From xen-devel-bounces@lists.xenproject.org Sat Apr 01 00:17:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 00:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517078.802123 (Exim 4.92) (envelope-from ) id 1piOvq-0000TO-43; Sat, 01 Apr 2023 00:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517078.802123; Sat, 01 Apr 2023 00:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piOvq-0000TH-0u; Sat, 01 Apr 2023 00:17:22 +0000 Received: by outflank-mailman (input) for mailman id 517078; Sat, 01 Apr 2023 00:17:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piOvn-0000T7-Vr; Sat, 01 Apr 2023 00:17:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piOvn-000769-Ua; Sat, 01 Apr 2023 00:17:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piOvn-00051M-B9; Sat, 01 Apr 2023 00:17:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piOvn-0005pD-Ah; Sat, 01 Apr 2023 00:17:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y/9+DwORxecq4Ne3hKBud5y8i4JQb4mLTXawEpL15Lw=; b=L9jfMX5zu7wio3KGD+zg9xcer4 GEEXTZae6k9z3ZZdHg2ZL70n3gRtH8K9RqeNwNh/DSsPA2FU+cFClRWIaGFr+JJSQ6RQfpunGVuER COdwMG1ybn3w/PY/n1dUdI4DOx+sBPm/kY4ija+aSUFbTIZ3RzTxRjmFpw62N9hRaSdk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180095: all pass - PUSHED X-Osstest-Versions-This: ovmf=eb6a74827200eedc81b8f45f332d6e9f3b3d2906 X-Osstest-Versions-That: ovmf=66f4b1b0d2e603c2b0a3f4149976cdc297a3606d From: osstest service owner Date: Sat, 01 Apr 2023 00:17:19 +0000 flight 180095 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180095/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf eb6a74827200eedc81b8f45f332d6e9f3b3d2906 baseline version: ovmf 66f4b1b0d2e603c2b0a3f4149976cdc297a3606d Last test of basis 180091 2023-03-31 17:40:47 Z 0 days Testing same since 180095 2023-03-31 21:10:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Albecki, Mateusz Mateusz Albecki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 66f4b1b0d2..eb6a748272 eb6a74827200eedc81b8f45f332d6e9f3b3d2906 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Apr 01 00:23:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 00:23:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517092.802164 (Exim 4.92) (envelope-from ) id 1piP1Z-0002Em-4N; Sat, 01 Apr 2023 00:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517092.802164; Sat, 01 Apr 2023 00:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piP1Z-0002Ed-0q; Sat, 01 Apr 2023 00:23:17 +0000 Received: by outflank-mailman (input) for mailman id 517092; Sat, 01 Apr 2023 00:23:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piP1X-0002EF-PG; Sat, 01 Apr 2023 00:23:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piP1X-0007Cr-NX; Sat, 01 Apr 2023 00:23:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piP1X-0005He-7R; Sat, 01 Apr 2023 00:23:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piP1X-0000Nj-6x; Sat, 01 Apr 2023 00:23:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+PqZPbf946pt3R4KbMh7ORmK4a0OXHF9xb1nidei2sY=; b=QqZFIfnfAYSYPFvmZsLddeeRpd fpDq6WBArkaMcwCLyQC/H4xNpS9egM1QzB7VK97v6Zp5ma4bcV3Hzyb6WjVKqYpDmyFTNMAty1tSk dFWmJatQbh0zXf7gpfXmDHiXTQIn46dmHsSIysUWGsSftsWr/Nv+zeaQK2uo1dIYIOxU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 180084: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=7758cd57e002c5096b2296ede67c59fca68724d7 X-Osstest-Versions-That: xen=3eac216e6e60860bbc030602c401d3ef8efce8d9 From: osstest service owner Date: Sat, 01 Apr 2023 00:23:15 +0000 flight 180084 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/180084/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 179869 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 179869 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 179869 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 179869 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 179869 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 179869 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 179869 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 179869 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 179869 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 7758cd57e002c5096b2296ede67c59fca68724d7 baseline version: xen 3eac216e6e60860bbc030602c401d3ef8efce8d9 Last test of basis 179869 2023-03-22 11:15:49 Z 9 days Testing same since 180084 2023-03-31 06:37:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3eac216e6e..7758cd57e0 7758cd57e002c5096b2296ede67c59fca68724d7 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Sat Apr 01 03:33:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 03:33:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517105.802192 (Exim 4.92) (envelope-from ) id 1piRzQ-0002Kb-O1; Sat, 01 Apr 2023 03:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517105.802192; Sat, 01 Apr 2023 03:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piRzQ-0002KD-Hl; Sat, 01 Apr 2023 03:33:16 +0000 Received: by outflank-mailman (input) for mailman id 517105; Sat, 01 Apr 2023 03:33:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piRzP-0002K3-5Q; Sat, 01 Apr 2023 03:33:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piRzP-0006qb-1z; Sat, 01 Apr 2023 03:33:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piRzO-0007ct-JL; Sat, 01 Apr 2023 03:33:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piRzO-0000xl-Ip; Sat, 01 Apr 2023 03:33:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bGttNYeg4tpFhyWMo8aXw7Bm5/7Jf5XskJBEDQYBhWg=; b=HhkxbCaHT0kzCYNydzhuWBImNG 1ZkFbr7k9k5+WO4MXEbDFMlovrexQrLXtRNVk4OOKHsgHjzrIAxjaSzO/1wkKZa9WTizbDLrGG/K3 xRbvabyGA1UJOxfGTK58RR8wToyTnh5tJPpHLEu8K24aVqOaTeEeS68osCjA/dzOUcg0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180099: all pass - PUSHED X-Osstest-Versions-This: ovmf=2f499c36db51980ad43fc6b578c7678a1720bd9c X-Osstest-Versions-That: ovmf=eb6a74827200eedc81b8f45f332d6e9f3b3d2906 From: osstest service owner Date: Sat, 01 Apr 2023 03:33:14 +0000 flight 180099 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180099/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2f499c36db51980ad43fc6b578c7678a1720bd9c baseline version: ovmf eb6a74827200eedc81b8f45f332d6e9f3b3d2906 Last test of basis 180095 2023-03-31 21:10:41 Z 0 days Testing same since 180099 2023-04-01 00:44:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Ray Ni Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git eb6a748272..2f499c36db 2f499c36db51980ad43fc6b578c7678a1720bd9c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Apr 01 05:43:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 05:43:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517111.802201 (Exim 4.92) (envelope-from ) id 1piU0g-0007Ec-UA; Sat, 01 Apr 2023 05:42:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517111.802201; Sat, 01 Apr 2023 05:42:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piU0g-0007EV-RV; Sat, 01 Apr 2023 05:42:42 +0000 Received: by outflank-mailman (input) for mailman id 517111; Sat, 01 Apr 2023 05:42:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piU0f-0007EL-RM; Sat, 01 Apr 2023 05:42:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piU0f-0001ry-Oy; Sat, 01 Apr 2023 05:42:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piU0f-0003Xp-Di; Sat, 01 Apr 2023 05:42:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piU0f-0005cH-DI; Sat, 01 Apr 2023 05:42:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/cpMKIZ1/NjyUFabX38tOt0vuWWogMjA76BUJDVGFEc=; b=WRAb7IiFMyReZBINyO7ZSbps7u ONGPRzaRXXOEXncQbR7CO5ivCyhAUKTNu/ohcTe0Kd9w0xBn1Aoza74bqPruzYtHhVfijEboLtIWC 94k9c/xl2mQ47raIK30JUe4ZXD4786+oVijZTws3iNcBFnd+ELcalJSDnKv4dI/xS9CE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180101: all pass - PUSHED X-Osstest-Versions-This: ovmf=67a6f414aa0e2a9cac965fcc6d83b6cbd6e893c0 X-Osstest-Versions-That: ovmf=2f499c36db51980ad43fc6b578c7678a1720bd9c From: osstest service owner Date: Sat, 01 Apr 2023 05:42:41 +0000 flight 180101 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180101/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 67a6f414aa0e2a9cac965fcc6d83b6cbd6e893c0 baseline version: ovmf 2f499c36db51980ad43fc6b578c7678a1720bd9c Last test of basis 180099 2023-04-01 00:44:02 Z 0 days Testing same since 180101 2023-04-01 03:35:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Lendacky, Thomas via groups.io Ray Ni Tom Lendacky jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2f499c36db..67a6f414aa 67a6f414aa0e2a9cac965fcc6d83b6cbd6e893c0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Apr 01 06:21:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 06:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517118.802212 (Exim 4.92) (envelope-from ) id 1piUbv-0003KA-Sr; Sat, 01 Apr 2023 06:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517118.802212; Sat, 01 Apr 2023 06:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUbv-0003K3-PG; Sat, 01 Apr 2023 06:21:11 +0000 Received: by outflank-mailman (input) for mailman id 517118; Sat, 01 Apr 2023 06:21:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUbu-0003Jt-Mm; Sat, 01 Apr 2023 06:21:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUbu-0002kQ-Jh; Sat, 01 Apr 2023 06:21:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUbu-0004j9-7O; Sat, 01 Apr 2023 06:21:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piUbu-0001xb-70; Sat, 01 Apr 2023 06:21:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qNwdL1YNq/AZ5YzHZqCjmU0GKyK+xl8l4MqIeM25Yt0=; b=Xw8iivLjhPL+59rwlEKBru/627 FGhBsKs+J6lXmL9jZ6RV6Po25w9+JWkNWnaxqXkZp4T8gwbttxzJHXqt52JWEs2LHplkKHm9svjNf Wq4HMPSXcoNxqks8nwd3VTgFhXUcPE+eukFw7HhAGxWxzWptT/BvEMj7a1WDKBJTlPqQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180088: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=efcd0ec14b0fe9ee0ee70277763b2d538d19238d X-Osstest-Versions-That: qemuu=f00506aeca2f6d92318967693f8da8c713c163f3 From: osstest service owner Date: Sat, 01 Apr 2023 06:21:10 +0000 flight 180088 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180088/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180057 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180057 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180057 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180057 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180057 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu efcd0ec14b0fe9ee0ee70277763b2d538d19238d baseline version: qemuu f00506aeca2f6d92318967693f8da8c713c163f3 Last test of basis 180057 2023-03-29 21:10:00 Z 2 days Testing same since 180088 2023-03-31 12:08:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Jiaxun Yang John Paul Adrian Glaubitz Laurent Vivier Nathan Chancellor Peter Maydell Philippe Mathieu-Daudé Titus Rwantare Zach van Rijn jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f00506aeca..efcd0ec14b efcd0ec14b0fe9ee0ee70277763b2d538d19238d -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Apr 01 06:37:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 06:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517124.802221 (Exim 4.92) (envelope-from ) id 1piUrE-0004vp-7a; Sat, 01 Apr 2023 06:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517124.802221; Sat, 01 Apr 2023 06:37:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUrE-0004vi-4o; Sat, 01 Apr 2023 06:37:00 +0000 Received: by outflank-mailman (input) for mailman id 517124; Sat, 01 Apr 2023 06:36:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUrD-0004vc-2s for xen-devel@lists.xenproject.org; Sat, 01 Apr 2023 06:36:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98a66c50-d057-11ed-b464-930f4c7d94ae; Sat, 01 Apr 2023 08:36:56 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 85D9F1F8B9; Sat, 1 Apr 2023 06:36:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 10300134FB; Sat, 1 Apr 2023 06:36:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AzBZAgfRJ2QGdwAAMHmgww (envelope-from ); Sat, 01 Apr 2023 06:36:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98a66c50-d057-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680331015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fwlqVEU+eay08IeeOOBfH65TQZ/XQ2nl5oYOkjj7LF0=; b=MLhGuHY3CSmYqr2j6E4yBaM89chPjWoCvhK+8ZTpJAQ4LqUfQfGaDbjFkxkQbSoUvT19LR UnX7QI+Uvo4rZ2gsQVxltDevlaQX+pUb0sZdTlyT42PQAUrR4sbpAQ0h0YQABpzteF3uPT KiNeYdvQLVNqIhlg1bIFWY1mzObA3oI= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Boris Ostrovsky , xen-devel@lists.xenproject.org, Andy Lutomirski , Peter Zijlstra Subject: [PATCH v5 00/15] x86/mtrr: fix handling with PAT but without MTRR Date: Sat, 1 Apr 2023 08:36:37 +0200 Message-Id: <20230401063652.23522-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series tries to fix the rather special case of PAT being available without having MTRRs (either due to CONFIG_MTRR being not set, or because the feature has been disabled e.g. by a hypervisor). The main use cases are Xen PV guests and SEV-SNP guests running under Hyper-V. Instead of trying to work around all the issues by adding if statements here and there, just try to use the complete available infrastructure by setting up a read-only MTRR state when needed. In the Xen PV case the current MTRR MSR values can be read from the hypervisor, while for the SEV-SNP case all needed is to set the default caching mode to "WB". I have added more cleanup which has been discussed when looking into the most recent failures. Note that I couldn't test the Hyper-V related change (patch 3). Running on bare metal and with Xen didn't show any problems with the series applied. It should be noted that patches 9+10 are replacing today's way to lookup the MTRR cache type for a memory region from looking at the MTRR register values to building a memory map with the cache types. This should make the lookup much faster and much easier to understand. Changes in V2: - replaced former patches 1+2 with new patches 1-4, avoiding especially the rather hacky approach of V1, while making all the MTRR type conflict tests available for the Xen PV case - updated patch 6 (was patch 4 in V1) Changes in V3: - dropped patch 5 of V2, as already applied - split patch 1 of V2 into 2 patches - new patches 6-10 - addressed comments Changes in V4: - addressed comments Changes in V5 - addressed comments - some other small fixes - new patches 3, 8 and 15 clone of "mtrr" Juergen Gross (15): x86/mtrr: split off physical address size calculation x86/mtrr: optimize mtrr_calc_physbits() x86/mtrr: replace some constants with defines x86/mtrr: support setting MTRR state for software defined MTRRs x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest x86/xen: set MTRR state when running as Xen PV initial domain x86/mtrr: replace vendor tests in MTRR code x86/mtrr: have only one set_mtrr() variant x86/mtrr: allocate mtrr_value array dynamically x86/mtrr: add get_effective_type() service function x86/mtrr: construct a memory map with cache modes x86/mtrr: use new cache_map in mtrr_type_lookup() x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID x86/mm: only check uniform after calling mtrr_type_lookup() x86/mtrr: remove unused code arch/x86/include/asm/mtrr.h | 44 ++- arch/x86/include/uapi/asm/mtrr.h | 6 +- arch/x86/kernel/cpu/mshyperv.c | 4 + arch/x86/kernel/cpu/mtrr/amd.c | 2 +- arch/x86/kernel/cpu/mtrr/centaur.c | 11 +- arch/x86/kernel/cpu/mtrr/cleanup.c | 6 +- arch/x86/kernel/cpu/mtrr/cyrix.c | 2 +- arch/x86/kernel/cpu/mtrr/generic.c | 578 +++++++++++++++++++---------- arch/x86/kernel/cpu/mtrr/mtrr.c | 146 ++++---- arch/x86/kernel/cpu/mtrr/mtrr.h | 7 +- arch/x86/kernel/setup.c | 2 + arch/x86/mm/pgtable.c | 24 +- arch/x86/xen/enlighten_pv.c | 52 +++ 13 files changed, 573 insertions(+), 311 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Apr 01 06:37:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 06:37:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517126.802232 (Exim 4.92) (envelope-from ) id 1piUrm-0005Oo-Fr; Sat, 01 Apr 2023 06:37:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517126.802232; Sat, 01 Apr 2023 06:37:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUrm-0005Og-Ci; Sat, 01 Apr 2023 06:37:34 +0000 Received: by outflank-mailman (input) for mailman id 517126; Sat, 01 Apr 2023 06:37:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piUrk-0005OF-GR for xen-devel@lists.xenproject.org; Sat, 01 Apr 2023 06:37:32 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acec79e9-d057-11ed-b464-930f4c7d94ae; Sat, 01 Apr 2023 08:37:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC0A921A6E; Sat, 1 Apr 2023 06:37:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 75458134FB; Sat, 1 Apr 2023 06:37:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2J9VGynRJ2RUdwAAMHmgww (envelope-from ); Sat, 01 Apr 2023 06:37:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acec79e9-d057-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680331049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BBSVwIjfh8GqolcmguccgHbT9FXyjh+eQq+oIFQmSnw=; b=ajS/iUmKoQdV4uRxzu4IIGIVP4xHuK0N0mFHi+m4Vq9E4sezhaed9RpDBa3+M5YQFdJCaq gZbqX3tuVGAXhzB3za13DOYXPeqgOYoxxl+pC7dSY9e8MohVhKnXH+ccd+fRqFRO43AjOz n25N0ONmdBS7BJtWgUpIwdIAaFHoHiM= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH v5 06/15] x86/xen: set MTRR state when running as Xen PV initial domain Date: Sat, 1 Apr 2023 08:36:43 +0200 Message-Id: <20230401063652.23522-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230401063652.23522-1-jgross@suse.com> References: <20230401063652.23522-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When running as Xen PV initial domain (aka dom0), MTRRs are disabled by the hypervisor, but the system should nevertheless use correct cache memory types. This has always kind of worked, as disabled MTRRs resulted in disabled PAT, too, so that the kernel avoided code paths resulting in inconsistencies. This bypassed all of the sanity checks the kernel is doing with enabled MTRRs in order to avoid memory mappings with conflicting memory types. This has been changed recently, leading to PAT being accepted to be enabled, while MTRRs stayed disabled. The result is that mtrr_type_lookup() no longer is accepting all memory type requests, but started to return WB even if UC- was requested. This led to driver failures during initialization of some devices. In reality MTRRs are still in effect, but they are under complete control of the Xen hypervisor. It is possible, however, to retrieve the MTRR settings from the hypervisor. In order to fix those problems, overwrite the MTRR state via mtrr_overwrite_state() with the MTRR data from the hypervisor, if the system is running as a Xen dom0. Fixes: 72cbc8f04fe2 ("x86/PAT: Have pat_enabled() properly reflect state when running on Xen") Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- V2: - new patch V3: - move the call of mtrr_overwrite_state() to xen_pv_init_platform() V4: - only call mtrr_overwrite_state() if any MTRR got from Xen (Boris Ostrovsky) --- arch/x86/xen/enlighten_pv.c | 52 +++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 093b78c8bbec..fdaea02ab5ab 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #include #include @@ -119,6 +120,54 @@ static int __init parse_xen_msr_safe(char *str) } early_param("xen_msr_safe", parse_xen_msr_safe); +/* Get MTRR settings from Xen and put them into mtrr_state. */ +static void __init xen_set_mtrr_data(void) +{ +#ifdef CONFIG_MTRR + struct xen_platform_op op = { + .cmd = XENPF_read_memtype, + .interface_version = XENPF_INTERFACE_VERSION, + }; + unsigned int reg; + unsigned long mask; + uint32_t eax, width; + static struct mtrr_var_range var[MTRR_MAX_VAR_RANGES] __initdata; + + /* Get physical address width (only 64-bit cpus supported). */ + width = 36; + eax = cpuid_eax(0x80000000); + if ((eax >> 16) == 0x8000 && eax >= 0x80000008) { + eax = cpuid_eax(0x80000008); + width = eax & 0xff; + } + + for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { + op.u.read_memtype.reg = reg; + if (HYPERVISOR_platform_op(&op)) + break; + + /* + * Only called in dom0, which has all RAM PFNs mapped at + * RAM MFNs, and all PCI space etc. is identity mapped. + * This means we can treat MFN == PFN regarding MTRR settings. + */ + var[reg].base_lo = op.u.read_memtype.type; + var[reg].base_lo |= op.u.read_memtype.mfn << PAGE_SHIFT; + var[reg].base_hi = op.u.read_memtype.mfn >> (32 - PAGE_SHIFT); + mask = ~((op.u.read_memtype.nr_mfns << PAGE_SHIFT) - 1); + mask &= (1UL << width) - 1; + if (mask) + mask |= MTRR_MASK_VALID; + var[reg].mask_lo = mask; + var[reg].mask_hi = mask >> 32; + } + + /* Only overwrite MTRR state if any MTRR could be got from Xen. */ + if (reg) + mtrr_overwrite_state(var, reg, MTRR_TYPE_UNCACHABLE); +#endif +} + static void __init xen_pv_init_platform(void) { /* PV guests can't operate virtio devices without grants. */ @@ -135,6 +184,9 @@ static void __init xen_pv_init_platform(void) /* pvclock is in shared info area */ xen_init_time_ops(); + + if (xen_initial_domain()) + xen_set_mtrr_data(); } static void __init xen_pv_guest_late_init(void) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Apr 01 12:04:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 12:04:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517145.802242 (Exim 4.92) (envelope-from ) id 1piZxP-0004TY-PU; Sat, 01 Apr 2023 12:03:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517145.802242; Sat, 01 Apr 2023 12:03:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piZxP-0004TR-MV; Sat, 01 Apr 2023 12:03:43 +0000 Received: by outflank-mailman (input) for mailman id 517145; Sat, 01 Apr 2023 12:03:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piZxO-0004TH-9z; Sat, 01 Apr 2023 12:03:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piZxN-0002HU-Lz; Sat, 01 Apr 2023 12:03:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piZxN-0004K0-7L; Sat, 01 Apr 2023 12:03:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piZxN-0002qa-6w; Sat, 01 Apr 2023 12:03:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pawRJLIzYdZWALZWGxQzinqL2TxXv/FjxJVI6HqfdO8=; b=QfISLqBMVEqnoLOngr0izvdZ6V xufyKJTVBDxe6CfMHjhPzwQAgecLB1BCdrmbe0iGtI2NK5YavpfIx+Q8t7oisZ40ioDK/a4dFLhmf JrH4EXQuvlulrcSQBqyjvMe7QjeSX7R7W3ebTGfDI8/T+sgSXBK7vkcbXtRxaZit6dsM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180093: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=5a57b48fdfcb1e196292665d87fac46180344f8a X-Osstest-Versions-That: linux=62bad54b26db8bc98e28749cd76b2d890edb4258 From: osstest service owner Date: Sat, 01 Apr 2023 12:03:41 +0000 flight 180093 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180093/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180081 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180081 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180081 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180081 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180081 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 5a57b48fdfcb1e196292665d87fac46180344f8a baseline version: linux 62bad54b26db8bc98e28749cd76b2d890edb4258 Last test of basis 180081 2023-03-31 05:40:32 Z 1 days Testing same since 180093 2023-03-31 20:41:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alyssa Ross Bjorn Helgaas Christoph Hellwig Christophe JAILLET Conor Dooley David Arcari David E. Box Hans de Goede Jens Axboe Juraj Pecigos Linus Torvalds Mark Brown Palmer Dabbelt Pavel Begunkov Pierre Asselin Rafael J. Wysocki Rajvi Jingar Sagi Grimberg Song Liu Srinivas Pandruvada Thomas Bogendoerfer Thomas Weißschuh weiliang1503 Yanjun Zhang Yoshihiro Shimoda Yu Kuai Álvaro Fernández Rojas jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 62bad54b26db..5a57b48fdfcb 5a57b48fdfcb1e196292665d87fac46180344f8a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Apr 01 14:51:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 14:51:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517156.802252 (Exim 4.92) (envelope-from ) id 1picZi-0004I9-R6; Sat, 01 Apr 2023 14:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517156.802252; Sat, 01 Apr 2023 14:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1picZi-0004I2-Nz; Sat, 01 Apr 2023 14:51:26 +0000 Received: by outflank-mailman (input) for mailman id 517156; Sat, 01 Apr 2023 14:51:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1picZh-0004Hs-6s; Sat, 01 Apr 2023 14:51:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1picZg-0006Aa-Va; Sat, 01 Apr 2023 14:51:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1picZg-0002sN-Fd; Sat, 01 Apr 2023 14:51:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1picZg-0006wp-FA; Sat, 01 Apr 2023 14:51:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vCi06dSwS+d4DBuc2qFuQMH+WfY+TYSEAjYP5ee0eXA=; b=pQskkCLlg9wAVnIV+riDcMxt6F s3yVxOQ0Ro5c9WIz3j2DEBwtqik5FwgXn8G/GjLjjymIsYb3zSHbwmv8aWaaiBojRoiK8Nkn0UTRb 3CvURdi9nU+70/vbQ1ViFPdSQ8dKYlJfdMt1MBuIsHSx8uS10lra8kWFxOJoHjenSqJg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180098: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb X-Osstest-Versions-That: xen=eef4608fe71feddb5fea86678cf3acaf84d10fd2 From: osstest service owner Date: Sat, 01 Apr 2023 14:51:24 +0000 flight 180098 xen-unstable real [real] flight 180104 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180098/ http://logs.test-lab.xenproject.org/osstest/logs/180104/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180104-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180062 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180062 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180062 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180062 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180062 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180062 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180062 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180062 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180062 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb baseline version: xen eef4608fe71feddb5fea86678cf3acaf84d10fd2 Last test of basis 180062 2023-03-30 05:16:10 Z 2 days Failing since 180073 2023-03-30 20:38:51 Z 1 days 3 attempts Testing same since 180098 2023-03-31 23:09:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ayan Kumar Halder Christian Lindig Jan Beulich Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git eef4608fe7..d6e0b4c41a d6e0b4c41a38655ade7ecb566e8b2961282769fb -> master From xen-devel-bounces@lists.xenproject.org Sat Apr 01 18:34:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 18:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517171.802286 (Exim 4.92) (envelope-from ) id 1pig3R-0002Dz-U3; Sat, 01 Apr 2023 18:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517171.802286; Sat, 01 Apr 2023 18:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pig3R-0002Dr-R1; Sat, 01 Apr 2023 18:34:21 +0000 Received: by outflank-mailman (input) for mailman id 517171; Sat, 01 Apr 2023 18:34:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pig3Q-0002Dh-CT; Sat, 01 Apr 2023 18:34:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pig3Q-0003JE-9i; Sat, 01 Apr 2023 18:34:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pig3P-0005TD-Pp; Sat, 01 Apr 2023 18:34:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pig3P-0005Oq-P5; Sat, 01 Apr 2023 18:34:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vmJ/mrxAtETkvtbEGndNmPrBzF1Sd/I6f1TIhhvYF28=; b=meTo3fFp+nUm5PNzEvelPme9XY q1Ed4ipDYeQ9L8YkPtrYkNWGB78LAQkcbBlwAVqaJjb1rLEIooHMqlFcikdcsvgPY8PwXpH8jqGdM d/hm+cfV4kKRlsKtT9eZLgtwMaJpcGHxC+7rB9F4PgU1LdHBWfyqwtKgrOJfLK19oJao=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180102: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=ac8e8ef24e3be018ec25f961033fed6c841bad02 X-Osstest-Versions-That: libvirt=2c6b5a84257379e516ca1999782dca88dfd8a9de From: osstest service owner Date: Sat, 01 Apr 2023 18:34:19 +0000 flight 180102 libvirt real [real] flight 180106 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180102/ http://logs.test-lab.xenproject.org/osstest/logs/180106/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180106-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt ac8e8ef24e3be018ec25f961033fed6c841bad02 baseline version: libvirt 2c6b5a84257379e516ca1999782dca88dfd8a9de Last test of basis 180061 2023-03-30 04:20:17 Z 2 days Failing since 180080 2023-03-31 04:21:50 Z 1 days 2 attempts Testing same since 180102 2023-04-01 04:20:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Pavel Borecki Peter Krempa 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 2c6b5a8425..ac8e8ef24e ac8e8ef24e3be018ec25f961033fed6c841bad02 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Apr 01 22:00:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 22:00:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517205.802312 (Exim 4.92) (envelope-from ) id 1pijHB-0007CB-3C; Sat, 01 Apr 2023 22:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517205.802312; Sat, 01 Apr 2023 22:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pijHB-0007C4-0b; Sat, 01 Apr 2023 22:00:45 +0000 Received: by outflank-mailman (input) for mailman id 517205; Sat, 01 Apr 2023 22:00:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pijH9-0007Bu-QW; Sat, 01 Apr 2023 22:00:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pijH9-0008SW-Ml; Sat, 01 Apr 2023 22:00:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pijH9-0003Hp-43; Sat, 01 Apr 2023 22:00:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pijH9-0006uM-3Z; Sat, 01 Apr 2023 22:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JYN/ZPe6KCf+8w4JVTDl2IXoPLNaO80KmtZ4P2ZNBm0=; b=0AJj/pVSkxGwAzqW9KH9UAMZz8 xfD4YiTk0ZlDhJ2FTol9kCmfNaofbCbDexP34V540S2nWD+O3FwPOqu+oNzDxCk49eBtRkXjP5hR2 BE8QCU6xGo9Dq8iLabUMpLb1If5Mu8rbjFaYVlme0x+INzQ/M9p6XTtcwAUwUSryUcEk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180103: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=7b50567bdcad8925ca1e075feb7171c12015afd1 X-Osstest-Versions-That: linux=5a57b48fdfcb1e196292665d87fac46180344f8a From: osstest service owner Date: Sat, 01 Apr 2023 22:00:43 +0000 flight 180103 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180103/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180093 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180093 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180093 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180093 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180093 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 7b50567bdcad8925ca1e075feb7171c12015afd1 baseline version: linux 5a57b48fdfcb1e196292665d87fac46180344f8a Last test of basis 180093 2023-03-31 20:41:50 Z 1 days Testing same since 180103 2023-04-01 12:08:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anna Schumaker Arnd Bergmann Linus Torvalds Siddharth Kawar Siddharth Rajendra Kawar Trond Myklebust jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 5a57b48fdfcb..7b50567bdcad 7b50567bdcad8925ca1e075feb7171c12015afd1 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Apr 01 22:37:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Apr 2023 22:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517210.802322 (Exim 4.92) (envelope-from ) id 1pijqA-0002GR-T2; Sat, 01 Apr 2023 22:36:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517210.802322; Sat, 01 Apr 2023 22:36:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pijqA-0002GK-QU; Sat, 01 Apr 2023 22:36:54 +0000 Received: by outflank-mailman (input) for mailman id 517210; Sat, 01 Apr 2023 22:36:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pijqA-0002GE-0L for xen-devel@lists.xenproject.org; Sat, 01 Apr 2023 22:36:54 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b27e29a3-d0dd-11ed-85db-49a42c6b2330; Sun, 02 Apr 2023 00:36:52 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id ew6so103437853edb.7 for ; Sat, 01 Apr 2023 15:36:52 -0700 (PDT) Received: from [127.0.0.1] (dynamic-077-013-027-219.77.13.pool.telefonica.de. [77.13.27.219]) by smtp.gmail.com with ESMTPSA id bq18-20020a056402215200b00501c2a9e16dsm2525599edb.74.2023.04.01.15.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 15:36:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b27e29a3-d0dd-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680388611; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3mcXjgUWbrap77dni2Kc4rFFZA3pvAccTjwmsDr8bxU=; b=mEteHCJVGbFfX6tRGM1s1+VkgCn+hxBW1ZPMXM8bHo1lDikF/amdVWjUftAXcShM8a QSUCelFL9ah0+AXtIsc17IFeWQH3I9hozzG5sbBDkZn+ElBcPC9HegHKvD+3vyTOjND3 ugVPymLueNtOS+uB1+vL9uTzj6FXIW+y9HEhS2zqCKO91NvGVU76xY7V5+tEJG7NKrZj Zvoov0pcWYrLUjrLk3iPcEgyiUbVABU0T3DFZfzBGIhRfiIIfV26WtEYaypcV8qu1J8r HEWMBS+85UsEL27hFh76IGPqOkyEEeNSgnno6LLxlQm/ygtzQTIaNvuKHJa8j26iRqFv 04YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680388611; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3mcXjgUWbrap77dni2Kc4rFFZA3pvAccTjwmsDr8bxU=; b=FZYGlUXaMbnLhtyNoFpBG5v/G5swMeapPlWR6PbLVts9a1hmov3qVRv+IoReI8Vkx7 Q8tvnoZ9QC9wd/Ln/iRoOijaPLxQffyDMb5EWkD8idsAxO1UQIm5wjIAb/GwzU9BmkyW joshiyLdPe/xNAdLagXFOWMb91LtnjH1aQ3HnSUTqS1ipA/6m75g/CFwoyklTTNhdOl9 AeH8Rt197Zf5MVuJ3d8mk79oxIvmmcsPuiOr65CW5QGNZSAXDB4as2MVBgnHnZ4iX1uy 1xfB1dyvdHJLKGpTS9spajNfGWBUCFSWY3kg/+8PY4WUDx/z+cN6VE8r1SGz00RBR1xF owkw== X-Gm-Message-State: AAQBX9cpuOLnZ+x5M+qWl/75srGa2DR3b0hIEZjZRiVoMw9Bdrd0KVsF tGXAIsiX+NH53YX923WuMg4= X-Google-Smtp-Source: AKy350ZBAQ0NclZYRHIFZo8U4NApWMVwMHMu7y4terrO7HGjAO6fxbeX8o8y5iqHZuYoEBhpoQdpEA== X-Received: by 2002:a17:907:2077:b0:92f:fbac:69c4 with SMTP id qp23-20020a170907207700b0092ffbac69c4mr30391166ejb.56.1680388611436; Sat, 01 Apr 2023 15:36:51 -0700 (PDT) Date: Sat, 01 Apr 2023 22:36:45 +0000 From: Bernhard Beschow To: Anthony PERARD CC: qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , David Woodhouse , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Eduardo Habkost , Paul Durrant , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefano Stabellini , Richard Henderson , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Chuck Zmudzinski Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_2/6=5D_hw/isa/piix3=3A_Reuse?= =?US-ASCII?Q?_piix3=5Frealize=28=29_in_piix3=5Fxen=5Frealize=28=29?= In-Reply-To: References: <20230312120221.99183-1-shentey@gmail.com> <20230312120221.99183-3-shentey@gmail.com> Message-ID: <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 30=2E M=C3=A4rz 2023 13:00:25 UTC schrieb Anthony PERARD : >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: >> This is a preparational patch for the next one to make the following >> more obvious: >>=20 >> First, pci_bus_irqs() is now called twice in case of Xen where the >> second call overrides the pci_set_irq_fn with the Xen variant=2E > >pci_bus_irqs() does allocates pci_bus->irq_count, so the second call in >piix3_xen_realize() will leak `pci_bus->irq_count`=2E Could you look if >pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs() >call, or maybe some other way to avoid the leak? Thanks for catching this! I'll post a v4=2E I think the most fool-proof way to fix this is to free irq_count just befo= re the assignment=2E pci_bus_irqs_cleanup() would then have to NULL the att= ribute such that pci_bus_irqs() can be called afterwards=2E BTW: I tried running qemu-system-x86_64 with PIIX4 rather than PIIX3 as Xe= n guest with my pc-piix4 branch without success=2E This branch essentially = just provides slightly different PCI IDs for PIIX=2E Does xl or something e= lse in Xen check these? If not then this means I'm still missing something= =2E Under KVM this branch works just fine=2E Any idea? Thanks, Bernhard > >> Second, pci_bus_set_route_irq_fn() is now also called in Xen mode=2E >>=20 >> Signed-off-by: Bernhard Beschow >> Reviewed-by: Michael S=2E Tsirkin > >Beside the leak which I think can happen only once, patch is fine: >Reviewed-by: Anthony PERARD > >Thanks, > From xen-devel-bounces@lists.xenproject.org Sun Apr 02 02:14:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 02:14:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517214.802333 (Exim 4.92) (envelope-from ) id 1pinEv-0000GD-5O; Sun, 02 Apr 2023 02:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517214.802333; Sun, 02 Apr 2023 02:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinEu-0000Fp-VI; Sun, 02 Apr 2023 02:14:40 +0000 Received: by outflank-mailman (input) for mailman id 517214; Sun, 02 Apr 2023 02:14:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinEu-0000Ff-0z; Sun, 02 Apr 2023 02:14:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinEt-0007lI-VA; Sun, 02 Apr 2023 02:14:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinEs-0004MT-F4; Sun, 02 Apr 2023 02:14:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pinEs-0005Jp-Ec; Sun, 02 Apr 2023 02:14:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i8Wpk8p17rn95gd+WONfEn5dMxOgMOWe7FZT2WMcxAc=; b=NG9KiuJwO+azkk3QNFLkvFNPLj 6eu3VCATJIVP7zhOkRBYPzKFm9BNnWABH/sz5esOSRwk0yHgo+Pwca1e0UL7uqmABTNzft/RabNGY HikzGaVM+KYEyRFQUU4rwS2vySjkJtfPhgHNbVZM5NogZIKs/dMNY+AnY4FE/3t/QXDk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180108: all pass - PUSHED X-Osstest-Versions-This: ovmf=4ca4d2b9df27f9c58009d623678ac911c544d36c X-Osstest-Versions-That: ovmf=67a6f414aa0e2a9cac965fcc6d83b6cbd6e893c0 From: osstest service owner Date: Sun, 02 Apr 2023 02:14:38 +0000 flight 180108 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180108/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4ca4d2b9df27f9c58009d623678ac911c544d36c baseline version: ovmf 67a6f414aa0e2a9cac965fcc6d83b6cbd6e893c0 Last test of basis 180101 2023-04-01 03:35:21 Z 0 days Testing same since 180108 2023-04-01 23:42:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Marvin Häuser Tom Lendacky jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 67a6f414aa..4ca4d2b9df 4ca4d2b9df27f9c58009d623678ac911c544d36c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Apr 02 02:22:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 02:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517219.802343 (Exim 4.92) (envelope-from ) id 1pinMe-0001jc-Va; Sun, 02 Apr 2023 02:22:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517219.802343; Sun, 02 Apr 2023 02:22:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinMe-0001jU-PS; Sun, 02 Apr 2023 02:22:40 +0000 Received: by outflank-mailman (input) for mailman id 517219; Sun, 02 Apr 2023 02:22:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinMd-0001jI-OV; Sun, 02 Apr 2023 02:22:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinMd-000849-KX; Sun, 02 Apr 2023 02:22:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pinMc-0004X3-Tj; Sun, 02 Apr 2023 02:22:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pinMc-00075v-T6; Sun, 02 Apr 2023 02:22:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MS3/z69NMjX20P24HtQGzFPG5o8SUI6o/Euvj+aImec=; b=Gm8YzoEjxWAZoYyyXbbfzJK2W9 DA506eANmzNgi+nfYytDf+P49jxyQjl3mCruC/U3jAMIWXK84hfAUHH75zpI0xgAUITyeQq2Cl4pg 2kTyH4dPRBWpUR3FDrV292RSHeIsDRYLfYL0bkDMzNamZVwQia57jp830RNYNZng1t00=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180105: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb X-Osstest-Versions-That: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb From: osstest service owner Date: Sun, 02 Apr 2023 02:22:38 +0000 flight 180105 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180105/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 180098 pass in 180105 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180098 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180098 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180098 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180098 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180098 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180098 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180098 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180098 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180098 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180098 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 180098 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb baseline version: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb Last test of basis 180105 2023-04-01 14:53:47 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Apr 02 04:32:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 04:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517224.802353 (Exim 4.92) (envelope-from ) id 1pipOA-0006Vr-22; Sun, 02 Apr 2023 04:32:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517224.802353; Sun, 02 Apr 2023 04:32:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pipO9-0006Vj-Sn; Sun, 02 Apr 2023 04:32:21 +0000 Received: by outflank-mailman (input) for mailman id 517224; Sun, 02 Apr 2023 04:32:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pipO8-0006VZ-Ht; Sun, 02 Apr 2023 04:32:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pipO8-0002u1-Dy; Sun, 02 Apr 2023 04:32:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pipO7-0008Tz-Aq; Sun, 02 Apr 2023 04:32:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pipO7-0005tZ-7H; Sun, 02 Apr 2023 04:32:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OkKk8jCOkGXMYOPpNEsNlwK5QDNhHFnUuwU7TIBN/n8=; b=gSjr5ZLLPfQpAmb4dUon01NvGs VFbRGkvWIiKFpRR8wvVB8ydD2ak6toXKbos7f01MMBQNFsZEW1yI43NIZbXIxP0ds5tW6kWBXJAdy thDWQjoOlRoR/v4DUvjbjDHFMfmwDgtyLh3PwuNXqmINdEYlJmcA5k6cQYu460TeEjH0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180109: all pass - PUSHED X-Osstest-Versions-This: ovmf=b4af23aaab8a44341e43713a71cbebf23df2c27d X-Osstest-Versions-That: ovmf=4ca4d2b9df27f9c58009d623678ac911c544d36c From: osstest service owner Date: Sun, 02 Apr 2023 04:32:19 +0000 flight 180109 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180109/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b4af23aaab8a44341e43713a71cbebf23df2c27d baseline version: ovmf 4ca4d2b9df27f9c58009d623678ac911c544d36c Last test of basis 180108 2023-04-01 23:42:19 Z 0 days Testing same since 180109 2023-04-02 02:15:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4ca4d2b9df..b4af23aaab b4af23aaab8a44341e43713a71cbebf23df2c27d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Apr 02 07:14:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 07:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517232.802363 (Exim 4.92) (envelope-from ) id 1piruL-0005vx-5N; Sun, 02 Apr 2023 07:13:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517232.802363; Sun, 02 Apr 2023 07:13:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piruL-0005vq-2m; Sun, 02 Apr 2023 07:13:45 +0000 Received: by outflank-mailman (input) for mailman id 517232; Sun, 02 Apr 2023 07:13:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piruJ-0005vg-8q; Sun, 02 Apr 2023 07:13:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piruJ-0007Ah-6w; Sun, 02 Apr 2023 07:13:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piruI-0001m3-Nw; Sun, 02 Apr 2023 07:13:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piruI-0001Mq-NX; Sun, 02 Apr 2023 07:13:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GR17R9eJbS8LKlWxOJKbPKkm5REFoWqCm1j8utK1gno=; b=oC8TE3aXqA4Hmte1DxpHVaCou/ ueBGyjPU26UpjcAFOLdGlBimsOVHsoZ+p1FxoeJJzraEvnq6rUHONS8mp9B9Xv08ClQT4r+ajk5zo 11aKsYQ5FTopdQi2X9h4R96RonOZWUe52Ai1IlIeu52u/nkXBkvwkvVn6sQhK2CTlBP4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180112: all pass - PUSHED X-Osstest-Versions-This: ovmf=fc00ff286a541c047b7d343e66ec10890b80d3ea X-Osstest-Versions-That: ovmf=b4af23aaab8a44341e43713a71cbebf23df2c27d From: osstest service owner Date: Sun, 02 Apr 2023 07:13:42 +0000 flight 180112 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180112/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fc00ff286a541c047b7d343e66ec10890b80d3ea baseline version: ovmf b4af23aaab8a44341e43713a71cbebf23df2c27d Last test of basis 180109 2023-04-02 02:15:13 Z 0 days Testing same since 180112 2023-04-02 04:43:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b4af23aaab..fc00ff286a fc00ff286a541c047b7d343e66ec10890b80d3ea -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Apr 02 07:42:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 07:42:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517239.802373 (Exim 4.92) (envelope-from ) id 1pisM2-0001VC-F7; Sun, 02 Apr 2023 07:42:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517239.802373; Sun, 02 Apr 2023 07:42:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pisM2-0001V5-Bq; Sun, 02 Apr 2023 07:42:22 +0000 Received: by outflank-mailman (input) for mailman id 517239; Sun, 02 Apr 2023 07:42:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pisM0-0001Uv-KA; Sun, 02 Apr 2023 07:42:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pisM0-0007tY-GV; Sun, 02 Apr 2023 07:42:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pisLz-0002a3-Ud; Sun, 02 Apr 2023 07:42:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pisLz-0001uh-U8; Sun, 02 Apr 2023 07:42:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EFSTj7x+FjD3timnUyBccbGZkgoXFnSJ4Gh5z5MjQYo=; b=29vdAcUuF92uEwFsjlkanW8nr1 JXxzANfmxQF6kZUJCDClc9pu84OcFWhEvzXFCsOVCKer7JliTL0x3HTbD1MBdklj0/W5tTvP/wuXw e+YzByg4FMgOlmlpxPoXJBxK7K8ulMiYG/1aphV6jh/yie09wSb83r6BeD4VNJ08Rb5o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180107: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=00c7b5f4ddc5b346df62b757ec73f9357bb452af X-Osstest-Versions-That: linux=7b50567bdcad8925ca1e075feb7171c12015afd1 From: osstest service owner Date: Sun, 02 Apr 2023 07:42:19 +0000 flight 180107 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180107/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180103 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180103 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180103 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180103 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180103 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 00c7b5f4ddc5b346df62b757ec73f9357bb452af baseline version: linux 7b50567bdcad8925ca1e075feb7171c12015afd1 Last test of basis 180103 2023-04-01 12:08:07 Z 0 days Testing same since 180107 2023-04-01 22:11:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arınç ÜNAL Ben Hutchings Claudiu Beznea # on SAMA7G5 Daniel Golle Dario Binacchi Dmitry Torokhov Hans de Goede Horatiu Vultur Jacob Pan Jason A. Donenfeld Jason Gunthorpe Joerg Roedel Johan Hovold Jonathan Denose Jonathan Denose Kan Liang Kevin Locke Kornel Dulęba Krzysztof Kozlowski Linus Torvalds Linus Walleij Lu Baolu Marek Szyprowski Masahiro Yamada Matthias Benkmann Mirsad Goran Todorovac msizanoen Niklas Schnelle Peter Oberparleiter Randy Dunlap Werner Sembach jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 7b50567bdcad..00c7b5f4ddc5 00c7b5f4ddc5b346df62b757ec73f9357bb452af -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Apr 02 12:27:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 12:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517261.802383 (Exim 4.92) (envelope-from ) id 1piwo4-0003v3-Uy; Sun, 02 Apr 2023 12:27:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517261.802383; Sun, 02 Apr 2023 12:27:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piwo4-0003uw-Ql; Sun, 02 Apr 2023 12:27:36 +0000 Received: by outflank-mailman (input) for mailman id 517261; Sun, 02 Apr 2023 12:27:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piwo3-0003um-Ne; Sun, 02 Apr 2023 12:27:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piwo3-0006Vk-Kt; Sun, 02 Apr 2023 12:27:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piwo3-0001aq-9a; Sun, 02 Apr 2023 12:27:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piwo3-0004Oy-9B; Sun, 02 Apr 2023 12:27:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/cBpI/4E6k6V/qUkmQWocwkX5ClhcjfWBFPfX4qFeQE=; b=VCp92ilZyt8O5k/eIU4M2AD93k Ul3mv1CnOFjsKRz5XOCdfvcVlvx+DLaaFLYpl1KJ3zCDvhhpVGvE0rD71hRFyliypGhbB4e+z5BZC 94h+xi28sIxVEjtm5NGMgsWWBmZPAEUyo/dTcxgwuxrFbkrX5lRvSXHRcOKKc1kGfm6E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180110: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb X-Osstest-Versions-That: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb From: osstest service owner Date: Sun, 02 Apr 2023 12:27:35 +0000 flight 180110 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180110/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180105 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180105 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180105 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180105 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180105 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180105 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180105 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180105 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180105 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb baseline version: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb Last test of basis 180110 2023-04-02 02:26:14 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Apr 02 14:51:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 14:51:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517274.802392 (Exim 4.92) (envelope-from ) id 1piz3I-0001bH-1y; Sun, 02 Apr 2023 14:51:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517274.802392; Sun, 02 Apr 2023 14:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piz3H-0001bA-Ve; Sun, 02 Apr 2023 14:51:27 +0000 Received: by outflank-mailman (input) for mailman id 517274; Sun, 02 Apr 2023 14:51:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piz3G-0001ax-Qe; Sun, 02 Apr 2023 14:51:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piz3G-0001nD-Ij; Sun, 02 Apr 2023 14:51:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1piz3G-0004qz-3O; Sun, 02 Apr 2023 14:51:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1piz3G-0005nm-2x; Sun, 02 Apr 2023 14:51:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TNn5vtC4ToGuGqyrVZ0zKZE88Z3HMhTGO119drbis84=; b=OBxLq/8S/cSSHVA+6NblknYJVk yI1jIP7p7UDrCqFf7eW0Rhwh8fkNir58hofx68VsJvrrLFSQ4Ad0LoyJHQVp3IUZZfZ8MHN24IIIJ CwUTiqkkfNUO+P++rsZ8DiLXONnjyCi/OcIMNyXsXTA9HvYuIj6Ucmv3aYCxuwpyNHyo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180111: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=145886e36dba23ed3756ab9c52b2ac77c506943f X-Osstest-Versions-That: libvirt=ac8e8ef24e3be018ec25f961033fed6c841bad02 From: osstest service owner Date: Sun, 02 Apr 2023 14:51:26 +0000 flight 180111 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180111/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 145886e36dba23ed3756ab9c52b2ac77c506943f baseline version: libvirt ac8e8ef24e3be018ec25f961033fed6c841bad02 Last test of basis 180102 2023-04-01 04:20:15 Z 1 days Testing same since 180111 2023-04-02 04:23:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Fedora Weblate Translation Jiri Denemark Pavel Borecki Weblate 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git ac8e8ef24e..145886e36d 145886e36dba23ed3756ab9c52b2ac77c506943f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Apr 02 23:16:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Apr 2023 23:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517288.802402 (Exim 4.92) (envelope-from ) id 1pj6vZ-000827-Dk; Sun, 02 Apr 2023 23:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517288.802402; Sun, 02 Apr 2023 23:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj6vZ-000820-B8; Sun, 02 Apr 2023 23:16:01 +0000 Received: by outflank-mailman (input) for mailman id 517288; Sun, 02 Apr 2023 23:15:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj6vW-00081r-V8 for xen-devel@lists.xenproject.org; Sun, 02 Apr 2023 23:15:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 509a565c-d1ac-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 01:15:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A0C660ADB; Sun, 2 Apr 2023 23:15:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C052C433EF; Sun, 2 Apr 2023 23:15:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 509a565c-d1ac-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680477352; bh=y9VtgQP6ZdJ/r0jZwGmf39KrAbBONFdJ6pJJcZhU74A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=a2MFJ3H6Gn1tjnpI5LBMv2hkvh5b6kihL2UQ0j9jVZfNOOqgunxgrbtWuoTFhghga XIT1v0csT9NcPZgvAxJsbdax32G8BMUZN/W9vrkfJs5GVHDf5e+BJCxNOjxKEcH0f8 LGM5nHo7YHx264blzlCuAct1O/h1TyB12N40PQS3v2LDE6CuFa3HGArveTV4acpX65 /nkwDz3zxB5xqiGn7IwIc2uk1gPRW5nJfG1fZDPraEHYhHA1oxognGQ5OJ9DF+8nv0 O0CK9zgxZDwsST2fWJCJpdHUlauFpQGke5SGYqZbAHLjdbqCJNy1n7jcvIPxRDNYka jW/nrh3oxGQIA== Date: Sun, 2 Apr 2023 16:15:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Oleksii Kurochko , xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h In-Reply-To: <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> Message-ID: References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 31 Mar 2023, Julien Grall wrote: > Hi Oleksii, > > I was going to ack the patch but then I spotted something that would want some > clarification. > > On 29/03/2023 11:50, Oleksii Kurochko wrote: > > diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h > > index cacaf014ab..3fb0471a9b 100644 > > --- a/xen/arch/arm/include/asm/bug.h > > +++ b/xen/arch/arm/include/asm/bug.h > > @@ -1,6 +1,24 @@ > > #ifndef __ARM_BUG_H__ > > #define __ARM_BUG_H__ > > +/* > > + * Please do not include in the header any header that might > > + * use BUG/ASSERT/etc maros asthey will be defined later after > > + * the return to from the current header: > > + * > > + * : > > + * ... > > + * : > > + * ... > > + * > > + * ... > > + * ... > > + * #define BUG() ... > > + * ... > > + * #define ASSERT() ... > > + * ... > > + */ > > + > > #include > > #if defined(CONFIG_ARM_32) > > @@ -11,76 +29,7 @@ > > # error "unknown ARM variant" > > #endif > > -#define BUG_FRAME_STRUCT > > - > > -struct bug_frame { > > - signed int loc_disp; /* Relative address to the bug address */ > > - signed int file_disp; /* Relative address to the filename */ > > - signed int msg_disp; /* Relative address to the predicate (for > > ASSERT) */ > > - uint16_t line; /* Line number */ > > - uint32_t pad0:16; /* Padding for 8-bytes align */ > > -}; > > - > > -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) > > -#define bug_file(b) ((const void *)(b) + (b)->file_disp); > > -#define bug_line(b) ((b)->line) > > -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) > > - > > -/* Many versions of GCC doesn't support the asm %c parameter which would > > - * be preferable to this unpleasantness. We use mergeable string > > - * sections to avoid multiple copies of the string appearing in the > > - * Xen image. BUGFRAME_run_fn needs to be handled separately. > > - */ > > Given this comment ... > > > -#define BUG_FRAME(type, line, file, has_msg, msg) do { > > \ > > - BUILD_BUG_ON((line) >> 16); > > \ > > - BUILD_BUG_ON((type) >= BUGFRAME_NR); > > \ > > - asm ("1:"BUG_INSTR"\n" > > \ > > - ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" > > \ > > - "2:\t.asciz " __stringify(file) "\n" > > \ > > - "3:\n" > > \ > > - ".if " #has_msg "\n" > > \ > > - "\t.asciz " #msg "\n" > > \ > > - ".endif\n" > > \ > > - ".popsection\n" > > \ > > - ".pushsection .bug_frames." __stringify(type) ", \"a\", > > %progbits\n"\ > > - "4:\n" > > \ > > - ".p2align 2\n" > > \ > > - ".long (1b - 4b)\n" > > \ > > - ".long (2b - 4b)\n" > > \ > > - ".long (3b - 4b)\n" > > \ > > - ".hword " __stringify(line) ", 0\n" > > \ > > - ".popsection"); > > \ > > -} while (0) > > - > > -/* > > - * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the > > - * flag but instead rely on the default value from the compiler). So the > > - * easiest way to implement run_in_exception_handler() is to pass the to > > - * be called function in a fixed register. > > - */ > > -#define run_in_exception_handler(fn) do { > > \ > > - asm ("mov " __stringify(BUG_FN_REG) ", %0\n" > > \ > > - "1:"BUG_INSTR"\n" > > \ > > - ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," > > \ > > - " \"a\", %%progbits\n" > > \ > > - "2:\n" > > \ > > - ".p2align 2\n" > > \ > > - ".long (1b - 2b)\n" > > \ > > - ".long 0, 0, 0\n" > > \ > > - ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); > > \ > > -} while (0) > > - > > -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") > > - > > -#define BUG() do { \ > > - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ > > - unreachable(); \ > > -} while (0) > > - > > -#define assert_failed(msg) do { \ > > - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ > > - unreachable(); \ > > -} while (0) > > +#define BUG_ASM_CONST "c" > > ... you should explain in the commit message why this is needed and the > problem described above is not a problem anymore. > > For instance, I managed to build it without 'c' on arm64 [1]. But it does > break on arm32 [2]. I know that Arm is also where '%c' was an issue. > > Skimming through linux, the reason seems to be that GCC may add '#' when it > should not. That said, I haven't look at the impact on the generic > implementation. Neither I looked at which version may be affected (the > original message was from 2011). > > However, without an explanation, I am afraid this can't go in because I am > worry we may break some users (thankfully that might just be a compilation > issues rather than weird behavior). > > Bertrand, Stefano, do you know if this is still an issue? I don't know, but I confirm your observation. In my system, both ARM64 and ARM32 compile without problems with "c". Without "c', only ARM64 compiles without problems, while ARM32 breaks. My ARM32 compiler is: arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 Additing a meaningful explanation to the commit message might be difficult in this case. Maybe instead we could run a few tests with different versions of arm64 and arm32 gcc to check that everything still works? If everything checks out, given that the issue has been unchanged for 10+ years we could just keep "c" and move forward with it? From xen-devel-bounces@lists.xenproject.org Mon Apr 03 01:28:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 01:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517294.802412 (Exim 4.92) (envelope-from ) id 1pj8zJ-0002p2-Me; Mon, 03 Apr 2023 01:28:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517294.802412; Mon, 03 Apr 2023 01:28:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj8zJ-0002ov-Jt; Mon, 03 Apr 2023 01:28:01 +0000 Received: by outflank-mailman (input) for mailman id 517294; Mon, 03 Apr 2023 01:28:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj8zI-0002op-5S for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 01:28:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0c::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c30196a8-d1be-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 03:27:57 +0200 (CEST) Received: from AM6PR01CA0047.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::24) by AS2PR08MB10296.eurprd08.prod.outlook.com (2603:10a6:20b:648::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.29; Mon, 3 Apr 2023 01:27:54 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::b1) by AM6PR01CA0047.outlook.office365.com (2603:10a6:20b:e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22 via Frontend Transport; Mon, 3 Apr 2023 01:27:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.16 via Frontend Transport; Mon, 3 Apr 2023 01:27:54 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Mon, 03 Apr 2023 01:27:53 +0000 Received: from 1a285a08504b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 12AA0D9A-322B-424F-AD6A-F43BE9627906.1; Mon, 03 Apr 2023 01:27:48 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a285a08504b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Apr 2023 01:27:48 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GVXPR08MB7798.eurprd08.prod.outlook.com (2603:10a6:150:4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 01:27:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6254.029; Mon, 3 Apr 2023 01:27:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c30196a8-d1be-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/xI7pG/+thWbOKdjBTxM27elUXU8IQePp3oEeA3Z1fQ=; b=UtDDT2pVj/+MT0Pk/1dqk5JZdWSJ2b4hPn9K6xyQz4PZYsIbl+EtRJG+KZs7OgqzrqjIPLFhXkFNXfC9f8egS8NaAPYxe928EC8lmi0iEitl7h3txhkrAdBMKu6j23aJvA1t1qqnHt++h1inIDxxqyarU+bu94bV68hWxS3s1iY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJy9kGR8eXSoorFf8+qhdJlRjF8EvRRrL2XGFQio3XiFgGgS5tXzAjwIYGxqYYax12yQH3enSAAvfvaQv+u96ybCNdtHZt4vnLvV6CD1sM+atyfLYfDY/sooY0ha8/bynrMnW+EPQg7Z0/0rdoxaLHsI82KhxmyCIFgYpirCxsAKAfGOsWsCchhLFCRUszRWDnAITFi9sTHedG3VlNz7ziVk1IvlLzZE5Rkr2cXuXFrlMRcwmaw1Llc0pCZwenJGXB/7zLMQirEPGzjNdLVlprsjtammD5qQ1XUcZCjb9+wJmPhbFCWpzo4bbz19HCBjGjyVpg9nA9fR+YvcR5fIPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/xI7pG/+thWbOKdjBTxM27elUXU8IQePp3oEeA3Z1fQ=; b=OQtLOSbyDMwDxiueCrf+PF/+i1o93IdItpg2MKKzgAJ5+9TI4Xjl8aWRsLxN2ytmpQ8eqYV8F50hRkMylpzsYfkWHCwIx7BpWa0lJIbFNnTweJ8KCpbxq4iOdZHRqHcq/4Cg3GhHWxTt3F7hFZCK5hD12Ebf+9v/uBDw8Bx5QDk2771hhzts0Fg2NPJglXj7yQKDfmQoq2BwyPwp8+exaTk1i/KqCNEI3WZiThp2ML3oNvDScJIcCI+tIX4VB2IE9vfTPN0AGsvXwr/BDeh8PdFpmebZiGDFZ5WQZA5ac4Q47F76368OMvipKAvLYrg4akGBQ150d6g0sft0ta+B2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/xI7pG/+thWbOKdjBTxM27elUXU8IQePp3oEeA3Z1fQ=; b=UtDDT2pVj/+MT0Pk/1dqk5JZdWSJ2b4hPn9K6xyQz4PZYsIbl+EtRJG+KZs7OgqzrqjIPLFhXkFNXfC9f8egS8NaAPYxe928EC8lmi0iEitl7h3txhkrAdBMKu6j23aJvA1t1qqnHt++h1inIDxxqyarU+bu94bV68hWxS3s1iY= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: "community.manager@xenproject.org" , Julien Grall , "sstabellini@kernel.org" , Bertrand Marquis , Andrew Cooper , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , George Dunlap , Juergen Gross , Wei Chen Subject: Xen 4.18 release: Proposed release schedule Thread-Topic: Xen 4.18 release: Proposed release schedule Thread-Index: AdllyZg0WLVAnXgvTY+2GvS7dGkAyQ== Date: Mon, 3 Apr 2023 01:27:42 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 572C6A4C7311C9449A271E8C1E3D6915.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GVXPR08MB7798:EE_|AM7EUR03FT036:EE_|AS2PR08MB10296:EE_ X-MS-Office365-Filtering-Correlation-Id: a4762508-037e-494e-4f81-08db33e2a5f2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QfQatOycnpIGKtE3P+2SHbE8E6VbhOzrdGxin3WqgfOjCB/WkUUUgjP42gkT849kPCrHlcaKqe+yLBjGuS2ap4MSJ1RiJg/xBAPs2UlX/K7ybP6HRRdIbbPDM2XQgPO+XeSzMGPL/JPjJl0dwEpTqEXWIhQQ+jJChWRb6D0k/jGKD8OQpoUkspbKf+cADU0ISQ5AefVJ1/6/oK6cCpgqflNRRbehu24ELhzVdwUQAqyPOeS/4s6mFSqJcxTLi5t8gCjBxbTZdKeqCJZ60Q8lNqHY7lmot7RcD4/PxcOFiyvzyhnI8h7ZlEk/h+wGPUhA3lL55dT6fYkl1MpiaJDwxZrIJpkUTNQ/W6WQ1PMaL0wPBhVbpQM4OzkzKS2bbGF0tSx8wPWA3bJpHnL2I6upMTlFCksFCBQV7e6PZDfPmqmTTSZbpg7z6geFAj35KSKvlMZJQQNZtr++kTpvP36TS7ljOGMn7ZLuHWIJLp6SW6NRUlessZpS8mclfyGFri02HTTVflplVlyTY2/KeElq+0rkitdglUxS2CUrxtpLt3tznkyp6C6xGR+uBjucRSSTuQlEoOj6zmuYRARIKgYzifbYPwnk4VchMXXxoaYkkY752BC04A7M70rtBKCu1hCc X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(451199021)(5660300002)(8936002)(41300700001)(54906003)(52536014)(478600001)(2906002)(66446008)(64756008)(76116006)(7696005)(4326008)(316002)(71200400001)(7416002)(66946007)(66556008)(66476007)(8676002)(6916009)(9686003)(186003)(6506007)(26005)(122000001)(55016003)(83380400001)(33656002)(86362001)(38100700002)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7798 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 10da1716-30c4-4707-fc51-08db33e29f01 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: usNsLZ3d2D+/KMoucZdM2VyDDJ3RboOvpupsjnpaX9nRK/SnhtfC7uUb5XObPi3ZhKwQhfUeGq/5ANlZ1+yBZgcubGWgEvadHM7xRPsc7tGa5Imea8NDvI/pI8nUW2o/Gy/GK+xLDR1negkCFCRVn5wcD1UGh3iY0BFxXU6s2LMRYUnSf5d6Hof6x6TDYK6BG+itkKB2qVPyjzr3YpTAz10cADrAdLJzgeiBabxgnrdYL2yCOpnFqs7EaVSmksNDbg6jQkd7voYCACwMGrifOD640bLkUMZECRE9FQ11sV7oiw4e1JFw49CIZ+WRvNVOqG0ewhJ9vP9GA28AWg8+yR8p+FS5nYCgAGyEv1UMwSczfGHJBl/ZPUTrzx4pAzITH1ev5orepKPAg66GfKuuWRAlS/S3lEYhoAsO0Om6q/3V/mUtWXujVzRJtdRDHnqZmPCdo2JDpo6LOCVUEgiI1vvMIaxvlySiqsa63QzzKIQTIrPCjNVshQkH1BCrTF7rLEdust98Yp50zQj5eDeBMQJqdmv1r2kfgjrF/0HNTkeSOTnsQHRtqjdbR0VTXhhYFxR9vUPOhjY5A6/tt+L9O6jO5sxaxQJMurkzwXsiFrE6E14ZDlWI883FTsch7EloKWHg0qO7FfiNVFAuyalzT4Eh2XCkW8Pgs7NhkWimYUs= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199021)(36840700001)(46966006)(86362001)(82310400005)(2906002)(33656002)(55016003)(40480700001)(7696005)(83380400001)(336012)(186003)(47076005)(26005)(6506007)(9686003)(4326008)(70586007)(8676002)(36860700001)(478600001)(70206006)(81166007)(6916009)(41300700001)(5660300002)(82740400003)(52536014)(356005)(54906003)(316002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 01:27:54.2178 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4762508-037e-494e-4f81-08db33e2a5f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10296 Hi everyone, Following the 8-month release cycle, also taking into account of the Xen Summit and summer holiday, below is the proposed release schedule that I come up with for Xen 4.18. Please don't hesitate to provide your feedback. Thanks! ** Proposed option: Wed Aug 2, 2023 ** (+8 months from Xen 4.17 release) - Last posting date Fri May 12, 2023 (+6 weeks from now) Patches adding new features are expected to be posted to the mailing list by this date, although perhaps not in their final version. - Feature freeze Fri Jun 2, 2023 (+3 weeks from Last posting da= te) Patches adding new features should be committed by this date. Straightforward bugfixes may continue to be accepted by maintainers. - Code freeze Fri Jun 23, 2023 (+3 weeks from Feature freeze= ) Bugfixes only. (Note that Xen Summit is Jun 24 - 26, 2023) - Hard code freeze Fri Jul 14, 2023 (+3 weeks from Code freeze) Bugfixes for serious bugs (including regressions), and low-risk fixes only. - Final commits Fri Jul 28, 2023 (+2 weeks from Hard code free= ze) Branch off staging-4.18. - Release Wed Aug 2, 2023 Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Mon Apr 03 02:24:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 02:24:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517297.802423 (Exim 4.92) (envelope-from ) id 1pj9rg-00012J-Tg; Mon, 03 Apr 2023 02:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517297.802423; Mon, 03 Apr 2023 02:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj9rg-00012A-Ll; Mon, 03 Apr 2023 02:24:12 +0000 Received: by outflank-mailman (input) for mailman id 517297; Mon, 03 Apr 2023 02:24:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj9rf-000120-Vk; Mon, 03 Apr 2023 02:24:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj9rf-0000XH-TW; Mon, 03 Apr 2023 02:24:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pj9rf-0006si-C7; Mon, 03 Apr 2023 02:24:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pj9rf-0003bU-Be; Mon, 03 Apr 2023 02:24:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1jGnIj+2z8g+2HncjObUUrmONjjD3Lp7FuLc/1bwoFM=; b=sjjEawTUjrwTHqxuPjcB+lECfl jUGkl3o2BdP25n0HwNoHaxniSdliTdsfmtRDcE2i78cnpTjMD9+c3wP3oNh99tTlQHkiRCuMYxEQu QjXwkd3uG1kWZEKQrFSsQgl+D8bFbH3i+SyVsU9BS7cz0DsUPFqSjdMduOjrBQhLnpJY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180113: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=6ab608fe852b50fe809b22cdf7db6cbe006d7cb3 X-Osstest-Versions-That: linux=00c7b5f4ddc5b346df62b757ec73f9357bb452af From: osstest service owner Date: Mon, 03 Apr 2023 02:24:11 +0000 flight 180113 linux-linus real [real] flight 180114 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180113/ http://logs.test-lab.xenproject.org/osstest/logs/180114/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 180114-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180107 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180107 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180107 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180107 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180107 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 6ab608fe852b50fe809b22cdf7db6cbe006d7cb3 baseline version: linux 00c7b5f4ddc5b346df62b757ec73f9357bb452af Last test of basis 180107 2023-04-01 22:11:37 Z 1 days Testing same since 180113 2023-04-02 18:13:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anand Jain Benjamin Gray Carlos Bilbao David Disseldorp David Sterba Federico Vaga Filipe Manana Greg Kroah-Hartman Haren Myneni Javier Martinez Canillas Jens Axboe Linus Torvalds Michael Ellerman Paulo Alcantara (SUSE) Paulo Alcantara Steve French Vegard Nossum Yicong Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 00c7b5f4ddc5..6ab608fe852b 6ab608fe852b50fe809b22cdf7db6cbe006d7cb3 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Apr 03 04:22:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 04:22:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517303.802433 (Exim 4.92) (envelope-from ) id 1pjBhq-0004wZ-1N; Mon, 03 Apr 2023 04:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517303.802433; Mon, 03 Apr 2023 04:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjBhp-0004wS-UO; Mon, 03 Apr 2023 04:22:09 +0000 Received: by outflank-mailman (input) for mailman id 517303; Mon, 03 Apr 2023 04:22:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjBho-0004wL-Vv for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 04:22:09 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14bb3ad6-d1d7-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 06:22:05 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 27AE95C0092; Mon, 3 Apr 2023 00:22:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 03 Apr 2023 00:22:01 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 00:21:59 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14bb3ad6-d1d7-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1680495721; x=1680582121; bh=1gwzkrabqfP4SsGBsML6M961/r3JQJiJG2e NmXnX7VU=; b=nrtW0pt1TMXD9x28v4nCVj/tJTS5U0fl0q7fBuWrt/lvz/zXPHI 2XkCaHMYhO0Wq7KPy67u8uTsOxiyFp9nO8WYsvx88ADhzAXQg5CahaEFaiP7M2Kd 6Hc0gXsKSAwq2QKKiSm/AI+big7PYsnsMnpCh5ak0C92NqhtDhmZBve2MQ5l0XZ/ pOFVvFw1z0/2hKXyABT9m2d73dFALCIdKwWkXmKVZhu9oPWghHJ3kUODuj74fG55 fqY0UcuF5TI9wHhdNXi92SZA8EhkLKQiQOFjqshw8gjGCqFzyLEX/ufTJT+bGRC3 ioyNkVbWu1VCaIAvOwjjM5XrAneAMaGWrhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680495721; x=1680582121; bh=1gwzkrabqfP4S sGBsML6M961/r3JQJiJG2eNmXnX7VU=; b=aV6O5NGj48VocE/YyaJ2CwDB8/bcr Wy6SkEaJXXiqCGWrcyANGHNPgh/ZQgTTqAGe1vC8Fwdu0aPOrcX5L5YYsDiafBRz rStVAdUMgAUxI4dRBU4DiQXkWhMT2pwYWcX8QPjuEAVuD4AcnxCXmIQ9S1YGQwKk gU5/PSioO4mmDN01CgX0hA8qqlY+aWWtrbe0P2mDtzKWt0JfN4XqoZyeH1LOUj5N 4bCo9w7UUtgrg1rD5HkeKj+5mcjB92hDmZlZB+f5cFxqGFWvCKdujBWGIVpUrl/O VeiCv8YLAFpeXRLiUrBOuvFCP1wZqmjhuqHO5Kn2Nzo3RuvSD2rJACgJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiiedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 3 Apr 2023 06:21:56 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Jason Andryuk , Andrew Cooper , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table Message-ID: References: <20230325024924.882883-1-marmarek@invisiblethingslab.com> <20230325024924.882883-2-marmarek@invisiblethingslab.com> <540906f7-4543-9d01-2b2b-a3bd70eda74b@suse.com> <9eb7b538-4074-4b15-4ea2-67d9cc0bf85d@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sx4KoBD4ntkktgRN" Content-Disposition: inline In-Reply-To: <9eb7b538-4074-4b15-4ea2-67d9cc0bf85d@suse.com> --Sx4KoBD4ntkktgRN Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 3 Apr 2023 06:21:56 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Jason Andryuk , Andrew Cooper , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table On Tue, Mar 28, 2023 at 03:03:17PM +0200, Jan Beulich wrote: > On 28.03.2023 14:52, Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Mar 28, 2023 at 02:34:23PM +0200, Jan Beulich wrote: > >> On 28.03.2023 14:05, Marek Marczykowski-G=C3=B3recki wrote: > >>> On Tue, Mar 28, 2023 at 01:28:44PM +0200, Roger Pau Monn=C3=A9 wrote: > >>>> On Sat, Mar 25, 2023 at 03:49:23AM +0100, Marek Marczykowski-G=C3=B3= recki wrote: > >>>>> +static bool cf_check msixtbl_page_accept( > >>>>> + const struct hvm_io_handler *handler, const ioreq_t *r) > >>>>> +{ > >>>>> + ASSERT(r->type =3D=3D IOREQ_TYPE_COPY); > >>>>> + > >>>>> + return msixtbl_page_handler_get_hwaddr( > >>>>> + current->domain, r->addr, r->dir =3D=3D IOREQ_WRITE); > >>>> > >>>> I think you want to accept it also if it's a write to the PBA, and > >>>> just drop it. You should always pass write=3Dfalse and then drop it= in > >>>> msixtbl_page_write() if it falls in the PBA region (but still return > >>>> X86EMUL_OKAY). > >>> > >>> I don't want to interfere with msixtbl_mmio_page_ops, this handler is > >>> only about accesses not hitting actual MSI-X structures. > >> > >> In his functionally similar vPCI change I did ask Roger to handle the > >> "extra" space right from the same handlers. Maybe that's going to be > >> best here, too. > >=20 > > I have considered this option, but msixtbl_range() is already quite > > complex, adding yet another case there won't make it easier to follow. >=20 > Do you care about the case of msixtbl_addr_to_desc() returning NULL at > all for the purpose you have?=20 IIUC I care specifically about this case. > Like in Roger's patch I'd assume > msixtbl_find_entry() needs extending what ranges it accepts; if need > be another parameter may be added to cover cases where the extended > coverage isn't wanted. > > > I mean, technically I can probably merge those two handlers together, > > but I don't think it will result in nicer code. Especially since the > > general direction is to abandon split of MSI-X table access handling > > between Xen and QEMU and go with just QEMU doing it, hopefully at some > > point not needing msixtbl_mmio_ops anymore (but still needing the one > > for adjacent accesses). >=20 > Hmm, at this point I'm not convinced of this plan. Instead I was hoping > that once vPCI properly supports PVH DomU-s, we may also be able to make > use of it for HVM, delegating less to qemu rather than more. In that case, this code won't be needed anymore, which will also make this handler unnecessary. Anyway, I tried to merge this handling into existing handlers and the resulting patch is slightly bigger, so it doesn't seem to avoid any duplication. The only benefit I can think of is avoiding iterating msixtbl_list twice (for respective accept callbacks) on each access. Is it worth a bit more complicated handlers? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Sx4KoBD4ntkktgRN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmQqVGQACgkQ24/THMrX 1ywJRAf/XIkiO20k0CXZsGxJ23AOQC91NVznTfOfXKg0aH+JjhwdUVKFQ2MCPQPF sC2oziwPlxHDDGg6i/dY3Il63mRNYTiDZ9t/i1UF1lwWp3IVRv90fTUyeNnjtjYP VCeYi5Ht1TE0wYN19MHb7A+6rvG33ZRFGiWxMF/IKMYR+uA3FwH6UYhTTRk5RflA hujDod7MiRgRCrD3YDBH8bffDxj+Atq/eFaySaQ+WbbaRD0HegT0h83nHfWkvvTz xjlr7lK38vTwr+6zVuRur0EE0IEl+dJO67UogTo0H1uf8DWJeY7QelHh2swV5YvX OQVbWBoerAdPBoBA5ILi/SWWEfozKw== =IgLb -----END PGP SIGNATURE----- --Sx4KoBD4ntkktgRN-- From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517309.802447 (Exim 4.92) (envelope-from ) id 1pjEot-0000WN-WA; Mon, 03 Apr 2023 07:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517309.802447; Mon, 03 Apr 2023 07:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEot-0000V4-So; Mon, 03 Apr 2023 07:41:39 +0000 Received: by outflank-mailman (input) for mailman id 517309; Mon, 03 Apr 2023 07:41:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEos-0000Sg-9M for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:38 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4e4850c-d1f2-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 09:41:35 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id p34so16484258wms.3 for ; Mon, 03 Apr 2023 00:41:34 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4e4850c-d1f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507693; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hqktkp0iv4ik+R4dzmjAFeY0JZolWYG3VGRe4IrvPbY=; b=LVlZ2cuXFFwexXKoLI9ZG5QLEbGwOeE1vppWSymN0IQlwF89mbzooulggZ9QEfulr8 PcmbIyQvJCwRAHRXGOCyARG18K25hcG1Z79E7hTODBbHIK5gRp8lt+RZ/NW7FpVGFaXg UiyqH4AVBIN7OzYQiYUpLFf0VmO/k9PzcY6G0ppf9uuG6chbW5qZDutq4dzRlzjqDcdl kBLiKAIa+gs0ikEQx09bluaV4HWsb28uN9XufuY9U6tt5vV79zff5a7CVVxoUUffTFnZ gomowXcFGaVrFrZduuwRYSaVlDcVSGOGAgvm8M/QM0eOxop+1AsCKWsROZrw7JaX9d3K eKWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507693; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hqktkp0iv4ik+R4dzmjAFeY0JZolWYG3VGRe4IrvPbY=; b=vrYHaRJ77eeVFnTy8dRZcjTnyvTC8iMW7LmhO+3LOUgLuVVdQcqGOnblLz7iN6WPde zEGaYmwdzRJJZjTE1FUBTFoCctw1wd1sG9SiqHdgdybPgHzN7DqZqlRjltaORpBAMxAK LFoVUOfDujp8BWuo+HRuXDNu28M3GvX8mzk2AJbzqL5Ch8hxlNFViZwFwU0LRGrXEruQ I4gjVp6NkF0vA2YhFx8xYS1HBnQu6greJzd7C5Q+msldCeHvHdhv4arTVQCwvLui1Cfu E8YZ//d8DVWDOD3TtSWPS34Pg3oNbJN6P8XGFA3y0E0da1QKEdxVDujgBiy0PSN+VOpW ooZg== X-Gm-Message-State: AO0yUKX2Tl0QIY6URJ0kC2F+5ttB30r9j6EyLY+9KIIQrcpkhBO2wnCK EkBfQb7yS1D1PfjTv/t+EaM= X-Google-Smtp-Source: AK7set+w4NV/Q17dNwmnKiNJ9TGNyLmYq7XLiiKjnzxMzffvXWPMfja/NHU/YbSqWzE9T9gy1AwaVA== X-Received: by 2002:a05:600c:ad0:b0:3ed:abb9:7515 with SMTP id c16-20020a05600c0ad000b003edabb97515mr26505746wmr.11.1680507693506; Mon, 03 Apr 2023 00:41:33 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE Date: Mon, 3 Apr 2023 09:41:17 +0200 Message-Id: <20230403074124.3925-1-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable There is currently a dedicated PIIX3 device model for use under Xen. By reu= sing=0D existing PCI API during initialization this device model can be eliminated = and=0D the plain PIIX3 device model can be used instead.=0D =0D Resolving TYPE_PIIX3_XEN_DEVICE results in less code while also making Xen= =0D agnostic towards the precise south bridge being used in the PC machine. The= =0D latter might become particularily interesting once PIIX4 becomes usable in = the=0D PC machine, avoiding the "Frankenstein" use of PIIX4_ACPI in PIIX3.=0D =0D Testing done:=0D - `make check`=0D - Run `xl create` with the following config:=0D name =3D "Manjaro"=0D type =3D 'hvm'=0D memory =3D 1536=0D apic =3D 1=0D usb =3D 1=0D disk =3D [ "file:manjaro-kde-21.2.6-220416-linux515.iso,hdc:cdrom,r" ]= =0D device_model_override =3D "/usr/bin/qemu-system-x86_64"=0D vga =3D "stdvga"=0D sdl =3D 1=0D - `qemu-system-x86_64 -M pc -m 2G -cpu host -accel kvm \=0D -cdrom manjaro-kde-21.2.6-220416-linux515.iso`=0D =0D v4:=0D - Add patch fixing latent memory leak in pci_bus_irqs() (Anthony)=0D =0D v3:=0D - Rebase onto master=0D =0D v2:=0D - xen_piix3_set_irq() is already generic. Just rename it. (Chuck)=0D =0D Tested-by: Chuck Zmudzinski =0D =0D Bernhard Beschow (7):=0D include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq()=0D hw/pci/pci.c: Don't leak PCIBus::irq_count[] in pci_bus_irqs()=0D hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()=0D hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3=0D hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config()=0D hw/isa/piix3: Resolve redundant k->config_write assignments=0D hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICE=0D =0D include/hw/southbridge/piix.h | 1 -=0D include/hw/xen/xen.h | 2 +-=0D hw/i386/pc_piix.c | 36 +++++++++++++++++++--=0D hw/i386/xen/xen-hvm.c | 2 +-=0D hw/isa/piix3.c | 60 +----------------------------------=0D hw/pci/pci.c | 2 ++=0D stubs/xen-hw-stub.c | 2 +-=0D 7 files changed, 39 insertions(+), 66 deletions(-)=0D =0D -- =0D 2.40.0=0D =0D From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517314.802503 (Exim 4.92) (envelope-from ) id 1pjEp0-000206-6x; Mon, 03 Apr 2023 07:41:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517314.802503; Mon, 03 Apr 2023 07:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEoz-0001zq-WC; Mon, 03 Apr 2023 07:41:45 +0000 Received: by outflank-mailman (input) for mailman id 517314; Mon, 03 Apr 2023 07:41:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEox-0000Sg-Vv for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:44 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9d7953e-d1f2-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 09:41:42 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id i5-20020a05600c354500b003edd24054e0so19144066wmq.4 for ; Mon, 03 Apr 2023 00:41:42 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9d7953e-d1f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xfruqCTvdLb6qQjpwkCpa8vgF1IvHI8+CFma9+fgJv8=; b=EAQ6n7WWQXPUjZaBzzBlO5S8qeAHPTlk8U7zS3dcf+8IIdkYRF+t76elBK5JMC6VvR MlevLDBVnopzGlcluD5E3paMkO9gGmS9AiWXwbBxrmfV6aY677J1hA7sEoOMZsusRhCO WtNuC4TBrqU9huTBhT4qaoJ3hKFDLVLwR3Q492RbdYmNN96sEoQRc05zQjYNBPUaYgFS wlTsF3d6qB4+ivcvqD/tRWrRuT7ASZ49jVudbsUe4HaCkTh0Jf88+s+oA9GGmu4u4jN4 MYC4GsrKHzZxdgEsprYEQvYQ9+pe1/Pfl0wcjSFYsZgQhf3t0h8B31q//5p9hTJOJ1Gu dYlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xfruqCTvdLb6qQjpwkCpa8vgF1IvHI8+CFma9+fgJv8=; b=Enkqb0ZqCfehwenYG9frKYj8zkkeBn40frY8jQ9i+tFNFIziC3p1O7KqWkAYCSC2Wt DLAfN403eElT8qoLHR97cSZDeZiCFTO794t0jZg/P0IBl6/U5oWlGafWiI7qs0MghWBL l6jvVNvMBr+UhLs3hX7VSfs/5KGsekTXahH2+R9QI12QmHrWBa99P/TgbEwRhGl0t94D RNyz3YInT4pTBqv9K3uyrAixugtu7JNJUpBg6hrWI0DBpAthCBvvcuyN4EUV9rLnO+9X QO/S6jWk7TRerZbug6725JYJ7AINZq106tnIDYcFl464N4h5mX/sb2/35ilSTpX3At0Y tfmg== X-Gm-Message-State: AO0yUKX1lAKtH8emrffrpDfAf4dTi/U7FY3N/EaGeH0COB39+XX2iEWx M97HPHRG4wNTFIRE6+wrwXs= X-Google-Smtp-Source: AK7set9rrvyB0aTyq/IlC7IjQSr4MJ3b4hfbs5XNaEHQCEylCJMqyaqqp21kfc6RgszwCmJPmkED8Q== X-Received: by 2002:a1c:770c:0:b0:3ed:454d:36ab with SMTP id t12-20020a1c770c000000b003ed454d36abmr25688857wmi.16.1680507701818; Mon, 03 Apr 2023 00:41:41 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 6/7] hw/isa/piix3: Resolve redundant k->config_write assignments Date: Mon, 3 Apr 2023 09:41:23 +0200 Message-Id: <20230403074124.3925-7-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous patch unified handling of piix3_write_config() accross the PIIX3 device models which allows for assigning k->config_write once in the base class. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-6-shentey@gmail.com> --- hw/isa/piix3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index 737f5c6a5d..418940139d 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -308,6 +308,7 @@ static void pci_piix3_class_init(ObjectClass *klass, void *data) PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); AcpiDevAmlIfClass *adevc = ACPI_DEV_AML_IF_CLASS(klass); + k->config_write = piix3_write_config; dc->reset = piix3_reset; dc->desc = "ISA bridge"; dc->vmsd = &vmstate_piix3; @@ -356,7 +357,6 @@ static void piix3_class_init(ObjectClass *klass, void *data) { PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix3_write_config; k->realize = piix3_realize; } @@ -370,7 +370,6 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data) { PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix3_write_config; k->realize = piix3_realize; } -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517310.802453 (Exim 4.92) (envelope-from ) id 1pjEou-0000bP-CC; Mon, 03 Apr 2023 07:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517310.802453; Mon, 03 Apr 2023 07:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEou-0000Xy-7F; Mon, 03 Apr 2023 07:41:40 +0000 Received: by outflank-mailman (input) for mailman id 517310; Mon, 03 Apr 2023 07:41:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEos-0000Sg-Jq for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:38 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f686a8af-d1f2-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 09:41:36 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id m2so28256759wrh.6 for ; Mon, 03 Apr 2023 00:41:36 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f686a8af-d1f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+2bxbqf6j4QPQJIwH9ivxbi0oLjhsXkO+rq7lp2Eh9U=; b=WC5szrsbsTKCY9H3NIUWRSbAOse9TsOnH1X01M7jJFEyCnqYih84GDL/KdBhBXgvfZ cxx71VQpcKF9zWdzMnSbkpc1hfesym5CJWKDjgWmFqmwEAZxtxhq8nOHsCyYPynIYrS9 BaLfK4jsrhCeSuXHGsXYL7fNzlE5hnc0hfC+2XsB/zKpBEIWgD6sfzdiEyxE4zaNCnEv 162tllbbB0sUjNuop5fu0nl/n19meZoUfNaKBn50XCNcWvdCal884QeT/q0SEepuboYT CVmM6NveJXfoFPYDUH3UGFCSnAI2AjW/EN4i3xu23N5hvy6np1jlESM9iiQdcFx39cPw K01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+2bxbqf6j4QPQJIwH9ivxbi0oLjhsXkO+rq7lp2Eh9U=; b=LhOJ1lrSYnxj9MUFQKCgjRAj4wr02EKrwj0qKL4X0Q1KJ6nnICaPdUCcN83T8IibM5 OC+Rw7sovmPOurnDKhNCYvMU4jGl7C1z6N+813c3+bREstJvF5T4cp+bgw9ox981fj9F SXkmRGdJpvr6F638m5Wh20ROF4bUF0uI/81/DWJsko4WOQtBbVoQUNJvUFBivV23gTE9 ImdwRgEo08kqM7gi+PZ2lGDJNj1ugsutJ1PFgbENyHeGyam153ZwxgFwPcL3Jr4r/MnP 8n+JBC9zZL2jZO73i8j/15Cl2yzn0+LljrmWM1Rm70tYL1LCC+MGkNimz4Suc7ctOtPN rMyw== X-Gm-Message-State: AAQBX9e6sQsde7vVErMC/G6l2yhvuNy3gBcdboCWV/dCPuzxYhE7UP8k OBb4IvexUDRVN5Qg/BfLn5E= X-Google-Smtp-Source: AKy350a8w/UjVGBXm/IvW1eiUEjt7WBOj3GvSpZIn/V9+4KAg1DkfQwNZGfsneF3GohAYNphgxwWGA== X-Received: by 2002:a05:6000:ca:b0:2d6:5afe:7b91 with SMTP id q10-20020a05600000ca00b002d65afe7b91mr11692241wrx.30.1680507696091; Mon, 03 Apr 2023 00:41:36 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 2/7] hw/pci/pci.c: Don't leak PCIBus::irq_count[] in pci_bus_irqs() Date: Mon, 3 Apr 2023 09:41:19 +0200 Message-Id: <20230403074124.3925-3-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When calling pci_bus_irqs() multiple times on the same object without calling pci_bus_irqs_cleanup() in between PCIBus::irq_count[] is currently leaked. Let's fix this because Xen will do just that in a few commits, and because calling pci_bus_irqs_cleanup() in between seems fragile and cumbersome. Note that pci_bus_irqs_cleanup() now has to NULL irq_count such that pci_bus_irqs() doesn't do a double free. Signed-off-by: Bernhard Beschow --- hw/pci/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index def5000e7b..be1c5d16ec 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -558,6 +558,7 @@ void pci_bus_irqs(PCIBus *bus, pci_set_irq_fn set_irq, bus->set_irq = set_irq; bus->irq_opaque = irq_opaque; bus->nirq = nirq; + g_free(bus->irq_count); bus->irq_count = g_malloc0(nirq * sizeof(bus->irq_count[0])); } @@ -573,6 +574,7 @@ void pci_bus_irqs_cleanup(PCIBus *bus) bus->irq_opaque = NULL; bus->nirq = 0; g_free(bus->irq_count); + bus->irq_count = NULL; } PCIBus *pci_register_root_bus(DeviceState *parent, const char *name, -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517315.802512 (Exim 4.92) (envelope-from ) id 1pjEp1-0002GR-L7; Mon, 03 Apr 2023 07:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517315.802512; Mon, 03 Apr 2023 07:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEp1-0002FC-DC; Mon, 03 Apr 2023 07:41:47 +0000 Received: by outflank-mailman (input) for mailman id 517315; Mon, 03 Apr 2023 07:41:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEoz-0000Sg-4z for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:45 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa87ecf0-d1f2-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 09:41:43 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id d17so28232998wrb.11 for ; Mon, 03 Apr 2023 00:41:43 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa87ecf0-d1f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bFBFz6LEBXPSgQcOvP8yki+MQL0SlRe8vWuNcy1ofyc=; b=JnS3k4VnUoa2yBgFGDVDqacBd2DdaZDlI+9R3AWOFhe3KjznQtcT72nyHz3M0NNxPI BHk7+yVafEuJZsDmpI86KxWZdZSFBDFQejFdT++2yketIkY99aI1HrLv2dP9MnPjHQBs epvt+PyDpEF8mjOGr9ueoeGBlgS296BEv6sUEJ1Plv/gcSrfBpTUUOoN369ZxcDeBnJJ fC5SM5o/FYODXJeS0jB6XOoeGVOgSkOpHdlRV5MgT+SPRphnIdELNl11dGfm/A0PKLPN PjSXjmBBRUqR2fA/eTLELJx/ttMNy1M7gpFYGMCRRK1Cbtc4/GQjStDehV6+jgrR63Ry NCWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bFBFz6LEBXPSgQcOvP8yki+MQL0SlRe8vWuNcy1ofyc=; b=UR1KvIKcPOl6dT4+2vN9pqbgNlDFTic4ZAxUwuA3FGCvBiPiBvmevhg1RfaVWlkJ+x 8/DA8+1pGHG7AHdsTg5haT0GB9l0zaVkML0NksXGpwJECNWEM/56FuVNc3tAYZY+aJi6 trc0TFIw3JNoOM4O0pQ2ME4JQJw+jgo226wR3LUlldYcP5fPPJaRtJYgMA0Lx+U+EeGd 4nG8JiXLhXYomHd2wJ68GLlStQHroCgWmryKKi7LL7iTLe4kP+KvTEySaOW6rpRrO0YC ekIvMGz3nFFogtYeHP4IAdBbG/IRJXhrRVIdFiFAi3+ZBZT3v1TLypWiaTJ+ToadNm2m zP6A== X-Gm-Message-State: AAQBX9caf9M+lsw9VWm9dKozHB/Zikroy5ktDGtOvN6muE2M3EXavdfp 17S66CJH6ZIX6tn9BBc65fs= X-Google-Smtp-Source: AKy350YQYzXtoXYV33vsug2IkHk8dVMjKWMW4Vgyul9fIIKt/0YfXdy2ovrIHW0LfhNXns7sxctNuA== X-Received: by 2002:adf:fd51:0:b0:2ce:adda:f45a with SMTP id h17-20020adffd51000000b002ceaddaf45amr25195402wrs.62.1680507703148; Mon, 03 Apr 2023 00:41:43 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 7/7] hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICE Date: Mon, 3 Apr 2023 09:41:24 +0200 Message-Id: <20230403074124.3925-8-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of TYPE_PIIX3_DEVICE. Remove this redundancy. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-7-shentey@gmail.com> --- include/hw/southbridge/piix.h | 1 - hw/i386/pc_piix.c | 5 ++--- hw/isa/piix3.c | 15 --------------- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h index 0bf48e936d..51be04e984 100644 --- a/include/hw/southbridge/piix.h +++ b/include/hw/southbridge/piix.h @@ -64,7 +64,6 @@ DECLARE_INSTANCE_CHECKER(PIIX3State, PIIX3_PCI_DEVICE, TYPE_PIIX3_PCI_DEVICE) #define TYPE_PIIX3_DEVICE "PIIX3" -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" #endif diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 1b70470dcd..7ca0d6d14e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -237,8 +237,6 @@ static void pc_init1(MachineState *machine, if (pcmc->pci_enabled) { PIIX3State *piix3; PCIDevice *pci_dev; - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE - : TYPE_PIIX3_DEVICE; pci_bus = i440fx_init(pci_type, i440fx_host, @@ -251,7 +249,8 @@ static void pc_init1(MachineState *machine, : pc_pci_slot_get_pirq); pcms->bus = pci_bus; - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); + pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, + TYPE_PIIX3_DEVICE); if (xen_enabled()) { pci_device_set_intx_routing_notifier( diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index 418940139d..0d6992af67 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -29,7 +29,6 @@ #include "hw/southbridge/piix.h" #include "hw/irq.h" #include "hw/isa/isa.h" -#include "hw/xen/xen.h" #include "sysemu/runstate.h" #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" @@ -366,24 +365,10 @@ static const TypeInfo piix3_info = { .class_init = piix3_class_init, }; -static void piix3_xen_class_init(ObjectClass *klass, void *data) -{ - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - - k->realize = piix3_realize; -} - -static const TypeInfo piix3_xen_info = { - .name = TYPE_PIIX3_XEN_DEVICE, - .parent = TYPE_PIIX3_PCI_DEVICE, - .class_init = piix3_xen_class_init, -}; - static void piix3_register_types(void) { type_register_static(&piix3_pci_type_info); type_register_static(&piix3_info); - type_register_static(&piix3_xen_info); } type_init(piix3_register_types) -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517313.802489 (Exim 4.92) (envelope-from ) id 1pjEox-0001Vc-Qg; Mon, 03 Apr 2023 07:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517313.802489; Mon, 03 Apr 2023 07:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEox-0001Uw-Fe; Mon, 03 Apr 2023 07:41:43 +0000 Received: by outflank-mailman (input) for mailman id 517313; Mon, 03 Apr 2023 07:41:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEow-0000Sg-LN for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:42 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f900dbb0-d1f2-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 09:41:41 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id q19so25188101wrc.5 for ; Mon, 03 Apr 2023 00:41:41 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f900dbb0-d1f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/EuJujhhzp9QT+Va/F4M2q8YBrUEweb2g4rehnqe99A=; b=hcViKZ3qPuwgtA4SsDAiRVSOd64zBPnpHxw+0VBLBeB50VFc/rKXi7fhu7V71wdQ1h FxpfO/RXYDuxhNYh2ttxusHsPNk+t2vE9+H9K9bhKMFQmuSkwffp5fkmeD16xMkbxQQ3 LXpNEKoDVtB45+OBM29Ey1FV8APapXHq6pMgasM66BMhL7Waih4O+UCiJoBRyIbd16zz 253w1Lis8Qh0rRlo2FH1+2zh1X8aqANyAQo//WYFAC4MkQPKgVheB4UURa3XhtGzyOrn Ar8I+OmZhfK340m5fuvAT+mWzcInzHAYzg7cJgstXkUtstVizW6nuDwjuLuv0636VIOC vMaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EuJujhhzp9QT+Va/F4M2q8YBrUEweb2g4rehnqe99A=; b=6plzb2sA43gsEP/CVhZbUjoeZvud1nFOfz1DbYNc95xZQOw+BubRGk+v5Ou4sDwStb FAqIhkMt3BxAtbcybU4854I6+kHTDmBGWL0HcQtopakmt4f1b0n8DA5VF/MjOTzvTL8k YM5pX35klguz1oKeujsBaxwE9UkoOBOiNVLgwFlOQSdrc6qt7dppZq5tuSyMvXW48Vyd QsajlBU66Quqi2/ZvHLSVyq0j5kSnnz6oIcb0vsbkvpUsa3+mma0kPJ+pFvVyzBCtUE7 9w2pUwFjrpY6QxoUtUgsaBxrL0LuRUY0/aIyHj2fEdmusQVieCqLxC7e0XIjpCcvDpCw P/UQ== X-Gm-Message-State: AAQBX9fLrG0UrKej9kIIo9Yd4CJFt3RFLJVpHiqRmrKJ8cp24I75pwbw UxoFljOlS5XR9wKflhbVRoA= X-Google-Smtp-Source: AKy350ZZP0vLfS334AXJ1QOOCUu1Iz6IfelFWZ0j6MBXF/9ON1OR+oP0rMSuxPQc4qp6H8kpAFlguw== X-Received: by 2002:a5d:68cb:0:b0:2cf:fd6:b83f with SMTP id p11-20020a5d68cb000000b002cf0fd6b83fmr12153147wrw.8.1680507700653; Mon, 03 Apr 2023 00:41:40 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 5/7] hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config() Date: Mon, 3 Apr 2023 09:41:22 +0200 Message-Id: <20230403074124.3925-6-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subscribe to pci_bus_fire_intx_routing_notifier() instead which allows for having a common piix3_write_config() for the PIIX3 device models. While at it, move the subscription into machine code to facilitate resolving TYPE_PIIX3_XEN_DEVICE. In a possible future followup, pci_bus_fire_intx_routing_notifier() could be adjusted in such a way that subscribing to it doesn't require knowledge of the device firing it. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-5-shentey@gmail.com> --- hw/i386/pc_piix.c | 18 ++++++++++++++++++ hw/isa/piix3.c | 22 +--------------------- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 99232701b1..1b70470dcd 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -88,6 +88,21 @@ static int pc_pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) return (pci_intx + slot_addend) & 3; } +static void piix_intx_routing_notifier_xen(PCIDevice *dev) +{ + int i; + + /* Scan for updates to PCI link routes (0x60-0x63). */ + for (i = 0; i < PIIX_NUM_PIRQS; i++) { + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); + if (v & 0x80) { + v = 0; + } + v &= 0xf; + xen_set_pci_link_route(i, v); + } +} + /* PC hardware initialisation */ static void pc_init1(MachineState *machine, const char *host_type, const char *pci_type) @@ -239,6 +254,9 @@ static void pc_init1(MachineState *machine, pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + /* * Xen supports additional interrupt routes from the PCI devices to * the IOAPIC: the four pins of each PCI device on the bus are also diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index 7a31caf2b6..737f5c6a5d 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -121,26 +121,6 @@ static void piix3_write_config(PCIDevice *dev, } } -static void piix3_write_config_xen(PCIDevice *dev, - uint32_t address, uint32_t val, int len) -{ - int i; - - /* Scan for updates to PCI link routes (0x60-0x63). */ - for (i = 0; i < len; i++) { - uint8_t v = (val >> (8 * i)) & 0xff; - if (v & 0x80) { - v = 0; - } - v &= 0xf; - if (((address + i) >= PIIX_PIRQCA) && ((address + i) <= PIIX_PIRQCD)) { - xen_set_pci_link_route(address + i - PIIX_PIRQCA, v); - } - } - - piix3_write_config(dev, address, val, len); -} - static void piix3_reset(DeviceState *dev) { PIIX3State *d = PIIX3_PCI_DEVICE(dev); @@ -390,7 +370,7 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data) { PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix3_write_config_xen; + k->config_write = piix3_write_config; k->realize = piix3_realize; } -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517308.802443 (Exim 4.92) (envelope-from ) id 1pjEot-0000T8-Nk; Mon, 03 Apr 2023 07:41:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517308.802443; Mon, 03 Apr 2023 07:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEot-0000T1-Jh; Mon, 03 Apr 2023 07:41:39 +0000 Received: by outflank-mailman (input) for mailman id 517308; Mon, 03 Apr 2023 07:41:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEor-0000Sf-M9 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:37 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f57e5bd8-d1f2-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 09:41:35 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id o24-20020a05600c511800b003ef59905f26so17440294wms.2 for ; Mon, 03 Apr 2023 00:41:35 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f57e5bd8-d1f2-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TeCzVhGVlV6a+Zg2qRJBs5g8PJcLaKDhbJ2idHJxxx0=; b=NOsYWiO46TFwc5m5xQHDhQb58P1Be5veIezV+JjfGZagw4FzoW9qAT0JRFYCG1Egj2 6q00XPm7KcKE7MUNFTIM7GgjU98aTY1zJm5D4vB8qAjZlbnErUSS4LUsH+5+df/dxoUP 0E/k4gNZfqlF5NggV1/s4+AQHdipEvxQQ1nQUjtsp2ehdEujBeHt8RnlyjvDRq6SdcgL EQ6RsxkTM5ehELnOpAbiPcdPxEwrfnGGyLKjQpveSExcoF6JzPNodfRySaFCXvOVzjgt NLBM7Dq02dF3TYQjQ8bHDGAKajXemkJTLwVjK9LwE5h5Pq9U48zyJqpvvli/cdn+9UVR ptSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TeCzVhGVlV6a+Zg2qRJBs5g8PJcLaKDhbJ2idHJxxx0=; b=yhYHq1tfu5ZzukYJEqg1RGVi/gPUAqb6Hi9bex8vvT3rJNDChryZxgqqNURiRjxkPT 2jhOEQRC7/0ksbQr+y7u75mAJI27ULKINXucBLp/+WAv83RkMu+GC1t/A341wPM1nYI8 RIEPvPNffuQpPUfuioMB9yfH4B+wT0QFSx/AgYije3Z2S3P5fwk86kS2ter5xlbL1Scb mbXxKRwKAb2SfqewAJgfeSXyoFo0COTy+Jiub5ATR/0S+M5n5rHqsDbURnbuauxMzUlT LDdrKnogyNz7YyI8XWKJcJ/Mh507QyoOuVZ9Oaa3mqj3sAEt9xoarFdHVEL9z5j43QVy 3j9Q== X-Gm-Message-State: AO0yUKXKozgJLbOf7J7nXCClVU6UVscYId6K+uQXh8eop8V0BPLbAqNP K6bDQabeMsdlyxkbxeO1tcI= X-Google-Smtp-Source: AK7set93HQ7bKPaN49jz207odhGu/2UkBML7wwW8EKMOxHqY7JzqavV7AWSsQWIMxqbtp26LC7xE8A== X-Received: by 2002:a1c:7406:0:b0:3ed:320a:3721 with SMTP id p6-20020a1c7406000000b003ed320a3721mr27549019wmc.22.1680507694746; Mon, 03 Apr 2023 00:41:34 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 1/7] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() Date: Mon, 3 Apr 2023 09:41:18 +0200 Message-Id: <20230403074124.3925-2-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_piix3_set_irq() isn't PIIX specific: PIIX is a single PCI device while xen_piix3_set_irq() maps multiple PCI devices to their respective IRQs, which is board-specific. Rename xen_piix3_set_irq() to communicate this. Also rename XEN_PIIX_NUM_PIRQS to XEN_IOAPIC_NUM_PIRQS since the Xen's IOAPIC rather than PIIX has this many interrupt routes. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-2-shentey@gmail.com> --- include/hw/xen/xen.h | 2 +- hw/i386/xen/xen-hvm.c | 2 +- hw/isa/piix3.c | 4 ++-- stubs/xen-hw-stub.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index 2bd8ec742d..37ecc91fc3 100644 --- a/include/hw/xen/xen.h +++ b/include/hw/xen/xen.h @@ -39,7 +39,7 @@ extern bool xen_domid_restrict; int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num); int xen_set_pci_link_route(uint8_t link, uint8_t irq); -void xen_piix3_set_irq(void *opaque, int irq_num, int level); +void xen_intx_set_irq(void *opaque, int irq_num, int level); void xen_hvm_inject_msi(uint64_t addr, uint32_t data); int xen_is_pirq_msi(uint32_t msi_data); diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 56641a550e..ab8f1b61ee 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -143,7 +143,7 @@ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) return irq_num + (PCI_SLOT(pci_dev->devfn) << 2); } -void xen_piix3_set_irq(void *opaque, int irq_num, int level) +void xen_intx_set_irq(void *opaque, int irq_num, int level) { xen_set_pci_intx_level(xen_domid, 0, 0, irq_num >> 2, irq_num & 3, level); diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index a9cb39bf21..1b3e23f0d7 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -34,7 +34,7 @@ #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" -#define XEN_PIIX_NUM_PIRQS 128ULL +#define XEN_IOAPIC_NUM_PIRQS 128ULL static void piix3_set_irq_pic(PIIX3State *piix3, int pic_irq) { @@ -405,7 +405,7 @@ static void piix3_xen_realize(PCIDevice *dev, Error **errp) * connected to the IOAPIC directly. * These additional routes can be discovered through ACPI. */ - pci_bus_irqs(pci_bus, xen_piix3_set_irq, piix3, XEN_PIIX_NUM_PIRQS); + pci_bus_irqs(pci_bus, xen_intx_set_irq, piix3, XEN_IOAPIC_NUM_PIRQS); } static void piix3_xen_class_init(ObjectClass *klass, void *data) diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 34a22f2ad7..7d7ffe83a9 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -15,7 +15,7 @@ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) return -1; } -void xen_piix3_set_irq(void *opaque, int irq_num, int level) +void xen_intx_set_irq(void *opaque, int irq_num, int level) { } -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517311.802462 (Exim 4.92) (envelope-from ) id 1pjEou-0000kS-QN; Mon, 03 Apr 2023 07:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517311.802462; Mon, 03 Apr 2023 07:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEou-0000ie-J4; Mon, 03 Apr 2023 07:41:40 +0000 Received: by outflank-mailman (input) for mailman id 517311; Mon, 03 Apr 2023 07:41:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEos-0000Sf-IM for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:38 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7281ec2-d1f2-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 09:41:37 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id t4so23024662wra.7 for ; Mon, 03 Apr 2023 00:41:38 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7281ec2-d1f2-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YTX5AlYG9H9wezF7Huuxzz/nE/nKnDO8ny1qnuzLZhc=; b=mtSXWDOaZ+SoOSRY+/QyXRKvT4i+55X7WZtDYWMATiHisig086+0JsHukwNdiJId7A tFqxCAoC4RwIQJM009Vk+jfFfOFlaKQrlmk2bTXjnhvW4+CF9lMXfKv1wHR3ukRMZW6Y CQyFaG+VXbo7bsLaY3JNaZ0O5jKXrhP2qIEG72Vjgf8MVH9BIMi5d+VGm5MfsEvzCudI GyrjyuNPJZrO+zweLhjAv7NojvLIUzr0fIDB8FyORUM/z/yAaS2dYmbZmQwIZzFXhz4c p7LFtBj/nJrdJSF6L2IGVCFNtgwR5DHDosc59QA+1G+LMTWWcV3o/frA6tmQ3zvYZ538 VF4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YTX5AlYG9H9wezF7Huuxzz/nE/nKnDO8ny1qnuzLZhc=; b=AaGVptg30OZFuThAwmbjtugwjA87nIW8QbuDTEHAzXmyftRhPKHE3q7M1ZaJomU6m8 t/G6SZmG66qvyPNbGXlJdkm4Iw9WZfkDGTfPJWSvYwOvJpalESOk3t/xLJkTseM25M7J fWyK21RCy0VQ4VQwSGdSMN2vYvEogq0mpxhJujwotDzk1namkTN8YbAtG+KZp8kKA1MF XPxa/Yk/LcZuZAiMsSGZQkOAUKghYMa3BJbD5K8p1Y/KUCWYXRdRzi5fNXj2+ECJQc07 bdM647XOqleZUkHQY1gBvV2gZG6JTyH7d1X9w7kvLG+FQUdkpWqZr5fyDCdWx4o1Yroe gq2g== X-Gm-Message-State: AAQBX9caUHF64emzsEUrgQvyZk1mPrV+Munuk6rVUwq9r8nXpbbj9s6s TGVs+5GrHExRL8kI8c46Afw= X-Google-Smtp-Source: AKy350aggVxi8ptGEF+kz7DCXq42gtEfYkUb6ffP2AHigP6K835TVXtAlFx6fFv21AA1vyoQLxAQyA== X-Received: by 2002:adf:f388:0:b0:2db:46ad:7e82 with SMTP id m8-20020adff388000000b002db46ad7e82mr25915768wro.47.1680507697657; Mon, 03 Apr 2023 00:41:37 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 3/7] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize() Date: Mon, 3 Apr 2023 09:41:20 +0200 Message-Id: <20230403074124.3925-4-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a preparational patch for the next one to make the following more obvious: First, pci_bus_irqs() is now called twice in case of Xen where the second call overrides the pci_set_irq_fn with the Xen variant. Second, pci_bus_set_route_irq_fn() is now also called in Xen mode. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-3-shentey@gmail.com> --- hw/isa/piix3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index 1b3e23f0d7..a86cd23ef4 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -394,7 +394,7 @@ static void piix3_xen_realize(PCIDevice *dev, Error **errp) PIIX3State *piix3 = PIIX3_PCI_DEVICE(dev); PCIBus *pci_bus = pci_get_bus(dev); - pci_piix3_realize(dev, errp); + piix3_realize(dev, errp); if (*errp) { return; } -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 07:41:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 07:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517312.802483 (Exim 4.92) (envelope-from ) id 1pjEox-0001R2-37; Mon, 03 Apr 2023 07:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517312.802483; Mon, 03 Apr 2023 07:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEow-0001Qp-UM; Mon, 03 Apr 2023 07:41:42 +0000 Received: by outflank-mailman (input) for mailman id 517312; Mon, 03 Apr 2023 07:41:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjEov-0000Sg-Cv for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 07:41:41 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8582e01-d1f2-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 09:41:39 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id m2so28256907wrh.6 for ; Mon, 03 Apr 2023 00:41:39 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm8414960wrr.100.2023.04.03.00.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 00:41:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8582e01-d1f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680507699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MUDyOxROyX57/HeZfnPOMpR49OmyPgdDYS4l8CKR3oE=; b=R0zQZHS1SVM2nbqIZon4bg3J/Tgs443HdjKKqxyVKw/W6M8PKg6fF5HqP9chCuyiBZ HJkytr0cpW/VhAlTB3rKHnd519d/mvwUbFIWVLXIvNSr48AXF6vTFq6fJUcOUmUH1iyB ueVnC/xQZaZZHpFPSVhx5W9HBRQbsjok895nYAKptZCyOKoD4Ib82ypomuw9roljaWLe IbWXzVNtIq89BY8uwqhgoY21w0gcpO0L4vbRyFCz5FSL/pxc3tWZ8/gLXOuRE9RPqc0/ 6HjlOpoi2+VFwd5ZeD8MBrf7WTl2dA38nm35BVoLZzH5VWDCu+75pIfnCT84gtQ11hI1 Ozwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680507699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MUDyOxROyX57/HeZfnPOMpR49OmyPgdDYS4l8CKR3oE=; b=pyFym8FJryc37DMfPoMm0BNvathFLweFfvcs7lUdvXHbcLej+Up5li25tFq49LECuA uUGCy7pWwV6hcVyf3XUrrQ/6l7G0CUMbM1d1XTvSCU52V1JFUSLC7jKbnBOVJtEM0dRY +cBnrSrtMMEahxFK13XwSwgsqgQmqSsyebogy1u89YeLn2HphjQz4Fy226sctWfmtMY8 oxUMUUcVZPcwgJLBz0VzCMXpXpDmvokx22Vd1lyQZMNLevA8E5cs0takLFX7jomlwP8s tsXZJt1MwPoIdrL1556IPL6kPd5wO8U+LDxscuRBjR+0ud9bbi+3w6pPPEPr0TVI12P8 Qb7g== X-Gm-Message-State: AAQBX9fzzLab9MPnFqvnemnaAMGARgIZLqHd5wciCDkYm3V2mHvvDaiC stjTS8S4H8yRwtsreAnqTRo= X-Google-Smtp-Source: AKy350Z1aIPseQR+1yV2swwLLDz0AEwlN4YYIJAKAq+O5S9egcGZLOBJfv2d/bu2tqMGfhvjE7XU2g== X-Received: by 2002:adf:ed0e:0:b0:2d1:86e6:bd6 with SMTP id a14-20020adfed0e000000b002d186e60bd6mr26015599wro.22.1680507699461; Mon, 03 Apr 2023 00:41:39 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Richard Henderson , Marcel Apfelbaum , David Woodhouse , Eduardo Habkost , Stefano Stabellini , Chuck Zmudzinski , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paul Durrant , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Anthony Perard , xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v4 4/7] hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3 Date: Mon, 3 Apr 2023 09:41:21 +0200 Message-Id: <20230403074124.3925-5-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403074124.3925-1-shentey@gmail.com> References: <20230403074124.3925-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_intx_set_irq() doesn't depend on PIIX3State. In order to resolve TYPE_PIIX3_XEN_DEVICE and in order to make Xen agnostic about the precise south bridge being used, set up Xen's PCI IRQ handling of PIIX3 in the board. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-4-shentey@gmail.com> --- hw/i386/pc_piix.c | 13 +++++++++++++ hw/isa/piix3.c | 24 +----------------------- 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 30eedd62a3..99232701b1 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -69,6 +69,7 @@ #include "kvm/kvm-cpu.h" #define MAX_IDE_BUS 2 +#define XEN_IOAPIC_NUM_PIRQS 128ULL #ifdef CONFIG_IDE_ISA static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; @@ -236,6 +237,18 @@ static void pc_init1(MachineState *machine, pcms->bus = pci_bus; pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); + + if (xen_enabled()) { + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + piix3 = PIIX3_PCI_DEVICE(pci_dev); piix3->pic = x86ms->gsi; piix3_devfn = piix3->dev.devfn; diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index a86cd23ef4..7a31caf2b6 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -34,8 +34,6 @@ #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" -#define XEN_IOAPIC_NUM_PIRQS 128ULL - static void piix3_set_irq_pic(PIIX3State *piix3, int pic_irq) { qemu_set_irq(piix3->pic[pic_irq], @@ -388,32 +386,12 @@ static const TypeInfo piix3_info = { .class_init = piix3_class_init, }; -static void piix3_xen_realize(PCIDevice *dev, Error **errp) -{ - ERRP_GUARD(); - PIIX3State *piix3 = PIIX3_PCI_DEVICE(dev); - PCIBus *pci_bus = pci_get_bus(dev); - - piix3_realize(dev, errp); - if (*errp) { - return; - } - - /* - * Xen supports additional interrupt routes from the PCI devices to - * the IOAPIC: the four pins of each PCI device on the bus are also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pci_bus, xen_intx_set_irq, piix3, XEN_IOAPIC_NUM_PIRQS); -} - static void piix3_xen_class_init(ObjectClass *klass, void *data) { PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); k->config_write = piix3_write_config_xen; - k->realize = piix3_xen_realize; + k->realize = piix3_realize; } static const TypeInfo piix3_xen_info = { -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 08:09:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 08:09:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517336.802523 (Exim 4.92) (envelope-from ) id 1pjFFP-0007bL-5b; Mon, 03 Apr 2023 08:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517336.802523; Mon, 03 Apr 2023 08:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjFFO-0007bC-Vy; Mon, 03 Apr 2023 08:09:02 +0000 Received: by outflank-mailman (input) for mailman id 517336; Mon, 03 Apr 2023 08:09:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjFFN-0007b6-Pk for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 08:09:01 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9b68f38-d1f6-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 10:08:59 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id eh3so113709905edb.11 for ; Mon, 03 Apr 2023 01:08:59 -0700 (PDT) Received: from [127.0.0.1] ([62.214.191.67]) by smtp.gmail.com with ESMTPSA id r30-20020a50aade000000b004f9e6495f94sm4252444edc.50.2023.04.03.01.08.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 01:08:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9b68f38-d1f6-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680509339; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=h7gZ4I+1THSU6WybzqtCa4itJGFjNPYCsJ3+ZxZ33L8=; b=g/yKJq8X2JpUJmxLRLkfW2Ei4bn+orZIp2D0WXpN1GZ8fDDktL6EaELr85Ejz5DqtK M2UYewx344latdwSIgrNpZqcOWCSxZPSz9KPBE08Fjt7braFb+Cn0U59CmirAOW6iLiy rC8auNdRyR0+Pgrda8sTcY8swp8rvrDMlM4Ci/izaFEF7vWBVKv6zJaY8Vn/59ZZso0B QSad5dETKrLhgqX+jCTxh6+1yopnRJzr94Kcc+ZXunE0a4h2viUpjqtvwpIvJFVIN+6X iDVk7Ii3wNE+Pz1f7gL5LFqzch0JlgA2B2dqA+6KAgy0pdh0b+dGQiY65MHJdvvQMfeW mjrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680509339; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h7gZ4I+1THSU6WybzqtCa4itJGFjNPYCsJ3+ZxZ33L8=; b=J6bRAIy3ehyy04imOdbPeu3Fe/XVzF3KCO3t0ag4JCMtXJLuD7Wokd9uIKqAqXV8sX rPK3FrnxZt50kto/1X0XNzzAgPEVA3zUYKei2KwJiywdGmfm9OPTxck9W2frwrzbNTDU Mu/r6S8wN39hNEszb0Aqj8Zcge5iBhvsxknFWs4yxtrRJ8nW+sPwu+VbGJv0jJNr6xYQ hX7vgn2NYXSjOnT1VtSesxDojVypjaNjFHtg9PGDaW+xf4Gvcl4E2/xJmR7SYx1MXet7 h4K0ytS0lcgHYEt0ftsFDcK92/I1Py9BQCXlxw2+kHEt7jr907omOBHpfJ2DSe+UWDlI S1zg== X-Gm-Message-State: AAQBX9cDPxIYsi6YOnHou/itiU6rRKwgr7gguXlrRX1b9xmICJ7N6gmZ ESCoPkvdb9KC2sqS5ELYgSY= X-Google-Smtp-Source: AKy350YggZvBQRQXxduHGJx+5C4Cd2Q1/ABqM+BmlNa87irJ7SgtPy2crbAhiUHp2jFkWurGwsvNoA== X-Received: by 2002:a17:907:8694:b0:947:c221:eb38 with SMTP id qa20-20020a170907869400b00947c221eb38mr11083800ejc.13.1680509339124; Mon, 03 Apr 2023 01:08:59 -0700 (PDT) Date: Mon, 03 Apr 2023 08:08:49 +0000 From: Bernhard Beschow To: Anthony PERARD CC: qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , David Woodhouse , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Eduardo Habkost , Paul Durrant , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefano Stabellini , Richard Henderson , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Chuck Zmudzinski Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_2/6=5D_hw/isa/piix3=3A_Reuse?= =?US-ASCII?Q?_piix3=5Frealize=28=29_in_piix3=5Fxen=5Frealize=28=29?= In-Reply-To: <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> References: <20230312120221.99183-1-shentey@gmail.com> <20230312120221.99183-3-shentey@gmail.com> <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 1=2E April 2023 22:36:45 UTC schrieb Bernhard Beschow : > > >Am 30=2E M=C3=A4rz 2023 13:00:25 UTC schrieb Anthony PERARD : >>On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: >>> This is a preparational patch for the next one to make the following >>> more obvious: >>>=20 >>> First, pci_bus_irqs() is now called twice in case of Xen where the >>> second call overrides the pci_set_irq_fn with the Xen variant=2E >> >>pci_bus_irqs() does allocates pci_bus->irq_count, so the second call in >>piix3_xen_realize() will leak `pci_bus->irq_count`=2E Could you look if >>pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs() >>call, or maybe some other way to avoid the leak? > >Thanks for catching this! I'll post a v4=2E V4 is out=2E Thanks, Bernhard > >I think the most fool-proof way to fix this is to free irq_count just bef= ore the assignment=2E pci_bus_irqs_cleanup() would then have to NULL the at= tribute such that pci_bus_irqs() can be called afterwards=2E > >BTW: I tried running qemu-system-x86_64 with PIIX4 rather than PIIX3 as X= en guest with my pc-piix4 branch without success=2E This branch essentially= just provides slightly different PCI IDs for PIIX=2E Does xl or something = else in Xen check these? If not then this means I'm still missing something= =2E Under KVM this branch works just fine=2E Any idea? > >Thanks, >Bernhard > >> >>> Second, pci_bus_set_route_irq_fn() is now also called in Xen mode=2E >>>=20 >>> Signed-off-by: Bernhard Beschow >>> Reviewed-by: Michael S=2E Tsirkin >> >>Beside the leak which I think can happen only once, patch is fine: >>Reviewed-by: Anthony PERARD >> >>Thanks, >> From xen-devel-bounces@lists.xenproject.org Mon Apr 03 08:58:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 08:58:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517340.802533 (Exim 4.92) (envelope-from ) id 1pjG17-00053x-Rx; Mon, 03 Apr 2023 08:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517340.802533; Mon, 03 Apr 2023 08:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjG16-00053c-Pe; Mon, 03 Apr 2023 08:58:20 +0000 Received: by outflank-mailman (input) for mailman id 517340; Mon, 03 Apr 2023 08:58:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjG12-00051H-RF for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 08:58:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8ff499d-d1fd-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 10:58:13 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 04:58:01 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BY5PR03MB4950.namprd03.prod.outlook.com (2603:10b6:a03:1e1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 08:57:58 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 08:57:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8ff499d-d1fd-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680512293; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=sIJr1DpFzFESjuG658Iht8tRP4KhsgK2Pqw9uQ1tb0k=; b=BqDIm73rGlRPu7zFnE0/Q/cmp3tPB7Gmc75YLjVS9FjYHlouKO9rso7W eQgJRLj4fl4VtxymQThyjzPOwGmHXQxxjW3TK3M8emetyAYivEB4jjpXL eUfCfTZPeIaB9NPUFesobDasi9TC4G8xVK+I8FeivkSsR05cHk6SNLYwL A=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 104500074 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:w8onRqscBbgJnBvfEsa33cPBz+fnVHdfMUV32f8akzHdYApBsoF/q tZmKWvVb6rcZ2r8KN8nOojgpEMHuJPRn9JjGQA6ryExQywX+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGzCFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwaxs1VUCIl+mMneirccw1ipwtEcTuBdZK0p1g5Wmx4fcOZ7nmGv2PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60aIG9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAN5PTOXgqaICbFu7+zwYGT4zcECCsNKfqnGRCt5DE VEt5X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO0cSCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptXm/oc6i0uXSs45SfbuyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CKvZ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:Q2u7z6nXACZYU6U1u0NBJVll0HXpDfLa3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRcdcLW7UpVoLkmyyXcY2+cs1PKZLWvbUQiTXeZfBOnZsl7d8kTFn4Yw6U 4jSdkaNDSZNzNHZK3BkW2F+rgboeVu8MqT9JjjJ3UGd3AVV0m3hT0JezpyESdNNXl77YJSLu vk2iLezQDQBEj+aK6AdwE4dtmGnfLnvrT8byULAhY2gTP+8Q9BuNbBYmOlNg51aUI0/Ysf X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="104500074" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i0CkQzkp9lDYeT1y5/ecnK9MeaqWs+QPfjTuNQvSByp3ULQw6QKvoT+pqlcYKicsHlYoDPh5YS8iXdW0L++ftTowkzK3BEgEIS5lzwydy7ByP/si9hpVCYB5KD7Hbynj232bb+fr+tIp9cYDxSkSF1uf9QtNmL78tVYKKywdDwhCvsnWaYsE+ts1FoSZSC+U+mOjdIyqfKKphwsY2o9IEczrQXwktqBETDpfP2p/EUZlWS9Fypg4yPyoqr8OGl7hfK73dD1wh0MPhkzTSmDYRUEIqIP5VVnzI0sLjDnAvbJBX45h2EDglI1in/cjShSnMu5/IUGDvH8T8HuNU9O8YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xf3yZJpNniIwd+LVSfWWmL7nhLZsXRRI19tvZcvt07g=; b=HAK+4Uny4llysaBC7W4EPOpcM5b26rinJB3crCbrkepXYk8rdRPuRLFOHTVe5kPVWH2yjCSVHWMCmSZ+svNru/ToOYLhz6vBISSgIY8lmZIyBcSqIXY8O3KSoCLl3QNWjdfI4iGN4ukZjusC/GOQP9d1z+bjBcCvacuPyYy+eo83ivXBs6GoDDBTpaXsd1ofqfSFP4BnTjAWoQchAjdeYAvNGppaWeMblUaP/DjOhnF/HM3lLtT7U1sXCtuJup9vUKP/umgg5aW1yhs3DrI033M4b57pMiUYG+NVUexyr2+GqmdwUc4P3OlOh/m/RFCYiMsUCtztZoKRbBxLXw7+iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xf3yZJpNniIwd+LVSfWWmL7nhLZsXRRI19tvZcvt07g=; b=JPNT9cnkz5roi6FXlBBe+OPXbxNa4cCsw/B6QqJQN1yY/NvxKwN197EK7eWBcbdPQ0LXttYNtKGc38hFfK4iX/r68xmCfj9Jzmxtb+6wnJx5nQYaauSVrfeGnkoMF0zYCuh0EAGqMuQ3ll/FfA/pbRk70xlIsp+pig6JsGsW3TI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 10:57:52 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Message-ID: References: <20230331175719.500285-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230331175719.500285-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P123CA0032.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB4950:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b6339fd-7c7c-4ba8-b985-08db34218595 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J7D6imCPUVXcFC92XXRAvmOK5LGdg+GYXofDgK1W32VRJpp75sg6CQJ0/cEI3hDGVxfCS0aRkOHrgE6FJqNhX+rYCd2OCqSVO9SbBxaDwTwCo4W5xU9rusnjQjqu5iAGdNRWXV3CAxUOly3avdN752TovD+69bVdK8FcjR14BxZO6H2Wc5ypiWUARZNVkAFplD3KAaQo6j5CfuM56wFMLalZYXCY5TdMl0QayysMq9dsbVm5hgVM2lwFJl/5Rvnc95jO11ABHwmRAK+gf+/n2Lli7UK/2gr9eLhy2rlgL6vpnoyBb2b3OxSbzuQinc8nxHPimCBr6oVa9x7E2HOSuU9yTi66Jkj9UCCarv2me3bksZu72YXqGTd2sUalapkkhFCwT84seEeeOFx147IbfUQ3bxSXoRMSjfaxX7in2nFThpFBHp/ke6uDPRQWmesZekip1v28FGF3gLBl5E+mVLzmqvYp1hM7mgUgtJKttsBGnhgzZTvgGhEcgMu+vkXOngRl9ljqj2usYvEH3tUwjXV9YiT4aiMQB24kj/1aEpO50PYKh3j91R2Wnl7FekCd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(376002)(136003)(366004)(346002)(396003)(39860400002)(451199021)(82960400001)(83380400001)(8676002)(4326008)(66946007)(66556008)(86362001)(66476007)(2906002)(41300700001)(316002)(33716001)(54906003)(478600001)(6636002)(85182001)(38100700002)(6486002)(6862004)(8936002)(5660300002)(9686003)(6512007)(186003)(6666004)(26005)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amZ4cURTbDZIWFFCTmg5NzJsK1hleGRYV2tWRXhhOURJcDlKVE00c2J5dXJS?= =?utf-8?B?KzJxWFppdDNPeXF0bHhUM0E2NUpPSHIydGp1WkVkOXpEN2c2bS8zSTJlT1Vo?= =?utf-8?B?Y1dlOXIrSXNkMUdzYjNPWjZTOGRub3p0cFZST3RteS84bk1pK0JrMWxtdVFx?= =?utf-8?B?QnM5TnY5WUErTlVEUmRyV3IyWTZCOVU1WmJGSUREc2ZUQUUxTVZqdjNKaFpt?= =?utf-8?B?N04wTnR1TkpKWkgvNWN6WkdCQWsrSGNxNS9KWlpKbTNLSDlQZkZJclVlN252?= =?utf-8?B?ZGhnb1R2S1RuSy9LQWtmWjJuUnVuM3dzR29rc2E5WGlEaDFYbFRJalhQaTNN?= =?utf-8?B?enE1NFZRTTAyem5ja3ZCZkFERUZzZ2NzRlRJbnpqU3laQUdZcEM4NmVidFpW?= =?utf-8?B?V0haWmVWOTZoZWc4QlAyMFBUcEpXbUZEK0kwOGpIZTdEaGRqWDhhRGI0REhH?= =?utf-8?B?RDQ5VVM0WW0xTnQ3YjhpTDlKc05IeGhWeUIxTCtTSmRuY3AyQndyV2x0UTc2?= =?utf-8?B?eEMwRERacWFyNFF4eHBwUkgyaTJsanNCZVNZcFRnNFFDN0Fpa1FvMDRsMGQx?= =?utf-8?B?OEwybXV0Yi94L3VucXFkRC9Ea3JsWmRUUDYwSWQ1cGgzWVY5cE9kYUhXV0ZW?= =?utf-8?B?L21lczFPKzhSekhsQ0NGUUU0dVVyS3p1d2JGNTFyVzhSQlluVG0zRGZMMnd4?= =?utf-8?B?UVBjY0JiWDF0Y1JUcVRWd0prZDFkb20wVmJlVGZBanowNXlMc1l6eXJPUHBM?= =?utf-8?B?TG9iN2JVcEUzSnVqUFB1ZUdodElvTHowQ2UvM243R3lWS0J3UmZvWlZ4a1Vv?= =?utf-8?B?Zkl2dUoybkZ1RmpWQVhCWXhROXZnOTBuMi9BUitPb3EyQVJxWXEySlRWVkkx?= =?utf-8?B?cVdQZU10TkJodUh6VkplY1pNUXdiWEhrbTRUMUhXMDNCL01GdGwwSnBSeFc4?= =?utf-8?B?SndiZDM0Q1ZkaXljSzdyUWt1MWVDZWdOT0svWEJqS1BRMWw2LzE5S3FGYWho?= =?utf-8?B?WVJjZFcvdU5ob0k0WjY1Q3dhV0JxcnR2YzF5ZEluV3VuQmZLbElGT1doT3hm?= =?utf-8?B?SHpXanZISEdzUW9TUzFJSmNEOUFLZUQrWHpSZlRZVWpmeUVrMnRuSlRqditk?= =?utf-8?B?MlorUFZRaUV2U1FRWU9nRkhSVHBZR3YySW50amtmQ0tmaG9IV2Z5YmdwK1lE?= =?utf-8?B?V3BMMXlTcVdlQUpVZDJzaWppdis2d1NUZVVuNEFWSlIrVVRGdVBlazFHTzFu?= =?utf-8?B?TXp2cjBjVnRBZmRFTWVxaVpyT1JrbCtSOURSS0ZoVnFTWEg5czRNMlBWd1hE?= =?utf-8?B?dUNKTFY1dkx2djlVcDFBQkZjMTd5V2JMN000Mll4WWZhUEFOL0NtWmVkR0Y1?= =?utf-8?B?WHVKc1NvNk1XMEFSZmRQek93KzRBcVkvOEkwaWJKRXJndlFxalo5cUlnR0s5?= =?utf-8?B?TUVrV0I1dHc3NFhxeUFWdWQzclFNWlIzSkpFRmh0dVhjOFBMS0ZCUlg0RENm?= =?utf-8?B?dmc3bUE1QmFMZk5RQmxXR1l2SDBjRW94eklUaU1tTXZmV0x0cnJkdm95Vjd1?= =?utf-8?B?VEQ4VUJuY2Y5WTVFNzAvZzVrNko3cmxxOTZodjVzM0VOcGl3V3NkNGhnaWMv?= =?utf-8?B?SnZKN2RQSFN1RkJPSWhOMjZmdzhxR3NkQUlKTlY0QWg3cno1MzY2SkNvcVBj?= =?utf-8?B?eUxBZWp1blo2RnhlR3RHUnpCYUUvQUJwdWgwWlVPS1AxL011UjAxTWdKUjFI?= =?utf-8?B?M2k0R3YrQnpqNUxXMEJMVG9xaGZUb3pKN3NuVStzQzVUZ2lvWldrdkpNUzFV?= =?utf-8?B?U3VzVDl4R3kzK0ZGb2JhUVRMYWF3NFBTeHVqTEtJOCtrWkw4QVVZKzZINjVF?= =?utf-8?B?ZlN5U3NOcUZOSzlhMDFFbU81dzF6R0F0VGt0b3poT2dxWHhPZ29sVy80MnpN?= =?utf-8?B?eStHeHRjek1laHhjQmpJOFFaM1FLRk81THg5L0pmZXJQcjkvUnpaY093SmpU?= =?utf-8?B?Ui9sUFhwYkgxRzVTa0FBcUhMRG1CR01Hc0t5TWZDSXErT1hySXp0bnBHVXBv?= =?utf-8?B?a1dKMGsrck5DTW1vUThvVmx1NGxROEdjMjlkdVNYN25BZzc2NUFVK0oyT1VZ?= =?utf-8?Q?nqKQ315XYiX6n/S5lDFgH5C+C?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: szt51JlSFrCauktts5mbwXId76pM7TsqI148Nzc8DDagaOb7dh3FnESfge4IfIr4C4/emJruiFhttOlYAgknN12Lq2t832Fw8DabWa/hTv4yR8DXjkE4UeGVHGSHHBprSKHEgguF/mtQdSLMA+2IzanhqJk39c5bfY2pY7/wwvGTeg5aOm8kwJq2z9Ipdkkjmh/vD9NnM5jz4G7jakvobjmg/fB+C5usgYoRkubPE1R1aWdn60SIlrxbJVcZglH2xpbCeIGl8yBc8iX20p/3IX/cNyuwkFjd9AcMmeLj6QPCX4xXyECZ+UMpYbMqjzQeBaAW00tu6gu4OMZ6KYLqR6GveUzKCy8pf6Gjhz9QrNlDuxO9F0HewF4HBAGlj2TtsWrAdDcGiBrHDfRJ6HJw5CBenhtLc2nj2acK9Il+CqApdIqh3Zn3hOgI7ldjf0VPmp4uRtdtBSOx5gi623lninZ1+CeJrOpTc0dRpeo7rssLQBBlYqGBRlOmQelKxDPHt/EDlWkohMNbWQWEv5EW9P8k+6SDlcB3CSVdou5Av5MRPfocxFBpScmA6O7IGrapX/lUG6bsbepMP68emKsQ7RjHD/PSgmu0wKxrn5vYeI7AX4FpQ4M16HDS5k/5cYYbtvQiiHf6sSOBqRZpaAjHlW4BHbNO/UHX3p86SmORE5JUOEn0nEJXouqLyHdxZKZDoWQWQU2z0zpA9KyOiFRCXdomYsh0Tjsrwztsq7g7nsUy6LGh5fajL3VLokBoHZQu6n4A2h8UGFZK8f2GNmhLmUFW+Qi1oZKQUeusnpxxfQn1TnW673KgV3aVqRjcuOMr X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b6339fd-7c7c-4ba8-b985-08db34218595 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 08:57:58.4949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x4sf1BWTabxoH/ANDiNIm8XLslx6OjkoxyLk3/RQqHVQ9zJhleequIS75bAWjSaYgn66FzA+MjVlTf6xaMPwJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4950 On Fri, Mar 31, 2023 at 06:57:19PM +0100, Andrew Cooper wrote: > This started by noticing the dubious Fam17h check in > arch_ioreq_server_get_type_addr(), and then realising that checking the host > CF8_EXT setting is utterly bogus for the guest <-> qemu emulation path. > > What should be consulted here is the guest's MSR_AMD64_NB_CFG setting, but a) > there isn't one, and b) the vestigial remnants of the cross-vendor migration > logic cause MSR_AMD64_NB_CFG to be unconditionally read-as-zero, making the > CF8_EXT path unused by any suitably-written OS in the first place. > > MSR_AMD64_NB_CFG really has been removed on Fam17h (it's now just a read-zero, > write-discard stub), and the ECS extension is unconditionally active, meaning > it is not correct for Xen to ignore the ExtRegNo field on newer AMD CPUs. > > It turns out that Xen did even have this behaviour in 4.5 and earlier, with > this problematic CF8_EXT checking being added in 4.6. Therefore, revert back > to Xen's older behaviour - it is objectively less wrong than the current > logic. > > While fixing this, get rid of hvm_pci_decode_addr() - it is more complicated > to follow (and to call) than using the CF8* macros in the calling context. > Rename CF8_ADDR() to CF8_REG() to better describe what it does, and write a > comment explaining all about CF8/CFC accesses. > > There's one rare case when CF8_EXT is visible to guests, and that is for a > pinned hwdom. Right now, we permit such a dom0 to modify the CF8_EXT bit, but > this seems like a very unwise idea. Leave a TODO for people to consider. One weirdness I've noticed is that for vPCI we decode the accesses taking the extended CF8 bit after this change, but then if the access is relayed to the hardware using vpci_{read,write}_hw it will be forwarded to the hardware using pci_conf_{read,write} which doesn't have support for CF8_EXT. So if the underlying hardware doesn't have MMCFG support and the reg is > 255 it will be dropped. > Fixes: e0fbf3bf9871 ("x86/AMD: correct certain Fam17 checks") > Fixes: 2d67a7a4d37a ("x86: synchronize PCI config space access decoding") > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > Whoever reviewed those two patches originally was clearly a fool... > --- > xen/arch/x86/hvm/io.c | 24 ++++++------------------ > xen/arch/x86/hvm/ioreq.c | 19 ++----------------- > xen/arch/x86/include/asm/hvm/io.h | 4 ---- > xen/arch/x86/include/asm/pci.h | 26 ++++++++++++++++++++++++-- > xen/arch/x86/pv/emul-priv-op.c | 19 ++++++------------- > 5 files changed, 38 insertions(+), 54 deletions(-) > > diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c > index 5ae209d3b6b3..b0d3c236e985 100644 > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -248,20 +248,6 @@ void register_g2m_portio_handler(struct domain *d) > handler->ops = &g2m_portio_ops; > } > > -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, > - pci_sbdf_t *sbdf) > -{ > - ASSERT(CF8_ENABLED(cf8)); > - > - sbdf->bdf = CF8_BDF(cf8); > - sbdf->seg = 0; > - /* > - * NB: the lower 2 bits of the register address are fetched from the > - * offset into the 0xcfc register when reading/writing to it. > - */ > - return CF8_ADDR_LO(cf8) | (addr & 3); > -} > - > /* vPCI config space IO ports handlers (0xcf8/0xcfc). */ > static bool cf_check vpci_portio_accept( > const struct hvm_io_handler *handler, const ioreq_t *p) > @@ -275,7 +261,7 @@ static int cf_check vpci_portio_read( > { > const struct domain *d = current->domain; > unsigned int reg; > - pci_sbdf_t sbdf; > + pci_sbdf_t sbdf = {}; > uint32_t cf8; > > *data = ~(uint64_t)0; > @@ -292,7 +278,8 @@ static int cf_check vpci_portio_read( > if ( !CF8_ENABLED(cf8) ) > return X86EMUL_UNHANDLEABLE; > > - reg = hvm_pci_decode_addr(cf8, addr, &sbdf); > + sbdf.bdf = CF8_BDF(cf8); > + reg = CF8_REG(cf8) | (addr & 3); > > if ( !vpci_access_allowed(reg, size) ) > return X86EMUL_OKAY; > @@ -308,7 +295,7 @@ static int cf_check vpci_portio_write( > { > struct domain *d = current->domain; > unsigned int reg; > - pci_sbdf_t sbdf; > + pci_sbdf_t sbdf = {}; > uint32_t cf8; > > if ( addr == 0xcf8 ) > @@ -323,7 +310,8 @@ static int cf_check vpci_portio_write( > if ( !CF8_ENABLED(cf8) ) > return X86EMUL_UNHANDLEABLE; > > - reg = hvm_pci_decode_addr(cf8, addr, &sbdf); > + sbdf.bdf = CF8_BDF(cf8); > + reg = CF8_REG(cf8) | (addr & 3); > > if ( !vpci_access_allowed(reg, size) ) > return X86EMUL_OKAY; > diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c > index 0bdcca1e1a5f..325a9d118e52 100644 > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -285,27 +285,12 @@ bool arch_ioreq_server_get_type_addr(const struct domain *d, > (p->addr & ~3) == 0xcfc && > CF8_ENABLED(cf8) ) > { > - unsigned int x86_fam, reg; > - pci_sbdf_t sbdf; > - > - reg = hvm_pci_decode_addr(cf8, p->addr, &sbdf); > + pci_sbdf_t sbdf = { .bdf = CF8_BDF(cf8) }; > + unsigned int reg = CF8_REG(cf8) | (p->addr & 3); > > /* PCI config data cycle */ > *type = XEN_DMOP_IO_RANGE_PCI; > *addr = ((uint64_t)sbdf.sbdf << 32) | reg; > - /* AMD extended configuration space access? */ > - if ( CF8_ADDR_HI(cf8) && > - d->arch.cpuid->x86_vendor == X86_VENDOR_AMD && > - (x86_fam = get_cpu_family( > - d->arch.cpuid->basic.raw_fms, NULL, NULL)) >= 0x10 && > - x86_fam < 0x17 ) > - { > - uint64_t msr_val; > - > - if ( !rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) && > - (msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT)) ) > - *addr |= CF8_ADDR_HI(cf8); > - } > } > else > { > diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h > index 54e0161b492c..3f3fb6403ccb 100644 > --- a/xen/arch/x86/include/asm/hvm/io.h > +++ b/xen/arch/x86/include/asm/hvm/io.h > @@ -144,10 +144,6 @@ void stdvga_deinit(struct domain *d); > > extern void hvm_dpci_msi_eoi(struct domain *d, int vector); > > -/* Decode a PCI port IO access into a bus/slot/func/reg. */ > -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, > - pci_sbdf_t *sbdf); > - > /* > * HVM port IO handler that performs forwarding of guest IO ports into machine > * IO ports. > diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h > index f4a58c8acf13..3b814f4ebacf 100644 > --- a/xen/arch/x86/include/asm/pci.h > +++ b/xen/arch/x86/include/asm/pci.h > @@ -3,10 +3,32 @@ > > #include > > +/* > + * PCI config space accesses with CF8/CFC: > + * > + * 1) Write {Enable | BDF | Reg} to CF8 to set an address > + * 2) Read or write CF{C..F} to access the register > + * > + * For sub-dword register accesses, the bottom two register address bits come > + * from the CF{C..F} address, not from CF8. > + * > + * AMD have extention to this protocol to access PCIe Extend Config Space by > + * storing the 4 extra register address bits in the penultimate nibble of CF8. > + * This extention: > + * - Is unconditionally active on Fam17h and later > + * - Has model specific enablement on Fam10h thru Fam16h > + * - Has reserved behaviour in all other cases, including other vendors > + * > + * For simplicity and because we are permitted to, given "reserved", Xen > + * always treats ECS as active when emulating guest PCI config space accesses. > + */ > #define CF8_BDF(cf8) ( ((cf8) & 0x00ffff00) >> 8) > -#define CF8_ADDR_LO(cf8) ( (cf8) & 0x000000fc) > -#define CF8_ADDR_HI(cf8) ( ((cf8) & 0x0f000000) >> 16) > #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000)) > +#define CF8_REG(cf8) \ > + ({ \ > + unsigned int _c = cf8; \ > + ((_c & 0x0f000000) >> 16) | (_c & 0xfc); \ > + }) What happens on Intel when the bit is set, is it just ignored? We only allow such accesses for dom0 anyway. > > #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \ > || id == 0x01268086 || id == 0x01028086 \ > diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c > index 5da00e24e4ff..008367195c78 100644 > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -245,19 +245,7 @@ static bool pci_cfg_ok(struct domain *currd, unsigned int start, > if ( ro_map && test_bit(machine_bdf, ro_map) ) > return false; > } > - start |= CF8_ADDR_LO(currd->arch.pci_cf8); > - /* AMD extended configuration space access? */ > - if ( CF8_ADDR_HI(currd->arch.pci_cf8) && > - boot_cpu_data.x86_vendor == X86_VENDOR_AMD && > - boot_cpu_data.x86 >= 0x10 && boot_cpu_data.x86 < 0x17 ) > - { > - uint64_t msr_val; > - > - if ( rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) ) > - return false; > - if ( msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT) ) > - start |= CF8_ADDR_HI(currd->arch.pci_cf8); > - } > + start |= CF8_REG(currd->arch.pci_cf8); > > return !write ? > xsm_pci_config_permission(XSM_HOOK, currd, machine_bdf, > @@ -1104,6 +1092,11 @@ static int cf_check write_msr( > if ( !is_hwdom_pinned_vcpu(curr) ) > return X86EMUL_OKAY; > if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || > + /* > + * TODO: this is broken. What happens when dom0 is pinned but > + * can't see the full system? CF8_EXT probably ought to be a > + * Xen-owned setting, and made symmetric across the system. > + */ I would assume CF8_EXT would be symmetric across the system, specially given that it seems to be phased out and only used in older AMD families that where all symmetric? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 09:25:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 09:25:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517346.802543 (Exim 4.92) (envelope-from ) id 1pjGQx-0001Re-Tw; Mon, 03 Apr 2023 09:25:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517346.802543; Mon, 03 Apr 2023 09:25:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGQx-0001RX-R0; Mon, 03 Apr 2023 09:25:03 +0000 Received: by outflank-mailman (input) for mailman id 517346; Mon, 03 Apr 2023 09:25:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGQw-0001RN-4j; Mon, 03 Apr 2023 09:25:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGQw-0003Zu-2A; Mon, 03 Apr 2023 09:25:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGQv-0000tz-Jj; Mon, 03 Apr 2023 09:25:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjGQv-0006cu-JB; Mon, 03 Apr 2023 09:25:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cQfBgwAWojfT8AROnVhNOIPTdz50paFl2+p9bIXtBX0=; b=d2Ny+2m8385vWDIL5jidQ/rLmf r5Fk2K3oAAoUvYzIuna0bbqZDxnl1BJ7a77+lCp+Vl/DYisD/GH43P6V4txq3RrUpM0cSzcdsjfPN ZO/K0exePLn821k9GpBKv2COkto+VkChjl2YfjYELl11MjtIu9FoBUaEUgkm3lg02vRw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180115: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb X-Osstest-Versions-That: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb From: osstest service owner Date: Mon, 03 Apr 2023 09:25:01 +0000 flight 180115 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180115/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 180110 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 180110 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180110 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180110 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180110 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180110 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180110 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180110 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180110 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180110 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180110 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb baseline version: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb Last test of basis 180115 2023-04-03 01:52:10 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 09:27:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 09:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517351.802553 (Exim 4.92) (envelope-from ) id 1pjGT8-000216-9M; Mon, 03 Apr 2023 09:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517351.802553; Mon, 03 Apr 2023 09:27:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGT8-00020z-6Z; Mon, 03 Apr 2023 09:27:18 +0000 Received: by outflank-mailman (input) for mailman id 517351; Mon, 03 Apr 2023 09:27:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGT6-00020t-Fx for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 09:27:16 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b82df015-d201-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 11:27:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1EAD21F8B8; Mon, 3 Apr 2023 09:27:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1C8513416; Mon, 3 Apr 2023 09:27:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 95KzNfGbKmT0YQAAMHmgww (envelope-from ); Mon, 03 Apr 2023 09:27:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b82df015-d201-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680514034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fPwYyujXO4mPZ107oiABO3rd/KXZ8IqVN1G60GG3sas=; b=iI0+eaaRv6fdlTpnFRhsapTgfyCXMoahX7PzJ0gySxojgtteAmnpXUZBnB49ZGzqLBPSKf Ditz6CbiSLcL5+eYo82Skh5xXV2wuNmqe5W88s8G8G6LNxQhgXvHIXRGMQi1SeSP7xOlGI Ic6Jq9TW/PcdIhLhAfFfFoHKlp5Bgls= From: Juergen Gross To: linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Dan Carpenter Subject: [PATCH v2] xen/pvcalls: don't call bind_evtchn_to_irqhandler() under lock Date: Mon, 3 Apr 2023 11:27:11 +0200 Message-Id: <20230403092711.15285-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bind_evtchn_to_irqhandler() shouldn't be called under spinlock, as it can sleep. This requires to move the calls of create_active() out of the locked regions. This is no problem, as the worst which could happen would be a spurious call of the interrupt handler, causing a spurious wake_up(). Reported-by: Dan Carpenter Link: https://lore.kernel.org/lkml/Y+JUIl64UDmdkboh@kadam/ Signed-off-by: Juergen Gross --- V2: - remove stale spin_unlock() (Oleksandr Tyshchenko) --- drivers/xen/pvcalls-front.c | 46 +++++++++++++++++++++---------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index d5d589bda243..b72ee9379d77 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -227,22 +227,30 @@ static irqreturn_t pvcalls_front_event_handler(int irq, void *dev_id) static void free_active_ring(struct sock_mapping *map); -static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, - struct sock_mapping *map) +static void pvcalls_front_destroy_active(struct pvcalls_bedata *bedata, + struct sock_mapping *map) { int i; unbind_from_irqhandler(map->active.irq, map); - spin_lock(&bedata->socket_lock); - if (!list_empty(&map->list)) - list_del_init(&map->list); - spin_unlock(&bedata->socket_lock); + if (bedata) { + spin_lock(&bedata->socket_lock); + if (!list_empty(&map->list)) + list_del_init(&map->list); + spin_unlock(&bedata->socket_lock); + } for (i = 0; i < (1 << PVCALLS_RING_ORDER); i++) gnttab_end_foreign_access(map->active.ring->ref[i], NULL); gnttab_end_foreign_access(map->active.ref, NULL); free_active_ring(map); +} + +static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, + struct sock_mapping *map) +{ + pvcalls_front_destroy_active(bedata, map); kfree(map); } @@ -433,19 +441,18 @@ int pvcalls_front_connect(struct socket *sock, struct sockaddr *addr, pvcalls_exit_sock(sock); return ret; } - - spin_lock(&bedata->socket_lock); - ret = get_request(bedata, &req_id); + ret = create_active(map, &evtchn); if (ret < 0) { - spin_unlock(&bedata->socket_lock); free_active_ring(map); pvcalls_exit_sock(sock); return ret; } - ret = create_active(map, &evtchn); + + spin_lock(&bedata->socket_lock); + ret = get_request(bedata, &req_id); if (ret < 0) { spin_unlock(&bedata->socket_lock); - free_active_ring(map); + pvcalls_front_destroy_active(NULL, map); pvcalls_exit_sock(sock); return ret; } @@ -821,28 +828,27 @@ int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags) pvcalls_exit_sock(sock); return ret; } - spin_lock(&bedata->socket_lock); - ret = get_request(bedata, &req_id); + ret = create_active(map2, &evtchn); if (ret < 0) { - clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT, - (void *)&map->passive.flags); - spin_unlock(&bedata->socket_lock); free_active_ring(map2); kfree(map2); + clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT, + (void *)&map->passive.flags); pvcalls_exit_sock(sock); return ret; } - ret = create_active(map2, &evtchn); + spin_lock(&bedata->socket_lock); + ret = get_request(bedata, &req_id); if (ret < 0) { - free_active_ring(map2); - kfree(map2); clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT, (void *)&map->passive.flags); spin_unlock(&bedata->socket_lock); + pvcalls_front_free_map(bedata, map2); pvcalls_exit_sock(sock); return ret; } + list_add_tail(&map2->list, &bedata->socket_mappings); req = RING_GET_REQUEST(&bedata->ring, req_id); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 09:33:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 09:33:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517354.802563 (Exim 4.92) (envelope-from ) id 1pjGYb-0003SB-RO; Mon, 03 Apr 2023 09:32:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517354.802563; Mon, 03 Apr 2023 09:32:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGYb-0003S4-Oj; Mon, 03 Apr 2023 09:32:57 +0000 Received: by outflank-mailman (input) for mailman id 517354; Mon, 03 Apr 2023 09:32:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjGYa-0003Ry-GR for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 09:32:56 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 81830ab4-d202-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 11:32:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81830ab4-d202-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680514374; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=T2DC+/OPrwDbeBS4v/+rJb1xT1/fC0TmvToGkyyaFpk=; b=Vb++4ivAJ98oU3zThEQzwRNI1RBC4bZWFUPqilCoAmHkIfa4V0ueCc49 zoxnZ9GThJVgHAJjTukAqhQ35wWmq4B5jA+I4jPRdsgguSL28P0hiZxnk co52g//8YzFfKitjCbZhA6Km6e/QOvbyGYxfmPNwZh1BMrRGf1ntK7DAg s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106520249 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:l8VL2aqdlaonzn1/kayP8Vs8ttleBmILYhIvgKrLsJaIsI4StFCzt garIBmAOPvcZ2OmL4t3YI6x8kIE6sXTz9MyQFFk/CFnEC8Qo5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzyJNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABdKNTOanOKn+oKASfhF1uYpF5jFPKpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jueoTmjWktGZbRzzxKp+XLrhtfQkRn7e6g1KIGU/+ZYvEaqkzl75Bo+CgLg/KjRZlSFc8lfJ koI9zsGoq079UjtRd74NzWhrXuZ+xIRRddUO+s97g6L1+zT+QnxLm0NVDVMbJovrME7QTYjy 1qhkNbgBDgpu7qQIVqF/LCSvzK0OAAPIGMCbDNCRgwAi/Hvv4QsphvKR8RkFui+iZvoGlnYw yiNsTMlhrM7l8MC3Lm85hbAmT3EjpHUVAMx5wjRdmu49A59P9TjYYG0gXDW4etJNoqeZlmIt nsDgNTY6u0SZbmVnTGJaPUAGveu/fntGC3RhxtjEocs8xyp+mW/ZsZA7TdmPkBrP80YPzjzb yf7vBhNzIVeMHujcel8ZIfZI98x0aHqGNDhV/bVRtlDeJ58cEmA5i4GTVSR1GDkikRqkaw5N ZqBasGqJXIbD619y3yxXeh1+acrxyQ7yUvXRJby1RPh1qCRDFafU7wFLVCNfMgw66fCqwLQm /5WL8aQwg9TePH/aCLQt4UUKDg3wWMTXM6s7ZYNL6jaf1QgQTt6YxPM/V8/U6sixIdMjefZx EGGWV5xmHj1vizpKSzfPxiPd4jTsYZDQWMTZHJ8ZQzzhyh+Me5D/49EKcJpIOBPGPhLiKctE qJbI5jo7uFnEGyvxtgLUXXqQGWOnjyPjBnGASeqaSNXk3VIF12QoY+MkucCGUAz4suLWSgW+ efIOvvzG8ZreuibJJ++hAiT512wp2MBv+l5QlHFJNJeEG21rtgyd3Kp0qFueptVQfkm+td9/ 1/PaSr0WMGX+9NlmDU3rfvsQ3iV/xtWQRMBQjizAUeePijG5GuzqbJ9vBKzVWmFDgvcofzyD di5OtmgaJXran4W6dsje1uqpIpij+bSS0hylVg1RiSVNQ3zUtuN4BCuhKFyi0GE/ZcB0SPeZ 65F0oMy1WmhUC89LGMsGQ== IronPort-HdrOrdr: A9a23:MrQ0wais0fnonQkgXQQkTigvOnBQXisji2hC6mlwRA09TyXPrb HJoB17726XtN91YhpLpTnuAtj5fZqiz+8P3WB8B9qftUzd2FdAT7sSiLcKoQeAJ8SWzIc06U 4jSdkcNDSXNzRHZK3BjjVQfexO/DCPytHTuc7ui01pRQtpL41m8gtjEx2aCEEzZCQuP+tcKL OsovBDrzCjPVAadN6yCHVAf8WrnayzqLvWJSQCDxQkrDSDhTftyJOSKWn+4isj X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="106520249" Date: Mon, 3 Apr 2023 10:32:37 +0100 From: Anthony PERARD To: Bernhard Beschow CC: , Marcel Apfelbaum , Paolo Bonzini , David Woodhouse , =?iso-8859-1?Q?Herv=E9?= Poussineau , Aurelien Jarno , Eduardo Habkost , Paul Durrant , , "Michael S. Tsirkin" , Stefano Stabellini , Richard Henderson , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Chuck Zmudzinski Subject: Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize() Message-ID: <622b9674-fffd-4634-ac30-d0db3230478e@perard> References: <20230312120221.99183-1-shentey@gmail.com> <20230312120221.99183-3-shentey@gmail.com> <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> On Sat, Apr 01, 2023 at 10:36:45PM +0000, Bernhard Beschow wrote: > > > Am 30. Mrz 2023 13:00:25 UTC schrieb Anthony PERARD : > >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: > >> This is a preparational patch for the next one to make the following > >> more obvious: > >> > >> First, pci_bus_irqs() is now called twice in case of Xen where the > >> second call overrides the pci_set_irq_fn with the Xen variant. > > > >pci_bus_irqs() does allocates pci_bus->irq_count, so the second call in > >piix3_xen_realize() will leak `pci_bus->irq_count`. Could you look if > >pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs() > >call, or maybe some other way to avoid the leak? > > Thanks for catching this! I'll post a v4. > > I think the most fool-proof way to fix this is to free irq_count just before the assignment. pci_bus_irqs_cleanup() would then have to NULL the attribute such that pci_bus_irqs() can be called afterwards. > > BTW: I tried running qemu-system-x86_64 with PIIX4 rather than PIIX3 as Xen guest with my pc-piix4 branch without success. This branch essentially just provides slightly different PCI IDs for PIIX. Does xl or something else in Xen check these? If not then this means I'm still missing something. Under KVM this branch works just fine. Any idea? Maybe the ACPI tables provided by libxl needs to be updated. Or maybe something in the firmware (SeaBIOS or OVMF/OvmfXen) check the id (I know that the PCI id of the root bus is checked, but I don't know if that's the one that's been changed). Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Apr 03 10:15:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 10:15:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517361.802573 (Exim 4.92) (envelope-from ) id 1pjHDX-0007wd-36; Mon, 03 Apr 2023 10:15:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517361.802573; Mon, 03 Apr 2023 10:15:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHDW-0007wW-Vq; Mon, 03 Apr 2023 10:15:14 +0000 Received: by outflank-mailman (input) for mailman id 517361; Mon, 03 Apr 2023 10:15:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHDV-0007wD-7U for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 10:15:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6854e9c6-d208-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 12:15:10 +0200 (CEST) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 06:15:05 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6534.namprd03.prod.outlook.com (2603:10b6:a03:38e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 10:15:03 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 10:15:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6854e9c6-d208-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680516910; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=kyjBEWr4eKfciZIpQc5jF5H6iyzmnfPSIHD1SdEfCtg=; b=ff8PnGMXVFvycCk2sGi8FlRgjeARZAHoMuvK68x0zNRMkDK9hqKO03xH xEv3mxyH+YG9/DQ2teUe97a0/lh+H7zyef73oPn2bM6TUyfwApDKARQS5 xYOhkRAoyYJrv1z1ER/Azvk0krN8KqTuhw03IbFVuP3hO84OZZ40xY+SI c=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 104127755 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:e7v/ZaJpa6pe36ieFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENS0DVSy TEaWTzVPviJYzT9fYh1a4Wz9U1V6MDSmNNmTgtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4sXktX/ 6FfCwwofzndo8fp3ZiDFeZV05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLk2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv02raVwnymBer+EpWkp9pvpw2W61UrM0UIdwKbudWy2nyHDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsTDRMddgnv88eXiEx2 xmCmNaBLSNrmK2YTzSa7Lj8kN+pES0cLGtHbylbSwIAuoHnuNtq1k2JSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNTNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:lJsV9qDt6wCk8mHlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="104127755" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLNLFtP/mLsiN0Spq6kEemtwDqhnWaMyyjNvSsWBS4Amj7Ya+uUaODmSW/4XJTlnbUHlUXlXLmIUsNilA9Ta/TVtcONn6r55cFfG71fsz0ldzUvdKM5RPsQqKlBoNuEJ9v0TLLBvWNXwmotrh2wfoCOyzMvMdeHKMiRhQkTRKHch/3BTMVzUDahK4EFjNbihBNpVlMZAktk/VxOvlaZtFsOWMePFgGBbi65/SXnBXaxtxRw2LCKa0u7PJNA1eb4O7EpZnMiraWxdQljdApjCZ/oD9sXLAJFcc/VorFDNedcKulredIY53/XfwQiTDHHrPHLxioOPEZZ5afp9Swl2oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BkDRg+VPEDuLPHDY4NyiLNhDqmUdPszHPJ+4Hgl9ygo=; b=DhcRLAqhhOZQNew+oeJUXeRyqtacTvgq3kWDfnT/9sQ0NrW8wA2OZSmGWr2dR3+ElffqNc454lBP33JjEHMuPtynjbhB1CNpmCOh1L1VMqrd+VRgt+CdlL3bPtnxH82lxuTjCiPsMnbAdO0OHp3Ygp5qJpYfvPBbt9XZQpxwTlfuSEsIq8hN5xD5VQaz/o1wQbKi49IzM0G/IbKHaFPpCL3b7LC1hwg4cBp26nwDRnxKoG5EQX1c325sTg5/gEygaBOCZaN7cP9K5qXBKxcG8I8RuoFF+awZdcvba3VmH7ncx+ktYnGbYJVmW/5N8KbO4w5temK7DUwqxW7e8ENaJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkDRg+VPEDuLPHDY4NyiLNhDqmUdPszHPJ+4Hgl9ygo=; b=XtReE/+iXbtnyK8pcscBzJ833wREmKbrrHf3Txuz/s4zOSJ4ho2HVknJNZ12GR6C1gFTDxWkT7FJkPIRMeau31eKYCZdLTMb+C5CfU4x9BDnuyHVMI34v8VUrFHDlL7pr2AFCLC09cg8ChgpI6dIzkYGC1lcdq2stqzXBS9Z4xk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , George Dunlap , Wei Liu Subject: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Date: Mon, 3 Apr 2023 12:14:49 +0200 Message-Id: <20230403101449.93323-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN1PR13CA0024.namprd13.prod.outlook.com (2603:10b6:408:e2::29) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6534:EE_ X-MS-Office365-Filtering-Correlation-Id: 37b3c7fd-2b73-4bd3-d6a2-08db342c49d5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r4a2/2p7PxspTwtFRTS1DSY18LBpP3penWC+ZlwH+an/NIlxG1kxBVTeFBUd60muuzrCXNFkDsrS6kvw6a8GYmG0YyV5wiBSglkrD1Cc4jxrGkQ26kzMCUovCMhFvkmgCohzxuPzlj7V0HcY4xCBnatHD9/80jEw9aqDGS2UBGA2VxOZVhpzM4ai3RvGrTgFIB8yUwoTU7n+C96zjCupIq7ruMVOMirv6qiDbPgMBcZ/X7zoJ5rysTRbrg05GITkFTPu3a3sv+ZfrQeOYdN1Adld7F3AAEahfjGSdIfAV1uxpnoCEC0uKddwoJdCXgYwLtJCEiN6LcCbTYu1VGwBw6qaeWhtaax7fWIn7SKRXFhaiZbWxf2TVzWtKJhcdSl8MsYSyj/JmZSNKqK/Elyk8mKnuVl2SvCY3vftIpJMkfgTSJmKFRloOP01y+u8ks2gdEckMeDuj39SJvmk5xYqJCqP0pE77dFzfUIhrRv54wUsNW6h8sKfBee0J8n9MDNqF/K8swQrlHrumbET9X5tD+Q7xxb3/7Ugby9f0llkeU8LkZ/AdakjGcSvTMWKFjWL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199021)(2906002)(83380400001)(6666004)(478600001)(8936002)(41300700001)(8676002)(5660300002)(54906003)(6486002)(66476007)(66946007)(66556008)(4326008)(316002)(36756003)(6916009)(38100700002)(186003)(82960400001)(26005)(6512007)(1076003)(2616005)(6506007)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTd0MjkxK296bzI2Q2ZSYmlsR2x5bSswdnhiZDFCYlRhSzNLOHhRQytVNnFs?= =?utf-8?B?bC9pVkFUeTMxR1hDNGRpcFhWRVNnZXV6NEpWYjlVRndYeXZDTEJZT0JnS1VO?= =?utf-8?B?anlrSmlFd0dLS3paT0k1eWFTbkpYSWo4bzk2WEsya1NaWHV2bGpkVzNLdjQ4?= =?utf-8?B?czV5Y284SDBDeVZxMmFkTTlBdGRXbjQ0NFZBUzE3QnZ4UmtjQWdDNElic0gz?= =?utf-8?B?c3NVaWpQeEdBWlpxRS9FZ09FVGpjQ0o5R2EzaFZ5Umlrdk5xN001VXU1dWl5?= =?utf-8?B?ZVd2MnJKYTR2MC9iU21BMEkzQUtGWW1nK0JsdnpwTnVhei93N0Q1VkVZVFZ2?= =?utf-8?B?aGEyNnVJYnBxNHRtWEN6S050a1FVd05idzIzVGZ2QzhBRk9GYzlOb0hSNGhn?= =?utf-8?B?SEM2L0dHOWFLblVXSVFILytnSU5aNkF3bUZWQkJjSkpUb2c5aVRhOVRUemFn?= =?utf-8?B?dG1waExqaXlyTUwzaGY4VU10bTV6UTlBcjdpTHlpZ1RUNWdhVzJYZTJCNjdy?= =?utf-8?B?VWZ3bUU1SEswTG8xaFoxVnZCaGVnYU0wSlZmcURiOUJZMFpueDZGZlZncUVk?= =?utf-8?B?L3ZRekoxUUVhYlJCaWRsblh4Ykk1Ym1ZMVlVbk1UdCtEdTdLVHVpeFBsWUs5?= =?utf-8?B?eGhHL3cyY1FMdUlRQ2NCVk9nd0Z1NTNOVkdVMzlVSXhJRFVhV1MzRzhrM283?= =?utf-8?B?MVM2cy9LWUhhSzFkdDBPSW1rc1F6N1JRTkVqbnNPRGhGUEh4d2NqZGJQeWRR?= =?utf-8?B?TGxDOEswNS9RbmdzZ0JQYUMzaHVkeWVBaTdwNUdIdWpYWjNPSUhndzk1Qklx?= =?utf-8?B?aFYyRDFMYmo4NGpSak15YWllY0JHeGY2RHowMW1Rd1ozRmdLcWEvUmE1NzEx?= =?utf-8?B?dk1hUlF0YTVnL1kxNVFOdzhwRVVpQWh1emJIb1ZpaVpMRlU5T2o3Smlvb3Nu?= =?utf-8?B?alNZWHVaRkd6Mm85dlFIUGVZTXhzb1ZqcXF6R2YybjVtRzY4SVlMQnhMYUcy?= =?utf-8?B?dlo4VVB2T3Y1NVhwMnh1QlRyRCtxcHRxaXNwVnBoVzRIc2NPc3lWdTJ2Q0NC?= =?utf-8?B?eHJuMjE2MC9BeWxVNkJRWXA4TzA0QmJvdFUxMXIvTEZTdXJyNEhsQTVIN0w0?= =?utf-8?B?QjVHUFYzKzhNSUo4ajl5OWtBaW00OVhFUW83YktGYmwwbXFSU21kbXU5L21i?= =?utf-8?B?ZDc1dEU3L3hIZnRrcXdZU0t5Z2RpMmdlWlJGM3Rqc0kzSEd5c0N4OGVqSEIr?= =?utf-8?B?NmF4ZUw1WnNueFY0SWN1TmhpQ25TRHg5NmhOR29vZTB3SHVBVmtBT0xKWmFH?= =?utf-8?B?ck5oZmRQY1dzRVpCYkZxQXdPd1U1RERHa2wvUlBYQ2xIZkVOallQVUtpQUI1?= =?utf-8?B?TGJFTmtDOGxaZ2hJQXJtdEw0d1pCUkxLUXl2aXpIVnppUGJTdW9zOER1RVVh?= =?utf-8?B?aXU3aVZteGtKRE9IN3ZjNUF4Nk11TCs2WlRCd2c0Q2dzV1dzVTkySTFqUTJM?= =?utf-8?B?M2lLdUp5TXVZbEVBbzJzUHZiQ2c5cnV1Unl6RFpmdzdOVzBHeklQVGU5VnI0?= =?utf-8?B?Zkk3ZWxkL3J5VjI0ZzZvQ0JrMkd0SStNUkh6eklRWFgweExQWHhaMXY4Qktj?= =?utf-8?B?SHliUStUaXg5L1g1bFNyb1Yyb3VJUk1XRVpJVUtWem5sQUQyNEw5V0lLTGtB?= =?utf-8?B?d2tIRDdJTXNLMWM0V1BialQrNDdjS2NZYk1MT1BTRWI5ZXR0aCsrUkdpUURi?= =?utf-8?B?V3M1TUQ0RXRnT0p1R3lMVjlVZUJGbFR4T2Q1dzZ1MmJibnp6Y3VpNzB1Y2ll?= =?utf-8?B?R1hOZXlNRTdPQzQyM3BmN1o0NDJWemZjQktDa0RIell5blRjclhjbDVyNGZL?= =?utf-8?B?SXRWRk9yNTVidE94NEF5d3Ayc05SbXIvT0ZEelVRemd2RlhKVkxCWXNlbThQ?= =?utf-8?B?YU9BZ1YycVQyUVJjalFqNnBiRnZXdnJ3U0tNZ1FTY1VxcHZIdjRRMi9CZzhY?= =?utf-8?B?NFhFa2FiZThSaE85TkdHR3hKa3o4dVkvUmRRNCs3WXpRdGM5ZHVoOS9hQlF2?= =?utf-8?B?K013c1J2VzM4SHZ1dUtoU25WbG1IWW9WSTNCbzdQRnRQTmJSaUVNc2lEekhI?= =?utf-8?Q?uObHq7/IVswXyzu6baCEMs4+8?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LGdZ4IvkOJ6kxNB8OzqEPVwbXPipV3L7pwdrU+zZiGChl+JPAtCeN131yJXv3OT9yvi8GloHBIi83EACwBrWcoRGfz61fhgloQLSIhKcMYV9ojY9B/hZNFs2JsZO3yZWC+48tjXRupUHvppQFDE/rSzm9sid141qJ/t8QmMC75EzOo+C8pd+ZQLnJxSOCPdUO7aHvmKeTMu9FxSn7Z/hcIOR9SGookMFpdZM2CVHTIiBt5tQ1ZlMmYgo0gfnFTkQ7T2prm//pyzpzMU7W+AxC28k0sxigEh2rLzXlEF4cc9Q/eJxy2tODixEgB4FO/DzdLLeujUt0EnJ6L0JPxJIYxGdIepgdnfUrlVuMrq72k1ySIjlkTHUsJPYDoliCxKK7D5rItlTK60/Ov/q15mDZcJdBZELaFTNlzX2cyBA9Yf+KUI8C5b9kZmcdyhWooEdXQgcs9Bs6RHdautoUTHewTUUdczmotHVYgJKlXHc9nO/+uDK+QQ+3GHguTmb3epU+6yEnmHhwm3gWecJkhC9SjM2wFD8YEdRbWjBXmihdjETb9knSUXFqbsgGO+dOm2/YJg5NY5yZH0Xky6SW5Rz/8AR59pZydYnau+ibJr/9678KnSPN8amexbbQWaCbpWD+Iy5YIJ5bOoGbwtfL/nm/i5YoMTvBG5lRDZDhNZdexwQVWfx3Uu6XU7jywETmpMWQqHPpLvW+TPS65A1aUrU2W/jEGCSGOQAiXkgkvsOciOSDf9ZcCRYWSAs1x0lWgf6Y0fTAwqLUIuI333FhN0LCjQKT3EVvpWtik62FXHAgM0qvcOmAVLGtJUNP+adB/Ow X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37b3c7fd-2b73-4bd3-d6a2-08db342c49d5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 10:15:02.8220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LPpA3ijAkE+/tmy/NVyPp9dME6OBy74Hkicfn53oIZfiFZ/8JHj8qnIC4TAfNg2JLQbKbjHNxzPy7bRfqg93Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6534 Global p2m type recalculations (as triggered by logdirty) can create so much contention on the p2m lock that simple guest operations like VCPUOP_set_singleshot_timer on guests with a high amount of vCPUs (32) will cease to work in a timely manner, up to the point that Linux kernel versions that sill use the VCPU_SSHOTTMR_future flag with the singleshot timer will cease to work: [ 82.779470] CE: xen increased min_delta_ns to 1000000 nsec [ 82.793075] CE: Reprogramming failure. Giving up [ 82.779470] CE: Reprogramming failure. Giving up [ 82.821864] CE: xen increased min_delta_ns to 506250 nsec [ 82.821864] CE: xen increased min_delta_ns to 759375 nsec [ 82.821864] CE: xen increased min_delta_ns to 1000000 nsec [ 82.821864] CE: Reprogramming failure. Giving up [ 82.856256] CE: Reprogramming failure. Giving up [ 84.566279] CE: Reprogramming failure. Giving up [ 84.649493] Freezing user space processes ... [ 130.604032] INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) [ 130.604032] Task dump for CPU 14: [ 130.604032] swapper/14 R running task 0 0 1 0x00000000 [ 130.604032] Call Trace: [ 130.604032] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 [ 130.604032] [] ? default_idle+0x1e/0xd0 [ 130.604032] [] ? arch_cpu_idle+0x20/0xc0 [ 130.604032] [] ? cpu_startup_entry+0x14a/0x1e0 [ 130.604032] [] ? start_secondary+0x1f7/0x270 [ 130.604032] [] ? start_cpu+0x5/0x14 [ 549.654536] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) [ 549.655463] Task dump for CPU 26: [ 549.655463] swapper/26 R running task 0 0 1 0x00000000 [ 549.655463] Call Trace: [ 549.655463] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 [ 549.655463] [] ? default_idle+0x1e/0xd0 [ 549.655463] [] ? arch_cpu_idle+0x20/0xc0 [ 549.655463] [] ? cpu_startup_entry+0x14a/0x1e0 [ 549.655463] [] ? start_secondary+0x1f7/0x270 [ 549.655463] [] ? start_cpu+0x5/0x14 [ 821.888478] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) [ 821.888596] Task dump for CPU 26: [ 821.888622] swapper/26 R running task 0 0 1 0x00000000 [ 821.888677] Call Trace: [ 821.888712] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 [ 821.888771] [] ? default_idle+0x1e/0xd0 [ 821.888818] [] ? arch_cpu_idle+0x20/0xc0 [ 821.888865] [] ? cpu_startup_entry+0x14a/0x1e0 [ 821.888917] [] ? start_secondary+0x1f7/0x270 [ 821.888966] [] ? start_cpu+0x5/0x14 This is obviously undesirable. One way to bodge the issue would be to ignore VCPU_SSHOTTMR_future, but that's a deliberate breakage of the hypercall ABI. Instead lower the contention in the lock by doing the recalculation with the lock in read mode. This is safe because only the flags/type are changed, there's no PTE mfn change in the AMD recalculation logic. The Intel (EPT) case is likely more complicated, as superpage splitting for diverging EMT values must be done with the p2m lock in taken in write mode. Signed-off-by: Roger Pau Monné --- I'm unsure whether such modification is fully safe: I think changing the flags/type should be fine: the PTE write is performed using safwrite_p2m_entry() which must be atomic (as the guest is still running and accessing the page tables). I'm slightly worried about all PTE readers not using atomic accesses to do so (ie: pointer returned by p2m_find_entry() should be read atomicallly), and code assuming that a gfn type cannot change while holding the p2m lock in read mode. Wanted to post early in case someone knows any showstoppers with this approach that make it a no-go, before I try to further evaluate users. --- xen/arch/x86/mm/p2m-pt.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index cd1af33b67..f145647f01 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -486,9 +486,6 @@ static int cf_check do_recalc(struct p2m_domain *p2m, unsigned long gfn) p2m_type_t ot, nt; unsigned long mask = ~0UL << (level * PAGETABLE_ORDER); - if ( !valid_recalc(l1, e) ) - P2M_DEBUG("bogus recalc leaf at d%d:%lx:%u\n", - p2m->domain->domain_id, gfn, level); ot = p2m_flags_to_type(l1e_get_flags(e)); nt = p2m_recalc_type_range(true, ot, p2m, gfn & mask, gfn | ~mask); if ( nt != ot ) @@ -538,9 +535,9 @@ int p2m_pt_handle_deferred_changes(uint64_t gpa) */ ASSERT(!altp2m_active(current->domain)); - p2m_lock(p2m); + p2m_read_lock(p2m); rc = do_recalc(p2m, PFN_DOWN(gpa)); - p2m_unlock(p2m); + p2m_read_unlock(p2m); return rc; } -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 10:17:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 10:17:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517364.802583 (Exim 4.92) (envelope-from ) id 1pjHFc-0008VT-Fm; Mon, 03 Apr 2023 10:17:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517364.802583; Mon, 03 Apr 2023 10:17:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHFc-0008VM-Bz; Mon, 03 Apr 2023 10:17:24 +0000 Received: by outflank-mailman (input) for mailman id 517364; Mon, 03 Apr 2023 10:17:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHFb-0008VE-87 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 10:17:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b724bc29-d208-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 12:17:21 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 06:17:01 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB6995.namprd03.prod.outlook.com (2603:10b6:510:12f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.28; Mon, 3 Apr 2023 10:16:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%5]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 10:16:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b724bc29-d208-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680517041; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=NJHBp8nY60BOtf1vDWBU2/LaHN57DMrJQ7Fa47wamQ4=; b=UtQwbGWnepMshyZ77M6JfhLfkudJsZjsEgsHMH7iR7/1eoGJU0d++Hxj Nf2+deF40423cFeO1Wu9Kp3iyIVWN2E0kChdxu3kYJE17NunaFObVGTxF U23wbuigrVrkhELg5Ny+JzviuT5BWw1PnyqTpkaPi4PYA9TmG9j/udB/Y 8=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 103470109 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cUGwyqif1xAN3cxzictcwVL4X161TBEKZh0ujC45NGQN5FlHY01je htvUWuHO6yCYTHyLt0iOY+yph8CvcTUydJkQAo6/i4yQSkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQXDzIHSxaA3Nuuwb2pYdQ22McJDs/0adZ3VnFIlVk1DN4AaLWaG+Dgw4Ad2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMpluG1YLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXjqqEy2QXCroAVIDA2aH+DrKiXsECzcMJ+B nAZpwg1v4FnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQI/ FKUm9LiBRR0raaYD3ma89+8sjeaKSUTa2gYakc5oRAt5tDipMQ5iE3JR9M6SKqt1IStSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodt7xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:rh5QuqFqAHsk1/C1pLqF9ZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6Km90dq7MBThHPlOkPQs1NaZLXPbUQ6TQL2KgrGSoAEIdxeOk9K1kJ 0QCJSWa+eAc2SS7/yb3ODQKb9Jrri6GeKT9J/jJh9WPH5XgspbnmNE42igYytLrUV9dPgE/M 323Ls6m9PsQwVeUiz9bUN1LdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y1zwoTSDRGxJYl6C zgnxbi7quunvmnwluEvlWjo6h+qZ/E8J9uFcaMgs8aJnHFjRupXp1oX/mvrS04u+am7XctiZ 3prw07N8p+xnvNdiWeoAfr2SPnzDEygkWShGOwsD/Gm4jUVTg6A81OicZwdQbY0VMpuJVZ3L hQ12yUmpJLBVeY9R6NreTgZlVPrA6ZsHAimekcgzh2VpYfUqZYqcg68FlOGJkNMSrm4MQMEf VoDuvb+PFKGGnqJEzxjy1K+piBT34zFhCJTgwrvdGU6SFfmDRDw04R1KUk7wA93aN4b6MBy/ XPM6xumr0LZNQRd7hBCOAIRtbyInDRQDrXWVjiYWjPJeUiATbgupT36LI66KWBY5oT1qY/n5 zHTRdxqXMyQUTzEseDtac7sywleF/NHwgF9/suoqSQ4tbHNf7W2Gy4OR4TevKb0rYi6paxYY f1BHpUa8WTWVcGV7w5mTEWYKMiWkX2YPdly+rTZGj+0v4jCreawNAzI8yjbYbFIHIDZl7VJE clcXzaGPhgh3rbL0MQxiKhFE/QRg== X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="103470109" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5Lur6ZyE0aACszxuCNOIXsT6RRjPrhVIVvHgKHoclm829RtHI3+Z08iFsyahZyOj94qB8coR7J2EpOinJ1lH5oQjU7fjhSCXSQFSxDc2ocJQ9oyYxe4dd2pfu4TNzIukXujds3StmkSRdesZLz+OgVi135RhxNVbTFmy7RD+oHrWw8mLXEzlYE0ZmRin/lGB18CZM0ZpMBzz/St4s7LHkGa/LwQuiziBYUNjdXnHkZLpJ+6T7VaRO/lFd3Wu+zqRWlE2tQomO67p3cNj1Zme+pezHp84ndoFnpJ8xr9F7tXS5aF3m66DgfkcwS5RuaMgyPnLfJBD/nxKA1ZVJJOPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybvD7N7hjF7U5elqg+fiOU6qIf03CIqjL/+AdVJOIWg=; b=FHmsqiINj7FQ0uXpccFF+uvDRGkotWDy7t/fdePZohheXwfB36Hd9EcLpKpnk5xY7Tg+Ayhw+pBlHwhyDr6YpG63NndpT4AKxBnmmCpn7GcVBnQPpKEVl1PaC3l7UpQIMm+8BGZgx8BSpWY/Q4WuZyaS26EMiqcOBCzqPXip3phO+ZabtbakotFkRMlLaCDuILA5givxfElzSsTdlkiglhnAVbU8u48UdV3p+oA9OM652Jqx6lUu7fSO8Z2jehVY9KK6AaqSfIbeYIJb0ozRtaTosuFvn2QxB7izQ0PF+MTSt1oldMhVXuzKLEP91egSBk819q9uftcvoYWSDpFQHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ybvD7N7hjF7U5elqg+fiOU6qIf03CIqjL/+AdVJOIWg=; b=PbQekA4iIB5zDkXUwEgJNxL7SXYXtPu3RoNSrMHuiaCZFfkZSP3otWvKZmsyx6WaNW4TI3AU5shbVG5VN1HygYEP/ZAU2aptahVC4/KYN3TYV4/oCoDFj2I8UmFofOzwasMB0DlzUBEWtzuGsFrj4twf42IBl0xLCmJsKZvLTSo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4b76def9-9940-ccf0-8050-12ddf2c1253c@citrix.com> Date: Mon, 3 Apr 2023 11:16:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Jan Beulich , Wei Liu References: <20230331175719.500285-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0046.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::34) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB6995:EE_ X-MS-Office365-Filtering-Correlation-Id: bb4db509-371d-41e7-d5c5-08db342c8eb9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GstqtAe623VcD3PaR5SL1OsCm35wA/8D/WdrH/9lAOdpOctcedUXTPUe31HVANhrkveJAQYZjIChO0hxxqAKNNst8fdkzTjiWyQNw+xDqesm3VAQOdbU2WwprdnAOMMU+hmTnF62n3iLbw5qOUxp1j6leRqoRW8RE43/NZFjqyTEn1DmoqGmk/IjjMyQR2Z3jbesgkK0ZseDj6IneLBDD3kgyUbo8P/IYVc0xavu7UUYlh4+u8oIvtoZKDIHWXbByra5T+L6j6ITPm/CMYQhxRNtp6BjahRHDyd6cNBycw8gMlou6ijEqWczu6Gjtq/UgY2alcHki504VMUwPiB9umwW69ec120QpLnR1S8oU/smP8hsmqYDx4ZRMLCBId28nbFcP99BW4XbKlmwSLxd7Pt4LuTbC8fTvz/nwkSzPuGgFD2VV2VdOs7bisUA9X3guFrbmNTY2wrc5xL9MpPaBQ69oLo9S99Yo0qGV0cR5R0dshbqN+5nulPC+uSwPM2Usx3IUxeuzy1X6hiKxdsV/elpy9j9cOobEoUO6tpCCTjmSCaxqk2i5sEW3Fu2pVKo/Ub89Cp+1a0IyONYcqrcA6DIa5LDcVUuvcGXH/3oTUTtO/cTyx3ZsyWMzY5T3SH6boWYbLAGyQvB3WoGBDlsxA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(39860400002)(376002)(396003)(346002)(451199021)(30864003)(2906002)(6512007)(6506007)(26005)(38100700002)(53546011)(31696002)(86362001)(83380400001)(36756003)(2616005)(82960400001)(186003)(6666004)(41300700001)(6862004)(6486002)(8936002)(8676002)(31686004)(6636002)(54906003)(4326008)(66556008)(66476007)(66946007)(478600001)(316002)(37006003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlpSUXlZbFJMRmJ0RWRQQ0g2OUZlUjd0U09mSlcrZHBHcldiYVNqdzZoQU9C?= =?utf-8?B?MVR6WXNaVjZMaE9nT2FjU051d09DT2gxRHhteEw2dHRqMEprdklEb1QreE90?= =?utf-8?B?ejZvY0Jub0pDWE52Q013OWZHSzBDRGFqaUFCSkNGUzQwQklYRFY5NWtKRkp2?= =?utf-8?B?RTg4MENDU0ZzbWJpd2trbFlWQ3B4MGZtVk5zOEEzb1dLU1dOZW56aFZRQUNN?= =?utf-8?B?SGliL1BvVitLZXFtQWpXNHdPWEcyUXV3RGlROTVnMjQ5Z1AvaEJlWFpkSTRV?= =?utf-8?B?NVRrS2Q3L3dWbFRNdFRiSm82VWJFeFdVS2tobXNsejBISldBWVc2VUEzSHNz?= =?utf-8?B?b3drREE0ZEM5aXdwU1lQeWZsQ1B6MzNMVFUrdlJqNG9wMzNQQTdMMkFadUYy?= =?utf-8?B?MUJuUjQxU2FQdm81Mlhnekx1dEdXaDEwaHE1SjljTEtZM2U0OHBJUEZIR0Qw?= =?utf-8?B?SVJZVkZXS0dQQnZBSjNYUWJTdzcrV084Z1ZFcWRtWFJDUS91bkIwMm5FS3li?= =?utf-8?B?VGI1MUJ6TksxVEhZZnpBT3ZLYmZxVFZWMVNZRWNRdjdnNVVwMmQzK1FiemdY?= =?utf-8?B?QTB6WjZBYVhacXdmd0FwbzZudTRvNmN1VXA3dlBNalp3ZzRsT2o2eFRsQ2JS?= =?utf-8?B?dVl3NWpML2J6Qng4TVN4MWsyM2NObWV4cjkzTTlUblRlZGpocFhBSHZUS3NI?= =?utf-8?B?UG52TmVQd0d5RndPVzFMU2JlbFVOSm51QVRzOWljc2dmR0lZWWhMZW1CTW5Q?= =?utf-8?B?M0RIUDZ1M2k0ZU53NjkrMUhIdTlqV3F3Sit6cmIxQUxiOUpsc0thN2g1TUNE?= =?utf-8?B?UUczSjRsejVCSEw2V3lDcFN3dytibUN2akU2V0U2RTBkZmFlVDhBVnBpQ3hG?= =?utf-8?B?cmZpb3FpV2pvbXdnaS9BcHhiY1dVVDFzQlExc0NLYytKVmZyekh3OVZjUFV2?= =?utf-8?B?ZEIvNGJOcWFiT2NqQmRoSjRNajAyU1llNUFHSy9pSjhzU3pjaWxCaHFiZGJu?= =?utf-8?B?QWk3SkU4R2MzUjZqdnp0WHlDcC9lOW1DV1I0MUVZYURJeGdKbHduZ05HSGVZ?= =?utf-8?B?a1hjd3JXWmJiUTNVcHRzUUJGWGJQSkswK2VEZERpUEJiOVVIaWdnaGdjbDlw?= =?utf-8?B?M3QyQ1lBamJSN2R3UDhqNWFXSU84R1RmS0JjMDYzcWVpYm5PTXhBWnQxaXRB?= =?utf-8?B?aEVqb29zWXdiaEJTak55L3VENFhDRzFhMWJLcWZJU0JHY3pCSWx5bDJvclVC?= =?utf-8?B?djBoQmNIeGpyOCtRNEliWndRQloxYklaSUdPaEVqNFRwMDEwVGE4MXp5Yzlt?= =?utf-8?B?RU91QzlVOVNvQm5xcFhEaUpBOGJzSHJyUk11dkFDa2RkQ3RjS1diZjRlSGp4?= =?utf-8?B?QlJ1d1hxTFc0NzZpTi82WTJobDdhWjl1RTlPM09rWVZiQmF0STJUQWpnSkZR?= =?utf-8?B?bEdGckRLS0Y5Y3NFQTQrVHdCeG1YZHA2VG9BbWxObjUwL0N1VE1VS3RYTkVw?= =?utf-8?B?SlpDNE8xYjY3UVhxSnFvYTZmMUJZQTA0cnE2QWlsekxyVjRNazVSTVpESTdn?= =?utf-8?B?TkliSEx6YzBkZnZ6a0o0WTR6NHgyenJPZzJlSkhkck9xUHNHOWRmcUI2SVJF?= =?utf-8?B?OGNxSUM3QXVDbU1NTGVDYTViL2FZSzdFM3FERDhhSkpyQzRka09oZkxkVkRk?= =?utf-8?B?MURNTVJ0MG5LNVFGM1ZBK2R3c2twRkt6REVOSHBsbGRZc3pyanJ0eEcweWJa?= =?utf-8?B?K1MrcmNhVlpGQW9RSHkzMVRBcUpWcWZyY3dNZjNaNkFjV0RkUVYzVUt1ZWxM?= =?utf-8?B?Ui9qMWlBb085VEhFZFAvNXFtWmJqNnE1RmRWckd0TzZ1SFdoT0podTRsSTRl?= =?utf-8?B?Nk5TcXV3bFdRaDNDaWh3T1lqK2V0VTRmd29DMkFyTytCTm5pR1ROdGRpZjdT?= =?utf-8?B?UWNUZ2hQWkNiSEh3ZHlEZmZEdlZzcW5YaGM2VnRkdDJYcU1LZG9MblFoaEMv?= =?utf-8?B?S215MUF0bU1lR3pkV1Z5QmlXeU9VbklEcWJ3M09HZHJuUVpoNnQvN3h3elZx?= =?utf-8?B?VXh5V0tzS3IrM3F0K2xSQ21LcWZRVTRNRmtzSm5JWFhWaWpXb216cjNPcjhG?= =?utf-8?B?NVYvTy9QVDVaZTJLOHZWK2tSRDc5NjFrTDJ0V1hNa29KV0hhdzYra2JRQ0FU?= =?utf-8?B?VWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6xQ7WrnMkvZOy0HC6j5Ux70YVQIxeMJbsq5NhhW83077hZINysldrrU6ShmesiyzVhuCGVfa5PXwVZNLaGA3ZAyXFR6oI5y8sa4knGyw+rwBi9945Xk+W7/Wselats0HyidgQGUGdL4gOrSRv10f+ZXkTW3nsg4fTuXcbyoS+QsYMYM7OPC5kVXkhMrTOt7Tg/5KoxlNF+N6O1z+Tz8BotPkIKJmlzgM1xObRRM4SiGfl6Xe4SmTJYg6bd0yG/25QziJcEJ8uM7Ip7Rgd2fSQNHTRVJU/JXunAVjSsvbh+yA22+f4gtM8iJrdYQqjJJndvr+1onzNNAdYItyBQM1Zav/UZQwXWt9swcNA2ratA0b6G5P22HWpWaqa6dTOToUWG7WUIR7c0BMQ4+l1z95FyV1KM+dtmfB7YzBGcIM8upE+japTBGic/KeM8G70ctzQ4p+R9zT32l/0LHTmtjgLw66mT2NAAbsFUfi4cNQcUcD5pG1X/+bYXHFUYJOW1ZnOtXZMdkGAzPl+YZJCcqIrwa9gPHZFdsWPTP1YB+MWVImmANSAUgB+XKJvRc7CtOQNS7RKmzZ4gWUPq8rbGRixR4l/fNOQfmSqbkSBYVoUFgNk+QWWNbGKHnKCev42BuKTFoEe3kmnUF0sNwsDwvQyVvaKTRZvRRzNBOkwWxXaVaJgIJHfTuXjItX+/falFDIkwxVetkPSZv9zTZ3s4os+AS1keIc+XbTxXXdu/Xo45DLh6Ci4M6V1u8SB4mpP0hCQ8uWGq00b6qGK67Q9amxl11plvC2bekRD1tVbsMc5VfGkgH4fEdQEgMpHCJ+Ljou X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb4db509-371d-41e7-d5c5-08db342c8eb9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 10:16:58.3744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RTeM3/YP8WHkeszVLhnoJvM2RvVl+J4FsxU6TaD+Yjxt2mk4zKKJ2irrGFKNYZlATTveczY0ExWP2HzyTUjBF3NfZX8sFZNdvrCRvtaZJzc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6995 On 03/04/2023 9:57 am, Roger Pau Monné wrote: > On Fri, Mar 31, 2023 at 06:57:19PM +0100, Andrew Cooper wrote: >> This started by noticing the dubious Fam17h check in >> arch_ioreq_server_get_type_addr(), and then realising that checking the host >> CF8_EXT setting is utterly bogus for the guest <-> qemu emulation path. >> >> What should be consulted here is the guest's MSR_AMD64_NB_CFG setting, but a) >> there isn't one, and b) the vestigial remnants of the cross-vendor migration >> logic cause MSR_AMD64_NB_CFG to be unconditionally read-as-zero, making the >> CF8_EXT path unused by any suitably-written OS in the first place. >> >> MSR_AMD64_NB_CFG really has been removed on Fam17h (it's now just a read-zero, >> write-discard stub), and the ECS extension is unconditionally active, meaning >> it is not correct for Xen to ignore the ExtRegNo field on newer AMD CPUs. >> >> It turns out that Xen did even have this behaviour in 4.5 and earlier, with >> this problematic CF8_EXT checking being added in 4.6. Therefore, revert back >> to Xen's older behaviour - it is objectively less wrong than the current >> logic. >> >> While fixing this, get rid of hvm_pci_decode_addr() - it is more complicated >> to follow (and to call) than using the CF8* macros in the calling context. >> Rename CF8_ADDR() to CF8_REG() to better describe what it does, and write a >> comment explaining all about CF8/CFC accesses. >> >> There's one rare case when CF8_EXT is visible to guests, and that is for a >> pinned hwdom. Right now, we permit such a dom0 to modify the CF8_EXT bit, but >> this seems like a very unwise idea. Leave a TODO for people to consider. > One weirdness I've noticed is that for vPCI we decode the accesses > taking the extended CF8 bit after this change, but then if the access > is relayed to the hardware using vpci_{read,write}_hw it will be > forwarded to the hardware using pci_conf_{read,write} which > doesn't have support for CF8_EXT. So if the underlying hardware > doesn't have MMCFG support and the reg is > 255 it will be dropped. It is important to stress that this change does not influence whether the guest issues ECS accesses or not.  All it does is change Xen's handling of such accesses. Previously vPCI blindly ignored ECS accesses, so the vPCI layer effectively truncated them to BCS accesses. Now, from your analysis, when MMCFG isn't active, Xen's PCI layer will effectively terminate ECS accesses with default behaviour, even on systems where IO ECS is available. So we've changed one valid behaviour for a different valid behaviour. (Quick tangent...  Our PCI handling is currently very dumb.  pci_mmcfg_read() returns its value by pointer but the callers never check.  Swapping it to return by value would improve code gen quite a lot.  Also, when MMCFG is active we still pass BCS accesses to IO ports.) So I think we do want to improve Xen's general behaviour too, but this difference here doesn't concern me. > >> Fixes: e0fbf3bf9871 ("x86/AMD: correct certain Fam17 checks") >> Fixes: 2d67a7a4d37a ("x86: synchronize PCI config space access decoding") >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> >> Whoever reviewed those two patches originally was clearly a fool... >> --- >> xen/arch/x86/hvm/io.c | 24 ++++++------------------ >> xen/arch/x86/hvm/ioreq.c | 19 ++----------------- >> xen/arch/x86/include/asm/hvm/io.h | 4 ---- >> xen/arch/x86/include/asm/pci.h | 26 ++++++++++++++++++++++++-- >> xen/arch/x86/pv/emul-priv-op.c | 19 ++++++------------- >> 5 files changed, 38 insertions(+), 54 deletions(-) >> >> diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c >> index 5ae209d3b6b3..b0d3c236e985 100644 >> --- a/xen/arch/x86/hvm/io.c >> +++ b/xen/arch/x86/hvm/io.c >> @@ -248,20 +248,6 @@ void register_g2m_portio_handler(struct domain *d) >> handler->ops = &g2m_portio_ops; >> } >> >> -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, >> - pci_sbdf_t *sbdf) >> -{ >> - ASSERT(CF8_ENABLED(cf8)); >> - >> - sbdf->bdf = CF8_BDF(cf8); >> - sbdf->seg = 0; >> - /* >> - * NB: the lower 2 bits of the register address are fetched from the >> - * offset into the 0xcfc register when reading/writing to it. >> - */ >> - return CF8_ADDR_LO(cf8) | (addr & 3); >> -} >> - >> /* vPCI config space IO ports handlers (0xcf8/0xcfc). */ >> static bool cf_check vpci_portio_accept( >> const struct hvm_io_handler *handler, const ioreq_t *p) >> @@ -275,7 +261,7 @@ static int cf_check vpci_portio_read( >> { >> const struct domain *d = current->domain; >> unsigned int reg; >> - pci_sbdf_t sbdf; >> + pci_sbdf_t sbdf = {}; >> uint32_t cf8; >> >> *data = ~(uint64_t)0; >> @@ -292,7 +278,8 @@ static int cf_check vpci_portio_read( >> if ( !CF8_ENABLED(cf8) ) >> return X86EMUL_UNHANDLEABLE; >> >> - reg = hvm_pci_decode_addr(cf8, addr, &sbdf); >> + sbdf.bdf = CF8_BDF(cf8); >> + reg = CF8_REG(cf8) | (addr & 3); >> >> if ( !vpci_access_allowed(reg, size) ) >> return X86EMUL_OKAY; >> @@ -308,7 +295,7 @@ static int cf_check vpci_portio_write( >> { >> struct domain *d = current->domain; >> unsigned int reg; >> - pci_sbdf_t sbdf; >> + pci_sbdf_t sbdf = {}; >> uint32_t cf8; >> >> if ( addr == 0xcf8 ) >> @@ -323,7 +310,8 @@ static int cf_check vpci_portio_write( >> if ( !CF8_ENABLED(cf8) ) >> return X86EMUL_UNHANDLEABLE; >> >> - reg = hvm_pci_decode_addr(cf8, addr, &sbdf); >> + sbdf.bdf = CF8_BDF(cf8); >> + reg = CF8_REG(cf8) | (addr & 3); >> >> if ( !vpci_access_allowed(reg, size) ) >> return X86EMUL_OKAY; >> diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c >> index 0bdcca1e1a5f..325a9d118e52 100644 >> --- a/xen/arch/x86/hvm/ioreq.c >> +++ b/xen/arch/x86/hvm/ioreq.c >> @@ -285,27 +285,12 @@ bool arch_ioreq_server_get_type_addr(const struct domain *d, >> (p->addr & ~3) == 0xcfc && >> CF8_ENABLED(cf8) ) >> { >> - unsigned int x86_fam, reg; >> - pci_sbdf_t sbdf; >> - >> - reg = hvm_pci_decode_addr(cf8, p->addr, &sbdf); >> + pci_sbdf_t sbdf = { .bdf = CF8_BDF(cf8) }; >> + unsigned int reg = CF8_REG(cf8) | (p->addr & 3); >> >> /* PCI config data cycle */ >> *type = XEN_DMOP_IO_RANGE_PCI; >> *addr = ((uint64_t)sbdf.sbdf << 32) | reg; >> - /* AMD extended configuration space access? */ >> - if ( CF8_ADDR_HI(cf8) && >> - d->arch.cpuid->x86_vendor == X86_VENDOR_AMD && >> - (x86_fam = get_cpu_family( >> - d->arch.cpuid->basic.raw_fms, NULL, NULL)) >= 0x10 && >> - x86_fam < 0x17 ) >> - { >> - uint64_t msr_val; >> - >> - if ( !rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) && >> - (msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT)) ) >> - *addr |= CF8_ADDR_HI(cf8); >> - } >> } >> else >> { >> diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h >> index 54e0161b492c..3f3fb6403ccb 100644 >> --- a/xen/arch/x86/include/asm/hvm/io.h >> +++ b/xen/arch/x86/include/asm/hvm/io.h >> @@ -144,10 +144,6 @@ void stdvga_deinit(struct domain *d); >> >> extern void hvm_dpci_msi_eoi(struct domain *d, int vector); >> >> -/* Decode a PCI port IO access into a bus/slot/func/reg. */ >> -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, >> - pci_sbdf_t *sbdf); >> - >> /* >> * HVM port IO handler that performs forwarding of guest IO ports into machine >> * IO ports. >> diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h >> index f4a58c8acf13..3b814f4ebacf 100644 >> --- a/xen/arch/x86/include/asm/pci.h >> +++ b/xen/arch/x86/include/asm/pci.h >> @@ -3,10 +3,32 @@ >> >> #include >> >> +/* >> + * PCI config space accesses with CF8/CFC: >> + * >> + * 1) Write {Enable | BDF | Reg} to CF8 to set an address >> + * 2) Read or write CF{C..F} to access the register >> + * >> + * For sub-dword register accesses, the bottom two register address bits come >> + * from the CF{C..F} address, not from CF8. >> + * >> + * AMD have extention to this protocol to access PCIe Extend Config Space by >> + * storing the 4 extra register address bits in the penultimate nibble of CF8. >> + * This extention: >> + * - Is unconditionally active on Fam17h and later >> + * - Has model specific enablement on Fam10h thru Fam16h >> + * - Has reserved behaviour in all other cases, including other vendors >> + * >> + * For simplicity and because we are permitted to, given "reserved", Xen >> + * always treats ECS as active when emulating guest PCI config space accesses. >> + */ >> #define CF8_BDF(cf8) ( ((cf8) & 0x00ffff00) >> 8) >> -#define CF8_ADDR_LO(cf8) ( (cf8) & 0x000000fc) >> -#define CF8_ADDR_HI(cf8) ( ((cf8) & 0x0f000000) >> 16) >> #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000)) >> +#define CF8_REG(cf8) \ >> + ({ \ >> + unsigned int _c = cf8; \ >> + ((_c & 0x0f000000) >> 16) | (_c & 0xfc); \ >> + }) > What happens on Intel when the bit is set, is it just ignored? "the bit" => the ECS nibble, or the CF8_EXT bit? The ECS nibble is ignored on Intel AFAICT, while the CF8_EXT bit is in a very AMD-only MSR, so won't exist on Intel. > We only allow such accesses for dom0 anyway. And guests running on AMD hardware where CF8_EXT is active on the northbridge of the core we are instantaneously scheduled on. >> >> #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \ >> || id == 0x01268086 || id == 0x01028086 \ >> diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c >> index 5da00e24e4ff..008367195c78 100644 >> --- a/xen/arch/x86/pv/emul-priv-op.c >> +++ b/xen/arch/x86/pv/emul-priv-op.c >> @@ -245,19 +245,7 @@ static bool pci_cfg_ok(struct domain *currd, unsigned int start, >> if ( ro_map && test_bit(machine_bdf, ro_map) ) >> return false; >> } >> - start |= CF8_ADDR_LO(currd->arch.pci_cf8); >> - /* AMD extended configuration space access? */ >> - if ( CF8_ADDR_HI(currd->arch.pci_cf8) && >> - boot_cpu_data.x86_vendor == X86_VENDOR_AMD && >> - boot_cpu_data.x86 >= 0x10 && boot_cpu_data.x86 < 0x17 ) >> - { >> - uint64_t msr_val; >> - >> - if ( rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) ) >> - return false; >> - if ( msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT) ) >> - start |= CF8_ADDR_HI(currd->arch.pci_cf8); >> - } >> + start |= CF8_REG(currd->arch.pci_cf8); >> >> return !write ? >> xsm_pci_config_permission(XSM_HOOK, currd, machine_bdf, >> @@ -1104,6 +1092,11 @@ static int cf_check write_msr( >> if ( !is_hwdom_pinned_vcpu(curr) ) >> return X86EMUL_OKAY; >> if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || >> + /* >> + * TODO: this is broken. What happens when dom0 is pinned but >> + * can't see the full system? CF8_EXT probably ought to be a >> + * Xen-owned setting, and made symmetric across the system. >> + */ > I would assume CF8_EXT would be symmetric across the system, specially > given that it seems to be phased out and only used in older AMD > families that where all symmetric? The CF8_EXT bit has been phased out.  The IO ECS functionality still exists. But yes, the more I think about letting dom0 play with this, the more I think it is a fundamentally broken idea...  I bet it was from the very early AMD Fam10h days where dom0 knew how to turn it on, and Xen was trying to pretend it didn't have to touch any PCI devices. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Apr 03 10:56:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 10:56:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517373.802593 (Exim 4.92) (envelope-from ) id 1pjHrG-0004WI-I9; Mon, 03 Apr 2023 10:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517373.802593; Mon, 03 Apr 2023 10:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHrG-0004WB-EH; Mon, 03 Apr 2023 10:56:18 +0000 Received: by outflank-mailman (input) for mailman id 517373; Mon, 03 Apr 2023 10:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHrE-0004W4-FJ for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 10:56:16 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 244edc6e-d20e-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 12:56:11 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 06:56:08 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5189.namprd03.prod.outlook.com (2603:10b6:610:a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 10:56:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%5]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 10:56:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 244edc6e-d20e-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680519371; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=5JZGi8/1/yb6/qdgogTjC3obpQIKi7kNJk4CnzYviYY=; b=Rw6v1ajTSibklxpKTuSyWOQ/56pMUVf1nASbYcmRXnVQ2ypzgvJHUxBK MUBfFgK8fRjMAkXM0Whii14YYBkjrNGCzniDOzQ73XQlupIEsm4wCXwkp AvAwr3axKTBWwmk8BKm1EpE9MK+Zn2Fwzw4qD7uLmvA8Z7yBxPrUZjCgR w=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 103474203 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sy9aWKtGLD34cGRB3kIilS1r4OfnVHtfMUV32f8akzHdYApBsoF/q tZmKTzUOKzcamWkL490advk8R5Tv5PSyIJgTgZlpCs0RX8b+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGzCFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcj0nZzuIqvuP8L/mS7kwuYMDLsfCI9ZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgraI13AfLnQT/DjVPD2GnvPK9kHXvZPNRD XMk4Ckkv5cboRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 HWEgtfoDjxHq6CORDSW8bL8hSy2ETgYKykFfyBscOcey9zqoYV2hBSfSN9mSfexloesR2G2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:bgSiy6yApGpvZvMI2d8+KrPw+r1zdoMgy1knxilNoH1uA7Olfq WV98jzuiWUtN9vYgBHpTntAsW9qDDnhOdICPAqTMqftVDdyReVxeJZnPXfKl/bexEWrdQtrZ uIGpIWYLfN5D5B4voSizPULz9P+re6GN3Bv5ak8564d3AJV0kdhz0JbTpzancGJzWv9fECZe ChDz181l6dkN0sH6GGOkU= X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="103474203" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ofzh/HacUYVN6GmR/MBDtmIrO9ju3Y/Oo+PBlrBXc+jFxq8cjxSj4pn93q6MXIb01xPo+nYhT0eLVwE40oyZUdT8hp3EJCo6w7TjVdyq2MhC8WZHIJbrA4UhDQt4Qiw6jRmMJy4i4rhmqNXAhvVR9s+zoXRjg4mPF4EGwYwtJrNm0IpEnWcWhmC7osYXPN0Y9vLiuIcJqDQYNe4JfmgXqaOIbbJSH/1azSkN5jx4uf+VLaYdxiCPkE2vF87fHo2zyAIXdc1oiUR2J86UIWuoQEkEHPALXhpRUurbSJu6jZyDWIg0D/sR5dbYT5FIEqbT+6JmyhOMLwoLIqBTJ7cgTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+TRfRo/vwqJdd2nOP6GwL6ag6RGk2ZLD1LhaZ3gY2CE=; b=BNM8qhWvgePd+lyTkhUFo4sV0i3QRTXtIzIqwp6Yp45sEh7orI9+O2SX81L5UsEWqLLhqaQ0FLfPh0Ma8i/QN1MflKPsZvZOgh73vzKrT81PNU1TxVkIc3DVPOwT+D37hgxgyuUAlzKdqAgQCFhRsct7AF3QluMeNM1Mnhy7TiCW0E7bhrTIxiC7LezbFrvkbQ0cplm0xszuvtkApZXVhIGV+A+OYnXi61WWNx+FY0sbg5ApyPkYdijJLPniH8/g7TqOQJb15dK8Ds2/7TklXOsF0/6vhGRbntnT4fzdavksxvGk7C3UlS+62T0pV2y24cDgk+MOYPLolNlERizc/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+TRfRo/vwqJdd2nOP6GwL6ag6RGk2ZLD1LhaZ3gY2CE=; b=Tq/7eomAFhkjPnepLuC6STCn4toyzFzY/neLfMxiIXKp44XhGASpAFknGAGGUAIFtyokmvLCG6SGSccKKlOQhUlOMh/jEbxUsoj0Cop057/D8Ym4fj7ZVIMAGD4Jn51m8elo3m20x2M3Tyt2C8G9lzwrWMFzuBoxSNKSInCWUYY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <14d8128d-6f50-99e5-ec98-366318e7be1b@citrix.com> Date: Mon, 3 Apr 2023 11:55:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH RFC 0/9] x86: Merge cpuid and msr policy Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Jan Beulich , Wei Liu References: <20230329205137.323253-1-andrew.cooper3@citrix.com> <9108a58f-da8f-14e4-de88-a7c8c8abb0f7@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH2PR03MB5189:EE_ X-MS-Office365-Filtering-Correlation-Id: a83456b1-91d3-4a5e-d8ae-08db3432049a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WKET558DhG3LAHR3wU7lGBV+1SAVaLYHao7LDDHgU0IaG7Kny7h3thRyhQsgopErFW5++UfDHuzZltFmLKdX+nyuAEOBuFTdv+wtHhBXcAmCN2rdyrBrj6eYf0LCo48YxjZFimIIcaHJA9c30f5o2ZzRU04NohvNSjBrExjXhC5+MdYJGsUYPjcF5LMTQ2bU4TMpNJX5Th2p4mtFtLHP1PFfZLzKqGsm9e4URVC4QwtrVcmKiXBFWjaSQFPbIq9LIC4Baz3PtEYNHn8gkqaVcpIvhHA8I6P/0zqkFr7I4qshP1/SpFaI5tXlpsjsiF4ENJYr8A5wJzU/38mlHGHRwX4iZrA+Aw8CBvrU9KjK2Vjjh9Ru4TAtgBe5AHfSi3b4TRSgBXWRek6DFIcNL7F2hFtLuRGOZ7ZRl6DK/T5mWzCfVqsGZzfrlg62CbL7cNZ4Q+plB6pxip3qGBQmoJZVUQerG2hEPQPHKh9Zz3/7VjHxy4RWCii0pSGmtQOKOmkbJaIj+sf42qLYLJ2dqPcitpSfqHaWwy9x7CmdPY5AOooi1x3MxiGPkru1ZCZHM5k7jgHsjpn6DStpfxhbzVGL6k/Z5Q4eORwXm2gD9oQzTwqAqbYe22ozIT2YVGJAhiXG5U8erzNf3GOOUgXz6mGQ7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199021)(31696002)(86362001)(36756003)(2906002)(31686004)(2616005)(6486002)(966005)(53546011)(186003)(6512007)(6506007)(26005)(6666004)(4326008)(478600001)(8676002)(66946007)(66476007)(66556008)(41300700001)(82960400001)(5660300002)(38100700002)(6862004)(37006003)(316002)(54906003)(6636002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWhlTnQwa0d5NFpBOWNud1pQQjBmQ2lhUEdLSE5vaW0wQ3JqL2s1MkJmZ3VX?= =?utf-8?B?RHc3RDFHLzdXMldadGdHWE1EU3ZWZVpJTVVEdXdsZ0doQWM5SVNmTkpGTm9l?= =?utf-8?B?eWdIK0l2RSt3Vzkxemo4Slphd3dqUWdSWHZnSit3SXc1V1UwYnVXejZXYnZx?= =?utf-8?B?dFZIbmlDN0U2dGErd0pKUXg1c1V4TUlXZVE0QU1Da2tuZnBHM1pSRjhraXd5?= =?utf-8?B?dW5xTk53NmErZ25WVzF6VmVTLzlUYnNBVkc3QnREUTcycG1uc0hSYVJyRmNw?= =?utf-8?B?Z2RvMGFpc2xLbms5WnZPd1VGQU83UUdPZzBnTVYvOW5qVXlBL1MxemNNTWM3?= =?utf-8?B?RUV3Rk84WjkvN0pvWGllWWJFMVdFVFRwYTZmNVN1R0hJdElGZzlPYjM1dVpn?= =?utf-8?B?RzBKenhnTVFKTDVSMExMb0hIc1k5OUUrZXBGbFROeHBKYWpIeTVTYzNxSTAv?= =?utf-8?B?S3dBNDlDRUhBSXJobmxBVHgvVHVGMkFTY3c2SVF2VzRRc2N2REdZRzJCNVV6?= =?utf-8?B?K2tIZ2ZlK3ZKcHBvb0l3RUxOVVRJcGRTNk5GcFl5R2FwM2QzVmcxTUtYa2Fi?= =?utf-8?B?Vmh5SGFKUWw0b2pBQ01CeW9xVTU1QkVXSk9CR2xWM0Y5QndZQXRHeFErZW1y?= =?utf-8?B?aG9yWWh3WkRFUlFFYVlEblJ6YVgvTXh4azkrak16NnNQcEEydnlmUXA1Z2xL?= =?utf-8?B?MU4yaE40ZkJBdzFUNFY0UU9ZWXFtMUpDSFJWZ1dHOFp2L1Qrb1JDV3FuMVhT?= =?utf-8?B?SmpMWjVsQzRidXdtdzkxaGVpR05BbFlMMzlBMHZSVjh1bzJJSSt6L1Zhamsz?= =?utf-8?B?S256Y2dkd2dzZlp5WCs3eGsyZ3pQMWhZNGJVTnBROGk1eVVkZWUvLzNodWxU?= =?utf-8?B?SGk1Y0lKK3htRC9Bc2NYY1pIeXEvQnF0eVpjck40UWcyYlo5V0VKT0NXb2Y1?= =?utf-8?B?QnFiR1ZEcjBzZU81bGJWL0FBVFJkRXhrSFE0OTkxRVZ3QkFIbGZwbnpDSTQ2?= =?utf-8?B?bnZ1d1I4VTZzcndhNWJCVmxUWFlKK01RVlFkVU51dHgzRnZJbkpNM3hYUGtj?= =?utf-8?B?VkpvVUVTbENhUFB3dFhCMEcrK1pLRkFXRXRkYmtKVDBBZFVucVBrWm9OcnpM?= =?utf-8?B?elh2QjRpOFc0eURLclJ1TGE1MHRRTThQa0JpTUpGQktNc1ErYjFOOHhDOEVT?= =?utf-8?B?UzlxYUF3YlRRZlQ4RnRhM0VuVm9qR2IwU2JzL1FHL0pYUHFUTmNOTWtXRncr?= =?utf-8?B?SlFwa2wzWDRVUmVDSDcxYkFqN09KcXVTOEh3OGZqSnMzdUhqdytvODNZRG9u?= =?utf-8?B?dTE4U05Jb3JkRjh0Y0daNkNCK2cyM2JRdHYvSSswZ1dkVnFXSzlnNnB4bFI0?= =?utf-8?B?VjZNSXZ6NWJEcGpaRWFLcGh3NjlPVS9LVG56ZEp4ZDA2czZlZTdHeWZjZFAy?= =?utf-8?B?OFg5bjkvcTJEZkRJVEZLRVVkMGNKL3hQR29rbXZ1cE15Q3JVUThJM2hycFk0?= =?utf-8?B?Mk5CSjNLSHI2dnNUM1FWMm9BR2FBa1ZkbkRyRVFMTHZlK2ZDd3Z6Q2lXb0kv?= =?utf-8?B?anVYTGdGNGVhc0tQQitiWEhwS0ZORnJtTWpSQVJQbXJWK2p3RHIvK3JiU3Bo?= =?utf-8?B?eWVadmFBMDVTUUp1a2xyUWh4TkFYWGhnNzM4a0hRUGV0Wi9xdGZUdnUvRytK?= =?utf-8?B?dTRjQTBHVjhGMGlSTjNtTTBZWFUrNXRONG1xQzlzVXk4cVpUbHlKT1k2V2ti?= =?utf-8?B?a3BZM295eUN6eDBHNHpqa3UyWEZreS9jSFloRHFsbkYrdXExVUcvMG9YcVQr?= =?utf-8?B?WmRTaVppd0VkVzRjMmR2YTFZZnpNTFpscjBFaWtuVFNVay9rQTc1R0RlNm81?= =?utf-8?B?VStreXFSQndlUGo2WlR1MFlWTG54dkozRENDR283OU02a0M0amU5MGxEaXIr?= =?utf-8?B?ZHV0NlE4UXpRNWt3N3BBTEh4U3B3MjQ5MHJabWNDYlNDRmMvaExpT3d6TUVK?= =?utf-8?B?VEkrV2V5VUwwRngzMVMvYXFoUFZRZlBLZDZxYlZEZ01OTms3Z0xoZHpITDJn?= =?utf-8?B?OWV4UWs2dStMZWJxdEdYZFVPV1J3eERVblBBakFFTWxvTkZvOVdpYmMxNUFC?= =?utf-8?B?bkxJaEVzU2w1SUVFalJJSUFYVmJpeTFrVExQYU0vTFArZFRFYTkycG9lNk56?= =?utf-8?B?U1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hfK0S/r0XySNmPS4uOIIA3mT7D1QjH3tZKU02dGRHbZdQe68FSdWAUBOS4fgydaIaaF3oaAyXazrSZa+Dpy6yWVZu47cum3/uEYUhELPCMr6Rlq2X7BMRQct3Sq92mOwfi71p0hKVRPVAOkZl8okZDXbEkRf4I4Oi3rzMCeuOpg5cwQZFk8eyxvdKfwR1gZ9G4Z88Yjun/GwG5HJI/Mqb2z5m0EirUF474oSGJqyXVLxj5//r5etdxcqWqOAbZ7YS5YTj+b/esH3bNky04giIM6+atkY9WEl8qyeoBg512pAjDabVHYBqCsLYwxSGpur4g4G7Vzrm3mA9h8guyduGn0OXRj3z1q6w+l1i+COL9Mc/6awgMPoEtCNie5cPaWn4ZUxM00P7xNoe3GGkv8na68+NQRh0H14ZpUzb2+dtBQY+tIq5pkbXheOEJcu27Nlu3G1qp9SiZ0wZW6Amil4L4DKJKp/yWWpzomLKtHVFhslC1W3roCY5Rt8yG0uPzPxFk1RU1s1tpdJJcT3c+8cZBFWt+OPb7KMZYHgaEQvnw7E/fu9K7DhKKcriCXO4LQwhFihCXAO1uYX4m6pFCAPu82TqKZq51MxVEbMXG2pWBYQHVQB5Sj2BXImaVpRHdK49ShGbw0C9QLs6EHemlB0xWfFsL4T7xOS+FS5fID3vzvSbfCDyo74UEnk82Io+L/sdQ3fhL3uGQUHp/onsBm8BOCw/+KcF6Fnl7NoQcBQEnasVyVXy6it8qt7xx+exNDh7tCJ8G9UIo6IfOhW75AUg7OoKbKKuPnKIlRy/dcDbt4xSNjihdIxZr1dq7GkHdr5 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a83456b1-91d3-4a5e-d8ae-08db3432049a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 10:56:03.6252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: on0nacmmeG8eE3LQhdSgBim3hrqnk1v9S9ghITwPhJkYZYjoWMEcKoSAdNvTH+nksFjpzwP7kBhgf2G5oBWYVTIMkL8XesDtUF1sNwNegMU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5189 On 30/03/2023 3:43 pm, Roger Pau Monné wrote: > On Thu, Mar 30, 2023 at 01:59:37PM +0100, Andrew Cooper wrote: >> On 30/03/2023 12:07 pm, Roger Pau Monné wrote: >>> On Wed, Mar 29, 2023 at 09:51:28PM +0100, Andrew Cooper wrote: >>>> tl;dr to add MSR_ARCH_CAPS features sensibly, cpu_{featureset<->policy}() need >>>> to not operate on objects of differing lifetimes, so structs >>>> {cpuid,msr}_policy need merging and cpu_policy is the obvious name. >>> So the problem is that there's a chance we might get a cpu_policy >>> object that contains a valid (allocated) cpuid object, but not an msr >>> one? >> No - not cpu_policy.  It is that we can get a cpuid_policy and an >> msr_policy that aren't at the same point in their lifecycle. >> >> ... which is exactly what happens right now for the raw/host msr right >> now if you featureset_to_policy() to include MSR data. > I see, but that's mostly because we handle the featureset_to_policy() > in two different places for CPUID vs MSR, those need to be unified > into a single helper that does both at the same point. > > I assume not having such pointers in side of cpu_policy makes it > clearer that both msr and cpuid should be handled at the same time, > but ultimately this would imply passing a cpu_policy object to > featureset_to_policy() so that both CPUID and MSR sub-structs are > filled from the same featureset. > > Sorry, maybe I'm being a bit dull here, just would like to understand > the motivation of the change. That's pretty much it.  Forcing them to be one object removes a class of errors, and makes the resulting code easier to follow. (Based on having tried to do the non-merged approach first, and deciding that it's not code I'm willing to try putting upstream...) >> Merging the two together into cpu_policy causes there to be a single >> object lifecycle. >> >> >> It's probably worth repeating the advise from the footnote in >> https://lwn.net/Articles/193245/ again.  Get your datastructures right, >> and the code takes care of itself.  Don't get them right, and the code >> tends to be unmaintainable. >> >> >>>> But this does mean that we now have >>>> >>>> cpu_policy->basic.$X >>>> cpu_policy->feat.$Y >>>> cpu_policy->arch_caps.$Z >>> I'm not sure I like the fact that we now can't differentiate between >>> policy fields related to MSRs or CPUID leafs. >>> >>> Isn't there a chance we might in the future get some name space >>> collision by us having decided to unify both? >> The names are chosen by me so far, and the compiler will tell us if >> things actually collide. >> >> And renaming the existing field is a perfectly acceptable way of >> resolving a conflict which arises in the future. >> >> But yes - this was the whole point of asking the question. > I think I would prefer to keep the cpu_policy->{cpuid,msr}. > distinction if it doesn't interfere with further work. Unfortunately that's the opposite of what Jan asked for.  What I have done, based on the prior conversation is: struct arch_domain {     ...     /*      * The domain's CPU Policy.  "cpu_policy" is considered the canonical      * pointer, but the "cpuid" and "msr" aliases exist so the most      * appropriate one can be used for local code clarity.      */     union {         struct cpu_policy *cpu_policy;         struct cpu_policy *cpuid;         struct cpu_policy *msr;     }; So all the cases where you do have d->arch.cpuid.feat.$X, this continues to work. The cases where you pull a cpu_policy out into a local variable, there will be no cpuid or msr infix, but these cases already have no cpuid/msr part to their naming. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:03:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:03:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517377.802603 (Exim 4.92) (envelope-from ) id 1pjHy1-000603-8t; Mon, 03 Apr 2023 11:03:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517377.802603; Mon, 03 Apr 2023 11:03:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHy1-0005zw-4b; Mon, 03 Apr 2023 11:03:17 +0000 Received: by outflank-mailman (input) for mailman id 517377; Mon, 03 Apr 2023 11:03:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjHxz-0005zo-Ow for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:03:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0604.outbound.protection.outlook.com [2a01:111:f400:fe0c::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f9f8b19-d20f-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 13:03:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8457.eurprd04.prod.outlook.com (2603:10a6:102:1d8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 11:03:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 11:03:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f9f8b19-d20f-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTxWN8JN1/kZw5Cftr7clthGSLpLFjA0BKR50jnkAp4WRPxKXTbguD6xtJIvekBYNcEY1j6iiX/0JQ+R3Ccc0PFaz1MlcLyiCfITKkzFcWU+AxrgClZhz7Jp5HUnM+HaPGw+dw92JmYIKfR5I/HC6vf5KPjVqT6MN6lBwNrTQMu+sQoOlo4bLd0xeTXlP/B2nwpo85rM3dU1YLPPJ1cnnB5B7BhTRuQTpT/mIFK30dUp3PKk13XgBh7luU5thWGYeubuBIKPVxgDBh/cQVqgoiLuvU06Neiw5SrEAsz8Mx8CmXXmxoS6A6p71Xbwt4FmxdNxojIfoe073SBEXdxjwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=stlEyM17FXGz/0HvkYCKDBzaDmPVE+3EdmWVSIMQhbI=; b=bNG1yLlsmEZQOIGZ6sERDnD5C856fqnwm+sJ1B55y/S1uQoIk68BURMyBtHiXz7AWkBNdknl6e0znLVrV6SOKhMMt6S2WBqOYnmkIWm+K26uZc/KINhh1/Ma9Iq3jHzOkoBDueCIJTLophgDrl1z9Yv8qC4afoKw36qb6nUPPokOhiLiqZrTP2hnLMgs8Bv23UYhWCawhVxOfTiFg7A5mO89grGlfR87o4l2kSVp4i4mB9tTMaSqHOqOZeoqJ7xSiwJw9c4c6IsTggvOuw3waAjPUPxsZawTYpd5PlTU6oNXfZdrU/6t/Cb0KDwGcDqcXoNR7oRmTSNS8FZG+nxDrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=stlEyM17FXGz/0HvkYCKDBzaDmPVE+3EdmWVSIMQhbI=; b=3kwxwvug9kGJfRYWGcwUtIvDOiEgr5YRPUCMvOuapZU8104YGYjfvKAQ+T134IQ7jhyFJkeuVOG6a0VV0KkX4aNCRpfyK7cSbgqwaNcZBEKLEOu/Lt2TM3pjJezCRDIA65MXIdTNbL5NpD4Lb4yqMmozatnD8JwFNYuQLhjfkyTZxigznCLEvlUZ2fmlh4HoFrUb2EE0qwIKosvupn1qbdrY1oIfrm9iD0sURqm6x4WHu4UGaq5SN7hP32iPbcsZd/NxSOI6PsIDZ8vrhNbHjlLj09UTcJuU2Rv+gJJVBB5EUU8JzMGDfHyPtgOU8SNVmsN9b5RFVCLtMK3DhJC6wA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 13:03:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: marmarek@invisiblethingslab.com, xen-devel@lists.xenproject.org References: <20221123154525.63068-1-roger.pau@citrix.com> <20221123154525.63068-3-roger.pau@citrix.com> <50fe2ff9-9633-1cbb-4afb-b577778d3edd@suse.com> <6dcc187a-5e81-2f36-4104-d9caac148cdd@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8457:EE_ X-MS-Office365-Filtering-Correlation-Id: 44b503a8-60bd-49df-14ae-08db343302b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FRzZlu1H3q+FkKkcUoaOpL8rQjE6qxbubGgf83xtwvUaPMYY5AALnvbykQAUj6acIDnEzaZ7PdKQEHQYkWzGw39ZGy+YreMQxCiE47Tg7Ox6DQ6w9X8CkCe9FgDG1BvnuJBnkmkqEWapqFrW+5VSFjXy21dLVbf1QKQVyGa+b/5rWZLBQzM7DWGC66klefCCOWprPd9l4XKF+mqUmgdhqaNIEG018oIGiBJc4Tudm7WYD/cgV2ukKtFoZ0x+J9tB6EY8erjRK7+f8WLq3V1MOOQy5IrTuBJs7jjo+uQ1VSrYXEnJ8y1Iv4y5kzjAB8u/6XV/OeSsh2zbuQgsB5Lar97HrvTU93nmysbzmcxqFYL8y4WDQ/UR0lk8gbZ0W8xjJbmhMvsDI4s1PS4mjRiaFTEntOKcFhK42JmAXcIii6wzs29XTs+NCOVCWwXALO19bYDNc8cV3ZpnMbkyuCOwTiNclxcPOErK/udZSnihzOSBug9JMz7MVKqd3TO/0BKnlnWIs08o/PWwILgYXqHndrW91EbIJUabh4NmYPZocGJDlamD8zxuFSFREEQ16DQpAgq2uAzBN65moMczZBjoPrN2O10jcsyWi5QzFPydwEISHa0DTPmU4JN5z7IdhozeJo/gKCC3pHS8P5/MB/1LFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199021)(8676002)(66476007)(6916009)(4326008)(66556008)(66946007)(478600001)(316002)(8936002)(41300700001)(38100700002)(5660300002)(53546011)(186003)(83380400001)(2616005)(6486002)(26005)(6506007)(6512007)(31696002)(86362001)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3krVGhEZDZMQ1B1a1BuUitXRlBxRzc4RWpMK1JncFNDellpTzFtMlpQNlhx?= =?utf-8?B?S2doMWZFVjlFaW1rdnh0VndpLzZLYkZibkt0TmpmZkpMUHZUSzJ2MTc4TTNs?= =?utf-8?B?cWwvRWZQRHN2RkZIbURoUk5IbW1jTzNvdHE4M1ZyY0VBbDVKSDhDQS9LN3hx?= =?utf-8?B?WU8zdVVrcTR6K1FydGVhTXVENFViSU5Pd3l1QWJzYTQ4VmYyZlRlYmZvaCs2?= =?utf-8?B?eUpFLzAreXk3cWhvYXNJZ3FpRnNmQ0h4bzJoN0VQSG9wb0t0YlJ6MSs1bzha?= =?utf-8?B?T3lxY0pvQ2NTUnY5SDJEL1lpMkl2VTI4bXgyaDdMeWdpN0pSK3N0RWtROUZo?= =?utf-8?B?eTRqbmpYMi9DLzVqNWw1a0lPOElEcUM0YkNENEtETlhxQnhuQmJHRVVLSEJs?= =?utf-8?B?Ny9iMHRnRTQ0V1MwU3E1ejIvL0kzRUpIZTA5SGFlZGl0SXYydVI4bTNXaDEw?= =?utf-8?B?b2RWUXZJMGJGbG9qTGM4WW9ncmN2NlRicVJ2N1RLa0FQZzBxT2FHaUpOMEgw?= =?utf-8?B?VHI3S0VFenkwcElPZkN0VUcvdmM0NlphTjV4L3RFeXIxVUZob05MTVNRUEty?= =?utf-8?B?VHpCWGRLQVNhdUFsNHhTYzJ4L2JrWDcxV3pmNHNuOTBwRklyaVJwM3ZlVEdw?= =?utf-8?B?cDFXY3NFaUZKckdHNjVzRjlwUFpCUU9MMHdWRWpUcVRsSGVUUXNFMFBCSS8x?= =?utf-8?B?aTNsSlVXaEQyZ3JrZWpSTTRXU1lFL2ZySjhUK2N0K0tFUFdvR0Q2bVR0WEVo?= =?utf-8?B?c2FFUnJUNHJSOVZHKzYrdUV1M1J4bVE5eFE5eEdVZTFFOWtYZmwwMGR6Vld4?= =?utf-8?B?TG9zeDFvV2N4eTdCajJwNUIyS2ZsQytjYk1KdmtKQ0FzNXAzR0N5R3dwcHBQ?= =?utf-8?B?UW55cE56b3RNQ0JNekxzZ0xPV0RoNkErcEtoL21YeXlSaWpsc0hWSnorRFJG?= =?utf-8?B?Q3Rjeno0bzZhT1pMYTFJMFdZVVdENTZ6bnZGOHo0ZXkwMVFPNGg5WGxHdE00?= =?utf-8?B?MmI4REdNMVBkMC9JdXRHdEtXc1BOWVlkdG1Wd1FYcXhXY2RSaitITk1EZXZl?= =?utf-8?B?dFFjd2ZIbzU5cmgrWWswRXRkd3RtaXg5WW1aT1pvNnJjeU9OVE5lUm5jL2pz?= =?utf-8?B?ZHJXQmk3ODhHVjMxTG5RKzlwNEJab0ZBZzJOQWZ3TmZiaGVjeXRzWDgwcVcw?= =?utf-8?B?N3lweDdCK0JlZW5obTlNWTNuSHFlL3RETXQxVFp4MEVHQ29QK1N4dU5lQy9F?= =?utf-8?B?R3FFd244U2cwWUVIbE1pYXBlQ0RLaGZOeUw2ZUJhcHMyMEYwcVpBZTFpTVdU?= =?utf-8?B?K1RiM25UUHhYUUlPa2JNTUorTW53cXVKZWZhcjQ2T3JPcjZCSmwvVTZpWVBi?= =?utf-8?B?Y2NWOUpnY3ZraDlsMVB0RDRkQ1dQZWtyYytPY3A5TitKNldrd1BXbFQzZFlX?= =?utf-8?B?d2VtR2RLU0lBZUlzZEkwV1Q0dGJlaVg1VkNmVGpyb2F4TGZ5Zm9QOGNscW9T?= =?utf-8?B?K1EzKzVPUzhteW9uaVV3QWF6VndVQ284VWJtWkRpL2NVVVdFNkdTWnhJVkwx?= =?utf-8?B?d1N6cTZxVjVYZ2dyK2pFTWp6aE1uV1ZjMnBXQThGL2NvT2JxOE41Mms0L0tV?= =?utf-8?B?b0laVmtLVXBwWmJsdVBlNkZWQ0hucGFCMzZ2NmVpb1BZR08ydXV6dkhuOHY4?= =?utf-8?B?bmQzSEUyVWNHdjFENTRVeHBQa3llRlNOQ1k1Qld5bGZtdVN0ZXM0empMTXBM?= =?utf-8?B?MEJyYS9lOVRpR1BUMWZUalBXM0swMkdjVDhCdUtzbHp6dE1aUFVhNnp5blFL?= =?utf-8?B?SWpMQjVpRVZIekVhMHVmbERWOEVQS1JxUUU1TEdTSDNSRjVqS0xvVGNRRVhk?= =?utf-8?B?M25KYVhQdDY2ZUlSaVBZcnlTaU1XWFRKd2YxRmpwQkViQVZjektVaTZaYkxY?= =?utf-8?B?ZFFpaXFLakx1V3JobGltbHk4bVVQdjI0ZjZVakd0NDljZ3BsQ3NQQmVsRFhC?= =?utf-8?B?OWhsMVZIVkVqRVZ3NFlRbjdyQk5DYVRvS3JLTnJrV3pmOW9mK0xjSzAvNVNa?= =?utf-8?B?c3ZlV1VETnNqdWhPalQwdjYvQzlqanBIVjRNODNpb2l0N0psdVp1ZlhnYXVW?= =?utf-8?Q?BPVPehI+B3cwqgT86rcLuki/f?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44b503a8-60bd-49df-14ae-08db343302b4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:03:09.7992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wkXWOw90cf/XFu9WZvwt9RYmliXX8ZBwXj+/fAkHQzw73zrExqYIx+EQK+WOZMNQ0Ur60Vk12QD3c28xkAEqNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8457 On 31.03.2023 09:37, Roger Pau Monné wrote: > On Fri, Mar 31, 2023 at 08:51:46AM +0200, Jan Beulich wrote: >> On 30.03.2023 18:17, Roger Pau Monné wrote: >>> On Thu, Mar 30, 2023 at 06:07:57PM +0200, Jan Beulich wrote: >>>> On 30.03.2023 17:44, Roger Pau Monné wrote: >>>>> I guess I'm slightly confused by the usage of both GOP and StdOut, I >>>>> would assume if we have a gop, and can correctly initialize it there's >>>>> no need to fiddle with StdOut also? >>>> >>>> Setting the GOP mode is done last before exiting boot services; this >>>> may be a graphics mode which doesn't support a text output protocol. >>> >>> Right, that's what I was missing. I assumed that all modes available >>> in GOP would be compatible with the ConOut mode. >>> >>> Would you be OK with leaving StdOut as-is when booted from multiboot2, >>> or there's a chance of things not being properly setup? >> >> On modern UEFI it may be unlikely, but I think it's not impossible (see >> below). >> >>> IMO it's not very friendly to change the StdOut mode if not explicitly >>> requested, as in the multiboot2 case that gets setup by the >>> bootloader. >> >> May get set up, that is. If it was set up, then yes, we probably should >> leave it alone unless told to use another mode. I.e. no vga= or >> vga=current should minimally result in no further mode change. Aiui we >> can't easily honor vga=gfx-... in that case, so leaving the mode alone >> there may also be better than trying to guess a mode. The only time >> where I would think it would be nice to switch by default even in the >> xen.gz case is if the boot loader handed us the screen in some text >> mode. > > How would you detect such case? > > ConOut is always text-mode like because it's a > EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL interface. > > Would it be a matter of checking whether the current GOP mode is > valid, and if so leave it as-is unless told otherwise by a command > line parameter? I think so, yes. > I would also like to avoid the unconditional resizing of the ConOut > interface that's done in efi_console_set_mode(), as that has the size > effect of changing the GOP mode, so I would only call > efi_console_set_mode() is there's no gop. Or maybe when the set mode isn't text-output capable. > Not sure it's meaningful to change the ConOut number of cols/rows if > there's no GOP, maybe it's possible to have some kind of screen that's > usable for EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL but not as a GOP? Of course there is. As said, earlier on screens started in 80x25 mode. Even going to 80x50 or 80x60 is already an improvement. Plus there are systems which support wider-than-80-cols text modes. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:09:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:09:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517383.802612 (Exim 4.92) (envelope-from ) id 1pjI3w-0006dd-TG; Mon, 03 Apr 2023 11:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517383.802612; Mon, 03 Apr 2023 11:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjI3w-0006dW-QG; Mon, 03 Apr 2023 11:09:24 +0000 Received: by outflank-mailman (input) for mailman id 517383; Mon, 03 Apr 2023 11:09:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjI3v-0006dQ-GU for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:09:23 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa06ae9f-d20f-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 13:09:20 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 07:09:14 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5469.namprd03.prod.outlook.com (2603:10b6:a03:28a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 11:09:12 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 11:09:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa06ae9f-d20f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680520160; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=v4J3NCj80jQPpfZWL0DWy5puK/iCxs6yTjvQS4+UW8Y=; b=HPA5GIvpmEiwDkhU3W3O8zcbeQIGLiQxOxevDrQi7/uJH8ErnHpq1uOc KbpNxBx+dM7Ibz4vPQWXK43Sh9h6YQYY3Vq5Gt7nxaFUhBKPT4CemjoNT oRlg8Hb5Y389Xgm99b2dugxe79LtYI+fop0tjugQtp9XpAqTcQpl379He M=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 104022316 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:c6a9tKhJsotYJd8aklRHjhV4X161VREKZh0ujC45NGQN5FlHY01je htvD22OaPvbNDT8eop0a4uz/UwG6sWAzt5gSFQ4rn09Q3sb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQyBiokMTGMud6szYiFWM8xps4EMsT0adZ3VnFIlVk1DN4AaLWaGeDv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilIvluS0WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHunANhIT+TmnhJsqEXC1C8sI0cYbnC2+9OlhU7mae5bM XVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9UXuA8p+EoDX0PjIaRUcdYQcUQA1D5MPsyLzflTrKR9dnVauq1Nv8HGiqx yjQ9HRnwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBb8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:ALJMR6ww4tx7TFt2b3TPKrPxTegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu vr2iIBzADQCUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T+c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdkDXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZ8fgHC40Qtkdlg2O YTtljp/6Z/PFflpmDQ9tLIXxZlmg6dpmcjq/caizh6XZEFYLFcgIQD9Ad+EYsGHgj99Ic7ed MeRf301bJzSxe3fnrZtm5gzJiFWWkyJA6PRgw4tsmcw1Ft7QVE5npd4PZasmYL9Zo7RZUBzf /DKL5UmLZHSdJTRb5hBc8aKPHHRFDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop LcS1lV3FRCNH4GMff+nKGjzyq9A1lUBV/Wu4NjDtlCy/HBrYPQQGy+oAtEqbrknx0daverKc pbdqgmR8MLFlGeaLqh7zeOJKW6FkNuLvH9muxLL25m8fi7XbHCh6j8TMv5AobLPHINZl7fa0 FzLwQbYv8wo3yWZg== X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="104022316" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvvgfIZ7HE4PDCUUdyqVH/IDs0l3vXHznj9PPIL0J9zvMjGbcOJoQy02KBiWEA+P/ehA5GsQvypLTUchucUjvNlNsrRQ08VQui7I682ikN0DjBzUG5Qsl7FpOnBd7cEY3sIvVRR9kb6u+C7YyHCjUObNqCQYMZz9sqI86RO5q/sKZKLYW5GFWSKLwZnJzwTdidkcncw9TIVS1duWzn67Qi5meJM2plEm80X4w3Q+7I/RPTYDz+XEnTOAIy57bNuSLyEnibd+Mfdhs1VcrGHaDhX2sx1n1M1C6B0gwa99lwgr+1r8mw/jaDQy/f/60EYcDI2PgaVDdzT9HCP511jjGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t14AAj2zeHUEhhx/uWYA+ay1WChw3nkDJJQ/8Wx9Pg8=; b=mJ8dVNHlcA+Sy/uERac9nF3krVvp8bOhZNGZAxFP8CmFF7ecw9aZ8qxlnSvQfmf1P5p2d8QLYFrSYD9svbwAdpGJYjJb8f4Ok8nyQ3Z7ufhu/R999vFfk5duKQ9dB2xfCnADeE2JZIZkLsYO56L0/dwfkbAXrCSwnFNnDzV2EcSusU4p9YWaV/ouuJieoX3HdqDnMsksZRKJxACXQWwA9GDXO4cK8B9kwB5/jEIoUIpTKYODp8BVxhfPTcsNnig2Ab3NQOYeJwItv5QSJh4tyqehFcu2E4BKN6RPxx+VmxpS9/pj/x+TvMj/cAl1G87OMnHZY/X3NZr/2okB15KZ9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t14AAj2zeHUEhhx/uWYA+ay1WChw3nkDJJQ/8Wx9Pg8=; b=DcKHQO47nOrDSL1rEl6GlJ1zhYy5O4CNf+7VDyvEDtVeHi9adu5d4KdZaCPiXm3KHGm14bVpjozVYHcsZ8mccRECNkreIGk4rPHIOg3/YxMGOkATUOTVTsKjmjyO4qEi1HVgV16gSt0UgS3G7j8fAyzZgQopQkIvwXaVeZQLdps= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 13:09:05 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v5] x86: detect CMOS aliasing on ports other than 0x70/0x71 Message-ID: References: <5426dd6f-50cd-dc23-5c6b-0ab631d98d38@suse.com> <8f2fa47d-89b7-b39c-e60f-edee1de5ca82@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8f2fa47d-89b7-b39c-e60f-edee1de5ca82@suse.com> X-ClientProxiedBy: LO4P123CA0575.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::7) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5469:EE_ X-MS-Office365-Filtering-Correlation-Id: 58fa5742-ebc5-4235-149f-08db3433dacb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Akg7sTkmdu0g0OCYDZAN0JLnGuWcu0q7GLckNjWEPIl4oHCmMYCkXSEOkGRjKZIih3Hy8utzauxtgm8HT0amNQGh+Mf+eWV6w/WxFaENt9L5zbxCGGY+MTta02gP/RGEfEk9Bd5vAY8mfwS0WnfNOfjQYAQBwgPc4UhzcJwAf2fUE2WH4bcpukcPrKhNZllSCzlGtoOV17JHWxp6Sgx9ROXlP9d0+I4RN7uxPCTpePpH6snBA5KlUu3sBu2J9ZZhq9MmoYj2XrLeGeL8m37cmT0oY3DqnZ9q0xk7vSdW8KSCUy4vMkwF+mzKKjIhWrFITEuRNUDli7ifxEml0xpveVw/aVZ2qN6uV6JCrP52nPzoelPU/gnEuRZEWRYm++HyDJKdAhixN6rA4zXYcHNlWSfTK/mP0uQmZqofeIbJueDs0L5hPFklTFKrgRiShU4c7GfyUky0VLd0zVDEPLii7ELEsoOCuYLGl+k6vr6O5y9xL5DJNYQXLp33AGcfqI92wl/aNJxmVetJ9pBFzbYmXsdQ6QyEDwEaewXHZpKi1pSe1Ayyq//DHBe9lSrbcmHj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(366004)(376002)(346002)(136003)(39860400002)(396003)(451199021)(86362001)(85182001)(33716001)(2906002)(6486002)(83380400001)(186003)(6512007)(6506007)(9686003)(26005)(6666004)(4326008)(6916009)(478600001)(8676002)(66946007)(66556008)(66476007)(82960400001)(5660300002)(38100700002)(41300700001)(316002)(54906003)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUxhSVlRWStmbThEUkdGdlAxdTN1MDZJZFo5dGFGUE5PNW1PdS82QlMxRWZh?= =?utf-8?B?Mk1ZL0dSaE1TYXRjU0FxOEVHb3hzaElsZEtXVmp5WXN3YnhnbGc1dU5QWmxs?= =?utf-8?B?Y2dYdjVjMG1BMlFJWmhkMU9LL05BaXZWd1QrbUpGTGh1dVR3USttN1kwSGJU?= =?utf-8?B?YUN1d3owaGJNQzc0NVFHRTlCbVoxUzd0aUQ4SDRGUnFoV2hPaDAwZ09XQ215?= =?utf-8?B?R245OGRxb0dQa1NkWTIxL3V2VUpnUy8wLzFaRWl6ZjFxSE13eGV2OWxJUWlT?= =?utf-8?B?TVltblZyeldzMGozNC9WTVJTYjNQSG0vRVgrQ1Mrb2ZMa280emJ1TjJKVUpL?= =?utf-8?B?SlR6VVRDa0dvL1hmR2x6V1FGYWN2V2l6aEVxWkptVytxL1VEWVlVUFIra2NG?= =?utf-8?B?UFFFOTZ1NmhvSVNLQXI0di9heGRRVVRhbG5CSkVYVHBRdnJ6ZVZaVUNrT2lt?= =?utf-8?B?MEN0d09JZEhBT0VUU25VZDVNU2Y0bTJmSUtJNktubm5RWDBmSGZ3RXI3OGU0?= =?utf-8?B?QUVrNExIVEM3YVhsYWZjSmcxeDNiRUFaSzZFLzB0TW01UkF2cXNxcy9CNGpw?= =?utf-8?B?TEJSbkplZFc2VFk3dWtnNU1oYlkxaUFiNTBIL0VKREI2SVdaaWpyMGd5TzNv?= =?utf-8?B?TTNTMWNrUmxnRHp1bURISk1KZGVxVzYwdktlRnlRODg1N0J2c3pEcStDaG9t?= =?utf-8?B?R1paMFN1V054Q2lsN2RDbUZkSkJ6YTJVQ1FnbTJ3T21rTGp2Njg1WUthTVJa?= =?utf-8?B?VTBmNFRCMzNFblNOUFNsT1o4cGFUTnd1bTF0WDk2dmxyZUlyWEp4T2d3QTFS?= =?utf-8?B?RCtqZVZDUzcwZ1VtTWxSd1hYeVRHSnU1WFpEbDhQcUdtWGpMNW5wd0pIKzJF?= =?utf-8?B?TFBBUEY2WFA1dXhyaEZhMzB6eWoxSjhJZUtHZVM1b0JacnpTVDgwWUxJZVk5?= =?utf-8?B?K1E4OTNHZkVXaXlDejNuUGcrWnhpaHNNVGo0T0h5TjkvWkFpS2U2RS9aNzNt?= =?utf-8?B?U05sb1VNcnVDQUN3U2FKT2laY2p4V1FGUzlPZFVPYkxFVnRXMTV0Y0tmWTEx?= =?utf-8?B?RzFad3o0RnF3MXlnOXNvcW5tK2FnVEI0Z1IrdFJPaXIrUG1jKzlXTnRteE16?= =?utf-8?B?Sk5zd1FzSEZCRGprbTVxZWNncDd0dE9ldWdpY09DWFRnOTQ0eThXajFsR3lk?= =?utf-8?B?OUtseVJtQmJoZElYa0ZSL1I3NmttRjZUQVBJbTZwMGl6ZmtYb3BrTUNnajhU?= =?utf-8?B?RkFtcWlYVWtLU0RRd3hiUmdQV25KQ045UlZMYXJsYnVFTjRNLytoUVNEVjNB?= =?utf-8?B?ZVNsUmNvYUdWN1BPQURvR2Mwb2R5Z3JIdkZoL3hvVkxaWWNRWG5xT3MvTHBH?= =?utf-8?B?OGdLMzRGTlh4eVYyMjh0WWFkKzFKUVlvS1ZObDdvblpFcnNNTGpRRkJ6bzFq?= =?utf-8?B?VWtwaldXajRqNUlUdGE2S21qclZOaCtubGM4STdrcmJmOWRJV3QxZDZjOC9t?= =?utf-8?B?OFpJSDRySmlrOGVRUVhyazNTeXprSk9xaUhBMmMzTFVwRXJSMHRDdG9HV1dS?= =?utf-8?B?RHY4T25JOS9SSGQzY0ZFNVBhblJMVlpFQXU2WHFGRmx6UFlGWWN5Y0Q2RUw4?= =?utf-8?B?SHhEV01PTmdkUjg3M1J5NFhZUmdUMUd4VUVlVG1iQmVTQlZxaHVrc0Q4TU5w?= =?utf-8?B?OHNPeE13cmNjaGxjbnN6ZlV0ZW55OHlZellsd2RhdHVYaXJZS0hwZ1hOTUVl?= =?utf-8?B?cUI4anBZdFQ2cnBTVWladUhWQms2TUo4WTBraDMyKzYzcmV3Kzcwa1RUMFV2?= =?utf-8?B?SGhndXR6WC9OVjArL0xZSmM0OE9TVmhaS0E5MUdXWktNS0k5aVdaclphcHRu?= =?utf-8?B?UzlnL1lqaStIQ2tKM0dXQUxrK3Y0bGNoSHMzWnVOOTJNSTczdkU4VmlmUDUv?= =?utf-8?B?ZlFzMzA2UytSc0x0TzNzUmtlMXVKTngxR0dxMkpodW5HODBCRU9VMmhxMGpY?= =?utf-8?B?OE1lbktPQjVKZ3locFk5UVlmcDZkMk4zV2NkdVBTZjdTNXdjbGQzV1hyaUw3?= =?utf-8?B?Sk14ejFxOFo1Ky9BTDBXR2g1Y01Vckk3RG5qUDcwSzhZNGZFc0JZbzcvNmJB?= =?utf-8?B?MTllQUZObUtvVkFLamZVWnp2TTA4QVF6c0NReEhFeFQ4OTFBTml1LzJtOHdY?= =?utf-8?B?UXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lejQw9zKMxEMnfcRK+qkS9rnF6cGzoNe18E0jRMV3JiU138QnkEeXFTshpoTKcKABmi2eikSqkPixwi3takHBWBBxNB0nVGitVdlzTga/dPvLoVzqoIieY1LovtF3N3ZZhYhz3YhOCIOW3SVtwGUDwes06nkFkjrc/M5/Qk/s6ZsgV8FJxksrO9XvRB5jI7tUE0pD5KvZOuiXIJnWqcF3HgLOoOYKrY3yD8k4Nzc2Ypmk1veMA80E1L6EXNXxyH3z1Fow/Nt7I/5aHkbWyiPGLx20y3LjOMotePYezKkNLV8u+LcRSn5Te2UNuVGNof+WFquH6VxTZHzbY1i3s8dsXfXVM6ZDxwDdqsykxtRDC+6XpD2bbwoIkUfZpx3ue53ATbpqTROfCt3PDC2EHYaBJ9NedPQjQVkou7Es5ISQTeoU/Ex33lsJ94lWaKViBxab2WVe84aXDyHR4HLtcY4tgrQ9SaIORPTXWvcQdZ5KvEceEj9Wixv1JKRq9BXxFsElMUzeIyWWslB7Ze/5rc/PN3NO2cxWcFVcgQihdu/PK1lcO80q5RqZiGF9sOoveD7psURVtUbd2zHQvgTNk5gC8e6xG0g4/j90swqbfEtYPSrog6Hew/NcqM0FmsIoC26Tdph/61kUNHLMTiRihDJTTMLBxy7arFvmedLk3tjkMjI2Wu80tUiDJ1DXCkGsCt/0qIDFGeWZ4Hop89Dxe9SMbSGCpxVpnLJ836FzwXmmE+vf8aaEUvmLqqnLJ+JuHd8eAXrhzgXWPRfgJSlDrb73gpklIKCUVe8BmGNQHAAZofi7FQpdScfaQja5tpcAsnN X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58fa5742-ebc5-4235-149f-08db3433dacb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:09:12.5348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7lpLMQ8Z7Ntr6GVcLgbwRZKFq184XxS9nt3ilPLqY2nijENSFfjjXRiQypU1i1Hau5AGfKYVUTXN2uUrSLoRJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5469 On Thu, Mar 30, 2023 at 12:40:38PM +0200, Jan Beulich wrote: > ... in order to also intercept Dom0 accesses through the alias ports. > > Also stop intercepting accesses to the CMOS ports if we won't ourselves > use the CMOS RTC, because of there being none. So it's fine for dom0 to switch off NMIs if Xen isn't using the RTC? Seems like a weird side-effect of Xen not using the RTC (seeing as we would otherwise mask bit 8 from dom0 RTC accesses). Also I'm worried that when Xen doesn't intercept RTC ports accesses from dom0 could be interrupted for example by the vCPU being scheduled out, so a vCPU might perform a write to the index port, and be scheduled out, leaving the RTC in an undefined state. I've read claims online that the RTC is not reset by the firmware, and since it has a battery the state is kept across reboots, so interrupting an access like that cold leave the RTC in a broken state across reboots. > Note that rtc_init() deliberately uses 16 as the upper loop bound, > despite probe_cmos_alias() using 8: The higher bound is benign now, but > would save us touching the code (or, worse, missing to touch it) in case > the lower one was doubled. > > Signed-off-by: Jan Beulich > --- > v5: Simplify logic in is_cmos_port(). Limit the scope of a local > variable. Adjust a comment that's being moved. > v4: Also conditionally mask top bit for guest index port accesses. Add > missing adjustments to rtc_init(). Re-work to avoid recursive > read_lock(). Also adjust guest_io_{read,write}(). Re-base. > v3: Re-base over change to earlier patch. > v2: Re-base. > > --- a/xen/arch/x86/hvm/rtc.c > +++ b/xen/arch/x86/hvm/rtc.c > @@ -27,7 +27,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > @@ -836,10 +836,18 @@ void rtc_init(struct domain *d) > > if ( !has_vrtc(d) ) > { > - if ( is_hardware_domain(d) ) > - /* Hardware domain gets mediated access to the physical RTC. */ > - register_portio_handler(d, RTC_PORT(0), 2, hw_rtc_io); > - return; > + unsigned int port; > + > + if ( !is_hardware_domain(d) ) > + return; > + > + /* > + * Hardware domain gets mediated access to the physical RTC/CMOS (of > + * course unless we don't use it ourselves, for there being none). > + */ > + for ( port = RTC_PORT(0); port < RTC_PORT(0) + 0x10; port += 2 ) > + if ( is_cmos_port(port, 2, d) ) > + register_portio_handler(d, port, 2, hw_rtc_io); You seem to have dropped a return from here, as for PVH dom0 the initialization below shouldn't be done. > } > > spin_lock_init(&s->lock); > --- a/xen/arch/x86/include/asm/mc146818rtc.h > +++ b/xen/arch/x86/include/asm/mc146818rtc.h > @@ -9,6 +9,10 @@ > > extern spinlock_t rtc_lock; /* serialize CMOS RAM access */ > > +struct domain; > +bool is_cmos_port(unsigned int port, unsigned int bytes, > + const struct domain *d); > + > /********************************************************************** > * register summary > **********************************************************************/ > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -220,7 +220,7 @@ static bool admin_io_okay(unsigned int p > return false; > > /* We also never permit direct access to the RTC/CMOS registers. */ > - if ( port <= RTC_PORT(1) && port + bytes > RTC_PORT(0) ) > + if ( is_cmos_port(port, bytes, d) ) > return false; > > return ioports_access_permitted(d, port, port + bytes - 1); > @@ -290,7 +290,7 @@ static uint32_t guest_io_read(unsigned i > { > sub_data = pv_pit_handler(port, 0, 0); > } > - else if ( port == RTC_PORT(0) || port == RTC_PORT(1) ) > + else if ( is_cmos_port(port, 1, currd) ) > { > sub_data = rtc_guest_read(port); > } > @@ -436,7 +436,7 @@ static void guest_io_write(unsigned int > { > pv_pit_handler(port, (uint8_t)data, 1); > } > - else if ( port == RTC_PORT(0) || port == RTC_PORT(1) ) > + else if ( is_cmos_port(port, 1, currd) ) > { > rtc_guest_write(port, data); > } > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -2131,37 +2131,36 @@ int __hwdom_init xen_in_range(unsigned l > static int __hwdom_init cf_check io_bitmap_cb( > unsigned long s, unsigned long e, void *ctx) > { > - struct domain *d = ctx; > + const struct domain *d = ctx; > unsigned int i; > > ASSERT(e <= INT_MAX); > for ( i = s; i <= e; i++ ) > - __clear_bit(i, d->arch.hvm.io_bitmap); > + /* > + * Accesses to RTC ports also need to be trapped in order to keep > + * consistency with hypervisor accesses. > + */ > + if ( !is_cmos_port(i, 1, d) ) > + __clear_bit(i, d->arch.hvm.io_bitmap); > > return 0; > } > > void __hwdom_init setup_io_bitmap(struct domain *d) > { > - int rc; > + if ( !is_hvm_domain(d) ) > + return; > > - if ( is_hvm_domain(d) ) > - { > - bitmap_fill(d->arch.hvm.io_bitmap, 0x10000); > - rc = rangeset_report_ranges(d->arch.ioport_caps, 0, 0x10000, > - io_bitmap_cb, d); > - BUG_ON(rc); > - /* > - * NB: we need to trap accesses to 0xcf8 in order to intercept > - * 4 byte accesses, that need to be handled by Xen in order to > - * keep consistency. > - * Access to 1 byte RTC ports also needs to be trapped in order > - * to keep consistency with PV. > - */ > - __set_bit(0xcf8, d->arch.hvm.io_bitmap); > - __set_bit(RTC_PORT(0), d->arch.hvm.io_bitmap); > - __set_bit(RTC_PORT(1), d->arch.hvm.io_bitmap); > - } > + bitmap_fill(d->arch.hvm.io_bitmap, 0x10000); > + if ( rangeset_report_ranges(d->arch.ioport_caps, 0, 0x10000, > + io_bitmap_cb, d) ) > + BUG(); > + > + /* > + * We need to trap 4-byte accesses to 0xcf8 (see admin_io_okay(), > + * guest_io_read(), and guest_io_write()). > + */ > + __set_bit(0xcf8, d->arch.hvm.io_bitmap); > } > > /* > --- a/xen/arch/x86/time.c > +++ b/xen/arch/x86/time.c > @@ -1234,7 +1234,10 @@ static unsigned long get_cmos_time(void) > if ( seconds < 60 ) > { > if ( rtc.sec != seconds ) > + { > cmos_rtc_probe = false; > + acpi_gbl_FADT.boot_flags &= ~ACPI_FADT_NO_CMOS_RTC; > + } > break; > } > > @@ -1249,6 +1252,77 @@ static unsigned long get_cmos_time(void) > return mktime(rtc.year, rtc.mon, rtc.day, rtc.hour, rtc.min, rtc.sec); > } > > +static unsigned int __ro_after_init cmos_alias_mask; > + > +static int __init cf_check probe_cmos_alias(void) > +{ > + unsigned int offs; > + > + if ( acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC ) > + return 0; > + > + for ( offs = 2; offs < 8; offs <<= 1 ) > + { > + unsigned int i; > + bool read = true; > + > + for ( i = RTC_REG_D + 1; i < 0x80; ++i ) > + { > + uint8_t normal, alt; > + unsigned long flags; > + > + if ( i == acpi_gbl_FADT.century ) > + continue; > + > + spin_lock_irqsave(&rtc_lock, flags); > + > + normal = CMOS_READ(i); > + if ( inb(RTC_PORT(offs)) != i ) > + read = false; > + > + alt = inb(RTC_PORT(offs + 1)); > + > + spin_unlock_irqrestore(&rtc_lock, flags); > + > + if ( normal != alt ) > + break; > + > + process_pending_softirqs(); > + } > + if ( i == 0x80 ) > + { > + cmos_alias_mask |= offs; > + printk(XENLOG_INFO "CMOS aliased at %02x, index %s\n", > + RTC_PORT(offs), read ? "r/w" : "w/o"); I would consider making this a DEBUG message, not sure it's that useful for a normal end user, and printing to the console can be slow. > + } > + } > + > + return 0; > +} > +__initcall(probe_cmos_alias); > + > +bool is_cmos_port(unsigned int port, unsigned int bytes, const struct domain *d) > +{ > + unsigned int offs; > + > + if ( !is_hardware_domain(d) || > + !(acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) ) > + return port <= RTC_PORT(1) && port + bytes > RTC_PORT(0); > + > + if ( acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC ) > + return false; > + > + for ( offs = 2; offs <= cmos_alias_mask; offs <<= 1 ) > + { > + if ( !(offs & cmos_alias_mask) ) > + continue; > + if ( port <= RTC_PORT(offs | 1) && port + bytes > RTC_PORT(offs) ) > + return true; > + } Maybe I'm confused, but doesn't this loop start at RTC_PORT(2), and hence you need to check for the RTC_PORT(0,1) pair outside of the loop? > + > + return false; > +} > + > /* Helpers for guest accesses to the physical RTC. */ > unsigned int rtc_guest_read(unsigned int port) > { > @@ -1256,23 +1330,25 @@ unsigned int rtc_guest_read(unsigned int > unsigned long flags; > unsigned int data = ~0; > > - switch ( port ) > + switch ( port & ~cmos_alias_mask ) Given that the call is gated with is_cmos_port() it would be clearer to just use RTC_PORT(1) as the mask here IMO. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:09:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:09:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517384.802622 (Exim 4.92) (envelope-from ) id 1pjI48-0006wK-9w; Mon, 03 Apr 2023 11:09:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517384.802622; Mon, 03 Apr 2023 11:09:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjI48-0006wD-6M; Mon, 03 Apr 2023 11:09:36 +0000 Received: by outflank-mailman (input) for mailman id 517384; Mon, 03 Apr 2023 11:09:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjI46-0006dQ-NP for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:09:34 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062d.outbound.protection.outlook.com [2a01:111:f400:fe16::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02c24cf1-d210-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 13:09:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8138.eurprd04.prod.outlook.com (2603:10a6:10:25c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 11:09:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 11:09:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02c24cf1-d210-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljSShnzZ3IkJ0ax+6+k560RKBq9aS5R/zl1756FzVn67gASBQETSN3J7r2e+zFBxCd+wxnYkIglWd2OThtXynLq7UYnrV1rY8775syZYQ+aS/i8hzLBXJNNWp95rIg39vrO8JPaEUAdRryHapFka8YFabs1rPeA0cpxlnYLW/9jyE7AxI8vMjnAhYBqYeoTG/mATEovuAX+IUclidYAdcLq/ANU3OpQd3JRqWruugAY8TVGd7HUoaFkEom3hd0MvtPIGnx/SYxidbig5ZPxilZobIaExKKEG4ItF629K+xbIHNSSDs1HCo6CQaFe9lSt0Q9k0xaKmpUt8tpgLEf8Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lh3DidjN6ele/jYXeFN/8iuMc38l5BJIsPtFgZxHUNk=; b=SWmsI1ck1hdMvxKjKoxdQvC5X6Tg9ZVpzgqkep0bCW0vvgmSdVDWRFoRlMpvfSBg3/z5euJVsH4YvwTF9jQshlMQS+8Z3Y0/DAJLTXcskgZh7ye/nHO9vZR9Y/kxqP/1ZE4tjdamL/z1NBlCbyJSn0N31Vg1GnRlYP/v1xJTKFZqSm7SDoEI0r8aO1pmaKth3b2cbeSc5Dx0UF2SEPJd1RIEI2dNKzgufEMnmTmwT86vFWIA3tWRpUDVjjLL7eQ4MVJknG6f0AchakX5wuY1c+Qkl+C72gOMkn50KTvgIEOrYEa7D7QrGAYmNFwlXdkeB649kzUsq4s3vFydtAvgVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lh3DidjN6ele/jYXeFN/8iuMc38l5BJIsPtFgZxHUNk=; b=PZG4a3XwCqHLcxXBY553XoTiCUgxN4C0r+2zBigjPE831erZH5pR4+sbuh3KBKQaMTAoA/E+Cnaimq8Dmx6yX9cl63Q8wfOZrB7B0t1tLg1smYth4icrutfa7Luhd/dOyHFbyYYODiyChgWIyfGvUHER3qUpG2V8+pxqjbRZ5kHATcDVgTcYYCKa9VBQ1hR88Da5ur6vAaaVuYs9lMzz2TvlDYnJ2g6GAGcHGqaIK7nqCSj3FUzrRxkJzJ6a9nP7QvVZGsXBxExufZol/0waDemXAP55FtloWK7pP5iEVj4OgvS1iic3ZuZyCB+zGtGp0tcRTinaB3+AuTpzKON2jw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <245d1a4d-3bdc-21e3-8ee8-2909d6fe7b60@suse.com> Date: Mon, 3 Apr 2023 13:09:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel@lists.xenproject.org, Jason Andryuk , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20230325024924.882883-1-marmarek@invisiblethingslab.com> <20230325024924.882883-2-marmarek@invisiblethingslab.com> <540906f7-4543-9d01-2b2b-a3bd70eda74b@suse.com> <9eb7b538-4074-4b15-4ea2-67d9cc0bf85d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8138:EE_ X-MS-Office365-Filtering-Correlation-Id: 6181ff65-045b-4173-8cbc-08db3433e5fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H1aHl4xkdWyX0+OhLb4OWAbIvhV8yZgq9IVd7OfwGTjNiJ6FmTIGK13kNdyE6QsnGxQ0fDjabnRcy3VNICeTtcENmGhbyTaEE9NeDn76mwWAMnbK51SDqS0lAqasR8IyuouSgOA7RyxfM1wXo4cAKK0/Y8oNTngFOI/LomHbsCcBBURKbyOscdcTTw1cHVRNa5RjxugeX1fy5QDv5Wv6u9xGiQwwkfwQQ0QRwTa/5JTqSgUIxM/HWI3zwz6OP4ksLh9do1Wjcs7HWD6sllTdWvFID8lJJKw1Ox2fHNelWj4h4lrDBKi2FM60/8poFhCxG1qukr75Uo/EZXxqxbnTAiqTu0e8WOY46GGQLbEqf53q3pN7ZmDJ1iUES7SRvB8YKk6z9DZ/W8/WpXXyYJsjtvWBa4odGZ0MpMu2w983BjlOcXFzey8eFWCEktE5MBxo+nzueCWkSXL+oy33tVhOSF4KGRYN+bA2hjQpq2OnUdhzBxPm4exe4dz8D61XpYYqP7jAwYnZKAADpoeJVgimbPjtIm/ru0wU6211v5IhZWLaUglP3/wEFpIq3YpxOsRHkJPf8u9enVqkXudepxCntkML29j8mA/fb9VNq93UxySDqyyQiRSlHJ3e11+evXpy2d4KbhZrIFY5x6tRcQWpfw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199021)(38100700002)(5660300002)(66574015)(31696002)(2616005)(83380400001)(54906003)(316002)(6486002)(186003)(478600001)(53546011)(86362001)(6512007)(6506007)(26005)(41300700001)(36756003)(4326008)(8676002)(6916009)(66476007)(8936002)(66556008)(66946007)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yll5SjBuZFE5aHduaTR1OS9ObUF1OTlaUVJUWmJuV0ZseGVOaTIwZU94NjJG?= =?utf-8?B?eEFqelVxd0lmOEhId2Iwb25JaHVQYW5VM3NhcERQZTZOUHZtRzdPeVlzNDlM?= =?utf-8?B?ZWFIbFo2QWFEZWJ3ZktYQjNpTCs3T2dtWks2aHlYeGYxd1dTWENvaGNLZlN3?= =?utf-8?B?dkpXeVNLbWVhKzk2dHR4T1BsOGl0Y0JHam5zVWFRQS9pcThkK2RieG5QQmlh?= =?utf-8?B?VVQ3VFIxNlh0ekJyczhhcVVSSUtDK21ZSE1NNEUxREhYK2gxMXBpZ3ZWcHBy?= =?utf-8?B?MUNRU0NuYnJtMmluRFNvdmZKU1RUcCtIOTZNTUFRTk43TVBTcFo3UWNLV3NI?= =?utf-8?B?SS91UzhuSlRaSGlFU1ppaDRqZ0MvQW5hZVp2Nmk2a05tVjJiZkJCRU5nTVRI?= =?utf-8?B?a1ozckVRMnpSMVlQL3BrcVE5T3VpQkdHbWNJZ0ZQNHVMTnZKOWZOT3k1T2ZX?= =?utf-8?B?NHRHTjhaeThobVRFVUQvNEJkRHNidUFqemxWekpRZ1g4akw1OXlsYWE3M3lu?= =?utf-8?B?L2RKQTU1ZjRIa2NqMlRjbk9PZWlQc3BoNDF5RzMwalZsZE14Zi9PdUt0N0pi?= =?utf-8?B?SjVpME9xZHpmejVxU3hjbkdjQXB3aVdXTFMzbm9iempVYjQ5Tm5LSHJFTjB3?= =?utf-8?B?QU96WEhvSEo1aC9XbTlvQU9WTXUrbmN5NURKbUVJditrWTRKaVc3Y1RPUnVz?= =?utf-8?B?Q1ZLVm5zMUV1eFZiK2RzRWRMNnZkSnZlVy9LUTdpbWt4bDZrMjZ3NHBJaCt0?= =?utf-8?B?T1lpYnZlUWd4VHJuaGtPQjR6VWtxcU95azlPUjNMOUVQcGVuelhQSG95bThT?= =?utf-8?B?eDArUkVqei9iWlNSWmxzZkc4Mk5abEJBSnFVemFhcjhhdktTNGFHSnZyUkpT?= =?utf-8?B?eXIyMWhSTGpaMURZdlNaTUlKQ0ZnRDRPMUR4bHVKUklzSVRpUUJxWlhTbmFD?= =?utf-8?B?K2xha1hMUzlxSGNROGVXVlN1REpjem1GSFU3VllSRFdESkRJd3QwQzZuN3B4?= =?utf-8?B?LzdhSVVzc2poT1htTmtRNzVORTdrUTlyNFp3ZE0vM2tiRVppYkJKY210WmNY?= =?utf-8?B?eWJoRThPY2ZBVzlDeHF6NzVsRUdtQ1ZyZWFqeGlNYlFWNnNxUFZqcFVqc2pB?= =?utf-8?B?UlVxbisyTGxueGxiMGZHeDRQcjh5ZVVPc3RjbCtpQ2RFYy83bmxtSWtCaHUz?= =?utf-8?B?YjI0NWwyZVF3NTM3aGNWSGowdmFvTHBrRktZVkVDejczUEUwcFA2MFVoL2Nw?= =?utf-8?B?MVJoa2lFVlBCczR6Q2RrTGpkbWIrcjFWSHc5RjFpZklrUWt6MFBKTlNud2FR?= =?utf-8?B?LzVSS0RORGxsYzdaK3VQbGZiSTdHWmFIV0JnZWVyUDVwZ1U1TkdMT2hoTGJT?= =?utf-8?B?TDRPYlVIL2plbnQ0OGozTVZyZ2ZNdGMwWmpoRUpwL2pxcjFIZzhCbktaZ3NU?= =?utf-8?B?blduVk5vSTlWbEZHdXZnN1FKdWJxM1NSc29OUkJJRE9qazJHR2NaK3IrZFZV?= =?utf-8?B?elF3WDkzTVNPOVdrTWIwbldiVG5qcDMvQ3VvMzNWOE1udmsrcU5VU2ljSmVh?= =?utf-8?B?dHlKWlJaTFVZU1l6SkRoUGNadmVha1NYYkpCZjVleVJMZW8wN0Z2cjlNRVow?= =?utf-8?B?SW96UHhCQjAvblNnSmpGQklMKzZsR1JScDdxN1pMaEZ0dnN0cUg1ckN5b2FM?= =?utf-8?B?MTNVT0ZiZTg4MDJKUE5Yc0w3c3pvdVkrR2MyWTRYekd6SlRzS3p3RGpjSnpP?= =?utf-8?B?bnpNMG9WSFhKZ25MU2wraDRmWXR0Q0MxUmhlcDNjWFk5cVg4SW1RamFmSXA0?= =?utf-8?B?ZHNCZGJzYW5kTFpJWmxsVGZaNVZST3J6MDBJRjZ6enRZWldrQURWSTNYOExP?= =?utf-8?B?SXV2NHU4c3hSZmZtYVRRNGRpL2MvYm5qalluZG5zSTk3Tk9BdDR1aGRJYy92?= =?utf-8?B?VWoveUZpc3lvZnJMbGh1ckdWSmplNGljUVlYSnVjSlZwTlZoMTVKMmlFV05W?= =?utf-8?B?YXpDc1dDcVNBNFRFdVZJQnRMN2ZEZitXMktLUHhPR1gvU09MU2JhcjF3VVZR?= =?utf-8?B?VmpPd2VqQlhuUkdLK2s5RWRqZDBaNkFzTkduU0VUWHJvaFg1bVlpY1Y4Nm1a?= =?utf-8?Q?FKxjDwUFQaHqi1yie8dmYngBZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6181ff65-045b-4173-8cbc-08db3433e5fa X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:09:31.0652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m2Rj1ktJftMK6t7ODOcttf7WEBzgi5PHJ/SXgorruGiZI+qkNXH+sz6F0Ak2pyIgVb4rZSZzDrLKjk4gxrsdnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8138 On 03.04.2023 06:21, Marek Marczykowski-Górecki wrote: > On Tue, Mar 28, 2023 at 03:03:17PM +0200, Jan Beulich wrote: >> On 28.03.2023 14:52, Marek Marczykowski-Górecki wrote: >>> I mean, technically I can probably merge those two handlers together, >>> but I don't think it will result in nicer code. Especially since the >>> general direction is to abandon split of MSI-X table access handling >>> between Xen and QEMU and go with just QEMU doing it, hopefully at some >>> point not needing msixtbl_mmio_ops anymore (but still needing the one >>> for adjacent accesses). >> >> Hmm, at this point I'm not convinced of this plan. Instead I was hoping >> that once vPCI properly supports PVH DomU-s, we may also be able to make >> use of it for HVM, delegating less to qemu rather than more. > > In that case, this code won't be needed anymore, which will also make > this handler unnecessary. > > Anyway, I tried to merge this handling into existing handlers and the > resulting patch is slightly bigger, so it doesn't seem to avoid any > duplication. The only benefit I can think of is avoiding iterating > msixtbl_list twice (for respective accept callbacks) on each access. Is > it worth a bit more complicated handlers? Well, limiting duplication (if possible) is only one aspect. Again referring to Roger's functionally similar vPCI work, an important (from my pov) aspect is to avoid consuming another handler slot (via a new call to hvm_next_io_handler()). Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:27:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517391.802634 (Exim 4.92) (envelope-from ) id 1pjIKo-0001DK-Om; Mon, 03 Apr 2023 11:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517391.802634; Mon, 03 Apr 2023 11:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIKo-0001DD-JW; Mon, 03 Apr 2023 11:26:50 +0000 Received: by outflank-mailman (input) for mailman id 517391; Mon, 03 Apr 2023 11:26:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIKn-0001D7-4O for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:26:49 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20631.outbound.protection.outlook.com [2a01:111:f400:fe1a::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a376de6-d212-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 13:26:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8199.eurprd04.prod.outlook.com (2603:10a6:20b:3f6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 11:26:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 11:26:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a376de6-d212-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+hdoDww5qWu7/IpzNtygOSq9A5/NQ1j0WN3va4/nUtqo+qscEVXYo/l5MkAqg9mAq2tlp0ABwyn7g+k5OOgilMTXD9mHvf0hC6e6YJFLTyriFEY87MxvReUexsowPb2ON7RgCuVxrnPDHGOpPhQqlXgz3h10Du5yFcWRv9Yv3Yr13L75zXyl+UX1oJIkLSQI8F40QliD06/nTHB2jnHYVF0eLszK5LiZIXtexdxMRb8T8h2AUp7RqRhwMVj77kdNsYgfQfuUREskXUJcYIBxNVPf3SGQ9dbpqvyEsc9jcM/eTbr7qBtLCk+sVspm/LyVEFlPvyr6Tb3mQJlSeuXJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L8q0afLa22hTjaRnK3m9EodQhb1yTAjxZx4IUbIHkaM=; b=GZZLp0wclcMIbZpiCGr00m8ELQES7QzUVvGnPkA/f7/ORbO2eahMJkTnazvPYBBPjhVdrQ19Ux7gRjwfR5FBVK490brdhqbZ73tOiPCYjDf48Ji7aNWtfTlQYcdw9uGU7JZHXgKOrxzcU3kpK2E/N+YJyqsOVvjLlXkksiHy/BZ1JkaGEN03ekhcm92pvB+KMZJeUdkO9Or8CZ+9NByBRg1/wUCAEqWnx8dCHUHiqJA8k5UQK+7ZdwRzW1j6NBjk4GAbF3b70FDsHCXcT2Rewy0tIe6vSeuyaqmZQXOJRCTT+itjCgdMA5YDJ6zC9W2xlCUqcW/3Wkq8K5PLklY65A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L8q0afLa22hTjaRnK3m9EodQhb1yTAjxZx4IUbIHkaM=; b=IZxR0y3YHXIJpSLbODqGMcs4WvelFlgm1crboySZnhSlV2I/zZC8Xh3os2bfxkKSiHMTDuF6M4FHHMyQ2OOA4GAWei/cA5iKmbNaQe/44aE4HTVepqA40PRZEGF1t0dF+plgtLrtAvacgYpVi5ZFERHhpF0IDCO6qrcT4u7I/DmsxGCU1IEokBTnubVHwcdnD5DCkUrl3OtD5aEhOEaE4lZ34vWr5GkkysA21OI7yjTn6c18jAmrq8tOKBJTVwcVS1j4YMgHAwPe3+so4Znx82BRWjA6vprN5WeVvZH9BbjVzBpZOiLekFoxi6+ziwMz67zO/26Fxop49cD3Xs3vrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 13:26:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5] x86: detect CMOS aliasing on ports other than 0x70/0x71 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <5426dd6f-50cd-dc23-5c6b-0ab631d98d38@suse.com> <8f2fa47d-89b7-b39c-e60f-edee1de5ca82@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8199:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d89e8ec-6986-410e-9c1c-08db34364d1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iGa+gFBuan6KwoxqIjLD07BUMtvuyypTCL3f28CUB9ZH1u4m+BMNsN+xJYlO5tDSmli+ZsAkdRFT5b1hpzeKq8toHJXSFSmRmmMpfJFDxW3hnehR4pIn3lcs/FPhtp106/4HeNUNvM0wlBCoBLU54Y+t/rfYXmVlgHIsNT75i4Tz0WqZyKTW4mi0q0BlKCMBCYrcFbyc7lu6QjYIhQMM5R7KyOy+yt8IAvqLInyrbnfCaopLYfKtBMwO4O02uiMGCu4yEyc03XrnGguRIahqkvUzqpZpcCbjIpCj7eSvoCKFDvdSiO6KVvqwqChWngbna9d1m1O+G7P9/tT75RaV9NGDPVPHvr2ZUoDMg8lK5HI1aWMwPkApzXVOZeW+/MgKyppbzR3a8jnmJnQUDiWkqe6c5P8XPLoZwbkCtanD8QcS3uZ+YDQUBOfpoVF8vXuXTd5gSGn1WTddK/4I8RVT8yOxCL+Pt7q3RZ3R/sitL8FrbFuDDsbHhOnmHwhuTH1I/jHlG9h1LZjc83WZH3cj4XLeIoYZQHCWD9JcQlXHpcB5Vsq+yW1w811xIQmshJpnm3mt2s0V0AW2RpINYn3GQeKNItj5UA5bifkhEFQQ8XBF8uQ93BBW5/lN58sgSH/31FrSjupehoRE6YqH8ssbCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199021)(8676002)(6916009)(66556008)(66476007)(66946007)(54906003)(316002)(478600001)(8936002)(41300700001)(5660300002)(38100700002)(4326008)(53546011)(186003)(83380400001)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUtQKzlXVUZEb3hVTUtCUTVVTE4rcmhxWnVxR3FFQjR2bHRBemxmVmxiQWRx?= =?utf-8?B?TFlGRGlYSTZwN0U4RkhuZWRKSzhCM2pnWTdUdFo5bCtlaWtrbWdzUlAwdkhy?= =?utf-8?B?M29nWXM2WnorMVdTWXRqUW9wbE1PNFRVTWgwdmRZZ0Y0V2preWdSdmFLczJY?= =?utf-8?B?aW9mR210V0p4V1ZLTkhsTTlxQW9OdHJTQ1ZrUWFmbFB5Mk1JQXBVdExqdmRK?= =?utf-8?B?Nlo5ZVYwcHBLa2ZMTXFYR3JFR3hYTTFPUHY2cjEyQmMwRWxZMTJFL3QzS05D?= =?utf-8?B?U2hJWmxlZVV4UHJkUnVsZmZUWSs2ZG9CcHljbXVZT3B1RGtKTFE1ZlJ2dlV0?= =?utf-8?B?dEFBZ1F3eHFIRm41V2RBTTgxQlozaXdTZ0NHbXhveStNdGQvWUtvT29pVXoz?= =?utf-8?B?bU95UXdxUnNBZU9sa0M3bmtpU2R0bHMzdDkxNUlPajVBRldSSy9pV1JaZ2V0?= =?utf-8?B?b0dtaTFYUU5ablFtbURMVUNGL3VDUGpZNE44WGh0ODFzaC9JVE8xWVFvQWg3?= =?utf-8?B?MkNocmRHQTM0STJQOVF2VGUvOEM0T3JrdHllMDJOVy8yT3IrRWEveXgzQWxC?= =?utf-8?B?R3crTVlUSmp0ZEdDNEd5ZDZoUTdma2tqMVpsSGhvKzVBZDhqZG9OWFpJcFU4?= =?utf-8?B?TTRvOWxDSUl4STdLVUlTbXpkc0c4Qk51V01Mc1FVYWl5TmluRkVuNWIxRDhE?= =?utf-8?B?Z2ZiN3I1R1BiblhyOUxKeU96M3RGalZZWnhhS2FLdzduOXI3QnBLUDV5dGJ2?= =?utf-8?B?S3Z4c0xZL2NFcWpCa243RUJWSmdDcWxGNlJTZEE1WEM1cm9RalhzMnBwTDBB?= =?utf-8?B?Wk8wRC9UWjFUQnVJZWs0SkM5d0tHNG5TWTBFZjBRd2N5d0VDTEdaeFFmNXds?= =?utf-8?B?U1pKTitHYWVDcWxtbTVXMVhTZ1pEcjV2bEwySms5NG9EL2d2RDRsbSt5cDB1?= =?utf-8?B?M05UM1RPd0RoRmRqNXNWdXY2M3pBRk11SS9GaUdIaGZQTjR5MkZyTklISzhn?= =?utf-8?B?UHpoOHpjQmRmQjZGNUdhTHJFT2VWSWl4ZVZzbTlldGhsd1JOV0Q4TjFENG9K?= =?utf-8?B?RHFCdTNEaUMzU1pSZElJQkZzdTJhRDRWVHRmbXl3VndnT0ZlZ3ZBbVBSL1kv?= =?utf-8?B?U3JhNXM4d0k2RThiL3VhM05lb1RVOXprSy85bE40OThPTXV6ZnRMKzBNNlp1?= =?utf-8?B?ZlZOWXZBRzlKWktUVU54aVh0L0FSV1B4L3cvc1E4M1daaWJ1bEs1eExuNGhU?= =?utf-8?B?NUZxK2x1ZERaQ1ZvbHY4TUdFOWdFOFJiWGo3NXJWeVVqT0grdnBNSEs3QkVW?= =?utf-8?B?RjQ3c2ZNeXZ3aG05QUxSVEVxaUtsWWJaR2JJaHFjbXp1TzlYbVNFOHBVR1kv?= =?utf-8?B?V0hta2M5U3VYbnFZMFBrcFJpK1BhbTVJTFFNK2U0R2hveDhIVUwya0FpektC?= =?utf-8?B?cWlDYXdvclgyakp3WnE0SmhXcU5nK3NTcml1LzF0OUk1Uzl0OE43MWQ1YjVh?= =?utf-8?B?V1hLdGFKSXVTMVh1cEdXME4wdGlmZHJBUUVsbldta3dHUTh2R3Vtczg1VVJh?= =?utf-8?B?NlgwRXBHcEhnSi9maUhydHZDbFUrcERqS21tbmo0WXlHZmVTSC83SURCWWlv?= =?utf-8?B?aWFrenFLTm5ZQ3QwME9jVnhvVkU2RzNxZk81cWRIUHJINEg3bzdWM1JXWkJO?= =?utf-8?B?dm9LVmJmdllxUXIwTGxtRzRQM2VxSldlMTdzOXBHMy84d1B3YkVsWFVjU1RL?= =?utf-8?B?aTFFdU5Fa1ppTHdOT2FnU1FpMkEwOUZHMW92VkxLVk1vcVVZZjNlT2s1dTVO?= =?utf-8?B?VWJlenpzbTlEWW9ZTVBwVVNQQ2JQcktObU1iUTAzbWxiSEJwdXFDZ1A4N09q?= =?utf-8?B?YXI0ZTU4Nlo2Ym9Gd0lOSU1VOTlpZ0k1QnhGb2dWWVVlWktVWGQ4Q1hRb2dQ?= =?utf-8?B?MnJRQ29vdi9lbXlIcWg0R00wb2ZESFFUZTIyd1JtVGloM3R6QmxKMWdJNDQz?= =?utf-8?B?M1BPM0FFSngvSU8vR3ZET0NtWVI1aW5tZk9kSER1RlhKSXJQaEVMTWd1ejNk?= =?utf-8?B?aDUxTTdTTW5xbFlRMjJmMEw5R1lEQ0ZKSk56Z1k3MnNJbFNKNVo4Q0Z1WGY3?= =?utf-8?Q?mI6eHeHor+E2V67KVEXhLSmak?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d89e8ec-6986-410e-9c1c-08db34364d1d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:26:43.1181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LOECWLr8hShqeiNXC7KvpCn9/n/lqF44JenNROx9YJ/XcvM4XgaQ0T9r9D3ZdLr0rUwfdoDZm4o1aYeEu75crQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8199 On 03.04.2023 13:09, Roger Pau Monné wrote: > On Thu, Mar 30, 2023 at 12:40:38PM +0200, Jan Beulich wrote: >> ... in order to also intercept Dom0 accesses through the alias ports. >> >> Also stop intercepting accesses to the CMOS ports if we won't ourselves >> use the CMOS RTC, because of there being none. > > So it's fine for dom0 to switch off NMIs if Xen isn't using the RTC? > Seems like a weird side-effect of Xen not using the RTC (seeing as we > would otherwise mask bit 8 from dom0 RTC accesses). I haven't been able to find documentation on this single bit in the absence of RTC / CMOS. > Also I'm worried that when Xen doesn't intercept RTC ports accesses > from dom0 could be interrupted for example by the vCPU being scheduled > out, so a vCPU might perform a write to the index port, and be > scheduled out, leaving the RTC in an undefined state. I did specifically add "because of there being none" to the sentence to clarify in which case we avoid intercepting. > I've read claims online that the RTC is not reset by the firmware, and > since it has a battery the state is kept across reboots, so > interrupting an access like that cold leave the RTC in a broken state > across reboots. I can easily imagine such firmware exists. >> @@ -836,10 +836,18 @@ void rtc_init(struct domain *d) >> >> if ( !has_vrtc(d) ) >> { >> - if ( is_hardware_domain(d) ) >> - /* Hardware domain gets mediated access to the physical RTC. */ >> - register_portio_handler(d, RTC_PORT(0), 2, hw_rtc_io); >> - return; >> + unsigned int port; >> + >> + if ( !is_hardware_domain(d) ) >> + return; >> + >> + /* >> + * Hardware domain gets mediated access to the physical RTC/CMOS (of >> + * course unless we don't use it ourselves, for there being none). >> + */ >> + for ( port = RTC_PORT(0); port < RTC_PORT(0) + 0x10; port += 2 ) >> + if ( is_cmos_port(port, 2, d) ) >> + register_portio_handler(d, port, 2, hw_rtc_io); > > You seem to have dropped a return from here, as for PVH dom0 the > initialization below shouldn't be done. Oh, indeed, thanks for spotting. (The excess init is benign afaict, but I still shouldn't have dropped that "return".) >> @@ -1249,6 +1252,77 @@ static unsigned long get_cmos_time(void) >> return mktime(rtc.year, rtc.mon, rtc.day, rtc.hour, rtc.min, rtc.sec); >> } >> >> +static unsigned int __ro_after_init cmos_alias_mask; >> + >> +static int __init cf_check probe_cmos_alias(void) >> +{ >> + unsigned int offs; >> + >> + if ( acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC ) >> + return 0; >> + >> + for ( offs = 2; offs < 8; offs <<= 1 ) >> + { >> + unsigned int i; >> + bool read = true; >> + >> + for ( i = RTC_REG_D + 1; i < 0x80; ++i ) >> + { >> + uint8_t normal, alt; >> + unsigned long flags; >> + >> + if ( i == acpi_gbl_FADT.century ) >> + continue; >> + >> + spin_lock_irqsave(&rtc_lock, flags); >> + >> + normal = CMOS_READ(i); >> + if ( inb(RTC_PORT(offs)) != i ) >> + read = false; >> + >> + alt = inb(RTC_PORT(offs + 1)); >> + >> + spin_unlock_irqrestore(&rtc_lock, flags); >> + >> + if ( normal != alt ) >> + break; >> + >> + process_pending_softirqs(); >> + } >> + if ( i == 0x80 ) >> + { >> + cmos_alias_mask |= offs; >> + printk(XENLOG_INFO "CMOS aliased at %02x, index %s\n", >> + RTC_PORT(offs), read ? "r/w" : "w/o"); > > I would consider making this a DEBUG message, not sure it's that > useful for a normal end user, and printing to the console can be slow. Can do, sure. >> +bool is_cmos_port(unsigned int port, unsigned int bytes, const struct domain *d) >> +{ >> + unsigned int offs; >> + >> + if ( !is_hardware_domain(d) || >> + !(acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) ) >> + return port <= RTC_PORT(1) && port + bytes > RTC_PORT(0); >> + >> + if ( acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC ) >> + return false; >> + >> + for ( offs = 2; offs <= cmos_alias_mask; offs <<= 1 ) >> + { >> + if ( !(offs & cmos_alias_mask) ) >> + continue; >> + if ( port <= RTC_PORT(offs | 1) && port + bytes > RTC_PORT(offs) ) >> + return true; >> + } > > Maybe I'm confused, but doesn't this loop start at RTC_PORT(2), and > hence you need to check for the RTC_PORT(0,1) pair outside of the > loop? The loop starts at offset 2, yes, but see the initial if() in the function. Or at least I thought I got that right, but it looks like I didn't (failed attempt to try to address a specific request of yours, iirc). >> @@ -1256,23 +1330,25 @@ unsigned int rtc_guest_read(unsigned int >> unsigned long flags; >> unsigned int data = ~0; >> >> - switch ( port ) >> + switch ( port & ~cmos_alias_mask ) > > Given that the call is gated with is_cmos_port() it would be clearer > to just use RTC_PORT(1) as the mask here IMO. Hmm, personally I wouldn't consider RTC_PORT(1) to be reasonable to use as a mask (even if technically it would be okay). Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:44:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517396.802643 (Exim 4.92) (envelope-from ) id 1pjIbv-0003ZO-6g; Mon, 03 Apr 2023 11:44:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517396.802643; Mon, 03 Apr 2023 11:44:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIbv-0003ZH-3i; Mon, 03 Apr 2023 11:44:31 +0000 Received: by outflank-mailman (input) for mailman id 517396; Mon, 03 Apr 2023 11:44:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIbt-0003ZB-IY for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:44:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2224a1c-d214-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 13:44:27 +0200 (CEST) Received: from mail-sn1nam02lp2047.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 07:44:16 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5853.namprd03.prod.outlook.com (2603:10b6:a03:2d0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.34; Mon, 3 Apr 2023 11:44:10 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 11:44:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2224a1c-d214-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680522267; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=MgN5akSc15Gle+v7aSaA+1Daes50i5XlQsd5PTdXRAQ=; b=Q4rxInMefbKne/G6v8WPWCnOLxCeY93gn4FBXjwhJXZfHeLK/bYxTTcp ENYyLq9xdo7FfDRm7J0iy9u8BOB7dlUczGHCgRbMpzrY3McASYysaWBfS 3ZNTmn9BVJl23a3ASED8DnGwnmryvTaISLT4LtS6vHn6vlqqK2Yl2+KAI k=; X-IronPort-RemoteIP: 104.47.57.47 X-IronPort-MID: 102904644 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mlhrX61UOZVmlorjE/bD5eZwkn2cJEfYwER7XKvMYLTBsI5bpzcAy DNMC22AbKuPMWXzKYh1b47i8RsOvJSAyYJhTAJppC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfC0IQ6 eQSIhUxMB3dib6d3qKmWtJwv5F2RCXrFNt3VnBI6xj8VaxjeraaBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6Pk2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv03L6XwX2nBOr+EpXgq8ZLuwS/m1ZKI14WfFXghKeGrlSHDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSRmrbm9WX+bsLCOoluaJiw9PWIEIygeQmM4D8LLpYgyilfUSI9lGavt1NntQ2msn HaNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z IronPort-HdrOrdr: A9a23:jWwQvKnUYeSkO4uI1OiHpmkKk+XpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="102904644" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFhXLTVEItfp1DLIYa3L9wwHl7QAUQCDsB8GSi+fKpdlfxMzoWWVuxfEWobem8+CWWzocq3YxWoZHOIIkAg3tv0/LB7Et4Sk6C7JaYFDY8aia+jahxueXmCI2MFR+kKE5rtvRa0UF7afZf7/PchYbUNkCPjyc3guIbGHjjY2mzarnVHVaZI/mtK9BkvY7xQyr1fMUx9I/RPXunFJcBgg91BTFB3sh6DDdqEHfawZnhUay38IwNGpKQe9IjhS8RROBUCujrOzYDLBin7Mcs5VO9Ax+jRYHrWvJcBOxMxEUHAkELZ2wIhi413kHgowlNBQxZet9bWCO4Km+Fp0hunzeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GDY6ZPt2ogBpnfv4hBUOFEYDGrLLJXxL+TTEDteGKw4=; b=dv3e76jrtr1xVHetxmjX8DlIhGNK8TEGARIPlLpGxw1dHh0UQ3/oq/fFPBtm6CyCyeVT/UZKVxDP4hJiwGgeO9vfXtph62CrlsmdbwxSBSMkT/K7vnJokg9gkBQA8Z/J18QKt+2N3lZZwrtxb/DEvcfqcd+Y8bD5OViSy3nvoySB11oMd+iVpiGEZC9uQf2ma4gy9uBp8iWr5f3TtmGu9p1pZiKs5sSKWojucshehCliMykNipCOlU7rElvR+alAdgmRAB+diwF7gDZz79UXjJ8Yq0bBptDIWVvHxj4Ux5Lz8+hnQ7sZA3ismA1DGAFt4BnLG5HCVJel/vwUEIIbMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GDY6ZPt2ogBpnfv4hBUOFEYDGrLLJXxL+TTEDteGKw4=; b=kQrVgZrGYcdEmY025Bcw/gWDriD40XJHZe44/5HdUPTmZFSj2Eoytlu7qQFVjXvCPr/v65p1AuUfJBRtoN/Y0Xa0BUsY7rnkzpj26kLWtaQIIQmpk5zmy13KXZXrej8GhznBB5EzwH5Is6wCImUxzwntTfF9QcWRmt7/s1A905Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 13:44:05 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v5] x86: detect CMOS aliasing on ports other than 0x70/0x71 Message-ID: References: <5426dd6f-50cd-dc23-5c6b-0ab631d98d38@suse.com> <8f2fa47d-89b7-b39c-e60f-edee1de5ca82@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BN0PR04CA0199.namprd04.prod.outlook.com (2603:10b6:408:e9::24) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5853:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ebf2394-e93e-4d97-9eeb-08db3438bcbd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OlPD7bVk9CGTz0PdgPTUKivu+0/DNWjjsCR3+0Qjb+OmgKkODqBktQ0G2BeBBoE+XNe2smJVj/UV3ffqLAmUh+dt7hsgMYq/Q/3fwQ/tAEWlyN2qcp8ptg3XekI3gbz2ixts8X1C/ZnA2H9f8LQHl8c8JsCtSMm0kjNHVXXsZc33HDUr4SX8WThtj9MLo7s7R0fcMJKsnF7hH3aGFMbgnweD3ixCAEf2paKkCG+36zbX6kgYGFSlO4gvPBkOs2S5p27gMkqjD9VIAqRhOecF69BKjC0EDZve2XGuuvTa9QlrVbXr5IlJmVmD/amlEr4euT23zUFXrbR69eLdUYeSxdI6MHSbTtZwn0c8fXwuHHLZ3m4W/G8F18JsUwmaHrCRLmtnolGnj/h2nNRQjuR5to6hm+vkpV4eeSEuciPdFw/kF/k7zxdpLCtQVzyQSdKAdl9sn+WMtrfFY6LxCPlDnKf5EeXqOYvXvwXYShoXjIS/FphvgXx2n3nWIzlOCUgm2v8Tv1WBKHbV2qN3H5OsOS1ko1kM5CgcrPhCzhdg8tcTatrlTSvk9pHrZatg/ww9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199021)(2906002)(38100700002)(5660300002)(82960400001)(66476007)(66946007)(66556008)(8936002)(85182001)(41300700001)(6916009)(8676002)(4326008)(54906003)(316002)(83380400001)(53546011)(86362001)(478600001)(186003)(6666004)(9686003)(6506007)(26005)(6512007)(6486002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDYzSDVZOVdHUjJXdTQ2ZW5Memh5WGN4TDNNRUJkV3BTYm9iT1R1NnhMVHBw?= =?utf-8?B?Q3loMnZEQWlETG5paWgzSFNwYXBFeEJ3dUI2L0kybHYxVjJJQ1AzaWNuQStk?= =?utf-8?B?STdaQkpQdmt5S2VmZzRXdlhxc3pUZElnajZaakt1Tm1YQXdQZUxOTUlFandi?= =?utf-8?B?eWsrdW5QMzFmbW5vaGNTUzRwSkFJNk1PVndNZnBYUkw0WkNPb0hxdmxRNmwz?= =?utf-8?B?WndKZEYyQ2RFZUNjSDc2bGEyaFhybXZhdFh3bG1zVkdSNlNVNVNZUGQ5LzBX?= =?utf-8?B?WmgzWXRSaWZYa3N1ZXRnVVRlQ0FRTVlQdHhUaWFTaTNXK1JZSGl2b1dtSUN2?= =?utf-8?B?YUdoSExBcCtQZmN4QlQ2NnRPSGRUV1c0WWlkZ3hBYytaUWhNVGFXbFQvVi9G?= =?utf-8?B?R3BLSTc5WUM4MTJvSnBiSnVndTNvTEdkb05KNnQ5bnhycUJjbGpvOFNGbzQx?= =?utf-8?B?d0V1OWVPR3M4V1FoU1FmSEJjSUZyZHkzYzQ1aXlUWmowZEV0cFBoMFZWb0hk?= =?utf-8?B?b09MUWg1UU5OVFI3cnJFQWJLVE12Y2Y2bGdueWtJMEE5cG9saUtMR3hkSjd5?= =?utf-8?B?WE5CRUpMNnovclVhbmVqWjJidmd6WjRGL2FIQis0YkE5WmI5MTJoTktOVUho?= =?utf-8?B?VjViZGJJSjlPM1BMNmNKTVFjb2FsMDYvcWVNWXJERVBYSEs3Nzk3NWhybjVm?= =?utf-8?B?dTBySFY0eDNhYXg2L0Z5VVdBeFp2OWhLeXlWZUxwUnJEdTVmZ1lldVFNbzNh?= =?utf-8?B?K3NHZjZqcjdjK0wzMEp2Y2V3My9DQWx5STJFcjFqVEw1NFdNVndRZXNpNGhP?= =?utf-8?B?Q3BEQnliSFN0dm1IOVBTbnlYeXc0TVJSTkdXVENiMVcxUHhxZ3lVL1BOaGxQ?= =?utf-8?B?RWh1MXdZWUcwNjIxeWxTeG5sRGY0ZUpZZkJIUndvTU5pVFh6UzNIbEUvdllj?= =?utf-8?B?bUpxdkt2cFB1VVhDMnI5QUdqakF0Sjl5K0hUSlN0Sy8wc3RXZkpiVXo2UHNG?= =?utf-8?B?SVNURTAwYXh6VlpidDdjWlExRzAydVN6NHkzaVFJNGJEc0V0U1hoYlJhWitq?= =?utf-8?B?V1crczBqeEE3UzA1d0pTZlJCMGRNOGYrZ0RwRmJFNDJiMjl2STRyMi9nVGJ2?= =?utf-8?B?SWZaaUMxNUdSZkVZcEdjMUJYdjloK2ZVbG0wbkh1TUo5RExOY0VWT1FQUFVa?= =?utf-8?B?dmo0cjllN3BxdjJlMVNrZ2VDMWp6Q2xHUHd4d0dickUxZlRnbUZmYUpLUU9h?= =?utf-8?B?N1lGTVMxNkZROGRScUlvZXE5TkJsaWlhd2xJeGdIZDE4WmorT2k3ZE10YWxJ?= =?utf-8?B?MzBxQnREeVp5clFCTUo1Nlh2cURma3puK1Q1dGVZVm12THUyRGJVLy93RkNr?= =?utf-8?B?RlYzcnJXczIyUEM2R3JzREViTlVLS2FwUEJJU0I3TVM3d0J2N3pUdFdQOFg0?= =?utf-8?B?VlJkUjJ4QlFTS2hPQ295Vk1PWFlQb3BmLzM4amU1dnU5bXBjcVV2L1dEYVhO?= =?utf-8?B?WEF0NnE0OXNtRzlrQ3JHYVN2cklHSVBwb2NrK3F3eWI0elBYYmJXR00vL1lm?= =?utf-8?B?dFdvQTVqdC9pMGtjZGtVL01lTUcvRU9ZU2RoZXh6SVRuOUt4N3lJTy9kem1i?= =?utf-8?B?MWtoaWt4cWdNYitDWFNUZmdnb0xpWGZURTcwMW51MEtBNUVGZWVScWhYYUZW?= =?utf-8?B?NDRudGg3SjFndWkzdUpXaUtCNWFETDV1b0czMWZ2OEhjZ081UVo0a01sOUx1?= =?utf-8?B?ekFVb1c5UHlWS3V6RkNheDJoVFlYOU9WN3hNdEtHWE9adWo0Nlo4NDA0YUtY?= =?utf-8?B?T1RacEQvem1GWkpScGgrU2pOZ2pjSkYvRXFnRlUzc2NyZVhYdDZuZUpyWlE0?= =?utf-8?B?UisrOHBDODRDODVFVFhpSWVNUkZqZ3k1cWduTCtYQ0ROMlpGZGt2SEk0QlZi?= =?utf-8?B?MDdyTWFYdUF3QTNyOGdFcXNXNGRhd3JqbWJMZjdwVWUxSTlyUy9pdGpIaUNu?= =?utf-8?B?c25rdHBBRkN6aklKNnRkemtLeENQcjQ4TmczQlhObERnTjRDbGxhcm8rNHVo?= =?utf-8?B?MjJmcktnWXpxdHdTVy96a0liWEtkSlhTTldFY3hleW9Wa09aQzNPcE5EMzcr?= =?utf-8?B?dHNGTjRTclIrQ1A3d0p2VC9JRU16N0JtUVYxTHBMam1oU1lCVVRUTHpQempB?= =?utf-8?B?VkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7Sma2PuAt8zP0CMrLo3bsg1YXKOKxKB1RjgDg7olFq4qPSTtPk2jukpjP2Jj2OGBhy4/l6xASaWGX0/Mbk/TGRtqbSPsP+NZSmX7KiNdOHNhJ+sFnLBMpghGVKxMFtHivm6l2HLYtZwRXVe8OgcxTzdKr9JXjdbv2irFUCrGNfGoj6mkkAacVRhGPd7mzdVBUCvstNFELVfmJKvloxCDx9pwVCcTVSaecY0rAxXJtxSt4AoUScn7aZVlnRPPZFw5LUybt3XcwVIiGXM7v1raUPtLv4NXiwu9UrPsDi7qglNXfuAM5uXbqf8xXtEmrjRlEF6yiSEnIATyBxa7jvUAf3pngEavChupMVLei5Cu6zqe0nPiljva5i8K1irkIQvLRiE7EEfmVlwc9HXmShGFmS4++lBqGqg/jO11vPH+JCyS83zBciM/isaymJGB4Jutb9fn/1DAtnaYvOX5GopVrAnd8WCOpTqdpPUfb2hzm5opF6Y54K2ElSXtTaS58u2INy0Jn/RLPMS9jvazm//UcfWWAwsGZ6yhfzhSB925je7h3cZnGgKd/dOlOPghjVlFYLgsMmN2itw7Q5x5IyqPldztjFzLoHqPsBihT1y+lv+0j6HlCVnM/7jgCybPoKrKp3r608mn8GN7i9mjJi2HqnKQpPUYNukQrLT8iz0ScqDgDSAnIYVZ9trR/SE6yTEjfOJowrGiNKpSrAXKrxh4d+nxBHQoRkfFf1RduPjkkhAfLBh9jph129kBug+BZ5k70HMFOgxkfv63ceuDpfm2v6FQsHxRByElpvIGXUAsPxBF56OKHGiCVdBNsVRmAki1 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ebf2394-e93e-4d97-9eeb-08db3438bcbd X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:44:09.6857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nxlWr4DejAlde6ieUF2PEt9AYfDnb11Gi4IY6dT/6+nR1zEkup4ccgeYKzR7hfFHXpLO+VTuHG0T7sWHN5lmGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5853 On Mon, Apr 03, 2023 at 01:26:41PM +0200, Jan Beulich wrote: > On 03.04.2023 13:09, Roger Pau Monné wrote: > > On Thu, Mar 30, 2023 at 12:40:38PM +0200, Jan Beulich wrote: > >> ... in order to also intercept Dom0 accesses through the alias ports. > >> > >> Also stop intercepting accesses to the CMOS ports if we won't ourselves > >> use the CMOS RTC, because of there being none. > > > > So it's fine for dom0 to switch off NMIs if Xen isn't using the RTC? > > Seems like a weird side-effect of Xen not using the RTC (seeing as we > > would otherwise mask bit 8 from dom0 RTC accesses). > > I haven't been able to find documentation on this single bit in the > absence of RTC / CMOS. > > > Also I'm worried that when Xen doesn't intercept RTC ports accesses > > from dom0 could be interrupted for example by the vCPU being scheduled > > out, so a vCPU might perform a write to the index port, and be > > scheduled out, leaving the RTC in an undefined state. > > I did specifically add "because of there being none" to the sentence > to clarify in which case we avoid intercepting. Oh, right, sorry for the fuzz, I didn't parse that last bit of the sentence. I'm fine with the current wording then. > >> +bool is_cmos_port(unsigned int port, unsigned int bytes, const struct domain *d) > >> +{ > >> + unsigned int offs; > >> + > >> + if ( !is_hardware_domain(d) || > >> + !(acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) ) > >> + return port <= RTC_PORT(1) && port + bytes > RTC_PORT(0); > >> + > >> + if ( acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC ) > >> + return false; > >> + > >> + for ( offs = 2; offs <= cmos_alias_mask; offs <<= 1 ) > >> + { > >> + if ( !(offs & cmos_alias_mask) ) > >> + continue; > >> + if ( port <= RTC_PORT(offs | 1) && port + bytes > RTC_PORT(offs) ) > >> + return true; > >> + } > > > > Maybe I'm confused, but doesn't this loop start at RTC_PORT(2), and > > hence you need to check for the RTC_PORT(0,1) pair outside of the > > loop? > > The loop starts at offset 2, yes, but see the initial if() in the > function. Or at least I thought I got that right, but it looks like > I didn't (failed attempt to try to address a specific request of > yours, iirc). Hm, doesn't that first if() cause that on all systems with an RTC only PORTS(0,1) are allowed? > >> @@ -1256,23 +1330,25 @@ unsigned int rtc_guest_read(unsigned int > >> unsigned long flags; > >> unsigned int data = ~0; > >> > >> - switch ( port ) > >> + switch ( port & ~cmos_alias_mask ) > > > > Given that the call is gated with is_cmos_port() it would be clearer > > to just use RTC_PORT(1) as the mask here IMO. > > Hmm, personally I wouldn't consider RTC_PORT(1) to be reasonable to > use as a mask (even if technically it would be okay). OK, never mind then. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:47:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:47:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517400.802652 (Exim 4.92) (envelope-from ) id 1pjIev-0004Cx-Ok; Mon, 03 Apr 2023 11:47:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517400.802652; Mon, 03 Apr 2023 11:47:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIev-0004Cq-M2; Mon, 03 Apr 2023 11:47:37 +0000 Received: by outflank-mailman (input) for mailman id 517400; Mon, 03 Apr 2023 11:47:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIeu-0004Ck-JJ for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:47:36 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51eaa262-d215-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 13:47:34 +0200 (CEST) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 07:47:31 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5587.namprd03.prod.outlook.com (2603:10b6:208:286::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.29; Mon, 3 Apr 2023 11:47:26 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 11:47:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51eaa262-d215-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680522454; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=jbn2uUVXb8yvO1/Rrdgb6/z7tAWkyGsVebJ70PfjtWA=; b=LbZAAEIwKDWIzIAbawhY+/5Q7lzk0f2t7H6Yh+bu9FRj31sg8ybhZ30f 0CSotnS5HPnZJH2oTrPiNDhK7dD5yogyAoTw8DoGm+bY2WIzdoxJsZO90 tBXH6wYAhC2MhsYeUIN/K8l1UbHkvYO9Z5I4SGSfjuNtscO6/ULRH2gL+ Q=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 104026075 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hV6T8qhaHmr857Mrpjx9ZPY2X161RhEKZh0ujC45NGQN5FlHY01je htvUT3XaayCNmD8LY0kPIiy9BkE7MfUy4RkTQI5pCtkHiwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQoLXcDcjvbtdiN0ZzqRMZ8nNoMAZn0adZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGzYbI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqjBNpISuXnq5aGhnWol0hQNxwvZGKliqOYi3SQRtdUL mEtr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOluU7WDgr3 V+hhM7yCHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A79y9pog210vLVow6Tv/zicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:qixBYqxIaI8E33WQOZ3kKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="104026075" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cv+SdaD0efSUllFyIm1fqrH2hJkDwPLoWdURfEf2rUwSlRl1jAYRBD+NoZd72egVwk9oG2loiUgyt8v0f5QQGFXob8CwcHcMqIciTEASE+eFr3TIWAbigVRIJjFcinL6WDhNCtvt7CHjUR1Kb/FOPPUmwMJvzdM6lC0TWTExOtqq9yXAuZ8A8DVJnO4ES/kczs7qEiiepREJczJOOE43Ag5Tm0XUufoqFPDCFfu1KsPmhdr1Rkch1TCSxgnX3L8VTB9Y27+MSP3wNJchg2wGXBUnQQrADYztkDzvtjNGyk3TvVBxmroJRyvCsDSIaotopoLtT2POxCz057ajBcUfog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gUTWRX+psj99xXOjpkf0l7H7LRbJFTWqro20JXGXwh0=; b=RxBA+KjG10ql6TbFMFA543YsOjZ0ETl2czMIf0S32O4TknCOZzwIvuLUXEwYvUBlVpJ1oPKafwMQgZTSiw3uuDraV+Kctpnt++svQY1gDlV+xB4onPiQ+2/W26WJtLC1FqptSBh9cQx8TC4W3n5UKZWJiHndyypLmzkfVsKvZEiNbGPKq5GH7R53uwdNY/Emtar9zVry6UzVIt8V6+TNsJANhjRdNpm/g07rwAeD4SqFGLTSuccz4NjtAPsVr7UF/jyNLQPB873hsDXXhaTb9THQGtU0+wL0orZ4UzCRi5ZyGoQ1xY/r2+1+53DpU/B1+JFwVv54yfCXqJi2TtKoCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUTWRX+psj99xXOjpkf0l7H7LRbJFTWqro20JXGXwh0=; b=gfnsaE1fxGZdlDQDE4EUrlGr71Tp2+QcOaKoSv3ElfVgC9fTE/juca3RcvXkfxF4OryEVkSc7VSDqxjji0qhK4mJHBLUhDbyvpGGEMp7WJGVDWSjldVJCyD38GM8plGz3XNj0Scq0TSV9kCzm+dZqO/NfCLzrdlFqe7V0O5ipbw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 13:47:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH RFC 0/9] x86: Merge cpuid and msr policy Message-ID: References: <20230329205137.323253-1-andrew.cooper3@citrix.com> <9108a58f-da8f-14e4-de88-a7c8c8abb0f7@citrix.com> <14d8128d-6f50-99e5-ec98-366318e7be1b@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <14d8128d-6f50-99e5-ec98-366318e7be1b@citrix.com> X-ClientProxiedBy: LO4P123CA0484.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5587:EE_ X-MS-Office365-Filtering-Correlation-Id: 82571b92-0ff0-4bcd-f62f-08db343931dc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5EbbQb06vQw00GUu2B1CHxsmpSmHH9kpO4nxjb+9obaYlVoBna14vTDbM0bI0vl60XZlME+SKjqygRqIHu4stscaIRZ8WHO0mrzWjx0ebKnD5nJspF2om26CG47pt7RqqmtXo/hbB3GnB+WPW1BO295XvA7xDNaMq+R/t9Mcsr5yEz2tTzgAV31Z8G27qd0YUcZAYJc2spo9g+b4PsKfwBLjtCFq+jlG5wFzXRMCdxR70Z7DWSEgb8NYFMmY3JjrraL+ouEEIdKdavwczNl0IVPfajqCW0UUlbUF6L4UjnEh+Nm6eOe1gOc2D+uMSAPcJBoR2Psf0zXHC7mK9Zf+J+uhxj4/4pOabYUHonXo9OqYHoAWR50KiHWYPMRQu+P2i5lf77PBXMnzr/rqUQGN/Und49hMHrfiiewFJaAJu8rw3As+rdAKTMI6KOgRcy2T57fC8dGGk8wtCuAg0OfqpJC8jX9IoxVG5H4CqfQjQhYora3Q3+eqgfzGOl8LzPiXHnihc5p86fogJ8jqN+Ds3bylFGagJTXEEX0TnaiRrWXJax57CaaK2c2UkI50LO+N X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199021)(66946007)(66476007)(41300700001)(66556008)(82960400001)(4326008)(316002)(6636002)(54906003)(186003)(6666004)(26005)(6486002)(6512007)(53546011)(9686003)(6506007)(86362001)(478600001)(33716001)(85182001)(2906002)(8676002)(6862004)(8936002)(38100700002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFRMSXRHL2xLYWQ5dUFWYTN1OGtyWGdTVDBxYmZCUTA2OVFOSFlsZUY5dDRx?= =?utf-8?B?cHd1c3AwMXlwck9YS3hET01qS3YwTU9DMGRwMml1UW05YklGdDdyVWZZbVV6?= =?utf-8?B?c2xHa0NQbkZLRFl0Tk9TUExkaEYrZEZRRjA2ZGtKVXlFVnJEYlk1V0NWbVpS?= =?utf-8?B?MFVjcjBlV1BaZHppei9PNUZXWjdocjE4YnBFTmVPRmlrclV0SEFQWTRiRFRq?= =?utf-8?B?SGNiR0ZUNUZMUVdYdzJkTGpibmJtSC83Yk9UMi9TcVhFUndpbWhNUlNCd0hQ?= =?utf-8?B?ejhVZnJnTEdJOTl6Rk1xRjNFVUU0akliL1RkR3ZIMFg3R0tkVGVaaWtFMUpL?= =?utf-8?B?eVlYeUJJM2FHNDNzcFJ3cDRVQXp6blV1Wk4vTEd6czR3NCtHWWFIVzNhelEx?= =?utf-8?B?UGlaU1AyK3VwQk55V01ZME5GQU1JL1JqNHkyVXRHU0U0K242LzBkbW1IVHRN?= =?utf-8?B?Mk50M2dtNE5tU1ppajY4c3llUU14RVZZUFlpTEhWd2R3c0FubGVOWi84d2hL?= =?utf-8?B?ck4vNGtFbkJDZlc4VWZMUlN3b2JMZ01pS1JkQkdxOXRVOUhxbDhQQWFNam04?= =?utf-8?B?T0h2cUdyRjdJTjhSRnd2WlQ2RTdjYWpKN1pmRDloVzdiN2c3c2w0bzFRcDd2?= =?utf-8?B?SG8xd2xNeVMwTGo1elNVOHlMaVZHQUZwUmVLYVU3TVNaOFpzT3ZPbHZnMGZD?= =?utf-8?B?R3FaR1dwa3J0dnBqbE9uNDVLY2tRTk9FSGlpNEpCUjVSazZTTVViTXVWM1h6?= =?utf-8?B?UjJtR1lWWEVqL0s1VW1wOFpaMmpob0hPVGhEZTBTanoxMEJVMlBFTUxTU2FN?= =?utf-8?B?V0xTK1FpME9tOG92TGlmQ3BvMmdHOWlwcUZKSjBiQXJGQURic3NVZWhMbXVR?= =?utf-8?B?Q2JhNWdFVUNMcExBOFBSY29aTzhtSHJOMTJoM014amljd25ZNFJxdHJ1OTdQ?= =?utf-8?B?eFlwc3VnRUQ2WlhYZmFWTWdYazdVWGw4Qlh2TG85ZUF3eUoyYTgxak1aQUsv?= =?utf-8?B?ekZVcDFvVjRwNzZuamNoc3VURUpGbDlFbzR4OEd1TzdReDR0VndTcnR6OUVW?= =?utf-8?B?QnlVRkM2Z1JjVUlybXgvREtUN1krbkpNbmUwckZQQmpQMENjRFV0MENmZFVn?= =?utf-8?B?RkJ1a0ZNYlp0ZnlmRXhFUnM5UzhONUxEeDEwUWxiek9rcFprakhGei9tTGRh?= =?utf-8?B?cXFUZTIxZThxWE1IdkdxWXBPdWpTdmFJOHRlVnYrVHlHN1dMcE10K0pYMkpn?= =?utf-8?B?SE1oS3FmNm00ZW1YSUxSYkFSWnUxOE5GZFo5d1pEdFQ3b1BabUY4Y294QlhR?= =?utf-8?B?SlgvV2dZSnI0RTg2dG1HRitkT2R2YzYyMUlzOEM5ZnVPcTBmVlhkVWZ1Uzhw?= =?utf-8?B?c0FKTE82dWhJVC9DZzBvTkNIODJ2Q3cyWjU4V1lRMXVXc0Q4Lzh5ODFMNGkx?= =?utf-8?B?U0lycHB2S21CQnp5T2tHcm5rWTNTVExydlU1OUVwTWVNamZYZGN0L0VaM1RP?= =?utf-8?B?MnUvNDhDbWZhWGc1bm1CdHpjYVJQWHduOEtuWjBZY3Q4Mm5zM1RnajNpK3Br?= =?utf-8?B?L2oyTkhYRm1rNFFVTGF6U2w0ZFZQcStZcW12WWxVTmhST0RpSTVZdVJzZDRj?= =?utf-8?B?Q2F1M0d6SU1vVkVGRzhhNHAvd3NmeFoyaDZHNW8rNUtTZko4T1RyQ3huTTVx?= =?utf-8?B?T21rR1JFMFhUSExRaUlOazhod2tCNXBUMDZ2N3F5SkNwVTYva0dEZG5rem80?= =?utf-8?B?ajNKTHZETERaRm9IR0k0cXlzbFArbzVtSXNOVXdwVU0xUGxOR0VyMVB0MGNK?= =?utf-8?B?MTQ1MG1RblVFY3dxWUV0di9yZ0lLcmVsZ3dGaFg4bFZybWw1cWRPaVM0akFa?= =?utf-8?B?TVlOZlJqdGNHNkYrL3FtWHpmMkhhYThRSDhhTTBNd25kaCtqRHBaUnhudmNS?= =?utf-8?B?c0Jsc2V4d0xRNUtjZ05zcVp1Y240bENZbWgzY21iaWhsTUhBT0R3UmIvUS9V?= =?utf-8?B?WDU4WUpQR3RUL0dHaFZHdjVUOE1mNWJKbE96ZWhNaTZWb095anB6bE8rWERV?= =?utf-8?B?c0lYclg5eGtPTVpQTi9hWFhyVWk2UGZKb3kvSFRZT3M3MnZCejdDWk9qRTlj?= =?utf-8?B?L2NtWXlhOUFuNmFvR2dsZGoyanoxUWs5cXhqa09hV1lad1R0aUEvaWZTMDJp?= =?utf-8?B?WHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: w5ZhF3gYtShqKTEj89NEXp+6n0ULAI0TGv4iN3hpD9Xzs+0cQ62v2nVYLYPLAj6O5zg+UZ9dNGgRI3wU9g0NTBBnMTkVVGnmPw80nDRblgk9b79bGzRJTSFcqF5rOy5ybgJGy4jLJfpBm8XFI/cmpuG79K/wY757stydIzKGNomhaiOiejQwS3Bf1yj3cnwgB79SoDAqH8SkxkcHCpzkMOneQ4n9uha+13Np4Oq0icBcbh5L09kFGAniyWNMJ/QstH7aXFjbHOa+oVzT5c7AVb+W+uy5h1NZFdpdfwkUsoBW2K3ewOYErHmSUN10EbNa+GEhCh1l4x4TlB9DHyddPnqqPSpE8sFsXI5UDms3bAxnyeb756BxV10n1urKY/Rb4p3ahMqBeMjVX6ETgLP9UE85uO9KzFSj0HRhxvS+c6f2PXjlt+d8gKPFbwcNgCwNLhONjqcNh0tp93r7z7TBGPpfIqPdx3isxK6LM3cFtn2Ky8S9F56HT68FCIhsrKlineRKnA/jBMhBSPHY07JZnWcoou5UT9bGK1mLrcBPCd1Bet+zhc1VlqHUSLFt3McDxux3eJpAHr6+++WOynojknALTvY40wBc6oeOqddfdgpI+0miF4g4/tM/yXUuCTMzuc7YM6IXFdazbulr4ayIFZsWY1BavBfH5eJZQavnVvuz3kQXNIr1vNhkN82tzGg/IhMcvYYk6+UrsG6IxyZi363+M+iGpovdKOhjQiVgPCfuS9Nm7aEA9p9nxBWL6Wp4D59otzlk+wB8F1Ue67LRfEtVadhTMmjTevwg3UW5epwuFslctVYnu2P6dqXpZebr X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82571b92-0ff0-4bcd-f62f-08db343931dc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:47:26.0546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: th2TLhkwqR91cywvzWVgvPAlw3Q7+xRJm5YOVWJv33g19BYNPExzm9fhxPVqJRzH89fIEufOMj9q69cLqNbGVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5587 On Mon, Apr 03, 2023 at 11:55:57AM +0100, Andrew Cooper wrote: > On 30/03/2023 3:43 pm, Roger Pau Monné wrote: > > On Thu, Mar 30, 2023 at 01:59:37PM +0100, Andrew Cooper wrote: > >> On 30/03/2023 12:07 pm, Roger Pau Monné wrote: > >>> On Wed, Mar 29, 2023 at 09:51:28PM +0100, Andrew Cooper wrote: > >>>> But this does mean that we now have > >>>> > >>>> cpu_policy->basic.$X > >>>> cpu_policy->feat.$Y > >>>> cpu_policy->arch_caps.$Z > >>> I'm not sure I like the fact that we now can't differentiate between > >>> policy fields related to MSRs or CPUID leafs. > >>> > >>> Isn't there a chance we might in the future get some name space > >>> collision by us having decided to unify both? > >> The names are chosen by me so far, and the compiler will tell us if > >> things actually collide. > >> > >> And renaming the existing field is a perfectly acceptable way of > >> resolving a conflict which arises in the future. > >> > >> But yes - this was the whole point of asking the question. > > I think I would prefer to keep the cpu_policy->{cpuid,msr}. > > distinction if it doesn't interfere with further work. > > Unfortunately that's the opposite of what Jan asked for.  What I have > done, based on the prior conversation is: > > struct arch_domain { >     ... > >     /* >      * The domain's CPU Policy.  "cpu_policy" is considered the canonical >      * pointer, but the "cpuid" and "msr" aliases exist so the most >      * appropriate one can be used for local code clarity. >      */ >     union { >         struct cpu_policy *cpu_policy; >         struct cpu_policy *cpuid; >         struct cpu_policy *msr; >     }; > > So all the cases where you do have d->arch.cpuid.feat.$X, this continues > to work. > > The cases where you pull a cpu_policy out into a local variable, there > will be no cpuid or msr infix, but these cases already have no cpuid/msr > part to their naming. I see. I'm fine with this. There's still the remote possibility of field name clash between cpuid and msr names, but we can likely sort this out if we ever get into this position. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 11:49:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 11:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517405.802662 (Exim 4.92) (envelope-from ) id 1pjIgJ-0004mo-33; Mon, 03 Apr 2023 11:49:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517405.802662; Mon, 03 Apr 2023 11:49:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIgJ-0004mh-0G; Mon, 03 Apr 2023 11:49:03 +0000 Received: by outflank-mailman (input) for mailman id 517405; Mon, 03 Apr 2023 11:49:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjIgH-0004mb-NL for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 11:49:01 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84e3de47-d215-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 13:49:00 +0200 (CEST) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 07:48:56 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5871.namprd03.prod.outlook.com (2603:10b6:a03:2dd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.23; Mon, 3 Apr 2023 11:48:55 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%5]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 11:48:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84e3de47-d215-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680522540; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=S/dd1BE3i1wam+A+ho2BHZrjnBdwFWUSnpCe5R7AdTg=; b=MgVuGeXXcbzCcHhroo6jZKiHHz+kQK1i5od7AiSG2mac+kg1hK7bkzW3 o36AtTGc0IHMgohxbSnd/77l+HPOL97bmKgn2vpy0CJer59AS4PmpcoMg +ENP0ISeDNL619Y10XPwJEp9TAZrCm7dDWCJizzoPxAlGzggmeitQK3lJ c=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 106534854 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:QinEg69Q/NogbZ5aysA6DrUDrX+TJUtcMsCJ2f8bNWPcYEJGY0x3z modUDvXbqrcMWWgKI90Ptm08UgAvZfSzIJqGVA4qy88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagQ5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkJ3 s4ZEmgqYSu/xPiZ57KFRO01pYcKeZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpMSebkpqM26LGV7nU8KQI5W2r4nemoo16je5VbD R0axTV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcUbzE30 l6Cn/vyGCdi9raSTBq16bO8vT60fy8PIgc/iTQsSAIE55zvpd81hxeWFtJ7Svft0ZvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:JbYOwq9OQVtYB+pJ0G5uk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7 X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="106534854" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aw4KEYrQI5uvc5mTxz77tYbItzblEfPXPZSnBHSWzxR72M2YD/iVQM1DlzoPOMEccewaZvSZoWTNZamliB8Y9MklAtXuPAcIE1bgUQ+YvACwIibvTUZUwoPYVSppKrFKl3pth2PqxzraM77N1huArjpiD/J6Df83opSCUoQgJxEL/r5ZG9eIdNDJCsv1WYAQ+54KJ5Y6MQSAe/jJPfF0oi3uz18l32dCM/hYsyA0p7QvTf5+X20w3348cFOxNgPfA0juMaUS8pfeunQz8pp/fXgXc2vWzd8ff7RL6mpfNZgX8t74dwFR6N0haBX2XPBpAH0XVQUO9wO3OQzeu+0VYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NF/0VHEKmXlSYyf2iV8XQgfO8qTiuqIbt5+2xRqLfYw=; b=aILlJcOeX/72IpWXPcbM8ucJrpY9xgeCuO9DwF9xvnZ9CFGMYLIEbV7sEUB+jyv7z3zNKa8PGYs1VQft3dCepLzGhGprHWLc/sBUjYU4lWXS7Z07A97dykDITvayNn4Fb1bGY9CpFhyCjWE0s8Gt1DJoQ+SgKwA948zrMGWTz3tRxxZMHZLWY5W/ag6MnP1WVgA2vpw+tHIJhbgiXCQjGXo+SCoMN4rY4s7DBo6mvGrGQLUHOMhWOiZ1PdB/VgdjiHkTI//k5zcvk2XRMXYORGmLXGxQBphTtRKgCBwMKvUFBTzgOQ4Z2rkg3E/tH6MIzDqgsBVPpSltQ5cc2ADTtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NF/0VHEKmXlSYyf2iV8XQgfO8qTiuqIbt5+2xRqLfYw=; b=MqY3/d7l8Eg3sxUKIiHXl5VU+8yVp89jVDEL/e0ZpFo8LZSMsilGpZumCHH4p6EzgBmWOvMoaNt17sNpspdO/GVwnaGW3Wvi5qoqUFVdRoyiTNcRnmG4XdK4k9i2R6gdg4wwsDv/PEa/QzBAkot0lYrHa29yl4azXDc0ceQnaaw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6788d260-fe5c-f3e8-d479-329a2149fba4@citrix.com> Date: Mon, 3 Apr 2023 12:48:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH RFC 0/9] x86: Merge cpuid and msr policy Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Jan Beulich , Wei Liu References: <20230329205137.323253-1-andrew.cooper3@citrix.com> <9108a58f-da8f-14e4-de88-a7c8c8abb0f7@citrix.com> <14d8128d-6f50-99e5-ec98-366318e7be1b@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0273.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37a::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5871:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c4d7db8-8668-4e23-5eee-08db343966b5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7VuoL2vZQ0ZfeE/nfGYHyCSoWyKKVrePIqrmdcTy5wrqzJUaxwYPlczG2jY2yckafAN9P02PS+3wDJTFmpIL0zCYJr00j0RC5cfebOE3ffHpUaXwvCn3Sx37y6H9Wb1CUO5RdmLBpgUHn80UiIN9gCGCqdKAQqox3rBKYkJidOVmg0YpXqt5LD7EODrkEPDH60FB3GbyzHeHe6CfivhgyCLr8W10qFdWi02QEPHbJvDVS8Od0F0War+18tmgIa+pSFSENGttckGkwYlWfYYVgka6E0ez73Hzg7/AQbDt1TbEiKYUg5z2X9ZHsfZLMckTK2bA2WnrJlz7qHuPM3aN4YqUniZvj9Wt4obK3e0M9+Kr5k+bmC+g7lurWgzjePQlQL4GlpzfX0AOdwtKi5XbkIZAARI5u5+MiwwXbWGaIEKb/fYc53V/EDjy6p4FPdgB0nnABEwac+FwaeCCCglAmq8GgFcsye7i8GA6XCZ93pt7NqOk3/aAY+sBPMyB23wOet45lCs9rYkn8zTMHYtKRvW6dF6G6jB4qWRYKf/WMAmOnDUjDHDMHzQvjt4ElA79T83joP1rGlaxQlNu6yxNLXkYPnMWpOCrmQp4D2TuPBfRBVRcOaQ88nx1fQRxXi/fDMd4GWxz2Yeutt6nAo4fWQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199021)(66946007)(6506007)(4326008)(316002)(36756003)(53546011)(8676002)(6636002)(54906003)(66556008)(37006003)(66476007)(6486002)(8936002)(41300700001)(478600001)(5660300002)(6862004)(82960400001)(86362001)(2906002)(31696002)(38100700002)(186003)(2616005)(6512007)(26005)(6666004)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eC9ZcWhlWTE5cXp6cHZMV1UxMlFNdi9OaXNIQURVUWRQRVZPdzY1YVMrUW5D?= =?utf-8?B?cmhveFNuYUE3L0VjRGNTdjhCZytsSGMxWlFwMTk0ZmdlQnpiOXNXcWRmWlpa?= =?utf-8?B?S1JIRzNlbU9iZTlQbzVSdU5GSndZUEo5OGNRbElzU2tXNWxOMVRtMkJoTXpa?= =?utf-8?B?RlJOVEdkU3JybjVYTWgzd3ltbmJjK1hoeFF5RDNucGg3ZzZHUGttYUdMbzNL?= =?utf-8?B?YmhFVnJRaVZqazlQYmRCNTJTM1ZaYzZrVzlYTmVLeDVnM21OTEZxb0F1Z2ZB?= =?utf-8?B?S0ZUc0dMTWdxZFpjL1F4Q1p1SGVrRDZKenh2SGRLVGdOam1zSjQ5VG41cVJ6?= =?utf-8?B?YzJidjB6aDVlRk05eW85WFRaYzRGVHJvWWVLTXdyMFhUR2Z0Ly9lajR4NWNP?= =?utf-8?B?a0U0T0V5eXZSeHB4ckhIWEVGNmRpek5LOVl1OXJqcExRL1VGWDJOMi9FZDF1?= =?utf-8?B?MEpQNWhINTV6UVVIOThrbTFqaWh6bUJwWGU0OFhvZUtkUnhrT1grK3hVMERm?= =?utf-8?B?SHYydDl0eU5pcHhhMDFya3pFZGFVMlduU3hWcVZrMUUzVnkwTjVMcm1zMUhU?= =?utf-8?B?S1Zxa0lRN3pVaCs0QllEUjB0ekpkZ2JEZ3h4VVk3VDNvU2JSQmRlcHNzVzUr?= =?utf-8?B?Z1ZVNk9Sa1o1US9QNVowZHJoamQ4TkRZUFJ0RlNTbGQ4YUFIcVQ4R255NTJx?= =?utf-8?B?blZFSEkxM3FtaXlGTXpYSGM2dkhSM05NT2VURElianNFa2pJRjFDSVhEVFIy?= =?utf-8?B?MXZ2eWo0RzFPWjFJT1NiQmRWbEh2MXJVdWZDaXhnQVFkVEwrZmVjQWY5WXh4?= =?utf-8?B?OEg3cjZJZ1hlS3h6T0k3NnZxSFB1U1FOd0lUZFk1Y0NwR25rL2JKLzRTMlN6?= =?utf-8?B?V3p4a1BmWWZvWG9WMm4xTjBnKzN2bFUwVUFUNWxaS01SeTUveXpaN0NhTHhI?= =?utf-8?B?OXd3VGNIWTdSaVkwamdkSGZiN21zLzRtNVVxanBkcVhWektKWlBkZkI4c3VP?= =?utf-8?B?TzQvblMrbkVkS09NMndyYktRSGIrd0xLZlNxc2t0ZHdEU0U1U3NNUlBHcXh5?= =?utf-8?B?SVY5TXAzKzY4TjhVbmxFY29UTUpZNTFkNU5sbENzTjlKWGkzb0M1cUE4UVhV?= =?utf-8?B?c2NUVC85Q1M4b2l1TTB5VWlYQVNRSG9ZUStPbTlsajR3TFV4Z1l1WGxSMFRN?= =?utf-8?B?QVlBdS9ZQ1J1MGZoZXdKWkRlbTYwYUFBMG1GWVp0Zm40c0k2RDgrckZqaFZa?= =?utf-8?B?RS9IMGprWXhoZkdtb3pMWEdVWXgrdHJxU1JOQXlkUDNtSExSbDd1TUhyNCta?= =?utf-8?B?b3hiOVJjRmlwS0ZZempjbXJYQmtoK3ZvVjl3MUNrRklyL2w0RUZFbjZjVGg0?= =?utf-8?B?V2FnUVVkRURvcEY2NjlHdFJ2MHpoVHdRSy9pZEJ4WnZZREJ6SEdUREhOUEtw?= =?utf-8?B?TCtCbHhzTFg3cWZyMGtEOUZ6c2FUbDN5bENWZWt5SzJjZmxVRk1XSjdVaHFt?= =?utf-8?B?YUxQdkN6U21zN1NxeFRVc1I4LzlsS3pQaC9EYjJxQ1FBN2tEU2didU5nRFhl?= =?utf-8?B?NmJzSkxON0JGelJPSEg0RzFucUttQkZYUEtNeVZLVnR3SURtSXdpMGJJVU4w?= =?utf-8?B?L2djdVJ6bzhMZDg1bjFKWm56eG95eFhTc2E5ekhQZjBycHlqd2NtZGpqZ3gx?= =?utf-8?B?TkliK0pIQTI3MkhvUEh3d3d5UjNUbEhPWHVtbm8vSm9ONzR0bERoUVptNk5Y?= =?utf-8?B?OEtQbHJLUmJ5bGFpY2pVbW1KOHZqOG52NjRFbzJFOXphbC9wTU9NL2JmcDNH?= =?utf-8?B?L3I1bkZ5bGoybzNYRFpkU0duU1EzMi84REoxaEdrZytZaU1xOGh6UkUrMnB5?= =?utf-8?B?eTVxa1QzSmZQMGNwNXJCcmJmNGxwMEVNY2FUaXJOV1BWdm9VQW1NZkRmYzN3?= =?utf-8?B?aFdaUXhjdG03QzVkNTJCU3kvYi9tT3JRZDIydjZ0N2R5TjJNd1JaRGx5a3NG?= =?utf-8?B?SlVuWUhoaFlZUUlLd1JYcGRZYTU2c1l6M0pTODRPVGpYdnBDZUJUSlQ3TmtY?= =?utf-8?B?SzdFRU5zb3BZbEhaSE9ybDZhd3B0NzF2Mjk3bnQycEtma0J0V3MrclhxN2Uv?= =?utf-8?B?YkhsRkJDenMybEpxbWRWVkRPWkZKOXV3WHVYQmhDTEV2SjdlNXlOKzNHek9m?= =?utf-8?B?dVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3xYKrKy1cKejUcL5dFOl2hOOZsjbmoDCfU0yN5i5U7gb4Be4MyaixNcovLefP91AT0iYzSdNyKOLS9U1i+JARaMZ+1NsLAlZJdy9/AD69xdRlkUAU3g4bZTKvF66mfcvDMZo6TIWUqu/vt9MhV8u+q1EMkrPgoH2v5++4MJTqWas5ncmp1aMaMm/FO9HaPtEJxEY79pNhzhTirWT9SBGbWO9CbaQRSncrRV8fTh5vzYtpVmmw4M4ZsRiQQCw8MwO2x9JDU1oLs8mJ7ctmNyzsQILyVDS6TwCVMPPHIqvDh6pIztqXfoouFEYrim43aHiejxOp5lp64saaGjn9O2nXRSl0tOUzn/M31TCNQe4a33hntc+dNKWNEIsl/vSnSD0pYklfNTV+FgfkK+Z0rI0aYscwVoImVKnKcGFk8nIXSLPxyQO9QQBnkE6069wQO74Fkm3Gk5HY45oeRDKT/Iwy++uyGWJHoPS4MhYy36o1ANpcw1KEjpiKGkdEUyhrAKz6jzWBGdjNY0NhxYcmhKWkgmDhz49uraMd4F3FRoBcQswwFUe8nLTBAbj94oEivWvMEJKNfmHM9mkJRvFvlXFZAEEV5S84/mZ3s9g2Tmmivcm8sNHBXhLhiYVkmOvXZKgmZFQIzEzzTTs/6v8z3ha3ZwTkvn1UeETcJYUPaYg1NTMNkJcnE9ZcNv7LFNMDwAdfXpLf+mu+xJ4y/m+SjXqrIC3H4YluLNACoRJDZEdDWcPiwTTV9Qcfb6JBUm0aQohoW5sxFCsN90gxozv8MumytnKofERo08/uLf5xT/0g+l8pg2OeJaPDUWMnJlphzu5 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4d7db8-8668-4e23-5eee-08db343966b5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 11:48:54.6702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cSZZb7vc48IOamLd73zFxGaEqfKQ378X/ZtOuMqofemymqqygjxrn7btxeXW2Yq16UQCEmUsu0qike0b8AjgeTL27RXRYV/Bg63eUkIZFpU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5871 On 03/04/2023 12:47 pm, Roger Pau Monné wrote: > On Mon, Apr 03, 2023 at 11:55:57AM +0100, Andrew Cooper wrote: >> On 30/03/2023 3:43 pm, Roger Pau Monné wrote: >>> On Thu, Mar 30, 2023 at 01:59:37PM +0100, Andrew Cooper wrote: >>>> On 30/03/2023 12:07 pm, Roger Pau Monné wrote: >>>>> On Wed, Mar 29, 2023 at 09:51:28PM +0100, Andrew Cooper wrote: >>>>>> But this does mean that we now have >>>>>> >>>>>> cpu_policy->basic.$X >>>>>> cpu_policy->feat.$Y >>>>>> cpu_policy->arch_caps.$Z >>>>> I'm not sure I like the fact that we now can't differentiate between >>>>> policy fields related to MSRs or CPUID leafs. >>>>> >>>>> Isn't there a chance we might in the future get some name space >>>>> collision by us having decided to unify both? >>>> The names are chosen by me so far, and the compiler will tell us if >>>> things actually collide. >>>> >>>> And renaming the existing field is a perfectly acceptable way of >>>> resolving a conflict which arises in the future. >>>> >>>> But yes - this was the whole point of asking the question. >>> I think I would prefer to keep the cpu_policy->{cpuid,msr}. >>> distinction if it doesn't interfere with further work. >> Unfortunately that's the opposite of what Jan asked for.  What I have >> done, based on the prior conversation is: >> >> struct arch_domain { >>     ... >> >>     /* >>      * The domain's CPU Policy.  "cpu_policy" is considered the canonical >>      * pointer, but the "cpuid" and "msr" aliases exist so the most >>      * appropriate one can be used for local code clarity. >>      */ >>     union { >>         struct cpu_policy *cpu_policy; >>         struct cpu_policy *cpuid; >>         struct cpu_policy *msr; >>     }; >> >> So all the cases where you do have d->arch.cpuid.feat.$X, this continues >> to work. >> >> The cases where you pull a cpu_policy out into a local variable, there >> will be no cpuid or msr infix, but these cases already have no cpuid/msr >> part to their naming. > I see. I'm fine with this. There's still the remote possibility of > field name clash between cpuid and msr names, but we can likely sort > this out if we ever get into this position. Thanks.  Yeah, we can rename if things become problematic. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:24:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517412.802673 (Exim 4.92) (envelope-from ) id 1pjJEq-0000hj-2N; Mon, 03 Apr 2023 12:24:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517412.802673; Mon, 03 Apr 2023 12:24:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJEp-0000hc-Vf; Mon, 03 Apr 2023 12:24:43 +0000 Received: by outflank-mailman (input) for mailman id 517412; Mon, 03 Apr 2023 12:24:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJEp-0000hW-5q for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 12:24:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7d00::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 81ddb89d-d21a-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 14:24:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8230.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 12:24:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 12:24:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81ddb89d-d21a-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFyhteW20r1iypmuiWClHRYR88XwsXiDbigY9APD1HbqI+7m1IM3m007KbvNZFprUN5UlgUJu59vamO6+c5HprTjANiKvCKv0oBBQ5iooIaRKJkTul64Wp5y7TjVBYj7her6Kd74Vr/17ryQ3zW52fXHgdQRcyQHSzpuacYg8+6u0w2aE1bouDX7DDQfR+8iHoZYHZSLDzjOecXg7SFBUYn8NVCYxLVVHBDS1L7mv21bTurQTaQLXR28bNwB1E8btqmztAu4VM75njArB4/V3SKR43nKlE8bi1hgP2sX4upmhsrMgc5v3L37+Y3QYLqBWdKH/MurXbyltFvEOvOVTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p163uZDvV5ZjP7boHQvWgvCYdt+czz0NqgkwcVWTlAY=; b=FBGq86CwJCpX74g1kpGzX6VtTkqWbjHkvSa9d8sEDVewsmuzYyXYApYByPAdvB8QysZ7DYmspR2B45qlntTffbEY7f2liRwsoWYZk7sAWqqGi1yae7fzXEj+WX6KKcc9aBuUOYQ7vE8+P0FJmAvO7iq2i56QdD4W1BLkc1GJqoRxHQNwBK9WENPUIBMXstDPI89vXnzfZQPEUwSHE2we6hLWR1WLMBEXOn0LtMqe/PU+tGVpUvdETqqYJtg+xCcJMBH6ptkJezI6+IKqj8otF8+bJ8wHDjSIr05eb2BVrJ6+xEFBEO8AHDg0BMtODxGSdQM34vag7/NZpuzrmySR2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p163uZDvV5ZjP7boHQvWgvCYdt+czz0NqgkwcVWTlAY=; b=pzcl+KShoODLAZSwAJ6HwjWdnzTLeP0cSKyN3msebJKvm1Us5kWNVgvcmchoaBeB6BLeJohV3V0oyBanwUdYrT33HbOeDkO5zzlIq3o8KCWw6C+IWnDNJo8on3gDCOxV3CbyQjwgZAeysV6YpFOiMDyAmSiOjsLPGuiT1yMnHvAxt2q+DRkPxzKtf1nHj/NozaSosOFcGGlp/BpDNdo52A1sER+6l+2FT13Oojt5f/xRvr6EMU3s+cCNTv1lbOJu8cPv/DnKP1qZtx/KtLi6p56E7aoqZcYiVP6xZtCvZwmITxeTH/pMsUQVacsQLNufTFVrpqNQKSWc6OBLv2us9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50420132-70e7-0cb5-6929-fda11b2cf05a@suse.com> Date: Mon, 3 Apr 2023 14:24:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5] x86: detect CMOS aliasing on ports other than 0x70/0x71 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <5426dd6f-50cd-dc23-5c6b-0ab631d98d38@suse.com> <8f2fa47d-89b7-b39c-e60f-edee1de5ca82@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0176.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8230:EE_ X-MS-Office365-Filtering-Correlation-Id: 09d06588-79ee-46d5-9eaa-08db343e64d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YtvQJEj0l55q3gMd6RLs9NMxHJXDr4gC02q6Q9YO9L4zUg50OP2baTPJeB+Iz76M6hm1L3y7Yl94F7g0N2zKtRutJAHq8RLhuXTxmQWDbYtBSmLknqNr9Xku55jtRWU/f/oh6sfWgqlXHRuIVEZVNFdxhWCO+RYV7LGYeaqimJUVDYolL9/sLup5ju30oeCGQxjslu9VuDfT0Uo97uQOw+lrF3ao8Jg1wK6NDT34EmrPdhGzZQZcRxJmQ81tdaaR6wSETqcSZzeudc4TzQWlQSLYE8cNvTchme3b7L6+t9qoSc/p+89PJDkj+YOBga11QeOLPYdBU2yJNfm7ITsPioeRNlkTP0VALhhb3SC3bxzfi1isDEYDPzlbR1OqfZpz+F8ZDfXNeTwhQWns/d4ubSbjobIhwWhImGypkfwNNodN6x9bbjmynkO5XzGrjW3rrrDr1Hx9UnsIYPslRxOFp2jiZ0HezKqPDBYWrCGkEyzKIhC0A5ZNyKrbftqZ9kD5kW2OMs6JY9szMJ6teoW3gnOX718GJAUtxBXJeg7b+tLVxGd0blr8deDDOlYjgGUZ3UpQYb3tJsniKkytw9QY7i2Ie+unAxHDlWll8EWE2CZn96/vCVb4sp6A7xXrX+bPt4Pk8YCyq4MAGrRSB4cgyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199021)(36756003)(6486002)(2906002)(31686004)(41300700001)(6916009)(4326008)(6506007)(6512007)(2616005)(26005)(186003)(66476007)(66556008)(66946007)(8676002)(8936002)(5660300002)(316002)(478600001)(54906003)(53546011)(83380400001)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVZENytjVkZMRHMzSGdQYmFubHc0UEdtQlBwdVUvNzVXelJsdHNGRElBS2Nv?= =?utf-8?B?Q0kvTGsyZmd5czRQYmNoS2FCRmQrZVRuOTRtUmY4WVM1M29OR1B6bEVSbnZO?= =?utf-8?B?ZTdyNGJpTXF2Q05xQS8yelJtNitrOG5GRjJ3eXRMV3ozSnJHZzVPZjhoL1Zn?= =?utf-8?B?ZjZ1dnl3NUhwSlpyN2N1ekoxRlR0b3NNNWl1d3dNbEd5bXM2bk9rczN2OGp4?= =?utf-8?B?ZFBYYWpzU0ZPSlpWNzlyRmhtMGNEa1BYZC9nZVU4Vk02YWRVUXhFb1Iwc0Uz?= =?utf-8?B?U2tGZjdTWHp4M2VaUjlyRWNuekt6SEI1TTZEM1g2VHlEYUYyaTdDL1kyYTl6?= =?utf-8?B?VUFiQjBNSnBBa1RUR2pDeGVsS1haTFgwc2FBZG9acERFcEdYdDhQVEZXNDRL?= =?utf-8?B?M2x4bkNTcWhSTkhLcDEzLzBMVHN5V1ptMXhBTXg5SE9Nb0h2TmRGNDZtZVlJ?= =?utf-8?B?WCtTcEJTYzNoTzNQa0VWbFlmdVp2eHNPUXhXYjR3NWZ1N1NXYUNURUh3YnVJ?= =?utf-8?B?VEJUNmliZHgrTWJOYUgyREhMc3pyN3J4c3hhSnNOSFFQQ09VZnRTS2FyUjBo?= =?utf-8?B?b25zRWdtUURxaHFaYU5DZSt5aFhyNVFKR1E2d1Z5VEwrQ0I3UEZpald0UzVK?= =?utf-8?B?S200SGs1R1dlQmJTc1ppUk1jQnV5ajlDSXNtWElmazBLeVVMN0g3aEh6K24z?= =?utf-8?B?Z0ZHQ3RBamczMWxoVk42dC9mc3VBZ1VjSEpZTTNGb0QvR0hHMjR2YUtKd1J3?= =?utf-8?B?Ymh6c3Y3eUpUSzEvL0hGUS9CSGNIZGpPcmYzdXVWVFRsd1ZPTVBrcHJkL0Rm?= =?utf-8?B?UkhtZDg5QzdCZ000b0UvY0c3WW5NcXEzRk1jNXRjQ0luZUlwRTBTT3ZEQTNJ?= =?utf-8?B?UG9YK0MxWSt2aXBxa3JaZVpLdC83QzRzVFRmVFUzZXRkSXR2QjVIYmZkaFll?= =?utf-8?B?N3phWkpVWDk3VWZRRUlGMlErdHJmVGhEUnRoOTdoSnVxNUNjL0tWbEs5QkNa?= =?utf-8?B?MlVvUDYyNy9WdVF3c0dlaWxlR3JtWU9sM0JkRlMrTHdCNzU4bnBLSU9VRHVp?= =?utf-8?B?TnpRelBZZUhQbTJSdnRPK2JvbGNRR0lQQmhaUk9udEI0b2VYdDBRcW9mdnp2?= =?utf-8?B?eGZKajdqYWErNzdzOS9iTTR5M3ljTkZPa2tOVlppbXVkSlJPS2JhMEZVTUNx?= =?utf-8?B?STkrQTh4cUI4bXZuM2U4NWs4ZXZ6RjRwTkRuZVRKblVkcDBpV3NYUDNmOFVC?= =?utf-8?B?ZmE5UkdTR1B3bnFWVGdKeW5SYU5VcFRqK3V6NmQyT3RkZ2l3UytveXR0NHcy?= =?utf-8?B?Y1B3UnBsWFJvekFXS3BGUzNNUE1XRE1oWXQ4Zy9VY0kreC9VK3lBaEgyMkJq?= =?utf-8?B?dmE0cDlIMWZ6VHc2UTVJbnplQmhGbjlXYVZ2cFlpQk5DMVM3TjdLK3dNQ1c3?= =?utf-8?B?RGdkMnc3cDBoTjFDdWZFUkd5NDhuUXpXWjNjN09zdHc3cExreW93d3VNaUFR?= =?utf-8?B?UlNhamhDRk9vaXZtbklVSFhGbW1HMmVkaXhOb1d2TnlrZVFTZm9URkxMZEhN?= =?utf-8?B?bVNia2granFZSW0wTUMwYUFuaVZDcmhEOWluSExYK0VsaktRYUt0bDB3VVJ5?= =?utf-8?B?czJQVGdaWWVNZyt1TjZFSXR1ZFMxOWQ0Qk00Z1FRaE9MMGhTSHFnWE41YU5Z?= =?utf-8?B?MytjcTJEcGo1NjROemFvOWx2QlpzQ1hOaG9ZS3Yrb1pNYVVUUktHL21nSVpl?= =?utf-8?B?RU51UHhUcUJsSk95alBFd1NjMG5SRUU2QUlaYzNEYkxYdVBzeXJGbXdpcGEz?= =?utf-8?B?N1Z0UVdMNW1RTUxEeWcxeWVyVHZ3cm9ZODBOQ0hiYkJ3QWJ2TFA4SkRlT1c4?= =?utf-8?B?ODZZczVQcXpGQlJaVEU1Q3VkMnIzV1hEMmxBelpTZ2s4MkdIeG4xeDFmMkox?= =?utf-8?B?ZTNyeXFmT2N6TmU0aG5PZzQzQ2FQdHBVM1J0MU1zWjhKVm1NeWpGdTkrVCt6?= =?utf-8?B?VkpOaks1QnBvYmhyK3RKaTljcDRDRmptbXFSRkJmQ3JVMTZqaVYyNHRzT2Mw?= =?utf-8?B?akNvdWNDdGpIQ3QyZmpoaU1pZS9BMW5tTDA4SXVoZGFUSDR5U1pFbHlXMit3?= =?utf-8?Q?x+bNPShbSTQlaz1NSmQewHswa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09d06588-79ee-46d5-9eaa-08db343e64d2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 12:24:38.8643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3tT09XN7bW4Zkhhfz6IDgwAuk34nkF+8E8nut/0KBO0kLXvyi8wSaPlm1r1dKsFP8uDIvsR1VfAbOnEvUCbJyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8230 On 03.04.2023 13:44, Roger Pau Monné wrote: > On Mon, Apr 03, 2023 at 01:26:41PM +0200, Jan Beulich wrote: >> On 03.04.2023 13:09, Roger Pau Monné wrote: >>> On Thu, Mar 30, 2023 at 12:40:38PM +0200, Jan Beulich wrote: >>>> +bool is_cmos_port(unsigned int port, unsigned int bytes, const struct domain *d) >>>> +{ >>>> + unsigned int offs; >>>> + >>>> + if ( !is_hardware_domain(d) || >>>> + !(acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) ) >>>> + return port <= RTC_PORT(1) && port + bytes > RTC_PORT(0); >>>> + >>>> + if ( acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC ) >>>> + return false; >>>> + >>>> + for ( offs = 2; offs <= cmos_alias_mask; offs <<= 1 ) >>>> + { >>>> + if ( !(offs & cmos_alias_mask) ) >>>> + continue; >>>> + if ( port <= RTC_PORT(offs | 1) && port + bytes > RTC_PORT(offs) ) >>>> + return true; >>>> + } >>> >>> Maybe I'm confused, but doesn't this loop start at RTC_PORT(2), and >>> hence you need to check for the RTC_PORT(0,1) pair outside of the >>> loop? >> >> The loop starts at offset 2, yes, but see the initial if() in the >> function. Or at least I thought I got that right, but it looks like >> I didn't (failed attempt to try to address a specific request of >> yours, iirc). > > Hm, doesn't that first if() cause that on all systems with an RTC only > PORTS(0,1) are allowed? Indeed, hence why I said "failed attempt". Looking at it now I really don't know what I was thinking when writing it that way. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:25:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:25:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517415.802682 (Exim 4.92) (envelope-from ) id 1pjJFo-0001F5-BY; Mon, 03 Apr 2023 12:25:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517415.802682; Mon, 03 Apr 2023 12:25:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJFo-0001Ey-8t; Mon, 03 Apr 2023 12:25:44 +0000 Received: by outflank-mailman (input) for mailman id 517415; Mon, 03 Apr 2023 12:25:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJFn-0001El-30 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 12:25:43 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a501aa3f-d21a-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 14:25:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a501aa3f-d21a-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680524741; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TxjTaysaeDa90xTG7SNGAWxGMgj3IbXSTraiBTjeLEs=; b=W0ZX94Rv9Fw+UQH3xzzyFrZ2osH7ca3mZZiAeRttIgTARX1DVHY/dyew Rx9cHPG04nupYfQeb5Syj61ZdMUWBDFK4l1wgeVKsUwVcB51sEJ+Zc3bc vGrkywW9gJLCZIf8n7LIG88XsufA8KZ1WFbajhkiGg99gFb+J2YuAwlK+ 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104030835 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:Fq9iQ6Kgze6q5vGVFE+RrpUlxSXFcZb7ZxGr2PjKsXjdYENSgTMAm DEWXWuBMq3YZGT8c9l/O4q+pxsD7MKAzoJhGwZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5HE2Bwr uUfIgwjVQ2NhvCEn7G8WOZj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TTHZkNxR7I/ T+uE2LRXgwUb9eflCu88k38ofSQwi/4fd0vC+jtnhJtqALKnTFCYPEMbnOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHsljw2VsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LQHGz XfQwYmvX2Y29uTIFzTErOz8QS6O1TY9HX0DW3QdSgE5zeL+roAhvE3MScRsH/vg5jHqIg0c0 wxmvQBn2eVL15VXh/jrlbzUq2ny/8aUF2bZ8i2SBzv4tV0hOeZJcqTysTDmAeB8wJF1p7Vrl FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/LF7rVxBA1b5IehtDMhWfS+FyPosdz7ze 1P0sghM/pJVN3bCRfYpM9rtVZx2k/G5T42NuhXogj1mO8EZSeN61Hs2OR74M57FyyDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDuJLbiilkTP7FZrTCLNIVvzGAfUP79RAWLtiFm9z uuzwOPWkU0BDbGvP3CMmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQwnN19e5LWsdRrFY IronPort-HdrOrdr: A9a23:w/PMB6BzSLcOKgPlHem955DYdb4zR+YMi2TDtnoddfUxSKfzqy nApoV56faKskdyZJhNo7690cq7LU80l6QU3WB5B97LYOCMggSVxe9ZjLcKygeQfhHDyg== X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="104030835" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/emul: Fix test harness build with blk.c moved out of x86_emulate.c Date: Mon, 3 Apr 2023 13:25:35 +0100 Message-ID: <20230403122535.724250-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Trying to build the test harness fails with: x86_emulate/blk.c: In function 'x86_emul_blk': x86_emulate/blk.c:74:15: error: expected ':' or ')' before 'ASM_FLAG_OUT' 74 | ASM_FLAG_OUT(, "; setz %[zf]") | ^~~~~~~~~~~~ This is because ASM_FLAG_OUT() is still local to x86_emulate.c. Move it into x86-emulate.h instead so it ends up in all files including private.h. The main Xen build gets this macro from compiler.h. Fixes: c80243f94386 ("x86emul: move x86_emul_blk() to separate source file") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- tools/tests/x86_emulator/x86-emulate.h | 6 ++++++ xen/arch/x86/x86_emulate/x86_emulate.c | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h index 0ae528a741ed..942b4cdd47d1 100644 --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -65,6 +65,12 @@ #define AC_(n,t) (n##t) #define _AC(n,t) AC_(n,t) +#ifdef __GCC_ASM_FLAG_OUTPUTS__ +# define ASM_FLAG_OUT(yes, no) yes +#else +# define ASM_FLAG_OUT(yes, no) no +#endif + #define hweight32 __builtin_popcount #define hweight64 __builtin_popcountll diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index b84e9ee54dae..5a0ec5900a93 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -132,12 +132,6 @@ static const uint8_t sse_prefix[] = { 0x66, 0xf3, 0xf2 }; (void *)(((long)__##var + __alignof(type) - __alignof(__##var)) \ & -__alignof(type)) -#ifdef __GCC_ASM_FLAG_OUTPUTS__ -# define ASM_FLAG_OUT(yes, no) yes -#else -# define ASM_FLAG_OUT(yes, no) no -#endif - /* MXCSR bit definitions. */ #define MXCSR_MM (1U << 17) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:27:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:27:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517418.802693 (Exim 4.92) (envelope-from ) id 1pjJHW-0001oD-N4; Mon, 03 Apr 2023 12:27:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517418.802693; Mon, 03 Apr 2023 12:27:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJHW-0001o6-Jh; Mon, 03 Apr 2023 12:27:30 +0000 Received: by outflank-mailman (input) for mailman id 517418; Mon, 03 Apr 2023 12:27:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJHV-0001nw-3Q for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 12:27:29 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e56cc482-d21a-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 14:27:28 +0200 (CEST) Received: by mail-ed1-x52d.google.com with SMTP id r11so116629126edd.5 for ; Mon, 03 Apr 2023 05:27:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e56cc482-d21a-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680524847; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tiE7fi8L9R9ZN6JJC1ebw86MnpKbIthjLM1TAQ6wdds=; b=SLWKoRIjJSc15Z3iJSvUSE+xWKgnWLllIi48RMO+zJuuH7Zh+wfu6mQWj4g/CMbfvm LWfIFDCmD3now078RwoRVxGcd8QMPVa+yEXuGB84+ZsddkMy2ELo100vpXSifKl7azhg G71yRxDmgpp1CcWAbCQh56I92k7s7x2wSPsH3y0Dt5YrQvWc+cFhTfnwthmTY/O6uIAv ISyhl5lRlzuTNHuNdBi+JjIHUTb8vHrXTyHW4xoJCTvMXX1xftq912OTVPjEAFu5wsXj l7W7wkKhz8g9ZI8NY7YozGaSM3disnulAoQVpVCB88s5dMMeJb6JWKiQ5BugpfwBvtvR jGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680524847; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tiE7fi8L9R9ZN6JJC1ebw86MnpKbIthjLM1TAQ6wdds=; b=aKMCnrmbzJqodlJB1K5kGbrvjSDS2c7Xblt37z5/bitJp6AoVKfPYR5gIKaVQ1B//S RjxNtkej100WOGd2zNNukHnD2yoYr53PCq0woROJD6u0WuF6oGqscIJLdKCzfh9huFb1 x/oLWz7IuLnIMA7nPIjA4czrKp92yV/obhE9WZl399ias3S/sl9OmfiF/CPwPkrS3eEd 2AlZ2LMc+0VTA/zUVUhaauZCSksKPbfkngAMo5KfrcHxWwbR64HtvnKZKVjSqkQ3VZnB Dps9w8GRlVFQVhUYrD5Pjdw0hXeB4mtdtpThRm4erbFqv47trBiob3iQptb04tz3Jw+K Xk2g== X-Gm-Message-State: AAQBX9cVmqtMNPlQtAX/KvD7cSzSkNtduqoOV2GJtsM0sCKk0GLt2Wao HjZcfhwWdPgVcVsuGIhGJH+crohUSG4KQnHjPN0= X-Google-Smtp-Source: AKy350bvj5HIZOXxODdl9HmyUeSupI0oslUbBLSEUl1HB1gkoU4xmW0A4xcnaidpOajdABK2WAs4EAaIQ4xHo6NgWLI= X-Received: by 2002:a17:907:20bc:b0:92a:581:ac49 with SMTP id pw28-20020a17090720bc00b0092a0581ac49mr15671469ejb.3.1680524847399; Mon, 03 Apr 2023 05:27:27 -0700 (PDT) MIME-Version: 1.0 References: <20230312120221.99183-1-shentey@gmail.com> <20230312120221.99183-3-shentey@gmail.com> <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> <622b9674-fffd-4634-ac30-d0db3230478e@perard> In-Reply-To: <622b9674-fffd-4634-ac30-d0db3230478e@perard> From: Jason Andryuk Date: Mon, 3 Apr 2023 08:27:14 -0400 Message-ID: Subject: Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize() To: Anthony PERARD Cc: Bernhard Beschow , qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , David Woodhouse , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Aurelien Jarno , Eduardo Habkost , Paul Durrant , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefano Stabellini , Richard Henderson , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Chuck Zmudzinski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 3, 2023 at 5:33=E2=80=AFAM Anthony PERARD wrote: > > On Sat, Apr 01, 2023 at 10:36:45PM +0000, Bernhard Beschow wrote: > > > > > > Am 30. M=C3=A4rz 2023 13:00:25 UTC schrieb Anthony PERARD : > > >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: > > >> This is a preparational patch for the next one to make the following > > >> more obvious: > > >> > > >> First, pci_bus_irqs() is now called twice in case of Xen where the > > >> second call overrides the pci_set_irq_fn with the Xen variant. > > > > > >pci_bus_irqs() does allocates pci_bus->irq_count, so the second call i= n > > >piix3_xen_realize() will leak `pci_bus->irq_count`. Could you look if > > >pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs() > > >call, or maybe some other way to avoid the leak? > > > > Thanks for catching this! I'll post a v4. > > > > I think the most fool-proof way to fix this is to free irq_count just b= efore the assignment. pci_bus_irqs_cleanup() would then have to NULL the at= tribute such that pci_bus_irqs() can be called afterwards. > > > > BTW: I tried running qemu-system-x86_64 with PIIX4 rather than PIIX3 as= Xen guest with my pc-piix4 branch without success. This branch essentially= just provides slightly different PCI IDs for PIIX. Does xl or something el= se in Xen check these? If not then this means I'm still missing something. = Under KVM this branch works just fine. Any idea? > > Maybe the ACPI tables provided by libxl needs to be updated. > Or maybe something in the firmware (SeaBIOS or OVMF/OvmfXen) check the > id (I know that the PCI id of the root bus is checked, but I don't know > if that's the one that's been changed). Xen also has hvmloader, which runs before SeaBIOS/OVMF. Looking at tools/firmware/hvmloader/pci.c, it has ASSERT((devfn !=3D PCI_ISA_DEVFN) || ((vendor_id =3D=3D 0x8086) && (device_id =3D=3D 0x7000))); >From QEMU, it looks like 0x7000 is PCI_DEVICE_ID_INTEL_82371SB_0, but PIIX4 uses 0x7110 (PCI_DEVICE_ID_INTEL_82371AB_0). Maybe try removing that check? Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:32:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:32:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517422.802703 (Exim 4.92) (envelope-from ) id 1pjJMB-0003Fx-9Y; Mon, 03 Apr 2023 12:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517422.802703; Mon, 03 Apr 2023 12:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJMB-0003Fq-5R; Mon, 03 Apr 2023 12:32:19 +0000 Received: by outflank-mailman (input) for mailman id 517422; Mon, 03 Apr 2023 12:32:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJM9-0003Fk-IY for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 12:32:17 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2062f.outbound.protection.outlook.com [2a01:111:f400:fe12::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 90bfa3f6-d21b-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 14:32:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8241.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.23; Mon, 3 Apr 2023 12:32:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 12:32:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90bfa3f6-d21b-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OhK0du4NTETNhaiN/TwaYdavWbFHxsw9tKVF8toKz/I8u9V/YiUhhvjmm3oQHlj+Sz3XsLhQ1ZCZ7MhiftzotZ3ueRwHkakoUpwjL+aNTtekj0p9MtLjNFrLLHqV4XQuMDiZ1Ee3NGU9SqhlL4r9AgOIeMUtiwqG13kTEiYcBQVwbJjT3/r1MqPLB9DYpHNl4fL9ipOVXkdWo+SCKIXaNT0DZAnpsUtVZ2SiUdxEJ335oiYjjKnCGL1onXiQjij2xjec0uVaT6HJn24S8FYa3DeiIeQqbSqZaUMY7PO0z7kyzXClJNYDKfcmJc3R+47Ka1y8qnftSfOgL8u8fxAi9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T85vDg5TUrhPHf2JrkJQCK2w9XzTQ/j04O5QemxmJV8=; b=C7xnCkHfZJJ96+a26QG3zWITD/wL8KM9sGutj7YrjnGDNmj3L2RhI0gwr/j9vwZFZxQ2ybTR18wyexJusYMDsjbYdO6v41Z621bnxAjn93R3ubnPtxCJPtoxIl7NlHfdmF+feXnl3oQCLz42dzBJgA7u1EX+oKHMOVnAZ4vKktOkX2WAZGsa1yJxuE6w8MmUdU5fi12v2+h3ryF7J0oSVmP5EY2wGo7hQz1TSHgpToEFPcUdZmx0vzvRgA+j2Z/46E3kCeem2vHg8qf9fs/3oZ81k8dELu/rW18mUaU1ufgD/y3uFQjrvOg5FwjnbX8t3ICK3n6wgMnZiJzNB5QzPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T85vDg5TUrhPHf2JrkJQCK2w9XzTQ/j04O5QemxmJV8=; b=zWPNfIBFs5t1L8n19gz5XapdI1mIOaVCGyuBqh1fVofD+8k8pogW1O6SSWobBjBRpst4xClYOfmo5pcl6ThbmH4ng0b0CBraONZP4ssbbsmlscxJTSfwhLLekosGcQ+OmTux2qpTGIfdgJnzdde8hw9VJ0tHjVwRKjRpxSaMLHXUrJruVAWhkPK+x62H/i+PmAFf4uQGTOX8Q0A/DpKe61pR/drwwTdyIRTFdKhSrU9KaI8Cm4eeqKdtC5In49jWfAHAt9e1jq5F1xP7KAQxq2gzDrnOSVlpsPBkFxAKEvrS3xT6AzF7kE08vsWcQkDzlXk9uuAtSFTCXqhf/cyTQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 14:32:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/emul: Fix test harness build with blk.c moved out of x86_emulate.c Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230403122535.724250-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230403122535.724250-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0178.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8241:EE_ X-MS-Office365-Filtering-Correlation-Id: 729229be-f0d1-4914-e799-08db343f742c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7dOPxVcOMXHPaO4ZObhVfOLrJT9V5rehAiwRJCyd0y5TbCtnz0MSLGE/rW2ymvl99oAGBESsKxb/k4h3yvpULMIgzzFxJ1jFhZsiHuUYOOdYAc7Se97rzSZyiUJXvPxOzW3CptCwDlAMnPPR3+Fvh2U/laIh5UpmDk6CsoWp2OxXnZzXuAJutw2hm+bW1ndjjLJgDIyv3K97WOuSx3o6fLJV/+mIsb1kK3z+VheKxKBH0Wl0fy9t80i+J4fj0T7MYPYIhkAC+TkHg3/aOMQC+V6Ma2Fibty/3kaFQjiVagyieswq6qmUuoWdqYgFjW3BSbrQsbyqTkxfIyOvpmsKPtmmCp4Hzo5EuCWOy5rF1eWW0v04jRIiz2SDme107TM68zfY8mRhdYL9OjnVz4f5eqKyI8PMh0mKKDS2VrO4sz94e9sSNFDbKqpO2ZJ2BEp725+6qek4m0UhqyTppz2uQ+LEnvRdrEQLhqYExUC2/SmOHyUzvB4osRUHyFgkH5QqUMZqm3cj/mRDHF7x9LAb2/3Tt6bZw3PRK6+UNQvBUk9vBAqY3CbCDE91ESBseTHK6GdaHCKprLTlLRgJcdAn96U1VsNkdV/AEPPZoK+HhFM4rE+i7QlcgvhpPgWMD03Ub/jHlT52wIXz0GGePVV+qA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199021)(31686004)(6486002)(26005)(8676002)(66476007)(6916009)(66946007)(54906003)(4326008)(66556008)(6512007)(316002)(36756003)(53546011)(6506007)(6666004)(38100700002)(2616005)(186003)(2906002)(8936002)(5660300002)(478600001)(41300700001)(31696002)(86362001)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U09nVFI1bEJNRzhaTDlWV1lzYmdRWUgzcFdDYStoOGVpNzhaTWsySTcrVGZR?= =?utf-8?B?V3dGRHl2MEZyNGxDNStTbTd1OStINkpPNTk3dlNmOFpSa0ZPQ2JNOVZlS3hl?= =?utf-8?B?TkpPRlBjRUJZZ3ZaS2lZdmNSUk9JU1I4VEs2a2RoUlAwTmk1WUtiVHU4RmZJ?= =?utf-8?B?SXpRRTl5d0lLQ1VWNkg1bmQxVVRPeXJ2SUw0dkdSOGY5RzVaSzFRKzZuQjhC?= =?utf-8?B?cTlFaUNiYWlrN0RTTW0wRFIxMWM3UkRIaWdmVzErUU5DS2ZCUTVLamM5bTZs?= =?utf-8?B?SlRINmxwNGNHeVYvZ1JLdXNCOFErNCtnc3Ztb3FpUytNeHE5dEY1ZE9LZGJD?= =?utf-8?B?bEltcHFObFRhUWxhQmR4K3ZVV1RpcVpEMHo4Y0hhQUlXcU5MSm9vTjNFNGZM?= =?utf-8?B?TS9YQ0RMZWhCZktjVk1rWjMzN05iZzJTWXNsc0dLNjZDbDFtZ05FYytQZjk1?= =?utf-8?B?NnhlTm5QSjdYWTBaUHdhbWE3akdVbFlkVzJMTFkwSmZRcUs3QUVMT2tOQWZH?= =?utf-8?B?citmdVFvZi9iNGtXMHhSc3R5SFJ4bUtzSTFRbEJuSWhFdk9jRWJOZkNUejR6?= =?utf-8?B?SE5EekcwSnV6ODFTMVc5QU5vQVRSaUVDVlFZOFM3RUwwNElwQ2RyUkhhYlVp?= =?utf-8?B?c1J3cVNmWVhVNTh5RnRWUmlhaXhUdXZsK095N2kzSUNzTW5vVEo5cy9YZE43?= =?utf-8?B?T1lwRUtxS2tpTGlneXRibVRDR3g5ZFJrRFhjc1h3YXJ0U3NTN3R5aDhpTktN?= =?utf-8?B?TWN1U3FSTmhNTTVQVGNHMy9OVVQzZExhVGZNMjg3ajg3ZmV6TGdHSE5hL3Nj?= =?utf-8?B?RHlMQncwNW9GOGVSVWJOY3kyZmFobVcxSzd6RGkzVnpKQkFiTkYzS3RTZlRv?= =?utf-8?B?dVBybmI5UkV5YTZEelQ4cG82WDZXYnlyL1Q4d3V2dGxOSjZEcG5tQ0lkUjlp?= =?utf-8?B?ZnVXbXh5ZGVoWW1ZUmY1eExYbTYwbG1qWUhKMFlLSDFpek9NMHM4dkdUN3Jw?= =?utf-8?B?cTFQeWRkRnFhV29zbUVVUWIwUHo5M0s2R2FXZWQxVUFabHRIUEZyR2krb05q?= =?utf-8?B?VnAweDU4L0dxVGNhMFR6UktqSDFEMGl5Qm5qZjJPZHc3QjlhVDBYK1JYZktF?= =?utf-8?B?M3pDZlpYM1krYU52UUJhcUM1YTB4MEs2SnZSVkJPVlkwU2R3THBFMlNqZmRs?= =?utf-8?B?eHdLbS9jQVV2UW5VZWllOFhkWDUxUnMrWjFKczJrTEdxOVZ1V01IYUx0K2NC?= =?utf-8?B?SllVaTJkVGNQTXQ0SXhETmhGY0krSkNLWnc4SjlsQmVOMS9PcFNpZi9oRmNM?= =?utf-8?B?cTh2UVdac3RVS01vd0R1dWFIQTA3VHJZU1pVNFpmZ0MyUFgrSEJob1E1RExh?= =?utf-8?B?TnJ5WWZYNitDTzRud3JLTkp5VWVnMFJtQ3dQdFVnblBLUDNaODlFVUJqYVRo?= =?utf-8?B?bEV5QzZ4UnVvNDBkbjE1aURlVXZ2c2pCNzI0STB5VW1JQTc2ZHdhTVBlRnhs?= =?utf-8?B?VXowTEN3c0xKSHphcmF3b2JTT2RrVFJVV1JpSVduZW43TUtMKzV6SEVKZHFO?= =?utf-8?B?cklpbjNzWlMxZ1NmNWoxRURGOG9SQXZPaGx6aVJJakttaDlqM2s1S2RteXNn?= =?utf-8?B?QXMxSXE3SVQvODh1L1R3NG91MW5XWENLWEsybitsU3FHcmJQMG84b1lCVFZH?= =?utf-8?B?YkM5YkN6VDh5ZkU0dlRCMkRFS3hPRk41ZXFNUW5mZmpndzl1SE9nRGZIMkVm?= =?utf-8?B?Q2ZzNW1HY1BMSldtRnRnaTRlV2oyNFNNQVlLVzdBcTlZNXAxVzQxcVRMOU9I?= =?utf-8?B?UFQwRGlMS1kyV2JVTkJSeGt3UFdmNytCUVBOQkhNeU5mOFdiZE8raHkzVUs2?= =?utf-8?B?S3lRQzFCZDhpbzAyWFZua0VXNHIvNXp3S2hneFpRaDVRMWplNnpDTndGL21x?= =?utf-8?B?Uncxcm95eTVRZGMzWDZ0dmN6cUJIN3FPSTYwY2lOMjVzbU1ERnBoeTVSOHJL?= =?utf-8?B?am9JZFdZb0xHWGRwUlVwWTNSOFZHeFNIZmF5dWU5bjhpZlJRbFh5UFRYTUJ3?= =?utf-8?B?OHUxN0xGa000K1lpa1kvdkZsRy9IZTV5ODUydDhEYm5ZbUloVk9mU0VJWFNB?= =?utf-8?Q?rMKUwt/g4YdiISEPWO+Hf9JlE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 729229be-f0d1-4914-e799-08db343f742c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 12:32:14.0724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PILZt4P8qTgiY8fRyso//prdafEPV17MYrqV3dRrBnRGd7uadUsSEFqsjLHWU1iDWieB6IVhfdK0aBMuq07Vzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8241 On 03.04.2023 14:25, Andrew Cooper wrote: > Trying to build the test harness fails with: > > x86_emulate/blk.c: In function 'x86_emul_blk': > x86_emulate/blk.c:74:15: error: expected ':' or ')' before 'ASM_FLAG_OUT' > 74 | ASM_FLAG_OUT(, "; setz %[zf]") > | ^~~~~~~~~~~~ > > This is because ASM_FLAG_OUT() is still local to x86_emulate.c. Move it into > x86-emulate.h instead so it ends up in all files including private.h. The > main Xen build gets this macro from compiler.h. > > Fixes: c80243f94386 ("x86emul: move x86_emul_blk() to separate source file") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Locally I actually have this exact same change, but in the MCOMMIT patch (which predates the splitting work by quite a bit). Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:39:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:39:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517426.802713 (Exim 4.92) (envelope-from ) id 1pjJSv-0003w3-44; Mon, 03 Apr 2023 12:39:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517426.802713; Mon, 03 Apr 2023 12:39:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJSu-0003vw-Vt; Mon, 03 Apr 2023 12:39:16 +0000 Received: by outflank-mailman (input) for mailman id 517426; Mon, 03 Apr 2023 12:39:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJSt-0003vq-Bt for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 12:39:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0d::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89915a07-d21c-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 14:39:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7674.eurprd04.prod.outlook.com (2603:10a6:10:1f5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 12:39:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 12:39:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89915a07-d21c-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWlLfxr7YGHGmlmKrz95obtczKkY1oeQ5/h0vLS+ODpFmYmzMlIAnadBrCtRoVmcKvChwGngargD02uF7H7234r7fh4D7xa4JZFWB/YWVpXEI/neAADufIsDcCFCLi402NFl/D5S9uAbJmgluSBKnPMcACkhcxkL+0fD5wu2Vo5yRkIMWy0r2pIwYDxukZBEwnF54iPAl8lpgG+hbXZ7LlG6tuqOeypuTPP3WhqR2kpdeM+G/DBgCVY/8jLNlCiVZI74MISO3pTyDJoTDswZqJxh55ioQxZjhKgqwbf/inCYjmGGe569+MU4hyohqenhhDZb1F+70rx+16DuDNNQ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kkNr5iDw5JV3J8qNnpUmRp1zna4a5Qb3MIEAArRhfSo=; b=cth6HxMJ4PI/GbDW7F48qzEVzyzVTE7tT9b4HASmsQyiX33kb0Hj1vQEUD5b7tYGOTz52BW6J1KKBPkANUKMfdxVu022QQ0Pma0QpqUfFZHxmtwAZFrEK9Zvja80Uwla/2Gh1E8YFpbPhdetVYnqRelrz+x2YCWgTdD+3I7yNsyiVZW0jeYn64px1N5y+yW9Y5LzpGihVLpX0l0StoiJ9U1wp06HCphwzvxvw/3Teirc5kUZcf675RRkmQXgHRkZk7dpflvIoHf+NBfaRqUC4LqLMgnkXIkaDmlpn1jQgX6stzwEW416CZbjfWLg6HlJIDoKxxejsR4usdr1dDPUiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kkNr5iDw5JV3J8qNnpUmRp1zna4a5Qb3MIEAArRhfSo=; b=ehROP3MTKk07w6eSJVVPBduwfGEuNn67O8JK2VxS2BSTIxfBgu1uKoJpIx+hzU7JUshvWxp9pu2hdmmrI5K/aC4gO6zOCxro1iyfsyf5K8wlF7q1cNDMy7KUMckYHy5dS/4ps1DjLbrihR6rFk9uIDyZ1lhXUITRiDpgcN4uaUMgd+EPc4Cxo2msgI3LKRIkT0cQ/9R6ljWuUScssLI7Mu6n5a/eA4gHtADzcY7nT5x7LwL04qnExtYmAg0Pd5AEZUpRC3KSerjjw6QHQgD7TiKH/bIxdWl8XzA5SadlzCazcOJ5rufIZkNv+9gd4kVMlGlHiAoihw0fOJ10k5qLhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8d976d34-8a1e-95ad-3bc9-3cb704c1fae7@suse.com> Date: Mon, 3 Apr 2023 14:39:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230403101449.93323-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20230403101449.93323-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7674:EE_ X-MS-Office365-Filtering-Correlation-Id: cba0af35-addf-4185-71f7-08db34406c43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w2SsTqvPKN2/J2avpwsiVBPF0e9qWqIqa7RcFEAAY6LbqU5D/qfzyQeH4qWfuQUkOmHWYtI1NLq2G++hklHqoJyyeqRByeTz2MYBpM7HL43O82nAhIYYIvd75PoIoUV3h29ISRVYjsAGgxj76GzW6AhhHRz4Z1WNeLIxiE2Re/dcZTFFBhWs40rL1vJdtDXj3M8tilhnWMj6a4FrW+/OcH7D+xP4pz2P0jVTwU84J/pVASnSY1ts6iKIxJv32B49zn40fueR+85DxJ3ZXBYt4XZ8qub2p530lfSoSxvpBtQrMbekshyiq4GNkMmObpzfBso1D3eBeoysPJRXl/+4/RbqOsPzNus/s12tyYSuemFFUpWX9U+uw6p9c/j31adnqhMlfOTra5jt8hpIntkhDhHnR6k0GLtF3BmasOrGWwthbZSPvG8ciJy3ZuUylK7wuuRW1ch75D2Pj85cYWUTfiUM37fy3bm67vU+38wGsbXfLU9DFgZ1lf+Zyb4G/uzF5baRFeKOhqtt23TbFpFERDDAhmrqya0rS2NXKkIzhKWTIwtwqqHV5ZLZekuH/Grat27IpMN0l1cNkZbXplsoQNxt1EczarqcM/3w2p7eEjnol8m6uOh9qAvsey2wj30kF70NdkAbena5mAPjocdA7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(366004)(39860400002)(376002)(136003)(451199021)(38100700002)(5660300002)(31696002)(2616005)(54906003)(316002)(83380400001)(6486002)(186003)(478600001)(53546011)(86362001)(6512007)(26005)(6506007)(41300700001)(36756003)(4326008)(8676002)(6916009)(66476007)(8936002)(66556008)(66946007)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGY3MWMzWXZaUzdZVUpkOFVhRnFidlFWSmJTdUMrWGllbkxidFhEd3pGWTlJ?= =?utf-8?B?WmN3eG1PSVdNbDZ5MUlSVGplTXBQdWFtNEZ1Q0N6VlNMWXM3bzd4NHg1VEQ4?= =?utf-8?B?dXpySkx0WVJLREtVY21TSlBWT1dxRFNvK0VrY21uUmxHaWJFaXNyeXRZN1JK?= =?utf-8?B?ZWhFcmxsMFN5K0VHcUZScWN5dVdCaC9QMlRGaGVYWXBmSXV1V2U5NjVzSXVH?= =?utf-8?B?RUU5M0RYZlJBd2xLOXBQNWp2N2NSNklQZ3BkM044RmRNaEFnU3ZPbllmNnFi?= =?utf-8?B?UXJFcnRMZ1VpR0ZUQnFGVjBjdEtvVlBsYkxDN2N2QkhmOGFPcDdPUlByVDZR?= =?utf-8?B?QXhYT2JnNFRqUUFqQWtDUGo5VEVnYnVJL0NLSmQxd1NDb2FvWTFxSnIyUDVv?= =?utf-8?B?a0lTSzgzaWo0OUFYS2FjL2RKaVdwZHI5eWhlbHp2bTQvZ3Y0Yi9BbmhSb1pu?= =?utf-8?B?Tmo2bkYzbmh0cDdmNHU2TUF0cVV3alNqNU1sVllmazZ2Mm0vQ0ZwaVU1ZFk1?= =?utf-8?B?MUVEUDVxdHBSaitmTFhCYnFaNWl5L3JETG0wYVRxRTBIRFEra1RnVjNaQzgy?= =?utf-8?B?aW1VZUNGSHJ4S1VOdkRwUkVzYjEyb1JxQ2RIbGxkZzJsVTVGd3Mrcm9MeTI3?= =?utf-8?B?NXZ3cmpNUFVJQjdZZE50TTJ4NWZxREZYQi9zN1A2SFdPbWcyRjZMQUdLM1Vl?= =?utf-8?B?Nk1HajlqZ1pNbVd3YytQcXdwNTlUZUEzOWUwTGVld1A1OGNRRDIxaVZwdXA2?= =?utf-8?B?RitXZm81K3lJNldFa0xHam5jVm9TZmw5MTd0Sy9XR3pkQkc5QmRUeTRST1lt?= =?utf-8?B?TjF3TWI3RUl1OCtsRVZYOTFzaGEydHlUK2tGVU83RXpkOUNDdjMxcWkrWU5G?= =?utf-8?B?VVhFcWVNNTgvSVlvVzR0cHZ1QlpDR1FHam84TEFyb29jZkVhaFNreW4zWlIr?= =?utf-8?B?b0xQRHpwckcreWd4N1o0TUc2UnMzSy9QTFk1SEN2bE1Ydk1xd3pUQ28ySTVl?= =?utf-8?B?anNxWStFVGdxUDhGZkRDeTR3WkNhNmJoSVZmdnJCWU04RytKUUNhRzVnVGlP?= =?utf-8?B?RlRucU8zZkdqRDIxT3lLekI2cE1KQWNnR05JdEhIU3hWK1FjMTl4MTlwQ0Z4?= =?utf-8?B?Y1FtUzYvbXIwWmljaTYyNHZqV0lQT0VSVFJJa1gxOVVVd1VYV1RreEZjbWNL?= =?utf-8?B?RHQwcTdxNFVIK01oOWUxQXVrdmdrU0dmQnd4UTE5RW9RYm91WTZWb0t6ZEk0?= =?utf-8?B?Q0dJcnNJRVFCVlloNEpHdGlIY3pyZDhyWlp6dXBCNkk4dWZ3c3p0by9yQTAz?= =?utf-8?B?Sm9tcWV6dXFoeW5VZUlGMGZmTzVUL2VLdVQzOWVWM05TTUlOVXR3ODhKNHdC?= =?utf-8?B?WWh4UERFL1ZRNU9TSkx3REhycE1sbVV5MHREMFVDOXlUMzkxbzFvQ2x2Y3hx?= =?utf-8?B?d3FQMzNpcTdkTXh4YkxVOFRMaHB5bU1OSm13aW43OE5pcmdnd1g2eTJUNyt5?= =?utf-8?B?Ulg1clFmaDlMTnVWY2YraC9uc2dvSURGQitycjZqUjFMTUM4TjZmZkRFbDhQ?= =?utf-8?B?U3dQWTVQenpLM2tNZUxiYk5nUkdvd2NEaFRkRmVLT2NZVFJVYTFQY0NlMGhX?= =?utf-8?B?eFRLdTZpclYwQTVKRDVvUkNPU2I1OTA4MWs2WmpqUDVOdEFaUGYxcjJWYmJy?= =?utf-8?B?UlJQMGFXdElOUmdzOTA2a081c0N1a1RxZzZ3NW9hZmFGUXl4RWZVT2RaOUxH?= =?utf-8?B?WFJiaVRTMGk1L3lJM0pMTDhMOFVSYTBndU5OUG52ZU03YzZ5bm90ZGZscTFx?= =?utf-8?B?c2FwUVlRcCs4bnhoMTNNZGxKU2RSamsySTNtcmRQL2p1bVFQZzJEbk5CMm9J?= =?utf-8?B?NnFiN1dUc3FqTWNTUzlMa2xIa0lMUmxSL2NGMXBsdTRhbU9QelN2RURrVWp1?= =?utf-8?B?a1NlVWIybXQ1WkdpaFF1cjN0a3kzOVhhVWJUTTdIZ05UenVlNWhjb29MclFs?= =?utf-8?B?YTJOczhBclRyWjZ5VUlSbXMwSk1DSmVaSUwzaWZ1MXRFNHRqYmZrTWcydXdQ?= =?utf-8?B?VURuSldLdkU4ajd1L0NBVEduTGNBS1RoVGYvNVV1Tm16Rjlpc3Rjay9MQjlC?= =?utf-8?Q?xw77x3Fe0MnfKYY3ETrVvgPfX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cba0af35-addf-4185-71f7-08db34406c43 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 12:39:10.6983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DplGsPZUMXXL/hlB9n1zPu0fTyYp7Nf5kJM20tTTfxjxx7HlFMw3YbXbWXQU05HQxvfvSaOFbIOMHpyc8XSrMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7674 On 03.04.2023 12:14, Roger Pau Monne wrote: > --- a/xen/arch/x86/mm/p2m-pt.c > +++ b/xen/arch/x86/mm/p2m-pt.c > @@ -486,9 +486,6 @@ static int cf_check do_recalc(struct p2m_domain *p2m, unsigned long gfn) > p2m_type_t ot, nt; > unsigned long mask = ~0UL << (level * PAGETABLE_ORDER); > > - if ( !valid_recalc(l1, e) ) > - P2M_DEBUG("bogus recalc leaf at d%d:%lx:%u\n", > - p2m->domain->domain_id, gfn, level); > ot = p2m_flags_to_type(l1e_get_flags(e)); > nt = p2m_recalc_type_range(true, ot, p2m, gfn & mask, gfn | ~mask); > if ( nt != ot ) I'm afraid I neither understand why you make this change, nor why you then leave the other use of valid_recalc() in place. > @@ -538,9 +535,9 @@ int p2m_pt_handle_deferred_changes(uint64_t gpa) > */ > ASSERT(!altp2m_active(current->domain)); > > - p2m_lock(p2m); > + p2m_read_lock(p2m); > rc = do_recalc(p2m, PFN_DOWN(gpa)); > - p2m_unlock(p2m); > + p2m_read_unlock(p2m); > > return rc; > } How can this be safe, when do_recalc() involves p2m_next_level(), which may install new (intermediate) page tables? Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:50:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:50:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517429.802723 (Exim 4.92) (envelope-from ) id 1pjJdF-0005RY-14; Mon, 03 Apr 2023 12:49:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517429.802723; Mon, 03 Apr 2023 12:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJdE-0005RR-UU; Mon, 03 Apr 2023 12:49:56 +0000 Received: by outflank-mailman (input) for mailman id 517429; Mon, 03 Apr 2023 12:49:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJdE-0005RL-4H for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 12:49:56 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062d.outbound.protection.outlook.com [2a01:111:f400:7e8a::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07444ab3-d21e-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 14:49:54 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM4PR12MB6063.namprd12.prod.outlook.com (2603:10b6:8:b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 12:49:51 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::659f:af8f:6d3e:8242]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::659f:af8f:6d3e:8242%4]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 12:49:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07444ab3-d21e-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SoyMUN8lkB4TWJczrrnC+webiCjV0i3IcQSOHW8nq+ZhmaW/OP9RCfYYY+rbE6aJjm+SxcVlnrWZGdu6RuZ2gNC2B7HW8EQvS8ApRu1zTT1D7BzI84HZ6Hxl8Ka2r6yDSh4wIbdULKi2AVfUQbAT7dQi2EVmlfJ+k65XRwz99RFIF6jeK38UzcG0gMB3FuqOjbzDckBHkCEp7H8WQEGVpvTL7d1inTWG9kK5iOdLdz37KPE0BnfqBQP78z9NlQ3vv6PRr9rHJh7/lnGlchfCHfmSP6IWs7vEQ11sGLgzCjHk/9QXz6KbqeuuWnkIK9vX9wRnTFzJ0sD4EWQIhIUiQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ulHxYGxKal1Hs+seRR7jT18eEPRUjrcMb+GtA8Atv4=; b=YCCk+OSU9li5Wc/nNrAYmffOEHb8tirpsk8gA8UnrCA/O20cRK/EtsuKVxHGXO3wVN/qDXBRxVJmSR9U/JUbnM4p5ckaansoE3Ws5wXdoTRh1+alkUooltZJ55OmKoKQjJ9wxs245H3YyYSLMhEV22MTNqrMA+E8BVLreyMu48xK+iVSCNcxvpyxwkGDiZ2FboPaMRPYd1+FAX7RQAmgPFKtXxG9VUbJNxJK5WeAUAQuZ8nX07GkaeNxCG8YbdrUKzvv18sF6FzWeQ4Dj6tFXazF8WJoel4M7cCKVyHyO21jCLHPVO4iqiXs+vfMCWJKjYSvNqwoe7cn+gN7bAw4/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ulHxYGxKal1Hs+seRR7jT18eEPRUjrcMb+GtA8Atv4=; b=rJVZcICm9E8Y9WhzweWI1oAc1+dk7enAelJgJQW1M9KlSaFmNRYZyNRDkn7Tw2TSMRdnPkpR/qlOcDCMDPpio7FL7IG72a0epePfqDPEnPfoPw0La31GNzI5XT0z9xBdhmb5HaLCtZQJZ1eLPTuNR/NfbW5K7HR6Z5xR+EAOJyA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <049cc80b-9fe3-1b01-67a6-112bd5e46443@amd.com> Date: Mon, 3 Apr 2023 13:49:44 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN v4 06/11] xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230321140357.24094-1-ayan.kumar.halder@amd.com> <20230321140357.24094-7-ayan.kumar.halder@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0450.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::23) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM4PR12MB6063:EE_ X-MS-Office365-Filtering-Correlation-Id: c15ac467-100a-41e8-1b0b-08db3441ea04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lnkDqbon/RKPst/EN01pi4SOxk2ooXqNrL/jeH1V0X/2bBRJcIiYIGM7Qm7KYQXHIYoLQKkjkmw+bVrXygVUDyOwsx1kAGj9sIl+ZL/nYV+H72p3jMkOIVsJ4nMhvL5s07SfaRb5WjQumGxbUZ12gHyHd2xOBy14Qs0iVKpzsOWhyStvHTfcXAhokVjB5gxUsuORrlDLfrVRxwmfi3vEAwieocbbnvgWX8RS+Vg25oZd0iiqxZtv8+f46EVJPq3t3vkyVvuIM2IMiYo67wS3zqYob6G1auEbyj80Ox9bzjg9lGG5ySCuM52oz6mGXPAqq3nXTk6DeGgsAgC12WRFXFyasNHH5myR+UrZI3LHlA3wdPNUsTkOY9X86EIpcaVU46/vMhAGvYbzqNq45AmsU43EcsqsoevUx1Lxq/6K/Bhi/GpeLMmAs4+n/DqlHroQ7pPQ2GvsL+/3c8Qkeo9kXRIhGIArTP2LPI9oTDsR1EiY6FK4ZPYNRUrEKYgCknYM0Zc4OGSaBqRF/ABMPAB0lEE/Njsl+/q5Kwb8gVWX1BdxmbfKq37r0uRz2vNEq+7GzPqFNljt8vWbIyD1fbnNOXcsCMW/MqvV4XcZ44UGJXTeEPEfzAJjVYHbGewiJfdUMlQNsPWD+b/UOhEYJ6qMZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199021)(8676002)(7416002)(8936002)(66556008)(2616005)(31696002)(186003)(26005)(6506007)(6512007)(38100700002)(83380400001)(53546011)(110136005)(316002)(478600001)(6486002)(6666004)(5660300002)(66476007)(41300700001)(4326008)(36756003)(66946007)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVFUcTJEVVM5MEZiMUo1SWxoWUcycUt1ZUtheUcrcUU4eng4RTVjUDE0ZS8y?= =?utf-8?B?TlFyNFBNOFFVM05EdVp2S01MSUVpc3JtVTlST2svT2VFblV1cXd6SWlHMFpm?= =?utf-8?B?Smpqc1VIbkJCTUNLL0UxL2xnQkc1UDdIM0o4bTJ4V0hmVjlmaFpNV1NkQTZV?= =?utf-8?B?MUs1Y0s3QWUwU1lIMDREWjNVVmJoZ3pmc0FSM29RdEtENi85OTRNVkxEWlRx?= =?utf-8?B?L0VNR0tmTW53dTF3ck93MFBudHY0VERSdWd2WjNrRTZhay80QkJFYlQxUG1D?= =?utf-8?B?ZGY5YkdIRWhlRFM2NUdqamg0NE0rSTlsa2ZReCszSURvZ2JRSmx0ZGpsWC9E?= =?utf-8?B?OFNMaHMyaFY3aHBIVTUvT1B6enJwZkc2Y3dWZUZBUmZGWllUQzVOQXVsS25l?= =?utf-8?B?d3pWVXNwc0VKaG1SK24zY2JBRkU1TEJjWE9oWFN4TDV2OWhVVG54NE5McitJ?= =?utf-8?B?bnpTM3p0WXdmRjY1MXlmZzUraUcrelp4L3VGaVd3L2U1RFVnS3haRXFBMlha?= =?utf-8?B?SFhtdVg4N0dNTE04WXhoSkVuRVV2TWExZUhnNEVQbzZGQ3lJeUdnMDFYN0VT?= =?utf-8?B?S1RqMm5JMU5RYzlEQnlnUW9XbG5oUzgvNitNMlozR0VHMVpGWUViSnJEVXJR?= =?utf-8?B?blRibWtjeTd1R2xFaXB0d1RERnB2ZCtxc0k0NEo1SXdITWV2eE4xcWV5cTg5?= =?utf-8?B?YzNZR3lrNTVoQ2RBUUdxTk1aa0xTUSthbjhYdXBOWFRSVUZhdk5LbnR2Vm5m?= =?utf-8?B?ckcyUUpYdmRNQXpxZit4cXhzVEJTRFMwaVRvejhzOUNGNzdLOTAzSmQ4eWpl?= =?utf-8?B?NUYrYjlBNHp4NzdjbzVNVUN1SEZNOFdMcmJuaDgwQkRvT1lCSEpKYitDMytD?= =?utf-8?B?OSt1aVJ4empTOTlvN3BiYVIrSVU1OU1Lc05RdnJXb0xJOE1ibHZHV3R1djBQ?= =?utf-8?B?MitqVXU2a1Q3bE5CeVMwaytIamN1RkZhdlV0R1JNZDc5dWRVNWRUUnh1bEM4?= =?utf-8?B?TFpzNWp3eEdpZ3FBZXhsQUovM0djbncvWmV3VFFKMVR4VkVYNnRnaTlzc056?= =?utf-8?B?cDhpS0hKQ1hITFBZRGJ1RWdyeXlGTzNDSXJsUlIva2Fvdnh0dzNJemN5Y3dV?= =?utf-8?B?L0VPazdtZkZRRk5aV0pvMjNTNEI0K21MN0VSQlJnMXY4WXhMU0xSc2VzbExO?= =?utf-8?B?VXBUVzBRcWw5S0MwSEs3MkhRODZLUjRCYmNvTDIwbE9HVHA3aUtrNUxHWDVT?= =?utf-8?B?Smw1K0VjSExhdjZTSEdoaXRQZW9rbkovcXBUZlRYUk5MaDc5QkJ6SFlGNUE2?= =?utf-8?B?T2UyYlJkK3VUVkZUKzI4Sy9DSHdaVG15TkRDczlvUkV2S2kweUEyRTZlRi84?= =?utf-8?B?U3Z0Y1Y4K1o0STgzeXpNdEhRVW5PSXl2ODNqMzBpYTRxSVFKcFppUUlLM3BN?= =?utf-8?B?OUlZbHJWdXFQQkVtT0pnWHVYTDZEN05NUlNCaHRDcXhJMDlKWVg4KzdoSnE4?= =?utf-8?B?ZGhBd1Y2ZWRiVS8xKzJrTnpHbmJNV3YwckZISGsvOGFKS2lqbjk0N0lIUmQ5?= =?utf-8?B?enNhaVdyN1JkMDJ6SEdDQlBKb2dGdUtjWVBUdVhCWDdGZG5WSW8ydGF6clNU?= =?utf-8?B?WnMvOG8rc0xybmEvckZ5M1VKY3JUcWM1cnNKbGdkUGRIWlNyQ3FQVzZiNDJm?= =?utf-8?B?aWJsdVFZbmtZWjRYenBEM0N0aTZRRXlMQTRVVFl0VXU2SGtZWmRvT1V1Wnhp?= =?utf-8?B?ZXVhaE9PaXJyanVHOTBCWlI4L3ZqUC9RVVlUQWs3TXdEWlk2c1dSTEdQWkJU?= =?utf-8?B?VDFkMm0yQ25YV2t4OXJKR29MNzVmQlpldjhmci9wMDFNSFFOZmpVVjZPY0Zu?= =?utf-8?B?VzlCRm5MWS9iSkZ6MlB2bCs2alhYakN4ell2UEExbWM5S3BuNUhhSC9PTkxV?= =?utf-8?B?YXdZOGdZS282ZS81MGhMcG1lRjhNZHdtOUtoQ3FNT1JUUm1yOEV0enA4bUMy?= =?utf-8?B?VzhNMnFGL2dMcFJJSHNEdzJHT3g5TmQrRmhrMVYwekhIVVRUUFpYUS9lKzFu?= =?utf-8?B?ZGlVOGNxRDJxNFU4WHJkTVkrc3ZrMTRhb0hWWTFNb0g4cVU5dVJTN2hkakh6?= =?utf-8?Q?uIUPQ6c9/3zcHS+B90E+Cgh7b?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c15ac467-100a-41e8-1b0b-08db3441ea04 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 12:49:50.9217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OUEqTcO+joF1U4qTClxAY7vT18IHh1gzwx4Uu0jn7OwC0pnGbCB2jn7JJKzkCG+skkYHQxF97G+fPKewuqcSSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6063 On 30/03/2023 22:27, Julien Grall wrote: > CAUTION: This message has originated from an External Source. Please > use proper judgment and caution when opening attachments, clicking > links, or responding to this email. > > > Hi Ayan, Hi Julien, > > On 21/03/2023 14:03, Ayan Kumar Halder wrote: >> Refer ARM IHI 0062D.c ID070116 (SMMU 2.0 spec), 17-360, 17.3.9, >> SMMU_CBn_TTBR0 is a 64 bit register. Thus, one can use >> writeq_relaxed_non_atomic() to write to it instead of invoking >> writel_relaxed() twice for lower half and upper half of the register. >> >> This also helps us as p2maddr is 'paddr_t' (which may be u32 in future). >> Thus, one can assign p2maddr to a 64 bit register and do the bit >> manipulations on it, to generate the value for SMMU_CBn_TTBR0. >> >> Reviewed-by: Stefano Stabellini >> Signed-off-by: Ayan Kumar Halder > > The tags should be ordered in a timeline. So Signed-off-by should be > first. Ack. I will take care henceforth. > > I am happy to do it on commit if you can confirm that this patch doesn't > dependent on the patches before. Yes, please commit this patch as it is independent of the patch series. - Ayan > > Cheers, > > -- > Julien Grall > From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:51:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517432.802733 (Exim 4.92) (envelope-from ) id 1pjJes-0006oG-Bp; Mon, 03 Apr 2023 12:51:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517432.802733; Mon, 03 Apr 2023 12:51:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJes-0006o9-8s; Mon, 03 Apr 2023 12:51:38 +0000 Received: by outflank-mailman (input) for mailman id 517432; Mon, 03 Apr 2023 12:51:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJeq-0006nz-Uf; Mon, 03 Apr 2023 12:51:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJeq-0000Kh-RG; Mon, 03 Apr 2023 12:51:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJeq-0006Wy-Ac; Mon, 03 Apr 2023 12:51:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjJeq-0000zg-AA; Mon, 03 Apr 2023 12:51:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dpMlPzhdn2xiggfFd3IuEvqdtUJGVsKIy+S3+BQTpqs=; b=R3KRY6zRMW+GO/FkAfxsvodHlb CQDzmh4/U5tEe7+jZ/WGnsytTcuKs2Pht/CfKOEUfpJwLgWOyOJmWE9unnY1x17ppxJiBBr+viWpj 2HaXaXpD8UcdpFxHqQQlVK6NIryRfGqyBI7aKYUG88MnpxKCaAQaxEYBB+VIU6BeIaRo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180117: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: xen-unstable-smoke:build-amd64:xen-build:fail:regression xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=720ebfbad3e3bee8aa18e37e08ef597f493f8bf8 X-Osstest-Versions-That: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb From: osstest service owner Date: Mon, 03 Apr 2023 12:51:36 +0000 flight 180117 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 180085 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 720ebfbad3e3bee8aa18e37e08ef597f493f8bf8 baseline version: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb Last test of basis 180085 2023-03-31 07:01:54 Z 3 days Testing same since 180117 2023-04-03 11:03:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Oleksii Kurochko Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 fail build-armhf starved build-amd64-libvirt blocked test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 720ebfbad3e3bee8aa18e37e08ef597f493f8bf8 Author: Oleksii Kurochko Date: Mon Apr 3 12:53:29 2023 +0200 xen/x86: switch to use generic implemetation of bug.h The following changes were made: * Make GENERIC_BUG_FRAME mandatory for X86 * Update asm/bug.h using generic implementation in * Update do_invalid_op using generic do_bug_frame() * Define BUG_DEBUGGER_TRAP_FATAL to debugger_trap_fatal(X86_EXC_GP,regs) * type of eip variable was changed to 'const void *' Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich commit 71efa7b868e64d29b2a0488e015e80798f1fde8a Author: Oleksii Kurochko Date: Mon Apr 3 12:52:02 2023 +0200 xen: change to The idea of the patch is to change all to and keep Xen compilable with adding only minimal amount of changes: 1. It was added "#include " to ARM's "" as it uses uint_{16,32}t in 'struct bug_frame'. 2. It was added '#define BUG_FRAME_STRUCT' which means that ARM hasn't been switched to generic implementation yet. 3. It was added '#define BUG_FRAME_STRUCT' which means that x86 hasn't been switched to generic implementation yet. 4. BUGFRAME_* and _start_bug_frame[], _stop_bug_frame_*[] were removed for ARM & x86 to deal with compilation errors such as: redundant redeclaration of ... 5. Remove BUG_DISP_WIDTH, BUG_LINE_LO_WIDTH, BUG_LINE_HI_WIDTH from x86's to not to produce #undef for them and #define again with the same values as in . These #undef and #define will be anyway removed in the patch [2] 6. Remove from and as nothing from are used in <*/cpufreq.c> In the following two patches x86 and ARM archictectures will be switched fully: [1] xen/arm: switch ARM to use generic implementation of bug.h [2] xen/x86: switch x86 to use generic implemetation of bug.h Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall commit faafb5cb736db67a5790854c63bf3c76dd4df7e0 Author: Oleksii Kurochko Date: Mon Apr 3 12:50:56 2023 +0200 xen/arm: remove unused defines in The following defines BUG_DISP_WIDTH, BUG_LINE_LO_WIDTH, BUG_LINE_HI_WIDTH aren't used in ARM so could be purged as unused. Requested-by: Jan Beulich Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall commit 60a9b07150558b212918aa8fedd532be246b03d7 Author: Oleksii Kurochko Date: Mon Apr 3 12:50:06 2023 +0200 xen: introduce CONFIG_GENERIC_BUG_FRAME A large part of the content of the bug.h is repeated among all architectures, so it was decided to create a new config CONFIG_GENERIC_BUG_FRAME. The version of from x86 was taken as the base version. The patch introduces the following stuff: * common bug.h header * generic implementation of do_bug_frame * new config CONFIG_GENERIC_BUG_FRAME Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Tested-by: Julien Grall Acked-by: Julien Grall commit de7d113212b0e28423b6d0e983aa164e76b415b7 Author: Jan Beulich Date: Mon Apr 3 12:48:12 2023 +0200 x86emul: move various utility functions to separate source files Many are needed by the hypervisor only - have one file for this purpose. Some are also needed by the harness (but not the fuzzer) - have another file for these. Code moved gets slightly adjusted in a few places, e.g. replacing "state" by "s" (like was done for other that has been split off). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit c80243f94386f64f85c5d92ef0bb19dc406eefc2 Author: Jan Beulich Date: Mon Apr 3 12:47:08 2023 +0200 x86emul: move x86_emul_blk() to separate source file The function is already non-trivial and is expected to further grow. Code moved gets slightly adjusted in a few places, e.g. replacing EXC_* by X86_EXC_* (such that EXC_* don't need to move as well; we want these to be phased out anyway). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit 1939403104965b091feb7712430ec5d7645a8d30 Author: Jan Beulich Date: Mon Apr 3 12:46:08 2023 +0200 x86emul: split off insn decoding This is a fair chunk of code and data and can easily live separate from the main emulation function. Code moved gets slightly adjusted in a few places, e.g. replacing EXC_* by X86_EXC_* (such that EXC_* don't need to move as well; we want these to be phased out anyway). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit 8f196c12eec7f90bcf31f86312b8fe5ee12b41be Author: Jan Beulich Date: Mon Apr 3 12:44:59 2023 +0200 x86emul: split off FPU opcode handling Some of the helper functions/macros are needed only for this, and the code is otherwise relatively independent of other parts of the emulator. Code moved gets slightly adjusted in a few places, e.g. replacing EXC_* by X86_EXC_* (such that EXC_* don't need to move as well; we want these to be phased out anyway). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit 0bae69c96b32963b535bb569d6b41f96a7d72617 Author: Jan Beulich Date: Mon Apr 3 12:43:51 2023 +0200 x86emul: split off opcode 0fc7 handling There's a fair amount of sub-cases (with some yet to be implemented), so a separate function seems warranted. Code moved gets slightly adjusted in a few places, e.g. replacing EXC_* by X86_EXC_* (such that EXC_* don't need to move as well; we want these to be phased out anyway). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit 3e957de632532dc287ae4cd356fd8d7882d4f233 Author: Jan Beulich Date: Mon Apr 3 12:42:44 2023 +0200 x86emul: split off opcode 0fae handling There's a fair amount of sub-cases (with some yet to be implemented), so a separate function seems warranted. Code moved gets slightly adjusted in a few places, e.g. replacing EXC_* by X86_EXC_* (such that EXC_* don't need to move as well; we want these to be phased out anyway). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit 9ace97ab9b87924477bbaea0a5a1378e106951cb Author: Jan Beulich Date: Mon Apr 3 12:41:08 2023 +0200 x86emul: split off opcode 0f01 handling There's a fair amount of sub-cases (with some yet to be implemented), so a separate function seems warranted. Code moved gets slightly adjusted in a few places, e.g. replacing EXC_* by X86_EXC_* (such that EXC_* don't need to move as well; we want these to be phased out anyway). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Mon Apr 03 12:57:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 12:57:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517438.802743 (Exim 4.92) (envelope-from ) id 1pjJkV-0007WG-4j; Mon, 03 Apr 2023 12:57:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517438.802743; Mon, 03 Apr 2023 12:57:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJkV-0007W9-26; Mon, 03 Apr 2023 12:57:27 +0000 Received: by outflank-mailman (input) for mailman id 517438; Mon, 03 Apr 2023 12:57:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJkU-0007Vz-6B; Mon, 03 Apr 2023 12:57:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJkU-0000Qv-0g; Mon, 03 Apr 2023 12:57:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjJkT-0006eA-Ee; Mon, 03 Apr 2023 12:57:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjJkT-0004Um-EB; Mon, 03 Apr 2023 12:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c4BQUKfw/IhXa4GW4aJy10c/+1PyMTSGePVS06txcuo=; b=QBRInCoJJuJWz/C9Rtf1fkvUT5 YtUg8FQFfpx21IBFi5+vDdsCxXgE09LabOZ4LqfDLS3f7QeilcuMRYlpAgSLHBZbSZ2SwITAToknw RdPL5j+Uh1UrMnopMEdYnQYElzA2qiesWBpD9TIplLqC+wXYoE0XR7Ye2J1IA9GtKBiM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180116: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=7e364e56293bb98cae1b55fd835f5991c4e96e7d X-Osstest-Versions-That: linux=6ab608fe852b50fe809b22cdf7db6cbe006d7cb3 From: osstest service owner Date: Mon, 03 Apr 2023 12:57:25 +0000 flight 180116 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180113 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180113 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180113 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180113 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180113 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 7e364e56293bb98cae1b55fd835f5991c4e96e7d baseline version: linux 6ab608fe852b50fe809b22cdf7db6cbe006d7cb3 Last test of basis 180113 2023-04-02 18:13:46 Z 0 days Testing same since 180116 2023-04-03 02:26:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 6ab608fe852b..7e364e56293b 7e364e56293bb98cae1b55fd835f5991c4e96e7d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Apr 03 13:25:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 13:25:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517446.802762 (Exim 4.92) (envelope-from ) id 1pjKBG-0002Um-D8; Mon, 03 Apr 2023 13:25:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517446.802762; Mon, 03 Apr 2023 13:25:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjKBG-0002Uf-A9; Mon, 03 Apr 2023 13:25:06 +0000 Received: by outflank-mailman (input) for mailman id 517446; Mon, 03 Apr 2023 13:25:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjKBE-0002UZ-Ot for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 13:25:04 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061e.outbound.protection.outlook.com [2a01:111:f400:fe0c::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f08920c2-d222-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 15:25:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8401.eurprd04.prod.outlook.com (2603:10a6:20b:3f3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Mon, 3 Apr 2023 13:25:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 13:25:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f08920c2-d222-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkLheGfPYrqgJ+vKyithgeLT5qTRmEiqg82FBguVCvfHKpQROcZikyMZfZvXK9aYcuvcCLd0eoBx98mdCMzCY/Mw5CwnCY8qLpeWDj4CVWK95kUDsLw10dFtvkzpOMj5m5cuzhIX+4UFMX29Lqvy3uL/A9DcXU+WvJ/b3K6XLPew9ClsGcw7vH9I4KfcwWJouUNPOKat1O0sE05xrP4Wliie7iF4snl9IcEzNuxPIzsDm68b/T9yi3Ui9i2/AXt36ewRQa0bU4WFCyVQPJV6etVCADUIhEcScTm00o4njaKc1TaB7qaAo4FZ6WFJK8mu5S9G0sUHCilE9hsDFLvSzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EeO9WlffdyqbjvDDnpxR+pBUtbwT2GBSWRHSi5bAjnM=; b=HpvVtyGveNfjn83dfVWcJzzLN0mhOjzzeOs7XZLS2xhwvAE/14y6IR3cp1UKbFRAKxAX6vOg6Oz7NtTWbun9X3uXsAYgKk2kP4UjUAjPf6K0VK2bf3amimhcrmwfSKTtBDR4IJiyYJH3fJPgfJbypJr60vXdbtDLmWG1sL0Axn1bhyBZCALdoiXIhCniol6iiHABUyt8OFfXmRPYTf2jA9h6FLZp1VULNmkpIAiHE12VDOJw2r9qygftcUK2UnTwz70vPRVgeEyiPyQjvc+XfASH5AaX3tLrvzhCWjvM4AW38aDMyxJhejrzTfCF04v07NOxRIuqw8TD3KhVep14jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeO9WlffdyqbjvDDnpxR+pBUtbwT2GBSWRHSi5bAjnM=; b=15XQ/Z5fb3e0Y5ixpPR5JVkxKQ0pjp8H1f/Xt3hPpuAcWqlNjcMmQ+WyaRDcCJg01DwsW0JewPbvfroMqLiqmS8/bv+ej9uanmzrlZAth+BQk6h6iLS601GU4qMNrTy7wCgpK7SDd5gw5R9MV6kONheVLfImx1BEIZyqmvj7y9rqMNK5TcDblcMC+gACrfXn9640jh7du8swUxZs7NyVvveSBVzLFD/YLUV7Ys0aJUDrm5/1oAVGXPDoekGE81f0Q0d4GaDfaq5lcJOGltsJZT6SDrcZqVBqWi4AaV/phcy1nxKx48nFb8kVnbor/kQgCCC+nN/Ydok7ZB4EMbLAMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <335f22be-cd5b-8cc9-cd9a-25caa59df384@suse.com> Date: Mon, 3 Apr 2023 15:24:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230331175719.500285-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230331175719.500285-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8401:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ce922e6-ce49-4487-c185-08db3446d32a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FQW0XosH6c+FLTUzXEPvaFjd7gZ4f74cp+aemhMqSgkP+7gpMbak7kpNYzTzxoz6PxrP8LCovvhmNBDFH0PPA0p3M1w3lRPqS3ZWUXraqipBKjf1Fpdr77FChtXN7nEWBYDQO8QesMKTyShvLy4ASM5XcRv/wA13Ps5K5mkX2AYYvfxWDKMuAwO60EEyQOWHsdMPgmOVTqs6AoKWw6RQsDhAZsGkJA+Fk3vFfmDv9G90T04vfvLkfMb4VzGwR56BDweEM/LByV/pKu8bNrqE3r3p/brCesW8xCzDxp9Yr7g7lFguBQ/KqtVyq01ruG5hv5fWljs7mhHKdX312BeB7mopla6zHLol6ZtGdmc3mVok49md0/qaBMsjsvf87wLkR+j9/6OK1uBH1IqDyoEKcSs5Z5tJHrpdmePMqe8HjR6HKZh1W4WvoHjPcboT7nIMpXiWnZ+4FBobtUxaLKeR1HWy4/fX+lRx00pD8hWOy25X/3P/kEeTRJBVO8Tq9c+Wvhz7ysx+TyV8CZZY+pFNeddCDCOsRCSH+1T2TkkMk6ZzlnyjlK3EDS79bseh3wNQm/UuMmI7/c+njUo3xnESUxa1yFaHQZAFK9Uxjkfpa3JJetj/rglYxgv5dAXBikPKid3v4mb0zTtOTwaIpnQIHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(31696002)(86362001)(36756003)(2906002)(66899021)(31686004)(2616005)(53546011)(83380400001)(186003)(26005)(6506007)(6486002)(6512007)(6916009)(4326008)(8676002)(66476007)(478600001)(66556008)(66946007)(41300700001)(38100700002)(5660300002)(54906003)(316002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHBBbFF2TU8wemdTSUN4TmFVeHJrd0pVSkRBYWZrYWU1ajUwQzFlK1N0anIr?= =?utf-8?B?NW92RjEyQ25nNE1tc2gweEpYUWdINHQ4S2hiQzRkUmtRWENWbTdlRFVRSitu?= =?utf-8?B?NFF0MmxYMExBNVZMamg0UHUxMmkrTHkvaVhKcEY5V0pRMk9JaVlkZlQvbEkz?= =?utf-8?B?M0d5Z1p0WVVJK0VoVm0zNTlCZndtNUpYUmxPR0YyZ1lSYWVRYi80L3N2TlNp?= =?utf-8?B?enp6bTRzTWIvb3BBaXFQbkowQzZQR2RRTGZnaUpJRzlaL01mZ2dyUXM3K3lW?= =?utf-8?B?YlkvaytRNWFtY2I4UE5lczA4VjBNRkhHVFVuQVFjdDZ3c3laeE9vdEJpaitF?= =?utf-8?B?UUlQNi9mOVVhblNNTEJYeWptSDA1eDRDRHhSVVhsdDVaOGEvM1pYVm9kdUNQ?= =?utf-8?B?V2R5RDZPZVRtQXUvdDZ6Z0dQR0tCSTl0U3ZvdjErUmxpbWF3K1J0V1hFR3dE?= =?utf-8?B?R1FRQVBSaUxZWHFPR2I5b25jdEk2QjUwbXBPYWtTY0VpYmhsM0haZ1JsRkF4?= =?utf-8?B?TWxTYldUWmlOMkR0OVZzRDBObnFHSnd0U2Rra0xWNkl5TlBvZzE0MnIxRlls?= =?utf-8?B?b0FTbzA4aDZVUDZUcE5uSTZpL3ZVbVVJSUZJck9kcHh0STRES2V4cDZubXFS?= =?utf-8?B?NmtwTEZUUXFET1pSb0NVcTR4ckR4VUNUVGhHZGl3cVArQkc4ZEEvNk1XNVlz?= =?utf-8?B?aXltbHVKbTNKM0N0b3lzQWx4RnlzZVhJaVhjR3hwL25DUDY1aDQ5enp1Mm4r?= =?utf-8?B?RlhtaTBwaEozeWJOT0RZY0pmNUx3NDFjL0thZVA0NkhyLzlNamQrdkxDdHhh?= =?utf-8?B?MVpXR3hvSURkSHhmR1RncUU3WGZwRnk2YitjdWF0OTMvUlhYMUl4b2hRY2FQ?= =?utf-8?B?Vm1pZWdtWWRyYlMvSVM5RHlIVTFQWEhOakpOdXRrOHFpZlBXSXdsR21GMUt6?= =?utf-8?B?cjU3cTVZaGFRVjBaY296OS92emFBNlRVcG5VZnJ3MGpNbGoybXdCa1gzM3pF?= =?utf-8?B?Vi9icmJLbVI5R1FtL1YwZkZHWXZ4QWQxa1JyR25LclljNXZLTWQxM1l3WnM4?= =?utf-8?B?bHVCbWVRMzZWRjdKbkJKVXZRYU9ScEVha1dmKzNidDF1RVVtdDJSQTBSdU81?= =?utf-8?B?ODg5TkpaSnltQk1yTE5LbDFhQlc5dHBoa3ZXMDN5UmhmdWNoRnIzZnliUlJ2?= =?utf-8?B?SmU4K0xMOS9wOEFacnVZTDU1TlZxcEpYUjlDTDVVODJSNzE3TmVKcUxGaGs2?= =?utf-8?B?NXR3NVAwcTUwbXZJNHB1cEhNVE5LdHdLQjZvT2lsajNvTGxGOC85SmFEN0Ur?= =?utf-8?B?RnFpeUhSc0wwcFZ3b05FR0VBeGtQdENJNGZ3UlJVMmJLMEdMU01UYTJWUk5L?= =?utf-8?B?dWxqZmFJT0xPWDM1bmdidHFXU2doZGJ5U0ZhV0ZCaWVDQUpqRWZrNE1seCtL?= =?utf-8?B?b3NMYXhlZUk3TWlnNUFrNkRGRXU1UEw2YUtLOHMvRDFyOUtCNXlhQ1pWb2ZM?= =?utf-8?B?Zk5CazN6MXR4KzVKT09aQWorYmI0T0YzcjRJeWNTRDQ2WWpRMWhleFhOMEVx?= =?utf-8?B?YzdvMUVTYXk2bzZrUVNRdTdyaE1aQ0prdTlBeS9KVUZkTGFDWWQvWnFiNkZG?= =?utf-8?B?YlFDYmxJeHVqRUQ5NUViaHN4UVdoVDF2RDlSelRlTk1rUDVldEpPQW9OR0hX?= =?utf-8?B?Sm9EKy9MZW9RblQ0QS9sNzJ6OW55ZnRXUXJhOG1heWk0aGpGelpvZG1ySGxL?= =?utf-8?B?QW8zcFQrMnB5QjNKdzdrcWVlMEpKbGN3L042Q2wybzJyMEpPTTI1dFJaaEY4?= =?utf-8?B?ZDRic3Z0MzhsM2o0aGNUcStlL3h3N1hwZHJuRTcwQyt4dWVEUC9yN01FYjRF?= =?utf-8?B?OExKbWduUW4vUjhQTGFJZXR2Z0gxVHNiVHhFaDlNYlIyR01zWVFZcHBVS214?= =?utf-8?B?QTFPbWwzVUZtSlRLZWd0elpiUGk3WnJiS2NMOUZKaDFDNEp2S09zYkQxYXJo?= =?utf-8?B?b3kvbnpTNUhKc1Yycm5kNkovaE9BTTlCU3RpNGNHd3dzWG9PUVRYUHlnN2JP?= =?utf-8?B?SVQvZkJ5U09CQmx6REJIbis4TlBsOWlIdy9wNDF6WDNRL2QyTUZVSUo0c08r?= =?utf-8?Q?I1n2P5S2cykPoHOgWAlkwJ6XW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce922e6-ce49-4487-c185-08db3446d32a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 13:25:00.1373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: de7B4H82wFl3h/rW8gLX1j/6assKAje5uzQLUXLySFSnFxl1M1aw0iHidTwIX7HFpxbgNLFWKYpLYDj7VYHjOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8401 On 31.03.2023 19:57, Andrew Cooper wrote: > This started by noticing the dubious Fam17h check in > arch_ioreq_server_get_type_addr(), and then realising that checking the host > CF8_EXT setting is utterly bogus for the guest <-> qemu emulation path. > > What should be consulted here is the guest's MSR_AMD64_NB_CFG setting, but a) > there isn't one, and b) the vestigial remnants of the cross-vendor migration > logic cause MSR_AMD64_NB_CFG to be unconditionally read-as-zero, making the > CF8_EXT path unused by any suitably-written OS in the first place. > > MSR_AMD64_NB_CFG really has been removed on Fam17h (it's now just a read-zero, > write-discard stub), and the ECS extension is unconditionally active, meaning > it is not correct for Xen to ignore the ExtRegNo field on newer AMD CPUs. I don't buy "unconditionally active". Whether to enable this by default is up to firmware; I view it as not unlikely that some firmware actually have a setup control for it. Fam17 controls it through D1[8-F]F4x044:0, while Fam19 has D1[8-F]F0xC00:0 for this purpose. (I've had a work item for quite some time to actually make use of this bit to enable ECS.) > It turns out that Xen did even have this behaviour in 4.5 and earlier, with > this problematic CF8_EXT checking being added in 4.6. Therefore, revert back > to Xen's older behaviour - it is objectively less wrong than the current > logic. > > While fixing this, get rid of hvm_pci_decode_addr() - it is more complicated > to follow (and to call) than using the CF8* macros in the calling context. > Rename CF8_ADDR() to CF8_REG() to better describe what it does, and write a > comment explaining all about CF8/CFC accesses. > > There's one rare case when CF8_EXT is visible to guests, and that is for a > pinned hwdom. Right now, we permit such a dom0 to modify the CF8_EXT bit, but > this seems like a very unwise idea. Leave a TODO for people to consider. > > Fixes: e0fbf3bf9871 ("x86/AMD: correct certain Fam17 checks") Therefore I'm not convinced this Fixes: tag is warranted. > Fixes: 2d67a7a4d37a ("x86: synchronize PCI config space access decoding") I'm also curious which particular aspect of that change you are considering to be fixed here. Your claim about behavior being reserved is perhaps okay as far as hardware is concerned, but by removing the checks you e.g. misguide xsm_pci_config_permission() in case it handles certain register ranges specially. Dealing with that was, according to the description, one of the purposes of the commit above (it's been long enough, so I can only go from the description in git). > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -248,20 +248,6 @@ void register_g2m_portio_handler(struct domain *d) > handler->ops = &g2m_portio_ops; > } > > -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, > - pci_sbdf_t *sbdf) > -{ > - ASSERT(CF8_ENABLED(cf8)); > - > - sbdf->bdf = CF8_BDF(cf8); > - sbdf->seg = 0; > - /* > - * NB: the lower 2 bits of the register address are fetched from the > - * offset into the 0xcfc register when reading/writing to it. > - */ > - return CF8_ADDR_LO(cf8) | (addr & 3); > -} I have to admit that I'm surprised that you fold replacing of this function (purely mechanical afaict) into a change with a significant functional change. Wouldn't you agree that this may better be split off? > @@ -1104,6 +1092,11 @@ static int cf_check write_msr( > if ( !is_hwdom_pinned_vcpu(curr) ) > return X86EMUL_OKAY; > if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || > + /* > + * TODO: this is broken. What happens when dom0 is pinned but > + * can't see the full system? CF8_EXT probably ought to be a > + * Xen-owned setting, and made symmetric across the system. > + */ > ((val ^ temp) & ~(1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT)) ) > goto invalid; > if ( wrmsr_safe(MSR_AMD64_NB_CFG, val) == 0 ) What do you mean by "can't see the full system"? Originally Linux used only the MSR view of the bit to enable ECS, but this was specifically extended to prefer the PCI config space view instead (24d9b70b8c67 "x86: Use PCI method for enabling AMD extended config space before MSR method"). Since here we're dealing with the MSR flavor, and since Linux shouldn't be using this anymore (due to checking whether the bit is clear before trying to set it), we may be okay with simply purging this code if we don't care about very old Linux Dom0 anymore (or if we use your argument of it not reliably affecting the entire system). As to the setting becoming Xen-owned: Dom0 being responsible for (almost) all of PCI, it would be somewhat odd to take away from it this level of control. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 13:27:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 13:27:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517449.802772 (Exim 4.92) (envelope-from ) id 1pjKDG-000345-QL; Mon, 03 Apr 2023 13:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517449.802772; Mon, 03 Apr 2023 13:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjKDG-00033y-Mz; Mon, 03 Apr 2023 13:27:10 +0000 Received: by outflank-mailman (input) for mailman id 517449; Mon, 03 Apr 2023 13:27:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjKDE-00033s-Im for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 13:27:08 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 388c2b9d-d223-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 15:27:05 +0200 (CEST) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 09:26:52 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5410.namprd03.prod.outlook.com (2603:10b6:208:29c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 13:26:49 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 13:26:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 388c2b9d-d223-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680528425; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=t1fkTL8HsOL6DzgWpK3QGHaxBLd4HWSxC4csE9hEYPc=; b=JQXzfvWZC0vM2zpdvo1C59xE1WTUfg3BtehPIaASzi9dRGos/Pm1gEhB +BA2LW1BIKxcZ/YNxPNU77OYRoUB7g5s/XeOA5+SzNuj12Bo2Xxgo4bux HK6P0Uzrbv1D8z/L4YPDOxI+MZoLM92pn20Rxgx+J6jTkYp4BMOWcLW5U c=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 106547825 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lVpx7KibkeP8VPf9HdoBkkubX161RxEKZh0ujC45NGQN5FlHY01je htvUGnUbPnca2Dwe4olOYy0p0MBu8fTy9A3QFM++ysyRn8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQcLQoMNjCcwNipnr/jUttmmYcdN+j0adZ3VnFIlVk1DN4AaLWaGeDv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilIvluSyWDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHulBd5NROflnhJsqFSP61VQIQUPbGuygN2mt2fhSu0OC VNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQEnsIrQT0h1 neSgsjkQzdotdW9Vna15rqS6zSoNkAowXQqYCYFSU4A/IPlqYRq1BbXFI4/T+iyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsjA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:MY017a18yJU3K80J7x1G2wqjBAkkLtp133Aq2lEZdPWaSK2lfq eV7ZImPH7P+VEssRQb8+xoV5PsfZqxz/JICMwqTNSftOePghrVEGgg1/qe/9XYcxeOidK1rJ 0QDZSWaueRMbEKt7ef3ODiKadY/DDvysnB7ts2jU0dLz2CDZsO0+4TMHf/LqQZfmd77LMCZe uhz/sCiTq8WGgdKv+2DmMCWIH41qf2vaOjTx4aJgItrDKDhzOw6LL8DnGjr2wjegIK77c+0H TP1zf07KW7s/2911v12mLJ445N8eGRuudrNYijitU1Nj6psAquaYh7MofyxAwInA== X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="106547825" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mB1mmXF+aylgBGjOWaPSQlAFMio6He+ps3MaWmk1+PqKcp02EeGbaWQoLXrovAtw41RC0MDy1cB0Yf5hCJWlkTLYMYeSntea2+xhKXqeVVASI1ohy3noBUUwggMQS/lpvP/ftCO0XHl4/OCDav7Vc7YNqhbn8E45YCBE7SK//Yr/zhGc0EzRoGG3aopIn8zf6UtchctwFt8Bev4RIeCGREXbRG+pOhyf4fH3Cw7Z2NJMkTPiuaMeZpcYmUbHTIu7dxKsiqVjOsWhRF434E6QfcqXL9zzR0ejPX3kkSkWIgK6fhazsesOeJmDtKwcOfYTnpyXQIAFqRegIMdAJOxeUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iuyfu2/BsHus3kHZGId7MNczCmHstVKYik7fQ1vMBSI=; b=mXe2PDdASLPCtoeViNadZDC16EsdXq7ZDpcQ+uMHM2G66RP/wLaxWwsAA9DLVBetQIFq8T2BSUSdtUOP5v/fbKMbEC7Y7Zg6ZzBkTlSs74TSOsDYTbnUwW55WOCf8inEOT49Cyb1R7TwKXKv7uNKNzpve7DwBsVVbd7+Dwp24KtP6aGETQ2l16q6pMBATlHkGdyDDmC/runZNmPQek2N1L506zrcyBUYACPgCngpY1T8aL9VT5HDKGyHzK0n/qGAcok2RferIDq030L1hhtO7POwwga0ax8RWeqrJdOcDevM5VcX7FGCs7i/sBVRl8YgD8Vd8zOyw4KHfzto9AHP0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iuyfu2/BsHus3kHZGId7MNczCmHstVKYik7fQ1vMBSI=; b=Q3dPnquMKELdRylRMWfWtLDun0HpNN39Jxm1MkXL2K+dFUICxAbtz5hg5h0GRV1eP/uhuKYNxlv2ZQLxYYVS1OYIQmGwKmSurrfw9F1Ezg6jCJ3RMXoojqhoXZ32FVXnGtq1zhwbU+lDZbpzxTXIawlqGF7fUQHeNA2gVB4kptM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 15:26:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Message-ID: References: <20230331175719.500285-1-andrew.cooper3@citrix.com> <4b76def9-9940-ccf0-8050-12ddf2c1253c@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4b76def9-9940-ccf0-8050-12ddf2c1253c@citrix.com> X-ClientProxiedBy: LO2P265CA0142.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::34) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5410:EE_ X-MS-Office365-Filtering-Correlation-Id: 47bd20a4-5c87-4e72-e82c-08db34471472 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jXyyPQ0ViY0rMp6AJmgwsTKxLZVIEgO7N6qSzD11XuTq1viEP5lRDtFJUD2dIduyk+nN/xIfz54a7o4NMCEiygbwrAnBAUAxpnGHF47NNnALnk7Z4iztDsed7nWKUNzt92UspqFFn9dYKEPkfQBWmaHFtg+TivYWS1rvQgBmdOgiTMPfOi3GK9BgB/FpUaCXAZKRNNiUzUKimoqoEZ5JOBMq0cTPqulw48NueAMzBOhSx9ZwXx76ak0ije8RPnEMRApFcCxKc2GoXEsLY/9ZpvcbeUU1x8H2qiopsYbnnJSS2GpcYzD4tipZnKUYLNz0tKfAiRL6XvUjQ8daU7A+758FLgvmWWX5Dm/Fwjm5xt7KTblJtXIh8uUu7PAZZTtIbK0idyifckcnCCPfStWYffjztjr3/IEwOngGdsOR8ambDeZVBBhV1iwIVkszFwYhdWLRz4Y/AAv7MrjfnbJtmvi1cLe2x0Uj7fX17v1BuQKPe+sfC0R0piwUVoq+9kXDuaPTDhLvOShGdtxqY6g/QIUEdBy6tJ6UeAKYzIb1cj0BaJFVGk39Q9zCOwMBTxS8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199021)(38100700002)(30864003)(5660300002)(83380400001)(54906003)(316002)(6636002)(6486002)(33716001)(478600001)(186003)(53546011)(86362001)(6666004)(9686003)(26005)(6512007)(6506007)(82960400001)(85182001)(41300700001)(8676002)(4326008)(66556008)(6862004)(66946007)(66476007)(8936002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2tnMHZ4Z25PaVFHbnVRM1I3Z0pUU3lzUGJIcEs2bFJUbHpDcU10SE1LS2hG?= =?utf-8?B?WWxVcHhmUWtzV0hqZW4xbGZBU3B4NCtxS2FYTVhKNVdNRi9VUUlGYkM0VkRC?= =?utf-8?B?eW5ydDJmWmxheTRSdUwySFpBTEYxaUxZOWVtUTRiRHQ1eWRHbHgza2ZaNFpY?= =?utf-8?B?bU5WTVhSYmxaQXJ1QXZUbjVab0N3bUhHTlhTS1djdXFsbCtMVGMxRmpCd0tB?= =?utf-8?B?VHJZMExVK0tIOWxIMkJjVWRqNy9Ob1pHOU9aWUV4bVd6YWM1azFZSWlQUmx0?= =?utf-8?B?dUdReUROelZpR3RqTGFwS1lDRTBhWGRUbE0zNisrNGVubE96V0ZlSlRsVSta?= =?utf-8?B?YkFwTW5LRFpucU5jOU81bTBJLzh4TW5FcmEya2NnL0MxTUdIMFZZYUxrZ3ps?= =?utf-8?B?RXBldkJPeE9SR3hjTEhCUndFejNoNzVVaHE2NENRNHc2N0EzUnZpL1NDbEF3?= =?utf-8?B?enJNZUVTS0VNTm1Qam8ydlUzWDBwV2JPcnR6aERXcXZCRTR1L3ZBSE9uR3FV?= =?utf-8?B?cVdvS3J2dDRxT3RWTXJRUFA0MllvMlZMaWdMbTVPU0xXb3pPZFlCY2gxbGtO?= =?utf-8?B?WFpNRDV5eXQ3d24raXdHUGdUdjFxZnRBR2poWUZXaHE4TFdsU0tLbEdFelpw?= =?utf-8?B?cm1hUzlzRFY5WUh1Vm4rMlhvemNhUEtHZXh4RnBYTjlrUVQrZFZCbHhWREFu?= =?utf-8?B?dm1ndStObzNqLzBHaWVMWHhnbmxiN0gzbFNpYmFOQndYbHpueXQ0aHJBcVlh?= =?utf-8?B?N2hlT2NZSTA0L1d0N3RmSVUraExRMUJoZVhZYStRdm1nb1FpL0s4cWN6MW96?= =?utf-8?B?YWFMUzNkU3hzM2d4T2Z6RXY5TkVPT1phK05OQklDaXNCSVdxQmxWZXJjNmE4?= =?utf-8?B?QXNBOWFDNDhOKytwaCtsZC9Bc3hOOXk1RjRteTRaLzNEWEVlcDJ0a3gyZ1JL?= =?utf-8?B?NUxDUXZaeThPNmNDSmNXWmxTOHVDOUkyYUsrRWVncTVlYVVUWWJNQUt4c1lu?= =?utf-8?B?Y3hnZTl5cXVSMmJRVG5keitlV3lCQ0liU2dYMHlReWhEZ0pTTTZ0QnJqMkZC?= =?utf-8?B?cjQ5S3lvWThaekFJeVh4bHFLaTNDY1BHcEZOZFdiZFlQazRIeVprTndCKzVJ?= =?utf-8?B?aFEzYXRwbmNjSGlHb2FDRGxnZE5SSmwrTTB1MWpkNzRXRkErY2ZHTTROUVZC?= =?utf-8?B?aWhndWxqUW96c1I2QVVjVXU2cUZaZVRnWWlkQ0NvdkZrVDJNM2tSYk1xODZ4?= =?utf-8?B?a0pCejdjcWh4eVRpbzJiaFFlcVQ1YWF3RGhIbHBCeTVPSjg0VkhIZmZ2MTRE?= =?utf-8?B?aVBJU3RRUjRObURCRXpDdHowaGhjd1ViNkFBeWpGUE9hVGxidlo5VXExWnhx?= =?utf-8?B?Q3Mxa2dyUTRaMUxHU05IQ2FWOWlOa2JPcmUwdnBxUzFsKzZKMUI5QzA0NElz?= =?utf-8?B?MHhYVzNFZHZjbDI5QjRWb3dkeWJnbnZneEVkdUhXY1NsTGU4LytBUG9xQ0RJ?= =?utf-8?B?N3hMYnZIK3R6Z3F1OGI1SzBmbjVLR094dEFzVzA1cTZJWUloVXlNUEtzaHZn?= =?utf-8?B?bTFlVW5PL2VudUwrdDUvRWg0aWd2SEVxcXNUSDZNZXRFYmRCWGJOeEtCNXhR?= =?utf-8?B?MXlLSXJKU0p6SVVsYWN1WDBZRmpIUm9mNHByVk9WTWJ1ZFVRYTkvcVZzQVd3?= =?utf-8?B?N2U4OEFWa2grclNYOWdMQ2lqaWs5NTZ1ZmEvNjZrdHdKNlBibDZrdGVtOXZ2?= =?utf-8?B?dEJ4TkdKRmRySXRzaHQrZWxDeWkzYnVsZ2FuSWE0TzVWU21pUFhoenErZDV3?= =?utf-8?B?OG55MGJmbkcvbU1aYUJQaXhEdFlVaU5XNUx0K3BWMGoyNFdEbE1xZWRraVNB?= =?utf-8?B?V1BVVkorZDVTZUVVTnlxYzBUdnZiakpUQ09qdEVYY29qdVR2UWxObUJsWjVK?= =?utf-8?B?NkZReXRGenlaVmpmUTgzQ3gyRGNycmh6bW0zMVZyQng4eGk3S1ZTRDZxM2sx?= =?utf-8?B?R2pYVkhCaWRDa1MwZ3hJVWdpSnZnYktQakxqa3drVmxjV0hXbkNqQkEyTlJI?= =?utf-8?B?cDZVNE5FL2pBQ2svZUp6Q2hhRE9WcHhVTUhTd1FnRHdOTVZkTGp5Y3pjeEhk?= =?utf-8?Q?V7IksAk/UbNk05GX18Sqa16Gb?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kjB8EoHMnohUkQpwDZBCNxQqQVA6tW7vHXHcWQZbtwDOubwSdaMFn3w1uUmXw919FXyIZhLBjllbS4Ldzj5TSeMN1kTQsK9xO5HKRBdXScQ5h6Nd757nwdU4kurqtKNGIsg6qu2gKpH3k3bMBKuf2Bdzx2Jii4BKGaTk/3VneHai2AwBLmu3hXQIC/d3SbkzT/DE/AliN0N2FGHUVXJYqni3V6jaCoJxb3k+Jo2JiSDifza/ZBvWGSjw/R2R0fcWk9ymGXVRUv/1+9pVjUQ9N3XwAg39ZMVqX26kRYE8zre7qVND7/WtxWVVMZnR90rbLYkAKWU5urVyd0aVkHyLKceL4Uq0QRTYcw2txLY/nssbaIilUK+gJo9qre+rUTq0l+e1W6MqJ4Vxek0UYtqvFwQQzEU0PCcyFnL/YkT3hIk6ovEthu18l01q6x5nH1/TwAuBEHpXgN2YeS+KS2uLaJR0s6NEmN/IFHzNchBV4/0/8o/c1Gz7X+afllrrNPX4GGGvqivxLCFPxueZ4sYpXdJuu7e6skztEi/zR1RW4uXeJQcrBM9rAMP0ourwghZgO8+a5qz4hqoXs2Puj/Oh/cEzwE4LD1zEb1cl4+Tit2+KrW1hBLiQxJMFekjfpBtVLRv+mq3mGU1sxLWih6a1+GniiSiCNiDD42oNsyubf6DcKXlC0HoGgo0aJeg+eILDBcJ1DTQb153heMVhcfC319OtbgCEGY24OO3b7cEkMnJx8PHENLC1eaEyRyvaa2nsQYyQ5+FRHMff7MCX+r+5djmBWWye1fy69JiTAjWrYHN6dOl2NOD7WEAWGKIrEVoC X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47bd20a4-5c87-4e72-e82c-08db34471472 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 13:26:49.5696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mx4C2QJvVZ6JByLslqBYMqMTTvM8UDNEq8Qy6JDM7/hOx5G4TGU0ZIXUCXq0SZ/rcggsztQmhQuDxJ/OeS8FsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5410 On Mon, Apr 03, 2023 at 11:16:52AM +0100, Andrew Cooper wrote: > On 03/04/2023 9:57 am, Roger Pau Monné wrote: > > On Fri, Mar 31, 2023 at 06:57:19PM +0100, Andrew Cooper wrote: > >> This started by noticing the dubious Fam17h check in > >> arch_ioreq_server_get_type_addr(), and then realising that checking the host > >> CF8_EXT setting is utterly bogus for the guest <-> qemu emulation path. > >> > >> What should be consulted here is the guest's MSR_AMD64_NB_CFG setting, but a) > >> there isn't one, and b) the vestigial remnants of the cross-vendor migration > >> logic cause MSR_AMD64_NB_CFG to be unconditionally read-as-zero, making the > >> CF8_EXT path unused by any suitably-written OS in the first place. > >> > >> MSR_AMD64_NB_CFG really has been removed on Fam17h (it's now just a read-zero, > >> write-discard stub), and the ECS extension is unconditionally active, meaning > >> it is not correct for Xen to ignore the ExtRegNo field on newer AMD CPUs. > >> > >> It turns out that Xen did even have this behaviour in 4.5 and earlier, with > >> this problematic CF8_EXT checking being added in 4.6. Therefore, revert back > >> to Xen's older behaviour - it is objectively less wrong than the current > >> logic. > >> > >> While fixing this, get rid of hvm_pci_decode_addr() - it is more complicated > >> to follow (and to call) than using the CF8* macros in the calling context. > >> Rename CF8_ADDR() to CF8_REG() to better describe what it does, and write a > >> comment explaining all about CF8/CFC accesses. > >> > >> There's one rare case when CF8_EXT is visible to guests, and that is for a > >> pinned hwdom. Right now, we permit such a dom0 to modify the CF8_EXT bit, but > >> this seems like a very unwise idea. Leave a TODO for people to consider. > > One weirdness I've noticed is that for vPCI we decode the accesses > > taking the extended CF8 bit after this change, but then if the access > > is relayed to the hardware using vpci_{read,write}_hw it will be > > forwarded to the hardware using pci_conf_{read,write} which > > doesn't have support for CF8_EXT. So if the underlying hardware > > doesn't have MMCFG support and the reg is > 255 it will be dropped. > > It is important to stress that this change does not influence whether > the guest issues ECS accesses or not.  All it does is change Xen's > handling of such accesses. > > Previously vPCI blindly ignored ECS accesses, so the vPCI layer > effectively truncated them to BCS accesses. > > Now, from your analysis, when MMCFG isn't active, Xen's PCI layer will > effectively terminate ECS accesses with default behaviour, even on > systems where IO ECS is available. > > So we've changed one valid behaviour for a different valid behaviour. Given vPCI is currently limited to PVH dom0 I doubt there are many systems capable of running PVH dom0 but not having MMCFG support. Best way to fix would be to implement ECS accesses in pci_conf_{read,write}() if the register is > 255 and there's no MMCFG. > > (Quick tangent...  Our PCI handling is currently very dumb.  > pci_mmcfg_read() returns its value by pointer but the callers never > check.  Swapping it to return by value would improve code gen quite a > lot.  Also, when MMCFG is active we still pass BCS accesses to IO ports.) I wonder if it's really preferred to access registers below 255 using the IO ports, as Linux seems to do the same (prefer IO port access if possible). > So I think we do want to improve Xen's general behaviour too, but this > difference here doesn't concern me. > > > > >> Fixes: e0fbf3bf9871 ("x86/AMD: correct certain Fam17 checks") > >> Fixes: 2d67a7a4d37a ("x86: synchronize PCI config space access decoding") > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Jan Beulich > >> CC: Roger Pau Monné > >> CC: Wei Liu > >> > >> Whoever reviewed those two patches originally was clearly a fool... > >> --- > >> xen/arch/x86/hvm/io.c | 24 ++++++------------------ > >> xen/arch/x86/hvm/ioreq.c | 19 ++----------------- > >> xen/arch/x86/include/asm/hvm/io.h | 4 ---- > >> xen/arch/x86/include/asm/pci.h | 26 ++++++++++++++++++++++++-- > >> xen/arch/x86/pv/emul-priv-op.c | 19 ++++++------------- > >> 5 files changed, 38 insertions(+), 54 deletions(-) > >> > >> diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c > >> index 5ae209d3b6b3..b0d3c236e985 100644 > >> --- a/xen/arch/x86/hvm/io.c > >> +++ b/xen/arch/x86/hvm/io.c > >> @@ -248,20 +248,6 @@ void register_g2m_portio_handler(struct domain *d) > >> handler->ops = &g2m_portio_ops; > >> } > >> > >> -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, > >> - pci_sbdf_t *sbdf) > >> -{ > >> - ASSERT(CF8_ENABLED(cf8)); > >> - > >> - sbdf->bdf = CF8_BDF(cf8); > >> - sbdf->seg = 0; > >> - /* > >> - * NB: the lower 2 bits of the register address are fetched from the > >> - * offset into the 0xcfc register when reading/writing to it. > >> - */ > >> - return CF8_ADDR_LO(cf8) | (addr & 3); > >> -} > >> - > >> /* vPCI config space IO ports handlers (0xcf8/0xcfc). */ > >> static bool cf_check vpci_portio_accept( > >> const struct hvm_io_handler *handler, const ioreq_t *p) > >> @@ -275,7 +261,7 @@ static int cf_check vpci_portio_read( > >> { > >> const struct domain *d = current->domain; > >> unsigned int reg; > >> - pci_sbdf_t sbdf; > >> + pci_sbdf_t sbdf = {}; > >> uint32_t cf8; > >> > >> *data = ~(uint64_t)0; > >> @@ -292,7 +278,8 @@ static int cf_check vpci_portio_read( > >> if ( !CF8_ENABLED(cf8) ) > >> return X86EMUL_UNHANDLEABLE; > >> > >> - reg = hvm_pci_decode_addr(cf8, addr, &sbdf); > >> + sbdf.bdf = CF8_BDF(cf8); > >> + reg = CF8_REG(cf8) | (addr & 3); > >> > >> if ( !vpci_access_allowed(reg, size) ) > >> return X86EMUL_OKAY; > >> @@ -308,7 +295,7 @@ static int cf_check vpci_portio_write( > >> { > >> struct domain *d = current->domain; > >> unsigned int reg; > >> - pci_sbdf_t sbdf; > >> + pci_sbdf_t sbdf = {}; > >> uint32_t cf8; > >> > >> if ( addr == 0xcf8 ) > >> @@ -323,7 +310,8 @@ static int cf_check vpci_portio_write( > >> if ( !CF8_ENABLED(cf8) ) > >> return X86EMUL_UNHANDLEABLE; > >> > >> - reg = hvm_pci_decode_addr(cf8, addr, &sbdf); > >> + sbdf.bdf = CF8_BDF(cf8); > >> + reg = CF8_REG(cf8) | (addr & 3); > >> > >> if ( !vpci_access_allowed(reg, size) ) > >> return X86EMUL_OKAY; > >> diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c > >> index 0bdcca1e1a5f..325a9d118e52 100644 > >> --- a/xen/arch/x86/hvm/ioreq.c > >> +++ b/xen/arch/x86/hvm/ioreq.c > >> @@ -285,27 +285,12 @@ bool arch_ioreq_server_get_type_addr(const struct domain *d, > >> (p->addr & ~3) == 0xcfc && > >> CF8_ENABLED(cf8) ) > >> { > >> - unsigned int x86_fam, reg; > >> - pci_sbdf_t sbdf; > >> - > >> - reg = hvm_pci_decode_addr(cf8, p->addr, &sbdf); > >> + pci_sbdf_t sbdf = { .bdf = CF8_BDF(cf8) }; > >> + unsigned int reg = CF8_REG(cf8) | (p->addr & 3); > >> > >> /* PCI config data cycle */ > >> *type = XEN_DMOP_IO_RANGE_PCI; > >> *addr = ((uint64_t)sbdf.sbdf << 32) | reg; > >> - /* AMD extended configuration space access? */ > >> - if ( CF8_ADDR_HI(cf8) && > >> - d->arch.cpuid->x86_vendor == X86_VENDOR_AMD && > >> - (x86_fam = get_cpu_family( > >> - d->arch.cpuid->basic.raw_fms, NULL, NULL)) >= 0x10 && > >> - x86_fam < 0x17 ) > >> - { > >> - uint64_t msr_val; > >> - > >> - if ( !rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) && > >> - (msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT)) ) > >> - *addr |= CF8_ADDR_HI(cf8); > >> - } > >> } > >> else > >> { > >> diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h > >> index 54e0161b492c..3f3fb6403ccb 100644 > >> --- a/xen/arch/x86/include/asm/hvm/io.h > >> +++ b/xen/arch/x86/include/asm/hvm/io.h > >> @@ -144,10 +144,6 @@ void stdvga_deinit(struct domain *d); > >> > >> extern void hvm_dpci_msi_eoi(struct domain *d, int vector); > >> > >> -/* Decode a PCI port IO access into a bus/slot/func/reg. */ > >> -unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, > >> - pci_sbdf_t *sbdf); > >> - > >> /* > >> * HVM port IO handler that performs forwarding of guest IO ports into machine > >> * IO ports. > >> diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h > >> index f4a58c8acf13..3b814f4ebacf 100644 > >> --- a/xen/arch/x86/include/asm/pci.h > >> +++ b/xen/arch/x86/include/asm/pci.h > >> @@ -3,10 +3,32 @@ > >> > >> #include > >> > >> +/* > >> + * PCI config space accesses with CF8/CFC: > >> + * > >> + * 1) Write {Enable | BDF | Reg} to CF8 to set an address > >> + * 2) Read or write CF{C..F} to access the register > >> + * > >> + * For sub-dword register accesses, the bottom two register address bits come > >> + * from the CF{C..F} address, not from CF8. > >> + * > >> + * AMD have extention to this protocol to access PCIe Extend Config Space by > >> + * storing the 4 extra register address bits in the penultimate nibble of CF8. > >> + * This extention: > >> + * - Is unconditionally active on Fam17h and later > >> + * - Has model specific enablement on Fam10h thru Fam16h > >> + * - Has reserved behaviour in all other cases, including other vendors > >> + * > >> + * For simplicity and because we are permitted to, given "reserved", Xen > >> + * always treats ECS as active when emulating guest PCI config space accesses. > >> + */ > >> #define CF8_BDF(cf8) ( ((cf8) & 0x00ffff00) >> 8) > >> -#define CF8_ADDR_LO(cf8) ( (cf8) & 0x000000fc) > >> -#define CF8_ADDR_HI(cf8) ( ((cf8) & 0x0f000000) >> 16) > >> #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000)) > >> +#define CF8_REG(cf8) \ > >> + ({ \ > >> + unsigned int _c = cf8; \ > >> + ((_c & 0x0f000000) >> 16) | (_c & 0xfc); \ > >> + }) > > What happens on Intel when the bit is set, is it just ignored? > > "the bit" => the ECS nibble, or the CF8_EXT bit? The ECS nibble. > > The ECS nibble is ignored on Intel AFAICT, while the CF8_EXT bit is in a > very AMD-only MSR, so won't exist on Intel. > > > We only allow such accesses for dom0 anyway. > > And guests running on AMD hardware where CF8_EXT is active on the > northbridge of the core we are instantaneously scheduled on. > > >> > >> #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \ > >> || id == 0x01268086 || id == 0x01028086 \ > >> diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c > >> index 5da00e24e4ff..008367195c78 100644 > >> --- a/xen/arch/x86/pv/emul-priv-op.c > >> +++ b/xen/arch/x86/pv/emul-priv-op.c > >> @@ -245,19 +245,7 @@ static bool pci_cfg_ok(struct domain *currd, unsigned int start, > >> if ( ro_map && test_bit(machine_bdf, ro_map) ) > >> return false; > >> } > >> - start |= CF8_ADDR_LO(currd->arch.pci_cf8); > >> - /* AMD extended configuration space access? */ > >> - if ( CF8_ADDR_HI(currd->arch.pci_cf8) && > >> - boot_cpu_data.x86_vendor == X86_VENDOR_AMD && > >> - boot_cpu_data.x86 >= 0x10 && boot_cpu_data.x86 < 0x17 ) > >> - { > >> - uint64_t msr_val; > >> - > >> - if ( rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) ) > >> - return false; > >> - if ( msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT) ) > >> - start |= CF8_ADDR_HI(currd->arch.pci_cf8); > >> - } > >> + start |= CF8_REG(currd->arch.pci_cf8); > >> > >> return !write ? > >> xsm_pci_config_permission(XSM_HOOK, currd, machine_bdf, > >> @@ -1104,6 +1092,11 @@ static int cf_check write_msr( > >> if ( !is_hwdom_pinned_vcpu(curr) ) > >> return X86EMUL_OKAY; > >> if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || > >> + /* > >> + * TODO: this is broken. What happens when dom0 is pinned but > >> + * can't see the full system? CF8_EXT probably ought to be a > >> + * Xen-owned setting, and made symmetric across the system. > >> + */ > > I would assume CF8_EXT would be symmetric across the system, specially > > given that it seems to be phased out and only used in older AMD > > families that where all symmetric? > > The CF8_EXT bit has been phased out.  The IO ECS functionality still exists. > > But yes, the more I think about letting dom0 play with this, the more I > think it is a fundamentally broken idea...  I bet it was from the very > early AMD Fam10h days where dom0 knew how to turn it on, and Xen was > trying to pretend it didn't have to touch any PCI devices. It seems to me Xen should set CF8_EXT on all threads (when available) and expose it to dom0, so that accesses using pci_{conf,write}_read() work as expected? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 13:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 13:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517456.802787 (Exim 4.92) (envelope-from ) id 1pjKQh-0005Xq-9R; Mon, 03 Apr 2023 13:41:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517456.802787; Mon, 03 Apr 2023 13:41:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjKQh-0005Xj-6V; Mon, 03 Apr 2023 13:41:03 +0000 Received: by outflank-mailman (input) for mailman id 517456; Mon, 03 Apr 2023 13:41:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjKQf-0005Xd-PG for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 13:41:01 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b01bb91-d225-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 15:40:59 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id v1so29397987wrv.1 for ; Mon, 03 Apr 2023 06:40:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b01bb91-d225-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680529259; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pJFLvj+kzgAAuR4I2/Wel89bouBKjG12WhBkLGSFURQ=; b=WHSRr8THUJaSUtEklr0o/86/+GjCz1jnc8gSlIKp88U5RvaDwKA84e/h9WXAM9LcSx Bf3unCTzlPfSWHfIvfYn7KrNnuBRtxse4398WVHT8YZjF0hvq91YFJdzDESZM7HWYx4f iVQBdNulbpw4yonCU2ok6LfYZvS/MdyBZwNpq7LaumfqCoWaFqGhUODfy6Ge+2b/uIG3 0937Eo3rQPJnVm5jENJqn4NK81h1iT59aZod7IhZUt/FcQ4ULX8xq5P/qv2anetDp+8J DQjJYwdkt5l23hGbfA3CfFcRuvVoX6k69b1rxxiUjKBbfq39mpWi69ramoCNyLMaz31Q lh4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529259; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pJFLvj+kzgAAuR4I2/Wel89bouBKjG12WhBkLGSFURQ=; b=QuRgrTObXiRVSryDh/7E35i36EuvqFQ5sw4WZ5mfbX00fj5HkSBPC2JcRmCkeAa7G+ WD6bX6yRQMx/LX/GS281m2ASnGRhPDjPaaWkVD763Z/mhAeP/tkORhKfNq/KEZ4qsBUS W9dhWF9d9AuJJRt/iurB1eXijQ5ospf2U9ohb2IgvFkub8o4mwcnscFhNo8DgFSnU3jp 7kdWK142PpewD7UrZt39eJn/iZgJ1pMLxEV2lSWRl8dx/EEODYi/HGHxYGjUf0B5MS48 t98ZzDu7mCmKKYkGQCllSxgCk67NPBduXR3c4CYrqpUhwHfvRvj/tJXs2C+M/wT4d1IK A8lw== X-Gm-Message-State: AAQBX9f7nvusqwoa+0E/HB9NIwJebMbaa4l1tTJvn+9mtKGA4h8QXKGb uYLaqooKCSLSyerflAvad+vC3lRPf+Qtn6wrf1bffpO3OqE= X-Google-Smtp-Source: AKy350aDobyDVG9z/7nOQ+1yOitdFN3I0fdvQgDKY5Cs8cNF/SeNwb6g5B4WY2Q9UJxleNqCuvKRjxmjXSPmDVAk7eE= X-Received: by 2002:adf:e98d:0:b0:2c5:7eb5:97a6 with SMTP id h13-20020adfe98d000000b002c57eb597a6mr7693051wrm.12.1680529258904; Mon, 03 Apr 2023 06:40:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Mon, 3 Apr 2023 09:40:22 -0400 Message-ID: Subject: Re: Best way to use altp2m to support VMFUNC EPT-switching? To: "Johnson, Ethan" Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" Content-Type: multipart/alternative; boundary="00000000000082fece05f86eb58f" --00000000000082fece05f86eb58f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 29, 2023 at 10:29=E2=80=AFPM Johnson, Ethan wrote: > > On 2023-03-16 02:14:18 +0000, Andrew Cooper wrote: > > Ok, so there is a lot here. Apologies in advance for the overly long > > answer. > > > > First, while altp2m was developed in parallel with EPTP-switching, we > > took care to split the vendor neutral parts from the vendor specific > > bits. So while we do have VMFUNC support, that's considered "just" a > > hardware optimisation to speed up the HVMOP_altp2m_switch_p2m hypercall= . > > > > But before you start, it is important to understand your security > > boundaries. You've found external mode, and this is all about > > controlling which aspects of altp2m the guest can invoke itself, and > > modes other than external let the guest issue HVMOP_altp2m ops itself. > > > > If you permit the guest to change views itself, either with VMFUNC, or > > HVMOP_altp2m_switch_p2m, you have to realise that these are just > > "regular" CPL0 actions, and can be invoked by any kernel code, not just > > your driver. i.e. the union of all primary and alternative views is on= e > > single security domain. > > > > For some usecases this is fine, but yours doesn't look like it fits in > > this category. In particular, no amount of protection on the trampolin= e > > pages stops someone writing a VMFUNC instruction elsewhere in kernel > > space and executing it. > > > > (I have seen plenty of research papers try to construct a security > > boundary around VMFUNC. I have yet see one that does so robustly, but = I > > do enjoy being surprised on occasion...) > > > > The first production use this technology I'm aware of was Bitdefender's > > HVMI, where the guest had no control at all, and was subject to the > > permission restrictions imposed on it by the agent in dom0. The agent > > trapped everything it considered sensitive, including writes to > > sensitive areas of memory using reduced EPT permissions, and either > > permitted execution to continue, or took other preventative action. > > > > This highlights another key point. Some entity in the system needs to > > deal with faults that occur when the guest accidentally (or otherwise) > > violates the reduced EPT permissions. #VE is, again, an optimisation t= o > > let violations be handled in guest context, rather than taking a VMExit= , > > but even with #VE the complicated corner cases are left to the external > > agent. > > > > With HVMI, #VE (but not VMFUNC IIRC) did get used as an optimisation to > > mitigate the perf hit from Window's Meltdown mitigation electing to use > > LOCK'd BTS/BTC operations on pagetables (which were write protected > > behind the scenes), but I'm reliably informed that the hoops required t= o > > jump through to make that work, and in particular avoid the notice of > > PatchGuard, were substantial. > > > > Perhaps a more accessible example is > > https://github.com/intel/kernel-fuzzer-for-xen-project and the > > underlying libvmi. There is also a very basic example in > > tools/misc/xen-access.c in the Xen tree. > > > > For your question specifically about mapping other frames, we do have > > hypercalls to map other frames (its necessary for e.g. mapping BARs of > > passed-through PCI devices), but for obvious reasons, it's restricted t= o > > control software (Qemu) in dom0. I suspect we don't actually have a > > hypercall to map MMIO into an alternative view, but it shouldn't be har= d > > to add (if you still decide you want it by the end of this email). > > > > > > But on to the specifics of mapping the xAPIC page. Sorry, but > > irrespective of altp2m, that is a non-starter, for reasons that date > > back to ~1997 or thereabouts. > > > > It's worth saying that AMD can fully virtualise IPI delivery from one > > vCPU to another without either taking a VMExit in the common case, sinc= e > > Zen1 (IIRC). Intel has a similar capability since Sapphire Rapids > > (IIRC). Xen doesn't support either yet, because there are only so many > > hours in the day... > > > > It is technically possible to map the xAPIC window into a guest, and > > such a guest could interact the real interrupt controller. But now > > you've got the problem that two bits of software (Xen, and your magic > > piece of guest kernel) are trying to driver the same single interrupt > > controller. > > > > Even if you were to say that the guest would only use ICR to send > > interrupts, that still doesn't work. In xAPIC, ICR is formed of two > > half registers, as it dates from the days of 32bit processors, with a > > large stride between the two half registers. > > > > Therefore, it is a minimum of two separate instructions (set destinatio= n > > in ICR_HI, set type/mode/etc in ICR_LO) to send an interrupt. > > > > A common bug in kernels is to try and send IPIs when interrupts are > > enabled, or in NMI context, both of which could interrupt an IPI > > sequence. This results in a sequence of writes (from the LAPIC's point > > of view) of ICR_HI, ICR_HI, ICR_LO, ICR_LO, which causes the outer IPI > > to be sent with the wrong destination. > > > > Guests always execute with IRQs enabled, but can take a VMExit on any > > arbitrary instruction boundary for other reasons, so the guest kernel > > can never be sure that ICR_HI hasn't been modified by Xen in the > > background, even if it used two adjacent instructions to send the IPI. > > > > Now, if you were to swap xAPIC for x2APIC, one of the bigger changes wa= s > > making ICR a single register, so it could be written atomically. But > > now you have an MSR based interface, not an MMIO based interface. > > > > It's also worth noting that any system with >254 CPUs is necessarily > > operating in x2APIC mode (so there isn't an xAPIC window to map, even i= f > > you wanted to try), and because of the =C3=86PIC Leak vulnerability, Ic= eLake > > and later CPUs are locked into x2APIC mode by firmware, with no option > > to revert back into xAPIC mode even on smaller systems. > > > > On top of that, you've still got the problem of determining the > > destination. Even if the guest could send an IPI, it still has to know > > the physical APIC ID of the CPU the target vCPU is currently scheduled > > on. And you'd have to ignore things like the logical mode or > > destination shorthands, because multi/broadcast IPIs will hit incorrect > > targets. > > > > On top of that, even if you can determine the right destination, how > > does the target receive the interrupt? There can only be one entity in > > the system receiving INTR, and that's Xen. So you've got to pick some > > vector that Xen knows what to do with, but isn't otherwise using. > > > > Not to mention there's a(nother) giant security hole... A guest able to > > issue interrupts could just send INIT-SIPI-SIPI and reset the target CP= U > > back into real mode behind Xen's back. Xen will not take kindly to this. > > > > > > So while I expect there's plenty of room to innovate on the realm switc= h > > aspect of EPTP-switching, trying to send IPIs from within guest context > > is something that I will firmly suggest you avoid. There are good > > reasons why it is so complicated to get VMExit-less guest IPIs working. > > > > ~Andrew > > Thank you for the detailed answers and context. I am somewhat encouraged to > note that most of the roadblocks you mentioned are issues we've specifically > considered (and think we have solutions for) in our design. :-) We're using > some rather exotic compiler-based instrumentation on the guest kernel (plus > some tricks with putting the "secure realm"'s page tables in a nonoverlapping > guest-physical address range that isn't present in the primary p2m used b= y > untrusted code) to prevent the guest from doing things it isn't supposed to > with VMFUNC and (x2)APIC access, despite running in ring 0 within non-roo= t > mode. > > On a more concrete level, I am looking to do the following from within th= e > hypervisor (specifically, from within a new hypercall I've added): > > 1) Get some (host-)physical memory frames from the domain heap and "pin" them > to make sure they won't be swapped out. > > 2) Create an altp2m for the calling (current) domain. > > 3) Map some of the newly-allocated physical frames into both the domain's > primary p2m and its altp2m, with R/X permissions. > > 4) Map the rest of the physical frames into only the altp2m (as R/W), at = a > guest-physical address higher than the end of the main p2m's mapped range > (such that when the primary p2m is active, the guest cannot access these > pages without taking a hard VM-exit fault). > > I've been poring through Xen's p2m code (e.g. xen/arch/x86/mm/p2m.c) to try > to understand how to achieve these goals, but with little success. Comments > in the p2m code seem to be rather sparse, and mostly unhelpful for > understanding (without pre-understood context) what many of the functions do > and what is the intended workflow for using them. For instance, > similarly-named functions like guest_remove_page() and > guest_physmap_remove_page() seem to operate at different levels of > abstraction (in terms of memory management, refcount bookkeeping, etc.) but > it isn't externally obvious how they're meant to all fit together and be used > by client code. > > Any suggestions on which p2m (or other) APIs I should be focusing on, and how > they're meant to be used, would be greatly appreciated. I suppose in theory I > could just bypass p2m entirely, and populate one of the VMCS's EPTP-switching > array's slots directly with my own manually constructed paging hierarchy > (since I'm envisioning the memory layout of our "secure realm" as being quite > simple - it only needs a handful of pages). But I'd rather "color within the > lines" of the existing APIs if possible, especially since some of the pages > will need to be mapped into the existing primary p2m (for the "insecure > realm") as well. You can find an example work-flow here to create altp2m's and change memory permissions in the different views: https://github.com/xen-project/xen/blob/master/tools/misc/xen-access.c#L517= . To add a new page to the VM you can use xc_domain_populate_physmap_exact. If you add the page after the VM has already booted the main kernel is unaware of these extra pages that were added but that doesn't mean it can't try to poke them. Similarly, using any type of memory map to avoid the kernel accessing these pages is just wishful thinking, the memory map is after all just a hint to the OS what to look for, not an access-control mechanism. Also keep in mind that altp2m's get CoW populated from the hostp2m. You can still get your altp2m to be "only a couple pages" by either 1) ensuring no other pages ever get touched while running the vCPU with the altp2m as to not trigger the CoW mechanism; or 2) manually map change the memaccess permissions to n on every page you want to be in-accessible in the altp2m. You'll likely want to have pages like where the IDT and GDT is mapped into the altp2m, alongside the pagetable pages. An easy way to check what pages are needed for execution in a given code context is use the VM forking mechanism, create a fork at the point your code is that you want to run in the altp2m, singlestep the fork a single instruction, then examine the fork's EPT using xl debug-keys D. Anything you see that got mapped into the fork's memory would be similarly needed to be accessible in the altp2m. Cheers, Tamas --00000000000082fece05f86eb58f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Mar 29, 2023 at 10:29=E2=80=AFPM Johnson, = Ethan <ejohns48@cs.rocheste= r.edu> wrote:
>
> On 2023-03-16 02:14:18 +0000, Andrew C= ooper wrote:
> > Ok, so there is a lot here.=C2=A0 Apologies in ad= vance for the overly long
> > answer.
> >
> > Fi= rst, while altp2m was developed in parallel with EPTP-switching, we
>= > took care to split the vendor neutral parts from the vendor specific<= br>> > bits.=C2=A0 So while we do have VMFUNC support, that's con= sidered "just" a
> > hardware optimisation to speed up t= he HVMOP_altp2m_switch_p2m hypercall.
> >
> > But before = you start, it is important to understand your security
> > boundar= ies.=C2=A0 You've found external mode, and this is all about
> &g= t; controlling which aspects of altp2m the guest can invoke itself, and
= > > modes other than external let the guest issue HVMOP_altp2m ops it= self.
> >
> > If you permit the guest to change views its= elf, either with VMFUNC, or
> > HVMOP_altp2m_switch_p2m, you have = to realise that these are just
> > "regular" CPL0 action= s, and can be invoked by any kernel code, not just
> > your driver= . =C2=A0i.e. the union of all primary and alternative views is one
> = > single security domain.
> >
> > For some usecases th= is is fine, but yours doesn't look like it fits in
> > this ca= tegory.=C2=A0 In particular, no amount of protection on the trampoline
&= gt; > pages stops someone writing a VMFUNC instruction elsewhere in kern= el
> > space and executing it.
> >
> > (I have s= een plenty of research papers try to construct a security
> > boun= dary around VMFUNC.=C2=A0 I have yet see one that does so robustly, but I> > do enjoy being surprised on occasion...)
> >
> &= gt; The first production use this technology I'm aware of was Bitdefend= er's
> > HVMI, where the guest had no control at all, and was = subject to the
> > permission restrictions imposed on it by the ag= ent in dom0.=C2=A0 The agent
> > trapped everything it considered = sensitive, including writes to
> > sensitive areas of memory using= reduced EPT permissions, and either
> > permitted execution to co= ntinue, or took other preventative action.
> >
> > This h= ighlights another key point.=C2=A0 Some entity in the system needs to
&g= t; > deal with faults that occur when the guest accidentally (or otherwi= se)
> > violates the reduced EPT permissions. =C2=A0#VE is, again,= an optimisation to
> > let violations be handled in guest context= , rather than taking a VMExit,
> > but even with #VE the complicat= ed corner cases are left to the external
> > agent.
> >> > With HVMI, #VE (but not VMFUNC IIRC) did get used as an optimis= ation to
> > mitigate the perf hit from Window's Meltdown miti= gation electing to use
> > LOCK'd BTS/BTC operations on pageta= bles (which were write protected
> > behind the scenes), but I'= ;m reliably informed that the hoops required to
> > jump through t= o make that work, and in particular avoid the notice of
> > PatchG= uard, were substantial.
> >
> > Perhaps a more accessible= example is
> > https://github.com/intel/kernel-fuzzer-for-xen-project= and the
> > underlying libvmi.=C2=A0 There is also a very basic e= xample in
> > tools/misc/xen-access.c in the Xen tree.
> >= ;
> > For your question specifically about mapping other frames, w= e do have
> > hypercalls to map other frames (its necessary for e.= g. mapping BARs of
> > passed-through PCI devices), but for obviou= s reasons, it's restricted to
> > control software (Qemu) in d= om0.=C2=A0 I suspect we don't actually have a
> > hypercall to= map MMIO into an alternative view, but it shouldn't be hard
> &g= t; to add (if you still decide you want it by the end of this email).
&g= t; >
> >
> > But on to the specifics of mapping the xA= PIC page.=C2=A0 Sorry, but
> > irrespective of altp2m, that is a n= on-starter, for reasons that date
> > back to ~1997 or thereabouts= .
> >
> > It's worth saying that AMD can fully virtua= lise IPI delivery from one
> > vCPU to another without either taki= ng a VMExit in the common case, since
> > Zen1 (IIRC).=C2=A0 Intel= has a similar capability since Sapphire Rapids
> > (IIRC).=C2=A0 = Xen doesn't support either yet, because there are only so many
> = > hours in the day...
> >
> > It is technically possib= le to map the xAPIC window into a guest, and
> > such a guest coul= d interact the real interrupt controller.=C2=A0 But now
> > you= 9;ve got the problem that two bits of software (Xen, and your magic
>= > piece of guest kernel) are trying to driver the same single interrupt=
> > controller.
> >
> > Even if you were to say= that the guest would only use ICR to send
> > interrupts, that st= ill doesn't work.=C2=A0 In xAPIC, ICR is formed of two
> > hal= f registers, as it dates from the days of 32bit processors, with a
> = > large stride between the two half registers.
> >
> >= Therefore, it is a minimum of two separate instructions (set destination> > in ICR_HI, set type/mode/etc in ICR_LO) to send an interrupt.> >
> > A common bug in kernels is to try and send IPIs wh= en interrupts are
> > enabled, or in NMI context, both of which co= uld interrupt an IPI
> > sequence.=C2=A0 This results in a sequenc= e of writes (from the LAPIC's point
> > of view) of ICR_HI, IC= R_HI, ICR_LO, ICR_LO, which causes the outer IPI
> > to be sent wi= th the wrong destination.
> >
> > Guests always execute w= ith IRQs enabled, but can take a VMExit on any
> > arbitrary instr= uction boundary for other reasons, so the guest kernel
> > can nev= er be sure that ICR_HI hasn't been modified by Xen in the
> > = background, even if it used two adjacent instructions to send the IPI.
&= gt; >
> > Now, if you were to swap xAPIC for x2APIC, one of the= bigger changes was
> > making ICR a single register, so it could = be written atomically.=C2=A0 But
> > now you have an MSR based int= erface, not an MMIO based interface.
> >
> > It's als= o worth noting that any system with >254 CPUs is necessarily
> >= ; operating in x2APIC mode (so there isn't an xAPIC window to map, even= if
> > you wanted to try), and because of the =C3=86PIC Leak vuln= erability, IceLake
> > and later CPUs are locked into x2APIC mode = by firmware, with no option
> > to revert back into xAPIC mode eve= n on smaller systems.
> >
> > On top of that, you've = still got the problem of determining the
> > destination.=C2=A0 Ev= en if the guest could send an IPI, it still has to know
> > the ph= ysical APIC ID of the CPU the target vCPU is currently scheduled
> &g= t; on.=C2=A0 And you'd have to ignore things like the logical mode or> > destination shorthands, because multi/broadcast IPIs will hit i= ncorrect
> > targets.
> >
> > On top of that, ev= en if you can determine the right destination, how
> > does the ta= rget receive the interrupt?=C2=A0 There can only be one entity in
> &= gt; the system receiving INTR, and that's Xen.=C2=A0 So you've got = to pick some
> > vector that Xen knows what to do with, but isn= 9;t otherwise using.
> >
> > Not to mention there's a= (nother) giant security hole... A guest able to
> > issue interrup= ts could just send INIT-SIPI-SIPI and reset the target CPU
> > bac= k into real mode behind Xen's back.=C2=A0 Xen will not take kindly to t= his.
> >
> >
> > So while I expect there's p= lenty of room to innovate on the realm switch
> > aspect of EPTP-s= witching, trying to send IPIs from within guest context
> > is som= ething that I will firmly suggest you avoid.=C2=A0 There are good
> &= gt; reasons why it is so complicated to get VMExit-less guest IPIs working.=
> >
> > ~Andrew
>
> Thank you for the detail= ed answers and context. I am somewhat encouraged to
> note that most = of the roadblocks you mentioned are issues we've specifically
> c= onsidered (and think we have solutions for) in our design. :-) We're us= ing
> some rather exotic compiler-based instrumentation on the guest = kernel (plus
> some tricks with putting the "secure realm"&= #39;s page tables in a nonoverlapping
> guest-physical address range = that isn't present in the primary p2m used by
> untrusted code) t= o prevent the guest from doing things it isn't supposed to
> with= VMFUNC and (x2)APIC access, despite running in ring 0 within non-root
&= gt; mode.
>
> On a more concrete level, I am looking to do the = following from within the
> hypervisor (specifically, from within a n= ew hypercall I've added):
>
> 1) Get some (host-)physical m= emory frames from the domain heap and "pin" them
> to make = sure they won't be swapped out.
>
> 2) Create an altp2m for= the calling (current) domain.
>
> 3) Map some of the newly-all= ocated physical frames into both the domain's
> primary p2m and i= ts altp2m, with R/X permissions.
>
> 4) Map the rest of the phy= sical frames into only the altp2m (as R/W), at a
> guest-physical add= ress higher than the end of the main p2m's mapped range
> (such t= hat when the primary p2m is active, the guest cannot access these
> p= ages without taking a hard VM-exit fault).
>
> I've been po= ring through Xen's p2m code (e.g. xen/arch/x86/mm/p2m.c) to try
>= to understand how to achieve these goals, but with little success. Comment= s
> in the p2m code seem to be rather sparse, and mostly unhelpful fo= r
> understanding (without pre-understood context) what many of the f= unctions do
> and what is the intended workflow for using them. For i= nstance,
> similarly-named functions like guest_remove_page() and
= > guest_physmap_remove_page() seem to operate at different levels of
= > abstraction (in terms of memory management, refcount bookkeeping, etc.= ) but
> it isn't externally obvious how they're meant to all = fit together and be used
> by client code.
>
> Any sugges= tions on which p2m (or other) APIs I should be focusing on, and how
>= they're meant to be used, would be greatly appreciated. I suppose in t= heory I
> could just bypass p2m entirely, and populate one of the VMC= S's EPTP-switching
> array's slots directly with my own manua= lly constructed paging hierarchy
> (since I'm envisioning the mem= ory layout of our "secure realm" as being quite
> simple - = it only needs a handful of pages). But I'd rather "color within th= e
> lines" of the existing APIs if possible, especially since so= me of the pages
> will need to be mapped into the existing primary p2= m (for the "insecure
> realm") as well.

<= div>You can find an example work-flow here to create altp2m's and chang= e memory permissions in the different views: https://github.co= m/xen-project/xen/blob/master/tools/misc/xen-access.c#L517. To add a ne= w page to the VM you can use xc_= domain_populate_physmap_exact. If you add the page after the VM has already= booted the main kernel is unaware of these extra pages that were added but= that doesn't mean it can't try to poke them. Similarly, using any = type of memory map to avoid the kernel accessing these pages is just wishfu= l thinking, the memory map is after all just a hint to the OS what to look = for, not an access-control mechanism.

Also keep in mind that altp2m's get CoW populated from= the hostp2m. You can still get your altp2m to be "only a couple pages= " by either 1) ensuring no other pages ever get touched while running = the vCPU with the altp2m as to not trigger the CoW mechanism; or 2) manuall= y map change the memaccess permissions to n on every page you want to be in= -accessible in the altp2m.


Cheers,
Tamas


--00000000000082fece05f86eb58f-- From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:28:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:28:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517465.802816 (Exim 4.92) (envelope-from ) id 1pjLAI-0001cW-0K; Mon, 03 Apr 2023 14:28:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517465.802816; Mon, 03 Apr 2023 14:28:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLAH-0001cP-Sn; Mon, 03 Apr 2023 14:28:09 +0000 Received: by outflank-mailman (input) for mailman id 517465; Mon, 03 Apr 2023 14:28:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLAF-0001cJ-LF for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:28:08 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bbe73976-d22b-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 16:28:01 +0200 (CEST) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 10:27:52 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5241.namprd03.prod.outlook.com (2603:10b6:5:24c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.34; Mon, 3 Apr 2023 14:27:50 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 14:27:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbe73976-d22b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680532081; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=W48LfNmEx10sdamQf9Z+l8xZx5nNUTgaMAo86JMl588=; b=PrdTD8WIjJ7w4fbwdHL6s1IfS28R5Sj+X3OUnKq6OFkZynda8Bm9LWvE OkcIy2bQRybB0IDWgRg8RUONezmCgx3Dkth38IHWsHfhjTOofXfW894y0 lXUgiUmwN6xHEZ8vNOeZdagvyJAedJElKRqQBMrIddHiV/y9eHtnXIjT6 c=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 103501731 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:W0OpQ6liXCLCJColnsL7jnro5gynJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKWG6HaKuNYDCkfNp+b9m39BtXvMPRyNRqHlFu+yoyFCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgX5ASGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eM+eWtONA2pu8C/yraBd/g3tJotJvC+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieC3WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHugBdpLS+bhnhJsqACJ/2AwBjZJb2GyhPWhukesae1xA kNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4J5oflqYRq1hbXFI87Suiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:Wgm9aqBUpm9+gGflHemV55DYdb4zR+YMi2TDtnoBMCC9F/bzqy nApoV/6faZskdyZJhko6HiBEDiexLhHPxOkO0s1N6ZNWGMhILrFuFfBODZslrd8kPFh4hgPG RbH5SWyuecMbG3t6nHCcCDfeod/A== X-IronPort-AV: E=Sophos;i="5.98,314,1673931600"; d="scan'208";a="103501731" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWu362jbBNliunOyuAp3h3gdwvNH/X19HuMKSGO0atc0oGVimOcA8ph/O1pm7mDP8ml+jmJsgydSIgBOmaxEAPE1/d7K3+0V1CQlZufiTTGfLlL4RmAgCYXQQppeWtBAiEZGPOsO2Yygfz2IDSnyzE7/cYVJHYbU5CczvZD0i//V/uV6W4Chy95/UPUwurd5KP7JsaFyj6/RRcGNAIUycsCe05rXmOJxF1MECwNhx3Cd3wTjXSx0bdxDGL5fvBUjN/zNfr8RdUEuB7tzmp8i1NJ+WlNeeol2qT/EHeywuohzaaECIRT3SxafSTw/WLQiGkRzoB8RjATP43T4jnXPhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAfwAS67uPv82PW8HQEBVpAbw93Rh6M0Lh2mOQ5+z9k=; b=bXsUw9zjHuDG2HSDd8wCzEAeZeGUHYpq++tz0tYcvFmd++auWVhyKJNtLLifl6AV88jXskCdMUJ5uRM3C6k3pHXgJvzNbqQ4ToOjS88AGocnSjSmg0Cp1o0Q/5g1dyOHlBZ+EJGI83udAIqG8bWhAiQKJMKW1k0OzjKgOe3+E6L7b+CgNTPdKO7+g2Vts//2fxM14WnPkHXdD8mEka73rB2bCkglAyo9TshovP05NXZNS7YsJ8iSH2QHKZErmGttVY+cMsCMC6llBFMUZsafL9/q1dVsvAYm6t2TxCygD2sURiWtogY+dMqCDuandO6aFo7F48wVi6UGATuCI2puGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IAfwAS67uPv82PW8HQEBVpAbw93Rh6M0Lh2mOQ5+z9k=; b=Z8Ch6u1IzzGH1C+wjElwH7e0V5ftQxVQvbxaQjevAD/DKXJNmYuCfa7eIVHHMqA7JGyCsIwSRE4noKbInsD1GGsZElOpXuUCok2m5HrxVPM81hiU+Dyf2PF0hSCyiaBorYsT4WszXcDOoQTBKXea230rrEjOC4NsbMxRi521zM0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 16:27:46 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Message-ID: References: <20230403101449.93323-1-roger.pau@citrix.com> <8d976d34-8a1e-95ad-3bc9-3cb704c1fae7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8d976d34-8a1e-95ad-3bc9-3cb704c1fae7@suse.com> X-ClientProxiedBy: BN9PR03CA0325.namprd03.prod.outlook.com (2603:10b6:408:112::30) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5241:EE_ X-MS-Office365-Filtering-Correlation-Id: dbc82857-6909-4183-2529-08db344f9a66 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CMTS+V5ALtoPTYzCDgDBdeInc9OyLTqbZ0fc33ySvPmpqjJqFGPMkL0I+gcBk9vRIEmeAa8THkphAiw2GIo4Egos1Ti50eXSyco9Hh3TQ5Lh0S/fLXZmGgc9SoDgPL7OF9n19DuDmWoP/kOV6EQKqWq7Enr18nM6ZlMv3U/UTI5lFQhTUo1lE0dteo9BU7bA7rxeFrD+xkzDSITkg152h2cH5cPl2XkClMKoSET2o1w2UG0yQYmbEti+mMMHFQp1HJ1gAIxKrtFQe1uJ9kQLp8ZmhU98nKGD/QbTc/EBXDgfINXPeRSWee/gYLalT4YX6e43oLG6HfAt62wUy8e/OgCgRA1svLSs1OCIwnRC56rQ8xzHtJloyKkZA1Pvgw6eC0zC7iXSJAI5dZxgZhB7VfFQm0uyBzga6mt+eiKbeMEmxf+PwGfUnLlD6peq1A1HIfugaak8ni9tUvdIU0ne6l+MFVChMjcq69VOnkE7g7DYKO3w+lgEgkgCSag+0fiGar8I4NywzP0JVE1/gKDFqlh0MWzJX59+AflyY39T6CPLNWWD1rlhVY/aaWwV3nVA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(6486002)(83380400001)(5660300002)(6916009)(8676002)(66556008)(66476007)(2906002)(66946007)(38100700002)(41300700001)(54906003)(4326008)(82960400001)(316002)(8936002)(86362001)(478600001)(6666004)(6512007)(26005)(6506007)(9686003)(85182001)(33716001)(186003)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aktwaFhnOWZGdWVJeGVNR2dWN3VWdXR3aW9CNHIrTTR1endPRDVKcDJ6UnRH?= =?utf-8?B?ZzZxMFlkK3lMRmlMZXNoaUdCQklkSzlpclhDeWRCdjZ3S3JUVTBlVVozNVV2?= =?utf-8?B?ZU51cEV5cGNGOUowVUtTQ1R0VGdHTHdZa3d2NXV3cEZJYmtUaGIzbEpmTHRZ?= =?utf-8?B?RndSRHFDaGU2YjdTT0hSYTJMN0cyZy9vUGlIUXJDVFBOeFBjWk5TeDcrUi91?= =?utf-8?B?UkNWMjl3eEFDbjRxTnBFUDBNN3BOYWx0clNUOTg4VEUvVDJaZEZhclUzZXp3?= =?utf-8?B?bzRXb2lwSlJUVmp0SWxxbG04TGZzK29XcXg5TWJVZVl1Tnk3eG5WMDk1dTRk?= =?utf-8?B?UHJjUzY0RXdzUEpMV3VpbURDMVB0YlFFcUhWM3FpeTZiaUdxNTBJSmkwNllD?= =?utf-8?B?TTlYdlRqT2c2NnNNQ0Y1bEoyOFVZWS9rRGRxNlg3VjFaRytLbjhkUHhtMzQv?= =?utf-8?B?RHBQNS9aeDhKMUY0aWYySFArbm9XTGpZMElvUHF2aTlTbFhBM1NNbWduTlhX?= =?utf-8?B?dmZYbzN1NUVPTzRLQTNoN0lSbFFMeFZ3cVdXcGhxamR4b1d3bnhiN0J0SVpy?= =?utf-8?B?TVlrd010SFRXS0J0dDMwT21xUUxmZjU3Wmg4VWJkQU5MQUFacEdMd0pNUTVm?= =?utf-8?B?UkZpY0FueFYzRi9wTVhnVFQzT3c2MTVmQ29leHdRU0VKMllBZDQxMUc1cDdu?= =?utf-8?B?LzQyM0c4MUlkdFZmbVEzTmFKVS94bW84QzI0czEydkd0RXJ6cll5bzlINUlX?= =?utf-8?B?blhJbVNuV1Z6SDNzWjh3OUlLT1FlbTUyQ3dkZmhoNjR3b1FEaDRJRnF2VTlz?= =?utf-8?B?ZlN5SjdZb21GMElOYW1VOVc2M1ZTVEFtTUVpZjdIVG81bDc1ZUpQMkUvWG9O?= =?utf-8?B?cFhscFdzS3M2NHRtRmZXSktSempubXd4SnEyVmhPd3cwWHBSSno0UXl1WVZY?= =?utf-8?B?SjhWby9HeGNDOTd3VXk0QUpjaEE0NXV6OXBFa0hVaDZCN25WR0xwcVdiWW5P?= =?utf-8?B?WWdzV3lOZzNnUXpEdTFNciszcjJMYTF4dUYyekU1QmxONTlLM0tqZnkyUHkr?= =?utf-8?B?ZXAwYjQ5b3JGZkhvWjl3TlljTWlZMDhEUC80QjhUK0hudHdMWkx3YmFGYXM5?= =?utf-8?B?eStqMEROZDdWZ2tteXpvSFpBUHNoS2M2SCtEZTdwOU9wRno3ZmJKQkpLNVgw?= =?utf-8?B?L1NRN1d0VFJuTktQcFF3SlpzWXE2dTJRc2RBbzNGdzcxTFRQQ204SUZabE5q?= =?utf-8?B?YUNSVFFIUEhuMmFhRjVDazBXejBmdDd5YWF1b09vQjRKR2dzRm9iQWROREFP?= =?utf-8?B?WDkvaWpXQnhLV0gydWJXeVE3bTFzODVXSFNVZlEzTHFHaC9mcGVPaXluLzB0?= =?utf-8?B?cWl0enJlV0tzeEU5WDF4UkRGdXRQOE9mb2hQWDBSMjY4SFZJTlZKTzBQM2hi?= =?utf-8?B?NW5NU09HeExhU1F2clNpaFdWcXJJUURYSHRsb0MybTU5VEtobDc4QVVIZjNM?= =?utf-8?B?aDB2OHRlY0c4ejJsT0F3bzNEQzR6LzVpbkVBVDQ1cVpReFF4RUZ4d0cxY0FI?= =?utf-8?B?MTdtejdWVDZrUFBiRzlZQS9NOTBreDBmbmR0NERPZVhFbWJScjdSdVRPVVhq?= =?utf-8?B?SCtnc29aaHpUTFo4RlJEQlJTOURoTjNNbUZrMDV6cWhtOUhtNW9kcE5OSTdi?= =?utf-8?B?Q0ZDNDA3NXlHTjd4VjdLbmVocDNRZlZOZGJkZjY3WXZFbGNwYytBMDRTalRX?= =?utf-8?B?QnZHSlBGTFZzVUc2QXc0RHJRRGx0NG1VT2dMUk9iUzBIOVJvLzZ2ay9CeDdT?= =?utf-8?B?WlBkQVp2QXczVkRBWmhlc3lremhGT2J1Z2RTZUFnTXFPczNGZ0hNcWRMclY0?= =?utf-8?B?U005REJMSmpsaEYrRkgxcTNwbUZKNkxtU0JMalNXem4ybmc4Y3JmSjNGNlc3?= =?utf-8?B?U0E2OWREajlSdlM5UGphWG8zNktIVGpxK0hOUW9TVUF4bVA5MG9mOGsxczlt?= =?utf-8?B?Q3F5dGZ5VXVRNkZFOWRNbWZtd1pHbG51QzQvVDRUQWpSVERlM0NPT2dIOW5Z?= =?utf-8?B?NW1lV3VyU1ZpeHdhbjRqKzhXOG51OUdVOGsyckZIV3hYV1kvOU4zd1JVTVAy?= =?utf-8?Q?dQn4msdkz6lSCF1TllD/aNkGC?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K8q+NIF1BxydUNFf60C3GgpCEup+KnhHZxUYiotpMVLtYT4xVkR5ouuvjFlsFOx1mGdNuPmbGLdnL57V+65kD09YXZflELEr4Jc8Ihyjv5fiVm02BJ/UHhfVmlX2vQel6IfV9tYvDpa/x9cehU/ixumGso4yPQH1FMTVTayMG2Q4bnOnTR4i7ewjk1eqh/pDv4ACrAZw44sMLXNPUrKre5WFBx+IL3OKwU0kBelNIdlthBk61NeXrBeElbropDns0KGlKWTNt7rYAZlhXZwWYAUTEi3011oxOwXbHd5989J9d+Uc9Q3xhiLcv+FKYmHq7It1FkEHT9XtL50jiJ/rf4lA21l1hkziNyXAvxU7QiPTCgTIDDrPLYU9j6YT0PvAz1h3e2W6sLDCYQIgVfsdtJkqEtY1eH+zGLdvZViVagUTgc2vexPAvfEiQFCJ9V9OJgjzn5AfUWA15Aaf7335dxN+cIP9kvCpwnIFg9CKu355jMqNvNoFwIWBtJygQQL0tasRoQFVuIudNxZBch/N11d9ojo79rfD8Kbvdn0Rydrqs6AvXnaPhrvkwBdWZopf5GWNxhyB5+OmZOISQySyhuNbL9tUQpTtNE78LwdAc6EFI6TOArtwJeAw/wXjV1KkELAqAFhf8MqGQSFZu7/UYmOGpa1tY9bhr9bErzFQAwYEd929CgvuZrXN0ryU5BZoXfNSU0Y52PX623Dd7QRGO5ZOw92zsNlWZucn1tX8t4AoxWrB87SvGlYKSvcYEtH+DHEyO+WEm7LkAgm30qCXL/GaiXjb74J7oGK1fWdPc7eISQnL5JKOiaexiEtdWFeR X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbc82857-6909-4183-2529-08db344f9a66 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:27:50.5791 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YZgaDS1TRPjCreLTNaPC3eS346DtHhHxyXwfFKkscOJT49QEC3JNJzq772aW6mJKLaxL8AItCIWYtDLn7hqJVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5241 On Mon, Apr 03, 2023 at 02:39:08PM +0200, Jan Beulich wrote: > On 03.04.2023 12:14, Roger Pau Monne wrote: > > --- a/xen/arch/x86/mm/p2m-pt.c > > +++ b/xen/arch/x86/mm/p2m-pt.c > > @@ -486,9 +486,6 @@ static int cf_check do_recalc(struct p2m_domain *p2m, unsigned long gfn) > > p2m_type_t ot, nt; > > unsigned long mask = ~0UL << (level * PAGETABLE_ORDER); > > > > - if ( !valid_recalc(l1, e) ) > > - P2M_DEBUG("bogus recalc leaf at d%d:%lx:%u\n", > > - p2m->domain->domain_id, gfn, level); > > ot = p2m_flags_to_type(l1e_get_flags(e)); > > nt = p2m_recalc_type_range(true, ot, p2m, gfn & mask, gfn | ~mask); > > if ( nt != ot ) > > I'm afraid I neither understand why you make this change, nor why you > then leave the other use of valid_recalc() in place. The message can be bogus if we allow concurrent do_recalc(), and I did miss the previous one. I missed the one at the top. Originally I wanted to send the RFC with just changing the lock to read mode, but then I though I might as well fix that (now bogus) print message. > > @@ -538,9 +535,9 @@ int p2m_pt_handle_deferred_changes(uint64_t gpa) > > */ > > ASSERT(!altp2m_active(current->domain)); > > > > - p2m_lock(p2m); > > + p2m_read_lock(p2m); > > rc = do_recalc(p2m, PFN_DOWN(gpa)); > > - p2m_unlock(p2m); > > + p2m_read_unlock(p2m); > > > > return rc; > > } > > How can this be safe, when do_recalc() involves p2m_next_level(), which > may install new (intermediate) page tables? Oh, great, didn't realize it was capable of doing so, it's more hidden than in the EPT case. Seems like this will only happen if a superpage needs to be split because a lower order frame is being used as an ioreq server page. Do you think it would be safe to try to attempt to perform the recalc with the read lock only and fallback to the write lock if there's a need to call p2m_next_level()? Do you agree it might be possible to do the recalc with just the read lock if it's updating of PTE type / recalc flags only? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:41:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517470.802826 (Exim 4.92) (envelope-from ) id 1pjLMf-00040T-7V; Mon, 03 Apr 2023 14:40:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517470.802826; Mon, 03 Apr 2023 14:40:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLMf-00040M-4r; Mon, 03 Apr 2023 14:40:57 +0000 Received: by outflank-mailman (input) for mailman id 517470; Mon, 03 Apr 2023 14:40:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLMd-00040C-5h; Mon, 03 Apr 2023 14:40:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLMd-000359-4R; Mon, 03 Apr 2023 14:40:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLMc-0000bd-SU; Mon, 03 Apr 2023 14:40:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjLMc-0006fm-Rw; Mon, 03 Apr 2023 14:40:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mUemyF7kJ+WSqtFthDJ62h4efiBNP1EudohcMPCEIsE=; b=GdUkNQJAW/5r8uL3bhNlxmE7YY LpdTPf/WuI6S2gTm4RvVrGHv9UVXESrHdOw4klCVzMVPbbKbFWpTIAZfUV96+eLj4uwh3qFiRbpTn bjBWYS74chQ3gVFqwPnejhe2LzN3SGsh6y2V5SvDXeJr7umsSOhp4ILG2xXQYMNT47D4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180119: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=bfa2e6a246225233f09a2523939e01dcf83bca4c X-Osstest-Versions-That: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb From: osstest service owner Date: Mon, 03 Apr 2023 14:40:54 +0000 flight 180119 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180119/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen bfa2e6a246225233f09a2523939e01dcf83bca4c baseline version: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb Last test of basis 180085 2023-03-31 07:01:54 Z 3 days Failing since 180117 2023-04-03 11:03:28 Z 0 days 2 attempts Testing same since 180119 2023-04-03 13:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Oleksii Kurochko Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d6e0b4c41a..bfa2e6a246 bfa2e6a246225233f09a2523939e01dcf83bca4c -> smoke From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:56:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517478.802839 (Exim 4.92) (envelope-from ) id 1pjLbW-0005bS-HY; Mon, 03 Apr 2023 14:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517478.802839; Mon, 03 Apr 2023 14:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLbW-0005bL-Et; Mon, 03 Apr 2023 14:56:18 +0000 Received: by outflank-mailman (input) for mailman id 517478; Mon, 03 Apr 2023 14:56:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLbV-0005bE-7T for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:56:17 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0601.outbound.protection.outlook.com [2a01:111:f400:fe02::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aebab964-d22f-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:56:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8969.eurprd04.prod.outlook.com (2603:10a6:20b:408::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:56:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:56:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aebab964-d22f-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hezAqPL86OnmI4MejXQqvnV4J4QmjgUxuIoLbrPRLyFIyRfycMRuJCCjiKWmTVgDyQQPrE/JJRedDSTwy2IUxYnd/KH2zPQ4PredvVwxtkENfr3eUb8IiYDhwY5GI9DSBrnR14ABkc6vsPHlZZve7CfRLuf0Pp5vf8j+Cy6UxgSdmZ/ub24N9Uw6qS0VreDxzqtizqIXFkY90fhHz3rECpB03wLX9BpSBebf2xowzEtYL2CsQ0qgUoWJj9sOrPVH1g/mdlxxqQtG0ATxfqU+7y5vb2Lr+xueOU4VmOSxJFgGshLhVwB1luBXbR5L1nQX89fqMuqdceMnrwhKzu6ttQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hCUUEF17r9XW3dkx0a5vTv5SWd+1bdYAn0PcErwXMKY=; b=ARuvEzmApDObq3RFi38OlrGxxfnWI8BdYeD5W/UIbHSg9xPVIpO7Ct63yq75wBeuEX4J0cszOAQCdfrdbhJZQbaVCU+SyBcExF5Rj6DiQ45HYBQ6rbMJbDhsAGwIgzB9Uq8lQF2b8zQYPAQYx5p/5ldGSSZ8E03AcYxk0kmc6bvhB9Z5uhd4Oid4gzLSnPFfuWDupgy7mD6JKHqEOh55DpPdRpPmu41COtQPgn9nUf1qnLh+1eszdCRYdWXZNEOmKL/m1P4eBZydaCXuiad/66BHHD2SQi5QoGjW0hZkAPCThhai8Zs/x8gdskJLUvLbDyKwp6WF3heTa9gxQQUpJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hCUUEF17r9XW3dkx0a5vTv5SWd+1bdYAn0PcErwXMKY=; b=I+o87UIhGCP86CGyaG1lc2Z1IOCm8JK8RXLiLirKaZhVdkvrpMpj0Hh3szau9P0zr6RXBhNL4NBI70vRYwREL412WjBqVj2vgUFkNGEcEYVJtYtYI5uXFYS00MJFrzWu53lHoZl8ynQqdSPy4fmQPDq5kTTlW4n+s3oZ/GfVud3dIrKqIpaJ2pYogeui7FyUp6Xw42QffMYJZML2e+KmFB9hUORA7Vkyv8QzEPHFe/GrRPoZJ82ySzWwnIki/BvE9ZsPv4l8mf345CZDZTA7kLkBBYyDGDmbJewqJ8Cyxigk7XDd/QqKjxiE2GzS9ugSjP9NYN/evP2f2r1E/g2Iww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Date: Mon, 3 Apr 2023 16:56:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 From: Jan Beulich Subject: [PATCH v2 00/10] x86: support AVX512-FP16 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8969:EE_ X-MS-Office365-Filtering-Correlation-Id: 176e682b-0784-4677-f35f-08db3453918c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D4BIcZoFTnb9PMSpaJgwTxnXlRpmMDWzlVmpcg/lhsjMf73i4N2R7a0iiYuFkUvm+uI2RZiMT8pGX12JA6lAN41OOFP5FonqrWNcRqwjt5JExD/nmZOjhT0oyQNCcxGIdsZOWQIuwzyzHiELQq+CI0noEK7lOPmCNLaUqlIuIKOQdAc4k/uom/kI/Y/rfXOeZ+RUrpYH92tJ3E8Gu8Ukowpk2B6Jr+Z4SurQ0W4gq1zBbzMRwM9T0tvc+Y3+MOKH2kGiwgH9K/EK3wkcGw3fz9Sx5a+jaBIt1ykdYivsVR1XAIQghb+BgJDzu+6SoaAbz99gcjEDmt/oV+M0C64sdTJhAgVsnAiM6Af2SQueQVvVETcLpkpekvg1UNRp+1dpw6IAQ+t1B2sZPijdFEVl7HVrJwuFRR+rTD6to/jkRqBwgsvjauZ5ppgf1FeKbjlEcnnF5eG+cYnq1853uRbhISgBiZt8yZoJ51URYKL+LozI2wqMAQJ8wYaVTwGO5qT7vbVx0QErFx4G8OAn+qEA03jrpTl2oPH5OIQB+/amQPYLVkU5BrYZ9z5Fk9hA29ZhVMNPR2VQ+x+cUQ0231cf+SIlhUMeoSR19kWjrkl9hVrFCFE9Tej/mGqhkvcplmAbKW64b3HP8MokX5AX/QDBdg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(396003)(376002)(366004)(39860400002)(451199021)(31696002)(86362001)(36756003)(2906002)(31686004)(2616005)(6486002)(186003)(83380400001)(6512007)(26005)(6506007)(6916009)(8676002)(66946007)(66476007)(66556008)(41300700001)(5660300002)(38100700002)(54906003)(316002)(478600001)(4744005)(8936002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y25kUFdLZEhVaWdsRDR4akE4a3RRVVpRTzdWbEdzSGdTYVBZR09HS3BRZUFu?= =?utf-8?B?SkhEKzF2TVZoaTRKWVNIczlPTXkrS3pvSkQya2Y3Zy9XU0d0a1VUcGhKeUR5?= =?utf-8?B?dlRBWG5pcnlsVXNScUUrZ2xZeFd2WWpHM1kySEV1Sm0wTVZhbnFQVEFQSlhV?= =?utf-8?B?YTVlbEprd1A5ZVdUaFpEaGh1R1JLL3ltaDFKQ1plalVPV1NZdVR3V1JkUC96?= =?utf-8?B?M25mNDIxc0p2bVJCTEovZlUzWmRDOW1ETm82Q1I0WTJiU1psTGVhTVVxbnFT?= =?utf-8?B?TmlWYXVGMGVlODg4VmNLYlZDYkluU09tTktucU1ZdG8ybHptWXlnNGRpSFpy?= =?utf-8?B?ZHJuNVZ0MkZBbitHWmhJdnpPWVh2WEhqQ0wrR0FhK1h0NVdZRE53eHNZU3F1?= =?utf-8?B?SEU1VmF3Z1FoZ0UzRkJ1YUNtSWp2Rk1Ya0VwOVdNWG1iVTZrNWpaaGdwSUVE?= =?utf-8?B?cGFUQUFRMkpvSzBhc09WMVRsdjJBWHIrT3V2MU8xcjcrYTd0dzdjVUl2KzRt?= =?utf-8?B?a3F0SGRseHdSN2tRYjhadlgzMWVJUDlTeVNMTGhLSklta1ZyYWNmZjdMVDRr?= =?utf-8?B?Q2R1R0xMYmdVM29CaXRQRWxaQ2ZjRVcrbXpIWTNibUR1UDN4bEhGQlAvTmp6?= =?utf-8?B?ZWtOM2FBdXQwWHJIYzVqenYyZ0NDTXBZeXFhM3BtN2MxUjlKN0NBZlRaZ1g3?= =?utf-8?B?bFRhUmsveWdreFVVNmRhdVFnNlllTk1LUEhCR01BWE54aE96MG5xc3BOUDhu?= =?utf-8?B?ZVkwSnpvejdEa0l3ZWJZNnNXdjA2RCtQaHMrNTRGNU5Ia1V6RDYyQVZDWVBO?= =?utf-8?B?Z2pRL3NkQytMNjNkMk5LUVEySGhTYURLTEsrNENDOTFvbFZmbVU3SXBQdVFP?= =?utf-8?B?MHdybHZiR1pzYVNlS2NZR1FFVi8ybDdDdVpvTGlZVmpOQWZzWHAzL1RLNmJU?= =?utf-8?B?bml3Z0MyUW1MUjVuZlpLNWZzOFJnTjBZVkFZa1d0cHBnMDd2TWRIUkdwZVNq?= =?utf-8?B?bTlkZWw3WG15cE5RQTZMaTRzcFlpYVlLSGVFbjd1ZnlDNXZVcUxQNlUrZU9J?= =?utf-8?B?dVRYVGJRcTdMeldoRml0aWRqMzFIbUNncTYvTHB0MUVKZlVaR3pUYTFTUi9F?= =?utf-8?B?eEMvVkZUTmhubHhTeWxHUnEranpoaWVUT1l1aDRUY3djRGNZRkdiUnM2OHc5?= =?utf-8?B?YXo3N2V1ZWV1eW5Gd2xoWTdoVnJjOU5VdzdTWlNqR3hSUmlyYTBUaFZNSnkr?= =?utf-8?B?aWRCbnphY083aVRSTllwbmpJOU84SktnK2hCaW4ybTVVMU5JdVdkZUpucG81?= =?utf-8?B?akkyU1g3VG11Unc2RTIzNjFqeUs4dWh0b0dUS0tGL0pzZWlUZ2JiZFRROWdQ?= =?utf-8?B?S3VwVndsaXp0bXVwRzE5MXpDYWoxQzNJbWdFMm9FYXRtQTkwQTN0d2xsRnI0?= =?utf-8?B?NEtBTTJLcVBNbmFEcmMrSHpldE1LZ0o4czZVRUlZSTcraW1GNExGeGVJOGJ6?= =?utf-8?B?cWdmbFVXQzMzaDZaZVN5bXRMbDE1NmZiOWhUSDlTSE5IOVAzUjEyMHp2L0lt?= =?utf-8?B?bkpodWZsd01XYXNpRHVlRzV2dGZnTWRWem1SbExRa1hyZ0JwOXZ1RU15TTBW?= =?utf-8?B?Z3llMzByenZFc3VIbjBxaEprczdhWm53MHNPbnVBNS9nYWF1SWI5VmxHUHcr?= =?utf-8?B?ZG1CZ3c3RnIxQitlWCtQUVZ0OTRUTUpDNXpjb0F2UjZZdW5oeVl4anRYUXJ3?= =?utf-8?B?aEhJUTBldFRVeGMrRkk1NzlMOVdSY1FMQ0YxdVd0c2d5eThTb1VXK2pMYXRI?= =?utf-8?B?eEVBK0xoZDJPYkdiN0UxWWl5d3VnaUhDeVkzMWp4eTk5NlZMTXZWWk9qd2Z3?= =?utf-8?B?RTFZMDZSQWJmdzgzdWc4c0JxZ0pyRFBVaUJDbVE1QXRpMzhkSllZVEphREsw?= =?utf-8?B?RkdOd044a0R6S1czYWVBWGVINmQzVHREZnZpYXdlVTJGUEFrQTJwVFdXZW5n?= =?utf-8?B?ZFd1aUI0VTVwVllKdndUcDBJaWhhYlExaGtCN1czU3NsVVRHaTZIeVBJRDBS?= =?utf-8?B?MW83ci82dmxuUzJUQWRKTW1rWE8wSG9NMWRSdzlIaVNVYUlsUW9NVXZaL0Fm?= =?utf-8?Q?ekxAlKqKnkdN7mHZbikQGnm9w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 176e682b-0784-4677-f35f-08db3453918c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:56:13.4152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ajySwkRM0E9DQaQy721e9SfyfqDo48EUlpawqs2qMG9cmXiwyzmEhBAxbKSN5HoijtvZ9LaTP48TSnFNC+MyIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8969 While I (quite obviously) don't have any suitable hardware, Intel's SDE allows testing the implementation. And since there's no new state (registers) associated with this ISA extension, this should suffice for integration. 01: handle AVX512-FP16 insns encoded in 0f3a opcode map 02: handle AVX512-FP16 Map5 arithmetic insns 03: handle AVX512-FP16 move insns 04: handle AVX512-FP16 fma-like insns 05: handle AVX512-FP16 Map6 misc insns 06: handle AVX512-FP16 complex multiplication insns 07: handle AVX512-FP16 conversion to/from (packed) int16 insns 08: handle AVX512-FP16 floating point conversion insns 09: handle AVX512-FP16 conversion to/from (packed) int{32,64} insns 10: AVX512-FP16 testing I've re-based this ahead of the also pending AMX series (and, obviously, ahead of the not even submitted yet KeyLocker one), in the hope that this may find its way in sooner than that other series. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:57:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517481.802849 (Exim 4.92) (envelope-from ) id 1pjLcO-00066n-QV; Mon, 03 Apr 2023 14:57:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517481.802849; Mon, 03 Apr 2023 14:57:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLcO-00066g-N9; Mon, 03 Apr 2023 14:57:12 +0000 Received: by outflank-mailman (input) for mailman id 517481; Mon, 03 Apr 2023 14:57:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLcM-00066R-HX for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:57:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7e1a::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cea60352-d22f-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:57:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:57:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:57:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cea60352-d22f-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acCpsPXMXDMlfJg+cL1cmT0lBWOGMvb0w6OND+xqasBt6i3ccE5k5hoFWdaDYgubxzEUjC6htBqA0VrC0BKbAwXj8qQO2Mem2RSueRbovXVGshtRa+PCcbRTQikw+ive3cjWXwT4ZsYJXRWnrFFpUdCT2W1jtlZ6gkucsObn8ajfn2tYGtLZekQeFsuUixRicjiC83nFY3Lt3YcuuGyHVBQrCbNMmCZyCdH7Huqc148L/3QkkFvcqxZRhVu2s6SYhOxi+OaojF6208TtD55Pyon7nVBDpQ3Ms198ZamRAEgp2k8+/ixQIWmzO0zrYCdMhQQSkuGzofFKGd28EXnMlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FCrSDs0f16ekqy4Eik8NqBW3LlGngJ7nD0dM0P0nsr8=; b=LghBN9P3jwxWVOMeSwJ43Kb5OL1TweMekV/42QexP0f6FAbrIO2GgsEjwTqLinPWtmuOVKR6F36XlcIWsP/Td36Id92iO72bz2m5FAh/I5wNm3PHCMt7fdw6g076upvL0t7iFtarPrDPh2ap13H4j2f2bYey3AGDTyByIQl06X78qhRSFg/0zwGQ956n10KWTcJ31tEOAk/F+HmzYx8L0X5T+g6QK64xJL4g8fbqL8mY2vnkU1xahqZs4OzQKBGuOrQCViqvM2pSrCHvwQJNPcSHq48bSTQ8JR9XM0daDwagi/hRe6FP+JhKY1IVCodzuhri+wg79aFScQCLtnMhAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCrSDs0f16ekqy4Eik8NqBW3LlGngJ7nD0dM0P0nsr8=; b=ihTbTw4ZFCEFdExKJRV/bfiTEuRtUrMpXtcJfFUlF8yCM7qIur9ff6Pnekrm5r83cuRDsQl7NzwSDBvuLxjvxIX9LCBr20elx8GjPIOg04aSCiicHwhkCA0hQEm56DKx+WCE6mP4qIvBoVfE/XS5sb7FLH3CEwqRkDb9Zp0gC8T3WP7XU1dHg0m0lGocC98sokQ/6GSaK6ETzhAcTzA+GyYk8xcIdwrlfGPpx7vwsvofQCAHPJn2AZU1u/7boyUYMcbSzjXwa2tiOmvkYz/LLSCKpTEFRbQa2NeFztkxSpxZFM2qU8AF8hJtCggJcMlb7NmXL+Ec3o2FnFQ7YPf57g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ce78724-a826-f53d-4ff2-701cc279289a@suse.com> Date: Mon, 3 Apr 2023 16:57:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 01/10] x86emul: handle AVX512-FP16 insns encoded in 0f3a opcode map Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 1398e316-7ab8-459b-e2ad-08db3453b0f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gJH7sTdD+B931sUMQkYGMHQsEDVsbeEpddamUdu+F+M6nvK6PnhD8fcr8WISj97w7tqHKDzoGixjYoCKxWW5lvW+Z+3ZEOIwP5okgSVmp6zEHe7Av6buw4W1M0ozOd3rW7GXRT5LhD9eAqiscbOK6gg2OMqWHiYKKxoWoYSd+7XSuKV4TiSbe9Cb+Pd7/uixcbFNk7lN38DkJcKfDdpG0KQq6Hp7K5pQBOccFTRl8ZhWgGDNMFv0YrSzRXyEURIuxCMCwF5SjYF7Lv/QNdTXjc8/Cbvf61P8fHe/mKQOmHha5/lmtmf5m0cSdNBmYJleWcjEG5Lx/AJ1pExzkImbWv/ADsDkDXM3zmRk78sO0fg5XF7xlBUlEy0fDGgh53LmiS3hl2PjSsUv1wGI8sE3dA9C67exTB2KWDMMj/OmczR2i1on2O628pKUZn1BeuyyrhCjFDAG4ITfJRUJr8yvFbGy3TSwM7Xtw4PEk3+kzTNVmZt8C563ZJIuSaFhQpHuyGiyIOh3IGgTBXNNDMUpA88IkmyBN9Z63OwK45DVaXijO6mja6lPyJyBFUBD0326kP7ZMJ92KyAypJufisLbMHen/v+Wzs6cnboUo3QGqHfLILMLYtyHwzggt7X+0v/SLpgc2B9nWaAoT8nbQ6Qm3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(30864003)(41300700001)(38100700002)(5660300002)(186003)(83380400001)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXhpS2M0SUpZVVZvRkhLS1pqM0VDa0dINEVyZ1IwOXJJRmZlb3B2M28zQ25G?= =?utf-8?B?M3MvbDllK3FPQUUxZ3JxRjVrT2diMkpDYlJ2NzJzcklKRG9zdHRJSlVMWEZt?= =?utf-8?B?S0kwZlZwSi9xOUUrNllNYWNFNlBjNVBNUmVMQUNoeG9XRUZHTEUrVkxWMU81?= =?utf-8?B?b0ZRbEFZdFpJZXd0bE1JeS96ZVROYzdEYWJzY2NSRXVFY0pkTjFLRU52WUdv?= =?utf-8?B?VjdqUmlOcll4MExTSEErYXZaSS9CVjQzSXFnV0MyUUNTZjkreHRHV05sSnFq?= =?utf-8?B?S2s2ZnFPbHdxUUhGM3dEUkRiOXpQZ1ZEU0FFYzZDY2Fnb1lNcFVpNW1ueWxZ?= =?utf-8?B?L3k4WXlPODdxdFh0ckR1b2o0Y0g3Nk5JbGxDdEVPay9sMkVjVStFQURFSHlO?= =?utf-8?B?MkFZTysyTWtRbExLaGZiMEczQWtHeEZGUng2b3BsSmZMeU83WTlBVGtvMWt1?= =?utf-8?B?a0gxTWpTWnZMZlNFZG9ZTWJiM3pJbEFLRStiWTV2cm9nWUZmUXN5eVp0OUZ2?= =?utf-8?B?UFozWUFjbkprOXdBTE9odDhuTnZSQ2EzamJNMUdaTFFSUE1HZUFNVkJWU2Fi?= =?utf-8?B?YUl1TEVscEh5MFZGeVNkVGlZaE0yZU9nVFgyK2NFVUV0OE1VY1pRMG5rL2NJ?= =?utf-8?B?VnVHSS9NbGRydEhTQ1lnMC9TeG9PeHJQWHNRVjlBQThYV1dKVmNaZXl2SThv?= =?utf-8?B?L1ZKeFp4Y2hZUlg2UXZWL2VQbnh5TTFqb1VsSnh3dG91U3VUczdKU1ovWXBY?= =?utf-8?B?SkMwam9xZ1dYSWlrTVhGZmJMeHQzcWNvM3Z6aVNaQ0VEK0l0QzdCMjdlTDRi?= =?utf-8?B?OFVsSDczMEVzUzdZZVFnTzBRYVlFVzdYSnpLclBYMGxXNkhiVnRLMHFMWWNl?= =?utf-8?B?WmhSK0phTlAwZ3N2SGxiWHo2T0VlSmU3SnF5dnJ3U2xtaml5aEpBNjNzL0l4?= =?utf-8?B?aXJXRmpUM0EwVG0wYUJpRTNYVzIyTlc5WlNlZHFyOXJWaThhbXcwb1Q4SU9V?= =?utf-8?B?c3EyN3hrb3BvL252SSs0eTdHYXAzUXd3c3EyN1dVL0ExaUVxZ0ZOT1VrK3E3?= =?utf-8?B?Q3BiUXdtcWo4dDN1dXVvSUVhWmVKQnk5VUV5OTRPY0pVZjdKTmY2TmJrQXpD?= =?utf-8?B?d1pLWmNEdHYyZjJFOWQ0WDVYQXVwdzZReTRxSUFndVFBZHRSNEpEY0FHcU1y?= =?utf-8?B?OWtMZjQ4QmxRUDJiSmsrMlg5QjJQVHo1RVdEYTdlbUwzT2dVTTFldVFTTnps?= =?utf-8?B?N2JNYmdFNzlXcHpLaEU4elRkMDZFM01CYlNpSXY5TzI3MVVTOTBnQzdhMHV6?= =?utf-8?B?U1ZCZlNycHdpdSswM3I4QTZ0Y3R5cGplYytydWNVeGt3MVRidFlVYlJvRS9J?= =?utf-8?B?aHNGSXBuSHJ5bHg0bUE2QkQrNUpqRnJ1dkU5aXpQblhHeWw5VVEwaUYwaVRE?= =?utf-8?B?aFZwU3A3VjNMNk9EVVNqa3JzYXFpL0RjZTM1RTA2OEZQVjV1eXdRLy9RL3NQ?= =?utf-8?B?WVJ3U0YvQU1XTU1KY211QlE1SVlmSFFiR3RFVFhHcmVmNzhscmU2UjFuV1la?= =?utf-8?B?dEtMVnZjejh0WEkrbzBvT0tqSDNKdjQ2SzZZaVNlWjArVHl4R2l3QnRVb2cy?= =?utf-8?B?a3BPRUZtcldiSXorR2pqYWoremRMeFNmN2EyUkhwb2tUeTU4YUgwZk9GdWdv?= =?utf-8?B?T3VTeDJZY3E5VHd2YVBZcC91d2toMzlOVmhuOGgvMVRBWkxrRG1ZeEVISjhp?= =?utf-8?B?TG0zeXB6Tmt2NEFCR2FDbGdDM1J1WTZJY0d0UllRTWZMT2hiMXUySWtITG4r?= =?utf-8?B?YlpDQ3VSdDc1d2xGTUFHeFFUQUlXN0pad1c0ajdxV1ZERWI2eFpNWnd6TmRm?= =?utf-8?B?TnVSWVlWZHRJNUdSd3k0cGtHbkQ3SWd4cnErQlY3c1RSSFNtOTFQK3JhRUsr?= =?utf-8?B?dHJLUEhnSEdHbDV5R0R5YW5tZjVQMjlrbU5QNHgrYTM1REhoM0VRZFFyMlJD?= =?utf-8?B?RmhGSjVSMG0rUXZpUTFsK1NvbVQ1aFFaN3BzUkw5aXRaRytKN0FlS1ppQXRG?= =?utf-8?B?Mnd0U2w0V2MrSE5PLzRNNkhyYit1cVVxek0zdDlCcmN0WFgzWkw0clBUWExY?= =?utf-8?Q?G/+/tpkKpWtC+iRDrclxzYaNN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1398e316-7ab8-459b-e2ad-08db3453b0f3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:57:06.0431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: faOVin8bABF1uGPHQt/CB5svc+hwVdgJ9qE3Q3n21/t+VwxkmC3XvN5/SOwOKZ4W0K6pA5AaKHx0p0NDCsLHCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 In order to re-use (also in subsequent patches) existing code and tables as much as possible, simply introduce a new boolean field in emulator state indicating whether an insn is one with a half-precision source. Everything else then follows "naturally". Signed-off-by: Jan Beulich --- SDE: -spr or -future --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -76,6 +76,7 @@ enum esz { ESZ_b, ESZ_w, ESZ_bw, + ESZ_fp16, }; #ifndef __i386__ @@ -601,6 +602,19 @@ static const struct test avx512_vpopcntd INSN(popcnt, 66, 0f38, 55, vl, dq, vl) }; +static const struct test avx512_fp16_all[] = { + INSN(cmpph, , 0f3a, c2, vl, fp16, vl), + INSN(cmpsh, f3, 0f3a, c2, el, fp16, el), + INSN(fpclassph, , 0f3a, 66, vl, fp16, vl), + INSN(fpclasssh, , 0f3a, 67, el, fp16, el), + INSN(getmantph, , 0f3a, 26, vl, fp16, vl), + INSN(getmantsh, , 0f3a, 27, el, fp16, el), + INSN(reduceph, , 0f3a, 56, vl, fp16, vl), + INSN(reducesh, , 0f3a, 57, el, fp16, el), + INSN(rndscaleph, , 0f3a, 08, vl, fp16, vl), + INSN(rndscalesh, , 0f3a, 0a, el, fp16, el), +}; + static const struct test gfni_all[] = { INSN(gf2p8affineinvqb, 66, 0f3a, cf, vl, q, vl), INSN(gf2p8affineqb, 66, 0f3a, ce, vl, q, vl), @@ -728,8 +742,10 @@ static void test_one(const struct test * break; case ESZ_w: - esz = 2; evex.w = 1; + /* fall through */ + case ESZ_fp16: + esz = 2; break; #ifdef __i386__ @@ -845,7 +861,7 @@ static void test_one(const struct test * case ESZ_b: case ESZ_w: case ESZ_bw: return; - case ESZ_d: case ESZ_q: + case ESZ_d: case ESZ_q: case ESZ_fp16: break; default: @@ -1002,6 +1018,7 @@ void evex_disp8_test(void *instr, struct RUN(avx512_vnni, all); RUN(avx512_vp2intersect, all); RUN(avx512_vpopcntdq, all); + RUN(avx512_fp16, all); if ( cpu_has_avx512f ) { --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1972,8 +1972,10 @@ static const struct evex { { { 0x03 }, 3, T, R, pfx_66, Wn, Ln }, /* valign{d,q} */ { { 0x04 }, 3, T, R, pfx_66, W0, Ln }, /* vpermilps */ { { 0x05 }, 3, T, R, pfx_66, W1, Ln }, /* vpermilpd */ + { { 0x08 }, 3, T, R, pfx_no, W0, Ln }, /* vrndscaleph */ { { 0x08 }, 3, T, R, pfx_66, W0, Ln }, /* vrndscaleps */ { { 0x09 }, 3, T, R, pfx_66, W1, Ln }, /* vrndscalepd */ + { { 0x0a }, 3, T, R, pfx_no, W0, LIG }, /* vrndscalesh */ { { 0x0a }, 3, T, R, pfx_66, W0, LIG }, /* vrndscaless */ { { 0x0b }, 3, T, R, pfx_66, W1, LIG }, /* vrndscalesd */ { { 0x0f }, 3, T, R, pfx_66, WIG, Ln }, /* vpalignr */ @@ -1993,7 +1995,9 @@ static const struct evex { { { 0x22 }, 3, T, R, pfx_66, Wn, L0 }, /* vpinsr{d,q} */ { { 0x23 }, 3, T, R, pfx_66, Wn, L1|L2 }, /* vshuff{32x4,64x2} */ { { 0x25 }, 3, T, R, pfx_66, Wn, Ln }, /* vpternlog{d,q} */ + { { 0x26 }, 3, T, R, pfx_no, W0, Ln }, /* vgetmantph */ { { 0x26 }, 3, T, R, pfx_66, Wn, Ln }, /* vgetmantp{s,d} */ + { { 0x27 }, 3, T, R, pfx_no, W0, LIG }, /* vgetmantsh */ { { 0x27 }, 3, T, R, pfx_66, Wn, LIG }, /* vgetmants{s,d} */ { { 0x38 }, 3, T, R, pfx_66, Wn, L1|L2 }, /* vinserti{32x4,64x2} */ { { 0x39 }, 3, T, W, pfx_66, Wn, L1|L2 }, /* vextracti{32x4,64x2} */ @@ -2008,14 +2012,20 @@ static const struct evex { { { 0x51 }, 3, T, R, pfx_66, Wn, LIG }, /* vranges{s,d} */ { { 0x54 }, 3, T, R, pfx_66, Wn, Ln }, /* vfixupimmp{s,d} */ { { 0x55 }, 3, T, R, pfx_66, Wn, LIG }, /* vfixumpimms{s,d} */ + { { 0x56 }, 3, T, R, pfx_no, W0, Ln }, /* vreduceph */ { { 0x56 }, 3, T, R, pfx_66, Wn, Ln }, /* vreducep{s,d} */ + { { 0x57 }, 3, T, R, pfx_no, W0, LIG }, /* vreducesh */ { { 0x57 }, 3, T, R, pfx_66, Wn, LIG }, /* vreduces{s,d} */ + { { 0x66 }, 3, T, R, pfx_no, W0, Ln }, /* vfpclassph */ { { 0x66 }, 3, T, R, pfx_66, Wn, Ln }, /* vfpclassp{s,d} */ + { { 0x67 }, 3, T, R, pfx_no, W0, LIG }, /* vfpclasssh */ { { 0x67 }, 3, T, R, pfx_66, Wn, LIG }, /* vfpclasss{s,d} */ { { 0x70 }, 3, T, R, pfx_66, W1, Ln }, /* vshldw */ { { 0x71 }, 3, T, R, pfx_66, Wn, Ln }, /* vshld{d,q} */ { { 0x72 }, 3, T, R, pfx_66, W1, Ln }, /* vshrdw */ { { 0x73 }, 3, T, R, pfx_66, Wn, Ln }, /* vshrd{d,q} */ + { { 0xc2 }, 3, T, R, pfx_no, W0, Ln }, /* vcmpph */ + { { 0xc2 }, 3, T, R, pfx_f3, W0, LIG }, /* vcmpsh */ { { 0xce }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineqb */ { { 0xcf }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineinvqb */ }; --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -4677,6 +4677,44 @@ int main(int argc, char **argv) else printf("skipped\n"); + printf("%-40s", "Testing vfpclassphz $0x46,128(%ecx),%k3..."); + if ( stack_exec && cpu_has_avx512_fp16 ) + { + decl_insn(vfpclassph); + + asm volatile ( put_insn(vfpclassph, + /* 0x46: check for +/- 0 and neg. */ + /* vfpclassphz $0x46, 128(%0), %%k3 */ + ".byte 0x62, 0xf3, 0x7c, 0x48\n\t" + ".byte 0x66, 0x59, 0x02, 0x46") + :: "c" (NULL) ); + + set_insn(vfpclassph); + for ( i = 0; i < 3; ++i ) + { + res[16 + i * 5 + 0] = 0x7fff0000; /* +0 / +NaN */ + res[16 + i * 5 + 1] = 0xffff8000; /* -0 / -NaN */ + res[16 + i * 5 + 2] = 0x80010001; /* +DEN / -DEN */ + res[16 + i * 5 + 3] = 0xfc00f800; /* -FIN / -INF */ + res[16 + i * 5 + 4] = 0x7c007800; /* +FIN / +INF */ + } + res[31] = 0; + regs.ecx = (unsigned long)res - 64; + rc = x86_emulate(&ctxt, &emulops); + if ( rc != X86EMUL_OKAY || !check_eip(vfpclassph) ) + goto fail; + asm volatile ( "kmovd %%k3, %0" : "=g" (rc) ); + /* + * 0b11(0001100101)*3 + * 0b1100_0110_0101_0001_1001_0100_0110_0101 + */ + if ( rc != 0xc6519465 ) + goto fail; + printf("okay\n"); + } + else + printf("skipped\n"); + /* * The following compress/expand tests are not only making sure the * accessed data is correct, but they also verify (by placing operands --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -183,6 +183,7 @@ void wrpkru(unsigned int val); #define cpu_has_avx512_4fmaps (cp.feat.avx512_4fmaps && xcr0_mask(0xe6)) #define cpu_has_avx512_vp2intersect (cp.feat.avx512_vp2intersect && xcr0_mask(0xe6)) #define cpu_has_serialize cp.feat.serialize +#define cpu_has_avx512_fp16 (cp.feat.avx512_fp16 && xcr0_mask(0xe6)) #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -518,6 +518,7 @@ static const struct ext0f3a_table { [0x7a ... 0x7b] = { .simd_size = simd_scalar_opc, .four_op = 1 }, [0x7c ... 0x7d] = { .simd_size = simd_packed_fp, .four_op = 1 }, [0x7e ... 0x7f] = { .simd_size = simd_scalar_opc, .four_op = 1 }, + [0xc2] = { .simd_size = simd_any_fp, .d8s = d8s_vl }, [0xcc] = { .simd_size = simd_other }, [0xce ... 0xcf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0xdf] = { .simd_size = simd_packed_int, .two_op = 1 }, @@ -579,7 +580,7 @@ static unsigned int decode_disp8scale(en if ( s->evex.brs ) { case d8s_dq: - return 2 + s->evex.w; + return 1 + !s->fp16 + s->evex.w; } break; @@ -596,7 +597,7 @@ static unsigned int decode_disp8scale(en /* fall through */ case simd_scalar_opc: case simd_scalar_vexw: - return 2 + s->evex.w; + return 1 + !s->fp16 + s->evex.w; case simd_128: /* These should have an explicit size specified. */ @@ -1417,7 +1418,29 @@ int x86emul_decode(struct x86_emulate_st */ s->simd_size = ext0f3a_table[b].simd_size; if ( evex_encoded() ) + { + switch ( b ) + { + case 0x08: /* vrndscaleph */ + case 0x0a: /* vrndscalesh */ + case 0x26: /* vfpclassph */ + case 0x27: /* vfpclasssh */ + case 0x56: /* vgetmantph */ + case 0x57: /* vgetmantsh */ + case 0x66: /* vreduceph */ + case 0x67: /* vreducesh */ + if ( !s->evex.pfx ) + s->fp16 = true; + break; + + case 0xc2: /* vpcmp{p,s}h */ + if ( !(s->evex.pfx & VEX_PREFIX_DOUBLE_MASK) ) + s->fp16 = true; + break; + } + disp8scale = decode_disp8scale(ext0f3a_table[b].d8s, s); + } break; case ext_8f09: @@ -1712,7 +1735,7 @@ int x86emul_decode(struct x86_emulate_st break; case vex_f3: generate_exception_if(evex_encoded() && s->evex.w, X86_EXC_UD); - s->op_bytes = 4; + s->op_bytes = 4 >> s->fp16; break; case vex_f2: generate_exception_if(evex_encoded() && !s->evex.w, X86_EXC_UD); @@ -1722,11 +1745,11 @@ int x86emul_decode(struct x86_emulate_st break; case simd_scalar_opc: - s->op_bytes = 4 << (ctxt->opcode & 1); + s->op_bytes = 2 << (!s->fp16 + (ctxt->opcode & 1)); break; case simd_scalar_vexw: - s->op_bytes = 4 << s->vex.w; + s->op_bytes = 2 << (!s->fp16 + s->vex.w); break; case simd_128: --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -305,6 +305,7 @@ struct x86_emulate_state { bool lock_prefix; bool not_64bit; /* Instruction not available in 64bit. */ bool fpu_ctrl; /* Instruction is an FPU control one. */ + bool fp16; /* Instruction has half-precision FP source operand. */ opcode_desc_t desc; union vex vex; union evex evex; @@ -592,6 +593,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_avx512_vp2intersect() (ctxt->cpuid->feat.avx512_vp2intersect) #define vcpu_has_serialize() (ctxt->cpuid->feat.serialize) #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) +#define vcpu_has_avx512_fp16() (ctxt->cpuid->feat.avx512_fp16) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1300,7 +1300,7 @@ x86_emulate( b = ctxt->opcode; d = state.desc; #define state (&state) - elem_bytes = 4 << evex.w; + elem_bytes = 2 << (!state->fp16 + evex.w); generate_exception_if(state->not_64bit && mode_64bit(), EXC_UD); @@ -7145,6 +7145,15 @@ x86_emulate( avx512_vlen_check(b & 2); goto simd_imm8_zmm; + case X86EMUL_OPC_EVEX(0x0f3a, 0x0a): /* vrndscalesh $imm8,xmm/mem,xmm,xmm{k} */ + generate_exception_if(ea.type != OP_REG && evex.brs, EXC_UD); + /* fall through */ + case X86EMUL_OPC_EVEX(0x0f3a, 0x08): /* vrndscaleph $imm8,[xyz]mm/mem,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + avx512_vlen_check(b & 2); + goto simd_imm8_zmm; + #endif /* X86EMUL_NO_SIMD */ CASE_SIMD_PACKED_INT(0x0f3a, 0x0f): /* palignr $imm8,{,x}mm/mem,{,x}mm */ @@ -7455,6 +7464,14 @@ x86_emulate( avx512_vlen_check(false); goto simd_imm8_zmm; + case X86EMUL_OPC_EVEX(0x0f3a, 0x26): /* vgetmantph $imm8,[xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX(0x0f3a, 0x56): /* vreduceph $imm8,[xyz]mm/mem,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + if ( ea.type != OP_REG || !evex.brs ) + avx512_vlen_check(false); + goto simd_imm8_zmm; + case X86EMUL_OPC_EVEX_66(0x0f3a, 0x51): /* vranges{s,d} $imm8,xmm/mem,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x57): /* vreduces{s,d} $imm8,xmm/mem,xmm,xmm{k} */ host_and_vcpu_must_have(avx512dq); @@ -7467,6 +7484,16 @@ x86_emulate( avx512_vlen_check(true); goto simd_imm8_zmm; + case X86EMUL_OPC_EVEX(0x0f3a, 0x27): /* vgetmantsh $imm8,xmm/mem,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX(0x0f3a, 0x57): /* vreducesh $imm8,xmm/mem,xmm,xmm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + if ( !evex.brs ) + avx512_vlen_check(true); + else + generate_exception_if(ea.type != OP_REG, EXC_UD); + goto simd_imm8_zmm; + case X86EMUL_OPC_VEX_66(0x0f3a, 0x30): /* kshiftr{b,w} $imm8,k,k */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x32): /* kshiftl{b,w} $imm8,k,k */ if ( !vex.w ) @@ -7630,6 +7657,16 @@ x86_emulate( avx512_vlen_check(true); goto simd_imm8_zmm; + case X86EMUL_OPC_EVEX(0x0f3a, 0x66): /* vfpclassph $imm8,[xyz]mm/mem,k{k} */ + case X86EMUL_OPC_EVEX(0x0f3a, 0x67): /* vfpclasssh $imm8,xmm/mem,k{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w || !evex.r || !evex.R || evex.z, EXC_UD); + if ( !(b & 1) ) + goto avx512f_imm8_no_sae; + generate_exception_if(evex.brs, EXC_UD); + avx512_vlen_check(true); + goto simd_imm8_zmm; + case X86EMUL_OPC_EVEX_66(0x0f3a, 0x70): /* vpshldw $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x72): /* vpshrdw $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ generate_exception_if(!evex.w, EXC_UD); @@ -7640,6 +7677,16 @@ x86_emulate( host_and_vcpu_must_have(avx512_vbmi2); goto avx512f_imm8_no_sae; + case X86EMUL_OPC_EVEX_F3(0x0f3a, 0xc2): /* vcmpsh $imm8,xmm/mem,xmm,k{k} */ + generate_exception_if(ea.type != OP_REG && evex.brs, EXC_UD); + /* fall through */ + case X86EMUL_OPC_EVEX(0x0f3a, 0xc2): /* vcmpph $imm8,[xyz]mm/mem,[xyz]mm,k{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w || !evex.r || !evex.R || evex.z, EXC_UD); + if ( ea.type != OP_REG || !evex.brs ) + avx512_vlen_check(evex.pfx & VEX_PREFIX_SCALAR_MASK); + goto simd_imm8_zmm; + case X86EMUL_OPC(0x0f3a, 0xcc): /* sha1rnds4 $imm8,xmm/m128,xmm */ host_and_vcpu_must_have(sha); op_bytes = 16; From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:57:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:57:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517483.802859 (Exim 4.92) (envelope-from ) id 1pjLci-0006VK-52; Mon, 03 Apr 2023 14:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517483.802859; Mon, 03 Apr 2023 14:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLci-0006VD-1q; Mon, 03 Apr 2023 14:57:32 +0000 Received: by outflank-mailman (input) for mailman id 517483; Mon, 03 Apr 2023 14:57:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLch-00066R-0F for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:57:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7e1a::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db14c9b8-d22f-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:57:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:57:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:57:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db14c9b8-d22f-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UMX/oiOvfeZBVNHcbouIPbM3AbxdRxjiOtL9x3JLGk1sZoQ9BtjJpE5Rr9HDWw8HphwMd/jYD22Udb1uZTT9LHQPHCKcDFGkW9GZrrPBEJOye87zWjTSqaMi4ML3mO3WGkkNRDojBNk9klh8o5XBpdipMkqKaBjUoJ3psIxWLfCclwgMBSCWf0m2AJOx3lQQ03busDcU4sysBO3Pm3dXGgIkUWiJzqBGIbWjfqV/ZPGjxIyqveHBe3pWZyeBJ0wr1Y1ETOz5ewAsSxVQXM4aKUmKb3bawOvzlzUa+HMGTiUuV6z1+1K6u1HDY7OKR/sCSD2Umt72z49UNypny8A4Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ssUjHs4HRn1b92pvEP2D8LrncOpBCibcR/DS6rD4XMw=; b=BrQX8T1/bUH8Xy6WLQ/2NC62yROU8KjcQ9L/LAJtMhbEeqs6NNLPfZbLVVvPpOWAIjv+A5bAtgMblDnQYMhhQoY4FeaE1pgdzAuIUPbxQj6z0h8M4MAsiwvS3ZE+n30xAKBkURPkRbMSjWDmNppuW9zSP7pwAJh6oqK91nH8QqgB33Zp74E21P6dSUPoGTuHbNtAnQBlNwT3C2jiwOC062XtXFb3v0k2iSOlxXHf44sEhwFoS2DWkjcytPmzsakTeZJjANc1Pu+UGFQKDzE2//A2jkWE75WnO67vJjjvsYamHjOQQUTmbL8lTH22hmdi6etigxy4cAWgZZ8V8OAHtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ssUjHs4HRn1b92pvEP2D8LrncOpBCibcR/DS6rD4XMw=; b=o5RVHHfqLGXbNMPqfLnyNN0oyTzROtsUC8vJyGyf6I1/oqrpgn2UXeQJpzoAc3gdVG6sEcd7+orQ710AJxrlvEykaRppSTtozKRPATsTKplIVw756v+NJj7bbK7vG7XwTdOklFxMTw7dsmYo6SHSyLuR+LjhPLTMD6n4lZ5i7YdLzgq7MLaWGpFGjo+ok84vcCiLTLToJan1tfZEjeridVjxpaXEgftc383cJ1wjTXB82hPvpHrKfeHNj2UA7jSY184MpErTds2U8azJEFnAXbpRloRMKzZTujJxwG5xT6oW2YwiM5VDHnlQrIA9+nYnIn9SFxUlWe+U0tFmE8YfmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <111f6a32-0c2c-f586-f599-dd0c4451ba4e@suse.com> Date: Mon, 3 Apr 2023 16:57:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 02/10] x86emul: handle AVX512-FP16 Map5 arithmetic insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0178.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e6ca9d1-9c36-4c89-1486-08db3453bdaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MZl8oLiU2OSkr+EBCj64noQekDKaqy6rI5lW79mgjxOjZiF+vWhovzGbIYH2TXVCsNuG8Wj/pMJAzLvWHmkJLYxH9jx3Jbxz/q9DY7RiL+dIQqT4FQu1KB3kQSDn2pYsuJvmn0QVsRjX75lh432wsNbtBaWTEoV6AwI0olPVrf8sr3LZzACccakHLipARDvttiEW90cfH+HJ2cAx6NqgOJNNGoYZxTxBSGN2Bs/HtCIVIYEkFcke3IQy1Y2jOGvFyIoZsNWS9mNdiIKrVAKASqvUQEoPYfLYO8FgkkdeDL688PihN1Z18SoBJW57zS4K8CBTpUsPMCNVKiZZ+TPKAh6ULzxHoZejm6XKqtp7RhlSrYm5PpGNr5Oafia0FCVLjC54CdQ9FhQvm95tnS13lFK6LY8BrBz3hyM08dECWDvmjz7+IiM7drhkBPyWhgmu2F94bG6H61ZIOUeK6zzCHfSVGYkg0qlCkIEK5uJzGxBFngWarfATIFm/Qq60Cus7AsK4jJOKsW84qzNvPEF7HiiWZ14CWXbHwBUTCbKljGGHQ7T8vgsRbeD5YSk0kmJE6ln1k0iqexzt3nifkzTs9G6DSv84B3MUxv/VZWZGVd9fkM+kuJlt1dwyG7IF652O/jzhI8fw6mFT3+wv5CgRag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm5FSlBNZGE2Q0R5MGFaK2ZKZlRMbWZVeGlramNFWnlhNkxhczhyQnMrVFhj?= =?utf-8?B?ME1VMWlXdmRTUEhxRG9NOGNnQ3dnVnpQYnVoVXZTeU85UjVXaitCZGViODBx?= =?utf-8?B?KzdhTjB5bGdWQm85UVlINUpmUjErVXBWRmpsS3NRVGVnblltazVsSEYwYVo2?= =?utf-8?B?MHQ5cm15Q093b0dMRnppelRkMUJXTXU2cmlkNmJ1T3NiWWJTeHkwK1pYTEhq?= =?utf-8?B?UXBjVlVCcUdSQ0Mwb3RlN3lLK3hVY00yOHZrZk51OWluaCt3NWR1S3h1NHBV?= =?utf-8?B?VTdVaHhRM29Vc0o4NlhFS2p5OWRpVUh2Rmk2NHRaRHJvVEFvMlJlamVEOUxJ?= =?utf-8?B?eXZqMitkTnpLMkJ6RVVtRkY0YTlyTlppcCtPdi91VmZRZlYrZDBSa2NXWTZP?= =?utf-8?B?YUlnWlYrUGNpUVJTNTNETUg3VnZDVGVGQlRiRUxYWU9rM0dIb011S2ZiU1NI?= =?utf-8?B?UWFJR2RYNGxLVFRTZy91V3VJQjVWK0p4bjMrcjYrVDVneS82UnVjWnhJbmhH?= =?utf-8?B?UHNzWUhVeWhIUVpGZVpEWTVveGFvUlVFemhUUnFEL0YyeHNUWThyTjZkano5?= =?utf-8?B?WjNLWUxHdGQ2OUNkQjE3V0Z2cTdyU1V6bVVjMitYY25rTmMra2Q0eVpTNzFu?= =?utf-8?B?cHlKeW1jY2gvaVhVbkwyYzcvbFlQVVBORW9yMDRENG1Bc1JsOTVXTjRDVzlw?= =?utf-8?B?alU2K3IrSStVWWVHVlFEU0hkN05YQkdQUStGdWYrNDY2QU0vYUZqMkhRQXNL?= =?utf-8?B?dElnbkVPY3c3b0tNTHlWTEthWis5VFBRMytwMHVTTGI2OUcxUkwwbEdHQzZQ?= =?utf-8?B?Z3BhVlhNdWo1Ung2RWxyeHJJTVh0RUJNSmhhVFpBeWVpN0ZPQzc0S20vbFZm?= =?utf-8?B?Tm5PMGpjaTZrNkxRSGxwSTZDU2NmaTdmZk8wSDhLd0tmVWFWRndUZUZsVXA2?= =?utf-8?B?TlNUZGlEV0RWckVhK1Y4VTNBVWhEVzJZNnRyUndrbWxac1Z3cTRwSWh6OEUr?= =?utf-8?B?dGRBV0hNclpmd3JtbHk0Vy9YbHZ0WDNIQVgwdXNjNlQ2RmpSZDQ1WG9KNnFV?= =?utf-8?B?NHl4NXIxMGExcmFSV1NzaFBNWVBNcXgvaDRPMVRUWjJxYnJLYnlObTFwZksr?= =?utf-8?B?dnRlVmFCMWIxTlRDeUtzOWRHOU5FMnVBYUZ6VmxmNjZ4Qm9LTFVQVDFhUUN0?= =?utf-8?B?QWRDbXlOc0NCcCswQ1VhWlkxSWpIcjJuK0Z3bklETGJabmJnV0NvODF4WVYy?= =?utf-8?B?QXFDVU1lZnFRdUJlcUxGL1c4amI5NFZiOEsrZ1hqNTJBUkNzN2FEMkVhYmpV?= =?utf-8?B?L3lVeng5a2ZsUnZWN1FJNWZVSGVta3FMcXh2VmgzUXpuakE5UFJDNTZXWlVZ?= =?utf-8?B?MEZhNDVSckQ3V1J0bUxaZGZvNkNiMVB6NWg1SGYyWWI5S3ltN1BxSW1YWk4x?= =?utf-8?B?d3Z6S1R0aGF3NWxTdVRUVFR4WG1rRXZlbEZTMko5bnJxVzlNc1ZYUUNQdmEv?= =?utf-8?B?blk3eXRMazE4dkF6YVphWFNxc2RGSmE4QitNd01FMHlVVEE3YzVoaHNJM0h6?= =?utf-8?B?YjhZNzR6SzEreTRkN3NVMFcyNE5BdHZuekhpTkEvcExSSEtSOEQ5Y3h3OFFn?= =?utf-8?B?OUE0R1RJZmJCeWcvS2NGNGJLeFdiaHZVRmlzdEFqeVRLT3Y0anZEOTBFZnhW?= =?utf-8?B?cE1mRWdOeWYzTDNqTmpJRVJMTHJ1NkYray9CSWFPTjYvWTFhYjBuU2FCeTdw?= =?utf-8?B?MjYwQnN2bFFUdXprQU4wcUJ0RHdRU0dwQy8vL3M5dE5VQmc5Q01CdmdRZDhk?= =?utf-8?B?cUtidUVCemhxazJMYWJzckpwbjdaUy9Oai9qTWRtSVI4aGt0cy8waElvbCt1?= =?utf-8?B?NnNuYmcwZzUrK2d0czhOeHFFOWU4UGVUbkZib1NlTGF0clFOcGI2YWxuR3Yw?= =?utf-8?B?Z3p2bCs0SkdVWFZGZlhLNFdGVmhYTjduWkdaUiticTd0V2NYbmlJQnVPazRP?= =?utf-8?B?Z05HNDlJcCtYNk52bmxVR212MUNyQmNZcVpOam1ZNStvaFN3RStNZkJVaGZr?= =?utf-8?B?VnMwbUtjWXJsUVJBQmhINzlVOXdmUm5yODc2dFc2V0V4d0lIWWdLU2U5N1J3?= =?utf-8?Q?3vM0szKgt2TwLvoJNt+Wv3XnP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6ca9d1-9c36-4c89-1486-08db3453bdaa X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:57:27.3441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: no+s59NY7tbs+KlkGZaWRTTg5bS6SZ+QKvVAYQH7a4jGr2EGzAhKY4kRg1FimUp9XYHgDcCl0kw4pEcFvsR65w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 This encoding space is a very sparse clone of the "twobyte" one. Re-use that table, as the entries corresponding to invalid opcodes in Map5 are simply benign with simd_size forced to other than simd_none (preventing undue memory reads in SrcMem handling early in x86_emulate()). Signed-off-by: Jan Beulich --- v2: Add comments. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -6,7 +6,7 @@ struct test { const char *mnemonic; unsigned int opc:8; - unsigned int spc:2; + unsigned int spc:3; unsigned int pfx:2; unsigned int vsz:3; unsigned int esz:4; @@ -19,6 +19,10 @@ enum spc { SPC_0f, SPC_0f38, SPC_0f3a, + SPC_unused4, + SPC_map5, + SPC_map6, + SPC_unused7, }; enum pfx { @@ -603,16 +607,32 @@ static const struct test avx512_vpopcntd }; static const struct test avx512_fp16_all[] = { + INSN(addph, , map5, 58, vl, fp16, vl), + INSN(addsh, f3, map5, 58, el, fp16, el), INSN(cmpph, , 0f3a, c2, vl, fp16, vl), INSN(cmpsh, f3, 0f3a, c2, el, fp16, el), + INSN(comish, , map5, 2f, el, fp16, el), + INSN(divph, , map5, 5e, vl, fp16, vl), + INSN(divsh, f3, map5, 5e, el, fp16, el), INSN(fpclassph, , 0f3a, 66, vl, fp16, vl), INSN(fpclasssh, , 0f3a, 67, el, fp16, el), INSN(getmantph, , 0f3a, 26, vl, fp16, vl), INSN(getmantsh, , 0f3a, 27, el, fp16, el), + INSN(maxph, , map5, 5f, vl, fp16, vl), + INSN(maxsh, f3, map5, 5f, el, fp16, el), + INSN(minph, , map5, 5d, vl, fp16, vl), + INSN(minsh, f3, map5, 5d, el, fp16, el), + INSN(mulph, , map5, 59, vl, fp16, vl), + INSN(mulsh, f3, map5, 59, el, fp16, el), INSN(reduceph, , 0f3a, 56, vl, fp16, vl), INSN(reducesh, , 0f3a, 57, el, fp16, el), INSN(rndscaleph, , 0f3a, 08, vl, fp16, vl), INSN(rndscalesh, , 0f3a, 0a, el, fp16, el), + INSN(sqrtph, , map5, 51, vl, fp16, vl), + INSN(sqrtsh, f3, map5, 51, el, fp16, el), + INSN(subph, , map5, 5c, vl, fp16, vl), + INSN(subsh, f3, map5, 5c, el, fp16, el), + INSN(ucomish, , map5, 2e, el, fp16, el), }; static const struct test gfni_all[] = { @@ -713,8 +733,8 @@ static void test_one(const struct test * union evex { uint8_t raw[3]; struct { - uint8_t opcx:2; - uint8_t mbz:2; + uint8_t opcx:3; + uint8_t mbz:1; uint8_t R:1; uint8_t b:1; uint8_t x:1; --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2028,6 +2028,23 @@ static const struct evex { { { 0xc2 }, 3, T, R, pfx_f3, W0, LIG }, /* vcmpsh */ { { 0xce }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineqb */ { { 0xcf }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineinvqb */ +}, evex_map5[] = { + { { 0x2e }, 2, T, R, pfx_no, W0, LIG }, /* vucomish */ + { { 0x2f }, 2, T, R, pfx_no, W0, LIG }, /* vcomish */ + { { 0x51 }, 2, T, R, pfx_no, W0, Ln }, /* vsqrtph */ + { { 0x51 }, 2, T, R, pfx_f3, W0, LIG }, /* vsqrtsh */ + { { 0x58 }, 2, T, R, pfx_no, W0, Ln }, /* vaddph */ + { { 0x58 }, 2, T, R, pfx_f3, W0, LIG }, /* vaddsh */ + { { 0x59 }, 2, T, R, pfx_no, W0, Ln }, /* vmulph */ + { { 0x59 }, 2, T, R, pfx_f3, W0, LIG }, /* vmulsh */ + { { 0x5c }, 2, T, R, pfx_no, W0, Ln }, /* vsubph */ + { { 0x5c }, 2, T, R, pfx_f3, W0, LIG }, /* vsubsh */ + { { 0x5d }, 2, T, R, pfx_no, W0, Ln }, /* vminph */ + { { 0x5d }, 2, T, R, pfx_f3, W0, LIG }, /* vminsh */ + { { 0x5e }, 2, T, R, pfx_no, W0, Ln }, /* vdivph */ + { { 0x5e }, 2, T, R, pfx_f3, W0, LIG }, /* vdivsh */ + { { 0x5f }, 2, T, R, pfx_no, W0, Ln }, /* vmaxph */ + { { 0x5f }, 2, T, R, pfx_f3, W0, LIG }, /* vmaxsh */ }; static const struct { @@ -2037,6 +2054,8 @@ static const struct { { evex_0f, ARRAY_SIZE(evex_0f) }, { evex_0f38, ARRAY_SIZE(evex_0f38) }, { evex_0f3a, ARRAY_SIZE(evex_0f3a) }, + { NULL, 0 }, + { evex_map5, ARRAY_SIZE(evex_map5) }, }; #undef Wn --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1219,9 +1219,22 @@ int x86emul_decode(struct x86_emulate_st opcode |= MASK_INSR(0x0f3a, X86EMUL_OPC_EXT_MASK); d = twobyte_table[0x3a].desc; break; + + case evex_map5: + if ( !evex_encoded() ) + { default: - rc = X86EMUL_UNRECOGNIZED; - goto done; + rc = X86EMUL_UNRECOGNIZED; + goto done; + } + opcode |= MASK_INSR(5, X86EMUL_OPC_EXT_MASK); + /* + * Re-use twobyte_table[] here, for the similarity of + * the entries valid in map 5. + */ + d = twobyte_table[b].desc; + s->simd_size = twobyte_table[b].size ?: simd_other; + break; } } else if ( s->ext < ext_8f08 + ARRAY_SIZE(xop_table) ) @@ -1443,6 +1456,25 @@ int x86emul_decode(struct x86_emulate_st } break; + case ext_map5: + switch ( b ) + { + default: + if ( !(s->evex.pfx & VEX_PREFIX_DOUBLE_MASK) ) + s->fp16 = true; + break; + + case 0x2e: case 0x2f: /* v{,u}comish */ + if ( !s->evex.pfx ) + s->fp16 = true; + s->simd_size = simd_none; + break; + } + + /* Like above re-use twobyte_table[] here. */ + disp8scale = decode_disp8scale(twobyte_table[b].d8s, s); + break; + case ext_8f09: if ( ext8f09_table[b].two_op ) d |= TwoOp; @@ -1661,6 +1693,7 @@ int x86emul_decode(struct x86_emulate_st s->simd_size = ext8f08_table[b].simd_size; break; + case ext_map5: case ext_8f09: case ext_8f0a: break; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -195,6 +195,7 @@ enum vex_opcx { vex_0f = vex_none + 1, vex_0f38, vex_0f3a, + evex_map5 = 5, }; enum vex_pfx { @@ -223,8 +224,8 @@ union vex { union evex { uint8_t raw[3]; struct { /* SDM names */ - uint8_t opcx:2; /* mm */ - uint8_t mbz:2; + uint8_t opcx:3; /* mmm */ + uint8_t mbz:1; uint8_t R:1; /* R' */ uint8_t b:1; /* B */ uint8_t x:1; /* X */ @@ -249,6 +250,7 @@ struct x86_emulate_state { ext_0f = vex_0f, ext_0f38 = vex_0f38, ext_0f3a = vex_0f3a, + ext_map5 = evex_map5, /* * For XOP use values such that the respective instruction field * can be used without adjustment. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -3756,6 +3756,13 @@ x86_emulate( ASSERT(!state->simd_size); break; +#ifndef X86EMUL_NO_SIMD + + case X86EMUL_OPC_EVEX(5, 0x2e): /* vucomish xmm/m16,xmm */ + case X86EMUL_OPC_EVEX(5, 0x2f): /* vcomish xmm/m16,xmm */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + /* fall through */ CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x2e): /* vucomis{s,d} xmm/mem,xmm */ CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x2f): /* vcomis{s,d} xmm/mem,xmm */ generate_exception_if((evex.reg != 0xf || !evex.RX || evex.opmsk || @@ -3768,9 +3775,11 @@ x86_emulate( get_fpu(X86EMUL_FPU_zmm); opc = init_evex(stub); - op_bytes = 4 << evex.w; + op_bytes = 2 << (!state->fp16 + evex.w); goto vcomi; +#endif + case X86EMUL_OPC(0x0f, 0x30): /* wrmsr */ generate_exception_if(!mode_ring0(), EXC_GP, 0); fail_if(ops->write_msr == NULL); @@ -7736,6 +7745,20 @@ x86_emulate( #ifndef X86EMUL_NO_SIMD + case X86EMUL_OPC_EVEX_F3(5, 0x51): /* vsqrtsh xmm/m16,xmm,xmm{k} */ + d &= ~TwoOp; + /* fall through */ + case X86EMUL_OPC_EVEX(5, 0x51): /* vsqrtph [xyz]mm/mem,[xyz]mm{k} */ + CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x58): /* vadd{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x59): /* vmul{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x5c): /* vsub{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x5d): /* vmin{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x5e): /* vdiv{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x5f): /* vmax{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + goto avx512f_all_fp; + case X86EMUL_OPC_XOP(08, 0x85): /* vpmacssww xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x86): /* vpmacsswd xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x87): /* vpmacssdql xmm,xmm/m128,xmm,xmm */ --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -619,6 +619,7 @@ struct x86_emulate_ctxt * 0x0fxxxx for 0f-prefixed opcodes (or their VEX/EVEX equivalents) * 0x0f38xxxx for 0f38-prefixed opcodes (or their VEX/EVEX equivalents) * 0x0f3axxxx for 0f3a-prefixed opcodes (or their VEX/EVEX equivalents) + * 0x5xxxx for Map5 opcodes (EVEX only) * 0x8f08xxxx for 8f/8-prefixed XOP opcodes * 0x8f09xxxx for 8f/9-prefixed XOP opcodes * 0x8f0axxxx for 8f/a-prefixed XOP opcodes From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:57:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:57:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517486.802869 (Exim 4.92) (envelope-from ) id 1pjLcz-00074D-DE; Mon, 03 Apr 2023 14:57:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517486.802869; Mon, 03 Apr 2023 14:57:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLcz-000746-9r; Mon, 03 Apr 2023 14:57:49 +0000 Received: by outflank-mailman (input) for mailman id 517486; Mon, 03 Apr 2023 14:57:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLcy-00066R-Bz for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:57:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1a::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e55c288d-d22f-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:57:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:57:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:57:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e55c288d-d22f-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4Fx248CscoJ4WRIKQ0QGNnVid4Fv/K8U6cYb5HD42xPpX7Waq8Reahrvn08N6SOaEJoXjZRwTH3PNVD9EDmeawJCZqCJnTMjSiTJwVZOhYh6W1vmhjhsFwHeImaMdLQ3MdO/6w7BrMbskrgVXf+mV3B3GTAXHTwfLNHC3l1T23+TpcQ3tNexDX6BSI1r5gq+0TfvuYkPnNQAB0223+6IWTseRdEtEFJXalt2umjAgXkMNhGwn7OFXYk252am0KqZRxfU1eRM9HE8o84rZmB16VvyL5BlckRV6QlbnzvMj6POMxPYlTh8Q7k5XyzymH4tt1xoB9MqFjt+X3OxmuwVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y99XU3et9c84vJqhU6TL+qqpPQD4yDAwck0bIDW2RGA=; b=j9UxJBO6JgFcM8nLZ0AumNAYaP42R1/NsW2IyOWNdVQ6U3vfjzJHgBvEpHV8bTklI8EwAPM1TP0iJ4JD+ESj0bKKdTvBTF8A+2V6QWlN00YdHq2GiV4+yFUYklwgx/TNr31mRe4NZHe/7FgaZbxXr4aV0Z6X2kO1P6ymj8PaC/TgC02KhWvbHwF+MCmB2xjkpPyzZ+Ep+3iFWZrsVcEIpP5tFG3F6CVnhbF4FHbgXf7toIDGHpi2Ko9/AxZ23M3e/nCm3VusqpjtL/hYzgvV8oGiJVvAb7hFpT8R0pgj1C9lBboNafNYiXr2oaq0HnKRzNKoVE/Ba7tGWIcwXRWErg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y99XU3et9c84vJqhU6TL+qqpPQD4yDAwck0bIDW2RGA=; b=LEISKkaZBCIQmO7WrEQI09DY4XFGlQnoKu5eHyGc24yicxPCfHZ16s9aJdfl26xHuBgxmncTW6eTdJmC6l4eOXKk1y3L04v6TlJfyRQ6v/7ARaR3VaABANkl3X1OrYFD7DtwAbYzFk9XoaAekVuDLIH8GZtudGi0fKvj0CGz1pT48MB2bIuSDUR2YjFCxCMzxAXGmnKkbH5xVO+44mxh7I7+i303kbZFnyc4tK6KsAMn8JCFaACNc7V5U48YIARbKmKHohUenlUnEgqKy6Jh95NPZyGdLJbJID/pQ4+TcBNj4d5MiIyTpaPYoWaqO9NoCWQGXxffOntZT3QbjPcCCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 16:57:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 03/10] x86emul: handle AVX512-FP16 move insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 305e6770-76fb-45c5-afaf-08db3453c8bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: juWwsLcDWMj12svgVwg+Yr3h9M/35BM7crTmON3ZDAaL9D9ys2Y5vCYAhwv/ajeZgsOUpG1bils1M+uO3TLC7bJtaz9giW1bVk948OpMzPINm/zdlZq2MOXVdXnt0TBYIi/w623Q9NvSghcuohq5uqtxjINpnpLDIVoKGCLoKrE1DReuELAoCnwOer/rWp+9E2XYnzw6bAJZaNpVLkjpzlfaR0r8gzvcpZ3J0vIcej/fDynF+U3FoTiMKNy27/mtcBuItKZYJVj0yvfUJPtHq1KotkOF7jiPbyGAKXZ7yC8SiOdaKAIwjsadvYYGyxBjcc3lfr5pLXL1+yMACGevKzCgl9aKNBI7nPZ1GwW78UFlmnMcNECVYzDBdwe+WkKVWT1LjYk+H3BKQI/n1AgP8+3i7Em65oVr2tHmo5EVEtyIfL9lF3db87KnVDOBfd786BUP6cJHiHlkKUkstdWGOF1mdwSdLM+4rAyIDmNoFsrlzZP/vpK3ssDp6l8AU/tXmTU8+8e8QnxSxuQp8Y5Ypvf0NeyC/mVWlPeapBDPXexMrTj5lZkBYa4AjO88qgXJlA+k8sO57RDYUMCFTMIzjSCEvfO0x91Ks26KP1mkrT3jzy7OVANCIy4P4o7gzk+bu72IomcLT9+Db64uk8EcfQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnFlUTdseDA2bXZDaEhPWnRmZjd5UXppcXRLTzd0SVJydmFybHg0eElOak5Z?= =?utf-8?B?NkMyb1RvU0NWTWlpb0tNR0p0NXhqRXk1U01rdHhnZkJxN0tOVmljS3NhMFll?= =?utf-8?B?R0Q2LzFjVmpBUURaRU9WT3FRaTZBNURIR2RESW1XbXhsRjhLTUcyYzd0eHVK?= =?utf-8?B?UUpwOERHUjgxcnpzMnlmbGZ3VVh5V2E0eHNHTUh6RXVIUTZHMzhvVG1ZSWJN?= =?utf-8?B?UHJGV044T1FLb05IMTdEeE0vNFhydW95cXV1bzNFOEloS2M1V2dhV3ZDL1NH?= =?utf-8?B?Yjl1UW5lQk9ldEVua3VPUlZOQWRzYS9aSTQ3dm40enV5dGtCdGpWS3VwUEVn?= =?utf-8?B?MTBRMFFXUEVFN0ZnZXVVelJiV0tpTHlUTUcxN2pPNm1pd3AvaDJoanJNcjR0?= =?utf-8?B?M0xXSmh5NWlwaHJRSzRzRVRjNkJSN1NwQlV5SHlZb1JwbkRFTFVSVVNVODhV?= =?utf-8?B?bCt3ZE82SWhTc0pPWHBEcmVKdkk5d2RrUGlJM0VuNGZoZ1pUdHRrV05Bbnpi?= =?utf-8?B?dXpzYk9pSmFYM1FmVkVId1FsU0ZEdHM2MGtiSzc4bUlrVHRpbUpIOEJnRnVM?= =?utf-8?B?dS83L1BNVk1sK0o4ZDlPTDV5ZGNVZEJXL3JYT0RLcFpsd2tYdnh6cm1sWmRI?= =?utf-8?B?UFR4aXZVb25NZnJZL0FZWVEvdDJXT0RDeXlIcEdJblYrNVNscG5LKzkwb2pk?= =?utf-8?B?WEEvajdLMTBXNUF0SWlrTjhCdXlwUURubHN2N0s3ZDkxUmQrYkl1UHl3ckc5?= =?utf-8?B?YStqWm1iT1ZyUWl4NHJKbWVwNmFKb2o0NzduRmY3cEtCNS9KbStCa1lKbHNV?= =?utf-8?B?cnNuV2h0MGdzWERZVDFyTXlCeFNtN3Z3WTJmMVBVK1NBcFc4ZU1nTTcxcFVv?= =?utf-8?B?a0hxblJqSnB4OXVnUjdtZ0FaUkpqVnoyZWNqOTRWaC9KV3ZieGdiMGJnN3pv?= =?utf-8?B?RnFhK2R6V1Jnc3hMY0NEdWh6WE90T0FZdVd5RFJjaWVVQUd6M2gwMXBuMzdw?= =?utf-8?B?bGFCVk1WQUhNK3dnRzFTSjI0RkVTeG1rbnQ0ZnQ5ZFNQRktYdVZCMEVtTmdM?= =?utf-8?B?VTFuaGN5aUNkMjlwTTNnbUVRaFlqb3U3clZja2ZiSkZqRnBQcWplMFNiR0l6?= =?utf-8?B?TlFKbFZwYzJBRVA1UDBLaFVRWUFHS0h6Ym5LQ2laTWlYYnhDYjgwMWlXUnM3?= =?utf-8?B?d0w5T09VQVBVeGFqMXBwTEZHMi9FYlBKa3pBL0xycUJqbFpaQUQrL1d4L0tL?= =?utf-8?B?OU5wYUlsTXU5MWo0d0tNSE9tTE5aaUZ4NW5xVVU2ZW0raG93cktkZjhUWXlo?= =?utf-8?B?OE9hWVV4Q2hjNDdlUzdOWXMxeE9RZUlEMG5LZ0FteUdTWjlqS1ZFM3dTSG5C?= =?utf-8?B?VzdoUXJyVUlMZFduVytsVkhKM0tna1VnbllCQytjalM5TWNLV21sTjUranZK?= =?utf-8?B?TTVueUdXbHRwMG91dHcyRHRCbC8yeHVLbzV3RjdISlRwbTFia1hIZ2xiRXZN?= =?utf-8?B?Z0Z4aVJyWXRpQkxqenhuZXpUdmlSQ1cvS0hzY3BiWFJFbmtqL2VWL00vWUV6?= =?utf-8?B?YzJ2TkFWWU1sMUgrVzB1WTVzc2pFOUE0VExPYjNNb2RheUpkNmczMkJ1RjJs?= =?utf-8?B?bGpvUVdKeTlkbXBxdWh5cm5BRUZORTZPQ0Z5MnRlNGJheDJRai9qT2FxTUMw?= =?utf-8?B?eU92bkpsTzZJVk5udFErVmcveXBRckhjOG5lZGxob1RSU0R2UHBIQmJPenA1?= =?utf-8?B?NUN0Rkpuc3FXdzFZUEk2QWdZSExlbTRNbCsvaWx5NjVHSjRHeU42eGhCbGk5?= =?utf-8?B?QzZBdTYwakZxaFAwOFArekcwa0NVOVhuSGNnb1A3YXJjdGd1ZUQ0c3RtTzFV?= =?utf-8?B?OFZ4TEJyeDY3eHJWWUlrb1lIdENEd0p0Mk5nTnNRa2E2N3pBVzJLdThPb0RL?= =?utf-8?B?c0Q4Y3VEbnhnWjg3S2toRjg0Mzh1RDVMNGt5NjRkN3ArVEN0NlU0eTBkSDJm?= =?utf-8?B?OFRnV1ZEWk85VkdQMGJCeGwrelFrL1A5V1A0YUtQQnlUU1o0NlFQSlZsSE1t?= =?utf-8?B?TjF2SzlFL2VnUCtPODJhM3pqK29LNEwwbWtySVBIT2hTcUFZQUxOQXUvdmg1?= =?utf-8?Q?Kw11USetWsaRwNeGwqQwd2i/S?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 305e6770-76fb-45c5-afaf-08db3453c8bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:57:45.9815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kNFNG1nkNpIvNdHSW+8U6RoBeBEl1fwDCoWnMH/Z0IuM81NMWrWFhAnVzIjobBw+I9u0Do0O15xRGXMlAVzqYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -622,6 +622,8 @@ static const struct test avx512_fp16_all INSN(maxsh, f3, map5, 5f, el, fp16, el), INSN(minph, , map5, 5d, vl, fp16, vl), INSN(minsh, f3, map5, 5d, el, fp16, el), + INSN(movsh, f3, map5, 10, el, fp16, el), + INSN(movsh, f3, map5, 11, el, fp16, el), INSN(mulph, , map5, 59, vl, fp16, vl), INSN(mulsh, f3, map5, 59, el, fp16, el), INSN(reduceph, , 0f3a, 56, vl, fp16, vl), @@ -635,6 +637,11 @@ static const struct test avx512_fp16_all INSN(ucomish, , map5, 2e, el, fp16, el), }; +static const struct test avx512_fp16_128[] = { + INSN(movw, 66, map5, 6e, el, fp16, el), + INSN(movw, 66, map5, 7e, el, fp16, el), +}; + static const struct test gfni_all[] = { INSN(gf2p8affineinvqb, 66, 0f3a, cf, vl, q, vl), INSN(gf2p8affineqb, 66, 0f3a, ce, vl, q, vl), @@ -1039,6 +1046,7 @@ void evex_disp8_test(void *instr, struct RUN(avx512_vp2intersect, all); RUN(avx512_vpopcntdq, all); RUN(avx512_fp16, all); + RUN(avx512_fp16, 128); if ( cpu_has_avx512f ) { --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2029,6 +2029,8 @@ static const struct evex { { { 0xce }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineqb */ { { 0xcf }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineinvqb */ }, evex_map5[] = { + { { 0x10 }, 2, T, R, pfx_f3, W0, LIG }, /* vmovsh */ + { { 0x11 }, 2, T, W, pfx_f3, W0, LIG }, /* vmovsh */ { { 0x2e }, 2, T, R, pfx_no, W0, LIG }, /* vucomish */ { { 0x2f }, 2, T, R, pfx_no, W0, LIG }, /* vcomish */ { { 0x51 }, 2, T, R, pfx_no, W0, Ln }, /* vsqrtph */ @@ -2045,6 +2047,8 @@ static const struct evex { { { 0x5e }, 2, T, R, pfx_f3, W0, LIG }, /* vdivsh */ { { 0x5f }, 2, T, R, pfx_no, W0, Ln }, /* vmaxph */ { { 0x5f }, 2, T, R, pfx_f3, W0, LIG }, /* vmaxsh */ + { { 0x6e }, 2, T, R, pfx_66, WIG, L0 }, /* vmovw */ + { { 0x7e }, 2, T, W, pfx_66, WIG, L0 }, /* vmovw */ }; static const struct { --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -5140,6 +5140,76 @@ int main(int argc, char **argv) else printf("skipped\n"); + printf("%-40s", "Testing vmovsh 8(%ecx),%xmm5..."); + if ( stack_exec && cpu_has_avx512_fp16 ) + { + decl_insn(vmovsh_from_mem); + decl_insn(vmovw_to_gpr); + + asm volatile ( "vpcmpeqw %%ymm5, %%ymm5, %%ymm5\n\t" + put_insn(vmovsh_from_mem, + /* vmovsh 8(%0), %%xmm5 */ + ".byte 0x62, 0xf5, 0x7e, 0x08\n\t" + ".byte 0x10, 0x69, 0x04") + :: "c" (NULL) ); + + set_insn(vmovsh_from_mem); + res[2] = 0x3c00bc00; + regs.ecx = (unsigned long)res; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || !check_eip(vmovsh_from_mem) ) + goto fail; + asm volatile ( "kmovw %2, %%k1\n\t" + "vmovdqu16 %1, %%zmm4%{%%k1%}%{z%}\n\t" + "vpcmpeqw %%zmm4, %%zmm5, %%k0\n\t" + "kmovw %%k0, %0" + : "=g" (rc) + : "m" (res[2]), "r" (1) ); + if ( rc != 0xffff ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing vmovsh %xmm4,2(%eax){%k3}..."); + memset(res, ~0, 8); + res[2] = 0xbc00ffff; + memset(res + 3, ~0, 8); + regs.eax = (unsigned long)res; + regs.ecx = ~0; + for ( i = 0; i < 2; ++i ) + { + decl_insn(vmovsh_to_mem); + + asm volatile ( "kmovw %1, %%k3\n\t" + put_insn(vmovsh_to_mem, + /* vmovsh %%xmm4, 2(%0)%{%%k3%} */ + ".byte 0x62, 0xf5, 0x7e, 0x0b\n\t" + ".byte 0x11, 0x60, 0x01") + :: "a" (NULL), "r" (i) ); + + set_insn(vmovsh_to_mem); + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || !check_eip(vmovsh_to_mem) || + memcmp(res, res + 3 - i, 8) ) + goto fail; + } + printf("okay\n"); + + printf("%-40s", "Testing vmovw %xmm5,%ecx..."); + asm volatile ( put_insn(vmovw_to_gpr, + /* vmovw %%xmm5, %0 */ + ".byte 0x62, 0xf5, 0x7d, 0x08\n\t" + ".byte 0x7e, 0xe9") + :: "c" (NULL) ); + set_insn(vmovw_to_gpr); + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || !check_eip(vmovw_to_gpr) || + regs.ecx != 0xbc00 ) + goto fail; + printf("okay\n"); + } + else + printf("skipped\n"); + printf("%-40s", "Testing invpcid 16(%ecx),%%edx..."); if ( stack_exec ) { --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -585,7 +585,7 @@ static unsigned int decode_disp8scale(en break; case d8s_dq64: - return 2 + (s->op_bytes == 8); + return 1 + !s->fp16 + (s->op_bytes == 8); } switch ( s->simd_size ) @@ -1469,6 +1469,15 @@ int x86emul_decode(struct x86_emulate_st s->fp16 = true; s->simd_size = simd_none; break; + + case 0x6e: /* vmovw r/m16, xmm */ + d = (d & ~SrcMask) | SrcMem16; + /* fall through */ + case 0x7e: /* vmovw xmm, r/m16 */ + if ( s->evex.pfx == vex_66 ) + s->fp16 = true; + s->simd_size = simd_none; + break; } /* Like above re-use twobyte_table[] here. */ --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -4390,6 +4390,15 @@ x86_emulate( #ifndef X86EMUL_NO_SIMD + case X86EMUL_OPC_EVEX_66(5, 0x7e): /* vmovw xmm,r/m16 */ + ASSERT(dst.bytes >= 4); + if ( dst.type == OP_MEM ) + dst.bytes = 2; + /* fall through */ + case X86EMUL_OPC_EVEX_66(5, 0x6e): /* vmovw r/m16,xmm */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f, 0x6e): /* vmov{d,q} r/m,xmm */ case X86EMUL_OPC_EVEX_66(0x0f, 0x7e): /* vmov{d,q} xmm,r/m */ generate_exception_if((evex.lr || evex.opmsk || evex.brs || @@ -7745,8 +7754,18 @@ x86_emulate( #ifndef X86EMUL_NO_SIMD + case X86EMUL_OPC_EVEX_F3(5, 0x10): /* vmovsh m16,xmm{k} */ + /* vmovsh xmm,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_F3(5, 0x11): /* vmovsh xmm,m16{k} */ + /* vmovsh xmm,xmm,xmm{k} */ + generate_exception_if(evex.brs, EXC_UD); + if ( ea.type == OP_MEM ) + d |= TwoOp; + else + { case X86EMUL_OPC_EVEX_F3(5, 0x51): /* vsqrtsh xmm/m16,xmm,xmm{k} */ - d &= ~TwoOp; + d &= ~TwoOp; + } /* fall through */ case X86EMUL_OPC_EVEX(5, 0x51): /* vsqrtph [xyz]mm/mem,[xyz]mm{k} */ CASE_SIMD_SINGLE_FP(_EVEX, 5, 0x58): /* vadd{p,s}h [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:58:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:58:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517490.802879 (Exim 4.92) (envelope-from ) id 1pjLdS-0007l0-Oj; Mon, 03 Apr 2023 14:58:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517490.802879; Mon, 03 Apr 2023 14:58:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLdS-0007kt-Lk; Mon, 03 Apr 2023 14:58:18 +0000 Received: by outflank-mailman (input) for mailman id 517490; Mon, 03 Apr 2023 14:58:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLdQ-00066R-Ob for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:58:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7e1a::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6539507-d22f-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:58:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:58:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:58:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6539507-d22f-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqnEFc9p304BbjCR28meVw3Cgt/JGP1KNLoUbKnVLacoWdsNP90bat1sFpAujaGNvQaaCSGYPqp0dMf+GVAz3TyZ6ktSAgM8ZAmqPrDNA7FC10nB7P1CAjR4kIaaPD2Ej0z9sUrm0G0eRWz/cN1MI2u1cDcVBbMZX3NdGQNsjYQDZn6F4yu4RGWX8SyKeiwHoif3JZ1JgQF4B3Etd3BZyn/IaiwoFlUx69uMxIRkZt4/M/9EJFrEwBlyt3QCQFBhChrM2HNon4x//ER/GLvcxlN84XLsaMwqa1l2IVBzi6NClJNxefrTWEtAuLIhfmD/sILk+SfRBpobGNzVyjoYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oydr5RGLPiB/5UlaPCHWJTbrdc3fnjsbwu/jwCLiWIo=; b=TE+BkxGv3HX7deLzpjZOcZcPg9YOK3PVZ6EUVyuFgFy0+SnJdyPF0o8QyLYt5cOU2NGFNaRfrGMX4BrBHVpqeJwkZWrMaDqPShld/A9ZzGdKp3T3XZQ7V6rWqr39+7xWRQ3HAHieWoOlSKURUEIJrB5Rq9o7YgzT6tqe6hA2l8BFJTwji4X1vuh6RuVT70Nq1euktvc1xC0IaSgClJaS8OxyyCJAxndc+NzeEfHSn9fQ85FfMPGXgzh6dk3pbLDyikLMp4UBc9m7S5p/e8zO+6cZeI/YUaprycb9DK+QeFOnEm9y7AALs4AORHzD3+7O/0lEYZlDvPRFAgS+9fmFdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oydr5RGLPiB/5UlaPCHWJTbrdc3fnjsbwu/jwCLiWIo=; b=oxd/K2NL01WO8G2hQcT1QCfnVwgkyCXY6pVg2MFMtB+tf0CYWpNJhAa8XyZtcLkO6nBrOr5VRNtHx8BRCFxLOP6WRID+jNlLHFtDeUFHFU1OsRSR9Gom/up5TRXGkAhsRu8tTEuWv7SRQpnvKysk2N7SbJxYOfC+4yafMjcYIhKId932BBHXoCD0AaZzFojKgyI9OcwDCKpFC/pz3mYJnaNDrT6gTPJ7YiYTDFx1H1+rhqP+XG5z0QzDnciK6MFs43rBIMEFR+vi47rHuSQxu5is6te7+NNucFENBXKv09bn34WXohRJUPnuLfI9I9enwg8GSdfanpTT90031M20/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 16:58:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 04/10] x86emul: handle AVX512-FP16 fma-like insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: ab8862c4-b2b5-4ea6-d632-08db3453d9c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E1FjQ3QBqYkRdozj0hcc2S4PtbKILBwA/3y5NzFay+CMFtL/sryD9cyPVOp2NFqi33rjzaB0/L/UOY85eKTaabysq4ZmMq0J1XzshAYUpo77jnh12hZp+ysdEWJZK+35BFu660Gr4ywOd18yeHGrT06l2U/QAT3gRpZmGMGuRVmhNaFpICQHjK30/PehqsJLr694fj47KFnlDwLQtfMPqNiXryC8rgUh1Pg1S4HO9e+dcTDI5DG6HCSZYnv9XN5X+PEQZZjGgPJFXLylPj+HzJVtcUYxcEVqu5Eq8lifq02axkh2Ff3NYYztVacqYj36fTSxRXv8SCmVOXORaee/9LSv5VAYHzda5qFFfvWUdCxQ7kUS9/jtkyZrYN0kmC03Bmml1UPqIOICU2AVIoRLeJs+UthTHSpuSuVLaMjuJbouI2+YwX3r2FHbDnU5hdxrbmS3vibjczAI8gIjCTMeTl2IDKQF3h3/ZeX/J849Iv6S/JvhrsSxe81YXx5FcVRrTFzw39i/cCvNLHMIgxl/xdlvVBNycTV64WishB9njWE8jKybpZI+VVK/kUm3cmVb1hbm+To8DX3Bz5mKE80odUoHBzcLsUMg5f2K9kigf7tLPr0Tq0nR3gsgR32Apg8W219LJ1caBuCQTT+APfEsXw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(30864003)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amQxMTlIMTBPL2RhdXpwTWYxNityd2UvbVRzQWYyK0FOTFRFdFZ3bUM3dmFm?= =?utf-8?B?V1hoeUpJMjhlbkdIdUdwZDdjendYY1lrTE9Ia0g3MHBYU0NlNFZOUkxVTXdt?= =?utf-8?B?aFVSYm1FV0ZEdUFTL0FuMlhtLzR2bkREN01tdXcySldWSW9SZU1tMGhhMWpK?= =?utf-8?B?OUZiS3UyYXVMUTlBU1gyYTJOcGZqdTk2MjR2Zkx3UU0vby9OLzA1em5ISC9W?= =?utf-8?B?TTZYMGlCdC9aRk8ySis4Vzc3My8vNDFUdUtHUHQ5M01RcFRibVhIZCtXUis1?= =?utf-8?B?MXczZTNEWnByK2NmbFR2TGFUVW9PL0VEMDV0WGUxTHNJR0FZc0w1cFZuRE9O?= =?utf-8?B?NnV5cTFKTUVhaGgxaVBKWjB1Wk1lMGtFWStBZXBjcUFOSXFvZ3JaTlRTaUdY?= =?utf-8?B?L1M5TGVhaVBreTRNREgrWlRGaDFFSjhCMjhkM05OS1hlMnpDN2RpN2YwSWFs?= =?utf-8?B?T3BlMnVXUW55Qm5GMC8za3NqSEdFQjRBRlBaZ3FRVzVMRXh0TkxwS3RiN2xF?= =?utf-8?B?cllXQmtQaDliaEJyQ3hTdWd0WHBpRndrRE40cUFWalVtZmYxWjkvSzV6YWxo?= =?utf-8?B?R1lGVmdsaXJ1cnNtL216RFI1dkcwZGI4cXJrWnQ3cGxNR1JkZTg5NXpOMm45?= =?utf-8?B?T3RpVlcwVFM0anIyNnFmeXBOYmFmV1dacmN4UG03WWZPb3RYaXVJeWxaWFhQ?= =?utf-8?B?VHNBQzhVYjJwdWsyaFJreHZmZ0x0ZkN1REtqRG41WTMzN0w5ZDYzWFJOK3pR?= =?utf-8?B?ay9FWUZkRkg2Ni85MXRUa3NJTTZnNlhCMlI4YjMrNDFlV2dVdjNHTnJreUN3?= =?utf-8?B?MEJrN2F0THFUUHljSnNvaUhZZ0xkWlZJbzJMYjBhbHFtWFBReTNEN1Y4NXdX?= =?utf-8?B?TUFSVnlqWCtBYUUydjBWL1g5WkUxTzdFaDJjRFl3eFBqSWZvVHBiZmhwY0pj?= =?utf-8?B?UWxTaFRwSE0yMVRwR053VkZxQzFRVHhhNVJveGpsTXVaTTZDa3pOSC9rU2hX?= =?utf-8?B?czRTdUdZWHlZVGJXVWw5L3NlN2lPQXI4cGdGakEvV2NuSmV6WXJmRUVRUmRk?= =?utf-8?B?WmR4NXpablk5M1FhL1Fpd09PZXlVVVQvVEZBTWxqNGtoS1hJSy9WZFI5eWRX?= =?utf-8?B?QTBZcEsrT1BzMXR0VEtoMUx3UzNYTmhCY3Yya29RcVd5YU9DN1Vxamlpb00r?= =?utf-8?B?NEJZOGpWSDZJYkFRWlQwVFAxNFdqVzkvYlhvVnBKZ1lXeGVJQU9HTklkK3pu?= =?utf-8?B?Rk1Bd3Jnc2pLeVQzK0ZBTGFrQmJac0llNUJFVzJZdFZKN2UxNFB0ZWYrQnA2?= =?utf-8?B?TTdBcDNDM1RXekR2Mi9WY0NxZU56b3R4N2w5dHpvUkhxbVNyOUQxeFlxN0di?= =?utf-8?B?S3I0aDNoM3FTRFBpeTFRd2FlMWZ3bExsc1BjZDRhUXZveG1ib1ZtT3ZNNnZ3?= =?utf-8?B?cHlOMWtJblZiUnZickhvYlR2SXAxbUlYSFpVTytReHJMSTJLK0t0MXZZcHVa?= =?utf-8?B?R0RDWm41aDRuRXpydWVZUGhCckI0UlpmVVpxS1JLaVd6QXdGNjZYSExPZy83?= =?utf-8?B?Z2FpUnJEVGllVGRsZ3d4M3BGeklKa3pQRXF6LzFxcWNoSzV1VmpHanhBbE9R?= =?utf-8?B?QkcvZjBmai9EeExXaUZNSzdiUVYzNmoxRnJoZWsxcjNXaVMyQUhVbzVsczJT?= =?utf-8?B?cmxsWEFmNkFsSEpydGp3UmRDcHlGc1hUNnhsWWhsOXMxajNiUktZSFJZL1BU?= =?utf-8?B?WG5ERllsK0drLytpNk5SMWgwOURHZytYKzNKajVCVlE2V0lqWEkrZnQrWXlm?= =?utf-8?B?clQyUWY1alA2cDNZTHJXZEdIV0FWK1dlMlFxU1JMQ055N0hVdFNzdUN1T1Aw?= =?utf-8?B?bmMyU3Q0OVJDMmRjaWxZVTJTMFJYaUlxdnJqUlVrcm50alNyMGlwYnlrQmRv?= =?utf-8?B?czBmZDQ2ZHlRL3QwdUFaR3I0eGcrQ05NR05UZzVSRjRYYmZYa1NudUF6Y1p3?= =?utf-8?B?anFjbHd6RWJrcHgzQi9NcmZjZVlvb3BtRldFNnNTalBFb2NPNEdzanluM0FJ?= =?utf-8?B?ZWRFUzMyeWlGOW1QS3hOVWIyVklMZkErWWRsTVFlSkhvYmlPYVdDUTR0MjY3?= =?utf-8?Q?0hPKYHiLprcAFzWGZCWDt3XG3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab8862c4-b2b5-4ea6-d632-08db3453d9c9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:58:14.5414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3x+Uzm4zH6donlyxuL75jxyuHt+D/xbAzaajYG4qAd4Qko+8JLXJLQwDQ0J0p40YT+YeB28eETP9++rQ2XEmvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 The Map6 encoding space is a very sparse clone of the "0f38" one. Once again re-use that table, as the entries corresponding to invalid opcodes in Map6 are simply benign with simd_size forced to other than simd_none (preventing undue memory reads in SrcMem handling early in x86_emulate()). Signed-off-by: Jan Beulich --- v2: Add comments. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -614,6 +614,36 @@ static const struct test avx512_fp16_all INSN(comish, , map5, 2f, el, fp16, el), INSN(divph, , map5, 5e, vl, fp16, vl), INSN(divsh, f3, map5, 5e, el, fp16, el), + INSN(fmadd132ph, 66, map6, 98, vl, fp16, vl), + INSN(fmadd132sh, 66, map6, 99, el, fp16, el), + INSN(fmadd213ph, 66, map6, a8, vl, fp16, vl), + INSN(fmadd213sh, 66, map6, a9, el, fp16, el), + INSN(fmadd231ph, 66, map6, b8, vl, fp16, vl), + INSN(fmadd231sh, 66, map6, b9, el, fp16, el), + INSN(fmaddsub132ph, 66, map6, 96, vl, fp16, vl), + INSN(fmaddsub213ph, 66, map6, a6, vl, fp16, vl), + INSN(fmaddsub231ph, 66, map6, b6, vl, fp16, vl), + INSN(fmsub132ph, 66, map6, 9a, vl, fp16, vl), + INSN(fmsub132sh, 66, map6, 9b, el, fp16, el), + INSN(fmsub213ph, 66, map6, aa, vl, fp16, vl), + INSN(fmsub213sh, 66, map6, ab, el, fp16, el), + INSN(fmsub231ph, 66, map6, ba, vl, fp16, vl), + INSN(fmsub231sh, 66, map6, bb, el, fp16, el), + INSN(fmsubadd132ph, 66, map6, 97, vl, fp16, vl), + INSN(fmsubadd213ph, 66, map6, a7, vl, fp16, vl), + INSN(fmsubadd231ph, 66, map6, b7, vl, fp16, vl), + INSN(fnmadd132ph, 66, map6, 9c, vl, fp16, vl), + INSN(fnmadd132sh, 66, map6, 9d, el, fp16, el), + INSN(fnmadd213ph, 66, map6, ac, vl, fp16, vl), + INSN(fnmadd213sh, 66, map6, ad, el, fp16, el), + INSN(fnmadd231ph, 66, map6, bc, vl, fp16, vl), + INSN(fnmadd231sh, 66, map6, bd, el, fp16, el), + INSN(fnmsub132ph, 66, map6, 9e, vl, fp16, vl), + INSN(fnmsub132sh, 66, map6, 9f, el, fp16, el), + INSN(fnmsub213ph, 66, map6, ae, vl, fp16, vl), + INSN(fnmsub213sh, 66, map6, af, el, fp16, el), + INSN(fnmsub231ph, 66, map6, be, vl, fp16, vl), + INSN(fnmsub231sh, 66, map6, bf, el, fp16, el), INSN(fpclassph, , 0f3a, 66, vl, fp16, vl), INSN(fpclasssh, , 0f3a, 67, el, fp16, el), INSN(getmantph, , 0f3a, 26, vl, fp16, vl), --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2049,6 +2049,37 @@ static const struct evex { { { 0x5f }, 2, T, R, pfx_f3, W0, LIG }, /* vmaxsh */ { { 0x6e }, 2, T, R, pfx_66, WIG, L0 }, /* vmovw */ { { 0x7e }, 2, T, W, pfx_66, WIG, L0 }, /* vmovw */ +}, evex_map6[] = { + { { 0x96 }, 2, T, R, pfx_66, W0, Ln }, /* vfmaddsub132ph */ + { { 0x97 }, 2, T, R, pfx_66, W0, Ln }, /* vfmsubadd132ph */ + { { 0x98 }, 2, T, R, pfx_66, W0, Ln }, /* vfmadd132ph */ + { { 0x99 }, 2, T, R, pfx_66, W0, LIG }, /* vfmadd132sh */ + { { 0x9a }, 2, T, R, pfx_66, W0, Ln }, /* vfmsub132ph */ + { { 0x9b }, 2, T, R, pfx_66, W0, LIG }, /* vfmsub132sh */ + { { 0x9c }, 2, T, R, pfx_66, W0, Ln }, /* vfnmadd132ph */ + { { 0x9d }, 2, T, R, pfx_66, W0, LIG }, /* vfnmadd132sh */ + { { 0x9e }, 2, T, R, pfx_66, W0, Ln }, /* vfnmsub132ph */ + { { 0x9f }, 2, T, R, pfx_66, W0, LIG }, /* vfnmsub132sh */ + { { 0xa6 }, 2, T, R, pfx_66, W0, Ln }, /* vfmaddsub213ph */ + { { 0xa7 }, 2, T, R, pfx_66, W0, Ln }, /* vfmsubadd213ph */ + { { 0xa8 }, 2, T, R, pfx_66, W0, Ln }, /* vfmadd213ph */ + { { 0xa9 }, 2, T, R, pfx_66, W0, LIG }, /* vfmadd213sh */ + { { 0xaa }, 2, T, R, pfx_66, W0, Ln }, /* vfmsub213ph */ + { { 0xab }, 2, T, R, pfx_66, W0, LIG }, /* vfmsub213sh */ + { { 0xac }, 2, T, R, pfx_66, W0, Ln }, /* vfnmadd213ph */ + { { 0xad }, 2, T, R, pfx_66, W0, LIG }, /* vfnmadd213sh */ + { { 0xae }, 2, T, R, pfx_66, W0, Ln }, /* vfnmsub213ph */ + { { 0xaf }, 2, T, R, pfx_66, W0, LIG }, /* vfnmsub213sh */ + { { 0xb6 }, 2, T, R, pfx_66, W0, Ln }, /* vfmaddsub231ph */ + { { 0xb7 }, 2, T, R, pfx_66, W0, Ln }, /* vfmsubadd231ph */ + { { 0xb8 }, 2, T, R, pfx_66, W0, Ln }, /* vfmadd231ph */ + { { 0xb9 }, 2, T, R, pfx_66, W0, LIG }, /* vfmadd231sh */ + { { 0xba }, 2, T, R, pfx_66, W0, Ln }, /* vfmsub231ph */ + { { 0xbb }, 2, T, R, pfx_66, W0, LIG }, /* vfmsub231sh */ + { { 0xbc }, 2, T, R, pfx_66, W0, Ln }, /* vfnmadd231ph */ + { { 0xbd }, 2, T, R, pfx_66, W0, LIG }, /* vfnmadd231sh */ + { { 0xbe }, 2, T, R, pfx_66, W0, Ln }, /* vfnmsub231ph */ + { { 0xbf }, 2, T, R, pfx_66, W0, LIG }, /* vfnmsub231sh */ }; static const struct { @@ -2060,6 +2091,7 @@ static const struct { { evex_0f3a, ARRAY_SIZE(evex_0f3a) }, { NULL, 0 }, { evex_map5, ARRAY_SIZE(evex_map5) }, + { evex_map6, ARRAY_SIZE(evex_map6) }, }; #undef Wn --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1235,6 +1235,20 @@ int x86emul_decode(struct x86_emulate_st d = twobyte_table[b].desc; s->simd_size = twobyte_table[b].size ?: simd_other; break; + + case evex_map6: + if ( !evex_encoded() ) + { + rc = X86EMUL_UNRECOGNIZED; + goto done; + } + opcode |= MASK_INSR(6, X86EMUL_OPC_EXT_MASK); + /* + * Re-use twobyte_table[]'s 0x38 entry here, for the + * similarity of the 0F38 entries with map 6. + */ + d = twobyte_table[0x38].desc; + break; } } else if ( s->ext < ext_8f08 + ARRAY_SIZE(xop_table) ) @@ -1484,6 +1498,28 @@ int x86emul_decode(struct x86_emulate_st disp8scale = decode_disp8scale(twobyte_table[b].d8s, s); break; + case ext_map6: + /* + * Re-use ext0f38_table[] here, for the similarity of the entries + * valid in map 6. + */ + d = ext0f38_table[b].to_mem ? DstMem | SrcReg + : DstReg | SrcMem; + if ( ext0f38_table[b].two_op ) + d |= TwoOp; + s->simd_size = ext0f38_table[b].simd_size ?: simd_other; + + switch ( b ) + { + default: + if ( s->evex.pfx == vex_66 ) + s->fp16 = true; + break; + } + + disp8scale = decode_disp8scale(ext0f38_table[b].d8s, s); + break; + case ext_8f09: if ( ext8f09_table[b].two_op ) d |= TwoOp; @@ -1703,6 +1739,7 @@ int x86emul_decode(struct x86_emulate_st break; case ext_map5: + case ext_map6: case ext_8f09: case ext_8f0a: break; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -196,6 +196,7 @@ enum vex_opcx { vex_0f38, vex_0f3a, evex_map5 = 5, + evex_map6, }; enum vex_pfx { @@ -251,6 +252,7 @@ struct x86_emulate_state { ext_0f38 = vex_0f38, ext_0f3a = vex_0f3a, ext_map5 = evex_map5, + ext_map6 = evex_map6, /* * For XOP use values such that the respective instruction field * can be used without adjustment. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7778,6 +7778,49 @@ x86_emulate( generate_exception_if(evex.w, EXC_UD); goto avx512f_all_fp; + case X86EMUL_OPC_EVEX_66(6, 0x96): /* vfmaddsub132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x97): /* vfmsubadd132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x98): /* vfmadd132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x9a): /* vfmsub132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x9c): /* vfnmadd132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x9e): /* vfnmsub132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xa6): /* vfmaddsub213ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xa7): /* vfmsubadd213ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xa8): /* vfmadd213ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xaa): /* vfmsub213ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xac): /* vfnmadd213ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xae): /* vfnmsub213ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xb6): /* vfmaddsub231ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xb7): /* vfmsubadd231ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xb8): /* vfmadd231ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xba): /* vfmsub231ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xbc): /* vfnmadd231ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xbe): /* vfnmsub231ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + if ( ea.type != OP_REG || !evex.brs ) + avx512_vlen_check(false); + goto simd_zmm; + + case X86EMUL_OPC_EVEX_66(6, 0x99): /* vfmadd132sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x9b): /* vfmsub132sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x9d): /* vfnmadd132sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x9f): /* vfnmsub132sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xa9): /* vfmadd213sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xab): /* vfmsub213sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xad): /* vfnmadd213sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xaf): /* vfnmsub213sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xb9): /* vfmadd231sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xbb): /* vfmsub231sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xbd): /* vfnmadd231sh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0xbf): /* vfnmsub231sh xmm/m16,xmm,xmm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w || (ea.type != OP_REG && evex.brs), + EXC_UD); + if ( !evex.brs ) + avx512_vlen_check(true); + goto simd_zmm; + case X86EMUL_OPC_XOP(08, 0x85): /* vpmacssww xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x86): /* vpmacsswd xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x87): /* vpmacssdql xmm,xmm/m128,xmm,xmm */ --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -620,6 +620,7 @@ struct x86_emulate_ctxt * 0x0f38xxxx for 0f38-prefixed opcodes (or their VEX/EVEX equivalents) * 0x0f3axxxx for 0f3a-prefixed opcodes (or their VEX/EVEX equivalents) * 0x5xxxx for Map5 opcodes (EVEX only) + * 0x6xxxx for Map6 opcodes (EVEX only) * 0x8f08xxxx for 8f/8-prefixed XOP opcodes * 0x8f09xxxx for 8f/9-prefixed XOP opcodes * 0x8f0axxxx for 8f/a-prefixed XOP opcodes From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:58:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:58:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517493.802889 (Exim 4.92) (envelope-from ) id 1pjLdn-0008DY-0t; Mon, 03 Apr 2023 14:58:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517493.802889; Mon, 03 Apr 2023 14:58:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLdm-0008DR-U5; Mon, 03 Apr 2023 14:58:38 +0000 Received: by outflank-mailman (input) for mailman id 517493; Mon, 03 Apr 2023 14:58:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLdl-00066R-6c for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:58:37 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0630.outbound.protection.outlook.com [2a01:111:f400:fe0c::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02a1081e-d230-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:58:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:58:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:58:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02a1081e-d230-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+EmADf+8qQGDOO2a63j7D3UXeDO17W/stMUvc3IZ+UhA4blbOiYj63+46myvKLXBRP02wPDZVgOQhVpceSXxPbN8OwJPSY3qnH5qnJo/XIju6/J15bQLgskU8QDDC9B3oIie6i1xjXYeerLReCeeCJsErm8aJQZelkbRQqRUGQXZLeHYfgwHbF46/ymma/9Bdg1FikzP6iyiNmGb6wsxWt+I9ctyU2EPeCA3mpPs78dHURoQEuf7AwkTjyYv/2Rvz+/7+l2LtBacGWhMY1gR+oIxaMNf+0UvxBFyxz5S6gBTrGGiUBoauzDUrEgbnxmU31wRqEdfgyWpUVCna14XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ur6LIVsIiGjC3p7/RJj3JA9BWiqIOjVGL814s+UqimA=; b=KMD8RGMvfkIZLn4GC2cUTaf+ESHTasZiPA5BTKcjR7BaRPa/cTC1hvMKzIFBngILXUP1+4lJGlWxgBkhjp4i17Nvv9PvqkUOT4y1pidJ/fJ5FiFOWtb82eOhQmxSd1dyfIYjjJw3DeTrrNNfkUeinIXpRX4maEU1y4absn3UILqX5tCDSYhB8NvDTp3EhsvkZYvwk23CR93+APjS23LFq6TQABaTTpDxO6eGWeMIq4ZR+eAEAag6HHGTh6Ba68qeTm3S0OG8gKqzJRuUaINiSaV5OI1dunOOKKHjPnAUM5QpupB9kKMEUsRimElvrhgladaNDALyVOgbmj4l1rAaNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ur6LIVsIiGjC3p7/RJj3JA9BWiqIOjVGL814s+UqimA=; b=G33wVPMKVv7m65GBYqJyXhsLSsnI41uo1yTsRsp6JmvhbZAD/ulN4EY//VWEuvo752DLlEb3IfQt5wQ7T1dgUkDogypy0Xw83RV440jgPW9JwihA02ZyaW08BD/GK6OiRb0gSjIYl+lp/7FHVsjCFL3DZHgjhHIqOJdZBd4drph1eY1VNABMq+JkJYtrZaEicv8VQRI+cUW1WIAl5S9gb2HQppymfMM+e+TrHQkcCyL0unGAkpVSnaHhO0KLg8BT1xVmnVFeDdXE1Nliz+mO1YLuWw2PYq7muDr/AsA2BNSClIjOhmOa7m/bY0D6kjJEQGS2U7Rfuk/FwbCTk+l0bg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ae781d5-0c8d-3c7e-31ea-b54e1eee6573@suse.com> Date: Mon, 3 Apr 2023 16:58:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 05/10] x86emul: handle AVX512-FP16 Map6 misc insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: aa5fd024-27bb-482a-2236-08db3453e617 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qrk9KyUj4cU/pfT5MM0EPK48DtshvMOhIQWZBj30v8IeYswXQvByOSI7E95RnMKSxCQ2n2QBcUc/KparlVb8Z+ddlKk2n5NDR4a5OQN5/I1VaHiQPTEWVa51Ta4PZ5dSvXixFwShLzCU9QTgEOvJfLpTN1A6AnRtTLWm301i0aWRE7T3K2AJV14e1WoHwK9+0vPeGnIJP4FeLX4uw2JxOradHhCaKDWOGdwhi/UxwY0K1h+sLlP3PJqlWJUGx4y4ppriTr0mujAIOjI/3o4+a0Iem8rbbBCB1DEs1qMZVhWRg/7jbZjvozFm6BDC/xKxLTGBeMaOvNop5EkmjZtABvGjlSaqxLhhae9Vt6txn3fT7d2vZN/R+CqYx/yga4LSNEAqfGZRAwEqruL1gibb6Sz4hU1o/eb+O/fnjB5TA1VLRsHqx5jpCw8DZHbIDKnT4PIejQQHgS1XEr+OTdp2+WScCMF5xL7ryRdS+Y77hHmOz7ICOLuWgI/s8wPHlvTpRb8uqwXut5DA4/YEbUCGN45ZUrKPoUU625QCC822rgEY9Zg7w8x+MLO531TgDMhf5hTl1U0X29V6aVxzMxhLWTBORJdybfBdJBFJXPLownAzZXi/wwxKPVDnGv7KINyGzirDx3I8kHP9qAk3vH8coQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWFHR1ZCcmhyQkN5ZnhPMEI5RkZQZzdlbERkakd0elQyUzVEdW9UOWhqVXRQ?= =?utf-8?B?dVRtMHFxZlg5L3hkQkJlRDRDRGZyZHdYM0daNVRGVnZMeU5DM3VYa3NDaUhC?= =?utf-8?B?RVRDYjBxWWZRQWtEbVl2QklXRUxPOFV4VHArK3ppMEZSMTYvUDdpSmZaR2Zz?= =?utf-8?B?ZzhHcU0vdlA3QmZDc29tb3ZuVDlCYzczTG5WQkhtTjNtQjNIOStMM2FFK2lt?= =?utf-8?B?Q3BVUVk2RWQ1YlAvUVA1ZXVYN0Vzc1pQcUdaVnRxMjltcG1QbkQ4aW9mS0FX?= =?utf-8?B?QzhpSzJ4T1B0WmxmWHpQdWJ5OG9xR0xQZ1haU0RlZy9JOCtrTDMxc1c4aTBx?= =?utf-8?B?YlNMTXdQWG1OZnZBbmtLZXcxUFEyaDZLZ0grOXZPcnJSaXYwSmZqZnBIRnRl?= =?utf-8?B?NDl1bEtIMTNMelNFRHFBN01CQkNhVU1OK0QzeU5YUnA5d25hcnRqWU12ZEpP?= =?utf-8?B?TWVFSlYzbjltUk9KWno4bUEyOVIrS3lFc1dBeng1T2FXT1IvY1BqTWlKd2VZ?= =?utf-8?B?ejlTdlpyWDJxTHQrK0VNSnlpOXdwQmdsWUw2UDFEZG1jY2V6QnNRbnkzRUs5?= =?utf-8?B?cFJEbDRrSWgwNDJpaEhqN2ZpaVFzSllncm9uUmthQVVSaGd1S1F5akszcVhm?= =?utf-8?B?RktCUDJYQnlPZkVrZEQ3czFmaVBxNzIxdUd3K1hDeThVOFVqbCtOc3hPUWln?= =?utf-8?B?TjV3YVVuNFJFWExDK1NSVVp1cEVuT1FqQmJXZDZLUUtYQlBNanhTWXZiTTVs?= =?utf-8?B?bjVFck5udzV4V1JhMTFvWHlBaXk3bDlRVVdoOEwvcDVPVDlvelVwZTlDbnBW?= =?utf-8?B?clNGN1huMWJnREFlWDl2dUtjUTJzQzdHaVdUQTFPTVhLWTZlTE1Qd1pxaEgw?= =?utf-8?B?OE5NKy9Jd1d2ZVFyeHduVG5QSGpHSCtDZ2xCTmMwL05vd0NLZE50NXZ4bGxP?= =?utf-8?B?TStsb09ZU084RmdmWnlMQlFwMjdKc212MXhzZDBxaUo3TVlkcjBkS0szemhn?= =?utf-8?B?V3JXU0ZyRWlaMmdhaURQZDdlUkpWcjNiOWFlbTBRSEQ1eitkNElKU1RGbG5u?= =?utf-8?B?TVloUUdrZkNheHpvWTcrMGxKZ3hqTlNqM2RzYnh6ck1vWnZ5UUtLaVVmejc3?= =?utf-8?B?SE5INWM2UHpRWjhDQ0NZMEhHcmFRL3RVSkFQWFRnUFNIYUhkeEdUZyt3c200?= =?utf-8?B?Nk1saWFTb1BtM1ZmZGh3MDZwaEtQRVFoc29HdzE0K0RlOFRuSExETEhrL1Yz?= =?utf-8?B?L3IzZ0huRmNWRFhFVGg0bVBtajdhOURTRm5VVDFCK3lZVGJjc0tSZjVKRkpx?= =?utf-8?B?eGh1Q014UkxMM2JZRDUzdkVtKzV1VXdFdng0ditLaEZlUGMvV3I1akUxeERa?= =?utf-8?B?L3lOUmpqSVV2ZTVXVnBzSFdBUWNSWmROeWJ6N25pV0VHMGRpRHlNRTVSUFNC?= =?utf-8?B?NGEzRDBaSmRDZ2hJVHBkMEtkWFBSWWhrVkYvdlRFTS93USswMXhKQk4vQXJi?= =?utf-8?B?VHRId3dkalpQSVMzQmRhY0ROalBqZ20yRlBzMVBLejQ4bU5qRE90N1B6QXIr?= =?utf-8?B?M0VuMGJhb0R0dm8vUVB0dFU0bFhPd2lnVzlaYXhzZER4cHFJeE5IWkxCQlZp?= =?utf-8?B?OUN0a3dFS0E3ZWozSEVxQXlPVEJsZ2JwNDkxWWd5OEVuVDZSVTdSZVhqTFJP?= =?utf-8?B?UWh5RUZJYlVubVA3M09yUXFKREwvbGVNZyt2ODhLeWhwb2ovaklPYzRNdjJx?= =?utf-8?B?bFJVdWxqUkxXQ01HOVBLWTVGNi9mYUFRQk9YVmd3QlF2ZVJkdW8wOGlrRjVQ?= =?utf-8?B?UVlJbjhMUFhLbGRYdlBvZUs3TVJYZEJPOGtMd0thckVXMHJNQmlFL1o4WmE5?= =?utf-8?B?M0U0Zk1rdXpXYkhqSHFJWHM0RG0zRjRiMXNQdDFjMGJlTERMZVJ3T09DaHNh?= =?utf-8?B?K3UwYkZadjVzbEdocTk3WXFEazJXVG1leWN0ekRLR0VrUXZFMW5TT1JIdmtr?= =?utf-8?B?NmJvOTVLWFU5SkFPUE1Rc0dLakpQUHI2MSs1TGRuWWJZbVBmT00wSFZ6OUVM?= =?utf-8?B?dnA4ZVI0V01McGsvWjlUYmRuR1laRXlKY3ZGNWZjOGtqWnhRMXRoQWRnWHh2?= =?utf-8?Q?7BdQf2nmxLP95Z94xSINsGY0N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa5fd024-27bb-482a-2236-08db3453e617 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:58:35.2251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CQfmDPtMjrBdlQJ3a375nZ7gluGXBUKFVDWw3vZQCNOxI/82FCyTZFWkxcxYHxZdhNE2uheuqBKc1vb9IiQb0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 While, as before, this leverages that the Map6 encoding space is a very sparse clone of the "0f38" one, switch around the simd_size overriding for opcode 2D. This way fewer separate overrides are needed. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -646,6 +646,8 @@ static const struct test avx512_fp16_all INSN(fnmsub231sh, 66, map6, bf, el, fp16, el), INSN(fpclassph, , 0f3a, 66, vl, fp16, vl), INSN(fpclasssh, , 0f3a, 67, el, fp16, el), + INSN(getexpph, 66, map6, 42, vl, fp16, vl), + INSN(getexpsh, 66, map6, 43, el, fp16, el), INSN(getmantph, , 0f3a, 26, vl, fp16, vl), INSN(getmantsh, , 0f3a, 27, el, fp16, el), INSN(maxph, , map5, 5f, vl, fp16, vl), @@ -656,10 +658,16 @@ static const struct test avx512_fp16_all INSN(movsh, f3, map5, 11, el, fp16, el), INSN(mulph, , map5, 59, vl, fp16, vl), INSN(mulsh, f3, map5, 59, el, fp16, el), + INSN(rcpph, 66, map6, 4c, vl, fp16, vl), + INSN(rcpsh, 66, map6, 4d, el, fp16, el), INSN(reduceph, , 0f3a, 56, vl, fp16, vl), INSN(reducesh, , 0f3a, 57, el, fp16, el), INSN(rndscaleph, , 0f3a, 08, vl, fp16, vl), INSN(rndscalesh, , 0f3a, 0a, el, fp16, el), + INSN(rsqrtph, 66, map6, 4e, vl, fp16, vl), + INSN(rsqrtsh, 66, map6, 4f, el, fp16, el), + INSN(scalefph, 66, map6, 2c, vl, fp16, vl), + INSN(scalefsh, 66, map6, 2d, el, fp16, el), INSN(sqrtph, , map5, 51, vl, fp16, vl), INSN(sqrtsh, f3, map5, 51, el, fp16, el), INSN(subph, , map5, 5c, vl, fp16, vl), --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2050,6 +2050,14 @@ static const struct evex { { { 0x6e }, 2, T, R, pfx_66, WIG, L0 }, /* vmovw */ { { 0x7e }, 2, T, W, pfx_66, WIG, L0 }, /* vmovw */ }, evex_map6[] = { + { { 0x2c }, 2, T, R, pfx_66, W0, Ln }, /* vscalefph */ + { { 0x2d }, 2, T, R, pfx_66, W0, LIG }, /* vscalefsh */ + { { 0x42 }, 2, T, R, pfx_66, W0, Ln }, /* vgetexpph */ + { { 0x43 }, 2, T, R, pfx_66, W0, LIG }, /* vgetexpsh */ + { { 0x4c }, 2, T, R, pfx_66, W0, Ln }, /* vrcpph */ + { { 0x4d }, 2, T, R, pfx_66, W0, LIG }, /* vrcpsh */ + { { 0x4e }, 2, T, R, pfx_66, W0, Ln }, /* vrsqrtph */ + { { 0x4f }, 2, T, R, pfx_66, W0, LIG }, /* vrsqrtsh */ { { 0x96 }, 2, T, R, pfx_66, W0, Ln }, /* vfmaddsub132ph */ { { 0x97 }, 2, T, R, pfx_66, W0, Ln }, /* vfmsubadd132ph */ { { 0x98 }, 2, T, R, pfx_66, W0, Ln }, /* vfmadd132ph */ --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -358,7 +358,7 @@ static const struct ext0f38_table { [0x2a] = { .simd_size = simd_packed_int, .two_op = 1, .d8s = d8s_vl }, [0x2b] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0x2c] = { .simd_size = simd_packed_fp, .d8s = d8s_vl }, - [0x2d] = { .simd_size = simd_packed_fp, .d8s = d8s_dq }, + [0x2d] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0x2e ... 0x2f] = { .simd_size = simd_packed_fp, .to_mem = 1 }, [0x30] = { .simd_size = simd_other, .two_op = 1, .d8s = d8s_vl_by_2 }, [0x31] = { .simd_size = simd_other, .two_op = 1, .d8s = d8s_vl_by_4 }, @@ -909,8 +909,8 @@ decode_0f38(struct x86_emulate_state *s, ctxt->opcode |= MASK_INSR(s->vex.pfx, X86EMUL_OPC_PFX_MASK); break; - case X86EMUL_OPC_EVEX_66(0, 0x2d): /* vscalefs{s,d} */ - s->simd_size = simd_scalar_vexw; + case X86EMUL_OPC_VEX_66(0, 0x2d): /* vmaskmovpd */ + s->simd_size = simd_packed_fp; break; case X86EMUL_OPC_EVEX_66(0, 0x7a): /* vpbroadcastb */ --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7778,6 +7778,8 @@ x86_emulate( generate_exception_if(evex.w, EXC_UD); goto avx512f_all_fp; + case X86EMUL_OPC_EVEX_66(6, 0x2c): /* vscalefph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x42): /* vgetexpph [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x96): /* vfmaddsub132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x97): /* vfmsubadd132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x98): /* vfmadd132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -7802,6 +7804,8 @@ x86_emulate( avx512_vlen_check(false); goto simd_zmm; + case X86EMUL_OPC_EVEX_66(6, 0x2d): /* vscalefsh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x43): /* vgetexpsh xmm/m16,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x99): /* vfmadd132sh xmm/m16,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x9b): /* vfmsub132sh xmm/m16,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x9d): /* vfnmadd132sh xmm/m16,xmm,xmm{k} */ @@ -7821,6 +7825,19 @@ x86_emulate( avx512_vlen_check(true); goto simd_zmm; + case X86EMUL_OPC_EVEX_66(6, 0x4c): /* vrcpph [xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x4e): /* vrsqrtph [xyz]mm/mem,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + goto avx512f_no_sae; + + case X86EMUL_OPC_EVEX_66(6, 0x4d): /* vrcpsh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_66(6, 0x4f): /* vrsqrtsh xmm/m16,xmm,xmm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w || evex.brs, EXC_UD); + avx512_vlen_check(true); + goto simd_zmm; + case X86EMUL_OPC_XOP(08, 0x85): /* vpmacssww xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x86): /* vpmacsswd xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x87): /* vpmacssdql xmm,xmm/m128,xmm,xmm */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:59:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:59:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517496.802899 (Exim 4.92) (envelope-from ) id 1pjLe5-0000ON-CR; Mon, 03 Apr 2023 14:58:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517496.802899; Mon, 03 Apr 2023 14:58:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLe5-0000OE-9a; Mon, 03 Apr 2023 14:58:57 +0000 Received: by outflank-mailman (input) for mailman id 517496; Mon, 03 Apr 2023 14:58:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLe3-00066R-9z for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:58:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0630.outbound.protection.outlook.com [2a01:111:f400:fe0c::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d7765f0-d230-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 16:58:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:58:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:58:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d7765f0-d230-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GZHer3oZBf7lCanQ1VDcdXV3qZySk5bsXWZnVk5TkFgjHacTMdyseqGAoruYKmu0GsS8kQKpgY7tdLkBQhVv1G4JePTjqJjeqa1JkreHgc3fb3R8ua/1shoSzxWEVpQzzXPP39VtnnBHF29Q5b2gGTuGjH195x7HpWYoGJLiOm1eN+bVJlZKPhSburJ0LuW7oLWWiwUIFhvxlraLYs8aFd7e1qDaL3Nce2GqQ8I5MeJ9KHxjBrRCgpJk2YqYdUEcg4ds7+rQndBH0CyqMgF7Ie0O4vE0/sTphLowoJMPESrO28MOTbhXwzRYqWRlkUjn5t0pwIJVV2XQrTBozuL+3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WeVlilJaXvmgNgAfKdgiJwwyvehDZKjSOpUZTR1a6eU=; b=ZTwIE8L09mh/cA67hF9lWtOfzJVyl/QpZ1F1QGVEjeilZP7aOjw9QHqG3YCWBDE+LjV7ET+jxyaVGZ0qPBXJo84AtoRd7MmhoUVY88PUQhKucv0ufYUWUEutyPhYstPcFALGcbKyoBNbQH6GkqlVNYhbTpDJFkmBrLnZmf/Jf4wjDJT+yjlBOa3GCG7RcKAommwFzsyEcEXcthIt8QSz6VsiI4TAxL3gFVeTl0BAyjgan5UX5xPU0NbMVIpQXJj4nz5gz1Rwjc/eZawbiRaCp5DVS9Ymn7CmzBbt1pzXW3cjnDSZ/MmARaFggy7at35pWMGAjrH2X482TCUpp+DtoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WeVlilJaXvmgNgAfKdgiJwwyvehDZKjSOpUZTR1a6eU=; b=Q2KughHdC/0ucGez9OJMQuI4UlCJ2XlnA9DHsGexkV3AFcIL8du3Va1nI4PIyFMgIaCd9qhnAJCzJaDXAoS43RRt5fRMRgdq/FO1EBX+emyEF5uby6vln/iKlvU+i43IqHcR/uLKZl0I4wHepZw0XB45Th0Cnag3ezUVbrG8b1sCajrT+iQ+sPnok7vOAty/SldzCaeC5G1MurA8Co5pukc2Wrhd1joTHLn2M5sy8X6/MIuGVYa5iPgF8jbJWR4sp+mDUiHyFMEdRrKcLuNnEMMLFa4jqrG1VY9iQVCUf4pdXkPJgJaR1OrVwb4ll/S9ap64nhNhPbKVgm7yAQ38tQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <25c100d7-fae7-5aa7-1d6e-3c06774a33f6@suse.com> Date: Mon, 3 Apr 2023 16:58:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 06/10] x86emul: handle AVX512-FP16 complex multiplication insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 15772e1f-0528-4b4b-fe97-08db3453f0c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lr6vmV/SRI15F3FfKyQrwpp8VAtUxEY0HLN9cNutNLcar1DoyK3X4/oUrYHp8EuOxkuehPjjHV3J9mjimsPsBLuvG8NgaymdeYbta7ZALvFZCf6dc9zQC1958kegfsAiwghG3mwnMfQvOlAax6ojyWZgE1qIDCl0xtedEKgv3SL7bDZ0A5B+5F5iFgYRhF8m2UFcaIaVTfMYAddZFn1ek2XrvHBmIH3pDcAXEuxtVs3VjFo0lkU7fkm/kpl/x7bnhWcbWiDsVjyiz+6RssWUhX0g37MpwLNep0Smng4Ays7+CZJH/P4C2omx8KIEGEwBD+HshZj1Ib1r6GRbql8MjqDrdvtWyJm6lju/0AUKYGWZSxz5LFMbINoEWZe/ogucofslgOx1E3sLab8wnK7rPHNeYy7ZlbWLux3zuRJd7lB4yMgQ881iRGydzc9cFUeCpVJBQo7eO+8BuQkJ8YrTAdCohURTI3MLWXuGAj1PlQcpNA+0hEgQutgv1LoLBpF38vAC0IESX4R96MKLrzpIUEFS6o9gZ+zmiOf8g8OOkD9bqX0dLVbVChAHiU0MxwoBcq0CtzPp6xYrxTspYwST1rN72/4FtBnDfdQd3+zD+HY8Na1CLNR4GyrhxQqF1Yh9Lcxoelol93xfdDbbRHDM/A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTN3dDNJWGFuZXozd1lkZVlwSEtuRHBVdWxCMGVuakE4Vm1nK3IzbjBiU2lk?= =?utf-8?B?YWcyVmRxUXFQbzBSZ3A5elo1ZzV2NURPTTJTVGo3REt6cENpSExjRGlzb0tW?= =?utf-8?B?UjFHSmtDUXZ4YkM2Uzl1NTFtSS9zTWdrQ2J2UG1aUFNoRFEzRXJ3MHNGWHl4?= =?utf-8?B?S2N2Wm9pOTZsc0NKamw0TkNCQWVtV1gvUGtLTkIvRVhuREkwSW5sVlhZOGYy?= =?utf-8?B?OEd4Tk1qaDRYUHdvSVFwUWFLT3VjR0V3dmYwWGUrRkZzSXh5RUt2YUg3ZGNR?= =?utf-8?B?QzBHcjZaNmIvVnAxeUcxU2JIYmF6akx0WEhNOFJVMnlBYjdEazlqdzhNbXR0?= =?utf-8?B?dnhXU213WFZkeEthL0dNT2dWWGJaMDJPZFdtb1VxNUFkRmhRNGkwSXFSdTdG?= =?utf-8?B?TlhkR1NBQjNSKzBma2tMNFJYRTNkMHd5U2oxYXk0OHpUUXZxQTdINWErdmxS?= =?utf-8?B?bjlVVHo3SStKblk1NlBsY0RxR09nanZpM01BZEI4cTRKcENueVBtaHZhVkhj?= =?utf-8?B?Z1d6VXdYYmRwQWt1N1E4a0VsZkFpaDZHeHkvd0ZISVVPQmVHVlkvTm9pRlcr?= =?utf-8?B?TDVNaVFtZThSbHkyaHZtRnF6cER5K0hpampKamlVejBNNE5EcWZDVFIyUkgz?= =?utf-8?B?Vm9aTTBNTURWUGRBTHIvOEtUcWM3b2pkQ3JIdEUyOFlWMXVpLzVzdWN0SElO?= =?utf-8?B?OFZnOCszbGtaUHlOd3pvSWxoVzJnZm4rTmJTVEVoaEQzaWhzMUVhbndzTnJW?= =?utf-8?B?Q0dWNVlTVWxiY3FPSTZVV1dUL1Ixblpwc0ZySWUvT3ZhRzI2Y2xudy9ZdzZw?= =?utf-8?B?c1lIL2ZpaXFiZmQ2cnJpamduZUNLTmxWejg3VERhL0F0ai9zRkFpZnY0TkFj?= =?utf-8?B?TnhpdVhCQloycHFmOW9FSjZzTDRVYkRyRHJEZDBHTFFjbFZKQWd4Z0JXR2d4?= =?utf-8?B?MEhUYmdCS1JZNDJXcWIzakhma1U1djhZUU4wUGgzZ0lyL20rNHZVV1ZCUWk3?= =?utf-8?B?SmZHT212V29TL2g4NEpsZ3hNejVGLy9rTWF2SHpRZ2twOG1xa2w5aEJBMjFQ?= =?utf-8?B?NDQzN0JTQWNVZ0lkMXJ5RHQxS3MyQS9BWStzWDhsZzlqL0xuZUFzditrSmtW?= =?utf-8?B?M0NHT2FzVVpLaHpCdTZmOGdyREx4d2tyeU10L3B1UkpzbGNscDBOYzFuaExG?= =?utf-8?B?SjZUTGZkemNuZFhDU1JvUWlYR3cvR1VmVUlZV1B2WDljaUtUU3djSENjSFVh?= =?utf-8?B?T280TEZ5SXlpRzQvN1JGZjZxZVJZRlIwTDNUN3R3bXRpaWI0STVHVmR3LzBO?= =?utf-8?B?UXJJVWhXMWYzRjE4RUxOaVFJeXdnS3lQaXR1MVluQUZSN1JsZ21LU21WSmQ2?= =?utf-8?B?N1FZZk5BRzlaL1V0NTI5REtRQkdCWWEyaStxRnZrYm9WdFB3MzVnN0JYUDZq?= =?utf-8?B?U0NRZy95Y0NNYmFuanZRUVFmVElHN2xnZmtPRVJPU1lZUFM0YXQvTjduMjZ5?= =?utf-8?B?OHlIUSsyQkhNTmVWdlNFY2JBYU92bEdISWVkeU4wMEdLZFBxS0VjZ3ByWnp3?= =?utf-8?B?dnZ0Zjg2VmVMZm8yZ3VkZFU1VnhTYWdiMFREbzNFZ2NWZExDUlVXanVaMHZj?= =?utf-8?B?cUtlZnVSVTZMZytVK2RSVEJ5Zy8zeTdOSE9uOW9hNUprZFVZbWlFQ3k0dTJs?= =?utf-8?B?UHRhL0J2MTVoUU1NVEczZ3lWeERFVGpOZEYvR25yZ2J2Y0w4UVZyNGVoS3RL?= =?utf-8?B?b2lCU0RQcGxza2FtbStqL1hob0R3ZFdZS1BQclp5a1ZnUmVVdXkrSll1TzJN?= =?utf-8?B?empBdFI0Q2dIeW9BRU9BaXcxNTNJempQcVVGazZQV3Y3WjhEajZsRjQ0Y2dD?= =?utf-8?B?Q1c0bGRHWW8yckhjb1ZRMitlNzVlbmdrUURPczg2SDdydklOVmRYMmx3NVY0?= =?utf-8?B?TGF0OGdiR0czcXMwL2xtL3djUlJERTQxb29Kb2ZBWEFGT2lPNFdlbmYzNTE1?= =?utf-8?B?MlVBUmsxRU1kajk4YnhzdjVJUzcvWVBzeVVzMTBzSmdKNHRYeS9BZWJrYWF4?= =?utf-8?B?RFpCNThxR1FRdzVWSVVVTnE0ZWhaWnBDSEJPOEprTnl3VHhiZUF1WnB1RnZv?= =?utf-8?Q?D0K7e2lCTDSF6OGOsayxzOjGH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15772e1f-0528-4b4b-fe97-08db3453f0c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:58:53.1131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B6UULQsSi7mTUNiwDQAHEc20BBkBIHgMVVZqT5PX9/wk/EvpkS6aTfve4DFD6/g/psa0BRP3MTaoneKFH1bN2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 Aspects to consider are that these have 32-bit element size (pairs of FP16) and that there are restrictions on the registers valid to use. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -614,12 +614,18 @@ static const struct test avx512_fp16_all INSN(comish, , map5, 2f, el, fp16, el), INSN(divph, , map5, 5e, vl, fp16, vl), INSN(divsh, f3, map5, 5e, el, fp16, el), + INSNX(fcmaddcph, f2, map6, 56, 1, vl, d, vl), + INSNX(fcmaddcsh, f2, map6, 57, 1, el, d, el), + INSNX(fcmulcph, f2, map6, d6, 1, vl, d, vl), + INSNX(fcmulcsh, f2, map6, d7, 1, el, d, el), INSN(fmadd132ph, 66, map6, 98, vl, fp16, vl), INSN(fmadd132sh, 66, map6, 99, el, fp16, el), INSN(fmadd213ph, 66, map6, a8, vl, fp16, vl), INSN(fmadd213sh, 66, map6, a9, el, fp16, el), INSN(fmadd231ph, 66, map6, b8, vl, fp16, vl), INSN(fmadd231sh, 66, map6, b9, el, fp16, el), + INSNX(fmaddcph, f3, map6, 56, 1, vl, d, vl), + INSNX(fmaddcsh, f3, map6, 57, 1, el, d, el), INSN(fmaddsub132ph, 66, map6, 96, vl, fp16, vl), INSN(fmaddsub213ph, 66, map6, a6, vl, fp16, vl), INSN(fmaddsub231ph, 66, map6, b6, vl, fp16, vl), @@ -632,6 +638,8 @@ static const struct test avx512_fp16_all INSN(fmsubadd132ph, 66, map6, 97, vl, fp16, vl), INSN(fmsubadd213ph, 66, map6, a7, vl, fp16, vl), INSN(fmsubadd231ph, 66, map6, b7, vl, fp16, vl), + INSNX(fmulcph, f3, map6, d6, 1, vl, d, vl), + INSNX(fmulcsh, f3, map6, d7, 1, el, d, el), INSN(fnmadd132ph, 66, map6, 9c, vl, fp16, vl), INSN(fnmadd132sh, 66, map6, 9d, el, fp16, el), INSN(fnmadd213ph, 66, map6, ac, vl, fp16, vl), --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2058,6 +2058,10 @@ static const struct evex { { { 0x4d }, 2, T, R, pfx_66, W0, LIG }, /* vrcpsh */ { { 0x4e }, 2, T, R, pfx_66, W0, Ln }, /* vrsqrtph */ { { 0x4f }, 2, T, R, pfx_66, W0, LIG }, /* vrsqrtsh */ + { { 0x56 }, 2, T, R, pfx_f3, W0, Ln }, /* vfmaddcph */ + { { 0x56 }, 2, T, R, pfx_f2, W0, Ln }, /* vfcmaddcph */ + { { 0x57 }, 2, T, R, pfx_f3, W0, LIG }, /* vfmaddcsh */ + { { 0x57 }, 2, T, R, pfx_f2, W0, LIG }, /* vfcmaddcsh */ { { 0x96 }, 2, T, R, pfx_66, W0, Ln }, /* vfmaddsub132ph */ { { 0x97 }, 2, T, R, pfx_66, W0, Ln }, /* vfmsubadd132ph */ { { 0x98 }, 2, T, R, pfx_66, W0, Ln }, /* vfmadd132ph */ @@ -2088,6 +2092,10 @@ static const struct evex { { { 0xbd }, 2, T, R, pfx_66, W0, LIG }, /* vfnmadd231sh */ { { 0xbe }, 2, T, R, pfx_66, W0, Ln }, /* vfnmsub231ph */ { { 0xbf }, 2, T, R, pfx_66, W0, LIG }, /* vfnmsub231sh */ + { { 0xd6 }, 2, T, R, pfx_f3, W0, Ln }, /* vfmulcph */ + { { 0xd6 }, 2, T, R, pfx_f2, W0, Ln }, /* vfcmulcph */ + { { 0xd7 }, 2, T, R, pfx_f3, W0, LIG }, /* vfmulcsh */ + { { 0xd7 }, 2, T, R, pfx_f2, W0, LIG }, /* vfcmulcsh */ }; static const struct { --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -379,6 +379,8 @@ static const struct ext0f38_table { [0x4f] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0x50 ... 0x53] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0x54 ... 0x55] = { .simd_size = simd_packed_int, .two_op = 1, .d8s = d8s_vl }, + [0x56] = { .simd_size = simd_other, .d8s = d8s_vl }, + [0x57] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0x58] = { .simd_size = simd_other, .two_op = 1, .d8s = 2 }, [0x59] = { .simd_size = simd_other, .two_op = 1, .d8s = 3 }, [0x5a] = { .simd_size = simd_128, .two_op = 1, .d8s = 4 }, @@ -441,6 +443,8 @@ static const struct ext0f38_table { [0xcc] = { .simd_size = simd_packed_fp, .two_op = 1, .d8s = d8s_vl }, [0xcd] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0xcf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, + [0xd6] = { .simd_size = simd_other, .d8s = d8s_vl }, + [0xd7] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0xdb] = { .simd_size = simd_packed_int, .two_op = 1 }, [0xdc ... 0xdf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0xf0] = { .two_op = 1 }, @@ -1515,6 +1519,10 @@ int x86emul_decode(struct x86_emulate_st if ( s->evex.pfx == vex_66 ) s->fp16 = true; break; + + case 0x56: case 0x57: /* vf{,c}maddc{p,s}h */ + case 0xd6: case 0xd7: /* vf{,c}mulc{p,s}h */ + break; } disp8scale = decode_disp8scale(ext0f38_table[b].d8s, s); --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7838,6 +7838,34 @@ x86_emulate( avx512_vlen_check(true); goto simd_zmm; + case X86EMUL_OPC_EVEX_F3(6, 0x56): /* vfmaddcph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_F2(6, 0x56): /* vfcmaddcph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_F3(6, 0xd6): /* vfmulcph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_F2(6, 0xd6): /* vfcmulcph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ + op_bytes = 16 << evex.lr; + /* fall through */ + case X86EMUL_OPC_EVEX_F3(6, 0x57): /* vfmaddcsh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_F2(6, 0x57): /* vfcmaddcsh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_F3(6, 0xd7): /* vfmulcsh xmm/m16,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX_F2(6, 0xd7): /* vfcmulcsh xmm/m16,xmm,xmm{k} */ + { + unsigned int src1 = ~evex.reg; + + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w || ((b & 1) && ea.type != OP_REG && evex.brs), + EXC_UD); + if ( mode_64bit() ) + src1 = (src1 & 0xf) | (!evex.RX << 4); + else + src1 &= 7; + generate_exception_if(modrm_reg == src1 || + (ea.type != OP_MEM && modrm_reg == modrm_rm), + EXC_UD); + if ( ea.type != OP_REG || (b & 1) || !evex.brs ) + avx512_vlen_check(!(b & 1)); + goto simd_zmm; + } + case X86EMUL_OPC_XOP(08, 0x85): /* vpmacssww xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x86): /* vpmacsswd xmm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0x87): /* vpmacssdql xmm,xmm/m128,xmm,xmm */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:59:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517499.802909 (Exim 4.92) (envelope-from ) id 1pjLeV-00010B-L9; Mon, 03 Apr 2023 14:59:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517499.802909; Mon, 03 Apr 2023 14:59:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLeV-000104-IE; Mon, 03 Apr 2023 14:59:23 +0000 Received: by outflank-mailman (input) for mailman id 517499; Mon, 03 Apr 2023 14:59:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLeU-0000MW-Gk for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:59:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1a::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d122fce-d230-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 16:59:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:59:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:59:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d122fce-d230-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQINIxyPzlzRx22z2Pl0Fc86R5dbQQ50a7E9cWUggUzeZzI2ys6djhWvPjKO9M5HXPTFQBkjjarXlTuC4runqoil458lWydSAWExIkE2/saDb3mo46oZqmpVF8nW5JNdpevg5rl+NAtW9cZbGOUmqtM5tUg8tmxq7cY5eMqaALEbJDRkcWtF4WB1cYo65KOtCnStzp1pjSDmoHnZ37LpbLwoOphqaEgTVkWQMjH2WVkEWWyvlQr0Z82zBBMEaG9x56LdN0Ec38Uc5Xk2x31jQ3p1sXBUUTbqlJYcE+XzpyT2LPOa/64Eq2M+iNPys8OJX5ME+Zo79ujSpe7Mk8wfwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uhli6p+2g334+AF1uQpNe0kBbZNIku4hPqzRfVDOW8Y=; b=K9H0uhiTy5Z4ldCq0xcM6JJRC4JM3Hi5MJbOHGrBXA6/Vr5oXY5YR74BnTPgCPszHDjznhjVCXXQSgqJJxHj7EEfer/T+C6iVgwNggr3idMc1y98UW2el+eJ6uasNPsPT5xOTlwkqfdJvfrk0iKe6MyWkGltPHnh8AA+fOscef1V1wPb5hEsLnQgDlOo5uB1WAKZwbuEBcIFuLzoicDi2C+nOiVzUW5NHhbIuidwOKQCqewIkUqCtt1cIULKmOO/QnsMBc6iBewxEisUexvKt8+BQ4gBMl5Yo22BXRgjOA2iGhWsBXp+kzVrf5RQGEntu2BCe+3DPatTsYpiMWR9Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uhli6p+2g334+AF1uQpNe0kBbZNIku4hPqzRfVDOW8Y=; b=rc53KsEygbttSkBO0nl/1EmXf/XzElObcKKwbdmDj3utKhegypm1tLMZjp5BaEO0xSeEhPFsxXEQkF9VZiWRe/g6B//VSuKTMNy3kgjNsluTPoTcK3+n9L9BtEDCWh5tqjNuDSiL7bM2Q/ssbVLaWosGqUC98OcLYI8QHjW+vs3Mi77yP5Lr0Fpfx8ngvq/vCX0uslQEdWeE9Iu70wzi8Xjuf0duooX+n3DoTh9tLnHaZnSrBYz6q7qnuMaUrvu8JRZL+CFolZ8P7AJp4uR+xBYhtaWfv4ff7B9rmG5MpL/BkBXHe6ccuiYyl8quIzE9Nbt+fQEaTxBXEb5Qr6j50Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 16:59:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 07/10] x86emul: handle AVX512-FP16 conversion to/from (packed) int16 insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 7526505b-58d4-4772-13a0-08db34540079 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9UQzmsyB2eRBJFk4YiB9IRSjpgMw7qlA9D2Pvx/G8dhdT6lphZKjclhIHz3WJrHhPayAbN/FL4t52xDO8Qx+Ync2bTMwiyeRrf21MZIENDNUlvTN+T9sMUZwGsXXFx1e5xT/MpluUtkEGhqTTcfACQy5maaAmmpbVHfpScmfVFb3JV8GuEdFxasA9N/pKFZUCHQ+srGqYbtiKu1DfWP1xXS72YN8J1vlqyBrdo33+UDrdUhRozV3FHPTLjmJ0x0TRK5Z8oaMKlJ1uB2hDDvaRi7YxId8YvSSTf2clNEMy2CEDW0AGDWN8jp01XKKska1UH8plVcaKUnDhdicz/ghfcyS+cciqeewT+i35TeDI5v19dRDnMyod7Twaw8BUeuWTwYcGhcqPtNJk8qL+5WSMXFkYey2TpaEkx/2zqTDR5kG2yii1kULnLNOuWhuhmj0/XgLIImI2guV/dTph7pNWzLhUyDJCZgYYwqi5BcWZG9giVhHOjfD+SBWEQmBXeM+81rpdHu3vyDvQYGHgOWvB6ytBvD3831ndSvpH0cWDTMaU2btx84nsPkXMAcwBgQamdBpCcXGBbUId9PJ1fOwIkFtmMtkBucyZXTgePYbA/Qm2RWxawkhU+gGft0v4NdeXmIsxpxodcVQO/hZghZXCg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkdhYkJ4b005R3gvNkNabHMwamthYytYSitMSjcxSktRa0JpYnhxc1d6OGRY?= =?utf-8?B?TUpWZHRnRU9uQVdUVDR5WXFhQ3RJcWhNTGliYWxzN3J0TkZwKzB5cFJjN3Fx?= =?utf-8?B?K29HZEdPN2FwQmV2RjlMV0pvYml3ZVgvNGtrSnJIY09CRlFuODdRYlUrREsy?= =?utf-8?B?VEdEZ3FHaU5xV2ZVZTUwZnM2ZHdVTlVsTlBxNmRpMHd2R2x4NHdqaEt6bVVZ?= =?utf-8?B?WkpOTlc2eis5UjZ6WFZ5by84NXh0RFdrQlpJSjZ6MlUzelkxbEtXZTR1WlA4?= =?utf-8?B?elgycGZuUjViaWZBWlVMajR6R1NZcWo3bEx1RnkrSGlRa1dTeXNoTVFuM1FQ?= =?utf-8?B?VkJQSDk3b21wSWdTT1pQMm1nZFZQTHJkYnNtcTJXS0ZEQ2FJclNIY05naW9j?= =?utf-8?B?TVFmM1hBdmpmaFh0b2pCUWlubCtXZGxFVlNISnVDM0lNRmJXY0V0VS9yNTVG?= =?utf-8?B?cTRMdG1ZTmVkR28xN3FXN3FrWWZVQWM1UU51NWZFU0pBcDRncElBQUFyY09D?= =?utf-8?B?WE53VWpmbVRrNUtlZExGd3NjLzFZTS8vMjY2VlVYNHFhQnNUSkx2bndSRTNv?= =?utf-8?B?L29YNW9FRkI3M2p4d01nZ2xENjh5Wi9mQkhYQTd4WjhiNURTc2txYkhDQmlT?= =?utf-8?B?ejZGNTY1MTRUdUE0Q08zVkpvc2IxY3JVbWJrdktWTEZpY0FXdGJGSjFvMFpX?= =?utf-8?B?WS9LU1BGdzVWK0xPcXhGSy9DdklkYkFGVG5nbllNRVlKTCsvYStCZHdRS2pq?= =?utf-8?B?QStpRmNLYUNiTmZKaXRlamdQbGpobXVOZGIyaE9xcHJrZytUcW5KU2xYUXFP?= =?utf-8?B?S1diRDZUalVQdTlYY0FFQVZhQW9ObEtxRGtqNTcvZkZ0Ky9BOXZodVZwVHhr?= =?utf-8?B?MUIwSTlwQlg3YzVMMlp1VlpWQ1d1V3NEbmx0ZElFT1BWT3NKekVhKzVkUUEz?= =?utf-8?B?UFZTaFdQSkx2WjBJWkpqajVndUtDMC9XZ3FERlpWZFhlTDJsTzJQSWhsMm5h?= =?utf-8?B?SXZiOXBSOWgzUXA4ZSt4WWFNYW92WVFoYkhOMldLcFczd0J6ZFBST1BuT3p2?= =?utf-8?B?SDB6TGZza0dOZjlGclhXZTFNRlEvblhlRUVJbWZTa3J1MGdUUVFJWm43WVV2?= =?utf-8?B?M1NUcDBwQ3NrWHVyVkJ2ZFhSdkF4czhyUG9Kb3Z1SXBYazZnbGZseWR2VHIv?= =?utf-8?B?WVJvdUZmMGhYbnh3WGJlMitFY3RCMTR6VFhtOGtvMEVKU3MrWUE5SVAyQUFO?= =?utf-8?B?clN6QjYwaUd0RmMzS1ZsQXpPT0dIM2hRZW1vb2JxZythbURLNE9iS2NxbXdo?= =?utf-8?B?d0kwK0RvaXJTK1NuTGdqSjhMV21KMnVpek00Q2Y1emJyWndVUjkrMElIZy93?= =?utf-8?B?WklZRy93VlEydlNZSDk2ais0eHJwQkJZM1JjenJYVS9sZTBvazJoa3ZEY1pu?= =?utf-8?B?NWVLbStNMEdUYTZudUFVUW9Ocks2RzRUMXVXejRSajFMdEZhTkoxaHRUKzYz?= =?utf-8?B?UnFnNkpUZmUwYmMyVmxXaE9tRmpTZ3VZOXY4aDA2OUduamx4Y05CQmd6ekl6?= =?utf-8?B?RC9GZ2RNdUMzUXhlRng1Z0huMWR3ZUg0bWVDSUVCa2Y4OVAzNlZPMk8zdzJR?= =?utf-8?B?anZnSEx1dTVzdHJsQ21UWW0vQnMzMGNuTlNSMFVNakhFZFJtMUpSVnpKcUNT?= =?utf-8?B?a2QrZjBDaVE1anZhcHZzV1h6ejVUc2IrM0JhdFlocmVXZmQ1d2xFWDVZWFJw?= =?utf-8?B?Q3VUVzlQSlpDSGM0R2hNU1Bua2FxQ3laRy9XaHdQa2xhUDVpdXBnVHgwY3lO?= =?utf-8?B?TVhxNHRrWnNyY1dTK1VSME1idjBEazRyd0tXbiszZVl6WFQvZVVBT2tJVE5y?= =?utf-8?B?WGk4WHZOZjZReVZMN29DbUNZdXBFL1FUOUNiNjZ6SmQ1YU5EZmp0TVpzU2Jn?= =?utf-8?B?Y3ZEelc3YVVyY0tkVmErVllHZUdwRjhsSDlyN3U1aUtnZjQ2RFA2TUZDUy9R?= =?utf-8?B?UkVKTmtORW5aTzVvQ2k4eDR2VGYrQzZXZVZTa3graDZseXN1Ym9YR0JwbXM1?= =?utf-8?B?MllKaTZXbkh3T2diSUVEQjVCSWd6VE9ZaEpheUttdWRHRFVmWG1wMkFDM1or?= =?utf-8?Q?L3lYaX0A7W8Zi/n234jSay9AY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7526505b-58d4-4772-13a0-08db34540079 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:59:19.4314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b5oOs+rTIZyG1YI43TgoMMafpU/avw2nCtPZtIjLz0K2YbReb8s9CK1QU/rS7MXiSaiXrcnluClW9NzB5eJlUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 These are easiest in that they have same-size source and destination vectors, yet they're different from other conversion insns in that they use opcodes which have different meaning in the 0F encoding space ({,V}H{ADD,SUB}P{S,D}), hence requiring a little bit of overriding. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -612,6 +612,12 @@ static const struct test avx512_fp16_all INSN(cmpph, , 0f3a, c2, vl, fp16, vl), INSN(cmpsh, f3, 0f3a, c2, el, fp16, el), INSN(comish, , map5, 2f, el, fp16, el), + INSN(cvtph2uw, , map5, 7d, vl, fp16, vl), + INSN(cvtph2w, 66, map5, 7d, vl, fp16, vl), + INSN(cvttph2uw, , map5, 7c, vl, fp16, vl), + INSN(cvttph2w, 66, map5, 7c, vl, fp16, vl), + INSN(cvtuw2ph, f2, map5, 7d, vl, fp16, vl), + INSN(cvtw2ph, f3, map5, 7d, vl, fp16, vl), INSN(divph, , map5, 5e, vl, fp16, vl), INSN(divsh, f3, map5, 5e, el, fp16, el), INSNX(fcmaddcph, f2, map6, 56, 1, vl, d, vl), --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2048,6 +2048,12 @@ static const struct evex { { { 0x5f }, 2, T, R, pfx_no, W0, Ln }, /* vmaxph */ { { 0x5f }, 2, T, R, pfx_f3, W0, LIG }, /* vmaxsh */ { { 0x6e }, 2, T, R, pfx_66, WIG, L0 }, /* vmovw */ + { { 0x7c }, 2, T, R, pfx_no, W0, Ln }, /* vcvttph2uw */ + { { 0x7c }, 2, T, R, pfx_66, W0, Ln }, /* vcvttph2w */ + { { 0x7d }, 2, T, R, pfx_no, W0, Ln }, /* vcvtph2uw */ + { { 0x7d }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2w */ + { { 0x7d }, 2, T, R, pfx_f3, W0, Ln }, /* vcvtw2ph */ + { { 0x7d }, 2, T, R, pfx_f2, W0, Ln }, /* vcvtuwph */ { { 0x7e }, 2, T, W, pfx_66, WIG, L0 }, /* vmovw */ }, evex_map6[] = { { { 0x2c }, 2, T, R, pfx_66, W0, Ln }, /* vscalefph */ --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -259,7 +259,7 @@ static const struct twobyte_table { [0x78 ... 0x79] = { DstImplicit|SrcMem|ModRM|Mov, simd_other, d8s_vl }, [0x7a] = { DstImplicit|SrcMem|ModRM|Mov, simd_packed_fp, d8s_vl }, [0x7b] = { DstImplicit|SrcMem|ModRM|Mov, simd_other, d8s_dq64 }, - [0x7c ... 0x7d] = { DstImplicit|SrcMem|ModRM, simd_other }, + [0x7c ... 0x7d] = { DstImplicit|SrcMem|ModRM, simd_other, d8s_vl }, [0x7e] = { DstMem|SrcImplicit|ModRM|Mov, simd_none, d8s_dq64 }, [0x7f] = { DstMem|SrcImplicit|ModRM|Mov, simd_packed_int, d8s_vl }, [0x80 ... 0x8f] = { DstImplicit|SrcImm }, @@ -1496,6 +1496,12 @@ int x86emul_decode(struct x86_emulate_st s->fp16 = true; s->simd_size = simd_none; break; + + case 0x7c: /* vcvttph2{,u}w */ + case 0x7d: /* vcvtph2{,u}w / vcvt{,u}w2ph */ + d = DstReg | SrcMem | TwoOp; + s->fp16 = true; + break; } /* Like above re-use twobyte_table[] here. */ --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7778,6 +7778,14 @@ x86_emulate( generate_exception_if(evex.w, EXC_UD); goto avx512f_all_fp; + case X86EMUL_OPC_EVEX (5, 0x7c): /* vcvttph2uw [xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(5, 0x7c): /* vcvttph2w [xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX (5, 0x7d): /* vcvtph2uw [xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(5, 0x7d): /* vcvtph2w [xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_F3(5, 0x7d): /* vcvtw2ph [xyz]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_F2(5, 0x7d): /* vcvtuw2ph [xyz]mm/mem,[xyz]mm{k} */ + op_bytes = 16 << evex.lr; + /* fall through */ case X86EMUL_OPC_EVEX_66(6, 0x2c): /* vscalefph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x42): /* vgetexpph [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x96): /* vfmaddsub132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 14:59:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 14:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517501.802918 (Exim 4.92) (envelope-from ) id 1pjLer-0001Yc-UR; Mon, 03 Apr 2023 14:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517501.802918; Mon, 03 Apr 2023 14:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLer-0001YV-RX; Mon, 03 Apr 2023 14:59:45 +0000 Received: by outflank-mailman (input) for mailman id 517501; Mon, 03 Apr 2023 14:59:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLeq-0000MW-GH for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 14:59:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1a::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28cb0595-d230-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 16:59:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:59:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:59:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28cb0595-d230-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5mq77nDTjSWCCoxWyRjwHhDlqQhIZ4O7Nys1zxdgGsK1GTEt+Ikse80QvIqBXOxaZ9bAdE3PPHxlGB1Mrs/BE9JvVGKYb3GoIiuzUy7OnPtz2psvVLX5WaHdoo1tGkHcCk6ghRvI3kto9ILk5e3ziDQunac+R2fhbe2iHd1vGqHAsWe8RwswW7u5z6k9+R+JHatzEQQrFpuo9NyosyrJI1oyIUVEhHimIFmW99O+VrarpklDmq/xx+ZdfFHXcjAa6QCe6Kz4Ym1T/0SqumFjzNzgcAtlFMCYezTi3oZRNStms0Bxrg4lHZLvSBPKdcV/QTfoTPJQP6UdnherJsU0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6C2XMdmMlevRHHkAtu6ujlq2vtpyDWTGQwl0t4wyzLM=; b=nANfu9XKPBGcYPRdHibN6R7xgd+IBoUVjXWEmSBzqhKBeSU8LUryeNn0ki/f3IpVgPvTYg7T181Nwjqh06xDGmscVql9xeEDQ4domX0KMONKXwXNVizVR43xiDTc4S2fNmw7Ya2qvr24c29IG/nmR2CzLNueCrcFDE3f//rUZJey0SPy0ABaSUSHdAGNBXqzpWtSzHdkbReN2WMxe8lQFXjshXQmx0VllgxFcxn/SXYNA5p9LVJwShMKdkK82JSUOGYHT/rChzZaPDoRw2qMQs1oIKZ2vkSSZRmZaKzgLxAodKzAqT31scvxr0YpHSVb2XaSPNbaUFABafBAIzZcoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6C2XMdmMlevRHHkAtu6ujlq2vtpyDWTGQwl0t4wyzLM=; b=QpzVia/dM/iOwWQz6zTHyK6Zrr0lxe7GLSG8WnRUZVI3rY1KyFhdx7PJiMNVpPBMrTdPjfZrxhm/UK48zx2ASboMAtjj9W6bvr4Oc0NxcYE5itUMQrNOEx5LnhavIOBemhed/BFa7E36f3WNcGKcxX+Xt9qFcRFc+8SUZU/vIlcm3ypb9GIg/88xuUV1vQoOchIXzN6RNfPwTsldd8np16/YuxX5ps9bX3PPyteTunKnm20Uma6pTbcETv9DTYPBH1oUDNRY80g9urO16zQDKToKNO8N10SZfGq1aBFql0sbZyHR/4+NjmqlvfM0ieZe3Y7hXiozJkfYk0YJf2ciqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <607132c8-2693-667d-f6a8-09f362cc7bce@suse.com> Date: Mon, 3 Apr 2023 16:59:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 08/10] x86emul: handle AVX512-FP16 floating point conversion insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: a1093b80-eed6-4d1f-427d-08db34540c24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z23T6p0jTls9S1+36WHN2JS1GNM2UFWR1lXUTrmpW9Joyr7NxX2ZUt0vhAAObY+58hlQj/wUVlSuMzCgTy7wcvela4qSGxz6sluyCrZ84KIxr1oFcb6/ReaENHuxKIVq+wXb0uof34Cg/sRPIQAxWt/Ro/6LrL8murMQ2QqHR7AaylmEeW4kYC7w2HSZF6372eu6YNkldRsdBo8asUEmLa4ztGCu5rbeeOT8YnAM9sSud8WJ4Drsx7CLzG3gbTC6NNc70pPDBrVhf/H22B4JjQPA7fjSxpBXpbNfN3Hj+MMp8rmGHEMlCzNVOKXpx/uQhPACqxi3zlu943PiLH401FxDI57KYj52q0RJx15T9fptG4nysdTRJQws3U+kqBX/8Iq/42ul1Gz7yBImuaJ+rpw5fiFnmjC7Vc5p/Mtt0UrA8TXaBJGmGjR7r1HBpKb2di5Moo+VTCgf12szCVLd78kOg6hvfXTDEezrYqkXi6tmHVqbDw4eH++0Btv3tYb1VzBWE8OU3NW82htxcrm63XsVkOehC+92A3prT/FfdU45C4Momo8J+TbplagJgbnWBzQGN6dhtur/Z0HBK+IEGeCXKHPBda7tvYLoXyE9kgSc42fXz3ttwbxHztAqePuVepIbnEshEvqoJrBpB+aoAA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3VEQzNKREk3dkZJdERWdXlmZUZjUnQrRTBGaWFrYk1Ebm9ka0drWkluRnpU?= =?utf-8?B?Q0lVREczVGlMVzFJa0w5TU9IYUdZTmtCaGNOU2pvckhySUJwb2lUZmpKNFZV?= =?utf-8?B?SkFFYnFBQ1NOZklLSCtnWUtHYkdWQ1ZIUTZTb3VWckFKS3NXSjF3MXZ6eVA1?= =?utf-8?B?Y3R1cjgvMEpIb2VyVUlZREUwNElCODc1M0d5cHhBTnN5SUxFbjJpanVXVHMr?= =?utf-8?B?MXZucmdQZU4zN0FTYkVyaUVYdlBRZmF2cndNMWFDSHMyUTIyKzhSY0xGWnc2?= =?utf-8?B?NTNDak9OTXFXelQvNGlYaHlUaEpBMkJVenpQRk1mSXlCNW9SVTJWbUtkanV4?= =?utf-8?B?NTBNQytFYndZbUFQQ0VFWWJCMnY0Q0ZsS0t6SS9ycDlORUF0NUw0NUlmQ0sy?= =?utf-8?B?QzUzTjM5MUZVK1c5WVNENmFKbHVjRkpuOSttMXZVZ0pVdE1VMk9HOU5qMktZ?= =?utf-8?B?R1M4TTBoeXFrclBrZU40S0JjYTZjM041ZUUzN1JHRFhMZ0l2VVI1NnYzcitv?= =?utf-8?B?ZHp6WnR0SlhVM2c3cGpYUVYzMHdKNjJwNldWZG8xb0pwMUlscWs4TW0xWjFH?= =?utf-8?B?cWVwcER3VEh6TTZ1M0N3UWU4YXJVb2J3V0NodnBFWExaM0dxWmtBaDhJbHoz?= =?utf-8?B?ZHJGdXdzTzFkTVppYnAvVmgwN0hJcmEvQ2Q5MC9icTludExNWkJYaXE2Um9J?= =?utf-8?B?TkpLYTRxRld0bXdaMUFWQnlvaG9WNUtveHkzOEVJVnhVelArYmRPdm9idkNJ?= =?utf-8?B?eTJNcWdQdUorUkY5WXZvZUJKa1FYYUpEWWtTdHhUS1dlcDNoUWVBTXViOTdH?= =?utf-8?B?WHNqc3htL0lSV2h3Mm9Ybzk1dVgwOWhZTWtZbkU3c21VVE5XVkhrVGdpa1g2?= =?utf-8?B?TjRyS0NJZk0xRmtoczJmeVB6ZEp1WEhQWE81L0xmNXJMdFBNYWNmK1VzZ3k5?= =?utf-8?B?UXcwN3ZUV2hWUmVJb1V3RUZ1enNTbGVucWJWTk1MaE5kWDVMMG94UUFVU0dj?= =?utf-8?B?WE5GMDNBUTlqYkVpNC96RHgyYmhmSW9pWERGVms1cUJ5SkwxMFg5ZVNxQmVw?= =?utf-8?B?R3VJaXRmbEUxQ0d4VW9aVjFhV0dVNXhvaXBEM2Faa1EwUko4aGtOYi9SUGlL?= =?utf-8?B?VGx0ck1DdHBaMjVXeHJaMCtTN3JHbTRYWWZEK1FTNUJ1Nlhua1VUWVBCWHlW?= =?utf-8?B?Nm9FNi9neGg3YmZ4Q0VDa0lvOStYZXo1Y2s3SEpjSVJxUVI1dFN0QkM1ZDNJ?= =?utf-8?B?OU5HZWl3YVB1eFhRTnl2bXN2bnFTNUFNUytQcWZ5ZFpmUG5mWmUvQWpKV0g1?= =?utf-8?B?c3d3bmtreWxhc0xlRk44NjFEanVKMU9WUjZQOXJ5UzNmTHkrRTdzNkRCNE9X?= =?utf-8?B?Um5PVFllcnQxL1MyYm9uV2ZHMnFNZEhVOWdvYklKMHVNeXN2cDkyQmZ0VU9u?= =?utf-8?B?MVVZcE92MHhhQjlTYXlkMG9uK0xBcnVJVkhLVmRjNFJrQnQ3Zy83NFp2ZjlV?= =?utf-8?B?MlFnSkljbWsrTnV4SVBGaE8wa0ZpcGNlNlQ2TVVJbUVxQ2RNbGVOYjdNZ2JM?= =?utf-8?B?U3ZLNkgxWnhzRFRIM0xZRWppbnJ3UDJFSVJKRy9NOWMyN1Y3L2txN0x0bU1s?= =?utf-8?B?ZlZ4eElnSlVkWnpDRndqSTBHYWpGNm81L3o4T09DZVNkNnJ4QUFrUXNKRk5J?= =?utf-8?B?cWVXQXFMZjE0VUxLK3V4WFAzbUFqZ2czMnlLeUxBQUs5bUxyc0R3aGJWK2ZI?= =?utf-8?B?NUhjZWZqeDcvNE1nUjhaODVuZ20vNVk5REpnWENBUGg1eEpqbVlUT1pyc1Jk?= =?utf-8?B?MU8vN25uTUpCZGs3WEtzWjBrOUEvamlxaDZsTExLWUh5bVlhQ0VET3N4UHFz?= =?utf-8?B?VUdJSmg5R1BVVEtCYWVsV0xUYmhFR3hDbEFxeHp3cjA4SlFNaDAxRjZHV2hW?= =?utf-8?B?OTJMbllOU0tYeGhRd1prd1J2QjhpMjc5UVNDZXE4Sm95amlxSGZGUVBRdzVF?= =?utf-8?B?ODQrdTNRMGxxcEFGaUJZV29DdkFveld4ZEIrRVhtWnpOMzNLdGo0d3YycTE2?= =?utf-8?B?QUFPMnZVU0N6MVRrai9sQkNlQ2NnYnZnMS81NEVnWmc0Q0R3ZWRkMk5xczdp?= =?utf-8?Q?2t7JwB3yWwSvDmSy4u1XGlbed?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1093b80-eed6-4d1f-427d-08db34540c24 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:59:39.0230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M/ochzW7QBuQbXIz+OxvSFpoxosAPCwq90fix46mGKLKJTCnQZk7eAIZWVrOHjHrqR3ohI/CSBo9f7VftYvnQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -612,8 +612,16 @@ static const struct test avx512_fp16_all INSN(cmpph, , 0f3a, c2, vl, fp16, vl), INSN(cmpsh, f3, 0f3a, c2, el, fp16, el), INSN(comish, , map5, 2f, el, fp16, el), + INSN(cvtpd2ph, 66, map5, 5a, vl, q, vl), + INSN(cvtph2pd, , map5, 5a, vl_4, fp16, vl), + INSN(cvtph2psx, 66, map6, 13, vl_2, fp16, vl), INSN(cvtph2uw, , map5, 7d, vl, fp16, vl), INSN(cvtph2w, 66, map5, 7d, vl, fp16, vl), + INSN(cvtps2phx, 66, map5, 1d, vl, d, vl), + INSN(cvtsd2sh, f2, map5, 5a, el, q, el), + INSN(cvtsh2sd, f3, map5, 5a, el, fp16, el), + INSN(cvtsh2ss, , map6, 13, el, fp16, el), + INSN(cvtss2sh, , map5, 1d, el, d, el), INSN(cvttph2uw, , map5, 7c, vl, fp16, vl), INSN(cvttph2w, 66, map5, 7c, vl, fp16, vl), INSN(cvtuw2ph, f2, map5, 7d, vl, fp16, vl), --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2031,6 +2031,8 @@ static const struct evex { }, evex_map5[] = { { { 0x10 }, 2, T, R, pfx_f3, W0, LIG }, /* vmovsh */ { { 0x11 }, 2, T, W, pfx_f3, W0, LIG }, /* vmovsh */ + { { 0x1d }, 2, T, R, pfx_66, W0, Ln }, /* vcvtps2phx */ + { { 0x1d }, 2, T, R, pfx_no, W0, LIG }, /* vcvtss2sh */ { { 0x2e }, 2, T, R, pfx_no, W0, LIG }, /* vucomish */ { { 0x2f }, 2, T, R, pfx_no, W0, LIG }, /* vcomish */ { { 0x51 }, 2, T, R, pfx_no, W0, Ln }, /* vsqrtph */ @@ -2039,6 +2041,10 @@ static const struct evex { { { 0x58 }, 2, T, R, pfx_f3, W0, LIG }, /* vaddsh */ { { 0x59 }, 2, T, R, pfx_no, W0, Ln }, /* vmulph */ { { 0x59 }, 2, T, R, pfx_f3, W0, LIG }, /* vmulsh */ + { { 0x5a }, 2, T, R, pfx_no, W0, Ln }, /* vcvtph2pd */ + { { 0x5a }, 2, T, R, pfx_66, W1, Ln }, /* vcvtpd2ph */ + { { 0x5a }, 2, T, R, pfx_f3, W0, LIG }, /* vcvtsh2sd */ + { { 0x5a }, 2, T, R, pfx_f2, W1, LIG }, /* vcvtsd2sh */ { { 0x5c }, 2, T, R, pfx_no, W0, Ln }, /* vsubph */ { { 0x5c }, 2, T, R, pfx_f3, W0, LIG }, /* vsubsh */ { { 0x5d }, 2, T, R, pfx_no, W0, Ln }, /* vminph */ @@ -2056,6 +2062,8 @@ static const struct evex { { { 0x7d }, 2, T, R, pfx_f2, W0, Ln }, /* vcvtuwph */ { { 0x7e }, 2, T, W, pfx_66, WIG, L0 }, /* vmovw */ }, evex_map6[] = { + { { 0x13 }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2psx */ + { { 0x13 }, 2, T, R, pfx_no, W0, LIG }, /* vcvtsh2ss */ { { 0x2c }, 2, T, R, pfx_66, W0, Ln }, /* vscalefph */ { { 0x2d }, 2, T, R, pfx_66, W0, LIG }, /* vscalefsh */ { { 0x42 }, 2, T, R, pfx_66, W0, Ln }, /* vgetexpph */ --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -224,7 +224,9 @@ static const struct twobyte_table { [0x14 ... 0x15] = { DstImplicit|SrcMem|ModRM, simd_packed_fp, d8s_vl }, [0x16] = { DstImplicit|SrcMem|ModRM|Mov, simd_other, 3 }, [0x17] = { DstMem|SrcImplicit|ModRM|Mov, simd_other, 3 }, - [0x18 ... 0x1f] = { ImplicitOps|ModRM }, + [0x18 ... 0x1c] = { ImplicitOps|ModRM }, + [0x1d] = { ImplicitOps|ModRM, simd_none, d8s_vl }, + [0x1e ... 0x1f] = { ImplicitOps|ModRM }, [0x20 ... 0x21] = { DstMem|SrcImplicit|ModRM }, [0x22 ... 0x23] = { DstImplicit|SrcMem|ModRM }, [0x28] = { DstImplicit|SrcMem|ModRM|Mov, simd_packed_fp, d8s_vl }, @@ -1482,6 +1484,19 @@ int x86emul_decode(struct x86_emulate_st s->fp16 = true; break; + case 0x1d: /* vcvtps2phx / vcvtss2sh */ + if ( s->evex.pfx & VEX_PREFIX_SCALAR_MASK ) + break; + d = DstReg | SrcMem; + if ( s->evex.pfx & VEX_PREFIX_DOUBLE_MASK ) + { + s->simd_size = simd_packed_fp; + d |= TwoOp; + } + else + s->simd_size = simd_scalar_vexw; + break; + case 0x2e: case 0x2f: /* v{,u}comish */ if ( !s->evex.pfx ) s->fp16 = true; @@ -1506,6 +1521,15 @@ int x86emul_decode(struct x86_emulate_st /* Like above re-use twobyte_table[] here. */ disp8scale = decode_disp8scale(twobyte_table[b].d8s, s); + + switch ( b ) + { + case 0x5a: /* vcvtph2pd needs special casing */ + if ( !s->evex.pfx && !s->evex.brs ) + disp8scale -= 2; + break; + } + break; case ext_map6: @@ -1526,6 +1550,17 @@ int x86emul_decode(struct x86_emulate_st s->fp16 = true; break; + case 0x13: /* vcvtph2psx / vcvtsh2ss */ + if ( s->evex.pfx & VEX_PREFIX_SCALAR_MASK ) + break; + s->fp16 = true; + if ( !(s->evex.pfx & VEX_PREFIX_DOUBLE_MASK) ) + { + s->simd_size = simd_scalar_vexw; + d &= ~TwoOp; + } + break; + case 0x56: case 0x57: /* vf{,c}maddc{p,s}h */ case 0xd6: case 0xd7: /* vf{,c}mulc{p,s}h */ break; --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7778,14 +7778,25 @@ x86_emulate( generate_exception_if(evex.w, EXC_UD); goto avx512f_all_fp; + CASE_SIMD_ALL_FP(_EVEX, 5, 0x5a): /* vcvtp{h,d}2p{h,d} [xyz]mm/mem,[xyz]mm{k} */ + /* vcvts{h,d}2s{h,d} xmm/mem,xmm,xmm{k} */ + host_and_vcpu_must_have(avx512_fp16); + if ( vex.pfx & VEX_PREFIX_SCALAR_MASK ) + d &= ~TwoOp; + op_bytes = 2 << (((evex.pfx & VEX_PREFIX_SCALAR_MASK) ? 0 : 1 + evex.lr) + + 2 * evex.w); + goto avx512f_all_fp; + case X86EMUL_OPC_EVEX (5, 0x7c): /* vcvttph2uw [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(5, 0x7c): /* vcvttph2w [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX (5, 0x7d): /* vcvtph2uw [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(5, 0x7d): /* vcvtph2w [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_F3(5, 0x7d): /* vcvtw2ph [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_F2(5, 0x7d): /* vcvtuw2ph [xyz]mm/mem,[xyz]mm{k} */ - op_bytes = 16 << evex.lr; + case X86EMUL_OPC_EVEX_66(6, 0x13): /* vcvtph2psx [xy]mm/mem,[xyz]mm{k} */ + op_bytes = 8 << ((ext == ext_map5) + evex.lr); /* fall through */ + case X86EMUL_OPC_EVEX_66(5, 0x1d): /* vcvtps2phx [xyz]mm/mem,[xy]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x2c): /* vscalefph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x42): /* vgetexpph [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x96): /* vfmaddsub132ph [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -7812,6 +7823,8 @@ x86_emulate( avx512_vlen_check(false); goto simd_zmm; + case X86EMUL_OPC_EVEX(5, 0x1d): /* vcvtss2sh xmm/mem,xmm,xmm{k} */ + case X86EMUL_OPC_EVEX(6, 0x13): /* vcvtsh2ss xmm/mem,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x2d): /* vscalefsh xmm/m16,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x43): /* vgetexpsh xmm/m16,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(6, 0x99): /* vfmadd132sh xmm/m16,xmm,xmm{k} */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 15:00:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 15:00:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517506.802929 (Exim 4.92) (envelope-from ) id 1pjLfG-0002y8-Bq; Mon, 03 Apr 2023 15:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517506.802929; Mon, 03 Apr 2023 15:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLfG-0002y1-8s; Mon, 03 Apr 2023 15:00:10 +0000 Received: by outflank-mailman (input) for mailman id 517506; Mon, 03 Apr 2023 15:00:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLfF-00025F-0y for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 15:00:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1a::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39430082-d230-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 17:00:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8760.eurprd04.prod.outlook.com (2603:10a6:10:2e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:00:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 15:00:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39430082-d230-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zj8uHsbxyqDlnVZmjqL9sx91gNXvLdLQH8LQeUnyL22V4/yrnGVAlxxV7CfVrH0ySwjDPNYErJjUcVvHbbxF9bQyWcZvGXcee/VMYUP6EIOwtDJ5HpaMYDcCmGe6C/u/3bk9NIRChLsS/c1LdMreZEKxMao0lir8rF4zASSb/z11JV/YJX+F+U+Bqhi7QvyXjaAu8LaqKR8wiJ8eEXhNPooSIPz70IS25C2zeEBD+d70/3eZZ3OiTePCYV8wL3A4m2wb0ok6GIwvPvwMvsSc+upVhEBrcwDgno62q/Jj8UvgzHqfB6Wf/sc4Ec9Kvlq4ZhmgVxSm0EiiI/k5HCVWYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wxm5CGoq/DJSIHHXyHkrlfKqPlnnC/KYi/RhtFzDoeM=; b=gOBkorkFh5NNcVpHL/s73bGIymlZuIs0MTPIzNBXyWngnZz3RLmK35LhUV9GCL2HwXPgwttejZc+WzHjewjIgN0UqqsANn2FdaZqxMdVQxzE/RZgsIz1Irh/4KA10soQSk2rWhMGglyx0HjNNpbKzwmI6n5GpyLcaA1CxdOB8u4dvwkT4ZgqmvjdzzxOuaNRgX2VK3J6mBWL8kH30n6JnuLgznyBh7NqWZaymNtLWTFaMSEm0Wvw1CJEReYY6VDtiSc+9CVgaoZhXrz2iomnat6yXdvndba6Uq8qTHPj6rkqqtlM7rQ25gITJ7QV6tI1mhhp55mVJK78w3APBufxcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wxm5CGoq/DJSIHHXyHkrlfKqPlnnC/KYi/RhtFzDoeM=; b=L7VenwbqWTh/tIIqcdEIQoz882tcdZFSjd+z0EBbqO3NfLRk2OtJRpmpuxfoSd5a0nU/ZgD96QVFyJFH+Q41DZXp13cH3tCay8ZpyCrZpY4DqW/Hdp4CkFqYSUi+bS2vF9/1p0WLh1fJZ4mHHmPHXr7ETxXNcV2HgKjQLAsO7vv7d1k4qbmgUwKDoM/D3aE4IkxlUzhJkZHUC41yEChLV+sd1PMbKQT3B3IYT4ernTFAOJ3ERGAUVwT74f7W77GS81zOVuWyDBuvLmdoR02E/2zpUpKcPUTrQ1Ma70X+FUJFxpMJAWk9D7umFJU4FlzKxT0+iT1fMdL8QSjUwT81rA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <283bef89-b29a-3cd3-56db-a34dc4f786ab@suse.com> Date: Mon, 3 Apr 2023 17:00:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 09/10] x86emul: handle AVX512-FP16 conversion to/from (packed) int{32,64} insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0242.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 86295e5c-9d05-4e11-d2e6-08db34541cb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JcRK0aNB0Ms6+hy6fVaPmT7H2TV71DRyqJWPTf/9Z0DrjivdCDIHnOUYMoxoQ/OyE54LWrA+a87FBDrD0Y0onokNbgJHhTLBXvnIIeSFryMnTR2agwtyWLTmX5YjGbERsh70xgLaqIEmkaiaXkg8aWh4kAFEPuEzHa9cbL3CpXuTV34h07s5Pa6kFuNLRdIZ8jABOUOQz520KbTS5y9zg0srigjxltyxzgaw5EBUgozvxtqzmFMBIZAxMPFPJrOo5Rwmb4oF6qcaCbq+mfWff1SLkbcwfLttAVMJR9fBZcm8Ocjh2JflD8hRg9ajjks8p4+R/DWEworBmbpmcHL89a/9VXZj9vwNJD7VNuRThRF8IIHnL9J+OW8XVVwdgwKUISngqlAVIRdBuE9+rz59JVHlhvUovjKTyH+bUieNQqHxTZLVfztJc/Vwr0nfxRTvCcPX0xJZkdgtwkGe4Penwd8LsP80Y0eydU9A3uLkzfqPqTmMQhQ2BSFRt56zkoCZ/+yfYkGnD2FqDmjry4GvUEYkK2vweL8pWoo2jg6R82XS/dUlloqMtdKY87QZ5/8sRDcvkHkwdDhZGyYcAZX66xAzfYu0Fxn4OA/UPObfNq/j/JfQ4EU2FFLl41+zRuDjqqQMT1oM7zmP7L/JwD6MHA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199021)(6916009)(8676002)(66476007)(4326008)(66556008)(66946007)(478600001)(316002)(54906003)(8936002)(41300700001)(38100700002)(5660300002)(186003)(2616005)(6486002)(26005)(6506007)(6512007)(86362001)(31696002)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVJOTXkxTmRRWWZKcUxwQUw1YlNHM25DRkU2L3lRWmJwVE04aUJJRkhLOFp4?= =?utf-8?B?WERKVzFGWEo3VzJjdW41bmtmTHg1QUR3elhEQkprK2NETXVQbTQ3dG5HTjgz?= =?utf-8?B?YlFtWXBCbWM0bVlNTmRJUGhueGY0QjM0K2FxUWsxdUUzVWN2eWx5ajJ3ZC9o?= =?utf-8?B?N1A0ZlZMQk9tSHY3RzV4aWM1N0NrL3Y5QkFxVTBwNFc4ZzBqTnhXNkE2NlJh?= =?utf-8?B?S0Q2WFZSL1pNYlRUbFFTUEtPN3NIZlFLczd2ZFRyNTEwVk9xWk1rVEd3a0tw?= =?utf-8?B?cFZpN2pnUHJoeFlxdThUMENnU0N0Q0xQbGQzaHpiRENOdlhVTm5qdWZKTnJr?= =?utf-8?B?UVlaOHBlb1BXTUp3WWNlUlV4dDEzenhUaEFqb2Y4MFNUd3lZVm4wL0RpamxZ?= =?utf-8?B?WmhlMmxvTzlZOENrcVV3Sk9nc0prRFJoUmRoTFYxNi8rK2U4MWJlRW1tNWhs?= =?utf-8?B?ZXpzQnlPbEx0dzZlV1lJSzlHSEFFU3BUdW5zRlNDMVVZa3JMU2NWTTFEdVFi?= =?utf-8?B?QVIzaHY0Z1N3MkxjSVM2RXQ1QTRCUVdibHJRYmlRNkJrUnZDQWNkTGhQTG9H?= =?utf-8?B?SUlBNkw1Y3l2clFodmhQMmdMQm55UUNZU3dFU1VRaU82S3FHRGRyNW5aN1Bu?= =?utf-8?B?NTIyUHJ2eDNBTXptR0JqMEUzWUdzQjh5UUNmV0Vtd0plWWZheUduVmo3NmVB?= =?utf-8?B?dU1YZUN2K3FGZEZQK05mUDB0Vjh0dldGTStxYjd6VU4yQWR2OHJYUDlJT1VE?= =?utf-8?B?RHJOSlJsQi9HVFgyeGY3cDh0Nld4TDRLcE1lb3d3dzU3bVhsWk5RT0paZDlP?= =?utf-8?B?R3dOT1p1endMWGpLbzRKb2xRalFEOVpVaVV1ZFBKVlRPTm9Jd0ZlN2hxeTVu?= =?utf-8?B?M2I4MG84UEo4WXdZU0tUbUVHdElJemd4WU5QcFRSS1g5eFNNc2xuelEwQXdD?= =?utf-8?B?MW9TVkphWU1nUG1qTFIyZHRPRU4xWFlrYjJvbUMvaGZqa20yVDdxdXhJNUhS?= =?utf-8?B?T2pJYUg1UWZreW5WczAxNVJjTG5aMWROZ0ZybTJOTWJjenl5Y2xtZ3BnL0NE?= =?utf-8?B?S1FZMy8rd0RMUEl1YXNPWG40VkllaVppMEh0ZU0wOUZyWEUvaGloVVFpbldK?= =?utf-8?B?TWgxekxhelhsbVoxbmdiQnVRWE1LaVBQbVZFTEtBUHFCNVBqeDQxL0NLSEt1?= =?utf-8?B?dG5MNWtneFYxMzVieklwVk1vb0RYZk5jZ0RBK3Jya3J3VzdmZkJJOHc4eFVu?= =?utf-8?B?NldDRkVQRUgrV2R2RjlJMHRUeUwwT0phd1h6ZjR1QXlFVXNkM1FTM1Fjdmxk?= =?utf-8?B?ZFpCTllTNklocHgwTmZGREthTitZV1ZMek8zMnlEdStWVk5wVExMY3J2MDRV?= =?utf-8?B?dVVXY1F4NExyL0RvTW10K0J2RUc1OHRjbURWVzhsT2ptaCtMbS9FRjhnaXVM?= =?utf-8?B?K2YzVDlNOFNMNlRXWWVuYkhEMm50UkcwQ1JnNDFkT2VnVkFMZTdSemlFQ3VJ?= =?utf-8?B?MEkyTUVFQlRBdTJLRi9XSGkvOGc1OVpaTzQ0b0lRdFkrek9SRTVlUk55cTk4?= =?utf-8?B?WTM3NmhGYXNMUk91VThVa01BS05JeWE4Wm5sV0xGdERFZjRPWXZvT2FibDA5?= =?utf-8?B?ODFZZkdydmJhZ2dIak5GeEoyR3FvbUNDbTJLNFV1NUswNVo2d1RzUzNnQUo1?= =?utf-8?B?bU9MYlR2MlIvTGVMS25ucHJ6aEtoM1pUMUxQUWhJVHVqUDRaRUtkRXduMDgw?= =?utf-8?B?VExsc1dwaGNncUFrSUlsU1VIVm02dklBODlqTzhMMk5vSmcvVUR2UG02dldx?= =?utf-8?B?aCttakI1NkhtN3ZBb3crK2o1WUgza1lVRVlvSTZqdENKbUQ1Ty8wNy8yUjdH?= =?utf-8?B?NHFldThkNUM3ZndmRTJUdFg5OC9pcnVEZ2Vad1U5bkZ5RzFKTUVhNGE4U1V4?= =?utf-8?B?VUVQa3lBb0l4bnZxbkViclJsNGJDNmh0eXdVUzZ2ZmpKZkwyYURTMWJybGN3?= =?utf-8?B?OS9aYitCcGVLNitvMVA5WTRoMHYxN0F5ZmlsL1ZBLzFvRnp6QW1xQXRtZmFj?= =?utf-8?B?R1R4Qmd4Z0ROdXRpRGpDWk9YSDlrMHFtbDlHQ3RDTnNGMDI4WmtGTzFHSWRh?= =?utf-8?Q?IJfNdk0THtwJQDklc2INbjo4j?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86295e5c-9d05-4e11-d2e6-08db34541cb7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:00:06.8062 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iqNOpu3XvHJjWnAGvsYlCgKKbuFjNmm+BVpulfyJ2cixIFA7b4GEb9W3VBNqJhkbr93z+xKum8DNv95lhr4xOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8760 Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -612,18 +612,36 @@ static const struct test avx512_fp16_all INSN(cmpph, , 0f3a, c2, vl, fp16, vl), INSN(cmpsh, f3, 0f3a, c2, el, fp16, el), INSN(comish, , map5, 2f, el, fp16, el), + INSN(cvtdq2ph, , map5, 5b, vl, d, vl), INSN(cvtpd2ph, 66, map5, 5a, vl, q, vl), + INSN(cvtph2dq, 66, map5, 5b, vl_2, fp16, vl), INSN(cvtph2pd, , map5, 5a, vl_4, fp16, vl), INSN(cvtph2psx, 66, map6, 13, vl_2, fp16, vl), + INSN(cvtph2qq, 66, map5, 7b, vl_4, fp16, vl), + INSN(cvtph2udq, , map5, 79, vl_2, fp16, vl), + INSN(cvtph2uqq, 66, map5, 79, vl_4, fp16, vl), INSN(cvtph2uw, , map5, 7d, vl, fp16, vl), INSN(cvtph2w, 66, map5, 7d, vl, fp16, vl), INSN(cvtps2phx, 66, map5, 1d, vl, d, vl), + INSN(cvtqq2ph, , map5, 5b, vl, q, vl), INSN(cvtsd2sh, f2, map5, 5a, el, q, el), INSN(cvtsh2sd, f3, map5, 5a, el, fp16, el), + INSN(cvtsh2si, f3, map5, 2d, el, fp16, el), INSN(cvtsh2ss, , map6, 13, el, fp16, el), + INSN(cvtsh2usi, f3, map5, 79, el, fp16, el), + INSN(cvtsi2sh, f3, map5, 2a, el, dq64, el), INSN(cvtss2sh, , map5, 1d, el, d, el), + INSN(cvttph2dq, f3, map5, 5b, vl_2, fp16, vl), + INSN(cvttph2qq, 66, map5, 7a, vl_4, fp16, vl), + INSN(cvttph2udq, , map5, 78, vl_2, fp16, vl), + INSN(cvttph2uqq, 66, map5, 78, vl_4, fp16, vl), INSN(cvttph2uw, , map5, 7c, vl, fp16, vl), INSN(cvttph2w, 66, map5, 7c, vl, fp16, vl), + INSN(cvttsh2si, f3, map5, 2c, el, fp16, el), + INSN(cvttsh2usi, f3, map5, 78, el, fp16, el), + INSN(cvtudq2ph, f2, map5, 7a, vl, d, vl), + INSN(cvtuqq2ph, f2, map5, 7a, vl, q, vl), + INSN(cvtusi2sh, f3, map5, 7b, el, dq64, el), INSN(cvtuw2ph, f2, map5, 7d, vl, fp16, vl), INSN(cvtw2ph, f3, map5, 7d, vl, fp16, vl), INSN(divph, , map5, 5e, vl, fp16, vl), --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -2033,6 +2033,9 @@ static const struct evex { { { 0x11 }, 2, T, W, pfx_f3, W0, LIG }, /* vmovsh */ { { 0x1d }, 2, T, R, pfx_66, W0, Ln }, /* vcvtps2phx */ { { 0x1d }, 2, T, R, pfx_no, W0, LIG }, /* vcvtss2sh */ + { { 0x2a }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtsi2sh */ + { { 0x2c }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvttsh2si */ + { { 0x2d }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtsh2si */ { { 0x2e }, 2, T, R, pfx_no, W0, LIG }, /* vucomish */ { { 0x2f }, 2, T, R, pfx_no, W0, LIG }, /* vcomish */ { { 0x51 }, 2, T, R, pfx_no, W0, Ln }, /* vsqrtph */ @@ -2045,6 +2048,10 @@ static const struct evex { { { 0x5a }, 2, T, R, pfx_66, W1, Ln }, /* vcvtpd2ph */ { { 0x5a }, 2, T, R, pfx_f3, W0, LIG }, /* vcvtsh2sd */ { { 0x5a }, 2, T, R, pfx_f2, W1, LIG }, /* vcvtsd2sh */ + { { 0x5b }, 2, T, R, pfx_no, W0, Ln }, /* vcvtdq2ph */ + { { 0x5b }, 2, T, R, pfx_no, W1, Ln }, /* vcvtqq2ph */ + { { 0x5b }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2dq */ + { { 0x5b }, 2, T, R, pfx_f3, W0, Ln }, /* vcvttph2dq */ { { 0x5c }, 2, T, R, pfx_no, W0, Ln }, /* vsubph */ { { 0x5c }, 2, T, R, pfx_f3, W0, LIG }, /* vsubsh */ { { 0x5d }, 2, T, R, pfx_no, W0, Ln }, /* vminph */ @@ -2054,6 +2061,17 @@ static const struct evex { { { 0x5f }, 2, T, R, pfx_no, W0, Ln }, /* vmaxph */ { { 0x5f }, 2, T, R, pfx_f3, W0, LIG }, /* vmaxsh */ { { 0x6e }, 2, T, R, pfx_66, WIG, L0 }, /* vmovw */ + { { 0x78 }, 2, T, R, pfx_no, W0, Ln }, /* vcvttph2udq */ + { { 0x78 }, 2, T, R, pfx_66, W0, Ln }, /* vcvttph2uqq */ + { { 0x78 }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvttsh2usi */ + { { 0x79 }, 2, T, R, pfx_no, W0, Ln }, /* vcvtph2udq */ + { { 0x79 }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2uqq */ + { { 0x79 }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtsh2usi */ + { { 0x7a }, 2, T, R, pfx_66, W0, Ln }, /* vcvttph2qq */ + { { 0x7a }, 2, T, R, pfx_f2, W0, Ln }, /* vcvtudq2ph */ + { { 0x7a }, 2, T, R, pfx_f2, W1, Ln }, /* vcvtuqq2ph */ + { { 0x7b }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2qq */ + { { 0x7b }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtusi2sh */ { { 0x7c }, 2, T, R, pfx_no, W0, Ln }, /* vcvttph2uw */ { { 0x7c }, 2, T, R, pfx_66, W0, Ln }, /* vcvttph2w */ { { 0x7d }, 2, T, R, pfx_no, W0, Ln }, /* vcvtph2uw */ --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1497,12 +1497,25 @@ int x86emul_decode(struct x86_emulate_st s->simd_size = simd_scalar_vexw; break; + case 0x2a: /* vcvtsi2sh */ + break; + + case 0x2c: case 0x2d: /* vcvt{,t}sh2si */ + if ( s->evex.pfx == vex_f3 ) + s->fp16 = true; + break; + case 0x2e: case 0x2f: /* v{,u}comish */ if ( !s->evex.pfx ) s->fp16 = true; s->simd_size = simd_none; break; + case 0x5b: /* vcvt{d,q}q2ph, vcvt{,t}ph2dq */ + if ( s->evex.pfx && s->evex.pfx != vex_f2 ) + s->fp16 = true; + break; + case 0x6e: /* vmovw r/m16, xmm */ d = (d & ~SrcMask) | SrcMem16; /* fall through */ @@ -1512,6 +1525,17 @@ int x86emul_decode(struct x86_emulate_st s->simd_size = simd_none; break; + case 0x78: case 0x79: /* vcvt{,t}ph2u{d,q}q, vcvt{,t}sh2usi */ + if ( s->evex.pfx != vex_f2 ) + s->fp16 = true; + break; + + case 0x7a: /* vcvttph2qq, vcvtu{d,q}q2ph */ + case 0x7b: /* vcvtph2qq, vcvtusi2sh */ + if ( s->evex.pfx == vex_66 ) + s->fp16 = true; + break; + case 0x7c: /* vcvttph2{,u}w */ case 0x7d: /* vcvtph2{,u}w / vcvt{,u}w2ph */ d = DstReg | SrcMem | TwoOp; @@ -1524,10 +1548,34 @@ int x86emul_decode(struct x86_emulate_st switch ( b ) { + case 0x78: + case 0x79: + /* vcvt{,t}ph2u{d,q}q need special casing */ + if ( s->evex.pfx <= vex_66 ) + { + if ( !s->evex.brs ) + disp8scale -= 1 + (s->evex.pfx == vex_66); + break; + } + /* vcvt{,t}sh2usi needs special casing: fall through */ + case 0x2c: case 0x2d: /* vcvt{,t}sh2si need special casing */ + disp8scale = 1; + break; + case 0x5a: /* vcvtph2pd needs special casing */ if ( !s->evex.pfx && !s->evex.brs ) disp8scale -= 2; break; + + case 0x5b: /* vcvt{,t}ph2dq need special casing */ + if ( s->evex.pfx && !s->evex.brs ) + --disp8scale; + break; + + case 0x7a: case 0x7b: /* vcvt{,t}ph2qq need special casing */ + if ( s->evex.pfx == vex_66 && !s->evex.brs ) + disp8scale = s->evex.brs ? 1 : 2 + s->evex.lr; + break; } break; --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -3577,6 +3577,12 @@ x86_emulate( state->simd_size = simd_none; goto simd_0f_rm; +#ifndef X86EMUL_NO_SIMD + + case X86EMUL_OPC_EVEX_F3(5, 0x2a): /* vcvtsi2sh r/m,xmm,xmm */ + case X86EMUL_OPC_EVEX_F3(5, 0x7b): /* vcvtusi2sh r/m,xmm,xmm */ + host_and_vcpu_must_have(avx512_fp16); + /* fall through */ CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x2a): /* vcvtsi2s{s,d} r/m,xmm,xmm */ CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x7b): /* vcvtusi2s{s,d} r/m,xmm,xmm */ generate_exception_if(evex.opmsk || (ea.type != OP_REG && evex.brs), @@ -3655,7 +3661,9 @@ x86_emulate( opc[1] = 0x01; rc = ops->read(ea.mem.seg, ea.mem.off, mmvalp, - vex.pfx & VEX_PREFIX_DOUBLE_MASK ? 8 : 4, ctxt); + vex.pfx & VEX_PREFIX_DOUBLE_MASK + ? 8 : 2 << !state->fp16, + ctxt); if ( rc != X86EMUL_OKAY ) goto done; } @@ -3685,6 +3693,12 @@ x86_emulate( state->simd_size = simd_none; break; + case X86EMUL_OPC_EVEX_F3(5, 0x2c): /* vcvttsh2si xmm/mem,reg */ + case X86EMUL_OPC_EVEX_F3(5, 0x2d): /* vcvtsh2si xmm/mem,reg */ + case X86EMUL_OPC_EVEX_F3(5, 0x78): /* vcvttsh2usi xmm/mem,reg */ + case X86EMUL_OPC_EVEX_F3(5, 0x79): /* vcvtsh2usi xmm/mem,reg */ + host_and_vcpu_must_have(avx512_fp16); + /* fall through */ CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x2c): /* vcvtts{s,d}2si xmm/mem,reg */ CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x2d): /* vcvts{s,d}2si xmm/mem,reg */ CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x78): /* vcvtts{s,d}2usi xmm/mem,reg */ @@ -3756,8 +3770,6 @@ x86_emulate( ASSERT(!state->simd_size); break; -#ifndef X86EMUL_NO_SIMD - case X86EMUL_OPC_EVEX(5, 0x2e): /* vucomish xmm/m16,xmm */ case X86EMUL_OPC_EVEX(5, 0x2f): /* vcomish xmm/m16,xmm */ host_and_vcpu_must_have(avx512_fp16); @@ -7787,6 +7799,38 @@ x86_emulate( 2 * evex.w); goto avx512f_all_fp; + case X86EMUL_OPC_EVEX (5, 0x5b): /* vcvtdq2ph [xyz]mm/mem,[xy]mm{k} */ + /* vcvtqq2ph [xyz]mm/mem,xmm{k} */ + case X86EMUL_OPC_EVEX_F2(5, 0x7a): /* vcvtudq2ph [xyz]mm/mem,[xy]mm{k} */ + /* vcvtuqq2ph [xyz]mm/mem,xmm{k} */ + host_and_vcpu_must_have(avx512_fp16); + if ( ea.type != OP_REG || !evex.brs ) + avx512_vlen_check(false); + op_bytes = 16 << evex.lr; + goto simd_zmm; + + case X86EMUL_OPC_EVEX_66(5, 0x5b): /* vcvtph2dq [xy]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_F3(5, 0x5b): /* vcvttph2dq [xy]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX (5, 0x78): /* vcvttph2udq [xy]mm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX (5, 0x79): /* vcvtph2udq [xy]mm/mem,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + if ( ea.type != OP_REG || !evex.brs ) + avx512_vlen_check(false); + op_bytes = 8 << evex.lr; + goto simd_zmm; + + case X86EMUL_OPC_EVEX_66(5, 0x78): /* vcvttph2uqq xmm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(5, 0x79): /* vcvtph2uqq xmm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(5, 0x7a): /* vcvttph2qq xmm/mem,[xyz]mm{k} */ + case X86EMUL_OPC_EVEX_66(5, 0x7b): /* vcvtph2qq xmm/mem,[xyz]mm{k} */ + host_and_vcpu_must_have(avx512_fp16); + generate_exception_if(evex.w, EXC_UD); + if ( ea.type != OP_REG || !evex.brs ) + avx512_vlen_check(false); + op_bytes = 4 << (evex.w + evex.lr); + goto simd_zmm; + case X86EMUL_OPC_EVEX (5, 0x7c): /* vcvttph2uw [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(5, 0x7c): /* vcvttph2w [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX (5, 0x7d): /* vcvtph2uw [xyz]mm/mem,[xyz]mm{k} */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 15:00:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 15:00:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517509.802938 (Exim 4.92) (envelope-from ) id 1pjLfr-0003ea-LR; Mon, 03 Apr 2023 15:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517509.802938; Mon, 03 Apr 2023 15:00:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLfr-0003eT-Ib; Mon, 03 Apr 2023 15:00:47 +0000 Received: by outflank-mailman (input) for mailman id 517509; Mon, 03 Apr 2023 15:00:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLfq-0003d2-Jv for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 15:00:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7d00::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e2cef8b-d230-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 17:00:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS5PR04MB10044.eurprd04.prod.outlook.com (2603:10a6:20b:682::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Mon, 3 Apr 2023 15:00:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 15:00:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e2cef8b-d230-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RnPvN30IJwsMdCvvKw77CHul+ofAp0MqjFkvQ4SIWooEZ9JnR25NquYi7FPRT23gyMmOgT6EojEiq+M+Szuo5+a30A/Oc8GfcdoHSmT6Mtbnw/7jxRbtjNJzbl9NyYxygR3M5/M9+ekNbJWxIP/wCms+lYfuPT3JIdrayVRb2oM/KEkeNF+MPm1XttcysBxkg64hQKaVsTPEBrj7ahmDnVkCeMP+Qzcatp7aQGz7/4p+D3TyNBbLuuVZe2szvyFMqwqxAYRS1xm0wrHBR0BmCqCLXairuqPnUP8y2TqBFyXUE69UDCzLL5MzE0xkmW8MV8W4zrR1GhwFt6pibDX1EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgoSFervzIjjTk4kgA6M9gpJ9SnSpxmSSPmQCBqoFvA=; b=kcz35wr+aH3U5KG99mOoNcJm9qjpZXECZdO1DVRpjT96ZP4Lju7OSJiHKBue/W3gRykxV2LOHISgLt4BZT/1f8pA0O+HRGS68lhpekUSXkjveJT5kDrKIUwoNOai3KQ1BUshGuZ+5Ln0ymEnQe68Ij+7bSlDrNhQmg+dICbyrgWqK3bkFZmay45QCbGQNVQjpvL4NarT2jnAsbow6vHaHFB7OPHb3qwrORtTlRAxcBzomBntcYtPE7pjje5WpSykX7mLVqve8r58YP0YROrcZ8kYkM2fWPFBbeMN0KUCUhKxn2k+dnyrXu4+r7wXUHPb9VMIjslbdda0eh2UjY9D7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgoSFervzIjjTk4kgA6M9gpJ9SnSpxmSSPmQCBqoFvA=; b=VUuIGZ3Kc1qTpyENUmczt3n1Mjft9CDOklqzlQt1a7SVwPmURgjNqvfcFR1iUrfeUvaqTvDRzAJ2Kl5HZA8lHtOYQS/g37T8w2AUw86pY00aOMG6PIUlX/p0Z9fmmoTJZXWJ7HQdeEzOv0kqcHwBdqlDnU7hn6WfQzeaZXWTvlqXIp6Kjhjjh3r/iEGUtpz2JYMCFmJrD49sQvhbgS2h7MD4rL2IY7obOTdpgDR+KWhxydlhNt92B+4cvpfdAa776czHXgJKOvneiuwvhk5YvykkbgKULWTBCmMoJNNZLSzFURnbQaRgnGC7NlbCdGSzx24QmvAuloKFyDXH1g3LnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 17:00:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH v2 10/10] x86emul: AVX512-FP16 testing Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> In-Reply-To: <8cbbab55-d670-5632-30ee-3e8ca352f048@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS5PR04MB10044:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a215608-475f-4f7a-ae96-08db34543140 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ++fwElJb+x3GM0AJnO9BUVl1HXTKb/TFQd7fXUOoaXHjhFZ7RDQDnsxf8E2oWngIemMux6l167LldBpXIrTZy6EK225BNQnC8vDjOr376O1+ggvWK9a9waFzmffzrbrrWM6rtNBDWDNXPgtk2N1999VI3xG9YO3EBN+m2TSPFOdrwSH8TJXTYOTonre1vkX3VqyXoJCbvUeUF0Cu4kln01xZ44yDCkcD2h1WJOVmh16+n0vZymBS8owSTfJa+0nMnnhPDAWvArgDK33utiDxKKDkJjng9yMwLnAdMLBNl8PhQc0vCSP6xYxD7ykkUSQiegl64UuV2eZbJanmNwL5WUmI6YH2akCvwnJoYTBxRe50pJoPEEo751lwbH7w/nC2sEZ3ToEsU6N/GzViiPfLNkH5jMCrFZkqcEX50pTQtstNIc7tZSKKEpHbI7IVkRfkFfGf9He+pC2aBiKPrOqLTcwN/qroYpet1sWB1t4VeSc6b1bVHWvdIRm/elP8187UO1XpEo0xmAvwbyxAOvFUK+iRFU37FGHi9IHc4ODSAN4hnRLT1dtYRmraO6HP+E5RiXR+kUzDIjCRS8gBL3D5LLyhd27voLA6hY7JB/xEZLPeWaG42tPSd1h+K6JYrzYMO47/AIg2k7d1AcxFj9W1Pg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199021)(186003)(54906003)(2616005)(478600001)(6486002)(6512007)(6506007)(26005)(2906002)(4001150100001)(36756003)(66946007)(66556008)(8936002)(66476007)(41300700001)(38100700002)(4326008)(31686004)(8676002)(6916009)(30864003)(83380400001)(316002)(86362001)(31696002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGtqWVIzM040N2JnbXkyellLYlArQWVZdzhDWHhvZDVNUGJ6S1E3RGwzczMw?= =?utf-8?B?ODEvS2JHL2FXN2FVMm0rOTdUWllybHZuVlVEc0pScmhsVzVDVjZIejV2Mm4v?= =?utf-8?B?M1lGcXNvWmdsZUhGYXFxZjFsYUpLQlFkN2FSQjdMN3FFd2ZDUGdLMEw1SzNq?= =?utf-8?B?Y015ZlpkcG15cGUyc2p1TWppdU5rZk5VNkgzRllHa1B3aEUreVlGd1hmTEx3?= =?utf-8?B?MWtnVE1UdGdqMS9VUDZrbDNSM3A5LzFPMThpUXRQdHN1YlZCRVVHd1ludkx2?= =?utf-8?B?TTZrbldTNkVMV3o3a1V4ekEyUVZOb1Njc0N1UTdWWWdJSVZMUkNvdEd3ZXo3?= =?utf-8?B?ci9EVXI1Z1U1QVllaC8welBuNEZ3RUYxK3JqU3VhUGUvU01MYXo3YWRsdmc3?= =?utf-8?B?djRDNEZzVHRZNkhzY1ZGRUFzQ29taUc3NXljRnU5bWpDZ0dCWXlaYkRNOERt?= =?utf-8?B?Z0h6WmJQSEhtbG1jRFN0TGpVV25IaWVjY0hkWTR6MGJ4YU5oTHk0ZGFWNS9z?= =?utf-8?B?QTRrekJ6RTd6ZXVVMVI4clo3RndMeW56bGV0Z0FPeDBpdkVvMlJNMEVUdGl2?= =?utf-8?B?Vzc4UjQ1OE9pMGRTUXgrdjlUR24yN0hveEVIMGljeW1raTNaa3YyVWx6R1pI?= =?utf-8?B?eENMdnJ0SHFQOGVzYjZENmRpVk90aVAycWlMS0xPbHo0MUFaZUJLTnVXNHNz?= =?utf-8?B?d3BTVFFuRXZ6S3J0dGZLenEwN2dWY0NoK2YwS0RnckxtdzdOenF6ckFKZHha?= =?utf-8?B?ZTJwaVBBa0hOYjlGeHhCUHFEeGQ3MzJ0dTNzM3o2Qm5Ua2UrdUZ2bVVGOC95?= =?utf-8?B?ZnNKKy9BdE9GTTkwVmtrazFyK09vSk41Z3BmRXZlRWZVY0EvV0w4bG9oemR5?= =?utf-8?B?eE1ORVRad29mNGJwMENsNU13TDlWWk5teUJnaDkvQk9aRUp4TFozQzBMbDcy?= =?utf-8?B?eUVRcFhuNmt4RWRrbTdGSUV5VWxiK1E3UGt4NkVkMkpMczBzTmxWd2FEdXRY?= =?utf-8?B?L3JIU21aWmVTdk5aT1QrK3U3Mi9KMnpNVmdIOWNuRUlhemxaSmZ4Ui9lS2tF?= =?utf-8?B?YnkrTHVEelBPaGdhL1htR3VBU1lyeU15M1c4K2tQdUJvNmh2em0wN3hSNS8v?= =?utf-8?B?WnhtNlhhQkQyRWhLRmpIVWV3b2xzb2J0dkYrYkZqR1Z4dnYvYm52d0hBdFVj?= =?utf-8?B?OVd6OVAwQVdYYjFlOWloZzkvTzhiajF4UkY5ZWlmWDc2aDZHRE5LZ2xvdzRW?= =?utf-8?B?c1I0dzlkTHV4Z3pDaEtRbHBVbVZrcWhmODZLQW9vbmZuZU9XNUx4KzMwcDFs?= =?utf-8?B?Q3FLQ1gxZ2lOd25ERk5Tdm1FTUVpaGwzNW1Zc2o2dEhJN25NL1hCbElJTlZ3?= =?utf-8?B?Q1JQTHcwcURBQmtjYXMzanp6ZEJtbm1kSXBONHNrQnR1cWJ2OG9STjE3Q2xI?= =?utf-8?B?aElEZmQrT3BUNmFDVmd4d1VRNW5iUHBCbCt2M096QnhvWlpWSnE2cEQ1cXZB?= =?utf-8?B?aWFvUE5KZ3BvelhRYjVjNkpWMlBuZU5VcmcwT0JFd05tSUhuZW83S3VEcXlx?= =?utf-8?B?OGFmeHFmV3NZSTJQaUNHaEV4Z0RRR0haYndEcU9MN1VzU0c3ZEZPZzVxYXVv?= =?utf-8?B?anJVTTJMRGkveUVoajZaQjNSVzZ0UDd5L0dKV1ltK1B1dU01RGRPamlzeFY4?= =?utf-8?B?NU5VQzY2K1pyVWNxclNRdUdKSzNoRFdUMnorQnJUSW5wUVNldmdXMm9xUUUw?= =?utf-8?B?SGtzSmF2ZzRFYmtwSDZJQjZrRFNhSUgxSHNLTkpuc1dOQlhwM1YyMTUxLytD?= =?utf-8?B?aGVpWm9QWFEwMDJXUHhTYVlVRlZ0QWw5bDYreVRKK3BnL1BoKy8rdFMwQU1k?= =?utf-8?B?c3NROUhhNjB5ekMwcW9nMmZCeU1GOTlxd0JUOVJDTTh4NjNmeEh3b05zNmlG?= =?utf-8?B?VFpsZG9HYUpCQk92VGUvRy9hcW91VXZNSEx3M3YwZkhnTWYzRHF5NUpjKzhQ?= =?utf-8?B?dlp2YWJNaHROdUJ3bVRKaVo4NnFOdlpxMTJCVmlXZDd0S2JaSGJKQWZWTUFl?= =?utf-8?B?dVJ6b0RNNE5Yc0U5OTFtM3psOXRXWkZmazRrbFZ2cGd0SXdKVnFlVjB2ZjJL?= =?utf-8?Q?VTJfJtjj3jeH9AApOmOdHQ4IQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a215608-475f-4f7a-ae96-08db34543140 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:00:41.2832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yfFTHl4vAAfPD3HNgiQV/C5iny/iE1CwxemGnCc6KO4pMCA2DyUUsZOMtE0r8/e2G6aH1Mh74UdlKWRxa0aFGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10044 Naming of some of the builtins isn't fully consistent with that of pre- existing ones, so there's a need for a new BR2() wrapper macro. With the tests providing some proof of proper functioning of the emulator code also enable use of the feature by guests, as there's no other infrastructure involved in enabling this ISA extension. Signed-off-by: Jan Beulich --- v2: Add CHANGELOG.md entry. --- This is Acked-by: Andrew Cooper under the condition that public/arch-x86/cpufeatureset.h use 'a', not 'A'. But I was putting this under question, so far without further response. --- SDE: -spr or -future --- In the course of putting together the FMA part of the test I had noticed that we no longer tested scalar FMA insns (FMA, FMA4, AVX512F), due to gcc (then) no longer recognizing the pattern in version 9 or later. See gcc bug 105965, which apparently has already gained a fix for version 13. (Using intrinsics for scalar operations is prohibitive, as they have full-vector parameters.) I'm taking this as one of several reasons why here I'm not even trying to make the compiler spot the complex FMA patterns, using a mixture of intrinsics and inline assembly instead. --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system wide impact of a guest misusing atomic instructions. - xl/libxl can customize SMBIOS strings for HVM guests. + - x86 AVX512-FP16 ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-12 --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -16,7 +16,7 @@ vpath %.c $(XEN_ROOT)/xen/lib/x86 CFLAGS += $(CFLAGS_xeninclude) -SIMD := 3dnow sse sse2 sse4 avx avx2 xop avx512f avx512bw avx512dq avx512er avx512vbmi +SIMD := 3dnow sse sse2 sse4 avx avx2 xop avx512f avx512bw avx512dq avx512er avx512vbmi avx512fp16 FMA := fma4 fma SG := avx2-sg avx512f-sg avx512vl-sg AES := ssse3-aes avx-aes avx2-vaes avx512bw-vaes @@ -91,6 +91,9 @@ avx512vbmi-vecs := $(avx512bw-vecs) avx512vbmi-ints := $(avx512bw-ints) avx512vbmi-flts := $(avx512bw-flts) avx512vbmi2-vecs := $(avx512bw-vecs) +avx512fp16-vecs := $(avx512bw-vecs) +avx512fp16-ints := +avx512fp16-flts := 2 avx512f-opmask-vecs := 2 avx512dq-opmask-vecs := 1 2 @@ -246,7 +249,7 @@ $(addsuffix .c,$(GF)): $(addsuffix .h,$(SIMD) $(FMA) $(SG) $(AES) $(CLMUL) $(SHA) $(GF)): simd.h -xop.h avx512f.h: simd-fma.c +xop.h avx512f.h avx512fp16.h: simd-fma.c endif # 32-bit override --- a/tools/tests/x86_emulator/simd.c +++ b/tools/tests/x86_emulator/simd.c @@ -20,6 +20,14 @@ ENTRY(simd_test); asm ( "vcmpsd $0, %1, %2, %0" : "=k" (r_) : "m" (x_), "v" (y_) ); \ r_ == 1; \ }) +# elif VEC_SIZE == 2 +# define eq(x, y) ({ \ + _Float16 x_ = (x)[0]; \ + _Float16 __attribute__((vector_size(16))) y_ = { (y)[0] }; \ + unsigned int r_; \ + asm ( "vcmpsh $0, %1, %2, %0" : "=k" (r_) : "m" (x_), "v" (y_) ); \ + r_ == 1; \ +}) # elif FLOAT_SIZE == 4 /* * gcc's (up to at least 8.2) __builtin_ia32_cmpps256_mask() has an anomaly in @@ -31,6 +39,8 @@ ENTRY(simd_test); # define eq(x, y) ((BR(cmpps, _mask, x, y, 0, -1) & ALL_TRUE) == ALL_TRUE) # elif FLOAT_SIZE == 8 # define eq(x, y) (BR(cmppd, _mask, x, y, 0, -1) == ALL_TRUE) +# elif FLOAT_SIZE == 2 +# define eq(x, y) (B(cmpph, _mask, x, y, 0, -1) == ALL_TRUE) # elif (INT_SIZE == 1 || UINT_SIZE == 1) && defined(__AVX512BW__) # define eq(x, y) (B(pcmpeqb, _mask, (vqi_t)(x), (vqi_t)(y), -1) == ALL_TRUE) # elif (INT_SIZE == 2 || UINT_SIZE == 2) && defined(__AVX512BW__) @@ -116,6 +126,14 @@ static inline bool _to_bool(byte_vec_t b asm ( "vcvtusi2sd%z1 %1, %0, %0" : "=v" (t_) : "m" (u_) ); \ (vec_t){ t_[0] }; \ }) +# elif FLOAT_SIZE == 2 +# define to_u_int(type, x) ({ \ + unsigned type u_; \ + _Float16 __attribute__((vector_size(16))) t_; \ + asm ( "vcvtsh2usi %1, %0" : "=r" (u_) : "m" ((x)[0]) ); \ + asm ( "vcvtusi2sh%z1 %1, %0, %0" : "=v" (t_) : "m" (u_) ); \ + (vec_t){ t_[0] }; \ +}) # endif # define to_uint(x) to_u_int(int, x) # ifdef __x86_64__ @@ -153,6 +171,43 @@ static inline bool _to_bool(byte_vec_t b # define to_wint(x) BR(cvtqq2pd, _mask, BR(cvtpd2qq, _mask, x, (vdi_t)undef(), ~0), undef(), ~0) # define to_uwint(x) BR(cvtuqq2pd, _mask, BR(cvtpd2uqq, _mask, x, (vdi_t)undef(), ~0), undef(), ~0) # endif +# elif FLOAT_SIZE == 2 +# define to_int(x) BR2(vcvtw2ph, _mask, BR2(vcvtph2w, _mask, x, (vhi_t)undef(), ~0), undef(), ~0) +# define to_uint(x) BR2(vcvtuw2ph, _mask, BR2(vcvtph2uw, _mask, x, (vhi_t)undef(), ~0), undef(), ~0) +# if VEC_SIZE == 16 +# define low_half(x) (x) +# define high_half(x) ((vec_t)B_(movhlps, , (vsf_t)undef(), (vsf_t)(x))) +# define insert_half(x, y, p) ((vec_t)((p) ? B_(movlhps, , (vsf_t)(x), (vsf_t)(y)) \ + : B_(shufps, , (vsf_t)(y), (vsf_t)(x), 0b11100100))) +# elif VEC_SIZE == 32 +# define _half(x, lh) ((vhf_half_t)B(extracti32x4_, _mask, (vsi_t)(x), lh, (vsi_half_t){}, ~0)) +# define low_half(x) _half(x, 0) +# define high_half(x) _half(x, 1) +# define insert_half(x, y, p) \ + ((vec_t)B(inserti32x4_, _mask, (vsi_t)(x), (vsi_half_t)(y), p, (vsi_t)undef(), ~0)) +# elif VEC_SIZE == 64 +# define _half(x, lh) \ + ((vhf_half_t)__builtin_ia32_extracti64x4_mask((vdi_t)(x), lh, (vdi_half_t){}, ~0)) +# define low_half(x) _half(x, 0) +# define high_half(x) _half(x, 1) +# define insert_half(x, y, p) \ + ((vec_t)__builtin_ia32_inserti64x4_mask((vdi_t)(x), (vdi_half_t)(y), p, (vdi_t)undef(), ~0)) +# endif +# define to_w_int(x, s) ({ \ + vhf_half_t t_ = low_half(x); \ + vsi_t lo_, hi_; \ + touch(t_); \ + lo_ = BR2(vcvtph2 ## s ## dq, _mask, t_, (vsi_t)undef(), ~0); \ + t_ = high_half(x); \ + touch(t_); \ + hi_ = BR2(vcvtph2 ## s ## dq, _mask, t_, (vsi_t)undef(), ~0); \ + touch(lo_); touch(hi_); \ + insert_half(insert_half(undef(), \ + BR2(vcvt ## s ## dq2ph, _mask, lo_, (vhf_half_t){}, ~0), 0), \ + BR2(vcvt ## s ## dq2ph, _mask, hi_, (vhf_half_t){}, ~0), 1); \ +}) +# define to_wint(x) to_w_int(x, ) +# define to_uwint(x) to_w_int(x, u) # endif #elif VEC_SIZE == 16 && defined(__SSE2__) # if FLOAT_SIZE == 4 @@ -240,10 +295,18 @@ static inline vec_t movlhps(vec_t x, vec # define scale(x, y) scalar_2op(x, y, "vscalefsd %[in2], %[in1], %[out]") # define sqrt(x) scalar_1op(x, "vsqrtsd %[in], %[out], %[out]") # define trunc(x) scalar_1op(x, "vrndscalesd $0b1011, %[in], %[out], %[out]") +# elif FLOAT_SIZE == 2 +# define getexp(x) scalar_1op(x, "vgetexpsh %[in], %[out], %[out]") +# define getmant(x) scalar_1op(x, "vgetmantsh $0, %[in], %[out], %[out]") +# define recip(x) scalar_1op(x, "vrcpsh %[in], %[out], %[out]") +# define rsqrt(x) scalar_1op(x, "vrsqrtsh %[in], %[out], %[out]") +# define scale(x, y) scalar_2op(x, y, "vscalefsh %[in2], %[in1], %[out]") +# define sqrt(x) scalar_1op(x, "vsqrtsh %[in], %[out], %[out]") +# define trunc(x) scalar_1op(x, "vrndscalesh $0b1011, %[in], %[out], %[out]") # endif #elif defined(FLOAT_SIZE) && defined(__AVX512F__) && \ (VEC_SIZE == 64 || defined(__AVX512VL__)) -# if ELEM_COUNT == 8 /* vextractf{32,64}x4 */ || \ +# if (ELEM_COUNT == 8 && ELEM_SIZE >= 4) /* vextractf{32,64}x4 */ || \ (ELEM_COUNT == 16 && ELEM_SIZE == 4 && defined(__AVX512DQ__)) /* vextractf32x8 */ || \ (ELEM_COUNT == 4 && ELEM_SIZE == 8 && defined(__AVX512DQ__)) /* vextractf64x2 */ # define _half(x, lh) ({ \ @@ -398,6 +461,21 @@ static inline vec_t movlhps(vec_t x, vec VEC_SIZE == 32 ? 0b01 : 0b00011011, undef(), ~0), \ 0b01010101, undef(), ~0) # endif +# elif FLOAT_SIZE == 2 +# define frac(x) BR2(reduceph, _mask, x, 0b00001011, undef(), ~0) +# define getexp(x) BR(getexpph, _mask, x, undef(), ~0) +# define getmant(x) BR(getmantph, _mask, x, 0, undef(), ~0) +# define max(x, y) BR2(maxph, _mask, x, y, undef(), ~0) +# define min(x, y) BR2(minph, _mask, x, y, undef(), ~0) +# define scale(x, y) BR2(scalefph, _mask, x, y, undef(), ~0) +# define recip(x) B(rcpph, _mask, x, undef(), ~0) +# define rsqrt(x) B(rsqrtph, _mask, x, undef(), ~0) +# define shrink1(x) BR2(vcvtps2phx, _mask, (vsf_t)(x), (vhf_half_t){}, ~0) +# define shrink2(x) BR2(vcvtpd2ph, _mask, (vdf_t)(x), (vhf_quarter_t){}, ~0) +# define sqrt(x) BR2(sqrtph, _mask, x, undef(), ~0) +# define trunc(x) BR2(rndscaleph, _mask, x, 0b1011, undef(), ~0) +# define widen1(x) ((vec_t)BR2(vcvtph2psx, _mask, x, (vsf_t)undef(), ~0)) +# define widen2(x) ((vec_t)BR2(vcvtph2pd, _mask, x, (vdf_t)undef(), ~0)) # endif #elif FLOAT_SIZE == 4 && defined(__SSE__) # if VEC_SIZE == 32 && defined(__AVX__) @@ -920,6 +998,16 @@ static inline vec_t movlhps(vec_t x, vec # define dup_lo(x) B(movddup, _mask, x, undef(), ~0) # endif #endif +#if FLOAT_SIZE == 2 && ELEM_COUNT > 1 +# define dup_hi(x) ((vec_t)B(pshufhw, _mask, \ + B(pshuflw, _mask, (vhi_t)(x), 0b11110101, \ + (vhi_t)undef(), ~0), \ + 0b11110101, (vhi_t)undef(), ~0)) +# define dup_lo(x) ((vec_t)B(pshufhw, _mask, \ + B(pshuflw, _mask, (vhi_t)(x), 0b10100000, \ + (vhi_t)undef(), ~0), \ + 0b10100000, (vhi_t)undef(), ~0)) +#endif #if VEC_SIZE == 16 && defined(__SSSE3__) && !defined(__AVX512VL__) # if INT_SIZE == 1 # define abs(x) ((vec_t)__builtin_ia32_pabsb128((vqi_t)(x))) --- a/tools/tests/x86_emulator/simd.h +++ b/tools/tests/x86_emulator/simd.h @@ -53,6 +53,9 @@ float # elif FLOAT_SIZE == 8 # define MODE DF # define ELEM_SFX "d" +# elif FLOAT_SIZE == 2 +# define MODE HF +# define ELEM_SFX "h" # endif #endif #ifndef VEC_SIZE @@ -67,7 +70,10 @@ typedef unsigned int __attribute__((mode /* Various builtins want plain char / int / long long vector types ... */ typedef char __attribute__((vector_size(VEC_SIZE))) vqi_t; typedef short __attribute__((vector_size(VEC_SIZE))) vhi_t; +#if VEC_SIZE >= 4 typedef int __attribute__((vector_size(VEC_SIZE))) vsi_t; +typedef float __attribute__((vector_size(VEC_SIZE))) vsf_t; +#endif #if VEC_SIZE >= 8 typedef long long __attribute__((vector_size(VEC_SIZE))) vdi_t; typedef double __attribute__((vector_size(VEC_SIZE))) vdf_t; @@ -96,6 +102,9 @@ typedef char __attribute__((vector_size( typedef short __attribute__((vector_size(HALF_SIZE))) vhi_half_t; typedef int __attribute__((vector_size(HALF_SIZE))) vsi_half_t; typedef long long __attribute__((vector_size(HALF_SIZE))) vdi_half_t; +#ifdef __AVX512FP16__ +typedef _Float16 __attribute__((vector_size(HALF_SIZE))) vhf_half_t; +#endif typedef float __attribute__((vector_size(HALF_SIZE))) vsf_half_t; # endif @@ -110,6 +119,9 @@ typedef char __attribute__((vector_size( typedef short __attribute__((vector_size(QUARTER_SIZE))) vhi_quarter_t; typedef int __attribute__((vector_size(QUARTER_SIZE))) vsi_quarter_t; typedef long long __attribute__((vector_size(QUARTER_SIZE))) vdi_quarter_t; +#ifdef __AVX512FP16__ +typedef _Float16 __attribute__((vector_size(QUARTER_SIZE))) vhf_quarter_t; +#endif # endif # if ELEM_COUNT >= 8 @@ -163,6 +175,7 @@ DECL_OCTET(half); #elif VEC_SIZE == 64 # define B(n, s, a...) __builtin_ia32_ ## n ## 512 ## s(a) # define BR(n, s, a...) __builtin_ia32_ ## n ## 512 ## s(a, 4) +# define BR2(n, s, a...) __builtin_ia32_ ## n ## 512 ## s ## _round(a, 4) #endif #ifndef B_ # define B_ B @@ -171,6 +184,9 @@ DECL_OCTET(half); # define BR B # define BR_ B_ #endif +#ifndef BR2 +# define BR2 BR +#endif #ifndef BR_ # define BR_ BR #endif --- a/tools/tests/x86_emulator/simd-fma.c +++ b/tools/tests/x86_emulator/simd-fma.c @@ -28,6 +28,8 @@ ENTRY(fma_test); # define fmaddsub(x, y, z) BR(vfmaddsubps, _mask, x, y, z, ~0) # elif FLOAT_SIZE == 8 # define fmaddsub(x, y, z) BR(vfmaddsubpd, _mask, x, y, z, ~0) +# elif FLOAT_SIZE == 2 +# define fmaddsub(x, y, z) BR(vfmaddsubph, _mask, x, y, z, ~0) # endif #elif VEC_SIZE == 16 # if FLOAT_SIZE == 4 @@ -70,6 +72,75 @@ ENTRY(fma_test); # endif #endif +#ifdef __AVX512FP16__ +# define I (1.if16) +# if VEC_SIZE > FLOAT_SIZE +# define CELEM_COUNT (ELEM_COUNT / 2) +static const unsigned int conj_mask = 0x80000000; +# define conj(z) ({ \ + vec_t r_; \ + asm ( "vpxord %2%{1to%c3%}, %1, %0" \ + : "=v" (r_) \ + : "v" (z), "m" (conj_mask), "i" (CELEM_COUNT) ); \ + r_; \ +}) +# define _cmul_vv(a, b, c) BR2(vf##c##mulcph, , a, b) +# define _cmul_vs(a, b, c) ({ \ + vec_t r_; \ + _Complex _Float16 b_ = (b); \ + asm ( "vf"#c"mulcph %2%{1to%c3%}, %1, %0" \ + : "=v" (r_) \ + : "v" (a), "m" (b_), "i" (CELEM_COUNT) ); \ + r_; \ +}) +# define cmadd_vv(a, b, c) BR2(vfmaddcph, , a, b, c) +# define cmadd_vs(a, b, c) ({ \ + _Complex _Float16 b_ = (b); \ + vec_t r_; \ + asm ( "vfmaddcph %2%{1to%c3%}, %1, %0" \ + : "=v" (r_) \ + : "v" (a), "m" (b_), "i" (CELEM_COUNT), "0" (c) ); \ + r_; \ +}) +# else +# define CELEM_COUNT 1 +typedef _Float16 __attribute__((vector_size(4))) cvec_t; +# define conj(z) ({ \ + cvec_t r_; \ + asm ( "xor $0x80000000, %0" : "=rm" (r_) : "0" (z) ); \ + r_; \ +}) +# define _cmul_vv(a, b, c) ({ \ + cvec_t r_; \ + /* "=&x" to force destination to be different from both sources */ \ + asm ( "vf"#c"mulcsh %2, %1, %0" : "=&x" (r_) : "x" (a), "m" (b) ); \ + r_; \ +}) +# define _cmul_vs(a, b, c) ({ \ + _Complex _Float16 b_ = (b); \ + cvec_t r_; \ + /* "=&x" to force destination to be different from both sources */ \ + asm ( "vf"#c"mulcsh %2, %1, %0" : "=&x" (r_) : "x" (a), "m" (b_) ); \ + r_; \ +}) +# define cmadd_vv(a, b, c) ({ \ + cvec_t r_ = (c); \ + asm ( "vfmaddcsh %2, %1, %0" : "+x" (r_) : "x" (a), "m" (b) ); \ + r_; \ +}) +# define cmadd_vs(a, b, c) ({ \ + _Complex _Float16 b_ = (b); \ + cvec_t r_ = (c); \ + asm ( "vfmaddcsh %2, %1, %0" : "+x" (r_) : "x" (a), "m" (b_) ); \ + r_; \ +}) +# endif +# define cmul_vv(a, b) _cmul_vv(a, b, ) +# define cmulc_vv(a, b) _cmul_vv(a, b, c) +# define cmul_vs(a, b) _cmul_vs(a, b, ) +# define cmulc_vs(a, b) _cmul_vs(a, b, c) +#endif + int fma_test(void) { unsigned int i; @@ -156,5 +227,99 @@ int fma_test(void) touch(inv); #endif +#ifdef CELEM_COUNT + +# if VEC_SIZE > FLOAT_SIZE +# define cvec_t vec_t +# define ceq eq +# else + { + /* Cannot re-use the function-scope variables (for being too small). */ + cvec_t x, y, z, src = { 1, 2 }, inv = { 2, 1 }, one = { 1, 1 }; +# define ceq(x, y) ({ \ + unsigned int r_; \ + asm ( "vcmpph $0, %1, %2, %0" : "=k" (r_) : "x" (x), "x" (y) ); \ + (r_ & 3) == 3; \ +}) +# endif + + /* (a * i)² == -a² */ + x = cmul_vs(src, I); + y = cmul_vv(x, x); + x = -src; + touch(src); + z = cmul_vv(x, src); + if ( !ceq(y, z) ) return __LINE__; + + /* conj(a * b) == conj(a) * conj(b) */ + touch(src); + x = conj(src); + touch(inv); + y = cmulc_vv(x, inv); + touch(src); + touch(inv); + z = conj(cmul_vv(src, inv)); + if ( !ceq(y, z) ) return __LINE__; + + /* a * conj(a) == |a|² */ + touch(src); + y = src; + touch(src); + x = cmulc_vv(y, src); + y *= y; + for ( i = 0; i < ELEM_COUNT; i += 2 ) + { + if ( x[i] != y[i] + y[i + 1] ) return __LINE__; + if ( x[i + 1] ) return __LINE__; + } + + /* a * b == b * a + 0 */ + touch(src); + touch(inv); + x = cmul_vv(src, inv); + touch(src); + touch(inv); + y = cmadd_vv(inv, src, (cvec_t){}); + if ( !ceq(x, y) ) return __LINE__; + + /* a * 1 + b == b * 1 + a */ + touch(src); + touch(inv); + x = cmadd_vs(src, 1, inv); + for ( i = 0; i < ELEM_COUNT; i += 2 ) + { + z[i] = 1; + z[i + 1] = 0; + } + touch(z); + y = cmadd_vv(inv, z, src); + if ( !ceq(x, y) ) return __LINE__; + + /* (a + b) * c == a * c + b * c */ + touch(one); + touch(inv); + x = cmul_vv(src + one, inv); + touch(inv); + y = cmul_vv(one, inv); + touch(inv); + z = cmadd_vv(src, inv, y); + if ( !ceq(x, z) ) return __LINE__; + + /* a * i + conj(a) == (Re(a) - Im(a)) * (1 + i) */ + x = cmadd_vs(src, I, conj(src)); + for ( i = 0; i < ELEM_COUNT; i += 2 ) + { + typeof(x[0]) val = src[i] - src[i + 1]; + + if ( x[i] != val ) return __LINE__; + if ( x[i + 1] != val ) return __LINE__; + } + +# if VEC_SIZE == FLOAT_SIZE + } +# endif + +#endif /* CELEM_COUNT */ + return 0; } --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -43,6 +43,7 @@ asm ( ".pushsection .test, \"ax\", @prog #include "avx512er.h" #include "avx512vbmi.h" #include "avx512vbmi2-vpclmulqdq.h" +#include "avx512fp16.h" #define verbose false /* Switch to true for far more logging. */ @@ -249,6 +250,16 @@ static bool simd_check_avx512bw_gf_vl(vo return cpu_has_gfni && cpu_has_avx512vl; } +static bool simd_check_avx512fp16(void) +{ + return cpu_has_avx512_fp16; +} + +static bool simd_check_avx512fp16_vl(void) +{ + return cpu_has_avx512_fp16 && cpu_has_avx512vl; +} + static void simd_set_regs(struct cpu_user_regs *regs) { if ( cpu_has_mmx ) @@ -513,6 +524,10 @@ static const struct { AVX512VL(_VBMI+VL u16x8, avx512vbmi, 16u2), AVX512VL(_VBMI+VL s16x16, avx512vbmi, 32i2), AVX512VL(_VBMI+VL u16x16, avx512vbmi, 32u2), + SIMD(AVX512_FP16 f16 scal,avx512fp16, f2), + SIMD(AVX512_FP16 f16x32, avx512fp16, 64f2), + AVX512VL(_FP16+VL f16x8, avx512fp16, 16f2), + AVX512VL(_FP16+VL f16x16,avx512fp16, 32f2), SIMD(SHA, sse4_sha, 16), SIMD(AVX+SHA, avx_sha, 16), AVX512VL(VL+SHA, avx512f_sha, 16), --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -267,7 +267,7 @@ XEN_CPUFEATURE(TSX_FORCE_ABORT, 9*32+13) XEN_CPUFEATURE(SERIALIZE, 9*32+14) /*A SERIALIZE insn */ XEN_CPUFEATURE(TSXLDTRK, 9*32+16) /*a TSX load tracking suspend/resume insns */ XEN_CPUFEATURE(CET_IBT, 9*32+20) /* CET - Indirect Branch Tracking */ -XEN_CPUFEATURE(AVX512_FP16, 9*32+23) /* AVX512 FP16 instructions */ +XEN_CPUFEATURE(AVX512_FP16, 9*32+23) /*A AVX512 FP16 instructions */ XEN_CPUFEATURE(IBRSB, 9*32+26) /*A IBRS and IBPB support (used by Intel) */ XEN_CPUFEATURE(STIBP, 9*32+27) /*A STIBP */ XEN_CPUFEATURE(L1D_FLUSH, 9*32+28) /*S MSR_FLUSH_CMD and L1D flush. */ From xen-devel-bounces@lists.xenproject.org Mon Apr 03 15:30:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 15:30:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517516.802949 (Exim 4.92) (envelope-from ) id 1pjM8r-0007PZ-6m; Mon, 03 Apr 2023 15:30:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517516.802949; Mon, 03 Apr 2023 15:30:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjM8r-0007PS-30; Mon, 03 Apr 2023 15:30:45 +0000 Received: by outflank-mailman (input) for mailman id 517516; Mon, 03 Apr 2023 15:30:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjM8p-0007PM-Ik for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 15:30:43 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1a::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7de094c2-d234-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 17:30:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7295.eurprd04.prod.outlook.com (2603:10a6:800:1ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:30:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 15:30:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7de094c2-d234-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhGGfpap+l/uzAzkgDekyM8UEe4jxBRuMVoSlTvL71XzqzRpfVBdwCWx9tNc7qpCecxqD87EXzv+vChtJMS42AQo9ZviLy6p4jCkP+DcVRWX0/bG3fO5291dEckEaSITWHSBxq+8r7e9B9fe4Oy2zMSe2zWDSuzQ4tWXJeOJmt7iDlYyZCZr9skDIC+mV7bzU2bdWYdavDI9m6rTrwQT3dz/UAsLALptCW4vck014hBoYm9YLWl/LMWgLeFn/LtqGoRVfkJn7UHAn7UPbR+f3OshC2ZjDuYfegnAMP6DYU3rtV2sqHsDJ7LF13vuLny5wbFiBUN/mXYuKPyrWoLrEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B67imkZ+mLCqggN+D+FxYzH+CtFN8swOWJXmBPyZXY4=; b=iWFL42km80Gcki3XEjk4p89LcvTQoi0p5tS8GBbrOLU97lmFOxjBLIUN9R6Ab+tOMK8wjLXhIpq9Vs1gh0EThO11LfnYQAXnsweEqib1jirosvRsky5WmSnBHmDfXOw+f501n+eGV1G943+D7cbr9sx1nOo880AqeMWqIC6Lvq8LbtJMwo2habZ1PSb68djIqozRW3hlxhf35JoMZ2rbbb/F1P9RRmGWhI+YnATmIN08QqCClvFGOYx+5XpvhglMsCOawfSb3Gfb4PActUJn3l0ApAj14h/an6jrifwyaP6IAAfar8PBr+JpYbgSP+obBk2p0Qh4vRp+vhkx/k0cZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B67imkZ+mLCqggN+D+FxYzH+CtFN8swOWJXmBPyZXY4=; b=IvkreTiEJVYlokaNZihpp1VTdqE0yn5jec/tBohrnZ+JldQ/+yFd00oFxzm6yw0tpfjEbzSHmsgEnku80N/fOJcnY409jGbQm4f0EV1bCqxDs0BgibJ75+PSPh0JRNvqYyzEZKM7bqifNRTUdWkCIAQDcpvqExMiQIfb7168T30Vs0lD9PIbXHPR0eNQNDmxHq7BpF3Yu698pJ1hp148SyzA6PHRROrhMHu+5gSXYhZJvojxqyFt5afAf6KJ8m0Mh7oWNKHqBBQ3A/RjtPAkbD1GIglhmFLPPx7VXqf/u1DJ8P5zR7Hffs7NFSvDhrP+X3zTtkkGJRp2zETOt+xJfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5fc00c1a-11ea-905e-49eb-d70caaf71041@suse.com> Date: Mon, 3 Apr 2023 17:30:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230403101449.93323-1-roger.pau@citrix.com> <8d976d34-8a1e-95ad-3bc9-3cb704c1fae7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7295:EE_ X-MS-Office365-Filtering-Correlation-Id: e711b2bc-2f86-472d-a0a4-08db345860bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GGPZlNp0ygXGJkHBr4ME9ooyBKI1D52o6tbcPC+uuHFWYSMwyYzWMVRMd64/qYo71yC+Q/3V2ZcDd41VwRzeXl/u1U0x7gGBgAZWDwdxSR1IOmAK/lclypGPRmKOBOB8eT/H3kkyHEbGHH0BC/8yRRdZe60qjGfZm7Hz1xTPWpARts+GYLJwFvjlBgGQuAQIK+s+SAGWEXPpsKLrKKntep+sA7z9GHyl5uZOagUlhP0o/vNX4Wh60YSpA2DMc+/HwliZYMargKLwnLDXMRlwiEcACRRehZehs9tcuKEhd8yOZYL+oKokNH0UiV6esyq37uXyDhEEuqjXJDLd30D1rCWRYSGqv711LiJ8/9fqzWHnvxKoHj0Q9IzTt/PE/jlBqxf0s8VAtwapRoWTpziJT77Gb7Q4BaYa3sa0IcU1mD2uBvCGMKajozIxoY4nG4P8LNfn1vTF9mSf8o8+SpHa4IrW2C0vMw/n0xBfWhVCzWIFW5/9q8AbV76KbKEucpu5SL6GVPMaMYP3r1QJ0mKO6PuLr+KM+4vhLOrp69aXXMHopjx+tSTAn6buH03f2Zd/T7IVIS6szc9SeMWp1MoWn7Ai7eYtHuvyE3qvxQ8f6dEviduqzxmz9FpJN8x/d2rkWIc4EqKnW60fOniUhfkuqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(346002)(396003)(376002)(366004)(136003)(451199021)(31696002)(86362001)(36756003)(2906002)(31686004)(2616005)(53546011)(186003)(83380400001)(6512007)(6506007)(26005)(6486002)(8676002)(6916009)(4326008)(66946007)(66556008)(66476007)(41300700001)(5660300002)(38100700002)(54906003)(316002)(478600001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3h6NGRZR3Y4Q01VZHdKcGZER1ZQdTFFWGZPc0ZENzk5RlQzYWgyNUVPUWlN?= =?utf-8?B?U1JZYUNISy9WakhHaXdWck9JRVR0V05FOGR4VDFNc3crWHVUdnhUREpnUHVu?= =?utf-8?B?T2svMkVCbUdrNEUxU0FkTVZBRURmcXJmcnl6bDd6U1JqMG9wNEZqTWRBSWRK?= =?utf-8?B?aUNPSnpKNnNFZE1XaTZyN3g2QVRkc3BxaWRvaERiaEM2azlHTDBWbjd1U1o1?= =?utf-8?B?VkxOYVZ3U2toVlUyaytSemd2cWIxbHFUSWdCM3dqWFB0MExaQldNSXFUWW9x?= =?utf-8?B?QWlTRDFsbHZHTG1sR3lNNFMyMlJrNDI1cnBEOHlNZTJCS0xHc1NUK0FTVkMr?= =?utf-8?B?Y1FwK01GL1E0QjhWSFJxKzROVVBJU0lJQTdBVnZOMnRQb280WFhZbzBCanBE?= =?utf-8?B?ZEd1MllTNFJLanlOSzFuaUN2RHJ2Zyt3bi9KZWdFTmpGbFJ2Wi9OQUlENHlO?= =?utf-8?B?VitLVzQ0U0ZOQk5pQ080L3BXL0xkS1V1dFBtMXpQQm1KM2RsTUxJUHVCUHY5?= =?utf-8?B?dE5tK2gzQWZKQmV1QXYwNE40WFpmK3NGV01JWWRLMitXYVVtSWtTcDFETE8y?= =?utf-8?B?bXphZS8xNHBIQ2Z0bFhMamQ3V3Q5RVVZS3BHdnJtT3o4ckpvVkhDcHJITjFD?= =?utf-8?B?MXRiQmtKMm9kVVBhZWp6aDZLa1hNS2pORk1MK0pWZ3N1dXczVDk3YWdURFNw?= =?utf-8?B?Q0xCV0RQZEEyL0lyWDJScEdNN1ZWUGRkVHFkSlRHa1BGTFhzclFqNUFTbUpi?= =?utf-8?B?S3FBMkgrY2I1d29KK0xCTlRPOHUzWnM3RWM0WlN3V2lTVUJyYXVxamdKZ3F1?= =?utf-8?B?K3FMdXIyQUxOcWZJM3dpUC9nL2xkUEc0ZmkwYUdkU1NpTk8yRUo0RVBjZXRt?= =?utf-8?B?bDhibm1tOGhpMmdHNFVnaDAvTzQwUThtVUxyaVBEQjhsQjZFeWRJTUExVUgw?= =?utf-8?B?eTJyNzdNUVJwbk1Ydk5QWTZPYU5tYmVTNmx4VjFqMlBXaUlMN3JiRkkrRmJT?= =?utf-8?B?RDJUM21sVXZ4aGt6K2Q1VVAvQkF3ajNxSWJRMU93UWxQenM2MmVnVUgrV1dv?= =?utf-8?B?QWhmWGZsQmp3UWU2WU5qaHFIZlV2RHkzM2tmcUxmak1WcWFZSC84bTBzSmpN?= =?utf-8?B?SlBDekMrb3JpM1RodVhWYjB4UTdwWStIMzIvZXhXL1NVem5mSHhFYm5JWjNj?= =?utf-8?B?V1dwSnNmMUhTKzNid0RWOWxiTjYwUHZES1B3NmF3bTZvQzFJeUxhaktnWGw3?= =?utf-8?B?Sk1jNVhSMjBnbmdVOVZWYlJmMDlKcENCWjh1WDlPRURMQWw0dFcrNGRhR1pi?= =?utf-8?B?R09KbnhYb3FJVGRaMkdQc01wRHJzRzJuN1cvcEN4OHNPNER0citaZElkSGh6?= =?utf-8?B?eGwwakZ5T29jcWJiMjZGR3hWSGRqTDdEMXdzTnZMWThHcVp4c1hpWnRCTmYw?= =?utf-8?B?dmdtVG84ZEMvZ2IybGV6TGNXNkxDditQTThMQk5JRWlxVnBGOHM1b1JUcE4w?= =?utf-8?B?Um9ibW5LQnFlRG1SV2lFdTRaRUpZQXlUdnY4YXFEUVZXYzV5RFNsK05KUkV5?= =?utf-8?B?QjdHQTkzSHJ0SkhvUS85cEJJeFowdmNhVHJXVXgyWlFXTU5oOHR6N1M4QTQ4?= =?utf-8?B?RFk5d3g3Z0V3V0JyOWwzRk0yTHVGNGI0eDZ2UTF2WGRPdHdQbzJhZmw4S1dj?= =?utf-8?B?OExZaDAzclFaVzRTQlJ2ZC9Ddzg4U21yN0RNTnJHQVA3dU1hMG1zYWx6YXNJ?= =?utf-8?B?ODFpKzYzUG96eXBNbEUxUjhjdGtYSUNHV25mM2pxR1Fsd1JyTUFITjVxOU1F?= =?utf-8?B?dm5JZlpyek9qQzVRMFNqdm8rWUZKYWFhdFZKYmNVTjhTQzhGcG1kRExPbWJZ?= =?utf-8?B?eUUwUVgvYmpRTmNrb1Q5cUZJKzFERnNncEFiMHVkY3RNR3dSaWZKalAveUNv?= =?utf-8?B?NEhaYlU1enZCQkxXOHJQcVZlOVNGdTY2allackFCQTlqRS9HZ2lrbkk2YUNs?= =?utf-8?B?T05NY0grQy9xNnhJSWgwY1JmYmdvOEYrc1U1Z2R2NlpHSXdPMUp0ei8rdE5l?= =?utf-8?B?b1BCVjhyYUhKZUh5ZjdLRU5SbFRRWkE0cE9RMlRaa24yREVlZnFrT0h1eHdB?= =?utf-8?Q?nkMqpk5M+A1jyC12MKNQgVhBL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e711b2bc-2f86-472d-a0a4-08db345860bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:30:39.0138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /JDFppl6blr1xh4u3Q+C/fE7Rd6JnYPrzmUmgP9KvlJ4Eo8KgYml4+0RrrGByGWPXdROxWm3lzdSj9XiCGvv8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7295 On 03.04.2023 16:27, Roger Pau Monné wrote: > On Mon, Apr 03, 2023 at 02:39:08PM +0200, Jan Beulich wrote: >> On 03.04.2023 12:14, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/mm/p2m-pt.c >>> +++ b/xen/arch/x86/mm/p2m-pt.c >>> @@ -486,9 +486,6 @@ static int cf_check do_recalc(struct p2m_domain *p2m, unsigned long gfn) >>> p2m_type_t ot, nt; >>> unsigned long mask = ~0UL << (level * PAGETABLE_ORDER); >>> >>> - if ( !valid_recalc(l1, e) ) >>> - P2M_DEBUG("bogus recalc leaf at d%d:%lx:%u\n", >>> - p2m->domain->domain_id, gfn, level); >>> ot = p2m_flags_to_type(l1e_get_flags(e)); >>> nt = p2m_recalc_type_range(true, ot, p2m, gfn & mask, gfn | ~mask); >>> if ( nt != ot ) >> >> I'm afraid I neither understand why you make this change, nor why you >> then leave the other use of valid_recalc() in place. > > The message can be bogus if we allow concurrent do_recalc(), and I > did miss the previous one. > > I missed the one at the top. Originally I wanted to send the RFC with > just changing the lock to read mode, but then I though I might as > well fix that (now bogus) print message. > >>> @@ -538,9 +535,9 @@ int p2m_pt_handle_deferred_changes(uint64_t gpa) >>> */ >>> ASSERT(!altp2m_active(current->domain)); >>> >>> - p2m_lock(p2m); >>> + p2m_read_lock(p2m); >>> rc = do_recalc(p2m, PFN_DOWN(gpa)); >>> - p2m_unlock(p2m); >>> + p2m_read_unlock(p2m); >>> >>> return rc; >>> } >> >> How can this be safe, when do_recalc() involves p2m_next_level(), which >> may install new (intermediate) page tables? > > Oh, great, didn't realize it was capable of doing so, it's more hidden > than in the EPT case. Seems like this will only happen if a superpage > needs to be split because a lower order frame is being used as an > ioreq server page. > > Do you think it would be safe to try to attempt to perform the recalc > with the read lock only and fallback to the write lock if there's a > need to call p2m_next_level()? Yes, that ought to be okay. > Do you agree it might be possible to do the recalc with just the read > lock if it's updating of PTE type / recalc flags only? Technically this looks to be possible, yes. Question is whether we do ourselves much good by introducing such a special case of permitting a certain kind of writes with the lock only held in read mode. The latest when we find a second (more or less similar) use case thing are likely to become difficult. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 15:32:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 15:32:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517519.802959 (Exim 4.92) (envelope-from ) id 1pjMAp-0007xb-JJ; Mon, 03 Apr 2023 15:32:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517519.802959; Mon, 03 Apr 2023 15:32:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMAp-0007xU-FM; Mon, 03 Apr 2023 15:32:47 +0000 Received: by outflank-mailman (input) for mailman id 517519; Mon, 03 Apr 2023 15:32:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMAo-0007xO-45 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 15:32:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061e.outbound.protection.outlook.com [2a01:111:f400:7e1b::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5749c1b-d234-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 17:32:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7295.eurprd04.prod.outlook.com (2603:10a6:800:1ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:32:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 15:32:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5749c1b-d234-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9npcgi1+bMVFezilYeE8bOu6Olj2VyP3KcCmsg5G+ZpVs5+CIR1JFLB82e6G0IWFqV/131USArPUZhODtJpu4UjJaMMZf2B5QUzz5iv8hEikgtejyK/zBfcBsXGNkKj67qCI/StS9mJ4P2esUQrKEpgnVmIQLkrN1tgH76o9siOtvVblmmNLlE58RR7+BQOyHy7P+UtRdjfCLqFamAN3Isn1nnpGzavlCqGrvnrEC6SHWhGNbngMRw/t42kuTrtcVS4FgiUUjQkvk6UEg1LR4m3F+qtAb9dyLzigBtATiPfAHaqUroUyl1IYmnTE8XxUJlfH9erzh35RsQFPOht+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yW/TYZcHxb7whSHZnCCIC13DmOy6RkRRJZkmFNF2v9c=; b=m07aEJNuiy5pMk3GTfVwPhYPoiLta95wHv8rSvFoSgwewluzk1bNm2C+WCzi0LXWoNYa21BA5tLlaxvSn8DLC+k4yakUfCCRTl/IbLVEsrlvFRpL6iylIULND4qcbYc7m8PMKli5u1M2ORHTVHT6jf6ImgeK8+KsYBg65NtggybXxcGg9XM4cwiJc1lWkqvTShcoVUqku/u4u5MOMYh2H2oQPHYpQpb8+wCMP6TOlwu/C72s1B/amlro4SI5uq4OS1X1Ji43E6Lab6fjYw520lEg4u7wYqfk4E0GAchzLEx6cYR3JQavnW8G+8Ti8+hIeCo/yh4uVZR3KJ21fdQSiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yW/TYZcHxb7whSHZnCCIC13DmOy6RkRRJZkmFNF2v9c=; b=ZXt+lPT94rfssoFdpe3MjBBAmny+NMLUUwkVfv1QgwmVyCgP3UdKtfHehG2flaRCKarzJmVLwt3Ukf2twlDXKQjimtb0dxhr236aV3Q5QTpqo/RnWHKNlkyCEHcB2QGAcSdc2InTH6bGAYXzHK8jrzMaGUnRTBgkPVvR3hoVe7ZEQTNZRnHDS6KPOjxCnQ4pvd7JspWWgOgv60UFoEYxWgRzCFWfvaHpIJpq7+DQqQsMAGjhbpyeEkafT/7kPIpI2UHlVn6rhxCFw+x4vjf5ubseXgRFFQAFUwLMv8G+7wneWzafqXV0Z9x3QrN/GguUDu8/bRJP/IyRou6YfZw5Hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0adcb388-d2a9-e43e-ec20-de1df51f33d7@suse.com> Date: Mon, 3 Apr 2023 17:32:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230403101449.93323-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20230403101449.93323-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7295:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ae16332-831e-4b02-4488-08db3458a93c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IjDEoTk22sxoybyjViHc6gj6hhsNoWi93iVA7Pb4rGtPRH2gPmmSOjwKbazmNqa/FsrtUKeK3/+1KJrQ9MzU9cBSkLdsJQ8fCACHke+KKdpeRJvaIjQaebQcWn8+1bRYKaBLW43VoIwDgXb1Ab5vl2d/HzlZ3MYTo6U2tPFip+IfJcH2/O8gXHHdsEVP95m8vNFyVs8DLfuVeRwY+ok11oRzU5BfPJWeTa9RBIBBgwQiRPlv3XMagUqqafeAoe1l76tHmJt0tpAH51dxrE8p2usDYTJqzpsPceXCwXPDYKY9l+tu0iuQpeem7W2wMTtCFciV9mEPkl1/VgecfW8BrXl2XqTMHkmvIh3xKYecP6HkWDkjvXaTVKb0cnJLAOChZrbUvgDuCmzYLNtkW6delazM867P4ARZ8YD0QZJWiq9O25eN8ALJZBPY2gHGDec2WiIrmAzh8kRT1aAalu10Ex0oWXscE7X9B1hvFyY10VDbO5yL1rxeBTKWf41G7kBM+a2i7Y++OdWbH3T/6MBcEtQqzwILjnWWZDfBkh1Lb/IMk8QX7c/NeL97h2jGon1jT1MC5+YzZTfg+564T7lFZS9V/Bxi0iyFHG5YsvNwQzXjaV81sXYWW9ZN8BvUC735NgPIdv0X2+5wFiWDvEv0yw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(346002)(396003)(376002)(366004)(136003)(451199021)(31696002)(86362001)(36756003)(2906002)(31686004)(2616005)(53546011)(186003)(83380400001)(6512007)(6506007)(26005)(6486002)(8676002)(6916009)(4326008)(66946007)(66556008)(66476007)(41300700001)(5660300002)(38100700002)(54906003)(316002)(478600001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q09rTXp4cnFMeDBjWGtGMWRPU3hFbmp6bUNSbEVRSmlXNm0zWlpSVTFwRWY4?= =?utf-8?B?QW93NEFtUUcrcEgwalJKdW1PY1B1YUVJbGZBbVdyYzlOZjB6YmNGcWlpdWxN?= =?utf-8?B?WUhBc0VJamd0N1prdFF6VXZ1NEJIeXB0ZzVpbUtxcUptallYY29hUEJTb0RL?= =?utf-8?B?cG9Jb3RRQnZJRGx1NmRLRUtZZDVEKys5VUw1ZGxXNFRvajJialkxSHVKRG8z?= =?utf-8?B?Skk5N0Fld0dDRmR3bTlHeFpQL1RRSTR6LzJ2Slc2QjE3ZjR4NHdEZCtORDNN?= =?utf-8?B?RmRMcXBFSnoybi81blY4QUI2VVhhS3FzK3JqdlRlTHJmbWpIQ2ZQNTJxT1hR?= =?utf-8?B?SVNKSnFZMWlqSmtEa0pralZHMkt5VWNXcStzcitKaDByVnRjcmZYaDErUUox?= =?utf-8?B?SkFPNVByckJQZG1OMlJWQXV3SkZDY2N4L0RTVnFLd05VNForU0tFTXpWMlE5?= =?utf-8?B?OHE1bENUZ0ROSGUwakNJLzh6MThCRWsvS0hDYVBkb3YycW5tTVg5ZHBWQTk5?= =?utf-8?B?aHMxSVgwN1Q4YURBWHlSRVg4anprenZRNFRJcWliVVcyVlhDTU5yVHpZTHB2?= =?utf-8?B?b3FZZWgyUm5KVlVKMUw0V1dZM1hKYnEvbGZ1ZGFBc0UxWU1hNXFzU1RhSmJP?= =?utf-8?B?aU5KUGVtWk1SOUFtWGVxT04rQ3pDUkJwYWdEbGhCSk5HUG03RHk2cXV5eHlX?= =?utf-8?B?K2w4YVN2VEo5K3ZLdDh0K2xvT3h4SFhseWZJb3FOM0tBT1VQUXdaUExHZm9S?= =?utf-8?B?d1BVc2xWVVRFUWJsOXQrUk43NGI4WFgwNi9sTGhScm5FWnZWTXhOTWE2MERQ?= =?utf-8?B?TldSaytyQXNWTmFLUVJUSWh4QndBMGp1c3Iyc05zdDF2SytLSWI5TjhMTFFW?= =?utf-8?B?c3kwbk1zaWhPK1Y3NUIyb0xETTRaZy9vQXVwTTZwOEh1bnEyajdpREc2ak9s?= =?utf-8?B?dXVpd0I4VzE5ZFZnbjJUL0I4cVRzYWZXQTExb0pzOEJoUEJkK29tV3Q2UUti?= =?utf-8?B?UnVjcUJ0STlwZTY1M1p3UFJ0L0FHeWc2WDdDdXhwdmFQb2ZKd1I3akZEdHF1?= =?utf-8?B?cGtHQTRjK0lmQUQvd3VzWHY3SHlRTWd6bWV6SWVmMUFnUitQQ091T2tncmVP?= =?utf-8?B?aEhVK3l5L1M4YnhNYi9hYkh1K25oSXpPNTdrOGdzNDNqMjdJc0R2dXZBWWhL?= =?utf-8?B?OGtYeTU1c2J3K0VzY3p4QzhMMk96RElmaGJOWVpqc1c5ejJRcG9RRHR6bXNK?= =?utf-8?B?cUdwU0ZKR2ZFUzRPTTdhL21OdHdMWlMwM0s2QUJXSk5idS9ROFRiaDl4Rnho?= =?utf-8?B?d2ovMW0wRnZhcHBIRndnZGRxOWJPb2FZanVMNGRERHNyZHhPT3ZHWFljaFBD?= =?utf-8?B?THpic2ptSHVjOGc2a3dpMHB3Ymx6T3VqbTYzZEdweWhXS0lEVVdMQ1hyQi9C?= =?utf-8?B?aFB3Ymh2NnRROThkMURSZHZLdVlyWmZLdi9nZmc3L0ZYUHJmUnlOZ2RNRGkr?= =?utf-8?B?Lyt1ZDBTV3F5dWNreml4aTFvODFjRXhTa3diM0RDQnRIZDlVVGZyVGZZOE9R?= =?utf-8?B?N2NBRDZmN2QvQ1VLc3B6cDBPTkY4QlpGNXphSUtvSU1hT0phQWdyaE10QzVX?= =?utf-8?B?Q3A1eUEyRFBjSlAyRmRlNEV5T3ZQZmhucnArelZNaEx3MzFQdjlzUE9xamtS?= =?utf-8?B?MGxnRUhrY0lIM1RkQ2J0V3R3K0JKc0tRSG5mVFFuZFdLTFkvYnVuL2E3RG01?= =?utf-8?B?emtCK0tNOFRLVmtHNWVNZXYraWhKK3dPUW42dWFESk15ZTRWc0pjTGkvN1J6?= =?utf-8?B?WldNZ2kxa0NyWmxlNzlacGdIdTFoMzJkVDYvNGRZdkJzMzVZUVZ4OVBXOWNl?= =?utf-8?B?NWlUb3JmN0U2aHltOVJ1L2VLc1VwQmk3WllMbUJMLzhUVHhFRnVRZHhUK2ww?= =?utf-8?B?VERvcU5lTm1JazBtcTVnOEFYOU11TkhlUUp3bHRtMkJoOGppN3kyeWVzVW9B?= =?utf-8?B?T3BMbjNDZUZOOFFCZVZEQWs1U3NMV2ltS0lWM2psc1ZibEFlN3kzMEpjb1Fh?= =?utf-8?B?czRsTHVIV1pGT1dVZGd2V3FqR09jZGdYSGhVOEl4SnVYVkd3a3duRytPN292?= =?utf-8?Q?l8DkJLD+eAv6UMp1/BAa65Bse?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ae16332-831e-4b02-4488-08db3458a93c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:32:40.5559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WwAw3nFK9ODvlJA9bLC1jdt0LCDwYbvXPrJ3bsFZrnCL2TN9MMmC2Q/Eb3M2V3l/vyD1maJZA/zJNahBH06ujg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7295 On 03.04.2023 12:14, Roger Pau Monne wrote: > Global p2m type recalculations (as triggered by logdirty) can create > so much contention on the p2m lock that simple guest operations like > VCPUOP_set_singleshot_timer on guests with a high amount of vCPUs (32) > will cease to work in a timely manner, up to the point that Linux > kernel versions that sill use the VCPU_SSHOTTMR_future flag with the > singleshot timer will cease to work: > > [ 82.779470] CE: xen increased min_delta_ns to 1000000 nsec > [ 82.793075] CE: Reprogramming failure. Giving up > [ 82.779470] CE: Reprogramming failure. Giving up > [ 82.821864] CE: xen increased min_delta_ns to 506250 nsec > [ 82.821864] CE: xen increased min_delta_ns to 759375 nsec > [ 82.821864] CE: xen increased min_delta_ns to 1000000 nsec > [ 82.821864] CE: Reprogramming failure. Giving up > [ 82.856256] CE: Reprogramming failure. Giving up > [ 84.566279] CE: Reprogramming failure. Giving up > [ 84.649493] Freezing user space processes ... > [ 130.604032] INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) > [ 130.604032] Task dump for CPU 14: > [ 130.604032] swapper/14 R running task 0 0 1 0x00000000 > [ 130.604032] Call Trace: > [ 130.604032] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > [ 130.604032] [] ? default_idle+0x1e/0xd0 > [ 130.604032] [] ? arch_cpu_idle+0x20/0xc0 > [ 130.604032] [] ? cpu_startup_entry+0x14a/0x1e0 > [ 130.604032] [] ? start_secondary+0x1f7/0x270 > [ 130.604032] [] ? start_cpu+0x5/0x14 > [ 549.654536] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) > [ 549.655463] Task dump for CPU 26: > [ 549.655463] swapper/26 R running task 0 0 1 0x00000000 > [ 549.655463] Call Trace: > [ 549.655463] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > [ 549.655463] [] ? default_idle+0x1e/0xd0 > [ 549.655463] [] ? arch_cpu_idle+0x20/0xc0 > [ 549.655463] [] ? cpu_startup_entry+0x14a/0x1e0 > [ 549.655463] [] ? start_secondary+0x1f7/0x270 > [ 549.655463] [] ? start_cpu+0x5/0x14 > [ 821.888478] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) > [ 821.888596] Task dump for CPU 26: > [ 821.888622] swapper/26 R running task 0 0 1 0x00000000 > [ 821.888677] Call Trace: > [ 821.888712] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > [ 821.888771] [] ? default_idle+0x1e/0xd0 > [ 821.888818] [] ? arch_cpu_idle+0x20/0xc0 > [ 821.888865] [] ? cpu_startup_entry+0x14a/0x1e0 > [ 821.888917] [] ? start_secondary+0x1f7/0x270 > [ 821.888966] [] ? start_cpu+0x5/0x14 > > This is obviously undesirable. One way to bodge the issue would be to > ignore VCPU_SSHOTTMR_future, but that's a deliberate breakage of the > hypercall ABI. > > Instead lower the contention in the lock by doing the recalculation > with the lock in read mode. This is safe because only the flags/type > are changed, there's no PTE mfn change in the AMD recalculation logic. > The Intel (EPT) case is likely more complicated, as superpage > splitting for diverging EMT values must be done with the p2m lock in > taken in write mode. > > Signed-off-by: Roger Pau Monné > --- > I'm unsure whether such modification is fully safe: I think changing > the flags/type should be fine: the PTE write is performed using > safwrite_p2m_entry() which must be atomic (as the guest is still > running and accessing the page tables). I'm slightly worried about > all PTE readers not using atomic accesses to do so (ie: pointer > returned by p2m_find_entry() should be read atomicallly), and code > assuming that a gfn type cannot change while holding the p2m lock in > read mode. Coming back to this: Yes, I think reads (at least the ones in do_recalc() which can now be done in parallel) will need to be tightened if this is a road we want to follow. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 15:39:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 15:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517522.802969 (Exim 4.92) (envelope-from ) id 1pjMH4-0000Cf-9P; Mon, 03 Apr 2023 15:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517522.802969; Mon, 03 Apr 2023 15:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMH4-0000CY-5b; Mon, 03 Apr 2023 15:39:14 +0000 Received: by outflank-mailman (input) for mailman id 517522; Mon, 03 Apr 2023 15:39:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMH2-0000CO-R4 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 15:39:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaac4a50-d235-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 17:39:07 +0200 (CEST) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 11:39:05 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6451.namprd03.prod.outlook.com (2603:10b6:806:1c2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Mon, 3 Apr 2023 15:39:02 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 15:39:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaac4a50-d235-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680536348; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=TJSScj+YE23rouMUnkriZyhGcby3yNfMK2DU1gUCJ1g=; b=cNZzINFWJkz1LDra47OnhGPEfaRBOHUINB8+XwMNoebaR7G8GjdVp8fd 1EzwppEFGVxHXrq1cJIfLjtBN2qp6oP0AcvxFG+uFfzzmLy2Ac4AIZjAM 87HobsU5AjqSwyXwPrSyqKfQrU8LIrs/M78vqiyt5n0kA/afrknfJ4LXr 8=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 104555290 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NiGY1qqicGihICXy111aXZKb5DBeBmI+ZBIvgKrLsJaIsI4StFCzt garIBmAOv6Ja2WmKtpzPdi+808A7MTTztJmQQY5+y5nECgS9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzyJNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACADdhmBid+p+ZGcdNB83e8FF+fIDapK7xmMzRmBZRonabbqZvyToPR/hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jearaYWIEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdpOSeDlrK8y6LGV7koPD0YwdUaCneGWpnLufcJ8A X0X3QN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsSAIE55zop9g1hxeWF9J7Svfq05vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:BLE14KEdxIFUGe1gpLqEKMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT4FOTOfeIHI/p/zciTPId+rJwrO8gd2VbTG19QYQceloAZsQkDuQEmygYypLrJEtP+tDKH KbjPA3wQZJKRwsH72G7mBuZZm6m+H2 X-IronPort-AV: E=Sophos;i="5.98,315,1673931600"; d="scan'208";a="104555290" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q49pNWpv+VT7Gzrwq5lev7rcI8DZXndkMrhV0q0sNM5Ij4ygMI8avG3L0O1E1kg1gTBdt/rwJH1r6crwDZTKnE7pwgYdQp0d0XGL4Sk6VPhy4UK8chnoYZ2OaIKiFzxKRprL1k5N70ojrtGzXca22zKXhLCExVpWOgyJzWleQGhSMdUn2v3Vu6b8c6bdbU4vliIL3TXDFUV5oSv30JvafqJwNczCLp4YKo4Ul9u0pAgMwbHN7rLZXJjuYkL7sHBH/BglfZFcqBxTYxPeaNoXsBNrqoXeQRM+nv79k2LSqxTtulUM18A/EeVPPm/42zL3vYGfCRD/QSeXfQqy/1dl7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eMoA0HbVGxqEhBwVsdwSPwO02be0FeKEZK3UFGRXJsY=; b=HYrrU+6IzxuzIphui2P1kCAl+onAl9SOhBStcOLrVBHwkKOMqSCa3ayHfaj4SMn4Tt5gENsWNtfolTzvsv5jCfMsiWuGcuHz4ZSAHjCWrzeouFI3hE+viLYbu+c/nQ9vtUgz7J3lcKyUvNocabAvm2l/B6eHzXVZ/so+tZOUBvJrW8klkPRBMJneLEXEvYYCB0jp5ISymrdSJ0n91PYcKABGS6LxnN+p8buzz8Jc9bvxYHpabq8F2sb6Y/2OCfUYljCcZ+bUmB5PZMnOp7fSnfViWe80+OgOCzdUjPFoerMhOxD0J6H1NsUS1fG+JtJu3owOV++MB8FJrlWd+tkLFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eMoA0HbVGxqEhBwVsdwSPwO02be0FeKEZK3UFGRXJsY=; b=PPzhaNi2uYgHAusErCqvkdUVvut4o16rIuj+fTyVyS05Kgznm8N3h1842V92kS31tEeeey0rLAwN0rmEzg+yev4onwyLmA0yk/HwUSi1+fEttbBy1QrRHgoDGe9+TNw07+bMQzjJUGUb8y2Jy4jW4/i2i54NZDJjIFbemjRh17A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 17:38:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Message-ID: References: <20230403101449.93323-1-roger.pau@citrix.com> <0adcb388-d2a9-e43e-ec20-de1df51f33d7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0adcb388-d2a9-e43e-ec20-de1df51f33d7@suse.com> X-ClientProxiedBy: LO4P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::11) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6451:EE_ X-MS-Office365-Filtering-Correlation-Id: 950c5119-e7c4-4b50-8036-08db34598c81 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4jv7sqOmRVFOn+PMG1efJRVL85AIxHhQ1VPsfaJE3x3C71eFh/CRXkH/J8OVwe3LZshOL30LOX+b9GkmGxN6Rjij5HDnkQpFCEco2l2YbxPn3dplzv05O0KHRMWPd0Aa+/+m9gsFNrcfElgbvWfow5xybNwMoG/lVsiyHJjnI3slvJhr6swf4aAu4i5S80v/pQqc9Tj9hxsD06sFp9nXKUlSBakE6SUzLeC7tPClWX4Wm3KT00/JPV0WmKVI7FhMDMhNazAOxwPk/FsRoGhClVbI/4wU5ul+q3cLVFYxa/e+7Dm2wgoyuLc45+72foPfN4kQLZoIWiy0wORiR/ID9aEhj2wlZRk4L9kN5DfXBGpkbSYz9SUYjvst/B7RwdjKNeKmDbgy4GWy2MVb38MsFVJF+eGE1arL5KSHIsQHL2Fw/55cX8pUAJfIkkbbJMoJ64KX7G6dJ8WbDmkg7dSb2QU1irbnRPf+7jgrqmztcHob8mvMFmpuXnq5ULrl9hXKsbhj6FlCf8VEqGF2EGhcb476by97kAYGyuXrae+pQFXGw5kvKhSCyPh/U/ENlrse X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199021)(41300700001)(4326008)(8936002)(6916009)(33716001)(82960400001)(26005)(316002)(5660300002)(86362001)(38100700002)(66899021)(54906003)(66946007)(66476007)(8676002)(66556008)(478600001)(2906002)(83380400001)(6486002)(186003)(6666004)(6506007)(9686003)(6512007)(53546011)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDYrWk1VTEJnSTMzd2g2Vlp5RWh4VUxpQ2Qza0NYYUtrTFoxbWppcVJGVHZr?= =?utf-8?B?OHo3SC9rT1d2cHNMQTFaTVlyUXpZbm05MHY3ZmtOL0xwOEFnTHFzaURiUUtH?= =?utf-8?B?NXIzdjVGeDlieXdJZWdCOXBrdW5PNVI4d2kyaHg2UURWMlRtc3dudkF0c3pO?= =?utf-8?B?c084L3FxbDU2eU1iUTlRNnpOaU5FNG1Lbk5NU3dxbllucUZxQ2habGVvaXpa?= =?utf-8?B?YXhGOW5yQmIwZlB0Vm5iMSsxbWlUNE9sZnhUYXBQTENZSWtRdDVwanNIMkgr?= =?utf-8?B?bk5Sdy9rclhBZjloSnY1aC9zNS8ycG0yYVZIdERacmRNdTZTRkpIcHRpR3hr?= =?utf-8?B?LzdmZklHck1nWUwwWFBaUWF0cllrdEpNWHdXaENYUE40TzA4MGx3OFlTQTU2?= =?utf-8?B?V3cvajQ1SEJldE9XOWUxb0k2cTRJZklMZDVMTDBiY0NhQzVsc0FyY0o5d2VC?= =?utf-8?B?Y2YwYmtLc2FQbGNlejRKOVgxUHpQYlBOamFVbTNaL1dRZXJ3MlFJUzB3RUlY?= =?utf-8?B?SlFqYndMM3dzQTNjWEY0bjFNK0tzZzhndWd6TFg2Y1pXNlJnanp2dHNIVDg4?= =?utf-8?B?Ti9iU3lBa0lGVWY1blRFeGlrbThXZ1oyeENwaFpEcjF3cEtMY1orS3dYTGpv?= =?utf-8?B?OXIxT2JzbC9LZWdHd2lKUk43amc1d00xQ2JDdkNhaWlHSXNuaklmSEovVFR0?= =?utf-8?B?QlRzaWVQK1VtcnpENEtHQmtNUVpibEIrdXp0SkR6d05pUXBYRC8rVnNwOEhT?= =?utf-8?B?azFuVzJwZmM5SnVtQlM4aEFFQ0tLN1NTOXJ2MXNHQjcySkNFVzZ6c1JFK0Yv?= =?utf-8?B?M2pUdnVmbUtwWjQ1MFFFVjRpL0U4SlFmVjkrY2JobkEwMlJzeGRZRHR0cGh1?= =?utf-8?B?YXVkOTMybHlYOXVQQlRLMXBWT0NaV2RsV3BPdVpCVmdpemNJRjV5ekJTV1lL?= =?utf-8?B?L1A3Y3hQSEl3c0RHeWFkZy8ybjgxK3NjWkdIWnRFR2ViS2s2QXZrTW0xcVl2?= =?utf-8?B?MEw3VTFOOXVSWWJId3J3R0tLTloyandwNzBXNEVjdDdvOUExREpUeFhtTkh4?= =?utf-8?B?c2dFeVc3eHVNYlNZRkwrNVJzelIvMzNTY1NvTGV0Z0cySWFwVVR3V0tVVk1W?= =?utf-8?B?cDlrWVl1VGJwZ3JGT3B4dElQYTRDRzZhbVBmWE81ZE1Qd0w1Tnl6czVnenhr?= =?utf-8?B?U0RMTmFHZlJFNUNlVjQ4SUZ2VXpnclBmU1ZnWkozTllTbXlsMmNabWN3MUhz?= =?utf-8?B?TmJndHMwZURDNHIrbGF0eXNoaUFNQ3AzOGNHS2JUUDFDaDdtbHNzTktaOTJ2?= =?utf-8?B?RGhEVFRreDJmMEpzWTFQWTJyM0swMTZSNWNla0tYTUwwMTM3Y0JYMW9JVG1s?= =?utf-8?B?Y3Y5VUJFL2toN1ZUcnNacitDVENESEZxTFFFN2h4Y2VKNTZEY01YNVVjczFH?= =?utf-8?B?ckdCT3EyUEVlbjQzMUZnR2V4Nittdk1CV1h5TTNHWVYvenBMOWdRNmtSelNF?= =?utf-8?B?eXNIMHNtYUZFR1pWczhGZlFldnNXWVp4V0VqRGg5cDUwV0dqbXNGUE9wUkd4?= =?utf-8?B?ZjR4M1hhN05BL08rVS9SUHR6MDRxMTZMdkk5Q0l3RzVEcEFaam9EUFdqajBK?= =?utf-8?B?MGRJOEZ2RW9RN0J3eXlIa283VC9rZG84a2NocFRiSkVkVU9uQUpTc1RpdVdD?= =?utf-8?B?L3YvSmg3dXR4K2NnTER3Q0piRDdJcjN3TjZNL2ZQa2N1UW9WT25Pd01INEcx?= =?utf-8?B?LzlCUmxROEY5RnRuWTFLa3A3ZTRDbFJXKzNrTW5zdnZ0R3lsWHUwTFBTZmhC?= =?utf-8?B?Q09jOVhMN3NLT0MrOUtFRFZBd2pDRG1tYUZyaE5qUmJnQ3c2bUd3UTZLUmFk?= =?utf-8?B?M0RwUVhVOHpJRDR2Y0V6a09nYkxxZVlPSjluM1IvQzc4ZVRlZVVtS1BJTVJk?= =?utf-8?B?TEdRRnJLeXo5WGxnRnlPZ1d3L0xTaHNrVERieVRGWFhWQWJvWkpLcHI3dDVw?= =?utf-8?B?RVNPSlBqS2pPY29PVFhmQy9XZWxrcGZpenBZWDVPeUk4MXZFQmRFczg1Vy9X?= =?utf-8?B?blJiUzNpNjVmRjcwYWxCRng5aTBtTksyVk95YW5ZMUlOK0QwWEJEb2YzcVhF?= =?utf-8?Q?eMIZhSddkClRvbGY8N9FGWJnp?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +PB7tguXWrxsznNO+pEzjro8ARwAH/aQG2iq2bW9fJ0Y//98Syqh5VcO/TGVUUGJ+YtvUCjJMLFWrHi8RABbwItqF5uiYN4Pf94CAoHB5KxlwrkBCvBXx7lrc7frzQ3Zmq3GRXAe21dyXr9n//6hXo+hZEPd3sSmDzYdv7U/iy/DiZNVMYbidozQLKoKZKvwY3iuAZR2bLVmwJSsYUHTTIv9x94xvatCrtdQpjWSMVlZc9Q6TsrkME4QbKkt7nH2rksBO6VaGIuEYzGcjZn6e5ubW4hdXh/Z1LMbXlxdDAfoF3wh0nTmi7tHAcyJyA2Fz1eHd2axKv4FFzhycFlOVJybNPeW7IkZp/m6zAf7tgDp8iNK/+IJ7kbszuvohZKGCbKFL5r2VQOJRxOVid+nzcDQArALarRLdZaOoeSD2WlXpHcc3e7eLGSMNk11vKWfvZU9z4NXpWh630hAKlgxct1Rk7t1ByoCuQNDPB1l8XmwRRuXy6NqJEjNt8xgKVM/gXvlFA4yP3kEEXLpvDx6NBEo8uispZJdOHFbwLBZXYZzs7Sin9TpxVRKz7jN92M+KUd2DRY9zNShVXbIArcJoyjFknaAmTOJzt1SChmXVlDlcFysAY1nKqyIQCR58U0mNYG6xMjbR/1eME5f+IC/7SlwLg1/N73CL1Z9ERNERzaf/wTNq2PT0Y4Y7NSU74DcAcjnWzaROWbisc2+q/ofLXUDkBNjhCXfUXdNEzGmcgCClLqPQkyh024VfqTW2yCbgcepYMRF6fZAJAxbs4lBxYYKQLJlm3elVKg38tTu3hge6kIGhdWKUucR7mXPZbqC X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 950c5119-e7c4-4b50-8036-08db34598c81 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:39:01.9891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CbzQ85k2Qh9uVXirGRUdMoxvxkLOgKWRnV9Tc1+RIRQnIvedtZlU715khrXvZQt9eBA79XvRCjU66k5mj3sU+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6451 On Mon, Apr 03, 2023 at 05:32:39PM +0200, Jan Beulich wrote: > On 03.04.2023 12:14, Roger Pau Monne wrote: > > Global p2m type recalculations (as triggered by logdirty) can create > > so much contention on the p2m lock that simple guest operations like > > VCPUOP_set_singleshot_timer on guests with a high amount of vCPUs (32) > > will cease to work in a timely manner, up to the point that Linux > > kernel versions that sill use the VCPU_SSHOTTMR_future flag with the > > singleshot timer will cease to work: > > > > [ 82.779470] CE: xen increased min_delta_ns to 1000000 nsec > > [ 82.793075] CE: Reprogramming failure. Giving up > > [ 82.779470] CE: Reprogramming failure. Giving up > > [ 82.821864] CE: xen increased min_delta_ns to 506250 nsec > > [ 82.821864] CE: xen increased min_delta_ns to 759375 nsec > > [ 82.821864] CE: xen increased min_delta_ns to 1000000 nsec > > [ 82.821864] CE: Reprogramming failure. Giving up > > [ 82.856256] CE: Reprogramming failure. Giving up > > [ 84.566279] CE: Reprogramming failure. Giving up > > [ 84.649493] Freezing user space processes ... > > [ 130.604032] INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) > > [ 130.604032] Task dump for CPU 14: > > [ 130.604032] swapper/14 R running task 0 0 1 0x00000000 > > [ 130.604032] Call Trace: > > [ 130.604032] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > > [ 130.604032] [] ? default_idle+0x1e/0xd0 > > [ 130.604032] [] ? arch_cpu_idle+0x20/0xc0 > > [ 130.604032] [] ? cpu_startup_entry+0x14a/0x1e0 > > [ 130.604032] [] ? start_secondary+0x1f7/0x270 > > [ 130.604032] [] ? start_cpu+0x5/0x14 > > [ 549.654536] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) > > [ 549.655463] Task dump for CPU 26: > > [ 549.655463] swapper/26 R running task 0 0 1 0x00000000 > > [ 549.655463] Call Trace: > > [ 549.655463] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > > [ 549.655463] [] ? default_idle+0x1e/0xd0 > > [ 549.655463] [] ? arch_cpu_idle+0x20/0xc0 > > [ 549.655463] [] ? cpu_startup_entry+0x14a/0x1e0 > > [ 549.655463] [] ? start_secondary+0x1f7/0x270 > > [ 549.655463] [] ? start_cpu+0x5/0x14 > > [ 821.888478] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) > > [ 821.888596] Task dump for CPU 26: > > [ 821.888622] swapper/26 R running task 0 0 1 0x00000000 > > [ 821.888677] Call Trace: > > [ 821.888712] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > > [ 821.888771] [] ? default_idle+0x1e/0xd0 > > [ 821.888818] [] ? arch_cpu_idle+0x20/0xc0 > > [ 821.888865] [] ? cpu_startup_entry+0x14a/0x1e0 > > [ 821.888917] [] ? start_secondary+0x1f7/0x270 > > [ 821.888966] [] ? start_cpu+0x5/0x14 > > > > This is obviously undesirable. One way to bodge the issue would be to > > ignore VCPU_SSHOTTMR_future, but that's a deliberate breakage of the > > hypercall ABI. > > > > Instead lower the contention in the lock by doing the recalculation > > with the lock in read mode. This is safe because only the flags/type > > are changed, there's no PTE mfn change in the AMD recalculation logic. > > The Intel (EPT) case is likely more complicated, as superpage > > splitting for diverging EMT values must be done with the p2m lock in > > taken in write mode. > > > > Signed-off-by: Roger Pau Monné > > --- > > I'm unsure whether such modification is fully safe: I think changing > > the flags/type should be fine: the PTE write is performed using > > safwrite_p2m_entry() which must be atomic (as the guest is still > > running and accessing the page tables). I'm slightly worried about > > all PTE readers not using atomic accesses to do so (ie: pointer > > returned by p2m_find_entry() should be read atomicallly), and code > > assuming that a gfn type cannot change while holding the p2m lock in > > read mode. > > Coming back to this: Yes, I think reads (at least the ones in do_recalc() > which can now be done in parallel) will need to be tightened if this is a > road we want to follow. There are likely a lot of reads under the p2m read lock outside of do_recalc() that will ideally need to be switched to use atomic accesses also? I'm open to suggestions to other ways to get this sorted. And that's a guest with 'just' 32 vCPUs, as we go up the contention on the p2m lock during recalcs/misconfigs is going to increase massively. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 15:43:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 15:43:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517527.802979 (Exim 4.92) (envelope-from ) id 1pjMKf-0001hJ-RO; Mon, 03 Apr 2023 15:42:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517527.802979; Mon, 03 Apr 2023 15:42:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMKf-0001hC-ON; Mon, 03 Apr 2023 15:42:57 +0000 Received: by outflank-mailman (input) for mailman id 517527; Mon, 03 Apr 2023 15:42:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMKe-0001h4-NC for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 15:42:56 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 324d790a-d236-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 17:42:55 +0200 (CEST) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Apr 2023 11:42:51 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6451.namprd03.prod.outlook.com (2603:10b6:806:1c2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Mon, 3 Apr 2023 15:42:49 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Mon, 3 Apr 2023 15:42:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 324d790a-d236-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680536575; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=cChx0o5A6ihLKB0t4My2IL0j6fZQVRc+OjMz0/qhwpw=; b=JeMOsYKwn9K0ausFtgKOGnCXYicNJHPEIXmzMsQJNAfWJMcnCurpsFqY 1isuyFtt6yU+biNEvunTynwTUmNQ/TICl4Gl9E+H1vjc1qsCe62+8yaAp 8gT/V1g5iBNdTIcfHk8My4qw3IWHabkgXsQppDzLhVF+JJ+BFCS7+KaJ3 c=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 104555926 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9F6dDqOe06JvaVzvrR2DlsFynXyQoLVcMsEvi/4bfWQNrUoihTQGn DQcWDzVPv/fazTzKtFya962phxQ6J/czoMwGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rh5JTFr1 sY1ExJOXimBrfyY2pefa+Y506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujeIpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyrw27KSzHmlMG4UPIPh0fVP2kyW/Go4KE0Nf0qBn9v6r0HrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/I+wBGAzOzT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+pQSiaPCEUKSoJYnYCRA5cut37+ths1VTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPuZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:bxvKQqpWeu/ob/KOw+k0SfQaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.98,315,1673931600"; d="scan'208";a="104555926" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJQQkdjP0C6CNvu1vXY5tc9Prfzh1TH2o33xtHDOrhsaaBajTxU5F82wsMJVu//yVJClo7njpoo1S2/UwFe8bqYxANvmIJAoOJkcWzPF4jU78YOs32Ew7pDGtCLiSj4GxyFFZJ56MpjbvLeBicPF6TL/pxz5HHKPLAOHLRdM0m7JD96lHrRiLQHpwruNLJJHx2jHp55+OY1ysHFA/94PFAzd5AjYFqlrq+bnKLHqNv2Mj3JITydirMstJp/kBydUZUQJLGnYtTYKuf0pPyt2K4qyC58t2RuHVEK6d0DNwxLBqEFvrlWqSQj/0ZPo3P4sa6OIPANl2jVrCw5z1xl5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NFq82okmVOxlJdIrhlenhySNz73COmJ8btmugVasD6Q=; b=QiTbQtcQ8uILdiIkU7DgC71hPhl8skOam18jXFneve6EYA9+cbQeCbXfnW+GOJFcbi/Seb0CbGQezxFDJXDVCnTecECxbM1adyPg2bsgRb1aowQrExCDs7jonbPygeYK4ZbAD1mExvcS0DHiSMZQiH5o9yay49d7NALZ066AIOkbOrRChIKN9o12fSawRfqffi8j428bX8AHbsjf2hBRzwm6VeFCNYUf7ZN0hLBcZ5Xi62O2NtDg5alsImWO3dl5XrQCLA/BnFzFWvEk+ZuvF1C7cgaSXsJj+nAE4AvqyJQNudBxZDnYXyDeG68fhqBTNJSBlZdsmeQlTSjroVB2AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFq82okmVOxlJdIrhlenhySNz73COmJ8btmugVasD6Q=; b=ZSs4yxRWK6gauK0Dqq+7WX2gLMBEj1fN5J4kUcpKdUQ4qPfjJUsPcp4b6jIjkFUre2K5f4mdaR8YVMXG21d0qLJqwg8/FWnIJXUWtI7pSS09pYfDhPQC664NpemTpRSDnFRUu9KchkfDCJmJ2cZK3czluvcb9GlDYEEL/z50ndI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Apr 2023 17:42:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Message-ID: References: <20230403101449.93323-1-roger.pau@citrix.com> <8d976d34-8a1e-95ad-3bc9-3cb704c1fae7@suse.com> <5fc00c1a-11ea-905e-49eb-d70caaf71041@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5fc00c1a-11ea-905e-49eb-d70caaf71041@suse.com> X-ClientProxiedBy: LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::27) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6451:EE_ X-MS-Office365-Filtering-Correlation-Id: e22b7550-ec20-4828-d277-08db345a13c3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KxxinPzUXSqjEuC76OGZL6FAFFvaBFMpu6qvp20IK5pyPUbdzZ5/UWXsZYhOjutGqSvtuJZLtisIZ1RtLXuQ2psY+Ee5iwaeukG3dtpAVEuMEfh8kdhFmJKna+uQ0xw/9DldsHO09lYnVEDZmBy+5elRFm0MFOQVkrgSTI+9iBz+k4MoK1dI1moWNr9zDSIbuih38T30+4pLxk81Bue6KB3cbtuiBSyvIV/5wP5YOaxFdCeKIsTR2MvFK1AT662sqayV5WyKLWi3pNK35O1EZv/vKYf2jnmv7IRfm2XQGUJ7DKEogRSzbJEKddnP3dVZR5gGt/6wcp+AtFVs3BjJTTm9A4JsaIO93lSx/8fuis1xY2JZHyieS/EP/5BEcezOH5xJ0dvUFmgKyxu9T2Cox7ZXJMLE5djAjpn3dmQg2Y3BvnTwthZ2uV/EO3eKofuAIlqIJOp6gkg6VD2TBrq1s+xaoW9psy5aLxYSVcpvdsTS59RjWYcCyJYbYulqktlEd+PL80BGl2los0BKua2eQahJ7fMLZVe/L0x2PeDqmBXPmXyMxRo0TJVHJ9RiR4iV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199021)(41300700001)(4326008)(8936002)(6916009)(33716001)(82960400001)(26005)(316002)(5660300002)(86362001)(38100700002)(54906003)(66946007)(66476007)(8676002)(66556008)(478600001)(2906002)(83380400001)(6486002)(186003)(6666004)(6506007)(9686003)(6512007)(53546011)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGNUNjVmZTRsM091d0VzdENuRjFWaWhCejBxOHZhSExVeTFMUDcyR3NQakFw?= =?utf-8?B?WUhldVVkZCtLaEFSRGg0WEwxd0VVQnE2cTF1dWxIODRsN1FNQTV1S3FpdEJR?= =?utf-8?B?THQrVzlBaU5IVXNyS3BsUkZ0MUw2Tk81WFU4Uys4cERWS2xFOUc4V3VwSGty?= =?utf-8?B?WDI0VW0yb2FBZ2RDNUc0K2dBVzdrRVdZc0RiUGhYS29RT01GVURQUTc2UEZR?= =?utf-8?B?UXc4RHcraTVIelJJOVR0NGdKL04xMUEybzZiT1NZc1NaRUV5ZjBhV3JjbnZW?= =?utf-8?B?MWpiWUFuVWE1VCtiRlhwQXkwNmdiS3pDZXhjLzA2d2NMcjhFY1p4MXFGYmFQ?= =?utf-8?B?OUZjZlpsUFhZUUpwUUlHeGNBeHdhTkFwc2RYdVFLVFQrd2dPeUZnai8yNzRx?= =?utf-8?B?K2RJVWJzNmtoT3NBSk5hZnpGYWVjZWhiZzB2K3QyMFF4N1RLUFh0SGpERTY2?= =?utf-8?B?bnl0MFNrbVgweURTa2Z6WkVZNE9yYzEyeTI5NERZRFJlcUo2RldFN3I5K1lk?= =?utf-8?B?V09ZK3FETkttVDl4bDg0NjZjeWhGSURrb1dmNkF3d2tESGVadTRDTVpEck1H?= =?utf-8?B?M2dKOTlpOXM2QzZOSTN3ZXowY2t6TVVqVVJGYkZML2MwOGhiWnhDandrSXFS?= =?utf-8?B?YUlSUzZ3WG5sb0Q0aGROQzJyN3cxM1FyMnZJRGZMV1FKOFRrWnhlNTZUVmxB?= =?utf-8?B?SWQ1QzBTbzczVHE2RmgzSXZSbGdGVjhpd1R5NDlGRCs3ODRxRjlpVHhkZU5n?= =?utf-8?B?TnBRQ2k3dU9JcHl0SmdmejdQKzMrcHVLVlA2YUNyMzV4YnNDWWRMOVUrTXYr?= =?utf-8?B?cTVYWjBTR0RKZzNqYXptV1IxN2lFK0pnYXlpelozeE1FamRDVmx4NG8zRmZ2?= =?utf-8?B?amNBWWhuZWt4amR6OUlGTTJHQXJqZ3NLQURNSVh2K2tGUGhvQXZ3MldodEc2?= =?utf-8?B?QnZ0Vk1EeGtneHpzR1dOYVJZb3BhdkkwamRpd2hleFJnYU1sOW9qRE5sSEpQ?= =?utf-8?B?T3NGZzJ4aE4xM1o1Qlp4QWdET2hxLytQRUI3UFdkZWpTRk8yR3RDQVZ1aVRk?= =?utf-8?B?SE9HYlZ1NXFlN2VhL0p1OGRCb20wUC9DTkFzMnVwNGl1cHJHZkhoYVdsUDdJ?= =?utf-8?B?QTJJYUJHWndGbGUzdmVTOGlFdnp6dEoybFN4NmdlUzRWZlA2ZEZwS21xOWlU?= =?utf-8?B?SHpLM25EL0xHOG9tQ0dYU1dRS2Znd1Z2WmFaRDZlNkFQbVE5aVR6dHJrN3Iw?= =?utf-8?B?ZXZ1dWtaVFIyS2NmeThEc0FEd25OLzRLSzlzQ1o5VGpjelJ2MkcyTzB2ZTZO?= =?utf-8?B?WnBFNDRHeUM1bzAxNWE3T2V0Q05oZWNHS1UxVU4yMW54ekkvaTZncUMyVWcz?= =?utf-8?B?TFhzRkwraGF4WXZhZFByRXFzRXk2cHVFMHhDV3JLM3NTeVFUQTVvOVp4Wm9q?= =?utf-8?B?WS9xMldIa2JIWnNVMDFGUStPUC9BV2FiVUM5REFJd0VTMkE4REsrV1FwNnRq?= =?utf-8?B?VnRXSi9TelZrZVpRcGg2Tk9HRDBuRWpYNlByL1REbUY0cjQ0Zk9EQXdma0Nk?= =?utf-8?B?a3RpczZtdWEyS1JWaDFSWEdmWUtlekk0bStTcUxJaDU2aWQyUHdpeTJnd0F1?= =?utf-8?B?d1Q0dFdpcllHajdTaVBjMHd3Mnh6R3R0MVBhcDd1ZTdiakoyT1Y3STZQYVl6?= =?utf-8?B?TjVCRkh2S2pTMHBOUjhBcnRmZWc0emNtTTFXT09jZGpsa1RNb3ZiZitoSW9j?= =?utf-8?B?UmtwZWFDL3lrczJ5NDg4YzI1RFF0R1JqRjJTNkgzL21ma2g4R200eHMyZmxH?= =?utf-8?B?VWFLN2xWM2RtWHZpY1V3NXFJZTlXTENiNEZxNE8yZm1OblB6Y0ZsRUJGYU1j?= =?utf-8?B?cFlTc25weWVaZklJd0hnZ0cvajRSWmhpUDkzRzc3UlBIUmYydWtydUpnaU1L?= =?utf-8?B?UzZhS2NjZWVaSlNwMEUxV1VmV2w4TW15bzNsK21rK1RMOXdITzNSUUx2cG44?= =?utf-8?B?eWNONmlmRk02OWJmdGYyS2M2aU9pdmRRZ0hGSncwVGNaN0hXY2VQelBrV3lV?= =?utf-8?B?WDNXQ25PTXo0cGEvWGZoOGIyQk5kY1dQY1M2VTQ3SFVnRmFxbUZjQS9DbDVh?= =?utf-8?B?RUUxd1pUT1Q5eEszSkVzSzZOci9mVlIzc1NYTnNxemZOdCtqNDVxQlhPQkZG?= =?utf-8?B?R2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OkVL0yPGPTneFK7N0QYEdvgmeRNuVCM5aZJ3AyRHCZpiZZloIvzJzM0QCNHJ2BF1lsSgjoYyWFePpfKFqJkpa9KVzKnuq1RpikHjySyEOQz+t1UFNLg6fDxR6NOcLaB4ZdNyaSGkSbkbIrlmtDTGNFIOLKagGTNjxpTfs2dpjtZGF55qN+mNKM6NxDhWb8LWrwado9+Re535V2J0BDV89ojqx3nWOdFh9220sIvChhq5vbXHSLlbp35BzfsZbX5g5h+FXANO5guOQPUqdhKCPKK0gqAVHpGitO6ZrNpxWF8PAI30gLn5H8oGxzJIKGdM6R3T+NLf9hz/hahL5tthu9ZpBryPUasN0lgwloyVmwpqVdWXEE8jMRgOBwoqr5v85HT/2qNWEozJNoGfbGUrvL8svdFWxmsFNBNjLEiQ7L2SqTa1FjVMX8QYMlNYNq8K0piOIWM+XWozTxDJWw+IQ92d/mhZwMxizJX3mBPXnl6HroJw4hwtxGMSzsOqiHdG+d+uNobi+enqCHyd1A2trSRi3z14tEqK/LYF/8/hXlRl235eZXMPHeulkZ6RANQg1RXkZvdWP8vcVANK9McCePFJEVifs7Xzhqy9LcbEF0rc55ymmljg/AMBlzpZsCy9PTb3fNkNVRTQH6yFB8XdHYfAKNuM78MNxXQVF46gfXXrwf0EO6Z3T0GHAcfUvedziFkSercDxS0/SwOMRn6hdNkQtM+71Gldc8f690qEqfDFucwf9H04gkqRovQ76ET7shjCTkSWxZ9U/IcWzXhOG3LdKIfO1mh1B6InnT+hUZ+cgMDMnktxbMW/4AJjFVzd X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e22b7550-ec20-4828-d277-08db345a13c3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:42:48.8089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uRSk4ZxCuQuAGy9bTYrPotnMIvsZCAZztTLkllVaZ64sHvKpZjDtxx37y1TC7/FdbogQj3oJoWH6I7q4q1w4Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6451 On Mon, Apr 03, 2023 at 05:30:37PM +0200, Jan Beulich wrote: > On 03.04.2023 16:27, Roger Pau Monné wrote: > > On Mon, Apr 03, 2023 at 02:39:08PM +0200, Jan Beulich wrote: > >> On 03.04.2023 12:14, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/mm/p2m-pt.c > >>> +++ b/xen/arch/x86/mm/p2m-pt.c > >>> @@ -486,9 +486,6 @@ static int cf_check do_recalc(struct p2m_domain *p2m, unsigned long gfn) > >>> p2m_type_t ot, nt; > >>> unsigned long mask = ~0UL << (level * PAGETABLE_ORDER); > >>> > >>> - if ( !valid_recalc(l1, e) ) > >>> - P2M_DEBUG("bogus recalc leaf at d%d:%lx:%u\n", > >>> - p2m->domain->domain_id, gfn, level); > >>> ot = p2m_flags_to_type(l1e_get_flags(e)); > >>> nt = p2m_recalc_type_range(true, ot, p2m, gfn & mask, gfn | ~mask); > >>> if ( nt != ot ) > >> > >> I'm afraid I neither understand why you make this change, nor why you > >> then leave the other use of valid_recalc() in place. > > > > The message can be bogus if we allow concurrent do_recalc(), and I > > did miss the previous one. > > > > I missed the one at the top. Originally I wanted to send the RFC with > > just changing the lock to read mode, but then I though I might as > > well fix that (now bogus) print message. > > > >>> @@ -538,9 +535,9 @@ int p2m_pt_handle_deferred_changes(uint64_t gpa) > >>> */ > >>> ASSERT(!altp2m_active(current->domain)); > >>> > >>> - p2m_lock(p2m); > >>> + p2m_read_lock(p2m); > >>> rc = do_recalc(p2m, PFN_DOWN(gpa)); > >>> - p2m_unlock(p2m); > >>> + p2m_read_unlock(p2m); > >>> > >>> return rc; > >>> } > >> > >> How can this be safe, when do_recalc() involves p2m_next_level(), which > >> may install new (intermediate) page tables? > > > > Oh, great, didn't realize it was capable of doing so, it's more hidden > > than in the EPT case. Seems like this will only happen if a superpage > > needs to be split because a lower order frame is being used as an > > ioreq server page. > > > > Do you think it would be safe to try to attempt to perform the recalc > > with the read lock only and fallback to the write lock if there's a > > need to call p2m_next_level()? > > Yes, that ought to be okay. > > > Do you agree it might be possible to do the recalc with just the read > > lock if it's updating of PTE type / recalc flags only? > > Technically this looks to be possible, yes. Question is whether we do > ourselves much good by introducing such a special case of permitting > a certain kind of writes with the lock only held in read mode. The > latest when we find a second (more or less similar) use case thing > are likely to become difficult. Yes, it's not very nice. I'm open to suggestions of other ways to remove some of the contention. If we go down this route it would need to be clearly documented. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Apr 03 16:07:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 16:07:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517531.802988 (Exim 4.92) (envelope-from ) id 1pjMiT-0004pI-Nk; Mon, 03 Apr 2023 16:07:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517531.802988; Mon, 03 Apr 2023 16:07:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMiT-0004pB-Kh; Mon, 03 Apr 2023 16:07:33 +0000 Received: by outflank-mailman (input) for mailman id 517531; Mon, 03 Apr 2023 16:07:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjMiS-0004p3-Nb for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 16:07:32 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20627.outbound.protection.outlook.com [2a01:111:f400:fe12::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a26a9d1e-d239-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 18:07:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8057.eurprd04.prod.outlook.com (2603:10a6:10:1f1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 16:07:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 16:07:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a26a9d1e-d239-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDMt1tSrxjGq3q3pB8tz78oVfOG/z9nxrspygX84sXw0kP/+vogkYAMOgB4AE5cFa7fvJpUuzYVXFfv5lTcEWJBFeqt6g/dCS0h7KH4aYCyzDd37zDOhZNlzmpL9IBdca0b8UVRzaze6JXQiruRIdPpMvW5DI++/ABKsBcQXzpdHo5j4yUAS+borJ+/RxJZyaJXlGoPOg5LEaPLzrei8YqQKgzJJuoN0FfNWqbwnSCwwMv6xZ17/p2g9/jLXc1ZLY17N4Xvt43KTwstcwt8wqE4vNubydeiIvFJ5J4+79rHMlCsgjJ53LfQbFdXKQGLWxHgZHGXOaL+edgETpmHoqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TQxMB6GjtobwvO42jbp5xpY3uI30G7RbMn/5g4WZk/M=; b=aesZRDui6IDoUJ7dwLG5qhRHh3QfOwzDSUEPxT+aXxKg+FWORlriJzD+9bQMXxDMAbXWG/EAgemI7ApME7ra+3ifxyVTMMa2iJjGysF6wMcVNN375kOjEyx0d5taczYF91hBlvMzTDYSmPz0UdvcN4JAQlS0y+WR9b0jzPHUB9DzjoIrDE5mAvQ8DD43huGlXdqPOKr/F7b1hZ8ZNEqhoMts291JthV1Qdrx8hbCJbz7qli/NLkjnQesx2NTGKUiMC0RwTcf72k/kNB4JCRjCiSPZ4YlF1toMMtPV47Fyrj97M3MemB3QDDE9aZqUKL3wuAvSw1dz+L/RPkEGyCPBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TQxMB6GjtobwvO42jbp5xpY3uI30G7RbMn/5g4WZk/M=; b=Y5xGij3RTmGX/SmzUNk+96YBCSzTwgIIpT/SP01q3zR2KRIZ0X6NjARxIajjJXqXg0BVh05afIyBer7qExokq9CSHBkb0N75wQUNc71qjB8D+yf1e4pjLs6GXXRb50sXcOafXUoElIx7wVPee7y0MdHHKJO+1xricy2vqFQs6X6JKBWKmlLr+XiEWXrgnAjP8VDx2leoNI/nMcdjeBh0kVpU7ipLy3n3klTaFPc17Chk+f9len9I63Sq7xXGnFWPiEsbILFIw7rZK2NQlhwmPMpe/zP7EkVq6LER33q2z9gIzOsXKkg+envZ79c8fcngbZkwUuU9jXzU0OAlVCi+YA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 3 Apr 2023 18:07:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230403101449.93323-1-roger.pau@citrix.com> <0adcb388-d2a9-e43e-ec20-de1df51f33d7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8057:EE_ X-MS-Office365-Filtering-Correlation-Id: be3aaf3e-6f7d-4270-f90c-08db345d85b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TCYiWYHnlCcQThEkq+rje5+2+F7335plpJIhPgb32k7WStzTKuRlUzSf2SrpMH8JdadYzMl02iFlIRSFeS4LuIsKJ/l67snqdANQe8CF261cNmaRugEmp2gOWSNHAwGIdrrpzbOKhHb1Vp+Peu2nQh1bN1PzgttIjbisN1o1oNRxIZRcUU5PyvcCpGJiiADHSre5fRG95Wh4HGNFkR+XY6J+9x7LtuzbvC11yq2dGuo3wLN0Jrem+x3BQNi6IHgRLw1uiRaM/Sjl21uvs2dq0704JtldTnMtlxrh1S+gPBtGqEgqWI0+HH7UCtdKrFaskYSHBRwX/tBymkaBPuXIHPsKw8XDZCvtwNq41pfAQtDR0ovgGIEAt+Y+pX3rzB4NDGkoSkZABf9eKfDZx2YRl2ppwLQ8Nf51lLuJeTjwChqUnn1hCxtf63MNf3T+C74ipG01q5ntoYs+pWt3JkDgp7qn8/wJnJYnmjxW82I6pSwdRlFAVo6Tvz3gVX/a6BuoJEjxA51tKmRMG8nWmiyUxMvho5j0F52VZt+JAAOES+qQT6LpNKYdWN6Oaqfa06w2/U/TNCRnlYXQ10pN4MI+5TaCwQDNOklenqAZkekhSbxwxyqkcqjIYkGXZlXmiat98RgwD99q75kKI5ygTNYuAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199021)(186003)(66899021)(53546011)(6512007)(6506007)(26005)(31686004)(54906003)(478600001)(38100700002)(36756003)(66556008)(86362001)(66946007)(66476007)(83380400001)(8676002)(4326008)(6916009)(316002)(31696002)(2906002)(41300700001)(5660300002)(6486002)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OStQSE4wWEQySUtacURnUDI5amVPN3dOdkhRbUFSbDkrOFJYLzZWMVAycWVF?= =?utf-8?B?Mjgybi9jZFYxd3FtSW1RWTYrZVBucytIcjJoNUJSd2UreXQ4eGRTczVCNHFJ?= =?utf-8?B?RHRsSjhMSU9Od1FaSURRQzU0bjJhMlJTN2RVVHpDV3VXcHVvL2NoZjZra3Vm?= =?utf-8?B?RzhwVE1QVUM0d2dWZFI5VXdKZXhpMDFFZEZ2ZDBRVUFQWjF3WXJKZlFXSlJh?= =?utf-8?B?clc0bERlOUZNTm9vcHNTbW1sUnhCN2RERjBKMUpxNGpUa011blk2aHMvcTJP?= =?utf-8?B?bmNKZ3MxbXJnUXNYNlVCdUxkNU53ek5YWTczcGl1cm84WXgyS1dnTHZmRGMz?= =?utf-8?B?UEZJaWRadjE1Z0ovMTN4OXVNckpXdEhEM0poWGJJb2k5RUZvTk9aZ1p0cUlH?= =?utf-8?B?Z0JaaTBpOEZ4elI4WFhxM0ZmQURpSUYyemNrVmJxTXFlMkxjK3VabU82OGY3?= =?utf-8?B?VFZPNnhXeGtnR3oxN2ZHbzhhT0xvQUROVW83Q1ZrYmtaZGpTMzFBYTN0eHNN?= =?utf-8?B?RDhSVGtEV2F6MUZNamRxYStTQkhnajlVTDV4Yzk5dStRYTVyTUVxNXI3RXNB?= =?utf-8?B?amZDU0k2TWpkQ3haTXo1QnVqUUU4c1VwajFaSnpzMXlqV2xCMEE5anRNYnR3?= =?utf-8?B?T1FyU21hUUE5bi9yL3o1L0wvTkliSnducENqT0pEVmpaMnp0a1hHTzhnV0pP?= =?utf-8?B?V2ZLMUtadW9QWmpCMko2T0RaUHdtMzdFQnNBRzVuY0M2UlN3R1FzOXZIWWZp?= =?utf-8?B?YlhCdGk5RGx0Ni9sZldTMGtsZTU4dmRaem1QSk1iUjRhOVJpWGo5cXkrQ202?= =?utf-8?B?VCtxRXpVdVk4eGVuYUFrMmErSHArYVBuRVRTSFBuN2F1VW5XL3BLODI5aDlL?= =?utf-8?B?WVJMNVl2em1IbU5Kd0hKUkIzeXpTQXB3aE9YUytOUlpUcTdGbjNUN21PRVJs?= =?utf-8?B?WGxOdHFMeCtJZyswSHJHczNTWktWTmRWcnVBUEV2ak9VdFdnTFR0RXRsVFJX?= =?utf-8?B?Q1QwanpoNGo1R0Z5MHpXb2RUbkFJemxOUG4vcm00dCsvcSt5aU16VHpvQlFp?= =?utf-8?B?YVp2V1hERHdXalJiMk9HNkpISEI0bkFIUHJlUFAxai93RndEK1pCNVczSU1F?= =?utf-8?B?bHltMkhxM0doS2dDNTRJRmZYS1BWVmR0TFhMeGR4MkdKUnQ2K1FUdDZscEly?= =?utf-8?B?NEhFRm9aS0YwenkzQiswanJtSU9PekRRVFk2QnFydjNUck8vZWFPblpabmpB?= =?utf-8?B?bnlhdmxka0VybHM4ZHlBeHFRMnlRWUN5VlZzVWMwSUd6TUFVS2hVRjFyaEhp?= =?utf-8?B?TE9aN2JvKzJVdHByLzhod3R0QU9KY2xRK2NpOVFCOHZaOURaQzE3YkphYy9k?= =?utf-8?B?a2N0dldDRzh1TTBRaGJOZnVXR0ZxR2xGNVFzNjg2ZVV4dmFWUGxWcXFwY3oy?= =?utf-8?B?SXRoSGVqbDlLWVNpOUlFSlA5ZU0xWWdoUEFzZ3Z5d1k4eFMzZm10d0dZeE4v?= =?utf-8?B?aTU1MFg4aUQxS0p6VjBJRExJZGlOV3lsN3JWdXBUR29rOER4U0NZR2UxOWsz?= =?utf-8?B?azRLYnZHMXJqMGtGUGxsekRVbkhERXJucDM2WkNYSytXd296cGd5MHlDK3NL?= =?utf-8?B?Q2xTV3l6WnhneW1BVTFXWmRvTVY3Qnp6MmgxTWRPNkplT0NTZEZQMnlnZmNi?= =?utf-8?B?VCtPMTFkMGQ1RXBDV1EzdEJSU3JLeVNmNmNPSFN5ZmhmdXVKRGZOZThOclhw?= =?utf-8?B?ZHY4aTREQW8yVjcvME9lRkljeGRXdkhqbVF1WGFBY1hNcVMySkRUQTVGdm1x?= =?utf-8?B?ek1vcUZVYW10OFkrQXdOUEQxRFM5RnFFcTZaaG9jNy84ZC9wRklGM1Vqci9l?= =?utf-8?B?Yjc1aDA0YVN2Vm1xYXI1bnZkTmhkS0lwaUh3dENmMDF4dVVOMjdRRm0xc2pi?= =?utf-8?B?aEhpcEt2amdYbnJST2xpakhVM0luRjNDUDhndnB4QnprTzA3MVgwN1JXNnhI?= =?utf-8?B?OVRtOTExSlZEdlEwTHVYM1hVdlFVRVV4TjNNWFZwSmJtZ1dMQ3pSSHdHUldy?= =?utf-8?B?dUt6M3JucjArQU02ME90SVdHS0JBS0ZJa0pJOWRMOURwb0R6UzNrVHI3ZVps?= =?utf-8?Q?55aEb34WbUe3Q4F7B99O3ePt/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: be3aaf3e-6f7d-4270-f90c-08db345d85b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 16:07:28.4645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O+MRNcqNC+Qvg3LpF4nKwOIfuzA2PPrvVKQ45l8ougXdhIek+Ca8Hffuw6pn0unRZWHg4XCLNogPbdJ8W+zXYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8057 On 03.04.2023 17:38, Roger Pau Monné wrote: > On Mon, Apr 03, 2023 at 05:32:39PM +0200, Jan Beulich wrote: >> On 03.04.2023 12:14, Roger Pau Monne wrote: >>> Global p2m type recalculations (as triggered by logdirty) can create >>> so much contention on the p2m lock that simple guest operations like >>> VCPUOP_set_singleshot_timer on guests with a high amount of vCPUs (32) >>> will cease to work in a timely manner, up to the point that Linux >>> kernel versions that sill use the VCPU_SSHOTTMR_future flag with the >>> singleshot timer will cease to work: >>> >>> [ 82.779470] CE: xen increased min_delta_ns to 1000000 nsec >>> [ 82.793075] CE: Reprogramming failure. Giving up >>> [ 82.779470] CE: Reprogramming failure. Giving up >>> [ 82.821864] CE: xen increased min_delta_ns to 506250 nsec >>> [ 82.821864] CE: xen increased min_delta_ns to 759375 nsec >>> [ 82.821864] CE: xen increased min_delta_ns to 1000000 nsec >>> [ 82.821864] CE: Reprogramming failure. Giving up >>> [ 82.856256] CE: Reprogramming failure. Giving up >>> [ 84.566279] CE: Reprogramming failure. Giving up >>> [ 84.649493] Freezing user space processes ... >>> [ 130.604032] INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) >>> [ 130.604032] Task dump for CPU 14: >>> [ 130.604032] swapper/14 R running task 0 0 1 0x00000000 >>> [ 130.604032] Call Trace: >>> [ 130.604032] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 >>> [ 130.604032] [] ? default_idle+0x1e/0xd0 >>> [ 130.604032] [] ? arch_cpu_idle+0x20/0xc0 >>> [ 130.604032] [] ? cpu_startup_entry+0x14a/0x1e0 >>> [ 130.604032] [] ? start_secondary+0x1f7/0x270 >>> [ 130.604032] [] ? start_cpu+0x5/0x14 >>> [ 549.654536] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) >>> [ 549.655463] Task dump for CPU 26: >>> [ 549.655463] swapper/26 R running task 0 0 1 0x00000000 >>> [ 549.655463] Call Trace: >>> [ 549.655463] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 >>> [ 549.655463] [] ? default_idle+0x1e/0xd0 >>> [ 549.655463] [] ? arch_cpu_idle+0x20/0xc0 >>> [ 549.655463] [] ? cpu_startup_entry+0x14a/0x1e0 >>> [ 549.655463] [] ? start_secondary+0x1f7/0x270 >>> [ 549.655463] [] ? start_cpu+0x5/0x14 >>> [ 821.888478] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) >>> [ 821.888596] Task dump for CPU 26: >>> [ 821.888622] swapper/26 R running task 0 0 1 0x00000000 >>> [ 821.888677] Call Trace: >>> [ 821.888712] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 >>> [ 821.888771] [] ? default_idle+0x1e/0xd0 >>> [ 821.888818] [] ? arch_cpu_idle+0x20/0xc0 >>> [ 821.888865] [] ? cpu_startup_entry+0x14a/0x1e0 >>> [ 821.888917] [] ? start_secondary+0x1f7/0x270 >>> [ 821.888966] [] ? start_cpu+0x5/0x14 >>> >>> This is obviously undesirable. One way to bodge the issue would be to >>> ignore VCPU_SSHOTTMR_future, but that's a deliberate breakage of the >>> hypercall ABI. >>> >>> Instead lower the contention in the lock by doing the recalculation >>> with the lock in read mode. This is safe because only the flags/type >>> are changed, there's no PTE mfn change in the AMD recalculation logic. >>> The Intel (EPT) case is likely more complicated, as superpage >>> splitting for diverging EMT values must be done with the p2m lock in >>> taken in write mode. >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> I'm unsure whether such modification is fully safe: I think changing >>> the flags/type should be fine: the PTE write is performed using >>> safwrite_p2m_entry() which must be atomic (as the guest is still >>> running and accessing the page tables). I'm slightly worried about >>> all PTE readers not using atomic accesses to do so (ie: pointer >>> returned by p2m_find_entry() should be read atomicallly), and code >>> assuming that a gfn type cannot change while holding the p2m lock in >>> read mode. >> >> Coming back to this: Yes, I think reads (at least the ones in do_recalc() >> which can now be done in parallel) will need to be tightened if this is a >> road we want to follow. > > There are likely a lot of reads under the p2m read lock outside of > do_recalc() that will ideally need to be switched to use atomic > accesses also? Possibly, perhaps even likely. I specifically said "at least". But ones clearly on write-locked paths could probably be left alone. > I'm open to suggestions to other ways to get this sorted. And that's > a guest with 'just' 32 vCPUs, as we go up the contention on the p2m > lock during recalcs/misconfigs is going to increase massively. I'm afraid I don't have any really good idea, but I'm wondering whether trylock with (almost?) immediate exit back to guest might make this any better. At least the guest could then take interrupts before the insn is retried. Another thought in this direction would be to have a variant of trylock which "senses" how contended the lock is, to spin if it's the first one to wait, but exit (fail) otherwise. Jan From xen-devel-bounces@lists.xenproject.org Mon Apr 03 16:28:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 16:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517535.802999 (Exim 4.92) (envelope-from ) id 1pjN2j-0007KT-GJ; Mon, 03 Apr 2023 16:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517535.802999; Mon, 03 Apr 2023 16:28:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjN2j-0007KM-Dc; Mon, 03 Apr 2023 16:28:29 +0000 Received: by outflank-mailman (input) for mailman id 517535; Mon, 03 Apr 2023 16:28:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjN2h-0007KG-O2 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 16:28:27 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f30543a-d23c-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 18:28:26 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B70561FE5E; Mon, 3 Apr 2023 16:28:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7AA9D13416; Mon, 3 Apr 2023 16:28:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eBFRHKn+KmSoXgAAMHmgww (envelope-from ); Mon, 03 Apr 2023 16:28:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f30543a-d23c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680539305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BkZFoojUM+8fz39pkxsEFi2atMuRoJfIlL2aw5KVwkg=; b=hdAKyfRvOTyqR6Ux0Ll7IvLjr+WjyD/MIyYC3S90Jzwl7MO+MsAQyTRMP2AUwmsipxhTZR nbQ9V+PeJ1+C3W6xO+jbfALsVJMaB8K4gi5pAj7IDkUnwwbaXBNMWaquRTjORpebjBDHwY gC79h9DBvyLaUjb0cYAT4zJ8JUyXqEE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 0/2] xen: some CONFIG_DEBUG_INFO changes Date: Mon, 3 Apr 2023 18:28:21 +0200 Message-Id: <20230403162823.30681-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enabling crash dump analysis of the hypervisor requires the hypervisor having been built with CONFIG_DEBUG_INFO enabled. Today this requires either CONFIG_DEBUG or CONFIG_EXPERT set, which are both not security supported. This small series changes that in order to allow security supported Xen builds with the capability to do crash dump analysis via the "crash" tool. Note that due to problems with test machines proper support for EFI booted systems hasn't been verified, so this will likely need some more work. Changes in V2: - comments addressed Juergen Gross (2): xen: move CONFIG_DEBUG_INFO out of EXPERT section xen: update CONFIG_DEBUG_INFO help text xen/Kconfig.debug | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 16:28:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 16:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517536.803009 (Exim 4.92) (envelope-from ) id 1pjN2o-0007a8-OS; Mon, 03 Apr 2023 16:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517536.803009; Mon, 03 Apr 2023 16:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjN2o-0007Zz-LY; Mon, 03 Apr 2023 16:28:34 +0000 Received: by outflank-mailman (input) for mailman id 517536; Mon, 03 Apr 2023 16:28:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjN2o-0007Zc-6r for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 16:28:34 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9272d6a0-d23c-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 18:28:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 64B821FE73; Mon, 3 Apr 2023 16:28:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2652A13416; Mon, 3 Apr 2023 16:28:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S5DsB6/+KmS7XgAAMHmgww (envelope-from ); Mon, 03 Apr 2023 16:28:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9272d6a0-d23c-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680539311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=51wZc2vktLAGkJYuxQvGjNEZLX6vduj0/qi4N/4LX8o=; b=sRrt0UANSYHctURzJeHSOgf3dlCzRjDQ92tgQODJD6alTJAPtn1UxexgDFEfzy2T8gmn/8 ruCf7Gnuto4HknA4fzPaDAGuYOlM4fTyuYT728oRKQCTumjkruhJW9/pnLKwjVbmv0iSKY d5TR+k960biF2bUT+SQZOsQmWyrAR6s= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section Date: Mon, 3 Apr 2023 18:28:22 +0200 Message-Id: <20230403162823.30681-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230403162823.30681-1-jgross@suse.com> References: <20230403162823.30681-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to support hypervisor analysis of crash dumps, xen-syms needs to contain debug_info. It should be allowed to configure the hypervisor to be built with CONFIG_DEBUG_INFO in non-debug builds without having to enable EXPERT. Using a rather oldish gcc (7.5) it was verified that code generation doesn't really differ between CONFIG_DEBUG_INFO on or off without CONFIG_DEBUG being set (only observed differences were slightly different symbol addresses, verified via "objdump -d", resulting from the different config.gz in the binary). The old gcc version selection was based on the assumption, that newer gcc won't regress in this regard. So move CONFIG_DEBUG_INFO out of the section guarded by EXPERT. It should be mentioned that there have been reports that the linking of the xen.efi might take considerably longer with CONFIG_DEBUG_INFO selected when using newer binutils. Signed-off-by: Juergen Gross --- V2: - expanded commit message (Jan Beulich) --- xen/Kconfig.debug | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index fad3050d4f..e0d773d347 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -11,6 +11,13 @@ config DEBUG You probably want to say 'N' here. +config DEBUG_INFO + bool "Compile Xen with debug info" + default DEBUG + help + If you say Y here the resulting Xen will include debugging info + resulting in a larger binary image. + if DEBUG || EXPERT config CRASH_DEBUG @@ -28,13 +35,6 @@ config GDBSX If you want to enable support for debugging guests from dom0 via gdbsx then say Y. -config DEBUG_INFO - bool "Compile Xen with debug info" - default y - ---help--- - If you say Y here the resulting Xen will include debugging info - resulting in a larger binary image. - config FRAME_POINTER bool "Compile Xen with frame pointers" default DEBUG -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 16:28:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 16:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517537.803019 (Exim 4.92) (envelope-from ) id 1pjN2t-0007rf-0i; Mon, 03 Apr 2023 16:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517537.803019; Mon, 03 Apr 2023 16:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjN2s-0007rY-Tt; Mon, 03 Apr 2023 16:28:38 +0000 Received: by outflank-mailman (input) for mailman id 517537; Mon, 03 Apr 2023 16:28:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjN2r-0007KG-So for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 16:28:37 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95cbb07e-d23c-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 18:28:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 163CF21EEC; Mon, 3 Apr 2023 16:28:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C8A5B13416; Mon, 3 Apr 2023 16:28:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SzKZL7T+KmTtXgAAMHmgww (envelope-from ); Mon, 03 Apr 2023 16:28:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95cbb07e-d23c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680539317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=221NmFTRmK1PFAHtiBP2d1/nR5dmCSk7Sk74pCThNJQ=; b=YegnYhORMyDnRciHjmFHW0hridB1GwSWIr7sp9x6vZe6gEmxyWp/09cWdROCKDz5gIFDQf xhWiKsrzneX7RzVcXgd3jMji8mHElRvxRsHn4ub8UYk6asn2WwrY+hSCRibOX5+iFi1SPg mDwiWinrWYxP6pURfCjjz8hvGe+aFwk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/2] xen: update CONFIG_DEBUG_INFO help text Date: Mon, 3 Apr 2023 18:28:23 +0200 Message-Id: <20230403162823.30681-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230403162823.30681-1-jgross@suse.com> References: <20230403162823.30681-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Update the help text of the CONFIG_DEBUG_INFO option to be a little bit more specific. Signed-off-by: Juergen Gross --- V2: - expand help text, especially mentioning INSTALL_EFI_STRIP (Jan Beulich) --- xen/Kconfig.debug | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index e0d773d347..e6e609f813 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -15,8 +15,14 @@ config DEBUG_INFO bool "Compile Xen with debug info" default DEBUG help - If you say Y here the resulting Xen will include debugging info - resulting in a larger binary image. + Say Y here if you want to build Xen with debug information. This + information is needed e.g. for doing crash dump analysis of the + hypervisor via the "crash" tool. + Saying Y will increase the size of the xen-syms and xen.efi + binaries. In case the space on the EFI boot partition is rather + limited, you may want to make use of the INSTALL_EFI_STRIP make + variable when building the hypervisor, in order to strip xen.efi + before installing it to the EFI partition. if DEBUG || EXPERT -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517549.803038 (Exim 4.92) (envelope-from ) id 1pjOwp-0004Xh-UQ; Mon, 03 Apr 2023 18:30:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517549.803038; Mon, 03 Apr 2023 18:30:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwp-0004Xa-Rk; Mon, 03 Apr 2023 18:30:31 +0000 Received: by outflank-mailman (input) for mailman id 517549; Mon, 03 Apr 2023 18:30:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwo-0004HH-5Z for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:30 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b015c4b-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:28 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-519-3isl-chxN3OIRuBPnd0Pfg-1; Mon, 03 Apr 2023 14:30:21 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71BBF385F379; Mon, 3 Apr 2023 18:30:14 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2F9E400F4F; Mon, 3 Apr 2023 18:30:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b015c4b-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0HFVVv61t7j/DUMbeicZfUXtZsQPz0KQrxVQvmIXfw=; b=VM3hW7NwOHLGEw7z2TtAkaM9y+rDacCrFrDh2TCrbnubtXCyVGSV17liiQ5mgbFdza1Jic Q2QqKnofNnVRFGtZkh9OpKE80WPzwBqW5+qlNwVg2u9Abup3t4lZXGrUypOlnGm8quH8+g yHlDjsb/8OFN1+Rwu7LI7yWeXQhMif4= X-MC-Unique: 3isl-chxN3OIRuBPnd0Pfg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard , Zhengui Li Subject: [PATCH 02/13] virtio-scsi: stop using aio_disable_external() during unplug Date: Mon, 3 Apr 2023 14:29:53 -0400 Message-Id: <20230403183004.347205-3-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 This patch is part of an effort to remove the aio_disable_external() API because it does not fit in a multi-queue block layer world where many AioContexts may be submitting requests to the same disk. The SCSI emulation code is already in good shape to stop using aio_disable_external(). It was only used by commit 9c5aad84da1c ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching scsi disk") to ensure that virtio_scsi_hotunplug() works while the guest driver is submitting I/O. Ensure virtio_scsi_hotunplug() is safe as follows: 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> device_set_realized() calls qatomic_set(&dev->realized, false) so that future scsi_device_get() calls return NULL because they exclude SCSIDevices with realized=false. That means virtio-scsi will reject new I/O requests to this SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while virtio_scsi_hotunplug() is still executing. We are protected against new requests! 2. Add a call to scsi_device_purge_requests() from scsi_unrealize() so that in-flight requests are cancelled synchronously. This ensures that no in-flight requests remain once qdev_simple_device_unplug_cb() returns. Thanks to these two conditions we don't need aio_disable_external() anymore. Cc: Zhengui Li Signed-off-by: Stefan Hajnoczi --- hw/scsi/scsi-disk.c | 1 + hw/scsi/virtio-scsi.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 97c9b1c8cd..e01bd84541 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2522,6 +2522,7 @@ static void scsi_realize(SCSIDevice *dev, Error **errp) static void scsi_unrealize(SCSIDevice *dev) { + scsi_device_purge_requests(dev, SENSE_CODE(RESET)); del_boot_device_lchs(&dev->qdev, NULL); } diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 000961446c..a02f9233ec 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -1061,11 +1061,8 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, VirtIODevice *vdev = VIRTIO_DEVICE(hotplug_dev); VirtIOSCSI *s = VIRTIO_SCSI(vdev); SCSIDevice *sd = SCSI_DEVICE(dev); - AioContext *ctx = s->ctx ?: qemu_get_aio_context(); - aio_disable_external(ctx); qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); - aio_enable_external(ctx); if (s->ctx) { virtio_scsi_acquire(s); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517550.803048 (Exim 4.92) (envelope-from ) id 1pjOwr-0004mc-7G; Mon, 03 Apr 2023 18:30:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517550.803048; Mon, 03 Apr 2023 18:30:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwr-0004mT-4H; Mon, 03 Apr 2023 18:30:33 +0000 Received: by outflank-mailman (input) for mailman id 517550; Mon, 03 Apr 2023 18:30:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwp-0004HH-5d for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9baee2a3-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:29 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-2uGakXqQNEinBtqwH2bvkA-1; Mon, 03 Apr 2023 14:30:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 07C581C27DBC; Mon, 3 Apr 2023 18:30:17 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F35E2166B26; Mon, 3 Apr 2023 18:30:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9baee2a3-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpef4kT6gqf7n/rR0/ynntTmCBLqt8QRSEC7iM5/ics=; b=ffR9Y3K7u6+01Mx2Q47gj+8wq/GyXU0w05hTOcdsfp3Aewhmmd9SpVIs+UPuDgm4qXvbdl Uq4PldBdZbSCy/MljL4kEmO0k5iA9PXy6yku4nOslN8OZWoSycHJfzbSD77K1t3or/GZiK CiJi195aeO5BZvOeY0rVXdthKlTf1dg= X-MC-Unique: 2uGakXqQNEinBtqwH2bvkA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 03/13] block/export: only acquire AioContext once for vhost_user_server_stop() Date: Mon, 3 Apr 2023 14:29:54 -0400 Message-Id: <20230403183004.347205-4-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 vhost_user_server_stop() uses AIO_WAIT_WHILE(). AIO_WAIT_WHILE() requires that AioContext is only acquired once. Since blk_exp_request_shutdown() already acquires the AioContext it shouldn't be acquired again in vhost_user_server_stop(). Signed-off-by: Stefan Hajnoczi --- util/vhost-user-server.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 40f36ea214..5b6216069c 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -346,10 +346,9 @@ static void vu_accept(QIONetListener *listener, QIOChannelSocket *sioc, aio_context_release(server->ctx); } +/* server->ctx acquired by caller */ void vhost_user_server_stop(VuServer *server) { - aio_context_acquire(server->ctx); - qemu_bh_delete(server->restart_listener_bh); server->restart_listener_bh = NULL; @@ -366,8 +365,6 @@ void vhost_user_server_stop(VuServer *server) AIO_WAIT_WHILE(server->ctx, server->co_trip); } - aio_context_release(server->ctx); - if (server->listener) { qio_net_listener_disconnect(server->listener); object_unref(OBJECT(server->listener)); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517553.803073 (Exim 4.92) (envelope-from ) id 1pjOwu-0005Ny-B9; Mon, 03 Apr 2023 18:30:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517553.803073; Mon, 03 Apr 2023 18:30:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwu-0005LQ-2c; Mon, 03 Apr 2023 18:30:36 +0000 Received: by outflank-mailman (input) for mailman id 517553; Mon, 03 Apr 2023 18:30:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOws-0004HH-9S for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9df5a3e9-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:33 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-rxZjFOypOgG8cMOE2p_TKw-1; Mon, 03 Apr 2023 14:30:27 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F1D68C447E; Mon, 3 Apr 2023 18:30:19 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC2A9483EC1; Mon, 3 Apr 2023 18:30:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9df5a3e9-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKqwyQ4Hx/raK7iVoVjGcYzVd4PPhwE8qnDjfh3DtNg=; b=URu9BWdvsR30tJn1o9ILEciRQJDN6aQR/LQ34COhjAr41NM9w0luWbVDE2Fopal95lT5a4 dPKaZHwJCbahzydaAA3tNYRtPCYgHjJU8Az79cykjloJEmwPhp8WgC+KBmmSupMbTKqC7r 0TyJqYPIL+P9rEqRVhsS8ZCNDavhVWI= X-MC-Unique: rxZjFOypOgG8cMOE2p_TKw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 04/13] util/vhost-user-server: rename refcount to in_flight counter Date: Mon, 3 Apr 2023 14:29:55 -0400 Message-Id: <20230403183004.347205-5-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 The VuServer object has a refcount field and ref/unref APIs. The name is confusing because it's actually an in-flight request counter instead of a refcount. Normally a refcount destroys the object upon reaching zero. The VuServer counter is used to wake up the vhost-user coroutine when there are no more requests. Avoid confusing by renaming refcount and ref/unref to in_flight and inc/dec. Signed-off-by: Stefan Hajnoczi --- include/qemu/vhost-user-server.h | 6 +++--- block/export/vhost-user-blk-server.c | 11 +++++++---- util/vhost-user-server.c | 14 +++++++------- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user-server.h index 25c72433ca..bc0ac9ddb6 100644 --- a/include/qemu/vhost-user-server.h +++ b/include/qemu/vhost-user-server.h @@ -41,7 +41,7 @@ typedef struct { const VuDevIface *vu_iface; /* Protected by ctx lock */ - unsigned int refcount; + unsigned int in_flight; bool wait_idle; VuDev vu_dev; QIOChannel *ioc; /* The I/O channel with the client */ @@ -60,8 +60,8 @@ bool vhost_user_server_start(VuServer *server, void vhost_user_server_stop(VuServer *server); -void vhost_user_server_ref(VuServer *server); -void vhost_user_server_unref(VuServer *server); +void vhost_user_server_inc_in_flight(VuServer *server); +void vhost_user_server_dec_in_flight(VuServer *server); void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx); void vhost_user_server_detach_aio_context(VuServer *server); diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index 3409d9e02e..e93f2ed6b4 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -49,7 +49,10 @@ static void vu_blk_req_complete(VuBlkReq *req, size_t in_len) free(req); } -/* Called with server refcount increased, must decrease before returning */ +/* + * Called with server in_flight counter increased, must decrease before + * returning. + */ static void coroutine_fn vu_blk_virtio_process_req(void *opaque) { VuBlkReq *req = opaque; @@ -67,12 +70,12 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque) in_num, out_num); if (in_len < 0) { free(req); - vhost_user_server_unref(server); + vhost_user_server_dec_in_flight(server); return; } vu_blk_req_complete(req, in_len); - vhost_user_server_unref(server); + vhost_user_server_dec_in_flight(server); } static void vu_blk_process_vq(VuDev *vu_dev, int idx) @@ -94,7 +97,7 @@ static void vu_blk_process_vq(VuDev *vu_dev, int idx) Coroutine *co = qemu_coroutine_create(vu_blk_virtio_process_req, req); - vhost_user_server_ref(server); + vhost_user_server_inc_in_flight(server); qemu_coroutine_enter(co); } } diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 5b6216069c..1622f8cfb3 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -75,16 +75,16 @@ static void panic_cb(VuDev *vu_dev, const char *buf) error_report("vu_panic: %s", buf); } -void vhost_user_server_ref(VuServer *server) +void vhost_user_server_inc_in_flight(VuServer *server) { assert(!server->wait_idle); - server->refcount++; + server->in_flight++; } -void vhost_user_server_unref(VuServer *server) +void vhost_user_server_dec_in_flight(VuServer *server) { - server->refcount--; - if (server->wait_idle && !server->refcount) { + server->in_flight--; + if (server->wait_idle && !server->in_flight) { aio_co_wake(server->co_trip); } } @@ -192,13 +192,13 @@ static coroutine_fn void vu_client_trip(void *opaque) /* Keep running */ } - if (server->refcount) { + if (server->in_flight) { /* Wait for requests to complete before we can unmap the memory */ server->wait_idle = true; qemu_coroutine_yield(); server->wait_idle = false; } - assert(server->refcount == 0); + assert(server->in_flight == 0); vu_deinit(vu_dev); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517548.803029 (Exim 4.92) (envelope-from ) id 1pjOwo-0004HZ-MV; Mon, 03 Apr 2023 18:30:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517548.803029; Mon, 03 Apr 2023 18:30:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwo-0004HS-Jq; Mon, 03 Apr 2023 18:30:30 +0000 Received: by outflank-mailman (input) for mailman id 517548; Mon, 03 Apr 2023 18:30:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwn-0004HH-HE for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:29 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9addabbf-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:28 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-gJweyXgPPBCNaCJfjwIa3g-1; Mon, 03 Apr 2023 14:30:25 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0DAFE3C20EE3; Mon, 3 Apr 2023 18:30:22 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63861440D8; Mon, 3 Apr 2023 18:30:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9addabbf-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+bLg6uTzP7Qgt6lQ3xKdY10AY3Nt3xLke1uGL1u9ShU=; b=Pq2O9MN9GXcdwkjsOEXC2ygoZmqJr/kEU4W7AK0q6j9jVTcqTNpCNN+GkCurWt9ZTXcZDr cWsXfXcmXuSV2JbzMfZGjFywQYe5D67mOdFgj/SCkcgvvMP2r1WwRHh09k/JSLX69u8JT+ coX+sYvJTKC3zXKhJeSkaOVEOAzsNp0= X-MC-Unique: gJweyXgPPBCNaCJfjwIa3g-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 05/13] block/export: wait for vhost-user-blk requests when draining Date: Mon, 3 Apr 2023 14:29:56 -0400 Message-Id: <20230403183004.347205-6-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Each vhost-user-blk request runs in a coroutine. When the BlockBackend enters a drained section we need to enter a quiescent state. Currently any in-flight requests race with bdrv_drained_begin() because it is unaware of vhost-user-blk requests. When blk_co_preadv/pwritev()/etc returns it wakes the bdrv_drained_begin() thread but vhost-user-blk request processing has not yet finished. The request coroutine continues executing while the main loop thread thinks it is in a drained section. One example where this is unsafe is for blk_set_aio_context() where bdrv_drained_begin() is called before .aio_context_detached() and .aio_context_attach(). If request coroutines are still running after bdrv_drained_begin(), then the AioContext could change underneath them and they race with new requests processed in the new AioContext. This could lead to virtqueue corruption, for example. (This example is theoretical, I came across this while reading the code and have not tried to reproduce it.) It's easy to make bdrv_drained_begin() wait for in-flight requests: add a .drained_poll() callback that checks the VuServer's in-flight counter. VuServer just needs an API that returns true when there are requests in flight. The in-flight counter needs to be atomic. Signed-off-by: Stefan Hajnoczi --- include/qemu/vhost-user-server.h | 4 +++- block/export/vhost-user-blk-server.c | 19 +++++++++++++++++++ util/vhost-user-server.c | 14 ++++++++++---- 3 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user-server.h index bc0ac9ddb6..b1c1cda886 100644 --- a/include/qemu/vhost-user-server.h +++ b/include/qemu/vhost-user-server.h @@ -40,8 +40,9 @@ typedef struct { int max_queues; const VuDevIface *vu_iface; + unsigned int in_flight; /* atomic */ + /* Protected by ctx lock */ - unsigned int in_flight; bool wait_idle; VuDev vu_dev; QIOChannel *ioc; /* The I/O channel with the client */ @@ -62,6 +63,7 @@ void vhost_user_server_stop(VuServer *server); void vhost_user_server_inc_in_flight(VuServer *server); void vhost_user_server_dec_in_flight(VuServer *server); +bool vhost_user_server_has_in_flight(VuServer *server); void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx); void vhost_user_server_detach_aio_context(VuServer *server); diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index e93f2ed6b4..dbf5207162 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -254,6 +254,22 @@ static void vu_blk_exp_request_shutdown(BlockExport *exp) vhost_user_server_stop(&vexp->vu_server); } +/* + * Ensures that bdrv_drained_begin() waits until in-flight requests complete. + * + * Called with vexp->export.ctx acquired. + */ +static bool vu_blk_drained_poll(void *opaque) +{ + VuBlkExport *vexp = opaque; + + return vhost_user_server_has_in_flight(&vexp->vu_server); +} + +static const BlockDevOps vu_blk_dev_ops = { + .drained_poll = vu_blk_drained_poll, +}; + static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, Error **errp) { @@ -292,6 +308,7 @@ static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vu_blk_initialize_config(blk_bs(exp->blk), &vexp->blkcfg, logical_block_size, num_queues); + blk_set_dev_ops(exp->blk, &vu_blk_dev_ops, vexp); blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vexp); @@ -299,6 +316,7 @@ static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, num_queues, &vu_blk_iface, errp)) { blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vexp); + blk_set_dev_ops(exp->blk, NULL, NULL); g_free(vexp->handler.serial); return -EADDRNOTAVAIL; } @@ -312,6 +330,7 @@ static void vu_blk_exp_delete(BlockExport *exp) blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vexp); + blk_set_dev_ops(exp->blk, NULL, NULL); g_free(vexp->handler.serial); } diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 1622f8cfb3..2e6b640050 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -78,17 +78,23 @@ static void panic_cb(VuDev *vu_dev, const char *buf) void vhost_user_server_inc_in_flight(VuServer *server) { assert(!server->wait_idle); - server->in_flight++; + qatomic_inc(&server->in_flight); } void vhost_user_server_dec_in_flight(VuServer *server) { - server->in_flight--; - if (server->wait_idle && !server->in_flight) { - aio_co_wake(server->co_trip); + if (qatomic_fetch_dec(&server->in_flight) == 1) { + if (server->wait_idle) { + aio_co_wake(server->co_trip); + } } } +bool vhost_user_server_has_in_flight(VuServer *server) +{ + return qatomic_load_acquire(&server->in_flight) > 0; +} + static bool coroutine_fn vu_message_read(VuDev *vu_dev, int conn_fd, VhostUserMsg *vmsg) { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517552.803069 (Exim 4.92) (envelope-from ) id 1pjOwt-0005JH-TH; Mon, 03 Apr 2023 18:30:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517552.803069; Mon, 03 Apr 2023 18:30:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwt-0005J6-PZ; Mon, 03 Apr 2023 18:30:35 +0000 Received: by outflank-mailman (input) for mailman id 517552; Mon, 03 Apr 2023 18:30:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwr-0004HH-VE for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9db74a78-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:33 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-cN00YhrQM7uB9EfAu9sSvQ-1; Mon, 03 Apr 2023 14:30:26 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 416D13C10EEF; Mon, 3 Apr 2023 18:30:12 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 751A6C15BA0; Mon, 3 Apr 2023 18:30:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9db74a78-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oL+HrJxL6ytOleAzvmZ4SJ3Zeezd7vV75aui9s0hUdo=; b=dI+yjjuDwKKViSZTb1wuclFWGfaAIY4B8fBgPsiEvcqMluIfiN33JcNCj4A5KlkR1WTkz6 vj61EvXAzYx80j80rRhCLyGfHn8Se3lfYfZD51uWRrbQzZRFUUapSK/N67fQDa9wTwq0O3 fum+ALo6iIoQJmuSCHUgxKt8wCcQc9Q= X-MC-Unique: cN00YhrQM7uB9EfAu9sSvQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event Date: Mon, 3 Apr 2023 14:29:52 -0400 Message-Id: <20230403183004.347205-2-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Only report a transport reset event to the guest after the SCSIDevice has been unrealized by qdev_simple_device_unplug_cb(). qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field to false so that scsi_device_find/get() no longer see it. scsi_target_emulate_report_luns() also needs to be updated to filter out SCSIDevices that are unrealized. These changes ensure that the guest driver does not see the SCSIDevice that's being unplugged if it responds very quickly to the transport reset event. Signed-off-by: Stefan Hajnoczi --- hw/scsi/scsi-bus.c | 3 ++- hw/scsi/virtio-scsi.c | 18 +++++++++--------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index c97176110c..f9bd064833 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -487,7 +487,8 @@ static bool scsi_target_emulate_report_luns(SCSITargetReq *r) DeviceState *qdev = kid->child; SCSIDevice *dev = SCSI_DEVICE(qdev); - if (dev->channel == channel && dev->id == id && dev->lun != 0) { + if (dev->channel == channel && dev->id == id && dev->lun != 0 && + qatomic_load_acquire(&dev->qdev.realized)) { store_lun(tmp, dev->lun); g_byte_array_append(buf, tmp, 8); len += 8; diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 612c525d9d..000961446c 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -1063,15 +1063,6 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, SCSIDevice *sd = SCSI_DEVICE(dev); AioContext *ctx = s->ctx ?: qemu_get_aio_context(); - if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { - virtio_scsi_acquire(s); - virtio_scsi_push_event(s, sd, - VIRTIO_SCSI_T_TRANSPORT_RESET, - VIRTIO_SCSI_EVT_RESET_REMOVED); - scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); - virtio_scsi_release(s); - } - aio_disable_external(ctx); qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); aio_enable_external(ctx); @@ -1082,6 +1073,15 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NULL); virtio_scsi_release(s); } + + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { + virtio_scsi_acquire(s); + virtio_scsi_push_event(s, sd, + VIRTIO_SCSI_T_TRANSPORT_RESET, + VIRTIO_SCSI_EVT_RESET_REMOVED); + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); + virtio_scsi_release(s); + } } static struct SCSIBusInfo virtio_scsi_scsi_info = { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517554.803079 (Exim 4.92) (envelope-from ) id 1pjOwu-0005Wh-Rc; Mon, 03 Apr 2023 18:30:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517554.803079; Mon, 03 Apr 2023 18:30:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwu-0005Vk-K5; Mon, 03 Apr 2023 18:30:36 +0000 Received: by outflank-mailman (input) for mailman id 517554; Mon, 03 Apr 2023 18:30:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwt-00058E-6y for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:35 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cf0bae2-d24d-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 20:30:32 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-274-Q2KxycS7PhakuOgluqVi7g-1; Mon, 03 Apr 2023 14:30:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4CDFC88FA4C; Mon, 3 Apr 2023 18:30:09 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16D77140EBF4; Mon, 3 Apr 2023 18:30:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cf0bae2-d24d-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CjLb/A1nTO72rleg3tgXtfILFOYKYMPMoC5OW2A0i4g=; b=iNAIOtkg78eEKcmpYmR0bZGz8Jp4V+2PT9d/T93TVVpQuQfWrBcjWDFicoh/J7sND0V+LD XEqoahedqHHkFAQXdF5L9jCjERMESwkprs71k+g2QL1AioEy7X2Vbrn2jcL0RCa7TEZzQn LoHFi1UDp6kiqr7Bf699zpcmZ/xR+Rk= X-MC-Unique: Q2KxycS7PhakuOgluqVi7g-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 00/13] block: remove aio_disable_external() API Date: Mon, 3 Apr 2023 14:29:51 -0400 Message-Id: <20230403183004.347205-1-stefanha@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 The aio_disable_external() API temporarily suspends file descriptor monitoring in the event loop. The block layer uses this to prevent new I/O requests being submitted from the guest and elsewhere between bdrv_drained_begin() and bdrv_drained_end(). While the block layer still needs to prevent new I/O requests in drained sections, the aio_disable_external() API can be replaced with .drained_begin/end/poll() callbacks that have been added to BdrvChildClass and BlockDevOps. This newer .bdrained_begin/end/poll() approach is attractive because it works without specifying a specific AioContext. The block layer is moving towards multi-queue and that means multiple AioContexts may be processing I/O simultaneously. The aio_disable_external() was always somewhat hacky. It suspends all file descriptors that were registered with is_external=true, even if they have nothing to do with the BlockDriverState graph nodes that are being drained. It's better to solve a block layer problem in the block layer than to have an odd event loop API solution. That covers the motivation for this change, now on to the specifics of this series: While it would be nice if a single conceptual approach could be applied to all is_external=true file descriptors, I ended up looking at callers on a case-by-case basis. There are two general ways I migrated code away from is_external=true: 1. Block exports are typically best off unregistering fds in .drained_begin() and registering them again in .drained_end(). The .drained_poll() function waits for in-flight requests to finish using a reference counter. 2. Emulated storage controllers like virtio-blk and virtio-scsi are a little simpler. They can rely on BlockBackend's request queuing during drain feature. Guest I/O request coroutines are suspended in a drained section and resume upon the end of the drained section. The first two virtio-scsi patches were already sent as a separate series. I included them because they are necessary in order to fully remove aio_disable_external(). Based-on: 087bc644b7634436ca9d52fe58ba9234e2bef026 (kevin/block-next) Stefan Hajnoczi (13): virtio-scsi: avoid race between unplug and transport event virtio-scsi: stop using aio_disable_external() during unplug block/export: only acquire AioContext once for vhost_user_server_stop() util/vhost-user-server: rename refcount to in_flight counter block/export: wait for vhost-user-blk requests when draining block/export: stop using is_external in vhost-user-blk server virtio: do not set is_external=true on host notifiers hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore hw/xen: do not set is_external=true on evtchn fds block/export: rewrite vduse-blk drain code block/fuse: take AioContext lock around blk_exp_ref/unref() block/fuse: do not set is_external=true on FUSE fd aio: remove aio_disable_external() API include/block/aio.h | 55 ----------- include/qemu/vhost-user-server.h | 8 +- util/aio-posix.h | 1 - block.c | 7 -- block/blkio.c | 15 +-- block/curl.c | 10 +- block/export/fuse.c | 62 ++++++++++++- block/export/vduse-blk.c | 132 +++++++++++++++++++-------- block/export/vhost-user-blk-server.c | 73 +++++++++------ block/io.c | 2 - block/io_uring.c | 4 +- block/iscsi.c | 3 +- block/linux-aio.c | 4 +- block/nfs.c | 5 +- block/nvme.c | 8 +- block/ssh.c | 4 +- block/win32-aio.c | 6 +- hw/i386/kvm/xen_xenstore.c | 2 +- hw/scsi/scsi-bus.c | 3 +- hw/scsi/scsi-disk.c | 1 + hw/scsi/virtio-scsi.c | 21 ++--- hw/virtio/virtio.c | 6 +- hw/xen/xen-bus.c | 6 +- io/channel-command.c | 6 +- io/channel-file.c | 3 +- io/channel-socket.c | 3 +- migration/rdma.c | 16 ++-- tests/unit/test-aio.c | 27 +----- tests/unit/test-fdmon-epoll.c | 73 --------------- util/aio-posix.c | 20 +--- util/aio-win32.c | 8 +- util/async.c | 3 +- util/fdmon-epoll.c | 10 -- util/fdmon-io_uring.c | 8 +- util/fdmon-poll.c | 3 +- util/main-loop.c | 7 +- util/qemu-coroutine-io.c | 7 +- util/vhost-user-server.c | 38 ++++---- tests/unit/meson.build | 3 - 39 files changed, 298 insertions(+), 375 deletions(-) delete mode 100644 tests/unit/test-fdmon-epoll.c -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517551.803055 (Exim 4.92) (envelope-from ) id 1pjOwr-0004s2-M3; Mon, 03 Apr 2023 18:30:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517551.803055; Mon, 03 Apr 2023 18:30:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwr-0004qd-Fl; Mon, 03 Apr 2023 18:30:33 +0000 Received: by outflank-mailman (input) for mailman id 517551; Mon, 03 Apr 2023 18:30:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwq-0004HH-5i for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:32 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c1693d8-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:30 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-yDm9BV4sNRCoPTzB8fuUCw-1; Mon, 03 Apr 2023 14:30:25 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A606E885620; Mon, 3 Apr 2023 18:30:24 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECAF31121314; Mon, 3 Apr 2023 18:30:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c1693d8-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rd8h2e2Z0uhjua/p0PDxA8jGvK3/DbHaZUIqG5W/DmA=; b=TlI8CNolDE3g8bsImw9FNt8x40JPFGkUBySN9BQP+3GjyzqjIIxRGy+AfzPyW0ldWpqr4V kZLSEAa487q8i718P8/eG/s1EoWGN1VTHrH++d1e5o9jIW/g/nHzbvB8y0X2oIGIgmQwk+ UkICGXaHU2W1Kb0v/6RCdJKtrFRAf8Y= X-MC-Unique: yDm9BV4sNRCoPTzB8fuUCw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 06/13] block/export: stop using is_external in vhost-user-blk server Date: Mon, 3 Apr 2023 14:29:57 -0400 Message-Id: <20230403183004.347205-7-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 vhost-user activity must be suspended during bdrv_drained_begin/end(). This prevents new requests from interfering with whatever is happening in the drained section. Previously this was done using aio_set_fd_handler()'s is_external argument. In a multi-queue block layer world the aio_disable_external() API cannot be used since multiple AioContext may be processing I/O, not just one. Switch to BlockDevOps->drained_begin/end() callbacks. Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 43 ++++++++++++++-------------- util/vhost-user-server.c | 10 +++---- 2 files changed, 26 insertions(+), 27 deletions(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index dbf5207162..6e1bc196fb 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -207,22 +207,6 @@ static const VuDevIface vu_blk_iface = { .process_msg = vu_blk_process_msg, }; -static void blk_aio_attached(AioContext *ctx, void *opaque) -{ - VuBlkExport *vexp = opaque; - - vexp->export.ctx = ctx; - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); -} - -static void blk_aio_detach(void *opaque) -{ - VuBlkExport *vexp = opaque; - - vhost_user_server_detach_aio_context(&vexp->vu_server); - vexp->export.ctx = NULL; -} - static void vu_blk_initialize_config(BlockDriverState *bs, struct virtio_blk_config *config, @@ -254,6 +238,25 @@ static void vu_blk_exp_request_shutdown(BlockExport *exp) vhost_user_server_stop(&vexp->vu_server); } +/* Called with vexp->export.ctx acquired */ +static void vu_blk_drained_begin(void *opaque) +{ + VuBlkExport *vexp = opaque; + + vhost_user_server_detach_aio_context(&vexp->vu_server); +} + +/* Called with vexp->export.blk AioContext acquired */ +static void vu_blk_drained_end(void *opaque) +{ + VuBlkExport *vexp = opaque; + + /* Refresh AioContext in case it changed */ + vexp->export.ctx = blk_get_aio_context(vexp->export.blk); + + vhost_user_server_attach_aio_context(&vexp->vu_server, vexp->export.ctx); +} + /* * Ensures that bdrv_drained_begin() waits until in-flight requests complete. * @@ -267,6 +270,8 @@ static bool vu_blk_drained_poll(void *opaque) } static const BlockDevOps vu_blk_dev_ops = { + .drained_begin = vu_blk_drained_begin, + .drained_end = vu_blk_drained_end, .drained_poll = vu_blk_drained_poll, }; @@ -309,13 +314,9 @@ static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, logical_block_size, num_queues); blk_set_dev_ops(exp->blk, &vu_blk_dev_ops, vexp); - blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, - vexp); if (!vhost_user_server_start(&vexp->vu_server, vu_opts->addr, exp->ctx, num_queues, &vu_blk_iface, errp)) { - blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, - blk_aio_detach, vexp); blk_set_dev_ops(exp->blk, NULL, NULL); g_free(vexp->handler.serial); return -EADDRNOTAVAIL; @@ -328,8 +329,6 @@ static void vu_blk_exp_delete(BlockExport *exp) { VuBlkExport *vexp = container_of(exp, VuBlkExport, export); - blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, - vexp); blk_set_dev_ops(exp->blk, NULL, NULL); g_free(vexp->handler.serial); } diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 2e6b640050..332aea9306 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -278,7 +278,7 @@ set_watch(VuDev *vu_dev, int fd, int vu_evt, vu_fd_watch->fd = fd; vu_fd_watch->cb = cb; qemu_socket_set_nonblock(fd); - aio_set_fd_handler(server->ioc->ctx, fd, true, kick_handler, + aio_set_fd_handler(server->ioc->ctx, fd, false, kick_handler, NULL, NULL, NULL, vu_fd_watch); vu_fd_watch->vu_dev = vu_dev; vu_fd_watch->pvt = pvt; @@ -299,7 +299,7 @@ static void remove_watch(VuDev *vu_dev, int fd) if (!vu_fd_watch) { return; } - aio_set_fd_handler(server->ioc->ctx, fd, true, + aio_set_fd_handler(server->ioc->ctx, fd, false, NULL, NULL, NULL, NULL, NULL); QTAILQ_REMOVE(&server->vu_fd_watches, vu_fd_watch, next); @@ -362,7 +362,7 @@ void vhost_user_server_stop(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, NULL, NULL, NULL, NULL, vu_fd_watch); } @@ -403,7 +403,7 @@ void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx) qio_channel_attach_aio_context(server->ioc, ctx); QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(ctx, vu_fd_watch->fd, true, kick_handler, NULL, + aio_set_fd_handler(ctx, vu_fd_watch->fd, false, kick_handler, NULL, NULL, NULL, vu_fd_watch); } @@ -417,7 +417,7 @@ void vhost_user_server_detach_aio_context(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, NULL, NULL, NULL, NULL, vu_fd_watch); } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517555.803099 (Exim 4.92) (envelope-from ) id 1pjOwx-0006AV-7f; Mon, 03 Apr 2023 18:30:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517555.803099; Mon, 03 Apr 2023 18:30:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwx-0006A0-46; Mon, 03 Apr 2023 18:30:39 +0000 Received: by outflank-mailman (input) for mailman id 517555; Mon, 03 Apr 2023 18:30:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwv-00058E-F1 for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f6e1b61-d24d-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 20:30:35 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-9CKa4rlENESBndwEgTyXrw-1; Mon, 03 Apr 2023 14:30:31 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC85B185A790; Mon, 3 Apr 2023 18:30:29 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1ED14400F4F; Mon, 3 Apr 2023 18:30:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f6e1b61-d24d-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=02kXX9aX6Yr2x3VYWWh4xRNvlIxdZtHtMoEfskS16XA=; b=jG/URGlzduMp2atXz4KaNq3IKZO6oJIHO0i5UZihTsZ1MocxkdAM98rtBCvP7YZGG6WByY GluIqgXkZH/9e/fZj2iM1JdrVfoiobkwrMrhMTdqDgAAt0Q+c34ldRkCdmeb6CCCAJruct 0V59YdLPn84w4MwihA1UoDBLiAAhgBc= X-MC-Unique: 9CKa4rlENESBndwEgTyXrw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore Date: Mon, 3 Apr 2023 14:29:59 -0400 Message-Id: <20230403183004.347205-9-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 There is no need to suspend activity between aio_disable_external() and aio_enable_external(), which is mainly used for the block layer's drain operation. This is part of ongoing work to remove the aio_disable_external() API. Signed-off-by: Stefan Hajnoczi --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 900679af8a..6e81bc8791 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kvm/xen_xenstore.c @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error **errp) error_setg(errp, "Xenstore evtchn port init failed"); return; } - aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true, + aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false, xen_xenstore_event, NULL, NULL, NULL, s); s->impl = xs_impl_create(xen_domid); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517556.803109 (Exim 4.92) (envelope-from ) id 1pjOwz-0006VT-GF; Mon, 03 Apr 2023 18:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517556.803109; Mon, 03 Apr 2023 18:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwz-0006VK-Cm; Mon, 03 Apr 2023 18:30:41 +0000 Received: by outflank-mailman (input) for mailman id 517556; Mon, 03 Apr 2023 18:30:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwx-00058E-3X for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:39 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a068c5f4-d24d-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 20:30:37 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-439-74AM9wfyN9eiYjF1jls1ng-1; Mon, 03 Apr 2023 14:30:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EE94B811E7C; Mon, 3 Apr 2023 18:30:31 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 521171121314; Mon, 3 Apr 2023 18:30:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a068c5f4-d24d-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w78ixlnTJkfmit1c5uhGwpfg3e2qbfo6w6b+6TW1iVA=; b=D8g8DNdYotY3VuhWIN5vTd5CmEn80Ry48uLp2xBWgJ+aguPaY/WH8O/z7PWXXhydT3zCDm ZgDNTHxlvXdxOeh9rjIagscMlbLbDKot1VRaMi+JENdwF2VzC0/CShZeyCjooamKM5YXMm 9R6V1BPLX2Fp3UVDHCidsLd4YD8gV8Y= X-MC-Unique: 74AM9wfyN9eiYjF1jls1ng-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 09/13] hw/xen: do not set is_external=true on evtchn fds Date: Mon, 3 Apr 2023 14:30:00 -0400 Message-Id: <20230403183004.347205-10-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 is_external=true suspends fd handlers between aio_disable_external() and aio_enable_external(). The block layer's drain operation uses this mechanism to prevent new I/O from sneaking in between bdrv_drained_begin() and bdrv_drained_end(). The xen-block device actually works fine with is_external=false because BlockBackend requests are already queued between bdrv_drained_begin() and bdrv_drained_end(). Since the Xen ring size is finite, request queuing will stop once the ring is full and memory usage is bounded. After bdrv_drained_end() the BlockBackend requests will resume and xen-block's processing will continue. This is part of ongoing work to remove the aio_disable_external() API. Signed-off-by: Stefan Hajnoczi --- hw/xen/xen-bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index c59850b1de..c4fd26abe1 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -842,11 +842,11 @@ void xen_device_set_event_channel_context(XenDevice *xendev, } if (channel->ctx) - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), true, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, NULL, NULL, NULL, NULL, NULL); channel->ctx = ctx; - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), true, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, xen_device_event, NULL, xen_device_poll, NULL, channel); } @@ -920,7 +920,7 @@ void xen_device_unbind_event_channel(XenDevice *xendev, QLIST_REMOVE(channel, list); - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), true, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, NULL, NULL, NULL, NULL, NULL); if (qemu_xen_evtchn_unbind(channel->xeh, channel->local_port) < 0) { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517557.803115 (Exim 4.92) (envelope-from ) id 1pjOwz-0006a7-W0; Mon, 03 Apr 2023 18:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517557.803115; Mon, 03 Apr 2023 18:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwz-0006ZY-Om; Mon, 03 Apr 2023 18:30:41 +0000 Received: by outflank-mailman (input) for mailman id 517557; Mon, 03 Apr 2023 18:30:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOwx-00058E-FX for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:39 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0980774-d24d-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 20:30:37 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-LlfGX1TgPQ-M7RE1UMTAgw-1; Mon, 03 Apr 2023 14:30:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 408E3101A551; Mon, 3 Apr 2023 18:30:27 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B806140EBF4; Mon, 3 Apr 2023 18:30:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0980774-d24d-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hEwtCA8s9JuIEhTUsGQuJCNn3dK7Smgq43ityTlAMA0=; b=Xcp4WtcqbfNKMOakkTqb4qmt7Tm+ZsvjLsYs4l1qKl45bB3w/KSqrfXNUWwmk0tydT95ez Ltj8xIHGvxr0HOvGhFmmFFc1PbDlC/PZCR7ZjmVwU4UszcBPcMRVWP1b7eJ0/iF2NB1l7e zSUfRYz8Svn4VgimrgfHMFDLwZY6H/E= X-MC-Unique: LlfGX1TgPQ-M7RE1UMTAgw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 07/13] virtio: do not set is_external=true on host notifiers Date: Mon, 3 Apr 2023 14:29:58 -0400 Message-Id: <20230403183004.347205-8-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Host notifiers trigger virtqueue processing. There are critical sections when new I/O requests must not be submitted because they would cause interference. In the past this was solved using aio_set_event_notifiers() is_external=true argument, which disables fd monitoring between aio_disable/enable_external() calls. This API is not multi-queue block layer friendly because it requires knowledge of the specific AioContext. In a multi-queue block layer world any thread can submit I/O and we don't know which AioContexts are currently involved. virtio-blk and virtio-scsi are the only users that depend on is_external=true. Both rely on the block layer, where we can take advantage of the existing request queuing behavior that happens during drained sections. The block layer's drained sections are the only user of aio_disable_external(). After this patch the virtqueues will be processed during drained section, but submitted I/O requests will be queued in the BlockBackend. Queued requests are resumed when the drained section ends. Therefore, the BlockBackend is still quiesced during drained sections but we no longer rely on is_external=true to achieve this. Note that virtqueues have a finite size, so queuing requests does not lead to unbounded memory usage. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 98c4819fcc..dcd7aabb4e 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3491,7 +3491,7 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n) void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, true, + aio_set_event_notifier(ctx, &vq->host_notifier, false, virtio_queue_host_notifier_read, virtio_queue_host_notifier_aio_poll, virtio_queue_host_notifier_aio_poll_ready); @@ -3508,14 +3508,14 @@ void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) */ void virtio_queue_aio_attach_host_notifier_no_poll(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, true, + aio_set_event_notifier(ctx, &vq->host_notifier, false, virtio_queue_host_notifier_read, NULL, NULL); } void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL); + aio_set_event_notifier(ctx, &vq->host_notifier, false, NULL, NULL, NULL); /* Test and clear notifier before after disabling event, * in case poll callback didn't have time to run. */ virtio_queue_host_notifier_read(&vq->host_notifier); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517558.803130 (Exim 4.92) (envelope-from ) id 1pjOx4-0007G8-Fj; Mon, 03 Apr 2023 18:30:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517558.803130; Mon, 03 Apr 2023 18:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOx4-0007Fn-6f; Mon, 03 Apr 2023 18:30:46 +0000 Received: by outflank-mailman (input) for mailman id 517558; Mon, 03 Apr 2023 18:30:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOx2-00058E-7u for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:44 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a36de5a6-d24d-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 20:30:42 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-fKluM2IgOGOWbZExTvDE9Q-1; Mon, 03 Apr 2023 14:30:35 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9501101A553; Mon, 3 Apr 2023 18:30:34 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B0242166B26; Mon, 3 Apr 2023 18:30:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a36de5a6-d24d-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvgpibm7uG8By4vHBOsqesPFxvQEinDBgjjk4WE12qY=; b=cTWL+vRTyf9kGd0m6cmuoYc28Vx4UD7RwyLLvHzchBpGTT6VkoKaph4sD/+9WbPPGqreUG HCgnsRbV04m6H4h/FQpiR1YRVXVZL8NIicSIlgSDu1NpgjqfkBkya7EPsSs7l9zif+b+or tik5MuKYVOOWWM18/47bXu0Dt7FWMqQ= X-MC-Unique: fKluM2IgOGOWbZExTvDE9Q-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 10/13] block/export: rewrite vduse-blk drain code Date: Mon, 3 Apr 2023 14:30:01 -0400 Message-Id: <20230403183004.347205-11-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 vduse_blk_detach_ctx() waits for in-flight requests using AIO_WAIT_WHILE(). This is not allowed according to a comment in bdrv_set_aio_context_commit(): /* * Take the old AioContex when detaching it from bs. * At this point, new_context lock is already acquired, and we are now * also taking old_context. This is safe as long as bdrv_detach_aio_context * does not call AIO_POLL_WHILE(). */ Use this opportunity to rewrite the drain code in vduse-blk: - Use the BlockExport refcount so that vduse_blk_exp_delete() is only called when there are no more requests in flight. - Implement .drained_poll() so in-flight request coroutines are stopped by the time .bdrv_detach_aio_context() is called. - Remove AIO_WAIT_WHILE() from vduse_blk_detach_ctx() to solve the .bdrv_detach_aio_context() constraint violation. It's no longer needed due to the previous changes. - Always handle the VDUSE file descriptor, even in drained sections. The VDUSE file descriptor doesn't submit I/O, so it's safe to handle it in drained sections. This ensures that the VDUSE kernel code gets a fast response. - Suspend virtqueue fd handlers in .drained_begin() and resume them in .drained_end(). This eliminates the need for the aio_set_fd_handler(is_external=true) flag, which is being removed from QEMU. This is a long list but splitting it into individual commits would probably lead to git bisect failures - the changes are all related. Signed-off-by: Stefan Hajnoczi --- block/export/vduse-blk.c | 132 +++++++++++++++++++++++++++------------ 1 file changed, 93 insertions(+), 39 deletions(-) diff --git a/block/export/vduse-blk.c b/block/export/vduse-blk.c index f7ae44e3ce..35dc8fcf45 100644 --- a/block/export/vduse-blk.c +++ b/block/export/vduse-blk.c @@ -31,7 +31,8 @@ typedef struct VduseBlkExport { VduseDev *dev; uint16_t num_queues; char *recon_file; - unsigned int inflight; + unsigned int inflight; /* atomic */ + bool vqs_started; } VduseBlkExport; typedef struct VduseBlkReq { @@ -41,13 +42,24 @@ typedef struct VduseBlkReq { static void vduse_blk_inflight_inc(VduseBlkExport *vblk_exp) { - vblk_exp->inflight++; + if (qatomic_fetch_inc(&vblk_exp->inflight) == 0) { + /* Prevent export from being deleted */ + aio_context_acquire(vblk_exp->export.ctx); + blk_exp_ref(&vblk_exp->export); + aio_context_release(vblk_exp->export.ctx); + } } static void vduse_blk_inflight_dec(VduseBlkExport *vblk_exp) { - if (--vblk_exp->inflight == 0) { + if (qatomic_fetch_dec(&vblk_exp->inflight) == 1) { + /* Wake AIO_WAIT_WHILE() */ aio_wait_kick(); + + /* Now the export can be deleted */ + aio_context_acquire(vblk_exp->export.ctx); + blk_exp_unref(&vblk_exp->export); + aio_context_release(vblk_exp->export.ctx); } } @@ -124,8 +136,12 @@ static void vduse_blk_enable_queue(VduseDev *dev, VduseVirtq *vq) { VduseBlkExport *vblk_exp = vduse_dev_get_priv(dev); + if (!vblk_exp->vqs_started) { + return; /* vduse_blk_drained_end() will start vqs later */ + } + aio_set_fd_handler(vblk_exp->export.ctx, vduse_queue_get_fd(vq), - true, on_vduse_vq_kick, NULL, NULL, NULL, vq); + false, on_vduse_vq_kick, NULL, NULL, NULL, vq); /* Make sure we don't miss any kick afer reconnecting */ eventfd_write(vduse_queue_get_fd(vq), 1); } @@ -133,9 +149,14 @@ static void vduse_blk_enable_queue(VduseDev *dev, VduseVirtq *vq) static void vduse_blk_disable_queue(VduseDev *dev, VduseVirtq *vq) { VduseBlkExport *vblk_exp = vduse_dev_get_priv(dev); + int fd = vduse_queue_get_fd(vq); - aio_set_fd_handler(vblk_exp->export.ctx, vduse_queue_get_fd(vq), - true, NULL, NULL, NULL, NULL, NULL); + if (fd < 0) { + return; + } + + aio_set_fd_handler(vblk_exp->export.ctx, fd, false, + NULL, NULL, NULL, NULL, NULL); } static const VduseOps vduse_blk_ops = { @@ -152,42 +173,19 @@ static void on_vduse_dev_kick(void *opaque) static void vduse_blk_attach_ctx(VduseBlkExport *vblk_exp, AioContext *ctx) { - int i; - aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - true, on_vduse_dev_kick, NULL, NULL, NULL, + false, on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); - for (i = 0; i < vblk_exp->num_queues; i++) { - VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); - int fd = vduse_queue_get_fd(vq); - - if (fd < 0) { - continue; - } - aio_set_fd_handler(vblk_exp->export.ctx, fd, true, - on_vduse_vq_kick, NULL, NULL, NULL, vq); - } + /* Virtqueues are handled by vduse_blk_drained_end() */ } static void vduse_blk_detach_ctx(VduseBlkExport *vblk_exp) { - int i; - - for (i = 0; i < vblk_exp->num_queues; i++) { - VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); - int fd = vduse_queue_get_fd(vq); - - if (fd < 0) { - continue; - } - aio_set_fd_handler(vblk_exp->export.ctx, fd, - true, NULL, NULL, NULL, NULL, NULL); - } aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - true, NULL, NULL, NULL, NULL, NULL); + false, NULL, NULL, NULL, NULL, NULL); - AIO_WAIT_WHILE(vblk_exp->export.ctx, vblk_exp->inflight > 0); + /* Virtqueues are handled by vduse_blk_drained_begin() */ } @@ -220,8 +218,55 @@ static void vduse_blk_resize(void *opaque) (char *)&config.capacity); } +static void vduse_blk_stop_virtqueues(VduseBlkExport *vblk_exp) +{ + for (uint16_t i = 0; i < vblk_exp->num_queues; i++) { + VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); + vduse_blk_disable_queue(vblk_exp->dev, vq); + } + + vblk_exp->vqs_started = false; +} + +static void vduse_blk_start_virtqueues(VduseBlkExport *vblk_exp) +{ + vblk_exp->vqs_started = true; + + for (uint16_t i = 0; i < vblk_exp->num_queues; i++) { + VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); + vduse_blk_enable_queue(vblk_exp->dev, vq); + } +} + +static void vduse_blk_drained_begin(void *opaque) +{ + BlockExport *exp = opaque; + VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); + + vduse_blk_stop_virtqueues(vblk_exp); +} + +static void vduse_blk_drained_end(void *opaque) +{ + BlockExport *exp = opaque; + VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); + + vduse_blk_start_virtqueues(vblk_exp); +} + +static bool vduse_blk_drained_poll(void *opaque) +{ + BlockExport *exp = opaque; + VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); + + return qatomic_read(&vblk_exp->inflight) > 0; +} + static const BlockDevOps vduse_block_ops = { - .resize_cb = vduse_blk_resize, + .resize_cb = vduse_blk_resize, + .drained_begin = vduse_blk_drained_begin, + .drained_end = vduse_blk_drained_end, + .drained_poll = vduse_blk_drained_poll, }; static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, @@ -268,6 +313,7 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vblk_exp->handler.serial = g_strdup(vblk_opts->serial ?: ""); vblk_exp->handler.logical_block_size = logical_block_size; vblk_exp->handler.writable = opts->writable; + vblk_exp->vqs_started = true; config.capacity = cpu_to_le64(blk_getlength(exp->blk) >> VIRTIO_BLK_SECTOR_BITS); @@ -322,14 +368,20 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vduse_dev_setup_queue(vblk_exp->dev, i, queue_size); } - aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), true, + aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), false, on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vblk_exp); - blk_set_dev_ops(exp->blk, &vduse_block_ops, exp); + /* + * We handle draining ourselves using an in-flight counter and by disabling + * virtqueue fd handlers. Do not queue BlockBackend requests, they need to + * complete so the in-flight counter reaches zero. + */ + blk_set_disable_request_queuing(exp->blk, true); + return 0; err: vduse_dev_destroy(vblk_exp->dev); @@ -344,6 +396,9 @@ static void vduse_blk_exp_delete(BlockExport *exp) VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); int ret; + assert(qatomic_read(&vblk_exp->inflight) == 0); + + vduse_blk_detach_ctx(vblk_exp); blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vblk_exp); blk_set_dev_ops(exp->blk, NULL, NULL); @@ -355,13 +410,12 @@ static void vduse_blk_exp_delete(BlockExport *exp) g_free(vblk_exp->handler.serial); } +/* Called with exp->ctx acquired */ static void vduse_blk_exp_request_shutdown(BlockExport *exp) { VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); - aio_context_acquire(vblk_exp->export.ctx); - vduse_blk_detach_ctx(vblk_exp); - aio_context_acquire(vblk_exp->export.ctx); + vduse_blk_stop_virtqueues(vblk_exp); } const BlockExportDriver blk_exp_vduse_blk = { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517559.803138 (Exim 4.92) (envelope-from ) id 1pjOx6-0007j5-7m; Mon, 03 Apr 2023 18:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517559.803138; Mon, 03 Apr 2023 18:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOx6-0007hW-0C; Mon, 03 Apr 2023 18:30:48 +0000 Received: by outflank-mailman (input) for mailman id 517559; Mon, 03 Apr 2023 18:30:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOx4-0004HH-KI for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:46 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a580eb64-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:46 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-LcBnC9OFNAS0HwwcyCiR0g-1; Mon, 03 Apr 2023 14:30:41 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A154885A5B1; Mon, 3 Apr 2023 18:30:39 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 062F21121314; Mon, 3 Apr 2023 18:30:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a580eb64-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9pwn7OV2gNoHAp8haSXqR0tkaO5uu/ou2YhRF+j7lsw=; b=ZNlbdW6cE/ITRX9LLxw3u14JWZGqJgNuahR70l+HYnq3NDX7c4jb3ehsLSIxBovKHoi1l7 dER6Akem132n0C2X3TtxRgOWSB1mmc6ErOI5tMhLivYCLNp4hM/QJnAeZ8IhRfsXCgE70B FFXOFexhjwfdYk9OaoXJeJvCKYesiew= X-MC-Unique: LcBnC9OFNAS0HwwcyCiR0g-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 12/13] block/fuse: do not set is_external=true on FUSE fd Date: Mon, 3 Apr 2023 14:30:03 -0400 Message-Id: <20230403183004.347205-13-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 This is part of ongoing work to remove the aio_disable_external() API. Use BlockDevOps .drained_begin/end/poll() instead of aio_set_fd_handler(is_external=true). As a side-effect the FUSE export now follows AioContext changes like the other export types. Signed-off-by: Stefan Hajnoczi --- block/export/fuse.c | 58 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git a/block/export/fuse.c b/block/export/fuse.c index 18394f9e07..83bccf046b 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -50,6 +50,7 @@ typedef struct FuseExport { struct fuse_session *fuse_session; struct fuse_buf fuse_buf; + unsigned int in_flight; /* atomic */ bool mounted, fd_handler_set_up; char *mountpoint; @@ -78,6 +79,42 @@ static void read_from_fuse_export(void *opaque); static bool is_regular_file(const char *path, Error **errp); +static void fuse_export_drained_begin(void *opaque) +{ + FuseExport *exp = opaque; + + aio_set_fd_handler(exp->common.ctx, + fuse_session_fd(exp->fuse_session), false, + NULL, NULL, NULL, NULL, NULL); + exp->fd_handler_set_up = false; +} + +static void fuse_export_drained_end(void *opaque) +{ + FuseExport *exp = opaque; + + /* Refresh AioContext in case it changed */ + exp->common.ctx = blk_get_aio_context(exp->common.blk); + + aio_set_fd_handler(exp->common.ctx, + fuse_session_fd(exp->fuse_session), false, + read_from_fuse_export, NULL, NULL, NULL, exp); + exp->fd_handler_set_up = true; +} + +static bool fuse_export_drained_poll(void *opaque) +{ + FuseExport *exp = opaque; + + return qatomic_read(&exp->in_flight) > 0; +} + +static const BlockDevOps fuse_export_blk_dev_ops = { + .drained_begin = fuse_export_drained_begin, + .drained_end = fuse_export_drained_end, + .drained_poll = fuse_export_drained_poll, +}; + static int fuse_export_create(BlockExport *blk_exp, BlockExportOptions *blk_exp_args, Error **errp) @@ -101,6 +138,15 @@ static int fuse_export_create(BlockExport *blk_exp, } } + blk_set_dev_ops(exp->common.blk, &fuse_export_blk_dev_ops, exp); + + /* + * We handle draining ourselves using an in-flight counter and by disabling + * the FUSE fd handler. Do not queue BlockBackend requests, they need to + * complete so the in-flight counter reaches zero. + */ + blk_set_disable_request_queuing(exp->common.blk, true); + init_exports_table(); /* @@ -224,7 +270,7 @@ static int setup_fuse_export(FuseExport *exp, const char *mountpoint, g_hash_table_insert(exports, g_strdup(mountpoint), NULL); aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), true, + fuse_session_fd(exp->fuse_session), false, read_from_fuse_export, NULL, NULL, NULL, exp); exp->fd_handler_set_up = true; @@ -248,6 +294,8 @@ static void read_from_fuse_export(void *opaque) blk_exp_ref(&exp->common); aio_context_release(exp->common.ctx); + qatomic_inc(&exp->in_flight); + do { ret = fuse_session_receive_buf(exp->fuse_session, &exp->fuse_buf); } while (ret == -EINTR); @@ -258,6 +306,10 @@ static void read_from_fuse_export(void *opaque) fuse_session_process_buf(exp->fuse_session, &exp->fuse_buf); out: + if (qatomic_fetch_dec(&exp->in_flight) == 1) { + aio_wait_kick(); /* wake AIO_WAIT_WHILE() */ + } + aio_context_acquire(exp->common.ctx); blk_exp_unref(&exp->common); aio_context_release(exp->common.ctx); @@ -272,7 +324,7 @@ static void fuse_export_shutdown(BlockExport *blk_exp) if (exp->fd_handler_set_up) { aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), true, + fuse_session_fd(exp->fuse_session), false, NULL, NULL, NULL, NULL, NULL); exp->fd_handler_set_up = false; } @@ -291,6 +343,8 @@ static void fuse_export_delete(BlockExport *blk_exp) { FuseExport *exp = container_of(blk_exp, FuseExport, common); + blk_set_dev_ops(exp->common.blk, NULL, NULL); + if (exp->fuse_session) { if (exp->mounted) { fuse_session_unmount(exp->fuse_session); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:30:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:30:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517560.803149 (Exim 4.92) (envelope-from ) id 1pjOxA-0008VW-MY; Mon, 03 Apr 2023 18:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517560.803149; Mon, 03 Apr 2023 18:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOxA-0008Sh-IR; Mon, 03 Apr 2023 18:30:52 +0000 Received: by outflank-mailman (input) for mailman id 517560; Mon, 03 Apr 2023 18:30:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjOx8-0004HH-IU for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:30:50 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7013ff6-d24d-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:30:48 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-vCApPF78Ozqd8fbf0y-d6A-1; Mon, 03 Apr 2023 14:30:44 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25B603C20EE6; Mon, 3 Apr 2023 18:30:43 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id D84B140C83A9; Mon, 3 Apr 2023 18:30:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7013ff6-d24d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LN11HOmb2+zF0uNZ22EvLdu7DtwYKh88e9e0E+eLcmM=; b=gL14HbSADW2gwQ0ncwOvH5wYgDWFBpRpxmyqosZ/+uVGw/TZE28V0W2Jn2YIf2PY76nALb EKVCVkxs4/ED5laBfU9NgCHe7ys10tvVFA++F/J8rkVXr4GaN9LHljVViYQjheFKuRFT5J X5FdIokvqMciwcgfAbYGc7KZr8UJyWs= X-MC-Unique: vCApPF78Ozqd8fbf0y-d6A-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 13/13] aio: remove aio_disable_external() API Date: Mon, 3 Apr 2023 14:30:04 -0400 Message-Id: <20230403183004.347205-14-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(), aio_enable_external(), and the is_external arguments to aio_set_fd_handler() and aio_set_event_notifier(). The entire test-fdmon-epoll test is removed because its sole purpose was testing aio_disable_external(). Parts of this patch were generated using the following coccinelle (https://coccinelle.lip6.fr/) semantic patch: @@ expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; @@ - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) @@ expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; @@ - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) Signed-off-by: Stefan Hajnoczi --- include/block/aio.h | 55 -------------------------- util/aio-posix.h | 1 - block.c | 7 ---- block/blkio.c | 15 +++---- block/curl.c | 10 ++--- block/export/fuse.c | 8 ++-- block/export/vduse-blk.c | 10 ++--- block/io.c | 2 - block/io_uring.c | 4 +- block/iscsi.c | 3 +- block/linux-aio.c | 4 +- block/nfs.c | 5 +-- block/nvme.c | 8 ++-- block/ssh.c | 4 +- block/win32-aio.c | 6 +-- hw/i386/kvm/xen_xenstore.c | 2 +- hw/virtio/virtio.c | 6 +-- hw/xen/xen-bus.c | 6 +-- io/channel-command.c | 6 +-- io/channel-file.c | 3 +- io/channel-socket.c | 3 +- migration/rdma.c | 16 ++++---- tests/unit/test-aio.c | 27 +------------ tests/unit/test-fdmon-epoll.c | 73 ----------------------------------- util/aio-posix.c | 20 +++------- util/aio-win32.c | 8 +--- util/async.c | 3 +- util/fdmon-epoll.c | 10 ----- util/fdmon-io_uring.c | 8 +--- util/fdmon-poll.c | 3 +- util/main-loop.c | 7 ++-- util/qemu-coroutine-io.c | 7 ++-- util/vhost-user-server.c | 11 +++--- tests/unit/meson.build | 3 -- 34 files changed, 75 insertions(+), 289 deletions(-) delete mode 100644 tests/unit/test-fdmon-epoll.c diff --git a/include/block/aio.h b/include/block/aio.h index e267d918fd..d4ce01ea08 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -467,7 +467,6 @@ bool aio_poll(AioContext *ctx, bool blocking); */ void aio_set_fd_handler(AioContext *ctx, int fd, - bool is_external, IOHandler *io_read, IOHandler *io_write, AioPollFn *io_poll, @@ -483,7 +482,6 @@ void aio_set_fd_handler(AioContext *ctx, */ void aio_set_event_notifier(AioContext *ctx, EventNotifier *notifier, - bool is_external, EventNotifierHandler *io_read, AioPollFn *io_poll, EventNotifierHandler *io_poll_ready); @@ -612,59 +610,6 @@ static inline void aio_timer_init(AioContext *ctx, */ int64_t aio_compute_timeout(AioContext *ctx); -/** - * aio_disable_external: - * @ctx: the aio context - * - * Disable the further processing of external clients. - */ -static inline void aio_disable_external(AioContext *ctx) -{ - qatomic_inc(&ctx->external_disable_cnt); -} - -/** - * aio_enable_external: - * @ctx: the aio context - * - * Enable the processing of external clients. - */ -static inline void aio_enable_external(AioContext *ctx) -{ - int old; - - old = qatomic_fetch_dec(&ctx->external_disable_cnt); - assert(old > 0); - if (old == 1) { - /* Kick event loop so it re-arms file descriptors */ - aio_notify(ctx); - } -} - -/** - * aio_external_disabled: - * @ctx: the aio context - * - * Return true if the external clients are disabled. - */ -static inline bool aio_external_disabled(AioContext *ctx) -{ - return qatomic_read(&ctx->external_disable_cnt); -} - -/** - * aio_node_check: - * @ctx: the aio context - * @is_external: Whether or not the checked node is an external event source. - * - * Check if the node's is_external flag is okay to be polled by the ctx at this - * moment. True means green light. - */ -static inline bool aio_node_check(AioContext *ctx, bool is_external) -{ - return !is_external || !qatomic_read(&ctx->external_disable_cnt); -} - /** * aio_co_schedule: * @ctx: the aio context diff --git a/util/aio-posix.h b/util/aio-posix.h index 80b927c7f4..4264c518be 100644 --- a/util/aio-posix.h +++ b/util/aio-posix.h @@ -38,7 +38,6 @@ struct AioHandler { #endif int64_t poll_idle_timeout; /* when to stop userspace polling */ bool poll_ready; /* has polling detected an event? */ - bool is_external; }; /* Add a handler to a ready list */ diff --git a/block.c b/block.c index a79297f99b..e9625ffeee 100644 --- a/block.c +++ b/block.c @@ -7254,9 +7254,6 @@ static void bdrv_detach_aio_context(BlockDriverState *bs) bs->drv->bdrv_detach_aio_context(bs); } - if (bs->quiesce_counter) { - aio_enable_external(bs->aio_context); - } bs->aio_context = NULL; } @@ -7266,10 +7263,6 @@ static void bdrv_attach_aio_context(BlockDriverState *bs, BdrvAioNotifier *ban, *ban_tmp; GLOBAL_STATE_CODE(); - if (bs->quiesce_counter) { - aio_disable_external(new_context); - } - bs->aio_context = new_context; if (bs->drv && bs->drv->bdrv_attach_aio_context) { diff --git a/block/blkio.c b/block/blkio.c index 0cdc99a729..72117fa005 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -306,23 +306,18 @@ static void blkio_attach_aio_context(BlockDriverState *bs, { BDRVBlkioState *s = bs->opaque; - aio_set_fd_handler(new_context, - s->completion_fd, - false, - blkio_completion_fd_read, - NULL, + aio_set_fd_handler(new_context, s->completion_fd, + blkio_completion_fd_read, NULL, blkio_completion_fd_poll, - blkio_completion_fd_poll_ready, - bs); + blkio_completion_fd_poll_ready, bs); } static void blkio_detach_aio_context(BlockDriverState *bs) { BDRVBlkioState *s = bs->opaque; - aio_set_fd_handler(bdrv_get_aio_context(bs), - s->completion_fd, - false, NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(bdrv_get_aio_context(bs), s->completion_fd, NULL, NULL, + NULL, NULL, NULL); } /* Call with s->blkio_lock held to submit I/O after enqueuing a new request */ diff --git a/block/curl.c b/block/curl.c index 8bb39a134e..0fc42d03d7 100644 --- a/block/curl.c +++ b/block/curl.c @@ -132,7 +132,7 @@ static gboolean curl_drop_socket(void *key, void *value, void *opaque) CURLSocket *socket = value; BDRVCURLState *s = socket->s; - aio_set_fd_handler(s->aio_context, socket->fd, false, + aio_set_fd_handler(s->aio_context, socket->fd, NULL, NULL, NULL, NULL, NULL); return true; } @@ -180,20 +180,20 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action, trace_curl_sock_cb(action, (int)fd); switch (action) { case CURL_POLL_IN: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, curl_multi_do, NULL, NULL, NULL, socket); break; case CURL_POLL_OUT: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, NULL, curl_multi_do, NULL, NULL, socket); break; case CURL_POLL_INOUT: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, curl_multi_do, curl_multi_do, NULL, NULL, socket); break; case CURL_POLL_REMOVE: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, NULL, NULL, NULL, NULL, NULL); break; } diff --git a/block/export/fuse.c b/block/export/fuse.c index 83bccf046b..9d4c6c4dee 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -84,7 +84,7 @@ static void fuse_export_drained_begin(void *opaque) FuseExport *exp = opaque; aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), NULL, NULL, NULL, NULL, NULL); exp->fd_handler_set_up = false; } @@ -97,7 +97,7 @@ static void fuse_export_drained_end(void *opaque) exp->common.ctx = blk_get_aio_context(exp->common.blk); aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), read_from_fuse_export, NULL, NULL, NULL, exp); exp->fd_handler_set_up = true; } @@ -270,7 +270,7 @@ static int setup_fuse_export(FuseExport *exp, const char *mountpoint, g_hash_table_insert(exports, g_strdup(mountpoint), NULL); aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), read_from_fuse_export, NULL, NULL, NULL, exp); exp->fd_handler_set_up = true; @@ -324,7 +324,7 @@ static void fuse_export_shutdown(BlockExport *blk_exp) if (exp->fd_handler_set_up) { aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), NULL, NULL, NULL, NULL, NULL); exp->fd_handler_set_up = false; } diff --git a/block/export/vduse-blk.c b/block/export/vduse-blk.c index 35dc8fcf45..94e2491e4a 100644 --- a/block/export/vduse-blk.c +++ b/block/export/vduse-blk.c @@ -141,7 +141,7 @@ static void vduse_blk_enable_queue(VduseDev *dev, VduseVirtq *vq) } aio_set_fd_handler(vblk_exp->export.ctx, vduse_queue_get_fd(vq), - false, on_vduse_vq_kick, NULL, NULL, NULL, vq); + on_vduse_vq_kick, NULL, NULL, NULL, vq); /* Make sure we don't miss any kick afer reconnecting */ eventfd_write(vduse_queue_get_fd(vq), 1); } @@ -155,7 +155,7 @@ static void vduse_blk_disable_queue(VduseDev *dev, VduseVirtq *vq) return; } - aio_set_fd_handler(vblk_exp->export.ctx, fd, false, + aio_set_fd_handler(vblk_exp->export.ctx, fd, NULL, NULL, NULL, NULL, NULL); } @@ -174,7 +174,7 @@ static void on_vduse_dev_kick(void *opaque) static void vduse_blk_attach_ctx(VduseBlkExport *vblk_exp, AioContext *ctx) { aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - false, on_vduse_dev_kick, NULL, NULL, NULL, + on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); /* Virtqueues are handled by vduse_blk_drained_end() */ @@ -183,7 +183,7 @@ static void vduse_blk_attach_ctx(VduseBlkExport *vblk_exp, AioContext *ctx) static void vduse_blk_detach_ctx(VduseBlkExport *vblk_exp) { aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); /* Virtqueues are handled by vduse_blk_drained_begin() */ } @@ -368,7 +368,7 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vduse_dev_setup_queue(vblk_exp->dev, i, queue_size); } - aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), false, + aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, diff --git a/block/io.c b/block/io.c index db438c7657..5b0b126422 100644 --- a/block/io.c +++ b/block/io.c @@ -356,7 +356,6 @@ static void bdrv_do_drained_begin(BlockDriverState *bs, BdrvChild *parent, /* Stop things in parent-to-child order */ if (qatomic_fetch_inc(&bs->quiesce_counter) == 0) { - aio_disable_external(bdrv_get_aio_context(bs)); bdrv_parent_drained_begin(bs, parent); if (bs->drv && bs->drv->bdrv_drain_begin) { bs->drv->bdrv_drain_begin(bs); @@ -409,7 +408,6 @@ static void bdrv_do_drained_end(BlockDriverState *bs, BdrvChild *parent) bs->drv->bdrv_drain_end(bs); } bdrv_parent_drained_end(bs, parent); - aio_enable_external(bdrv_get_aio_context(bs)); } } diff --git a/block/io_uring.c b/block/io_uring.c index 989f9a99ed..b64a3e6285 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -406,7 +406,7 @@ int coroutine_fn luring_co_submit(BlockDriverState *bs, int fd, uint64_t offset, void luring_detach_aio_context(LuringState *s, AioContext *old_context) { - aio_set_fd_handler(old_context, s->ring.ring_fd, false, + aio_set_fd_handler(old_context, s->ring.ring_fd, NULL, NULL, NULL, NULL, s); qemu_bh_delete(s->completion_bh); s->aio_context = NULL; @@ -416,7 +416,7 @@ void luring_attach_aio_context(LuringState *s, AioContext *new_context) { s->aio_context = new_context; s->completion_bh = aio_bh_new(new_context, qemu_luring_completion_bh, s); - aio_set_fd_handler(s->aio_context, s->ring.ring_fd, false, + aio_set_fd_handler(s->aio_context, s->ring.ring_fd, qemu_luring_completion_cb, NULL, qemu_luring_poll_cb, qemu_luring_poll_ready, s); } diff --git a/block/iscsi.c b/block/iscsi.c index 9fc0bed90b..34f97ab646 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -363,7 +363,6 @@ iscsi_set_events(IscsiLun *iscsilun) if (ev != iscsilun->events) { aio_set_fd_handler(iscsilun->aio_context, iscsi_get_fd(iscsi), - false, (ev & POLLIN) ? iscsi_process_read : NULL, (ev & POLLOUT) ? iscsi_process_write : NULL, NULL, NULL, @@ -1540,7 +1539,7 @@ static void iscsi_detach_aio_context(BlockDriverState *bs) IscsiLun *iscsilun = bs->opaque; aio_set_fd_handler(iscsilun->aio_context, iscsi_get_fd(iscsilun->iscsi), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); iscsilun->events = 0; if (iscsilun->nop_timer) { diff --git a/block/linux-aio.c b/block/linux-aio.c index fc50cdd1bf..129908531a 100644 --- a/block/linux-aio.c +++ b/block/linux-aio.c @@ -443,7 +443,7 @@ int coroutine_fn laio_co_submit(int fd, uint64_t offset, QEMUIOVector *qiov, void laio_detach_aio_context(LinuxAioState *s, AioContext *old_context) { - aio_set_event_notifier(old_context, &s->e, false, NULL, NULL, NULL); + aio_set_event_notifier(old_context, &s->e, NULL, NULL, NULL); qemu_bh_delete(s->completion_bh); s->aio_context = NULL; } @@ -452,7 +452,7 @@ void laio_attach_aio_context(LinuxAioState *s, AioContext *new_context) { s->aio_context = new_context; s->completion_bh = aio_bh_new(new_context, qemu_laio_completion_bh, s); - aio_set_event_notifier(new_context, &s->e, false, + aio_set_event_notifier(new_context, &s->e, qemu_laio_completion_cb, qemu_laio_poll_cb, qemu_laio_poll_ready); diff --git a/block/nfs.c b/block/nfs.c index 351dc6ec8d..2f603bba42 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -195,7 +195,6 @@ static void nfs_set_events(NFSClient *client) int ev = nfs_which_events(client->context); if (ev != client->events) { aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context), - false, (ev & POLLIN) ? nfs_process_read : NULL, (ev & POLLOUT) ? nfs_process_write : NULL, NULL, NULL, client); @@ -373,7 +372,7 @@ static void nfs_detach_aio_context(BlockDriverState *bs) NFSClient *client = bs->opaque; aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); client->events = 0; } @@ -391,7 +390,7 @@ static void nfs_client_close(NFSClient *client) if (client->context) { qemu_mutex_lock(&client->mutex); aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); qemu_mutex_unlock(&client->mutex); if (client->fh) { nfs_close(client->context, client->fh); diff --git a/block/nvme.c b/block/nvme.c index 5b744c2bda..17937d398d 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -862,7 +862,7 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace, } aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, nvme_handle_event, nvme_poll_cb, + nvme_handle_event, nvme_poll_cb, nvme_poll_ready); if (!nvme_identify(bs, namespace, errp)) { @@ -948,7 +948,7 @@ static void nvme_close(BlockDriverState *bs) g_free(s->queues); aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, NULL, NULL, NULL); + NULL, NULL, NULL); event_notifier_cleanup(&s->irq_notifier[MSIX_SHARED_IRQ_IDX]); qemu_vfio_pci_unmap_bar(s->vfio, 0, s->bar0_wo_map, 0, sizeof(NvmeBar) + NVME_DOORBELL_SIZE); @@ -1546,7 +1546,7 @@ static void nvme_detach_aio_context(BlockDriverState *bs) aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, NULL, NULL, NULL); + NULL, NULL, NULL); } static void nvme_attach_aio_context(BlockDriverState *bs, @@ -1556,7 +1556,7 @@ static void nvme_attach_aio_context(BlockDriverState *bs, s->aio_context = new_context; aio_set_event_notifier(new_context, &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, nvme_handle_event, nvme_poll_cb, + nvme_handle_event, nvme_poll_cb, nvme_poll_ready); for (unsigned i = 0; i < s->queue_count; i++) { diff --git a/block/ssh.c b/block/ssh.c index b3b3352075..2748253d4a 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -1019,7 +1019,7 @@ static void restart_coroutine(void *opaque) AioContext *ctx = bdrv_get_aio_context(bs); trace_ssh_restart_coroutine(restart->co); - aio_set_fd_handler(ctx, s->sock, false, NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(ctx, s->sock, NULL, NULL, NULL, NULL, NULL); aio_co_wake(restart->co); } @@ -1049,7 +1049,7 @@ static coroutine_fn void co_yield(BDRVSSHState *s, BlockDriverState *bs) trace_ssh_co_yield(s->sock, rd_handler, wr_handler); aio_set_fd_handler(bdrv_get_aio_context(bs), s->sock, - false, rd_handler, wr_handler, NULL, NULL, &restart); + rd_handler, wr_handler, NULL, NULL, &restart); qemu_coroutine_yield(); trace_ssh_co_yield_back(s->sock); } diff --git a/block/win32-aio.c b/block/win32-aio.c index ee87d6048f..6327861e1d 100644 --- a/block/win32-aio.c +++ b/block/win32-aio.c @@ -174,7 +174,7 @@ int win32_aio_attach(QEMUWin32AIOState *aio, HANDLE hfile) void win32_aio_detach_aio_context(QEMUWin32AIOState *aio, AioContext *old_context) { - aio_set_event_notifier(old_context, &aio->e, false, NULL, NULL, NULL); + aio_set_event_notifier(old_context, &aio->e, NULL, NULL, NULL); aio->aio_ctx = NULL; } @@ -182,8 +182,8 @@ void win32_aio_attach_aio_context(QEMUWin32AIOState *aio, AioContext *new_context) { aio->aio_ctx = new_context; - aio_set_event_notifier(new_context, &aio->e, false, - win32_aio_completion_cb, NULL, NULL); + aio_set_event_notifier(new_context, &aio->e, win32_aio_completion_cb, + NULL, NULL); } QEMUWin32AIOState *win32_aio_init(void) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 6e81bc8791..0b189c6ab8 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kvm/xen_xenstore.c @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error **errp) error_setg(errp, "Xenstore evtchn port init failed"); return; } - aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false, + aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), xen_xenstore_event, NULL, NULL, NULL, s); s->impl = xs_impl_create(xen_domid); diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index dcd7aabb4e..6125e4d556 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3491,7 +3491,7 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n) void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, false, + aio_set_event_notifier(ctx, &vq->host_notifier, virtio_queue_host_notifier_read, virtio_queue_host_notifier_aio_poll, virtio_queue_host_notifier_aio_poll_ready); @@ -3508,14 +3508,14 @@ void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) */ void virtio_queue_aio_attach_host_notifier_no_poll(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, false, + aio_set_event_notifier(ctx, &vq->host_notifier, virtio_queue_host_notifier_read, NULL, NULL); } void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, false, NULL, NULL, NULL); + aio_set_event_notifier(ctx, &vq->host_notifier, NULL, NULL, NULL); /* Test and clear notifier before after disabling event, * in case poll callback didn't have time to run. */ virtio_queue_host_notifier_read(&vq->host_notifier); diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index c4fd26abe1..7b5c338ea1 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -842,11 +842,11 @@ void xen_device_set_event_channel_context(XenDevice *xendev, } if (channel->ctx) - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), NULL, NULL, NULL, NULL, NULL); channel->ctx = ctx; - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), xen_device_event, NULL, xen_device_poll, NULL, channel); } @@ -920,7 +920,7 @@ void xen_device_unbind_event_channel(XenDevice *xendev, QLIST_REMOVE(channel, list); - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), NULL, NULL, NULL, NULL, NULL); if (qemu_xen_evtchn_unbind(channel->xeh, channel->local_port) < 0) { diff --git a/io/channel-command.c b/io/channel-command.c index e7edd091af..7ed726c802 100644 --- a/io/channel-command.c +++ b/io/channel-command.c @@ -337,10 +337,8 @@ static void qio_channel_command_set_aio_fd_handler(QIOChannel *ioc, void *opaque) { QIOChannelCommand *cioc = QIO_CHANNEL_COMMAND(ioc); - aio_set_fd_handler(ctx, cioc->readfd, false, - io_read, NULL, NULL, NULL, opaque); - aio_set_fd_handler(ctx, cioc->writefd, false, - NULL, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, cioc->readfd, io_read, NULL, NULL, NULL, opaque); + aio_set_fd_handler(ctx, cioc->writefd, NULL, io_write, NULL, NULL, opaque); } diff --git a/io/channel-file.c b/io/channel-file.c index d76663e6ae..8b5821f452 100644 --- a/io/channel-file.c +++ b/io/channel-file.c @@ -198,8 +198,7 @@ static void qio_channel_file_set_aio_fd_handler(QIOChannel *ioc, void *opaque) { QIOChannelFile *fioc = QIO_CHANNEL_FILE(ioc); - aio_set_fd_handler(ctx, fioc->fd, false, io_read, io_write, - NULL, NULL, opaque); + aio_set_fd_handler(ctx, fioc->fd, io_read, io_write, NULL, NULL, opaque); } static GSource *qio_channel_file_create_watch(QIOChannel *ioc, diff --git a/io/channel-socket.c b/io/channel-socket.c index b0ea7d48b3..d99945ebec 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -899,8 +899,7 @@ static void qio_channel_socket_set_aio_fd_handler(QIOChannel *ioc, void *opaque) { QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(ioc); - aio_set_fd_handler(ctx, sioc->fd, false, - io_read, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, sioc->fd, io_read, io_write, NULL, NULL, opaque); } static GSource *qio_channel_socket_create_watch(QIOChannel *ioc, diff --git a/migration/rdma.c b/migration/rdma.c index df646be35e..aee41ca43e 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -3104,15 +3104,15 @@ static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc, { QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc); if (io_read) { - aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); - aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); } else { - aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); - aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); } } diff --git a/tests/unit/test-aio.c b/tests/unit/test-aio.c index 321d7ab01a..519440eed3 100644 --- a/tests/unit/test-aio.c +++ b/tests/unit/test-aio.c @@ -130,7 +130,7 @@ static void *test_acquire_thread(void *opaque) static void set_event_notifier(AioContext *ctx, EventNotifier *notifier, EventNotifierHandler *handler) { - aio_set_event_notifier(ctx, notifier, false, handler, NULL, NULL); + aio_set_event_notifier(ctx, notifier, handler, NULL, NULL); } static void dummy_notifier_read(EventNotifier *n) @@ -383,30 +383,6 @@ static void test_flush_event_notifier(void) event_notifier_cleanup(&data.e); } -static void test_aio_external_client(void) -{ - int i, j; - - for (i = 1; i < 3; i++) { - EventNotifierTestData data = { .n = 0, .active = 10, .auto_set = true }; - event_notifier_init(&data.e, false); - aio_set_event_notifier(ctx, &data.e, true, event_ready_cb, NULL, NULL); - event_notifier_set(&data.e); - for (j = 0; j < i; j++) { - aio_disable_external(ctx); - } - for (j = 0; j < i; j++) { - assert(!aio_poll(ctx, false)); - assert(event_notifier_test_and_clear(&data.e)); - event_notifier_set(&data.e); - aio_enable_external(ctx); - } - assert(aio_poll(ctx, false)); - set_event_notifier(ctx, &data.e, NULL); - event_notifier_cleanup(&data.e); - } -} - static void test_wait_event_notifier_noflush(void) { EventNotifierTestData data = { .n = 0 }; @@ -935,7 +911,6 @@ int main(int argc, char **argv) g_test_add_func("/aio/event/wait", test_wait_event_notifier); g_test_add_func("/aio/event/wait/no-flush-cb", test_wait_event_notifier_noflush); g_test_add_func("/aio/event/flush", test_flush_event_notifier); - g_test_add_func("/aio/external-client", test_aio_external_client); g_test_add_func("/aio/timer/schedule", test_timer_schedule); g_test_add_func("/aio/coroutine/queue-chaining", test_queue_chaining); diff --git a/tests/unit/test-fdmon-epoll.c b/tests/unit/test-fdmon-epoll.c deleted file mode 100644 index ef5a856d09..0000000000 --- a/tests/unit/test-fdmon-epoll.c +++ /dev/null @@ -1,73 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - * fdmon-epoll tests - * - * Copyright (c) 2020 Red Hat, Inc. - */ - -#include "qemu/osdep.h" -#include "block/aio.h" -#include "qapi/error.h" -#include "qemu/main-loop.h" - -static AioContext *ctx; - -static void dummy_fd_handler(EventNotifier *notifier) -{ - event_notifier_test_and_clear(notifier); -} - -static void add_event_notifiers(EventNotifier *notifiers, size_t n) -{ - for (size_t i = 0; i < n; i++) { - event_notifier_init(¬ifiers[i], false); - aio_set_event_notifier(ctx, ¬ifiers[i], false, - dummy_fd_handler, NULL, NULL); - } -} - -static void remove_event_notifiers(EventNotifier *notifiers, size_t n) -{ - for (size_t i = 0; i < n; i++) { - aio_set_event_notifier(ctx, ¬ifiers[i], false, NULL, NULL, NULL); - event_notifier_cleanup(¬ifiers[i]); - } -} - -/* Check that fd handlers work when external clients are disabled */ -static void test_external_disabled(void) -{ - EventNotifier notifiers[100]; - - /* fdmon-epoll is only enabled when many fd handlers are registered */ - add_event_notifiers(notifiers, G_N_ELEMENTS(notifiers)); - - event_notifier_set(¬ifiers[0]); - assert(aio_poll(ctx, true)); - - aio_disable_external(ctx); - event_notifier_set(¬ifiers[0]); - assert(aio_poll(ctx, true)); - aio_enable_external(ctx); - - remove_event_notifiers(notifiers, G_N_ELEMENTS(notifiers)); -} - -int main(int argc, char **argv) -{ - /* - * This code relies on the fact that fdmon-io_uring disables itself when - * the glib main loop is in use. The main loop uses fdmon-poll and upgrades - * to fdmon-epoll when the number of fds exceeds a threshold. - */ - qemu_init_main_loop(&error_fatal); - ctx = qemu_get_aio_context(); - - while (g_main_context_iteration(NULL, false)) { - /* Do nothing */ - } - - g_test_init(&argc, &argv, NULL); - g_test_add_func("/fdmon-epoll/external-disabled", test_external_disabled); - return g_test_run(); -} diff --git a/util/aio-posix.c b/util/aio-posix.c index a8be940f76..934b1bbb85 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -99,7 +99,6 @@ static bool aio_remove_fd_handler(AioContext *ctx, AioHandler *node) void aio_set_fd_handler(AioContext *ctx, int fd, - bool is_external, IOHandler *io_read, IOHandler *io_write, AioPollFn *io_poll, @@ -144,7 +143,6 @@ void aio_set_fd_handler(AioContext *ctx, new_node->io_poll = io_poll; new_node->io_poll_ready = io_poll_ready; new_node->opaque = opaque; - new_node->is_external = is_external; if (is_new) { new_node->pfd.fd = fd; @@ -196,12 +194,11 @@ static void aio_set_fd_poll(AioContext *ctx, int fd, void aio_set_event_notifier(AioContext *ctx, EventNotifier *notifier, - bool is_external, EventNotifierHandler *io_read, AioPollFn *io_poll, EventNotifierHandler *io_poll_ready) { - aio_set_fd_handler(ctx, event_notifier_get_fd(notifier), is_external, + aio_set_fd_handler(ctx, event_notifier_get_fd(notifier), (IOHandler *)io_read, NULL, io_poll, (IOHandler *)io_poll_ready, notifier); } @@ -285,13 +282,11 @@ bool aio_pending(AioContext *ctx) /* TODO should this check poll ready? */ revents = node->pfd.revents & node->pfd.events; - if (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR) && node->io_read && - aio_node_check(ctx, node->is_external)) { + if (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR) && node->io_read) { result = true; break; } - if (revents & (G_IO_OUT | G_IO_ERR) && node->io_write && - aio_node_check(ctx, node->is_external)) { + if (revents & (G_IO_OUT | G_IO_ERR) && node->io_write) { result = true; break; } @@ -350,9 +345,7 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) QLIST_INSERT_HEAD(&ctx->poll_aio_handlers, node, node_poll); } if (!QLIST_IS_INSERTED(node, node_deleted) && - poll_ready && revents == 0 && - aio_node_check(ctx, node->is_external) && - node->io_poll_ready) { + poll_ready && revents == 0 && node->io_poll_ready) { node->io_poll_ready(node->opaque); /* @@ -364,7 +357,6 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) if (!QLIST_IS_INSERTED(node, node_deleted) && (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR)) && - aio_node_check(ctx, node->is_external) && node->io_read) { node->io_read(node->opaque); @@ -375,7 +367,6 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) } if (!QLIST_IS_INSERTED(node, node_deleted) && (revents & (G_IO_OUT | G_IO_ERR)) && - aio_node_check(ctx, node->is_external) && node->io_write) { node->io_write(node->opaque); progress = true; @@ -436,8 +427,7 @@ static bool run_poll_handlers_once(AioContext *ctx, AioHandler *tmp; QLIST_FOREACH_SAFE(node, &ctx->poll_aio_handlers, node_poll, tmp) { - if (aio_node_check(ctx, node->is_external) && - node->io_poll(node->opaque)) { + if (node->io_poll(node->opaque)) { aio_add_poll_ready_handler(ready_list, node); node->poll_idle_timeout = now + POLL_IDLE_INTERVAL_NS; diff --git a/util/aio-win32.c b/util/aio-win32.c index 6bded009a4..948ef47a4d 100644 --- a/util/aio-win32.c +++ b/util/aio-win32.c @@ -32,7 +32,6 @@ struct AioHandler { GPollFD pfd; int deleted; void *opaque; - bool is_external; QLIST_ENTRY(AioHandler) node; }; @@ -64,7 +63,6 @@ static void aio_remove_fd_handler(AioContext *ctx, AioHandler *node) void aio_set_fd_handler(AioContext *ctx, int fd, - bool is_external, IOHandler *io_read, IOHandler *io_write, AioPollFn *io_poll, @@ -111,7 +109,6 @@ void aio_set_fd_handler(AioContext *ctx, node->opaque = opaque; node->io_read = io_read; node->io_write = io_write; - node->is_external = is_external; if (io_read) { bitmask |= FD_READ | FD_ACCEPT | FD_CLOSE; @@ -135,7 +132,6 @@ void aio_set_fd_handler(AioContext *ctx, void aio_set_event_notifier(AioContext *ctx, EventNotifier *e, - bool is_external, EventNotifierHandler *io_notify, AioPollFn *io_poll, EventNotifierHandler *io_poll_ready) @@ -161,7 +157,6 @@ void aio_set_event_notifier(AioContext *ctx, node->e = e; node->pfd.fd = (uintptr_t)event_notifier_get_handle(e); node->pfd.events = G_IO_IN; - node->is_external = is_external; QLIST_INSERT_HEAD_RCU(&ctx->aio_handlers, node, node); g_source_add_poll(&ctx->source, &node->pfd); @@ -368,8 +363,7 @@ bool aio_poll(AioContext *ctx, bool blocking) /* fill fd sets */ count = 0; QLIST_FOREACH_RCU(node, &ctx->aio_handlers, node) { - if (!node->deleted && node->io_notify - && aio_node_check(ctx, node->is_external)) { + if (!node->deleted && node->io_notify) { assert(count < MAXIMUM_WAIT_OBJECTS); events[count++] = event_notifier_get_handle(node->e); } diff --git a/util/async.c b/util/async.c index 21016a1ac7..be0726038e 100644 --- a/util/async.c +++ b/util/async.c @@ -377,7 +377,7 @@ aio_ctx_finalize(GSource *source) g_free(bh); } - aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL, NULL); + aio_set_event_notifier(ctx, &ctx->notifier, NULL, NULL, NULL); event_notifier_cleanup(&ctx->notifier); qemu_rec_mutex_destroy(&ctx->lock); qemu_lockcnt_destroy(&ctx->list_lock); @@ -561,7 +561,6 @@ AioContext *aio_context_new(Error **errp) QSLIST_INIT(&ctx->scheduled_coroutines); aio_set_event_notifier(ctx, &ctx->notifier, - false, aio_context_notifier_cb, aio_context_notifier_poll, aio_context_notifier_poll_ready); diff --git a/util/fdmon-epoll.c b/util/fdmon-epoll.c index e11a8a022e..ef3eacacd2 100644 --- a/util/fdmon-epoll.c +++ b/util/fdmon-epoll.c @@ -64,11 +64,6 @@ static int fdmon_epoll_wait(AioContext *ctx, AioHandlerList *ready_list, int i, ret = 0; struct epoll_event events[128]; - /* Fall back while external clients are disabled */ - if (qatomic_read(&ctx->external_disable_cnt)) { - return fdmon_poll_ops.wait(ctx, ready_list, timeout); - } - if (timeout > 0) { ret = qemu_poll_ns(&pfd, 1, timeout); if (ret > 0) { @@ -131,11 +126,6 @@ bool fdmon_epoll_try_upgrade(AioContext *ctx, unsigned npfd) return false; } - /* Do not upgrade while external clients are disabled */ - if (qatomic_read(&ctx->external_disable_cnt)) { - return false; - } - if (npfd >= EPOLL_ENABLE_THRESHOLD) { if (fdmon_epoll_try_enable(ctx)) { return true; diff --git a/util/fdmon-io_uring.c b/util/fdmon-io_uring.c index ab43052dd7..17ec18b7bd 100644 --- a/util/fdmon-io_uring.c +++ b/util/fdmon-io_uring.c @@ -276,11 +276,6 @@ static int fdmon_io_uring_wait(AioContext *ctx, AioHandlerList *ready_list, unsigned wait_nr = 1; /* block until at least one cqe is ready */ int ret; - /* Fall back while external clients are disabled */ - if (qatomic_read(&ctx->external_disable_cnt)) { - return fdmon_poll_ops.wait(ctx, ready_list, timeout); - } - if (timeout == 0) { wait_nr = 0; /* non-blocking */ } else if (timeout > 0) { @@ -315,8 +310,7 @@ static bool fdmon_io_uring_need_wait(AioContext *ctx) return true; } - /* Are we falling back to fdmon-poll? */ - return qatomic_read(&ctx->external_disable_cnt); + return false; } static const FDMonOps fdmon_io_uring_ops = { diff --git a/util/fdmon-poll.c b/util/fdmon-poll.c index 5fe3b47865..17df917cf9 100644 --- a/util/fdmon-poll.c +++ b/util/fdmon-poll.c @@ -65,8 +65,7 @@ static int fdmon_poll_wait(AioContext *ctx, AioHandlerList *ready_list, assert(npfd == 0); QLIST_FOREACH_RCU(node, &ctx->aio_handlers, node) { - if (!QLIST_IS_INSERTED(node, node_deleted) && node->pfd.events - && aio_node_check(ctx, node->is_external)) { + if (!QLIST_IS_INSERTED(node, node_deleted) && node->pfd.events) { add_pollfd(node); } } diff --git a/util/main-loop.c b/util/main-loop.c index e180c85145..3e43a9cd38 100644 --- a/util/main-loop.c +++ b/util/main-loop.c @@ -642,14 +642,13 @@ void qemu_set_fd_handler(int fd, void *opaque) { iohandler_init(); - aio_set_fd_handler(iohandler_ctx, fd, false, - fd_read, fd_write, NULL, NULL, opaque); + aio_set_fd_handler(iohandler_ctx, fd, fd_read, fd_write, NULL, NULL, + opaque); } void event_notifier_set_handler(EventNotifier *e, EventNotifierHandler *handler) { iohandler_init(); - aio_set_event_notifier(iohandler_ctx, e, false, - handler, NULL, NULL); + aio_set_event_notifier(iohandler_ctx, e, handler, NULL, NULL); } diff --git a/util/qemu-coroutine-io.c b/util/qemu-coroutine-io.c index d791932d63..364f4d5abf 100644 --- a/util/qemu-coroutine-io.c +++ b/util/qemu-coroutine-io.c @@ -74,8 +74,7 @@ typedef struct { static void fd_coroutine_enter(void *opaque) { FDYieldUntilData *data = opaque; - aio_set_fd_handler(data->ctx, data->fd, false, - NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(data->ctx, data->fd, NULL, NULL, NULL, NULL, NULL); qemu_coroutine_enter(data->co); } @@ -87,7 +86,7 @@ void coroutine_fn yield_until_fd_readable(int fd) data.ctx = qemu_get_current_aio_context(); data.co = qemu_coroutine_self(); data.fd = fd; - aio_set_fd_handler( - data.ctx, fd, false, fd_coroutine_enter, NULL, NULL, NULL, &data); + aio_set_fd_handler(data.ctx, fd, fd_coroutine_enter, NULL, NULL, NULL, + &data); qemu_coroutine_yield(); } diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 332aea9306..9ba19121a2 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -278,7 +278,7 @@ set_watch(VuDev *vu_dev, int fd, int vu_evt, vu_fd_watch->fd = fd; vu_fd_watch->cb = cb; qemu_socket_set_nonblock(fd); - aio_set_fd_handler(server->ioc->ctx, fd, false, kick_handler, + aio_set_fd_handler(server->ioc->ctx, fd, kick_handler, NULL, NULL, NULL, vu_fd_watch); vu_fd_watch->vu_dev = vu_dev; vu_fd_watch->pvt = pvt; @@ -299,8 +299,7 @@ static void remove_watch(VuDev *vu_dev, int fd) if (!vu_fd_watch) { return; } - aio_set_fd_handler(server->ioc->ctx, fd, false, - NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(server->ioc->ctx, fd, NULL, NULL, NULL, NULL, NULL); QTAILQ_REMOVE(&server->vu_fd_watches, vu_fd_watch, next); g_free(vu_fd_watch); @@ -362,7 +361,7 @@ void vhost_user_server_stop(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, NULL, NULL, NULL, NULL, vu_fd_watch); } @@ -403,7 +402,7 @@ void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx) qio_channel_attach_aio_context(server->ioc, ctx); QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(ctx, vu_fd_watch->fd, false, kick_handler, NULL, + aio_set_fd_handler(ctx, vu_fd_watch->fd, kick_handler, NULL, NULL, NULL, vu_fd_watch); } @@ -417,7 +416,7 @@ void vhost_user_server_detach_aio_context(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, NULL, NULL, NULL, NULL, vu_fd_watch); } diff --git a/tests/unit/meson.build b/tests/unit/meson.build index fa63cfe6ff..2980170397 100644 --- a/tests/unit/meson.build +++ b/tests/unit/meson.build @@ -121,9 +121,6 @@ if have_block if nettle.found() or gcrypt.found() tests += {'test-crypto-pbkdf': [io]} endif - if config_host_data.get('CONFIG_EPOLL_CREATE1') - tests += {'test-fdmon-epoll': [testblock]} - endif endif if have_system -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:34:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:34:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517570.803159 (Exim 4.92) (envelope-from ) id 1pjP0B-00039i-Ht; Mon, 03 Apr 2023 18:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517570.803159; Mon, 03 Apr 2023 18:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjP0B-00039Z-F2; Mon, 03 Apr 2023 18:33:59 +0000 Received: by outflank-mailman (input) for mailman id 517570; Mon, 03 Apr 2023 18:33:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjP0A-00038w-HI for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:33:58 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 177b4932-d24e-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 20:33:57 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-j26lxWggN_O159O5n3-PNg-1; Mon, 03 Apr 2023 14:33:46 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3118C885620; Mon, 3 Apr 2023 18:30:37 +0000 (UTC) Received: from localhost (unknown [10.39.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71C5440C6EC4; Mon, 3 Apr 2023 18:30:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 177b4932-d24e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680546835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hLGTNhZNr3bIXX7Mx11PRwkKdI3CfrxoXkyIIe5WNhM=; b=ex87W1Y2rVLKmb4iIysD6LEcc+IrdiGRxrTImhC5fU5oW9/2y581T4DsPBNiyueuHpq6Li KvpiWb1NsWVBioKxv5i5yW33Gr+3vluq1C0jFv+BtC47HIMa2tHZ8b7xBF/Xxgoln6O/HC rqYr6PiZ0kz3vdcKaxMIeQmHDHs1W8c= X-MC-Unique: j26lxWggN_O159O5n3-PNg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Stefan Hajnoczi , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Anthony Perard Subject: [PATCH 11/13] block/fuse: take AioContext lock around blk_exp_ref/unref() Date: Mon, 3 Apr 2023 14:30:02 -0400 Message-Id: <20230403183004.347205-12-stefanha@redhat.com> In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 These functions must be called with the AioContext acquired: /* Callers must hold exp->ctx lock */ void blk_exp_ref(BlockExport *exp) ... /* Callers must hold exp->ctx lock */ void blk_exp_unref(BlockExport *exp) Signed-off-by: Stefan Hajnoczi --- block/export/fuse.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/export/fuse.c b/block/export/fuse.c index 06fa41079e..18394f9e07 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -244,7 +244,9 @@ static void read_from_fuse_export(void *opaque) FuseExport *exp = opaque; int ret; + aio_context_acquire(exp->common.ctx); blk_exp_ref(&exp->common); + aio_context_release(exp->common.ctx); do { ret = fuse_session_receive_buf(exp->fuse_session, &exp->fuse_buf); @@ -256,7 +258,9 @@ static void read_from_fuse_export(void *opaque) fuse_session_process_buf(exp->fuse_session, &exp->fuse_buf); out: + aio_context_acquire(exp->common.ctx); blk_exp_unref(&exp->common); + aio_context_release(exp->common.ctx); } static void fuse_export_shutdown(BlockExport *blk_exp) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Apr 03 18:40:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 18:40:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517586.803168 (Exim 4.92) (envelope-from ) id 1pjP6Q-0004m8-8E; Mon, 03 Apr 2023 18:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517586.803168; Mon, 03 Apr 2023 18:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjP6Q-0004m1-5f; Mon, 03 Apr 2023 18:40:26 +0000 Received: by outflank-mailman (input) for mailman id 517586; Mon, 03 Apr 2023 18:40:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjP6P-0004lv-3S for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 18:40:25 +0000 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [2a00:1450:4864:20::22f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fdeb178b-d24e-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 20:40:22 +0200 (CEST) Received: by mail-lj1-x22f.google.com with SMTP id h9so31381937ljq.2 for ; Mon, 03 Apr 2023 11:40:22 -0700 (PDT) Received: from [192.168.202.197] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id u22-20020a2ea176000000b002935005f782sm940636ljl.57.2023.04.03.11.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 11:40:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdeb178b-d24e-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680547222; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=D1mf9FE6OGtx421qkqQ1ut1+Ibbt2CZmN0oBWVfBFIo=; b=gI1euHdMIe085Z55oMOZQGbeJQyoGYIuimgyfobH023UYgD0ikSCYkI1pbIYPwL0HH +gUiDYb0pIAv9BmWevsS9TpgsYNl69UR+KzNQibGQVVPqd58i0ZXaQQ+XaHVZQvYKw7h F9+TI0kGQHH9cvuIQAMsMaIxxMvIewuCiBmn5fi54Hc9aqLFTzNQ3J/ptY18BzSRmr0Z P/1MTm/QSRlRO9CuoMBE7Ebp5n9b9ugCI4GTn/ko1lwU9oMrInvXLH/Z2vqbJLVgmW0g ZXl2+nV30rYzNqiLHg4BOeV4jZXs1vueeM6AcOV7bpXL7a7BhvhscXfffKF6IDAflOGc cUYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680547222; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=D1mf9FE6OGtx421qkqQ1ut1+Ibbt2CZmN0oBWVfBFIo=; b=lxEBbvIVoai+Co67+J2BeOHNbALrTAeOX+qufkz5f0eyFxJZiWjZ9kvy0dMIV651id C0Go7Rzc/esIwxFVNsq2JLYOlh3YfwFEzkE6cE8QDAqNED1zNAO9hnbOYQAEMAH1yV2+ LwVA0rvjQUJ5VtRuwxRXT0OwHuJ7i1mYABX1zbWe72HacvEq4IWQzVeIHWXNtZU+UM3s HvszJgHV5/P5zNh7T+aGVxjcopoXs8IYUxn8ljHwFsDCtuxdSkN1SzpxSw+uAAyk5A/b IpK44gZlHYdOPl6Zk2hHuwpRxFaRoq6aKpyDGMyKWTbUnmMW6zerIBfi1DrT30DoprLR wfiw== X-Gm-Message-State: AAQBX9eZAawIv4rPL6qXgb6TnR5rtyOkG+e1Ac0N7tR3t9dkHnsc0M39 WNxIB8ok7avznnBNUEA+/C8= X-Google-Smtp-Source: AKy350a0lRWSBr0kRwjKoJJMRBpD5euDxKz53pnqpvwnWtA8j+SJucGmsWro9c/7CzV4EaSMFjzDHA== X-Received: by 2002:a2e:7314:0:b0:298:a89b:fb66 with SMTP id o20-20020a2e7314000000b00298a89bfb66mr111082ljc.42.1680547222051; Mon, 03 Apr 2023 11:40:22 -0700 (PDT) Message-ID: <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk Date: Mon, 03 Apr 2023 21:40:21 +0300 In-Reply-To: <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 SGVsbG8gSnVsaWVuLCAKT24gRnJpLCAyMDIzLTAzLTMxIGF0IDIyOjA1ICswMTAwLCBKdWxpZW4g R3JhbGwgd3JvdGU6Cj4gSGkgT2xla3NpaSwKPiAKPiBJIHdhcyBnb2luZyB0byBhY2sgdGhlIHBh dGNoIGJ1dCB0aGVuIEkgc3BvdHRlZCBzb21ldGhpbmcgdGhhdCB3b3VsZCAKPiB3YW50IHNvbWUg Y2xhcmlmaWNhdGlvbi4KPiAKPiBPbiAyOS8wMy8yMDIzIDExOjUwLCBPbGVrc2lpIEt1cm9jaGtv IHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9idWcuaAo+ ID4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYnVnLmgKPiA+IGluZGV4IGNhY2FmMDE0YWIu LjNmYjA0NzFhOWIgMTAwNjQ0Cj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYnVn LmgKPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9idWcuaAo+ID4gQEAgLTEsNiAr MSwyNCBAQAo+ID4gwqAgI2lmbmRlZiBfX0FSTV9CVUdfSF9fCj4gPiDCoCAjZGVmaW5lIF9fQVJN X0JVR19IX18KPiA+IMKgIAo+ID4gKy8qCj4gPiArICogUGxlYXNlIGRvIG5vdCBpbmNsdWRlIGlu IHRoZSBoZWFkZXIgYW55IGhlYWRlciB0aGF0IG1pZ2h0Cj4gPiArICogdXNlIEJVRy9BU1NFUlQv ZXRjIG1hcm9zIGFzdGhleSB3aWxsIGJlIGRlZmluZWQgbGF0ZXIgYWZ0ZXIKPiA+ICsgKiB0aGUg cmV0dXJuIHRvIDx4ZW4vYnVnLmg+IGZyb20gdGhlIGN1cnJlbnQgaGVhZGVyOgo+ID4gKyAqCj4g PiArICogPHhlbi9idWcuaD46Cj4gPiArICrCoCAuLi4KPiA+ICsgKsKgwqAgPGFzbS9idWcuaD46 Cj4gPiArICrCoMKgwqDCoCAuLi4KPiA+ICsgKsKgwqDCoMKgIDxhbnlfaGVhZGVyX3doaWNoX3Vz ZXNfQlVHL0FTU0VSVC9ldGMgbWFjcm9zLmg+Cj4gPiArICrCoMKgwqDCoCAuLi4KPiA+ICsgKsKg IC4uLgo+ID4gKyAqwqAgI2RlZmluZSBCVUcoKSAuLi4KPiA+ICsgKsKgIC4uLgo+ID4gKyAqwqAg I2RlZmluZSBBU1NFUlQoKSAuLi4KPiA+ICsgKsKgIC4uLgo+ID4gKyAqLwo+ID4gKwo+ID4gwqAg I2luY2x1ZGUgPHhlbi90eXBlcy5oPgo+ID4gwqAgCj4gPiDCoCAjaWYgZGVmaW5lZChDT05GSUdf QVJNXzMyKQo+ID4gQEAgLTExLDc2ICsyOSw3IEBACj4gPiDCoCAjIGVycm9yICJ1bmtub3duIEFS TSB2YXJpYW50Igo+ID4gwqAgI2VuZGlmCj4gPiDCoCAKPiA+IC0jZGVmaW5lIEJVR19GUkFNRV9T VFJVQ1QKPiA+IC0KPiA+IC1zdHJ1Y3QgYnVnX2ZyYW1lIHsKPiA+IC3CoMKgwqAgc2lnbmVkIGlu dCBsb2NfZGlzcDvCoMKgwqAgLyogUmVsYXRpdmUgYWRkcmVzcyB0byB0aGUgYnVnIGFkZHJlc3MK PiA+ICovCj4gPiAtwqDCoMKgIHNpZ25lZCBpbnQgZmlsZV9kaXNwO8KgwqAgLyogUmVsYXRpdmUg YWRkcmVzcyB0byB0aGUgZmlsZW5hbWUgKi8KPiA+IC3CoMKgwqAgc2lnbmVkIGludCBtc2dfZGlz cDvCoMKgwqAgLyogUmVsYXRpdmUgYWRkcmVzcyB0byB0aGUgcHJlZGljYXRlCj4gPiAoZm9yIEFT U0VSVCkgKi8KPiA+IC3CoMKgwqAgdWludDE2X3QgbGluZTvCoMKgwqDCoMKgwqDCoMKgwqAgLyog TGluZSBudW1iZXIgKi8KPiA+IC3CoMKgwqAgdWludDMyX3QgcGFkMDoxNjvCoMKgwqDCoMKgwqAg LyogUGFkZGluZyBmb3IgOC1ieXRlcyBhbGlnbiAqLwo+ID4gLX07Cj4gPiAtCj4gPiAtI2RlZmlu ZSBidWdfbG9jKGIpICgoY29uc3Qgdm9pZCAqKShiKSArIChiKS0+bG9jX2Rpc3ApCj4gPiAtI2Rl ZmluZSBidWdfZmlsZShiKSAoKGNvbnN0IHZvaWQgKikoYikgKyAoYiktPmZpbGVfZGlzcCk7Cj4g PiAtI2RlZmluZSBidWdfbGluZShiKSAoKGIpLT5saW5lKQo+ID4gLSNkZWZpbmUgYnVnX21zZyhi KSAoKGNvbnN0IGNoYXIgKikoYikgKyAoYiktPm1zZ19kaXNwKQo+ID4gLQo+ID4gLS8qIE1hbnkg dmVyc2lvbnMgb2YgR0NDIGRvZXNuJ3Qgc3VwcG9ydCB0aGUgYXNtICVjIHBhcmFtZXRlciB3aGlj aAo+ID4gd291bGQKPiA+IC0gKiBiZSBwcmVmZXJhYmxlIHRvIHRoaXMgdW5wbGVhc2FudG5lc3Mu IFdlIHVzZSBtZXJnZWFibGUgc3RyaW5nCj4gPiAtICogc2VjdGlvbnMgdG8gYXZvaWQgbXVsdGlw bGUgY29waWVzIG9mIHRoZSBzdHJpbmcgYXBwZWFyaW5nIGluCj4gPiB0aGUKPiA+IC0gKiBYZW4g aW1hZ2UuIEJVR0ZSQU1FX3J1bl9mbiBuZWVkcyB0byBiZSBoYW5kbGVkIHNlcGFyYXRlbHkuCj4g PiAtICovCj4gCj4gR2l2ZW4gdGhpcyBjb21tZW50IC4uLgo+IAo+ID4gLSNkZWZpbmUgQlVHX0ZS QU1FKHR5cGUsIGxpbmUsIGZpbGUsIGhhc19tc2csIG1zZykgZG8KPiA+IHvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoCBCVUlMRF9CVUdfT04o KGxpbmUpID4+Cj4gPiAxNik7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAt wqDCoMKgIEJVSUxEX0JVR19PTigodHlwZSkgPj0KPiA+IEJVR0ZSQU1FX05SKTvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+IC3CoMKgwqAgYXNtCj4gPiAoIjE6IkJVR19JTlNUUiJcbiLCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gXAo+ID4gLcKgwqDCoMKgwqDCoMKgwqAg Ii5wdXNoc2VjdGlvbiAucm9kYXRhLnN0ciwgXCJhTVNcIiwgJXByb2diaXRzLAo+ID4gMVxuIsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoCAiMjpc dC5hc2NpeiAiIF9fc3RyaW5naWZ5KGZpbGUpCj4gPiAiXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDCoMKg wqDCoMKgCj4gPiAiMzpcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+IFwKPiA+IC3CoMKgwqDCoMKgwqDCoMKgICIuaWYg IiAjaGFzX21zZwo+ID4gIlxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwK PiA+IC3CoMKgwqDCoMKgwqDCoMKgICJcdC5hc2NpeiAiICNtc2cKPiA+ICJcbiLCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoMKgwqDCoMKgwqAKPiA+ICIuZW5k aWZcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgCj4gPiBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoAo+ID4gIi5wb3BzZWN0aW9uXG4iwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiBcCj4gPiAtwqDCoMKg wqDCoMKgwqDCoCAiLnB1c2hzZWN0aW9uIC5idWdfZnJhbWVzLiIgX19zdHJpbmdpZnkodHlwZSkg IiwgXCJhXCIsCj4gPiAlcHJvZ2JpdHNcbiJcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoAo+ID4gIjQ6 XG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgCj4gPiBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoCAiLnAyYWxpZ24KPiA+IDJcbiLC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDC oMKgwqDCoMKgwqDCoCAiLmxvbmcgKDFiIC0KPiA+IDRiKVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoMKgwqDCoMKgwqAgIi5sb25nICgyYiAtCj4g PiA0YilcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKg wqDCoMKgwqDCoMKgICIubG9uZyAoM2IgLQo+ID4gNGIpXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoCAiLmh3b3JkICIgX19zdHJp bmdpZnkobGluZSkgIiwKPiA+IDBcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoAo+ID4g Ii5wb3BzZWN0aW9uIik7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgCj4gPiBcCj4gPiAtfSB3aGlsZSAoMCkKPiA+IC0KPiA+IC0vKgo+ID4gLSAqIEdDQyB3aWxs IG5vdCBhbGxvdyB0byB1c2UgImkiwqAgd2hlbiBQSUUgaXMgZW5hYmxlZCAoWGVuIGRvZXNuJ3QK PiA+IHNldCB0aGUKPiA+IC0gKiBmbGFnIGJ1dCBpbnN0ZWFkIHJlbHkgb24gdGhlIGRlZmF1bHQg dmFsdWUgZnJvbSB0aGUgY29tcGlsZXIpLgo+ID4gU28gdGhlCj4gPiAtICogZWFzaWVzdCB3YXkg dG8gaW1wbGVtZW50IHJ1bl9pbl9leGNlcHRpb25faGFuZGxlcigpIGlzIHRvIHBhc3MKPiA+IHRo ZSB0bwo+ID4gLSAqIGJlIGNhbGxlZCBmdW5jdGlvbiBpbiBhIGZpeGVkIHJlZ2lzdGVyLgo+ID4g LSAqLwo+ID4gLSNkZWZpbmXCoCBydW5faW5fZXhjZXB0aW9uX2hhbmRsZXIoZm4pIGRvCj4gPiB7 wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgYXNtICgibW92ICIgX19zdHJpbmdpZnkoQlVHX0ZOX1JF RykgIiwKPiA+ICUwXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDCoMKgwqDCoMKgCj4gPiAiMToiQlVHX0lOU1RSIlxu IsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiBcCj4gPiAtwqDC oMKgwqDCoMKgwqDCoCAiLnB1c2hzZWN0aW9uIC5idWdfZnJhbWVzLiIgX19zdHJpbmdpZnkoQlVH RlJBTUVfcnVuX2ZuKQo+ID4gIiwiwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDCoMKgwqDCoMKg ICLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXCJhXCIsCj4gPiAlJXByb2diaXRzXG4iwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoAo+ID4gIjI6XG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiBcCj4gPiAtwqDC oMKgwqDCoMKgwqDCoCAiLnAyYWxpZ24KPiA+IDJcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgwqDCoMKgwqDCoCAiLmxvbmcgKDFi IC0KPiA+IDJiKVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4g LcKgwqDCoMKgwqDCoMKgwqAgIi5sb25nIDAsIDAsCj4gPiAwXG4iwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoMKgwqDCoMKgwqAgIi5wb3BzZWN0 aW9uIiA6OiAiciIgKGZuKSA6IF9fc3RyaW5naWZ5KEJVR19GTl9SRUcpCj4gPiApO8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtfSB3aGlsZSAoMCkKPiA+IC0KPiA+IC0jZGVmaW5lIFdB Uk4oKSBCVUdfRlJBTUUoQlVHRlJBTUVfd2FybiwgX19MSU5FX18sIF9fRklMRV9fLCAwLCAiIikK PiA+IC0KPiA+IC0jZGVmaW5lIEJVRygpIGRvIHvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgXAo+ID4gLcKgwqDCoCBCVUdfRlJBTUUoQlVHRlJBTUVfYnVnLMKgIF9fTElORV9fLCBf X0ZJTEVfXywgMCwgIiIpO8KgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgdW5yZWFjaGFibGUo KTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLX0gd2hpbGUgKDApCj4g PiAtCj4gPiAtI2RlZmluZSBhc3NlcnRfZmFpbGVkKG1zZykgZG8ge8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKg wqDCoCBCVUdfRlJBTUUoQlVHRlJBTUVfYXNzZXJ0LCBfX0xJTkVfXywgX19GSUxFX18sIDEsIG1z Zyk7wqDCoMKgwqAgXAo+ID4gLcKgwqDCoCB1bnJlYWNoYWJsZSgpO8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtfSB3aGlsZSAoMCkKPiA+ICsjZGVmaW5lIEJVR19BU01f Q09OU1TCoMKgICJjIgo+IAo+IC4uLiB5b3Ugc2hvdWxkIGV4cGxhaW4gaW4gdGhlIGNvbW1pdCBt ZXNzYWdlIHdoeSB0aGlzIGlzIG5lZWRlZCBhbmQKPiB0aGUgCj4gcHJvYmxlbSBkZXNjcmliZWQg YWJvdmUgaXMgbm90IGEgcHJvYmxlbSBhbnltb3JlLgo+IAo+IEZvciBpbnN0YW5jZSwgSSBtYW5h Z2VkIHRvIGJ1aWxkIGl0IHdpdGhvdXQgJ2MnIG9uIGFybTY0IFsxXS4gQnV0IGl0IAo+IGRvZXMg YnJlYWsgb24gYXJtMzIgWzJdLiBJIGtub3cgdGhhdCBBcm0gaXMgYWxzbyB3aGVyZSAnJWMnIHdh cyBhbgo+IGlzc3VlLgo+IAo+IFNraW1taW5nIHRocm91Z2ggbGludXgsIHRoZSByZWFzb24gc2Vl bXMgdG8gYmUgdGhhdCBHQ0MgbWF5IGFkZCAnIycKPiB3aGVuIAo+IGl0IHNob3VsZCBub3QuIFRo YXQgc2FpZCwgSSBoYXZlbid0IGxvb2sgYXQgdGhlIGltcGFjdCBvbiB0aGUgZ2VuZXJpYwo+IGlt cGxlbWVudGF0aW9uLiBOZWl0aGVyIEkgbG9va2VkIGF0IHdoaWNoIHZlcnNpb24gbWF5IGJlIGFm ZmVjdGVkCj4gKHRoZSAKPiBvcmlnaW5hbCBtZXNzYWdlIHdhcyBmcm9tIDIwMTEpLgpZb3UgYXJl IHJpZ2h0IHRoYXQgc29tZSBjb21waWxlcnMgYWRkICcjJyB3aGVuIGl0IHNob3VsZG4ndC4gVGhl IHNhbWUKdGhpbmcgaGFwcGVucyB3aXRoIFJJU0MtVi4KClNvIEknbGwgdXBkYXRlIGJvdGggdGhl IGNvbW1pdCBtZXNzYWdlIGFuZCBjb21tZW50LgoKPiAKPiBIb3dldmVyLCB3aXRob3V0IGFuIGV4 cGxhbmF0aW9uLCBJIGFtIGFmcmFpZCB0aGlzIGNhbid0IGdvIGluIGJlY2F1c2UKPiBJIAo+IGFt IHdvcnJ5IHdlIG1heSBicmVhayBzb21lIHVzZXJzICh0aGFua2Z1bGx5IHRoYXQgbWlnaHQganVz dCBiZSBhIAo+IGNvbXBpbGF0aW9uIGlzc3VlcyByYXRoZXIgdGhhbiB3ZWlyZCBiZWhhdmlvciku Cj4gCj4gQmVydHJhbmQsIFN0ZWZhbm8sIGRvIHlvdSBrbm93IGlmIHRoaXMgaXMgc3RpbGwgYW4g aXNzdWU/Cj4gCj4gQ2hlZXJzLAo+IAo+IFsxXSBhYXJjaDY0LWxpbnV4LWdudS1nY2MgKExpbmFy byBHQ0MgNy41LTIwMTkuMTIpIDcuNS4wCj4gWzJdIGFybS1ub25lLWxpbnV4LWdudWVhYmloZi1n Y2MgKEdOVSBUb29sY2hhaW4gZm9yIHRoZSBBLXByb2ZpbGUgCj4gQXJjaGl0ZWN0dXJlIDEwLjMt MjAyMS4wNyAoYXJtLTEwLjI5KSkgMTAuMy4xIDIwMjEwNjIxCj4gCn4gT2xla3NpaQoK From xen-devel-bounces@lists.xenproject.org Mon Apr 03 20:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 20:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517597.803178 (Exim 4.92) (envelope-from ) id 1pjQLo-0004fx-Qx; Mon, 03 Apr 2023 20:00:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517597.803178; Mon, 03 Apr 2023 20:00:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjQLo-0004fq-OO; Mon, 03 Apr 2023 20:00:24 +0000 Received: by outflank-mailman (input) for mailman id 517597; Mon, 03 Apr 2023 20:00:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjQLn-0004fg-1o; Mon, 03 Apr 2023 20:00:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjQLm-0002wk-Rl; Mon, 03 Apr 2023 20:00:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjQLm-0006gu-FJ; Mon, 03 Apr 2023 20:00:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjQLm-00054e-Eq; Mon, 03 Apr 2023 20:00:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iVHKg7EU5CIRCK4JX8fX/BslmcDwyivBEC/bwGpywxU=; b=VO67zF9qbZc3DvCHrj08igDKbS UBAbD5Qo/zdedOiUYSSmempc813BDtuSxmhVZau031h07gj5WtzJsdrxW4vZWpUsqOkDrkReWWb8x qpmZGlKz2tfbzLkzpY73FWQ7+3r6dq4L5SYXmFuZ5mQDoT1sDWi1A5bpN7BFcD5MHIJg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180127: all pass - PUSHED X-Osstest-Versions-This: ovmf=26997800c991f934b57ebd91de2edcd93312f756 X-Osstest-Versions-That: ovmf=fc00ff286a541c047b7d343e66ec10890b80d3ea From: osstest service owner Date: Mon, 03 Apr 2023 20:00:22 +0000 flight 180127 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180127/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 26997800c991f934b57ebd91de2edcd93312f756 baseline version: ovmf fc00ff286a541c047b7d343e66ec10890b80d3ea Last test of basis 180112 2023-04-02 04:43:57 Z 1 days Testing same since 180127 2023-04-03 15:40:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Erich McMillan Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fc00ff286a..26997800c9 26997800c991f934b57ebd91de2edcd93312f756 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Apr 03 20:36:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 20:36:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517602.803189 (Exim 4.92) (envelope-from ) id 1pjQum-00087Y-Hq; Mon, 03 Apr 2023 20:36:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517602.803189; Mon, 03 Apr 2023 20:36:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjQum-00087R-F3; Mon, 03 Apr 2023 20:36:32 +0000 Received: by outflank-mailman (input) for mailman id 517602; Mon, 03 Apr 2023 20:36:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjQuk-00087L-Sh for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 20:36:31 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35dc50ff-d25f-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 22:36:29 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id d11-20020a05600c3acb00b003ef6e6754c5so15162021wms.5 for ; Mon, 03 Apr 2023 13:36:28 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-055-162-106.78.55.pool.telefonica.de. [78.55.162.106]) by smtp.gmail.com with ESMTPSA id bg11-20020a05600c3c8b00b003f04057bf1bsm13656303wmb.18.2023.04.03.13.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 13:36:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35dc50ff-d25f-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680554188; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hNpPseAD6nHZ7v+hgrSa5UPOdQF/BU4JEX0k08mqk2E=; b=BzrQf8shkKF3ucc8v0yanJ+Y+GcgPtueiVt7X99aCBS4DeY+XPagZA/aqqJeocKnGQ vAm80zoeHOANwvXNddMOL7IBIjwphOJFStdydNflih2ttP8KROWr9FklP2PJqrEH9o2d rGPbRwTINAhRpF9n42/WlHkMeEI5FWxRKLf2neETIG2bLlXvVmsqSehsrk8w4iLJddGC mGuxAFIV6d3eGN5jxxOL+borlmXOai7qhD0ZogU9fxDMZqYbUKUAImap3hlnON7jQTh6 DZW1lb3DC88qHwebbilU0AuHzQJ4gYOCqKu5vPU2JqMqVY6Y7UOaKS6kJiuRcQHgol5N +MUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680554188; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hNpPseAD6nHZ7v+hgrSa5UPOdQF/BU4JEX0k08mqk2E=; b=F49eC6NbCmqqZF8W81npFZJoF4NY9L4ObYkudTNvIzJaT0KmkUqPG6thbgACLkmlob dfQxTiFznoBzV/2q4GJAUX/OMw/8hgyngzHBjqpLYukcEtlfi/9lqdCvcx3PWv6zoyw/ VS2XLLNQMVU4/SEtEeoZ4Be15Mozzzjj6Fz5Pvu3MwJFq+R8mYkdVGdn5iznNAw0kRmP /agCbF7wQiv6CDYhZbE/phfO24bQIuAlrot0c9fGdATjg2EGpLxL7HhRqb9iVUBq7KUG pbbXmdlalsZgR92+wYMy1Tb9FuUISDbnQa6UjQ0MRSkUU8SKnCOmE2+Q9cOq5NAjIAo7 ojpA== X-Gm-Message-State: AAQBX9fca5f1MDGgktpp7ziIgXImedy70KyYhivv/V7CcmDj+L9AcT3V C5Pr8AsPpCXdGKDO2iyTXe8= X-Google-Smtp-Source: AKy350bKz/PYk6lgC93kgyq++7qdvvptIvcgqHIM2SizcDYoNqvyp2ruZaSzDSuJzx2fXfh1j29U3A== X-Received: by 2002:a1c:f208:0:b0:3eb:4150:a476 with SMTP id s8-20020a1cf208000000b003eb4150a476mr497072wmc.0.1680554188103; Mon, 03 Apr 2023 13:36:28 -0700 (PDT) Date: Mon, 03 Apr 2023 20:36:22 +0000 From: Bernhard Beschow To: Jason Andryuk , Anthony PERARD CC: qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , David Woodhouse , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Eduardo Habkost , Paul Durrant , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefano Stabellini , Richard Henderson , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Chuck Zmudzinski Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_2/6=5D_hw/isa/piix3=3A_Reuse?= =?US-ASCII?Q?_piix3=5Frealize=28=29_in_piix3=5Fxen=5Frealize=28=29?= In-Reply-To: References: <20230312120221.99183-1-shentey@gmail.com> <20230312120221.99183-3-shentey@gmail.com> <7F45B51F-F1E3-4F04-A46F-4C80509C7195@gmail.com> <622b9674-fffd-4634-ac30-d0db3230478e@perard> Message-ID: <3D51F8CC-6909-4777-9C43-5E277650331C@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 3=2E April 2023 12:27:14 UTC schrieb Jason Andryuk : >On Mon, Apr 3, 2023 at 5:33=E2=80=AFAM Anthony PERARD wrote: >> >> On Sat, Apr 01, 2023 at 10:36:45PM +0000, Bernhard Beschow wrote: >> > >> > >> > Am 30=2E M=C3=A4rz 2023 13:00:25 UTC schrieb Anthony PERARD : >> > >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: >> > >> This is a preparational patch for the next one to make the followi= ng >> > >> more obvious: >> > >> >> > >> First, pci_bus_irqs() is now called twice in case of Xen where the >> > >> second call overrides the pci_set_irq_fn with the Xen variant=2E >> > > >> > >pci_bus_irqs() does allocates pci_bus->irq_count, so the second call= in >> > >piix3_xen_realize() will leak `pci_bus->irq_count`=2E Could you look= if >> > >pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs(= ) >> > >call, or maybe some other way to avoid the leak? >> > >> > Thanks for catching this! I'll post a v4=2E >> > >> > I think the most fool-proof way to fix this is to free irq_count just= before the assignment=2E pci_bus_irqs_cleanup() would then have to NULL th= e attribute such that pci_bus_irqs() can be called afterwards=2E >> > >> > BTW: I tried running qemu-system-x86_64 with PIIX4 rather than PIIX3 = as Xen guest with my pc-piix4 branch without success=2E This branch essenti= ally just provides slightly different PCI IDs for PIIX=2E Does xl or someth= ing else in Xen check these? If not then this means I'm still missing somet= hing=2E Under KVM this branch works just fine=2E Any idea? >> >> Maybe the ACPI tables provided by libxl needs to be updated=2E >> Or maybe something in the firmware (SeaBIOS or OVMF/OvmfXen) check the >> id (I know that the PCI id of the root bus is checked, but I don't know >> if that's the one that's been changed)=2E > >Xen also has hvmloader, which runs before SeaBIOS/OVMF=2E Looking at >tools/firmware/hvmloader/pci=2Ec, it has > ASSERT((devfn !=3D PCI_ISA_DEVFN) || > ((vendor_id =3D=3D 0x8086) && (device_id =3D=3D 0x7000))); > >From QEMU, it looks like 0x7000 is PCI_DEVICE_ID_INTEL_82371SB_0, but >PIIX4 uses 0x7110 (PCI_DEVICE_ID_INTEL_82371AB_0)=2E Maybe try removing >that check? Sounds promising indeed=2E I'll give it a try! Regards, Bernhard > >Regards, >Jason From xen-devel-bounces@lists.xenproject.org Mon Apr 03 20:47:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 20:47:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517606.803198 (Exim 4.92) (envelope-from ) id 1pjR5C-0001EA-L8; Mon, 03 Apr 2023 20:47:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517606.803198; Mon, 03 Apr 2023 20:47:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjR5C-0001E3-IF; Mon, 03 Apr 2023 20:47:18 +0000 Received: by outflank-mailman (input) for mailman id 517606; Mon, 03 Apr 2023 20:47:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjR5A-0001Dx-IY for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 20:47:16 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b77cc6db-d260-11ed-85db-49a42c6b2330; Mon, 03 Apr 2023 22:47:15 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id d11-20020a05600c3acb00b003ef6e6754c5so15174647wms.5 for ; Mon, 03 Apr 2023 13:47:15 -0700 (PDT) Received: from [192.168.69.115] (pas38-h02-176-184-5-132.dsl.sta.abo.bbox.fr. [176.184.5.132]) by smtp.gmail.com with ESMTPSA id l32-20020a05600c1d2000b003f0321c22basm19001040wms.12.2023.04.03.13.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 13:47:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b77cc6db-d260-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680554835; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lQW83CaEFIKTAbTGMK7zJAXx2zCsHH8oRPYKrzlIxPw=; b=fNGh2NV6/uj7FXzhYWT2H2X1iMgLhYqx5DQL6GwdoEYEHkvIK7KGPOYxFcq407H4T+ SPpDo7z8o68YlOOG65fHhKTjYHMuzp3pjBoINet7XgMWmiIsuJq1JC7vZu25hbshHqkm 4ePpZieKILGkS/7UVLBCblFqD/mw2XE4aUt4Op92vlqL4PkWxCqswfJkmLEw9eJJvlmP BOjt3AZDAkZEszXzDqBSBhAJ0++TjQg0Qhn2xutvRsF0zqVsrFK49JBMJ94rsnhv/u5Z UHdh2GTjPUtx1NU5SFlV6jvmMTsWTt8WzXQWdclyISmEQ/TtGy22fxDk3RZzbbD9OIHP dbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680554835; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lQW83CaEFIKTAbTGMK7zJAXx2zCsHH8oRPYKrzlIxPw=; b=M8YdRhSIDmLFK17YKeoEiDcq/gmUuUqaiSkGZ7ygQVVKeOIV4NR8nwP5vIXo35bmR4 h+weTKi+Y4+XACyJ4KLUN7goNemqtXa4TNrsklyHhYM8Tmn8YMLFcVnqtme/5Nj6C75+ V2j3RTlknhpnzf7PpXQwMti3ZMZvwRQKlcuKG9PfYLrjUpqCYJt/yMUPXRRXjiKYsFtl Wp72D1SW1TZX3QXsH5QqsLVlA2Qj1Tx/0BWqzzhMydfBzuGZWauXpQygtlVr1IN5E54p R3f/BWk2VURVZj2c0FxEnujgZ0u67dISFaHqAbgpLIx8VdJYcON85RewfE1tNgP0bWmu xOxQ== X-Gm-Message-State: AAQBX9cqQwhdwD5DvpT9g51M+o6btFiW86yCqL2/hWdfS6cCZi4rd+gO Hy3PY3gghG/ja+O/jr/TXBLexA== X-Google-Smtp-Source: AKy350YJckSFRktwO+Ap2UM2V7mr6N7rsDxT5yrMXbEjRUK205rt4FU3Ijr4q2cDcOnc7yvmq+n7YQ== X-Received: by 2002:a05:600c:3789:b0:3ee:b3bf:5f7c with SMTP id o9-20020a05600c378900b003eeb3bf5f7cmr491399wmr.23.1680554835048; Mon, 03 Apr 2023 13:47:15 -0700 (PDT) Message-ID: <2bbe988c-0802-55c3-b2a3-05e3f94e2f04@linaro.org> Date: Mon, 3 Apr 2023 22:47:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event Content-Language: en-US To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Anthony Perard References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-2-stefanha@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230403183004.347205-2-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/4/23 20:29, Stefan Hajnoczi wrote: > Only report a transport reset event to the guest after the SCSIDevice > has been unrealized by qdev_simple_device_unplug_cb(). > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field > to false so that scsi_device_find/get() no longer see it. > > scsi_target_emulate_report_luns() also needs to be updated to filter out > SCSIDevices that are unrealized. > > These changes ensure that the guest driver does not see the SCSIDevice > that's being unplugged if it responds very quickly to the transport > reset event. > > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/scsi-bus.c | 3 ++- > hw/scsi/virtio-scsi.c | 18 +++++++++--------- > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index c97176110c..f9bd064833 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c > @@ -487,7 +487,8 @@ static bool scsi_target_emulate_report_luns(SCSITargetReq *r) > DeviceState *qdev = kid->child; > SCSIDevice *dev = SCSI_DEVICE(qdev); > > - if (dev->channel == channel && dev->id == id && dev->lun != 0) { > + if (dev->channel == channel && dev->id == id && dev->lun != 0 && > + qatomic_load_acquire(&dev->qdev.realized)) { Would this be more useful as a qdev_is_realized() helper? From xen-devel-bounces@lists.xenproject.org Mon Apr 03 21:03:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Apr 2023 21:03:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517609.803209 (Exim 4.92) (envelope-from ) id 1pjRKw-0003ax-1d; Mon, 03 Apr 2023 21:03:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517609.803209; Mon, 03 Apr 2023 21:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjRKv-0003aq-Tj; Mon, 03 Apr 2023 21:03:33 +0000 Received: by outflank-mailman (input) for mailman id 517609; Mon, 03 Apr 2023 21:03:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjRKv-0003ak-8J for xen-devel@lists.xenproject.org; Mon, 03 Apr 2023 21:03:33 +0000 Received: from madras.collabora.co.uk (madras.collabora.co.uk [2a00:1098:0:82:1000:25:2eeb:e5ab]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fac0cbc5-d262-11ed-b464-930f4c7d94ae; Mon, 03 Apr 2023 23:03:28 +0200 (CEST) Received: from [192.168.2.163] (109-252-124-32.nat.spd-mgts.ru [109.252.124.32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7E46C66003B2; Mon, 3 Apr 2023 22:03:25 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fac0cbc5-d262-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680555807; bh=Q2hdVjNQTK+EUWtWpCirhufnEV7FHiF9pY75Mt779/o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lSLI99hnfSoTDZNCbIO7NvqqKE1AY7Sp3cn/LgehMOJ5vXw5XO2KoBa+lQQeCO5bd OP+7K5/00TbABp2dHoU+RS6AigJN09CS3ANla0f8/Ycdu4YQQTVffyIxOm2rn67//I uuBD4Pky5TjcN6f8kBfyO/KOfc2OxUZiLi2+6MvH/KkQo74OlVTA7Pj2rLL6UmB8+4 y/+dHo2GKHOnrS4U0MRoUBwrVm2gDVgC68qQ+kEmhY5XN0vHKOSHUSYUdxrAy8Pr2p uwjs8vaYrkGffNsznnM+mFxL1ctoxvapXD7xQ0I/d5xRelHCPUTmnPYMSupsYY9C17 9g5F+KZcB8LzA== Message-ID: <626c649b-e82c-d660-5015-6dd64e48a4a0@collabora.com> Date: Tue, 4 Apr 2023 00:03:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus Content-Language: en-US To: Huang Rui Cc: Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , "Dr . David Alan Gilbert" , Robert Beckett , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" , "Deucher, Alexander" , "Koenig, Christian" , "Hildebrand, Stewart" , Xenia Ragiadakou , "Huang, Honglei1" , "Zhang, Julia" , "Chen, Jiqian" References: <20230312092244.451465-1-ray.huang@amd.com> <20230312092244.451465-9-ray.huang@amd.com> <68195782-0309-2f81-7f1f-84a7fe7bb05c@collabora.com> <53c25304-bc30-b5af-846e-b247aab67be9@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/24/23 16:22, Huang Rui wrote: > On Thu, Mar 16, 2023 at 07:14:47AM +0800, Dmitry Osipenko wrote: >> On 3/13/23 18:55, Huang Rui wrote: >>> On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote: >>>> On 3/12/23 12:22, Huang Rui wrote: >>>>> From: Antonio Caggiano >>>>> >>>>> Request Venus when initializing VirGL. >>>>> >>>>> Signed-off-by: Antonio Caggiano >>>>> --- >>>>> hw/display/virtio-gpu-virgl.c | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c >>>>> index fe03dc916f..f5ce206b93 100644 >>>>> --- a/hw/display/virtio-gpu-virgl.c >>>>> +++ b/hw/display/virtio-gpu-virgl.c >>>>> @@ -803,7 +803,11 @@ int virtio_gpu_virgl_init(VirtIOGPU *g) >>>>> { >>>>> int ret; >>>>> >>>>> +#ifdef VIRGL_RENDERER_VENUS >>>>> + ret = virgl_renderer_init(g, VIRGL_RENDERER_VENUS, &virtio_gpu_3d_cbs); >>>>> +#else >>>>> ret = virgl_renderer_init(g, 0, &virtio_gpu_3d_cbs); >>>>> +#endif >>>> >>>> Note that Venus now requires VIRGL_RENDERER_RENDER_SERVER flag to be >>>> set. Please test the patches with the latest virglrenderer and etc. >>>> >>>> The #ifdef also doesn't allow adding new flags, it should look like: >>>> >>>> #ifdef VIRGL_RENDERER_VENUS >>>> flags |= VIRGL_RENDERER_RENDER_SERVER; >>>> #endif >>>> >>>> ret = virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs); >>> >>> In fact, we have rebased to the latest virglrenderer: >>> >>> We check both VIRGL_RENDERER_RENDER_SERVER or VIRGL_RENDERER_VENUS in >>> virglrenderer, alternative of them works. >>> >>> https://gitlab.freedesktop.org/rui/virglrenderer/-/commit/c1322a8a84379b1ef7939f56c6761b0114716f45 >> >> All the extra changes you made to virglrenderer that Qemu depends on >> need to go upstream. Please open all the relevant merge requests. Thanks! >> > > Dmitry, sorry to late response, I have created relevant merge requests > below: > > Virglrenderer: > https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1068 > > Mesa: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22108 > > I'd appreciate any comments. :-) Thanks, Ray. I'll try to get to the patches soon. -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Tue Apr 04 01:11:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 01:11:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517616.803221 (Exim 4.92) (envelope-from ) id 1pjVCX-0001pF-HO; Tue, 04 Apr 2023 01:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517616.803221; Tue, 04 Apr 2023 01:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjVCX-0001p8-EE; Tue, 04 Apr 2023 01:11:09 +0000 Received: by outflank-mailman (input) for mailman id 517616; Tue, 04 Apr 2023 01:11:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjVCW-0001ow-31; Tue, 04 Apr 2023 01:11:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjVCV-0000ix-VQ; Tue, 04 Apr 2023 01:11:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjVCV-00064T-EH; Tue, 04 Apr 2023 01:11:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjVCV-0006FR-Dj; Tue, 04 Apr 2023 01:11:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NGuRm6LRtwdRikEnpctEtxAxJAPOwnanjb4jTii76sI=; b=cEOjz3wxxOzMyX912Cb+XwCiV2 eBOwdOP6mKtcDnteOJrxrhnASU9qpCGCMEaznPCgue9V8jwufWgfoqcPzYOWtG1S19Yvvmb3+JSYp wFYkQa5Do7uMJOkg0uUNVu8pWnt3QYx/Z/+2VMQ2bgijlwPybTwEKnYJohe/kkrKhGXw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180130: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=148341f0a2f53b5e8808d093333d85170586a15d X-Osstest-Versions-That: linux=7e364e56293bb98cae1b55fd835f5991c4e96e7d From: osstest service owner Date: Tue, 04 Apr 2023 01:11:07 +0000 flight 180130 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180130/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 17 guest-localmigrate fail REGR. vs. 180116 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail REGR. vs. 180116 build-arm64-pvops 6 kernel-build fail REGR. vs. 180116 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180116 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180116 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180116 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180116 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180116 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 148341f0a2f53b5e8808d093333d85170586a15d baseline version: linux 7e364e56293bb98cae1b55fd835f5991c4e96e7d Last test of basis 180116 2023-04-03 02:26:51 Z 0 days Testing same since 180130 2023-04-03 17:12:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Brauner Linus Torvalds Michael Kelley Mohammed Gamal Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 148341f0a2f53b5e8808d093333d85170586a15d Merge: 2d72ab2449fa cb2239c198ad Author: Linus Torvalds Date: Mon Apr 3 09:41:24 2023 -0700 Merge tag 'vfs.misc.fixes.v6.3-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping Pull vfs fix from Christian Brauner: "When a mount or mount tree is made shared the vfs allocates new peer group ids for all mounts that have no peer group id set. Only mounts that aren't marked with MNT_SHARED are relevant here as MNT_SHARED indicates that the mount has fully transitioned to a shared mount. The peer group id handling is done with namespace lock held. On failure, the peer group id settings of mounts for which a new peer group id was allocated need to be reverted and the allocated peer group id freed. The cleanup_group_ids() helper can identify the mounts to cleanup by checking whether a given mount has a peer group id set but isn't marked MNT_SHARED. The deallocation always needs to happen with namespace lock held to protect against concurrent modifications of the propagation settings. This fixes the one place where the namespace lock was dropped before calling cleanup_group_ids()" * tag 'vfs.misc.fixes.v6.3-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping: fs: drop peer group ids under namespace lock commit 2d72ab2449fa9fce8f6898fd5adda10497f7c111 Merge: 7e364e56293b f8acb24aaf89 Author: Linus Torvalds Date: Mon Apr 3 09:34:08 2023 -0700 Merge tag 'hyperv-fixes-signed-20230402' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux Pull hyperv fixes from Wei Liu: - Fix a bug in channel allocation for VMbus (Mohammed Gamal) - Do not allow root partition functionality in CVM (Michael Kelley) * tag 'hyperv-fixes-signed-20230402' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux: x86/hyperv: Block root partition functionality in a Confidential VM Drivers: vmbus: Check for channel allocation before looking up relids commit cb2239c198ad9fbd5aced22cf93e45562da781eb Author: Christian Brauner Date: Thu Mar 30 09:13:16 2023 +0200 fs: drop peer group ids under namespace lock When cleaning up peer group ids in the failure path we need to make sure to hold on to the namespace lock. Otherwise another thread might just turn the mount from a shared into a non-shared mount concurrently. Link: https://lore.kernel.org/lkml/00000000000088694505f8132d77@google.com Fixes: 2a1867219c7b ("fs: add mount_setattr()") Reported-by: syzbot+8ac3859139c685c4f597@syzkaller.appspotmail.com Cc: stable@vger.kernel.org # 5.12+ Message-Id: <20230330-vfs-mount_setattr-propagation-fix-v1-1-37548d91533b@kernel.org> Signed-off-by: Christian Brauner commit f8acb24aaf89fc46cd953229462ea8abe31b395f Author: Michael Kelley Date: Wed Mar 15 08:34:13 2023 -0700 x86/hyperv: Block root partition functionality in a Confidential VM Hyper-V should never specify a VM that is a Confidential VM and also running in the root partition. Nonetheless, explicitly block such a combination to guard against a compromised Hyper-V maliciously trying to exploit root partition functionality in a Confidential VM to expose Confidential VM secrets. No known bug is being fixed, but the attack surface for Confidential VMs on Hyper-V is reduced. Signed-off-by: Michael Kelley Link: https://lore.kernel.org/r/1678894453-95392-1-git-send-email-mikelley@microsoft.com Signed-off-by: Wei Liu commit 1eb65c8687316c65140b48fad27133d583178e15 Author: Mohammed Gamal Date: Fri Feb 17 22:44:11 2023 +0200 Drivers: vmbus: Check for channel allocation before looking up relids relid2channel() assumes vmbus channel array to be allocated when called. However, in cases such as kdump/kexec, not all relids will be reset by the host. When the second kernel boots and if the guest receives a vmbus interrupt during vmbus driver initialization before vmbus_connect() is called, before it finishes, or if it fails, the vmbus interrupt service routine is called which in turn calls relid2channel() and can cause a null pointer dereference. Print a warning and error out in relid2channel() for a channel id that's invalid in the second kernel. Fixes: 8b6a877c060e ("Drivers: hv: vmbus: Replace the per-CPU channel lists with a global array of channels") Signed-off-by: Mohammed Gamal Reviewed-by: Dexuan Cui Link: https://lore.kernel.org/r/20230217204411.212709-1-mgamal@redhat.com Signed-off-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Tue Apr 04 04:10:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 04:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517624.803232 (Exim 4.92) (envelope-from ) id 1pjY0E-0003Cy-C3; Tue, 04 Apr 2023 04:10:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517624.803232; Tue, 04 Apr 2023 04:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjY0E-0003Cr-8Q; Tue, 04 Apr 2023 04:10:38 +0000 Received: by outflank-mailman (input) for mailman id 517624; Tue, 04 Apr 2023 04:10:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjY0D-0003Ch-FR; Tue, 04 Apr 2023 04:10:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjY0D-00067W-Bt; Tue, 04 Apr 2023 04:10:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjY0C-0004Hf-SP; Tue, 04 Apr 2023 04:10:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjY0C-0005Ir-RP; Tue, 04 Apr 2023 04:10:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UaSrjTFr7NlGVotpBsXurKBxjodXIRhN7GGHzpHI4EU=; b=6yuVXNHZNy+n7XXri1U9eMQCX5 f0t1EwzH4StdYjnCNsdcQlnG2b8g3KwEOzIpR1AOe323swtopah6xAph8PTk2HUtIDnQ3RQyolxls x6iffoh1+ugM6eyqxgKj6IQwYSjxIS1QHxueIad0aGnn3+ggyBYNDCtihxH+bYlzv4rk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180126: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=bfa2e6a246225233f09a2523939e01dcf83bca4c X-Osstest-Versions-That: xen=d6e0b4c41a38655ade7ecb566e8b2961282769fb From: osstest service owner Date: Tue, 04 Apr 2023 04:10:36 +0000 flight 180126 xen-unstable real [real] flight 180132 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180126/ http://logs.test-lab.xenproject.org/osstest/logs/180132/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail pass in 180132-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180115 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180115 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180115 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180115 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180115 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180115 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180115 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180115 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180115 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen bfa2e6a246225233f09a2523939e01dcf83bca4c baseline version: xen d6e0b4c41a38655ade7ecb566e8b2961282769fb Last test of basis 180115 2023-04-03 01:52:10 Z 1 days Testing same since 180126 2023-04-03 15:09:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Oleksii Kurochko Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d6e0b4c41a..bfa2e6a246 bfa2e6a246225233f09a2523939e01dcf83bca4c -> master From xen-devel-bounces@lists.xenproject.org Tue Apr 04 06:37:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 06:37:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517642.803290 (Exim 4.92) (envelope-from ) id 1pjaIH-0001Gw-Un; Tue, 04 Apr 2023 06:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517642.803290; Tue, 04 Apr 2023 06:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaIH-0001Gp-R6; Tue, 04 Apr 2023 06:37:25 +0000 Received: by outflank-mailman (input) for mailman id 517642; Tue, 04 Apr 2023 06:37:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaIG-0001Gj-Fi for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 06:37:24 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20613.outbound.protection.outlook.com [2a01:111:f400:fe1a::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2642e993-d2b3-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 08:37:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6989.eurprd04.prod.outlook.com (2603:10a6:803:131::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 06:37:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 06:37:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2642e993-d2b3-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgiPZ83m5kwIHcBbRDEFp48bVUAOOTXKJlxGJP62hYe0uFNRjUzi8SuyN/Wdfp+Ky85EbnKQ8yrRWKZrVRek2Y9EEPaYEm9siYtbUL4MfYgiiUlPrByZzNBOcvzgDS1T7hjv712sn6LMOBeqNsHHWklKwiOhjufT0ELARwpkoI27D4GhnWiZFeQdUStKyVaNVNsZchdH/bIpV9Z3kKgZoE0LUGq5/+fLUF0uYpLLMsMrrjEzfTGZnmDvrSV8aJeidc83nTOlybt6uSs7IjLsMpckYBrzyjQeDb7C3sOm/mc00VAhDcLwRN2sTbb+q19DkT2WwN/aVQwb3ep2QjwXXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCK7+KxNPVlBfCrlOenGmTflrOgFep/xixoemxsHHV8=; b=nPf/VyMWmsahspydfceckauCxIwnDIpDHn6ElcXJQrZhMj5ert2z8uS5NdY6moFrBLTS44eivQ85S5/BZp2/uINqnkbZUSaGXL4e8pgp6r5EecBDkMvquH6a7350NVShdCb9xAkAe7A7CQ3eopYfubJhk+4nZTfUFzVRJhJLP+vxBFhKJ6bXLDoTpC/U1vZzv0rjlPd7LzXH/EkcxbN8B/hYxNWJd1Odd4pRIfHNO1xp/p/4e6RY77suVJ2NSrwgaJiuHJMn1F4CE4SwLfT+5H88UzgPXJamP4OKQvKz1Ou+vZNd6E6DYEL8NyyQ2AqybF62seByNM9T2Y1K/3a+Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCK7+KxNPVlBfCrlOenGmTflrOgFep/xixoemxsHHV8=; b=wiXbskfFx4wIgpYSY1DL1Vu+JhDBjd1wGekAVbx0f9StkxQeLYuEGdtrauxHC6AROi7hGX5o7I9H/wWNHla46GY6pAVz8XAlM1tXUC2kXwtWRmt9CJkr9LpdEzMkH66ois0Sox8GBQhmG6JMg/VW67F+8zzn0DAePCKhUPafN2TIdlmVb6uCVqd69ncimIsJnqGFDIPKa1AVNWw2K7KwLGuBaeHJjefd/0VJ9azniEe94Bgx0MgBYbqvyKDzu5eyxtrBF5vSHmGCXpLEiYGkt0W2g8hlQggCQYp1dNZiaHcD6zeZdZM+76miVA/5tmZNtar6sXBgHStb8uUpYlQtmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8353df4d-44ef-e39c-9a66-b6a7a73d5ff8@suse.com> Date: Tue, 4 Apr 2023 08:37:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard From: Jan Beulich Subject: [PATCH] x86emul/fuzzer: re-arrange cleaning Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6989:EE_ X-MS-Office365-Filtering-Correlation-Id: 6aab12ff-9bb6-49b7-2e32-08db34d708de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hvoakpgHPL6PIg/ap+VB3yl59RzmXC0QzhxXmR1drflj8jN0rnI9ng6klRH8RkffUC+/hHk4HI2fVckZZ2G6OhTssMOD64LjnbHxv3v1f+wLzl+Ejemy5SmGoH0xkGmIwgqMlWihmAyDNQgAkN8ea3+C0ICsztkvnFXPweaTm+6heifLRcva3RMb7WnLHyWNCIrnu5NooY1vwGjJvy7WbCkR8ZQ7PBpICJgX6D1GsyrXL234mFpJgzZBxdwxX7Zj5C1O14X8KkorMKatXGN+AlsBw3dD9Y1FPOS8g20kaCW71jjB1bqR/raKCYFEam4otGtkxt9eKL/UIJGorGrjDXMLzCNfnp14x/Cjxu67wmMvi5D509Yr0LjuLUCm5x/05TF5tZ69oOjH7xZs7mOhuH9Ntk6n3E5nz0p9GTatWTFy+GgUpXR36DaQ21P6AcDobJVi63ShY+rS92iskb2torwu3QGmji4YjHysTtlBiSIknzUA+U7GPCUZLae/332hdmCl9qMx0+kN8q3Gp8ftemH8vdp1VzuA+RILXOZAS8/Y9pFT94mc+NYgWZSjHdiyU5I9NWT+bCKrqF9fImdlRCQCKuoqnjX3RV4fXUPgciGzNTcSqmWAhG0aOF6mawIJedGhDmL2KB0L16rqJh2kLQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(376002)(346002)(136003)(396003)(366004)(451199021)(66946007)(478600001)(66899021)(316002)(54906003)(5660300002)(8936002)(36756003)(31696002)(2906002)(4326008)(86362001)(6916009)(8676002)(66556008)(38100700002)(41300700001)(26005)(6506007)(6512007)(6486002)(83380400001)(2616005)(31686004)(186003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGQwK1FHQUljWkFRcTl4ZDE5RzFJSmFYSnAwRUdhbnd4WEcwcStVL3ZUQkk3?= =?utf-8?B?NmlIZkdsQTlDYm5mQ004WFAzaUtZd0xkeU1lY01EWlJINmFZVHRZdkVFaXhZ?= =?utf-8?B?cllFWHJObnVodWNwTjFBSDBYbk4wcjhiQzZPZkwydXFUNGxscVRMaTlLaUZu?= =?utf-8?B?a1VtS0dmbGVzb3YrMFhrUHV5ZHgrbnBZRXZYWUcvalRvSEtkRnhQQmlIUXhw?= =?utf-8?B?R3o0V2d5QmJRcXBUUW9xRmd0a0YzaTFJOGpBd2pHWitIWmFtSFlHRk56Uitq?= =?utf-8?B?WlJZMk5MNml3aVJaejRXUU5WVy9hSlBzbnY2RDIyT2RwU2E4MlZnV1BwWVJQ?= =?utf-8?B?RXIyTHgxT1Q3c0UxVURuTHZOajMyWjRsbjNkUXdiSzZkaU5hRG5Id3lvK2ZT?= =?utf-8?B?UkpSQlFNWktYekNkcU1DTURWamVKQURpSDA1MkV3Vis3aEdZOXhucGRXYVlJ?= =?utf-8?B?b2VtazY1N1dxcUh0cjdqWGFCUHpnZXRFbkkrN0VDbm9TZE5pbE5jbExIL2tN?= =?utf-8?B?SXd4bXJqcTcvQ05jdDJtMk9YcFFIVWNFMlFsNGc0OWgzN3dwc0NGY3pVcnlX?= =?utf-8?B?SWw4QUNBemhPMGYyWEl0L2JZamV6clBYV3paa1gwRW9Xbmh2MzV0ejlyVTF5?= =?utf-8?B?Qm04d3puZTUxSmNjVTUweEkxcnZ2NC9kRnhNcENHNUJZM1RSRGU3RmFEV09L?= =?utf-8?B?ckptZFZVUDF2bFpDekFiZUt4c0ZqSnFYckVRS2lZZGo2ZzdWU0MvYkFsZHlG?= =?utf-8?B?aEhLSXdkVDJHano4VlNRNVBEOW8vV3d1ZHVKdWdEN3pvY2d0NXM4YkRKdXIy?= =?utf-8?B?NC9LbFg0RllOOERDVlU0Mkhtcm1CLzN1OWhySHRQQ3FoRTl1eklvNlQ2dVhj?= =?utf-8?B?eWVFUDF0cG1FS2RFV0hHK3ZUZHBKdGUyYTJiYmU5SXl6OGhIbnJxZU1LNUhT?= =?utf-8?B?cFJzNVZHelE1dmNPZVgzUDJSeDhkRUcrTTFydnZMRS9vTUZGNk54Y0U0d2JT?= =?utf-8?B?VmN3TDhReGt6OVc3QktqQTZ6N1h6TFpFYWhkL0RuQklrRWJtaGFuRlMxdUIw?= =?utf-8?B?N3JvRVJ6NHIwc1FXa0xSMkNaMlRwQS8xd2lkMnlGdEZDQTNMVUhGL1pMNmpP?= =?utf-8?B?OEpzZkVDenU0OEUxL3MxTlRZYzhSRVVCVmdLMmlvc1VyMUFKQXBkZGtpeGNI?= =?utf-8?B?d3JmNlQ5THQxSVhxbXF6UXpkRSsyRnlhUFF1UjBKSjBYOE0wWDh3Wm9leVZy?= =?utf-8?B?S2M4bDJwV2cxZzNma1pUUnk0Qmg4MHJ6Mk9uREk5SGNGNzFpYlBzL3FKUUhJ?= =?utf-8?B?L2N5UWlhMEoraHFxeERBYXhZR1hGN25DN1RnYjlGejBzMUwwYm9LVE9TaHJX?= =?utf-8?B?S1FkQ0hRNjJwTEpLWUtIalNscWxieGZDamNDMytiblB6U0NuVXZhaklNU0Fs?= =?utf-8?B?aEZJYlMwcWFCRDJQR0tPdFp5dFJJRkRuVnVRR21JODFyUDhEU1A1Tno0c1pl?= =?utf-8?B?S0xUdnRjZFk4MEQ4WHUvV05rWWJMSU0wci81SFBDWmhqT2MrM2NxTjR6YlBI?= =?utf-8?B?VnVabG91MS8xV1B5Q0dJZXhDNktpbWFGUDRHMklrQkwwU2dpRldlMEo4Zk02?= =?utf-8?B?a0VRMzhBL21RUGVDRzNtZ3BrZnFxMGNKYlZoYU5xa093bnNWZHI3ZTljMmVz?= =?utf-8?B?aDJaVkNXamp2Q1BzTlJ1VmFKd0ZyUm9nbDBJbzl5T1VsTm92NlBVQW50emJr?= =?utf-8?B?Y0xUTElnYmNlUWIrWEovYStCVnVtMGVxamVlck9tak5vbDlOUjkzY3lSeXR6?= =?utf-8?B?dm9Sd3VxUURZV0VVQjFNdzNDZzZibFIwNnR6VmIxZjFMLzhQbXdYcWphODFN?= =?utf-8?B?V1Z3RTFqY2FFNmlIOCtlVEM4azAyYmdlbnJ0aHZZOHZrbzQ1M0ptRWhVUmFj?= =?utf-8?B?bnpkRlhQYTZ3blBmdjE5OU4vUjBsbXRjL2ZlUjdCMStDLzUySXVJaEM1MXlS?= =?utf-8?B?MEtGWDVaVTNTWk1hdzJWVEZGc0szcXZrOFgxdzE3UDByOXZzRGFHZGlRcVBi?= =?utf-8?B?aktMenJkZkE4WGozS3cvV2lBeFVRMXlYcDA0SUpwY1lWa09Ma2ZXT3doV1JW?= =?utf-8?Q?CJLfO54vEI41kYOrn7M0YvneB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6aab12ff-9bb6-49b7-2e32-08db34d708de X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 06:37:17.6602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UUHPJcy7JpkbBQ+uNhXTpuxt8zLGz0Jc9k0bIEkk+bFSIGxoVJsrL5rgu2tROfGDcFCRiOnE2aKSe6W+eEMTpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6989 The latter of the two commits referenced below converted x86_emulate from a symlinked dir to a real one, holding symlinked files. Yet even before that the split between distclean and clean was suspicious: A similar split, removing symlinks only in distclean, doesn't exist anywhere else in the tree afaics. Fixes: c808475882ef ("tools/fuzz: introduce x86 instruction emulator target") Fixes: 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- The use of FORCE also looks suspicious to me in the rules creating the symlinks. Supposedly that's to deal with the source tree moving, but is that really something we need to care about (and if so, here but not elsewhere)? --- a/tools/fuzz/x86_instruction_emulator/Makefile +++ b/tools/fuzz/x86_instruction_emulator/Makefile @@ -60,11 +60,11 @@ all: x86-insn-fuzz-all .PHONY: distclean distclean: clean - rm -f x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c .PHONY: clean clean: rm -f *.a *.o $(DEPS_RM) afl-harness afl-harness-cov *.gcda *.gcno *.gcov + rm -rf x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c .PHONY: install install: all From xen-devel-bounces@lists.xenproject.org Tue Apr 04 06:38:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 06:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517646.803300 (Exim 4.92) (envelope-from ) id 1pjaIs-0001mk-CI; Tue, 04 Apr 2023 06:38:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517646.803300; Tue, 04 Apr 2023 06:38:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaIs-0001md-8b; Tue, 04 Apr 2023 06:38:02 +0000 Received: by outflank-mailman (input) for mailman id 517646; Tue, 04 Apr 2023 06:38:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaIq-0001kf-1I for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 06:38:00 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20608.outbound.protection.outlook.com [2a01:111:f400:fe1a::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c90218e-d2b3-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 08:37:58 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6989.eurprd04.prod.outlook.com (2603:10a6:803:131::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 06:37:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 06:37:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c90218e-d2b3-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EtIZu2Q2yiS1eXxPR8p4qTQcO8AMasHTE/9ow7bE2JzE9WRin2B4CzIHCzQ3dn49seQF93yIluSz/5SnLZr8LsfC/IYPdmydu5ikTywb0wEHnAJ6oIgbYod+D596tLwGBjZjjc2JSLOTUw1/OcfjufF17FIXwMpqIXdqErwDWCcdHhYY/rrQt1a1yaqBq/sd6pPBY4xYJiIFky1RoLI4fsBn1/Kek/wQrnQuu9rPwfqWV4ijmxdVUD7SWsz75PModVtK/rXHigvu55x+HmtMhSGFXN2cLufGqxCS7FT7BZMI4D4tP8wdkfp1lfugqKS+eIM+pzHPQSGpHoJVhwmGIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9nxbvcdtu2fDPhGz7G7bOIoBMTqBuVwAFgntN9b6L3M=; b=L3zGQgqXHKxubaXksa5ZsBYheFm8glh+C6YLBo2CSTzjpCPfF+sX5CntHo9Bnqrh1OqaYRxLtmJbVdgk7ndiRGYQNRvSLCHut+nUvJekwV7AbpncS1a6QJylBS+t74qC3Ez0ptZJBmlRvivpQMEk6CVycQjAOjbad49/lPidsLYIyreF6WE+xErkpSRUa94eBKc2ZLnUbLqiPJUfr6bfE4z7Mx3ip1JVV0KN7HvNcIErJ+T89HrkWmUT5wepUkIE1ghoubFXZ0gznBBShkp8IrMz8qcgT8LthIWL0vFdNia1X1hSas016wyChzxoi8BMcQmLySZbNRHJVIWbPIrAWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nxbvcdtu2fDPhGz7G7bOIoBMTqBuVwAFgntN9b6L3M=; b=XPgYU6rbrxO2s5ejGWNdYXPnTm1UoGwHrf2q/5/ddhikhV1vqZY2vwOSSOQ5+3j3Ben9psC97oAKUB1wqCu7e7RM9+O03nai4f6sNIt7OuZq5iKgePIu7msA8KapVqVhA8r0P+nxHsgJvkmk01FyfduUyDVv/nYNfRejWWd4A9NZJ4Ye3XFkm7OEovUo8eb0FzI6OfAIyN8yzHGVUd5HczX/4bqyXJRDUn/fe/yWbyJ+T6sQ4eyZ9UiC5LfXqqRiCEzsttuT/pYJh1cjk/Mub7WNc/d99zI+YmKfGJf+oBoNT9Hi1NmSl38UPNhtg7ehBDfEMElx3+lELFqg6KMDpQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <515bbf07-91fa-1932-1be1-1411f7814e6e@suse.com> Date: Tue, 4 Apr 2023 08:37:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard From: Jan Beulich Subject: [PATCH] x86emul/test: drop bogus .PHONY Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6989:EE_ X-MS-Office365-Filtering-Correlation-Id: 14c0fabe-515c-4cf5-de33-08db34d72023 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8v45MbdvZrr05/tp+ZTvzkDrUxuBsgvXnm9I25qRU0gXVrZ9yCmJVqYrossXYraqT2fefU3lC9wLsjae4u9TY5J1xH9lRCjU4aczaYd0js7EgNTivkWC8OKTAyldEFGbVmmIVM95nYXfbx9ILIDpkAw/bUnoCORcU1wF/XHumVA6rN1p4b18Jpyp0zwv3nOlULKjLW5bevDGf+yol7iKXhMVKFJXzjqUaHtkoZjvZtn8EKtqWEWDzDlaOo769WUsX8Qz7Q7N0QWEZKbUnXL1D5Uqsd+PJvZnlW4y1e3B9Y+2Wr831ymZy9hERjKFxI+eStTSZrifpFQPi8n4bgFynchUnKCHg2kQiJxhSjdVwwPGUmKJnvPHmTqQOl+gAw7Gyx4LpoQyoyR3OWUOtAL556XmuA1EpXX3D+y27j8Ejn+IoXGFEBXA+qG+a/U4WZCsDBK3xzZ2EdSlHCBCVCFqHiROW+e9AIfDpRUuG35qSj8EQAuHn8F0/w3SRZqTimjfDTu71J6IchC6jLhol7Iz3V1nkhYyDIVphOsd2Mi9NRlpFej7qE+6DXiRZ6e4LDAjI6mLkr7xiRJgdkbIDKQF6CBxhW61XOLR7rPEoXqLmkZ6T2fthjYyJ0jpgRUizjx5E2bLdcsoMqIjQUhEdcYhOi/7qLAKeKOz7orzqSeC3qisfAZaFsVXOwaLZrRH8KvB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(376002)(346002)(136003)(396003)(366004)(451199021)(66946007)(478600001)(316002)(54906003)(5660300002)(8936002)(36756003)(31696002)(4744005)(2906002)(4326008)(86362001)(6916009)(8676002)(66556008)(38100700002)(41300700001)(26005)(6506007)(6512007)(6486002)(2616005)(31686004)(186003)(66476007)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1BEK0FabzBqQTZDRTlmOHdtS2lDb3Q5KzhmMnBBajhOdXdvcG9jSEUwU2NE?= =?utf-8?B?ZE56Vit1NTdDUGZYT0FhcVBoWFdUWi9uK2t6dXdidVNCOG5CT2NpQmxPdnZZ?= =?utf-8?B?VHVsU3NCSGJDRUk0QkJjT29mMlUzeEVSamVVYWJPMDRYbFJnS3M0bmlzQTZM?= =?utf-8?B?Z05qVmNrRlAxRHZneHpTVUo3NitVaUp2SnVHcnJYbHovL1hzd0V2UkZObmIz?= =?utf-8?B?cHd6eWpNbCtQQlg3ZmVYU0VtYVRTOHNsZzh1L2VMaUFERkE1NjBlYXIzam1m?= =?utf-8?B?V2JsMktMNGE1ZUQzem8yaCthMEw0dERUNzhLemJBSUtqNVpWOUsxU3RlOHRF?= =?utf-8?B?OGRITTErRG5ESW5laDBaRGNiN1V1TTlRRisvVE5OKzJicTVWZExLbDErbDIx?= =?utf-8?B?N3hFeUI2ci9uenhrUW90c1VoUmZzRVpxSDhhOUNCaGtjc1RhZjJ1dWVPWkxh?= =?utf-8?B?ZFh2dmNwSWkxbE1kOTFkdUFzbC9DMDZOc21RSGxHUWorM3lmRVdaMXhQTmFC?= =?utf-8?B?UUxlZUtCU3dFVjZaMzNyU2VsR1kvdHNacVBXZkxBbnpRVytSeUNZMnpJcWVW?= =?utf-8?B?TzV2S2lKNmF4SUtFRGhsWkk4TzRkclZWUW00VE5nM3VBZkxiTExsdDdCZ0hW?= =?utf-8?B?T29SeEJyeVVaNTVRU1BTckJKNDk5MW5XVFNzeTZOcjdXTFp5VXN6aVhNL05K?= =?utf-8?B?bTRyK3hYSWNRa0IxVzhJbUpvZzBYcTZ4NWliTWxodUlJb0NRODBNY0Rzd2w0?= =?utf-8?B?UFQ2YzdCUWJ3QTBJR0FlckVTN1hvUlRKYit2ejJyditLQWZZRDB0QThHWHYv?= =?utf-8?B?UlFsOGFiTWN0UWVGLzBXTEN5SWJyV0pXR2Rvenl3WnFOUWp1Nm5SdG5DZ3Rx?= =?utf-8?B?cUhON1doSHc4RlZXUnVyeGxCcjlJQmI1NlBRdjFJNFcwb21VQllJQkh4Q0Nn?= =?utf-8?B?UU5XYW1Yb3dKQVFPYnJPN2poVEpwY2FOUlh4Vng5eWZac1A4UU1tWWNuWm0r?= =?utf-8?B?cVZvNFkzQkdrNXlMYnhDemhydG1qOERPekRHYU0zUVFaV0l0cmEyTVljN0l3?= =?utf-8?B?YWRuTThrUks0Z1FaZlUvL1NSL25DUFo2TkZJSG9jRmFGbkdGd0VPbTBJUEFH?= =?utf-8?B?Wlc1MUlFcGdKUG9WTmxlRGVsai9wVXNuZWJjaHVDTEQzdmtJU2hDY2h6ZGNr?= =?utf-8?B?R0xXdEV1LzlNcGs0NFd0UkJVeXk1anR3RFZOb2lqOXdYNXVGejE4RHhxNEtM?= =?utf-8?B?MnRKWUR3RnJZVk5LSFNWL3hjMDdPN2ozaTlLU1VxaEJicUJ6NGFhTE1Ia0pF?= =?utf-8?B?UDBkOVhQZmRieWNnKzhFTnVqUmVGbUg4QUVLN1hxMGFTWHNQb1ZxVmEyUlIx?= =?utf-8?B?Mjhja0RhVDNKTzB6bFIzbXM2c29IazR3V3U1eGxpdFprKzU4WFNXOUttNnZo?= =?utf-8?B?MTZ1NFgvY2tVNmxUSFVBbkpCNDFZQVU4RmZYTWlWQzFjUFI5Z250Sk9LaFY4?= =?utf-8?B?bllKYkEwUHR2ZUdKY1pxK1Eyd1ZidExlTUZjbEN2Y3ZUZ3RscnZxc05WOGNQ?= =?utf-8?B?UDVDdGZOYTFRNkV4ZFVlY2Q4SlgwczZZelRIcHh3amhFbldmOVNaMTlBbGJx?= =?utf-8?B?SjMrV3ludVBHNjF1d0szUCtmdCtvZGxLRldMSmY4U1BjNHgxWmRvNWpFS2FB?= =?utf-8?B?ZWlPNzJWK3doWjArQWUyT1pJUFpRTnRPZXFmT1YvZDdrbFBFL2N2QjVoZllt?= =?utf-8?B?aUxBbEJtaHpnWjQ1RXc3N0VHQlczVTFRcS9tVGo3bjZoTDAvVGFTUlljUmJP?= =?utf-8?B?UUZkR1IreDB3MmoxZ2JoQTNiYno5bWkwQXJxUnMvMnJ6ZFpGc1RqZ0dnNkg2?= =?utf-8?B?N1Z2c0QrQWgxRkUxd29LVytSbGZQbmc5bWFQeVVzdEFzTm5OUk1kRVNXbk1Z?= =?utf-8?B?R0RnL0lXTWRIYTBaOFBDUml3UDlHMmZCK0lDaW1xRUlnamVRdlpHVVZkYllL?= =?utf-8?B?N0VGaXBxVVlXL1BrREY4VXNnS1dPY1ptN01VZmtqTUZYWFRUc0xZZUpyaEc1?= =?utf-8?B?d0dkVFNISmk1OTM3YlNlazBqcFlGYTJhMnREeE9DNEdjWTlJTTIrMTFKU01u?= =?utf-8?Q?1EV/+1Sq0BdLMBGcwY0AV5+lx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14c0fabe-515c-4cf5-de33-08db34d72023 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 06:37:56.7225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C+KkG4e+DOvljm5O5UTrR5Wlwak3JMgdN6WCWw9TBiQsBTJHhXNdG1FKtPIAgrVhDXao+0thRzFhPfnML1Xp4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6989 x86_emulate is a real (directory) target. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -278,7 +278,6 @@ else run32 clean32: %32: % endif -.PHONY: x86_emulate x86_emulate: mkdir -p $@ ln -sf $(XEN_ROOT)/xen/arch/x86/$@/*.[ch] $@/ From xen-devel-bounces@lists.xenproject.org Tue Apr 04 06:41:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 06:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517649.803310 (Exim 4.92) (envelope-from ) id 1pjaLu-0003FR-Q5; Tue, 04 Apr 2023 06:41:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517649.803310; Tue, 04 Apr 2023 06:41:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaLu-0003FK-NA; Tue, 04 Apr 2023 06:41:10 +0000 Received: by outflank-mailman (input) for mailman id 517649; Tue, 04 Apr 2023 06:41:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaLt-0003FC-MR for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 06:41:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0c::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad84d469-d2b3-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 08:41:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6989.eurprd04.prod.outlook.com (2603:10a6:803:131::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 06:41:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 06:41:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad84d469-d2b3-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YhAYVrOsCkH3oFI1IWJuSAOHjQeCyzBcS1F/4v7Df+WS7mdqw8ER7e9r9rLSAFYu7+DND1buzmzJsHdUtnAKllUiQqqV0+U5yQMCKDMu9h180DKu3EYysVaQu8f54ydjpsd/cA/39x17QCFey1/N71mHi8BiwabA0qqDviJIZL72pn4XlMslEhSAiNH3fauCB28U/VahTBbkbFV1qCv1JoBrsdUa5v7tyhVYtyH2qvVYtqiaGFVcScAvg3KCrG+dRnL2TZKgGb7liV+Rhn7H2rMaj8xbHCyuahgXnxAei1qhqR+ETYRkrVW09hQ0YFqtNlJZvsrcFR2pycY11P8F5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K2UkOx6OFZmoKsDw4mTu+8TCCvL9Hmx+/sNsW6ojfnM=; b=lcKQ6cd7GFTbI0ZTOiQi6A9Zr2gUhnaM+BGTesWnCKVzoubfjNnWfDJUfODAWD52PRcSTjp40w7nx97wQImdFUzzbkYd/4YRr+bBcvR2Fh7RPC8oNs06teJaLoEJsrHOs1kUXcFW7SFOwk3bkgyLcDR5vVaAsMjVqbEscyxPaUpmq+G7eslsDXFEsIr9PFsktq1qXF2dNPrsZwxkUTp5sl3qz5xq/J+sUa3qeGHOdt7yuji2YV1K+Dlv1Xn5s+Uyyhr2M2CCPcintMiVZk1y/vLB06qlko2V5LLSBdw+N934hW2YhJm6h/bqYbTxK882+qlpav7519mUC2bV355wPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K2UkOx6OFZmoKsDw4mTu+8TCCvL9Hmx+/sNsW6ojfnM=; b=BGitEcbLQ8TjU/oYVRp8OmZwxgYSH0+5EpR9naFwFOrZJ0HIu/nW86b570LLoVns+wBIYoC8S2J1kS+9g6il7c4feBFCRgcshZTpd/aXHr92ogAddgZ4iU7H09n3/M+6HEgKFjTLUFvKVjJ91NrmhR9sNX4eNEW8p/FprUDSg8napQnv/VxCyvrHugAY2Yn0EZFNjEG0Vx/dFu30u+KgRomHO8C4rqY5PZa3H1ixLj0c+OrmjfEFan87UHY6kzBSBkRlcQPCY/fkNx4yCOkcptjYz6NujF8AO6Pc1uhRA4a7mRodore8BJ4/TIf3BMUaJEW5xxreX/iEqtLjSP3X6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c4ca4a1-1b68-5ee0-0434-e6c9ec7d1ef6@suse.com> Date: Tue, 4 Apr 2023 08:41:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Julien Grall References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> From: Jan Beulich In-Reply-To: <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6989:EE_ X-MS-Office365-Filtering-Correlation-Id: edc3c366-953d-4c12-fb39-08db34d790f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u3KmMZgbqvI7VKAIR6A5RcGph19vbIQMa7j0RFKvJ4OnMTqzAFFyymZU1S2MbByq9Sa4D3AF4Li1xnCuJbF6XylPRbZfi+fo86aXd8V6zkY5QQNfaajccL4wBm7RsA6JaPfdOBt5aPy8WwjoGNYzmtwgYLQSBdbufKTgkpqSNjND34UC5mwdhZ6PV3+si0TOAvswE9ijfRsfewxGgBdMg+QzJj3U7ti56FN9IEEWvz1U15iaRGyW/BUrnwe4jrtRuDe+0DpUOLzI+ozIBSTja5ijSNAT6It5bB38n2PP8P2t7YexTbfxif1cKI/LwsfFPixQIU/njq4pwUxtNoSWY2DoyCJ+8NgSKXhdar6J7CZhMEn2xrdSdhZL+Cs2U5NpjMo7eodU6eH9qDOzQcBciaa7DUw3KLkgtMBT7xY1DQxprtpdPerpPZ3PNqS5qhOGF2hfo4OV5GX8hWW8QF47bexgXGwQv3mrMyB0TISlEQrK164hvijn1c235xw9lbYGgTHSdpRs1oMmAM9ICYUj+uB1Jv9R2Ga1b+AQWqrajXs301vJ9abrflEo2iX3rWp1dLpBTvfQ1vnprNCEmTq4EP67n46uHUWYJI20NmF891dV3vP5b8erfPJUVo3QeBm5FJ8DaLCsK2e8A2MaLxb14sgkChRgUzpHGfX9GeyJUUs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(376002)(346002)(136003)(396003)(366004)(451199021)(66946007)(478600001)(316002)(54906003)(5660300002)(8936002)(36756003)(31696002)(2906002)(4326008)(86362001)(6916009)(8676002)(66556008)(38100700002)(41300700001)(26005)(6506007)(6512007)(53546011)(6486002)(83380400001)(2616005)(31686004)(186003)(66476007)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjMrVURVWTcxMXFNUFIzS3haWEJwanFjQXYwZEJDcE0rWmRMMWV6UklWa3Fw?= =?utf-8?B?Z3FVR2o3ckk1VVVQZXRWR25BaCtMN0g2M3ZyTms3MFZaNnh1elRybXNWQ3VZ?= =?utf-8?B?SkFHcHh1czV5UHdxSkhTZzE3VG9JeFo0UzFYRWxycmxud0RkdnlkemZIMUJP?= =?utf-8?B?ekgzNktVZUdwaWg2Z0sxR1lEbUxJREFMR2NJdjNyM2ErMS92UG5sVXBDRnpq?= =?utf-8?B?YllETng3VkE0UXpXVExYcm9YejBzUDJGeTMyQ00vVjU5K3NpMFdMa2tUVllj?= =?utf-8?B?UjFJZzEzR0x5QzhNTUxPVnJIRWdhek9PbExodFZJWXg1WnlMa2JZQzI1RTFD?= =?utf-8?B?ZTBRdHkzd2FXSlFCT29EKzFHTmgrUVdDZ1pRZ0FoVUF0Z2VWQjFaSElWSFV0?= =?utf-8?B?T3ptSHBQU0c4NldHYnVTSktNYlVWWkx6KzZidEJuRnVOZjFZUFpENS9FaDhO?= =?utf-8?B?ZHpiRVh0UTIzdW1kT094cjN5V2J2S0VLUTVlMXlLU2V4UzBDNWEwbUt2UlpF?= =?utf-8?B?WUlmTWwwT3NDbTNSUkhmckJXZUZlUC9oU1VwczZHYWdMWXpXbS9pRVVOSll2?= =?utf-8?B?NkxJa3BSYmxNSC9iOTR6QWpSQ2NFcm9WVDhYYWpKSGZpRHA4Mno5ZjVMSFc0?= =?utf-8?B?NXJiT3dJKzNGWTdhMWwvZlZQYTNlZGFnS0JjYXc1a3NMZTZMVTBSK3JHdGpO?= =?utf-8?B?VGZkUDJEQ2JDY29SNEE2Y09pai9lQkhGUU52bEcrTk1hTUtaWkh2UzE5b3hh?= =?utf-8?B?K2c4OWJnaGltVUFuWjlZV05PUFhjSmVxY2srakR2ZzlTZkF0MlRmblovZXV3?= =?utf-8?B?bUZjVUU2SFJPZmhjakFTcHlDQU9CQnl5MXJIY2RMVHpWTHBJNmpRWE1lQWRv?= =?utf-8?B?Z2dJR3hQR2c4S1N5Si9DZy82OWt2SXFKdHhveE12WlVNVkZHbWdBbVZaMkJN?= =?utf-8?B?dHd4NGJVWjJFT1VlYmFWSzMxRVhyVXNmdmN0eGtzTmxLZ1l2S0dZSUVLc3ZH?= =?utf-8?B?MVMvd1NocGNRNTFQem1zNGxmNHVKTDdCd0R6OS90d2IwTUR2K253KzFEQlA2?= =?utf-8?B?OC9PT2toeG9Ka0svbmozem9sMDBDZTNNbzRXdVVlY3QzclFBdzEvZEZlb1NU?= =?utf-8?B?UnFSTjIzTEViaXZjMk9LZFhxVURxeVVPUUpKcW5oWDMzcjljNlpmQ01ndzZD?= =?utf-8?B?SHNFTW9MYStwc0ZSY3lQNFhlMXhoNCtXMVNpSFBLS3R2NFpIMmZFTzYxVVF4?= =?utf-8?B?OXRsc1dKalk5MnpobWpWNnRET21zL0xRY1BjaWM2bnBvSVhFSG9PYjdQZGFD?= =?utf-8?B?eTF0b0cwWUZINExQNkZEcjhSM0lwNGwzZ0FoVy9MYThhdmxudzUwWHhQdmdX?= =?utf-8?B?ZXRxblc0ZDZ6eVBDK1h6dEtlNXFqcVl6RTZQSWoyZWZveEo5VUl6djc5ODJV?= =?utf-8?B?Vmd4eUhyRHI0NjFzTW4wdTBxaFlVUURWVFk3NlBOYzY0TG9FaVlIMW5LaFc5?= =?utf-8?B?R3NrSmJwWEhQSG5HSnN3VFVmckwyRHR1bjkrWkhQellhcXcxRUNXZEl5dHlx?= =?utf-8?B?ZldVRDdhcDNuSTRBR21IbEhTUUpodkprL3k2eUwySk1zSDl1amc2Q3BLbUZS?= =?utf-8?B?T1lrdDdKbG40UTRFRzd1bUFUY1FxM3diR0J2UmJMVWRUd0xPQTlRRUg3MWlK?= =?utf-8?B?UlhLWFAwWjZvcUc0SURPUlhjVHlGcENteU5LQzBBNlBucmtDVzZXQ0s0WlRz?= =?utf-8?B?a1B3L0VTTkpwcEtCaTFTNkRIelArZERwODVvS0dUay95MkRwUDZyaEMrMVcw?= =?utf-8?B?YmxsQkFBejdFbmRrTDcwYktOMVNIeUp1SFFDRWZsdXVuSDRidzBCR1ZjZXl4?= =?utf-8?B?VEU5d0M4VmNoTGFsd2NleGpYa2ZTejdJSDF4Vk9DeW1oNm50aUo1cXkrOHow?= =?utf-8?B?cnNQa0hmdUdZdlVJYm9zUXBFaVF4YWgzaHpScSs5R2UxOWlOVWhkZllGdFFj?= =?utf-8?B?Ukt3akVBZGw2SU5TQVdGN1RzM1pwNWxKTGtyTXBabXBWRjRNaC9rNUpGMVlk?= =?utf-8?B?T042Um9FL2h6ZlNBMzZQUWtjS1Z3Vk5lK0dsazQ4RG5GRXJtZHhxVnd5Rk1T?= =?utf-8?Q?GoIDP28E9A++AEnKiElxIWNLY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: edc3c366-953d-4c12-fb39-08db34d790f3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 06:41:05.9235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dD4ZRKvkD68n4VjLQhm144hMBJOLoL/onhONJiRvxCztAAo6iEtfp5XHqfagCldncCnl2lxituXGGUxwaIr8LA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6989 On 03.04.2023 20:40, Oleksii wrote: > Hello Julien, > On Fri, 2023-03-31 at 22:05 +0100, Julien Grall wrote: >> Hi Oleksii, >> >> I was going to ack the patch but then I spotted something that would >> want some clarification. >> >> On 29/03/2023 11:50, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/arm/include/asm/bug.h >>> b/xen/arch/arm/include/asm/bug.h >>> index cacaf014ab..3fb0471a9b 100644 >>> --- a/xen/arch/arm/include/asm/bug.h >>> +++ b/xen/arch/arm/include/asm/bug.h >>> @@ -1,6 +1,24 @@ >>>   #ifndef __ARM_BUG_H__ >>>   #define __ARM_BUG_H__ >>>   >>> +/* >>> + * Please do not include in the header any header that might >>> + * use BUG/ASSERT/etc maros asthey will be defined later after >>> + * the return to from the current header: >>> + * >>> + * : >>> + *  ... >>> + *   : >>> + *     ... >>> + *     >>> + *     ... >>> + *  ... >>> + *  #define BUG() ... >>> + *  ... >>> + *  #define ASSERT() ... >>> + *  ... >>> + */ >>> + >>>   #include >>>   >>>   #if defined(CONFIG_ARM_32) >>> @@ -11,76 +29,7 @@ >>>   # error "unknown ARM variant" >>>   #endif >>>   >>> -#define BUG_FRAME_STRUCT >>> - >>> -struct bug_frame { >>> -    signed int loc_disp;    /* Relative address to the bug address >>> */ >>> -    signed int file_disp;   /* Relative address to the filename */ >>> -    signed int msg_disp;    /* Relative address to the predicate >>> (for ASSERT) */ >>> -    uint16_t line;          /* Line number */ >>> -    uint32_t pad0:16;       /* Padding for 8-bytes align */ >>> -}; >>> - >>> -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) >>> -#define bug_file(b) ((const void *)(b) + (b)->file_disp); >>> -#define bug_line(b) ((b)->line) >>> -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) >>> - >>> -/* Many versions of GCC doesn't support the asm %c parameter which >>> would >>> - * be preferable to this unpleasantness. We use mergeable string >>> - * sections to avoid multiple copies of the string appearing in >>> the >>> - * Xen image. BUGFRAME_run_fn needs to be handled separately. >>> - */ >> >> Given this comment ... >> >>> -#define BUG_FRAME(type, line, file, has_msg, msg) do >>> {                      \ >>> -    BUILD_BUG_ON((line) >> >>> 16);                                             \ >>> -    BUILD_BUG_ON((type) >= >>> BUGFRAME_NR);                                    \ >>> -    asm >>> ("1:"BUG_INSTR"\n"                                                  >>> \ >>> -         ".pushsection .rodata.str, \"aMS\", %progbits, >>> 1\n"                \ >>> -         "2:\t.asciz " __stringify(file) >>> "\n"                               \ >>> -         >>> "3:\n"                                                             >>> \ >>> -         ".if " #has_msg >>> "\n"                                               \ >>> -         "\t.asciz " #msg >>> "\n"                                              \ >>> -         >>> ".endif\n"                                                         >>> \ >>> -         >>> ".popsection\n"                                                    >>> \ >>> -         ".pushsection .bug_frames." __stringify(type) ", \"a\", >>> %progbits\n"\ >>> -         >>> "4:\n"                                                             >>> \ >>> -         ".p2align >>> 2\n"                                                     \ >>> -         ".long (1b - >>> 4b)\n"                                                \ >>> -         ".long (2b - >>> 4b)\n"                                                \ >>> -         ".long (3b - >>> 4b)\n"                                                \ >>> -         ".hword " __stringify(line) ", >>> 0\n"                                \ >>> -         >>> ".popsection");                                                    >>> \ >>> -} while (0) >>> - >>> -/* >>> - * GCC will not allow to use "i"  when PIE is enabled (Xen doesn't >>> set the >>> - * flag but instead rely on the default value from the compiler). >>> So the >>> - * easiest way to implement run_in_exception_handler() is to pass >>> the to >>> - * be called function in a fixed register. >>> - */ >>> -#define  run_in_exception_handler(fn) do >>> {                                  \ >>> -    asm ("mov " __stringify(BUG_FN_REG) ", >>> %0\n"                            \ >>> -         >>> "1:"BUG_INSTR"\n"                                                  >>> \ >>> -         ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) >>> ","       \ >>> -         "             \"a\", >>> %%progbits\n"                                 \ >>> -         >>> "2:\n"                                                             >>> \ >>> -         ".p2align >>> 2\n"                                                     \ >>> -         ".long (1b - >>> 2b)\n"                                                \ >>> -         ".long 0, 0, >>> 0\n"                                                  \ >>> -         ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) >>> );             \ >>> -} while (0) >>> - >>> -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") >>> - >>> -#define BUG() do {                                              \ >>> -    BUG_FRAME(BUGFRAME_bug,  __LINE__, __FILE__, 0, "");        \ >>> -    unreachable();                                              \ >>> -} while (0) >>> - >>> -#define assert_failed(msg) do {                                 \ >>> -    BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg);     \ >>> -    unreachable();                                              \ >>> -} while (0) >>> +#define BUG_ASM_CONST   "c" >> >> ... you should explain in the commit message why this is needed and >> the >> problem described above is not a problem anymore. >> >> For instance, I managed to build it without 'c' on arm64 [1]. But it >> does break on arm32 [2]. I know that Arm is also where '%c' was an >> issue. >> >> Skimming through linux, the reason seems to be that GCC may add '#' >> when >> it should not. That said, I haven't look at the impact on the generic >> implementation. Neither I looked at which version may be affected >> (the >> original message was from 2011). > You are right that some compilers add '#' when it shouldn't. The same > thing happens with RISC-V. RISC-V doesn't know of a '#' prefix, does it? '#' is a comment character there afaik, like for many other architectures. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 06:47:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 06:47:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517652.803320 (Exim 4.92) (envelope-from ) id 1pjaRQ-0003uq-Da; Tue, 04 Apr 2023 06:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517652.803320; Tue, 04 Apr 2023 06:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaRQ-0003uj-AV; Tue, 04 Apr 2023 06:46:52 +0000 Received: by outflank-mailman (input) for mailman id 517652; Tue, 04 Apr 2023 06:46:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaRP-0003uN-70 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 06:46:51 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2062a.outbound.protection.outlook.com [2a01:111:f400:fe13::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7937d7a4-d2b4-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 08:46:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7972.eurprd04.prod.outlook.com (2603:10a6:20b:236::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 06:46:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 06:46:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7937d7a4-d2b4-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TD9pz/84qduABV1TQTEYHXOTnwmLiWEAMoA+2g9ssPxxgi6MeQd+6+5daIlhUApcY6yR/u4PRqCTC9BKfixH/i/5f+JvQv2ewH2hj6PAyk+7ZQ68kRslOt9aTosFnz9e/sJyC0z1pBMnlfAor/1DTbKvfYLs44JfTC8OWUSNPQr2w/xpWRW/lTG+SXLLCu4kZx+T2tlrT2ziDufPLAUxooaIOrwKoODhbkFQqcgUjoU+8H/vphqLKtlJqvx8O2+vomcx6T3uk3qaKg6L+g49+CoL2JcXuYAdr1L8Da0GBiNynGODo1AwcLnFxYuypGQJV/k+pSCK4Ykd2lH9O8uFSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TawaQTZiKD5mX4SgPj1LVmMbrtcalac5mcR+lI2S6YE=; b=PbEgIQUgk7uMQwu6SJnS7QJWhWBXXZg/9q6LbHU4XaMu+xWrWrbIkKxSMcwVtnOCwFZA+WpSJbXv2pF/NVi2ct4xIJYnMh/tp3FU+CtA7Iid7wjQKbqSKjuBIIF4qBIvv/DoLSRXo2Os6ZZ61K94OSnbm4iQwP1lc2hSrczyiGkjnNY+XVOhQwWuh/cm86zB0YEBeEgOkPmSutBgmTR9oarxLwpwzICKTaqPWgPayIoq9sJKmFswaQapdpIhxL3vuk9eO/ObB0TUNWW8DeZpFKnutejcnE5KeIi1hFaogc+F9QdVQg9d9tTvTdY3mngg7UH5bmc5tMN1bPed96BCBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TawaQTZiKD5mX4SgPj1LVmMbrtcalac5mcR+lI2S6YE=; b=iv4anSFO6uQ3O9YPyLXDqs0JGJ6EdWUKaDfL10lxcXkgUmUOzhVeNG9S/aByRwMjXl21QppamL8QcICNmpX8Jx3b496aPuQzPGgFVRVzE8CcWMIkagntBw0Y6NsrTkxt7/BoYEC95+xJ+iajmsiAIAkT52/7B/ClfqbxjimiW/vJv47YWUVnNBu8kLq5yaOJa3enw0YvAiO8y+ktwEcqlFd6rSj7XlbDB89PHZYUdmLVom/cdlvSeAOH54IjBEKGNg/cOOoGDB6ZjiwhYDgQRxh6ZMiVXOvrNGm6Yja3XxJ94YnN2mgMeITaQDFrWnTEPcxV2NTpBDeB14x+T0NwuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 08:46:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] cmdline: document "extra_guest_irqs" upper bound Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7972:EE_ X-MS-Office365-Filtering-Correlation-Id: 437e3e65-02c1-4b8f-0f43-08db34d85a9c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pr12zN8Ib6ncSZuJ+iYF+JZnzH+p8BIvHQO7mK4qXsovcfBs9A+bDw6o9hT/OTlv3TJxkw0ia9qiJmsRAPReYgkw0p8YxlKf8nWyVqaVdCMaK/gmEMbm5OTEv2BdbJ7xWsQh/ZXfWbuNFkS0ST/A7fJBkDGi6sqOPVnaX371bXcJE1GXb638ykHe1CnKAoXtnh+Hc5U1T1vB9a2JEzG4wGh7QP6zB0bkpyyvXdq5gggEzon2/lCJKvRnJ8qzK2ljO6jgF/saVpwrnm6koHMFmWu47l+PxWPv+FqPiHBDgSMg+CAO4TyQjUr0n0sAXYaCoXu3w6JWExkPyH8ZR+YIRAbPorn2a31nsLFts7gqEM0zY0M13YjNmHbmgXVcCqvC2shkbyYQecDiVy9yWtWquZ99pWVsAh5o/92NYI5Kf1ch+SpPbaEQYUvLdpyepUes61K2423mC6tB6lcKkCg4dCiuQTYcDBqiJU6hci1KYsW+pg8u62mRxjuMIskKtEv4kp7HDqeOkt7EXBSpDkFZnVTg06aRCaOEqWzgOwj4MwCJDH6QeIXCpP0F7aKwBN5ykArtgljq2FaFxsoSIouD3foRVpb+yuL6KqfRbAFJVJnqKXC1vCWOfc0baLLGM2/etIDljBR6tSqdIUutnzipBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(346002)(396003)(366004)(136003)(451199021)(6486002)(83380400001)(36756003)(2616005)(38100700002)(31696002)(86362001)(6512007)(26005)(6506007)(186003)(54906003)(2906002)(316002)(31686004)(5660300002)(41300700001)(8936002)(66946007)(4326008)(6916009)(8676002)(66476007)(66556008)(4744005)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGdLa0Z6Mll6Tml0a080S2oyWm1GQXVOUTFPOXNZa3ZSeWUyalVycms4amN1?= =?utf-8?B?bVJrY3dqTlhGaUVuand2ZWM2QmMzNHFMK1Z4ZTZSdzBzSVI3dDI1a3EzSXFK?= =?utf-8?B?MVpDRnJBeGswYTlJcGo5Tzl4Tis1c3JPdUs3N0FWT0VxdTZXRXNYK05oQjVW?= =?utf-8?B?UE1kaEFSU0VKZ2UvV1ozR2NGZm1LZGNJa2tFMGVHSDh3b0RBMGVRUWJjQWYx?= =?utf-8?B?U1BxWXYrNzFaZzRGN2JwTW10RFhLZHkwOEU3VHdYZm5QZVhpU0p2KzlzaThS?= =?utf-8?B?OHd1S0lwMzFEM1dtY0ZHbHVqbWtobWtCK3BxdGdMMnlENVI4OW5wamJNR3Ur?= =?utf-8?B?MTRYZ0FZRnVQWHRHeGEyaEdsdFdOaU5PVmF0b1U1dDlmaXQ2ZDd5V0txVUxU?= =?utf-8?B?aFN3Y2JwWTBuTFE3TnAyVkpzU0VBN3A1Tzl4U0p5UkhoalRwbUhSRmo3ZFds?= =?utf-8?B?Y3k1NU5ZR3U0akVjUXlKaFRTeHppTFRSM2FKeTVNMWFzY1NDK0t6RUpPOGhn?= =?utf-8?B?K2ZRdUptMkV4bzJNTE5SdTZEb1V4cXdpVEZ0Zkx6NnpkN1V3QW81Si9jTVhh?= =?utf-8?B?d1pOK05NMndMQmNYWHZlbXdWcXlpelVodVpLa090NHV5cTJDMElPZXZqaDdH?= =?utf-8?B?TWZ0VjJEUjRiRHF1QzN2OU10RXJLOGRoSmMxeXl2TUdQamFVbDh6ZThqN2c2?= =?utf-8?B?bGlnNEdBV0RBbm5BVXpRZXFPYUNlK3BRajN3MnJCS3kzaVVmRkJLb21ucHZF?= =?utf-8?B?UEJ6am1uT3U5ZVkwMEZicW1NK1pzN0VaQ1p4OS85WjlNWUl2dXVua0VHWHVy?= =?utf-8?B?U2VYbUt0akNhckxveHAzamxEMzVGbFArdVhnY1lFNWFuektQUFljOGxBT0Rj?= =?utf-8?B?d3VWYmlTRU95Y3ZNSm5tRUdhMEtNTllBWXQrUEpJN21lRTgvTGdpUjhtdXNF?= =?utf-8?B?UHQvR3dJZ29BdXUxRzZSN3dGdmplUkV3bTJrbWFlTWVyUXd2RzQxb0ZwRDM3?= =?utf-8?B?R0NjWjlqdzRvK25Qcy8xYmxaUU9BenNRaGlxMVJDcG96K0U0WEV0QmRGdzdU?= =?utf-8?B?Um9CK2dORVkxMEJYaHRqMWxibi9hRURTZS9oR2d2Wk4wd25pZE5pRjM3MVNW?= =?utf-8?B?eXpUODN5cEpkS2NrNUxEMTN6WUJYSEFDbDNVSlpZYlNJRVNzK2tNQWw5YWRn?= =?utf-8?B?aytTdzUzNy9HTmZveUdscHlneXYvL013TzFTemRldFBOYWt2bTl0bUpQWlFl?= =?utf-8?B?K2hIKzE5V2dnYWtraUttdGNLc0RVODJOeTZDazMvY2VDUklwSmZiT01TelpO?= =?utf-8?B?OXVJVWszR2F3TVlFSGg3cHRJa0lnK1pMZi80dGRkR0QwQmNxWWVHdkNqVkRO?= =?utf-8?B?cVRDSmh3WDVSNWUxVWNSVi9BbUVIelZBdkpCRTNVZW5HdHNtYTBzZDNSQytt?= =?utf-8?B?WTlDREtxTXdvaEdyWnpOajY1ZnBsYjc1SzNKamtiN3N6c2ZLTmQvd2dJS05x?= =?utf-8?B?d0RKaTNlOVhGc1REQW14aG14OW50UHZ5Qk5Pd2hJOGU3R3NicGxaWko5dnFH?= =?utf-8?B?UmtOeHVNU1YxRXZVd0o2Ni9Gb0N3ckoyZ29qeGVSajdsQzA2OHFTQlVIWHEr?= =?utf-8?B?WnErdkZqM1VoL3VKbDhFdFpNWDVKckJiM0d3cjNTcXRrdE9lRk51OGR4UmxU?= =?utf-8?B?ZHBBVDhPTFhLOUQrUm9jYW1zSVBYOFpKNjdVa29aWlpHS2hEbTNQQTRQNjh2?= =?utf-8?B?VUcrOWx2RnBrc085REZUY0QvaDFzVnlvblJSQ24vdGIranpsTUQwU0tKbGVP?= =?utf-8?B?OGhRczlDY3RBTGZIZEdlZk1uSWp1SXZ6VzNqaHBzbDFjbWNaeDJBMDRwYkYr?= =?utf-8?B?UDlWTVJYQ2RZRFJ0S0I2c3c3TjUyQm1tMW5HMmVqMkVEVnVid3RDOFZWSDBS?= =?utf-8?B?ekRaTklXQTVjTzV1MjF3RC9pRTBuY1ZMZGo5eXMvdWtNUXlnMnNIdWkvS1BD?= =?utf-8?B?SHhlbUhvM3FhaS9MYXNVSnp4VGFEcHZMNU1hRVV5ajJlWWpja0xPSC85OTZz?= =?utf-8?B?SE1TYTNuNVJsUk1BL1BBamh0L0d4RGF1czVZY3ZlU0Q3Z08wUUJmUEk5ZXRO?= =?utf-8?Q?rp02GRQEk9P0u4r93OZNwJB1Q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 437e3e65-02c1-4b8f-0f43-08db34d85a9c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 06:46:44.2529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l/hi71BTg5MHwRvQJhIZ8g67SWKG8zgRh9eV57sLX+DeVGP+ETWKB42St/lMBlGfn22XFCbemf4x3lB7HdL6TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7972 PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no more than 32k pIRQ-s can be used by a domain. Document this upper bound. Signed-off-by: Jan Beulich --- I was uncertain about also introducing a bounds check in code: We don't check for bogus / abusive values elsewhere either. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1130,7 +1130,8 @@ common for all domUs, while the optional is for dom0. Changing the setting for domU has no impact on dom0 and vice versa. For example to change dom0 without changing domU, use `extra_guest_irqs=,512`. The default value for Dom0 and an eventual separate -hardware domain is architecture dependent. +hardware domain is architecture dependent. The upper limit for both values is +32768. Note that specifying zero as domU value means zero, while for dom0 it means to use the default. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 06:55:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 06:55:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517656.803329 (Exim 4.92) (envelope-from ) id 1pjaZ9-0005Py-Ap; Tue, 04 Apr 2023 06:54:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517656.803329; Tue, 04 Apr 2023 06:54:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaZ9-0005Pb-87; Tue, 04 Apr 2023 06:54:51 +0000 Received: by outflank-mailman (input) for mailman id 517656; Tue, 04 Apr 2023 06:54:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaZ8-0005PV-5c for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 06:54:50 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95647f52-d2b5-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 08:54:47 +0200 (CEST) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 02:54:40 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by BN9PR03MB6073.namprd03.prod.outlook.com (2603:10b6:408:136::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 06:54:36 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::a84f:cb5:8471:f9d6]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::a84f:cb5:8471:f9d6%7]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 06:54:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95647f52-d2b5-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680591287; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ArH07A1EUAkuj+60F1scr9dgVajlc/cTWcd9aBlSjeQ=; b=JmT8lDx8wPZQctGL6tcEMG5a/TV8X0ruKDLBjYZZxwCz9PzJ2QlFvHeU mvbJoxrT5V/UcvgrjljY0fIz/FW2WhartS2EaMbn8xI+ezO7cFwmAfXGU 0EZbM47QLQp3hfo8Ptxoz7GHRFny8ahSdmiTDRkFMcAQo8K//+YHhPMXO g=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 103591911 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:T9j1CKwilJj2E4hTMz96t+caxyrEfRIJ4+MujC+fZmUNrF6WrkUPy GQaUGjVPqmOYGvze4pyPt+190lQ65fTxoAxTwtr/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRiPawT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KTtk9 6YKJDkXVUrd1vmVyp7kbM9MuO12eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiANlPReTpr6cCbFu75mIjKQY7D2OAiOCTtkm9RYNeI W4O9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRVLufgcBRAoBptPl/4c6i0uXSs45SfbqyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:c+aU6qFj8E9bnJdVpLqEwMeALOsnbusQ8zAX/mt6Q3VuA7elfg 6V7Y0mPH7P+U4ssRQb8+xoV5PwJE80maQFg7X5eI3SPzUO21HIEGgB1/qH/9SIIUSXndK1l5 0BT0EUMqyWMbEVt7ed3OB6KbodKRu8nZxASd2w856ld29XV50= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103591911" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FsQGmh6UF6kUpHKDpWLia9DgworWs6OeJhYo1iK70bO7fkzhz+Q5Z3XDVDN2Xf551BV7nIotu+AsumuoxJD9tYolvx6RMo+uTlU/SmM+cEgwMwvfugdvo8W6q3tTCzLeDmquyO5j0/cPnyHi5uFVwPVPGELufLTU8sbku2gbqlOWZh4F6DaaMB1lCfu9KwCZtEsp0z+o+JdSZtGGkGKipcLVX3DsmUl5KLOG4ak4/JutyRsQ5WMdATV3wkWX/jCBmjZpGdKFosl8akFdSAJ+Ms9lI1SQK3M6P+/EeNxHcBejxuWfnyob9fhx1jkzSEW98LW7evU4rBQKEWHHvD1r7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ArH07A1EUAkuj+60F1scr9dgVajlc/cTWcd9aBlSjeQ=; b=cRhGkGwmUFUeOPtVCGdCImYC6hCUWyQlMyOJKpMxXpc0BXsp8SVUK90hzBJMe78Vvn//Zjv2oCqs6h+omZFbDqEGg6OV75ZLdNT2GOJLwnPYqwyYmcLcgo8B92qHpezV8ArLrIcTIAP4vVevnzm/BfZXZ4NnidCRvJrfbkLpoDL29ImMkq3muUsnaLBlWcaMpXWUukIqrI5PB7dbN/UukNANsFkw/09wCUtFPBz6XqYU/8+rDNpkBL6fM41/a2nolUpVIZK4p3QjmyB6Q7ujhrohGDF4Q7XoQTRju4kID4/nnsmJqv+MGaBJwxwvfy1lXn6qW03AQQ/EWLqskQi8Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ArH07A1EUAkuj+60F1scr9dgVajlc/cTWcd9aBlSjeQ=; b=OjWO4DzgFETf4wNn4BC8O96LTe/ZqZxAX7z7etw1Z/CFASFjhus8iWL1iJfCJn9qtK1EAa9g0mqHz7/TQe2Bj4lr0/5+7B64QxxtkoFBR636e55yzTaSnynQo7UEUiRJ7AIoXTz2eczwlseF8ycMd95ZNXE4UE91QSwOYf88DDw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <38a2565d-da05-7a20-c144-6fb388b12716@citrix.com> Date: Tue, 4 Apr 2023 07:54:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86emul/fuzzer: re-arrange cleaning Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard References: <8353df4d-44ef-e39c-9a66-b6a7a73d5ff8@suse.com> In-Reply-To: <8353df4d-44ef-e39c-9a66-b6a7a73d5ff8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0598.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::22) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN7PR03MB3618:EE_|BN9PR03MB6073:EE_ X-MS-Office365-Filtering-Correlation-Id: 56e33d06-9eee-4cff-9634-08db34d973dc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b3USi8iuzHrgn/meyW2oq9YRy+vxGZKHrwDJPk9EpjAjZ5LoQpeSO/ihiWpJwfq0ji5/3Es6TMKG79qSgYo3jR05vDrUjzNadRqS4xWPR9TDQYgjlDvo1r4iwAzmpHOJXiVvMENbVe0PtRq4IxGNXJ0UQRo7PBQHmkO8Nt/mSuunISjNM9tSx3ZrgKMwVO6r5sKDHx9cWwKZyDD2aXMssijaab4nMob1Qark2LhPAYZrypw8XXOs+Ws1ZOFClyxGzNFFIhMQHc9bStYzIAv+suIMzuz+ieJEvx3cbt/OeFVJ4jl2VhYzULlpr8cdcYiA5+6P7k41QyKayarCNDfHxLICEIndQFMUpbfV21ogxckcCe6NTVCFS+fYGY9rtmleseeQGa1neApKt0g9O/k95zzr8t1i3hylEICJsLMMD4vyjh99+jtFLoSS30DZXuqJ0N/4BWti1sodFPb5NXOjQ9GZ/gYf5TBeuZ4oRnalyXBTXlb4ryRKBWDE2sPLhvyLetJDaUz31DXkem5IhmQmpoZ4ZlBXMA7yr5Rb6oQ13ja6FgVCA+RyCk3gNW+q4KI8Z/DfP/oifqSv1pvWcf3wAM+bCOvn8SYvhkTbhCVVuT1MpZdsQIED3CHbMbePnrVW1lBW1WFzcspKpP9t1etJZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199021)(4326008)(66946007)(66556008)(66476007)(8676002)(478600001)(110136005)(316002)(54906003)(8936002)(4744005)(5660300002)(41300700001)(82960400001)(38100700002)(53546011)(186003)(83380400001)(2616005)(6486002)(107886003)(6666004)(6512007)(26005)(6506007)(31696002)(86362001)(36756003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUNuUGh6N3VWblVzRlJZakpMbjArYUJqcHd2TWcxV09VTnNrRnJVM0pGNDZv?= =?utf-8?B?Q0VGa3ltckJyMWkxWVV1YjZVNy9Wb05UemVyM25XWVBCbWJDOUdYTjRJbXY4?= =?utf-8?B?YUlDamxnKzFlaWtUOEFmZStLV3E4aW1OQVlCYnp3MEFzU1hoMlZyMXVXOVJL?= =?utf-8?B?TXBtL0hDQXZrQXFweU0yT1c1ZU1TL25SWHNWcFZpeFc1SkRqQVlvaHRJWTl5?= =?utf-8?B?eFRmdk1TNDZPL2k4enB4SzUvckppNEVqQXFkeE02RThwZnBHVE9SdXMxeDBP?= =?utf-8?B?bDQ1a3RWYzczMUlTSm9MTkFQZ3ZISWpvaTFHdmpzREJ1VzllbFhnU3VVeC9s?= =?utf-8?B?OS9Qd0pvY3hEcjZCWXFBQ0J0RmoxTHNWaUZsRFFGaWx1UzIwSUpEYXVrdlpJ?= =?utf-8?B?aWRtL1p1OW1Ud3AzQ1MyQUlObG8rM09pOW1ZSnNHZmQ3emlBa0RvNkluY1JR?= =?utf-8?B?ME1aeGF2MldZRGN6aklqZWwvQ2NoRjkvYWlvSU1POVNCNldZVmlvdEZvQjZm?= =?utf-8?B?WjE4YkFpdkkzTmlLQkNlaGhWemtWUEZyb2o3Y09ybFgwbm5PT2dUT1lsbXdl?= =?utf-8?B?czNWWUx4Ulk3RXJNdUFrVjFDZmNJUy9vNG83cGlQZnNsMURML24xWkRRYXFo?= =?utf-8?B?SVhLSXF0NTJVWU1YbGNqeFRUM1lhTlJoNnlqeVJ5TlJWVW95d2VEVGlTWC90?= =?utf-8?B?Y2t2NEZFeGxYMHdRU3VVYkk3OXgra1dzamxUSDVVR0NUNEdEbmtRWUpoOHpw?= =?utf-8?B?WC8rVGN3S0cvbjVNaHQ3SUVJYUdTTmhmMHlVbzQyaEhPNElqSlVQREIzR2l2?= =?utf-8?B?RlBkdHppRnR5SUkrVmlYVDdYUUc2WFNVSm1JZVdUQTVKcVpsOW1ieTlwcTZE?= =?utf-8?B?RTIvVVkzMElVY1hYMHhrOVpJVkdQM1NRcGVxZnpXczlqUnlJYmJWZzNNbEhZ?= =?utf-8?B?TWhXYTUwZFJESENYL0RvL0llVndDbW5hWDNQWjFHN3hENFQ3ZVpldVhYc0R0?= =?utf-8?B?ZVRveUJaQWx5WmxtTFU3UWJDendxVVpDUWJ6amV3MG8xbkVoRUhWcHZNT1Vo?= =?utf-8?B?d3AxQ1FYS0hIQUF4OUlJbDdIT3Rkd0pmYVNyZVVGblVGNUVVaEtYRE5Vc0l6?= =?utf-8?B?enIrM2pTL1RBbFVNMng1M2RJWkZXUlRPL3Q3VHd5bkdLV2ZRdlF4TmVEWHJy?= =?utf-8?B?RHh2di9venFhRDhmblE4NFpSZzl4ZjJiUktjb1Q5ZDBxeUdJaWJkb0pLREQx?= =?utf-8?B?a2lmUHQ0WUw3enM3Q2U3OHhSNEVDdjJTMTJ1QjFiMjRDQTY5ZUhiTE1sN2VU?= =?utf-8?B?SmluVDdGMk52aW9aTmc3WUF5UkNsRHB5bjRRdU80YldYdTNxU2VMd2dMdmNa?= =?utf-8?B?WDg3VFV0TG1IRmJTNHJxQk4rMHlwR3NqcEdUOHVSUlkvTUlZV1hpcjJnK0lo?= =?utf-8?B?UXk0enpXdWFnU1ZWZFE2TGxDQjRzeXNXSkg2T2JjYTNVV0tVUWFoOUhZekJN?= =?utf-8?B?elY0bFFDSU9nUDhjTTBpT3hRU1hGQXM3STlMNDloY21CV3V6em05NHRIWVZ3?= =?utf-8?B?dDZtOC9NRVljRVZLS3h4ZWZkQ0tUUFFodU1UdHo0Q1JSRXVxWk9QQUZCQUtL?= =?utf-8?B?aW5YbTdZcU1xUGN4MFV5TDNnNXpYQWN0bGd5Q2lrbGk3OURPZkFQL0Uxekp5?= =?utf-8?B?QzBlbEd0NW4zeklTeFdKTUFvVHIrakRJbmNKTDcwVG9KUWIrUVgxd0xQa2ps?= =?utf-8?B?azlWRVNmdDZKT1p2N0ljNTBZYWd0WmdjcG5QV0U3QW1xMUhzM05FNnZaVUQ0?= =?utf-8?B?M0w4YjM4ZDVLdmV0Und4dWQ4RHdrVXBxZUliRjQzTW9BUVN4OE1UVDNpazBJ?= =?utf-8?B?UTJYZGNsOFFHYmptOXNNdXgyY1k5UWdaSU9aTGdqbTcxRUNQRDJwblhkS3pL?= =?utf-8?B?K2VveHZTZ3RPWUNNancvTFEwNHB0Yk8zQ1FlL0xGcHh6eGdoN2daMWJlK2Fv?= =?utf-8?B?R1RtR0ZnU2JsVWYyQkhlbGM1VlBGVEhUbHJ1Q2NEcEdQRmpZNUFFR2xYTGNG?= =?utf-8?B?SlFXSTZ2TGJzLzUxaVJxNEVqUlNyNncwVlVoNHQ5RkdLZ3JHNmdWclBrUFJM?= =?utf-8?B?Y2VlYnFOTEVZV0RkR2h4WXRMRWdzakw4L3BIWkZ4UStndTg2Qkh5ZGdYVHI3?= =?utf-8?B?bnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ymHF7pS5/Ahdhc/uoLsjA6HK0e/Kp8LVLJUYohW1T+q+B4JS2yb23rQSpFpvcu6Xj8omYExAAVlNiMqf5XPVoXhsTAdif8PWzAx8VH+Cw/5PKqFU34gtvBhoEyEd5fyhIeKe/P8IKSkNcGxw5uvoQ4+wqIZUmUBekPih2z810zySCR45s6hv/4krr762m5nQOK+sQYy/+uppdNGVtLQF9Yz2oJj5Mkov43a3P7CHFNg3GSgemWPa36ythWAfuEavkVLXVBBKhQYzynWtmR1BSw13AQKuRUPFJE3bBYVLhfzgwZ06zrUsseDDRw6u9wfAn8zcF36f2ofYLx66jVnNpqfiNTZLL1tibqDjpPVCLdhfGswGEoJmwVzTedHirIpOraqHy7axF6BBHIouOoYPrL7FndZea8XIld/kFhzHfW7kwGF+kq8v5ILBgTsvKey5jCdc4Uke6Zeqx9Aasd64XRHIW8m1u7KQsZEgJEdaGkF9lacY5W8/q6C1Vbj7eSHHFt4yWidcwg/ek0cKhT+zkzQgfUZ86tgexmFyDGOv3kxD3wxYAQ9hQzIwm0n4GxwkX3QvRII7mQYpiB9OQnnukDcc22ymyDnykjawXeacL3czD9Ef0tsDntXrshf0f9eZ4pp/5nx4rIsJPZlGuLeVpF/o0iRg03C+iBbITHfI9cm0M6j4egT41KkAtDIfQsB+DYRauCZA73hfdNPAl6SR+cm4ElLOoPffv6iyCKl9TjhnSPXAkqdmZvqPFFWaorJcq06hVZMQvcClGBzA/z9W6neeL+C45l5y3cp0hp71EZDL55b+AiCRJHGhL5qaEEFv X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56e33d06-9eee-4cff-9634-08db34d973dc X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 06:54:36.2061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B/sRLw5OAW5d/a3xHplBWEAMB17FEiY622J6ohTn1UBafI1vVkNcYkgthCMPVwb/cUMWsq+WsTjDm8PRC3OEfS5yhzjXly4qB76rgG+OS2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6073 On 04/04/2023 7:37 am, Jan Beulich wrote: > The latter of the two commits referenced below converted x86_emulate > from a symlinked dir to a real one, holding symlinked files. Yet even > before that the split between distclean and clean was suspicious: A > similar split, removing symlinks only in distclean, doesn't exist > anywhere else in the tree afaics. > > Fixes: c808475882ef ("tools/fuzz: introduce x86 instruction emulator target") > Fixes: 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling") > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Apr 04 06:55:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 06:55:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517657.803340 (Exim 4.92) (envelope-from ) id 1pjaZT-0005p4-JE; Tue, 04 Apr 2023 06:55:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517657.803340; Tue, 04 Apr 2023 06:55:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaZT-0005ow-Ff; Tue, 04 Apr 2023 06:55:11 +0000 Received: by outflank-mailman (input) for mailman id 517657; Tue, 04 Apr 2023 06:55:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjaZS-0005n7-3q for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 06:55:10 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a20f5801-d2b5-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 08:55:08 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 02:55:04 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by CH2PR03MB5237.namprd03.prod.outlook.com (2603:10b6:610:9c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 06:55:02 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::a84f:cb5:8471:f9d6]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::a84f:cb5:8471:f9d6%7]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 06:55:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a20f5801-d2b5-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680591308; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=wVelfQuyaKXgYl0uIIi7iW/tVlnA+3FXHh3/C5/4X2o=; b=YZPjn0EBcLbJef6f09zqSo55KU06KkHWCGwEL5OYxQerg+w8js52Kb3G JXcPCo8QfBzVC3V0ZeCYxMXhQvQypj1XodwBcac9kd8YX7hc9AUcEuvNr ujWMpFFfwV3lC9Iszc79gxEjGEv0/PEUPa7dkgBNeV4qLfj1lpPS6b7J3 M=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 103016611 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nBj2LapFAdA3WNJv0l90SXm7XsleBmI1ZBIvgKrLsJaIsI4StFCzt garIBmHPv2LYWv9fI1wO4nj9hxQuZLWzIRjGVZk+HoyECJE8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzyVNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAD48QUvcoNmN+qDhcK53wecofMbMZbpK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSFEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqUy2QPNnzV75Bs+BGLjg8ewlhOHW8NuL 1YU8W0+gfAd+xn+JjX6d1jiyJKehTYeUddNF+wx6CmW17HZpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRutPQAFIGlEYjULJTbp+PHmqYA3yxjJHtBqFffsisWvQG+gh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7EJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:5wqcma/RDsCuNSm8MwFuk+HFdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwQZVoMkmskqKdhrNhQItKPTOWwldASbsP0WKM+UyCJ8STzJ856U 4kSdkENDSSNykFsS+Z2mmF+r8bqbHokZxAx92ut0uFJTsaFJ2IhD0JbjpzfHcGIjWuSaBJdq Z1saF81kadkDksH4yG7j5vZZmwm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjsOTj9Vxr8m0G 7d1yj0/L+qvf2XwgLVkza71eUbpPLRjv94QOCcgMkcLTvhzi6ueYRaQrWH+Bwlve21714usd /U5zMtJd565X/9dny85THtxw7j+jAz7GKK8y7UvVLT5ejCAB4qActIgoxUNjPf9kobpdl5lI ZGxXiQuZZ7BQ7J2H2V3amDazha0m6P5VYym+8aiHJSFaMYdb9qtIQauGdYCo0JEi7W4J0uVM NuEMbfzvBLdk7yVQGTgkBfhPiXGlgjFBaPRUYP/uSTzjhthXh8i3AVwcQO901wg64Vet1h3a DpI65onLZBQos9dqRmHtoMRsOxFyjkXQ/MGHj6GyWmKIg3f1b277Ln6rQ84++nPLYSyoEppZ jHWFRE8UYvZkPVD9GU1pEjyGGNfIyEZ0Wu9ihi3ek9hlWlL4CbdRFrCWpe3fdIms9vQfEyAJ 2ISdVr6/yKFxqbJW8G5Xy5Z3BoEwhsbCQkgKdLZ7uwmLO6FmTLjJ2sTB+BHsulLR8UHkXCP1 AkYB/fYO1902HDYA6MvPGWYQKjRnDC X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103016611" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dFjjsVIrQG5TVQuVRZLwzfZdjbzjPNhDXbp02TC0leo3IYduaz1ekEk4i3JFT40ZAEvy9JxnM21FfdEJ/IiN3KgaocPOVHqAitJ9kPItSkKTxctg2KMFD7iOhITGfQ8EmT1cKAHilSA7d0/6DgfBp6lWdh0t3iKC2vbBAiKgvGoIm5ZTdchsmmh5CYczGG6jdq7EKKVQD7X6GGYWqzgu67Jw0ccs3nLpWnFgtfv/2+1oceILhZE5AFp19KDCALMQZphkpWBt0E9TP9yPiMr6icyrt5J5vwI6ULbY0p/+0nGtVhhbrJ8mqT35msSQnNh4InWDh896EQg6sKT8jqyt5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVelfQuyaKXgYl0uIIi7iW/tVlnA+3FXHh3/C5/4X2o=; b=FaEJBRkyftcnuijZI0cq4y4sA9zfzGd9dDHkF3JIX5z+voBRc5MY79XA8yZROe8Gp0xDtce4yHj9qKgGjEfzlpM3wk6nyQXwzyGNEY9Fg5pSKIy8NT9lu/tNgdUGu6Bh3dD4KUGGZB9YO2JixFMsFSV4ChKmaqrb7rt46L/CPaaly6pBP3UsqkHIPT3LqlGs3FsHirJ7wfj4mLGv9DnPntpd57qCoYengtimBYLhz4FtnpsUaAjvcgQ8OPzJUmHJjyJqeX0qCz7LUnpjIdxIM3X4qCTKfwGlUm5PXLO2VJO6BcktQZT02+9ZM81zEJvpmQPKCEeI8Zwqsgw9ZetlVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVelfQuyaKXgYl0uIIi7iW/tVlnA+3FXHh3/C5/4X2o=; b=PAWcrJtkhu26O+etMMBUvk0D3lEC3Uq6kDyK1jCflSk7Kv+TTM73ug0s5SBUrGgbuEByXF5+D9jQAwdypUBcHcxakNyJs7WO8XMPqYouxZE7z3/VEGCo5Bm2Q2h0J5KVxnmxf5IK4j6ukFSNtIasyv9V8Zs8CiakgvWHpFxdXdA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7de7a0a9-dd1b-c98b-9663-23c4aedb65b1@citrix.com> Date: Tue, 4 Apr 2023 07:54:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86emul/test: drop bogus .PHONY Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard References: <515bbf07-91fa-1932-1be1-1411f7814e6e@suse.com> In-Reply-To: <515bbf07-91fa-1932-1be1-1411f7814e6e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0596.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::10) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN7PR03MB3618:EE_|CH2PR03MB5237:EE_ X-MS-Office365-Filtering-Correlation-Id: d3fb6780-f414-48cc-fb03-08db34d98369 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xw+Z1IDcIkWTgOrUoj4f1+/CxJPAvnKH1Y8HxMcSSw860+vVrRYVZ1wsFlZqCRhfcrnP26MDym2j8lXciDtUaE7mbNEHsRn0h0YFXGQEWimJeFdUWz8xnODErjBjOv1ogUk1TdjfG8+KRvtnDIh7AZjDeY9o6jVSdtyV+oHf/+jYrewWlYkGCWpAAQc00cw3eCGFiXR6Y9W9AR/SwXJUyBC81CuoOaXeNyWo586iLjcm8eU9sIWeQGTS14cvShWmqlJp5wRg6/dWxLAMPs9bCCdQzzX3E00xtnIVB6pmJM1tRQHnY4DnTSKMQ4vXVLIMXadGcyCQzJvIrDuRHI7uZtH9Bm9gaaZJ/6ARTVGfJGM1/3CPtIwrkS6F+WRNeq3EFn1s1VeSDfK9JyTlNh11C9ftab2n8b+zoJqFBgMwu0SvxBcJODRx1AeIqfaJJNKLzVitL0B/qOzFBmKGt5MF5Mi9QRsmamOIfEgDKARypIAJgryOS8rT3/CElAZlUF7YibOm8e9luJ+qpuWuPqY5c7SHewYgPYYR5R2FEDi5Qv1UjkNnmLqnf2OSN7jg8d4S7KSwGIAM0Sfr64suWGDjO6OMsoQ31YgPCABhNM6l/4YQWClY0C/kCqpaV02sPD1zdMxPBJSTLjKNqKPDar4lNyLCRXG6qiKlC/5tDPuiyZM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199021)(4326008)(66556008)(66476007)(66946007)(478600001)(8676002)(54906003)(316002)(110136005)(8936002)(5660300002)(38100700002)(41300700001)(82960400001)(53546011)(186003)(6486002)(107886003)(6666004)(6506007)(26005)(6512007)(31696002)(86362001)(558084003)(36756003)(2906002)(2616005)(31686004)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmFiaXJHUHRzRm1rT0tqb3pyTU1zNzNhNzhweENBOEZFaXFJcUd5MDVodlVt?= =?utf-8?B?YThGS094MzJiT25SVlJlTHNLYXk0emxzUlQ3alIya0lXOW1iUlRNQThGbzBl?= =?utf-8?B?UzI3KytMcnJjVlZTU1g2QkE1YktvMjladlY5bnBlRjE0TW85NWtnZ1pFZ0sx?= =?utf-8?B?aEgrV3QrNHo3WUQxOEtEMEZEazZDRzU1TnE0cGRISXVEYWVxK2RSbTYwVWtQ?= =?utf-8?B?VjlhbXBwWncwUDBqZDV5dFlQM21JN1g2cDNZeFdwWEtaanJmNVVNYk9LYXds?= =?utf-8?B?YXFBSU9pS3dwQitQWVZCV3dHRG9uVjN4NXpqUVRab0o2VlJla2k4WFQ2WUxh?= =?utf-8?B?YjV3WGpIOUtsZEJadTVKOTgxRnJHYkFvY1RQM2FGV3lLTW1wNFFwSTNSWC9r?= =?utf-8?B?U3dtbE1QVC9yZE1LWUxpME55TjFlWXI1cDZWV21tZkJVeDRKbzc2MWovYmYr?= =?utf-8?B?SHNVY1F2M1ovMHQ2UkI1QWVYMHdXTGRQeUYvS3FwUHNSSFh5SktUVTZYeUp1?= =?utf-8?B?b2JlMGhtNk9DdlMwQmxKSENKS1EzVFRyR1JuS05NZFZyNmVnRXh3dlc1QVJO?= =?utf-8?B?alJzOHRpdG0wblkvR1dBVjV1N3U5L3FNNkNEUEMvaXczWTJ6Rnd2Z2NGcFRH?= =?utf-8?B?elMxMjI3dG9FeVBJc2oyQjV0WUc5UG9NdjhRNW1vT2lmS2pBQ2NzRkFFNzU4?= =?utf-8?B?bWx5K3hkUittTklWN09CcVc3ZkZUWHh0ZTMremtKQkhWZ0hLaTkvdWNXMnFD?= =?utf-8?B?VUt4dFZ1eVBPZTFTTmUxTEVpR3E3L0w3U3plTFd6blplY0FJM2piVWs5MmJO?= =?utf-8?B?bGg0LzFFanBRejc1SkRWTEZVMjIxdmd4MFF6WWxYbFFuV2FZUXRRNkZxeERO?= =?utf-8?B?UjdzcE5ESnZ6UHdzSkMzcVRmZHZpOGFvOG9ieVBwWmk4OVhpTDlLMkcyeVdN?= =?utf-8?B?dGJzdlk1NHRZcGhpRVFHRHF5cmsyb1FGd3FBTHp5Y0FDR0JmNnUvVU0xcDN4?= =?utf-8?B?TnN3eVFCbk9ObkxFZ1pnVHR1dnVpSnFjbm0zVDZHZkF4cDJoSFNYTVQraVlr?= =?utf-8?B?bFl0aktGOHhZYXQ1NW1nYXFSWjN5RHk1dlZTRmFFT2JUSjI4YTNua2dUbTd1?= =?utf-8?B?RGg4TVlZN3BqaHBtY2ZFM3dqbjIwK3RWc2x3U2dQaWhtR1M4RFVSMkwzQlE4?= =?utf-8?B?YU15Y3FLaVlYUE5vRnMxMVVZUFM0OVMrRmpabnRTS1hJT3RaQ2l6aGdOWXgw?= =?utf-8?B?Tks3WllCbjhPRHhmRGNBd2k5dGNnZUt5ZFZwaGNoajJKNWszOWxON0I4Ykhn?= =?utf-8?B?ZnZING4rRWZoVEErb1dFS0MzNjJsaExkNzcwcWpLb2liTGRrQUJFdzVIcGts?= =?utf-8?B?YWZTY2N1RDFTQXRJSEJ1RlovZnJjR0tFTkszZFNUazJHYy94dWRELzFwN2k2?= =?utf-8?B?V0VvakVvdHdmQnNwSGFjeFlrUmFaaXBpVnp4a00rSmMwS28ydTRDS0tnS3ow?= =?utf-8?B?ZVNpdGVLV1pxbnhKRk96dzZQTWQ4VGh4UFFtbXVtNHEwZWlnZUZsTEl4NGtv?= =?utf-8?B?RHp5ZGpETVZNU1hGaDNoZ0wzbjVFRElSTVNqQi9xODlYMDhpb0liem5LQ0cv?= =?utf-8?B?STRLTVZZek9qV1Q3SXVjODN2YVJDcjhwekRPQll3RXk4TzJQOWVEU1dqRmJX?= =?utf-8?B?WVFkRzZEL2xLamxPOEFGNGVhVjIvTzFCRkNUTzNrREJ4dTlsVUxCQ0UxRmo4?= =?utf-8?B?TmJqRFIwODdPR2Fjamp5Z01zQ1FOdEpWUG5VOFNtLzJXU3VXMDlkZEdyR3JH?= =?utf-8?B?ZmJCUEN1K0JJVnhWcDlpTCtWejlPRmw2L3JmamRzTHVNb1ZHeFY0WEhFVFBh?= =?utf-8?B?cVFOcW40VEhMbk1IMURxc09zcVE1R1B3cS9NSUJCa1diaXN5c1ZKMi85VkFZ?= =?utf-8?B?NjEvTzJNWk5KN0JRUGpXS0s2VmZuKy8vS3g4R2xMQXhVSnlPY3lRVko4WFlH?= =?utf-8?B?MklsZHhKVmlsVmJQQTdvNGorRzFNVzBGVE1zMnV4alkxTU0wRm5TWU0xN28y?= =?utf-8?B?cTU0TXMzWmwrLzVzYUdvOWxOVGZJeHBFTktPWEt3RFp1eVNOSGJFVHpyMWdX?= =?utf-8?B?OS9YVVFZMnp3dWQ5ZUJZNVczTTRFSzkxSkl3WmNQRVhXRFFhaEVIVWhJMGVa?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EVmzHPohxC0F84xEMxQTvJ8ncscMKdeCS++FZl9d703OjJD5SKjAuvh5ts8/D7UXp8olOa/hV/ObW4TmzgIU0BtHRX65ypks9e6N/y+DAxjusvRVNW5PjQQkZo35P4ehGH6NQg/6iESW6kEoR0+aHkVTjBmF840ik+xgRNDfv2tQq/iAe/z1K17WU7IVFDxCCaIalrui1Bx4P++HhseduVwPdujtOutvLcphPIM1hk5Q16LLhu7Q9c9Q1MdsjuH1gyY4KXCCVK4qEkIs6fxTpS4Oyyh48Lw//hk+eCq/CGzQGjJolBnxqrWr4y/PAUJ+quyqJGlcIDewxmj7Xg+C/o9eUGZYEiTBVXQmINSk5vclxLJPeqMgrSrtndw+sDzr4BnUtKDXnAoygmrAy+Pbqu6YrNFfoVZ33aRXDD6RcWfDYm2xbO74Ks8ahS3V5L/Pr6isdDj5H0/MivUuSCXS0r3NpgTe5I3Tu0YslzfDTbOc7iKYBUHyuTJIogqbLEwJI4YbO+aICAAUHK2nEN72FlieYd7hxYvZq5VPmb61M3+/GmGk4rSb6D/6aZ+TyW39faJTmP2DtETMxh8V7b0NHS+h7gWUrFbqrJLz7JloylVDuuet+pUtwzKico7uKX+X1QD/1+EF4eOUQlWCXVJQcDBxaITJagV7xhloTLVvJloAWSlevWu7Oo8+3KmEP3gNiUTK+Y1g9PzJzrMYpT9i4yb7jQIB4Ja/RZ7Sf+3h6Vf6CplJLrtFO3nub9dXiwgj2QTTu4UpHWeFvEZvZNhxWlavePSOqi1ns8N27bsxxHq048C82UP5khmZ41U1sc8H X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3fb6780-f414-48cc-fb03-08db34d98369 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 06:55:02.1914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7CXdfMX8kUGciHWFxH1v3VxUTlN/qZQRURPMKZLs+1ido4nN4m6lPwTT3Hp1NNlphc7lXzgOMYmuki7kRKAbU1MRdgnH5bs/XNhrk0o2Vts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5237 On 04/04/2023 7:37 am, Jan Beulich wrote: > x86_emulate is a real (directory) target. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Apr 04 07:09:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 07:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517664.803350 (Exim 4.92) (envelope-from ) id 1pjanR-0007ec-R1; Tue, 04 Apr 2023 07:09:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517664.803350; Tue, 04 Apr 2023 07:09:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjanR-0007eV-ON; Tue, 04 Apr 2023 07:09:37 +0000 Received: by outflank-mailman (input) for mailman id 517664; Tue, 04 Apr 2023 07:09:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjanQ-0007eN-SZ for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 07:09:36 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a63cb010-d2b7-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 09:09:34 +0200 (CEST) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 03:09:31 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB5696.namprd03.prod.outlook.com (2603:10b6:a03:2d6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 07:09:29 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::a84f:cb5:8471:f9d6]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::a84f:cb5:8471:f9d6%7]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 07:09:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a63cb010-d2b7-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680592174; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=wFGQFCHVvkmCrHJ1jX9q5LMd/o9f8WZjGtAJf7Jd0UE=; b=dJu7SBLs4BhfaUBslisJdVjswQzl/Sx5pfPFdrrCfTri+7Un9L+qbMeI eUGRARbOzIvk0B/4qCYTWhZvYv+ezpY9mG4eg5S4E1gYTNS1Wg3sOdEVJ 0kq2aqUPQ2tNiEyW2eVCnsFw/8l7S7cJR623wLPFEpvguSlSoWfFf+zRU w=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 104636992 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:d+uY0aktrPm+dP20RudmKQro5gxUJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKXmyCb//ZYWKmKNojaY6zoEgP7MeAmIc2Sgtkqi5mECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgX5AOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c4nISEWcg2vvt67+Iird+dF3/kRAda+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieC9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOHmraA70Qf7Kmo7AzEdWQCHpMuFmFedXdsBE 1I/xSYllP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2GEUvvhjutot3MUVQz7wCOBma9tFohNMiiepCi7kXd4bBYNoGFQ1Kdv X8C3c+D8OQJCpLLnyuIKAkQIIyUCz++GGW0qTZS81MJrlxBJ1bLkVhs3QxD IronPort-HdrOrdr: A9a23:oOtNSKvU+dmVJ4hhy/vsqf6A7skDeNV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpgHIKmnT8fNcyL clU4UWMqyVMbGit7eZ3DWF X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104636992" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAd9ThiVB1C/euKnE+DNBs86UG+rK+QzGvc4Qy+vcHCkQlfSpokUaK/PuMKk812NYbwjt/+XwCiqXiGTBa6oW/mNrPGlyX4ngPf+1k/xXjWJD/dDUbdykrpBTxjd5/J7sGTjXDeDSEg3aduIce8XooOgVPM0j6IyHyNs1nZboYO3qW55gY7PXz5Htld4B/YImUQGbUqy5QrtJRg8oWqUWNRbfDcKMXTnZdOtlM2XI701ACoucXhBU9Kj14wlI5tqxpat3x38b4XSq9GambHru80NkMfWRiSBCCjPsVDTLrfApJnDWT0l0z7tHdoDKoYHbkAU9QFC2IpD+/IietN7Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wFGQFCHVvkmCrHJ1jX9q5LMd/o9f8WZjGtAJf7Jd0UE=; b=hg6On8P1fYABJ+Q9Pns0LSJaW0DLCCB1B3GA573Y7dl0NSEF+SlxrN0F44MzHWKQBDcLUbr3qMFpHuE+2CaYnKVJ6Et7tUV1Brgio2LfrtFbCHF0uYWXVYnAi+hygKTbSvZVXOOmy/HMxsx0eR/qcYqtWhC52X5zKk9jPZTUOBwifFTSIZo/sqVbMIaokzhs23U4JBxOH6+nmfftQNxusyjXsKCJ9h0Alt33VEqhzBmAbiJUGOjGdh0Ra4Wka5zOVj0iHj3KzOUuWGvZP5cTtpnH+15skuP+i6bcB5r4CAfTHplcDiORRgSYWUeHd/BRUU20M7gRPHemwAxqekLzrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wFGQFCHVvkmCrHJ1jX9q5LMd/o9f8WZjGtAJf7Jd0UE=; b=ij63QU8l+Qz8QF4JeGPe38hrJWuSDxesxfMh2ki96JmxIvhcZMG1WZvCQhadQ3/dstdHHUkIJMQFnkw2NMJ66Iw5SZsFzQRnG0l56qplT+HUplhKCIjYYE4pFhyyRLRNoGZdDly//ZQxpZAd8nEwEi/kOl9yp8sAfgRiC/WcghE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0e165632-938d-596b-3087-75da66641d85@citrix.com> Date: Tue, 4 Apr 2023 08:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] cmdline: document "extra_guest_irqs" upper bound Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0122.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::15) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN7PR03MB3618:EE_|SJ0PR03MB5696:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b4b58ae-eb1c-483a-c2a9-08db34db875a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WsTVc2LQ9NZBD0Cl+Q8p+FU07W6edyMigri2OIzAvEnfG2l0LR50CerLkoteTJRzN0OVDLTcg1H4EKL+XhdIK3yaxMW+JSoZdcd3o6GKk/UOqoeeLjwYFZ4a56BgGXyutfsamkOVT3CKdwXdXQwqJQQbghpRmQCnU2HJ0hkjc06eH3stSxnaYh49vWlx6by6BrQj7NxBw0xsFmKu3OtqtDVYFbz15lG0LQf1JTLa28pRFdxgTPAS0DBdh4wwpSmJ0RiCtBTfTeO48w/m4x+nEwvcVKQOoLRIcrG65v/OUI1o6yzAtaD+I3liO2cvdaM88UadULFcyHKSzj002LpOJTI2aHiSbZbvOG6lwLTrohmBnkLk1d/bgJiXO2DJxQaCXd+f/XQVelK7Htz/LTcEcpa6pS1uL89IaaPiKxyx6fKgEpgY5FyQBisIOEmVTGrmHZNI95khMAa2HH2lAGFnMmW+x6Ms0x5b3atSP6cGHe65CBls5Q/rbj+Ax22glKYqRguDpEniNgsHNyAsWLHZZSw4KObP2gVsSH0pRJwFYuNwSOdZyOJ1FxxKAa1R9oiazS9R6Ntngqu4vODF4rAst9o8plbShAeaY6cmL4SG+PgWrp5UCgCYmYiVV9zt9dGBIrgVq/7PaBZZw7AbobS03w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(451199021)(31696002)(86362001)(2906002)(36756003)(31686004)(6486002)(2616005)(186003)(83380400001)(53546011)(6506007)(26005)(6512007)(107886003)(6666004)(4326008)(66556008)(66476007)(66946007)(478600001)(8676002)(5660300002)(38100700002)(82960400001)(4744005)(110136005)(54906003)(316002)(41300700001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDg5d0VJNlNaRHlzdDJ3L3NLZlgrcEZsa1VVdnc2d210aDZtNnZBYlpkcWV1?= =?utf-8?B?RlFrSmJKNzdvKzhXU09lR3AvWEFnMmxTZUI0SzNjSFZ1WXBNV3Y3b0QycXE5?= =?utf-8?B?TUNTbGx3S2xuakpJaEhHK0p2WFZZRVdtZmQvYmdidTVLelExNHppSXAzK1Vs?= =?utf-8?B?NEdBUDlvZGx3WUs1cGZIc0dzK0lDaHE4TFM5ZW15dlBrMzZObFBuM0tmSzVL?= =?utf-8?B?M21ZU29tempEb1M0c0wwemhHYUlidys0TjR5SUVmdDJCQXkvR3IzWnY5TWVw?= =?utf-8?B?RklGb1J3UjNNbDJ0NXhRbC95RFJHSFp2dG5YdVBVeUY2ZzFBV1F3ZXBhS1hU?= =?utf-8?B?K0hhaUE5OTlpVlNGSEtoekNKbEd6aEc2dXJiS2ErNnp4dHJ2dUN5V0pTaklJ?= =?utf-8?B?Q1JCbkFNc2RPTmh0K1U4UVRpRjU4Qm1RV21aSGdqZWYwTVlqLzJzM3BoVDNZ?= =?utf-8?B?aldzWTI0YndSTE9WclVOcTM4TWowVE5oK1k0VlBNRXo4V3lZZ3ljeklybkxG?= =?utf-8?B?dHgwa0EvMlA3MUlBdkFUcDNFSUdXem5SVzhheUorcVMyL1NtY2hsRjRFSjFz?= =?utf-8?B?NGVKVFd4QjJPcU1UeHVkdlBpU0dUaVNnVTJuQXhpVGpWMUFtNkhiYldzN00z?= =?utf-8?B?U3Rua2JiK25HbkZEMzJqekNUSnViVUdJWWYralIzMy9vVThpVC9PbXVrbmo2?= =?utf-8?B?cEtQejZaaWxyWUhTYlViYS9KaWRjaFpKeGk3VXJ4amRGUkdhdjRGL25kOCty?= =?utf-8?B?b2xRYVhOOEtkL3AvZ0xHbmN0akxxUTBuS0h5SkcvcWNya2FpT3FWR2U1TDly?= =?utf-8?B?UVZDQmsySi9hOUFPL25DZmxrcy9jeWtrTTRtcG9HMmVoWTNNZjlOMmtOVUdO?= =?utf-8?B?aUxlTEZzZnBFNFRhU0tRR1lvU2EzS2pXNjZCRkRwR0NqQkQ5QVhoZmJOZnJu?= =?utf-8?B?VUs1VTd2dFhRTkV0cXpCNHU1emRXMVpvOC8ybTlEeEk3QXY1TEpIekNSYmxx?= =?utf-8?B?UVdMUldrNVRzWUh0UGhJcnkxNGRFWSt3UTJ3eUdhblFoWnY3TUhwek1reERm?= =?utf-8?B?c3hjamp4cS94SE9vV0MzSVhicWNhUDRSQmM2dTA4MUc0dGl6N1NISEdtVnJm?= =?utf-8?B?KzlocFcwUlRvb0RscFBaUVp3TUpLUGdQd2RsTGtZY2lUNHp2MFBOOXgzWWk1?= =?utf-8?B?NFVaYkxuR0VIRTNhckhZZWF2OXBENjBiYTczNWVyb2FkYnlRSXRVanZZUkpS?= =?utf-8?B?ZEtBVzdwRlVpOVZsM3k3M2RTWDkzMDIvVnFXV1UxVWNiYWwyVWpnc3VScjVx?= =?utf-8?B?M0hQdFNEWEZzZnpkRmFIbWlMY2lYTHBhaWM3VjB0UnhNdFVJM0I5WlFnODJz?= =?utf-8?B?UjZQRmViLzFJL3d4cTJUeGU4akdVNjlydDlYOFBjbTM0cjZsMGp6dWVEUWo5?= =?utf-8?B?VTNHYVBUaU5hb0l5QXo1KzFSUnJJblpuUk4yZTZsUnVJOFZXb2pLQjdhV0tz?= =?utf-8?B?d0d6b01peTRYTTFJcFdXR3JnaWRzYnZHZm5TT1hSelRIMm5DY21HdmZWMGZV?= =?utf-8?B?OGNIdlY0QTJrUzI4TG1xanFRQ0VseDlZbXA1bmR0a0JzUTcweFlNaHQ0a1Z5?= =?utf-8?B?NlBNZjI4blNHdXhlRzFnMGNGaHpCRElycXRWU0NlMzFJeXFDcytmdlNuK0JC?= =?utf-8?B?aW9RK0NXVEhpVjBocnBSL3VRMGd4OWZIc2dQd0JPVTZyWktPT3FzMWpmNzBo?= =?utf-8?B?Tk5mQTF5bVF2TnFsbzdZSEFhOVdxc0tMRjJNd2hUK1RlN2RVZzhoOEJ6cFg5?= =?utf-8?B?OE40MS9pRXovZSt2ZUhlaGxhamtHb2lQRmVnZDJBT08zNjhjeWVDSmZqa0FH?= =?utf-8?B?VXNYcjhPTFRpQWNPQzhWZld5Z1RvdmpLc09vVjVLSlpQUTd6Zkx1R0p2V2xX?= =?utf-8?B?TWVXdUw5TEpMcndxZHRQM1hVcFZ6ZDViT0FqRkdDNGJkeDY3REFuZ2VCZ1p0?= =?utf-8?B?Mk9WZEdaNjFKanVTZC84S2RDbVYrV0lDT3c5aUkxejBwKzhMWmFvSzZWdS95?= =?utf-8?B?VmlLa1F5a2ZQalVjYkZnV2FSckE1WEpudWgwQ0xUL2ZlUThEYjQvRXRWeENt?= =?utf-8?B?U3hkNzA0L1VIV0dRYkZOSFhLVnFUSkJPdUtVdVB2Ulp0U0ZTY2VNZXVOMWVE?= =?utf-8?B?UlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: n4IjA30dof9a2HkgiVTn3xNWUoJxxnbLH8+dr9D99mn9ddyQhI7b8K+ezN+PCpxRuSx1ba7YCm/6lb7PHMSkrnE2fOlctRPD3FBOm1XSathEO+7Teuogj4pSNGXDyJQoFP7Fsg21KN/1Qc497KiUXodQ8URU3kX18KumO2+NxutRtT+1ek1XVJP5E4U42bc6/VxVK1MMhRKT3gtg2Sy8QJoqKIQYTfsSR1SyVftwQEsG9adHG0+5EdQq4Q/LHfiKwFG7/ElNTUiS03qtgXoDpfR1mhrdytwxcfIAt5a05tkKZJ3aVJG6PBaJcQ/LZUVdvO2GM378WTti3LyhZ8ndwKSR6Zvw8UFxdUN4BU52C9Z4V+btukn6k8Yz7ET5Q85rXo5rTmFHjajao8RcCGqfqjoXEkj2JVb2OtZQSOgfa/EcruhlS0UoSA+f95nqlgd1Lohxi//spj6bvCQFuWa0IoqCjHlocX21A2/qipqIR/GlfQr7aRUup2zgAIcg4pYEsQgjrnArBUNGEnJCVg8aN+GkT70iLKzt+AphPv3tyVP9OS31mQuLYMZadX9l+YfIhe15xT89AVJY6OPbJavEah1kO3V0CgJ+vq/o8HMKq/WlhZFtQ5U5hbPlhUZXtdSlPh7w32it4xSCdYb6It0pBo6B1pNuU34N9ANsHRfXlaf2NdwTZaChHolZdEbflWthZMIzpF35INMkfV9kPusPKkGB7TODfx3VoMSErS/lH84HOg9OSz371kuWb+QeJtl63pWsOK9VxMe/35oyNNV2yma09+RzPV1Xi6rTdz6OtdKWJAB/rycLhyBVwCBr7VtD/UbN1D/vuDXTfhqDde3PLEml0CpP1PeTn6oDStKOWKQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b4b58ae-eb1c-483a-c2a9-08db34db875a X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 07:09:28.0290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KkMYjRKcRyMclxKryR9ViLLMAHYE7YSojcUV/DGx0H44jnT/V1wDZNaU5HRcK6VYwVxUICHuZIFd6bVROi36cuBz9npwuoUshJv0wNi9J0s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5696 On 04/04/2023 7:46 am, Jan Beulich wrote: > PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no > more than 32k pIRQ-s can be used by a domain. Document this upper bound. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > --- > I was uncertain about also introducing a bounds check in code: We don't > check for bogus / abusive values elsewhere either. Normally not, but in this case I suspect it's worth it.  Without a bounds check, don't we risk wandering off the page? From xen-devel-bounces@lists.xenproject.org Tue Apr 04 07:25:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 07:25:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517669.803360 (Exim 4.92) (envelope-from ) id 1pjb2x-0001pf-BG; Tue, 04 Apr 2023 07:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517669.803360; Tue, 04 Apr 2023 07:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjb2x-0001pY-8Q; Tue, 04 Apr 2023 07:25:39 +0000 Received: by outflank-mailman (input) for mailman id 517669; Tue, 04 Apr 2023 07:25:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjb2w-0001pS-9E for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 07:25:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7e1b::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e43c1df3-d2b9-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 09:25:36 +0200 (CEST) Received: from AS9PR07CA0032.eurprd07.prod.outlook.com (2603:10a6:20b:46b::26) by GV1PR08MB8129.eurprd08.prod.outlook.com (2603:10a6:150:93::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Tue, 4 Apr 2023 07:25:32 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46b:cafe::ac) by AS9PR07CA0032.outlook.office365.com (2603:10a6:20b:46b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.28 via Frontend Transport; Tue, 4 Apr 2023 07:25:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.18 via Frontend Transport; Tue, 4 Apr 2023 07:25:32 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Tue, 04 Apr 2023 07:25:31 +0000 Received: from 03dfef89983d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4964DB8F-5F00-4319-BF1E-C01212FD3F3E.1; Tue, 04 Apr 2023 07:25:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 03dfef89983d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Apr 2023 07:25:30 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com (2603:10a6:208:ff::27) by AS8PR08MB8222.eurprd08.prod.outlook.com (2603:10a6:20b:52a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 07:25:20 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::7b58:72de:8c37:5104]) by AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::7b58:72de:8c37:5104%6]) with mapi id 15.20.6254.033; Tue, 4 Apr 2023 07:25:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e43c1df3-d2b9-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZkOr/QC/Awt/0jF1p4/c1SFts/o/0u4Id40Ai/aNGcQ=; b=l7d7PF75xOf0+Q7cFkpC1cRWrySrS6yFJNuJygewysDhZXySsk1G+/NQ9Wk4aQ01zQk1b1f3JDZ4FF4xlynH76jreLA2nQsRCTXnvl8O65P8bAorkoi0ObkfIXdeXbo5pEYcs2PGmsyi8TCQ+QNiHOBkI9780D/+8IReUoCerQ4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1ca0b615dc84edd7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HxKdMJXd2jEqkpgCcKZCXRw1v5eIYNjEmyQdHMpCgCRbGtTTHGxRr7BaRh/4Ka8qYpSKjR0wEwR1vEzkhhRPqzd0AspF44sT+vkmhD9FopEOG/IGZx48lHuDQUlHr+r1ZpDSAC9ZivUlgDnqVUcuCGJDbW7DRUe05ECfEJlxMVZcrx2wbDC3sYdhm63ehPw8LekBV48zl2MImBfuzplzkaBt5K3nBB9yerdtWKE56Tnftd/YRut4p5Y1Xx7eAj8JhiRfPyMguZKnoD0qRhB88g65OQQIrYN2kJFiJjtqNc4KBVshIuF2DcwRRgIsftjNV6A66Qf7jMoWPZD9Fx1EGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZkOr/QC/Awt/0jF1p4/c1SFts/o/0u4Id40Ai/aNGcQ=; b=F8OQ/IkAsMBW0RYR3vRffvTPEgAJJTwnpp8gRmjf4O2v6tvjncM9FiXLSBqAjueBRZa2ueoqqd+/axDmYcPZ8y5IGz4X+5IAD462JtBtHGEw6BOt69TcgEmv6Qf/JQKnDTeGho2kYOQaCHNMOvMYIEMJmJZPXVG2MRVLs0OrIWtJ9k15WgK13DOMh+yXSMq2KoL/1IzqlowQucrZrgOi8SBPEa4WP4mx1kkTtUKN+3aCE8M1QpcRqAlwCnB0inuAtoaLy91ge3rRaSLpeVjGgovUSKWvXnh4OfrBD4WX2tYyzSe4QP1JBNqiXw4/rfcx0iUhK06ccRDXBbg8ow7taA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZkOr/QC/Awt/0jF1p4/c1SFts/o/0u4Id40Ai/aNGcQ=; b=l7d7PF75xOf0+Q7cFkpC1cRWrySrS6yFJNuJygewysDhZXySsk1G+/NQ9Wk4aQ01zQk1b1f3JDZ4FF4xlynH76jreLA2nQsRCTXnvl8O65P8bAorkoi0ObkfIXdeXbo5pEYcs2PGmsyi8TCQ+QNiHOBkI9780D/+8IReUoCerQ4= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , George Dunlap , Nick Rosbrook , Wei Liu , Juergen Gross , Christian Lindig , David Scott , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Christian Lindig Subject: Re: [PATCH v4 09/12] tools: add physinfo arch_capabilities handling for Arm Thread-Topic: [PATCH v4 09/12] tools: add physinfo arch_capabilities handling for Arm Thread-Index: AQHZYJtfUiyGg0Un4ki5c+B28igcyq8TjeGAgAc+FQA= Date: Tue, 4 Apr 2023 07:25:20 +0000 Message-ID: <6373AE6D-DD75-45FE-B549-DC540453508C@arm.com> References: <20230327105944.1360856-1-luca.fancellu@arm.com> <20230327105944.1360856-10-luca.fancellu@arm.com> <9804fbab-3e8d-49dc-847b-4804a6de286b@perard> In-Reply-To: <9804fbab-3e8d-49dc-847b-4804a6de286b@perard> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3745:EE_|AS8PR08MB8222:EE_|AM7EUR03FT015:EE_|GV1PR08MB8129:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ead9dac-8345-4ada-d05f-08db34ddc64f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ipWbnH40rr+i4lSQ0M79XLqn15iAvIsDpjsZxuvjFDkxbtZO+nVKD/Mhg6ktcSOFKvaoN3jeEMQg4Ikp+E0N+AoAh5Lgbzz0wpBGPPI0hmjtVPq0DG7nxDIxFB/G5JUU3wooDAtmFTysBamC9flSrqlCbjL9QKSuSBWqye4bT8YBpm0DXKMqljTW+CGeDsS7iSwVKF7KMX61Ftx6uExxHF2JM2XXwRlNkTAPYlkqEU+pjQp/k87ScfCqEi3kmOJJPvnT/dkn2Ox6eNIImNl+vJ8mOyjJz6gvXWQK6hRnqCZku/Lt142baAXCvMVPZkdAKX39DEGL7iuC7l7a+AshDksQEyb5Vl2H+lRv+EClSC3nwRWXVJuMR+PkXsK2Qd8eREkF0hJxELUpfxM5W+fAYPZyBMLR7IRBuOzoAsy1+x54z2brYYetSMA9fOybmFFhe80GFZJ1+sydjD1Z7TgBy01Mp+gB/05lAWTqwc7aU5YQNSGeqxilTzOyJTKV+JZK6r6AgYJTRiidcX4CWhKIGyt+VooI6AqpEldjiCtfm9vZvD+6efOGyXhRSYdeMW5ZbI5MkNp7MFsSlji23/SLy7eWBnBdcdUb5GLYoH0E/4yS90xIFay0VfsNsdQcU0AP8QFgRbhZ5as12ad2i5nMdQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3745.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(451199021)(33656002)(122000001)(38100700002)(36756003)(7416002)(5660300002)(38070700005)(8936002)(76116006)(66556008)(66446008)(66946007)(8676002)(86362001)(41300700001)(4326008)(6916009)(66476007)(64756008)(91956017)(966005)(2616005)(26005)(54906003)(53546011)(2906002)(6512007)(6506007)(6486002)(71200400001)(478600001)(186003)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <80EFDB6C63C4DA4FB717E4EFAF5C8824@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8222 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 04d21212-0789-43a2-b402-08db34ddbf71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xIyCZxPUW1EiT9pmyFVSNkwweJtQ64d5UUfBJrPUiuaODYwNy+8ip33rLcPbQHpHKwD59XbbZluALrSwuXf+gw95+pcA0+7hYnyitz/wiYwwx8ROTdyGPuo6w2ArCD0ntJkFnf93JEUJq6dqpeMSeYtftI+FaFGmbKWd+Rp8qCubLYowCxKUl4vYuBVwFEO+elx3QIKcSe5WgavWkByR/QOtnkH/+nWkrxhXNxx956KUj8ZQvRu1r8ZaJ8+1hg1i7+hzfOHPH837WZRatf+lLiQnMjDZCwJ2Di+xW7yEn/BO9v8skAQL3sNjYe/cd4xpNhR8fvnob0z2kPRsOF54b2s9lHESiKgzgUkGd/HOvNN9Bgs9LK58avTWjabXZ1yWS8kLz9mCmat9ewxUbU6b/Ebw3GU57yyf4fFqcPXy4IMiIA0ac2A1tAlSocpO1dAykxIHJGFONE8bY5374F+ATZsXeV9Zieza2ePGstMwTuZgEbgE/5jtWE9fkbpL6QDhfB/hCpU5MctfOUbqZXuAugn92jFIjGNvuunBVV3/hVp9pi1PiuAkOS49QmIiG5BQ/mqS5KaK6mg1uTahBZv/O5jTku6fXHPPjjSkpvxhPl7JIhXVoqpvInhk/5vnOo4Gj+JKW6jHh2k9Bu10Or5mI1n1aRib/mZjK9LoqVHCiiJmSnczT/magiqNAeFeYgkO X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199021)(40470700004)(46966006)(36840700001)(82740400003)(82310400005)(356005)(81166007)(40460700003)(86362001)(40480700001)(36756003)(33656002)(966005)(107886003)(6512007)(2906002)(186003)(4326008)(26005)(6506007)(70206006)(70586007)(5660300002)(41300700001)(8936002)(478600001)(8676002)(54906003)(316002)(6862004)(6486002)(36860700001)(53546011)(336012)(47076005)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 07:25:32.0874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ead9dac-8345-4ada-d05f-08db34ddc64f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8129 SGkgQW50aG9ueSwNCg0KVGhhbmsgeW91IGZvciB5b3VyIHJldmlldw0KDQo+IE9uIDMwIE1hciAy MDIzLCBhdCAxNzo0OSwgQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+ IHdyb3RlOg0KPiANCj4gT24gTW9uLCBNYXIgMjcsIDIwMjMgYXQgMTE6NTk6NDFBTSArMDEwMCwg THVjYSBGYW5jZWxsdSB3cm90ZToNCj4+IC0tLQ0KPj4gdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hl bHBlcnMuZ2VuLmdvICAgIHwgIDIgKysNCj4+IHRvb2xzL2dvbGFuZy94ZW5saWdodC90eXBlcy5n ZW4uZ28gICAgICB8ICAxICsNCj4+IHRvb2xzL2luY2x1ZGUvYXJtLWFyY2gtY2FwYWJpbGl0aWVz LmggICB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysNCj4gDQo+IENvdWxkIHlvdSBtb3Zl IHRoYXQgbmV3IGZpbGUgaW50byAidG9vbHMvaW5jbHVkZS94ZW4tdG9vbHMvIiwgd2hlcmUNCj4g ImNvbW1vbi1tYWNyb3MuaCIgaXMuIFRoZSB0b3AtZGlyICJ0b29scy9pbmNsdWRlIiBhbHJlYWR5 IGhhcyBhIG1peHR1cmUNCj4gb2YgaW5zdGFsbGVkIGFuZCBpbnRlcm5hbCBoZWFkZXJzLCBidXQg bW9zdCBvZiB0aGVtIGFyZSBpbnN0YWxsZWQuIFNvDQo+IHRoZSBmYWlybHkgcmVjZW50ICJ4ZW4t dG9vbHMiIGRpciB3aGljaCBoYXZlIGJlZW4gaW50cm9kdWNlZCB0byBzaGFyZQ0KPiBtYWNyb3Mg YXQgYnVpbGQgdGltZSBzZWVtcyBtb3JlIGFwcHJvcHJpYXRlIGZvciBhbm90aGVyIGJ1aWx0LXRp bWUNCj4gbWFjcm8uDQoNClllcyBJ4oCZbGwgZG8NCg0KPiANCj4+IHRvb2xzL2luY2x1ZGUveGVu LXRvb2xzL2NvbW1vbi1tYWNyb3MuaCB8ICAyICsrDQo+PiANCj4+IGRpZmYgLS1naXQgYS90b29s cy9pbmNsdWRlL2FybS1hcmNoLWNhcGFiaWxpdGllcy5oIGIvdG9vbHMvaW5jbHVkZS9hcm0tYXJj aC1jYXBhYmlsaXRpZXMuaA0KPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+IGluZGV4IDAwMDAw MDAwMDAwMC4uNDZlODc2NjUxMDUyDQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi90b29scy9p bmNsdWRlL2FybS1hcmNoLWNhcGFiaWxpdGllcy5oDQo+PiBAQCAtMCwwICsxLDMzIEBADQo+PiAr LyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAgKi8NCj4+ICsvKg0KPj4gKyAqIENv cHlyaWdodCAoQykgMjAyMyBBUk0gTHRkLg0KPj4gKyAqLw0KPj4gKw0KPj4gKyNpZm5kZWYgQVJN X0FSQ0hfQ0FQQUJJTElUSUVTX0gNCj4+ICsjZGVmaW5lIEFSTV9BUkNIX0NBUEFCSUxJVElFU19I DQo+PiArDQo+PiArLyogVGVsbCB0aGUgWGVuIHB1YmxpYyBoZWFkZXJzIHdlIGFyZSBhIHVzZXIt c3BhY2UgdG9vbHMgYnVpbGQuICovDQo+PiArI2lmbmRlZiBfX1hFTl9UT09MU19fDQo+PiArI2Rl ZmluZSBfX1hFTl9UT09MU19fIDENCj4gDQo+IFNvbWVob3csIHRoaXMgZG9lc24ndCBzZWVtcyBh cHByb3ByaWF0ZSBpbiB0aGlzIGhlYWRlci4gVGhpcyBtYWNybw0KPiBzaG91bGQgaW5zdGVhZCBi ZSBzZXQgb24gdGhlIGNvbW1hbmQgbGluZS4gQW55IHJlYXNvbiB5b3UndmUgYWRkZWQgdGhpcw0K PiBpbiB0aGUgaGVhZGVyPw0KDQpJ4oCZdmUgYWRkZWQgdGhhdCBiZWNhdXNlIHN5c2N0bC5oIGlz IGRvaW5nIHRoaXM6DQoNCiNpZiAhZGVmaW5lZChfX1hFTl9fKSAmJiAhZGVmaW5lZChfX1hFTl9U T09MU19fKQ0KI2Vycm9yICJzeXNjdGwgb3BlcmF0aW9ucyBhcmUgaW50ZW5kZWQgZm9yIHVzZSBi eSBub2RlIGNvbnRyb2wgdG9vbHMgb25seSINCiNlbmRpZg0KDQpCdXQgSeKAmXZlIG5vdCBjaGVj a2VkIGlmIHRoZSBtYWNybyBpcyBhbHJlYWR5IHBhc3NlZCB0aHJvdWdoIHRoZSBidWlsZCBzeXN0 ZW0sIEnigJlsbA0KdHJ5IGFuZCBJ4oCZbGwgcmVtb3ZlIGl0IGlmIGl04oCZcyB0aGUgY2FzZQ0K DQo+IA0KPj4gKyNlbmRpZg0KPj4gKw0KPj4gKyNpbmNsdWRlIDxzdGRpbnQuaD4NCj4+ICsjaW5j bHVkZSA8eGVuL3N5c2N0bC5oPg0KPj4gKw0KPj4gKyNpbmNsdWRlIDx4ZW4tdG9vbHMvY29tbW9u LW1hY3Jvcy5oPg0KPj4gKw0KPj4gK3N0YXRpYyBpbmxpbmUNCj4+ICt1bnNpZ25lZCBpbnQgYXJj aF9jYXBhYmlsaXRpZXNfYXJtX3N2ZSh1bnNpZ25lZCBpbnQgYXJjaF9jYXBhYmlsaXRpZXMpDQo+ PiArew0KPj4gKyNpZiBkZWZpbmVkKF9fYWFyY2g2NF9fKQ0KPj4gKyAgICB1bnNpZ25lZCBpbnQg c3ZlX3ZsID0gTUFTS19FWFRSKGFyY2hfY2FwYWJpbGl0aWVzLA0KPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFhFTl9TWVNDVExfUEhZU0NBUF9BUk1fU1ZFX01BU0spOw0K Pj4gKw0KPj4gKyAgICAvKiBWZWN0b3IgbGVuZ3RoIGlzIGRpdmlkZWQgYnkgMTI4IGJlZm9yZSBz dG9yaW5nIGl0IGluIGFyY2hfY2FwYWJpbGl0aWVzICovDQo+PiArICAgIHJldHVybiBzdmVfdmwg KiAxMjhVOw0KPj4gKyNlbHNlDQo+PiArICAgIHJldHVybiAwOw0KPj4gKyNlbmRpZg0KPj4gK30N Cj4+ICsNCj4+ICsjZW5kaWYgLyogQVJNX0FSQ0hfQ0FQQUJJTElUSUVTX0ggKi8NCj4+IGRpZmYg LS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbCBiL3Rvb2xzL2xpYnMvbGln aHQvbGlieGxfdHlwZXMuaWRsDQo+PiBpbmRleCBjMTAyOTJlMGQ3ZTMuLmZkMzFkYWNmN2Q1YSAx MDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiArKysg Yi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4gQEAgLTExMzMsNiArMTEzMyw3 IEBAIGxpYnhsX3BoeXNpbmZvID0gU3RydWN0KCJwaHlzaW5mbyIsIFsNCj4+ICAgICAoImNhcF92 cG11IiwgYm9vbCksDQo+PiAgICAgKCJjYXBfZ250dGFiX3YxIiwgYm9vbCksDQo+PiAgICAgKCJj YXBfZ250dGFiX3YyIiwgYm9vbCksDQo+PiArICAgICgiYXJjaF9jYXBhYmlsaXRpZXMiLCB1aW50 MzIpLA0KPiANCj4gVGhpcyBhZGRpdGlvbmFsIGZpZWxkIG5lZWRzIGEgbmV3IExJQlhMX0hBVkVf IG1hY3JvIGluICJsaWJ4bC5oIi4NCg0KSeKAmWxsIGFkZA0KDQo+IA0KPj4gICAgIF0sIGRpcj1E SVJfT1VUKQ0KPj4gDQo+PiBsaWJ4bF9jb25uZWN0b3JpbmZvID0gU3RydWN0KCJjb25uZWN0b3Jp bmZvIiwgWw0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3B5dGhvbi94ZW4vbG93bGV2ZWwveGMveGMu YyBiL3Rvb2xzL3B5dGhvbi94ZW4vbG93bGV2ZWwveGMveGMuYw0KPj4gaW5kZXggMzU5MDFjMmQ2 M2I2Li4yNTRkM2I1ZGNjZDIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9weXRob24veGVuL2xvd2xl dmVsL3hjL3hjLmMNCj4+ICsrKyBiL3Rvb2xzL3B5dGhvbi94ZW4vbG93bGV2ZWwveGMveGMuYw0K Pj4gQEAgLTcsNiArNyw3IEBADQo+PiAjZGVmaW5lIFBZX1NTSVpFX1RfQ0xFQU4NCj4+ICNpbmNs dWRlIDxQeXRob24uaD4NCj4+ICNkZWZpbmUgWENfV0FOVF9DT01QQVRfTUFQX0ZPUkVJR05fQVBJ DQo+PiArI2luY2x1ZGUgPGFybS1hcmNoLWNhcGFiaWxpdGllcy5oPg0KPiANCj4gQ291bGQgeW91 IGFkZCB0aGlzIGhlYWRlciAuLi4NCj4gDQo+PiAjaW5jbHVkZSA8eGVuY3RybC5oPg0KPj4gI2lu Y2x1ZGUgPHhlbmd1ZXN0Lmg+DQo+PiAjaW5jbHVkZSA8ZmNudGwuaD4NCj4+IEBAIC0yMiw4ICsy Myw2IEBADQo+PiAjaW5jbHVkZSA8eGVuL2h2bS9odm1faW5mb190YWJsZS5oPg0KPj4gI2luY2x1 ZGUgPHhlbi9odm0vcGFyYW1zLmg+DQo+PiANCj4+IC0jaW5jbHVkZSA8eGVuLXRvb2xzL2NvbW1v bi1tYWNyb3MuaD4NCj4+IC0NCj4gDQo+IC4uLiBoZXJlLCBpbnN0ZWFkPw0KPiANCj4gQWxzbywg SSB0aGluayAjaW5jbHVkZSBjb21tb24tbWFjcm9zLCBjYW4gc3RheS4NCg0KT2sgSeKAmWxsIGRv IHRoZSBtb2RpZmljYXRpb25zDQoNCj4gDQo+PiAvKiBOZWVkZWQgZm9yIFB5dGhvbiB2ZXJzaW9u cyBlYXJsaWVyIHRoYW4gMi4zLiAqLw0KPj4gI2lmbmRlZiBQeU1PRElOSVRfRlVOQw0KPj4gI2Rl ZmluZSBQeU1PRElOSVRfRlVOQyBETF9FWFBPUlQodm9pZCkNCj4+IEBAIC04OTcsNyArODk2LDcg QEAgc3RhdGljIFB5T2JqZWN0ICpweXhjX3BoeXNpbmZvKFhjT2JqZWN0ICpzZWxmKQ0KPj4gICAg IGlmICggcCAhPSB2aXJ0X2NhcHMgKQ0KPj4gICAgICAgKihwLTEpID0gJ1wwJzsNCj4+IA0KPj4g LSAgICByZXR1cm4gUHlfQnVpbGRWYWx1ZSgie3M6aSxzOmksczppLHM6aSxzOmwsczpsLHM6bCxz OmksczpzLHM6c30iLA0KPj4gKyAgICByZXR1cm4gUHlfQnVpbGRWYWx1ZSgie3M6aSxzOmksczpp LHM6aSxzOmwsczpsLHM6bCxzOmksczpzLHM6cyxzOml9IiwNCj4+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAibnJfbm9kZXMiLCAgICAgICAgIHBpbmZvLm5yX25vZGVzLA0KPj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJ0aHJlYWRzX3Blcl9jb3JlIiwgcGluZm8udGhyZWFkc19w ZXJfY29yZSwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiY29yZXNfcGVyX3NvY2tl dCIsIHBpbmZvLmNvcmVzX3Blcl9zb2NrZXQsDQo+PiBAQCAtOTA3LDcgKzkwNiwxMCBAQCBzdGF0 aWMgUHlPYmplY3QgKnB5eGNfcGh5c2luZm8oWGNPYmplY3QgKnNlbGYpDQo+PiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgInNjcnViX21lbW9yeSIsICAgICBwYWdlc190b19raWIocGluZm8u c2NydWJfcGFnZXMpLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjcHVfa2h6Iiwg ICAgICAgICAgcGluZm8uY3B1X2toeiwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi aHdfY2FwcyIsICAgICAgICAgIGNwdV9jYXAsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJ2aXJ0X2NhcHMiLCAgICAgICAgdmlydF9jYXBzKTsNCj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgInZpcnRfY2FwcyIsICAgICAgICB2aXJ0X2NhcHMsDQo+PiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJhcm1fc3ZlX3ZsIiwNCj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBhcmNoX2NhcGFiaWxpdGllc19hcm1fc3ZlKHBpbmZvLmFyY2hfY2FwYWJpbGl0 aWVzKQ0KPiANCj4gYXJjaF9jYXBhYmlsaXRpZXNfYXJtX3N2ZSgpIHJldHVybnMgYW4gInVuc2ln bmVkIGludCIsIGJ1dCB0aGUgZm9ybWF0IGlzDQo+ICJpIiwgd2hpY2ggc2VlbXMgdG8gYmUgYW4g ImludCIuIFNob3VsZG4ndCB0aGUgZm9ybWF0IGJlICJJIiBpbnN0ZWFkPw0KPiANCj4gaHR0cHM6 Ly9kb2NzLnB5dGhvbi5vcmcvMy9jLWFwaS9hcmcuaHRtbCNjLlB5X0J1aWxkVmFsdWUNCg0KWWVz IHlvdSBhcmUgcmlnaHQsIEnigJlsbCBjaGFuZ2UgaXQNCg0KPiANCj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICApOw0KPj4gfQ0KPj4gDQo+PiBzdGF0aWMgUHlPYmplY3QgKnB5eGNfZ2V0Y3B1 aW5mbyhYY09iamVjdCAqc2VsZiwgUHlPYmplY3QgKmFyZ3MsIFB5T2JqZWN0ICprd2RzKQ0KPj4g ZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL3hsX2luZm8uYyBiL3Rvb2xzL3hsL3hsX2luZm8uYw0KPj4g aW5kZXggNzEyYjc2MzhiMDEzLi5iZjE4YmEyNDQ5ZWYgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94 bC94bF9pbmZvLmMNCj4+ICsrKyBiL3Rvb2xzL3hsL3hsX2luZm8uYw0KPj4gQEAgLTE0LDYgKzE0 LDcgQEANCj4+IA0KPj4gI2RlZmluZSBfR05VX1NPVVJDRQ0KPj4gDQo+PiArI2luY2x1ZGUgPGFy bS1hcmNoLWNhcGFiaWxpdGllcy5oPg0KPiANCj4gQW55IHJlYXNvbiByZWFzb24gdG8gaGF2ZSB0 aGlzIGhlYWRlciBmaXJzdD8NCj4gSSBmZWVsIGxpa2UgcHJpdmF0ZSBoZWFkZXJzIHNob3VsZCBj b21lIGFmdGVyIHB1YmxpYyBvbmVzLCBzbyBoZXJlLCB0aGlzDQo+IGluY2x1ZGUgd291bGQgYmUg YWRkZWQgYmV0d2VlbiA8bGlieGx1dGlsLmg+IGFuZCAieGwuaCIuDQoNCk9rIEnigJlsbCBtb3Zl IGl0DQoNCj4gDQo+PiAjaW5jbHVkZSA8ZmNudGwuaD4NCj4+ICNpbmNsdWRlIDxpbnR0eXBlcy5o Pg0KPj4gI2luY2x1ZGUgPHN0ZGxpYi5oPg0KPj4gQEAgLTIyNCw2ICsyMjUsMTMgQEAgc3RhdGlj IHZvaWQgb3V0cHV0X3BoeXNpbmZvKHZvaWQpDQo+PiAgICAgICAgICBpbmZvLmNhcF9nbnR0YWJf djIgPyAiIGdudHRhYi12MiIgOiAiIg0KPj4gICAgICAgICApOw0KPj4gDQo+PiArICAgIC8qIFBy aW50IGFybSBTVkUgdmVjdG9yIGxlbmd0aCBvbmx5IG9uIEFSTSBwbGF0Zm9ybXMgKi8NCj4+ICsj aWYgZGVmaW5lZChfX2FhcmNoNjRfXykNCj4+ICsgICAgbWF5YmVfcHJpbnRmKCJhcm1fc3ZlX3Zl Y3Rvcl9sZW5ndGggIDogJXVcbiIsDQo+PiArICAgICAgICAgYXJjaF9jYXBhYmlsaXRpZXNfYXJt X3N2ZShpbmZvLmFyY2hfY2FwYWJpbGl0aWVzKQ0KPj4gKyAgICAgICAgKTsNCj4+ICsjZW5kaWYN Cj4+ICsNCj4+ICAgICB2aW5mbyA9IGxpYnhsX2dldF92ZXJzaW9uX2luZm8oY3R4KTsNCj4+ICAg ICBpZiAodmluZm8pIHsNCj4+ICAgICAgICAgaSA9ICgxIDw8IDIwKSAvIHZpbmZvLT5wYWdlc2l6 ZTsNCj4gDQo+IFRoYW5rcywNCj4gDQo+IC0tIA0KPiBBbnRob255IFBFUkFSRA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Apr 04 07:38:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 07:38:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517672.803369 (Exim 4.92) (envelope-from ) id 1pjbEk-0003Sh-E0; Tue, 04 Apr 2023 07:37:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517672.803369; Tue, 04 Apr 2023 07:37:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjbEk-0003SZ-BG; Tue, 04 Apr 2023 07:37:50 +0000 Received: by outflank-mailman (input) for mailman id 517672; Tue, 04 Apr 2023 07:37:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjbEi-0003SQ-C5 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 07:37:48 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7d00::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9828afdf-d2bb-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 09:37:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9099.eurprd04.prod.outlook.com (2603:10a6:10:2f2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 07:37:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 07:37:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9828afdf-d2bb-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyQ2v5VCAOBCG5+IGWoKhxOJ1219jOEz/0JvInID30pnHeWRk6DDpnJqTGSBY3pFcfmQK7K7GN9cnIp8liFKoQbYON1gq1xonS4pS3T7k/g3HotSPA+7lSj1vtMjafTDCDdXjTIDruMVy/K0CIMZI7w5E5pobGk269SP0Qr3ptoLYxS6JAKfP9O6QQBhkDBy6w8r3YPlJHEssPJA4kPrWVD6TNGK1NuyaJyB1qPPK3hp02+GV0P4L9bpgpWxjFSDF55uNcxm2zMbmVWlv6+4NCh19gHyIXWPj8FK3jwYoVZXRnF02ptq5CjOmuvvli6zcSTa9nye5cRWfmCZGDIB+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9iXgmTsj+0Rxvl5Ewhk+C1qP1W68DSWKVggTNGwczk=; b=b2moBjgtdKWmeSf+pGQNi7a9hyOV/1n8s+Irq9Suj4upp2azGhTyG3i1AQsdPao4B6xP+U0G7qg37KnUDkZSDEep6w9/QTivXTwY2HHOYM7d+vMu6ZzgZP+5Fusm6kPFMXGoIG8wkTAQJSpzd2yc96VjYaiWe0SQ4HU72i/8O85vOKmne4ClRdGqmSP5pCSj0Uf57dyjBLXe9eUYqQUIRA2y/vAECrX+JWfM07ciXwjSqkNpSDJMctzg4sOKTbr43yPI0iJWxZjw9sEBlXLAcgdwblIUqtEr3aTOlk38dOvEjMXGLdwj/rft/T79YMD4uMKVN9JxYRTSBXBWK3VIVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9iXgmTsj+0Rxvl5Ewhk+C1qP1W68DSWKVggTNGwczk=; b=2ZJCzns286owsxMv5qGWrWcrScvHmuVa8qEzbNc7bAAFyANOw6jyWLtROjFHo1JvrL5IgqaxOkeZ9k65Bzjjdgzj4hl1M0FjHNI0A8/UkHSnvBr7jdExkeM6xhppfLEj8KfEO9JyOtdJMUBPCepEZRM1HGsJLSprM+1KU6AKEY37h8BZrYsy6E+9nN7VkxFNVNEU3hGujdg4q1w1iyMwCmpFpkYPG+Azmin65Ca87+4IaOKa9ygv0G25qG+wog+G1E+3rb5R+okROP9LQ7fdlLLTR4XyXr8+XB5NGBTJryD4wajbUcmIq7CskVihZCYwzckoqpsEVUQQKuAm1BP0tg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ab50964-bf29-b580-7ef6-78aa0e6a7a7f@suse.com> Date: Tue, 4 Apr 2023 09:37:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] cmdline: document "extra_guest_irqs" upper bound Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <0e165632-938d-596b-3087-75da66641d85@citrix.com> From: Jan Beulich In-Reply-To: <0e165632-938d-596b-3087-75da66641d85@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9099:EE_ X-MS-Office365-Filtering-Correlation-Id: ca3bb805-3ab5-4dbb-82b3-08db34df7a97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nBRF3TZYN6rv0oEUEaEKC7i7sRmzECA3RfX76xp6QWSSR7TszHtdXwgbHV23zcStLqhYFiSPiuH2cHHmR6MDQa4gIXi1YoRcG4iaGsJVhQ8zi6hRnu9wP5QkUhHn/9zEj7/LeyQLsN9cpmlEMlg1xakp/5TQRu0saUIzcmrjJGcfs3K0IDGlt7L2cfXMPFYdZmoetfO+8Ir/LlkRd0npQdswmhNCGFJJ87Ct4ecQT65zlV+dteLCp/w0m9oTUl3ajsmjK9pb2AjACt3Xj4qwaJRFebix2qKtT2odYvQUc/K8skG2rw1rGHVUs8TtwBWR/DURr46MQIph3qN/msiYYnMU1T1J0dNzA4/xIzgqaltVM6au4Te9Q8CNa7xatx80bUXYfHITmLk6Gjtmf3ooNeUI/bhIdXuRWBPoaoN6W4P18L4ow66vAmsP163smxvG6ugnzmFgEHxKftzLuaalPXVQy1kuNDaPHM7CgBKhyqQA+mZ0Ndi/YZajAqCsgJg2h6HE9B/Vsz5+ABWxtjXG8lyoym65ET/qO+0EnZ9BYHA4VWDdjBt+ZkSHrtiI7T6pjSkHkIE4JfIFLBpKwIWhK7pLByWiaPOkTiGrci/tCGYMxb6q5woD7LLyoyawxzStw/IWVkUu/R+MhAqxXH+LKw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(136003)(346002)(376002)(451199021)(5660300002)(31686004)(316002)(2906002)(54906003)(41300700001)(8936002)(186003)(478600001)(6916009)(8676002)(4326008)(66946007)(66476007)(66556008)(4744005)(6486002)(53546011)(6512007)(26005)(6506007)(2616005)(83380400001)(36756003)(86362001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0hET3BCZEFWaGhFL21XYkxTcU1EUXBYUGlTNmkxY3dFYmdFRWE2d2ZnTmR4?= =?utf-8?B?MTFQU0ZJKzZxVG5jK2hZNGQ3ampvcmFxcFVlTkdPaTVNeVNKaGlsS1hjRmRI?= =?utf-8?B?U2tkZHNPT1Z6N3VDVkhhY3UxZ2xyN2VhNnRSY1hqNGZyL1M0MXAzTVpwL2NC?= =?utf-8?B?UWhLOWZTc2UvTXpDbjN0YmsrcDVsQVdmSWpyNmJyMVB2MjlPdktoTXNwY2o3?= =?utf-8?B?YWcyWThtSzlVdE1NY2lxaDBkSFQ1TnltU0kzUHBUaytNc2JEdTIvSXpkczR6?= =?utf-8?B?a3BDemYvVit1dzNkYVRWWkJFZ0NBQzE2a3ZGT2lBMVJINHNxT1JoRzVqbTBY?= =?utf-8?B?TktIRWJ6K2JYNkFRR1RIRDVDNkZIVjY5aC9pNG84R2ttUnlaRldYYUFqZklO?= =?utf-8?B?Q3pocDF2NFhGbitTME5Ga0RESEI1YWJqSlBkY29abjdkS0tSV2RFUm1oQjdl?= =?utf-8?B?Rzd3N055eCtvYjY4RXZTR0JPeTZsWGNQTnhXK0locmZmQlErclgxRjBHblJL?= =?utf-8?B?OHc0RnFhQzVLLzVkTTlDQnZpL3N5Wk9RZVhnZEpvK01jeVYyTFFlRnRjMGJK?= =?utf-8?B?UGNCaUIrV0x6WXp3SVF4ZTUreGlvVUhnM2luaVhFRFdtT2MxWmQ3RTJUdUM2?= =?utf-8?B?dHFiM3BHY3ZObzlwYTFPZUtaVEt1dy9WUzRvclhsWlZYUkVaeDV6UzZvdmRE?= =?utf-8?B?RUtYRlRKUWdxYTVRdkJGRU1SK2xGNjZSdlZucmtXMXRXTkNyMk1NcUFmMmc0?= =?utf-8?B?anp6Ui9SNUZSV0FOSUQvc054djlqOGFlMVpYUEdMZy9uL2cyUDJaR2xURGVF?= =?utf-8?B?SWpMczlnMW53OVZoY3RFOGtDTFhCSDRUcVhGeUxReUV0SVRGNnNhWFErVHZX?= =?utf-8?B?VGxheTRvTjdIMkRlSTIrMEFZMWhGa045UWNHcDhCU0tnMTVONGpmckwzejdU?= =?utf-8?B?Zys4VXRCS2FrL3h0a0dENVprQnRwOUtyRnJGaktEK3lJVTk1RzFrZjJGd3h1?= =?utf-8?B?bjhxZ2tOeTJDVVlJZWNnUHoveWlQK0Z1dHpTeXhhQkxQTnVnVGdEN2lBWVk0?= =?utf-8?B?OTJGaUJDcVRaY2dsK3NFdkM1YXF6cDExUkt0K0dBYXNNTDduL3RYV3ZqYjM3?= =?utf-8?B?dGxOYXdaZGVRM0VpdDBaVEM1N1QwOTdESTczKzhZRHoycFBoWmEza1RxVUpU?= =?utf-8?B?enA2Tm5oTU5yMkgzS0VncDZYcWl2TjF6OG9kN01XNmlHMFpnNncxcG9RYVBB?= =?utf-8?B?UXp4UHhadGk2bkFSNGpwcUVBV3FZamxqWEhCS2tJZVpPK0RyL29WOG9jYzhP?= =?utf-8?B?dWFHYWl1Z2FWTHYrdkxuRjhBUVpPVWp5OGU4ODFNTjcxVDhXY3FaSnZ5YTcr?= =?utf-8?B?QUdoV0dyMmpXNFkyNmRya282VlhQTDdDQ1NTbGJRVk9VekdiNE1WQXUrNU0r?= =?utf-8?B?Y3VEVWlTaWFTVVEwRkpFK1Y3cTJaclRLdzdDa2ZzdGNEZ1pTeTBqaGxSSldB?= =?utf-8?B?QjdzU0VlZFNzbW05d3lXNXgxUk9QN3VqL2JhTEVjUkM2VkE4dnpyMGc1UEV6?= =?utf-8?B?SHBydXh6Yld4RExMckVnQlRLUCtxUC9oalBiR3RDKzMvTXdCTGlpenFYeDN0?= =?utf-8?B?eGMxT0o2VDVTVjhDM1U4WWtqU0oxczZPY1pRNmpVQmxuR240QnpLQnZnbGRs?= =?utf-8?B?YTBPVUZPeXYvZ3VESXAyaC9IMElBRCt2V3czV0hqWHRHdkg4SlRKVGsyMjRm?= =?utf-8?B?QU5YM0xZNEROWmY3Z1A5cGx4UklWcjlSL016VmRIQ0hVR1h1N0QzT3VwSkNm?= =?utf-8?B?RHJzZDYwVHNzOCtTeGJNSExlM3R5ajYwellodW5Db3hNeUxiWHBnU2ZPYk9E?= =?utf-8?B?bzBHUUIzb01XelY5YXozN3VnYlVqS0JvR1lZZ2EwNzBjMU5LcENId3RXaGgr?= =?utf-8?B?UTlsbS93bjNRNlRtdTdkeWpvaGw5SWdaSzJzSnh1RFovTmg1K2EvYUE3bGh0?= =?utf-8?B?a0JHT0t2L0hsOG9zVGVYSDVQMHhZMzQ4YTRVWUIvSWJXMGZJdzRKUjJKL25V?= =?utf-8?B?RTdyU3gvUlE1OU9GVnZDamhldDlUdnBoMVRsaG94aHpZTGFEOVA4WCtJeVNk?= =?utf-8?Q?Kr3fSIh6sOoQtRcHHbTVVZ571?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca3bb805-3ab5-4dbb-82b3-08db34df7a97 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 07:37:44.3466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NWpUQGb+Gs1qMsDd5LTCGitg9nqJSA2jARTRPKXonESYUPLkQDDomKgMQTAl7JtvrJD1st4FCdfVoht0FGky3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9099 On 04.04.2023 09:09, Andrew Cooper wrote: > On 04/04/2023 7:46 am, Jan Beulich wrote: >> PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no >> more than 32k pIRQ-s can be used by a domain. Document this upper bound. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks, but because of the below I guess I'll make a v2. >> --- >> I was uncertain about also introducing a bounds check in code: We don't >> check for bogus / abusive values elsewhere either. > > Normally not, but in this case I suspect it's worth it.  Without a > bounds check, don't we risk wandering off the page? Indeed we do; in debug builds we hit assertions. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 08:10:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 08:10:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517680.803380 (Exim 4.92) (envelope-from ) id 1pjbjm-0007Ua-AA; Tue, 04 Apr 2023 08:09:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517680.803380; Tue, 04 Apr 2023 08:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjbjm-0007UT-7H; Tue, 04 Apr 2023 08:09:54 +0000 Received: by outflank-mailman (input) for mailman id 517680; Tue, 04 Apr 2023 08:09:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjbjl-0007UN-H1 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 08:09:53 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 132c36a6-d2c0-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 10:09:51 +0200 (CEST) Received: by mail-lf1-x12c.google.com with SMTP id g19so28180438lfr.9 for ; Tue, 04 Apr 2023 01:09:51 -0700 (PDT) Received: from [192.168.202.197] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id l10-20020ac24a8a000000b004db3e445f1fsm2205676lfp.97.2023.04.04.01.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 01:09:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 132c36a6-d2c0-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680595791; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5z+oL0CEH0hrowCjVXAlWzw0WLtvmNnQxZR5UH2VOjM=; b=bVbpgCtfMLjb4MUQAJF9M7j3q5DlwGRXTIaRBHi/TVwj7VWYneEepIVp1C1X2RXAl6 lcVyqlhciICOg5kpi9DavDk9UnXwo2mYBt9nmjXNa69o0etNJnxoS9Hf1hWkv1YsY8I+ ai8lQcRqsbkup05rZmyUnETgnsLfOayvypXa6NIdbJ3CS8c1G0I7pO38kJAaRHQjpq88 E6RHEV1mw2oapFIVsuF9UaKDNTdnYq4xBNKJQSExh3waEw1fMdkq/+GsVru+cMWQ+S1t qGOV8SVscyJFxLmp1U44XdeM3bKZTPGi529lHSvIxSWWT5A2mDZPV0zUeuL/MgPCw14i ICMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680595791; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5z+oL0CEH0hrowCjVXAlWzw0WLtvmNnQxZR5UH2VOjM=; b=2wzHrZq4YojvjbCCrUZBVnl2qsrXJS9F45o60njsqKtwurUB9xWS6oblYclNg9LyF/ CM0cFE6Cvtyyv41BPoVgk7kgxouFwpZqbCP3KAvCXD0RrN/9cKlMGFmXcP3wssZpu4x9 knrHIKnRSyGo1dZjKMtyB1dSJZmMGXjt5/msmYkBs+kEy2Co1v2i2RY9z3BJYFjF7/pP pVq/CoEQewQMZqY7EM1iwjdJEggQgjjBcju9zFZV28gZ8weM0bg7vJfcKTyymiLx9wtz fUjIkAPeBqS78pJyee5pWu92ftxEYAPfXl1qYo3c+SgvraDtPfk/I9inOlK9FU1uR6qS i3QA== X-Gm-Message-State: AAQBX9f2X6Kj4egXItb5wf6atrir4cUgoy+ee7xVyYvjjT1pGOtg3CUm Wig+0b9wzhMWyKZe4043qO8= X-Google-Smtp-Source: AKy350bxrCz6UxynTAaF3n2L7sCDwK6TCD2MGrvMRukGdH6BghtA4gpnUPdyvRSSa6dz7SsBubnAJQ== X-Received: by 2002:ac2:42c4:0:b0:4e9:ad85:aa09 with SMTP id n4-20020ac242c4000000b004e9ad85aa09mr404758lfl.68.1680595791004; Tue, 04 Apr 2023 01:09:51 -0700 (PDT) Message-ID: Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Julien Grall Date: Tue, 04 Apr 2023 11:09:49 +0300 In-Reply-To: <9c4ca4a1-1b68-5ee0-0434-e6c9ec7d1ef6@suse.com> References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> <9c4ca4a1-1b68-5ee0-0434-e6c9ec7d1ef6@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 T24gVHVlLCAyMDIzLTA0LTA0IGF0IDA4OjQxICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToKPiBP biAwMy4wNC4yMDIzIDIwOjQwLCBPbGVrc2lpIHdyb3RlOgo+ID4gSGVsbG8gSnVsaWVuLCAKPiA+ IE9uIEZyaSwgMjAyMy0wMy0zMSBhdCAyMjowNSArMDEwMCwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+ ID4gPiBIaSBPbGVrc2lpLAo+ID4gPiAKPiA+ID4gSSB3YXMgZ29pbmcgdG8gYWNrIHRoZSBwYXRj aCBidXQgdGhlbiBJIHNwb3R0ZWQgc29tZXRoaW5nIHRoYXQKPiA+ID4gd291bGQgCj4gPiA+IHdh bnQgc29tZSBjbGFyaWZpY2F0aW9uLgo+ID4gPiAKPiA+ID4gT24gMjkvMDMvMjAyMyAxMTo1MCwg T2xla3NpaSBLdXJvY2hrbyB3cm90ZToKPiA+ID4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL2J1Zy5oCj4gPiA+ID4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYnVn LmgKPiA+ID4gPiBpbmRleCBjYWNhZjAxNGFiLi4zZmIwNDcxYTliIDEwMDY0NAo+ID4gPiA+IC0t LSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9idWcuaAo+ID4gPiA+ICsrKyBiL3hlbi9hcmNo L2FybS9pbmNsdWRlL2FzbS9idWcuaAo+ID4gPiA+IEBAIC0xLDYgKzEsMjQgQEAKPiA+ID4gPiDC oCAjaWZuZGVmIF9fQVJNX0JVR19IX18KPiA+ID4gPiDCoCAjZGVmaW5lIF9fQVJNX0JVR19IX18K PiA+ID4gPiDCoCAKPiA+ID4gPiArLyoKPiA+ID4gPiArICogUGxlYXNlIGRvIG5vdCBpbmNsdWRl IGluIHRoZSBoZWFkZXIgYW55IGhlYWRlciB0aGF0IG1pZ2h0Cj4gPiA+ID4gKyAqIHVzZSBCVUcv QVNTRVJUL2V0YyBtYXJvcyBhc3RoZXkgd2lsbCBiZSBkZWZpbmVkIGxhdGVyIGFmdGVyCj4gPiA+ ID4gKyAqIHRoZSByZXR1cm4gdG8gPHhlbi9idWcuaD4gZnJvbSB0aGUgY3VycmVudCBoZWFkZXI6 Cj4gPiA+ID4gKyAqCj4gPiA+ID4gKyAqIDx4ZW4vYnVnLmg+Ogo+ID4gPiA+ICsgKsKgIC4uLgo+ ID4gPiA+ICsgKsKgwqAgPGFzbS9idWcuaD46Cj4gPiA+ID4gKyAqwqDCoMKgwqAgLi4uCj4gPiA+ ID4gKyAqwqDCoMKgwqAgPGFueV9oZWFkZXJfd2hpY2hfdXNlc19CVUcvQVNTRVJUL2V0YyBtYWNy b3MuaD4KPiA+ID4gPiArICrCoMKgwqDCoCAuLi4KPiA+ID4gPiArICrCoCAuLi4KPiA+ID4gPiAr ICrCoCAjZGVmaW5lIEJVRygpIC4uLgo+ID4gPiA+ICsgKsKgIC4uLgo+ID4gPiA+ICsgKsKgICNk ZWZpbmUgQVNTRVJUKCkgLi4uCj4gPiA+ID4gKyAqwqAgLi4uCj4gPiA+ID4gKyAqLwo+ID4gPiA+ ICsKPiA+ID4gPiDCoCAjaW5jbHVkZSA8eGVuL3R5cGVzLmg+Cj4gPiA+ID4gwqAgCj4gPiA+ID4g wqAgI2lmIGRlZmluZWQoQ09ORklHX0FSTV8zMikKPiA+ID4gPiBAQCAtMTEsNzYgKzI5LDcgQEAK PiA+ID4gPiDCoCAjIGVycm9yICJ1bmtub3duIEFSTSB2YXJpYW50Igo+ID4gPiA+IMKgICNlbmRp Zgo+ID4gPiA+IMKgIAo+ID4gPiA+IC0jZGVmaW5lIEJVR19GUkFNRV9TVFJVQ1QKPiA+ID4gPiAt Cj4gPiA+ID4gLXN0cnVjdCBidWdfZnJhbWUgewo+ID4gPiA+IC3CoMKgwqAgc2lnbmVkIGludCBs b2NfZGlzcDvCoMKgwqAgLyogUmVsYXRpdmUgYWRkcmVzcyB0byB0aGUgYnVnCj4gPiA+ID4gYWRk cmVzcwo+ID4gPiA+ICovCj4gPiA+ID4gLcKgwqDCoCBzaWduZWQgaW50IGZpbGVfZGlzcDvCoMKg IC8qIFJlbGF0aXZlIGFkZHJlc3MgdG8gdGhlCj4gPiA+ID4gZmlsZW5hbWUgKi8KPiA+ID4gPiAt wqDCoMKgIHNpZ25lZCBpbnQgbXNnX2Rpc3A7wqDCoMKgIC8qIFJlbGF0aXZlIGFkZHJlc3MgdG8g dGhlCj4gPiA+ID4gcHJlZGljYXRlCj4gPiA+ID4gKGZvciBBU1NFUlQpICovCj4gPiA+ID4gLcKg wqDCoCB1aW50MTZfdCBsaW5lO8KgwqDCoMKgwqDCoMKgwqDCoCAvKiBMaW5lIG51bWJlciAqLwo+ ID4gPiA+IC3CoMKgwqAgdWludDMyX3QgcGFkMDoxNjvCoMKgwqDCoMKgwqAgLyogUGFkZGluZyBm b3IgOC1ieXRlcyBhbGlnbiAqLwo+ID4gPiA+IC19Owo+ID4gPiA+IC0KPiA+ID4gPiAtI2RlZmlu ZSBidWdfbG9jKGIpICgoY29uc3Qgdm9pZCAqKShiKSArIChiKS0+bG9jX2Rpc3ApCj4gPiA+ID4g LSNkZWZpbmUgYnVnX2ZpbGUoYikgKChjb25zdCB2b2lkICopKGIpICsgKGIpLT5maWxlX2Rpc3Ap Owo+ID4gPiA+IC0jZGVmaW5lIGJ1Z19saW5lKGIpICgoYiktPmxpbmUpCj4gPiA+ID4gLSNkZWZp bmUgYnVnX21zZyhiKSAoKGNvbnN0IGNoYXIgKikoYikgKyAoYiktPm1zZ19kaXNwKQo+ID4gPiA+ IC0KPiA+ID4gPiAtLyogTWFueSB2ZXJzaW9ucyBvZiBHQ0MgZG9lc24ndCBzdXBwb3J0IHRoZSBh c20gJWMgcGFyYW1ldGVyCj4gPiA+ID4gd2hpY2gKPiA+ID4gPiB3b3VsZAo+ID4gPiA+IC0gKiBi ZSBwcmVmZXJhYmxlIHRvIHRoaXMgdW5wbGVhc2FudG5lc3MuIFdlIHVzZSBtZXJnZWFibGUKPiA+ ID4gPiBzdHJpbmcKPiA+ID4gPiAtICogc2VjdGlvbnMgdG8gYXZvaWQgbXVsdGlwbGUgY29waWVz IG9mIHRoZSBzdHJpbmcgYXBwZWFyaW5nCj4gPiA+ID4gaW4KPiA+ID4gPiB0aGUKPiA+ID4gPiAt ICogWGVuIGltYWdlLiBCVUdGUkFNRV9ydW5fZm4gbmVlZHMgdG8gYmUgaGFuZGxlZCBzZXBhcmF0 ZWx5Lgo+ID4gPiA+IC0gKi8KPiA+ID4gCj4gPiA+IEdpdmVuIHRoaXMgY29tbWVudCAuLi4KPiA+ ID4gCj4gPiA+ID4gLSNkZWZpbmUgQlVHX0ZSQU1FKHR5cGUsIGxpbmUsIGZpbGUsIGhhc19tc2cs IG1zZykgZG8KPiA+ID4gPiB7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ID4gPiAtwqDCoMKgIEJVSUxEX0JVR19PTigobGluZSkgPj4KPiA+ID4gPiAxNik7 wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiA+ID4gLcKgwqDCoCBCVUlMRF9C VUdfT04oKHR5cGUpID49Cj4gPiA+ID4gQlVHRlJBTUVfTlIpO8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4g PiA+IC3CoMKgwqAgYXNtCj4gPiA+ID4gKCIxOiJCVUdfSU5TVFIiXG4iwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgCj4gPiA+ID4gwqDCoMKgwqAKPiA+ID4gPiBcCj4gPiA+ID4gLcKg wqDCoMKgwqDCoMKgwqAgIi5wdXNoc2VjdGlvbiAucm9kYXRhLnN0ciwgXCJhTVNcIiwgJXByb2di aXRzLAo+ID4gPiA+IDFcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gPiA+ IC3CoMKgwqDCoMKgwqDCoMKgICIyOlx0LmFzY2l6ICIgX19zdHJpbmdpZnkoZmlsZSkKPiA+ID4g PiAiXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIFwKPiA+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoAo+ID4gPiA+ICIzOlxuIsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4g PiA+IMKgwqDCoAo+ID4gPiA+IFwKPiA+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoCAiLmlmICIgI2hh c19tc2cKPiA+ID4gPiAiXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ ID4gPiA+IC3CoMKgwqDCoMKgwqDCoMKgICJcdC5hc2NpeiAiICNtc2cKPiA+ID4gPiAiXG4iwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ID4gPiAtwqDCoMKgwqDCoMKgwqDC oAo+ID4gPiA+ICIuZW5kaWZcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgCj4gPiA+ID4gwqDCoMKgCj4gPiA+ID4gXAo+ID4gPiA+IC3CoMKgwqDCoMKg wqDCoMKgCj4gPiA+ID4gIi5wb3BzZWN0aW9uXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgCj4gPiA+ID4gwqDCoMKgCj4gPiA+ID4gXAo+ID4gPiA+IC3CoMKgwqDCoMKg wqDCoMKgICIucHVzaHNlY3Rpb24gLmJ1Z19mcmFtZXMuIiBfX3N0cmluZ2lmeSh0eXBlKSAiLAo+ ID4gPiA+IFwiYVwiLAo+ID4gPiA+ICVwcm9nYml0c1xuIlwKPiA+ID4gPiAtwqDCoMKgwqDCoMKg wqDCoAo+ID4gPiA+ICI0OlxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gPiA+IMKgwqDCoAo+ID4gPiA+IFwKPiA+ID4gPiAtwqDC oMKgwqDCoMKgwqDCoCAiLnAyYWxpZ24KPiA+ID4gPiAyXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoMKgICIu bG9uZyAoMWIgLQo+ID4gPiA+IDRiKVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgXAo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoMKgICIubG9uZyAoMmIgLQo+ID4gPiA+IDRi KVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gPiA+IC3CoMKg wqDCoMKgwqDCoMKgICIubG9uZyAoM2IgLQo+ID4gPiA+IDRiKVxuIsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoMKgICIuaHdvcmQg IiBfX3N0cmluZ2lmeShsaW5lKSAiLAo+ID4gPiA+IDBcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiA+ID4gLcKgwqDC oMKgwqDCoMKgwqAKPiA+ID4gPiAiLnBvcHNlY3Rpb24iKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAKPiA+ID4gPiDCoMKgwqAKPiA+ID4gPiBcCj4gPiA+ID4gLX0gd2hp bGUgKDApCj4gPiA+ID4gLQo+ID4gPiA+IC0vKgo+ID4gPiA+IC0gKiBHQ0Mgd2lsbCBub3QgYWxs b3cgdG8gdXNlICJpIsKgIHdoZW4gUElFIGlzIGVuYWJsZWQgKFhlbgo+ID4gPiA+IGRvZXNuJ3QK PiA+ID4gPiBzZXQgdGhlCj4gPiA+ID4gLSAqIGZsYWcgYnV0IGluc3RlYWQgcmVseSBvbiB0aGUg ZGVmYXVsdCB2YWx1ZSBmcm9tIHRoZQo+ID4gPiA+IGNvbXBpbGVyKS4KPiA+ID4gPiBTbyB0aGUK PiA+ID4gPiAtICogZWFzaWVzdCB3YXkgdG8gaW1wbGVtZW50IHJ1bl9pbl9leGNlcHRpb25faGFu ZGxlcigpIGlzIHRvCj4gPiA+ID4gcGFzcwo+ID4gPiA+IHRoZSB0bwo+ID4gPiA+IC0gKiBiZSBj YWxsZWQgZnVuY3Rpb24gaW4gYSBmaXhlZCByZWdpc3Rlci4KPiA+ID4gPiAtICovCj4gPiA+ID4g LSNkZWZpbmXCoCBydW5faW5fZXhjZXB0aW9uX2hhbmRsZXIoZm4pIGRvCj4gPiA+ID4ge8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBcCj4gPiA+ID4gLcKgwqDCoCBhc20gKCJtb3YgIiBfX3N0cmluZ2lmeShCVUdfRk5fUkVH KSAiLAo+ID4gPiA+ICUwXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIFwKPiA+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoAo+ID4gPiA+ICIxOiJC VUdfSU5TVFIiXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+ID4gPiDC oMKgwqAKPiA+ID4gPiBcCj4gPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqAgIi5wdXNoc2VjdGlvbiAu YnVnX2ZyYW1lcy4iCj4gPiA+ID4gX19zdHJpbmdpZnkoQlVHRlJBTUVfcnVuX2ZuKQo+ID4gPiA+ ICIsIsKgwqDCoMKgwqDCoCBcCj4gPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqAgIsKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBcImFcIiwKPiA+ID4gPiAlJXByb2diaXRzXG4iwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiA+ ID4gLcKgwqDCoMKgwqDCoMKgwqAKPiA+ID4gPiAiMjpcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+ID4gPiDCoMKgwqAKPiA+ID4g PiBcCj4gPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqAgIi5wMmFsaWduCj4gPiA+ID4gMlxuIsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ID4gPiAtwqDC oMKgwqDCoMKgwqDCoCAiLmxvbmcgKDFiIC0KPiA+ID4gPiAyYilcbiLCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoCAiLmxvbmcg MCwgMCwKPiA+ID4gPiAwXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgXAo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoMKgICIucG9wc2VjdGlvbiIgOjogInIiIChmbikg OiBfX3N0cmluZ2lmeShCVUdfRk5fUkVHKQo+ID4gPiA+ICk7wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ID4gPiAtfSB3aGlsZSAoMCkKPiA+ID4gPiAtCj4gPiA+ID4gLSNkZWZpbmUgV0FS TigpIEJVR19GUkFNRShCVUdGUkFNRV93YXJuLCBfX0xJTkVfXywgX19GSUxFX18sIDAsCj4gPiA+ ID4gIiIpCj4gPiA+ID4gLQo+ID4gPiA+IC0jZGVmaW5lIEJVRygpIGRvCj4gPiA+ID4ge8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiA+ID4gLcKgwqDCoCBCVUdfRlJBTUUo QlVHRlJBTUVfYnVnLMKgIF9fTElORV9fLCBfX0ZJTEVfXywgMCwKPiA+ID4gPiAiIik7wqDCoMKg wqDCoMKgwqAgXAo+ID4gPiA+IC3CoMKgwqAKPiA+ID4gPiB1bnJlYWNoYWJsZSgpO8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiA+ID4gLX0gd2hpbGUgKDApCj4gPiA+ID4g LQo+ID4gPiA+IC0jZGVmaW5lIGFzc2VydF9mYWlsZWQobXNnKSBkbwo+ID4gPiA+IHvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IFwKPiA+ID4gPiAtwqDCoMKgIEJVR19GUkFNRShCVUdGUkFNRV9hc3NlcnQsIF9fTElORV9fLCBf X0ZJTEVfXywgMSwKPiA+ID4gPiBtc2cpO8KgwqDCoMKgIFwKPiA+ID4gPiAtwqDCoMKgCj4gPiA+ ID4gdW5yZWFjaGFibGUoKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4g PiA+IC19IHdoaWxlICgwKQo+ID4gPiA+ICsjZGVmaW5lIEJVR19BU01fQ09OU1TCoMKgICJjIgo+ ID4gPiAKPiA+ID4gLi4uIHlvdSBzaG91bGQgZXhwbGFpbiBpbiB0aGUgY29tbWl0IG1lc3NhZ2Ug d2h5IHRoaXMgaXMgbmVlZGVkCj4gPiA+IGFuZAo+ID4gPiB0aGUgCj4gPiA+IHByb2JsZW0gZGVz Y3JpYmVkIGFib3ZlIGlzIG5vdCBhIHByb2JsZW0gYW55bW9yZS4KPiA+ID4gCj4gPiA+IEZvciBp bnN0YW5jZSwgSSBtYW5hZ2VkIHRvIGJ1aWxkIGl0IHdpdGhvdXQgJ2MnIG9uIGFybTY0IFsxXS4g QnV0Cj4gPiA+IGl0IAo+ID4gPiBkb2VzIGJyZWFrIG9uIGFybTMyIFsyXS4gSSBrbm93IHRoYXQg QXJtIGlzIGFsc28gd2hlcmUgJyVjJyB3YXMKPiA+ID4gYW4KPiA+ID4gaXNzdWUuCj4gPiA+IAo+ ID4gPiBTa2ltbWluZyB0aHJvdWdoIGxpbnV4LCB0aGUgcmVhc29uIHNlZW1zIHRvIGJlIHRoYXQg R0NDIG1heSBhZGQKPiA+ID4gJyMnCj4gPiA+IHdoZW4gCj4gPiA+IGl0IHNob3VsZCBub3QuIFRo YXQgc2FpZCwgSSBoYXZlbid0IGxvb2sgYXQgdGhlIGltcGFjdCBvbiB0aGUKPiA+ID4gZ2VuZXJp Ywo+ID4gPiBpbXBsZW1lbnRhdGlvbi4gTmVpdGhlciBJIGxvb2tlZCBhdCB3aGljaCB2ZXJzaW9u IG1heSBiZSBhZmZlY3RlZAo+ID4gPiAodGhlIAo+ID4gPiBvcmlnaW5hbCBtZXNzYWdlIHdhcyBm cm9tIDIwMTEpLgo+ID4gWW91IGFyZSByaWdodCB0aGF0IHNvbWUgY29tcGlsZXJzIGFkZCAnIycg d2hlbiBpdCBzaG91bGRuJ3QuIFRoZQo+ID4gc2FtZQo+ID4gdGhpbmcgaGFwcGVucyB3aXRoIFJJ U0MtVi4KPiAKPiBSSVNDLVYgZG9lc24ndCBrbm93IG9mIGEgJyMnIHByZWZpeCwgZG9lcyBpdD8g JyMnIGlzIGEgY29tbWVudAo+IGNoYXJhY3Rlcgo+IHRoZXJlIGFmYWlrLCBsaWtlIGZvciBtYW55 IG90aGVyIGFyY2hpdGVjdHVyZXMuCkl0IGRvZXNuJ3QgYW5kIGZvciBSSVNDLVYgaXQncyBhIGNv bW1lbnQgY2hhcmFjdGVyLgoKYWZhaWsgJyVjJyBpcyBuZWVkZWQgdG8gc2tpcCBwcmVmaXgoJ3Np Z24nICkgKCMgb3IgJCAoIGluIGNhc2Ugb2YKeDg2KSkuCgpJIG1lYW4gdGhhdCBSSVNDLVYgZG9l c24ndCBwdXQgYW55dGhpbmcgYmVmb3JlIGltbWVkaWF0ZSBzbyB0aGVyZSBpcyBubwpuZWVkIHRv IHVzZSAlYyBhcyB3ZSBkb24ndCBuZWVkIHRvIHNraXAgcHJlZml4LydzaWduJyBiZWZvcmUgaW1t ZWRpYXRlCmJ1dCBpZiBzdGFydCB0byB1c2UgJyVjJyBpdCB3aWxsIGNhdXNlIGFuIGNvbXBpbGVy IGlzc3VlLgoKfiBPbGVrc2lpCg== From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:10:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:10:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517683.803390 (Exim 4.92) (envelope-from ) id 1pjcfx-0005OL-Oj; Tue, 04 Apr 2023 09:10:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517683.803390; Tue, 04 Apr 2023 09:10:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcfx-0005NU-Lf; Tue, 04 Apr 2023 09:10:01 +0000 Received: by outflank-mailman (input) for mailman id 517683; Tue, 04 Apr 2023 09:10:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcfw-0005IK-7e for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:10:00 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [2a01:111:f400:fe0e::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 778422a5-d2c8-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:09:58 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB9852.eurprd04.prod.outlook.com (2603:10a6:150:117::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 09:09:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 09:09:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 778422a5-d2c8-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRN07gEljZ6tFkm2xgW8JexQfh6/erScfgyrKAbxUeSg+lFIlz6gNPqp3fzoj3uo9Elbr/gyXEj3mHALL9kEgN1Rzgf7ObcqbMMZt85L96lZnQtz+9OT6y9P3oD5GzoWihiX5QUFXcezzD/8Yemm+6wA3cAWhHA9jd5YMjnufAZaop/GGAXOmPRNpquveB3X1NnY4bCSvp6MIfi0hUwCX5+zufYxDzGs/hjU2Aw8+/LNVNHeE1S4CqcPKuaa7sCe1l9vZJrOLlupHlfRFubdFjbDmMi6yRfDO5ulZe+Z4N5sF9j3wFyNzvuCgQa0+z5SH+iacpg5zfzK3PqJIBxrxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t1Be+8SKWFkGjv1O8hnhZzzzbBtxIIpMpvWMe0CFsrA=; b=TaEVGTN2bzVTPEfp1TmP5P886/nYF1Lw3W1IyyuLYl+Y76K5LHN/GnfQcb3zV97SOlwyB+C3/upAk8DiOy0KhmVzp5PyqFI+Wt9j8gSja6jRL+2KjcJIfdqIMG/qeocEOOz3mMx5fa2LBFdfy+0jruAf5uXG1kyfZzYeX2J6ZxM9WciCntwLeD4tdVio3tJzFbQC+KUwB3SCf7Ped9iyyVV3N0HfEOzirmdLIqovoKd8f5lOCvrBpsTJ1TPDMLH+Xn2wF+g8n3rFqVrjq6gHyZW+TtAqC5S1dlRzzFIWGugKu5/iHIq63FEWoxbm2UwEmzF29ehUdD+4skcnipox/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t1Be+8SKWFkGjv1O8hnhZzzzbBtxIIpMpvWMe0CFsrA=; b=O7LQHCWoscDHDcWfIxBiv59wntLBoUx3AbXlXhJ8NTfCP9zBPdVjrMU3YUd63mIjrcYXC9RgEa3iaUGx2Br6A6ABpx/uS7WrJNO6ruf+huXSxVBXpzf9qF6y8aI+CY/rTTS24RgikEY946DpsBuqUqPYUorVz9zJLMAYp6eNVN3Lbx04CfWVkexa4MGgK9bMB6GaPTd8yDcnJ5oCibT2KNYF9tKQX7fH+Yn99shS+faO0zuVWO2qtvVW8+VgN5ya/6ooUAutquM17YjSmrZCrWxRCg/cqUEeCjrzLWl97kLwjDVbFzjSGXqWt6zKoA/qkKhmXZnkTBTEB7Ra20aZiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <358e9788-b930-5c51-1e89-232be43f83e5@suse.com> Date: Tue, 4 Apr 2023 11:09:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/2] xen: update CONFIG_DEBUG_INFO help text Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-3-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230403162823.30681-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0065.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB9852:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f60c38f-c882-4ace-cb2e-08db34ec5926 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bNGVfm1DEgbv6LJ6mrtvh5NIHL93bzS4wfnz/5POJskHOhYnRuFv0OXETJbEmpQL9d7EPu114z06cOzKmnJVLIlIgLce+p5njr//coY5ACMve/YGIhlAPt12B02zZ/28crR4WMB1suBVGXSLJVN3QOZmfyPeYFNw5wqxuh5HExcKrQ1DehcI93R2YoIFU6xwrnRV4DXidYm6OUOl5WSoP4EzhTBYTZJJ6lmRwiR46gETjPYWJIVqw/RQ8v41NyTj6OJeFOA/klZJ5drZmm52ASYOyKS9l6wmGym03kPVfPglW2zHzBF0/6MfqGPER3xDjw0My32+mRk/Htd5wTWbhayUe2GJ3PmLngO+CEGFueVVRk/2Dirq+kbTMyYt8M1uiusWi35esr2lPvcVl8BefIu+7neiNHAPa7E4nWcC354b7bnXuF22T0P1l8VSkzFjGzEOeaVaRmgxbDgnWbdwpGO+l7K4ck3Ul6IUfW9D8L3SeSAgg3yeKfWYVpbLSNq4sHDH/ScM+qnCu55OYIlbPTMrH92cGPDCH7Qt7Ft+5mRGOu4i8QrdvthzsH0M0nzsU4NEPTHNpvtr9rHlEqpifxOv78J0PutqDnd5hQ0CAfHbkfyf+TyP3X4I9pz/z+cecbYY5DPC1to/97NJgyg8IA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(376002)(39860400002)(346002)(396003)(451199021)(6506007)(186003)(53546011)(83380400001)(26005)(2616005)(8676002)(54906003)(6636002)(66946007)(41300700001)(37006003)(316002)(4326008)(66556008)(6666004)(6486002)(38100700002)(66476007)(2906002)(36756003)(478600001)(86362001)(6862004)(31696002)(8936002)(5660300002)(6512007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VURNVGZ1L0w0TmV5aGxKKzlRazN3QmRVM2w1SzUyU0FRWHNCb3FqNXl6eGY5?= =?utf-8?B?UHJrNlJEMldoRjR1T2dHS0x5Lzh6RmJycVdvd0YyYVAvT3dZcU1INHFvbXNt?= =?utf-8?B?ZUFMaGF4TzlQV3RWUWlFQXVWeStqeU9sQ0NxbXEyRzczb1lSODE1bG9WM09k?= =?utf-8?B?YVRVMEZUTzRQUk1CMnAwY3E1YUpGeFhZV1VFWUpiSEtlck9NcitJYWNjNTlr?= =?utf-8?B?U1VCdzc3eHRKaVBiQlVLcENNcm1qSWl2Q2ttMlRUS2dxYnBpblhZN0o0TU9q?= =?utf-8?B?WXFBdWJyTWRSMUhCTlRaY0JJMkpRbnFJOHMwQXMyampSekVkYjZrd1RYSExD?= =?utf-8?B?aFVkSk1yZktxOXY0SDNYMHVaZTJVMW9SVS9xY0l6M0JMSHlnZjRhdVFzcjlE?= =?utf-8?B?KzEyME1JR292bVJ4UlRFbVlkZmNGQW9aYmdsYnNCYWU3ek9LZXMwRnJYaXpH?= =?utf-8?B?NnZhSC96THRub2ZVRG1WV1MzUmQzZUNUMm9PZGprUUtlbTBVMktFSnkzT0Vr?= =?utf-8?B?c3p4Nk55Q0d3QkYyVHFIRFRubXQ0NVpHRmVyZ3NPTTV6RUltTmN4VEh6UlNT?= =?utf-8?B?VXVHdFQvTnFRMUV4WDlEWk92U0phanFka3ZZQUJDamlzVzBLNllNdFh5SERC?= =?utf-8?B?STREOExGbkpxSTBhdUlBRkVhcVh6eDN5d013bDBsVGVwaFJDZFJTWStHNFdI?= =?utf-8?B?NXNuMjArZTRueGxhazVtUlVCaHEzTjg3dG0vRTlZeFRVWDdweWQzM1Fzbm93?= =?utf-8?B?UGNGMXU4YVJMUWdSdjJFZS9rdmJUc3IwVEEzeFdHanBnVFFpSTJWSEE1WTdJ?= =?utf-8?B?OWlVcWMxaEVPRWY2b1h5TThGWXFYVXBsdkZZTWpZZEpKTFY2V0hrS1lpYm10?= =?utf-8?B?ejF2Z251Sy9xLzNmdFNtODhneHFlczRtQUV3eU5jRGpGVVV4RVU3TDJHZTc0?= =?utf-8?B?ODVJOXZSZzY2VEVGcy9RYld5OGtvMW5QMUc1WXB5aXIzWU5NTmhqZDRFcm5u?= =?utf-8?B?TTNFMHI5NjY4bVlpV01jVHFpMHhHdTFydFlJdUIxeWQ3ZS9Hc0VpQXRBUUo3?= =?utf-8?B?THQ5QTdxZnFvQ3JoQTBQZjBrUDlnZVBtTEUvc3MvL3pSR0Vwdm5MQVFhUDFw?= =?utf-8?B?L1hDQ2lKVnZzWDBHMjIyS3NMbzdwKy9iVGorQS8yMW5IL0U1WjB3bE1CT0lG?= =?utf-8?B?dEVPSFhJUFFyb0xSczFWYnkwSlJ2WWwzSXRBajNsYWR6OVJGZXhPeWlnbTZu?= =?utf-8?B?Y2tZS21TazVzV1RCbVQweU1WbUZpaWVZN2pLQVZpc21SMzJhQzZIK09LR1hM?= =?utf-8?B?bHMwOCtyMzg4Mm82NXd0djd2dVRvVXdIVjM0UVlQdG9jc1AybFRGWHNMRjFE?= =?utf-8?B?VEtGMW5LcisvM2k2U054c3JOdTJLVXl2TDlZLzFiamJXdUlGaXBKN0ZZZzZt?= =?utf-8?B?R09tMlI3SmJuLzVaclNuaFd4UVR5Y01xR2phVjMybm8vVmM0WXhtbCt5OXQ5?= =?utf-8?B?Mnp1TERuYzV5c0Z4N2lXdGJsTXYxaUNKdm53b2hGS25ubnVERDVUa1VhOEV1?= =?utf-8?B?cE1ncHpad2hYdEJ0NmdCVkREaWg1RU11RDBGanFwMkNaQ1d1aG14cW5tc2tZ?= =?utf-8?B?M2IycVRRSXRwUmpXU1kvaU51anRZYW9vSGMxblFiMjFjTWJkS2MxSzluUm1w?= =?utf-8?B?TmhKWGVaYk1jRkZYY2d0d3RwN05xY2NYbDkyTk9PSzA0NzhrbDZPZEVFTGZt?= =?utf-8?B?T2tyZ1hOTlI2WFduOXFIcGprVTRPVG1LY3oxd095YTA2SldWK1JkQUVkS0li?= =?utf-8?B?RHA2S0JsUUE5OFY4TW91LzJBTVB4S0FBNVFwcWwyaEQvc1pyai80K3lwYU5J?= =?utf-8?B?eXJuUkpBUGRGK01Ocjg0VGpUVjRET00xdnVXRHJBbUk0MDUvc3dweUM4Mks1?= =?utf-8?B?UHhmVE5DMys4dHNYWUhKTTBCb3hZMWpqR0V6ZzR2WWlaQVl2UE5mYitMZ1NE?= =?utf-8?B?M2NNZEs0elFsS1hJVUUxTnp0QzlLZC9oejNLZkoyRGtBMW5DQVV4bGhMdnFF?= =?utf-8?B?SDBGV0FkaDZtQWNaN29rNnlucHNEc0NYWlJacTlTRTNWZ09ubkhERzVrK0d0?= =?utf-8?Q?GfWahpXOyFvgpTycaIxhsdDol?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f60c38f-c882-4ace-cb2e-08db34ec5926 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 09:09:51.7507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0QibiVXN6MeP/giY7oyX+opy/bECYf+ZnpTjPXwwHJ1Zoo7SEypphMT1WeRjQ6iriE2MU+T7PaqRNGAhTHxSlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9852 On 03.04.2023 18:28, Juergen Gross wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -15,8 +15,14 @@ config DEBUG_INFO > bool "Compile Xen with debug info" > default DEBUG > help > - If you say Y here the resulting Xen will include debugging info > - resulting in a larger binary image. > + Say Y here if you want to build Xen with debug information. This > + information is needed e.g. for doing crash dump analysis of the > + hypervisor via the "crash" tool. > + Saying Y will increase the size of the xen-syms and xen.efi > + binaries. In case the space on the EFI boot partition is rather > + limited, you may want to make use of the INSTALL_EFI_STRIP make > + variable when building the hypervisor, in order to strip xen.efi > + before installing it to the EFI partition. Hmm, INSTALL_EFI_STRIP is only a courtesy to developers wanting to install xen.efi directly into the EFI partition. It wouldn't affect the normal flow, and hence I think this wants expressing here such that both kinds of people have at least a hint what they need to do. I.e. in the normal case they'd need to adjust the way xen.efi is "propagated" from its installed location onto the EFI partition, to do the desired stripping at that time. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:17:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:17:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517687.803400 (Exim 4.92) (envelope-from ) id 1pjcmg-0006nO-Ff; Tue, 04 Apr 2023 09:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517687.803400; Tue, 04 Apr 2023 09:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcmg-0006nH-Ci; Tue, 04 Apr 2023 09:16:58 +0000 Received: by outflank-mailman (input) for mailman id 517687; Tue, 04 Apr 2023 09:16:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcmf-0006nB-0w for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:16:57 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 709b7c78-d2c9-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:16:54 +0200 (CEST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-RJP9IdugPhGMvS-nWILlMw-1; Tue, 04 Apr 2023 05:16:50 -0400 Received: by mail-wm1-f71.google.com with SMTP id d11-20020a05600c34cb00b003ee89ce8cc3so15786764wmq.7 for ; Tue, 04 Apr 2023 02:16:50 -0700 (PDT) Received: from redhat.com ([47.58.164.113]) by smtp.gmail.com with ESMTPSA id s17-20020a05600c45d100b003ed51cdb94csm21819628wmo.26.2023.04.04.02.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 02:16:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 709b7c78-d2c9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680599813; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=BSBmdTbfTkUl7Ea3VQh27DTaOioxkwyVdy28bzui4ZE=; b=hVh2hptaQSOC0hSoQw24A2g80Up/KyqVThSrXp2+tZG8e/YzKeUGj6mE8IA4xFLw6bVs3G 83zsRHUP29HxSkk4RksOCOu5aE/Yio5NkGPqsbNqxR2VAkrKeH4Pj0tG0ksQ9wWWF7nppi +hZQ4LJdPPG07SFfv6ecOGRox3Vwqws= X-MC-Unique: RJP9IdugPhGMvS-nWILlMw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680599809; h=mime-version:message-id:date:reply-to:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BSBmdTbfTkUl7Ea3VQh27DTaOioxkwyVdy28bzui4ZE=; b=EA+4yCAkZ9kzkYE7qwDl0Rc1teg1CW2nk1WLN1ZMeENwbEFvhRB1bb1/XZwzvbknOo v2t+8YZPLSKIoLvZgelb06mzYowmhcbBnameUo3XZYJAwyByn8pyRRmOo/JHEa0UefCY LnonYyRAF0zNiTpoDrwzq+tk+n+CRkMzPsITrVFgRP7tnhzms9nn98ZCoSydV1FMF4QM LSNw77ancK/ofOWlf3By15snLmUhVWeE6KawoFetKm99XNr1P5CNImoVZGOEt1c7OTBp WIUMfRVqhojceu7oRH1q7YIy3L1Fvw1EPPUHhn52pmmegGiKC2oPOGKTAQ+l2+pCMas0 5Z/A== X-Gm-Message-State: AAQBX9d5mVWHvwhj45mhvVsD8ug2vvyV6GAxiYr/QcXkBjSE+jpQWFHq MjIb7wmn1NT8d2gy8nxoeo+a2HGKAviH6C6jYMJNsuE652L6CIhgLR0f306Vw9dro+ycyg3CJzJ v7njXO/k1ELZlClqdtqveSVqA7oU= X-Received: by 2002:a05:6000:508:b0:2d7:89ce:8319 with SMTP id a8-20020a056000050800b002d789ce8319mr1013750wrf.27.1680599809116; Tue, 04 Apr 2023 02:16:49 -0700 (PDT) X-Google-Smtp-Source: AKy350bBjCYY8Gmu90141dU4yV/FMGGIfHstBOuovWY7hslWLD6VBET6tgmgZ4mx0XgXOelUMo6HKg== X-Received: by 2002:a05:6000:508:b0:2d7:89ce:8319 with SMTP id a8-20020a056000050800b002d789ce8319mr1013723wrf.27.1680599808769; Tue, 04 Apr 2023 02:16:48 -0700 (PDT) From: Juan Quintela To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paolo Bonzini , Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , , Eduardo Habkost , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Anthony Perard Subject: Re: [PATCH 13/13] aio: remove aio_disable_external() API In-Reply-To: <20230403183004.347205-14-stefanha@redhat.com> (Stefan Hajnoczi's message of "Mon, 3 Apr 2023 14:30:04 -0400") References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-14-stefanha@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Reply-To: quintela@redhat.com Date: Tue, 04 Apr 2023 11:16:46 +0200 Message-ID: <877cusroqp.fsf@secure.mitica> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Stefan Hajnoczi wrote: > All callers now pass is_external=false to aio_set_fd_handler() and > aio_set_event_notifier(). The aio_disable_external() API that > temporarily disables fd handlers that were registered is_external=true > is therefore dead code. > > Remove aio_disable_external(), aio_enable_external(), and the > is_external arguments to aio_set_fd_handler() and > aio_set_event_notifier(). > > The entire test-fdmon-epoll test is removed because its sole purpose was > testing aio_disable_external(). > > Parts of this patch were generated using the following coccinelle > (https://coccinelle.lip6.fr/) semantic patch: > > @@ > expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; > @@ > - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) > + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) > > @@ > expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; > @@ > - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) > + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) > > Signed-off-by: Stefan Hajnoczi [....] > diff --git a/migration/rdma.c b/migration/rdma.c > index df646be35e..aee41ca43e 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -3104,15 +3104,15 @@ static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc, > { > QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc); > if (io_read) { > - aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, > - false, io_read, io_write, NULL, NULL, opaque); > - aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, > - false, io_read, io_write, NULL, NULL, opaque); > + aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, io_read, > + io_write, NULL, NULL, opaque); > + aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, io_read, > + io_write, NULL, NULL, opaque); > } else { > - aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, > - false, io_read, io_write, NULL, NULL, opaque); > - aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, > - false, io_read, io_write, NULL, NULL, opaque); > + aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, io_read, > + io_write, NULL, NULL, opaque); > + aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, io_read, > + io_write, NULL, NULL, opaque); > } > } Reviewed-by: Juan Quintela For the migration bits. I don't even want to know why the RDMA code uses a low level block layer API. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:19:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:19:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517692.803410 (Exim 4.92) (envelope-from ) id 1pjcot-0007QL-0Z; Tue, 04 Apr 2023 09:19:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517692.803410; Tue, 04 Apr 2023 09:19:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcos-0007QE-TQ; Tue, 04 Apr 2023 09:19:14 +0000 Received: by outflank-mailman (input) for mailman id 517692; Tue, 04 Apr 2023 09:19:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcor-0007Q6-PJ for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:19:13 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20629.outbound.protection.outlook.com [2a01:111:f400:fe1a::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c35be60a-d2c9-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:19:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9915.eurprd04.prod.outlook.com (2603:10a6:10:4ec::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Tue, 4 Apr 2023 09:19:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 09:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c35be60a-d2c9-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXjcnHJV9t+ebL3yCyqlnnc4xs4LSzhBG1Zpqfj77IpBYLumNKSlxc41/z9rBXwttrZZcZ2/ULA3oaBKVTWHh6045oGFdEBxxC5azCYLbC8MIu+Kp1R41cE7cBQi/c+b1N4Lx6WIQV/D+XvvSqiugJP/qUJmsLkhPlOuKlHYzKAed2spZAcok49NpzowxO6NX62Q5d7o+wZFiE6bp5rcRY+xYL7k6KMf9x8Sch+pU4G4smx5DI5aPJDk6ZVjk1X5Pc0e9e+fyZuc7r9Oq+z+t+8Hz0SG3HPECNpmukyeFK3d5pq/ebxIoDnVRu0zdN6d48dCZfj3WMn3muknoYMzKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7N904AxklSbnMiROFbdWJfhWDMU/a+PNtwY8Ooo9QI=; b=KbUUh1GlFBg2IcBus5lH0FsROpj0cozNVxCc8zXm1upBnO+msKgoiVR1qaf4gvoXE+n5/a7ASNGqWS+SpeuooV0PSJjEWEKAvq04uFXFYXv2wWwc15pV9LfkeJl1WrGXNoKZ6XVZsSJXlbCjoNzgRtPmT2kXNQyalh/nmGqVNokNdBerSpBmlmhtJzpLETCX9rLAvZ9OyI8cPsl5pu84Vzn7t/XyzNA2x453Ava+/H0ZtsNBf1bBl6Mt9OF1ph6nDdzhJu7Cef57c85tTzp6s8z31PurCSLjhjWFIR29kWug6FWQokKj5kwws2LalG+VQQY2aNx5yto9mEjj+S3TZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/7N904AxklSbnMiROFbdWJfhWDMU/a+PNtwY8Ooo9QI=; b=gq3VuFEVaKpovtmJTLz+v4FBDbEcZHYDVK1kj/ChC8bBeNwf0o8h98rZCU68lIVD7kj1la8WN1tUpb/ZrnNtNGnIPR0BMew7JnTfhjNy5itjBMtqfOv+LPVd1D8OlO2ejqQ2niQ6/24/bSyrNkM68Zd4JqVn0hntr4jd8wFwASn6jtW/gUxFa3wTX7lFp/E4+LTuNFBKz+NU7LMZF1gtgaJfpzxZ9vQFEci5V/iQx8FULPpyQPb/8jwgYlJf6ERk3raYERTuPgs8cRSS4QzpCKZR6ZJ+5v/frcApd64MD8xmBKpEztGTsPEOuzUIQsNrWZQKJ62ENGRLLt1E2UnWwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 11:19:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 From: Jan Beulich Subject: [PATCH v2] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9915:EE_ X-MS-Office365-Filtering-Correlation-Id: 377ba6c8-602c-49ac-00ba-08db34eda5c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JCDSsrggbx3+5PNTDltoIx1wBJfxgNSyv5T55+HkKh4uSkIH/jLUmpV4W3wRpjsUG4CCq/gtamMiVJFouVUnE8FUV6JKeqCSxQs00jlJtzor00P7WZv2eejb4hsubN5Heo/NRo009VmiYgcD9YBU1UbvE34+MRn3M3gHQKLoQl+FVuacrhhLzhrfL4u2uatAXEbWmBDDZRdcrT6QnuFx/9qpTbsrBjDBMu64cBEPnXFwevF04El8kV++9ZgqWdWN0oUJteNzlWhF9KlHIUPz7E1q9rr88Fch0CP8uhmdmK4uukW0fGtY3a41Fwfk4H+whOuVV5ZkXSQi2i7D/4AQb4JJPZ4bG2feibwPwS3WBv+qhgCzmwLdH3TiQhXkP7hCLuL8NeP1qKnSS7x+Vexi7MW6JQM9cbs7hSWE2IIni6Zd8jCbCnTO/rhg6HlK3UI6DZHsttO9JRe888Icp3sXBT0+odL5WN8nj+5dPW+1hlOHUPAUgCA12GfMnXtHOK1JTzUdRzWx6HSZOubAz4QD0xEuya8GIpr5MJONSNTpmNPG3izV2XgTvei87ZFe9c5T39rYWtQDB1b3zphNWdy+xi70CVLN2a02buLvjbZRbIToCeh584t3EDQshfqnozbjbr+s9qdWESNM2gOnBAL7CQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(346002)(366004)(376002)(451199021)(38100700002)(8676002)(66476007)(66556008)(66946007)(5660300002)(8936002)(41300700001)(316002)(31686004)(6916009)(4326008)(478600001)(2906002)(31696002)(54906003)(83380400001)(86362001)(186003)(36756003)(2616005)(6486002)(6512007)(26005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3Fkak81VzRiYktxQUx1LzdUeHM2S0Z4aWVhcmFvUGRZNjBGWDVzUTlpNVAx?= =?utf-8?B?Mkh1S3F1RlNvb0J3ditsRk9qLzJmNk9lVUxCUHhQQnp0dTNyZ1FVdkhmU2RE?= =?utf-8?B?TnBycXJGcVN0ZjJDNXcxUmRQZlg5VXRmRjMyZzdCMENBMlJoT0lxbVdzV3RD?= =?utf-8?B?enNUQi9yQVFNZGtnRnhCbWVaNXBCZ3RYSzRlUkFFbXRVMDRuQ2NscEZtRElP?= =?utf-8?B?VEZPNXhjWVpUeU82QUU0VHBQZG54WlRmR0x0TEhaNkRoQ2JWc1VLVVNPYXBl?= =?utf-8?B?UUpFUTlDZWtqeUxPbzVwdDV6aXlYVTM2SFRWenJGdjRVcGpVN2hrWXlaUWNh?= =?utf-8?B?bDNZMjlXcmFEOTFsWDdlV2c2SkVQYmVoOVNGcG9CU2IvcGNUVTh3bnQzLzJE?= =?utf-8?B?aW0zaWpaWVNGcGlSZmFRREIvYjFMaTBBNkJvTkJLeXlLQ2FsTXk0STgwb1U0?= =?utf-8?B?SFgyMVc1UTdpTm93TU5leDZQTUcwMXpGdEpOZEhEaXAveGY3Z3VkSzlFNFRR?= =?utf-8?B?QVMvWTRuK3lvRDNHcm9MQkJXUGpyUjY0R29QLzU3VFM0dUhDb3JiMTlxTFVJ?= =?utf-8?B?aEFyTUpOcFdpOFJnZFRHNW1aZkk2TFY5eEpNY3MveFpWS3dUSUJoNm9nK2Rk?= =?utf-8?B?UDM4WDRYOWhXR0hUWWFFcHAyRmV1ZlQvQWZwZ3IxN252bU5pUm5SSjlpRnhU?= =?utf-8?B?S1ZSM3UyeGh6VGtDSDZFZ2J3ZU9Md3d6UHRhWWMzZjgvSzhZYm9Xelo3WGlk?= =?utf-8?B?bWdWNHFJWnJocmdzd1NZYm50OHNuZFJ1Z1lyRDNOL1c3NUxPS1pLbWprTFNY?= =?utf-8?B?dCtraWl6U3J3ODlLQmhwWnppSXl0b04rMFoyWjlUQmQxWklDQlRYb2dPTFlh?= =?utf-8?B?cHpUK1NjeWFiSU01Uy95ZFBoUDYzZEdoTnhHRHhMWnpvY1hOeEVWUCtsSzlq?= =?utf-8?B?WHJ0TWowMkgveDFqRlRYOE8zZnB4YjdGeHZoKzBzeVIxdGJaVVpLaTd6SUVY?= =?utf-8?B?SnVkT3FqQXh1enJBREtlS2hPUUp3bDlTNXhmclNkekc5bnZMaDY5aEVyZXR5?= =?utf-8?B?K0VCcHBBdGdkZmw1cWpOTUtMbDFtRFhyaTgvcjdlZ2s2bDNpdCtDZ1hFMHNp?= =?utf-8?B?RGlBMVVNRUJ3azAvQWt0dGZCNktRejdwc2hyWmp2NGlKUFYybEJjUHNjWGRn?= =?utf-8?B?U0lkKzhObm01TDh4cFFhTzFFMjQvdmFMMXI1ZnJ3MG1PQzF5U24vWCs3WTRj?= =?utf-8?B?Mkh3V04rblBTWEZ3VWt0MFJBSCtJR3VlUC9IMDVYaTBGNjJHU0dhMXZWMzcw?= =?utf-8?B?aXZpYm9RRjhJeGxyRzlsY28rRnlOYVJEOVVReVdkam9VcXpzNWVkaDQ1cEZJ?= =?utf-8?B?TW5UUFlESUlZTGpFcFN3QWtzcGZFOUNmeE0zYk1VdWpDSTYrYXBwR3BwS3FL?= =?utf-8?B?OXd1amgzTWNDSDFvWWZscTJTR3hCZERaeWVHSDRGdURrMGFvWXlTTHExcTMw?= =?utf-8?B?c0gvNEJ4U0xQQjZ1cFNwbjE5V3R1cjZvdTAzTjNWZnVERFY5ekhjYWpLNXNC?= =?utf-8?B?c0dDclkvdG5pcmJQeXU0SVZudkFLT0U0RUJlU3J3cFNkTlUvc3pzb29zSzRC?= =?utf-8?B?RG9JaGlqYVRxV1l5cTlMa09RZE5aejVidXVmRnlscGVBYllOTk1UTWttSmhx?= =?utf-8?B?R1d5UEpDWVBBM0pUaHdBMlJvcE5wWlducVhCeHgvaXBFNWZ6T0k5TjlGTkVC?= =?utf-8?B?WmZMaVpiK3FUd0VKaTB0alpxeE5qdWJWNzNyWFhGeGVxbkRjL0g2bmJaVitJ?= =?utf-8?B?Zkd2aDVwMXV6Qlc0dU03WWg1bjRHK2lPZTQ3L1lYUHV4d0ZobldCUDhCN3Nw?= =?utf-8?B?V0FpcCsvNFRRTHE1Y2ZadTVpYW0vRmNjOTVkdGJDT3h6L0p5VmJvZVJ0WWY5?= =?utf-8?B?UjhxTVA2SWN1Qy9vTlZxb3JkeGlPSnFDWUNXZnl5Rjd0MXMyeWJjeUdNTGxX?= =?utf-8?B?NVhPZjNtVWZrVmtXSVZJMit0cUFmKzVNVzU5dUpTZ05TSU4rTmp2aDJvM2NX?= =?utf-8?B?bnRUTGdyM1RXZWNpdnhhb0MrQms3c09PQnhsRmlwVnppT3M4bVdUSmlJK1Ny?= =?utf-8?Q?mgCEK8xZxF0gnF6Xz8srBHW6q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 377ba6c8-602c-49ac-00ba-08db34eda5c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 09:19:09.8621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tEidxJEAFU9n8QurnQZpXBuQbrcU2rn6fKoGU2O42ACtUe0gZQRAwZuT+ZL9nSydLI4ZYFhiEXhdCmuxs6cAxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9915 Besides a printk() the main effect is slight corruption of the start info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended up as xen-3.0-x86_64p. Note that no known users exist that would have developed a dependency on the bogus magic string. In particular Linux, NetBSD, and mini-os have been checked. Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") Signed-off-by: Jan Beulich --- RFC: While Linux works fine with the adjustment, I'm not entirely certain of external tools (crash?) having grown a dependency. It may be worth noting that XenoLinux and its forward ports never had this ELF note in 64-bit kernels, so in principle it may be reasonable to expect that no such dependency exists anywhere. Prior to "x86/PV32: restore PAE-extended-CR3 logic" that (meaningless for 64-bit domains) VM-assist could also be engaged, based on the ELF note's value. I expect that change to go in first, at which point the description here is going to be correct (in not mentioning this VM- assist aspect). --- v2: Extend description. --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -459,8 +459,13 @@ int __init dom0_construct_pv(struct doma compat = is_pv_32bit_domain(d); if ( elf_64bit(&elf) && machine == EM_X86_64 ) + { compatible = true; + /* Zap meaningless setting which kernels may carry by mistake. */ + parms.pae = 0; + } + if ( elf_msb(&elf) ) compatible = false; From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:21:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:21:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517698.803420 (Exim 4.92) (envelope-from ) id 1pjcqP-0000Nn-CR; Tue, 04 Apr 2023 09:20:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517698.803420; Tue, 04 Apr 2023 09:20:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcqP-0000Ng-9G; Tue, 04 Apr 2023 09:20:49 +0000 Received: by outflank-mailman (input) for mailman id 517698; Tue, 04 Apr 2023 09:20:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcqO-0000Na-Ht for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:20:48 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0c::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fae3a15c-d2c9-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:20:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8422.eurprd04.prod.outlook.com (2603:10a6:20b:3ea::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 09:20:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 09:20:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fae3a15c-d2c9-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZgDFb4IqiwfLkjEEmwkZ+1ljIk4DDuHVz3oIuLuTMqfbpBYTuRORqo87+SSzSrFmshEsQr6S/+V1siJ0GWhOWJrpv3uZ+JbfEPh8yX1RSVqSOzmeILDLK8gZDKJ9Yvap7MwtF6l6djAmWwmCnF+6vHKrCJ3QySBex7nY9iAK2QaqoZyBz6ERgoRYswfCVdCmRraEWap5C6fhJmnDCOsfE3DBj+cb1Ya9Fq6UHYhV4A3gIU53AQ+iegHf/+0OtAAvb5/zXbDcj9NOnZEIo1Fiz6RawfieAzS/bu9/ZKmvk/ZJOjjm3unV2HvwMvS6Qr6BqVWYXe7V2X6Zm5zO3/Q0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SbtH2o36X0z7MtAmMJTg+4apLZdjst0d0KZ8EsroDUQ=; b=MsKkMCZI4y6TPZj02Zdv6lLEBKO4Ewt+9tL2CJv5exJK9qL+GZlP8OeyfYeUDk99R33XBowojuRPs4AnvjuKzILOr1iiJfQ0OS2fCaVSpzBvTDIojqYTCXR8RyVt/o449PVY0Zf4fs0fOJhWNieMw165DJxPoD1pQ5ACCBVGMnNId8GNzCDzaq8SopYovrb+/jKTCbkjnXkYMmrl634Yv404Ub4xdulXc3yfv58SAuDRq44sXhUfQTmQNBWw05C0ZOYh1CIt6/5Nd8u95PyuBOwmg6GjrGxSW91AZvTBKtu0Vsf+KALUXel4WIHwK0Ovj/YfZYs2NVlGP4197rXSFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SbtH2o36X0z7MtAmMJTg+4apLZdjst0d0KZ8EsroDUQ=; b=v0cSlHWMihQ2ahcbgOv1/1zcFACldyujn7pVwC5UPApOF3AvzywRR1Xl7e8jHsADnc3QZ4mgW2E1RdO0jXBGsvJZo7t1l3xJPmLXR3ToZsg9n12lx/D9ZbX8p+tMgIAHW2vmcDqCqnyFOUBc0OLav9J8alFZ1b5gq0epzGlYsF0UmM+FrDDWL1pdKibXb8wSB1702i7sB/DJMkDluHx3Y0qBpJHp2YgNGzhDRA8K1xnDNYGecb0tDT7gUK2GkiXaTosUylgHl+kwQGGNuYFrboDLzClUB432aaHajzsdETvDtYorenruGHh2sS7DvurLNx6DZijbtD8RqPIxOGFzLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> Date: Tue, 4 Apr 2023 11:20:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 From: Jan Beulich Subject: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8422:EE_ X-MS-Office365-Filtering-Correlation-Id: b91f59e7-56c9-467e-0c21-08db34edde56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xjoLBMIkTSAHNvG456J/d59nZ6a+nevWUuvchG3yBeqRc0TGrXi5mDm7fqYtddG6FejbdCpLg8Nv9mPa9fOIJmyYqem8z802VYELLJR1O1mwPDty+tfgcsDzkEXELn+pmcSfb2kVw4Ggl2QGnVAMH76G4jT38aCRUVr1se8Hd9T/PI0AEZbSZOQ0FwBCwvAapzAxD7pd+FyHDCgX4w4b9GNXAhdvkoowqlHQFdK1HbYTpq54wyt7uMQ3QJ/vXUQnKDl+O6UpEF5ejRHEvl1iXLUbL45cDtJtxZUezuVqEHJFBpNAXrtRXQM+fU6fn2uP1xKG/rY57MCK63rz4/9jU2C7Hm9VpDIesY43XKrcVGfcuKwmBE8es08hwZuoyQrFrEEkF4zUxCBiIe48yzUKh3PN58aR74QNMWvaRbPfe3YV66VThkvQszVrYS66XbISyXF0Xkv6HWJeNQXzjzVAeCgITJdtcfO5jVuLbyLtyPTI0HFriZFxoJ4FkmE0UoCqHSXtg5AfRDkrQeN2HFmnSTq3VftAPJwkwofwRyQiiZoUKI1x5xvkGxdLjQTcrHYUQXuCtF8Rr2NY38bVeq1+kvOY2D0Ag0srVrmLlXpzpOIlv2IC62Ugoueji6BSX6WY5BjtyWgTFBf6rKtgC5ifsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(39860400002)(366004)(346002)(376002)(451199021)(86362001)(31696002)(36756003)(2906002)(31686004)(2616005)(6486002)(83380400001)(186003)(26005)(6506007)(6512007)(8676002)(4326008)(316002)(478600001)(66556008)(66946007)(66476007)(6916009)(41300700001)(38100700002)(5660300002)(54906003)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2FWeGM4THJKdmZPbjFYU1IzTmNZN3lFek5OaXZaMFl0UnBqemFCTzhPUEc5?= =?utf-8?B?bit1eWZ2czg4d0UrVUVFbStQMXJhUWREL0k3cis1d0lCTkZUM1AxbWJLZ0tn?= =?utf-8?B?N0gwNUErWXlaU1JNZTFmaFRwN3JtblVhRDVseFBBTUdRNzBCV2xSUGVDcDlD?= =?utf-8?B?Ny9keE9VcUF0b2VzeDJPSWV2SU5SNXBUQ3RSb3JJTjdOekVxdHE3R3pRZnFj?= =?utf-8?B?Zm8vZ01rNFZmak9tamk3WmNnOUZpSWRjK1pmUjNLZlVVRXI5RXJqQ21TZGpM?= =?utf-8?B?bkN2anZrcFpBaTZBSWtRbm1td3UwVXFiUGxPNmt0SkY4LzhHNlNiaTVublZR?= =?utf-8?B?c1l0a3Q5eEFYY3Ryai9aYzR4UW5ab0Uza1V0RkxYOURVLzlWcW04cFlhOW5J?= =?utf-8?B?b1VTeVVOcDBGNHhVUGlpenp3ZnFSSWg0Sm9JcG5VYUw2VjlBcnhmUEJiZWFV?= =?utf-8?B?ZmxIOVhVRnZOQjRlNjNtMzdIcnQ0UkNadmlUeTl3RzJqYldpWFlYeGZINEtn?= =?utf-8?B?OGlJSW5Sb3IyZTJDMlp5LzlhQjNzdlNLd1ppYnh1WGg1MnhIOFd2dnZsVzdu?= =?utf-8?B?Z040N0Y3U2VZdnhaSVZXT3hGOWdpRVZESXB0czd2TEhrMlBoUHVnM0dFYkRY?= =?utf-8?B?bHBOYXlnM0ZCeHIzdzJOODZ6M3l1dGE0aTdpazc4Z05KMkJkWVM0UmtkSVI4?= =?utf-8?B?RFdPS0ZDRHhQSmh5SWFLUTJmbThsam1JeFFvVFdsbHN2Rk0wRWtRNjhrS3pX?= =?utf-8?B?NmtqUmppRklRR1RmZitNWjZyZjNaRWlaUmthWFdEaE9LK05rUFMvb1h6cjMw?= =?utf-8?B?VUNJWnZJUkZ3aDlHZDlWcmpHdHc5MEVjWm9ydnE2dm04TS9LaWdDbHhmZVZN?= =?utf-8?B?Umt4TDlwaXlDQ2svS0VXdWRsdjdYRHN1OCtqeXVTdU1lbStHTmEwK1FGaS96?= =?utf-8?B?UG5MNTZFZUd3V1pZYy8wWWVSTVVxVnNweFVZK1RndUV4SjZaQ1pxcEJpbEVp?= =?utf-8?B?WXd1UE5neUFWQmxXR2ZwOGswUThvV3JQaSt6ZDNEUE9yQlBDb2dCaU8wL2h3?= =?utf-8?B?MWF4WmVpNUw5SE9DeUE4SmRsM1JEVVUwZzFqcmVqZFd3R1dBbkkxNnl2R0ZQ?= =?utf-8?B?YnI5WTBXYVpkeUduWHE0M3ZoMUgxZVRSWFJ1RTV0Um1Bd0cxZDFnM0xUMUV1?= =?utf-8?B?WWxUM2RWVUlZdzRwYjVJSFp5dEQ1aEpzZnQ3ak9mcTlxTS92enRhQXBOR0o3?= =?utf-8?B?VWQ4aUxxMklTQk9lcHJyc0t0R2tja0dPWnRDaHVWSmNlUnF2QnR1TmRBVkUy?= =?utf-8?B?Ky9ra3ZzUFNsRW9zM2NHUys4VVBad2YxbE40VHc4dU1xbUZiMExGdG1xNTV5?= =?utf-8?B?bmxwTmxSN3dtd1p3cnVaRU9CMFRVNFBwWmUrZ0ZkWXBSMXJ2bFA3UEF1TkJU?= =?utf-8?B?eVgzZlhGN3hxT2FyREVmaCttRU9rNm50RXBzTXkwUWJFZ0k3SmRxZTF0SW5B?= =?utf-8?B?RWpzMkV1bk1XcXNKOThwd3lCSmdJNktXVjdHVVREc01ZOSttYXFBc04zQXRW?= =?utf-8?B?MFZwQm0vMGdFMWRJcG5ETnBKNFljdXFHam1oNHVYSW5aNElRWHpHRWRaNXpW?= =?utf-8?B?bGxxOWkxYTdSSWZKKzF2Z0x6aDd4MUVXNE9BSk9jaThlSE5rbDB0SDNYZ0lE?= =?utf-8?B?enBja294U1Q4L1huVExtMDNPeEc4U3lSSTlTNncweTBlTE1ya291UFpkMll0?= =?utf-8?B?bHc2eEZmck5mNXFLOWF5MVZ5QWJGb1BHNnovNTRqOUt2aG1zaTlBaTlhaWp5?= =?utf-8?B?eWFRbEhXdlUrUU1ycklyTU9QQ3lGSUx3RUFqSUU2NFZ0d0R4V0VPcnFOekQ4?= =?utf-8?B?VzhnekdDQUYxUG45RjhYcHRQbzVKTnlYWktwbWNRU1FZRUUxaFhVekhwZzNa?= =?utf-8?B?dnZUMDlvclkvaS9IVy9CSjJ1ZEhJV0grL3pGeEt0WHJCUVJkbUw4V0oraUMw?= =?utf-8?B?blJKWlhvb1VOQ2ZFSzVWbzJRWEZaWlc3Wm1YdUhzSzlvcE5XRjZwZ2ZSN3g0?= =?utf-8?B?L1Jxc05PQlVQTzlka2ZCUTNMYTNJaFVMWnN5QUtZRUt2Z2lXYndTMUVpSkxY?= =?utf-8?Q?sO3TFk1c50LmlZwe2tBfn1Ior?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b91f59e7-56c9-467e-0c21-08db34edde56 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 09:20:44.6882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G9qH83bYv/CAcTpMap9oTVfpNRDRO4ovFGwcImjmw7BSntIKnzR4nW551GsntFag8CHNUT1G7YgodBNzJDe1Hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8422 PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no more than 32k pIRQ-s can be used by a domain on x86. Document this upper bound. To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its parameter type) and setup_system_domains(). This is primarily to avoid exposing the two static variables or introducing yet further arch hooks. Signed-off-by: Jan Beulich --- Instead of passing dom_xen into arch_hwdom_irqs(), NULL could also be used. That would make the connection to setup_system_domains() yet more weak, though. On Arm the upper limit right now effectively is zero, albeit with - afaict - no impact if a higher value was used (and hence permitting up to the default of 32 is okay albeit useless). The question though is whether the command line option as a whole shouldn't be x86-only. Passing the domain pointer instead of the domain ID would also allow to return a possibly different value if sensible for PVH Dom0 (which presently has no access to PHYSDEVOP_pirq_eoi_gmfn_v in the first place). --- v2: Also enforce these bounds. Adjust doc to constrain the bound to x86 only. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1130,7 +1130,8 @@ common for all domUs, while the optional is for dom0. Changing the setting for domU has no impact on dom0 and vice versa. For example to change dom0 without changing domU, use `extra_guest_irqs=,512`. The default value for Dom0 and an eventual separate -hardware domain is architecture dependent. +hardware domain is architecture dependent. The upper limit for both values on +x86 is such that the resulting total number of IRQs can't be higher than 32768. Note that specifying zero as domU value means zero, while for dom0 it means to use the default. --- a/xen/arch/arm/include/asm/irq.h +++ b/xen/arch/arm/include/asm/irq.h @@ -52,7 +52,7 @@ struct arch_irq_desc { extern const unsigned int nr_irqs; #define nr_static_irqs NR_IRQS -#define arch_hwdom_irqs(domid) NR_IRQS +#define arch_hwdom_irqs(d) NR_IRQS struct irq_desc; struct irqaction; --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -2665,18 +2665,21 @@ void __init ioapic_init(void) nr_irqs_gsi, nr_irqs - nr_irqs_gsi); } -unsigned int arch_hwdom_irqs(domid_t domid) +unsigned int arch_hwdom_irqs(const struct domain *d) { unsigned int n = fls(num_present_cpus()); - if ( !domid ) + if ( is_system_domain(d) ) + return PAGE_SIZE * BITS_PER_BYTE; + + if ( !d->domain_id ) n = min(n, dom0_max_vcpus()); n = min(nr_irqs_gsi + n * NR_DYNAMIC_VECTORS, nr_irqs); /* Bounded by the domain pirq eoi bitmap gfn. */ n = min_t(unsigned int, n, PAGE_SIZE * BITS_PER_BYTE); - printk("Dom%d has maximum %u PIRQs\n", domid, n); + printk("%pd has maximum %u PIRQs\n", d, n); return n; } --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -659,7 +659,7 @@ struct domain *domain_create(domid_t dom d->nr_pirqs = nr_static_irqs + extra_domU_irqs; else d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs - : arch_hwdom_irqs(domid); + : arch_hwdom_irqs(d); d->nr_pirqs = min(d->nr_pirqs, nr_irqs); radix_tree_init(&d->pirq_tree); @@ -771,6 +771,8 @@ struct domain *domain_create(domid_t dom void __init setup_system_domains(void) { + unsigned int n; + /* * Initialise our DOMID_XEN domain. * Any Xen-heap pages that we will allow to be mapped will have @@ -782,6 +784,19 @@ void __init setup_system_domains(void) if ( IS_ERR(dom_xen) ) panic("Failed to create d[XEN]: %ld\n", PTR_ERR(dom_xen)); + /* Bound-check values passed via "extra_guest_irqs=". */ + n = max(arch_hwdom_irqs(dom_xen), nr_static_irqs); + if ( extra_hwdom_irqs > n - nr_static_irqs ) + { + extra_hwdom_irqs = n - nr_static_irqs; + printk(XENLOG_WARNING "hwdom IRQs bounded to %u\n", n); + } + if ( extra_domU_irqs > max(32U, n - nr_static_irqs) ) + { + extra_domU_irqs = n - nr_static_irqs; + printk(XENLOG_WARNING "domU IRQs bounded to %u\n", n); + } + /* * Initialise our DOMID_IO domain. * This domain owns I/O pages that are within the range of the page_info --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -173,8 +173,9 @@ extern irq_desc_t *pirq_spin_lock_irq_de unsigned int set_desc_affinity(struct irq_desc *, const cpumask_t *); +/* When passed a system domain, this returns the maximum permissible value. */ #ifndef arch_hwdom_irqs -unsigned int arch_hwdom_irqs(domid_t); +unsigned int arch_hwdom_irqs(const struct domain *); #endif #ifndef arch_evtchn_bind_pirq From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:38:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517701.803430 (Exim 4.92) (envelope-from ) id 1pjd7Y-00025P-RH; Tue, 04 Apr 2023 09:38:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517701.803430; Tue, 04 Apr 2023 09:38:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjd7Y-00025I-Mz; Tue, 04 Apr 2023 09:38:32 +0000 Received: by outflank-mailman (input) for mailman id 517701; Tue, 04 Apr 2023 09:38:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjd7X-00025C-9e for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:38:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 74b0c826-d2cc-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:38:30 +0200 (CEST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-4kZDA1kzP8OvR8XertBUoQ-1; Tue, 04 Apr 2023 05:38:25 -0400 Received: by mail-wr1-f70.google.com with SMTP id t9-20020adfba49000000b002dd3986083bso3601087wrg.12 for ; Tue, 04 Apr 2023 02:38:25 -0700 (PDT) Received: from work-vm (ward-16-b2-v4wan-166627-cust863.vm18.cable.virginm.net. [81.97.203.96]) by smtp.gmail.com with ESMTPSA id e5-20020a05600c218500b003ed243222adsm14539157wme.42.2023.04.04.02.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 02:38:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74b0c826-d2cc-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680601108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PrhRpuE5PfYdyTK6FnQG64gKAkt74Bkdl20J+vUSjAY=; b=FCGjmNrGWmqVC6GsMsCbqwGSvXl+NyJS+9aMQ4g8aI6GWehtHWt1yIuOIdu1ubhi347BjA VXgzuL/f5SnK9PZD2bPsMA+griQj6gPlNnMTiwa1DQ2NQ9Jj2vTGivcyj9SwhBnbe+eKCL WdHKv9QBovcwgjsLoTpQMpQNTHOmbqo= X-MC-Unique: 4kZDA1kzP8OvR8XertBUoQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680601104; x=1683193104; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PrhRpuE5PfYdyTK6FnQG64gKAkt74Bkdl20J+vUSjAY=; b=1kJDy+OxjQOX+xUYuwBsQUedTf5o+ipR1S+z5p79ZfV0w3dRcW7DAtv4mD54u6p62q IkAlEpnV7d7ITGnXjR1xyQFrj/GzFtDJIpROOhyYw91iHf/kSYJcUIeMAA1HxK1gbH9D nX9yiJCTymjUrEQlqC0K4YadqGHVkP9evkG8dqLfY3q7wpqz3Svyewd3sKGWfPGhQgN6 3KrqJCEJEYf2iulrZ1hGH5vdL3L5cWoDlJ68Dh74PiSpCM+3DOaVBrjQIIflXIxNL5kk DDM9jqwhAr/Zwvw91l72OLmsewanIIUVwmThYSy+9Iscgh87z30LdtJcUW+HFKEqxy+q i/vQ== X-Gm-Message-State: AAQBX9f8fYMXvTsIKVwW5urqyO232RlJniZW69YPgQH1nWoDiwEaaS87 3ylo1ZTczkQsiKGWAwDTrGZNcpNlB7Wl1tZtU7OWmLdUV7rJ9Tyq22d8OZt0lHkN2zWUWQCO1Sx DGRW7OFs/jfY33qo+eMtTaefYiyE= X-Received: by 2002:a7b:c38a:0:b0:3ed:e715:1784 with SMTP id s10-20020a7bc38a000000b003ede7151784mr1947188wmj.15.1680601104666; Tue, 04 Apr 2023 02:38:24 -0700 (PDT) X-Google-Smtp-Source: AKy350arlH3TpIuzppyhWEkgvJ11yISyREQNvnJp5gdw8zP6hTf84qhuHwXkNDKAhWVO4OJfBTXc1g== X-Received: by 2002:a7b:c38a:0:b0:3ed:e715:1784 with SMTP id s10-20020a7bc38a000000b003ede7151784mr1947163wmj.15.1680601104292; Tue, 04 Apr 2023 02:38:24 -0700 (PDT) Date: Tue, 4 Apr 2023 10:38:21 +0100 From: "Dr. David Alan Gilbert" To: Juan Quintela Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, Paolo Bonzini , Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Paul Durrant , "Richard W.M. Jones" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Anthony Perard Subject: Re: [PATCH 13/13] aio: remove aio_disable_external() API Message-ID: References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-14-stefanha@redhat.com> <877cusroqp.fsf@secure.mitica> MIME-Version: 1.0 In-Reply-To: <877cusroqp.fsf@secure.mitica> User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline * Juan Quintela (quintela@redhat.com) wrote: > Stefan Hajnoczi wrote: > > All callers now pass is_external=false to aio_set_fd_handler() and > > aio_set_event_notifier(). The aio_disable_external() API that > > temporarily disables fd handlers that were registered is_external=true > > is therefore dead code. > > > > Remove aio_disable_external(), aio_enable_external(), and the > > is_external arguments to aio_set_fd_handler() and > > aio_set_event_notifier(). > > > > The entire test-fdmon-epoll test is removed because its sole purpose was > > testing aio_disable_external(). > > > > Parts of this patch were generated using the following coccinelle > > (https://coccinelle.lip6.fr/) semantic patch: > > > > @@ > > expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; > > @@ > > - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) > > + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) > > > > @@ > > expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; > > @@ > > - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) > > + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) > > > > Signed-off-by: Stefan Hajnoczi > > [....] > > > diff --git a/migration/rdma.c b/migration/rdma.c > > index df646be35e..aee41ca43e 100644 > > --- a/migration/rdma.c > > +++ b/migration/rdma.c > > @@ -3104,15 +3104,15 @@ static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc, > > { > > QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc); > > if (io_read) { > > - aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, > > - false, io_read, io_write, NULL, NULL, opaque); > > - aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, > > - false, io_read, io_write, NULL, NULL, opaque); > > + aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, io_read, > > + io_write, NULL, NULL, opaque); > > + aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, io_read, > > + io_write, NULL, NULL, opaque); > > } else { > > - aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, > > - false, io_read, io_write, NULL, NULL, opaque); > > - aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, > > - false, io_read, io_write, NULL, NULL, opaque); > > + aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, io_read, > > + io_write, NULL, NULL, opaque); > > + aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, io_read, > > + io_write, NULL, NULL, opaque); > > } > > } > > Reviewed-by: Juan Quintela > > For the migration bits. > I don't even want to know why the RDMA code uses a low level block layer API. I don't think it's block specific. It looks like it's because qio_channel uses aio in the case where something QIO_CHANNEL_ERR_BLOCK and then waits for the recovery; see 4d9f675 that added it. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:49:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:49:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517705.803440 (Exim 4.92) (envelope-from ) id 1pjdIF-0003iS-VA; Tue, 04 Apr 2023 09:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517705.803440; Tue, 04 Apr 2023 09:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdIF-0003iL-Ru; Tue, 04 Apr 2023 09:49:35 +0000 Received: by outflank-mailman (input) for mailman id 517705; Tue, 04 Apr 2023 09:49:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdID-0003iF-O8 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:49:33 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe7579c3-d2cd-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:49:31 +0200 (CEST) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 05:49:24 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BY5PR03MB5362.namprd03.prod.outlook.com (2603:10b6:a03:220::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 09:49:21 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 09:49:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe7579c3-d2cd-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601771; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0TK5mmykk1NcKCg1NtRN94tEW99YAhs3/IlP3iOzrg8=; b=OZ50fGFJoKvmFdns2jOxop3jP983ZpwYLrHjBTb2ZPwW8cBJaPbSsF/m /DhKgyhnYUpvM/BzGgW4rAGZ+8XMsJ00quV3TB7QYxmiY0YqQOO7I54Nd I6tj4+AyUileSs62nihI68fiu3Eh97Tzjx8dS1NDE8ZqUtAONT5fsjPdk o=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 106670401 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:abX7gqgd5v+uiYSuq6vRI2rvX161RxEKZh0ujC45NGQN5FlHY01je htvXDiFPP6ON2TyftAnaN7l8xtVvcPUzdFkHFc9qiwxRCIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQzLTURNT3anNiIg6ORT+lgguVgAsn0adZ3VnFIlVk1DN4AaLWaGeDv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilIvluSyWDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHulBt1KSOXhnhJsqFShlnc9WDY6bmqcuMPnsFObGM1cA lNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4A/IPlqYRq1BbXFI4/T+iyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:QfaZqqybX/sjhG69DjMEKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="106670401" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9p2QuxIUIdjPEf8QDeg7FWnVBRGJQ6aGWQakcXLDPEp333o/1J+isxpWifpMwyF/j2BnBvxC0ecSOFQJ6tGEZWQFwjRxgqkYVU8QzffK1k3uoqTYoG/FJNj8GMuou8VCwiNRxeQblWxZCu7DVtzXaArIsVjCJYTQvcLRMJiGFiqQL0HFgVphvfKI3GP+lT4jYR2immaXrABKFFqNkH5GCI1PEK6KkbvYCuIIb/pcOYVjHs93acDUkjQvpsjX7ITLcNyk/dEm9TVI5GtM7FKpWrbPlr0IUxUtWBDqiNXhj8xJ84mc6Aq+lYJ4gFRs4Zq2eLql+zBMlg7PT9jHifxyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sg2Fb3jl6e1BDtSDZUlN864Ch3WiFTsjN/pXDxcysgg=; b=hYEET9wrBbHsF0a/r/NhJmHJFBg7Bqjej7m2ZSaE/4vE2zujEFe2LxNPPG/dwdWbJAn/zYwPOos2jB8czjLnw3GNWZYep5tu4jsY+4ZX86piv4WwSpUONVLRo/ocn/eGMYomZFvvnKvhWG1eueh/ZEqdUq+kHpB7UOFbnhyqQWLSI88M0uL4gwEF0jl3ypRevLf5p/p5UT/OsbbhHSWPzYd855oWuqvUeMhvK98bX4aHmVnG4Pok9cibT6MH46gTw6Ia8HRz7gAP1cTk7zMnvgzKZgbmqy26uo2VCa006S9uxdtFvO2QtmAZObcjCH0f6H8Fl2OaWyN1yIAJ0y6XOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sg2Fb3jl6e1BDtSDZUlN864Ch3WiFTsjN/pXDxcysgg=; b=UWHpsR2HAMa9Dw/hUDvroDZaSXg6XS3rreEApagL9Ol82Ref6sdZVvBr8SarQTAOBSy81UElGIY3xJcaE9xRuVw6hDOyjEkm72ABYORh931gU5l3LgcqZ8dIXcbiDTycH+RgeXzil42W8vr7Aedz0WwcO0KxKuKusX3G2PrNSeE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 11:49:14 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH] x86/p2m-pt: do type recalculations with p2m read lock Message-ID: References: <20230403101449.93323-1-roger.pau@citrix.com> <0adcb388-d2a9-e43e-ec20-de1df51f33d7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0514.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5362:EE_ X-MS-Office365-Filtering-Correlation-Id: aab5934b-d4a3-4bf1-35d5-08db34f1dd2a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zIOREiEmSeyBsvlaO7PcQ1/zqlyEN6XArCVekD3PjgoRc4U8z1VEleN/iGKSZ+qdihw/KAHzYJBAR4OAUVRQgZY75mWqOyCk6yoU7FZ5TbTtVAX4XrANHKR48VECbPxUDE+37eGtIfHJSfR6rd/hGVxuY0/DGK/DJxKc1L4FLtvGKg/Lu/UCsq9EqDoAKMGbXc6BqEye+ujjnY+WQViRKJry1yuZ9lzezdYSWva0qj9ZNcjM9WqcVTvj3vJ9JjHCt/NK7MN8BZig3RAvGOy9qP9nqOghkoA/HFPO6ShETl1bjCYfo6mjgP0+Y/n8nzZoUJu+CqEI7MBmJxKkv1LImA4GbOM+BHkMlhaq4ig65pEaKCS2QhdZqfINpOdAFjNt/xmSJJW/EGsgEDNuH98+gbfP+dRHQrwmduhCHclmckNQGhcluG0hyRdBA2jnwahH9FMj+rvpHTXlVLInVt4+ghZoN/dgwSL+pLrqekyC5lFRTPghKUYGQgyimF500FrtGKgO3ZyjypHwecy8VJTr99NHUibqfvr4Wx1LNsnizPcqVcxY/4+Tthw7OQ9+Sp43 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199021)(82960400001)(85182001)(38100700002)(33716001)(86362001)(2906002)(6486002)(9686003)(6506007)(6512007)(26005)(53546011)(6666004)(66946007)(66476007)(66556008)(8676002)(6916009)(4326008)(41300700001)(478600001)(54906003)(5660300002)(8936002)(316002)(83380400001)(66899021)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVppMEFiTDEyekM3UHYwR2xMdXVnMzR0ZkVlU0VlbzBzM0l1MWVhZjdGVmc2?= =?utf-8?B?dHdTRGpyRlhGcjVMb1dHSC9GQUZkSmNqOENaZzhVNG1XclFYVHVmM3NvSEhj?= =?utf-8?B?VzVJTG0rd3NQR1N6QmJUb0FiZitLaXFBUXc1b29WRkkxbDJyRmNZOVJGQ2tE?= =?utf-8?B?dnA5d1V6NWVKN00yRi8yRkl5bFVQM3pld01xb1RqaDhWckZLL2JCK0ZLdW5r?= =?utf-8?B?MUIvb0RaVmlISXJBYkFaZ3pGSXlUS1FxNkRGTThRZGZiNzRjcHpsSjFNM01o?= =?utf-8?B?cktaMFl1MFlWS2FmUTR1NlcwczV5a1lTQzdERmZkd2pvazU0YnA0QzlobG5h?= =?utf-8?B?ZjR6ZjVzek9LOHhUQ0hWT3RTNzhVKzNaT3lCV3hhSlVtNTJGbFhCUnRnNnlF?= =?utf-8?B?Vys5RTVEc0g3NnNHZWtLa3lxWTRpeWVyS21ZL0pUTXZJdHcvUzJ2Mk50cjNz?= =?utf-8?B?ZldUd2FScWduLzR1dUVEaGlmUGVBdU5VRE5WNDcyMWtET2ZJWWxiQThzaGRl?= =?utf-8?B?NHRWWXlTRmJYblV0eE1mUHUyT29MSk9ydEtUWDZXMG1jeThPeGNHMUMxdGg4?= =?utf-8?B?L1dmeUQ2ZmF6VE9pV0l4T3RyUGtLeXhJSGtGTVB5OVdBVjg3anFyK3c0QlNq?= =?utf-8?B?NEdOQWswUjF2ZzhGd1hKTERMYnRBdHk2Ynd6dXpPMnA0dC9xbWlLZWNZOTdn?= =?utf-8?B?ODc0WEF0Q012aWsycEJCVHhlWThuRVM1eitYejlURVUrM3hlT0V6aGtxRXUy?= =?utf-8?B?c0srMXBhTmc3NzRNNWFERTh2RkdyWTVlTjdOMExONlZ5eHNvZTdYZWxJRk9C?= =?utf-8?B?bTBBT0pqR3l2bE1NMHh3R01BZ0g3aE5Ya1JSMXhocGxnRmMxZHF3TnU4cm9J?= =?utf-8?B?cEFpQWUxaEpCQ3RTNm5yaUNHeWtQQklpUXZwU1pZdmpYSDlzR3V0ZWhVbCsx?= =?utf-8?B?dS9vL2Z5Z2V0SDludElPVk56WFliNGlxbWZpMytQUERaSjNQdWZXV1BQaWV0?= =?utf-8?B?NGpEMlZPcjE3UXpFbW9wbHFWRi9ldnlTM0U0WkVnTWtRQ1YzY2Y3ZVFCM1gv?= =?utf-8?B?SDdnUDdiUzRrRWozaCtkV2FxR1VGRWVQZXRVUFVnWW9Ya3Q1ek9pTUIwOUFn?= =?utf-8?B?bVJZK3RKTFk1RlZxUjNzajlXbzFhZ0UxTElBMTFocXdYSTJsOEZwNlFhcGVX?= =?utf-8?B?QlpzOWpCaVR4SmhXU1lmN2pOdmh3MkpMT3grNk9QTlQ4ZCs1TE80V1dGUlBk?= =?utf-8?B?WXRvcnZUV1QrckxjeXljeDFRS0RiK0wzdVVqblpjMW1rZC9EMFNlY3h4T2lW?= =?utf-8?B?Y041Qi82NXY3SUNnbHkrOFRMRjcwMEZ1aTJaZjVlYUlkTkljUXBmdm5vRVFF?= =?utf-8?B?MCtma0I3MFM1dk52U2hZSC8zVHE5bjZjUTNUUkVEWnppb2w3eVgvNzNVUjNo?= =?utf-8?B?VlJXMm10eW9Hc2Q0ODR1UThPTC92TDVXMkRDZGJXM3RaV29ta3JneXF1SlU0?= =?utf-8?B?MW1NU29Dcmg0VUtRMGpycCs1czdOTG9OczNYaElRN1pMam1nMXBSaFNVblpS?= =?utf-8?B?SnA5U2VSVGkyd1NhR2pHc0puaUZMdWl4aUI3dVA3dFNGNmZrUitQdDFBVVVw?= =?utf-8?B?WllJLzkyeVkzeWhnR2xpS1lkQ3dVTVlCU2tKazJhb21OTHdoemd1a01iK0NQ?= =?utf-8?B?c1ZPR05VbkpVUGJiN3ZUMGNoUFptQjNnZzlGZlFJWDh1em1tSVBibE40SDdt?= =?utf-8?B?V3dMdFVmSENBUElyaWkzNUpOWW1xS2hGOXRwR1ZrUXcrTjdidU1wamNOM05j?= =?utf-8?B?NERqVmNqVnFyZ3JYdXdjczF1cjBqbGFSdFpQc2xkcisveXEzb3B6TTR4QmZL?= =?utf-8?B?T0RUR2ZyandQQXBmQjFuOFZ2UjI0dlJzNDlOV3drQkRBckdlRnhxS2ZEU3Vt?= =?utf-8?B?OUJjWmwwQ0xnQnd5U25jU29Jc05ZbkJRWXhOTndYVWswNWFQTm5qUHdDRjJ4?= =?utf-8?B?eWFTRk9qbTViTmZCeGZtM0ZxWXVlOEVIWW81YmV3M2tnYXBJbHdtdWtsdVBp?= =?utf-8?B?bjNKWTRONDVWc21TaUgyc1J2TWdiYnBCRU9PYURaZ1Y2c2F1SjB6YnVWckRV?= =?utf-8?Q?KM4D5CcpFk9CLne8CWIIUMub9?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: usnYVDu0tWEVhKAgrpadeT2pkycxFshUxCyFt8z8juphXTAS7IDlxAB8CcfFGpJPqI/PVknW5XOp9VCmbplWoBDvPr/9/Q5HL5B/3G5f6j0RA7tOB13Men2ahNP98poyZMPR13LA2PvPe/ptbQQrW8q02YsEUD3wRw6s0ybPr5uPFYe1iBSJqj50BpINWdu9y97pBsDHU0sHQEAcBFnCdMNK4XAbDpratBjuzFmNJjVjXiCoDHqawed84gSs2jqosOYEg747FT5uGztLAzDZEA3bOeum3eQrh5EmzJ0UKSrH8TdnlT6ZvVU2hK0niPlwka655cKNg0X4rVDgg5EU0kn3Y1DbSoqG7mCV96dsbz4ey30PELu3P/PNAJXRTrmyTs6kDbn4DvwEHr0JeJdADeWSlhvzUph16yOLXX0/ron9wkAkhsjYW70pU1LE0WcUy6M1TZodvaVnSAiwR4yi7dC+GagfOdL5Np4S08miUJYWOSigzzK5LxzxhnAL7gKAYS329sB0zi8wSpReB/9WELPPXUOeYhXfM1XcmkXeGyMdRZBzyCpT02gckkQhvtEfPIWuXW5GDAnKlyjO+1Yf9XQFen7wviHC6ISJsrPA/TvhsxHuZy4lnkn0rU4rOpCghjJLkkqOmae1PjY5Z0jBLHbqUaPu4R7a9RVgRGOCRGKR/9Rku16ri125FP1xFs/vE599QuEkw10Fw2Z3AR2iANk4cKsRwXiHUYX+KBkoxWYtFCe2BFKRSe3MAOlg+tz+JnnA96IsYW2n6KKcQ+g/erpFRnWr+ML6GFbz4phtJH/+2NQMaiJJT3zrZ13xjTj7 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: aab5934b-d4a3-4bf1-35d5-08db34f1dd2a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 09:49:20.8879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZVllJ6hnUhXNRlMOxiFF95av+DwF6Ty/1p9Gmyymq5DkFKgXbEfJvZkbKUX0ypwyapbi4Ld93pPCcBM2lDei1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5362 On Mon, Apr 03, 2023 at 06:07:26PM +0200, Jan Beulich wrote: > On 03.04.2023 17:38, Roger Pau Monné wrote: > > On Mon, Apr 03, 2023 at 05:32:39PM +0200, Jan Beulich wrote: > >> On 03.04.2023 12:14, Roger Pau Monne wrote: > >>> Global p2m type recalculations (as triggered by logdirty) can create > >>> so much contention on the p2m lock that simple guest operations like > >>> VCPUOP_set_singleshot_timer on guests with a high amount of vCPUs (32) > >>> will cease to work in a timely manner, up to the point that Linux > >>> kernel versions that sill use the VCPU_SSHOTTMR_future flag with the > >>> singleshot timer will cease to work: > >>> > >>> [ 82.779470] CE: xen increased min_delta_ns to 1000000 nsec > >>> [ 82.793075] CE: Reprogramming failure. Giving up > >>> [ 82.779470] CE: Reprogramming failure. Giving up > >>> [ 82.821864] CE: xen increased min_delta_ns to 506250 nsec > >>> [ 82.821864] CE: xen increased min_delta_ns to 759375 nsec > >>> [ 82.821864] CE: xen increased min_delta_ns to 1000000 nsec > >>> [ 82.821864] CE: Reprogramming failure. Giving up > >>> [ 82.856256] CE: Reprogramming failure. Giving up > >>> [ 84.566279] CE: Reprogramming failure. Giving up > >>> [ 84.649493] Freezing user space processes ... > >>> [ 130.604032] INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) > >>> [ 130.604032] Task dump for CPU 14: > >>> [ 130.604032] swapper/14 R running task 0 0 1 0x00000000 > >>> [ 130.604032] Call Trace: > >>> [ 130.604032] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > >>> [ 130.604032] [] ? default_idle+0x1e/0xd0 > >>> [ 130.604032] [] ? arch_cpu_idle+0x20/0xc0 > >>> [ 130.604032] [] ? cpu_startup_entry+0x14a/0x1e0 > >>> [ 130.604032] [] ? start_secondary+0x1f7/0x270 > >>> [ 130.604032] [] ? start_cpu+0x5/0x14 > >>> [ 549.654536] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) > >>> [ 549.655463] Task dump for CPU 26: > >>> [ 549.655463] swapper/26 R running task 0 0 1 0x00000000 > >>> [ 549.655463] Call Trace: > >>> [ 549.655463] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > >>> [ 549.655463] [] ? default_idle+0x1e/0xd0 > >>> [ 549.655463] [] ? arch_cpu_idle+0x20/0xc0 > >>> [ 549.655463] [] ? cpu_startup_entry+0x14a/0x1e0 > >>> [ 549.655463] [] ? start_secondary+0x1f7/0x270 > >>> [ 549.655463] [] ? start_cpu+0x5/0x14 > >>> [ 821.888478] INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) > >>> [ 821.888596] Task dump for CPU 26: > >>> [ 821.888622] swapper/26 R running task 0 0 1 0x00000000 > >>> [ 821.888677] Call Trace: > >>> [ 821.888712] [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > >>> [ 821.888771] [] ? default_idle+0x1e/0xd0 > >>> [ 821.888818] [] ? arch_cpu_idle+0x20/0xc0 > >>> [ 821.888865] [] ? cpu_startup_entry+0x14a/0x1e0 > >>> [ 821.888917] [] ? start_secondary+0x1f7/0x270 > >>> [ 821.888966] [] ? start_cpu+0x5/0x14 > >>> > >>> This is obviously undesirable. One way to bodge the issue would be to > >>> ignore VCPU_SSHOTTMR_future, but that's a deliberate breakage of the > >>> hypercall ABI. > >>> > >>> Instead lower the contention in the lock by doing the recalculation > >>> with the lock in read mode. This is safe because only the flags/type > >>> are changed, there's no PTE mfn change in the AMD recalculation logic. > >>> The Intel (EPT) case is likely more complicated, as superpage > >>> splitting for diverging EMT values must be done with the p2m lock in > >>> taken in write mode. > >>> > >>> Signed-off-by: Roger Pau Monné > >>> --- > >>> I'm unsure whether such modification is fully safe: I think changing > >>> the flags/type should be fine: the PTE write is performed using > >>> safwrite_p2m_entry() which must be atomic (as the guest is still > >>> running and accessing the page tables). I'm slightly worried about > >>> all PTE readers not using atomic accesses to do so (ie: pointer > >>> returned by p2m_find_entry() should be read atomicallly), and code > >>> assuming that a gfn type cannot change while holding the p2m lock in > >>> read mode. > >> > >> Coming back to this: Yes, I think reads (at least the ones in do_recalc() > >> which can now be done in parallel) will need to be tightened if this is a > >> road we want to follow. > > > > There are likely a lot of reads under the p2m read lock outside of > > do_recalc() that will ideally need to be switched to use atomic > > accesses also? > > Possibly, perhaps even likely. I specifically said "at least". But ones > clearly on write-locked paths could probably be left alone. > > > I'm open to suggestions to other ways to get this sorted. And that's > > a guest with 'just' 32 vCPUs, as we go up the contention on the p2m > > lock during recalcs/misconfigs is going to increase massively. > > I'm afraid I don't have any really good idea, but I'm wondering whether > trylock with (almost?) immediate exit back to guest might make this any > better. At least the guest could then take interrupts before the insn > is retried. Another thought in this direction would be to have a variant > of trylock which "senses" how contended the lock is, to spin if it's the > first one to wait, but exit (fail) otherwise. Using trylock in the recalc path could starve those quite badly, as readers can acquire the lock concurrently. Also we would loose the fairness. Using trylock on VCPUOP_set_singleshot_timer (in order to fetch the data from the guest provided pointer) would lead to the same situation AFAICT, as guests using VCPU_SSHOTTMR_future will likely see the time expired by the point the hypercall checks it. One thing that I've noticed is that copy_from_guest for HVM (__hvm_copy()) takes and releases the p2m lock in read mode at several points. It would likely be better if the whole GVA -> MFN translation was resolved inside of a single read-locked region, as that would avoid stalls in the middle of the operation, but I don't think this will solve the issue at hand. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517713.803489 (Exim 4.92) (envelope-from ) id 1pjdLL-00065q-Kf; Tue, 04 Apr 2023 09:52:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517713.803489; Tue, 04 Apr 2023 09:52:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLL-00064o-FH; Tue, 04 Apr 2023 09:52:47 +0000 Received: by outflank-mailman (input) for mailman id 517713; Tue, 04 Apr 2023 09:52:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLJ-0005bo-Os for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:45 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70fd1efd-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:52:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70fd1efd-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601963; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DskzMb94090V7ZbiUkJVNj9GkqXb607CuUmAX3BTcQA=; b=debtlS28BTxGtSYZb6P407iklmOqyFqitg4Ggsc3Y/bOyPWvsKpskBpf 9Ty8v+uGuUaL6rEzOL0IsmCjHuHKQ2HpAIvnZnYlggJ6OjpIIVfuZAeua a2YndCaKf97FkyASzT+DLkvOICgR+PWgtrMzeFD927vihzC6Bn/dZ8tM8 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103612244 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:oo6hb6gLw1Ufv2IQodeBTL1UX161HxAKZh0ujC45NGQN5FlHY01je htvWmiBPPuDYTf1c9okbty+/U4GupXSz9Q3QQM/rC48Eyob9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQmLCFXNyvEht6PwbGlEMRP1skGCdX0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27B/ jmYpj6jXk1y2Nq38n2ByjG9i+r1m332faEjMKO92vduqQjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAPQ5sOcmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XrY3N9wXI+iTEscw8UuYDY54APtxPMUIxOM/64q/jpBmSlq 9yVlxTSl4n/nOZSifXjoA+Z2W31znTaZlVrv1uKBwpJ+is8Pdf4PNLwtDA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGFb5J+i8GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510nfC9SYq0DKuOMIomjn1NmOivpXkGWKJt9zq1zBhEfV8XY v93jvpA/V5FUP86nVJats8W0KMxxzBW+F4/savTlkz9uZLHPS79dFvwGAfWBgzPxP/e8Vq9H hc2H5fi9iizp8WlPXaLq9dPcglaRZX5bLivw/Fqmie4ClIOMAkc5zX5mNvNp6QNc3xpq9r1 IronPort-HdrOrdr: A9a23:Cxf9BKmoCalSaIbUWjqMRhn2btnpDfLd3DAbv31ZSRFFG/Fwwf re+sjztCWE6gr5PUtK8+xoV5PwOU80iqQFmrX5UY3OYOCigguVxeJZnO7fKl/behEWn9Q1vZ uIMZIOa+EYa2IXsS+Q2meF+rgbr+Vv+ZrY/9v2/jNWSAlhaeVN6Bp0ER+BEld7AClqbKBJcK a01458ojKrezAyYt6gDncIG8jvzue77a7OUFo9AhYs6k2ygTutrJ7WeiLouSsjbw== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103612244" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 02/15] x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields Date: Tue, 4 Apr 2023 10:52:09 +0100 Message-ID: <20230404095222.1373721-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit These weren't great names to begin with, and using {leaves,msrs} matches up better with the existing nr_{leaves,msr} parameters anyway. Furthermore, by renaming these fields we can get away with using some #define trickery to avoid the struct {cpuid,msr}_policy merge needing to happen in a single changeset. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Fix typo in commit message --- tools/libs/guest/xg_cpuid_x86.c | 12 ++++++------ xen/arch/x86/domctl.c | 12 ++++++------ xen/arch/x86/sysctl.c | 8 ++++---- xen/include/public/domctl.h | 4 ++-- xen/include/public/sysctl.h | 4 ++-- 5 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 1b02bc987af7..5fae06e77804 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -145,9 +145,9 @@ static int get_system_cpu_policy(xc_interface *xch, uint32_t index, sysctl.cmd = XEN_SYSCTL_get_cpu_policy; sysctl.u.cpu_policy.index = index; sysctl.u.cpu_policy.nr_leaves = *nr_leaves; - set_xen_guest_handle(sysctl.u.cpu_policy.cpuid_policy, leaves); + set_xen_guest_handle(sysctl.u.cpu_policy.leaves, leaves); sysctl.u.cpu_policy.nr_msrs = *nr_msrs; - set_xen_guest_handle(sysctl.u.cpu_policy.msr_policy, msrs); + set_xen_guest_handle(sysctl.u.cpu_policy.msrs, msrs); ret = do_sysctl(xch, &sysctl); @@ -183,9 +183,9 @@ static int get_domain_cpu_policy(xc_interface *xch, uint32_t domid, domctl.cmd = XEN_DOMCTL_get_cpu_policy; domctl.domain = domid; domctl.u.cpu_policy.nr_leaves = *nr_leaves; - set_xen_guest_handle(domctl.u.cpu_policy.cpuid_policy, leaves); + set_xen_guest_handle(domctl.u.cpu_policy.leaves, leaves); domctl.u.cpu_policy.nr_msrs = *nr_msrs; - set_xen_guest_handle(domctl.u.cpu_policy.msr_policy, msrs); + set_xen_guest_handle(domctl.u.cpu_policy.msrs, msrs); ret = do_domctl(xch, &domctl); @@ -232,9 +232,9 @@ int xc_set_domain_cpu_policy(xc_interface *xch, uint32_t domid, domctl.cmd = XEN_DOMCTL_set_cpu_policy; domctl.domain = domid; domctl.u.cpu_policy.nr_leaves = nr_leaves; - set_xen_guest_handle(domctl.u.cpu_policy.cpuid_policy, leaves); + set_xen_guest_handle(domctl.u.cpu_policy.leaves, leaves); domctl.u.cpu_policy.nr_msrs = nr_msrs; - set_xen_guest_handle(domctl.u.cpu_policy.msr_policy, msrs); + set_xen_guest_handle(domctl.u.cpu_policy.msrs, msrs); domctl.u.cpu_policy.err_leaf = -1; domctl.u.cpu_policy.err_subleaf = -1; domctl.u.cpu_policy.err_msr = -1; diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 0b41b279507e..944af63e68d0 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -54,10 +54,10 @@ static int update_domain_cpu_policy(struct domain *d, /* Merge the toolstack provided data. */ if ( (ret = x86_cpuid_copy_from_buffer( - new.cpuid, xdpc->cpuid_policy, xdpc->nr_leaves, + new.cpuid, xdpc->leaves, xdpc->nr_leaves, &err.leaf, &err.subleaf)) || (ret = x86_msr_copy_from_buffer( - new.msr, xdpc->msr_policy, xdpc->nr_msrs, &err.msr)) ) + new.msr, xdpc->msrs, xdpc->nr_msrs, &err.msr)) ) goto out; /* Trim any newly-stale out-of-range leaves. */ @@ -1317,20 +1317,20 @@ long arch_do_domctl( case XEN_DOMCTL_get_cpu_policy: /* Process the CPUID leaves. */ - if ( guest_handle_is_null(domctl->u.cpu_policy.cpuid_policy) ) + if ( guest_handle_is_null(domctl->u.cpu_policy.leaves) ) domctl->u.cpu_policy.nr_leaves = CPUID_MAX_SERIALISED_LEAVES; else if ( (ret = x86_cpuid_copy_to_buffer( d->arch.cpuid, - domctl->u.cpu_policy.cpuid_policy, + domctl->u.cpu_policy.leaves, &domctl->u.cpu_policy.nr_leaves)) ) break; /* Process the MSR entries. */ - if ( guest_handle_is_null(domctl->u.cpu_policy.msr_policy) ) + if ( guest_handle_is_null(domctl->u.cpu_policy.msrs) ) domctl->u.cpu_policy.nr_msrs = MSR_MAX_SERIALISED_ENTRIES; else if ( (ret = x86_msr_copy_to_buffer( d->arch.msr, - domctl->u.cpu_policy.msr_policy, + domctl->u.cpu_policy.msrs, &domctl->u.cpu_policy.nr_msrs)) ) break; diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index 3f5b092df16a..3ed7c69f4315 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -411,11 +411,11 @@ long arch_do_sysctl( } /* Process the CPUID leaves. */ - if ( guest_handle_is_null(sysctl->u.cpu_policy.cpuid_policy) ) + if ( guest_handle_is_null(sysctl->u.cpu_policy.leaves) ) sysctl->u.cpu_policy.nr_leaves = CPUID_MAX_SERIALISED_LEAVES; else if ( (ret = x86_cpuid_copy_to_buffer( policy->cpuid, - sysctl->u.cpu_policy.cpuid_policy, + sysctl->u.cpu_policy.leaves, &sysctl->u.cpu_policy.nr_leaves)) ) break; @@ -427,11 +427,11 @@ long arch_do_sysctl( } /* Process the MSR entries. */ - if ( guest_handle_is_null(sysctl->u.cpu_policy.msr_policy) ) + if ( guest_handle_is_null(sysctl->u.cpu_policy.msrs) ) sysctl->u.cpu_policy.nr_msrs = MSR_MAX_SERIALISED_ENTRIES; else if ( (ret = x86_msr_copy_to_buffer( policy->msr, - sysctl->u.cpu_policy.msr_policy, + sysctl->u.cpu_policy.msrs, &sysctl->u.cpu_policy.nr_msrs)) ) break; diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 7280e9f96816..529801c89ba3 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -683,8 +683,8 @@ struct xen_domctl_cpu_policy { * 'cpuid_policy'. */ uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to * 'msr_policy' */ - XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */ - XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy; /* IN/OUT */ + XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) leaves; /* IN/OUT */ + XEN_GUEST_HANDLE_64(xen_msr_entry_t) msrs; /* IN/OUT */ /* * OUT, set_policy only. Written in some (but not all) error cases to diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index e8dded9fb94a..2b24d6bfd00e 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -1050,8 +1050,8 @@ struct xen_sysctl_cpu_policy { * 'msr_policy', or the maximum number of MSRs if * the guest handle is NULL. */ uint32_t _rsvd; /* Must be zero. */ - XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* OUT */ - XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy; /* OUT */ + XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) leaves; /* OUT */ + XEN_GUEST_HANDLE_64(xen_msr_entry_t) msrs; /* OUT */ }; typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517714.803496 (Exim 4.92) (envelope-from ) id 1pjdLM-0006FC-8d; Tue, 04 Apr 2023 09:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517714.803496; Tue, 04 Apr 2023 09:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLM-0006Ds-2q; Tue, 04 Apr 2023 09:52:48 +0000 Received: by outflank-mailman (input) for mailman id 517714; Tue, 04 Apr 2023 09:52:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLK-0005bo-MN for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:46 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71dfcd27-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:52:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71dfcd27-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601964; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lvleilS5BRDLhyzG1k+YQ1TdfDraad9QCp1ZsHyb0Xk=; b=WunbCIuEUdHCEfvZ4bFM7QNzud+F87X+JbejyrRmxpS2SqPUiPLvnKcW th6/wWn72x1OdW5pTTLauqQZI+Eus8pu50njyMdyQH6CqpcZmdHFiYsXx +GliXG8kQQgPqMUQCK0PpWy0zbmos0WPl4+rm7nkcGE7G7v3XLVU5mAIc 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106670669 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:j7CdmqBPer0whRVW/1bjw5YqxClBgxIJ4kV8jS/XYbTApDMl12FWy jYWUWmEbPyKZjOkc9txbt/l9E4EsJOAy9M2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw171LJ0Fj6 vUhM3NXZBSgjsm376Kbc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9I4TUG5oNwBjJz o7A1z6lEz8mC9Xc8wbftULrhajxpAWjdqtHQdVU8dY12QbOlwT/EiY+Sl+TsfS/zEmkVLp3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmPwKfJ5weSBkAfUyVMLtchsacLqScCj wHT2YmzXHo27ePTECjGnluJkd+sEQVOEUkiSDANdBBGudPng4gYjz3fbu82RcZZkebJ9SHML yGi9XZu3+hM05RUjs1X7nic3Wvy+8Ghohodo1yOAzn7tl4RiJuNPdTA1LTN0RpXwG91pHGlt WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43Nzgbb1HRcNJG8yFoSLLQGypyGgWyL1VGsgFYyT1R 0TYpBlc4pReVFPzM/8vPt7vWp5xl/awfTgAahwzRoMWCqWdiSfdpH0+DaJu9zuFfLcQfVEXZ s7ALJfE4YcyAqV71jumL9ogPUsQ7nlmnwv7HMmrpylLJJLCPBZ5v59ZagrRBg34hYvYyDjoH yF3bJTVl08GDLKnMkE6M+c7dDg3EJTyPriuw+Q/SwJJClMO9L0JYxMJ/Y4cRg== IronPort-HdrOrdr: A9a23:3Hy5EK55FGsbrdfn5wPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="106670669" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 04/15] x86: Merge struct msr_policy into struct cpu_policy Date: Tue, 4 Apr 2023 10:52:11 +0100 Message-ID: <20230404095222.1373721-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit As with the cpuid side, use a temporary define to make struct msr_policy still work. Note, this means that domains now have two separate struct cpu_policy allocations with disjoint information, and system policies are in a similar position, as well as xc_cpu_policy objects in libxenguest. All of these duplications will be addressed in the following patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Alter msr_policy -> cpu_policy in comments. --- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 1 - xen/arch/x86/include/asm/msr.h | 3 +- xen/include/xen/lib/x86/cpu-policy.h | 81 ++++++++++++++++- xen/include/xen/lib/x86/msr.h | 104 ---------------------- xen/lib/x86/msr.c | 2 +- 5 files changed, 83 insertions(+), 108 deletions(-) delete mode 100644 xen/include/xen/lib/x86/msr.h diff --git a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c index 79e42e8bfd04..0ce3d8e16626 100644 --- a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c +++ b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c @@ -10,7 +10,6 @@ #include #include -#include #include static bool debug; diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 7946b6b24c11..02eddd919c27 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -6,8 +6,9 @@ #include #include #include +#include -#include +#include #include #include diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 666505964d00..53fffca55211 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -3,7 +3,6 @@ #define XEN_LIB_X86_POLICIES_H #include -#include #define FEATURESET_1d 0 /* 0x00000001.edx */ #define FEATURESET_1c 1 /* 0x00000001.ecx */ @@ -107,6 +106,9 @@ const char *x86_cpuid_vendor_to_str(unsigned int vendor); CPUID_GUEST_NR_XSTATE - !!CPUID_GUEST_NR_XSTATE + \ CPUID_GUEST_NR_EXTD + 2 /* hv_limit and hv2_limit */ ) +/* Maximum number of MSRs written when serialising a cpu_policy. */ +#define MSR_MAX_SERIALISED_ENTRIES 2 + struct cpu_policy { #define DECL_BITFIELD(word) _DECL_BITFIELD(FEATURESET_ ## word) @@ -324,6 +326,44 @@ struct cpu_policy }; } extd; + /* + * 0x000000ce - MSR_INTEL_PLATFORM_INFO + * + * This MSR is non-architectural, but for simplicy we allow it to be read + * unconditionally. CPUID Faulting support can be fully emulated for HVM + * guests so can be offered unconditionally, while support for PV guests + * is dependent on real hardware support. + */ + union { + uint32_t raw; + struct { + uint32_t :31; + bool cpuid_faulting:1; + }; + } platform_info; + + /* + * 0x0000010a - MSR_ARCH_CAPABILITIES + * + * This is an Intel-only MSR, which provides miscellaneous enumeration, + * including those which indicate that microarchitectrual sidechannels are + * fixed in hardware. + */ + union { + uint32_t raw; + struct { + bool rdcl_no:1; + bool ibrs_all:1; + bool rsba:1; + bool skip_l1dfl:1; + bool ssb_no:1; + bool mds_no:1; + bool if_pschange_mc_no:1; + bool tsx_ctrl:1; + bool taa_no:1; + }; + } arch_caps; + #undef __DECL_BITFIELD #undef _DECL_BITFIELD #undef DECL_BITFIELD @@ -337,6 +377,7 @@ struct cpu_policy /* Temporary */ #define cpuid_policy cpu_policy +#define msr_policy cpu_policy struct old_cpu_policy { @@ -438,9 +479,11 @@ void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p); #ifdef __XEN__ #include typedef XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_leaf_buffer_t; +typedef XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_entry_buffer_t; #else #include typedef xen_cpuid_leaf_t cpuid_leaf_buffer_t[]; +typedef xen_msr_entry_t msr_entry_buffer_t[]; #endif /** @@ -480,6 +523,42 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, uint32_t nr_entries, uint32_t *err_leaf, uint32_t *err_subleaf); +/** + * Serialise an msr_policy object into an array. + * + * @param policy The msr_policy to serialise. + * @param msrs The array of msrs to serialise into. + * @param nr_entries The number of entries in 'msrs'. + * @returns -errno + * + * Writes at most MSR_MAX_SERIALISED_ENTRIES. May fail with -ENOBUFS if the + * buffer array is too short. On success, nr_entries is updated with the + * actual number of msrs written. + */ +int x86_msr_copy_to_buffer(const struct msr_policy *policy, + msr_entry_buffer_t msrs, uint32_t *nr_entries); + +/** + * Unserialise an msr_policy object from an array of msrs. + * + * @param policy The msr_policy object to unserialise into. + * @param msrs The array of msrs to unserialise from. + * @param nr_entries The number of entries in 'msrs'. + * @param err_msr Optional hint for error diagnostics. + * @returns -errno + * + * Reads at most MSR_MAX_SERIALISED_ENTRIES. May fail for a number of reasons + * based on the content in an individual 'msrs' entry, including the MSR index + * not being valid in the policy, the flags field being nonzero, or if the + * value provided would truncate when stored in the policy. In such cases, + * the optional err_* pointer will identify the problematic MSR. + * + * No content validation is performed on the data stored in the policy object. + */ +int x86_msr_copy_from_buffer(struct msr_policy *policy, + const msr_entry_buffer_t msrs, uint32_t nr_entries, + uint32_t *err_msr); + /* * Calculate whether two policies are compatible. * diff --git a/xen/include/xen/lib/x86/msr.h b/xen/include/xen/lib/x86/msr.h deleted file mode 100644 index 48ba4a59c036..000000000000 --- a/xen/include/xen/lib/x86/msr.h +++ /dev/null @@ -1,104 +0,0 @@ -/* Common data structures and functions consumed by hypervisor and toolstack */ -#ifndef XEN_LIB_X86_MSR_H -#define XEN_LIB_X86_MSR_H - -/* Maximum number of MSRs written when serialising msr_policy. */ -#define MSR_MAX_SERIALISED_ENTRIES 2 - -/* MSR policy object for shared per-domain MSRs */ -struct msr_policy -{ - /* - * 0x000000ce - MSR_INTEL_PLATFORM_INFO - * - * This MSR is non-architectural, but for simplicy we allow it to be read - * unconditionally. CPUID Faulting support can be fully emulated for HVM - * guests so can be offered unconditionally, while support for PV guests - * is dependent on real hardware support. - */ - union { - uint32_t raw; - struct { - uint32_t :31; - bool cpuid_faulting:1; - }; - } platform_info; - - /* - * 0x0000010a - MSR_ARCH_CAPABILITIES - * - * This is an Intel-only MSR, which provides miscellaneous enumeration, - * including those which indicate that microarchitectrual sidechannels are - * fixed in hardware. - */ - union { - uint32_t raw; - struct { - bool rdcl_no:1; - bool ibrs_all:1; - bool rsba:1; - bool skip_l1dfl:1; - bool ssb_no:1; - bool mds_no:1; - bool if_pschange_mc_no:1; - bool tsx_ctrl:1; - bool taa_no:1; - }; - } arch_caps; -}; - -#ifdef __XEN__ -#include -typedef XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_entry_buffer_t; -#else -#include -typedef xen_msr_entry_t msr_entry_buffer_t[]; -#endif - -/** - * Serialise an msr_policy object into an array. - * - * @param policy The msr_policy to serialise. - * @param msrs The array of msrs to serialise into. - * @param nr_entries The number of entries in 'msrs'. - * @returns -errno - * - * Writes at most MSR_MAX_SERIALISED_ENTRIES. May fail with -ENOBUFS if the - * buffer array is too short. On success, nr_entries is updated with the - * actual number of msrs written. - */ -int x86_msr_copy_to_buffer(const struct msr_policy *policy, - msr_entry_buffer_t msrs, uint32_t *nr_entries); - -/** - * Unserialise an msr_policy object from an array of msrs. - * - * @param policy The msr_policy object to unserialise into. - * @param msrs The array of msrs to unserialise from. - * @param nr_entries The number of entries in 'msrs'. - * @param err_msr Optional hint for error diagnostics. - * @returns -errno - * - * Reads at most MSR_MAX_SERIALISED_ENTRIES. May fail for a number of reasons - * based on the content in an individual 'msrs' entry, including the MSR index - * not being valid in the policy, the flags field being nonzero, or if the - * value provided would truncate when stored in the policy. In such cases, - * the optional err_* pointer will identify the problematic MSR. - * - * No content validation is performed on the data stored in the policy object. - */ -int x86_msr_copy_from_buffer(struct msr_policy *policy, - const msr_entry_buffer_t msrs, uint32_t nr_entries, - uint32_t *err_msr); - -#endif /* !XEN_LIB_X86_MSR_H */ - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * tab-width: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/xen/lib/x86/msr.c b/xen/lib/x86/msr.c index 7d71e92a380a..c4d885e7b568 100644 --- a/xen/lib/x86/msr.c +++ b/xen/lib/x86/msr.c @@ -1,6 +1,6 @@ #include "private.h" -#include +#include /* * Copy a single MSR into the provided msr_entry_buffer_t buffer, performing a -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517710.803455 (Exim 4.92) (envelope-from ) id 1pjdLH-00059k-LP; Tue, 04 Apr 2023 09:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517710.803455; Tue, 04 Apr 2023 09:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLH-00058c-G1; Tue, 04 Apr 2023 09:52:43 +0000 Received: by outflank-mailman (input) for mailman id 517710; Tue, 04 Apr 2023 09:52:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLG-00056d-Dy for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:42 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e4dedd2-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:52:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e4dedd2-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601958; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=26klonSMws4SwwrhUJvMYhga9nBaQ/a3jGXfpoulioI=; b=d/YAm3j1rzvxGBlaOJyg/vwXopWL36Ba0QNi1HIbUXHH7iL0mrvYZLpp +TAzt9ErqBxZXnoG1sgg2q92GP7hsgLNiGzKKLJD1L0PZUuEcfNbC+01e 7jFMCfdD5uS76SeyBKeA0i5pHqvJdwOfpuo+H4sH2ADdHOmzOl6963T/X s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104161361 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:vNzrr606nWyAYg4k/PbD5axxkn2cJEfYwER7XKvMYLTBsI5bp2NVz TQcCm2OO/3YZWqje9AkPNjipBkG7JbQzddrG1RspC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfJ3Fny f0oBxQ0bjOSmcmMx6jqd+triZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJ0JxxjB/ Tyfl4j/KgoIEd+55DeYy0qLtP3VwmDXSbsNE4Tto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jY+cddNF+wx6CmW17HZpQ2eAwAsUTppeNEg8sgsSlQXO kShxo2zQ2Y16fvMFCzbr+3Pxd+vBcQLBUkSTBMFfSQh2tnAsZ8YtBXVH+thF6Hg27UZBgrML yC2QDkW3utD1ZNUif/kpDgrkBr3+MGXE1ddChH/Gzv8s1gnPNPNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83oJrW7FF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPdLpVph0nPK7T4q1PhwxUjapSsEpHDJrAQk0PRLAt4wTuBNEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqLH/jTlk33uYdykVbJEd/pxnPSNLFmhE5FyS2Jm +ti2zyikEoADLenPnaOoeb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:9DL2QqBOw0rCwfjlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104161361" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 09/15] x86: Out-of-inline the policy<->featureset convertors Date: Tue, 4 Apr 2023 10:52:16 +0100 Message-ID: <20230404095222.1373721-10-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit These are already getting over-large for being inline functions, and are only going to grow more over time. Out of line them, yielding the following net delta from bloat-o-meter: add/remove: 2/0 grow/shrink: 0/4 up/down: 276/-1877 (-1601) Switch to the newer cpu_policy terminology while doing so. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New --- tools/libs/guest/xg_cpuid_x86.c | 2 +- xen/arch/x86/cpuid.c | 28 +++++++-------- xen/arch/x86/sysctl.c | 2 +- xen/include/xen/lib/x86/cpu-policy.h | 52 ++++++---------------------- xen/lib/x86/cpuid.c | 42 ++++++++++++++++++++++ 5 files changed, 68 insertions(+), 58 deletions(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 259029be8b36..33d366a8eb43 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -565,7 +565,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, } } - cpuid_featureset_to_policy(feat, p); + x86_cpu_featureset_to_policy(feat, p); } else { diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index df3e503ced9d..5eb5f1893516 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -368,7 +368,7 @@ static void __init calculate_host_policy(void) p->extd.max_leaf = 0x80000000 | min_t(uint32_t, max_extd_leaf & 0xffff, ARRAY_SIZE(p->extd.raw) - 1); - cpuid_featureset_to_policy(boot_cpu_data.x86_capability, p); + x86_cpu_featureset_to_policy(boot_cpu_data.x86_capability, p); recalculate_xstate(p); recalculate_misc(p); @@ -450,7 +450,7 @@ static void __init calculate_pv_max_policy(void) unsigned int i; *p = host_cpu_policy; - cpuid_policy_to_featureset(p, pv_featureset); + x86_cpu_policy_to_featureset(p, pv_featureset); for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) pv_featureset[i] &= pv_max_featuremask[i]; @@ -468,7 +468,7 @@ static void __init calculate_pv_max_policy(void) guest_common_feature_adjustments(pv_featureset); sanitise_featureset(pv_featureset); - cpuid_featureset_to_policy(pv_featureset, p); + x86_cpu_featureset_to_policy(pv_featureset, p); recalculate_xstate(p); p->extd.raw[0xa] = EMPTY_LEAF; /* No SVM for PV guests. */ @@ -481,7 +481,7 @@ static void __init calculate_pv_def_policy(void) unsigned int i; *p = pv_max_cpu_policy; - cpuid_policy_to_featureset(p, pv_featureset); + x86_cpu_policy_to_featureset(p, pv_featureset); for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) pv_featureset[i] &= pv_def_featuremask[i]; @@ -490,7 +490,7 @@ static void __init calculate_pv_def_policy(void) guest_common_default_feature_adjustments(pv_featureset); sanitise_featureset(pv_featureset); - cpuid_featureset_to_policy(pv_featureset, p); + x86_cpu_featureset_to_policy(pv_featureset, p); recalculate_xstate(p); } @@ -502,7 +502,7 @@ static void __init calculate_hvm_max_policy(void) const uint32_t *hvm_featuremask; *p = host_cpu_policy; - cpuid_policy_to_featureset(p, hvm_featureset); + x86_cpu_policy_to_featureset(p, hvm_featureset); hvm_featuremask = hvm_hap_supported() ? hvm_hap_max_featuremask : hvm_shadow_max_featuremask; @@ -581,7 +581,7 @@ static void __init calculate_hvm_max_policy(void) guest_common_feature_adjustments(hvm_featureset); sanitise_featureset(hvm_featureset); - cpuid_featureset_to_policy(hvm_featureset, p); + x86_cpu_featureset_to_policy(hvm_featureset, p); recalculate_xstate(p); } @@ -593,7 +593,7 @@ static void __init calculate_hvm_def_policy(void) const uint32_t *hvm_featuremask; *p = hvm_max_cpu_policy; - cpuid_policy_to_featureset(p, hvm_featureset); + x86_cpu_policy_to_featureset(p, hvm_featureset); hvm_featuremask = hvm_hap_supported() ? hvm_hap_def_featuremask : hvm_shadow_def_featuremask; @@ -612,7 +612,7 @@ static void __init calculate_hvm_def_policy(void) __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); sanitise_featureset(hvm_featureset); - cpuid_featureset_to_policy(hvm_featureset, p); + x86_cpu_featureset_to_policy(hvm_featureset, p); recalculate_xstate(p); } @@ -682,8 +682,8 @@ void recalculate_cpuid_policy(struct domain *d) ? CPUID_GUEST_NR_EXTD_AMD : CPUID_GUEST_NR_EXTD_INTEL) - 1); - cpuid_policy_to_featureset(p, fs); - cpuid_policy_to_featureset(max, max_fs); + x86_cpu_policy_to_featureset(p, fs); + x86_cpu_policy_to_featureset(max, max_fs); if ( is_hvm_domain(d) ) { @@ -740,7 +740,7 @@ void recalculate_cpuid_policy(struct domain *d) (cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | cpufeat_mask(X86_FEATURE_NO_FPU_SEL))); - cpuid_featureset_to_policy(fs, p); + x86_cpu_featureset_to_policy(fs, p); /* Pass host cacheline size through to guests. */ p->basic.clflush_size = max->basic.clflush_size; @@ -806,7 +806,7 @@ void __init init_dom0_cpuid_policy(struct domain *d) uint32_t fs[FSCAPINTS]; unsigned int i; - cpuid_policy_to_featureset(p, fs); + x86_cpu_policy_to_featureset(p, fs); for ( i = 0; i < ARRAY_SIZE(fs); ++i ) { @@ -814,7 +814,7 @@ void __init init_dom0_cpuid_policy(struct domain *d) fs[i] &= ~dom0_disable_feat[i]; } - cpuid_featureset_to_policy(fs, p); + x86_cpu_featureset_to_policy(fs, p); recalculate_cpuid_policy(d); } diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index 43a241f2090f..c107f40c6283 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -338,7 +338,7 @@ long arch_do_sysctl( ret = -EINVAL; if ( !ret ) - cpuid_policy_to_featureset(p, featureset); + x86_cpu_policy_to_featureset(p, featureset); /* Copy the requested featureset into place. */ if ( !ret && copy_to_guest(sysctl->u.cpu_featureset.features, diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 8b27a0725b8e..57b4633c861e 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -387,49 +387,17 @@ struct cpu_policy_errors #define INIT_CPU_POLICY_ERRORS { -1, -1, -1 } -/* Fill in a featureset bitmap from a CPUID policy. */ -static inline void cpuid_policy_to_featureset( - const struct cpuid_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) -{ - fs[FEATURESET_1d] = p->basic._1d; - fs[FEATURESET_1c] = p->basic._1c; - fs[FEATURESET_e1d] = p->extd.e1d; - fs[FEATURESET_e1c] = p->extd.e1c; - fs[FEATURESET_Da1] = p->xstate.Da1; - fs[FEATURESET_7b0] = p->feat._7b0; - fs[FEATURESET_7c0] = p->feat._7c0; - fs[FEATURESET_e7d] = p->extd.e7d; - fs[FEATURESET_e8b] = p->extd.e8b; - fs[FEATURESET_7d0] = p->feat._7d0; - fs[FEATURESET_7a1] = p->feat._7a1; - fs[FEATURESET_e21a] = p->extd.e21a; - fs[FEATURESET_7b1] = p->feat._7b1; - fs[FEATURESET_7d2] = p->feat._7d2; - fs[FEATURESET_7c1] = p->feat._7c1; - fs[FEATURESET_7d1] = p->feat._7d1; -} +/** + * Copy the featureset words out of a cpu_policy object. + */ +void x86_cpu_policy_to_featureset(const struct cpu_policy *p, + uint32_t fs[FEATURESET_NR_ENTRIES]); -/* Fill in a CPUID policy from a featureset bitmap. */ -static inline void cpuid_featureset_to_policy( - const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpuid_policy *p) -{ - p->basic._1d = fs[FEATURESET_1d]; - p->basic._1c = fs[FEATURESET_1c]; - p->extd.e1d = fs[FEATURESET_e1d]; - p->extd.e1c = fs[FEATURESET_e1c]; - p->xstate.Da1 = fs[FEATURESET_Da1]; - p->feat._7b0 = fs[FEATURESET_7b0]; - p->feat._7c0 = fs[FEATURESET_7c0]; - p->extd.e7d = fs[FEATURESET_e7d]; - p->extd.e8b = fs[FEATURESET_e8b]; - p->feat._7d0 = fs[FEATURESET_7d0]; - p->feat._7a1 = fs[FEATURESET_7a1]; - p->extd.e21a = fs[FEATURESET_e21a]; - p->feat._7b1 = fs[FEATURESET_7b1]; - p->feat._7d2 = fs[FEATURESET_7d2]; - p->feat._7c1 = fs[FEATURESET_7c1]; - p->feat._7d1 = fs[FEATURESET_7d1]; -} +/** + * Copy the featureset words back into a cpu_policy object. + */ +void x86_cpu_featureset_to_policy(const uint32_t fs[FEATURESET_NR_ENTRIES], + struct cpu_policy *p); static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p) { diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index e81f76c779c0..734e90823a63 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -60,6 +60,48 @@ const char *x86_cpuid_vendor_to_str(unsigned int vendor) } } +void x86_cpu_policy_to_featureset( + const struct cpu_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) +{ + fs[FEATURESET_1d] = p->basic._1d; + fs[FEATURESET_1c] = p->basic._1c; + fs[FEATURESET_e1d] = p->extd.e1d; + fs[FEATURESET_e1c] = p->extd.e1c; + fs[FEATURESET_Da1] = p->xstate.Da1; + fs[FEATURESET_7b0] = p->feat._7b0; + fs[FEATURESET_7c0] = p->feat._7c0; + fs[FEATURESET_e7d] = p->extd.e7d; + fs[FEATURESET_e8b] = p->extd.e8b; + fs[FEATURESET_7d0] = p->feat._7d0; + fs[FEATURESET_7a1] = p->feat._7a1; + fs[FEATURESET_e21a] = p->extd.e21a; + fs[FEATURESET_7b1] = p->feat._7b1; + fs[FEATURESET_7d2] = p->feat._7d2; + fs[FEATURESET_7c1] = p->feat._7c1; + fs[FEATURESET_7d1] = p->feat._7d1; +} + +void x86_cpu_featureset_to_policy( + const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpu_policy *p) +{ + p->basic._1d = fs[FEATURESET_1d]; + p->basic._1c = fs[FEATURESET_1c]; + p->extd.e1d = fs[FEATURESET_e1d]; + p->extd.e1c = fs[FEATURESET_e1c]; + p->xstate.Da1 = fs[FEATURESET_Da1]; + p->feat._7b0 = fs[FEATURESET_7b0]; + p->feat._7c0 = fs[FEATURESET_7c0]; + p->extd.e7d = fs[FEATURESET_e7d]; + p->extd.e8b = fs[FEATURESET_e8b]; + p->feat._7d0 = fs[FEATURESET_7d0]; + p->feat._7a1 = fs[FEATURESET_7a1]; + p->extd.e21a = fs[FEATURESET_e21a]; + p->feat._7b1 = fs[FEATURESET_7b1]; + p->feat._7d2 = fs[FEATURESET_7d2]; + p->feat._7c1 = fs[FEATURESET_7c1]; + p->feat._7d1 = fs[FEATURESET_7d1]; +} + void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p) { p->x86_vendor = x86_cpuid_lookup_vendor( -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517709.803450 (Exim 4.92) (envelope-from ) id 1pjdLH-00056z-C4; Tue, 04 Apr 2023 09:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517709.803450; Tue, 04 Apr 2023 09:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLH-00056s-9R; Tue, 04 Apr 2023 09:52:43 +0000 Received: by outflank-mailman (input) for mailman id 517709; Tue, 04 Apr 2023 09:52:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLF-00056d-Oj for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6de41a44-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:52:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6de41a44-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601958; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yusP9sqEdAZaFQzY4EzOz4zVJrPEbY9vi/S0gYtOA9g=; b=B5JQhePuqD6Lt87DrutIo4qUR9ovRVw5Nq4j3mOFPi86L18IR5qTK7yb bG6pWaYepYhUKVcPC+kjBXYbw4hTOTBtC4UBmENXgO/JZpXA/B8+2+AoU uUPWn2Q46ABlHzDQjWFJMRDjmskZ5XCWlszrNey/ujeIHHjbnJY0GbuXr c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104656504 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:UXTOm601L5VneFYFKPbD5axxkn2cJEfYwER7XKvMYLTBsI5bp2MOn zZKUG7QPfeJYDH8KNslboSw9k4E7cCGz9dmTwJkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHT5o3 /AiIQw3MB2Fht6S55KDVeAymZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJ0JwBvG+ zqal4j/Kj8Vbv+w6Be7y2mHo9TTnw7Ae7w/KLLto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jY+cddNF+wx6CmW17HZpQ2eAwAsUTppeNEg8sgsSlQXO kShxo2zQ2Y16fvMFCzbr+3Pxd+vBcQLBXNdQwUIdwI52YfupoAPqjXvdslqTrHg27UZBgrML yC2QDkW3utD1ZNUif/kpDgrkBr3+MGXE1ddChH/Gzv8s1gnPNPNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83oJrW7FF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPdLpVph0nPK7T4q1PhwxUjapSsEpHDJrAQk0PRLAt4wTuBNEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqLH/jTlk33uYdykVbJEd/pxnPSNLFmhE5FyS2Jm +ti2zyikEoADLenPnaOoeb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:GRI8zauwCmGdDUojUt+TfATN7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104656504" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 00/15] x86: Merge cpuid and msr policy objects Date: Tue, 4 Apr 2023 10:52:07 +0100 Message-ID: <20230404095222.1373721-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is in order to be able to put MSR_ARCH_CAPS in a featureset. In hindsight it was a mistake separating CPUID and read-only MSR data into separate structs. Patches 1-8 were posted previously and have had the feedback addressed. Patches 9-15 are the result of splitting the older RFC patch 9 apart, with the discussed adjustment to aliases accounted for. Gitlab run showing the series to be buildable at each changeset: https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4053607867 P.S. I'm not sure I believe the net diffstat below. I think the cpuid.c => cpu-policy.c rename is confusing it. Andrew Cooper (15): x86: Rename struct cpu_policy to struct old_cpuid_policy x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields x86: Rename struct cpuid_policy to struct cpu_policy x86: Merge struct msr_policy into struct cpu_policy x86: Merge the system {cpuid,msr} policy objects x86: Merge a domain's {cpuid,msr} policy objects x86: Merge xc_cpu_policy's cpuid and msr objects x86: Drop struct old_cpu_policy x86: Out-of-inline the policy<->featureset convertors x86/boot: Move MSR policy initialisation logic into cpu-policy.c x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c x86/emul: Switch x86_emulate_ctxt to cpu_policy tools/fuzz: Rework afl-policy-fuzzer libx86: Update library API for cpu_policy x86: Remove temporary {cpuid,msr}_policy defines tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 64 +- .../fuzz/x86_instruction_emulator/fuzz-emul.c | 2 +- tools/libs/guest/xg_cpuid_x86.c | 50 +- tools/libs/guest/xg_private.h | 5 +- tools/tests/cpu-policy/test-cpu-policy.c | 54 +- tools/tests/tsx/test-tsx.c | 71 +- tools/tests/x86_emulator/Makefile | 2 +- tools/tests/x86_emulator/test_x86_emulator.c | 2 +- tools/tests/x86_emulator/x86-emulate.c | 4 +- tools/tests/x86_emulator/x86-emulate.h | 2 +- xen/arch/x86/Makefile | 1 + xen/arch/x86/{cpuid.c => cpu-policy.c} | 692 ++++---------- xen/arch/x86/cpu/common.c | 4 +- xen/arch/x86/cpu/mcheck/mce_intel.c | 2 +- xen/arch/x86/cpuid.c | 856 +----------------- xen/arch/x86/domain.c | 17 +- xen/arch/x86/domctl.c | 51 +- xen/arch/x86/hvm/emulate.c | 4 +- xen/arch/x86/hvm/hvm.c | 5 +- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/vlapic.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 8 +- xen/arch/x86/include/asm/cpu-policy.h | 27 + xen/arch/x86/include/asm/cpuid.h | 21 +- xen/arch/x86/include/asm/domain.h | 13 +- xen/arch/x86/include/asm/msr.h | 14 +- xen/arch/x86/mm/mem_sharing.c | 3 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/msr.c | 160 +--- xen/arch/x86/pv/domain.c | 3 +- xen/arch/x86/pv/emul-priv-op.c | 6 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/setup.c | 5 +- xen/arch/x86/sysctl.c | 79 +- xen/arch/x86/traps.c | 2 +- xen/arch/x86/x86_emulate/private.h | 4 +- xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.h | 9 +- xen/arch/x86/xstate.c | 4 +- xen/include/public/domctl.h | 4 +- xen/include/public/sysctl.h | 4 +- xen/include/xen/lib/x86/cpu-policy.h | 510 ++++++++++- xen/include/xen/lib/x86/cpuid.h | 475 ---------- xen/include/xen/lib/x86/msr.h | 104 --- xen/lib/x86/cpuid.c | 68 +- xen/lib/x86/msr.c | 6 +- xen/lib/x86/policy.c | 8 +- 47 files changed, 1005 insertions(+), 2430 deletions(-) copy xen/arch/x86/{cpuid.c => cpu-policy.c} (52%) create mode 100644 xen/arch/x86/include/asm/cpu-policy.h delete mode 100644 xen/include/xen/lib/x86/cpuid.h delete mode 100644 xen/include/xen/lib/x86/msr.h -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517715.803509 (Exim 4.92) (envelope-from ) id 1pjdLN-0006c1-JQ; Tue, 04 Apr 2023 09:52:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517715.803509; Tue, 04 Apr 2023 09:52:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLN-0006bS-D8; Tue, 04 Apr 2023 09:52:49 +0000 Received: by outflank-mailman (input) for mailman id 517715; Tue, 04 Apr 2023 09:52:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLL-0005bo-RA for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:48 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72bcdab1-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:52:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72bcdab1-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LIoXi1ZnCa4bmwRZ1DkqTbadm8IWoD0szu1Mk05QyrI=; b=EB8sJLmqiDRgiMc11ykK76kB3fOu2av1Q7msVMhaFmno2RVkTNY8UDJH DTnuYUUkpt7PyodeHLk8xriIjUJhSw7B4j4XaTn42qD8TwdSzUtYdEGUa xi1aiDMpeyYPmu3o4uIdPo5OTfPMq/UwBQd+vhR539IwHFooEjScot1yh c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104275103 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:cy1kG65e3HpQFt0c1t7M3gxRtEfHchMFZxGqfqrLsTDasY5as4F+v jAcD2yCOKrbYzOhKdwiPdy/p0oOsJTRnYBrGVZrpStmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz PoRJxw3Sz+/mfuG+O+CbNsr3v8FFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9xx7E/ D2bpjyiav0cHOaa1Ced/UqourTGnw6nXIM7Hbj/z+E/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1Zpd9gOpMIwAzsw2 Te0c8jBXGI19ufPEDTEq+nS9GnpUcQIEYMcTRYCRAQp2fzMnJ8qviqSd/BRV/aOqOSgTFkc3 Au2QDgCa6Q71JBbj/jkowqY2lpAtbCSEFdru1y/snaNq1ogOdX7P9HABU3zt64oEWqPcrWWU JHoceC65ftGM5yCnTflrA4lTODwvKbt3NExbDdS83gdG9eFoSTLkXh4um0WGauQGp9slcXVS EHSoxhNw5RYIWGna6R6C6roVZRykPS+RI6+DK6EBjarXnSWXFbflByCmGbKhzy9+KTSufpX1 WinnTaEUi9BVPUPIMueTOYBy747rh0DKZfobcmjlXyPiOPODEN5vJ9ZaDNimMhltvLbyOgUm v4DX/a3J+J3C7KhPnOOrdFKfTjn7xETXPjLliCeTcbbSiIOJY3rI6a5LW8JE2C9o5loqw== IronPort-HdrOrdr: A9a23:zRzflaEGZxpovFrjpLqEMceALOsnbusQ8zAXPo5KOHlom7+j5r +TdZUgpGXJYVMqMk3I9urwQZVoLUmslqKdpLNhWotKPzOWw1dATrsSlbcKqgeIc0afygce79 YFT0EXMrzN5DNB/KDHCXyDYqodKbe8gcKVbCTlo0uFjzsGV0it1WhE436gYzBLrcB9a6YEKA == X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104275103" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 06/15] x86: Merge a domain's {cpuid,msr} policy objects Date: Tue, 4 Apr 2023 10:52:13 +0100 Message-ID: <20230404095222.1373721-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Right now, they're the same underlying type, containing disjoint information. Drop the d->arch.msr pointer, and union d->arch.cpuid to give it a second name of cpu_policy in the interim. Merge init_domain_{cpuid,msr}_policy() into a single init_domain_cpu_policy(), moving the implementation into cpu-policy.c No practical change. This undoes the transient doubling of storage space from earlier patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Reword commit message. * Undo accidental deletion of v->arch.msrs. --- xen/arch/x86/cpu-policy.c | 49 +++++++++++++++++++++++++++ xen/arch/x86/cpuid.c | 23 ------------- xen/arch/x86/domain.c | 15 +++----- xen/arch/x86/domctl.c | 35 ++++++++++--------- xen/arch/x86/include/asm/cpu-policy.h | 4 +++ xen/arch/x86/include/asm/cpuid.h | 3 -- xen/arch/x86/include/asm/domain.h | 13 +++++-- xen/arch/x86/include/asm/msr.h | 1 - xen/arch/x86/mm/mem_sharing.c | 3 +- xen/arch/x86/msr.c | 44 ------------------------ 10 files changed, 86 insertions(+), 104 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 663e9a084c53..e9ac1269c35a 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -1,10 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include #include +#include #include #include +#include +#include struct cpu_policy __ro_after_init raw_cpu_policy; struct cpu_policy __ro_after_init host_cpu_policy; @@ -16,3 +19,49 @@ struct cpu_policy __ro_after_init pv_def_cpu_policy; struct cpu_policy __ro_after_init hvm_max_cpu_policy; struct cpu_policy __ro_after_init hvm_def_cpu_policy; #endif + +int init_domain_cpu_policy(struct domain *d) +{ + struct cpu_policy *p = is_pv_domain(d) + ? (IS_ENABLED(CONFIG_PV) ? &pv_def_cpu_policy : NULL) + : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_cpu_policy : NULL); + + if ( !p ) + { + ASSERT_UNREACHABLE(); + return -EOPNOTSUPP; + } + + p = xmemdup(p); + if ( !p ) + return -ENOMEM; + + /* See comment in ctxt_switch_levelling() */ + if ( !opt_dom0_cpuid_faulting && is_control_domain(d) && is_pv_domain(d) ) + p->platform_info.cpuid_faulting = false; + + /* + * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0, + * so dom0 can turn off workarounds as appropriate. Temporary, until the + * domain policy logic gains a better understanding of MSRs. + */ + if ( is_hardware_domain(d) && cpu_has_arch_caps ) + { + uint64_t val; + + rdmsrl(MSR_ARCH_CAPABILITIES, val); + + p->arch_caps.raw = val & + (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | + ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | ARCH_CAPS_IF_PSCHANGE_MC_NO | + ARCH_CAPS_TAA_NO | ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | + ARCH_CAPS_PSDP_NO | ARCH_CAPS_FB_CLEAR | ARCH_CAPS_RRSBA | + ARCH_CAPS_BHI_NO | ARCH_CAPS_PBRSB_NO); + } + + d->arch.cpu_policy = p; + + recalculate_cpuid_policy(d); + + return 0; +} diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 0916bfe175c8..df3e503ced9d 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -784,29 +784,6 @@ void recalculate_cpuid_policy(struct domain *d) p->extd.raw[0x19] = EMPTY_LEAF; } -int init_domain_cpuid_policy(struct domain *d) -{ - struct cpuid_policy *p = is_pv_domain(d) - ? (IS_ENABLED(CONFIG_PV) ? &pv_def_cpu_policy : NULL) - : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_cpu_policy : NULL); - - if ( !p ) - { - ASSERT_UNREACHABLE(); - return -EOPNOTSUPP; - } - - p = xmemdup(p); - if ( !p ) - return -ENOMEM; - - d->arch.cpuid = p; - - recalculate_cpuid_policy(d); - - return 0; -} - void __init init_dom0_cpuid_policy(struct domain *d) { struct cpuid_policy *p = d->arch.cpuid; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index d5847f70f890..b23e5014d1d3 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -66,6 +66,7 @@ #ifdef CONFIG_COMPAT #include #endif +#include #include #include #include @@ -743,8 +744,7 @@ int arch_domain_create(struct domain *d, d->arch.ctxt_switch = &idle_csw; - d->arch.cpuid = ZERO_BLOCK_PTR; /* Catch stray misuses. */ - d->arch.msr = ZERO_BLOCK_PTR; + d->arch.cpu_policy = ZERO_BLOCK_PTR; /* Catch stray misuses. */ return 0; } @@ -799,10 +799,7 @@ int arch_domain_create(struct domain *d, goto fail; paging_initialised = true; - if ( (rc = init_domain_cpuid_policy(d)) ) - goto fail; - - if ( (rc = init_domain_msr_policy(d)) ) + if ( (rc = init_domain_cpu_policy(d)) ) goto fail; d->arch.ioport_caps = @@ -873,8 +870,7 @@ int arch_domain_create(struct domain *d, iommu_domain_destroy(d); cleanup_domain_irq_mapping(d); free_xenheap_page(d->shared_info); - xfree(d->arch.cpuid); - xfree(d->arch.msr); + XFREE(d->arch.cpu_policy); if ( paging_initialised ) paging_final_teardown(d); free_perdomain_mappings(d); @@ -888,8 +884,7 @@ void arch_domain_destroy(struct domain *d) hvm_domain_destroy(d); xfree(d->arch.e820); - xfree(d->arch.cpuid); - xfree(d->arch.msr); + XFREE(d->arch.cpu_policy); free_domain_pirqs(d); if ( !is_idle_domain(d) ) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 5800bb10bc4a..81be25c67731 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -40,11 +40,11 @@ static int update_domain_cpu_policy(struct domain *d, xen_domctl_cpu_policy_t *xdpc) { - struct old_cpu_policy new = {}; + struct cpu_policy *new; struct cpu_policy *sys = is_pv_domain(d) ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); - struct old_cpu_policy old_sys = { sys, sys }; + struct old_cpu_policy old_sys = { sys, sys }, old_new; struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; int ret = -ENOMEM; @@ -54,33 +54,33 @@ static int update_domain_cpu_policy(struct domain *d, return -EOPNOTSUPP; } - /* Start by copying the domain's existing policies. */ - if ( !(new.cpuid = xmemdup(d->arch.cpuid)) || - !(new.msr = xmemdup(d->arch.msr)) ) + /* Start by copying the domain's existing policy. */ + if ( !(new = xmemdup(d->arch.cpu_policy)) ) goto out; + old_new = (struct old_cpu_policy){ new, new }; + /* Merge the toolstack provided data. */ if ( (ret = x86_cpuid_copy_from_buffer( - new.cpuid, xdpc->leaves, xdpc->nr_leaves, + new, xdpc->leaves, xdpc->nr_leaves, &err.leaf, &err.subleaf)) || (ret = x86_msr_copy_from_buffer( - new.msr, xdpc->msrs, xdpc->nr_msrs, &err.msr)) ) + new, xdpc->msrs, xdpc->nr_msrs, &err.msr)) ) goto out; /* Trim any newly-stale out-of-range leaves. */ - x86_cpuid_policy_clear_out_of_range_leaves(new.cpuid); + x86_cpuid_policy_clear_out_of_range_leaves(new); /* Audit the combined dataset. */ - ret = x86_cpu_policies_are_compatible(&old_sys, &new, &err); + ret = x86_cpu_policies_are_compatible(&old_sys, &old_new, &err); if ( ret ) goto out; /* - * Audit was successful. Replace existing policies, leaving the old - * policies to be freed. + * Audit was successful. Replace the existing policy, leaving the old one + * to be freed. */ - SWAP(new.cpuid, d->arch.cpuid); - SWAP(new.msr, d->arch.msr); + SWAP(new, d->arch.cpu_policy); /* TODO: Drop when x86_cpu_policies_are_compatible() is completed. */ recalculate_cpuid_policy(d); @@ -89,9 +89,8 @@ static int update_domain_cpu_policy(struct domain *d, domain_cpu_policy_changed(d); out: - /* Free whichever cpuid/msr structs are not installed in struct domain. */ - xfree(new.cpuid); - xfree(new.msr); + /* Free whichever struct is not installed in struct domain. */ + xfree(new); if ( ret ) { @@ -1327,7 +1326,7 @@ long arch_do_domctl( if ( guest_handle_is_null(domctl->u.cpu_policy.leaves) ) domctl->u.cpu_policy.nr_leaves = CPUID_MAX_SERIALISED_LEAVES; else if ( (ret = x86_cpuid_copy_to_buffer( - d->arch.cpuid, + d->arch.cpu_policy, domctl->u.cpu_policy.leaves, &domctl->u.cpu_policy.nr_leaves)) ) break; @@ -1336,7 +1335,7 @@ long arch_do_domctl( if ( guest_handle_is_null(domctl->u.cpu_policy.msrs) ) domctl->u.cpu_policy.nr_msrs = MSR_MAX_SERIALISED_ENTRIES; else if ( (ret = x86_msr_copy_to_buffer( - d->arch.msr, + d->arch.cpu_policy, domctl->u.cpu_policy.msrs, &domctl->u.cpu_policy.nr_msrs)) ) break; diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h index eef14bb4267e..9ba34bbf5ea1 100644 --- a/xen/arch/x86/include/asm/cpu-policy.h +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -3,6 +3,7 @@ #define X86_CPU_POLICY_H struct cpu_policy; +struct domain; extern struct cpu_policy raw_cpu_policy; extern struct cpu_policy host_cpu_policy; @@ -11,4 +12,7 @@ extern struct cpu_policy pv_def_cpu_policy; extern struct cpu_policy hvm_max_cpu_policy; extern struct cpu_policy hvm_def_cpu_policy; +/* Allocate and initialise a CPU policy suitable for the domain. */ +int init_domain_cpu_policy(struct domain *d); + #endif /* X86_CPU_POLICY_H */ diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h index ea0586277331..7f81b998ce01 100644 --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -49,9 +49,6 @@ extern struct cpuidmasks cpuidmask_defaults; /* Check that all previously present features are still available. */ bool recheck_cpu_features(unsigned int cpu); -/* Allocate and initialise a CPUID policy suitable for the domain. */ -int init_domain_cpuid_policy(struct domain *d); - /* Apply dom0-specific tweaks to the CPUID policy. */ void init_dom0_cpuid_policy(struct domain *d); diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h index 17780ad9db2f..466388a98e12 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -386,9 +386,16 @@ struct arch_domain */ uint8_t x87_fip_width; - /* CPUID and MSR policy objects. */ - struct cpuid_policy *cpuid; - struct msr_policy *msr; + /* + * The domain's CPU Policy. "cpu_policy" is considered the canonical + * pointer, but the "cpuid" and "msr" aliases exist so the most + * appropriate one can be used for local code clarity. + */ + union { + struct cpu_policy *cpu_policy; + struct cpu_policy *cpuid; + struct cpu_policy *msr; + }; struct PITState vpit; diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 022230acc0af..b59a51d238a7 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -419,7 +419,6 @@ struct vcpu_msrs }; void init_guest_msr_policy(void); -int init_domain_msr_policy(struct domain *d); int init_vcpu_msr_policy(struct vcpu *v); /* diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 649d93dc5444..5b3449db7a11 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1902,8 +1902,7 @@ static int fork(struct domain *cd, struct domain *d) domain_pause(d); cd->max_pages = d->max_pages; - *cd->arch.cpuid = *d->arch.cpuid; - *cd->arch.msr = *d->arch.msr; + *cd->arch.cpu_policy = *d->arch.cpu_policy; cd->vmtrace_size = d->vmtrace_size; cd->parent = d; } diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index bff26bc4e2b5..93bd93feb644 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -122,50 +122,6 @@ void __init init_guest_msr_policy(void) } } -int init_domain_msr_policy(struct domain *d) -{ - struct msr_policy *mp = is_pv_domain(d) - ? (IS_ENABLED(CONFIG_PV) ? &pv_def_cpu_policy : NULL) - : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_cpu_policy : NULL); - - if ( !mp ) - { - ASSERT_UNREACHABLE(); - return -EOPNOTSUPP; - } - - mp = xmemdup(mp); - if ( !mp ) - return -ENOMEM; - - /* See comment in ctxt_switch_levelling() */ - if ( !opt_dom0_cpuid_faulting && is_control_domain(d) && is_pv_domain(d) ) - mp->platform_info.cpuid_faulting = false; - - /* - * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0, - * so dom0 can turn off workarounds as appropriate. Temporary, until the - * domain policy logic gains a better understanding of MSRs. - */ - if ( is_hardware_domain(d) && cpu_has_arch_caps ) - { - uint64_t val; - - rdmsrl(MSR_ARCH_CAPABILITIES, val); - - mp->arch_caps.raw = val & - (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | - ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | ARCH_CAPS_IF_PSCHANGE_MC_NO | - ARCH_CAPS_TAA_NO | ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | - ARCH_CAPS_PSDP_NO | ARCH_CAPS_FB_CLEAR | ARCH_CAPS_RRSBA | - ARCH_CAPS_BHI_NO | ARCH_CAPS_PBRSB_NO); - } - - d->arch.msr = mp; - - return 0; -} - int init_vcpu_msr_policy(struct vcpu *v) { struct vcpu_msrs *msrs = xzalloc(struct vcpu_msrs); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517711.803470 (Exim 4.92) (envelope-from ) id 1pjdLK-0005cY-09; Tue, 04 Apr 2023 09:52:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517711.803470; Tue, 04 Apr 2023 09:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLJ-0005cM-Su; Tue, 04 Apr 2023 09:52:45 +0000 Received: by outflank-mailman (input) for mailman id 517711; Tue, 04 Apr 2023 09:52:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLI-00056d-HN for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:44 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70eae744-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:52:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70eae744-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601962; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aLMfsVFJMPWfdGfDVV87nevqNr05P5LkUPZ6r3/rMcw=; b=IAJ1862dGKNvFB/BTlLqBMI1KFmgaP4pS38PwQOZBK4kWd3N7pJEO9DL b6d4u0QMrtoCU+shhxXmc6p+gda0cfszpM9pCYDmrgH4asbhbh1t9Cwt2 EGonPLpEOypR67dLz71cuvY09Kae3+X2JzOc4bxJbMHovM59yBzIIK8hl Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104656513 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:we0psq/4EOmL4Du6egCdDrUD/36TJUtcMsCJ2f8bNWPcYEJGY0x3n DQXWj2FbKzcYWD1fN9/bN628UoHv8eEydVqHQtprn08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklrp cBIEigHRCrbrP2t5vW/WM0ruPo8eZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0MxhrG+ zybpj+R7hcyEfy/wzCb0k6XmsDTkAHKQ6c5MJeH+as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJhZebPQ2uclwQiYlv mJlhPuwW2Yp6ufMDyvAqPHN92ja1TUpwXEqQH84HTEd6fPZ+KoslTSISsRHV5CLkYigcd3v+ AxmvBTSlp1K055Tivrlpw+e696/jsOXF1Bov207Skrgt1okP9D9OuRE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFBz3oRZPhagKvFlDyL5Ba67ogwPBb k7Joh9275ROJnasZqIfS9vvW5x3kfaxT4+/CKC8gj9yjn9ZLVfvwc2TTRTIgzCFfLYEysnTx qt3ge7zVC1HWMyLPRK9RvsH0K9D+x3SMVj7HMihpzz+iOr2WZJgYetdWLd4RrxjvfzsTcS82 4o3CvZmPD0ED7KiOHCLrtdDRb3IRFBiba3LRwVsXrbrCmJb9KsJUZc9HZtJl1RZoplo IronPort-HdrOrdr: A9a23:enJGDKjcmqWppJkVrY3NCTzegnBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104656513" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 01/15] x86: Rename struct cpu_policy to struct old_cpuid_policy Date: Tue, 4 Apr 2023 10:52:08 +0100 Message-ID: <20230404095222.1373721-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit We want to merge struct cpuid_policy and struct msr_policy together, and the result wants to be called struct cpu_policy. The current struct cpu_policy, being a pair of pointers, isn't terribly useful. Rename the type to struct old_cpu_policy, but it will disappear entirely once the merge is complete. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- tools/libs/guest/xg_cpuid_x86.c | 4 ++-- tools/tests/cpu-policy/test-cpu-policy.c | 4 ++-- xen/arch/x86/domctl.c | 4 ++-- xen/arch/x86/include/asm/cpuid.h | 2 +- xen/arch/x86/sysctl.c | 4 ++-- xen/include/xen/lib/x86/cpu-policy.h | 6 +++--- xen/lib/x86/policy.c | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 4542878bbe88..1b02bc987af7 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -868,8 +868,8 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch, xc_cpu_policy_t *host, xc_cpu_policy_t *guest) { struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; - struct cpu_policy h = { &host->cpuid, &host->msr }; - struct cpu_policy g = { &guest->cpuid, &guest->msr }; + struct old_cpu_policy h = { &host->cpuid, &host->msr }; + struct old_cpu_policy g = { &guest->cpuid, &guest->msr }; int rc = x86_cpu_policies_are_compatible(&h, &g, &err); if ( !rc ) diff --git a/tools/tests/cpu-policy/test-cpu-policy.c b/tools/tests/cpu-policy/test-cpu-policy.c index d3f24fd6d274..909d6272f875 100644 --- a/tools/tests/cpu-policy/test-cpu-policy.c +++ b/tools/tests/cpu-policy/test-cpu-policy.c @@ -602,7 +602,7 @@ static void test_is_compatible_success(void) for ( size_t i = 0; i < ARRAY_SIZE(tests); ++i ) { struct test *t = &tests[i]; - struct cpu_policy sys = { + struct old_cpu_policy sys = { &t->host_cpuid, &t->host_msr, }, new = { @@ -654,7 +654,7 @@ static void test_is_compatible_failure(void) for ( size_t i = 0; i < ARRAY_SIZE(tests); ++i ) { struct test *t = &tests[i]; - struct cpu_policy sys = { + struct old_cpu_policy sys = { &t->host_cpuid, &t->host_msr, }, new = { diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 2118fcad5dfe..0b41b279507e 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -40,8 +40,8 @@ static int update_domain_cpu_policy(struct domain *d, xen_domctl_cpu_policy_t *xdpc) { - struct cpu_policy new = {}; - const struct cpu_policy *sys = is_pv_domain(d) + struct old_cpu_policy new = {}; + const struct old_cpu_policy *sys = is_pv_domain(d) ? &system_policies[XEN_SYSCTL_cpu_policy_pv_max] : &system_policies[XEN_SYSCTL_cpu_policy_hvm_max]; struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h index 9c3637549a10..49b3128f06f9 100644 --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -51,7 +51,7 @@ extern struct cpuid_policy raw_cpuid_policy, host_cpuid_policy, pv_max_cpuid_policy, pv_def_cpuid_policy, hvm_max_cpuid_policy, hvm_def_cpuid_policy; -extern const struct cpu_policy system_policies[]; +extern const struct old_cpu_policy system_policies[]; /* Check that all previously present features are still available. */ bool recheck_cpu_features(unsigned int cpu); diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index 16625b57f01f..3f5b092df16a 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -32,7 +32,7 @@ #include #include -const struct cpu_policy system_policies[6] = { +const struct old_cpu_policy system_policies[6] = { [ XEN_SYSCTL_cpu_policy_raw ] = { &raw_cpuid_policy, &raw_msr_policy, @@ -391,7 +391,7 @@ long arch_do_sysctl( case XEN_SYSCTL_get_cpu_policy: { - const struct cpu_policy *policy; + const struct old_cpu_policy *policy; /* Reserved field set, or bad policy index? */ if ( sysctl->u.cpu_policy._rsvd || diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 5a2c4c7b2d90..3a5300d1078c 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -5,7 +5,7 @@ #include #include -struct cpu_policy +struct old_cpu_policy { struct cpuid_policy *cpuid; struct msr_policy *msr; @@ -33,8 +33,8 @@ struct cpu_policy_errors * incompatibility is detected, the optional err pointer may identify the * problematic leaf/subleaf and/or MSR. */ -int x86_cpu_policies_are_compatible(const struct cpu_policy *host, - const struct cpu_policy *guest, +int x86_cpu_policies_are_compatible(const struct old_cpu_policy *host, + const struct old_cpu_policy *guest, struct cpu_policy_errors *err); #endif /* !XEN_LIB_X86_POLICIES_H */ diff --git a/xen/lib/x86/policy.c b/xen/lib/x86/policy.c index f6cea4e2f9bd..2975711d7c6c 100644 --- a/xen/lib/x86/policy.c +++ b/xen/lib/x86/policy.c @@ -2,8 +2,8 @@ #include -int x86_cpu_policies_are_compatible(const struct cpu_policy *host, - const struct cpu_policy *guest, +int x86_cpu_policies_are_compatible(const struct old_cpu_policy *host, + const struct old_cpu_policy *guest, struct cpu_policy_errors *err) { struct cpu_policy_errors e = INIT_CPU_POLICY_ERRORS; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517716.803520 (Exim 4.92) (envelope-from ) id 1pjdLP-0006z0-6n; Tue, 04 Apr 2023 09:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517716.803520; Tue, 04 Apr 2023 09:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLP-0006y7-1o; Tue, 04 Apr 2023 09:52:51 +0000 Received: by outflank-mailman (input) for mailman id 517716; Tue, 04 Apr 2023 09:52:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLN-0005bo-Ai for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:49 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 742f8e97-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:52:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 742f8e97-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601967; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9UHULmNeog4OHP6x3IyWXzySNECyTqt0kgFmTV9Rc0k=; b=IK9AzNLBAoh2XvuW4teqM9D3HYqjy1lkNvNy4Fijj04eQXjLcHu2yzSW pHu2QuGXLqUJ9+Pw+ApWjcAxbbDuS03H6pVlniQhg89SGTkQQKep/nf7p 99JlWV0xEreuhWI+/TI5u1qy6xEm8P+DNdJkoUwfINPRhdRG8LtkXJ0zB A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106670672 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:I3hCz6wXoWh3baxkQiN6t+dIxirEfRIJ4+MujC+fZmUNrF6WrkUFz TYWUDyGOqrcN2X0eYsiYIXj80gPusSHz9Y1TFNoriAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRiPawT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXlM2 Ow+OD8vVEySvOW82Jfic7k9ptt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZwNwBjH/ jyZpQwVBDk5C5+BmAWeo0muufDU3grwY4EdHqa3o6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC6 7OSt4q3X3o16uTTEC/DsO7O9lteJBT5M0caZwIUaxsKweO/sbo0hArqF+8zQY6q24id9S7L/ 9yakMQvr+xN3ZZWiPvhogmvbyGE/caQEFNsjunDdif8t14iOtb4D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XC3273k5JbVdoMiAyS3W8wWir+RRfnY VXIpSRa74JJMX2hYMdfOtzhU5l2k/m6To67Bpg4i+aihbAoLGe6ENxGPxbMjwgBbmB3+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHcqT503+gdKjiIu9Fe9t3K2mMrpos8tpYWz9r 75iCid9404AD7GkO3WIqN57wJJjBSFTOK0aYvd/LoarSjeK0kl4YxMN6dvNo7BYopk= IronPort-HdrOrdr: A9a23:ZQBS36OH2TnlpcBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="106670672" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 07/15] x86: Merge xc_cpu_policy's cpuid and msr objects Date: Tue, 4 Apr 2023 10:52:14 +0100 Message-ID: <20230404095222.1373721-8-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Right now, they're the same underlying type, containing disjoint information. Use a single object instead. Also take the opportunity to rename 'entries' to 'msrs' which is more descriptive, and more in line with nr_msrs being the count of MSR entries in the API. test-tsx uses xg_private.h to access the internals of xc_cpu_policy, so needs updating at the same time. Take the opportunity to improve the code clarity by passing a cpu_policy rather than an xc_cpu_policy into some functions. No practical change. This undoes the transient doubling of storage space from earlier patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Reword the commit message. * Clean up test-tsx a bit more. --- tools/libs/guest/xg_cpuid_x86.c | 36 ++++++++--------- tools/libs/guest/xg_private.h | 5 +-- tools/tests/tsx/test-tsx.c | 71 +++++++++++++++------------------ 3 files changed, 53 insertions(+), 59 deletions(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 5fae06e77804..5061fe357767 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -431,7 +431,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, xc_dominfo_t di; unsigned int i, nr_leaves, nr_msrs; xen_cpuid_leaf_t *leaves = NULL; - struct cpuid_policy *p = NULL; + struct cpu_policy *p = NULL; uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; uint32_t host_featureset[FEATURESET_NR_ENTRIES] = {}; uint32_t len = ARRAY_SIZE(host_featureset); @@ -692,7 +692,7 @@ static int deserialize_policy(xc_interface *xch, xc_cpu_policy_t *policy, uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; int rc; - rc = x86_cpuid_copy_from_buffer(&policy->cpuid, policy->leaves, + rc = x86_cpuid_copy_from_buffer(&policy->policy, policy->leaves, nr_leaves, &err_leaf, &err_subleaf); if ( rc ) { @@ -702,7 +702,7 @@ static int deserialize_policy(xc_interface *xch, xc_cpu_policy_t *policy, return rc; } - rc = x86_msr_copy_from_buffer(&policy->msr, policy->entries, + rc = x86_msr_copy_from_buffer(&policy->policy, policy->msrs, nr_entries, &err_msr); if ( rc ) { @@ -719,18 +719,18 @@ int xc_cpu_policy_get_system(xc_interface *xch, unsigned int policy_idx, xc_cpu_policy_t *policy) { unsigned int nr_leaves = ARRAY_SIZE(policy->leaves); - unsigned int nr_entries = ARRAY_SIZE(policy->entries); + unsigned int nr_msrs = ARRAY_SIZE(policy->msrs); int rc; rc = get_system_cpu_policy(xch, policy_idx, &nr_leaves, policy->leaves, - &nr_entries, policy->entries); + &nr_msrs, policy->msrs); if ( rc ) { PERROR("Failed to obtain %u policy", policy_idx); return rc; } - rc = deserialize_policy(xch, policy, nr_leaves, nr_entries); + rc = deserialize_policy(xch, policy, nr_leaves, nr_msrs); if ( rc ) { errno = -rc; @@ -744,18 +744,18 @@ int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, xc_cpu_policy_t *policy) { unsigned int nr_leaves = ARRAY_SIZE(policy->leaves); - unsigned int nr_entries = ARRAY_SIZE(policy->entries); + unsigned int nr_msrs = ARRAY_SIZE(policy->msrs); int rc; rc = get_domain_cpu_policy(xch, domid, &nr_leaves, policy->leaves, - &nr_entries, policy->entries); + &nr_msrs, policy->msrs); if ( rc ) { PERROR("Failed to obtain domain %u policy", domid); return rc; } - rc = deserialize_policy(xch, policy, nr_leaves, nr_entries); + rc = deserialize_policy(xch, policy, nr_leaves, nr_msrs); if ( rc ) { errno = -rc; @@ -770,16 +770,16 @@ int xc_cpu_policy_set_domain(xc_interface *xch, uint32_t domid, { uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; unsigned int nr_leaves = ARRAY_SIZE(policy->leaves); - unsigned int nr_entries = ARRAY_SIZE(policy->entries); + unsigned int nr_msrs = ARRAY_SIZE(policy->msrs); int rc; rc = xc_cpu_policy_serialise(xch, policy, policy->leaves, &nr_leaves, - policy->entries, &nr_entries); + policy->msrs, &nr_msrs); if ( rc ) return rc; rc = xc_set_domain_cpu_policy(xch, domid, nr_leaves, policy->leaves, - nr_entries, policy->entries, + nr_msrs, policy->msrs, &err_leaf, &err_subleaf, &err_msr); if ( rc ) { @@ -802,7 +802,7 @@ int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t *p, if ( leaves ) { - rc = x86_cpuid_copy_to_buffer(&p->cpuid, leaves, nr_leaves); + rc = x86_cpuid_copy_to_buffer(&p->policy, leaves, nr_leaves); if ( rc ) { ERROR("Failed to serialize CPUID policy"); @@ -813,7 +813,7 @@ int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t *p, if ( msrs ) { - rc = x86_msr_copy_to_buffer(&p->msr, msrs, nr_msrs); + rc = x86_msr_copy_to_buffer(&p->policy, msrs, nr_msrs); if ( rc ) { ERROR("Failed to serialize MSR policy"); @@ -831,7 +831,7 @@ int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t *policy, uint32_t nr) { unsigned int err_leaf = -1, err_subleaf = -1; - int rc = x86_cpuid_copy_from_buffer(&policy->cpuid, leaves, nr, + int rc = x86_cpuid_copy_from_buffer(&policy->policy, leaves, nr, &err_leaf, &err_subleaf); if ( rc ) @@ -850,7 +850,7 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t *policy, const xen_msr_entry_t *msrs, uint32_t nr) { unsigned int err_msr = -1; - int rc = x86_msr_copy_from_buffer(&policy->msr, msrs, nr, &err_msr); + int rc = x86_msr_copy_from_buffer(&policy->policy, msrs, nr, &err_msr); if ( rc ) { @@ -868,8 +868,8 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch, xc_cpu_policy_t *host, xc_cpu_policy_t *guest) { struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; - struct old_cpu_policy h = { &host->cpuid, &host->msr }; - struct old_cpu_policy g = { &guest->cpuid, &guest->msr }; + struct old_cpu_policy h = { &host->policy, &host->policy }; + struct old_cpu_policy g = { &guest->policy, &guest->policy }; int rc = x86_cpu_policies_are_compatible(&h, &g, &err); if ( !rc ) diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 09e24f122760..e729a8106c3e 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -173,10 +173,9 @@ int pin_table(xc_interface *xch, unsigned int type, unsigned long mfn, #include struct xc_cpu_policy { - struct cpuid_policy cpuid; - struct msr_policy msr; + struct cpu_policy policy; xen_cpuid_leaf_t leaves[CPUID_MAX_SERIALISED_LEAVES]; - xen_msr_entry_t entries[MSR_MAX_SERIALISED_ENTRIES]; + xen_msr_entry_t msrs[MSR_MAX_SERIALISED_ENTRIES]; }; #endif /* x86 */ diff --git a/tools/tests/tsx/test-tsx.c b/tools/tests/tsx/test-tsx.c index d6d98c299bf9..b7e1972ce8a7 100644 --- a/tools/tests/tsx/test-tsx.c +++ b/tools/tests/tsx/test-tsx.c @@ -151,15 +151,15 @@ static void test_tsx_msrs(void) { printf("Testing MSR_TSX_FORCE_ABORT consistency\n"); test_tsx_msr_consistency( - MSR_TSX_FORCE_ABORT, host.cpuid.feat.tsx_force_abort); + MSR_TSX_FORCE_ABORT, host.policy.feat.tsx_force_abort); printf("Testing MSR_TSX_CTRL consistency\n"); test_tsx_msr_consistency( - MSR_TSX_CTRL, host.msr.arch_caps.tsx_ctrl); + MSR_TSX_CTRL, host.policy.arch_caps.tsx_ctrl); printf("Testing MSR_MCU_OPT_CTRL consistency\n"); test_tsx_msr_consistency( - MSR_MCU_OPT_CTRL, host.cpuid.feat.srbds_ctrl); + MSR_MCU_OPT_CTRL, host.policy.feat.srbds_ctrl); } /* @@ -281,7 +281,7 @@ static void test_rtm_behaviour(void) else return fail(" Got unexpected behaviour %d\n", rtm_behaviour); - if ( host.cpuid.feat.rtm ) + if ( host.policy.feat.rtm ) { if ( rtm_behaviour == RTM_UD ) fail(" Host reports RTM, but appears unavailable\n"); @@ -293,57 +293,52 @@ static void test_rtm_behaviour(void) } } -static void dump_tsx_details(const struct xc_cpu_policy *p, const char *pref) +static void dump_tsx_details(const struct cpu_policy *p, const char *pref) { printf(" %s RTM %u, HLE %u, TSX_FORCE_ABORT %u, RTM_ALWAYS_ABORT %u, TSX_CTRL %u\n", pref, - p->cpuid.feat.rtm, - p->cpuid.feat.hle, - p->cpuid.feat.tsx_force_abort, - p->cpuid.feat.rtm_always_abort, - p->msr.arch_caps.tsx_ctrl); + p->feat.rtm, + p->feat.hle, + p->feat.tsx_force_abort, + p->feat.rtm_always_abort, + p->arch_caps.tsx_ctrl); } /* Sanity test various invariants we expect in the default/max policies. */ -static void test_guest_policies(const struct xc_cpu_policy *max, - const struct xc_cpu_policy *def) +static void test_guest_policies(const struct cpu_policy *max, + const struct cpu_policy *def) { - const struct cpuid_policy *cm = &max->cpuid; - const struct cpuid_policy *cd = &def->cpuid; - const struct msr_policy *mm = &max->msr; - const struct msr_policy *md = &def->msr; - dump_tsx_details(max, "Max:"); dump_tsx_details(def, "Def:"); - if ( ((cm->feat.raw[0].d | cd->feat.raw[0].d) & + if ( ((max->feat.raw[0].d | def->feat.raw[0].d) & (bitmaskof(X86_FEATURE_TSX_FORCE_ABORT) | bitmaskof(X86_FEATURE_RTM_ALWAYS_ABORT) | bitmaskof(X86_FEATURE_SRBDS_CTRL))) || - ((mm->arch_caps.raw | md->arch_caps.raw) & ARCH_CAPS_TSX_CTRL) ) + ((max->arch_caps.raw | def->arch_caps.raw) & ARCH_CAPS_TSX_CTRL) ) fail(" Xen-only TSX controls offered to guest\n"); switch ( rtm_behaviour ) { case RTM_UD: - if ( (cm->feat.raw[0].b | cd->feat.raw[0].b) & + if ( (max->feat.raw[0].b | def->feat.raw[0].b) & (bitmaskof(X86_FEATURE_HLE) | bitmaskof(X86_FEATURE_RTM)) ) fail(" HLE/RTM offered to guests despite not being available\n"); break; case RTM_ABORT: - if ( cd->feat.raw[0].b & + if ( def->feat.raw[0].b & (bitmaskof(X86_FEATURE_HLE) | bitmaskof(X86_FEATURE_RTM)) ) fail(" HLE/RTM offered to guests by default despite not being usable\n"); break; case RTM_OK: - if ( !cm->feat.rtm || !cd->feat.rtm ) + if ( !max->feat.rtm || !def->feat.rtm ) fail(" RTM not offered to guests despite being available\n"); break; } - if ( cd->feat.hle ) + if ( def->feat.hle ) fail(" Fail: HLE offered in default policy\n"); } @@ -352,13 +347,13 @@ static void test_def_max_policies(void) if ( xen_has_pv ) { printf("Testing PV default/max policies\n"); - test_guest_policies(&pv_max, &pv_default); + test_guest_policies(&pv_max.policy, &pv_default.policy); } if ( xen_has_hvm ) { printf("Testing HVM default/max policies\n"); - test_guest_policies(&hvm_max, &hvm_default); + test_guest_policies(&hvm_max.policy, &hvm_default.policy); } } @@ -382,23 +377,23 @@ static void test_guest(struct xen_domctl_createdomain *c) goto out; } - dump_tsx_details(&guest_policy, "Cur:"); + dump_tsx_details(&guest_policy.policy, "Cur:"); /* * Check defaults given to the guest. */ - if ( guest_policy.cpuid.feat.rtm != (rtm_behaviour == RTM_OK) ) + if ( guest_policy.policy.feat.rtm != (rtm_behaviour == RTM_OK) ) fail(" RTM %u in guest, despite rtm behaviour\n", - guest_policy.cpuid.feat.rtm); + guest_policy.policy.feat.rtm); - if ( guest_policy.cpuid.feat.hle || - guest_policy.cpuid.feat.tsx_force_abort || - guest_policy.cpuid.feat.rtm_always_abort || - guest_policy.cpuid.feat.srbds_ctrl || - guest_policy.msr.arch_caps.tsx_ctrl ) + if ( guest_policy.policy.feat.hle || + guest_policy.policy.feat.tsx_force_abort || + guest_policy.policy.feat.rtm_always_abort || + guest_policy.policy.feat.srbds_ctrl || + guest_policy.policy.arch_caps.tsx_ctrl ) fail(" Unexpected features advertised\n"); - if ( host.cpuid.feat.rtm ) + if ( host.policy.feat.rtm ) { unsigned int _7b0; @@ -406,7 +401,7 @@ static void test_guest(struct xen_domctl_createdomain *c) * If host RTM is available, all combinations of guest flags should be * possible. Flip both HLE/RTM to check non-default settings. */ - _7b0 = (guest_policy.cpuid.feat.raw[0].b ^= + _7b0 = (guest_policy.policy.feat.raw[0].b ^= (bitmaskof(X86_FEATURE_HLE) | bitmaskof(X86_FEATURE_RTM))); /* Set the new policy. */ @@ -427,12 +422,12 @@ static void test_guest(struct xen_domctl_createdomain *c) goto out; } - dump_tsx_details(&guest_policy, "Cur:"); + dump_tsx_details(&guest_policy.policy, "Cur:"); - if ( guest_policy.cpuid.feat.raw[0].b != _7b0 ) + if ( guest_policy.policy.feat.raw[0].b != _7b0 ) { fail(" Expected CPUID.7[1].b 0x%08x differs from actual 0x%08x\n", - _7b0, guest_policy.cpuid.feat.raw[0].b); + _7b0, guest_policy.policy.feat.raw[0].b); goto out; } } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517712.803477 (Exim 4.92) (envelope-from ) id 1pjdLK-0005g8-CZ; Tue, 04 Apr 2023 09:52:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517712.803477; Tue, 04 Apr 2023 09:52:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLK-0005fO-5e; Tue, 04 Apr 2023 09:52:46 +0000 Received: by outflank-mailman (input) for mailman id 517712; Tue, 04 Apr 2023 09:52:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLI-00056d-Rv for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:44 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71331b36-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:52:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71331b36-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601962; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IL5jduQ9wz95TuOVb8Hg3lcqfJg4oc1M0v7wklWBR7U=; b=fqdWjunhNnUkRvKB57Auje5ZtBaKjup87SJp1Mp+1mFJ7h8VO2z2ZQ9m VSRHs5OEyNgf8++03Tl0yYWjo+nUcYK/IwZu7hGG+24Y7xmkEYlIIL3ZG yrHPjG7Vx2ag6RJh5dBMGaavU1qzBkVOqnZhq4mPQriuJLmedpHVF8ijY g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104161363 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:TTtdRaPFHGHio0PvrR3al8FynXyQoLVcMsEvi/4bfWQNrUohhj0Cy WtLWWHXPf+CY2LxfYtxaorn/BgB757Tm9QwTgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sBWOkdp2 u4JE2EicT7Yos+RzeyhRMA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUoXSGZwLxx3G/ Qoq+UzAJwoHCNiulQHC2WCPnPXQ3g/bZYYrQejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxasvBQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBeeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwAzDFQkQgAWXDBUzMbN+6QeqR+RVNhKRfvdYsLOJd3g/ 9ybhHFg1+1O0pBRiPzTEUPv2Gz1+MWQJuIhzkCOBz/+sFskDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKMN8N7n9hV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPEnO9/tVZVwlvK+RbwJs8w4ifIXOvBMmPKvpnkyNSZ8IUi2+KTTrU3PE cjCKpv9ZZrrIa9m0CC3V48g7FPf/QhnnTm7bcmin3yaPU+2OCb9pUEtbAHfMYjULcqs/G3oz jqoH5DVlEkFCbGhO3m/HEx6BQliEEXXzKve86R/HtNv6CI/cI39I5c9GY8cRrE= IronPort-HdrOrdr: A9a23:igteTK1T07G5OI8/NpHhKwqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104161363" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 08/15] x86: Drop struct old_cpu_policy Date: Tue, 4 Apr 2023 10:52:15 +0100 Message-ID: <20230404095222.1373721-9-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit With all the complicated callers of x86_cpu_policies_are_compatible() updated to use a single cpu_policy object, we can drop the final user of struct old_cpu_policy. Update x86_cpu_policies_are_compatible() to take (new) cpu_policy pointers, reducing the amount of internal pointer chasing, and update all callers to pass their cpu_policy objects directly. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Fix host/guest typo in xc_cpu_policy_is_compatible() --- tools/libs/guest/xg_cpuid_x86.c | 4 +- tools/tests/cpu-policy/test-cpu-policy.c | 50 +++++++----------------- xen/arch/x86/domctl.c | 7 +--- xen/include/xen/lib/x86/cpu-policy.h | 12 ++---- xen/lib/x86/policy.c | 12 +++--- 5 files changed, 27 insertions(+), 58 deletions(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 5061fe357767..259029be8b36 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -868,9 +868,7 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch, xc_cpu_policy_t *host, xc_cpu_policy_t *guest) { struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; - struct old_cpu_policy h = { &host->policy, &host->policy }; - struct old_cpu_policy g = { &guest->policy, &guest->policy }; - int rc = x86_cpu_policies_are_compatible(&h, &g, &err); + int rc = x86_cpu_policies_are_compatible(&host->policy, &guest->policy, &err); if ( !rc ) return true; diff --git a/tools/tests/cpu-policy/test-cpu-policy.c b/tools/tests/cpu-policy/test-cpu-policy.c index 909d6272f875..a4ca07f33973 100644 --- a/tools/tests/cpu-policy/test-cpu-policy.c +++ b/tools/tests/cpu-policy/test-cpu-policy.c @@ -98,7 +98,7 @@ static bool msrs_are_sorted(const xen_msr_entry_t *entries, unsigned int nr) static void test_cpuid_current(void) { - struct cpuid_policy p; + struct cpu_policy p; xen_cpuid_leaf_t leaves[CPUID_MAX_SERIALISED_LEAVES]; unsigned int nr = ARRAY_SIZE(leaves); int rc; @@ -118,7 +118,7 @@ static void test_cpuid_current(void) static void test_cpuid_serialise_success(void) { static const struct test { - struct cpuid_policy p; + struct cpu_policy p; const char *name; unsigned int nr_leaves; } tests[] = { @@ -242,7 +242,7 @@ static void test_cpuid_serialise_success(void) static void test_msr_serialise_success(void) { static const struct test { - struct msr_policy p; + struct cpu_policy p; const char *name; unsigned int nr_msrs; } tests[] = { @@ -430,7 +430,7 @@ static void test_cpuid_out_of_range_clearing(void) static const struct test { const char *name; unsigned int nr_markers; - struct cpuid_policy p; + struct cpu_policy p; } tests[] = { { .name = "basic", @@ -550,7 +550,7 @@ static void test_cpuid_out_of_range_clearing(void) for ( size_t i = 0; i < ARRAY_SIZE(tests); ++i ) { const struct test *t = &tests[i]; - struct cpuid_policy *p = memdup(&t->p); + struct cpu_policy *p = memdup(&t->p); void *ptr; unsigned int nr_markers; @@ -574,23 +574,20 @@ static void test_is_compatible_success(void) { static struct test { const char *name; - struct cpuid_policy host_cpuid; - struct cpuid_policy guest_cpuid; - struct msr_policy host_msr; - struct msr_policy guest_msr; + struct cpu_policy host, guest; } tests[] = { { .name = "Host CPUID faulting, Guest not", - .host_msr = { + .host = { .platform_info.cpuid_faulting = true, }, }, { .name = "Host CPUID faulting, Guest wanted", - .host_msr = { + .host = { .platform_info.cpuid_faulting = true, }, - .guest_msr = { + .guest = { .platform_info.cpuid_faulting = true, }, }, @@ -602,15 +599,8 @@ static void test_is_compatible_success(void) for ( size_t i = 0; i < ARRAY_SIZE(tests); ++i ) { struct test *t = &tests[i]; - struct old_cpu_policy sys = { - &t->host_cpuid, - &t->host_msr, - }, new = { - &t->guest_cpuid, - &t->guest_msr, - }; struct cpu_policy_errors e; - int res = x86_cpu_policies_are_compatible(&sys, &new, &e); + int res = x86_cpu_policies_are_compatible(&t->host, &t->guest, &e); /* Check the expected error output. */ if ( res != 0 || memcmp(&no_errors, &e, sizeof(no_errors)) ) @@ -624,25 +614,22 @@ static void test_is_compatible_failure(void) { static struct test { const char *name; - struct cpuid_policy host_cpuid; - struct cpuid_policy guest_cpuid; - struct msr_policy host_msr; - struct msr_policy guest_msr; + struct cpu_policy host, guest; struct cpu_policy_errors e; } tests[] = { { .name = "Host basic.max_leaf out of range", - .guest_cpuid.basic.max_leaf = 1, + .guest.basic.max_leaf = 1, .e = { 0, -1, -1 }, }, { .name = "Host extd.max_leaf out of range", - .guest_cpuid.extd.max_leaf = 1, + .guest.extd.max_leaf = 1, .e = { 0x80000000, -1, -1 }, }, { .name = "Host no CPUID faulting, Guest wanted", - .guest_msr = { + .guest = { .platform_info.cpuid_faulting = true, }, .e = { -1, -1, 0xce }, @@ -654,15 +641,8 @@ static void test_is_compatible_failure(void) for ( size_t i = 0; i < ARRAY_SIZE(tests); ++i ) { struct test *t = &tests[i]; - struct old_cpu_policy sys = { - &t->host_cpuid, - &t->host_msr, - }, new = { - &t->guest_cpuid, - &t->guest_msr, - }; struct cpu_policy_errors e; - int res = x86_cpu_policies_are_compatible(&sys, &new, &e); + int res = x86_cpu_policies_are_compatible(&t->host, &t->guest, &e); /* Check the expected error output. */ if ( res == 0 || memcmp(&t->e, &e, sizeof(t->e)) ) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 81be25c67731..c02528594102 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -41,10 +41,9 @@ static int update_domain_cpu_policy(struct domain *d, xen_domctl_cpu_policy_t *xdpc) { struct cpu_policy *new; - struct cpu_policy *sys = is_pv_domain(d) + const struct cpu_policy *sys = is_pv_domain(d) ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); - struct old_cpu_policy old_sys = { sys, sys }, old_new; struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; int ret = -ENOMEM; @@ -58,8 +57,6 @@ static int update_domain_cpu_policy(struct domain *d, if ( !(new = xmemdup(d->arch.cpu_policy)) ) goto out; - old_new = (struct old_cpu_policy){ new, new }; - /* Merge the toolstack provided data. */ if ( (ret = x86_cpuid_copy_from_buffer( new, xdpc->leaves, xdpc->nr_leaves, @@ -72,7 +69,7 @@ static int update_domain_cpu_policy(struct domain *d, x86_cpuid_policy_clear_out_of_range_leaves(new); /* Audit the combined dataset. */ - ret = x86_cpu_policies_are_compatible(&old_sys, &old_new, &err); + ret = x86_cpu_policies_are_compatible(sys, new, &err); if ( ret ) goto out; diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 53fffca55211..8b27a0725b8e 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -379,12 +379,6 @@ struct cpu_policy #define cpuid_policy cpu_policy #define msr_policy cpu_policy -struct old_cpu_policy -{ - struct cpuid_policy *cpuid; - struct msr_policy *msr; -}; - struct cpu_policy_errors { uint32_t leaf, subleaf; @@ -559,7 +553,7 @@ int x86_msr_copy_from_buffer(struct msr_policy *policy, const msr_entry_buffer_t msrs, uint32_t nr_entries, uint32_t *err_msr); -/* +/** * Calculate whether two policies are compatible. * * i.e. Can a VM configured with @guest run on a CPU supporting @host. @@ -573,8 +567,8 @@ int x86_msr_copy_from_buffer(struct msr_policy *policy, * incompatibility is detected, the optional err pointer may identify the * problematic leaf/subleaf and/or MSR. */ -int x86_cpu_policies_are_compatible(const struct old_cpu_policy *host, - const struct old_cpu_policy *guest, +int x86_cpu_policies_are_compatible(const struct cpu_policy *host, + const struct cpu_policy *guest, struct cpu_policy_errors *err); #endif /* !XEN_LIB_X86_POLICIES_H */ diff --git a/xen/lib/x86/policy.c b/xen/lib/x86/policy.c index 2975711d7c6c..a9c60000af9d 100644 --- a/xen/lib/x86/policy.c +++ b/xen/lib/x86/policy.c @@ -2,8 +2,8 @@ #include -int x86_cpu_policies_are_compatible(const struct old_cpu_policy *host, - const struct old_cpu_policy *guest, +int x86_cpu_policies_are_compatible(const struct cpu_policy *host, + const struct cpu_policy *guest, struct cpu_policy_errors *err) { struct cpu_policy_errors e = INIT_CPU_POLICY_ERRORS; @@ -15,18 +15,18 @@ int x86_cpu_policies_are_compatible(const struct old_cpu_policy *host, #define FAIL_MSR(m) \ do { e.msr = (m); goto out; } while ( 0 ) - if ( guest->cpuid->basic.max_leaf > host->cpuid->basic.max_leaf ) + if ( guest->basic.max_leaf > host->basic.max_leaf ) FAIL_CPUID(0, NA); - if ( guest->cpuid->feat.max_subleaf > host->cpuid->feat.max_subleaf ) + if ( guest->feat.max_subleaf > host->feat.max_subleaf ) FAIL_CPUID(7, 0); - if ( guest->cpuid->extd.max_leaf > host->cpuid->extd.max_leaf ) + if ( guest->extd.max_leaf > host->extd.max_leaf ) FAIL_CPUID(0x80000000, NA); /* TODO: Audit more CPUID data. */ - if ( ~host->msr->platform_info.raw & guest->msr->platform_info.raw ) + if ( ~host->platform_info.raw & guest->platform_info.raw ) FAIL_MSR(MSR_INTEL_PLATFORM_INFO); #undef FAIL_MSR -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517717.803525 (Exim 4.92) (envelope-from ) id 1pjdLP-00074K-Pc; Tue, 04 Apr 2023 09:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517717.803525; Tue, 04 Apr 2023 09:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLP-00072q-EI; Tue, 04 Apr 2023 09:52:51 +0000 Received: by outflank-mailman (input) for mailman id 517717; Tue, 04 Apr 2023 09:52:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLN-00056d-7T for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:49 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71129d6f-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:52:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71129d6f-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601964; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HneZ+FyiXcZ5gyPQXO36bg8Dh9bI0rc/BYX3S3biViY=; b=XOLkP+Qp9vWrMcjAxNov3/hjB2+dj3ygmlmKOaGt+ltkfcGIOnueYnbq DaC1w+NZ2JFaNphpZKZeSy07N082DO/hS4t/r21RXi1bTXGOnDOv5aSvf jgEC9T0kR82hwXv9T1zifq1xXnMrkles5qt8dmaJKCBhU4wQI2Ivtqr68 Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104275102 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:xF1lj6zryNkAuFjMYsx6t+dIxirEfRIJ4+MujC+fZmUNrF6WrkUCy jYcDG/TPfyJMWb1eooga9+0pEsBup/UmtJkTVFt/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRiPawT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVhI/ PM0EhUiUg6at9rr+ZSJDbFXoP12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZwNwhzH+ zuepQwVBDkbO9e1ygTez06Lh82SlDH6G7AIM6Cno6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC6 7OSt4q3X3o16uTTEC/DsO7O9lteJBT5M0c7YyYLYTEgzOX9ubEL0yvpfJE7K4iM24id9S7L/ 9yakMQvr+xN3ZZWiPvhogmvbyGE/caQEFNsjunDdif8t14iOtb4D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XC3273k5JbVdoMiAyS3W8wWir+RRfnY VXIpSRa74JJMX2hYMdfOtzhU5l2k/m6To67Bpg4i+aihbAoLGe6ENxGPxbMjwgBbmB3+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHcqT503+gdKjiIu9Fe9t3K2mMrpos8tpYWz9r 75iCid9404AD7GkO3WIqN57wJJjBSFTOK0aYvd/LoarSjeK0kl4YxMN6dvNo7BYopk= IronPort-HdrOrdr: A9a23:1SF98aiMBDuv+B6mbtonImLiPnBQXgMji2hC6mlwRA09TyVXrb HKoB1p726KtN9xYgBbpTnkAsO9qBznhOdICOUqTNSftUzdyQyVxeJZnPDfKl/balXDH4dmvM 8KE5SWSueAaWSS5fya3ODSKadH/DDzytHVuQ6x9QYOceioUc1dBsVCZzpz3ncYeOA/P+tFKH NU3KR6mwY= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104275102" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 05/15] x86: Merge the system {cpuid,msr} policy objects Date: Tue, 4 Apr 2023 10:52:12 +0100 Message-ID: <20230404095222.1373721-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Right now, they're the same underlying type, containing disjoint information. Introduce a new cpu-policy.{h,c} to be the new location for all policy handling logic. Place the combined objects in __ro_after_init, which is new since the original logic was written. As we're trying to phase out the use of struct old_cpu_policy entirely, rework update_domain_cpu_policy() to not pointer-chase through system_policies[]. This in turn allows system_policies[] in sysctl.c to become static and reduced in scope to XEN_SYSCTL_get_cpu_policy. No practical change. This undoes the transient doubling of storage space from earlier patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Reword commit message * Reintroduce dropped const from system_policies[] --- xen/arch/x86/Makefile | 1 + xen/arch/x86/cpu-policy.c | 18 +++++++ xen/arch/x86/cpu/common.c | 4 +- xen/arch/x86/cpuid.c | 66 +++++++++++-------------- xen/arch/x86/domctl.c | 17 +++++-- xen/arch/x86/include/asm/cpu-policy.h | 14 ++++++ xen/arch/x86/include/asm/cpuid.h | 6 --- xen/arch/x86/include/asm/msr.h | 7 --- xen/arch/x86/msr.c | 38 ++++++-------- xen/arch/x86/sysctl.c | 71 ++++++++++----------------- 10 files changed, 116 insertions(+), 126 deletions(-) create mode 100644 xen/arch/x86/cpu-policy.c create mode 100644 xen/arch/x86/include/asm/cpu-policy.h diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 08b110592dcc..fc9487aa4023 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -19,6 +19,7 @@ obj-y += bitops.o obj-bin-y += bzimage.init.o obj-bin-y += clear_page.o obj-bin-y += copy_page.o +obj-y += cpu-policy.o obj-y += cpuid.o obj-$(CONFIG_PV) += compat.o obj-$(CONFIG_PV32) += x86_64/compat.o diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c new file mode 100644 index 000000000000..663e9a084c53 --- /dev/null +++ b/xen/arch/x86/cpu-policy.c @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include +#include + +#include + +#include + +struct cpu_policy __ro_after_init raw_cpu_policy; +struct cpu_policy __ro_after_init host_cpu_policy; +#ifdef CONFIG_PV +struct cpu_policy __ro_after_init pv_max_cpu_policy; +struct cpu_policy __ro_after_init pv_def_cpu_policy; +#endif +#ifdef CONFIG_HVM +struct cpu_policy __ro_after_init hvm_max_cpu_policy; +struct cpu_policy __ro_after_init hvm_def_cpu_policy; +#endif diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 5ad347534a22..f11dcda57a69 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -3,6 +3,8 @@ #include #include #include + +#include #include #include #include @@ -141,7 +143,7 @@ bool __init probe_cpuid_faulting(void) return false; if ((rc = rdmsr_safe(MSR_INTEL_PLATFORM_INFO, val)) == 0) - raw_msr_policy.platform_info.cpuid_faulting = + raw_cpu_policy.platform_info.cpuid_faulting = val & MSR_PLATFORM_INFO_CPUID_FAULTING; if (rc || diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index b22725c492e7..0916bfe175c8 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include #include @@ -142,17 +143,6 @@ static void zero_leaves(struct cpuid_leaf *l, memset(&l[first], 0, sizeof(*l) * (last - first + 1)); } -struct cpuid_policy __read_mostly raw_cpuid_policy, - __read_mostly host_cpuid_policy; -#ifdef CONFIG_PV -struct cpuid_policy __read_mostly pv_max_cpuid_policy; -struct cpuid_policy __read_mostly pv_def_cpuid_policy; -#endif -#ifdef CONFIG_HVM -struct cpuid_policy __read_mostly hvm_max_cpuid_policy; -struct cpuid_policy __read_mostly hvm_def_cpuid_policy; -#endif - static void sanitise_featureset(uint32_t *fs) { /* for_each_set_bit() uses unsigned longs. Extend with zeroes. */ @@ -344,7 +334,7 @@ static void recalculate_misc(struct cpuid_policy *p) static void __init calculate_raw_policy(void) { - struct cpuid_policy *p = &raw_cpuid_policy; + struct cpuid_policy *p = &raw_cpu_policy; x86_cpuid_policy_fill_native(p); @@ -354,10 +344,10 @@ static void __init calculate_raw_policy(void) static void __init calculate_host_policy(void) { - struct cpuid_policy *p = &host_cpuid_policy; + struct cpuid_policy *p = &host_cpu_policy; unsigned int max_extd_leaf; - *p = raw_cpuid_policy; + *p = raw_cpu_policy; p->basic.max_leaf = min_t(uint32_t, p->basic.max_leaf, ARRAY_SIZE(p->basic.raw) - 1); @@ -449,17 +439,17 @@ static void __init guest_common_feature_adjustments(uint32_t *fs) * of IBRS by using the AMD feature bit. An administrator may wish for * performance reasons to offer IBPB without IBRS. */ - if ( host_cpuid_policy.feat.ibrsb ) + if ( host_cpu_policy.feat.ibrsb ) __set_bit(X86_FEATURE_IBPB, fs); } static void __init calculate_pv_max_policy(void) { - struct cpuid_policy *p = &pv_max_cpuid_policy; + struct cpuid_policy *p = &pv_max_cpu_policy; uint32_t pv_featureset[FSCAPINTS]; unsigned int i; - *p = host_cpuid_policy; + *p = host_cpu_policy; cpuid_policy_to_featureset(p, pv_featureset); for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) @@ -486,11 +476,11 @@ static void __init calculate_pv_max_policy(void) static void __init calculate_pv_def_policy(void) { - struct cpuid_policy *p = &pv_def_cpuid_policy; + struct cpuid_policy *p = &pv_def_cpu_policy; uint32_t pv_featureset[FSCAPINTS]; unsigned int i; - *p = pv_max_cpuid_policy; + *p = pv_max_cpu_policy; cpuid_policy_to_featureset(p, pv_featureset); for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) @@ -506,12 +496,12 @@ static void __init calculate_pv_def_policy(void) static void __init calculate_hvm_max_policy(void) { - struct cpuid_policy *p = &hvm_max_cpuid_policy; + struct cpuid_policy *p = &hvm_max_cpu_policy; uint32_t hvm_featureset[FSCAPINTS]; unsigned int i; const uint32_t *hvm_featuremask; - *p = host_cpuid_policy; + *p = host_cpu_policy; cpuid_policy_to_featureset(p, hvm_featureset); hvm_featuremask = hvm_hap_supported() ? @@ -539,7 +529,7 @@ static void __init calculate_hvm_max_policy(void) * HVM guests are able if running in protected mode. */ if ( (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) && - raw_cpuid_policy.basic.sep ) + raw_cpu_policy.basic.sep ) __set_bit(X86_FEATURE_SEP, hvm_featureset); /* @@ -597,12 +587,12 @@ static void __init calculate_hvm_max_policy(void) static void __init calculate_hvm_def_policy(void) { - struct cpuid_policy *p = &hvm_def_cpuid_policy; + struct cpuid_policy *p = &hvm_def_cpu_policy; uint32_t hvm_featureset[FSCAPINTS]; unsigned int i; const uint32_t *hvm_featuremask; - *p = hvm_max_cpuid_policy; + *p = hvm_max_cpu_policy; cpuid_policy_to_featureset(p, hvm_featureset); hvm_featuremask = hvm_hap_supported() ? @@ -670,8 +660,8 @@ void recalculate_cpuid_policy(struct domain *d) { struct cpuid_policy *p = d->arch.cpuid; const struct cpuid_policy *max = is_pv_domain(d) - ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpuid_policy : NULL) - : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpuid_policy : NULL); + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS]; unsigned int i; @@ -746,7 +736,7 @@ void recalculate_cpuid_policy(struct domain *d) /* Fold host's FDP_EXCP_ONLY and NO_FPU_SEL into guest's view. */ fs[FEATURESET_7b0] &= ~(cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | cpufeat_mask(X86_FEATURE_NO_FPU_SEL)); - fs[FEATURESET_7b0] |= (host_cpuid_policy.feat._7b0 & + fs[FEATURESET_7b0] |= (host_cpu_policy.feat._7b0 & (cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | cpufeat_mask(X86_FEATURE_NO_FPU_SEL))); @@ -797,8 +787,8 @@ void recalculate_cpuid_policy(struct domain *d) int init_domain_cpuid_policy(struct domain *d) { struct cpuid_policy *p = is_pv_domain(d) - ? (IS_ENABLED(CONFIG_PV) ? &pv_def_cpuid_policy : NULL) - : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_cpuid_policy : NULL); + ? (IS_ENABLED(CONFIG_PV) ? &pv_def_cpu_policy : NULL) + : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_cpu_policy : NULL); if ( !p ) { @@ -1102,7 +1092,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, if ( is_pv_domain(d) && is_hardware_domain(d) && guest_kernel_mode(v, regs) && cpu_has_monitor && regs->entry_vector == TRAP_gp_fault ) - *res = raw_cpuid_policy.basic.raw[5]; + *res = raw_cpu_policy.basic.raw[5]; break; case 0x7: @@ -1234,14 +1224,14 @@ static void __init __maybe_unused build_assertions(void) /* Find some more clever allocation scheme if this trips. */ BUILD_BUG_ON(sizeof(struct cpuid_policy) > PAGE_SIZE); - BUILD_BUG_ON(sizeof(raw_cpuid_policy.basic) != - sizeof(raw_cpuid_policy.basic.raw)); - BUILD_BUG_ON(sizeof(raw_cpuid_policy.feat) != - sizeof(raw_cpuid_policy.feat.raw)); - BUILD_BUG_ON(sizeof(raw_cpuid_policy.xstate) != - sizeof(raw_cpuid_policy.xstate.raw)); - BUILD_BUG_ON(sizeof(raw_cpuid_policy.extd) != - sizeof(raw_cpuid_policy.extd.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.basic) != + sizeof(raw_cpu_policy.basic.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.feat) != + sizeof(raw_cpu_policy.feat.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.xstate) != + sizeof(raw_cpu_policy.xstate.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.extd) != + sizeof(raw_cpu_policy.extd.raw)); } /* diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 944af63e68d0..5800bb10bc4a 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -35,18 +35,25 @@ #include #include #include -#include +#include static int update_domain_cpu_policy(struct domain *d, xen_domctl_cpu_policy_t *xdpc) { struct old_cpu_policy new = {}; - const struct old_cpu_policy *sys = is_pv_domain(d) - ? &system_policies[XEN_SYSCTL_cpu_policy_pv_max] - : &system_policies[XEN_SYSCTL_cpu_policy_hvm_max]; + struct cpu_policy *sys = is_pv_domain(d) + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); + struct old_cpu_policy old_sys = { sys, sys }; struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS; int ret = -ENOMEM; + if ( !sys ) + { + ASSERT_UNREACHABLE(); + return -EOPNOTSUPP; + } + /* Start by copying the domain's existing policies. */ if ( !(new.cpuid = xmemdup(d->arch.cpuid)) || !(new.msr = xmemdup(d->arch.msr)) ) @@ -64,7 +71,7 @@ static int update_domain_cpu_policy(struct domain *d, x86_cpuid_policy_clear_out_of_range_leaves(new.cpuid); /* Audit the combined dataset. */ - ret = x86_cpu_policies_are_compatible(sys, &new, &err); + ret = x86_cpu_policies_are_compatible(&old_sys, &new, &err); if ( ret ) goto out; diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h new file mode 100644 index 000000000000..eef14bb4267e --- /dev/null +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef X86_CPU_POLICY_H +#define X86_CPU_POLICY_H + +struct cpu_policy; + +extern struct cpu_policy raw_cpu_policy; +extern struct cpu_policy host_cpu_policy; +extern struct cpu_policy pv_max_cpu_policy; +extern struct cpu_policy pv_def_cpu_policy; +extern struct cpu_policy hvm_max_cpu_policy; +extern struct cpu_policy hvm_def_cpu_policy; + +#endif /* X86_CPU_POLICY_H */ diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h index d418e8100dde..ea0586277331 100644 --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -46,12 +46,6 @@ DECLARE_PER_CPU(struct cpuidmasks, cpuidmasks); /* Default masking MSR values, calculated at boot. */ extern struct cpuidmasks cpuidmask_defaults; -extern struct cpuid_policy raw_cpuid_policy, host_cpuid_policy, - pv_max_cpuid_policy, pv_def_cpuid_policy, - hvm_max_cpuid_policy, hvm_def_cpuid_policy; - -extern const struct old_cpu_policy system_policies[]; - /* Check that all previously present features are still available. */ bool recheck_cpu_features(unsigned int cpu); diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 02eddd919c27..022230acc0af 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -292,13 +292,6 @@ static inline void wrmsr_tsc_aux(uint32_t val) uint64_t msr_spec_ctrl_valid_bits(const struct cpuid_policy *cp); -extern struct msr_policy raw_msr_policy, - host_msr_policy, - pv_max_msr_policy, - pv_def_msr_policy, - hvm_max_msr_policy, - hvm_def_msr_policy; - /* Container object for per-vCPU MSRs */ struct vcpu_msrs { diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 7ddf0078c3a2..bff26bc4e2b5 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -25,6 +25,7 @@ #include #include +#include #include #include #include @@ -37,20 +38,9 @@ DEFINE_PER_CPU(uint32_t, tsc_aux); -struct msr_policy __read_mostly raw_msr_policy, - __read_mostly host_msr_policy; -#ifdef CONFIG_PV -struct msr_policy __read_mostly pv_max_msr_policy; -struct msr_policy __read_mostly pv_def_msr_policy; -#endif -#ifdef CONFIG_HVM -struct msr_policy __read_mostly hvm_max_msr_policy; -struct msr_policy __read_mostly hvm_def_msr_policy; -#endif - static void __init calculate_raw_policy(void) { - struct msr_policy *mp = &raw_msr_policy; + struct msr_policy *mp = &raw_cpu_policy; /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ /* Was already added by probe_cpuid_faulting() */ @@ -61,9 +51,9 @@ static void __init calculate_raw_policy(void) static void __init calculate_host_policy(void) { - struct msr_policy *mp = &host_msr_policy; + struct msr_policy *mp = &host_cpu_policy; - *mp = raw_msr_policy; + *mp = raw_cpu_policy; /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ /* probe_cpuid_faulting() sanity checks presence of MISC_FEATURES_ENABLES */ @@ -81,25 +71,25 @@ static void __init calculate_host_policy(void) static void __init calculate_pv_max_policy(void) { - struct msr_policy *mp = &pv_max_msr_policy; + struct msr_policy *mp = &pv_max_cpu_policy; - *mp = host_msr_policy; + *mp = host_cpu_policy; mp->arch_caps.raw = 0; /* Not supported yet. */ } static void __init calculate_pv_def_policy(void) { - struct msr_policy *mp = &pv_def_msr_policy; + struct msr_policy *mp = &pv_def_cpu_policy; - *mp = pv_max_msr_policy; + *mp = pv_max_cpu_policy; } static void __init calculate_hvm_max_policy(void) { - struct msr_policy *mp = &hvm_max_msr_policy; + struct msr_policy *mp = &hvm_max_cpu_policy; - *mp = host_msr_policy; + *mp = host_cpu_policy; /* It's always possible to emulate CPUID faulting for HVM guests */ mp->platform_info.cpuid_faulting = true; @@ -109,9 +99,9 @@ static void __init calculate_hvm_max_policy(void) static void __init calculate_hvm_def_policy(void) { - struct msr_policy *mp = &hvm_def_msr_policy; + struct msr_policy *mp = &hvm_def_cpu_policy; - *mp = hvm_max_msr_policy; + *mp = hvm_max_cpu_policy; } void __init init_guest_msr_policy(void) @@ -135,8 +125,8 @@ void __init init_guest_msr_policy(void) int init_domain_msr_policy(struct domain *d) { struct msr_policy *mp = is_pv_domain(d) - ? (IS_ENABLED(CONFIG_PV) ? &pv_def_msr_policy : NULL) - : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_msr_policy : NULL); + ? (IS_ENABLED(CONFIG_PV) ? &pv_def_cpu_policy : NULL) + : (IS_ENABLED(CONFIG_HVM) ? &hvm_def_cpu_policy : NULL); if ( !mp ) { diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index 3ed7c69f4315..43a241f2090f 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -30,38 +30,7 @@ #include #include #include -#include - -const struct old_cpu_policy system_policies[6] = { - [ XEN_SYSCTL_cpu_policy_raw ] = { - &raw_cpuid_policy, - &raw_msr_policy, - }, - [ XEN_SYSCTL_cpu_policy_host ] = { - &host_cpuid_policy, - &host_msr_policy, - }, -#ifdef CONFIG_PV - [ XEN_SYSCTL_cpu_policy_pv_max ] = { - &pv_max_cpuid_policy, - &pv_max_msr_policy, - }, - [ XEN_SYSCTL_cpu_policy_pv_default ] = { - &pv_def_cpuid_policy, - &pv_def_msr_policy, - }, -#endif -#ifdef CONFIG_HVM - [ XEN_SYSCTL_cpu_policy_hvm_max ] = { - &hvm_max_cpuid_policy, - &hvm_max_msr_policy, - }, - [ XEN_SYSCTL_cpu_policy_hvm_default ] = { - &hvm_def_cpuid_policy, - &hvm_def_msr_policy, - }, -#endif -}; +#include struct l3_cache_info { int ret; @@ -326,19 +295,19 @@ long arch_do_sysctl( case XEN_SYSCTL_get_cpu_featureset: { - static const struct cpuid_policy *const policy_table[6] = { - [XEN_SYSCTL_cpu_featureset_raw] = &raw_cpuid_policy, - [XEN_SYSCTL_cpu_featureset_host] = &host_cpuid_policy, + static const struct cpu_policy *const policy_table[6] = { + [XEN_SYSCTL_cpu_featureset_raw] = &raw_cpu_policy, + [XEN_SYSCTL_cpu_featureset_host] = &host_cpu_policy, #ifdef CONFIG_PV - [XEN_SYSCTL_cpu_featureset_pv] = &pv_def_cpuid_policy, - [XEN_SYSCTL_cpu_featureset_pv_max] = &pv_max_cpuid_policy, + [XEN_SYSCTL_cpu_featureset_pv] = &pv_def_cpu_policy, + [XEN_SYSCTL_cpu_featureset_pv_max] = &pv_max_cpu_policy, #endif #ifdef CONFIG_HVM - [XEN_SYSCTL_cpu_featureset_hvm] = &hvm_def_cpuid_policy, - [XEN_SYSCTL_cpu_featureset_hvm_max] = &hvm_max_cpuid_policy, + [XEN_SYSCTL_cpu_featureset_hvm] = &hvm_def_cpu_policy, + [XEN_SYSCTL_cpu_featureset_hvm_max] = &hvm_max_cpu_policy, #endif }; - const struct cpuid_policy *p = NULL; + const struct cpu_policy *p = NULL; uint32_t featureset[FSCAPINTS]; unsigned int nr; @@ -391,7 +360,19 @@ long arch_do_sysctl( case XEN_SYSCTL_get_cpu_policy: { - const struct old_cpu_policy *policy; + static const struct cpu_policy *const system_policies[6] = { + [XEN_SYSCTL_cpu_policy_raw] = &raw_cpu_policy, + [XEN_SYSCTL_cpu_policy_host] = &host_cpu_policy, +#ifdef CONFIG_PV + [XEN_SYSCTL_cpu_policy_pv_max] = &pv_max_cpu_policy, + [XEN_SYSCTL_cpu_policy_pv_default] = &pv_def_cpu_policy, +#endif +#ifdef CONFIG_HVM + [XEN_SYSCTL_cpu_policy_hvm_max] = &hvm_max_cpu_policy, + [XEN_SYSCTL_cpu_policy_hvm_default] = &hvm_def_cpu_policy, +#endif + }; + const struct cpu_policy *policy; /* Reserved field set, or bad policy index? */ if ( sysctl->u.cpu_policy._rsvd || @@ -400,11 +381,11 @@ long arch_do_sysctl( ret = -EINVAL; break; } - policy = &system_policies[ + policy = system_policies[ array_index_nospec(sysctl->u.cpu_policy.index, ARRAY_SIZE(system_policies))]; - if ( !policy->cpuid || !policy->msr ) + if ( !policy ) { ret = -EOPNOTSUPP; break; @@ -414,7 +395,7 @@ long arch_do_sysctl( if ( guest_handle_is_null(sysctl->u.cpu_policy.leaves) ) sysctl->u.cpu_policy.nr_leaves = CPUID_MAX_SERIALISED_LEAVES; else if ( (ret = x86_cpuid_copy_to_buffer( - policy->cpuid, + policy, sysctl->u.cpu_policy.leaves, &sysctl->u.cpu_policy.nr_leaves)) ) break; @@ -430,7 +411,7 @@ long arch_do_sysctl( if ( guest_handle_is_null(sysctl->u.cpu_policy.msrs) ) sysctl->u.cpu_policy.nr_msrs = MSR_MAX_SERIALISED_ENTRIES; else if ( (ret = x86_msr_copy_to_buffer( - policy->msr, + policy, sysctl->u.cpu_policy.msrs, &sysctl->u.cpu_policy.nr_msrs)) ) break; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:52:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:52:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517718.803537 (Exim 4.92) (envelope-from ) id 1pjdLR-0007WT-EP; Tue, 04 Apr 2023 09:52:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517718.803537; Tue, 04 Apr 2023 09:52:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLR-0007Ur-7F; Tue, 04 Apr 2023 09:52:53 +0000 Received: by outflank-mailman (input) for mailman id 517718; Tue, 04 Apr 2023 09:52:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLP-0005bo-36 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:52:51 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7485f6e7-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:52:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7485f6e7-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680601968; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UWOWvkRFhQtN58lpWN5uMWSpgTK9p/X4W2+Z700adBA=; b=Q+DNi5ozG4MyQG1HGxr14UHhfAKEFcdbdV8wNqQWJDTuy2Jc7xzuHROJ oMSiAaHWFmdWB0a6fX+dMFHuk7zOTmDsrjOR8IX/P80sErBqHAVntacbA ukdUOfwTiqCzFRrm9IKTz6J8t8FirFDwZyAbJ1VokRo5bEyuQE70aMZ4F w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104275106 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:8puiia01dD2dX2jz//bD5axxkn2cJEfYwER7XKvMYLTBsI5bpzAHx 2UXDW/Sb/yMZ2KhetxxboSyoUNX7MfSnNJhQQpqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDGFyr eYECTk2RAmqqNKpxeyjY7FAr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJ0JxBnF/ zqYl4j/Ki4FGY3EzCCmzn2HuPHIh3PnfYgrLqLto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLW6QuEAmkPThZadccr8sQxQFQXO kShxo2zQ2Y16fvMFCzbr+3Pxd+vBcQLBWICWXceUSoM2PP6ia4DkReRVv87PIfg27UZBgrML yC2QDkW3utD1ZNUif/kpDgrkBr3+MGXE1ddChH/Gzv8s1gnPNPNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83oJrW7FF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPdLpVph0nPK7T4q1PhwxUjapSsEpHDJrAQk0PRLAt4wTuBNEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqLH/jTlk33uYdykVbJEd/pxnPSNLFmhE5FyS2Jm +ti2zyikEoADLenPnaOoeb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:+TC7BajZnnUAz5em4pebKylZdHBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104275106" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 03/15] x86: Rename struct cpuid_policy to struct cpu_policy Date: Tue, 4 Apr 2023 10:52:10 +0100 Message-ID: <20230404095222.1373721-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Also merge lib/x86/cpuid.h entirely into lib/x86/cpu-policy.h Use a temporary define to make struct cpuid_policy still work. There's one forward declaration of struct cpuid_policy in tools/tests/x86_emulator/x86-emulate.h that isn't covered by the define, and it's easier to rename that now than to rearrange the includes. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Retain test/x86_emulator handcoded dependency on cpuid-autogen.h * Rebase over x86_emulate() split --- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 2 +- tools/tests/x86_emulator/Makefile | 2 +- tools/tests/x86_emulator/x86-emulate.h | 2 +- xen/arch/x86/include/asm/cpuid.h | 1 - xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- xen/include/xen/lib/x86/cpu-policy.h | 463 ++++++++++++++++++++- xen/include/xen/lib/x86/cpuid.h | 475 ---------------------- xen/lib/x86/cpuid.c | 2 +- 8 files changed, 467 insertions(+), 482 deletions(-) delete mode 100644 xen/include/xen/lib/x86/cpuid.h diff --git a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c index 7d0f274c6cdd..79e42e8bfd04 100644 --- a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c +++ b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c @@ -9,7 +9,7 @@ #include #include -#include +#include #include #include diff --git a/tools/tests/x86_emulator/Makefile b/tools/tests/x86_emulator/Makefile index f5d88fb9f681..4b1f75de052e 100644 --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -292,7 +292,7 @@ HOSTCFLAGS += $(CFLAGS_xeninclude) -I. $(HOSTCFLAGS-$(XEN_COMPILE_ARCH)) x86.h := $(addprefix $(XEN_ROOT)/tools/include/xen/asm/,\ x86-vendors.h x86-defns.h msr-index.h) \ $(addprefix $(XEN_ROOT)/tools/include/xen/lib/x86/, \ - cpuid.h cpuid-autogen.h) + cpu-policy.h cpuid-autogen.h) x86_emulate.h := x86-emulate.h x86_emulate/x86_emulate.h x86_emulate/private.h $(x86.h) $(OBJS): %.o: %.c $(x86_emulate.h) diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h index 942b4cdd47d1..02922d0c5a19 100644 --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -77,7 +77,7 @@ #define is_canonical_address(x) (((int64_t)(x) >> 47) == ((int64_t)(x) >> 63)) extern uint32_t mxcsr_mask; -extern struct cpuid_policy cp; +extern struct cpu_policy cp; #define MMAP_SZ 16384 bool emul_test_init(void); diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h index 49b3128f06f9..d418e8100dde 100644 --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -9,7 +9,6 @@ #include #include -#include #include diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index bb7af967ffee..75015104fbdb 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -23,7 +23,7 @@ #ifndef __X86_EMULATE_H__ #define __X86_EMULATE_H__ -#include +#include #define MAX_INST_LEN 15 diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 3a5300d1078c..666505964d00 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -2,9 +2,342 @@ #ifndef XEN_LIB_X86_POLICIES_H #define XEN_LIB_X86_POLICIES_H -#include +#include #include +#define FEATURESET_1d 0 /* 0x00000001.edx */ +#define FEATURESET_1c 1 /* 0x00000001.ecx */ +#define FEATURESET_e1d 2 /* 0x80000001.edx */ +#define FEATURESET_e1c 3 /* 0x80000001.ecx */ +#define FEATURESET_Da1 4 /* 0x0000000d:1.eax */ +#define FEATURESET_7b0 5 /* 0x00000007:0.ebx */ +#define FEATURESET_7c0 6 /* 0x00000007:0.ecx */ +#define FEATURESET_e7d 7 /* 0x80000007.edx */ +#define FEATURESET_e8b 8 /* 0x80000008.ebx */ +#define FEATURESET_7d0 9 /* 0x00000007:0.edx */ +#define FEATURESET_7a1 10 /* 0x00000007:1.eax */ +#define FEATURESET_e21a 11 /* 0x80000021.eax */ +#define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ +#define FEATURESET_7d2 13 /* 0x00000007:2.edx */ +#define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ +#define FEATURESET_7d1 15 /* 0x00000007:1.edx */ + +struct cpuid_leaf +{ + uint32_t a, b, c, d; +}; + +/* + * Versions of GCC before 5 unconditionally reserve %rBX as the PIC hard + * register, and are unable to cope with spilling it. This results in a + * rather cryptic error: + * error: inconsistent operand constraints in an ‘asm’ + * + * In affected situations, work around the issue by using a separate register + * to hold the the %rBX output, and xchg twice to leave %rBX preserved around + * the asm() statement. + */ +#if defined(__PIC__) && __GNUC__ < 5 && !defined(__clang__) && defined(__i386__) +# define XCHG_BX "xchg %%ebx, %[bx];" +# define BX_CON [bx] "=&r" +#elif defined(__PIC__) && __GNUC__ < 5 && !defined(__clang__) && \ + defined(__x86_64__) && (defined(__code_model_medium__) || \ + defined(__code_model_large__)) +# define XCHG_BX "xchg %%rbx, %q[bx];" +# define BX_CON [bx] "=&r" +#else +# define XCHG_BX "" +# define BX_CON "=&b" +#endif + +static inline void cpuid_leaf(uint32_t leaf, struct cpuid_leaf *l) +{ + asm ( XCHG_BX + "cpuid;" + XCHG_BX + : "=a" (l->a), BX_CON (l->b), "=&c" (l->c), "=&d" (l->d) + : "a" (leaf) ); +} + +static inline void cpuid_count_leaf( + uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *l) +{ + asm ( XCHG_BX + "cpuid;" + XCHG_BX + : "=a" (l->a), BX_CON (l->b), "=c" (l->c), "=&d" (l->d) + : "a" (leaf), "c" (subleaf) ); +} + +#undef BX_CON +#undef XCHG + +/** + * Given the vendor id from CPUID leaf 0, look up Xen's internal integer + * vendor ID. Returns X86_VENDOR_UNKNOWN for any unknown vendor. + */ +unsigned int x86_cpuid_lookup_vendor(uint32_t ebx, uint32_t ecx, uint32_t edx); + +/** + * Given Xen's internal vendor ID, return a string suitable for printing. + * Returns "Unknown" for any unrecognised ID. + */ +const char *x86_cpuid_vendor_to_str(unsigned int vendor); + +#define CPUID_GUEST_NR_BASIC (0xdu + 1) +#define CPUID_GUEST_NR_CACHE (5u + 1) +#define CPUID_GUEST_NR_FEAT (2u + 1) +#define CPUID_GUEST_NR_TOPO (1u + 1) +#define CPUID_GUEST_NR_XSTATE (62u + 1) +#define CPUID_GUEST_NR_EXTD_INTEL (0x8u + 1) +#define CPUID_GUEST_NR_EXTD_AMD (0x21u + 1) +#define CPUID_GUEST_NR_EXTD MAX(CPUID_GUEST_NR_EXTD_INTEL, \ + CPUID_GUEST_NR_EXTD_AMD) + +/* + * Maximum number of leaves a struct cpu_policy turns into when serialised for + * interaction with the toolstack. (Sum of all leaves in each union, less the + * entries in basic which sub-unions hang off of.) + */ +#define CPUID_MAX_SERIALISED_LEAVES \ + (CPUID_GUEST_NR_BASIC + \ + CPUID_GUEST_NR_FEAT - !!CPUID_GUEST_NR_FEAT + \ + CPUID_GUEST_NR_CACHE - !!CPUID_GUEST_NR_CACHE + \ + CPUID_GUEST_NR_TOPO - !!CPUID_GUEST_NR_TOPO + \ + CPUID_GUEST_NR_XSTATE - !!CPUID_GUEST_NR_XSTATE + \ + CPUID_GUEST_NR_EXTD + 2 /* hv_limit and hv2_limit */ ) + +struct cpu_policy +{ +#define DECL_BITFIELD(word) _DECL_BITFIELD(FEATURESET_ ## word) +#define _DECL_BITFIELD(x) __DECL_BITFIELD(x) +#define __DECL_BITFIELD(x) CPUID_BITFIELD_ ## x + + /* Basic leaves: 0x000000xx */ + union { + struct cpuid_leaf raw[CPUID_GUEST_NR_BASIC]; + struct { + /* Leaf 0x0 - Max and vendor. */ + uint32_t max_leaf, vendor_ebx, vendor_ecx, vendor_edx; + + /* Leaf 0x1 - Family/model/stepping and features. */ + uint32_t raw_fms; + uint8_t :8, /* Brand ID. */ + clflush_size, /* Number of 8-byte blocks per cache line. */ + lppp, /* Logical processors per package. */ + apic_id; /* Initial APIC ID. */ + union { + uint32_t _1c; + struct { DECL_BITFIELD(1c); }; + }; + union { + uint32_t _1d; + struct { DECL_BITFIELD(1d); }; + }; + + /* Leaf 0x2 - TLB/Cache/Prefetch. */ + uint8_t l2_nr_queries; /* Documented as fixed to 1. */ + uint8_t l2_desc[15]; + + uint64_t :64, :64; /* Leaf 0x3 - PSN. */ + uint64_t :64, :64; /* Leaf 0x4 - Structured Cache. */ + uint64_t :64, :64; /* Leaf 0x5 - MONITOR. */ + uint64_t :64, :64; /* Leaf 0x6 - Therm/Perf. */ + uint64_t :64, :64; /* Leaf 0x7 - Structured Features. */ + uint64_t :64, :64; /* Leaf 0x8 - rsvd */ + uint64_t :64, :64; /* Leaf 0x9 - DCA */ + + /* Leaf 0xa - Intel PMU. */ + uint8_t pmu_version, _pmu[15]; + + uint64_t :64, :64; /* Leaf 0xb - Topology. */ + uint64_t :64, :64; /* Leaf 0xc - rsvd */ + uint64_t :64, :64; /* Leaf 0xd - XSTATE. */ + }; + } basic; + + /* Structured cache leaf: 0x00000004[xx] */ + union { + struct cpuid_leaf raw[CPUID_GUEST_NR_CACHE]; + struct cpuid_cache_leaf { + uint32_t /* a */ type:5, level:3; + bool self_init:1, fully_assoc:1; + uint32_t :4, threads_per_cache:12, cores_per_package:6; + uint32_t /* b */ line_size:12, partitions:10, ways:10; + uint32_t /* c */ sets; + bool /* d */ wbinvd:1, inclusive:1, complex:1; + } subleaf[CPUID_GUEST_NR_CACHE]; + } cache; + + /* Structured feature leaf: 0x00000007[xx] */ + union { + struct cpuid_leaf raw[CPUID_GUEST_NR_FEAT]; + struct { + /* Subleaf 0. */ + uint32_t max_subleaf; + union { + uint32_t _7b0; + struct { DECL_BITFIELD(7b0); }; + }; + union { + uint32_t _7c0; + struct { DECL_BITFIELD(7c0); }; + }; + union { + uint32_t _7d0; + struct { DECL_BITFIELD(7d0); }; + }; + + /* Subleaf 1. */ + union { + uint32_t _7a1; + struct { DECL_BITFIELD(7a1); }; + }; + union { + uint32_t _7b1; + struct { DECL_BITFIELD(7b1); }; + }; + union { + uint32_t _7c1; + struct { DECL_BITFIELD(7c1); }; + }; + union { + uint32_t _7d1; + struct { DECL_BITFIELD(7d1); }; + }; + + /* Subleaf 2. */ + uint32_t /* a */:32, /* b */:32, /* c */:32; + union { + uint32_t _7d2; + struct { DECL_BITFIELD(7d2); }; + }; + }; + } feat; + + /* Extended topology enumeration: 0x0000000B[xx] */ + union { + struct cpuid_leaf raw[CPUID_GUEST_NR_TOPO]; + struct cpuid_topo_leaf { + uint32_t id_shift:5, :27; + uint16_t nr_logical, :16; + uint8_t level, type, :8, :8; + uint32_t x2apic_id; + } subleaf[CPUID_GUEST_NR_TOPO]; + } topo; + + /* Xstate feature leaf: 0x0000000D[xx] */ + union { + struct cpuid_leaf raw[CPUID_GUEST_NR_XSTATE]; + + struct { + /* Subleaf 0. */ + uint32_t xcr0_low, /* b */:32, max_size, xcr0_high; + + /* Subleaf 1. */ + union { + uint32_t Da1; + struct { DECL_BITFIELD(Da1); }; + }; + uint32_t /* b */:32, xss_low, xss_high; + }; + + /* Per-component common state. Valid for i >= 2. */ + struct { + uint32_t size, offset; + bool xss:1, align:1; + uint32_t _res_d; + } comp[CPUID_GUEST_NR_XSTATE]; + } xstate; + + /* Extended leaves: 0x800000xx */ + union { + struct cpuid_leaf raw[CPUID_GUEST_NR_EXTD]; + struct { + /* Leaf 0x80000000 - Max and vendor. */ + uint32_t max_leaf, vendor_ebx, vendor_ecx, vendor_edx; + + /* Leaf 0x80000001 - Family/model/stepping and features. */ + uint32_t raw_fms, /* b */:32; + union { + uint32_t e1c; + struct { DECL_BITFIELD(e1c); }; + }; + union { + uint32_t e1d; + struct { DECL_BITFIELD(e1d); }; + }; + + uint64_t :64, :64; /* Brand string. */ + uint64_t :64, :64; /* Brand string. */ + uint64_t :64, :64; /* Brand string. */ + uint64_t :64, :64; /* L1 cache/TLB. */ + uint64_t :64, :64; /* L2/3 cache/TLB. */ + + /* Leaf 0x80000007 - Advanced Power Management. */ + uint32_t /* a */:32, /* b */:32, /* c */:32; + union { + uint32_t e7d; + struct { DECL_BITFIELD(e7d); }; + }; + + /* Leaf 0x80000008 - Misc addr/feature info. */ + uint8_t maxphysaddr, maxlinaddr, :8, :8; + union { + uint32_t e8b; + struct { DECL_BITFIELD(e8b); }; + }; + uint32_t nc:8, :4, apic_id_size:4, :16; + uint32_t /* d */:32; + + uint64_t :64, :64; /* Leaf 0x80000009. */ + uint64_t :64, :64; /* Leaf 0x8000000a - SVM rev and features. */ + uint64_t :64, :64; /* Leaf 0x8000000b. */ + uint64_t :64, :64; /* Leaf 0x8000000c. */ + uint64_t :64, :64; /* Leaf 0x8000000d. */ + uint64_t :64, :64; /* Leaf 0x8000000e. */ + uint64_t :64, :64; /* Leaf 0x8000000f. */ + uint64_t :64, :64; /* Leaf 0x80000010. */ + uint64_t :64, :64; /* Leaf 0x80000011. */ + uint64_t :64, :64; /* Leaf 0x80000012. */ + uint64_t :64, :64; /* Leaf 0x80000013. */ + uint64_t :64, :64; /* Leaf 0x80000014. */ + uint64_t :64, :64; /* Leaf 0x80000015. */ + uint64_t :64, :64; /* Leaf 0x80000016. */ + uint64_t :64, :64; /* Leaf 0x80000017. */ + uint64_t :64, :64; /* Leaf 0x80000018. */ + uint64_t :64, :64; /* Leaf 0x80000019 - TLB 1GB Identifiers. */ + uint64_t :64, :64; /* Leaf 0x8000001a - Performance related info. */ + uint64_t :64, :64; /* Leaf 0x8000001b - IBS feature information. */ + uint64_t :64, :64; /* Leaf 0x8000001c. */ + uint64_t :64, :64; /* Leaf 0x8000001d - Cache properties. */ + uint64_t :64, :64; /* Leaf 0x8000001e - Extd APIC/Core/Node IDs. */ + uint64_t :64, :64; /* Leaf 0x8000001f - AMD Secure Encryption. */ + uint64_t :64, :64; /* Leaf 0x80000020 - Platform QoS. */ + + /* Leaf 0x80000021 - Extended Feature 2 */ + union { + uint32_t e21a; + struct { DECL_BITFIELD(e21a); }; + }; + uint32_t /* b */:32, /* c */:32, /* d */:32; + }; + } extd; + +#undef __DECL_BITFIELD +#undef _DECL_BITFIELD +#undef DECL_BITFIELD + + /* Toolstack selected Hypervisor max_leaf (if non-zero). */ + uint8_t hv_limit, hv2_limit; + + /* Value calculated from raw data above. */ + uint8_t x86_vendor; +}; + +/* Temporary */ +#define cpuid_policy cpu_policy + struct old_cpu_policy { struct cpuid_policy *cpuid; @@ -19,6 +352,134 @@ struct cpu_policy_errors #define INIT_CPU_POLICY_ERRORS { -1, -1, -1 } +/* Fill in a featureset bitmap from a CPUID policy. */ +static inline void cpuid_policy_to_featureset( + const struct cpuid_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) +{ + fs[FEATURESET_1d] = p->basic._1d; + fs[FEATURESET_1c] = p->basic._1c; + fs[FEATURESET_e1d] = p->extd.e1d; + fs[FEATURESET_e1c] = p->extd.e1c; + fs[FEATURESET_Da1] = p->xstate.Da1; + fs[FEATURESET_7b0] = p->feat._7b0; + fs[FEATURESET_7c0] = p->feat._7c0; + fs[FEATURESET_e7d] = p->extd.e7d; + fs[FEATURESET_e8b] = p->extd.e8b; + fs[FEATURESET_7d0] = p->feat._7d0; + fs[FEATURESET_7a1] = p->feat._7a1; + fs[FEATURESET_e21a] = p->extd.e21a; + fs[FEATURESET_7b1] = p->feat._7b1; + fs[FEATURESET_7d2] = p->feat._7d2; + fs[FEATURESET_7c1] = p->feat._7c1; + fs[FEATURESET_7d1] = p->feat._7d1; +} + +/* Fill in a CPUID policy from a featureset bitmap. */ +static inline void cpuid_featureset_to_policy( + const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpuid_policy *p) +{ + p->basic._1d = fs[FEATURESET_1d]; + p->basic._1c = fs[FEATURESET_1c]; + p->extd.e1d = fs[FEATURESET_e1d]; + p->extd.e1c = fs[FEATURESET_e1c]; + p->xstate.Da1 = fs[FEATURESET_Da1]; + p->feat._7b0 = fs[FEATURESET_7b0]; + p->feat._7c0 = fs[FEATURESET_7c0]; + p->extd.e7d = fs[FEATURESET_e7d]; + p->extd.e8b = fs[FEATURESET_e8b]; + p->feat._7d0 = fs[FEATURESET_7d0]; + p->feat._7a1 = fs[FEATURESET_7a1]; + p->extd.e21a = fs[FEATURESET_e21a]; + p->feat._7b1 = fs[FEATURESET_7b1]; + p->feat._7d2 = fs[FEATURESET_7d2]; + p->feat._7c1 = fs[FEATURESET_7c1]; + p->feat._7d1 = fs[FEATURESET_7d1]; +} + +static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p) +{ + return ((uint64_t)p->xstate.xcr0_high << 32) | p->xstate.xcr0_low; +} + +static inline uint64_t cpuid_policy_xstates(const struct cpuid_policy *p) +{ + uint64_t val = p->xstate.xcr0_high | p->xstate.xss_high; + + return (val << 32) | p->xstate.xcr0_low | p->xstate.xss_low; +} + +const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature); + +/** + * Recalculate the content in a CPUID policy which is derived from raw data. + */ +void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p); + +/** + * Fill a CPUID policy using the native CPUID instruction. + * + * No sanitisation is performed, but synthesised values are calculated. + * Values may be influenced by a hypervisor or from masking/faulting + * configuration. + */ +void x86_cpuid_policy_fill_native(struct cpuid_policy *p); + +/** + * Clear leaf data beyond the policies max leaf/subleaf settings. + * + * Policy serialisation purposefully omits out-of-range leaves, because there + * are a large number of them due to vendor differences. However, when + * constructing new policies (e.g. levelling down), it is possible to end up + * with out-of-range leaves with stale content in them. This helper clears + * them. + */ +void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p); + +#ifdef __XEN__ +#include +typedef XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_leaf_buffer_t; +#else +#include +typedef xen_cpuid_leaf_t cpuid_leaf_buffer_t[]; +#endif + +/** + * Serialise a cpuid_policy object into an array of cpuid leaves. + * + * @param policy The cpuid_policy to serialise. + * @param leaves The array of leaves to serialise into. + * @param nr_entries The number of entries in 'leaves'. + * @returns -errno + * + * Writes at most CPUID_MAX_SERIALISED_LEAVES. May fail with -ENOBUFS if the + * leaves array is too short. On success, nr_entries is updated with the + * actual number of leaves written. + */ +int x86_cpuid_copy_to_buffer(const struct cpuid_policy *policy, + cpuid_leaf_buffer_t leaves, uint32_t *nr_entries); + +/** + * Unserialise a cpuid_policy object from an array of cpuid leaves. + * + * @param policy The cpuid_policy to unserialise into. + * @param leaves The array of leaves to unserialise from. + * @param nr_entries The number of entries in 'leaves'. + * @param err_leaf Optional hint for error diagnostics. + * @param err_subleaf Optional hint for error diagnostics. + * @returns -errno + * + * Reads at most CPUID_MAX_SERIALISED_LEAVES. May return -ERANGE if an + * incoming leaf is out of range of cpuid_policy, in which case the optional + * err_* pointers will identify the out-of-range indicies. + * + * No content validation of in-range leaves is performed. Synthesised data is + * recalculated. + */ +int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, + const cpuid_leaf_buffer_t leaves, + uint32_t nr_entries, uint32_t *err_leaf, + uint32_t *err_subleaf); + /* * Calculate whether two policies are compatible. * diff --git a/xen/include/xen/lib/x86/cpuid.h b/xen/include/xen/lib/x86/cpuid.h deleted file mode 100644 index fa98b371eef4..000000000000 --- a/xen/include/xen/lib/x86/cpuid.h +++ /dev/null @@ -1,475 +0,0 @@ -/* Common data structures and functions consumed by hypervisor and toolstack */ -#ifndef XEN_LIB_X86_CPUID_H -#define XEN_LIB_X86_CPUID_H - -#include - -#define FEATURESET_1d 0 /* 0x00000001.edx */ -#define FEATURESET_1c 1 /* 0x00000001.ecx */ -#define FEATURESET_e1d 2 /* 0x80000001.edx */ -#define FEATURESET_e1c 3 /* 0x80000001.ecx */ -#define FEATURESET_Da1 4 /* 0x0000000d:1.eax */ -#define FEATURESET_7b0 5 /* 0x00000007:0.ebx */ -#define FEATURESET_7c0 6 /* 0x00000007:0.ecx */ -#define FEATURESET_e7d 7 /* 0x80000007.edx */ -#define FEATURESET_e8b 8 /* 0x80000008.ebx */ -#define FEATURESET_7d0 9 /* 0x00000007:0.edx */ -#define FEATURESET_7a1 10 /* 0x00000007:1.eax */ -#define FEATURESET_e21a 11 /* 0x80000021.eax */ -#define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ -#define FEATURESET_7d2 13 /* 0x00000007:2.edx */ -#define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ -#define FEATURESET_7d1 15 /* 0x00000007:1.edx */ - -struct cpuid_leaf -{ - uint32_t a, b, c, d; -}; - -/* - * Versions of GCC before 5 unconditionally reserve %rBX as the PIC hard - * register, and are unable to cope with spilling it. This results in a - * rather cryptic error: - * error: inconsistent operand constraints in an ‘asm’ - * - * In affected situations, work around the issue by using a separate register - * to hold the the %rBX output, and xchg twice to leave %rBX preserved around - * the asm() statement. - */ -#if defined(__PIC__) && __GNUC__ < 5 && !defined(__clang__) && defined(__i386__) -# define XCHG_BX "xchg %%ebx, %[bx];" -# define BX_CON [bx] "=&r" -#elif defined(__PIC__) && __GNUC__ < 5 && !defined(__clang__) && \ - defined(__x86_64__) && (defined(__code_model_medium__) || \ - defined(__code_model_large__)) -# define XCHG_BX "xchg %%rbx, %q[bx];" -# define BX_CON [bx] "=&r" -#else -# define XCHG_BX "" -# define BX_CON "=&b" -#endif - -static inline void cpuid_leaf(uint32_t leaf, struct cpuid_leaf *l) -{ - asm ( XCHG_BX - "cpuid;" - XCHG_BX - : "=a" (l->a), BX_CON (l->b), "=&c" (l->c), "=&d" (l->d) - : "a" (leaf) ); -} - -static inline void cpuid_count_leaf( - uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *l) -{ - asm ( XCHG_BX - "cpuid;" - XCHG_BX - : "=a" (l->a), BX_CON (l->b), "=c" (l->c), "=&d" (l->d) - : "a" (leaf), "c" (subleaf) ); -} - -#undef BX_CON -#undef XCHG - -/** - * Given the vendor id from CPUID leaf 0, look up Xen's internal integer - * vendor ID. Returns X86_VENDOR_UNKNOWN for any unknown vendor. - */ -unsigned int x86_cpuid_lookup_vendor(uint32_t ebx, uint32_t ecx, uint32_t edx); - -/** - * Given Xen's internal vendor ID, return a string suitable for printing. - * Returns "Unknown" for any unrecognised ID. - */ -const char *x86_cpuid_vendor_to_str(unsigned int vendor); - -#define CPUID_GUEST_NR_BASIC (0xdu + 1) -#define CPUID_GUEST_NR_CACHE (5u + 1) -#define CPUID_GUEST_NR_FEAT (2u + 1) -#define CPUID_GUEST_NR_TOPO (1u + 1) -#define CPUID_GUEST_NR_XSTATE (62u + 1) -#define CPUID_GUEST_NR_EXTD_INTEL (0x8u + 1) -#define CPUID_GUEST_NR_EXTD_AMD (0x21u + 1) -#define CPUID_GUEST_NR_EXTD MAX(CPUID_GUEST_NR_EXTD_INTEL, \ - CPUID_GUEST_NR_EXTD_AMD) - -/* - * Maximum number of leaves a struct cpuid_policy turns into when serialised - * for interaction with the toolstack. (Sum of all leaves in each union, less - * the entries in basic which sub-unions hang off of.) - */ -#define CPUID_MAX_SERIALISED_LEAVES \ - (CPUID_GUEST_NR_BASIC + \ - CPUID_GUEST_NR_FEAT - !!CPUID_GUEST_NR_FEAT + \ - CPUID_GUEST_NR_CACHE - !!CPUID_GUEST_NR_CACHE + \ - CPUID_GUEST_NR_TOPO - !!CPUID_GUEST_NR_TOPO + \ - CPUID_GUEST_NR_XSTATE - !!CPUID_GUEST_NR_XSTATE + \ - CPUID_GUEST_NR_EXTD + 2 /* hv_limit and hv2_limit */ ) - -struct cpuid_policy -{ -#define DECL_BITFIELD(word) _DECL_BITFIELD(FEATURESET_ ## word) -#define _DECL_BITFIELD(x) __DECL_BITFIELD(x) -#define __DECL_BITFIELD(x) CPUID_BITFIELD_ ## x - - /* Basic leaves: 0x000000xx */ - union { - struct cpuid_leaf raw[CPUID_GUEST_NR_BASIC]; - struct { - /* Leaf 0x0 - Max and vendor. */ - uint32_t max_leaf, vendor_ebx, vendor_ecx, vendor_edx; - - /* Leaf 0x1 - Family/model/stepping and features. */ - uint32_t raw_fms; - uint8_t :8, /* Brand ID. */ - clflush_size, /* Number of 8-byte blocks per cache line. */ - lppp, /* Logical processors per package. */ - apic_id; /* Initial APIC ID. */ - union { - uint32_t _1c; - struct { DECL_BITFIELD(1c); }; - }; - union { - uint32_t _1d; - struct { DECL_BITFIELD(1d); }; - }; - - /* Leaf 0x2 - TLB/Cache/Prefetch. */ - uint8_t l2_nr_queries; /* Documented as fixed to 1. */ - uint8_t l2_desc[15]; - - uint64_t :64, :64; /* Leaf 0x3 - PSN. */ - uint64_t :64, :64; /* Leaf 0x4 - Structured Cache. */ - uint64_t :64, :64; /* Leaf 0x5 - MONITOR. */ - uint64_t :64, :64; /* Leaf 0x6 - Therm/Perf. */ - uint64_t :64, :64; /* Leaf 0x7 - Structured Features. */ - uint64_t :64, :64; /* Leaf 0x8 - rsvd */ - uint64_t :64, :64; /* Leaf 0x9 - DCA */ - - /* Leaf 0xa - Intel PMU. */ - uint8_t pmu_version, _pmu[15]; - - uint64_t :64, :64; /* Leaf 0xb - Topology. */ - uint64_t :64, :64; /* Leaf 0xc - rsvd */ - uint64_t :64, :64; /* Leaf 0xd - XSTATE. */ - }; - } basic; - - /* Structured cache leaf: 0x00000004[xx] */ - union { - struct cpuid_leaf raw[CPUID_GUEST_NR_CACHE]; - struct cpuid_cache_leaf { - uint32_t /* a */ type:5, level:3; - bool self_init:1, fully_assoc:1; - uint32_t :4, threads_per_cache:12, cores_per_package:6; - uint32_t /* b */ line_size:12, partitions:10, ways:10; - uint32_t /* c */ sets; - bool /* d */ wbinvd:1, inclusive:1, complex:1; - } subleaf[CPUID_GUEST_NR_CACHE]; - } cache; - - /* Structured feature leaf: 0x00000007[xx] */ - union { - struct cpuid_leaf raw[CPUID_GUEST_NR_FEAT]; - struct { - /* Subleaf 0. */ - uint32_t max_subleaf; - union { - uint32_t _7b0; - struct { DECL_BITFIELD(7b0); }; - }; - union { - uint32_t _7c0; - struct { DECL_BITFIELD(7c0); }; - }; - union { - uint32_t _7d0; - struct { DECL_BITFIELD(7d0); }; - }; - - /* Subleaf 1. */ - union { - uint32_t _7a1; - struct { DECL_BITFIELD(7a1); }; - }; - union { - uint32_t _7b1; - struct { DECL_BITFIELD(7b1); }; - }; - union { - uint32_t _7c1; - struct { DECL_BITFIELD(7c1); }; - }; - union { - uint32_t _7d1; - struct { DECL_BITFIELD(7d1); }; - }; - - /* Subleaf 2. */ - uint32_t /* a */:32, /* b */:32, /* c */:32; - union { - uint32_t _7d2; - struct { DECL_BITFIELD(7d2); }; - }; - }; - } feat; - - /* Extended topology enumeration: 0x0000000B[xx] */ - union { - struct cpuid_leaf raw[CPUID_GUEST_NR_TOPO]; - struct cpuid_topo_leaf { - uint32_t id_shift:5, :27; - uint16_t nr_logical, :16; - uint8_t level, type, :8, :8; - uint32_t x2apic_id; - } subleaf[CPUID_GUEST_NR_TOPO]; - } topo; - - /* Xstate feature leaf: 0x0000000D[xx] */ - union { - struct cpuid_leaf raw[CPUID_GUEST_NR_XSTATE]; - - struct { - /* Subleaf 0. */ - uint32_t xcr0_low, /* b */:32, max_size, xcr0_high; - - /* Subleaf 1. */ - union { - uint32_t Da1; - struct { DECL_BITFIELD(Da1); }; - }; - uint32_t /* b */:32, xss_low, xss_high; - }; - - /* Per-component common state. Valid for i >= 2. */ - struct { - uint32_t size, offset; - bool xss:1, align:1; - uint32_t _res_d; - } comp[CPUID_GUEST_NR_XSTATE]; - } xstate; - - /* Extended leaves: 0x800000xx */ - union { - struct cpuid_leaf raw[CPUID_GUEST_NR_EXTD]; - struct { - /* Leaf 0x80000000 - Max and vendor. */ - uint32_t max_leaf, vendor_ebx, vendor_ecx, vendor_edx; - - /* Leaf 0x80000001 - Family/model/stepping and features. */ - uint32_t raw_fms, /* b */:32; - union { - uint32_t e1c; - struct { DECL_BITFIELD(e1c); }; - }; - union { - uint32_t e1d; - struct { DECL_BITFIELD(e1d); }; - }; - - uint64_t :64, :64; /* Brand string. */ - uint64_t :64, :64; /* Brand string. */ - uint64_t :64, :64; /* Brand string. */ - uint64_t :64, :64; /* L1 cache/TLB. */ - uint64_t :64, :64; /* L2/3 cache/TLB. */ - - /* Leaf 0x80000007 - Advanced Power Management. */ - uint32_t /* a */:32, /* b */:32, /* c */:32; - union { - uint32_t e7d; - struct { DECL_BITFIELD(e7d); }; - }; - - /* Leaf 0x80000008 - Misc addr/feature info. */ - uint8_t maxphysaddr, maxlinaddr, :8, :8; - union { - uint32_t e8b; - struct { DECL_BITFIELD(e8b); }; - }; - uint32_t nc:8, :4, apic_id_size:4, :16; - uint32_t /* d */:32; - - uint64_t :64, :64; /* Leaf 0x80000009. */ - uint64_t :64, :64; /* Leaf 0x8000000a - SVM rev and features. */ - uint64_t :64, :64; /* Leaf 0x8000000b. */ - uint64_t :64, :64; /* Leaf 0x8000000c. */ - uint64_t :64, :64; /* Leaf 0x8000000d. */ - uint64_t :64, :64; /* Leaf 0x8000000e. */ - uint64_t :64, :64; /* Leaf 0x8000000f. */ - uint64_t :64, :64; /* Leaf 0x80000010. */ - uint64_t :64, :64; /* Leaf 0x80000011. */ - uint64_t :64, :64; /* Leaf 0x80000012. */ - uint64_t :64, :64; /* Leaf 0x80000013. */ - uint64_t :64, :64; /* Leaf 0x80000014. */ - uint64_t :64, :64; /* Leaf 0x80000015. */ - uint64_t :64, :64; /* Leaf 0x80000016. */ - uint64_t :64, :64; /* Leaf 0x80000017. */ - uint64_t :64, :64; /* Leaf 0x80000018. */ - uint64_t :64, :64; /* Leaf 0x80000019 - TLB 1GB Identifiers. */ - uint64_t :64, :64; /* Leaf 0x8000001a - Performance related info. */ - uint64_t :64, :64; /* Leaf 0x8000001b - IBS feature information. */ - uint64_t :64, :64; /* Leaf 0x8000001c. */ - uint64_t :64, :64; /* Leaf 0x8000001d - Cache properties. */ - uint64_t :64, :64; /* Leaf 0x8000001e - Extd APIC/Core/Node IDs. */ - uint64_t :64, :64; /* Leaf 0x8000001f - AMD Secure Encryption. */ - uint64_t :64, :64; /* Leaf 0x80000020 - Platform QoS. */ - - /* Leaf 0x80000021 - Extended Feature 2 */ - union { - uint32_t e21a; - struct { DECL_BITFIELD(e21a); }; - }; - uint32_t /* b */:32, /* c */:32, /* d */:32; - }; - } extd; - -#undef __DECL_BITFIELD -#undef _DECL_BITFIELD -#undef DECL_BITFIELD - - /* Toolstack selected Hypervisor max_leaf (if non-zero). */ - uint8_t hv_limit, hv2_limit; - - /* Value calculated from raw data above. */ - uint8_t x86_vendor; -}; - -/* Fill in a featureset bitmap from a CPUID policy. */ -static inline void cpuid_policy_to_featureset( - const struct cpuid_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) -{ - fs[FEATURESET_1d] = p->basic._1d; - fs[FEATURESET_1c] = p->basic._1c; - fs[FEATURESET_e1d] = p->extd.e1d; - fs[FEATURESET_e1c] = p->extd.e1c; - fs[FEATURESET_Da1] = p->xstate.Da1; - fs[FEATURESET_7b0] = p->feat._7b0; - fs[FEATURESET_7c0] = p->feat._7c0; - fs[FEATURESET_e7d] = p->extd.e7d; - fs[FEATURESET_e8b] = p->extd.e8b; - fs[FEATURESET_7d0] = p->feat._7d0; - fs[FEATURESET_7a1] = p->feat._7a1; - fs[FEATURESET_e21a] = p->extd.e21a; - fs[FEATURESET_7b1] = p->feat._7b1; - fs[FEATURESET_7d2] = p->feat._7d2; - fs[FEATURESET_7c1] = p->feat._7c1; - fs[FEATURESET_7d1] = p->feat._7d1; -} - -/* Fill in a CPUID policy from a featureset bitmap. */ -static inline void cpuid_featureset_to_policy( - const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpuid_policy *p) -{ - p->basic._1d = fs[FEATURESET_1d]; - p->basic._1c = fs[FEATURESET_1c]; - p->extd.e1d = fs[FEATURESET_e1d]; - p->extd.e1c = fs[FEATURESET_e1c]; - p->xstate.Da1 = fs[FEATURESET_Da1]; - p->feat._7b0 = fs[FEATURESET_7b0]; - p->feat._7c0 = fs[FEATURESET_7c0]; - p->extd.e7d = fs[FEATURESET_e7d]; - p->extd.e8b = fs[FEATURESET_e8b]; - p->feat._7d0 = fs[FEATURESET_7d0]; - p->feat._7a1 = fs[FEATURESET_7a1]; - p->extd.e21a = fs[FEATURESET_e21a]; - p->feat._7b1 = fs[FEATURESET_7b1]; - p->feat._7d2 = fs[FEATURESET_7d2]; - p->feat._7c1 = fs[FEATURESET_7c1]; - p->feat._7d1 = fs[FEATURESET_7d1]; -} - -static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p) -{ - return ((uint64_t)p->xstate.xcr0_high << 32) | p->xstate.xcr0_low; -} - -static inline uint64_t cpuid_policy_xstates(const struct cpuid_policy *p) -{ - uint64_t val = p->xstate.xcr0_high | p->xstate.xss_high; - - return (val << 32) | p->xstate.xcr0_low | p->xstate.xss_low; -} - -const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature); - -/** - * Recalculate the content in a CPUID policy which is derived from raw data. - */ -void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p); - -/** - * Fill a CPUID policy using the native CPUID instruction. - * - * No sanitisation is performed, but synthesised values are calculated. - * Values may be influenced by a hypervisor or from masking/faulting - * configuration. - */ -void x86_cpuid_policy_fill_native(struct cpuid_policy *p); - -/** - * Clear leaf data beyond the policies max leaf/subleaf settings. - * - * Policy serialisation purposefully omits out-of-range leaves, because there - * are a large number of them due to vendor differences. However, when - * constructing new policies (e.g. levelling down), it is possible to end up - * with out-of-range leaves with stale content in them. This helper clears - * them. - */ -void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p); - -#ifdef __XEN__ -#include -typedef XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_leaf_buffer_t; -#else -#include -typedef xen_cpuid_leaf_t cpuid_leaf_buffer_t[]; -#endif - -/** - * Serialise a cpuid_policy object into an array of cpuid leaves. - * - * @param policy The cpuid_policy to serialise. - * @param leaves The array of leaves to serialise into. - * @param nr_entries The number of entries in 'leaves'. - * @returns -errno - * - * Writes at most CPUID_MAX_SERIALISED_LEAVES. May fail with -ENOBUFS if the - * leaves array is too short. On success, nr_entries is updated with the - * actual number of leaves written. - */ -int x86_cpuid_copy_to_buffer(const struct cpuid_policy *policy, - cpuid_leaf_buffer_t leaves, uint32_t *nr_entries); - -/** - * Unserialise a cpuid_policy object from an array of cpuid leaves. - * - * @param policy The cpuid_policy to unserialise into. - * @param leaves The array of leaves to unserialise from. - * @param nr_entries The number of entries in 'leaves'. - * @param err_leaf Optional hint for error diagnostics. - * @param err_subleaf Optional hint for error diagnostics. - * @returns -errno - * - * Reads at most CPUID_MAX_SERIALISED_LEAVES. May return -ERANGE if an - * incoming leaf is out of range of cpuid_policy, in which case the optional - * err_* pointers will identify the out-of-range indicies. - * - * No content validation of in-range leaves is performed. Synthesised data is - * recalculated. - */ -int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, - const cpuid_leaf_buffer_t leaves, - uint32_t nr_entries, uint32_t *err_leaf, - uint32_t *err_subleaf); - -#endif /* !XEN_LIB_X86_CPUID_H */ - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * tab-width: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index 8eb88314f53c..e81f76c779c0 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -1,6 +1,6 @@ #include "private.h" -#include +#include static void zero_leaves(struct cpuid_leaf *l, unsigned int first, unsigned int last) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:53:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:53:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517735.803550 (Exim 4.92) (envelope-from ) id 1pjdLg-0001DI-Qi; Tue, 04 Apr 2023 09:53:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517735.803550; Tue, 04 Apr 2023 09:53:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLg-0001D2-NM; Tue, 04 Apr 2023 09:53:08 +0000 Received: by outflank-mailman (input) for mailman id 517735; Tue, 04 Apr 2023 09:53:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdLe-0005bo-Du for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:07 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e112011-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:53:05 +0200 (CEST) Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=freeip.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pjdL9-00FEvo-3m; Tue, 04 Apr 2023 09:52:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e112011-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wvgoJQ9Lm0ccWU181xaSUlae1PKiLsa2k6MVbJjeNtE=; b=YUP5VxUUDjN7PoRvhJ1Z/6AqgN 7yoyEVN2XqXQTuYI69bJS2qGUdan3oCjnkR12UKpNSlPUNTUdzpk5DY/xbugywWlO6LHyyXlzhRbI K2Ywx250HO65Ts7l7gE4H1aQbHnCpljV8c58aS4k6DHBdPMLQmOVkoRorlscUWkSdPLboEUeK6DPB OiMDf9gevMIN5nmYLglpR/Erhx9f7yjXIm8kaAmocRrPc0s03A8mUs0e/00r9k3pYmxuyFakN/IxA 6AYcj54rWR37VJZarjItBstYW5YjQFIRie+IY8z2DEDap3aV0Guw7YGhSeXGk6I1dAc1AyFwAinCp 5FVxq6Iw==; Message-ID: Subject: Re: [PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore From: David Woodhouse To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , "Daniel P." =?ISO-8859-1?Q?Berrang=E9?= , Anthony Perard Date: Tue, 04 Apr 2023 10:52:32 +0100 In-Reply-To: <20230403183004.347205-9-stefanha@redhat.com> References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-9-stefanha@redhat.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-7s6HEpTuj3u8ifXuNfwk" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-7s6HEpTuj3u8ifXuNfwk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-04-03 at 14:29 -0400, Stefan Hajnoczi wrote: > There is no need to suspend activity between aio_disable_external() and > aio_enable_external(), which is mainly used for the block layer's drain > operation. >=20 > This is part of ongoing work to remove the aio_disable_external() API. >=20 > Signed-off-by: Stefan Hajnoczi Reviewed-by: David Woodhouse Thanks. > --- > =C2=A0hw/i386/kvm/xen_xenstore.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c > index 900679af8a..6e81bc8791 100644 > --- a/hw/i386/kvm/xen_xenstore.c > +++ b/hw/i386/kvm/xen_xenstore.c > @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Er= ror **errp) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 error_setg(errp, "Xensto= re evtchn port init failed"); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; > =C2=A0=C2=A0=C2=A0=C2=A0 } > -=C2=A0=C2=A0=C2=A0 aio_set_fd_handler(qemu_get_aio_context(), xen_be_evt= chn_fd(s->eh), true, > +=C2=A0=C2=A0=C2=A0 aio_set_fd_handler(qemu_get_aio_context(), xen_be_evt= chn_fd(s->eh), false, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xen_xens= tore_event, NULL, NULL, NULL, s); > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 s->impl =3D xs_impl_create(xen_domid); --=-7s6HEpTuj3u8ifXuNfwk Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDA0MDk1MjMyWjAvBgkqhkiG9w0BCQQxIgQgrsepn9Vl DdKC1BeQEBFEi/a6RbJbt8TXN1jmHO7GNJ0wgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAVZ1qfTa9Nxee1RiBcOJYy3wtZjMAiU4eW 9bj9KacxKWNjZGupFHiljaK3GCNNbfQX0SaycrtzkHxnnGpBSnMy1uluAbCx/4Pxkw5tEO3s2oMl HJS70RRWDS9q3d26tgu6znZFl/JoVdNI9CljOw6adKOgDY4QL5TLEbGW4/CQJmDmLgnROIoiId9k l+EWUDZZEofAxneyZP1GpSV3f5945HxOxl5FlLlP2GmuEzpBZlIWsocyozX2FeKFSTR0BNIPssD0 eS1fK3j9IEthkl3t1IlpGQPmkG8aYeRgNvpZc41eA2iVzFKGar5ILukzrCwc2Pp8sHC4bQSR7oB2 xejzhzdBAYvMzu1FYLKqYvAmqT/xqXjxIjbucwT68yyLh8pp7NE5uIBl2L4acjmMfmFRJQAYSezP t/VWPxuZunQhzDzo4a0unsZP9I6KLfrnPggVbASb9oAfxCC8Hu4wPjbbyhuOs36+pHqLPcHKSVno sP4Z6mQnGOT8ng6LTCiYkq7LQkEHqgHFHIn5ScqYIY1x4VUQ4lUVkw2PE/MNacZ+hIsj7GYry2C7 9o+aa1qw2f5NCns8ITlcqC3vdDks86MvETwP4V0tnRES+P91GPB0KnWhFUwSCIHLRFOni0GGggtj O6rNb9HAbDhwXn12vYtafW+933ruJSCaFbig3SeFsQAAAAAAAA== --=-7s6HEpTuj3u8ifXuNfwk-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:59:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:59:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517745.803559 (Exim 4.92) (envelope-from ) id 1pjdRK-00037Y-Hw; Tue, 04 Apr 2023 09:58:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517745.803559; Tue, 04 Apr 2023 09:58:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdRK-00037R-Eu; Tue, 04 Apr 2023 09:58:58 +0000 Received: by outflank-mailman (input) for mailman id 517745; Tue, 04 Apr 2023 09:58:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdMR-0005bo-Qm for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:56 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a1b42c3-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:53:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a1b42c3-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602032; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+gBx+55wWG2Xc8HbkdAE6jzV3hAbtN970XBfRirIXxI=; b=UCF0+KPNPzktodWBff3mT/1jmkk0sEMy6VSSA8VMX2UUtV0oh57Ss0sO KG3xCyeBEas0u6P0n3/FCXgn8oW4wVG0ROtacZybgn0SYnw3z55kgUjvf WxQVDTpi5uYQadEGOEFBSGMI/yiKW+c9mk18QQDhmYNv1PcmoK1OCiEky k=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104656675 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:uS3LlKIe1D1PhJBLFE+RrpUlxSXFcZb7ZxGr2PjKsXjdYENS0mMCm 2sYXW+OOvnfZ2TxcoxyaYTjpE5XusPdyoc2QAtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c56AFhr5 P4KDQwqVSyYmfDm5aiSUu9z05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TTHZkLwxjG+ T+uE2LRBwBGbYOGkQS+ryijj8nQsAb8UbkwG+jtnhJtqALKnTFCYPEMbnOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHsljw2VsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LQHGz XfQwYmvX2Y29uTIFzTErOz8QS6O1TY9IG47QD4GXy45xOLfu58h3jfVZ85lD/vg5jHqIg0c0 wxmvQBn2eVL0JFVjfrilbzUq2ny/8aUF2bZ8i2SBzv4tV0hOeZJcqTysTDmAeB8wJF1p7Vrl FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/LF7rVxBA1b5IehtDMhWfS+FyPosdz7ze 1P0sghM/pJVN3bCRfYpM9rsV5p7l/O6S4SNuhXogj1mO8AZSeN61Hs2OR74M57FyyDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDuJLbiilkTP7FZrTCLNIVvzGAfUP79RAWLtiFm9z uuzwOPRlEoDCrSiPXCHmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQgnN19e5LWsdRrFY IronPort-HdrOrdr: A9a23:xxqf5a2COqozSHZlDIYQaQqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104656675" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 11/15] x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c Date: Tue, 4 Apr 2023 10:52:18 +0100 Message-ID: <20230404095222.1373721-12-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Switch to the newer cpu_policy nomenclature. Do some easy cleanup of includes. No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New --- xen/arch/x86/cpu-policy.c | 752 ++++++++++++++++++++++++ xen/arch/x86/cpuid.c | 817 +------------------------- xen/arch/x86/hvm/hvm.c | 1 - xen/arch/x86/include/asm/cpu-policy.h | 6 + xen/arch/x86/include/asm/cpuid.h | 11 +- xen/arch/x86/pv/domain.c | 1 + xen/arch/x86/setup.c | 2 - 7 files changed, 764 insertions(+), 826 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index f6a2317ed7bd..83186e940ca7 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -1,13 +1,19 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include #include +#include #include #include +#include #include +#include +#include #include +#include #include +#include struct cpu_policy __ro_after_init raw_cpu_policy; struct cpu_policy __ro_after_init host_cpu_policy; @@ -20,10 +26,332 @@ struct cpu_policy __ro_after_init hvm_max_cpu_policy; struct cpu_policy __ro_after_init hvm_def_cpu_policy; #endif +const uint32_t known_features[] = INIT_KNOWN_FEATURES; + +static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; +static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; +static const uint32_t __initconst hvm_hap_max_featuremask[] = + INIT_HVM_HAP_MAX_FEATURES; +static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; +static const uint32_t __initconst hvm_shadow_def_featuremask[] = + INIT_HVM_SHADOW_DEF_FEATURES; +static const uint32_t __initconst hvm_hap_def_featuremask[] = + INIT_HVM_HAP_DEF_FEATURES; +static const uint32_t deep_features[] = INIT_DEEP_FEATURES; + +static const struct feature_name { + const char *name; + unsigned int bit; +} feature_names[] __initconstrel = INIT_FEATURE_NAMES; + +/* + * Parse a list of cpuid feature names -> bool, calling the callback for any + * matches found. + * + * always_inline, because this is init code only and we really don't want a + * function pointer call in the middle of the loop. + */ +static int __init always_inline parse_cpuid( + const char *s, void (*callback)(unsigned int feat, bool val)) +{ + const char *ss; + int val, rc = 0; + + do { + const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; + const char *feat; + + ss = strchr(s, ','); + if ( !ss ) + ss = strchr(s, '\0'); + + /* Skip the 'no-' prefix for name comparisons. */ + feat = s; + if ( strncmp(s, "no-", 3) == 0 ) + feat += 3; + + /* (Re)initalise lhs and rhs for binary search. */ + lhs = feature_names; + rhs = feature_names + ARRAY_SIZE(feature_names); + + while ( lhs < rhs ) + { + int res; + + mid = lhs + (rhs - lhs) / 2; + res = cmdline_strcmp(feat, mid->name); + + if ( res < 0 ) + { + rhs = mid; + continue; + } + if ( res > 0 ) + { + lhs = mid + 1; + continue; + } + + if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) + { + callback(mid->bit, val); + mid = NULL; + } + + break; + } + + /* + * Mid being NULL means that the name and boolean were successfully + * identified. Everything else is an error. + */ + if ( mid ) + rc = -EINVAL; + + s = ss + 1; + } while ( *ss ); + + return rc; +} + +static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) +{ + if ( !val ) + setup_clear_cpu_cap(feat); + else if ( feat == X86_FEATURE_RDRAND && + (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) + setup_force_cpu_cap(X86_FEATURE_RDRAND); +} + +static int __init cf_check parse_xen_cpuid(const char *s) +{ + return parse_cpuid(s, _parse_xen_cpuid); +} +custom_param("cpuid", parse_xen_cpuid); + +static bool __initdata dom0_cpuid_cmdline; +static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; +static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; + +static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) +{ + __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); + __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); +} + +static int __init cf_check parse_dom0_cpuid(const char *s) +{ + dom0_cpuid_cmdline = true; + + return parse_cpuid(s, _parse_dom0_cpuid); +} +custom_param("dom0-cpuid", parse_dom0_cpuid); + +#define EMPTY_LEAF ((struct cpuid_leaf){}) +static void zero_leaves(struct cpuid_leaf *l, + unsigned int first, unsigned int last) +{ + memset(&l[first], 0, sizeof(*l) * (last - first + 1)); +} + +static void sanitise_featureset(uint32_t *fs) +{ + /* for_each_set_bit() uses unsigned longs. Extend with zeroes. */ + uint32_t disabled_features[ + ROUNDUP(FSCAPINTS, sizeof(unsigned long)/sizeof(uint32_t))] = {}; + unsigned int i; + + for ( i = 0; i < FSCAPINTS; ++i ) + { + /* Clamp to known mask. */ + fs[i] &= known_features[i]; + + /* + * Identify which features with deep dependencies have been + * disabled. + */ + disabled_features[i] = ~fs[i] & deep_features[i]; + } + + for_each_set_bit(i, (void *)disabled_features, + sizeof(disabled_features) * 8) + { + const uint32_t *dfs = x86_cpuid_lookup_deep_deps(i); + unsigned int j; + + ASSERT(dfs); /* deep_features[] should guarentee this. */ + + for ( j = 0; j < FSCAPINTS; ++j ) + { + fs[j] &= ~dfs[j]; + disabled_features[j] &= ~dfs[j]; + } + } +} + +static void recalculate_xstate(struct cpu_policy *p) +{ + uint64_t xstates = XSTATE_FP_SSE; + uint32_t xstate_size = XSTATE_AREA_MIN_SIZE; + unsigned int i, Da1 = p->xstate.Da1; + + /* + * The Da1 leaf is the only piece of information preserved in the common + * case. Everything else is derived from other feature state. + */ + memset(&p->xstate, 0, sizeof(p->xstate)); + + if ( !p->basic.xsave ) + return; + + if ( p->basic.avx ) + { + xstates |= X86_XCR0_YMM; + xstate_size = max(xstate_size, + xstate_offsets[X86_XCR0_YMM_POS] + + xstate_sizes[X86_XCR0_YMM_POS]); + } + + if ( p->feat.mpx ) + { + xstates |= X86_XCR0_BNDREGS | X86_XCR0_BNDCSR; + xstate_size = max(xstate_size, + xstate_offsets[X86_XCR0_BNDCSR_POS] + + xstate_sizes[X86_XCR0_BNDCSR_POS]); + } + + if ( p->feat.avx512f ) + { + xstates |= X86_XCR0_OPMASK | X86_XCR0_ZMM | X86_XCR0_HI_ZMM; + xstate_size = max(xstate_size, + xstate_offsets[X86_XCR0_HI_ZMM_POS] + + xstate_sizes[X86_XCR0_HI_ZMM_POS]); + } + + if ( p->feat.pku ) + { + xstates |= X86_XCR0_PKRU; + xstate_size = max(xstate_size, + xstate_offsets[X86_XCR0_PKRU_POS] + + xstate_sizes[X86_XCR0_PKRU_POS]); + } + + p->xstate.max_size = xstate_size; + p->xstate.xcr0_low = xstates & ~XSTATE_XSAVES_ONLY; + p->xstate.xcr0_high = (xstates & ~XSTATE_XSAVES_ONLY) >> 32; + + p->xstate.Da1 = Da1; + if ( p->xstate.xsaves ) + { + p->xstate.xss_low = xstates & XSTATE_XSAVES_ONLY; + p->xstate.xss_high = (xstates & XSTATE_XSAVES_ONLY) >> 32; + } + else + xstates &= ~XSTATE_XSAVES_ONLY; + + for ( i = 2; i < min(63ul, ARRAY_SIZE(p->xstate.comp)); ++i ) + { + uint64_t curr_xstate = 1ul << i; + + if ( !(xstates & curr_xstate) ) + continue; + + p->xstate.comp[i].size = xstate_sizes[i]; + p->xstate.comp[i].offset = xstate_offsets[i]; + p->xstate.comp[i].xss = curr_xstate & XSTATE_XSAVES_ONLY; + p->xstate.comp[i].align = curr_xstate & xstate_align; + } +} + +/* + * Misc adjustments to the policy. Mostly clobbering reserved fields and + * duplicating shared fields. Intentionally hidden fields are annotated. + */ +static void recalculate_misc(struct cpu_policy *p) +{ + p->basic.raw_fms &= 0x0fff0fff; /* Clobber Processor Type on Intel. */ + p->basic.apic_id = 0; /* Dynamic. */ + + p->basic.raw[0x5] = EMPTY_LEAF; /* MONITOR not exposed to guests. */ + p->basic.raw[0x6] = EMPTY_LEAF; /* Therm/Power not exposed to guests. */ + + p->basic.raw[0x8] = EMPTY_LEAF; + + /* TODO: Rework topology logic. */ + memset(p->topo.raw, 0, sizeof(p->topo.raw)); + + p->basic.raw[0xc] = EMPTY_LEAF; + + p->extd.e1d &= ~CPUID_COMMON_1D_FEATURES; + + /* Most of Power/RAS hidden from guests. */ + p->extd.raw[0x7].a = p->extd.raw[0x7].b = p->extd.raw[0x7].c = 0; + + p->extd.raw[0x8].d = 0; + + switch ( p->x86_vendor ) + { + case X86_VENDOR_INTEL: + p->basic.l2_nr_queries = 1; /* Fixed to 1 query. */ + p->basic.raw[0x3] = EMPTY_LEAF; /* PSN - always hidden. */ + p->basic.raw[0x9] = EMPTY_LEAF; /* DCA - always hidden. */ + + p->extd.vendor_ebx = 0; + p->extd.vendor_ecx = 0; + p->extd.vendor_edx = 0; + + p->extd.raw[0x1].a = p->extd.raw[0x1].b = 0; + + p->extd.raw[0x5] = EMPTY_LEAF; + p->extd.raw[0x6].a = p->extd.raw[0x6].b = p->extd.raw[0x6].d = 0; + + p->extd.raw[0x8].a &= 0x0000ffff; + p->extd.raw[0x8].c = 0; + break; + + case X86_VENDOR_AMD: + case X86_VENDOR_HYGON: + zero_leaves(p->basic.raw, 0x2, 0x3); + memset(p->cache.raw, 0, sizeof(p->cache.raw)); + zero_leaves(p->basic.raw, 0x9, 0xa); + + p->extd.vendor_ebx = p->basic.vendor_ebx; + p->extd.vendor_ecx = p->basic.vendor_ecx; + p->extd.vendor_edx = p->basic.vendor_edx; + + p->extd.raw_fms = p->basic.raw_fms; + p->extd.raw[0x1].b &= 0xff00ffff; + p->extd.e1d |= p->basic._1d & CPUID_COMMON_1D_FEATURES; + + p->extd.raw[0x8].a &= 0x0000ffff; /* GuestMaxPhysAddr hidden. */ + p->extd.raw[0x8].c &= 0x0003f0ff; + + p->extd.raw[0x9] = EMPTY_LEAF; + + zero_leaves(p->extd.raw, 0xb, 0x18); + + /* 0x19 - TLB details. Pass through. */ + /* 0x1a - Perf hints. Pass through. */ + + p->extd.raw[0x1b] = EMPTY_LEAF; /* IBS - not supported. */ + p->extd.raw[0x1c] = EMPTY_LEAF; /* LWP - not supported. */ + p->extd.raw[0x1d] = EMPTY_LEAF; /* TopoExt Cache */ + p->extd.raw[0x1e] = EMPTY_LEAF; /* TopoExt APIC ID/Core/Node */ + p->extd.raw[0x1f] = EMPTY_LEAF; /* SEV */ + p->extd.raw[0x20] = EMPTY_LEAF; /* Platform QoS */ + break; + } +} + static void __init calculate_raw_policy(void) { struct cpu_policy *p = &raw_cpu_policy; + x86_cpuid_policy_fill_native(p); + + /* Nothing good will come from Xen and libx86 disagreeing on vendor. */ + ASSERT(p->x86_vendor == boot_cpu_data.x86_vendor); + /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ /* Was already added by probe_cpuid_faulting() */ @@ -34,9 +362,50 @@ static void __init calculate_raw_policy(void) static void __init calculate_host_policy(void) { struct cpu_policy *p = &host_cpu_policy; + unsigned int max_extd_leaf; *p = raw_cpu_policy; + p->basic.max_leaf = + min_t(uint32_t, p->basic.max_leaf, ARRAY_SIZE(p->basic.raw) - 1); + p->feat.max_subleaf = + min_t(uint32_t, p->feat.max_subleaf, ARRAY_SIZE(p->feat.raw) - 1); + + max_extd_leaf = p->extd.max_leaf; + + /* + * For AMD/Hygon hardware before Zen3, we unilaterally modify LFENCE to be + * dispatch serialising for Spectre mitigations. Extend max_extd_leaf + * beyond what hardware supports, to include the feature leaf containing + * this information. + */ + if ( cpu_has_lfence_dispatch ) + max_extd_leaf = max(max_extd_leaf, 0x80000021); + + p->extd.max_leaf = 0x80000000 | min_t(uint32_t, max_extd_leaf & 0xffff, + ARRAY_SIZE(p->extd.raw) - 1); + + x86_cpu_featureset_to_policy(boot_cpu_data.x86_capability, p); + recalculate_xstate(p); + recalculate_misc(p); + + /* When vPMU is disabled, drop it from the host policy. */ + if ( vpmu_mode == XENPMU_MODE_OFF ) + p->basic.raw[0xa] = EMPTY_LEAF; + + if ( p->extd.svm ) + { + /* Clamp to implemented features which require hardware support. */ + p->extd.raw[0xa].d &= ((1u << SVM_FEATURE_NPT) | + (1u << SVM_FEATURE_LBRV) | + (1u << SVM_FEATURE_NRIPS) | + (1u << SVM_FEATURE_PAUSEFILTER) | + (1u << SVM_FEATURE_DECODEASSISTS)); + /* Enable features which are always emulated. */ + p->extd.raw[0xa].d |= ((1u << SVM_FEATURE_VMCBCLEAN) | + (1u << SVM_FEATURE_TSCRATEMSR)); + } + /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ /* probe_cpuid_faulting() sanity checks presence of MISC_FEATURES_ENABLES */ p->platform_info.cpuid_faulting = cpu_has_cpuid_faulting; @@ -51,11 +420,88 @@ static void __init calculate_host_policy(void) ARCH_CAPS_PBRSB_NO); } +static void __init guest_common_default_feature_adjustments(uint32_t *fs) +{ + /* + * IvyBridge client parts suffer from leakage of RDRAND data due to SRBDS + * (XSA-320 / CVE-2020-0543), and won't be receiving microcode to + * compensate. + * + * Mitigate by hiding RDRAND from guests by default, unless explicitly + * overridden on the Xen command line (cpuid=rdrand). Irrespective of the + * default setting, guests can use RDRAND if explicitly enabled + * (cpuid="host,rdrand=1") in the VM's config file, and VMs which were + * previously using RDRAND can migrate in. + */ + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && + boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x3a && + cpu_has_rdrand && !is_forced_cpu_cap(X86_FEATURE_RDRAND) ) + __clear_bit(X86_FEATURE_RDRAND, fs); + + /* + * On certain hardware, speculative or errata workarounds can result in + * TSX being placed in "force-abort" mode, where it doesn't actually + * function as expected, but is technically compatible with the ISA. + * + * Do not advertise RTM to guests by default if it won't actually work. + */ + if ( rtm_disabled ) + __clear_bit(X86_FEATURE_RTM, fs); +} + +static void __init guest_common_feature_adjustments(uint32_t *fs) +{ + /* Unconditionally claim to be able to set the hypervisor bit. */ + __set_bit(X86_FEATURE_HYPERVISOR, fs); + + /* + * If IBRS is offered to the guest, unconditionally offer STIBP. It is a + * nop on non-HT hardware, and has this behaviour to make heterogeneous + * setups easier to manage. + */ + if ( test_bit(X86_FEATURE_IBRSB, fs) ) + __set_bit(X86_FEATURE_STIBP, fs); + if ( test_bit(X86_FEATURE_IBRS, fs) ) + __set_bit(X86_FEATURE_AMD_STIBP, fs); + + /* + * On hardware which supports IBRS/IBPB, we can offer IBPB independently + * of IBRS by using the AMD feature bit. An administrator may wish for + * performance reasons to offer IBPB without IBRS. + */ + if ( host_cpu_policy.feat.ibrsb ) + __set_bit(X86_FEATURE_IBPB, fs); +} + static void __init calculate_pv_max_policy(void) { struct cpu_policy *p = &pv_max_cpu_policy; + uint32_t fs[FSCAPINTS]; + unsigned int i; *p = host_cpu_policy; + x86_cpu_policy_to_featureset(p, fs); + + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) + fs[i] &= pv_max_featuremask[i]; + + /* + * If Xen isn't virtualising MSR_SPEC_CTRL for PV guests (functional + * availability, or admin choice), hide the feature. + */ + if ( !boot_cpu_has(X86_FEATURE_SC_MSR_PV) ) + { + __clear_bit(X86_FEATURE_IBRSB, fs); + __clear_bit(X86_FEATURE_IBRS, fs); + } + + guest_common_feature_adjustments(fs); + + sanitise_featureset(fs); + x86_cpu_featureset_to_policy(fs, p); + recalculate_xstate(p); + + p->extd.raw[0xa] = EMPTY_LEAF; /* No SVM for PV guests. */ p->arch_caps.raw = 0; /* Not supported yet. */ } @@ -63,15 +509,112 @@ static void __init calculate_pv_max_policy(void) static void __init calculate_pv_def_policy(void) { struct cpu_policy *p = &pv_def_cpu_policy; + uint32_t fs[FSCAPINTS]; + unsigned int i; *p = pv_max_cpu_policy; + x86_cpu_policy_to_featureset(p, fs); + + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) + fs[i] &= pv_def_featuremask[i]; + + guest_common_feature_adjustments(fs); + guest_common_default_feature_adjustments(fs); + + sanitise_featureset(fs); + x86_cpu_featureset_to_policy(fs, p); + recalculate_xstate(p); } static void __init calculate_hvm_max_policy(void) { struct cpu_policy *p = &hvm_max_cpu_policy; + uint32_t fs[FSCAPINTS]; + unsigned int i; + const uint32_t *mask; *p = host_cpu_policy; + x86_cpu_policy_to_featureset(p, fs); + + mask = hvm_hap_supported() ? + hvm_hap_max_featuremask : hvm_shadow_max_featuremask; + + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) + fs[i] &= mask[i]; + + /* + * Xen can provide an (x2)APIC emulation to HVM guests even if the host's + * (x2)APIC isn't enabled. + */ + __set_bit(X86_FEATURE_APIC, fs); + __set_bit(X86_FEATURE_X2APIC, fs); + + /* + * We don't support EFER.LMSLE at all. AMD has dropped the feature from + * hardware and allocated a CPUID bit to indicate its absence. + */ + __set_bit(X86_FEATURE_NO_LMSL, fs); + + /* + * On AMD, PV guests are entirely unable to use SYSENTER as Xen runs in + * long mode (and init_amd() has cleared it out of host capabilities), but + * HVM guests are able if running in protected mode. + */ + if ( (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) && + raw_cpu_policy.basic.sep ) + __set_bit(X86_FEATURE_SEP, fs); + + /* + * VIRT_SSBD is exposed in the default policy as a result of + * amd_virt_spec_ctrl being set, it also needs exposing in the max policy. + */ + if ( amd_virt_spec_ctrl ) + __set_bit(X86_FEATURE_VIRT_SSBD, fs); + + /* + * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional + * availability, or admin choice), hide the feature. + */ + if ( !boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ) + { + __clear_bit(X86_FEATURE_IBRSB, fs); + __clear_bit(X86_FEATURE_IBRS, fs); + } + else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ) + /* + * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed + * and implemented using the former. Expose in the max policy only as + * the preference is for guests to use SPEC_CTRL.SSBD if available. + */ + __set_bit(X86_FEATURE_VIRT_SSBD, fs); + + /* + * With VT-x, some features are only supported by Xen if dedicated + * hardware support is also available. + */ + if ( cpu_has_vmx ) + { + if ( !cpu_has_vmx_mpx ) + __clear_bit(X86_FEATURE_MPX, fs); + + if ( !cpu_has_vmx_xsaves ) + __clear_bit(X86_FEATURE_XSAVES, fs); + } + + /* + * Xen doesn't use PKS, so the guest support for it has opted to not use + * the VMCS load/save controls for efficiency reasons. This depends on + * the exact vmentry/exit behaviour, so don't expose PKS in other + * situations until someone has cross-checked the behaviour for safety. + */ + if ( !cpu_has_vmx ) + __clear_bit(X86_FEATURE_PKS, fs); + + guest_common_feature_adjustments(fs); + + sanitise_featureset(fs); + x86_cpu_featureset_to_policy(fs, p); + recalculate_xstate(p); /* It's always possible to emulate CPUID faulting for HVM guests */ p->platform_info.cpuid_faulting = true; @@ -82,8 +625,32 @@ static void __init calculate_hvm_max_policy(void) static void __init calculate_hvm_def_policy(void) { struct cpu_policy *p = &hvm_def_cpu_policy; + uint32_t fs[FSCAPINTS]; + unsigned int i; + const uint32_t *mask; *p = hvm_max_cpu_policy; + x86_cpu_policy_to_featureset(p, fs); + + mask = hvm_hap_supported() ? + hvm_hap_def_featuremask : hvm_shadow_def_featuremask; + + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) + fs[i] &= mask[i]; + + guest_common_feature_adjustments(fs); + guest_common_default_feature_adjustments(fs); + + /* + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus + * amd_virt_spec_ctrl is set. + */ + if ( amd_virt_spec_ctrl ) + __set_bit(X86_FEATURE_VIRT_SSBD, fs); + + sanitise_featureset(fs); + x86_cpu_featureset_to_policy(fs, p); + recalculate_xstate(p); } void __init init_guest_cpu_policies(void) @@ -149,3 +716,188 @@ int init_domain_cpu_policy(struct domain *d) return 0; } + +void recalculate_cpuid_policy(struct domain *d) +{ + struct cpu_policy *p = d->arch.cpuid; + const struct cpu_policy *max = is_pv_domain(d) + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); + uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS]; + unsigned int i; + + if ( !max ) + { + ASSERT_UNREACHABLE(); + return; + } + + p->x86_vendor = x86_cpuid_lookup_vendor( + p->basic.vendor_ebx, p->basic.vendor_ecx, p->basic.vendor_edx); + + p->basic.max_leaf = min(p->basic.max_leaf, max->basic.max_leaf); + p->feat.max_subleaf = min(p->feat.max_subleaf, max->feat.max_subleaf); + p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff, + ((p->x86_vendor & (X86_VENDOR_AMD | + X86_VENDOR_HYGON)) + ? CPUID_GUEST_NR_EXTD_AMD + : CPUID_GUEST_NR_EXTD_INTEL) - 1); + + x86_cpu_policy_to_featureset(p, fs); + x86_cpu_policy_to_featureset(max, max_fs); + + if ( is_hvm_domain(d) ) + { + /* + * HVM domains using Shadow paging have further restrictions on their + * available paging features. + */ + if ( !hap_enabled(d) ) + { + for ( i = 0; i < ARRAY_SIZE(max_fs); i++ ) + max_fs[i] &= hvm_shadow_max_featuremask[i]; + } + + /* Hide nested-virt if it hasn't been explicitly configured. */ + if ( !nestedhvm_enabled(d) ) + { + __clear_bit(X86_FEATURE_VMX, max_fs); + __clear_bit(X86_FEATURE_SVM, max_fs); + } + } + + /* + * Allow the toolstack to set HTT, X2APIC and CMP_LEGACY. These bits + * affect how to interpret topology information in other cpuid leaves. + */ + __set_bit(X86_FEATURE_HTT, max_fs); + __set_bit(X86_FEATURE_X2APIC, max_fs); + __set_bit(X86_FEATURE_CMP_LEGACY, max_fs); + + /* + * 32bit PV domains can't use any Long Mode features, and cannot use + * SYSCALL on non-AMD hardware. + */ + if ( is_pv_32bit_domain(d) ) + { + __clear_bit(X86_FEATURE_LM, max_fs); + if ( !(boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) + __clear_bit(X86_FEATURE_SYSCALL, max_fs); + } + + /* Clamp the toolstacks choices to reality. */ + for ( i = 0; i < ARRAY_SIZE(fs); i++ ) + fs[i] &= max_fs[i]; + + if ( p->basic.max_leaf < XSTATE_CPUID ) + __clear_bit(X86_FEATURE_XSAVE, fs); + + sanitise_featureset(fs); + + /* Fold host's FDP_EXCP_ONLY and NO_FPU_SEL into guest's view. */ + fs[FEATURESET_7b0] &= ~(cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | + cpufeat_mask(X86_FEATURE_NO_FPU_SEL)); + fs[FEATURESET_7b0] |= (host_cpu_policy.feat._7b0 & + (cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | + cpufeat_mask(X86_FEATURE_NO_FPU_SEL))); + + x86_cpu_featureset_to_policy(fs, p); + + /* Pass host cacheline size through to guests. */ + p->basic.clflush_size = max->basic.clflush_size; + + p->extd.maxphysaddr = min(p->extd.maxphysaddr, max->extd.maxphysaddr); + p->extd.maxphysaddr = min_t(uint8_t, p->extd.maxphysaddr, + paging_max_paddr_bits(d)); + p->extd.maxphysaddr = max_t(uint8_t, p->extd.maxphysaddr, + (p->basic.pae || p->basic.pse36) ? 36 : 32); + + p->extd.maxlinaddr = p->extd.lm ? 48 : 32; + + recalculate_xstate(p); + recalculate_misc(p); + + for ( i = 0; i < ARRAY_SIZE(p->cache.raw); ++i ) + { + if ( p->cache.subleaf[i].type >= 1 && + p->cache.subleaf[i].type <= 3 ) + { + /* Subleaf has a valid cache type. Zero reserved fields. */ + p->cache.raw[i].a &= 0xffffc3ffu; + p->cache.raw[i].d &= 0x00000007u; + } + else + { + /* Subleaf is not valid. Zero the rest of the union. */ + zero_leaves(p->cache.raw, i, ARRAY_SIZE(p->cache.raw) - 1); + break; + } + } + + if ( vpmu_mode == XENPMU_MODE_OFF || + ((vpmu_mode & XENPMU_MODE_ALL) && !is_hardware_domain(d)) ) + p->basic.raw[0xa] = EMPTY_LEAF; + + if ( !p->extd.svm ) + p->extd.raw[0xa] = EMPTY_LEAF; + + if ( !p->extd.page1gb ) + p->extd.raw[0x19] = EMPTY_LEAF; +} + +void __init init_dom0_cpuid_policy(struct domain *d) +{ + struct cpu_policy *p = d->arch.cpuid; + + /* dom0 can't migrate. Give it ITSC if available. */ + if ( cpu_has_itsc ) + p->extd.itsc = true; + + /* + * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0, + * so dom0 can turn off workarounds as appropriate. Temporary, until the + * domain policy logic gains a better understanding of MSRs. + */ + if ( cpu_has_arch_caps ) + p->feat.arch_caps = true; + + /* Apply dom0-cpuid= command line settings, if provided. */ + if ( dom0_cpuid_cmdline ) + { + uint32_t fs[FSCAPINTS]; + unsigned int i; + + x86_cpu_policy_to_featureset(p, fs); + + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) + { + fs[i] |= dom0_enable_feat [i]; + fs[i] &= ~dom0_disable_feat[i]; + } + + x86_cpu_featureset_to_policy(fs, p); + + recalculate_cpuid_policy(d); + } +} + +static void __init __maybe_unused build_assertions(void) +{ + BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); + BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); + BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); + BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); + BUILD_BUG_ON(ARRAY_SIZE(deep_features) != FSCAPINTS); + + /* Find some more clever allocation scheme if this trips. */ + BUILD_BUG_ON(sizeof(struct cpu_policy) > PAGE_SIZE); + + BUILD_BUG_ON(sizeof(raw_cpu_policy.basic) != + sizeof(raw_cpu_policy.basic.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.feat) != + sizeof(raw_cpu_policy.feat.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.xstate) != + sizeof(raw_cpu_policy.xstate.raw)); + BUILD_BUG_ON(sizeof(raw_cpu_policy.extd) != + sizeof(raw_cpu_policy.extd.raw)); +} diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 5eb5f1893516..3f20c342fde8 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -1,638 +1,14 @@ -#include -#include -#include #include -#include -#include +#include + +#include + #include #include -#include -#include -#include #include -#include -#include -#include #include -const uint32_t known_features[] = INIT_KNOWN_FEATURES; - -static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; -static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; -static const uint32_t __initconst hvm_hap_max_featuremask[] = - INIT_HVM_HAP_MAX_FEATURES; -static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; -static const uint32_t __initconst hvm_shadow_def_featuremask[] = - INIT_HVM_SHADOW_DEF_FEATURES; -static const uint32_t __initconst hvm_hap_def_featuremask[] = - INIT_HVM_HAP_DEF_FEATURES; -static const uint32_t deep_features[] = INIT_DEEP_FEATURES; - -static const struct feature_name { - const char *name; - unsigned int bit; -} feature_names[] __initconstrel = INIT_FEATURE_NAMES; - -/* - * Parse a list of cpuid feature names -> bool, calling the callback for any - * matches found. - * - * always_inline, because this is init code only and we really don't want a - * function pointer call in the middle of the loop. - */ -static int __init always_inline parse_cpuid( - const char *s, void (*callback)(unsigned int feat, bool val)) -{ - const char *ss; - int val, rc = 0; - - do { - const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; - const char *feat; - - ss = strchr(s, ','); - if ( !ss ) - ss = strchr(s, '\0'); - - /* Skip the 'no-' prefix for name comparisons. */ - feat = s; - if ( strncmp(s, "no-", 3) == 0 ) - feat += 3; - - /* (Re)initalise lhs and rhs for binary search. */ - lhs = feature_names; - rhs = feature_names + ARRAY_SIZE(feature_names); - - while ( lhs < rhs ) - { - int res; - - mid = lhs + (rhs - lhs) / 2; - res = cmdline_strcmp(feat, mid->name); - - if ( res < 0 ) - { - rhs = mid; - continue; - } - if ( res > 0 ) - { - lhs = mid + 1; - continue; - } - - if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) - { - callback(mid->bit, val); - mid = NULL; - } - - break; - } - - /* - * Mid being NULL means that the name and boolean were successfully - * identified. Everything else is an error. - */ - if ( mid ) - rc = -EINVAL; - - s = ss + 1; - } while ( *ss ); - - return rc; -} - -static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) -{ - if ( !val ) - setup_clear_cpu_cap(feat); - else if ( feat == X86_FEATURE_RDRAND && - (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) - setup_force_cpu_cap(X86_FEATURE_RDRAND); -} - -static int __init cf_check parse_xen_cpuid(const char *s) -{ - return parse_cpuid(s, _parse_xen_cpuid); -} -custom_param("cpuid", parse_xen_cpuid); - -static bool __initdata dom0_cpuid_cmdline; -static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; -static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; - -static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) -{ - __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); - __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); -} - -static int __init cf_check parse_dom0_cpuid(const char *s) -{ - dom0_cpuid_cmdline = true; - - return parse_cpuid(s, _parse_dom0_cpuid); -} -custom_param("dom0-cpuid", parse_dom0_cpuid); - #define EMPTY_LEAF ((struct cpuid_leaf){}) -static void zero_leaves(struct cpuid_leaf *l, - unsigned int first, unsigned int last) -{ - memset(&l[first], 0, sizeof(*l) * (last - first + 1)); -} - -static void sanitise_featureset(uint32_t *fs) -{ - /* for_each_set_bit() uses unsigned longs. Extend with zeroes. */ - uint32_t disabled_features[ - ROUNDUP(FSCAPINTS, sizeof(unsigned long)/sizeof(uint32_t))] = {}; - unsigned int i; - - for ( i = 0; i < FSCAPINTS; ++i ) - { - /* Clamp to known mask. */ - fs[i] &= known_features[i]; - - /* - * Identify which features with deep dependencies have been - * disabled. - */ - disabled_features[i] = ~fs[i] & deep_features[i]; - } - - for_each_set_bit(i, (void *)disabled_features, - sizeof(disabled_features) * 8) - { - const uint32_t *dfs = x86_cpuid_lookup_deep_deps(i); - unsigned int j; - - ASSERT(dfs); /* deep_features[] should guarentee this. */ - - for ( j = 0; j < FSCAPINTS; ++j ) - { - fs[j] &= ~dfs[j]; - disabled_features[j] &= ~dfs[j]; - } - } -} - -static void recalculate_xstate(struct cpuid_policy *p) -{ - uint64_t xstates = XSTATE_FP_SSE; - uint32_t xstate_size = XSTATE_AREA_MIN_SIZE; - unsigned int i, Da1 = p->xstate.Da1; - - /* - * The Da1 leaf is the only piece of information preserved in the common - * case. Everything else is derived from other feature state. - */ - memset(&p->xstate, 0, sizeof(p->xstate)); - - if ( !p->basic.xsave ) - return; - - if ( p->basic.avx ) - { - xstates |= X86_XCR0_YMM; - xstate_size = max(xstate_size, - xstate_offsets[X86_XCR0_YMM_POS] + - xstate_sizes[X86_XCR0_YMM_POS]); - } - - if ( p->feat.mpx ) - { - xstates |= X86_XCR0_BNDREGS | X86_XCR0_BNDCSR; - xstate_size = max(xstate_size, - xstate_offsets[X86_XCR0_BNDCSR_POS] + - xstate_sizes[X86_XCR0_BNDCSR_POS]); - } - - if ( p->feat.avx512f ) - { - xstates |= X86_XCR0_OPMASK | X86_XCR0_ZMM | X86_XCR0_HI_ZMM; - xstate_size = max(xstate_size, - xstate_offsets[X86_XCR0_HI_ZMM_POS] + - xstate_sizes[X86_XCR0_HI_ZMM_POS]); - } - - if ( p->feat.pku ) - { - xstates |= X86_XCR0_PKRU; - xstate_size = max(xstate_size, - xstate_offsets[X86_XCR0_PKRU_POS] + - xstate_sizes[X86_XCR0_PKRU_POS]); - } - - p->xstate.max_size = xstate_size; - p->xstate.xcr0_low = xstates & ~XSTATE_XSAVES_ONLY; - p->xstate.xcr0_high = (xstates & ~XSTATE_XSAVES_ONLY) >> 32; - - p->xstate.Da1 = Da1; - if ( p->xstate.xsaves ) - { - p->xstate.xss_low = xstates & XSTATE_XSAVES_ONLY; - p->xstate.xss_high = (xstates & XSTATE_XSAVES_ONLY) >> 32; - } - else - xstates &= ~XSTATE_XSAVES_ONLY; - - for ( i = 2; i < min(63ul, ARRAY_SIZE(p->xstate.comp)); ++i ) - { - uint64_t curr_xstate = 1ul << i; - - if ( !(xstates & curr_xstate) ) - continue; - - p->xstate.comp[i].size = xstate_sizes[i]; - p->xstate.comp[i].offset = xstate_offsets[i]; - p->xstate.comp[i].xss = curr_xstate & XSTATE_XSAVES_ONLY; - p->xstate.comp[i].align = curr_xstate & xstate_align; - } -} - -/* - * Misc adjustments to the policy. Mostly clobbering reserved fields and - * duplicating shared fields. Intentionally hidden fields are annotated. - */ -static void recalculate_misc(struct cpuid_policy *p) -{ - p->basic.raw_fms &= 0x0fff0fff; /* Clobber Processor Type on Intel. */ - p->basic.apic_id = 0; /* Dynamic. */ - - p->basic.raw[0x5] = EMPTY_LEAF; /* MONITOR not exposed to guests. */ - p->basic.raw[0x6] = EMPTY_LEAF; /* Therm/Power not exposed to guests. */ - - p->basic.raw[0x8] = EMPTY_LEAF; - - /* TODO: Rework topology logic. */ - memset(p->topo.raw, 0, sizeof(p->topo.raw)); - - p->basic.raw[0xc] = EMPTY_LEAF; - - p->extd.e1d &= ~CPUID_COMMON_1D_FEATURES; - - /* Most of Power/RAS hidden from guests. */ - p->extd.raw[0x7].a = p->extd.raw[0x7].b = p->extd.raw[0x7].c = 0; - - p->extd.raw[0x8].d = 0; - - switch ( p->x86_vendor ) - { - case X86_VENDOR_INTEL: - p->basic.l2_nr_queries = 1; /* Fixed to 1 query. */ - p->basic.raw[0x3] = EMPTY_LEAF; /* PSN - always hidden. */ - p->basic.raw[0x9] = EMPTY_LEAF; /* DCA - always hidden. */ - - p->extd.vendor_ebx = 0; - p->extd.vendor_ecx = 0; - p->extd.vendor_edx = 0; - - p->extd.raw[0x1].a = p->extd.raw[0x1].b = 0; - - p->extd.raw[0x5] = EMPTY_LEAF; - p->extd.raw[0x6].a = p->extd.raw[0x6].b = p->extd.raw[0x6].d = 0; - - p->extd.raw[0x8].a &= 0x0000ffff; - p->extd.raw[0x8].c = 0; - break; - - case X86_VENDOR_AMD: - case X86_VENDOR_HYGON: - zero_leaves(p->basic.raw, 0x2, 0x3); - memset(p->cache.raw, 0, sizeof(p->cache.raw)); - zero_leaves(p->basic.raw, 0x9, 0xa); - - p->extd.vendor_ebx = p->basic.vendor_ebx; - p->extd.vendor_ecx = p->basic.vendor_ecx; - p->extd.vendor_edx = p->basic.vendor_edx; - - p->extd.raw_fms = p->basic.raw_fms; - p->extd.raw[0x1].b &= 0xff00ffff; - p->extd.e1d |= p->basic._1d & CPUID_COMMON_1D_FEATURES; - - p->extd.raw[0x8].a &= 0x0000ffff; /* GuestMaxPhysAddr hidden. */ - p->extd.raw[0x8].c &= 0x0003f0ff; - - p->extd.raw[0x9] = EMPTY_LEAF; - - zero_leaves(p->extd.raw, 0xb, 0x18); - - /* 0x19 - TLB details. Pass through. */ - /* 0x1a - Perf hints. Pass through. */ - - p->extd.raw[0x1b] = EMPTY_LEAF; /* IBS - not supported. */ - p->extd.raw[0x1c] = EMPTY_LEAF; /* LWP - not supported. */ - p->extd.raw[0x1d] = EMPTY_LEAF; /* TopoExt Cache */ - p->extd.raw[0x1e] = EMPTY_LEAF; /* TopoExt APIC ID/Core/Node */ - p->extd.raw[0x1f] = EMPTY_LEAF; /* SEV */ - p->extd.raw[0x20] = EMPTY_LEAF; /* Platform QoS */ - break; - } -} - -static void __init calculate_raw_policy(void) -{ - struct cpuid_policy *p = &raw_cpu_policy; - - x86_cpuid_policy_fill_native(p); - - /* Nothing good will come from Xen and libx86 disagreeing on vendor. */ - ASSERT(p->x86_vendor == boot_cpu_data.x86_vendor); -} - -static void __init calculate_host_policy(void) -{ - struct cpuid_policy *p = &host_cpu_policy; - unsigned int max_extd_leaf; - - *p = raw_cpu_policy; - - p->basic.max_leaf = - min_t(uint32_t, p->basic.max_leaf, ARRAY_SIZE(p->basic.raw) - 1); - p->feat.max_subleaf = - min_t(uint32_t, p->feat.max_subleaf, ARRAY_SIZE(p->feat.raw) - 1); - - max_extd_leaf = p->extd.max_leaf; - - /* - * For AMD/Hygon hardware before Zen3, we unilaterally modify LFENCE to be - * dispatch serialising for Spectre mitigations. Extend max_extd_leaf - * beyond what hardware supports, to include the feature leaf containing - * this information. - */ - if ( cpu_has_lfence_dispatch ) - max_extd_leaf = max(max_extd_leaf, 0x80000021); - - p->extd.max_leaf = 0x80000000 | min_t(uint32_t, max_extd_leaf & 0xffff, - ARRAY_SIZE(p->extd.raw) - 1); - - x86_cpu_featureset_to_policy(boot_cpu_data.x86_capability, p); - recalculate_xstate(p); - recalculate_misc(p); - - /* When vPMU is disabled, drop it from the host policy. */ - if ( vpmu_mode == XENPMU_MODE_OFF ) - p->basic.raw[0xa] = EMPTY_LEAF; - - if ( p->extd.svm ) - { - /* Clamp to implemented features which require hardware support. */ - p->extd.raw[0xa].d &= ((1u << SVM_FEATURE_NPT) | - (1u << SVM_FEATURE_LBRV) | - (1u << SVM_FEATURE_NRIPS) | - (1u << SVM_FEATURE_PAUSEFILTER) | - (1u << SVM_FEATURE_DECODEASSISTS)); - /* Enable features which are always emulated. */ - p->extd.raw[0xa].d |= ((1u << SVM_FEATURE_VMCBCLEAN) | - (1u << SVM_FEATURE_TSCRATEMSR)); - } -} - -static void __init guest_common_default_feature_adjustments(uint32_t *fs) -{ - /* - * IvyBridge client parts suffer from leakage of RDRAND data due to SRBDS - * (XSA-320 / CVE-2020-0543), and won't be receiving microcode to - * compensate. - * - * Mitigate by hiding RDRAND from guests by default, unless explicitly - * overridden on the Xen command line (cpuid=rdrand). Irrespective of the - * default setting, guests can use RDRAND if explicitly enabled - * (cpuid="host,rdrand=1") in the VM's config file, and VMs which were - * previously using RDRAND can migrate in. - */ - if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && - boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x3a && - cpu_has_rdrand && !is_forced_cpu_cap(X86_FEATURE_RDRAND) ) - __clear_bit(X86_FEATURE_RDRAND, fs); - - /* - * On certain hardware, speculative or errata workarounds can result in - * TSX being placed in "force-abort" mode, where it doesn't actually - * function as expected, but is technically compatible with the ISA. - * - * Do not advertise RTM to guests by default if it won't actually work. - */ - if ( rtm_disabled ) - __clear_bit(X86_FEATURE_RTM, fs); -} - -static void __init guest_common_feature_adjustments(uint32_t *fs) -{ - /* Unconditionally claim to be able to set the hypervisor bit. */ - __set_bit(X86_FEATURE_HYPERVISOR, fs); - - /* - * If IBRS is offered to the guest, unconditionally offer STIBP. It is a - * nop on non-HT hardware, and has this behaviour to make heterogeneous - * setups easier to manage. - */ - if ( test_bit(X86_FEATURE_IBRSB, fs) ) - __set_bit(X86_FEATURE_STIBP, fs); - if ( test_bit(X86_FEATURE_IBRS, fs) ) - __set_bit(X86_FEATURE_AMD_STIBP, fs); - - /* - * On hardware which supports IBRS/IBPB, we can offer IBPB independently - * of IBRS by using the AMD feature bit. An administrator may wish for - * performance reasons to offer IBPB without IBRS. - */ - if ( host_cpu_policy.feat.ibrsb ) - __set_bit(X86_FEATURE_IBPB, fs); -} - -static void __init calculate_pv_max_policy(void) -{ - struct cpuid_policy *p = &pv_max_cpu_policy; - uint32_t pv_featureset[FSCAPINTS]; - unsigned int i; - - *p = host_cpu_policy; - x86_cpu_policy_to_featureset(p, pv_featureset); - - for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) - pv_featureset[i] &= pv_max_featuremask[i]; - - /* - * If Xen isn't virtualising MSR_SPEC_CTRL for PV guests (functional - * availability, or admin choice), hide the feature. - */ - if ( !boot_cpu_has(X86_FEATURE_SC_MSR_PV) ) - { - __clear_bit(X86_FEATURE_IBRSB, pv_featureset); - __clear_bit(X86_FEATURE_IBRS, pv_featureset); - } - - guest_common_feature_adjustments(pv_featureset); - - sanitise_featureset(pv_featureset); - x86_cpu_featureset_to_policy(pv_featureset, p); - recalculate_xstate(p); - - p->extd.raw[0xa] = EMPTY_LEAF; /* No SVM for PV guests. */ -} - -static void __init calculate_pv_def_policy(void) -{ - struct cpuid_policy *p = &pv_def_cpu_policy; - uint32_t pv_featureset[FSCAPINTS]; - unsigned int i; - - *p = pv_max_cpu_policy; - x86_cpu_policy_to_featureset(p, pv_featureset); - - for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) - pv_featureset[i] &= pv_def_featuremask[i]; - - guest_common_feature_adjustments(pv_featureset); - guest_common_default_feature_adjustments(pv_featureset); - - sanitise_featureset(pv_featureset); - x86_cpu_featureset_to_policy(pv_featureset, p); - recalculate_xstate(p); -} - -static void __init calculate_hvm_max_policy(void) -{ - struct cpuid_policy *p = &hvm_max_cpu_policy; - uint32_t hvm_featureset[FSCAPINTS]; - unsigned int i; - const uint32_t *hvm_featuremask; - - *p = host_cpu_policy; - x86_cpu_policy_to_featureset(p, hvm_featureset); - - hvm_featuremask = hvm_hap_supported() ? - hvm_hap_max_featuremask : hvm_shadow_max_featuremask; - - for ( i = 0; i < ARRAY_SIZE(hvm_featureset); ++i ) - hvm_featureset[i] &= hvm_featuremask[i]; - - /* - * Xen can provide an (x2)APIC emulation to HVM guests even if the host's - * (x2)APIC isn't enabled. - */ - __set_bit(X86_FEATURE_APIC, hvm_featureset); - __set_bit(X86_FEATURE_X2APIC, hvm_featureset); - - /* - * We don't support EFER.LMSLE at all. AMD has dropped the feature from - * hardware and allocated a CPUID bit to indicate its absence. - */ - __set_bit(X86_FEATURE_NO_LMSL, hvm_featureset); - - /* - * On AMD, PV guests are entirely unable to use SYSENTER as Xen runs in - * long mode (and init_amd() has cleared it out of host capabilities), but - * HVM guests are able if running in protected mode. - */ - if ( (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) && - raw_cpu_policy.basic.sep ) - __set_bit(X86_FEATURE_SEP, hvm_featureset); - - /* - * VIRT_SSBD is exposed in the default policy as a result of - * amd_virt_spec_ctrl being set, it also needs exposing in the max policy. - */ - if ( amd_virt_spec_ctrl ) - __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); - - /* - * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional - * availability, or admin choice), hide the feature. - */ - if ( !boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ) - { - __clear_bit(X86_FEATURE_IBRSB, hvm_featureset); - __clear_bit(X86_FEATURE_IBRS, hvm_featureset); - } - else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ) - /* - * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed - * and implemented using the former. Expose in the max policy only as - * the preference is for guests to use SPEC_CTRL.SSBD if available. - */ - __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); - - /* - * With VT-x, some features are only supported by Xen if dedicated - * hardware support is also available. - */ - if ( cpu_has_vmx ) - { - if ( !cpu_has_vmx_mpx ) - __clear_bit(X86_FEATURE_MPX, hvm_featureset); - - if ( !cpu_has_vmx_xsaves ) - __clear_bit(X86_FEATURE_XSAVES, hvm_featureset); - } - - /* - * Xen doesn't use PKS, so the guest support for it has opted to not use - * the VMCS load/save controls for efficiency reasons. This depends on - * the exact vmentry/exit behaviour, so don't expose PKS in other - * situations until someone has cross-checked the behaviour for safety. - */ - if ( !cpu_has_vmx ) - __clear_bit(X86_FEATURE_PKS, hvm_featureset); - - guest_common_feature_adjustments(hvm_featureset); - - sanitise_featureset(hvm_featureset); - x86_cpu_featureset_to_policy(hvm_featureset, p); - recalculate_xstate(p); -} - -static void __init calculate_hvm_def_policy(void) -{ - struct cpuid_policy *p = &hvm_def_cpu_policy; - uint32_t hvm_featureset[FSCAPINTS]; - unsigned int i; - const uint32_t *hvm_featuremask; - - *p = hvm_max_cpu_policy; - x86_cpu_policy_to_featureset(p, hvm_featureset); - - hvm_featuremask = hvm_hap_supported() ? - hvm_hap_def_featuremask : hvm_shadow_def_featuremask; - - for ( i = 0; i < ARRAY_SIZE(hvm_featureset); ++i ) - hvm_featureset[i] &= hvm_featuremask[i]; - - guest_common_feature_adjustments(hvm_featureset); - guest_common_default_feature_adjustments(hvm_featureset); - - /* - * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus - * amd_virt_spec_ctrl is set. - */ - if ( amd_virt_spec_ctrl ) - __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); - - sanitise_featureset(hvm_featureset); - x86_cpu_featureset_to_policy(hvm_featureset, p); - recalculate_xstate(p); -} - -void __init init_guest_cpuid(void) -{ - calculate_raw_policy(); - calculate_host_policy(); - - if ( IS_ENABLED(CONFIG_PV) ) - { - calculate_pv_max_policy(); - calculate_pv_def_policy(); - } - - if ( hvm_enabled ) - { - calculate_hvm_max_policy(); - calculate_hvm_def_policy(); - } -} bool recheck_cpu_features(unsigned int cpu) { @@ -656,170 +32,6 @@ bool recheck_cpu_features(unsigned int cpu) return okay; } -void recalculate_cpuid_policy(struct domain *d) -{ - struct cpuid_policy *p = d->arch.cpuid; - const struct cpuid_policy *max = is_pv_domain(d) - ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) - : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); - uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS]; - unsigned int i; - - if ( !max ) - { - ASSERT_UNREACHABLE(); - return; - } - - p->x86_vendor = x86_cpuid_lookup_vendor( - p->basic.vendor_ebx, p->basic.vendor_ecx, p->basic.vendor_edx); - - p->basic.max_leaf = min(p->basic.max_leaf, max->basic.max_leaf); - p->feat.max_subleaf = min(p->feat.max_subleaf, max->feat.max_subleaf); - p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff, - ((p->x86_vendor & (X86_VENDOR_AMD | - X86_VENDOR_HYGON)) - ? CPUID_GUEST_NR_EXTD_AMD - : CPUID_GUEST_NR_EXTD_INTEL) - 1); - - x86_cpu_policy_to_featureset(p, fs); - x86_cpu_policy_to_featureset(max, max_fs); - - if ( is_hvm_domain(d) ) - { - /* - * HVM domains using Shadow paging have further restrictions on their - * available paging features. - */ - if ( !hap_enabled(d) ) - { - for ( i = 0; i < ARRAY_SIZE(max_fs); i++ ) - max_fs[i] &= hvm_shadow_max_featuremask[i]; - } - - /* Hide nested-virt if it hasn't been explicitly configured. */ - if ( !nestedhvm_enabled(d) ) - { - __clear_bit(X86_FEATURE_VMX, max_fs); - __clear_bit(X86_FEATURE_SVM, max_fs); - } - } - - /* - * Allow the toolstack to set HTT, X2APIC and CMP_LEGACY. These bits - * affect how to interpret topology information in other cpuid leaves. - */ - __set_bit(X86_FEATURE_HTT, max_fs); - __set_bit(X86_FEATURE_X2APIC, max_fs); - __set_bit(X86_FEATURE_CMP_LEGACY, max_fs); - - /* - * 32bit PV domains can't use any Long Mode features, and cannot use - * SYSCALL on non-AMD hardware. - */ - if ( is_pv_32bit_domain(d) ) - { - __clear_bit(X86_FEATURE_LM, max_fs); - if ( !(boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) - __clear_bit(X86_FEATURE_SYSCALL, max_fs); - } - - /* Clamp the toolstacks choices to reality. */ - for ( i = 0; i < ARRAY_SIZE(fs); i++ ) - fs[i] &= max_fs[i]; - - if ( p->basic.max_leaf < XSTATE_CPUID ) - __clear_bit(X86_FEATURE_XSAVE, fs); - - sanitise_featureset(fs); - - /* Fold host's FDP_EXCP_ONLY and NO_FPU_SEL into guest's view. */ - fs[FEATURESET_7b0] &= ~(cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | - cpufeat_mask(X86_FEATURE_NO_FPU_SEL)); - fs[FEATURESET_7b0] |= (host_cpu_policy.feat._7b0 & - (cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | - cpufeat_mask(X86_FEATURE_NO_FPU_SEL))); - - x86_cpu_featureset_to_policy(fs, p); - - /* Pass host cacheline size through to guests. */ - p->basic.clflush_size = max->basic.clflush_size; - - p->extd.maxphysaddr = min(p->extd.maxphysaddr, max->extd.maxphysaddr); - p->extd.maxphysaddr = min_t(uint8_t, p->extd.maxphysaddr, - paging_max_paddr_bits(d)); - p->extd.maxphysaddr = max_t(uint8_t, p->extd.maxphysaddr, - (p->basic.pae || p->basic.pse36) ? 36 : 32); - - p->extd.maxlinaddr = p->extd.lm ? 48 : 32; - - recalculate_xstate(p); - recalculate_misc(p); - - for ( i = 0; i < ARRAY_SIZE(p->cache.raw); ++i ) - { - if ( p->cache.subleaf[i].type >= 1 && - p->cache.subleaf[i].type <= 3 ) - { - /* Subleaf has a valid cache type. Zero reserved fields. */ - p->cache.raw[i].a &= 0xffffc3ffu; - p->cache.raw[i].d &= 0x00000007u; - } - else - { - /* Subleaf is not valid. Zero the rest of the union. */ - zero_leaves(p->cache.raw, i, ARRAY_SIZE(p->cache.raw) - 1); - break; - } - } - - if ( vpmu_mode == XENPMU_MODE_OFF || - ((vpmu_mode & XENPMU_MODE_ALL) && !is_hardware_domain(d)) ) - p->basic.raw[0xa] = EMPTY_LEAF; - - if ( !p->extd.svm ) - p->extd.raw[0xa] = EMPTY_LEAF; - - if ( !p->extd.page1gb ) - p->extd.raw[0x19] = EMPTY_LEAF; -} - -void __init init_dom0_cpuid_policy(struct domain *d) -{ - struct cpuid_policy *p = d->arch.cpuid; - - /* dom0 can't migrate. Give it ITSC if available. */ - if ( cpu_has_itsc ) - p->extd.itsc = true; - - /* - * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0, - * so dom0 can turn off workarounds as appropriate. Temporary, until the - * domain policy logic gains a better understanding of MSRs. - */ - if ( cpu_has_arch_caps ) - p->feat.arch_caps = true; - - /* Apply dom0-cpuid= command line settings, if provided. */ - if ( dom0_cpuid_cmdline ) - { - uint32_t fs[FSCAPINTS]; - unsigned int i; - - x86_cpu_policy_to_featureset(p, fs); - - for ( i = 0; i < ARRAY_SIZE(fs); ++i ) - { - fs[i] |= dom0_enable_feat [i]; - fs[i] &= ~dom0_disable_feat[i]; - } - - x86_cpu_featureset_to_policy(fs, p); - - recalculate_cpuid_policy(d); - } -} - void guest_cpuid(const struct vcpu *v, uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res) { @@ -1190,27 +402,6 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, } } -static void __init __maybe_unused build_assertions(void) -{ - BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(deep_features) != FSCAPINTS); - - /* Find some more clever allocation scheme if this trips. */ - BUILD_BUG_ON(sizeof(struct cpuid_policy) > PAGE_SIZE); - - BUILD_BUG_ON(sizeof(raw_cpu_policy.basic) != - sizeof(raw_cpu_policy.basic.raw)); - BUILD_BUG_ON(sizeof(raw_cpu_policy.feat) != - sizeof(raw_cpu_policy.feat.raw)); - BUILD_BUG_ON(sizeof(raw_cpu_policy.xstate) != - sizeof(raw_cpu_policy.xstate.raw)); - BUILD_BUG_ON(sizeof(raw_cpu_policy.extd) != - sizeof(raw_cpu_policy.extd.raw)); -} - /* * Local variables: * mode: C diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index d326fa1c0136..675c523d9909 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -77,7 +77,6 @@ #include #include #include -#include #include diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h index 13e2a1f86d13..b361537a602b 100644 --- a/xen/arch/x86/include/asm/cpu-policy.h +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -18,4 +18,10 @@ void init_guest_cpu_policies(void); /* Allocate and initialise a CPU policy suitable for the domain. */ int init_domain_cpu_policy(struct domain *d); +/* Apply dom0-specific tweaks to the CPUID policy. */ +void init_dom0_cpuid_policy(struct domain *d); + +/* Clamp the CPUID policy to reality. */ +void recalculate_cpuid_policy(struct domain *d); + #endif /* X86_CPU_POLICY_H */ diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h index 7f81b998ce01..b32ba0bbfe5c 100644 --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -8,14 +8,10 @@ #include #include -#include - #include extern const uint32_t known_features[FSCAPINTS]; -void init_guest_cpuid(void); - /* * Expected levelling capabilities (given cpuid vendor/family information), * and levelling capabilities actually available (given MSR probing). @@ -49,13 +45,8 @@ extern struct cpuidmasks cpuidmask_defaults; /* Check that all previously present features are still available. */ bool recheck_cpu_features(unsigned int cpu); -/* Apply dom0-specific tweaks to the CPUID policy. */ -void init_dom0_cpuid_policy(struct domain *d); - -/* Clamp the CPUID policy to reality. */ -void recalculate_cpuid_policy(struct domain *d); - struct vcpu; +struct cpuid_leaf; void guest_cpuid(const struct vcpu *v, uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res); diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c index f94f28c8e271..95492715d8ad 100644 --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x86/pv/domain.c @@ -10,6 +10,7 @@ #include #include +#include #include #include #include diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 51a19b9019eb..08ade715a3ce 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include #include @@ -1991,7 +1990,6 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( !tboot_protect_mem_regions() ) panic("Could not protect TXT memory regions\n"); - init_guest_cpuid(); init_guest_cpu_policies(); if ( xen_cpuidle ) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:59:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517749.803570 (Exim 4.92) (envelope-from ) id 1pjdRX-0003Rx-UL; Tue, 04 Apr 2023 09:59:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517749.803570; Tue, 04 Apr 2023 09:59:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdRX-0003Rj-Qz; Tue, 04 Apr 2023 09:59:11 +0000 Received: by outflank-mailman (input) for mailman id 517749; Tue, 04 Apr 2023 09:59:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdMC-0005bo-Gy for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 926ea3a0-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:53:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 926ea3a0-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602019; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GbFah8Uej44Bj9X6DdnsRE7vn00ll+/fTK8duGH2gAE=; b=RJH/ZgNLZ3lSIqMB3bEan5pDxw5I7g09rzjIzs17XzMBe07KFGPmXftg Jwz9ThgHQxbFFZOtKRxnbTOYYZJq4mC70NJur+z1TNFaqmKFPe8OyC42V AFY1cI5DZkwSCJOjIJksb0amE++Clo9uFJ4FEVPXWIQXM2zX9TRrsid87 o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104161466 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:uoLQVq9Ye3x1JcrNB3lyDrUD/36TJUtcMsCJ2f8bNWPcYEJGY0x3z moaD2rSOqqLYGL0edlxbNu+pBlVvpDUyNJiHFRs+X88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklu9 uIXeQoIYCmZntio+6C4W8hJq8gaeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0MxhrB+ DuaoTqR7hcyN8yVxj28z1KVgKzsrBnVAYxJNKGWz6s/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c/h6HvA+6QqN4rHJ+AvfDW8BJhZebPQ2uclwQiYlv mJlhPuwW2Yp6ufMDyvAqPHN92ja1TUpwXEqRSwaQlo/5tfaupgJkCndTcdCNYO5t4igcd3v+ AxmvBTSlp1K055Tivrlpw+e696/jsOXF1Bov207Skrgt1okP9D9OuRE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFBz3oRZPhagKvFlDyL5Ba67ogwPBb k7Joh9275ROJnasZqIfS9vvW5x3kfaxT4+/CKC8gj9yjn9ZLVfvwc2TTRTIgzCFfLYEysnTx qt3ge7zVC1HWMyLPRK9RvsH0K9D+x3SMVj7HMihpzz+iOr2WZJgYetdWLd4RrxjvfzsTcS82 4o3CvZmPD0ED7KiOHCLrtdDRb3IRFBiba3LRwVsXrbrCmJb9KsJUpc9HZtJl1RZoplo IronPort-HdrOrdr: A9a23:59oaB6CIYAkWZ2LlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104161466" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 10/15] x86/boot: Move MSR policy initialisation logic into cpu-policy.c Date: Tue, 4 Apr 2023 10:52:17 +0100 Message-ID: <20230404095222.1373721-11-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Switch to the newer cpu_policy nomenclature. No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New --- xen/arch/x86/cpu-policy.c | 84 +++++++++++++++++++++++++++ xen/arch/x86/include/asm/cpu-policy.h | 3 + xen/arch/x86/include/asm/msr.h | 1 - xen/arch/x86/msr.c | 84 --------------------------- xen/arch/x86/setup.c | 3 +- 5 files changed, 89 insertions(+), 86 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index e9ac1269c35a..f6a2317ed7bd 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -20,6 +20,90 @@ struct cpu_policy __ro_after_init hvm_max_cpu_policy; struct cpu_policy __ro_after_init hvm_def_cpu_policy; #endif +static void __init calculate_raw_policy(void) +{ + struct cpu_policy *p = &raw_cpu_policy; + + /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ + /* Was already added by probe_cpuid_faulting() */ + + if ( cpu_has_arch_caps ) + rdmsrl(MSR_ARCH_CAPABILITIES, p->arch_caps.raw); +} + +static void __init calculate_host_policy(void) +{ + struct cpu_policy *p = &host_cpu_policy; + + *p = raw_cpu_policy; + + /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ + /* probe_cpuid_faulting() sanity checks presence of MISC_FEATURES_ENABLES */ + p->platform_info.cpuid_faulting = cpu_has_cpuid_faulting; + + /* Temporary, until we have known_features[] for feature bits in MSRs. */ + p->arch_caps.raw &= + (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | + ARCH_CAPS_SKIP_L1DFL | ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | + ARCH_CAPS_IF_PSCHANGE_MC_NO | ARCH_CAPS_TSX_CTRL | ARCH_CAPS_TAA_NO | + ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | ARCH_CAPS_PSDP_NO | + ARCH_CAPS_FB_CLEAR | ARCH_CAPS_RRSBA | ARCH_CAPS_BHI_NO | + ARCH_CAPS_PBRSB_NO); +} + +static void __init calculate_pv_max_policy(void) +{ + struct cpu_policy *p = &pv_max_cpu_policy; + + *p = host_cpu_policy; + + p->arch_caps.raw = 0; /* Not supported yet. */ +} + +static void __init calculate_pv_def_policy(void) +{ + struct cpu_policy *p = &pv_def_cpu_policy; + + *p = pv_max_cpu_policy; +} + +static void __init calculate_hvm_max_policy(void) +{ + struct cpu_policy *p = &hvm_max_cpu_policy; + + *p = host_cpu_policy; + + /* It's always possible to emulate CPUID faulting for HVM guests */ + p->platform_info.cpuid_faulting = true; + + p->arch_caps.raw = 0; /* Not supported yet. */ +} + +static void __init calculate_hvm_def_policy(void) +{ + struct cpu_policy *p = &hvm_def_cpu_policy; + + *p = hvm_max_cpu_policy; +} + +void __init init_guest_cpu_policies(void) +{ + calculate_raw_policy(); + calculate_host_policy(); + + if ( IS_ENABLED(CONFIG_PV) ) + { + calculate_pv_max_policy(); + calculate_pv_def_policy(); + } + + if ( hvm_enabled ) + { + calculate_hvm_max_policy(); + calculate_hvm_def_policy(); + } +} + int init_domain_cpu_policy(struct domain *d) { struct cpu_policy *p = is_pv_domain(d) diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h index 9ba34bbf5ea1..13e2a1f86d13 100644 --- a/xen/arch/x86/include/asm/cpu-policy.h +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -12,6 +12,9 @@ extern struct cpu_policy pv_def_cpu_policy; extern struct cpu_policy hvm_max_cpu_policy; extern struct cpu_policy hvm_def_cpu_policy; +/* Initialise the guest cpu_policy objects. */ +void init_guest_cpu_policies(void); + /* Allocate and initialise a CPU policy suitable for the domain. */ int init_domain_cpu_policy(struct domain *d); diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index b59a51d238a7..458841733e18 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -418,7 +418,6 @@ struct vcpu_msrs uint32_t dr_mask[4]; }; -void init_guest_msr_policy(void); int init_vcpu_msr_policy(struct vcpu *v); /* diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 93bd93feb644..802fc60baf81 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -38,90 +38,6 @@ DEFINE_PER_CPU(uint32_t, tsc_aux); -static void __init calculate_raw_policy(void) -{ - struct msr_policy *mp = &raw_cpu_policy; - - /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ - /* Was already added by probe_cpuid_faulting() */ - - if ( cpu_has_arch_caps ) - rdmsrl(MSR_ARCH_CAPABILITIES, mp->arch_caps.raw); -} - -static void __init calculate_host_policy(void) -{ - struct msr_policy *mp = &host_cpu_policy; - - *mp = raw_cpu_policy; - - /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ - /* probe_cpuid_faulting() sanity checks presence of MISC_FEATURES_ENABLES */ - mp->platform_info.cpuid_faulting = cpu_has_cpuid_faulting; - - /* Temporary, until we have known_features[] for feature bits in MSRs. */ - mp->arch_caps.raw &= - (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | - ARCH_CAPS_SKIP_L1DFL | ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | - ARCH_CAPS_IF_PSCHANGE_MC_NO | ARCH_CAPS_TSX_CTRL | ARCH_CAPS_TAA_NO | - ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | ARCH_CAPS_PSDP_NO | - ARCH_CAPS_FB_CLEAR | ARCH_CAPS_RRSBA | ARCH_CAPS_BHI_NO | - ARCH_CAPS_PBRSB_NO); -} - -static void __init calculate_pv_max_policy(void) -{ - struct msr_policy *mp = &pv_max_cpu_policy; - - *mp = host_cpu_policy; - - mp->arch_caps.raw = 0; /* Not supported yet. */ -} - -static void __init calculate_pv_def_policy(void) -{ - struct msr_policy *mp = &pv_def_cpu_policy; - - *mp = pv_max_cpu_policy; -} - -static void __init calculate_hvm_max_policy(void) -{ - struct msr_policy *mp = &hvm_max_cpu_policy; - - *mp = host_cpu_policy; - - /* It's always possible to emulate CPUID faulting for HVM guests */ - mp->platform_info.cpuid_faulting = true; - - mp->arch_caps.raw = 0; /* Not supported yet. */ -} - -static void __init calculate_hvm_def_policy(void) -{ - struct msr_policy *mp = &hvm_def_cpu_policy; - - *mp = hvm_max_cpu_policy; -} - -void __init init_guest_msr_policy(void) -{ - calculate_raw_policy(); - calculate_host_policy(); - - if ( IS_ENABLED(CONFIG_PV) ) - { - calculate_pv_max_policy(); - calculate_pv_def_policy(); - } - - if ( hvm_enabled ) - { - calculate_hvm_max_policy(); - calculate_hvm_def_policy(); - } -} - int init_vcpu_msr_policy(struct vcpu *v) { struct vcpu_msrs *msrs = xzalloc(struct vcpu_msrs); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index b29229933d8c..51a19b9019eb 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -50,6 +50,7 @@ #include #include #include +#include #include #include #include @@ -1991,7 +1992,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) panic("Could not protect TXT memory regions\n"); init_guest_cpuid(); - init_guest_msr_policy(); + init_guest_cpu_policies(); if ( xen_cpuidle ) xen_processor_pmbits |= XEN_PROCESSOR_PM_CX; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:59:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517751.803580 (Exim 4.92) (envelope-from ) id 1pjdRZ-0003hx-6H; Tue, 04 Apr 2023 09:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517751.803580; Tue, 04 Apr 2023 09:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdRZ-0003hq-1O; Tue, 04 Apr 2023 09:59:13 +0000 Received: by outflank-mailman (input) for mailman id 517751; Tue, 04 Apr 2023 09:59:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdMS-0005bo-R1 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:56 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b5e9743-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:53:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b5e9743-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602034; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=g6soTwUYllGEYZrZeu6VHps1q/P3LIhMMKfu395S8Yw=; b=Nf0ZU6SdlXkjQwjPFuLSMIH3fVlpq3UFTM19kMDfK/O8oWiBivO69uiF TqT+bWjNGD1vR+PqRcBqnyol607dnJBz9PgQSZxNJ0ryg8G2KBKDiLZ1L OVZ52db+q6jQYdnpFNZGLnSXEmsEf9FCDURWD4Dv/JVIMQrK6Zp0d6njz 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104161492 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ZPnmvaN/QfuEnHrvrR3al8FynXyQoLVcMsEvi/4bfWQNrUp2hDRTn WtLC2jSMvePNzOhe4t+Pdmw8UoEscXdzNEyGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rd+DUURy 9IxEQ4ESxqlqvOcwLjqe+Y506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUoXSGZwLxxrJ/ Aoq+UzEC0gYGoKS2wCOrHi2jOjWwWT8dK4NQejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52ml6IDZ/gKYDWgsVSNaZZots8peeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwBEJGMmOhEqZDI76vzphqwipBLFH+dsRfvdYsLOJd3g/ 9ybhHFg1+1O0pBRiPzTEUPv2Gz1+MWQJuIhzkCOBz/+sFskDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKMN8N7n9hV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPEnO9/tVZVwlvK+RbwJs8w4ifIXOvBMmPKvpnkyNSZ8IUi2+KTTrU3PE cjCKpv9ZZrrIa9m0CC3V48g7FPf/QhnnTm7bcmin3yaPU+2OCb9pUEtbAHfMYjULcqs/G3oz jqoH5DVlEkFCbGhO3m/HEx6BQliEEXXzKve86R/HtNv6CI/cI39I5c9GY8cRrE= IronPort-HdrOrdr: A9a23:fE8LuaNbuPenKsBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104161492" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 12/15] x86/emul: Switch x86_emulate_ctxt to cpu_policy Date: Tue, 4 Apr 2023 10:52:19 +0100 Message-ID: <20230404095222.1373721-13-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit As with struct domain, retain cpuid as a valid alias for local code clarity. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Retain cpuid compatibility alias. * Split out of RFC patch. --- tools/fuzz/x86_instruction_emulator/fuzz-emul.c | 2 +- tools/tests/x86_emulator/test_x86_emulator.c | 2 +- tools/tests/x86_emulator/x86-emulate.c | 2 +- xen/arch/x86/hvm/emulate.c | 4 ++-- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/x86_emulate/private.h | 4 ++-- xen/arch/x86/x86_emulate/x86_emulate.h | 7 +++++-- 9 files changed, 15 insertions(+), 12 deletions(-) diff --git a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c index 966e46bee199..4885a68210d0 100644 --- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c +++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c @@ -893,7 +893,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data_p, size_t size) struct x86_emulate_ctxt ctxt = { .data = &state, .regs = &input.regs, - .cpuid = &cp, + .cpu_policy = &cp, .addr_size = 8 * sizeof(void *), .sp_size = 8 * sizeof(void *), }; diff --git a/tools/tests/x86_emulator/test_x86_emulator.c b/tools/tests/x86_emulator/test_x86_emulator.c index 31586f805726..7b7fbaaf45ec 100644 --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -909,7 +909,7 @@ int main(int argc, char **argv) ctxt.regs = ®s; ctxt.force_writeback = 0; - ctxt.cpuid = &cp; + ctxt.cpu_policy = &cp; ctxt.lma = sizeof(void *) == 8; ctxt.addr_size = 8 * sizeof(void *); ctxt.sp_size = 8 * sizeof(void *); diff --git a/tools/tests/x86_emulator/x86-emulate.c b/tools/tests/x86_emulator/x86-emulate.c index f6ee09439751..2692404df906 100644 --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -25,7 +25,7 @@ #endif uint32_t mxcsr_mask = 0x0000ffbf; -struct cpuid_policy cp; +struct cpu_policy cp; static char fpu_save_area[0x4000] __attribute__((__aligned__((64)))); static bool use_xsave; diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 95364deb1996..5691725d6c6f 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -2771,7 +2771,7 @@ int hvm_emulate_one_mmio(unsigned long mfn, unsigned long gla) void hvm_emulate_one_vm_event(enum emul_kind kind, unsigned int trapnr, unsigned int errcode) { - struct hvm_emulate_ctxt ctx = {{ 0 }}; + struct hvm_emulate_ctxt ctx = {}; int rc; hvm_emulate_init_once(&ctx, NULL, guest_cpu_user_regs()); @@ -2846,7 +2846,7 @@ void hvm_emulate_init_once( hvmemul_ctxt->validate = validate; hvmemul_ctxt->ctxt.regs = regs; - hvmemul_ctxt->ctxt.cpuid = curr->domain->arch.cpuid; + hvmemul_ctxt->ctxt.cpu_policy = curr->domain->arch.cpu_policy; hvmemul_ctxt->ctxt.force_writeback = true; } diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c index e2ee1c77056f..cc84af01925a 100644 --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -319,7 +319,7 @@ const struct x86_emulate_ops *shadow_init_emulation( memset(sh_ctxt, 0, sizeof(*sh_ctxt)); sh_ctxt->ctxt.regs = regs; - sh_ctxt->ctxt.cpuid = curr->domain->arch.cpuid; + sh_ctxt->ctxt.cpu_policy = curr->domain->arch.cpu_policy; sh_ctxt->ctxt.lma = hvm_long_mode_active(curr); /* Segment cache initialisation. Primed with CS. */ diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 5da00e24e4ff..ab52768271c5 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -1327,7 +1327,7 @@ int pv_emulate_privileged_op(struct cpu_user_regs *regs) struct domain *currd = curr->domain; struct priv_op_ctxt ctxt = { .ctxt.regs = regs, - .ctxt.cpuid = currd->arch.cpuid, + .ctxt.cpu_policy = currd->arch.cpu_policy, .ctxt.lma = !is_pv_32bit_domain(currd), }; int rc; diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index 5963f5ee2d51..0d02c7d2ab10 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -356,7 +356,7 @@ int pv_ro_page_fault(unsigned long addr, struct cpu_user_regs *regs) unsigned int addr_size = is_pv_32bit_domain(currd) ? 32 : BITS_PER_LONG; struct x86_emulate_ctxt ctxt = { .regs = regs, - .cpuid = currd->arch.cpuid, + .cpu_policy = currd->arch.cpu_policy, .addr_size = addr_size, .sp_size = addr_size, .lma = addr_size > 32, diff --git a/xen/arch/x86/x86_emulate/private.h b/xen/arch/x86/x86_emulate/private.h index 653a298c705b..8dee019731ae 100644 --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -505,7 +505,7 @@ in_protmode( }) static inline bool -_amd_like(const struct cpuid_policy *cp) +_amd_like(const struct cpu_policy *cp) { return cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON); } @@ -513,7 +513,7 @@ _amd_like(const struct cpuid_policy *cp) static inline bool amd_like(const struct x86_emulate_ctxt *ctxt) { - return _amd_like(ctxt->cpuid); + return _amd_like(ctxt->cpu_policy); } #define vcpu_has_fpu() (ctxt->cpuid->basic.fpu) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index 75015104fbdb..0139d16da70c 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -565,8 +565,11 @@ struct x86_emulate_ctxt * Input-only state: */ - /* CPUID Policy for the domain. */ - const struct cpuid_policy *cpuid; + /* CPU policy for the domain. Allow aliases for local code clarity. */ + union { + struct cpu_policy *cpu_policy; + struct cpu_policy *cpuid; + }; /* Set this if writes may have side effects. */ bool force_writeback; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:59:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517752.803585 (Exim 4.92) (envelope-from ) id 1pjdRZ-0003mr-FD; Tue, 04 Apr 2023 09:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517752.803585; Tue, 04 Apr 2023 09:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdRZ-0003mO-Bx; Tue, 04 Apr 2023 09:59:13 +0000 Received: by outflank-mailman (input) for mailman id 517752; Tue, 04 Apr 2023 09:59:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdMK-00056d-2X for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:48 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 962f50e3-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:53:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 962f50e3-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602025; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BD8/V6HTXPI8zjfRwIUp+LKbifOL/pPEYn5jnL6tGjU=; b=aEhT89AkO8KrOFxlJwGFdsHqSg/+e2oJSGcN+/+4ebY3pOECirJTasTI NJJW2kRRMv4SSesCIJgTczQdOJ1FVlZKpkVyg9387ZRhlEgNqiFgc7JS7 UNO4QXgeunyYt0obMr3+kHTO9kb+XUujwqDpGY3MDaNprTswMPVREsXIh E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103612437 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:KGRsUKqQKYmTq8pX0IbW2gF8deReBmJnZRIvgKrLsJaIsI4StFCzt garIBmFPPyKZGb0KY0iOd61oRsDvpDXm4VhSwo5pSgxHy4ao5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzyVNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGxUbhuAm6WU+7m2d8Q9tu4mEMX6A6pK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj juepDqgWE1Ba7RzzxKD/lb0q+qSkBj6G4YOO5eU8cN2sgeMkzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyNZutnoo510rCnEQ+tOQZ6fi+H5CA7Zl mXiQDcFu1kDsSIa//zlrQia3Gz2+cGhoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawTYm5CKGONYAQMvCdkTNrGwk3PSatM53FyhBwwcnTx 7/AGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+ieD2TCfMGd843K6mMrhRAFWs/F+Er L6y9qKil31ibQEJSnKIrtJJdAxVdChT6FKfg5U/S9Nv6zFOQAkJY8I9C5t4E2C5t8y5Ttv1w 0w= IronPort-HdrOrdr: A9a23:XbA7vaCUYNajGozlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103612437" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 15/15] x86: Remove temporary {cpuid,msr}_policy defines Date: Tue, 4 Apr 2023 10:52:22 +0100 Message-ID: <20230404095222.1373721-16-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit With all code areas updated, drop the temporary defines and adjust all remaining users. No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Split out of RFC patch --- xen/arch/x86/cpu/mcheck/mce_intel.c | 2 +- xen/arch/x86/cpuid.c | 2 +- xen/arch/x86/domain.c | 2 +- xen/arch/x86/hvm/hvm.c | 4 ++-- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/vlapic.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 8 ++++---- xen/arch/x86/include/asm/msr.h | 2 +- xen/arch/x86/msr.c | 20 +++++++++----------- xen/arch/x86/pv/domain.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 4 ++-- xen/arch/x86/traps.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- xen/include/xen/lib/x86/cpu-policy.h | 4 ---- 14 files changed, 26 insertions(+), 32 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c index 301533722d1a..2f23f02923d2 100644 --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -1008,7 +1008,7 @@ int vmce_intel_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) int vmce_intel_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; unsigned int bank = msr - MSR_IA32_MC0_CTL2; switch ( msr ) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 3f20c342fde8..f311372cdf1f 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -36,7 +36,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; *res = EMPTY_LEAF; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index b23e5014d1d3..91f57e3a3b17 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -283,7 +283,7 @@ void update_guest_memory_policy(struct vcpu *v, void domain_cpu_policy_changed(struct domain *d) { - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; struct vcpu *v; if ( is_pv_domain(d) ) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 675c523d9909..7020fdce995c 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -924,7 +924,7 @@ const char *hvm_efer_valid(const struct vcpu *v, uint64_t value, signed int cr0_pg) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; if ( value & ~EFER_KNOWN_MASK ) return "Unknown bits set"; @@ -961,7 +961,7 @@ const char *hvm_efer_valid(const struct vcpu *v, uint64_t value, /* These bits in CR4 can be set by the guest. */ unsigned long hvm_cr4_guest_valid_bits(const struct domain *d) { - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; bool mce, vmxe, cet; /* Logic broken out simply to aid readability below. */ diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 02563e4b7027..b8fe759db456 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -583,7 +583,7 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) { struct svm_vcpu *svm = &v->arch.hvm.svm; struct vmcb_struct *vmcb = svm->vmcb; - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; u32 bitmap = vmcb_get_exception_intercepts(vmcb); if ( opt_hvm_fep || diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index dc93b5e930b1..f4f5ffc673e5 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1083,7 +1083,7 @@ static void set_x2apic_id(struct vlapic *vlapic) int guest_wrmsr_apic_base(struct vcpu *v, uint64_t value) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; struct vlapic *vlapic = vcpu_vlapic(v); if ( !has_vlapic(v->domain) ) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index e05588505871..ee4c41628cc3 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -710,7 +710,7 @@ static void vmx_restore_host_msrs(void) static void vmx_save_guest_msrs(struct vcpu *v) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; struct vcpu_msrs *msrs = v->arch.msrs; /* @@ -731,7 +731,7 @@ static void vmx_save_guest_msrs(struct vcpu *v) static void vmx_restore_guest_msrs(struct vcpu *v) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; const struct vcpu_msrs *msrs = v->arch.msrs; write_gs_shadow(v->arch.hvm.vmx.shadow_gs); @@ -784,7 +784,7 @@ void vmx_update_exception_bitmap(struct vcpu *v) static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; int rc = 0; if ( opt_hvm_fep || @@ -3521,7 +3521,7 @@ static int cf_check vmx_msr_write_intercept( unsigned int msr, uint64_t msr_content) { struct vcpu *v = current; - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x, msr_value=%#"PRIx64, msr, msr_content); diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 458841733e18..1d8ea9f26faa 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -290,7 +290,7 @@ static inline void wrmsr_tsc_aux(uint32_t val) } } -uint64_t msr_spec_ctrl_valid_bits(const struct cpuid_policy *cp); +uint64_t msr_spec_ctrl_valid_bits(const struct cpu_policy *cp); /* Container object for per-vCPU MSRs */ struct vcpu_msrs diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 802fc60baf81..2e16818bf509 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -54,8 +54,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) { const struct vcpu *curr = current; const struct domain *d = v->domain; - const struct cpuid_policy *cp = d->arch.cpuid; - const struct msr_policy *mp = d->arch.msr; + const struct cpu_policy *cp = d->arch.cpu_policy; const struct vcpu_msrs *msrs = v->arch.msrs; int ret = X86EMUL_OKAY; @@ -139,13 +138,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) goto get_reg; case MSR_INTEL_PLATFORM_INFO: - *val = mp->platform_info.raw; + *val = cp->platform_info.raw; break; case MSR_ARCH_CAPABILITIES: if ( !cp->feat.arch_caps ) goto gp_fault; - *val = mp->arch_caps.raw; + *val = cp->arch_caps.raw; break; case MSR_INTEL_MISC_FEATURES_ENABLES: @@ -326,7 +325,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) * separate CPUID features for this functionality, but only set will be * active. */ -uint64_t msr_spec_ctrl_valid_bits(const struct cpuid_policy *cp) +uint64_t msr_spec_ctrl_valid_bits(const struct cpu_policy *cp) { bool ssbd = cp->feat.ssbd || cp->extd.amd_ssbd; bool psfd = cp->feat.intel_psfd || cp->extd.psfd; @@ -345,8 +344,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) { const struct vcpu *curr = current; struct domain *d = v->domain; - const struct cpuid_policy *cp = d->arch.cpuid; - const struct msr_policy *mp = d->arch.msr; + const struct cpu_policy *cp = d->arch.cpu_policy; struct vcpu_msrs *msrs = v->arch.msrs; int ret = X86EMUL_OKAY; @@ -387,7 +385,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) * for backwards compatiblity, the OS should write 0 to it before * trying to access the current microcode version. */ - if ( d->arch.cpuid->x86_vendor != X86_VENDOR_INTEL || val != 0 ) + if ( cp->x86_vendor != X86_VENDOR_INTEL || val != 0 ) goto gp_fault; break; @@ -397,7 +395,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) * to AMD CPUs as well (at least the architectural/CPUID part does). */ if ( is_pv_domain(d) || - d->arch.cpuid->x86_vendor != X86_VENDOR_AMD ) + cp->x86_vendor != X86_VENDOR_AMD ) goto gp_fault; break; @@ -409,7 +407,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) * by any CPUID bit. */ if ( is_pv_domain(d) || - d->arch.cpuid->x86_vendor != X86_VENDOR_INTEL ) + cp->x86_vendor != X86_VENDOR_INTEL ) goto gp_fault; break; @@ -446,7 +444,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) bool old_cpuid_faulting = msrs->misc_features_enables.cpuid_faulting; rsvd = ~0ull; - if ( mp->platform_info.cpuid_faulting ) + if ( cp->platform_info.cpuid_faulting ) rsvd &= ~MSR_MISC_FEATURES_CPUID_FAULTING; if ( val & rsvd ) diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c index 95492715d8ad..5c92812dc67a 100644 --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x86/pv/domain.c @@ -146,7 +146,7 @@ static void release_compat_l4(struct vcpu *v) unsigned long pv_fixup_guest_cr4(const struct vcpu *v, unsigned long cr4) { - const struct cpuid_policy *p = v->domain->arch.cpuid; + const struct cpu_policy *p = v->domain->arch.cpu_policy; /* Discard attempts to set guest controllable bits outside of the policy. */ cr4 &= ~((p->basic.tsc ? 0 : X86_CR4_TSD) | diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index ab52768271c5..04416f197951 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -885,7 +885,7 @@ static int cf_check read_msr( { struct vcpu *curr = current; const struct domain *currd = curr->domain; - const struct cpuid_policy *cp = currd->arch.cpuid; + const struct cpu_policy *cp = currd->arch.cpu_policy; bool vpmu_msr = false, warn = false; uint64_t tmp; int ret; @@ -1034,7 +1034,7 @@ static int cf_check write_msr( { struct vcpu *curr = current; const struct domain *currd = curr->domain; - const struct cpuid_policy *cp = currd->arch.cpuid; + const struct cpu_policy *cp = currd->arch.cpu_policy; bool vpmu_msr = false; int ret; diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index c36e3f855bd9..e4f8b158e1ed 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1036,7 +1036,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; uint32_t base = is_viridian_domain(d) ? 0x40000100 : 0x40000000; uint32_t idx = leaf - base; unsigned int limit = is_viridian_domain(d) ? p->hv2_limit : p->hv_limit; diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index 5a0ec5900a93..c69f7c65f526 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -848,7 +848,7 @@ protmode_load_seg( struct x86_emulate_ctxt *ctxt, const struct x86_emulate_ops *ops) { - const struct cpuid_policy *cp = ctxt->cpuid; + const struct cpu_policy *cp = ctxt->cpu_policy; enum x86_segment sel_seg = (sel & 4) ? x86_seg_ldtr : x86_seg_gdtr; struct { uint32_t a, b; } desc, desc_hi = {}; uint8_t dpl, rpl; diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index dee46adeff17..182cf77cffaf 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -375,10 +375,6 @@ struct cpu_policy uint8_t x86_vendor; }; -/* Temporary */ -#define cpuid_policy cpu_policy -#define msr_policy cpu_policy - struct cpu_policy_errors { uint32_t leaf, subleaf; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:59:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:59:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517768.803600 (Exim 4.92) (envelope-from ) id 1pjdRm-0004r1-1y; Tue, 04 Apr 2023 09:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517768.803600; Tue, 04 Apr 2023 09:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdRl-0004qn-Th; Tue, 04 Apr 2023 09:59:25 +0000 Received: by outflank-mailman (input) for mailman id 517768; Tue, 04 Apr 2023 09:59:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdMG-00056d-FQ for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9433838d-d2ce-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 11:53:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9433838d-d2ce-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602022; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ChH0mv0WlkWt8mC9RVpMxMqX69igiduH8qj4IJ/OTlE=; b=SQUbV8GVwRO3uvUSYpX7wEh1Eu7H6jlNWovrOVwJbiFjpOHwF7RePZTB phvODEYxBcx1TfzkB4RH9RqXaWEF/I5fQwyXJN7cXiI4EOk7RjFMqWrpA fc3UkJ16A2c6Ri52zsC0abLudmRSLCb6FNap6UuDq7+HlyNFBuskcu6ts E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104275209 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:jOR9b6rJqOdbVVFSZpebUQeba2NeBmJnZRIvgKrLsJaIsI4StFCzt garIBmFMvyOZmSmctF2bo+w8h5QuZCBzdM1SVBvqSo3FCpHoJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzyVNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABE1cyvcwN+d+4OmEuBi2f94IMvOOLpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jueoz6mX0tCZbRzzxKGqHGNgM/DzBjaY4EYSoGRyfpj2UO6kzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyMk28TY/8YOpSn+U45qHvGO1dH3PDXJl mXiQDcFu1kDsSIa//zlrQia3Gz2+cGhoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawTYm5CKGONYAQMvCdkTNrGwk3PSatM53FyhBwwcnTx 7/AGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+ieD2TCfMGd843K6mMrhRAFWs/F+Er L6y9qKil31ibQEJSnKIrtJJdAxVdChT6FKfg5U/S9Nv6zFOQAkJY8I9C5t6E2C5t8y5Ttv1w 0w= IronPort-HdrOrdr: A9a23:VwSaD63tK3JQsKmUXOpa4QqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104275209" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 13/15] tools/fuzz: Rework afl-policy-fuzzer Date: Tue, 4 Apr 2023 10:52:20 +0100 Message-ID: <20230404095222.1373721-14-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit With cpuid_policy and msr_policy merged to form cpu_policy, merge the respective fuzzing logic. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New --- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 57 ++++++++--------------- 1 file changed, 20 insertions(+), 37 deletions(-) diff --git a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c index 0ce3d8e16626..466bdbb1d91a 100644 --- a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c +++ b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c @@ -16,16 +16,19 @@ static bool debug; #define EMPTY_LEAF ((struct cpuid_leaf){}) -static void check_cpuid(struct cpuid_policy *cp) +static void check_policy(struct cpu_policy *cp) { - struct cpuid_policy new = {}; + struct cpu_policy new = {}; size_t data_end; xen_cpuid_leaf_t *leaves = malloc(CPUID_MAX_SERIALISED_LEAVES * sizeof(xen_cpuid_leaf_t)); - unsigned int nr = CPUID_MAX_SERIALISED_LEAVES; + xen_msr_entry_t *msrs = malloc(MSR_MAX_SERIALISED_ENTRIES * + sizeof(xen_cpuid_leaf_t)); + unsigned int nr_leaves = CPUID_MAX_SERIALISED_LEAVES; + unsigned int nr_msrs = MSR_MAX_SERIALISED_ENTRIES; int rc; - if ( !leaves ) + if ( !leaves || !msrs ) return; /* @@ -49,12 +52,19 @@ static void check_cpuid(struct cpuid_policy *cp) x86_cpuid_policy_recalc_synth(cp); /* Serialise... */ - rc = x86_cpuid_copy_to_buffer(cp, leaves, &nr); + rc = x86_cpuid_copy_to_buffer(cp, leaves, &nr_leaves); + assert(rc == 0); + assert(nr_leaves <= CPUID_MAX_SERIALISED_LEAVES); + + rc = x86_msr_copy_to_buffer(cp, msrs, &nr_msrs); assert(rc == 0); - assert(nr <= CPUID_MAX_SERIALISED_LEAVES); + assert(nr_msrs <= MSR_MAX_SERIALISED_ENTRIES); /* ... and deserialise. */ - rc = x86_cpuid_copy_from_buffer(&new, leaves, nr, NULL, NULL); + rc = x86_cpuid_copy_from_buffer(&new, leaves, nr_leaves, NULL, NULL); + assert(rc == 0); + + rc = x86_msr_copy_from_buffer(&new, msrs, nr_msrs, NULL); assert(rc == 0); /* The result after serialisation/deserialisaion should be identical... */ @@ -76,28 +86,6 @@ static void check_cpuid(struct cpuid_policy *cp) free(leaves); } -static void check_msr(struct msr_policy *mp) -{ - struct msr_policy new = {}; - xen_msr_entry_t *msrs = malloc(MSR_MAX_SERIALISED_ENTRIES * - sizeof(xen_msr_entry_t)); - unsigned int nr = MSR_MAX_SERIALISED_ENTRIES; - int rc; - - if ( !msrs ) - return; - - rc = x86_msr_copy_to_buffer(mp, msrs, &nr); - assert(rc == 0); - assert(nr <= MSR_MAX_SERIALISED_ENTRIES); - - rc = x86_msr_copy_from_buffer(&new, msrs, nr, NULL); - assert(rc == 0); - assert(memcmp(mp, &new, sizeof(*mp)) == 0); - - free(msrs); -} - int main(int argc, char **argv) { FILE *fp = NULL; @@ -144,8 +132,7 @@ int main(int argc, char **argv) while ( __AFL_LOOP(1000) ) #endif { - struct cpuid_policy *cp = NULL; - struct msr_policy *mp = NULL; + struct cpu_policy *cp = NULL; if ( fp != stdin ) { @@ -160,22 +147,18 @@ int main(int argc, char **argv) } cp = calloc(1, sizeof(*cp)); - mp = calloc(1, sizeof(*mp)); - if ( !cp || !mp ) + if ( !cp ) goto skip; fread(cp, sizeof(*cp), 1, fp); - fread(mp, sizeof(*mp), 1, fp); if ( !feof(fp) ) goto skip; - check_cpuid(cp); - check_msr(mp); + check_policy(cp); skip: free(cp); - free(mp); if ( fp != stdin ) { -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 09:59:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 09:59:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517772.803610 (Exim 4.92) (envelope-from ) id 1pjdRn-00058l-9L; Tue, 04 Apr 2023 09:59:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517772.803610; Tue, 04 Apr 2023 09:59:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdRn-000582-5z; Tue, 04 Apr 2023 09:59:27 +0000 Received: by outflank-mailman (input) for mailman id 517772; Tue, 04 Apr 2023 09:59:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdM5-0005bo-SB for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:53:34 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8dd3c787-d2ce-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:53:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dd3c787-d2ce-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602012; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S9rrbCEYs4IT9bqKPV/iJx2K9DkXe5RcZyCTKB2nQ9U=; b=OYDADpeDP5cEnFRW6GUiK3sGMYpY8eqSwL2Ynnejkj/FXDgApxclEytm slgEqR2VE/GZsSnLewg1GrazG8oitkZVgC++JrgWoc2OW8rb82hn+vaTb WsTsSRHvgd0DlV0iSeHuyMjBSFZOr+tHHR4GfzzfnkRkwCs99iGWT8EWr I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104656599 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:Fsg6SaOJIj2cUo7vrR3al8FynXyQoLVcMsEvi/4bfWQNrUolhT1Ty 2JMX2yGbvjZNGX1edklbYq0pksH65LRndQ2GQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0ut4C0Bc/ qETEzkIdA6fuNir4by7cuY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUoXSGZsIwBvJ9 woq+UymDD0CCs2P1wamzWj1rOv0jSH7fpIdQejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxasnDQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBeeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwAYImUjdyRZRjAM5sP9vL4JkzPBTu5sRfvdYsLOJd3g/ 9ybhHFg1+1O0pBRiPzTEUPv2Gz1+MWQJuIhzkCOBz/+sFskDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKMN8N7n9hV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPEnO9/tVZVwlvK+RbwJs8w4ifIXOvBMmPKvpnkyNSZ8IUi2+KTTrU3PE cjCKpv9ZZrrIa9m0CC3V48g7FPf/QhnnTm7bcmin3yaPU+2OCb9pUEtbAHfMYjULcqs/G3oz jqoH5DVlEkFCbGhO3m/HEx6BQliEEXXzKve86R/HtNv6CI/cI39I5c9GY8cRrE= IronPort-HdrOrdr: A9a23:ujXFI61ilrIcMTIDVr7uEwqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104656599" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 14/15] libx86: Update library API for cpu_policy Date: Tue, 4 Apr 2023 10:52:21 +0100 Message-ID: <20230404095222.1373721-15-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-1-andrew.cooper3@citrix.com> References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Adjust the API and comments appropriately. x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a TODO in the short term. No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New --- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 4 +-- tools/tests/cpu-policy/test-cpu-policy.c | 4 +-- tools/tests/x86_emulator/x86-emulate.c | 2 +- xen/arch/x86/cpu-policy.c | 2 +- xen/arch/x86/domctl.c | 2 +- xen/arch/x86/xstate.c | 4 +-- xen/include/xen/lib/x86/cpu-policy.h | 42 ++++++++++++----------- xen/lib/x86/cpuid.c | 24 +++++++------ xen/lib/x86/msr.c | 4 +-- 9 files changed, 46 insertions(+), 42 deletions(-) diff --git a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c index 466bdbb1d91a..7d8467b4b258 100644 --- a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c +++ b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c @@ -48,8 +48,8 @@ static void check_policy(struct cpu_policy *cp) * Fix up the data in the source policy which isn't expected to survive * serialisation. */ - x86_cpuid_policy_clear_out_of_range_leaves(cp); - x86_cpuid_policy_recalc_synth(cp); + x86_cpu_policy_clear_out_of_range_leaves(cp); + x86_cpu_policy_recalc_synth(cp); /* Serialise... */ rc = x86_cpuid_copy_to_buffer(cp, leaves, &nr_leaves); diff --git a/tools/tests/cpu-policy/test-cpu-policy.c b/tools/tests/cpu-policy/test-cpu-policy.c index a4ca07f33973..f1d968adfc39 100644 --- a/tools/tests/cpu-policy/test-cpu-policy.c +++ b/tools/tests/cpu-policy/test-cpu-policy.c @@ -105,7 +105,7 @@ static void test_cpuid_current(void) printf("Testing CPUID on current CPU\n"); - x86_cpuid_policy_fill_native(&p); + x86_cpu_policy_fill_native(&p); rc = x86_cpuid_copy_to_buffer(&p, leaves, &nr); if ( rc != 0 ) @@ -554,7 +554,7 @@ static void test_cpuid_out_of_range_clearing(void) void *ptr; unsigned int nr_markers; - x86_cpuid_policy_clear_out_of_range_leaves(p); + x86_cpu_policy_clear_out_of_range_leaves(p); /* Count the number of 0xc2's still remaining. */ for ( ptr = p, nr_markers = 0; diff --git a/tools/tests/x86_emulator/x86-emulate.c b/tools/tests/x86_emulator/x86-emulate.c index 2692404df906..7d2d57f7591a 100644 --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -75,7 +75,7 @@ bool emul_test_init(void) unsigned long sp; - x86_cpuid_policy_fill_native(&cp); + x86_cpu_policy_fill_native(&cp); /* * The emulator doesn't use these instructions, so can always emulate diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 83186e940ca7..1140f0b365cd 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -347,7 +347,7 @@ static void __init calculate_raw_policy(void) { struct cpu_policy *p = &raw_cpu_policy; - x86_cpuid_policy_fill_native(p); + x86_cpu_policy_fill_native(p); /* Nothing good will come from Xen and libx86 disagreeing on vendor. */ ASSERT(p->x86_vendor == boot_cpu_data.x86_vendor); diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index c02528594102..1a8b4cff48ee 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -66,7 +66,7 @@ static int update_domain_cpu_policy(struct domain *d, goto out; /* Trim any newly-stale out-of-range leaves. */ - x86_cpuid_policy_clear_out_of_range_leaves(new); + x86_cpu_policy_clear_out_of_range_leaves(new); /* Audit the combined dataset. */ ret = x86_cpu_policies_are_compatible(sys, new, &err); diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index d481e1db3e7e..92496f379546 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -684,7 +684,7 @@ void xstate_init(struct cpuinfo_x86 *c) int validate_xstate(const struct domain *d, uint64_t xcr0, uint64_t xcr0_accum, const struct xsave_hdr *hdr) { - uint64_t xcr0_max = cpuid_policy_xcr0_max(d->arch.cpuid); + uint64_t xcr0_max = cpu_policy_xcr0_max(d->arch.cpuid); unsigned int i; if ( (hdr->xstate_bv & ~xcr0_accum) || @@ -708,7 +708,7 @@ int validate_xstate(const struct domain *d, uint64_t xcr0, uint64_t xcr0_accum, int handle_xsetbv(u32 index, u64 new_bv) { struct vcpu *curr = current; - uint64_t xcr0_max = cpuid_policy_xcr0_max(curr->domain->arch.cpuid); + uint64_t xcr0_max = cpu_policy_xcr0_max(curr->domain->arch.cpuid); u64 mask; if ( index != XCR_XFEATURE_ENABLED_MASK ) diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 57b4633c861e..dee46adeff17 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -399,12 +399,12 @@ void x86_cpu_policy_to_featureset(const struct cpu_policy *p, void x86_cpu_featureset_to_policy(const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpu_policy *p); -static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p) +static inline uint64_t cpu_policy_xcr0_max(const struct cpu_policy *p) { return ((uint64_t)p->xstate.xcr0_high << 32) | p->xstate.xcr0_low; } -static inline uint64_t cpuid_policy_xstates(const struct cpuid_policy *p) +static inline uint64_t cpu_policy_xstates(const struct cpu_policy *p) { uint64_t val = p->xstate.xcr0_high | p->xstate.xss_high; @@ -414,18 +414,18 @@ static inline uint64_t cpuid_policy_xstates(const struct cpuid_policy *p) const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature); /** - * Recalculate the content in a CPUID policy which is derived from raw data. + * Recalculate the content in a CPU policy which is derived from raw data. */ -void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p); +void x86_cpu_policy_recalc_synth(struct cpu_policy *p); /** - * Fill a CPUID policy using the native CPUID instruction. + * Fill CPU policy using the native CPUID/RDMSR instruction. * * No sanitisation is performed, but synthesised values are calculated. * Values may be influenced by a hypervisor or from masking/faulting * configuration. */ -void x86_cpuid_policy_fill_native(struct cpuid_policy *p); +void x86_cpu_policy_fill_native(struct cpu_policy *p); /** * Clear leaf data beyond the policies max leaf/subleaf settings. @@ -436,7 +436,7 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p); * with out-of-range leaves with stale content in them. This helper clears * them. */ -void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p); +void x86_cpu_policy_clear_out_of_range_leaves(struct cpu_policy *p); #ifdef __XEN__ #include @@ -449,9 +449,10 @@ typedef xen_msr_entry_t msr_entry_buffer_t[]; #endif /** - * Serialise a cpuid_policy object into an array of cpuid leaves. + * Serialise the CPUID leaves of a cpu_policy object into an array of cpuid + * leaves. * - * @param policy The cpuid_policy to serialise. + * @param policy The cpu_policy to serialise. * @param leaves The array of leaves to serialise into. * @param nr_entries The number of entries in 'leaves'. * @returns -errno @@ -460,13 +461,14 @@ typedef xen_msr_entry_t msr_entry_buffer_t[]; * leaves array is too short. On success, nr_entries is updated with the * actual number of leaves written. */ -int x86_cpuid_copy_to_buffer(const struct cpuid_policy *policy, +int x86_cpuid_copy_to_buffer(const struct cpu_policy *policy, cpuid_leaf_buffer_t leaves, uint32_t *nr_entries); /** - * Unserialise a cpuid_policy object from an array of cpuid leaves. + * Unserialise the CPUID leaves of a cpu_policy object into an array of cpuid + * leaves. * - * @param policy The cpuid_policy to unserialise into. + * @param policy The cpu_policy to unserialise into. * @param leaves The array of leaves to unserialise from. * @param nr_entries The number of entries in 'leaves'. * @param err_leaf Optional hint for error diagnostics. @@ -474,21 +476,21 @@ int x86_cpuid_copy_to_buffer(const struct cpuid_policy *policy, * @returns -errno * * Reads at most CPUID_MAX_SERIALISED_LEAVES. May return -ERANGE if an - * incoming leaf is out of range of cpuid_policy, in which case the optional + * incoming leaf is out of range of cpu_policy, in which case the optional * err_* pointers will identify the out-of-range indicies. * * No content validation of in-range leaves is performed. Synthesised data is * recalculated. */ -int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, +int x86_cpuid_copy_from_buffer(struct cpu_policy *policy, const cpuid_leaf_buffer_t leaves, uint32_t nr_entries, uint32_t *err_leaf, uint32_t *err_subleaf); /** - * Serialise an msr_policy object into an array. + * Serialise the MSRs of a cpu_policy object into an array. * - * @param policy The msr_policy to serialise. + * @param policy The cpu_policy to serialise. * @param msrs The array of msrs to serialise into. * @param nr_entries The number of entries in 'msrs'. * @returns -errno @@ -497,13 +499,13 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, * buffer array is too short. On success, nr_entries is updated with the * actual number of msrs written. */ -int x86_msr_copy_to_buffer(const struct msr_policy *policy, +int x86_msr_copy_to_buffer(const struct cpu_policy *policy, msr_entry_buffer_t msrs, uint32_t *nr_entries); /** - * Unserialise an msr_policy object from an array of msrs. + * Unserialise the MSRs of a cpu_policy object from an array of msrs. * - * @param policy The msr_policy object to unserialise into. + * @param policy The cpu_policy object to unserialise into. * @param msrs The array of msrs to unserialise from. * @param nr_entries The number of entries in 'msrs'. * @param err_msr Optional hint for error diagnostics. @@ -517,7 +519,7 @@ int x86_msr_copy_to_buffer(const struct msr_policy *policy, * * No content validation is performed on the data stored in the policy object. */ -int x86_msr_copy_from_buffer(struct msr_policy *policy, +int x86_msr_copy_from_buffer(struct cpu_policy *policy, const msr_entry_buffer_t msrs, uint32_t nr_entries, uint32_t *err_msr); diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index 734e90823a63..7c7b092736ff 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -102,13 +102,13 @@ void x86_cpu_featureset_to_policy( p->feat._7d1 = fs[FEATURESET_7d1]; } -void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p) +void x86_cpu_policy_recalc_synth(struct cpu_policy *p) { p->x86_vendor = x86_cpuid_lookup_vendor( p->basic.vendor_ebx, p->basic.vendor_ecx, p->basic.vendor_edx); } -void x86_cpuid_policy_fill_native(struct cpuid_policy *p) +void x86_cpu_policy_fill_native(struct cpu_policy *p) { unsigned int i; @@ -199,7 +199,7 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p) cpuid_count_leaf(0xd, 0, &p->xstate.raw[0]); cpuid_count_leaf(0xd, 1, &p->xstate.raw[1]); - xstates = cpuid_policy_xstates(p); + xstates = cpu_policy_xstates(p); /* This logic will probably need adjusting when XCR0[63] gets used. */ BUILD_BUG_ON(ARRAY_SIZE(p->xstate.raw) > 63); @@ -222,10 +222,12 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p) p->hv_limit = 0; p->hv2_limit = 0; - x86_cpuid_policy_recalc_synth(p); + /* TODO MSRs */ + + x86_cpu_policy_recalc_synth(p); } -void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) +void x86_cpu_policy_clear_out_of_range_leaves(struct cpu_policy *p) { unsigned int i; @@ -260,7 +262,7 @@ void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) zero_leaves(p->topo.raw, i, ARRAY_SIZE(p->topo.raw) - 1); } - if ( p->basic.max_leaf < 0xd || !cpuid_policy_xstates(p) ) + if ( p->basic.max_leaf < 0xd || !cpu_policy_xstates(p) ) memset(p->xstate.raw, 0, sizeof(p->xstate.raw)); else { @@ -268,7 +270,7 @@ void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) BUILD_BUG_ON(ARRAY_SIZE(p->xstate.raw) > 63); /* First two leaves always valid. Rest depend on xstates. */ - i = max(2, 64 - __builtin_clzll(cpuid_policy_xstates(p))); + i = max(2, 64 - __builtin_clzll(cpu_policy_xstates(p))); zero_leaves(p->xstate.raw, i, ARRAY_SIZE(p->xstate.raw) - 1); @@ -333,7 +335,7 @@ static int copy_leaf_to_buffer(uint32_t leaf, uint32_t subleaf, return 0; } -int x86_cpuid_copy_to_buffer(const struct cpuid_policy *p, +int x86_cpuid_copy_to_buffer(const struct cpu_policy *p, cpuid_leaf_buffer_t leaves, uint32_t *nr_entries_p) { const uint32_t nr_entries = *nr_entries_p; @@ -383,7 +385,7 @@ int x86_cpuid_copy_to_buffer(const struct cpuid_policy *p, case 0xd: { - uint64_t xstates = cpuid_policy_xstates(p); + uint64_t xstates = cpu_policy_xstates(p); COPY_LEAF(leaf, 0, &p->xstate.raw[0]); COPY_LEAF(leaf, 1, &p->xstate.raw[1]); @@ -419,7 +421,7 @@ int x86_cpuid_copy_to_buffer(const struct cpuid_policy *p, return 0; } -int x86_cpuid_copy_from_buffer(struct cpuid_policy *p, +int x86_cpuid_copy_from_buffer(struct cpu_policy *p, const cpuid_leaf_buffer_t leaves, uint32_t nr_entries, uint32_t *err_leaf, uint32_t *err_subleaf) @@ -522,7 +524,7 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *p, } } - x86_cpuid_policy_recalc_synth(p); + x86_cpu_policy_recalc_synth(p); return 0; diff --git a/xen/lib/x86/msr.c b/xen/lib/x86/msr.c index c4d885e7b568..e04b9ca01302 100644 --- a/xen/lib/x86/msr.c +++ b/xen/lib/x86/msr.c @@ -23,7 +23,7 @@ static int copy_msr_to_buffer(uint32_t idx, uint64_t val, return 0; } -int x86_msr_copy_to_buffer(const struct msr_policy *p, +int x86_msr_copy_to_buffer(const struct cpu_policy *p, msr_entry_buffer_t msrs, uint32_t *nr_entries_p) { const uint32_t nr_entries = *nr_entries_p; @@ -48,7 +48,7 @@ int x86_msr_copy_to_buffer(const struct msr_policy *p, return 0; } -int x86_msr_copy_from_buffer(struct msr_policy *p, +int x86_msr_copy_from_buffer(struct cpu_policy *p, const msr_entry_buffer_t msrs, uint32_t nr_entries, uint32_t *err_msr) { -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:05:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:05:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517792.803620 (Exim 4.92) (envelope-from ) id 1pjdX2-0007Yq-V8; Tue, 04 Apr 2023 10:04:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517792.803620; Tue, 04 Apr 2023 10:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdX2-0007Yj-SH; Tue, 04 Apr 2023 10:04:52 +0000 Received: by outflank-mailman (input) for mailman id 517792; Tue, 04 Apr 2023 10:04:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdX1-0007Yd-Iw for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:04:51 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 21e6e2bd-d2d0-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 12:04:49 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 06:04:29 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6924.namprd03.prod.outlook.com (2603:10b6:303:1bb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 10:04:26 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 10:04:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21e6e2bd-d2d0-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680602690; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Ok66YB07IDcQouChuZxEPNj7oZ/Qz8j2cCPSknr1tlo=; b=F0QEIX8BP3zk7NZk9Im7hYet8FOiAT+NLlI32ZEOobCN/qM7eUXl6yBE /Py5mtSxbHdpyTy/yBFEo7LXvL+8s+KGsXACw2V9QVW4DdurCF8wdaL+7 IIeQapm/GdMXRMD3mVTeakVXVBDw4iSzcBvNo/o0ncfJdDIZI3pyqGjBX 4=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 103613987 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4L8JBq4rgJJCZCjKFrxnNAxRtBnGchMFZxGqfqrLsTDasY5as4F+v mMZCzyOPvmDYWf3c9Egb46zoxsH6pLcm9JkSwNprnoyHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 80/CGgtfAy5mLyI452WFvBvo+4zI5y+VG8fkikIITDxK98DGMmGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEoojumF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxXilAdlDROLQGvhCqkO83FdJKyYtd0qJ/NW2lBGif+p6E hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACAEDs9/qpdhqigqVF4gyVqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraT0tDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:npkDy6N7m60jLsBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103613987" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fP30eJHQi8VKXJe0tPnSekRi/t+MnesKJZwzkFusYT6vl30Zn5uhhD7b0PX+Zk6kisWYCuSvG8rpuxfoFxC1JrEqpzNx2xDzXFgZzuNGf9OIper592uKSKvoeSmN13Mr+sn1c0u4LakFKLJ4kT0pEy4lpxgks95/enTYSp9YhjQy1DEP+qrzMe1eQZDq6znMTfoeEwCbrP6dX1UfbHKD43HA3UiMXts9BxFXcanYR1w3NO8SFYeYSaRY7KaASxglEE9gMf6QFF59224FIwjPVwXvl0q64seyv1Yi5PtB6+V2WN8Jqa5hsO8UDTbvQd9sdjoHTjWb0GRn4NQhOibz+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PevfhuB9Pt0w/l3GtYOJ6zG/k37g0KxbE8D4sxkY1qE=; b=OSDS5bsm90d9YFNJLl2qwRi6LdWbDOAGkDNjbVJM14Pb2Uca2u5HDXoaM8YC0Azsh/sfJQFgBO4IHuiqrhiYZrVIIr8GUtyL1MG1CqwLwK5MyvIwfia4R37bBvNQOkyRKQYtGuIfPFmhnAGvA5qJMbz5oKwPJHqD+rQFdDP2TVc2Ep/jLrO5XNff3mBV1oQ/4c8PakM8EMKzhasj5GplkEt5kJgJHVthQZlObU1vIH6PrQF7HxNslWbD8GpjP6oE5A1HKVjqdiixTMg+ZNK/+k+Q1soD0qsHZxYM32UVKYDwZYjiX8A27uUJP+6z1dMHlnOVKMLo3BaGzWtZuexGVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PevfhuB9Pt0w/l3GtYOJ6zG/k37g0KxbE8D4sxkY1qE=; b=hQ3MNP477Zn1a/AjqZq1kOCIZ4/IbbWL5EqAcCoPQEU2Gh929RmfPGy5nRF+WuTfZ5ER5GalC3jBPLiqL4Jv8LtErOaR3luFcLbhmoTHMpMYA0O58n2zXMxttrKfKTFoDyumZ39ODLuCBhhRsG2HrDLc68daGzZGhi6xMMKIl3M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 12:04:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH v2] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P302CA0001.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6924:EE_ X-MS-Office365-Filtering-Correlation-Id: 766ad71d-d05c-4f1b-6aef-08db34f3f92f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nKJQqF89Hhdxl26J+mlEYZNnDz5aL+8pIQBG+VyLkgtFdIxvk8kvXxo4p78DVZgSUdSalDfWBmX2Zg2nCPA+IXyzhH94L7Cw/fHgD/6+yx+c0wl+i4lUnYCmvcni+b5v39sdY/YKUqWoo7tVKXdwrY1CkJKgTttAow37q0VmXRL6pG/T9E56CH7X4RMyR3i5BDTlaotNAqk0m3aGepUbvLxXvjiIrLrY6N8TAPwZ8AUKW8Fb6Z+20r43djPEtiHUhchkCUjG30D1H9KwndlPNK2AucAzzXkj8hOxEdZpZubpsaKKwrxaxnLtCoKwGhm9YMLmctTmxG1X0uKsk0CMX3rwELR1uPE9Qhhvv1hlgzzWQYCMh2pww3z3SUQDrekzRugg3EE5kBD4+FN4XzSmul6wBZVazEW+f/+sHY+OH32f+pZghKS0DvjNlS5dgb91T+PqR7XGCz4NYAMKIEsX1ifqsksRkF/MF6JF+7wO39WO82yCPZwQaEQDloFWenJUg11sO+du2qHHWgdCjM9KYrTi/9UVnqfegWQQGV5HEqtGRWpVkg7SawLJhXkSBmcd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199021)(86362001)(66946007)(41300700001)(4326008)(8676002)(66476007)(66556008)(6916009)(316002)(6486002)(83380400001)(85182001)(6666004)(478600001)(33716001)(54906003)(2906002)(38100700002)(5660300002)(8936002)(186003)(6512007)(6506007)(9686003)(26005)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHMvTGFrcWcrVmEvWFJjems4d1RWNDZOOFBUUExmYmY0b0tya1ByMDJxQlJM?= =?utf-8?B?dUNLUXFGVFAySWNQSFJGMmw0NlhROFoyaGRSQWRqT3RFZDRERk9aRW1SOXpx?= =?utf-8?B?MGhBcWw3VHMyN1lMdUk2SUtjTEtUZ2NsOXVESmhzdTlsRTV3OXV1RFZaRy9y?= =?utf-8?B?eWp6ak5TYy9JSTZWbGErc1dZS0FaY2FRWHpkSXlwZ2srVTRId2JhQkdhTVlq?= =?utf-8?B?aWtQU2M2RXFSUytRQm42SWN2QSs4Znd6aVIwZDMyYkd1Smw1TWl3VXQvOEZx?= =?utf-8?B?VEd5V1JPQ2VNZkhOYitCWHRqRGt4WVBMN3BPTzhnYXFZVnV4Wm1rZFJQVUlm?= =?utf-8?B?THhtS3JsMUh4MU95UXY0dDcrZzBNc2dLMWlzaTBqTlp6RStZMXVrZDRvcFdZ?= =?utf-8?B?aTZVM2pEVkNkNlJ6TFIwQXd6VVdDNWttdVYwQzBPUlVYK3ZuTm1nbnZJcnFG?= =?utf-8?B?eGkzRnNiSFRxTHk5VkorZlZWWjRsajVTVnZqazB6WFhlc0hoSUYrVTFCQkRm?= =?utf-8?B?LzRuYXBiSnE4RzBiOTN5NEE5amtrY0F0UnRJQWZoaVhEOGY1WkZIODQxalNG?= =?utf-8?B?U2hmaXV0UWkvTzBWd0hqNVVYY0p0THRiY1B3UGxxdUNZUkxEK25NNUpEMkxW?= =?utf-8?B?dEQydkIxbEh1VGtFOFRlcXJaeWZOUDJRVTlEZTZaZk9PbU4wSGM2dnRZeEh5?= =?utf-8?B?QS9MbXk5dVZYYjRZdGN6ZmVlRkdORzdBc1BaSGhzeWJ3bVRLdWxwZGMzUXI1?= =?utf-8?B?UTJFZFVzS3dBTGdiZlAwQ2xDeUU5bWpreGQ4c3NNYTNzazNPRFprNm9vSGpm?= =?utf-8?B?eHlTZGt1Njd2MGVRWnM4RHhLTEhXdHRvVDhDRG1Za1kvcloydUhtZ2s0eXlR?= =?utf-8?B?TXNLZGpEbEZ0cU1CdGpuamZwbUJBcGxGNnd4M3pOcmw1TnJzVmI3c2JoYVZZ?= =?utf-8?B?QUVBU1BzdG5jbWhFSzJ4N2tBMGNPQ045Z3JDdTdOdjBjSFVFdjBxbi9SY2N4?= =?utf-8?B?VnlpM3VTRERjQmJGM0xSNFhwR3JkT0dCZkQxSUZlRXhPUXRYWlM3UVdCZmpE?= =?utf-8?B?enIxcTBuaVdyM0E5YzZZdlBSR0RtMjlteHRZbDdwbGQ4cWJ5ajNlbllmeHdT?= =?utf-8?B?TVlNM2NJYkpLQ0ZjcnZxOW9jd1RKVWtSTzRMUnIxZVdVSzJ6MTdHK2FBZTFS?= =?utf-8?B?ZG9QU0lUQ0RHYWMrdVhhV0tDNnFzcUpIQzVRakJIbTJtS0lMczgwaFBJZU1W?= =?utf-8?B?VS9BWjNZaG1MREtadG1Udjh2YkR0REFGQ1I2RmlUYmxPNjB3ZkRJN2wxZ3pV?= =?utf-8?B?K2xzRzJjVVhWZlpjcnJqRFQrcGlGdHd1RDdoalh4ZnB3bVpaaVhKN2pPMjM2?= =?utf-8?B?UDNQQm9UNjJIQmdDdkNyRlJrS0JqTmtJNW5KV0hhLys1L21Wc1EzTjlGa1Z5?= =?utf-8?B?MGZnUjVzdGpjOVhpUDE2Qm5xeHRxc2N6YS9OeXBGTjdZVFRJNnBPb3h1VUpv?= =?utf-8?B?dk1kaDdZZnhJK3lYblF2NWludFJSeE52WUIzSEJlcXg1RU9mdDN4RFJFWnRN?= =?utf-8?B?SFAvRWp2dkIrVXRYSWpTRzAybDd4VFp6em03aFEwaWNoSkdadmgrSy9BTGpG?= =?utf-8?B?M0VHTDV1T3ovQ2Q4b3BvNzJXbnlGSExYWG1LVC9Da3pKTXZkeHJxelRWTmxQ?= =?utf-8?B?SGFTOVduRUNOWVBRS2NkMk1OV0tiaEZsUmUxOHFCMjhqaXE5dU0xd0pyMjBj?= =?utf-8?B?akpEbUEzWUNIRkNBVWw2ZWFNU2tlTEozaEhOV0ZPVHpIL1VGVXE5UHRrVFVw?= =?utf-8?B?di9ZNTBLNVdqYkFuNG9sK21BMHpWME1uUS9nM1ZoUlhwVUlGdzA4bEpxN3RJ?= =?utf-8?B?MWxrbUhOeDRkWVpQSjNLMGZ6bThxVEV1UnNLRStSdjBhWEVKODI3UUR6T2Vj?= =?utf-8?B?cU1DK0VkZldDWldqSDg4T2VLbUw5d1B2OEw3clFiVEZrZHYxTmhMNlNCRENw?= =?utf-8?B?RTQrRTBHMUk1TVJIK1lJRjRiRkZrTG9ldWxtMWdLY3dYYm1UK1lYODNEUHgw?= =?utf-8?B?WVVKZnEwWldMMjloU2prTHV0bEdpYnVJSGxxRDlzTlRKL2FyQ0JPWXhQbDly?= =?utf-8?B?bDYxQ3l0LzJ0QjBwWG9KYmxzYTY3VGxKanFBekcySVBZbkxrVmtzL1J3bktR?= =?utf-8?B?a1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZH/1KQtAM0OjJLSuoJgE3HYP3c9n3ZyPAhPvrdnQdPNwVPhed2QhDDzLGlN+NZweFg+LJ5XQ7id5JyJou3sCkja/fXnhFoABVNR9IBSJ7FGWxqE85uOqohQ4ikHFkxfXwUd0GJZhr81jhEADZAMljADrymIQ0M8zAPXwbQoki2N54d6roesiEgupY4MSIo1EKzziHvNVN/Lx6zAvY3/OPuMhcgemxM8VlGe0AIJAZuPo3Faxm89ePbo9YHuyi17C3zdfZkpOT/BidVjR2lyWT1/YX+0Z7jz6V0q5ipUwIPpZBQNS98ApQPx4o80Pu02EvRO+B9v3nJhWKA8Tt8+GQBXLFmpCGh2Vni3TutLPdws4L9ofkhMkvd9cYYzmlfeH70WKbxWAlmuQyQXnEifGupDJ93XZor7iw8L8NoRYaOuv+DJVxm43a0vddIQyGYWCRVoEeJ1JQrG/i8MMp7drtwEJ4sBl9Ho+YPw4pxdUvQOcj2NHjY33iMUjjndmHwSKO/frqxWnooUyYhYsT9deiF6UdMmKHhTqeZ/tDW6ra76P4QK9TkoovTxNBXWWBZ6uygNfOd3OXMjVuS0wmbAoCEDWMRJOJkFi5+6x6tysN3axthm0MmwH1qytuhpUJLFgC1J0MNG3VzlEWhuTmxIZw6s+75GZJIY3wJL0YHq4ACgdQYhqcRxH/mkOHauQdSe44WkRo/vu1qn1GcEhCO2PZ8TdbnVWT3t7Enff2teRxOttBUQv8AM66hn8qpMGuMwckclus8R+iIO6eHGg6p7bWnohmkC1sKWbF6Jkxt+AAqRLvOgCeJKpQglfmXpCDZet X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 766ad71d-d05c-4f1b-6aef-08db34f3f92f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:04:26.6749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jAov9yYDQGiSrqY7surtFpGMNMINFytH1pFpVooB4mwoySgSwiJIYSmHNIYbsWNK002qT79R6yd0gJZcMA1ymw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6924 On Tue, Apr 04, 2023 at 11:19:08AM +0200, Jan Beulich wrote: > Besides a printk() the main effect is slight corruption of the start > info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended > up as xen-3.0-x86_64p. > > Note that no known users exist that would have developed a dependency on > the bogus magic string. In particular Linux, NetBSD, and mini-os have > been checked. > > Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné > --- > RFC: While Linux works fine with the adjustment, I'm not entirely > certain of external tools (crash?) having grown a dependency. It > may be worth noting that XenoLinux and its forward ports never had > this ELF note in 64-bit kernels, so in principle it may be > reasonable to expect that no such dependency exists anywhere. > > Prior to "x86/PV32: restore PAE-extended-CR3 logic" that (meaningless > for 64-bit domains) VM-assist could also be engaged, based on the ELF > note's value. I expect that change to go in first, at which point the > description here is going to be correct (in not mentioning this VM- > assist aspect). Will look at it now. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:12:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:12:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517798.803629 (Exim 4.92) (envelope-from ) id 1pjdeL-0000gb-SG; Tue, 04 Apr 2023 10:12:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517798.803629; Tue, 04 Apr 2023 10:12:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdeL-0000gU-Pg; Tue, 04 Apr 2023 10:12:25 +0000 Received: by outflank-mailman (input) for mailman id 517798; Tue, 04 Apr 2023 10:12:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdeK-0000gO-H2 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:12:24 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f2b7090-d2d1-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 12:12:21 +0200 (CEST) Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 06:12:19 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5758.namprd03.prod.outlook.com (2603:10b6:a03:2d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 10:12:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 10:12:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f2b7090-d2d1-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680603141; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=UFz2JVkAVtyrZ1xbzG59PK/LiPSeghCsIzW9wX9wibQ=; b=IIwMwk2mD2gqMO5VrcN+HgI6dyGaXHRUJTX4/1YUGg09PlWG1R026BLx aJaqqJfoPjJFSUxF/KSBKjovDS25PkpPIMpCW+UgBtxCdefygykByrhpY wc8zjImYwLJtk7YX1aTPnYV4mXvZKHs180NsJFSNHjmAb5qytqWg47vSY o=; X-IronPort-RemoteIP: 104.47.58.101 X-IronPort-MID: 103615075 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Asrj+KvuNbpgxrEJ3IfbOPlfHufnVHBfMUV32f8akzHdYApBsoF/q tZmKWDQM/feYzb9eosgb4m19EMH6sXTn99nTlY+qSw2FSpH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCT1SfBuFwLKP27u1QPB0nIN4b8jXBdZK0p1g5Wmx4fcOZ7nmGv2PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60aIO9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiANlMTeDgqaMCbFu7/3EpGgdPSFyA+8Kyt0mQQNQBO 3FT5X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRVLufgcBRAoBptXm/oc6i0uXSs45SfbsyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:TQutO6xlArgAKiQ1wctdKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103615075" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZN0z6NogvqAaI2zwHlEDQacuH1AVq4OoYovgnv8nxAFCM4+ZosOa/2wzxJBtFILNsobh/QxpIzzgTbUfoqVjnIW6w7z4+8axSNPDPpAzwV+T2BWe3xW7Npsl+0bL7mCjr0jWnOLTGe4wXvBuKxzAtOonUnKBw06T2TnlavqIZjDtd4bVICQFcfyR8M6M89VEc5ZiDAju2dcXjoTiFg+UVID0uOe0r8qM75TiVetWqxd3C+DzgqMC3mtANKN5qx2Rq/plvufVLlhGnHr6XXNB8cauJHwqgqsJmpPlR19Au3umFEr55R0uXa3EmFIn6OjQZr8a5Q32NCNgXEJ4DeYIEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/mi0rYFQH7+37FCBieDUcO9QBZVqw+Q1snS907vw8ow=; b=Zb0v37uzNp7DOAMQZMyvsW487UneIi3yPTYxt5a+iTBJTS8Mm2rGny97khpbHvyxLXSkUJL/mLK/PJZzvrxt0Q9aKbMe4+06g1SzMxkksKjYyejbIhpWrnTcwnbuy9BsCechRyYBoOSMKbTMg6DQS2L6zU4yVfpGMBbkj1o8r2BICuYSLDJNCnwhxfdCGP8rKBtO4UGZfZaLi5VesyubFFhlkYphWNr7Z43ZlZgnJUtZVkxaqmFHRgvon4yo14px31yOtyLP8vtrF4bL8qIWhpG7FuoZH7JDsGdmsfZa60eqp3MM5tE9iPNNB7dKUWLVZrm5K8dTUYoypys/uEmOJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/mi0rYFQH7+37FCBieDUcO9QBZVqw+Q1snS907vw8ow=; b=LCmkkGPHTSZ9+3SZ2q4ekZ+dBBpqITWs40VGuErnX8LzlSiH0OixwZqLTlnx8T0n5quKZy+P/4sQnfodWnhI40i1t7o8Zht1Xh0LllbEezcP/dd2TxRPOXcJKmwvk7F1H0/s+JtkBebagAwmQi79vyA7BFWsEYaQeaZdwKVCIkQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 12:12:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Message-ID: References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> X-ClientProxiedBy: LO4P123CA0435.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::8) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5758:EE_ X-MS-Office365-Filtering-Correlation-Id: 7babf69e-4352-4220-091a-08db34f510a3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E+RlM9xKusNVh3+08goIXUsfNEYShHNiXXcyD/CZhizqcnsOjnCp011XuNmDWtjtReYjzBjaktwc3NcIxqTYKs9Au6bcCkzr4LS45gF/iFKFGK6uT3ZYJILizcnE1fcZUYZqTm4dHAapO/0JKRMUYkfnnb9i+EWKekNuvDJVQcM/BuI6+1HwHr0IPGI14qq3vQD7uOlzpEe4IK1tTWbr7xvyrVWG/solotKuF1k5hRItxvk6hTbGeSht4uSWmnV8uy4iC4I4S8SNHBfnh/bZvk6r/stHt3lqRm5bgCmxj6N+U390+5yNfE9DYZxUjdNbjXBF3E94s25jlufFOZd5oLGcLOm6yu4rzXbAQsDNFsz7V8SLXWIHUgP5xRZPOrVS1vjUBuL4IiOYlDXYzgnl5EXYGJO2YLGBn8+pH+y61mcyoi12sSdifcaHNCITQEHCLCLOZ/pgeFIna9VaAciNjPYCW3qx1Vuifmw54avpGdcEDZtORyNFuTOaGtKbdWVBcM8Xa25COP68ckztZweW20l5e0Xl5QqMpHtchPE6KYkBx3R7Bt1PfHHtLJBIe4IZ0gjQVfI0fPB3ScXzxu/lDK1NTRz7hb/fO+YLtsHbT6A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(376002)(39860400002)(136003)(396003)(346002)(366004)(451199021)(66899021)(186003)(33716001)(26005)(6666004)(2906002)(86362001)(8936002)(9686003)(5660300002)(83380400001)(478600001)(66476007)(66946007)(6512007)(6916009)(316002)(54906003)(6506007)(41300700001)(82960400001)(4326008)(85182001)(38100700002)(8676002)(6486002)(66556008)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXpUZUdRVCtoV3F0QzNRZE9meDBzaHk2WTYyNzJTUXBFYVBkOFFnUFpMMHRp?= =?utf-8?B?M1d2cUJabTJLdDZhY1Y0UXhCb2RwUUpYNGhqUC8xUkJpNlZUNzZ0b1czWi9O?= =?utf-8?B?cVkwUE1xRFZjUVN1cTd6VlJLUWIrOVYydDhHKzZvY0tiYXovTGVPRlNwVUkz?= =?utf-8?B?aGJmcFhyanMvTzhJMkcyOXFuaFBpYnpSV3QwRm5nZjFlTTdYeStQcmdKL3Ru?= =?utf-8?B?TUtHU1dHWEJaTmJtOFZzeGJQNmU5TzR3d09iRGFPTXVVcFM3TCtoTWNZZytn?= =?utf-8?B?L3VGU1g1d0thM1RpLzY3UDZid2FXcXFWZ2NjcENnSVZVUGpSaUZEVDFOR01l?= =?utf-8?B?Sy84dys2c04xQWxiY1lmV1kwVGJ2bFVCdThKSHFtZ1VWU05pSWgrOXF4K0Fz?= =?utf-8?B?U2g3Y2NOaUpZc2tHMSs2akJ2WkwraVkydjFKRTl3R1JYakJLYkRYT0FLSjNV?= =?utf-8?B?K0lUd1B2WlR2SVo0dzh0ZGhxbDFzT2ZHdnJWaWtxMDZYc0d0ekQvK214bEJQ?= =?utf-8?B?NFRDT2MwV1BJQWtaZ0lab2lKdzFEVCtNZVRLOFlYUlJ0SnduclFIL0hMZG9q?= =?utf-8?B?Qzc3STdzVVRuLzNOODh4bDl3T0ppbzhnRGxjbks3ZkYvdHRuSVI5MDNka1hJ?= =?utf-8?B?RG41c0E2TjJmajJYVnhjUUFFREc0a1ZHK2NvdlZPZWhmUThPY2VjQWVobll2?= =?utf-8?B?ckFqWXAycmFQNWxBaFcyWVVyN0srZVFrcG5ZaW5tK2VNVXpla0dWR21CL01U?= =?utf-8?B?Rzc5aDUwaHVHMGlqQ09nTHVZQXk1amFUeGZiVFNzY0k1U0RLTW5sUzQ2SVVZ?= =?utf-8?B?NmNHMVRWY1d4bGhlRTZBRmdnaWtSQzJRRHlmL2NFT095OC9EaWF5MkwvNUs5?= =?utf-8?B?TWMwakNGMmdRMDdETTA4UzhZYWhOcG8ySllEZmg2TUF6U1NNZU4ydzFBNGF3?= =?utf-8?B?K0ZtOW1iVFJoSVNOMnp3Y0k3bmxGWlJVaVRmYXZyNzM3NGtvTDlXWE1ValM1?= =?utf-8?B?YjBha0lreVlnZkVjdnpMNkZGSDlsclB6dlgxYkdBcVZVYk9WUDJSb1NabmRY?= =?utf-8?B?dVJ1ZkFzODVqYVdiMDdXOW1XNUdqUitxVkZCOEgwK2V2bHZSTDFQZnFHZVJF?= =?utf-8?B?c3MxRE4xQWZYMHIySGJySk9CbFU5RTZxQnRrbHZoWUVZVEpITzZsY1Y4QnZP?= =?utf-8?B?bVR5ZWMyYzhLTTFySEIvTEI3U2ZKQlFmTFJsRU15NWxrRU8rSWNmY01BUW1j?= =?utf-8?B?THppeUhLcFNJeldSTUJIOWduM1psSW9Jb0JaZmU1S3BZRzR2NHc5ZWhXUENF?= =?utf-8?B?Q3V1UExCWitCdTdFR0pwUFh1RmVPMUo5c3BuZ3FiRVhHQUVEaDBObytHQkNS?= =?utf-8?B?ZmNyVjF3OW1FTU5MNHdiWFo5OTVHd0JySUxCSkhkWmcwd3dnWmNFeHJ2aW4y?= =?utf-8?B?TmtuU2JLaGxYdXJDcnB3cHI1cVZxckcrSjBvb2NyeG5HaUtRc1FMRENWbXVw?= =?utf-8?B?SjNkcFBIUHIveHcyTWFRWU9XSzZ6NVpka3NaQ1grcWJiV1FiVnBRYmQxV1Bn?= =?utf-8?B?eU1mRDc4VXZxM21Oak15MlA0eTJiaXVLT0pUYXJYaWx5UFJPV2dtbkgvYzZw?= =?utf-8?B?N1V5dFFSdFBUMStCRDNFWG0zQnpJLzh4NlRJSjZKbWdSeXFiaEI1aDJTZ2xU?= =?utf-8?B?enVUell1Y1kzRythc2taMm1BQWVqMXR5eXM5dWtvWDU4dkNlWGprcTlGdEpZ?= =?utf-8?B?dFd3SUhiam4xU0Y5VzlsbkxBR1ZtVG84RUlhOG9tbHRKT3FRa3NLQ2JjZVV5?= =?utf-8?B?bDd4QjJ1VUZVcHVSYWhYb1Z6MXJ2dWthR3p2MWZNVTFnMTZMNTY0ZFpSTjJQ?= =?utf-8?B?OHQwYTJrWkEySmcrQmZIb0JJUkRqbmQyZVRYc0tLc2I1QXU3NEdHbHdYNjZk?= =?utf-8?B?bXBiN292Sys5Z0w3WFVhK0ZjVWJ5YXdCaFFJYmNFTUhXSGozakJjT1JCLzB5?= =?utf-8?B?MU5uV2ZydmR5KyticTU4NXpHZ2RzOThmNWdyRUMxeVJrK08yOG9Wbi92c1Yz?= =?utf-8?B?MHhER1JxbTlDUFBsV1lPcXM1cHFIbVVnUjlhTm1vMTg4SHZlc3ZMYUEyNks5?= =?utf-8?B?aXNMSkdJdVo0NmdaNC9udVpNbU81RmQxWTBCUGkxRTFpUmYzekRhaDZ0bDNr?= =?utf-8?B?dkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: q6FoNrjwNIEkhIWFJxjG+8HWe510D91Cjp9k59PsYFgz3lsV4YYepULB4KEUs452N+X2RcFQFaG14ZN/2M4VPPjOMhPCu05GVurrczlPKv/DjsPoTCw6zokwdtJhwsKyq1lXiDkRzFKhWnSAB1SlG4uwqTLBeBTIcNDxT+X/AqrjJjaITGucbGUJeu0SC1aMHT4TcwR+AUGc0du6hATEPawb+rBhhvoJXODM0Egv2bFOLDasPwHXOgcFqjZyjdop/mKqW8THVvBfhBHWkHx9W/LVN1t7es6n08GbVOVead+cElmBMn8fOetDY4jXdYjUatfwZljarbnwg3O8iRKt1GNDzrbPXZS8+6tzMreedztCCwr4wipDjtzeMc5R8sbDT/pvMBBXGZUf6HJ/lPgD7KNfUBodcPGOCKK75Zv6WDJFlwQY0+F1DGVjlXv7h93ZbX8d0i/MGUMxdCFhANSELomz2Advh+MKLmDHycgS7AiV6iTmesUI1jQ5BD9yMGB2FO4VS0VvzLYPHEmorkMWu+xSY33k1sKahiJtq+ZofLvJflR1fOKiBxAdIzIm4nKO4DO5s/5R0r4B0+cOHCWjKrwgRTWX9GB0/YQbMOZ0krU4l2qwFH6fXoq8YSp47UUNz4E83uqt2v8OZhU+hF18LL6xzKzCQx3YPLPO9xoyqgM2WcYTzXa95Zbg5ygboj3ElbvbYGKGqpY0NQ5DnhmbvW47liVTazH73PHqbFbNIZAEBVmKcO2pmJ/nLu9hHHmd191iH7f041lUOlbfp4ZZG0TiXnizW/ryr6fMP8LNq8VUXVqnoID2gcP9fXKMuUdE X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7babf69e-4352-4220-091a-08db34f510a3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:12:15.6654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VskyNUKOAj7TYbTydjRfeNgcmcuZo8vBy1gpw3DTXdJL4lEkaMgr0gcsTGGk6D7LirKXy8LubR4XfmA5L+f0wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5758 On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: > While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still > applies to guests also when run on a 64-bit hypervisor: The "extended > CR3" format has to be used there as well, to fit the address in the only > 32-bit wide register there. As a result it was a mistake that the check > was never enabled for that case, and was then mistakenly deleted in the > course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume > CONFIG_PAGING_LEVELS==4"]). > > Similarly during Dom0 construction kernel awareness needs to be taken > into account, and respective code was again mistakenly never enabled for > 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by > 5d1181a5ea5e ["xen: Remove x86_32 build target"]). > > At the same time restrict enabling of the assist for Dom0 to just the > 32-bit case. Furthermore there's no need for an atomic update there. > > Signed-off-by: Jan Beulich > --- > I was uncertain whether to add a check to the CR3 guest read path, > raising e.g. #GP(0) when the value read wouldn't fit but also may not > be converted to "extended" format (overflow is possible there in > principle because of the control tools "slack" in promote_l3_table()). > > In that context I was puzzled to find no check on the CR3 guest write > path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any > of the low reserved ones) could observe anomalous behavior rather than > plain failure. > > As to a Fixes: tag - it's pretty unclear which of the many original > 32-on-64 changes to blame. I don't think the two cited commits should > be referenced there, as they didn't break anything that wasn't already > broken. > > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ > unsigned int partial_flags = page->partial_flags; > l3_pgentry_t l3e = l3e_empty(); > > + /* > + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not > + * understand the weird 'extended cr3' format for dealing with high-order > + * address bits. We cut some slack for control tools (before vcpu0 is > + * initialised). Don't we then need some check in the vCPU init path to assure that the cr3 is < 32bits if we allow those to initially be set? Or will the initialization unconditionally overwrite any previous cr3 value? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:16:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:16:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517802.803639 (Exim 4.92) (envelope-from ) id 1pjdiI-0001Ik-DR; Tue, 04 Apr 2023 10:16:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517802.803639; Tue, 04 Apr 2023 10:16:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdiI-0001Id-A6; Tue, 04 Apr 2023 10:16:30 +0000 Received: by outflank-mailman (input) for mailman id 517802; Tue, 04 Apr 2023 10:16:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdiH-0001IT-3v; Tue, 04 Apr 2023 10:16:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdiG-0007rv-T3; Tue, 04 Apr 2023 10:16:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdiG-0004X2-FX; Tue, 04 Apr 2023 10:16:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjdiG-0004ZC-F7; Tue, 04 Apr 2023 10:16:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HKzArlN5QH0A1KTS3kZmDBsTTF+uGBcxCr2nRB7swiY=; b=x+lSi87K4rpG8lS0W2fjNVapOH N/yDRih2lRPCV6K5BG6K1vKXL6FlMJCP9Ly+AHBH8JrxnOEhiwwGbrpU2EGzdHDA1QRHw1KtqvOQZ 20mbMxWh9tA5FNwzLrikvUJ9GMJe1vKtWGom5guPpsywlnvmbcC0k88jrEYshNcCWYfQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180131: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=148341f0a2f53b5e8808d093333d85170586a15d X-Osstest-Versions-That: linux=7e364e56293bb98cae1b55fd835f5991c4e96e7d From: osstest service owner Date: Tue, 04 Apr 2023 10:16:28 +0000 flight 180131 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180131/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail in 180130 REGR. vs. 180116 Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 17 guest-localmigrate fail in 180130 pass in 180131 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail in 180130 pass in 180131 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail pass in 180130 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 180130 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 180130 n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180116 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180116 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180116 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180116 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180116 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 148341f0a2f53b5e8808d093333d85170586a15d baseline version: linux 7e364e56293bb98cae1b55fd835f5991c4e96e7d Last test of basis 180116 2023-04-03 02:26:51 Z 1 days Testing same since 180130 2023-04-03 17:12:08 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Brauner Linus Torvalds Michael Kelley Mohammed Gamal Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 148341f0a2f53b5e8808d093333d85170586a15d Merge: 2d72ab2449fa cb2239c198ad Author: Linus Torvalds Date: Mon Apr 3 09:41:24 2023 -0700 Merge tag 'vfs.misc.fixes.v6.3-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping Pull vfs fix from Christian Brauner: "When a mount or mount tree is made shared the vfs allocates new peer group ids for all mounts that have no peer group id set. Only mounts that aren't marked with MNT_SHARED are relevant here as MNT_SHARED indicates that the mount has fully transitioned to a shared mount. The peer group id handling is done with namespace lock held. On failure, the peer group id settings of mounts for which a new peer group id was allocated need to be reverted and the allocated peer group id freed. The cleanup_group_ids() helper can identify the mounts to cleanup by checking whether a given mount has a peer group id set but isn't marked MNT_SHARED. The deallocation always needs to happen with namespace lock held to protect against concurrent modifications of the propagation settings. This fixes the one place where the namespace lock was dropped before calling cleanup_group_ids()" * tag 'vfs.misc.fixes.v6.3-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping: fs: drop peer group ids under namespace lock commit 2d72ab2449fa9fce8f6898fd5adda10497f7c111 Merge: 7e364e56293b f8acb24aaf89 Author: Linus Torvalds Date: Mon Apr 3 09:34:08 2023 -0700 Merge tag 'hyperv-fixes-signed-20230402' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux Pull hyperv fixes from Wei Liu: - Fix a bug in channel allocation for VMbus (Mohammed Gamal) - Do not allow root partition functionality in CVM (Michael Kelley) * tag 'hyperv-fixes-signed-20230402' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux: x86/hyperv: Block root partition functionality in a Confidential VM Drivers: vmbus: Check for channel allocation before looking up relids commit cb2239c198ad9fbd5aced22cf93e45562da781eb Author: Christian Brauner Date: Thu Mar 30 09:13:16 2023 +0200 fs: drop peer group ids under namespace lock When cleaning up peer group ids in the failure path we need to make sure to hold on to the namespace lock. Otherwise another thread might just turn the mount from a shared into a non-shared mount concurrently. Link: https://lore.kernel.org/lkml/00000000000088694505f8132d77@google.com Fixes: 2a1867219c7b ("fs: add mount_setattr()") Reported-by: syzbot+8ac3859139c685c4f597@syzkaller.appspotmail.com Cc: stable@vger.kernel.org # 5.12+ Message-Id: <20230330-vfs-mount_setattr-propagation-fix-v1-1-37548d91533b@kernel.org> Signed-off-by: Christian Brauner commit f8acb24aaf89fc46cd953229462ea8abe31b395f Author: Michael Kelley Date: Wed Mar 15 08:34:13 2023 -0700 x86/hyperv: Block root partition functionality in a Confidential VM Hyper-V should never specify a VM that is a Confidential VM and also running in the root partition. Nonetheless, explicitly block such a combination to guard against a compromised Hyper-V maliciously trying to exploit root partition functionality in a Confidential VM to expose Confidential VM secrets. No known bug is being fixed, but the attack surface for Confidential VMs on Hyper-V is reduced. Signed-off-by: Michael Kelley Link: https://lore.kernel.org/r/1678894453-95392-1-git-send-email-mikelley@microsoft.com Signed-off-by: Wei Liu commit 1eb65c8687316c65140b48fad27133d583178e15 Author: Mohammed Gamal Date: Fri Feb 17 22:44:11 2023 +0200 Drivers: vmbus: Check for channel allocation before looking up relids relid2channel() assumes vmbus channel array to be allocated when called. However, in cases such as kdump/kexec, not all relids will be reset by the host. When the second kernel boots and if the guest receives a vmbus interrupt during vmbus driver initialization before vmbus_connect() is called, before it finishes, or if it fails, the vmbus interrupt service routine is called which in turn calls relid2channel() and can cause a null pointer dereference. Print a warning and error out in relid2channel() for a channel id that's invalid in the second kernel. Fixes: 8b6a877c060e ("Drivers: hv: vmbus: Replace the per-CPU channel lists with a global array of channels") Signed-off-by: Mohammed Gamal Reviewed-by: Dexuan Cui Link: https://lore.kernel.org/r/20230217204411.212709-1-mgamal@redhat.com Signed-off-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:31:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:31:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517808.803651 (Exim 4.92) (envelope-from ) id 1pjdwx-0003hZ-SR; Tue, 04 Apr 2023 10:31:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517808.803651; Tue, 04 Apr 2023 10:31:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdwx-0003hS-NT; Tue, 04 Apr 2023 10:31:39 +0000 Received: by outflank-mailman (input) for mailman id 517808; Tue, 04 Apr 2023 10:31:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdww-0003hM-LU for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:31:38 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on062e.outbound.protection.outlook.com [2a01:111:f400:fe1e::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfa9873c-d2d3-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 12:31:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 10:31:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:31:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfa9873c-d2d3-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPs6cxSRpxJ0evezqtVW3GhqqpF9JGlPRnTVvwbE5C1EmYgJfz51qB0WNAF2D/ztlv6pHuNsdxxoRmwvILwIoJFG1TtOXtrnQqrS7k5Vnvv9JhPTqvVhUsNm/3yngqifFXEbCowGYFJJvkhLpiHj71/8TFasf//gC8sh7FnFwecicQ7qGYKk0CbVJleLbgCdxizgYr/tq9/QL+NtfLXsJRR7XpVjl0u3iHsqVAy6nNzg1pKDrP6DAj35qBAMaAnOjxemCAzoDYn+Bo3fnGeUEOkVOiJ6VEoXdXFUTPDc8eXX0laobm8uT8LsdkTXGUXvECUqiUzCGJcPXL0864C9Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SK5yEcXmvmF9LNfOBdI39ph6figLkQWOz0P31QY8dBg=; b=odvfKTC28lKLHP5xiLycaN/exVvFShAjRlrNj5mQBB6hKk5a5lY24Bd7iJm2l4PNELNE4StN1AlQ8HuY/iJZdZGBUyW8w/lOMEln7ENs08eDpZvXZFWNjf+6aZC/zgAtfzH0e9Q3N8SrQQWbIOJjfZ/P6j8Eb1bJgk8ONmXorArF4b/+eKuAiPwt1bX0N6EmCYdR11SJ79NHH5CiWJtDt03QvPzjn7279v7ylkzKeh0+9LH3OTKV+fva//Qs6l298BKnO8RdCXpCax10kMCzTqyU6MhJ5plYZ3+MVHsyQd6MpLGJ9r6lAA/ADkRiRcmpZDwoz3LUmO0i8z1SjdkeVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SK5yEcXmvmF9LNfOBdI39ph6figLkQWOz0P31QY8dBg=; b=wGgAHSVk/JYQwMgEp3Ix/GB4DLlV1TpQWU7B3HsrW81olMSQxHLEH4ONWg12QnDRRcYGm8YnABebysymwl9c7CCNvvm+nIBPL2Y00jjgNkUDMB3F5klgzLf8YxirANpADwtm7OH0y6NB+oct3uwzPbuwQs49ATgw0WDjsFYaHal7pWZ4uwyayu+0SNlD51fclYs3g8RYjmbDPvLCgXTN0r/0veXauoOhHW5xkYPWHgOaIITptJUdqCXyIRudNlzcdlTHcfwzYdGZ/6C6aUv438mg8nM850mHIdi0xTEhXipgi5RSCkSWO7n8RAx0Smz2+BsXQXneizDIirZn9/WVkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> Date: Tue, 4 Apr 2023 12:31:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8788:EE_ X-MS-Office365-Filtering-Correlation-Id: 98b9e487-f8fa-4488-56f5-08db34f7c2c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tS5fpPz/AxFt8LgcxRun1J4alZjrGRctKpx3efuBKBxvI71aAMP/NUlCIRQcYufUMh1rkgzXq1rsuxhbgND94FpuPkx85Xm6XJBs6uRvAeJ3BLnvA7jG0xWPSlIxDOToETLChN3QCD8kDOFQLhI/mr/csGkegnF4eTkpUF/Qy99P5Fk87OAGCym+4wcDYaMvLFnaHUsa9Y1WtncYjfakc0ng5UQI3cJnxmZ8Qp58iYqNWrMpSlZulhTCX9RqSlcxe1Jhv6hsn0Xz2huLeSsxA0yPGJdfDNKfvQzEdzYm/cotFWQapg4S/fa9LcnfKXttHERLF2mEEX3KBppLXXYUPNZgH1/yuanUPqIGrC96FMAMiFOQNjaJTEBvXcxkHrR7rd9W5BDKA90oAvh5huS43X8qUciaiPceQ9+392/wLuhB/sgQoXXqG4YX2cy2WlVIEC3+r8jXfpz6i5Drkn41ty0XYi8l/e2EnVa/2P5+ar1T7CT65I4F5nL1Ti2bwdA8HouK9AOQnM3aYdMPTPP6tHuXrJfiL6w1G+DGaWmIHW7rjvy36rHVa9ZlDTIgzIEeUXlb/R7SkdK6T9ht1j64yFR3zBhIakMOC6Rs1EQYHJ4a0j97Oyn3kcz0OUFK2fshPwhGYjB5jPSg9nMYjjgoZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199021)(66946007)(31686004)(478600001)(6512007)(6506007)(26005)(66556008)(41300700001)(6916009)(6486002)(2616005)(66476007)(4326008)(53546011)(54906003)(316002)(186003)(66899021)(5660300002)(83380400001)(8936002)(8676002)(2906002)(38100700002)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a29TWWw0eHdESHRBZUUvODBBZEM0WlkyVzRQUTkrbGFQclpIcWt0NzNEMHpt?= =?utf-8?B?L1BISGxsalZZcUs2KzFxSFZvekdiUTEva0poTU8yb2VXSG1iR1dvamFTQS82?= =?utf-8?B?aEdKZFR2U3V2a1d0YXBHZ2lRZXBZeVRvVThGbEpnTTk2dERLTG1BK0JWTjc5?= =?utf-8?B?dDFFbmpySko1amwvL2NlYWNLelJnRjNCbVVWd0MzcnR4a3pGYXh3eWRiVXR3?= =?utf-8?B?OHFER3RHeXhabkgwMzNBZjZ0ZGxyeS9XMXIzMEJmYnk5K0w1ZGdGeXVCd3NZ?= =?utf-8?B?V1VCZ2ZUSGdBcHJpMFhmMUpNcUg5K0ZXQlRpeTQ2dkFHZnhrWVYxN1BicFgx?= =?utf-8?B?Qm9CZVRCZHNGY0JUVXE5WUJoZXBUWnN4MVFJTFlWVVJPd3FLVW03OTFjcWU3?= =?utf-8?B?akh6V3FMandnbUFsVk9Qd29URjZGcVByaFoxeWN0WDllU2FXbzZtSlMrN3hH?= =?utf-8?B?NStIYVVINFBuZXBkdkpheXVxV1FTbWh2UlhiVGk1bVRPWHZwK1h0VW16NVFN?= =?utf-8?B?OUFOWjBLUFlEOThQdktZSnY5Wk9GLzNyMDFGOGUzWEhReisrRWNnUGpaY2N5?= =?utf-8?B?bmJMMFNGcFo5UWh2d1VidGw5K21peTlkcUkyQmF0bjQ2UERDRkpRcTBuZkhP?= =?utf-8?B?VGRMdXBzYTdoNTROL25hZlVORExwaXVCRmtZMkRoclpQZHlLU2ZwMjljUmx2?= =?utf-8?B?SWpxY1JyQSt2Rk0xUGM3RmlNRDIwM3dhUzNUZDN2OHRMTUpJTWtzcjc5cFBD?= =?utf-8?B?SDd3TTlJSkNzbFI4enFqUmhFUlpsb0hIOHpqZzVZQlNvK0t1bzB4WGpMVEgr?= =?utf-8?B?OXVBVlBVZDVVZm45cERha0FFcmxxTmIwdGFJQWtmQ1RSRHVzbVFUWEd5TVV0?= =?utf-8?B?SXBGaGNLaDJEbDNJdmtqVlloZzBmckJrVHp0RXAyNFJkb3hTUkNtMzdkSDF6?= =?utf-8?B?NGFiZWJRZFI5M2tUeFRySkk1aWZjTkVBOU9wbVVXSFFoVDdaQVczaFhDRnFv?= =?utf-8?B?OSsrNytoRGkrVFNNSk40UlE2dlhvN1I4SWl2WFJxN0tkaFNsQ1RYY2JWMDJ6?= =?utf-8?B?U0oySFNtTmFwVlE1RFdBR0xsWWxSWS9Ibm14MHZIbW9QeVpkRlF3NFllWmpC?= =?utf-8?B?cndHQkY5eHUvUExSMHkzdTIwKzlPY0dRcTdBRDhnVXBqdlVYOXppeFJ3NDlT?= =?utf-8?B?TDR2MlZLdjR5akJHYXZMTkR4QTZuREJ6MDErZ3NjNGxrbDdISkRJeGRnUDNJ?= =?utf-8?B?TjBhZmNycCtIQ0NKTmNhV1ZDN0laNUtJcERUNFhiZ04zTUZLSTd6N3V0M0FH?= =?utf-8?B?RnYzZ0NUSlBmcm5scVVrY2VjQnB6QTUzODVZc2d6MGp3RjcyWU92ZFFtVElZ?= =?utf-8?B?Si9RRm9rZSs0anJPN0NhSDVqZWV0ZEZUNjN5a1Jod0FMc0RBa0pueWZxYUJy?= =?utf-8?B?VFo1NDRIcFFuSG1pNUJ1MnpFMW1WSVRWWlFYb2RLUnRUWnVoSUNvRWJjWXV3?= =?utf-8?B?ZjdEU0pRQUhrVFBSbGtMaWFXNkJBdGUxZHhUMHM4enVFQmJvZEtVZGFaYXVa?= =?utf-8?B?KyswclVDVUR0YmtWMTRsMksreDJkaVlYVnBsZkVUL1BYUWU0VW45M2lKeWJC?= =?utf-8?B?cjdPU1RyS25MSVJzNU5jb3pEL09FcVFFQW4wWlUzaHB6Y1lJTzAyeWhOaVNp?= =?utf-8?B?TmNIRDlnbVNKbG1HOGxZRGxRdHQzOG1ZMlJiV3gzTW0rNDZTSVltYjZuaXJa?= =?utf-8?B?S1hRNjlpa0lMcEhUR2JTTUhrUlRVSndXYUVHQmUyTk5IbnJ4TVlkVTVMNGxI?= =?utf-8?B?NFJDMEtGaVpJOGkvVGdQcTVxQTVkb0owckk3Sk0xRzBMR1owelNkN0dPSXMv?= =?utf-8?B?S21YZE1YTjlpTWpnM1phWDloQnJueGtxV0M1cVNNVFd1MFdRenNEcFVtTCtr?= =?utf-8?B?WGhkR1JnNUlKWWNnNlFiWkNyNjlZTWhXTTJHTDRTMzVQek1hQThseTFwOFFm?= =?utf-8?B?RjJ1UERRbUhSM2VuckV1UUU0eHNNUXBIeklpSmtMbXlCd2xYSXRlbzFLcGFQ?= =?utf-8?B?RkU4MTFvQjFOaVh3RDI4amllcmZnVDVoS1BWZE9LUzQwZzJiNkN1dkNOU1du?= =?utf-8?Q?bYlQv6f93bZe7IvZXXjfgpOjm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98b9e487-f8fa-4488-56f5-08db34f7c2c9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:31:33.4765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XJO4R/GTiOt8Qw9jsVRL5bbQeiVFCrBy9TfaLmwX6/hVsqsTKTaDBuKNuQofuGaNIDxIzzzwOAtCrDb33jdhJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8788 On 04.04.2023 12:12, Roger Pau Monné wrote: > On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: >> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still >> applies to guests also when run on a 64-bit hypervisor: The "extended >> CR3" format has to be used there as well, to fit the address in the only >> 32-bit wide register there. As a result it was a mistake that the check >> was never enabled for that case, and was then mistakenly deleted in the >> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume >> CONFIG_PAGING_LEVELS==4"]). >> >> Similarly during Dom0 construction kernel awareness needs to be taken >> into account, and respective code was again mistakenly never enabled for >> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by >> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). >> >> At the same time restrict enabling of the assist for Dom0 to just the >> 32-bit case. Furthermore there's no need for an atomic update there. >> >> Signed-off-by: Jan Beulich >> --- >> I was uncertain whether to add a check to the CR3 guest read path, >> raising e.g. #GP(0) when the value read wouldn't fit but also may not >> be converted to "extended" format (overflow is possible there in >> principle because of the control tools "slack" in promote_l3_table()). >> >> In that context I was puzzled to find no check on the CR3 guest write >> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any >> of the low reserved ones) could observe anomalous behavior rather than >> plain failure. >> >> As to a Fixes: tag - it's pretty unclear which of the many original >> 32-on-64 changes to blame. I don't think the two cited commits should >> be referenced there, as they didn't break anything that wasn't already >> broken. >> >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ >> unsigned int partial_flags = page->partial_flags; >> l3_pgentry_t l3e = l3e_empty(); >> >> + /* >> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not >> + * understand the weird 'extended cr3' format for dealing with high-order >> + * address bits. We cut some slack for control tools (before vcpu0 is >> + * initialised). > > Don't we then need some check in the vCPU init path to assure that the > cr3 is < 32bits if we allow those to initially be set? > > Or will the initialization unconditionally overwrite any previous cr3 > value? That's not the way I understand this "cut some slack". Instead I read it to be meant to cover for the VM-assist bit not being set, yet. Beyond that it is assumed to be tool stack's responsibility to constrain addresses suitably. If it doesn't, it'll simply break the guest. (There is some guessing on my part involved here, as the original introduction of that code didn't further explain things.) Nevertheless going beyond what was there originally might be desirable. Yet it's not really clear to me when / how to carry out such further checking. For example I don't fancy walking all of the domain's pages when it's about to be unpaused for the first time. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:34:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517811.803659 (Exim 4.92) (envelope-from ) id 1pjdzZ-0004Fp-7h; Tue, 04 Apr 2023 10:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517811.803659; Tue, 04 Apr 2023 10:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdzZ-0004Fi-4e; Tue, 04 Apr 2023 10:34:21 +0000 Received: by outflank-mailman (input) for mailman id 517811; Tue, 04 Apr 2023 10:34:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjdzX-0004Fc-PX for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:34:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4008d808-d2d4-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 12:34:18 +0200 (CEST) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 06:34:14 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB7152.namprd03.prod.outlook.com (2603:10b6:a03:4d5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 10:34:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:34:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4008d808-d2d4-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680604458; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Z2Wc7JsRF9HraoVD2sOHIDwXVyvrEyRv6dD3C/bsKWc=; b=Qcnom77GNv107goEZSn28eN5UKY6vt7jB3gfddXUYl/Jm17iXk2evY0t DCQQqJTnx0+WX+rlnPGwfBaO7/OF+bTSa8DThztSrhFFECVCfkJTqffb0 Nqt/d5dSa7cT7s+l6fCdnR2ZC3qE90+TxWAUtGwY95R/HLALHt9Jvufau U=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 104166344 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FHiTMqjcwEtLIImMS//a+f8uX1614xEKZh0ujC45NGQN5FlHY01je htvXWnSOKyLZDH0KNh+bo619U8OvJ7Qx9ViHgNurCBmFy4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQEFiorTi+It9uwmpuDVPJ3huB7Bc70adZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGybLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXkr6A02wHProAVIDg/WkXrrseTsFenC4NeJ Xwa5wAAobdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8ry62OCUTBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDc6r6Uei4gMzarT1VrKmS62r57FCAs8/BzKX3mN5xl8IoWiYuSA91/f6vpRKZeDeVOIt nMEhsu24fgHCNeGkynlfQkWNLSg5vLAOjuMh1dqRsMl7270pCLlep1M6jZjIksvKtwDZTLif E7Uv0VW+YNXO3ypK6RwZupdFvgX8EQpLvy9Pti8UzaESsEZmNOvlM22WXOt4g== IronPort-HdrOrdr: A9a23:S5DihqBl3tUle2DlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104166344" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j/l62gojXGd1eAiq9ylUwiU2Zhu7qtUCLDHvZNeQAW82Zw8efMJzaVJ5OmdvVz/7PBoP2XHg7GWUTJ/EZgFBoO5XoyvMdxS0FgvpmThWhFAoYGnRb+e4EprW2sQml1w2JIodzGZQiTpV4vJ7yId4nIFl3On/a1IsuLZP3hUyTrit5wYasz0xb6pDtYl4w8JdXE8d8OjzBG1u7zyxahhjIDup5Y395fmS9aLVUXQTMCas8mfGRRxFp68LGriLETNK2DF9ESF1hZE1edTYJAm2rfTqvTxcBBxpQki7PAZg02V3A0s8FxddaIbBvG3HDsbJwrTljpHwXa/1wHrQnCNBog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XksOnesjBMGLFJg6HigPvb/LKfQp1MR2TWqNugXsJlo=; b=ULbfhGkchc5+zdXVg12PDH25wKV+MJ1dSJQ7vhk1rds0i5nxYQvQeSv0XnvlB+8GZMTe1kB1V2vKWRBTWdKNYNIn74/XRSgjRlShe6l0j1YDFBd9BBDQoZcmetQRRynqh2YIJvAZan1cqxXh2waPASNdDW4BPSjV6q7nR8WztcQShGBDV19AyEFLmvrlQY9DDoQ3tSNMEJb1IsWH9qpXSTbJbv2IIFTRSbOPKI7voIrGtic6BHCxOqYe8scjWETJO7WUm/phE5BvBAkD4TMXBJtnx0J3KdKbty5NtOKnzSn3TwtTZGdIgbMk9eLn17GT5jEJA90O4G/pu5qsjg3C3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XksOnesjBMGLFJg6HigPvb/LKfQp1MR2TWqNugXsJlo=; b=Lf/+hqYuoIO+5Fq88iV8VZ+VHJHxyp+keBQroAmM9UNZZ6GQI8oGdfZ4yJ1zW3Vy+UNWPgdYz1b8Vt12ZNBdL+edQ7wo2wGY9XuSnnlySCQKPgsdu763SFrzY7QFXpRmFciTxTCfvOgnhtD1aOmm7kxt8iK47VdgXd8XiSb1rlQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6c5cdffa-f3fb-8f40-c44f-ad7431451929@citrix.com> Date: Tue, 4 Apr 2023 11:34:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk References: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> In-Reply-To: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0487.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB7152:EE_ X-MS-Office365-Filtering-Correlation-Id: 458fd087-1ea6-434f-a4ba-08db34f8207f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F1QKM5MZrDkhU5DpVh/Mw52NTOEOCmgK23txuc6CBKTEuy0i+V4SKL6HVjHCgN65cAQ8nLMIimn760P8KXStPNX21JO0MPnutMwVtel7rDcCN955nyTncSRhxO1r635wy0CIZf3I2ki4jme1H/8y/4pUK0hEDnJd/zH3Xn1lWHFbPbtw7LD0n4ZzsPz9GIMFiOLw4rGC0s7jUZbK4UPQmrj0XW8dIeWqgkbQlHYVtwz3w9tmfSkwvLgKyiIDEtcPTtUYJq4v8lFsyQUGxtwJP6znJ+s+DfrpwZCTeRJm76p4QJkqme60agbXRY/Fn1ieqHAzLv/4Ev7po0ld2XLxZOM/QyZi+hRCM8SK/XVIctWunLwxFiM38yqW9YhzBKXoZzvsWs1CwN9e85WtpTbKR9ay7rXPftenGqWpNwmUfbsAybX1c2sitaKnATMAcUX3tffG+29+m+4aO7+b0cLLX2FZXtfRAhpsKVH8XHRk+c4a3QtzaGHnKwwXG3B+M28v0Pkb7NvrLXgkALYi+O0eeT8bgVoep9cKeINb4eBPQ494r3WQfk9rJZB3MwOejE43ovoJwXuGou/Owx7i9Nbyp0HB84HA5MUrfqvVivGXJXNIA4dUdsyFh1HL0Tag8IwJPRckOFZwEw9/LROL7kxPWA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(451199021)(5660300002)(8676002)(41300700001)(110136005)(2906002)(8936002)(31686004)(66476007)(54906003)(66946007)(66556008)(4326008)(478600001)(316002)(6666004)(6486002)(83380400001)(53546011)(36756003)(6512007)(6506007)(26005)(82960400001)(2616005)(186003)(86362001)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEtUbDQwdlcyTGdTcHFBRjZsWGxzNSt5MzNyRkRTcWR0NGhFWnZlRVBSbnFO?= =?utf-8?B?cVFRT1RwbS9PWlNaT0lhanhOM29VTlNNc1RtVVZmQ2JadE1nbzhVTUFFeE9k?= =?utf-8?B?bVNDSEVUN2o5UDI0VEQya0hFUzhQZmJYaVJUUUdiRWh2SnBKaFBFeUVpdFBp?= =?utf-8?B?QzFSSFZVaWsyRXlpYWNLSGdBZWM3SnV0Z094T1JuUWN0UWY4Y2pHbkNQZjRP?= =?utf-8?B?Sk5DMFozY0ZZNWhOVHl1V0M5SnVzSFZTRWRlajZJUURPd1MrbGZwZkhSMHo2?= =?utf-8?B?YVZXbTdRTE9adlJUVU5VSmxXNEc3dHRBdElLTlNlZW5Zb3dFRGR5R2Q2Qk1M?= =?utf-8?B?U1pNbnBoUVlvNlZWVi8yaTJmREtpYVlIb01UQ251WWp6bWphMkRURUxaTVl3?= =?utf-8?B?WEM4Q1BtZW9pdVFiVzlJV1NJcHUzZ0tDaXg3bm5NcGJacEtjV3pHbnRwZy9n?= =?utf-8?B?RHZqUVl6a3B1cWpUeEUzQjNiV0N2UkQzVVg0OFE4czNxRXZ0cEw2RUJ6Zm1x?= =?utf-8?B?RGJ3VERYajB4dDhadDBUdDJ5dFZaU3dRRHoyQ0dtSmg5TGFVZERhNTFBcWww?= =?utf-8?B?MHFUR3ZVSWN5N2l5MjdraTJwY0F4STNNaXAwZ1RqTUpsT0JFYjJDSzhQUXpo?= =?utf-8?B?Z3hDRmV5OTZHUXpWejlXRVpyL1FNZEtFUVM5UE5TK0l1QnprbWdKcjMzSG01?= =?utf-8?B?K0ZMeUFpcHJZMjV0ZERnbUcwOUJsMjR1ZkdYaWF4RjY1WWtUZkRrREtSeXlp?= =?utf-8?B?UGUvMFN3NjVHQkNKeDNqV0tNR1BKZWpIazlKb0JySmdPd2xhbnJrbzBQcjRU?= =?utf-8?B?eWRvRUdHcStnOU5sd3RCSDcySkc4K0owN3ZucWdUb1J0ZENCalh0aWJzM3N0?= =?utf-8?B?MGdDSnJVYUYxeE5oa2V1WHpIYi9rR0p4NGxydHVQMC8zdERuRXdiWUpicmp5?= =?utf-8?B?Y1hFVVFoR2g4Y1U2Q01ZOEdrcUQ3b2JuZjhuZHM0aFI1ay9laXdPK1V0c2pO?= =?utf-8?B?bDU4ZVNhcWFncStVdXdwS0ZlZW5TcjZsOE9nbnRoYm1pak1DUy9TQ1EwTTl2?= =?utf-8?B?c1RSWFREdjgweGI4NExUdzNKTkFiQXFuUU1MeHJBWXZ5NUlaTmM5WVNXWk9T?= =?utf-8?B?MU9XM3F3dG0xU0FtVDBFUzBxaW16bDFhVU9nVFlSRnY2c0R3di9Kck9SbHo4?= =?utf-8?B?S2UvVGFqWVE5QVh2dlFna0dFNkpJSzR4WHpuc1hzRjBKREdtRXpZRmUrQlFt?= =?utf-8?B?SkIwT3dadjJCRGFUMCtETFoxZWxmQmlIRU52Q0pQa3RiZUszOVhJNy9FSk1z?= =?utf-8?B?ckVDQWs0T05GakFKU1BPQ2QrQTlRSGF5YUVFSG5rMytpeEhoQXFMR0tkL0li?= =?utf-8?B?T3ZQNGNHT09YdzRnMUhXTzhhQktSS2RwOGxYenFGRUJwU3NVenpCOEdjUzBh?= =?utf-8?B?WHVBaXR2a1BhZDlhZktsVUlOU2hGVy85cEdFRXFFY1VYWk5ZR0dNdk12bW9S?= =?utf-8?B?UFRhTFZYQkQ0cHdhM05jdm5adUJZN0ZzMUE4ekRicE0zcHFkNUZCeExTR1do?= =?utf-8?B?SklHczFsNEtuc1p4c3lYQzcwY0NUSVNQN3lkbmt0T2JZN1dlQnRlTnB1akVl?= =?utf-8?B?ZEhKcEIyVFE1QUlwUWp2R0I0aS9RQ3laOFpTV0xpL2JDL0x1WXhkck1yYjRj?= =?utf-8?B?Z3IwQU5IK3VGQkNWeGp4Ym4xaTdOdHV0QklhSFZISThjMGV5ZGhwalhhaTZ4?= =?utf-8?B?bjZxOGtkNElReml5TGx1aFZrS2JnR1hVS0NYR0dqTlEzNVZqbEl3RmQvc1hh?= =?utf-8?B?SlJkbTBxSHlBZjBOSmltdGlLN3JXV2pFNGw0Y3hUUGZVZGxKaTJwdW5PVzB5?= =?utf-8?B?eVBjUDM3YVUzekJ6WjhrZk5YUXhUZ24za1BTaDdrZS9JdmxVV0RNV1JWUTFT?= =?utf-8?B?M1BVc1kyY1Y2bkczeDlvQ2ljek5pb3ZDM1FXb3h2Q3F4NmxPUkVpc3BpaWps?= =?utf-8?B?NDNxQjU3YVNTWkJnbGhVVU5hUU9Id0FLdHRacVc0UURHMG9qdTRJaldKdTBV?= =?utf-8?B?NjZzd0RZNnkyV1NCUXZUTThNelMzSkV0QThLWW5mbGc2VUU4UktrVTlDTE5v?= =?utf-8?B?NGxWMWNSeWxha2pmMlA2dWhmeThQVVI4R3A2d25xVGhMT3M2N3FDN1B6VExE?= =?utf-8?B?M1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LKESl4Hy3Ni+YXuxlH3+PQ80Hsv7uQx3iXwHmAm9ZQZQ0cAEvBHQyZ+KBZrFgJ4dndqPjjkW220a3XJlsNeIejg37wOwnZSDWvt2Kn/5Bdt2QIvzQPBg91vSmVZG78P4i0aMDIzV1WR6QKZwhe0kEO2IvXReCbOJ7kjguHI6miJiDEnsKNGThNaaUUdE1Wg3LCRCiIsULBrA/PawDdtZNnWpgjrjjZuybb9nuCwze2UTXBqvoKW7gFaaY1RuUUyq1uWZBL2CMzgb8wX+dmzebF8ACoAVdXkqp7M3aLciXuaXYH7zTUU38TC9yWYvIIbqZhkqFK3IjPdwYRoagyouCft4HHXbqN7FfmZ8A02LGvsouzlOHz92TNt49f8m3X3R6r4b92fxt2Y6ROfPrQ4Lp5EDtWqwuTF3c0TGUax+I+UcewOVSCmT2Dre3CGS8XnUkCTSIqozkAoDYCAMv6mCv2XENs1sXg2/Uu3amL0NRZMWC6YFIzuwhEQIbM7FihcF8lncHgak6PQLEXhb4NrHNUMwjNmp65zFxptyf5dJpGQ9h+N1hcIYgUIMd9tGgs0cu7QboMqbL3AMVk3nN/zSQOlS1wxezlEmrDunli22unKAglXMIPPsoCtOgTGmRt4qUvsAqylgMWp8adrQd/kZSEhPMHcI/1DT7fXVNjQ7kBojvOadOFfm6Tw2CY+e3ds2mNNBQvLk47KcIQ+b6pZSTYN1g6+KYtNwJ19OSzvUdkjHUKspUPS2mXnqRFXtQthnWs6vxD9EqQheo/S5GdCWwW+IL9FiCy4wlUPiFZR/uVYC2E/m2DNItQqBDy31LrhV0Yj8BhLISvQakvUMuyD2aldCfsTIk/ir8dKbnkYHWdKv8HuuBSu8oUCNp85uA3dDaRuGMcp+Z4kHmgZsrIjm+g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 458fd087-1ea6-434f-a4ba-08db34f8207f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:34:10.8412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C+xzU4aZL46DlngxkUJWNuTvvid6O7tBOR7Ai1wneb9sw/9E4Imz8hrhaykgAKr/50TZ3Ls/ORGXGafbQ7m/oIWiD5LHpyugfcZ5d8bsXXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB7152 On 04/04/2023 10:20 am, Jan Beulich wrote: > PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no > more than 32k pIRQ-s can be used by a domain on x86. Document this upper > bound. > > To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its > parameter type) and setup_system_domains(). This is primarily to avoid > exposing the two static variables or introducing yet further arch hooks. > > Signed-off-by: Jan Beulich > --- > Instead of passing dom_xen into arch_hwdom_irqs(), NULL could also be > used. That would make the connection to setup_system_domains() yet more > weak, though. > > On Arm the upper limit right now effectively is zero, albeit with - > afaict - no impact if a higher value was used (and hence permitting up > to the default of 32 is okay albeit useless). The question though is > whether the command line option as a whole shouldn't be x86-only. > > Passing the domain pointer instead of the domain ID would also allow > to return a possibly different value if sensible for PVH Dom0 (which > presently has no access to PHYSDEVOP_pirq_eoi_gmfn_v in the first > place). > --- > v2: Also enforce these bounds. Adjust doc to constrain the bound to x86 > only. > > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1130,7 +1130,8 @@ common for all domUs, while the optional > is for dom0. Changing the setting for domU has no impact on dom0 and vice > versa. For example to change dom0 without changing domU, use > `extra_guest_irqs=,512`. The default value for Dom0 and an eventual separate > -hardware domain is architecture dependent. > +hardware domain is architecture dependent. The upper limit for both values on > +x86 is such that the resulting total number of IRQs can't be higher than 32768. > Note that specifying zero as domU value means zero, while for dom0 it means > to use the default. > > --- a/xen/arch/arm/include/asm/irq.h > +++ b/xen/arch/arm/include/asm/irq.h > @@ -52,7 +52,7 @@ struct arch_irq_desc { > > extern const unsigned int nr_irqs; > #define nr_static_irqs NR_IRQS > -#define arch_hwdom_irqs(domid) NR_IRQS > +#define arch_hwdom_irqs(d) NR_IRQS I know it's not your bug, but this ought to be (d, NR_IRQS) as you're changing it. > > struct irq_desc; > struct irqaction; > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -2665,18 +2665,21 @@ void __init ioapic_init(void) > nr_irqs_gsi, nr_irqs - nr_irqs_gsi); > } > > -unsigned int arch_hwdom_irqs(domid_t domid) > +unsigned int arch_hwdom_irqs(const struct domain *d) > { > unsigned int n = fls(num_present_cpus()); > > - if ( !domid ) > + if ( is_system_domain(d) ) > + return PAGE_SIZE * BITS_PER_BYTE; System domains never reach here, because ... > + > + if ( !d->domain_id ) > n = min(n, dom0_max_vcpus()); > n = min(nr_irqs_gsi + n * NR_DYNAMIC_VECTORS, nr_irqs); > > /* Bounded by the domain pirq eoi bitmap gfn. */ > n = min_t(unsigned int, n, PAGE_SIZE * BITS_PER_BYTE); > > - printk("Dom%d has maximum %u PIRQs\n", domid, n); > + printk("%pd has maximum %u PIRQs\n", d, n); > > return n; > } > --- a/xen/common/domain.c > +++ b/xen/common/domain.c ... just out of context here is the system domain early exit from domain_create(). > @@ -659,7 +659,7 @@ struct domain *domain_create(domid_t dom > d->nr_pirqs = nr_static_irqs + extra_domU_irqs; > else > d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs > - : arch_hwdom_irqs(domid); > + : arch_hwdom_irqs(d); > d->nr_pirqs = min(d->nr_pirqs, nr_irqs); > > radix_tree_init(&d->pirq_tree); > @@ -771,6 +771,8 @@ struct domain *domain_create(domid_t dom > > void __init setup_system_domains(void) > { > + unsigned int n; > + > /* > * Initialise our DOMID_XEN domain. > * Any Xen-heap pages that we will allow to be mapped will have > @@ -782,6 +784,19 @@ void __init setup_system_domains(void) > if ( IS_ERR(dom_xen) ) > panic("Failed to create d[XEN]: %ld\n", PTR_ERR(dom_xen)); > > + /* Bound-check values passed via "extra_guest_irqs=". */ > + n = max(arch_hwdom_irqs(dom_xen), nr_static_irqs); > + if ( extra_hwdom_irqs > n - nr_static_irqs ) > + { > + extra_hwdom_irqs = n - nr_static_irqs; > + printk(XENLOG_WARNING "hwdom IRQs bounded to %u\n", n); > + } > + if ( extra_domU_irqs > max(32U, n - nr_static_irqs) ) > + { > + extra_domU_irqs = n - nr_static_irqs; Why the extra 32 here? > + printk(XENLOG_WARNING "domU IRQs bounded to %u\n", n); > + } > + > /* > * Initialise our DOMID_IO domain. > * This domain owns I/O pages that are within the range of the page_info > --- a/xen/include/xen/irq.h > +++ b/xen/include/xen/irq.h > @@ -173,8 +173,9 @@ extern irq_desc_t *pirq_spin_lock_irq_de > > unsigned int set_desc_affinity(struct irq_desc *, const cpumask_t *); > > +/* When passed a system domain, this returns the maximum permissible value. */ This comment is technically true, but it probably doesn't want to stay. ~Andrew > #ifndef arch_hwdom_irqs > -unsigned int arch_hwdom_irqs(domid_t); > +unsigned int arch_hwdom_irqs(const struct domain *); > #endif > > #ifndef arch_evtchn_bind_pirq > From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:35:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:35:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517815.803670 (Exim 4.92) (envelope-from ) id 1pje0E-0004pV-Kj; Tue, 04 Apr 2023 10:35:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517815.803670; Tue, 04 Apr 2023 10:35:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pje0E-0004pO-Hl; Tue, 04 Apr 2023 10:35:02 +0000 Received: by outflank-mailman (input) for mailman id 517815; Tue, 04 Apr 2023 10:35:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pje0D-0004kI-53 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:35:01 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5874413f-d2d4-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 12:34:59 +0200 (CEST) Received: from mail-dm6nam04lp2048.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 06:34:56 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB7152.namprd03.prod.outlook.com (2603:10b6:a03:4d5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 10:34:54 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:34:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5874413f-d2d4-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680604499; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=LXvl7Q3MWQdrWCPWcRV34Y4DsSEqczpFJv5pi729qKQ=; b=WP+JAYsI55YaSsHYDXxkJaJcpZ1bqU2LpBy3DDr39Aso+Zr04+xjWCy0 l7akXUh5TWYQiE/1dV0IF25heW+O/4t9NjIFsuC8O54oDKaOeHzpE5wZ1 mnS0hWLcwY9gYb4U0cJr5cnCIGU3YW/G2mKw4XKZmxe6kOyspkdJC6x4W c=; X-IronPort-RemoteIP: 104.47.73.48 X-IronPort-MID: 104280354 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ak8wEKjT3hFSv7G/VURyC0QBX161QhEKZh0ujC45NGQN5FlHY01je htvD2/TP6zcZGahKYhzbtji8kkFuJTVm9QxHgdkpCgyEH8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQpFBUcYRCAv96x3ZCgE/Np2p8ecPj0adZ3VnFIlVk1DN4AaLWbH+DmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMqluS9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOHipqYx3QH7Kmo7NlpKCmDqm+eDoxCMB/9ve 1EJuRE/lP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+LqRuiNC5TKnUNDRLoViMA6tjn5Y020BTGS44/FLbv1oGlXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:YY+3f6uiKOyHlQP6CcKd2LD47skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104280354" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SmVfRWhO2TfFgk14bLqC6vaIkeg/LcbBl3P0JAGjmb8khhR3M2WCXyfwunZkgiOzJ6x8BGvnKPSysv60nd1k0+Fm08AGNFetf5lSFHt8OyN0KdEQgPeh85h9RtVZ9OJxCShtEZ/DcLuFNe0GWR1xiL9mbFAIEBysGVP0tV0VcQZCvn5TWuOoy1ajHCW4jWGd4uCTIRs9xddN2n+Wb/ZUQpKDy4N7AHzPibPpjkNKxvGcxLqeQXokSl8kNPsjSR/pUjnTOdW3YNSLEGjnRdzDEQNyixy8rxhrNqghiMjhAZ9Jl50U6u3Oc59N+O97yHmjZuSRK/iUJJST4YvA1COPtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LXvl7Q3MWQdrWCPWcRV34Y4DsSEqczpFJv5pi729qKQ=; b=l7byjE+OcKiMEwpiiL/ArPQdijNgxwlj1/FjdX1fLgPrPgVlSw11KMBZAp7XO9lF2DunMK2vQucUFo7vVadm5f7f2M2n01QlcNbtiOY9TUBJ9mEowHqmozHFvivlrXSC5GOFSCJReotO6DXr70XX7mr+IE5Sl7uOfHNK7HAaGYpUz3Pfz8843S3k+3HFvllT6G0gDYlAH2pvMUVSILSTPfg5qC1UE6+61aL12AyrT+1gu3gs76ikQAjxHmZlyU0pYu9ND2EVRt3+FxTCTrOgqhQNKNWHSW1nOd5xFFJfyJhtvSfC0BsRHJ7zb7KnEduGMXpmI5FeL+LZMNySwcVImg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXvl7Q3MWQdrWCPWcRV34Y4DsSEqczpFJv5pi729qKQ=; b=Og6sZxqGHT0KbHmMTKjVU9vwmLSKIVD4E2DBwtWsx33ydIWaT0g5npmqi5n+D7pxPfEzrLFvE7DK1VQAqenqgEWCcO1yK7URInNH9xrzr2i0WJuXilSStpemeNVqTqVtJfZa8OP2mwUnpGmEQULO7yIVooh9mxr36/+FbOqT86w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0eba4f65-c054-531b-2998-6038f17af0f8@citrix.com> Date: Tue, 4 Apr 2023 11:34:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v2] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0483.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB7152:EE_ X-MS-Office365-Filtering-Correlation-Id: 20802844-2fdb-4e39-df92-08db34f83ab1 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CUBAvMq/Y0uCnTv4sQRjyf058xtwyXb7jn6wO8ZHMeielHZ8xXalwqOtURQyXzo/K1lrr9duA+Glq+xhNMZx2XRsZjiatr2RKjB59po6otVx2UpUX1BRP8PKbBrhfDTr+BjKXb5pBhZ0bEoc7p5FsT2DusTg0U2/O59TR532PeKShkh+hEqv4slKrVIlC5OaVWyQg6kjXjb9KFmxcgayXQMSCLwsPS9D1jQ3AGWVmH2KVp6pukmUCq8aR/khpYkHVPSb9w0W96pEAqrlPysoKVZsZSfQrTIqFTtNi6RfR2cTOWIBWLTa6SjFS1odMi3ik/t7CcZ2DbdmMD9CsfK2ukGIBw+NDvvDfpYpjrnaT/94hgO+iGe8Kzym2lxwcjpAs+kzkBJY3XxWbj1WbMpY1tOVXagy77AaJ4SNQ1kXBPzLMGfzVd3y0cDwg0NI2eKb2d4jiLaK8TFHYZYPldsX3FPF7esoZ6GjY2jipNT5cH2BmFozvefc4eUlEFxHxTzvvbbyaBFQhDOQOiayi/U2fPZaw2/PdkYLNeXhhuUwAJN/7GFoHIyx8NH90nizFET3sQh+VOLQATAX1n4t1XsvF8wu8/gXcXbASwbVqBHxa6WlJqyqEE4CyEWChfJm83MYICNFzxblHvdXF9AnNKFKWA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(451199021)(5660300002)(8676002)(41300700001)(4744005)(110136005)(2906002)(8936002)(31686004)(66476007)(54906003)(66946007)(66556008)(4326008)(478600001)(316002)(6666004)(6486002)(107886003)(53546011)(36756003)(6512007)(6506007)(26005)(82960400001)(2616005)(186003)(86362001)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEFXazcxQmRHa2svdXdFT2hjL2llK3pnYnhDdDl3UE51d3Q5OHN0RDN3OXZm?= =?utf-8?B?TENXeEdHVEk4aVJEYVdYYjhJMTdhQndoVlVKc1VKdW5wRm1WbnhFZzJmb0VG?= =?utf-8?B?a3JWMW5sNmVKbUNZNThFQ1A1OXJhK1ZUWmJSbG41cWFNWXF3WFpEOE5WSU13?= =?utf-8?B?Y3V1bFBIQjc0RHFBanBvQlMrUnV3cmNYZlAvcDFPQ1BtdnJIRWJ1WnFGbGJi?= =?utf-8?B?aUcwTEdWaDFXRDdKT1ZIeXpsQ0xIbk9Ga1lneUVTNEpCUnd1ZmNQZ0I0MWl4?= =?utf-8?B?Z0gvSEV5OWNnS2FVbFg4QmZ4UFpmMldpTXdJUTJBS1pkNGpxSFFSUkJEUU81?= =?utf-8?B?eTFuRi9tSTFKUWRQYWVkY21obGI0UVRJZFdQSzYvQzZVQnEvVU85bTY1VlNp?= =?utf-8?B?alU0eVhsRk1RN1ZIOUFZSDlQOUNMcUdDRUw0VHRPNE1HN3ZFVWRjU3N6a1Ax?= =?utf-8?B?TGlXZWFTajA5eHJ1Qkk1NGJCTWxkNGZYQWxvbzQvem1ZVXZmOWdGdDdQWnQ4?= =?utf-8?B?RE8vY2FPQm04dGVBVnptcDRvSDFjWkJrR2hjYW9PQmMzQzVqbTVqQkpBMmRx?= =?utf-8?B?ZkpSVXRwbjdBaUU2NEdrVGIvLzdJY25ZVGtKTzY1ZUdpbjVWYVZ1MHEwaGdD?= =?utf-8?B?THJiQmFyK2N0QVczK08vNU5hWUtPK0lhYlBrV0RqKzA3N1JrYUpwdmFubDJY?= =?utf-8?B?RUw4Q0VZd2xZamtQMVcrN0JaWkpRSFM3bTdsa2UzTkxoMDczdTdRQmVWc1F5?= =?utf-8?B?Q2R4V0g1cDQ3bVJKbmVlYVNFdXJjQWl0VGkyUS9obVpTaWYxY1ZvMnE5QVpF?= =?utf-8?B?Ri9BTUVPMy92YWkrdmxTaEhnSmVNdUdlTGo0ZHZPa3BpaGxlQkVvQnRvOG9S?= =?utf-8?B?V3NMNVRmUVdQTi9waXFIN0xkbzFFUkR5VHQyczlER3hqQ0pSRlFSZHJHVml4?= =?utf-8?B?Qjlyc2QrWk1uL1V0cFA0bkZnVXAxMjdSVkNXWEhsQUpGVW90R2dNTVZ4czFV?= =?utf-8?B?U3JVeVNDOVZOTDdlTVZ4VVRGWjVOb1VBWFI1QW96WHRMZVdEQmt6cDYxWHpQ?= =?utf-8?B?VWl2RWYxRnJ1ajQyOStiY3JKaERUSGlvcys4Rk9JWDhsaVlkT3BjRFAzUHpy?= =?utf-8?B?Y3NaMUROZk5GNzFjbzQxYzM2V2VGWDREZTlRZTQ4L0Q0cUtrTzJNYkNNeC9Z?= =?utf-8?B?dFo2M2RGYVBJbDBLT01UeEVuVVl0dzV4Y28vZ1kzL3hZeEJQSUlmcDBHZkts?= =?utf-8?B?S2hvRWxhNGg5Znd6bkZROW9BVFh1b3hXdWpxdFA0QTYrVDY1YlZqNDRnMGZP?= =?utf-8?B?M0U2bC9sYzRPK1JVOTFkNGZBYUt2Rm1IMVNGbXp3b3E1Ulh1ZjFncnNadWtX?= =?utf-8?B?Nk1LaUxEQ2ZsTlBxWk9vTC9oVkFRWUtsdWFWMGxkUVpzV1I3K0dIUkhtQisw?= =?utf-8?B?WENORG9OTFV4N2x5K3BKa0lVTW5qaS85bVpmWktBMjZSRGJYb2tPMTE1S0w0?= =?utf-8?B?YzRzZWlma3VZWWgyZUt5RDdFVHJjc0lmUm1aKzFVUlZ1Z2JZb0tTRG5NWDR5?= =?utf-8?B?RGUyZmI4K3lidFlkdkNOMnZYS1JvVWhXeUpMaDUxVUZmUUhIcFdjRTNpd0FN?= =?utf-8?B?YkQ3aHpUbnY4bGNXbnp4VDVuNkZEczlFSjRJWitmMnRyVU41eDFUblhpd0k5?= =?utf-8?B?RzJuTzZzZjVaQjlwM2drSi9lWEUvTTNoQUdkdjMwUVNwUDNDRUtCUUFyNHpn?= =?utf-8?B?V3BJQVZmM1VwUEdhdmM1VXlSUVQ1cW5xK2wvNWhicHNLTkZrckpqNUZLN1Vt?= =?utf-8?B?dG1EOFdnaVVzRGdXR3NTekR6YkVXYlJJaU01eDBVcCtOY3RvY3JMbzByajFa?= =?utf-8?B?Wm5xRnJTRmthZDhwT1dub3R5b25NSHVVb05pZlBJMXdpRTU4ekRBa0Nkc2cz?= =?utf-8?B?b2pLUEh0azhtME4yclBTVHkwMWhuVVhGSzFnUFFIOFpBZU16NGtuemtKOVJ5?= =?utf-8?B?VHlHWEcwa2krZE9GSXpSVit1K2xDV3NrbE5kOUNHUHIvV3RYWXRwSytOTmlu?= =?utf-8?B?WnpGWndYc3lyKzhxMDlKeW11Z1NOQWpVNFBKSGltcExkVTBrZ2lzV1lSK21T?= =?utf-8?B?a0VEbmtyejlRRDl6bGdvc3dVUTNjWWxMLzlMVy9GZ1NmTUM3VENQbjNwZCtp?= =?utf-8?B?L1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cAKExYs5cyHWmlabf/b+aXIUh6aPZJpKy6oe3aMkyb/dQ56OfWAN145lsXuyO9Jh21ehlNSo16mniGaFBR7cuMxX21MmrHPzyzRj/6yWNSjOJ8P9wv09FEmxPcyOkWU7bByEE9DsM7cCXMHWRbh+Rj4tJT5PURmioeQ+VN4HkyE8masZU/qFp/KwF8Ntagt4rMmidyM9w+X3xm5F47QRztmN1f9QO/b02hAlUTwypKoUDchBHreKtFgeS4O7N3S3zIDsLYhe4aRfhFVot2ASTlncZt+swgDhl0OJHvhp7FXRas1KLDPfPZLMeeLJJ1b+rxiofhbJNywJ90wzkTTCQYEmCFWeTNva0LxjRsMgi1z2/zoGxZtP5AW2RW6qvPT4gdj0QtTREuQV35jXPgnGIzxcDVEWJHv8OdiCc0+lfnoUrx6eiy8qaVuRLukPyblxvkMgRgld+ANgbMf8ICHt70qEV8cGlWzEp1T0vMFONClsqJrBBkBBp8DCfUq6l3S7oypSw3YS/9x6KhdK4Jbko6JmbvksEcz6yUqNHM2qfLgEyj1yXRZUgs2AC+lOujKnibGfLt5daR8nBomPkynMbD/7FZpxSWlp6SZOvDapYtnDmhAKkBCe/xGWXCdm7xR8U1UPT1dY9i1oK+VH/wVwsoiBsYCOgmpHKzlQBRJv14dCzqyJ4hkHs/bTzSrUKNS2J0lwOuo2zfrqPF50i8wH3KlRtLJr7wNPijYDvy1BJF5v4TbTJX2b5nstMbhCsAvJEuA6ByK5hq8BzAN9WdIsK7vNYCqxlxO53iVzOPfcavj7M2JStcJAViquqFAhrdWj X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20802844-2fdb-4e39-df92-08db34f83ab1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:34:54.7425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +vXcfbfeQb8yp4kj80w+5DGmV/DEphCRo8OrQQgCXxpW2n7T24s/Tpq9rvRUHfY5PoSOPbbN5lETAGpUD1iSujE8LIjp59U6m+pqqCgOV/8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB7152 On 04/04/2023 10:19 am, Jan Beulich wrote: > Besides a printk() the main effect is slight corruption of the start > info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended > up as xen-3.0-x86_64p. > > Note that no known users exist that would have developed a dependency on > the bogus magic string. In particular Linux, NetBSD, and mini-os have > been checked. > > Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:39:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:39:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517821.803680 (Exim 4.92) (envelope-from ) id 1pje4E-0005V7-5Y; Tue, 04 Apr 2023 10:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517821.803680; Tue, 04 Apr 2023 10:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pje4E-0005V0-2A; Tue, 04 Apr 2023 10:39:10 +0000 Received: by outflank-mailman (input) for mailman id 517821; Tue, 04 Apr 2023 10:39:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pje4D-0005Uu-HW for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:39:09 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20608.outbound.protection.outlook.com [2a01:111:f400:7e88::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ecc90741-d2d4-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 12:39:08 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by IA0PR12MB7577.namprd12.prod.outlook.com (2603:10b6:208:43e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 10:39:03 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::659f:af8f:6d3e:8242]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::659f:af8f:6d3e:8242%4]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:39:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecc90741-d2d4-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NXqgMz10bGgqY66STra7jb2YSy1QRnFJf5ND73tU/fZnwwmUK2yFwgdliZwYHi2r3uuYoohm9hfyDJPrgAyS53lkD4ApdTePlcXVn6ZpnKad2DB9XRcF9RIcH+/SgQOjalbHYaPcdLHrzsHZaJx9Go4vd8JRgU8gzKvp0yePkiJg2TacslqwblncNwAaIJCUy2PgXiC3eXjnx2m8SkD9S6W/QHk/il/dA/NVamkX7ld02fxvLMQgywx12JnYYpb1Ph11vTZ8hgUrnm3lNZMdGuH7kI/P3RWdhxk+KuOqqzonqjFQ5vAvZAoJwgTiopWtBcSiz9RS3s2ZIFYTx3ILWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mn9NBNAoabzJLeGf/m8W6pLeV0k6QC8ZkTvUpnBKvq8=; b=K8+yFpC4hhBR/yCCnHbIfGySPaUmXZB+ffbK9984YecKI6cOakh18kFba9oNb5VBdbhC0UyPWMKVqEaWOTvOOdyNn1TkTHwVuwMG/8l9oZmHjUiAU3f43w7FKO+BkMhemRWjQqwiupQGsZxPGgqSS6bSsJTNc28g9CzW5ic6kYyUlakEiZvcgGgssfQQAacju97bHBDbOCOyAXbBel9jLXDbaKDimZO4zqJscGR2GLI8rTwA7nRI63K6u6sJucJkHw7lm6gXrZPqKtdSvhrpgaDe3dIGIqWaPWIRSeYEI8t6BJKgmv2BV6ack67nQfBu3FBXCgp0IqD1Ss0Ci+l0Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mn9NBNAoabzJLeGf/m8W6pLeV0k6QC8ZkTvUpnBKvq8=; b=S24BMfdfkUmh2aVNAg8LHimJ6vPxPQrMLehG34knLFtYSHqrahcJopoR6wFjNRivZuTZ9E3M/be60mLuTdABN3OUGSrHekzzI3kX/I9zleRuJhnWqQgKJe6G20EOHmxwge4tvBh4visCSiZia8MXCthVHBG9UFvisVhCoGBTh6U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 4 Apr 2023 11:38:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN v4 11/11] xen/arm: p2m: Enable support for 32bit IPA for ARM_32 To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230321140357.24094-1-ayan.kumar.halder@amd.com> <20230321140357.24094-12-ayan.kumar.halder@amd.com> <22ce7663-e63c-a3b8-9444-8f43cc4620c4@xen.org> From: Ayan Kumar Halder In-Reply-To: <22ce7663-e63c-a3b8-9444-8f43cc4620c4@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0632.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::22) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|IA0PR12MB7577:EE_ X-MS-Office365-Filtering-Correlation-Id: 732c742c-cc52-423b-3e5a-08db34f8cecc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s5iY7twI3ihaBx5iJGrRFUUg06tnKNi9S18DOLoBJmBeWlP12maxb9WoorEiF/YX6zDazGgGS3S7qGQLABRqBCpQ/aBIciMYdFoxOe30FMRP4y8y6sAi/pSej5CED5URDZ/L1A4MZikkQVMrSqh34I4ylHQGVq/KP6394MAkrjSJKjLoBvmPT5H6p+r+83Z3UX4QV0fAhY1jLWKoqzpim/2ID75vgVBxX75StWCV3X2EYXkNs/+n/8UxxmRBbGCFsvcItnocakRahxRCTNf30yf/vT1Jk5kGIqCzTizhzyyUKmsHtqKQSYhhtBLPXw0pc/TJ5HbjaD+/gY5F4Kd0yQ8MIhWOQ0iT+6E6DPQ4VgdFNFdNs97tY7/I9Q7vmYGuXVNZh1a+QRGATrMgBPC0eeY40zmf4Z8WML7hstY7IMc4kAW3vFzfvQ7VqGqMF4+FvNvKKRmgaic+CvS/aAl3jz+c81F7KlzG9BYJcSRmO7eWrygZ05AKY3e1nKo78MSC+tskIJjdq1Hi5GRTXGN+4P16Ur1QvtejF4Qip8ycoOMNu5jmi1v+MJn/waQDdqeCfzZrPCpzNPHEUwcxl4De5C2suYP4r47G/iB1LBJCHRgLfZPgMYWIMyY6CleQF7NXlB3IgQSA+ryExpHl6kyCDsZcGGazcHa69c6sQqwuqgDnfP8O7bUbtiI9zL82ItW4/ctlQRvgZGbg8fIAvvOlmg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(451199021)(478600001)(4326008)(66476007)(66946007)(66556008)(8676002)(110136005)(316002)(8936002)(7416002)(38100700002)(41300700001)(5660300002)(53546011)(83380400001)(186003)(6666004)(26005)(6506007)(6512007)(6486002)(31696002)(36756003)(2906002)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0NEbmpZSC9Jc2N6aElsYm1FdWVWL2FaZmZManpiMDNFUmJieE9UUHkrS3dk?= =?utf-8?B?OXdDYjVKQklsMjAyRFJPWFZCWGpoN21jQkNJOXhURDRGakU4Zm12UnRacXBi?= =?utf-8?B?bEFsVTMrVy90Q21NSU1DNVV3VnZlbEluc29lY3FCcndlTms5VnAwU1lEcmtZ?= =?utf-8?B?UUZIWWRxRjh3T0Q3VWdHUm1BbFJkTzYzRlBnYWJGd1hyU3pncCtkVy92dkRv?= =?utf-8?B?WkJHNXVhSWJuQmszN2JkRllqMVNPV2JqRFk4TjZ3cmpNT1NwZ1hoNmJTb3Vp?= =?utf-8?B?cXpaTG03RlRObzUvVUtndHhhV0REL3hrQ0FOMk1TdERMV0JUTWxrY3o2dmcr?= =?utf-8?B?NmNpRUIzK2NWeXhYV3JQYTdqNE8zTDgzZy9aVkZxTmxCR3F3M3h0MVdhUUpx?= =?utf-8?B?ZXhhQUlDbEtGbGlLN241emJ1enJCVHlXR3RRMnJCc01Ld2VCdHV3b2Vyck1P?= =?utf-8?B?d0V2bFlLWEphdVlJckU4WjFGMDlJZ0xLMnA1ejczK0pKRnpaT0tDUlp1a0hK?= =?utf-8?B?MWFtMGFndzA0aTNZZXNocXNBRndReVM1WlJTS1pMYkdRUXBEN21NeDNCV1g4?= =?utf-8?B?alhNN3ZQYW94R0Z1RlhsMXByb01EZUJ1a1kxL2prUkpQTjRqeTQyRys2M25r?= =?utf-8?B?b2c2TzMxeG4rVjA3cWM2SGg1MEx3UlhmNjczV0xpa00wczMxb0lPTG4wZ1BQ?= =?utf-8?B?TGFQUHh4Q0FrS3czNFdMdUVoenIxK2U4SGMvc0RvTW9BOWQ3STdqTmhvSjkv?= =?utf-8?B?VHRlcHBaWWhLbTViTFFrZFhyemFtL0o4dXNVUHpIZDFWbUxnR1lyYUMvaksz?= =?utf-8?B?VWFWdHhWWXBqdGQwTWpoZTFlRG1QVzUzcGR1SEllZ25HbjVWYVRVNDRMRmJM?= =?utf-8?B?SktEb3NVY29rY0VYSXNuSk5tbWpFK0NVcjFtaG05OUFvSEpPMjJjRk5PV0ZL?= =?utf-8?B?VVNLWHc3MzJ1YkFUVHptQ2REN3c0TWdpV2dGTXNBcWFXT2NMWSs4Y29hSHd4?= =?utf-8?B?ZzB5d0hRNHVOaFViWUxNN1ZxMnhqSVZCZ2dwVG83eUZLU3p3SUdIMFYrTXVw?= =?utf-8?B?M3lsZ0pMRWlwYXNieGVWandOODlaby9LSUt0aUJSRDFlcDFCbFp2emVtYkpO?= =?utf-8?B?ckRxSTJhdDRLNWlhbFpyWGdKME84QllBZXFVM1NGWlczcmQ3OWJIZmEybXRF?= =?utf-8?B?M2tVRXdReG4xamxNbzNrVE14YWs5bXJKeENSUzFyZG91OHQ2ZzhVT0h0dk1t?= =?utf-8?B?eWt3MVdaTGdjNXFCUThVSXJDSzZ6SjVaRXcwN3hFM1pEK0xGMmJyakd4dGxW?= =?utf-8?B?cjF3Mk12UzVHZWNnczlFZVM2emF4V2FvM2dvajFqYzVWOEQwMFloVnFVbEUr?= =?utf-8?B?eS90THgvY3lVTWVYTkUvNGRxTlRzTGN0Zm1JUVZIaENVYWtSRzN5NVkzb2JB?= =?utf-8?B?ZVF4ZS9jSE1QY3lRdkE5dFovQ1BUcWdjRE1tNkNHRWhTdkhmRWh2dmVsOHZt?= =?utf-8?B?THBHdHBGaUowVmxEY0t5N25CbnVUU21aS0p2dnlMenlSbnpoSGtxVlpPNTJ4?= =?utf-8?B?bzNmNE0xQ09uNlJjZzF0ZEVoUUVmOEdLYzdrMnFQK2Vmd3Q3bkVKRFF1Ymxo?= =?utf-8?B?WUtGRHMyMGpQSnVzV2IzeTdqeDM5Wkp4Z1pFL2I0b1JqazhpMjg2Q1ozQnBK?= =?utf-8?B?ckg2a3ZtYkh5OGdYNG54eG8vV1pmVWFZQlcwVGZ3Q3FVaCszTlR2dTN5SVBM?= =?utf-8?B?NklmSjNkS2xlQW9hZUltWi9lTDR1TGNyS3Q2Yk4rVUZIeEZXdk9qQWVRdWww?= =?utf-8?B?SVdwalFYNlBmNlFCYmFsSG5XdVNZT0NKc09HY1dmallOeWVvM1BSNWpSNDdZ?= =?utf-8?B?Y01VWEh1ZG04OFhiSTBRV2tReHpFdzlEaFc4RGgzLzNVWXdUOTdxU2hkMTZG?= =?utf-8?B?Y3ZUaVRyWklVem44bjNxeUxneEN1eUFCcHBaU1RucS9odVJBQ3hmSWhpaS9o?= =?utf-8?B?TFA3Uko4bktVZ1J6VTY5d2k5R0YzU0cxa0tmcTY5ekNGRHN2Q0grWW1qd1FJ?= =?utf-8?B?aE54c2hSWHhPaVh5K2xlZFI0Z0VDdzZyWkRyM2pYU3NsWHZwa3hWNCs3OW5i?= =?utf-8?Q?dSzKblbzK0MPQ+PH+/ln/W02q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 732c742c-cc52-423b-3e5a-08db34f8cecc X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:39:03.0467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: psfq0utQ4sQWygfKvxwz+lEWG4o9l3qx++WR5hhIHwjSKpSZjDR0qkXl9e2thUpP8jqlGFzvQ//DsnxBomSfbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7577 On 30/03/2023 22:45, Julien Grall wrote: > CAUTION: This message has originated from an External Source. Please > use proper judgment and caution when opening attachments, clicking > links, or responding to this email. > > > Hi Ayan, Hi Julien, I need some clarifications. > > On 21/03/2023 14:03, Ayan Kumar Halder wrote: >> The pabits, t0sz, root_order and sl0 values are the same as those for >> ARM_64. > > To me this read as the line should be common. But you still duplicate it. > > In any case, you should justify this change with a pointer to the Arm > Arm. Not just saying they are common. Does the following commit message read fine ? Refer ARM DDI 0406C.d ID040418, B3-1345, 0. "Use of concatenated second-level translation tables A stage 2 translation with an input address range of 31-34 bits can start the translation either: * With a first-level lookup, accessing a first-level translation table with 2-16 entries. * With a second-level lookup, accessing a set of concatenated second-level translation tables" Thus, for 32 bit IPA, there will be only one root level translation tables. This is because as the paragraph explains above,  35 bit IPA is the minimum required to support two root level translation tables. The root order for 32 bit IPA will be 0. (Refer xen/arch/arm/p2m.c "#define P2M_ROOT_PAGES (1< >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from - >> >> v1 - New patch. >> >> v2 - 1. Added Ack. >> >> v3 - 1. Dropped Ack. >> 2. Rebased the patch based on the previous change. >> >>   xen/arch/arm/p2m.c | 5 +++-- >>   1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >> index f34b6e6f11..20beecc6e8 100644 >> --- a/xen/arch/arm/p2m.c >> +++ b/xen/arch/arm/p2m.c >> @@ -2272,8 +2272,9 @@ void __init setup_virt_paging(void) >>           unsigned int sl0;    /* Desired SL0, maximum in comment */ >>       } pa_range_info[] __initconst = { >>   #ifdef CONFIG_ARM_32 >> -        [0] = { 40,      24/*24*/,  1,          1 }, >> -        [1] = { 0 } /* Invalid */ >> +        [0] = { 32,      32/*32*/,  0,          1 }, > > As I pointed out in one of the previous version, the root order is > different than ... > >> +        [1] = { 40,      24/*24*/, 1,          1 }, > > ... here. Yet, you still keep P2M_ROOT_ORDER and P2M_ROOT_LEVEL > hardcoded. Your previous patch wants to define p2M_root_order and > p2m_root_level (lower-case intended). IOW making more code common > between arm64 and arm32. > > Cheers, > > -- > Julien Grall > From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:40:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:40:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517824.803689 (Exim 4.92) (envelope-from ) id 1pje5Y-0006rx-EQ; Tue, 04 Apr 2023 10:40:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517824.803689; Tue, 04 Apr 2023 10:40:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pje5Y-0006rq-Bk; Tue, 04 Apr 2023 10:40:32 +0000 Received: by outflank-mailman (input) for mailman id 517824; Tue, 04 Apr 2023 10:40:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pje5W-0006rk-VW for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:40:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0c::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1dad2538-d2d5-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 12:40:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB9925.eurprd04.prod.outlook.com (2603:10a6:150:112::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 10:40:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:40:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dad2538-d2d5-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fI7x1J62ojqi97gy4+fTaJUsgb2OhfGDGOWxGAdMiXhREY4SgsbRMbgY01Ea+i5xTwPdJJvdzlw+X66rcEZK8rShpa0/S8P4R4jJf+knpEvkmGtzyqZKnG5n8NSNNabTO35FSthhaIM7/DtZSLRU0DN1fK/oIqskBXQRKQcLPaFhNM39zH3t27WC1v78V3ET402J5kxlCsRUnu7Cz8AWwuTJ43uoPnDxKsIuZg70ayKV0xkEyCKIWAHfXR345WpBeoPBCYDQuWfeIkDFKup8QTmcIJ5Zq/VtmO4PggPNZYKd/2GXArdDjcJua8XPwFwy3jDVP3SGM5faF3JFn3oPSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xBCXfjvZiFQaKwerBMfqcds06QVNrK3ird1Ze6TJ1/4=; b=UwvzoLctm8iTZuLOqpTQgD4RH2FxNbqHK90nA9mVZWP5Z09/D3q/a3Exuj85Z0ZklgOy6EyVQ6e82LuihipArU1ifguVCG7sI0hQGDg8Ef0lfBTxZOBFLs0CTkt5TeH+8l7nNxjWeeozo0P31oqf2ayFPsVD8IO894xqVZ2Dao7677feYzgEEJQEARB3mdmiYa7CRZQR9DzdhNgv7quYLJKlxnc3AiqOTzW2Y+1fde2nWpGetX372PL1VcABlYsCZ8tLGO80tNQGNxl5mznRWXnFwoPCftv9VFGnQuHfASlfEp2GEnO7cR5G76oDcTsLPrWWgG75diVRINzWBC4rBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xBCXfjvZiFQaKwerBMfqcds06QVNrK3ird1Ze6TJ1/4=; b=azU5ruHzngtFAL0aS4DLPWES+gcoS2IAWfNLmrxscYSJK1xFaWGM6TydS7R5rn/0k5olgpOJrz773jaJTPOuCQmvnt6zlAaEekm3NZJSyuDw58cHTn9XsJndgymVflMHRAYpOoc7bSy3OPakr4901txg9+xE1Lv83ypugh5+lnjvhXn5KHe3BJorLqsurs8+Id65P97NL/0SBMLnIjbYPL4iZma/aEEXmKX+k0VMFEeosVqU+tqhWWQGYkMOFprb4ecKz+4290NbzEJCrYQx7WZqusBlsBkYwl/1frmwm7OZngZIS5JJw+RAYphuvMzC23oeBY9y/ma8zTb21JakUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 12:40:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> <6c5cdffa-f3fb-8f40-c44f-ad7431451929@citrix.com> From: Jan Beulich In-Reply-To: <6c5cdffa-f3fb-8f40-c44f-ad7431451929@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0158.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB9925:EE_ X-MS-Office365-Filtering-Correlation-Id: 10380eb0-29a9-4bba-3abe-08db34f9006e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jblOSUFyrjy2NsmsZV9PpHFxrDUf8fIf9H9GdUO+RgdksrtyMcBzvyAzY8oB7mvyO9bdQMdgnsfGuE6o+X3p4Rr1Ahlrv+2dtQ2NXw5lJFtKM9lMMa6DWlNpx1h7LJ7t+8dA+pkSVeKBvBGUqhr5rp573EjDI+ivLHU1I/Qv9hMaUIW+rSjg9f+Tg7dRxa8vB1GhGLPwoJVV5NPKENJPQIXJYaiwcsn8rd0pUEC05kGXaCGuYKt/D3N489534/NsUJlcARx/l4OHT79GZCxSYxrDMxRDri+tlWzuyXfMDfWUwxD6MCtOpXeEsuuFrLdX7IOJt4ELvKHmIZVnAxfZe/KdIplphgASmp593aPt9cezPnO+crVqxezxBRrGwHF0QjMPVGqboj1xkKAduPzj6jSbWXMptl1WZjqMuQsB/ocqCY3ZhLCyeCUf31BFJTM4/jfJQGxrpa78hTuS8/ZtnTLR7M9ykg9rDckqF9GIR/YeuJbBtF1wF+uCdhkz4hv6Qc+6nRNAZ7dklyyEQr9fM0JDaL1cQXlvMh9skCZpY4nc+gabDTMY6889V4l4MjnAVtZ26PlwXuVrz3zME+/Z6/zx9rUqNknWHezMtzyLdNCKAGnGTG2otunwHtZxRJwS9z/0XiQUNDyHlpIK2Hyp/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199021)(31686004)(38100700002)(2906002)(86362001)(5660300002)(66946007)(8936002)(66476007)(8676002)(36756003)(54906003)(41300700001)(66556008)(316002)(6916009)(4326008)(478600001)(6486002)(2616005)(53546011)(6506007)(26005)(6512007)(31696002)(186003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTZYTGJacGVQeEtHaWoxR3ZFaEoxemFWWlN1cjNtU2p5Tm5nR2JyRWUxNFF0?= =?utf-8?B?bUpGMTZIK00yVW4zTDVxREJPaU5WOEdoUTVvSWk5RmV3bHhVMjdxQ1hFTVRp?= =?utf-8?B?SStUUDhBUEFKODVDcGozRGVNeVY5eG8vaVZuc0NjLzNYdXZXb1RyOTA0TXdP?= =?utf-8?B?WUxzTEZabWdsN01RcVd4QzNQbHBMMVd2NnlVZlNpYzRBMnJHVFYwcnBhS1A1?= =?utf-8?B?Qzc4Zi9vWHBXdm5ERFhWSll6ZitabkFVZXYrNVd0aFdjWnhvbVJ0T2RveUZZ?= =?utf-8?B?MnlqNy9NcG1LRlNMSkZ4Y25wbTlmeDBXNlZrS1pSWWs4dzZCRThxWTRiczV3?= =?utf-8?B?VlBGQjFQWEdwaVdQR0FBeVppVGZaM3R1MFZXM1lTdGJpc3cvRkJWTVhmbTc0?= =?utf-8?B?bWlxd1VSMWpWMm52dWpDZ3pMTVBROUIvS0lSYjZVSXJTVEU5U2lpZS9jYkdk?= =?utf-8?B?bUc1Skc5MG44MHZTZThqcm56eUZwZ2pvRHJOdVJzUnI3eUhJTVZjYmwxZjZm?= =?utf-8?B?cCtaUFdrbjVrbm9uUGM3a3cycStmOVF4bWZpZ0tBWVpZK3AzQ3B4NTRITHlZ?= =?utf-8?B?cmdaMDdvYzQ2VHlFZmVTS1EyQ1NmWklrZ1hsOGREbFN0cTQyejU0NmJHV1Js?= =?utf-8?B?bzJncFRHcDd4TVRFUHRuRnVYR2kxeWlGOVZJS3FaYms2dlYwZUR0aG1XeklQ?= =?utf-8?B?U0ErZkhra3dZWDJ2ZHN0dUxENmxIRmhvQ2FyQWpIRVNDT1BZcEY1Sm5GendV?= =?utf-8?B?MExXd0RmQW1xSS8veU1mWC91R1ZCTkVDS3dUWEVQZlAwR0htWmMrU0d1Und6?= =?utf-8?B?UWtUL0tGNko5c0JtRms2UzZHbjJRSFRIa3hHM2FDMXBaRFRIYytOWWlJOTVR?= =?utf-8?B?ZU5rQ2krSXdkMXl5cTVNREQrc2pucjU1RkxwTVBOVmZZWkQ1cDRxdzNYajF1?= =?utf-8?B?c1dkMTBtcHJicjBBZGsyOWZubXA2Zjh4eS9hQWFzNE5DRm43L3FBcHVsTlpJ?= =?utf-8?B?ckVVTDhsNVdVa0ZYZkd1dFJSa1dvdTAzRW5wM2p5d0tONmRxUW5GNVNPQkJD?= =?utf-8?B?bWxkY1BpZmduWDY2Rkc1Nk94a1cxVytqY3V3MXQ5NTBZQ0ErMXJkQlpnL201?= =?utf-8?B?NCsyMEdBRFBSNWpIQXJQL0t4dkF4WVB3a2QvKzVYclVLeTg5WWwrNzllVmls?= =?utf-8?B?SUJQdkpZdVRmTEhUNnEySlo1ZmZ6WGxlY3VvSUdJamQ4dkI0dGl4MFhpSXFE?= =?utf-8?B?U3o4QXdaRk5nd01hT01XdlJUL1EwM0pmaXFObG5jM2hrQmNJWHA4RmF4cURQ?= =?utf-8?B?b1dWN3pyVHVDY05TeEQ5MDFEYW54cldUY3ZRczZTV3R5Q3VsNVBxc0JHbEhh?= =?utf-8?B?K0ZZNkV5VmZKR2RtS2FsWXkxSUU0NklReUlLUWVRanZxQ2NCQkdCUDlLeUFl?= =?utf-8?B?QWQ1NkZUajBYVnovRWFpTU01dEJVZ00zS0NvWTVlb2NSM2wrOWlGT2E1R2Z1?= =?utf-8?B?L0ZrTUxNUnhEZGo5b3liNFVJaU1nZ2NVMjVUMTY4WlA4SG9qM2ZWbkovT1lt?= =?utf-8?B?UGUrbFk2Qnh6L0xOM2VzM0dzdzltZUFaZWF6RXU3Q2psVVd5cDlZV0NRRHc2?= =?utf-8?B?ZnRaaU4vb1NLTEJmWngraitZaC9pbGJ2ZW8wZy9zR2NLWnFEN3FGZVA5cmNn?= =?utf-8?B?a1dka3cvYUNwZFZuYVU2T3hLMGVlRjBLRFZxaDNqZzRaMU5EQ0s5a1BZOEtw?= =?utf-8?B?dThiTlUrSHNIeGZlZ0V5RWRSM3BMeHRwRDBCQkVhZTYzdzcwQmI3ejVOMGs0?= =?utf-8?B?SVhycUxKVjZWU0J2Kzkwa1BPUkNYaXRFNXVtU29Kb2c3YWZ6WEw2Qys0V0Fi?= =?utf-8?B?OXpMR1JydnI3TU9mSHZhbXlVZlFLbCtYQ04zREZRaHR0VktHaXI1SENyRWIr?= =?utf-8?B?dU8yNDdlNWRhM0tUaXUwYW4yNTdFOHhCQmRRYmpvWTVFSVBQNDNSZHQ0cHlN?= =?utf-8?B?MTJ6RnExQ2lUYmJBNEdDTlVkeGdWT0hPcGFSck1TZEdnZkZNSVFWQ3VWcm14?= =?utf-8?B?ZlVoTFdKVStRQlZCV3ExRTVsT3lyZUswcnljZ3pQNXR3WDZBakNUOFpMdFNu?= =?utf-8?Q?gdmJ5pZfp98odzMkz3beugtsB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10380eb0-29a9-4bba-3abe-08db34f9006e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:40:26.3271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r90aoUXFqKACHTjsDBCXu1sPq+5ihh2O0jjvqGlxJDBcjcz/+VtHJh1HlaHhw1aOQbk3jE+Nthe7EY42j7Na0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9925 On 04.04.2023 12:34, Andrew Cooper wrote: > On 04/04/2023 10:20 am, Jan Beulich wrote: >> --- a/xen/arch/arm/include/asm/irq.h >> +++ b/xen/arch/arm/include/asm/irq.h >> @@ -52,7 +52,7 @@ struct arch_irq_desc { >> >> extern const unsigned int nr_irqs; >> #define nr_static_irqs NR_IRQS >> -#define arch_hwdom_irqs(domid) NR_IRQS >> +#define arch_hwdom_irqs(d) NR_IRQS > > I know it's not your bug, but this ought to be (d, NR_IRQS) as you're > changing it. I can add this (with a cast to void), but I'll leave the final say to Arm maintainers. >> --- a/xen/arch/x86/io_apic.c >> +++ b/xen/arch/x86/io_apic.c >> @@ -2665,18 +2665,21 @@ void __init ioapic_init(void) >> nr_irqs_gsi, nr_irqs - nr_irqs_gsi); >> } >> >> -unsigned int arch_hwdom_irqs(domid_t domid) >> +unsigned int arch_hwdom_irqs(const struct domain *d) >> { >> unsigned int n = fls(num_present_cpus()); >> >> - if ( !domid ) >> + if ( is_system_domain(d) ) >> + return PAGE_SIZE * BITS_PER_BYTE; > > System domains never reach here, because ... > >> + >> + if ( !d->domain_id ) >> n = min(n, dom0_max_vcpus()); >> n = min(nr_irqs_gsi + n * NR_DYNAMIC_VECTORS, nr_irqs); >> >> /* Bounded by the domain pirq eoi bitmap gfn. */ >> n = min_t(unsigned int, n, PAGE_SIZE * BITS_PER_BYTE); >> >> - printk("Dom%d has maximum %u PIRQs\n", domid, n); >> + printk("%pd has maximum %u PIRQs\n", d, n); >> >> return n; >> } >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c > > ... just out of context here is the system domain early exit from > domain_create(). Of course. But that's not the path I care about; this ... >> @@ -659,7 +659,7 @@ struct domain *domain_create(domid_t dom >> d->nr_pirqs = nr_static_irqs + extra_domU_irqs; >> else >> d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs >> - : arch_hwdom_irqs(domid); >> + : arch_hwdom_irqs(d); >> d->nr_pirqs = min(d->nr_pirqs, nr_irqs); >> >> radix_tree_init(&d->pirq_tree); >> @@ -771,6 +771,8 @@ struct domain *domain_create(domid_t dom >> >> void __init setup_system_domains(void) >> { >> + unsigned int n; >> + >> /* >> * Initialise our DOMID_XEN domain. >> * Any Xen-heap pages that we will allow to be mapped will have >> @@ -782,6 +784,19 @@ void __init setup_system_domains(void) >> if ( IS_ERR(dom_xen) ) >> panic("Failed to create d[XEN]: %ld\n", PTR_ERR(dom_xen)); >> >> + /* Bound-check values passed via "extra_guest_irqs=". */ >> + n = max(arch_hwdom_irqs(dom_xen), nr_static_irqs); ... is the one. >> + if ( extra_hwdom_irqs > n - nr_static_irqs ) >> + { >> + extra_hwdom_irqs = n - nr_static_irqs; >> + printk(XENLOG_WARNING "hwdom IRQs bounded to %u\n", n); >> + } >> + if ( extra_domU_irqs > max(32U, n - nr_static_irqs) ) >> + { >> + extra_domU_irqs = n - nr_static_irqs; > > Why the extra 32 here? On Arm we would warn even if the command line option wasn't used. Plus I view it as bogus to warn for any value up to the default. >> --- a/xen/include/xen/irq.h >> +++ b/xen/include/xen/irq.h >> @@ -173,8 +173,9 @@ extern irq_desc_t *pirq_spin_lock_irq_de >> >> unsigned int set_desc_affinity(struct irq_desc *, const cpumask_t *); >> >> +/* When passed a system domain, this returns the maximum permissible value. */ > > This comment is technically true, but it probably doesn't want to stay. Why not? We (now) depend on this property. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:48:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517829.803700 (Exim 4.92) (envelope-from ) id 1pjeDV-0007am-B0; Tue, 04 Apr 2023 10:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517829.803700; Tue, 04 Apr 2023 10:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjeDV-0007af-7W; Tue, 04 Apr 2023 10:48:45 +0000 Received: by outflank-mailman (input) for mailman id 517829; Tue, 04 Apr 2023 10:48:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjeDU-0007aZ-2A for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:48:44 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20604.outbound.protection.outlook.com [2a01:111:f400:fe13::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4402ac15-d2d6-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 12:48:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 10:48:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4402ac15-d2d6-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dvDvE+LdazRTMVRdDLDqwsNJxaThusd9CBiFKV57vm0UBFZmGSem9OShFD2UMBKabaw5DrqhPj6/6hqFVFHjS+fXL9LUTmdE/bpL11afEra45alD6mqKJdknys3xZqyhT9DWjC+MlvnM2dfDHCGC04wAN0KrwibaY6zjHugujdsZnnlD2bbr0Y3xHPQaSmgjPb5SrZZl3vxq4uJrtzA6z3qHBeZoeSt/lkBJf/GjOaNUnW5BPMPtjPp0gXbCa/2IGghWAMv+mcWSZyrG6xUNDaiqBVgYu9Fvb6gETdLC2UVcP+7Gbu0dxoQVrAlvhQPz6Xuj9EuZuH4wpbS7LS4NNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cf8KOdXE7psy3J1Dgd+qmWiV5099rLBr/uhBEdSFlTs=; b=GVxNefWRk1qm1V/1NQT8LdLgikIAi5APO95GVkRLFT3gnR8LjggpmiHUe2TYabjPvPufgQejJSNUPdv0usgTyIRCMLTvBGb8+WwLZpPEKv51Ff+/FM7rKUihF7Dweqa3GCBys6XZmD9fqycHY1MNQ81XiTBCh8gkslNwbU1Dby0eEINxK/hvTFDrylSNuqqQc9dnogvGXRrin21A7/qvsdf5hgyHiDjm5ZRJKOPQpxy8YOjqkYzYtROTgjY28yrvLvxcNPvlnr2j3CB9S5A7XfTks4yzj+YHDpi03lyZlTL/vRT93w1Rgt6+7233FhV76gWpvwZGoYW43xLqqD1NiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cf8KOdXE7psy3J1Dgd+qmWiV5099rLBr/uhBEdSFlTs=; b=A1TCnAEwsh0hf0EH9LSb2baIYDDAH14fym9XaVUAnrTmESFIiUyibFgGOqENld2ejHLg3RrfLGJhiJT9pcymiwi9IDeglb+JU9heJ103XorFDwLW2J/1ClB/+N8zW1mVF6LpxRbZyewDInsRc2pwlfXtbn7MurNtwm9808cMnmn45fVtKzC9sVL4nSYv2qJb61G20/Y69LtjQJSTeBQe6DHvDshz5Zo+eZt7/qzvwjCCjncRap0bEHPbvZB72xyCKxPhWk/1aAIFVX9uYmk25cfli2l4ks7yMzTTEX1br9nRMvZ6xqQZoecZ/e09UJBSDXrXvUkD/slSZFIu5lo0KQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <558b1cc5-e294-87b3-676b-68d7e55065f5@suse.com> Date: Tue, 4 Apr 2023 12:48:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86emul: correct AVX512VL+VPCLMUL test descriptions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8562:EE_ X-MS-Office365-Filtering-Correlation-Id: 982942c5-8a4e-4b0d-1967-08db34fa26ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sar9RPx4JvyedxjGsvPXmdWuQZQ8waCOZr/tki2/FKxQKZc9gDk5v+lNVpGY1H+cMlrjYN46owAlEM/1Vo5cRHQoYxabg5IF1xmZio424WDYI+CUFICkdIxTAhATqfPWg1hqW8fWW0VBEoj5aCoWAqtvndf8oZfsYcUM151nb0SY+UQ7bo2GWaIC9iGqaXA/XAGC9DjC0RbrE8WLa15o3BU/qOqnP1zLXAaGdRPKkm18TcTQkiV1PXZOJFcQRR1kkd73igW0mu9j1SwSOrLs84qCmtunjix7DvVg5pzanQbP9IL/vtS3u3OJ0dmDqvo5Rdf8iJ1Y+DRwbgV1cXfWPtvsJQaxVRDpd9cd2dh2tkelS3QUccTTRgXrGE7Bce7BumbJYdgn5D68G8CPO7M7Lr8Rj/AeMhzWQCBx2RsIYtE/CLttqBi4GqclVnPZQ3H+k/WeEEymqndpN5uRE3o9OShqZUr9WflKEJf80WMyBbtSjwYhxORy4m9U3rSanN4zbj6sEldEepPNy8elZla74SbJAShoIs57mI3gGdNiSzPnsjZL9Oz0geeeVfogKSMkdLAu/x6EnP5UY3U0tq1fcngBx4toA97iEqWjPurzwGyKN8036G/2XoMBn5f57bUbibFvzUyssOb+jadvRuUcvg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199021)(31686004)(478600001)(26005)(6512007)(6506007)(66556008)(2616005)(41300700001)(66946007)(6486002)(66476007)(6916009)(4326008)(54906003)(316002)(186003)(5660300002)(8676002)(8936002)(2906002)(38100700002)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wjg4SjR2bUdsWm1HclBPMVZ0YVUxK3dSYXFQa1R5UERXdWxrY2E1bndBQ082?= =?utf-8?B?NE1ncHhJRlNlc24vKzJrM0psc3hiZW5tWHpGOWJBVWNMbjNzVEZPUXFlVjdU?= =?utf-8?B?WmMyZlJ0anRRam01ejNodjNDZE9Fd3JVUGxWdzZCR21GajExWjlrTmpvME84?= =?utf-8?B?eHRMRHowYlU2TXk2WGJHaWpaMW5GN014dlJFUXFjdGtSaHp6TFpKSFA2c2Iy?= =?utf-8?B?TGloYjRmRVVRM2gxQzYrTnRsRXJvQ0QxWFl2b0t6S2RRdEpnVVE3QlpobjN6?= =?utf-8?B?OE0vd1dpM2RmOC92TWJ5ZUxURTI1dWE4TlNXS2QvNW1rQVJKMml6WWRzMjdz?= =?utf-8?B?TFNCeGxDNStrVG1zTkxEQ0p6SXgvcEo5Y2Y1NlhIRjRHVXBpMldqVUxwWkhV?= =?utf-8?B?UmI1T2dOc2RqZ3BvVWh2emhhZnJURkZCNytteGNpVWMxL0o2ZUNTOFUySmFO?= =?utf-8?B?M28xZUlpN3hxU2R5K25pdDBYenJOQldTSzk0WXhSV01RcTQrUXhLQ1F3SWdW?= =?utf-8?B?NWVMYUdMYXl5TjY1WHhZdDhBZ0N6Q0tCemtPSDUycnVqdUV4SDZoZjhuMzdF?= =?utf-8?B?Y0NUUkJVQmwxZXU5R2ZUNDBOYlZmN3NuMnRkcW9EUzBGalo0djFiNmlVYjdD?= =?utf-8?B?S3FzTnYybGVmZTUxQlNmd0pBMU1rQ3F1amtRdk9UaDBITkdxWk5mVVFHdElx?= =?utf-8?B?ZzEyZ0l0d0FrZ2dOc0J6cUQ2MEd3am4yc0d2aDVKcVN0RXFXU3dtcDFvTG5v?= =?utf-8?B?d0k4YW9NQU8wSmZFT09WK2F5b0N2Mm9LdmxYQ3dUUjY4SkFXTXZrT3RYdS9z?= =?utf-8?B?TTlxbi9UUHJKSlBtQUZLcDZUN1NNVzVJc1c5U1FpK3lOaitUQW92KzI5Uk1l?= =?utf-8?B?MlZZK0h3bWVzRFh4NGlVdURKcEw5cGlGUW1HMXIzQ2t0Y1lKRWVyMXRlUVBo?= =?utf-8?B?aG1RaHp5MDIvWkdEcW9rWVdsc1QrM2hCa21VQVZybDQrWFptRVA3UnRvVVVp?= =?utf-8?B?TmdLWGVOYkw1SCtiVkhjV2xTY0RON2k4b3JrMGk1Mm5jNDdDc0NRZVV2SWh5?= =?utf-8?B?Y2g1dUxrZTJPMGN1SzNBMXpJNnZidXgrT1ZDbzRRZ3JpNkxFaWE1RERyZFhG?= =?utf-8?B?Y3k2NSsrOTB0cWthSTBPWjJtMTdrU3d3WTFoR3Ric3AvQTVkK3lmSDBMd2pB?= =?utf-8?B?Vk1GZTIwSTJ6c2NlMmlaTWFBaW1uei9ic3NmUW5leElSY1ZvNEdZU0RsOHFJ?= =?utf-8?B?T2ZFTXlhaUprQWM0UHhiY1FkeExONnBZL2ZWaEVwZ29LeDVVZEMyYXo5aHI3?= =?utf-8?B?R1Ixai9QWVJDaTRaaGwydGZPVEdObTlLb1dRWC9OUVBKZXpUb0tjUEpHTG5L?= =?utf-8?B?Q2E3Sm9ObkxoRkdEMkNwWVVTTUtMM1AyY255QllFTUdtYnFpbUVodFE0NGN3?= =?utf-8?B?U0tlcWQxU05Tb3NJc2RqVkJsUFBHVWVYU1F3cHZ2Yjk2SGN5WHJZdjhhK2N0?= =?utf-8?B?eTR2NWVHeUYyVE1QYUhIc3FiQXk3VCsrTGVGKzl3TFFwczdST2VBZWxtcjlh?= =?utf-8?B?bk1mWFJBMmhIcjFXa3F5ZzJSM0lITHdQeWUvQldzWGFka2tST3lITzZ5bk1T?= =?utf-8?B?RkFPQlRXaENyQ3hkKzAwKzRpL3ZhOGxKZ3VMb0Q1d2w1aCtHSi81RGRhcWVy?= =?utf-8?B?bXI1cjJ1T0ZaRjJ0Vnc1bFNkM2pnMTBaMW44UXJQZksrOVgxaFlXdmRjeTZS?= =?utf-8?B?ZDNoaUF1V2pNOElHWlg5bHplbWNCS2hqamtGam1pWVVkZnVNd05lQXVQVUYr?= =?utf-8?B?Q3lDZWM2UXl4N3VNaUhpSEZKUDZGSGNmTE5GSmt4cG1jQUJFWDhGSlNoZTUz?= =?utf-8?B?bElkTnN5dHBTRS9tNXd6RTNESXpJeG5NeVJsc3hiK1RMUmpmaCtMQUpGTmR2?= =?utf-8?B?RlFFSmZ6K3Boa01tVFFHdlJxTTFjZ1NFdjdRZ21jaHhUUTFnWmVVdTJhc0VM?= =?utf-8?B?b2sxRVBwT2drblZ3U0pUWjJWdkYxK2xUZkVoMHdWazFQeEE1bjVMTUZBMDVX?= =?utf-8?B?TENPZzlMS016WlY4SytkRlpxUTFwMkdyWlEya2p3aGw4VW5JSmpyUWpJRDBC?= =?utf-8?Q?cVPjr/Jb2iTenlDt4GIa2OUgz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 982942c5-8a4e-4b0d-1967-08db34fa26ef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:48:40.4500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s/uTvvQ44jZuUEM0woXj3LHRAzt7Qhmo4pQJd72L7ISoPYXfuEVWRMGqUG+rah6CxHNXx+WNy+PaN/gpFCuK9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8562 The stride values (based on 32-bit element size) were wrong for these two test, yielding misleading output (especially when comparing with the test variants also involving AVX512-VBMI2). Also insert a missing blank on a nearby, related line. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -520,10 +520,10 @@ static const struct { SIMD(VAES (EVEX/x64), avx512bw_vaes, 64), AVX512VL(VL+VAES (x16), avx512bw_vaes, 16), AVX512VL(VL+VAES (x32), avx512bw_vaes, 32), - SIMD(VPCLMUL (VEX/x4), avx2_vpclmulqdq, 32), + SIMD(VPCLMUL (VEX/x4), avx2_vpclmulqdq, 32), SIMD(VPCLMUL (EVEX/x8), avx512bw_vpclmulqdq, 64), - AVX512VL(VL+VPCLMUL (x4), avx512bw_vpclmulqdq, 16), - AVX512VL(VL+VPCLMUL (x8), avx512bw_vpclmulqdq, 32), + AVX512VL(VL+VPCLMUL (x2), avx512bw_vpclmulqdq, 16), + AVX512VL(VL+VPCLMUL (x4), avx512bw_vpclmulqdq, 32), SIMD(AVX512_VBMI2+VPCLMUL (x8), avx512vbmi2_vpclmulqdq, 64), AVX512VL(_VBMI2+VL+VPCLMUL (x2), avx512vbmi2_vpclmulqdq, 16), AVX512VL(_VBMI2+VL+VPCLMUL (x4), avx512vbmi2_vpclmulqdq, 32), From xen-devel-bounces@lists.xenproject.org Tue Apr 04 10:58:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 10:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517832.803710 (Exim 4.92) (envelope-from ) id 1pjeMs-0000de-7Y; Tue, 04 Apr 2023 10:58:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517832.803710; Tue, 04 Apr 2023 10:58:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjeMs-0000dX-4g; Tue, 04 Apr 2023 10:58:26 +0000 Received: by outflank-mailman (input) for mailman id 517832; Tue, 04 Apr 2023 10:58:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjeMq-0000dR-K6 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 10:58:24 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c79f845-d2d7-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 12:58:21 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 06:58:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5201.namprd03.prod.outlook.com (2603:10b6:a03:221::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 10:58:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 10:58:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c79f845-d2d7-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680605901; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=4mz0unXIACTtoxSLUL21K62e6alLo+uDYC9SUOBOSVI=; b=WCAxC+yuCPKtvtaXw+LgQ8tKUva5Hu1DgmGTk5LzNJ/H1AAPW0ES0KOP Ph83nMh6pqvyv/QeVt1H6xiFDHTnddmDWUwJkjiCVcefZRB8yHN/bBS0c reM3y1fMVa1D3OUGl+D6HIeSRFPdEL7YKUSgHPto5VVZJFWcyY0gZDQhY 4=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 106678214 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:D0pY9KBwgkrLAhVW/wXiw5YqxClBgxIJ4kV8jS/XYbTApDwl1DMGn 2FMC2vUaKrea2P1ftp0Ooy1/BtU65LUnYJqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw9P0nOEtHp PgjLC0hSiGuuMSOzq2jVbw57igjBJGD0II3nFhFlGmcIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuuzO7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXw32kCNhLSNVU8NZUx2Gj9kEsVCc0anGlhPiJkl/uasJ2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBQQ5b5dDm+dk3lkiWFo0lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9b1gbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:SrPFtqpjmyfz4juBdpEtU2saV5oaeYIsimQD101hICG9E/b1qy nKpp8mPHDP5wr5NEtPpTnEAtjlfZq/z/5ICPgqXItKNTOO0AHEEGgh1/qB/9SKIVycygcy79 YHT4FOTPH2EFhmnYLbzWCDYq8dKFHrytHMuQ4G9QYLcT1X X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="106678214" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CasEe4vu2Md6j80QG3j8w/nIChUVnmf6vVuLsqlAOcktGSfY1CD/4zk4eHTqL6Mp9Tx0AyKSDMt3m0gIuNiGYuwTMDgYw4KfC7l7dMTCuGM41HWt7BRB5xIQA/2+41IEqN1pxzAXAA6tE1fthjunE2jyyAUGmYUl0u4M9PBY440DYSx6jz22pk+yYHFa7dw7yctg8PRUcQSTS1pg+zod6FSgDBQMoiIRYzg7QSatNRDN+pUF8wZLW99DIv0JwBgdY+KW0+Cqs73oMq92n5vEqiEm2DVFcjnGSvkcSCxkV0LuFxNoZi2roW+SNEvN7Bn4p4dUekNHqK1lgjocsOwwIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4mz0unXIACTtoxSLUL21K62e6alLo+uDYC9SUOBOSVI=; b=FPe4ZsdLxNtXl1RM2Yivnwf0x1LIVmmCBEiausksS6aJTvIedegfIBuhql6qqSfpzv3PAH5rtxliaKVmjjnnM11DLJ6ERWIftWPNoGUJ/itL0HL1+clRymP9u1LTsANadtRdxtdrvzEJ5CxrPSFVUhH5qJXbOPQ1AfQZYz4WPgbUpgmGZUy1eX13nYr9RvF9BEj/blZRGXBUvQYe3omXLYJ1RGDjFdGSL3o+7dOsvlY/rrb0uvMkPQ3iYEyiMvfVbsBI0ArUZ4DuAhgW7EFcDd6kNYKlJEcSLBmnXPultw180JWyq6HW36+1xviWodLp4b5USkmY7n+M7AL3FgjEWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4mz0unXIACTtoxSLUL21K62e6alLo+uDYC9SUOBOSVI=; b=g/gLeAZISZkMpECLErU/rp6ertcTiki+RNslpVG0oAO/YH7n+1KITBOZPKyZMljQL2BrtXg2/4xsstJoI6/eemNru26C9M6DwIHgDMeExDiZVV9DTYzcRGCOekTYJsq77bbkx+4mBPAhxbxEblBEdqBWCjUatr0c91KzkUCtbsw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3d5c84c4-d7f4-57ba-ef0e-b190ccadae14@citrix.com> Date: Tue, 4 Apr 2023 11:57:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86emul: correct AVX512VL+VPCLMUL test descriptions Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <558b1cc5-e294-87b3-676b-68d7e55065f5@suse.com> In-Reply-To: <558b1cc5-e294-87b3-676b-68d7e55065f5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0141.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5201:EE_ X-MS-Office365-Filtering-Correlation-Id: f4ddafc0-02ef-4a3f-7178-08db34fb75d3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tz77qLQlSePRymeXuCOTy7zKlvONRckHqyqkz+OfPRsDzYLYxBT7xSqsnSrY0iVFHAntNQlPmHkAQGMTMO4TnTK0NHR1bUXUsqni1ait+G5zTP8iZ/wiK/XkWtWMCPg4srFURy7LNhcB2ArslaNWyTxdwSVAmiTzfY8F1dKQ7iOfu+r8nbGI3WcCBh3KkxiYhiZSu4/N88+LxjHey5uQBCiedf7mMzmYKHMS8BQ7zhoO1mz/dHxUVXbQLpkkhMc0Wio9Jfd/VgPYGZEk2jwLRAqQBez3mg47EEKcllcey9uUWRdzjxdKtHBt339MVOHavRSmw0BqdPIC2UvV5+0dioLzuZIUB64gKaZR0q61fF9P7FKCIU5ap3RpnHwsRCcz3ovApDz1tw0DJAaCZjzmn7i4AwQb6nu1/IZ3yT2scSqwDPLaHxClqHhAKyVaKW2TIZgzf9M0tek2MdvarU6yAenh4ijsgRxR8MaThhnWl/cmM5DCQj+1C3g2yMVhcaLWLQy3Rw1XXoCiIED2+6g6mQH7ejNFMnf6qhMZg+GOLrt6zOKkaL5E10CTJcxdCpppzBNRs3fQ+p2Z706T6PrbvxW3qhG/vi1ELVr7FECcF6kWW+M/QjDzChid0Ci+aUwhZ/lGob3hpZYbWEKg9A5ChA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(451199021)(186003)(6666004)(26005)(107886003)(53546011)(6506007)(41300700001)(4326008)(82960400001)(2616005)(6512007)(316002)(478600001)(66476007)(66946007)(110136005)(54906003)(38100700002)(8676002)(6486002)(66556008)(36756003)(86362001)(31696002)(2906002)(4744005)(8936002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjE4aEdEN0RQWnJlSHp6aDlQSy9ucFdlcC9hbzVxQ2ZNQnNMNmt5RXJubXNi?= =?utf-8?B?RUpnVkducU13WTYwUnh6ZnhQc1V2WktaZjMvYmZNbzJhUFBYMWM1aGErOXB4?= =?utf-8?B?ZGNCRkFrUUg5bW1EWnFHeDZFMEVpQk9uTWpKUFM4VjJnRnl5akJPWUZSWjBN?= =?utf-8?B?QmNuK0NSUFk2TVF0cC90S3QwM3ZZdHFnWUlTb0Q2a0Vob29hRVI5cTdjOSs0?= =?utf-8?B?MURETWxpVXlUR1N0YW96Um5ka0pBTEsrZ1VydTM5d1V2RjQxQXJETGRrYTVn?= =?utf-8?B?SW96V1JHcVlRQXRVbDlOblpqUU95L3c5ZlFBZ1M5SUxpRjJ3dU9vTVVsUWFY?= =?utf-8?B?Y1l2Y2FnMmxLZEpJQS9rL3NJZWZFZEJPOG1LaGk4RWI2Umd5dEoveStxWUow?= =?utf-8?B?ZlNFR21GNmxqSnFFWUJVSWZSRDVHTXJjeHMvekZUZW5qd2NlSWhBaEtjb25I?= =?utf-8?B?eFdrd3JpUjlYSk9QcXE4TWswSkJLcm9yWGp4Y2VxN3UwUlgzYVpkRlVmaVE4?= =?utf-8?B?MjJFSXhxK0Yzc0ZiT0RHajltMDFTUmliWVIrTUh3WjlRcnpHWlBrOHV5dnJC?= =?utf-8?B?NHhtc3M4MHBsb2wvams5TG1WeU45eWYwaHF5WnFwWFRWYzA4ZGUzbEJvMWVj?= =?utf-8?B?bEFxYnRXTXZCT2NpZlZuazU4V212TXFvdmVjSWxROVVOZVJSZWlaSDNRL1lw?= =?utf-8?B?RzFJRjQxMlBZTVhxZXlORkFwNEpUNzh3bjBrK2dXdENYMU1mUHNKT0RWa2p3?= =?utf-8?B?M254bnUzWnU1UTFzWXJRN3FlaHRSVGx0OEpKbHROM3hyaGVxTVVZeFdKRzVh?= =?utf-8?B?RzlmS29ESUZDSGlrVFY2QlMyZXdaVnBnTktGdlp4R01JcmVOYjRNREZnMTJM?= =?utf-8?B?Vk9CYnV6RFdib08rRXc0NWRuVlZQa1JzWHdxNjZ6cWhBMS9Ha0xxZjBSbjly?= =?utf-8?B?bjRoRnpXTm5HeERBbjRyejYxOUxpekZHVnQ1ZElWck9mRXVsbVcyTEEvUnlq?= =?utf-8?B?WkdhTXA0SEpia0pVTTRHQkRuell5b0c4TWV1L2tWNDhqUU1aeFA4SWVBdVJ0?= =?utf-8?B?K2tDUjhkRENpWmU1dGVPOXpxRk40bWpNNjBrdGVPaVFPNXNLeTlzNDZRNUtQ?= =?utf-8?B?TVVTc0RMOWx6QnlqVmEyN2NvWWtCQ3dkL0N0N2thTDRXdFVIYVZkdmNpNzYw?= =?utf-8?B?L3pBOXRlZHBOZlRjcExqSjFKWnhxT3dpbUhtU1N4bGxMZi9FQ05KL0RQYk9O?= =?utf-8?B?SEhrcFVkTExOdU9zeWFhZEZRSXBCamhjWFlvWFB2N2k4SWlORUFIN3IwQ3pP?= =?utf-8?B?ay9EMzJrS1J4cUQ4ZjRYa0c0eDdoOVU0dnRKMFhjcFZGTnY3L3NCbGRXRFZh?= =?utf-8?B?dERGV2psbU5Va01IZ0d5OUpEMWdJbkFCNFBYWW4rUXdXLzdyY1pHRFFVTU9L?= =?utf-8?B?WlBUQ0lISkI5NWx6a2V0NGM0aDFWMk5ITlBTcWxkbnpRQ3ZtVGtVekdJNmhX?= =?utf-8?B?Z1lVQlBkVHFKZG5lTUk2dzdLK3Z2bzJ4a21PaXNtV3NKcG9JWGd6emtDVzRs?= =?utf-8?B?SFpyYjZZSUZmRUY2ZzVGSkp0OGFXaDcxMTlaU09Kbm1SSEkyNkNDOUlaMWRF?= =?utf-8?B?QzlCOFZFeFR5NFVQSTdDcVF0UnVqQTg2R2Y4bEtxbnFpUitVazZrTU5IQ2hx?= =?utf-8?B?aVNtLyszOW9ZbzFibTZFb1p0NE0xeWwwbWY3bStZdmcycGpvMVpNU3A1WTl3?= =?utf-8?B?WVFpV0pMSVhHMk5rRzdoODNXdXJKZlU5eW1MUmpWQVU4MmF3cG9LR0VuZGtI?= =?utf-8?B?Y1dRL3RnV29VMk1Wb3JXOTFYdkVmKytjMnhTTlJBZW9QVzk0QmZYR3RLK3hU?= =?utf-8?B?TC93YnpZTDlKNnFGL2kvSXFqcytETFVnam9IRk0wYTdaNFg1MW5rRys4cFA4?= =?utf-8?B?VWNwYTFEOW9taXliVTQ4QVQ3cEFJU0pza0szUHNScDdLdzR4Y0l0TGtMMDBs?= =?utf-8?B?cCswYXo3c2Fia1NrTG1lMFZMT01lWUdEcVpZNllnMXNFMEdmVnE3eHk1VG5n?= =?utf-8?B?NUswMmZSR1ZxR0lmK0loTnMrMytXdFpJeVV5V0ErWkpOS2hmZVZXS1NmN29u?= =?utf-8?B?eElpOWJrNWVzckVncnR2VTBKakZCR3pMVnBxTVE5aWt3ZDRGRS9mcDdocmov?= =?utf-8?B?bmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gUPU5qttekrMU/QjceW2KvO730NOTg5IQL0bQ0knQtQiF5rPNYL0+8e2JhwuIa51WEeYnKDyfEp0kRTgR5vRR+UU7vWxWE5d6y+CljRVPhgiL9ulKLSsoHTM06fpPOrxTLS49WlqA32quQb/ft73DGU1vnKA0alb17dba04aWdG6F8hyg7ooVdLLmxSOBCaozz6QEB8BkZCID6BQnY2S+9gxSUPexuvXw+xaqrg9eMiZid4BYxksnjWhpOCNCI8xKFnI4i8cnvj6sp3wscE+fMv+2gh4vSBJftdJszhyIyZ91mKO0zz7YydzLDfWF35eKWj5TezAomowkaP7bHDJJ6h8g5DfiKVSKSZfZAOroO5vEmgFVzO7c05FBQNHaPr0C070Z5WsfUz/0AAZhJ3+5GeZ22gC1BwrPWaLg3uaAQYGs6sINUaCuhVvex3m+h6OgGAIZgpCyRrxx5YpJKd5tHF6dd+4mAj1pHTMoJxKuuhdAznRnrKmFHxQaJDbzePoXtD8tYw+5BdRN0pqrA41HEEncAdD8tG+QrPdA9W2sQsbAI5Zx/3rIEyHoiBbRIaxaVedeu7vNlCEWwiQLMx90u3R3qTkMRMPBSCp+rLUnwuf5621uQfyGdX9zvPW8pcnU+/JU+W7KH76l0dR5QpEltQasKZbm8ErKC5BTcaYwzSQSo1sn3rA7ttKvYZRGNdBRCA0Lz6TPx1N3xrRRwdWGpd75fC7GaXcsYK5agDMzyBg/yA8TWT1Z4zVqKKZ2LFcvHYY3SttoPNxKkjpnYn458pD0W4SHiE0/1e+SEOplLZGhG2ptE7zLOLbGsNe9XDF X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4ddafc0-02ef-4a3f-7178-08db34fb75d3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 10:58:02.5100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AkX+JXjAxbyiEfKPxqo3kqf4axYI8eoRr8/CGBdQSmIVluUCwxwfRlP5Vb6XG6lM/WE7KzlKq6HuXKUJmohMz4JC4VBZoEG6E9NvqJy5VPw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5201 On 04/04/2023 11:48 am, Jan Beulich wrote: > The stride values (based on 32-bit element size) were wrong for these > two test, yielding misleading output (especially when comparing with the > test variants also involving AVX512-VBMI2). > > Also insert a missing blank on a nearby, related line. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Apr 04 11:41:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 11:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517836.803721 (Exim 4.92) (envelope-from ) id 1pjf2Z-0005o6-AY; Tue, 04 Apr 2023 11:41:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517836.803721; Tue, 04 Apr 2023 11:41:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjf2Z-0005nz-4s; Tue, 04 Apr 2023 11:41:31 +0000 Received: by outflank-mailman (input) for mailman id 517836; Tue, 04 Apr 2023 11:41:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjf2X-0005nt-4E for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 11:41:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f7f29a8-d2dd-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 13:41:24 +0200 (CEST) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 07:41:18 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5247.namprd03.prod.outlook.com (2603:10b6:208:19f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 11:41:16 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 11:41:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f7f29a8-d2dd-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680608484; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Z59NWup1eQF6ib+PLgar8cI684KTkUwJrqiiGycw+Pc=; b=GDvwjNXyFmFJ6mJpTClHcLZW718vNMCM/oqdm0dZVlHqyLxKj55HR7ND Ar/PpVX+WdfdEhCucsSjnjhIa9LHSkGgugM0uzz5fGLzZi21hwk3dhSDI j/YkPldIR3IK5txbbH9xRuuChvjKyzLqY//SLuFyGrvJbEL19bd086umk A=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 103050501 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:y4RQHKJgPhJmM7mkFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENSg2RVz DdOUT2GOa7eZ2L3KNwlO9i3/UwDvJSDm9BjQVZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5IImh0z NJGFgohME7a3PCa/OPieu9z05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMlWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv03beSxX6jAer+EpW4qvp2m0+/21ciJxwcVUaLkb6wlX+HDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSNrmK2YTzSa7Lj8kN+pES0cLGtHaSpaSwIAuoDnuNtq0UuJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:gQ5mNq8Q1aYoegUPY11uk+Fbdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcKO7SdK9qBLnhNZICOwqUYtKMzOW3FdAQLsC0WKm+UyYJ8SczJ8X6U 4DSdkYNDSYNzET4qjHCUuDYrAdKbK8gcOVbJLlvhJQpHZRGsNdBmlCajqzIwlTfk1rFJA5HJ 2T6o5svDy7Y0kaacy9Gz0sQ/XDj8ejruOqXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU DYjg3C4Lm5uf3T8G6R64aT1eUYpDLS8KoDOCW+sLlUFtwqsHfqWG1VYczNgNnympDs1L9lqq iIn/5qBbUP15qYRBDInTLdny3t1ysv7Xj5oGXo+0cL5/aJDg7SQvAx+r5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa4XZcjEBS5NL7tUYvJbc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcF0gbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xN/efGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzvekPcV T6ISBlXEIJCjLT4Je1reN2Gzj2MRSAYQg= X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103050501" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZC03thCXRgw54az2y05hx8DexSyGUvMa9mH7mgU5GD5pMa9WSAH5QD7eXUzhXLAu42AhVp6dOfvCqZjjUz3TEAjFrSrmsZ8QBx6chYyjj+704kZXWACEFS30nb7s9dLg1QEnUpnDUHkcuawqC7Fq+RGUjdqmH9ge+ENNk6nnM8RM74DvD3qUN9KP7GsFIdHx6j3knDVJKWsdAdHK/yJx0BPiMh6IIkP1rDcN3SOM/ODnNQy+ielhcpXWp3r4rdPLY9s2kSo7tJTYGuoh/6jW/fkmcojD0e3ctCaFtArqbRBdOGsx6e9ZZ9L1ukog3mv3yzasPlT2Apibq3t+CKASQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bvN/doML6DAbPVu6JvfmZv122kJ+JIPSdwlwdDpfzbY=; b=M83JZd9I95AlpR5Fu+1nMf9H85bxtQSejGxqA52iygrwmCWp4Hy7SMkN/cYaz/IIk6XRxCrzyobgabpdhm8AFX6RQhpgkJp0iZD6NQesAA6qEsjlkMoV6tbS0mSDy6GFd3NxfaM1et/KIk4G+j0bsSiWx/iMRBj2AvGhWUCecphynh7LBZmK4U2oTgArpNyzBbNuMd0R7s4Lr8FwdqrGBQjkOIMM0fVHhzepeUhdOM1WWkK8ursXUjXkPe//zwH/M6AwtMWBR9ROSHQxiYipkBr+w4eJdQb7bmfGd7NcqaC6d9YSsFqUHwDmUuafjS/XYCcqU8XYMIVVQl4uY49E6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bvN/doML6DAbPVu6JvfmZv122kJ+JIPSdwlwdDpfzbY=; b=mFCXZv7rqiuiC3swS/1monEZnzTlJKpo9QUuHAO/lQHbhI15mS3uON1zNIk4G65Yfh0+aH5LzPKSpcEQip9/nKO8o9oNpAubDI3kMz8Q9j7VMqwUX9LegoGDgg9Tzb6BXcxXAcdxTZc8A8H0oyj2L/tjYfeivRfUxkTGIdOdzi8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 13:41:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Message-ID: References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> X-ClientProxiedBy: LO4P265CA0240.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5247:EE_ X-MS-Office365-Filtering-Correlation-Id: 8068abbe-50bd-40d5-b06b-08db35017f97 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 858fYNEfiy97ZGDd4P+a5DfygRFDmLshKtppaA93nOi970XsU6APLuXXvbEUY7h0vHddFMfPkzou0dk0oXK50KhM2sMl/L/qYDSdcjbEkTOI68kfeo86Q4y/4omBymJZGhtOh0EjKtQWxb9xP4QoMbubz/J1617zu7rNuVf6jNk0iMJqtR+spHZqgKOEfHlmdNyx1b9YB4CnCSFAbNXL/FfTyN9v4YGGkkmSszZ0Xhz/1NtHRgMraVq4cWA6VjJfbZ1gRtWcJEvJvFTKN2/OuM5Y3sWh3iCv1yUIB9i2Jyja/7ivoMfmD48u2en2Rr5AF1XbQaC4zMtar+oJpn7qbXUqotm0R/34azoEeZi+U4O6JmZwYGJKzwO7gyPi3rQsXlUUjIt3lyzlvr4V9uOSBsyDOWWYjZ2tWyefnWtrPn0DxV28rxQPdPaEMDEiA8K/Kne4PXkCnQSX4clUkVliDwFp1JQ+WR+vs3iGXiUYmHG3ekcAJwCpdumhzNsYc+VKfoVixwVNXdUP+FRVXcbA8XSx6zuZNX74o85hjmUDRpw4JI/U4V/qNIsA4P3BRJK7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(451199021)(4326008)(66476007)(66556008)(66946007)(8676002)(54906003)(5660300002)(316002)(6916009)(8936002)(478600001)(82960400001)(41300700001)(38100700002)(186003)(53546011)(83380400001)(6486002)(6666004)(9686003)(6512007)(26005)(6506007)(86362001)(85182001)(33716001)(2906002)(66899021);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1FkUWY0MW1iWGpxeUI4OXVhRGhKUTkrdURsWnd2ZjNlU2pQbS9YSHVad21x?= =?utf-8?B?WS8zdVMydUVwNmNKMlpIRUF0QXJVMG9wTlBEM2oxKys1a3VaejVROVErNzRX?= =?utf-8?B?dmxEVzR2Zys1SjhwUEtJSCs2V2c0MkdtZ1NJTFFQT0Y2TENsTlUvbHpzOTNw?= =?utf-8?B?U0VUdXRBTFZLVjFDNjUxMU1HVW9uQVBwMnhCZkl0U0xNVkdwRXZ0eTFLcVVH?= =?utf-8?B?NFJMSWU2NzJTbmFCcmdUWGVxV0s3S0JuSWhnaTNyVkk3OHlCNDM2ckZ3MEFS?= =?utf-8?B?VTJGOU4xU2tOcVpEaW5EcCs0OHRlV0ZRQ0RESmZQVENoS2ZkYmZkYXcvRjBv?= =?utf-8?B?Y0x5ZFBFOFVPUDIrV0o4aW5oaHhZb1dwQUtZQ0ZpR2VwNjJiSXJQMm03UEhU?= =?utf-8?B?a3JzYnlFa2dPNnhyZXFJUTF6aUtCYU9GYVdHdTd3MWw5d0YvTjdPdW11Nng1?= =?utf-8?B?VzROV3hTeW5VZmJRNVgyc2wyK2pJaCtEdUg2NVVzTkVLM1d0a240Lys5T1lK?= =?utf-8?B?cDF0cC9LWjdndStPNEhHV1NYN3ZBRy9jTlBNSEdTSmwzMjh4M09ya2orM2lX?= =?utf-8?B?di82cHVUWWJTeFpBOVhMRjBDZFFSbko5Ti9oR3lVdjFEVlBBVFJZdVU3aXYy?= =?utf-8?B?cC8rWGVCRTZ6S083b0pKUHIzVnRDKzBnSFhiYkpxZWs1Ykh0aGU2SWw4cXhJ?= =?utf-8?B?OW4zTDQxb1RDUld3OGsyekFzblVMSDg5THd4T2h3U1VZRGVVeUJobmFxUkRS?= =?utf-8?B?em0rdThRVjV0cU9td0JRNzgrS29meEVrRjBEblhlUGdmbElleEl4WmJNbXFo?= =?utf-8?B?SU1xRHBQZmxxZmk3cnZHdm95VS9qSW1XTGx2aU9BWjBvNlFLVThibUU5Y1Zm?= =?utf-8?B?NmpOL1QvWitldTdLenFpcE85YTl0U1VvWE83MXhtZVFqZzQ3LzlWWGoya2Fk?= =?utf-8?B?SlJmYkRsaG9IdDliMWdnUW9IZWpkNG04WHVNNlRQWU91c01neFdkMUFSS1pJ?= =?utf-8?B?V2pEUWJkb25JWjY2ZU9FNm9wUW5TcG1ndGdzd3krcHd0d0hVSjByRFZNbmZa?= =?utf-8?B?NWlsWGp3MVl5b0xvNm55eW9GSVc3SkQxSC9RMXBUeS9wZTdKZDh3Y3pNcFFS?= =?utf-8?B?eml1OG4rQ0hacjRwU1hWcVhwOXpnZUh2VWZGL2xSTDYvamhna0QzTnkyN3d6?= =?utf-8?B?YXB6VVlTUUJWVk1UVzdvSHBBWWpjWWtjeHRSUFhtdEpWU0RxNkN2cGFXQ0hv?= =?utf-8?B?alFKdHNFU0cwc0xUVDU2dFh5cEh1d0NZazhXRktlUmhLMk1QallZNTF5K3NF?= =?utf-8?B?MFY5OVNnL1dSWFFjeldXV3p5aHVyUFJkSWJGNUYxUmxITVZiNUJTdHJmQlh1?= =?utf-8?B?NkVrbTNzYU9PRm9BaVJSS0Yva0Q3NDVOZVo1dGYzbGhsYm1hN2FWdWpmS3hq?= =?utf-8?B?MFNiZ0JnNWxkYlVRUW5DcGdLa0JMOXhsS2o2TS9iTlZsKy95akh1UjFidmpH?= =?utf-8?B?dEFPaFVBdDRCSDRHbGtRNWRFQ29aeFZhbWYrWkEraUtwNm9BSnk4K0pLRERD?= =?utf-8?B?c2FVYzFBT3crVUxkUXNEKzRxbSsvYzg1OGZ5bGE0b3ZVUkNrVUtrdTcyUXYv?= =?utf-8?B?eWtjNERkRG5PazYwVVJYVW9WTTJaQ3BOczc0dW5wSUFaSkhDdUMrVWtKcksx?= =?utf-8?B?VXhFeWkwOWJyNFBwQk1tZ3hoQ3ZqQnBlMllBSjNvRndFNTVmaGdpTTkrM0Jx?= =?utf-8?B?Z0lyUVhlVkJNTWExN3FGWC9xbStEQW80clhVQnprMDRFKzRvQTBRMkZoQ2ZX?= =?utf-8?B?bVJIa1Y2eTJ4SmIvQUR0MVRuRk8vMkhFSjg3T0M3Tys2K2lKak96blJsNmcy?= =?utf-8?B?azlKdk9yMll3MVltcDZ6VVBxdlFMaVk4a2ZDR0JFMjVsUDNqcEFvdGU3Q3pt?= =?utf-8?B?Q2JMeWVSQTRoUjBtNnRVcjAyeXlheFI2a2lIZjRKb2N3WjRCcHI1aThYZ0N2?= =?utf-8?B?UXJhZUwyNngxNE9VaWNCTGJSUHoyZkllZitBRjNVclRWcExibHpmeTU1bGdK?= =?utf-8?B?ZHpQOEd6RzhTWkduYTRyQ1pkbHNzMktidjVRdzlzbGs2SGd0c1M1L0FHOU0x?= =?utf-8?Q?j23LQcu1Fw92yh5zaVJtH2x/L?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0FBcI7CAwrmmErj4MQLs1FI2hiWNbaVlZBbn5XoX7iBrL27WkAnYsLzB/N3hFebsbvFZg9+2BxSJupSLGCUjFtXAeupyEUFaThE5Zg4mZ/qDgrG+XHLksI0bN8AmBgwgzZNtR+6/k5iIqTKfA7jB9KnWP2/cuefvz+Xkn0ASueV3KQoarPjme8TVaWhyg/tMtlsG4+5Dnnkj6OqlvtaEV35GSYrH1pU4TJ3X55JnxZL/TxESsKSHxhhrc2JPjsHb3tCj1V6v+vBJqkHSmYbdCXUor5Erv4mMGn+NprDXeoPvX1FkznfAiw9KiaarRQrC+op6jjJW3u7MUtFrAT2z40aL6vNNSgaT3dKcX7DZi0xW2UL/Y2VnyWM6kQM4g04EWXmgsrNTK7tzBRgGD+tX/rIEeABUhGniWl2D+TCeXPaFxmiJnKEjtAIU73bUu2w+KZurXmihTTayi4RRgmW37dEjipR3rnw00d7JQ8ysEAW9cBKyPQAcANb5NQnLDJ8PVF6rs5bliimP3vry6e9dW5OmTH4gIonNLdK/1VpaxTquT6oP90H6EYEKcqRYjPmr2AwVtY2k/wgvVxGMJ5WXmUuXO4PnK4+ZmgzJw3j+oB2ZLBFoPbMzJNTQNf7Xcbq9qbM38XFB6acO+tCu6Mdn0jxGgGxo2I3EGdl1MbcZkan7N1vy845URXl0nkYduf5ep0JukXltxYqhTH5/ZPzKoHjpOTCR5b9WNva90s0shg1VPVS7x1uk5ZoJYIyi07Sn9/5U0Y3l6SnRi0PhqfmhWgCi6ByBsuMIq8ZZwgi5AOYKxihNp44QWv8ADAxJgs5v X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8068abbe-50bd-40d5-b06b-08db35017f97 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 11:41:15.6901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xpIW4ULc3Z7MUY9IPGv4R0RFiNMGZV9TbxxrqYxbu4IpwkxREJoM/xUmC/DqWX7Qbf32e3/VIxOQN29yoACZug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5247 On Tue, Apr 04, 2023 at 12:31:31PM +0200, Jan Beulich wrote: > On 04.04.2023 12:12, Roger Pau Monné wrote: > > On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: > >> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still > >> applies to guests also when run on a 64-bit hypervisor: The "extended > >> CR3" format has to be used there as well, to fit the address in the only > >> 32-bit wide register there. As a result it was a mistake that the check > >> was never enabled for that case, and was then mistakenly deleted in the > >> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume > >> CONFIG_PAGING_LEVELS==4"]). > >> > >> Similarly during Dom0 construction kernel awareness needs to be taken > >> into account, and respective code was again mistakenly never enabled for > >> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by > >> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). > >> > >> At the same time restrict enabling of the assist for Dom0 to just the > >> 32-bit case. Furthermore there's no need for an atomic update there. > >> > >> Signed-off-by: Jan Beulich > >> --- > >> I was uncertain whether to add a check to the CR3 guest read path, > >> raising e.g. #GP(0) when the value read wouldn't fit but also may not > >> be converted to "extended" format (overflow is possible there in > >> principle because of the control tools "slack" in promote_l3_table()). > >> > >> In that context I was puzzled to find no check on the CR3 guest write > >> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any > >> of the low reserved ones) could observe anomalous behavior rather than > >> plain failure. > >> > >> As to a Fixes: tag - it's pretty unclear which of the many original > >> 32-on-64 changes to blame. I don't think the two cited commits should > >> be referenced there, as they didn't break anything that wasn't already > >> broken. > >> > >> --- a/xen/arch/x86/mm.c > >> +++ b/xen/arch/x86/mm.c > >> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ > >> unsigned int partial_flags = page->partial_flags; > >> l3_pgentry_t l3e = l3e_empty(); > >> > >> + /* > >> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not > >> + * understand the weird 'extended cr3' format for dealing with high-order > >> + * address bits. We cut some slack for control tools (before vcpu0 is > >> + * initialised). > > > > Don't we then need some check in the vCPU init path to assure that the > > cr3 is < 32bits if we allow those to initially be set? > > > > Or will the initialization unconditionally overwrite any previous cr3 > > value? > > That's not the way I understand this "cut some slack". Instead I read it > to be meant to cover for the VM-assist bit not being set, yet. Beyond > that it is assumed to be tool stack's responsibility to constrain > addresses suitably. If it doesn't, it'll simply break the guest. (There > is some guessing on my part involved here, as the original introduction > of that code didn't further explain things.) If it's just the guest that's broken I would think it's fine. As long as such mismatch doesn't cause issues in the hypervisor internal state. Did you see a toolstack setting such entries before pae_extended_cr3 is set? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:07:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517844.803730 (Exim 4.92) (envelope-from ) id 1pjgNU-0005iV-Jq; Tue, 04 Apr 2023 13:07:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517844.803730; Tue, 04 Apr 2023 13:07:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgNU-0005iO-Gw; Tue, 04 Apr 2023 13:07:12 +0000 Received: by outflank-mailman (input) for mailman id 517844; Tue, 04 Apr 2023 13:07:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgNT-0005iI-7p for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:07:11 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ac532a6-d2e9-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:07:09 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-342-aEEHYlrtMj-0qGW-NiOQLQ-1; Tue, 04 Apr 2023 09:07:02 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8CE59101A54F; Tue, 4 Apr 2023 13:07:01 +0000 (UTC) Received: from localhost (unknown [10.39.194.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DFB4440BC; Tue, 4 Apr 2023 13:07:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ac532a6-d2e9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680613628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oHqf0BVn2cr4iUWHULKZ+lPM/LaK6kyDq2wLGk1dnWI=; b=N5XFXZU8AK5znY3a3LiDnV5C4UIohAhrK99Ia21wBSIh4FlIQzeEfbTqLwpqnG/D5Xp18b uw0MYWXlRdxTUn1jQw2Kp6Vqn/FjOPrJA9xMizsiPYyFxZ0h5ah+uEo0ETQIgh05k3MLqt ArncaLxKJ1Hyaso00fg/HEF+YI/bxS0= X-MC-Unique: aEEHYlrtMj-0qGW-NiOQLQ-1 Date: Tue, 4 Apr 2023 09:06:58 -0400 From: Stefan Hajnoczi To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Anthony Perard Subject: Re: [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event Message-ID: <20230404130658.GG428487@fedora> References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-2-stefanha@redhat.com> <2bbe988c-0802-55c3-b2a3-05e3f94e2f04@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a21Ii3lSZbeXw64P" Content-Disposition: inline In-Reply-To: <2bbe988c-0802-55c3-b2a3-05e3f94e2f04@linaro.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 --a21Ii3lSZbeXw64P Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2023 at 10:47:11PM +0200, Philippe Mathieu-Daud=E9 wrote: > On 3/4/23 20:29, Stefan Hajnoczi wrote: > > Only report a transport reset event to the guest after the SCSIDevice > > has been unrealized by qdev_simple_device_unplug_cb(). > >=20 > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field > > to false so that scsi_device_find/get() no longer see it. > >=20 > > scsi_target_emulate_report_luns() also needs to be updated to filter out > > SCSIDevices that are unrealized. > >=20 > > These changes ensure that the guest driver does not see the SCSIDevice > > that's being unplugged if it responds very quickly to the transport > > reset event. > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > hw/scsi/scsi-bus.c | 3 ++- > > hw/scsi/virtio-scsi.c | 18 +++++++++--------- > > 2 files changed, 11 insertions(+), 10 deletions(-) > >=20 > > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > > index c97176110c..f9bd064833 100644 > > --- a/hw/scsi/scsi-bus.c > > +++ b/hw/scsi/scsi-bus.c > > @@ -487,7 +487,8 @@ static bool scsi_target_emulate_report_luns(SCSITar= getReq *r) > > DeviceState *qdev =3D kid->child; > > SCSIDevice *dev =3D SCSI_DEVICE(qdev); > > - if (dev->channel =3D=3D channel && dev->id =3D=3D id && de= v->lun !=3D 0) { > > + if (dev->channel =3D=3D channel && dev->id =3D=3D id && de= v->lun !=3D 0 && > > + qatomic_load_acquire(&dev->qdev.realized)) { >=20 > Would this be more useful as a qdev_is_realized() helper? Yes. There are no other users, but I think a helper makes sense. Stefan --a21Ii3lSZbeXw64P Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmQsIPIACgkQnKSrs4Gr c8iK9gf/TFi/RWboEn8yEQ4zpL0td9Nd4+0XYH85P9acscF+6TcA+W70ehstRChY twRsDr7bNxiglT+w01MBLdladQFM/J7c58OUZQ9OdEgkhFY1iP3DEIod+7sHIb/D kkxW8D3uzTtzVRBGt+bIiFI44sBkukGcHVSrIyk3Rc57amd0T9ceSmGuXanmq0sp kOpaQ/yt4dmAACGfJfcBYXfQE9QMr465W/YJQDjH+wrT49e9SkDbgw3MYjo6zYcm BTH9t6XKAHp8b7OKZ8F8ibkALAXU553zogaq2j5Qlra0fzk/PsgyYwkni8qaTw8V AUhiPKNh5ppuxq6VEfzReJrAyoIS5g== =Pths -----END PGP SIGNATURE----- --a21Ii3lSZbeXw64P-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:08:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517847.803740 (Exim 4.92) (envelope-from ) id 1pjgPA-0006Fg-VF; Tue, 04 Apr 2023 13:08:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517847.803740; Tue, 04 Apr 2023 13:08:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgPA-0006FZ-SL; Tue, 04 Apr 2023 13:08:56 +0000 Received: by outflank-mailman (input) for mailman id 517847; Tue, 04 Apr 2023 13:08:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgP9-0006Ey-9u for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:08:55 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7513fd9-d2e9-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:08:51 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 09:08:48 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5697.namprd03.prod.outlook.com (2603:10b6:303:94::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.34; Tue, 4 Apr 2023 13:08:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 13:08:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7513fd9-d2e9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680613731; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=u/A/J0571XYKFGpeBNTr7AZ4HdpqCckhPqJWR+JnJrE=; b=Cn4lpczMcXVKzxVvcqyIQMMd31cGrnHpg+weUuaCf2fD2ZCkIx1vDpkI xpc1TZF9s/BXZtyu4DD69cUeuaeNs1ErjKMvaqITchYRRjqBGvCyoqtzQ 6LU2zZq2+Ueeq+VeF4lx7Ol66h2PupqkTVKqtRSL9xKevhrpxPCe6EkHg o=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 104184127 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZwLyJasDrrBr06p4mPij/K9smOfnVHtfMUV32f8akzHdYApBsoF/q tZmKWmDOK6NMTPxfosib9izoEpS6MWHn4NnHgdr/ixjQygV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAg4mYTmku7qMmpmld7I2hZ0DD+y1M9ZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60bou9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqqc63ATJmQT/DjUdBFv8nfW4jXSlXuxGL 0BPynow95MboRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSy2ETgYKykFfyBscOcey9zqoYV2hBSfSN9mSfexloesR2C2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:WhdKqqM6ZHK6M8BcTsWjsMiBIKoaSvp037BN7SxMoH1uHfBw8v rEoB1173HJYVoqOU3I++rwW5VoMEm9yXcd2+B4V9qftWLdyQmVxe9ZnO/f6gylNyri9vNMkY dMGpIOb+EY1GIK6PrH3A== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="104184127" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKVqkx0Baz9qaPqvPEZWjAy/JF4w4Qh/1Y/mzk7WParBecgAD8AVorJTCGQ9LSOlwvbH04ABdSCq2Z2Uyce2gv8NsdJUlYEBis1lnYD5psmaHVQMBWcXFcNCh5QJa5OLu6E9jLyBu1XbXlscoudF4WltyEnmlAioQD4P9PZMmvOpVCcBPeKCoaDWNowGnBH/d4PFmAN6nUVTR/SCAbOWWNjVmomyArJ9IR1hDt5YQn5RhZyX3CB/n1pWhU0lHrBLJVlUy6Om6XTHBTZJVXk76awSM8KQ8TBwClwXE9B6DgKFc3PFDhOBkf43ZnvLKfWFPOEKFZYrzUstevmo+4pYbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mlemeQ7aWqQk8Ow5+xbGNCu6nFUcKoMWH3TsirNkFks=; b=dpyCRInhvZO+CBErJZN6GMaiDlpXgiT8qki7n85VCz7I6d6V9wREhAoHqtSQxuV+nVrUZZvfZcgcOQp3qls6tj84v84DmHMNmuoOlll7RFCjsiBqLunAz5EAT1yMgZmT31pWoz0Wxyfhe65LHymW+xrRE3AS9zQ+q7LxfSHIzMhJVN6fv9tFXlkX7gc8mgzC9UnQH61dymiiRUkUNE1qMN24fbNOcjxIZwqllAfTnBaJvL8mo53dz/riZ9GeVvCppLW5nnbLS0nCkQce1gJQHJZSswvffNppAyucBG/0hscQbi8W2Yu9pt3TrDMjFZoDZNRooRMiUBAu6/4/b0aSAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlemeQ7aWqQk8Ow5+xbGNCu6nFUcKoMWH3TsirNkFks=; b=M5aIjkNNE5aZCKHE6i+oahL3k53cU94WRM/AabclROSXeGFvAF0pTnKG+r53p/0ic+o2+FpRFqKS9VS+hgyOKd5JG9ywEnKVCD7U9aCfS4v2ZpmHc3h9vxWEcVOZ3LLSVUquI1yI1T9gfgNYPVBhbhdWxGNEVnSlwmtQCKkZUD4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6d64dd4a-5b25-ddca-5c07-7b4c0fc48c0c@citrix.com> Date: Tue, 4 Apr 2023 14:08:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> In-Reply-To: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0031.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO1PR03MB5697:EE_ X-MS-Office365-Filtering-Correlation-Id: 0111f8ac-691d-45b4-cd79-08db350db893 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 70i2Ln9FsZTQYRJ8YjgEoSNjt8KMb/4qUbZN67FyqyWKCyWi/wz3xeuoU9DM4+4USnYtXAdE3AeLQD64P5eC/tYQElkaBHCFJSvRJ8ZL6NGCeRjwCSVtHIiPthwQHK8xWH5F8TP3MkQxBOUkd7WkRWVxzbTsZWYKHprh5MUSw/yY85fBe0pwO21m8Y3nX9cKlFKFPb1AexGXb+Jct+eyCcs5e6iPzKi2NxeAS5Wkb02O+pT5baBD3Rb+7WFLVQZdKm7uDIbzLiuVIr/gmv+C4K6hUIiHn3lUTEZFQEvB9LNDYiz6etDdMecqVVpDqefmvRT6tCuxXdglc6l5SageKeXOJqW2oymSeI/gKyxFAZxJkRB4U1v3AZqAjcORPXerPn0voJvxlY6pGLrBe1Te39A906IgtNJxwPDFYlFsJ1mZT72qGOWDXuc+NjIhQijhDBkc1bq31RZvHS6LhJ/Up0TiYDAlGbEn8Mv4mtc2Hdo8BGJWuW/OulPXDZO0EBjyYplhs24UCjAz9PcWkCqftB20vMEsGRJZQBPCzNitE3VlJjfttXvfohEcjBrf3mciHJngWOmOHql0IBq+RGQA+ipmBVrbjdgUu2OKDNR3TNlwo3tuixLRkdM4hdjSdAQ4R9DFe88IxZ2OW8o88+EW2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199021)(4326008)(5660300002)(8676002)(41300700001)(8936002)(38100700002)(82960400001)(66899021)(86362001)(2906002)(31696002)(26005)(6666004)(6506007)(107886003)(53546011)(6512007)(36756003)(6486002)(2616005)(83380400001)(186003)(31686004)(66476007)(316002)(110136005)(66556008)(66946007)(478600001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFVHZjZ1OWxSdEJxemdNc2ZYais4RXB3TVJoVVFWTEcrTUxQWkEyME1jN1oy?= =?utf-8?B?QXlQSlk4VWlIZloyQkdTZDhGTzE0OFhzMFBNUTdIMzEyWGppaW9tUjFGK3N6?= =?utf-8?B?RSt1VGJNZWpjemVNMDJLZmVPS2J1M3duVlY1akdvZnJIaXhXMmYwM2hUSnJR?= =?utf-8?B?dEVySE96b1hKeDRFK0h1dytOeVdFVkdLYVp0Nkowa24vazVOWGhySkdQVytM?= =?utf-8?B?NlBVYXpWL3ptS3RZMFN3azNSR05ZMlI1TTBkbUUrYnNtSGhXb3ROL2xUaFhS?= =?utf-8?B?N2tuenpmVE1UajViZWVjcFVHcWwxSm9YeGFBT2hhaUJWZHE1NFhtTGYvbG1O?= =?utf-8?B?U0U4WFJwbkhHVTFoSlV3L3ZJVis1SDRwcmhRdmJHdHdjK0Zib0R1OFRaTzJq?= =?utf-8?B?elFTQmh2TUdaSUQzelorUGZUSHhrMFUvajNJN3k1V3UreHBmVVk1eEFMTlFp?= =?utf-8?B?K3pNNkptcXdMK0t0WU1ENUFvN0hYenlkM1V0RE43M2hnZ1ZyWE00UzVWNnBN?= =?utf-8?B?V29LZks1NjBib2trazlicW5NbEh1S3E1OTNVM21tQWhQalk3RGptRnJCVENm?= =?utf-8?B?RzZEV2FEREVXSHcrcU5BRUZUTWNpYU1GV05uK01IRndSQjUwbklOQlZodG5P?= =?utf-8?B?SnJRM2R1aVB2Q0MyNlNiVy8wMUMrc2xLL0JSTERoZnEyRWd2dFJ1VStDSTdl?= =?utf-8?B?ZDBKaUF2YUZGYUphWWhLQ2ZPUEhBMFRuTG1EMlprb3dPR1o3NjZWc1YwQ0FM?= =?utf-8?B?K2VhSExUZjlUeDNIVFZWSmZMMkJqYVJXRSs5cXNXOHRCZWxnKzU4dUFHeDBy?= =?utf-8?B?dmMrMDArVmhuakJFSlNUVnk3U1BuNjF3ZzdRTjNrTVc2L0hXcUR1aWswckNO?= =?utf-8?B?d1RRTnBJRDhCaFVqRUdXc1hTMlJiTHBYVTZDdE4rUUtmbXY1eVl5V1Y5M1Zv?= =?utf-8?B?aENvRjRMTTZFVllaSmVsRHFNLy9MamxwSG5KY3l2Zk9aRjRKZlRDS1ByNy85?= =?utf-8?B?ODBVK1dLV3RiNFRTVVg5V2JXVS9leFpDUUxLbGhYeDhMZ1dySlVibFRuQlpu?= =?utf-8?B?SDN6bk9ZMnBPSGpzUjAyNzdYQVlleEk3bHBZZEhRSkM1NDhUYldkRTBZVVdR?= =?utf-8?B?LzJoUjJXS0ZqOUhBdzhKWUlkODRMbEtuQ1ZGbGtyYzBTY3BnU0V4dXRhWGI3?= =?utf-8?B?TlAwVzRQaFltZTY1M1VSTnBaTFdrRk5aeGpPWE00aW9ET0tHcUZWa2kraVRt?= =?utf-8?B?MDM1N3BjRXhWSndtZ3FTVGtqZisya1FjMWhIeGE2LzllR0FaZmhmeG1BVklt?= =?utf-8?B?VHdYcHVxeVdPQWlPTHFlVGhnTjIrWWRwamVVWWlyTkhJd1I5ZjNGNkxQcTd3?= =?utf-8?B?YXI0MkhqWm5QK3dJNGdqRkk2bkdWbnRXVEZRSVlWdVJ2VnhxenRtTkRQL083?= =?utf-8?B?MVpYNlBIaThjZmZDUXpBYzV5dXJPay9xM0NDRDFyalJFYTZZek4zdW16MTZH?= =?utf-8?B?N2UxYWVhOUxlUkphN3l5c2tnQkhCU0IxSW8weWpJd2hNVkVwNkRweGFDZFNj?= =?utf-8?B?dUpCcjkwWm5mSDRhT3JWemJPdXhVVFJPYmZFbDZVQWR4YWJQcHhCcEFieUE3?= =?utf-8?B?VVFwRy9EWnlXTUtaMU10enVaa3ZreElTMzVOU1c5NGNrVi9jUDNaRUFOMVlQ?= =?utf-8?B?eHYzcUVaV3BGSno1RWZoK2pBM243dUxDM240SWFSbHllR1BDYjIwdGZWVUkz?= =?utf-8?B?QWRISjM5N3lDb3pUQnluUDBnWldrQStjU3lPSkxwL2FDY0lPbkVQeFB0N2s2?= =?utf-8?B?bTlScHlxUXVxUWFwM3hVTTB4YWFXaWFGYmFwcUpjVkFkaHRFdUg3R1FSVGlD?= =?utf-8?B?K0hYdThJaFhEUGtoQmtyUnh6L0gwZmR1NHJLWDZxenhUZHRNd1E3WEJaVkh5?= =?utf-8?B?c2l2bklVNFJSZUtaZzdLVEhQUk5BQ2F0YnB0NEFkaVFubkgrMjZxeS9mWE9i?= =?utf-8?B?dFlCRE1wcUE1eit5WE9lNVdzS2JvcElzSzZkb1lHYWRxem9rcEFhZE9GOGxn?= =?utf-8?B?NmlIdkFUM2xLRkJlR0Exa3B3N21FNFUzVDNTVGFMYUJkYXZiWVI5djZ6cXdZ?= =?utf-8?B?L0FIOEZRajlIbVZzd1ZDWUtvNlh0dHNXb1BYWW5FSTZ3dG5Oa3BBZ3Rrd1BO?= =?utf-8?B?T3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lrriTmojV1wymCQJ1SdzRb6nmQq18VowdfVrPM67IidYgqWZ14zcc1d0unNccaSq+92rQ4VruKgIEM5FzSeW36d/Uvnzf24OS9Voj4H86ipGOy4cGcYbPtiPi/2lpqwifp6FsXVi8aPrBmm9+c5EaB/PSjoGulkxL336WL/wrXVzeKBoC2pyZEE84c/bMQYAN5bvwUE5Ja734ktFyGC6bLtTaIIgQxKQVqrwefZ/L2VpkXcrKiLf9piKEQevu/kW9GfTQdjohSFanzMe8nFbcQMf9yf1G1srD+fe9mO2diPLH5DMbfrHgC1yE0H/aZ7jj+PduvHvyjVOTXdOZkw3N/TLJVo7YBAe4n3eTspS6/3mWwYVPOfCG8Fz9h8X9YXixoxdHKMIbPpWyhVs14gOIOh5hVDHza/jiMxdYAEUSPsmvEn3gThgXVg+vqnHtscv3J6Fxe4FtPVC5UbVDlw7JPFtDYaVR8JRR80tjLun0ppSVOm1cFOAHp0kHqWfCr7ZM/Vwvk0jU/kJkHqDY80/R8ixdK4+7bHQtoHcVHdtxchE1xvDT3KE48rIIXpggO0adzkJHosa8TSe0UkDnNR8ctSyv44uDxmyN8KK2BEw4bDsQdmrwz+OnRfDwBt7JgfJvmqtHBi91BXRlj1o7wKKEPtkOtfVSUiY9yAxKCx8ye2zHK/YoSTTu3zpMkr6T+fqy9oy4QrO05ZWOoBWcH/ZZfs5htZOGYOYGEdHzw3hjx3Ds+/LAipxgC7JENMpASiq6ZhvO6HQPYWbPKQ/i6YoFtYXUBTgc/HZFSxJiupbq5or0/k72R2IN7LiOwz0P+Ss X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0111f8ac-691d-45b4-cd79-08db350db893 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 13:08:45.4977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6xfJFUPGmMSMP4hMUNW6XJhaPVsrRWCWxb/eeR/PNbaJIputK7OvB144d/OmGBv2HR2V49i2oKSn+tCToS0tF7S5tz/gc3VklfS7sVszoRU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5697 On 15/02/2023 2:54 pm, Jan Beulich wrote: > While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still > applies to guests also when run on a 64-bit hypervisor: Is this really true?  Even when looking at Xen 4.2, 32bit guests are required to pass a full 4k page, not a 32b quad. Which makes complete sense.  It was a hard requirement of 32bit non-PAE guests, so it was a natural restriction to maintain into 32bit PAE guests. This is *only* a 32-on-64 issue, because this is the only case a 32bit guest could in principle use an L3 placed above the 4G boundary. > The "extended > CR3" format has to be used there as well, to fit the address in the only > 32-bit wide register there. As a result it was a mistake that the check > was never enabled for that case, and was then mistakenly deleted in the > course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume > CONFIG_PAGING_LEVELS==4"]). > > Similarly during Dom0 construction kernel awareness needs to be taken > into account, and respective code was again mistakenly never enabled for > 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by > 5d1181a5ea5e ["xen: Remove x86_32 build target"]). > > At the same time restrict enabling of the assist for Dom0 to just the > 32-bit case. Furthermore there's no need for an atomic update there. > > Signed-off-by: Jan Beulich > --- > I was uncertain whether to add a check to the CR3 guest read path, > raising e.g. #GP(0) when the value read wouldn't fit but also may not > be converted to "extended" format (overflow is possible there in > principle because of the control tools "slack" in promote_l3_table()). > > In that context I was puzzled to find no check on the CR3 guest write > path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any > of the low reserved ones) could observe anomalous behavior rather than > plain failure. > > As to a Fixes: tag - it's pretty unclear which of the many original > 32-on-64 changes to blame. I don't think the two cited commits should > be referenced there, as they didn't break anything that wasn't already > broken. > > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ > unsigned int partial_flags = page->partial_flags; > l3_pgentry_t l3e = l3e_empty(); > > + /* > + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not > + * understand the weird 'extended cr3' format for dealing with high-order > + * address bits. We cut some slack for control tools (before vcpu0 is > + * initialised). > + */ > + if ( is_pv_32bit_domain(d) && > + unlikely(!VM_ASSIST(d, pae_extended_cr3)) && > + mfn_x(l3mfn) >= 0x100000 && > + d->vcpu[0] && d->vcpu[0]->is_initialised ) > + { > + gdprintk(XENLOG_WARNING, > + "PAE pgd must be below 4GB (%#lx >= 0x100000)", > + mfn_x(l3mfn)); > + return -ERANGE; > + } Having dug through source history, I see this is largely the form that it used to be. But I'm unconvinced by the "cut control tools some slack".  I'm quite tired of different bits of Xen taking on unnecessary complexity because people are unwilling to fix the problem at the correct layer. A toolstack which has non-pae_extended_cr3 guest on its hand will know this before any pagetables get allocated. That said... I don't recall encountering this in migration v2, and looking at the logic now, I'm pretty sure it will malfunction with a non-pae_extended_cr3 guest.  When interpreting the guest cr3 value, we blindly make the transform on the save and restore side, and I can't spot anything limiting the L3 tables to below the 4G boundary. So I'm reasonably sure I accidentally broke such guests in Xen 4.6(?) and the absence of complaints in the intervening 8(?) years shows how many are in use in practice. For this check specifically, I'd suggest prohibiting non-32p guests from setting pae_extended_cr3 in the first place (I see no limit currently), and then simplifying the check to just if ( unlikely(!VM_ASSIST(d, pae_extended_cr3)) &&      mfn_x(l3mfn) >= PFN_DOWN(GB(4)) ) And I suppose I need to make a non-pae_extended_cr3 XTF test which is migrate-capable... ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:28:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:28:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517853.803750 (Exim 4.92) (envelope-from ) id 1pjghY-0000Ff-He; Tue, 04 Apr 2023 13:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517853.803750; Tue, 04 Apr 2023 13:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjghY-0000FY-ES; Tue, 04 Apr 2023 13:27:56 +0000 Received: by outflank-mailman (input) for mailman id 517853; Tue, 04 Apr 2023 13:27:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjghW-0000F9-9t for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:27:54 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f0d471a-d2ec-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:27:51 +0200 (CEST) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 09:27:46 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6268.namprd03.prod.outlook.com (2603:10b6:510:ea::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 13:27:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 13:27:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f0d471a-d2ec-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680614871; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=P4xCSk37NaJ3GwvRnjV+hqE8WKXnDPVbaRFPKeOS5/U=; b=U0iz5J0Z84qyU94GeFH935+UupzPtfVx9D4m+IYy+pcDhTORrNwVJfMw 7Q8zEOd75tk4f3QYLqBCg0ampGg3EZXgbqnKj9OWrNz15lCSE1ixdkVdA kyr8OWyD4SnIBqKeQFreszSJWX4SpB4Ct9axsGMSaKfslc7EGs7qRQzgC 4=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 106697073 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sddWT6LYDtlHsemgFE+R/JQlxSXFcZb7ZxGr2PjKsXjdYENS1TwCz mYaCmyCbqvYYTPwfd9ybNi39EoC6JKAnNMyHFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c53WDxR1 qQ4EglKQQuG1+yE+YjiE/BF05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMlGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHulBtNNTOLjnhJsqB6N+ExUGSMab2aEhaiclUyQfMJ0E GVBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQEnsIrQT0h1 neSgsjkQzdotdW9Vna15rqS6zSoNkAowXQqYCYFSU4J5oflqYRq1xbXFI88SOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAszA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:E9U/sK5tmKHRMlG8JAPXwPvXdLJyesId70hD6qkmc20tTiX+rb HKoB17726XtN5yMEtLpTnuAsS9qB/nmaKdgrNhXotKPjOGhILyFvAF0WKK+VSJcBEWkNQz6U 4KSchD4bPLY2STIqzBkXGF+3pL+qjizEgI792uqEtQcQ== X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="106697073" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PmjaESlC89RsgFZZdc6/0rXISbvxkADkFhu0Oof7SCM/8ems2hd1mTV3R9pSXET4227gzI/5ZGJh+cQy9LrUWDkFbsJb8SKnoNm49zNP6Bws3y6169UVCq0c/ax+vBhCZ8hFU9FgFTg0Wv0GFDuBJJEK9uGLg0bvjB2wYrJbYvQ5GrgCkEqBrMDdXFnS6MvLFZ7qG/CZcV9CoIkyt0kstoIZTg2gKR2SEGm24MM5L/yrR8lU9VwLjzDGflc5+QZ1uFZ4yMa29Ir6IhPh4qIzmFcJkiVqEJ2ZoB5ceAw3OBS8tyoN3lDYcUysRPXLnn4xL5EsnYfEX1BXr8mzrVfE8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nl1vY8U0d5COAPbhowL7ndLBAeSmFOBTksyjV33zWzE=; b=Og5uW2nJZ20lpsCTDjtjS5UcQfCMOJ5SvR0/DeQETv7nRgqeLhfMl1W81WPGypbxXQygxf1sNyr3/n7mq6qB/CYgN1Sz6QOF/m5A34eS+eHoCPHsL7x3KnxLRFm9pqmM81usvIr5tqGu/ei2S1m/YUMBHwXO8+pKBiFCKaQRD5ZeBqCjF/8p4iV1UVvnRrnCq9VXapGA03zmW8vPgkB0u0V+kW2O2+KXkV70MZvcxW+gq82IuZPPPGDpOPPsxDSP3UtiwLjxSWKuDHUCp/hnNN4Wwj8Jv1Zo8eVTbY1lqFcYzbVpEhrMjnNi5cMFbr8Pv5YX3j90kK3Ixe9m/UVbQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nl1vY8U0d5COAPbhowL7ndLBAeSmFOBTksyjV33zWzE=; b=Fvvptp2OycOlJnJF0iIZjnJ15HW3yHFG2dWhmlMBb5TKP/tU0SdrZ4GbZTTUd7JqBM82SCiwB3qGbnpuQtzoa5egnsMqjqE+rRWXf1J/qzIrJ/t7FUFt3ElVMHgwCeyAXaA7NAOoyTekwb7TQcjCXZG6H9yVO+WGtqR1wPSGoRE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <91fc0c1f-a985-17bd-2011-f4964d82e008@citrix.com> Date: Tue, 4 Apr 2023 14:27:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Jan Beulich , Wei Liu References: <20230331175719.500285-1-andrew.cooper3@citrix.com> <4b76def9-9940-ccf0-8050-12ddf2c1253c@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0442.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6268:EE_ X-MS-Office365-Filtering-Correlation-Id: e87a61d5-4043-4052-0f47-08db35105e32 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8XvwyiwvE1db9nDwLvG9A+3lQyUDTKmwhzZW3S2jjHmMmkYytAq6U8hH/K8rv9RXi0resvYjonJaimDIuZfwMQ/GxxrX9V3Vvu5Ors3EhI9gyW2CIjhcl8HytAHreF+GDk7RVYVC0ha/VW8DZOxPKELVf8aMjoyVqqSb4SGrzYrEXdNoyp9rduicOe5/MqEXU382RMe1hEDhp8YAfMYTqeCbLIq/ZC1J4RGWbyW3sJI8LlAVlLP+9oVb/P6UhAuhkvzeIDT0WzfW8Fm4GvlD4llnrorfvw1lrwr8K0/4ux7jV+VHzImO+yEx3+tkey4Brjiqyb2lyi1kaOeea7ig/sTIL5jwDDZOk0ZAGEesVz/2f8ekPvbWDrjWJ4ThvYkKrTh+JT289ROmp1zgJBFZRnV+RDJciLCg/b2p96RkkyvM1n8tz+fmTc9cz9TSn/LJCodUe5ubXb5X1VPIyvo9cNGYA0pnRfljRZt3moiZg8Lesu91Bq5IYOwhdJfodyHre1uZ0PEX7E0xP5jZ7B1uvrfEH0D5TMQAcPSg7jQq/tDTYnFjv0mpRuZWPl9EpOApm9xemtY0WDEtYLxnpPUK/rpVYfciGVHkFJyfoMrLXNlhtO6nY2feGGA12mFAdslinReg3uJj0WUz2V4SdVvqlw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199021)(31686004)(6636002)(37006003)(2906002)(316002)(5660300002)(54906003)(6862004)(66946007)(8936002)(41300700001)(186003)(478600001)(4326008)(8676002)(66476007)(66556008)(6666004)(6486002)(53546011)(26005)(6512007)(6506007)(2616005)(83380400001)(36756003)(82960400001)(31696002)(38100700002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVBabHVycmhOMUxSUk5zL3djMmNJRGw3dzExZXY2WVVzQ0hwaFUvcXV4Ky9r?= =?utf-8?B?dE14d210UVFPdFdWT3VRWUxoUUJEV3RhMEQ4cTNpZ210TzM2SzRYcHd0cUJ6?= =?utf-8?B?aSs5MjFxQ1ZSUjNORXJCZzBwR2pCT2lOMmR3UHVGc0hEY1Q1S3ZWVWlsMGJ4?= =?utf-8?B?V2ZqK2NLbG1OejlEYkFTekRpVUNQdm84WFJzMEU2VUhIcVhLRVRJa0VhZ01m?= =?utf-8?B?L0ZkUVNFdE1jM0JWc2xiSEdWaTRhTkhPYk5FWklzOTNQOTJ4WlpHN1RsWGIx?= =?utf-8?B?emJjRWVRMzYrYTN0SlhUQWt5azZlMWFwZWlNUXNZUWRlK2hrNnVEaGpXUnBT?= =?utf-8?B?M25uclE3ZGUyUmx6VWtjZ2ZVU0dlYU1Qd1kzcUZBVGNyY1lSM1kvZ1k3Vk0z?= =?utf-8?B?VXZVSWo2K2dVZXVwTEpJNlpnQzhwTWRNMWdyUmhtREExbVFkRmdIK1R6STZM?= =?utf-8?B?OEhvM1B3NzJtODRzWENjSERvVXMzenpTKzIzbFk0RXI5Y0NydEkxczV6Ynh0?= =?utf-8?B?N2t0VEUvM0xWUHovYVNEQS83dFJJemJBOHhuS01LdGw3cExhRGxDOFFwMVNS?= =?utf-8?B?VEJlOHdkbTBFVzNLei9DK0xZdGRRU2hHZjdXWitFWlcyU21SQ1JlSTB4c2E0?= =?utf-8?B?K1gvVThSRDM5aVp3eHdxcysxNHRpNXBKbkUxSFJIVHAwUStLSkt2NEEvN2lS?= =?utf-8?B?UWJsaFU1T0xFdGFrSjZ2YUF6TndvYUpsUGJlRkVCaHk3MktkSzNQOUh5UWVq?= =?utf-8?B?aTBxTm1KeEdUSE9VYmRRd1R1NkMxM0pDc1pOU1pjbEJaWmhaTnpqSmRuUkhP?= =?utf-8?B?elAyU1J1SUN4TTREUEZNeVdLWk9DTVlpbktQR25hbUdpSEtKOWZhNlF1QW9n?= =?utf-8?B?bEdYcGlaMXpJMkRlMlZLbXNYWnNkdkw1Q3ZaRThFMjNud2t6TnpySEdLUCty?= =?utf-8?B?TE9Vays0QWZ4U09adk5iaXFscVVzb0Rtck9Qb0VYRDB5KzNLa3d4RkJ4NG1h?= =?utf-8?B?WldnYXlCU0N0eXE1VXVsWEJpcWp1MHp0ZFh0Ymp5SklKdy9PMjI2TGZFR0hm?= =?utf-8?B?TmRLeVcvVFJ1YVFtemxTVVhxbTBFbVhUWHNEYWJreG9iTUgwYXF0dlJrc2Zk?= =?utf-8?B?aGNkOGRUUjJNMmIrQjcybVN4NW40d0xVbWpxdldGUm45ejV4Sko2cWhjakFE?= =?utf-8?B?TWtKR1U1eW1LRE90aXUzRkM2Nk1nVGxQTDM2bnh0MTJiM0krRmoremZpN2V3?= =?utf-8?B?QXVDUFZoSWFxRWNRd2RpNXd4TFcxQTlzTEFGbTFqMEhHeDhaU2JkTzg4NVJP?= =?utf-8?B?N2lSM3BPeU0wVjNEVjdJR0h0aG1RYjB2TXZrbitQMm5URFBoSm1PZ3dyNDdn?= =?utf-8?B?K0NHL1FVS0RqOUtNOHE3Q0NCckhPakJzVGtudW9nQlprQ214R3AwRkRjb0ZU?= =?utf-8?B?TDJ1b2NZU1FvZmFmdXdPTjNVWDVXWlhraVJEcHlvQU0wRzIxOWlZb0srU1VK?= =?utf-8?B?NVRZK0ltTWpsaG83QkRJcHJoZ3MxRXpSTmxEZ2FGeUk1dDQweVVCUzZUZ3BS?= =?utf-8?B?NmRSSjBxbnl3YThPdnFqR3lpWmVBNzBNVEZrOGUvaTkvTWlPUUdtb2lCei9X?= =?utf-8?B?SzkyTWl3WDE5L1cwbmxZQS9pdUYzSlZlQTNjNGl4TzJvMjNZY1V4M2dBVmN3?= =?utf-8?B?NDN2bGVSV3FVVUdTVGR2SDdDYmlwUzdrM0xJdDJOOXRjN1h2K3VFdUFaNlpU?= =?utf-8?B?ZGhqUEQzMHVFWGRxbkVXNG10UWVmOU12djVneWRHei9zZXlaeTRQN3Fvdjht?= =?utf-8?B?VWRFWkpVcnU5aUdkUXMyT3NyMDFRUnBzSlNEdEtUVmRialhCMkMxdTEvS2F6?= =?utf-8?B?Q3JoTnNlQ1d0Zlk2V1lpVGZhSlg0Y2MyOGkyR1VMN3JjRmJIYnFNM1VTMU05?= =?utf-8?B?bEZEUnlyQ0FCU2FhaXJCNnkzVWhMWXUzamtyQitRckRUQzJVbVhCaVZJaWJI?= =?utf-8?B?c0dnVUx5bXJ2YW1FK00rbElxQlBUbUVyaGh0ZUtkZWlkT2RZVU1jaThPUTBO?= =?utf-8?B?TTljRmhPRzYvRk84TEw0QUtWRXh4aWxYUFVrUVNZSThyeDlvcEF2S0JHVVdz?= =?utf-8?B?NzZZb3JGdFN1cEYyWGdqa2xzK0dRT1Q3RXdpeE9SMDF3aWl6ZWhSZ0xJVm5W?= =?utf-8?B?aFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5DbWliqt2NTg0SiY73F0PP+0MbEla54To2QiKtFdZ2KI2exgxtsXTgjDqmVMiNu46j++U3WKWBcpqWeSuWkoWW/j3w98fXIO3Qp0gL8B0jkxPk00Rfx6lzP1CSN8/M5tOB84fCjP9EWluCqfMMVtw9ahaOgvK3mLTIbH59x7dqm51aK0ODLzT1lGPTaUGfrfB69bchkin4vJxi0hpYZ/7K5pTdiW0o3XnvVyGPpQ3PLLHcju2Obs3pfIc5Fk1nPU1K70sHaThFWAi/JP2uOCsg+NJqgt7b6C2kXzUv/3TR5tWtdMhOf6cIdknFgGxbrwOfX/AUwadzQhSVrDNH/+eMvwbCS/YaAVbch8k80P+W+z90zTQe8MeWxP+fH6CdopQqJGgKJ8sCTz+KiW49WFNKafIbMcO+ykRL/az/1PTCa24UWx5wETZfwuY4X5DUgc5wBRaZ9ijAie/oHspgbHeAgA0kl8X8Bn05j+wDAqae4vonKqMuHpXOXXWG9cLDuCOH37BM5Xi+Eo5F6mkyz/yLTNYPEkHQvs8KiJe5Q/e2WDGxRK/9/gHR9WKd2x5QgNDDWHjjRXihm3VgwD3F6QQwlAgMYp9NA/LOlfndnD7FaHjbIcKjNfoX+Y7q1Daat4PuAReSgItSsZznBd4ingX80LDAIcJK62BeL3MOW1gRD35bPq0g5zwWFHYZkigBxHwh0sPcFhZ5lRF+KftyotChafU2f6X064C8AoyJgPdwRZ696wS8zUkqamnBxjIfOwopA4nvPmXUuu7R3zsAcHwgLGWDFgmmAp5LwbS/2gUhQBwAkHaesHtTwtXi10SNVI X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e87a61d5-4043-4052-0f47-08db35105e32 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 13:27:42.1942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h2OnHul5NYlWXcnPzRh7f15M9dPrbllYoRiwtl/Bd3rDMGIoYha+mwbCmECEbTZlcZlQeKzknfHY7NvedJncUfJpoT8fPgS9CbQ2QNKPMgU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6268 On 03/04/2023 2:26 pm, Roger Pau Monné wrote: > On Mon, Apr 03, 2023 at 11:16:52AM +0100, Andrew Cooper wrote: >> On 03/04/2023 9:57 am, Roger Pau Monné wrote: >> (Quick tangent...  Our PCI handling is currently very dumb.  >> pci_mmcfg_read() returns its value by pointer but the callers never >> check.  Swapping it to return by value would improve code gen quite a >> lot.  Also, when MMCFG is active we still pass BCS accesses to IO ports.) > I wonder if it's really preferred to access registers below 255 using > the IO ports, as Linux seems to do the same (prefer IO port access if > possible). And see how many attempts there have been to change this, only blocked on untangling the IO port mess on other architectures (a problem Xen doesn't have to contend with). MMCFG, when available is strictly preferable to IO ports. An MMCFG access is a single UC read or write, whereas IO ports are a pair of UC accesses *and* a global spinlock. >>>> >>>> #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \ >>>> || id == 0x01268086 || id == 0x01028086 \ >>>> diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c >>>> index 5da00e24e4ff..008367195c78 100644 >>>> --- a/xen/arch/x86/pv/emul-priv-op.c >>>> +++ b/xen/arch/x86/pv/emul-priv-op.c >>>> @@ -245,19 +245,7 @@ static bool pci_cfg_ok(struct domain *currd, unsigned int start, >>>> if ( ro_map && test_bit(machine_bdf, ro_map) ) >>>> return false; >>>> } >>>> - start |= CF8_ADDR_LO(currd->arch.pci_cf8); >>>> - /* AMD extended configuration space access? */ >>>> - if ( CF8_ADDR_HI(currd->arch.pci_cf8) && >>>> - boot_cpu_data.x86_vendor == X86_VENDOR_AMD && >>>> - boot_cpu_data.x86 >= 0x10 && boot_cpu_data.x86 < 0x17 ) >>>> - { >>>> - uint64_t msr_val; >>>> - >>>> - if ( rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) ) >>>> - return false; >>>> - if ( msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT) ) >>>> - start |= CF8_ADDR_HI(currd->arch.pci_cf8); >>>> - } >>>> + start |= CF8_REG(currd->arch.pci_cf8); >>>> >>>> return !write ? >>>> xsm_pci_config_permission(XSM_HOOK, currd, machine_bdf, >>>> @@ -1104,6 +1092,11 @@ static int cf_check write_msr( >>>> if ( !is_hwdom_pinned_vcpu(curr) ) >>>> return X86EMUL_OKAY; >>>> if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || >>>> + /* >>>> + * TODO: this is broken. What happens when dom0 is pinned but >>>> + * can't see the full system? CF8_EXT probably ought to be a >>>> + * Xen-owned setting, and made symmetric across the system. >>>> + */ >>> I would assume CF8_EXT would be symmetric across the system, specially >>> given that it seems to be phased out and only used in older AMD >>> families that where all symmetric? >> The CF8_EXT bit has been phased out.  The IO ECS functionality still exists. >> >> But yes, the more I think about letting dom0 play with this, the more I >> think it is a fundamentally broken idea...  I bet it was from the very >> early AMD Fam10h days where dom0 knew how to turn it on, and Xen was >> trying to pretend it didn't have to touch any PCI devices. > It seems to me Xen should set CF8_EXT on all threads (when available) > and expose it to dom0, so that accesses using pci_{conf,write}_read() > work as expected? It's per northbridge in the system, not per thread.  Hence needing the spinlock protecting the CF8/CFC IO port pair access, and why MMCFG is strictly preferable. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:31:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:31:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517858.803760 (Exim 4.92) (envelope-from ) id 1pjgka-0001i3-4e; Tue, 04 Apr 2023 13:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517858.803760; Tue, 04 Apr 2023 13:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgka-0001hw-1R; Tue, 04 Apr 2023 13:31:04 +0000 Received: by outflank-mailman (input) for mailman id 517858; Tue, 04 Apr 2023 13:31:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgkZ-0001hk-3U; Tue, 04 Apr 2023 13:31:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgkZ-0003lX-01; Tue, 04 Apr 2023 13:31:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgkY-00030w-Ej; Tue, 04 Apr 2023 13:31:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjgkY-0005k4-EF; Tue, 04 Apr 2023 13:31:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cvNA39lKzg/ZQ85gaOZ3G2aS3C8/vSMMsobqoCVHgVw=; b=fHuXYoc9GvogAQCPjzODfi+RXi JCAISMrbXKukahceSSwMSpgTyAczvz+yejg48gVUrjmkm2IICAxLRDPL+OTzsMdsQ7BVJWjiuAF6x tMIOMM9xAveC1ACdmZw8iAdW4rqFx3ONyCtW1dlB+50mABGBebRj4QZPgmb6y5ZeOrW0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180133: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=bfa2e6a246225233f09a2523939e01dcf83bca4c X-Osstest-Versions-That: xen=bfa2e6a246225233f09a2523939e01dcf83bca4c From: osstest service owner Date: Tue, 04 Apr 2023 13:31:02 +0000 flight 180133 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180133/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180126 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180126 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180126 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180126 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180126 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180126 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180126 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180126 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180126 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen bfa2e6a246225233f09a2523939e01dcf83bca4c baseline version: xen bfa2e6a246225233f09a2523939e01dcf83bca4c Last test of basis 180133 2023-04-04 04:12:59 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:39:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:39:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517863.803769 (Exim 4.92) (envelope-from ) id 1pjgsI-0002NJ-0W; Tue, 04 Apr 2023 13:39:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517863.803769; Tue, 04 Apr 2023 13:39:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgsH-0002NC-Ts; Tue, 04 Apr 2023 13:39:01 +0000 Received: by outflank-mailman (input) for mailman id 517863; Tue, 04 Apr 2023 13:39:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgsG-0002Mh-Rr for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:39:00 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c4bf896-d2ee-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:38:57 +0200 (CEST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-zhTRkDGhMQ6fbcLtkdxDKQ-1; Tue, 04 Apr 2023 09:38:55 -0400 Received: by mail-ed1-f70.google.com with SMTP id b1-20020aa7dc01000000b004ad062fee5eso45756877edu.17 for ; Tue, 04 Apr 2023 06:38:54 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id f22-20020a50d556000000b005002daeb27asm5937325edj.37.2023.04.04.06.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:38:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c4bf896-d2ee-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680615536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s8A+0/77ETVjCC+da2gmyQ8uuifyTw2Q7q/NY4s52Vs=; b=YeNAUa4hhtiLj8Dgxhn8DBcPGnaSTKjzqrFH7nzX4P8fYwSYtIDpYrTAx3+7EhEwXOZjR2 XSMggwyIxIMbZ6drTBbN3ET4R+4vgtB8cSvsxz9sbgAN71yUHvGpJMRtek/xJ8R/1Sqo4E 3Gvrh/0lqXP4AJHnfCMNGXNHlYyUGVo= X-MC-Unique: zhTRkDGhMQ6fbcLtkdxDKQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615534; x=1683207534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s8A+0/77ETVjCC+da2gmyQ8uuifyTw2Q7q/NY4s52Vs=; b=IRWuGvVoowvrgRYDukE2Gv00bxP6Ic3GHanhNdMAKmiuUW7mjcW6hAwPDpgT0+JQMh lw5oEiORcTmtXa5wmPixVnS8O1n9SaEvG8kUkZ+FNEjNHzzFVqILDYm8XIBgwZmGILeW HUdGYbY2KIQ42yWpxxx0ldrI3BavGB+o+DJD3WmCnes0EkXzT8XRJnTbJq4zms5bZ3Kh AHxsbU/pHO2OCoBulja4aWrcspqLpDuJwhJUwznllXPZn3TiMGqDJCscJ/dmIh2XbnjG xq7/stN8cMZdLdMEnO0lxrdroWp+PIpVLyvTFyXIlh5oTVIOOQRcxBueju9cPD2WzV28 i/kQ== X-Gm-Message-State: AAQBX9fYh6rJ2yudQIl7iZ5zSJugzqFK5lP5V51KfNMeDcmtQBeGXsan weVFbQqMAQ1v6gdOwo2g+yjMVSzxrshKwHWxxt6QP6wYI3p3ERFyXRgiI7z4sX+oRgHm0fT6BkW WjQtTI5maLo8s94CfcIgEQapn8Wo= X-Received: by 2002:a05:6402:4cf:b0:4fa:e8f3:968b with SMTP id n15-20020a05640204cf00b004fae8f3968bmr2551233edw.19.1680615533971; Tue, 04 Apr 2023 06:38:53 -0700 (PDT) X-Google-Smtp-Source: AKy350al+iU0IKXO90b1D9to94YRCbqQRKUwSNuKsjsPFReXh3S7dIzKpCXzXyF4ywwP2kJFgg+jKA== X-Received: by 2002:a05:6402:4cf:b0:4fa:e8f3:968b with SMTP id n15-20020a05640204cf00b004fae8f3968bmr2551207edw.19.1680615533676; Tue, 04 Apr 2023 06:38:53 -0700 (PDT) Message-ID: <8f871654-064c-4782-e99f-c81f5935b23a@redhat.com> Date: Tue, 4 Apr 2023 15:38:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 02/13] virtio-scsi: stop using aio_disable_external() during unplug To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Anthony Perard , Zhengui Li References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-3-stefanha@redhat.com> From: Paolo Bonzini In-Reply-To: <20230403183004.347205-3-stefanha@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/3/23 20:29, Stefan Hajnoczi wrote: > This patch is part of an effort to remove the aio_disable_external() > API because it does not fit in a multi-queue block layer world where > many AioContexts may be submitting requests to the same disk. > > The SCSI emulation code is already in good shape to stop using > aio_disable_external(). It was only used by commit 9c5aad84da1c > ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching scsi > disk") to ensure that virtio_scsi_hotunplug() works while the guest > driver is submitting I/O. > > Ensure virtio_scsi_hotunplug() is safe as follows: > > 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> > device_set_realized() calls qatomic_set(&dev->realized, false) so > that future scsi_device_get() calls return NULL because they exclude > SCSIDevices with realized=false. > > That means virtio-scsi will reject new I/O requests to this > SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while > virtio_scsi_hotunplug() is still executing. We are protected against > new requests! > > 2. Add a call to scsi_device_purge_requests() from scsi_unrealize() so > that in-flight requests are cancelled synchronously. This ensures > that no in-flight requests remain once qdev_simple_device_unplug_cb() > returns. > > Thanks to these two conditions we don't need aio_disable_external() > anymore. > > Cc: Zhengui Li > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/scsi-disk.c | 1 + > hw/scsi/virtio-scsi.c | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 97c9b1c8cd..e01bd84541 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -2522,6 +2522,7 @@ static void scsi_realize(SCSIDevice *dev, Error **errp) > > static void scsi_unrealize(SCSIDevice *dev) > { > + scsi_device_purge_requests(dev, SENSE_CODE(RESET)); > del_boot_device_lchs(&dev->qdev, NULL); > } > > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index 000961446c..a02f9233ec 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -1061,11 +1061,8 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, > VirtIODevice *vdev = VIRTIO_DEVICE(hotplug_dev); > VirtIOSCSI *s = VIRTIO_SCSI(vdev); > SCSIDevice *sd = SCSI_DEVICE(dev); > - AioContext *ctx = s->ctx ?: qemu_get_aio_context(); > > - aio_disable_external(ctx); > qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); > - aio_enable_external(ctx); > > if (s->ctx) { > virtio_scsi_acquire(s); Reviewed-by: Paolo Bonzini From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:39:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517866.803780 (Exim 4.92) (envelope-from ) id 1pjgsu-0002rs-9I; Tue, 04 Apr 2023 13:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517866.803780; Tue, 04 Apr 2023 13:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgsu-0002rl-68; Tue, 04 Apr 2023 13:39:40 +0000 Received: by outflank-mailman (input) for mailman id 517866; Tue, 04 Apr 2023 13:39:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgst-0002po-9E for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:39:39 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23f4759e-d2ee-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:39:37 +0200 (CEST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-6Lp5ym6kPTCntbQ4WZMqJg-1; Tue, 04 Apr 2023 09:39:34 -0400 Received: by mail-ed1-f71.google.com with SMTP id n6-20020a5099c6000000b00502c2f26133so1037639edb.12 for ; Tue, 04 Apr 2023 06:39:34 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id gv19-20020a1709072bd300b00931db712768sm5987531ejc.4.2023.04.04.06.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:39:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23f4759e-d2ee-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680615576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+fw7/8SirqBr4X2qtQdxLuMPR3GvOcViyBmOU340OWg=; b=abfSQhgaYtzYpsQ6Rnh+lCpLuRkHbswRSzvuRSvhDXXxvi4ca8/57IokU611F8OvMTEHdt ndEIEJLfAVib4Zc2VIjRYQZ3COnR830XjvAxZVYqEegXHTr7CxqWXkAGOImlaaZGUx7ofy XtDFVsigw4y8zV2Jpnsw38pU7snn5yk= X-MC-Unique: 6Lp5ym6kPTCntbQ4WZMqJg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615574; x=1683207574; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+fw7/8SirqBr4X2qtQdxLuMPR3GvOcViyBmOU340OWg=; b=LB+SM2z/jixszcC4S+kU/T+5kPythdG193JJuhyjXTFlk5xHQCw7+BJpagOMTeoUrh CCi9YUMB1lPkte5FoCYtvXUQP4/pAAtSfQQPWq2mGANRP+pruJbSD88tkUqcqLD5BnEt Y6iszod9UKM7AHL71sojZfNlWuOaD2UEUNNgnp/WE3CdGtP1NCd3KqmNI0KlJS7HY29I XFabsI3IfeAZ8BYelHjVUPAm8ogLbzreXfJHWycckaBwWv4Vp5hzubPRpKj9Fie7H/tH 2k9IsS9apxXcRZA/z5dY2HCYQKbFpc++T3OHpiwZnCDK+zdxsdKM8IHJE+1ccv0fnh4M 9HGA== X-Gm-Message-State: AAQBX9euaW3OLVE3BFrbnRj85lEq+Cld+jkG6qDNvryEUb2sYyBgXvVz jzuEJTTurKMdq+1rufFwpLuXPPb/0pSjfzWyhaWkl7LQnmex39ISZmgkrl13TWB4fyU8vGi1yoc Q3uDzUJrvygqsGdnqbUDIZoopW1o= X-Received: by 2002:a17:906:aad3:b0:921:5cce:6599 with SMTP id kt19-20020a170906aad300b009215cce6599mr2419094ejb.41.1680615573825; Tue, 04 Apr 2023 06:39:33 -0700 (PDT) X-Google-Smtp-Source: AKy350aaCkFAzW7d1iA6E5boAcJaqOBPLxKcd5Wvt9uXai5VAMRolWR6H8rwuM6Bp4D7FgjG04Wj5g== X-Received: by 2002:a17:906:aad3:b0:921:5cce:6599 with SMTP id kt19-20020a170906aad300b009215cce6599mr2419071ejb.41.1680615573528; Tue, 04 Apr 2023 06:39:33 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 15:39:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 04/13] util/vhost-user-server: rename refcount to in_flight counter To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Anthony Perard References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-5-stefanha@redhat.com> From: Paolo Bonzini In-Reply-To: <20230403183004.347205-5-stefanha@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/3/23 20:29, Stefan Hajnoczi wrote: > The VuServer object has a refcount field and ref/unref APIs. The name is > confusing because it's actually an in-flight request counter instead of > a refcount. > > Normally a refcount destroys the object upon reaching zero. The VuServer > counter is used to wake up the vhost-user coroutine when there are no > more requests. > > Avoid confusing by renaming refcount and ref/unref to in_flight and > inc/dec. > > Signed-off-by: Stefan Hajnoczi > --- > include/qemu/vhost-user-server.h | 6 +++--- > block/export/vhost-user-blk-server.c | 11 +++++++---- > util/vhost-user-server.c | 14 +++++++------- > 3 files changed, 17 insertions(+), 14 deletions(-) > > diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user-server.h > index 25c72433ca..bc0ac9ddb6 100644 > --- a/include/qemu/vhost-user-server.h > +++ b/include/qemu/vhost-user-server.h > @@ -41,7 +41,7 @@ typedef struct { > const VuDevIface *vu_iface; > > /* Protected by ctx lock */ > - unsigned int refcount; > + unsigned int in_flight; > bool wait_idle; > VuDev vu_dev; > QIOChannel *ioc; /* The I/O channel with the client */ > @@ -60,8 +60,8 @@ bool vhost_user_server_start(VuServer *server, > > void vhost_user_server_stop(VuServer *server); > > -void vhost_user_server_ref(VuServer *server); > -void vhost_user_server_unref(VuServer *server); > +void vhost_user_server_inc_in_flight(VuServer *server); > +void vhost_user_server_dec_in_flight(VuServer *server); > > void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx); > void vhost_user_server_detach_aio_context(VuServer *server); > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c > index 3409d9e02e..e93f2ed6b4 100644 > --- a/block/export/vhost-user-blk-server.c > +++ b/block/export/vhost-user-blk-server.c > @@ -49,7 +49,10 @@ static void vu_blk_req_complete(VuBlkReq *req, size_t in_len) > free(req); > } > > -/* Called with server refcount increased, must decrease before returning */ > +/* > + * Called with server in_flight counter increased, must decrease before > + * returning. > + */ > static void coroutine_fn vu_blk_virtio_process_req(void *opaque) > { > VuBlkReq *req = opaque; > @@ -67,12 +70,12 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque) > in_num, out_num); > if (in_len < 0) { > free(req); > - vhost_user_server_unref(server); > + vhost_user_server_dec_in_flight(server); > return; > } > > vu_blk_req_complete(req, in_len); > - vhost_user_server_unref(server); > + vhost_user_server_dec_in_flight(server); > } > > static void vu_blk_process_vq(VuDev *vu_dev, int idx) > @@ -94,7 +97,7 @@ static void vu_blk_process_vq(VuDev *vu_dev, int idx) > Coroutine *co = > qemu_coroutine_create(vu_blk_virtio_process_req, req); > > - vhost_user_server_ref(server); > + vhost_user_server_inc_in_flight(server); > qemu_coroutine_enter(co); > } > } > diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c > index 5b6216069c..1622f8cfb3 100644 > --- a/util/vhost-user-server.c > +++ b/util/vhost-user-server.c > @@ -75,16 +75,16 @@ static void panic_cb(VuDev *vu_dev, const char *buf) > error_report("vu_panic: %s", buf); > } > > -void vhost_user_server_ref(VuServer *server) > +void vhost_user_server_inc_in_flight(VuServer *server) > { > assert(!server->wait_idle); > - server->refcount++; > + server->in_flight++; > } > > -void vhost_user_server_unref(VuServer *server) > +void vhost_user_server_dec_in_flight(VuServer *server) > { > - server->refcount--; > - if (server->wait_idle && !server->refcount) { > + server->in_flight--; > + if (server->wait_idle && !server->in_flight) { > aio_co_wake(server->co_trip); > } > } > @@ -192,13 +192,13 @@ static coroutine_fn void vu_client_trip(void *opaque) > /* Keep running */ > } > > - if (server->refcount) { > + if (server->in_flight) { > /* Wait for requests to complete before we can unmap the memory */ > server->wait_idle = true; > qemu_coroutine_yield(); > server->wait_idle = false; > } > - assert(server->refcount == 0); > + assert(server->in_flight == 0); > > vu_deinit(vu_dev); > Reviewed-by: Paolo Bonzini From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:43:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:43:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517870.803790 (Exim 4.92) (envelope-from ) id 1pjgwb-0004PC-TQ; Tue, 04 Apr 2023 13:43:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517870.803790; Tue, 04 Apr 2023 13:43:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgwb-0004P5-QW; Tue, 04 Apr 2023 13:43:29 +0000 Received: by outflank-mailman (input) for mailman id 517870; Tue, 04 Apr 2023 13:43:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgwa-0004Oz-2D for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:43:28 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac7d1973-d2ee-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 15:43:26 +0200 (CEST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-sOwozmLYNka3ioryJDhGRA-1; Tue, 04 Apr 2023 09:43:24 -0400 Received: by mail-ed1-f72.google.com with SMTP id s30-20020a508d1e000000b005005cf48a93so45831605eds.8 for ; Tue, 04 Apr 2023 06:43:23 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id tp24-20020a170907c49800b00948c320fcfdsm2099432ejc.202.2023.04.04.06.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:43:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac7d1973-d2ee-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680615805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=banha77N8+B6dxSVSxrCs92gu1rjIC58TeHKkpj1HpY=; b=EhtOVeFUA+/eJpC5yUkkyuanpN2dGoPHlXpaEhKQ++x02jdlobL4TbEMdL2o+Tzf2AkIHT Z1p+waU+cYdo9f9hkMScwjxGXa/NTPftL2GUEiJAOk2F3rXD5tzUL0/WmNbkzL304Dg7Am nKydMtZCcY44tC4vVPVYQL57SykOgm8= X-MC-Unique: sOwozmLYNka3ioryJDhGRA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615803; x=1683207803; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=banha77N8+B6dxSVSxrCs92gu1rjIC58TeHKkpj1HpY=; b=dxGkdqudtTO4x5Asj2HNhA34vnvbGlZ7DLyRbk4L4yfhOVImESaCkyMN7Hqn4BVHmh DfhhY4Z3qT8tFIUUzpOyHhs86R2Ct+XNCYDcMcCsRAhfelYsib0DOhyHKqWt8Nlx0knQ 8sKr482fIogH7YS3n5P2Uhd0gGDQY7/F/IViLZKPnCrp6O4TRCUYJ6L2vmGDtHmZDvGj PtQoEdX99U9gNrVNucskcY6hefxPrrrLqUu+x87Y+wBJfWEG412Sb4ARIJke95JYQSOP DivZapQO7Vjv/7i7KlBT8otkvqk6r1GOK6Z4IN+RSw97fAOdcwQtKtNL0jaar1pw9OrF QlUA== X-Gm-Message-State: AAQBX9dEwKl3sD9K4+TwL80eECOh8uXbu97OYtxQ0DX9Xb+DsxLxVfWl kLExiaDIUbzHcacJyb7d2Eqhi8SMaYwlSJAIuUDd9QP9Gti1fBTK03RZzATH7Q/348YUOhmhAGO 9nbHGirbAlDIKGfR0QV1Zx59qQ0U= X-Received: by 2002:a17:907:6b87:b0:93c:efaf:ba75 with SMTP id rg7-20020a1709076b8700b0093cefafba75mr2282159ejc.37.1680615802912; Tue, 04 Apr 2023 06:43:22 -0700 (PDT) X-Google-Smtp-Source: AKy350ZNWNaNuwDkGHAuaeEc6X1s7r9xa0mDxtFhP32ZOx76xJcO7cMfakVgb34HP4JHYtrJgHQzvw== X-Received: by 2002:a17:907:6b87:b0:93c:efaf:ba75 with SMTP id rg7-20020a1709076b8700b0093cefafba75mr2282128ejc.37.1680615802626; Tue, 04 Apr 2023 06:43:22 -0700 (PDT) Message-ID: <261efade-683e-84dc-d402-7143be7199c3@redhat.com> Date: Tue, 4 Apr 2023 15:43:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 00/13] block: remove aio_disable_external() API To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Anthony Perard References: <20230403183004.347205-1-stefanha@redhat.com> From: Paolo Bonzini In-Reply-To: <20230403183004.347205-1-stefanha@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/3/23 20:29, Stefan Hajnoczi wrote: > The aio_disable_external() API temporarily suspends file descriptor monitoring > in the event loop. The block layer uses this to prevent new I/O requests being > submitted from the guest and elsewhere between bdrv_drained_begin() and > bdrv_drained_end(). > > While the block layer still needs to prevent new I/O requests in drained > sections, the aio_disable_external() API can be replaced with > .drained_begin/end/poll() callbacks that have been added to BdrvChildClass and > BlockDevOps. > > This newer .bdrained_begin/end/poll() approach is attractive because it works > without specifying a specific AioContext. The block layer is moving towards > multi-queue and that means multiple AioContexts may be processing I/O > simultaneously. > > The aio_disable_external() was always somewhat hacky. It suspends all file > descriptors that were registered with is_external=true, even if they have > nothing to do with the BlockDriverState graph nodes that are being drained. > It's better to solve a block layer problem in the block layer than to have an > odd event loop API solution. > > That covers the motivation for this change, now on to the specifics of this > series: > > While it would be nice if a single conceptual approach could be applied to all > is_external=true file descriptors, I ended up looking at callers on a > case-by-case basis. There are two general ways I migrated code away from > is_external=true: > > 1. Block exports are typically best off unregistering fds in .drained_begin() > and registering them again in .drained_end(). The .drained_poll() function > waits for in-flight requests to finish using a reference counter. > > 2. Emulated storage controllers like virtio-blk and virtio-scsi are a little > simpler. They can rely on BlockBackend's request queuing during drain > feature. Guest I/O request coroutines are suspended in a drained section and > resume upon the end of the drained section. Sorry, I disagree with this. Request queuing was shown to cause deadlocks; Hanna's latest patch is piling another hack upon it, instead in my opinion we should go in the direction of relying _less_ (or not at all) on request queuing. I am strongly convinced that request queuing must apply only after bdrv_drained_begin has returned, which would also fix the IDE TRIM bug reported by Fiona Ebner. The possible livelock scenario is generally not a problem because 1) outside an iothread you have anyway the BQL that prevents a vCPU from issuing more I/O operations during bdrv_drained_begin 2) in iothreads you have aio_disable_external() instead of .drained_begin(). It is also less tidy to start a request during the drained_begin phase, because a request that has been submitted has to be completed (cancel doesn't really work). So in an ideal world, request queuing would not only apply only after bdrv_drained_begin has returned, it would log a warning and .drained_begin() should set up things so that there are no such warnings. Thanks, Paolo From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:46:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:46:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517873.803799 (Exim 4.92) (envelope-from ) id 1pjgzj-000505-B6; Tue, 04 Apr 2023 13:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517873.803799; Tue, 04 Apr 2023 13:46:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgzj-0004zy-8S; Tue, 04 Apr 2023 13:46:43 +0000 Received: by outflank-mailman (input) for mailman id 517873; Tue, 04 Apr 2023 13:46:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjgzi-0004zr-P8 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:46:42 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20184499-d2ef-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:46:40 +0200 (CEST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-mct8Gp3fNoy_iDMr5PIPuw-1; Tue, 04 Apr 2023 09:46:38 -0400 Received: by mail-ed1-f71.google.com with SMTP id j21-20020a508a95000000b004fd82403c91so45818213edj.3 for ; Tue, 04 Apr 2023 06:46:37 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id ae14-20020a17090725ce00b00947a939f6e0sm5693767ejc.77.2023.04.04.06.46.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:46:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20184499-d2ef-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680615999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EOC5xMNB8TKUwhrqSALMGxTnLF38Hs5nrhrqBLl6nYM=; b=diswIHp3Kk8bHBFXDoC1xDGSmIUco8xblMdh2DwNsGJqx1gOWL07Ka+N52QlWzwF93nF0Y 4H0C/jfL5xGjK0fSqDPcgKJW+Nd72ImQc18OHjU8TOVNZ/QviIk806kC1RIUdmSW9j/877 NKbRnQML6TtJFAdS4bIiqz4d/B2bvUU= X-MC-Unique: mct8Gp3fNoy_iDMr5PIPuw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615997; x=1683207997; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EOC5xMNB8TKUwhrqSALMGxTnLF38Hs5nrhrqBLl6nYM=; b=Xas72rhRFB8hxvoiNnmzetw0397IEIEncBJ8+v2jPKQK9nvqgKN5V5GYyc/7y3ruUL bdqevhapMi8Bbt80J8Y00t8VKIJ+7l1KUv/vmxisPEd5ghgpefqN+AMhLa/2sb3hHgWJ Hf8zYj7aEO0xbjciL33uusWrCXsk++oRHllgV4EeKFQ1c8s9G8qX87wEwr4Vakncyxpo fhnAlnUM1TDPIT6bi2pZbOC2aHv7Xg5U3hn9nFPhvGld7GHzhOG2xNGXjD4OWrRbl7Hn OAXuiShk9R5yiATRuLyRY9ZfolAC/Dy1CSFdRpRJ1zB2y1V3oPt8uKdWNoPJ77z9qQcw T3bQ== X-Gm-Message-State: AAQBX9ejd+YzgALL8NJ1fI1t4t/25vFeadOHKgTLFCkuKp3OWluBtl5x LLJSFzDKV0ZuC9/F5SWhvHYUjvxuqf9EpKGvTyOwcR/0shyx72EHDvUKkVzz09JuUW3xFNhxHsx BmvIPiJd1FLfMGSwyuDjKNLFP7U8= X-Received: by 2002:a17:907:8a24:b0:947:791b:fdcb with SMTP id sc36-20020a1709078a2400b00947791bfdcbmr2640629ejc.21.1680615996937; Tue, 04 Apr 2023 06:46:36 -0700 (PDT) X-Google-Smtp-Source: AKy350ZKGn72BpwOfdhCDqdjHSKetYDAkrw483POzylVVBOQOp0vZ1sAfoVpUPVCPr98oRDnQvzcCQ== X-Received: by 2002:a17:907:8a24:b0:947:791b:fdcb with SMTP id sc36-20020a1709078a2400b00947791bfdcbmr2640574ejc.21.1680615996616; Tue, 04 Apr 2023 06:46:36 -0700 (PDT) Message-ID: <92b731c7-81d4-ef54-cca9-9dcb944e94f0@redhat.com> Date: Tue, 4 Apr 2023 15:46:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 11/13] block/fuse: take AioContext lock around blk_exp_ref/unref() To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Anthony Perard References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-12-stefanha@redhat.com> From: Paolo Bonzini In-Reply-To: <20230403183004.347205-12-stefanha@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/3/23 20:30, Stefan Hajnoczi wrote: > These functions must be called with the AioContext acquired: > > /* Callers must hold exp->ctx lock */ > void blk_exp_ref(BlockExport *exp) > ... > /* Callers must hold exp->ctx lock */ > void blk_exp_unref(BlockExport *exp) > > Signed-off-by: Stefan Hajnoczi > --- > block/export/fuse.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/block/export/fuse.c b/block/export/fuse.c > index 06fa41079e..18394f9e07 100644 > --- a/block/export/fuse.c > +++ b/block/export/fuse.c > @@ -244,7 +244,9 @@ static void read_from_fuse_export(void *opaque) > FuseExport *exp = opaque; > int ret; > > + aio_context_acquire(exp->common.ctx); > blk_exp_ref(&exp->common); > + aio_context_release(exp->common.ctx); > > do { > ret = fuse_session_receive_buf(exp->fuse_session, &exp->fuse_buf); > @@ -256,7 +258,9 @@ static void read_from_fuse_export(void *opaque) > fuse_session_process_buf(exp->fuse_session, &exp->fuse_buf); > > out: > + aio_context_acquire(exp->common.ctx); > blk_exp_unref(&exp->common); > + aio_context_release(exp->common.ctx); > } Since the actual thread-unsafe work is done in a bottom half, perhaps instead you can use qatomic_inc and qatomic_fetch_dec in blk_exp_{ref,unref}? Paolo From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:48:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517876.803810 (Exim 4.92) (envelope-from ) id 1pjh0r-0005X0-M4; Tue, 04 Apr 2023 13:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517876.803810; Tue, 04 Apr 2023 13:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjh0r-0005Ws-I7; Tue, 04 Apr 2023 13:47:53 +0000 Received: by outflank-mailman (input) for mailman id 517876; Tue, 04 Apr 2023 13:47:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjh0q-0005Wk-3m for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:47:52 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49ac961a-d2ef-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:47:50 +0200 (CEST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-soMn4lKEOgS4lM9Mr4vtAQ-1; Tue, 04 Apr 2023 09:47:45 -0400 Received: by mail-ed1-f69.google.com with SMTP id u30-20020a50c05e000000b0050299de3f82so10374672edd.10 for ; Tue, 04 Apr 2023 06:47:45 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id u25-20020a170906109900b008e22978b98bsm5996684eju.61.2023.04.04.06.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:47:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49ac961a-d2ef-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680616069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NXZVAuXURCCUeEyCJ3Apt7MqMRoeGh4PQRIsfTgOkBg=; b=Y+VGdb+cQ0Un1Bfr731INk2BFXRgrmxlmd8dH6m6QAfIFciwB3qKeAeZOSPPUZthpsF70O KajTWvXkThnPdZNW6Ha+ZIMFj9qdbmdudX8LZ56oCrE7EootRaLN/kcyps5BhCAnay0yVl SzxUZzQ97067GL9bRpzUqiNiNcVxVF4= X-MC-Unique: soMn4lKEOgS4lM9Mr4vtAQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680616065; x=1683208065; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NXZVAuXURCCUeEyCJ3Apt7MqMRoeGh4PQRIsfTgOkBg=; b=GJjzaPP6j2RNmErkH7tg+w6Kj1i5jqPJsLvOdm7QCAlks+ZSDmGbUlo672hUG4KHar WUxNt+thSENTuQTJ2ODSydGI4IW2d6fT9JIrBdqbStM58RC4VpXVYB/RtcgXc9+bUbpL zy4Ik3ekZhUFqctgUL9F1SlL26tEjajc2pVGnJtocAJ9ME7TeEFkIR01lmyXREb8QwcE zId1quFZQwvz2PMmMPc+pIklOUWNeOTCWO02CyEZnEmYbI5WFGbn4cQ67dJHGmrFdaWn zx+AIy/gs/3AFVDq89mRL4OC1RRVAWfEVmR6co5d9soiAb2lfnUYsY9pbOF6RKniSYmx 6D2w== X-Gm-Message-State: AAQBX9cs3N+bWxWlBOF+nz5NAVCMim7xKlscvwYP2Mjh/w02DHgmiGWW A+HjG197yAkxxYe3M5+PBPIL1VZIP4zBrY4ZDJxrH3UeQTRxzEQPDXiQvwjCrt12new5m0PuY8n QZNPbB/8hbBLwRBprvkF3LYfk73g= X-Received: by 2002:a17:906:68ca:b0:931:b4d3:fc7f with SMTP id y10-20020a17090668ca00b00931b4d3fc7fmr2638023ejr.30.1680616064890; Tue, 04 Apr 2023 06:47:44 -0700 (PDT) X-Google-Smtp-Source: AKy350bTUWpDfEkQMztCXSp3lAzmKMLlNkSrHzGGYgK9EE7DOW/ArYgtjIo2Ha6U6gSgxkvegrzexA== X-Received: by 2002:a17:906:68ca:b0:931:b4d3:fc7f with SMTP id y10-20020a17090668ca00b00931b4d3fc7fmr2638000ejr.30.1680616064630; Tue, 04 Apr 2023 06:47:44 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 15:47:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event To: Stefan Hajnoczi , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Anthony Perard References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-2-stefanha@redhat.com> <2bbe988c-0802-55c3-b2a3-05e3f94e2f04@linaro.org> <20230404130658.GG428487@fedora> From: Paolo Bonzini In-Reply-To: <20230404130658.GG428487@fedora> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/4/23 15:06, Stefan Hajnoczi wrote: >> Would this be more useful as a qdev_is_realized() helper? > Yes. There are no other users, but I think a helper makes sense. Agreed; anyway, Reviewed-by: Paolo Bonzini Paolo From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:48:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517878.803820 (Exim 4.92) (envelope-from ) id 1pjh1s-00064o-W9; Tue, 04 Apr 2023 13:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517878.803820; Tue, 04 Apr 2023 13:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjh1s-00064g-T7; Tue, 04 Apr 2023 13:48:56 +0000 Received: by outflank-mailman (input) for mailman id 517878; Tue, 04 Apr 2023 13:48:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjh1r-000645-2z for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:48:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20617.outbound.protection.outlook.com [2a01:111:f400:7d00::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ea399f3-d2ef-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:48:51 +0200 (CEST) Received: from DU2PR04CA0327.eurprd04.prod.outlook.com (2603:10a6:10:2b5::32) by DU0PR08MB9824.eurprd08.prod.outlook.com (2603:10a6:10:443::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 13:48:49 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::dc) by DU2PR04CA0327.outlook.office365.com (2603:10a6:10:2b5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22 via Frontend Transport; Tue, 4 Apr 2023 13:48:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.22 via Frontend Transport; Tue, 4 Apr 2023 13:48:48 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Tue, 04 Apr 2023 13:48:48 +0000 Received: from b5273e95bc26.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C0E0D05A-41F1-4CB3-8A13-790796B09FB8.1; Tue, 04 Apr 2023 13:48:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b5273e95bc26.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Apr 2023 13:48:37 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com (2603:10a6:208:ff::27) by DU0PR08MB9396.eurprd08.prod.outlook.com (2603:10a6:10:423::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 13:48:34 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::7b58:72de:8c37:5104]) by AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::7b58:72de:8c37:5104%6]) with mapi id 15.20.6254.033; Tue, 4 Apr 2023 13:48:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ea399f3-d2ef-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yu4G5C5PAz4602WPmtEDrxcOgB32F/GfLy1j4u4kXq4=; b=ChSO1tDiwBHwHSg4cspdN2v239HQfqI+k3VD3oq2iNo5a2J22+UolWFWprwAbHyg4Kk7xxWWi17R9oZTVYf4zg4fUsf0lNobqlXRMUgwoK/2wRy3dPfapJdsoR6CZ8yEFOQOXxWCEm0O9npWKiyWGbYxdNilUAQwEWBVDwpyLmU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8a7c52f910f13e3e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y77Pmyo5vpXOmzKkJG6aKdl4TwdtzFrg5QSdlxAubVExdq/OevnWC5wlV5EnYeNzQ0OcrH1cSRI7JRpaURti++raDcHth06HESKl7yIBTByJxDL9oZ4vWD0TCowVkAj6eaXO2909yR4P7CYhdaNreqfawhHxX5/o7GcB9ji/hgiPYSwDyqSisrDmuiYKd3U4iyWjCJwjjSMgUJg7uiZ0nta7sDiFOkLKUMmfWDSRnDtQ4HlpNJ0kBL1WT/BvOM1gEMgQp3cycSIyr25BdOG0LrINCjbSji3nSpDSHuAffUAg5AcZ5xKuTGZsEsDMHd0OG9a19MxRLUbNchSQMZG8fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yu4G5C5PAz4602WPmtEDrxcOgB32F/GfLy1j4u4kXq4=; b=j2WZ6zbuRzT8+PlbW470uczrj7E7v1D+xhwtFA2MbAthaofo8Ly/xZ6mCRxnhDl7z2o9CrVXqHnbzl06xla8S8s5w2bg3LW2L2d6nE8Ii9i+vJDmPGusXNeCWNHMhGgCJTKr8UIom4/5FDYp65jwtq2REeg4IvszYCoffLUalNaseG6a7pNfrd9iyBDxICwrpqDngU5sTHoXGM/Fspk/jAbW2Aqe5wBKhRIkmEBRvHQw6dlN7NYGa8HRpmTTbysw/b5DcwWzN4TJ81Ya6ySMndGxmJiO/KSzcQgn7CWBWdqcqA7qcEJ5WRyvxPMcJWbrXvIIVasCrxJ7MQVDFPZx1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yu4G5C5PAz4602WPmtEDrxcOgB32F/GfLy1j4u4kXq4=; b=ChSO1tDiwBHwHSg4cspdN2v239HQfqI+k3VD3oq2iNo5a2J22+UolWFWprwAbHyg4Kk7xxWWi17R9oZTVYf4zg4fUsf0lNobqlXRMUgwoK/2wRy3dPfapJdsoR6CZ8yEFOQOXxWCEm0O9npWKiyWGbYxdNilUAQwEWBVDwpyLmU= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross , George Dunlap Subject: Re: [PATCH v4 10/12] xen/tools: add sve parameter in XL configuration Thread-Topic: [PATCH v4 10/12] xen/tools: add sve parameter in XL configuration Thread-Index: AQHZYJtmX5JG1Zpok0mjr+irvDjf6q8U92AAgAY/qIA= Date: Tue, 4 Apr 2023 13:48:34 +0000 Message-ID: <328A9CBD-5FCE-481B-93AF-D139963488D5@arm.com> References: <20230327105944.1360856-1-luca.fancellu@arm.com> <20230327105944.1360856-11-luca.fancellu@arm.com> <9bd2924b-bb4a-440d-ae31-0253e66c56e5@perard> In-Reply-To: <9bd2924b-bb4a-440d-ae31-0253e66c56e5@perard> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3745:EE_|DU0PR08MB9396:EE_|DBAEUR03FT019:EE_|DU0PR08MB9824:EE_ X-MS-Office365-Filtering-Correlation-Id: d29897bf-f5a4-4ab3-b278-08db35135169 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KDc67oFzZs6C6dfrCcNHtXqvDa74BtN+tpfKg+oDzBewcVhCJndnH34TiE/t5j6PtFfxfPxUUHv4PK2+ohM23NAR2c6e5ItqF2wm43nj6jswniBBT0vv6zpTs4E0PIx9fdFlQ72sISliZhn0N1mpgyLsV8oYt+KlaPORkEMZxX4F4YHJ3ob30Vt7s8gNb8dCiZJLnz/lv4Pd2yCIioCjAjq3zttHOlyfMwZGsu0vHr2rJqMZKzXF3EtKy/TgR/9VqpF+Uzqs9wFUZi9vqzqI9QQJ47fnmJGAj+E0lr4fElhg1UrHGrZStwdcpJSa/tTaKVF4MJF6IXaU/jyx0xflt6SdJ8IQ37c0V7BEPxJT5gZ7AwW5tKeeK8BCWUU8bYXTFHzsQU1goF2bsa6xBjA9SNv/UKVbFiUhrKpM6kALWitSRj2Kk2OqJ0VSadfMbxD6AFHvbRTmoNej58TkA+3Q/iMz6KPHN1kcFMr3JNiyz38ock6j8v9yl/nHLD/4SOqIfznmNs/vdyTQnIujNBDmJTpHKhmt+7ZyVDlaaAUG9GuPsFwYTKRmVURMtAtJUW9y2mzqgiWnZOBP5h/oOI2pv0oYYVuYwFOyBcao7gDcHm1QxdWg55iCu5A41giQMtJ+ViA84hTE7gJK1tncRNh6aQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3745.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199021)(38070700005)(6512007)(26005)(6506007)(33656002)(86362001)(36756003)(53546011)(122000001)(2616005)(83380400001)(38100700002)(186003)(66446008)(66556008)(91956017)(66476007)(66946007)(64756008)(478600001)(76116006)(2906002)(6916009)(4326008)(5660300002)(8676002)(316002)(41300700001)(8936002)(71200400001)(54906003)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <73907EEA8D744543B8238637242D9E44@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9396 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 21826133-0d7d-48dc-9e91-08db351348b2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qVuSKC7yfB3hKC7oQ9H9IbOO/rcNRFE2jmBjPAlkK/gDZRQYi5GJGCClfkON6RGSbBGms2b38BJrkAd8Snr6YTCCE/H0aewV9jdVjnDRe9V4exr0v52hZXSYlLbJqbBwmPuz+K3m90K0o6WycmO/9QB5NMs8xwrFa7Z0ZlFzGtmJEnoqiSICF8Jg3+8k+Nfo8CQN3CbfogSRj3egIMUuEIaEVsIc+eXA9wqwIBRLwid6YsgspyEclXANNeambWBlLSY5+pRfaqFkVfCTTX6QuaeZpK2lcQCBouG5OUpkJm7Rxx5NHG3TevYsjk9/ThmhNP4JcXqB7s1D6JeChqGbwSmBbUuu/vSD2tj8d4VVjFmMBsLElKS4Yt9vBGrGLQ2RygKXQRd0evsHkCnjmO3yemfUOyMrVHZNudlR66Nk7KO29LOM+HkB2XdN/ArzK/Qof8LSPGj/gRX8fmtT3c1twHG6rwVWwBlG9s44qAfI5edmzsElFNeL/+WiCP//pPkHEa7jtqz2QpeNNjN/ywXO14LluR+kvI4wQvao3xfq/eUO44jMSYo9aSb4HqbnLw9tCIEdXtREPfPFQE77NlKW6m75lS6D5KuwYdLMs/FJ62PgVeW0Xd0j2841PKanzkjulOZlmw9AeIOT+on6D5Lz1qdsMX20bT0HfbnrAljlIdqfqTJI4k33k8Osy7la8/4bBcuUXpUgALqeaQOOt76HlQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(36840700001)(46966006)(40470700004)(186003)(82310400005)(26005)(107886003)(53546011)(6506007)(41300700001)(4326008)(336012)(2616005)(70586007)(316002)(6512007)(70206006)(47076005)(54906003)(478600001)(40460700003)(8676002)(6486002)(36756003)(82740400003)(356005)(33656002)(81166007)(86362001)(6862004)(2906002)(36860700001)(83380400001)(8936002)(5660300002)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 13:48:48.8808 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d29897bf-f5a4-4ab3-b278-08db35135169 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9824 DQoNCkhpIEFudGhvbnksDQoNClRoYW5rcyBmb3IgeW91ciByZXZpZXcNCg0KPiBPbiAzMSBNYXIg MjAyMywgYXQgMTU6MjMsIEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29t PiB3cm90ZToNCj4gDQo+IE9uIE1vbiwgTWFyIDI3LCAyMDIzIGF0IDExOjU5OjQyQU0gKzAxMDAs IEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9tYW4veGwuY2ZnLjUu cG9kLmluIGIvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+PiBpbmRleCAxMGYzNzk5MGJlNTcu LmFkZjQ4ZmU4YWMxZCAxMDA2NDQNCj4+IC0tLSBhL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbg0K Pj4gKysrIGIvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+PiBAQCAtMjk1Miw2ICsyOTUyLDE3 IEBAIEN1cnJlbnRseSwgb25seSB0aGUgInNic2FfdWFydCIgbW9kZWwgaXMgc3VwcG9ydGVkIGZv ciBBUk0uDQo+PiANCj4+ID1iYWNrDQo+PiANCj4+ICs9aXRlbSBCPHN2ZT0iTlVNQkVSIj4NCj4+ ICsNCj4+ICtUbyBlbmFibGUgU1ZFLCB1c2VyIG11c3Qgc3BlY2lmeSBhIG51bWJlciBkaWZmZXJl bnQgZnJvbSB6ZXJvLCBtYXhpbXVtIDIwNDggYW5kDQo+PiArbXVsdGlwbGUgb2YgMTI4LiBUaGF0 IHZhbHVlIHdpbGwgYmUgdGhlIG1heGltdW0gbnVtYmVyIG9mIFNWRSByZWdpc3RlcnMgYml0cw0K Pj4gK3RoYXQgdGhlIGh5cGVydmlzb3Igd2lsbCBpbXBvc2UgdG8gdGhpcyBndWVzdC4gSWYgdGhl IHBsYXRmb3JtIGhhcyBhIGxvd2VyDQo+IA0KPiBNYXliZSBzdGFydCBieSBkZXNjcmliaW5nIHdo YXQgdGhlICJzdmUiIHZhbHVlIGlzIGJlZm9yZSBpbXBvc2luZw0KPiBsaW1pdHMuIE1heWJlIHNv bWV0aGluZyBsaWtlOg0KPiANCj4gICAgU2V0IHRoZSBtYXhpbXVtIHZlY3RvciBsZW5ndGggdGhh dCBhIGd1ZXN0J3MgU2NhbGFibGUgVmVjdG9yDQo+ICAgIEV4dGVuc2lvbiAoU1ZFKSBjYW4gdXNl LiBPciBkaXNhYmxlIGl0IGJ5IHNwZWNpZnlpbmcgMCwgdGhlIGRlZmF1bHQuDQo+IA0KPiAgICBW YWx1ZSBuZWVkcyB0byBiZSBhIG11bHRpcGxlIG9mIDEyOCwgd2l0aCBhIG1heGltdW0gb2YgMjA0 OCBvciB0aGUNCj4gICAgbWF4aW11bSBzdXBwb3J0ZWQgYnkgdGhlIHBsYXRmb3JtLg0KPiANCj4g V291bGQgdGhpcywgb3Igc29tZXRoaW5nIGxpa2UgdGhhdCBiZSBhIGdvb2QgZXhwbGFuYXRpb24g b2YgdGhlICJzdmUiDQo+IGNvbmZpZ3VyYXRpb24gb3B0aW9uPw0KDQpZZXMgSSBjYW4gY2hhbmdl IGl0LCBhIG5lZWQgdG8gZG8gaXQgYW55d2F5IGJlY2F1c2UgSSB0aGluayBhbHNvIGhlcmUsIHRo ZSBzdWdnZXN0aW9uDQpGcm9tIEphbiBjYW4gYXBwbHkgYW5kIHdlIGNvdWxkIHBhc3MgYSBuZWdh dGl2ZSB2YWx1ZSB0aGF0IG1lYW5zIOKAnG1heCBWTCBzdXBwb3J0ZWQNCmJ5IHRoZSBwbGF0Zm9y bSINCg0KPiANCj4+ICtzdXBwb3J0ZWQgYml0cyB2YWx1ZSwgdGhlbiB0aGUgZG9tYWluIGNyZWF0 aW9uIHdpbGwgZmFpbC4NCj4+ICtBIHZhbHVlIGVxdWFsIHRvIHplcm8gaXMgdGhlIGRlZmF1bHQg YW5kIGl0IG1lYW5zIHRoaXMgZ3Vlc3QgaXMgbm90IGFsbG93ZWQgdG8NCj4+ICt1c2UgU1ZFLg0K Pj4gKw0KPj4gKz1iYWNrDQo+PiArDQo+PiA9aGVhZDMgeDg2DQo+PiANCj4+ID1vdmVyIDQNCj4+ IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jIGIvdG9vbHMvbGlicy9s aWdodC9saWJ4bF9hcm0uYw0KPj4gaW5kZXggZGRjN2IyYTE1OTc1Li4xNmE0OTAzMWZkNTEgMTAw NjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+PiArKysgYi90b29s cy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+PiBAQCAtMjExLDYgKzIxMSw4IEBAIGludCBsaWJ4 bF9fYXJjaF9kb21haW5fcHJlcGFyZV9jb25maWcobGlieGxfX2djICpnYywNCj4+ICAgICAgICAg cmV0dXJuIEVSUk9SX0ZBSUw7DQo+PiAgICAgfQ0KPj4gDQo+PiArICAgIGNvbmZpZy0+YXJjaC5z dmVfdmwgPSBkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfYXJtLnN2ZTsNCj4gDQo+IFRoaXMgdHJ1bmNh dGUgYSAxNmJpdCB2YWx1ZSBpbnRvIGFuIDhiaXQgdmFsdWUsIEkgdGhpbmsgeW91IHNob3VsZCBj aGVjaw0KPiB0aGF0IHRoZSB2YWx1ZSBjYW4gYWN0dWFsbHkgZml0Lg0KPiANCj4gQW5kIG1heWJl IGNoZWNrIGBkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfYXJtLnN2ZWAgdmFsdWUgaGVyZSBpbnN0ZWFk IG9mDQo+IGB4bGAgYXMgY29tbWVudGVkIGxhdGVyLg0KDQpZZXMgSSBjYW4gZG8gaXQsIG9uZSBx dWVzdGlvbiwgY2FuIEkgdXNlIGhlcmUgeGNfcGh5c2luZm8gdG8gcmV0cmlldmUgdGhlIG1heGlt dW0NClZlY3RvciBsZW5ndGggZnJvbSBhcmNoX2NhcGFiaWxpdGllcz8NCkkgbWVhbiwgaXMgdGhl cmUgYSBiZXR0ZXIgd2F5IG9yIEkgY2FuIGdvIGZvciB0aGF0Pw0KDQo+IA0KPj4gKw0KPj4gICAg IHJldHVybiAwOw0KPj4gfQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9s aWJ4bF90eXBlcy5pZGwgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4gaW5k ZXggZmQzMWRhY2Y3ZDVhLi5lZjRhODM1OGU1NGUgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJz L2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF90 eXBlcy5pZGwNCj4+IEBAIC02OTAsNiArNjkwLDcgQEAgbGlieGxfZG9tYWluX2J1aWxkX2luZm8g PSBTdHJ1Y3QoImRvbWFpbl9idWlsZF9pbmZvIixbDQo+PiANCj4+ICAgICAoImFyY2hfYXJtIiwg U3RydWN0KE5vbmUsIFsoImdpY192ZXJzaW9uIiwgbGlieGxfZ2ljX3ZlcnNpb24pLA0KPj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICgidnVhcnQiLCBsaWJ4bF92dWFydF90eXBlKSwN Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCJzdmUiLCB1aW50MTYpLA0KPiAN Cj4gSSB3b25kZXIgaWYgcmVuYW1pbmcgInN2ZSIgdG8gInN2ZV92bCIgaGVyZSB3b3VsZCBtYWtl IHNlbnNlLCBzZWVpbmcNCj4gdGhhdCAic3ZlX3ZsIiBpcyBhY3R1YWxseSB1c2VkIGluIG90aGVy IHBsYWNlcy4NCg0KWWVzIEkgY2FuIHJlbmFtZSBpdCBhcyBzdmVfdmwsIEkgd2lsbCBhbHNvIGNo YW5nZSB0aGUgdHlwZSB0byDigJxpbnRlZ2VyIg0KDQo+IA0KPj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXSkpLA0KPj4gICAgICgiYXJjaF94ODYiLCBTdHJ1Y3QoTm9uZSwgWygibXNy X3JlbGF4ZWQiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF0pKSwNCj4+IGRpZmYgLS1naXQgYS90b29scy94bC94bF9wYXJzZS5jIGIvdG9vbHMveGwv eGxfcGFyc2UuYw0KPj4gaW5kZXggMWY2ZjQ3ZGFmNGUxLi4zY2JjMjNiMzY5NTIgMTAwNjQ0DQo+ PiAtLS0gYS90b29scy94bC94bF9wYXJzZS5jDQo+PiArKysgYi90b29scy94bC94bF9wYXJzZS5j DQo+PiBAQCAtMTIsNiArMTIsNyBAQA0KPj4gICogR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+PiAgKi8NCj4+IA0KPj4gKyNpbmNsdWRlIDxhcm0t YXJjaC1jYXBhYmlsaXRpZXMuaD4NCj4gDQo+IENvdWxkIHlvdSBhZGQgdGhpcyBoZWFkZXJzIGFm dGVyIHB1YmxpYyBvbmVzPw0KDQpZZXMNCg0KPiANCj4+ICNpbmNsdWRlIDxjdHlwZS5oPg0KPj4g I2luY2x1ZGUgPGludHR5cGVzLmg+DQo+PiAjaW5jbHVkZSA8bGltaXRzLmg+DQo+PiBAQCAtMTMx Miw4ICsxMzEzLDYgQEAgdm9pZCBwYXJzZV9jb25maWdfZGF0YShjb25zdCBjaGFyICpjb25maWdf c291cmNlLA0KPj4gICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7DQo+PiAgICAgfQ0KPj4gDQo+ PiAtICAgIGxpYnhsX3BoeXNpbmZvX2Rpc3Bvc2UoJnBoeXNpbmZvKTsNCj4+IC0NCj4+ICAgICBj b25maWc9IHhsdV9jZmdfaW5pdChzdGRlcnIsIGNvbmZpZ19zb3VyY2UpOw0KPj4gICAgIGlmICgh Y29uZmlnKSB7DQo+PiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiRmFpbGVkIHRvIGFsbG9jYXRl IGZvciBjb25maWd1cmF0aW9uXG4iKTsNCj4+IEBAIC0yODg3LDYgKzI4ODYsMjkgQEAgc2tpcF91 c2JkZXY6DQo+PiAgICAgICAgIH0NCj4+ICAgICB9DQo+PiANCj4+ICsgICAgaWYgKCF4bHVfY2Zn X2dldF9sb25nIChjb25maWcsICJzdmUiLCAmbCwgMCkpIHsNCj4+ICsgICAgICAgIHVuc2lnbmVk IGludCBhcm1fc3ZlX3ZsID0NCj4+ICsgICAgICAgICAgICBhcmNoX2NhcGFiaWxpdGllc19hcm1f c3ZlKHBoeXNpbmZvLmFyY2hfY2FwYWJpbGl0aWVzKTsNCj4+ICsgICAgICAgIGlmICghYXJtX3N2 ZV92bCkgew0KPj4gKyAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiU1ZFIGlzIG5vdCBzdXBw b3J0ZWQgYnkgdGhlIHBsYXRmb3JtXG4iKTsNCj4+ICsgICAgICAgICAgICBleGl0KC1FUlJPUl9G QUlMKTsNCj4gDQo+ICJFUlJPUl9GQUlMIiBpcyBhICJsaWJ4bF9lcnJvciIsIGluc3RlYWQgZXhp dCB3aXRoICJFWElUX0ZBSUxVUkUiLg0KDQpPayBJIHdpbGwgdXNlIHRoZSByaWdodCB0eXBlDQoN Cj4gDQo+PiArICAgICAgICB9IGVsc2UgaWYgKCgobCAlIDEyOCkgIT0gMCkgfHwgKGwgPiAyMDQ4 KSkgew0KPj4gKyAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLA0KPj4gKyAgICAgICAgICAgICAg ICAgICAgIkludmFsaWQgc3ZlIHZhbHVlOiAlbGQuIE5lZWRzIHRvIGJlIDw9IDIwNDggYW5kIG11 bHRpcGxlIg0KPj4gKyAgICAgICAgICAgICAgICAgICAgIiBvZiAxMjhcbiIsIGwpOw0KPj4gKyAg ICAgICAgICAgIGV4aXQoLUVSUk9SX0ZBSUwpOw0KPj4gKyAgICAgICAgfSBlbHNlIGlmIChsID4g YXJtX3N2ZV92bCkgew0KPj4gKyAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLA0KPj4gKyAgICAg ICAgICAgICAgICAgICAgIkludmFsaWQgc3ZlIHZhbHVlOiAlbGQuIFBsYXRmb3JtIHN1cHBvcnRz IHVwIHRvICV1IGJpdHNcbiIsDQo+PiArICAgICAgICAgICAgICAgICAgICBsLCBhcm1fc3ZlX3Zs KTsNCj4+ICsgICAgICAgICAgICBleGl0KC1FUlJPUl9GQUlMKTsNCj4+ICsgICAgICAgIH0NCj4+ ICsgICAgICAgIC8qIFZlY3RvciBsZW5ndGggaXMgZGl2aWRlZCBieSAxMjggaW4gZG9tYWluIGNv bmZpZ3VyYXRpb24gc3RydWN0ICovDQo+IA0KPiBUaGF0J3Mgd3JvbmcsIGJlc2lkZSB0aGlzIGNv bW1lbnQgdGhlcmUncyBub3RoaW5nIHRoYXQgc2F5IHRoYXQNCj4gYGJfaW5mby0+YXJjaF9hcm0u c3ZlYCBuZWVkcyB0byBoYXZlIGEgdmFsdWUgZGl2aWRlZCBieSAxMjguDQo+IGBiX2luZm8tPmFy Y2hfYXJtLnN2ZWAgaXMganVzdCBvZiB0eXBlIHVpbnQxNl90IChsaWJ4bF90eXBlLmlkbCkuDQo+ IA0KPiBCVFcsICJ0b29scy94bCIgKHhsKSB1c2UganVzdCBvbmUgdXNlciBvZiAidG9vbHMvbGli cy9saWdodCIgKGxpYnhsKSwgc28NCj4gaXQncyBwb3NzaWJsZSB0aGF0IG90aGVyIHVzZXJzIHdv dWxkIHNldCBgc3ZlYCB0byBhIHZhbHVlIHRoYXQgaGF2ZW4ndA0KPiBiZWVuIGNoZWNrZWQuIFNv IEkgdGhpbmsgYWxsIHRoZSBjaGVjayB0aGF0IHRoZSBgc3ZlYCB2YWx1ZSBpcyBjb3JyZWN0DQo+ IGNvdWxkIGJlIGRvbmUgaW4gbGlieGwgaW5zdGVhZC4NCg0KU3VyZSBJIHdpbGwgZG8gdGhhdA0K DQo+IA0KPiANCj4+ICsgICAgICAgIGJfaW5mby0+YXJjaF9hcm0uc3ZlID0gbCAvIDEyOFU7DQo+ PiArICAgIH0NCj4+ICsNCj4+ICsgICAgbGlieGxfcGh5c2luZm9fZGlzcG9zZSgmcGh5c2luZm8p Ow0KPj4gKw0KPj4gICAgIHBhcnNlX3ZrYl9saXN0KGNvbmZpZywgZF9jb25maWcpOw0KPj4gDQo+ PiAgICAgZF9jb25maWctPnZpcnRpb3MgPSBOVUxMOw0KPiANCj4gVGhhbmtzLA0KPiANCj4gLS0g DQo+IEFudGhvbnkgUEVSQVJEDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Apr 04 13:51:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 13:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517883.803830 (Exim 4.92) (envelope-from ) id 1pjh4C-0007ZA-GM; Tue, 04 Apr 2023 13:51:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517883.803830; Tue, 04 Apr 2023 13:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjh4C-0007Z3-Df; Tue, 04 Apr 2023 13:51:20 +0000 Received: by outflank-mailman (input) for mailman id 517883; Tue, 04 Apr 2023 13:51:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjh4B-0007Yx-0X for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 13:51:19 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3bf9ca4-d2ef-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 15:51:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3bf9ca4-d2ef-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680616276; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=x0PaaBcjCtio6kfl56+tYMtF5+jnjOaDFGTwPHgx+5s=; b=Nt1t4USWaFa/DfpUMnaGqWyZ6raGi82wb+reqZ3jUZ6Ogzr7Udt42iCi huTWCtS7w7uR1U3NS6rGn4FiQvDD78RDvFvYFO0+laqtdea8sRCp2KVkl ws9E+kgJUTOrlz/Z9Hu8zQHz8gwOFUubIKTGKb09fljTJKWFo4R5X+F8X E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103067229 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:qK19D6O0RDxVFobvrR2ql8FynXyQoLVcMsEvi/4bfWQNrUp2hDAAn zdKW2mHafaIZmT9L91ybd/g8kkC75TRn4diTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uB3OWtk0 uITFCoydFPapubnnKu2bOY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUoXSHp0LwRzC9 woq+UzBGBcTMcKt5AOf61CFnu71rCLKdoA7QejQGvlC3wTImz175ActfVe2pPiRi0igWsleI UgZ5iovq6cp8EWhCNL6WnWQqWaJpBcGV/JMEucx70eGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhqgGqy89G3of3JPdClbOHFCFFFeizX+nG0tphTPdtxJN7C+ssfKA3Kp4 jTb8DEzobpG2KbnyJ6HEUD7byOE/8aZFlBtul6GAgpJ/SsiOtf7OtXABUzzqK8Zcd3HFgTpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKRBaJxslcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIoWP8QvJVXcpn8+DaJ144wKuBF0+ZzTx L/BKZr8ZZrkIf8PIMWKqxc1juZwm3FWKZL7TpHn1RW3uYejiIquYe5dajOmN7lphJ5oVS2Jq 76zwePWkUQAOAA/CwGLmbMuwacifCRiXsqv85MKHgNBSyI/cFwc5zbq6etJU+RYc259zI8kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:eC6zkakKtpA/BAnV6I88gvOIJKDpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.98,317,1673931600"; d="scan'208";a="103067229" Date: Tue, 4 Apr 2023 14:51:01 +0100 From: Anthony PERARD To: Andrew Cooper CC: , Demi Marie Obenour Subject: Re: [xen-unstable-smoke test] 179929: regressions - trouble: blocked/fail/pass/starved Message-ID: <20d41dd0-19d1-47fb-92ab-4de458ddd56f@perard> References: <17e95e93-a3a9-962c-1563-f9fc526320df@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <17e95e93-a3a9-962c-1563-f9fc526320df@citrix.com> On Fri, Mar 24, 2023 at 08:37:06PM +0000, Andrew Cooper wrote: > On 24/03/2023 8:28 pm, Andrew Cooper wrote: > > On 24/03/2023 6:58 pm, osstest service owner wrote: > >> flight 179929 xen-unstable-smoke real [real] > >> http://logs.test-lab.xenproject.org/osstest/logs/179929/ > >> > >> Regressions :-( > >> > >> Tests which did not succeed and are blocking, > >> including tests which could not be run: > >> build-amd64 6 xen-build fail REGR. vs. 179926 > > > > Bah. > > > > make[6]: Entering directory '/home/osstest/build.179929.build-amd64/xen/tools/firmware/etherboot' > > set -e; if ! /usr/bin/wget -c -O _ipxe.tar.gz https://xenbits.xen.org/xen-extfiles/ipxe-git-3c040ad387099483102708bb1839110bc788cefb.tar.gz; then \ > > git clone file:////osstest/IPXE-GIT-FORBIDDEN ipxe.git; \ > > (cd ipxe.git && git archive --format=tar --prefix=ipxe/ \ > > 3c040ad387099483102708bb1839110bc788cefb | gzip -n >../_ipxe.tar.gz); \ > > rm -rf ipxe.git; \ > > fi > > --2023-03-24 17:06:51-- https://xenbits.xen.org/xen-extfiles/ipxe-git-3c040ad387099483102708bb1839110bc788cefb.tar.gz > > Resolving cache (cache)... 172.16.148.6 > > Connecting to cache (cache)|172.16.148.6|:3128... connected. > > ERROR: The certificate of 'xenbits.xen.org' is not trusted. > > ERROR: The certificate of 'xenbits.xen.org' has expired. > > Cloning into 'ipxe.git'... > > fatal: '//osstest/IPXE-GIT-FORBIDDEN' does not appear to be a git repository > > fatal: Could not read from remote repository. > > > > That's OSSTest choking, apparently with the same LE root cert problem? > > Given that there's plenty of content wanting testing right now, and no > chance of this being looked at until next week, I've reverted e1d750844 > (which was just a single hunk anyway) in the hopes that we can still get > a useful weekend of testing The certificate of the HTTPS proxy has been renewed, and osstest has been updated to use the new certificates. So that commit should work. In other word, osstest is ready for a revert of b5cc3c25a242 ("Revert "build: Change remaining xenbits.xen.org link to HTTPS"") Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:21:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:21:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517887.803840 (Exim 4.92) (envelope-from ) id 1pjhXA-0002eo-PP; Tue, 04 Apr 2023 14:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517887.803840; Tue, 04 Apr 2023 14:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhXA-0002eh-MZ; Tue, 04 Apr 2023 14:21:16 +0000 Received: by outflank-mailman (input) for mailman id 517887; Tue, 04 Apr 2023 14:21:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhX9-0002eb-Nh for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:21:16 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062e.outbound.protection.outlook.com [2a01:111:f400:fe16::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3a42a1d-d2f3-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:21:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8482.eurprd04.prod.outlook.com (2603:10a6:20b:34a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 14:21:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:21:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3a42a1d-d2f3-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLumDTvjYmBBEicEU0W6WDIxirkjIhnXI5vpIqaPT7dMG7NMsPunJMrVgAveEZLRLdEJY9bPG9pSy8GJh+htYDYGiix5D9vpyuO2QHZyjP32AzpeGVX4Kd+FSZ3E6evqikndHZPJUdFZ6UDeGh18JUR/mSUEbLroOVAPImJBUHzZC+RKN/dnZkYuUGHk65tO51P5zEOjGXlg1nM9HvYeN2kPDnb0Igd4Idekbjzelj78c0+GanuGpGpRDaA2QwjnP5FGtZ1CPSLZVVVNHtHYTDqaGSqxyvOEbE2asV6j/mv3+KyMTd8y0DfCXdVJpf8vT+3R7pcwbcP1q4ScxzzQPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bHyzEfPI/zvXf0RCfyg2mKP5kKbOBRpTIxetoWwctGc=; b=YexxhU6wCTE2CvMpprh6bSX4hQRhZQH7hpTRGKGUtf2Eh+l8J9npDodirU0B05IRp8tkqsT/8pjzvBVoaHlg+taD4o03hIGAwR13COwepumDdJcWbfPcYQ9VlNH/vVCzhWzkMw6ltvO+zC8IZ4UTIndCpTRPo3r+oPlcsarkm7wX4Q6k2fKMxsTgUAmZbT/FFD3VRU9svaM6kBaQ/wE8uSffBRe7ARV2j7wdrY81W0rvFOkYLPXTGDJmV9DzuNYrRtTpqgJs+qXlHY1/sHP+JqTJMJZ6JhpFeBWYlHbutG9fNFZx30Q5jhUxGn7zBghGGPstdF+pddGixRzkp/28Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bHyzEfPI/zvXf0RCfyg2mKP5kKbOBRpTIxetoWwctGc=; b=r+KkM2vefq7hV25iKWPcPAzcoJswnkYl1WB4mRXucN31p0akV9fDOiU7K+lHJKIww0XOfR/cKJakN44tfZvKPP93zbqxixACw1Yqd3CDxwjGH7RhAGl2SjiVgiRu207P3uTI6es4+zjYzm0Xm9Izmhzfs1SaYACcahoxCFuv/SqUMb2KvBUv7uXmH1VmhX6d6H0rmeIZDgkk1HNJ/twppXCuUjkaSx0YV9lqu08GCQlBe8mnGEj7z9nv8m37+kMSn684iZCeB3QEohZAQ8qr+WGkitnyercpo+R9uvOkMNPEVjM4hnElnkngiV8wPD6tl54qsnZGX31QGan0RkUEGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5f9218c1-9ee9-c5bd-af8b-003084aa66e4@suse.com> Date: Tue, 4 Apr 2023 16:21:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <6d64dd4a-5b25-ddca-5c07-7b4c0fc48c0c@citrix.com> From: Jan Beulich In-Reply-To: <6d64dd4a-5b25-ddca-5c07-7b4c0fc48c0c@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0215.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8482:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d0a04c3-12b1-4342-bc19-08db3517d631 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WwEmXkwe8u4fuKODHyx+T/2vRD5hj7rp0oFssz0K8zbL+pYQ4EPwXFlvuXGrJMuHFaXZMYO8IBbrZ7+npQeL8fLm44sOMGzQaQlS1sa1W3/9lQoobm5AI/drtBV8eS1D+aVoXWSBmXJo/+x4rnp1oFZxwLtF9bAHQalhWnWa0NkDFT2N2jrflhgiVLS5DLjplfNwP5h8B+Dbb0XTVy00hLqTirGrD+hcsKJq+o8EsdSrHcIkUZr3XICPLL+wQhPdyyTfCbmvg0KMUvLNAN5PtpSZbj0y+a4O2TECigD47DCysjgPTiPM9nBVXU46PhvpollJ4CQX78XmIzC2Lmc4qlrl9EBA1731RL3IEmwvSG4K/pe9S+zEJE5ggO1KelrTrAdsCSHj92+DI/XpYAv/N91iNhaugAzhIW4ghq+HfcL+GIAdqgXh4jlBW/sHMXd3SJkJFdxWqyFe2XhR9b1diIIDzuDpkb6kTQzdxWVDyavjeX8H45t0NjxBfOmyDW/REKCTzXIHRdPFZSyM6GAdS97FsxGWmpFmfAWb8AyOceSQNBxc0FoNtWe13Navf6fvB7h07JWPdBBuLLFSdpwybpemAyivWRY6+wiCFVt4eAN0m8IgbA8xidoAgG4XNpobl0M1k96KZMXf35howtsLug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(366004)(136003)(396003)(346002)(451199021)(86362001)(31696002)(36756003)(2906002)(66899021)(31686004)(2616005)(53546011)(6486002)(83380400001)(186003)(26005)(6506007)(6666004)(6512007)(4326008)(316002)(8676002)(66556008)(66946007)(66476007)(478600001)(6916009)(41300700001)(38100700002)(5660300002)(54906003)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUY0V0FOSFhBUlR2K3kydXBxdUJnMW9vUjhpWGVkWjlGbkFRQ0xhUnF6c1Br?= =?utf-8?B?VTR2NERBOCtYS3I5NTh1Qzk1UjN6YzgrMTB1d1JxTHdadjBxZGtYalcwdUlx?= =?utf-8?B?WUdUZ2FnRXlGZTNGeEZzUTZuMXZITEVyUzRPZHdmdXBib2NiYTJ2TVdzNmRI?= =?utf-8?B?MFlpOEJLb3lxSWJHblBvN0VNTVM5bnA0YW56V0U0M3ZpQ2MvK1VvUmFXdE5G?= =?utf-8?B?OTBkcDJleldtc2dZMlNjeXFsVWFmNkhadVh6bnAzWWFXeHBmTEZtN25PRWlu?= =?utf-8?B?TmZvV0ZYcllZRXRsM2pIdkxRKys3SlpuK3ZhRzk5OFR6RGoyWUtuUnM0M2xn?= =?utf-8?B?WmphekthWmo2eCtJSFo5ZmpQRkZFRzRRd25jOHFYeGZ2SmZiTEE1NmVuY21j?= =?utf-8?B?MUZ1NlJreWcwNVdJQ1VlZ2hkTkN5NXZ6S0JESjhNQ0hFeVRHVHZrQVhGT3JZ?= =?utf-8?B?akg5Wi9ZckRhY2VBbnNPTjZHR1YraTFza3BWY0RRMHBpczN6VGo4VThCRXJq?= =?utf-8?B?M20rN0t0WTRnbFp4QkpRMmRxWXkwQ05xb2VhdUNLSzdiK002S1B0WTRlc3NL?= =?utf-8?B?QWxTSUl3ekZweCtreVJkdittY1k1OGxKU3FlVzJpellUSDg3a0l4SUd0K1J1?= =?utf-8?B?c3pPUmlGSGN2cG9ISzZxaXpJdnFVQVVOR2JaN2pqK0FmYS9SdnRNY1dsdmpJ?= =?utf-8?B?L3UrQUxvWTBTNTIrL2JhT29GQlJSaHkzVjZNK1ZHeWUxb29Bc3dsTHRzSVk4?= =?utf-8?B?ZDJIZlEvRHdnc1JmRThudERSR2RxV3MzTlJuWUM0ckJYcW1LSmxCcG9vejdD?= =?utf-8?B?SUh5YlFUQ0lVMDI5RGo5SlpMaW10TGFTb0dLWUUzVmFSSEFadUpqL2xLakk1?= =?utf-8?B?Yks3T251WHhqMDRYemRSK0p3YXpuNlVMRHkvRUV0OHcwRDdjRmhpUHoyZVRi?= =?utf-8?B?NjRaTWd5RUlkekxobE03alR1ak1hdGpPck5uRDlYUjZlazdNU2gxcnYySjdu?= =?utf-8?B?UmtQZTRpYWMyck5BbE9QZU5jTmFtYVgzQlExYnR1dC9lYktQbWdGUFdSSnFO?= =?utf-8?B?c2ZaZzZEdWU1bzNrQXJRaEx5QjZsYzROVTArb3FXakxxVVRzYXVwNVFkRFIr?= =?utf-8?B?dTFHeGFPOTJtZnlmeStkOUNFMTFhNlQ5YkJuSC9Lb2JQblJYOHlRWHgrUkVH?= =?utf-8?B?MGhBZFN5LzZvdE5xWVpwanAvajN5MlZBTXNlUXd1ZU4vVGJBQ1N5QXA1eWpt?= =?utf-8?B?YjVJSG5JOTlnTWF1cHQrZ3R3UitiQUZOeGxEREtPcjRlVjN6ajZXY2hyc3c1?= =?utf-8?B?RjhudDUzd1ljVHJOS3FpUzZiQ09UT0ZzdmxDQnRxSTVHRExmOEdZSWw0TW5h?= =?utf-8?B?SlBFajhBVFJqUXlqa0ViNFVSYUhQVUpVamVvbEx3WnNZSHU0Y1VqU3BrWWVi?= =?utf-8?B?MWpMY05rUnhhMlRmek5sWldiWGZEZ0pGbEtyckx0ZFRGald2OXkyMDhxVnlU?= =?utf-8?B?ZkorbTlyYmVmcG5WWkxpdS9RTi9sMFhKWk9rQnBvOWdoSFFoWlNIT0tEQW4r?= =?utf-8?B?aUpJblMxbXFNaXZKR1prdkl1RHBZY0l1K3NQbEp2S3lPRHhHcHNLM3UzK0l3?= =?utf-8?B?N0t2ZTVXWlB6Q1JTU3l6UEpyZXlRQmczZzdpSlZBQlA1cWF5YW1hSFBPNVZW?= =?utf-8?B?T3A1d1BBUGhtdUptSlJHakszak5IZGMwZ2hiZUYzdTJNRER0bHI3MHMranRT?= =?utf-8?B?QXBEZXA1QVB3aGZSVlRvTjViM2puRDdmUXpqTmUyUTZQaFF5Snc1S25WMmhj?= =?utf-8?B?cCtacEoyS09UVXk0cVJncWhFYlhDclhTaWo1Z3M3NWszTkFrMEk2N09wS3Vo?= =?utf-8?B?b0xLUHBsZWg5blZsSVJ3UGR6MFF5ZTRXKzFSd2xKSHJaaHFMWWlXV0k5THRu?= =?utf-8?B?QTkxZ1dKK0NTanZ6NlBrcnFWYk1pNTNueHdWRm9ybEk0K0RDYTFvT05pZ1pu?= =?utf-8?B?ZnhvaVFXM244aWJSek5CVTFndm5udHgzSElrSXBTdmEweURjcVVEaUtyMGV4?= =?utf-8?B?cmRQcjgzVFFGNlZiN3F0anFQN2JGM3J3Q3Zwc1ZqL1lJVFJyMkY1WjFvRG9T?= =?utf-8?Q?Tb3FQpE7V4aGGbiottI4I3LWa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0a04c3-12b1-4342-bc19-08db3517d631 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:21:09.8794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NhIa2HgwUpedre17lxjGRXTxiIRE9hAUek1D7YR5dppWAf9M/SVDjg35zaYyOMTLMa5apO1k6mgpsXOEg/D1NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8482 On 04.04.2023 15:08, Andrew Cooper wrote: > On 15/02/2023 2:54 pm, Jan Beulich wrote: >> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still >> applies to guests also when run on a 64-bit hypervisor: > > Is this really true?  Even when looking at Xen 4.2, 32bit guests are > required to pass a full 4k page, not a 32b quad. The full-page vs 32b-quad aspect is orthogonal. This VM-assist is solely about where that data structure is, not what size it is. > Which makes complete sense.  It was a hard requirement of 32bit non-PAE > guests, so it was a natural restriction to maintain into 32bit PAE guests. > > This is *only* a 32-on-64 issue, because this is the only case a 32bit > guest could in principle use an L3 placed above the 4G boundary. Not exactly. 32-bit Xen maintained a 4-entry "shadow" array below 4G that it would copy (massage) the guest entries into upon CR3 reload (just look for struct pae_l3_cache in the old sources). So above-4G page table base was possible there as well. >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ >> unsigned int partial_flags = page->partial_flags; >> l3_pgentry_t l3e = l3e_empty(); >> >> + /* >> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not >> + * understand the weird 'extended cr3' format for dealing with high-order >> + * address bits. We cut some slack for control tools (before vcpu0 is >> + * initialised). >> + */ >> + if ( is_pv_32bit_domain(d) && >> + unlikely(!VM_ASSIST(d, pae_extended_cr3)) && >> + mfn_x(l3mfn) >= 0x100000 && >> + d->vcpu[0] && d->vcpu[0]->is_initialised ) >> + { >> + gdprintk(XENLOG_WARNING, >> + "PAE pgd must be below 4GB (%#lx >= 0x100000)", >> + mfn_x(l3mfn)); >> + return -ERANGE; >> + } > > Having dug through source history, I see this is largely the form that > it used to be. > > But I'm unconvinced by the "cut control tools some slack".  I'm quite > tired of different bits of Xen taking on unnecessary complexity because > people are unwilling to fix the problem at the correct layer. But anything tools do before having created the first vCPU would not have had any means to engage the VM-assist. I.e. ... > A toolstack which has non-pae_extended_cr3 guest on its hand will know > this before any pagetables get allocated. ... this knowledge buys it nothing: It would need to move the table to below 4G irrespective of knowing that the guest can deal with bigger addresses, just to get past this check. > For this check specifically, I'd suggest prohibiting non-32p guests from > setting pae_extended_cr3 in the first place (I see no limit currently), > and then simplifying the check to just > > if ( unlikely(!VM_ASSIST(d, pae_extended_cr3)) && >      mfn_x(l3mfn) >= PFN_DOWN(GB(4)) ) Dropping the is_pv_32bit_domain() check isn't possible because we can't, all of the sudden, fail 64-bit guests' requests to enable this VM- assist (no matter that we know that it is of no use to them). Dropping the control-tools part of the condition is at least problematic as well, as per above. Albeit I'll admit I didn't check whether nowadays vCPU 0 is initialized before page tables are built. But I think it's more sensible the other way around: CR3 setting (in the hypervisor) is less involved when the page was already validated as an L3 one. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:24:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:24:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517891.803850 (Exim 4.92) (envelope-from ) id 1pjhaB-0003Dc-8Z; Tue, 04 Apr 2023 14:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517891.803850; Tue, 04 Apr 2023 14:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhaB-0003DV-5R; Tue, 04 Apr 2023 14:24:23 +0000 Received: by outflank-mailman (input) for mailman id 517891; Tue, 04 Apr 2023 14:24:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhaA-0003DN-85 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:24:22 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061c.outbound.protection.outlook.com [2a01:111:f400:fe02::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6345e347-d2f4-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:24:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8482.eurprd04.prod.outlook.com (2603:10a6:20b:34a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 14:24:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:24:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6345e347-d2f4-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B7tWl/BQS4a33kq+YilzewF/6rtfg/zxjStKj20pmYDYguIOaZ1iddPmlPKiCoBwNrpC57FxPoSmZttNxk1V4kHVK5yFZ9bDs22G6MofM7n5CoH7E+FdJmUwWDPBzIhUigDwwgspBtt63vpq4jA0OwDvLcEN54tRGp47SZYnj9TTa5jzYn9B+1j3vf2iBwEcSzvUrewMurfWf37QXNQ2ljnvT+HEtPLATDNEllPozf5QtqWlF84PfzgwLjFNt6to+8b9yBQoldsqaJqV3Mbo0zILgRr1aQQUUA50zqqgYItwgxOlEtJftJ3yjoQyHTQb5CJDZZ27i2P7FZU0ymU+qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NdmOg5mQoRO5Np3j2AZRvRHevCll0fy8DK/TFMocFsA=; b=E+SCMfCT6aC5Q0b+CVSO9gwqnWf2zSL+kNfUO6rAAn+mqt0L/N0tHbOkhcIS2Ys2x9o/bzhxNdF3Yevem2HkD/IVd5EDuUNZk43L8RneFUIIWjFNxoqtAec7vBcl4j9oWkWrXHE4ccrD+zcs8OK1s88hJbu2c0n4ySyZV3z0scqGPVI94h4WUtcUpz8Yl0FazESftpmewUnGWpT6mRZT6nETpTkApnKNqLCFE6SkHXUjCA47yVRK+VfvjXLu5svwVck6x1XB0V+0EPmOtPuYbBq3j2m41AREy8tEgUZ2Fzg0UuEkY0zrtF0o+dW4+c/Gd3gwlXwZ5g2L1Ck7I42MbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NdmOg5mQoRO5Np3j2AZRvRHevCll0fy8DK/TFMocFsA=; b=FSlfvdF28BcFoIiJoaJRYGp010tN+40H1I6Q5RNPIGR/HEh1cSrycrF7dr9QmY+tR4NITt8W8256cE+WzVMpIkcCSOzLwaEzqN0IuZy/cI9R6vQgJD5snJWmwTrAQ2L9MkoAm3S4YDpaunEb9fcRIv4J2jcgTkT/0lN3Y4Zd5DxQVDPRNBFoXbltRSvktw75x1+LNjmyJhtwn9YOQGmABGAfIxxBdN39IYMkKAyunuppapuNmM1x6zxbmsiFGkOWAOMu/vKiLMf1XJ9ArGjIt7fgOJXQMlIOmXZ6IFuKgWV1Xox4C5+l17Zn2WkyUFnFrRO287Mxj++R5IqT5CgO6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:24:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0189.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8482:EE_ X-MS-Office365-Filtering-Correlation-Id: aa2eb8a3-7588-4689-7181-08db3518467c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3JNjU+TEotU1brJS6qg8FO4NWs1oegpL7iYGZnxaWSF3ty9pij9BgnGBCNsg63dOpF8DWjhGz1HSdGk7FIDNMFlb8i2MtSCms3rEOV8dtXWuyy7wTxGNeXrBFS2qxyxD1D+7M7DIENiHJFy8+nq3p12q6hfcOI3EqSFqHsDDeAh+k+I5x7062tlX0Z5HEQd//iodivAXVG+UMBXO7IfIAnGYWVtbmlsP97IwkAg3pY5CeAogVCpMslfAeKLWV091jMUgpnXEWdaIQB38s9IlxN0S+d55uT5kUHJQUP773RM3CX9MNrTnRrOig3GtiadaRsTdqnajBiXvRER+vOgGucWfwpaDIAtCwbWRzP6+J3wJuzs1JCxBD2XFJyVhHPszciN0iallo0Uh0fdlQRP9wJjt4ToolNZ/YiL+2ZFWkiyTnZOpY/dHbhMRAROVmtyqZNTPvux7/BSmbwZ6wi5/rI6FVMue91/8j/5fgWyRNNiB8mdx+PeNnQguifjrY1itk8I/L9r+RZkmw15j5nn+AE18yrUxAPiB04O9vi9gVogn5LN93xqIrJ/wtyAADMPD52C1Hz+awARA5DFPd+BvOn1Pk06NqtFkSByqbKJf2d4uFDzRPH4N7M5m9zgppT2/YXbxmUqfYBaYSCTtAv5dHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(366004)(136003)(396003)(346002)(451199021)(86362001)(31696002)(36756003)(2906002)(66899021)(31686004)(2616005)(53546011)(6486002)(83380400001)(186003)(26005)(6506007)(6512007)(4326008)(316002)(8676002)(66556008)(66946007)(66476007)(478600001)(6916009)(41300700001)(38100700002)(5660300002)(54906003)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1I5Z2NsbC9td3c3bWk5R2ZqTi9ONkFlN2dvL1NCeEwrbEM4cU5NelZ5dVVs?= =?utf-8?B?SDBYaGoyQThGNFVLSWlrbytseDdFeEovOEdqOSs4UzRTR0tVaU8rOFNyOStK?= =?utf-8?B?a2hTMGtSblgxbTlvOW5pMlFQbnVtZmYzc1JKRklDdUZSbm9nRTN1aWNTVFFh?= =?utf-8?B?Vldkb052cXpiMXByT0lzcXhscXRoLzZZclVIR3ZiMUNaUU8rME9mc3FoaTBs?= =?utf-8?B?R2ovVXBOQjIvalVxeXhYT0t1QTEzdFdEN3MyMDByMXk0SEVWWUVMWVp1THNh?= =?utf-8?B?WkNTTkZwMkVTSUxTMmc3aUZzYlRtQnFUaURScHVGb0xRY2l1dVVXM2s3ZGlW?= =?utf-8?B?c0oxQWFJTE9SQkQ1ZFU0Yzk4NTNsR1dKU1dCZGVGbG8xbnRkZWxqN0RZcTRV?= =?utf-8?B?SEpoUm1vclFYZHR3ZWUwNlNmcjFIL21MRDJ0anJ1RkY0Wk9iMEZheTA1S3Yv?= =?utf-8?B?VjY3cFJpRXJiV0wvNTRqRWRtSktha0tOQTFoWFlMTHhqWWFwUUY5MVdjNW44?= =?utf-8?B?QmNUc3pBdGR3TDhTbVZPL3BzeHUwR3FBSm4zNEZ0OWxqQUVKNkJoamVOY0xT?= =?utf-8?B?YU55cG03QndqOXRjd2xPa3lDU0owc2srQ0dTYzRweFVzbFdWQjJNazRFQVBs?= =?utf-8?B?Znh0RG5FVW5ZZzZCNnhmOVZRb3pOR0wwTzhzRkVGRjJvbVJUT2l1dzRJaFdI?= =?utf-8?B?Zmk0eHphcE5sVnVSVUdzVEFKNkRWbG1oTEs0R0NpeFh5Q3kyeXByTUZtSURS?= =?utf-8?B?R0p0OGZlZ1REU2hGNGNLVER6NllqZkpHVnYwUC91RER5UXNNNVQxdmdDNVVP?= =?utf-8?B?bW5NazZWTEFFanY4RHZydkhxZXFiZGFLaTIvcFNOYTg1aEZuSC9pczlDczlC?= =?utf-8?B?dyt0UnVWb3dSeW1mWFNzd2cxNjBZYmlJeEV2UG1OYnpXNFRtN0hhYnlpOGtq?= =?utf-8?B?TnQ4V1MvYXJSbE5NSFFQaHg4TTF0bVJwSmRUMmNGQVVJclU5Z1BUTDZUK254?= =?utf-8?B?dGNrY3BkeXRhNVRXK1Nxa0ROSnJZRXhwK1BNTUFISGJzY1Rkc3BnTjRjdjN3?= =?utf-8?B?eUNoYnVZTWdCd2UzNGdCWEh0dXNNYjZPeDhhK3Mrc0JYaXdFL2lIaWJqZDFI?= =?utf-8?B?RXQ0WmRsT2JqcjRnZWR3WnlpVUhUbHYyRlIxcTE4YWxhaEZuTTFubGc0ZTFn?= =?utf-8?B?MFBkVXdLbDF5WFp0RmdxUTMxeHZoblU2RmVrSFR3NUdqQi9vVjRHZWQzaExS?= =?utf-8?B?TEhXYzlnNDNra3hmWTJkMFIyRkxqUjhqWlJWNUxkVytCMTQyNVE2b0ZlS0Jq?= =?utf-8?B?MXpzK1JxUERNQnhnTzhYUnpFbFBtYnRQeWFtWXRsS2k2Q1pBU0JnUVJHOEtp?= =?utf-8?B?SmVTSnAydm9RY2ZxR3M1WGlISVpGc1Rlelg5Q3JNWXYybG1Qa2xyUUpiRjls?= =?utf-8?B?YjZsdTRuKzQ5K0MrQTY5aWJaVFdMZ0xnRGxmSVNzOVF6emF6NFVrcFl3QlVL?= =?utf-8?B?L0pYTU9YbHhIaDc1L2dpYVJndEdBaDJ4R3F4SGZnTUswRWplS1RONkdIaFMy?= =?utf-8?B?Q2Z1c2pmYWd3RXVPS3czNlR5eVVhWStIV01FYWRDTmZhdU9YS0d1NkJLMXE1?= =?utf-8?B?QngycU1CR1RsQmx4NDcxUFVCSFlQOTNPZnFqd0ZORzk2VHFEdWRFTDFzeHZr?= =?utf-8?B?em15ckxmSUQ0MXRkQlhvdytZK3RiT0k0aDlHeHdTdTliQXB0aWhMR3BhNG1z?= =?utf-8?B?a2FVNHd3V25IWTJoNVNVWmtFV0hFcnlXaDhpOXZqV2dUdzRjVjNhSlg3M1B6?= =?utf-8?B?VTRWNHVESjBKZ2hZTDRKQnpMMEQ1SlpqSldWcmxiTks1NC9uYkhVUVJ5UW44?= =?utf-8?B?NEU2UXVRMyt2RWN5UUlEd2gzZVFMajIwK1FQK1M0cmMwaEwyclpCQVZLVWNU?= =?utf-8?B?bjBSdWRBazF4ZzZpOU5tR1BjWmg0NDlZOVpNTyt1VHFvYTRUSm1RbjdqZnZ3?= =?utf-8?B?ZWpMeGhaQVhIazdnUld6S2xZZ2VWMHo2SjlwdmN5RGlIVTdYcm53MFdpY2Vi?= =?utf-8?B?YTBnNk1Fb0hlSXZSSSsraWt1NDRSSkxyQW42TW5HSm11cEtlbXFreW5Objl0?= =?utf-8?Q?BWfOoCZX5fxxher62oMid9UYZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa2eb8a3-7588-4689-7181-08db3518467c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:24:18.3083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /5bmXlbQWSLGApp+34QHSj3odF9BdTECl1fqcqBoqHbQvTjA2EiNQ1JnjXP2FwhgU6gh1x5nhiywhIhujeQpBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8482 On 04.04.2023 13:41, Roger Pau Monné wrote: > On Tue, Apr 04, 2023 at 12:31:31PM +0200, Jan Beulich wrote: >> On 04.04.2023 12:12, Roger Pau Monné wrote: >>> On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: >>>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still >>>> applies to guests also when run on a 64-bit hypervisor: The "extended >>>> CR3" format has to be used there as well, to fit the address in the only >>>> 32-bit wide register there. As a result it was a mistake that the check >>>> was never enabled for that case, and was then mistakenly deleted in the >>>> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume >>>> CONFIG_PAGING_LEVELS==4"]). >>>> >>>> Similarly during Dom0 construction kernel awareness needs to be taken >>>> into account, and respective code was again mistakenly never enabled for >>>> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by >>>> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). >>>> >>>> At the same time restrict enabling of the assist for Dom0 to just the >>>> 32-bit case. Furthermore there's no need for an atomic update there. >>>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> I was uncertain whether to add a check to the CR3 guest read path, >>>> raising e.g. #GP(0) when the value read wouldn't fit but also may not >>>> be converted to "extended" format (overflow is possible there in >>>> principle because of the control tools "slack" in promote_l3_table()). >>>> >>>> In that context I was puzzled to find no check on the CR3 guest write >>>> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any >>>> of the low reserved ones) could observe anomalous behavior rather than >>>> plain failure. >>>> >>>> As to a Fixes: tag - it's pretty unclear which of the many original >>>> 32-on-64 changes to blame. I don't think the two cited commits should >>>> be referenced there, as they didn't break anything that wasn't already >>>> broken. >>>> >>>> --- a/xen/arch/x86/mm.c >>>> +++ b/xen/arch/x86/mm.c >>>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ >>>> unsigned int partial_flags = page->partial_flags; >>>> l3_pgentry_t l3e = l3e_empty(); >>>> >>>> + /* >>>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not >>>> + * understand the weird 'extended cr3' format for dealing with high-order >>>> + * address bits. We cut some slack for control tools (before vcpu0 is >>>> + * initialised). >>> >>> Don't we then need some check in the vCPU init path to assure that the >>> cr3 is < 32bits if we allow those to initially be set? >>> >>> Or will the initialization unconditionally overwrite any previous cr3 >>> value? >> >> That's not the way I understand this "cut some slack". Instead I read it >> to be meant to cover for the VM-assist bit not being set, yet. Beyond >> that it is assumed to be tool stack's responsibility to constrain >> addresses suitably. If it doesn't, it'll simply break the guest. (There >> is some guessing on my part involved here, as the original introduction >> of that code didn't further explain things.) > > If it's just the guest that's broken I would think it's fine. As long > as such mismatch doesn't cause issues in the hypervisor internal state. > > Did you see a toolstack setting such entries before pae_extended_cr3 > is set? To be honest - I didn't look. As said in the longer reply to Andrew, I think it is more logical this way (the page table root already being validated as an L3 table when vCPU 0 is inititalized, which includes setting its CR3). Hence even if right now the order was the other way around (which I doubt it is), I wouldn't want to make impossible to restore the original ordering again. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517896.803860 (Exim 4.92) (envelope-from ) id 1pjhoV-0004qy-L1; Tue, 04 Apr 2023 14:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517896.803860; Tue, 04 Apr 2023 14:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhoV-0004qr-I4; Tue, 04 Apr 2023 14:39:11 +0000 Received: by outflank-mailman (input) for mailman id 517896; Tue, 04 Apr 2023 14:39:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhoT-0004ql-R9 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:39:09 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7395241e-d2f6-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:39:07 +0200 (CEST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-xE8BrNmlOl6tBKmvK2zYKA-1; Tue, 04 Apr 2023 10:39:01 -0400 Received: by mail-ed1-f72.google.com with SMTP id u30-20020a50c05e000000b0050299de3f82so10600187edd.10 for ; Tue, 04 Apr 2023 07:39:00 -0700 (PDT) Received: from redhat.com ([2.52.129.179]) by smtp.gmail.com with ESMTPSA id qb34-20020a1709077ea200b00948f41af90dsm1279385ejc.166.2023.04.04.07.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 07:38:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7395241e-d2f6-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680619145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmO97gAtFYtTbL1S42EXHY21vUfwD059Jzy3RrPu67Q=; b=OLssQaPUVXUA7egJ0iGuWBP6qQM3xoGARTMGd3rCRS680yEngVP32ZecArHyEvgWf6zaF+ kBAYqg4xSKAxIKEXPc2u6woo9ZYLw5c55F9NBm0B9oHNYxycwxA9rQJJbp3PxWM2aFnF9K sTooll9I02HKZa8hHz30DKNXBg665go= X-MC-Unique: xE8BrNmlOl6tBKmvK2zYKA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680619139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmO97gAtFYtTbL1S42EXHY21vUfwD059Jzy3RrPu67Q=; b=xQEKz8jFgBHwGUR34x2bS03+RoDawniika7996cref7EL2jkqSGgyrFd9nwCRrzCFi xcV5Grx9G8IlTtS4xWZ8rT3W6ACvlzwP1nuMrvqQioQvD6yt3dYL5qcFzZQUrhhTk/8q JewYbLBfXrBPFwMV/qGZZSKzrQtwo260QQZu0SvK5knf0iBe7ySgd7G+9QJ2iD1gjS5V VCzV4i0DJyN1y5H2pSAR+8HoQRcveTKtSZo3uQdAKwH/mizm2assmehx9ftj26yJFsO2 ezWpbPxxcVMW+u7PWKrL1uybF7z6FXheN1hXuzolIPT8buJt7WcQzE5KPxmSB5KUZkRN NanQ== X-Gm-Message-State: AAQBX9fV7Zss8zShF+5tcyTPjr27O7G3T1WrPzuACVVKveEJimPhABm6 5jpCJFXSJ0O6sN3zW9z0NqorNqfT5C//iMCGNnxE7KvegB5mnDmgcZpZiqyY7L396dirD0+b313 Ii42yyVNmu1+z8ggJ384hpGzKwSc= X-Received: by 2002:aa7:cfd5:0:b0:4fa:c17d:8fdd with SMTP id r21-20020aa7cfd5000000b004fac17d8fddmr2323120edy.34.1680619139637; Tue, 04 Apr 2023 07:38:59 -0700 (PDT) X-Google-Smtp-Source: AKy350bi2S3wGdfV0YoNjlWz9akfgA+degJejYBD5zzJwJg5OHp4hxP/MX7u3WDswchOrfTPlv4XoQ== X-Received: by 2002:aa7:cfd5:0:b0:4fa:c17d:8fdd with SMTP id r21-20020aa7cfd5000000b004fac17d8fddmr2323108edy.34.1680619139386; Tue, 04 Apr 2023 07:38:59 -0700 (PDT) Date: Tue, 4 Apr 2023 10:38:53 -0400 From: "Michael S. Tsirkin" To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paolo Bonzini , Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Anthony Perard Subject: Re: [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event Message-ID: <20230404103838-mutt-send-email-mst@kernel.org> References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-2-stefanha@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230403183004.347205-2-stefanha@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 03, 2023 at 02:29:52PM -0400, Stefan Hajnoczi wrote: > Only report a transport reset event to the guest after the SCSIDevice > has been unrealized by qdev_simple_device_unplug_cb(). > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field > to false so that scsi_device_find/get() no longer see it. > > scsi_target_emulate_report_luns() also needs to be updated to filter out > SCSIDevices that are unrealized. > > These changes ensure that the guest driver does not see the SCSIDevice > that's being unplugged if it responds very quickly to the transport > reset event. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Feel free to merge. > --- > hw/scsi/scsi-bus.c | 3 ++- > hw/scsi/virtio-scsi.c | 18 +++++++++--------- > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index c97176110c..f9bd064833 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c > @@ -487,7 +487,8 @@ static bool scsi_target_emulate_report_luns(SCSITargetReq *r) > DeviceState *qdev = kid->child; > SCSIDevice *dev = SCSI_DEVICE(qdev); > > - if (dev->channel == channel && dev->id == id && dev->lun != 0) { > + if (dev->channel == channel && dev->id == id && dev->lun != 0 && > + qatomic_load_acquire(&dev->qdev.realized)) { > store_lun(tmp, dev->lun); > g_byte_array_append(buf, tmp, 8); > len += 8; > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index 612c525d9d..000961446c 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -1063,15 +1063,6 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, > SCSIDevice *sd = SCSI_DEVICE(dev); > AioContext *ctx = s->ctx ?: qemu_get_aio_context(); > > - if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > - virtio_scsi_acquire(s); > - virtio_scsi_push_event(s, sd, > - VIRTIO_SCSI_T_TRANSPORT_RESET, > - VIRTIO_SCSI_EVT_RESET_REMOVED); > - scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); > - virtio_scsi_release(s); > - } > - > aio_disable_external(ctx); > qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); > aio_enable_external(ctx); > @@ -1082,6 +1073,15 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, > blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NULL); > virtio_scsi_release(s); > } > + > + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > + virtio_scsi_acquire(s); > + virtio_scsi_push_event(s, sd, > + VIRTIO_SCSI_T_TRANSPORT_RESET, > + VIRTIO_SCSI_EVT_RESET_REMOVED); > + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); > + virtio_scsi_release(s); > + } > } > > static struct SCSIBusInfo virtio_scsi_scsi_info = { > -- > 2.39.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:48:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517900.803870 (Exim 4.92) (envelope-from ) id 1pjhxK-0006Jp-GV; Tue, 04 Apr 2023 14:48:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517900.803870; Tue, 04 Apr 2023 14:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhxK-0006Ji-Dj; Tue, 04 Apr 2023 14:48:18 +0000 Received: by outflank-mailman (input) for mailman id 517900; Tue, 04 Apr 2023 14:48:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhxJ-0006Jc-1N for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:48:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7e1a::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb17d4b9-d2f7-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 16:48:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8059.eurprd04.prod.outlook.com (2603:10a6:10:1e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:48:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:48:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb17d4b9-d2f7-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEx35mZh57eCns829b3WkMAk1YGOrap6lKU3x/Nb7alj3JPFiBKghdZv6v7Duj5arsEYtDlmDWjV+r1KE5HjeSa1uxseOu7Cf0w2LML+8vBXRw0INRCMx3DazKd5b37nky1SH+l5o/9ozf+L6PLOhloRnnOEGpcybHjxU1odamDCw67CKbJ4mrN2KY6mVY9vl9AwlNRjz42/j0USv4fXAArBWgWxzy6DDPUeZ/9mK45AI6c/3l7ZtTnmwqeucJmujl8JUMh1AUKx+wE8Mn2tqAYQe3OFSLH/ZsxxsVF94qcikOfdf5TXJVasvMhElmT0rWVSQsAS5COUTdOG0SyxHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3CGLe7T2yLSk6DDDg8vDLU1RI5JXzolsx2xLHPjcZd4=; b=hYa0A9uQNpT4C95PaHjmeOnQG+9ZAxMDLoprR/SMJA8cqg/W+WUf+XFGZ8OsVjfSI/PweMBBbayB2Jsg6dR52+3fdIiRGsUXl8q512ja7gnsW5lZceUkwWMMKDmyKqTsVdSycNFVl7cl0Ghc9NgrbIPg/KMriyPgElzKr/qqPFNtanP3qO/g8dm7Epz8xkjRQ2H/w+Smm+MfUcHbQUoW04jJziKLIWhF/eg31Ndx6TU8uhSPuJbWmfJocIYmhioYlSbAi6ZGJp9qmOG6qOsjmPjLUld0xeBY5b9bX/5rWqssOG0gHVzjyOxOZqyw7ZUHZnKUncb1Gip+u2tot6AYkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3CGLe7T2yLSk6DDDg8vDLU1RI5JXzolsx2xLHPjcZd4=; b=WkXVOlx5SAhYHTg1/0ib7ySM69twvBxCsj1D5ghDNLd94Z2GjfH+jHDKJsLq1GW7NIxjxBbZBsTSa5BffSAB8CSZY5IAB4BtSfsuzo8z3dW0kuZ30dI2WWFr19TTUu5LO25s0jsAkd3MPLfesunQZFqeQL8ubUYCvI1YKXAsdGwaqQNAhurNpedeiLL1hYIvEiOrTndyjXA7NCm39Wcu99DDPj7WG5mcQiZf7ML2lSQviJg67Ea3yqSi3HpxkTwC64Ho9kHkxafm363wtbbJo7ik7NMYBNPPlZKsvahJHUH28iEh/pCTrNAHBLLjpQAqD2b2tPn3U4oomUmXVT+Uiw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:48:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/9] x86emul: misc additions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8059:EE_ X-MS-Office365-Filtering-Correlation-Id: a5821fa2-48e4-42cb-331e-08db351b9e69 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Va39pFWYcD06j+tLXhp+5REl9euqrD1q+s1t97QN5EWXQNfbvZNqhEovTDI4J66PUobSDGkgG+8WmjbtHayJyGJOyGLbDLvpmwbm4lhotSKGtWRrv+isBw6PnwLKJyrJTC8H8QR4/uqVhrQJviH/elDG6VYdxrFMxAWHQ40zS3068PDDxgBVxdsJtyCNwdbhkQ8SYyG2U7QfnwjDKuCBZFunnoand5QngDWN2Aoli10LL4t4P85IyNBvsutu7dlq4w0rz2C6swA9bMtOzvdXcYT9K6khNRqKvMw4NqY0ErOoR4uNtuRx2uAUnJla8ll1Rl+SLjvqZxbRbzORQeCm4R/eDwLmW8JFHp7Gn8Bd1Dru4HYSme7uMef2uldC1BNlT9/kLERTdqW/H7+GHCoWv8JDVydpAdHQ+GPok3GQK4Z3sHUU1x8qzyLT2AV9qIMwIygviLoK4fruA/l+5Z5ooQas5IjbwQXCdkM3UTnwGBKGa2J3NlwtngbqTE2tFjkOHL5m+jAKKtX73y+gWXNz4S7ofAaZHd2yVKJvRqb5Te5E0R51MHnCXxG/LSmswf2+qn4mAW6Mo1YWNtxqaXzoCw619dW2IXt67TV5sBsFudAO6Mc4izA7Kst5T+InzkPKwDMj3S2D7F33vF7WUCV6mw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199021)(478600001)(316002)(54906003)(5660300002)(8936002)(36756003)(86362001)(31696002)(4326008)(4744005)(2906002)(8676002)(6916009)(66556008)(66476007)(38100700002)(41300700001)(6512007)(6506007)(26005)(6666004)(66946007)(6486002)(83380400001)(2616005)(31686004)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d25HUGVKRm9ES2t0aThEM0hBWVc1WkMzcWtxMTNtQ2wyRk1DbDdUSXZHbXZK?= =?utf-8?B?TnlNQXhZUFhsSXVBWjEyQTJMTm01VFZMZTI0RzJkN1hacjdhUEpLby81Q21q?= =?utf-8?B?QWhSOHVuc1VjL0hYMnp2cWxjZ3NERGlUOXkxRHJZZ2pNSWNvY1A2VmtkNXkx?= =?utf-8?B?WTZrckdiT0hxU1NyejEwUmQvbXVsVnhldUQ0T0FoN2FrNUtaUk5NZ0lUcVBT?= =?utf-8?B?S294NkZKUElqSml2UEpTY0R3ZVR5djlCZ1FHRXBIY3d0WTNFSzduQzhrbC9W?= =?utf-8?B?aTlTaExXQzB1a2Z2WjcwY3BZZVJsOUNOTWZkL2ZRdTByQ0hlRy8rMHA0cTBu?= =?utf-8?B?aDVySFN0VEtrY1NmZG5qOHNneXNqWCtHeTJ3bGFNUDZ4ZTNMeWZuUTd6WEVt?= =?utf-8?B?YmJMRTd2SkpqZzljSlBLZFJvb1pyRW92VHlvL0ZDYkx6Z2FzWmNUSVd4cVFM?= =?utf-8?B?ektmbFg0RG5oaDZrazdBeXIwNWpkb0Z3OXE1MGRibno4Nmdlb2p3RHhmN29t?= =?utf-8?B?UjhNa0RDSk9zQllpNnpyWjRHcEZlVk5xSGw5WEdWSHA3dEZyenY1OUlIU281?= =?utf-8?B?bkp5UXhOSFl2TFpOSS84UjI3ZlViOHNMMWYyV1JzUi9zOWY3TlhMTjIvTXRV?= =?utf-8?B?blFkK2FxdzZyLzRod1BPT0wwMEppVlZrbmVoV2JBaE5FNCswY0pkbU8zczYy?= =?utf-8?B?QnNiLzYzeEI0dzlHeTA1Tk5meFQ1UE9xNW04MmpnczF4c1p0SCt0TVd5VEdp?= =?utf-8?B?ZkFVSXRXOU5iVXdUejJMV3RVZ3ZZRW1CSXdJNC9MNXBuKzNXYlBYVktBUVp2?= =?utf-8?B?MlRxb0N3K0Iwem1QSlpDT2JWdzJJcTF0bDdIZ0V0YVMxSTR5MEJ5RmNEZHV4?= =?utf-8?B?MDBEa1dhTTBIVGxDaUdSVmZKYUd4WFdZdzdBbEFuV0Noa2FNR2lXLy9rZ01P?= =?utf-8?B?MVhqZ2pMcEpVU1VPTjdBdkFTNWNyMkZKS0ZJeHowUnJ4cWpxUldETXI3K204?= =?utf-8?B?M3lvQ05uVHRQakxZR3Nnc2hUUUViV0tJL0VibzRIUVVtZGpmSkliVG5RSVJQ?= =?utf-8?B?akFRYlBSNklJZVF4czVGQWFnMTZzOTFDa3I0TmVDT0pCUlNOdlRmZGtpTTFY?= =?utf-8?B?T2VFVmkrMHdlSE5SRkdmTW5oNWpTejJxRHFaMFNzQlNEa3JKOURyQklLdDBh?= =?utf-8?B?VU0rVG14NXorWlp4SUt0UWQ0RC9BUnRlWUJsYXpzYlVuM3h6alRWd0s0SFRa?= =?utf-8?B?ZVd1QXY3WE5xcUN3MWlDU21rMUx5TDByVlRuYi9ONWM5ckQ4R05td2dEZUk3?= =?utf-8?B?MjNGM2greU1nWTRhSmlWZnpTalozSFM3bVhleHFEdVgzZXJjNmR5R2F1eUFi?= =?utf-8?B?NGN6VVNNZTU5OEpvTlFRNHozRnU5a3RkVnFmQnM2WDVWQ3Q3YzJ0Z2NGM0RJ?= =?utf-8?B?NTd6cVNXYi9BV2RMcHE1V0xjOFZtY0E1Q1BNMkltd1VlcXVBNWxyZm1qWkov?= =?utf-8?B?eUJMNlpPZ2daVnJwUlBJc09zdzN0NGtvR2NrY2RGTlA0M0lXZHVHK2NhVmly?= =?utf-8?B?dEFWYnRmQmo5VHRvK1FidmtXQ0pNY2RCR1E3cGZBRlkrM244UjZDdm5aOHJ6?= =?utf-8?B?RXVDV3ZXSm40U0VuYjF6RVowVE1lb3BGbCt1THZLK1o3Uk5qMHpvWkNSZFkw?= =?utf-8?B?NmdET0ZsNm1uaUt2V0w0M0E3dmJCNWl5KzNLb21tU1pVWmpkRS9iU0NCTlkz?= =?utf-8?B?czFCemQ4TVkzODJmWjA0SHcrazBNNnIyaS9Jem80bmliQkFoL0pDS2ZOODE1?= =?utf-8?B?NWhDUlJVQ2wzRUZTOExPUi8wbDdST0hRYWtsNlRRQWUrdWswS3oyYkY0eXRF?= =?utf-8?B?MUFDcWJKMUxXamJCU2xGclhzcERsVllBZkNlbWRvcVVaSGZ2OVVYTXVCU0dS?= =?utf-8?B?c1ZpaTNZdnJDUFZ2bndLN0s2dTJIdTZxM1FhV1UyVmxuQll0elpYeGlCRE1P?= =?utf-8?B?a3N1SWNnT1IxdVRhb2ZKR3V2QzduT3JlbW5IMHFPeFdhdUlWVDd2MWllTnRM?= =?utf-8?B?ZmplRDVqWmNZVjcvRXcyajdlbmpVaFFLc1RZUGlXMEtWZ21IaWRRanFLeHFR?= =?utf-8?Q?UDfQ36fK8VFBhattmX7nnd/7B?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5821fa2-48e4-42cb-331e-08db351b9e69 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:48:14.2488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U4YN9jr9R2pFriNrbrm1T5wfy9xng6XtyAE3yaFONvkNVtBxHjScuVwCroJVxbNklaeeJ+xFMUkXeD1TMh117w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8059 This series adds support for a number of more or less recently announced ISA extensions. Plus a little bit of (more or less related) cleanup. The series interacts mildly (and only contextually) with the AVX512-FP16 one. Note that patch 1 was previously posted standalone; the posting here is unchanged, so isn't called "v2". Note further that while the last patch is kind of incomplete (it doesn't enable the feature for guest use), it could still be applied ahead of further VMX-specific work that's needed there (and that's dependent upon documentation becoming more complete). Apart from contextual interaction the patches should be largely independent of one another; only 5 strictly depends on 4. 1: support LKGS 2: support WRMSRNS 3: drop regs field from emulator state structure 4: support CMPccXADD 5: re-use new stub_exn field in state structure 6: support AVX-IFMA insns 7: support AVX-VNNI-INT8 8: support AVX-NE-CONVERT insns 9: support {RD,WR}MSRLIST Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:49:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:49:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517904.803880 (Exim 4.92) (envelope-from ) id 1pjhyB-0006ps-ST; Tue, 04 Apr 2023 14:49:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517904.803880; Tue, 04 Apr 2023 14:49:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhyB-0006pl-Oj; Tue, 04 Apr 2023 14:49:11 +0000 Received: by outflank-mailman (input) for mailman id 517904; Tue, 04 Apr 2023 14:49:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhy9-0006pZ-Pj for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:49:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7e1a::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d99ae6e5-d2f7-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:49:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8059.eurprd04.prod.outlook.com (2603:10a6:10:1e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:49:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:49:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d99ae6e5-d2f7-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhNa3gQVqEqVWOn1BQiWAUkMLvttOvoMTYXO6hoFgS0pyVeMkKly/otz5kRIMRz0WZtPgsKfRWB1KV1eJD4aGGzk4g8jHwXW4gBdhawPpYOC3nHZnfGvBuT2dnzkw60kJEz2EAkKsWFUqQicHtfT4zGOxwtlkwgYzz0z+6nCNztdv2wqFNOidDUxQ23Y552pThpgz0crjXFAtgzdjSvgxgrOnRuZStgOEZqNWXZfE6/1K8NHMg9ZiZn/0xXvcaSO/r2pjq8BZgmoM4FiRcI0i5j7sDEPQbYVh3BWdeF2ae+v3L68XHf1o5owZQO2CPjYwKgABnjPDmiuJ41TW08vvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1gpGtiRKwEgaAgJAWR+acZezpCQEWfuFPhZDqqfukzE=; b=lZtQDbpvs4EEYH9MHKzoQHu/gBzR7BFyLKl5iU7wsxqx19j+/KNIJNHJ0W9Q1ziByIefiYPK5Ze70vGK9Uo+GkG5/fNcYU6UO5OpEAI5WSidJpR8nKBhk6yvaopf6UZeG8CtsyGEXk6qWiMD828tIBijfUQ76oViF4+WoIgUMEPAeuYwxuikxXEZVJtWCZBPsBJMVj9pVSu1H77n+w5Rb8CuNf5DeByMDTMR6ZlpZ1nsBeIEh0pOZIijHHezxGCl4Nvc9qjnaQKn08oV10OBFBNkoz06BO+ZKJQOR8mbVo8kEbxra0xPT+bu0DgaQ+Q+tkdgx20ZTdzS0RcDiqcf7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1gpGtiRKwEgaAgJAWR+acZezpCQEWfuFPhZDqqfukzE=; b=cPOsI1bQRTbggibijwxFPtr05jC7HHOl5FaH6GijrFXx5PlPBjkX7Fxk/Tc6dKYf2v2U+kxi7hQwDzse3SjCWH3OmpDPscm/H0TA5FRLRMmnERC4oubIgwCRah2DrLLso2TDTNP/RceqTXjOzY6L5SZw3ELqErtNdmOeKtL6SfIa7cXrpdxbTRxv8v3GJCqR3USJCKjzQCV5kltJ7V7WyN09QYUUsTjx8xBusaoBaUgVHXvUEld1kMYoWOacnsd6Mx2O3stSvPlfOaW3kFap+rohcDTeuu4GmhXavGeHNGXoOYhV7IjevwZeHWDR/xGp/vy432vOjHln82fOo5dVSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1eb21ece-9d33-d8e1-1c2b-c682dbb1cda1@suse.com> Date: Tue, 4 Apr 2023 16:49:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 1/9] x86emul: support LKGS Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8059:EE_ X-MS-Office365-Filtering-Correlation-Id: 809a8e30-a5b7-4f0b-85d9-08db351bbce6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: //iGQc3JQ14jAqruPERNrELZL4XVtliVGJWs2Hq1qm1r5FkyLDs0yLSFuYeig3PdGCoSH2saEFo2xArk4TsmqxiS2na7i9FAbFVV7PjYA+OaVzgT6XJjpQZjBNr61dxn6bgYTAjf4vRf8CPaE1WgRknYd8/4rmhuTMA+59+qFY/GemoVQAWlITIwcQh2FyZ69JbF9mr5x1EewfbaQWpsG/q4s/+5hs1MqTAadQLVrEIC9Ep3thReE38wzQAOZOB1OQN0Nlcgf9wJak/TBoLSbs7X0d2INLt/OmVRyRtz9hoMKqHS1zpvCWBoR6Ou/CUvCDSNjzqlBwpa3NPfchOlapq+GwlBR6bQRhkNBFGG372BIGBQbqQb7K7r8EHnuIXwrfwV2rK5Exi6G1xA1Ji8oFlcPJZBjhd5OzuOZU7XntNsTxz2BaMG7MWs7+3KGMBTPDt9FxbwWKiSKhWYX/JTB3tg2PvEjjJteFw6lqMAmWHnX7RK2Vh2YjbYQNXQiZ2cobC3D2mgxssYOIlZRCXE2F4mWVxwZmOgl7yOpmazv9wDMgQoybBYJY3IriMnefwAzE6nbakIjOTvAfNxmIU5MXMh1w+pP6tKgA/gq4/Lnu8MCZeemS3HGi9Fg86rViUhGEM9Fa8/Qacb1EBODdBotA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199021)(478600001)(316002)(54906003)(5660300002)(8936002)(36756003)(86362001)(31696002)(4326008)(2906002)(8676002)(6916009)(66556008)(66476007)(38100700002)(41300700001)(6512007)(6506007)(26005)(66946007)(6486002)(83380400001)(2616005)(31686004)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QldCMmZ2aC9mWFdTZXJvSHNoWGFvR29qdFA0UnNTSy9BZzBUS3R5b2pvdTVr?= =?utf-8?B?WEsrOUd6WjBuZnpLb1UrcElJNW5vMHRFMzA0dERwOWlxR0NJQk1kVUplUEhX?= =?utf-8?B?UkRIbUtRUC9hSzFGV1gzZVFka29BQUNrUTB1eVpiZ1JGaGhxVFYrbHRsU2ds?= =?utf-8?B?bXVXSElwdUhsby9tazVFdEd3RFozVW13OTh4bGpGUngyb2NjdExiK040YXdW?= =?utf-8?B?TGUrOXhvcjFUaUZpSDZ1cDJjZ2xsRTlQY0lLaTRxeXdrRnFxcTMrVXRSdG9Y?= =?utf-8?B?WkpxdHBCb1lHVTJxNGt5dWU4L1FKMWg4VWlhZnYrUXdjM3FQM0V5cis2d2hi?= =?utf-8?B?M1A2U1prdXlQYXNEMkREOTBOMnF6cTNWemRZRnFoWEhMaDJlS3lORXA5Nm54?= =?utf-8?B?VlZpby9zcHlqNk5aV2dVeGdhazBZQ2o5UG5JcUtBcGxIM0hYSURQUWhDVUJz?= =?utf-8?B?WVdBcnRBMWRDd3Q4Y0lwbHdqTXhTSVFtclpPZVk0djU3RGNCcytIQ3l3SE1x?= =?utf-8?B?WE9GbXVKemlpRktlRjlKWHNqVzhFOWpqU1N5OGswRXR3NDJNQmVaRlN3TWFE?= =?utf-8?B?NklwV0V6Z01JdEFBK2x6VUNaV2Qwcm5lV1M4aG9VRzJ5cU1BaTkyeVMxU3lx?= =?utf-8?B?SFFtU252Rmx4c2lBenhFaFg1ME40RTVFeVk4enZ2WFk1YVcwSzViWkRUWmRR?= =?utf-8?B?Zi9waU1aNEJOUXRzSlZWYVRNVEgrVXphWWl1U0xQZyt5ZDV5T2l3RXh5ZjQz?= =?utf-8?B?dUI5dGdsKyt5aXd4M1ZQNlVEQ3lrMXp4K3FPRVZZcEp6YzU1MWF6Z3daZDlq?= =?utf-8?B?U2tJZTVTSTIxb1ZHMTV4ejdjQUlvcm5QWXpSTm5sUmhUQmwrNzAvTzdiU0pZ?= =?utf-8?B?UWVFZU5CMWhNWE9zd0dWNmZERWtJZmFHV1ZhT0U3OE82SHlLZjArSHRzQm1R?= =?utf-8?B?cE9FMkwxbXZzWWpROC8rY3JwcWtqeXFpZmFQb0hmZzhYR0NIeEphVFRiK3RB?= =?utf-8?B?Y2c4bWd1VFA1Uk8rYlA3RDRzQXVlWS9Fditvdi9lTThWdmNweHNvdEVmTWJ5?= =?utf-8?B?OVFXNHZrNVU5Q3B3R0RBSkkwTGUrU29pUFRaeXhiQWlYUkV6dEpndlhGWGlr?= =?utf-8?B?V09kVDBiQTFWcTcyeDZvL3Z4ZnhvYkdmZlMzc3NoYlloTHZHM1V3a29MV2du?= =?utf-8?B?cnk2VExLNk95NDd0bmQ3WGNtdjkxb0tJQWlWczhablFsdFB1V2FGaTVuVzEz?= =?utf-8?B?cXpwci9scFBydVV4ZG9xK3hQd01Md2t0anBoTTBFYzZxa0hmbzlLUEJhQWJv?= =?utf-8?B?dG9IUU5keFBhQjcremRLeGlxVngxOG1SR0dnUVFLVmg4c3FLWHNJa2tIZldE?= =?utf-8?B?V0ViSUJjVlJDRERtaU5lMlFMYVJhN1pCUjVmdm9SbEtQNlA0TFhHWXc4eVF0?= =?utf-8?B?RXE5OUUyRUtKVFJ3Nm45Vks3N2pZcXdpTEVnNXNNKy9NYmh5dXZuSnNVTVFE?= =?utf-8?B?Y2pRUkFpaHU4WGQwMnRtL2VLY1ZpQnUyak91RTdsbit2T0wyL0oyZlN2TzhP?= =?utf-8?B?c2JXd3BvS1VKWU40ZUpkckIrTVNmME5zWTNmM01YdXBrRGg1QTdNM0plL21O?= =?utf-8?B?MHFSeWRHWUFmNXY0QUh6UnkvQ1BGYjdOd0lERDhGbndsMkRtVy9BaCtDa3Qz?= =?utf-8?B?OVN4QWI4ekwybmFFVWJEV0pvWDNJeFJNZjRhWCthK3dteHRJakdZT3d2aFkz?= =?utf-8?B?akdGUCtOWHBJV0tBV1lCVHdpZnZjeWxSTEtxN1E4L2lKZFpDaDVCa29xWXRJ?= =?utf-8?B?a2lNN3BJRUMxY2ZYRjNTY2ZVaXhlaEc3b29HR1NzUmw1UVZ1WWZKZThIMHZh?= =?utf-8?B?NEVLay9UYTFqaVNVbTJRd3FJTTVyMmhCbytQTWh1WjkvVHQ0YUhzc1c5cTVI?= =?utf-8?B?MDZDbW9RSUlENWJ1NXpzN3Q4eW5rVjh5Rk9OaldQWW0yTlJtREIzbjM2Z0JO?= =?utf-8?B?VTgyV2VoWWJSMWdsZ05Vd0hyeUExOFFYZVZXdC9TT3pzWmdwbENMb2JKY2p3?= =?utf-8?B?TURJbFV0ZXo1ZXg4U3NaNWQ2VHB4a2ZCVFc0NDd2QlJCYlY5c1RKa0R5R2Jr?= =?utf-8?Q?8zkyPIclFEil40sKwAi4ZwRev?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 809a8e30-a5b7-4f0b-85d9-08db351bbce6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:49:05.5014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lL3awT8mHOCociecza1dYY2PnNYlnbDr5CCMg801VVTaV5tDIljqgqL7uDlmbEhOJ6W2fwppeND0zrq5HuuldQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8059 Provide support for this insn, which is a prereq to FRED. CPUID-wise introduce both its and FRED's bit at this occasion, thus allowing to also express the dependency right away. While adding a testcase, also add a SWAPGS one. In order to not affect the behavior of pre-existing tests, install write_{segment,msr} hooks only transiently. Signed-off-by: Jan Beulich --- Instead of ->read_segment() we could of course also use ->read_msr() to fetch the original GS base. I don't think I can see a clear advantage of either approach; the way it's done it matches how we handle SWAPGS. For PV save_segments() would need adjustment, but the insn being restricted to ring 0 means PV guests can't use it anyway (unless we wanted to emulate it as another privileged insn). --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -235,6 +235,8 @@ int libxl_cpuid_parse_config(libxl_cpuid {"fzrm", 0x00000007, 1, CPUID_REG_EAX, 10, 1}, {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, + {"fred", 0x00000007, 1, CPUID_REG_EAX, 17, 1}, + {"lkgs", 0x00000007, 1, CPUID_REG_EAX, 18, 1}, {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, {"cet-sss", 0x00000007, 1, CPUID_REG_EDX, 18, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -190,7 +190,8 @@ static const char *const str_7a1[32] = [10] = "fzrm", [11] = "fsrs", [12] = "fsrcs", - /* 18 */ [19] = "wrmsrns", + /* 16 */ [17] = "fred", + [18] = "lkgs", [19] = "wrmsrns", }; static const char *const str_e21a[32] = --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -326,6 +326,7 @@ static const struct { { { 0x00, 0x18 }, { 2, 2 }, T, R }, /* ltr */ { { 0x00, 0x20 }, { 2, 2 }, T, R }, /* verr */ { { 0x00, 0x28 }, { 2, 2 }, T, R }, /* verw */ + { { 0x00, 0x30 }, { 0, 2 }, T, R, pfx_f2 }, /* lkgs */ { { 0x01, 0x00 }, { 2, 2 }, F, W }, /* sgdt */ { { 0x01, 0x08 }, { 2, 2 }, F, W }, /* sidt */ { { 0x01, 0x10 }, { 2, 2 }, F, R }, /* lgdt */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -666,6 +666,10 @@ static int blk( return x86_emul_blk((void *)offset, p_data, bytes, eflags, state, ctxt); } +#ifdef __x86_64__ +static unsigned long gs_base, gs_base_shadow; +#endif + static int read_segment( enum x86_segment seg, struct segment_register *reg, @@ -675,8 +679,30 @@ static int read_segment( return X86EMUL_UNHANDLEABLE; memset(reg, 0, sizeof(*reg)); reg->p = 1; + +#ifdef __x86_64__ + if ( seg == x86_seg_gs ) + reg->base = gs_base; +#endif + + return X86EMUL_OKAY; +} + +#ifdef __x86_64__ +static int write_segment( + enum x86_segment seg, + const struct segment_register *reg, + struct x86_emulate_ctxt *ctxt) +{ + if ( !is_x86_user_segment(seg) ) + return X86EMUL_UNHANDLEABLE; + + if ( seg == x86_seg_gs ) + gs_base = reg->base; + return X86EMUL_OKAY; } +#endif static int read_msr( unsigned int reg, @@ -689,6 +715,20 @@ static int read_msr( *val = ctxt->addr_size > 32 ? 0x500 /* LME|LMA */ : 0; return X86EMUL_OKAY; +#ifdef __x86_64__ + case 0xc0000101: /* GS_BASE */ + if ( ctxt->addr_size < 64 ) + break; + *val = gs_base; + return X86EMUL_OKAY; + + case 0xc0000102: /* SHADOW_GS_BASE */ + if ( ctxt->addr_size < 64 ) + break; + *val = gs_base_shadow; + return X86EMUL_OKAY; +#endif + case 0xc0000103: /* TSC_AUX */ #define TSC_AUX_VALUE 0xCACACACA *val = TSC_AUX_VALUE; @@ -698,6 +738,31 @@ static int read_msr( return X86EMUL_UNHANDLEABLE; } +#ifdef __x86_64__ +static int write_msr( + unsigned int reg, + uint64_t val, + struct x86_emulate_ctxt *ctxt) +{ + switch ( reg ) + { + case 0xc0000101: /* GS_BASE */ + if ( ctxt->addr_size < 64 || !is_canonical_address(val) ) + break; + gs_base = val; + return X86EMUL_OKAY; + + case 0xc0000102: /* SHADOW_GS_BASE */ + if ( ctxt->addr_size < 64 || !is_canonical_address(val) ) + break; + gs_base_shadow = val; + return X86EMUL_OKAY; + } + + return X86EMUL_UNHANDLEABLE; +} +#endif + #define INVPCID_ADDR 0x12345678 #define INVPCID_PCID 0x123 @@ -1331,6 +1396,41 @@ int main(int argc, char **argv) printf("%u bytes read - ", bytes_read); goto fail; } + printf("okay\n"); + + emulops.write_segment = write_segment; + emulops.write_msr = write_msr; + + printf("%-40s", "Testing swapgs..."); + instr[0] = 0x0f; instr[1] = 0x01; instr[2] = 0xf8; + regs.eip = (unsigned long)&instr[0]; + gs_base = 0xffffeeeecccc8888UL; + gs_base_shadow = 0x0000111122224444UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[3]) || + (gs_base != 0x0000111122224444UL) || + (gs_base_shadow != 0xffffeeeecccc8888UL) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing lkgs 2(%rdx)..."); + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x00; instr[3] = 0x72; instr[4] = 0x02; + regs.eip = (unsigned long)&instr[0]; + regs.edx = (unsigned long)res; + res[0] = 0x00004444; + res[1] = 0x8888cccc; + i = cp.extd.nscb; cp.extd.nscb = true; /* for AMD */ + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[5]) || + (gs_base != 0x0000111122224444UL) || + gs_base_shadow ) + goto fail; + + cp.extd.nscb = i; + emulops.write_segment = NULL; + emulops.write_msr = NULL; #endif printf("okay\n"); --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -86,6 +86,7 @@ bool emul_test_init(void) cp.feat.adx = true; cp.feat.avx512pf = cp.feat.avx512f; cp.feat.rdpid = true; + cp.feat.lkgs = true; cp.extd.clzero = true; if ( cpu_has_xsave ) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -744,8 +744,12 @@ decode_twobyte(struct x86_emulate_state case 0: s->desc |= DstMem | SrcImplicit | Mov; break; + case 6: + if ( !(s->modrm_reg & 1) && mode_64bit() ) + { case 2: case 4: - s->desc |= SrcMem16; + s->desc |= SrcMem16; + } break; } break; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -594,6 +594,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) +#define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2886,8 +2886,31 @@ x86_emulate( break; } break; - default: - generate_exception_if(true, EXC_UD); + case 6: /* lkgs */ + generate_exception_if((modrm_reg & 1) || vex.pfx != vex_f2, EXC_UD); + generate_exception_if(!mode_64bit() || !mode_ring0(), EXC_UD); + vcpu_must_have(lkgs); + fail_if(!ops->read_segment || !ops->read_msr || + !ops->write_segment || !ops->write_msr); + if ( (rc = ops->read_msr(MSR_SHADOW_GS_BASE, &msr_val, + ctxt)) != X86EMUL_OKAY || + (rc = ops->read_segment(x86_seg_gs, &sreg, + ctxt)) != X86EMUL_OKAY ) + goto done; + dst.orig_val = sreg.base; + if ( (rc = protmode_load_seg(x86_seg_gs, src.val, false, &sreg, + ctxt, ops)) != X86EMUL_OKAY || + (rc = ops->write_msr(MSR_SHADOW_GS_BASE, sreg.base, + ctxt)) != X86EMUL_OKAY ) + goto done; + sreg.base = dst.orig_val; + if ( (rc = ops->write_segment(x86_seg_gs, &sreg, + ctxt)) != X86EMUL_OKAY ) + { + /* Best effort unwind (i.e. no error checking). */ + ops->write_msr(MSR_SHADOW_GS_BASE, msr_val, ctxt); + goto done; + } break; } break; --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -281,6 +281,8 @@ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) / XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ XEN_CPUFEATURE(FSRS, 10*32+11) /*A Fast Short REP STOSB */ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ +XEN_CPUFEATURE(FRED, 10*32+17) /* Flexible Return and Event Delivery */ +XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ XEN_CPUFEATURE(WRMSRNS, 10*32+19) /* WRMSR Non-Serialising */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -295,6 +295,9 @@ def crunch_numbers(state): # In principle the TSXLDTRK insns could also be considered independent. RTM: [TSXLDTRK], + + # FRED builds on the LKGS instruction. + LKGS: [FRED], } deep_features = tuple(sorted(deps.keys())) From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:50:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:50:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517909.803890 (Exim 4.92) (envelope-from ) id 1pjhz6-0008GE-9a; Tue, 04 Apr 2023 14:50:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517909.803890; Tue, 04 Apr 2023 14:50:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhz6-0008G7-6Y; Tue, 04 Apr 2023 14:50:08 +0000 Received: by outflank-mailman (input) for mailman id 517909; Tue, 04 Apr 2023 14:50:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjhz5-0007P6-7w for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:50:07 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20619.outbound.protection.outlook.com [2a01:111:f400:7eaf::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc72725c-d2f7-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:50:05 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB9979.eurprd04.prod.outlook.com (2603:10a6:800:1da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:50:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:50:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc72725c-d2f7-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GsoDCfEdy+uT5ocgTR3PmCem/D/ChYSS4+J+KKb/WUQSvJ56zE3+pqAMr1WVxA33T+a/TBw9G+pdOo0JxE6a5sOjxjGeofDneGgHGjcbA7cZCUXAgZr0H0W/JsZL2WFnqtmVWGEBD5aq5keMZlBHCdjH8HFVFNaa7fZbqrbQGE3h6VOORr5tFwV9C+Af4moMUMjF91BPm/361n6MzE0Kl6T9J4wxerZIKpmCQFnwZDpTw7m0u4ZX+vtg17lai4Av6PFuBCr++28x3Y9XOF/MVq+yCz6x9mSE4KbZw06uEDSAjlB2luYRYvDuPk/iNcg5hnp9XcfdcfmLTRyhj042QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gLZS7zO17fvDUH6j59nF4hxdbd2yaRJuM4XD9fYDp0s=; b=FiG57S8EGwSoQrn3Nr3WreXdB5DppEJ0cHrJCyNgh/DtGpmxRKs+FEuhItLjtJWCE/KQuWQdY38OMVylHDSBum10YKjKg5I0LQxbFY5+6dbQBW80V1pV3QaTt+27/ocF5OmEdnHIupOH9zj3mjp2WuRqaBlOor1rTr1i33qPeZUDqljDdFk6i1JtT79HMp/ddyyFU43zgGdD0PecJ3ZwNrd10ZrAaBCjYQvjCL9kUPWt211PUlEInfgN/8wtbxUv6kBF4AHGCq7qIFu+Kmf/tukV7sw4GrwOfq6udTmWoad2qKJ1LdN3yhD5Mt/7TmuuX1dIb3rwLYzKlH/tw/3Myg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLZS7zO17fvDUH6j59nF4hxdbd2yaRJuM4XD9fYDp0s=; b=Tm2oAQR0bOwQ9ossvg11iCKg7/BXM42e9VT5HI9KBUcbQe3VbtmoN1cbMYE2ne6SqpI0VapwxZp+rlh5xJwChIEzMPLtSqJf0fcGbKm3L7xWd9zIVl1KGBO/ihpVzH11ZRm7CQvZEH4R4RHkbrcbBMBj7yxzROzoIPWV1xTVvZhhzANybmvuA4wX8lho3+PzjXh6VGPNbN3vnt8JG4Wxk4V+n/2KtEgVsthw+YCBUFgyMowOH0JYA9Y9W9f7l21784fpz3keqm2wC9D9pwzYs7uTq88yMIvu+xe54A1V/xb74PNtq1GlDnzfWB61+wP72t1zU4FnhEeR8vNelMfqAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0c2ddae9-3222-9755-b6e1-35e51410093b@suse.com> Date: Tue, 4 Apr 2023 16:50:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 2/9] x86emul: support WRMSRNS Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0077.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB9979:EE_ X-MS-Office365-Filtering-Correlation-Id: 13dd7963-161c-435c-9dc7-08db351bdf05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M9A4e083zpWr9QYF+Aeqriop/HnY/SSzwxalGvEnhx0WKi5etch1CrUHz5c4LHFvF19c/gSJYaMq2nNf6bm80AuyA/XQzGIWv2Ov9weITz1mofohMX0uHVALo2hwlsBCWjoyXI+Y/0waWfMgl9B8Eh0mCOGBJqbVnTvQeJdR7l5W43iAsMnd/zoY1ka4+Hm5FMTOgEyJwkideuGdSMc6Jczb3TdWr3YWNe7C52rGLOdHc/DKIsXJ2koHDbrf5s+9WBNG/2SbPV+HSJN1leWgYyzR0ggbVbs4XmY9+b6ywdts6igoDa4sDREtzOMyo6OunObvZKDZuYCU9T3POjxeGuBTHMzCXve/VRhxN30TqwC+ENN2726PDCd/BglxMdXiABwHVahUnJ6+Y5LpD4OE2wq9L5U7lDyA9CUOwvYFu7+21xcAIxHsEsJUaig76qEWKoKoaO7mUobwORIwaHGqTTY5g1A+gW0n/9GiNgz4SKIL3rC081mAUAq83i7Ct1kc8jO+xqVb2e2NT7z+/3DCjWsxKriFZtt23Pg+OcmwQyDWpOSTWxQ1ixPDtuH+ouBHzoQhw69g1CzUTk7KkFdnKk0ofNrz91cyR5lpkUmkynAfEYBgx0f5pu3fPO1QyCJ+AFvjVlWFtgQcXMsVoKdwdfqEicnris3TN1FbXpMDrUdGsAK64UB507eX9G7cTn//+5rraKoXCBc9/g/UReho7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(136003)(366004)(39850400004)(451199021)(83380400001)(2616005)(6486002)(6506007)(316002)(6512007)(478600001)(54906003)(2906002)(26005)(186003)(5660300002)(38100700002)(66946007)(66556008)(66476007)(41300700001)(86362001)(8676002)(31696002)(8936002)(6916009)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzdwWjZ5ME1DaEdIRkhGTU95L1QyOXlmZDBQV3F6N3ZrK3ZocnRJemI2OEcy?= =?utf-8?B?L1lTSnJSYWg5R3dyVDRVWXRWNWN3d1VUSjBkdnlIOEh1cmhhaUhTVzZpQWU3?= =?utf-8?B?L3QzQitPNXlMa0d6WXU1cUNlR2h1R21RaStrWk8zNWM4V2hOaDREWlBJL000?= =?utf-8?B?eHBIMmIzcWgwVzFXNHlESnMzODRiZElXby9rQXN1UHFnNng5UzBDcHhNL2d4?= =?utf-8?B?ZU84c3kxN2xlS3R5V2tocVZpK2M5MXVhWVJjdnJybHQ1ekExM1FKVHNrdzh1?= =?utf-8?B?MXZ3SUY4U0w3QUZlejRvcDBmQWp4VVRXRTIwMElqcForYUZPVFN5TGpyaGxQ?= =?utf-8?B?UFdzTmpPbWRISGtMRHVYUHZnWXF3cnhwYzVNbHZNbTRlbkx1VkVPYXNTSGhp?= =?utf-8?B?VXdWV2NNU1V1QjV6ZHRPL3JwMVA2dkE2UWhrNEFrWHE0Mlhxck5COS9UWGN5?= =?utf-8?B?WmRObVZHdnNVa2JBOE1HMldUQ1NIbHN2anM4a21Mb2t6amxEYVp0N0VQSHJH?= =?utf-8?B?MWszZ3Q2dXA4R1Y3MXptVVJCVlNaeFc5ZCthYUp5WkxNQWsvN0o1cmhZKzZI?= =?utf-8?B?bUMzY1VldWNYdkkycjBZWE5wUUlwYmdkd3RLalVYczZBWGxUSXJTcEsrMlEx?= =?utf-8?B?VUxoM1E2RnVCQ1hyOWllb3NSSGI3a1VyVWQ4ZkZaSVV1MlMwOVBKYjJyeDF0?= =?utf-8?B?SlFTUm9haElheGkvczZDa29aSU9ucnVnUlc5RHhad1M4cHpwS1V5a3J2RUV1?= =?utf-8?B?MGdZdFNZYUc2ZGV6UkJpeTA4ZVNabm9XTFhrdys1b0thYkR0aUJmWVdkZm54?= =?utf-8?B?am56RCtqOGpPdUxqdWRIOHZaS01TdGN3YU9VUXcxOHp6Qml2Mi9yejZnUitT?= =?utf-8?B?V0JiTExtZGkwS1lNY1lNWnJSTWlRZlVPYWNkbmZNY1YxYmFzZmZvMVRmaGNL?= =?utf-8?B?V3RrcjEwdzJlVUpkWTZWS0JtbDVZcUdjL2c3SzB1WWJYT0oxMlRtZStHK0J4?= =?utf-8?B?aGEzOVIrT0pwdTVXdi93ckh2dlZBbVNJMGt6aEZzUjZzYkxvU0NXUjZsT29I?= =?utf-8?B?Mk5ISC8rcEIycXhNWmllakJqbFZ5ZEFjNGM0WURQV3pObGtTNkkzZXMvVmJ1?= =?utf-8?B?T1VhcFFySjg3Y0xjWGYrOW9lTlFjRFB6R2lSWWZhS2hwZ08rRkNXNDlsQ3lw?= =?utf-8?B?SnZISFN5djZRcFE1RkhsNmwzeE1rZTZwTFRENWdOZzNOTVRzZjVGaDJzTTBV?= =?utf-8?B?bktRdEI5VTViQXdVT3AzK0dNOEJiMUZOUEpyTFg2OFNPR0dOYzZkdlF2TFJU?= =?utf-8?B?ZGZraEtvQ1Z3YTU3aUR3cThnbGFWdnN1bm11VmdMclBNSWtPWmJRMmV2SmZW?= =?utf-8?B?QW5PRGYzeXlJbWFjbXhsOVB5NjJmMFdndDJtQUhZcUU5MXRXbTJ1WFBBdUp5?= =?utf-8?B?ZzVUOGp6RGFrclk5Mjgya21oY0pTRzRkUDRUSWI4U1ZuWWtsbWVkZ242MUdH?= =?utf-8?B?eEk1VXFhaXJ6Z0lXTWNYU0FlNWFIV3JpditFMTJHc1FvTjlsbVhUaUxpV0Fj?= =?utf-8?B?NE5GS1VJTGpFM3RwV2VmOE1CWWlrWDdsQklKdTZyYit1SGFtZWI2eFlXR0RH?= =?utf-8?B?TG1EVUVCTXM4UVlGZ1AwUmxuOVplVTZ0cEZBOXl0ODFTL3I0dUN5NG9GZXJp?= =?utf-8?B?cUhkN090MTRXZkFuT1JpZFgwZkwwOS9wSjFidFN2SGpLZEJuQk0yQjdWZFZR?= =?utf-8?B?OGhDd21GV2lNRitXNEEwMEFndk1Uc1c2N2JIVWV5azVFRk1ab2JVL1g2eVJ2?= =?utf-8?B?ZjRYVkl2ZHBMdDIxLzBGbVl2clRxQmthTTBsR1hxalp6OWZkby9hSFFBUllD?= =?utf-8?B?T2dDZC96TVk4NWlPd1BnSHM5MGhjUmY5UkN1UU12UkY0RDRXOEtEeDZLenhC?= =?utf-8?B?WUp5dkdZWG54amhYeFExK1VGbWlMeHpmZ1EwMVJ4MUtETktvQ3JlV2tYa0Er?= =?utf-8?B?MHRjUnRsS2ZUdWhIQ3Y0OE9tQlZjMmVJb2hXSmp4QTFkcUR4TW9HZ3NyZ1VW?= =?utf-8?B?VVRlc1Q0ZVpaY013SmprY2tBUVlDTnN0dVdKZm5ZMG9oaUhkNXlqRDRaZ21z?= =?utf-8?Q?O4NWMfovbM+i2gc0xoMp85nuU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13dd7963-161c-435c-9dc7-08db351bdf05 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:50:02.6525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u8uza9ILXMWS5UDyR3d1LmgnZyLzIOwLbUR3xRITAJsl4u51eX1GpHZ4sI6hBP0wjyZZfCVEWY0zS5f6/5qq/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9979 This insn differs from WRMSR solely in the lack of serialization. Hence the code used there can simply be used here as well, plus a feature check of course. As there's no other infrastructure needed beyond permitting the insn for PV privileged-op emulation (in particular no separate new VMEXIT) we can expose the insn to guests right away. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -341,6 +341,7 @@ static const struct { /*{ 0x01, 0xc3 }, { 2, 2 }, F, R }, vmresume */ { { 0x01, 0xc4 }, { 2, 2 }, F, N }, /* vmxoff */ { { 0x01, 0xc5 }, { 2, 2 }, F, N }, /* pconfig */ + { { 0x01, 0xc6 }, { 2, 2 }, F, N }, /* wrmsrns */ { { 0x01, 0xc8 }, { 2, 2 }, F, N }, /* monitor */ { { 0x01, 0xc9 }, { 2, 2 }, F, N }, /* mwait */ { { 0x01, 0xca }, { 2, 2 }, F, N }, /* clac */ --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -87,6 +87,7 @@ bool emul_test_init(void) cp.feat.avx512pf = cp.feat.avx512f; cp.feat.rdpid = true; cp.feat.lkgs = true; + cp.feat.wrmsrns = true; cp.extd.clzero = true; if ( cpu_has_xsave ) --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -1252,8 +1252,11 @@ static int cf_check validate( { unsigned int modrm_rm, modrm_reg; - if ( x86_insn_modrm(state, &modrm_rm, &modrm_reg) != 3 || - (modrm_rm & 7) != 1 ) + if ( x86_insn_modrm(state, &modrm_rm, &modrm_reg) != 3 ) + break; + if ( (modrm_rm & 7) == 6 && !(modrm_reg & 7) ) /* wrmsrns, {rd,wr}msrlist */ + return X86EMUL_OKAY; + if ( (modrm_rm & 7) != 1 ) break; switch ( modrm_reg & 7 ) { --- a/xen/arch/x86/x86_emulate/0f01.c +++ b/xen/arch/x86/x86_emulate/0f01.c @@ -43,6 +43,20 @@ int x86emul_0f01(struct x86_emulate_stat struct segment_register sreg; uint64_t msr_val; + case 0xc6: + switch ( s->vex.pfx ) + { + case vex_none: /* wrmsrns */ + vcpu_must_have(wrmsrns); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); + fail_if(!ops->write_msr); + rc = ops->write_msr(regs->ecx, + ((uint64_t)regs->r(dx) << 32) | regs->eax, + ctxt); + goto done; + } + generate_exception(X86_EXC_UD); + case 0xca: /* clac */ case 0xcb: /* stac */ vcpu_must_have(smap); --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -595,6 +595,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) +#define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -283,7 +283,7 @@ XEN_CPUFEATURE(FSRS, 10*32+11) / XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ XEN_CPUFEATURE(FRED, 10*32+17) /* Flexible Return and Event Delivery */ XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ -XEN_CPUFEATURE(WRMSRNS, 10*32+19) /* WRMSR Non-Serialising */ +XEN_CPUFEATURE(WRMSRNS, 10*32+19) /*A WRMSR Non-Serialising */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:51:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:51:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517913.803900 (Exim 4.92) (envelope-from ) id 1pji0R-0000QD-Jz; Tue, 04 Apr 2023 14:51:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517913.803900; Tue, 04 Apr 2023 14:51:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji0R-0000Q6-H0; Tue, 04 Apr 2023 14:51:31 +0000 Received: by outflank-mailman (input) for mailman id 517913; Tue, 04 Apr 2023 14:51:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji0Q-0000Q0-MV for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:51:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061d.outbound.protection.outlook.com [2a01:111:f400:fe0c::61d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e687569-d2f8-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 16:51:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB9979.eurprd04.prod.outlook.com (2603:10a6:800:1da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:51:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:51:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e687569-d2f8-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XANcl+4tlrwBoTsvD4ro7L547vtHaE+az1sGOkY/hrFadqxBtXZkvrZCC/jz6BXakZ6cu7AUFEs0i16TgCKVtvMr1mgj7DCLuz2Z/Hty859M0y5ybeqP1dZrj/2BnOvq3XTMHrlkkjenbnzpR9j2Ria5AO2aWKeVIcXAlu0qQQzuUMoi4O75KdVavZKxTK8GnEhAPALDy3i5iH4PqBf0ci1lJXtZxi4U6iTwl2u9ZXgzaYFewQ6x07rjvnAcgGJ9+jmTaHmoPU+4RJcjCbN9dtt1PtjIezmiPrL0C6uqZ54s/T+CuCCeyMNNOsZWIoiN7DVr+tVvAqHle/1lQxA/8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eoN5/J1wcWGoWrTfKMxsXC6epsaN4Cagva4IJnTZ3rI=; b=Kit+0++cgohLU6r5aI7YpsOx4hEl9AOJMOZ7R5o/ex5zt7ZeQpXLvm/zQv0G4v1N51Q7mwZBnwrcB+bx0MGwXhzEqFmlMt+hAYrCGvHy1G4L7CVNYo6Q3JTniVYAQqxMcSUzG0Zt0Z2NaI2hflxuGkYDLn46ynm4B+dRp6sifDyEEXCYEXWf9qfE5JRNBLJcFvbSbz5/QLi31CdiPsIeIgDW6ruoSx/MRZ2cD4dPBNL4TRV7X4zJpREnnu3Uodf7z6lb2srNzXMXMOa8AdhhBzbEUmTVdcum/Iyg5mOa/rniVbbEx3rpE8GqwI1/fITzlphHN9ftYS0CYfxoLadhDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eoN5/J1wcWGoWrTfKMxsXC6epsaN4Cagva4IJnTZ3rI=; b=LQnFx00uCEIVsIM9lGKLXcHwic0V8q1JPW4C9g3tBt7uUwoxzZ33EQnJpWc3fUT23iCBcrGo8WrgZoKbt1e8xUBsEyQs4JS+eTWD6+lrfh7Kk87uZYisugXeXpJy7HqFhNq7eHQlPnthxxLMe8PpcuR7D+PCIAtJql48Wd8pwRxJM7unnS+CfyK6gdjW0s9ofJga1eBVSxskbduvrQhitwQfH8QmBE3YjvgdZdIHkCHxgW0ryxFddy9sJDVrU9DgFvklZGaQY+n6mDe9YORc+aGBucM6AdO0SdeRtn3II/9H4EAV7NYiRYE5JmvqiExY0BkKKZ4TSX0nxVxbvhTH/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:51:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 3/9] x86emul: drop regs field from emulator state structure Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB9979:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fc72461-e753-4fb9-92a7-08db351c1204 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +i+O0wDRCs1crW0KniaW9fvWic7mfNcpD/5r6FOdWEqHExEkTjPNd+v7NWom4d0yhaawNWpSc/tyTLYN5c52pMSX+MWejYkNXG16t5g+V0eIuwNgA6RS0w3KPTaFX6YT+Ld6+dZ7hleyfJnFydVJKN4nBr5bM6g8oznX31lRfQPwX4ZE0Zl+AOC72aI6v8QXVsE/6eUg6bPre2zWtB+wFtdGWzn93eBXSGt44qKWq1KRnZDvjIgjbV8yYPG3y41OUzBAsiN1AVs/6ux4XV4eAq9+zVqNk5lPjkPmG+xM0B51VYOjwYwX7DG09EZ8xcCtkubXi8/mh72zt62a/Rl9QwnD/0/2jYFoVND6m+wgX+H5xBXr0kfM6u2MXV4S/mP2YOiqHDkMtHWyh2VnsKFtfKIFlcPal8U/9zmzyuRqjNZLUa7ja41GXATlQjescI1Ya65LbJxNPYIr4RLhup8sbXPuyz8IT+EtQnUw2Wbq0838Ri3lhkgK0B76yTbxRLVWblLbw3ZyHbjUBPlga1/ReyRcpdZcghtKfbdMCCN3YG3lVtnZYP6WMMO2l6pg7oWfDQsN4MciuW/yJ1rQgKoiGF7IKqrzCrH4tpFCJB9sm4Pn2ooVRHwssXD1wusmMWlLLphm6CDZ8sTjk5arO6P8wOMzDKpj8zZoE/WeUu85mKj8iJdnXbT5VOq2k8IWCmoe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(136003)(366004)(39850400004)(451199021)(2616005)(6486002)(6506007)(316002)(6512007)(478600001)(54906003)(2906002)(26005)(6666004)(186003)(5660300002)(38100700002)(66946007)(66556008)(66476007)(41300700001)(86362001)(8676002)(31696002)(8936002)(6916009)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXBHWUk1NTdlN0c4Y2h0ZndzK2x3TDcyYnFnU0x0L3YvblZsVnJPc2M3TTVo?= =?utf-8?B?YndCV0tVQ0VDVlBpVStFUXZMb0UzOXNvUDhubjBhTU1zeEdpWUp5UlZHeVF1?= =?utf-8?B?bi8zSzdqMFkwcjI4azhwVXAzOTNIRVg3cWZMSE4rNlJuN0xVOG41TkY2Rk5t?= =?utf-8?B?WnUwMS9zOC9pcDRhd3dUYWMyTE5PS3IrR3cxckhmUUJsT1lvRi9CZkJ4Q3Zm?= =?utf-8?B?QSthNEgrU3NCOUNuVWsvNk55UDgrbk91TmRGQ0xrcDdUdDRrN2lXdFBvSy9X?= =?utf-8?B?aVdackMvM2ZUSkc2OTFqcnZrSFkvMExkYnRDbVFweitPYXBpc0s2WklRczFR?= =?utf-8?B?WVJWV3U5ODdhRzZHckc1TkRCeGRid1Bwb09HZUZURGFmZ254cHlvZ1l3eGlJ?= =?utf-8?B?NHhWTGlmN1pHMTU1cWpTZ1NtV0FzV0l0VDMvMko4UGQwc0xhOXJjU1gyL3pN?= =?utf-8?B?enBGSFBpUE04QWtNQVZ5SjlLTFEzR1NxaHhuMU11QUlBRDZBVWVSN2d2R0lQ?= =?utf-8?B?ZUg2WDNoc0t5SU15U3RXeGp2cnJRRnV5Ni9zdUhHbjNtRlFQTWNHRmd6WmR6?= =?utf-8?B?WU1NSXZGNVNHTGUwTUJLZ0FsTUpVTGdIVFRsMlNhS1BKYnlhVlhoY3ZjOE0v?= =?utf-8?B?RklsTFlqUE9qU0xTVlFIZ1BSL01ENWZKVWV0RW1oUDRBTkxHUUU4MGdPVGNZ?= =?utf-8?B?VXhUalRwTnZJRjVxYzFuZEIvQWxEdkR2SHo1dTZQZ3R1NnRaWVZ6bnR0TDFT?= =?utf-8?B?VVZGeks0RElHRjh5S2FWQU5IU05BRTNNV3JNWGlqdnNoVFBkdTRxSnhjMGMw?= =?utf-8?B?MFlFVGpVZ0ZVRk5PUVF2N2NKK0Z3V0NXanlQRHN1Rk5qMHZoOHF1RE92bGp5?= =?utf-8?B?S1NLbnVoT2NlSy83ODdZY3FZVnZFdjU5ckVERTYxMWV1MHVid0lNNko3NEg0?= =?utf-8?B?Y3ZuUnRGM2pid210K0Zaa1N5eU81L2lFdWpGVjF4WEdveHhFVUJuQjY3YnJI?= =?utf-8?B?RWZ2aUZZS29FTmM2WVNmWWVuOU5aVmVBSkJyQWp1YTBVa2ZzUTZ1LzNtVkgv?= =?utf-8?B?Q3QxZmw3ZzRFem53NDBLZXFTaFFJVm9hSWlqV1pXbTNyVDc2TEt3MSthbXBt?= =?utf-8?B?T2VWeVpwY21JZDkwcVI2SDE3djlRb2JaUWtJbkhPZklVcWgwRC94MlBGb1cy?= =?utf-8?B?UUEzaDR2djNMaWxibkJxZVJ6VDJZNDloUzVzM2NSNi9aYVFQOFNqK1BoRUxt?= =?utf-8?B?YXZrVnFZcXpmdDBzSXNBNGo0OXdhMWY5NjF5WkF2aFNoL1FoY1NFc2lhc2pq?= =?utf-8?B?YW9kdmRETnhmaVpJRzNOb2NjM1RaYTJjSUhRdTlWaHdEN1BmeS8xVDJqeUJx?= =?utf-8?B?R25YeHpNSTVKT0lPcVlNQW4zYk1od051Sy9jcFV1ank1Z0VrTzZhcmxnQ0gx?= =?utf-8?B?RGtWdUtsL29ZeHBwcit0M0ZwM1pOT2ZqaEdNVlVRQmpGdEJVT1BJbmErNVZT?= =?utf-8?B?QkhtZE1EMkUrS1NIeU1RRlExWUgxZTJuWWhhOTVjaDdvbjJCazhIV0FXWnln?= =?utf-8?B?cHhIZnZuQlpIZUJkaGxYMklDQ0kyWXhqVGl6Q0dER3hDWHFRUTNDZ1FWTWlW?= =?utf-8?B?WjNncXZDemtNanRTTXllYStraUhjdCs3bDc1L3BOZGtVRmlORmorZUlLczB1?= =?utf-8?B?dk5kTk80Q0ZicDJrendhZXhiUWNEalNyUW9vaHJENjViTExDaHBFdlVEbHdM?= =?utf-8?B?UjAwYzhoRGVLU1V3OG0vZElCSlR3UTZ3dG9jRDRJSUNKenVSZ0VGbE1VV2NZ?= =?utf-8?B?Tzh6Mm1STWNtS0Q5OEUvYWhpMUxQbzU0ZDhHZUNoYXRZU3J4UWpVRlNtbG56?= =?utf-8?B?Tmh4K2Q1Y3BKREdFK3lyMnNUeE83dERJa2o2TFRsSDRwK1AvcVpWNlZ1dS83?= =?utf-8?B?MGxTc3pHdXFSdjRHczlCb0wyYWZhUkJTK0lqZFNIL0Nvb244cUtadnRaQTJi?= =?utf-8?B?YVJubnVFaFZmSnRUc3gyUVM3WUsrWTFLZmtRN2JGMWZ3Z2RxVXZXSU51Vzdi?= =?utf-8?B?SXEvdW9ZSHBxbmk1bHFJemdtU1d5T3Rrc0JHaURUWmljRXE4UnkwNzVqQXBK?= =?utf-8?Q?geUtSPpQsDwSsOmrbrBJ1d5Zq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc72461-e753-4fb9-92a7-08db351c1204 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:51:28.2371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o2LtRZdsAfE8Y0Vt+/qcG366+tWsmoMtZEMrlP2JlydSqXLFpnf9wu4csyY9Y/BJ7h/uIhdZXQUgIvOphrq6hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9979 For an unclear reason 0552a8cfda43 ("x86emul: track only rIP in emulator state") converted the original struct cpu_user_regs instance to a pointer, rather than dropping the field altogether: The pointer merely aliases the one in the context structure. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1013,7 +1013,6 @@ int x86emul_decode(struct x86_emulate_st s->ea.type = OP_NONE; s->ea.mem.seg = x86_seg_ds; s->ea.reg = PTR_POISON; - s->regs = ctxt->regs; s->ip = ctxt->regs->r(ip); s->op_bytes = def_op_bytes = ad_bytes = def_ad_bytes = @@ -1129,7 +1128,7 @@ int x86emul_decode(struct x86_emulate_st default: BUG(); /* Shouldn't be possible. */ case 2: - if ( s->regs->eflags & X86_EFLAGS_VM ) + if ( ctxt->regs->eflags & X86_EFLAGS_VM ) break; /* fall through */ case 4: @@ -1458,33 +1457,33 @@ int x86emul_decode(struct x86_emulate_st switch ( s->modrm_rm ) { case 0: - s->ea.mem.off = s->regs->bx + s->regs->si; + s->ea.mem.off = ctxt->regs->bx + ctxt->regs->si; break; case 1: - s->ea.mem.off = s->regs->bx + s->regs->di; + s->ea.mem.off = ctxt->regs->bx + ctxt->regs->di; break; case 2: s->ea.mem.seg = x86_seg_ss; - s->ea.mem.off = s->regs->bp + s->regs->si; + s->ea.mem.off = ctxt->regs->bp + ctxt->regs->si; break; case 3: s->ea.mem.seg = x86_seg_ss; - s->ea.mem.off = s->regs->bp + s->regs->di; + s->ea.mem.off = ctxt->regs->bp + ctxt->regs->di; break; case 4: - s->ea.mem.off = s->regs->si; + s->ea.mem.off = ctxt->regs->si; break; case 5: - s->ea.mem.off = s->regs->di; + s->ea.mem.off = ctxt->regs->di; break; case 6: if ( s->modrm_mod == 0 ) break; s->ea.mem.seg = x86_seg_ss; - s->ea.mem.off = s->regs->bp; + s->ea.mem.off = ctxt->regs->bp; break; case 7: - s->ea.mem.off = s->regs->bx; + s->ea.mem.off = ctxt->regs->bx; break; } switch ( s->modrm_mod ) @@ -1517,7 +1516,7 @@ int x86emul_decode(struct x86_emulate_st !s->evex.RX) << 4; else if ( s->sib_index != 4 ) { - s->ea.mem.off = *decode_gpr(s->regs, s->sib_index); + s->ea.mem.off = *decode_gpr(ctxt->regs, s->sib_index); s->ea.mem.off <<= s->sib_scale; } if ( (s->modrm_mod == 0) && ((sib_base & 7) == 5) ) @@ -1525,7 +1524,7 @@ int x86emul_decode(struct x86_emulate_st else if ( sib_base == 4 ) { s->ea.mem.seg = x86_seg_ss; - s->ea.mem.off += s->regs->r(sp); + s->ea.mem.off += ctxt->regs->r(sp); if ( !s->ext && (b == 0x8f) ) /* POP computes its EA post increment. */ s->ea.mem.off += ((mode_64bit() && (s->op_bytes == 4)) @@ -1534,16 +1533,16 @@ int x86emul_decode(struct x86_emulate_st else if ( sib_base == 5 ) { s->ea.mem.seg = x86_seg_ss; - s->ea.mem.off += s->regs->r(bp); + s->ea.mem.off += ctxt->regs->r(bp); } else - s->ea.mem.off += *decode_gpr(s->regs, sib_base); + s->ea.mem.off += *decode_gpr(ctxt->regs, sib_base); } else { generate_exception_if(d & vSIB, X86_EXC_UD); s->modrm_rm |= (s->rex_prefix & 1) << 3; - s->ea.mem.off = *decode_gpr(s->regs, s->modrm_rm); + s->ea.mem.off = *decode_gpr(ctxt->regs, s->modrm_rm); if ( (s->modrm_rm == 5) && (s->modrm_mod != 0) ) s->ea.mem.seg = x86_seg_ss; } --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -321,7 +321,6 @@ struct x86_emulate_state { #define imm2 ea.orig_val unsigned long ip; - struct cpu_user_regs *regs; #ifndef NDEBUG /* From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:52:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:52:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517917.803909 (Exim 4.92) (envelope-from ) id 1pji1J-0000xt-ST; Tue, 04 Apr 2023 14:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517917.803909; Tue, 04 Apr 2023 14:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji1J-0000xm-Pp; Tue, 04 Apr 2023 14:52:25 +0000 Received: by outflank-mailman (input) for mailman id 517917; Tue, 04 Apr 2023 14:52:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji1I-0000xc-89 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:52:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0607.outbound.protection.outlook.com [2a01:111:f400:fe0c::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e22134c-d2f8-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 16:52:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB9979.eurprd04.prod.outlook.com (2603:10a6:800:1da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:52:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:52:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e22134c-d2f8-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SA3IJD4J6AdT496EyuFZF1ksGQWwNwCJX1fOQOuUXQwA9LT79yU3CD7gefWlKowNKY7qp61NXsua/ffV9PLUNzNJVELCjA8e+51qEMVciXPxW45/8zYRaY0tFPmahZlduvu554rr7YSHnOyOCEUXWr7ipn8l+NpQ2YvYW6tr8f3ZT4icAxK2vo2vLDGQvjZ9YYk7Ys8djKDOaSws/qUxjHhHreQePT1kga046WqW54hAT67OoDj4eKNPsj78TpL3GVIO8OwbazM1ZsmBCHIfIDWkm5+VhhQ2ucjoQuzh6x69JC3veovZCjE/g7bopj6gzAGVxYVCpzy2nIXGVHEe1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytto9LVBxwhZWpIO0ffNtB+orBK2vTWlKoDCEHOFFGA=; b=k2NC7FNaoySdRSkYTg0hOI+p/jROwE71n4cleef/1LCtye2RD241KlmZV466bCcCmSbXdeB/6mQL+oceYn/txiXy0aoSLNUnjfYzpT5nsaG1JWCnxiOHdSPtsqaliAREt5drlWGoLkdOiZjUb9alWp7rEgYEHB/msEDYqaqxrVQmHMYgb+tKF5kS/qD35SFdeWdbjTVpvdx/kNVnQbH6VYCssuvNqBAo/83Loh3eFRDkoP4ARB8dk9zFsyeYKrgZgMM3L2V0dfbci3QFN6JcD2MYf8wyXzc5lwC0ejpWtGi+RbCiyxV8rIUcNQVoJ+Gsj1/RqzSHf5jGJvXWqz56Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ytto9LVBxwhZWpIO0ffNtB+orBK2vTWlKoDCEHOFFGA=; b=3EbP+drpvdTr+SnRb9FMjKKHDtL8JluIHUEIC1Y9JBghfik/V7zNcSb5HEkGo33nrWDJOiGcimldftFjwhKihui+3bMsHD+fqKcNZje7ErqGnjFYburtNhmhblLW8HkHYCLeByENXxZXiDItzaX3hdfxnThsUk5bcZUFSyM/8DYla5Keawc8GkYO99EamivdYd4JfbjritkzUcxpYmGdYGKLiQ7AKcpI9AiwV4FMQMskBPb+rMm5wzWP2FWUVdezH+eRY7CQzEOmBkODtN5Fr8n7NE2NBTy9c7AuEDFbozmqBM9scrp3sVyd3UR18lqxMRBakof1ipgoHrjLZ1uOsA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7fdf882f-0667-e0f1-8183-2dc1a344f4fb@suse.com> Date: Tue, 4 Apr 2023 16:52:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 4/9] x86emul: support CMPccXADD Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB9979:EE_ X-MS-Office365-Filtering-Correlation-Id: 26a2b5d1-4b23-43b1-bff5-08db351c3185 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p/g0L5g/0M52/bLrqgAyDMN6xCfU6LzoTIsNQPL3c/43p80bWgLMNSg+ZASemFQ4/nnzn2aChYNc6jpokWischmjnnkYyTy85VAG43DMVC4ndQJ4voeHNyAGastoIjybugWeUGEnJtYfT5rPmvx7jvwydKcQzXsKEk93qnMJO06Rxz+obwPn0cuBpNxo9IQrzLDkqZ85AhMMagT63j1ghSL0xgC0A94WWhRkt1J2BqpbmXj3OwWHfknkpU6oqc/8qskjJVcYmxLZC/HweNoM/1Q0KamfkPLtOga5Of6X3IiB9fNJvlJCAjMMnmYu8dy6aKIEKIA9AVx1wOzSmcO2JXc3dc5+rVp4HTCXFdqT/50iXv+zOSaYMZfWoIzpqyqfoTULGv0s5ron16CN8T1l8lz472pR0KVNYaRVXpY0Ywexp5F/k38t2MHmkLar3J18gCbqczESuTlTcegVJG0H4cEFP0UlkiMiScLfrKaOgmqNqHAf9SmSMXTHUV/pqRhOU177BGUhcjzBfzmpVhYQEHE3OM52WNTnD91JEnSj4KCsD8fKE1XvhxkGLZB4wxIfp/GEIzvQhO3OI/K+N+In61ysjjv1dCTEYcVn9CR1M6wp6Xf5hYi/V9deO2IDKigNZnvIX5mvSmAtuiuIJSX9iA9O3YrDc+Wl2jjg1C/EZF9pJqY6AbZRn9tpUrvUGX8u9OwaeVydw2ztl8AtJNAdxA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(136003)(366004)(39850400004)(451199021)(83380400001)(66574015)(2616005)(6486002)(6506007)(316002)(6512007)(478600001)(54906003)(2906002)(26005)(186003)(30864003)(5660300002)(38100700002)(66946007)(66556008)(66476007)(41300700001)(86362001)(8676002)(31696002)(8936002)(6916009)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elhsdXBXZjYvS3Qzd3NEbTJkS1FrdDlYbW1xNWl4cGpsWkpEcFBWZGY1bUJq?= =?utf-8?B?dTZsN3dla1c3dHlteU91U09JTlRpdm5MS0JBRkMyQ2NJVGI0WUE1L1dBYTB3?= =?utf-8?B?VVV5OTY0TlVGT3VsNXIwNWMveTBCYm9pZHJhc0dXUEFjS0x6TlA3ankzQ2I3?= =?utf-8?B?ek5yK2E2TmM4OUFTdXA3Y0NQeFFOTVFiVkNhNWNqT0NIMGViTi9iQnFrTnMr?= =?utf-8?B?TiszRk9WZkJwQUFXaG9CMDd4dy9kZkxZV0sreDV3U1dUM0VZcXJQV2l1bERs?= =?utf-8?B?RFdCUTVvZk03YTZZVHNQb20yNzBqckFYOFpBNGJHNkg3QkkvT042TEIwbUVJ?= =?utf-8?B?MTF3cmE3VlFpbk5aVE52bnRvWGlqMytLY3lrZkxNczNEMG1HN0ZTYkRhbmhn?= =?utf-8?B?bWJwN3NlZEZIbnRhMVljYUJqUjFLQW1qZ2NUUnhvcFBmSTlPeTZ2VWJrNVNj?= =?utf-8?B?YTZEL1JneFg5a0ZTcHRyKzlMb1M1TlhwVU1jTGRuMDZJSWMzTGJqS05tS2tu?= =?utf-8?B?UWJDNllpRkJiMHZBZklmajJYTFBweEZteEkvV2FHMkpPRG5SRnR3dStrUUxi?= =?utf-8?B?MFpURmpPZ2FVUzR2d1pZa1E1eTVRckVIRDdtZS92RS9YakptNWRFMEx5akhG?= =?utf-8?B?NzZmTURIalVpQ0lEcUhwOE96VjRyQ0QzSzV4YWRMTmpjeXkyaElZSVZPYkpU?= =?utf-8?B?YlpmaVlPZmRkemFOTnI3K3JQSU5SNHR6UzRaQmNRQlNvSUcxbUhVR1U5ODNV?= =?utf-8?B?dVhRT2ZjeFBRR1BDcmNQa2RLWHV5cWxYNmJkZ2x5cThybjhPS0QrakFtbFdT?= =?utf-8?B?dUVBWFl0UTM0dEdXci9yQUZjN2U1MFB2ZWkwUDFrY2dSVmpaWVJDVGVwUTJy?= =?utf-8?B?YTA5QWlYU2NFTzMxSmYyRkRNeWRSSWY2L3lONWhLRnBWeTdkRncxRW9wUU5O?= =?utf-8?B?UnJybFY2Nm5Dd09EOGpqWnNYeVNiU3dKOVpkbEFnZEFvSjZyME9EelY3anZ4?= =?utf-8?B?MjJpQlJzZDFBSjlDZFFXd1g2M2ZCanpJdU9DTW1Qemdvd2puNmkycWpWQStm?= =?utf-8?B?enE0alJyeGI3dkR1ejU2MmhHbHIwMEtIbkdETEhpVDBIWEp6a0tha3pDU1h2?= =?utf-8?B?OEpJM0FaUklXblFPRDZjK3V0V1I5aE13RjNXZlIvZ3g4SjN4Y2JYRlBxN3lr?= =?utf-8?B?ZHVUb3I1U0xMQXY5Q2VGYWZkMmNzY0RwMThSRGVtdnMrQjNBUXU4aW1zQTd6?= =?utf-8?B?MWhuLzI2Q2xTSXNCbWhjWG0wRVR6ZHJNbVVOSXBsNEFIUTJjd0thV1BTc01F?= =?utf-8?B?Y2QveHAxR1dwRGhocVhWbnlqa1ZzSGFjWHNEMzBYLytPK29DNDhaMEdleGxs?= =?utf-8?B?VHBXQitkRm8zNHltaVcvZVNXM09EUCtabWlFV2tLbjQ5R2EyWEhLdkllbFV3?= =?utf-8?B?Tk9SZTF2OHVjelRRNzhvQ2EzUW44UzBNTU9LRVA4QXVBcmJudlAxclBhQk9h?= =?utf-8?B?akp2bVZ4dTlTcVcyU3N1K25iRWpMWkYrZzlybDlkRis4eXRBU2J3aXdaNHEy?= =?utf-8?B?L0FuUlBBQ1ordHlLS2lZYzRJM1pCZVE1MlVoQ2Y3a3Nkb3JFSjlyUE9YU0pJ?= =?utf-8?B?QUVaTEQrN0wwa3VaTmF0T2xrYzdhOFJlWHlLYjhDV0ZuU0NPdGRMVGVZcTA1?= =?utf-8?B?OUkxOU9MdXNITUkzU1djVE9SRzA2QUlyYWtkWUV4eUtUeGNpVzNyS3ZUbE9u?= =?utf-8?B?YWdvKzVhdlpZbTZFZjVBb3lOZFB5S0Y5L0oxT2txQWJmUi9kSGgxQWNNL0JK?= =?utf-8?B?RHJacll4ZlNOa2hFcXhGOEJhRU05SWJyRlR0eXhOUHEwVzVIeU9sSlJGblVD?= =?utf-8?B?VkNjRE02RkYrT0Roa0xJa0hGL1Mva3BYMTk4dVVydmt1amhwUE9sY2dLcjdW?= =?utf-8?B?MnBXc29pOTJ3NlRuallwUHAzZWNOWWVZSHpJNkp3Qyt1T2k1emhvdkM1Smxk?= =?utf-8?B?VDNYa2d3VWNzSzNYTjhQN0lzU21odldoOFRadU11M3BTV1kxckdLby80QnBU?= =?utf-8?B?RzRyS0d2SzdIcnpEcGxoM3VCZ3Y5YW5rVUJnQlJ6RG1iUGx2V2pUa01BUU0x?= =?utf-8?Q?LqPPpDvBk0nKkezpyyjDMiy+2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26a2b5d1-4b23-43b1-bff5-08db351c3185 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:52:21.1560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MedJmFONYDiI83Q6l+pqfjGeR6f562yEcTke5WMYchXpTbjJJTjcD880K4Pm5t3N9HWG5nI7vPV4hTFVT1OMaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9979 Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() now wants to construct and invoke a stub, make stub_exn available to it via a new field in the emulator state structure. Signed-off-by: Jan Beulich --- # SDE: -grr or -srf --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -232,6 +232,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"avx-vnni", 0x00000007, 1, CPUID_REG_EAX, 4, 1}, {"avx512-bf16", 0x00000007, 1, CPUID_REG_EAX, 5, 1}, + {"cmpccxadd", 0x00000007, 1, CPUID_REG_EAX, 7, 1}, {"fzrm", 0x00000007, 1, CPUID_REG_EAX, 10, 1}, {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -186,6 +186,7 @@ static const char *const str_7d0[32] = static const char *const str_7a1[32] = { [ 4] = "avx-vnni", [ 5] = "avx512-bf16", + /* 6 */ [ 7] = "cmpccxadd", [10] = "fzrm", [11] = "fsrs", [12] = "fsrcs", --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1388,6 +1388,22 @@ static const struct vex { { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ { { 0xde }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdec */ { { 0xdf }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdeclast */ + { { 0xe0 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpoxadd */ + { { 0xe1 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnoxadd */ + { { 0xe2 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpbxadd */ + { { 0xe3 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnbxadd */ + { { 0xe4 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpexadd */ + { { 0xe5 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnexadd */ + { { 0xe6 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpbexadd */ + { { 0xe7 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpaxadd */ + { { 0xe8 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpsxadd */ + { { 0xe9 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnsxadd */ + { { 0xea }, 2, F, W, pfx_66, Wn, L0 }, /* cmppxadd */ + { { 0xeb }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnpxadd */ + { { 0xec }, 2, F, W, pfx_66, Wn, L0 }, /* cmplxadd */ + { { 0xed }, 2, F, W, pfx_66, Wn, L0 }, /* cmpgexadd */ + { { 0xee }, 2, F, W, pfx_66, Wn, L0 }, /* cmplexadd */ + { { 0xef }, 2, F, W, pfx_66, Wn, L0 }, /* cmpgxadd */ { { 0xf2 }, 2, T, R, pfx_no, Wn, L0 }, /* andn */ { { 0xf3, 0x08 }, 2, T, R, pfx_no, Wn, L0 }, /* blsr */ { { 0xf3, 0x10 }, 2, T, R, pfx_no, Wn, L0 }, /* blsmsk */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -1398,6 +1398,78 @@ int main(int argc, char **argv) } printf("okay\n"); + printf("%-40s", "Testing cmpbxadd %rbx,%r9,(%rdx)..."); + if ( stack_exec && cpu_has_cmpccxadd ) + { + instr[0] = 0xc4; instr[1] = 0x62; instr[2] = 0xe1; instr[3] = 0xe2; instr[4] = 0x0a; + regs.rip = (unsigned long)&instr[0]; + regs.eflags = EFLAGS_ALWAYS_SET; + res[0] = 0x11223344; + res[1] = 0x01020304; + regs.rdx = (unsigned long)res; + regs.r9 = 0x0001020300112233UL; + regs.rbx = 0x0101010101010101UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[5]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x0101010101010101UL) || + ((regs.eflags & EFLAGS_MASK) != + (X86_EFLAGS_PF | EFLAGS_ALWAYS_SET)) || + (res[0] != 0x11223344) || + (res[1] != 0x01020304) ) + goto fail; + + regs.rip = (unsigned long)&instr[0]; + regs.r9 <<= 8; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[5]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x0101010101010101UL) || + ((regs.eflags & EFLAGS_MASK) != + (X86_EFLAGS_CF | X86_EFLAGS_PF | X86_EFLAGS_SF | + EFLAGS_ALWAYS_SET)) || + (res[0] != 0x12233445) || + (res[1] != 0x02030405) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing cmpsxadd %r9d,%ebx,4(%r10)..."); + instr[1] = 0xc2; instr[2] = 0x31; instr[3] = 0xe8; instr[4] = 0x5a; instr[5] = 0x04; + regs.rip = (unsigned long)&instr[0]; + res[2] = res[0] = ~0; + regs.r10 = (unsigned long)res; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[6]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x02030405) || + ((regs.eflags & EFLAGS_MASK) != EFLAGS_ALWAYS_SET) || + (res[0] + 1) || + (res[1] != 0x02030405) || + (res[2] + 1) ) + goto fail; + + regs.rip = (unsigned long)&instr[0]; + regs.rbx <<= 8; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[6]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x02030405) || + ((regs.eflags & EFLAGS_MASK) != + (X86_EFLAGS_CF | X86_EFLAGS_PF | X86_EFLAGS_SF | + EFLAGS_ALWAYS_SET)) || + (res[0] + 1) || + (res[1] != 0x13253749) || + (res[2] + 1) ) + goto fail; + printf("okay\n"); + } + else + printf("skipped\n"); + emulops.write_segment = write_segment; emulops.write_msr = write_msr; --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -185,6 +185,7 @@ void wrpkru(unsigned int val); #define cpu_has_serialize cp.feat.serialize #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) +#define cpu_has_cmpccxadd cp.feat.cmpccxadd #define cpu_has_xgetbv1 (cpu_has_xsave && cp.xstate.xgetbv1) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -170,6 +170,7 @@ extern struct cpuinfo_x86 boot_cpu_data; /* CPUID level 0x00000007:1.eax */ #define cpu_has_avx_vnni boot_cpu_has(X86_FEATURE_AVX_VNNI) #define cpu_has_avx512_bf16 boot_cpu_has(X86_FEATURE_AVX512_BF16) +#define cpu_has_cmpccxadd boot_cpu_has(X86_FEATURE_CMPCCXADD) /* Synthesized. */ #define cpu_has_arch_perfmon boot_cpu_has(X86_FEATURE_ARCH_PERFMON) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -443,6 +443,7 @@ static const struct ext0f38_table { [0xcf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0xdb] = { .simd_size = simd_packed_int, .two_op = 1 }, [0xdc ... 0xdf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, + [0xe0 ... 0xef] = { .to_mem = 1 }, [0xf0] = { .two_op = 1 }, [0xf1] = { .to_mem = 1, .two_op = 1 }, [0xf2 ... 0xf3] = {}, @@ -934,6 +935,8 @@ decode_0f38(struct x86_emulate_state *s, ctxt->opcode |= MASK_INSR(s->vex.pfx, X86EMUL_OPC_PFX_MASK); break; + case X86EMUL_OPC_VEX_66(0, 0xe0) + ... X86EMUL_OPC_VEX_66(0, 0xef): /* cmpxadd */ case X86EMUL_OPC_VEX(0, 0xf2): /* andn */ case X86EMUL_OPC_VEX(0, 0xf3): /* Grp 17 */ case X86EMUL_OPC_VEX(0, 0xf5): /* bzhi */ --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -265,6 +265,7 @@ struct x86_emulate_state { rmw_btc, rmw_btr, rmw_bts, + rmw_cmpccxadd, rmw_dec, rmw_inc, rmw_neg, @@ -322,6 +323,8 @@ struct x86_emulate_state { unsigned long ip; + struct stub_exn *stub_exn; + #ifndef NDEBUG /* * Track caller of x86_decode_insn() to spot missing as well as @@ -593,6 +596,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) +#define vcpu_has_cmpccxadd() (ctxt->cpuid->feat.cmpccxadd) #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6881,6 +6881,15 @@ x86_emulate( #endif /* !X86EMUL_NO_SIMD */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xe0) + ... X86EMUL_OPC_VEX_66(0x0f38, 0xef): /* cmpxadd r,r,m */ + generate_exception_if(!mode_64bit() || dst.type != OP_MEM || vex.l, + EXC_UD); + host_and_vcpu_must_have(cmpccxadd); + fail_if(!ops->rmw); + state->rmw = rmw_cmpccxadd; + break; + case X86EMUL_OPC(0x0f38, 0xf0): /* movbe m,r */ case X86EMUL_OPC(0x0f38, 0xf1): /* movbe r,m */ vcpu_must_have(movbe); @@ -7942,14 +7951,20 @@ x86_emulate( { ea.val = src.val; op_bytes = dst.bytes; + state->stub_exn = &stub_exn; rc = ops->rmw(dst.mem.seg, dst.mem.off, dst.bytes, &_regs.eflags, state, ctxt); +#ifdef __XEN__ + if ( rc == X86EMUL_stub_failure ) + goto emulation_stub_failure; +#endif if ( rc != X86EMUL_OKAY ) goto done; /* Some operations require a register to be written. */ switch ( state->rmw ) { + case rmw_cmpccxadd: case rmw_xchg: case rmw_xadd: switch ( dst.bytes ) @@ -8224,6 +8239,7 @@ int x86_emul_rmw( uint32_t *eflags, struct x86_emulate_state *state, struct x86_emulate_ctxt *ctxt) +#define stub_exn (*state->stub_exn) /* for invoke_stub() */ { unsigned long *dst = ptr; @@ -8289,6 +8305,37 @@ int x86_emul_rmw( #undef BINOP #undef SHIFT +#ifdef __x86_64__ + case rmw_cmpccxadd: + { + struct x86_emulate_stub stub = {}; + uint8_t *buf = get_stub(stub); + typeof(state->vex) *pvex = container_of(buf + 1, typeof(state->vex), + raw[0]); + unsigned long dummy; + + buf[0] = 0xc4; + *pvex = state->vex; + pvex->b = 1; + pvex->r = 1; + pvex->reg = 0xf; /* rAX */ + buf[3] = ctxt->opcode; + buf[4] = 0x11; /* reg=rDX r/m=(%RCX) */ + buf[5] = 0xc3; + + *eflags &= ~EFLAGS_MASK; + invoke_stub("", + _POST_EFLAGS("[eflags]", "[mask]", "[tmp]"), + "+m" (*dst), "+d" (state->ea.val), + [tmp] "=&r" (dummy), [eflags] "+g" (*eflags) + : "a" (*decode_vex_gpr(state->vex.reg, ctxt->regs, ctxt)), + "c" (dst), [mask] "i" (EFLAGS_MASK)); + + put_stub(stub); + break; + } +#endif + case rmw_not: switch ( state->op_bytes ) { @@ -8384,7 +8431,13 @@ int x86_emul_rmw( #undef JCXZ return X86EMUL_OKAY; + +#if defined(__XEN__) && defined(__x86_64__) + emulation_stub_failure: + return X86EMUL_stub_failure; +#endif } +#undef stub_exn static void __init __maybe_unused build_assertions(void) { --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -278,6 +278,7 @@ XEN_CPUFEATURE(SSBD, 9*32+31) / /* Intel-defined CPU features, CPUID level 0x00000007:1.eax, word 10 */ XEN_CPUFEATURE(AVX_VNNI, 10*32+ 4) /*A AVX-VNNI Instructions */ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ +XEN_CPUFEATURE(CMPCCXADD, 10*32+ 7) /*A CMPccXADD Instructions */ XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ XEN_CPUFEATURE(FSRS, 10*32+11) /*A Fast Short REP STOSB */ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:53:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:53:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517922.803920 (Exim 4.92) (envelope-from ) id 1pji26-0001ZI-Af; Tue, 04 Apr 2023 14:53:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517922.803920; Tue, 04 Apr 2023 14:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji26-0001ZB-7Q; Tue, 04 Apr 2023 14:53:14 +0000 Received: by outflank-mailman (input) for mailman id 517922; Tue, 04 Apr 2023 14:53:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji25-0001Yx-5r for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:53:13 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0624.outbound.protection.outlook.com [2a01:111:f400:fe02::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b18823a-d2f8-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:53:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8126.eurprd04.prod.outlook.com (2603:10a6:102:1bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:53:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:53:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b18823a-d2f8-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhnS7sPADdHjgqtZl6OY5N1VFd7TcKOoBUKAX5Wj7HYTQr0lRr6dNea8hpaLZJqAUB93Uu/mKBhDmSrGeqIug0TrqSafATODSiVfXbVWhK6EGrkK1F57nl19RFyCW9wgkRRQZg1MTlzbw1nZhX2hlioGNJ+Oz0dIkAXH8l2F5+rma3aMG80MBzwWU/UXES7yqM69ct5ENwFhvq1D5NN1xlPb52G/XnzI2V5H+LEpywQY+sbbnuPnp0BsonrEgV0m9+HD2jRgAaC9ROz9UUyIgZ52p1KydKEqOOy9X9osP1hOFSGwyQCurOHPR4N+UqsIxaR98UMp2HJkd52mDhZbaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8OsRmeonhBRsTzr/ndz1lxvEmvcIjQIblEBSSAV+qJQ=; b=iKBBzkhVmSNBmPbbVZtt/9+Bvf6t+CJ5i7fZKksYGXexRcH4AI79VsMXIrWuR10Z0d+Qjgyl8fXOsECQKY2LpLKyLjtmcknw78FkcBPc2wj1Iod5CsYU5Xy+0GN5Wn6EC58XpjWHUZ5FbvmBCrVhd/fB1o828GfDscH5/1cOExqb8pCyDwpLkdsNkCm2j5+aldUNOkuq5+yC3cOCBczbfAjUaw2rNw/mynZqgAXacRJCv1+u1ogtdEpRwPnCitLHbM/HjkC+oqFDeeQZDf7mbKwadV6TZ40dDO3mycH9cgEYWCwKbhorjLLl3Nqwp8/DsoMLM/OTGdw5BKSIB74IzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OsRmeonhBRsTzr/ndz1lxvEmvcIjQIblEBSSAV+qJQ=; b=H/+BzYGQyJBpRTkddsQ7Le2xgcpf9Fj4QhoI4ex93pTNEYhTBcFk6kmQQ6yxRPFgqGOxYNv8mi+u6M0gUlnmhtuH9euoloyQl0abjiHczMfyjUHM0H/jF5I+CnQQwYax2RDjSTt38Yss+FydQht5ubZxBgUAKulhBgPzIvVUQHK9Qg7Pb/W5u/7bQJlorxJNVk5JeadsS6+zozmbcyRX3wvRiKZ486kFodccav4Yw2ttm+hHFutDjkLnwSa7vwqqCwkbnEnIqn+WpfMapbe++RlGcrEl5wEkgUsJlhqyUqPlI9MNcD/AjKq2EIQhdmQIiGbpwf80jAlutKtNgGrExA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:53:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 5/9] x86emul: re-use new stub_exn field in state structure Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8126:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c8fae01-9a9b-4b73-bf58-08db351c4dbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0fcJcWaMjcAJuGfgmgwQCc8hYlnF/F4r4Krnj/w3y+AQyAHYAzKXvpwvAqS47/6wpmlbaW3FXi9nhrmLQcDntR/h7pU5gH8270T6ZypJFpVzKPzYLPwteLvUdG8yMI7frfBNb4tRHjWcUII0D5y/tlchRCpZ3nSboG2DmlxwY4h8v691qjYsly8mLFswK++ToFmyaFICWPYHzkWDXDUt6/LE/NWbaUzNegvaR7ozQEdiBY2cD8XAMDCGaX7PxwSo/z6FpN3U7GPTEUMFGVouOLEG1LYKy9F9WeEua2lrsiEWlSoDc+hNlaepTceJ+GqWfLQFnPw4YTcPZaBSezePYecgrDtz4JjMbOmos2aVEa+12Tlpzg3iSzA07WgbpwhV5//Kwq53FNJHweb6tOFfaLCTmypcOLKXr+Nr4+fqDRZyG+4/kAwGzX6k8VBGQ1JKjdSkqVJAXH1oCgv+9pE1YoM1JOOldi3JOSiZFl4gCl1TOi7RZip01OBxZCq94AUE5gGyDd26xeOcY6NIix9jsq4i+Ikrs+LZFZLsMO3IqEfRMF1H8OjrPQlwEiv7pPieVgPnaGcvNapUJBkpc4J2sZi5c+UA+Aa0CBWTKb33E4LzGHE7/GHvLpM6mV4Lw1i2iQbt55W/rinGAkgsuIqpgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(66556008)(41300700001)(8676002)(4326008)(6916009)(66476007)(66946007)(316002)(5660300002)(8936002)(31686004)(54906003)(478600001)(6486002)(26005)(6512007)(6506007)(2616005)(186003)(31696002)(86362001)(38100700002)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enJXZmhQZ2ZaTmZXYVI3V2VUQmNLaG9MQ2EzREdaRlZCbVQ1T09yWk1PZ3Rj?= =?utf-8?B?c2ZweHA5b1RWYnNzUFdQK2JEclMvTTlwaU9JT0J0K3d4MW03K0pGVktHZjZS?= =?utf-8?B?cm1QQ1JmTnd0Sk9heHhkbVgvczdVR1owemhZSUNXeVQrT0ljMDd1bS9ZSEJX?= =?utf-8?B?d29FVFM3OHpZZjJkRko3NEI3UDh0dUpIU0ZvSUpEYzRKTDdpejZhNXR2cEla?= =?utf-8?B?WURTN2RpcDR5UWlFTFVhelF5dldGZTg1Q0hqSHNWNmtzWld5SVpseUtWWVVW?= =?utf-8?B?TlJVNFdGTENadUNZSWtOdkpsNnBuRmhuQW1FQU45a3RPbnZhL1dOZU9BdGV0?= =?utf-8?B?V2F5Z2g4T0oxMStGRTdrcStKUm5JcFdRM0FCNmJTSURTZHJZbEh1REJKaHhj?= =?utf-8?B?Z0lMUkZjZnM4Z0xNWTJOU2dSejZDbW43VGw5bmE4OTNQeWV3bytMRDFGY1pT?= =?utf-8?B?TzlYZjlUMEMyblhBTk4wdlFPSHBWZXcxbE9BLy8vZVR3Qkw5TVV1V0hDZXoz?= =?utf-8?B?N05OOFk4MUlGYTFDZXpZRXZMVUhxWlpJOUo5a2JOVXI5dU1iUUY4U0tSdmJk?= =?utf-8?B?NmppV3pIejAwWURwSW1QbzgzSlJGeTY5aWw2cUxYZm90TUNSTW5qTVZKQmQ2?= =?utf-8?B?MkRmUHZzb0Fnem8zUXM5MHRIV3dXQmpucFFMc3oxeW5zNEFma0czL25XRUpQ?= =?utf-8?B?Q2ZiY2d4K1JvNnJiNkJ4Kzkrb0dpcUJyc0VNaGdVY3RSeUIvTjdsQ0RpeDZp?= =?utf-8?B?RlpSVFBPQlhaYVQyMi9qVWFsZ0NxNXQ0N0tpMkJqMldDdHQ5dTl0LzVxZy90?= =?utf-8?B?bVpCTTF5b3RZR1M5MG1xeXlEVGdGdFE4WFY3RWdVdW9RYTdrYk0zWTY5OGgx?= =?utf-8?B?RUFqeUZXVGFlM2JHNGxOdDBtZUJTcUI4bWtkYjBLQ21hY3lXYnU0dkFjQkxI?= =?utf-8?B?OHhTdGE3UVp5b1lqRXc1WmIrOCtyUk41a2Rpb0JOekhZMk5JaFp4NDVzbWlY?= =?utf-8?B?S1ViZzZEY2REcjMvRmRSbWgwQWl4MlhkMzBDay9kbDhBL0RkYk0xMnhDNkFN?= =?utf-8?B?VFVIRU1XdTRZNWJNSzJLL0tUQXRESUxjUTFtQ1ZmZHBFTlpRQ2l3K1dkemE5?= =?utf-8?B?cnpoMmQxQXdHQnBoa1V6b2U1QnQ5U0xRYktEMlFHR0V0UjNEQm1jSVRCQStH?= =?utf-8?B?eUFvYk44T1VWbEZFUDNBTkVCd2dOdEpRUVYzZm15QW4xbnlRWkYyWFZpbFBq?= =?utf-8?B?cWhGR3NvYVE3elVkZndrZ3hYK3dPZjlkM1lkL215NFZGb28yZ1dhcHVOeGpy?= =?utf-8?B?NnpKOXhEeEdBVmx3eDBrbDhCS1hRY3FFUWJpby85ckhseWx4S1JseGFROUVD?= =?utf-8?B?TTFvN3ZsU2g5a3hicmVKWnNjVmJqaUQvaWR3OFQ4MXRpU3dLczNOZkkreVBq?= =?utf-8?B?TjBaRjZpREcySFU0aG9RR2ttN2VkM05tbHBRdERvckZqelF4QW5jSkZLV2lx?= =?utf-8?B?bHBxTlcyY1NUSG5FbTNNTTA2c0dydHRYaVlpdFlIQlJ0cGR6SHNzZi9Eekov?= =?utf-8?B?ZkdobURTMFRxc1h3Rzc1TmFtWDVVa0E0N25hQmFva0wwa0ZYT0tjd3BhaXFr?= =?utf-8?B?OWFVWGJyTm9ERitjbDFRU1NFcjlaWXk0ck5oZ2pFdUUydURpTDhOeDBoaE9V?= =?utf-8?B?cWJRN3hRK2RqSmQxVEpLdndEZENVMzMwZXZleE1JdkF1Z2J6NlZtYkg1OGRt?= =?utf-8?B?d0pOOUlrSENUc0Y0T2hzMlcxZldHdE9IbDdwK29aQUQ0Z25CMEgweXFHQmNk?= =?utf-8?B?TXg0VUJWL3c4WFR4WVMwSDBaYW5VeUxoak85YzV5b21PY2JnaFVmVHA0SCsy?= =?utf-8?B?Yys2V0NMV1BBNHJIOVZqZ2lFRk42cWtQSUVPU1Frb2E1K1JCMm02Mi9VWmRW?= =?utf-8?B?UFdIeUJCZFRMQmVNdldLSTk5U1o5R1VXd3pMQzMrZm9MYWdrdWRXZ003L3dR?= =?utf-8?B?ZTljM05rNG5uenV5eVFzVkxzNmFSZnNmbHpqKzVtcGR0L1RsYTRiRkhFRnd4?= =?utf-8?B?RStIdm4zK000WnVGQzFXa3QwaC85S2ZkNFZ4UW9qLzBKNWFyVXRCTVBsQjBq?= =?utf-8?Q?ktn84LU4ppiEZIbwUArGrqL5a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c8fae01-9a9b-4b73-bf58-08db351c4dbf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:53:08.4398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gIV3jWri0WyKkPAbshbCihh7ZvMOOVJfD0Xqe9/yRCL3UUDycjWRE2eBLdrpV+NiwvSt9MsGBr4LTYQGzd0eWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8126 This can now also be used to reduce the number of parameters x86emul_fpu() needs to take. Signed-off-by: Jan Beulich --- We could of course set the struct field once early in x86_emulate(), but for now I think we're better off leaving it as NULL where not actually needed. --- a/xen/arch/x86/x86_emulate/fpu.c +++ b/xen/arch/x86/x86_emulate/fpu.c @@ -90,9 +90,8 @@ int x86emul_fpu(struct x86_emulate_state unsigned int *insn_bytes, enum x86_emulate_fpu_type *fpu_type, #define fpu_type (*fpu_type) /* for get_fpu() */ - struct stub_exn *stub_exn, -#define stub_exn (*stub_exn) /* for invoke_stub() */ mmval_t *mmvalp) +#define stub_exn (*s->stub_exn) /* for invoke_stub() */ { uint8_t b; int rc; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -764,7 +764,6 @@ int x86emul_fpu(struct x86_emulate_state const struct x86_emulate_ops *ops, unsigned int *insn_bytes, enum x86_emulate_fpu_type *fpu_type, - struct stub_exn *stub_exn, mmval_t *mmvalp); int x86emul_0f01(struct x86_emulate_state *s, struct cpu_user_regs *regs, --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2058,8 +2058,9 @@ x86_emulate( #ifndef X86EMUL_NO_FPU case 0x9b: /* wait/fwait */ case 0xd8 ... 0xdf: /* FPU */ + state->stub_exn = &stub_exn; rc = x86emul_fpu(state, &_regs, &dst, &src, ctxt, ops, - &insn_bytes, &fpu_type, &stub_exn, mmvalp); + &insn_bytes, &fpu_type, mmvalp); goto dispatch_from_helper; #endif From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:53:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:53:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517924.803930 (Exim 4.92) (envelope-from ) id 1pji2T-00021x-IZ; Tue, 04 Apr 2023 14:53:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517924.803930; Tue, 04 Apr 2023 14:53:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji2T-00021q-Ep; Tue, 04 Apr 2023 14:53:37 +0000 Received: by outflank-mailman (input) for mailman id 517924; Tue, 04 Apr 2023 14:53:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji2S-0001Yx-7x for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:53:36 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0619.outbound.protection.outlook.com [2a01:111:f400:fe02::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78833a08-d2f8-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:53:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8126.eurprd04.prod.outlook.com (2603:10a6:102:1bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:53:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:53:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78833a08-d2f8-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bBoZfzhvl+G8C00sLGUlmDgErx4+maPHAcSWakkZ5tBvwz/EUag5Bz/YX2NJerTBrblty7kAcO+wGWK8dgXvH1eL3Td21xsL01caoHSsbvaOatpfkwCqzvT32c+gSNhNpyXAM0wk2Xow//1WWV/NhKdLSM668niB13IuAgpHHFsl3EHesX7gL+VFbMSGhqY/pJEppHVyiotmispZqXWvBPnDc9SuIdzw5gCPaHoa9mfJelLuMeStwNGsWZMs4j5d4wIeAEHEEUTRbJEAhH5Aow/AC2di1Inb5D9E59ZIP7YInCVVymoDQj5acHkz/GRfj+K/Yl3BlSne0eh6xj6vWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uuO8e/fNBYfvRmo/WVweSQll7opiYTXixAvlnnhA5lc=; b=Sb41/HGtjtrtam1xw3R49Yp/5HL93DS5nqthIHfWW2+zl9VPVPh+L5hY7samnFQWrW9qYw04k7h4ShM/JnqwRb3kkL6AHXo81o8hMHJVMxqPERRNf+elI6YLtEdLwfZ/7f5yOOQWFkwZ//c+azP+Tz4kLZM0NJfbX3naquaBS12jJiBzTC/Su6J7TE4FEEYxeX0NKvkMWKnNhheg4LGTrNsPzwzFRKLKqnFvSNiEjT5uQ39wWK6rHtfftKpftJvFzAzPmucivPDc6wrqajQfbFB7Q+AFBFIQfya5xdnXneQwo8sOHUe24zD6/qVZ1f2X3GR/cu0kemq2W7WjE5MaBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uuO8e/fNBYfvRmo/WVweSQll7opiYTXixAvlnnhA5lc=; b=p/CCwAKTuvzf8J5fl1KK68jMW1UeQfljCloVXPCWm0Wv9eJqJSDjQQhGElngAuDuVbE3t7aYWkeATnJEE17WIwhrR0Wx6hwhku78PU6ntzww8Fuoxfz1L/1W8xU2LtF4Gn3oxk0MiP0yOgZ7IX291y1Gf0YmebyrFsDlqregalIr/rkf7s86xccfUMWWuiDhDs5LCWjiNaWP3yUO7w6CUniACr6TenxtfirHjHu8SAmBqFGEhCF9lnF3NcCmq5WcP4i990o1qCAbbsArSjbSNg9h452zc/9Fiz3LdVsJIWTJX019JZlrD3MTmbZ4ymWdqPw2OOfHSBD9fJ7O1mqztA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:53:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 6/9] x86emul: support AVX-IFMA insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8126:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e77b752-406a-4250-39ee-08db351c5c2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C2D30WIKNGZhVtk4eZwoxkSPbGLZHVP/zQHR6w6G4ILCiecx0RYX5Wzc+7PheyAKD31MjFvcuFaBxUbyXJ5Jl8zbtAzfsAk6vN10CgOTpw5M/GJXifYUZXvvODp8P5HjJJYDQl/O0j6gh13s8M++4237nim7QrextKN21ABj6jg6DIfveyf5CNzZVz+xoYUjzCTHKybqp7uf9chS1cVOLo8CL9V/xRouYgtBFHg4ysmRqpTk6gV1BSoW8wuB9PHFzrgHf+QazklC+CpKv9lwQihfvEcPOLet1edp49B+Xa94V420svh9ToepY6mwsQlKKaMQFFBkTSwlXIKOS6rEy9rJYIznrqWIA01WNqwwEzfOWoGl7CXSPN8r0Sh/mnqGta81NMwosiZw6N7Vl6nO2mmI3QATXfCWvpNMB2gEL9V1yLXmhCNNnSRVuxriOfGREeU3cGJLnOpFQkgJ1XXfNNFzJYoHeZADS4WHdm7E5kDCW3ENxS9soN4x9h3jinzfMTDHpwmg8rZf5+KDt4t42+3EkY8Z8EIP4McHH9aAYsDA+Ib8spujT02hPHnLQ+vS4yrpsEfOze0AI5QzbR7JXP1M6OdMEKOcgXnr1PHZO96Dl3M3bIkVqiLU/jEPtxCfPMVAbMJTp3RU4ygyALmVyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(66556008)(41300700001)(8676002)(4326008)(6916009)(66476007)(66946007)(316002)(5660300002)(8936002)(31686004)(54906003)(478600001)(6486002)(26005)(6512007)(6506007)(2616005)(186003)(83380400001)(31696002)(86362001)(38100700002)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alBRMEtzVUovNHFRdnQ2NU05ZmdlU3RCSFJ0QzMyU1BPbGxtd3grWXp0MFpR?= =?utf-8?B?UUpjU0Y3RXZvaUhTelpxdGV6VjB5ZUx3UnJ0aVNqVUNJUHBiUU5iWTYzTUhj?= =?utf-8?B?cnNNMXI1RlNLbFV5aEMrN1pZMVVnZnRROEpNZUR6QnZ4SWs0YUVqN2tySnlM?= =?utf-8?B?RlI5YTY4SG90QVRtbmg5bTBaNFNGM3U0eEtLbkx4T1R2S2ZTWWRCRkZMOUd3?= =?utf-8?B?bXBsTVVsd3lXM0NwcTJ2S3hYVDRGVmNXaVU0TWowQTZCWHpuMkZUNkd6K1BC?= =?utf-8?B?NjdmU3FmL3dFY3l4dlVQUk9yODgwMzdQenkzSG5hTkQwSTRiMzlMWnoyb252?= =?utf-8?B?UjQrYjQyamVjZjlzQjQ2ck9WalVTcGRMTnI1VysyZkN3eGlsaGFnaU9ua24x?= =?utf-8?B?L3RieC9aN2gyK2JUaDBOZlJqTU9KZFg3aVpTOVI0MGE4c3pIemY4OHVqUld5?= =?utf-8?B?ZWhvVkNtZkJhellrUWcyQ3ltbFlqT1dLNWY0M2ovaEY0Znd3Y3U4U2xKa1Vh?= =?utf-8?B?KzUyK3Bha2N1dTFUd09ZaVdGaUlKZDhyaXBadWRpVFQwazAwd3JVY1V2Q1Vr?= =?utf-8?B?QVRLU0IwVmdIRlJQNGdRM0dRbG9UMG5WTE9KVHVQenRaRjVHU0ZyWW8ybmNE?= =?utf-8?B?Ry9Za0tyNEtJOTg4ZnZaMjkvWGI5RGdabHJ2WDZyZ1lYTmNueVVHc01xdGYr?= =?utf-8?B?V2VZSEdMZkJmZm1ISE9acU8rQ2tlOE5XS3hrcDZ6bk50Si9Ld0NrT0s2bjRz?= =?utf-8?B?aGZTSjMyTExBS0ZwdVV3WHA0R3V3SlFuSkROa3IzOEVrTUE5YU9xR3BxbEdN?= =?utf-8?B?ZVR5SjNTQm45Z0Q5WGt5ajhRUXV6WStiK2tYT09zWUd2bzdqRzYxZGNadXZo?= =?utf-8?B?R2dNOXh1cmwwU24ybThrMjNQMVA4bVdIdlg3bGM5RitVMm44N3FkbmxtWmpS?= =?utf-8?B?TU1aQ2Z6NEVRbDhOdWdsUitrUytTSWtHSE9YNlFEU0JPem1tTFNRdnpXazVC?= =?utf-8?B?OGdCdUhaVlJKNmR4T0gvREk0TUhIMzdKWGFROWNLMk5yYXJ6c2FPSjhCMjN5?= =?utf-8?B?bFJacHRrRTA0OTl2cVc2OWMwSGNuOE9MS0d3ZG5aOEdwUlJzaEkvZ1dvMG0y?= =?utf-8?B?ejQ3VjJoZTZJNjZEVHN6cmJLelRoM2lsVEpGVHVKbXJpbHZ2cmY5ZEFCYmN2?= =?utf-8?B?ODJzcmFXenFnbFVoSVpkSFJiblVvbXllVUk1M3ducHpDcHJEeDVXLy9zZTV3?= =?utf-8?B?OGxGSkVNVHFxZkNvYU1CWEd5RWhHKzVlTWFwdUl2dTZUZENMUWNoUFc1SkVC?= =?utf-8?B?R1pwVEFlamFVLzRYaXZ4cTZvRDFHTEppTVRJL3c5MU9HVm1iNUV5L3RMZHVV?= =?utf-8?B?ZWREYVZybUhFZ0xTT0tQNE1uVjdlSDZDMWhVZTJsWnU4MUZvc1RLUTRWUzhl?= =?utf-8?B?Nk95T2t6c2Z2U3NvUWRpeVkrcWpzYTUyT2xIMW5wbXVLVnoyZTFlVGlLNFV0?= =?utf-8?B?Y1RJcU80OUVKVG5ibFJ1THVIMnVjWEhSSzVJV0hHeTg4eUpqQSt1cHdCMGdY?= =?utf-8?B?OXA5Q1lndG9RTk45Ym5yN2tnVEVxamtkQmZXTk5xSmMvbmZqNGJ2Zk4zVEpC?= =?utf-8?B?ZjdVVkhmN2RmeFl6QVp1SnF3bGl5a2JMZGtsVk5MRzE2ZUlOeVhJTXpxblBH?= =?utf-8?B?NUVhTnBMUWxIZFQ1d3c4c1NuOEtDam01VE4yRlhQRUxubWgvVmFTaXdRZ2RD?= =?utf-8?B?dFdiMUcrNkc1aHlhd3NIN3E1WlpTOG8zcXlqWld3SGY1MUhOeEwyMmJkS2hp?= =?utf-8?B?dUJoQ2NXaE5uOERFenFxMmV3M21FZFUrNEJFZGd6UCs1ZUhRQ0hTdlpnY1FR?= =?utf-8?B?M2k1eFhZOEVUanpEcmM2c29kR1ZVYllQYWt3LzFXSDlOamtqVlVtUmhwNThL?= =?utf-8?B?Rk9FY0RlaDZ6WHlDbE9BeThCc3lLQ21PQWJsNzFSYUlLazRmK3ExRFBvL0Q5?= =?utf-8?B?YktVb0oyQlh6Q1o3QUQ3QUhlNlJpOGhCNHdzZ29ZSnBOVHBlK3BMNjBHRnVU?= =?utf-8?B?WWozeC90WU1SZ2Nld1g1SEFIMmhkVFdBeVR0M1VZeC91Szh1NDJxZnF3a1l2?= =?utf-8?Q?r5ePGJoN/z/6395lFf6YcvC0x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e77b752-406a-4250-39ee-08db351c5c2a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:53:32.6198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f4lbY4WiC4GDnqnPoFsiLGe0fYWtTnDfGPyf6ObN16f2Tzx24/C3h2YGrtgCCR34eDSMeuR03e7YTDdngOHv8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8126 As in a few cases before (in particular: AVX512_IFMA), since the insns here and in particular their memory access patterns follow the usual scheme, I didn't think it was necessary to add a contrived test specifically for them. Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -239,6 +239,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"fred", 0x00000007, 1, CPUID_REG_EAX, 17, 1}, {"lkgs", 0x00000007, 1, CPUID_REG_EAX, 18, 1}, {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, + {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, {"cet-sss", 0x00000007, 1, CPUID_REG_EDX, 18, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -193,6 +193,8 @@ static const char *const str_7a1[32] = /* 16 */ [17] = "fred", [18] = "lkgs", [19] = "wrmsrns", + + /* 22 */ [23] = "avx-ifma", }; static const char *const str_e21a[32] = --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1372,6 +1372,8 @@ static const struct vex { { { 0xad }, 2, T, R, pfx_66, Wn, LIG }, /* vnmadd213s{s,d} */ { { 0xae }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub213p{s,d} */ { { 0xaf }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub213s{s,d} */ + { { 0xb4 }, 2, T, R, pfx_66, W1, Ln }, /* vpmadd52luq */ + { { 0xb5 }, 2, T, R, pfx_66, W1, Ln }, /* vpmadd52huq */ { { 0xb6 }, 2, T, R, pfx_66, Wn, Ln }, /* vmaddsub231p{s,d} */ { { 0xb7 }, 2, T, R, pfx_66, Wn, Ln }, /* vmsubadd231p{s,d} */ { { 0xb8 }, 2, T, R, pfx_66, Wn, Ln }, /* vmadd231p{s,d} */ --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -186,6 +186,7 @@ void wrpkru(unsigned int val); #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) #define cpu_has_cmpccxadd cp.feat.cmpccxadd +#define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) #define cpu_has_xgetbv1 (cpu_has_xsave && cp.xstate.xgetbv1) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -171,6 +171,7 @@ extern struct cpuinfo_x86 boot_cpu_data; #define cpu_has_avx_vnni boot_cpu_has(X86_FEATURE_AVX_VNNI) #define cpu_has_avx512_bf16 boot_cpu_has(X86_FEATURE_AVX512_BF16) #define cpu_has_cmpccxadd boot_cpu_has(X86_FEATURE_CMPCCXADD) +#define cpu_has_avx_ifma boot_cpu_has(X86_FEATURE_AVX_IFMA) /* Synthesized. */ #define cpu_has_arch_perfmon boot_cpu_has(X86_FEATURE_ARCH_PERFMON) --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -599,6 +599,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_cmpccxadd() (ctxt->cpuid->feat.cmpccxadd) #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) +#define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6727,6 +6727,12 @@ x86_emulate( break; } + case X86EMUL_OPC_VEX_66(0x0f38, 0xb4): /* vpmadd52luq [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xb5): /* vpmadd52huq [xy]mm/mem,[xy]mm,[xy]mm */ + host_and_vcpu_must_have(avx_ifma); + generate_exception_if(!vex.w, EXC_UD); + goto simd_0f_ymm; + case X86EMUL_OPC_EVEX_66(0x0f38, 0xb4): /* vpmadd52luq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0xb5): /* vpmadd52huq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512_ifma); --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -285,6 +285,7 @@ XEN_CPUFEATURE(FSRCS, 10*32+12) / XEN_CPUFEATURE(FRED, 10*32+17) /* Flexible Return and Event Delivery */ XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ XEN_CPUFEATURE(WRMSRNS, 10*32+19) /*A WRMSR Non-Serialising */ +XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -254,7 +254,7 @@ def crunch_numbers(state): # feature flags. If want to use AVX512, AVX2 must be supported and # enabled. Certain later extensions, acting on 256-bit vectors of # integers, better depend on AVX2 than AVX. - AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI], + AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA], # AVX512F is taken to mean hardware support for 512bit registers # (which in practice depends on the EVEX prefix to encode) as well From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:54:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:54:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517929.803940 (Exim 4.92) (envelope-from ) id 1pji33-0002ci-R6; Tue, 04 Apr 2023 14:54:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517929.803940; Tue, 04 Apr 2023 14:54:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji33-0002cZ-Ne; Tue, 04 Apr 2023 14:54:13 +0000 Received: by outflank-mailman (input) for mailman id 517929; Tue, 04 Apr 2023 14:54:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji32-0001Yx-68 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:54:12 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20631.outbound.protection.outlook.com [2a01:111:f400:7eaf::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e50941e-d2f8-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:54:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8126.eurprd04.prod.outlook.com (2603:10a6:102:1bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:54:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:54:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e50941e-d2f8-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqMVr+pBuiHEIto5vREmKrSTnfKifscS241O+gZshjQfduCez2NvwjTQPS6brQAbUZEtX+u8a9Dd4tsC8LOjZhpp3Lb+sorgFqcpEe6wcmSIaHQ0o0MXIInM339zIncc8xeFVujdpFPfIsnAuTg5PBvIpUB/EVl1IFKXem185XgxNU+f5cxpho/pIScUgmjtHNb2RhOMoe07MGQ+7cWgnDCJHf2jIyCNVqxlVbOjjM69E1I+MQ3xEUB644TzlqnwtIMX5KXVf7zB1oJRHIDdw5JrZIL48Yc2NfbYm4NgQxcWVuicI8RmNmD/DInwIo+ps2P/ayU8zir1t/rc0NXR/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xgzA2b+QjSJL+b8+vIb+DCUzhUIrjTWFIjzTmH58pdU=; b=S2ePVGxgBeb2+di0/h/ZVhxwElxcKExG+Uq+HqR9pMXds19bBGNKS9VlNUFUGJdyQIbkoSvkyuqLzMrPWSdXzV8WJGu+B0Ox+Xkk631SnfOvdZa76gewsm3W+UBnPMsXjISzMoI7KjmP/yfsFZVs5pIFeYEOymRuDWorlD60nmZGUUvSZMudU6SUR5iWhLu1OhjKcFBOZETVVVdYFThrY3fTSDmJrUCvyggrfWHhLr4853YS1uF67PEvU+DT/sIbqzgvxJ3IjK4a7KaXUxUZyxvvhaJlkP3ArkjwbahuYIW5JlW49hZ0avYP9TQ+v91EwDf2NGzp4rXfv5mWr5D4+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xgzA2b+QjSJL+b8+vIb+DCUzhUIrjTWFIjzTmH58pdU=; b=Avscmj6hi8aM2ZxA2p40X0iBRXVU+5ozJKtMKLfRBszh7FNQbzgAFQs5N0uul6nYsCgHvZPBQQutXZniMa9b8huxeHvVPxZ4BViJK+iO/i3BIgyw5/puFAPfiH4OhKx5pwykcCmoKfY8MLqruVVDIJNPMow/vsGfwi0DAOH7nscJnTmsGDav8Eu59WB3vF5PkYivB5AmXe+hcQ9M53RbJfeOclC6Rl77gPRcMeFbxAD+gq+xQlFXDrjqweiyOfctJ4myZ+GAKDP3MPZ+7do1q0/xZxuNv9oTGVjzGgeI+O6rDt58C22rZvb2xsonLKMVceIUHA6iIwEQulxoOzCH7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:54:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 7/9] x86emul: support AVX-VNNI-INT8 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0195.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8126:EE_ X-MS-Office365-Filtering-Correlation-Id: f819c972-c97e-4025-a410-08db351c71bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DWC1w/V8N+y1potYInB97EcDZQSxNdQ06+hBP5SQ22WoC8xATDtCJ0RaAn3VcdByWa6rmeirEzyx0ZUphZXTcY4LLUkBWJC+ug+ry1KnSMDlzoRR7c98ory61W9ofGyB/rFmDKTLIu79vElBlNkPRAaqaNMdzD5MUZSF6JxquFTqyi9AwdOsT4uFMFp11o2mYYZzJZmPOdnMahq7y82XPqPGfshbLkU5SUYv2WVvVbK4dP1btjmOl06TTGkk94i4HeSntXLYM2oGJdlR3FL2s5Yp6gOKpgVgU6jUkMyh9/YREIg6Xzl8bA3FMuSPBUo86N46tTXBYW42AUweWKZq5g/oSbo3gPn1CeHtFU1takj73cC2yd5BkiCgZvjwlnE1sV5icBShMdZi0PtSuPVd3ZHKCZytgqT+paZ04N7nQRYT481XNgRmMaWtQcBDMEbiBKZxqdnIBMqplWOxBjwoY4bFJrAwJJkappOmbwqRLnWgrmsu/rUOBvy8zNQTrysQor2D0Ho+6uUti8nLLJU16UnsQ911CfoM0Z1eQv0/Uxvto+dL18SQjc3sYp5MHQmVMqkUxMVG+le2Zxiub+tt0awx+apyP6jkzOaCHrAxotL9CQt83yEiEkpKBXMcm19LQmlEuKNeH0TfNt4tUQysYA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(66556008)(41300700001)(8676002)(4326008)(6916009)(66476007)(66946007)(316002)(5660300002)(8936002)(31686004)(54906003)(478600001)(6486002)(26005)(6512007)(6506007)(2616005)(186003)(83380400001)(31696002)(86362001)(38100700002)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3d5TlpxMmpQOCt3a2N4cWdqOU9JYkhaYU1ScDMrbVpCVzJ2WFF4cHFjZHdX?= =?utf-8?B?S0ZpUE5EQm9TQjFFMTBiL29XY2NESlY2dkdaRXYxbjNNaDVEWksxeXV4bFNr?= =?utf-8?B?S003alZDTGlrdUVRS01DbVVXQ1FHa1hZbTEyZWRDWlFSTDMySVlPU2tWeWxC?= =?utf-8?B?YnhmR3h1QmQ5WEZzTlRMZ3pNSUpZQVpxbDVtTzg4SDJFL0U5NnQxWCttQ0pF?= =?utf-8?B?cTA3YjcvQS9ldVBHZEU0UDl6YXoza2ZhM1lxdDJtTkk5OWdIeWpWWExwdHEw?= =?utf-8?B?SkZ5eStRTDNkUUNaZmFNYXBvUU5NMmI0dkpIRWFqUWRyZHBPdysyYS81ZitH?= =?utf-8?B?NVNHN041ZHVUenpyUCtPUzhLbWpycUMxTksvZ3VkZGVXSTR6QUk3WnhZNlVU?= =?utf-8?B?OXFZcWZLZGxsSUxJOVR4czd0bElVNVVGbEhYd04vSkxwM2tKck4xdUI1VzlF?= =?utf-8?B?UHBxVVMwemZBdlV0eEJGUDdJZmw0TGhLOVhjNXBadVp6elN6S0pITWdpbTZP?= =?utf-8?B?dW9RdG5RNGd6UFMrVVhFMWtpQlpoOS9rMHo5NVg3SWdTVHVrOUFtTXI1Ulhy?= =?utf-8?B?ZXRLQm1KVGRJWDJ3L2F2c2tRUDdja0VLTGwzajhUaHFiR3YwejI2QUpReUJS?= =?utf-8?B?alRFdldYSXhNUVMxNzJ0ZWF0ZGxlZkpJTmU5aCtHR2NYTWNWaENkK0lTczlk?= =?utf-8?B?MjhEck5JczFoSnNoRllteld6MXp1S2F4TVNzZUpKdnRvQUxiZ1Voa3RkUkx4?= =?utf-8?B?aXJwVXJNK25IYWY1cVBlVGNhTXk1ZFNCS3lSRGZhTEF5elBTNklWSjJKcW9K?= =?utf-8?B?eDl5dklRUHVHZmpsMHZOMVg0MFdZYmhuaVQ5b25ZWGNxVG5sem5jVC9ud1Ur?= =?utf-8?B?S1UzVGV3bnAvSVlPMmp5bjI0UHNySmxlNU1pSW11UlJ0WDRpbzhwUkdXYzM0?= =?utf-8?B?Z0w3Z1hEdExFajdUMmFldFI3RmdXVGtKRTJYOU54U2RtN2lZSSs0V1orTS9m?= =?utf-8?B?WHZEQVprUEp2dDRWZkNScy9LQ0tXRmRBS20wdHlxcTFNTVJmUUpqK3htazdw?= =?utf-8?B?YlV4RHFLZitBRC9pRlhGT0QxN2xqQmE3MlNKR1lXRTFMdm1jWXpJQkc1aXV5?= =?utf-8?B?QTRqZmtmV2pKR3FFRTdza0cyODJOQlhuMlI3OEpWQ1UwaERwZEVqdFNFbXl6?= =?utf-8?B?M3NpVHVmM1prMThPbVZURkovdEF3SmVGUThKbjZMVDBNb3VNbFFaeU9jYThy?= =?utf-8?B?NXd5YlA4Y2FCNmptMjBIbVl3MXRKekdXZzVtYjBhM3hhOXY5cEhpU0ZLSDRu?= =?utf-8?B?TnFMUWRnUHUxL05hMjBUZFZHWlRSanJOSnlYbHI2ZU5ka0xPcWpkcDVTMW9w?= =?utf-8?B?RnRlMWhvMUlFbEwrZWZpSUpRQmUwQXBLRER4NVFlMENpOGFTZVduOGc5ZmhV?= =?utf-8?B?eG9TOEdveXpnc1JQUHgwQUxqQUNYRU12b0puem5BRWttS2VTc2ExZ0l0ZGFY?= =?utf-8?B?RnM2QWN1ZEx4c0tLWjZPZkxTTG5ka3NnWmRReG1QTzlUMzJVWnRQYkd4aTJw?= =?utf-8?B?ZzR5NHdqbmE3TGJ5RzY3QS9tNDNsTlhLdXRkcSsxUURIZFVxcy9ZUHlLekJZ?= =?utf-8?B?cG1lSEluczBQY3hlR1BCMDFEem0vSmNsekl1V2doNW5tOVZBblVoZ2dPakpB?= =?utf-8?B?Rng5cUxFM21XTTI2bjNRbE5heHM3OXZWcWN0ak1vQmVUTTUzRDcxbnpZd2pu?= =?utf-8?B?TnVZWFRSV3BPeFF2MVk1SDg2V29KQ0QxOWdXZ2FJN2h1WENXTytjSmNkM21l?= =?utf-8?B?dGkvckVuMjFOTGlLMEthL1dTNzl5b3NhM0ZzYmhQakRoTFY1U09NSkxuRHlx?= =?utf-8?B?aHkwNkUwMFVtOGtBbmFvMDVpZWxzZ1lDeWlFaGsvMWwvcnU5bWNiMHVvem9H?= =?utf-8?B?WlpJcWJheXBpYnkvM3g4VUUwWkU1ZnVxbWk2L3dzTGphMmtjZ2FUMW9XRlli?= =?utf-8?B?YmZXZ2YybVd3WVR2Q3hZS3NmeXNHU01OZExwNFFZM3NXMmh0dG91NzBUcHpN?= =?utf-8?B?YWRraWxkOGFmS3Z4RUdoVCtrNkhYc2g0bFgvaWx2UTZSc053L3JKeTcwUktx?= =?utf-8?Q?D3aLiEKRmXlV3usLQw768beWQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f819c972-c97e-4025-a410-08db351c71bb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:54:08.8178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NxV+/LR6ER9vkq5LIrPPGeHnYL7/9QtLN1mrGYfNQe3N/LfXEc5dxFM0u2XzwYzOTDs+Egtv2rSWOCEoeGyi/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8126 These are close relatives of the AVX-VNNI ISA extension. Since the insns here and in particular their memory access patterns follow the usual scheme (and especially the byte variants of AVX-VNNI), I didn't think it was necessary to add a contrived test specifically for them. While making the addition also re-wire AVX-VNNI's handling to simd_0f_ymm: There's no reason to check the AVX feature alongside the one actually of interest (there are a few features where two checks are actually necessary, e.g. GFNI+AVX, but this isn't the case here). Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -241,6 +241,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, + {"avx-vnni-int8",0x00000007, 1, CPUID_REG_EDX, 4, 1}, {"cet-sss", 0x00000007, 1, CPUID_REG_EDX, 18, 1}, {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -214,6 +214,8 @@ static const char *const str_7c1[32] = static const char *const str_7d1[32] = { + [ 4] = "avx-vnni-int8", + [18] = "cet-sss", }; --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1337,8 +1337,14 @@ static const struct vex { { { 0x45 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsrlv{d,q} */ { { 0x46 }, 2, T, R, pfx_66, W0, Ln }, /* vpsravd */ { { 0x47 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsllv{d,q} */ + { { 0x50 }, 2, T, R, pfx_no, W0, Ln }, /* vpdpbuud */ { { 0x50 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpbusd */ + { { 0x50 }, 2, T, R, pfx_f3, W0, Ln }, /* vpdpbsud */ + { { 0x50 }, 2, T, R, pfx_f2, W0, Ln }, /* vpdpbssd */ + { { 0x51 }, 2, T, R, pfx_no, W0, Ln }, /* vpdpbuuds */ { { 0x51 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpbusds */ + { { 0x51 }, 2, T, R, pfx_f3, W0, Ln }, /* vpdpbsuds */ + { { 0x51 }, 2, T, R, pfx_f2, W0, Ln }, /* vpdpbssds */ { { 0x52 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwssd */ { { 0x53 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwssds */ { { 0x58 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastd */ --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -187,6 +187,7 @@ void wrpkru(unsigned int val); #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) #define cpu_has_cmpccxadd cp.feat.cmpccxadd #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) +#define cpu_has_avx_vnni_int8 (cp.feat.avx_vnni_int8 && xcr0_mask(6)) #define cpu_has_xgetbv1 (cpu_has_xsave && cp.xstate.xgetbv1) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -173,6 +173,9 @@ extern struct cpuinfo_x86 boot_cpu_data; #define cpu_has_cmpccxadd boot_cpu_has(X86_FEATURE_CMPCCXADD) #define cpu_has_avx_ifma boot_cpu_has(X86_FEATURE_AVX_IFMA) +/* CPUID level 0x00000007:1.edx */ +#define cpu_has_avx_vnni_int8 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT8) + /* Synthesized. */ #define cpu_has_arch_perfmon boot_cpu_has(X86_FEATURE_ARCH_PERFMON) #define cpu_has_cpuid_faulting boot_cpu_has(X86_FEATURE_CPUID_FAULTING) --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -600,6 +600,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) +#define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6077,13 +6077,23 @@ x86_emulate( generate_exception_if(vex.l, EXC_UD); goto simd_0f_avx; + case X86EMUL_OPC_VEX (0x0f38, 0x50): /* vpdpbuud [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0x50): /* vpdpbsud [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F2(0x0f38, 0x50): /* vpdpbssd [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX (0x0f38, 0x51): /* vpdpbuuds [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0x51): /* vpdpbsuds [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F2(0x0f38, 0x51): /* vpdpbssds [xy]mm/mem,[xy]mm,[xy]mm */ + host_and_vcpu_must_have(avx_vnni_int8); + generate_exception_if(vex.w, EXC_UD); + goto simd_0f_ymm; + case X86EMUL_OPC_VEX_66(0x0f38, 0x50): /* vpdpbusd [xy]mm/mem,[xy]mm,[xy]mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x51): /* vpdpbusds [xy]mm/mem,[xy]mm,[xy]mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x52): /* vpdpwssd [xy]mm/mem,[xy]mm,[xy]mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x53): /* vpdpwssds [xy]mm/mem,[xy]mm,[xy]mm */ host_and_vcpu_must_have(avx_vnni); generate_exception_if(vex.w, EXC_UD); - goto simd_0f_avx; + goto simd_0f_ymm; case X86EMUL_OPC_EVEX_66(0x0f38, 0x50): /* vpdpbusd [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x51): /* vpdpbusds [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -305,6 +305,7 @@ XEN_CPUFEATURE(MCDT_NO, 13*32 /* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ +XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32+ 4) /*A AVX-VNNI-INT8 Instructions */ XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ #endif /* XEN_CPUFEATURE */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -254,7 +254,7 @@ def crunch_numbers(state): # feature flags. If want to use AVX512, AVX2 must be supported and # enabled. Certain later extensions, acting on 256-bit vectors of # integers, better depend on AVX2 than AVX. - AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA], + AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA, AVX_VNNI_INT8], # AVX512F is taken to mean hardware support for 512bit registers # (which in practice depends on the EVEX prefix to encode) as well From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:54:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:54:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517933.803949 (Exim 4.92) (envelope-from ) id 1pji3U-00039F-7t; Tue, 04 Apr 2023 14:54:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517933.803949; Tue, 04 Apr 2023 14:54:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji3U-000398-4w; Tue, 04 Apr 2023 14:54:40 +0000 Received: by outflank-mailman (input) for mailman id 517933; Tue, 04 Apr 2023 14:54:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji3S-00038P-5s for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:54:38 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20611.outbound.protection.outlook.com [2a01:111:f400:fe16::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d9240a4-d2f8-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 16:54:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8126.eurprd04.prod.outlook.com (2603:10a6:102:1bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:54:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:54:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d9240a4-d2f8-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nFr790ZrZjSmlZcs33yWrti5tqAz3kertLXPude8W632EOZfuYr6BjHFMwk0Yx+uKoUfp8NDTN94xIn9l/k4noHgzuFV6yB2C+WEblF+NdU4D8HOUjGjCWqzWNNxR+8AV0hg6F5ESYGoYxOwEEbzhVFrGYE1FsOszk/Vh9o/BvxR/LMuwydz+PGQmxhK2t5eC8p3tUPnKgP4yhLQd3Wc6iEMYTMG147hFSTnL6FRJVDoFMzUxGt0wi4kH0Ot0QWzwH+7mz9aN5e3bcXdahpVZiBawcjzVNBlMg2UfMHUTvSzVSON4On3519EH8mUuhAGz3dRDgGhOhkHPnld19iNxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N2VXtzSxt2N0XZD5RA5H5Y/sAIhPik9M4K9Pvxm3mDQ=; b=hz0hOfiGsgL4cWDcAocxbO32yQchhO5NzEnF+i0auW796NMe2I6mUN4o9CpF4EtdZF4qWGZuI5euzNER+XTCJNStbyvNcvNHYjKyL89zPLau85O0qKX2JABTc9mpfCSPAuNEGczunT3aYSR7o/8gxgODE/WQ97RhGnun5fhCOgYBMyp4rhb0+o1SQcs064HTc0UDnjhhFMjwMsliFnrCQEAO0XQyCWXeriU6HK2EQuvSeKZDnpEeA+UuA2OAeDvmZweGKfPGXV5B5GefdOtu+pb1XqXJYsP8z2ozbQzajldBcIs6/kGuvx+OW0hq9TrNQ7mQANgdALM/bjMDwYYBjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N2VXtzSxt2N0XZD5RA5H5Y/sAIhPik9M4K9Pvxm3mDQ=; b=S3KwFP555vTnXB5z6xy6NcVsc1EDXocbxy2qvpsJYQwzkFiNl/C64f6ntoqfGNvOD3Lh5/8nQzs5X3INV+4sYJ4I0270blANQiEnY/Zgs/4NQ+6qUz++k5ycV3ng0wVbB9gRGAk0jIDIzN/+1nR/ClRcrg3ot8UPR4pNdxAeayomC6WLkt/ICRAmlNDjI3NCVlb9OM8FBIVqOlYwpmduZzVfKytkgfhz5x9ivQqHC/RPR06JMAVS9XT0vXoU4jeF/84y2d029uDhjXipMTrTeXGpjNob4MgNqByRqkP9J/eHutqi4jCb9EMHGXya1RHtTLMFlzDLVlcDP9HG3TDyfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:54:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 8/9] x86emul: support AVX-NE-CONVERT insns Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0181.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8126:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c23632b-f94e-40cf-9c58-08db351c80e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Neg8WMJaYIe6XSbITpCdr26RGqwTgvbcrYG1SCrolWeVvjRjgMFG+SH/yvxqaU30ceQedhzV7zayjOowVLRkwZJUGFQyXEU3u32VckP/qJqSPzGvj26D5R4iezyXlWum/klJDnS6w/Hf3mfROqVVvHNOyRNPpRoYcMDDUJNrPiM6EQ6wmC9zm32pYejjJiPr9nSNyQh8Mh5TnKMhMZNYBm/0AYYfy2hqpTrpN6MKhPeODmGMv7r/jQA/+0YQkkNZmFqkGUHzMEFH+zCiBhp+47FVCNzlcy1UvtbHRxiaDqcsuTkQblCtAheL6Qbeq7qgyr2B9BbJtntk5w7f5Ca8wgCZwZPpLwCRTpc5TWSmbK9cXKuTWYgJ+3KROCfHQto8FmkZwUKp0AOPmOD8q/XasRfm101TqyMFT2aw77uCo7uQkesFGpRH+m4xXyPvkw0ABDhXhO/pEs46uY4lkH9wt6WjzyJfu6n3sLscm7f1mqISqPP16hhPH/f3kiz7eJoBHhjnUHJNvO1qfBVKscs6j0RKLVAwLv0bNGcL5b0ooDSGKZ9uE6MeXSvXtnGQOT3F6kVDkZlm19YTwsuF1KS+siHFEPLAlSVj+IAcUAv0SNiDu2OpBM8nDCvte68LOTl45931sIkP+g6oyHe/6m9NOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(66556008)(41300700001)(8676002)(4326008)(6916009)(66476007)(66946007)(316002)(5660300002)(8936002)(31686004)(54906003)(478600001)(6486002)(26005)(6512007)(6506007)(2616005)(186003)(83380400001)(31696002)(86362001)(38100700002)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUpoMlRCSnRQSHdRU2xNRmtsemd0QUNjTE1PNERmaGZ1c05aV21EYUI4S2hE?= =?utf-8?B?bktQOEJFdno4MUFaV01UNHFuLzI0S0JkbnUwNkE4ZGs1MUZ4MnFHa3pJZDE4?= =?utf-8?B?VE1KOXpoSWxldDZicXRTUmswa09kMVRkY01PK2Y4akNhcFJidE5PaFJrdVU5?= =?utf-8?B?MTRQU3E2MXl3RHVFdTJ5anJSWUJnWXU4dXRhTS9VVUFoV243WGlweEJyNEVX?= =?utf-8?B?UkdGa2kxRTU2V0xhZ2ZDVVFtbmtUZERPM1M3akR0dm1neWlYSGc4Mjd1cHI2?= =?utf-8?B?cWFURWEzeEg3R0FhMEFtVm5PT0czWXlzMWFGUUI4ajNhRHk3N2R5RkxydkdI?= =?utf-8?B?Nk0rMTdHWE0rTnVuczVyMVlQWTkvTlF0NmFSS0JhRGxtd2xzUWJ6RmMyeWRZ?= =?utf-8?B?eTFucFNXeHZGY3l1UjJ3UVNGc1c4SmFWSUswNi9RamxWc29yNi9iamlDMU4v?= =?utf-8?B?RGlrT0htWXdWTkpaR1MydFhQODMyT29zQWNNaTF6MGswZ0xDTEErREdwRWFR?= =?utf-8?B?N3JDVG44enJudUJmTE93U3Y0K2d2RlMrOUVGbnBUOFp1S0JFcTJ6RTAxUmVO?= =?utf-8?B?aVB3T1pFcHBPR3IyMnhmK1FYaVA0dklITXJMMlNhdmhMdlFLblRzbTFYUXhh?= =?utf-8?B?bWZYMThseEVIL2hoUjRoaDdvU2d2NjFDSUhlVkpzY284SGliV3RRcFV0Qnc0?= =?utf-8?B?eHB4ZUtSZ1BZWTU2U2Y5cFhWalFsVHpIS0VKNTFYVnhoTnUvVjF6aDBOK0Yz?= =?utf-8?B?bU1KNkNIU2RMU2JPWlpwY0hKQ0liT2lURnp5azdzUWQ4SHcxWXB3OVlOYmQ3?= =?utf-8?B?Z1BrdVkrRThWL29CMm9jdnBqdzRTQnpuU1N6MXdjeDZ4TmNWbEhSMGRrYzU4?= =?utf-8?B?YXBTVWFFMzV5RFN0eHNhR2RTOEJ5dk1uKzZveDBBNGEwOTlGUU1LWmtkOWJN?= =?utf-8?B?SHJxYXpkcWJLSGZuUE5pdTlTMytZalQwT2ZHN1NKMlNwZEVaMVJsMzUyZE5Q?= =?utf-8?B?Qy9WRWNjRlA4NXBtd2NXSU83RkRialJQYVlOdE43bmpYTk9UMFVJc0l2TXIz?= =?utf-8?B?eTNHelpCdEpRVUwyRzlqQkt1SG9LOTFoNEJVYXlhWW12TlY5K3NUMU9MK2pL?= =?utf-8?B?eVY3KzhFS0ZoMWFzZmE2cmU2UjRhNFZLTjd5cWVzRVdnQXAvR1dZSjV1SCtH?= =?utf-8?B?cVZ6ZlhUY1laaFFERUFVN25lSXY0OVd4TGs0d1ZtUHViWkJhclhhODVzUjRQ?= =?utf-8?B?eGRDUDB2TVNaU2xITE81TkNUVVprc0Jzd3ZYdzUzbjZWQ2drTWpKeWhwZ2ZQ?= =?utf-8?B?MkhGMVN3dC9SRWhGeFNUa2wvZFNUUXQ2SDZ3aFBBMk4xRmVwV0xheTBzc21y?= =?utf-8?B?dm1XNVhzMDdycWNqZ3FoUyt1bE9tbmpMNkNiaFdNNjN2V2IrYTlXcnVKQzB3?= =?utf-8?B?T2N1cDVjNGFyeUtaQ2ZEOVAxWTFkYTJmQjlXL0Y5WVNNUDR0RDdNbUdHNkpi?= =?utf-8?B?ZWprT0oydVorczU5Y3dvL2hCOVRabE1CM0MzcVZhN1VNcjM5Y2JDYnVlUkFV?= =?utf-8?B?ajRpZHpFZEh0cWg5QmNEaVdjNFZ3OTZ6bnhJUTdGalZvNC8xMlJXSkpteGw0?= =?utf-8?B?alA2c1BqOFNjdVdSeFd3LzRyZEtILytQSnVLRUYzMXBUY3Q3eFZGRlJjbXZU?= =?utf-8?B?WWtkRnNDVjdlVWtlSlpEY1VlM0o3SndNb1d4LzllMUtzTmQzTmhCTE1ZZ0Ft?= =?utf-8?B?TTJPV0MrZUhEa3hCSXdnd0pKWS9CNFgzWExTQjNrVnNQU1Z1SVdjWEtOdEpV?= =?utf-8?B?SDg1bDNZS3FXQTJWWU80eFg0aE95SEVXb3BhLzIvZ3pHRXJHaElIVEFPWm4z?= =?utf-8?B?V0hHdE9FZ3FwNzlRVXY0S3k2dXYyZk9vRTJNam5Ick84TzVtZ1NDNEdxYkRp?= =?utf-8?B?UmNpSGprdmdNdnoxclhQckxnL2szUWNudDIwTnpEZEU1OU9xQlBVdHV2UjNj?= =?utf-8?B?N1N3OHlPVlBVS1pFZk95WHo1aXArZ01BYjFRSEJsWkxnL1grdmxQR1NNb0k1?= =?utf-8?B?ejhBcHVDK2JuM1R1bWMvbHNTbTloNXlDRjdCeXhuckpTOFRoOVBpS09lNHNk?= =?utf-8?Q?4wCrIWJhID1vw+FNfN5thOAVo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c23632b-f94e-40cf-9c58-08db351c80e9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:54:34.2795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QIDfAINVTb+W4Toch1pGOexXH3FU6pwNkV3bLehq/gyW/Paa7fj6kLHUpLzHow3/86DeZLgFEBuDxS2aaVG0zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8126 Matching what was done earlier, explicit tests are added only for irregular insn / memory access patterns. Signed-off-by: Jan Beulich --- SDE: -grr or -srf --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -242,6 +242,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, {"avx-vnni-int8",0x00000007, 1, CPUID_REG_EDX, 4, 1}, + {"avx-ne-convert",0x00000007, 1, CPUID_REG_EDX, 5, 1}, {"cet-sss", 0x00000007, 1, CPUID_REG_EDX, 18, 1}, {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -214,7 +214,7 @@ static const char *const str_7c1[32] = static const char *const str_7d1[32] = { - [ 4] = "avx-vnni-int8", + [ 4] = "avx-vnni-int8", [ 5] = "avx-ne-convert", [18] = "cet-sss", }; --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1350,6 +1350,7 @@ static const struct vex { { { 0x58 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastd */ { { 0x59 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastq */ { { 0x5a }, 2, F, R, pfx_66, W0, L1 }, /* vbroadcasti128 */ + { { 0x72 }, 2, T, R, pfx_f3, W0, Ln }, /* vcvtneps2bf16 */ { { 0x78 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastb */ { { 0x79 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastw */ { { 0x8c }, 2, F, R, pfx_66, Wn, Ln }, /* vpmaskmov{d,q} */ @@ -1378,6 +1379,12 @@ static const struct vex { { { 0xad }, 2, T, R, pfx_66, Wn, LIG }, /* vnmadd213s{s,d} */ { { 0xae }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub213p{s,d} */ { { 0xaf }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub213s{s,d} */ + { { 0xb0 }, 2, F, R, pfx_no, W0, Ln }, /* vcvtneoph2ps */ + { { 0xb0 }, 2, F, R, pfx_66, W0, Ln }, /* vcvtneeph2ps */ + { { 0xb0 }, 2, F, R, pfx_f3, W0, Ln }, /* vcvtneebf162ps */ + { { 0xb0 }, 2, F, R, pfx_f2, W0, Ln }, /* vcvtneobf162ps */ + { { 0xb1 }, 2, F, R, pfx_66, W0, Ln }, /* vbcstnesh2ps */ + { { 0xb1 }, 2, F, R, pfx_f3, W0, Ln }, /* vbcstnebf162ps */ { { 0xb4 }, 2, T, R, pfx_66, W1, Ln }, /* vpmadd52luq */ { { 0xb5 }, 2, T, R, pfx_66, W1, Ln }, /* vpmadd52huq */ { { 0xb6 }, 2, T, R, pfx_66, Wn, Ln }, /* vmaddsub231p{s,d} */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -4572,6 +4572,39 @@ int main(int argc, char **argv) else printf("skipped\n"); + printf("%-40s", "Testing vbcstnebf162ps 2(%ecx),%ymm3..."); + if ( stack_exec && cpu_has_avx_ne_convert ) + { + decl_insn(vbcstnebf162ps); + + asm volatile ( /* vbcstnebf162ps 2(%0), %%ymm3 */ + put_insn(vbcstnebf162ps, + ".byte 0xc4, 0xe2, 0x7e, 0xb1, 0x59, 0x02 ") + :: "c" (NULL) ); + + res[0] = 0x43210000; + regs.ecx = (unsigned long)res; + set_insn(vbcstnebf162ps); + bytes_read = 0; + rc = x86_emulate(&ctxt, &emulops); + if ( rc != X86EMUL_OKAY || !check_eip(vbcstnebf162ps) || + bytes_read != 2 ) + goto fail; + + asm volatile ( "vbroadcastss %1, %%ymm2;" + "vsubps %%ymm3, %%ymm2, %%ymm1;" + "vptest %%ymm1, %%ymm1;" + "setc %b0; setz %h0" + : "=&Q" (rc) + : "m" (res[0]) ); + if ( (rc & 0xffff) != 0x0101 ) + goto fail; + + printf("okay\n"); + } + else + printf("skipped\n"); + printf("%-40s", "Testing stmxcsr (%edx)..."); if ( cpu_has_sse ) { --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -188,6 +188,7 @@ void wrpkru(unsigned int val); #define cpu_has_cmpccxadd cp.feat.cmpccxadd #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) #define cpu_has_avx_vnni_int8 (cp.feat.avx_vnni_int8 && xcr0_mask(6)) +#define cpu_has_avx_ne_convert (cp.feat.avx_ne_convert && xcr0_mask(6)) #define cpu_has_xgetbv1 (cpu_has_xsave && cp.xstate.xgetbv1) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -175,6 +175,7 @@ extern struct cpuinfo_x86 boot_cpu_data; /* CPUID level 0x00000007:1.edx */ #define cpu_has_avx_vnni_int8 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT8) +#define cpu_has_avx_ne_convert boot_cpu_has(X86_FEATURE_AVX_NE_CONVERT) /* Synthesized. */ #define cpu_has_arch_perfmon boot_cpu_has(X86_FEATURE_ARCH_PERFMON) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -423,6 +423,8 @@ static const struct ext0f38_table { [0xad] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0xae] = { .simd_size = simd_packed_fp, .d8s = d8s_vl }, [0xaf] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, + [0xb0] = { .simd_size = simd_other, .two_op = 1 }, + [0xb1] = { .simd_size = simd_other, .two_op = 1 }, [0xb4 ... 0xb5] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0xb6 ... 0xb8] = { .simd_size = simd_packed_fp, .d8s = d8s_vl }, [0xb9] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -601,6 +601,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) +#define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6208,6 +6208,19 @@ x86_emulate( host_and_vcpu_must_have(avx512_vbmi2); goto avx512f_no_sae; + case X86EMUL_OPC_VEX (0x0f38, 0xb0): /* vcvtneoph2ps mem,[xy]mm */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xb0): /* vcvtneeph2ps mem,[xy]mm */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0xb0): /* vcvtneebf162ps mem,[xy]mm */ + case X86EMUL_OPC_VEX_F2(0x0f38, 0xb0): /* vcvtneobf162ps mem,[xy]mm */ + generate_exception_if(ea.type != OP_MEM, EXC_UD); + /* fall through */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0x72): /* vcvtneps2bf16 [xy]mm/mem,xmm */ + host_and_vcpu_must_have(avx_ne_convert); + generate_exception_if(vex.w, EXC_UD); + d |= TwoOp; + op_bytes = 16 << vex.l; + goto simd_0f_ymm; + case X86EMUL_OPC_EVEX_66(0x0f38, 0x75): /* vpermi2{b,w} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x7d): /* vpermt2{b,w} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x8d): /* vperm{b,w} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -6737,6 +6750,13 @@ x86_emulate( break; } + case X86EMUL_OPC_VEX_66(0x0f38, 0xb1): /* vbcstnesh2ps mem,[xy]mm */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0xb1): /* vbcstnebf162ps mem,[xy]mm */ + host_and_vcpu_must_have(avx_ne_convert); + generate_exception_if(vex.w || ea.type != OP_MEM, EXC_UD); + op_bytes = 2; + goto simd_0f_ymm; + case X86EMUL_OPC_VEX_66(0x0f38, 0xb4): /* vpmadd52luq [xy]mm/mem,[xy]mm,[xy]mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xb5): /* vpmadd52huq [xy]mm/mem,[xy]mm,[xy]mm */ host_and_vcpu_must_have(avx_ifma); --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -306,6 +306,7 @@ XEN_CPUFEATURE(MCDT_NO, 13*32 /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32+ 4) /*A AVX-VNNI-INT8 Instructions */ +XEN_CPUFEATURE(AVX_NE_CONVERT, 15*32+ 5) /*A AVX-NE-CONVERT Instructions */ XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ #endif /* XEN_CPUFEATURE */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -232,7 +232,7 @@ def crunch_numbers(state): # for the XOP prefix). VEX/XOP-encoded GPR instructions, such as # those from the BMI{1,2}, TBM and LWP sets function fine in the # absence of any enabled xstate. - AVX: [FMA, FMA4, F16C, AVX2, XOP], + AVX: [FMA, FMA4, F16C, AVX2, XOP, AVX_NE_CONVERT], # This dependency exists solely for the shadow pagetable code. If the # host doesn't have NX support, the shadow pagetable code can't handle From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:55:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517939.803960 (Exim 4.92) (envelope-from ) id 1pji4P-0003qX-Hm; Tue, 04 Apr 2023 14:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517939.803960; Tue, 04 Apr 2023 14:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji4P-0003qQ-F0; Tue, 04 Apr 2023 14:55:37 +0000 Received: by outflank-mailman (input) for mailman id 517939; Tue, 04 Apr 2023 14:55:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji4N-0003oC-2I for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:55:35 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0620.outbound.protection.outlook.com [2a01:111:f400:fe0e::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf7e408d-d2f8-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:55:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7387.eurprd04.prod.outlook.com (2603:10a6:102:91::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:55:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:55:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf7e408d-d2f8-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S5C8RUOJoi+hdotVxI3CsrNA3Ic+y6ScMHT4OnOdslj7PMiji5TJMyg6coI6uSOMHxC5ylWYUBteOjxdJcUfldfuD43CEutMRQxdB9T3/6ayResp69fo/9+9lh4QiYwVSmxiYoaCbgkzMwbe2dLsY8TMU/KLaPM2qnW0BUWps/X4ZBNvqULHU6X00XX75buG5s4fgr8WLVxvE1EYZFLEE3PFCly7e6MNtL+7xXxoL2emufiLKUetwEvQ5PO8p5P+hlNYHY7CJypSCppQLLLk9h8fM7MnLOTGH+AWWimYX+xYlmhNof6dZiidZMrh6BWZoik50vjfygmJGrqZg/eL5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLeFsTI0iyr3SPpC0veUHC0LR4+hVFKVGSkpuBvNPvk=; b=j1B3/nI/Ij62SVVKcWFXoxcL+fLfMxdc/l1q4uUGqygLzB4TS5upSqZP7OkunisF1w6o3/zAZkfdh9Ef045Fetzfib+0LNcfAPK1wizXoqZpVFZxgLx/SlTdlHZOwMLT477nW5cEBKjVj4h0Hm3qp907QtI5kEykoj13JAhITwexypOtOLSxbCQD3oivQRPCz/fm3YyeD15QgA/gpYbfY+yzb8haX+Y7ONtZXbYAkxb7yO+n0N2D3FH6rkXpInVQjROd7mIz6x6fDQvR7VORH2zcsqNBQmirtt8tSyaLKk/z/QIVCI0X3MD196Z1sY5BjJYr8K0M/dgM/QF1shBahg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lLeFsTI0iyr3SPpC0veUHC0LR4+hVFKVGSkpuBvNPvk=; b=on7RLrSQgN/5YUVplOkU3QxQdBCRm73yu0+GJ84nv9o+VI83CNHh2gjtkIHyrepE4N+pD90PJoyQgBRpbnSbqGNMsGUzf0/WU4V6vXqzRK5mu/2q7mDkFfe+XsZQ84wrOOO5S3QtMUt2HWEn2xk1Waf5YHlmahtmNr+AuMFhRenEHogKoPuXo1HEz5VBvH/MuskNIzD1R71ZjJCOAKzXqTqb30mR81Wl/oFfnPJssLiX82CrTMee70lzzrduc9YGBH0Na6L2W/EL5mNwNdN1chHWTD8x7gJOyVlpdYbWnuY0/iPIUzwsgLASgXuFYStiNyK+l32QsLyzdVwaM/IvWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 16:55:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 9/9] x86emul+VMX: support {RD,WR}MSRLIST Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7387:EE_ X-MS-Office365-Filtering-Correlation-Id: a0b0b44f-ddb3-4d24-b94f-08db351ca162 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /je+6YLXR1M66HeYWQ2onL2DabuFALwc5l0MZ+Bn2W8TXGG+HBeejT1eNPsFqsThOJB6eHaDHNiSQTs1z/Jzg/i1fmKOAyKO9vW6M7u/0afR6petqdSm5lFxWto8cqfetpuftRPlw0PK5Q8ZwwYTqWzowc/L8dGqYmWsCwwOuSlGtGZwoixzMqq4bOpngLIVPx6QT5q8N0Q8eXUc4xjzQoV+Ia0Y/vOQVWwKlsXwbg1qBepw2PSbM4pxT2+cP+ZI0emmFI1XIXjG3gi3w5jaIhNHg43/A2CF+2xIx5AuGo5KaLLSD9T6udNkUQRwGhkdkQ4ylm2x2kDkRtjEsxEVkaAko4GoFlLKu7XsyNAvZ+eaVu6z5A4a81zP9tqSlKZuzrYF8SATpXUHsor070GajW60iMMWFCxpsAAlTe+4PFA1OteW2JeoP2nssyskpTgV4paEMUwel5MB8Q/Gr0Icq3l69KyLAGP1jByBGmAowS90BeKn2+kdAVmWMXCh6M8NsNkXV9XwPuiKo4MaRc8I5W3ie6Oiw/gHOhVrliTrKRMt31RF76noMp0K31sQAVXw8V2Ha+75EHUWEN0UW/nsLk4kv3cvkNEYOx4uvMAFURFCIslJ4IvDf+82UdIm+42AyIYDzOUDf8Y2CclKEkhSeg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(136003)(39860400002)(366004)(451199021)(83380400001)(2616005)(6486002)(6506007)(316002)(6512007)(478600001)(54906003)(2906002)(26005)(186003)(30864003)(5660300002)(38100700002)(66946007)(66556008)(66476007)(41300700001)(86362001)(8676002)(31696002)(8936002)(6916009)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjJicU5WMFMxZlZnZEU5NC84dFYwYmowR2NhRFIxci9DZkJsRzR1TlgzQXkv?= =?utf-8?B?L05pQTN3Qnp1WWtPek1FZHlrcDk1TGFwc3FZcVdpMG5uM1B6SEtoajZLaTR6?= =?utf-8?B?VDQ2Ulo3NGxHSmJ4ZWI4Rk1NVFpLOUVzYzdxTVd2R0lDZWQ2dExHMTdHSWVm?= =?utf-8?B?Uk9KdENJSE9SRFl4YmNhZllBd0xURU5vc1VPS016OE9WSldSWXBwUTNzNGhY?= =?utf-8?B?endmOXBIU2hSOWJlYXR3dzRjN2xTcUxNbzRFL3ZDYkpnUkdPeVlkWWlKK25a?= =?utf-8?B?aFdJMjVJbG9wK0c1aERVT0JFWERheGY0T21PanFsNzRLTHJWd01NWlRDZzNJ?= =?utf-8?B?MTBSeHZDM2lWMTUyd1Q0ZktuYnFyM1g4c3p0eGFuMEV1N0xRbEtDdktFaEFC?= =?utf-8?B?WHRJTGc3a0VpSDcyUzJqOGhaUEdIODRVUnQ2NEJ5ajdSdUlMVGVaZHZpSjFj?= =?utf-8?B?c1A1UjYxbkczbFYzSENTMUdnVGE5TC9KM1BOODZ5WitUSDF4Q2w3eUpSeGh6?= =?utf-8?B?dkM3WWRtNkE1MklOTzgySk90LzdiUWtuUmtVNHpWRFJISUNzZ2V5M2ZmcUI5?= =?utf-8?B?L0tIK0NKOWFIRzFvSENtRlM3emk1VzlhbGVHM0I5QUZ2dEV1YzkyNTJ1MzVy?= =?utf-8?B?R1A3TENRQVVwb3NMSnQybDRERmpsMWk0NEhCR1pKaW95TWtnMi9uVjRQTWZt?= =?utf-8?B?MitUbE9CTnpzb0dScUhMUENWR2dqeWxkcERQN1B4d2RGWDc3SDEwUTcvc3ls?= =?utf-8?B?bnFLZlE2OTZJb3FrNEkxOE1NcURqZytWTUZBOUFUNVN0SGRUTHdPcXhOM05Y?= =?utf-8?B?ckEzdTMvdkd3c0pad2gxM1JZZno5YWtMVU9pUXYzNEdNQ2tTbkxSQStJKzBF?= =?utf-8?B?MFNLVFgyYmk3dGIvTXZMRmNuMUN4S3lQclRoQUgrZTNKeUVzelZzMVBOVHky?= =?utf-8?B?OU5leG4wTHNDaWtMRVp3ZnFaSUZxcDlEWnZTa3A1Z3hzK1FwbC9YTk0yQ0Fm?= =?utf-8?B?TE93ZGNPMnNvai83UCtXOTUyaVBuNE5QcytaTWhaN2kxcjcyRU1HWEpJc3ow?= =?utf-8?B?TkdQWlpoclJocEZFSWVJMDhVZlZZclVTQTFvckVTcmNkQVBjMk8zaHMwNzNz?= =?utf-8?B?L2V0cWQ1VnJOWlRBbDV2NlllT3NBTmRvQkx6ZGw1RVBYdkVoRVpNaWdTU2RZ?= =?utf-8?B?VUV3OUFMUzhDcTA2TDZUeFdBck1DTjVhQUlkNG5hS2RjbnhSOU9Nc1NkMUZu?= =?utf-8?B?YXlmSHNzbXIwbUJRaTgwSXZhQTJBYnpJbU9HSG50cXBINE5oSEEzYi9SR0FE?= =?utf-8?B?NUhqUkNLUDBMQmcrVDYzWEgvVVJTRlluK0grK21rVkI5VFZPMll0Sm9iTDRW?= =?utf-8?B?TVdLU0RXRkZ4Y3R3T2dJdkJMSEh1OC9BSnhaL2k1TnRSRGFlS0VtekoxKzgv?= =?utf-8?B?YXdCdS80OG0zajQ1VVc2UURQQkxhUStuNm8xMFJRdXFuUitodnh5a3Q5a1Vr?= =?utf-8?B?QjN4NVQ4N0MwczZIcVlpRW10RGhvTDJrWUR5WWdKcmpaQmVwcXBWckJpNjha?= =?utf-8?B?Z25qL1NuWXpYSnBtVWRGcUpDdU1UOVRGei9sNXViMHMrdEg1SVMrbGQ0NnZW?= =?utf-8?B?RFNkSTZDdWduOSsybGl0a0wzZk5PRHJERHNFR1FuZUVKYlFvc0ZVeXQ0TkIv?= =?utf-8?B?L3BKcVd5Wnp2ZVRscEtsVEZsUFB2QXA1YWVKYXRlUnpYaGYrbkF2R3pvTTYw?= =?utf-8?B?NnNrUlZQMjhHSDdHYVFwSXBHV2N1cUdsMkUwaDd4VVBJUnE5QlgrTlhCTlg5?= =?utf-8?B?eWZTSk9NQTB1V05pZEVaYTlTWFMycWJEcjZJZXF6UTJOb05XUU1kakRxOTla?= =?utf-8?B?eEJRNG0zRlNMZ2ZOZDY3S2FURGU1VGxWdElleGxlVDNaRzJnUWEyK0hucjVG?= =?utf-8?B?Qkg1THVlN1gzRlhQNE54Um9HdTdkazV1K01ZazZqbUZSYkVZdWZ2b2NYazQr?= =?utf-8?B?cGkxME5JQzA5M0Z5RU00Tm9yWWgrTm5uS3JLN1UvZ3Njb3MrTXE2c0hTRjhE?= =?utf-8?B?SDJwb0czQ3JleWFEU3FvbnRnaUliVkdYRllXQUR6QWNjT3ZIVDgxSWxhQnJq?= =?utf-8?Q?Up0dv1aW8a5nepSm6dLuogKca?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0b0b44f-ddb3-4d24-b94f-08db351ca162 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:55:28.7634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0TN3sk35VdQqZnON7Yql3gZG76HBwh1+FgeJ90UY59yFPDq7O9i2VKE/NAuMHiahZ/Nt8dc2lq9KTTuk5cXHew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7387 These are "compound" instructions to issue a series of RDMSR / WRMSR respectively. In the emulator we can therefore implement them by using the existing msr_{read,write}() hooks. The memory accesses utilize that the HVM ->read() / ->write() hooks are already linear-address (x86_seg_none) aware (by way of hvmemul_virtual_to_linear() handling this case). Signed-off-by: Jan Beulich --- TODO: Use VMX tertiary execution control (once bit is known; see //todo-s) and then further adjust cpufeatureset.h. RFC: In vmx_vmexit_handler() handling is forwarded to the emulator blindly. Alternatively we could consult the exit qualification and process just a single MSR at a time (without involving the emulator), exiting back to the guest after every iteration. (I don't think a mix of both models makes a lot of sense.) RFC: For PV priv_op_ops would need to gain proper read/write hooks, which doesn't look desirable (albeit there we could refuse to handle anything else than x86_seg_none); we may want to consider to instead not support the feature for PV guests, requiring e.g. Linux to process the lists in new pvops hooks. RFC: I wasn't sure whether to add preemption checks to the loops - thoughts? With the VMX side of the spec still unclear (tertiary execution control bit unspecified in ISE 046) we can't enable the insn yet for (HVM) guest use. The precise behavior of MSR_BARRIER is also not spelled out, so the (minimal) implementation is a guess for now. --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -240,6 +240,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"lkgs", 0x00000007, 1, CPUID_REG_EAX, 18, 1}, {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, + {"msrlist", 0x00000007, 1, CPUID_REG_EAX, 27, 1}, {"avx-vnni-int8",0x00000007, 1, CPUID_REG_EDX, 4, 1}, {"avx-ne-convert",0x00000007, 1, CPUID_REG_EDX, 5, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -195,6 +195,8 @@ static const char *const str_7a1[32] = [18] = "lkgs", [19] = "wrmsrns", /* 22 */ [23] = "avx-ifma", + + /* 26 */ [27] = "msrlist", }; static const char *const str_e21a[32] = --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -342,6 +342,8 @@ static const struct { { { 0x01, 0xc4 }, { 2, 2 }, F, N }, /* vmxoff */ { { 0x01, 0xc5 }, { 2, 2 }, F, N }, /* pconfig */ { { 0x01, 0xc6 }, { 2, 2 }, F, N }, /* wrmsrns */ + { { 0x01, 0xc6 }, { 0, 2 }, F, W, pfx_f2 }, /* rdmsrlist */ + { { 0x01, 0xc6 }, { 0, 2 }, F, R, pfx_f3 }, /* wrmsrlist */ { { 0x01, 0xc8 }, { 2, 2 }, F, N }, /* monitor */ { { 0x01, 0xc9 }, { 2, 2 }, F, N }, /* mwait */ { { 0x01, 0xca }, { 2, 2 }, F, N }, /* clac */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -589,6 +589,7 @@ static int read( default: if ( !is_x86_user_segment(seg) ) return X86EMUL_UNHANDLEABLE; + case x86_seg_none: bytes_read += bytes; break; } @@ -619,7 +620,7 @@ static int write( if ( verbose ) printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, bytes); - if ( !is_x86_user_segment(seg) ) + if ( !is_x86_user_segment(seg) && seg != x86_seg_none ) return X86EMUL_UNHANDLEABLE; memcpy((void *)offset, p_data, bytes); return X86EMUL_OKAY; @@ -711,6 +712,10 @@ static int read_msr( { switch ( reg ) { + case 0x0000002f: /* BARRIER */ + *val = 0; + return X86EMUL_OKAY; + case 0xc0000080: /* EFER */ *val = ctxt->addr_size > 32 ? 0x500 /* LME|LMA */ : 0; return X86EMUL_OKAY; @@ -1499,9 +1504,53 @@ int main(int argc, char **argv) (gs_base != 0x0000111122224444UL) || gs_base_shadow ) goto fail; + printf("okay\n"); cp.extd.nscb = i; emulops.write_segment = NULL; + + printf("%-40s", "Testing rdmsrlist..."); + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = (unsigned long)(res + 0x80); + regs.rdi = (unsigned long)(res + 0x80 + 0x40 * 2); + regs.rcx = 0x0002000100008000UL; + gs_base_shadow = 0x0000222244446666UL; + memset(res + 0x80, ~0, 0x40 * 8 * 2); + res[0x80 + 0x0f * 2] = 0xc0000101; /* GS_BASE */ + res[0x80 + 0x0f * 2 + 1] = 0; + res[0x80 + 0x20 * 2] = 0xc0000102; /* SHADOW_GS_BASE */ + res[0x80 + 0x20 * 2 + 1] = 0; + res[0x80 + 0x31 * 2] = 0x2f; /* BARRIER */ + res[0x80 + 0x31 * 2 + 1] = 0; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[4]) || + regs.rcx || + (res[0x80 + (0x40 + 0x0f) * 2] != (unsigned int)gs_base) || + (res[0x80 + (0x40 + 0x0f) * 2 + 1] != (gs_base >> (8 * sizeof(int)))) || + (res[0x80 + (0x40 + 0x20) * 2] != (unsigned int)gs_base_shadow) || + (res[0x80 + (0x40 + 0x20) * 2 + 1] != (gs_base_shadow >> (8 * sizeof(int)))) || + res[0x80 + (0x40 + 0x31) * 2] || res[0x80 + (0x40 + 0x31) * 2 + 1] ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing wrmsrlist..."); + instr[0] = 0xf3; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; + regs.eip = (unsigned long)&instr[0]; + regs.rsi -= 0x11 * 8; + regs.rdi -= 0x11 * 8; + regs.rcx = 0x0002000100000000UL; + res[0x80 + 0x0f * 2] = 0xc0000102; /* SHADOW_GS_BASE */ + res[0x80 + 0x20 * 2] = 0xc0000101; /* GS_BASE */ + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[4]) || + regs.rcx || + (gs_base != 0x0000222244446666UL) || + (gs_base_shadow != 0x0000111122224444UL) ) + goto fail; + emulops.write_msr = NULL; #endif printf("okay\n"); --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -88,6 +88,7 @@ bool emul_test_init(void) cp.feat.rdpid = true; cp.feat.lkgs = true; cp.feat.wrmsrns = true; + cp.feat.msrlist = true; cp.extd.clzero = true; if ( cpu_has_xsave ) --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -835,6 +835,17 @@ static void cf_check vmx_cpuid_policy_ch else vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + if ( cp->feat.msrlist ) + { + vmx_clear_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); + //todo enable MSRLIST tertiary execution control + } + else + { + vmx_set_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); + //todo disable MSRLIST tertiary execution control + } + out: vmx_vmcs_exit(v); @@ -3705,6 +3716,22 @@ gp_fault: return X86EMUL_EXCEPTION; } +static bool cf_check is_msrlist( + const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt) +{ + + if ( ctxt->opcode == X86EMUL_OPC(0x0f, 0x01) ) + { + unsigned int rm, reg; + int mode = x86_insn_modrm(state, &rm, ®); + + /* This also includes WRMSRNS; should be okay. */ + return mode == 3 && rm == 6 && !reg; + } + + return false; +} + static void vmx_do_extint(struct cpu_user_regs *regs) { unsigned long vector; @@ -4513,6 +4540,17 @@ void vmx_vmexit_handler(struct cpu_user_ } break; + case EXIT_REASON_RDMSRLIST: + case EXIT_REASON_WRMSRLIST: + if ( vmx_guest_x86_mode(v) != 8 || !currd->arch.cpuid->feat.msrlist ) + { + ASSERT_UNREACHABLE(); + hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + } + else if ( !hvm_emulate_one_insn(is_msrlist, "MSR list") ) + hvm_inject_hw_exception(TRAP_gp_fault, 0); + break; + case EXIT_REASON_VMXOFF: case EXIT_REASON_VMXON: case EXIT_REASON_VMCLEAR: --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -211,6 +211,8 @@ static inline void pi_clear_sn(struct pi #define EXIT_REASON_XRSTORS 64 #define EXIT_REASON_BUS_LOCK 74 #define EXIT_REASON_NOTIFY 75 +#define EXIT_REASON_RDMSRLIST 78 +#define EXIT_REASON_WRMSRLIST 79 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -24,6 +24,8 @@ #define APIC_BASE_ENABLE (_AC(1, ULL) << 11) #define APIC_BASE_ADDR_MASK 0x000ffffffffff000ULL +#define MSR_BARRIER 0x0000002f + #define MSR_TEST_CTRL 0x00000033 #define TEST_CTRL_SPLITLOCK_DETECT (_AC(1, ULL) << 29) #define TEST_CTRL_SPLITLOCK_DISABLE (_AC(1, ULL) << 31) --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 76 +#define VMX_PERF_EXIT_REASON_SIZE 80 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -223,6 +223,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t case MSR_AMD_PPIN: goto gp_fault; + case MSR_BARRIER: + if ( !cp->feat.msrlist ) + goto gp_fault; + *val = 0; + break; + case MSR_IA32_FEATURE_CONTROL: /* * Architecturally, availability of this MSR is enumerated by the @@ -493,6 +499,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t uint64_t rsvd; /* Read-only */ + case MSR_BARRIER: case MSR_IA32_PLATFORM_ID: case MSR_CORE_CAPABILITIES: case MSR_INTEL_CORE_THREAD_COUNT: --- a/xen/arch/x86/x86_emulate/0f01.c +++ b/xen/arch/x86/x86_emulate/0f01.c @@ -40,6 +40,7 @@ int x86emul_0f01(struct x86_emulate_stat switch ( s->modrm ) { unsigned long base, limit, cr0, cr0w, cr4; + unsigned int n; struct segment_register sreg; uint64_t msr_val; @@ -54,6 +55,56 @@ int x86emul_0f01(struct x86_emulate_stat ((uint64_t)regs->r(dx) << 32) | regs->eax, ctxt); goto done; + + case vex_f3: /* wrmsrlist */ + vcpu_must_have(msrlist); + generate_exception_if(!mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0() || (regs->r(si) & 7) || + (regs->r(di) & 7), + X86_EXC_GP, 0); + fail_if(!ops->write_msr); + while ( regs->r(cx) ) + { + n = __builtin_ffsl(regs->r(cx)) - 1; + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + generate_exception_if(msr_val != (uint32_t)msr_val, + X86_EXC_GP, 0); + base = msr_val; + if ( (rc = ops->read(x86_seg_none, regs->r(di) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY || + (rc = ops->write_msr(base, msr_val, ctxt)) != X86EMUL_OKAY ) + break; + regs->r(cx) &= ~(1UL << n); + } + goto done; + + case vex_f2: /* rdmsrlist */ + vcpu_must_have(msrlist); + generate_exception_if(!mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0() || (regs->r(si) & 7) || + (regs->r(di) & 7), + X86_EXC_GP, 0); + fail_if(!ops->read_msr || !ops->write); + while ( regs->r(cx) ) + { + n = __builtin_ffsl(regs->r(cx)) - 1; + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + generate_exception_if(msr_val != (uint32_t)msr_val, + X86_EXC_GP, 0); + if ( (rc = ops->read_msr(msr_val, &msr_val, + ctxt)) != X86EMUL_OKAY || + (rc = ops->write(x86_seg_none, regs->r(di) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + regs->r(cx) &= ~(1UL << n); + } + if ( rc != X86EMUL_OKAY ) + ctxt->regs->r(cx) = regs->r(cx); + goto done; } generate_exception(X86_EXC_UD); --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -600,6 +600,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) +#define vcpu_has_msrlist() (ctxt->cpuid->feat.msrlist) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) --- a/xen/arch/x86/x86_emulate/util.c +++ b/xen/arch/x86/x86_emulate/util.c @@ -112,6 +112,9 @@ bool cf_check x86_insn_is_mem_access(con break; case X86EMUL_OPC(0x0f, 0x01): + /* {RD,WR}MSRLIST */ + if ( mode_64bit() && s->modrm == 0xc6 ) + return s->vex.pfx >= vex_f3; /* Cover CLZERO. */ return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; } @@ -172,7 +175,11 @@ bool cf_check x86_insn_is_mem_write(cons case 0xff: /* Grp5 */ break; - case X86EMUL_OPC(0x0f, 0x01): /* CLZERO is the odd one. */ + case X86EMUL_OPC(0x0f, 0x01): + /* RDMSRLIST */ + if ( mode_64bit() && s->modrm == 0xc6 ) + return s->vex.pfx == vex_f2; + /* CLZERO is another odd one. */ return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; default: --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -286,6 +286,7 @@ XEN_CPUFEATURE(FRED, 10*32+17) / XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ XEN_CPUFEATURE(WRMSRNS, 10*32+19) /*A WRMSR Non-Serialising */ XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ +XEN_CPUFEATURE(MSRLIST, 10*32+27) /* MSR list instructions */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ From xen-devel-bounces@lists.xenproject.org Tue Apr 04 14:57:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 14:57:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517944.803969 (Exim 4.92) (envelope-from ) id 1pji6a-0004X7-2Q; Tue, 04 Apr 2023 14:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517944.803969; Tue, 04 Apr 2023 14:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji6Z-0004X0-Vi; Tue, 04 Apr 2023 14:57:51 +0000 Received: by outflank-mailman (input) for mailman id 517944; Tue, 04 Apr 2023 14:57:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pji6Y-0004Wr-Jx for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 14:57:50 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0630.outbound.protection.outlook.com [2a01:111:f400:fe0e::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 104f1fcb-d2f9-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 16:57:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7387.eurprd04.prod.outlook.com (2603:10a6:102:91::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 14:57:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 14:57:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 104f1fcb-d2f9-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MkqA52HTGsGEPM35miugkVaUCcy2ru4hCst91XMg6yVjJk+YOkh3F7YNfIv8qIA7ssiiHZUpkCbZch159eXVdSAq5zkABZ44TzhTS/C5MD+cbVq6Zk7Z4b6pE1v2EVERKzTxFDp7muBdQxH4xYef+sUSHL583eRAExUxMq+tV4xH21iMPmPkAfNTJeg73UoyNnOSPQllKwdQhEplRTSxNHxgQ1SRjRyrO3n/lSLGsW5yDofgh2Pe0KrDmGvIDIWKgYrMvRvj083kg8bd1jQA1PNiSAd2R6TJSngCyOxEVmfrhTQwBvvgcp9EE1tf5wFd1TfD0DnL6q9BQZzXHJD6Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AsDrIOoJ4XkstJMEfZwJev2okvsusmdA6pBNEPh/60E=; b=eGIvZ07gW4tEn/ePHr6nzsksQKoVyNY++RB3Axt1CRkVGloYJpvvr7PuSMEIj/IAYr8Mxo4DHo/ITD+6hK7eb/0ujFK6SClgyJKK0sQ1LY2FNriEFH6XrDCm6PE943CO6I4wiI7VSVKuyOuTor/l58HRZn3jS/44kId3+Kw1pQc0sWDyPebMUUoMlZQSIYmNYjKCwdRhJ5hm3rdrW0bzseeN8Wn+cNfGnkAwlk8Mu+nNAY0SEXELNL4gCljYe2TNZyCCHjHjtiOw3Fbi1kjC+aPKDDsQw/e/l9ueyRJmuAJrvSf5hv+jpLMA/mrg87qvEBiCdPNVbLT0sxHm2YEw4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AsDrIOoJ4XkstJMEfZwJev2okvsusmdA6pBNEPh/60E=; b=V0H63stCf+XcTSPlqe45Uh8sLOv/pEl13b3f7lNZNSLADEmuSAzyHox9CGpeC0VjzHcZVdqcnUbJN/f6xGaGDuW7NcjrhVibdPi701tYigkSeNAPwN5jcvHDdM9OxuocCCMxh/8kKgPwcZvY4DtXsPQ3ywXtGmr7o5Uhj8Wnsc3ezsgNeOwss9ApAC46UC7O5Tqo4Hbo8Mb/OlOl2aL2mSUYS0c3RJK+N36SQd92gtYYplwp1phCQglvjzq0vWCdO55Tapts05oF7dhrLzlW3rNj0QVsEeCFP3xJHcfTCG/McTUeIkyp9LQWr8CJjAbCNgC9UBvEVqD6wpnk2vxODg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <31d27d25-f576-d605-d3d1-b56b543df568@suse.com> Date: Tue, 4 Apr 2023 16:57:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 9/9] x86emul+VMX: support {RD,WR}MSRLIST Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7387:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a2e1e52-5555-4953-2544-08db351cf324 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j71GX9BV6knxN1YyWwgQ1jD5Rld8A6hmBbKYZEUs5kbopOO4IgvmLRO2I0kB9iZkhoH8H8zKKLuBGtGFY0Pepcw5AbqJ7CuhofmFjnK2IUqrqYJCcgoc+xxygT2VsbC8EdFhApaFkilK94GowVT/E7LvpbE9g+ypjw3iHxns8jztGmdCfaPc8kg5tMP5/fgDK+SNZBeiTjV5N+QY6lEdHDiAylljjWuqCBICR7VZ+DU2lKbxKiqkjYddxSqGiJ3P/9CZSHleYLi92otTbxtFEEg32n/rSj8WrfNQBah9jdUZRIU0B9xK7Akt/K+kzf2cEaaqT3r9RJEad/Ip2qv12fCxWGDaoCoBOzR1Ar+oNGQkfjdEsNvvEmVENn8Fk5zqmOn1nCjgg9MhVLjJpAS1rSES6z4sYRcH3NE81FS106Z2tJdb5TI7vw49VTEIeGdBERS7YvjrmRjH2aD7Ilko6UjrdKEIgK/UoNlbvf42HBolFW9sRlfWIPGHP2knl7dAE6V4xPAQrUq6EzznTIJu1ELCRBggG3Fpf8YMGo7WPYQqQxydD3I0cwkVXEpI++EM55zwSmgIJwpyswCrhpgRl6fS2aSVmcS0zcPhQD8wnPh+0co+7/CfKp6yoZMdr7xD9qQAGKstbxzxPy8tzrOCBg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(136003)(39860400002)(366004)(451199021)(83380400001)(2616005)(6486002)(6506007)(316002)(6512007)(478600001)(54906003)(53546011)(2906002)(26005)(186003)(30864003)(5660300002)(38100700002)(66946007)(66556008)(66476007)(41300700001)(86362001)(8676002)(31696002)(8936002)(6916009)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW9uOEEzaVRPUjFEcWZDeDJabFo3Q1hPdEdWb3VxZVE4NUU0dlB1N3RXWlVr?= =?utf-8?B?OGNNYmNTb2RtSVdkSXN2NzQ2Q1BKcWZkMDVqTE1rWTcwNzJ0UWt4cUw1bGlG?= =?utf-8?B?WW1CKy8xWFc4bkFpMXpuL1FnQnh4d1lHcVkwc09DTGJoWHpBYmdpTjl6RHBy?= =?utf-8?B?KzNDaG5GQ3Y2NnlrMWdmeEtkSFhkeGppaC80c1dEZU83MkFJU2EyWnRuTDV3?= =?utf-8?B?ak1weVNqMkN0VlJKaEFCYWFNM29SNjRZR1UzSTdvNSsra1RaWi9TdWpOak1x?= =?utf-8?B?ZmcvVzMwMjg1MHdqdWVaRWYzWnNDeUQzdkJOQUdUSnd4dEhzaFhkVnZMRGpO?= =?utf-8?B?TUEyaXFmVDN4RFh3YStUSDJUc0FxZUhEak1jOVhSbzk1bnN5b3hpbHhuWElG?= =?utf-8?B?TVU0enRBTVorR0k3RWRjNXFkUUhVQnZlK0hSSFpmUXduZlRFVnQxL1NPcEdt?= =?utf-8?B?K1p1TVZYeFJrODZld0ZCZ0p6UmQvUlFDK0pNa3B3c0Y5QU8xZVNZTDBLMXlS?= =?utf-8?B?c1h3QnJVdVhrZHdPOTNBVXpVMXVYbVZmL1dsQjlLV1FWV1JsT3NDT0E0dnln?= =?utf-8?B?dURUeDdwWk9OYUR3em0zMktiZFc1eTJoVGpiaHhlaXJpRjRkOFMyN2xjdjdH?= =?utf-8?B?RFVMVmoyTTJ2TTlKMEU3bGZGNTduYmMxclUrWDF2dkRUZ1NQNnBuR1oweElE?= =?utf-8?B?TnlWb0p1bVNBTzMxY0FrdytjWWtGcWYyU3ZaWGI4KzlCNk9GWWZ1MEFHZ0hZ?= =?utf-8?B?OG5ZOUszbWxIYUVsN1B3UjZiM3doZTRXUlEvQUNVR2hhUzcwMHJaYkR6TWZM?= =?utf-8?B?aFRWL1NEejJ1bG9IaHFnNUd6aEZSN2dXTEdsUEp0UGE2ZWxwZ2hUVGF4U21n?= =?utf-8?B?U3gyRkRXMFpTcTNyUDV5OElhVmdXRmo0T1J1cmo4eW9RdHJudlVDR2piTU02?= =?utf-8?B?K2xpazVDeGY4R25Pa09kc2dyNmx3eTBhSm9vUjdxWno1TWY1RnNtVmYxeTlF?= =?utf-8?B?K0R3N043VDNlS3pXWU9mZDYya3I1bk43TmZMWHBleWFCMWZDWmZqMXl2cy9w?= =?utf-8?B?UTlobTl5K0VsTWs5QktzUnp0NGlkdjlFNm5UQnlCSE41cnU2dDczR3hPMmpU?= =?utf-8?B?UXhtcnV3bFV3UGQ1czZhbCtRaXR6eVFEVmViN1N3djJ5ZE1RMjhzc09WV0ph?= =?utf-8?B?M2lmeWQva1gyMTFLZXRCZUhZM3VVVHE3ODlYUE9WeUEzM012Z09UZnBHZzNw?= =?utf-8?B?bGE5Z2RlU2hhMGJaYjFzQUJIbEFxbmJsZlcrUlBwdHYwUC9qRDY3SEx6WDVn?= =?utf-8?B?OTI3YXhPV1Y0UGVrUTBpMVlWeWJ1dTJRWjFWcS9FUXRoR2IvbUJXYTN2NDQx?= =?utf-8?B?M2VHcDYvd0IzWUFEUGVpc2V0aGplVVU4Qk0wcnRUQ3FFZEFWM05MRE5IRyto?= =?utf-8?B?dWFIZVBjUGppQTdJNEx3amhMdVF1d21uYU9GTmR2YkhacTNteWRob1VXY2Jk?= =?utf-8?B?NVNQWnQ0VndzTG0vQWkvc21DTlc3ZHZYQXYzb1E3U09KZVlyN0d0RmQ0K1g3?= =?utf-8?B?bHAzR0hmSjI3UGQyalk4MHJnczhuNVRLU2plMHhETndTbXZaNnMxS1NSL0x3?= =?utf-8?B?N0hHMFNLMnVwU1VXZ2RKMEdVR0dhRklwU0NqK2NTT1lYMlJiZ0NpM2VNeUEv?= =?utf-8?B?b0t5U3hsZjhYWko2cjJtZGJ4SnpIYkN3V0Y1dGJTUytBVjhiQnhYSFJwT0ZX?= =?utf-8?B?dkFlcC82OHVaYkRTSUhoY2M1N1l2ZUlzZXdCZVJhS2pRUFhQeWE4ZDZYUm5y?= =?utf-8?B?dDNtRXFaMWZCMzJUalNIWE9wdytwWjlBT2tpUGJxb1daVEptTXVOQmNVa2Ji?= =?utf-8?B?N2NMVlQ2SUU3LzgvbktETkVIZnZ5UElQcE5lVFJnZzh3RG4wYWxGenhMd09L?= =?utf-8?B?M0c3NkxnM0Zwanh4RXMzc2puZzNuMFFScVhTUkE2V1o5ZmdHandkMXVXQjZF?= =?utf-8?B?R29XQWVSR0F0ZWc4dHBsRjlaVkFzckh5ZFNmcXRZYVBtQ25GU3FGaFM1R0Fo?= =?utf-8?B?UWxvV2xGYnd0dU8zRXA5NFFZem9hcEJZdzEvQW5QNll2eTlSODdqQmozMGp5?= =?utf-8?Q?iQeOPa4Bk/ka4LCWlEE9nVMTp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2e1e52-5555-4953-2544-08db351cf324 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:57:45.9412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uRvVk0AgHxp0pnLXpPA/RfyurjTWRctGCFrtPTCSLSibt2rcjzrLSbp25fQKK7F1SGfWEbwtwU34Os1RitGxzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7387 On 04.04.2023 16:55, Jan Beulich wrote: > These are "compound" instructions to issue a series of RDMSR / WRMSR > respectively. In the emulator we can therefore implement them by using > the existing msr_{read,write}() hooks. The memory accesses utilize that > the HVM ->read() / ->write() hooks are already linear-address > (x86_seg_none) aware (by way of hvmemul_virtual_to_linear() handling > this case). > > Signed-off-by: Jan Beulich > --- > TODO: Use VMX tertiary execution control (once bit is known; see > //todo-s) and then further adjust cpufeatureset.h. Argh, should have Cc-ed Kevin and Jun, even if there weren't this issue. Jan > RFC: In vmx_vmexit_handler() handling is forwarded to the emulator > blindly. Alternatively we could consult the exit qualification and > process just a single MSR at a time (without involving the > emulator), exiting back to the guest after every iteration. (I > don't think a mix of both models makes a lot of sense.) > > RFC: For PV priv_op_ops would need to gain proper read/write hooks, > which doesn't look desirable (albeit there we could refuse to > handle anything else than x86_seg_none); we may want to consider to > instead not support the feature for PV guests, requiring e.g. Linux > to process the lists in new pvops hooks. > > RFC: I wasn't sure whether to add preemption checks to the loops - > thoughts? > > With the VMX side of the spec still unclear (tertiary execution control > bit unspecified in ISE 046) we can't enable the insn yet for (HVM) guest > use. The precise behavior of MSR_BARRIER is also not spelled out, so the > (minimal) implementation is a guess for now. > > --- a/tools/libs/light/libxl_cpuid.c > +++ b/tools/libs/light/libxl_cpuid.c > @@ -240,6 +240,7 @@ int libxl_cpuid_parse_config(libxl_cpuid > {"lkgs", 0x00000007, 1, CPUID_REG_EAX, 18, 1}, > {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, > {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, > + {"msrlist", 0x00000007, 1, CPUID_REG_EAX, 27, 1}, > > {"avx-vnni-int8",0x00000007, 1, CPUID_REG_EDX, 4, 1}, > {"avx-ne-convert",0x00000007, 1, CPUID_REG_EDX, 5, 1}, > --- a/tools/misc/xen-cpuid.c > +++ b/tools/misc/xen-cpuid.c > @@ -195,6 +195,8 @@ static const char *const str_7a1[32] = > [18] = "lkgs", [19] = "wrmsrns", > > /* 22 */ [23] = "avx-ifma", > + > + /* 26 */ [27] = "msrlist", > }; > > static const char *const str_e21a[32] = > --- a/tools/tests/x86_emulator/predicates.c > +++ b/tools/tests/x86_emulator/predicates.c > @@ -342,6 +342,8 @@ static const struct { > { { 0x01, 0xc4 }, { 2, 2 }, F, N }, /* vmxoff */ > { { 0x01, 0xc5 }, { 2, 2 }, F, N }, /* pconfig */ > { { 0x01, 0xc6 }, { 2, 2 }, F, N }, /* wrmsrns */ > + { { 0x01, 0xc6 }, { 0, 2 }, F, W, pfx_f2 }, /* rdmsrlist */ > + { { 0x01, 0xc6 }, { 0, 2 }, F, R, pfx_f3 }, /* wrmsrlist */ > { { 0x01, 0xc8 }, { 2, 2 }, F, N }, /* monitor */ > { { 0x01, 0xc9 }, { 2, 2 }, F, N }, /* mwait */ > { { 0x01, 0xca }, { 2, 2 }, F, N }, /* clac */ > --- a/tools/tests/x86_emulator/test_x86_emulator.c > +++ b/tools/tests/x86_emulator/test_x86_emulator.c > @@ -589,6 +589,7 @@ static int read( > default: > if ( !is_x86_user_segment(seg) ) > return X86EMUL_UNHANDLEABLE; > + case x86_seg_none: > bytes_read += bytes; > break; > } > @@ -619,7 +620,7 @@ static int write( > if ( verbose ) > printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, bytes); > > - if ( !is_x86_user_segment(seg) ) > + if ( !is_x86_user_segment(seg) && seg != x86_seg_none ) > return X86EMUL_UNHANDLEABLE; > memcpy((void *)offset, p_data, bytes); > return X86EMUL_OKAY; > @@ -711,6 +712,10 @@ static int read_msr( > { > switch ( reg ) > { > + case 0x0000002f: /* BARRIER */ > + *val = 0; > + return X86EMUL_OKAY; > + > case 0xc0000080: /* EFER */ > *val = ctxt->addr_size > 32 ? 0x500 /* LME|LMA */ : 0; > return X86EMUL_OKAY; > @@ -1499,9 +1504,53 @@ int main(int argc, char **argv) > (gs_base != 0x0000111122224444UL) || > gs_base_shadow ) > goto fail; > + printf("okay\n"); > > cp.extd.nscb = i; > emulops.write_segment = NULL; > + > + printf("%-40s", "Testing rdmsrlist..."); > + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; > + regs.rip = (unsigned long)&instr[0]; > + regs.rsi = (unsigned long)(res + 0x80); > + regs.rdi = (unsigned long)(res + 0x80 + 0x40 * 2); > + regs.rcx = 0x0002000100008000UL; > + gs_base_shadow = 0x0000222244446666UL; > + memset(res + 0x80, ~0, 0x40 * 8 * 2); > + res[0x80 + 0x0f * 2] = 0xc0000101; /* GS_BASE */ > + res[0x80 + 0x0f * 2 + 1] = 0; > + res[0x80 + 0x20 * 2] = 0xc0000102; /* SHADOW_GS_BASE */ > + res[0x80 + 0x20 * 2 + 1] = 0; > + res[0x80 + 0x31 * 2] = 0x2f; /* BARRIER */ > + res[0x80 + 0x31 * 2 + 1] = 0; > + rc = x86_emulate(&ctxt, &emulops); > + if ( (rc != X86EMUL_OKAY) || > + (regs.rip != (unsigned long)&instr[4]) || > + regs.rcx || > + (res[0x80 + (0x40 + 0x0f) * 2] != (unsigned int)gs_base) || > + (res[0x80 + (0x40 + 0x0f) * 2 + 1] != (gs_base >> (8 * sizeof(int)))) || > + (res[0x80 + (0x40 + 0x20) * 2] != (unsigned int)gs_base_shadow) || > + (res[0x80 + (0x40 + 0x20) * 2 + 1] != (gs_base_shadow >> (8 * sizeof(int)))) || > + res[0x80 + (0x40 + 0x31) * 2] || res[0x80 + (0x40 + 0x31) * 2 + 1] ) > + goto fail; > + printf("okay\n"); > + > + printf("%-40s", "Testing wrmsrlist..."); > + instr[0] = 0xf3; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; > + regs.eip = (unsigned long)&instr[0]; > + regs.rsi -= 0x11 * 8; > + regs.rdi -= 0x11 * 8; > + regs.rcx = 0x0002000100000000UL; > + res[0x80 + 0x0f * 2] = 0xc0000102; /* SHADOW_GS_BASE */ > + res[0x80 + 0x20 * 2] = 0xc0000101; /* GS_BASE */ > + rc = x86_emulate(&ctxt, &emulops); > + if ( (rc != X86EMUL_OKAY) || > + (regs.rip != (unsigned long)&instr[4]) || > + regs.rcx || > + (gs_base != 0x0000222244446666UL) || > + (gs_base_shadow != 0x0000111122224444UL) ) > + goto fail; > + > emulops.write_msr = NULL; > #endif > printf("okay\n"); > --- a/tools/tests/x86_emulator/x86-emulate.c > +++ b/tools/tests/x86_emulator/x86-emulate.c > @@ -88,6 +88,7 @@ bool emul_test_init(void) > cp.feat.rdpid = true; > cp.feat.lkgs = true; > cp.feat.wrmsrns = true; > + cp.feat.msrlist = true; > cp.extd.clzero = true; > > if ( cpu_has_xsave ) > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -835,6 +835,17 @@ static void cf_check vmx_cpuid_policy_ch > else > vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); > > + if ( cp->feat.msrlist ) > + { > + vmx_clear_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); > + //todo enable MSRLIST tertiary execution control > + } > + else > + { > + vmx_set_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); > + //todo disable MSRLIST tertiary execution control > + } > + > out: > vmx_vmcs_exit(v); > > @@ -3705,6 +3716,22 @@ gp_fault: > return X86EMUL_EXCEPTION; > } > > +static bool cf_check is_msrlist( > + const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt) > +{ > + > + if ( ctxt->opcode == X86EMUL_OPC(0x0f, 0x01) ) > + { > + unsigned int rm, reg; > + int mode = x86_insn_modrm(state, &rm, ®); > + > + /* This also includes WRMSRNS; should be okay. */ > + return mode == 3 && rm == 6 && !reg; > + } > + > + return false; > +} > + > static void vmx_do_extint(struct cpu_user_regs *regs) > { > unsigned long vector; > @@ -4513,6 +4540,17 @@ void vmx_vmexit_handler(struct cpu_user_ > } > break; > > + case EXIT_REASON_RDMSRLIST: > + case EXIT_REASON_WRMSRLIST: > + if ( vmx_guest_x86_mode(v) != 8 || !currd->arch.cpuid->feat.msrlist ) > + { > + ASSERT_UNREACHABLE(); > + hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); > + } > + else if ( !hvm_emulate_one_insn(is_msrlist, "MSR list") ) > + hvm_inject_hw_exception(TRAP_gp_fault, 0); > + break; > + > case EXIT_REASON_VMXOFF: > case EXIT_REASON_VMXON: > case EXIT_REASON_VMCLEAR: > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -211,6 +211,8 @@ static inline void pi_clear_sn(struct pi > #define EXIT_REASON_XRSTORS 64 > #define EXIT_REASON_BUS_LOCK 74 > #define EXIT_REASON_NOTIFY 75 > +#define EXIT_REASON_RDMSRLIST 78 > +#define EXIT_REASON_WRMSRLIST 79 > /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ > > /* > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -24,6 +24,8 @@ > #define APIC_BASE_ENABLE (_AC(1, ULL) << 11) > #define APIC_BASE_ADDR_MASK 0x000ffffffffff000ULL > > +#define MSR_BARRIER 0x0000002f > + > #define MSR_TEST_CTRL 0x00000033 > #define TEST_CTRL_SPLITLOCK_DETECT (_AC(1, ULL) << 29) > #define TEST_CTRL_SPLITLOCK_DISABLE (_AC(1, ULL) << 31) > --- a/xen/arch/x86/include/asm/perfc_defn.h > +++ b/xen/arch/x86/include/asm/perfc_defn.h > @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, > > #ifdef CONFIG_HVM > > -#define VMX_PERF_EXIT_REASON_SIZE 76 > +#define VMX_PERF_EXIT_REASON_SIZE 80 > #define VMEXIT_NPF_PERFC 143 > #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) > PERFCOUNTER_ARRAY(vmexits, "vmexits", > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -223,6 +223,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t > case MSR_AMD_PPIN: > goto gp_fault; > > + case MSR_BARRIER: > + if ( !cp->feat.msrlist ) > + goto gp_fault; > + *val = 0; > + break; > + > case MSR_IA32_FEATURE_CONTROL: > /* > * Architecturally, availability of this MSR is enumerated by the > @@ -493,6 +499,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t > uint64_t rsvd; > > /* Read-only */ > + case MSR_BARRIER: > case MSR_IA32_PLATFORM_ID: > case MSR_CORE_CAPABILITIES: > case MSR_INTEL_CORE_THREAD_COUNT: > --- a/xen/arch/x86/x86_emulate/0f01.c > +++ b/xen/arch/x86/x86_emulate/0f01.c > @@ -40,6 +40,7 @@ int x86emul_0f01(struct x86_emulate_stat > switch ( s->modrm ) > { > unsigned long base, limit, cr0, cr0w, cr4; > + unsigned int n; > struct segment_register sreg; > uint64_t msr_val; > > @@ -54,6 +55,56 @@ int x86emul_0f01(struct x86_emulate_stat > ((uint64_t)regs->r(dx) << 32) | regs->eax, > ctxt); > goto done; > + > + case vex_f3: /* wrmsrlist */ > + vcpu_must_have(msrlist); > + generate_exception_if(!mode_64bit(), X86_EXC_UD); > + generate_exception_if(!mode_ring0() || (regs->r(si) & 7) || > + (regs->r(di) & 7), > + X86_EXC_GP, 0); > + fail_if(!ops->write_msr); > + while ( regs->r(cx) ) > + { > + n = __builtin_ffsl(regs->r(cx)) - 1; > + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, > + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) > + break; > + generate_exception_if(msr_val != (uint32_t)msr_val, > + X86_EXC_GP, 0); > + base = msr_val; > + if ( (rc = ops->read(x86_seg_none, regs->r(di) + n * 8, > + &msr_val, 8, ctxt)) != X86EMUL_OKAY || > + (rc = ops->write_msr(base, msr_val, ctxt)) != X86EMUL_OKAY ) > + break; > + regs->r(cx) &= ~(1UL << n); > + } > + goto done; > + > + case vex_f2: /* rdmsrlist */ > + vcpu_must_have(msrlist); > + generate_exception_if(!mode_64bit(), X86_EXC_UD); > + generate_exception_if(!mode_ring0() || (regs->r(si) & 7) || > + (regs->r(di) & 7), > + X86_EXC_GP, 0); > + fail_if(!ops->read_msr || !ops->write); > + while ( regs->r(cx) ) > + { > + n = __builtin_ffsl(regs->r(cx)) - 1; > + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, > + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) > + break; > + generate_exception_if(msr_val != (uint32_t)msr_val, > + X86_EXC_GP, 0); > + if ( (rc = ops->read_msr(msr_val, &msr_val, > + ctxt)) != X86EMUL_OKAY || > + (rc = ops->write(x86_seg_none, regs->r(di) + n * 8, > + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) > + break; > + regs->r(cx) &= ~(1UL << n); > + } > + if ( rc != X86EMUL_OKAY ) > + ctxt->regs->r(cx) = regs->r(cx); > + goto done; > } > generate_exception(X86_EXC_UD); > > --- a/xen/arch/x86/x86_emulate/private.h > +++ b/xen/arch/x86/x86_emulate/private.h > @@ -600,6 +600,7 @@ amd_like(const struct x86_emulate_ctxt * > #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) > #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) > #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) > +#define vcpu_has_msrlist() (ctxt->cpuid->feat.msrlist) > #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) > #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) > > --- a/xen/arch/x86/x86_emulate/util.c > +++ b/xen/arch/x86/x86_emulate/util.c > @@ -112,6 +112,9 @@ bool cf_check x86_insn_is_mem_access(con > break; > > case X86EMUL_OPC(0x0f, 0x01): > + /* {RD,WR}MSRLIST */ > + if ( mode_64bit() && s->modrm == 0xc6 ) > + return s->vex.pfx >= vex_f3; > /* Cover CLZERO. */ > return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; > } > @@ -172,7 +175,11 @@ bool cf_check x86_insn_is_mem_write(cons > case 0xff: /* Grp5 */ > break; > > - case X86EMUL_OPC(0x0f, 0x01): /* CLZERO is the odd one. */ > + case X86EMUL_OPC(0x0f, 0x01): > + /* RDMSRLIST */ > + if ( mode_64bit() && s->modrm == 0xc6 ) > + return s->vex.pfx == vex_f2; > + /* CLZERO is another odd one. */ > return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; > > default: > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -286,6 +286,7 @@ XEN_CPUFEATURE(FRED, 10*32+17) / > XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ > XEN_CPUFEATURE(WRMSRNS, 10*32+19) /*A WRMSR Non-Serialising */ > XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ > +XEN_CPUFEATURE(MSRLIST, 10*32+27) /* MSR list instructions */ > > /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ > XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ > > From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:01:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:01:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517948.803980 (Exim 4.92) (envelope-from ) id 1pjiA9-00060N-IO; Tue, 04 Apr 2023 15:01:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517948.803980; Tue, 04 Apr 2023 15:01:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiA9-00060G-FK; Tue, 04 Apr 2023 15:01:33 +0000 Received: by outflank-mailman (input) for mailman id 517948; Tue, 04 Apr 2023 15:01:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiA7-00060A-VA for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:01:31 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0c::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94eecb06-d2f9-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:01:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DUZPR04MB9982.eurprd04.prod.outlook.com (2603:10a6:10:4db::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:01:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:01:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94eecb06-d2f9-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnu0U4TuQngHdyNyTYVEFbBFhsVXEe9GL/nuyWVZ7SVtt5JfGi3nT3iFPZA9AZTkPVWkb6YPXmwgP6IqB9UvyUdI6t9CDjVO/aNGylNc6P6ySy4UrYH4z6VUugAr4DvDeXH7d4wl6FUjT7lb14YVr98gXVKpm89qsgwZ7drAcUKucWkq0T6/ftdQ8NotCdMqV0YBbEBZnUJ9p2fLX3nmELWMU31kaudTT1PZxbbKQsx/XuPZy6ApAPzHHxms4Lx96e4mz634KTWbHHJSCLMSTQouRDK0cbyKbZ5Ck9YZIJF22oTZJlGbwLEZogvCWSOIlWBMdU/GgB7cNbpYaM/r4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aaynlAKGKmHgycZ7qG6oJUclcTjJpuYDyEq4fa/d5Qw=; b=SnXL8GYPzKQZWYU1emHWNgm0NgZmj4qZXM9v7gSgS41IOcUQNKBx6BaDA+hrwSSdCN06hdC+ITKfQW/auuSXnm0VmZx2wjx9d/ZlN0yF6ZBXMdN/PzdW+YUdFLbIVozsRC9q0NkFwzP5b4oysrsCkFC+qTmIXxuB8sh2bNA93zGkot1BYly7alUGQt1bdnoxtJ8mQ6aXxSoUjHjI02X9gkUZMm3Gy14lzelZRoGCU/RBk9ottjHD9NXBe5P8fHd44HyGTp3YVTgRoTPPy9gQAsyoFMkGh6fYWbdZG/RfATTM4wCKsqEkZiN7mSJQsIheH0OgwwHKHc6+WYqQ5X9lBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aaynlAKGKmHgycZ7qG6oJUclcTjJpuYDyEq4fa/d5Qw=; b=iF2E/VlPPMHb454CWi/ToaUff67RmZb/Ck0CyYuTX7f7yA6w/ioHTBdPIs1NmUhsklG5FyCuQiqpwxdCx5e+t2SMxDmg4lPHuf5uT7crO/WvT/gn5Bn1soapC7pyEcKG90F2vQ0lJc+/f/Dv/VEiCy0FtZT6yKxtH+NR8usl56MoQXMzbqYtze/p2MtCkF5fXVI9DtDH0RfVtWRNjYbcZJje8Wt8Thl4QB2IRbS4/SjK+x9EfLv3bAQD65j+uDy/OsHSm9rxXfXcrxB8Zin8aeCuyJoxnX8/Vuqka7PlYCOsSEeA+ZNJtbEYGUDOIG5qqLj7m2ozyWXLrRvIhcyJBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <63395f4e-2272-5537-190e-27318d4057ea@suse.com> Date: Tue, 4 Apr 2023 17:01:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 09/15] x86: Out-of-inline the policy<->featureset convertors Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-10-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-10-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DUZPR04MB9982:EE_ X-MS-Office365-Filtering-Correlation-Id: 8351e5e8-42ff-46a2-e71e-08db351d783c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4DjTsWhZTzvrZz7tcTW9xefyFb7DMdjekkej6IrrrhsHj+uBFNgz6D2leFEH+XGRbwPFVfsCzeWvzZ2dVgv3RlVy9Drvlygbxs2ZNXq1J3kerGrCI3joplLvKbV+joxvXlfqOK0T1XNAKSrf4fnyy86lE8sZh+UoA2P6h3/7fT8s44cbKprTmg4o8VU4KvHK3LRZW/C/Cn0uc40lBI0JFAnIE0mSwgT4YmQFWpjG3NAvnbUkXlow5dew0g2NucxaHBC3yRrKVK/IZbomyU6ileJuMfPih2XP3PYiLXPOrs5u2YvT7scYxrznHpFGKu4poRU52lonA0vKaEkVx6bt+TkrBSndzqLAjiz3EjmFNDK8lAVUrD5BAyyPW+lABEuU3Q5O0WHWqSCp+uCpf5ndAzsP3j38FVZuNUjCdKfK1TZIgPuGz5K2tJgHufJ3/gUNJLZDlaREUtrWz1MCPq/0JbySxNY8OPk4N2mkSJpcUuC870dV5/UycPZTrPVRFTF6X6yR0MdlfvpGDm3b1ten2Shev/4HGzs0IOGW8cm9sY+iuJ3gvy85lq9HYa1pgxPBcKIycfuJfIChnR++KLfJSzYDNtKs0zT6BuVUEl1utU/W6LttLKJkuxTw823j5VP6cTIsagmhvZ0iDV65wv5A1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199021)(2616005)(86362001)(31696002)(36756003)(2906002)(31686004)(53546011)(6486002)(186003)(83380400001)(6512007)(6506007)(26005)(4326008)(478600001)(66556008)(66946007)(8676002)(6916009)(66476007)(54906003)(41300700001)(5660300002)(38100700002)(8936002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVpaR3NnS1gwbjdRcFZQeGUvSW9HdkVEVDh0UVZuYTBsV2YwYzgraUsrS3Nn?= =?utf-8?B?SnB5OHJmUjRqVVlGam9mdWlpTWFaSWlzSFlGNXY3SVgyamdQMTdIV2ZmV3JL?= =?utf-8?B?NGdxa2JnaFNRT1lQWDl3QThFTE5ZejBlaDl5L2IyMmcxUm1BTzNmSHg1dlZG?= =?utf-8?B?QUZCVmJIYVRRRHUwTHV0dVZkSnQ3cURqMVRCQkZVRWhMYmJGRFVCRFJva2NY?= =?utf-8?B?dUVMMlBLTUI3UldCS3ZEeUpqTmMxT3JXREtrMGdjazIyV3NNd1FBakE5TjZO?= =?utf-8?B?VnhHOWdTSzhSc3FYcmxnejF3RUdIb0Z0RkRPaE9OQVMxY0gwQ213VHV3bml5?= =?utf-8?B?OXV5c3RXNG5UUHkrNzR5d3AyVWFlVmI1N2JtSDE1bkRqeC9qcXNmUXduOFd6?= =?utf-8?B?bUxxdHIyTUhIdENPK2pmTHJaa3NkVFlLcTJGUGFjY3UvVUgzaHB2WHAyTVc5?= =?utf-8?B?ZGxkREpoZlEvUVc0VzV6SGJJY1NVWVBvaWFGcHRqRmVrdkJtOVVMZkxyK3BV?= =?utf-8?B?TmtNbVl5YkhETVIxTlNmaVJvaDBGV1g4dERjbXNpTnlDTDNwRDlwTzBMcGlC?= =?utf-8?B?a080a2RvR3ZtRytmcE5FVCtKalhRR1E1YTVKZ2h1NmFhYWxWd2hWNFAweUVv?= =?utf-8?B?SUtZV2U1MHJpL3h0MTlpMmIvQU5FZjloZzcwOWdESkU2Mi9FMnIwaDIwOENy?= =?utf-8?B?ZnN5MXFEcFV0TmtmdlZkdUpURUtBcEszMDh0V3lsTVpLa1ZCaDYybWRSRUZH?= =?utf-8?B?T1dQVE4xbThrWVlkNUo5TVIzRzFOSVJFTC9UbTREK1p3cW5zeldDQmNMdmhJ?= =?utf-8?B?MFRLaStYcUE1NVdGUGRSb3ZYaUd4TUtiek1uTFNGVTl0Y3EyRGhVY2R5ZkFT?= =?utf-8?B?aWFhV1dsbUEvdkdwTi9YQm5iVEVteXU0R05PRkVIeVdhUXp4SnNiY1ZzdUM0?= =?utf-8?B?cVFYa0tzVWgwWTZEdnoxQVRHK1FPaWRnRTdqcWpuMEdWM2R6QW8wQVQrckZn?= =?utf-8?B?WkFwbVJlLzB6WW1iSUhBRVFxKzhqdDlLcHZZUFFVZldCeGF1M3VUWjhUemhi?= =?utf-8?B?VjVPYlhWL1c4a1FYVHNMeVRiVnJPRTIvM1FuWk9OSXEwR0lmTzYrNXFVQ0dT?= =?utf-8?B?dlJHajJtbWhJcERyQXBIOTArdUwzSEpNYjhMYnQ2Z2NxZnp5UzNOcFVqd1pP?= =?utf-8?B?K0laMG5EaUl4MVUyWjR1eU9tdG1TOUR3SC9VeG4vbnZvUktNbnZpRGFRS0lQ?= =?utf-8?B?OEJvV1k3UEdLcU5sTHFKREpPR0dTRmNjUnRvcGx2cnJKKzlSUmdlTHdEYTVM?= =?utf-8?B?TU9aeHBGSlR4bVY0VHE5Z3VlRzBJMU9Fd3NXbXB1TUtSSG50Yk9oaUo2bkFy?= =?utf-8?B?SjlVZnlaOEYrWU8wTVlQUzJKcjZ0NmlIa29sb1N2WEU4VUp2K25KSWl4VCtx?= =?utf-8?B?a1hZREM0dHg3em5PbWF5QTc4c2tSMURuS1dCUHk5QXo2VmJpTjRtb1l5WE94?= =?utf-8?B?aldoa1k5SGd1SmlvdFNFcENnMUFUajVFYWw3c3Znd1ZoTmV6RnpJNG1tc0o5?= =?utf-8?B?RjYrUExVVG1JK2J6UzYydUZmeDBUbllxTW9YRFhSL1hZay9Nb3dISktJVFp1?= =?utf-8?B?MUZGVCtwdzVUK2g0TkVCakZtcHkvd0VvVWxVcEdiNXhCaEtpM2RrNExQdDB0?= =?utf-8?B?MUhRZU9wdUFUNUluNTdvUUVVZ2pWRnYzZmJUQ0wvTGRSanQ0WjlDOG92eTRm?= =?utf-8?B?dWdoUTdLVS9HaGRSbmlzUEJkeDE4Rm52QTZsOHhxYnpXdFB1TGRmU2xKQjR3?= =?utf-8?B?R21VNnFRbElMWlRIRkQ5RS9HYmUzRTVwU0dsWFAwOEswTGs2Z2tjellDbEc1?= =?utf-8?B?NnRKNDVzZUt5ZXRpeTRxVzVOMXNPaGsvT2tnL3VlTkRMMi9oWjNFUDJjTFhR?= =?utf-8?B?QUErdDYvd05vWWJaVlRlWG12TUdGK01ZUG4yK1ZlbStWdE9HZFpEMWplT3pl?= =?utf-8?B?REFsdjdKUE5kb2xIWHJENEJUZEtLVWRDdjJMT0hJNnlOQUl1M1lRY2RtWVVF?= =?utf-8?B?ZEVmc2hRdDdPQzZPK3lPQVZtNDBjZVlkaE5IQk9UcklRY3BZSktuTnhLdjdm?= =?utf-8?Q?W7o2cKO41XY25zBLFBGjqvJDO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8351e5e8-42ff-46a2-e71e-08db351d783c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:01:29.2058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e/NU6duYQSxdd9syxVQdwJ1YPaYZrg7ALX7yQq0Bc/9MQok2smjrcEs4wBp/KG8KoK8ulfRsNEWtK5JPeuH1oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9982 On 04.04.2023 11:52, Andrew Cooper wrote: > These are already getting over-large for being inline functions, and are only > going to grow more over time. Out of line them, yielding the following net > delta from bloat-o-meter: > > add/remove: 2/0 grow/shrink: 0/4 up/down: 276/-1877 (-1601) > > Switch to the newer cpu_policy terminology while doing so. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich I take it you have a reason to ... > --- a/xen/lib/x86/cpuid.c > +++ b/xen/lib/x86/cpuid.c > @@ -60,6 +60,48 @@ const char *x86_cpuid_vendor_to_str(unsigned int vendor) > } > } > > +void x86_cpu_policy_to_featureset( > + const struct cpu_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) > +{ > + fs[FEATURESET_1d] = p->basic._1d; > + fs[FEATURESET_1c] = p->basic._1c; > + fs[FEATURESET_e1d] = p->extd.e1d; > + fs[FEATURESET_e1c] = p->extd.e1c; > + fs[FEATURESET_Da1] = p->xstate.Da1; > + fs[FEATURESET_7b0] = p->feat._7b0; > + fs[FEATURESET_7c0] = p->feat._7c0; > + fs[FEATURESET_e7d] = p->extd.e7d; > + fs[FEATURESET_e8b] = p->extd.e8b; > + fs[FEATURESET_7d0] = p->feat._7d0; > + fs[FEATURESET_7a1] = p->feat._7a1; > + fs[FEATURESET_e21a] = p->extd.e21a; > + fs[FEATURESET_7b1] = p->feat._7b1; > + fs[FEATURESET_7d2] = p->feat._7d2; > + fs[FEATURESET_7c1] = p->feat._7c1; > + fs[FEATURESET_7d1] = p->feat._7d1; > +} > + > +void x86_cpu_featureset_to_policy( > + const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpu_policy *p) > +{ > + p->basic._1d = fs[FEATURESET_1d]; > + p->basic._1c = fs[FEATURESET_1c]; > + p->extd.e1d = fs[FEATURESET_e1d]; > + p->extd.e1c = fs[FEATURESET_e1c]; > + p->xstate.Da1 = fs[FEATURESET_Da1]; > + p->feat._7b0 = fs[FEATURESET_7b0]; > + p->feat._7c0 = fs[FEATURESET_7c0]; > + p->extd.e7d = fs[FEATURESET_e7d]; > + p->extd.e8b = fs[FEATURESET_e8b]; > + p->feat._7d0 = fs[FEATURESET_7d0]; > + p->feat._7a1 = fs[FEATURESET_7a1]; > + p->extd.e21a = fs[FEATURESET_e21a]; > + p->feat._7b1 = fs[FEATURESET_7b1]; > + p->feat._7d2 = fs[FEATURESET_7d2]; > + p->feat._7c1 = fs[FEATURESET_7c1]; > + p->feat._7d1 = fs[FEATURESET_7d1]; > +} ... add quite a few padding blanks in here, unlike in the originals? Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:04:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:04:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517951.803989 (Exim 4.92) (envelope-from ) id 1pjiCj-0006cl-3V; Tue, 04 Apr 2023 15:04:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517951.803989; Tue, 04 Apr 2023 15:04:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiCj-0006ce-0m; Tue, 04 Apr 2023 15:04:13 +0000 Received: by outflank-mailman (input) for mailman id 517951; Tue, 04 Apr 2023 15:04:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiCh-0006cY-PF for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:04:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7e1a::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f445bdf1-d2f9-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:04:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8441.eurprd04.prod.outlook.com (2603:10a6:102:1d8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 15:04:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:04:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f445bdf1-d2f9-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJ3Jz95BAxaEfcUaLgmAxhFzC8qLu3IZw8sFwrIRSH1rbAEt3wovjz1er+uWoudXh4SO5n4cxqWimMr4wdN4X3PV8DKY1BfIiqTKjGExrfaS2AJSniTFewGmegkrhsANOmMRVCE+y1THeBLAMoF/b051JaYVFy40k/KJrXoBlVEgELkmqrYAyI3YL9ukilVbiHTSawtUhEn1SKNOeSgT0ZruPRhlW0s/KCBsPHbU7PXVGZx51PsrcUhHY3sjsgT1DCJI6CFWsYuMfquChj7AqMpNKMgX0DsAU7du08xAafG+8XV2cAZnmfE2zxaj1B7N/bvY05nlePp9/as3DlA7Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kGuOQTAuPBRa5775jCnhEJmWNqlJN05jP5ku+zddE8M=; b=bPHKoqBtX4UszgXQ+YE/snVgbVrJrrnXNk7M8mQI8EmKR5zPZo9UrMItRa4WmX5fOPjnlvb06mOetimF4KANC11W2VX4Maqk7v7LDlv2WEaAuhQpULk9emx7tJZSgJuMNZb10NobYSOvweevpiUzg5ereBjnZ4+IkfTaxY+stv+i782BHYeyTwQ9WKeptJREMxJkJ79uKCfrPu+RgXvrQpVLieTtwz7pUFHAKvMs4dX+DH3avQIQVk5EAK0UJKHl/AQ0iDj1cV7JMgArfCsKsSbgRbQ1nuwV6cHpJbC7e5vnhDfyueppiIyhA3kxcanCTCP3z4mloJKyYjt2yIxVDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kGuOQTAuPBRa5775jCnhEJmWNqlJN05jP5ku+zddE8M=; b=3r7anzR6MHKgnJE7J5DFvb/doTrtD6kquzUZ0P6qbkv94vEAL9HKvbpwRVDPGRCUtM6SsZyzas3wYOX7Q5zm9ZMRcXPbU26PLW0XrP/RfZZejtShoR4lN6xCQu46Vph4bl7KtvLiobiZKr36t3WjN3UXV/QUaAQgRaR31hxPYgdDYldVpKPdOU992+vrloK3xYVwI63bsWrOP2FbRqNn/khZEz5MTMKmOFmvlMDJjKVNw50YYs3pwoeea3X+yxUGOrwb1Jb4VFEyWHOuljZpAc+E5OHQlkCBIYEJ+HK1oiKMU+7qjfa5vGjEtnhC9IZ2vuSu22NBG1kpERkJjs1qcw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <60e92022-e383-6382-ff50-d6c67e2be227@suse.com> Date: Tue, 4 Apr 2023 17:04:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 10/15] x86/boot: Move MSR policy initialisation logic into cpu-policy.c Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-11-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-11-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8441:EE_ X-MS-Office365-Filtering-Correlation-Id: a6150b87-a238-4ad1-c5d2-08db351dd5e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 41epBBVYVpwblG2jiHD/PvMA2phDRHb9KdSeOXbNd0oGKaPWEqsW0SsDl/+WOZaev5cQJppfEwyGNj9yAlYzvMjhHdf2VrVXLJ2Z1BjI7AGyp9Fu/n+clBTlrmPifGqg1bq5AjsxCzWsrSOcCsZUjlmUHKE0vhDXVYOaVALk6AcCGcQWs6aIH8FzY+vGOAnK1J3jWDo208WAt0xjtuWKPkR/zvmhIK/b8uAth5wlR6Y8XxYsRtRkwzK5ilVyU9d8Bj8qWyc5eHC04AXC8AkcwRwDT/Ysza1oiKBwlCNiCYAoUgK0ImWJfcQuaEwlsZ7JBlZozn9NTrDbssknxyEAae4BLLC/Q0WdZKujTfONhE5wdYHGPl2RNJ3OhOtlhbg+91idHNXUaP9mZnF8w9I2AVQgAg0a2r8Q/n2+I4kdWxh2S4s0uiM8gumBUwvrt3CLYfadyu57eHG2bsSyBsJ7iQUinwnKpQzaYlpGgQXVcOJW+bFKFTkrG4zRCvx4mJLDt48benIWYUlhULTX5Er+rASjaYex8OpLZkVYVe8XCS7tVpC2Fe8/hvRf5g99SFWGj+B5ShsxBF2FhuaxP0jg0xQb4UYv3qCn16LgrhF/u8SR8leoi1htFadjRND+XdXdIOgBsCi/Y4WfO7aKspRfUA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199021)(558084003)(36756003)(38100700002)(31696002)(86362001)(2906002)(6486002)(6512007)(26005)(53546011)(6506007)(66946007)(66476007)(6916009)(4326008)(8676002)(66556008)(41300700001)(54906003)(478600001)(316002)(5660300002)(8936002)(31686004)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHQ1eWpySVcwWE5TczZPYkpGQVVYKzAzdXRaQlkzUFJMOERCdUkvQ0RFMUJk?= =?utf-8?B?SVZVOEx4ZVB2RGZ1R0NzS2phSUxtQU4xdURnZy9jVytYNkVtYnU3T2R3ZndI?= =?utf-8?B?K2wyaHRTeThwQmxlOHVzdFVkNTdoZUFOMTkyS3cvckN1VnZMUkVOdjlMVU4z?= =?utf-8?B?czNqYTlXaVFtMExqbnZzTWFWRW5XZXFVaUZxQmEySFJZUjJua1RFTFBVRGxj?= =?utf-8?B?RnN5UklYOFhHNWlFazdHQjh5eWw5dUFMTkhmdlNKeE9mbmk0Vmo1OTQ4QXJR?= =?utf-8?B?MlkzRzdsUFVUTU5TUXE1aVJrNEFab0hrUG5ORFJqWU5XVlN4ZjgzekZMcXdK?= =?utf-8?B?cTdPZTNrQnNtODhPOHpTWlBtQzl0aHA1ZjdPT3hRQkQxTkVSc3c3Tk8wVU4r?= =?utf-8?B?NSsyR3Ixc1dON0NTQzVLMW4ySnJuV3NpZlFwZFRsTWpLYUhuZlh2TnZWZlVZ?= =?utf-8?B?R0U3dFRRZWdyK0kwV051RDFpRlpiTkZNeENrdmpTUlo5RjgyQi8zNU5IMWJq?= =?utf-8?B?ZURIdzRyTmNZZGdhdktpblBrQVhOTHI5bk13N2d5WFNSbHVJUzZybFZRR3FV?= =?utf-8?B?dU1NY2l6bktNYU9kUTFNcVNyNmJvMkRnQVQwZVlTYWQxNkxKN0VTMWJGUkln?= =?utf-8?B?MXkyMEpJU3BzdG81b2JFNmI4SjI2UzlxVkJ2TEt6ME9BQWdQdUF6TGcwQW9m?= =?utf-8?B?dFZUN3ZGMFMwdXNaNlNidlFTR1hRYy80aCtWcldYMFBUS0RXL0R6cUVmNmNO?= =?utf-8?B?R09VTldZMkdKMFplSTc1MFM5QU8vaGVFNnh1R1FnazAyZTZvVjFBMXpGR291?= =?utf-8?B?RDdBeUh0SGRmWTZicXQvVi9zdlBrcCtKci9wL2o2SUdxMkRCNWg4d3JvM3I5?= =?utf-8?B?dEpwbEdrL1h6QXN0T2VhaEV2SEJNQkEwa1ZDbXpQR0U4RnZGeTEzMEh3WnJB?= =?utf-8?B?SEV3SzhYVTgyQjBQdlVGUFBDSjFjM0xnc3JnQnlCQk5mRWdaSHA5QTcwcFpn?= =?utf-8?B?cHcxQmtHSnkzSTdhQW03bndEVDFrMWJNclp3blZTTXpLdFo5Vy92WmhsLzln?= =?utf-8?B?S0pjbGFQeTYrNGJJY1NLS3FKMFgwR29YQzBZcXI0UGg0dUNKT3AxcVA2TmtL?= =?utf-8?B?SHJBZkVDcFRUVHRKbjB0QmI1YURyQ2phZGkxelBjdUZoVElRUTV5cis1QmVZ?= =?utf-8?B?VEV0WFRwemNXOHFWTUYzSFF3U204NUFOMUpTRjdiaVhzemxvVTlULzZBcmZk?= =?utf-8?B?NWRLKy9nNjBKbkNSK3EzRFUyZXIxV0dzTXAzWTZ2WXprcnlXbHEzVFlrMDV1?= =?utf-8?B?bEVocXJNcE9GVFVvenZPTEU5T011emxBa3pJQnJsbndYZWFRbHR0NitCWng1?= =?utf-8?B?SThBSUM3RHdYTDB4Rmhlb2ZpS3ZRN1lZSnZESWk3VlVvL2xCSXFsSEhuR2VK?= =?utf-8?B?czlRdWprTUVROW93c2ZvMlZQOFdNNFFiVmt3VW54cW1POXFOdTUxYlY1NWdt?= =?utf-8?B?MGFuUjBYakpPdVluV0puUU1UZFpvbXorNm9VY1pYSDJWWVUrV1BHU2NUNStC?= =?utf-8?B?eUFZMEplOFZqRlpTZEpHQXl6NFB3ckNwZGMvOUJYM0pDOTR6ZzlzWllZYmZn?= =?utf-8?B?eXlPRm1IMm1EcGRMbGtsUjM5VU93TkdzKzZmZlordm9lZ3Zzdk9yc240bm82?= =?utf-8?B?bDB6Y0FwbU12UjNpMWlWN2JIOTd3c3FaQVRyalNtaVdRVithWGFDRkNRbmVE?= =?utf-8?B?Z3I5K0lyZ1NBblZYd3Nkc0ZMOFJjWVJFMUc4aktWdWwzMHE5STJMdWFKT2xt?= =?utf-8?B?eG5uYWJGZEgrN3AzbytCSUQ3SzRjTm5ZenpQcm5qclpsYW9mK0EvT2pmb0JE?= =?utf-8?B?b3lsV3ZpRFNudVVzVis4QUpYS29HZFh0S3RJTEZSNjFkaGw0K2pkWGZBRGxr?= =?utf-8?B?dklkVUJXWjEyTG0yTW5LbEFONU5rWHdvVWdldUxIWDdUR3FvbmJrSmlSV3N2?= =?utf-8?B?Tk90RlZoaFptVHBwZmk0cDZ6Q2dTOG9GMklFMlR4YnM2bnl0YUtZSWlMV1Ny?= =?utf-8?B?bytaeXVXbWFmZVNHYnFkL201dzVpUXdaUkt0eUpvTXBkWk9IaHRWY1JOMGRm?= =?utf-8?Q?9UAn50KisctOjY4IGcwt38JV+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6150b87-a238-4ad1-c5d2-08db351dd5e2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:04:06.3767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9q3EroGxX9ZsllO2HRY9CHKEhpxsU4NWaQXvzhsvfy+1fuMW/Fa4zcpMwwU0/xRoFzRHqLfWkNHmLse4EdR8MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8441 On 04.04.2023 11:52, Andrew Cooper wrote: > Switch to the newer cpu_policy nomenclature. > > No practical change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:04:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:04:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517953.804000 (Exim 4.92) (envelope-from ) id 1pjiDF-00075N-C1; Tue, 04 Apr 2023 15:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517953.804000; Tue, 04 Apr 2023 15:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiDF-00075G-8t; Tue, 04 Apr 2023 15:04:45 +0000 Received: by outflank-mailman (input) for mailman id 517953; Tue, 04 Apr 2023 15:04:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiDD-0006cY-I2 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:04:43 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05f58427-d2fa-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:04:42 +0200 (CEST) Received: from mail-sn1nam02lp2046.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 11:04:34 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5598.namprd03.prod.outlook.com (2603:10b6:a03:28a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 15:04:31 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 15:04:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05f58427-d2fa-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680620682; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=igp8vhRXqLzi6dgIlBWd0iZCPWb4KnQmsCPvlHrRiqk=; b=eioSmmy8ZGpEcGI/xJrHVL2RHJ51Zs+ko5+0S0Xl7wC9HgLxbmjsUJ+p BXcDdQUl2fU5pjwkWl0lrzo1wzAUH5XA2KSFWyHajUYm2SS5mUCs8m66L 8CiS+C/JncpoXjwS3Bb1ySGJR7ixWw4xVR0GvO9bkefb7AP3YE0W5XtoY Q=; X-IronPort-RemoteIP: 104.47.57.46 X-IronPort-MID: 103079324 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xDo0HKKNRu6hUnKtFE+R9pQlxSXFcZb7ZxGr2PjKsXjdYENSgTVWy TQZXWmCM67fM2qmLd90bN7l9BwDsZ7Vm4c2GgRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRiPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5zGWZB2 tw9MwoPTTCIt6G0kJCLYeVF05FLwMnDZOvzu1lG5BSBV7MdZ8mGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTSNpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyr33rCexnmnMG4UPIaBptI0knbU/X0WMw8/eEGWoP6Tj0HrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAmZDNcbN0ttOctWCcnk FSOmrvBGjhHoLCTD3WH+d+pQSiaPCEUKSoZY3YCRA5dud37+tlv0FTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRP+ZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:EWHwRqoO3mHraeV0iCd3j2AaV5oJeYIsimQD101hICG9E/bo8v xG+c5wuCMc5wx8ZJhNo7+90dC7MBThHP1OkOss1NWZPDUO0VHARL2Ki7GN/9SKIVycygcy78 Zdmp9FebnN5AhB5voSODPIaerIGuP3iJxAWN2uqUuFkTsaEJ2IMT0JdzpyfSVNNXB7OaY= X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="103079324" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zep+hn5yw3NA1jJHq1tf6kXrYY45O8INcCRz3PgUYawe2hIl5bbZfvzjeEgM0JNNJIrg8awLHkpdrN5MDrlr0rGqDtL1yedDV7ecWCCu8sctv+WMUc7wAjO1+pJetJOnVX4zvuqvMVZm14cKTU9NzXEkJvD67l1WSTtR8jQT/3l5t3CZ/P98CSuUYli8AcpiXZxOPjf/GZElTekluiUBMqooAQmVB6lLjRpbMKrU3qvd0Vf0PRn7e4i0h1R7Y9BAnlLhBYhMDaIgAFeO7zQVjjtKwRfaav2+1O+ayIKETvwSR1N6msfuoEdTuyd7xhIXgatujSy2wG2WbImoH2SjBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SAJceG8SYRB7dmczQIz9NoKmgKqs2EQZOu9yMBGtoAw=; b=lCH1Z81IlhvjG1CmJLos7NLbWThErhel9E0JUo9j7JXZw7iR1oRZv2bw8dAY4Egc7xCeec9KbG1bJCPIjrpoZnCfiadBA/wADOgYJXAS74U7jjiRKreLjccJRxLBEmompdQ3Ux/WXtdYef8Cj3kb//DYchPMr3Wg4lYr2CrWc7B0UDqN38E0p2Dm8qRjQON2FUW7tHfTTRIe/nA6RAw42dZ0rLU1kYwnQwY3VSoY0v4kxAcVBapm6P2CH3r/kzWQDv4i6AoP8lZkaEQfFHMvXmflgLwCL32/Ht3TRkTS8C4QsuyRq7/84E/Ij64LaZnPDjhQrVBu+nNd3OElk01gGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SAJceG8SYRB7dmczQIz9NoKmgKqs2EQZOu9yMBGtoAw=; b=SKzQywZPOCsvd/BQswUJk7wabPiUfz762Nqii8wYcsOXkW7qn8WWVZdZhKRUaDAE4Gz234ayWrDFuTFh6e05r1aAsiTJ3pZCz/J2Y/1zt3QyyA/0KGqps/70ZqDqW6+1Nt24HhIX4hCe1TT5G7PfClCZ42bx9H/8X7DiEzU7ijU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 17:04:25 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Message-ID: References: <20230331175719.500285-1-andrew.cooper3@citrix.com> <4b76def9-9940-ccf0-8050-12ddf2c1253c@citrix.com> <91fc0c1f-a985-17bd-2011-f4964d82e008@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91fc0c1f-a985-17bd-2011-f4964d82e008@citrix.com> X-ClientProxiedBy: LO4P265CA0219.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5598:EE_ X-MS-Office365-Filtering-Correlation-Id: 719450aa-12ce-42a8-2a09-08db351de4c4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wVy+E1AH+Wl65p+WGY44c1JsWBvU/R07CFxP/Lhwfb1/hwSDm6F3N8mvYC05jHJRFhJ76nVcZqtjhW/ELWMDZ9BFALVMt3HS+qBsGcGy+/CQX0DmPeBZHMPRiG/G7t2CIUp8h3rJcIg4CKJjnzLqwqasCc8C0vWVDqXU7A8Kzb9rj/55iwbaOVXrAF3cjh7SuNKVwnAUZqVUyv1Og71RgzgIUuk2HyDZ7sfp/wdtrNTAwuDS4qapqkqd7qizRmPc9s2cOam+A/+FG3UQ2erfk9nZYFetsbYNKTpZIIwWxmUlaZsj6GPe66vmfQP7PCJqvdZy39J4QvTv8jEPQYCB/sNuFoBigT7+3GCN98U65mhLrVytpukhydvRSMFrS/RgIfF3eNOqYjv7abqQXSKkGexkm+Tjo/rLKAKd2KosAw4ZD5sZzs1aqORMYcm0cl6zr2swBfgzYn3bET1pfANAdsq/fvagkEsNl28f1vK9nlWRXNOuAO9KQRhsSohOl8St0zIqLoIeN5z4Xc/TzstgUW+FGK+DW9HdfIKza+y8+CfmkiimmsajzwCqDFLqFsZA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199021)(186003)(53546011)(6512007)(26005)(9686003)(6506007)(66946007)(38100700002)(6666004)(41300700001)(6486002)(83380400001)(54906003)(478600001)(316002)(6636002)(33716001)(2906002)(86362001)(82960400001)(66556008)(66476007)(8676002)(4326008)(5660300002)(85182001)(6862004)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2MvMFhNS2RCQ0ZpQ3ZCaExNZVFoTXIrUkRrSFBKMTdlbUVNMTdqTEROTWMx?= =?utf-8?B?cHVjRE8vcHRMWHA4RDVRZzdFbkdBN3J5K1VGSXZCWUxHTE9qbzFFNCtGVmlj?= =?utf-8?B?U2lPazJPdVA5dW1iTG9hQm91Nzl1OXFrZitaMS8vSWtia1habEdpdnRjd0p2?= =?utf-8?B?blUxcWVFSEFLbTNtY2VjelpRMVVobTcxSUFWemVTYlozRjZSVEhIanpSaUx1?= =?utf-8?B?SDFYVFdKMVBaVEhXVzFSblJUTVF0eUFHMnNQdDZUY2JUa1RVTlV1WlZncVlM?= =?utf-8?B?MGNiVFRSbDJDVHdNWUhzSFpyOWxjalZLZ1hsSnBXcnVyWW1hUHFtZlRGT2xQ?= =?utf-8?B?eStMUElJRXRRdVdIQ2ZPUG9ia0hYaURwQktJeTc1Q1JDSVFCcWZoUzNSa01P?= =?utf-8?B?RVVjbW5EbUN0T00vcUYyY2ZyVkNsd1kwMGw4VE1rSVZXYll0bWcvb0FqTUJG?= =?utf-8?B?SS9Xc1BBMElIbDBxU1l3OGhaLzNVMEpjb2x1VS9hMGdxT2NHdVBGQVlNMnB5?= =?utf-8?B?ajFZcGpPbVB5M29pR21zRW44czZaS1gxVmc1K1ZINTBOSGRPMk16dG41TGkz?= =?utf-8?B?ZFlWNGwyR2c1QUdrN0ZGTjYvQTNDKzUyMURwR3VCYk5UZS8yaEtVZGlrWjBP?= =?utf-8?B?K1U3UHUvNUFWdEFBdEppWjJYTmhHSHY0K3pzSjlZK09xd0pRNG9sMUxERUc4?= =?utf-8?B?RXRxT3AzSllRTmxvRWxMQk5wS1JENlNNQkdYRDllUVc1QnVXRU5TdnJEcVE3?= =?utf-8?B?NlVacmdjWkZ4QS9DZG5VS1lBcnBFaFQ3aDNwclBCbExKTXNKQ2Y4cVdIaTRW?= =?utf-8?B?T2thVTJWY0t5QWs4YjhiRkpYdmJvVGZBVHppeTZKOEtmVE5IZHFNWTYxU2Fl?= =?utf-8?B?N1QyQWsraWtja0o1TnBjRlhyR1UvdGJCRE8wb1JkT1lmRUg4TEY5d1BneG5U?= =?utf-8?B?c2ZXWVJvTEp5SVV5bU1PSkx0eGgzby9tVlZMOVlRdTJubXlIa0IxWGxTN3VU?= =?utf-8?B?MWxyK3VvY0FMU29ITFZ0T0pleEQwdkFwcXNENk9pTEk5QjMybjg2WE1vaHJE?= =?utf-8?B?by8rbDFPaWNYV1I5QURleGNhOWdzMmdMVjRkNng3bEtaSzdVUHJxdlBhRzJ1?= =?utf-8?B?T0VyWHByZWI1Qk1uQ1h5aXM1K1lPR1BsYVA4TUpiTE5nUmFRUEtqeWhDeGdV?= =?utf-8?B?amRJbi91aCtYWW1nY1hMaVZqOEdMTnZxWW9tL0tRMGNDdjhiZ2tWUjQvWFVI?= =?utf-8?B?NlBRMkZ5aGNuZnQvNGU4bDd6dENHZ1ZnYWhjblNnOGxqZ040Z1VSdVdZWkU2?= =?utf-8?B?cXkxWXFVSStGbDZtYkgraXExUEFPS21ieTcwRjZNcnUvZWdUaWVubnR6Z0FC?= =?utf-8?B?M01CSHcrZE5VZEszdi8rN2Y4Q1kzamRjK25FVmxVaERwWUJ5M1hDVmFNVmFP?= =?utf-8?B?dlRkWmdqUDIzcnN5cmQ0RUhVekZwVHNHa0lnWkxSbElWWjdWaE9oQ3B5VFo0?= =?utf-8?B?Qk9UVmRrNUJlcXhaOGM3ZkM3bnFQR05JYlN0VHFiQjNhNU1BbCtQYllwRGZX?= =?utf-8?B?RjRRK3p4eXBRQWpPSDV0YlJmd3IreENDY0lhUUd3UWhOOHhUNUhzcitKTUVV?= =?utf-8?B?SkRXQVhiTjFMU0JuN3pKU3JRUzRJMlE4OG5GQnQ4b0NidzlWL0RyelFRRW05?= =?utf-8?B?RlRzOU8vNGdidTNEOHVPZHozZjNIZ3dtNEJMZkhGYUV4V0hjcWt3MXp3elFy?= =?utf-8?B?MVdKTWVqZXJ6eENIUTBxTVpNZUtQU1FQUHJnWUJ5VVVLWW5OOHBJRzZCRmQ5?= =?utf-8?B?L3dzbEkvS0NSYUZXZUJrcDdZWWhMZlgvbmVCRHlybUVZUmQvdUtlSHZGUjR3?= =?utf-8?B?dE9iZlFQTElZcFdaMmQ2eEIvQXlYMlJZamU5Rm9SdWY1T3V2dmVoS0VhblQz?= =?utf-8?B?d1dwNWdsZmRpRk5IY2MzVjFHbzdjemdpbGEwYWtQWUNYdmhJd1dDdjMzRzd6?= =?utf-8?B?akhKN0c2QmZ4QnFmS2lTUi9HNjhPTnlmellTa0tMY05rK3RpblYycU5OQ1Vv?= =?utf-8?B?TlR5MzduUU5WYTdHNDhWaFd0VVZ5aTA4Q1VxVVcreXc0QTBlanBYTU9oenY1?= =?utf-8?Q?oXXBCMv32Pfi+2nteoDxkXlM1?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gG5XgOYqLzVRA3Dy19jxDPS8VVaXE3vZAH3V8sk0tgmKzD9p1sTOqAlWB1GWVpPQpnCTAqMrCRtO02JU/Btj+L4w+LY8czWB+cx0jvfIXovmW55A5KYoyyauyNIb1H0FSenkWyMK7o+kJVaCGL0Mf8Qkw9KX+Swdjt/PyNui9CiSgKHsCCUgH8I4KDwAY/i7+RQW+D0HjLYNF3OD1acd/CzA5JTdbnEa5TVfIQ0wAMhZBx3rbVuFd+Ydqe3Y9x0Zx/+mB6DTj/soLFu15vL2lBiThyXYShKXomjuSn2pMHOTnub/q6tynFSUvj7if9n65XllOhLI7AHIjzAK8Wft3AzxnTCXr+MHjLT5zpqFm7h1LRNm6b79FuD+mtKflyAjlMiuLPMv7eNrRgNGojFQ3qHNVTBBh8pkyVhApJNGaAvBH5ilFKNhj84z2neTAYBmWG1eaxPCw73k6OShprJiDnCwRfBVSr+GzFE3A5UEqbpPWYFvCliYGh6STX5GSagCxnhwSArLcOJTYx3RF8zqUhEuWovUfVj8gP3gOKLztD6PaizqPeqhwyQnwunMibt/wX7WbXIR6CsrsaGOLM7xRLQVJsdCDba4UVrbW3dN6NAaxBG/eKdhjeLEDGWj1RZ1OTlhgwGnMMn1QjG2CMebaPBIAzF3+uUfptwvRmiCjMhAb1uAdOHZHES44/v1GuV9p5acQkW4hTetdjxlPVJiQfiAaeAKr72xTzS6LmpoAIAhy8F1GPRUuVAmAWO7LunSn3SPO+eYH4oR4E4ixRiLm6c38J5WM0rsmX8Ve63g+t3SEnz9AZDX4+6eTbgeUH31 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 719450aa-12ce-42a8-2a09-08db351de4c4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:04:31.4982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3osPg+CdPmys++u/aNnauMQ4HrG5VVT8Q0JpjMYjUGpd58t1OHxX4YF1l7BMoyRGofzx9YmJJPdIAoBh/s6y3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5598 On Tue, Apr 04, 2023 at 02:27:36PM +0100, Andrew Cooper wrote: > On 03/04/2023 2:26 pm, Roger Pau Monné wrote: > > On Mon, Apr 03, 2023 at 11:16:52AM +0100, Andrew Cooper wrote: > >> On 03/04/2023 9:57 am, Roger Pau Monné wrote: > >> (Quick tangent...  Our PCI handling is currently very dumb.  > >> pci_mmcfg_read() returns its value by pointer but the callers never > >> check.  Swapping it to return by value would improve code gen quite a > >> lot.  Also, when MMCFG is active we still pass BCS accesses to IO ports.) > > I wonder if it's really preferred to access registers below 255 using > > the IO ports, as Linux seems to do the same (prefer IO port access if > > possible). > > And see how many attempts there have been to change this, only blocked > on untangling the IO port mess on other architectures (a problem Xen > doesn't have to contend with). > > MMCFG, when available is strictly preferable to IO ports. > > An MMCFG access is a single UC read or write, whereas IO ports are a > pair of UC accesses *and* a global spinlock. Right, I know it's better from a performance PoV, but didn't know whether there was some known glitches for not using MMCFG when accessing regs < 255. > >>>> > >>>> #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \ > >>>> || id == 0x01268086 || id == 0x01028086 \ > >>>> diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c > >>>> index 5da00e24e4ff..008367195c78 100644 > >>>> --- a/xen/arch/x86/pv/emul-priv-op.c > >>>> +++ b/xen/arch/x86/pv/emul-priv-op.c > >>>> @@ -245,19 +245,7 @@ static bool pci_cfg_ok(struct domain *currd, unsigned int start, > >>>> if ( ro_map && test_bit(machine_bdf, ro_map) ) > >>>> return false; > >>>> } > >>>> - start |= CF8_ADDR_LO(currd->arch.pci_cf8); > >>>> - /* AMD extended configuration space access? */ > >>>> - if ( CF8_ADDR_HI(currd->arch.pci_cf8) && > >>>> - boot_cpu_data.x86_vendor == X86_VENDOR_AMD && > >>>> - boot_cpu_data.x86 >= 0x10 && boot_cpu_data.x86 < 0x17 ) > >>>> - { > >>>> - uint64_t msr_val; > >>>> - > >>>> - if ( rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) ) > >>>> - return false; > >>>> - if ( msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT) ) > >>>> - start |= CF8_ADDR_HI(currd->arch.pci_cf8); > >>>> - } > >>>> + start |= CF8_REG(currd->arch.pci_cf8); > >>>> > >>>> return !write ? > >>>> xsm_pci_config_permission(XSM_HOOK, currd, machine_bdf, > >>>> @@ -1104,6 +1092,11 @@ static int cf_check write_msr( > >>>> if ( !is_hwdom_pinned_vcpu(curr) ) > >>>> return X86EMUL_OKAY; > >>>> if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || > >>>> + /* > >>>> + * TODO: this is broken. What happens when dom0 is pinned but > >>>> + * can't see the full system? CF8_EXT probably ought to be a > >>>> + * Xen-owned setting, and made symmetric across the system. > >>>> + */ > >>> I would assume CF8_EXT would be symmetric across the system, specially > >>> given that it seems to be phased out and only used in older AMD > >>> families that where all symmetric? > >> The CF8_EXT bit has been phased out.  The IO ECS functionality still exists. > >> > >> But yes, the more I think about letting dom0 play with this, the more I > >> think it is a fundamentally broken idea...  I bet it was from the very > >> early AMD Fam10h days where dom0 knew how to turn it on, and Xen was > >> trying to pretend it didn't have to touch any PCI devices. > > It seems to me Xen should set CF8_EXT on all threads (when available) > > and expose it to dom0, so that accesses using pci_{conf,write}_read() > > work as expected? > > It's per northbridge in the system, not per thread.  Hence needing the > spinlock protecting the CF8/CFC IO port pair access, and why MMCFG is > strictly preferable. So just setting CF8_EXT_ENABLE on MSR_AMD64_NB_CFG by the BSP should be enough to have it enabled? I expect all other threads will see the bit as set in the MSR then. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:17:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:17:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517962.804010 (Exim 4.92) (envelope-from ) id 1pjiOt-0000Nv-Fd; Tue, 04 Apr 2023 15:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517962.804010; Tue, 04 Apr 2023 15:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiOt-0000No-C2; Tue, 04 Apr 2023 15:16:47 +0000 Received: by outflank-mailman (input) for mailman id 517962; Tue, 04 Apr 2023 15:16:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiOs-0000Nf-0q for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:16:46 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20617.outbound.protection.outlook.com [2a01:111:f400:7eaf::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3e77233-d2fb-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 17:16:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9261.eurprd04.prod.outlook.com (2603:10a6:20b:4c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:16:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3e77233-d2fb-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CH2uPWiQiVsV9TncPRvS7hzOEl1A2Q8mUkrd2sgBq1kzbo6egdQP0BtG5T8v4JG9uW4fzLkGWPFShTfcu1NaSvmel6mkrHdLwjOGLLZt8ggYNLI3/jTVcqfPnSmYGhPujly6Ujyr6Yosa6BkixhiYaiBCYQTUN5IxNEh5K5xlfdbamHxMTuEsjOycUxjdLTgNe2lSjqyJFgoaXDr4vmv8pw/pfzo8QxMIuF5G26c//zuPMNJJkK5vboZWfUNFxyj2CALulm0IYi3aqTsI8SITy1T3YtSHG7L4i+SSpK0Ktm0GzdL8kdmgZwm/TTF2c70Muk4TRQQ8OPk3nD+s1TENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDVX0Pqi/OHZLe+dLA/r7Eg/rxGTpg9C2YX3gmKNGh8=; b=StenCZ3Gtz11IJSpkWb/LOkgu/T1aQ0efG20DY2svnS9Eizt1bDLeNxfQEC9gqcV+pSsFlwP/Dcix2o6z2uAJAwMstq3bHQqoiEH/dhtWRiwG/hOyReCR0zl6TkY5KnF/Nc/d8JrK2IuItxq4BSOEyaMCh91Hp7T2PwCxHgi6y7Do6DVwTxp0CmDb8da+02+oGoHA8o3/rtea52sKMA1oQMFS4jY23vlEdHZzN4262Bl5zRxP/FFLYRzR2e1q62ltHDil/V85R4M6qXe/JYOgYTW87QwNXql4tdQ+0YvtEIdV7ZijUwkCiILHaZB286br8uUp3dajEPm2OS/KLr3FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDVX0Pqi/OHZLe+dLA/r7Eg/rxGTpg9C2YX3gmKNGh8=; b=SZkiNwKLIq0i1YK/QgZVcyEzDnIugaFX2oo9iNhoRbkjSOO/MFfcjq68fIqaxcF0SeiKxLJzRnRY+Vit1bflCcRTUKA6++/EZnjsiqzMRKeWgNs/VggID4axsm9kbAIYU6+Yf8CkgreslWwzcD3AVmxNKy5DROFe7hl2uozT/07tLzkgwChLveT1j2EY+xZkxFFCdGToOG0lFMMv9jLJ/Nhg+DzkxbaT5wkDK/KBhZdk6AjEzbq6obqMnT5UBEozwsKyuXgxGdbgiO9Jjki8+f4UvsuSFQG6/F3lzOv5k4EzzAGokF4BDKDV8Y78e/bYfR0ibHZxGG8XhJ6cHRq8mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <087536dd-96cf-84f0-4b8f-d4de4d6bd093@suse.com> Date: Tue, 4 Apr 2023 17:16:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 11/15] x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-12-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-12-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9261:EE_ X-MS-Office365-Filtering-Correlation-Id: 1549535e-a323-4972-3bbc-08db351f94fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l3c98LWBBtEp2d1twKFDVihc+sOdq0gV9RvcdC0SXRccMLDyGQJoFysT0DoS+aGxcxylYJlC4t8UO7v6Y87AUq283oLpEpwBLfKp4ghzDKOK3JPDBKW25Z0kg7ZCAA4kMcwgheSIN4+bfwJqNONdlQeUS//XFu/FUZ/6SlJHHIeWJ4Q+R2f7jnDs8sWIzYUWENTk1jBPWYp7OYC1Hs491buUlrr0hdBacrrwWOgtLVd8oYlO64FKX+dsRtCnTcAMV40+KXVI1x2OG9iMk0ghF10bW7ncu2P6vBaHc6LQfPQ6ffWW0B0RvYeh8m5Qy7IEmzCXyhWEuTl8q2gP1XmUhy+mTfLpLFy1G47SBjfuWt5prUlTspFrTji1qtj5p8X5e0PESae7f3IxkcOCw3mvFVM1GONzrrXXWEOFdVTlnq5lxDBZFzmKvSl6mXBIb0Rmt/ps/vdDoA2B+2zJzV9uIbSyc99VeBXYyyCmmQBptfe17izGTjkqfF5D0g7j6HunhHXB3mm7qEcC0aSr8cw/mLwNiHxrX3VUOAURsFXpVgkt3bcCSi8899a3ULCSrJyWlBb7/2NEEsiWlsMyzSXkov7W3hgeLWlzFnTn5bIBH53JDxzqDMYrHCAsrRjNC6oSvfDW4oFavwlXjIou8f0Gz0mV+lsPs7VuyafVEtNn7uFyx1/WAMxXidXCWm02NzoS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199021)(30864003)(38100700002)(5660300002)(83380400001)(2616005)(31696002)(54906003)(316002)(36756003)(53546011)(6486002)(86362001)(186003)(6512007)(478600001)(6506007)(26005)(6916009)(66556008)(66476007)(41300700001)(4326008)(8676002)(66946007)(8936002)(31686004)(66899021)(2906002)(43740500002)(45980500001)(579004)(559001)(473944003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bldtVCtZdU03c1dKMmk2YjhLeHdpWE0wdzFsZ0dVOVJvRUxISGhnSGFjam1a?= =?utf-8?B?dXNoZnA1NDl3bkE4YjBSZC80K0lzaWJtTFJvZWRTM0ZsbXBnYVJEV2JOQUsz?= =?utf-8?B?dzBTR3Z6TDg4TnZmekRmeEEvcUYxSjhpMXducVJhWEl1b2JYdFpQZ1FtZUZT?= =?utf-8?B?c1M4WUd3eVFCeFFWRHlicWRtMUJINy9ZdEtKYWlEMFUzNGJ1S04rRkY5NnZ4?= =?utf-8?B?czBabG00cXUvOXZvN2QvUTl2clBxdlg1QzVXbkxQMXdLcjhSRHZHNk4vc2c4?= =?utf-8?B?dW9pMlNrUDZQVGR2dnk2Nlk1Y2pWVG5ORnpKNnkrYWw4eUVsUlpGTlNTTmU4?= =?utf-8?B?NENtbGpsYVNvSXNHRGRRZmZBc1dJN0RRTGJ0VGkvQmxuZzFjdkUzODJrb0ww?= =?utf-8?B?ckJkR3NHNGxRRXB0VkpWNXZPTEYwYmI0eEVRaGZVMlVBdExTUHQzVnpnTlJZ?= =?utf-8?B?MEd2a096cWE3aUFVanFuL3JqdEl4bXk5aWd3M0trc3E2V1p6dEk5dUwyd1RU?= =?utf-8?B?UllyRzRjREU0Mzl0dDdBSFhPQlhmVmcxMFZPQXMxOS9UV3NWS1VlOTUzWlNm?= =?utf-8?B?dUV5TjhLdHNhbFFPTHMwMHIvWk1RWDdjczk5T0wzV1ozNTBGdzBGRXhlcTJw?= =?utf-8?B?T1hYRXhVZkdQWFlpbUxvRk84UDczeEVKVVJWSkVXZ1BJR1h2MlVNOFhvTVhK?= =?utf-8?B?Tk1DU1h6NkhrVnk3QmNrMjVvMFlWSDFGbU5hWWpMMjZ0dlludER0eGk2Q2dV?= =?utf-8?B?R3BUK0dSYnBhakZsYkk3WEI4SUdyS1BaM1RZUkZLV1BVMThPUTMxb2NTRVVC?= =?utf-8?B?bHd4VVcrY0xaeUMyZkFPNVF4N1ZnK0RoUTRiUGZxWko0ZlFYTlBlN3dVMS9r?= =?utf-8?B?d2NFUnc5OVZRRjV1UWdNdTRNSEJ1OW1KajZaWFJselFrQVhLZTdwUG5lc1hB?= =?utf-8?B?NjRsaENGNkhkeCtYa3RhZW92REkxT0xNeEF5UHQ5ZTNsd3FybWJmbTVTUERN?= =?utf-8?B?bzBoL1JaSC9NdXlvSXpjZnQ3R3Vwa3ZIc1lyVWtndko1YThxeUhzOW9QM2Zh?= =?utf-8?B?TFFRdHA5Y0I3c0ZEWEMrZlQ1d2UzU1BWR0VWM0tnRVZFRDhubDRJMTdUempY?= =?utf-8?B?ZmFJbmQ1Rlc3VlJKR2EyUDcrbExCS1RmUVdGaHNlbFdObGh6djFXZ29ESzNB?= =?utf-8?B?WERoTzdnekJ1RUpZOHNqTlIwTmI4ZHVSMklGSjR5aENFbk01cEltQnJqZ01s?= =?utf-8?B?M3l4UzRDSW81aVhuRC9SUVBpZ245alFoTlFPZTMyQW01YmZBR0NUYjg2aTMz?= =?utf-8?B?RjZnUkF6L2E1QStCUGRYVlkvTTY4c0FLMnZnRWUyTERsbTM0L2xHdEFjVDFn?= =?utf-8?B?bjFsTU11b1pxT3RuT2xpcElyMk5WdEcwaHd3SjdiTjR2SSswY2M1Q0RNZ2U5?= =?utf-8?B?ZTlQSlFMZXc0YjFBanBETjZUbzhQMjQrOEo0dFNhaXR4QXBTdmZpeVdwMWJw?= =?utf-8?B?L2l0a3FiQlVpOUM3VFlpNE5FWFltanhpVFhqdTBtdk5QOWV1WDJWZTkrV0FZ?= =?utf-8?B?NVFsZStWdjJmejdGd0tMNitwamEvQTNwNHdYWUNITTZJUHVQblZsQVQ3MnFu?= =?utf-8?B?MDZqaVBmOFQ2TUp4eHljMVc1RDIwUHhVOTVCL0x2YWpNQjJOeE1NRVBWeG01?= =?utf-8?B?MnRsS0xlNFBVUTVmQXdGVmh1QmhxMWFPazlGZ3lsVnVWQ2xDbHhDL0UvUVZx?= =?utf-8?B?WXFGbXRZblprSUZ2UDJrYTNiNnZwdGNWMEp6YitRNURsSzJ2T3A0MnVmMExS?= =?utf-8?B?T3hUdjZLeW5qTEx5dTB4VFg4ejlUbTB3d1NjeVlyN2JqQ1Fpd0xIZVE0YVIv?= =?utf-8?B?REhOaVdMWmpCemk3VDRWR2pXTGtIR0hjNHY3RDB1dVpQT2FROTBaSVh3MCtY?= =?utf-8?B?MGh1UitySHVCd0VNYzZhT0dqNGQ0ZStwYWR0Y1piVGoxVU1WSGhKNWZVanl4?= =?utf-8?B?NTNKVm9SZlBtVUhHUDdZNnR4TEMzM08yZEJhTTFaMzFqaEVWQlFMOUdNOHVG?= =?utf-8?B?TnJkZWFHZHRVZkZZNEFTQXRHc28wVm5WcEpoMjdUeUx2VEVaRnRCOUNpMHNn?= =?utf-8?Q?pD8X3SwPg8JwwK9Dz6rc9uqV4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1549535e-a323-4972-3bbc-08db351f94fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:16:36.4754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PfJRslTDae/57uSLPY1iY5tz0xJsYpvEqWaY193iHzLQJj6nE0N+TA15Li2ebhHqhQhS7E3uw8yklpv9febKYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9261 On 04.04.2023 11:52, Andrew Cooper wrote: > Switch to the newer cpu_policy nomenclature. Do some easy cleanup of > includes. > > No practical change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > v2: > * New > --- > xen/arch/x86/cpu-policy.c | 752 ++++++++++++++++++++++++ > xen/arch/x86/cpuid.c | 817 +------------------------- > xen/arch/x86/hvm/hvm.c | 1 - > xen/arch/x86/include/asm/cpu-policy.h | 6 + > xen/arch/x86/include/asm/cpuid.h | 11 +- > xen/arch/x86/pv/domain.c | 1 + > xen/arch/x86/setup.c | 2 - > 7 files changed, 764 insertions(+), 826 deletions(-) > > diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c > index f6a2317ed7bd..83186e940ca7 100644 > --- a/xen/arch/x86/cpu-policy.c > +++ b/xen/arch/x86/cpu-policy.c > @@ -1,13 +1,19 @@ > /* SPDX-License-Identifier: GPL-2.0-or-later */ > #include > #include > +#include > #include > > #include > > +#include > #include > +#include > +#include > #include > +#include > #include > +#include > > struct cpu_policy __ro_after_init raw_cpu_policy; > struct cpu_policy __ro_after_init host_cpu_policy; > @@ -20,10 +26,332 @@ struct cpu_policy __ro_after_init hvm_max_cpu_policy; > struct cpu_policy __ro_after_init hvm_def_cpu_policy; > #endif > > +const uint32_t known_features[] = INIT_KNOWN_FEATURES; > + > +static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; > +static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; > +static const uint32_t __initconst hvm_hap_max_featuremask[] = > + INIT_HVM_HAP_MAX_FEATURES; > +static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; > +static const uint32_t __initconst hvm_shadow_def_featuremask[] = > + INIT_HVM_SHADOW_DEF_FEATURES; > +static const uint32_t __initconst hvm_hap_def_featuremask[] = > + INIT_HVM_HAP_DEF_FEATURES; > +static const uint32_t deep_features[] = INIT_DEEP_FEATURES; > + > +static const struct feature_name { > + const char *name; > + unsigned int bit; > +} feature_names[] __initconstrel = INIT_FEATURE_NAMES; > + > +/* > + * Parse a list of cpuid feature names -> bool, calling the callback for any > + * matches found. > + * > + * always_inline, because this is init code only and we really don't want a > + * function pointer call in the middle of the loop. > + */ > +static int __init always_inline parse_cpuid( > + const char *s, void (*callback)(unsigned int feat, bool val)) > +{ > + const char *ss; > + int val, rc = 0; > + > + do { > + const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; > + const char *feat; > + > + ss = strchr(s, ','); > + if ( !ss ) > + ss = strchr(s, '\0'); > + > + /* Skip the 'no-' prefix for name comparisons. */ > + feat = s; > + if ( strncmp(s, "no-", 3) == 0 ) > + feat += 3; > + > + /* (Re)initalise lhs and rhs for binary search. */ > + lhs = feature_names; > + rhs = feature_names + ARRAY_SIZE(feature_names); > + > + while ( lhs < rhs ) > + { > + int res; > + > + mid = lhs + (rhs - lhs) / 2; > + res = cmdline_strcmp(feat, mid->name); > + > + if ( res < 0 ) > + { > + rhs = mid; > + continue; > + } > + if ( res > 0 ) > + { > + lhs = mid + 1; > + continue; > + } > + > + if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) > + { > + callback(mid->bit, val); > + mid = NULL; > + } > + > + break; > + } > + > + /* > + * Mid being NULL means that the name and boolean were successfully > + * identified. Everything else is an error. > + */ > + if ( mid ) > + rc = -EINVAL; > + > + s = ss + 1; > + } while ( *ss ); > + > + return rc; > +} > + > +static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) > +{ > + if ( !val ) > + setup_clear_cpu_cap(feat); > + else if ( feat == X86_FEATURE_RDRAND && > + (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) > + setup_force_cpu_cap(X86_FEATURE_RDRAND); > +} > + > +static int __init cf_check parse_xen_cpuid(const char *s) > +{ > + return parse_cpuid(s, _parse_xen_cpuid); > +} > +custom_param("cpuid", parse_xen_cpuid); > + > +static bool __initdata dom0_cpuid_cmdline; > +static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; > +static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; > + > +static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) > +{ > + __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); > + __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); > +} > + > +static int __init cf_check parse_dom0_cpuid(const char *s) > +{ > + dom0_cpuid_cmdline = true; > + > + return parse_cpuid(s, _parse_dom0_cpuid); > +} > +custom_param("dom0-cpuid", parse_dom0_cpuid); Unless the plan is to completely remove cpuid.c, this command line handling would imo better fit there. I understand that to keep dom0_{en,dis}able_feat[] static, the _parse_dom0_cpuid() helper would then need to be exposed (under a different name), but I think that's quite okay, the more that it's an __init function. > +#define EMPTY_LEAF ((struct cpuid_leaf){}) > +static void zero_leaves(struct cpuid_leaf *l, > + unsigned int first, unsigned int last) > +{ > + memset(&l[first], 0, sizeof(*l) * (last - first + 1)); > +} > + > +static void sanitise_featureset(uint32_t *fs) > +{ > + /* for_each_set_bit() uses unsigned longs. Extend with zeroes. */ > + uint32_t disabled_features[ > + ROUNDUP(FSCAPINTS, sizeof(unsigned long)/sizeof(uint32_t))] = {}; > + unsigned int i; > + > + for ( i = 0; i < FSCAPINTS; ++i ) > + { > + /* Clamp to known mask. */ > + fs[i] &= known_features[i]; > + > + /* > + * Identify which features with deep dependencies have been > + * disabled. > + */ > + disabled_features[i] = ~fs[i] & deep_features[i]; > + } > + > + for_each_set_bit(i, (void *)disabled_features, > + sizeof(disabled_features) * 8) > + { > + const uint32_t *dfs = x86_cpuid_lookup_deep_deps(i); > + unsigned int j; > + > + ASSERT(dfs); /* deep_features[] should guarentee this. */ > + > + for ( j = 0; j < FSCAPINTS; ++j ) > + { > + fs[j] &= ~dfs[j]; > + disabled_features[j] &= ~dfs[j]; > + } > + } > +} > + > +static void recalculate_xstate(struct cpu_policy *p) > +{ > + uint64_t xstates = XSTATE_FP_SSE; > + uint32_t xstate_size = XSTATE_AREA_MIN_SIZE; > + unsigned int i, Da1 = p->xstate.Da1; > + > + /* > + * The Da1 leaf is the only piece of information preserved in the common > + * case. Everything else is derived from other feature state. > + */ > + memset(&p->xstate, 0, sizeof(p->xstate)); > + > + if ( !p->basic.xsave ) > + return; > + > + if ( p->basic.avx ) > + { > + xstates |= X86_XCR0_YMM; > + xstate_size = max(xstate_size, > + xstate_offsets[X86_XCR0_YMM_POS] + > + xstate_sizes[X86_XCR0_YMM_POS]); > + } > + > + if ( p->feat.mpx ) > + { > + xstates |= X86_XCR0_BNDREGS | X86_XCR0_BNDCSR; > + xstate_size = max(xstate_size, > + xstate_offsets[X86_XCR0_BNDCSR_POS] + > + xstate_sizes[X86_XCR0_BNDCSR_POS]); > + } > + > + if ( p->feat.avx512f ) > + { > + xstates |= X86_XCR0_OPMASK | X86_XCR0_ZMM | X86_XCR0_HI_ZMM; > + xstate_size = max(xstate_size, > + xstate_offsets[X86_XCR0_HI_ZMM_POS] + > + xstate_sizes[X86_XCR0_HI_ZMM_POS]); > + } > + > + if ( p->feat.pku ) > + { > + xstates |= X86_XCR0_PKRU; > + xstate_size = max(xstate_size, > + xstate_offsets[X86_XCR0_PKRU_POS] + > + xstate_sizes[X86_XCR0_PKRU_POS]); > + } > + > + p->xstate.max_size = xstate_size; > + p->xstate.xcr0_low = xstates & ~XSTATE_XSAVES_ONLY; > + p->xstate.xcr0_high = (xstates & ~XSTATE_XSAVES_ONLY) >> 32; > + > + p->xstate.Da1 = Da1; > + if ( p->xstate.xsaves ) > + { > + p->xstate.xss_low = xstates & XSTATE_XSAVES_ONLY; > + p->xstate.xss_high = (xstates & XSTATE_XSAVES_ONLY) >> 32; > + } > + else > + xstates &= ~XSTATE_XSAVES_ONLY; > + > + for ( i = 2; i < min(63ul, ARRAY_SIZE(p->xstate.comp)); ++i ) > + { > + uint64_t curr_xstate = 1ul << i; > + > + if ( !(xstates & curr_xstate) ) > + continue; > + > + p->xstate.comp[i].size = xstate_sizes[i]; > + p->xstate.comp[i].offset = xstate_offsets[i]; > + p->xstate.comp[i].xss = curr_xstate & XSTATE_XSAVES_ONLY; > + p->xstate.comp[i].align = curr_xstate & xstate_align; > + } > +} > + > +/* > + * Misc adjustments to the policy. Mostly clobbering reserved fields and > + * duplicating shared fields. Intentionally hidden fields are annotated. > + */ > +static void recalculate_misc(struct cpu_policy *p) > +{ > + p->basic.raw_fms &= 0x0fff0fff; /* Clobber Processor Type on Intel. */ > + p->basic.apic_id = 0; /* Dynamic. */ > + > + p->basic.raw[0x5] = EMPTY_LEAF; /* MONITOR not exposed to guests. */ > + p->basic.raw[0x6] = EMPTY_LEAF; /* Therm/Power not exposed to guests. */ > + > + p->basic.raw[0x8] = EMPTY_LEAF; > + > + /* TODO: Rework topology logic. */ > + memset(p->topo.raw, 0, sizeof(p->topo.raw)); > + > + p->basic.raw[0xc] = EMPTY_LEAF; > + > + p->extd.e1d &= ~CPUID_COMMON_1D_FEATURES; > + > + /* Most of Power/RAS hidden from guests. */ > + p->extd.raw[0x7].a = p->extd.raw[0x7].b = p->extd.raw[0x7].c = 0; > + > + p->extd.raw[0x8].d = 0; > + > + switch ( p->x86_vendor ) > + { > + case X86_VENDOR_INTEL: > + p->basic.l2_nr_queries = 1; /* Fixed to 1 query. */ > + p->basic.raw[0x3] = EMPTY_LEAF; /* PSN - always hidden. */ > + p->basic.raw[0x9] = EMPTY_LEAF; /* DCA - always hidden. */ > + > + p->extd.vendor_ebx = 0; > + p->extd.vendor_ecx = 0; > + p->extd.vendor_edx = 0; > + > + p->extd.raw[0x1].a = p->extd.raw[0x1].b = 0; > + > + p->extd.raw[0x5] = EMPTY_LEAF; > + p->extd.raw[0x6].a = p->extd.raw[0x6].b = p->extd.raw[0x6].d = 0; > + > + p->extd.raw[0x8].a &= 0x0000ffff; > + p->extd.raw[0x8].c = 0; > + break; > + > + case X86_VENDOR_AMD: > + case X86_VENDOR_HYGON: > + zero_leaves(p->basic.raw, 0x2, 0x3); > + memset(p->cache.raw, 0, sizeof(p->cache.raw)); > + zero_leaves(p->basic.raw, 0x9, 0xa); > + > + p->extd.vendor_ebx = p->basic.vendor_ebx; > + p->extd.vendor_ecx = p->basic.vendor_ecx; > + p->extd.vendor_edx = p->basic.vendor_edx; > + > + p->extd.raw_fms = p->basic.raw_fms; > + p->extd.raw[0x1].b &= 0xff00ffff; > + p->extd.e1d |= p->basic._1d & CPUID_COMMON_1D_FEATURES; > + > + p->extd.raw[0x8].a &= 0x0000ffff; /* GuestMaxPhysAddr hidden. */ > + p->extd.raw[0x8].c &= 0x0003f0ff; > + > + p->extd.raw[0x9] = EMPTY_LEAF; > + > + zero_leaves(p->extd.raw, 0xb, 0x18); > + > + /* 0x19 - TLB details. Pass through. */ > + /* 0x1a - Perf hints. Pass through. */ > + > + p->extd.raw[0x1b] = EMPTY_LEAF; /* IBS - not supported. */ > + p->extd.raw[0x1c] = EMPTY_LEAF; /* LWP - not supported. */ > + p->extd.raw[0x1d] = EMPTY_LEAF; /* TopoExt Cache */ > + p->extd.raw[0x1e] = EMPTY_LEAF; /* TopoExt APIC ID/Core/Node */ > + p->extd.raw[0x1f] = EMPTY_LEAF; /* SEV */ > + p->extd.raw[0x20] = EMPTY_LEAF; /* Platform QoS */ > + break; > + } > +} > + > static void __init calculate_raw_policy(void) > { > struct cpu_policy *p = &raw_cpu_policy; > > + x86_cpuid_policy_fill_native(p); > + > + /* Nothing good will come from Xen and libx86 disagreeing on vendor. */ > + ASSERT(p->x86_vendor == boot_cpu_data.x86_vendor); > + > /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ > /* Was already added by probe_cpuid_faulting() */ > > @@ -34,9 +362,50 @@ static void __init calculate_raw_policy(void) > static void __init calculate_host_policy(void) > { > struct cpu_policy *p = &host_cpu_policy; > + unsigned int max_extd_leaf; > > *p = raw_cpu_policy; > > + p->basic.max_leaf = > + min_t(uint32_t, p->basic.max_leaf, ARRAY_SIZE(p->basic.raw) - 1); > + p->feat.max_subleaf = > + min_t(uint32_t, p->feat.max_subleaf, ARRAY_SIZE(p->feat.raw) - 1); > + > + max_extd_leaf = p->extd.max_leaf; > + > + /* > + * For AMD/Hygon hardware before Zen3, we unilaterally modify LFENCE to be > + * dispatch serialising for Spectre mitigations. Extend max_extd_leaf > + * beyond what hardware supports, to include the feature leaf containing > + * this information. > + */ > + if ( cpu_has_lfence_dispatch ) > + max_extd_leaf = max(max_extd_leaf, 0x80000021); > + > + p->extd.max_leaf = 0x80000000 | min_t(uint32_t, max_extd_leaf & 0xffff, > + ARRAY_SIZE(p->extd.raw) - 1); > + > + x86_cpu_featureset_to_policy(boot_cpu_data.x86_capability, p); > + recalculate_xstate(p); > + recalculate_misc(p); > + > + /* When vPMU is disabled, drop it from the host policy. */ > + if ( vpmu_mode == XENPMU_MODE_OFF ) > + p->basic.raw[0xa] = EMPTY_LEAF; > + > + if ( p->extd.svm ) > + { > + /* Clamp to implemented features which require hardware support. */ > + p->extd.raw[0xa].d &= ((1u << SVM_FEATURE_NPT) | > + (1u << SVM_FEATURE_LBRV) | > + (1u << SVM_FEATURE_NRIPS) | > + (1u << SVM_FEATURE_PAUSEFILTER) | > + (1u << SVM_FEATURE_DECODEASSISTS)); > + /* Enable features which are always emulated. */ > + p->extd.raw[0xa].d |= ((1u << SVM_FEATURE_VMCBCLEAN) | > + (1u << SVM_FEATURE_TSCRATEMSR)); > + } > + > /* 0x000000ce MSR_INTEL_PLATFORM_INFO */ > /* probe_cpuid_faulting() sanity checks presence of MISC_FEATURES_ENABLES */ > p->platform_info.cpuid_faulting = cpu_has_cpuid_faulting; > @@ -51,11 +420,88 @@ static void __init calculate_host_policy(void) > ARCH_CAPS_PBRSB_NO); > } > > +static void __init guest_common_default_feature_adjustments(uint32_t *fs) > +{ > + /* > + * IvyBridge client parts suffer from leakage of RDRAND data due to SRBDS > + * (XSA-320 / CVE-2020-0543), and won't be receiving microcode to > + * compensate. > + * > + * Mitigate by hiding RDRAND from guests by default, unless explicitly > + * overridden on the Xen command line (cpuid=rdrand). Irrespective of the > + * default setting, guests can use RDRAND if explicitly enabled > + * (cpuid="host,rdrand=1") in the VM's config file, and VMs which were > + * previously using RDRAND can migrate in. > + */ > + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && > + boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x3a && > + cpu_has_rdrand && !is_forced_cpu_cap(X86_FEATURE_RDRAND) ) > + __clear_bit(X86_FEATURE_RDRAND, fs); > + > + /* > + * On certain hardware, speculative or errata workarounds can result in > + * TSX being placed in "force-abort" mode, where it doesn't actually > + * function as expected, but is technically compatible with the ISA. > + * > + * Do not advertise RTM to guests by default if it won't actually work. > + */ > + if ( rtm_disabled ) > + __clear_bit(X86_FEATURE_RTM, fs); > +} > + > +static void __init guest_common_feature_adjustments(uint32_t *fs) > +{ > + /* Unconditionally claim to be able to set the hypervisor bit. */ > + __set_bit(X86_FEATURE_HYPERVISOR, fs); > + > + /* > + * If IBRS is offered to the guest, unconditionally offer STIBP. It is a > + * nop on non-HT hardware, and has this behaviour to make heterogeneous > + * setups easier to manage. > + */ > + if ( test_bit(X86_FEATURE_IBRSB, fs) ) > + __set_bit(X86_FEATURE_STIBP, fs); > + if ( test_bit(X86_FEATURE_IBRS, fs) ) > + __set_bit(X86_FEATURE_AMD_STIBP, fs); > + > + /* > + * On hardware which supports IBRS/IBPB, we can offer IBPB independently > + * of IBRS by using the AMD feature bit. An administrator may wish for > + * performance reasons to offer IBPB without IBRS. > + */ > + if ( host_cpu_policy.feat.ibrsb ) > + __set_bit(X86_FEATURE_IBPB, fs); > +} > + > static void __init calculate_pv_max_policy(void) > { > struct cpu_policy *p = &pv_max_cpu_policy; > + uint32_t fs[FSCAPINTS]; > + unsigned int i; > > *p = host_cpu_policy; > + x86_cpu_policy_to_featureset(p, fs); > + > + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) > + fs[i] &= pv_max_featuremask[i]; > + > + /* > + * If Xen isn't virtualising MSR_SPEC_CTRL for PV guests (functional > + * availability, or admin choice), hide the feature. > + */ > + if ( !boot_cpu_has(X86_FEATURE_SC_MSR_PV) ) > + { > + __clear_bit(X86_FEATURE_IBRSB, fs); > + __clear_bit(X86_FEATURE_IBRS, fs); > + } > + > + guest_common_feature_adjustments(fs); > + > + sanitise_featureset(fs); > + x86_cpu_featureset_to_policy(fs, p); > + recalculate_xstate(p); > + > + p->extd.raw[0xa] = EMPTY_LEAF; /* No SVM for PV guests. */ > > p->arch_caps.raw = 0; /* Not supported yet. */ > } > @@ -63,15 +509,112 @@ static void __init calculate_pv_max_policy(void) > static void __init calculate_pv_def_policy(void) > { > struct cpu_policy *p = &pv_def_cpu_policy; > + uint32_t fs[FSCAPINTS]; > + unsigned int i; > > *p = pv_max_cpu_policy; > + x86_cpu_policy_to_featureset(p, fs); > + > + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) > + fs[i] &= pv_def_featuremask[i]; > + > + guest_common_feature_adjustments(fs); > + guest_common_default_feature_adjustments(fs); > + > + sanitise_featureset(fs); > + x86_cpu_featureset_to_policy(fs, p); > + recalculate_xstate(p); > } > > static void __init calculate_hvm_max_policy(void) > { > struct cpu_policy *p = &hvm_max_cpu_policy; > + uint32_t fs[FSCAPINTS]; > + unsigned int i; > + const uint32_t *mask; > > *p = host_cpu_policy; > + x86_cpu_policy_to_featureset(p, fs); > + > + mask = hvm_hap_supported() ? > + hvm_hap_max_featuremask : hvm_shadow_max_featuremask; > + > + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) > + fs[i] &= mask[i]; > + > + /* > + * Xen can provide an (x2)APIC emulation to HVM guests even if the host's > + * (x2)APIC isn't enabled. > + */ > + __set_bit(X86_FEATURE_APIC, fs); > + __set_bit(X86_FEATURE_X2APIC, fs); > + > + /* > + * We don't support EFER.LMSLE at all. AMD has dropped the feature from > + * hardware and allocated a CPUID bit to indicate its absence. > + */ > + __set_bit(X86_FEATURE_NO_LMSL, fs); > + > + /* > + * On AMD, PV guests are entirely unable to use SYSENTER as Xen runs in > + * long mode (and init_amd() has cleared it out of host capabilities), but > + * HVM guests are able if running in protected mode. > + */ > + if ( (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) && > + raw_cpu_policy.basic.sep ) > + __set_bit(X86_FEATURE_SEP, fs); > + > + /* > + * VIRT_SSBD is exposed in the default policy as a result of > + * amd_virt_spec_ctrl being set, it also needs exposing in the max policy. > + */ > + if ( amd_virt_spec_ctrl ) > + __set_bit(X86_FEATURE_VIRT_SSBD, fs); > + > + /* > + * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional > + * availability, or admin choice), hide the feature. > + */ > + if ( !boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ) > + { > + __clear_bit(X86_FEATURE_IBRSB, fs); > + __clear_bit(X86_FEATURE_IBRS, fs); > + } > + else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ) > + /* > + * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed > + * and implemented using the former. Expose in the max policy only as > + * the preference is for guests to use SPEC_CTRL.SSBD if available. > + */ > + __set_bit(X86_FEATURE_VIRT_SSBD, fs); > + > + /* > + * With VT-x, some features are only supported by Xen if dedicated > + * hardware support is also available. > + */ > + if ( cpu_has_vmx ) > + { > + if ( !cpu_has_vmx_mpx ) > + __clear_bit(X86_FEATURE_MPX, fs); > + > + if ( !cpu_has_vmx_xsaves ) > + __clear_bit(X86_FEATURE_XSAVES, fs); > + } > + > + /* > + * Xen doesn't use PKS, so the guest support for it has opted to not use > + * the VMCS load/save controls for efficiency reasons. This depends on > + * the exact vmentry/exit behaviour, so don't expose PKS in other > + * situations until someone has cross-checked the behaviour for safety. > + */ > + if ( !cpu_has_vmx ) > + __clear_bit(X86_FEATURE_PKS, fs); > + > + guest_common_feature_adjustments(fs); > + > + sanitise_featureset(fs); > + x86_cpu_featureset_to_policy(fs, p); > + recalculate_xstate(p); > > /* It's always possible to emulate CPUID faulting for HVM guests */ > p->platform_info.cpuid_faulting = true; > @@ -82,8 +625,32 @@ static void __init calculate_hvm_max_policy(void) > static void __init calculate_hvm_def_policy(void) > { > struct cpu_policy *p = &hvm_def_cpu_policy; > + uint32_t fs[FSCAPINTS]; > + unsigned int i; > + const uint32_t *mask; > > *p = hvm_max_cpu_policy; > + x86_cpu_policy_to_featureset(p, fs); > + > + mask = hvm_hap_supported() ? > + hvm_hap_def_featuremask : hvm_shadow_def_featuremask; > + > + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) > + fs[i] &= mask[i]; > + > + guest_common_feature_adjustments(fs); > + guest_common_default_feature_adjustments(fs); > + > + /* > + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus > + * amd_virt_spec_ctrl is set. > + */ > + if ( amd_virt_spec_ctrl ) > + __set_bit(X86_FEATURE_VIRT_SSBD, fs); > + > + sanitise_featureset(fs); > + x86_cpu_featureset_to_policy(fs, p); > + recalculate_xstate(p); > } > > void __init init_guest_cpu_policies(void) > @@ -149,3 +716,188 @@ int init_domain_cpu_policy(struct domain *d) > > return 0; > } > + > +void recalculate_cpuid_policy(struct domain *d) > +{ > + struct cpu_policy *p = d->arch.cpuid; > + const struct cpu_policy *max = is_pv_domain(d) > + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) > + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); While this is how the original code was, wouldn't this want to use hvm_enabled, just like init_guest_cpu_policies() does (patch 10)? > + uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS]; > + unsigned int i; > + > + if ( !max ) > + { > + ASSERT_UNREACHABLE(); > + return; > + } > + > + p->x86_vendor = x86_cpuid_lookup_vendor( > + p->basic.vendor_ebx, p->basic.vendor_ecx, p->basic.vendor_edx); > + > + p->basic.max_leaf = min(p->basic.max_leaf, max->basic.max_leaf); > + p->feat.max_subleaf = min(p->feat.max_subleaf, max->feat.max_subleaf); > + p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff, > + ((p->x86_vendor & (X86_VENDOR_AMD | > + X86_VENDOR_HYGON)) > + ? CPUID_GUEST_NR_EXTD_AMD > + : CPUID_GUEST_NR_EXTD_INTEL) - 1); > + > + x86_cpu_policy_to_featureset(p, fs); > + x86_cpu_policy_to_featureset(max, max_fs); > + > + if ( is_hvm_domain(d) ) > + { > + /* > + * HVM domains using Shadow paging have further restrictions on their > + * available paging features. > + */ > + if ( !hap_enabled(d) ) > + { > + for ( i = 0; i < ARRAY_SIZE(max_fs); i++ ) > + max_fs[i] &= hvm_shadow_max_featuremask[i]; > + } > + > + /* Hide nested-virt if it hasn't been explicitly configured. */ > + if ( !nestedhvm_enabled(d) ) > + { > + __clear_bit(X86_FEATURE_VMX, max_fs); > + __clear_bit(X86_FEATURE_SVM, max_fs); > + } > + } > + > + /* > + * Allow the toolstack to set HTT, X2APIC and CMP_LEGACY. These bits > + * affect how to interpret topology information in other cpuid leaves. > + */ > + __set_bit(X86_FEATURE_HTT, max_fs); > + __set_bit(X86_FEATURE_X2APIC, max_fs); > + __set_bit(X86_FEATURE_CMP_LEGACY, max_fs); > + > + /* > + * 32bit PV domains can't use any Long Mode features, and cannot use > + * SYSCALL on non-AMD hardware. > + */ > + if ( is_pv_32bit_domain(d) ) > + { > + __clear_bit(X86_FEATURE_LM, max_fs); > + if ( !(boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) > + __clear_bit(X86_FEATURE_SYSCALL, max_fs); > + } > + > + /* Clamp the toolstacks choices to reality. */ > + for ( i = 0; i < ARRAY_SIZE(fs); i++ ) > + fs[i] &= max_fs[i]; > + > + if ( p->basic.max_leaf < XSTATE_CPUID ) > + __clear_bit(X86_FEATURE_XSAVE, fs); > + > + sanitise_featureset(fs); > + > + /* Fold host's FDP_EXCP_ONLY and NO_FPU_SEL into guest's view. */ > + fs[FEATURESET_7b0] &= ~(cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | > + cpufeat_mask(X86_FEATURE_NO_FPU_SEL)); > + fs[FEATURESET_7b0] |= (host_cpu_policy.feat._7b0 & > + (cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | > + cpufeat_mask(X86_FEATURE_NO_FPU_SEL))); > + > + x86_cpu_featureset_to_policy(fs, p); > + > + /* Pass host cacheline size through to guests. */ > + p->basic.clflush_size = max->basic.clflush_size; > + > + p->extd.maxphysaddr = min(p->extd.maxphysaddr, max->extd.maxphysaddr); > + p->extd.maxphysaddr = min_t(uint8_t, p->extd.maxphysaddr, > + paging_max_paddr_bits(d)); > + p->extd.maxphysaddr = max_t(uint8_t, p->extd.maxphysaddr, > + (p->basic.pae || p->basic.pse36) ? 36 : 32); > + > + p->extd.maxlinaddr = p->extd.lm ? 48 : 32; > + > + recalculate_xstate(p); > + recalculate_misc(p); > + > + for ( i = 0; i < ARRAY_SIZE(p->cache.raw); ++i ) > + { > + if ( p->cache.subleaf[i].type >= 1 && > + p->cache.subleaf[i].type <= 3 ) > + { > + /* Subleaf has a valid cache type. Zero reserved fields. */ > + p->cache.raw[i].a &= 0xffffc3ffu; > + p->cache.raw[i].d &= 0x00000007u; > + } > + else > + { > + /* Subleaf is not valid. Zero the rest of the union. */ > + zero_leaves(p->cache.raw, i, ARRAY_SIZE(p->cache.raw) - 1); > + break; > + } > + } > + > + if ( vpmu_mode == XENPMU_MODE_OFF || > + ((vpmu_mode & XENPMU_MODE_ALL) && !is_hardware_domain(d)) ) > + p->basic.raw[0xa] = EMPTY_LEAF; > + > + if ( !p->extd.svm ) > + p->extd.raw[0xa] = EMPTY_LEAF; > + > + if ( !p->extd.page1gb ) > + p->extd.raw[0x19] = EMPTY_LEAF; > +} > + > +void __init init_dom0_cpuid_policy(struct domain *d) > +{ > + struct cpu_policy *p = d->arch.cpuid; > + > + /* dom0 can't migrate. Give it ITSC if available. */ > + if ( cpu_has_itsc ) > + p->extd.itsc = true; > + > + /* > + * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0, > + * so dom0 can turn off workarounds as appropriate. Temporary, until the > + * domain policy logic gains a better understanding of MSRs. > + */ > + if ( cpu_has_arch_caps ) > + p->feat.arch_caps = true; > + > + /* Apply dom0-cpuid= command line settings, if provided. */ > + if ( dom0_cpuid_cmdline ) > + { > + uint32_t fs[FSCAPINTS]; > + unsigned int i; > + > + x86_cpu_policy_to_featureset(p, fs); > + > + for ( i = 0; i < ARRAY_SIZE(fs); ++i ) > + { > + fs[i] |= dom0_enable_feat [i]; > + fs[i] &= ~dom0_disable_feat[i]; > + } > + > + x86_cpu_featureset_to_policy(fs, p); > + > + recalculate_cpuid_policy(d); > + } > +} > + > +static void __init __maybe_unused build_assertions(void) > +{ > + BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); > + BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); > + BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); > + BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); > + BUILD_BUG_ON(ARRAY_SIZE(deep_features) != FSCAPINTS); > + > + /* Find some more clever allocation scheme if this trips. */ > + BUILD_BUG_ON(sizeof(struct cpu_policy) > PAGE_SIZE); > + > + BUILD_BUG_ON(sizeof(raw_cpu_policy.basic) != > + sizeof(raw_cpu_policy.basic.raw)); > + BUILD_BUG_ON(sizeof(raw_cpu_policy.feat) != > + sizeof(raw_cpu_policy.feat.raw)); > + BUILD_BUG_ON(sizeof(raw_cpu_policy.xstate) != > + sizeof(raw_cpu_policy.xstate.raw)); > + BUILD_BUG_ON(sizeof(raw_cpu_policy.extd) != > + sizeof(raw_cpu_policy.extd.raw)); > +} > diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c > index 5eb5f1893516..3f20c342fde8 100644 > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -1,638 +1,14 @@ > -#include > -#include > -#include > #include > -#include > -#include > +#include > + > +#include > + > #include > #include > -#include > -#include > -#include > #include > -#include > -#include > -#include > #include > > -const uint32_t known_features[] = INIT_KNOWN_FEATURES; > - > -static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; > -static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; > -static const uint32_t __initconst hvm_hap_max_featuremask[] = > - INIT_HVM_HAP_MAX_FEATURES; > -static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; > -static const uint32_t __initconst hvm_shadow_def_featuremask[] = > - INIT_HVM_SHADOW_DEF_FEATURES; > -static const uint32_t __initconst hvm_hap_def_featuremask[] = > - INIT_HVM_HAP_DEF_FEATURES; > -static const uint32_t deep_features[] = INIT_DEEP_FEATURES; > - > -static const struct feature_name { > - const char *name; > - unsigned int bit; > -} feature_names[] __initconstrel = INIT_FEATURE_NAMES; > - > -/* > - * Parse a list of cpuid feature names -> bool, calling the callback for any > - * matches found. > - * > - * always_inline, because this is init code only and we really don't want a > - * function pointer call in the middle of the loop. > - */ > -static int __init always_inline parse_cpuid( > - const char *s, void (*callback)(unsigned int feat, bool val)) > -{ > - const char *ss; > - int val, rc = 0; > - > - do { > - const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; > - const char *feat; > - > - ss = strchr(s, ','); > - if ( !ss ) > - ss = strchr(s, '\0'); > - > - /* Skip the 'no-' prefix for name comparisons. */ > - feat = s; > - if ( strncmp(s, "no-", 3) == 0 ) > - feat += 3; > - > - /* (Re)initalise lhs and rhs for binary search. */ > - lhs = feature_names; > - rhs = feature_names + ARRAY_SIZE(feature_names); > - > - while ( lhs < rhs ) > - { > - int res; > - > - mid = lhs + (rhs - lhs) / 2; > - res = cmdline_strcmp(feat, mid->name); > - > - if ( res < 0 ) > - { > - rhs = mid; > - continue; > - } > - if ( res > 0 ) > - { > - lhs = mid + 1; > - continue; > - } > - > - if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) > - { > - callback(mid->bit, val); > - mid = NULL; > - } > - > - break; > - } > - > - /* > - * Mid being NULL means that the name and boolean were successfully > - * identified. Everything else is an error. > - */ > - if ( mid ) > - rc = -EINVAL; > - > - s = ss + 1; > - } while ( *ss ); > - > - return rc; > -} > - > -static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) > -{ > - if ( !val ) > - setup_clear_cpu_cap(feat); > - else if ( feat == X86_FEATURE_RDRAND && > - (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) > - setup_force_cpu_cap(X86_FEATURE_RDRAND); > -} > - > -static int __init cf_check parse_xen_cpuid(const char *s) > -{ > - return parse_cpuid(s, _parse_xen_cpuid); > -} > -custom_param("cpuid", parse_xen_cpuid); > - > -static bool __initdata dom0_cpuid_cmdline; > -static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; > -static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; > - > -static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) > -{ > - __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); > - __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); > -} > - > -static int __init cf_check parse_dom0_cpuid(const char *s) > -{ > - dom0_cpuid_cmdline = true; > - > - return parse_cpuid(s, _parse_dom0_cpuid); > -} > -custom_param("dom0-cpuid", parse_dom0_cpuid); > - > #define EMPTY_LEAF ((struct cpuid_leaf){}) > -static void zero_leaves(struct cpuid_leaf *l, > - unsigned int first, unsigned int last) > -{ > - memset(&l[first], 0, sizeof(*l) * (last - first + 1)); > -} > - > -static void sanitise_featureset(uint32_t *fs) > -{ > - /* for_each_set_bit() uses unsigned longs. Extend with zeroes. */ > - uint32_t disabled_features[ > - ROUNDUP(FSCAPINTS, sizeof(unsigned long)/sizeof(uint32_t))] = {}; > - unsigned int i; > - > - for ( i = 0; i < FSCAPINTS; ++i ) > - { > - /* Clamp to known mask. */ > - fs[i] &= known_features[i]; > - > - /* > - * Identify which features with deep dependencies have been > - * disabled. > - */ > - disabled_features[i] = ~fs[i] & deep_features[i]; > - } > - > - for_each_set_bit(i, (void *)disabled_features, > - sizeof(disabled_features) * 8) > - { > - const uint32_t *dfs = x86_cpuid_lookup_deep_deps(i); > - unsigned int j; > - > - ASSERT(dfs); /* deep_features[] should guarentee this. */ > - > - for ( j = 0; j < FSCAPINTS; ++j ) > - { > - fs[j] &= ~dfs[j]; > - disabled_features[j] &= ~dfs[j]; > - } > - } > -} > - > -static void recalculate_xstate(struct cpuid_policy *p) > -{ > - uint64_t xstates = XSTATE_FP_SSE; > - uint32_t xstate_size = XSTATE_AREA_MIN_SIZE; > - unsigned int i, Da1 = p->xstate.Da1; > - > - /* > - * The Da1 leaf is the only piece of information preserved in the common > - * case. Everything else is derived from other feature state. > - */ > - memset(&p->xstate, 0, sizeof(p->xstate)); > - > - if ( !p->basic.xsave ) > - return; > - > - if ( p->basic.avx ) > - { > - xstates |= X86_XCR0_YMM; > - xstate_size = max(xstate_size, > - xstate_offsets[X86_XCR0_YMM_POS] + > - xstate_sizes[X86_XCR0_YMM_POS]); > - } > - > - if ( p->feat.mpx ) > - { > - xstates |= X86_XCR0_BNDREGS | X86_XCR0_BNDCSR; > - xstate_size = max(xstate_size, > - xstate_offsets[X86_XCR0_BNDCSR_POS] + > - xstate_sizes[X86_XCR0_BNDCSR_POS]); > - } > - > - if ( p->feat.avx512f ) > - { > - xstates |= X86_XCR0_OPMASK | X86_XCR0_ZMM | X86_XCR0_HI_ZMM; > - xstate_size = max(xstate_size, > - xstate_offsets[X86_XCR0_HI_ZMM_POS] + > - xstate_sizes[X86_XCR0_HI_ZMM_POS]); > - } > - > - if ( p->feat.pku ) > - { > - xstates |= X86_XCR0_PKRU; > - xstate_size = max(xstate_size, > - xstate_offsets[X86_XCR0_PKRU_POS] + > - xstate_sizes[X86_XCR0_PKRU_POS]); > - } > - > - p->xstate.max_size = xstate_size; > - p->xstate.xcr0_low = xstates & ~XSTATE_XSAVES_ONLY; > - p->xstate.xcr0_high = (xstates & ~XSTATE_XSAVES_ONLY) >> 32; > - > - p->xstate.Da1 = Da1; > - if ( p->xstate.xsaves ) > - { > - p->xstate.xss_low = xstates & XSTATE_XSAVES_ONLY; > - p->xstate.xss_high = (xstates & XSTATE_XSAVES_ONLY) >> 32; > - } > - else > - xstates &= ~XSTATE_XSAVES_ONLY; > - > - for ( i = 2; i < min(63ul, ARRAY_SIZE(p->xstate.comp)); ++i ) > - { > - uint64_t curr_xstate = 1ul << i; > - > - if ( !(xstates & curr_xstate) ) > - continue; > - > - p->xstate.comp[i].size = xstate_sizes[i]; > - p->xstate.comp[i].offset = xstate_offsets[i]; > - p->xstate.comp[i].xss = curr_xstate & XSTATE_XSAVES_ONLY; > - p->xstate.comp[i].align = curr_xstate & xstate_align; > - } > -} > - > -/* > - * Misc adjustments to the policy. Mostly clobbering reserved fields and > - * duplicating shared fields. Intentionally hidden fields are annotated. > - */ > -static void recalculate_misc(struct cpuid_policy *p) > -{ > - p->basic.raw_fms &= 0x0fff0fff; /* Clobber Processor Type on Intel. */ > - p->basic.apic_id = 0; /* Dynamic. */ > - > - p->basic.raw[0x5] = EMPTY_LEAF; /* MONITOR not exposed to guests. */ > - p->basic.raw[0x6] = EMPTY_LEAF; /* Therm/Power not exposed to guests. */ > - > - p->basic.raw[0x8] = EMPTY_LEAF; > - > - /* TODO: Rework topology logic. */ > - memset(p->topo.raw, 0, sizeof(p->topo.raw)); > - > - p->basic.raw[0xc] = EMPTY_LEAF; > - > - p->extd.e1d &= ~CPUID_COMMON_1D_FEATURES; > - > - /* Most of Power/RAS hidden from guests. */ > - p->extd.raw[0x7].a = p->extd.raw[0x7].b = p->extd.raw[0x7].c = 0; > - > - p->extd.raw[0x8].d = 0; > - > - switch ( p->x86_vendor ) > - { > - case X86_VENDOR_INTEL: > - p->basic.l2_nr_queries = 1; /* Fixed to 1 query. */ > - p->basic.raw[0x3] = EMPTY_LEAF; /* PSN - always hidden. */ > - p->basic.raw[0x9] = EMPTY_LEAF; /* DCA - always hidden. */ > - > - p->extd.vendor_ebx = 0; > - p->extd.vendor_ecx = 0; > - p->extd.vendor_edx = 0; > - > - p->extd.raw[0x1].a = p->extd.raw[0x1].b = 0; > - > - p->extd.raw[0x5] = EMPTY_LEAF; > - p->extd.raw[0x6].a = p->extd.raw[0x6].b = p->extd.raw[0x6].d = 0; > - > - p->extd.raw[0x8].a &= 0x0000ffff; > - p->extd.raw[0x8].c = 0; > - break; > - > - case X86_VENDOR_AMD: > - case X86_VENDOR_HYGON: > - zero_leaves(p->basic.raw, 0x2, 0x3); > - memset(p->cache.raw, 0, sizeof(p->cache.raw)); > - zero_leaves(p->basic.raw, 0x9, 0xa); > - > - p->extd.vendor_ebx = p->basic.vendor_ebx; > - p->extd.vendor_ecx = p->basic.vendor_ecx; > - p->extd.vendor_edx = p->basic.vendor_edx; > - > - p->extd.raw_fms = p->basic.raw_fms; > - p->extd.raw[0x1].b &= 0xff00ffff; > - p->extd.e1d |= p->basic._1d & CPUID_COMMON_1D_FEATURES; > - > - p->extd.raw[0x8].a &= 0x0000ffff; /* GuestMaxPhysAddr hidden. */ > - p->extd.raw[0x8].c &= 0x0003f0ff; > - > - p->extd.raw[0x9] = EMPTY_LEAF; > - > - zero_leaves(p->extd.raw, 0xb, 0x18); > - > - /* 0x19 - TLB details. Pass through. */ > - /* 0x1a - Perf hints. Pass through. */ > - > - p->extd.raw[0x1b] = EMPTY_LEAF; /* IBS - not supported. */ > - p->extd.raw[0x1c] = EMPTY_LEAF; /* LWP - not supported. */ > - p->extd.raw[0x1d] = EMPTY_LEAF; /* TopoExt Cache */ > - p->extd.raw[0x1e] = EMPTY_LEAF; /* TopoExt APIC ID/Core/Node */ > - p->extd.raw[0x1f] = EMPTY_LEAF; /* SEV */ > - p->extd.raw[0x20] = EMPTY_LEAF; /* Platform QoS */ > - break; > - } > -} > - > -static void __init calculate_raw_policy(void) > -{ > - struct cpuid_policy *p = &raw_cpu_policy; > - > - x86_cpuid_policy_fill_native(p); > - > - /* Nothing good will come from Xen and libx86 disagreeing on vendor. */ > - ASSERT(p->x86_vendor == boot_cpu_data.x86_vendor); > -} > - > -static void __init calculate_host_policy(void) > -{ > - struct cpuid_policy *p = &host_cpu_policy; > - unsigned int max_extd_leaf; > - > - *p = raw_cpu_policy; > - > - p->basic.max_leaf = > - min_t(uint32_t, p->basic.max_leaf, ARRAY_SIZE(p->basic.raw) - 1); > - p->feat.max_subleaf = > - min_t(uint32_t, p->feat.max_subleaf, ARRAY_SIZE(p->feat.raw) - 1); > - > - max_extd_leaf = p->extd.max_leaf; > - > - /* > - * For AMD/Hygon hardware before Zen3, we unilaterally modify LFENCE to be > - * dispatch serialising for Spectre mitigations. Extend max_extd_leaf > - * beyond what hardware supports, to include the feature leaf containing > - * this information. > - */ > - if ( cpu_has_lfence_dispatch ) > - max_extd_leaf = max(max_extd_leaf, 0x80000021); > - > - p->extd.max_leaf = 0x80000000 | min_t(uint32_t, max_extd_leaf & 0xffff, > - ARRAY_SIZE(p->extd.raw) - 1); > - > - x86_cpu_featureset_to_policy(boot_cpu_data.x86_capability, p); > - recalculate_xstate(p); > - recalculate_misc(p); > - > - /* When vPMU is disabled, drop it from the host policy. */ > - if ( vpmu_mode == XENPMU_MODE_OFF ) > - p->basic.raw[0xa] = EMPTY_LEAF; > - > - if ( p->extd.svm ) > - { > - /* Clamp to implemented features which require hardware support. */ > - p->extd.raw[0xa].d &= ((1u << SVM_FEATURE_NPT) | > - (1u << SVM_FEATURE_LBRV) | > - (1u << SVM_FEATURE_NRIPS) | > - (1u << SVM_FEATURE_PAUSEFILTER) | > - (1u << SVM_FEATURE_DECODEASSISTS)); > - /* Enable features which are always emulated. */ > - p->extd.raw[0xa].d |= ((1u << SVM_FEATURE_VMCBCLEAN) | > - (1u << SVM_FEATURE_TSCRATEMSR)); > - } > -} > - > -static void __init guest_common_default_feature_adjustments(uint32_t *fs) > -{ > - /* > - * IvyBridge client parts suffer from leakage of RDRAND data due to SRBDS > - * (XSA-320 / CVE-2020-0543), and won't be receiving microcode to > - * compensate. > - * > - * Mitigate by hiding RDRAND from guests by default, unless explicitly > - * overridden on the Xen command line (cpuid=rdrand). Irrespective of the > - * default setting, guests can use RDRAND if explicitly enabled > - * (cpuid="host,rdrand=1") in the VM's config file, and VMs which were > - * previously using RDRAND can migrate in. > - */ > - if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && > - boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x3a && > - cpu_has_rdrand && !is_forced_cpu_cap(X86_FEATURE_RDRAND) ) > - __clear_bit(X86_FEATURE_RDRAND, fs); > - > - /* > - * On certain hardware, speculative or errata workarounds can result in > - * TSX being placed in "force-abort" mode, where it doesn't actually > - * function as expected, but is technically compatible with the ISA. > - * > - * Do not advertise RTM to guests by default if it won't actually work. > - */ > - if ( rtm_disabled ) > - __clear_bit(X86_FEATURE_RTM, fs); > -} > - > -static void __init guest_common_feature_adjustments(uint32_t *fs) > -{ > - /* Unconditionally claim to be able to set the hypervisor bit. */ > - __set_bit(X86_FEATURE_HYPERVISOR, fs); > - > - /* > - * If IBRS is offered to the guest, unconditionally offer STIBP. It is a > - * nop on non-HT hardware, and has this behaviour to make heterogeneous > - * setups easier to manage. > - */ > - if ( test_bit(X86_FEATURE_IBRSB, fs) ) > - __set_bit(X86_FEATURE_STIBP, fs); > - if ( test_bit(X86_FEATURE_IBRS, fs) ) > - __set_bit(X86_FEATURE_AMD_STIBP, fs); > - > - /* > - * On hardware which supports IBRS/IBPB, we can offer IBPB independently > - * of IBRS by using the AMD feature bit. An administrator may wish for > - * performance reasons to offer IBPB without IBRS. > - */ > - if ( host_cpu_policy.feat.ibrsb ) > - __set_bit(X86_FEATURE_IBPB, fs); > -} > - > -static void __init calculate_pv_max_policy(void) > -{ > - struct cpuid_policy *p = &pv_max_cpu_policy; > - uint32_t pv_featureset[FSCAPINTS]; > - unsigned int i; > - > - *p = host_cpu_policy; > - x86_cpu_policy_to_featureset(p, pv_featureset); > - > - for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) > - pv_featureset[i] &= pv_max_featuremask[i]; > - > - /* > - * If Xen isn't virtualising MSR_SPEC_CTRL for PV guests (functional > - * availability, or admin choice), hide the feature. > - */ > - if ( !boot_cpu_has(X86_FEATURE_SC_MSR_PV) ) > - { > - __clear_bit(X86_FEATURE_IBRSB, pv_featureset); > - __clear_bit(X86_FEATURE_IBRS, pv_featureset); > - } > - > - guest_common_feature_adjustments(pv_featureset); > - > - sanitise_featureset(pv_featureset); > - x86_cpu_featureset_to_policy(pv_featureset, p); > - recalculate_xstate(p); > - > - p->extd.raw[0xa] = EMPTY_LEAF; /* No SVM for PV guests. */ > -} > - > -static void __init calculate_pv_def_policy(void) > -{ > - struct cpuid_policy *p = &pv_def_cpu_policy; > - uint32_t pv_featureset[FSCAPINTS]; > - unsigned int i; > - > - *p = pv_max_cpu_policy; > - x86_cpu_policy_to_featureset(p, pv_featureset); > - > - for ( i = 0; i < ARRAY_SIZE(pv_featureset); ++i ) > - pv_featureset[i] &= pv_def_featuremask[i]; > - > - guest_common_feature_adjustments(pv_featureset); > - guest_common_default_feature_adjustments(pv_featureset); > - > - sanitise_featureset(pv_featureset); > - x86_cpu_featureset_to_policy(pv_featureset, p); > - recalculate_xstate(p); > -} > - > -static void __init calculate_hvm_max_policy(void) > -{ > - struct cpuid_policy *p = &hvm_max_cpu_policy; > - uint32_t hvm_featureset[FSCAPINTS]; > - unsigned int i; > - const uint32_t *hvm_featuremask; > - > - *p = host_cpu_policy; > - x86_cpu_policy_to_featureset(p, hvm_featureset); > - > - hvm_featuremask = hvm_hap_supported() ? > - hvm_hap_max_featuremask : hvm_shadow_max_featuremask; > - > - for ( i = 0; i < ARRAY_SIZE(hvm_featureset); ++i ) > - hvm_featureset[i] &= hvm_featuremask[i]; > - > - /* > - * Xen can provide an (x2)APIC emulation to HVM guests even if the host's > - * (x2)APIC isn't enabled. > - */ > - __set_bit(X86_FEATURE_APIC, hvm_featureset); > - __set_bit(X86_FEATURE_X2APIC, hvm_featureset); > - > - /* > - * We don't support EFER.LMSLE at all. AMD has dropped the feature from > - * hardware and allocated a CPUID bit to indicate its absence. > - */ > - __set_bit(X86_FEATURE_NO_LMSL, hvm_featureset); > - > - /* > - * On AMD, PV guests are entirely unable to use SYSENTER as Xen runs in > - * long mode (and init_amd() has cleared it out of host capabilities), but > - * HVM guests are able if running in protected mode. > - */ > - if ( (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) && > - raw_cpu_policy.basic.sep ) > - __set_bit(X86_FEATURE_SEP, hvm_featureset); > - > - /* > - * VIRT_SSBD is exposed in the default policy as a result of > - * amd_virt_spec_ctrl being set, it also needs exposing in the max policy. > - */ > - if ( amd_virt_spec_ctrl ) > - __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > - > - /* > - * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional > - * availability, or admin choice), hide the feature. > - */ > - if ( !boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ) > - { > - __clear_bit(X86_FEATURE_IBRSB, hvm_featureset); > - __clear_bit(X86_FEATURE_IBRS, hvm_featureset); > - } > - else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ) > - /* > - * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed > - * and implemented using the former. Expose in the max policy only as > - * the preference is for guests to use SPEC_CTRL.SSBD if available. > - */ > - __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > - > - /* > - * With VT-x, some features are only supported by Xen if dedicated > - * hardware support is also available. > - */ > - if ( cpu_has_vmx ) > - { > - if ( !cpu_has_vmx_mpx ) > - __clear_bit(X86_FEATURE_MPX, hvm_featureset); > - > - if ( !cpu_has_vmx_xsaves ) > - __clear_bit(X86_FEATURE_XSAVES, hvm_featureset); > - } > - > - /* > - * Xen doesn't use PKS, so the guest support for it has opted to not use > - * the VMCS load/save controls for efficiency reasons. This depends on > - * the exact vmentry/exit behaviour, so don't expose PKS in other > - * situations until someone has cross-checked the behaviour for safety. > - */ > - if ( !cpu_has_vmx ) > - __clear_bit(X86_FEATURE_PKS, hvm_featureset); > - > - guest_common_feature_adjustments(hvm_featureset); > - > - sanitise_featureset(hvm_featureset); > - x86_cpu_featureset_to_policy(hvm_featureset, p); > - recalculate_xstate(p); > -} > - > -static void __init calculate_hvm_def_policy(void) > -{ > - struct cpuid_policy *p = &hvm_def_cpu_policy; > - uint32_t hvm_featureset[FSCAPINTS]; > - unsigned int i; > - const uint32_t *hvm_featuremask; > - > - *p = hvm_max_cpu_policy; > - x86_cpu_policy_to_featureset(p, hvm_featureset); > - > - hvm_featuremask = hvm_hap_supported() ? > - hvm_hap_def_featuremask : hvm_shadow_def_featuremask; > - > - for ( i = 0; i < ARRAY_SIZE(hvm_featureset); ++i ) > - hvm_featureset[i] &= hvm_featuremask[i]; > - > - guest_common_feature_adjustments(hvm_featureset); > - guest_common_default_feature_adjustments(hvm_featureset); > - > - /* > - * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus > - * amd_virt_spec_ctrl is set. > - */ > - if ( amd_virt_spec_ctrl ) > - __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > - > - sanitise_featureset(hvm_featureset); > - x86_cpu_featureset_to_policy(hvm_featureset, p); > - recalculate_xstate(p); > -} > - > -void __init init_guest_cpuid(void) > -{ > - calculate_raw_policy(); > - calculate_host_policy(); > - > - if ( IS_ENABLED(CONFIG_PV) ) > - { > - calculate_pv_max_policy(); > - calculate_pv_def_policy(); > - } > - > - if ( hvm_enabled ) > - { > - calculate_hvm_max_policy(); > - calculate_hvm_def_policy(); > - } > -} > > bool recheck_cpu_features(unsigned int cpu) > { > @@ -656,170 +32,6 @@ bool recheck_cpu_features(unsigned int cpu) > return okay; > } > > -void recalculate_cpuid_policy(struct domain *d) > -{ > - struct cpuid_policy *p = d->arch.cpuid; > - const struct cpuid_policy *max = is_pv_domain(d) > - ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) > - : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); > - uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS]; > - unsigned int i; > - > - if ( !max ) > - { > - ASSERT_UNREACHABLE(); > - return; > - } > - > - p->x86_vendor = x86_cpuid_lookup_vendor( > - p->basic.vendor_ebx, p->basic.vendor_ecx, p->basic.vendor_edx); > - > - p->basic.max_leaf = min(p->basic.max_leaf, max->basic.max_leaf); > - p->feat.max_subleaf = min(p->feat.max_subleaf, max->feat.max_subleaf); > - p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff, > - ((p->x86_vendor & (X86_VENDOR_AMD | > - X86_VENDOR_HYGON)) > - ? CPUID_GUEST_NR_EXTD_AMD > - : CPUID_GUEST_NR_EXTD_INTEL) - 1); > - > - x86_cpu_policy_to_featureset(p, fs); > - x86_cpu_policy_to_featureset(max, max_fs); > - > - if ( is_hvm_domain(d) ) > - { > - /* > - * HVM domains using Shadow paging have further restrictions on their > - * available paging features. > - */ > - if ( !hap_enabled(d) ) > - { > - for ( i = 0; i < ARRAY_SIZE(max_fs); i++ ) > - max_fs[i] &= hvm_shadow_max_featuremask[i]; > - } > - > - /* Hide nested-virt if it hasn't been explicitly configured. */ > - if ( !nestedhvm_enabled(d) ) > - { > - __clear_bit(X86_FEATURE_VMX, max_fs); > - __clear_bit(X86_FEATURE_SVM, max_fs); > - } > - } > - > - /* > - * Allow the toolstack to set HTT, X2APIC and CMP_LEGACY. These bits > - * affect how to interpret topology information in other cpuid leaves. > - */ > - __set_bit(X86_FEATURE_HTT, max_fs); > - __set_bit(X86_FEATURE_X2APIC, max_fs); > - __set_bit(X86_FEATURE_CMP_LEGACY, max_fs); > - > - /* > - * 32bit PV domains can't use any Long Mode features, and cannot use > - * SYSCALL on non-AMD hardware. > - */ > - if ( is_pv_32bit_domain(d) ) > - { > - __clear_bit(X86_FEATURE_LM, max_fs); > - if ( !(boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) > - __clear_bit(X86_FEATURE_SYSCALL, max_fs); > - } > - > - /* Clamp the toolstacks choices to reality. */ > - for ( i = 0; i < ARRAY_SIZE(fs); i++ ) > - fs[i] &= max_fs[i]; > - > - if ( p->basic.max_leaf < XSTATE_CPUID ) > - __clear_bit(X86_FEATURE_XSAVE, fs); > - > - sanitise_featureset(fs); > - > - /* Fold host's FDP_EXCP_ONLY and NO_FPU_SEL into guest's view. */ > - fs[FEATURESET_7b0] &= ~(cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | > - cpufeat_mask(X86_FEATURE_NO_FPU_SEL)); > - fs[FEATURESET_7b0] |= (host_cpu_policy.feat._7b0 & > - (cpufeat_mask(X86_FEATURE_FDP_EXCP_ONLY) | > - cpufeat_mask(X86_FEATURE_NO_FPU_SEL))); > - > - x86_cpu_featureset_to_policy(fs, p); > - > - /* Pass host cacheline size through to guests. */ > - p->basic.clflush_size = max->basic.clflush_size; > - > - p->extd.maxphysaddr = min(p->extd.maxphysaddr, max->extd.maxphysaddr); > - p->extd.maxphysaddr = min_t(uint8_t, p->extd.maxphysaddr, > - paging_max_paddr_bits(d)); > - p->extd.maxphysaddr = max_t(uint8_t, p->extd.maxphysaddr, > - (p->basic.pae || p->basic.pse36) ? 36 : 32); > - > - p->extd.maxlinaddr = p->extd.lm ? 48 : 32; > - > - recalculate_xstate(p); > - recalculate_misc(p); > - > - for ( i = 0; i < ARRAY_SIZE(p->cache.raw); ++i ) > - { > - if ( p->cache.subleaf[i].type >= 1 && > - p->cache.subleaf[i].type <= 3 ) > - { > - /* Subleaf has a valid cache type. Zero reserved fields. */ > - p->cache.raw[i].a &= 0xffffc3ffu; > - p->cache.raw[i].d &= 0x00000007u; > - } > - else > - { > - /* Subleaf is not valid. Zero the rest of the union. */ > - zero_leaves(p->cache.raw, i, ARRAY_SIZE(p->cache.raw) - 1); > - break; > - } > - } > - > - if ( vpmu_mode == XENPMU_MODE_OFF || > - ((vpmu_mode & XENPMU_MODE_ALL) && !is_hardware_domain(d)) ) > - p->basic.raw[0xa] = EMPTY_LEAF; > - > - if ( !p->extd.svm ) > - p->extd.raw[0xa] = EMPTY_LEAF; > - > - if ( !p->extd.page1gb ) > - p->extd.raw[0x19] = EMPTY_LEAF; > -} > - > -void __init init_dom0_cpuid_policy(struct domain *d) > -{ > - struct cpuid_policy *p = d->arch.cpuid; > - > - /* dom0 can't migrate. Give it ITSC if available. */ > - if ( cpu_has_itsc ) > - p->extd.itsc = true; > - > - /* > - * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0, > - * so dom0 can turn off workarounds as appropriate. Temporary, until the > - * domain policy logic gains a better understanding of MSRs. > - */ > - if ( cpu_has_arch_caps ) > - p->feat.arch_caps = true; > - > - /* Apply dom0-cpuid= command line settings, if provided. */ > - if ( dom0_cpuid_cmdline ) > - { > - uint32_t fs[FSCAPINTS]; > - unsigned int i; > - > - x86_cpu_policy_to_featureset(p, fs); > - > - for ( i = 0; i < ARRAY_SIZE(fs); ++i ) > - { > - fs[i] |= dom0_enable_feat [i]; > - fs[i] &= ~dom0_disable_feat[i]; > - } > - > - x86_cpu_featureset_to_policy(fs, p); > - > - recalculate_cpuid_policy(d); > - } > -} > - > void guest_cpuid(const struct vcpu *v, uint32_t leaf, > uint32_t subleaf, struct cpuid_leaf *res) > { > @@ -1190,27 +402,6 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, > } > } > > -static void __init __maybe_unused build_assertions(void) > -{ > - BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(deep_features) != FSCAPINTS); > - > - /* Find some more clever allocation scheme if this trips. */ > - BUILD_BUG_ON(sizeof(struct cpuid_policy) > PAGE_SIZE); > - > - BUILD_BUG_ON(sizeof(raw_cpu_policy.basic) != > - sizeof(raw_cpu_policy.basic.raw)); > - BUILD_BUG_ON(sizeof(raw_cpu_policy.feat) != > - sizeof(raw_cpu_policy.feat.raw)); > - BUILD_BUG_ON(sizeof(raw_cpu_policy.xstate) != > - sizeof(raw_cpu_policy.xstate.raw)); > - BUILD_BUG_ON(sizeof(raw_cpu_policy.extd) != > - sizeof(raw_cpu_policy.extd.raw)); > -} > - > /* > * Local variables: > * mode: C > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index d326fa1c0136..675c523d9909 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -77,7 +77,6 @@ > #include > #include > #include > -#include > > #include > > diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h > index 13e2a1f86d13..b361537a602b 100644 > --- a/xen/arch/x86/include/asm/cpu-policy.h > +++ b/xen/arch/x86/include/asm/cpu-policy.h > @@ -18,4 +18,10 @@ void init_guest_cpu_policies(void); > /* Allocate and initialise a CPU policy suitable for the domain. */ > int init_domain_cpu_policy(struct domain *d); > > +/* Apply dom0-specific tweaks to the CPUID policy. */ > +void init_dom0_cpuid_policy(struct domain *d); > + > +/* Clamp the CPUID policy to reality. */ > +void recalculate_cpuid_policy(struct domain *d); > + > #endif /* X86_CPU_POLICY_H */ > diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h > index 7f81b998ce01..b32ba0bbfe5c 100644 > --- a/xen/arch/x86/include/asm/cpuid.h > +++ b/xen/arch/x86/include/asm/cpuid.h > @@ -8,14 +8,10 @@ > #include > #include > > -#include > - > #include > > extern const uint32_t known_features[FSCAPINTS]; > > -void init_guest_cpuid(void); > - > /* > * Expected levelling capabilities (given cpuid vendor/family information), > * and levelling capabilities actually available (given MSR probing). > @@ -49,13 +45,8 @@ extern struct cpuidmasks cpuidmask_defaults; > /* Check that all previously present features are still available. */ > bool recheck_cpu_features(unsigned int cpu); > > -/* Apply dom0-specific tweaks to the CPUID policy. */ > -void init_dom0_cpuid_policy(struct domain *d); > - > -/* Clamp the CPUID policy to reality. */ > -void recalculate_cpuid_policy(struct domain *d); > - > struct vcpu; > +struct cpuid_leaf; > void guest_cpuid(const struct vcpu *v, uint32_t leaf, > uint32_t subleaf, struct cpuid_leaf *res); > > diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c > index f94f28c8e271..95492715d8ad 100644 > --- a/xen/arch/x86/pv/domain.c > +++ b/xen/arch/x86/pv/domain.c > @@ -10,6 +10,7 @@ > #include > #include > > +#include > #include > #include > #include > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 51a19b9019eb..08ade715a3ce 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -51,7 +51,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1991,7 +1990,6 @@ void __init noreturn __start_xen(unsigned long mbi_p) > if ( !tboot_protect_mem_regions() ) > panic("Could not protect TXT memory regions\n"); > > - init_guest_cpuid(); > init_guest_cpu_policies(); > > if ( xen_cpuidle ) From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:18:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517967.804020 (Exim 4.92) (envelope-from ) id 1pjiQM-0000y2-Vl; Tue, 04 Apr 2023 15:18:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517967.804020; Tue, 04 Apr 2023 15:18:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiQM-0000xv-T1; Tue, 04 Apr 2023 15:18:18 +0000 Received: by outflank-mailman (input) for mailman id 517967; Tue, 04 Apr 2023 15:18:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiQL-0000wk-Fa for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:18:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062a.outbound.protection.outlook.com [2a01:111:f400:fe0c::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ebd7f2bb-d2fb-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 17:18:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9261.eurprd04.prod.outlook.com (2603:10a6:20b:4c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:18:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:18:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebd7f2bb-d2fb-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qge5t21hXJyEHRkcmOzMh/XI4LOHNFeIm9xUWwrxOF1dGcLWyZOBfyaEQiEd88Et0rV6/ZC6wE5bcvRc2W6cqvL/JIWE9AMNznlTFOu6GR1aPbMCQb1UxWWzjRTBMVIRuYpob/IJyS1pYqsmdHQm3CRsPHUNS+s5KmgLUa1+LnBLny7RaQb40AArkhfAPMfvj4DEN3xl5xsEIcoBXj55D8pUOax2zv9eQKGWPL/t6OiAZQmi5l9FTlITBRcRWrHKvgQi+5mXHtt68/pctR52Qvz5aBw5kNr8oWcF13nzCIPCFBmKBI3Dx0V4wlUbCMyX+m85kj5mXGmuH8OJMsivIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62XBXfVTI7hx6DBhJHmeGCLANXJLmjSM/SQCiMNAh4c=; b=cFAfsyS/MGqAxLJA36bCHNzpJPzPCqH+h3Dshoe5g1k4LZD8TtvxGRrI0QTukKcVw8/89xH2ipkF0sLXlphewf8bvTp0FO1tdCCiEiNXPC4ZvwuIrwTHUD8jgEaB8vXmbpXjJdHTQ9y6UeH7biwwMWkopwzolWHZipzhbdiyldZU/pps4g2z2eY+JVqnJeFRx4kbU36n5qB/RcxDvZxSVkxVAjYyyn3QVnSgBffxUq2/ZfXZdOAwYUYNSK7Br6HcT+OVtKyIl1P81Zw5OJrm89QpQ7uftFrtlzzW50QkCufAGgg4zsRv+p9dX2PfKjdcY4GnNZ4DofHIflK8PewI9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62XBXfVTI7hx6DBhJHmeGCLANXJLmjSM/SQCiMNAh4c=; b=sN/t/NtkfDhjk+UMQMQZwT1uR0jUrefEbCq5yTcFYQVWLM6kpa5k8xFJBdGchrfb/nDgWwVwYfWpNYm/WPRUqbkYVEUx9Y46xoosen8wHHPDvth04v1xhCGCgsG0+o/4fJ44k4RoqqycilIrJ3jdV2eqcB9IcAvtQAvuqSQLomut8sZehKQg46V0zdY+AtaCac7y5eEeOOyCSHm4BvwmfUFob3ut7Iv5N7uKPq96guFf2zSXwpWxbwGRbmBpBAnCAQuZDQnsqBbM1/vkn3V02+i3GqFwio9+J2c6JDO3RXOXnt48YEEMJHguC/L6nB0zE1PW3UM5j6sdwH1RpuXMiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e1d7c6f-82c8-418d-922a-e3f6f24c8d21@suse.com> Date: Tue, 4 Apr 2023 17:18:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/pci: Correct ECS handling with CF8/CFC emulation Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Wei Liu , Andrew Cooper References: <20230331175719.500285-1-andrew.cooper3@citrix.com> <4b76def9-9940-ccf0-8050-12ddf2c1253c@citrix.com> <91fc0c1f-a985-17bd-2011-f4964d82e008@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9261:EE_ X-MS-Office365-Filtering-Correlation-Id: d03ec373-8be0-4f2b-c7c3-08db351fcf5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h+051pjhnvn4C0k5LxZqCUTp3RbzbFJ8y5e2SZqH5zyxhIGQoSn2HGOc/+MErV7v4dJpURA9O/JNF85ajTAIggQrfltNH0fPF1AqnfrF3HPCD4uskU/qC9wAvjkG+FTCbRSUANj8RTCTkjim0Rgf7e5gNMMVhmf1s7VKlj0daE44edwZJlYNBLorK+54Y7U97w1iNVYfloYqDoU86YRWWzbVsvUszOXFqUUJqfL3BHu9CvMem/6NRTM5cjXAUMIpoYOBvsLQL6tqOQ3JdGrFCSEfGI767+qZ76/mGMIM2A+VzeYkrpB5PrtITgWIh1eKvkXbiX/dlL4B+n8a1rtcH+zWs5Bl+t/MgDku7JE9T+lMS7I/GNJM7oVTDmCO/kRfBFsu7iir+bs65JXkKKbEYQfehWpUY4Mmds+3rQACj83L1mJDQp2A+DKmN4KSIhHtBcQQ3sx21UNxjWOUqUpZsWp4W1WBaYpR5Z4+7c2OmYe2zGMUlhANLjQW54qHL7fHClXxHElbCC4f4Y/lVC9zggFtPbamY0R1NEJhRqX0FKFC2wbu0F6YHJeAYSIzRwHQZSpsWOScVyjkHXOyzl5ch534TVOI4Rrir7SDyXopKVO2qywEdV6md4wrAoVR8XB3LScBAM7lpYphIaKbpQ86OQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199021)(38100700002)(5660300002)(83380400001)(2616005)(31696002)(54906003)(316002)(36756003)(53546011)(6486002)(86362001)(186003)(6512007)(478600001)(6506007)(26005)(6916009)(66556008)(66476007)(41300700001)(4326008)(8676002)(66946007)(8936002)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2dnYStKNmZGeHhRRE4yM1Z6RzZPTjRNa3RWajRmWlhuTExrMzg1T2MvMklQ?= =?utf-8?B?VVFaTHRGbXpqT3oreFZDVkhpbzBTM2k5bTY2MmpaWndRVDRtWSs0M3dDVkZI?= =?utf-8?B?bWJYSnkvekhDeFBPdWJFeHNLMnFQVWVwR1JwcmExWE5RNTZNTEpUSUFSMmdw?= =?utf-8?B?VVR1ZFBRSHBBcjNVQSszTXIxLzR1OUIxSjRVYjQyNmxnenlRbURIR0VJaWFk?= =?utf-8?B?YnpwMHRxcmxYWXh5RGJBMHRlc0llb1lWdmtyT2Y1N0FCdTJsL3pnenFDUmZO?= =?utf-8?B?UDBLKy9QZWFQTW8xNWg1VUVTa3hWOHJvV1Mvb21xamVCM3E1N3dwa2lpSm1V?= =?utf-8?B?a2NZSUVxMkNuNkNzUDZDNi9HMGRlRCtDZ0RQdGpMNW80eE1nR2JyRXZReEUw?= =?utf-8?B?bHczdkhETEIrZW91bnhNZ3AySzI2YkR4NnB2eDdnMUs4NzRSbzZKOG9hazhj?= =?utf-8?B?QVV5U0FNdE1GdUh0dmhNWW5vWENaYUdXaTdiTXBhWkplcTFFdHhKVlBHNFJo?= =?utf-8?B?NFFXeExvODA3S2s0Q2FaV3FXMzVZMmpWeVRvajFuZU4wOHMyeWE2UXlqejBR?= =?utf-8?B?cXFORVlPUW1ESFJCbWN1Z1ZjRzlyM1ZVVjRWSGxOMlNEQXlrUU5oK2lERnkv?= =?utf-8?B?RE1MREpmRmxqSGRCcW9oa2QyQmwvYzBscE5MUktlRWpUbFVMdHI4QjdSNEt5?= =?utf-8?B?dGN5M3czalBoUC9JbHlPSm5pMHFZV1J5TS9WQk9OdWxEUFlIeFZwd2tFNTBl?= =?utf-8?B?U1ZLWFVIZ3BmcUxTdXluNE8xVm5udkNQZ1lqL2ZYaklhKzRPaEg5NzJpVWJW?= =?utf-8?B?U0UzelhNSk9MblF6TU8yRGJINlE4bnU0cXhMZFFDZEI4WFVUV1VQVTg0N3dt?= =?utf-8?B?ZXhkSGFOTXBGRkkyMmFJYllsMEZRU3BaYVBCTFAxbW1jeUVtMGtiSm1hdXhR?= =?utf-8?B?VmV3MFdKcTBmS3dpMXRDWWpmRzREaSthejhqVDI3SmZ4RDRlUExxdWlETUt3?= =?utf-8?B?cVQ0NFN5REtSTFFzektvNnJGUjFLeDJHM21vdWU4TXNKb203czVXNS8wSE5Z?= =?utf-8?B?RzM4NnZjN2tPSC9ZdWh6ODAzOUlTdDBQQ0dMazVRNElQTjJOM01QeU13ei85?= =?utf-8?B?M01zUkg2cEM1dkwvRzFuZVFoTGE5SlBBN0hrSFBzS0w3Q1lHbGk0M2FudDAz?= =?utf-8?B?K0pJOXpCZVQraU5lR3ovam9ERnpUN0N0bjNqOXpoZk0rZTBIR3pLUXpuT1VB?= =?utf-8?B?QmlVOXRlUDZ1eUoxclFxT1ZCQ004Vk9LTVpsM3NVZmk3VzlNeVJRa2ZjS2lH?= =?utf-8?B?c1F6bnFoNnNpeWRtYWJrM2ZsZlRqZ0VCcnk5UHo5NWVCK3IxYzBXbm1aUmFy?= =?utf-8?B?dkVQbFhvQzN3OHF1Q1ZMTTluZi9EZHhUdlhnd3BUZ1ZHSlE4ZkVQaTZITkFB?= =?utf-8?B?a3BSRWVlYjRUZUhqakgwQnhIOVROZFo2MUp5U3VseEtWSzI2K1RweERVa0hQ?= =?utf-8?B?M1J2YU9JRWxEK0EvMDc4bys4MldTT3ZWVmJncHVjc2xXYkJ4NWpYanlJcU1C?= =?utf-8?B?Tk9rYk5hblBsM200UkNhcmR3bzNZdk05L3JaU3lKbERuWGQrZFVTN2pTdXRB?= =?utf-8?B?eHprMzBqbUNsdFFSYU96U1hRNStlYWQrbmxCVlRFbG0vTG9CYkN6a0ZzeFRu?= =?utf-8?B?VklIbEhYMkxVeGgwdmVZV2Nvbk4wMlk4SlM2Q3JnY0RZQlVGQWxDZHBiY05F?= =?utf-8?B?cGtRQmtZMzZBRjZnZEY5bjJHMWZEUjJqU29WRStIVHI5TU1CRTJ3RjMvbDlZ?= =?utf-8?B?TERYdzdkcjBpaVoveGZINFFUdVpWSWJVZVBZT09ib21RWFNiK2gxeHlEd2E0?= =?utf-8?B?YW5pYUl3WnoydUtNVDl0eHpTWEp0bXB0aHZienJpK3RPMEhONFVUc0UyWWFT?= =?utf-8?B?T1lMd3pESmpQM2NHSEFabE50eFVvNE5JZ08xRkVVK1dLY0M5SHlLWVpLRkxo?= =?utf-8?B?RHpKdk9aTkp6Y1pralBVMHNwQm5EYVR0Z2ZGb20xaTdKZHJQUm9DWVNLeE15?= =?utf-8?B?eGJMbGRhNlBobk1ybk5qbVM5L2pUVDRxUVkvRU5vUXRYZ3JORGtoSWNDN1ky?= =?utf-8?Q?92BDiQS5x3A2wJzpSNJi2tSGm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d03ec373-8be0-4f2b-c7c3-08db351fcf5d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:18:14.3795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f1mXU8/tG1ZLKM3mtuX9BztNW+MgdDyPFrLWBjAM8GGFCQpYtQx5/OuPaih60R2hE5nAqDllbLwQs9a/WyKpMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9261 On 04.04.2023 17:04, Roger Pau Monné wrote: > On Tue, Apr 04, 2023 at 02:27:36PM +0100, Andrew Cooper wrote: >> On 03/04/2023 2:26 pm, Roger Pau Monné wrote: >>> On Mon, Apr 03, 2023 at 11:16:52AM +0100, Andrew Cooper wrote: >>>> On 03/04/2023 9:57 am, Roger Pau Monné wrote: >>>>>> @@ -1104,6 +1092,11 @@ static int cf_check write_msr( >>>>>> if ( !is_hwdom_pinned_vcpu(curr) ) >>>>>> return X86EMUL_OKAY; >>>>>> if ( (rdmsr_safe(MSR_AMD64_NB_CFG, temp) != 0) || >>>>>> + /* >>>>>> + * TODO: this is broken. What happens when dom0 is pinned but >>>>>> + * can't see the full system? CF8_EXT probably ought to be a >>>>>> + * Xen-owned setting, and made symmetric across the system. >>>>>> + */ >>>>> I would assume CF8_EXT would be symmetric across the system, specially >>>>> given that it seems to be phased out and only used in older AMD >>>>> families that where all symmetric? >>>> The CF8_EXT bit has been phased out.  The IO ECS functionality still exists. >>>> >>>> But yes, the more I think about letting dom0 play with this, the more I >>>> think it is a fundamentally broken idea...  I bet it was from the very >>>> early AMD Fam10h days where dom0 knew how to turn it on, and Xen was >>>> trying to pretend it didn't have to touch any PCI devices. >>> It seems to me Xen should set CF8_EXT on all threads (when available) >>> and expose it to dom0, so that accesses using pci_{conf,write}_read() >>> work as expected? >> >> It's per northbridge in the system, not per thread.  Hence needing the >> spinlock protecting the CF8/CFC IO port pair access, and why MMCFG is >> strictly preferable. > > So just setting CF8_EXT_ENABLE on MSR_AMD64_NB_CFG by the BSP should > be enough to have it enabled? I expect all other threads will see the > bit as set in the MSR then. No, it's one bit per socket iirc. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:22:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:22:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517971.804029 (Exim 4.92) (envelope-from ) id 1pjiUW-0002S7-H1; Tue, 04 Apr 2023 15:22:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517971.804029; Tue, 04 Apr 2023 15:22:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiUW-0002S0-EM; Tue, 04 Apr 2023 15:22:36 +0000 Received: by outflank-mailman (input) for mailman id 517971; Tue, 04 Apr 2023 15:22:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiUU-0002Rr-QI for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:22:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7d00::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 858a8cf5-d2fc-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:22:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8264.eurprd04.prod.outlook.com (2603:10a6:20b:3fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 15:22:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:22:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 858a8cf5-d2fc-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZiqgN4QuaDD3A9CSFy0Wym+tlZHRTfB5Ng9rjtsnn0OCi3phTzxozAy2l1Ks5dkziE6JfNz4dqsAthA0lzg4tshVkB50bvQWXGPTjDS9PEBTzS4e5x2WP9kK4eQqU/k+TTSVZJ9hmgHTD2DMc1EPwTTw7ezMrCYHzyvkc1YEaU7qoa3zHIxVSaicW9kLixuH0WCGmw7ZuR+Ki8Zn0ePhyOveWOWyzf7Odpr7hoZWDjg/JQcQAQFkKSOme2XBqVUlHYBDn1pwxs/Dp2H5f6C+E7wW5nnh6TOq5a9pjVGW1RKbNEOwZsOQg6aJCIMyhymxQ2qq79DsVggTjWoPgAkeNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eTzjGYye49h2XlQsudSBmRNkFZaxCU/5/YM7mQSQXcU=; b=W3eDZaCvNG/0j74Bv01VsV9z2gIRqJPib+EVdQ1ocihWhMzsRSrwlz0IX3FMcE1jYLWeziOvMhzHLch49winTPUjhh2EoZlLCn100Hj9RT1r5SM8ouka/cdYmxSCAD14QDod1hmsESqBreBfcIpPBZHs8QsjJdh8VYQnFwcfUy02gI23fU7YwlfDdwkaDKpCMYxqH6Sc5h0FlFyQeNocpb3H3GUAE/nvVpAm2swqWxE0IZtGnOrO+zp2zNL1ZKFapA88OW0Irrw+UWJ1Of8tj5iYB/25enpz6W4IVAZxIw+MzE/UUozpFrg+adDoXe8Uf7aXM4mLtuHCdlMjfUEv8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTzjGYye49h2XlQsudSBmRNkFZaxCU/5/YM7mQSQXcU=; b=pqZxDDb1utSba/nygGJzk/A+a3zjogYW8saU+O+N9Jgwcu5N7+A7ZLePvC8YtKVhlE5vekM50jBmrYPGEF7CkPz0dleQimwxH8g11YBuLFPoivLWSCJ5dZOX69LoYIL7nLDyd+FH5lUB/KpJSDEuSvAV1T0ugcziBXww6aakHH6pg82BBnzkmwY5V4Ruq0rSdE1JSynQSY9K6SJwGvXx8tZeO3l/KYgQ7dm8tll0bXrgcrxE1ehAeLWODAYNZg7WQ/VjIQr1+AEpNgd+L3wJdjcyyHP7zmJC1IwMBZg1XpBfOvIazuv8CZkf6EDgBWhdl9PvzEUm4/JmGZAfn0bo6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c132e7c-8582-874a-1964-31368fbd5872@suse.com> Date: Tue, 4 Apr 2023 17:22:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 12/15] x86/emul: Switch x86_emulate_ctxt to cpu_policy Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-13-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-13-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0195.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8264:EE_ X-MS-Office365-Filtering-Correlation-Id: f807b7e2-69ae-4c90-4094-08db35206845 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ux3dH5JOxY+VxSOXqvaEjLj7TxxzPL6hixN02zNFlI6+WDuG9z+9/Bcyaj4BhLLNPp53J3q4OGTP66pyeiOp7QBEU1lZMd4MZNPnbmYeUjOOs0QQrI8HJexOIxm1lPc/WuYie3ajwP8JtAXkEvQrRXfU7dbk1QtSLo7H5Lc6wqcdF0+ak6f4jsTs9p/1O4X7EtikZSsRVmBMl5Xhhit4zmKODJfZfQgKPw2XV0wUYr8s4cQ4hVtD9SOhNAzCi7E7NhMUCOJPa0vVtQ63PiKKBJLqj+gIS4MhVD2PzjBwRuo08A83jUVbevkt6kx+8855US3Vm/D1kZ8ija8yorhSTkISRkiPl9L0XU0FHSvyHVVi4mDpK3rAd5HaYLZWdv2c8u3VKBBYFwp3J9Pzm7f0D5x2cgGP8GsEuKizP/fjAsPELshihBUdVMbe1kTH1yO9K+RE+X+oD+4wEWD68TstuzFCvB3jZBDXml6Yw+m1z+OUuEsGR2qUbg2dO/j2qN5+lxA7XB+lVMDlyKUCQh38WryO3CUTdUUseuv5XqHntGgQM06AfCuExzKYlLFrTD8juMttbtcveeZzRB7setKz375TU2Hc/XeMj4oiAZE4L9BV7iTCQXM2HMpKNSgEAv2MjzpLTRvOT0ybnIrFaHQYDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(376002)(39860400002)(346002)(451199021)(4326008)(478600001)(66476007)(66556008)(8676002)(66946007)(5660300002)(316002)(6916009)(54906003)(8936002)(41300700001)(38100700002)(186003)(53546011)(2616005)(6486002)(6506007)(26005)(6512007)(31696002)(86362001)(36756003)(558084003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0t2bDg4MGhQWjY5NUdJblNzNGkrcXIwVjRWaDFXSW9YWkhBZXF3eFBkTWpo?= =?utf-8?B?M3Rpek02OGQyWnYwUUZMc09nZzFjVHRmV05FZ3A0dUwzL01RTUZlZW9UaVF5?= =?utf-8?B?d1VGdjZDVDR2WlRlWUhlYnJybUY4MHhYN1paSW5YZm5DeGtGOWo4a0pFaEZr?= =?utf-8?B?SngvemljU1B4enAvdSthcWp0Z2J6ZGpZRHU3RGd6S0U2ZmJTalB0YkQybTd0?= =?utf-8?B?U2p0alZrSGJtTXB5Y25lV3hJdUhZQWNSV1NSeGUva2w1NDZQUElsc3NBNTFa?= =?utf-8?B?OTFKdFdzc3NMR1BYc3czTG5LVHRSM1hDZU92WnErT05PT1N3bjdTY25PcFFC?= =?utf-8?B?aW9uZ3h4d2VDTzIwcUdsSVRkU2xOYm1uSGZycXYrNThwenpCT0g1a2thN00w?= =?utf-8?B?MHhUTGRSdGRIcnBGd2MvamZydFM3TGJISzRnWjZyOFFVd2ZvUzUrQmFHQ0ZW?= =?utf-8?B?ZFl4TGFoZXZydFNjaFBrZWJLNEFDNW10WHBoY25iUG8rd2JVOFNWdXBiekpy?= =?utf-8?B?R2JSU0EyellRK1JKRW1QaTlvV2xyMWlKZGw0Nm4zaFllb0VaeFRuZUJTc3BX?= =?utf-8?B?dW9FRWdDalRnRDJBSWxTV0pJdHhXbkd2UVVyVXZTUXJJSDZXL3lUYUsxdnIr?= =?utf-8?B?b0hoNmozeW1zRUxJQmp0VXdGVnN0NEpramZpMmdFUnZtNGs4RlVNUjBoYzh1?= =?utf-8?B?aWlTY3VURnY0VE9LVGVyRm1CYk1pZGZVdk9tZCtpY24zOE1ydDJhbVdIVXQr?= =?utf-8?B?WWZGeFFLQ3gxdzJrUENVN3hyc1MvWk96S2hiK1FnWUg0dkFJdFd6clhWcWp0?= =?utf-8?B?a0xtdWFObDNOZHZSMy9UZ2FMMXZOdEhlMUlPb2lNYzdNMHVDaGF0a256QWdC?= =?utf-8?B?MGQ3VERXT1k2clNOaUYrVnB5bkhweGY3UXJVTlc4ci9PcnQ1MldTSjgyRElV?= =?utf-8?B?b1R2bXBJUDYzV2YzSCtmMjVYT25ua0xXM1B0MCtkWHBkUTZZM0JoZmYzUlBt?= =?utf-8?B?Z0h5WXJ6WUJpeWZ1MUlqZTZkanRhU0M4M3Nmckdxa3o0NldxN0dLRkhjV2ow?= =?utf-8?B?VFZJVE5OdUw1eXlzWmlEQVJFSll5VHFscVZxMHpERFFWNVFEZWlETmN1NzFi?= =?utf-8?B?VzVTZVlaR2M3VDZ2YWZFR1BmZ3JJM3psMncvbU5DUEFPdlRHUzg2ZjJSOThz?= =?utf-8?B?WWIyRDJHejRCRXZvSS9jVjN6bVNwYmx3NW9YSmREQkl3ZDB5R0k5cWx2QTZZ?= =?utf-8?B?d3c5QXpHRTY1TmVnWWMzZ2EyMTlqTXo5cVd1VThYNk5tM25zN0pIQ1NaUTEx?= =?utf-8?B?U09PRkJ1eE1DandXNCtxdjBQSDQwU3JuQUZ3aHBGYk11cVFlVmQzOEdadnBt?= =?utf-8?B?OXNkVExsenhXWVBlai9pbXlad0ljczc5VW5zTWdaeTJoV1FCa0VtQ2tjZ0J0?= =?utf-8?B?Y29UazNjY1BFQVl4VEJ3S21Hak9yS3ZiNldpaExiOFhHWnVOOTY5dWhWQVBC?= =?utf-8?B?YVIrUHlIeU52bDAzZGZIVDJHRHdOOVJoRFNXMFJOQmMzZGdFVmxFaVBob0VC?= =?utf-8?B?WXAzZTdxYTVEM2JUc0s4YmRwNnpVb3lxWVkxSUUrYi9SSkdod21HcFQxVjEw?= =?utf-8?B?Z3ZXQ3RoclNMYnA0ckpLYVphL1kzVDZOTmEyUkFyR3IwcnFNL1AwRGRldXFn?= =?utf-8?B?Q3VCdU0yZ04wcHdscXNCUTNQUUhyZTR6aUxKTnh1UTFhcy9qKzdYNEd0WEFC?= =?utf-8?B?WGFvUGJIQUZOaFNkVG5yKytQWUMvQ2hkbEowSXR6aVc5cEJMVm91L1Y3dENL?= =?utf-8?B?QkpWNFYzdVFtcEF4ZFFzTVdPNTRKbks1cjFQMkJ0bGZDMTR1V1dIampPYXB6?= =?utf-8?B?UmIvQnJsZVRleEdPSnRWdllKaDRVaUlmaDJtU2FTNFIrSm5uUDNHd1hEMFNl?= =?utf-8?B?WFhWUzMwRUFFUWV1aGxnU3NPUDdYVXZEVEN2UXBaSHArYzdqejVPMmgyN2ZM?= =?utf-8?B?MVNlNktNSyt6L2J3MWRXWTF2cDBtT092MExoaUl0MWJrbTdtTFVOcFBUdUFN?= =?utf-8?B?Nm1yUHJuckk3Vkl1Zkt2YTNuVVIvc1FGS0x2RldENDVsRk9yUE1UbHZ0ZEtI?= =?utf-8?Q?JIXF5Vgof0FAArKWM65Ip4+Tx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f807b7e2-69ae-4c90-4094-08db35206845 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:22:30.9659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0uACBSfMpPjYGvyypp/S7Ax6HnYNQKwhvxq6ZI2/qbBpryMOtUxVMG5ApJ7NvbnV1UdDKERnMHh7bUHGre0Qtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8264 On 04.04.2023 11:52, Andrew Cooper wrote: > As with struct domain, retain cpuid as a valid alias for local code clarity. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:25:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517974.804040 (Exim 4.92) (envelope-from ) id 1pjiXK-00032w-02; Tue, 04 Apr 2023 15:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517974.804040; Tue, 04 Apr 2023 15:25:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiXJ-00032p-Sz; Tue, 04 Apr 2023 15:25:29 +0000 Received: by outflank-mailman (input) for mailman id 517974; Tue, 04 Apr 2023 15:25:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiXH-00032i-Se for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:25:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7d00::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec1a3515-d2fc-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 17:25:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7223.eurprd04.prod.outlook.com (2603:10a6:10:1a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 15:25:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:25:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec1a3515-d2fc-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXWFxTTIcAacLzPaNbkYtDFk6Cvndl3AkF7oZz+L4IaTpAEf/UkdzVPJsTf2R8sVCQweIHxMBNd+B49v9bSucx0nvvVSgy+WrWeDbkUbymtzTDRE0s4O/UhN5efqxHt7xWXZQq6LuUJk3oqpuHvDQJxN4hc1/LGZYgDKl/LxSZPxhdCIUNuFcuzTed/MNcxicJJpLEEYUFUt8pBSJ4hm05ZseBHsnUhJhFS9Q8RCK0/UGZgqABrYIbNSrUTZ7GVtfc8MH7aLk3VA7umEtmeoaHeBe4jlTJivlpN2q02+Zsyba6UL54YYlTEaB0qGuEu9D56/vCVx3/oiIo9H8Uiaew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5jGdw4viSV9S7TApuPOX3S47yaHtXnnnjRZnrRRyAqQ=; b=UgOTaCDs4vRN9m05gfghutBRClfUpbKngQIxdY8jVWHu5QZ8LzFSGBr61IfL4SMI+y5lJ43/VPGWcm8HZnNW53P0+RglJTbwCQLtYvTz0jdfOPjn7mtMf8pbDjIpuTxKj4O5ur0FZ1xNYsbiLzj8SlsNLbk9o2JrAulfayUuMlkeNkql7I4UTv7pU1h+lMx8WzrtPjZXNE2jpM0DzF+O5MamZe3k6se5vUD+2KGq/scrN164ThqcAEC3VuxMiEpUrAz62UBgtn7gQAJiOErdE+DQH2/KFTIy1bvsTTJEcjO4RpQUqfKyq662Zr3Ey8ni1/01j0LLhxDLU6GHKl69PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5jGdw4viSV9S7TApuPOX3S47yaHtXnnnjRZnrRRyAqQ=; b=R1iOakWn/93EOmasSt+HE5fETSQXoKOSd1qraMJvih7cnFu3g+WppmpBUarssuitWebkKjNCyIMdhGWM5oKdkAlh+E+9aTYMIkCIUBpsdzvUoVIHZFd7vjNtaPo6VCjOMTOAd+1ga6DUoYK8hGsKtMA3MN32pO4W/liWR8kUzXbDFsMfKaF0HQzKzZFX9/wPHOTPK+l4S2rcNfM2hb6M0nQAMewNkxjcFkR/Z70o6kHeboAno+UWiNj3TjZxKEPRjDwr4x3b/Q36AAb/oT6fM+JtLGP6RZmWFEQW+OMHqJhg/5WJox3+8rJ801SDb0/yTJu6+VfT9bIQxq0vRdfnWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 17:25:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 13/15] tools/fuzz: Rework afl-policy-fuzzer Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-14-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-14-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7223:EE_ X-MS-Office365-Filtering-Correlation-Id: 736dabe2-4459-426e-7a95-08db3520cf7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ax7uXd//TEu11IMdpodelv/GMAD3sEPJzccWxv6cbMxi7zLt2ImNo0V9MvNpaJqJ/8Uy0Wx4TkNFBGdkFQuRAtGQQNE5hLeaASV3IX03NztJqt/2Unjam4i/trGz2R5nC8w4tJtT16B5KAtxTMJMTjX+zqe7FLVQs8dvS2MfskOPDN0iQgGk9qFov98TnvzrVe2ti/+cLUvxq4x/8kWwXGfORgAPzFjM9srSCKXmS/EdlD0omxizIiHPe2qdmSD7rkMttXxVJjsQsdgqlG1PRsUOeeyhepEHCtbYOFC61pWqVoKkPGEVl5NsIfaxF9GFVPxz4k8Np0Rgb/VP2VwcrLhAGkLqTz6YgPWnmZ+ZkSEcUlXLjB3vi5J1bmCjjdXHYhlFMhAsFpd6FH+4kFzNAw4fsIq29wQ1txaMWlEel1pWOGvRcDp71h09Sdz6+sem5uuBUVlZq+X5/GWzX5GidLK+zoW3QOF7cqi3AwkfS1uf3SQ5vDBHY/Wrogri+Y94oPJV9pPE6CaehgpdLGSnms2ntqYV9rx84/XVKQcI/Ri+oBvNhevQYo25mLl7nechVhH3dwyNKteh0ib6QR/X8jAshK4UdA4jqNEeQqJngLVrViNLZ/Mg8N7Hfy8X0f6DRK09p4abx/NbqRG/Hf3SBw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(39850400004)(396003)(451199021)(5660300002)(38100700002)(8676002)(8936002)(186003)(6506007)(6512007)(26005)(36756003)(2616005)(53546011)(2906002)(558084003)(31696002)(86362001)(41300700001)(54906003)(31686004)(66946007)(66476007)(66556008)(4326008)(6916009)(478600001)(6486002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkxCeUVDcDAvc2JMcnEwSzVSd1F3bkMzUWErMndhT0szNjBnT3ErNGVmb0hN?= =?utf-8?B?U2NPL1ZZSWN3YXFLenU0OWt0eUVxUHczYmtuOUF3RlJQNDdqeVNjWVpXZ1Qr?= =?utf-8?B?ZllxZExjL3daUlFNWWJPL3pVaWFBcmIzWWJUa1kxWVZ3S3c0OFhLcitnSm5R?= =?utf-8?B?NmplS0cyekFMYnVyRy9MNk9KeVhibW5tQkQyUmNpWE5rNzhyR2ZsRlQ1MnFx?= =?utf-8?B?S3A2Zm10UXp1Y09HcCt3M3ZwbmZ4ekJlQjd5R0t6QTVnS2YxY0JqRER4UXlz?= =?utf-8?B?dFJYbUNCc1hRWDBvTllNakxUbys4TXRoMFlDRURqc05MaFJpSE9Ed1Z5VW9h?= =?utf-8?B?bVVBRkt6NzVXcUlPb0tQeTNIS1FsdnZFVlhhUG1sS3NTWEltc211UFV1S0R2?= =?utf-8?B?NC9oWWt5RFFLdnZ0eERwZVVvQ0w3a0JHdG5ZVzhQMVlYdkpTTFlJZm44RTlx?= =?utf-8?B?a3J5Qy9HWTI0VmRRY25CdjRBYnR6eTdrUSs1ZEZzcEltVkFKemZUcThJK3RX?= =?utf-8?B?WEQ5NzRWd3RRcDE2cTJ3YnR4OFUvUjZOTkZ2eVNZUUk1aGMycGJQa3d1dGJS?= =?utf-8?B?OHJnSDY5R3dtMC9QWEdaaS9JUUtmSVN0cG8wcTFvRjdvSHZEQ3MrdFZIYXI5?= =?utf-8?B?NFNBYmd1M3RvZ2krZFN1R3EycEsyVTNnaHhuR0dBMFNDTElVeUhKRlJIOGxy?= =?utf-8?B?OTZCL29xdG1LeFpqYXR4TkxoZ0d6bDBMeDNuMWZ6QWNkRzFucGw3RDB6b0N2?= =?utf-8?B?bWVmdGd0MGZaeWhZL2VlNGpYS01ZSXR1eTFZcnpyTXU4a3MvYytrbjh5TDhp?= =?utf-8?B?OHdiZ3EyQm9tMk1XbmptTzlnR3ltVWN1QllrRXkvWW81QWZYUXlIaHJpcnZn?= =?utf-8?B?TkFYWGsxSUkyRGR5RkRrSlU1cUsrZkxXVGRKbC84MkpxbGdHVS9kb3N0OWR5?= =?utf-8?B?V3pWWXRLaWRYWkg4ZVVOc1N1MFRVd0p1N0NBZWJnSmdVb0gwQUVjd0E0Skw2?= =?utf-8?B?aE1neXptRkdqRmFaNnVOSlN0K1hLZUNxLzZsejkxZFp2T1ljSWE0dGJ0NlJl?= =?utf-8?B?MU5oYjF6a2g4d2N1UmdHVDhOOUoxbmpHY2gvUFAvZzcydTAyRDMvVHpLTS94?= =?utf-8?B?aENJZGJDSWtzb0lZN1pQZ29IdHBlNzYxL0R0SVozdC9ZcHpLaXExbjNtTVZO?= =?utf-8?B?akpXWWNrbjNrd1RZNkJUc3ZzMnZpUmVBN2VnV2tSUWxZcW1BTTlmbnlzamt5?= =?utf-8?B?cDhxaHFXQ1pWdW16bnJqcEU2OTRkUzlUMEIrWlBUNzJ0d3lHU1NGZlJhY0VY?= =?utf-8?B?UGRFV0NyQUc0Z1VJRk0yMm1QM3lTVnorREZOTE5PRGFsODEweWhNY2txNCt0?= =?utf-8?B?R0ZBSUs1WkVTRDI3aEVxSmF4Rk8wY1pVMENFK3FCMkN6UExjOVM5MGFFelJJ?= =?utf-8?B?TWpubFdma25xelVKbGIyVU1NM0JsZE1QT3hhaDVsdkxlRzV3bmJRSGlPckZF?= =?utf-8?B?MXBDNm15QlNnbkdPa0JaZ0ZIcWtyTU1RamRMUnBMOXNwbUF6RnJSK1lneUdr?= =?utf-8?B?NjFESGJDeTloc3kybDF2aHpicEkvamkrMnhDK2pQT09EK2V4aUIvWlRpaGFw?= =?utf-8?B?UU5BWExKdFJiRUlKWkRLa0JHcGU5VXNJangxTVY5VzF1b3RUckkvTEFRSllS?= =?utf-8?B?c0k0NmV3dWl6KzBOWGJHcENhZmEwbVRPWXFZNjluYUhHOGdvUzhOYnZFQU5R?= =?utf-8?B?NU5hMjdXRmpHRXhmSDkrd1FVajlDN0dDMVVpcnFZVFRzOW0yaGxHNjZ4NkNQ?= =?utf-8?B?TURqMld2alIvb2k5UlNKaGlES3IyODFCeE5scGZZK3hPcjI5VFZIOHF4NGZN?= =?utf-8?B?bytSNnlwMkpJRzY0MnlpL2cvODhyNVhFRy9ybmxKdU1SZW0zZ2svNGhWcnZ5?= =?utf-8?B?ejdsN3hab1JWU0taamZzK20xbGVJSm5lYjVxTEdNWGNpUDlxdldmSDFBeEhJ?= =?utf-8?B?aVlsYU9rUHBzUU1SUFM4UXQ5d2M4d0VSWUx1UzNTUHRIc2tkYWFyM3VXMWt3?= =?utf-8?B?NVk0QzNhLzhQbXFUK0JHeWswbVIvcGR3dUVBdWpVWXNwNHZyRXIxNnJIQU5r?= =?utf-8?Q?zNwxvkAk+Dekflwb+lr8NSf/r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 736dabe2-4459-426e-7a95-08db3520cf7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:25:24.1808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GHojTxkwcnM5KxxqMO0v1yoxd+LWglPSyzc8t7y099zMTc7kyXO0PthkIyVXjB9glU2aTEU3n88geekI9I3fTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7223 On 04.04.2023 11:52, Andrew Cooper wrote: > With cpuid_policy and msr_policy merged to form cpu_policy, merge the > respective fuzzing logic. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:26:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:26:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517978.804050 (Exim 4.92) (envelope-from ) id 1pjiYR-0003f6-Ec; Tue, 04 Apr 2023 15:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517978.804050; Tue, 04 Apr 2023 15:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiYR-0003ez-BC; Tue, 04 Apr 2023 15:26:39 +0000 Received: by outflank-mailman (input) for mailman id 517978; Tue, 04 Apr 2023 15:26:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiYQ-0003Zp-4t for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:26:38 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15526ce0-d2fd-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:26:36 +0200 (CEST) Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 11:26:31 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5214.namprd03.prod.outlook.com (2603:10b6:208:1ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:26:29 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:26:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15526ce0-d2fd-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680621996; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=79+mPpvknChuWzV8y6U2VYX1RyXjcvvfH29L6m9w3ts=; b=YCAD+cEYBXPwVSwaWBetc3AcYCO7JOoFez5op14Nd2Ed4ifsd8I4j95z zmZH9ho5vHTyDhzdajobh5ohEdab3A/q7rqm6XZHVRXoCvhMhYSygu12B kNY9OgIS3rerZ1A8hhmwEOZUFwc6cK0L4/bSEsaxHVdG3JzSuytXVeNEr I=; X-IronPort-RemoteIP: 104.47.70.109 X-IronPort-MID: 103655417 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Fy1c164aovCxN1kuoSSZqQxRtBXGchMFZxGqfqrLsTDasY5as4F+v jNJDTvSP6vbazOnLYogao/g8UNVvpbRzoJnSVY4rioyHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my v0mIWocaCm4uv+7xqqeGrJe1s4CFZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOmF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtKT+Plq6Iz3zV/wEQPEQEtdGO5/MWWyUfkWMt0K 3Y++yMh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mqodsiBvKF45nCPTs1oyzHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa0owFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:RovSx6DlQGbH3GHlHelc55DYdb4zR+YMi2TDt3oddfU1SL39qy nKpp4mPHDP5wr5NEtPpTniAtjkfZq/z+8X3WB5B97LMDUO3lHIEGgL1+DfKlbbak/DH4BmtZ uICJIOb+EZDTJB/LrHCAvTKade/DFQmprY+9s3zB1WPHBXg7kL1XYeNu4CeHcGPjWvA/ACZe Ohz/sCnRWMU1INYP+2A3EUNtKz2uEixPrdEGY77wdM0nj0sQ+V X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="103655417" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmeBLmSo8iEfGAX3TVuaJ34sj3E++BLrRrum8Z3kVjU4sNFBdGQlkblGN1rPb9lpzHzvceWb1kYxq57sen5irYB7xbOPZ6EIHionwOCbkcu15APDwfBdt4kSwjjBm5dzQ8HyHv3kKkdySjf+uo2tX1fsQnlSqRwV0RyZypzHuv9GA33wIK/J+4xxRN01fjUjADrfj1E2LwqrvLO9fPxUyvzouU7IPWVfdjxq75/esbdTBrGeth0jo/RepqIslP+wN2dAkrqR9ys2IfzwABSWQtQWXzY0bo6yvBAPWn9yFoTalXC0CrOcS9NiHnQBBO5Lft0Itwj75ZsD3yHE6ilBng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6y40F/Oe0xUll3zPKQlK+LZEkQkCQrpdsfcxvK2eJ4=; b=atvqcQmtsorYmY8GzSWFUpzGz3sy4P3lv7rj6flg8Zq19qQBVM8T+XSCZmM1ag/Dg1G8YaKYeI6p7/szcNtHClRQ/+HLOL1ufX1/711k/1f/fiJuU/qGRgt2oMQCUmKaABNyIXasY6RPIoGe+Jvr9BqaH+ppxOZ3bFc7IGjzyuLUBz5SeU8pKkqVZ8UAIHy0o5+dtOKwwp5xkc5jaVj9gew0ZopXknx+5mTalcUR4BScOaHTGuRGoRUwD8GfLzt23Cbd5NRCpI0APlfLpIfbpdfNqGI1Spcby8qImr+/loCehkPN+/SpsMEl+HrOT4DpAn//Ac/92Il3I51dKjEpbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6y40F/Oe0xUll3zPKQlK+LZEkQkCQrpdsfcxvK2eJ4=; b=csrxbuSiUtosL82hT3yP3QCHTuxkS7b1J9wznSzrUCiySvY6Kq6924991JE1B+iPxKbHqM3dA6Fs57fqXueA5e29bjgJdbuVvkXe48khYqxrtxS1ROHx59/ktGt1t408OzfKYNPBaoqmhSVmXPjIynxrkN+UaRjyJT2WvDWI1Yc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Apr 2023 16:26:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v2 09/15] x86: Out-of-inline the policy<->featureset convertors Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-10-andrew.cooper3@citrix.com> <63395f4e-2272-5537-190e-27318d4057ea@suse.com> In-Reply-To: <63395f4e-2272-5537-190e-27318d4057ea@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0627.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5214:EE_ X-MS-Office365-Filtering-Correlation-Id: 342dad2b-35b5-44d6-4af2-08db3520f630 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9ejMmS5YFhoHjdFUqCErvU1+UL+um3VDUh4VoTrmH8FJacjraSLxqp9GmBDpFpdzXirNOcX+7FMf//vCQUIzyZTlxO+0SyYAeIdsHNB/72YOVjt41VwEZOIPpvfX/blM57Zfckufrkp6o7/iTs0FbIIoOKR6NKP1A83WKmRWw/qStNpSoHFm7t/TULwqcypJZzs3RiD0kEddC1czu2a57VJdPaqTEPW2FWAUncVcRhI1z9iiN1bmLEuM8j0MG94Gsu+kpMNlXzJZs3KHsPtxnY+hsigIiaLAuuPAo3OobS+USrJqgWwK2IOG+TaWlqJDkjucnPy0TbqIVaJ7A359bAnIr8sL4pVR0XlOByVVM1NRm5FAd1VC9nzmItmA2XWaH99w3SR3uI515MITH8iKxrAmTkKCQsHi7A7BxdMpLaTG9mNHCLm5Fs/uTh38/0G7kh+PeKgaS2oV3MJEU+rPXIfc3A6+WAyY4LNscygvitEqUX7ZK4H3ArV1u/z0PsH1QTuwY3p61ly6YH9fULF1oVg8jbH+2pPiwLF7Kj5MuJigFZkRvzFeyrfkOTsyoMoNNhzoEOhcsliH0bogptltlKMjTIxQp0T6gkENcmXP/cBEaYsMg8VrvyTdSdkP+kMWEuTa1l8pOpgVExJJws+IVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199021)(8936002)(5660300002)(38100700002)(83380400001)(86362001)(31696002)(2616005)(316002)(54906003)(53546011)(6666004)(478600001)(186003)(6486002)(26005)(6512007)(6506007)(66476007)(82960400001)(6916009)(4326008)(8676002)(41300700001)(66556008)(66946007)(36756003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEVMS2MwSUM5U1h6SUdhZWtuMVhhVWhOR1hLKzZSU3o5TTgxYXZLazQrY2g4?= =?utf-8?B?ZnVnaitXZTExYkc0blNLZXlNNS9HQnhkZEhzZlF6VndIaGZUb2lMOXpuME04?= =?utf-8?B?eUxxSHl1VmE3RlJsdndsLzJBVElNUDZ0UTlicU9aNEkvd1M0bGhHTDZlRUh3?= =?utf-8?B?VG9SeXMwZHRlNHZZS1BkczZIMGhIcm1UWUc4NjR1L0E5azg1Qk5raFFOZzZo?= =?utf-8?B?SWtkVGlCQVpKUU9iWCtUZU14ZEtJVzB1c09zTGJ1S2FXYzZodXQwblVleWNW?= =?utf-8?B?ZmtabWdKRVhlYUZEQ2RTQ3F6bEIxSTNiNnYwd2d1amVNQUxNcldCOGEzdjRv?= =?utf-8?B?QzJTQ2luajlOWUdKMXNia1FNSkRBMU1LK3dLbVYwVVpHWERqb3loUit4M2t3?= =?utf-8?B?dFJyT1FXRWliaWxPT0hNcm1zcTVhS2xlVWVxWkpYRG9RMFlBVFJLRkpXSDJ4?= =?utf-8?B?OWdBMjIwSlVCSENmaVdOclZOTVFGTzZaUE1QU0dtQjZkcC9oSmJ4QTM0dzh0?= =?utf-8?B?MFdaTTV0enpZUjljdkxNck9RMkxpdHdIL2o5dXRpdDFBQ2xtb1pYbVpsRzcz?= =?utf-8?B?VlF3K25WZ0xyWDc1MXdIejdlYTZ6ZTRSb2RyMklzVEltV245NmFDVG02NTQ1?= =?utf-8?B?dU00VVBHQm1TcnVuVm5IWTJ3QUJwdWJyTkoxSGJVSmZQZUNxZzludW9vNC9C?= =?utf-8?B?S2NvaklwOU1QSUZNMDlXWXNCeGtiVldlRXNUcWJYK0pYYVNicGRHSk1ZdHBH?= =?utf-8?B?SnlFSGhMem5uaTVaZFZYL1JuY3pDOUtsd3V3ZlpCRjhnNmt5VFB0WFVnaFJM?= =?utf-8?B?N1lNTUFGa3VNZkpRUnN2RmlGaHJ2em9KMjhoSU9wY3pYWW9ERzRpcXJwWTRl?= =?utf-8?B?NjhUaEZNSmxET3hEVys2ZnFxL0NsNDliOUwwWHdDOTZpU1JkUmF0NUdWcDI0?= =?utf-8?B?SHVSSDM0K2tCWDEydFd6YnZ2eHZYSUpjb0JLWDhDV0JKOExydi9NajR6M1Jm?= =?utf-8?B?SnRhK1hYblNyRUxVRjhDUENwZU1HSHdnWktCNUxiendOMkZpdUM1cjBjTVlE?= =?utf-8?B?VmdoQktqdnN4WG1ncjN5VGRxSDZjSGliNjVFY29pNGRpT2FybFJMcEw0RDc5?= =?utf-8?B?cUJPMnVpbFErVHgrSHo2a1pNTFNETTZIZ1hpOWJOVnRPVDNzSzRLaWtpRU9H?= =?utf-8?B?VHVRZzRHQmxNaXpzNU5YT0hqcHVPcG51Uk5wWWc4d1FIUkhiK0xTem96eUt0?= =?utf-8?B?SGJGTXJkNlZBbWN4aW13aVNlSUppMVBPY0lXaVA3VFRzUWNja29FR29qMVYw?= =?utf-8?B?U3l4djgvaFYwYy85TkJkKytoQi9HOTFxOXVzT3BmYkxhaFpEcGhyZjV4UFVK?= =?utf-8?B?U2F1TGFmNXBxMm1NMExic2QwSE1sRnByQlI0aTAyN0V1dWZmaGRaUHo5UDJN?= =?utf-8?B?aVZXVFJHZFBiZlNiMml6aittT2NaanRxVEpUU1hUMUhBM3ROeFhnSEtxVjhP?= =?utf-8?B?T0lsUS8yR0hUTStJY0tPakxNY01oQTV1d1ZTTjRERFNNYkt4Nm0vSWNsSG9M?= =?utf-8?B?amMyMVRCYnNydGk2QjFVbWM2djZHa2h3SUwvNUx3VU1velNVek9IcVJXOGdx?= =?utf-8?B?UEFxS0JGbzcyZisySmRjK1N2NGRyV21iRzRqSG1FVnJZZVJWMjVDT3djL05v?= =?utf-8?B?c1J4VWIyb1dsUVduTnkzTTFNSzdUS1N1dkE0WC9sTkV3a0hmN3gweC9nbGZi?= =?utf-8?B?Tldac05KTFZtakR3eWVua2VJMWhxcmhTMTBJR2hUTFBzLzVzQ0N6SllqaW1F?= =?utf-8?B?czlnazdJTEoyNGpqTVgxdzZzd3VtbkM0cEtKSy8wMitibXZHclp0MFNDTTlX?= =?utf-8?B?YXZCWmJiMkRzNTZjTmcxS3F2cjJNVjlhZExOeW5WVGdVWUJXMmhacGFTMlJN?= =?utf-8?B?WlZuN0NQUXIvRnIxdm1Qc1BzWlgvM3dTVy9DVjVRcGpyZmpiR3UvODJwWm1S?= =?utf-8?B?SFozcWZOeDA4K3FHQmxmKzJ4Nk1Va25hR01ibHgydzhWQnFueHF4VmhNMEdC?= =?utf-8?B?aUJsd3RSSVA1TytnUnNuK3l2S2laQWc4V04wbmRXbzFQSXRleEhkTFJhR2Uy?= =?utf-8?B?NEJHVEVOWXFlUk5VNElIU0tleFRzYzlxM2I4VEpIc2hmdWZzMS9GMU9TWVdR?= =?utf-8?B?OEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HoGCMVVVfn3ycyQSFTDNz4PlXxLqi9vqryWcyXEaF6ZmBkIb1PvF7Ki7GcxyF/L/9UMt4yXWOQAA/QRYrQVEsdrllv0qWjOg1p6OsRkW5CLM2K1gyMU10Ux6Hz9JSdgpxNtGpL3WyZzve5R5lGgXvDjzJ4LYDZeeCU78Vt/223lnEqV4N8Bg+/Bw6Dxq//rzuyYibuYIV7j1SIqi7W0JLb1hh8RRbadU4PtLR9HhvuOfltXx93EcrENAGeZLdZZyMpUGCcUXw5m1cWcj5MugGbAGGP5FE9KEHu1tAi1xGz7Z29a5D3n5f55+C2x5lUjfa6Ec4ZSjcHWValiodA+QkzVfzSbskCk2KQkd9u4x0Qi1Ggxdw0RihZHF3Qgh5qr398bzkWaCmlda9+XJ9Y6/1tb4A+uVCmd8TbiAdltI1aEo2leYq+/HNJaBQX67jIQf0vxGes8IBptXJv8+P3siwr5IqFP7GZ0itW/kA2Rs02u/ZTdrHlUR1YG5WZfz5zjXwRXWoPi1Fp8JLSP7KrzMN6I06shjjK3GQeEmGKJSidT41uSHlgYUAoQIWtXIzvABAWGR8T7bg1kW44IxBruQrBotHRY3GMZyOG0oE/HDaejsG1VCRQy7fEYIpHGAWiZDF3e6XrwRDky85W/7qMwU7Gl1+vEPGgtUMbmJW9K1amEzYF+BRmxO3S4mniGZSa7pY2N6LStX7z2k/kaWbhYEjkAJjp2PCTLzeGo+a0XT6ilMKwXxJ1U2xKmNOuDz7UVs6VKliSOEfRD4PmidSUx3nSI/heRfp5IH8zcFEQSKqDn+IWoKnl4no10f00K/GjTJ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 342dad2b-35b5-44d6-4af2-08db3520f630 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:26:29.0140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zLuqNaIf+5JPrF2kQ29zNh3St+uIN+9cGUci+ksz8wqV7LIW6WrVyHXaVdwBU56nVBV+Lqn7Vjgv/TrzzD8cwDSyuaAjNJQlqf7KkjJlf98= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5214 On 04/04/2023 4:01 pm, Jan Beulich wrote: > On 04.04.2023 11:52, Andrew Cooper wrote: >> These are already getting over-large for being inline functions, and are only >> going to grow more over time. Out of line them, yielding the following net >> delta from bloat-o-meter: >> >> add/remove: 2/0 grow/shrink: 0/4 up/down: 276/-1877 (-1601) >> >> Switch to the newer cpu_policy terminology while doing so. >> >> Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich Thanks. > > I take it you have a reason to ... > >> --- a/xen/lib/x86/cpuid.c >> +++ b/xen/lib/x86/cpuid.c >> @@ -60,6 +60,48 @@ const char *x86_cpuid_vendor_to_str(unsigned int vendor) >> } >> } >> >> +void x86_cpu_policy_to_featureset( >> + const struct cpu_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) >> +{ >> + fs[FEATURESET_1d] = p->basic._1d; >> + fs[FEATURESET_1c] = p->basic._1c; >> + fs[FEATURESET_e1d] = p->extd.e1d; >> + fs[FEATURESET_e1c] = p->extd.e1c; >> + fs[FEATURESET_Da1] = p->xstate.Da1; >> + fs[FEATURESET_7b0] = p->feat._7b0; >> + fs[FEATURESET_7c0] = p->feat._7c0; >> + fs[FEATURESET_e7d] = p->extd.e7d; >> + fs[FEATURESET_e8b] = p->extd.e8b; >> + fs[FEATURESET_7d0] = p->feat._7d0; >> + fs[FEATURESET_7a1] = p->feat._7a1; >> + fs[FEATURESET_e21a] = p->extd.e21a; >> + fs[FEATURESET_7b1] = p->feat._7b1; >> + fs[FEATURESET_7d2] = p->feat._7d2; >> + fs[FEATURESET_7c1] = p->feat._7c1; >> + fs[FEATURESET_7d1] = p->feat._7d1; >> +} >> + >> +void x86_cpu_featureset_to_policy( >> + const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpu_policy *p) >> +{ >> + p->basic._1d = fs[FEATURESET_1d]; >> + p->basic._1c = fs[FEATURESET_1c]; >> + p->extd.e1d = fs[FEATURESET_e1d]; >> + p->extd.e1c = fs[FEATURESET_e1c]; >> + p->xstate.Da1 = fs[FEATURESET_Da1]; >> + p->feat._7b0 = fs[FEATURESET_7b0]; >> + p->feat._7c0 = fs[FEATURESET_7c0]; >> + p->extd.e7d = fs[FEATURESET_e7d]; >> + p->extd.e8b = fs[FEATURESET_e8b]; >> + p->feat._7d0 = fs[FEATURESET_7d0]; >> + p->feat._7a1 = fs[FEATURESET_7a1]; >> + p->extd.e21a = fs[FEATURESET_e21a]; >> + p->feat._7b1 = fs[FEATURESET_7b1]; >> + p->feat._7d2 = fs[FEATURESET_7d2]; >> + p->feat._7c1 = fs[FEATURESET_7c1]; >> + p->feat._7d1 = fs[FEATURESET_7d1]; >> +} > ... add quite a few padding blanks in here, unlike in the originals? Yeah.  There was already one misalignment, and I haven't quite decided on the MSR syntax yet but it's going to be longer still. Here specifically, we've got p->arch_caps.{a,d} at a minimum, so column width is based on the MSR name. This is just a guestimate of "plenty for now". ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:35:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:35:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517985.804060 (Exim 4.92) (envelope-from ) id 1pjigL-0005Bs-95; Tue, 04 Apr 2023 15:34:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517985.804060; Tue, 04 Apr 2023 15:34:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjigL-0005Bl-5W; Tue, 04 Apr 2023 15:34:49 +0000 Received: by outflank-mailman (input) for mailman id 517985; Tue, 04 Apr 2023 15:34:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjigJ-0005Bf-Ol for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:34:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1a::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a33a9d7-d2fe-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:34:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9095.eurprd04.prod.outlook.com (2603:10a6:20b:446::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 15:34:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:34:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a33a9d7-d2fe-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4AjKKNXb1SxKoopU6MW4HnYpWop+Jz54Cx1kNOZVQswfYc8CyVCNYGu/FH+yvr032csE94MXGzMFk8Wypan//TpGcBib1ZVPd4qlgiiq0wgq341fhcA35tC6ONvhHM3owu5eNmArGW0YI53w+qNWcsaQ6XiLe7+EzH8ms2KkstSIABei/8ItT1eDm4/CrZm02TQKDo44Aeh91droynZbes9vsb4264tAea2YzURP7NLPrKQcHbN+YE1lHcWf+/Fm7AgA/UvjGDLnRyYLlYld/QeDXhBoHIx2AITxOawc7eKg0JVCXfRNWVRHv51QhZNKKZ5gF6XY1phgP4dtUmNwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NRzzlFeZvhJduDLPey9wLw9oUPxcwz4PaBTrfAGQoHo=; b=KA1Gj/WIN4MpPqxc9EGHSvWjIHj0nSHXgrEQk9B6D6utC+ZMch52xdmB8FRuEY6aw5MCNfap8OsaKZ5Z57hXlvkroi+MOBlwM2elSTWxeyGl+awUHzUzjppJX5wcoBACYUbUuVwD1lxjmrDbXT0bwVe2ae/TGUYAfDm1bXGh1VvcG3V+2NUoysZwwTmdMdrg6pQb2T+UY8J0XoaCsqq/gI9gjl47D0EJr1KZL5vxd+6Fxbu6ygFMecotaa1vz1zZtFzWEFyg+It/hp7/fa/UT6qLBM4xEmQxGdXOjIMJ+CO0GuWslv7S6u4dNyHCkFqOi8MQPHhU+JD+c8R1gKIGpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NRzzlFeZvhJduDLPey9wLw9oUPxcwz4PaBTrfAGQoHo=; b=UPttCuqCUuNktmesejqrWd/hEYoQtdPwZ678+aiVb6FlWvC2lMv43iNLSH85Prh3zqCDSjQdJzmw0VkWSrTnJrG/LjuUjf/D13EAGsy31dXQd14ZhPq4MlT9IYh66g4WBxlgAY36dUy2oCGaZkdzI//j+QA3iG2CKe1AC/fpmkSBba/p40Zywn9GYPe4LirpqY51PKJAIpufhV5tGSX7exMQ4nk1VTF1xvNZcpGrHoApSiRs1CyvJPpoABCou+S/0HTZCWXh1JJk3U7ri5/xFpWG9nkr5/302xPmhLHpE1Vs7XphIyP/duhLXq8/MqzArTE0nr7uYVVIg6CkyCnrxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <74e716df-b27f-a86b-a257-fcdc2526a820@suse.com> Date: Tue, 4 Apr 2023 17:34:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 14/15] libx86: Update library API for cpu_policy Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-15-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-15-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0209.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9095:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d111571-a369-4e9c-846e-08db35221d78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ShdmLwjbTk/PRjXIAQWKys2h4hNPqTVim0n3OJT+4VjETw7eykToX8UlDdfasF6i5LTAnIGXBuPXNPbJFB0oe4Sx/4eOiCqRHY9VG/Wo7eBkL8ijmG1cj6IS42ubnmFZfW2gLn1JKTrh4lzsaMPlXGGs2hLXefd/bzEyOY2gzmPIMyx9hyNRJIsr8hOI4F1/7uMi3D+tngtjecmtpu5cb2EeXk2FBNEv9kCvrSTKZxZNVWDinel8ke53735lXj+qwWrro6Fam8oGvbd0d1gwBvmAoj12Fdm2eKd8jbbSkSs/5+AO+bQHbasriIpuSiUX39XZoR67YgmmWiENElHQJa0oRh9ZMZWsvml9Z0hOpcFI5q+RK8ET/lCy3ZfeaEn9zX4ZzPfxsZxORey5eD7EAIr6QdpX0z/paXUewUxEDewfewMdto8TgKUX20V/xem0DVjHARI05MyXmSJ9MMORTG/fXU3OsmVr5tGTjC+GYdnywS9EQKsiI/4DZ96Nx9huKCsGt0QOJ+lkGoDpkqb4gMiZf9/pddInLrBuzlNQLtDR6NWDBPEvozpvL97cBExN8YEq/oUh1KJasQYOz4xnNsbI2tnXAErxjNqLBBUFeq4HYtAHJ9AKhgv2I71l052zYxOmaUZ2bSWoOFKWUhcpIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199021)(66946007)(6486002)(6506007)(53546011)(6512007)(26005)(2616005)(66476007)(66556008)(38100700002)(41300700001)(31686004)(186003)(54906003)(316002)(478600001)(2906002)(31696002)(86362001)(4744005)(4326008)(8676002)(6916009)(5660300002)(36756003)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WE9pL204L0ZBY2JxVlQxTFhTM0dHeWRSZ09aY0IrY1VUQ2JYampETGFySjIw?= =?utf-8?B?bFhEQnBLdzRVRHNEYlUzOEZHWnZRYVVleTNLUnZxR25ybWZYd2FRNXYxeUdJ?= =?utf-8?B?OTlEampCMi9jWVFqYTQwSVpibzNIYTJSbi9PaWkycy9GUVg4OTZpenNrWHRz?= =?utf-8?B?RXQ3REtEVERtaVJPRjFOa3czVkVIWll0c3Fkd0hmVFJDblM2eW5Rb0pzY0Fl?= =?utf-8?B?aUxyTmJhUkhOZEdBQkZEcldyZld4NkpNYnR1NDRlQXVERGNHNE84T2ZISlQ2?= =?utf-8?B?Y1lGbVBhUXBTaXZ1ODNiTVZyY0lIc1ZMVmZpMG9xRUsvaVZYMnp1dy9LQU0r?= =?utf-8?B?S1hFekF0dllDUUc2eFlzMldVS0MrVVdGL3NPSTdsV1UrUWRoQ3N5Yk1BMXcz?= =?utf-8?B?OFRnL1ZkZmZ2eGVkOHRQazBRSTBLKzROdXZhdWh3TlVzUk5oelN4MnoyV2Nr?= =?utf-8?B?L3orckFkMlZ2Mm9pMU5GTHhrM3NhMnhKMGdpa0ZqL3dtcmhWRnR6d1BoQ2xU?= =?utf-8?B?YkE2VWRCb0tvaVFtYnA1cFBRUWFzYktUamQvWGRCUVcxdzNNNENhTlZxVHNj?= =?utf-8?B?Y3hRMGorcGZ6TW8yZklQNitFV3dtNVlYcVRqa1FvNit4MFhIc3ZGUHlKOUw0?= =?utf-8?B?VE9jWDlEbzhudFhRZWtJbWpBNzlUZnpkd2I2U3drRVVTU1ZsVG90ZCt3ejNZ?= =?utf-8?B?bWZvZEhhZDQ3T05WMU1LbURnOE9sK014em8xTklXbFUyRU0xa1YvNEZNREtX?= =?utf-8?B?WGhTMTFwWVJUVjNibmFCcysyRFJvQkhkQ3lpdmxUam42TkxKUitPMUlRY2px?= =?utf-8?B?b1ZkK1EwQ1F4SWF5WTNWU1R3SDgwQWlvU0RtdWovd2x0di9XdEhJSUxYYnlC?= =?utf-8?B?NHBkMHBwR2p0ZHpPWkFKWXdYcWpDN2tUWmlwQW9aZ2pPY2lmMGY0amZLWkRY?= =?utf-8?B?SFdEaElFNlhLQWhJSUUvWC9LeFJBUnZjVExGWnNVOWZXVEx5WTJ4MEVoTld5?= =?utf-8?B?RmhXckxSUnl2YjlqVUdWT0JnLzdRREZhMEp6S3BZMUlaUFIxZk01UmQvQ2hj?= =?utf-8?B?UGlYSHYrNG41NmhIQW9pZzJXTE5UazE0b3FCb3FpcEs2T0FCcUE3U0ZkemVZ?= =?utf-8?B?UU50blVRQ3BvMWVIRHFwSTdLNjNNeFVONUd4cExrdkxDcE5lOW5Cdm1tNUFF?= =?utf-8?B?Z2VXcnhuY0NsZTZtY3VPNmorczg4UzU1WjBFRUNMR2xwQmcyeHAzcU5YWGlr?= =?utf-8?B?YlNLdVE3ZlJsZk85VWUyM0dBYzJQc1JvL2J5RTlYUjJrWm1SNGwzQkJEVEpn?= =?utf-8?B?ZkFoTFhYeFhSWHZEbDRKazIydUEydXkyeWhTaVBzYkltbmdFRXhDekVENnRi?= =?utf-8?B?a2EzWHFGMnNJMDNQVFpkKzhHQmgrSDBpenhsTjlFcTNsZVNobnl6Uml1bFFI?= =?utf-8?B?MS8wVWhzZGVPUjJoSklwQ3k4VUlBYUs4YWJ6L0dUVW9NUDd5ZzlyMGtSMzB2?= =?utf-8?B?K3RwZGc4bVJQdTVoMDI5QXlwVk5iWVdqOEx3RWZvNlVZZFhEVysrMWJxMGZC?= =?utf-8?B?ekVIWkxHSnVzMHVVQjhSVzRFM1N3MGtzRlZFSHVZR2swUkZIYnNKdlNESkwz?= =?utf-8?B?V2RUclBmaTRUdXIxSXBQaU9wd05yVmwzK3Q5V0dlb1VsTzZROHhZTGx1SHlk?= =?utf-8?B?MTYwaG1QbU9VOHhKYnJURGpEZ0VRZC9yTTdHOUpPVTB6NVgrUnFGeFQzUEhM?= =?utf-8?B?bEtFQlNDT1BFd0xiM2FYR1FKS2RDNlRDK0IvckVUNTVOVDEzajBzYXhyUW15?= =?utf-8?B?ajRIWXA3VG5YVjljZ1ZhSng5TndaajZDWHB5NXNoV3lPbGhkNUVpeXRvSkhJ?= =?utf-8?B?Q0JNT1ZvRVJCYUNwYWVTcWxXTjNZbXFSa1YvOGRJUUo1ZEVjNnNZTG8yMmJ2?= =?utf-8?B?dTRnd0dFU1NVTTE4ZGJMUXZHV1ptRkUvWTllM1NnU0REclNEWjRyQUlrTU1T?= =?utf-8?B?TTFYa2RLVVBpdldmS1ZBQ1NOakYwa3RGbjZ0NWlHd3BqQ3Vta1JHL0M4QmxY?= =?utf-8?B?Uy85SkptbmwrMWVWd01QUEVHM1hJc05jdUcwVW9oZG1Jams0OWxlak9jc3FT?= =?utf-8?Q?nwYwJXeprs1DSq0cDAV9IxeV7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d111571-a369-4e9c-846e-08db35221d78 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:34:44.5453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I4ZbXMBDog+Q9FVjWCmiUAgLtj9cegS4ayrK0HJeznx37hEvXUg+bF0VDp26z+P4wj0sbAfad+WZxhLVQ8bSPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9095 On 04.04.2023 11:52, Andrew Cooper wrote: > Adjust the API and comments appropriately. > > x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a > TODO in the short term. That'll then require passing in a callback function anyway, such that different environments can use different ways of getting at the wanted MSR values. (IOW a bigger change anyway.) > No practical change. > > Signed-off-by: Andrew Cooper What about x86_cpuid_lookup_deep_deps()? That'll be looking at more than just CPUID bits as well, won't it? Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:36:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517989.804070 (Exim 4.92) (envelope-from ) id 1pjihs-0005le-Iu; Tue, 04 Apr 2023 15:36:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517989.804070; Tue, 04 Apr 2023 15:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjihs-0005lX-Fd; Tue, 04 Apr 2023 15:36:24 +0000 Received: by outflank-mailman (input) for mailman id 517989; Tue, 04 Apr 2023 15:36:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjihr-0005lQ-9q for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:36:23 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 726b7179-d2fe-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:36:21 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 11:36:16 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5263.namprd03.prod.outlook.com (2603:10b6:208:1f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:36:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:36:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 726b7179-d2fe-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680622581; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=JUQAkjiIbs23B7Yu1hEhEOqPd/LPq69CwzaQsPDsfzM=; b=BXRenU5Fmb/3rDgTLX/+hk3NWU8j3JLhGirtck7MAtajg/SEUA073wra USYfbP2vAbwvMpIIpKLI5Lp9Fh9ZL39zvBGM0UzpxHwzGULzGcbInqYeq Ky+/j3oZj6MBpdIc2I4MC5UuGcJtvfiUHsDgpAjdJlREJTYIkNGF91FHj g=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 103085443 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:wq2F76wSdAW61fmiSOd6t+caxyrEfRIJ4+MujC+fZmUNrF6WrkUPy zdMXzjSOPuDMTPwKt53Pti3p0sF7cXXyt5kG1NrryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRiPawT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU8Tz OAoKwkhVROKndC5y7aqcPA0rNt2eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVMuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiANlKRODkqqUCbFu74GIQEBY2XkSCgae7tWGFHPdSD WIN0397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRVLufgcBRAoBptXm/oc6i0uVSs45SfHqyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CHhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:8A+cA6keXlnPWH97LIuZCLi5BnLpDfIj3DAbv31ZSRFFG/Fw9v re+cjzsCWe4gr5N0tNpTntAsa9qArnhPlICOoqTNWftWvd2FdARbsKhebfKlvbdREWndQttp uIHZIeNPTASWZGs+eS2njdL+od X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="103085443" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwnH+GSPsh06ycU4qxT6XUpBuRAhhrM6u7Wpp8caziK2Gv4W5dRG73YBH9dYH1jzLfh3stxd5MytEOEvV2z54zFFKlLiH7dceJC3+YnDRI2EObWh7li1IUureJDgA17XOzwXSLBL1VA92mRxPw6eGKkE4HHhvHDtyhY6esVpGwlSQp+Zy7AyukDCCwme+KTIjpOZyhOiTtWt8dZN43L7N1nLhy+ew6ok2ngichSBOphDKYUg7ILbGm1n8AECkhCNAo9u+x9oiGEhFOseqX1RhP9leORWzQyONtvn65NWmi4mYs8bbJJzCQDPvLmMaXkb8z9TwkwK3MtsTiEhtYP80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JUQAkjiIbs23B7Yu1hEhEOqPd/LPq69CwzaQsPDsfzM=; b=eLuh/Uo+HOXY5dIE91PcpQtLKGuSvMECavazGr0o1nDqQGlAzP9TOEnHpNSgnZc3Vt4ivRHVJmAWt9qKe7e2ijW8qHTtfkI7v3i/wk1I3boATS38HZl8f0S3fRXrN6e+9MzkfK530mHetwTCp78/uLArq1/dbx1MM3oQlEfj01F5z08jMiOEtlhqG9YAdgWEI2PQNhQDsD7hTiHcvzP3Gw/vjhbMOSyU8GDgvL0CaIWt0ZYV4AImEJsOOOaZwBjXTL2qS5RFk53mfHuZ9alamGZJkkOmG93b2fhuFxJ8LxaWw0MgOYw2bwx/V2PHbwxb5w1uTinKHAc0MaGCfnBHPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JUQAkjiIbs23B7Yu1hEhEOqPd/LPq69CwzaQsPDsfzM=; b=hocUkkrP5dq4q/PMlcYfZiRAOdCQunsVFxoBtlsEHA2ObyK3KNSSnLgn+xW9hHK7NIf10KewtaM9W4ViTFFqiKmQRSAKFW+bK3a9gYq+guqroudfGyr4KeiVF276n1Elphys3x54yRv+kQpDOg5gEFqTf+4CzEZ88urrrbMhp5M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Apr 2023 16:36:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v2 14/15] libx86: Update library API for cpu_policy Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-15-andrew.cooper3@citrix.com> <74e716df-b27f-a86b-a257-fcdc2526a820@suse.com> In-Reply-To: <74e716df-b27f-a86b-a257-fcdc2526a820@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0010.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5263:EE_ X-MS-Office365-Filtering-Correlation-Id: f33def41-2bbd-46c8-f4a8-08db35225277 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +O8QSyb3ZY0c0qvgKn9ApdkQzwx7UrvJB+B4KcdTG5Oo+isabOJ8uc3lYwJD1gqlPH6XJD7rXbxVXNHszEq+4EHolsuCmlyjTqeyB3Qc3Z1JNZcUuJlWyMHE2xv1t3mItTFCgJj+M9AutOrvXJOHkWHPPVdlINB8zkGo4ofUomhCt75MPAo0WFIiCzF12ylrgrdVRh5iehQf+bzuJPJ1ifEATSso22+XqPMcKpL5AqO3IsWmkknjVkqKi+z7KSWvzAZroUSEJf/YRZf/bLW5lOoWj5SQ1oT6EkAlIQOhs8Md3JcVbqHsN8JyLEKO8po7EBuI//0rGTB4y3rbTlbYiQHfTGo6Pq38jI34BrNrYbwFFK6sxJMiO8BrX0Wwv9wyIBwAt3v6GtBwS9k7nWYurO+tbJ7WZ/2RJUpdqtOpOTk9/ayel7Ja65haQrfDdr5ujr9qNvsSYRRD5NOs7+uJFZq7drGv5Ab12cWwgoHQeyHvl9GWBw0FJQh0J69OQtWYdMwzYqVbHNnxnntBgMoFWHms40VN67BFog2R/vNfHokT3s33yKBVtyONGaqEFs9M0+MQTQXvI75dS1le2WP5IhS9q0Nx+OynvghIV4KU09H4Y7pfMTOtLMyWqD9Tx8sa/oaQJxdtu5n05mngYsvlNg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(136003)(396003)(376002)(39860400002)(451199021)(2906002)(31696002)(36756003)(31686004)(86362001)(6486002)(2616005)(6666004)(186003)(6512007)(53546011)(26005)(6506007)(66476007)(66946007)(8676002)(66556008)(6916009)(41300700001)(82960400001)(5660300002)(38100700002)(54906003)(478600001)(316002)(8936002)(4326008)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjB1Z2pOMGxMUkRuN2FHU0JYa2NMUUdHdUdHWlNXOUMrWWxFdjJ6YktCNFZZ?= =?utf-8?B?b3FONEtGQkJuRVQxL1I0SVg1LzhkQVEvOVEvN3NKMDczWDhUcVVmejVWMDU0?= =?utf-8?B?TTJDaWFaZ2ZFN3k5QUhFMnBUTVkyRDZLMS9QMWtMVUxlenA0eUdNWkRVZGtF?= =?utf-8?B?bldGRjU5THRlb0hic0J6WHVDV2J1MmhGbEpmYWFMT1p6ODJMU1R5aXR4NVdL?= =?utf-8?B?SElEeXd3MHRqNHlaZ0FtdjMzaXhOVkZYVzd1NHdobC9PdXZ6S0RpUnA1aC9O?= =?utf-8?B?Nk1xaTd1RVFScmJkTjhwQlczUzZaL3FreDBPblQ1YWdtS29iUlR6U1pVV24x?= =?utf-8?B?aVlPN2lYT2hlcEV4Y3FjTUc0U3Ftd3NnM3hkeTZ0TGVSM2wwSzFRczRZa3hz?= =?utf-8?B?cFZsdzY3aEJaR0RzQldkbElFTTllL3pHeEE5eVEybjNibEVzMW1adEtRVzQr?= =?utf-8?B?Syt6YUZEV2M5OEs2Um5JMnVpRWFPekg0S24wRTZTQkxGR08zdW5ucDNOeGcw?= =?utf-8?B?SU04TVgyazJRSjFtREtMVXBCZ3BoYkhoUnRFQllHK01CdjJOQVM1SmdKb3M1?= =?utf-8?B?bmlXS1o1RFZwWlhhUVVHQmV4MnZaSjNnYnZrVTA0OVczcGhkMExFd2N3L0hi?= =?utf-8?B?N1ZoNEhHZUthOU9pdlNtWU5uSkR0dzVzdkpaRnJVU3JsS0RoMVhiNlc4Q1ZD?= =?utf-8?B?Uzg4RzUrM0hqaHFzZE9TRlJMbXRlTmNWb0t3N1I3YVpDR3pidmUrc2N0M25u?= =?utf-8?B?ektHaXd6SnRORkdyMDdydjVEbGM0UU5IQkFvZzNOUFpxRVM4ZTd3Q20vcnFP?= =?utf-8?B?aTVFMzMwRVF3UnVnN3FiQVZEQ0V5em9tclA5ZElNbUNSZWlEWWdjZ0U1SlFB?= =?utf-8?B?cFZ6dklaUHZwbGtCUytmalVKNWpjQ2pqVnlraWFrU3hHRFk0ZUZ1OTZlNjJK?= =?utf-8?B?TXVCZnV6QlhEeWxMc0VXUUdaODFCVW5iU2d1M2t3WW9hWmNTVXo4L0dBQ3dq?= =?utf-8?B?cmtRc0M5QW4wS1pSSGYwbEU3ZjEvZXRMd3BlcVZrZXZtNmVnR1NSUVZOSllw?= =?utf-8?B?d2ZpbnZ1R0RxYlUweWtoZXo2d2FZVGhQTGY5dDhEcm8vVGRGbFpUeUhPOUN5?= =?utf-8?B?UDEyNlk1QlRBSlhINUhJb1Q1YmF5RzNCaE4xbEtaSkdkQWVvRlpyN2NZZVR3?= =?utf-8?B?cWd5Y3lLcGJOY2VvY1RvK1B5aVRzZmZzcEJVS21CeTl5TlYwRE0ydzBHR0xw?= =?utf-8?B?RW1vbGh2NkdvRlB2dXp4NHdnYlhxa3AwMlZsZVJyVWQwblhscE5hWWZ1ekR3?= =?utf-8?B?N2JuTGQrZmlXVnRQSEtiVzdqZ1NxS2ZCY2hldHVRNXFFZ0JrajAvRFM2M3Yx?= =?utf-8?B?ekczQkFlZXpwcXR6WTJiOExwa0lPWmlDV2hjeFRBVFlUT2FGRU1xZGlzVzZU?= =?utf-8?B?b2RLVFYvOXhCdnRkalhGUTIrZkw4cHNpWUgxUUhxMUM5WXRXYzQzQk5yS1Vx?= =?utf-8?B?aEVRNnpQa01NaW5Wbm1aVDhtYms2QU4yUG5JM09HSEo3b29ERjEzMUlBWlhy?= =?utf-8?B?VS9OZjhveS9HT0JDZVhDRy9lZnJENW9mUFNzdHhObWZDWUVndDR6NXFSYmdH?= =?utf-8?B?c0YvWXBXVDhZTFhBNVNSMUZsTXQ0bjErNmd0dGFJSlJZNjR5SThDSFBxUVdN?= =?utf-8?B?VjFLcHZiVm4zdVNGSVJaR3hSK0Y4NGJLTW41VGRMMTRpYVROT1Vhak1SVHRL?= =?utf-8?B?MzVWOWhtNndKUW1oRzRoVDVlNERmZzZKNE1lN3VEN3BOZlV2ZkJRdUJlbE0r?= =?utf-8?B?TTFGWXNLZ2JKVncxbUdkc0crZkJXWXdMRmNKVWpCRHZRVHozZk9mOTdzUkxm?= =?utf-8?B?bHlDdVFHelZzWXRUVjJHQ2Q1WkR6WHliVE1PdCt4Tnd0NHIwVnNrQjVIVm9C?= =?utf-8?B?bHhsbklnZmlnWlc5VTlhSnJvbmxEWWh1L0kzRWR0ZGN4dFAwTHM4L0FaTmY0?= =?utf-8?B?Wk5YQ1lkYnFGQ2htajB4UWE2aGZHaVQ2Zk13R054VmZyL2QxR1A2d1pVUUZt?= =?utf-8?B?T3p4NkZOSm9ES2hZWjdncUE0SURCV09wVWV1QU5UZElQOTVJZlNoeWZlOG00?= =?utf-8?B?cnMxbzhzYUZYbDkwQmVjSm1Bd1VxSk04c1duNldlSGRadm1kM0hEc0RyMU40?= =?utf-8?B?dGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5losZz6Zgz1jqfFZY5kNpbAGrJv9LZsLcQmNviY6hhhAVkn23/tx5TyRQ3DjQui/fPW1gW+JOIHSLTqDVXyX4hMhIXAvmC7DKN916M68OKCAY3X3P9+Q0nvR0tlTEhLtJqedBvGLYZ+xjv7jhPCdR3antjBkt1PKwtA/bHNwu5/6yuVDW8kXXdXyeJKsePkdnEE+IqXI6CUIkwuLTE5d82cCJfIFnJalvKj1Ek0ILaqUl2KgYs0TB9KMVVdMMlsvVlUYdvtR1XgUk8/KQWA6bexn9nV0IEWBjmtaGIRJbgdSDlm3QFbK/IN51E2jhqPPYu6ot5r1+7LXqttuyyObQ1xp6kXY6KzwAN01QYHFNt0hlC6vfK4O8g4r3pnT3EvPdYOGJPV9DTo127KliwYRTCJ8rONyubB+eQDFh/xsaiXh97NBTWBy9BQX1DeWq6HJ7HUbwovDlB2VJ0Yyf1wFxktThi2Ae4z0taAM3N5DVddOsvs5QxbfzYofchUlQr0lNiBbaOA3xmD/bozYQvEQXGrjOMsCKJRg3Ai75S1vIgA2vYnoNAhpZTUmyzwGkXL+WiYE6hSV28SIibtl6Dg5zoqpyjRIwTc8e1G2wkDyscH5FVigZYY+RqbFRunriMla9/nXa4ZtdwADXfuMYs/B4+t7u13eyRrHezq8ma7iGi3WMUHWAjrVI3QqP+dLFzdB/4Fx/RysF6OZDQfqlG2Nua5ylqjO5pZ2QEKSJX8p1najXRoKbEX/x4RRo1/1MuUYiytKU/JdXxvOqx19BaPIsbu1BuS+5/OnUUsU3FfudO2VilrfUuaWiLIlflr4+DjI X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f33def41-2bbd-46c8-f4a8-08db35225277 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:36:13.9605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mQFCXW8SpmHgk7fDe+7P+unfZOzafi0yafXJcBz5nPVDjaZcLkPj4p72Opn9HxENgQOjbsUO3hdj3W8wqPX2U7QKEIpfb0uK8cdTNiyTxMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5263 On 04/04/2023 4:34 pm, Jan Beulich wrote: > On 04.04.2023 11:52, Andrew Cooper wrote: >> Adjust the API and comments appropriately. >> >> x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a >> TODO in the short term. > That'll then require passing in a callback function anyway, such that > different environments can use different ways of getting at the wanted > MSR values. (IOW a bigger change anyway.) We've already got #if __XEN__'s in there already.  I was going to add one more in the short term. > >> No practical change. >> >> Signed-off-by: Andrew Cooper > What about x86_cpuid_lookup_deep_deps()? That'll be looking at more than > just CPUID bits as well, won't it? Good point.  I'll adjust. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:37:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517994.804080 (Exim 4.92) (envelope-from ) id 1pjiih-0006KZ-Vz; Tue, 04 Apr 2023 15:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517994.804080; Tue, 04 Apr 2023 15:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiih-0006KS-TH; Tue, 04 Apr 2023 15:37:15 +0000 Received: by outflank-mailman (input) for mailman id 517994; Tue, 04 Apr 2023 15:37:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiih-0006HI-05 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:37:15 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 905ea8b0-d2fe-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 17:37:12 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 334E34CU009007; Tue, 4 Apr 2023 15:37:01 GMT Received: from eur03-dba-obe.outbound.protection.outlook.com (mail-dbaeur03lp2173.outbound.protection.outlook.com [104.47.51.173]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3prnabrcac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Apr 2023 15:37:00 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AM7PR03MB6497.eurprd03.prod.outlook.com (2603:10a6:20b:1be::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 15:36:58 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::bdd:a497:66a0:a342]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::bdd:a497:66a0:a342%5]) with mapi id 15.20.6254.033; Tue, 4 Apr 2023 15:36:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 905ea8b0-d2fe-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gi8KtCpTfwUune7wIX/QAE4BEQFpCNh3rzeu2BOTZIATozlX0m6N2HUQLtu7QOm1jAFebugUMMtx3vMXcOVIbW0RMyqTVvZskEnKcuFMuVOgHSSHban9LNa1Bc+d6cHRDtLtbv0qZSpYFOJoIEVfoGZyVvUls6ftq4hMjx84DRPd2Y4l93NTCP70uTDYTi1owYosILU6Pqbk/M7mIYLhrum6yoCldQZqJF5oNOkLZISBIY7UXqKiwhxlryYr70ywlBUjuns0HXkK24uwN0GxQ8ATEmiGaknXX6IE1ovO14w/vwyoJab36MJ681aQZ4T2jWQblgiJo6y1aoboBY+G5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PKocZPDzP6zaQ8YHNKIM3Zxni4FGkO63dFSN+bSbAcI=; b=XeIuYHJ+2YvxozHs3wLpoGwpazeDCImpnUX6mve2efRBXjOD1n8KW8hoKHfS6AEFboefL4ycbGzgKpJR0uJShIE49eZokyMSyspNWgXRiTZyHtIspg2KNOX9ST3Ob3gBCK14iimnEo1IurmkPhfXiZhKyeeLZ2xt00s3hpFqpcsNNBRKkL0N7e53nbsw7YBsgoHnnFNML4+GbpeFhZwKtMR7puyAdtRLZms3/Zfe8/H0xGbzGV2AsVxy2jZgLnlzn5SU/Hm8E8nB8ZgoNhdc/Kb6cHKXm5+EmwZt0ILGvA/jYLORB4iK1Hho9x7O/0tftI1u2g8I3Rh+ej+98hl8SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PKocZPDzP6zaQ8YHNKIM3Zxni4FGkO63dFSN+bSbAcI=; b=kcKyWQn+/AvvdxoDRYVzcjAmAyqLDAxzjC9wX/xwNXV7Ti9bSxCVRmHd0saO+hsvy5HO7LsHEGlEDg8kHUvEsXEyevk/wYHFIouuyHtTYypPrU2iMv3oPy3pLj1FEQmRMftiVht7tucpmotLVGQZL8pD6anZrFfbuhpoCj6+FbG7ARoe5FwHFn45ROWbu5ojRQ89eEa4nvAt4yslumEPJSYBatO9QVlfjUNlraPJh8K4GwlUtqnIgvom5puXE5By7EgNploIUM2Fwbz0Cpqn8JK2F2RG/GNNj7aiDLiNJq6WNy7ONCdKwUVIjmVzz+aJagOgKRKEGL9Cx5L5QIufeA== From: Oleksandr Tyshchenko To: Juergen Gross CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Dan Carpenter , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] xen/pvcalls: don't call bind_evtchn_to_irqhandler() under lock Thread-Topic: [PATCH v2] xen/pvcalls: don't call bind_evtchn_to_irqhandler() under lock Thread-Index: AQHZZg59s4tqkaRFM0qaTjkzIaVOrq8bSm4A Date: Tue, 4 Apr 2023 15:36:57 +0000 Message-ID: <9c0b195d-181e-f34c-6b42-7d7e75da901c@epam.com> References: <20230403092711.15285-1-jgross@suse.com> In-Reply-To: <20230403092711.15285-1-jgross@suse.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AM7PR03MB6497:EE_ x-ms-office365-filtering-correlation-id: ff1414c5-0aad-4191-ae65-08db35226d39 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a1Lsuo6gRzWGatT5cniIW8jID8dsTDsOrvA5vmzYgACLvLH/jm79dh9F6vGMsvuIjkxXgEbSS9VDyc63eysEiNMi7/BRGNroZytDLhRj3WkHEPtDdH1FbFeJ3hsqjY8AtWOdoYnWiR2qOXAhbl3WY4MyUE55Ddcx4tK4bS43JK80wYzMavkkCPYi5i1P2A8d5xBucEI0f/rKAV1GryUR/xN+/vXWuAXX06euXtkGBNoEzKSxy/cjChzP6f6fUflUkRpNdMS5JnkXVVna5mC3VJPveLlXE65naZVGHvC623xGWcsTyIWMmS2uJunNC2Z3xVgBUv11hCDT23KMXnrY0fKybuos01VG9HHmCjfFcU1MVmgQkjIXtJ7HLISgpH7fOZTPl2GEWUcL2tIxDOX9xTfr74ZTojN0RWyTDyAl0r9BVf6S/+UCXM+T3CLV7K9S6VnwNf+TSP1NYSx6XaYiLdfQ1Ie5M6ngTfYLYcnemJ4643w+1EegXD2fLMJTiJGX0/F9C9wp2WUbFbW3A3ij3Z0XrrwiyZE8NrWCAQH/fbtTT6xydRrEhgtv2eKpKjEToN1xMfYB9yB/fHPuzpDK0xbqoM6esZ3kWXsAb4XMa6bnlYt6wxDUgs352B/5aYLm4JvaqEYo6KNtDj9lVV9hhw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199021)(66946007)(6486002)(6506007)(53546011)(6512007)(26005)(83380400001)(2616005)(966005)(122000001)(66446008)(66476007)(66556008)(38100700002)(41300700001)(71200400001)(31686004)(186003)(54906003)(316002)(478600001)(2906002)(31696002)(86362001)(91956017)(4326008)(64756008)(76116006)(8676002)(6916009)(5660300002)(38070700005)(36756003)(8936002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OUFWUEFSWGRaa3N6eWNaNXhCT0w3RDhJOFE2Z1ZBRVBnenphTFBGS3lvVVls?= =?utf-8?B?Vkh4YVNmNlZEZE9RK0djUC9VUVREWTU2RWExRUNQaU9rZTJISkdwSVh0ZUlV?= =?utf-8?B?Vk1YaEZjZFhVWmUxMEIxdkI4bnRCSWFkWmxmb0lJRlp3SC9mT3lTZnZleXNu?= =?utf-8?B?Um9nRFpNejQxTzFPcllBNENOTDBLdjN5UnNLaTE1d3VseU5JVDFwbExlSWxa?= =?utf-8?B?b2pweGE0Tk44a3VPeitOeVU5cVJVOTdmajBJV0NZSjlWWXZJWWVZaVhrK25k?= =?utf-8?B?RndmM1RuNzMxZ2tFWjVHdCtycXJoRGRzVUZvcFY0RDlldGYxWnlzV2JDNXlv?= =?utf-8?B?U05TbFEwY2RESEVGdENGRG9JeUdlZmRhcEllUHRkaGp4K09IOGZMYjd5ZWVL?= =?utf-8?B?eE9acW9telVBYitsdEZ4dVpsRXp2RWRQMVNscU5iVk1mbkhFUmZ6OFZPbEVN?= =?utf-8?B?YzJHRFQwWHdIMWtwaCszWkV1NVlrR0FMcmVyU00xTG8xRzBjYzNqbHZ2bVNn?= =?utf-8?B?MkZoRlVVNnVyWWN3OE52L0NzbUVQNk1adTlMcDNxU0xqSktZdWFMVWFNRVVM?= =?utf-8?B?T2J1WjR0ZVFsdHd4RDZuL21SUkpqNFJPR1FNSDNrTStHNTM4b1hFWmxoOGhh?= =?utf-8?B?TkIvMXhyZ2E4R2wvbFNkb21YdFk3dzZBSk1qRXlBWHBlOXVPTGJFTkhEMkRT?= =?utf-8?B?TWc5WUlOMld0RWtibnB0RXBXcVJrTUt6UW9UOTFuTkdrVzg0VW95NjF6bkc1?= =?utf-8?B?aHJjaWtzZUNkQnJhOUhCWXZLVVFMSHorUGIraENlTlZ2OVdJZWd3NFFQWFdK?= =?utf-8?B?WDNqN2s2Q3l1Zm9KdnNEcXloV3A2bFdCRmYwVldBOUVVZnZvL3ZteVErenRo?= =?utf-8?B?L0hzdmZ2RzAvRG1JYUpqckZDdTloV0ZkTlFOOTdRaWZMQVo5eGJtN1RldVRZ?= =?utf-8?B?dXl2UjMydXk0Y2ZLalJCenFSRG5CWjZVVitmRnJwdmt0ZnZQL2twOW1VV2s2?= =?utf-8?B?Q3R1L3ZNY1RPNkh0Q01xbkVJOXh5Q1ZpQXg2Y0o1R2hyTzlENi9Ld3pTUU1u?= =?utf-8?B?dk1sRm1YZ09wRjRCUGxvWHNSVmQyT0EyY3BtOFo2ajk4S0xwSGxDUzUyM0o1?= =?utf-8?B?UVBYc05xakRJemlNZCtsOVNHVjNnWVBCdkM4U1AzNmVUamFRTWRIekRiOXgr?= =?utf-8?B?U3BERlpYemJuNURPb0N5bytwbWtCdHlkN0tnVDZJYWE2NnoxSzFhWHBuUkZv?= =?utf-8?B?NmtxT3dqTDY2cS82eXQ4czY5SmU1eThObllrWG5aUmVhWXlPcEkvNVFxcWJE?= =?utf-8?B?VlZQNGVVR0R1cGFNRkp5WCtQQ2VyL2tWTEFRR2JUOUtjdStJZS9qMWFZOG5a?= =?utf-8?B?ZytYYXNERUd5ck8vY25zNnNMVVlUSDdwQWhjUmgyYTRicVh5VmFYRU1KdEdH?= =?utf-8?B?SHJvUGZTSjNnQU4zblVpVmkxSHRjd3Ira29EbXp3TC9hK01QYldxVmVSUE9F?= =?utf-8?B?MEJsUXBNc0lBclZZd2RBNjRMbkczVURSZkwzZm5FSHVzbHNnUHljNTVWUGhV?= =?utf-8?B?a0tGVVlIekw3N0wvTmdKdnBMQVdxY0hEL093bFhUamhTcXQ5VGFDdmkrNVlC?= =?utf-8?B?ck5lWStST0pCZldibGNSRW12Vld5Y2tBa3lxWXdLb1FvN1ZEMXNSWVppbkov?= =?utf-8?B?eUxWRk1OdVZ2NW1EMmlEcnlOWURWcHo3ZklEZk9BaGtlVTBNdVVTL2hTRFNm?= =?utf-8?B?QXJkMXo1MDRVVEM4MjBmWE15cldELzFqK1VhRkhaM25KSUhZOGMvbFV3UGJt?= =?utf-8?B?bTUwWE1MdFQ1VFdXUnNBa3p2bTV4cnprUVB6ZUF4SlE0eTYrdzhuUEEwb0ZO?= =?utf-8?B?L1lvZXpEVEJqTUpVQkNEWkZHSTA3bnorYklPNXArcWd5ek9nUDBVc1V1T2U0?= =?utf-8?B?OHByZ2YzSTFjUjYzUHcwY1FleE5BRHZrSTR0bzBnQkZ6VHdIc3hWcGlRU3F2?= =?utf-8?B?RGpXRUVpSnhWSkFWQzY3K1JDbDNBSi9mMXZseTlnbDl0S3drSXU0cmd4ZVIx?= =?utf-8?B?Y09KL2RCbzJQQnIweDVNUmViSkdWbnBxVEV4SnVoYUl0UXVLcUdidU5Lc01q?= =?utf-8?B?QS82ZjcwY0ZVbm8yOGQ4T1dZRkVwQVlndDdzbjlYN3RXZ0VhbE1kZzBHaUhS?= =?utf-8?Q?OgR1sj3/VJJGxZ10EO7xG1s=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <79D6B25CF8F4024C906AC9FE71CB979D@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff1414c5-0aad-4191-ae65-08db35226d39 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2023 15:36:58.0108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: heFIkc22fH/IuXh4nrj466lbfx7hM1xyKvNw0Nbl7mck+r3PePMDcUmJY+NqNJ+vLgXYG4oIXBLigLA2qySVJrM8AdXmZX2GlMJI2ssZRJY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6497 X-Proofpoint-ORIG-GUID: YrqL6bX1DrWCmLv2kdDaV9yGdaEas3wu X-Proofpoint-GUID: YrqL6bX1DrWCmLv2kdDaV9yGdaEas3wu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-04_07,2023-04-04_04,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 clxscore=1015 suspectscore=0 phishscore=0 mlxlogscore=769 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304040144 DQoNCk9uIDAzLjA0LjIzIDEyOjI3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KDQoNCkhlbGxvIEp1 ZXJnZW4NCg0KPiBiaW5kX2V2dGNobl90b19pcnFoYW5kbGVyKCkgc2hvdWxkbid0IGJlIGNhbGxl ZCB1bmRlciBzcGlubG9jaywgYXMgaXQNCj4gY2FuIHNsZWVwLg0KPiANCj4gVGhpcyByZXF1aXJl cyB0byBtb3ZlIHRoZSBjYWxscyBvZiBjcmVhdGVfYWN0aXZlKCkgb3V0IG9mIHRoZSBsb2NrZWQN Cj4gcmVnaW9ucy4gVGhpcyBpcyBubyBwcm9ibGVtLCBhcyB0aGUgd29yc3Qgd2hpY2ggY291bGQg aGFwcGVuIHdvdWxkIGJlDQo+IGEgc3B1cmlvdXMgY2FsbCBvZiB0aGUgaW50ZXJydXB0IGhhbmRs ZXIsIGNhdXNpbmcgYSBzcHVyaW91cyB3YWtlX3VwKCkuDQo+IA0KPiBSZXBvcnRlZC1ieTogRGFu IENhcnBlbnRlciA8ZXJyb3IyN0BnbWFpbC5jb20+DQo+IExpbms6IGh0dHBzOi8vdXJsZGVmZW5z ZS5jb20vdjMvX19odHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sL1kqSlVJbDY0VURtZGtib2hA a2FkYW0vX187S3chIUdGXzI5ZGJjUUlVQlBBIXdUeVUwMzJQUVB4cWxwSWZ1V1J3Yi1EWUUxSzhQ MGJSV0p5SklDYTdJRWJBd1EwX2FlWndrbkFXd3hKX2N2X3RXR1k0MmY1TlBnbjZKSHRac2lHUCQg W2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4NCj4gLS0tDQo+IFYyOg0KPiAtIHJlbW92ZSBzdGFsZSBzcGluX3VubG9j aygpIChPbGVrc2FuZHIgVHlzaGNoZW5rbykNCg0KDQpSZXZpZXdlZC1ieTogT2xla3NhbmRyIFR5 c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KDQoNCg0KPiAtLS0NCj4g ICBkcml2ZXJzL3hlbi9wdmNhbGxzLWZyb250LmMgfCA0NiArKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDIw IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3B2Y2FsbHMtZnJv bnQuYyBiL2RyaXZlcnMveGVuL3B2Y2FsbHMtZnJvbnQuYw0KPiBpbmRleCBkNWQ1ODliZGEyNDMu LmI3MmVlOTM3OWQ3NyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94ZW4vcHZjYWxscy1mcm9udC5j DQo+ICsrKyBiL2RyaXZlcnMveGVuL3B2Y2FsbHMtZnJvbnQuYw0KPiBAQCAtMjI3LDIyICsyMjcs MzAgQEAgc3RhdGljIGlycXJldHVybl90IHB2Y2FsbHNfZnJvbnRfZXZlbnRfaGFuZGxlcihpbnQg aXJxLCB2b2lkICpkZXZfaWQpDQo+ICAgDQo+ICAgc3RhdGljIHZvaWQgZnJlZV9hY3RpdmVfcmlu ZyhzdHJ1Y3Qgc29ja19tYXBwaW5nICptYXApOw0KPiAgIA0KPiAtc3RhdGljIHZvaWQgcHZjYWxs c19mcm9udF9mcmVlX21hcChzdHJ1Y3QgcHZjYWxsc19iZWRhdGEgKmJlZGF0YSwNCj4gLQkJCQkg ICBzdHJ1Y3Qgc29ja19tYXBwaW5nICptYXApDQo+ICtzdGF0aWMgdm9pZCBwdmNhbGxzX2Zyb250 X2Rlc3Ryb3lfYWN0aXZlKHN0cnVjdCBwdmNhbGxzX2JlZGF0YSAqYmVkYXRhLA0KPiArCQkJCQkg c3RydWN0IHNvY2tfbWFwcGluZyAqbWFwKQ0KPiAgIHsNCj4gICAJaW50IGk7DQo+ICAgDQo+ICAg CXVuYmluZF9mcm9tX2lycWhhbmRsZXIobWFwLT5hY3RpdmUuaXJxLCBtYXApOw0KPiAgIA0KPiAt CXNwaW5fbG9jaygmYmVkYXRhLT5zb2NrZXRfbG9jayk7DQo+IC0JaWYgKCFsaXN0X2VtcHR5KCZt YXAtPmxpc3QpKQ0KPiAtCQlsaXN0X2RlbF9pbml0KCZtYXAtPmxpc3QpOw0KPiAtCXNwaW5fdW5s b2NrKCZiZWRhdGEtPnNvY2tldF9sb2NrKTsNCj4gKwlpZiAoYmVkYXRhKSB7DQo+ICsJCXNwaW5f bG9jaygmYmVkYXRhLT5zb2NrZXRfbG9jayk7DQo+ICsJCWlmICghbGlzdF9lbXB0eSgmbWFwLT5s aXN0KSkNCj4gKwkJCWxpc3RfZGVsX2luaXQoJm1hcC0+bGlzdCk7DQo+ICsJCXNwaW5fdW5sb2Nr KCZiZWRhdGEtPnNvY2tldF9sb2NrKTsNCj4gKwl9DQo+ICAgDQo+ICAgCWZvciAoaSA9IDA7IGkg PCAoMSA8PCBQVkNBTExTX1JJTkdfT1JERVIpOyBpKyspDQo+ICAgCQlnbnR0YWJfZW5kX2ZvcmVp Z25fYWNjZXNzKG1hcC0+YWN0aXZlLnJpbmctPnJlZltpXSwgTlVMTCk7DQo+ICAgCWdudHRhYl9l bmRfZm9yZWlnbl9hY2Nlc3MobWFwLT5hY3RpdmUucmVmLCBOVUxMKTsNCj4gICAJZnJlZV9hY3Rp dmVfcmluZyhtYXApOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgdm9pZCBwdmNhbGxzX2Zyb250X2Zy ZWVfbWFwKHN0cnVjdCBwdmNhbGxzX2JlZGF0YSAqYmVkYXRhLA0KPiArCQkJCSAgIHN0cnVjdCBz b2NrX21hcHBpbmcgKm1hcCkNCj4gK3sNCj4gKwlwdmNhbGxzX2Zyb250X2Rlc3Ryb3lfYWN0aXZl KGJlZGF0YSwgbWFwKTsNCj4gICANCj4gICAJa2ZyZWUobWFwKTsNCj4gICB9DQo+IEBAIC00MzMs MTkgKzQ0MSwxOCBAQCBpbnQgcHZjYWxsc19mcm9udF9jb25uZWN0KHN0cnVjdCBzb2NrZXQgKnNv Y2ssIHN0cnVjdCBzb2NrYWRkciAqYWRkciwNCj4gICAJCXB2Y2FsbHNfZXhpdF9zb2NrKHNvY2sp Ow0KPiAgIAkJcmV0dXJuIHJldDsNCj4gICAJfQ0KPiAtDQo+IC0Jc3Bpbl9sb2NrKCZiZWRhdGEt PnNvY2tldF9sb2NrKTsNCj4gLQlyZXQgPSBnZXRfcmVxdWVzdChiZWRhdGEsICZyZXFfaWQpOw0K PiArCXJldCA9IGNyZWF0ZV9hY3RpdmUobWFwLCAmZXZ0Y2huKTsNCj4gICAJaWYgKHJldCA8IDAp IHsNCj4gLQkJc3Bpbl91bmxvY2soJmJlZGF0YS0+c29ja2V0X2xvY2spOw0KPiAgIAkJZnJlZV9h Y3RpdmVfcmluZyhtYXApOw0KPiAgIAkJcHZjYWxsc19leGl0X3NvY2soc29jayk7DQo+ICAgCQly ZXR1cm4gcmV0Ow0KPiAgIAl9DQo+IC0JcmV0ID0gY3JlYXRlX2FjdGl2ZShtYXAsICZldnRjaG4p Ow0KPiArDQo+ICsJc3Bpbl9sb2NrKCZiZWRhdGEtPnNvY2tldF9sb2NrKTsNCj4gKwlyZXQgPSBn ZXRfcmVxdWVzdChiZWRhdGEsICZyZXFfaWQpOw0KPiAgIAlpZiAocmV0IDwgMCkgew0KPiAgIAkJ c3Bpbl91bmxvY2soJmJlZGF0YS0+c29ja2V0X2xvY2spOw0KPiAtCQlmcmVlX2FjdGl2ZV9yaW5n KG1hcCk7DQo+ICsJCXB2Y2FsbHNfZnJvbnRfZGVzdHJveV9hY3RpdmUoTlVMTCwgbWFwKTsNCj4g ICAJCXB2Y2FsbHNfZXhpdF9zb2NrKHNvY2spOw0KPiAgIAkJcmV0dXJuIHJldDsNCj4gICAJfQ0K PiBAQCAtODIxLDI4ICs4MjgsMjcgQEAgaW50IHB2Y2FsbHNfZnJvbnRfYWNjZXB0KHN0cnVjdCBz b2NrZXQgKnNvY2ssIHN0cnVjdCBzb2NrZXQgKm5ld3NvY2ssIGludCBmbGFncykNCj4gICAJCXB2 Y2FsbHNfZXhpdF9zb2NrKHNvY2spOw0KPiAgIAkJcmV0dXJuIHJldDsNCj4gICAJfQ0KPiAtCXNw aW5fbG9jaygmYmVkYXRhLT5zb2NrZXRfbG9jayk7DQo+IC0JcmV0ID0gZ2V0X3JlcXVlc3QoYmVk YXRhLCAmcmVxX2lkKTsNCj4gKwlyZXQgPSBjcmVhdGVfYWN0aXZlKG1hcDIsICZldnRjaG4pOw0K PiAgIAlpZiAocmV0IDwgMCkgew0KPiAtCQljbGVhcl9iaXQoUFZDQUxMU19GTEFHX0FDQ0VQVF9J TkZMSUdIVCwNCj4gLQkJCSAgKHZvaWQgKikmbWFwLT5wYXNzaXZlLmZsYWdzKTsNCj4gLQkJc3Bp bl91bmxvY2soJmJlZGF0YS0+c29ja2V0X2xvY2spOw0KPiAgIAkJZnJlZV9hY3RpdmVfcmluZyht YXAyKTsNCj4gICAJCWtmcmVlKG1hcDIpOw0KPiArCQljbGVhcl9iaXQoUFZDQUxMU19GTEFHX0FD Q0VQVF9JTkZMSUdIVCwNCj4gKwkJCSAgKHZvaWQgKikmbWFwLT5wYXNzaXZlLmZsYWdzKTsNCj4g ICAJCXB2Y2FsbHNfZXhpdF9zb2NrKHNvY2spOw0KPiAgIAkJcmV0dXJuIHJldDsNCj4gICAJfQ0K PiAgIA0KPiAtCXJldCA9IGNyZWF0ZV9hY3RpdmUobWFwMiwgJmV2dGNobik7DQo+ICsJc3Bpbl9s b2NrKCZiZWRhdGEtPnNvY2tldF9sb2NrKTsNCj4gKwlyZXQgPSBnZXRfcmVxdWVzdChiZWRhdGEs ICZyZXFfaWQpOw0KPiAgIAlpZiAocmV0IDwgMCkgew0KPiAtCQlmcmVlX2FjdGl2ZV9yaW5nKG1h cDIpOw0KPiAtCQlrZnJlZShtYXAyKTsNCj4gICAJCWNsZWFyX2JpdChQVkNBTExTX0ZMQUdfQUND RVBUX0lORkxJR0hULA0KPiAgIAkJCSAgKHZvaWQgKikmbWFwLT5wYXNzaXZlLmZsYWdzKTsNCj4g ICAJCXNwaW5fdW5sb2NrKCZiZWRhdGEtPnNvY2tldF9sb2NrKTsNCj4gKwkJcHZjYWxsc19mcm9u dF9mcmVlX21hcChiZWRhdGEsIG1hcDIpOw0KPiAgIAkJcHZjYWxsc19leGl0X3NvY2soc29jayk7 DQo+ICAgCQlyZXR1cm4gcmV0Ow0KPiAgIAl9DQo+ICsNCj4gICAJbGlzdF9hZGRfdGFpbCgmbWFw Mi0+bGlzdCwgJmJlZGF0YS0+c29ja2V0X21hcHBpbmdzKTsNCj4gICANCj4gICAJcmVxID0gUklO R19HRVRfUkVRVUVTVCgmYmVkYXRhLT5yaW5nLCByZXFfaWQpOw== From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:37:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.517995.804090 (Exim 4.92) (envelope-from ) id 1pjij5-0006nq-7I; Tue, 04 Apr 2023 15:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517995.804090; Tue, 04 Apr 2023 15:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjij5-0006nj-4R; Tue, 04 Apr 2023 15:37:39 +0000 Received: by outflank-mailman (input) for mailman id 517995; Tue, 04 Apr 2023 15:37:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjij4-0006nR-AF for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:37:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0601.outbound.protection.outlook.com [2a01:111:f400:fe1f::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a019c2d6-d2fe-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:37:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7818.eurprd04.prod.outlook.com (2603:10a6:10:1f2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:37:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:37:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a019c2d6-d2fe-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ss6mEVYZxtrSuSiHJFFHBUVGrlVgNYSmPZKPnC9gd/dk5PhAgiU7wO+mkp/ZHlBooCkHog6WNe+fwjaozsZdptjBxO5v40BPonLu9QN078JEKWnNGf+ciJbWbgR1t1sZiHzqjjU76fK+cgeH7Vi4OrYjO5J3SCQzVpZS99gQvoK16U+BQUlnnDGAZWTfWd2SyccA8wFWQXMJnyTXIXG1EdSHwa9RZ92I1AEyq8VAZJ3CTJkEnzdwkGs/6ktwAH/DodZP9DLcPbW+ZxTZ+2JMn6PR9Ie2J+ML32KiEgQtCKGXIfBkT4/syGOKLEIjR86jBw5NPhS3j79qFo4o1kYAXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=14ddhLCYch+LjmllLCbgc6txJlddcQ2MeHG303rRx20=; b=ErPsOFog8cfLt5vbdqatYRmOpCZmG4zfXpaedBxNZX2QQ89uiM4aXBqS8GYnUecjJL/xhUDDRTgm9iPHbMeyPzgVML/cmda4juOeBMorrwWgdkxnWEUULoumJAFplcbl8OGb0/sz6msO17OmsQrfDSYxHjduTkyz/hOIY7wlZJKG+LsNDa1cs2P5Jnz0DGXhaxJODeIC3AnQAZG2dJG8YGzbVLqJGHuNKc2p12V7v8xaCCNgNf/Oem9zb/vwYqmfD5OOnJJ0OS8dPNQMO2WPptRCVGH52MaqwIkAVPPr0YKRXTOjlOo3KLhjPJk/gqvSWTS3SZuofil4LtYYNyPqVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=14ddhLCYch+LjmllLCbgc6txJlddcQ2MeHG303rRx20=; b=DA3juulYJKMUnEqJdZOQmjLcQxKfEmS3Wr5pB1N6AmFfX1wZU3GKz/LsHgusnuiNDJUzJL8r9SRJRQQ1VPitxd8khTfRnVlNublMmJ3xEXRHmcmH2DgxtJHTZCAX+naWqRmaB2H+SV3QSxGHti0k7W0BgkktupKluw8r9p5J0oUm/o5sWv70fdxrC5PPhb47dgcn25VU670FFy62Ct+sKz9Q99uChq5YmN6yKF0GVPZhV9gK5CZhYmcJNqIlTiOyByK5hSnCz5SlsZTuoRSFf4zJnzD6/HgABU0Du9AtcOk9+8rDPQPEJdXI4QcVfWBjkMWSXsKpu9pzydKTYCo8Xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5abc440d-a484-34a1-589b-420902d44d6c@suse.com> Date: Tue, 4 Apr 2023 17:37:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 15/15] x86: Remove temporary {cpuid,msr}_policy defines Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-16-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404095222.1373721-16-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7818:EE_ X-MS-Office365-Filtering-Correlation-Id: 893548af-ce87-480e-3bbb-08db352282ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U1snMlMci7TBwWBm/r/hTsjK5NjtDfLKfyofl/Gle8Rbp+PY1CsZ1gkvqMg0C/lB+y40Fxxe4T3m7giL/6wnhPXEXWRQhn8TQyNkuw+w0tJv3Sk7R7Qhfn1FqkUKSS7qLMoYaqEwj+HzFF2mB/151dzdF2joBxK7HrxyvWjPbjT3UkvYo/uGi/bEz+QvNvbsKqLcO9wKr4Y28iLYX9yxg6gQP/f06l7GzX/2ETqE/J1UTqDlYp64SGvYMi0AIRecTBdy4URipGE7MaJwzsaDbELn8oe9iBd2rAJ7MZZ8gc8UlpQc7QXZbBIzdOyCLWS8OkXX+Dx5iL/siBShoHlNIYt7bVuiIGqQCu0o4nh918BuRRtTjx1J+TxCpvac3H176RPh2YMSgy5Tcn228qrrn9YPo0sU/4axKnOJCyJRcdes7MCfnOSYA4zK8gO9q96q5AWSvQX6ddgk4RVyB/6a1/SOmZ0pY1fKWxkMZRTGcqTyBs3wX0j3vj2E2O2W+NNjCLJNY7YTO0Y1hOxL8zyTBWuH66jwP5Z0zi8K8N6EqzfbuLy3z81tsd2fqu0xKAzdT6kRj09UyJRlaHiN5pgIpmvNybwAVf32Suujq6lMuHXw+Q5De1XGuGvRzmimBEXsEqu47kETk8HvrWFq+85eLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199021)(8936002)(5660300002)(38100700002)(83380400001)(86362001)(31696002)(2616005)(316002)(54906003)(53546011)(558084003)(478600001)(186003)(6486002)(26005)(6512007)(6506007)(66476007)(6916009)(4326008)(8676002)(41300700001)(66556008)(66946007)(36756003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVVUN0UycFhqUEIvT2k3M3lsclF5dGVlaVZtWEI0WjI2aThwdExqSi9ycE5s?= =?utf-8?B?UWZiT1VpNWpSOVlBSWN4c0hrekptTUNNL1VQdUFkejRxZmprZU9ybHhBaS80?= =?utf-8?B?VCtuQ3A3aVN3ZFNQY0NoNDRvSnhPYnBJVGVUTzVxSWJ1N1BDcXY1VnZGS3Vh?= =?utf-8?B?ekJJUkNDRWJ2bzg3MFlEZ3I0UXpKYkF3N041azF2YVc2blZEdjFjM1VyL2J1?= =?utf-8?B?R0hvMk14UmszY0FRVElUNEFBSE43dGY3V1lhOHNKS0tVR0pxcjhFcEJKaHB3?= =?utf-8?B?Q1RQL0FvcWJ5SEx5NlRsN2pYMk9waEprM2VpcTIveTVvYlFYZEJSQloxeTAx?= =?utf-8?B?ZlNWOTlnMktaa2hWblI3TXNqb0FCcWxPNjRKRUM5ZkJTMzg0aXZIZHJjSDY1?= =?utf-8?B?Wkd0b2tFd0lNK3h4NTVjK3drTUwzYU9wc21aZGNmQit3U05lN0U1TkJpZHFw?= =?utf-8?B?WnRDczBYazZVcDUxUklkVXBZQ1hVd3U0ZHFlRG4raURJN0d1YnFUckFFT1lD?= =?utf-8?B?a2dld3V1SmFwM3IwNHJzQTVhWHorRndUR2RrQ2N6SlozMnUrVFFFbTdKZ0tw?= =?utf-8?B?SVprd3haQWJVSnNQRnZ6cW5iSi9OTytZOGR4OENtOThDenFpUTFtVHAzcVMy?= =?utf-8?B?UFp6R2tDaXZIaElXMEZoWWlqQXVjR0NRcEpsVUVUM09nMFYxQlVtWkhDVnh0?= =?utf-8?B?NU11aDZYejNocFZucFFRVFg5dHQ0WDlsNlphSUhnTVJJUzNZMDZLMWkvQjcr?= =?utf-8?B?cThJaE0xQ3l2MThOd1NWN0dGSWdqbEdNd2NqTGM3K3E5SmJueG43WGxxLzBz?= =?utf-8?B?OU5OQ0V1aFpTbFNVSjBaK2xWOVlQcE9ncEdQS1paUUtZTjVsbGFqZzJpaEdy?= =?utf-8?B?UHo2SmtxYWdHT3NJZmcybHJrVkd5K3FDMkkraXRsU243L0xNU0JmaHhhTlNv?= =?utf-8?B?d0FtVGN6cWc1NkZGVlVTRXV6cGFuYXgxVnNlSHA3YzNLTFVCODkxWlc2WEx1?= =?utf-8?B?WThkKy9zVkxhRVZaQ0NhM0RrM0lJRDZvQ2ExaXpLR2FzN0U1VDRkQllmVFlZ?= =?utf-8?B?WFU4UitFNnRlQ2I0NmFpOWhiR2k3WWI3SEtBdHRxVzg5WTJWYzdSL2twZWsy?= =?utf-8?B?QU4rOXpJbUs3UHhnV0EremZYNGI0VWhEQnFSa1hSeEUvbzlPZFBQektPdEVh?= =?utf-8?B?OWlsVGFlandSMmk4bjdKK1NvVXhlNHBJOTVlbFBGSVRoQXJpdys4TWh0NVFp?= =?utf-8?B?TVdtS29VTzMyc2F3SVoraUpBYTFyamtCWGNua1o0a3U0NWdINzlqa0ozUVd6?= =?utf-8?B?U2tUSHJydWx5Y3M3NDlQdnhOeEYwbmkwdjdPaTBqZ2dqTjBsdjFETWhWNnhl?= =?utf-8?B?cWZvZnIvZ3hSWEVHTmtOQmpqWWMrTlRPTEtJSG5yOVVZQmtKNWgycDlvczVm?= =?utf-8?B?czl3MmNpanhaMFZUUHBLWWRuZ2hXWnNOZk1tNUJBM2NEK3IxVkpaT0dzaXBV?= =?utf-8?B?MWlkY1daU1JXRmNCaW9NYkVZVlRvQVI3Q0hmSEd3YXNXM28wQzVybG1OUVV5?= =?utf-8?B?V0xaUWdNMHFML3BxM1o3SnA1ZXRsTlZwNUMxZ0RDb0hhUGtlN2FDN3pnWFBt?= =?utf-8?B?a21TZ3VDclA1WkxxeUFtSGNYK2JYSk03WDZnQ0s3YThjOFFqSEVhcG8zeERz?= =?utf-8?B?TCtlaE9LbGFKaGI5by9RaEtRZHQzaGJ5Si9aWlRWQzJsMkl0RkZYeERSWHJ1?= =?utf-8?B?VUtRcEtnZzJTcVZ4M1hpdUJuN2Vub05YZVZqN0wwSklLa1BkTHVTVUptZ24x?= =?utf-8?B?OGtJNk16Z2cvc1cxcUJhQTl5Y2hONERGNEo0UjR6QTkvbVNTR2NVcnh1d0d6?= =?utf-8?B?cE92Vkk0b3k3amV1TUdOckk1VDBDa1gxM2l0MGQ3T3JGM3BLUzRNNGZibjFZ?= =?utf-8?B?Q3FPK2pLSkRjN2s1bG1NZURaVXBtRzJaSVJvenNwT1dnYTV0eUlEbWg4TDZB?= =?utf-8?B?TEY4bDRlREJaSnF3YUxBNW12NEFhTm5YU3JTekJFL0FMRk95ZkhCYmVOMFpw?= =?utf-8?B?S1VnYXB3Umx3VEY0V0Y3OVFvS3lqWTQxaTZtdG1wWW4zRk12eURmL21OOVU0?= =?utf-8?Q?VJegFsx0vWKmsN8ts84ZbiqMu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 893548af-ce87-480e-3bbb-08db352282ae X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:37:34.2467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JF+c51SdEOCP2+ywgvXhNrF7Aei2KGMr4dMfGUhuEiXXXIjJpDmhNSgd5Yj48w+riBrDnEhZxA8fcFPWgw8NiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7818 On 04.04.2023 11:52, Andrew Cooper wrote: > With all code areas updated, drop the temporary defines and adjust all > remaining users. > > No practical change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:45:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:45:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518003.804099 (Exim 4.92) (envelope-from ) id 1pjiqW-0008VW-Vu; Tue, 04 Apr 2023 15:45:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518003.804099; Tue, 04 Apr 2023 15:45:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiqW-0008VP-TI; Tue, 04 Apr 2023 15:45:20 +0000 Received: by outflank-mailman (input) for mailman id 518003; Tue, 04 Apr 2023 15:45:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjiqV-0008VG-Ts for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:45:20 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1bc3d2b-d2ff-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:45:17 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 11:45:14 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6774.namprd03.prod.outlook.com (2603:10b6:303:178::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.23; Tue, 4 Apr 2023 15:45:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 15:45:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1bc3d2b-d2ff-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680623117; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=natFjPgAl7txcGRKd3B57/LBN2sPc/aWTAD6a6f26Ic=; b=AoJP7Mo6SG49VZZVxJ5/fv9L7/KuLKsqISAgBj+xnNSQbWwnwFar7TKA R8TPZe47Ddjmr0EqLAmZLJy6rUN9ih8Kvxn3DPJEPIG2vUwNTOBv2EXs1 cQPM/+XUrHw3Oge7LphKtXbcXH4Ww1sf5YZvN6g8iSemSzfcOM5thG/T9 A=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 104324439 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rPpuEKtxc795TysPU4fLfUfc9ufnVHtfMUV32f8akzHdYApBsoF/q tZmKT3Tb/qJYzb3eop+aNuxpkgAsMOHndI2TwNt/yAyQylB+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGyyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwc2o0UhaB18mM2OzrdsRViJ15dev6I9ZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4C9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqqUw3AHIlwT/DjVHVXWfu8P+lnWQSvV1L m86y3QhpvI9oRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2gheRSN9mSfSxloesRmu2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:59KGOahpJr2OVMJT8QakuOCf/HBQXtUji2hC6mlwRA09TyX4rb HKoB1/73SftN9/Yh0dcLy7V5VoOEmskqKdgrNhX4tKPjOHhILAFugLgLcKpQePJ8SUzJ8/6U 4PSclDIey1M2VFrK/BkW2FL+o= X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="104324439" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKFLHhphQVUZ8V+XFFeyv1IK25gLUzIOQl7NlH8re9kF/JAyBmNHAvlEyCFlqVAb412bYB3wHH4zI236O/tIW8DaDLS4ydPMB9NKVIBcCMOrE6cCvPMFfnrumzgGulXAapaaKWXcw9+Ik0fxA/ZZIYfiK3fMk8mmWLIJIcXY0pz8xuzgh7+Ej8NTBRMyx1zAXG7BsdAS/4FI3gFt+xdNQr0bHNA3WNbAr4WlZQkwPhJGcxYeHuknKeYgVHfkGhNgOOr2WobruYZpVuR2gCCdx5OQ2s7qk9upWIZME7QvGGi3+3ClscQtBdjNAk+rg1JAaEN/VRa+A7c05NffOZ9GIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qdMLLuwbV3BYa1fUZZwxBbHCaaivCL4vH/hihHVFoZY=; b=TuOX77v8o4rO4+pD0FDjrVzTupFWLqyuLPqpwL7l5ZLhOVJtPa6xCRWZTLEGavE5DpmdrLZThqa+psQ5bzvT/olmHQ3PND5sVL4WUrkgCZHXu02wCPUTQ6LtS3nfjxtJW4lbpujOyLFL/SE+h77/vwvt5b/gpm5g20x6LkMSG890DhDcraD79NxsuDC+yN8d8Fh2Ut4YsYHJZWzve7gmbFmTLl7VbyLf9S4OL3BRzHu/uYOqDTOPFjy472OqOvkSsSAJULcV50/r9FFYFJtRJgzTJ5RcAG9Ugwr9tByPFO3HpmLqIYJvqvuWyqExzw201rH6vXX7edxw7tRFYf8p/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qdMLLuwbV3BYa1fUZZwxBbHCaaivCL4vH/hihHVFoZY=; b=uDduHxDWUZVzTQxn2nn0IkXd6y2/Wk+P0gXyJ5GVLGhQ5VisiJ45qj/kKXugv6uqukfxl4DYPs/ygc7G9lP8fm4KdMb52lnq3pbG6m31v/QMID8fC/r9KBeuGV7uA0H1ZjOKqMxQGFpACTSjLk2di9hJaLX2JqUlu/U5i6j9BKw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0c43546e-0333-af19-efa5-71cfaf5efa3f@citrix.com> Date: Tue, 4 Apr 2023 16:45:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v2 11/15] x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-12-andrew.cooper3@citrix.com> <087536dd-96cf-84f0-4b8f-d4de4d6bd093@suse.com> In-Reply-To: <087536dd-96cf-84f0-4b8f-d4de4d6bd093@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0337.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO3PR03MB6774:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a18d73f-ce1c-4eec-1248-08db352392c6 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AQxiMrV8mXXBToee8J/wqingWEbZSZifVA+xAPV3KUkI4Ji49S7QOMnO14HCYhhQQJFHZzg/lIXzUWsKIrFGaOYzfF3Iqr4SS0lYT5RZm8P7WiA2lHZwB4v5bwTE5Svm9FPcBYo6COxgqg+bDG1PjFVOLdZEbUXF68OI0kySFXp/HRR5403KOMIBxfhqBDcldRW9r72h9m7XGJ0k7TCVqb3KXHnxOW6Sq9HDV7KmxrAX+QPhDr9/6OR8aLxFYtz4ntJxRaV+SGJgoD6BBQx8EFo9eK1ortiyL/cEvimR0JkXqVUJNrw8BLgYbXLPLgbICHQ4vNqGy677kT68/Kqy7Hzc/eitkrSnzcE3XkB0Dqk3TpvVtFVtFwfpfOZCQ5iN8ScIGSS4aG24ecoIen1dAZdCpiPQeMsJrraliMyB9Sf0R8j3rHoOGy0+wJSOuSAv7YuvNsFBgoipMcJKOuHfSdEUcxHXcp/Wr21beZzGpz6u8vGHq82uwgSKLNvuf3O/CiBKfhm8uhOfSMWtTe+XH5qrisgXuKFzmhD1F6/d+f5wLwjS34LztYDPuGHS4ZpRqPjdkVNFjj5LykAXaC1uapUMdFrfRxw5vrXtU3KbhJ6qG7PM9z+mSWC31iLjHPRR9BVl/wSPnx5jB9QlvXADNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(451199021)(5660300002)(38100700002)(41300700001)(8676002)(8936002)(82960400001)(31696002)(86362001)(2906002)(6506007)(53546011)(6486002)(6666004)(26005)(83380400001)(36756003)(2616005)(6512007)(31686004)(186003)(316002)(4326008)(66556008)(66476007)(66946007)(6916009)(54906003)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVNEUGs4Mi9taGY0SE5NMS91MzZmQ0cxaFdTVXBiVUxBZkZMZWRQWXhPUnBi?= =?utf-8?B?YWg4OFVDbWtqQW5yV2l0WVNYaFNPdDAyQ3AyNkh6WUdGcHhjMTR0d25EZHYr?= =?utf-8?B?dExjLzV1elc4VGdsUDBTK1ZqTkpQN2dYcGZuUDA0WWRFQnp4NlVTbnk1L2p5?= =?utf-8?B?dWh6ZUVnSitRRG52Nzd0ZDZHbEg3cENjbTZjSGE5TlZJKzlZSDVqU3pqTVNX?= =?utf-8?B?dnRyNjRTNXpxRWl0L2JPV013S1J6Q2ZTMGFYRWo4SDk1R1M3NUFxQ3ZnL0tL?= =?utf-8?B?cmdKSTE2RG1acUFVeDRVcXZIQ01McmlobWcyVDVLcG5WMmxZaTNxeHh3YzVO?= =?utf-8?B?TEV2MHVSR1ZYN1dEaG1JQ3dhQzdsbWJmcmcyRWZjcnVzMmpTZTI0eFk4QVZj?= =?utf-8?B?cmEwTjh0UCtKUC91WFJJd0NZU1pEYkYwQTJiRXBIZDFweVJFVFVhWUh0QXov?= =?utf-8?B?SEQ2UWZSV2I0dkdNS0hDQ0JuYTdBdEZPNzFXRW5PQnl4MjlaaWtDSFd5d3JE?= =?utf-8?B?bkR6R08xcTNmK1BGaEpYZklIN3VaemNUd211SFRxelJWNmpKZHk2cytjYllt?= =?utf-8?B?eTlxdlYvcFprSTQreTJjbEMvbFlabmtaczZJZklqN0FaNkM4Wjd1SkpQWThp?= =?utf-8?B?RlhhT2pmeEtLUjJ3MVYzeSt0UHhsU1B6cjJsQWEydlZ6TmNqaEVHa0FuUW56?= =?utf-8?B?RDhiYXdwQjVyUzNBU0ptOWJ3SUtSUmVMdE03WlRRL1B2UUd6KzlCdzhKdks0?= =?utf-8?B?eHZJdnlKQmRaWUR0czE2TTRBdW1admJacmpzaXZScFQ0UE5OM1hScGVxcHJO?= =?utf-8?B?N0tKOUo3ZWR0K3B3bW41cGMzVkY4TUdOU2ZLU2JZSjRoZEVPL3ExR05GWWhn?= =?utf-8?B?SDhObTRjeGhHSnJWMC8wQ3Q5c0tNQ2N1TDJEbVNIVG1vUHBWNEl4Y0E2a0pK?= =?utf-8?B?K09GalFqc0IweGlGZ0s1SkdDVkZacDdOMlRtWE5Jd2ErOTB5ZWo4Y1RYMW9S?= =?utf-8?B?UmdXNlpyRnBTS3p4YS9IMllZYTFBNi8zQmRoVC9CbTRtTVJMREZIMkNZZHQ4?= =?utf-8?B?Wkw3QkhuajNYbzc2dFd2a2R2OXZKMXdZTzZyREE5cHNGbnUzekQ1VmZtRTNF?= =?utf-8?B?STFJRmlxYXJjanN5Mmh0SW9rdzNxSE9oazNVUHltZENGUmxoS2NndmlBeXFk?= =?utf-8?B?Q2doOXJTQnFrejVMdm83RlhKdWMxaWdDTHovWkFlRU1Yc3YrcU9vdXRvOUVU?= =?utf-8?B?RlhaYzdnZTVoVGlwOGFucEtnbllwNGlXdXZENjBpWFV3V1BKcDNhZ0NBMjlW?= =?utf-8?B?TzZXcFVzUjdsOW82ZGpJcmtybEtLTmtqcTNKZGJNdVNwb1RzeVhhSHFibVli?= =?utf-8?B?bk9jYjVSb0Q3OWRHM0MrUEszbVBUci9hakRONVFmM2lOK1dFa1VPdTNlVEJ2?= =?utf-8?B?dkJReW9WTjVzTkZzUGp5MU9EUi9QMXp4dnNDNEV2SFluSXQveEVXL3hMSFBt?= =?utf-8?B?QUFLYXNiVzhhdkJLSWZ6cWRwcGRadWVtbW04UDlnSnc0QTR2ZzJ1Y09yNkhv?= =?utf-8?B?d2M0eU0rdnBxMTlOcXNKbFdBSDU4WU5lUEJFNWlMYzhRWjdYdHhlM3NNYVF0?= =?utf-8?B?WWJ5OUF4OXFrRFFNVDRiSGV5Z0FqZ1RWdFkwQVpmSEFkZld5azlPRnFPTEhY?= =?utf-8?B?ZmluMkdUT1VnSUFIcC84d2ZoZ1RjWWVBaDhzRWJDQ2RTdjB4UUlLakZ6WFZJ?= =?utf-8?B?d2d6UHVIYS9hZWhGM0cvRTg1WFdsSUhkYUtteEt5VVAzckxhWGkxTm44RDQ1?= =?utf-8?B?MW1VU0diQzZQMEJaYXB5MHRrMVhyZjV0NTJrNnJVRHQwYjVHb3BWTVh4dnBL?= =?utf-8?B?b2FhY0xLaFplb2U0VFNJNXNBL1czRDhybG9kcW8xOWNJNWcxRUdZTVdJQjJL?= =?utf-8?B?dnhwSmVjRzZtUHhwbXQ5bDZyUlVMSzd5UlhsMG84YURtSnZzU3dnL0d6VFI2?= =?utf-8?B?U0FNUC9jUXN1TGJneXhuR1NDTjBUcklBaWQzVFVUOCs5T2ViVHY4V0hwbDVN?= =?utf-8?B?UXF5YllvcTBtdTUzZDMwOGJ2bWhiYkxvOXFQTVVhQS9neENoeVE4R1V6azMy?= =?utf-8?B?QWpqVkdnS3d0R0VWeWpXSVRzcnFtYjVyVVhpN05BWW9NVHJ1Zjk3YU1XRmQ5?= =?utf-8?B?Mnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fhUsFmlsE22EGcJl48bJICfNxPkwj3j5atnzjSc5Tb2wA3eT/EcIVYk/+Fq9HQGh5zUfQ/nE/hRSJFjgasSAH6uGPOKAJDKYndoqAW9uSgIru5wbLkT19D+ux07c0LEE7jY0n/M8cpbUeyFSwT7zXczHfU3WFccLxn2CH3mwnciqNy59nsrKvNbQbQ/EOLm7SII/F8oT9jzS+7RRZXuXDS0l86RKYWdQjgBUD5hao56vL2BrNZE3H3WS2rs9+yMThffb0oF7Zf3Lzq4xxEcoYaHmQZHD+JTbDI1/T3AC+l0RPHzAEEPbI0NL/C0kpqQdiaNdFk/xQh5hQuIXf1OMHd9lkZ77e8vfoM6nOz4fcR3i5IHr6xGY0UhDI3XW9rcVV0UZB30KFLJWTU4cEjTd2TbUMxRl2Nl4FqLnj/OIkqxNkr2Pdh5kmrXfrXokroEBeaTsDMbc6fZHUFzQrs6mTsYsagmojxc24oLNLVuxvTLsUdMv1X25w3veNkFlVthdOY4W80GZTgaWZ0nJKaJKUeGqf02UjNqgDqqI6JNYpRv/ym51HBV5+mvrshXglpNWpqEw6yI8QiApBcCPyDBeHoxly3hnElzvHKaAmTTy4MfMG1F2Iv/yRhuCnjQugQV+ywU2eAi0ueehz2f1X34rvEusKJtFn8x6zzbUMRYco7hq3yp60XPjExF/kp0ENvRaVg0oRRHQ9K/o6FynjYsNQJPDw9BayAXkx9CrgyiP2kIxHDSn+bNKaUXUusvWQeAXqNcUUXW62sfvIfQukrmjd+YucG0M5Z3RAXBQcupEpwLlhe73Xscvq0uZTJH7e/ot X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a18d73f-ce1c-4eec-1248-08db352392c6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:45:11.8222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cfL9l+vCdCLJ9Ry2Kl8XSbb9IBrHxm6zCWJLBcM/zkhhd9qsSHEzyulOamtziLzco1a5IEDuXH9544EB26A4G5/u7EKL1nQ7w/jm6QzDvdM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6774 On 04/04/2023 4:16 pm, Jan Beulich wrote: > On 04.04.2023 11:52, Andrew Cooper wrote: >> Switch to the newer cpu_policy nomenclature. Do some easy cleanup of >> includes. >> >> No practical change. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> >> v2: >> * New >> --- >> xen/arch/x86/cpu-policy.c | 752 ++++++++++++++++++++++++ >> xen/arch/x86/cpuid.c | 817 +------------------------- >> xen/arch/x86/hvm/hvm.c | 1 - >> xen/arch/x86/include/asm/cpu-policy.h | 6 + >> xen/arch/x86/include/asm/cpuid.h | 11 +- >> xen/arch/x86/pv/domain.c | 1 + >> xen/arch/x86/setup.c | 2 - >> 7 files changed, 764 insertions(+), 826 deletions(-) >> >> diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c >> index f6a2317ed7bd..83186e940ca7 100644 >> --- a/xen/arch/x86/cpu-policy.c >> +++ b/xen/arch/x86/cpu-policy.c >> @@ -1,13 +1,19 @@ >> /* SPDX-License-Identifier: GPL-2.0-or-later */ >> #include >> #include >> +#include >> #include >> >> #include >> >> +#include >> #include >> +#include >> +#include >> #include >> +#include >> #include >> +#include >> >> struct cpu_policy __ro_after_init raw_cpu_policy; >> struct cpu_policy __ro_after_init host_cpu_policy; >> @@ -20,10 +26,332 @@ struct cpu_policy __ro_after_init hvm_max_cpu_policy; >> struct cpu_policy __ro_after_init hvm_def_cpu_policy; >> #endif >> >> +const uint32_t known_features[] = INIT_KNOWN_FEATURES; >> + >> +static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; >> +static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; >> +static const uint32_t __initconst hvm_hap_max_featuremask[] = >> + INIT_HVM_HAP_MAX_FEATURES; >> +static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; >> +static const uint32_t __initconst hvm_shadow_def_featuremask[] = >> + INIT_HVM_SHADOW_DEF_FEATURES; >> +static const uint32_t __initconst hvm_hap_def_featuremask[] = >> + INIT_HVM_HAP_DEF_FEATURES; >> +static const uint32_t deep_features[] = INIT_DEEP_FEATURES; >> + >> +static const struct feature_name { >> + const char *name; >> + unsigned int bit; >> +} feature_names[] __initconstrel = INIT_FEATURE_NAMES; >> + >> +/* >> + * Parse a list of cpuid feature names -> bool, calling the callback for any >> + * matches found. >> + * >> + * always_inline, because this is init code only and we really don't want a >> + * function pointer call in the middle of the loop. >> + */ >> +static int __init always_inline parse_cpuid( >> + const char *s, void (*callback)(unsigned int feat, bool val)) >> +{ >> + const char *ss; >> + int val, rc = 0; >> + >> + do { >> + const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; >> + const char *feat; >> + >> + ss = strchr(s, ','); >> + if ( !ss ) >> + ss = strchr(s, '\0'); >> + >> + /* Skip the 'no-' prefix for name comparisons. */ >> + feat = s; >> + if ( strncmp(s, "no-", 3) == 0 ) >> + feat += 3; >> + >> + /* (Re)initalise lhs and rhs for binary search. */ >> + lhs = feature_names; >> + rhs = feature_names + ARRAY_SIZE(feature_names); >> + >> + while ( lhs < rhs ) >> + { >> + int res; >> + >> + mid = lhs + (rhs - lhs) / 2; >> + res = cmdline_strcmp(feat, mid->name); >> + >> + if ( res < 0 ) >> + { >> + rhs = mid; >> + continue; >> + } >> + if ( res > 0 ) >> + { >> + lhs = mid + 1; >> + continue; >> + } >> + >> + if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) >> + { >> + callback(mid->bit, val); >> + mid = NULL; >> + } >> + >> + break; >> + } >> + >> + /* >> + * Mid being NULL means that the name and boolean were successfully >> + * identified. Everything else is an error. >> + */ >> + if ( mid ) >> + rc = -EINVAL; >> + >> + s = ss + 1; >> + } while ( *ss ); >> + >> + return rc; >> +} >> + >> +static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) >> +{ >> + if ( !val ) >> + setup_clear_cpu_cap(feat); >> + else if ( feat == X86_FEATURE_RDRAND && >> + (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) >> + setup_force_cpu_cap(X86_FEATURE_RDRAND); >> +} >> + >> +static int __init cf_check parse_xen_cpuid(const char *s) >> +{ >> + return parse_cpuid(s, _parse_xen_cpuid); >> +} >> +custom_param("cpuid", parse_xen_cpuid); >> + >> +static bool __initdata dom0_cpuid_cmdline; >> +static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; >> +static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; >> + >> +static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) >> +{ >> + __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); >> + __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); >> +} >> + >> +static int __init cf_check parse_dom0_cpuid(const char *s) >> +{ >> + dom0_cpuid_cmdline = true; >> + >> + return parse_cpuid(s, _parse_dom0_cpuid); >> +} >> +custom_param("dom0-cpuid", parse_dom0_cpuid); > Unless the plan is to completely remove cpuid.c, this command line > handling would imo better fit there. I understand that to keep > dom0_{en,dis}able_feat[] static, the _parse_dom0_cpuid() helper > would then need to be exposed (under a different name), but I think > that's quite okay, the more that it's an __init function. I'm not sure I agree.  (I did debate this for a while before moving the cmdline parsing.) I do have some cleanup plans which will move code into cpuid.c, and guest_cpuid() absolutely still lives there, but for these options specifically, the moment I add MSR_ARCH_CAPS into a featureset, their bit names names will work here too. So arguably {dom0-}cpuid= don't be a great name moving forwards, but it is is absolutely more cpu-policy.c content than cpuid.c content. We can't get rid of the existing cmdline names, and I think documenting our way out of the "it's not only CPUID bits any more" is better than adding yet a new name. >> @@ -149,3 +716,188 @@ int init_domain_cpu_policy(struct domain *d) >> >> return 0; >> } >> + >> +void recalculate_cpuid_policy(struct domain *d) >> +{ >> + struct cpu_policy *p = d->arch.cpuid; >> + const struct cpu_policy *max = is_pv_domain(d) >> + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) >> + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); > While this is how the original code was, wouldn't this want to use > hvm_enabled, just like init_guest_cpu_policies() does (patch 10)? No.  That will fail to link. This trickery is necessary to drop the compiler-visible reference to hvm_max_cpu_policy in !CONFIG_HVM builds. This function is only called after the domain type has already been established, which precludes calling it in a case where max will evaluate to NULL, hence the ASSERT_UNREACHABLE() just below. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 15:57:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 15:57:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518009.804110 (Exim 4.92) (envelope-from ) id 1pjj2K-0001ji-6P; Tue, 04 Apr 2023 15:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518009.804110; Tue, 04 Apr 2023 15:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjj2K-0001jb-2V; Tue, 04 Apr 2023 15:57:32 +0000 Received: by outflank-mailman (input) for mailman id 518009; Tue, 04 Apr 2023 15:57:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjj2J-0001jT-1X for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 15:57:31 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64a97c0f-d301-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 17:57:27 +0200 (CEST) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 11:57:24 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB7101.namprd03.prod.outlook.com (2603:10b6:a03:4e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 15:57:17 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 15:57:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64a97c0f-d301-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680623847; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=x4cE0SxBtJATw7E3uGvEqgIgR/UsymTRX4mzi0JwnBU=; b=XDJTbOCIFHWHBt+cM2HasjH0u9fP1kg9DXdWVZQf/qkbifk/BhupmEY5 If3o4SxdpjKNEjNPw/XY0HKTR4qTh41W+amyk0foGw3BffO+aoW3JzcSx iGJWWwGWH/A4Qhs7HjLYg9OmHNcJZvYkaIokuBswPCXIVybVqOvz+FGzF 0=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 104210500 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:idS6EazMPcynro3SM796t+cRxyrEfRIJ4+MujC+fZmUNrF6WrkUPn DZKDGzUM/rbY2D0eo8gO4yx/UxV6pOByYc3TQpv+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRiPawT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXBi1 aE3Og4UVU+4q+Oqw52DTctyq9t2eaEHPKtH0p1h5RfwKK9/BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVlVMruFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37eTx3qjBdpKfFG+3t5WmHK8+zJUNB4TdEuxpcSBm2qSGN0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9KGYDYWoISFUD6ty6+YUr1EuQFJBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:tFKDTKnjg6jQzZcEk8XeY8GmgOXpDfIo3DAbv31ZSRFFG/Fw9v re+sjzsCWftN9/YgBGpTn+Asi9qB/nhPtICPAqUYtKPzOJhILLFu5fBOLZqlWMJ8SZzJ8/6U 4JScND4bbLfDpHZKjBkW2F+xpJ+rm6zJw= X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="104210500" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fNKvwg+I+Ci2icnQYj06xmeA3MCE+Z5AV2EBmLAznZTjI/arlVWxb2w9N1eecbtVGzSb3SLIVDr66+AQ9IttVl4bG8jnJ/F1O9DFCugC+QONhFB5pTX+aoSc+CUDWc7lQ+e7j/x6cUOws7I/Ce/kZMr7/4WemuP3z81oziMoRdYszwm1G9Ksn1kDlhEyJKId5Ofytdd8CFExPv+j769QuiG5kic+yDRVW9XP7gnc9GMjlNhkMiVZt8Kc8xNHC4cOrRJBAeHEFJ/D64o+S3qaHlPExxf9znsNNe2W8UQgdu35sxkQDTOMVNh/4GyTpts9EQmInuy0RpNy0ZnEhEucqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZhJ5xzIUm24PVzc6DAO6I1XdSsa+BdeUXFhz3Cs1W84=; b=og5/8MExSaAZFP9tFLo41KJwk7CyDfjERuOwBDg0JJ9h4HpNHaFqhtkjpbgnj1kQaIzzqDOVL8ck+Vpu1EHP6TGBjTgXuizK1W4EewgjiziVl8g36F6b3ViH5qiK4oMm5SjjcduRdupao6v05WzuUtrIdzd1lI9Lt7Bu5PxbF50qKSLPQzZX9z6P2/wNBADEghx5S817osPjORyyYSV8/uupaNa6bazzqvkJSnppTo7qe4Bqz9XNrUHzCrxKrVGYjJEoSsuJN8R37NUrJ/8wjaFFO6s4DjfnipIBVqSJgW9YYAgp5i7JPp99HaI/cMqZPqgO8DNX7iYilvwawyC0JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZhJ5xzIUm24PVzc6DAO6I1XdSsa+BdeUXFhz3Cs1W84=; b=BdDp7i9H65v8BSLcY3kknAuFISKAxdjdnFBLOOsri8M0I4aXqo49U/6VLeKA4LvyI6lStS1SfjnMJx9r0UvwQfGq6k6HcUqNr6LBLC9o9aLF9Sz+9fdqxluNCMTxEpoLnsDP0Zsh202WopN4IuA7oz7GpLNRWmmHFccU8XJ7/4M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 17:57:11 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Message-ID: References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0409.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB7101:EE_ X-MS-Office365-Filtering-Correlation-Id: ac7192a8-c1a5-49c6-3c33-08db352543bf X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V4rzIh/kFzauq0AWovF4N68I/MYyCjFsSBk12qtixJK/8Zlg5ulazUbLMYEFS0DS20Zvw9vFkFQFM7KK3tuF8FwfIYnhCwrrgTL1bOcunzTNRNIIGHhUoZkui7Am3+NcWH7DQ+70rA/HD8Au3wBC0ukb1bbb/kSd5H7IY4tlafQ7EO1lICrrBnvWYsv2OeDe86Z7rVS8yGZRV//9J5Ojdi/k5sbitI2J1Y521hrnFEKWGurZBJZD3gkXM0gnhlnSJ3iN3Ydap+sIh3MonBkgtpaiKrTdmgZdW65wx49LIAMbsTyFfb4XLeXPDEBGxrYRSNzaIr01+2qEFoVKNyUeTKeJ3bpcdrhl1LF6YGfaXGbXtSPjfCfGUAnm0Tat+XKqa9FJqdDJ2nJXmYcHGXYKkbrzbAn29g/9hSdisn30RZe/0F/fK4Hxl01Z1PTe9obKisn6cqmb0yecGBZ8kUaCvBG+J3V/Jt3gFStFY1ubADPVBBKdW5YwNpTgho+eMDin29VbqVayOJZQsMSCvKEcptDAG03cPWb3xLJXxJJv4Jcw+xtojvC558mwM5a13hBO0Utqlm+AMJWoUX4y5ggcIbd1pwwav+PMDwSBai0msNo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199021)(2906002)(82960400001)(38100700002)(86362001)(66899021)(33716001)(6666004)(6512007)(66476007)(66946007)(66556008)(8676002)(4326008)(53546011)(9686003)(41300700001)(6506007)(26005)(316002)(6916009)(54906003)(478600001)(85182001)(6486002)(83380400001)(5660300002)(8936002)(186003)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHRTNnBEMUcvTWQ3bEVRMXRrTVJBMjIwV1dIbnVBYTRNZkFSOGFBSkZqNkhE?= =?utf-8?B?ZzRBZVUrVXpPYWhmUkcyK0VCWTlsa1FSemVxbTFrUlRGbjBCOTNwRW9xeVJo?= =?utf-8?B?TFF4TlNORHp2ZVRkMzM0WDF4d0tHdkUwU2VxWjkvSU95QzA5WlQwem04UFky?= =?utf-8?B?d1crOHYwVVg5VlhvaVRzcURkYVhrb0w2YWd0eVhLa2Q0RGM5Zms3NzBWazQ2?= =?utf-8?B?SEc4TjJxN0JLT1UvcGZJS3hWbTVjTDFpN0Jra01IdXNsRWR1NVlDRDJSYWZt?= =?utf-8?B?WjNqTkNVYk1BYStDN0xlYS9taXZuZDhCaGZSZ3ZKMGJGbzh6MFhIVVh5UEpH?= =?utf-8?B?TmIzckN6dmI3SnVGOGQ5VkkxNHkyOEp2S21SK3AwK0x1b3VVNGFJNFdVRXBz?= =?utf-8?B?VXcreVNnK053K2pGc1FFNVpocUhMVkpRZG5zNEh4L1JYb3FPaFhLTlY0TWlC?= =?utf-8?B?ZkZhSmZCa0RnbVFxb2FtcG9JQVBYcExPWEU0TWpMMlZjVHQrcGlPVXU3S1BC?= =?utf-8?B?dHFzZHdkbkhBQWR2enBQSDk4U2lGa1QyVklXZ2VSWmlUVDNyL3gvOGNTcFJ5?= =?utf-8?B?TFR2Vk4zR1ZoUEZHODh4d255WjFwcnRJM1liOW51KzhtUWtna1hhVEd6R1Zu?= =?utf-8?B?TXVlZjlHR2RobjlFQUFWQzBuUTAvU2pFUXAwN2N6MWcyM3FPZC96cHRQWm9j?= =?utf-8?B?ODdPQnpuc3loSmtSWVk2eGpnUXBOcE5mRlBVejFFdldVTVl3ejIyTUxIRTBv?= =?utf-8?B?MDJEdjB5Qk8xaWxiZE9KejVBRldaSWRGRjdMZ0gwdEFsR0JNOUprR2UzYi90?= =?utf-8?B?cDBYQ3haQldjUjRRL1Z0MFVEc0s3V2U2MWlXZDViN0R1SDZRQkFTWGlmNk5h?= =?utf-8?B?dndtRUpPc3gxQjVuMkY3Yjh0OEI1YklhWmFOZXhNQjZnb2lOVnFXOVVyWGtj?= =?utf-8?B?bzRHU0diSENsdlV3TlRHbVd3dDNSSWkycGpvS2ZzemQ3V0U5QlB3THFyTmlP?= =?utf-8?B?TWZyV3h0ajhSUlZiWW9CaUdEc0htYnlxcHRoMEgxVDIzWW45K2YrL1RxZFd2?= =?utf-8?B?Y1crQ1hRcEU3QllOcWJoYWlybVA0TTdkaTRDYXRNaDd4Q0FNb21SQ1IwN2Yw?= =?utf-8?B?d3gxQlBld3IrbFpKMWtRS204ajhXa1BUNkVjMVdJRThCSlpIa0VLcjVYMEdF?= =?utf-8?B?V0laL2ZONzdXMm9iSmUvVlZwcGdxQkpSMDVpWnArUU1qdmJobzRSS3VIY2Jn?= =?utf-8?B?U3YvTUZTUDRVMllWcURuZHB2eXZCaFptR000eUd0WDc0NW5vQnR3NmdaUU0x?= =?utf-8?B?ZUlETXN1VHFBaE80VnMxZmJMRHpoRUtDUVlYbVQzK2xLSzN1b0kyaFRSUjJj?= =?utf-8?B?WmhoVlF1Y3Q5Ulh6ZXFhTi94Wi9wU1hwQ1BOU1JaUlgyMDJrbDlRYis1M3ZB?= =?utf-8?B?cUtCdEI4OC8xWHRvNmJqL04rQnVBd1RtRmsxc0tOZUtmbXFnY1NpRFB4dFJD?= =?utf-8?B?R0NmZzREUXJ0NW1SYklSUFg3ajU5OWpXb0o1L20wUW94TzlIbUFtNjI2SmdE?= =?utf-8?B?bkg1K2M5VUFCWmU5cUNza2tBTFg2UURaVFpDVmF4djh4ZjJmTU1odEJ5OStS?= =?utf-8?B?bDhRRUVlc0MvNVhnbVZDWGJRdFFsNy9zbDIzQjBpUFVZdTZJcFI1YVBlaGwz?= =?utf-8?B?d0dOdjd5UkJLV3R1ZXJ6eFlKbEJHTXBRQ295elNBZzJqa3MrYWJ6TnZGMUFR?= =?utf-8?B?UDFqMEtUb2VOMDNMRi8wQk1vaWxCRHN0ZUhjRkdOV3lwcmRIWW9Eb3NIVjd2?= =?utf-8?B?OWo3VXN3cm1FNCtEQXFubHZzM2QvL295bXhyd2R6NWpLWVVqUHBwYVV4bnJV?= =?utf-8?B?MlhGOGU3eG9leUhtcUhtYjVQQ0d6d0RLM0twWGVKbk1ackNMMTBJaTNOREFL?= =?utf-8?B?MWFxcFEyZHlGNktJZTJIalplVmRFU0pMZVdpVTFkcDFka25ZTzAwUHZ0SlVK?= =?utf-8?B?MGp3MEpxSFh2clVvaTJHbHVCZWVocUM3c0ZQakIyZVNnYzVseGtjT01WOFhv?= =?utf-8?B?ek5mN0dKa1BKQ2xRTk5NQVJwdHJ3N3NaOTBQWDRHL3IvZEw0dkVCdENBYjZv?= =?utf-8?Q?yn8dKp5HVKQ4se3D9lGEDc+48?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: JLf8pMbefW55+2gdRTJqVSLIMVy6xOlc6xGMqrEBSW0mAsV3RVb38VrQokofDAcVlmq5Z6pescGHitHcfhjCDt4Ax8QkoFI6x6pyHIdK6V7ySIBdumbmat0yC2Nya9lRYTR/0MMCneK7rQ/roMHZ+BbdQX381Scpoqe0VTP936BHDUkwgRnsKZu+eRj9E2dXJjVbUPC2ekAO7eOvBrSsXPsPqR15T2YDV3ZuzbnPP5XCJO5rnyPcLo1ml7ECRKh3ixwfvCXJFlUsxHRIrD8lG8CbnhPD4lVcp0GbqZzFTcpJE86jDEhf1V/vwkgS6wQUAJ+VIW/D14+g4Oc22rLrd0KymnjFa5SCteRbw/XCJdIOZU+UebMS8G/Wa2CZnLu/wC3R4BS/MKz2sdluNLg5F93syhdlcOcimpeQ7n241RTz03LC7I5+dojxaL1H9KaHyAckRDYywVgC+dl7x/6mnlJzX9QQg9aCUQD5wA96oTBGg4mf+SMAbu70N8hV1nhnq+4zko/i1kjnljO76pgAEDvNy/p+79VFVcEMFG+EbT7VzFb9xnI6yW4qTOiGRkcsQaGjDHl7xeKjOlzQRAE5/FzJNs/GN9mONDh2uc+voGL2bOiPdHNzejmFp2ec/5MwPKM5oOH4/lwvH/5ZMAdLr6uZJOyo4tLCkhlt1kWrbAHeReWxwsI+63jho2O8qnt1NK4Na5z4wOmCoffegg7Je3RuqcEsMh1krovCtz2CBEV+BoehlO1U5tFaw4Gp8UHbxKkpglPrZWGuhWZBSsoxYwkUfJTzQbD3gWr6OGSq/6NZmMv8RZ80ZWB6fIGleA+e X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac7192a8-c1a5-49c6-3c33-08db352543bf X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 15:57:17.2939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EsjZht/Ytd4OyysFc8M1iLLlbFfkkf2v7qfuc+Hp4XMRsUgQGxXnF4LUqcvsW5J4V82c99jw3DCcq+1MGtisIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB7101 On Tue, Apr 04, 2023 at 04:24:16PM +0200, Jan Beulich wrote: > On 04.04.2023 13:41, Roger Pau Monné wrote: > > On Tue, Apr 04, 2023 at 12:31:31PM +0200, Jan Beulich wrote: > >> On 04.04.2023 12:12, Roger Pau Monné wrote: > >>> On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: > >>>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still > >>>> applies to guests also when run on a 64-bit hypervisor: The "extended > >>>> CR3" format has to be used there as well, to fit the address in the only > >>>> 32-bit wide register there. As a result it was a mistake that the check > >>>> was never enabled for that case, and was then mistakenly deleted in the > >>>> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume > >>>> CONFIG_PAGING_LEVELS==4"]). > >>>> > >>>> Similarly during Dom0 construction kernel awareness needs to be taken > >>>> into account, and respective code was again mistakenly never enabled for > >>>> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by > >>>> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). > >>>> > >>>> At the same time restrict enabling of the assist for Dom0 to just the > >>>> 32-bit case. Furthermore there's no need for an atomic update there. > >>>> > >>>> Signed-off-by: Jan Beulich > >>>> --- > >>>> I was uncertain whether to add a check to the CR3 guest read path, > >>>> raising e.g. #GP(0) when the value read wouldn't fit but also may not > >>>> be converted to "extended" format (overflow is possible there in > >>>> principle because of the control tools "slack" in promote_l3_table()). > >>>> > >>>> In that context I was puzzled to find no check on the CR3 guest write > >>>> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any > >>>> of the low reserved ones) could observe anomalous behavior rather than > >>>> plain failure. > >>>> > >>>> As to a Fixes: tag - it's pretty unclear which of the many original > >>>> 32-on-64 changes to blame. I don't think the two cited commits should > >>>> be referenced there, as they didn't break anything that wasn't already > >>>> broken. > >>>> > >>>> --- a/xen/arch/x86/mm.c > >>>> +++ b/xen/arch/x86/mm.c > >>>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ > >>>> unsigned int partial_flags = page->partial_flags; > >>>> l3_pgentry_t l3e = l3e_empty(); > >>>> > >>>> + /* > >>>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not > >>>> + * understand the weird 'extended cr3' format for dealing with high-order > >>>> + * address bits. We cut some slack for control tools (before vcpu0 is > >>>> + * initialised). > >>> > >>> Don't we then need some check in the vCPU init path to assure that the > >>> cr3 is < 32bits if we allow those to initially be set? > >>> > >>> Or will the initialization unconditionally overwrite any previous cr3 > >>> value? > >> > >> That's not the way I understand this "cut some slack". Instead I read it > >> to be meant to cover for the VM-assist bit not being set, yet. Beyond > >> that it is assumed to be tool stack's responsibility to constrain > >> addresses suitably. If it doesn't, it'll simply break the guest. (There > >> is some guessing on my part involved here, as the original introduction > >> of that code didn't further explain things.) > > > > If it's just the guest that's broken I would think it's fine. As long > > as such mismatch doesn't cause issues in the hypervisor internal state. > > > > Did you see a toolstack setting such entries before pae_extended_cr3 > > is set? > > To be honest - I didn't look. As said in the longer reply to Andrew, I > think it is more logical this way (the page table root already being > validated as an L3 table when vCPU 0 is inititalized, which includes > setting its CR3). Hence even if right now the order was the other way > around (which I doubt it is), I wouldn't want to make impossible to > restore the original ordering again. IMO I think it would be better if we could already report error at domain creation time if the toolstack is attempting to create a domain that the hypervisor knows is not going to work properly, rather than allowing it and the guest failing in maybe non obvious ways. It seems to me however that we would need to fix xc_dom_boot_image() in order to setup the vCPU before creating the initial page-tables. (->setup_pgtables() hook being called before ->vcpu() hook) So I don't think this is strictly worse than what we have, but it would also be nice to get things sorted out so the ability of the toolstack to shot its own foot is limited. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:07:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:07:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518014.804119 (Exim 4.92) (envelope-from ) id 1pjjBg-0003lo-1l; Tue, 04 Apr 2023 16:07:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518014.804119; Tue, 04 Apr 2023 16:07:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjBf-0003lh-VF; Tue, 04 Apr 2023 16:07:11 +0000 Received: by outflank-mailman (input) for mailman id 518014; Tue, 04 Apr 2023 16:07:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjBe-0003lX-1C; Tue, 04 Apr 2023 16:07:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjBd-00086J-Uw; Tue, 04 Apr 2023 16:07:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjBd-0002Tf-Et; Tue, 04 Apr 2023 16:07:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjjBd-0003So-EA; Tue, 04 Apr 2023 16:07:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6n06JrAZS3LVFrbsQfYq6ZCfdJtlwUHjqhGaejujYdo=; b=zyYMPm84PUmkpyg4CrTmmo+BPa 5rEVBxpaUJzDwtO1l8iEOVuqWIfGwldcyeyaO1dLfswZgt3Xegek1ILuA25u1BMEHteONNX32r8/U ph8Ztnsdz3kTmDLfHAblaZ/823Dux9FmfAi8v7jyXZlwTL0HF3PLJtJgy48JvfS47t1U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180137: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e X-Osstest-Versions-That: xen=bfa2e6a246225233f09a2523939e01dcf83bca4c From: osstest service owner Date: Tue, 04 Apr 2023 16:07:09 +0000 flight 180137 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180137/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e baseline version: xen bfa2e6a246225233f09a2523939e01dcf83bca4c Last test of basis 180119 2023-04-03 13:00:25 Z 1 days Testing same since 180137 2023-04-04 14:03:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bfa2e6a246..658fcb7ac9 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e -> smoke From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:07:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:07:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518017.804130 (Exim 4.92) (envelope-from ) id 1pjjBn-00042m-9r; Tue, 04 Apr 2023 16:07:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518017.804130; Tue, 04 Apr 2023 16:07:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjBn-00042f-6Y; Tue, 04 Apr 2023 16:07:19 +0000 Received: by outflank-mailman (input) for mailman id 518017; Tue, 04 Apr 2023 16:07:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjBm-00042B-23 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:07:18 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3963683-d302-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:07:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3963683-d302-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680624435; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=QsmKjz9FSvqTsAQ5kNWHSGgpoV1tw0uvDbd0t6jEgvo=; b=NauPj0zhH9qqNc6uPFGBX8VXr0Up6GZZd0gvygJjwLe7C7Koahpvl82A 0MpOcsKx1psg4lBqMqXAlqfnIiBHHHgsZTkqjp0iffgB1d2qv1x6/gHy6 GSAVjeFsxOw+iaWQY/ITmdWbaCOZWZ9XB5qtHI3G4ndR1UTWIelxf/4ou 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104328623 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:dUgNEal0GTwHMn6zhFqF1jTo5gy2JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIeUG6DOa6IZjD9e91zboXjox8AuZPUyYdrGQRu/C08HiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgX5AOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f1HNzVWV0uqvvm3/a+KbdFql8MAcPC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHkfidXpUPTqbs++GzS5AdwzKLsIJzefdniqcB9xx7E/ TiWoT6iav0cHNWa1CLZz2qJv+PWgRjXZI43RJLj0cc/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1Zpd9gOpMIwAzsw2 TehndzzAid0mKaIUn/b/bCRxRuwJCwUIGkqdSICCwwf7LHLu5ovhxjCStJiFq+djdDvHzz0h TeQo0ADa6471JBRkf/hpBae3mzq/8KSJuIo2unJdmP68QYiXdWMXpep1EXqys5GPYG6EmDU6 RDohPOiAPAy4YClzXLdGLtVQOr4u55pIxWH3wcxQsBJGyCFvif6INsOuGwWyFJBaJ5sRNP/X KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmOyvpnsGiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymHBmmD+NFMqglUr3uVZ7WJJyYe5dWGZik8hjtP/UyOkr2 4032zS2J+V3D7SlP3i/HX87JlEWN3krba3LRzhsXrfbeGJOQThxY8I9NJt9I+SJaYwJzLaXl px8M2cEoGfCaYrvcl/VMCo7NOu+Bf6SbxsTZEQRALph4FB7Ca7H0UvVX8JfkWUPnAC78cNJc g== IronPort-HdrOrdr: A9a23:A8CGqKNzLcl7FsBcTuqjsMiBIKoaSvp037BL7TEVdfUxSKb0qy nAppgmPHPP5wr5IUtQ4OxoW5PwI080l6QU3WB5B97LYOCBggWVxepZnOjfKlPbehEWwdQtsZ uII5IUNDQpNykAsS8h2njfLz/8+qjhzEl1v5an856yd3ARV51d X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="104328623" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v4 2/3] x86/platform: introduce XENPF_get_ucode_revision Date: Tue, 4 Apr 2023 17:06:54 +0100 Message-ID: <20230404160655.2354-3-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230404160655.2354-1-sergey.dyasli@citrix.com> References: <20230404160655.2354-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Currently it's impossible to get CPU's microcode revision from Xen after late loading without looking into Xen logs which is not always convenient. Add a new platform op in order to get the required data from Xen and provide a wrapper for libxenctrl. Signed-off-by: Sergey Dyasli --- v3 --> v4: - clarified the commit message - Renamed "ucode version" to "ucode revision" - Removed DECLARE_PLATFORM_OP and NULL checks - Added a TODO comment about parked CPUs - Renamed struct xenpf_ucode_revision fields --- tools/include/xenctrl.h | 2 ++ tools/libs/ctrl/xc_misc.c | 18 +++++++++++++++ xen/arch/x86/platform_hypercall.c | 29 ++++++++++++++++++++++++ xen/arch/x86/x86_64/platform_hypercall.c | 4 ++++ xen/include/public/platform.h | 11 +++++++++ xen/include/xlat.lst | 1 + 6 files changed, 65 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 34b3b25289..1149f805ba 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1187,6 +1187,8 @@ int xc_cputopoinfo(xc_interface *xch, unsigned *max_cpus, xc_cputopo_t *cputopo); int xc_microcode_update(xc_interface *xch, const void *buf, size_t len); int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver); +int xc_get_ucode_revision(xc_interface *xch, + struct xenpf_ucode_revision *ucode_rev); int xc_numainfo(xc_interface *xch, unsigned *max_nodes, xc_meminfo_t *meminfo, uint32_t *distance); int xc_pcitopoinfo(xc_interface *xch, unsigned num_devs, diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 90d50faa4f..4159294b2e 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -243,6 +243,24 @@ int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver) return 0; } +int xc_get_ucode_revision(xc_interface *xch, + struct xenpf_ucode_revision *ucode_rev) +{ + int ret; + struct xen_platform_op op = { + .cmd = XENPF_get_ucode_revision, + .u.ucode_revision.cpu = ucode_rev->cpu, + }; + + ret = do_platform_op(xch, &op); + if ( ret != 0 ) + return ret; + + *ucode_rev = op.u.ucode_revision; + + return 0; +} + int xc_cputopoinfo(xc_interface *xch, unsigned *max_cpus, xc_cputopo_t *cputopo) { diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c index a2d9526355..9ff2da8fc3 100644 --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -640,6 +640,35 @@ ret_t do_platform_op( } break; + case XENPF_get_ucode_revision: + { + struct xenpf_ucode_revision *rev = &op->u.ucode_revision; + + if ( !get_cpu_maps() ) + { + ret = -EBUSY; + break; + } + + /* TODO: make it possible to know ucode revisions for parked CPUs */ + if ( (rev->cpu >= nr_cpu_ids) || !cpu_online(rev->cpu) ) + ret = -ENOENT; + else + { + const struct cpu_signature *sig = &per_cpu(cpu_sig, rev->cpu); + + rev->signature = sig->sig; + rev->pf = sig->pf; + rev->revision = sig->rev; + } + + put_cpu_maps(); + + if ( __copy_field_to_guest(u_xenpf_op, op, u.ucode_revision) ) + ret = -EFAULT; + } + break; + case XENPF_cpu_online: { int cpu = op->u.cpu_ol.cpuid; diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c index 5bf6b958d2..99440f4076 100644 --- a/xen/arch/x86/x86_64/platform_hypercall.c +++ b/xen/arch/x86/x86_64/platform_hypercall.c @@ -28,6 +28,10 @@ CHECK_pf_pcpuinfo; CHECK_pf_pcpu_version; #undef xen_pf_pcpu_version +#define xen_pf_ucode_revision xenpf_ucode_revision +CHECK_pf_ucode_revision; +#undef xen_pf_pucode_revision + #define xen_pf_enter_acpi_sleep xenpf_enter_acpi_sleep CHECK_pf_enter_acpi_sleep; #undef xen_pf_enter_acpi_sleep diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h index 60caa5ce7e..15777b5416 100644 --- a/xen/include/public/platform.h +++ b/xen/include/public/platform.h @@ -614,6 +614,16 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_symdata_t); typedef struct dom0_vga_console_info xenpf_dom0_console_t; DEFINE_XEN_GUEST_HANDLE(xenpf_dom0_console_t); +#define XENPF_get_ucode_revision 65 +struct xenpf_ucode_revision { + uint32_t cpu; /* IN: CPU number to get the revision from. */ + uint32_t signature; /* OUT: CPU signature (CPUID.1.EAX). */ + uint32_t pf; /* OUT: Platform Flags (Intel only) */ + uint32_t revision; /* OUT: Microcode Revision. */ +}; +typedef struct xenpf_ucode_revision xenpf_ucode_revision_t; +DEFINE_XEN_GUEST_HANDLE(xenpf_ucode_revision_t); + /* * ` enum neg_errnoval * ` HYPERVISOR_platform_op(const struct xen_platform_op*); @@ -645,6 +655,7 @@ struct xen_platform_op { xenpf_resource_op_t resource_op; xenpf_symdata_t symdata; xenpf_dom0_console_t dom0_console; + xenpf_ucode_revision_t ucode_revision; uint8_t pad[128]; } u; }; diff --git a/xen/include/xlat.lst b/xen/include/xlat.lst index d601a8a984..9c41948514 100644 --- a/xen/include/xlat.lst +++ b/xen/include/xlat.lst @@ -157,6 +157,7 @@ ? xenpf_pcpuinfo platform.h ? xenpf_pcpu_version platform.h ? xenpf_resource_entry platform.h +? xenpf_ucode_revision platform.h ? pmu_data pmu.h ? pmu_params pmu.h ! sched_poll sched.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:07:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:07:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518019.804139 (Exim 4.92) (envelope-from ) id 1pjjC2-0004Qd-NP; Tue, 04 Apr 2023 16:07:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518019.804139; Tue, 04 Apr 2023 16:07:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjC2-0004QW-Kb; Tue, 04 Apr 2023 16:07:34 +0000 Received: by outflank-mailman (input) for mailman id 518019; Tue, 04 Apr 2023 16:07:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjC1-0004Q2-Mv for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:07:33 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cca51aa8-d302-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 18:07:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cca51aa8-d302-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680624451; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=OIB4XE7cSQQtZzws9p9Ga2irS8OnpzPLnMZtppaosBg=; b=GsB7Yy1Jo4Ow6+EFtZiwVjKi0AULlLC1H/ys9LaFkAvARqHohNo0SPOP tToe0+ra4bSeoli/yY5QUf1cAN/w4sMwzy0jegLkfLOG1jVaOxSAbkyvc UsFMfByJHhSwbITbCUCsp3ESrwL0EtYQcRiYOXTihIoHUyHypkIZwab1N k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106724130 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:yu8CZ6pwY/cYEdn6ykTvBwmglPVeBmIuZRIvgKrLsJaIsI4StFCzt garIBmGPKuDYzCgctEjO4u0pkIEsZXQzIRiGQc9rylgQSJE8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGtSLQDTreG3+ZSQEeJz3fYlc8boI5xK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVDpUiaqLtx73na1whw+LPsLMDUapqBQsA9ckOw/ zqYoD6lW0pCXDCZ4SSP9i20qPGVpgzmSr4rNrK47rl4iWTGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOq8seVTEsk FiTkLvBBzN1t6aOYWmA7brSpjS3UQAXMGsDaCksXQYDpd75r+kblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN0uYdUjjvvhuwqd2nT1+8aPF1RujunKYo67xlgmJ571TY+p0H7wtv1fd7SfEVaCo 2dRzqBy89sy4YGxeD2lGbtdRO/xu63UbFUwknY0QcB/qm3FF2qLONkJvWogfBoB3tMsI2eBX aPFhe9GCHa/1lOOZLQ/XY++At9CIUPIRYW8DaC8gjajj/FMmO67EMJGPxT4M5jFyhRErE3GE c7znTyQJXgbE7976zG9Wv0Q17QmrghnmzOLGMylnk78i+TODJJwdVviGALWBt3VEYve+FmFm zqhH5DiJ+pjvB3WPXCMrN97waEiJnknH5Hmw/Fqmhq4ClM+QgkJUqaBqY7NjqQ5x8y5YM+Up CDiMqKZoXKj7UD6xfKiMSo8Mum3Ac4u9RrW/0UEZD6V5pTqWq73hI93Snf9VeJ4nAC/5ZaYl 8U4Rvg= IronPort-HdrOrdr: A9a23:g3P7gK99tCdBf+9fU7Juk+DzI+orL9Y04lQ7vn2ZKCYlF/Bw8v rF8cjzuiWZtN98Yh4dcKm7SdC9qBDnhPxICOsqXYtKNTOO0FdASrsN0WKI+UyCJ8SRzI9gPJ BbAsxD4Y3LZmSSVfyKmzVQyexQpuVvLZrY4ts2E00dNT2CtZsQlTtENg== X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="106724130" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v4 1/3] tools/xenctrl: add xc_get_cpu_version() Date: Tue, 4 Apr 2023 17:06:53 +0100 Message-ID: <20230404160655.2354-2-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230404160655.2354-1-sergey.dyasli@citrix.com> References: <20230404160655.2354-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Type: text/plain As a wrapper for XENPF_get_cpu_version platform op. Signed-off-by: Sergey Dyasli --- v3 --> v4: - Replaced DECLARE_PLATFORM_OP - Removed NULL checks --- tools/include/xenctrl.h | 1 + tools/libs/ctrl/xc_misc.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 05967ecc92..34b3b25289 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1186,6 +1186,7 @@ int xc_physinfo(xc_interface *xch, xc_physinfo_t *info); int xc_cputopoinfo(xc_interface *xch, unsigned *max_cpus, xc_cputopo_t *cputopo); int xc_microcode_update(xc_interface *xch, const void *buf, size_t len); +int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver); int xc_numainfo(xc_interface *xch, unsigned *max_nodes, xc_meminfo_t *meminfo, uint32_t *distance); int xc_pcitopoinfo(xc_interface *xch, unsigned num_devs, diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 265f15ec2d..90d50faa4f 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -226,6 +226,23 @@ int xc_microcode_update(xc_interface *xch, const void *buf, size_t len) return ret; } +int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver) +{ + int ret; + struct xen_platform_op op = { + .cmd = XENPF_get_cpu_version, + .u.pcpu_version.xen_cpuid = cpu_ver->xen_cpuid, + }; + + ret = do_platform_op(xch, &op); + if ( ret != 0 ) + return ret; + + *cpu_ver = op.u.pcpu_version; + + return 0; +} + int xc_cputopoinfo(xc_interface *xch, unsigned *max_cpus, xc_cputopo_t *cputopo) { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:07:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518021.804150 (Exim 4.92) (envelope-from ) id 1pjjC3-0004gP-W5; Tue, 04 Apr 2023 16:07:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518021.804150; Tue, 04 Apr 2023 16:07:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjC3-0004gG-Rr; Tue, 04 Apr 2023 16:07:35 +0000 Received: by outflank-mailman (input) for mailman id 518021; Tue, 04 Apr 2023 16:07:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjC2-0004Q2-Bv for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:07:34 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd171558-d302-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 18:07:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd171558-d302-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680624451; h=from:to:cc:subject:date:message-id:mime-version; bh=P7/Mv4d7vPTIrhuPMkAr+Y3CR940VFPqx5xikklOBgo=; b=SJhGaJIFGPD3cRIsvDx8/7mUAWZD//QDkCd8k4QLCMD0V2knzwoR4rDw NC0lHra9VELCiSi6M2WQx6ynorjcsO4b8DjazyaBinajuFfkACl+SVLbq 8H9U+eGy6S6ptF6+yBVzTw8QMXLELr3Hp4BlAfF1ngYSGG+tC8EziQDQ/ g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106724129 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:WrH9SK1LPnlbyBXylPbD5eVxkn2cJEfYwER7XKvMYLTBsI5bp2BSz 2JLXWqGPayLZjHye9sib9m+/R8BupWDx4AxSQY4pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWj4N5 awyKzE0SDvYjP3t8rTkRepzmZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tPylnHbyYntUuVuOoasf6GnP1g1hlrPqNbI5f/TTHZsKxBrB/ DOuE2LRJDwXFICz4jm59neB38WSn3vfVKBOLejtnhJtqALKnTFCYPEMbnOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQo2 UWOhMjBHiF0vfueTnf13rWJqTK/PwAFIGlEYjULJSMe+MXqqow3ihPJT/5gHbSzg9mzHiv/q w1mtwBn2e9V15RSkfzmoxae2WnESoX1ohAdvVqUTjKP7QJAQqX+bJPz216E4vVfM9PMJrWeh 0Toi/Ry/chXU8HVynTRG7RRdF26z63baWOB2DaDC7Fkrm3woCD7IOi89RkkfC9U3tA4lSgFi aM5kSdY/9dtMXSjdsebiKrhWp1xncAM+TkIP804j+aigbArLmdrBAk0OSatM5nFySDAa50XN 5aBatqLBn0HE6lhxzfeb75Dged2mn5vnziJG8CTI/GbPV22PSb9dFv4GAHWMrBRAF2s+205D Oqzx+PVkk4CAYUSkwHc8JIJLEBiEEXX8ave8pQNHsbae1oOJY3UI6OJqV/XU9A/zvs9eyah1 i3VZ3K0P3Kk3yKdc13WMiE7AF4tNL4mxU8G0eUXFQ7A8xAejUyHt/p3m0cfFVX/yNFe8A== IronPort-HdrOrdr: A9a23:D1ZmRaqMfUdI1X5YDbvdIUEaV5oAeYIsimQD101hICG9E/bo8v xG+c5wuCMc5wx8ZJhNo7+90dC7MArhHP1OkOss1NWZPDUO0VHARL2Ki7GN/9SKIVycygcy78 Zdmp9FebnN5AhB5voSODPIaOrIGuP3lpxAWN2uqEuFkTsaE52IMT0JcDqmLg== X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="106724129" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v4 0/3] xen-ucode: print information about currently loaded ucode Date: Tue, 4 Apr 2023 17:06:52 +0100 Message-ID: <20230404160655.2354-1-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain Posting v4 with addressed review comments. Changes from v3 are available in each patch. Sergey Dyasli (3): tools/xenctrl: add xc_get_cpu_version() x86/platform: introduce XENPF_get_ucode_revision tools/xen-ucode: print information about currently loaded ucode tools/include/xenctrl.h | 3 + tools/libs/ctrl/xc_misc.c | 35 ++++++++++ tools/misc/xen-ucode.c | 83 ++++++++++++++++++++---- xen/arch/x86/platform_hypercall.c | 29 +++++++++ xen/arch/x86/x86_64/platform_hypercall.c | 4 ++ xen/include/public/platform.h | 11 ++++ xen/include/xlat.lst | 1 + 7 files changed, 154 insertions(+), 12 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:07:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518022.804160 (Exim 4.92) (envelope-from ) id 1pjjC5-0004wm-8R; Tue, 04 Apr 2023 16:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518022.804160; Tue, 04 Apr 2023 16:07:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjC5-0004wX-5O; Tue, 04 Apr 2023 16:07:37 +0000 Received: by outflank-mailman (input) for mailman id 518022; Tue, 04 Apr 2023 16:07:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjC3-0004Q2-C0 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:07:35 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cedfab95-d302-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 18:07:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cedfab95-d302-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680624453; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=uBXu6YZv6BAp5cZzrn3yHrWUC2z5HKvOE9bB6d7ZZR4=; b=C+WTegrat2MbXQD0eTtTXHY77Y/y9cnBEfngiiX/94eFKxSc6DcWn2IU qHfbBIoVSa6O9yxr+/2lq4X2vmIR224w0YZKr/K+zglpfZb8rHFUWcMWo b2cF2j3qvJjhGWnGid2kP37FoS7uKmS1WguBabK1w1Yqcdz8RMQTFANWH Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106724147 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:AUokrKgTGvkjyX7osJTilRLbX161VhAKZh0ujC45NGQN5FlHY01je htvWGCOPPuCajOhc912PI61/BgDupXTx9AxHFQ6+SkwQX4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ0IgwPTAGvqtm73a2iGvI8vJwJfO3CadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XaDBCp1+E46Ym6nPXzSR60aT3McqTcduPLSlQth/A+ D2coz2lXXn2MvSA8TeO90vwltbItgKlWdNRN+P72eV11Qj7Kms7V0RNCArTTeOCol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Eec39QWMwar8+BuCCy4PSTspQMMinN87Q3otz FDht9HmHzt0q5WOVGmQsLyTqFuaOzURLGIETT8JS00C+daLiJookhvFQ9JnEai0pt74Azf9x 3aNtidWulkIpZdVjePhpwmB2m/y4MGTFWbZ+zk7QEqJ5D97Rp+JSrel9EfCve0QFt6zHn2o6 S1sd9el0AweMX2cvHXTEL1TRO3ytqrt3C702gA2QcR4n9i50zv6JN0LvmkjTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONk1Hs0DaJo9zqx+HXAaIlmU XthTe6iDGwBFYNsxyesSuEW3NcDn35unT6PG8GhlE75gdJygUJ5rp9caDOzgh0RtvvY8G05D f4EXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLliCjTcbaelAOMDh4W5fsLUYJJ9QNc1J9yr2Zo RlQmyZwlDLCuJEwAV7QNSo5MO+3DM4XQLBSFXVEAGtEEkMLOe6HhJrzvbNtJdHLKMQLISZIc sQ4 IronPort-HdrOrdr: A9a23:5XLDkKPTjTUy48BcTuqjsMiBIKoaSvp037BL7TEVdfUxSKb0qy nAppgmPHPP5wr5IUtQ4OxoW5PwI080l6QU3WB5B97LYOCBggWVxepZnOjfKlPbehEWwdQtsZ uII5IUNDQpNykAsS8h2njfLz/8+qjhzEl1v5an856yd3ARV51d X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="106724147" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v4 3/3] tools/xen-ucode: print information about currently loaded ucode Date: Tue, 4 Apr 2023 17:06:55 +0100 Message-ID: <20230404160655.2354-4-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230404160655.2354-1-sergey.dyasli@citrix.com> References: <20230404160655.2354-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Add an option to xen-ucode tool to print the currently loaded ucode revision and also print it during usage info. Print CPU signature and platform flags as well. The raw data comes from XENPF_get_cpu_version and XENPF_get_ucode_revision platform ops. Example output: Intel: CPU signature 06-55-04 (raw 0x00050654) pf 0x1 revision 0x02006e05 AMD: CPU signature fam19h (raw 0x00a00f11) revision 0x0a0011ce Signed-off-by: Sergey Dyasli --- v3 --> v4: - changed the output to be 1-line long - made xc_interface *xch global - added error checking to xc calls - added error for unsupported CPU vendor - changed printf format to 0x%08x for raw signature and revision values --- tools/misc/xen-ucode.c | 83 ++++++++++++++++++++++++++++++++++++------ 1 file changed, 71 insertions(+), 12 deletions(-) diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c index ad32face2b..bd0bfaaa00 100644 --- a/tools/misc/xen-ucode.c +++ b/tools/misc/xen-ucode.c @@ -12,22 +12,89 @@ #include #include +static xc_interface *xch; + +static const char intel_id[] = "GenuineIntel"; +static const char amd_id[] = "AuthenticAMD"; + +static void show_curr_cpu(FILE *f) +{ + int ret; + struct xenpf_pcpu_version cpu_ver = { .xen_cpuid = 0 }; + struct xenpf_ucode_revision ucode_rev = { .cpu = 0 }; + + ret = xc_get_cpu_version(xch, &cpu_ver); + if ( ret ) + { + fprintf(f, "Failed to get CPU information. (err: %s)\n", + strerror(errno)); + exit(1); + } + + ret = xc_get_ucode_revision(xch, &ucode_rev); + if ( ret ) + { + fprintf(f, "Failed to get microcode information. (err: %s)\n", + strerror(errno)); + exit(1); + } + + /* + * Print signature in a form that allows to quickly identify which ucode + * blob to load, e.g.: + * + * Intel: /lib/firmware/intel-ucode/06-55-04 + * AMD: /lib/firmware/amd-ucode/microcode_amd_fam19h.bin + */ + if ( memcmp(cpu_ver.vendor_id, intel_id, + sizeof(cpu_ver.vendor_id)) == 0 ) + { + fprintf(f, "CPU signature %02x-%02x-%02x (raw 0x%08x) pf %#x revision 0x%08x\n", + cpu_ver.family, cpu_ver.model, cpu_ver.stepping, + ucode_rev.signature, ucode_rev.pf, ucode_rev.revision); + } + else if ( memcmp(cpu_ver.vendor_id, amd_id, + sizeof(cpu_ver.vendor_id)) == 0 ) + { + fprintf(f, "CPU signature fam%xh (raw 0x%08x) revision 0x%08x\n", + cpu_ver.family, ucode_rev.signature, ucode_rev.revision); + } + else + { + fprintf(f, "Unsupported CPU vendor: %s\n", cpu_ver.vendor_id); + exit(3); + } +} + int main(int argc, char *argv[]) { int fd, ret; char *filename, *buf; size_t len; struct stat st; - xc_interface *xch; + + xch = xc_interface_open(NULL, NULL, 0); + if ( xch == NULL ) + { + fprintf(stderr, "Error opening xc interface. (err: %s)\n", + strerror(errno)); + exit(1); + } if ( argc < 2 ) { - fprintf(stderr, - "xen-ucode: Xen microcode updating tool\n" - "Usage: %s \n", argv[0]); + fprintf(stderr, "xen-ucode: Xen microcode updating tool\n"); + show_curr_cpu(stderr); + fprintf(stderr, "Usage: %s \n", argv[0]); exit(2); } + if ( !strcmp(argv[1], "show-cpu-info") ) + { + show_curr_cpu(stdout); + return 0; + } + filename = argv[1]; fd = open(filename, O_RDONLY); if ( fd < 0 ) @@ -52,14 +119,6 @@ int main(int argc, char *argv[]) exit(1); } - xch = xc_interface_open(NULL, NULL, 0); - if ( xch == NULL ) - { - fprintf(stderr, "Error opening xc interface. (err: %s)\n", - strerror(errno)); - exit(1); - } - ret = xc_microcode_update(xch, buf, len); if ( ret ) { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:07:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:07:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518026.804170 (Exim 4.92) (envelope-from ) id 1pjjCD-0005OY-Kv; Tue, 04 Apr 2023 16:07:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518026.804170; Tue, 04 Apr 2023 16:07:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjCD-0005OG-H2; Tue, 04 Apr 2023 16:07:45 +0000 Received: by outflank-mailman (input) for mailman id 518026; Tue, 04 Apr 2023 16:07:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjCB-00042B-FM for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:07:43 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20616.outbound.protection.outlook.com [2a01:111:f400:7eaf::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3cadec5-d302-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:07:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAWPR04MB10053.eurprd04.prod.outlook.com (2603:10a6:102:387::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 16:07:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 16:07:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3cadec5-d302-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0AlkEvq6ByF24u0vM7F2WktRfsIA1tpbWxgiPpskX0XNWu1lFfMbR4d7c+KRAA8JN+pRjDJosWmEcTEkzd6XMcLs14KHV0aYbntoGY1lqSo4KZiqrRZJTCqUiv4jzR9wuj6RnsqFXauGm+17t7kIIKrKYfau94du7utpnpGr/xkhX6MjiNs6yTMeG0VgGKg8MkJeXCeiF+w2hsjHf35EsGwoQuoWgHaInrEUcavaEmxO9MYGeKQFywFaUzuG6Ap1w/WAep+jRl5sC1YCUDdinEzKVdMeHbjFxwY50FeliHGeislR+cc4Qkqrpo45fmHf/z7vfN+zvYES1U8HtQ3sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2CCQNHz3YZYu6kKH9DtowEu2cW9bMzkaJbpFteJ6gbc=; b=i96DBr47vI704e0mhtslpD+n9bR0NzWEbE6Yj4xQjWTv09GaCErDA6sBaO5uXnbi9Q1iY2auAbku+RxNPrW+90HpYBSotTV8v87WAIjayL75otyiwMewQI3JKOWtbtabh86tj54OxOLCUUWvfRAi/iPXbWcOlHdWd+6zIwo6OsDeR/5TAvaciIWjTMkOj2JIZvPEc0uU8IRgjh4U6VQee3GaCQ5tvWj7wCr2uatVtufPmIzhrkjH3KKO73eaTofLHjfmShI4p77C0xhO0gXwmXvS4MG6P030GVlxB2Hzs5w8S5e6J7Kzc80Raca30+j2VUdwyu28egfBIRtafIISUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2CCQNHz3YZYu6kKH9DtowEu2cW9bMzkaJbpFteJ6gbc=; b=P2wm3j0RGT5ejgtbm1i33oOc6CYtCvUp9ZZkBBQihrQEkIXKRnBNpY8tN5VE4zAB16rgmy4pyyDzekTEqbGOVB8YYfAk5FVp03fTREFYPtNU7iWCnR0mA8xVSFCDpBXtQme5rYHB7XO1KB2DDp3V0dKntKjSKVLacpUKBbX6OpVwnHt5DaLAWWICVouGR9uNLXDg3MR4KZIYcODfAkdWXOtOvk6kpTnWKMjIosfbK8UDiEzblLaWGjNXC1Ni0tsc8szjjviIt2wolUb3fRN0ToUszgKwuEgnsV6VwWCxGIsFSHrT1uC5Kbr/Yz/2h2O8siWDcZQ1RuzI7JuAy2C62Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 18:07:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/3] efi: try to use the currently set GOP mode Content-Language: en-US To: Roger Pau Monne References: <20230331095946.45024-1-roger.pau@citrix.com> <20230331095946.45024-2-roger.pau@citrix.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <20230331095946.45024-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAWPR04MB10053:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d204e65-96a9-4482-84f6-08db3526b719 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VfP0zM3lkMCNWowKLN3pye2YIwqwXggcARB9C8WF/cZnaitmjI58EK0BDayyZBB3Q/kgcxBC8pWP7scg3Xwd4/d9Kx5QsLlLtZDGjwxyUwAJoRP1C/C8hViYHRG/JA1CH0X64rq0y/IDY8DsOFUElp9TAvamdO67SYyXZUqOUa4CQoL/WheCdMTfMQhaoek4QT2eh+8LcjVCoicrWZy2XCFbLuomLuUY4zbN9v1r1c5+mnJE+KXeg/osT1H5MDqTAe1lQdVgiRmH+V99vYiqPrOsEHdhfGsQdH8Ye0hKYzTk7TagOT43DMg5QoS7TRH6/Hr35vYHqEjPCn8Y48hg8MLUIFPwIlYN0ru15nevVpaSUIofwMhFUqB50XdutvEtq2R73miiy88f61UUqbV3VxKwtn8RU0+iN8Y+88bNbiN59erstVnBi7eDiRilGT/ToIKDkWt00Y1WEis120btbKTQ894gLvKCYdA0L6FfzaptsoTiEq62grGPhGHEP7cJTA0dJQEo5EYZe7jjKurOTCzgiMPNsifdnoDM8sVu0q7gZQpiiQh6uDz1qY+t4n9aohWbJlpD++0DDKy0yibVOWNRspmVXidfooMDhoXe/r3X0WU8tEyQFZXQrPHrW6RzyW/i8ccwpz1P7rm3m0q8Hw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199021)(31696002)(5660300002)(38100700002)(8936002)(6916009)(4326008)(66946007)(8676002)(66476007)(66556008)(41300700001)(86362001)(2906002)(6486002)(26005)(36756003)(53546011)(6506007)(6512007)(186003)(83380400001)(316002)(2616005)(31686004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUh3SEVaei9obWtYRExlUExyWDZMdDBxcVE3N2RmOHVMYWFZTnBwSHpWTnNP?= =?utf-8?B?RHJvZkpzOVAvcTZPZkxrSy9BdlNJYnlDRjFRVDZ1UVV2T1ZuMmk4MlJtQ09C?= =?utf-8?B?M1lOdUlSWmVhL2JVcFI2RmZJNmhTeUZHOEVCd3kyem1PQ3VBMlU1dlQ1a2lT?= =?utf-8?B?MVlpOG1uNWVtRjhEcHM1U25jSTh0V0xLM2M2dlhJWTc4K0x2aFJtNVpvODZU?= =?utf-8?B?NDdwZ1VodkF0ckJ3a2t2aDNMNzh3OG96cEd5T2hDVksydXdhdUw2Znd6MEFq?= =?utf-8?B?aFBpMEhxM3ZHdUg1NkYrR2NYMk4ycVVPanBwN29MNFllZHZES203b1RmdDRr?= =?utf-8?B?TzhlVExMaU1BYkpRYmtXU1lGOUNTczAySGlLb2txSUNta2FGWkhIL0ZYZlEw?= =?utf-8?B?RWdYY21ZNS9USWtJRHlZdWNqWDgxbE8zVm1wNms4bDRNK0NZazk5NkQzRW5K?= =?utf-8?B?U09wd1JGSysveTF0VDMzTFhWYkkzUWxTUElyRkJpdFI2Q0JhMk5CeVh2UkNM?= =?utf-8?B?U2xsN2M4R3V5MzR4a05XNks2RitkdThIQm13emhjQ2N0L0IwMFJCd09SRGxX?= =?utf-8?B?RGw1TDBpYTIyQXhKdjVuZzZ6VnNKUEpKMzNLZUlpbmtXbURuamkrZHBlTGQ1?= =?utf-8?B?MU1DWHkwZVlNM0p1K1hzclNPajQ1eDFxSkdhYVRtSlgyZnB2OStQMzlFNzNL?= =?utf-8?B?VWZaVVhKN2ZZSUxheGhXSDhER0gyTTFuS2NjWTQyZUc3M2UxSkcxMlpEMzlk?= =?utf-8?B?K1crbHIxUXk3YmE3eUFLZVJFWS9wZFFyZStoZTJoWS83SkFmSWtKanlBa0hI?= =?utf-8?B?R3J3SUVLb2xOVmRiZDBSa1lOT0VpY213QUZHaENvZmdRaHZIUkI3SmZzQkNW?= =?utf-8?B?QUFkYzFENzRoQWUyQ1kxV2l6bXhHbU5RTEF2VGc2a0hwQVdyQXdCczhlSXFW?= =?utf-8?B?RW1xQVZSL3pzbW9HSmdyZTJZZWhzTE9rUmZ5WmkxV0pERkxrSk5NNGlTVVJ6?= =?utf-8?B?NGFUVVJpMXFHRzVsazlsYnpBUEd2L1Vod2EvNWo5WmpFSWZ0Q2tZYk5ZRUZZ?= =?utf-8?B?Rlc2KzNDS29yVHlSTFY2OS9PTUhSRU8xUUp2cmZENzJiMS9kd0NwSmJ5WlZp?= =?utf-8?B?cHRlZHJVNUFYNUNieUdTRGdWd2I1d3p6aFQ5NWliYW9OZ0V0elNHYjNBemhD?= =?utf-8?B?UitUUm5MWXRpTkt2MFY4ZkR3dkhVWEFjZTFCc2lYeWdTMnZQRXpOdURrbkVX?= =?utf-8?B?OFVta25ueVdpN25uSEx0bll5MnFRR2k4NjYwdGkrNEZtVVN3R3Q0ZTBGUTV1?= =?utf-8?B?WmJtS2p4OG5KcnlWZG1TaEp2RXRueCtpQ0ZHSjJVV20zckNKSTJicVk0cDIy?= =?utf-8?B?RjVoZjg5TzlFa20wV2tyd0k1S2xIT1pQTVFIMGZwOHFXd0gvWTRDdkEvVEdy?= =?utf-8?B?Zm9oTlRoYjlHVnFUalk4eTNRVTBYYjA0czhvN1JVYkFCaWdpdUliSkp1TVQ3?= =?utf-8?B?cUlZWDJRN2FhZXVzRVcwZUlFazVITjh5NTlvd0IzREF5MVg1UkVBcndpbnZV?= =?utf-8?B?SWE3dDVaWGcrWUgreXE3dG5YMGpBZjhrVDZvTUtzKzAwS2EzWE9BcjRESUR0?= =?utf-8?B?amlyS0V3aVNEWUNKYXhRTTJpcm9OZTBzM0ZlL29iM3g2dXdZZDcvVjVBaEtv?= =?utf-8?B?Zm0xVmJzbnRlS0xvc25VVC93cjJLNlI3Tm1XdlR1YVkrOE9kRUhmT3loOCtB?= =?utf-8?B?RjdVcXFvK2o2SW5vQUxQNW1JYk1hdDBRNzB3dDhldjB1TldpYm0wWUNYVUh5?= =?utf-8?B?eEUxaE4rdmgvNUI2cXlaZGtEakRaOHRGU2U2eXo1NWpRdG1LeC9kaTBTUnQy?= =?utf-8?B?Q0Z2UEpOOVRaMmluVXFHMC9ZZ21GTHFrWlhoTjVXZVBCRVdUQ1ZsdE5uaUNj?= =?utf-8?B?RGFJaWVTeUVjRDlpaSt0cE9ORHNyWHErT1ZYRmhmSjU5Mkg1MUM3QzlvUlVM?= =?utf-8?B?SUJJMGVoK2hvcjF2VG9wTitaMDB2ZnloZWhQUWUvaFF4azBXOFhYNFEwUzNT?= =?utf-8?B?ejgvd1g5dzdScXVtSU1rdThSU3dWNWRBYUVwQkJlZjVsSGxkWHVOVGFQSitu?= =?utf-8?Q?BVOQRAzvfKjbvF6yMZSQsocS+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d204e65-96a9-4482-84f6-08db3526b719 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 16:07:40.3456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0jMqhkrX42BpFlA5WtXjALpAk09l0+5rjiZZmTlG6OuHfaQf99AXoPe8hz0KSIWiOy90ncg7Yfj1wAZDbdWqqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10053 On 31.03.2023 11:59, Roger Pau Monne wrote: > Modify efi_find_gop_mode() so that passing cols or rows as 0 is > interpreted as a request to attempt to keep the currently set mode, > and do so if the mode query for information is successful and the depth > is supported. > > Signed-off-by: Roger Pau Monné > --- > Changes since v1: > - Only update cols or rows if the value is 0. > - Leave depth alone. > --- > xen/common/efi/boot.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) While I realize that docs/misc/efi.pandoc currently doesn't describe what rows/cols being zero means, I think that file needs updating in the course of what you're doing. Irrespective of this I'm uncertain about the change in behavior: Presently both values being 0 means "find biggest resolution mode", in an attempt to have as much info on the screen at a time as possible (in particular in case of problems). I certainly appreciate the desire to have a way to say "keep the current mode", but I don't think this should alter behavior of what's presently considered valid config settings. > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -930,6 +930,27 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > UINTN gop_mode = ~0, info_size, size; > unsigned int i; > > + if ( (!cols || !rows) && gop->Mode->Mode < gop->Mode->MaxMode ) > + { > + /* If no (valid) resolution suggested, try to use the current mode. */ > + status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info); > + if ( EFI_ERROR(status) ) > + PrintErr(L"Invalid current graphics mode\r\n"); > + else if ( mode_info->PixelFormat < PixelBltOnly ) > + return gop->Mode->Mode; What if one of cols/rows was non-zero? You then wouldn't fulfill the request. "depth", if non-zero, is also entirely ignored. (We don't fulfill such a request right now either, but not doing so becomes more odd now imo. In fact right now in this case we leave the screen alone, if I'm not mistaken, so there already looks to be a way to achieve what you're after.) > + else > + { > + /* > + * Try to find a mode with the same resolution and a valid pixel > + * format. > + */ Is "valid" the right word here? I think you mean "usable for us" or some such? > + if ( !cols ) > + cols = mode_info->HorizontalResolution; > + if ( !rows ) > + rows = mode_info->VerticalResolution; > + } > + } Overall with the resulting behavior I'm not sure the title really describes what's being done. You "try" only in certain cases. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:11:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:11:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518040.804180 (Exim 4.92) (envelope-from ) id 1pjjFZ-00084A-BM; Tue, 04 Apr 2023 16:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518040.804180; Tue, 04 Apr 2023 16:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjFZ-000843-7x; Tue, 04 Apr 2023 16:11:13 +0000 Received: by outflank-mailman (input) for mailman id 518040; Tue, 04 Apr 2023 16:11:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjFX-00083x-Qs for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:11:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d2813f0-d303-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:11:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8F646366F; Tue, 4 Apr 2023 16:11:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C854CC433D2; Tue, 4 Apr 2023 16:11:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d2813f0-d303-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680624663; bh=eKiqHkoBVo1AQRx10HafTawauui+/7aWix/7MTRPGrA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nkcQpc5NRHDKcALdEO/kD1vJ7JRnALrRH75LPh2TDOMavdcMgvCuVznC7x8x+ecKt 1/q7prAN9eClvaAU3c0+dUWFvcRO66V04KGg+gYkb+YrMhjTw0ASpXENR+YKBHmeia 3Q5pvbnqrK/uCSEeFKclNxI3vwOX0dUud1/pCQiZ36qwD28S6odWh3QMAvbBbgMd/s C/Qhj0iZpFO3X/jYT9y3J5qKvtPSjj/GrdFNEZo1J9pLwcjwlot2Tv6qfpoajNxUA+ o+rmP5HeMIpXk0J+ytkWwcX3yLOfhBvsgasfRd7/C7/NUehmnMEdxtOqmb8yLnHceu ZoK1FHXZYisVQ== Date: Tue, 4 Apr 2023 11:11:01 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users Message-ID: <20230404161101.GA3554747@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330162434.35055-1-andriy.shevchenko@linux.intel.com> On Thu, Mar 30, 2023 at 07:24:27PM +0300, Andy Shevchenko wrote: > Provide two new helper macros to iterate over PCI device resources and > convert users. > > Looking at it, refactor existing pci_bus_for_each_resource() and convert > users accordingly. > > Note, the amount of lines grew due to the documentation update. > > Changelog v8: > - fixed issue with pci_bus_for_each_resource() macro (LKP) > - due to above added a new patch to document how it works > - moved the last patch to be #2 (Philippe) > - added tags (Philippe) > > Changelog v7: > - made both macros to share same name (Bjorn) I didn't actually request the same name for both; I would have had no idea how to even do that :) v6 had: pci_dev_for_each_resource_p(dev, res) pci_dev_for_each_resource(dev, res, i) and I suggested: pci_dev_for_each_resource(dev, res) pci_dev_for_each_resource_idx(dev, res, i) because that pattern is used elsewhere. But you figured out how to do it, and having one name is even better, so thanks for that extra work! > - split out the pci_resource_n() conversion (Bjorn) > > Changelog v6: > - dropped unused variable in PPC code (LKP) > > Changelog v5: > - renamed loop variable to minimize the clash (Keith) > - addressed smatch warning (Dan) > - addressed 0-day bot findings (LKP) > > Changelog v4: > - rebased on top of v6.3-rc1 > - added tag (Krzysztof) > > Changelog v3: > - rebased on top of v2 by Mika, see above > - added tag to pcmcia patch (Dominik) > > Changelog v2: > - refactor to have two macros > - refactor existing pci_bus_for_each_resource() in the same way and > convert users > > Andy Shevchenko (6): > kernel.h: Split out COUNT_ARGS() and CONCATENATE() > PCI: Introduce pci_resource_n() > PCI: Document pci_bus_for_each_resource() to avoid confusion > PCI: Allow pci_bus_for_each_resource() to take less arguments > EISA: Convert to use less arguments in pci_bus_for_each_resource() > pcmcia: Convert to use less arguments in pci_bus_for_each_resource() > > Mika Westerberg (1): > PCI: Introduce pci_dev_for_each_resource() > > .clang-format | 1 + > arch/alpha/kernel/pci.c | 5 +- > arch/arm/kernel/bios32.c | 16 +++-- > arch/arm/mach-dove/pcie.c | 10 ++-- > arch/arm/mach-mv78xx0/pcie.c | 10 ++-- > arch/arm/mach-orion5x/pci.c | 10 ++-- > arch/mips/pci/ops-bcm63xx.c | 8 +-- > arch/mips/pci/pci-legacy.c | 3 +- > arch/powerpc/kernel/pci-common.c | 21 +++---- > arch/powerpc/platforms/4xx/pci.c | 8 +-- > arch/powerpc/platforms/52xx/mpc52xx_pci.c | 5 +- > arch/powerpc/platforms/pseries/pci.c | 16 ++--- > arch/sh/drivers/pci/pcie-sh7786.c | 10 ++-- > arch/sparc/kernel/leon_pci.c | 5 +- > arch/sparc/kernel/pci.c | 10 ++-- > arch/sparc/kernel/pcic.c | 5 +- > drivers/eisa/pci_eisa.c | 4 +- > drivers/pci/bus.c | 7 +-- > drivers/pci/hotplug/shpchp_sysfs.c | 8 +-- > drivers/pci/pci.c | 3 +- > drivers/pci/probe.c | 2 +- > drivers/pci/remove.c | 5 +- > drivers/pci/setup-bus.c | 37 +++++------- > drivers/pci/setup-res.c | 4 +- > drivers/pci/vgaarb.c | 17 ++---- > drivers/pci/xen-pcifront.c | 4 +- > drivers/pcmcia/rsrc_nonstatic.c | 9 +-- > drivers/pcmcia/yenta_socket.c | 3 +- > drivers/pnp/quirks.c | 29 ++++----- > include/linux/args.h | 13 ++++ > include/linux/kernel.h | 8 +-- > include/linux/pci.h | 72 +++++++++++++++++++---- > 32 files changed, 190 insertions(+), 178 deletions(-) > create mode 100644 include/linux/args.h Applied 2-7 to pci/resource for v6.4, thanks, I really like this! I omitted [1/7] kernel.h: Split out COUNT_ARGS() and CONCATENATE()" only because it's not essential to this series and has only a trivial one-line impact on include/linux/pci.h. Bjorn From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:14:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:14:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518050.804190 (Exim 4.92) (envelope-from ) id 1pjjIv-0000D6-RF; Tue, 04 Apr 2023 16:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518050.804190; Tue, 04 Apr 2023 16:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjIv-0000Cz-NV; Tue, 04 Apr 2023 16:14:41 +0000 Received: by outflank-mailman (input) for mailman id 518050; Tue, 04 Apr 2023 16:14:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjIu-0000Ch-1P for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:14:40 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe13::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cca72ce1-d303-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 18:14:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8965.eurprd04.prod.outlook.com (2603:10a6:10:2e0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 16:14:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 16:14:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cca72ce1-d303-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxDF+AoahQsIazkgLmGUOEB1HZGNhxuBZ7CqJbChgxVtEb+V1oMVMsYrYQU3autLwehhrH4U09bM6iPc30+M3N24yAKgxfCendALi04VHnzE3392qU4qwHB7Bh4G7307LrYYWhZEhIJB+5zIGQ+nDd78g2OvI/G9Ui0SpQot7Qvs1jtuBnlz8yKVjyaYC/wnJom/urcFTW5ne00qvolpMLDijiGcMAuzZHAv46yU5f5265HGgfGCFlOtAbpPW7eNvjZwtlCiDSak0p/6Wr+zYwIJwGcoDYeS4AMQXFNWeUjFQryQIn3tUPPz+o60ywxND0xZ+K84rTV9324AhqCdnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EnWiy6JScAf/NRInOHVOq/udM6RNapUPBQzbUYxr1Xs=; b=Lg0spScQOCFiftogrciJLn08wLJm0b60/9ue5eMeWFFeF5aBtbPey2ISYIhTdzT1tVXAJb/14gVBhy0qz3liHKx1fqyO7zozPf7iWmf/yNTjVgFQ2Hz+333/buHAnIz6c8PDsuNJn7Q4iRHITi5dCWp91pmX5goKlf7jcvtrJVMdinAb1Hr/6qOLt60W3wtILbhUaI4/mrpOZ/gfe9UzhpsUnxusNVzv6TzkSIwr1/08TlkjEuD7yQJz50Mm5JZkWcCb0U9jGvLIX7RhxvrQylvbjSdQiRow0qKPWlW1ctHVZJ3GnsI+llptwqZPqC2/+z5crAb5DwLzYKEd60ELoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnWiy6JScAf/NRInOHVOq/udM6RNapUPBQzbUYxr1Xs=; b=aRGcCZEMN56MdYhmcec1BPO4ub485kwyRfbxRipYq++NU3MnxG3p/7FpVSjm6TVst+Avk7T+mxoFLV9kt+dnpSpV0r7qlSeoDJwvAGKaE+meqCJoUPTRzUSJMT5Skzh932llx2tDtPTT+YI8BDvXfsPSKZHhrc7hRialGroUjolV68jNQgxsXTKz6+sbvtEA2UvRwfMJ8mfc/K3YlgNCtlPzPRxuHQUeXtvZrEd2+sMoR2Ex5C2OiCj3BDpXIC4a24x57DZZ25DWiDDg8Y2CmituFkAxLbTdTJG04T3Q93mOzCMHvktuS377HW/u94k5TMrXNPFnGUmh4wUZjoR4Uw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 18:14:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 11/15] x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-12-andrew.cooper3@citrix.com> <087536dd-96cf-84f0-4b8f-d4de4d6bd093@suse.com> <0c43546e-0333-af19-efa5-71cfaf5efa3f@citrix.com> From: Jan Beulich In-Reply-To: <0c43546e-0333-af19-efa5-71cfaf5efa3f@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0225.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8965:EE_ X-MS-Office365-Filtering-Correlation-Id: 26effeed-589d-4817-d268-08db3527adc5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fSme10hNEqs6WNvJlK2SB9uD6SwrBrS0hOaBWob2EAQWk653q/7Lwy1QjbPVPGYrI4PvmorPcHosKuDhViygMgpx5cfLlsH9PZ368zgSlHLkznTnoGSsG6NyJAEtOG42XfE3DKoZls7Tv8Ip90Yn5GPXkt7ueN9N1H8m8QP9sxu857HicNi5I4zGm89GBFja0DBgZvu4BgD7lwczI+00NHALGumCHjP+lJLCUeXhA81BJD4tHbcrvdvxYNqZ0CS0KlaKF9otdB57PAIBDwx2iaeJBojB8tI19rtojthlzpvVhIlhr2K6DyZkxrSNg7TPsbABDIXETZBD/HdyUzn9Ml3/OBkidaP/CMlFf/6AqCyC1JwH0WSwFW1CpnJbQpkZT5/YLswWF+X/DKDNJAAGe1iS0btpTC6FcJBMqhxEwb+JG/d2P4SghDf58ak20ZH85NtbriezWLmWb9FLo82TvcHDEHWbYp6sw0seIXHhk/Cb71z2vq5t90iGFB6pdqksNqyu71mZDCQu06QX2T85qQHQoRCf4WnK1XnBrJKNssdUnb1jsw42nvH6YdbxaDaTehEVRrIC8MsUyWTvjpVkRr9WB6AdsvXnlFmcvugcf72D7dSC7TDMK1hTbo17F2T8ij/bMkciJ0kVBIMO0Oc8fQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199021)(6916009)(66476007)(478600001)(316002)(8676002)(4326008)(66556008)(66946007)(8936002)(54906003)(38100700002)(41300700001)(5660300002)(53546011)(6486002)(186003)(2616005)(6506007)(6512007)(26005)(31696002)(86362001)(2906002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZENxVU5tYUNNUWJtTDN5eUdXeFlWUEdDR3NTZWZ1MTJSeVNjc0lPSm84RENx?= =?utf-8?B?b2RJaEUreVVHS3ZMRjBxSjhDckRxdlJnMnIrTFlNRGhqeGgvczgyd2RnZ0ts?= =?utf-8?B?d2JjVVl2YWxkSzBLbUcvNUwwWDZMUXBuZXIxZzBnT2NDSDMyRW1IUVpvalhv?= =?utf-8?B?cXdiWmlnUkFYN0Y2aEgycVlFT0hSeCtLSGlramFYdVBWMU5oOFJiK2dDc0dk?= =?utf-8?B?Q2RxbUM0VWd5RmhJRjNJOTdmUEdhUmVkSXdabVVGb2VGV2RHdm1LT3BNRGlx?= =?utf-8?B?UU1DamhCcXl1eGw1RG14UFJ2YlB0WGY0YURYMnFFdHJQdXlLbWVBR0w2ZU00?= =?utf-8?B?TGZvemdacnJld2FyN21VVkQvb1c1d3lnbE1GL0hYZmVPa3MrUnQxS0l1bjNX?= =?utf-8?B?dUNFaXA1ZjBycWdLT3NEVm8vQmdiMHB4SVdQVmdPdWVMMDIwUHhHV1h3RzVI?= =?utf-8?B?bytOOWM4a3ZKMXc1c3hreWpWZHYyclQ3RXdZTzhVNHVtblhja2Ftck80a3ZV?= =?utf-8?B?Vk9ZRmswbkZqdjRNOHgveTVvclhsZkN0VDhBb1krV1l4cVlDQ2MrZmNJUTBo?= =?utf-8?B?L01TM3MrRUpGZ2RGZnQyVzdjVEtnbThndWVUQ0VVRnFXeHlSR2swZ2RMczE3?= =?utf-8?B?clJYMlhob0lWRkRIL01DR2xLR3VQMHVWWFpza3hORWtJNWFIZWtWVTFzUGsy?= =?utf-8?B?WEoySk96NjVsV0dubzNpNy9oUFk2M3FibVdmYTNvUm5JeDdBUlFicXRnbDB4?= =?utf-8?B?VEJGc0Q0eDZYZXhFNVRtUitNbi81UXlKWWt6cGRiS1IrbnlhTTNwVGVVZ1Bm?= =?utf-8?B?ZE9Obm9yRFZNTGRmTTdvRDZScUt1eHpDVjdRdS8wQ0lyVkFnbzAwZ3NBMTh1?= =?utf-8?B?ekxvSnhscndUWmVXM3ROVENVdC9raG9nSmtEeDRMejM4R3ZUKzN1dUtDcElr?= =?utf-8?B?RWoyT3hxMEd4S09zVFEvdGtSS1NoNllEdjVRWGEvWjdxbHRUS0pGeXhKTVhi?= =?utf-8?B?bXAwVnhxb2cvZ3c2aGpjdEpKRHJjcWx4cDR3YlpHNUlLa1V3ZG1ob0drODZV?= =?utf-8?B?cWp2cE9OYXlpWEZLZURqYTNFam5oSXNxdlBHUW5JYTFIbTNnNHpqVStOaDM2?= =?utf-8?B?RGpKc0dlZ2xhK2NqbUZkTENLSWgxQU9rNzV2emYwWWVzSFUyZFUwMkdxV2xU?= =?utf-8?B?RWRQS0Jwb0JpdlA5NTVUd1E1azBSVm9NcUZSaERWRC9XeWJuZE43bVI0R0d4?= =?utf-8?B?TU53WldXa0JaSjg3ZkpsSkd2WnpuWlRKbXQ2eGRodmRiUEJMN3Mwb3JCVUEy?= =?utf-8?B?NVpxVmkwQUhrR2c3VkZyUzJObjlNVC9xMHVWRkx0OXpPNS9UY3M2clNxN1Y4?= =?utf-8?B?UXdCc2x0SUs2OFM5L25JOHJGK2xDc1d1RThheFRoeEl6Q2x5WUp3b2tqR3pn?= =?utf-8?B?ZHl4eS9saUF0SHAwcUNpVmp2NWNhR2UwRkFPS2VLZ1lHMEpBRTVmMXc3bk1r?= =?utf-8?B?NjJvV3RlT1I2c0RLbkdWVmRpZG9WUWtYek9PQmthR1o3bjJNTTd3Y0JGd2VQ?= =?utf-8?B?ZkVEbXdBM1dDVWF1YWN5S29Sd0xDQitzbXdKRFJTYkg5Ulk0eUhGaVlIVm9y?= =?utf-8?B?YWUxSGdPa2R5N3M0N1dtYlg5TGVEcjRwYlFNbkk0Z1JwaGlnVmh6VHlKTngx?= =?utf-8?B?Y0MrcGdEeHBBWENicExINExxOGc5aUZpempPZXNVbU1UeWhMK3hZc2hQRmpl?= =?utf-8?B?SGNRWHl3TFJwNXNEcnpXUjY4bG1xSGUwKzJCUkZLOXdXbjJRQkQ4T0lyN1gy?= =?utf-8?B?SHlicURNaVJScnhJc1JGRTAzMjFrLzJuclhWMWpXdTdEVW5JUGdURUxvSmlV?= =?utf-8?B?UmVJN1FrM1VzWW1mMWx3SE1JcnNybzhraURwTnJ2TjUvczNsd0xwaDUwQ2gv?= =?utf-8?B?bGx1cjdzUmRRbEsyQUxvU1FRcGN4N2Vtck9PTjRWN0k3bk9jcDZPTnJiNGlX?= =?utf-8?B?VkpmT3pzWkVhOG1ZQ2JkV2Z0bTlsMXJsVWM5Q3VQY3IxQWRTZXhUZGM0dHhj?= =?utf-8?B?eVc5OGpkMEw1VDNXbHRVb3FMYlFrYUo0QU11WlJ6a1p3MDI3Vkw1dllxTks3?= =?utf-8?Q?VIjMKLgUHHQ0eMWUpn2go8NTP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26effeed-589d-4817-d268-08db3527adc5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 16:14:34.2684 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3yKb9yRXea4X5BM7aNLQ8NbPiS8M2JSCDoFV5ZKBo9aEbpiRmi6P8ly+V8cr87yONEErXwVNPEwTt4PhNN8iaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8965 On 04.04.2023 17:45, Andrew Cooper wrote: > On 04/04/2023 4:16 pm, Jan Beulich wrote: >> On 04.04.2023 11:52, Andrew Cooper wrote: >>> @@ -20,10 +26,332 @@ struct cpu_policy __ro_after_init hvm_max_cpu_policy; >>> struct cpu_policy __ro_after_init hvm_def_cpu_policy; >>> #endif >>> >>> +const uint32_t known_features[] = INIT_KNOWN_FEATURES; >>> + >>> +static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; >>> +static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; >>> +static const uint32_t __initconst hvm_hap_max_featuremask[] = >>> + INIT_HVM_HAP_MAX_FEATURES; >>> +static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; >>> +static const uint32_t __initconst hvm_shadow_def_featuremask[] = >>> + INIT_HVM_SHADOW_DEF_FEATURES; >>> +static const uint32_t __initconst hvm_hap_def_featuremask[] = >>> + INIT_HVM_HAP_DEF_FEATURES; >>> +static const uint32_t deep_features[] = INIT_DEEP_FEATURES; >>> + >>> +static const struct feature_name { >>> + const char *name; >>> + unsigned int bit; >>> +} feature_names[] __initconstrel = INIT_FEATURE_NAMES; >>> + >>> +/* >>> + * Parse a list of cpuid feature names -> bool, calling the callback for any >>> + * matches found. >>> + * >>> + * always_inline, because this is init code only and we really don't want a >>> + * function pointer call in the middle of the loop. >>> + */ >>> +static int __init always_inline parse_cpuid( >>> + const char *s, void (*callback)(unsigned int feat, bool val)) >>> +{ >>> + const char *ss; >>> + int val, rc = 0; >>> + >>> + do { >>> + const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; >>> + const char *feat; >>> + >>> + ss = strchr(s, ','); >>> + if ( !ss ) >>> + ss = strchr(s, '\0'); >>> + >>> + /* Skip the 'no-' prefix for name comparisons. */ >>> + feat = s; >>> + if ( strncmp(s, "no-", 3) == 0 ) >>> + feat += 3; >>> + >>> + /* (Re)initalise lhs and rhs for binary search. */ >>> + lhs = feature_names; >>> + rhs = feature_names + ARRAY_SIZE(feature_names); >>> + >>> + while ( lhs < rhs ) >>> + { >>> + int res; >>> + >>> + mid = lhs + (rhs - lhs) / 2; >>> + res = cmdline_strcmp(feat, mid->name); >>> + >>> + if ( res < 0 ) >>> + { >>> + rhs = mid; >>> + continue; >>> + } >>> + if ( res > 0 ) >>> + { >>> + lhs = mid + 1; >>> + continue; >>> + } >>> + >>> + if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) >>> + { >>> + callback(mid->bit, val); >>> + mid = NULL; >>> + } >>> + >>> + break; >>> + } >>> + >>> + /* >>> + * Mid being NULL means that the name and boolean were successfully >>> + * identified. Everything else is an error. >>> + */ >>> + if ( mid ) >>> + rc = -EINVAL; >>> + >>> + s = ss + 1; >>> + } while ( *ss ); >>> + >>> + return rc; >>> +} >>> + >>> +static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) >>> +{ >>> + if ( !val ) >>> + setup_clear_cpu_cap(feat); >>> + else if ( feat == X86_FEATURE_RDRAND && >>> + (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) >>> + setup_force_cpu_cap(X86_FEATURE_RDRAND); >>> +} >>> + >>> +static int __init cf_check parse_xen_cpuid(const char *s) >>> +{ >>> + return parse_cpuid(s, _parse_xen_cpuid); >>> +} >>> +custom_param("cpuid", parse_xen_cpuid); >>> + >>> +static bool __initdata dom0_cpuid_cmdline; >>> +static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; >>> +static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; >>> + >>> +static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) >>> +{ >>> + __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); >>> + __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); >>> +} >>> + >>> +static int __init cf_check parse_dom0_cpuid(const char *s) >>> +{ >>> + dom0_cpuid_cmdline = true; >>> + >>> + return parse_cpuid(s, _parse_dom0_cpuid); >>> +} >>> +custom_param("dom0-cpuid", parse_dom0_cpuid); >> Unless the plan is to completely remove cpuid.c, this command line >> handling would imo better fit there. I understand that to keep >> dom0_{en,dis}able_feat[] static, the _parse_dom0_cpuid() helper >> would then need to be exposed (under a different name), but I think >> that's quite okay, the more that it's an __init function. > > I'm not sure I agree.  (I did debate this for a while before moving the > cmdline parsing.) > > I do have some cleanup plans which will move code into cpuid.c, and > guest_cpuid() absolutely still lives there, but for these options > specifically, the moment I add MSR_ARCH_CAPS into a featureset, their > bit names names will work here too. > > So arguably {dom0-}cpuid= don't be a great name moving forwards, but it > is is absolutely more cpu-policy.c content than cpuid.c content. > > We can't get rid of the existing cmdline names, and I think documenting > our way out of the "it's not only CPUID bits any more" is better than > adding yet a new name. Hmm, yes: Acked-by: Jan Beulich >>> @@ -149,3 +716,188 @@ int init_domain_cpu_policy(struct domain *d) >>> >>> return 0; >>> } >>> + >>> +void recalculate_cpuid_policy(struct domain *d) >>> +{ >>> + struct cpu_policy *p = d->arch.cpuid; >>> + const struct cpu_policy *max = is_pv_domain(d) >>> + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) >>> + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); >> While this is how the original code was, wouldn't this want to use >> hvm_enabled, just like init_guest_cpu_policies() does (patch 10)? > > No.  That will fail to link. Why? hvm_enabled is a #define (to false) only when !HVM. > This trickery is necessary to drop the compiler-visible reference to > hvm_max_cpu_policy in !CONFIG_HVM builds. > > This function is only called after the domain type has already been > established, which precludes calling it in a case where max will > evaluate to NULL, hence the ASSERT_UNREACHABLE() just below. Right, and this will hold when HVM=y but no VMX/SVM was found. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:16:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518053.804200 (Exim 4.92) (envelope-from ) id 1pjjKR-0000ml-4i; Tue, 04 Apr 2023 16:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518053.804200; Tue, 04 Apr 2023 16:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjKR-0000me-1v; Tue, 04 Apr 2023 16:16:15 +0000 Received: by outflank-mailman (input) for mailman id 518053; Tue, 04 Apr 2023 16:16:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjKP-0000mU-Fm; Tue, 04 Apr 2023 16:16:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjKP-0008Tj-Bq; Tue, 04 Apr 2023 16:16:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjKO-00032c-Rr; Tue, 04 Apr 2023 16:16:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjjKO-00034b-RI; Tue, 04 Apr 2023 16:16:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RqEEFWst+GWVnEQHrqAj94ZB3VIu3nRPZx4GnxqzVl4=; b=FV6aJFQYzlnefih0VN/FqEvdFe xN/jmek009GB+Y20gvPE7zC59FK2dIbg5klzvkIeXp+zOkraiReUW7dhV4QWkVUiJhaSHw9hzwZcD MawGJ3hqz/ToHX9krbH4AN4TJ51DpciV1DlGDFNi3SitVF8JQUNTjCq7MWBAWh3WMI9Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180134: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=d292ddf1cc268bdd8a494f8e7ce76dc3445c26ab X-Osstest-Versions-That: libvirt=145886e36dba23ed3756ab9c52b2ac77c506943f From: osstest service owner Date: Tue, 04 Apr 2023 16:16:12 +0000 flight 180134 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180134/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt d292ddf1cc268bdd8a494f8e7ce76dc3445c26ab baseline version: libvirt 145886e36dba23ed3756ab9c52b2ac77c506943f Last test of basis 180111 2023-04-02 04:23:21 Z 2 days Testing same since 180134 2023-04-04 04:20:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ján Tomko Martin Kletzander Michael Ablassmeier Michal Privoznik Pavel Hrdina Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 145886e36d..d292ddf1cc d292ddf1cc268bdd8a494f8e7ce76dc3445c26ab -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:20:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518061.804210 (Exim 4.92) (envelope-from ) id 1pjjOV-0002Is-QA; Tue, 04 Apr 2023 16:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518061.804210; Tue, 04 Apr 2023 16:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjOV-0002Il-MW; Tue, 04 Apr 2023 16:20:27 +0000 Received: by outflank-mailman (input) for mailman id 518061; Tue, 04 Apr 2023 16:20:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjOU-0002Ic-E3 for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:20:26 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98cfb28c-d304-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:20:23 +0200 (CEST) Received: from mail-bn8nam04lp2042.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 12:20:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH8PR03MB7305.namprd03.prod.outlook.com (2603:10b6:510:251::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Tue, 4 Apr 2023 16:20:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 16:20:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98cfb28c-d304-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680625223; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=acb0Vjzb2vomYZXvOLj89NVgZUGBCCnPCoP9oO0tFqo=; b=GIFvxWaUrEDLx4U7ujAV2SQrFIkan9GMvBbMBaMIVj9hBIUr0Hu9sQfI kZ+f56ZWUF9lnq9SxrxzU6wrJ0qTgLFTkR31QXg6oVgm+wUh8Q8lAvmfT DpFXawoi43FFuG4qK0na0GBqRr1umZABtfn4NWUPrycYyRqqWijQQHI1c 0=; X-IronPort-RemoteIP: 104.47.74.42 X-IronPort-MID: 104214592 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:X9E+nq7zTnfhVXQFo/FnBAxRtBjGchMFZxGqfqrLsTDasY5as4F+v jRNC2+CbqyKNDD1f98lPtuy9U8Du5XTy4JhTQI4/CBkHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my MYSGiwEXgC6xMmc5L2QbrRJrcRgBZy+VG8fkikIITDxK98DGcyGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MkEotitABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpOTuTkq68w6LGV7nEiJQIZUEbmmuXnm3PmUv5eA HUmqhN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc6SDkr/ l6PgdLyBDZrvaGVSHSS7bOdp3W5Pi19EIMZTSoNTA9A6d+zpog21k7LVow7TPTzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:WA1izqzdTowErJzoXHlsKrPxw+skLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFTUO11HYS72KgbGC/9SkIVyHygc/79 YpT0EdMqyXMbESt6+TijVQUexQueVvmJrYxds2pE0dLz2CHpsQizuRfTzrd3GeKjMnOXKxf6 D22iLIzwDQO0j+Ma+Aa0UtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZozU H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUqZ1TChkF5nAic0idkrD D+mWZvAy1H0QKcQoj6m2qt5+Cq6kdS15ar8y7lvZJIm727eNtyMbs/uatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAfqqOYmwtRrQcotQ0rbaIOLLtK6YAP9kJcF5kNWCr89YA8Ce FrSMXR/uxff1+WZ23Q+jAH+q3bYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/ nNdq5oiLZNRMkLar8VPpZ3fSJ2MB2/ffvhChPjHb28LtB4B5vkke+H3IkI X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="104214592" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiXHEQoJ7gUssHZa+/QRf6pnqZ9f0amGUC3btt+EemYAQg0/mFVrNh7hf0PAz8PX6znV4FMGKQ60B5AXwq9Lb6qEVL5Gw8FtFnmg5ae+aUQjqf0Gvh8GmvLh1JOa8GQD+4kxhlPOgEaKG+fJbWOhi2Tk1YMe79gdJvn/nbs78J1BrjjJiENARpdoSdmnwDpTveILtZtftUTu+1n7zba6XuArYKEIFfDIM5yTm+NJaq2Km0/96JdDfNkH+q2a+XBnDQUrlwsStlefo3GO2B3Qa2rOdP98DkEfRVmL6H7/hf29A37YGrGt32zL7Ql4MY9U9G0/8lD+KapQpiH/1hqFfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jj4gGm4oTx0u/+xZtcHtoeuCVzi/i1cnClh6OAVuhZQ=; b=g9iZNjydfgTds69Db0ukoTAOMb0VxG6QXO+v6DSQn1vQUCGNanuiQNQpWb4cAUh9lK/eAClwmiBJ0q48gn96CE7d6EYyzuc4oeWIYDH3bwqUf8JcaimFX11yaPXlwSr97p+iPORd6qM80mEDp08nuq6PzeIbo88I7q2xenvOjA5cVVx+xn2GRNdvgn11JTO4WpxD4Wfjuvae8GdVBBO1UQSKNcHG0p+LEyGCESKul/THwP+CkLCd4jynOF6cHsg1gcrFsQm/o4EzFbGgxlfixGdUN6Z/XRwd2KOaF5GFdw110WBTKSJuh8zYD6SxqrOsgdEHULmGclaDwMJo6Dil3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jj4gGm4oTx0u/+xZtcHtoeuCVzi/i1cnClh6OAVuhZQ=; b=eHBzTi2uAY7MMIL1PhD18PK+hbEHHXKJUeiLi/aUuNkDQznEDBEbLSVyLR0Rc6+T/S1qESO1lYe4zdz2+a1YD0jwEi6V5bhr6ZqEam3Z5Nf7FUlnjlQQ/ya2ljb+jzSooOQqducGoTZtzehzQ9bjt2rhu8qcn5O0E6LGQjLc/sE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <697cec91-0f58-9f50-33db-d2d92d321267@citrix.com> Date: Tue, 4 Apr 2023 17:20:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [xen-unstable-smoke test] 179929: regressions - trouble: blocked/fail/pass/starved Content-Language: en-GB To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Demi Marie Obenour References: <17e95e93-a3a9-962c-1563-f9fc526320df@citrix.com> <20d41dd0-19d1-47fb-92ab-4de458ddd56f@perard> In-Reply-To: <20d41dd0-19d1-47fb-92ab-4de458ddd56f@perard> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0034.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH8PR03MB7305:EE_ X-MS-Office365-Filtering-Correlation-Id: 8659ba86-3a78-4f89-3a25-08db35287a8d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p4haAepPlMwkxv5bNNyATxxsKfJ7L1sqIiuAC9N5eMmsuM0EFBjJ8In+wuR4WtYQoLuvu2mX/itemv54TtYp4XLSJ1PaQT2AgEczfMZxRnDrZZiPaEkMNSRM2+AyZvZscEUcUQxGYNmlbEVWoCIFcOpNDXQ0+OmJLHsYtLfSV1IOggbAIJHV50dJZi1GNaf1tlIjfLDhmpjp543D2Y9ML4t4yurTfqmvn86yGFk5IfOvSWzOu9L2LzdHmOIs3FGIZd+H22mo3AhYn8onpFX1t/iiQAWTVgl9JgyHGTokRi8K1f/yfa6v9gOA7M5/+lGzdQlEYtBo0JKGRexIo/aw38JBfFmwSwo025yCNK+y/OWD/t2rA8M8QWVEq4q8CeAVNSJP9W3XAw2ROGsg9QtDCUdHMVmCxG+oas+oMXp37Zw3XoNhSO9zHKQ3UvHd9w7L3kZVSwvEgtr1tMiwOMra+VjsJ7vaALbD020oC067kkQUAvC7LeKzRLbYGW+vpt3oR99gFGhljFgikn4pNI0ySqdELJmxLZo/4ZoVdta2Ff0RcKVNMhQP5iOQW+RGkKDUamo1NSb9DegxevFoSWV4iJUP0qh/yRH3Ldun8mQdnP6uhIG8S1U3uwYGrggJDqYbJlgc3qRUvpJ6MxUMvWQJOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(26005)(478600001)(15650500001)(2906002)(186003)(2616005)(6512007)(6506007)(53546011)(36756003)(6666004)(83380400001)(966005)(6486002)(37006003)(82960400001)(6862004)(38100700002)(86362001)(316002)(31696002)(5660300002)(41300700001)(4326008)(8936002)(31686004)(66476007)(66556008)(8676002)(66946007)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmI1bmxsVGU1c0pIL3ZWbUF3dUh4VWhkMlFGYnJwRjF1MGJmQldWRUNMV3lL?= =?utf-8?B?S0MzaGlXTGMwNE1TNlhTUjViRkU5VW1GM1lSeUpzQ2dIZDY0ZW8vb2VKZ3N1?= =?utf-8?B?OFVWSGZEdzh0cnl4M2U1Q1k3VlBwZWp5cUNuaUhJaTZldUFJUnhCeGtoemlC?= =?utf-8?B?ZEgzOWFyejdNTkx6N2FPMHFsYmpQRXRVUXAwUWoyVm5rbTJqTnVIV3kzTTl1?= =?utf-8?B?MnJ4VnQzVzJ3S3dxaFMzcW1SUng3RndtY2pLRkdmemhwSTUvYXptOGF4RVNu?= =?utf-8?B?RVBlQnUvWDE5Vm04TGVocFo1TmpZZ2lrQllENHcvTUNGY1VHOFVsWFpEcHFL?= =?utf-8?B?ZkRXT2JDOG1ZRDEyRFRTSjl3L215MnFPeG5RMm1LY3cyblpDQjlKaUlERnAx?= =?utf-8?B?czkxczlwaVR6YktWL1J4ODQ0MUtPSWhRcDMyN0owNEtUcFM5alZtbWxrNFAw?= =?utf-8?B?MVlZOEQ1WjhDM1BZaGgzY0tnUWliNFZ1dmdtOGxGRU9yR3MxZTFJamRlNHpZ?= =?utf-8?B?R2l0VDdhSTNFRDNRaGlGV1FrOW9ub01BSktoeStMTDA2Rk52UG9Td1lsM2Nj?= =?utf-8?B?T3hzbjd5dG5sd2dXNEdEaDFjVDM1dWI0VHRpMkwydUVpWmRDNTVrK09ROWpz?= =?utf-8?B?bHJzNmI1emxJU0I5YUMxc1hLWisva2pobVphclJySVdhdlNFaC9NQTJ5Q1E2?= =?utf-8?B?MjRlMStrVVJETWIvVGhjV1pOajFvSXNSVTVZdzFoUmg2M3czVHkraUJYU08v?= =?utf-8?B?MnQwVlJUNjZmdW5CWUpZSkcrbFBmN091SEVhRnUxOURtUk9BMXpEMURqWXF1?= =?utf-8?B?VnNIMENFM01Qck5uSTVjZnd1akZ0YzZQNWhGelJ1MkpxSlY5YmN1Zjk1Yys4?= =?utf-8?B?S0RUMEVQY09ub0pYZkUxSDVjb3lQVUZlTzBvQUM4QVQxTFJLVGlwNU9wdFFm?= =?utf-8?B?TjFYcEpVR0JHblNJSk5GU3AwVnFXdWJxZTd2dFpmcVZBN3FkbS9rN3lZNjh1?= =?utf-8?B?Qm9PalNzWDNIcXROZmVOcC9yalhhZ0RzbG1RekxmUHY3YXAreWxwNWVDOEgv?= =?utf-8?B?eFVseVJkOU8vU3dkVjJEQjJ4Ukx1Ni9WS3ZWMlVFS29Cd0hiSEVZTHZUdjZC?= =?utf-8?B?T0c3c1J4QW1QL0sraEVLdHFJc0hvQmlCU0lnV3JyaVJDVFpQZytFdTBSbXFI?= =?utf-8?B?QS9ENzVWV3kydUZKak1WV1h3cTZTTFdhYWgxY0hORmNuMmc5UDJNZUVhWllr?= =?utf-8?B?a3VKVlBTU1pBYU56R1R4ZlliNm05WW1rZEkyaFNzejRhUmFPaXM2cy92ZXdt?= =?utf-8?B?dXpodVg4TU9yNWhtSjFoakg1YTZ4aHdqaEUwckx3SU9MTnVITFlTemhhT0E5?= =?utf-8?B?WStUUUdHUWY5L2JhY2VVVGordVkrYmNKeldSdTFmWlIybDZzN3hCWVMybUg4?= =?utf-8?B?ckprMEpSRVlWbHRVYUp1djgyUmRDZktNczIycTJ0Nzcxbmc5SVBIUG9UcUlh?= =?utf-8?B?d1J2ZVZJVDFCZUtJTG5vWlNqb3NvcllLb3U4bXZsb3hCRzUrYTF3N0JRRnRJ?= =?utf-8?B?emFCVXRKSDRtdDZNZmFJRFR3aWdQdGc0RkkvcXNqaS9jZTNPZTk0aktrZFdW?= =?utf-8?B?YjAxY0ptekd1bmIxcjNnZmFGVE51dW5TVzNlMGFSZ09OMitpWE1wUmZnMlZY?= =?utf-8?B?YTE3NzBVUFJvcEhYdmVpdFNPaDlBaFozQ1JoU2ZFY2d1SzdGaGt1TlJVSk8y?= =?utf-8?B?RTRWYmxVR3FDZllGYVVhNVQwU3RCZ0d5dzN0b01NU3gwdlNjb1lqci9TdlhC?= =?utf-8?B?aXlFWnlsbmtpRnlaNGZwYnROdWpXVFBTMTQ2SnR3cGVEQk1HaFdFTm5lMXBt?= =?utf-8?B?aXhYUEp6Z0pZM0FXZ0l2VmxMUGNINlhINFMyQ1h5VjlqeFNHVm8rTFpkaUZQ?= =?utf-8?B?TUdUVkc3WlBQbFI5NStDWGx0Q0NVYitMeEFsNjFYSU9uQ2l2cEltM0dvTVNz?= =?utf-8?B?d2U2TWRuZmJ5K1oxWEpWZ0phWGFTeTJmSysyVzJlajdFdVROc0FPL1lqWWox?= =?utf-8?B?VHlKZ2hmLy9mb1lrVllSVUNDaGNHU0hlK0lxN2lBejZaNFppT3dZYjZnSGlF?= =?utf-8?B?dHhNSkZhOVB5aThQZVJoOVhpcUh2cTI1OU54SkU2Y3pZdG1tTzdzMCtjRzJN?= =?utf-8?B?RVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: phkGOa41YsSDAtkUI7cpdr34HqbCnw4wLy2A99ZrFZI9/dTj3aT3XZOOnEKMKCzX9RaQxAnA25jxoH1bXMF9yiy31nXuovAY8WmLF8LDokbQpLcWtmMuIyPPwaeQSFep8eq1YEesGJs8J8gjSTeOcNwdiMMkLajsB4ibEtZ7W6wP88WKZWXRkmXXZAcSy+EFHBJ42XDPsAOcwW4oi3yQDfJ+sVUPnRXrPbFHFFKwPozB2/xiTeoGvSvjT3prmWEd4SDT6vwTmuirIAmg3wInxhrxGlx7INlWufVRLurqu2w6Ob03pSduW3FpmD1gKStYL3e/W4ihXnFHc3fiKDi0+6os0eLMwA0xMtPxRlZzmn3LiMy2qsbpOxQTIt57lECjlaRQQn4ncrZZX3i+7Yy/96ctUFtf2cUn6oK7Kst/da6BbymigNEuNJxMzUnCEtP+zOvTUTvDqUnYYM9znwkg8c3mFtApD0C1H6F06oSkRt59GngXblNC0J4eYQQfGDCl+sz1sY9pvmnY044aJFvAeGP3CCiv8Y2pq3TORLpS0vxpAo4cYUmbpLhnESLEDz+F0Ok9iauJGYbLa11VJeJ4Eblcl94NP0vKKfaSU1+8IfptKnBKj1OhO5l+TuApf2BINAxooRFzAaSuHc7XtkPx8pKKu03RXO1qalQYfimpgMnME5CoCNetlgpQg7fm1VdFPBkB1koQwVsU36+AHeyno4qJdVPv9GPmCB8YOtXQtsTzjZR+7TPowSrWP/bXeBxAlzquTrpgRNbwfY21euWae611iQrLbB/OHA8v7Xt7wjup3KtHnH90H3C81ULq6c+/7n+UrZ8QsJYSG94r7LpUfA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8659ba86-3a78-4f89-3a25-08db35287a8d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 16:20:17.8494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R/HM4adQ7hPrS1jTS0Dt26pvhHSBjIArHqWrA6+A4RFDMpzsoMOyiW2CQEBLXTBeIR8QayIKJ/7S8CYbjTCIhWzf2tw63CH4pPEHsrrWOcs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR03MB7305 On 04/04/2023 2:51 pm, Anthony PERARD wrote: > On Fri, Mar 24, 2023 at 08:37:06PM +0000, Andrew Cooper wrote: >> On 24/03/2023 8:28 pm, Andrew Cooper wrote: >>> On 24/03/2023 6:58 pm, osstest service owner wrote: >>>> flight 179929 xen-unstable-smoke real [real] >>>> http://logs.test-lab.xenproject.org/osstest/logs/179929/ >>>> >>>> Regressions :-( >>>> >>>> Tests which did not succeed and are blocking, >>>> including tests which could not be run: >>>> build-amd64 6 xen-build fail REGR. vs. 179926 >>> Bah. >>> >>> make[6]: Entering directory '/home/osstest/build.179929.build-amd64/xen/tools/firmware/etherboot' >>> set -e; if ! /usr/bin/wget -c -O _ipxe.tar.gz https://xenbits.xen.org/xen-extfiles/ipxe-git-3c040ad387099483102708bb1839110bc788cefb.tar.gz; then \ >>> git clone file:////osstest/IPXE-GIT-FORBIDDEN ipxe.git; \ >>> (cd ipxe.git && git archive --format=tar --prefix=ipxe/ \ >>> 3c040ad387099483102708bb1839110bc788cefb | gzip -n >../_ipxe.tar.gz); \ >>> rm -rf ipxe.git; \ >>> fi >>> --2023-03-24 17:06:51-- https://xenbits.xen.org/xen-extfiles/ipxe-git-3c040ad387099483102708bb1839110bc788cefb.tar.gz >>> Resolving cache (cache)... 172.16.148.6 >>> Connecting to cache (cache)|172.16.148.6|:3128... connected. >>> ERROR: The certificate of 'xenbits.xen.org' is not trusted. >>> ERROR: The certificate of 'xenbits.xen.org' has expired. >>> Cloning into 'ipxe.git'... >>> fatal: '//osstest/IPXE-GIT-FORBIDDEN' does not appear to be a git repository >>> fatal: Could not read from remote repository. >>> >>> That's OSSTest choking, apparently with the same LE root cert problem? >> Given that there's plenty of content wanting testing right now, and no >> chance of this being looked at until next week, I've reverted e1d750844 >> (which was just a single hunk anyway) in the hopes that we can still get >> a useful weekend of testing > The certificate of the HTTPS proxy has been renewed, and osstest has > been updated to use the new certificates. So that commit should work. > In other word, osstest is ready for a revert of b5cc3c25a242 ("Revert > "build: Change remaining xenbits.xen.org link to HTTPS"") > > Cheers, Thanks.  I'll revert the revert. Fingers crossed... ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:27:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:27:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518066.804219 (Exim 4.92) (envelope-from ) id 1pjjUu-0002xZ-Gz; Tue, 04 Apr 2023 16:27:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518066.804219; Tue, 04 Apr 2023 16:27:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjUu-0002xS-EK; Tue, 04 Apr 2023 16:27:04 +0000 Received: by outflank-mailman (input) for mailman id 518066; Tue, 04 Apr 2023 16:27:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjUt-0002xK-2n for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:27:03 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86249a4d-d305-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:26:59 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id br6so43025676lfb.11 for ; Tue, 04 Apr 2023 09:26:59 -0700 (PDT) Received: from [192.168.202.197] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id w7-20020ac25987000000b004d5786b7299sm2393695lfn.5.2023.04.04.09.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 09:26:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86249a4d-d305-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680625619; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OmE3+4mkKRClmf97yq5669zSeIG+gT8wURrmTIS+7sg=; b=OSFBnMwyzxDpJUp2dHCeg7rzHTOaTjujj/6I42VEd9kOWuiWeXIzI5qCdpWtSZZ8b0 D8jBXn+kbirgwJMhnaibRRJusCs2ifhQb6V6enzIsDxiZUBUfglbSqICznk5OGEBq6k8 qA0Y7YP2VjIUyDu6fOaz7fi/IfPbO+/+KpUOu/mv/ELS4octetJr+yHrmU6nmHPwmhP4 ZA3Slvz9K2IPtPfozOH+qbdqGgXfOikvjhNFnVwKXr8zIE8JUZadWUkKTZcA3VJu5pBG O2oM1b5z2dRvroZgtXT9YP5kO4i6ob2siBbA9pDbaBO5Box7j3VxK+RCeeSS/3AjDB6v igHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680625619; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OmE3+4mkKRClmf97yq5669zSeIG+gT8wURrmTIS+7sg=; b=UZO06bw78qzTBMzceL1nL1bQLc1sl5jQYg8sOSMEzBuSzp/bPD/h6iLY1naDyWjDon Ot773JOUY05I/jeHNY8VP2l1bIzgzu8Jy3uu5aGfJqnWnFIPc35f5Cs5zLoKZyRolGBz JhDlIysiPic4gusoE4sbUM9x3IM1H9pI9m5t5lV5fF3S9VXQfXJvgk5hJ7ExgDD1WuzX 0ogR+gPe6LDZm1VW27JFCesShQmgkfRCGp3V7LUW2c2JrztjB2XKEeVI+S0V+Ph/uSzI OR854AWB9CfkTEGLeCuPt2YG5Im4AB/NfTEh/vWbjh2fCEn/4WtS093HrF8kuQ7BkyX6 tg7A== X-Gm-Message-State: AAQBX9cxyqo0M+2RdF79E81iFjG3vU+trLlE/gbLlYSJrhTVDKDXCT/V hbdCjpxJvfGfCMwUmrt1/CU= X-Google-Smtp-Source: AKy350Y7stklTXPa+K/oV7wrJeU6Tm1Gp8FOdgiWdJxinC8a8+cNvUU/yYakY30v/7Enn+G90YTRHQ== X-Received: by 2002:ac2:4823:0:b0:4eb:edf:fb5e with SMTP id 3-20020ac24823000000b004eb0edffb5emr863032lft.44.1680625618897; Tue, 04 Apr 2023 09:26:58 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 1/3] xen/riscv: introduce setup_initial_pages From: Oleksii To: Julien Grall Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 04 Apr 2023 19:26:58 +0300 In-Reply-To: <621425bb-03ad-1a5b-f53f-553eeefebf44@suse.com> References: <93da6ba381604748e2c71e2ebd35e80798ec4bb2.1679934166.git.oleksii.kurochko@gmail.com> <0a16b79e-8292-6947-24d4-dd027113943f@suse.com> <621425bb-03ad-1a5b-f53f-553eeefebf44@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Hi Julien, On Wed, 2023-03-29 at 14:06 +0200, Jan Beulich wrote: > > > > +void __init setup_initial_pagetables(void) > > > > +{ > > > > +=C2=A0=C2=A0=C2=A0 struct mmu_desc mmu_desc =3D { 0, 0, NULL, 0 }; > > > > + > > > > +=C2=A0=C2=A0=C2=A0 /* > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * Access to _{stard, end } is always PC-r= elative > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * thereby when access them we will get lo= ad adresses > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * of start and end of Xen > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * To get linker addresses LOAD_TO_LINK() = is required > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * to use > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 */ > > > > +=C2=A0=C2=A0=C2=A0 unsigned long load_start=C2=A0=C2=A0=C2=A0 =3D = (unsigned long)_start; > > > > +=C2=A0=C2=A0=C2=A0 unsigned long load_end=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 =3D (unsigned long)_end; > > > > +=C2=A0=C2=A0=C2=A0 unsigned long linker_start=C2=A0 =3D LOAD_TO_LI= NK(load_start); > > > > +=C2=A0=C2=A0=C2=A0 unsigned long linker_end=C2=A0=C2=A0=C2=A0 =3D = LOAD_TO_LINK(load_end); > > > > + > > > > +=C2=A0=C2=A0=C2=A0 if ( (linker_start !=3D load_start) && > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (linker_start <= =3D load_end) && (load_start <=3D > > > > linker_end) > > > > ) { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 early_printk("(XEN) lin= ker and load address ranges > > > > overlap\n"); > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 die(); > > > > +=C2=A0=C2=A0=C2=A0 } > > > > + > > > > +=C2=A0=C2=A0=C2=A0 calc_pgtbl_lvls_num(&mmu_desc); > > > > + > > > > +=C2=A0=C2=A0=C2=A0 mmu_desc.pgtbl_base =3D stage1_pgtbl_root; > > > > +=C2=A0=C2=A0=C2=A0 mmu_desc.next_pgtbl =3D stage1_pgtbl_nonroot; > > > > + > > > > +=C2=A0=C2=A0=C2=A0 setup_initial_mapping(&mmu_desc, > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 linker_start, > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 linker_end, > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 load_start, > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 PTE_LEAF_DEFAULT); > > > > + > > > > +=C2=A0=C2=A0=C2=A0 setup_ptes_permission(&mmu_desc); > > >=20 > > > ...: Why does this require a 2nd pass / function in the first > > > place? > > Probably I misunderstood Julien and it setup_pte_permission can be > > done > > in setup_initial_mapping() but here is the reply: > > https://lore.kernel.org/xen-devel/79e83610-5980-d9b5-7994-6b0cb2b9049a@= xen.org/ >=20 > Hmm, yes, his option 2 looks like what you've implemented. Still I > don't see why the permissions can't be got right on the first pass. I would like to ask you again about separation of mapping Xen and setting permission for specific sections. I am not using setup_initial_mapping to change permission flags as it was before so do we still need to do two passes? Can't we set permission during the first pass? It looks like there is a sense in merging setup_initial_mapping() and setup_ptes_permission(). Probably I misunderstood your opinion from the link above. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:29:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:29:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518070.804230 (Exim 4.92) (envelope-from ) id 1pjjWx-0003Vr-Tj; Tue, 04 Apr 2023 16:29:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518070.804230; Tue, 04 Apr 2023 16:29:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjWx-0003Vk-R8; Tue, 04 Apr 2023 16:29:11 +0000 Received: by outflank-mailman (input) for mailman id 518070; Tue, 04 Apr 2023 16:29:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjWx-0003Ve-0a for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:29:11 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d279d7c6-d305-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 18:29:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d279d7c6-d305-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680625749; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=muyEy+imng+MiuS0rC7GNqhnQwFZmakSOGOJA1lr+IM=; b=EZQUfEaG6DqHe/5dnXKjbQUx7Cl9BPUw6Dy5D0Qf6JeaKkhPJM+sUtF/ LMb2mCwsSoFuhJYHw/gNTg2OaBR8Adfup2PHb/AXqzscXcPu06ncCTQfJ zZROcIDK1a/f9dPDX2dOmsTYLNki0wnpXCipBv/PzHtMj89UZPRCUDMhG 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106727183 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:jRNvnK/ES7sHIGEiyo3jDrUDvn6TJUtcMsCJ2f8bNWPcYEJGY0x3y jAYWzzVP/aOZDT1KN93Ot6z8BwD75eDyNNkGwZo/H88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklp9 MxfJSFcdCvaiuC8/JHkS+Zp3J0KeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0MxhjH/ D2frz+R7hcyDPnC2x3c3lGVp9CXvT3dYIY+BJn76as/6LGU7jNKU0BHPbehmtGhh1KzQZRfL F0Z4QInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMrtYk9RTEs/ laTmpXiAjkHmLeYU26H/7GY6za7IzEILHQqbDUBCwAC5rHLv4Ubnh/JCNF5H8adh8X4Azjqz xiWrSI1gPMYistj6kmg1QmZ2XT2/MGPF1NroFyNBQpJ8z+VeqaCZrzv5EmK980ZIYSTcnrev XcBwZG3ubVm4Y62qMCdfAkcNOj3t67baGGH0AIH84oJrGr0pSP6FWxEyHQnfRoybJ5ZEdP8S BWL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJz9zq3+KTUuftjU ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6rl0n7j+vEPyTLGd/p1WdiichgtMu5TPj9q Y4DZ6NmNT0EOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+H+aSI0l4U6W56ep4K+RYc1F9yr+gE oeVBhUJlzISRBTvdW23V5yUQOi1Aswl9S5jbHRE0JTB8yFLXLtDJZw3L/MfFYTLPsQ6pRKoZ 5Hpo/m9P8k= IronPort-HdrOrdr: A9a23:IBAPkahctH3S8mul+LPfnLaXXnBQX9923DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVpQRvnlaKdkrNhRotKPTOW81dAQ7sSibcKrwePJ8S6zJ8l6U 4CSdk1NDSTNykcsS+S2mDRf7kdKZu8gcaVbIzlvhRQpHRRGsRdBnBCe2Sm+yNNJTVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zutsDGj5XvZD8BHloC5BOVhT2lxbbmG1zAty1uHw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69B7icbs0dxKAe2Lk4wwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87isIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsOuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59Ts5Ufa/pfVFZil/1cwKpnKuZEIMs80vFiLA BaNrCe2B+RSyLcU5mWhBgo/DXmZAVIIv7PeDl+hiXS6UkYoJkx9Tpm+CQS801wiK4VWt1K4f /JPb9vk6wLRsgKbbhlDONEWsevDHfRKCi8Rl56DG6XYJ3vAUi93KLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwbrBdeV1JNG/xjRSCHlNA6dgv129tx8oPnxVbDrOSqMRBQnlNahuewWBoneV+ yoMJxbDvf/JS/lGJpP3Qf5R55OQENuGfE9q5I+QRaDs8jLIorluqjSd+vSPqPkFXI+Vmb2Eh I4LU3OzQV7nzKWs1PD8WjssinWCzLCFLpLYdnn1vlWzpQRPYtRtQVQgUil56iwWE5/jpA= X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="106727183" Date: Tue, 4 Apr 2023 17:28:58 +0100 From: Anthony PERARD To: Peter Hoyes CC: , , , Wei Liu Subject: Re: [PATCH] tools/xendomains: Only save/restore/migrate if supported by xenlight Message-ID: References: <20230322135800.3869458-1-peter.hoyes@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230322135800.3869458-1-peter.hoyes@arm.com> On Wed, Mar 22, 2023 at 01:58:00PM +0000, Peter Hoyes wrote: > From: Peter Hoyes > > Saving, restoring and migrating domains are not currently supported on > arm and arm64 platforms, so xendomains prints the warning: > > An error occurred while saving domain: > command not implemented > > when attempting to run `xendomains stop`. It otherwise continues to shut > down the domains cleanly, with the unsupported steps skipped. The patch looks kind of ok, but shouldn't $XENDOMAINS_SAVE be set to an empty string in the config by the admin instead? Or is the issue that $XENDOMAINS_SAVE is set by default, even on arm* ? Maybe it's easier to check that the command is implemented at run time rather than trying to have a good default value for XENDOMAINS_SAVE at install/package time. > Use `xl help` to detect whether save/restore/migrate is supported by the > platform. If not, do not attempt to run the corresponding command. > > Signed-off-by: Peter Hoyes > --- > tools/hotplug/Linux/xendomains.in | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/tools/hotplug/Linux/xendomains.in b/tools/hotplug/Linux/xendomains.in > index 70f4129ef4..bafcb874e1 100644 > --- a/tools/hotplug/Linux/xendomains.in > +++ b/tools/hotplug/Linux/xendomains.in > @@ -229,6 +229,15 @@ parseln() > [ -n "$name" -a -n "$id" ] && return 0 || return 1 > } > > +subcmd_supported() > +{ > + local output > + output=$("$CMD help | grep "^ $1"") > + if [ ! "$output" ]; then > + return 1 > + fi It looks like some quote are in the wrong place. You probably wanted to write: output="$($CMD help | grep "^ $1")" But I'd like to have this slightly more robust, to match the whole command, rather than the beginning. (For example `subcmd_supported "pci"` would reture true even if no "pci" command exist.) Something like: $CMD help | grep "^ $1\( \|$\)" To check that the command name is followed by a space or end-of-line (even if it seems that there's always a space printed.) A similar pattern is used in "tools/xl/bash-completion", so it should probably be fine in the future. Then, we don't really need the "$output" from grep, we could just ask it if there's a match or not, with --quiet: $CMD help | grep -q "^ $1\( \|$\)" And that would be the whole function. Would that works for you? The rest of the patch looks fine. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:39:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518078.804240 (Exim 4.92) (envelope-from ) id 1pjjgj-00057Y-16; Tue, 04 Apr 2023 16:39:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518078.804240; Tue, 04 Apr 2023 16:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjgi-00057R-U4; Tue, 04 Apr 2023 16:39:16 +0000 Received: by outflank-mailman (input) for mailman id 518078; Tue, 04 Apr 2023 16:39:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjgh-00057L-Tn for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 16:39:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39fe83bc-d307-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:39:13 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 12:39:08 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DS7PR03MB5575.namprd03.prod.outlook.com (2603:10b6:5:2cd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.26; Tue, 4 Apr 2023 16:39:06 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Tue, 4 Apr 2023 16:39:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39fe83bc-d307-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680626353; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2VwF/6oP5Vnmo3WD3Q2qsw9zTr5lv4aZJIMcQTK7mI4=; b=B0J8c8OGyqgbNN2QaFK9dphCrDwk7IcEPvZ0wJThj8n4pCTipvLKyQ4g gad72IxUZzNpKWd64xfPfIb1vODqkShLJ4im3qF+z2X/JGKfrN9EsfTqQ QxyG3r0m+qaFBU90zSVasEecPURDbvo7oPcqFlP/Werzx69wezF/NFEKj Q=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 103095625 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MfBVxquAUHPrImC4G4Oovuo0dOfnVHBfMUV32f8akzHdYApBsoF/q tZmKW+GOfuCNGD3eYt+YY6z/EkBvMPXm99lQVQ+rilgHigR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGyyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOm00MTGMueKK45GYZ/Buo/wHNtb3FdZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiANlKReDmrKMCbFu7wzc1FDI9TUCBn8Kp1FWnR9lTM HwF9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRVLufgcBRAoBptPl8Ic6i0uWSs45SfDlyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:F5uwxa4OYAhfktoyKwPXwPrXdLJyesId70hD6qkRc202TiX8ra uTdZsguCMc9wxhIE3I9ertBED4ewK6yXct2/h2AV7AZniEhILLFuBfBOLZqlWLJ8SZzIFgPM xbE5SWZuefMbAP5vyKhDVRYb0bsby6GDbCv5am80tQ X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="103095625" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G1xyXshKzn3AsI5nin9LNHyjXA0cPNdeavPitItCBWSomeaH3/DoDbCTWHYsoo9mm2Yg2T0gIFNA4E3ph5E8tU1wBQm1+IS64spzlRulJKJ9SKAc3MNH69qO9KyKnakN+Wajs/hfxHG6UNvGgcnJurSETJnqOoVVVqt6tN4ED9SgdaO1lXJ8dAem/cfrXsQTB9Rfo6tbDRzh3nlxjiEiXXmw8RmqEHYedjwT65Tk0EeQp4BlWKvc0C7m12BdbXNIpT3WUXKfDJw6Ef0eS/rDCpCNMTgy4Fn1DLCfw190m4ixxUKB0JLUsVwEfopfZ2axb7y4/sVQpuaNoa/EnXW0qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvcsTwnXdBTocmvXSNfMLcZeG+qa8zME+K8EMsoSI54=; b=l7e9HwHQX4As9Vs/3989o2ktcL19LTV1yaXyy77VxtE4ZybBLhY1Un1eAQb8qDrnglkWqjYZbOAvSXrTrB4fKMkib4tfX8FSVzeYExAKHCMdLJVCkGpce463nEpLtfpH81vXjbFXa22z8JNpjbLE2UAEbvG93QvKqKkdEIdvALBu0yEGva+UincS6K31jG0qzrhUrcBDqbElbNo8Ku0yDxLLwV7jdT2t+cx5tNtZnT6beR50uWWvWyAZGdv9UlN2HvoLluIiNLQkra37SFKLXOvZzG6nJgnvrTlvxzO7aJMuGP3lEQ70kEAF67Cz+3loVOrylXf90hYfVo/DMwamOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XvcsTwnXdBTocmvXSNfMLcZeG+qa8zME+K8EMsoSI54=; b=CsKf6VHnyg4m3lMY1SpsdQhXEcgeYfnWrzl9f9jzAFx1hQ6v+4qnZDPvZASCgc2aTwPE+ruaFkbjB6I7yI+Z+vr3DlJI2hdbw3Rr7lvblQ3HxLuqmpAs8K6I13mbnovs28FpOk+xX6jLuW2YNf4B0ujWt8iqDwrvkFVFeNc7zio= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Apr 2023 18:38:58 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Message-ID: References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0001.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::13) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DS7PR03MB5575:EE_ X-MS-Office365-Filtering-Correlation-Id: 0675f27c-2a71-4a0c-b622-08db352b1adc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZDSkCjgLsp6KxiXQAwTEj08tBX4RF0YyhYbw/9cBAac5ZUzeOuqDuPdrUx2i3kPHU5Rizfrw/lOpXBsHylrYYsxL4xoEsfwc686EBT1Vw9oXIkFI9WYqZrp8mK3OugkoO748INZSZ+AifJsoQNEF9nWKbBYfPOeDgPwOy8LSROBMxaVCgidQZVNV7eSlQJ8AzAX4so/stoc8l0rn+9rz4qoUnYWx/qozs9AE2zG+sYJE16Pla/qPH8VK9b4XRLSuPmOBraC5504ywJK/R1HdAh5Y8sfRWLrqeZz4e6YRpJ5Ry4Cugjt3E1R5FFSDYnpJ5f3UxA3WOStBHpeK1QwQHH+xb8weSqGz2twxgjwbLq4lWGpgusEIU0n/givyzcVoEjjvfmV2mk1wP4jqZyBVF4P4FcAlqNjcEt6edKgeQPauq9/tQ7fBaud03gSPNJjN8rwRecvw0W0QXIiql+AA5wCwXalcmxXA7BMttzsYLtXrjDj8zg346dg0bzSOyK9p5xBa6W9gS5N7z+niUerFR/FoIopcnaKKR/UeElA2vaC80RDzcW8L3KjE10a+3g2hHVSD+QlqEV8QM5HSwCwf0vHx0CqRz5PydZZxLrZvOrc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(39860400002)(376002)(136003)(346002)(396003)(366004)(451199021)(86362001)(41300700001)(5660300002)(9686003)(186003)(6666004)(53546011)(26005)(6506007)(38100700002)(6512007)(6486002)(82960400001)(33716001)(66946007)(8936002)(4326008)(478600001)(54906003)(8676002)(66476007)(83380400001)(316002)(66556008)(6916009)(85182001)(66899021)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHFRdHBwUmdlbWFtWTlqenZHM0czNzJaZUd0Q1hkNWFhQlpuZzZ3WmVyV0tN?= =?utf-8?B?RW1YQ204TVF6MjNhMnQxdVRqYm04d3czTjBTb1o5NCtITG9QUVFkUWtqcUJa?= =?utf-8?B?ZVFWRmtvQ3ArcC9qalRUQWtsKzBSMnhrU3ZOVUp0cUMvcnA0R3I3TEJ1dEt5?= =?utf-8?B?VWZyKy9VeUcyUkNGYkZHUXU4OFVjaGZ3S3V4V05OYnA3OG5mWEVXMnMza0oy?= =?utf-8?B?Y3pJQlQrMDg0VFlxTWtEYVYxZzUzdEYzZXBtSFQvUmhzN3I0OEphUVFVSzNW?= =?utf-8?B?d0VGbllpRFBMN0xQRjRhbjdRclU4MGxMWVFiUzVyYUY0alZ2MEFWQ2lLRDVo?= =?utf-8?B?b0ZmRjV5ejZXK05QT1IvR0FWdjN2b1R4bVQzVG14ZlgzOG1GaXpZMUxYZ0ZX?= =?utf-8?B?Vkx3TG41NWFRVkVEWGtxMHNuUWF4ZDE5U1Z4OHl1VXFtbXcrSkUwQ0ZsK1Vj?= =?utf-8?B?Vm03VmNuV0ZPV3llOFJEOVN4RHhUTWpRZGgyT2xnbUsvcllXaVNLQWJxWVdU?= =?utf-8?B?RS9ZdklRdmpoYmpjR1VnNnVOR0NlMmh3MmtIV3R3czJKQzB2Y1pidmdYSUlG?= =?utf-8?B?eFFZa3FlVWNhcEgwYUV3RnNIZlFQMUFjajc3SzlIM1lDZ3BZU2xyaUwzS0Fl?= =?utf-8?B?WXlMS3NlQzRDM0lMRTZUNGhXSmc5dmp3Q0NoY2tzYjNRN1B4aFBPS3hxQWFZ?= =?utf-8?B?TWtUa1BsNUVwWFNrbkQ4bDZ0eGd3NE11SlhkNXk4Mnl0eG9TTFcxNldvcndN?= =?utf-8?B?YmJtbUg4blAyRm9ndTJvdWEzay9KTE92Qk9qZnhrVVo0NVJ1MUVIL0RTZ1E0?= =?utf-8?B?TlY3K002RGNuQkVJdTc5ay9vaVJacWRnMVJ0NDVVemJqRHdQNlRtRktyOFc1?= =?utf-8?B?Z04xeEN1TXA3cGkvWlg4Q2Vndkxwc0c2ODRaaVFZWVlvdUZEdVdzVlE4bXFw?= =?utf-8?B?QmEwQ3BNYnFDUkRsRDJtOHAwdWlVZ1QyOUFyeDZWbVlBc1BVT1Zaa2ZubjRj?= =?utf-8?B?RXpWSDZGSzRBQjZGNDM2SGVNOWdXazhhRXVZS24zWHQrbHZGVzNUK3E1dm5i?= =?utf-8?B?dUwzOUp3WUFLZmhjdXJGVytmZEJBZXZ0VC8rVnRPWDhvTDdoaTcwY3JBUGUz?= =?utf-8?B?dGJBZlcrcnpBMytUemNQb0EwU1RjcHdpWHNlRmkxTXhRNTFUaW9UWFdwYTZV?= =?utf-8?B?eFJwZVZabTdwWWlFN1IySVRNaVhabmpJejQ5SmduKzVJVi9Yd00wR2ZFMlNz?= =?utf-8?B?VjlYK25lNkcwZnUyWTluY3pCVkY3NGdkU01GVXRXYmkzT0ZPQldDV2pnZzVM?= =?utf-8?B?TTM2T29HMHZ3T240U3QwZHN0d1h0UUNKN1dmeE1nVlZTa1BDTXRTeFpaRHdC?= =?utf-8?B?c1dJNkpxbk1qamNwbkJ6QkxtMVlTK0QzeVhROWpaMy9TT1BTbi9NTHh1Rmxk?= =?utf-8?B?YXd6azhmZ3V5RElMY0JqK21VNm1PYUtKWlIrbTFkU1ozR1pHaU9oNVR1em1z?= =?utf-8?B?RG5IYjJXcUkzVVYxNjBic0orcnd3dCtpazM1dGlrSW9haDMzRXU5MzJGdWZy?= =?utf-8?B?ajJ6c3cyaW1vU1dmT2toR094K2xzaU1WTEwyU1hXYTlpMUQ5Mjc4T0tlQito?= =?utf-8?B?UU0xYmZsNHFFRzVDU0RUVUYwRmhGQy9KbGl0NFUzUWhEM2dDbk1lbVZvYVAw?= =?utf-8?B?anNtQnVsSXV0NHhpRk1kbHdESHEvN0R4bG1RTzAzYkUrTGs4YnE3WHZOMEJr?= =?utf-8?B?dTlDbXEyZ3ZubUhuQ1hqaEZndFZpNzBNaVFDZnZiYWZJckdPaDlZZTFUeHVF?= =?utf-8?B?MER6aUFhTyszejJ5SllUSVpTWlhUYjlMUCtkVzNMSDhEZnBjVnNEczV0UHdo?= =?utf-8?B?Zk9GOUE1UlVrVlNXVVgyZTdnNm5WZTZsbURLR28zcTNxTkc0Nm4ySkc4b3Bk?= =?utf-8?B?QStVOUJMa29kVlEyb3FuenhHclJ0bjBQa3dDQXZrV1dNNEgrbThkSHZURllt?= =?utf-8?B?WkxqMzBHaTVTNHUxY0d2RXEzSmVuNlZybG9NT2R6blVSZjczZmZaNVJ0L2hX?= =?utf-8?B?S3VnZFczejNCQUYvbGpSR2d6RnhkQVhQdkgwbVVKUnU3dE9rTUNOSitxVXJU?= =?utf-8?B?R1B1eXBXY0NKRHU1VmJ5VE5SdGxxMDRNMUNvK1czQjBpYVBrQ0hJK2t5SXFD?= =?utf-8?B?bUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: AAG3/3lI25PQSsvGZf/rleKCs2H+ojUcmHJ5gWMItwZIOV9LYoqMPXEHeOdsT2386g+7eNbe7fY37fywrzltsQYzAdEq2nXLULaykcuRXxZelPeGAFMTzGpRvcE/XVh+TXd33MvPfq/Em40TQDzr2pt5HkCDARrQtLTzAGv3GjDZJ+l693U1SOHofc0KOF6bQkDpLOOHIo+FbT0E13AikpcQl34KirRKPJ3tgqImdU4jnwd1bxTqP0j9vdkobiP2NNqkGLCz47UTGHwW6XbnseO6FSyoe4XEYmxVzCArlssoJ13FKNWmV4MBR+fFe3z/M2dqTSb/im+sIh0eM9Bh3wHGv4fUIBGhtFvVWICaCcOYDwRviW3opENkE3MURfNZoyeX4rmYipIo/G+Gww+A/HGUJrEv4fQJzKTHFnvbs69t4MW/7sbarWXaBETdeiFfdbQghp6DhUWt53kwY4uFbt8gf+7FvzNGT0G00yOExQaon/+NWvZ372DcPto5ymYv5YEC82pujjWmbBDQrHNGgf+EdF3NuE7kbUZ7aobx4P5P0rqw8OyneLqKIhSnvJV8AMHhrzW7LADpL7l+drWAs5Wbxxtk4TCEPw3XXWmjUhvX6icLnbbUBankeHv4ZTBZJrNgFxVIi5aDsMvOsHbwpTS1iqxFbIJ4F7SXuO6rMlwlNsCgxV0Jwf6/VyWDNChM6OVgkbFuDx58SHGexwnSnpPYnG42B8MJvdPgwQuDG4zWekJ6S6jCiepl0E2J3+u45ci2q326d5iCApeOMqHy/LItbXb1zdqbls12BSwsaFswqGOCKbaSLizDktbNUdwP X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0675f27c-2a71-4a0c-b622-08db352b1adc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 16:39:05.5814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8GaC8WohKXghUOV/L+fW+g86GpluO/f+jHS26OpCPYDrZYdb9HdzBOIN73SneRZSeKmAlmYaBE2CbAU7mOZOxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5575 On Tue, Apr 04, 2023 at 05:57:11PM +0200, Roger Pau Monné wrote: > On Tue, Apr 04, 2023 at 04:24:16PM +0200, Jan Beulich wrote: > > On 04.04.2023 13:41, Roger Pau Monné wrote: > > > On Tue, Apr 04, 2023 at 12:31:31PM +0200, Jan Beulich wrote: > > >> On 04.04.2023 12:12, Roger Pau Monné wrote: > > >>> On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: > > >>>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still > > >>>> applies to guests also when run on a 64-bit hypervisor: The "extended > > >>>> CR3" format has to be used there as well, to fit the address in the only > > >>>> 32-bit wide register there. As a result it was a mistake that the check > > >>>> was never enabled for that case, and was then mistakenly deleted in the > > >>>> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume > > >>>> CONFIG_PAGING_LEVELS==4"]). > > >>>> > > >>>> Similarly during Dom0 construction kernel awareness needs to be taken > > >>>> into account, and respective code was again mistakenly never enabled for > > >>>> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by > > >>>> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). > > >>>> > > >>>> At the same time restrict enabling of the assist for Dom0 to just the > > >>>> 32-bit case. Furthermore there's no need for an atomic update there. > > >>>> > > >>>> Signed-off-by: Jan Beulich > > >>>> --- > > >>>> I was uncertain whether to add a check to the CR3 guest read path, > > >>>> raising e.g. #GP(0) when the value read wouldn't fit but also may not > > >>>> be converted to "extended" format (overflow is possible there in > > >>>> principle because of the control tools "slack" in promote_l3_table()). > > >>>> > > >>>> In that context I was puzzled to find no check on the CR3 guest write > > >>>> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any > > >>>> of the low reserved ones) could observe anomalous behavior rather than > > >>>> plain failure. > > >>>> > > >>>> As to a Fixes: tag - it's pretty unclear which of the many original > > >>>> 32-on-64 changes to blame. I don't think the two cited commits should > > >>>> be referenced there, as they didn't break anything that wasn't already > > >>>> broken. > > >>>> > > >>>> --- a/xen/arch/x86/mm.c > > >>>> +++ b/xen/arch/x86/mm.c > > >>>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ > > >>>> unsigned int partial_flags = page->partial_flags; > > >>>> l3_pgentry_t l3e = l3e_empty(); > > >>>> > > >>>> + /* > > >>>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not > > >>>> + * understand the weird 'extended cr3' format for dealing with high-order > > >>>> + * address bits. We cut some slack for control tools (before vcpu0 is > > >>>> + * initialised). > > >>> > > >>> Don't we then need some check in the vCPU init path to assure that the > > >>> cr3 is < 32bits if we allow those to initially be set? > > >>> > > >>> Or will the initialization unconditionally overwrite any previous cr3 > > >>> value? > > >> > > >> That's not the way I understand this "cut some slack". Instead I read it > > >> to be meant to cover for the VM-assist bit not being set, yet. Beyond > > >> that it is assumed to be tool stack's responsibility to constrain > > >> addresses suitably. If it doesn't, it'll simply break the guest. (There > > >> is some guessing on my part involved here, as the original introduction > > >> of that code didn't further explain things.) > > > > > > If it's just the guest that's broken I would think it's fine. As long > > > as such mismatch doesn't cause issues in the hypervisor internal state. > > > > > > Did you see a toolstack setting such entries before pae_extended_cr3 > > > is set? > > > > To be honest - I didn't look. As said in the longer reply to Andrew, I > > think it is more logical this way (the page table root already being > > validated as an L3 table when vCPU 0 is inititalized, which includes > > setting its CR3). Hence even if right now the order was the other way > > around (which I doubt it is), I wouldn't want to make impossible to > > restore the original ordering again. > > IMO I think it would be better if we could already report error at > domain creation time if the toolstack is attempting to create a domain > that the hypervisor knows is not going to work properly, rather than > allowing it and the guest failing in maybe non obvious ways. > > It seems to me however that we would need to fix xc_dom_boot_image() > in order to setup the vCPU before creating the initial page-tables. > (->setup_pgtables() hook being called before ->vcpu() hook) > > So I don't think this is strictly worse than what we have, but it > would also be nice to get things sorted out so the ability of the > toolstack to shot its own foot is limited. Maybe I'm confused after all day, but isn't the hypercall used by the toolstack to set CR3 the same one used to set the vm_assist bits? (XEN_DOMCTL_setvcpucontext) At which point we just need to make sure d->vm_assist gets set before attempting to load the new CR3 (seems that way from the quick look I've given at arch_set_info_guest()). And so there should be no need to give extra slack to toolstack operations. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 04 16:51:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 16:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518083.804251 (Exim 4.92) (envelope-from ) id 1pjjsi-0007Tj-5C; Tue, 04 Apr 2023 16:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518083.804251; Tue, 04 Apr 2023 16:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjsi-0007Tc-0N; Tue, 04 Apr 2023 16:51:40 +0000 Received: by outflank-mailman (input) for mailman id 518083; Tue, 04 Apr 2023 16:51:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjsg-0007TW-Pv for xen-devel@lists.xen.org; Tue, 04 Apr 2023 16:51:38 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f5ef77c0-d308-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 18:51:36 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id j1-20020a05600c1c0100b003f04da00d07so992074wms.1 for ; Tue, 04 Apr 2023 09:51:35 -0700 (PDT) Received: from [192.168.0.106] ([91.123.150.38]) by smtp.gmail.com with ESMTPSA id e5-20020a05600c218500b003ed243222adsm15616711wme.42.2023.04.04.09.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 09:51:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5ef77c0-d308-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680627095; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nmwA5QIE12SS7JgIVsKKCsxGeOjasYgBEbSu07ZYTSU=; b=j3X7CQ1RSjFMeq3h/sDNd516v3GtX5TcOf28kc7cih/YdK3d1j1bIgD6r8dQyy+CTV xS7FxlaA2mI9xXehp9sLxN2YiEzkisHp8N5GqnVLZGgOJbRKbcqftf4G50nEtCDPxUqy s82n2D6C8ucroeun906j3Hn/5n+h85GFAX88qGxpEMlAzDZVzcEF/p3iLVLTlqHlv+Kt eYyAj3fluApLMwniSQ6PXyLsuow0ouar1hI10a2VpDrbaI2MoPA37FhXvJkNLJpqBVRw G5dde3U+AI/b6zw4vpME7WRGv2wG9HW/fQu1IPEPHfph5u0XjDYFYkNkKmltMFO/UlCl 0GCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680627095; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nmwA5QIE12SS7JgIVsKKCsxGeOjasYgBEbSu07ZYTSU=; b=Tcyvfu7cgAZzDpwl3v5r55wBKyD3SrXwk801YUGzylqlGESoaMrXEZkrj2+Cyb6lY0 UQnp6xGi5dwBNIMPiFeJgOM51iY4aFw6hXC7ZtxANQcPkfU8HAUdQlqQKtf3s2ukUbeQ bHiUvvUCsoFiYsDgLkhT0LierbcNSNjREsq6aB3+6ppwT2i4LuGeIWJBbUjEOec+FVQL jWJ2vpl6BH4krmof4SIb9kVVQyrTfH2eqZ/I1Lkp53kDOYx5Z2A1QtxmkIQqlRZ2sZJ3 h6AAz4xXbd/3pFeb5A78Nro9EdN41pVCpbzR+pCLMo0n2Q0r30DaRQhOidX/z2G+163x 3fRw== X-Gm-Message-State: AAQBX9e/uI3BSS7qgeWcgdPSH0YwkcDYU41w1I6k463yQDwTyyw+pGoR RyS0VAUyH7VouxpPNZK52Ro= X-Google-Smtp-Source: AKy350ZPTHLXZZtEJJV/KLDfQHEAcggBiApR/vQ6qZwddyf+FZnWqHowVpVwxPjRx3L0JA7kCZ0Q4w== X-Received: by 2002:a05:600c:254:b0:3ee:2552:7512 with SMTP id 20-20020a05600c025400b003ee25527512mr2628533wmj.13.1680627095070; Tue, 04 Apr 2023 09:51:35 -0700 (PDT) Message-ID: <44ec8244-d172-8f21-d7c1-a070ff0a5cb5@gmail.com> Date: Tue, 4 Apr 2023 19:51:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] libxl: fix matching of generic virtio device Content-Language: en-US To: Viresh Kumar Cc: Vincent Guittot , Julien Grall , xen-devel@lists.xen.org, Juergen Gross , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Erik Schilling , Anthony PERARD References: <210b5be4b7e84fce1519663f28ca24f6761fb2cb.1680161663.git.viresh.kumar@linaro.org> From: Oleksandr Tyshchenko In-Reply-To: <210b5be4b7e84fce1519663f28ca24f6761fb2cb.1680161663.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.03.23 10:35, Viresh Kumar wrote: Hello Viresh > The strings won't be an exact match, and we are only looking to match > the prefix here, i.e. "virtio,device". This is already done properly in > libxl_virtio.c file, lets do the same here too. > > Signed-off-by: Viresh Kumar It feels to me this patch wants to gain the following tag: Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") > --- > tools/libs/light/libxl_arm.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index ddc7b2a15975..97c80d7ed0fa 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -1033,10 +1033,14 @@ static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, > } else if (!strcmp(type, VIRTIO_DEVICE_TYPE_GPIO)) { > res = make_virtio_mmio_node_gpio(gc, fdt); > if (res) return res; > - } else if (strcmp(type, VIRTIO_DEVICE_TYPE_GENERIC)) { > - /* Doesn't match generic virtio device */ > - LOG(ERROR, "Invalid type for virtio device: %s", type); > - return -EINVAL; > + } else { > + int len = sizeof(VIRTIO_DEVICE_TYPE_GENERIC) - 1; > + > + if (strncmp(type, VIRTIO_DEVICE_TYPE_GENERIC, len)) { > + /* Doesn't match generic virtio device */ > + LOG(ERROR, "Invalid type for virtio device: %s", type); > + return -EINVAL; > + } I agree that now code is aligned with what we have in libxl_virtio.c file, but I am afraid I cannot connect the sentence from the commit description: "The strings won't be an exact match, and we are only looking to match the prefix here, i.e. "virtio,device"." with the sentence from docs/man/xl.cfg.5.pod.in: "For generic virtio devices, where we don't need to set special or compatible properties in the Device Tree, the type field must be set to "virtio,device"." I might miss something, but shouldn't we clarify the documentation? > } > > return fdt_end_node(fdt); From xen-devel-bounces@lists.xenproject.org Tue Apr 04 17:21:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 17:21:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518087.804260 (Exim 4.92) (envelope-from ) id 1pjkLF-0002R0-Dz; Tue, 04 Apr 2023 17:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518087.804260; Tue, 04 Apr 2023 17:21:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkLF-0002Qt-AA; Tue, 04 Apr 2023 17:21:09 +0000 Received: by outflank-mailman (input) for mailman id 518087; Tue, 04 Apr 2023 17:21:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkLE-0002Qj-6c; Tue, 04 Apr 2023 17:21:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkLE-0001YS-10; Tue, 04 Apr 2023 17:21:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkLD-0005UC-HA; Tue, 04 Apr 2023 17:21:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjkLD-0002Pi-Gf; Tue, 04 Apr 2023 17:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VidBrDSsszNUGskm2BZWHSEq+ojhFlf1TW60WYaUgyk=; b=slHygYNrUlkk7ZjNVvZD8kHIKU wv9sgvVwbzRYAQz3nVpSHpdJkrju+uGveQN9yoPCn07nP8VvkF+iyd3OGMBkON/s7ca8+6FifOi5e tALlzh8zA9f0BQfRhLcN/ZzpKyLT72zQyoF+r3cZ82EQvtnzV4MjeflY2ahjbfM7gkWo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180138: all pass - PUSHED X-Osstest-Versions-This: ovmf=fb89f62d2702faf7db7f7afef342467d4f0fba3c X-Osstest-Versions-That: ovmf=26997800c991f934b57ebd91de2edcd93312f756 From: osstest service owner Date: Tue, 04 Apr 2023 17:21:07 +0000 flight 180138 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180138/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fb89f62d2702faf7db7f7afef342467d4f0fba3c baseline version: ovmf 26997800c991f934b57ebd91de2edcd93312f756 Last test of basis 180127 2023-04-03 15:40:46 Z 1 days Testing same since 180138 2023-04-04 15:10:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 26997800c9..fb89f62d27 fb89f62d2702faf7db7f7afef342467d4f0fba3c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Apr 04 17:36:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 17:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518093.804270 (Exim 4.92) (envelope-from ) id 1pjkZd-000418-LE; Tue, 04 Apr 2023 17:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518093.804270; Tue, 04 Apr 2023 17:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkZd-000411-IR; Tue, 04 Apr 2023 17:36:01 +0000 Received: by outflank-mailman (input) for mailman id 518093; Tue, 04 Apr 2023 17:35:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkZb-00040c-Ia for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 17:35:59 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2391ff87-d30f-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 19:35:49 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id eg48so133624781edb.13 for ; Tue, 04 Apr 2023 10:35:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2391ff87-d30f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680629749; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B++ILPDB3X+VuBU8jlV4qBmXikQNjKUxckqbnWCshEs=; b=nEMEpYDPKqf3YLC0FS2dnk3CaMTs5JeR/WJE92Vclc3fGNqm3Q4jcJ1saTecAW50kK SkZAAQedIQyx1QshTDj2dqfqdrj3L3TA98J03DxnWXM6lx5vIF1Y2qtzGFQYUnwou0NI 0RdoLDwN3COEIJxX6HOFtQ68IcXGl00Q/Cro7ywaKLa/H7gl07KR0KPsmFRtsgxmVdPQ T++ulO6Hu1d7QX+FbmmPNluD3/GfPKnxXHpahwlm/bJjy3Lw/5Ek1C2Q4ArXC/Xs0TwO 5CJyUvZoK5f8yImPnWACOMke+eMrjrzi/9c6YdRo3viKtljNnygfDHcE96qEVB9WWz+H RAPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680629749; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B++ILPDB3X+VuBU8jlV4qBmXikQNjKUxckqbnWCshEs=; b=AFT/M0Nw/UsOxWECXxMxd8uhjZ9DnVBrOD/nFh0igUX567IGw7new+d4TQsufbavEa pmVXIht3Bi4kGL/VWu01A4rRO/qlWQxbc54FaGVeqvhxZPTiOK0E6F3mIULWJkw9cTic O7LfzWxckbwJ1LbdWmlIeJMiWwNdFhYXSkQYk/9UztBdGc89mCmW6BN7BaAOwYKgBYD3 QWz7ABzKStfTGy7eQaTaaPsyag4FFqQLWSQavvkcLJcwZvPvW6Ute0hEDxzXiL/0Uvsq dAedwIWEspZ7vp0Za1ygv9cEWTC68TvnVqtTeadCwbQXGwLJyqYCs470F0Bx5+4jxk6p 5hYQ== X-Gm-Message-State: AAQBX9etrsUW5ctkTP92hVHnAffy1Z5i9upsdayUpNcaNWR/mJkzsYWj wcVHgU2kwf4pt62HBNGRvQJR4/pnaE94lLdqaKFDvA== X-Google-Smtp-Source: AKy350bFZ5U/HvpJohqoyPJEv2MbHDufBnPeztQmU14vuRQWrqhanpo8MykXvxhbF2/kYUPL7BROh16KxkmoJmjzqmw= X-Received: by 2002:a17:906:9bde:b0:924:efbb:8a8b with SMTP id de30-20020a1709069bde00b00924efbb8a8bmr173409ejc.6.1680629748942; Tue, 04 Apr 2023 10:35:48 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-14-dwmw2@infradead.org> In-Reply-To: <20230307182707.2298618-14-dwmw2@infradead.org> From: Peter Maydell Date: Tue, 4 Apr 2023 18:35:38 +0100 Message-ID: Subject: Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: Paul Durrant > > Signed-off-by: Paul Durrant > Signed-off-by: David Woodhouse > Reviewed-by: Paul Durrant > --- Hi; Coverity points out a memory leak in this code (CID 1508098): > +static struct qemu_xs_handle *libxenstore_open(void) > +{ > + struct xs_handle *xsh = xs_open(0); > + struct qemu_xs_handle *h = g_new0(struct qemu_xs_handle, 1); Here we allocate memory... > + > + if (!xsh) { > + return NULL; ...but here we can return without freeing it... > + } > + > + h = g_new0(struct qemu_xs_handle, 1); ...and here we allocate a second time and overwrite the pointer to the first allocation. Deleting the first call to g_new0() would fix both of these. > + h->xsh = xsh; > + > + notifier_list_init(&h->notifiers); > + qemu_set_fd_handler(xs_fileno(h->xsh), watch_event, NULL, h); > + > + return h; > +} thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Apr 04 17:45:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 17:45:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518098.804280 (Exim 4.92) (envelope-from ) id 1pjkid-0005Yq-MI; Tue, 04 Apr 2023 17:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518098.804280; Tue, 04 Apr 2023 17:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkid-0005Yj-IW; Tue, 04 Apr 2023 17:45:19 +0000 Received: by outflank-mailman (input) for mailman id 518098; Tue, 04 Apr 2023 17:45:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkib-0005YX-Qt for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 17:45:18 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75862dc2-d310-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 19:45:16 +0200 (CEST) Received: from [2001:8b0:10b:5:99d7:d5a0:55b7:41c3] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pjkiS-00FZi4-QD; Tue, 04 Apr 2023 17:45:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75862dc2-d310-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g8SnSDCU1FbwVqsBDwgLKPNWtPpuDwLN/0oRMertQBw=; b=h/snio6bG0Vu7iuAlLVf8ry4b+ wuNF+uHu0wBcluW7ML+QR5KwB29+bVr49ZFQCCh72LjZOhFw5NnL1snhHVvec4OLHOJ6ft8eUrx8a Cs8rC8H+BkIT65DXYCK/NZVAvDTTJsasSXv54KemN1IqALr2sTy2QAn6gJy+o7XOvUJPYtqAPrxX8 4DeFjZ4yXEcFsZ2EeLgbXAKNt62l6C0kp67Dt7p/+WRyiatMRmM2ToOfyhpODf1KNoIUfLj5PDsWN 4W63StUsJUZnZqg8ociRHA7R1znRtZwU+xl7JVtX+xImPrlRLaJ7pafY2mP7EfhOTJt5BZUc2YdCK pAyE54uw==; Message-ID: Subject: Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation From: David Woodhouse To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Date: Tue, 04 Apr 2023 18:45:07 +0100 In-Reply-To: References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-14-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-trzKSnN3SH5xbBzkYnH5" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-trzKSnN3SH5xbBzkYnH5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote: > On Tue, 7 Mar 2023 at 18:27, David Woodhouse > wrote: > >=20 > > From: Paul Durrant > >=20 > > Signed-off-by: Paul Durrant > > Signed-off-by: David Woodhouse > > Reviewed-by: Paul Durrant > > --- >=20 > Hi; Coverity points out a memory leak in this code (CID 1508098): >=20 > > +static struct qemu_xs_handle *libxenstore_open(void) > > +{ > > +=C2=A0=C2=A0=C2=A0 struct xs_handle *xsh =3D xs_open(0); > > +=C2=A0=C2=A0=C2=A0 struct qemu_xs_handle *h =3D g_new0(struct qemu_xs_= handle, 1); >=20 > Here we allocate memory... >=20 > > + > > +=C2=A0=C2=A0=C2=A0 if (!xsh) { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return NULL; >=20 > ...but here we can return without freeing it... >=20 > > +=C2=A0=C2=A0=C2=A0 } > > + > > +=C2=A0=C2=A0=C2=A0 h =3D g_new0(struct qemu_xs_handle, 1); >=20 > ...and here we allocate a second time and overwrite the > pointer to the first allocation. >=20 > Deleting the first call to g_new0() would fix both of these. Indeed, thanks. Do you want a=20 Reviewed-by: David Woodhouse or would you prefer me to submit the actual patch as described? --=-trzKSnN3SH5xbBzkYnH5 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDA0MTc0NTA3WjAvBgkqhkiG9w0BCQQxIgQgpJ6J7s3H 3UAHtBoEPna0uaV12yxgcl1DDtVgYwJt6Wowgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgB3HWBPzyvUlUFU8nI8xVYFzlf9Nx/nbPvU kqKMCcfTELJAut4NQ9mlezYs4JBQsRh5b9/sQ017dBAq8Ok1epto8UBoT5sFYBF+1UMtLCWQCHMA qX+JElG8VoKWaDSUU2V7bSpvnCbMHx2ViNZieqnkfK+5OpZegXjZ7FytorfPd2EMC0gw+wkiOPIQ PJ7n08r7P+AEzRYMO2IF07X2/2h+ioOfMG+uOZY7vJQWjLCrpW6Fx4X6aUQha8l089RtqBcna+gA xYrQJs3K7DHdBg6rACS1Ahwi9rPH01v9iZpqCOB5UZqXZOcMM8m3d0KekBeru8BFVZlZdG9Wd5LZ Pf22aDYlS2sKPUtds49hsynRxAITZhlFws//l3WWLWbgl9Vl+1yjH0fOETiY616vgpn4v09alfDt fpPXqYhSalAaRay4lgdCb7cs8aoL2f5eFdoJojvGZdYFGDsLOwhCXADeyoHdRjX3GCveFFNhuTRX NMuuQoEgECceOPihHoQxc1Zx0iYXPP+NnmMyWK8/Mg276mM+IFXwrOcTKmy0hcRM6+EY6QaSfl1H 7c033dLIQiPIWLIrgnQThDckTasgTmzHZMK4chcKJhDp0Jr6KtZ+CGusS6/MZjTTuJ3z+q1+Uxp8 K6XFWZH/3UO4mZyVskTvfKavOfDXUYa/KgDy4G/QgwAAAAAAAA== --=-trzKSnN3SH5xbBzkYnH5-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 17:46:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 17:46:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518102.804289 (Exim 4.92) (envelope-from ) id 1pjkjB-00060t-UN; Tue, 04 Apr 2023 17:45:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518102.804289; Tue, 04 Apr 2023 17:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkjB-00060m-Rj; Tue, 04 Apr 2023 17:45:53 +0000 Received: by outflank-mailman (input) for mailman id 518102; Tue, 04 Apr 2023 17:45:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjkjA-00060Z-Qx for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 17:45:52 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8abb3184-d310-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 19:45:52 +0200 (CEST) Received: by mail-ed1-x531.google.com with SMTP id ew6so133753336edb.7 for ; Tue, 04 Apr 2023 10:45:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8abb3184-d310-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680630351; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zM6C51SzsToixyfPpduAVipa4SnNg5IMo4YirkkilTI=; b=m79o95DJlnvNJ4KH0Md0JB/qcLndytfefpLDAV0P5BOEkg/Vua/5v5yhxJiEAvb7w5 zX4nTiEhJCuiD5E98BTa7eiGfw2OqM2TpwCvm1TcLI6Hk2miGK5+V4kheAWEibmMUm3R txiTr0hc/XRHsz4NUYkN/ovZ+XzpI7r9BRvI0kulU38aQadsOpX6GPzfUPpyJlXcZabB 84rq8WrNEjrkLZ0VGXADyKLyZT0AVrpSg1AHZWPisb5dFOkkIAV3isD22l9nLcJ0JZJA mp4WPZrOD0ZIlWi0yX0/5QNNpEwJEB7WKHjVk6zXuk9UI4SAqf9oZJg3HYcHG/MKsiKz j7Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680630351; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zM6C51SzsToixyfPpduAVipa4SnNg5IMo4YirkkilTI=; b=vTlh7o9YqVL4pn9P4Jf9rDIZvvJFx5sn/95zoBemeVsjY0M8VFzS0BIG2nykF8pXjH /smTRZ18TWRHAPNY5Ncp7UDQ1B8jl/QswepLMHF7Ah9+d5+3xknJQsyPNwBmaK0ZSB/u cgUwkctZFXHb8FoafH1QeEGPYTeYtzjsAVcZvibiTKbjnFfcmQSsAA3+BkTRyyw677+7 FqekhSqi1Dgcv9CsQkehob+J2XeK/FubeYTTjwW7+8Y7kxrotajqZwN55mhwuu+SimAd m6462gsp+gX2gg1F9oj/0DPQaBHumoWvRGKY/NPFIVV7yw7GtNbHIyj5TVWPstjqiE0U dRpA== X-Gm-Message-State: AAQBX9fjR0CIBh2He4Cmey5xaK06dFlw3ZhkHsTPf90lJf5sjxyFBxQE g4lUvAFpPgU6x/nXxGNnRolKdiLf30oc8zTxy7h6XQ== X-Google-Smtp-Source: AKy350aUoDCSACn1ctQt94298XZZELptJd4vlQvIrHKhZ59SL3gN/lMGnaDhhMIf4vhQdc2A1ymiyiiUf29jIj2J2NY= X-Received: by 2002:a17:907:118d:b0:932:4577:6705 with SMTP id uz13-20020a170907118d00b0093245776705mr203873ejb.6.1680630351647; Tue, 04 Apr 2023 10:45:51 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-14-dwmw2@infradead.org> In-Reply-To: From: Peter Maydell Date: Tue, 4 Apr 2023 18:45:41 +0100 Message-ID: Subject: Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Tue, 4 Apr 2023 at 18:45, David Woodhouse wrote: > > On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote: > > On Tue, 7 Mar 2023 at 18:27, David Woodhouse > > wrote: > > > > > > From: Paul Durrant > > > > > > Signed-off-by: Paul Durrant > > > Signed-off-by: David Woodhouse > > > Reviewed-by: Paul Durrant > > > --- > > > > Hi; Coverity points out a memory leak in this code (CID 1508098): > > > > > +static struct qemu_xs_handle *libxenstore_open(void) > > > +{ > > > + struct xs_handle *xsh = xs_open(0); > > > + struct qemu_xs_handle *h = g_new0(struct qemu_xs_handle, 1); > > > > Here we allocate memory... > > > > > + > > > + if (!xsh) { > > > + return NULL; > > > > ...but here we can return without freeing it... > > > > > + } > > > + > > > + h = g_new0(struct qemu_xs_handle, 1); > > > > ...and here we allocate a second time and overwrite the > > pointer to the first allocation. > > > > Deleting the first call to g_new0() would fix both of these. > > Indeed, thanks. Do you want a > > Reviewed-by: David Woodhouse > > or would you prefer me to submit the actual patch as described? If you could submit the patch that would be easiest -- you're in a better position to test it. thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Apr 04 18:16:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 18:16:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518107.804300 (Exim 4.92) (envelope-from ) id 1pjlCe-0001BC-6W; Tue, 04 Apr 2023 18:16:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518107.804300; Tue, 04 Apr 2023 18:16:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlCe-0001B5-3Y; Tue, 04 Apr 2023 18:16:20 +0000 Received: by outflank-mailman (input) for mailman id 518107; Tue, 04 Apr 2023 18:16:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlCc-0001Az-Hg for xen-devel@lists.xen.org; Tue, 04 Apr 2023 18:16:18 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca1fe744-d314-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 20:16:17 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id v20-20020a05600c471400b003ed8826253aso1247661wmo.0 for ; Tue, 04 Apr 2023 11:16:16 -0700 (PDT) Received: from [192.168.0.106] ([91.123.150.38]) by smtp.gmail.com with ESMTPSA id a14-20020a05600c224e00b003ef5f77901dsm15728970wmm.45.2023.04.04.11.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 11:16:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca1fe744-d314-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680632176; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BCirR0DIa/QvXBN4OfZB+iKk1mo5LyWqNWEty91n8xk=; b=AtiqUKvX4AsMbxrDCCur/zsKdRRuNzxsmivIphJuZbGWHLchRBrx3Bu4Y4pL5NNuu9 gG6iZU31EeFyCtKIbboiP4hpV+3JSbb27lTu6SwnAbGghTjdYSOQF7jOCCOIlt0gGTeD cTJnVwEFjieRi6H5T2uuNorqzdPtikxwMAMRXRMjEo6YDSodpV+Da/BY4hq/1Vw9nXe2 9EHOrmLX0skiNRcFnWM2ss0FWcAo6YYaDG9Qm1LneIjjY7E6iyeafJn4KIvcBlBPIcIn p66Aaq8eGNhCFwmPwJ/FslvOgQt+xNZKNgoFpD3HuDs4JG5IRvoArFfxYMwL4TgZFqKS EaAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680632176; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BCirR0DIa/QvXBN4OfZB+iKk1mo5LyWqNWEty91n8xk=; b=nPO27ig5JVXN1XEbk5nrz4Wr5ovUfkHcmSTTI9r0mc1yk9xxNpwgQqAts8ttCOXQ1Z Kl7YvqxlhqWtGeHFDdCRTK/0+6PZKWCRm8IJCxOOV4Sng4hGxTTcofbZxIP0zffG1Biw vuKuRL2YvaYVux4+mbx5/eLxtIn4APdY2qpW0YPmc/zvpOrKtfMlZV87PRg5kfNf4haH TaH8fSniYujLfl/0+3Cdvjz9BlQ5dAXrJG/c3ZMl/FSTHl3q2ceVMNbSdIIib3lW2nhM beF9mM29Hyd3zfoNSi+CsT3ThWGGRMTfb1cRte2Qm6JUQ/lW438NNR31183d8DVgNPqU B4UA== X-Gm-Message-State: AAQBX9e+UnCY1EqIdAUmqdKDIwURBE3euTT9j1Zm0ip99QYwGgXvhb6w Ynl7BKnQNHgDbuZpeQzEqEg= X-Google-Smtp-Source: AKy350YOF8FfjzS9Aayo5g4ZcE9hqYtbwccdFVeyWjdirZtdMoLh46cHTvoZGnOtElOFokm2PtkFKw== X-Received: by 2002:a05:600c:acb:b0:3dc:55d9:ec8 with SMTP id c11-20020a05600c0acb00b003dc55d90ec8mr2596346wmr.41.1680632175538; Tue, 04 Apr 2023 11:16:15 -0700 (PDT) Message-ID: <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> Date: Tue, 4 Apr 2023 21:16:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Content-Language: en-US To: Viresh Kumar Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Juergen Gross , Julien Grall , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Anthony PERARD , Mathieu Poirier , Erik Schilling References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> From: Oleksandr Tyshchenko In-Reply-To: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.03.23 11:43, Viresh Kumar wrote: Hello Viresh > Currently, we add grant mapping related device tree properties if the > backend domain is not Dom0. While Dom0 is privileged and can do foreign > mapping for the entire guest memory, it is still okay for Dom0 to access > guest's memory via grant mappings and hence map only what is required. ok, probably makes sense > > This commit adds another parameter for virtio devices, with which they > can do forced grant mappings irrespective of the backend domain id. > > Signed-off-by: Viresh Kumar In general patch lgtm, just a few comments below > --- > docs/man/xl.cfg.5.pod.in | 4 ++++ > tools/libs/light/libxl_arm.c | 21 ++++++++++++--------- > tools/libs/light/libxl_types.idl | 1 + > tools/libs/light/libxl_virtio.c | 11 +++++++++++ > tools/xl/xl_parse.c | 2 ++ > 5 files changed, 30 insertions(+), 9 deletions(-) > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index 10f37990be57..4879f136aab8 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1616,6 +1616,10 @@ properties in the Device Tree, the type field must be set to "virtio,device". > Specifies the transport mechanism for the Virtio device, only "mmio" is > supported for now. > > +=item B > + > +Allows Xen Grant memory mapping to be done from Dom0. Asumming it is disabled by default, I would add the following: The default is (0) false. > + > =falback > > =item B > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 97c80d7ed0fa..ec2f1844e9b3 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -922,7 +922,8 @@ static int make_xen_iommu_node(libxl__gc *gc, void *fdt) > > /* The caller is responsible to complete / close the fdt node */ > static int make_virtio_mmio_node_common(libxl__gc *gc, void *fdt, uint64_t base, > - uint32_t irq, uint32_t backend_domid) > + uint32_t irq, uint32_t backend_domid, > + bool forced_grant) > { > int res; > gic_interrupt intr; > @@ -945,7 +946,7 @@ static int make_virtio_mmio_node_common(libxl__gc *gc, void *fdt, uint64_t base, > res = fdt_property(fdt, "dma-coherent", NULL, 0); > if (res) return res; > > - if (backend_domid != LIBXL_TOOLSTACK_DOMID) { > + if (forced_grant || backend_domid != LIBXL_TOOLSTACK_DOMID) { > uint32_t iommus_prop[2]; > > iommus_prop[0] = cpu_to_fdt32(GUEST_PHANDLE_IOMMU); > @@ -959,11 +960,12 @@ static int make_virtio_mmio_node_common(libxl__gc *gc, void *fdt, uint64_t base, > } > > static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, uint64_t base, > - uint32_t irq, uint32_t backend_domid) > + uint32_t irq, uint32_t backend_domid, > + bool forced_grant) > { > int res; > > - res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); > + res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid, forced_grant); > if (res) return res; > > return fdt_end_node(fdt); > @@ -1019,11 +1021,11 @@ static int make_virtio_mmio_node_gpio(libxl__gc *gc, void *fdt) > > static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, > uint32_t irq, const char *type, > - uint32_t backend_domid) > + uint32_t backend_domid, bool forced_grant) > { > int res; > > - res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); > + res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid, forced_grant); > if (res) return res; > > /* Add device specific nodes */ > @@ -1363,7 +1365,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > iommu_needed = true; > > FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, > - disk->backend_domid) ); > + disk->backend_domid, false) ); > } > } > > @@ -1373,12 +1375,13 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > if (virtio->transport != LIBXL_VIRTIO_TRANSPORT_MMIO) > continue; > > - if (virtio->backend_domid != LIBXL_TOOLSTACK_DOMID) > + if (virtio->forced_grant || virtio->backend_domid != LIBXL_TOOLSTACK_DOMID) > iommu_needed = true; > > FDT( make_virtio_mmio_node_device(gc, fdt, virtio->base, > virtio->irq, virtio->type, > - virtio->backend_domid) ); > + virtio->backend_domid, > + virtio->forced_grant) ); > } > > /* > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index c10292e0d7e3..cfbcd717dc7f 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -740,6 +740,7 @@ libxl_device_virtio = Struct("device_virtio", [ > ("backend_domname", string), > ("type", string), > ("transport", libxl_virtio_transport), > + ("forced_grant", bool), If I remember correctly when making any updates here we also need to regenerate golang bindings. > ("devid", libxl_devid), > # Note that virtio-mmio parameters (irq and base) are for internal > # use by libxl and can't be modified. > diff --git a/tools/libs/light/libxl_virtio.c b/tools/libs/light/libxl_virtio.c > index faada49e184e..e1f15344ef97 100644 > --- a/tools/libs/light/libxl_virtio.c > +++ b/tools/libs/light/libxl_virtio.c > @@ -48,11 +48,13 @@ static int libxl__set_xenstore_virtio(libxl__gc *gc, uint32_t domid, > flexarray_append_pair(back, "base", GCSPRINTF("%#"PRIx64, virtio->base)); > flexarray_append_pair(back, "type", GCSPRINTF("%s", virtio->type)); > flexarray_append_pair(back, "transport", GCSPRINTF("%s", transport)); > + flexarray_append_pair(back, "forced_grant", GCSPRINTF("%u", virtio->forced_grant)); > > flexarray_append_pair(front, "irq", GCSPRINTF("%u", virtio->irq)); > flexarray_append_pair(front, "base", GCSPRINTF("%#"PRIx64, virtio->base)); > flexarray_append_pair(front, "type", GCSPRINTF("%s", virtio->type)); > flexarray_append_pair(front, "transport", GCSPRINTF("%s", transport)); > + flexarray_append_pair(front, "forced_grant", GCSPRINTF("%u", virtio->forced_grant)); > > return 0; > } > @@ -104,6 +106,15 @@ static int libxl__virtio_from_xenstore(libxl__gc *gc, const char *libxl_path, > } > } > > + tmp = NULL; > + rc = libxl__xs_read_checked(gc, XBT_NULL, > + GCSPRINTF("%s/forced_grant", be_path), &tmp); > + if (rc) goto out; > + > + if (tmp) { > + virtio->forced_grant = strtoul(tmp, NULL, 0); > + } I would add "else" case, something like: { LOG(DEBUG, "Missing xenstore node %s/forced_grant, assuming it is disabled", libxl_path); virtio->forced_grant = 0; } > + > tmp = NULL; > rc = libxl__xs_read_checked(gc, XBT_NULL, > GCSPRINTF("%s/type", be_path), &tmp); > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 1f6f47daf4e1..3e34da099785 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1215,6 +1215,8 @@ static int parse_virtio_config(libxl_device_virtio *virtio, char *token) > } else if (MATCH_OPTION("transport", token, oparg)) { > rc = libxl_virtio_transport_from_string(oparg, &virtio->transport); > if (rc) return rc; > + } else if (MATCH_OPTION("forced_grant", token, oparg)) { > + virtio->forced_grant = strtoul(oparg, NULL, 0); > } else { > fprintf(stderr, "Unknown string \"%s\" in virtio spec\n", token); > return -1; From xen-devel-bounces@lists.xenproject.org Tue Apr 04 18:22:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 18:22:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518112.804309 (Exim 4.92) (envelope-from ) id 1pjlIT-0002f3-Vp; Tue, 04 Apr 2023 18:22:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518112.804309; Tue, 04 Apr 2023 18:22:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlIT-0002ew-Sv; Tue, 04 Apr 2023 18:22:21 +0000 Received: by outflank-mailman (input) for mailman id 518112; Tue, 04 Apr 2023 18:22:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlIR-0002eq-RA for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 18:22:19 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9edc7384-d315-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 20:22:16 +0200 (CEST) Received: from [2001:8b0:10b:5:99d7:d5a0:55b7:41c3] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pjlIB-00Fbbn-KB; Tue, 04 Apr 2023 18:22:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9edc7384-d315-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lu8jZhJaTM8m5Xr4ZDYrxrjU1MfxECiW0p4YuCvnGkU=; b=p1Vzi9eB2flWEAyLvCdP73AYed 5cxIUcKX2e4Hj3GBqR/JPEJjgr/GVER5EDKP7iF5VfmYr+uSi6nhaNXHLE0ZBmwMv4+e4MvoiqtHd 8RCwRAdlISuh7VlCxlnbuIT/lWgZs+NR+ScqzUTbFVkCUEYsq3XgGfLPXjgGpmYQzN5xEBK2HFpA+ 7SXBDrfuAsizV++3ptudrG4I0Y07Mnw6egH2DTCSyYmZVQ15SPHHIjddJwp6RlnIhyem75hDjwrsb ojy6qE07qp6nad4Rw2PlbthbVobe25Zyo9JhYOsInVqt28A/RHbe7XIFHX4bxocciULrlgR3Uzf0w Uf/iNuMQ==; Message-ID: <59486d12e4c22fccf5fad4a34cfae68547c759c2.camel@infradead.org> Subject: Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation From: David Woodhouse To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Date: Tue, 04 Apr 2023 19:21:53 +0100 In-Reply-To: References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-14-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-5qfME1/1OsAkh+xXm9Bs" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-5qfME1/1OsAkh+xXm9Bs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-04-04 at 18:45 +0100, Peter Maydell wrote: > On Tue, 4 Apr 2023 at 18:45, David Woodhouse > wrote: > >=20 > > On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote: > > > On Tue, 7 Mar 2023 at 18:27, David Woodhouse > > > > > > wrote: > > > >=20 > > > > From: Paul Durrant > > > >=20 > > > > Signed-off-by: Paul Durrant > > > > Signed-off-by: David Woodhouse > > > > Reviewed-by: Paul Durrant > > > > --- > > >=20 > > > Hi; Coverity points out a memory leak in this code (CID 1508098): > > >=20 > > > > +static struct qemu_xs_handle *libxenstore_open(void) > > > > +{ > > > > +=C2=A0=C2=A0=C2=A0 struct xs_handle *xsh =3D xs_open(0); > > > > +=C2=A0=C2=A0=C2=A0 struct qemu_xs_handle *h =3D g_new0(struct qemu= _xs_handle, > > > > 1); > > >=20 > > > Here we allocate memory... > > >=20 > > > > + > > > > +=C2=A0=C2=A0=C2=A0 if (!xsh) { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return NULL; > > >=20 > > > ...but here we can return without freeing it... > > >=20 > > > > +=C2=A0=C2=A0=C2=A0 } > > > > + > > > > +=C2=A0=C2=A0=C2=A0 h =3D g_new0(struct qemu_xs_handle, 1); > > >=20 > > > ...and here we allocate a second time and overwrite the > > > pointer to the first allocation. > > >=20 > > > Deleting the first call to g_new0() would fix both of these. > >=20 > > Indeed, thanks. Do you want a > >=20 > > Reviewed-by: David Woodhouse > >=20 > > or would you prefer me to submit the actual patch as described? >=20 > If you could submit the patch that would be easiest -- you're in > a better position to test it. I've been getting Paul to test the parts on actual Xen, so I'll send it and let him test. --=-5qfME1/1OsAkh+xXm9Bs Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDA0MTgyMTUzWjAvBgkqhkiG9w0BCQQxIgQgugYs5ujX NisPvvX7Yn5LgbTK0p3LWuuOwcg/UVqe3pAwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAtJTGL0p1GfoAN7M+KDM7nTNR8U75JMSb3 sOI7kfy+vAfZvuHJFydxVn4P1AMSj3TIbMJr3FbR5ajQuIPeYkuT43WMnL6Mgsh7XeBpdyJdXwyV al9m3lWZq9xUYu/89yBEd70Rc8iivB/lFgvQaNFMyAQoJUS8BgDAqo65U+8bz01c7HYMcM0Os3cP eTLXI/zcSYZP/6eqVAuP2SP9u3ikA0YyqhI3ca7lX4QWGNaGnLCb75tOtRYjJ/50Z/pvSX8a0k1L lX68GPM6GIURFUV5m8f/tyQcPOZUYUrqypWvPXuh35GtQinDsIDRM6bBrUp0jRdn4An7Lsc9e6iW 8PP20IrrpYor9H1+WhxHZ/ip9AM5yO5ZYwlw+3cx+BftbRDhNfu3T6Mwr5AhfzHCXpYHvcxoTdrS hOeoEpclqTaCRivyd2lhGh2f4AMp6/EsO6JyN5+/j8QXO7lCdPaN6YrLHkXNoeSocR72la516Jlr cmlxFFBK9VQm7DiRtesUkSpOLg3XKt/iZcv6pN6ruBbEYEGEFmmc8MWbXymR75WmaxslrDSnNtQV I/welI9d6hZrlAwVprmJbomQyVyJgWd4R1HPzSXYZ+XjNgUNYMDY7mv7pCtZkfuOa3QEpGphWW+I cpkAD3slZePZ5QsNRYRg6W3yhL8CMu755G3bAP7jyQAAAAAAAA== --=-5qfME1/1OsAkh+xXm9Bs-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 18:25:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 18:25:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518117.804320 (Exim 4.92) (envelope-from ) id 1pjlL5-0003Do-EN; Tue, 04 Apr 2023 18:25:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518117.804320; Tue, 04 Apr 2023 18:25:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlL5-0003Dh-BE; Tue, 04 Apr 2023 18:25:03 +0000 Received: by outflank-mailman (input) for mailman id 518117; Tue, 04 Apr 2023 18:25:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlL4-0003Db-DB for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 18:25:02 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02b171ab-d316-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 20:25:01 +0200 (CEST) Received: from [2001:8b0:10b:5:99d7:d5a0:55b7:41c3] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pjlL2-00Fbl8-3s; Tue, 04 Apr 2023 18:25:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02b171ab-d316-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:Date:Cc:To: From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=480JJEkRxs3cmNNvJ6vGQyvJ1jJTqswEUwkTvI30tHc=; b=onf3GHa5oA8L0Q8WHPctBlPRUW zHbocjgALQoABlp3ZuxwkP093PFoR8fNhfXGq7VdpaL5Jqn70+CPmKTlOK8ypnn2CK7y4Wt6WY/+s Qv4L+OTeCABVyU9PvgyFa02QfsH0g6IFbUszb+3kih8UgsPVsrxkjXb4gX7T1EE3QVeU2+nc3Qn8i 8GxXREN4h3+7tm7jBzGEGDKqjpEpd2W6OOhMROVwD6Ey5HTd+KtCWjzcM33o0XSGfYSr2Qwrz2iDz ZB4GbV+pPvGdBodDDwbV1QSX3LjjC4VicQIXWXPeumJDV6w+qmydTovyCnDE3NDDODkkkb7nrKq20 /e0Vmrng==; Message-ID: Subject: [PATCH] hw/xen: Fix memory leak in libxenstore_open() for Xen From: David Woodhouse To: qemu-devel Cc: xen-devel , Paul Durrant , Anthony Perard , Stefano Stabellini , Peter Maydell Date: Tue, 04 Apr 2023 19:24:59 +0100 Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-uipq9uCR3mh5JLaPWdR1" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-uipq9uCR3mh5JLaPWdR1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable From: David Woodhouse There was a superfluous allocation of the XS handle, leading to it being leaked on both the error path and the success path (where it gets allocated again). Spotted by Coverity (CID 1508098). Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection = to internal emulation") Suggested-by: Peter Maydell Signed-off-by: David Woodhouse --- hw/xen/xen-operations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen-operations.c b/hw/xen/xen-operations.c index 4b78fbf4bd..3d213d28df 100644 --- a/hw/xen/xen-operations.c +++ b/hw/xen/xen-operations.c @@ -287,7 +287,7 @@ static void watch_event(void *opaque) static struct qemu_xs_handle *libxenstore_open(void) { struct xs_handle *xsh =3D xs_open(0); - struct qemu_xs_handle *h =3D g_new0(struct qemu_xs_handle, 1); + struct qemu_xs_handle *h; =20 if (!xsh) { return NULL; --=20 2.34.1 --=-uipq9uCR3mh5JLaPWdR1 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDA0MTgyNDU5WjAvBgkqhkiG9w0BCQQxIgQgjC6wgXqc 50+U+F35zaGyC+2DHwu+0q2L01ltJKIfXIMwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAKBg6VhCEJOc7AzHqmKKK0YSirnbRs5g0S 3gKvk9aXDcf3mlWMN1oZuqQsqnqaZQBIKhq6P4+GOnvfEBsImBCP94LMUb+YI/Sm3VRUAq9at0nK mrWV3mvz82Gu8J0ZoZQqleUcfFUHwBp39pSxnXSFi4XFp2kp9OhLCbMjK8TbGozVAr6nuEhQY+ki f1Mx9Pm2Mu4JgzhBm5gnOgRwvdZ9ZspufLBP9VpCVIsIrCczajM01MNCENvX4p19ORPTjF+J1RBV dN7gcj6lvCyj6N591JB15s5NYJ2SwqaqCl61HeG+43K6XwbySMrEW4YHkZG4WgkX0gxq/vTGVQDV CfhbvOKaqNQNdhKY8cg3shh/zCAmQgzVrap+N2dFWq4AVVOVFvHwQGkkaRwyagO9qPb+ADDk3nak /xhWdaHLxz8cNmdrqEyAk57dbxos5P5kMpqMXpxDthbMLheCjSHTBscyVdCCADsHYzCRUCYHepng hmYoVM4uE5CBPN6PYvnD6sg1bWRwpOQYLmadoilhRWNxBz5J/cAdUAH0kzPg7CHqaUwJRYuHBQFu KJ/h38hGXLUAoz4X21Vro+oJUh2D+jB5MJHeV2P6UuOiTTh8iP6Vb10X6vg5b+lYOT4A2HpLj1Yt LhOP1GmoU8nM2YroVqXt9OVE1SPNyF8vi7RLdxljtwAAAAAAAA== --=-uipq9uCR3mh5JLaPWdR1-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 18:28:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 18:28:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518122.804330 (Exim 4.92) (envelope-from ) id 1pjlOM-0003q0-Sw; Tue, 04 Apr 2023 18:28:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518122.804330; Tue, 04 Apr 2023 18:28:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlOM-0003pt-QE; Tue, 04 Apr 2023 18:28:26 +0000 Received: by outflank-mailman (input) for mailman id 518122; Tue, 04 Apr 2023 18:28:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlOL-0003pn-Ov for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 18:28:25 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b76eb4c-d316-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 20:28:23 +0200 (CEST) Received: by mail-ed1-x52e.google.com with SMTP id t10so134161537edd.12 for ; Tue, 04 Apr 2023 11:28:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b76eb4c-d316-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680632903; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r+d5Q9YLXYIEcRrYG4TRRbzODXP0vlh3YF3733MY38Y=; b=f3BpCBNxoILDtSyKj6axT8mrPBlR5NN0lRzyoX5tdjNO/89HEPknpa4WvDWvmDY58B BI0hYUwNBgaMA8tYJ7g1HLqAvUExLBy3m1U1+4LSeQHitztp3uTADQEFWKk3ejKh8zHG d8eIbwe2BJ3fYazGz2Q4bSoA4I96qXA5V+g/6roXRdYcnwfhMpurLv7XqBXSibhOa8T4 uZcgEoBlNaqEyFJ1VY53AKfCGcQ/Cel/7ok7tvgZq4mf9GXwVfV67QswY7pBPxG4byhj 5Gzf52tGeynPD3urXrj/SVyzZcSHBswX6C3Zinr9W2c1498cvHXAwVpExI0VTjq7CdSU bAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680632903; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r+d5Q9YLXYIEcRrYG4TRRbzODXP0vlh3YF3733MY38Y=; b=qYebnK8ESyCUChQ7qXgwN+NFPf8mORiaU+6gEYjhfEdCVUFrqG/qGWI2z/Xc3zOkoC 6cNrzBjp5ulnoxbOCK1kdd9xc/Q8G3Vs2TkI44laZAE3KgSyYFk0t1j+h+ruR2WKu1wp lQsfLWeNeMeukKUvGbpXNdpvASPc8MqKjfhMRAEKqn5nFUMQgK25331VzBZ4lUd299Fs NoG91vXsQhPiycsrTk/UuMMMCFDKLoEzGdEjZiuZqHKiRTcVCFDsY6EK0y7IEJwru+// 0jmRFIc61PS8QK2PcZpgUM+4ec/bH7TAPFOOhIU6iE9xV9LdL+mT/36XC1fNi+rYIsDf P2MA== X-Gm-Message-State: AAQBX9dyddlt8xdILmbfHkfqeEM4keUcyB1dgSUB5liKMK38x6Xls6lA MTnPRKy2SLRiUp0Xbp38FoZXZDG0sDXuY5i1eqRLiQ== X-Google-Smtp-Source: AKy350ZT252GSKd/98j6Mu/b60fK17QV1dP+JE4fqqkBHdumFzII2W394UiPvTI+M3TSV0LF0wvFMeuQ5PxM5EcMK/M= X-Received: by 2002:a50:bb43:0:b0:4fb:7e7a:ebf1 with SMTP id y61-20020a50bb43000000b004fb7e7aebf1mr222707ede.6.1680632902832; Tue, 04 Apr 2023 11:28:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Maydell Date: Tue, 4 Apr 2023 19:28:12 +0100 Message-ID: Subject: Re: [PATCH] hw/xen: Fix memory leak in libxenstore_open() for Xen To: David Woodhouse Cc: qemu-devel , xen-devel , Paul Durrant , Anthony Perard , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Tue, 4 Apr 2023 at 19:25, David Woodhouse wrote: > > From: David Woodhouse > > There was a superfluous allocation of the XS handle, leading to it > being leaked on both the error path and the success path (where it gets > allocated again). > > Spotted by Coverity (CID 1508098). > > Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to internal emulation") > Suggested-by: Peter Maydell > Signed-off-by: David Woodhouse > --- > hw/xen/xen-operations.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/xen-operations.c b/hw/xen/xen-operations.c > index 4b78fbf4bd..3d213d28df 100644 > --- a/hw/xen/xen-operations.c > +++ b/hw/xen/xen-operations.c > @@ -287,7 +287,7 @@ static void watch_event(void *opaque) > static struct qemu_xs_handle *libxenstore_open(void) > { > struct xs_handle *xsh = xs_open(0); > - struct qemu_xs_handle *h = g_new0(struct qemu_xs_handle, 1); > + struct qemu_xs_handle *h; > > if (!xsh) { > return NULL; > -- > 2.34.1 Reviewed-by: Peter Maydell thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Apr 04 18:51:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 18:51:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518127.804340 (Exim 4.92) (envelope-from ) id 1pjlk1-0007AD-Op; Tue, 04 Apr 2023 18:50:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518127.804340; Tue, 04 Apr 2023 18:50:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjlk1-0007A6-LM; Tue, 04 Apr 2023 18:50:49 +0000 Received: by outflank-mailman (input) for mailman id 518127; Tue, 04 Apr 2023 18:50:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjljz-00079w-Pr; Tue, 04 Apr 2023 18:50:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjljz-0003dr-OB; Tue, 04 Apr 2023 18:50:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjljz-0001mv-Bl; Tue, 04 Apr 2023 18:50:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjljz-0005Y1-B2; Tue, 04 Apr 2023 18:50:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V3Qio32KoVcucSR4U73bxtt9sgm0NSQNh+tVBbU+crI=; b=L/xh3opJhIgwI+dm6A8BdInCIK bRLhSzhmXNCVeXubtTWVliP095JiFaMs+JKFkrbCSucDFhOKGtlFUoqmX1UyFURWl+CwqwtDHuwxy 4RR5AcDxmo2XJEzM5I1aj8ILQaL4tqX70PNicoOstzH63yVxSg/73S2fHsUkg64qqB+4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180140: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 X-Osstest-Versions-That: xen=658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e From: osstest service owner Date: Tue, 04 Apr 2023 18:50:47 +0000 flight 180140 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 180137 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 baseline version: xen 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e Last test of basis 180137 2023-04-04 14:03:39 Z 0 days Testing same since 180140 2023-04-04 17:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm fail build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 Author: Andrew Cooper Date: Tue Apr 4 17:35:52 2023 +0100 Revert "Revert "build: Change remaining xenbits.xen.org link to HTTPS"" This reverts commit b5cc3c25a242ddb9c5b108884061b17f35c3084b, reinstating the original change as per e1d75084443f676be681fdaf47585cc9a5f5b820. We think the OSSTest failure has been addressed now. Link: https://lore.kernel.org/xen-devel/20d41dd0-19d1-47fb-92ab-4de458ddd56f@perard/ Signed-off-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Apr 04 20:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 20:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518136.804359 (Exim 4.92) (envelope-from ) id 1pjnSg-0001j9-Jk; Tue, 04 Apr 2023 20:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518136.804359; Tue, 04 Apr 2023 20:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnSg-0001j2-Gb; Tue, 04 Apr 2023 20:41:02 +0000 Received: by outflank-mailman (input) for mailman id 518136; Tue, 04 Apr 2023 20:41:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnSe-0001ig-Gd for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 20:41:01 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff4003aa-d328-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 22:40:57 +0200 (CEST) Received: from mail-dm6nam04lp2042.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 16:40:53 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5080.namprd03.prod.outlook.com (2603:10b6:a03:1ea::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.34; Tue, 4 Apr 2023 20:40:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 20:40:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff4003aa-d328-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680640857; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=OcfyXQakXa/Js9T7ldqQkijECtim2exxVgrREpNG/r4=; b=TUR/yCv4mOIAz/Lqa8cCNKL1teeH1Ar2Mu6E1Muz1r9yPRWFW9BL0Vq3 Ajx6inXcUrKSC3LIcZ5BvYRHGuZ7fYudZtuamcje1PcdUvmumdDClZyuF pPvD0uSMxTF6Y0my1Uy1jxlwkQcOQLPHMtQPftxmcphcJSzgPDi/B6TOj A=; X-IronPort-RemoteIP: 104.47.73.42 X-IronPort-MID: 104360082 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ErVnjq23vtZHkFjmCfbD5fFwkn2cJEfYwER7XKvMYLTBsI5bpzMAz 2VKUWGAMqyIZjOje9Bwbti18BwCuZ7UydFrHFY5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAlpk3 NVJdgk2Y06gmPC9nre4Vusyv5F2RCXrFNt3VnBI6xj8VapjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6PlmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHunA9xKTO3inhJsqGfL9jFCWCI9bgOQouuZrWj9Ve8Bd nVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4J5oflqYRr0hbXFI4/Suiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAszA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:xw4ARKiWntTJhn2buqE+FBoHDXBQXgYji2hC6mlwRA09TyX4rb HUoB1/73TJYVkqNk3I9ersBEDCewK5yXcN2+gs1O6ZPDUO21HYTr2Kj7GSuwEIcheWnoRgPM FbAs1D4bbLYmSS4/yX3OD2KadG/DArytHPuc7Oi11WZUVBbaV46gdwDQyWVndxWBJNCfMCZf mhD4581kOdRUg= X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="104360082" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oDD7Lo4ulL5XlkD7IBdPqELv80gFlCsQk5bIvQqJUC0S/iZ49ZmUwIYxBEOW8n/BdnD3Kyyklo7ZwlAIZ+gWZqp3t21LyQwClzbmfpe6/jpGDFoG/V5wjy8kJ+ZBd3ywbo+lfnb9disbQKF0arcCYyL1KGSca2qWlbyDY0itKQaw8DprHheZruf/gaIuJ+r1BHW72sp+FzT8NWIrD9H+xihupgpALEXglqx7YwIjJNpt6LbXDLQ46ol4cC3JGLSlx4zItTAnTcWLH6pceuknR/1nFmOi613JGX4cSWoINa9bi9pP8IJMQg16B1/yIWfjiCbV0gWDgfAuJ7+cdyQHDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hKY0pwn6ZmXRuUf4xs2ZJ/Z+kpIVH1u23Ydggy2dA1g=; b=ELbxaJHSD+s/lc2W70HNi8YXaJhEjXt7TNn15AydiYWBTaCBHCFdB3al3VJxwNK78c1JhYD3DIMMzOqbYKwf8lMZ9hNyqydt6Lwr108wh98nH//CXTJTD+PBd26UT1vZ1EyarcHJqRWJP2ez0EnXJ4xzt56ycDfNnE11kV+wLR4suCPfHs0ha/qxWMJa10iGom50AEjJ9DsaGWCuSXZWpiRHZOzJ2ezPupZyILaQHyr1V3FicfWZhYmhrMH4lHxzpR6xkD5YMuEH6evyDQL8zh3RlyUF+ikwUfi4aCoPYeywFBqxO5r/s7xPcDP7MXNJ1PP0CyBWbBfMa51nH21W0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hKY0pwn6ZmXRuUf4xs2ZJ/Z+kpIVH1u23Ydggy2dA1g=; b=igwCiu7Vzps1m5JGPnEDqgXvhOxLAw6l0a9gXXUEra7ay5onT+CHFyUOTQu//zbjKUhU+Zr4HqXayLFLLq+vjAd7noiitqCLnuyYUCxtGArnh0WU6+snZbaAYKeqcmBHQYL0nq/RgPeZ8vUHqRZMi02X/ylctTQzyaIiEnKGE+s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <78e72635-6ebc-b3b7-83d5-134d5c63d561@citrix.com> Date: Tue, 4 Apr 2023 21:40:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-GB To: Jan Beulich Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <6d64dd4a-5b25-ddca-5c07-7b4c0fc48c0c@citrix.com> <5f9218c1-9ee9-c5bd-af8b-003084aa66e4@suse.com> In-Reply-To: <5f9218c1-9ee9-c5bd-af8b-003084aa66e4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0368.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5080:EE_ X-MS-Office365-Filtering-Correlation-Id: a7a4647d-0572-4568-dc69-08db354ce052 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N+C1yuUiLaz+J8lOgSnA/GjcN8V771lkj+/TLTxTXoLPUi5P7P0ej27uOt9hjdnhEKwyEGDmcJIKPhvhAvo+zdu5EjU/6Pp2nTy2L5vJg9vmTpYMo9zgZEHhj2jr3TPJDannPs5AJUV+w+jnLjkuzZJxiWfKLyc+hwuKsCE3cfo2Q01ovMjnAeaAtfs1CQPrcohVDECx+y3Wj9+uYjP4wuytRbkhi/c8OnBG2ESiWr7UlPHNxkduVQYF/jbg+FgQMJcmPjigMAn3NlF+6jZOAZr0L9LSyCVOm7Oo/g3EDjfkBbNCOr/QkIz4wsyNtg7Ch3kN2AfJrmXdD9Owa1rTGPhOB9gJ6TeUpE3Q4/OFOJKq2PJaM47LxPH+2lcjh2pE1IiH4ztDUjRZ0YLVnesVP3ZrSTXLhiUgNfA9y+iji/Bc2kwlsRxgv/MiScGWXSg0vYqQdY3iCDdxUvTEHHjsCJwSQ0bZdaoQon884xwzYaPCw4zwSLCmmsXTr0qlLwiIWGh3OTXDPNfJhJtKqrQeohi8XJhPUq60RIT/xzjHlUoIMAmN3pgi2+ueRK+IhQcEU+st6XJG4HTxHZ4E/ZoOYYwKdKO/SiLL56M2e4fvKIWftExgRp5uA6KzkzIegm0WZt5X5RqviLoNrgH7gxfZLQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199021)(31686004)(36756003)(316002)(186003)(53546011)(2616005)(6506007)(26005)(83380400001)(6512007)(6486002)(478600001)(86362001)(54906003)(6666004)(31696002)(6916009)(4326008)(8676002)(2906002)(66476007)(66899021)(66556008)(82960400001)(8936002)(41300700001)(66946007)(5660300002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVdRR2FkeWtpaU80blFsd3JnNVZLbG9PZjdpbmtIS1BhNmtaRU01cjFTZE1T?= =?utf-8?B?ZGpWelk1YnRPanF3U0N2WWlnMmlGK0ZRdHl2T1psaFNKR1h6S3ZTOEhBdkFL?= =?utf-8?B?OXpPbEREWHprM0dWZis0T3c2dEduU05PLzdmNWJaejV0ZitBQTNvQnBKZjZD?= =?utf-8?B?Vko1TFJpWmJlekdtcHNzZTBQK01DWDg0b1E4Qk96MmZCUHN6MkVTUHgyNUxD?= =?utf-8?B?Qk5TdG95TnVoMURMSWkzenpENUkydnNjSFp4aFNrZ2VCNTZoWWpIQ2FsNGhp?= =?utf-8?B?Vitoa1BnQ3dDcmREQU1IcUtoc3FXNnpQSSs4TWhGVEVtY05NbWljeFhjVkl4?= =?utf-8?B?OW1kdVpYeFkzcURXNkJqSDRJWVE4QTJvVGhDRUVZS3E2T2toempxVTFLWUZm?= =?utf-8?B?MzlnMjZ4UlprRjlTdk5wRmFnK2tNOUdsS3VCeEtOeUdDR0tIV0xTUHpYczRt?= =?utf-8?B?aU1XOGQ3OWIwcUxJczFXRGJxOTlrZjd6NzNHdFo4RGZmRWdqbnBXeXV0QnNt?= =?utf-8?B?UVVrQU5Ob0RaTjFkWUc3cUpDWG1HcDlpVVRSVlUvcGZTc3J6RkNlZDRWOXBH?= =?utf-8?B?bmg1VDVjR1NrQmUwN1MzZFZoajJ5cFhzZEVlWmlELzZHRVVPVmlYNGNIZ0xU?= =?utf-8?B?U2RqK09NWnh3amdST1JYZXZidFZMUVFBS0ZSaGg2bi9wQkpDMTl4N2RZQWNj?= =?utf-8?B?c2dUdkZpeDA0d1pkY21LYUNzV3dmZ21lNWovdG5vNUc2RUhLTEFGdlI4eVU3?= =?utf-8?B?MURpL0x2NjFYbFZnT2diN09MUVRlTUlyRlhJRHM1VVNQMDRkV3A2dHZHUUov?= =?utf-8?B?dWI4bGlLS0h4RUxiUW5hNS8vb2NLY3hFTitXeG5NSGY3aHV6S3NuUDVWdUVG?= =?utf-8?B?ckFFTm1KdUlOSFBpR0tHL3c4OTdFbjNSOEJRTWdDa1RyRTIzWlBGZFVJRkRj?= =?utf-8?B?ZGdYR2FKa2hJblM3V2xHRXY5ZFNBZjRmcmV5VzRhWWFubUhVRDdWK2FOOXdS?= =?utf-8?B?Nm9yZ3NaNlEvZ3hOUDVUbmMyNkR3MndHeU9UR0NwTVVjWWlRYVZjT3VUc0hs?= =?utf-8?B?U0E5eCthRHV5RFJjbTh5UXVYRnVtOTExVFVXU1JCNGZsTzJZNEVkbWF1bjN5?= =?utf-8?B?NnFoOTJONEhmektnclRZRHkzL3R3THZlWnpaNHBidEQvNHM5cU55WXgzU0cy?= =?utf-8?B?dElVN2ZQS1dTQ01DTE1TT3B4czEraFpUQ3liL0pHTFlYM3FQc2dUakhOTUZY?= =?utf-8?B?d2tWeGxKT0xMNWFGWWl2d1RzSHNqdGk3enBRRWllblRiSndmTHRlWEFCdzBy?= =?utf-8?B?WlFGN1lxUmdzQnMyVGhxaEFvOXlmNUV0cGYzbDJhWjhTbVltZ2U0RG9QWVVV?= =?utf-8?B?ckt3eEZ2bENwOXBsWVkyZGhhZVJGYWdmQnVvUk84aGRUVUE2aXo5TUdJTHJB?= =?utf-8?B?bGcxZXNjTnh3RFl2cXZHbm9pc1JBQkdDMzBnQ1ZmZC9rT2pQcmtxZ2FTT0ZL?= =?utf-8?B?R2dXMEhZQUJzMEdrN0tWMEhCc0x4VHluY0hKZTdId2ZQMlRORmZyeEZXRnZW?= =?utf-8?B?V1hqWjV5SnBrWG9EeWZrcm5heGFnOWVSS2JIemFWeHRKYjFPelBscVk0UEMx?= =?utf-8?B?QTRraUZXKzF0NnNRZFRYQVZRbS9SQ25CcWd0SFdISHVxclBsejEyOXJzVUxN?= =?utf-8?B?VXhBSFpPa2hSMHg2dlhNUVA1c202Snl3U1owNHV0SE1KYllHUUNyYnI4aC9s?= =?utf-8?B?MVRNTFZOcElGcWx5dmdqU2tWQ0VtY0RMWDhsL3BUMmpjb2NWWjc0WGV5eVdj?= =?utf-8?B?S3dEMU50ZGZuZkgwY1FqNkkxQmM2NUZaTTlxZEtWWVBPQUpSajJBYWRPdTJF?= =?utf-8?B?ZXR5aEdXZ2VuRHZBOXNCUDJpNjIvblJQcWR0Qjc1WEZpb2ZiUjhZZVJSUDdm?= =?utf-8?B?UmdvbTAxT0xjNnNSSDVOOTNRclp5cm8xSFlpSXZtOXF5QkxkV01vdENKdmYx?= =?utf-8?B?aThLNXpzd2hZREUzanpLaGV2TDhJSFppSFljL3d6TENUS0ZLVU1sS1plQWRx?= =?utf-8?B?ZmUyQzUwNHkvWWFaTGZhY2VudjBDdm5UUzQ0cmdHL3kwdGt2VUg3TGJWa29V?= =?utf-8?B?NDZUR1ZXanozZlR2RUlVYlpuY2NoQWFWRzBsem9uaEZGcjU3SjF4MVNIcVB0?= =?utf-8?B?Y3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6XNVG3yMzF3X3HVo6+rS9+NescXcz6MpivFJdgbZM1/hESOMKmT+JxUoV4xxGx0yngg1c5SpVE63eW7AGm06nMORCKnVmKskQO+DfWHr+Qr9ZFmTYHSc/rBZJgNt02KLrlOn2Q8lvC3qE4Ui3DL+jXwncdTkTJ0l9hQdbB7gM1Bu0MPRGQ2uIqyFH0lQrMwCSVvca8UJvUMRxelzG0f4IHPIOsux0KuHlVW9559h/CkyZuFU/ph6it1jJ/p6pUnVkvuRrvYmWT0ebS2bMQFA+5I3k4WE18liTvC3RhYCj0y8yvNj0MsRTcL4OXZ/jx/LcZQpnkLe6Etn/Ckr8TamKlX1B2tdbGkL6pTqoQn0F2jTOjGHpRv9gmDHMt8mJkBPVbwbhWzTVTcix1cZTSq4LDfBxkXDXwektkD7A8nQdltyYZGNYglrtnciH4F+qjz6hWUp2E3tpWbY8fm08JZrFv4x8JZEpiABwrOVzdhhtCM44uCAiY6xt4fYtSSYr0kgcNVTl98Xrx7cyyw48P76zAMm1qVxS1PBNW1YAQbhzHSGugWkcjwaV4W6/lqiJYlcqmVbaDWKuQx5JttCapnxf7tDi9+fZv5Wx279sDSj325e1F0ibBrE4fo8G4MlcaC14KyvJi9vREoaXl7vnYthWOcOhbuDyaNemNhpj887F9kN7X2NHnefjOprIndwW1EmCPMnhVUALKqYav56w92xzdccsXLQpgIn7tz9IZ31H7jqadDbQPqPYwXR5obEFL1HhCbswmi+YiR5y9cZzKjdS5z3Z14Mb0nrhSW3FP4m+xgLwAHaCdYxXOU0XkS37qrV X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7a4647d-0572-4568-dc69-08db354ce052 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 20:40:50.4683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aEdlN5k5uNAlP4wjMv01l2s/bDL3zNg0pXn5LMMNqZb+nwvL4SPOqcmBMqXcB3jHaExtNPHqOqvc41MC6Zfq1aaUS1BEqSzGoV4dYsTyd0g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5080 On 04/04/2023 3:21 pm, Jan Beulich wrote: > On 04.04.2023 15:08, Andrew Cooper wrote: >> On 15/02/2023 2:54 pm, Jan Beulich wrote: >>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still >>> applies to guests also when run on a 64-bit hypervisor: >> Is this really true?  Even when looking at Xen 4.2, 32bit guests are >> required to pass a full 4k page, not a 32b quad. > The full-page vs 32b-quad aspect is orthogonal. This VM-assist is solely > about where that data structure is, not what size it is. > >> Which makes complete sense.  It was a hard requirement of 32bit non-PAE >> guests, so it was a natural restriction to maintain into 32bit PAE guests. >> >> This is *only* a 32-on-64 issue, because this is the only case a 32bit >> guest could in principle use an L3 placed above the 4G boundary. > Not exactly. 32-bit Xen maintained a 4-entry "shadow" array below 4G > that it would copy (massage) the guest entries into upon CR3 reload > (just look for struct pae_l3_cache in the old sources). So above-4G > page table base was possible there as well. Oh eww, so while Xen never gained an optimisation to permit only a 32b quad in place of a full 4k L3 table, it did support having the full tables higher. (This code is especially hard to follow with #ifdefary in the common mm.c when there are perfectly good x86_{32,64}/mm.c's to use for differing function implementations...) >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ >>> unsigned int partial_flags = page->partial_flags; >>> l3_pgentry_t l3e = l3e_empty(); >>> >>> + /* >>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not >>> + * understand the weird 'extended cr3' format for dealing with high-order >>> + * address bits. We cut some slack for control tools (before vcpu0 is >>> + * initialised). >>> + */ >>> + if ( is_pv_32bit_domain(d) && >>> + unlikely(!VM_ASSIST(d, pae_extended_cr3)) && >>> + mfn_x(l3mfn) >= 0x100000 && >>> + d->vcpu[0] && d->vcpu[0]->is_initialised ) >>> + { >>> + gdprintk(XENLOG_WARNING, >>> + "PAE pgd must be below 4GB (%#lx >= 0x100000)", >>> + mfn_x(l3mfn)); >>> + return -ERANGE; >>> + } >> Having dug through source history, I see this is largely the form that >> it used to be. >> >> But I'm unconvinced by the "cut control tools some slack".  I'm quite >> tired of different bits of Xen taking on unnecessary complexity because >> people are unwilling to fix the problem at the correct layer. > But anything tools do before having created the first vCPU would not > have had any means to engage the VM-assist. I.e. ... > >> A toolstack which has non-pae_extended_cr3 guest on its hand will know >> this before any pagetables get allocated. > ... this knowledge buys it nothing: It would need to move the table > to below 4G irrespective of knowing that the guest can deal with > bigger addresses, just to get past this check. This just goes from bad to worse.  It is mad that the VMASSIST flags can't be set ahead of a vcpu initialise hypercall. But. The code in xg_dom_x86.c unconditionally moves the L3 below the 4G boundary, so the thing actually pinned as an L3 will always pass the check. Which is just as well because it too blindly applies the extended-cr3 transform momentarily after conditionally setting VMASST_TYPE_pae_extended_cr3... So a 32bit PV guests will pass the check irrespective of their pae_extended_cr3 setting. I note looking at this code that it's absurd.  The single L3 ought to be allocated with memf(32), rather than being allocated regularly and then reallocated lower if it happened to be too high (which will be the increasingly common case as it's getting harder and harder to find systems with <4G of RAM).  Making the memf conditional on the pae_extended_cr3 needs to come with some better xen<->tools APIs. >> For this check specifically, I'd suggest prohibiting non-32p guests from >> setting pae_extended_cr3 in the first place (I see no limit currently), >> and then simplifying the check to just >> >> if ( unlikely(!VM_ASSIST(d, pae_extended_cr3)) && >>      mfn_x(l3mfn) >= PFN_DOWN(GB(4)) ) > Dropping the is_pv_32bit_domain() check isn't possible because we can't, > all of the sudden, fail 64-bit guests' requests to enable this VM- > assist (no matter that we know that it is of no use to them). I'm not so sure about this.  This VMASSIST cannot credibly be set at runtime, and making a restriction here is not usefully different from prior patches of yours that relax checks in Xen that still break on older builds. But as I know you're going to argue with that position, I'll at least note that ignoring a 64bit guest's request to set that bit would be less bad than the current behaviour. > Dropping > the control-tools part of the condition is at least problematic as well, > as per above. Albeit I'll admit I didn't check whether nowadays vCPU 0 > is initialized before page tables are built. But I think it's more > sensible the other way around: CR3 setting (in the hypervisor) is less > involved when the page was already validated as an L3 one. All of this is before the guest starts running, so it doesn't matter. The most efficient way (from Xen's point of view) is to pin the L1s, then L2s, then L3s and then set vCR3, because this is the only order where we don't have to do do recursive type acquisition. But, the most efficient way for the toolstack to do this is the opposite way around, because making Xen do recursive type acquisition is faster than other ways, and turns all subsequent hypercalls into almost no-ops. I doubt there is a relevant difference between these two approaches. And it doesn't matter either.  The check won't ever trip from domain creation (see above), nor from migration (we set vcpu context before pinning the pagetables, and a non pae_extended_cr3 will have exploded on the source side). So there really are no toolstack codepaths that can trip the check.  Future improvements that might trip the check can come with a less broken hypercall as a prerequisite. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 20:51:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 20:51:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518141.804369 (Exim 4.92) (envelope-from ) id 1pjncY-0003EW-JS; Tue, 04 Apr 2023 20:51:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518141.804369; Tue, 04 Apr 2023 20:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjncY-0003EP-Ge; Tue, 04 Apr 2023 20:51:14 +0000 Received: by outflank-mailman (input) for mailman id 518141; Tue, 04 Apr 2023 20:51:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjncX-0003EJ-3l for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 20:51:13 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6dc6f685-d32a-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 22:51:11 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 16:51:02 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6176.namprd03.prod.outlook.com (2603:10b6:5:39c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 20:51:00 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 20:51:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dc6f685-d32a-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680641471; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=d/iOhb27zQl0Tuqnt544c6sjqrsZzaAcvW83EZJK5kY=; b=SBiv/y7gCNqL3Fl+wYSnk7ASKU2ztZxQpoWIzCkFs9+muxJ4zDKyAdWa 0tOpLE48qPCkk3Em4yAEmD1jMPI9vfb1Td3sZUYCYmwzAL/MZW7EGYMmg DGFBTVJCtyVnJX0Uu/d1GdThAFZXGYpl4Gon3Ot8SvYVJHD0b7YRwP0pw I=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 106757052 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3yR+nqgEGUXmPLeAY/hMyiHbX161TREKZh0ujC45NGQN5FlHY01je htvD2GAM//bY2Wjc4ggO4vj/EkAv5fXzIJnHlE5/CBjQy4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AeCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQKJ21RZRLZhdmyg4OwQdcymeZgFsLCadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGybbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXmqaM12ADJroAVIDsWCHiJmNCrth+ze40FN RdJ0Asp8pFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAt5tDipMQ/i0zJR9M6Sqqt1ISqRHf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:krKzKa0ssaxDfDCcwY4ckwqjBLwkLtp133Aq2lEZdPU1SKClfq WV98jzuiWatN98Yh8dcLK7WJVoMEm8yXcd2+B4V9qftWLdyQiVxe9ZnO7f6gylNyri9vNMkY dMGpIObOEY1GIK7/rH3A== X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="106757052" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZKFQ28R07lFlepFv/LBj/DbBqCnCyggutGWyuhaKCI5lClBeI0x0iIqJmGfwnLCLpX7VMz672kod6gCymRePumxxu0clr3wYBorKAMJyk8WAQpOiu7MfsNNSsVox4fOwRq9Emsl513D1NPth8wBWMDXX5jd30CQdxnqaxXAoQpoemxxwqyYBtRDHwVMUcXdbo8PKt3Dw24Q25AEx3hT836GStm38ClJ2rrJP1oryw+LerbQmt4sGgnuiShbfLlVzAMTgNnSUy/WCEmwREH8MvEU6OnIgtUM8eVWNJoEyOFuP1OFKR69Bb3P0uJ+2o6nCPgBvDPq6+mLjNjzZ7PhRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WDKuqcvC7AlVLeucoWBHyztl7KBKwvZVo/uJNac1XF8=; b=kiislyOBD3iUhTHjccwpgwVu+AHAlGX1ad47FUIyP7dWoT1amm4nY+dQ98kMiwCTniK7BhHzTEutEsMwV+cIKJTs22Lx7r7jg1l+SG81oCfTBnrNBZJR0JgshzyeNcPw8cJKX+1jyUV79iYAPeFgm6Ey7F+t7FVMTYzd9fHQhJy2v/SFxAQm9HWiwA3ib+vIeR68RO1Q54BgFrEsGoPpPx+JtLvNEvj5XC4MCghuwtRZKy7JoIaV7nSfSqPt8TJ5xKV/n+NOv0pAnmqUpXAqk5XRRpSOwaMem5wT53Kt9aY7eZlS4kdUUYOHDptl1BWkosvkMj+dV7uIQS7bN1iF3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WDKuqcvC7AlVLeucoWBHyztl7KBKwvZVo/uJNac1XF8=; b=PInC0lXGhivAMelWCiL5n5Ci9biOfsq7O0W/8u1bxqsaHQPC8Pa3FY7FIi6RN4sSRK9FqWnNFINv0Q9yVyuWnDA/XNmfCF2/Sktojh6Rw5rJY93FRBWXz25l9eAUGhIzj1Ayjam3CoNqppQZ1pNe5hkoOTWFe3b1fFUCn/mm3DQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Apr 2023 21:50:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v2 11/15] x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-1-andrew.cooper3@citrix.com> <20230404095222.1373721-12-andrew.cooper3@citrix.com> <087536dd-96cf-84f0-4b8f-d4de4d6bd093@suse.com> <0c43546e-0333-af19-efa5-71cfaf5efa3f@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0495.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6176:EE_ X-MS-Office365-Filtering-Correlation-Id: afc277d6-5a40-455f-dab8-08db354e4c2e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XUlKjAF76JH8xR6cCO1fPWYFAHi7R8CAI4N4YPboQfg5PbLzIMnh3kcxia7b/OjHl6fKkMhlv3eCQkyLYvUGI9Nrv1ba0mFrB05Fs7bW6x8mngd812CKT+8+cV3k2Y/VL34h+ILs2MecftC3hFgxZ9TGofT7jSUOXELxltaHhDS9H9ak+WW5dWTH5iy5f1cgQdDl0kBOiTXyMn2oN3jeQdUdWpnJuRDNvGbsUTd+2tYETCNoUv75ycOSfXNmRK8yS4frJbF8BI28tuvMDsMvfp6OXaOcpTCO7iOnA+uQ2KONbc1jasvsN2+aJWqs0z+ohH4rlerJkVk4kFinNRv37CTru/eKwtcvxB/sKdWyrYDs70pjJYY//m9BQ+74t7Mu0eKy3GdPy8EwTWfg615Y9DouvzHFfXtICmxNfRXzwCxrwhdDxfABlXDUivpQUZkZYfeUo9wIYT11+eUtekYHu8Tu/JL1ZnayjJMVeRdP9SD2Ji0WFWfYMw4nk6gLEZdG5UW1qQ+LsYqlGqf0B6u2bRx+bMXifVwgfXFCWiEPzYH49jOVd+ltYvBuQJ/5ZxcXUMssfMTqmcWa/FPWhwzNe/8Q0VMb0QIY9fWaKz73PK0RbNtz0tEcRFVpgwdZAruogZ/NkKKCqhJOYPS9BuhhGg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199021)(2906002)(31696002)(36756003)(31686004)(86362001)(6486002)(2616005)(186003)(6512007)(26005)(53546011)(6506007)(6666004)(66476007)(66946007)(8676002)(6916009)(41300700001)(82960400001)(66556008)(38100700002)(54906003)(5660300002)(478600001)(316002)(4326008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0RMTlZNWm5wYVc1TXMvZFNveU5BUlBYUkxKRXRza05lRDdWcWxRdG56YVVL?= =?utf-8?B?Wlh1RkkyTXZXRGxHZlF0MTQyemEwMFB1dVlwSmh4M2tZWStXK0g5RjFEcUJt?= =?utf-8?B?VFNNY3NsbVVrRllacFRXNWxNTEJLdkMvRGowSExsajNRQkhSQllNbkxaSG1E?= =?utf-8?B?K3V4dHBmZXhiS2RLQnpTNStnMTVwZk8wM2ZvT0E4Q0VGYzBybmlyVlZ6SVA5?= =?utf-8?B?YUd0Sk1BRnZRb015QVRpbVgzOHVhYW9zVnUvNDdqb015bHErMUVpQzM3dlZQ?= =?utf-8?B?Y3prdGNMcG40ZjYzT0luSDlUR3czRjlIVkh6aXZab0RSRjRYMU13TUJaYU1E?= =?utf-8?B?cVdQMHJvOFZyVDFQcVNDanFRSmt4dVUxaUl0MW16Tmt6TzlGeERBaGJHQUZj?= =?utf-8?B?UE5oRndGMzdrMjlvT0FGTlRSM2JWWWZsdmlvQU4yNVJydHVmUXY5RXZVREVu?= =?utf-8?B?TkJFYytud2RpZ1FoQ2MzcXZiVW0zQlllZ0hITzRMdy9mbkVENi84TSs5dTNs?= =?utf-8?B?ZW4vL2pkQ24zM2RaVDJNb2wwVzZQaUF3TEFMWHkzZm5SMGhuMnlaQlNkWDBw?= =?utf-8?B?WWppb3hVejhoQ1phZTBmWEZ2VWZtYmo0ME1wc2ZuZFRlVC9ERUk5Ty84Q1dw?= =?utf-8?B?ZDdzMEhoQU9xajJBR0RaOS9kajhaQXpxN3RpUWZIODBDeUxRdXJ2bjE3Ry8w?= =?utf-8?B?dnc5Y2dkei9LcE1CRWNTczR0aUVsbDdsSTZIOGRYM095ajh0MkM2bWRtMVdp?= =?utf-8?B?a2tLRU5GL3V2ZXkzMmp3TWxsSm9YNGdudjI1QzJpY0NJbjZTeWNZTkswT2Ro?= =?utf-8?B?bHR3V1N2WXI4RmlxZFM0aGtlQmdoZUZha2NzS1VRUUREUGFyL2srM2VNSmhP?= =?utf-8?B?ZVlJU29aR0xEVW5PbE42Q2ZqaXhoaEYvaHBZNFFIL3NIQUJiTWlUUFN5akRr?= =?utf-8?B?aDlXaEdkYTVZbmZJNS9RRjBESFZXaStTemNQNnE1ajdQQkVZcStzQWVnT3By?= =?utf-8?B?R2Rvdk1nTm5OVFJhWEZNOVRaWWJ4Nkc5TDN6VDJ1eGtHT2U0bFVpRVI3TUdy?= =?utf-8?B?Vm55Q2JkeUh1dURmZDB4TWx6aWFoWTBrOW5VYUhuSFQ2RjJLSUptNHpNbGhW?= =?utf-8?B?SHZybzA1OFd4amxGU1pENlRWSHJQRjg1UWtlSGpUWUNzZmJzVkFFRXI0VXJr?= =?utf-8?B?Tkd0YTNYMUxyQ1ltM3pzQXhkS01ORGVxYzRZTHdCaUxzRm55U0dtRlA4YW1Y?= =?utf-8?B?djdHWjIyczY2bkNKejV3T3pUY2YvYlRqdUlYWjdXZTVhWDRsMXVuNmlJRnp1?= =?utf-8?B?SUlqbFZxOGFPelA1NWNYLzF6T0NWeWZEVUt5ZXA2MmlmbnhINXl0QXdGbnNV?= =?utf-8?B?ZDA3RVJ4OFFCM3ZkTjZrVzZaeWFlQ3R5QkhybW5pTEdYcGNpSmJDc0FnYjc2?= =?utf-8?B?UVI3ZUthblI5d1NIRytCRExHT1lRYUdpSDQ4bXp5UHQ5elloQ3FVQlRubTkv?= =?utf-8?B?bENKeFNOS3E0b0FBRzMzUnVQTmJhS3VhQzI5ejMvVkkyMmdhTVRVTkNDNlhP?= =?utf-8?B?UXliVjRKNHRWQUNaZE5RdlhsenNEbjkwT3BuVnN1MEg4UWY1MldhK3FIRkNh?= =?utf-8?B?YmdCVjVjZUpieXJlMEF3d3N0WVlzazBuNTY1bTFzNmwzK0wxNkNwU1BrSFFC?= =?utf-8?B?bDd0QnVEdWlla21oRzBkRUMydGtWNEFjRHF4QUR5M2VPSGxkSVZPZlo5bHNR?= =?utf-8?B?cit5czZncEh5RE9WRUZoSUtET043dlBnQ0U4Njhtd0FsYkRoMlZoZVdKZnhL?= =?utf-8?B?RFZ4clNYYWdSY0t6bG4wc3NLTW9lMllScU05Z1NWMENTUVEzVUVxRHVPWnl5?= =?utf-8?B?WlFKTk8rVjVVUHYzWEJ0M0EzVkc5SnRlUElGdlRob3lDVjlTcTlKc0x1Rzl5?= =?utf-8?B?SDY2c2JCU1prRzlmNGk3aXJMTkc2K2dBVjdUR0ZHK1VVQXZBVUlqTWxPbTVj?= =?utf-8?B?Rm8zWmpRdHpVZkpEczhOck5NbURxdkRJNFo4eDcwNzRQa0I5cGtaUXFpUXo0?= =?utf-8?B?ZTE1ZGVHK1dBblFsd0M3SkY5djBFUXMwQnNtVjVUZWFzZkRkVkNCTnVEeWlh?= =?utf-8?B?TDNCblB0eURpM01QR0pvY29wbDNLVE1acXVLV1dzV2xRRFBONTEzbkIzTUkw?= =?utf-8?B?U0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XFz+MTPEdioA6ii1oehNI6+bzbojB4FnKTvW5EcfqTunHF5eATImcU67Ves7JDxMa5jPVG50p2dsoZK4A6lbyhU74FkRdlQBOgLlLWjMizfTxhbTIrhx3O32P4DddQytI/uywdl41OqBOxQwytTlLv64mqQXVkPhOr62wf+A9fyWAC9V9P2eXiQwMpN+zq/3lvl68Tv3l4jynSRtcNbnp/gY2NTeDoSeI7MNyKhzcrQXX7ZkzHOP3VsRQHPzxxYEqI6UIjqdlPU/5TVdsVFtysLJd6fzOkodn4kdGAUgpkTpnWfl27NVEB0QedI+lRaRyjHtFoOOKufy5KXCJpEnOECUYxRdBENB9x7CZw90rGS+0pxdsf51rm4dFHNZXhB20Kj15p+rsizZ8DHw1fFWEa4D2Gs+2MLe8HctUKClNF7nPdPfZ/8KM/zxDITmcetnEl2WCKEmzrSJctOoAoIbLGP70m8iLop3fXxdLLw7r4wTnEa2PwM1jY7AMzz/LsLSRa0iA/t1jZS+oGxLaFAAWdbqhhKyAxohyN06P+UtarwgXkZBkrvCyBB/MgcdneC6FmgxV6ASlhJbuRO06zoAI4rKSJ1Mbva5xg/I6AwroHAN5rVrsCEnCNA+rzo5nlyOFQ62JwfxOZHEJZKQqe/99dz0gMofMIcB87QQHp/Rk228nGMxqzARENeG3cedKVnBWvODWPgImxMW8pCqOdLR4kLXYeZetQ6tI/pIY3FxYsPU1in5fvxUgoScL3AdlOo1RTMFS0wZhUrrLWnTx9FAt9aKQEdrTA+aA7U/JrkNf6UmvEjv301W+aZYhh7dkWJA X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: afc277d6-5a40-455f-dab8-08db354e4c2e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 20:51:00.6659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZsIuDZu2geNTIV0P+Z7CYFuPJqIKOIgfGsEeqg9uE2RnMWa3/NTzATZMrF/D9GCu6UVPgW2HLhcnE4xZDcR5xvi/CqH6w/gbPlss9s5DLI4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6176 On 04/04/2023 5:14 pm, Jan Beulich wrote: > On 04.04.2023 17:45, Andrew Cooper wrote: >> On 04/04/2023 4:16 pm, Jan Beulich wrote: >>> On 04.04.2023 11:52, Andrew Cooper wrote: >>>> @@ -20,10 +26,332 @@ struct cpu_policy __ro_after_init hvm_max_cpu_policy; >>>> struct cpu_policy __ro_after_init hvm_def_cpu_policy; >>>> #endif >>>> >>>> +const uint32_t known_features[] = INIT_KNOWN_FEATURES; >>>> + >>>> +static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; >>>> +static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; >>>> +static const uint32_t __initconst hvm_hap_max_featuremask[] = >>>> + INIT_HVM_HAP_MAX_FEATURES; >>>> +static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; >>>> +static const uint32_t __initconst hvm_shadow_def_featuremask[] = >>>> + INIT_HVM_SHADOW_DEF_FEATURES; >>>> +static const uint32_t __initconst hvm_hap_def_featuremask[] = >>>> + INIT_HVM_HAP_DEF_FEATURES; >>>> +static const uint32_t deep_features[] = INIT_DEEP_FEATURES; >>>> + >>>> +static const struct feature_name { >>>> + const char *name; >>>> + unsigned int bit; >>>> +} feature_names[] __initconstrel = INIT_FEATURE_NAMES; >>>> + >>>> +/* >>>> + * Parse a list of cpuid feature names -> bool, calling the callback for any >>>> + * matches found. >>>> + * >>>> + * always_inline, because this is init code only and we really don't want a >>>> + * function pointer call in the middle of the loop. >>>> + */ >>>> +static int __init always_inline parse_cpuid( >>>> + const char *s, void (*callback)(unsigned int feat, bool val)) >>>> +{ >>>> + const char *ss; >>>> + int val, rc = 0; >>>> + >>>> + do { >>>> + const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */; >>>> + const char *feat; >>>> + >>>> + ss = strchr(s, ','); >>>> + if ( !ss ) >>>> + ss = strchr(s, '\0'); >>>> + >>>> + /* Skip the 'no-' prefix for name comparisons. */ >>>> + feat = s; >>>> + if ( strncmp(s, "no-", 3) == 0 ) >>>> + feat += 3; >>>> + >>>> + /* (Re)initalise lhs and rhs for binary search. */ >>>> + lhs = feature_names; >>>> + rhs = feature_names + ARRAY_SIZE(feature_names); >>>> + >>>> + while ( lhs < rhs ) >>>> + { >>>> + int res; >>>> + >>>> + mid = lhs + (rhs - lhs) / 2; >>>> + res = cmdline_strcmp(feat, mid->name); >>>> + >>>> + if ( res < 0 ) >>>> + { >>>> + rhs = mid; >>>> + continue; >>>> + } >>>> + if ( res > 0 ) >>>> + { >>>> + lhs = mid + 1; >>>> + continue; >>>> + } >>>> + >>>> + if ( (val = parse_boolean(mid->name, s, ss)) >= 0 ) >>>> + { >>>> + callback(mid->bit, val); >>>> + mid = NULL; >>>> + } >>>> + >>>> + break; >>>> + } >>>> + >>>> + /* >>>> + * Mid being NULL means that the name and boolean were successfully >>>> + * identified. Everything else is an error. >>>> + */ >>>> + if ( mid ) >>>> + rc = -EINVAL; >>>> + >>>> + s = ss + 1; >>>> + } while ( *ss ); >>>> + >>>> + return rc; >>>> +} >>>> + >>>> +static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val) >>>> +{ >>>> + if ( !val ) >>>> + setup_clear_cpu_cap(feat); >>>> + else if ( feat == X86_FEATURE_RDRAND && >>>> + (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) ) >>>> + setup_force_cpu_cap(X86_FEATURE_RDRAND); >>>> +} >>>> + >>>> +static int __init cf_check parse_xen_cpuid(const char *s) >>>> +{ >>>> + return parse_cpuid(s, _parse_xen_cpuid); >>>> +} >>>> +custom_param("cpuid", parse_xen_cpuid); >>>> + >>>> +static bool __initdata dom0_cpuid_cmdline; >>>> +static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; >>>> +static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; >>>> + >>>> +static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) >>>> +{ >>>> + __set_bit (feat, val ? dom0_enable_feat : dom0_disable_feat); >>>> + __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat ); >>>> +} >>>> + >>>> +static int __init cf_check parse_dom0_cpuid(const char *s) >>>> +{ >>>> + dom0_cpuid_cmdline = true; >>>> + >>>> + return parse_cpuid(s, _parse_dom0_cpuid); >>>> +} >>>> +custom_param("dom0-cpuid", parse_dom0_cpuid); >>> Unless the plan is to completely remove cpuid.c, this command line >>> handling would imo better fit there. I understand that to keep >>> dom0_{en,dis}able_feat[] static, the _parse_dom0_cpuid() helper >>> would then need to be exposed (under a different name), but I think >>> that's quite okay, the more that it's an __init function. >> I'm not sure I agree.  (I did debate this for a while before moving the >> cmdline parsing.) >> >> I do have some cleanup plans which will move code into cpuid.c, and >> guest_cpuid() absolutely still lives there, but for these options >> specifically, the moment I add MSR_ARCH_CAPS into a featureset, their >> bit names names will work here too. >> >> So arguably {dom0-}cpuid= don't be a great name moving forwards, but it >> is is absolutely more cpu-policy.c content than cpuid.c content. >> >> We can't get rid of the existing cmdline names, and I think documenting >> our way out of the "it's not only CPUID bits any more" is better than >> adding yet a new name. > Hmm, yes: > Acked-by: Jan Beulich Thanks. > >>>> @@ -149,3 +716,188 @@ int init_domain_cpu_policy(struct domain *d) >>>> >>>> return 0; >>>> } >>>> + >>>> +void recalculate_cpuid_policy(struct domain *d) >>>> +{ >>>> + struct cpu_policy *p = d->arch.cpuid; >>>> + const struct cpu_policy *max = is_pv_domain(d) >>>> + ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) >>>> + : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); >>> While this is how the original code was, wouldn't this want to use >>> hvm_enabled, just like init_guest_cpu_policies() does (patch 10)? >> No.  That will fail to link. > Why? hvm_enabled is a #define (to false) only when !HVM. Hmm, maybe. But honestly, I want to keep the code as it is because this is trying to only be code-movement, and because it's currently symmetric between the two cases. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 21:02:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 21:02:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518148.804381 (Exim 4.92) (envelope-from ) id 1pjnmq-0004qF-NH; Tue, 04 Apr 2023 21:01:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518148.804381; Tue, 04 Apr 2023 21:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnmq-0004q8-Ka; Tue, 04 Apr 2023 21:01:52 +0000 Received: by outflank-mailman (input) for mailman id 518148; Tue, 04 Apr 2023 21:01:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnmp-0004q2-NV for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 21:01:51 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8d75946-d32b-11ed-b464-930f4c7d94ae; Tue, 04 Apr 2023 23:01:47 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-nUUcCrVBN7ilOFNHk6niDw-1; Tue, 04 Apr 2023 17:01:41 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE052185A78F; Tue, 4 Apr 2023 21:01:39 +0000 (UTC) Received: from localhost (unknown [10.39.194.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id 857D82166B26; Tue, 4 Apr 2023 21:01:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8d75946-d32b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680642106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hU59+CgsTGXo7IuR485kJWxhopO+syI1zdWvSx0jC0o=; b=AI9Hyzooera9BZj6dkrOIyvAgCKRsx+3X0Vwe+q8tKnka5KArvHymKdUdovOEaNhZMDbpa /6hcWa6p0r0wODyUjl38WYDI7bg8C+1ein3BFnVgvUGUoS/DvtNPzpgBXU+GRvdOMvvjby MHoNMZTrePbngIVAm2ASy1wpsCCXtOY= X-MC-Unique: nUUcCrVBN7ilOFNHk6niDw-1 Date: Tue, 4 Apr 2023 17:01:36 -0400 From: Stefan Hajnoczi To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Anthony Perard Subject: Re: [PATCH 11/13] block/fuse: take AioContext lock around blk_exp_ref/unref() Message-ID: <20230404210136.GB603232@fedora> References: <20230403183004.347205-1-stefanha@redhat.com> <20230403183004.347205-12-stefanha@redhat.com> <92b731c7-81d4-ef54-cca9-9dcb944e94f0@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="neTXd3RKoERDfsz0" Content-Disposition: inline In-Reply-To: <92b731c7-81d4-ef54-cca9-9dcb944e94f0@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 --neTXd3RKoERDfsz0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2023 at 03:46:34PM +0200, Paolo Bonzini wrote: > On 4/3/23 20:30, Stefan Hajnoczi wrote: > > These functions must be called with the AioContext acquired: > >=20 > > /* Callers must hold exp->ctx lock */ > > void blk_exp_ref(BlockExport *exp) > > ... > > /* Callers must hold exp->ctx lock */ > > void blk_exp_unref(BlockExport *exp) > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > block/export/fuse.c | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/block/export/fuse.c b/block/export/fuse.c > > index 06fa41079e..18394f9e07 100644 > > --- a/block/export/fuse.c > > +++ b/block/export/fuse.c > > @@ -244,7 +244,9 @@ static void read_from_fuse_export(void *opaque) > > FuseExport *exp =3D opaque; > > int ret; > > + aio_context_acquire(exp->common.ctx); > > blk_exp_ref(&exp->common); > > + aio_context_release(exp->common.ctx); > > do { > > ret =3D fuse_session_receive_buf(exp->fuse_session, &exp->fus= e_buf); > > @@ -256,7 +258,9 @@ static void read_from_fuse_export(void *opaque) > > fuse_session_process_buf(exp->fuse_session, &exp->fuse_buf); > > out: > > + aio_context_acquire(exp->common.ctx); > > blk_exp_unref(&exp->common); > > + aio_context_release(exp->common.ctx); > > } >=20 > Since the actual thread-unsafe work is done in a bottom half, perhaps > instead you can use qatomic_inc and qatomic_fetch_dec in > blk_exp_{ref,unref}? Sure, I'll give that a try in the next revision. Stefan --neTXd3RKoERDfsz0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmQskC8ACgkQnKSrs4Gr c8ge+Af/fN0G3NFCPv1dW59nNxnKDFCC+GIm48Kk+qOWta6oggk2ADk7czgcS3fN BHk3zVgrvaoGZ8seFxN3CqKsCfYCFCkcws2IzVErHRIGpVCN6kpakDinR244u+cF qRwtk+ME1+Yv+IcOEk/Lj+UfS6YUD0TLY8LxfbjlsQFQV5RlsRY2/f+4FzbWrFJx +9dicHDGkWs35LeabbAWl/mki6TGMh2/APr8a87gMlRHONc4gG/ZcDOdWj+Dg9bz ODgE6eDuf/dHMk/xrfGzwRUly4gTrZLIUZ5ADes+ZhUipijL/8fSQ35gW2tTVzNC 8shYSvBKrBNF6oFfIUluQ/7doZbp0g== =85Ek -----END PGP SIGNATURE----- --neTXd3RKoERDfsz0-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 21:04:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 21:04:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518152.804392 (Exim 4.92) (envelope-from ) id 1pjnpl-0005PG-4F; Tue, 04 Apr 2023 21:04:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518152.804392; Tue, 04 Apr 2023 21:04:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnpl-0005P9-1P; Tue, 04 Apr 2023 21:04:53 +0000 Received: by outflank-mailman (input) for mailman id 518152; Tue, 04 Apr 2023 21:04:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnpk-0005P1-3e for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 21:04:52 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56876968-d32c-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 23:04:51 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-550-DimVpMkPOYuLTzIRXxdNzg-1; Tue, 04 Apr 2023 17:04:45 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 74F9B887400; Tue, 4 Apr 2023 21:04:44 +0000 (UTC) Received: from localhost (unknown [10.39.194.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEA78C35999; Tue, 4 Apr 2023 21:04:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56876968-d32c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680642290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nzP6fmPsLpxmtr/dHctXT699XVp9501+3aNzUwPLVNM=; b=cYMzFtJ+W6fEGyny5QnxWoAs17dHAjvd/g+STtG7QlTGiiYriSWNJaj6fITNe69asaYeft 0QXhIbI9B9rcDw+yCL9/yx9lVhU7i6mEA5wRcr5GOZW65eHKLLfIylle4SMA/gWAeRsWwx 9/jgU39MnuojQP+GPqr/uv7OZAymb1M= X-MC-Unique: DimVpMkPOYuLTzIRXxdNzg-1 Date: Tue, 4 Apr 2023 17:04:42 -0400 From: Stefan Hajnoczi To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Julia Suvorova , Kevin Wolf , Peter Lieven , Coiby Xu , xen-devel@lists.xenproject.org, Richard Henderson , Stefano Garzarella , qemu-block@nongnu.org, Eduardo Habkost , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Paul Durrant , "Richard W.M. Jones" , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Aarushi Mehta , Stefano Stabellini , Fam Zheng , David Woodhouse , Stefan Weil , Juan Quintela , Xie Yongji , Hanna Reitz , Ronnie Sahlberg , eesposit@redhat.com, "Michael S. Tsirkin" , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Anthony Perard Subject: Re: [PATCH 00/13] block: remove aio_disable_external() API Message-ID: <20230404210442.GC603232@fedora> References: <20230403183004.347205-1-stefanha@redhat.com> <261efade-683e-84dc-d402-7143be7199c3@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="snMIsWYZfG/EJhXo" Content-Disposition: inline In-Reply-To: <261efade-683e-84dc-d402-7143be7199c3@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 --snMIsWYZfG/EJhXo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2023 at 03:43:20PM +0200, Paolo Bonzini wrote: > On 4/3/23 20:29, Stefan Hajnoczi wrote: > > The aio_disable_external() API temporarily suspends file descriptor mon= itoring > > in the event loop. The block layer uses this to prevent new I/O request= s being > > submitted from the guest and elsewhere between bdrv_drained_begin() and > > bdrv_drained_end(). > >=20 > > While the block layer still needs to prevent new I/O requests in drained > > sections, the aio_disable_external() API can be replaced with > > .drained_begin/end/poll() callbacks that have been added to BdrvChildCl= ass and > > BlockDevOps. > >=20 > > This newer .bdrained_begin/end/poll() approach is attractive because it= works > > without specifying a specific AioContext. The block layer is moving tow= ards > > multi-queue and that means multiple AioContexts may be processing I/O > > simultaneously. > >=20 > > The aio_disable_external() was always somewhat hacky. It suspends all f= ile > > descriptors that were registered with is_external=3Dtrue, even if they = have > > nothing to do with the BlockDriverState graph nodes that are being drai= ned. > > It's better to solve a block layer problem in the block layer than to h= ave an > > odd event loop API solution. > >=20 > > That covers the motivation for this change, now on to the specifics of = this > > series: > >=20 > > While it would be nice if a single conceptual approach could be applied= to all > > is_external=3Dtrue file descriptors, I ended up looking at callers on a > > case-by-case basis. There are two general ways I migrated code away from > > is_external=3Dtrue: > >=20 > > 1. Block exports are typically best off unregistering fds in .drained_b= egin() > > and registering them again in .drained_end(). The .drained_poll() f= unction > > waits for in-flight requests to finish using a reference counter. > >=20 > > 2. Emulated storage controllers like virtio-blk and virtio-scsi are a l= ittle > > simpler. They can rely on BlockBackend's request queuing during dra= in > > feature. Guest I/O request coroutines are suspended in a drained se= ction and > > resume upon the end of the drained section. >=20 > Sorry, I disagree with this. >=20 > Request queuing was shown to cause deadlocks; Hanna's latest patch is pil= ing > another hack upon it, instead in my opinion we should go in the direction= of > relying _less_ (or not at all) on request queuing. >=20 > I am strongly convinced that request queuing must apply only after > bdrv_drained_begin has returned, which would also fix the IDE TRIM bug > reported by Fiona Ebner. The possible livelock scenario is generally not= a > problem because 1) outside an iothread you have anyway the BQL that preve= nts > a vCPU from issuing more I/O operations during bdrv_drained_begin 2) in > iothreads you have aio_disable_external() instead of .drained_begin(). >=20 > It is also less tidy to start a request during the drained_begin phase, > because a request that has been submitted has to be completed (cancel > doesn't really work). >=20 > So in an ideal world, request queuing would not only apply only after > bdrv_drained_begin has returned, it would log a warning and .drained_begi= n() > should set up things so that there are no such warnings. That's fine, I will give .drained_begin/end/poll() a try with virtio-blk and virtio-scsi in the next revision. Stefan --snMIsWYZfG/EJhXo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmQskOoACgkQnKSrs4Gr c8jsQAf+PJyaSj96NmHb9lkSsM0rDSEoQ56fJV7vTR+eUUuvgwbRl1u07Nrka9s6 mwJjQLVUZpsLuOTCC1ZOvePeeo0daHHZ6pkLMI9xTh2noy8/ka3KUSkbYAE2y8+/ CYqbu19QuEIEEjjPEXl7xda50dSz16N27J+A367ZKS2jcB+p4hr73gII1vLwCnbi 3xuLsNRy/f9mcOiv+30w/fiGLxmVDYlq/5msaY5JlLkNzbeAWC4s06Pcvoxa71Jr RgB1YLWcwI5x+AIZQ6Je1bZyK5beUHJGxIKEkAq5CyiaDaBCwRpoiuFAbI4lXz4X 2Pwa17IPZ6Zgqvf4L6E9LAMB/nCygA== =UdcK -----END PGP SIGNATURE----- --snMIsWYZfG/EJhXo-- From xen-devel-bounces@lists.xenproject.org Tue Apr 04 21:06:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 21:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518156.804402 (Exim 4.92) (envelope-from ) id 1pjnr6-0005zD-FP; Tue, 04 Apr 2023 21:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518156.804402; Tue, 04 Apr 2023 21:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnr6-0005z6-CO; Tue, 04 Apr 2023 21:06:16 +0000 Received: by outflank-mailman (input) for mailman id 518156; Tue, 04 Apr 2023 21:06:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjnr5-0005yw-3x for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 21:06:15 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86d294f0-d32c-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 23:06:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86d294f0-d32c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680642372; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SZkHVZ2NWT/4Tsj7fqIvLvzNKb7GyKuoPQiH3xqCu+A=; b=IkzEPp7N7dzi8H/BX/JnfrFqHorwdvXIOJVrT6Bjo/DYdE3oZtPAQaw+ 7jAGaOk9r0uiiUHpRQyJW7YwPZ+gvWo/aoANm8UTT9VppE9v37wPkQokm 8N9cNVWeWtWm6aiMOTnqUstFVo7zas5O0fE40/K0CQl1aS7cA0CCMR1ri Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104742219 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:FAAa7aI4UetFx3TcFE+RrZUlxSXFcZb7ZxGr2PjKsXjdYENS0jJSn zNKDW3VaP3eZ2ugf99xboyw8ElXup/Sm9JjGVFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRiPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5HAH8S2 eQCLAkpUQ2CmNK68papFLlj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TTHZkKwhzC/ zOuE2LRLBQHDOeVzSi/3TH3n8GXtBrHf743LejtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4oj+7hudB2MEZiVcc9Fgv8gzLQHGz XfQwYmvX2Y29uTIFzTErOz8QS6O1TY9HW4cOQMcVw88x+b+oZ4DgiDrXIgzH/vg5jHqIg0c0 wxmvQBn2eVL05ZXjPTnlbzUq2ny/8aUF2bZ8i2SBzv4tV0hOeZJcqTysTDmAeB8wJF1p7Vrl FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/LF7rVxBA1b5IehtDMhWfS+FyPosdz7ze 1P0sghM/pJVN3bCRfYpM9rvUJ9wnPOwRIyNuhXogj1mO8EZSeN61Hs2OR74M57FyyDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDuJLbiilkTP7FZrTCLNIVvzGAfUP79RAWLtiFm9z uuzwOPTkk4GD7WhMni/HEx6BQliEEXXzKve86R/HtNv6CI8cI39I5c9GY8cRrE= IronPort-HdrOrdr: A9a23:+dSzMKiU91avdV2rpsYin75tXHBQXioji2hC6mlwRA09TyX5ra 2TdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKF+Vzd8kXFndK1vp 0QEZSWZueRMbEAt7ec3OG5eexQvOVu8sqT9JjjJ6EGd3AVV0lihT0JezpyCidNNW977QJSLu vn2iJAzQDQAEg/X4CAKVQuefPMnNHPnIKOW296O/Z2gDP+9Q9B8dTBYmOl4is= X-IronPort-AV: E=Sophos;i="5.98,318,1673931600"; d="scan'208";a="104742219" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3] libx86: Update library API for cpu_policy Date: Tue, 4 Apr 2023 22:06:00 +0100 Message-ID: <20230404210600.1404532-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230404095222.1373721-15-andrew.cooper3@citrix.com> References: <20230404095222.1373721-15-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Adjust the API and comments appropriately. x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a TODO in the short term. No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New v3: * Update x86_cpu_policy_lookup_deep_deps() too and write an API doc. --- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 4 +- tools/tests/cpu-policy/test-cpu-policy.c | 4 +- tools/tests/x86_emulator/x86-emulate.c | 2 +- xen/arch/x86/cpu-policy.c | 4 +- xen/arch/x86/cpu/common.c | 2 +- xen/arch/x86/domctl.c | 2 +- xen/arch/x86/xstate.c | 4 +- xen/include/xen/lib/x86/cpu-policy.h | 49 +++++++++++++---------- xen/lib/x86/cpuid.c | 26 ++++++------ xen/lib/x86/msr.c | 4 +- 10 files changed, 55 insertions(+), 46 deletions(-) diff --git a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c index 466bdbb1d91a..7d8467b4b258 100644 --- a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c +++ b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c @@ -48,8 +48,8 @@ static void check_policy(struct cpu_policy *cp) * Fix up the data in the source policy which isn't expected to survive * serialisation. */ - x86_cpuid_policy_clear_out_of_range_leaves(cp); - x86_cpuid_policy_recalc_synth(cp); + x86_cpu_policy_clear_out_of_range_leaves(cp); + x86_cpu_policy_recalc_synth(cp); /* Serialise... */ rc = x86_cpuid_copy_to_buffer(cp, leaves, &nr_leaves); diff --git a/tools/tests/cpu-policy/test-cpu-policy.c b/tools/tests/cpu-policy/test-cpu-policy.c index a4ca07f33973..f1d968adfc39 100644 --- a/tools/tests/cpu-policy/test-cpu-policy.c +++ b/tools/tests/cpu-policy/test-cpu-policy.c @@ -105,7 +105,7 @@ static void test_cpuid_current(void) printf("Testing CPUID on current CPU\n"); - x86_cpuid_policy_fill_native(&p); + x86_cpu_policy_fill_native(&p); rc = x86_cpuid_copy_to_buffer(&p, leaves, &nr); if ( rc != 0 ) @@ -554,7 +554,7 @@ static void test_cpuid_out_of_range_clearing(void) void *ptr; unsigned int nr_markers; - x86_cpuid_policy_clear_out_of_range_leaves(p); + x86_cpu_policy_clear_out_of_range_leaves(p); /* Count the number of 0xc2's still remaining. */ for ( ptr = p, nr_markers = 0; diff --git a/tools/tests/x86_emulator/x86-emulate.c b/tools/tests/x86_emulator/x86-emulate.c index 2692404df906..7d2d57f7591a 100644 --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -75,7 +75,7 @@ bool emul_test_init(void) unsigned long sp; - x86_cpuid_policy_fill_native(&cp); + x86_cpu_policy_fill_native(&cp); /* * The emulator doesn't use these instructions, so can always emulate diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 83186e940ca7..a58bf6cad54e 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -176,7 +176,7 @@ static void sanitise_featureset(uint32_t *fs) for_each_set_bit(i, (void *)disabled_features, sizeof(disabled_features) * 8) { - const uint32_t *dfs = x86_cpuid_lookup_deep_deps(i); + const uint32_t *dfs = x86_cpu_policy_lookup_deep_deps(i); unsigned int j; ASSERT(dfs); /* deep_features[] should guarentee this. */ @@ -347,7 +347,7 @@ static void __init calculate_raw_policy(void) { struct cpu_policy *p = &raw_cpu_policy; - x86_cpuid_policy_fill_native(p); + x86_cpu_policy_fill_native(p); /* Nothing good will come from Xen and libx86 disagreeing on vendor. */ ASSERT(p->x86_vendor == boot_cpu_data.x86_vendor); diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index f11dcda57a69..edc4db1335eb 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -75,7 +75,7 @@ void __init setup_clear_cpu_cap(unsigned int cap) __builtin_return_address(0), cap); __clear_bit(cap, boot_cpu_data.x86_capability); - dfs = x86_cpuid_lookup_deep_deps(cap); + dfs = x86_cpu_policy_lookup_deep_deps(cap); if (!dfs) return; diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index c02528594102..1a8b4cff48ee 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -66,7 +66,7 @@ static int update_domain_cpu_policy(struct domain *d, goto out; /* Trim any newly-stale out-of-range leaves. */ - x86_cpuid_policy_clear_out_of_range_leaves(new); + x86_cpu_policy_clear_out_of_range_leaves(new); /* Audit the combined dataset. */ ret = x86_cpu_policies_are_compatible(sys, new, &err); diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index d481e1db3e7e..92496f379546 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -684,7 +684,7 @@ void xstate_init(struct cpuinfo_x86 *c) int validate_xstate(const struct domain *d, uint64_t xcr0, uint64_t xcr0_accum, const struct xsave_hdr *hdr) { - uint64_t xcr0_max = cpuid_policy_xcr0_max(d->arch.cpuid); + uint64_t xcr0_max = cpu_policy_xcr0_max(d->arch.cpuid); unsigned int i; if ( (hdr->xstate_bv & ~xcr0_accum) || @@ -708,7 +708,7 @@ int validate_xstate(const struct domain *d, uint64_t xcr0, uint64_t xcr0_accum, int handle_xsetbv(u32 index, u64 new_bv) { struct vcpu *curr = current; - uint64_t xcr0_max = cpuid_policy_xcr0_max(curr->domain->arch.cpuid); + uint64_t xcr0_max = cpu_policy_xcr0_max(curr->domain->arch.cpuid); u64 mask; if ( index != XCR_XFEATURE_ENABLED_MASK ) diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 57b4633c861e..cf7de0f29ccd 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -399,33 +399,38 @@ void x86_cpu_policy_to_featureset(const struct cpu_policy *p, void x86_cpu_featureset_to_policy(const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpu_policy *p); -static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p) +static inline uint64_t cpu_policy_xcr0_max(const struct cpu_policy *p) { return ((uint64_t)p->xstate.xcr0_high << 32) | p->xstate.xcr0_low; } -static inline uint64_t cpuid_policy_xstates(const struct cpuid_policy *p) +static inline uint64_t cpu_policy_xstates(const struct cpu_policy *p) { uint64_t val = p->xstate.xcr0_high | p->xstate.xss_high; return (val << 32) | p->xstate.xcr0_low | p->xstate.xss_low; } -const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature); +/** + * For a specific feature, look up the dependent features. Returns NULL if + * this feature has no dependencies. Otherwise return a featureset of + * dependent features, which has been recursively flattened. + */ +const uint32_t *x86_cpu_policy_lookup_deep_deps(uint32_t feature); /** - * Recalculate the content in a CPUID policy which is derived from raw data. + * Recalculate the content in a CPU policy which is derived from raw data. */ -void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p); +void x86_cpu_policy_recalc_synth(struct cpu_policy *p); /** - * Fill a CPUID policy using the native CPUID instruction. + * Fill CPU policy using the native CPUID/RDMSR instruction. * * No sanitisation is performed, but synthesised values are calculated. * Values may be influenced by a hypervisor or from masking/faulting * configuration. */ -void x86_cpuid_policy_fill_native(struct cpuid_policy *p); +void x86_cpu_policy_fill_native(struct cpu_policy *p); /** * Clear leaf data beyond the policies max leaf/subleaf settings. @@ -436,7 +441,7 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p); * with out-of-range leaves with stale content in them. This helper clears * them. */ -void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p); +void x86_cpu_policy_clear_out_of_range_leaves(struct cpu_policy *p); #ifdef __XEN__ #include @@ -449,9 +454,10 @@ typedef xen_msr_entry_t msr_entry_buffer_t[]; #endif /** - * Serialise a cpuid_policy object into an array of cpuid leaves. + * Serialise the CPUID leaves of a cpu_policy object into an array of cpuid + * leaves. * - * @param policy The cpuid_policy to serialise. + * @param policy The cpu_policy to serialise. * @param leaves The array of leaves to serialise into. * @param nr_entries The number of entries in 'leaves'. * @returns -errno @@ -460,13 +466,14 @@ typedef xen_msr_entry_t msr_entry_buffer_t[]; * leaves array is too short. On success, nr_entries is updated with the * actual number of leaves written. */ -int x86_cpuid_copy_to_buffer(const struct cpuid_policy *policy, +int x86_cpuid_copy_to_buffer(const struct cpu_policy *policy, cpuid_leaf_buffer_t leaves, uint32_t *nr_entries); /** - * Unserialise a cpuid_policy object from an array of cpuid leaves. + * Unserialise the CPUID leaves of a cpu_policy object into an array of cpuid + * leaves. * - * @param policy The cpuid_policy to unserialise into. + * @param policy The cpu_policy to unserialise into. * @param leaves The array of leaves to unserialise from. * @param nr_entries The number of entries in 'leaves'. * @param err_leaf Optional hint for error diagnostics. @@ -474,21 +481,21 @@ int x86_cpuid_copy_to_buffer(const struct cpuid_policy *policy, * @returns -errno * * Reads at most CPUID_MAX_SERIALISED_LEAVES. May return -ERANGE if an - * incoming leaf is out of range of cpuid_policy, in which case the optional + * incoming leaf is out of range of cpu_policy, in which case the optional * err_* pointers will identify the out-of-range indicies. * * No content validation of in-range leaves is performed. Synthesised data is * recalculated. */ -int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, +int x86_cpuid_copy_from_buffer(struct cpu_policy *policy, const cpuid_leaf_buffer_t leaves, uint32_t nr_entries, uint32_t *err_leaf, uint32_t *err_subleaf); /** - * Serialise an msr_policy object into an array. + * Serialise the MSRs of a cpu_policy object into an array. * - * @param policy The msr_policy to serialise. + * @param policy The cpu_policy to serialise. * @param msrs The array of msrs to serialise into. * @param nr_entries The number of entries in 'msrs'. * @returns -errno @@ -497,13 +504,13 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *policy, * buffer array is too short. On success, nr_entries is updated with the * actual number of msrs written. */ -int x86_msr_copy_to_buffer(const struct msr_policy *policy, +int x86_msr_copy_to_buffer(const struct cpu_policy *policy, msr_entry_buffer_t msrs, uint32_t *nr_entries); /** - * Unserialise an msr_policy object from an array of msrs. + * Unserialise the MSRs of a cpu_policy object from an array of msrs. * - * @param policy The msr_policy object to unserialise into. + * @param policy The cpu_policy object to unserialise into. * @param msrs The array of msrs to unserialise from. * @param nr_entries The number of entries in 'msrs'. * @param err_msr Optional hint for error diagnostics. @@ -517,7 +524,7 @@ int x86_msr_copy_to_buffer(const struct msr_policy *policy, * * No content validation is performed on the data stored in the policy object. */ -int x86_msr_copy_from_buffer(struct msr_policy *policy, +int x86_msr_copy_from_buffer(struct cpu_policy *policy, const msr_entry_buffer_t msrs, uint32_t nr_entries, uint32_t *err_msr); diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index 734e90823a63..68aafb404927 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -102,13 +102,13 @@ void x86_cpu_featureset_to_policy( p->feat._7d1 = fs[FEATURESET_7d1]; } -void x86_cpuid_policy_recalc_synth(struct cpuid_policy *p) +void x86_cpu_policy_recalc_synth(struct cpu_policy *p) { p->x86_vendor = x86_cpuid_lookup_vendor( p->basic.vendor_ebx, p->basic.vendor_ecx, p->basic.vendor_edx); } -void x86_cpuid_policy_fill_native(struct cpuid_policy *p) +void x86_cpu_policy_fill_native(struct cpu_policy *p) { unsigned int i; @@ -199,7 +199,7 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p) cpuid_count_leaf(0xd, 0, &p->xstate.raw[0]); cpuid_count_leaf(0xd, 1, &p->xstate.raw[1]); - xstates = cpuid_policy_xstates(p); + xstates = cpu_policy_xstates(p); /* This logic will probably need adjusting when XCR0[63] gets used. */ BUILD_BUG_ON(ARRAY_SIZE(p->xstate.raw) > 63); @@ -222,10 +222,12 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p) p->hv_limit = 0; p->hv2_limit = 0; - x86_cpuid_policy_recalc_synth(p); + /* TODO MSRs */ + + x86_cpu_policy_recalc_synth(p); } -void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) +void x86_cpu_policy_clear_out_of_range_leaves(struct cpu_policy *p) { unsigned int i; @@ -260,7 +262,7 @@ void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) zero_leaves(p->topo.raw, i, ARRAY_SIZE(p->topo.raw) - 1); } - if ( p->basic.max_leaf < 0xd || !cpuid_policy_xstates(p) ) + if ( p->basic.max_leaf < 0xd || !cpu_policy_xstates(p) ) memset(p->xstate.raw, 0, sizeof(p->xstate.raw)); else { @@ -268,7 +270,7 @@ void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) BUILD_BUG_ON(ARRAY_SIZE(p->xstate.raw) > 63); /* First two leaves always valid. Rest depend on xstates. */ - i = max(2, 64 - __builtin_clzll(cpuid_policy_xstates(p))); + i = max(2, 64 - __builtin_clzll(cpu_policy_xstates(p))); zero_leaves(p->xstate.raw, i, ARRAY_SIZE(p->xstate.raw) - 1); @@ -278,7 +280,7 @@ void x86_cpuid_policy_clear_out_of_range_leaves(struct cpuid_policy *p) ARRAY_SIZE(p->extd.raw) - 1); } -const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature) +const uint32_t *x86_cpu_policy_lookup_deep_deps(uint32_t feature) { static const uint32_t deep_features[] = INIT_DEEP_FEATURES; static const struct { @@ -333,7 +335,7 @@ static int copy_leaf_to_buffer(uint32_t leaf, uint32_t subleaf, return 0; } -int x86_cpuid_copy_to_buffer(const struct cpuid_policy *p, +int x86_cpuid_copy_to_buffer(const struct cpu_policy *p, cpuid_leaf_buffer_t leaves, uint32_t *nr_entries_p) { const uint32_t nr_entries = *nr_entries_p; @@ -383,7 +385,7 @@ int x86_cpuid_copy_to_buffer(const struct cpuid_policy *p, case 0xd: { - uint64_t xstates = cpuid_policy_xstates(p); + uint64_t xstates = cpu_policy_xstates(p); COPY_LEAF(leaf, 0, &p->xstate.raw[0]); COPY_LEAF(leaf, 1, &p->xstate.raw[1]); @@ -419,7 +421,7 @@ int x86_cpuid_copy_to_buffer(const struct cpuid_policy *p, return 0; } -int x86_cpuid_copy_from_buffer(struct cpuid_policy *p, +int x86_cpuid_copy_from_buffer(struct cpu_policy *p, const cpuid_leaf_buffer_t leaves, uint32_t nr_entries, uint32_t *err_leaf, uint32_t *err_subleaf) @@ -522,7 +524,7 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *p, } } - x86_cpuid_policy_recalc_synth(p); + x86_cpu_policy_recalc_synth(p); return 0; diff --git a/xen/lib/x86/msr.c b/xen/lib/x86/msr.c index c4d885e7b568..e04b9ca01302 100644 --- a/xen/lib/x86/msr.c +++ b/xen/lib/x86/msr.c @@ -23,7 +23,7 @@ static int copy_msr_to_buffer(uint32_t idx, uint64_t val, return 0; } -int x86_msr_copy_to_buffer(const struct msr_policy *p, +int x86_msr_copy_to_buffer(const struct cpu_policy *p, msr_entry_buffer_t msrs, uint32_t *nr_entries_p) { const uint32_t nr_entries = *nr_entries_p; @@ -48,7 +48,7 @@ int x86_msr_copy_to_buffer(const struct msr_policy *p, return 0; } -int x86_msr_copy_from_buffer(struct msr_policy *p, +int x86_msr_copy_from_buffer(struct cpu_policy *p, const msr_entry_buffer_t msrs, uint32_t nr_entries, uint32_t *err_msr) { -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Apr 04 21:29:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 21:29:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518162.804411 (Exim 4.92) (envelope-from ) id 1pjoDQ-00008i-Dn; Tue, 04 Apr 2023 21:29:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518162.804411; Tue, 04 Apr 2023 21:29:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoDQ-00008b-B2; Tue, 04 Apr 2023 21:29:20 +0000 Received: by outflank-mailman (input) for mailman id 518162; Tue, 04 Apr 2023 21:29:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoDO-00008P-ID; Tue, 04 Apr 2023 21:29:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoDO-0007a2-Er; Tue, 04 Apr 2023 21:29:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoDO-0000I2-0U; Tue, 04 Apr 2023 21:29:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjoDO-0006sT-02; Tue, 04 Apr 2023 21:29:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3nsbpyvV8cjcptqjQ7Ew7Ma4IEDCW/Qt4OJrV0bNQmU=; b=qJ+h/1t9wqUMb6LXvzIjXuK19P njbdecVdmZ7M1s18BEUDBZVr+0gyKPXuzdOagDvaeK13PNITYFBxBiPS3pZqRmt3F3qOig2oWzd+w dt4GX+CXpaFeXleN6/B1yCsDrjuNNbanc/I2+Y2OnpWlCYZfKRvs0ciLNKWJSc2WRHd4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180141: all pass - PUSHED X-Osstest-Versions-This: ovmf=7df447930c42addaf2cc0d32916141d95ded677e X-Osstest-Versions-That: ovmf=fb89f62d2702faf7db7f7afef342467d4f0fba3c From: osstest service owner Date: Tue, 04 Apr 2023 21:29:18 +0000 flight 180141 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180141/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7df447930c42addaf2cc0d32916141d95ded677e baseline version: ovmf fb89f62d2702faf7db7f7afef342467d4f0fba3c Last test of basis 180138 2023-04-04 15:10:48 Z 0 days Testing same since 180141 2023-04-04 17:42:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fb89f62d27..7df447930c 7df447930c42addaf2cc0d32916141d95ded677e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Apr 04 21:41:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 21:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518168.804422 (Exim 4.92) (envelope-from ) id 1pjoP5-0002ZD-Hn; Tue, 04 Apr 2023 21:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518168.804422; Tue, 04 Apr 2023 21:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoP5-0002Z6-Eq; Tue, 04 Apr 2023 21:41:23 +0000 Received: by outflank-mailman (input) for mailman id 518168; Tue, 04 Apr 2023 21:41:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoP3-0002Yw-99; Tue, 04 Apr 2023 21:41:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoP3-0007wZ-3X; Tue, 04 Apr 2023 21:41:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoP2-0000pd-SU; Tue, 04 Apr 2023 21:41:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjoP2-0000wk-Ry; Tue, 04 Apr 2023 21:41:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R1thnMV2UW1eOgIhj7W2vBfzbZkG2iiyfLzU8SqQdQw=; b=Y9zvq2B7gUFQbkIw7MKcIFpYU/ IIxeyb2/z+yplktTbT0hs5Y0sM5ORuOvxZy+GVeuk41HP8GDgrk1RONTVMamkmoIhRRZm0T7b0Fcd HwsI+SXRLUHS08AMzUu81VDDISTTZ7VxU0TAgut7/TdWDCpocq50dX57iduWWcQXN2ZM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180143: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 X-Osstest-Versions-That: xen=658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e From: osstest service owner Date: Tue, 04 Apr 2023 21:41:20 +0000 flight 180143 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180143/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 baseline version: xen 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e Last test of basis 180137 2023-04-04 14:03:39 Z 0 days Testing same since 180140 2023-04-04 17:01:55 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 658fcb7ac9..415f7d9404 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Apr 04 21:54:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 21:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518174.804432 (Exim 4.92) (envelope-from ) id 1pjoby-00047h-OD; Tue, 04 Apr 2023 21:54:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518174.804432; Tue, 04 Apr 2023 21:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjoby-00047a-Km; Tue, 04 Apr 2023 21:54:42 +0000 Received: by outflank-mailman (input) for mailman id 518174; Tue, 04 Apr 2023 21:54:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjobx-00047T-0I for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 21:54:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4af19420-d333-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 23:54:38 +0200 (CEST) Received: from mail-dm6nam04lp2040.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Apr 2023 17:54:13 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6387.namprd03.prod.outlook.com (2603:10b6:806:1c2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 21:54:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 21:54:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4af19420-d333-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680645278; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=9ZabhdgXSSrBvWvumOUTfZeknY8WfKfHQ46NHrpbX7k=; b=T8UVvalobsGjTF4yqjXPU5rD1D/ARvgJEKkr8xwycMMYrsDzD8MLjc6/ TiSCwOfysvjEIFlLXpnwej8Sugxwm4mBd2Ros4lq1E2VXBOtdQ6qXk9KW Cq/7aKe5NccuBJBhmWJKfsNpIOgGyEHTQ1/0WSVHkv70WTUMn47JFReHm M=; X-IronPort-RemoteIP: 104.47.73.40 X-IronPort-MID: 104746601 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aGnFs6OJgx50ehfvrR2IlsFynXyQoLVcMsEvi/4bfWQNrUoj1WYHz WBJXTyPaa3bZDemLt4kPYTk8U5UupXVmNAwHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gBmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sUuOk9Pp e0fFDQQdCKpg+Cz4rj4UMA506zPLOGzVG8ekldJ6GmFSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxvzC7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwXynBtxKTdVU8NZQnnax4DcQDSQGVHS0p/7ktErmRJF2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBQQ5b5dDm+N03lkiXEo4lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bzgbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:J6Ok6K0dEx/5TNQAXjYPgwqjBIIkLtp133Aq2lEZdPUzSKClfq GV88jzsCWetN9/Yh8dcLy7WZVoI0mslqKdkLNwAV7KZmCP0gaVxedZnO7fKlbbak/DH4BmpM FdWpk7JNrsDUVryebWiTPIaurIGeP3lJxAU92uqEtQcQ== X-IronPort-AV: E=Sophos;i="5.98,319,1673931600"; d="scan'208";a="104746601" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfH9SsgOx/ZeREsVz8Hab5u5UhAcj+Z2iq5n/jncm5e17uW0Dq6ueRdrOBL+Diyx+kLU7wL1Upb3YgVhlMe4Eh3CYHyLSWqW5E97bRRNzyMV4sE4Am6KR8jKSiTuABcDygtQ3mRmx+dBRC3oNjlM3GfcxOzlgTIsFuCtL8uU4VOHTVnKtTQeL6xizUCC8fkgXZcOtJ/qiWyZPcWQ6k7HD9plMQGeHk8QPRBVUY/Bp8uvAIzB3boPZz/QOjUr/Uys1tgd+sCRSQHSb9jqbdWrt0CN2QWl4C7+T//6VBxZ3pawpSceQhwP0w14JENuC1XNN58uy3NLOT/MzUyMMAi+Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93vfan2gsno1DCeqXREVT5h6NSIC8R4Twl29c7aP6Js=; b=Cm8dYvRAb3/24djSiEWENn3XfuoXr1ty5Xo7TvmGLTv8wQIeW+CxZ4itd50W9ElinYgrY1Bf3/St7r3sABdEGV2sdQsyE6BMRZTCosPBNcSqmq5ZVxj8Z9aJHwZdTQAAn/SA5efshvhTydxEjjzdovpVZ1tIrakbLQ78jbBJ8pux8JVjv7ickzqfkSJWOFhcuFNI+aBAlK1UH+BK8lQ6OUP0IUJdJ1zh/pDs9ZuWBnPvi74DCydBierEBEAx4qgsgAYRwZNpPVbVQ+3pyu16w6WgFZAb+2ZsbyntqaX/44Ry8ntQJqRV38QVUw/OFI4YW+Lj82ih3AStLd4e6WySsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93vfan2gsno1DCeqXREVT5h6NSIC8R4Twl29c7aP6Js=; b=H9A6pqwWufacSJRIvj+05gR/t5sOu9t5PhoE+y8etv9+5c68HH1X/ic+uyHlWP3VtlK0N2aKKdVKiMZmqmfWpQqahdatubiipaJPoSaXusQB5n16boG4S3zVE+2O6Z0TPUlwUDGMeO3ZXUxKryV9UPAvHKotsx8cq55wvLHYgXg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Apr 2023 22:54:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 1/9] x86emul: support LKGS Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1eb21ece-9d33-d8e1-1c2b-c682dbb1cda1@suse.com> In-Reply-To: <1eb21ece-9d33-d8e1-1c2b-c682dbb1cda1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO0P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6387:EE_ X-MS-Office365-Filtering-Correlation-Id: 81c19b71-470e-415a-c6ad-08db35571f01 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vb0CtKbU3ol0ffgjokJh203s58Ccmj3YgkzJnl6h4/0CNxw7ivyVR5gj+I63yyMQickV8AnRXGP2Ql4F6MoBU/prpbjT80wUk5p7O2byhc7YxHAk0Bsi4pmQiiiiIlxAqwrGVrdjEyv+EV+8ypHfAX9iwtFDoU4pIHBkQAT0N3Ms5nlHI9F5upNgSIKH9/D5UPFHuCu2sDtAYlCKtP+NPMNlfHGU6BhG77jtctoUqTbSet3pOj27Jv8f37/ecm5ravx5t29mKwTndVk6S/xN9lF8Z1tUTNyXXFF40YMQpH0nb2rNCquuDuYBOAGe5Rd6QMf6L1BZ1xNknEA4z/0DVCCwIjq+vwQWa3rs3xi8pPd4xpBhf1Ih9qQjMLilHXZRf4z1wDugPZwUf6FbkyMk0wBs/CNCwF7WsDSoU2ZXavfLDrLGFPCySzB/nmFcuKMYlBApEuMU6d2dJk6KS4jTab0g2eOIlX6ng+ZQB0eV2/dea8pP7kMa5Gfr8+xL2JJh/QK4W1uuzhuw3SC8gZ3T0llsJI8z1XUQNzg1/RpnSpTDFnbuWRnYQkT3R2WmK1qkUnjXH06QY+QQEsuHU3jqMU4CIBqc2kOl9RlrNCmboTQjFdS9LRcUvJWxcIGF13IjW6ZsuIBTl4u3O4heyDdFOg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199021)(107886003)(31686004)(6666004)(2616005)(83380400001)(186003)(53546011)(6512007)(6506007)(26005)(31696002)(86362001)(4326008)(66556008)(8676002)(66476007)(66946007)(38100700002)(2906002)(82960400001)(41300700001)(54906003)(316002)(110136005)(478600001)(5660300002)(8936002)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWFGMzFiL0kxL0ZUQXJQMzBzZmhzdFhZazdoRENFcCtZMS9DakhvTUNZcGk1?= =?utf-8?B?ZVBvaDdLS3FxeFR4d1ZnTTFkNllyM0VacUZyU2UyTC9PUXBFMi8vZTluZGRR?= =?utf-8?B?ZEZLL0N5Sm9PS2dXdElRTzhBVEozVVRuNjdSNGNiMEZQQUJWeGtBek5PRVd5?= =?utf-8?B?R3RqeTlMK1dpRHRZdEp1UU1pVzhNZTVZeGdhQjJqc0FGNmROeGFBMS9yVi9h?= =?utf-8?B?TlFmOGJXZEpSRDFQVEptQUI5VGtZR1YzeEM1dmJVRXZHeFBZMUtOQXRseWpn?= =?utf-8?B?ZGlKSWhWT3VhZklLTDRxUDNvYkFwcG4zRE9COUNudUtEU0c4YUdoWm14WXcv?= =?utf-8?B?YUZ0MXRSYUxDbVUwWnRhdWF5Z1lMY0U1cGlTeEN1TVNkRGhaeVlOZXREYlNw?= =?utf-8?B?S3lNaXBUaDMrdEl0TjV3RkdFQlVhdW1URlNWQ3hJcElvTlcwd2xDMnlwOHhR?= =?utf-8?B?TDIyQXJkNytISDN0Vis3cjJwQTlpZkgzQUh3bGZHRURZYXFKaVRTT0R2TXdj?= =?utf-8?B?anFzWTdmOGF2T1FWM0NFTGZCUXltWTB1L0VxWVBGTWRRc3VYUUJ4T1BhUTZj?= =?utf-8?B?YTA3VVNNWEZ1ZWtKV282NVNHSnRoVTNCaFhzK0tYaHdNQnBkcUFmRkw0azlS?= =?utf-8?B?bFV3NmZCcGFDSXJrbS9oOTlTTkZUcXZqclhuUkRuM2tIZzUrdDM2S3A1WTEz?= =?utf-8?B?YXFaN3FueUZqQW4zb2xkY1ROVUcrWkZ0bjlSaHFCOVhnT2hKUEMvZGFPYzcx?= =?utf-8?B?WjZyY01oRnpoRnBTc2FpZGZNY1dMVDE4cm1seTN6eURVcEpGWDgzQnZmMDVu?= =?utf-8?B?d2N0cVVVeEVmL0VsOUo5RENyTHZNUkVHNmxxY0RkVDJyaldEcGxGOERNbm1D?= =?utf-8?B?MVArTHpxV2VyZ0dqekhsWndTbUVoK2V1NnRjU05reXVpZkpkaSswOXZqZWNB?= =?utf-8?B?eUFUbXRsa25KTkxzNlFSTHRqWE1EcFRxRFBoM2w1bFU4QWJIS1NJU1RMOXkz?= =?utf-8?B?OSsyWDEwYzZSMTlpdmxFSGN0OVkzWXdXSVdQUnkvSTBSempwNmJqSm9rNlZw?= =?utf-8?B?YXY1VmI2bXFJa200aGtud1ZhQmloVXJwbkZBQVRDV0U4eTJKNk1YMnJhekNl?= =?utf-8?B?QURCMmFkRU9YWE94MFpsYncrZ1drMWEyYkNtT0IvbVN3VWZIcmh1WDJCbDV5?= =?utf-8?B?K1M1b3J2ZTBrV0JKcEY5M3NmL1RyUzdrVENwUC9jME1acndtUGhEYTVZMWZ0?= =?utf-8?B?QmxxRkVjdDlkQVFMTWp1RnQ4KzcyTVJ1aHRUem1Ec2pZVkVxQ3RVa1BZYXNM?= =?utf-8?B?NWxBNVh1aGJmR1lpUUY0S0wxa1hnbGUwVkg3VEh3VEdrdmtjYU9LVW1qb01w?= =?utf-8?B?OXVaWlZ5a3JPMEN0cFZFNkRGMWNiU2VZZUlZc0RPVVpyZUxPOTZQZXkyK3gr?= =?utf-8?B?ZlA0UG9VWllxbEFqWE05ekt6MDI4eGR1VWlwd0dYc3hUeUsyc3Y0RXlqTmxh?= =?utf-8?B?eUxTdWU5UG9WY1FaT01pbWZEZndsaW9SVVFSZ2Q3VTNuNzBTUWh5NElXRHJq?= =?utf-8?B?TmxKYkszeit6eHNZOG1QelBuZktjMWZoOHYwZkladjkrOFVkb3NheFByVUl3?= =?utf-8?B?MTZveDRzQUd3OERoUDRPazUxT09qVjJXdXBMVDRQcjNEdDF2L0kyVkYwL2I5?= =?utf-8?B?NGR1d24wSitYSi9TOUF0Tlpya2hOMHAwemQrbkpZTU9acVhNRVNUaHlJeXJE?= =?utf-8?B?Q3ZrK1BxRnVIUjdISlJ0SW1YSTRncUkrUWpuZ2o3WjVnQXBtd3JydkduTFE5?= =?utf-8?B?ekpTbmRjRFlhb2Z4a1JQSXM1SVRrVTh0OUxaa3VHWitDRnV1TXh5SUhxOXZ5?= =?utf-8?B?YVE2bG5KUjZzM2VVcDBmQXJjVXdmSHh4cXFTdFprWjI2alB1YzVKalBEREkv?= =?utf-8?B?d0JEL2pUTkgrcThhUnd1WFFXaHdQZTJvM2lVUm1vaWVsN25WNlNOTEFBeGhK?= =?utf-8?B?L2xpbXZuS1kwd3BtNU5UcGFzdmZCWHpRME1ld0FOdXVid3VUN0J6WjRuV2Jy?= =?utf-8?B?Q1pSWW9kSHpialVxUzhlLy96RHRJc1FYMmxtSzI1cEVYck0rd1B6K0JxOWVi?= =?utf-8?B?UDAzWk4ySHRnbmgyVFVTTDdZWnE5SDJTOWlUMkUrS1RKZytCd0JneHNpdEZi?= =?utf-8?B?Qnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uT/yVC0+kxQNGpiumMSstrGq+FkHc3ef3wBFNpNZmfNYvyWNk35dlwseCcPIlU1NSSh8ISeW5C6A9JqdDKrpt3V0MQ4ZA1TXW99OC/Iyoke+iO4DZOUemC5i/qB4L+Hm6kRCLOnoclJknFFiP3hyEjcnA4awmaz7z+Uu5xYX2TJf4jmHEcC8GmI3qzznNejLx6tAgKs0148VVmIqet0nAIMVxmtC5nG3CyNjhm2zb+O9X0LcGJC08k+Vrsq7rtVNMxfgosivWGj+I35QUXSB0g/KUPBf9l1VIr4R2M2f619icadscfSTNlQ0P7o9TP0Cz+6idEpcUIqEYMquhtsXlrApZA0C1lSsKyrpHjyrELKphViZxNZUyzAd2MS7xDQ/y65XPZwuRkX7HSxtbSQSqoa+h8w81eEfyPjpiz771Wxpmb0RAWvxYbJQTgBugVrqRFaAriQ1LCb14x14gseUZ0PRWT9jNH4bC0tz8YMt/abY+epSofQdbe9QbeqzB2YtHayN4rgC9Q9NEnBEeYEGsr4GkQFDdq9OQjrBkWdAIEUjYQIzk9ubDznCV94/IN2NlArhnfx+1jF8qUIui7yzCyqtQBsq/5TkBIxj0rVrwx8G2AGlBoTTgsTh3nJ3thFm7+aOO4/1QhHtkaaDgXj9bbcCivL1GvQ+HH9xFli8laegHiqnju3HZ92CGmvHGh8dhXmciO0kjvhnGqCj9rUXfV2JX8MCncUGRAd5AcI0rWoM9VHjRANpFG3iMpJWda52hMUD1iwvkfEkuI8gItXirJdC8dvBVFocd0Rc+pYyOyijYAYx2BbFZ5WivDOsea7N X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81c19b71-470e-415a-c6ad-08db35571f01 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 21:54:10.5766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6iRnkCwweVfSLJ1nQqfd/qPBptLjSe/wNDMT+DXk1TBH0ubY9YHot131BSJKc/odQMME6pxeVtNm3LkIqfHfF/aXxddlW+yjcuqKaaBNe8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6387 On 04/04/2023 3:49 pm, Jan Beulich wrote: > Provide support for this insn, which is a prereq to FRED. CPUID-wise > introduce both its and FRED's bit at this occasion, thus allowing to > also express the dependency right away. > > While adding a testcase, also add a SWAPGS one. In order to not affect > the behavior of pre-existing tests, install write_{segment,msr} hooks > only transiently. IMO, the emulator is already complicated enough without us having fallback logic to cope with callers that don't set up all the hooks. Nor do I think making these hooks transient in the test harness is a clever idea. > Signed-off-by: Jan Beulich > --- > Instead of ->read_segment() we could of course also use ->read_msr() to > fetch the original GS base. I don't think I can see a clear advantage of > either approach; the way it's done it matches how we handle SWAPGS. read_segment() is a much shorter logic chain under the hood, so will be marginally faster, but it will be a couple of unnecessary VMREADs (on Intel at least). We could expose the get/set reg paths for cases where we know we're not going to need sanity checks, but I'm not sure it's worth it in this case. > For PV save_segments() would need adjustment, but the insn being > restricted to ring 0 means PV guests can't use it anyway (unless we > wanted to emulate it as another privileged insn). I know, it's on the list. What is rather irritating is that, depending on FRED or not, it's opposite whether the guest user or guest kernel GS base is in context.  Sadly Intel refused my request for a control knob to turn off FRED's auto-SWAPGS, but I didn't really push them on it because for practically all other circumstances, it would just be a way for OSes to shoot themselves in the foot. For PV guests, our regular ABI is half-way to FRED anyway.  I suspect we can get most of the interesting rest of the functionality by adding an ERET bit to the HYPERCALL_iret flags.  I'm not sure yet if we ought to bother exposing CSL in the pvFRED ABI or not, but doing so would reduce the divergence from native even further. > --- a/xen/arch/x86/x86_emulate/private.h > +++ b/xen/arch/x86/x86_emulate/private.h > @@ -594,6 +594,7 @@ amd_like(const struct x86_emulate_ctxt * > #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) > #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) > #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) > +#define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) > > #define vcpu_must_have(feat) \ > generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -2886,8 +2886,31 @@ x86_emulate( > break; > } > break; > - default: > - generate_exception_if(true, EXC_UD); > + case 6: /* lkgs */ > + generate_exception_if((modrm_reg & 1) || vex.pfx != vex_f2, EXC_UD); > + generate_exception_if(!mode_64bit() || !mode_ring0(), EXC_UD); Can we switch to X86_* please.  Alternatively, I've got such a patch which I've just rebased over all your emulator changes anyway, if we're happy to fix this in one fell swoop. (Sadly, you did move some TRAP_* names into util-xen.c which I fixed up in my other tree-wide exception constant patch.) > + vcpu_must_have(lkgs); > + fail_if(!ops->read_segment || !ops->read_msr || > + !ops->write_segment || !ops->write_msr); > + if ( (rc = ops->read_msr(MSR_SHADOW_GS_BASE, &msr_val, > + ctxt)) != X86EMUL_OKAY || > + (rc = ops->read_segment(x86_seg_gs, &sreg, > + ctxt)) != X86EMUL_OKAY ) > + goto done; > + dst.orig_val = sreg.base; > + if ( (rc = protmode_load_seg(x86_seg_gs, src.val, false, &sreg, > + ctxt, ops)) != X86EMUL_OKAY || > + (rc = ops->write_msr(MSR_SHADOW_GS_BASE, sreg.base, > + ctxt)) != X86EMUL_OKAY ) > + goto done; > + sreg.base = dst.orig_val; Honestly, I think a comment is needed here, because I'm struggling to work out if this is correct or not. There is a 64->32 bit truncation of base with LGKS, just as there is with MOV GS. Which I think does happen as a side effect of protmode_load_seg() only filling in the lower half of sreg.base, but I think it would be nicer to have: +            dst.orig_val = sreg.base; /* Preserve full GS Base */ +            if ( (rc = protmode_load_seg(x86_seg_gs, src.val, false, &sreg, +                                         ctxt, ops)) != X86EMUL_OKAY || +                 /* Write truncated base into GS_SHADOW */ +                 (rc = ops->write_msr(MSR_SHADOW_GS_BASE, sreg.base, +                                      ctxt)) != X86EMUL_OKAY ) +                goto done; +            sreg.base = dst.orig_val; /* Reinstate full GS Base */ Or so, because it's weird not to see a (uint32_t) somewhere in this logic. > + if ( (rc = ops->write_segment(x86_seg_gs, &sreg, > + ctxt)) != X86EMUL_OKAY ) > + { > + /* Best effort unwind (i.e. no error checking). */ > + ops->write_msr(MSR_SHADOW_GS_BASE, msr_val, ctxt); write_segment() can't fail.  (The sanity checks are actually deferred until after emulation is complete, and I'm not sure if that's behaviour we want...) However, more importantly, if we actually take this error path (for some future reason) then we've created a security vulnerability in the guest. It will be strictly better to crash the domain in this case, than to try and let it continue in this state. > + goto done; > + } > break; > } > break; > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -281,6 +281,8 @@ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) / > XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ > XEN_CPUFEATURE(FSRS, 10*32+11) /*A Fast Short REP STOSB */ > XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ > +XEN_CPUFEATURE(FRED, 10*32+17) /* Flexible Return and Event Delivery */ > +XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ > XEN_CPUFEATURE(WRMSRNS, 10*32+19) /* WRMSR Non-Serialising */ > > /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ > --- a/xen/tools/gen-cpuid.py > +++ b/xen/tools/gen-cpuid.py > @@ -295,6 +295,9 @@ def crunch_numbers(state): > > # In principle the TSXLDTRK insns could also be considered independent. > RTM: [TSXLDTRK], > + > + # FRED builds on the LKGS instruction. > + LKGS: [FRED], Hmm...  This is the first case (I think) we've got where a dependency that goes back numerically in terms of feature number. Obviously we need to support it, but I'm not sure if the deep_deps loop will cope in its current form. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Apr 04 23:43:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 23:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518181.804442 (Exim 4.92) (envelope-from ) id 1pjqIj-0006jp-LB; Tue, 04 Apr 2023 23:42:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518181.804442; Tue, 04 Apr 2023 23:42:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqIj-0006ji-HB; Tue, 04 Apr 2023 23:42:57 +0000 Received: by outflank-mailman (input) for mailman id 518181; Tue, 04 Apr 2023 23:42:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqIi-0006jc-73 for xen-devel@lists.xen.org; Tue, 04 Apr 2023 23:42:56 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 680bcece-d342-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 01:42:49 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id w4so32818573plg.9 for ; Tue, 04 Apr 2023 16:42:49 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id y6-20020a170902864600b0019a97a4324dsm8937815plt.5.2023.04.04.16.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 16:42:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 680bcece-d342-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680651768; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=feIblo+o8kbpXNJYhzwlTFiRu9n2TLSdCk9P+Iemon0=; b=Yan3Q9i7usnOf/ue1Ycdr66MdZ/nw/QgnlqaS4UNZDvl86rfJ9JCpESP5YkLjkYU2h ypWspWID3xtm7mfI2MG/9QdNp/C7Njy0uSzzOeY6mBxt0hhJTbZ5n3AQiFh2gixGgn8X OnKq6gCfWgacDC7Y9wkL4k8rtMMP/QUTSPLkw+nLWCnjvVmkGx2v9qBnMUS17sp86BSW ir9I0Zmzy9ZGad7QpnpU+/ARWvp8T5Z+N2OFKBEL54Dz26YGb86FeiB8+j4NMJXPUiWo 9RMfyrAa8yxV3pOFIHADm/xxHiGZ4gT9EMFKoEfJIM8Vwtl50/BxI4UHwL5Fb+8z7OnL KP0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680651768; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=feIblo+o8kbpXNJYhzwlTFiRu9n2TLSdCk9P+Iemon0=; b=K1stWgcAyZf8ClVwrQ7be0SWWjLvxgZbspSfEORaID8mEcL+JKZlRWmvJExjTXKdB5 u9wOB+jC3BQk5V7p2IN22tugSaCntRHHai7aAo5R1xN2QoBtM4NsRFQ8PF6KGw0enj69 x02tNv2gg16Fz7JC6ybt4vjwkkn8dmWG7xNOuWbBZLOgu6CdNFBloJbceS910L5IGbif 9ZYFtzIbiCmdjvBdI2wUUeQgB1pkeSa+fDq1hRIWj3o3o9ZcuVqArO+007hrg3Eseh/z +4CdOMZWuclLA/mrCD6Ql6HnyDNs7Yk9WJ69yZmNjVqLwMzTDJpyHVVjucoRPoINnqDE bq4w== X-Gm-Message-State: AAQBX9dGHVGm2QuAKjSb26u1w+lz75XzYulQxLHvj9UIHih05SzA8TiC ZFropbMcWQp0ql5yxJHfIBLNSg== X-Google-Smtp-Source: AKy350ba2lwW+XWrJEcaG00ngHmXaxvRAhtHPRrC1Vt33qoLwtfK/oXIIbLdeQDDb2MkXMlAm5GfPQ== X-Received: by 2002:a17:902:f68f:b0:19c:be0c:738 with SMTP id l15-20020a170902f68f00b0019cbe0c0738mr5157163plg.59.1680651767862; Tue, 04 Apr 2023 16:42:47 -0700 (PDT) Date: Wed, 5 Apr 2023 05:12:28 +0530 From: Viresh Kumar To: Oleksandr Tyshchenko Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Juergen Gross , Julien Grall , Alex =?utf-8?Q?Benn=C3=A9e?= , Anthony PERARD , Mathieu Poirier , Erik Schilling Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Message-ID: <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> On 04-04-23, 21:16, Oleksandr Tyshchenko wrote: > ok, probably makes sense While testing both foreign and grant mappings I stumbled upon another related problem. How do I control the creation of iommu node from guest configuration file, irrespective of the domain backend is running at ? This is what we have right now: - always create iommu nodes if backend-dom != 0 - always create iommu nodes if forced_grant == 1 what I need to cover is - don't create iommu nodes irrespective of the domain This is required if you want to test both foreign and grant memory allocations, with different guests kernels. i.e. one guest kernel for device with grant mappings and another guest for device with foreign mappings. There is no way, that I know of, to disable the creation of iommu nodes. Of course we would want to use the same images for kernel and other stuff, so this needs to be controlled from guest configuration file. -- viresh From xen-devel-bounces@lists.xenproject.org Tue Apr 04 23:56:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Apr 2023 23:56:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518186.804451 (Exim 4.92) (envelope-from ) id 1pjqW7-0008Qd-UU; Tue, 04 Apr 2023 23:56:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518186.804451; Tue, 04 Apr 2023 23:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqW7-0008QW-Rn; Tue, 04 Apr 2023 23:56:47 +0000 Received: by outflank-mailman (input) for mailman id 518186; Tue, 04 Apr 2023 23:56:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqW6-0008QM-5z; Tue, 04 Apr 2023 23:56:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqW6-0002cI-2s; Tue, 04 Apr 2023 23:56:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqW5-00051d-LU; Tue, 04 Apr 2023 23:56:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjqW5-0004RP-Ky; Tue, 04 Apr 2023 23:56:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j/m17Yn7/eQs4vcsv8wd4f6/0NDyHCDEjIIcGGNnV5A=; b=TBjn4Y0TFf7LqRFxCYWUXLBttA D0nYLYyg8GekKlUK5MesY9SIUOeKRfBdVZ70tuULpCd62YEGkCdrIC9sdGGGq4HwyU0hq73ZZMLV9 ELfacJx6VA9pFbn5K+Nbh/h2YcAxlnEX7pZ/kI2Iy47sH+GTFeRBzug49ywmequg65U0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180135: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=148341f0a2f53b5e8808d093333d85170586a15d X-Osstest-Versions-That: linux=7e364e56293bb98cae1b55fd835f5991c4e96e7d From: osstest service owner Date: Tue, 04 Apr 2023 23:56:45 +0000 flight 180135 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180135/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 180131 pass in 180135 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 180131 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180131 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180116 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180116 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180116 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180116 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180116 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 148341f0a2f53b5e8808d093333d85170586a15d baseline version: linux 7e364e56293bb98cae1b55fd835f5991c4e96e7d Last test of basis 180116 2023-04-03 02:26:51 Z 1 days Testing same since 180130 2023-04-03 17:12:08 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Brauner Linus Torvalds Michael Kelley Mohammed Gamal Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 7e364e56293b..148341f0a2f5 148341f0a2f53b5e8808d093333d85170586a15d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Apr 05 00:13:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 00:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518194.804472 (Exim 4.92) (envelope-from ) id 1pjqli-0003Cq-H8; Wed, 05 Apr 2023 00:12:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518194.804472; Wed, 05 Apr 2023 00:12:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqli-0003Cj-Dd; Wed, 05 Apr 2023 00:12:54 +0000 Received: by outflank-mailman (input) for mailman id 518194; Wed, 05 Apr 2023 00:12:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqlh-0002xi-H7 for xen-devel@lists.xen.org; Wed, 05 Apr 2023 00:12:53 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a5e91b4-d346-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 02:12:51 +0200 (CEST) Received: by mail-pj1-x102d.google.com with SMTP id j13so32305906pjd.1 for ; Tue, 04 Apr 2023 17:12:51 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id z3-20020a170902ee0300b001a1ea1d6d6esm8851436plb.290.2023.04.04.17.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 17:12:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a5e91b4-d346-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680653570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mYxdQefgqzq2X8Q8qR8DL2/WAeN3DrYXWhA7psmOG80=; b=tzmH9TBXP3GLNCGLUPpOx4TttKCBmol8VdJA6+UQj486ul/mT6/7hcIp6NJQc4wMbq WfrnQHg0d5FE8BoZ+pORuig9piAflF/mel91+K1+Mb5MkgBp+E4vzEupCjnuuiRSeaUX sRR6x0OfIml2X7W/sZqZrwDJ4uIL2NfsQ/4s72WUpB43/9QfiBpV2M2YUJw11AtvFYEW nv66L+qr4kJQ5ganRgEFds/KFds1DLRrf5fFhiu/A2+2UYdPxH258Q/hzgiOn2wWIwM/ 1Ldud6iAarCJ2TmueSghvBXJ4lUdwxT03TM96N4q02SHBzvW0L4kDw1EnL6wqlCOOWMF KQlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680653570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mYxdQefgqzq2X8Q8qR8DL2/WAeN3DrYXWhA7psmOG80=; b=GUu6wSDAMyEFpzl5D4lur6Bfuwm6xfpmJQLDL1YaXjXiVvyTFG5+yiIBOj844Ak61W fCa6+JA4NyN6mhUg99UajP5Y8dB1H5k32NmOph+pTDIlZeHwuXi+Axb5SKVimS70tlHb umRuMFVdNVBzNWCUI2KhAhjqBkFC66Aw+ZqNcVbc7zcQdmqDHDMQXAlrSC7yw7n8Uf/w vg5U3w9KtMn+6ug6Llo4VGaieK5Tsy26ufecm6OD1HEMrQVsxsdYigTmbaoxGoEpzSUy D6yajaSofqK0QlqBLKXDLLCgeuM2V6yV8ipBGiPWjNIXePZACicGgcD+IcCnNXciBHAH cFfw== X-Gm-Message-State: AAQBX9cwOIOvRrRqV5v25Tv2wxT49ySgIeZtpcTvCM0rlkkbO7c5KqqR Aeedze2Kq57twibw7hPeizJDyeIYu3MtMNsOX8E= X-Google-Smtp-Source: AKy350b5vjoTBYkLa2izjFoNXcHxKSMw3SrIT5qvguVpK4gjXabDgou1jc1K8ftTFJBNnxwFcqQy9w== X-Received: by 2002:a17:90b:3b8a:b0:237:161d:f5ac with SMTP id pc10-20020a17090b3b8a00b00237161df5acmr4435401pjb.36.1680653570386; Tue, 04 Apr 2023 17:12:50 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling Subject: [PATCH V2 2/2] libxl: fix matching of generic virtio device Date: Wed, 5 Apr 2023 05:42:36 +0530 Message-Id: <62f2603d8b3fba1efb236063a0819fb95285b0ae.1680653504.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The strings won't be an exact match, as we are only looking to match the prefix here, i.e. "virtio,device". This is already done properly in libxl_virtio.c file, lets do the same here too. Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") Signed-off-by: Viresh Kumar --- V1->V2: Add the missing fixes tag. tools/libs/light/libxl_arm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..97c80d7ed0fa 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1033,10 +1033,14 @@ static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, } else if (!strcmp(type, VIRTIO_DEVICE_TYPE_GPIO)) { res = make_virtio_mmio_node_gpio(gc, fdt); if (res) return res; - } else if (strcmp(type, VIRTIO_DEVICE_TYPE_GENERIC)) { - /* Doesn't match generic virtio device */ - LOG(ERROR, "Invalid type for virtio device: %s", type); - return -EINVAL; + } else { + int len = sizeof(VIRTIO_DEVICE_TYPE_GENERIC) - 1; + + if (strncmp(type, VIRTIO_DEVICE_TYPE_GENERIC, len)) { + /* Doesn't match generic virtio device */ + LOG(ERROR, "Invalid type for virtio device: %s", type); + return -EINVAL; + } } return fdt_end_node(fdt); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 00:13:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 00:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518193.804462 (Exim 4.92) (envelope-from ) id 1pjqlg-0002xv-8K; Wed, 05 Apr 2023 00:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518193.804462; Wed, 05 Apr 2023 00:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqlg-0002xo-5M; Wed, 05 Apr 2023 00:12:52 +0000 Received: by outflank-mailman (input) for mailman id 518193; Wed, 05 Apr 2023 00:12:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjqle-0002xi-ID for xen-devel@lists.xen.org; Wed, 05 Apr 2023 00:12:50 +0000 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [2607:f8b0:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97e26084-d346-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 02:12:47 +0200 (CEST) Received: by mail-pl1-x62a.google.com with SMTP id le6so32869820plb.12 for ; Tue, 04 Apr 2023 17:12:47 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id jn22-20020a170903051600b0019a95baaaa6sm8852381plb.222.2023.04.04.17.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 17:12:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97e26084-d346-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680653566; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OWw80btV/vkY8XMbURM92c6D4GYeLA/5q3xU6Aoi0EQ=; b=vR5dx0yJebVkrvv+aB71InjcvrW6v9q0rNb2PTlKa4lWPnr4/+1CT8KntvSHFQKpCM siaDKPZwRnkot4U8RUR7yYpA9CR+79a+NByNqKCtWM8XTMRw7aQ+4NXSgLSHbK0ZGE50 QPgCl4tZtf45W8+N9nUlXaG6eFFXj8MPsvunicqk18zheXGfYpoV+f5uKDHDy00GGHhZ Ouz/Q5yQrF5BC8YUFzktg3F9hE3rKvbZtGqxMOZ1cLD7mQPziXcKw6Tv6t2hTlB5FJZM O4zNi823xfywpse/OuLgtWfVK9WPUeINoe/ziK2zK2CAr/UlvgUI5QTAqYf2Fm32YanH mMRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680653566; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OWw80btV/vkY8XMbURM92c6D4GYeLA/5q3xU6Aoi0EQ=; b=4108WNwuCYfF/epZqox5Xyu1aP5matl6SCPcbeJ4v0m/Sk0M8D5G9Anj0IYiiVcfJB IQQOUmzuSSwDf1Sfh9mUqm4Ch8Azve8JDb15w2pcK4sCIZZjeZ+yvvj85L5gJ78IkXrH /qwZNByua02iD2cxqRUWgSMfxSLTtLjlE+RMm8B5Q+YGR/ZQ0nfurnpfweEs+CKDZRuq Zz/dpTukqwgZONRGTThXENQ2mIzyfrSQseVG93zLgxrvERGXCcgA1X08IOa145aeRuZt RrslJGIjcwuWktnzSaEMvn5KJheyFWRnMURRZkO3tFA7v8gbWxP5lPumwJSI718Zwrw3 WiBA== X-Gm-Message-State: AAQBX9cpEsa513P8xGij+CB1pcKHbPofYvTwKwoB/nVXG0O2U84J7fMf sCj7Jl5oZwWXtzM8oDZoF3quT7pP6CG/3u2fQOQ= X-Google-Smtp-Source: AKy350bnELvarxqhwrfDobQ4HgHVzxA23wxmz2u35PJ8qLOp7TTqjYlqBLgYLfiN6mn/KoxMHgp9gg== X-Received: by 2002:a17:90a:1902:b0:240:5c43:7766 with SMTP id 2-20020a17090a190200b002405c437766mr4844628pjg.4.1680653566069; Tue, 04 Apr 2023 17:12:46 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling Subject: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id Date: Wed, 5 Apr 2023 05:42:35 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For generic virtio devices, where we don't need to add compatible or other special DT properties, the type field is set to "virtio,device". But this misses the case where the user sets the type with a valid virtio device id as well, like "virtio,device26" for file system device. Update documentation to support that as well. Fixes: dd54ea500be8 ("docs: add documentation for generic virtio devices") Signed-off-by: Viresh Kumar --- V1->V2: New patch. docs/man/xl.cfg.5.pod.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 10f37990be57..ea20eac0ba32 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1608,8 +1608,9 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is L -For generic virtio devices, where we don't need to set special or compatible -properties in the Device Tree, the type field must be set to "virtio,device". +For other generic virtio devices, where we don't need to set special or +compatible properties in the Device Tree, the type field must be set to +"virtio,device" or "virtio,device", where "N" is the virtio device id. =item B -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 03:05:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 03:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518204.804482 (Exim 4.92) (envelope-from ) id 1pjtSM-0002Ay-R5; Wed, 05 Apr 2023 03:05:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518204.804482; Wed, 05 Apr 2023 03:05:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjtSM-0002Aq-MK; Wed, 05 Apr 2023 03:05:06 +0000 Received: by outflank-mailman (input) for mailman id 518204; Wed, 05 Apr 2023 03:05:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjtSL-0002Ag-0n; Wed, 05 Apr 2023 03:05:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjtSK-0006WQ-He; Wed, 05 Apr 2023 03:05:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjtSJ-0002z8-UR; Wed, 05 Apr 2023 03:05:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjtSJ-0008Lu-Te; Wed, 05 Apr 2023 03:05:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Sfpbcr+nPnZUZKjN++iIYImzR/J4uxMaWfRdEUAx0/c=; b=nRBU+RtBybYwK0NAD0YzaGQT6l RXattxOWVDxhmWIi8ZnwvadaZ+tEiianNT1PFRG2ev9tC2dHpcqnLUPbZa/G7vwWtnYG5YFGYEuCz xgPZoQj5dc3y604ka+k20ZXGkmb2GdBqotjNBDo4GU03UZfhyDpFuF25SnTe9fHu93nc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180136: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=51a6dc9d394098e8f4141fad869a1ee9585f54f8 X-Osstest-Versions-That: qemuu=efcd0ec14b0fe9ee0ee70277763b2d538d19238d From: osstest service owner Date: Wed, 05 Apr 2023 03:05:03 +0000 flight 180136 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180136/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180088 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180088 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180088 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180088 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180088 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 51a6dc9d394098e8f4141fad869a1ee9585f54f8 baseline version: qemuu efcd0ec14b0fe9ee0ee70277763b2d538d19238d Last test of basis 180088 2023-03-31 12:08:44 Z 4 days Testing same since 180136 2023-04-04 13:08:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chris Rauer Daniel Henrique Barboza Markus Armbruster Peter Maydell Philippe Mathieu-Daudé jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git efcd0ec14b..51a6dc9d39 51a6dc9d394098e8f4141fad869a1ee9585f54f8 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Apr 05 04:46:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 04:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518211.804492 (Exim 4.92) (envelope-from ) id 1pjv2Y-0003vX-Tg; Wed, 05 Apr 2023 04:46:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518211.804492; Wed, 05 Apr 2023 04:46:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjv2Y-0003vQ-Po; Wed, 05 Apr 2023 04:46:34 +0000 Received: by outflank-mailman (input) for mailman id 518211; Wed, 05 Apr 2023 04:46:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjv2W-0003vK-SQ for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 04:46:33 +0000 Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [2607:f8b0:4864:20::92f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d45cb58b-d36c-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 06:46:30 +0200 (CEST) Received: by mail-ua1-x92f.google.com with SMTP id i22so24745423uat.8 for ; Tue, 04 Apr 2023 21:46:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d45cb58b-d36c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680669988; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1mHfEQJVJxa7vmszfTcCwqaAU9CfuBGkxiTaGBwcxQI=; b=pHPuOmM0hqQsCVM5oqdsVCnq3cSErus6CZp0nlP2tSmPudXWNmJYrcuslv5bpRnY1S ckmspC8qR/oeJoQJe1O3CwIlQXciszzKY25cTaftbrf+Syk988VYnWgIl6c4Trk8Aqlf +dE74/BHzzcT433EpKmBWnsex5YSQrAq/bgExJvfKEnAa2UmiRd4Qg3fguvVa9qlmzSM k1UArUywPOjKy5YM88rjCAPsMY+SuBa2dDUl4nodcv16OwVw6O+OWen4Ro/6jYxIzkft WndR0bqRj7ECxGx6lU7MWBa5mUKbn8IcKDJ/wvNlDJQoo2d/rbEHxiy0VrpYrrWsiCJh PlMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680669988; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1mHfEQJVJxa7vmszfTcCwqaAU9CfuBGkxiTaGBwcxQI=; b=VViNmlLci6wAIqJLohkMEOu87FeIp9qb1Tw3jYIb/zxJkb6Z3VTbICHABCNcAy/fEj nMJy46I8n/PW+Ghlk5Nt+yF+eICiM/iKPE9x3E8GfuNzNckqWIjckrkXLDqO/3T0zMxI dDjuP3++EXyMhXLsYHcFXPw1M02/4EqfD22LskYvZ9MHQQ83JVUmZ8N+sxunX2Q9wvD5 kcVoHVI0Ixl0XNOhxo5ibFd2IXnDbC1gJ2wUqzofCddZqc985B0hMwYowYCOK0M8BuD7 fEgxX7E2kXOkMXszY5KvBAWIc465rKCUCY00IJMrosAsKp/KtN4Z02JvUm3sTW6tmXkm nkiA== X-Gm-Message-State: AAQBX9f+4QWdUaD6ebMjHX1ePeQQBEV+Fr2KK1gL6iG3HmEMyNhG4zf7 NJkHwyEkhMQ94O+99EB7Mk37iCi9tRjht44iOo4= X-Google-Smtp-Source: AKy350akIvZyr5+Ra8ZTKGtad0acZ4zqrDFkn2DwRV4Aaw/MuEbufeHM0ZDMDtFHbQ1E1lUoQ7I8bv21YCVj7QVKxkE= X-Received: by 2002:a9f:37cd:0:b0:764:64c1:9142 with SMTP id q71-20020a9f37cd000000b0076464c19142mr1418967uaq.0.1680669988687; Tue, 04 Apr 2023 21:46:28 -0700 (PDT) MIME-Version: 1.0 References: <20230324222451.3295023-1-andrew.cooper3@citrix.com> In-Reply-To: <20230324222451.3295023-1-andrew.cooper3@citrix.com> From: Alistair Francis Date: Wed, 5 Apr 2023 14:46:02 +1000 Message-ID: Subject: Re: [PATCH] ARM+RISC-V: BSS handling improvements To: Andrew Cooper Cc: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 25, 2023 at 8:25=E2=80=AFAM Andrew Cooper wrote: > > * Correct comments in arm{32,64}/head.S > * Provide Linker assertions to check the safety of the zeroing loops > > Signed-off-by: Andrew Cooper Acked-by: Alistair Francis Alistair > --- > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Bob Eshleman > CC: Alistair Francis > CC: Connor Davis > CC: Oleksii Kurochko > > Pulled out of the very start of my work to try and unify the handling of > xen_phys_addr across architectures. > --- > xen/arch/arm/arm32/head.S | 2 +- > xen/arch/arm/arm64/head.S | 2 +- > xen/arch/arm/xen.lds.S | 2 ++ > xen/arch/riscv/xen.lds.S | 4 ++++ > 4 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index df51550baa8a..f9f7be9588b1 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -301,7 +301,7 @@ ENDPROC(check_cpu_mode) > zero_bss: > PRINT("- Zero BSS -\r\n") > mov_w r0, __bss_start /* r0 :=3D vaddr(__bss_start) */ > - mov_w r1, __bss_end /* r1 :=3D vaddr(__bss_start) */ > + mov_w r1, __bss_end /* r1 :=3D vaddr(__bss_end) */ > > mov r2, #0 > 1: str r2, [r0], #4 > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 4a3f87117c83..8a4dd64c99ad 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -437,7 +437,7 @@ zero_bss: > > PRINT("- Zero BSS -\r\n") > ldr x0, =3D__bss_start /* x0 :=3D vaddr(__bss_start) */ > - ldr x1, =3D__bss_end /* x1 :=3D vaddr(__bss_start) */ > + ldr x1, =3D__bss_end /* x1 :=3D vaddr(__bss_end) */ > > 1: str xzr, [x0], #8 > cmp x0, x1 > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index 1b392345bc3b..6ca3caefe607 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -240,3 +240,5 @@ ASSERT(_idmap_end - _idmap_start <=3D PAGE_SIZE, "Ide= ntity mapped code is larger t > */ > ASSERT(IS_ALIGNED(__init_begin, 4), "__init_begin is misaligned") > ASSERT(IS_ALIGNED(__init_end, 4), "__init_end is misaligned") > +ASSERT(IS_ALIGNED(__bss_start, POINTER_ALIGN), "__bss_start is misa= ligned") > +ASSERT(IS_ALIGNED(__bss_end, POINTER_ALIGN), "__bss_end is misali= gned") > diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S > index ca57cce75cba..2ed70eccc62a 100644 > --- a/xen/arch/riscv/xen.lds.S > +++ b/xen/arch/riscv/xen.lds.S > @@ -1,3 +1,4 @@ > +#include > #include > > #undef ENTRY > @@ -156,3 +157,6 @@ SECTIONS > > ELF_DETAILS_SECTIONS > } > + > +ASSERT(IS_ALIGNED(__bss_start, POINTER_ALIGN), "__bss_start is misa= ligned") > +ASSERT(IS_ALIGNED(__bss_end, POINTER_ALIGN), "__bss_end is misali= gned") > -- > 2.30.2 > > From xen-devel-bounces@lists.xenproject.org Wed Apr 05 06:40:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 06:40:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518218.804502 (Exim 4.92) (envelope-from ) id 1pjwoB-00075x-Ut; Wed, 05 Apr 2023 06:39:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518218.804502; Wed, 05 Apr 2023 06:39:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjwoB-00075q-Rn; Wed, 05 Apr 2023 06:39:51 +0000 Received: by outflank-mailman (input) for mailman id 518218; Wed, 05 Apr 2023 06:39:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjwoA-00075f-Sk; Wed, 05 Apr 2023 06:39:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjwoA-0003uT-Pg; Wed, 05 Apr 2023 06:39:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjwoA-0006po-7I; Wed, 05 Apr 2023 06:39:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pjwoA-0000Ao-6q; Wed, 05 Apr 2023 06:39:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pA769ubfFR/4arVACp/5eOEiHrl/x/uoU+musyhZ/fQ=; b=HXFCsxbPN3tyk80pmx5V6cV0rX c6KDU/Qs7kURpTa2FBkns4M3N21HYOtOZHjXtvnwgKoPzJz1WQwy2yIpp55PryufdU86xVmVa4uVo 9LyDvtzmx1DA2iJLBChu8Hv9ODO6Siw721/AmTivV2CU/f2uM20pfHu28HRrX57oMzCg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180139: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e X-Osstest-Versions-That: xen=bfa2e6a246225233f09a2523939e01dcf83bca4c From: osstest service owner Date: Wed, 05 Apr 2023 06:39:50 +0000 flight 180139 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180139/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180133 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180133 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180133 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180133 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180133 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e baseline version: xen bfa2e6a246225233f09a2523939e01dcf83bca4c Last test of basis 180133 2023-04-04 04:12:59 Z 1 days Testing same since 180139 2023-04-04 16:39:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bfa2e6a246..658fcb7ac9 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e -> master From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518228.804528 (Exim 4.92) (envelope-from ) id 1pjxBU-0002F6-0b; Wed, 05 Apr 2023 07:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518228.804528; Wed, 05 Apr 2023 07:03:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBT-0002Ez-Sq; Wed, 05 Apr 2023 07:03:55 +0000 Received: by outflank-mailman (input) for mailman id 518228; Wed, 05 Apr 2023 07:03:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBS-0002Et-Ox for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:03:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 057a42a7-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:03:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 95B26204F8; Wed, 5 Apr 2023 07:03:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4F8F313A31; Wed, 5 Apr 2023 07:03:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id e+f0EVcdLWRFEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:03:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 057a42a7-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/ixJC+7prIJuoskG0EIHqu4CVsVfCk74G0QSnhmZDzM=; b=h9rvUgdzBA7Hqu85sjtwMNHuaiHefCCwEO4cBTJl1JOo0xqHAY56pYccr5q6+hL8S8o7l6 1lq5Psheupci+F6672Sv4aetHL273Mw/3QrfDm17//EKW16oGoVyWR3LdNVWOw/qfYhFsW oumo0p1Ov8K5U8/KaUR3sTShX4GUxNM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini Subject: [PATCH v4 00/13] tools/xenstore: rework internal accounting Date: Wed, 5 Apr 2023 09:03:36 +0200 Message-Id: <20230405070349.25293-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series reworks the Xenstore internal accounting to use a uniform generic framework. It is adding some additional useful diagnostic information, like accounting trace and max. per-domain and global quota values seen. Changes in V2: - added patch 1 (leftover from previous series) - rebase Changes in V3: - addressed comments Changes in V4: - fixed patch 3 Juergen Gross (13): tools/xenstore: take transaction internal nodes into account for quota tools/xenstore: manage per-transaction domain accounting data in an array tools/xenstore: introduce accounting data array for per-domain values tools/xenstore: add framework to commit accounting data on success only tools/xenstore: use accounting buffering for node accounting tools/xenstore: add current connection to domain_memory_add() parameters tools/xenstore: use accounting data array for per-domain values tools/xenstore: add accounting trace support tools/xenstore: add TDB access trace support tools/xenstore: switch transaction accounting to generic accounting tools/xenstore: remember global and per domain max accounting values tools/xenstore: use generic accounting for remaining quotas tools/xenstore: switch quota management to be table based docs/misc/xenstore.txt | 5 +- tools/xenstore/xenstored_control.c | 65 ++-- tools/xenstore/xenstored_core.c | 168 +++++----- tools/xenstore/xenstored_core.h | 24 +- tools/xenstore/xenstored_domain.c | 433 ++++++++++++++++++------- tools/xenstore/xenstored_domain.h | 60 +++- tools/xenstore/xenstored_transaction.c | 22 +- tools/xenstore/xenstored_watch.c | 15 +- 8 files changed, 514 insertions(+), 278 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518229.804537 (Exim 4.92) (envelope-from ) id 1pjxBY-0002Uy-AS; Wed, 05 Apr 2023 07:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518229.804537; Wed, 05 Apr 2023 07:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBY-0002Un-7C; Wed, 05 Apr 2023 07:04:00 +0000 Received: by outflank-mailman (input) for mailman id 518229; Wed, 05 Apr 2023 07:03:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBX-0002UC-4m for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:03:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08a76ca9-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:03:57 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35663229E9; Wed, 5 Apr 2023 07:03:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0655A13A31; Wed, 5 Apr 2023 07:03:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZzxgO1wdLWRUEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:03:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08a76ca9-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678237; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jR2CaVJDZ2qBizxTmbgLfYMIkR5bcQwiTfYf2yndaVw=; b=PNm3qfd93Y9Gavr2aSfwatm6iAcArvUAkI79Ec4Tyz5JmZRSAEqnX+J++bZAENfZdrmhrV c0EkT/oJCwY1tWWec5KmRLnWNFn+p233Vqh67Dit3FLRkxAE9kWF+lGf+1CSX4WsBiX6gG WFxSSwcrukx/2dldNX1uTN9jlLZrpUY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v4 01/13] tools/xenstore: take transaction internal nodes into account for quota Date: Wed, 5 Apr 2023 09:03:37 +0200 Message-Id: <20230405070349.25293-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it is checking the node quota only against the number of nodes outside the transaction. This can result in the transaction finally failing, as node quota is checked at the end of the transaction again. On the other hand even in a transaction deleting many nodes, new nodes might not be creatable, in case the node quota was already reached at the start of the transaction. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- V3: - rewrite of commit message (Julien Grall) --- tools/xenstore/xenstored_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f62be2245c..dbbf97accc 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1116,9 +1116,8 @@ int domain_nbentry_fix(unsigned int domid, int num, bool update) int domain_nbentry(struct connection *conn) { - return (domain_is_unprivileged(conn)) - ? conn->domain->nbentry - : 0; + return domain_is_unprivileged(conn) + ? domain_nbentry_add(conn, conn->id, 0, true) : 0; } static bool domain_chk_quota(struct domain *domain, int mem) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518230.804547 (Exim 4.92) (envelope-from ) id 1pjxBd-0002nk-Jj; Wed, 05 Apr 2023 07:04:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518230.804547; Wed, 05 Apr 2023 07:04:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBd-0002nZ-Ga; Wed, 05 Apr 2023 07:04:05 +0000 Received: by outflank-mailman (input) for mailman id 518230; Wed, 05 Apr 2023 07:04:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBb-0002UC-L1 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:03 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bfdcdaa-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C870B205F9; Wed, 5 Apr 2023 07:04:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 95F1F13A31; Wed, 5 Apr 2023 07:04:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NXw7I2IdLWRfEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bfdcdaa-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlFoqnoU3I4JMyJapnFZtevlraEzWmolnTL1zQ4kqcs=; b=DDAP5/NyAduIWDEb6ICBx4jdNEjhte34fHoXhVU634jNXxaIfwnKOrqGKNI6jeg6ph566v KkAXwau9ss9pN8JmnivV8yWp18Ak6MDK0OfL+QBwKc0N0CJhcN/LNEJ3kRN5lboJWw0jU+ I9r22p9nwPylJiSigy3yVyLqeuejJZA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v4 02/13] tools/xenstore: manage per-transaction domain accounting data in an array Date: Wed, 5 Apr 2023 09:03:38 +0200 Message-Id: <20230405070349.25293-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare keeping accounting data in an array instead of using independent fields, switch the struct changed_domain accounting data to that scheme, for now only using an array with one element. In order to be able to extend this scheme add the needed indexing enum to xenstored_domain.h. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - make "what" parameter of acc_add_changed_dom() an enum type, and assert() that it won't exceed the accounting array (Julien Grall) --- tools/xenstore/xenstored_domain.c | 19 +++++++++++-------- tools/xenstore/xenstored_domain.h | 10 ++++++++++ 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index dbbf97accc..609a9a13ab 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -99,8 +99,8 @@ struct changed_domain /* Identifier of the changed domain. */ unsigned int domid; - /* Amount by which this domain's nbentry field has changed. */ - int nbentry; + /* Accounting data. */ + int acc[ACC_TR_N]; }; static struct hashtable *domhash; @@ -550,7 +550,7 @@ int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) int cnt; list_for_each_entry(cd, head, list) { - cnt = domain_nbentry_fix(cd->domid, cd->nbentry, update); + cnt = domain_nbentry_fix(cd->domid, cd->acc[ACC_NODES], update); if (!update) { if (chk_quota && cnt >= quota_nb_entry_per_domain) return ENOSPC; @@ -595,19 +595,21 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, return cd; } -static int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, - unsigned int domid) +static int acc_add_changed_dom(const void *ctx, struct list_head *head, + enum accitem what, int val, unsigned int domid) { struct changed_domain *cd; + assert(what < ARRAY_SIZE(cd->acc)); + cd = acc_get_changed_domain(ctx, head, domid); if (!cd) return 0; errno = 0; - cd->nbentry += val; + cd->acc[what] += val; - return cd->nbentry; + return cd->acc[what]; } static void domain_conn_reset(struct domain *domain) @@ -1071,7 +1073,8 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, if (conn && conn->transaction) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_dom_nbentry(conn->transaction, head, add, domid); + ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, + add, domid); if (errno) { fail_transaction(conn->transaction); return -1; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 279cccb3ad..40803574f6 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -19,6 +19,16 @@ #ifndef _XENSTORED_DOMAIN_H #define _XENSTORED_DOMAIN_H +/* + * All accounting data is stored in a per-domain array. + * Depending on the account item there might be other scopes as well, like e.g. + * a per transaction array. + */ +enum accitem { + ACC_NODES, + ACC_TR_N, /* Number of elements per transaction. */ +}; + void handle_event(void); void check_domains(void); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518232.804558 (Exim 4.92) (envelope-from ) id 1pjxBk-0003C5-T7; Wed, 05 Apr 2023 07:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518232.804558; Wed, 05 Apr 2023 07:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBk-0003By-Q8; Wed, 05 Apr 2023 07:04:12 +0000 Received: by outflank-mailman (input) for mailman id 518232; Wed, 05 Apr 2023 07:04:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBi-0002Et-Ga for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f586cb1-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:04:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67D92229E5; Wed, 5 Apr 2023 07:04:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3834213A31; Wed, 5 Apr 2023 07:04:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NaRUDGgdLWSUEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f586cb1-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678248; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGeyzFUz5tXMQxwcHUnMlsPDW6IPPfsMHnMCy5JL5Tc=; b=hz+PU6USwBStzOH8qIlujgCh7UZln1zWU3HxdKKBJcFUaj1pIdwd6spHFZdSJpaFSJqT5R wikn4kZb07OYCFVKm2y78r1ZqeS1PweDdHmGtfO1ZKjw0Q2jYT3LkErSnWa52fsf7XAqYc GQ/ohUuVYPPMu6oEmN4BIBfLILN8bbY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 03/13] tools/xenstore: introduce accounting data array for per-domain values Date: Wed, 5 Apr 2023 09:03:39 +0200 Message-Id: <20230405070349.25293-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce the scheme of an accounting data array for per-domain accounting data and use it initially for the number of nodes owned by a domain. Make the accounting data type to be unsigned int, as no data is allowed to be negative at any time. Signed-off-by: Juergen Gross --- V3: - remove domid parameter from domain_acc_add_chk() (Julien Grall) - rename domain_acc_add_chk() (Julien Grall) - modify overflow check (Julien Grall) V4: - fix overflow check --- tools/xenstore/xenstored_domain.c | 70 ++++++++++++++++++------------- tools/xenstore/xenstored_domain.h | 3 +- 2 files changed, 43 insertions(+), 30 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 609a9a13ab..30fb9acec6 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -69,8 +69,8 @@ struct domain /* Has domain been officially introduced? */ bool introduced; - /* number of entry from this domain in the store */ - int nbentry; + /* Accounting data for this domain. */ + unsigned int acc[ACC_N]; /* Amount of memory allocated for this domain. */ int memory; @@ -246,7 +246,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, if (keep_orphans) { set_tdb_key(node->name, &key); - domain->nbentry--; + domain_nbentry_dec(NULL, domain->domid); node->perms.p[0].id = priv_domid; node->acc.memory = 0; domain_nbentry_inc(NULL, priv_domid); @@ -270,7 +270,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, ret = WALK_TREE_SKIP_CHILDREN; } - return domain->nbentry > 0 ? ret : WALK_TREE_SUCCESS_STOP; + return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; } static void domain_tree_remove(struct domain *domain) @@ -278,7 +278,7 @@ static void domain_tree_remove(struct domain *domain) int ret; struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; - if (domain->nbentry > 0) { + if (domain->acc[ACC_NODES]) { ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); if (ret == WALK_TREE_ERROR_STOP) syslog(LOG_ERR, @@ -437,7 +437,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ if (!resp) return ENOMEM - ent(nodes, d->nbentry); + ent(nodes, d->acc[ACC_NODES]); ent(watches, d->nbwatch); ent(transactions, ta); ent(outstanding, d->nboutstanding); @@ -1047,8 +1047,27 @@ int domain_adjust_node_perms(struct node *node) return 0; } -static int domain_nbentry_add(struct connection *conn, unsigned int domid, - int add, bool no_dom_alloc) +static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) +{ + assert(what < ARRAY_SIZE(d->acc)); + + if ((add < 0 && -add > d->acc[what]) || + (add > 0 && (INT_MAX - d->acc[what]) < add)) { + /* + * In a transaction when a node is being added/removed AND the + * same node has been added/removed outside the transaction in + * parallel, the resulting value will be wrong. This is no + * problem, as the transaction will fail due to the resulting + * conflict. + */ + return (add < 0) ? 0 : INT_MAX; + } + + return d->acc[what] + add; +} + +static int domain_acc_add(struct connection *conn, unsigned int domid, + enum accitem what, int add, bool no_dom_alloc) { struct domain *d; struct list_head *head; @@ -1071,56 +1090,49 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, } } - if (conn && conn->transaction) { + if (conn && conn->transaction && what < ACC_TR_N) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, + ret = acc_add_changed_dom(conn->transaction, head, what, add, domid); if (errno) { fail_transaction(conn->transaction); return -1; } - /* - * In a transaction when a node is being added/removed AND the - * same node has been added/removed outside the transaction in - * parallel, the resulting number of nodes will be wrong. This - * is no problem, as the transaction will fail due to the - * resulting conflict. - * In the node remove case the resulting number can be even - * negative, which should be avoided. - */ - return max(d->nbentry + ret, 0); + return domain_acc_add_valid(d, what, ret); } - d->nbentry += add; + d->acc[what] = domain_acc_add_valid(d, what, add); - return d->nbentry; + return d->acc[what]; } int domain_nbentry_inc(struct connection *conn, unsigned int domid) { - return (domain_nbentry_add(conn, domid, 1, false) < 0) ? errno : 0; + return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) + ? errno : 0; } int domain_nbentry_dec(struct connection *conn, unsigned int domid) { - return (domain_nbentry_add(conn, domid, -1, true) < 0) ? errno : 0; + return (domain_acc_add(conn, domid, ACC_NODES, -1, true) < 0) + ? errno : 0; } int domain_nbentry_fix(unsigned int domid, int num, bool update) { int ret; - ret = domain_nbentry_add(NULL, domid, update ? num : 0, update); + ret = domain_acc_add(NULL, domid, ACC_NODES, update ? num : 0, update); if (ret < 0 || update) return ret; return domid_is_unprivileged(domid) ? ret + num : 0; } -int domain_nbentry(struct connection *conn) +unsigned int domain_nbentry(struct connection *conn) { return domain_is_unprivileged(conn) - ? domain_nbentry_add(conn, conn->id, 0, true) : 0; + ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } static bool domain_chk_quota(struct domain *domain, int mem) @@ -1597,7 +1609,7 @@ static int domain_check_acc_init_sub(const void *k, void *v, void *arg) * If everything is correct incrementing the value for each node will * result in dom->nodes being 0 at the end. */ - dom->nodes = -d->nbentry; + dom->nodes = -d->acc[ACC_NODES]; if (!hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); @@ -1652,7 +1664,7 @@ static int domain_check_acc_cb(const void *k, void *v, void *arg) if (!d) return 0; - d->nbentry += dom->nodes; + d->acc[ACC_NODES] += dom->nodes; return 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 40803574f6..9d05eb01da 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -27,6 +27,7 @@ enum accitem { ACC_NODES, ACC_TR_N, /* Number of elements per transaction. */ + ACC_N = ACC_TR_N, /* Number of elements per domain. */ }; void handle_event(void); @@ -77,7 +78,7 @@ int domain_alloc_permrefs(struct node_perms *perms); int domain_nbentry_inc(struct connection *conn, unsigned int domid); int domain_nbentry_dec(struct connection *conn, unsigned int domid); int domain_nbentry_fix(unsigned int domid, int num, bool update); -int domain_nbentry(struct connection *conn); +unsigned int domain_nbentry(struct connection *conn); int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); /* -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518234.804568 (Exim 4.92) (envelope-from ) id 1pjxBo-0003Xm-54; Wed, 05 Apr 2023 07:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518234.804568; Wed, 05 Apr 2023 07:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBo-0003XU-1p; Wed, 05 Apr 2023 07:04:16 +0000 Received: by outflank-mailman (input) for mailman id 518234; Wed, 05 Apr 2023 07:04:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBn-0002UC-09 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:15 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12a74feb-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 013E520258; Wed, 5 Apr 2023 07:04:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C962013A31; Wed, 5 Apr 2023 07:04:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ac+pL20dLWSiEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12a74feb-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PmKRxa2YuBmHM00MgxuyH9GXZoeQCdBxFLkVz4Hk1ys=; b=W+adN7dxvkw5e9v+LkLSUx0dG3FvIDFTdGoBe9KhCde/ai3BrSwTIYgCAj8J7s7tF8uXkS p98RJu10dza9JeLqj2N3J+HuYsat3qpyE2/okY2BJAT3AOxZZ818/HCwRF4nLZvFPKvWie BvgAhmbL7B8wqZFtw7FrbTN2Ct6q1kY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 04/13] tools/xenstore: add framework to commit accounting data on success only Date: Wed, 5 Apr 2023 09:03:40 +0200 Message-Id: <20230405070349.25293-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole operation has succeeded. This scheme can reuse large parts of the per transaction accounting. The changed_domain handling can be reused, but the array size of the accounting data should be possible to be different for both use cases. Signed-off-by: Juergen Gross --- V3: - call acc_commit() earlier (Julien Grall) - add assert() to acc_commit() - use fixed sized acc array in struct changed_domain (Julien Grall) --- tools/xenstore/xenstored_core.c | 9 ++++-- tools/xenstore/xenstored_core.h | 3 ++ tools/xenstore/xenstored_domain.c | 53 ++++++++++++++++++++++++++++++- tools/xenstore/xenstored_domain.h | 5 ++- 4 files changed, 66 insertions(+), 4 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 3ca68681e3..84335f5f3d 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1023,6 +1023,9 @@ static void send_error(struct connection *conn, int error) break; } } + + acc_drop(conn); + send_reply(conn, XS_ERROR, xsd_errors[i].errstring, strlen(xsd_errors[i].errstring) + 1); } @@ -1034,6 +1037,9 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, assert(type != XS_WATCH_EVENT); + conn->in = NULL; + acc_commit(conn); + if ( len > XENSTORE_PAYLOAD_MAX ) { send_error(conn, E2BIG); return; @@ -1059,8 +1065,6 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, } } - conn->in = NULL; - /* Update relevant header fields and fill in the message body. */ bdata->hdr.msg.type = type; bdata->hdr.msg.len = len; @@ -2195,6 +2199,7 @@ struct connection *new_connection(const struct interface_funcs *funcs) new->is_stalled = false; new->transaction_started = 0; INIT_LIST_HEAD(&new->out_list); + INIT_LIST_HEAD(&new->acc_list); INIT_LIST_HEAD(&new->ref_list); INIT_LIST_HEAD(&new->watches); INIT_LIST_HEAD(&new->transaction_list); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index c59b06551f..1f811f38cb 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -139,6 +139,9 @@ struct connection struct list_head out_list; uint64_t timeout_msec; + /* Not yet committed accounting data (valid if in != NULL). */ + struct list_head acc_list; + /* Referenced requests no longer pending. */ struct list_head ref_list; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 30fb9acec6..144cbafb73 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -91,6 +91,8 @@ struct domain bool wrl_delay_logged; }; +#define ACC_CHD_N (ACC_TR_N < ACC_REQ_N ? ACC_REQ_N : ACC_TR_N) + struct changed_domain { /* List of all changed domains. */ @@ -100,7 +102,7 @@ struct changed_domain unsigned int domid; /* Accounting data. */ - int acc[ACC_TR_N]; + int acc[ACC_CHD_N]; }; static struct hashtable *domhash; @@ -1070,6 +1072,7 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, enum accitem what, int add, bool no_dom_alloc) { struct domain *d; + struct changed_domain *cd; struct list_head *head; int ret; @@ -1090,6 +1093,22 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, } } + /* Temporary accounting data until final commit? */ + if (conn && conn->in && what < ACC_REQ_N) { + /* Consider transaction local data. */ + ret = 0; + if (conn->transaction && what < ACC_TR_N) { + head = transaction_get_changed_domains( + conn->transaction); + cd = acc_find_changed_domain(head, domid); + if (cd) + ret = cd->acc[what]; + } + ret += acc_add_changed_dom(conn->in, &conn->acc_list, what, + add, domid); + return errno ? -1 : domain_acc_add_valid(d, what, ret); + } + if (conn && conn->transaction && what < ACC_TR_N) { head = transaction_get_changed_domains(conn->transaction); ret = acc_add_changed_dom(conn->transaction, head, what, @@ -1106,6 +1125,38 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, return d->acc[what]; } +void acc_drop(struct connection *conn) +{ + struct changed_domain *cd; + + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { + list_del(&cd->list); + talloc_free(cd); + } +} + +void acc_commit(struct connection *conn) +{ + struct changed_domain *cd; + enum accitem what; + + /* + * Make sure domain_acc_add() below can't add additional data to + * to be committed accounting records. + */ + assert(!conn->in); + + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { + list_del(&cd->list); + for (what = 0; what < ACC_REQ_N; what++) + if (cd->acc[what]) + domain_acc_add(conn, cd->domid, what, + cd->acc[what], true); + + talloc_free(cd); + } +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 9d05eb01da..6355ad4f37 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -25,7 +25,8 @@ * a per transaction array. */ enum accitem { - ACC_NODES, + ACC_REQ_N, /* Number of elements per request. */ + ACC_NODES = ACC_REQ_N, ACC_TR_N, /* Number of elements per transaction. */ ACC_N = ACC_TR_N, /* Number of elements per domain. */ }; @@ -113,6 +114,8 @@ int domain_get_quota(const void *ctx, struct connection *conn, * If "update" is true, "chk_quota" is ignored. */ int acc_fix_domains(struct list_head *head, bool chk_quota, bool update); +void acc_drop(struct connection *conn); +void acc_commit(struct connection *conn); /* Write rate limiting */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518237.804578 (Exim 4.92) (envelope-from ) id 1pjxBt-0004Ar-HX; Wed, 05 Apr 2023 07:04:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518237.804578; Wed, 05 Apr 2023 07:04:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBt-0004Ak-Em; Wed, 05 Apr 2023 07:04:21 +0000 Received: by outflank-mailman (input) for mailman id 518237; Wed, 05 Apr 2023 07:04:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBs-0002UC-Dn for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:20 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15fee7ff-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 943DD229D0; Wed, 5 Apr 2023 07:04:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6637513A31; Wed, 5 Apr 2023 07:04:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qRGQF3MdLWSuEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15fee7ff-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zpWITZM/jycFaeqzkIbP5IXI6C0MvtvZCqGsXHa9q9E=; b=kTpVk4DwUfgPK7n3BwU0oPzleMoDtWJ447NcVfWzVjgXB+gyyHKQnZFa0k/Vr2vrOq9/LD HF4LHvHcGRpZHl9AJDKHA0UZmHI75Hu6Rn8600M4F1KRoyM3hM4yAivBTD1QMT3z8+BXXv 8+7tdsP+1izd8Xl53RPN1wneBPWYAXY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting Date: Wed, 5 Apr 2023 09:03:41 +0200 Message-Id: <20230405070349.25293-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the node accounting to the accounting information buffering in order to avoid having to undo it in case of failure. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 21 ++------------------- tools/xenstore/xenstored_domain.h | 4 ++-- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 84335f5f3d..92a40ccf3f 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1452,7 +1452,6 @@ static void destroy_node_rm(struct connection *conn, struct node *node) static int destroy_node(struct connection *conn, struct node *node) { destroy_node_rm(conn, node); - domain_nbentry_dec(conn, get_node_owner(node)); /* * It is not possible to easily revert the changes in a transaction. @@ -1797,27 +1796,11 @@ static int do_set_perms(const void *ctx, struct connection *conn, old_perms = node->perms; domain_nbentry_dec(conn, get_node_owner(node)); node->perms = perms; - if (domain_nbentry_inc(conn, get_node_owner(node))) { - node->perms = old_perms; - /* - * This should never fail because we had a reference on the - * domain before and Xenstored is single-threaded. - */ - domain_nbentry_inc(conn, get_node_owner(node)); + if (domain_nbentry_inc(conn, get_node_owner(node))) return ENOMEM; - } - if (write_node(conn, node, false)) { - int saved_errno = errno; - - domain_nbentry_dec(conn, get_node_owner(node)); - node->perms = old_perms; - /* No failure possible as above. */ - domain_nbentry_inc(conn, get_node_owner(node)); - - errno = saved_errno; + if (write_node(conn, node, false)) return errno; - } fire_watches(conn, ctx, name, node, false, &old_perms); send_ack(conn, XS_SET_PERMS); diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 6355ad4f37..e669f57b80 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -25,9 +25,9 @@ * a per transaction array. */ enum accitem { + ACC_NODES, ACC_REQ_N, /* Number of elements per request. */ - ACC_NODES = ACC_REQ_N, - ACC_TR_N, /* Number of elements per transaction. */ + ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction. */ ACC_N = ACC_TR_N, /* Number of elements per domain. */ }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518241.804588 (Exim 4.92) (envelope-from ) id 1pjxC0-0004lL-QS; Wed, 05 Apr 2023 07:04:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518241.804588; Wed, 05 Apr 2023 07:04:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxC0-0004l9-NG; Wed, 05 Apr 2023 07:04:28 +0000 Received: by outflank-mailman (input) for mailman id 518241; Wed, 05 Apr 2023 07:04:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxBz-0002Et-6Z for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 195505f4-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:04:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D16D229ED; Wed, 5 Apr 2023 07:04:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0042613A31; Wed, 5 Apr 2023 07:04:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rYEsOngdLWS3EwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 195505f4-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KyUsGkw8xvAHU6kBBf8lvAgf5AlXfalzLddBzhYP/rg=; b=hS7Q1J2iA2PuHiGjs8dolF9hQLFzMKmnotf6iaAmoucNaCMbjfrmJqVN10kvlHLumpgt/M ncomGyud1nlnq0qh91uVHCijkS+y45dNDfUPzKrtysap+3mypWr4/sKPFJyz/WwzMvg+RY 6XxHAUO7n0xo+N+DCuNtj6ZUlhAq89M= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 06/13] tools/xenstore: add current connection to domain_memory_add() parameters Date: Wed, 5 Apr 2023 09:03:42 +0200 Message-Id: <20230405070349.25293-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to enable switching memory accounting to the generic array based accounting, add the current connection to the parameters of domain_memory_add(). This requires to add the connection to some other functions, too. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 28 ++++++++++++++++------------ tools/xenstore/xenstored_domain.c | 3 ++- tools/xenstore/xenstored_domain.h | 14 +++++++++----- tools/xenstore/xenstored_watch.c | 11 ++++++----- 4 files changed, 33 insertions(+), 23 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 92a40ccf3f..88ae674523 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -246,7 +246,8 @@ static void free_buffered_data(struct buffered_data *out, } } - domain_memory_add_nochk(conn->id, -out->hdr.msg.len - sizeof(out->hdr)); + domain_memory_add_nochk(conn, conn->id, + -out->hdr.msg.len - sizeof(out->hdr)); if (out->hdr.msg.type == XS_WATCH_EVENT) { req = out->pend.req; @@ -631,24 +632,25 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, * nodes to new owners. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, -old_acc.memory - key->dsize); - ret = domain_memory_add(new_domid, data->dsize + key->dsize, - no_quota_check); + ret = domain_memory_add(conn, new_domid, + data->dsize + key->dsize, no_quota_check); if (ret) { /* Error path, so no quota check. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, old_acc.memory + key->dsize); return ret; } /* TDB should set errno, but doesn't even set ecode AFAICT. */ if (tdb_store(tdb_ctx, *key, *data, TDB_REPLACE) != 0) { - domain_memory_add_nochk(new_domid, -data->dsize - key->dsize); + domain_memory_add_nochk(conn, new_domid, + -data->dsize - key->dsize); /* Error path, so no quota check. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, old_acc.memory + key->dsize); errno = EIO; return errno; @@ -683,7 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, if (acc->memory) { domid = get_acc_domid(conn, key, acc->domid); - domain_memory_add_nochk(domid, -acc->memory - key->dsize); + domain_memory_add_nochk(conn, domid, -acc->memory - key->dsize); } return 0; @@ -1055,11 +1057,13 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, if (len <= DEFAULT_BUFFER_SIZE) { bdata->buffer = bdata->default_buffer; /* Don't check quota, path might be used for returning error. */ - domain_memory_add_nochk(conn->id, len + sizeof(bdata->hdr)); + domain_memory_add_nochk(conn, conn->id, + len + sizeof(bdata->hdr)); } else { bdata->buffer = talloc_array(bdata, char, len); if (!bdata->buffer || - domain_memory_add_chk(conn->id, len + sizeof(bdata->hdr))) { + domain_memory_add_chk(conn, conn->id, + len + sizeof(bdata->hdr))) { send_error(conn, ENOMEM); return; } @@ -1122,7 +1126,7 @@ void send_event(struct buffered_data *req, struct connection *conn, } } - if (domain_memory_add_chk(conn->id, len + sizeof(bdata->hdr))) { + if (domain_memory_add_chk(conn, conn->id, len + sizeof(bdata->hdr))) { talloc_free(bdata); return; } @@ -3322,7 +3326,7 @@ static void add_buffered_data(struct buffered_data *bdata, * be smaller. So ignore it. The limit will be applied for any resource * after the state has been fully restored. */ - domain_memory_add_nochk(conn->id, len + sizeof(bdata->hdr)); + domain_memory_add_nochk(conn, conn->id, len + sizeof(bdata->hdr)); } void read_state_buffered_data(const void *ctx, struct connection *conn, diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 144cbafb73..f94812610a 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1235,7 +1235,8 @@ static bool domain_chk_quota(struct domain *domain, int mem) return false; } -int domain_memory_add(unsigned int domid, int mem, bool no_quota_check) +int domain_memory_add(struct connection *conn, unsigned int domid, int mem, + bool no_quota_check) { struct domain *domain; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index e669f57b80..5cfd730cf6 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -80,25 +80,29 @@ int domain_nbentry_inc(struct connection *conn, unsigned int domid); int domain_nbentry_dec(struct connection *conn, unsigned int domid); int domain_nbentry_fix(unsigned int domid, int num, bool update); unsigned int domain_nbentry(struct connection *conn); -int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); +int domain_memory_add(struct connection *conn, unsigned int domid, int mem, + bool no_quota_check); /* * domain_memory_add_chk(): to be used when memory quota should be checked. * Not to be used when specifying a negative mem value, as lowering the used * memory should always be allowed. */ -static inline int domain_memory_add_chk(unsigned int domid, int mem) +static inline int domain_memory_add_chk(struct connection *conn, + unsigned int domid, int mem) { - return domain_memory_add(domid, mem, false); + return domain_memory_add(conn, domid, mem, false); } + /* * domain_memory_add_nochk(): to be used when memory quota should not be * checked, e.g. when lowering memory usage, or in an error case for undoing * a previous memory adjustment. */ -static inline void domain_memory_add_nochk(unsigned int domid, int mem) +static inline void domain_memory_add_nochk(struct connection *conn, + unsigned int domid, int mem) { - domain_memory_add(domid, mem, true); + domain_memory_add(conn, domid, mem, true); } void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 8ad0229df6..e30cd89be3 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -199,7 +199,7 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token, watch->token = talloc_strdup(watch, token); if (!watch->node || !watch->token) goto nomem; - if (domain_memory_add(conn->id, strlen(path) + strlen(token), + if (domain_memory_add(conn, conn->id, strlen(path) + strlen(token), no_quota_check)) goto nomem; @@ -274,8 +274,9 @@ int do_unwatch(const void *ctx, struct connection *conn, list_for_each_entry(watch, &conn->watches, list) { if (streq(watch->node, node) && streq(watch->token, vec[1])) { list_del(&watch->list); - domain_memory_add_nochk(conn->id, -strlen(watch->node) - - strlen(watch->token)); + domain_memory_add_nochk(conn, conn->id, + -strlen(watch->node) - + strlen(watch->token)); talloc_free(watch); domain_watch_dec(conn); send_ack(conn, XS_UNWATCH); @@ -291,8 +292,8 @@ void conn_delete_all_watches(struct connection *conn) while ((watch = list_top(&conn->watches, struct watch, list))) { list_del(&watch->list); - domain_memory_add_nochk(conn->id, -strlen(watch->node) - - strlen(watch->token)); + domain_memory_add_nochk(conn, conn->id, -strlen(watch->node) - + strlen(watch->token)); talloc_free(watch); domain_watch_dec(conn); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518244.804598 (Exim 4.92) (envelope-from ) id 1pjxC6-0005Fx-1l; Wed, 05 Apr 2023 07:04:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518244.804598; Wed, 05 Apr 2023 07:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxC5-0005F8-U0; Wed, 05 Apr 2023 07:04:33 +0000 Received: by outflank-mailman (input) for mailman id 518244; Wed, 05 Apr 2023 07:04:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxC3-0002UC-Rz for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cacb26e-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BCE9D229FF; Wed, 5 Apr 2023 07:04:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F10E13A31; Wed, 5 Apr 2023 07:04:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id whOiIX4dLWTHEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cacb26e-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXnL6y0xe3ujnGIrpffgz9CI+U2tC4w1dZmiNxkMXsw=; b=W7D+JLybanPWNvnVDx6eoSXB/U3WJR6A7WZ9HEE3UUKI5O26jvf9gW0MfxlUvBkM7mydAw llKH5a7EwZZXjTgpPQxN7NF4APfwC9TjembZO5rkzqIuoTkLjxb6ghyYN2iBRTzH/hlIyU os3novb/1onmO6ME64axrSDcIZqN0po= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 07/13] tools/xenstore: use accounting data array for per-domain values Date: Wed, 5 Apr 2023 09:03:43 +0200 Message-Id: <20230405070349.25293-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the accounting of per-domain usage of Xenstore memory, watches, and outstanding requests to the array based mechanism. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 8 +-- tools/xenstore/xenstored_domain.c | 111 +++++++++++------------------- tools/xenstore/xenstored_domain.h | 10 +-- 3 files changed, 52 insertions(+), 77 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 88ae674523..67aa7c1578 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -255,7 +255,7 @@ static void free_buffered_data(struct buffered_data *out, req->pend.ref.event_cnt--; if (!req->pend.ref.event_cnt && !req->on_out_list) { if (req->on_ref_list) { - domain_outstanding_domid_dec( + domain_outstanding_dec(conn, req->pend.ref.domid); list_del(&req->list); } @@ -271,7 +271,7 @@ static void free_buffered_data(struct buffered_data *out, out->on_ref_list = true; return; } else - domain_outstanding_dec(conn); + domain_outstanding_dec(conn, conn->id); talloc_free(out); } @@ -1077,7 +1077,7 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, /* Queue for later transmission. */ list_add_tail(&bdata->list, &conn->out_list); bdata->on_out_list = true; - domain_outstanding_inc(conn); + domain_outstanding_inc(conn, conn->id); } /* @@ -3320,7 +3320,7 @@ static void add_buffered_data(struct buffered_data *bdata, * request have been delivered. */ if (bdata->hdr.msg.type != XS_WATCH_EVENT) - domain_outstanding_inc(conn); + domain_outstanding_inc(conn, conn->id); /* * We are restoring the state after Live-Update and the new quota may * be smaller. So ignore it. The limit will be applied for any resource diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f94812610a..22836ae881 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -72,19 +72,12 @@ struct domain /* Accounting data for this domain. */ unsigned int acc[ACC_N]; - /* Amount of memory allocated for this domain. */ - int memory; + /* Memory quota data for this domain. */ bool soft_quota_reported; bool hard_quota_reported; time_t mem_last_msg; #define MEM_WARN_MINTIME_SEC 10 - /* number of watch for this domain */ - int nbwatch; - - /* Number of outstanding requests. */ - int nboutstanding; - /* write rate limit */ wrl_creditt wrl_credit; /* [ -wrl_config_writecost, +_dburst ] */ struct wrl_timestampt wrl_timestamp; @@ -202,14 +195,15 @@ static bool domain_can_write(struct connection *conn) static bool domain_can_read(struct connection *conn) { - struct xenstore_domain_interface *intf = conn->domain->interface; + struct domain *domain = conn->domain; + struct xenstore_domain_interface *intf = domain->interface; if (domain_is_unprivileged(conn)) { - if (conn->domain->wrl_credit < 0) + if (domain->wrl_credit < 0) return false; - if (conn->domain->nboutstanding >= quota_req_outstanding) + if (domain->acc[ACC_OUTST] >= quota_req_outstanding) return false; - if (conn->domain->memory >= quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM] >= quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -440,10 +434,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, if (!resp) return ENOMEM ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->nbwatch); + ent(watches, d->acc[ACC_WATCH]); ent(transactions, ta); - ent(outstanding, d->nboutstanding); - ent(memory, d->memory); + ent(outstanding, d->acc[ACC_OUTST]); + ent(memory, d->acc[ACC_MEM]); #undef ent @@ -1186,14 +1180,16 @@ unsigned int domain_nbentry(struct connection *conn) ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } -static bool domain_chk_quota(struct domain *domain, int mem) +static bool domain_chk_quota(struct connection *conn, unsigned int mem) { time_t now; + struct domain *domain; - if (!domain || !domid_is_unprivileged(domain->domid) || - (domain->conn && domain->conn->is_ignored)) + if (!conn || !domid_is_unprivileged(conn->id) || + conn->is_ignored) return false; + domain = conn->domain; now = time(NULL); if (mem >= quota_memory_per_domain_hard && @@ -1238,80 +1234,57 @@ static bool domain_chk_quota(struct domain *domain, int mem) int domain_memory_add(struct connection *conn, unsigned int domid, int mem, bool no_quota_check) { - struct domain *domain; + int ret; - domain = find_domain_struct(domid); - if (domain) { - /* - * domain_chk_quota() will print warning and also store whether - * the soft/hard quota has been hit. So check no_quota_check - * *after*. - */ - if (domain_chk_quota(domain, domain->memory + mem) && - !no_quota_check) - return ENOMEM; - domain->memory += mem; - } else { - /* - * The domain the memory is to be accounted for should always - * exist, as accounting is done either for a domain related to - * the current connection, or for the domain owning a node - * (which is always existing, as the owner of the node is - * tested to exist and deleted or replaced by domid 0 if not). - * So not finding the related domain MUST be an error in the - * data base. - */ - errno = ENOENT; - corrupt(NULL, "Accounting called for non-existing domain %u\n", - domid); - return ENOENT; - } + ret = domain_acc_add(conn, domid, ACC_MEM, 0, true); + if (ret < 0) + return -ret; + + /* + * domain_chk_quota() will print warning and also store whether the + * soft/hard quota has been hit. So check no_quota_check *after*. + */ + if (domain_chk_quota(conn, ret + mem) && !no_quota_check) + return ENOMEM; + + /* + * The domain the memory is to be accounted for should always exist, + * as accounting is done either for a domain related to the current + * connection, or for the domain owning a node (which is always + * existing, as the owner of the node is tested to exist and deleted + * or replaced by domid 0 if not). + * So not finding the related domain MUST be an error in the data base. + */ + domain_acc_add(conn, domid, ACC_MEM, mem, true); return 0; } void domain_watch_inc(struct connection *conn) { - if (!conn || !conn->domain) - return; - conn->domain->nbwatch++; + domain_acc_add(conn, conn->id, ACC_WATCH, 1, true); } void domain_watch_dec(struct connection *conn) { - if (!conn || !conn->domain) - return; - if (conn->domain->nbwatch) - conn->domain->nbwatch--; + domain_acc_add(conn, conn->id, ACC_WATCH, -1, true); } int domain_watch(struct connection *conn) { return (domain_is_unprivileged(conn)) - ? conn->domain->nbwatch + ? domain_acc_add(conn, conn->id, ACC_WATCH, 0, true) : 0; } -void domain_outstanding_inc(struct connection *conn) +void domain_outstanding_inc(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding++; + domain_acc_add(conn, domid, ACC_OUTST, 1, true); } -void domain_outstanding_dec(struct connection *conn) +void domain_outstanding_dec(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding--; -} - -void domain_outstanding_domid_dec(unsigned int domid) -{ - struct domain *d = find_domain_by_domid(domid); - - if (d) - d->nboutstanding--; + domain_acc_add(conn, domid, ACC_OUTST, -1, true); } static wrl_creditt wrl_config_writecost = WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 5cfd730cf6..0d61bf4344 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -28,7 +28,10 @@ enum accitem { ACC_NODES, ACC_REQ_N, /* Number of elements per request. */ ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction. */ - ACC_N = ACC_TR_N, /* Number of elements per domain. */ + ACC_WATCH = ACC_TR_N, + ACC_OUTST, + ACC_MEM, + ACC_N, /* Number of elements per domain. */ }; void handle_event(void); @@ -107,9 +110,8 @@ static inline void domain_memory_add_nochk(struct connection *conn, void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); -void domain_outstanding_inc(struct connection *conn); -void domain_outstanding_dec(struct connection *conn); -void domain_outstanding_domid_dec(unsigned int domid); +void domain_outstanding_inc(struct connection *conn, unsigned int domid); +void domain_outstanding_dec(struct connection *conn, unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:04:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518248.804607 (Exim 4.92) (envelope-from ) id 1pjxCA-0005jl-AN; Wed, 05 Apr 2023 07:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518248.804607; Wed, 05 Apr 2023 07:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxCA-0005jc-6c; Wed, 05 Apr 2023 07:04:38 +0000 Received: by outflank-mailman (input) for mailman id 518248; Wed, 05 Apr 2023 07:04:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxC9-0002UC-5c for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:37 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 200ce63f-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:36 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7340C20592; Wed, 5 Apr 2023 07:04:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D6E213A31; Wed, 5 Apr 2023 07:04:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TNk3DYQdLWTWEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 200ce63f-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678276; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0FVX/N0LxAMOywC2jlDscHABd/v4BQEj8zV+MLHaj68=; b=kkFJhyYeVvEhEobwXdCyZzLJpbdI1PB+Q0ceqAJQc3IV+ScoJrBQheTkPhfSOhU8j3Zi3j 3ilgCE1AnCRHhreOXN4+uAJwR+yzepxIshlSbqaD/7DaYRvHBtTmzKm2pa5Bk8NRtaU9Sq BdXYeOhCOuCgRFvcGQSoWQSQhTyy5rs= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v4 08/13] tools/xenstore: add accounting trace support Date: Wed, 5 Apr 2023 09:03:44 +0200 Message-Id: <20230405070349.25293-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new trace switch "acc" and the related trace calls. The "acc" switch is off per default. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 1 + tools/xenstore/xenstored_domain.c | 10 ++++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 67aa7c1578..bd816ce709 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2746,7 +2746,7 @@ static void set_quota(const char *arg, bool soft) /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ const char *const trace_switches[] = { - "obj", "io", "wrl", + "obj", "io", "wrl", "acc", NULL }; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 1f811f38cb..3e0734a6c6 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -302,6 +302,7 @@ extern unsigned int trace_flags; #define TRACE_OBJ 0x00000001 #define TRACE_IO 0x00000002 #define TRACE_WRL 0x00000004 +#define TRACE_ACC 0x00000008 extern const char *const trace_switches[]; int set_trace_switch(const char *arg); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 22836ae881..1caa60bb14 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -540,6 +540,12 @@ static struct domain *find_domain_by_domid(unsigned int domid) return (d && d->introduced) ? d : NULL; } +#define trace_acc(...) \ +do { \ + if (trace_flags & TRACE_ACC) \ + trace("acc: " __VA_ARGS__); \ +} while (0) + int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) { struct changed_domain *cd; @@ -603,6 +609,8 @@ static int acc_add_changed_dom(const void *ctx, struct list_head *head, return 0; errno = 0; + trace_acc("local change domid %u: what=%u %d add %d\n", domid, what, + cd->acc[what], val); cd->acc[what] += val; return cd->acc[what]; @@ -1114,6 +1122,8 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, return domain_acc_add_valid(d, what, ret); } + trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, + d->acc[what], add); d->acc[what] = domain_acc_add_valid(d, what, add); return d->acc[what]; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:09:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518261.804629 (Exim 4.92) (envelope-from ) id 1pjxGM-0007Z9-Lm; Wed, 05 Apr 2023 07:08:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518261.804629; Wed, 05 Apr 2023 07:08:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxGM-0007Xk-FN; Wed, 05 Apr 2023 07:08:58 +0000 Received: by outflank-mailman (input) for mailman id 518261; Wed, 05 Apr 2023 07:08:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxCR-0002Et-GC for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2a24292f-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:04:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5B43C229D0; Wed, 5 Apr 2023 07:04:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 183F713A31; Wed, 5 Apr 2023 07:04:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y9STBJUdLWT9EwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a24292f-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ZcKfGTywyhrwZZUE2CTmIRIHQZRyLmi1TNVZ6l6MAw=; b=J85PbfdL8z3iCw2B4Q1bk3oMnyCK50oEidaoR42ZPYCoHHWj/yqLNNp6LOgrjYls97N18/ HkhQHaOPux3ZgThOWGXZFOewgIISa3eegqDDkkgUuomSi7g5tmcBvk97MQJ7ZTrK/9OCsv JTZWK5b6oNvQifldTqW7itnzi5IUMd8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH v4 11/13] tools/xenstore: remember global and per domain max accounting values Date: Wed, 5 Apr 2023 09:03:47 +0200 Message-Id: <20230405070349.25293-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add saving the maximum values of the different accounting data seen per domain and (for unprivileged domains) globally, and print those values via the xenstore-control quota command. Add a sub-command for resetting the global maximum values seen. This should help for a decision how to set the related quotas. Signed-off-by: Juergen Gross --- docs/misc/xenstore.txt | 5 +- tools/xenstore/xenstored_control.c | 22 ++++++- tools/xenstore/xenstored_domain.c | 100 +++++++++++++++++++++++------ tools/xenstore/xenstored_domain.h | 2 + 4 files changed, 108 insertions(+), 21 deletions(-) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index d807ef0709..38015835b1 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -426,7 +426,7 @@ CONTROL |[|] print| print to syslog (xenstore runs as daemon) or to console (xenstore runs as stubdom) - quota|[set |] + quota|[set ||max [-r]] without parameters: print the current quota settings with "set ": set the quota to new value (The admin should make sure all the domain usage is @@ -435,6 +435,9 @@ CONTROL |[|] violating the new quota setting isn't increased further) with "": print quota related accounting data for the domain + with "max [-r]": show global per-domain maximum values of all + unprivileged domains, optionally reset the values by adding + "-r" quota-soft|[set ] like the "quota" command, but for soft-quota. help diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index cbd62556c3..a2ba64a15c 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -306,6 +306,22 @@ static int quota_get(const void *ctx, struct connection *conn, return domain_get_quota(ctx, conn, atoi(vec[0])); } +static int quota_max(const void *ctx, struct connection *conn, + char **vec, int num) +{ + if (num > 1) + return EINVAL; + + if (num == 1) { + if (!strcmp(vec[0], "-r")) + domain_reset_global_acc(); + else + return EINVAL; + } + + return domain_max_global_acc(ctx, conn); +} + static int do_control_quota(const void *ctx, struct connection *conn, char **vec, int num) { @@ -315,6 +331,9 @@ static int do_control_quota(const void *ctx, struct connection *conn, if (!strcmp(vec[0], "set")) return quota_set(ctx, conn, vec + 1, num - 1, hard_quotas); + if (!strcmp(vec[0], "max")) + return quota_max(ctx, conn, vec + 1, num - 1); + return quota_get(ctx, conn, vec, num); } @@ -978,7 +997,8 @@ static struct cmd_s cmds[] = { { "memreport", do_control_memreport, "[]" }, #endif { "print", do_control_print, "" }, - { "quota", do_control_quota, "[set |]" }, + { "quota", do_control_quota, + "[set ||max [-r]]" }, { "quota-soft", do_control_quota_s, "[set ]" }, { "help", do_control_help, "" }, }; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 40bcc1dbfa..d21f31da92 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,6 +43,8 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; +static unsigned int acc_global_max[ACC_N]; + struct domain { /* The id of this domain */ @@ -70,7 +72,10 @@ struct domain bool introduced; /* Accounting data for this domain. */ - unsigned int acc[ACC_N]; + struct acc { + unsigned int val; + unsigned int max; + } acc[ACC_N]; /* Memory quota data for this domain. */ bool soft_quota_reported; @@ -201,9 +206,9 @@ static bool domain_can_read(struct connection *conn) if (domain_is_unprivileged(conn)) { if (domain->wrl_credit < 0) return false; - if (domain->acc[ACC_OUTST] >= quota_req_outstanding) + if (domain->acc[ACC_OUTST].val >= quota_req_outstanding) return false; - if (domain->acc[ACC_MEM] >= quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM].val >= quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -266,7 +271,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, ret = WALK_TREE_SKIP_CHILDREN; } - return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; + return domain->acc[ACC_NODES].val ? ret : WALK_TREE_SUCCESS_STOP; } static void domain_tree_remove(struct domain *domain) @@ -274,7 +279,7 @@ static void domain_tree_remove(struct domain *domain) int ret; struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; - if (domain->acc[ACC_NODES]) { + if (domain->acc[ACC_NODES].val) { ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); if (ret == WALK_TREE_ERROR_STOP) syslog(LOG_ERR, @@ -428,14 +433,41 @@ int domain_get_quota(const void *ctx, struct connection *conn, return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ + resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ + d->acc[e].val, d->acc[e].max); \ + if (!resp) return ENOMEM + + ent(nodes, ACC_NODES); + ent(watches, ACC_WATCH); + ent(transactions, ACC_TRANS); + ent(outstanding, ACC_OUTST); + ent(memory, ACC_MEM); + +#undef ent + + send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); + + return 0; +} + +int domain_max_global_acc(const void *ctx, struct connection *conn) +{ + char *resp; + + resp = talloc_asprintf(ctx, "Max. seen accounting values:\n"); + if (!resp) + return ENOMEM; + +#define ent(t, e) \ + resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ + acc_global_max[e]); \ if (!resp) return ENOMEM - ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->acc[ACC_WATCH]); - ent(transactions, d->acc[ACC_TRANS]); - ent(outstanding, d->acc[ACC_OUTST]); - ent(memory, d->acc[ACC_MEM]); + ent(nodes, ACC_NODES); + ent(watches, ACC_WATCH); + ent(transactions, ACC_TRANS); + ent(outstanding, ACC_OUTST); + ent(memory, ACC_MEM); #undef ent @@ -1051,10 +1083,12 @@ int domain_adjust_node_perms(struct node *node) static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) { + unsigned int val; + assert(what < ARRAY_SIZE(d->acc)); - if ((add < 0 && -add > d->acc[what]) || - (add > 0 && (INT_MAX - d->acc[what]) < add)) { + if ((add < 0 && -add > d->acc[what].val) || + (add > 0 && (INT_MAX - d->acc[what].val) < add)) { /* * In a transaction when a node is being added/removed AND the * same node has been added/removed outside the transaction in @@ -1065,7 +1099,13 @@ static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) return (add < 0) ? 0 : INT_MAX; } - return d->acc[what] + add; + val = d->acc[what].val + add; + if (val > d->acc[what].max) + d->acc[what].max = val; + if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) + acc_global_max[what] = val; + + return val; } static int domain_acc_add(struct connection *conn, unsigned int domid, @@ -1121,10 +1161,10 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, } trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, - d->acc[what], add); - d->acc[what] = domain_acc_add_valid(d, what, add); + d->acc[what].val, add); + d->acc[what].val = domain_acc_add_valid(d, what, add); - return d->acc[what]; + return d->acc[what].val; } void acc_drop(struct connection *conn) @@ -1159,6 +1199,28 @@ void acc_commit(struct connection *conn) } } +static int domain_reset_global_acc_sub(const void *k, void *v, void *arg) +{ + struct domain *d = v; + unsigned int i; + + for (i = 0; i < ACC_N; i++) + d->acc[i].max = d->acc[i].val; + + return 0; +} + +void domain_reset_global_acc(void) +{ + unsigned int i; + + for (i = 0; i < ACC_N; i++) + acc_global_max[i] = 0; + + /* Set current max values seen. */ + hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) @@ -1659,7 +1721,7 @@ static int domain_check_acc_init_sub(const void *k, void *v, void *arg) * If everything is correct incrementing the value for each node will * result in dom->nodes being 0 at the end. */ - dom->nodes = -d->acc[ACC_NODES]; + dom->nodes = -d->acc[ACC_NODES].val; if (!hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); @@ -1714,7 +1776,7 @@ static int domain_check_acc_cb(const void *k, void *v, void *arg) if (!d) return 0; - d->acc[ACC_NODES] += dom->nodes; + d->acc[ACC_NODES].val += dom->nodes; return 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index abc766f343..b55c9bcc2d 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -126,6 +126,8 @@ int domain_get_quota(const void *ctx, struct connection *conn, int acc_fix_domains(struct list_head *head, bool chk_quota, bool update); void acc_drop(struct connection *conn); void acc_commit(struct connection *conn); +int domain_max_global_acc(const void *ctx, struct connection *conn); +void domain_reset_global_acc(void); /* Write rate limiting */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:09:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518260.804622 (Exim 4.92) (envelope-from ) id 1pjxGM-0007T6-9d; Wed, 05 Apr 2023 07:08:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518260.804622; Wed, 05 Apr 2023 07:08:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxGM-0007ST-6U; Wed, 05 Apr 2023 07:08:58 +0000 Received: by outflank-mailman (input) for mailman id 518260; Wed, 05 Apr 2023 07:08:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxCL-0002Et-ML for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26c01ddb-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:04:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA1E22058E; Wed, 5 Apr 2023 07:04:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7B8FD13A31; Wed, 5 Apr 2023 07:04:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aC3eHI8dLWTyEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26c01ddb-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+svNodvtqEzi347VmDVhAeqbmPB+a6CEyNMcH7A/78=; b=tnoiNvEK7wVRD3t0XP4Hb9wj9DRqF9BbSyC6DqYylJERvPZPE+SKEm+XT2wW86hDrWy8xB /v4wAUytR0s5QLSPDUknaFsDXTnPllXZP5H+DTDJbjKcl4L5+PBWKVbQU4+YHfxlPv2odP WPjJIR4tQYibRtvRn3i3I3iBFXgM4ig= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 10/13] tools/xenstore: switch transaction accounting to generic accounting Date: Wed, 5 Apr 2023 09:03:46 +0200 Message-Id: <20230405070349.25293-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As transaction accounting is active for unprivileged domains only, it can easily be added to the generic per-domain accounting. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 3 +-- tools/xenstore/xenstored_core.h | 1 - tools/xenstore/xenstored_domain.c | 21 ++++++++++++++++++--- tools/xenstore/xenstored_domain.h | 4 ++++ tools/xenstore/xenstored_transaction.c | 12 +++++------- 5 files changed, 28 insertions(+), 13 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 2d481fcad9..88c569b7d5 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2083,7 +2083,7 @@ static void consider_message(struct connection *conn) * stalled. This will ignore new requests until Live-Update happened * or it was aborted. */ - if (lu_is_pending() && conn->transaction_started == 0 && + if (lu_is_pending() && conn->ta_start_time == 0 && conn->in->hdr.msg.type == XS_TRANSACTION_START) { trace("Delaying transaction start for connection %p req_id %u\n", conn, conn->in->hdr.msg.req_id); @@ -2190,7 +2190,6 @@ struct connection *new_connection(const struct interface_funcs *funcs) new->funcs = funcs; new->is_ignored = false; new->is_stalled = false; - new->transaction_started = 0; INIT_LIST_HEAD(&new->out_list); INIT_LIST_HEAD(&new->acc_list); INIT_LIST_HEAD(&new->ref_list); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 5a11dc1231..3564d85d7d 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -151,7 +151,6 @@ struct connection /* List of in-progress transactions. */ struct list_head transaction_list; uint32_t next_transaction_id; - unsigned int transaction_started; time_t ta_start_time; /* List of delayed requests. */ diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 1caa60bb14..40bcc1dbfa 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -419,12 +419,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, { struct domain *d = find_domain_struct(domid); char *resp; - int ta; if (!d) return ENOENT; - ta = d->conn ? d->conn->transaction_started : 0; resp = talloc_asprintf(ctx, "Domain %u:\n", domid); if (!resp) return ENOMEM; @@ -435,7 +433,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, ent(nodes, d->acc[ACC_NODES]); ent(watches, d->acc[ACC_WATCH]); - ent(transactions, ta); + ent(transactions, d->acc[ACC_TRANS]); ent(outstanding, d->acc[ACC_OUTST]); ent(memory, d->acc[ACC_MEM]); @@ -1297,6 +1295,23 @@ void domain_outstanding_dec(struct connection *conn, unsigned int domid) domain_acc_add(conn, domid, ACC_OUTST, -1, true); } +void domain_transaction_inc(struct connection *conn) +{ + domain_acc_add(conn, conn->id, ACC_TRANS, 1, true); +} + +void domain_transaction_dec(struct connection *conn) +{ + domain_acc_add(conn, conn->id, ACC_TRANS, -1, true); +} + +unsigned int domain_transaction_get(struct connection *conn) +{ + return (domain_is_unprivileged(conn)) + ? domain_acc_add(conn, conn->id, ACC_TRANS, 0, true) + : 0; +} + static wrl_creditt wrl_config_writecost = WRL_FACTOR; static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 0d61bf4344..abc766f343 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -31,6 +31,7 @@ enum accitem { ACC_WATCH = ACC_TR_N, ACC_OUTST, ACC_MEM, + ACC_TRANS, ACC_N, /* Number of elements per domain. */ }; @@ -112,6 +113,9 @@ void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); void domain_outstanding_inc(struct connection *conn, unsigned int domid); void domain_outstanding_dec(struct connection *conn, unsigned int domid); +void domain_transaction_inc(struct connection *conn); +void domain_transaction_dec(struct connection *conn); +unsigned int domain_transaction_get(struct connection *conn); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 11c8bcec84..1c14b8579a 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -479,8 +479,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (conn->transaction) return EBUSY; - if (domain_is_unprivileged(conn) && - conn->transaction_started > quota_max_transaction) + if (domain_transaction_get(conn) > quota_max_transaction) return ENOSPC; /* Attach transaction to ctx for autofree until it's complete */ @@ -505,9 +504,9 @@ int do_transaction_start(const void *ctx, struct connection *conn, list_add_tail(&trans->list, &conn->transaction_list); talloc_steal(conn, trans); talloc_set_destructor(trans, destroy_transaction); - if (!conn->transaction_started) + if (!conn->ta_start_time) conn->ta_start_time = time(NULL); - conn->transaction_started++; + domain_transaction_inc(conn); wrl_ntransactions++; snprintf(id_str, sizeof(id_str), "%u", trans->id); @@ -533,8 +532,8 @@ int do_transaction_end(const void *ctx, struct connection *conn, conn->transaction = NULL; list_del(&trans->list); - conn->transaction_started--; - if (!conn->transaction_started) + domain_transaction_dec(conn); + if (list_empty(&conn->transaction_list)) conn->ta_start_time = 0; chk_quota = trans->node_created && domain_is_unprivileged(conn); @@ -588,7 +587,6 @@ void conn_delete_all_transactions(struct connection *conn) assert(conn->transaction == NULL); - conn->transaction_started = 0; conn->ta_start_time = 0; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:09:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518257.804618 (Exim 4.92) (envelope-from ) id 1pjxGM-0007Qe-2V; Wed, 05 Apr 2023 07:08:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518257.804618; Wed, 05 Apr 2023 07:08:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxGL-0007QS-W0; Wed, 05 Apr 2023 07:08:57 +0000 Received: by outflank-mailman (input) for mailman id 518257; Wed, 05 Apr 2023 07:08:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxCX-0002Et-31 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:05:01 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d7be2a9-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:04:59 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F139B203F7; Wed, 5 Apr 2023 07:04:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C72B113A31; Wed, 5 Apr 2023 07:04:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cxhLL5odLWQKFAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d7be2a9-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCyLt0zxkjWxud2x9uGxTV8f0obgprf3/tY/K8k0jbw=; b=JMkSCFp31r0fIZPNH2AkMftQJA+mpIcj9jvbs5ufb0Ar0XBybtUowBEtZDvBcP2LTjksJF fqxANAkevAZlQI+gakDpVPD8TisCAKrF0fcbvK1C5jjSE/LCDkdGF8CT6w2ukbn0+ujGx6 xNfbNEucYtgjqwKlr68nrI4H020r5Bo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas Date: Wed, 5 Apr 2023 09:03:48 +0200 Message-Id: <20230405070349.25293-13-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count values. Nevertheless being able to know the maximum number of those quota related values per domain would be beneficial, so add them to the generic accounting. The per domain value will never show current numbers other than zero, but the maximum number seen can be gathered the same way as the number of nodes during a transaction. To be able to use the const qualifier for a new function switch domain_is_unprivileged() to take a const pointer, too. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 14 ++++----- tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 39 ++++++++++++++++++++------ tools/xenstore/xenstored_domain.h | 6 ++++ tools/xenstore/xenstored_transaction.c | 4 +-- tools/xenstore/xenstored_watch.c | 2 +- 6 files changed, 48 insertions(+), 19 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 88c569b7d5..65df2866bf 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -799,8 +799,8 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, + node->perms.num * sizeof(node->perms.p[0]) + node->datalen + node->childlen; - if (!no_quota_check && domain_is_unprivileged(conn) && - data.dsize >= quota_max_entry_size) { + if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) + && !no_quota_check) { errno = ENOSPC; return errno; } @@ -1168,7 +1168,7 @@ static bool valid_chars(const char *node) "0123456789-/_@") == strlen(node)); } -bool is_valid_nodename(const char *node) +bool is_valid_nodename(const struct connection *conn, const char *node) { int local_off = 0; unsigned int domid; @@ -1188,7 +1188,8 @@ bool is_valid_nodename(const char *node) if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) local_off = 0; - if (strlen(node) > local_off + quota_max_path_len) + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, + quota_max_path_len)) return false; return valid_chars(node); @@ -1250,7 +1251,7 @@ static struct node *get_node_canonicalized(struct connection *conn, *canonical_name = canonicalize(conn, ctx, name); if (!*canonical_name) return NULL; - if (!is_valid_nodename(*canonical_name)) { + if (!is_valid_nodename(conn, *canonical_name)) { errno = EINVAL; return NULL; } @@ -1775,8 +1776,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EINVAL; perms.num--; - if (domain_is_unprivileged(conn) && - perms.num > quota_nb_perms_per_node) + if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) return ENOSPC; permstr = in->buffer + strlen(in->buffer) + 1; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 3564d85d7d..9339820156 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -258,7 +258,7 @@ void check_store(void); void corrupt(struct connection *conn, const char *fmt, ...); /* Is this a valid node name? */ -bool is_valid_nodename(const char *node); +bool is_valid_nodename(const struct connection *conn, const char *node); /* Get name of parent node. */ char *get_parent(const void *ctx, const char *node); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index d21f31da92..49e2c5c82a 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -433,7 +433,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ + resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ d->acc[e].val, d->acc[e].max); \ if (!resp) return ENOMEM @@ -442,6 +442,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, ent(transactions, ACC_TRANS); ent(outstanding, ACC_OUTST); ent(memory, ACC_MEM); + ent(transaction-nodes, ACC_TRANSNODES); #undef ent @@ -459,7 +460,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ acc_global_max[e]); \ if (!resp) return ENOMEM @@ -468,6 +469,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) ent(transactions, ACC_TRANS); ent(outstanding, ACC_OUTST); ent(memory, ACC_MEM); + ent(transaction-nodes, ACC_TRANSNODES); #undef ent @@ -1081,12 +1083,22 @@ int domain_adjust_node_perms(struct node *node) return 0; } +static void domain_acc_valid_max(struct domain *d, enum accitem what, + unsigned int val) +{ + assert(what < ARRAY_SIZE(d->acc)); + assert(what < ARRAY_SIZE(acc_global_max)); + + if (val > d->acc[what].max) + d->acc[what].max = val; + if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) + acc_global_max[what] = val; +} + static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) { unsigned int val; - assert(what < ARRAY_SIZE(d->acc)); - if ((add < 0 && -add > d->acc[what].val) || (add > 0 && (INT_MAX - d->acc[what].val) < add)) { /* @@ -1100,10 +1112,7 @@ static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) } val = d->acc[what].val + add; - if (val > d->acc[what].max) - d->acc[what].max = val; - if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) - acc_global_max[what] = val; + domain_acc_valid_max(d, what, val); return val; } @@ -1221,6 +1230,20 @@ void domain_reset_global_acc(void) hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); } +bool domain_max_chk(const struct connection *conn, enum accitem what, + unsigned int val, unsigned int quota) +{ + if (!conn || !conn->domain) + return false; + + if (domain_is_unprivileged(conn) && val > quota) + return true; + + domain_acc_valid_max(conn->domain, what, val); + + return false; +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index b55c9bcc2d..3e17b63659 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -32,6 +32,10 @@ enum accitem { ACC_OUTST, ACC_MEM, ACC_TRANS, + ACC_TRANSNODES, + ACC_NPERM, + ACC_PATHLEN, + ACC_NODESZ, ACC_N, /* Number of elements per domain. */ }; @@ -128,6 +132,8 @@ void acc_drop(struct connection *conn); void acc_commit(struct connection *conn); int domain_max_global_acc(const void *ctx, struct connection *conn); void domain_reset_global_acc(void); +bool domain_max_chk(const struct connection *conn, unsigned int what, + unsigned int val, unsigned int quota); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 1c14b8579a..0b256f9b18 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -252,8 +252,8 @@ int access_node(struct connection *conn, struct node *node, i = find_accessed_node(trans, node->name); if (!i) { - if (trans->nodes >= quota_trans_nodes && - domain_is_unprivileged(conn)) { + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, + quota_trans_nodes)) { ret = ENOSPC; goto err; } diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index e30cd89be3..61b1e3421e 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -176,7 +176,7 @@ static int check_watch_path(struct connection *conn, const void *ctx, *path = canonicalize(conn, ctx, *path); if (!*path) return errno; - if (!is_valid_nodename(*path)) + if (!is_valid_nodename(conn, *path)) goto inval; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:09:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518263.804648 (Exim 4.92) (envelope-from ) id 1pjxGP-0008Co-8m; Wed, 05 Apr 2023 07:09:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518263.804648; Wed, 05 Apr 2023 07:09:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxGP-0008Cf-2H; Wed, 05 Apr 2023 07:09:01 +0000 Received: by outflank-mailman (input) for mailman id 518263; Wed, 05 Apr 2023 07:08:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxCE-0002UC-Sd for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2367f272-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1AC7020298; Wed, 5 Apr 2023 07:04:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DFDB813A31; Wed, 5 Apr 2023 07:04:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dLRaNYkdLWTnEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2367f272-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GIdwVYCAKepkDxThtVUfw/37sAa1oGJdz4Nx6ZA+2lg=; b=JYSdSrraO6+/ewSBe4ComCaeaEt6LaIqm7GpPwvvBB2/50c3lKRhEfexZ/M1PYtUNuOAdp cAXPwMDtyPaVr6zj4HebZEt9t+7eJ9G9ICvXqsD4QgpVereucdcAxnztUHXU0/E9EcKMvt WCuHsq6yasY6PYD4cdSaJ4rMhd+r4JQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v4 09/13] tools/xenstore: add TDB access trace support Date: Wed, 5 Apr 2023 09:03:45 +0200 Message-Id: <20230405070349.25293-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new trace switch "tdb" and the related trace calls. The "tdb" switch is off per default. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_core.c | 8 +++++++- tools/xenstore/xenstored_core.h | 7 +++++++ tools/xenstore/xenstored_transaction.c | 7 ++++++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index bd816ce709..2d481fcad9 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -589,6 +589,8 @@ static void get_acc_data(TDB_DATA *key, struct node_account_data *acc) if (old_data.dptr == NULL) { acc->memory = 0; } else { + trace_tdb("read %s size %zu\n", key->dptr, + old_data.dsize + key->dsize); hdr = (void *)old_data.dptr; acc->memory = old_data.dsize; acc->domid = hdr->perms[0].id; @@ -655,6 +657,7 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, errno = EIO; return errno; } + trace_tdb("store %s size %zu\n", key->dptr, data->dsize + key->dsize); if (acc) { /* Don't use new_domid, as it might be a transaction node. */ @@ -682,6 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, errno = EIO; return errno; } + trace_tdb("delete %s\n", key->dptr); if (acc->memory) { domid = get_acc_domid(conn, key, acc->domid); @@ -731,6 +735,8 @@ struct node *read_node(struct connection *conn, const void *ctx, goto error; } + trace_tdb("read %s size %zu\n", key.dptr, data.dsize + key.dsize); + node->parent = NULL; talloc_steal(node, data.dptr); @@ -2746,7 +2752,7 @@ static void set_quota(const char *arg, bool soft) /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ const char *const trace_switches[] = { - "obj", "io", "wrl", "acc", + "obj", "io", "wrl", "acc", "tdb", NULL }; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 3e0734a6c6..5a11dc1231 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -303,9 +303,16 @@ extern unsigned int trace_flags; #define TRACE_IO 0x00000002 #define TRACE_WRL 0x00000004 #define TRACE_ACC 0x00000008 +#define TRACE_TDB 0x00000010 extern const char *const trace_switches[]; int set_trace_switch(const char *arg); +#define trace_tdb(...) \ +do { \ + if (trace_flags & TRACE_TDB) \ + trace("tdb: " __VA_ARGS__); \ +} while (0) + extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; extern int dom0_event; diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 2b15506953..11c8bcec84 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -374,8 +374,11 @@ static int finalize_transaction(struct connection *conn, if (tdb_error(tdb_ctx) != TDB_ERR_NOEXIST) return EIO; gen = NO_GENERATION; - } else + } else { + trace_tdb("read %s size %zu\n", key.dptr, + key.dsize + data.dsize); gen = hdr->generation; + } talloc_free(data.dptr); if (i->generation != gen) return EAGAIN; @@ -399,6 +402,8 @@ static int finalize_transaction(struct connection *conn, set_tdb_key(i->trans_name, &ta_key); data = tdb_fetch(tdb_ctx, ta_key); if (data.dptr) { + trace_tdb("read %s size %zu\n", ta_key.dptr, + ta_key.dsize + data.dsize); hdr = (void *)data.dptr; hdr->generation = ++generation; *is_corrupt |= do_tdb_write(conn, &key, &data, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:09:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518268.804653 (Exim 4.92) (envelope-from ) id 1pjxGP-0008EO-Ic; Wed, 05 Apr 2023 07:09:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518268.804653; Wed, 05 Apr 2023 07:09:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxGP-0008Dn-BL; Wed, 05 Apr 2023 07:09:01 +0000 Received: by outflank-mailman (input) for mailman id 518268; Wed, 05 Apr 2023 07:09:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxCd-0002Et-6Z for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:05:07 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30dd4850-d380-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:05:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9FAA1201AE; Wed, 5 Apr 2023 07:05:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6FFED13A31; Wed, 5 Apr 2023 07:05:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sUUcGqAdLWQYFAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:05:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30dd4850-d380-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678304; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WlsEUwLyrbuDwUKcPe0rdVJuR+fsh5G5MKrTkqmSsAU=; b=nuCyErAeaJms2nibOGMxAA1WYVt61sEpsQAOH+dBoxFDz3+jeklDHw4Wp+bbUxdmDyiZmk H4Qi8RYtT+TRz6nGLb0OcbywNqGLor5XSv80LKOmzU/0XzzhiNw6JI52TaFas4p+uqF8EU bpKKxSVcybscwIDkiW4DzfawgVwEszo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 13/13] tools/xenstore: switch quota management to be table based Date: Wed, 5 Apr 2023 09:03:49 +0200 Message-Id: <20230405070349.25293-14-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having individual quota variables switch to a table based approach like the generic accounting. Include all the related data in the same table and add accessor functions. This enables to use the command line --quota parameter for setting all possible quota values, keeping the previous parameters for compatibility. Signed-off-by: Juergen Gross --- V2: - new patch One further remark: it would be rather easy to add soft-quota for all the other quotas (similar to the memory one). This could be used as an early warning for the need to raise global quota. --- tools/xenstore/xenstored_control.c | 43 ++------ tools/xenstore/xenstored_core.c | 85 ++++++++-------- tools/xenstore/xenstored_core.h | 10 -- tools/xenstore/xenstored_domain.c | 132 +++++++++++++++++-------- tools/xenstore/xenstored_domain.h | 12 ++- tools/xenstore/xenstored_transaction.c | 5 +- tools/xenstore/xenstored_watch.c | 2 +- 7 files changed, 155 insertions(+), 134 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index a2ba64a15c..75f51a80db 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -221,35 +221,6 @@ static int do_control_log(const void *ctx, struct connection *conn, return 0; } -struct quota { - const char *name; - int *quota; - const char *descr; -}; - -static const struct quota hard_quotas[] = { - { "nodes", "a_nb_entry_per_domain, "Nodes per domain" }, - { "watches", "a_nb_watch_per_domain, "Watches per domain" }, - { "transactions", "a_max_transaction, "Transactions per domain" }, - { "outstanding", "a_req_outstanding, - "Outstanding requests per domain" }, - { "transaction-nodes", "a_trans_nodes, - "Max. number of accessed nodes per transaction" }, - { "memory", "a_memory_per_domain_hard, - "Total Xenstore memory per domain (error level)" }, - { "node-size", "a_max_entry_size, "Max. size of a node" }, - { "path-max", "a_max_path_len, "Max. length of a node path" }, - { "permissions", "a_nb_perms_per_node, - "Max. number of permissions per node" }, - { NULL, NULL, NULL } -}; - -static const struct quota soft_quotas[] = { - { "memory", "a_memory_per_domain_soft, - "Total Xenstore memory per domain (warning level)" }, - { NULL, NULL, NULL } -}; - static int quota_show_current(const void *ctx, struct connection *conn, const struct quota *quotas) { @@ -260,9 +231,11 @@ static int quota_show_current(const void *ctx, struct connection *conn, if (!resp) return ENOMEM; - for (i = 0; quotas[i].quota; i++) { + for (i = 0; i < ACC_N; i++) { + if (!quotas[i].name) + continue; resp = talloc_asprintf_append(resp, "%-17s: %8d %s\n", - quotas[i].name, *quotas[i].quota, + quotas[i].name, quotas[i].val, quotas[i].descr); if (!resp) return ENOMEM; @@ -274,7 +247,7 @@ static int quota_show_current(const void *ctx, struct connection *conn, } static int quota_set(const void *ctx, struct connection *conn, - char **vec, int num, const struct quota *quotas) + char **vec, int num, struct quota *quotas) { unsigned int i; int val; @@ -286,9 +259,9 @@ static int quota_set(const void *ctx, struct connection *conn, if (val < 1) return EINVAL; - for (i = 0; quotas[i].quota; i++) { - if (!strcmp(vec[0], quotas[i].name)) { - *quotas[i].quota = val; + for (i = 0; i < ACC_N; i++) { + if (quotas[i].name && !strcmp(vec[0], quotas[i].name)) { + quotas[i].val = val; send_ack(conn, XS_CONTROL); return 0; } diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 65df2866bf..6e2fc06840 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -89,17 +89,6 @@ unsigned int trace_flags = TRACE_OBJ | TRACE_IO; static const char *sockmsg_string(enum xsd_sockmsg_type type); -int quota_nb_entry_per_domain = 1000; -int quota_nb_watch_per_domain = 128; -int quota_max_entry_size = 2048; /* 2K */ -int quota_max_transaction = 10; -int quota_nb_perms_per_node = 5; -int quota_trans_nodes = 1024; -int quota_max_path_len = XENSTORE_REL_PATH_MAX; -int quota_req_outstanding = 20; -int quota_memory_per_domain_soft = 2 * 1024 * 1024; /* 2 MB */ -int quota_memory_per_domain_hard = 2 * 1024 * 1024 + 512 * 1024; /* 2.5 MB */ - unsigned int timeout_watch_event_msec = 20000; void trace(const char *fmt, ...) @@ -799,7 +788,7 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, + node->perms.num * sizeof(node->perms.p[0]) + node->datalen + node->childlen; - if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) + if (domain_max_chk(conn, ACC_NODESZ, data.dsize) && !no_quota_check) { errno = ENOSPC; return errno; @@ -1188,8 +1177,7 @@ bool is_valid_nodename(const struct connection *conn, const char *node) if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) local_off = 0; - if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, - quota_max_path_len)) + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off)) return false; return valid_chars(node); @@ -1501,7 +1489,7 @@ static struct node *create_node(struct connection *conn, const void *ctx, for (i = node; i; i = i->parent) { /* i->parent is set for each new node, so check quota. */ if (i->parent && - domain_nbentry(conn) >= quota_nb_entry_per_domain) { + domain_nbentry(conn) >= hard_quotas[ACC_NODES].val) { ret = ENOSPC; goto err; } @@ -1776,7 +1764,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EINVAL; perms.num--; - if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) + if (domain_max_chk(conn, ACC_NPERM, perms.num)) return ENOSPC; permstr = in->buffer + strlen(in->buffer) + 1; @@ -2644,7 +2632,16 @@ static void usage(void) " memory: total used memory per domain for nodes,\n" " transactions, watches and requests, above\n" " which Xenstore will stop talking to domain\n" +" nodes: number nodes owned by a domain\n" +" node-permissions: number of access permissions per\n" +" node\n" +" node-size: total size of a node (permissions +\n" +" children names + content)\n" " outstanding: number of outstanding requests\n" +" path-length: length of a node path\n" +" transactions: number of concurrent transactions\n" +" per domain\n" +" watches: number of watches per domain" " -q, --quota-soft = set a soft quota to the value ,\n" " causing a warning to be issued via syslog() if the\n" " limit is violated, allowed quotas are:\n" @@ -2695,12 +2692,12 @@ int dom0_domid = 0; int dom0_event = 0; int priv_domid = 0; -static int get_optval_int(const char *arg) +static unsigned int get_optval_int(const char *arg) { char *end; - long val; + unsigned long val; - val = strtol(arg, &end, 10); + val = strtoul(arg, &end, 10); if (!*arg || *end || val < 0 || val > INT_MAX) barf("invalid parameter value \"%s\"\n", arg); @@ -2709,15 +2706,19 @@ static int get_optval_int(const char *arg) static bool what_matches(const char *arg, const char *what) { - unsigned int what_len = strlen(what); + unsigned int what_len; + + if (!what) + false; + what_len = strlen(what); return !strncmp(arg, what, what_len) && arg[what_len] == '='; } static void set_timeout(const char *arg) { const char *eq = strchr(arg, '='); - int val; + unsigned int val; if (!eq) barf("quotas must be specified via =\n"); @@ -2731,22 +2732,22 @@ static void set_timeout(const char *arg) static void set_quota(const char *arg, bool soft) { const char *eq = strchr(arg, '='); - int val; + struct quota *q = soft ? soft_quotas : hard_quotas; + unsigned int val; + unsigned int i; if (!eq) barf("quotas must be specified via =\n"); val = get_optval_int(eq + 1); - if (what_matches(arg, "outstanding") && !soft) - quota_req_outstanding = val; - else if (what_matches(arg, "transaction-nodes") && !soft) - quota_trans_nodes = val; - else if (what_matches(arg, "memory")) { - if (soft) - quota_memory_per_domain_soft = val; - else - quota_memory_per_domain_hard = val; - } else - barf("unknown quota \"%s\"\n", arg); + + for (i = 0; i < ACC_N; i++) { + if (what_matches(arg, q[i].name)) { + q[i].val = val; + return; + } + } + + barf("unknown quota \"%s\"\n", arg); } /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ @@ -2808,7 +2809,7 @@ int main(int argc, char *argv[]) no_domain_init = true; break; case 'E': - quota_nb_entry_per_domain = strtol(optarg, NULL, 10); + hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10); break; case 'F': pidfile = optarg; @@ -2826,10 +2827,10 @@ int main(int argc, char *argv[]) recovery = false; break; case 'S': - quota_max_entry_size = strtol(optarg, NULL, 10); + hard_quotas[ACC_NODESZ].val = strtoul(optarg, NULL, 10); break; case 't': - quota_max_transaction = strtol(optarg, NULL, 10); + hard_quotas[ACC_TRANS].val = strtoul(optarg, NULL, 10); break; case 'T': tracefile = optarg; @@ -2849,15 +2850,17 @@ int main(int argc, char *argv[]) verbose = true; break; case 'W': - quota_nb_watch_per_domain = strtol(optarg, NULL, 10); + hard_quotas[ACC_WATCH].val = strtoul(optarg, NULL, 10); break; case 'A': - quota_nb_perms_per_node = strtol(optarg, NULL, 10); + hard_quotas[ACC_NPERM].val = strtoul(optarg, NULL, 10); break; case 'M': - quota_max_path_len = strtol(optarg, NULL, 10); - quota_max_path_len = min(XENSTORE_REL_PATH_MAX, - quota_max_path_len); + hard_quotas[ACC_PATHLEN].val = + strtoul(optarg, NULL, 10); + hard_quotas[ACC_PATHLEN].val = + min((unsigned int)XENSTORE_REL_PATH_MAX, + hard_quotas[ACC_PATHLEN].val); break; case 'Q': set_quota(optarg, false); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 9339820156..92d5b50f3c 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -316,16 +316,6 @@ extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; extern int dom0_event; extern int priv_domid; -extern int quota_nb_watch_per_domain; -extern int quota_max_transaction; -extern int quota_max_entry_size; -extern int quota_nb_perms_per_node; -extern int quota_max_path_len; -extern int quota_nb_entry_per_domain; -extern int quota_req_outstanding; -extern int quota_trans_nodes; -extern int quota_memory_per_domain_soft; -extern int quota_memory_per_domain_hard; extern bool keep_orphans; extern unsigned int timeout_watch_event_msec; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 49e2c5c82a..9f6b17cca3 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,7 +43,61 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; -static unsigned int acc_global_max[ACC_N]; +struct quota hard_quotas[ACC_N] = { + [ACC_NODES] = { + .name = "nodes", + .descr = "Nodes per domain", + .val = 1000, + }, + [ACC_WATCH] = { + .name = "watches", + .descr = "Watches per domain", + .val = 128, + }, + [ACC_OUTST] = { + .name = "outstanding", + .descr = "Outstanding requests per domain", + .val = 20, + }, + [ACC_MEM] = { + .name = "memory", + .descr = "Total Xenstore memory per domain (error level)", + .val = 2 * 1024 * 1024 + 512 * 1024, /* 2.5 MB */ + }, + [ACC_TRANS] = { + .name = "transactions", + .descr = "Active transactions per domain", + .val = 10, + }, + [ACC_TRANSNODES] = { + .name = "transaction-nodes", + .descr = "Max. number of accessed nodes per transaction", + .val = 1024, + }, + [ACC_NPERM] = { + .name = "node-permissions", + .descr = "Max. number of permissions per node", + .val = 5, + }, + [ACC_PATHLEN] = { + .name = "path-max", + .descr = "Max. length of a node path", + .val = XENSTORE_REL_PATH_MAX, + }, + [ACC_NODESZ] = { + .name = "node-size", + .descr = "Max. size of a node", + .val = 2048, + }, +}; + +struct quota soft_quotas[ACC_N] = { + [ACC_MEM] = { + .name = "memory", + .descr = "Total Xenstore memory per domain (warning level)", + .val = 2 * 1024 * 1024, /* 2.0 MB */ + }, +}; struct domain { @@ -206,10 +260,10 @@ static bool domain_can_read(struct connection *conn) if (domain_is_unprivileged(conn)) { if (domain->wrl_credit < 0) return false; - if (domain->acc[ACC_OUTST].val >= quota_req_outstanding) + if (domain->acc[ACC_OUTST].val >= hard_quotas[ACC_OUTST].val) return false; - if (domain->acc[ACC_MEM].val >= quota_memory_per_domain_hard && - quota_memory_per_domain_hard) + if (domain->acc[ACC_MEM].val >= hard_quotas[ACC_MEM].val && + hard_quotas[ACC_MEM].val) return false; } @@ -424,6 +478,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, { struct domain *d = find_domain_struct(domid); char *resp; + unsigned int i; if (!d) return ENOENT; @@ -432,19 +487,15 @@ int domain_get_quota(const void *ctx, struct connection *conn, if (!resp) return ENOMEM; -#define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ - d->acc[e].val, d->acc[e].max); \ - if (!resp) return ENOMEM - - ent(nodes, ACC_NODES); - ent(watches, ACC_WATCH); - ent(transactions, ACC_TRANS); - ent(outstanding, ACC_OUTST); - ent(memory, ACC_MEM); - ent(transaction-nodes, ACC_TRANSNODES); - -#undef ent + for (i = 0; i < ACC_N; i++) { + if (!hard_quotas[i].name) + continue; + resp = talloc_asprintf_append(resp, "%-17s: %8u (max %8u)\n", + hard_quotas[i].name, + d->acc[i].val, d->acc[i].max); + if (!resp) + return ENOMEM; + } send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); @@ -454,24 +505,21 @@ int domain_get_quota(const void *ctx, struct connection *conn, int domain_max_global_acc(const void *ctx, struct connection *conn) { char *resp; + unsigned int i; resp = talloc_asprintf(ctx, "Max. seen accounting values:\n"); if (!resp) return ENOMEM; -#define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ - acc_global_max[e]); \ - if (!resp) return ENOMEM - - ent(nodes, ACC_NODES); - ent(watches, ACC_WATCH); - ent(transactions, ACC_TRANS); - ent(outstanding, ACC_OUTST); - ent(memory, ACC_MEM); - ent(transaction-nodes, ACC_TRANSNODES); - -#undef ent + for (i = 0; i < ACC_N; i++) { + if (!hard_quotas[i].name) + continue; + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", + hard_quotas[i].name, + hard_quotas[i].max); + if (!resp) + return ENOMEM; + } send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); @@ -586,7 +634,7 @@ int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) list_for_each_entry(cd, head, list) { cnt = domain_nbentry_fix(cd->domid, cd->acc[ACC_NODES], update); if (!update) { - if (chk_quota && cnt >= quota_nb_entry_per_domain) + if (chk_quota && cnt >= hard_quotas[ACC_NODES].val) return ENOSPC; if (cnt < 0) return ENOMEM; @@ -1087,12 +1135,12 @@ static void domain_acc_valid_max(struct domain *d, enum accitem what, unsigned int val) { assert(what < ARRAY_SIZE(d->acc)); - assert(what < ARRAY_SIZE(acc_global_max)); + assert(what < ARRAY_SIZE(hard_quotas)); if (val > d->acc[what].max) d->acc[what].max = val; - if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) - acc_global_max[what] = val; + if (val > hard_quotas[what].max && domid_is_unprivileged(d->domid)) + hard_quotas[what].max = val; } static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) @@ -1224,19 +1272,19 @@ void domain_reset_global_acc(void) unsigned int i; for (i = 0; i < ACC_N; i++) - acc_global_max[i] = 0; + hard_quotas[i].max = 0; /* Set current max values seen. */ hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); } bool domain_max_chk(const struct connection *conn, enum accitem what, - unsigned int val, unsigned int quota) + unsigned int val) { if (!conn || !conn->domain) return false; - if (domain_is_unprivileged(conn) && val > quota) + if (domain_is_unprivileged(conn) && val > hard_quotas[what].val) return true; domain_acc_valid_max(conn->domain, what, val); @@ -1285,8 +1333,7 @@ static bool domain_chk_quota(struct connection *conn, unsigned int mem) domain = conn->domain; now = time(NULL); - if (mem >= quota_memory_per_domain_hard && - quota_memory_per_domain_hard) { + if (mem >= hard_quotas[ACC_MEM].val && hard_quotas[ACC_MEM].val) { if (domain->hard_quota_reported) return true; syslog(LOG_ERR, "Domain %u exceeds hard memory quota, Xenstore interface to domain stalled\n", @@ -1303,15 +1350,14 @@ static bool domain_chk_quota(struct connection *conn, unsigned int mem) syslog(LOG_INFO, "Domain %u below hard memory quota again\n", domain->domid); } - if (mem >= quota_memory_per_domain_soft && - quota_memory_per_domain_soft && - !domain->soft_quota_reported) { + if (mem >= soft_quotas[ACC_MEM].val && + soft_quotas[ACC_MEM].val && !domain->soft_quota_reported) { domain->mem_last_msg = now; domain->soft_quota_reported = true; syslog(LOG_WARNING, "Domain %u exceeds soft memory quota\n", domain->domid); } - if (mem < quota_memory_per_domain_soft && + if (mem < soft_quotas[ACC_MEM].val && domain->soft_quota_reported) { domain->mem_last_msg = now; domain->soft_quota_reported = false; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 3e17b63659..b9e38abff5 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -39,6 +39,16 @@ enum accitem { ACC_N, /* Number of elements per domain. */ }; +struct quota { + const char *name; + const char *descr; + unsigned int val; + unsigned int max; +}; + +extern struct quota hard_quotas[ACC_N]; +extern struct quota soft_quotas[ACC_N]; + void handle_event(void); void check_domains(void); @@ -133,7 +143,7 @@ void acc_commit(struct connection *conn); int domain_max_global_acc(const void *ctx, struct connection *conn); void domain_reset_global_acc(void); bool domain_max_chk(const struct connection *conn, unsigned int what, - unsigned int val, unsigned int quota); + unsigned int val); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 0b256f9b18..e8968d7a1d 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -252,8 +252,7 @@ int access_node(struct connection *conn, struct node *node, i = find_accessed_node(trans, node->name); if (!i) { - if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, - quota_trans_nodes)) { + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1)) { ret = ENOSPC; goto err; } @@ -479,7 +478,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (conn->transaction) return EBUSY; - if (domain_transaction_get(conn) > quota_max_transaction) + if (domain_transaction_get(conn) > hard_quotas[ACC_TRANS].val) return ENOSPC; /* Attach transaction to ctx for autofree until it's complete */ diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 61b1e3421e..e8eb35de02 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -239,7 +239,7 @@ int do_watch(const void *ctx, struct connection *conn, struct buffered_data *in) return EEXIST; } - if (domain_watch(conn) > quota_nb_watch_per_domain) + if (domain_watch(conn) > hard_quotas[ACC_WATCH].val) return E2BIG; watch = add_watch(conn, vec[0], vec[1], relative, false); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 07:52:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 07:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518289.804668 (Exim 4.92) (envelope-from ) id 1pjxw1-0006mQ-M0; Wed, 05 Apr 2023 07:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518289.804668; Wed, 05 Apr 2023 07:52:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxw1-0006mJ-J6; Wed, 05 Apr 2023 07:52:01 +0000 Received: by outflank-mailman (input) for mailman id 518289; Wed, 05 Apr 2023 07:52:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxw0-0006mB-9h for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:52:00 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0623.outbound.protection.outlook.com [2a01:111:f400:fe1e::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd524ea5-d386-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 09:51:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9940.eurprd04.prod.outlook.com (2603:10a6:10:4c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 07:51:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 07:51:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd524ea5-d386-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gS2k3VFRwdUd2gf441Igmw/8E+ASuzlKPyItbkr+TJlI1jGNKyDZMxEff6JJM6sB8XqAkJnDeWcWaCgEIhY39ZSZXNrQ7VIv6BmZz5dqvjIqpmue986YH7JpZIal7qCmSubv0AN/6txgXYovuqCwUJcLziBVHFZ483Ykyhd8A7kQCH1bKkI1pYCNUEsN/rjc9rXD4ZZTg0f5eWsgRhI+u6I0Y8tbjGMCS6SSkm8GPFfxPfsw8tJ2RHIbrrKbycgMeq4MQd9W5hsbsWxotabbntqVO6olMI8I00xMHUFCSzEccElRIwzLwZJScu2yJ+qPo9je/Tc4RFLNY9re6HrQ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0x0+0wJ8Q4w/H40y6THXQJcjdg6Sf3VzaqPj3AYPlHU=; b=Qp7eM7wHo+9fF0GNesJqiFirLpsjArm97y8NYt9nzab5V0QS1oIyMRFwLz3QdkCEWSEGD63jL4IyHefgEJenNn95d7WeCoEUjNQm39NxIgPdGichGazBhfvHL0MT+PRmc5/CTbZk7c6bItcera0HVpPZwBa2YEzMyINrYcSkWOGv8/RKOFOeZ+UvaLEr8HvNdeQQcUdgckRz9g/m8u4jlg6apYaNsSRNcIFtAFF79WVeNxPaw8lx3s4RElP4ngKmQ2mh+S8rwkNG8dPB7KxNXVTlMtusa0jdcfEUaVh4MOyR5dAR8EIwW36ZnVXxlz0a4uTz8HYCHzO4rtY9ekmgBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0x0+0wJ8Q4w/H40y6THXQJcjdg6Sf3VzaqPj3AYPlHU=; b=sZVXquaSgZ4fiEqIa9EvfqM3WADdNiCNYjprrgujvV4Gt2xWZ5QVGiphbz6zzIluzNDw9afpzfuJCGQZ22xegW0vQsRBuOpARrtxr/2Yc/3S/X3irhbY/J4J1e9ULgf9TPVUB0E6DLjLueYtgkZSJutMEH3hH+itdKIxDMKYIcs4zHPEDyTTj6UkFiZO53bWKMiXy0XbRhU9TYfvWe0E1Q7Qz/S18X6ktv3kFKoV9tqk/qQc8uGhu7Te5AvVfZ1j0hIS3K1CpXo2wQDBahFN9dfJXG7C2xRMumUScOS4Fs5EFWE6511R+vsic8tJQ6Y1v2a+LWdoTLOzBjv1fFDDfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <400b70cd-d2a9-60ce-0acc-a429f3f5a958@suse.com> Date: Wed, 5 Apr 2023 09:51:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/9] x86emul: support LKGS Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <1eb21ece-9d33-d8e1-1c2b-c682dbb1cda1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9940:EE_ X-MS-Office365-Filtering-Correlation-Id: fc273405-6910-4852-3995-08db35aa9f23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SIqlHaJ7CCYZnxiN14QlocvY7yqtXYEURDaMX5MnXnup6NTmoZbjtHAukxX12gyi7lpGFWLVV/bGDtRLDj65PotAfLJovJ9w6CSNrl+y6rWs0PPjXdAjVUgLH0hsB6JnsSyzYXeOALYJ/f11ks8QmSni8Js5hmRiux84xO7srlxPU0mClyvfp8G4Juug87I1MtYWk+75HAyFzLbyZz/1D33VBnWqHtW6NAFcvdl6B2ET9XaL+tWuYxWwyTrDzZw/T/UYVCIPwFcrflaREi3jw/0iB49s7gT1gFujqJaGTGiVO27uYkqevhI3/jx1UgGBLJnCGIoeO6H/exVOCB/Ek+M+PpsgGOzCMxZXConIvejOrh3p+kHx+mccohEsOVvNNimfyUXgnBnuYOW2xWBBdW5qYXfRVbnumCoaGE3o5jPRa8kyVAj3fanjTOfjuVmiZmFbEpuLhGfyJaV+QTt3ymvtnB8VQvBktgMJk94oATCGuyezLSeZ6jviM4IFB+WKZmXlpA3GbEEoNBkDKriJuDPRzNqwR6aAubxvByhk8xrRlruaF8yYTGnbfTNtNtj244nUvHjRWFAnNq48WCqBSibyWgeoMIEEYbj7LGqn8e6pavOM1cl/rFtWdBdngxMUEvLZgHRDgo6rI0Qq7Cw/vg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199021)(6486002)(5660300002)(478600001)(36756003)(38100700002)(31696002)(66556008)(66476007)(4326008)(6916009)(8676002)(66946007)(86362001)(41300700001)(316002)(54906003)(8936002)(2616005)(186003)(31686004)(26005)(6512007)(6506007)(2906002)(53546011)(66899021)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0tsNis3MGlubE1GcDZDdCtXK05adHN3MjlhcWFhTmR0ZWVMQnNrS0hqQ0Jw?= =?utf-8?B?bUFmeE5ZWUxIRGJHRzY5VmRBelpvS0lNMWdYTjFqUW1zdVgxWkNIVzV5OVRa?= =?utf-8?B?d3RWYjhVcFRiN0RWc2hLcU5Ham1QS3ZtTFYrZ25YenlJMmM2TXFBSXl6QU0z?= =?utf-8?B?eTR1azNxZThwVlBzSEpZU1FudTZsSzJybjh4TXBSSkIrc2xIUWZRR1JLTXBu?= =?utf-8?B?bEprRjVGNUJxM0FTY2pYZzFYM3VNRXMvREVOTzBKZG0vamROYldJNGw5N3Vz?= =?utf-8?B?bi8vd0JoWVV0c1BZUVpuanVjRkRJR0N2STBtN25UcTNJcGpJQ0lWVDZPRGlv?= =?utf-8?B?ZEp3a0JhMFVveVdsbDhQRld2cElCL29YdTcyRjNyRWxYNEtjS3ExajVWSVFs?= =?utf-8?B?UnE1djJNVWc5dlJWeU1ibXVsTTM1K05VMVRiYzR6RlAycVhPeERtOW9DSXJO?= =?utf-8?B?SnVESnNWa1VUWGNCK2UyaU5OWS9pMUFhK3JVdXNNa3M3dmVtMk5JZUNWQzhm?= =?utf-8?B?Q0pJdEpHS2ZNNERzZTYrQkxjUXJyV1g2TUVQYlF3cG52U01hQWg0eHhjVDAr?= =?utf-8?B?UFV3Rmp6TnhSMFJsQ25GaVJqRlpYcldUcEFIWVBTVG9tSnI5MytsejBCOUlD?= =?utf-8?B?V1R6OWc5NEVXeVVsN1VqcXBob21DYzU4WEpKbkpGaDc1cHkvRnY3T0FvNHo3?= =?utf-8?B?dFpNQm1rTXRxZFdwOGtyOWJWdml0QW5nYnFhSENSMXhHMlc3RHBKcUUxLytl?= =?utf-8?B?NS9OcEE1KzU5Y2pnREd3RHNwYnFvaUNlejJYNXA4LzdNWWpZUm4wbytnQUl3?= =?utf-8?B?QjhkcEltRDZyZEZ5VkVaNWR1NnRpSEdlMWJEOXpIQkcrc2NMQmlxbFBWUGNp?= =?utf-8?B?a1FUN3VHVTQ0aVpYSVE2T25zMWIzVFBLdnZaRjNTVEppY3hOTG5ESC9uZVJm?= =?utf-8?B?VmZVRWgwY2NHRU1Bem9ldm9qcTJjN1dqcSsyL0tjbGZvNDhaQkttNWdXUFd2?= =?utf-8?B?NElUaXNXbXJROUJkcEJvak5GNFVQcjlaWnBOOHg2cnp3SUNibFhjY3o1UUtV?= =?utf-8?B?Y3hIa25JVTFuMWI0bk9EUjFWckpoZVJzd2pEeHdmcXYvMkZRUWdrQzBrUkdk?= =?utf-8?B?Y01rNWlia2xPVzh1cThQbHQyS0Y3RDdXbEIxa3pPRitkT0FObExLL2tuUU9K?= =?utf-8?B?RUdqTk53R3lzVk1OL2FJT0k5dTQ5RDdmeWdNYldrYXcrcFVaQTNCOUptNVBn?= =?utf-8?B?V1ZTaWNHd2FwTkFyWEJWQ3Z5YlNsN0xoL25yc0xlczF6WDJqSE0rcndDcUZk?= =?utf-8?B?VUozNDIyUHlXUDZaODZmR1Azc1BtREIyRm96SHhPa3l1czdpRHgyRWJVam9w?= =?utf-8?B?UTBFVXN5bTVXUUp5ellQaTczNEFVVTNqNVVmanVtN2owd2RmbUhZTzNEcDVY?= =?utf-8?B?QlhMVGdBSm1UZEN2RTlVa05wWERJMXFtbll4Wllvdy9HNmhuR0hHSXI3VzYw?= =?utf-8?B?Rmk5SndLNk5OQWZUZG1hYlhCemhiZXd0ZnVLM2p5UmxnVXdCOFZQdTYwRjg2?= =?utf-8?B?cXVVclI4Wk16cHd5c1FDM1JnVXZENEw2WExXSlhiL1p2SHV2aFZVb0FyVkUy?= =?utf-8?B?OTBLSjlSYmpBeFRUdVVTOUhrMlN3ZzlwUFdHS2JNM0EzT0pYV29FWlIzamZX?= =?utf-8?B?WXR2dURIenpDNXFwWkE0Qkh2SHE2eStrQlRodW5hVnRmWHd5bmN3SHAyaGhN?= =?utf-8?B?MVBSMFJQVUdDbzI1bTE3Q09sZ1I0bmxKcW5PaThSd0IwVlFVVTVCWmxnUzhZ?= =?utf-8?B?T0JzNWZSdWE4VkdKblVUSkxrSjdPeE1ERCtieFNDOTNNWDN3M29QWjdPZnln?= =?utf-8?B?MTgzdDdzQ3hoWWVjZ0RkRVZjTmwrNUF3N3J0Tk0rVDNub3crb3lrdTJCUGtP?= =?utf-8?B?NHprNjY5SlpaZllqaU1mS1RtNjNkNTFpZVRsRmZYUlgwZWpZQXRuSHNoRHB2?= =?utf-8?B?RnlrZVRKbnlqSlQrcXd5Mk05WEFrdTZhZ1M0ZkxQa0JKWVRnYTExdzA1UGpP?= =?utf-8?B?T0ZBVzFUTER1SlFodm9TOFg1aGt6d09rMlU0MFJTOGtzamVEbXB0RGFyR1Fm?= =?utf-8?Q?pjxhO3jw48EUhwNDAVEX0BGpy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc273405-6910-4852-3995-08db35aa9f23 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 07:51:53.5830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L+3YYYCOWQuonUCVN25+m4p0YeBxlD/vtv9Nf6wleOUKspmXxu3S+0mymrqAIIxuJQAWCxwX16NvvCaJzLx5AQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9940 On 04.04.2023 23:54, Andrew Cooper wrote: > On 04/04/2023 3:49 pm, Jan Beulich wrote: >> Provide support for this insn, which is a prereq to FRED. CPUID-wise >> introduce both its and FRED's bit at this occasion, thus allowing to >> also express the dependency right away. >> >> While adding a testcase, also add a SWAPGS one. In order to not affect >> the behavior of pre-existing tests, install write_{segment,msr} hooks >> only transiently. > > IMO, the emulator is already complicated enough without us having > fallback logic to cope with callers that don't set up all the hooks. > > Nor do I think making these hooks transient in the test harness is a > clever idea. Are you suggesting we start to _require_ all hooks to be set? That'll mean many useless stubs in particular in PV emulation. Furthermore absent hooks sometimes cause default behavior to apply rather than outright failure, so altering what hooks are present can affect overall behavior. Hence the transient establishing of the two hooks here. >> Signed-off-by: Jan Beulich >> --- >> Instead of ->read_segment() we could of course also use ->read_msr() to >> fetch the original GS base. I don't think I can see a clear advantage of >> either approach; the way it's done it matches how we handle SWAPGS. > > read_segment() is a much shorter logic chain under the hood, so will be > marginally faster, but it will be a couple of unnecessary VMREADs (on > Intel at least). And this is precisely why I think it's not entirely clear. Anyway, the remark is here just in case you (or Roger) thought doing it the other way might be better. > We could expose the get/set reg paths for cases where we know we're not > going to need sanity checks, but I'm not sure it's worth it in this case. Probably not. >> --- a/xen/arch/x86/x86_emulate/x86_emulate.c >> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c >> @@ -2886,8 +2886,31 @@ x86_emulate( >> break; >> } >> break; >> - default: >> - generate_exception_if(true, EXC_UD); >> + case 6: /* lkgs */ >> + generate_exception_if((modrm_reg & 1) || vex.pfx != vex_f2, EXC_UD); >> + generate_exception_if(!mode_64bit() || !mode_ring0(), EXC_UD); > > Can we switch to X86_* please.  Alternatively, I've got such a patch > which I've just rebased over all your emulator changes anyway, if we're > happy to fix this in one fell swoop. Of course, and I've applied this transformation to all the emulator patches I have pending (i.e. no need to re-request this elsewhere). > (Sadly, you did move some TRAP_* names into util-xen.c which I fixed up > in my other tree-wide exception constant patch.) Hmm, yes, I changed EXC_* -> X86_EXC_* but failed to pay attention to TRAP_* (because there no build issue arose). >> + vcpu_must_have(lkgs); >> + fail_if(!ops->read_segment || !ops->read_msr || >> + !ops->write_segment || !ops->write_msr); >> + if ( (rc = ops->read_msr(MSR_SHADOW_GS_BASE, &msr_val, >> + ctxt)) != X86EMUL_OKAY || >> + (rc = ops->read_segment(x86_seg_gs, &sreg, >> + ctxt)) != X86EMUL_OKAY ) >> + goto done; >> + dst.orig_val = sreg.base; >> + if ( (rc = protmode_load_seg(x86_seg_gs, src.val, false, &sreg, >> + ctxt, ops)) != X86EMUL_OKAY || >> + (rc = ops->write_msr(MSR_SHADOW_GS_BASE, sreg.base, >> + ctxt)) != X86EMUL_OKAY ) >> + goto done; >> + sreg.base = dst.orig_val; > > Honestly, I think a comment is needed here, because I'm struggling to > work out if this is correct or not. > > There is a 64->32 bit truncation of base with LGKS, just as there is > with MOV GS. > > Which I think does happen as a side effect of protmode_load_seg() only > filling in the lower half of sreg.base, I thought that's obvious, as protmode_load_seg() can't possibly have any other behavior. But ... > but I think it would be nicer to > have: > > +            dst.orig_val = sreg.base; /* Preserve full GS Base */ > +            if ( (rc = protmode_load_seg(x86_seg_gs, src.val, false, &sreg, > +                                         ctxt, ops)) != X86EMUL_OKAY || > +                 /* Write truncated base into GS_SHADOW */ > +                 (rc = ops->write_msr(MSR_SHADOW_GS_BASE, sreg.base, > +                                      ctxt)) != X86EMUL_OKAY ) > +                goto done; > +            sreg.base = dst.orig_val; /* Reinstate full GS Base */ > > Or so, because it's weird not to see a (uint32_t) somewhere in this logic. ... sure, I've added comments. I don't think "truncated" is correct, as there's no truncation - there's no more than 32 bits we can read out of the GDT/LDT. I've used "32-bit" instead. >> + if ( (rc = ops->write_segment(x86_seg_gs, &sreg, >> + ctxt)) != X86EMUL_OKAY ) >> + { >> + /* Best effort unwind (i.e. no error checking). */ >> + ops->write_msr(MSR_SHADOW_GS_BASE, msr_val, ctxt); > > write_segment() can't fail.  (The sanity checks are actually deferred > until after emulation is complete, and I'm not sure if that's behaviour > we want...) Irrespective we shouldn't start omitting error checks. If we truly mean write_segment() to always be successful, we should make it return "void". Yet I wouldn't view such as a good move. > However, more importantly, if we actually take this error path (for some > future reason) then we've created a security vulnerability in the guest. You mean in case additionally the write_msr() also fails? In any event, ... > It will be strictly better to crash the domain in this case, than to try > and let it continue in this state. ... we don't return OKAY in this case, so in most cases the guest will already be crashed, won't it? Otherwise it's not really clear to me what action you propose to take to "crash the domain": Right here we better wouldn't call domain_crash() (or else we'd need yet another #ifdef __XEN__ around it). Furthermore - what does what you say here mean for the (existing) similar code path in SWAPGS handling? >> --- a/xen/tools/gen-cpuid.py >> +++ b/xen/tools/gen-cpuid.py >> @@ -295,6 +295,9 @@ def crunch_numbers(state): >> >> # In principle the TSXLDTRK insns could also be considered independent. >> RTM: [TSXLDTRK], >> + >> + # FRED builds on the LKGS instruction. >> + LKGS: [FRED], > > Hmm...  This is the first case (I think) we've got where a dependency > that goes back numerically in terms of feature number. > > Obviously we need to support it, but I'm not sure if the deep_deps loop > will cope in its current form. As you know my Python isn't overly good, but looking at the loop makes me think it deals with this fine; I can't see an ordering dependency. Looking at the generated INIT_DEEP_DEPS appears to confirm this - there is an entry for LKGS, and while I haven't counted elements, the set bit there looks to be in a plausible position. The only thing I'm not entirely certain about is whether a further (hypothetical) transitive dependency would also be dealt with correctly. If there was an issue here, I'd really like to leave addressing it to you, as your Python is surely much better than mine. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:05:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518301.804678 (Exim 4.92) (envelope-from ) id 1pjy8w-0000sh-Cx; Wed, 05 Apr 2023 08:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518301.804678; Wed, 05 Apr 2023 08:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjy8w-0000sa-A9; Wed, 05 Apr 2023 08:05:22 +0000 Received: by outflank-mailman (input) for mailman id 518301; Wed, 05 Apr 2023 08:05:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjy8v-0000sP-Fq for xen-devel@lists.xen.org; Wed, 05 Apr 2023 08:05:21 +0000 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [2607:f8b0:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9986dc51-d388-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:05:17 +0200 (CEST) Received: by mail-pl1-x62c.google.com with SMTP id n14so17852232plc.8 for ; Wed, 05 Apr 2023 01:05:17 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id j1-20020aa78d01000000b0062e032b61a8sm6873761pfe.63.2023.04.05.01.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 01:05:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9986dc51-d388-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680681915; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gG5PZXaUKhRxajyfEHYthrg54Lo1xoJ4el5+xnkywpQ=; b=bXqXlLJ6We8DJ5x6EsboXOQFZKE3WQBpg4pzsW643gYyFnwHIpw8eOykr4dOTCFtM9 ECwx22xqOqDAJ0QOAfosmP3QeiPjyEvwnk10Q7cLZjJ6jsFjJCiRbvHO1TuZH8TD0iNP squLEepCF/T9uWNR2qwrlN7CAdHUc2X5DMmOC+tKyrQtoUafUJurBwHqvQF23gLPhsnN ks8bK3PeF2O7JpuZQ2C4EPZMJUfhFPu+cWnP22BTFdKwWM0mteoYEzFdXaPsnkzJldPD Ff160jxoHNRWKLdNRh8ABM+ocVKwrtsr8rIVSOHveAAWMHimyC7LRtXMPEwfcfvQ4dPa 0Fkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680681915; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gG5PZXaUKhRxajyfEHYthrg54Lo1xoJ4el5+xnkywpQ=; b=0sZfdAoAztFhwx4JhLqW6TIQ3NiJ1LBqthzR1zCzeYXbI36Jqesz6q1RK+wKqno2yA VpTqF2q1r+OowOmcywYBJLx9vdhixiU0ZAjBPoAjO0zAVahpD53S+AKyTAk48WwVsW7e LAruPGgnHOCzNIF06B20rCFdooBoDFN+sMHdgmkB0WUgC4jzJQ4rudbjZidkIcrBO/k1 xC1/9H9DO6aPzEz/bk6ixMbY6Gf4RYjpLTEtTkCCWrY8/ed8KPMZvFYZtB7hyo5MCE5N rC2m4gc+RiCRtgBF2Wl8AFxDhPmLmL0zV1hzicI+n0NoCzgAEHoenulqx+1nObgwfiWd 85Dw== X-Gm-Message-State: AAQBX9dmXR3tL6GimPanFuHJYPxcUHZXmtwe7c4keIBKZkl09Z+afPHx CCcVyKR2usR6kDZzHDfNG0YwxQ== X-Google-Smtp-Source: AKy350ZJ1bbwKNRCdYkOTrVTQ+pN4bqMvXPSEwXvqfgJHgfHdmB+v/yBFWMjTYFvTH5cPlfe9/Nq/w== X-Received: by 2002:a05:6a20:2d96:b0:dd:bf6a:4609 with SMTP id bf22-20020a056a202d9600b000ddbf6a4609mr3559565pzb.49.1680681915648; Wed, 05 Apr 2023 01:05:15 -0700 (PDT) Date: Wed, 5 Apr 2023 13:35:12 +0530 From: Viresh Kumar To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, Stefan Hajnoczi , "Michael S. Tsirkin" Cc: Vincent Guittot , Alex =?utf-8?Q?Benn=C3=A9e?= , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks Message-ID: <20230405080512.nvxiw4lv7hyuzqej@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 09-03-23, 14:20, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific > feature. Can we apply this now ? I have developed code for rust-vmm crates based on this and we need to get this merged/finalized first before merging those changes. Thanks. -- viresh From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:11:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:11:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518305.804688 (Exim 4.92) (envelope-from ) id 1pjyF2-0002X9-0h; Wed, 05 Apr 2023 08:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518305.804688; Wed, 05 Apr 2023 08:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyF1-0002X2-U6; Wed, 05 Apr 2023 08:11:39 +0000 Received: by outflank-mailman (input) for mailman id 518305; Wed, 05 Apr 2023 08:11:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyF1-0002Wv-3Y for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:11:39 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060d.outbound.protection.outlook.com [2a01:111:f400:fe1a::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7bf60ff4-d389-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:11:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7419.eurprd04.prod.outlook.com (2603:10a6:102:80::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 08:11:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 08:11:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7bf60ff4-d389-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VHPWpZdtDyK64D90A3BgbC8RpvNru8I8zGT/6jgkJjlP7r28ypRC/wT+o++dW+LwJGJ83C5wfNjZRo+vYHlNKSE1GJx43FMXFGRbuDVeWEDfA3qInkaXlwypiJOmUBlpa8IwOYFXjM5Kepp7AKmOQ/Qlectsa6VffTrkXKBSAk/xoBXtOicc8NPHzV7RQxNWeFtzTtaxMUdBRTlE5MWJsBNbP9y7OKdXS2OchoYfkxSJjBymSiVpwDmSN9wDIPn6nZCe2bjvVpTr+uYlCmMBowfzg3SdwkzZQLYUKmmnHYUmzBEVs15ugoNjXBEdKXtzHzqDfUCFHM2oD+u6jy7eEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCv6Uw70k5QdWXzfFmwvfNojOrbNjqU6z5B2gibT+ZQ=; b=M0C6L9/zmLXJdbjIVGDSVepBP+THbCHR6E/jHZNWOTOIahqULkrxhUu9Iqkm0vWLGgxHPDrcaSnJL6if6su918gLwHibaOpUTl7RbSjdGOhUmlRh/NXTmeLm5HsKYHGAVVtwJ+k5YxO82gSv9kfRObeDE+WJHw6qEHJLdO25qQH02lsZeDN3cI9gOm3WpbsVkO28JKazeO3UgWwj5ck4N6af/jL0pVNWsv/tHXSDYKN3C8bOLtSbPo9lNFG5vMaojFAhVbN8g6vFmfNs665SpoI/7Uf847heZvXVZuORGQ/X5u2f1cw8Yos6+umT7praazRxp6dCvIAChl/87SmiBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCv6Uw70k5QdWXzfFmwvfNojOrbNjqU6z5B2gibT+ZQ=; b=TnNCEWHzBygeX0PbXe7nF8o7lDoe7B7g2Er+KiHyaHWox9+NjYNrIHktYFyAL52jVhFvgG+Ys7u5kTzMCM3hw0J5cBkJ0P31lioMmsUCtAzcgIjFwLF7QVdobOCb/d4tmYkBS7V3qMKdbGfzoz1zeB5iWRGzuzZuDb7S7shinhbYbGraZ+Xaz3qWxamaubji4V15HmvQEqsHXD0h8AjvcbjAbdTLS4gfDslEPZlbUkJe55cAnClegj04QuL/l8twoitCL7cifwFNqj0y9OZuURfegE0cOosNj4QixwLSZgfmzXr0lPtlB1LIxFzJlU7j+esyJuecEDHbbRCVrPwd5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5cda250b-57b4-2833-99d3-84ae8ca32059@suse.com> Date: Wed, 5 Apr 2023 10:11:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0187.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7419:EE_ X-MS-Office365-Filtering-Correlation-Id: 8aaaa2fc-e1cb-454d-229e-08db35ad5e4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hQrqelugHpzuJ9mUtxy9n/hrtCQ0aTkQUlkXSfWjTcMm7BfT+GaCBG9oeQr7LS3FUn7YSPbEyl+wmj72xBPJmwLiNiLR9ogaCVXzBvXWDQN9UP/AyKSNRjEvvDNr27s+03AC8HhsLLvd/sr69SB2mjZwYzz1qE7nCKcLqtvo7Oh2Rlmzcauqh9M4gVXbIPWOA3HwGFg/RDc8103PzElayvggKvKKLwuD9ametafRZX0Mxv5dsSnxeroVYoAm5ZmgBEvG91NTBBpaWQiDfRHySG7jnLh/0pqkW47bBam1+jY+jqeXI1zp5kwQo1kshKc5tl9xuCl43tJEnVRgEJZKY3i3Rzsmuqd9RNJcpIyXCUsKb2GBHM0m21bYKF0/Sw1kmYkWlshUAO0Q5juDuBACC75V8+v1RuyIOn1qcRTbj3Z05cOem/p1WVWdFQkwXF/eTRvsDN4whbVay91JOpEnj+QsinYJLwGB68l1QsYNV4c0UDplRnSgv2SINgiBJHhHl8d21sRq0mXx9d3IEALQfdzfroHvt/xZlHBhh6WK1wT1DSqD6iG/b7x+7v1pdTD31CfkECxCxFcUpNbdfU/pM5uoRoNppjgiykWRK5u71PhsbPZ/ZfHWAMdubHxMLCA02J5WuI+yp+tRrzaBjZRHeg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199021)(478600001)(66899021)(316002)(54906003)(5660300002)(8936002)(36756003)(2906002)(31696002)(4326008)(6916009)(86362001)(8676002)(38100700002)(66556008)(41300700001)(6512007)(26005)(6506007)(53546011)(66946007)(83380400001)(6486002)(2616005)(31686004)(66476007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RW0rNksrRFhrczFRYUhZWTVqYWlod2xjajJQK0V5M1ArMmU0YUp3c2RsUE5q?= =?utf-8?B?OU4ycC83alpZdk9CUi9LUDNQQUxaRloyaGEwRXJRQjhWUFhEdHpzVGQ4MUJn?= =?utf-8?B?WG0yMlJIQU50NjczVlgyUUgxd2NWdzRjSmQvdWNrV3VCMkJXRUkzb1lWRFNU?= =?utf-8?B?L3Fhb0RLQXlCOEZBc3RBdE8vK3VNVHRudVRmU1ZVLy9EMDY1bW95bHZnV3BC?= =?utf-8?B?SjFML3NLNmFVRVVjY2x6djNmQlFsUHY1WitDaS8ycE1oS2lJbXRMNXlaZmli?= =?utf-8?B?R3hra2pYVW54QU5GMi9OdkIvQUlzUGxvbzdvMnlkb2E1OThKcStaZ3V5dnkv?= =?utf-8?B?Z3pjQ1M3TUdIalZkc0xyZXUrT0hJNmF1V1F5S05VSjFpcjFBNm4ybnhlYUJq?= =?utf-8?B?N3VpZlhZcGlTbzJpWWZrdWc2MTluS0R2WDlUdHNEMWswTitxbVlDM2pYMi9y?= =?utf-8?B?OVI1UDhWdFNPaHBoLzc4RHROcHc3LzdCSFFBL2tONFZkVXBDSU9ucmNhUWNy?= =?utf-8?B?SEtrSElEYkdaQW8vTWUzdTErZm5EbERiWG1QeVV0MFBuUCtzR254UzJteU9x?= =?utf-8?B?THEwNXlaVkc5OGdrZFloTXRWR25Vc0h2RFQveDVIQlZHbkVkRVJhLzhybHB0?= =?utf-8?B?c0lHRHNMMllKWDJkR1ZMUUJuOXZwc3ZBRTlzM1VIbWVHT3k0QjhwL3c0Zlp3?= =?utf-8?B?K3dGdUsrRFZyTDJHdWdkZVdqaVVDVlR6NnNIMFBPWXlKRnNtZVNtY1VKVFNx?= =?utf-8?B?VExjYVllZHljU0pUMHd0ODBpKytTaWR2NGZoMmw5MmkydFNuNlp5eFFsM1ZI?= =?utf-8?B?dUZmU1NGNUNjSmRPWmlIeUdPcVY4VmRseU96RzlLZWV2SkhPNzgrVlpPaDBy?= =?utf-8?B?MG5ubEpGcFZvNzNSQ0pJY01LU3N0RFE0am5Ed2JPdzdqMVlmQ1k3VmhLamVK?= =?utf-8?B?YWxRWVJ2VnJOVy9rbjFHb2NySlBQQWJFVXpWVFRjbzhXS09OOG9CdUhTNTR5?= =?utf-8?B?aVlIcUVTNVVlZ3BkSlR4aDIzL2l1Rk5WV0JCVEMrSVJQK1E2RzdJQ2VYYTBt?= =?utf-8?B?K2dvYmxDZ0UxL3FKenFEenMwSXFlL1I3akhrL1MrUkl1OW56UER2bm1KQi9m?= =?utf-8?B?eGswYnY1R2ZZZy9LY2RsejFsSUIzL1BxNGgzOWUxbFpMbU5JSXdsQlNHUGVY?= =?utf-8?B?ekRpdC9Pd3lVbjRFZ0kvS2I3YWFJVzlwcDhwaUdZK3kyUzJsY2Z5SmxWekR3?= =?utf-8?B?eE9aVmlqU1FrbFdlU1d2YnEwa3BEcHBNTExvM3hKQVVjcEh3bWxjeTN6SjhG?= =?utf-8?B?VS9RVm5pbUhCN05KdHhzcUFLN09UQVFsWCtkcFh0aDZvdWZZQk1jNDlaVHMz?= =?utf-8?B?cU52TmYwdXYrTks3amJDdXlMV3BWdC9pQU5HTDFhSytMVW9ELzlkSTFHeXpD?= =?utf-8?B?ekJ6cERmSFU1V2R6SDF6Vk41NFc2amRjdS9na1hQVVdnQ0hJcHk0ajRZclZO?= =?utf-8?B?WWhlcWZlekJySWwwZkY3WWNvWVN4MmdPYjVKZUZEeDY1SGNNa1hiMWJRLy95?= =?utf-8?B?czFyQm5keElpN1VxY3BReStSa093Y0VtR3ZYczJPY1hjWkFSdGYyUTY1VXBk?= =?utf-8?B?S1ZxM1pPRnY0S2JsemxlTEdOb0hEdnFSTGltMEVKVUFVVHF0TzFUVUY2alBJ?= =?utf-8?B?cDdsd3pRMW9EdFhscXV3UXN3a0FuYmF1WlpKNHFhbGMwaDhIb1ZGeEszL3V0?= =?utf-8?B?VzdBckNYSlhmaGp4TXlqR2hsRy9SU0R4dmE4Y2hwSEZUd28rdnREQXVULzU1?= =?utf-8?B?UXNaNkl0bjJuZXV1NTl1ays0VWc5cUN4WGFVZXcxcVpvdWhKMlJNdlNER0Uy?= =?utf-8?B?UnM2aWxPOWdNS2xPbmR5bnVPYnE0WnlCTjYyOXp2a1lzNXZRTUZXc21NUUJX?= =?utf-8?B?YVYxa3l0RnVjZkdlbkgzVEU0ZkNKaTJOZExiOXZ2U3hScThPN2dPKzVUbDFi?= =?utf-8?B?aW9GUnVhWk1xM1ZJNmNkNDNlSVgzMDlqQ2t6WXBvSlA4N1cxRnBTTnF1VlQ4?= =?utf-8?B?VkdRb01aak1qUDBKYnVndFRaVUI0c2p1dC9JWjhHYzJ5RkJXc3hGMGgrSDZm?= =?utf-8?Q?D4litlYL1SyzgG0K5m7OJ+Tsk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aaaa2fc-e1cb-454d-229e-08db35ad5e4c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 08:11:33.2429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cJwwp4Wu2JW559/hlApxWMpu3OcVu8dpes5DDXmUbyjx8IPoFixFzmUE8KNdr2q+G80Ep2CjpCm22dC8TtNiXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7419 On 04.04.2023 18:38, Roger Pau Monné wrote: > On Tue, Apr 04, 2023 at 05:57:11PM +0200, Roger Pau Monné wrote: >> On Tue, Apr 04, 2023 at 04:24:16PM +0200, Jan Beulich wrote: >>> On 04.04.2023 13:41, Roger Pau Monné wrote: >>>> On Tue, Apr 04, 2023 at 12:31:31PM +0200, Jan Beulich wrote: >>>>> On 04.04.2023 12:12, Roger Pau Monné wrote: >>>>>> On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: >>>>>>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still >>>>>>> applies to guests also when run on a 64-bit hypervisor: The "extended >>>>>>> CR3" format has to be used there as well, to fit the address in the only >>>>>>> 32-bit wide register there. As a result it was a mistake that the check >>>>>>> was never enabled for that case, and was then mistakenly deleted in the >>>>>>> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume >>>>>>> CONFIG_PAGING_LEVELS==4"]). >>>>>>> >>>>>>> Similarly during Dom0 construction kernel awareness needs to be taken >>>>>>> into account, and respective code was again mistakenly never enabled for >>>>>>> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by >>>>>>> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). >>>>>>> >>>>>>> At the same time restrict enabling of the assist for Dom0 to just the >>>>>>> 32-bit case. Furthermore there's no need for an atomic update there. >>>>>>> >>>>>>> Signed-off-by: Jan Beulich >>>>>>> --- >>>>>>> I was uncertain whether to add a check to the CR3 guest read path, >>>>>>> raising e.g. #GP(0) when the value read wouldn't fit but also may not >>>>>>> be converted to "extended" format (overflow is possible there in >>>>>>> principle because of the control tools "slack" in promote_l3_table()). >>>>>>> >>>>>>> In that context I was puzzled to find no check on the CR3 guest write >>>>>>> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any >>>>>>> of the low reserved ones) could observe anomalous behavior rather than >>>>>>> plain failure. >>>>>>> >>>>>>> As to a Fixes: tag - it's pretty unclear which of the many original >>>>>>> 32-on-64 changes to blame. I don't think the two cited commits should >>>>>>> be referenced there, as they didn't break anything that wasn't already >>>>>>> broken. >>>>>>> >>>>>>> --- a/xen/arch/x86/mm.c >>>>>>> +++ b/xen/arch/x86/mm.c >>>>>>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ >>>>>>> unsigned int partial_flags = page->partial_flags; >>>>>>> l3_pgentry_t l3e = l3e_empty(); >>>>>>> >>>>>>> + /* >>>>>>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not >>>>>>> + * understand the weird 'extended cr3' format for dealing with high-order >>>>>>> + * address bits. We cut some slack for control tools (before vcpu0 is >>>>>>> + * initialised). >>>>>> >>>>>> Don't we then need some check in the vCPU init path to assure that the >>>>>> cr3 is < 32bits if we allow those to initially be set? >>>>>> >>>>>> Or will the initialization unconditionally overwrite any previous cr3 >>>>>> value? >>>>> >>>>> That's not the way I understand this "cut some slack". Instead I read it >>>>> to be meant to cover for the VM-assist bit not being set, yet. Beyond >>>>> that it is assumed to be tool stack's responsibility to constrain >>>>> addresses suitably. If it doesn't, it'll simply break the guest. (There >>>>> is some guessing on my part involved here, as the original introduction >>>>> of that code didn't further explain things.) >>>> >>>> If it's just the guest that's broken I would think it's fine. As long >>>> as such mismatch doesn't cause issues in the hypervisor internal state. >>>> >>>> Did you see a toolstack setting such entries before pae_extended_cr3 >>>> is set? >>> >>> To be honest - I didn't look. As said in the longer reply to Andrew, I >>> think it is more logical this way (the page table root already being >>> validated as an L3 table when vCPU 0 is inititalized, which includes >>> setting its CR3). Hence even if right now the order was the other way >>> around (which I doubt it is), I wouldn't want to make impossible to >>> restore the original ordering again. >> >> IMO I think it would be better if we could already report error at >> domain creation time if the toolstack is attempting to create a domain >> that the hypervisor knows is not going to work properly, rather than >> allowing it and the guest failing in maybe non obvious ways. >> >> It seems to me however that we would need to fix xc_dom_boot_image() >> in order to setup the vCPU before creating the initial page-tables. >> (->setup_pgtables() hook being called before ->vcpu() hook) This might be a possibility, yes, but it's (imo severe) scope creep in the context here. All I'm after is to restore code which was delete in error (and which was, when it was still there, not properly put in use in all cases it would have been needed). >> So I don't think this is strictly worse than what we have, but it >> would also be nice to get things sorted out so the ability of the >> toolstack to shot its own foot is limited. > > Maybe I'm confused after all day, but isn't the hypercall used by the > toolstack to set CR3 the same one used to set the vm_assist bits? > (XEN_DOMCTL_setvcpucontext) > > At which point we just need to make sure d->vm_assist gets set before > attempting to load the new CR3 (seems that way from the quick look > I've given at arch_set_info_guest()). Right, it is this way already. But that's not the point. MMUEXT_PIN_L3_TABLE may (will?) come ahead of this. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:20:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:20:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518309.804698 (Exim 4.92) (envelope-from ) id 1pjyMv-0003RY-SC; Wed, 05 Apr 2023 08:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518309.804698; Wed, 05 Apr 2023 08:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyMv-0003RR-Os; Wed, 05 Apr 2023 08:19:49 +0000 Received: by outflank-mailman (input) for mailman id 518309; Wed, 05 Apr 2023 08:19:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyMu-0003RF-AF for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:19:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0612.outbound.protection.outlook.com [2a01:111:f400:fe0e::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9fe97a41-d38a-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:19:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7034.eurprd04.prod.outlook.com (2603:10a6:10:128::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Wed, 5 Apr 2023 08:19:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 08:19:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fe97a41-d38a-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJIIw9REseH4fauPitjsdNPAjQyVKU8SiTyUGnIXdsFKVMGxsT2Zn+kzY+qR2NaYdBoMfV0W7NuoA0WGtDo6ipN/+eJlF5SrroHmk0sLHikPIjRBdwFnNFwd9fYufaSk2uqr4455R/v+AkjxX4wqDR2WXEJ0spyNgPCay9jeG7Gklqd6UAkrFrUAcZi71y/dyRNYTD3jdr5RtWSzZ6PNoqWdAVrdnnoUitEZ2Q4qYIKtl01689tRGbYL8hSiDcZ0g8AT8oA1eojMcwnA5iUTEaZnrSsRtbJpahiZQVR87v3pzaUg9qFH/Pg+61sGuc6EviojFZnhvQDuhtpotZXOVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KvZ9P6Oc5QfRT6Z13Iipi/AKyrzjUUpibjnnKvc4YWY=; b=al34kqBMu4YlavyoKPMQSrm6yUkiv4GyhiWhe+D9VRmXHasiO17/USrJPoKsAX9yECrZEKRUYLERf0TpnfwXsw1e3XZD7i9kGvjgADQag/9z2WSbVT9yM4sfP+N/75VscTYhMqoZQnLDyTXbY5tpg0Y5595lmbkjOBOXG1+kbGXttnhoFyorQrkERLVT00KnGPse+A2lazHx+alU6+w6Omryh5erHJH4L5V4NfWOTASF6JmDJ85ThR3o6rucwHP8LCRFJ3W6O8vYVPQWUrUTF27xMxXF+oB8E9v8MkPX6FS9vB6mt1XJbGzbHQuLoegE4XqQftaAIM81jnsAeUhu2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KvZ9P6Oc5QfRT6Z13Iipi/AKyrzjUUpibjnnKvc4YWY=; b=R8cekt3y2+riXqT9vV6/gNV5YGGimhmLaK5sQ1RpRyq4nMqpqGcU7XpgcVP4Iv1FZLNa4CQoOeV5XAHUscDoHb2TskY4J4SgChMm9Tlx7pONBCd9Dl2+e5qpidQKtl4kE4zaXSk4kZk/FHqn2m0C8vJRnGohl+uiu8ozrI3s32A549S77LwLr3WW/zAGAnVRbs1vratXsADCRkTlbWZyvx1WOlDuiKsEFu+KInyXjB9U85giMEKuBxYiv6aN4owAt9bObd2fjk9znDsqXvdlUaTOVbmje7tL+9AIhE92BForPb2oQEHE8tTa1aU2I8vQW8KQP94p7aWLxR7WhwRb2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2cc24b27-d2d2-4f15-acfc-acfd802f04a1@suse.com> Date: Wed, 5 Apr 2023 10:19:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3] libx86: Update library API for cpu_policy Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230404095222.1373721-15-andrew.cooper3@citrix.com> <20230404210600.1404532-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230404210600.1404532-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7034:EE_ X-MS-Office365-Filtering-Correlation-Id: 87c538e9-cb39-440f-43f0-08db35ae82ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qe+8HgCJYGrx+Vw8t2FhRJqNaoT/N2nahDreqbEKA/aOOLtb5i1flnZO+zSeugY8OiGHAZRSh3o0yM6FCIF4gGGgm5MqglOmFUVyTqa13mI5YM0Jj+MwmrYjI2Pf4+mHlzNdJAoJUB8UIKi+spSNBp7bIxNZSyAUxAzWfZWyw51gp6J+xD+p2oYLcZsmF9jTCzduMvKzrhDyMmx3/GrZnFlN6ONzvyyz56ZFJEN3FrbJ38eeh6Q1OCZECms8epxk0dmBCJ5dK65VANMSQ71gXUSZ6oHag4SyAULXO15HKeXuXIL4XxJzfJtYQNc3mkoPoklJYZ2L97MZHKBSshg1byQ/DHqhYL9neRx7g+W1TUCI1Ul0+XDTKkSkV/vvlRRWteYzqqxQu/PbHX1lEcj9ztM9rZ5bwSRIl+rA/0A87Dy4MCHRA/8yGJUbFLWCg5TaEULsw4Lrv2pG1+sTLGqF9dZRgXLOrkDbyz7ceY9ly0+Tp5PtKjtSgHmfK63OCa8+kweuAblO5xygrAs79senXo6gQ7yIPNdlv8SWSBxs1KdGknzd3uyviWF+Mn0v+gbaYDlIrMAx24qTmdUBCU9qkzTAlcufbWfFSpcqGPw3CqTynDQgdM1EIRcFiEp7VOmANHiIt7jIwjJ2P1/Ln/UH8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199021)(31686004)(36756003)(38100700002)(5660300002)(4744005)(2906002)(8936002)(8676002)(66556008)(66476007)(41300700001)(86362001)(31696002)(66946007)(4326008)(6916009)(2616005)(26005)(54906003)(53546011)(6512007)(6506007)(316002)(6486002)(478600001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0pmWHByU0kxNiswQ1pTd1RXdFlYM0F6NHl0VGZlRnowY0pVUXkrelFwSzlP?= =?utf-8?B?WlZoeE5QSkwyU0FGMGlUV2ZxR0Nhc2JQUjd0cnJaaFdURGVtM3pQZnhPTjBE?= =?utf-8?B?SS9KaStxMlZDcVFPNFo3NnhVS2NtVGoyOEpOcVV0RHFlUGc1ZWRIWGtiODFQ?= =?utf-8?B?YzZ1Tmw5WEtFWVVzaWJSb0lMVWVLVXBIRnkrcFlUMkpkaFJ2NnlveUExRThh?= =?utf-8?B?SCs3TVdGNUFSK3RySjhQREt2QVZ3dXlOd0dORTVXeEltM29xYTVLZTJSWHNv?= =?utf-8?B?c2xyT2dDMm1yTm11ZzlCVkhaZnZ2TkVjQXozVFZML2d0cHF5VTRRZWxBRzhZ?= =?utf-8?B?bGZLREhIYTVtQ1MzNFg0YUwxUHFjM1Y5aXZtbjhuRStDdUp6SEhsVlN5WG43?= =?utf-8?B?Rk1UeWoyZkd6ZFR4anZwZEhKOUw4ZVZFR1RBbk1lQUhGRlNLZytkRkZRbWVu?= =?utf-8?B?STNLNTBnakNHM0VsM05FS3BtYWVCZ3VCOEpYcmx2REhMS2VsYmo4dkluVG95?= =?utf-8?B?OHJ3WEpxUnNvK21NMTRMVkpXbHkwQ1k4M3JNUmR5eEJYOWxDUUFaK0pBT3Zy?= =?utf-8?B?eGlXOGNJQzRib3k2blpZZjJsdW0yTHZvTGhvSjVKNXBFNnZNaGFKU0lHM2RQ?= =?utf-8?B?Nmp4eklaRDVwMHVRbkZXRXprVUczYkgvV3FBY3NONmE2T2xvY2ZRdW1HVDE2?= =?utf-8?B?aGRlR1pjcHhsalpMTDNkNjRVY0tzeVo3UjhxNDlyYkZFMDNSTlFVUWcyU2kw?= =?utf-8?B?OVZXRHdLdVpJbXFhZnErOFE5TW5qWnRhUlVLeXhhdG5GZnd4M0RFZG1KNHJ3?= =?utf-8?B?ODlMZm9McnFpRi9RSW90d3NrUk9tSjgxWmRpd0VxTGJhS2xqYlE3Q3RTaXVl?= =?utf-8?B?bHd1UWw5K2RIeGVYcUN0cnNSQ1FVRXZtNmN6ZklXYmtPenB0NG1INXpTamZF?= =?utf-8?B?dWlaS2oxYndHMms2TE92Umo5bXE5QVdjeDRBTnEzcENuVUJxcVdPaGFqc3ha?= =?utf-8?B?cVFBT3EyQjlPdlQ1QS85bXJKWUNTZEFUbTRYRElndktZNzJoNkZpRXIyRnNI?= =?utf-8?B?cjdldjVKaHlCZmthMTBKcStoak82aGwxQUJGR0Z0YitHYm1yaWZSOUkvTE5s?= =?utf-8?B?c0hrT0xUcWFWR0t6MzJvM1phNUhucTdWTVlUOEdON21IQVdnL0FGTnpzWGk0?= =?utf-8?B?S1Z3MEdkVmEybnBlaEJjRWtUTnFmVHhqbVpYYUpVUll5UFJSUUg3UkNSdm91?= =?utf-8?B?UHlTcXh4SSt4aUtwTkFPZlJRSkF5czdMSUJKR3RqV3pmYVo5WEU0TEUxdGw0?= =?utf-8?B?QnQwQU9xK2FneE9SbCsraGNZbVUySkNrZHpFeC9OQ2x4L1hXekFBWEhlcFNh?= =?utf-8?B?VlZjbmQ3Tm5EakpIOVdOcFcyb0dZZDRNd3E1VEhwc0xjZWp1clE2R1VWTDla?= =?utf-8?B?YjlVZEVuV2pvTlBEMFdjdlZpbzVGd0E2dUoxejB1S2xBTnFiUFRxeEozQXhZ?= =?utf-8?B?ZjVERXpFY28wU2lIS2IwTmV0emhRUGlZUW9WNDlHY3l6TndpYS8xUzgwbW9j?= =?utf-8?B?RHNrOGcrRm9KYmxmdGpBWVNHZGEvaERrcXJidk1xYThYbEEyZ2t5WWlsZ1Zp?= =?utf-8?B?U3o5NDVjWEpEWHRqNWxEcU5Dd3RBdk5KVi9FSTRnZWNSSTUyNFY1amF6ZmVa?= =?utf-8?B?dVJUU0EzNlBWWDVtT2d5aCtMeG9zT2h4dzYraitrMFZKOFNNUEl0Y1h4Qm1W?= =?utf-8?B?dDNFK1RlN0ZJR1BRMTg2ei9WOGtkdmJKK0M5L3FPTzNjaWdETVFVTlY0aS9z?= =?utf-8?B?Z3VQMm92N0pOekJZK3dJQjhZQmhwbndvV21uR2FsRGNhb1owZC9LZm1TSGo0?= =?utf-8?B?YjF3SWFLbGFPYlpIcENyNkF4TEF1dkhiZUdTYkc0NXhFUkJZbU1rMHNIeDZP?= =?utf-8?B?RXlKbFdZanhLY29BRzZic3h2aEIzVStxb2VCd2N4MFFtWkFEaEJUMU9NYzZT?= =?utf-8?B?UXJpRm9ReVZHUTZzakcvNFZSVUduSzBSekJicnVpQzhmMkNqUHJiZUVteFRw?= =?utf-8?B?RVJmcHZYcjdGYnFkSnRwTU8vaDVVeWF0T2tGRDhZZ0ZwK05tUVJma25ZYUFF?= =?utf-8?Q?zOUB7xSA8+xGgda74F7X46e67?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87c538e9-cb39-440f-43f0-08db35ae82ad X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 08:19:43.8521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VgEpno+jo7JJVlWQf6WJvItBSVk/RcBNNWqxD8i8MwggAUOzfqXKnYVuvyGR9aqE+feK2PiR+sh0GmmHHY6U6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7034 On 04.04.2023 23:06, Andrew Cooper wrote: > Adjust the API and comments appropriately. > > x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a > TODO in the short term. > > No practical change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:29:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518313.804708 (Exim 4.92) (envelope-from ) id 1pjyVd-0005CJ-Lf; Wed, 05 Apr 2023 08:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518313.804708; Wed, 05 Apr 2023 08:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyVd-0005CC-Iy; Wed, 05 Apr 2023 08:28:49 +0000 Received: by outflank-mailman (input) for mailman id 518313; Wed, 05 Apr 2023 08:28:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyVb-0005C2-KY for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:28:48 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dfb21dff-d38b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 10:28:44 +0200 (CEST) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 01:28:41 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 05 Apr 2023 01:28:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pjyVH-00CkZe-2G; Wed, 05 Apr 2023 11:28:27 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfb21dff-d38b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680683324; x=1712219324; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wrn29fWEWUh9DQE7oDLC0JoUgdEFYGWX1tgF9OvmiyE=; b=Pl3Z1zw4nobkhQz6coU1698+mcSuAFdqkrLJcvMRStDyV1mrbcjwDE8F PtI+Nr5V++PRN7Is3hyfrpbvYKboIPPJNPpcB7iO5RCzWlvRqz4x1Y5Ia kZBvxgBRGR9HO2jb/dn6zicDAel5/RWqo+U/4MjyKf0UGqUsQg/ZhLdr7 ogcaezPy6S9+SkEyTeTJ7/vQ7CmR4nX5NmnTFGiTM6kU78BtiHYRziK8F 4k+G1+WhqqdkcgAIbvmOsYCq/RGietDTHH4jFtbVZV1DKb7VMuneJpTeJ K9LgrCDJe4BZpj3GjLi/qJyQOE7ZDE3Cv1tGnP2xyf/AYCzfTD+3FYIuh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="344113398" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="344113398" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="751192534" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="751192534" Date: Wed, 5 Apr 2023 11:28:27 +0300 From: Andy Shevchenko To: Bjorn Helgaas Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users Message-ID: References: <20230330162434.35055-1-andriy.shevchenko@linux.intel.com> <20230404161101.GA3554747@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404161101.GA3554747@bhelgaas> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Apr 04, 2023 at 11:11:01AM -0500, Bjorn Helgaas wrote: > On Thu, Mar 30, 2023 at 07:24:27PM +0300, Andy Shevchenko wrote: > > Provide two new helper macros to iterate over PCI device resources and > > convert users. > > > > Looking at it, refactor existing pci_bus_for_each_resource() and convert > > users accordingly. > > > > Note, the amount of lines grew due to the documentation update. > > > > Changelog v8: > > - fixed issue with pci_bus_for_each_resource() macro (LKP) > > - due to above added a new patch to document how it works > > - moved the last patch to be #2 (Philippe) > > - added tags (Philippe) > > > > Changelog v7: > > - made both macros to share same name (Bjorn) > > I didn't actually request the same name for both; I would have had no > idea how to even do that :) > > v6 had: > > pci_dev_for_each_resource_p(dev, res) > pci_dev_for_each_resource(dev, res, i) > > and I suggested: > > pci_dev_for_each_resource(dev, res) > pci_dev_for_each_resource_idx(dev, res, i) > > because that pattern is used elsewhere. Ah, sorry I misinterpreted your suggestion (I thought that at the end of the day you wanted the macro to be less intrusive, so we change less code, that's why I interpreted it the way described in the Changelog). > But you figured out how to do > it, and having one name is even better, so thanks for that extra work! You are welcome! > > - split out the pci_resource_n() conversion (Bjorn) > > > > Changelog v6: > > - dropped unused variable in PPC code (LKP) > > > > Changelog v5: > > - renamed loop variable to minimize the clash (Keith) > > - addressed smatch warning (Dan) > > - addressed 0-day bot findings (LKP) > > > > Changelog v4: > > - rebased on top of v6.3-rc1 > > - added tag (Krzysztof) > > > > Changelog v3: > > - rebased on top of v2 by Mika, see above > > - added tag to pcmcia patch (Dominik) > > > > Changelog v2: > > - refactor to have two macros > > - refactor existing pci_bus_for_each_resource() in the same way and > > convert users > > > > Andy Shevchenko (6): > > kernel.h: Split out COUNT_ARGS() and CONCATENATE() > > PCI: Introduce pci_resource_n() > > PCI: Document pci_bus_for_each_resource() to avoid confusion > > PCI: Allow pci_bus_for_each_resource() to take less arguments > > EISA: Convert to use less arguments in pci_bus_for_each_resource() > > pcmcia: Convert to use less arguments in pci_bus_for_each_resource() ... > Applied 2-7 to pci/resource for v6.4, thanks, I really like this! Btw, can you actually drop patch 7, please? After I have updated the documentation I have realised that why the first chunk is invalid. It needs mode careful check and rework. > I omitted > > [1/7] kernel.h: Split out COUNT_ARGS() and CONCATENATE()" > > only because it's not essential to this series and has only a trivial > one-line impact on include/linux/pci.h. I'm not sure I understood what exactly "essentiality" means to you, but I included that because it makes the split which can be used later by others and not including kernel.h in the header is the objective I want to achieve. Without this patch the achievement is going to be deferred. Yet, this, as you have noticed, allows to compile and use the macros in the rest of the patches. P.S. Thank you for the review and application of the rest! -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:30:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:30:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518319.804718 (Exim 4.92) (envelope-from ) id 1pjyXQ-0006ij-4P; Wed, 05 Apr 2023 08:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518319.804718; Wed, 05 Apr 2023 08:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyXQ-0006ia-1a; Wed, 05 Apr 2023 08:30:40 +0000 Received: by outflank-mailman (input) for mailman id 518319; Wed, 05 Apr 2023 08:30:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyXO-0006iP-8w for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:30:38 +0000 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22ae3d07-d38c-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 10:30:36 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 01:30:34 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 05 Apr 2023 01:30:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pjyX4-00Ckbm-35; Wed, 05 Apr 2023 11:30:18 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22ae3d07-d38c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680683436; x=1712219436; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=o2D+LfXhLk+QrH3a0th/mLBmSHhjZTr2yV97vm5EWfI=; b=DgfI8W389xQ6g+SnxwTeLhQmkeB2ju0MgkeZzkdeom0I2tnAebnK/r7K Qoz78Ty8b0NqEL+/SjCIZKu04l6vtBxLrZDu8MSwiw5PBPJRisW6dPHqB GkbtSZerwjCBIAwwDQWzkAhsqhGi/RA42hbU7jBgBrzRBN9dmTr5/BXb5 llt3CWAAoB7L0tSaszYLyXVyiKIHUTUYeOoKY5jSCBSM6Pva7mUQ80wh0 ObwqRx7LHIGMZ3uvlhghyalLqbn12y6pIL2+IjzMb8EtpyxuHGobA3Xgi vIpTcj1c75leYMIo5mVNPx76x7IkUMnPbFfcsxN6YpQ7aIWjDTtNPeYAL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="322058593" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="322058593" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="860894821" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="860894821" Date: Wed, 5 Apr 2023 11:30:18 +0300 From: Andy Shevchenko To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource() Message-ID: References: <20230330162434.35055-1-andriy.shevchenko@linux.intel.com> <20230330162434.35055-8-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330162434.35055-8-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote: ... > @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) > */ > if (s->cb_dev->bus->number == 0) > return -EINVAL; > - > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > - res = s->cb_dev->bus->resource[i]; > -#else > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > #endif > + > + pci_bus_for_each_resource(s->cb_dev->bus, res) { > if (!res) > continue; As pointed out in the reply to Bjorn's email this hunk needs to be revisited, since I wrote the documentation for the above call I have started understanding the deal behind this special treatment for X86 case. -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:37:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518324.804728 (Exim 4.92) (envelope-from ) id 1pjydJ-0007Ye-Q3; Wed, 05 Apr 2023 08:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518324.804728; Wed, 05 Apr 2023 08:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjydJ-0007YX-M3; Wed, 05 Apr 2023 08:36:45 +0000 Received: by outflank-mailman (input) for mailman id 518324; Wed, 05 Apr 2023 08:36:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjydI-0007YN-Hn for xen-devel@lists.xen.org; Wed, 05 Apr 2023 08:36:44 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd3badf8-d38c-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:36:42 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id r11so35341365wrr.12 for ; Wed, 05 Apr 2023 01:36:41 -0700 (PDT) Received: from [192.168.0.106] ([91.123.150.38]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm13806796wrr.100.2023.04.05.01.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 01:36:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd3badf8-d38c-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680683801; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pgcwjOGVr1lFUtMdP9HgDE1IUQk05oAJXW/E6R9ojlg=; b=nec8S49q1O8S+prmVrvx7Te7QroUTNSdm/2WXcKzONbDjQRldGX1Mr7AS5BMRnpwzP Nk1iu58bReXmw1Nv7CXSJm837UmL4XYMoKX7p5TGsKI8pateVn9ytaqVESFUiEYRNDDF Wz7crxIvJVPfuF/dxsSOW+MTBhBpyCAZN9nDGEvgnmM1OEeGUTjTUqvIyo261MZyRqhH VpkfV3Qil6dw/9FOxhTsQiQGWhQZUcNzYYDfmy1RAsP7FuBsuRk9wuB/q+a7cyMCmnrc ntv3d2jT7y7j1QVVSaz6LYyQ43woWI6jy14pLOAFsareox5dkCBhP4XzqMyP4KQPWIXo Iylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680683801; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pgcwjOGVr1lFUtMdP9HgDE1IUQk05oAJXW/E6R9ojlg=; b=v3lpE0u/UpHrPqpzQqzA1X5A4tfsPEEglxuf5Hl6BXJouWd97XxSuOxpgwnxJjcgGY inUDQQhXqV/AT1DAW9yKS5FQGQWcxkACF+Gws+Ij0hrpYzbRRqzs18F/gy+hYjS28vRN TLpjx6/xF7qv7xXy3doGvsklw6S2d+WSskLOKlZHQ1uMg/FE1yVujMXTEN5chh5DwUP/ jTBpiBpuUjabGutHHqZFyO5a3WcfdxiXfCT99rwU+rO6X6EF6sWKgIArY7r3RBGzmUH+ 6cvAKJtyxr4arIDR7dhbA6vdCPuCeriSjtP42oQqp/2VdOUxzFzVPqdOuikAHuLSBWEE M53g== X-Gm-Message-State: AAQBX9dQBQWBZlM4dNAxU8uJqnZs8kEkRdtyTQU9FfjDcqAwjKWy3twQ Q6VSEAWYM/08rmSa+E+PHxQ= X-Google-Smtp-Source: AKy350Yx9d0su5dgNq1fXie+FM2THoKzDb9lZNmvrjool5qMebXAgSseo4f31iSy9RiikftaOrgnYw== X-Received: by 2002:a5d:5188:0:b0:2d6:a357:f138 with SMTP id k8-20020a5d5188000000b002d6a357f138mr3257363wrv.18.1680683800918; Wed, 05 Apr 2023 01:36:40 -0700 (PDT) Message-ID: <37fa3d37-5ee7-863c-48cd-1ce313c8e296@gmail.com> Date: Wed, 5 Apr 2023 11:36:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id To: Viresh Kumar Cc: Vincent Guittot , Juergen Gross , stratos-dev@op-lists.linaro.org, xen-devel@lists.xen.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Erik Schilling , Julien Grall , Anthony PERARD References: Content-Language: en-US From: Oleksandr Tyshchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.04.23 03:12, Viresh Kumar wrote: Hello Viresh > For generic virtio devices, where we don't need to add compatible or > other special DT properties, the type field is set to "virtio,device". > > But this misses the case where the user sets the type with a valid > virtio device id as well, like "virtio,device26" for file system device. ok. For the record, a valid virtio device ids can be found at: https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-2160005 I don't know, maybe it is worth adding that link to commit description. Also a NIT, is this example "like "virtio,device26" for file system device" precise? According to https://www.kernel.org/doc/Documentation/devicetree/bindings/virtio/virtio-device.yaml the virtio device id should be in hex, so for file system device it should be "virtio,device1a", or I really missed something? With updating description if NIT is correct (I don't know, maybe this could be done on commit): Reviewed-by: Oleksandr Tyshchenko > > Update documentation to support that as well. > > Fixes: dd54ea500be8 ("docs: add documentation for generic virtio devices") > Signed-off-by: Viresh Kumar > --- > V1->V2: New patch. > > docs/man/xl.cfg.5.pod.in | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index 10f37990be57..ea20eac0ba32 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1608,8 +1608,9 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is > > L > > -For generic virtio devices, where we don't need to set special or compatible > -properties in the Device Tree, the type field must be set to "virtio,device". > +For other generic virtio devices, where we don't need to set special or > +compatible properties in the Device Tree, the type field must be set to > +"virtio,device" or "virtio,device", where "N" is the virtio device id. > > =item B > From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:44:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:44:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518328.804738 (Exim 4.92) (envelope-from ) id 1pjyku-0000nn-Hd; Wed, 05 Apr 2023 08:44:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518328.804738; Wed, 05 Apr 2023 08:44:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyku-0000ng-ER; Wed, 05 Apr 2023 08:44:36 +0000 Received: by outflank-mailman (input) for mailman id 518328; Wed, 05 Apr 2023 08:44:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjykt-0000nW-KI for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:44:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0d::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1617d8f3-d38e-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:44:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8106.eurprd04.prod.outlook.com (2603:10a6:10:24b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 08:44:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 08:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1617d8f3-d38e-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qoo4qaPbM9PoWjOzDF+6Kl9PT4V7A1jVIpKBy7iQeEH8hutvXZyTlHOs5poH4GD+OaTn4mjT/Bpe7voidQpDJpnvuk/QuqmLsqhygDYT+b94qMW25YMRsEP14mEphqNhLJWNYNY1pjl8IdFCYDN9HhohmZPyts/9hqgAkFSX6PmOoK/6dZVV5JwnTC5fEmZBHgCsH05SyrP1ghcokLwnuidxdOxkXtJKe27K3J8lswt+0zmWa0RXIIofClw38BHSwijyOuXHIxopWA53ncFjYOOv37UDq7SWrTCh6VavRvWq/OggqmyV8y0FrjerKR7x5tEP/tGACZx8g2EQJlJLUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vupqexl+OQR8xvArBtJGbcSswETVQm/vq3260uXglUI=; b=UV52cjepPlk2NsrSaRJo+AN2qYA2PKL+TvfHRev/I3UKhYugjx5z2NBG384EXoUXIyZ6P9Fwjpa/JSDtFaxaK5RB3rEqnGozuhDyT4wOZ/eFEvWrVCJ/DNPEZQWdzyUriSEA+r9tKueIc0gA5Ql1d6+EW5A0Jy8za3MFKGMT1IMCpiNHG2WGpYlA17MWDu/g/WPmfkq+0WRckMaFUjdLZ0iD4nX86Pdwmxq/1Yo1uWtqSLk05ogeh/DuCQMio/b4HF2imp54pC5AD9zm4g4MGTQPj+oYh2V0nje1obEbB7x/rEDiACLSVeixF7tbeFHbsN4Jra8Wh3HXszXJttr7tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vupqexl+OQR8xvArBtJGbcSswETVQm/vq3260uXglUI=; b=RPE6Ka82iyrqAGrDOKh/nTlMt4Weojedes/kjbONb8a9xSqGrJ+QcluHJD1RxiqNxutg3CjrEr7m/goflyoWSjvVWKjeMQlaVbXruVrCCRA3vRXXc1UrvIIoTenDWFc8s4TAMsZ+9Thp8v4vwghhSVzdomejfb12LF8ltboMXk/Rw74X6PajwKLRKpdY06byHGcohV9hgc3IcJgmrI6jK7q4SopuA5/vePjddodVErd8xPBhRyivbCgqd47wx6bB4IgxUMbWRBu/V+usnuOJfwpZ+fe8hn0njJ7wZduoqraoyuUszoSunwmoMfh/x/U6Dsv2u0T8/+5p6JIzAR9uiw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0f997105-4601-683a-7edf-d3fe5ee5aa48@suse.com> Date: Wed, 5 Apr 2023 10:44:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <6d64dd4a-5b25-ddca-5c07-7b4c0fc48c0c@citrix.com> <5f9218c1-9ee9-c5bd-af8b-003084aa66e4@suse.com> <78e72635-6ebc-b3b7-83d5-134d5c63d561@citrix.com> From: Jan Beulich In-Reply-To: <78e72635-6ebc-b3b7-83d5-134d5c63d561@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8106:EE_ X-MS-Office365-Filtering-Correlation-Id: dc0cea9c-568f-42cd-2b5f-08db35b1f7c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBlpMTUQIuvZJuyLUhYSAH8M3MTbbr4yZJ2lV/byyiW3iJekFd8FCNRSKLItXoXyVgU4+f8ZJNn/EasSNhpLaiZP6Rs0Aj2Ht0UhOumg7tHx7gekNi8H53H3Y6kk2AuvoJaf0MAIAUaZbeWAPq6/fpTh+d2/bf9JpueJ1qmki65VJ0COXxfVf+uxAXWT08wm76njYY8ReDwTK+KvM5E3eA6ahbNV0/WO14ZJN1Xbwq6uxmB1Z/YpCAIj9f4Myi3HMjEO+sIjL76lH0yJ5o2dS2uaqiIx1WprsmFX1MzV16Ewv2go+TnoR0njN32+OqyqfAlkYVhPdmUBTNLsMtnaCVQaxWqBaQDAdpQW4qJ4gDSUhQbmM/nvGUkcqMnj4B7hwoBNRqlZXEszWMWc1oqqruYK/B/D7JFy1L3SnZW0r5/sI8kQ50TV9xEycRmKRUH277/IxJZjWVNPC/zz6q7typpP8kPy1SR94M8m9y28OVjgkB0FGhaAFSXegxHCuqIDon2jmzwjF9aq2a5vjFP9EEn/3zl53MTbDvbfqURhmYw2pJdP5QTZQXREh246GPjLhwnWX0+LNCQ15cDiIZoIuvglePz9Tib9xZEl/NADb6TTGSeHO4bC8mE469u7J1mjfMNyjpKcA5583nE2xKFwRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(39860400002)(136003)(366004)(346002)(451199021)(8936002)(66946007)(66476007)(41300700001)(66556008)(316002)(2906002)(54906003)(478600001)(31686004)(2616005)(4326008)(186003)(8676002)(6916009)(5660300002)(6512007)(6506007)(26005)(53546011)(83380400001)(66899021)(86362001)(31696002)(6486002)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blJqNjQ3b1RsZUJJR0dONnRZQ2MrMUdvVGlSK05ud2RKOEJuQm1mdDhMUS94?= =?utf-8?B?T3ZHWjNIMlJHWi80akJiN1BQZjhVVHlQUjYxWVRDS1creXRIQXVLNzUxVjht?= =?utf-8?B?VU16Z0Y2RlFoUUNyWjMydUJPUTFzQ2ZxcDljMkhBdk5jYzdjdTdxM1hkVkJ2?= =?utf-8?B?a0RoWnNsVW11dU9jL0xaTHladVRnZDFMT2ZoN3BydHVOMi9SNjdSL0NSNndk?= =?utf-8?B?Nk4wVUxHdFpyNkc3ckUrREhEMENIY1F5ZFZPelRGYzdGOEM4eXZjTUh2ZFJl?= =?utf-8?B?YW5SQm9jbDgrMURTK0I1YVRoZU43elQxUXZ3a3ZvZ2hOSHlacU5QL1lqVE80?= =?utf-8?B?bmE4SmhMNXpDeDVFZzdUajdDOUxVYXFjTEEyRDREVCtuZFUrNzNDOXFNZktu?= =?utf-8?B?M2N2dUV6bWxlRFRGQ080am1pc3RvZTZOdDlMQ2lQdmdiUVkxb21ZMlMxM2dI?= =?utf-8?B?bjMvY0dTTk5mdjIyTGREd2d0cmVxSHZwQ2xwNm1yYnNRVXNqSVZUQXZBUHFL?= =?utf-8?B?T1ZBK0t1eVJzTGg0WDB4WWZXZHhpZS9CbC9hRllwZ2Q0N0psYjVPUzM4eEpQ?= =?utf-8?B?a0lHTk1FaEdzWVpJK3cwZndQSDZ5RkRUTGlSYXJySEdGb29DRktvQWk4VGV1?= =?utf-8?B?dEdKNUd2NHFWNVhodktKWHArSURrd0dzUXZMN2taSmtyY1JkZktPRmRvZkgv?= =?utf-8?B?c211eFpKeDI4cWtLOHRqMi9yRnlsQ1RjRVBZU05kb3pPZ254K0dDRWNwT1lq?= =?utf-8?B?cTR5TTRuMFZlVkwyWkpFSWVJcWlwd1N1eXhmNTc1TEJ5ODJ5MEpYdXl2L1BX?= =?utf-8?B?Y1E2RnVqUWRzZGFKVENSMUFkb3cwRWl2R3dmMUl2bWtrSnBKTWROV0FNbklo?= =?utf-8?B?K09TaWFlN2tpZG1MMFc1VTVINTJxNTZNY3I5ZXo3alZhbWc1QmNvOVh3aVNo?= =?utf-8?B?MXhzeTBkcXZxTVBJYlRwTmp3NVI5VDNSWnNTdWQvbWpkZGhBWlE1MXNJVnQx?= =?utf-8?B?SWJjaUJOMUEyQ0lrZWhPMS9VRWZiSXVweGpFSUFOUmVLSDNmclZ5NHpxRW03?= =?utf-8?B?QnNMOVRFYmJkZ2Z6Y212dFBtNTVyU3VRTEhhSmJXaDEzQWtxVStReE1NQWgr?= =?utf-8?B?ZldickJoTmFWeTRIaGdzSU1xSkVGaTdJQkE2bnFrcEd0VTFNZ053bVo4eUVD?= =?utf-8?B?VTZJTUhMNDJ5dGxsWWM1SHhvTlhhV05tMDlCTWFPaDBQa21MU2tLclZyZlU5?= =?utf-8?B?dVZ0WVRmMXNaWjB5TS93ZjlzYXRmenZIcFFRanozVkdNaURYWUFFZTBscDJa?= =?utf-8?B?VThqZVVQQjBBdFBYVnZLclNmUzREejVSRTJZRG9WaEhSQ203YlhzYSt3Ri9U?= =?utf-8?B?cWNDVHNtN0s0YTgwR3RzNGpiSFl4ZFZqdnN1MS81djR6Zks4dXhEQXYwdWdK?= =?utf-8?B?NVlIZGRwRDl5YlRZdk9nOXFYVFRmOUh4UlI5NXJ1Rkp5YmRzTEoxYmZaT2c5?= =?utf-8?B?NStkSit1VGNFUzJBS2hycHQzSmtNRXBFbVhCNGNnNWpkYXBXT2FERDlnU3Js?= =?utf-8?B?c0k2cEZYOUZwZmdyYVUxWldaVFFiaUpSREkwVHo0U2c3UG01VHU3N1prdlNj?= =?utf-8?B?d1RJa2hnUUppcVNIVkVuN0piazU2MUsvNllNZ3hlY0pqZkd2Uzk2RVV6ckw2?= =?utf-8?B?NlRWbGVzUExwZmRZYkZMQmxza0dvbWc0UncvUEJqaUpjT0lSczcvV1F5aWNu?= =?utf-8?B?eUJIb0tTL0pUS3VhRWlUeTllc2pVTFlxdGtJVGJVVlJRaFFnWUliemg5a2pM?= =?utf-8?B?WjdUSzBHOVJ6ZEE3RzZpWldaNUlrU3VwNHE2b2JIOTFicmZWT0NwUHFEWXZM?= =?utf-8?B?amx1Qk5DdjhNa1BPUEF2Q3NNV09taXExbWZicVZpdS9TV0FVellTUkpsSGV4?= =?utf-8?B?QWlSRkZqd1NpajNQQThDWTcybnhOUWppN2hud1NmdW96QmpKTnZTYXV2RlR3?= =?utf-8?B?eTNHRVcyVjI2NWN3ZzhEY3VWOXlwRDZ2K3Y4YSszUFM5SjVuT2grbm80MStG?= =?utf-8?B?UjU5cHRZMS9mWnJJZENBRGw5TmY5WFk0N2M2VEY3bDVhRnp3Q3pPOEUxRmd4?= =?utf-8?Q?1i4sGD69ySDkomvUyND4i2xxG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc0cea9c-568f-42cd-2b5f-08db35b1f7c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 08:44:28.7200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xTsq/miP+jpQM4NEiJaIaO+6aNs6nHB0kONzJHc+Nnqk69shIcmpoHTNGLBtpv1uwGN1lwtg1BvT+NUXh2K4Wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8106 On 04.04.2023 22:40, Andrew Cooper wrote: > On 04/04/2023 3:21 pm, Jan Beulich wrote: >> On 04.04.2023 15:08, Andrew Cooper wrote: >>> On 15/02/2023 2:54 pm, Jan Beulich wrote: >>>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still >>>> applies to guests also when run on a 64-bit hypervisor: >>> Is this really true?  Even when looking at Xen 4.2, 32bit guests are >>> required to pass a full 4k page, not a 32b quad. >> The full-page vs 32b-quad aspect is orthogonal. This VM-assist is solely >> about where that data structure is, not what size it is. >> >>> Which makes complete sense.  It was a hard requirement of 32bit non-PAE >>> guests, so it was a natural restriction to maintain into 32bit PAE guests. >>> >>> This is *only* a 32-on-64 issue, because this is the only case a 32bit >>> guest could in principle use an L3 placed above the 4G boundary. >> Not exactly. 32-bit Xen maintained a 4-entry "shadow" array below 4G >> that it would copy (massage) the guest entries into upon CR3 reload >> (just look for struct pae_l3_cache in the old sources). So above-4G >> page table base was possible there as well. > > Oh eww, so while Xen never gained an optimisation to permit only a 32b > quad in place of a full 4k L3 table, it did support having the full > tables higher. > > (This code is especially hard to follow with #ifdefary in the common > mm.c when there are perfectly good x86_{32,64}/mm.c's to use for > differing function implementations...) Except that the #ifdef-ary was wrong, and should have been suitable if() instead. Those having been #ifdef was why the respective code got removed in the course of purging 32-bit Xen logic. >>>> --- a/xen/arch/x86/mm.c >>>> +++ b/xen/arch/x86/mm.c >>>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ >>>> unsigned int partial_flags = page->partial_flags; >>>> l3_pgentry_t l3e = l3e_empty(); >>>> >>>> + /* >>>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not >>>> + * understand the weird 'extended cr3' format for dealing with high-order >>>> + * address bits. We cut some slack for control tools (before vcpu0 is >>>> + * initialised). >>>> + */ >>>> + if ( is_pv_32bit_domain(d) && >>>> + unlikely(!VM_ASSIST(d, pae_extended_cr3)) && >>>> + mfn_x(l3mfn) >= 0x100000 && >>>> + d->vcpu[0] && d->vcpu[0]->is_initialised ) >>>> + { >>>> + gdprintk(XENLOG_WARNING, >>>> + "PAE pgd must be below 4GB (%#lx >= 0x100000)", >>>> + mfn_x(l3mfn)); >>>> + return -ERANGE; >>>> + } >>> Having dug through source history, I see this is largely the form that >>> it used to be. >>> >>> But I'm unconvinced by the "cut control tools some slack".  I'm quite >>> tired of different bits of Xen taking on unnecessary complexity because >>> people are unwilling to fix the problem at the correct layer. >> But anything tools do before having created the first vCPU would not >> have had any means to engage the VM-assist. I.e. ... >> >>> A toolstack which has non-pae_extended_cr3 guest on its hand will know >>> this before any pagetables get allocated. >> ... this knowledge buys it nothing: It would need to move the table >> to below 4G irrespective of knowing that the guest can deal with >> bigger addresses, just to get past this check. > > This just goes from bad to worse.  It is mad that the VMASSIST flags > can't be set ahead of a vcpu initialise hypercall. > > But. > > The code in xg_dom_x86.c unconditionally moves the L3 below the 4G > boundary, so the thing actually pinned as an L3 will always pass the check. Where do you see this being dome unconditionally? I only see this inside a check of dom->parms->pae being XEN_PAE_YES. > Which is just as well because it too blindly applies the extended-cr3 > transform momentarily after conditionally setting > VMASST_TYPE_pae_extended_cr3... Doing this "blindly" is (kind of) fine, isn't it? The transformation is an identity one when extended-CR3 isn't in use. > So a 32bit PV guests will pass the check irrespective of their > pae_extended_cr3 setting. As per above - I question this: dom->parms->pae isn't a simple boolean (see enum xen_pae_type in libelf.h, and as can also be seen from the condition around the enabling of the VM assist). >>> For this check specifically, I'd suggest prohibiting non-32p guests from >>> setting pae_extended_cr3 in the first place (I see no limit currently), >>> and then simplifying the check to just >>> >>> if ( unlikely(!VM_ASSIST(d, pae_extended_cr3)) && >>>      mfn_x(l3mfn) >= PFN_DOWN(GB(4)) ) >> Dropping the is_pv_32bit_domain() check isn't possible because we can't, >> all of the sudden, fail 64-bit guests' requests to enable this VM- >> assist (no matter that we know that it is of no use to them). > > I'm not so sure about this.  This VMASSIST cannot credibly be set at > runtime, Why not? A kernel may statically say XEN_PAE_YES, resulting in its initial L3 to be relocated to below 4G, and then - before any further page table creation - enable the assist. > and making a restriction here is not usefully different from > prior patches of yours that relax checks in Xen that still break on > older builds. How's this not "usefully different"? I replace potentially silent misbehavior by the failing of a hypercall (which ought to be noticed) plus a (debug build only) log message. > But as I know you're going to argue with that position, I'll at least > note that ignoring a 64bit guest's request to set that bit would be less > bad than the current behaviour. We already ignore this bit (as in: it has no effect). Yet just like we can't fail the request all of the sudden, we also can't zap the bit from the supplied mask, as kernels may legitimately check that what they read is what they set. (That said - I'm unaware of such checking anywhere.) Jan >> Dropping >> the control-tools part of the condition is at least problematic as well, >> as per above. Albeit I'll admit I didn't check whether nowadays vCPU 0 >> is initialized before page tables are built. But I think it's more >> sensible the other way around: CR3 setting (in the hypervisor) is less >> involved when the page was already validated as an L3 one. > > All of this is before the guest starts running, so it doesn't matter. > > The most efficient way (from Xen's point of view) is to pin the L1s, > then L2s, then L3s and then set vCR3, because this is the only order > where we don't have to do do recursive type acquisition. > > But, the most efficient way for the toolstack to do this is the opposite > way around, because making Xen do recursive type acquisition is faster > than other ways, and turns all subsequent hypercalls into almost no-ops. > > I doubt there is a relevant difference between these two approaches. > > > And it doesn't matter either.  The check won't ever trip from domain > creation (see above), nor from migration (we set vcpu context before > pinning the pagetables, and a non pae_extended_cr3 will have exploded on > the source side). > > So there really are no toolstack codepaths that can trip the check.  > Future improvements that might trip the check can come with a less > broken hypercall as a prerequisite. > > ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:51:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:51:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518332.804748 (Exim 4.92) (envelope-from ) id 1pjyrV-0002Sc-8q; Wed, 05 Apr 2023 08:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518332.804748; Wed, 05 Apr 2023 08:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyrV-0002SV-42; Wed, 05 Apr 2023 08:51:25 +0000 Received: by outflank-mailman (input) for mailman id 518332; Wed, 05 Apr 2023 08:51:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyrU-0002SN-5a for xen-devel@lists.xen.org; Wed, 05 Apr 2023 08:51:24 +0000 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [2607:f8b0:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08f1d51e-d38f-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:51:21 +0200 (CEST) Received: by mail-pl1-x631.google.com with SMTP id z19so33810165plo.2 for ; Wed, 05 Apr 2023 01:51:21 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id 134-20020a63028c000000b0051303d3e3c5sm9018640pgc.42.2023.04.05.01.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 01:51:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08f1d51e-d38f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680684679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uTmWh7bgIaShLbjOtPbFopk4h+aCHK0BPMfF7xCsMCU=; b=UFReNiOFbZlGWg/34mbH/fROY4+46+yziPEOG/bjniycIzr4dqS8890aZ0MBq0Jor6 WMIbpW9Z5UvgEEaeKa7nIMnk1id3yjjjk2WipvqX8Asc/XhFswF37HWylXnC/ytFSnWU 1q9TB0mpl2DiYzIfnkvei/4SZsW4cN6AZBPxzcC0QN3UAxMLYF0nJ+UaDGxuaGKpVmEH sumYbxnKAKn2PLt65MN8+REC9QiX/QRbQWaQblDIUJHThY5+f1dzYWwSVMZl6gVtg64n sqYOAfw4EzJ9OsPMqfpV6O6dJ03pf6Y4GofSklzYHtrmjDLp8RwpELoNr/+A41W0WOW0 RxYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680684679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uTmWh7bgIaShLbjOtPbFopk4h+aCHK0BPMfF7xCsMCU=; b=zbUQ7Onk+qNIV2LasL+0z3VVDuQYZMisCEYUs9ti4diYdqITLzq2M43a+e7QactgD5 Liaje9rKAeWZNbp91xUzliio8U8E+IAgcT8m9oFTFlMiuKQh/8/NJFUZCCyp9AhAZ2wy gBgGpaobWDPv2PhlPzsmEKL2RmSilVVlf29sHkWTF7lr16FdD73nj/aS0qDjpXgeT7Mq vvCf8nCLzet5yKLqQE++1sdelJDVWOuTgWJn5koS6mUp+xa001DKfa5l10qhejNOpbU2 Z3l3bzScT53Oo9w7WzHQuCJJGgFATWpWPl7Pt9u2miXGK9+gYQgYNP+8fDprhBGekt94 pMAw== X-Gm-Message-State: AAQBX9c9qVdfoQ6LedI+DjmSYMEB4u9MvWb7GVNm3QksYb9gRs9OAYyD 8FpSAvdHCCK08HSaLaW9bPN9+A== X-Google-Smtp-Source: AKy350YTW5NK2cxTa4fIkmHliiCG4XUoXoaRsrI6R75HvHS3tlR9YNZmWTYfStMuoue/vx4QD12w/w== X-Received: by 2002:a05:6a20:38a5:b0:d9:55b0:c0e8 with SMTP id n37-20020a056a2038a500b000d955b0c0e8mr4234722pzf.39.1680684679529; Wed, 05 Apr 2023 01:51:19 -0700 (PDT) Date: Wed, 5 Apr 2023 14:21:16 +0530 From: Viresh Kumar To: Oleksandr Tyshchenko Cc: Vincent Guittot , Juergen Gross , stratos-dev@op-lists.linaro.org, xen-devel@lists.xen.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Mathieu Poirier , Erik Schilling , Julien Grall , Anthony PERARD Subject: Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id Message-ID: <20230405085115.dayqa6mrkac372sb@vireshk-i7> References: <37fa3d37-5ee7-863c-48cd-1ce313c8e296@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37fa3d37-5ee7-863c-48cd-1ce313c8e296@gmail.com> On 05-04-23, 11:36, Oleksandr Tyshchenko wrote: > Also a NIT, is this example "like "virtio,device26" for file system device" > precise? No :( I will send the patch again later, this is how it looks now. I have also updated the documentation to contain the hexadecimal format for N. Author: Viresh Kumar Date: Wed Apr 5 05:36:19 2023 +0530 docs: Allow generic virtio device types to contain device-id For generic virtio devices, where we don't need to add compatible or other special DT properties, the type field is set to "virtio,device". But this misses the case where the user sets the type with a valid virtio device id as well, like "virtio,device1a" for file system device. The complete list of virtio device ids is mentioned here: https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-2160005 Update documentation to support that as well. Fixes: dd54ea500be8 ("docs: add documentation for generic virtio devices") Signed-off-by: Viresh Kumar Reviewed-by: Oleksandr Tyshchenko --- docs/man/xl.cfg.5.pod.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 10f37990be57..938aea22c798 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1608,8 +1608,10 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is L -For generic virtio devices, where we don't need to set special or compatible -properties in the Device Tree, the type field must be set to "virtio,device". +For other generic virtio devices, where we don't need to set special or +compatible properties in the Device Tree, the type field must be set to +"virtio,device" or "virtio,device", where "N" is the virtio device id in +hexadecimal format. =item B -- viresh From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:56:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:56:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518337.804758 (Exim 4.92) (envelope-from ) id 1pjyw6-0003FR-Sy; Wed, 05 Apr 2023 08:56:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518337.804758; Wed, 05 Apr 2023 08:56:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyw6-0003FK-QB; Wed, 05 Apr 2023 08:56:10 +0000 Received: by outflank-mailman (input) for mailman id 518337; Wed, 05 Apr 2023 08:56:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyw4-0003FA-Ro for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:56:08 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20618.outbound.protection.outlook.com [2a01:111:f400:fe12::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3887f47-d38f-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:56:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8806.eurprd04.prod.outlook.com (2603:10a6:10:2e1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 08:56:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 08:56:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3887f47-d38f-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XBPb2bwqdMtAV18nOX5hsDz40W/yqZhYRFJnVJL6SKT9F+JmEVz0Rq1kJjIRrVBle6Bc+yxeOesadtg7HhUnVWlI9EJ6PCoX16Es/rkLLHSD3uU7vYN5z4xhp1Vf7N7vseHU73JOLcG8zwSRqahb3fz09aCasGndx/2FAz9o1YAOnynPw04h+5orRf9qVzP/dVgJJv2aQPw263DgPPhWooA8GWEUdQBZxrypgZQ5mX0Ccf5j3nBh04S1807O3ZTrp/JVWUKsROo/AHi965NmciNJXWKw0daJX1I6QB1pBBvcBjdwGsJtl+0eyau4UWq15SUdgPI9YjU1ulfdatuzLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+mVTO62r6MdNDfQvzJjVKCOtuW5R5PdZ4og7pljUhPc=; b=nePbIZtD0nvR9bshlTd/7uTXv3D+YWMQA2oSa++ZYDq5m/RC/qWsAF7Ov0RvYiodAVMIH3w+nriT/1BeB2mAdKXt3C2DrvKK+fiyfE7RC+m5RTcpuBt6baUT7xSxL+veujQFfC7G+DWNW4Ldqr3WgsW30ka2dd7ly1/c3Zu96B08Ng+RfnehbcXgMZadJyTH69Jf7+yEs0ZewD4O5Z590piZC6oJKiZhNtgl1zz3sbUsLp0lgWQvj3y8GuG3AKunNGp+t4iHqhBdfHT9XzUeqC4xOUJfybeoyVD27Aa/PN8gB9umj6FtbYg4nWTqQkyxNuVJZJsJaKBAyxt+dbEAOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mVTO62r6MdNDfQvzJjVKCOtuW5R5PdZ4og7pljUhPc=; b=dxG/77rFnJRGMEn7p7hepF5W4d4JCa/1slGtyQ+FWtSUu2tREcFfVGvr7suG+PJKa16M7Je+z055w1mH4Hh9z1OIjwT1LHxjSwpMUwGM7HNST9m2CR0Ez6XGaEjkWM5fI2nb11W+7+lBokuKE//7V5NdKQN6UI+HUoQ3MBiJ+uwJ2BiONUEh8cjFnrcTgLFwCwE1yA2MfJmWbjmeiKydHxSAIuEluQTWjH2FjP+xVeBZo9Nm/DdI0tp2Ddfh1YrrWNhdQPzK3FaAoM28Ea5oT2U3pChUxeqKGxbBkv8QaSz77R5gsgFo9t2UVwJFoal0hKh0MpeneulU3wIgwCExYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 5 Apr 2023 10:56:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 2/3] x86/platform: introduce XENPF_get_ucode_revision Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230404160655.2354-1-sergey.dyasli@citrix.com> <20230404160655.2354-3-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: <20230404160655.2354-3-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8806:EE_ X-MS-Office365-Filtering-Correlation-Id: 080548f0-1ca7-4cab-11e6-08db35b39690 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Fw1PSZqg8TBwr9bXEIHVhFo0nkeout8a0NpsOG7Dgt1gCqTi2oM+/CgudF5+sXmxKVkFrT97fSXbOkFzvhuyLThXs116HJ33jakUTg5ASfga5qkGh4BHGvgu/nz3Vj6TKZUBbIFMXSBI7XIQ9THsA9jnEoTape29XVWnOnKsYsLjUMyzE2hQZ0ZiuWScxeIPdGi171TXOPTfElazDbo8cNKuUYVap8FS4KM5G0GCR2EbkCmn2H4+LfvEWhVFYDUZq2tHrCIHe+LCEl2iaRGbGZ8WB2LVQlDcs4Zs0Hwl13VUfEXh12ZkXVjTxml8QqjiNp5bi8025uckVqUq2zUURA5Zz9Lm9cSVFiB32n9t5a3eL9fnQ7Hca0Wp8V//QmCtNn0waq99+FV0uxWQybMO9c7xMJSnCXIMvabUv+rwHcfQcViwgKAeB5RVtuDvXt7DF+a8cnZLMLSkPNg+1Iy4ugxQITyfiGlMLyOOWj6PK1IWw9U13DNvIYJH5Wb+RZRswBtfUdcdNWthXisdr1lXA/eiLUJaWkWcplOVZ08ue31QPKWWp1Kqc0NJdpqUNpYbSLutrJHwx6MT/G05Rw2RnSHKLPJWPVanR6aX6aZl1IkG30wuiYGcw9bYug80Wy3nB2HbrTcOogip7iQ1tBuIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199021)(66946007)(478600001)(316002)(54906003)(8676002)(5660300002)(8936002)(36756003)(4326008)(31696002)(2906002)(6916009)(86362001)(38100700002)(41300700001)(6512007)(53546011)(6506007)(26005)(66556008)(6486002)(2616005)(83380400001)(31686004)(186003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkJVUksxRVVFVW8zbUp3VisyeFBCSVlhcFJzRlh6MHhxK004dnFESHkza0dn?= =?utf-8?B?dDhtS2pTblNvUXpEakVoZ2xQYnpibXZDUDJqZ2tSUWdPNkhxTEFHeTFqOU82?= =?utf-8?B?eThxS010eTV1R2V6VW1IM09rV055UGlmZGVkMXdpYncyc3dXNDB5M09QYkQy?= =?utf-8?B?dkFSRTVsZ1REWlI1ZHN4ajBpT0lDRGdKZTBNNDNUVW1XQ1U4UlZSWUJuZVhy?= =?utf-8?B?clR3aUJtZGZQYmF5SFE3a0ZwekRIKzFPYUNmWGRpdFMzZWFvSTBPbmZ6Rmkv?= =?utf-8?B?MnIxMVhYSVZSSU44aU5iZStPcC9obGQrMVlYVkk5bkRTR1d5bVRPMy9GMnBV?= =?utf-8?B?OEhDdmQ2QjhtZVlyYWs3UzhrWGU5bGhKV0paMyt1RzY4YktNNnArenVqNUZP?= =?utf-8?B?WWphVEZPay8wMWtsdHAvZHFjb2lVbTlkTjg3VzR3VHBkWndHZFZCcnZoem1K?= =?utf-8?B?ZS90NTFCMW1maVA5UXZFdExCNmJ1R3dnN0dxd2h3Sm9kZERPclRqYjdqTlVk?= =?utf-8?B?cTkwVjNhM3NxUzJQaDhYaTJsRisvY2FZVlR5TFhQSEFCRHZ4VkNLRUxGZzhY?= =?utf-8?B?YXZNUFAwYkU0aVluVEpqSG9kU2xPd0VWYjF4Z05EWXBqNnZraGZHb2tkVHpJ?= =?utf-8?B?V0lwUWF3MkVjTFdBRVpvRHdqMUNVT0NJT0VYeU1xeGY1ZnNBSWZ4THNpak5G?= =?utf-8?B?VFJWeXBWUDd0ay8yeHZiaVlCR2p3MmNSeVZrYmJhVzQzOWZMK1p2Wll2TXNX?= =?utf-8?B?SVI3RzRRZmhuWXdsWHhoVGxwcFk5T0RrL25BSlBrTi94eUhiL3Zpa0pZT2p5?= =?utf-8?B?SmNvaVZOZnBOS2VhUndYZjhWZDZmM1ovRExUZ2dBUmp4V1YrdWJ3aE9mSlEv?= =?utf-8?B?a1V3dGx6OFpuUGNXeWlkalhnVlgzcnBLSFdnZDdyM3FkS0VmQ2xkZWZpWWVZ?= =?utf-8?B?akVPdHl5S29KMVVBbnlpYjF3VWtqRFBtdUUxK3lmTStTMlpOdEVOOGwyT2Jl?= =?utf-8?B?amxuak9Od2Q3VndDMDVURVI5VlFPbDNia3daSlZqcnNTTW5POGFSTDZ2VXAw?= =?utf-8?B?MUhqK2xjWXpKUVB0K2lQTDY3SVlWVnBWbGZ1K0lONU16K29rWU5XRG1CUDhB?= =?utf-8?B?bFNRSGhZQVUxT1hiTWlwODJsdlpPVUFpTjU0TFJtYm9temJpSW1HNldOd1NQ?= =?utf-8?B?citqVjUzYUEyRThLR2JKdE1rYnBONGxGcU05R0ZsOGY0MEptODVROVRvOU5F?= =?utf-8?B?YzZyaEQwZzd2dDJkaXNJdFN4MVhleUhvSjB4MEpkak9LK1Z4dE9aMjlGRk1G?= =?utf-8?B?OTdXZW9ENyt3S1VVVTM2NmxYS3huMzBXRjNMVitBbk81QzdvREpjT1NYaktj?= =?utf-8?B?a3BYNWJVMzJTWEZja05FZjlSTVhnaGZoc2VnQlBwaDgxUzEwZkZ4OS94WDZS?= =?utf-8?B?YnQ2QWxjL3ZIU0ZsUy9kZ3U3MkpXZHVHenRvalUrVFVreFhISU41SU4vZnNt?= =?utf-8?B?Uy9wS2JFUXhzU2F5bEx5S05jTEtxNU1lbGdXaFIxdVQ4TkxKWFhtUnRsdFFR?= =?utf-8?B?YU40U2cvMy9qYXpoN0dwNHJqa3diNlQrY20yTzNZelRGN0MzeDV1NDlGT0d0?= =?utf-8?B?TkJ6ZjdRWmEzeHBNREszR3g5NFNvOXBubDBRVHpKYTZQVWpZc3FFUVRtZVJ3?= =?utf-8?B?ZmlrUS9NRjRxSkw0OXpOZzVkUDdJTFZLVlVhTFE5RUtaWklwM2k3ZkF5TVVh?= =?utf-8?B?b2ovMFhkNmpLWkRyS09hVjVmd0dEMEFhNTh0Q3d1YVN2RG01V2RRenBROVJD?= =?utf-8?B?VnRiNHhSY21IcFQ1YjhrdWY1UTRiL09xNE5HNzhpSGZCSFpMNFlVa0JUVzVI?= =?utf-8?B?UWwyZWxURVQvTmVLeGFKazM2N1VGNnAxa0NzOHBzZHMwUmQzMlowVm5uS0xE?= =?utf-8?B?dEVqNEJSbmtEbmp1by9lbTFKOTRZUUZPSm1tMFplak1aa28rUUhkQkljRWdU?= =?utf-8?B?NjFFWXpuU0xzS0Z4bGVmOGxubHZpUXY3c0FxVllUN0FISHJvL2NrenNXbmth?= =?utf-8?B?OVU2TGdDVUFTSlJFb2piL1k5czUyQXF4clB1WmNNZFdQNENGOWFoeSs5RXJX?= =?utf-8?Q?5VgusHQ4lG0EVzjzxvHS002hn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 080548f0-1ca7-4cab-11e6-08db35b39690 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 08:56:04.6427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k6xC87La6JoQWdoSck+NccnVmTZcm5+/4MSO7T/NTnAeTwMMVmM5ef5ks2KH4OWEXC9TeMKhcJhV8pCIrTXNUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8806 On 04.04.2023 18:06, Sergey Dyasli wrote: > Currently it's impossible to get CPU's microcode revision from Xen after > late loading without looking into Xen logs which is not always convenient. > > Add a new platform op in order to get the required data from Xen and > provide a wrapper for libxenctrl. > > Signed-off-by: Sergey Dyasli Reviewed-by: Jan Beulich with two remarks: > --- a/tools/libs/ctrl/xc_misc.c > +++ b/tools/libs/ctrl/xc_misc.c > @@ -243,6 +243,24 @@ int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver) > return 0; > } > > +int xc_get_ucode_revision(xc_interface *xch, > + struct xenpf_ucode_revision *ucode_rev) > +{ > + int ret; > + struct xen_platform_op op = { > + .cmd = XENPF_get_ucode_revision, > + .u.ucode_revision.cpu = ucode_rev->cpu, > + }; > + > + ret = do_platform_op(xch, &op); > + if ( ret != 0 ) > + return ret; Is there anything wrong with omitting this if() and ... > + *ucode_rev = op.u.ucode_revision; > + > + return 0; ... using "return ret" here? > --- a/xen/arch/x86/platform_hypercall.c > +++ b/xen/arch/x86/platform_hypercall.c > @@ -640,6 +640,35 @@ ret_t do_platform_op( > } > break; > > + case XENPF_get_ucode_revision: > + { > + struct xenpf_ucode_revision *rev = &op->u.ucode_revision; > + > + if ( !get_cpu_maps() ) > + { > + ret = -EBUSY; > + break; > + } > + > + /* TODO: make it possible to know ucode revisions for parked CPUs */ > + if ( (rev->cpu >= nr_cpu_ids) || !cpu_online(rev->cpu) ) > + ret = -ENOENT; While the cpu_online() check needs to be done under lock, it's kind of misleading for the caller to tell it to try again later when it has passed an out-of-range CPU number. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 08:59:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 08:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518341.804767 (Exim 4.92) (envelope-from ) id 1pjyzf-0003vY-Cq; Wed, 05 Apr 2023 08:59:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518341.804767; Wed, 05 Apr 2023 08:59:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyzf-0003vR-A9; Wed, 05 Apr 2023 08:59:51 +0000 Received: by outflank-mailman (input) for mailman id 518341; Wed, 05 Apr 2023 08:59:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjyzd-0003vH-55 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 08:59:49 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34fad4a4-d390-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 10:59:45 +0200 (CEST) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 04:59:39 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5837.namprd03.prod.outlook.com (2603:10b6:a03:2df::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 08:59:37 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Wed, 5 Apr 2023 08:59:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34fad4a4-d390-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680685185; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=YpNTfqkBcnMiVI9kFXp4pH2yoyKhgC8BFDB1sYVZMWk=; b=YR2ntzd49fvj+kj7f1iYrAottPrpr3OwVO9sj/8i5B6VR4TFVzDYFwHg hlPjiHvUHToh0osF/9I4p+EWKdY04DggGqMfrnh1zbi7AlYVnu32uHLz3 PJG6Z79FqemAwk2V/j91B0x8SGt3nqlMuKc652jrRzJ78W/waeimZ+SNP A=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 103749612 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1gSm+61J+irmLNdJ4PbD5fVwkn2cJEfYwER7XKvMYLTBsI5bp2YFx jQYW2GPbKqJNmb1e4t/aITgp0pQscPTyoBgHlZqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfPCJk9 dgELSAxaDuqhN/p/reFabkxmZF2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1IZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13rSQwXKlAdh6+LuQx6FDnAW0mGwpORQpElzjj8e51WX5YocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICMBEw0M5oC5pJlp102RCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb/D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:X8veiKwGZp78MOn7J6xfKrPxLOgkLtp133Aq2lEZdPULSK2lfp GV8sjziyWatN9IYgBdpTiBUJPwJU80hqQFnrX5XI3SEDUO3VHCEGgM1/qb/9SNIVydygcZ79 YcT0EcMqy+MbEZt7eA3ODQKb9JrLn3k5xAx92utUuFJjsaDJ2Imj0JczpzZXcGIjWua6BJca Z04PAsygaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA+7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1cwKoVKuZEIMvJ0vFhLA BcNrCb2B+QSyLCU5nthBgq/DVrZAVqIv7JeDlYhiXf6UkpoJkw9Tpo+CVYpAZByHt1ceg22w zJX54Y5I1mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94KIfzY9Frd1CQqZ4hKcaid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbfBGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7YLHCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8W7ssrPWCzvCFL5LYdznFrIoufow36V3w30otWg= X-IronPort-AV: E=Sophos;i="5.98,319,1673931600"; d="scan'208";a="103749612" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UC4GSn2QRqdmiVeshQZMsQwrtI6/t7jzzGdZkF+qJc2DXze1FrrpUf2h4LY0SqwczGgwwFymAsdbgQ+AT+bmJHThNIyWlkq+d0ioy6Z6K2mdZCt1VufEt9bCg/CzwGPwB27EBAe49WmOf2H5Yk0bmkjY72Qw0uIHS6vMI6DYZ+lREd0EM6nphzXbfatY+RkfCGL5BIKQupOSuNyWqSRU+6m2uuEdGB4YmbjnKvNmbe2vO0j306/Dql+3NP9NtWxqp/HwAXBjdc97Pe2aBKmUFJltOoWYuA0dBB2KFCpv27ulEc6KNK3SgsxkOEALspmqn3JUb7O1C3rZQovyxmuv8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RaRUamhn11nMvnYnVK64rs9/zrMUREZ4KwHbmPGqQfI=; b=FsmQGRcFmP/48s0/6JD8yxcW6oLrWdb54HXptGKcCpJNUQhenGVU7iNqeu8nzgoRdXpueOa8Gw7jro8OWCD7YuinsEXA1c27tS3TK+jK2GdGwxoPAoXcNrNoYkCjyIQUmsWfK0avhdSlBi12celpDv9flokdQ85/v4mgxuvJpElcblKbvIgIosfhx0fSot++y7h0Uba7DyCF5vNC5RfAo0witg1MoNK0vHSI2wSPADjKZdB7sFP+Lb5etn87L2nBT8X+Fde/xfTi3mSZ9pn5OLVq3asIcnwDNk1P8aN6UU9bsWFr4iL9MkWa8/qt/QHzXAJNuddCg8OwzoW8+Eo8ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RaRUamhn11nMvnYnVK64rs9/zrMUREZ4KwHbmPGqQfI=; b=N2QYFLEF0MLHZwrQjW0syKr7ko/YMlXwexRW8io3r/9c2717vkxE9Q3laqqXTNWU77CjXrSORnoLRzKTsfgwBNjZSQvwNWz0FAtCS+I7zri9hmkLgcwy9JfZ291iwNcTZAZUbtAHFf+CIe44ZASv3JvMNRPQ5rqwb3QEfGLY5Ag= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 5 Apr 2023 10:59:30 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Message-ID: References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> <5cda250b-57b4-2833-99d3-84ae8ca32059@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5cda250b-57b4-2833-99d3-84ae8ca32059@suse.com> X-ClientProxiedBy: LO4P265CA0097.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bc::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5837:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bca9d47-2567-44f9-bf3d-08db35b41527 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q/n+KX3JYJoF9OOZLreIZmXVhfwGhzNIKInhhegUZj9k+w1d8dXYAF4s7k4beDWAgETq+EbdfBvSxUahHjIJahHbfqFJjOzLERA96FHxhTYY0WRvfnsd58Ev6HJKyhNPiu1ZoPp6b0wxSKy61audd5OeVLNG8/4/0YgeoHqjg1i+TMThPAiscQVWW/twC2PxZNh+fd0k3Lf0OPoxiYXuorRhTLAkdU9mfGp7Hn5Zcvqt1ojfQh7a9JV5UxttxhkzCGiZFGyPQO0hCXcCL5//siOz5eXHR5ZF0E4ovCJCf6lGHxIHL9GGE/u/kWV2RZDzYSQfUkrsAIclyzaz/jwJlRJ0ayYJr4lnojfj5MXogAOvnlfcLE3apjXkyEZolwGrIvZXV7c0XVTRfy9DDFOGpXRnHAQdQB5orXnfSnoUvgEJSjprIVzPo+rXCYyimhWf6C9By5GwxVcIsUfw21S56REI+xfQPbBShmyaYeXFhDSwB75wHDEFV0SOeAA6zTCsl2EXqmgxKxigIw65dAwbqBSPhlwgdMigt8vDFOVTJBZzcLm9qxF41lE0/Y9xT62E X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(451199021)(6666004)(83380400001)(66899021)(6506007)(53546011)(6512007)(26005)(9686003)(66476007)(4326008)(8676002)(86362001)(66946007)(66556008)(6916009)(38100700002)(2906002)(82960400001)(186003)(41300700001)(54906003)(478600001)(316002)(33716001)(5660300002)(8936002)(85182001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVZ6WW1LL3B3OXc1OHhjcXlGaUJSZlhNSG81NUFtR1U5MnB3dmRQNTlVa0hz?= =?utf-8?B?L2w2cVpkcnVDSlYwSmZBZTFWOFF0Mmx6STh2VjVpNzlOaE9IcjE4ZFNxM1NN?= =?utf-8?B?RUViZHNsYlcrVXdKcWJ4ajc0M2RZVWw5WVdPeWY2OElrU2N6cG1CdmRZeTlq?= =?utf-8?B?dGUwOVZOUjJOODkzNk0rVzNmcVg2VEQvTFFGUjhCMnAzZU9wTi8xY3hTTkpO?= =?utf-8?B?VnRvMjZMdHF0NUZ5TzJBT29uSXJ6aEg5S0NzdlNLOCs4LzlwbUN2TXlLSEF2?= =?utf-8?B?NWQycFFDQzJTbDNNZHpDL08yVW1JaHdJMHNYZDhQRjVUdkswOTd3SUVVSUpO?= =?utf-8?B?U21xVHZWakloUGc3eis0VVRDYzVHaWNVWFBBUDhkTG5VdWhQMUlzcFdvaWtZ?= =?utf-8?B?dVRZM0JSSndLK1ZkVFhwdXNoYjdmZ3VoSzFEanlJRjZqMnkraWIzR0xIYUxB?= =?utf-8?B?WjgwOXJGYWorQlRPdmhRcFZWTXRueVJUSy9RWFZycTFERTZQUlZMZ2RHSEpD?= =?utf-8?B?SWw5Y3NrdnQ2YjRDUE5IbVdkOWZoQ1A2YmJlaHlLVFpuNGJNdy9KUHpBU3pj?= =?utf-8?B?NmIxRTZqb3MxU2xsYnRyWGxMVnZ1K0publdPYXdQNDRadllYK1NNTVlCek1S?= =?utf-8?B?aW90M1FmY09ER2lDVzEvQSsxbDg3K013Z2lFYmpsbUlBdEZIUXRxQmtMeCt1?= =?utf-8?B?Yll6WmlSN0FRWlJkaXRGUE1WQ2txRzUwSEM3ZkpRRWdrcmdQNEhYVHk3VVJI?= =?utf-8?B?Q3FVRUcrTDVxQ0dzQVBsc0Nka0pDYnhGYVM2SkpIQkF5U2pFQmpWdStlSXBv?= =?utf-8?B?S09LaEZWUmFzMERFS2VrWUZnUlhHakdXb2dOa0VvK2N4TWlYdFR2UGgvSVRQ?= =?utf-8?B?ekloanh6d2lhWWpYa3pmenBpYkJnSCsxaXhjeWxuYSttdlpjYlNHUFdxTnhH?= =?utf-8?B?bzZNeTk3VHhMTWZjZGwvcG9kelhCSjByR01wUm5pY0R6dFFaVFhzTmE5TXJZ?= =?utf-8?B?a3Ywbk53cWVVWm9UM0ZpSUtFQ2ltVHg5Q0gwaytxRnBqWG9QMFVDemFTdzh1?= =?utf-8?B?bkdaWXZCOUtwSFdlMFdTV1RsSnQ2YzR4YW1xVlhTRUd0eG9JOGE1czNZSGJm?= =?utf-8?B?aXE2L3ZLSVpvV3VTWWdZVjc2dk5JMmF4Vm12bllwZkt1VFROczRzUTRQUUlw?= =?utf-8?B?ZUVpTUN5eGtLVlkzY3NYV3NZbktZbjBKMENFY1ZIRFEzR25sR2UvQ0J5WVh0?= =?utf-8?B?ajI3Zk96TnVsWnVnQWhEb2h1a2JXVkZmYjcrYWpBbzNKcklhdTd2dGtmSlhC?= =?utf-8?B?RmF4TlhneUc5MDZlbWdLZlNYcXZMWGplS3hPQnJ6UlNXUExIQXBXTWRBWHk1?= =?utf-8?B?OGh1NW5QcUJIRVZ6cXF0cGI2ckkvc3F2d2dmbW8ydUNYUUlUYURPRmJpUGd6?= =?utf-8?B?R3FkdXhGNFFDbmtjK0kxcndtcmRyVVdPUG5UQXBCTHU1RzlUNjV1dGVwUjdU?= =?utf-8?B?NXRNT09BQWJPVm81OGlvNkYvMlVzTmppZVVZbWlGSVg0UU9qUkgrRDQxNDZD?= =?utf-8?B?U0xEaExoaTRkSjMwdHNkbnhhRllpeWs1YTZHV09Fa3M0Zkx1WCt3UllzQjU3?= =?utf-8?B?dm10dUpiMHNYZ3EzQUlnS1BQK1dkWUxwcFVwVVY1TnMzVXo0bCtqUjU4aERv?= =?utf-8?B?aW5vUmJBUzF0QlJvUG1KbXhyZFRxb3hPdDVyVzg5c2NpaHFqbDRKdTJKd3NQ?= =?utf-8?B?WHdqUjV1eWtGZnA1ZTA4ME9RaWZjNnhIcG5jdU8ya3o5VDd2REJUK3AzSDRv?= =?utf-8?B?QlZaRG4zM3hVMFVNVWw2am1CS2N4S2V1eERaNkpQSlgxRU50d2Z6STZsL2FQ?= =?utf-8?B?c0cvMzAwRHZMNnd2c1duWU1IeGJnWFcxdTBlR1AwcEpVbjNjeHI4ZEpzWjJl?= =?utf-8?B?ZnRuSUo4alpPMlpvd3g3UE43TjM5RDhBNFFkVThmczdVM3kwNVkrZlBBTXdH?= =?utf-8?B?STdoSVM0d0lhZXZBNEVVVUp5Z3dseTJiQVlFTHcrWW5UVmdrdWYrNVVhN3RH?= =?utf-8?B?SGZGbTJUOWU0d0kyZzJGcWFmaFRwY3RoYUJYQStoYi9nWjQwY0ZtNm41ZGJM?= =?utf-8?Q?7eX//ufk+ZVX7sHymFfXvVC8F?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ci50GXTPXoH02XtwmXZtnzFQiZfNQQFN0jBFfPp0/5u9VGE6G9cA5if7LY7CaigEEPsM3ZQhc1vMteS7u9WkEGH83Ogci8c9Hgtv79mIXlFia8/gpb39jAFuyiGJCMUK2D186NuUNTtUm6XIsoIGVZaqNWM9MgZrloV9XY0ofqAkQQHwL31S24uFISzYTnJtye7VJw8DzNomYvDMKkb5465DlK8oNgsLibZ1PUfmZGjG658mlkNJ3JFM2nVGcovxUY8ladCcvA4MMcY6NlVJZOP1GcH9K8i3ssbroj0wfUk3PmolZk8z6AFuoDsF/T6yjbxj4ZFvBDhUF5DgVlgKJ/zjTxFy3HzobuTNjl2HJKU/Gtc9/7Y+JKF7uDjC4x2RtvNYYGoGufh+qEoXbHg8I3jzXdfRk4KbiFixmw3IVf+Bs46Yd6ZEw8m5MiL0HMrXh7xFIOIoHMuv9tBsZKzJXP8Xuw0s6iLVc9mWskWub8WRg3ItxICPAu/EkYnYL9bWszUrR7mYFy7WPT0A3oBp/JZTDjr49R3KEFKr6/gc2Vk1nfodTihRlIDWjxQPm64mkJjCLddLZrW6WVisxrxJJMRIsDn89IoQRFHKkYuC6dvqWoEM89vot2AnyCcM708bSOmyV4cVr/o1CU3are3+GXx50b+UCYILr1Ymov560Ss3mochgQmqoi0bKrEBk0m4MsBJmXrnY0gqotdW7bJ3g9F47FyxQuF2Datn5ojUfK5jtQtDMFawob7HYoOQdy1UqE9RULZRIzUHO8oWifWaj9y4raq0HZ0RHZDPUT2kXkwhdWKhom3WJPkPTD6Y2civ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bca9d47-2567-44f9-bf3d-08db35b41527 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 08:59:37.4591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PdDNWr2C7zqEqGOEseOrp7+yd5y4JoMOov7D3UObHPJ3IIVrMgPf4xRrnWry17hbuL+Si3xpdJPWj6MyoSZSFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5837 On Wed, Apr 05, 2023 at 10:11:30AM +0200, Jan Beulich wrote: > On 04.04.2023 18:38, Roger Pau Monné wrote: > > On Tue, Apr 04, 2023 at 05:57:11PM +0200, Roger Pau Monné wrote: > >> On Tue, Apr 04, 2023 at 04:24:16PM +0200, Jan Beulich wrote: > >>> On 04.04.2023 13:41, Roger Pau Monné wrote: > >>>> On Tue, Apr 04, 2023 at 12:31:31PM +0200, Jan Beulich wrote: > >>>>> On 04.04.2023 12:12, Roger Pau Monné wrote: > >>>>>> On Wed, Feb 15, 2023 at 03:54:11PM +0100, Jan Beulich wrote: > >>>>>>> While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still > >>>>>>> applies to guests also when run on a 64-bit hypervisor: The "extended > >>>>>>> CR3" format has to be used there as well, to fit the address in the only > >>>>>>> 32-bit wide register there. As a result it was a mistake that the check > >>>>>>> was never enabled for that case, and was then mistakenly deleted in the > >>>>>>> course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume > >>>>>>> CONFIG_PAGING_LEVELS==4"]). > >>>>>>> > >>>>>>> Similarly during Dom0 construction kernel awareness needs to be taken > >>>>>>> into account, and respective code was again mistakenly never enabled for > >>>>>>> 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by > >>>>>>> 5d1181a5ea5e ["xen: Remove x86_32 build target"]). > >>>>>>> > >>>>>>> At the same time restrict enabling of the assist for Dom0 to just the > >>>>>>> 32-bit case. Furthermore there's no need for an atomic update there. > >>>>>>> > >>>>>>> Signed-off-by: Jan Beulich > >>>>>>> --- > >>>>>>> I was uncertain whether to add a check to the CR3 guest read path, > >>>>>>> raising e.g. #GP(0) when the value read wouldn't fit but also may not > >>>>>>> be converted to "extended" format (overflow is possible there in > >>>>>>> principle because of the control tools "slack" in promote_l3_table()). > >>>>>>> > >>>>>>> In that context I was puzzled to find no check on the CR3 guest write > >>>>>>> path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any > >>>>>>> of the low reserved ones) could observe anomalous behavior rather than > >>>>>>> plain failure. > >>>>>>> > >>>>>>> As to a Fixes: tag - it's pretty unclear which of the many original > >>>>>>> 32-on-64 changes to blame. I don't think the two cited commits should > >>>>>>> be referenced there, as they didn't break anything that wasn't already > >>>>>>> broken. > >>>>>>> > >>>>>>> --- a/xen/arch/x86/mm.c > >>>>>>> +++ b/xen/arch/x86/mm.c > >>>>>>> @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ > >>>>>>> unsigned int partial_flags = page->partial_flags; > >>>>>>> l3_pgentry_t l3e = l3e_empty(); > >>>>>>> > >>>>>>> + /* > >>>>>>> + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not > >>>>>>> + * understand the weird 'extended cr3' format for dealing with high-order > >>>>>>> + * address bits. We cut some slack for control tools (before vcpu0 is > >>>>>>> + * initialised). > >>>>>> > >>>>>> Don't we then need some check in the vCPU init path to assure that the > >>>>>> cr3 is < 32bits if we allow those to initially be set? > >>>>>> > >>>>>> Or will the initialization unconditionally overwrite any previous cr3 > >>>>>> value? > >>>>> > >>>>> That's not the way I understand this "cut some slack". Instead I read it > >>>>> to be meant to cover for the VM-assist bit not being set, yet. Beyond > >>>>> that it is assumed to be tool stack's responsibility to constrain > >>>>> addresses suitably. If it doesn't, it'll simply break the guest. (There > >>>>> is some guessing on my part involved here, as the original introduction > >>>>> of that code didn't further explain things.) > >>>> > >>>> If it's just the guest that's broken I would think it's fine. As long > >>>> as such mismatch doesn't cause issues in the hypervisor internal state. > >>>> > >>>> Did you see a toolstack setting such entries before pae_extended_cr3 > >>>> is set? > >>> > >>> To be honest - I didn't look. As said in the longer reply to Andrew, I > >>> think it is more logical this way (the page table root already being > >>> validated as an L3 table when vCPU 0 is inititalized, which includes > >>> setting its CR3). Hence even if right now the order was the other way > >>> around (which I doubt it is), I wouldn't want to make impossible to > >>> restore the original ordering again. > >> > >> IMO I think it would be better if we could already report error at > >> domain creation time if the toolstack is attempting to create a domain > >> that the hypervisor knows is not going to work properly, rather than > >> allowing it and the guest failing in maybe non obvious ways. > >> > >> It seems to me however that we would need to fix xc_dom_boot_image() > >> in order to setup the vCPU before creating the initial page-tables. > >> (->setup_pgtables() hook being called before ->vcpu() hook) > > This might be a possibility, yes, but it's (imo severe) scope creep > in the context here. All I'm after is to restore code which was > delete in error (and which was, when it was still there, not > properly put in use in all cases it would have been needed). I realize the check was wrongly removed in 218adf199e68, so I guess it's fine to restore it, albeit it would be better if we could remove the weirdness with setting up page tables before the hypervisor has the full information about the domain capabilities. > >> So I don't think this is strictly worse than what we have, but it > >> would also be nice to get things sorted out so the ability of the > >> toolstack to shot its own foot is limited. > > > > Maybe I'm confused after all day, but isn't the hypercall used by the > > toolstack to set CR3 the same one used to set the vm_assist bits? > > (XEN_DOMCTL_setvcpucontext) > > > > At which point we just need to make sure d->vm_assist gets set before > > attempting to load the new CR3 (seems that way from the quick look > > I've given at arch_set_info_guest()). > > Right, it is this way already. But that's not the point. > MMUEXT_PIN_L3_TABLE may (will?) come ahead of this. Oh, I see. We should likely move the setting of vm_assist to the domain create hypercall, instead of doing it at vCPU initialization. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Apr 05 09:11:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 09:11:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518347.804778 (Exim 4.92) (envelope-from ) id 1pjzAs-0006df-Io; Wed, 05 Apr 2023 09:11:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518347.804778; Wed, 05 Apr 2023 09:11:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzAs-0006dY-FP; Wed, 05 Apr 2023 09:11:26 +0000 Received: by outflank-mailman (input) for mailman id 518347; Wed, 05 Apr 2023 09:11:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzAr-0006dR-Mw for xen-devel@lists.xen.org; Wed, 05 Apr 2023 09:11:25 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d51b8abb-d391-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 11:11:22 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id d17so35434249wrb.11 for ; Wed, 05 Apr 2023 02:11:21 -0700 (PDT) Received: from [192.168.0.106] ([91.123.150.38]) by smtp.gmail.com with ESMTPSA id u17-20020adfed51000000b002c6e8af1037sm14385616wro.104.2023.04.05.02.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 02:11:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d51b8abb-d391-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680685881; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gRLOiGbueskxaYnwpqydq+rM10NCqVGbvjWXD3gvn6E=; b=G2elS4ZYo1kgEMMcjJIhFHe/VvAfXmuTV4s89NwHNjE6m9A+6bvEvkm8YOybg5S59j +/VR0nxbNt5OV3tJhTq6fB3ImMahLMTA2BJQJRSnvH+aAY7yUB98kItFD0jHtNtamUqz 3nwryQ72vjbrwPNnWmLDZtSk9ttqot/Q3E5AxOorOkYZ/G9dl592HMBp0fasowjNg2+v ONjsu+JmrYYtX0XO8GUIuWg3QaUEhfX2Fe/w4gkIbRlAV2hcyljW7K3GCLDwLXpJ8EXt 6jlseYTxw6Q1GIWxuYSr/n8MsGiDLeguYXyy++qWraM7x47tXfS943MZREjSIXdDFxWs tG7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680685881; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gRLOiGbueskxaYnwpqydq+rM10NCqVGbvjWXD3gvn6E=; b=7mMw/pglvxN0NgNES+0esaG7kEcQxjFpT2McME1nwfpR3PE0UQglKvIuZ0gEUbiyGt kxBnG6NVyqOq/3VhRZ+r8FoIK/Qdf/JbK0MurDBYDGyYf4uCeZIjzM3bL8wGGx1UiGvz St7y80KiBD7FqbLdKvkDCnQiqPPA5Y+HcA+neHKg+nEWaZ+Gr3X3MW+xnyXcL7f3O6iw JrHb6vuMgnYXF1OXiJxNRAa8yp1+1i+7RXPBOk7vdmKJAerjjOMaptH/OGUkJPVUdRV0 fbyyISvJOoKPhjRSnCKIjHqRKYuMZqBILqCazsDtG03GzPtDDBllAvEgK7SsyOlH0J46 1Anw== X-Gm-Message-State: AAQBX9fke5OmJQhJ0J7Hg7Opqhiul7Zc5GH86Nt8jNYw8dfzOlEg/Qfb Mfmjuaeb+rYIKWs+5AfcB6E= X-Google-Smtp-Source: AKy350boAjHuIRohqBGVvG15oxrCQ5hHEJXX3ihgms29Tggf0EMnE5y29T4h/k/F2llty9g8UQTbhg== X-Received: by 2002:adf:fe8e:0:b0:2c5:4c9d:2dab with SMTP id l14-20020adffe8e000000b002c54c9d2dabmr1315099wrr.10.1680685881035; Wed, 05 Apr 2023 02:11:21 -0700 (PDT) Message-ID: <25c3cc19-e32d-6ced-2853-d1f78e3a476b@gmail.com> Date: Wed, 5 Apr 2023 12:11:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V2 2/2] libxl: fix matching of generic virtio device Content-Language: en-US To: Viresh Kumar Cc: Vincent Guittot , Anthony PERARD , Julien Grall , Juergen Gross , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Erik Schilling References: <62f2603d8b3fba1efb236063a0819fb95285b0ae.1680653504.git.viresh.kumar@linaro.org> From: Oleksandr Tyshchenko In-Reply-To: <62f2603d8b3fba1efb236063a0819fb95285b0ae.1680653504.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.04.23 03:12, Viresh Kumar wrote: Hello Viresh > The strings won't be an exact match, as we are only looking to match the > prefix here, i.e. "virtio,device". This is already done properly in > libxl_virtio.c file, lets do the same here too. > > Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") > Signed-off-by: Viresh Kumar > --- > V1->V2: Add the missing fixes tag. Reviewed-by: Oleksandr Tyshchenko > > tools/libs/light/libxl_arm.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index ddc7b2a15975..97c80d7ed0fa 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -1033,10 +1033,14 @@ static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, > } else if (!strcmp(type, VIRTIO_DEVICE_TYPE_GPIO)) { > res = make_virtio_mmio_node_gpio(gc, fdt); > if (res) return res; > - } else if (strcmp(type, VIRTIO_DEVICE_TYPE_GENERIC)) { > - /* Doesn't match generic virtio device */ > - LOG(ERROR, "Invalid type for virtio device: %s", type); > - return -EINVAL; > + } else { > + int len = sizeof(VIRTIO_DEVICE_TYPE_GENERIC) - 1; > + > + if (strncmp(type, VIRTIO_DEVICE_TYPE_GENERIC, len)) { > + /* Doesn't match generic virtio device */ > + LOG(ERROR, "Invalid type for virtio device: %s", type); > + return -EINVAL; > + } > } > > return fdt_end_node(fdt); From xen-devel-bounces@lists.xenproject.org Wed Apr 05 09:11:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 09:11:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518348.804788 (Exim 4.92) (envelope-from ) id 1pjzB5-0006w5-Ra; Wed, 05 Apr 2023 09:11:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518348.804788; Wed, 05 Apr 2023 09:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzB5-0006vw-NF; Wed, 05 Apr 2023 09:11:39 +0000 Received: by outflank-mailman (input) for mailman id 518348; Wed, 05 Apr 2023 09:11:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzB3-0006dR-Tx for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 09:11:38 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20620.outbound.protection.outlook.com [2a01:111:f400:7e1a::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd7d230a-d391-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 11:11:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6771.eurprd04.prod.outlook.com (2603:10a6:208:18d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 09:11:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 09:11:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd7d230a-d391-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dqqp3kNObjQSdp/LiiaRn7qG//2OqMJZx0AwmnFpHvpT9mJIXN+PSlIOjv/vUDw8xd5hbC4Mkgr6yp8XDvY2/aICNqhqs9eIYVpDElE7LElddvYvM54icm5fXg59gXEKcPv7Mes/IZZB2TfzF7EbyTBVC2rDxSWTVp3b+PxprFGbd3P01IBLH81026WjXx6kHY8GEeNFXOEFTp102acI2Bp4UPVDIOwzAI2OxQhn0L4s9naIK1cNhMHGmadWp1AxQOui6y7bJn03Z5mNJwrA9uYUHXDuI+/ZuXr6yXvjH1b1hDJdonKfIERZ1buIhAftdDAFLGThILJEs4lSW56OUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsIizMNRMggsxTCY+Sd25aj3DYEvJ4MtxDRw2VgDX44=; b=VG3p5wPCbAui+vxCWYV2gHzfY16jnXOXp0aQPYDtm3xrFvg+YzebkPjfCwrIWTEweq8mtBiLJTZWIqVGUfhDJXSYnBFJm+0Pz3+gMm05ahpPQp5qWQhxiezh0+6I8Ge5bue+AwbdkSo2/1Zp7wCnC4cHOXRJs7MQHZt5bDznk1psb6QmxlSbEQag0zcXmQz0xUc9MgDvdhvBeS1aZ1D3trwGwdCO4n9qTxoj3QCIWrCef+VYT9LmG5pokCIno+pWU1N55WL5Cd4GI5jlP5s2r+5CHZAkcA59Nd1XPORdUV4ZTmy1NCX4+7nxNsjIGC5Tx/cQExjj9sc3dJAfUsAbOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rsIizMNRMggsxTCY+Sd25aj3DYEvJ4MtxDRw2VgDX44=; b=z7CPivYOsb2W4E9I2HcknJ8gw9EWVZlJx0joUI2ZKh/wK5DYxaTPpBoN1ZUfw2bkSLlPdsKUPLTBsDF6CeEs2z/ENJ9voek0k84hm5R/RHpzoYs64ecVL65hKTf4IEVC1I9JPwtaZU8Ju10WdleoNs+nDj8mukPBF9ZW7Jm892hGjxgzyLY9Vtum5qsgFZMHex3X5NMCaJ2DMRK+NyAFggqV7Uh1+NUzPR3EpJlyTcLgIOOXqHhMva2SKdLIcRA2ribYgrCkRJYZ/zYCzo3RizugXI3UZwhMOH3TnBRIPZMYPTV8SsH+2qY6Wxp88OipfjBF0mK0fyhKJs2bYup33A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 5 Apr 2023 11:11:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 3/3] tools/xen-ucode: print information about currently loaded ucode Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230404160655.2354-1-sergey.dyasli@citrix.com> <20230404160655.2354-4-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: <20230404160655.2354-4-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6771:EE_ X-MS-Office365-Filtering-Correlation-Id: 0787be21-fdae-4be4-7164-08db35b5c07a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O7C669LueFj1JCSf0BzZTfn7YK9cnkQqWlhWAzz0yeEjeT4sQKgPZ1isMUC4zMSv836svO0vHuQOTdTwKhVpYCJKgWCVBloC59exz/IqHkOjbrgDusVW8B+LYK8F6nBMwkFL77VuWnZ2Vs9ukB+7m6DCYq7D1hrPWthN9aelf6NuKDX2B1HC5vy7DFsrvun3g4Jct9SlLwHlXWFqmxZHatTAK6CwY2ihee2Jxqu6BIstFGVeDPsp09KH61C+nP6tioiwpM7HgePUFfBujWmA4RVUN2gUSgg+SFmGCZGgdH6E1zlzQLw2/zsH2f4yMeeM/SPB5wqShikyESMMo58v6Q4u5ZdgXTpbRRM0CWm1QHsb+6J/0OP1y8jtxlEzpwc/keqXKeo4cjeBMV9h/4J5J2lZnQ9bwXp1QSvXdBgELB3xquqQGPCDZ73SfXNyCzPmE9JuOOrfmkY7hFR7LavufHzVM+ktAJseRnnkabuuTD089m4WUuXy9fUKiQkXu7fEIWAhUI857P2QSZ6lVBOXZZZWk6a9Xzj4WEYwumojV0fSbFBaS/2uvdLCEDo1mLk/fHR7/eI0DPfuVQnsSUDUbGoUY0AuAx5btWus/R3YmjiTPct1puLYL/aquDgPsG+luxP9drK3TB2DUoL+uBE2Lg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199021)(83380400001)(2616005)(6486002)(6506007)(6512007)(316002)(2906002)(478600001)(54906003)(53546011)(26005)(186003)(5660300002)(66476007)(38100700002)(66946007)(66556008)(86362001)(8936002)(6916009)(41300700001)(8676002)(31696002)(4326008)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnovOW5CSitrTFFmd2dKUU80Z3YyY2Y3Q0ZxcGx6QndOZjgwbGJBY3B6ZzND?= =?utf-8?B?dDVsckdFVGtKNC84VmxYN3lPOEFSODZXWnhxZ0JJNlBFcWdUeitlcTFFZ1E3?= =?utf-8?B?ZWtlNURPS2phdXdwRmRIb2tpNU0rS2k5SG8rNzgzVk9Wb0NZZ1E3ZG5DK2or?= =?utf-8?B?SWpGRWE0RkRFekpBSnVaUmRIOXVrMkFjWTNvYkNFVmpBRVM4ZkhOQkx2TSs0?= =?utf-8?B?TkFqKzJ3c3M4UXRSL2VYV0x6Q2g5VWh5STdWQTYySmJQVGQ5RlJ6Tm84RE5u?= =?utf-8?B?OUlyOHRGMlVwU1RhWlRkMXRaaEZ0U1BlSzRMdkVUZHRWN2ZFWVNBNldBTURR?= =?utf-8?B?c3ZMMTJZZWFBVWRZLy9CRk5hbnZXVEJSM1Q4SkZTSk5kWEhiVVYvaElUZ3J1?= =?utf-8?B?VzJzbmZCZTZZZzV5VVhnWEtEZzlqQTlwcFFGOE9hRXV0a3hZTkJNK0xoeURp?= =?utf-8?B?U21KcWhldnZtZUo4R0pXeThsK0VmcXNsSkJWNGdXbjVUWXpkZUcxT25qNmtZ?= =?utf-8?B?MFEwbk0zR2ZPOFQwOE03MVFDRnFSaUVFc2JhQWpMUXVNajI1ZkdMdkpGRndv?= =?utf-8?B?c29qcldISGxwMlFjbU0yVk13QUUvMHp3bmpyUUJBdjhobC9pUWhKWHhpZnFH?= =?utf-8?B?bDgxdDUzZ2x2ZHJRdHN3U01hM1FjQ1l4b1lFMUVUYXh1NTVTKzlCL2FOeW9G?= =?utf-8?B?SGs5N2IyckxzUEZpaU84SWhrT3hTeWZkSjJ0d1JVaDhOc2ZyeVdzUEswNHd6?= =?utf-8?B?R1VDNUIzdm1Cb0s0QTdJenlmZFZJS3VGTHpaallBdmlvUVV5bmtGL1huU28w?= =?utf-8?B?SG5Ic3h5dkJYc3pHbk1ENHRycnJKeWJwNm1USUpiS00yTzkxSDVYcWlCOEpt?= =?utf-8?B?Smg0QU1hYWdIMDZvY0ZpRERzVk5QUjRNWkVtU1hEcnpkWEd4cDd1ZDJ1SjU3?= =?utf-8?B?VWJ3QXVvYVdSOFhFSXU5R0dzUXI1UlNwV3RGd0pvRnFLdTZGMmUrR204djMv?= =?utf-8?B?aEVZWXp3QkRnUmd1elBBRHkrWFB3TG1SbG1xVHVMbEVGdkpVaHhlT2NVTk1n?= =?utf-8?B?cjM4ZVVXNEdoZ1M5a2tnMzc1eHdZV0w1NXlvN1ZQWCsxdFB1TUFiTUoyaW1o?= =?utf-8?B?d2pwaC9PdElJNmx1a2RPVzFscTFxdUZGVWZLVGt0T1k3K0ZnbG9GbTdlb1J3?= =?utf-8?B?WTZhQWlWS2JEQ3V6dGEvS2RmalZsbXNtSXJhYjZwSHBkZWQ1dXUrUmVsU3VD?= =?utf-8?B?aVM0clczalVPR0hLYVIzZUIzcVRtRXNvaklSWUNJdngwZmZqTm01WnFRRTJI?= =?utf-8?B?NVlENWsrcmFxUVpWdDdpR1ZHWVZldnAxVkFXR3ltUkZDT1dlOCtUZTFyL1Bk?= =?utf-8?B?ZVlWdE9yMTkyc21HQ0Nxc3M2L3JaRHJGZEZVNDFkZnZQV0lvaXFJRisvMy94?= =?utf-8?B?Y0lPMDZ5SjN3WW85UnJlZEI3YUhNQitYNkwrQlRYTVZVVndyVzVUVGdqRU9F?= =?utf-8?B?UG5xSTRNaUlZZEk4RXJaaWR4Y3lUR2pVOXprcSsxVVpzNFFYalR5cUMzZ2Ns?= =?utf-8?B?YW4wR1loTFN5MENjM0NBZ2NhYUlUTGlqb1VIdDZXZUFsYmt0V20xclU5ZGtW?= =?utf-8?B?UlMyQlBpelo3M28vMnRaR2djOFVPN2VTUEZHMkI5RllJMTFYWWNhZjFsRVBn?= =?utf-8?B?cFdHc29SYXhEZnlIeDdWMWxXTHFHS3Nkd0hsWlJOYU4xcS9TNTRmbytuRlpv?= =?utf-8?B?MDRBSWFuY0ZtZGlnMnh5dXkwUytXNnhPOUgydzhTQmNYM2Y4NlVwdmU0UGlp?= =?utf-8?B?dEY1bGNkNkc3YVZaY3hLaktJeXhCWnpOQk40bUpCS1N3ZzNORmErM0VyMEwv?= =?utf-8?B?bjEvNzh4aWZaemYxa0dYa2huMFZqN1dNeGZ6aTlmOFdZb0FoeDZkTHdGSy84?= =?utf-8?B?dmo2SkUwbUhRVzdyOVl2UVhNNXY1L2hjOUdJRDNmbkZDTU02MDhpNmJlTGUr?= =?utf-8?B?OHBqTWVjbTFRbFRmak1mcjRxM0RFWFdpWDlZVU1rd3RoakRoVkdRYjB5WUF2?= =?utf-8?B?Wmp4VGF2MG5GTlpLci9mQy8xTWIycGpUMStrV0ExcjNST091YWErTDBXS0pY?= =?utf-8?Q?MJsezj3/nEfQaOVoIHBlEVquI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0787be21-fdae-4be4-7164-08db35b5c07a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 09:11:33.9218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 25QtnpjRaVufSdNAG0CdAnkP7WrWrK/3zZBM7JUqIMwymmcpOgAGPw+m90xwa+tpOg3OHl7WXMwPz6+arylIEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6771 On 04.04.2023 18:06, Sergey Dyasli wrote: > Add an option to xen-ucode tool to print the currently loaded ucode > revision and also print it during usage info. Print CPU signature and > platform flags as well. The raw data comes from XENPF_get_cpu_version > and XENPF_get_ucode_revision platform ops. > > Example output: > Intel: > CPU signature 06-55-04 (raw 0x00050654) pf 0x1 revision 0x02006e05 > > AMD: > CPU signature fam19h (raw 0x00a00f11) revision 0x0a0011ce Wouldn't it make sense to also report the model number here, even if ucode blob file names (currently) don't include it? While for the revision always printing 8 digits is definitely helpful, I wonder whether the two top nibbles of the raw value wouldn't better be omitted. (I understand Andrew did ask for this, but it's unclear to me why he extended this request to the raw fields.) > --- a/tools/misc/xen-ucode.c > +++ b/tools/misc/xen-ucode.c > @@ -12,22 +12,89 @@ > #include > #include > > +static xc_interface *xch; > + > +static const char intel_id[] = "GenuineIntel"; > +static const char amd_id[] = "AuthenticAMD"; > + > +static void show_curr_cpu(FILE *f) > +{ > + int ret; > + struct xenpf_pcpu_version cpu_ver = { .xen_cpuid = 0 }; > + struct xenpf_ucode_revision ucode_rev = { .cpu = 0 }; As mentioned before - the current state of the system may be inconsistent, so I question the entire lack of a way to know of this by using this tool (even if via a specific command line option, defaulting to CPU0-only). > + ret = xc_get_cpu_version(xch, &cpu_ver); > + if ( ret ) > + { > + fprintf(f, "Failed to get CPU information. (err: %s)\n", > + strerror(errno)); > + exit(1); Errors want to go to stderr, I would say (just like is already the case in main()). > + } > + > + ret = xc_get_ucode_revision(xch, &ucode_rev); > + if ( ret ) > + { > + fprintf(f, "Failed to get microcode information. (err: %s)\n", > + strerror(errno)); > + exit(1); > + } > + > + /* > + * Print signature in a form that allows to quickly identify which ucode > + * blob to load, e.g.: > + * > + * Intel: /lib/firmware/intel-ucode/06-55-04 > + * AMD: /lib/firmware/amd-ucode/microcode_amd_fam19h.bin > + */ > + if ( memcmp(cpu_ver.vendor_id, intel_id, > + sizeof(cpu_ver.vendor_id)) == 0 ) > + { > + fprintf(f, "CPU signature %02x-%02x-%02x (raw 0x%08x) pf %#x revision 0x%08x\n", > + cpu_ver.family, cpu_ver.model, cpu_ver.stepping, > + ucode_rev.signature, ucode_rev.pf, ucode_rev.revision); Nit: Indentation (also below). I think you mean fprintf(f, "CPU signature %02x-%02x-%02x (raw 0x%08x) pf %#x revision 0x%08x\n", cpu_ver.family, cpu_ver.model, cpu_ver.stepping, ucode_rev.signature, ucode_rev.pf, ucode_rev.revision); > + } > + else if ( memcmp(cpu_ver.vendor_id, amd_id, > + sizeof(cpu_ver.vendor_id)) == 0 ) > + { > + fprintf(f, "CPU signature fam%xh (raw 0x%08x) revision 0x%08x\n", > + cpu_ver.family, ucode_rev.signature, ucode_rev.revision); > + } > + else > + { > + fprintf(f, "Unsupported CPU vendor: %s\n", cpu_ver.vendor_id); > + exit(3); > + } > +} > + > int main(int argc, char *argv[]) > { > int fd, ret; > char *filename, *buf; > size_t len; > struct stat st; > - xc_interface *xch; > + > + xch = xc_interface_open(NULL, NULL, 0); > + if ( xch == NULL ) > + { > + fprintf(stderr, "Error opening xc interface. (err: %s)\n", > + strerror(errno)); > + exit(1); > + } > > if ( argc < 2 ) > { > - fprintf(stderr, > - "xen-ucode: Xen microcode updating tool\n" > - "Usage: %s \n", argv[0]); > + fprintf(stderr, "xen-ucode: Xen microcode updating tool\n"); > + show_curr_cpu(stderr); I recall you had it this way before, but I don't see why this information needs to be part of argument error handling. Furthermore, considering the possibility of hitting an error path in show_curr_cpu(), I think ... > + fprintf(stderr, "Usage: %s \n", argv[0]); ... this would need printing first, and perhaps ... > exit(2); ... the exit code also shouldn't be anything other than 2 in that event. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 09:15:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 09:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518355.804798 (Exim 4.92) (envelope-from ) id 1pjzEh-0007t5-AU; Wed, 05 Apr 2023 09:15:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518355.804798; Wed, 05 Apr 2023 09:15:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzEh-0007sy-7h; Wed, 05 Apr 2023 09:15:23 +0000 Received: by outflank-mailman (input) for mailman id 518355; Wed, 05 Apr 2023 09:15:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzEg-0007sq-37 for xen-devel@lists.xen.org; Wed, 05 Apr 2023 09:15:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7e1a::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62ec97af-d392-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 11:15:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7876.eurprd04.prod.outlook.com (2603:10a6:20b:240::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.29; Wed, 5 Apr 2023 09:15:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 09:15:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62ec97af-d392-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+jaEhnggllRYjqTkpwjysVVVgWFYTGz9lzM5nBjrVMB9UystPgajJFU+uYsPPQdxLs/ndXUOLdb2pZ52y9G55PW6JbTh8VuMHFyzt8W7ak5Mo/AIgdS0OyMDtiqq0Op6qd24U2yEP08YvS80rxQmnsR/aVmfQnIqZaqdJuXwn2GoCr/IyiofILZwcQKXLLqLMpWN9eb0M0yl+aYlzMNDqloe9JzAt4fEb9CgmvfOXTucSION6hIJn2fzvpbKy2ReHCJXLSDOaztWjwQwOUxmYoQzUs0djmzADw9Le9hm2N/va6db5BNUkxpigYCh/jDVcYohx8wASZ315XrXa5J2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e++isSxOgl7MWiuKsHDzIFCAkVOM4/Smlnr77qRqEsU=; b=Dp9Xs+vjTb6aobqXj1w3J1PKBsRhsCo4c2l5ygtBCJnnAH34myInPHAfk/EDhbO9+1PHhFwgQQ/0O7NR6qog0KBD4tKrNeXSfc6qdsFsl7yT/+pPMiLQ36dnH0syHiCstGXHmDuLKn8PpH0Lt4nil0440NtQ98qOv6Abgu6eWfRpDFsKImFGex4xJRaAdWB9YYbjp3bAXjJOzzW8o4c9EbXYynK3nfrDYZ3a0lLbe8VIulzltJMy2yZZip5PUafKB9KRHOw6dtASn2Ls2ot3blNR2CoZVfdm8JnSeiiqbDl8Em24FsC6gFkFIoOQfAEL5GFVpkbDl8Wo0b68l4MWLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e++isSxOgl7MWiuKsHDzIFCAkVOM4/Smlnr77qRqEsU=; b=O8ueFYfc6S/gFSd08mPmjK1LA/Tcj8ZC2QNXQtvD4BhxXhrEEi4i8/3QHK6o7jNfuKd9Zb91xw5mj42nNIdJ8AaoxIPimT/P36t4jscekT43+ijz4fzTpqFqNvr3/s4jTwisC3Cq152+nx4PQglJbp+E5TmjJV1nuR0PnFavGRIkUmm1IYeq3oEmCYfqEb6qRqR0Ev9sXsKcrCTLLiSLYQmbUkGRhXAfWlMiA1aG/O5DmbdTs28xYMDP4GSOdiW4hzF7eRZG2Dt3C9AvBD3zJGD3cIlk1vlrEQIfsPy26Kd6vAO5+sWKvpx0Wsv7Y01AOUukiDnyYalt7B9GlpF2PQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 5 Apr 2023 11:15:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id Content-Language: en-US To: Viresh Kumar Cc: Vincent Guittot , Juergen Gross , stratos-dev@op-lists.linaro.org, xen-devel@lists.xen.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Erik Schilling , Julien Grall , Anthony PERARD , Oleksandr Tyshchenko References: <37fa3d37-5ee7-863c-48cd-1ce313c8e296@gmail.com> <20230405085115.dayqa6mrkac372sb@vireshk-i7> From: Jan Beulich In-Reply-To: <20230405085115.dayqa6mrkac372sb@vireshk-i7> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0161.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7876:EE_ X-MS-Office365-Filtering-Correlation-Id: 209caa11-fccc-4659-eeda-08db35b6458b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a0MWxSlQGV65ovRIA57oL8LKsBhQ0cTYrfgSPHqbYNXpA2+noTpTMXJawwrlJSnKfFBVyEvFoc8MvLqoLRw6OluPVkiGk99cO0ceRqN/moi0CpGDdKdcmwLlnCcc6OMXxRRWVfmkNeM+jbI2j7hhT4o160m+VxxQlfT0wRREOYEjyqf1w6dtdGmZjxO9cy4y09jrBIixb3BrjG/qGlRWGosN70yU37jsGmz6D9177JHw+JJpOD8RhVSR9O5Hgoz++yrJ/kTY4abHvD7SlWJeWtmLaTdhpOu4iG/5ZUj9ZOiyGvbVQvmxSfeWjRkGZ7j1pH5kjOVnSnklsLDnJQBiKNSBjtW7zEG2YLcTlk1zHsge5YGKqxHJ9LwHwqPOtEjk4NZ+LyTMqg42o/7dTqII853q/XHbiOezvY+o5/PMP+OJOdpz3423WLBQmQ1emm0W8CokRkiSB/RgdZD8ZI0MkexiXk7mm3T37/UPGW/uqT5IIyXJVp4gMLE1wOCajHMTR7zbceI77wIgYFcabtqiSzDKa4nfJxH88PAZa3jxVHmZ+WyxshVNZzTmWnBXXkMO2lAnXJeRa0pUS2k8v8O5Uo2ZBEYOhynDm69wXUbm9lUEFK/CNYLYSYr7vcNktEVhwxtKQON0w4vtTMN4HmlJyRt39BWofNLS5ky1Hi+Sx3s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199021)(38100700002)(4326008)(5660300002)(8676002)(7416002)(4744005)(8936002)(6916009)(66476007)(66556008)(66946007)(41300700001)(86362001)(31696002)(36756003)(6486002)(2906002)(478600001)(316002)(53546011)(2616005)(6512007)(6506007)(31686004)(186003)(26005)(54906003)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVJ5RUJkUzJhcGE1dXhSTUhZTjFiWnc1RWpjdHdCMWZhVjZJOXJLZC8zM3ow?= =?utf-8?B?cEFvMmQzbDU3SW5scTRIV1d3b1IvR0p6eUxHQ0ZyNWhEMGE2RDYyT1NSSUVq?= =?utf-8?B?aVpMcGdBZ2RvSklMaklpRVpKQ1V2S3QvYm9IL01OdWo3RnlwY1B0eVFHR2hz?= =?utf-8?B?dzBBUEdlOE5MeXkxZWVSNndkRmJiMjFJMG5rdXJYUFUzY0pkNzJ2Y2RFNEdJ?= =?utf-8?B?K091R2JzTUpnZVhMZ3oxZzAxS2RZcG56YngzS0kwWlpDOURHWnlVSzdWUm9P?= =?utf-8?B?dTFRUXd6aWVpNHpCQ09BeXBjNy9mTGZqcVFrTDY0UElWVjFNU0prM3dHTXIw?= =?utf-8?B?RU1OVVRNZ1M5MGJNU1E4SzgxK3crZFJrY1BLbEc4aCtSRmU3Q1puVWRuanEw?= =?utf-8?B?bFhnejlIRm1VeXBDZkVMNmtxVE4vNHJVcjZXdlZ2a1JlT29DcFhCWmluTFF6?= =?utf-8?B?cmE1QlphQUE3Y3NoYWlsM1VaTEladlYzTVdlYkV2SkczaUhJZEI1MXRlWmhY?= =?utf-8?B?U1JpM2xNUy9JNTVlcU5Jd0RiNVJ2K2Y2OVN3eTAwb2VNSksxV0lodTNiZjBH?= =?utf-8?B?RkRoSWx2UUZITXA0dENubVVGNVJRM2dRenpqMC95RDkxRUVBTTBYQW9RMlov?= =?utf-8?B?cmwrcnpMc1lGdDRNT1Y3RDNLZkhEZ0g0ZC9QeXU0aU54T25JZEUzdE9FTk9y?= =?utf-8?B?MTNlVHlyS1pkRlhZS3lHbmpqdkxiZHdwVi93OHJKT0JGVDY4SmMxUCtGOUd0?= =?utf-8?B?VVp4TVVQNExFUGZyWnNJMkF6aFRRT3BCTzhNVFZrazdndE44RFRRM0pHTUtL?= =?utf-8?B?R2lYWTRVYjlZSFZLRkc2Y1pkQ0tmcDRUR1BaYnFVWnVDVWRjRldzREFEcDhr?= =?utf-8?B?UTdTU1FZMmxRWnRyZ3lBeXo2Q1padmg3Zzg1dnIrUXZicFRCd0dsUGFqLzc1?= =?utf-8?B?WTU1a0ppWUk5cnhNM3RuT0N4aVdsWUlpVXByeTZLbkkxb3pIMmRhSFJGR0g4?= =?utf-8?B?SUJkYWRHQ0dQWHlCSFowOVdYRkdsejQ5MHZlTDF1V0FXcENtY3hmYkFlcEFV?= =?utf-8?B?N0lSWTd1d1pwQzliZ3FoVGNiZzdaWWFSZ0s3SzZrQ1hjWUFvL2E3TkNZdEJ0?= =?utf-8?B?OGF3bDhpYmgrd1hqTEhEM0FBaHNYeHNKMVNFZ1R0dVRDSlZSZ0JqUzVCeGdZ?= =?utf-8?B?NkZRY210Ty9qYitRdFd5UHJVZWhKS2hZU2pETHBYRnRxVmlVMVR5QlpaMDlo?= =?utf-8?B?WGdodkc1NkJpbUU2QitJRTZVR2plZkdvQUlKSjJpd2hTNEFFRGJxcTYyaTFZ?= =?utf-8?B?YjBnV0NubzZMZkVyWmNoSW0yTDk3aFBRcWJXejJFRkdiWVZIWjZyZm04L3FK?= =?utf-8?B?TS9EdllEbExFeGdaUG15bnB5YWZqd1EydUVLNU5iWnNBbjFscFhGTUc3QjdZ?= =?utf-8?B?V1dlMkJkQ1lTamxlRGZyREpOVHJWSCtIN0RoTElGcTJJUml3Q2RnYWRsaUVH?= =?utf-8?B?bm53RFZDQmNIblZpZHc5NXVsamIrclR6SXpMWXA0cDIzWG1DMGdTcVNhQVBm?= =?utf-8?B?b2dUVGI4Z3dTbVBNL2hMWUxzRXNUbjU4ejdsNFc0VUdoa282Z1drZzB5dm9S?= =?utf-8?B?NG9tRjJTU0k0YWhEaGxmbXlHZU45bjJGdXpHQTh0ZG8zQVcrSlFBck05VTRU?= =?utf-8?B?ZFVJU0xtQkd1U0xPUGVPTHAxTHgreUQ2enlSaHVCSDNCNU84UEUrbkFRZjdk?= =?utf-8?B?UW9odFpiS2lTUzJBNHczN2dncWRDdFc2WVFiZTJTaDI3a2hOODJBRWY2c1cr?= =?utf-8?B?eWdpT00rVjFXckcxcDROVjRlZmRDV2l5STh3V0ZGYTBoQWdPb0o5QWZITkZD?= =?utf-8?B?RlUxRThzNk1WazhXOFNVSjhxQlpQOXdsVXFXRDkvOG1La1BnSXRaejVrTngw?= =?utf-8?B?TlJrVnBnSjhOaVBpcXloUkh5RFM0NWNzWEduOEdQNmU2NTBCSUl4Sllod1BF?= =?utf-8?B?bFk3akp1Y1BXTTFWU2UvSTY4QWpmSlRKWkNFZVpvSzdiTFZaOUtBLy9YM1B5?= =?utf-8?B?MVNFTncvMXBoc2o0aVZCZEpVZkFESFVFa2tMTmRwY0hpMFhFMWVlN1BPVHNX?= =?utf-8?Q?GTV2JFh3yzvRuv5p22GqtIBRW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 209caa11-fccc-4659-eeda-08db35b6458b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 09:15:17.1760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y0FcpipTBZHGtx7E/T4c/Ujcp08CGzDJZGguTsEmmD6FWKKzNhRqueGSlLBQMFP9yTsFFfDO4k+XVErcIC8lxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7876 On 05.04.2023 10:51, Viresh Kumar wrote: > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1608,8 +1608,10 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is > > L > > -For generic virtio devices, where we don't need to set special or compatible > -properties in the Device Tree, the type field must be set to "virtio,device". > +For other generic virtio devices, where we don't need to set special or > +compatible properties in the Device Tree, the type field must be set to > +"virtio,device" or "virtio,device", where "N" is the virtio device id in > +hexadecimal format. Are "virtio,device0x1a" or "virtio,device1A" valid, too? If so, all is fine, but if not, constraints on the hex representation may want mentioning. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 09:25:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 09:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518360.804809 (Exim 4.92) (envelope-from ) id 1pjzOD-0001Cu-DU; Wed, 05 Apr 2023 09:25:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518360.804809; Wed, 05 Apr 2023 09:25:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzOD-0001Cn-7o; Wed, 05 Apr 2023 09:25:13 +0000 Received: by outflank-mailman (input) for mailman id 518360; Wed, 05 Apr 2023 09:25:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzOB-0001Bs-UJ for xen-devel@lists.xen.org; Wed, 05 Apr 2023 09:25:11 +0000 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [2607:f8b0:4864:20::1029]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2698ef1-d393-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 11:25:10 +0200 (CEST) Received: by mail-pj1-x1029.google.com with SMTP id x15so33319475pjk.2 for ; Wed, 05 Apr 2023 02:25:10 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id c16-20020aa78c10000000b005e5b11335b3sm10217060pfd.57.2023.04.05.02.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 02:25:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2698ef1-d393-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680686708; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dsJ1Pr7QDcgnVIhypGgV7+tj/tswyw0N5/Rm+NWo9rw=; b=pzmB7sUauULhFlJsutjbD5Pd+oLKsT4Xw/RxGQioknnTrxEKEet7YPNeeXCYoj/zme pqze3Hx8gl7n+YUq4EyKvVLtoFjBWsHsUiTy7ZEanhOSqYAk3/2AlNH8kavrYPFGtT4q Zurgcbc94KYYFAwVtv4YiUV5dlMEtKrVK2Tx7EUAn65NJVcQH7oikRAT4CA4zp204nJX 3lEt1kyMTHXyiaCunAMqsWyIjyMKedvtl18qi6y/Ce04nulNI/5ngUn0P5AvLuRfhTBk 8AhLO3UvrQWwjlbAM+Oe+UgIhr2k61l8XZFuPn2e3xohwbVsXiKG7ijBEb3f5DtFCRTr bHIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680686708; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dsJ1Pr7QDcgnVIhypGgV7+tj/tswyw0N5/Rm+NWo9rw=; b=E+897j5D3nRltUS4Y++PhYrdiXGEfElbj4U/9HqVYghtKQSskbQQsV2DigfZW4syNQ LDSrJ3eELlCAdNKBr3XGMDlRLxf1qiyGXpjwaxjuUBjLxuM3SrsD9zxb0kNU2fQwK3wn PieGgFUJMdP03Gk1so69DH2dQ5LsWrlFT+5K+cagKSyoTAYkMkBdE24dsg6JRpvJoaXQ /C5PeIXGGlNggAJwXxzuZ+xXgzAT3E017g/KatKKKeBRIVjPr15giriZwf11l5G0GVN0 OLUbJaM5aJ6QEOywkI2g5SxsDasX96cWJsNYLP/F0jdwUpH46CFShWhqbbKrBZwSQpPK jBng== X-Gm-Message-State: AAQBX9chiB3H55lRft0rIaiov4o5pxzwHmJmp0T8KduzKsX2G6LzMFe5 gcn7nGuDzhlLTCbagJ8XkOXDNA== X-Google-Smtp-Source: AKy350axzbppMO9pJvbe8uQWRrvT0Q70A5UqfDWeL56uAno2xeYPmJ3cO0Ki+RfnZn5B2CjkZP3wag== X-Received: by 2002:a05:6a20:b728:b0:d8:bed9:33cf with SMTP id fg40-20020a056a20b72800b000d8bed933cfmr1816252pzb.17.1680686708638; Wed, 05 Apr 2023 02:25:08 -0700 (PDT) Date: Wed, 5 Apr 2023 14:54:57 +0530 From: Viresh Kumar To: Jan Beulich Cc: Vincent Guittot , Juergen Gross , stratos-dev@op-lists.linaro.org, xen-devel@lists.xen.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Mathieu Poirier , Erik Schilling , Julien Grall , Anthony PERARD , Oleksandr Tyshchenko Subject: Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id Message-ID: <20230405092457.m6bi2yvv7s2nasxv@vireshk-i7> References: <37fa3d37-5ee7-863c-48cd-1ce313c8e296@gmail.com> <20230405085115.dayqa6mrkac372sb@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 05-04-23, 11:15, Jan Beulich wrote: > On 05.04.2023 10:51, Viresh Kumar wrote: > > --- a/docs/man/xl.cfg.5.pod.in > > +++ b/docs/man/xl.cfg.5.pod.in > > @@ -1608,8 +1608,10 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is > > > > L > > > > -For generic virtio devices, where we don't need to set special or compatible > > -properties in the Device Tree, the type field must be set to "virtio,device". > > +For other generic virtio devices, where we don't need to set special or > > +compatible properties in the Device Tree, the type field must be set to > > +"virtio,device" or "virtio,device", where "N" is the virtio device id in > > +hexadecimal format. > > Are "virtio,device0x1a" or "virtio,device1A" valid, too? If so, all is fine, > but if not, constraints on the hex representation may want mentioning. >From [1], both above are invalid. Updated doc as: diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 10f37990be57..24ac92718288 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1608,8 +1608,11 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is L -For generic virtio devices, where we don't need to set special or compatible -properties in the Device Tree, the type field must be set to "virtio,device". +For other generic virtio devices, where we don't need to set special or +compatible properties in the Device Tree, the type field must be set to +"virtio,device" or "virtio,device", where "N" is the virtio device id in +hexadecimal format, without the "0x" prefix and all in lower case, like +"virtio,device1a" for the file system device. -- viresh [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/virtio/virtio-device.yaml From xen-devel-bounces@lists.xenproject.org Wed Apr 05 09:30:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 09:30:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518364.804818 (Exim 4.92) (envelope-from ) id 1pjzSo-0001vr-Se; Wed, 05 Apr 2023 09:29:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518364.804818; Wed, 05 Apr 2023 09:29:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzSo-0001vk-Pn; Wed, 05 Apr 2023 09:29:58 +0000 Received: by outflank-mailman (input) for mailman id 518364; Wed, 05 Apr 2023 09:29:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzSo-0001vd-Cj for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 09:29:58 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062a.outbound.protection.outlook.com [2a01:111:f400:fe16::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6cd39c67-d394-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 11:29:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8037.eurprd04.prod.outlook.com (2603:10a6:20b:2ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Wed, 5 Apr 2023 09:29:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 09:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cd39c67-d394-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBhg9vijep/v9C+llyabXe18soO62vzduroRAbB8BlMvl+73vmxZwu9ZjJlFcbrrOxs05GcL+bG3wRmliZ/9C1GAOtWjQf32dFVLFbnnkHeGmda09Q0KJDTLi3iEcEwDmNrJYO6VcpGIuY0G6AhC/sRtfAhRP3byN3X76Snlb4sL9uTeJ0WGLd0caOtmpKkcsHoKk44mwnAIg+kVfurlzCyodCfGnhYrVXANSPOREijRIfWlDUvuTW6ZsJh1lm6jK04V9S0MFxtj/qjEcQ8C3NL6EtH0E22f71w+tJ0uIxPagVEYPXd5mle5S9axn48uBGx4Jd/OIgwD4ZP1Fc/lqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z9Rxxk0xnOzGBNILaI2KtYmjf6KxyxKXqSchWhBI7lQ=; b=Ia9TTMdLrEyFi1mh1540MpmP3f+31DecoC2D8apK4Xy6+n8SMqnU1Tc9l+8ZzT8Ca/n5gJkgvBWRZurQV6UVr8UEeAZ/hBOBxVyJKK63eY8c38fjo7Ek02U9pMpLkPghjbroiTE2rbM3b1ENr+tiBWTqaUVtVAPO507RvQlsn7o5AR4fumnYdzIogPaefrOThjY7GxyGjip+mGVieEhc/lyMcFaHwj19NS7TNlw5MTR8wFPlsPq2NdPHeoqxkqAgao40OL3og0kIc2RYK8eaNcIS4FWnVcN6yjB9Cfh6xWI+gjn74hT9mVYszEenF3qia+j8+NOs3uYimbydGnTyOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9Rxxk0xnOzGBNILaI2KtYmjf6KxyxKXqSchWhBI7lQ=; b=nak0QiD1TXZSpOgrrKlHFvQ0mV90eHf+Lg2Z89Z22f/dmleT6Bg3L1KBB3t+YXuC3w8cnnWm3wRtDezKTYVNlDifTDVKlOQ40rldT3JxdZWwD+PS/6yopXH1bsAyzk1uoIoc6VXRAjWIpv9OXtrrxjuKloJ4xB4LCAvBQ6A/kE/2qU68Rdszd/jL6rEoQYGE3eJmgqvEmw3wwZW2o9ol6Bfo2XXxkdgFTUiR26z/frM0G1g9+/3mt21vx+IjK+2fi1ABvutjKdzfCCvcEve7fq6VRCrAVY8bEf6tX/LCM90Scl5+YEoJZvnIEXtuI5MXpe05ZZXSqM3guuc15mL7aQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83cc6b93-6a50-1eed-1588-20b3bc38c318@suse.com> Date: Wed, 5 Apr 2023 11:29:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> <5cda250b-57b4-2833-99d3-84ae8ca32059@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8037:EE_ X-MS-Office365-Filtering-Correlation-Id: 7300fe45-f032-4e02-af28-08db35b84fa1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sJMpCA0lXTsmaqWmD/wdHsz+mDNMs3uC4wsdhNJO21AjegL9VFpN1jtUEA1oKpFlq/BGUXOVfVC0Nqiz66JuvJpNydPSxwJ9lvPiCoYGApg/DVwp3uuAiRw0Zwyrc+O0wUHUSBS2+PPv81OgrltaibFTKb2we5n2bLrIBoMltY/Pwo8ntnUPvqHlz2a2t2s+Wbep+mHCmTuicXaW04aJooJ+UIx3dzFJlOISJt42YDFXGzsAz/3cDNnvNugAhTb/GvyFk8ExS8BFQRbQgfsvZlQ3sJrq02MkMpqw+Oc1uVeD0HG2xy/moQ82u9ltl+f6nDLzinM46Rl85EkzF5kj+tCyFmxyntCqZQZ1F/Obo1ZZOSjAfchhA48IhizxfvqR3RehycCmbzBCRVXgXwNcpE4Uio8hFBCpXtkwKUOKnEOel3Ht0hUwzVSCI8kPvG7Srwxl4HRDX86b2qiHxeqGzDeKkP6xUodCW05zjb02701xpb0faa/H0alZEwZBNJDc/CXiSLySF+1i/FFbRALwFp4bqxkp9m7ZBMzM0lFzykVNSd9yFZq/0luphkWZeZwm5ETgsM/ao1qJyYUOE3Bum1AhwTVKkv0nhk+RNzL5O+LRZGzHG2oD66Wg/xWoA8Uy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199021)(2616005)(83380400001)(6486002)(478600001)(316002)(54906003)(26005)(6506007)(186003)(6512007)(53546011)(2906002)(4744005)(36756003)(4326008)(5660300002)(38100700002)(6916009)(66556008)(41300700001)(66476007)(8676002)(86362001)(31696002)(8936002)(66946007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWU0K2E2cWFaYW5BUVV5NGhJOGZucmsxZjNZV0t1QTJiV2NiaU5UWUxCV0ho?= =?utf-8?B?MkllaVE3NFQ5K1pUR0NEL2NkTVBJbVBKT1llaDR6dXdOQVVpUTJnOUpFVmVy?= =?utf-8?B?dzRhV1psUzY2RGRPUXRXUGRkVlJDbE9lUGdzL0xRNWZPY3ptSnNWNmRiS1B0?= =?utf-8?B?TERGR2sxN012SGdiS3pIZnoyYk9tQkgzMFcrNjZXVXBRZ09oUURyL0tCa1VO?= =?utf-8?B?enhjUy80Q05Cdk4wYXFadExQK2VQYXJJYXVzcnh3WmVJWGhFVFdvSWlvNHVU?= =?utf-8?B?ako0WG1UYXZ6V3pPSzJtUG9SNCtHblk5QlJtZ1NsV09CcXpGeEhrMzBjTnJx?= =?utf-8?B?TFI4K2JFRFBjU2R2QVNqVERXeEI0QXpwa1VJTmxOMDJoMHZMUCsraDQydnFl?= =?utf-8?B?eHVoNXdqT2gxWE5vNkRaSW80Ny9hckFXc01RZVhueHU3S2pvZE45bGp3UFl2?= =?utf-8?B?YXphM2NtTldDZmUwRXpYajREZkV5QnFkR2lGMTZvOUhLV2p1b2V5cEgzRHlo?= =?utf-8?B?RlF4QS8wSFU0SGJxWVhyTkpZQWNiSkUzOGpkbVg0cVQyMkdwa3JPWmxNSzFa?= =?utf-8?B?SDdyampWaldDSjlQS2l2M28yb3luZmVScmRNU1ROZG81SE1VOTd4U09qQXNI?= =?utf-8?B?OUoyb0F0eVgxSmpQcnJDQTNrSDMzMkJtdHdGZXBjaXJQWCs5MzduRmd1OXFT?= =?utf-8?B?QzFqUFB2MlIyczk4QWQ3Vmh3OGNHcVlId2dBVlJ1bUhia0VnVzNqNkhkN2J1?= =?utf-8?B?TUpJK3pqdmt4dkFPaTJaaUo3R0xWWmxVQjl6V0xhNklXTmxta25YMllnbVRZ?= =?utf-8?B?OU1qYkdPeUsvWWNkenJ2Nm9mZTdzT3JuM2w4UGVQVUY4NGdwd1lSZ0h2UHFG?= =?utf-8?B?QWZIaGZCTWJlZEh3VjRVV1M3WjRSalBnSVRDY2tkRXozTW9ndjNKR0JCcVNP?= =?utf-8?B?VTJVWThicFJYcTBOQmVxOEczcHdIb2xzLzEyYWFaUUxjclN0eExtVTdpRlNY?= =?utf-8?B?cDhJTGVoN2w1NFZQQTgxalA4VU9MdDBiYk1lY2kybksyalJnR29mUVRWSHZB?= =?utf-8?B?RUN6ejJnM211bHpzQVBRODJtcFQ2c1ZpVDR3YjhpRm9meXFZUVpCWnZDRlJl?= =?utf-8?B?RFJ4cy84ZEhicjhwWFN0dDZrc0tSZCtLT25TcndLWTBJdnA0QVdWYU0rT0xt?= =?utf-8?B?Z2xIcitWOU8yaGkwOWFhanZza3dySlhOMkVQcGVVQzI1WHgrQ3owZkVKSVlI?= =?utf-8?B?eVVNLzI1bU5rNUszZ2lZb2RVOFhmT1JpYjNhcUhyVGFqZXNYa0c1TEh4VXln?= =?utf-8?B?MEIrLyt5a2hobUVtM2NXWnJ3TXNUbFY2cVd1ZzAyZmVMUEhITEs1dVRKT2Rj?= =?utf-8?B?aC85c3lGbURJT0dMTlRVV2xUY2t6VDZzQ21Qd05wdkZLMVZuNVNBRUxabzNF?= =?utf-8?B?QitOV2xsRkRrUEVLMUxyczdId29ocUpTbE8zV0NGUk51Ny8zY2VHNEpqazFn?= =?utf-8?B?N3JRQ0R2QTNUV25NWndITXJYNDdsNDkvbzM4Q0FGajkvY0pONXFTM2tvWUxN?= =?utf-8?B?NUJhSFNUeE5KU1o3WEVZK2p4aGpkNzJoalljdlc2TzR1VDJJenYxdWd4ckxI?= =?utf-8?B?YWllcVlsS1ZpNEowUEZqZVJMUmU5TjhsQ0NIQlUrTmJmN0M3a1c0dVU0WEdO?= =?utf-8?B?blg5SzMrSTcrVmc2SlFLQjdmdEpLSkpXT1ovUDhjVUJlZkhhQVlHTFF0Umcy?= =?utf-8?B?WkdmVG5HRlRnTFpvaWw2NHMxTEdtQ1JBUU9MQzJ4V0JiZlpwYkVuMkVmNmQ2?= =?utf-8?B?UFZGSFhWZXovKytYUFpWblAxd1lFcWV5NTJ1bENjcmE5Z3FqRk00bmFib1RO?= =?utf-8?B?ZkFvQ0hKeTZXM3hmNUdTSW9RZ21UUm4vM0JBdVU4bW4vSnlFV0FrUXZsQXJG?= =?utf-8?B?VlNuNlVwc3Ywd3lodGxxUzI3UlpZTHZSUUxiWi9WRnRIVCt3QUg1ZGpDcjJv?= =?utf-8?B?K2dEQnRLMkdvNUxSWFcxbkxrTVEveXFwalUzWEVYSG9DYmJ0ZWFENnRZWU9J?= =?utf-8?B?WWhoL1RsOER4RTBZbkJBQmZSUmdWSEdlaGwwTGdEYldySDRKK2tJVkJxV2Ns?= =?utf-8?Q?LTYS+W5I85ydcbN1v7aIpTfRg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7300fe45-f032-4e02-af28-08db35b84fa1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 09:29:53.0767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2IRIf/GiaRdEAt0DW3uEtdID2aavXiR4G84KvzcY2dlns7dQLrFQK19Aqcs1MW9AWZJti50QgeKG3qp1DghTDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8037 On 05.04.2023 10:59, Roger Pau Monné wrote: > We should likely move the setting of vm_assist to the domain create > hypercall, instead of doing it at vCPU initialization. Perhaps, the more that setting the assist is limited to vCPU 0 init. Which in a way makes sense when considering domain creation, but it is odd for the case of vCPU 0 being brought down, reset, and then re-initialized; IOW I think arch_set_info_guest() should further have constrained the setting by a !d->creation_finished check. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 09:41:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 09:41:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518368.804828 (Exim 4.92) (envelope-from ) id 1pjzdK-0004Uk-TY; Wed, 05 Apr 2023 09:40:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518368.804828; Wed, 05 Apr 2023 09:40:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzdK-0004Ud-Qs; Wed, 05 Apr 2023 09:40:50 +0000 Received: by outflank-mailman (input) for mailman id 518368; Wed, 05 Apr 2023 09:40:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzdJ-0004UV-IC for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 09:40:49 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef39a336-d395-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 11:40:44 +0200 (CEST) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 05:40:37 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5195.namprd03.prod.outlook.com (2603:10b6:5:240::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 09:40:35 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Wed, 5 Apr 2023 09:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef39a336-d395-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680687644; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Lg5WL66Cxisvq0Y7xWdHEEoEbUlpjZjugaRK5I+aV/k=; b=hzZI/J3q3O12f8xcSWtw6wP7yYjuajU2TL1C36IQlBWYj0ApKnE/j69i 40Rw7iuPNZJi2xFcHqiIkAkikJqalhGzDnXiZkUnpVOoDW48VhOMmabMj NsZE77uTi2A/Dw7+2ioefaaQLhzxJB1Aw5d36S9MUrkrowiCHKDQB0Ozq U=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 106819497 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:H+DvbKLWOGC0tkDYFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENS12dUy 2oYWWrQb/iDNzb9eNsibo6yoUoBuZbQzd9qSgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRjPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lCEBN0 dwoBgkLSR6Km/CuzOuJVNdj05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv02L+WzH+qB+r+EpWi5r1U2QK86FAdCVoMWlWXsOWEkESXDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSNrmK2YTzSa7Lj8kN+pES0cLGtHaSpaSwIAuoPnuNtq0UuJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:FhMQ0KvYb5F/RrTRic1Vj8cN7skCM4Mji2hC6mlwRA09TyX4rb HaoB1/73SbtN9/YhEdcK+7SdW9qB/nlKKdgrNhTotKIjOW2ldARbsKheHfKlbbak7DH4BmpM Jdm6MXMqyOMbAT5/yX3OHSeexO/DFJmprEuc7ui05ICSVWQ+VY6QF9YzzrYHGfhmN9dOQE/F 733Ls2m9JkE05nH/hTfUN1O9TrlpnwjZf7ZhxDLwc/gTP+9A+A2frBCh2F2RVbeC9OxLpKyx m5ryXJop+7tu29yFv632vehq4m/+fJ+594HcmRjcpQDCvqhh3AXvUGZ5Sy+Aotpf2p6hIRsP SkmWZZA+1Dr0nJe32zo1/W1xL+3C0I43vvoGXo+kfLkIjCXTcnDMgEuo5DaBve7CMbzatB7J 4= X-IronPort-AV: E=Sophos;i="5.98,319,1673931600"; d="scan'208";a="106819497" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nilq3Neu6MV/8GAvmrJwQYMu+/2UeiiSQi3Daacq+/5pk1yK9xekFlIkzXbZTuzpjWm4ohTrCJgwqBRONqpvwj2lmF3xS8+x7oIp0fFGDadxkjkAmMpsLBX6DuqjeYLJeCq7sZbRDqeZIfqhN2yrpHqOXaizo3TGITM/xeRxuEFfi5+Em4lEp6aS6cDY9J/zbhnK/RxLbt6f2z/imrmeuVRPNSFUBufFDI2UMfFjSjej1iheHKH0QpZV3ATzza69a0g9NuCN9olfckYMfWQAaSc1MX3xl43DYL2NWOSUF12CI8xfp4oDoaCLDlzAb5Bd9drgOP4uZhfw2UTryLCwpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=glMDDIPA9Olrwj9DPq4D9sJNv7NzFuBiUuVcNTR6e80=; b=APKEV0hloO0/ehkM0yydxWyZdBS+QvvdnL6iHYP8vXWku+zvdchmif1zYz99lMIsiDAXSlECG1fA5FjTIxkpGO8vQaVOjj31r3CeF4SD4DnnQAyx5FD1PxsHzF8K/HBuX4FT/+oY0TP2Tr4osTutSumrYRtDQpEJLw7LBTFF+yg2uO0YoHcudW7jxuc1PcH9+VGybBVVe+PoXDfYG15mWSjr+f0TMtMHZIk25aeP3ClflNplHctoTAgUqiHMpRCopYQmy0rhWBn5Y7mUVZhO+EbgFu3qYd+4D9noJQMSysuCqw7zvENDsgsxuXvfYFh+2ix+G2+fb7fVsH4RBEqaMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=glMDDIPA9Olrwj9DPq4D9sJNv7NzFuBiUuVcNTR6e80=; b=DAeIalqQ6ha+6gwIGfD50S7a1himneV20yKWHCZv4lfL+GcfOfEVuoYDZvrf6wyBZ9fac0lBaegc+WA9uNS8W678iO7lczAu9yuAIEN9EYrUYWl8iSSgdQP2S7CA9+w90GoLS0FJK+I2v3HtYAZmp2S3T+5RvKZuqdHY5DlK1WM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 5 Apr 2023 11:40:30 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Message-ID: References: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> <3752672b-f4a0-5ffb-9759-dd315ce31079@suse.com> <5cda250b-57b4-2833-99d3-84ae8ca32059@suse.com> <83cc6b93-6a50-1eed-1588-20b3bc38c318@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83cc6b93-6a50-1eed-1588-20b3bc38c318@suse.com> X-ClientProxiedBy: LO4P265CA0159.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::9) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5195:EE_ X-MS-Office365-Filtering-Correlation-Id: 0172ef3d-80a3-4e2f-22dd-08db35b9ceab X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fTS6iAqLmtDEj67Qeq20fxoEeHNKcAMTGEpv97NE+A7xkpbIs9B8k3jZ5p7cecJ6qXMIOpRAgJKv9ZznIUjtBVbs9Gov5IFTgz0XAA0puPsvPE+MqX+P8GPp6HLQ+GeyQ2i71ITwmt2gxrWnC32vARGSo9y5GDnRqJ3at0IiZ6ZLu7YLqdpdffzdvLmXTBMcyFRKZu7sxfYVBmh3FZMNM9VhlQy8xcMTUq/pHCDpxoioQFhjfVe5HfbEI3i5U4guHbiK+n71GG5TZdaR6MR4kRuNXSjkhmriXZOGswOsXUyvPCNwfN5njoPieOi9m3hBQZFnGnOBx1nJtpdRqDEoFqAhWtEAJuvuKPpoINgGFqZ2Nv0K0ohTzHz0pahMZ+Xsz+r2RQopfiL779QRv2ihkUb87HxHaQ9M567dLSs0UO1slDSASKfnen0D3bqCusDAu9/0iAny3j2PV7qaVLlGdTBdSbHVXIa9H0ZqOkIHJAqJ6uvUBRksJ0aSbNS3RdVGRJWHGJIpU+Lub1K8/tnzNX7DjG90XlV6LuUtte1lQ7Bgd443rU4zhkQHXbgQcqfi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(396003)(346002)(39860400002)(376002)(136003)(366004)(451199021)(4326008)(6486002)(5660300002)(82960400001)(478600001)(85182001)(6916009)(8676002)(66476007)(86362001)(66556008)(38100700002)(41300700001)(316002)(54906003)(33716001)(8936002)(4744005)(186003)(66946007)(6506007)(9686003)(6512007)(26005)(53546011)(2906002)(6666004)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bENDcHVVYVFLdERmbFdUVzA5dTY5UFo1MWIxM3NVYWxGM1lkTllKaWM3YUtJ?= =?utf-8?B?MzdwYlp1dVBZTVJQT2VuZHp1dmF6QjI2aFJLWVNkV2R4cEVmK2lBMkN5RVls?= =?utf-8?B?dE41VTFxcXE2dWxickFiQTEyVUZPTUVlL2dTRzdiMUx5VTlWaC9OT3d5TU1G?= =?utf-8?B?UDZMODFQYU0zeEVrMUVWdzloWE8wWmZabm83TndITnBYck1adTBlb3N3NUhq?= =?utf-8?B?bk5tUXBmcTlXOXA2K2lBTzJnSGRTc0JLTE45VnpzeGNML0Q2a1Z4bm8yaDUz?= =?utf-8?B?L21UZFRXM3M3blJvQ3NENjl3bWY4STVVMFl5SjhQc2x2azk2bEJIT3dpNHk3?= =?utf-8?B?QlgycUxrTEFOUnB4cXlScG5YS1BkYUtSaEFPMmF6c2dPMVFnQTZTdGRVbU9h?= =?utf-8?B?bTZnb3pWOXgyMmpnTnQwaVhTNzVMT3JuZFlzVVZCbURqVWJRc3JXNytCeHRO?= =?utf-8?B?WFdvKzFWV2hnSnN2SmdyR1pqU1ZHOG84Z1Flb0Q4Z0VxOXplUmVlY1lzN1JV?= =?utf-8?B?TkpQb1RrOHMxMmhkV0NzRE84UGt4Z2pTcmxNai9UVHl2Z3QzeHBPNUdDenNC?= =?utf-8?B?QmZBeWI5WXFYdWNjdFZoMGx3K1RVSzlVQVY0RzBLNXcweUFLQ1huYkE1eFBI?= =?utf-8?B?L1ZSc0FlMWFVTnVSVkwyL0FNK0dkRmhDUHJac1dtRTRya2dyRUpjd0E2ZFFE?= =?utf-8?B?NkNhR0RlMXNnOS81OFE2R2JEV1F1eUdZeWdEWHd4N1ZQT3JJdkVTSEZtT0xw?= =?utf-8?B?Q0N3enhHcE9lMFowQVJCZDhIYmh3NFlkUnk4a3k5Yi9UTHlkenFyZUMrZjJG?= =?utf-8?B?VVBIZGxrVnl0UHlXWGtNekF4ZG80RG56UVZPbVNVWWRsQTFLMmpZNnJYMjBs?= =?utf-8?B?MGh5Q0JUME9RWXVUQ0F4cVJ3WE5yZm94UUt4ejJXU1FqNEpFZ21qZFR1OC9K?= =?utf-8?B?cFJBZEdvNnRGL3RXRllBWkZwNVV3eFJhZGJWbHlLMmJMTFFzUy91bEJQTGYz?= =?utf-8?B?elc4UUxtalI2M0NCc0w3UmMwcDcxYko5VngrZlF1TW1PaE9YaXI4eWcxeHds?= =?utf-8?B?ZElxZTA3SldpMy9uMnBrNXFzeXFPZHVHdE01alJvVUhMbTNIMlIvNWlqR2Yw?= =?utf-8?B?eEFjb1hMLzF1VGU1b2VvZmVScWxxMFFzVVdWaCtod3YvM2ZjbVMrNWdMQUx0?= =?utf-8?B?NnZmczllQUFIWk80YktST20xbWIyRzhZaER0ZjNIRURURHBmd0tsSXF0YXJN?= =?utf-8?B?R1UrYXZ0M3ZZL3BsclNvVk1CM3dFTW5HZ1hrWkVwM3lIWlc3dVI4aCtaajZz?= =?utf-8?B?Q2pvNCtvbTBwYmFjNU9WTHpSbUlaQml6c2Z5WHZDeXZxczBORjZYT0MvUzdG?= =?utf-8?B?bmRoY0hSU2RqS3NIbENsZWRZZzBMNHlYMC83Lyt1UUR2c2J4Y2xaOHRqUmVj?= =?utf-8?B?TVV0ZjlVMjkxakxGVmYvZnRLZ08vV1V4YXZESW5ScDFEOTJlUzJyZFEvaW43?= =?utf-8?B?clhNb0FqcXdrSVdPZysrY2orcHJkRnVMbHhRYTJ1dkJRSVdZdkpQMytzZkFL?= =?utf-8?B?dFVjQldGR2ZEVUEwNzNGZlZUR0p5OG9nOHNMdzRFSjdXQng1NnN2UnhEa1Ew?= =?utf-8?B?YVBNTVdHaEp0aVNkbEFHRjZtRmFwWFljcWhLMmx4Nk1rNjloZVViRm1rUU56?= =?utf-8?B?Rnp5U1c3cE9DWElkNGVwMGVyaERTY29DVDVrM25JUk03cUJRN2hMb3NlZkJB?= =?utf-8?B?VGpQM2FlZmtzbVU1a1ovcm81amNjUDFHQUhTUEFCREdKajdJbTVkLzlPV01K?= =?utf-8?B?WC8zMXU5cTkwQ29jbW1pUjFZalFTY0hnUEI3dUNsY0dKWjJtMVhZMjA2NDhN?= =?utf-8?B?T1hZMlBwMnVIUUxsMzFndHR0NUZyeXIwdmtCbXVJRC90Y2Nsd3NMZEtXL0Qr?= =?utf-8?B?c2docmllNmg0RTN6UGc4WEtEMFlPQjJQL3g0K2hSUGxpeWpITmFwR0pPTnh3?= =?utf-8?B?M3pzK3duVE0zbWhHMjFkVDkwSCtXMlFaWkVQN3pxVVZES05VVFFhNmVxU3ZT?= =?utf-8?B?dW9panpuSFIyOU5XNlBNeXJCVDRmbHU5d3gwV08vbDZYZVV4MG4vd1NpQS9M?= =?utf-8?B?bGhMTzhLdXVYa1FLYStXRzZUNmtvaE5RUlB6TXJmN1ZnZVFGS3Rpb2xQNXJp?= =?utf-8?B?bUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4rj4joOK95djKLYXW4ilqscTjL3Dfx6UOafqjbpDVPhNNIsWOf3bDxPE4tjPfQJ7lXDwiZ4nD89SulXlPavea0hjSSkWzTqHYs1t/9S2wUclNqju7wDnVtaM84/gRJ1BrgojPHQONfNUeNzp2PcOessR/2x9rGhrZALV938aNQ6GylOZLwkgEFBB/eILkdrZZ8DTaLUsntIFeTGcS2020o0fRzCxcvhkS0OZyZo93NFBtPZC8g3tX0Wjqq5F8EimhxT1ogwL02YGLlAe0lpS7H3vVQmXqlRKElv63Uj5H7x0rIGXAfawYB9JJwbU4YozLkIakHZIVP3DW1FdOeMYV6tLEtmcCukkir22R+wmjk33woTfApAJyfhd/F1h+baf1W/Sts/ge6FY/Bh52aby1u3mkcwArru6SGICLLziGeLzWkNGRYmVMju8csGMS0s1HpCTRTYT6ropuC9yrW36PuWJHBemWKWN19c8/7w3vUydbHOzTmKRF5Hj+an5mIjo/17Q0MUou/UXNxKnm/QM2MFQ0DjntGYSlsE/w9nS02efzyQlgd/ek63K7BStZqxwHngK0AGK14F+3KtrySPj2fJg362axzG8vbJMpUfHde9M30Pkt+7iI95JQ9yhmoHwWX38XdGmau5hWXk477J4PwtKnqBO1NNspDuJusn/HnUosUpvzXxACmqerD+69xZCjgUOqC40q8wIb0yUM8fLXX8YsYRZypsLSM1BXFJqR7o0jniiTjADt5K3C6vCMm8+soNBfJHC2i1V+cVSwd3TKlvddUds4XbNXTLPJhx9whNu7r4eOh8+GlNiqV6vdRbY X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0172ef3d-80a3-4e2f-22dd-08db35b9ceab X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 09:40:35.7015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GnKwD9Kayq0djQDEgPywh6RZLNE0F7G5BNYYAU1PRK7lX7dAKY0oUxaEt0L6PHmyrw/Fq/Y4K/XYc0aj7Z8DJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5195 On Wed, Apr 05, 2023 at 11:29:51AM +0200, Jan Beulich wrote: > On 05.04.2023 10:59, Roger Pau Monné wrote: > > We should likely move the setting of vm_assist to the domain create > > hypercall, instead of doing it at vCPU initialization. > > Perhaps, the more that setting the assist is limited to vCPU 0 init. > Which in a way makes sense when considering domain creation, but it > is odd for the case of vCPU 0 being brought down, reset, and then > re-initialized; IOW I think arch_set_info_guest() should further > have constrained the setting by a !d->creation_finished check. Maybe, but still the right fix IMO would be to move this into domain_create. We could add the !d->creation_finished check but that feels more like a bodge than a proper solution. Restoring the previous check is better than nothing, but it would be nice if long term we could get rid of the vpcu related conditions. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:02:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518373.804838 (Exim 4.92) (envelope-from ) id 1pjzxe-0007Xe-M1; Wed, 05 Apr 2023 10:01:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518373.804838; Wed, 05 Apr 2023 10:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzxe-0007XX-JM; Wed, 05 Apr 2023 10:01:50 +0000 Received: by outflank-mailman (input) for mailman id 518373; Wed, 05 Apr 2023 10:01:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjzxd-0007XQ-IH for xen-devel@lists.xen.org; Wed, 05 Apr 2023 10:01:49 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfee48be-d398-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:01:47 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id e18so35587146wra.9 for ; Wed, 05 Apr 2023 03:01:46 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id w7-20020adfec47000000b002cfe687fc7asm14532282wrn.67.2023.04.05.03.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:01:45 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1E04B1FFB7; Wed, 5 Apr 2023 11:01:45 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfee48be-d398-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680688906; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=xDFJjTGQNkjMjQaKDKrEsiOprP+3eY5rMht1R3BPmqI=; b=qJuUB8lXKPAV5az5FqyOzh/WnCwEbzeWlRe/pF6mMPsBue+wMOt4jrinivf9lbjUpj 549SQvsI4JEw1kWHpGuzNjjgtF2FaRY74NPXxJL3rebT/OBdwarrYv3hKyub+n6lHD+v W1KKhZQ8xjsJwLmRTzhw1Jk0CGJc9RwPZTQr83EK9C0L96NZNLAlfk8qH1mvrT1mhp9E V7+aPEI7hnb4bZ+spDvZL1hbXutqqILlju2OgGdfRbp7wMf7Tpzjfq2e+dBmEqUyZHIe XvGZlRwMbSL9yUBa64cqjZlqK/PQIpmHT+l9dqKQsfiMiQ0J67JYpgDz+eVq5o4Ks3H7 Semg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680688906; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xDFJjTGQNkjMjQaKDKrEsiOprP+3eY5rMht1R3BPmqI=; b=XYAdqiSk81kYEuDaSk/klKXTpwdJsJxKFhq960sQLqS1D4lKx3aUOG+xG07OPp6xBN M8ZVUgeuuA6yYDUxlBqxPtWTlW0CXPwM3AKna5y0a7E5Qj/0A9otXYwWVGij2xQCCHhV zaLO2f9TKNaKwDlqUtqHT6d4nd7tYLrmi1ayfiKlYwuTt2vRGkqNHt+RkRJxpGY916F5 6F4XLRgVju3J4yHI3sCFmIAGFPFSvXAGW1/kBAI7cOjdohP5t25WmCU91OFPqf9cfChd xpiw6em/C+h3vNSesQtZpRX/6telwnr9f4VZjtmUXDNjn6Fx4nYm4HYjNKQXfuXO6v0r 5sGw== X-Gm-Message-State: AAQBX9fC2FGlRvloSFXs4NYrxx5q+Jo0LpmzxfFN2LZ/VpDDwSTkcOtG SYuz59ZfTbPtiM5fWYXuOJSmyw== X-Google-Smtp-Source: AKy350ZtC2zcGgpmA1tObIYkI/B3t4R7tGoffPFGOXgc8gOET2D0kOgJ1A31FE4xklaO7MxIT2j8nA== X-Received: by 2002:adf:f1cc:0:b0:2cf:e67c:8245 with SMTP id z12-20020adff1cc000000b002cfe67c8245mr3708097wro.44.1680688905956; Wed, 05 Apr 2023 03:01:45 -0700 (PDT) References: <20230405080512.nvxiw4lv7hyuzqej@vireshk-i7> User-agent: mu4e 1.10.0; emacs 29.0.60 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Viresh Kumar Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, Stefan Hajnoczi , "Michael S. Tsirkin" , Vincent Guittot , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks Date: Wed, 05 Apr 2023 11:00:34 +0100 In-reply-to: <20230405080512.nvxiw4lv7hyuzqej@vireshk-i7> Message-ID: <87h6tulkae.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Viresh Kumar writes: > On 09-03-23, 14:20, Viresh Kumar wrote: >> Hello, >>=20 >> This patchset tries to update the vhost-user protocol to make it support= special >> memory mapping required in case of Xen hypervisor. >>=20 >> The first patch is mostly cleanup and second one introduces a new xen sp= ecific >> feature. > > Can we apply this now ? I have developed code for rust-vmm crates > based on this and we need to get this merged/finalized first before > merging those changes. I've queued into my virtio/vhost-user-device series so I'll get merged with that series unless mst wants to take it now. > > Thanks. --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:06:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518377.804847 (Exim 4.92) (envelope-from ) id 1pk01w-0008Ds-7G; Wed, 05 Apr 2023 10:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518377.804847; Wed, 05 Apr 2023 10:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk01w-0008Dl-4a; Wed, 05 Apr 2023 10:06:16 +0000 Received: by outflank-mailman (input) for mailman id 518377; Wed, 05 Apr 2023 10:06:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk01u-0008Dd-Qa for xen-devel@lists.xen.org; Wed, 05 Apr 2023 10:06:14 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7dc9ce65-d399-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:06:12 +0200 (CEST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-psKlu5H3NgSykp4d88qt7g-1; Wed, 05 Apr 2023 06:06:09 -0400 Received: by mail-ed1-f69.google.com with SMTP id c11-20020a509f8b000000b00501e2facf47so49642067edf.16 for ; Wed, 05 Apr 2023 03:06:09 -0700 (PDT) Received: from redhat.com ([2.52.139.22]) by smtp.gmail.com with ESMTPSA id k15-20020a170906158f00b00948cb15c642sm3154354ejd.42.2023.04.05.03.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:06:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dc9ce65-d399-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680689171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K7tqdHp0z7SrsceuGaqk3f4Dn2eBRCUCgxJHv4nhpXM=; b=M+8Y6JcufEf29RyWksXclCE/eIAMBOVfEv75cOKN5hZT4TCCohraVYKKtgw6V6okr/xCia 4OQQ138nMHjwltpcRq2cXsRcHce4wR7rSzrrbL9IFneEIfDGH3WaZ3Q7iP/BmSkQ/QMMtr AVg4vP/6pYP2Qcch+9+L1vrmUZzqy5s= X-MC-Unique: psKlu5H3NgSykp4d88qt7g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689168; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7tqdHp0z7SrsceuGaqk3f4Dn2eBRCUCgxJHv4nhpXM=; b=V4XSh60QqpVgWLj8Us8kDizNrW2iRvuofYSfbjirvgsS2nv80OGbKm0UO/kplnpG3C 5qaNlMPSlqvBoBW7rbw+3U5BAX8GasBczfJVl98K5V2eI99pX1t2lUkK0X7mRQFehuWp 4kqlSLTcE35HmeLuDjeqHfQTYtHeG3ERF2psyoxiPAwck1nC7G3C2LRVGGm5TbskfJvR +H0YIUmeFjRt7Q7gm0SFcLvkeIAOoTHBxxkAe13QSQvHvliiTojjjoyszecsal1a3nm1 aOhKFPt2lFt7IdcHSwMzw5ojhY2j29sIgVp/hZ+FvN7lj4elRF/7haEAWKoIoJDxRKB4 OlVQ== X-Gm-Message-State: AAQBX9c7qUP49SLF0NKEKbJD1/xtcg0Z8v0BrSRizPQov05OMENzhwe1 tuHUd6GWeuB6wjCdE4yUV0x/MDTEm3YlgZ3+tdCFHLFtsphrID+S7ah6j6E6v7hG1L+mPggOTVw LCitVesFXLv5irx8//w== X-Received: by 2002:a17:906:a254:b0:933:37f4:2fe0 with SMTP id bi20-20020a170906a25400b0093337f42fe0mr2333565ejb.46.1680689168547; Wed, 05 Apr 2023 03:06:08 -0700 (PDT) X-Google-Smtp-Source: AKy350Yf1A5XZK4oo80SHWAZ2GiHPkSEf5Qh7hmicDEC8A80aMGY6813loQHdU4+ZIZl0KypQH0u+A== X-Received: by 2002:a17:906:a254:b0:933:37f4:2fe0 with SMTP id bi20-20020a170906a25400b0093337f42fe0mr2333546ejb.46.1680689168281; Wed, 05 Apr 2023 03:06:08 -0700 (PDT) Date: Wed, 5 Apr 2023 06:06:03 -0400 From: "Michael S. Tsirkin" To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: Viresh Kumar , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, Stefan Hajnoczi , Vincent Guittot , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks Message-ID: <20230405060340-mutt-send-email-mst@kernel.org> References: <20230405080512.nvxiw4lv7hyuzqej@vireshk-i7> <87h6tulkae.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <87h6tulkae.fsf@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Benne wrote: > > Viresh Kumar writes: > > > On 09-03-23, 14:20, Viresh Kumar wrote: > >> Hello, > >> > >> This patchset tries to update the vhost-user protocol to make it support special > >> memory mapping required in case of Xen hypervisor. > >> > >> The first patch is mostly cleanup and second one introduces a new xen specific > >> feature. > > > > Can we apply this now ? I have developed code for rust-vmm crates > > based on this and we need to get this merged/finalized first before > > merging those changes. > > > I've queued into my virtio/vhost-user-device series so I'll get merged > with that series unless mst wants to take it now. Well the patches are tagged and I was going to take these after the release. Probably easier not to work on this in two trees. Still if there's something in your tree being blocked by these patches then Acked-by: Michael S. Tsirkin Let me know. > > > > Thanks. > > > -- > Alex Benne > Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:15:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:15:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518382.804858 (Exim 4.92) (envelope-from ) id 1pk0Ay-0001Tl-6J; Wed, 05 Apr 2023 10:15:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518382.804858; Wed, 05 Apr 2023 10:15:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ay-0001Te-1U; Wed, 05 Apr 2023 10:15:36 +0000 Received: by outflank-mailman (input) for mailman id 518382; Wed, 05 Apr 2023 10:15:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Aw-0001TU-Mt for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:15:35 +0000 Received: from outbound.mail.protection.outlook.com (mail-ve1eur01on0603.outbound.protection.outlook.com [2a01:111:f400:fe1f::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb2f1987-d39a-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:15:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7597.eurprd04.prod.outlook.com (2603:10a6:102:e0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 10:15:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 10:15:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb2f1987-d39a-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qy/7cb2mDISNV3/gwl2/8YwPzZfAY8CfbZ7+9ylJjvXoRBgM35AxFNuf1yu4CiS/wkm5GxSH8QgTDEWQslWM56XvC+l71GYx1aAbs0Us4NCpv8ZMMsal/FoOz5SwAEgCugNl3VN+VN4EsEMQWYvu5G7ZMqL6OnLIISv0v/RvjNmwa1K3x1q6MsFD6/5YisNVC23CoUK8Ny48wX4WErng96QDDALVAyg0iBjQwxnkfXnC20c9YnkpYcQi3ZsnOyKEZvyC6m4kax0E4Ru0FvjOsfJOXRd8+BI0gqgQscrS2fuZFXxBAMjow0drIXRYnXt3ApZCyKSeSlbHRyWbQaLBZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ia8dCuqc76h37XZyZZCOtQqagUqNbWQ4NOC/+flu5jM=; b=U3UDWhnesnxZ/llDrraQPi3wr6D0Nl/0WQUn+7Yrh0+/VXncI5C88VJKpLhJuBRjOic15Ib2Eu8rQ2LxY8nsqLHCrDtHRPA2uU5xRWpze/NonLb0gAMV5In5b13AFy8EqyN0L2rdKZ0xjo64Iyua+CGIS5gJsjJsHYS+ldPckHtT9Gj8AHXq+0zkLS1k1kI1MXyTtIdA8lk6OXG/+JGpNb/dE5fOMG/F5fW+ionaVZXSO8gmqWrv3m3UYU4x8COQsrj86SV/47vMxUgcHXYfs9KdJAXbjVCjIAJuNJ7qkOpPTp15vOWyeEhXfceBpd2NdNPVcOYukXJ/Q6pNHc9XQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ia8dCuqc76h37XZyZZCOtQqagUqNbWQ4NOC/+flu5jM=; b=u3rxKuPUiPGbuBDGztEkBbjx5GrWMMSEokpXejn9YYySnKg0Tz5HIO9r0tmN0u30jbhdv3OZRTrfblD4VO1zZvHAGr5CJfbs+JreqUj3vdPlmCtuxGiVqKSOQjJxMAPezF7U/OHskXM6Tkl7z58VPctkVMQtUPjzyO9txdpNtB8Jg+xGtyu93SeOtoIeiHcxz05zSFLL4eXaPJAMiu/uIRxgkYaAf+/t/gmg4HWxoyt2Ym/ZSuo9NkIKfNrN1mAlClV+3HgEhBcuzu7xvgtYXOpfC3DNojCz8lpn2Xg/z7mXx1ILpQKY8RsUxDohxkjG2Z/syJa1otlKtQFMaQmfOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2ee8a4b4-c0ac-8950-297a-e1fe97d2c494@suse.com> Date: Wed, 5 Apr 2023 12:15:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/3] multiboot2: parse console= and vga= options when setting GOP mode Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20230331095946.45024-1-roger.pau@citrix.com> <20230331095946.45024-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20230331095946.45024-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7597:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e1fdfc9-a63e-4a4c-792c-08db35bead7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fv2AMJeFHR4bWA1wnvx+09vle5+lbgWvxP1UsunTVEaXKZ+jYm9aNk0aiPKxYpglWoAkWsqk4kLSsG4JHpgCQ5e4DCTf36XRSkjnkpKjRpkMx7OhdDM+3lq7hokQraWrx895Tr+tE/HihpxMAVbXwP540YzR28vWfdx7GKmaFPXBMMbqmsAFcrBlNW+taYk2hwn4FjbL+tCBaiDcjC+lkCgEuwtro48PjsqP+cL+QCXDAi1HjRMgUd9f7uIt21VyceKd8//jLBbAcUnJWEvyiAV626Nu17c4ZYTsGvsOXvTe4jmRnPdsulmZZOU/4SP+iAUd7x0ukjnUTRzTwYtdP5sXlDSdrl64REjTeWqLziwww0b+bgaF022NpAyQOcn0yP7eg07gVucRKhW243JsFL33a0gIeUB56DhR192nh5QqfzjDyhDj+snEM0coQIPRS77vWneixbkTl0LV3A4BDmtCVhX3owa4ZmOL+ywNmdt0t20o4IlNLHlvGZpPsPDn03UKA7l3rYmiSlQ7cDK5fUcZ5K1VeUezVn7tc1UnnviB22mZrKr+PwxWDEQdmxHF2mkNptUTyiG9pdzdtwVb9+IW/j3xKelGYC2dLblW+zkQZ15mHjNioh0FnwG2HWXeCTA7VfqGb/ql2SWEAyNoDw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(2616005)(186003)(38100700002)(31686004)(316002)(6916009)(66476007)(36756003)(66946007)(2906002)(4326008)(66556008)(478600001)(41300700001)(54906003)(6486002)(6506007)(6512007)(8676002)(26005)(8936002)(86362001)(31696002)(83380400001)(53546011)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkFqNFdydWNKWU13c2FFRTRXZHQ4WmlZdzdMaVZPbDFtR0pVTitzV21yRzdM?= =?utf-8?B?amREcWdjcE1TenBTL2dxMnhpL3E4U1VjZGJGMGhKamQvUmtBMGdNd2NYVTNu?= =?utf-8?B?bVlWV0lCWUo5eHVvN3NIbkVueTcyTmdNY0lwNGloWjMzcHJ5TU1kcnFUcDdv?= =?utf-8?B?dXpTUzh4dmgwUm1KMjViUklWUmpPM2ZoMktqQlh6UlFvRGJVc1kxQWZ6S1Rw?= =?utf-8?B?VWc2OGNNcDlaVDkrWW5LTUFhM1BBRFJxNWZUWkNYQ0tIU3QwbUViVVhORHFG?= =?utf-8?B?VlBtQU9Lc1ludU9xQ2xROVJzMGc0TjdhNDdsc1hocmFjSVBrbXRCUG50ZG9y?= =?utf-8?B?NkJPL3VtVk5URVhHS0I4cUg3dVhSSWxWY0VvUmQ3a3J1V2h1QTR5K3dsSGl1?= =?utf-8?B?OFZoSjBjbjZmcDRwNWo5VXo4MWl1NWJLZE5WaENEblA1UzJXbm5tYzZRbVRk?= =?utf-8?B?RTUyOXJzdnpmTHRKLzBlRWROMHMvKzRYMEExNlV1R2dDSzFnb3plRThIVFpH?= =?utf-8?B?cmw0VG5YcENjNnZrUEFBYWQxN21JU2l0NTJZMGxsQ3QxNzgvZE9aV0RSMG9L?= =?utf-8?B?Uk9mOER3UmdzZm9sZmI2dWxFWlN6bDBNcjZwNDZYSG85VzdMMitYVFB2Mm1s?= =?utf-8?B?TVhsczQzZVhGcWErWHhFcnpHeXVlMWFFWnpNVTc2S2hLZ3J1SzB4bjBzVWpI?= =?utf-8?B?WVlZQTNUMDgrWmk1R0ZTQld6Ty9DcnpHNXk0WHdNdGUraCtiakpocGZtcytk?= =?utf-8?B?N0JOVTZNYUVQSitJU3NlV3VaNVI0Mzh4b1JRSVczWGpuRTk4bzlxTnp5SlJS?= =?utf-8?B?eVl2Z1d0cHQ5NVhlTXY2c042dTJ4NXpmSjdVVkg1cVdFUjZVR09uV1NlZitu?= =?utf-8?B?RStMZTRuOWtLTHpkeWw0Ynd1aTUxaExrTUZ1ZXdUVU1GZjRwcWJpWnQ2NGJL?= =?utf-8?B?SmJoWElzbjAzdytzQncrRlp3d2JoejdlRDgyVVVaS0V6TC9oVHY2Q0ZHUFJs?= =?utf-8?B?cHV2TFZHUDN5c1RkT0Z1dFkvblVBVTRCQ1ZUM1FJcFB5VGp5QmhVbVN0cy9v?= =?utf-8?B?c1dQakpsYUszeEJnQ2JKT2h5cElVMGRsRlZ2TkgvM3ozWXNkSzhVcTRMdWh6?= =?utf-8?B?cEZGbVR6Z2xIcTBGNkNWU1FyTHhieUZKb3VZVmVqcVlJRElUcGdYRERZT21z?= =?utf-8?B?cjBoSFJjaWZESXltcHdTaVgrRWhDWG9RWEYrdkdLL0JsdDJuSjRFSDl2MTFT?= =?utf-8?B?NU0xeVVzR2pwZXkyd3F4dGE0amZNMitUVTdFTElNVUZXMkdWdUI4VWxzZGFp?= =?utf-8?B?Tm5Ma3diWFRxUnFMQTZGLzNoVHF5Tm1KOEtHMzhtYWxsN0kzOUJVQVoxcFZO?= =?utf-8?B?MkRjYzl1UkRNeWhGQzVWOGpEQmRIdWxTUGIwTjdiaDZsQmFaTjJnVmVWcHhR?= =?utf-8?B?N3E2ejU3WkE0ZThkdE51MjVYZk9LRjdlaS9xZkxBR2JycklWNGxlNTcrUDNN?= =?utf-8?B?Y21QNHVuMmNleE9aa0E0UEVyb042M1NKRWFWNWgxVlo2bUR0RVZHV0dXT3FE?= =?utf-8?B?cEwxZlFsb25XRDJyclV1Z0w4eTkzYWJ1VHJNUFh3MlMxV2lRbmJjV3pRdktJ?= =?utf-8?B?R3V1dEgvRGRad1E2N3NiNWdNSHE4M2RHb21MeXB0V1JrcEFwekY1SWhsMkhi?= =?utf-8?B?MTlEK3l0TmRJYXFJL01FckhpWUd0R3hLV3BFVUM4cUh1SmZzUGJWcFZmMy9L?= =?utf-8?B?cTA3ajVWTzlFcmVXd0VPQmNrQkRsbUF0citYSDViWi9YQ0pFMGxKWTRTTkRW?= =?utf-8?B?MDhlYnJJdGQwcStZb25DcHFqZkUyMGRxUlhoeVV5bzAvby82dFNBaUhLMUhh?= =?utf-8?B?dlNVQUluaEdYM3Erdlk1SmpDOGdpVUJMYTdCanRuTlNrRlUwanFEVzhMOHRT?= =?utf-8?B?ZXlKZUppMnNZem9wd2F1d25UbXhvVjd3SkZ6NURNNlZraUh1QUJNdHR3Mm1N?= =?utf-8?B?dmRrZ3lHeWRwWGlYSEVDYVkwTTVLVUJ2V0J6ZkFDeXVDTm1yeGo1TDl0cTJH?= =?utf-8?B?ZUlFR2RFT2k1VWVPZzFOMXlUMjk2Slhub3ZscG1DYXo4MHRpTXpiYWR0Vmx4?= =?utf-8?Q?WjjZ3XDlD+kGveY1kYuIoykd8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1fdfc9-a63e-4a4c-792c-08db35bead7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 10:15:27.5458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sydkG/s6kdfCO/9vSw9pbDJcF2L5d8r4bxJA9Z9QJ63QXMmO1rHNk0CjIViKVr6+Dt9y0NEQcsCRf5SHLD0i5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7597 On 31.03.2023 11:59, Roger Pau Monne wrote: > Only set the GOP mode if vga is selected in the console option, This particular aspect of the behavior is inconsistent with legacy boot behavior: There "vga=" isn't qualified by what "console=" has. > otherwise just fetch the information from the current mode in order to > make it available to dom0. > > Introduce support for passing the command line to the efi_multiboot2() > helper, and parse the console= and vga= options if present. > > Add support for the 'gfx' and 'current' vga options, ignore the 'keep' > option, and print a warning message about other options not being > currently implemented. > > Signed-off-by: Roger Pau Monné >[...] > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -786,7 +786,30 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) > > static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) { } > > -void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > +/* Return the next occurrence of opt in cmd. */ > +static const char __init *get_option(const char *cmd, const char *opt) > +{ > + const char *s = cmd, *o = NULL; > + > + if ( !cmd || !opt ) I can see why you need to check "cmd", but there's no need to check "opt" I would say. > @@ -807,7 +830,60 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable > > if ( gop ) > { > - gop_mode = efi_find_gop_mode(gop, 0, 0, 0); > + const char *opt = NULL, *last = cmdline; > + /* Default console selection is "com1,vga". */ > + bool vga = true; > + > + /* For the console option the last occurrence is the enforced one. */ > + while ( (last = get_option(last, "console=")) != NULL ) > + opt = last; > + > + if ( opt ) > + { > + const char *s = strstr(opt, "vga"); > + > + if ( !s || s > strpbrk(opt, " ") ) Why strpbrk() and not the simpler strchr()? Or did you mean to also look for tabs, but then didn't include \t here (and in get_option())? (Legacy boot code also takes \r and \n as separators, btw, but I'm unconvinced of the need.) Also aiui this is UB when the function returns NULL, as relational operators (excluding equality ones) may only be applied when both addresses refer to the same object (or to the end of an involved array). > + vga = false; > + } > + > + if ( vga ) > + { > + unsigned int width = 0, height = 0, depth = 0; > + bool keep_current = false; > + > + last = cmdline; > + while ( (last = get_option(last, "vga=")) != NULL ) It's yet different for "vga=", I'm afraid: Early boot code (boot/cmdline.c) finds the first instance only. Normal command line handling respects the last instance only. So while "vga=gfx-... vga=keep" will have the expected effect, "vga=keep vga=gfx-..." won't (I think). It is certainly fine to be less inflexible here, but I think this then wants accompanying by an update to the command line doc, no matter that presently it doesn't really describe these peculiarities. Otoh it would end up being slightly cheaper to only look for the first instance here as well. In particular ... > + { > + if ( !strncmp(last, "gfx-", 4) ) > + { > + width = simple_strtoul(last + 4, &last, 10); > + if ( *last == 'x' ) > + height = simple_strtoul(last + 1, &last, 10); > + if ( *last == 'x' ) > + depth = simple_strtoul(last + 1, &last, 10); > + /* Allow depth to be 0 or unset. */ > + if ( !width || !height ) > + width = height = depth = 0; > + keep_current = false; > + } > + else if ( !strncmp(last, "current", 7) ) > + keep_current = true; > + else if ( !strncmp(last, "keep", 4) ) > + { > + /* Ignore. */ > + } > + else > + { > + /* Fallback to defaults if unimplemented. */ > + width = height = depth = 0; > + keep_current = false; ... this zapping of what was successfully parsed before would then not be needed in any event (else I would question why this is necessary). Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:18:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518389.804868 (Exim 4.92) (envelope-from ) id 1pk0DZ-00026V-Ik; Wed, 05 Apr 2023 10:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518389.804868; Wed, 05 Apr 2023 10:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0DZ-00026O-Ff; Wed, 05 Apr 2023 10:18:17 +0000 Received: by outflank-mailman (input) for mailman id 518389; Wed, 05 Apr 2023 10:18:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0DY-00024X-0j for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:16 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d2ca14d-d39b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:18:15 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id n9-20020a05600c4f8900b003f05f617f3cso2518425wmq.2 for ; Wed, 05 Apr 2023 03:18:15 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id t16-20020a05600c451000b003ef66c89af0sm5203608wmo.0.2023.04.05.03.18.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d2ca14d-d39b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R3c7APLhxJFNCqIErCGS2nhF3aw+HLHuokeVO/lFk00=; b=OBiO/iyMPp7HhyBZcX7fJgp2AA6LNBmXbyqspQfxTpbw5ifIhJkHachSnVGxiHum7T pDyTjdZU/TDYDH8YqIYCNPP2VKdx3wdUBLlBxM9gzo34nXlEfQws3UH3CuMpU0XuvBtJ BR0Y9rfffghCpUn3Lq722SfA08hTOExgU+rQvnILo+j+5Ft88ticBqenXwg5p/GlGvca 41krEivQExeKbzC6OcydV1hPviKH9pwe4ul7G2ol7M0QTifUHh3PLePZ/6n5cypktE9F 2KVXZ7OB0raOVG9XCJUMp3dAf1zpvJiqWUaGdW48AgcrjBnZSMXe3CucyEtdxru47k5Y KTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R3c7APLhxJFNCqIErCGS2nhF3aw+HLHuokeVO/lFk00=; b=02+2NsZRj3ClHmrk2mN+2kEpRFejs3Hr7gcidK/z/jKApKg1J0cBk8FJ3L0HO1XpUL U18pr8UcZg9HJ7EErCmhh2HxtxS01X7YNxoGl9hhks/Z7DQEbYMrOQWMw/Vkrdn7qP1W mLAl590KJXd4EbSVxY/pY4HGB11lZo5P/7KldgVnexFnA/o568y5moafCHWgZaUDZrCH S2WoqYfWmoFIJQdywrhD9GkxeXHrkhkv+DUx4Vg1kF3f8fT7/gL1YtCbbXblDfJnOQQo eBag7eNHedLxFJ4RYwuXf4fTPEn4kpBlhxQbBkfYzR4u5QUvtuFtejOmRIVnwsthISai gJlA== X-Gm-Message-State: AAQBX9dxAXx/87IUkGCQaxOIBAJNtSRgL1oWfFsc1o6K/byLElVut8eg pWoulLeD6kRRcXx3hmPp6AVq0g== X-Google-Smtp-Source: AKy350Ybve9k60nXpw2N7+saf2pFb1rgNJYM8Jf0Z78V3ulPWVpu1aVqOeAnHikWi6TcyhWdL0mjyg== X-Received: by 2002:a7b:c4d3:0:b0:3ed:551b:b78f with SMTP id g19-20020a7bc4d3000000b003ed551bb78fmr4181570wmk.4.1680689894558; Wed, 05 Apr 2023 03:18:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 00/14] accel: Share CPUState accel context (HAX/NVMM/WHPX/HVF) Date: Wed, 5 Apr 2023 12:17:57 +0200 Message-Id: <20230405101811.76663-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit This series is part of the single binary effort. All accelerator will share their per-vCPU context in an opaque 'accel' pointer within the CPUState. First handle HAX/NVMM/WHPX/HVF. KVM and TCG will follow as two different (bigger) follow-up series. Philippe Mathieu-Daudé (14): accel: Document generic accelerator headers accel: Remove unused hThread variable on TCG/WHPX accel: Fix a leak on Windows HAX accel: Destroy HAX vCPU threads once done accel: Rename 'hax_vcpu' as 'accel' in CPUState accel: Use a typedef for struct hax_vcpu_state accel: Rename struct hax_vcpu_state -> struct AccelvCPUState accel: Move HAX hThread to accelerator context accel: Allocate NVMM vCPU using g_try_FOO() accel: Rename NVMM struct qemu_vcpu -> struct AccelvCPUState accel: Inline NVMM get_qemu_vcpu() accel: Rename WHPX struct whpx_vcpu -> struct AccelvCPUState accel: Inline WHPX get_whpx_vcpu() accel: Rename HVF struct hvf_vcpu_state -> struct AccelvCPUState include/hw/core/cpu.h | 11 ++--- include/sysemu/hax.h | 2 + include/sysemu/hvf_int.h | 2 +- include/sysemu/kvm.h | 2 + include/sysemu/nvmm.h | 2 + include/sysemu/tcg.h | 2 + include/sysemu/whpx.h | 2 + include/sysemu/xen.h | 2 + target/i386/hax/hax-i386.h | 14 ++++--- accel/hvf/hvf-accel-ops.c | 16 +++---- accel/tcg/tcg-accel-ops-mttcg.c | 4 -- accel/tcg/tcg-accel-ops-rr.c | 3 -- target/arm/hvf/hvf.c | 70 +++++++++++++++---------------- target/i386/hax/hax-accel-ops.c | 5 ++- target/i386/hax/hax-all.c | 26 +++++++----- target/i386/hax/hax-posix.c | 4 +- target/i386/hax/hax-windows.c | 6 +-- target/i386/nvmm/nvmm-all.c | 38 +++++++---------- target/i386/whpx/whpx-accel-ops.c | 3 -- target/i386/whpx/whpx-all.c | 39 +++++++---------- 20 files changed, 123 insertions(+), 130 deletions(-) -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:18:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:18:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518390.804878 (Exim 4.92) (envelope-from ) id 1pk0Dh-0002OR-UE; Wed, 05 Apr 2023 10:18:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518390.804878; Wed, 05 Apr 2023 10:18:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dh-0002OK-QG; Wed, 05 Apr 2023 10:18:25 +0000 Received: by outflank-mailman (input) for mailman id 518390; Wed, 05 Apr 2023 10:18:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dg-0002Na-Et for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:24 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31729cae-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:18:22 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id t4so30403161wra.7 for ; Wed, 05 Apr 2023 03:18:22 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id a12-20020a056000100c00b002cea8664304sm14500312wrx.91.2023.04.05.03.18.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31729cae-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y5W5kRucCzOBlp3KNoaJLlOhdcHcmgdcoSudurkJOAU=; b=YvdDHGNJmJITr/TCaBwa+nNTBQzwFo4m9pQoqmbmi3vaFmhxmN+kDfHXTlih7hjOuG i5foQd722oTmMrBj+Hnn/y+vSEYHeAfBNU8qFxNsz637G6z7vjp3C2UAjRMomPmXSt6B 8zPBf0Ips8vfVnHZNtgCTbmeRiHGsNV5SUfNvKV2SqM3fJYcuc7ImyIhwyWRK6Hj9a9X +Js3FJbT2ARj2FgCtaCnNeF4Yijhd95peS0BiCwqBd/BuWcL+6seYLzsD3aU2CENQUwI ovnk8urTgfiCLVoqgt1J2QmQfKLKfpa8JYktu83jlKdtgVQauBcK79zdBkzhpVPSX3Ka StWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y5W5kRucCzOBlp3KNoaJLlOhdcHcmgdcoSudurkJOAU=; b=yID/JQcz4IvI6Uf+RrQrUUjq6My/2RFP5113Ru96WPQdsmAevaGOwvHbizsVNtrOlN 0GcG2wg/trt7QUqZcV2qJtRcfAX0z1ax1KEYQhHduq+LnHBM7s/PUnTxlz52jAShZVhE i2k6mZUGtL6bWDwu9Auqq6Edis3ntcl2iIKpnjDw/TFi+y/txrimNWdLlr97EVo5RYsM aYxB8vo8y8EL6ycGNdFCFKE2lS3+pUxfWMFHOUIx1Q1+QchugOxQI/myVpM7FORseTKX cocv1T33yFmNOtKGinSw4MMYvz+hdkrTo3wpoFV0KfFt2JvFZQGlbhY8DNwCVaIr4i89 /Cyg== X-Gm-Message-State: AAQBX9cYvSyiIyLdA85ApxGxouWGZ3KfbxuncfU5LLdw2KB78dt0fCR5 gu4ES9iY/Avv+Zy9g4i9eX1HXA== X-Google-Smtp-Source: AKy350bpxg4IrwdUQGHpIVdGoidA/+sCsrkONX9FyvsEM868pIe4QiJWHCOtkMTvKUMsoYziJ+Rgdw== X-Received: by 2002:a5d:44c2:0:b0:2cf:efd7:2f1d with SMTP id z2-20020a5d44c2000000b002cfefd72f1dmr3851096wrr.13.1680689901758; Wed, 05 Apr 2023 03:18:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Reinoud Zandijk , Richard Henderson , Sunil Muthuswamy , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: [PATCH 01/14] accel: Document generic accelerator headers Date: Wed, 5 Apr 2023 12:17:58 +0200 Message-Id: <20230405101811.76663-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These headers are meant to be include by any file to check the availability of accelerators, thus are not accelerator specific. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/hax.h | 2 ++ include/sysemu/kvm.h | 2 ++ include/sysemu/nvmm.h | 2 ++ include/sysemu/tcg.h | 2 ++ include/sysemu/whpx.h | 2 ++ include/sysemu/xen.h | 2 ++ 6 files changed, 12 insertions(+) diff --git a/include/sysemu/hax.h b/include/sysemu/hax.h index bf8f99a824..80fc716f80 100644 --- a/include/sysemu/hax.h +++ b/include/sysemu/hax.h @@ -19,6 +19,8 @@ * */ +/* header to be included in non-HAX-specific code */ + #ifndef QEMU_HAX_H #define QEMU_HAX_H diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index c8281c07a7..cc6c678ed8 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu/kvm.h @@ -11,6 +11,8 @@ * */ +/* header to be included in non-KVM-specific code */ + #ifndef QEMU_KVM_H #define QEMU_KVM_H diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h index 833670fccb..be7bc9a62d 100644 --- a/include/sysemu/nvmm.h +++ b/include/sysemu/nvmm.h @@ -7,6 +7,8 @@ * See the COPYING file in the top-level directory. */ +/* header to be included in non-NVMM-specific code */ + #ifndef QEMU_NVMM_H #define QEMU_NVMM_H diff --git a/include/sysemu/tcg.h b/include/sysemu/tcg.h index 53352450ff..5e2ca9aab3 100644 --- a/include/sysemu/tcg.h +++ b/include/sysemu/tcg.h @@ -5,6 +5,8 @@ * See the COPYING file in the top-level directory. */ +/* header to be included in non-TCG-specific code */ + #ifndef SYSEMU_TCG_H #define SYSEMU_TCG_H diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h index 2889fa2278..781ca5b2b6 100644 --- a/include/sysemu/whpx.h +++ b/include/sysemu/whpx.h @@ -10,6 +10,8 @@ * */ +/* header to be included in non-WHPX-specific code */ + #ifndef QEMU_WHPX_H #define QEMU_WHPX_H diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index 0ca25697e4..bc13ad5692 100644 --- a/include/sysemu/xen.h +++ b/include/sysemu/xen.h @@ -5,6 +5,8 @@ * See the COPYING file in the top-level directory. */ +/* header to be included in non-Xen-specific code */ + #ifndef SYSEMU_XEN_H #define SYSEMU_XEN_H -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:18:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518391.804888 (Exim 4.92) (envelope-from ) id 1pk0Dm-0002gl-6A; Wed, 05 Apr 2023 10:18:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518391.804888; Wed, 05 Apr 2023 10:18:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dm-0002ge-2x; Wed, 05 Apr 2023 10:18:30 +0000 Received: by outflank-mailman (input) for mailman id 518391; Wed, 05 Apr 2023 10:18:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dk-00024X-Nw for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:28 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34ea1565-d39b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:18:28 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id m8so9666674wmq.5 for ; Wed, 05 Apr 2023 03:18:28 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id ay8-20020a05600c1e0800b003edddae1068sm1744815wmb.9.2023.04.05.03.18.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34ea1565-d39b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z3PbVXrARru//womsk1QFTfUC/jT1xFpRBIRhWzNLeg=; b=c4FFRXSdAKN2IWwtiqV7Ffzer7xJF5apMUkKlQiTaxUK2YipBsMKVqtP9PC9OjOLHc rMq0iWLrZJBM6oJj3ZcxNuV1npeN62fnwpOyTCL/NyjHhKWn4eE/PATJuuf/ffKK2NvR l5O6MKTRN5ifGk9nigJmitObdfRL5i9btUsj2E5xzt7sy+nX/kRuir/iAaexJdDqUFJg 4racwp2lla6NgRk1CkowemsGQ25lhbtxKUZ69OG2cP31L9IIwSsFNGT7+hn7ucd+REZe bpReBOAvbbifyVLiPMUCDSGVvfBSE6MFot4sUTf8DSomPdPCaRK9s3qVOS+XAggbGFny j31A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z3PbVXrARru//womsk1QFTfUC/jT1xFpRBIRhWzNLeg=; b=VB59JqOIqaDXPClAXUimm8p7iDootZNKVZg2JAL1vWCxo34vMwlvKU2Km/j4M+XAc+ dSjcvErBoeALjA53npzx0q7IYUD9X76zQel7XFigb5JIl0scoBUQ3fFg5DOQaJRQgIn9 W6FYkBezEGfrXDSyN6v+MqKVdnr68xojRPPhpVg80K5fzgJOXbqfJa0cCVzfDt//kEwG 7LzTclcd73syOm4486bI1WzinO4Exh/TCnG5lMCIKnhxNfHEKcpft+n95Y20e+HeMJCd IWqpMjPyCQZGTPiLd+I4HzrS7SgeV+HBZdJiRqPUHH4mbwVhCniBjH66TL1JNeZwnuai aqVg== X-Gm-Message-State: AAQBX9cOObw1G6AfPvNJu1tLR8n+krWwC7zrw4+y67mVYYmoRQ95MCuX TgsILXMnCNpTzpqzY35MYBh82g== X-Google-Smtp-Source: AKy350brt1TNZ7pG57+pZfUAcAl5eE1plZdTvYqjEnxz0kMrxGEeLijqmQ0ROub7VB7ZqCDrKQfQFA== X-Received: by 2002:a05:600c:2942:b0:3ee:4ee:bf73 with SMTP id n2-20020a05600c294200b003ee04eebf73mr4220330wmd.24.1680689907651; Wed, 05 Apr 2023 03:18:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Sunil Muthuswamy Subject: [PATCH 02/14] accel: Remove unused hThread variable on TCG/WHPX Date: Wed, 5 Apr 2023 12:17:59 +0200 Message-Id: <20230405101811.76663-3-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Windows hosts, cpu->hThread is assigned but never accessed: remove it. Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/tcg-accel-ops-mttcg.c | 4 ---- accel/tcg/tcg-accel-ops-rr.c | 3 --- target/i386/whpx/whpx-accel-ops.c | 3 --- 3 files changed, 10 deletions(-) diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c index d50239e0e2..19cfb26c02 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -152,8 +152,4 @@ void mttcg_start_vcpu_thread(CPUState *cpu) qemu_thread_create(cpu->thread, thread_name, mttcg_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); - -#ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); -#endif } diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 290833a37f..dafff71530 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -291,9 +291,6 @@ void rr_start_vcpu_thread(CPUState *cpu) single_tcg_halt_cond = cpu->halt_cond; single_tcg_cpu_thread = cpu->thread; -#ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); -#endif } else { /* we share the thread */ cpu->thread = single_tcg_cpu_thread; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-accel-ops.c index e8dc4b3a47..67cad86720 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -71,9 +71,6 @@ static void whpx_start_vcpu_thread(CPUState *cpu) cpu->cpu_index); qemu_thread_create(cpu->thread, thread_name, whpx_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); -#ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); -#endif } static void whpx_kick_vcpu_thread(CPUState *cpu) -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:18:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518393.804898 (Exim 4.92) (envelope-from ) id 1pk0Ds-00036C-Et; Wed, 05 Apr 2023 10:18:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518393.804898; Wed, 05 Apr 2023 10:18:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ds-000365-AP; Wed, 05 Apr 2023 10:18:36 +0000 Received: by outflank-mailman (input) for mailman id 518393; Wed, 05 Apr 2023 10:18:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dr-0002Na-Sm for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:35 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3893df93-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:18:34 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id y14so35677419wrq.4 for ; Wed, 05 Apr 2023 03:18:34 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id d9-20020adff849000000b002c56af32e8csm14637033wrq.35.2023.04.05.03.18.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3893df93-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E6NW9VhhS5fLeVwZeTyWWyTbAHfvPOC/r0zI8X/AYhw=; b=FrtFKE2hFxCwSIOxwL7fJNJgclFtRZYFCKSwPQeumlgt6bklL8ZJLOhaxRanBaGmBN sSSdwoBuo0PWQIPC5aVYpH3V4lrlZrxSnF6ec08aPzNngc+4NCJth/v+YEXjEI5hAYZ7 deplHkaFXLIdswcAyfQjoGU7HHGPGzJHJzztDL7n6LAkZeMYnyvPoi+3fXYTgBgP5XWs cPr7wmMyCDh4HsAHrXF/xlBABJq7EFQwNi0Rj4haWnYMHlXIAYY+Lsa8OGwO4Mt6ZR/d e7uyZyaesG4XjKKufoRM2SpXpgdAnFrSp25xtnMkjXzs/M6Ow7DNjd1C6Ovjn8q1Umho 74DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6NW9VhhS5fLeVwZeTyWWyTbAHfvPOC/r0zI8X/AYhw=; b=QlO71eGYcc4/A839ZcUOtT1xhGgo6p6sBc0/SoL0yHAzIMQ2534YlBNBp/v1Tr4fai s3vVURIQcv4z0XHckrG+VVXXPGJ3guwo0ZYGtzdlP/F9OslCrk7a6uBWuLwPH3IFiRca Qmq3DXvB57qGFi/61LUjorru7kUl/50Y/OMz8j8tOf4MJIk8el54lkBT8Rv+aCPNuNu/ sXErcQeE+Chm3WRn/e1NHkM6aGfufph5Ci7HvR1BFJAEIp+ApEOifPcEB52ZxOt7NFjP O5KaYAgTE8DzLW/6tkpvcuiZ41x4EPYz59oomc7JclN1ipEOlpkpR83VtMQfuRIHYnGn 3O2g== X-Gm-Message-State: AAQBX9fEhyJijfAKsl7+kEZRdXE2m0VA9xBYCVwsI0j8AW0RQfIUgtT9 OxitiO7hgJWadZg4vPhur9TgRQ== X-Google-Smtp-Source: AKy350YkinPPwbt/c64vUzk9lM4SXacH8xjrAIzv8V1BeCK80tQHniLUzIE+5w/+4XbN335yprpGWw== X-Received: by 2002:a5d:4d11:0:b0:2ce:9819:1c1e with SMTP id z17-20020a5d4d11000000b002ce98191c1emr3913343wrt.30.1680689913858; Wed, 05 Apr 2023 03:18:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 03/14] accel: Fix a leak on Windows HAX Date: Wed, 5 Apr 2023 12:18:00 +0200 Message-Id: <20230405101811.76663-4-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hThread is only used on the error path in hax_kick_vcpu_thread(). Fixes: b0cb0a66d6 ("Plumb the HAXM-based hardware acceleration support") Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hax/hax-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index 3e5992a63b..a2321a1eff 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -205,6 +205,9 @@ int hax_vcpu_destroy(CPUState *cpu) */ hax_close_fd(vcpu->fd); hax_global.vm->vcpus[vcpu->vcpu_id] = NULL; +#ifdef _WIN32 + CloseHandle(cpu->hThread); +#endif g_free(vcpu); return 0; } -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:18:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:18:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518395.804908 (Exim 4.92) (envelope-from ) id 1pk0Dx-0003Yv-Mj; Wed, 05 Apr 2023 10:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518395.804908; Wed, 05 Apr 2023 10:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dx-0003Ym-Iu; Wed, 05 Apr 2023 10:18:41 +0000 Received: by outflank-mailman (input) for mailman id 518395; Wed, 05 Apr 2023 10:18:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Dw-00024X-Nv for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:40 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c165dc3-d39b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:18:40 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so21676991wms.1 for ; Wed, 05 Apr 2023 03:18:40 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id l6-20020a1c7906000000b003ee4e99a8f6sm1696262wme.33.2023.04.05.03.18.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c165dc3-d39b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IGm3E04zIWsYk05zgucyUicl5+3W8OYlCuN37xDTmqU=; b=rTu1tRZPqV4LFx/UoOZi2WLzS6khixq6d/WYxFS7eNNn/OYGeFnv0qc3Qcr02VSKxy rb660oY/fmNu7J89tEYsSKeFFMuIPWe0bwl6jY9zC3o3nLjl9EKCdNxVkCbBuJ6lm5CH gjTz1i3s9XYei/E+itmN9I/+2jlgOY1BBVZJB9fjEYyywfgateusSwusPqpu7NrWhMR0 GMl837ggRVzo1kt3Z33apYrhv71R+7WptfZnBSbUKuQc75ogJNF4kCG2j8Ggv1YnBRCy yVn/ZgcJgjoRbF4Cbyz/wswjzVjQZxiYa1fX9y35/BD8s5WDn2b95Nx3tL6XSawRO0qk iJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IGm3E04zIWsYk05zgucyUicl5+3W8OYlCuN37xDTmqU=; b=48W1T2IaEf288nn7yfly3SGwmytE2z05UcIbVEjvOhBS0U/It01nMMQxkNiLXdRXRn X6HieE5DWVJ0ug2s2PqgAK6QzXz1fJarjAqOuj5WOUYf9ASbNMUEuy2NasnmfVTYy0f1 42Rs0JXpeMyxtkrixDPuspTI6Ezayv68VfYgUa795y/W9Ahflxs2b5cm963dPvSOEyg+ dJqnGZPQNEqOwy/DuzZ8wPCRhQ2CaqCLwKXOySKq23Gft5zhc39k7M3vCLTPVGudiz1l WHVPDzfZzx+AqHEIMZyu/WXi6eFTLEg+3lBIQFJNasK0OOpI7vV6awsti9S99Ud755qy A6Xw== X-Gm-Message-State: AAQBX9fG1/zDNeZ119JRmWPGiH/38FJMyANdCrMbAzULANK4oLfjfBOb Xi2X8hwSreW61CXkMm9OSoRWmg== X-Google-Smtp-Source: AKy350ZDfAFPi7DjfgX/oekuSK5IMwY5EAU6LrxLx1bImlo8Bj5BMxd5ZdtWz6ZThOU3rdF/7XqStA== X-Received: by 2002:a1c:770e:0:b0:3ed:8780:f27b with SMTP id t14-20020a1c770e000000b003ed8780f27bmr4338493wmi.16.1680689919738; Wed, 05 Apr 2023 03:18:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 04/14] accel: Destroy HAX vCPU threads once done Date: Wed, 5 Apr 2023 12:18:01 +0200 Message-Id: <20230405101811.76663-5-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When the vCPU thread finished its processing, destroy it and signal its destruction to generic vCPU management layer. Add a sanity check for the vCPU accelerator context. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hax/hax-accel-ops.c | 3 +++ target/i386/hax/hax-all.c | 1 + 2 files changed, 4 insertions(+) diff --git a/target/i386/hax/hax-accel-ops.c b/target/i386/hax/hax-accel-ops.c index 18114fe34d..0157a628a3 100644 --- a/target/i386/hax/hax-accel-ops.c +++ b/target/i386/hax/hax-accel-ops.c @@ -53,6 +53,8 @@ static void *hax_cpu_thread_fn(void *arg) qemu_wait_io_event(cpu); } while (!cpu->unplug || cpu_can_run(cpu)); + hax_vcpu_destroy(cpu); + cpu_thread_signal_destroyed(cpu); rcu_unregister_thread(); return NULL; } @@ -69,6 +71,7 @@ static void hax_start_vcpu_thread(CPUState *cpu) cpu->cpu_index); qemu_thread_create(cpu->thread, thread_name, hax_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); + assert(cpu->hax_vcpu); #ifdef _WIN32 cpu->hThread = qemu_thread_get_handle(cpu->thread); #endif diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index a2321a1eff..38a4323a3c 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -209,6 +209,7 @@ int hax_vcpu_destroy(CPUState *cpu) CloseHandle(cpu->hThread); #endif g_free(vcpu); + cpu->hax_vcpu = NULL; return 0; } -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:19:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:19:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518400.804917 (Exim 4.92) (envelope-from ) id 1pk0E5-0004EL-Vm; Wed, 05 Apr 2023 10:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518400.804917; Wed, 05 Apr 2023 10:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0E5-0004EE-Su; Wed, 05 Apr 2023 10:18:49 +0000 Received: by outflank-mailman (input) for mailman id 518400; Wed, 05 Apr 2023 10:18:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0E4-0002Na-RP for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:48 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 403c51b8-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:18:47 +0200 (CEST) Received: by mail-wr1-x42d.google.com with SMTP id j24so35697941wrd.0 for ; Wed, 05 Apr 2023 03:18:47 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id c1-20020adfef41000000b002d322b9a7f5sm14646618wrp.88.2023.04.05.03.18.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 403c51b8-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JKKj8/4pIvX0Y2G0Iw2NvkVvuNOgIGf3wL1krYyOhFI=; b=zZVWJRJJOaN+7Gbu5U00rRVxIF+M1REi0nasLd2+TX7rCZ676M8HfGZvzPUiiR+jmJ LzK21sAAN+g/5CA7pY0t71M+JRU/D0i2mKppiG11wKsb+ATVhKWStv+h8AcYfYWJ7o7q ZkVpkMfk04QTu63lwsYX09N6qWIm7uJJV67xns5BXbF7sXdcTtMRBlCsegTqDBPUcmBh ARAhBXK711g76VGI42qECVpEmFzwZ0PK4jFw+pyEwqyKB+BJxwBLM0WD1/uRxXapkmvf Ej+a+b8eIjRl0xMwS3Wlq5n5DK62HsO8B/0gtpHvOMwDIRcustaLrz9inDPWuLWLPEfj UczQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JKKj8/4pIvX0Y2G0Iw2NvkVvuNOgIGf3wL1krYyOhFI=; b=gMbQmKSDOi+AYxv+OFNiSssECuzDxVZ4+jQ0vkHHd6sL12+i9rfOkQ3z9HIyzHKJEG a2kZl/t62U5ffqiujfStBt5Hq5t+Kx47ImZNQw986Rg6JSQ5nLDH3q2o2QYQuXuiHgIZ 2iNAshx14cRuF2GeAKAXDAb1oBzgfODR4DjyZhz6r1qx8CPm3KUfltkotAFKnkYvwrfq UeBIIf1UUmc1gNd9LLhOpX1FJGL9K7PiDEUjo/MoCRF37xTZLp1XuTlwtlYVL7ZeL43T yfOOvIVpkoJfaSrOZWxMCf/bw0/NWNkKyhbYZzKG5qvPdGxh+U6byCt6KA1Aw+uC7QpQ NEyQ== X-Gm-Message-State: AAQBX9fp/OrcSgArGhdq8SCnz89bmgYh+rQnvv7KegMyR02DqHm90Mgv /hJ4OcDAhyZfEnkFjhhw7oufog== X-Google-Smtp-Source: AKy350bkMz7m3CqlZANDFC+N8H247sFug5Oc9sidBbssiHByDywSp20m46NTY3RF7XV/gx2ANc24Hw== X-Received: by 2002:a5d:68ca:0:b0:2e4:bfa0:8c32 with SMTP id p10-20020a5d68ca000000b002e4bfa08c32mr3774527wrw.47.1680689926542; Wed, 05 Apr 2023 03:18:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Reinoud Zandijk , Sunil Muthuswamy Subject: [PATCH 05/14] accel: Rename 'hax_vcpu' as 'accel' in CPUState Date: Wed, 5 Apr 2023 12:18:02 +0200 Message-Id: <20230405101811.76663-6-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All accelerators will share a single opaque context in CPUState. Start by renaming 'hax_vcpu' as 'accelCPUState'. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 2 +- target/i386/hax/hax-accel-ops.c | 2 +- target/i386/hax/hax-all.c | 18 +++++++++--------- target/i386/nvmm/nvmm-all.c | 6 +++--- target/i386/whpx/whpx-all.c | 6 +++--- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 397fd3ac68..193494cde4 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -442,7 +442,7 @@ struct CPUState { /* Used for user-only emulation of prctl(PR_SET_UNALIGN). */ bool prctl_unalign_sigbus; - struct hax_vcpu_state *hax_vcpu; + struct hax_vcpu_state *accel; struct hvf_vcpu_state *hvf; diff --git a/target/i386/hax/hax-accel-ops.c b/target/i386/hax/hax-accel-ops.c index 0157a628a3..a8512efcd5 100644 --- a/target/i386/hax/hax-accel-ops.c +++ b/target/i386/hax/hax-accel-ops.c @@ -71,7 +71,7 @@ static void hax_start_vcpu_thread(CPUState *cpu) cpu->cpu_index); qemu_thread_create(cpu->thread, thread_name, hax_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); - assert(cpu->hax_vcpu); + assert(cpu->accel); #ifdef _WIN32 cpu->hThread = qemu_thread_get_handle(cpu->thread); #endif diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index 38a4323a3c..3865ff9419 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -62,7 +62,7 @@ int valid_hax_tunnel_size(uint16_t size) hax_fd hax_vcpu_get_fd(CPUArchState *env) { - struct hax_vcpu_state *vcpu = env_cpu(env)->hax_vcpu; + struct hax_vcpu_state *vcpu = env_cpu(env)->accel; if (!vcpu) { return HAX_INVALID_FD; } @@ -188,7 +188,7 @@ int hax_vcpu_create(int id) int hax_vcpu_destroy(CPUState *cpu) { - struct hax_vcpu_state *vcpu = cpu->hax_vcpu; + struct hax_vcpu_state *vcpu = cpu->accel; if (!hax_global.vm) { fprintf(stderr, "vcpu %x destroy failed, vm is null\n", vcpu->vcpu_id); @@ -209,7 +209,7 @@ int hax_vcpu_destroy(CPUState *cpu) CloseHandle(cpu->hThread); #endif g_free(vcpu); - cpu->hax_vcpu = NULL; + cpu->accel = NULL; return 0; } @@ -223,7 +223,7 @@ int hax_init_vcpu(CPUState *cpu) exit(-1); } - cpu->hax_vcpu = hax_global.vm->vcpus[cpu->cpu_index]; + cpu->accel = hax_global.vm->vcpus[cpu->cpu_index]; cpu->vcpu_dirty = true; qemu_register_reset(hax_reset_vcpu_state, cpu->env_ptr); @@ -415,7 +415,7 @@ static int hax_handle_io(CPUArchState *env, uint32_t df, uint16_t port, static int hax_vcpu_interrupt(CPUArchState *env) { CPUState *cpu = env_cpu(env); - struct hax_vcpu_state *vcpu = cpu->hax_vcpu; + struct hax_vcpu_state *vcpu = cpu->accel; struct hax_tunnel *ht = vcpu->tunnel; /* @@ -447,7 +447,7 @@ static int hax_vcpu_interrupt(CPUArchState *env) void hax_raise_event(CPUState *cpu) { - struct hax_vcpu_state *vcpu = cpu->hax_vcpu; + struct hax_vcpu_state *vcpu = cpu->accel; if (!vcpu) { return; @@ -468,7 +468,7 @@ static int hax_vcpu_hax_exec(CPUArchState *env) int ret = 0; CPUState *cpu = env_cpu(env); X86CPU *x86_cpu = X86_CPU(cpu); - struct hax_vcpu_state *vcpu = cpu->hax_vcpu; + struct hax_vcpu_state *vcpu = cpu->accel; struct hax_tunnel *ht = vcpu->tunnel; if (!hax_enabled()) { @@ -1114,8 +1114,8 @@ void hax_reset_vcpu_state(void *opaque) { CPUState *cpu; for (cpu = first_cpu; cpu != NULL; cpu = CPU_NEXT(cpu)) { - cpu->hax_vcpu->tunnel->user_event_pending = 0; - cpu->hax_vcpu->tunnel->ready_for_interrupt_injection = 0; + cpu->accel->tunnel->user_event_pending = 0; + cpu->accel->tunnel->ready_for_interrupt_injection = 0; } } diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index b75738ee9c..cf4f0af24b 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -52,7 +52,7 @@ static struct qemu_machine qemu_mach; static struct qemu_vcpu * get_qemu_vcpu(CPUState *cpu) { - return (struct qemu_vcpu *)cpu->hax_vcpu; + return (struct qemu_vcpu *)cpu->accel; } static struct nvmm_machine * @@ -995,7 +995,7 @@ nvmm_init_vcpu(CPUState *cpu) } cpu->vcpu_dirty = true; - cpu->hax_vcpu = (struct hax_vcpu_state *)qcpu; + cpu->accel = (struct hax_vcpu_state *)qcpu; return 0; } @@ -1030,7 +1030,7 @@ nvmm_destroy_vcpu(CPUState *cpu) struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); nvmm_vcpu_destroy(mach, &qcpu->vcpu); - g_free(cpu->hax_vcpu); + g_free(cpu->accel); } /* -------------------------------------------------------------------------- */ diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 52af81683c..d1ad6f156a 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -262,7 +262,7 @@ static bool whpx_has_xsave(void) static struct whpx_vcpu *get_whpx_vcpu(CPUState *cpu) { - return (struct whpx_vcpu *)cpu->hax_vcpu; + return (struct whpx_vcpu *)cpu->accel; } static WHV_X64_SEGMENT_REGISTER whpx_seg_q2h(const SegmentCache *qs, int v86, @@ -2258,7 +2258,7 @@ int whpx_init_vcpu(CPUState *cpu) vcpu->interruptable = true; cpu->vcpu_dirty = true; - cpu->hax_vcpu = (struct hax_vcpu_state *)vcpu; + cpu->accel = (struct hax_vcpu_state *)vcpu; max_vcpu_index = max(max_vcpu_index, cpu->cpu_index); qemu_add_vm_change_state_handler(whpx_cpu_update_state, cpu->env_ptr); @@ -2300,7 +2300,7 @@ void whpx_destroy_vcpu(CPUState *cpu) whp_dispatch.WHvDeleteVirtualProcessor(whpx->partition, cpu->cpu_index); whp_dispatch.WHvEmulatorDestroyEmulator(vcpu->emulator); - g_free(cpu->hax_vcpu); + g_free(cpu->accel); return; } -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:19:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518403.804928 (Exim 4.92) (envelope-from ) id 1pk0EG-0004uu-FS; Wed, 05 Apr 2023 10:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518403.804928; Wed, 05 Apr 2023 10:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0EG-0004un-Ac; Wed, 05 Apr 2023 10:19:00 +0000 Received: by outflank-mailman (input) for mailman id 518403; Wed, 05 Apr 2023 10:18:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0EE-0002Na-Mn for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:18:58 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 461dd625-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:18:57 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id l12so35623144wrm.10 for ; Wed, 05 Apr 2023 03:18:56 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id l18-20020adfe592000000b002c5534db60bsm14659802wrm.71.2023.04.05.03.18.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:18:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 461dd625-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6tftOh0BEcl8WGCnB6MC//b/5zdxDYjL5goslSUZJws=; b=yPbFhCwGeiCV4thDFylzfI/HwDyG5hzAj4MOzixAzKF25y0uzdJIpFxXuplWi9vjHl /pOllACxcM9z8xuQDdRw6M+2mhe134Dj+vuHZkVEnkH+iEToGCJ/gsI/e1vCCyvskKgL u3Mvtb6MFtubWA04wRDH74PCwnCAY/i2SngbnxTxDSfmMlutOwruOtZ/lxg1P8mD8QYc drS8XHL8crBE+lDtcMRmYU91Oi0ecrSiQz2TIPt5ieGnpP+PuypBCXiw3EMqe02ST1rI wsMGZCOdiVWLzTUX7Ca+wgJTbV5lZ6+mNbhvpM8NJsdWCvazgFD200r/8aPIN7ho8VP6 onNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6tftOh0BEcl8WGCnB6MC//b/5zdxDYjL5goslSUZJws=; b=20XlBoaIgxqLyPHspG5cAGPtye59aQMVcmYsl32UwxVf4NrX+gOrYG5gtboAPSTAQC yLuyKS0TCWumPj7AuiDkxyYahWSDfVgQxMTJdz0CkM1xlPkX+bROXoWVMjk4MabqZ+Jh DRTiItiNZoFR/qJ/lSc5xGiDd3Qwk/tDNesNjh7ui6BeBSuzku0ae5AjJh1ooSv9YJ7D N0hW2w8Dy35GoEyulwi3XhedqgeM9UeA+dzszJsZFZGgURmUPGHvJoNcr5h6RWcYe2x/ ajvrYtqQfopbxUurulANys721/AF+LWZZD/OTx2fXpynL4a9bWn2sLZKKi7BxSNQeXlp xcRg== X-Gm-Message-State: AAQBX9fZa8rtByuIva3RTlYmd567w3Cayzb6nmFrIRcno2dR+5lt93qP UWm4JTVCVDdoQjJb6V1JieSAaw== X-Google-Smtp-Source: AKy350bSSR7dvtgFBRLgKNCzhtqOOQSU+0g5L1LOMUC3nb32jDJaawY9UmLjKaQ4gtEPNgL7gGWKbg== X-Received: by 2002:a5d:610a:0:b0:2d5:553a:93ac with SMTP id v10-20020a5d610a000000b002d5553a93acmr3978963wrt.7.1680689936532; Wed, 05 Apr 2023 03:18:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 06/14] accel: Use a typedef for struct hax_vcpu_state Date: Wed, 5 Apr 2023 12:18:03 +0200 Message-Id: <20230405101811.76663-7-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use a type definition instead of explicit structure. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hax/hax-i386.h | 10 +++++----- target/i386/hax/hax-all.c | 16 ++++++++-------- target/i386/hax/hax-posix.c | 4 ++-- target/i386/hax/hax-windows.c | 4 ++-- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/target/i386/hax/hax-i386.h b/target/i386/hax/hax-i386.h index 409ebdb4af..3cb3b9bbd0 100644 --- a/target/i386/hax/hax-i386.h +++ b/target/i386/hax/hax-i386.h @@ -25,12 +25,12 @@ typedef HANDLE hax_fd; #endif extern struct hax_state hax_global; -struct hax_vcpu_state { +typedef struct hax_vcpu_state { hax_fd fd; int vcpu_id; struct hax_tunnel *tunnel; unsigned char *iobuf; -}; +} hax_vcpu_state; struct hax_state { hax_fd fd; /* the global hax device interface */ @@ -46,7 +46,7 @@ struct hax_vm { hax_fd fd; int id; int numvcpus; - struct hax_vcpu_state **vcpus; + hax_vcpu_state **vcpus; }; /* Functions exported to host specific mode */ @@ -57,7 +57,7 @@ int valid_hax_tunnel_size(uint16_t size); int hax_mod_version(struct hax_state *hax, struct hax_module_version *version); int hax_inject_interrupt(CPUArchState *env, int vector); struct hax_vm *hax_vm_create(struct hax_state *hax, int max_cpus); -int hax_vcpu_run(struct hax_vcpu_state *vcpu); +int hax_vcpu_run(hax_vcpu_state *vcpu); int hax_vcpu_create(int id); void hax_kick_vcpu_thread(CPUState *cpu); @@ -76,7 +76,7 @@ int hax_host_create_vm(struct hax_state *hax, int *vm_id); hax_fd hax_host_open_vm(struct hax_state *hax, int vm_id); int hax_host_create_vcpu(hax_fd vm_fd, int vcpuid); hax_fd hax_host_open_vcpu(int vmid, int vcpuid); -int hax_host_setup_vcpu_channel(struct hax_vcpu_state *vcpu); +int hax_host_setup_vcpu_channel(hax_vcpu_state *vcpu); hax_fd hax_mod_open(void); void hax_memory_init(void); diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index 3865ff9419..a55b18f353 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -62,7 +62,7 @@ int valid_hax_tunnel_size(uint16_t size) hax_fd hax_vcpu_get_fd(CPUArchState *env) { - struct hax_vcpu_state *vcpu = env_cpu(env)->accel; + hax_vcpu_state *vcpu = env_cpu(env)->accel; if (!vcpu) { return HAX_INVALID_FD; } @@ -136,7 +136,7 @@ static int hax_version_support(struct hax_state *hax) int hax_vcpu_create(int id) { - struct hax_vcpu_state *vcpu = NULL; + hax_vcpu_state *vcpu = NULL; int ret; if (!hax_global.vm) { @@ -149,7 +149,7 @@ int hax_vcpu_create(int id) return 0; } - vcpu = g_new0(struct hax_vcpu_state, 1); + vcpu = g_new0(hax_vcpu_state, 1); ret = hax_host_create_vcpu(hax_global.vm->fd, id); if (ret) { @@ -188,7 +188,7 @@ int hax_vcpu_create(int id) int hax_vcpu_destroy(CPUState *cpu) { - struct hax_vcpu_state *vcpu = cpu->accel; + hax_vcpu_state *vcpu = cpu->accel; if (!hax_global.vm) { fprintf(stderr, "vcpu %x destroy failed, vm is null\n", vcpu->vcpu_id); @@ -263,7 +263,7 @@ struct hax_vm *hax_vm_create(struct hax_state *hax, int max_cpus) } vm->numvcpus = max_cpus; - vm->vcpus = g_new0(struct hax_vcpu_state *, vm->numvcpus); + vm->vcpus = g_new0(hax_vcpu_state *, vm->numvcpus); for (i = 0; i < vm->numvcpus; i++) { vm->vcpus[i] = NULL; } @@ -415,7 +415,7 @@ static int hax_handle_io(CPUArchState *env, uint32_t df, uint16_t port, static int hax_vcpu_interrupt(CPUArchState *env) { CPUState *cpu = env_cpu(env); - struct hax_vcpu_state *vcpu = cpu->accel; + hax_vcpu_state *vcpu = cpu->accel; struct hax_tunnel *ht = vcpu->tunnel; /* @@ -447,7 +447,7 @@ static int hax_vcpu_interrupt(CPUArchState *env) void hax_raise_event(CPUState *cpu) { - struct hax_vcpu_state *vcpu = cpu->accel; + hax_vcpu_state *vcpu = cpu->accel; if (!vcpu) { return; @@ -468,7 +468,7 @@ static int hax_vcpu_hax_exec(CPUArchState *env) int ret = 0; CPUState *cpu = env_cpu(env); X86CPU *x86_cpu = X86_CPU(cpu); - struct hax_vcpu_state *vcpu = cpu->accel; + hax_vcpu_state *vcpu = cpu->accel; struct hax_tunnel *ht = vcpu->tunnel; if (!hax_enabled()) { diff --git a/target/i386/hax/hax-posix.c b/target/i386/hax/hax-posix.c index ac1a51096e..8ee247845b 100644 --- a/target/i386/hax/hax-posix.c +++ b/target/i386/hax/hax-posix.c @@ -205,7 +205,7 @@ hax_fd hax_host_open_vcpu(int vmid, int vcpuid) return fd; } -int hax_host_setup_vcpu_channel(struct hax_vcpu_state *vcpu) +int hax_host_setup_vcpu_channel(hax_vcpu_state *vcpu) { int ret; struct hax_tunnel_info info; @@ -227,7 +227,7 @@ int hax_host_setup_vcpu_channel(struct hax_vcpu_state *vcpu) return 0; } -int hax_vcpu_run(struct hax_vcpu_state *vcpu) +int hax_vcpu_run(hax_vcpu_state *vcpu) { return ioctl(vcpu->fd, HAX_VCPU_IOCTL_RUN, NULL); } diff --git a/target/i386/hax/hax-windows.c b/target/i386/hax/hax-windows.c index 59afa213a6..08ec93a256 100644 --- a/target/i386/hax/hax-windows.c +++ b/target/i386/hax/hax-windows.c @@ -301,7 +301,7 @@ hax_fd hax_host_open_vcpu(int vmid, int vcpuid) return hDeviceVCPU; } -int hax_host_setup_vcpu_channel(struct hax_vcpu_state *vcpu) +int hax_host_setup_vcpu_channel(hax_vcpu_state *vcpu) { hax_fd hDeviceVCPU = vcpu->fd; int ret; @@ -327,7 +327,7 @@ int hax_host_setup_vcpu_channel(struct hax_vcpu_state *vcpu) return 0; } -int hax_vcpu_run(struct hax_vcpu_state *vcpu) +int hax_vcpu_run(hax_vcpu_state *vcpu) { int ret; HANDLE hDeviceVCPU = vcpu->fd; -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:19:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:19:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518406.804938 (Exim 4.92) (envelope-from ) id 1pk0EM-0005NU-P6; Wed, 05 Apr 2023 10:19:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518406.804938; Wed, 05 Apr 2023 10:19:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0EM-0005NI-Kv; Wed, 05 Apr 2023 10:19:06 +0000 Received: by outflank-mailman (input) for mailman id 518406; Wed, 05 Apr 2023 10:19:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0EL-00024X-5R for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:05 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a6f4b4b-d39b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:19:04 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id l10-20020a05600c1d0a00b003f04bd3691eso6765085wms.5 for ; Wed, 05 Apr 2023 03:19:04 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id f23-20020a7bcd17000000b003eb966d39desm1762763wmj.2.2023.04.05.03.19.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a6f4b4b-d39b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0bXZGRuYaUWuS+waIlKd8VQv2t6ejAS6CfkyaECLnt0=; b=LIHJIKyuI7acMvt8rBrVg6eWFKgBkrJ3/b0arkph/DUHa0BLbU93H3b1GIwH92R4Zy +uvzlTCyUDlYf/j4al5z+wQUHx97GbeXdG9kBiFdMAHyviECH6MqzuY0CNALDN8Ap5Kl ApXLzY1U62e1horWK6Vt/U+csJdBfLpJs0pQHuzAzmEZEThhQrNbsPj75PM04Up7HqEo 3/73NqiS9NmRAA8IVw8pYFlfJUzbpOMYXpCwDL0opeM+q2GUARMOBu22yoM5Hh8oWG8N qONWesA/cQ68zjyXExg7MhsK0M/t5sPv8yhjX2pllIkZYpVHgJWQ2hcKuv9wWGPJXdDK ogxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0bXZGRuYaUWuS+waIlKd8VQv2t6ejAS6CfkyaECLnt0=; b=WF0c0ek4QkPZ8AQoRDWY3zdt98WsSNb0Trd+pbXRgem+gdY/6mFFCD4sGD3FQutWQF hPfG5hVNX5ayeDIL321OzbKXi5sUhKW3xudxoQEXAm0xCdFDchAthvCsZ1tk2zyVM8Fn Yyv+B86xJyeK6GR6beAHwJ8is7HIdGV+slxP0xvDqE2YWJ4PoPTHfcGJqFgywxlFNFkt 1+rg0boZy8bn4wo1aaK2PuCcPTdCyp+ow/qalK93j0pqHKgp0+wcXzuW/NtG3bzGFW7H AM1OrlIQCEaBqwpb8aiynMKKklkUuVoDXqnmny0SlHVrff3TxkqkO59O/L86KLCG0JB8 /hig== X-Gm-Message-State: AAQBX9eEnmHpVNebFr7b2XZbQqYQhPscrSQPgaiuihRa9wFuCjr7X65E T29VFWxEbVcQddLhUuGUbnu2jwan/K7RUk0AvaY= X-Google-Smtp-Source: AKy350aOrY2Jw4wGetHTWaGkqVDR1/1hOaALytcr5CxarBrtXg4uhD0qN6hOdWeu8PVqJ7zVJHPs0g== X-Received: by 2002:a7b:ca48:0:b0:3ee:ed5:6115 with SMTP id m8-20020a7bca48000000b003ee0ed56115mr4226349wml.19.1680689943740; Wed, 05 Apr 2023 03:19:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Reinoud Zandijk , Sunil Muthuswamy Subject: [PATCH 07/14] accel: Rename struct hax_vcpu_state -> struct AccelvCPUState Date: Wed, 5 Apr 2023 12:18:04 +0200 Message-Id: <20230405101811.76663-8-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We want all accelerators to share the same opaque pointer in CPUState. Start with the HAX context, renaming its forward declarated structure 'hax_vcpu_state' as 'AccelvCPUState'. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 7 +++---- target/i386/hax/hax-i386.h | 3 ++- target/i386/nvmm/nvmm-all.c | 2 +- target/i386/whpx/whpx-all.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 193494cde4..173f47d24e 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -235,8 +235,7 @@ typedef struct SavedIOTLB { struct KVMState; struct kvm_run; - -struct hax_vcpu_state; +struct AccelvCPUState; struct hvf_vcpu_state; /* work queue */ @@ -305,6 +304,7 @@ struct qemu_work_item; * @next_cpu: Next CPU sharing TB cache. * @opaque: User data. * @mem_io_pc: Host Program Counter at which the memory was accessed. + * @accel: Pointer to accelerator specific state. * @kvm_fd: vCPU file descriptor for KVM. * @work_mutex: Lock to prevent multiple access to @work_list. * @work_list: List of pending asynchronous work. @@ -423,6 +423,7 @@ struct CPUState { uint32_t can_do_io; int32_t exception_index; + struct AccelvCPUState *accel; /* shared by kvm, hax and hvf */ bool vcpu_dirty; @@ -442,8 +443,6 @@ struct CPUState { /* Used for user-only emulation of prctl(PR_SET_UNALIGN). */ bool prctl_unalign_sigbus; - struct hax_vcpu_state *accel; - struct hvf_vcpu_state *hvf; /* track IOMMUs whose translations we've cached in the TCG TLB */ diff --git a/target/i386/hax/hax-i386.h b/target/i386/hax/hax-i386.h index 3cb3b9bbd0..d11d43e857 100644 --- a/target/i386/hax/hax-i386.h +++ b/target/i386/hax/hax-i386.h @@ -25,7 +25,8 @@ typedef HANDLE hax_fd; #endif extern struct hax_state hax_global; -typedef struct hax_vcpu_state { + +typedef struct AccelvCPUState { hax_fd fd; int vcpu_id; struct hax_tunnel *tunnel; diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index cf4f0af24b..3c7bdd560f 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -995,7 +995,7 @@ nvmm_init_vcpu(CPUState *cpu) } cpu->vcpu_dirty = true; - cpu->accel = (struct hax_vcpu_state *)qcpu; + cpu->accel = (struct AccelvCPUState *)qcpu; return 0; } diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index d1ad6f156a..70eadb7f05 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2258,7 +2258,7 @@ int whpx_init_vcpu(CPUState *cpu) vcpu->interruptable = true; cpu->vcpu_dirty = true; - cpu->accel = (struct hax_vcpu_state *)vcpu; + cpu->accel = (struct AccelvCPUState *)vcpu; max_vcpu_index = max(max_vcpu_index, cpu->cpu_index); qemu_add_vm_change_state_handler(whpx_cpu_update_state, cpu->env_ptr); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:27:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:27:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518414.804948 (Exim 4.92) (envelope-from ) id 1pk0Lx-0007kW-G0; Wed, 05 Apr 2023 10:26:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518414.804948; Wed, 05 Apr 2023 10:26:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Lx-0007kP-Cb; Wed, 05 Apr 2023 10:26:57 +0000 Received: by outflank-mailman (input) for mailman id 518414; Wed, 05 Apr 2023 10:26:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Lv-0007kH-OS for xen-devel@lists.xen.org; Wed, 05 Apr 2023 10:26:55 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 624caf44-d39c-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:26:54 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id l12so35644946wrm.10 for ; Wed, 05 Apr 2023 03:26:53 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id bd5-20020a05600c1f0500b003f0472ffc7csm1768461wmb.11.2023.04.05.03.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:26:52 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7DA471FFB7; Wed, 5 Apr 2023 11:26:52 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 624caf44-d39c-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680690413; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=Lww6dDMe0bMEJli6/6ZP6j4C+of80/qR+ErByK0yw5g=; b=A+4oG+PJQ4lEZ6T1z8xTGbTG1pEru7t6wl92B6x2UAdtjSn4xJzf7eV7I2j4gpyXbn 92WZ5xE3JJgQFywvuyLRJMG40XXULmggfQHz69w92CEIWEygoSuigsrjq9ht1V3Zgu4i z6TNY9OfzzcZUcU6HOCAxUSIK/3goyowjInTAglW7fsosL6LxLa21DNgd+90SoYxNwuq nd1NNnRxAH+BUWyGiJkYqmYw+QSWqTzOkEiAh19YsI+W7wvfl1+9S9BkkI5tN+bxmvJZ grxortISRJgmJfB1B0BK78szZCrNSh2iGdM/WCCfqUuU/hheHyQVJZmwC0sSHOmCINwS /EBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680690413; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Lww6dDMe0bMEJli6/6ZP6j4C+of80/qR+ErByK0yw5g=; b=RTx3Mudl1P+J4p5Le4iBC1iyLBqzS8Rv8UWS9wPq1ZzUutVHnCs+3eLeYthxVU2nX0 31kr/iO12ZomSdAtxRNcIb9h0dPtxsuHK86jSsowCwCsvI3eub/gszdTTa9nZOWBZpoS 32GAss6SdUmPz6jh1oACyDymOkFZEzV4s9EwmIE+lBk5xrYqT89K8olwtxLK8YfY33JY 3vT3mGzdXJklb0JylTN2KpZb7HvHJXbrNaAyVCdVGZqUBk6l3TPoPejUnPEZCaFdCsvg tT5WvsjX5dMl/aP9IBpOWGpeyQ5D/QzwJL3+jJM30ZAqJ0Q28UrbkZxHL+qDAjtcWwIJ YAmg== X-Gm-Message-State: AAQBX9cKsEvctpLDr+b1F5gN7xnbjsS2FisLyz2aCaEJWG0qS51LmgCf v7YLj7f+/keL6diCuH+z7mwXkw== X-Google-Smtp-Source: AKy350bNr4KJH+ZbusBX8ddHYWCR5TF9ug/D4hQCNf5bE3nZzYv03gsenyNx3XTYaQjbqtu0borjcw== X-Received: by 2002:a5d:6b0a:0:b0:2cd:bc79:5444 with SMTP id v10-20020a5d6b0a000000b002cdbc795444mr3747030wrw.2.1680690413210; Wed, 05 Apr 2023 03:26:53 -0700 (PDT) References: <20230405080512.nvxiw4lv7hyuzqej@vireshk-i7> <87h6tulkae.fsf@linaro.org> <20230405060340-mutt-send-email-mst@kernel.org> User-agent: mu4e 1.10.0; emacs 29.0.60 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: "Michael S. Tsirkin" Cc: Viresh Kumar , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, Stefan Hajnoczi , Vincent Guittot , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks Date: Wed, 05 Apr 2023 11:24:43 +0100 In-reply-to: <20230405060340-mutt-send-email-mst@kernel.org> Message-ID: <87cz4ilj4j.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Michael S. Tsirkin" writes: > On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Benn=C3=A9e wrote: >>=20 >> Viresh Kumar writes: >>=20 >> > On 09-03-23, 14:20, Viresh Kumar wrote: >> >> Hello, >> >>=20 >> >> This patchset tries to update the vhost-user protocol to make it supp= ort special >> >> memory mapping required in case of Xen hypervisor. >> >>=20 >> >> The first patch is mostly cleanup and second one introduces a new xen= specific >> >> feature. >> > >> > Can we apply this now ? I have developed code for rust-vmm crates >> > based on this and we need to get this merged/finalized first before >> > merging those changes. >>=20 >>=20 >> I've queued into my virtio/vhost-user-device series so I'll get merged >> with that series unless mst wants to take it now. > > Well the patches are tagged and I was going to take these after the relea= se. > Probably easier not to work on this in two trees. > Still if there's something in your tree being blocked > by these patches then > Acked-by: Michael S. Tsirkin > Let me know. The virtio/vhost-user-device tree work is orthogonal to this vhost-user enhancement although all the work is related to our latest VirtIO project inside Linaro, Orko: https://linaro.atlassian.net/wiki/spaces/ORKO/overview So if you are happy please take these patches now for when the tree re-opens. > > >> > >> > Thanks. >>=20 >>=20 >> --=20 >> Alex Benn=C3=A9e >> Virtualisation Tech Lead @ Linaro --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:28:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518418.804958 (Exim 4.92) (envelope-from ) id 1pk0Nu-0008Kx-RJ; Wed, 05 Apr 2023 10:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518418.804958; Wed, 05 Apr 2023 10:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Nu-0008Kq-O8; Wed, 05 Apr 2023 10:28:58 +0000 Received: by outflank-mailman (input) for mailman id 518418; Wed, 05 Apr 2023 10:28:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ej-0002Na-9W for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:29 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 586a9388-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:19:27 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id e18so35635998wra.9 for ; Wed, 05 Apr 2023 03:19:27 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id q12-20020adff78c000000b002c5d3f0f737sm14591138wrp.30.2023.04.05.03.19.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 586a9388-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zfz8X/GUHgutjcuWgCA2LWUZkCc4gRaFUTsRO6OH06g=; b=yL8zWIHfSIdBZYPkNDculPyk2YWRIlBQX8fQHgjeuSYeTxaloVwCCglH5DXA7/0zDg TZoThoM/7Yzk229VxX9xWe1sKCb9xPkVbKN8Rue8VJ9iqfCxkzpWDThAQYbFg2V+tT4n 0lFcGByrmLtNLB2oRBl4LbPvsUeFbnwE43+pzddA4+wnnvx5l0rEaM3ytpPw2h5NOvmZ DVCYR6+eBbGkSb54pQlKLGqI1fhY/v3/lWGMSe4bZ8LvxqbH70eUp/6qo6vPZ7mUdh5Y PeQA12GP5hcgxOvodwGCZ4f1KCUcAPsr/zlEr6sTgBGcMgExpeywl1vstjMaVXIEP1HP 4juw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zfz8X/GUHgutjcuWgCA2LWUZkCc4gRaFUTsRO6OH06g=; b=WLxFXax1asXeE+jvMRFIdNkSkSk9P77rpUcZdvn3JkvbPuii95gVkNcDlzmGd5SXx7 DMiUX3WKdwBX0dWb377mksbs/cUPW9/LChRVo9qWlDLqB9I5Zj49ZCyd5IVAFi0sxI19 Ojf9zB4CTEI3xaNxveBLVXGUpwYvP60dh3mNjL75dNVx6Jm2TqxnlubPUJcqrjI3jjdG 71fu5Hpwnvrm6AYFCrehJxHTZTwZwdbMBywAQO5oEzUw853/xIui3liWeTyIVYmch1vw LkG+dlij1s8obBjqwmv0RnG9tTh2GfWY2MNfZEntZjHh0XUfyaFBVyE/N61T3Itdk+Zw 6huw== X-Gm-Message-State: AAQBX9ffMYJ2uzDrr8nv++J767qMUJDiO9aqLoDlS2mxitAXmpN5ciLG lUz1PtWALgsSbryqZ1zWnid/Mg== X-Google-Smtp-Source: AKy350Zvml7eWtPRqrRcRnGg6qq51tcU3Hzdj52W85LNQPphjff69u1l2lWyWIRrXMamHJtWfSOkkw== X-Received: by 2002:adf:e48b:0:b0:2c7:6bb:fb7a with SMTP id i11-20020adfe48b000000b002c706bbfb7amr4270631wrm.54.1680689967157; Wed, 05 Apr 2023 03:19:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Reinoud Zandijk Subject: [PATCH 10/14] accel: Rename NVMM struct qemu_vcpu -> struct AccelvCPUState Date: Wed, 5 Apr 2023 12:18:07 +0200 Message-Id: <20230405101811.76663-11-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We want all accelerators to share the same opaque pointer in CPUState. Rename NVMM 'qemu_vcpu' as 'AccelvCPUState'. Replace g_try_malloc0() by g_try_new0() for readability. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index 45fd318d23..97a7225598 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -26,7 +26,7 @@ #include -struct qemu_vcpu { +struct AccelvCPUState { struct nvmm_vcpu vcpu; uint8_t tpr; bool stop; @@ -49,10 +49,10 @@ struct qemu_machine { static bool nvmm_allowed; static struct qemu_machine qemu_mach; -static struct qemu_vcpu * +static struct AccelvCPUState * get_qemu_vcpu(CPUState *cpu) { - return (struct qemu_vcpu *)cpu->accel; + return cpu->accel; } static struct nvmm_machine * @@ -86,7 +86,7 @@ nvmm_set_registers(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; struct nvmm_x64_state *state = vcpu->state; uint64_t bitmap; @@ -223,7 +223,7 @@ nvmm_get_registers(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -347,7 +347,7 @@ static bool nvmm_can_take_int(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; struct nvmm_machine *mach = get_nvmm_mach(); @@ -372,7 +372,7 @@ nvmm_can_take_int(CPUState *cpu) static bool nvmm_can_take_nmi(CPUState *cpu) { - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); /* * Contrary to INTs, NMIs always schedule an exit when they are @@ -395,7 +395,7 @@ nvmm_vcpu_pre_run(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -478,7 +478,7 @@ nvmm_vcpu_pre_run(CPUState *cpu) static void nvmm_vcpu_post_run(CPUState *cpu, struct nvmm_vcpu_exit *exit) { - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); uint64_t tpr; @@ -565,7 +565,7 @@ static int nvmm_handle_rdmsr(struct nvmm_machine *mach, CPUState *cpu, struct nvmm_vcpu_exit *exit) { - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -610,7 +610,7 @@ static int nvmm_handle_wrmsr(struct nvmm_machine *mach, CPUState *cpu, struct nvmm_vcpu_exit *exit) { - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -686,7 +686,7 @@ nvmm_vcpu_loop(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_vcpu_exit *exit = vcpu->exit; @@ -892,7 +892,7 @@ static void nvmm_ipi_signal(int sigcpu) { if (current_cpu) { - struct qemu_vcpu *qcpu = get_qemu_vcpu(current_cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(current_cpu); #if NVMM_USER_VERSION >= 2 struct nvmm_vcpu *vcpu = &qcpu->vcpu; nvmm_vcpu_stop(vcpu); @@ -926,7 +926,7 @@ nvmm_init_vcpu(CPUState *cpu) struct nvmm_vcpu_conf_cpuid cpuid; struct nvmm_vcpu_conf_tpr tpr; Error *local_error = NULL; - struct qemu_vcpu *qcpu; + struct AccelvCPUState *qcpu; int ret, err; nvmm_init_cpu_signals(); @@ -942,7 +942,7 @@ nvmm_init_vcpu(CPUState *cpu) } } - qcpu = g_try_malloc0(sizeof(*qcpu)); + qcpu = g_try_new0(struct AccelvCPUState, 1); if (qcpu == NULL) { error_report("NVMM: Failed to allocate VCPU context."); return -ENOMEM; @@ -995,7 +995,7 @@ nvmm_init_vcpu(CPUState *cpu) } cpu->vcpu_dirty = true; - cpu->accel = (struct AccelvCPUState *)qcpu; + cpu->accel = qcpu; return 0; } @@ -1027,7 +1027,7 @@ void nvmm_destroy_vcpu(CPUState *cpu) { struct nvmm_machine *mach = get_nvmm_mach(); - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); nvmm_vcpu_destroy(mach, &qcpu->vcpu); g_free(cpu->accel); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:29:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518420.804968 (Exim 4.92) (envelope-from ) id 1pk0Ny-0000CP-7v; Wed, 05 Apr 2023 10:29:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518420.804968; Wed, 05 Apr 2023 10:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ny-0000C6-2v; Wed, 05 Apr 2023 10:29:02 +0000 Received: by outflank-mailman (input) for mailman id 518420; Wed, 05 Apr 2023 10:28:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0F5-0002Na-8w for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:51 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6587ef62-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:19:49 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id l27so35663873wrb.2 for ; Wed, 05 Apr 2023 03:19:49 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id o7-20020adfe807000000b002e4cd2ec5c7sm14692347wrm.86.2023.04.05.03.19.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6587ef62-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jksVpkvUC0Cd0t39UFdIwyYip+p/HLpViupo0kEzavo=; b=M14p41XBeC2pDOXONWRmVPh/g0bgtOaeo2kq2u+TWuJbxjfFyLRtQYnT6xjEliAwSd Gmn7vgNMSmnVxfuYpWs2aBjugNVuv4EcJIwJLGMmyZg0QDYfH3i/sc7Kh/q/3WK7qsdn F60Wv7glyCGVMo3BOtpHfdZkvOyzxwN+gH3+Hex9JK/WUrdLUi4yf74vk34hUq78UiYb AORBP6ycIQAo33OBYSJhlzh69AqqlN5KQ4LDwsQpdYmaxHN8h7YoC/jYUnRSJ6PAS/Fc moP7c9mQFfmYCYIySXHMkSb6ncs0eKD1DYTa0llVPqgHxXnFQBGyNcDmOUOFGwExmveQ mqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jksVpkvUC0Cd0t39UFdIwyYip+p/HLpViupo0kEzavo=; b=PyjYiXx1JJHfIZA4kAOC7EGN/KhQdJgM+jxnxOevm8EaxJq8pfi1I3LIt4a64ed2CE SocZ7t+5OUQ5xI4Ov4aXPhbjPeAKnRu5sfYilbjbhhfebQDQA9jwpy+kmYLsr8LQ1SO0 hfphUE01mzcoGzCFq9MfO5nUdQk5dLjHZdOOmEuLboCiFieO5jg29rr8h5hkW8rxrePQ zSR3+XK0mnRCcV0Jhc0RNr+p3Ryf+MyDu8kKpsdl7QiaPd2TnldNhW5glKpouOAbU/Ti fbRMxuQb6H6tudjURYBaEov9K/RQO9GgEmjMwL5WyH0JUJWIAcLIjzJagAwMPEiRzOSM l8Iw== X-Gm-Message-State: AAQBX9eNp0L/5Ld5yV5Vf/S1Je1qYZpd3piRuN2u82Za2nXXoK2oQVVr AzUdNGqo2CYG5fqj7RPATd3SBg== X-Google-Smtp-Source: AKy350ab1egrbimBmhajh9GEqufBtAURJQuxG6H/Hs7JpaNOdz6mu7HJAmIyOPKcGGllVT4MOOnVWA== X-Received: by 2002:adf:df85:0:b0:2ce:a85f:1313 with SMTP id z5-20020adfdf85000000b002cea85f1313mr3358628wrl.35.1680689989199; Wed, 05 Apr 2023 03:19:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sunil Muthuswamy Subject: [PATCH 13/14] accel: Inline WHPX get_whpx_vcpu() Date: Wed, 5 Apr 2023 12:18:10 +0200 Message-Id: <20230405101811.76663-14-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No need for this helper to access the CPUState::accel field. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/whpx/whpx-all.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 2372c4227a..2cca6bc004 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -256,15 +256,6 @@ static bool whpx_has_xsave(void) return whpx_xsave_cap.XsaveSupport; } -/* - * VP support - */ - -static struct AccelvCPUState *get_whpx_vcpu(CPUState *cpu) -{ - return (struct AccelvCPUState *)cpu->accel; -} - static WHV_X64_SEGMENT_REGISTER whpx_seg_q2h(const SegmentCache *qs, int v86, int r86) { @@ -390,7 +381,7 @@ static uint64_t whpx_cr8_to_apic_tpr(uint64_t cr8) static void whpx_set_registers(CPUState *cpu, int level) { struct whpx_state *whpx = &whpx_global; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); struct whpx_register_set vcxt; @@ -609,7 +600,7 @@ static void whpx_get_xcrs(CPUState *cpu) static void whpx_get_registers(CPUState *cpu) { struct whpx_state *whpx = &whpx_global; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); struct whpx_register_set vcxt; @@ -892,7 +883,7 @@ static const WHV_EMULATOR_CALLBACKS whpx_emu_callbacks = { static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx) { HRESULT hr; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; WHV_EMULATOR_STATUS emu_status; hr = whp_dispatch.WHvEmulatorTryMmioEmulation( @@ -917,7 +908,7 @@ static int whpx_handle_portio(CPUState *cpu, WHV_X64_IO_PORT_ACCESS_CONTEXT *ctx) { HRESULT hr; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; WHV_EMULATOR_STATUS emu_status; hr = whp_dispatch.WHvEmulatorTryIoEmulation( @@ -1417,7 +1408,7 @@ static vaddr whpx_vcpu_get_pc(CPUState *cpu, bool exit_context_valid) * of QEMU, nor this port by calling WHvSetVirtualProcessorRegisters(). * This is the most common case. */ - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; return vcpu->exit_ctx.VpContext.Rip; } else { /* @@ -1468,7 +1459,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) { HRESULT hr; struct whpx_state *whpx = &whpx_global; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); int irq; @@ -1590,7 +1581,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) static void whpx_vcpu_post_run(CPUState *cpu) { - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); @@ -1617,7 +1608,7 @@ static void whpx_vcpu_process_async_events(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; if ((cpu->interrupt_request & CPU_INTERRUPT_INIT) && !(env->hflags & HF_SMM_MASK)) { @@ -1656,7 +1647,7 @@ static int whpx_vcpu_run(CPUState *cpu) { HRESULT hr; struct whpx_state *whpx = &whpx_global; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; struct whpx_breakpoint *stepped_over_bp = NULL; WhpxStepMode exclusive_step_mode = WHPX_STEP_NONE; int ret; @@ -2296,7 +2287,7 @@ int whpx_vcpu_exec(CPUState *cpu) void whpx_destroy_vcpu(CPUState *cpu) { struct whpx_state *whpx = &whpx_global; - struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = cpu->accel; whp_dispatch.WHvDeleteVirtualProcessor(whpx->partition, cpu->cpu_index); whp_dispatch.WHvEmulatorDestroyEmulator(vcpu->emulator); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:29:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518421.804972 (Exim 4.92) (envelope-from ) id 1pk0Ny-0000Fo-I2; Wed, 05 Apr 2023 10:29:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518421.804972; Wed, 05 Apr 2023 10:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ny-0000EP-CV; Wed, 05 Apr 2023 10:29:02 +0000 Received: by outflank-mailman (input) for mailman id 518421; Wed, 05 Apr 2023 10:29:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0FE-0002Na-Hl for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:20:00 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6af48c46-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:19:58 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id e18so35637518wra.9 for ; Wed, 05 Apr 2023 03:19:58 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id e11-20020a5d4e8b000000b002cde626cd96sm14624762wru.65.2023.04.05.03.19.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6af48c46-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Byk5LNB9PsG7qsnBIJRRo9JOVccGApJy+cx27j4c9fU=; b=zy6RoKZl3HFi+Q0vtR3UwohHMiMsWOn2/ul3EQVzNnehPXDwziBD8kN5oz8YFLSGXj z/JbV/w7gRjJU5xeR6Z9EK4Q7ekBR7AroyEWwqox013ocsFMmdaA4ZWf2wIKs/m2o1XP +/We8oxS7dteLdYGU8FLDvQO4VX6Suu2gr/VvXj3kZJ2FFAYoGMXBduf7o4qkVPTQNmu 0HhVtRaZCSFq9x8ZTK0MirJoKqdYOdV5BlEMLWbn5vWNkxftascntbFIYwA0uUlQwF/C 2xBShpUeR7qjrBXuhSVb8YEJTUIHLJJZrHR3rxKsIkhUvcQpcNTzRCtk+oyEz9o0QBbV o/PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Byk5LNB9PsG7qsnBIJRRo9JOVccGApJy+cx27j4c9fU=; b=mf2mSuq7lG7kdyKvB3AKbk066NpQugEV7T8gte70Y9jln6/UH+lbZuitS3iykbIXz8 /SH809xBOkLvEu4RnfoqLyxEsfxpEpbJILWmh7XLCglk3zOO2kaVcV4ToPjdG35XXf2g YAb8OqvckT8C60RdDK3AwnP4CR6SLw4P4wem2jdnaGzDjA/F1eplyRw2wNCjXIERv0Wb FMjjn3BChuB0jPcySVo1PRb9GxiBsD5ZIbml+4f5MgqIKHdlbw3QOpt4/FS6m6BE9HB/ 5laUlPslxOlybzK1TPZ1+yolGw9SVlJcmjPxWl9hSkaFP6+sWT9A7t+GYTSFb/guLowl N4VQ== X-Gm-Message-State: AAQBX9fSc+Ujt51dv1LNZU/FY7M5KSt1+rNFtWK5wpFJOcncDFb0NQPJ r4L6LmKXb7aaI4sLHiYvcNSuDA== X-Google-Smtp-Source: AKy350ZkCRxUlRNTXX0kIqDAWFewpV/6tQ9nx8c+rFpbVyobQsMD1OzgOrzwPflhmrDI+QR50xCA9g== X-Received: by 2002:a5d:42c1:0:b0:2cf:eeae:88c3 with SMTP id t1-20020a5d42c1000000b002cfeeae88c3mr3555848wrr.32.1680689998344; Wed, 05 Apr 2023 03:19:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cameron Esfahani , Roman Bolshakov , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Alexander Graf , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 14/14] accel: Rename HVF struct hvf_vcpu_state -> struct AccelvCPUState Date: Wed, 5 Apr 2023 12:18:11 +0200 Message-Id: <20230405101811.76663-15-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We want all accelerators to share the same opaque pointer in CPUState. Rename the 'hvf_vcpu_state' structure as 'AccelvCPUState'. Use the generic 'accel' field of CPUState instead of 'hvf'. Replace g_malloc0() by g_new0() for readability. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 3 -- include/sysemu/hvf_int.h | 2 +- accel/hvf/hvf-accel-ops.c | 16 ++++----- target/arm/hvf/hvf.c | 70 +++++++++++++++++++-------------------- 4 files changed, 44 insertions(+), 47 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 8d27861ed5..1dc5efe650 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -236,7 +236,6 @@ typedef struct SavedIOTLB { struct KVMState; struct kvm_run; struct AccelvCPUState; -struct hvf_vcpu_state; /* work queue */ @@ -442,8 +441,6 @@ struct CPUState { /* Used for user-only emulation of prctl(PR_SET_UNALIGN). */ bool prctl_unalign_sigbus; - struct hvf_vcpu_state *hvf; - /* track IOMMUs whose translations we've cached in the TCG TLB */ GArray *iommu_notifiers; }; diff --git a/include/sysemu/hvf_int.h b/include/sysemu/hvf_int.h index 6545f7cd61..96ef51f4df 100644 --- a/include/sysemu/hvf_int.h +++ b/include/sysemu/hvf_int.h @@ -48,7 +48,7 @@ struct HVFState { }; extern HVFState *hvf_state; -struct hvf_vcpu_state { +struct AccelvCPUState { uint64_t fd; void *exit; bool vtimer_masked; diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 24913ca9c4..06ca1d59a4 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -363,19 +363,19 @@ type_init(hvf_type_init); static void hvf_vcpu_destroy(CPUState *cpu) { - hv_return_t ret = hv_vcpu_destroy(cpu->hvf->fd); + hv_return_t ret = hv_vcpu_destroy(cpu->accel->fd); assert_hvf_ok(ret); hvf_arch_vcpu_destroy(cpu); - g_free(cpu->hvf); - cpu->hvf = NULL; + g_free(cpu->accel); + cpu->accel = NULL; } static int hvf_init_vcpu(CPUState *cpu) { int r; - cpu->hvf = g_malloc0(sizeof(*cpu->hvf)); + cpu->accel = g_new0(struct AccelvCPUState, 1); /* init cpu signals */ struct sigaction sigact; @@ -384,13 +384,13 @@ static int hvf_init_vcpu(CPUState *cpu) sigact.sa_handler = dummy_signal; sigaction(SIG_IPI, &sigact, NULL); - pthread_sigmask(SIG_BLOCK, NULL, &cpu->hvf->unblock_ipi_mask); - sigdelset(&cpu->hvf->unblock_ipi_mask, SIG_IPI); + pthread_sigmask(SIG_BLOCK, NULL, &cpu->accel->unblock_ipi_mask); + sigdelset(&cpu->accel->unblock_ipi_mask, SIG_IPI); #ifdef __aarch64__ - r = hv_vcpu_create(&cpu->hvf->fd, (hv_vcpu_exit_t **)&cpu->hvf->exit, NULL); + r = hv_vcpu_create(&cpu->accel->fd, (hv_vcpu_exit_t **)&cpu->accel->exit, NULL); #else - r = hv_vcpu_create((hv_vcpuid_t *)&cpu->hvf->fd, HV_VCPU_DEFAULT); + r = hv_vcpu_create((hv_vcpuid_t *)&cpu->accel->fd, HV_VCPU_DEFAULT); #endif cpu->vcpu_dirty = 1; assert_hvf_ok(r); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index ad65603445..b85648b61c 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -366,29 +366,29 @@ int hvf_get_registers(CPUState *cpu) int i; for (i = 0; i < ARRAY_SIZE(hvf_reg_match); i++) { - ret = hv_vcpu_get_reg(cpu->hvf->fd, hvf_reg_match[i].reg, &val); + ret = hv_vcpu_get_reg(cpu->accel->fd, hvf_reg_match[i].reg, &val); *(uint64_t *)((void *)env + hvf_reg_match[i].offset) = val; assert_hvf_ok(ret); } for (i = 0; i < ARRAY_SIZE(hvf_fpreg_match); i++) { - ret = hv_vcpu_get_simd_fp_reg(cpu->hvf->fd, hvf_fpreg_match[i].reg, + ret = hv_vcpu_get_simd_fp_reg(cpu->accel->fd, hvf_fpreg_match[i].reg, &fpval); memcpy((void *)env + hvf_fpreg_match[i].offset, &fpval, sizeof(fpval)); assert_hvf_ok(ret); } val = 0; - ret = hv_vcpu_get_reg(cpu->hvf->fd, HV_REG_FPCR, &val); + ret = hv_vcpu_get_reg(cpu->accel->fd, HV_REG_FPCR, &val); assert_hvf_ok(ret); vfp_set_fpcr(env, val); val = 0; - ret = hv_vcpu_get_reg(cpu->hvf->fd, HV_REG_FPSR, &val); + ret = hv_vcpu_get_reg(cpu->accel->fd, HV_REG_FPSR, &val); assert_hvf_ok(ret); vfp_set_fpsr(env, val); - ret = hv_vcpu_get_reg(cpu->hvf->fd, HV_REG_CPSR, &val); + ret = hv_vcpu_get_reg(cpu->accel->fd, HV_REG_CPSR, &val); assert_hvf_ok(ret); pstate_write(env, val); @@ -397,7 +397,7 @@ int hvf_get_registers(CPUState *cpu) continue; } - ret = hv_vcpu_get_sys_reg(cpu->hvf->fd, hvf_sreg_match[i].reg, &val); + ret = hv_vcpu_get_sys_reg(cpu->accel->fd, hvf_sreg_match[i].reg, &val); assert_hvf_ok(ret); arm_cpu->cpreg_values[hvf_sreg_match[i].cp_idx] = val; @@ -420,24 +420,24 @@ int hvf_put_registers(CPUState *cpu) for (i = 0; i < ARRAY_SIZE(hvf_reg_match); i++) { val = *(uint64_t *)((void *)env + hvf_reg_match[i].offset); - ret = hv_vcpu_set_reg(cpu->hvf->fd, hvf_reg_match[i].reg, val); + ret = hv_vcpu_set_reg(cpu->accel->fd, hvf_reg_match[i].reg, val); assert_hvf_ok(ret); } for (i = 0; i < ARRAY_SIZE(hvf_fpreg_match); i++) { memcpy(&fpval, (void *)env + hvf_fpreg_match[i].offset, sizeof(fpval)); - ret = hv_vcpu_set_simd_fp_reg(cpu->hvf->fd, hvf_fpreg_match[i].reg, + ret = hv_vcpu_set_simd_fp_reg(cpu->accel->fd, hvf_fpreg_match[i].reg, fpval); assert_hvf_ok(ret); } - ret = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_FPCR, vfp_get_fpcr(env)); + ret = hv_vcpu_set_reg(cpu->accel->fd, HV_REG_FPCR, vfp_get_fpcr(env)); assert_hvf_ok(ret); - ret = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_FPSR, vfp_get_fpsr(env)); + ret = hv_vcpu_set_reg(cpu->accel->fd, HV_REG_FPSR, vfp_get_fpsr(env)); assert_hvf_ok(ret); - ret = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_CPSR, pstate_read(env)); + ret = hv_vcpu_set_reg(cpu->accel->fd, HV_REG_CPSR, pstate_read(env)); assert_hvf_ok(ret); aarch64_save_sp(env, arm_current_el(env)); @@ -449,11 +449,11 @@ int hvf_put_registers(CPUState *cpu) } val = arm_cpu->cpreg_values[hvf_sreg_match[i].cp_idx]; - ret = hv_vcpu_set_sys_reg(cpu->hvf->fd, hvf_sreg_match[i].reg, val); + ret = hv_vcpu_set_sys_reg(cpu->accel->fd, hvf_sreg_match[i].reg, val); assert_hvf_ok(ret); } - ret = hv_vcpu_set_vtimer_offset(cpu->hvf->fd, hvf_state->vtimer_offset); + ret = hv_vcpu_set_vtimer_offset(cpu->accel->fd, hvf_state->vtimer_offset); assert_hvf_ok(ret); return 0; @@ -474,7 +474,7 @@ static void hvf_set_reg(CPUState *cpu, int rt, uint64_t val) flush_cpu_state(cpu); if (rt < 31) { - r = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_X0 + rt, val); + r = hv_vcpu_set_reg(cpu->accel->fd, HV_REG_X0 + rt, val); assert_hvf_ok(r); } } @@ -487,7 +487,7 @@ static uint64_t hvf_get_reg(CPUState *cpu, int rt) flush_cpu_state(cpu); if (rt < 31) { - r = hv_vcpu_get_reg(cpu->hvf->fd, HV_REG_X0 + rt, &val); + r = hv_vcpu_get_reg(cpu->accel->fd, HV_REG_X0 + rt, &val); assert_hvf_ok(r); } @@ -629,22 +629,22 @@ int hvf_arch_init_vcpu(CPUState *cpu) assert(write_cpustate_to_list(arm_cpu, false)); /* Set CP_NO_RAW system registers on init */ - ret = hv_vcpu_set_sys_reg(cpu->hvf->fd, HV_SYS_REG_MIDR_EL1, + ret = hv_vcpu_set_sys_reg(cpu->accel->fd, HV_SYS_REG_MIDR_EL1, arm_cpu->midr); assert_hvf_ok(ret); - ret = hv_vcpu_set_sys_reg(cpu->hvf->fd, HV_SYS_REG_MPIDR_EL1, + ret = hv_vcpu_set_sys_reg(cpu->accel->fd, HV_SYS_REG_MPIDR_EL1, arm_cpu->mp_affinity); assert_hvf_ok(ret); - ret = hv_vcpu_get_sys_reg(cpu->hvf->fd, HV_SYS_REG_ID_AA64PFR0_EL1, &pfr); + ret = hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_ID_AA64PFR0_EL1, &pfr); assert_hvf_ok(ret); pfr |= env->gicv3state ? (1 << 24) : 0; - ret = hv_vcpu_set_sys_reg(cpu->hvf->fd, HV_SYS_REG_ID_AA64PFR0_EL1, pfr); + ret = hv_vcpu_set_sys_reg(cpu->accel->fd, HV_SYS_REG_ID_AA64PFR0_EL1, pfr); assert_hvf_ok(ret); /* We're limited to underlying hardware caps, override internal versions */ - ret = hv_vcpu_get_sys_reg(cpu->hvf->fd, HV_SYS_REG_ID_AA64MMFR0_EL1, + ret = hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_ID_AA64MMFR0_EL1, &arm_cpu->isar.id_aa64mmfr0); assert_hvf_ok(ret); @@ -654,7 +654,7 @@ int hvf_arch_init_vcpu(CPUState *cpu) void hvf_kick_vcpu_thread(CPUState *cpu) { cpus_kick_thread(cpu); - hv_vcpus_exit(&cpu->hvf->fd, 1); + hv_vcpus_exit(&cpu->accel->fd, 1); } static void hvf_raise_exception(CPUState *cpu, uint32_t excp, @@ -1191,13 +1191,13 @@ static int hvf_inject_interrupts(CPUState *cpu) { if (cpu->interrupt_request & CPU_INTERRUPT_FIQ) { trace_hvf_inject_fiq(); - hv_vcpu_set_pending_interrupt(cpu->hvf->fd, HV_INTERRUPT_TYPE_FIQ, + hv_vcpu_set_pending_interrupt(cpu->accel->fd, HV_INTERRUPT_TYPE_FIQ, true); } if (cpu->interrupt_request & CPU_INTERRUPT_HARD) { trace_hvf_inject_irq(); - hv_vcpu_set_pending_interrupt(cpu->hvf->fd, HV_INTERRUPT_TYPE_IRQ, + hv_vcpu_set_pending_interrupt(cpu->accel->fd, HV_INTERRUPT_TYPE_IRQ, true); } @@ -1231,7 +1231,7 @@ static void hvf_wait_for_ipi(CPUState *cpu, struct timespec *ts) */ qatomic_mb_set(&cpu->thread_kicked, false); qemu_mutex_unlock_iothread(); - pselect(0, 0, 0, 0, ts, &cpu->hvf->unblock_ipi_mask); + pselect(0, 0, 0, 0, ts, &cpu->accel->unblock_ipi_mask); qemu_mutex_lock_iothread(); } @@ -1252,7 +1252,7 @@ static void hvf_wfi(CPUState *cpu) return; } - r = hv_vcpu_get_sys_reg(cpu->hvf->fd, HV_SYS_REG_CNTV_CTL_EL0, &ctl); + r = hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_CNTV_CTL_EL0, &ctl); assert_hvf_ok(r); if (!(ctl & 1) || (ctl & 2)) { @@ -1261,7 +1261,7 @@ static void hvf_wfi(CPUState *cpu) return; } - r = hv_vcpu_get_sys_reg(cpu->hvf->fd, HV_SYS_REG_CNTV_CVAL_EL0, &cval); + r = hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_CNTV_CVAL_EL0, &cval); assert_hvf_ok(r); ticks_to_sleep = cval - hvf_vtimer_val(); @@ -1294,12 +1294,12 @@ static void hvf_sync_vtimer(CPUState *cpu) uint64_t ctl; bool irq_state; - if (!cpu->hvf->vtimer_masked) { + if (!cpu->accel->vtimer_masked) { /* We will get notified on vtimer changes by hvf, nothing to do */ return; } - r = hv_vcpu_get_sys_reg(cpu->hvf->fd, HV_SYS_REG_CNTV_CTL_EL0, &ctl); + r = hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_CNTV_CTL_EL0, &ctl); assert_hvf_ok(r); irq_state = (ctl & (TMR_CTL_ENABLE | TMR_CTL_IMASK | TMR_CTL_ISTATUS)) == @@ -1308,8 +1308,8 @@ static void hvf_sync_vtimer(CPUState *cpu) if (!irq_state) { /* Timer no longer asserting, we can unmask it */ - hv_vcpu_set_vtimer_mask(cpu->hvf->fd, false); - cpu->hvf->vtimer_masked = false; + hv_vcpu_set_vtimer_mask(cpu->accel->fd, false); + cpu->accel->vtimer_masked = false; } } @@ -1317,7 +1317,7 @@ int hvf_vcpu_exec(CPUState *cpu) { ARMCPU *arm_cpu = ARM_CPU(cpu); CPUARMState *env = &arm_cpu->env; - hv_vcpu_exit_t *hvf_exit = cpu->hvf->exit; + hv_vcpu_exit_t *hvf_exit = cpu->accel->exit; hv_return_t r; bool advance_pc = false; @@ -1332,7 +1332,7 @@ int hvf_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); qemu_mutex_unlock_iothread(); - assert_hvf_ok(hv_vcpu_run(cpu->hvf->fd)); + assert_hvf_ok(hv_vcpu_run(cpu->accel->fd)); /* handle VMEXIT */ uint64_t exit_reason = hvf_exit->reason; @@ -1346,7 +1346,7 @@ int hvf_vcpu_exec(CPUState *cpu) break; case HV_EXIT_REASON_VTIMER_ACTIVATED: qemu_set_irq(arm_cpu->gt_timer_outputs[GTIMER_VIRT], 1); - cpu->hvf->vtimer_masked = true; + cpu->accel->vtimer_masked = true; return 0; case HV_EXIT_REASON_CANCELED: /* we got kicked, no exit to process */ @@ -1457,10 +1457,10 @@ int hvf_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); - r = hv_vcpu_get_reg(cpu->hvf->fd, HV_REG_PC, &pc); + r = hv_vcpu_get_reg(cpu->accel->fd, HV_REG_PC, &pc); assert_hvf_ok(r); pc += 4; - r = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_PC, pc); + r = hv_vcpu_set_reg(cpu->accel->fd, HV_REG_PC, pc); assert_hvf_ok(r); } -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:29:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:29:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518423.804979 (Exim 4.92) (envelope-from ) id 1pk0Nz-0000NT-16; Wed, 05 Apr 2023 10:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518423.804979; Wed, 05 Apr 2023 10:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ny-0000L1-Qg; Wed, 05 Apr 2023 10:29:02 +0000 Received: by outflank-mailman (input) for mailman id 518423; Wed, 05 Apr 2023 10:29:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0ES-00024X-SF for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:12 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f45fb5b-d39b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:19:12 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id n19so20587973wms.0 for ; Wed, 05 Apr 2023 03:19:12 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id y5-20020a1c4b05000000b003ede06f3178sm1730449wma.31.2023.04.05.03.19.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f45fb5b-d39b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RAVav4ABEpIiF2Ib5SEI8jHJn5J3YAuyzrKJBGzco1s=; b=hHxXSS6O9+86vT2m6d0DTc+hiT8gaRNGAVM+7W9qw5K7dcdKYYbh0E7lvSzpkYn368 fOMNZZP/1e+qRYjuveniW+hqJPeXRIDEN0l73ChMXeJHLmaPOblTjTKGwBGBBShSS3FY MjxZ0uY781JiDGIyrZ2Wmf9jZfbEMqhXfcJrGMdfGEFfNJ40NRBoRK/JRBa+tS5fdI92 eU/ZF0jqD4wzOX6Sr/86Q1BA8EHQgHGTKipyyzmSWtpcvo657D+2/e3mC0kuVQ+XljSH s07gbWhPjhP4utq/Kj/s6MnBKF2BXRP7AOXf6kw6C44JcSBNEeM091V355Hm/Q/Y0H3V Xa9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RAVav4ABEpIiF2Ib5SEI8jHJn5J3YAuyzrKJBGzco1s=; b=r0T/AgGQgPTwWlFRuvSMOVNOkd3Eg89SaacytUiZgbkguQ0bMbB+kiUEylaneX+tQQ VvaSIPzIz9ZoAwd+YdLsmWwD4Dl8F0/gLncgYxdmxZC+ghIXnznrMEpyGf3CJfESIyXa IHzIH0jdOKZQgQr6/5G1QidfGAYNnsA79PX0ywMOcLa3fIas1mntpdtRCoj2W8gwAmB2 h2Jj36abKocfiCQnRuQVCUN7C7N3BYbQCkX/ySVrDvNzwThAIt79+N4rAfrcy1uRWiUi MmWHbAT2ODcniJrtDcAl0F89/TsRA+vNEfKq+LoIfgYx3Ejo4CgFvyTN3kFscFGwLqPO ADPg== X-Gm-Message-State: AAQBX9eLn0bTzTKqijVcuVsRo4ag9vwO9B/irOvAQFjNJXI2PX2glKd7 bN78kTUp+PUHaogTff+bhLwMg5EwWpnNd4dZof4= X-Google-Smtp-Source: AKy350Zr65D5G7Y2SXbNR//LfCiPeKcYs21bo5zZhAXH6JQLmNB2HwLRUfAeUMYH/5tXslpZRuo8zQ== X-Received: by 2002:a05:600c:28f:b0:3ea:bc08:b63e with SMTP id 15-20020a05600c028f00b003eabc08b63emr4378808wmk.2.1680689951840; Wed, 05 Apr 2023 03:19:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang Subject: [PATCH 08/14] accel: Move HAX hThread to accelerator context Date: Wed, 5 Apr 2023 12:18:05 +0200 Message-Id: <20230405101811.76663-9-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hThread variable is only used by the HAX accelerator, so move it to the accelerator specific context. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 1 - target/i386/hax/hax-i386.h | 3 +++ target/i386/hax/hax-accel-ops.c | 2 +- target/i386/hax/hax-all.c | 2 +- target/i386/hax/hax-windows.c | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 173f47d24e..8d27861ed5 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -334,7 +334,6 @@ struct CPUState { struct QemuThread *thread; #ifdef _WIN32 - HANDLE hThread; QemuSemaphore sem; #endif int thread_id; diff --git a/target/i386/hax/hax-i386.h b/target/i386/hax/hax-i386.h index d11d43e857..15d16772db 100644 --- a/target/i386/hax/hax-i386.h +++ b/target/i386/hax/hax-i386.h @@ -27,6 +27,9 @@ typedef HANDLE hax_fd; extern struct hax_state hax_global; typedef struct AccelvCPUState { +#ifdef _WIN32 + HANDLE hThread; +#endif hax_fd fd; int vcpu_id; struct hax_tunnel *tunnel; diff --git a/target/i386/hax/hax-accel-ops.c b/target/i386/hax/hax-accel-ops.c index a8512efcd5..5031096760 100644 --- a/target/i386/hax/hax-accel-ops.c +++ b/target/i386/hax/hax-accel-ops.c @@ -73,7 +73,7 @@ static void hax_start_vcpu_thread(CPUState *cpu) cpu, QEMU_THREAD_JOINABLE); assert(cpu->accel); #ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); + cpu->accel->hThread = qemu_thread_get_handle(cpu->thread); #endif } diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index a55b18f353..c9ccc411e9 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -206,7 +206,7 @@ int hax_vcpu_destroy(CPUState *cpu) hax_close_fd(vcpu->fd); hax_global.vm->vcpus[vcpu->vcpu_id] = NULL; #ifdef _WIN32 - CloseHandle(cpu->hThread); + CloseHandle(vcpu->hThread); #endif g_free(vcpu); cpu->accel = NULL; diff --git a/target/i386/hax/hax-windows.c b/target/i386/hax/hax-windows.c index 08ec93a256..b907953321 100644 --- a/target/i386/hax/hax-windows.c +++ b/target/i386/hax/hax-windows.c @@ -476,7 +476,7 @@ void hax_kick_vcpu_thread(CPUState *cpu) */ cpu->exit_request = 1; if (!qemu_cpu_is_self(cpu)) { - if (!QueueUserAPC(dummy_apc_func, cpu->hThread, 0)) { + if (!QueueUserAPC(dummy_apc_func, cpu->accel->hThread, 0)) { fprintf(stderr, "%s: QueueUserAPC failed with error %lu\n", __func__, GetLastError()); exit(1); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:29:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:29:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518425.804987 (Exim 4.92) (envelope-from ) id 1pk0Nz-0000YS-Mz; Wed, 05 Apr 2023 10:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518425.804987; Wed, 05 Apr 2023 10:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Nz-0000XE-EY; Wed, 05 Apr 2023 10:29:03 +0000 Received: by outflank-mailman (input) for mailman id 518425; Wed, 05 Apr 2023 10:29:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ep-00024X-Ua for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:36 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5cfe3fec-d39b-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:19:35 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso858463wmr.0 for ; Wed, 05 Apr 2023 03:19:35 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id d21-20020a1c7315000000b003ed1f6878a5sm1770353wmb.5.2023.04.05.03.19.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cfe3fec-d39b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=reJpuebcoI5BKEfS88SjCkcplXXPmguVbMU9Olmibx0=; b=Q2+dqv8HKpPQKTf9cQJSeqsGPGkeqsXxu8v+C2JYWo/wkdpZHobUDc9N35z1UbQyXo 9C6lndVpWvjoGdquQUathNsJoiIiN7nJn3kgNVvT5T7tc01blota5eXmXHc1hE2a/9ew 2Wf7CCzhPcSAgNhjaTij8S5PpdLVkajwG2fdrCTckKDaeIUqcPO5ZI4SEhoPCSlpK/xc jQRVVytzUEGa2Ydc7bSMmlI+Bj89/EomAs72KzqL8mlaSY0qlyPq25y3stucFF3G2pSS /sRRUshA2hioO50En8HSMUOtDGPuoJV66S46OhB8lo7qSEotmJH2F75Zpnda8gdb6yr0 tHhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=reJpuebcoI5BKEfS88SjCkcplXXPmguVbMU9Olmibx0=; b=5ElheQRINiX2Ygsg/9tU8tpk0LQunD3JUPGDFeZwRYP1TtH8mbnZJmvwLhbfgeHWHk +BQ6UkGmVrNTjCsFcIrf60S3VVPZQPZj2wUs7jR37tjZtSTVxbUInqLz75TuCKxtipsx uaeEV2avu4/T4+WKR97w3vwbHeThGL2NwhfCdpnHoIb9w4CGbsvBeC/NNSNfwbojrVI4 ui6UNsBBHjZWaC+0/HlLawEiG7POxUmobF1nDTXrTWd7DiBuflUl6eINn0Z7ziZfE8jP GMgrXbrW2tT7rLhcQAc/bD78jYzDQvGJ/1dhvXA6ga/Yk70b5Beq2Fq5IaBNRG/pb+ZE FDHw== X-Gm-Message-State: AAQBX9ces/GWJ5T9bHIDWyxyrMmG9qEtbpkFLhjcJ9/N6dwDkHW6NXBJ ugRwI8rpMBt0S/5COyowdsxMLA== X-Google-Smtp-Source: AKy350ZAz7PsFWbSoWRxQBkCoHp/n/DjoRXVF/1COGNHcX9m4lAa529X6M54U1ZwDgyYhrM/EeN7Fw== X-Received: by 2002:a1c:7717:0:b0:3f0:48f4:8454 with SMTP id t23-20020a1c7717000000b003f048f48454mr4350332wmi.27.1680689974915; Wed, 05 Apr 2023 03:19:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Reinoud Zandijk Subject: [PATCH 11/14] accel: Inline NVMM get_qemu_vcpu() Date: Wed, 5 Apr 2023 12:18:08 +0200 Message-Id: <20230405101811.76663-12-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No need for this helper to access the CPUState::accel field. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index 97a7225598..1c0168d83c 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -49,12 +49,6 @@ struct qemu_machine { static bool nvmm_allowed; static struct qemu_machine qemu_mach; -static struct AccelvCPUState * -get_qemu_vcpu(CPUState *cpu) -{ - return cpu->accel; -} - static struct nvmm_machine * get_nvmm_mach(void) { @@ -86,7 +80,7 @@ nvmm_set_registers(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; struct nvmm_x64_state *state = vcpu->state; uint64_t bitmap; @@ -223,7 +217,7 @@ nvmm_get_registers(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -347,7 +341,7 @@ static bool nvmm_can_take_int(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; struct nvmm_machine *mach = get_nvmm_mach(); @@ -372,7 +366,7 @@ nvmm_can_take_int(CPUState *cpu) static bool nvmm_can_take_nmi(CPUState *cpu) { - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; /* * Contrary to INTs, NMIs always schedule an exit when they are @@ -395,7 +389,7 @@ nvmm_vcpu_pre_run(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -478,7 +472,7 @@ nvmm_vcpu_pre_run(CPUState *cpu) static void nvmm_vcpu_post_run(CPUState *cpu, struct nvmm_vcpu_exit *exit) { - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); uint64_t tpr; @@ -565,7 +559,7 @@ static int nvmm_handle_rdmsr(struct nvmm_machine *mach, CPUState *cpu, struct nvmm_vcpu_exit *exit) { - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -610,7 +604,7 @@ static int nvmm_handle_wrmsr(struct nvmm_machine *mach, CPUState *cpu, struct nvmm_vcpu_exit *exit) { - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_x64_state *state = vcpu->state; @@ -686,7 +680,7 @@ nvmm_vcpu_loop(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; struct nvmm_machine *mach = get_nvmm_mach(); - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; struct nvmm_vcpu *vcpu = &qcpu->vcpu; X86CPU *x86_cpu = X86_CPU(cpu); struct nvmm_vcpu_exit *exit = vcpu->exit; @@ -892,7 +886,7 @@ static void nvmm_ipi_signal(int sigcpu) { if (current_cpu) { - struct AccelvCPUState *qcpu = get_qemu_vcpu(current_cpu); + struct AccelvCPUState *qcpu = current_cpu->accel; #if NVMM_USER_VERSION >= 2 struct nvmm_vcpu *vcpu = &qcpu->vcpu; nvmm_vcpu_stop(vcpu); @@ -1027,7 +1021,7 @@ void nvmm_destroy_vcpu(CPUState *cpu) { struct nvmm_machine *mach = get_nvmm_mach(); - struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); + struct AccelvCPUState *qcpu = cpu->accel; nvmm_vcpu_destroy(mach, &qcpu->vcpu); g_free(cpu->accel); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:29:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:29:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518431.805008 (Exim 4.92) (envelope-from ) id 1pk0O4-0001Ny-4u; Wed, 05 Apr 2023 10:29:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518431.805008; Wed, 05 Apr 2023 10:29:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0O3-0001Ng-VT; Wed, 05 Apr 2023 10:29:07 +0000 Received: by outflank-mailman (input) for mailman id 518431; Wed, 05 Apr 2023 10:29:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ex-0002Na-A1 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:43 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60c82f71-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:19:41 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id l10-20020a05600c1d0a00b003f04bd3691eso6766053wms.5 for ; Wed, 05 Apr 2023 03:19:41 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c4f8700b003ee9c8cc631sm1780821wmq.23.2023.04.05.03.19.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c82f71-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S/MtLkEvv/mpFG8xdDJ5UGIDl6QuLPsc27INO07zRJs=; b=j3hNNVtnFSkeMmMMmVP7MwKIlYYAEqbhDpfKTMInG3a+9K0+YXceoJPZJ4jZAHCBFI VPa6eMgi/+9TXCgyr86xjuKK9t4zNhPlw7CAX0fvenTdKFSa3t+eBYp0hgH6m98d3/lR jnJJMwWe2cN5PCDDRMn3ZiOfvLvOx0KgfKGPNgpITrxaoDPAOFx1uqGJJWFNIk4jpdv7 NGGSO2xZQkFpOwy7mhzr21QREPPwjCH42qXvKwpRx5Hf1PwrV8q3x4WiQL9Zq/cJZpvA +TtnCQgltM297hRRmytaXGZhpTBrxwBYRmMmPEjntzUo7iHBOLTSWiIxfEFT8knJMWNo rgog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S/MtLkEvv/mpFG8xdDJ5UGIDl6QuLPsc27INO07zRJs=; b=ENxCQpKaZ/vJYYVAI/pNkWj5blaiw0Y3P01s+6CN3vcTM/wnO5KzZqAqqOxAsyFpie QfnEX4I1aWEWKrME2hatZaUin5d2tLTPrXy2j53kEEXCM0U8G5wLqJOODKrPQ29r0ZPb dqdceKwV/3insS9Sz3Gkw7sg2oLuBMdT4SbEMa9QRXXJF1Q0n1kr6SeHc6rANMz4ZWQA Zub2EHnAYv/TpLWsAPUVM2rFO+mBeZlDci4tSaQOKALtsLWi09g7qnC80CfNfopgY+bx KjW7byf3VkBTyx/FtdgyvGefna0HHurow6rJEbnGHgyTa5KGVHp7JQ6/WaI7VUxsQ7xd xMzA== X-Gm-Message-State: AAQBX9ee/CrNb48v9z13d39+WMgzcsZNjSDBQDTBlr7XhRNqq1gqFiLe foFpC3UFDFZ8uIL3qxhgYhTy9A== X-Google-Smtp-Source: AKy350ZceuduIKjGNIdlkcOLlYLJL5KbbisXjbggRXGoX4b3J2s4uJbs/AyE+v9R+USsxTJSDNjt2g== X-Received: by 2002:a1c:f707:0:b0:3ee:9909:acc8 with SMTP id v7-20020a1cf707000000b003ee9909acc8mr4174177wmh.32.1680689981231; Wed, 05 Apr 2023 03:19:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sunil Muthuswamy Subject: [PATCH 12/14] accel: Rename WHPX struct whpx_vcpu -> struct AccelvCPUState Date: Wed, 5 Apr 2023 12:18:09 +0200 Message-Id: <20230405101811.76663-13-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We want all accelerators to share the same opaque pointer in CPUState. Rename WHPX 'whpx_vcpu' as 'AccelvCPUState'. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/whpx/whpx-all.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 70eadb7f05..2372c4227a 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -229,7 +229,7 @@ typedef enum WhpxStepMode { WHPX_STEP_EXCLUSIVE, } WhpxStepMode; -struct whpx_vcpu { +struct AccelvCPUState { WHV_EMULATOR_HANDLE emulator; bool window_registered; bool interruptable; @@ -260,9 +260,9 @@ static bool whpx_has_xsave(void) * VP support */ -static struct whpx_vcpu *get_whpx_vcpu(CPUState *cpu) +static struct AccelvCPUState *get_whpx_vcpu(CPUState *cpu) { - return (struct whpx_vcpu *)cpu->accel; + return (struct AccelvCPUState *)cpu->accel; } static WHV_X64_SEGMENT_REGISTER whpx_seg_q2h(const SegmentCache *qs, int v86, @@ -390,7 +390,7 @@ static uint64_t whpx_cr8_to_apic_tpr(uint64_t cr8) static void whpx_set_registers(CPUState *cpu, int level) { struct whpx_state *whpx = &whpx_global; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); struct whpx_register_set vcxt; @@ -609,7 +609,7 @@ static void whpx_get_xcrs(CPUState *cpu) static void whpx_get_registers(CPUState *cpu) { struct whpx_state *whpx = &whpx_global; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); struct whpx_register_set vcxt; @@ -892,7 +892,7 @@ static const WHV_EMULATOR_CALLBACKS whpx_emu_callbacks = { static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx) { HRESULT hr; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); WHV_EMULATOR_STATUS emu_status; hr = whp_dispatch.WHvEmulatorTryMmioEmulation( @@ -917,7 +917,7 @@ static int whpx_handle_portio(CPUState *cpu, WHV_X64_IO_PORT_ACCESS_CONTEXT *ctx) { HRESULT hr; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); WHV_EMULATOR_STATUS emu_status; hr = whp_dispatch.WHvEmulatorTryIoEmulation( @@ -1417,7 +1417,7 @@ static vaddr whpx_vcpu_get_pc(CPUState *cpu, bool exit_context_valid) * of QEMU, nor this port by calling WHvSetVirtualProcessorRegisters(). * This is the most common case. */ - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); return vcpu->exit_ctx.VpContext.Rip; } else { /* @@ -1468,7 +1468,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) { HRESULT hr; struct whpx_state *whpx = &whpx_global; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); int irq; @@ -1590,7 +1590,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) static void whpx_vcpu_post_run(CPUState *cpu) { - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); @@ -1617,7 +1617,7 @@ static void whpx_vcpu_process_async_events(CPUState *cpu) { CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); if ((cpu->interrupt_request & CPU_INTERRUPT_INIT) && !(env->hflags & HF_SMM_MASK)) { @@ -1656,7 +1656,7 @@ static int whpx_vcpu_run(CPUState *cpu) { HRESULT hr; struct whpx_state *whpx = &whpx_global; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); struct whpx_breakpoint *stepped_over_bp = NULL; WhpxStepMode exclusive_step_mode = WHPX_STEP_NONE; int ret; @@ -2154,7 +2154,7 @@ int whpx_init_vcpu(CPUState *cpu) { HRESULT hr; struct whpx_state *whpx = &whpx_global; - struct whpx_vcpu *vcpu = NULL; + struct AccelvCPUState *vcpu = NULL; Error *local_error = NULL; CPUX86State *env = cpu->env_ptr; X86CPU *x86_cpu = X86_CPU(cpu); @@ -2177,7 +2177,7 @@ int whpx_init_vcpu(CPUState *cpu) } } - vcpu = g_new0(struct whpx_vcpu, 1); + vcpu = g_new0(struct AccelvCPUState, 1); if (!vcpu) { error_report("WHPX: Failed to allocte VCPU context."); @@ -2296,7 +2296,7 @@ int whpx_vcpu_exec(CPUState *cpu) void whpx_destroy_vcpu(CPUState *cpu) { struct whpx_state *whpx = &whpx_global; - struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu); + struct AccelvCPUState *vcpu = get_whpx_vcpu(cpu); whp_dispatch.WHvDeleteVirtualProcessor(whpx->partition, cpu->cpu_index); whp_dispatch.WHvEmulatorDestroyEmulator(vcpu->emulator); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:29:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:29:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518433.805014 (Exim 4.92) (envelope-from ) id 1pk0O4-0001S9-IF; Wed, 05 Apr 2023 10:29:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518433.805014; Wed, 05 Apr 2023 10:29:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0O4-0001RM-9g; Wed, 05 Apr 2023 10:29:08 +0000 Received: by outflank-mailman (input) for mailman id 518433; Wed, 05 Apr 2023 10:29:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Ea-0002Na-UF for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:19:20 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53612bd7-d39b-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:19:19 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id r11so35629067wrr.12 for ; Wed, 05 Apr 2023 03:19:19 -0700 (PDT) Received: from localhost.localdomain (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id s11-20020a5d424b000000b002e5f6f8fc4fsm14040108wrr.100.2023.04.05.03.19.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 05 Apr 2023 03:19:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53612bd7-d39b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680689959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EBsjiWXEyjNdcnK7CdgNfH2aIDA7wl6BmVcuMNTGlRg=; b=ZCeEmGx5C1tuByO7Gk8190umAFm3Jq4q/3LEy8V4HB/sgDGk01PdV0MXcQqltklyu3 DW09L0fwCMzuVJZy82A0vSyQNKZSvZwE3Rakfj2hr1zvFY1eZeaEbcBCDOHIx7fy11jt /S2FM9gq9oJe4BBqhtdS5l+3uhXXNdnl7KuLkaG9eftfsUPFv3TGzexWOVF1sWTguVrY 838K9xTGvVrgnK3wGNr49BTbICPTkdgaMh9RIPXj5OJjY/e393NR9LtEmB+cM2VmI3zz RQrk9WLPd1wzBdC0E7STdPo8yjxVpnfYhSiLQXfXjBKsSb4Cc8fPtp7Mrl4DfK8dO1FF g35Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680689959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EBsjiWXEyjNdcnK7CdgNfH2aIDA7wl6BmVcuMNTGlRg=; b=UmyRNXnzdCCa2vrgkknss4VTCQUCx6LmDdnwIHwYLFy2fpolh2KxAJXhSxmJTW65ej sivBCc+vTt+UkruP+yjbCc7XZKWYzGSoUigCzprhA7rd77lwYqOd203/dYvWGGAj3kEk o1mlTu3a2gpGkDtuGU1Q/AU62kkBKdHU1HM0H01tUehOwEEUhyHKhUL16IxoA09tr8wW /YWhe8DzMG03heV+CNx7BE9pTIA9tqLXa+juvAwqpapSV5Luu+bt/x+KEmZxuS0aJgs4 UeU5YSD8fvXk80+HNfaN5ACHrYAzaMkzOpP024W8hSWT6wr59auuVY5qsrDr6EYFzo2E Zr/w== X-Gm-Message-State: AAQBX9dHHg+FpUOeJzkl16FfeJEzhRjg6MbHvzlQ5Lcm5OM9ZGVM763c NTCR2J8qhJt/TeBwQR0DmnaQgEffp8+ee5BrAt4= X-Google-Smtp-Source: AKy350bqyCS4jO7cj3IxU6M9gEfWmwwxn91ShCFu07OvQwRL7AbHTBtXunKmonFyvH6AyOInd3xSpQ== X-Received: by 2002:adf:f004:0:b0:2cf:f01f:ed89 with SMTP id j4-20020adff004000000b002cff01fed89mr4200753wro.24.1680689958696; Wed, 05 Apr 2023 03:19:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Reinoud Zandijk Subject: [PATCH 09/14] accel: Allocate NVMM vCPU using g_try_FOO() Date: Wed, 5 Apr 2023 12:18:06 +0200 Message-Id: <20230405101811.76663-10-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230405101811.76663-1-philmd@linaro.org> References: <20230405101811.76663-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit g_malloc0() can not fail. Use g_try_malloc0() instead. https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index 3c7bdd560f..45fd318d23 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -942,7 +942,7 @@ nvmm_init_vcpu(CPUState *cpu) } } - qcpu = g_malloc0(sizeof(*qcpu)); + qcpu = g_try_malloc0(sizeof(*qcpu)); if (qcpu == NULL) { error_report("NVMM: Failed to allocate VCPU context."); return -ENOMEM; -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:37:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:37:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518451.805027 (Exim 4.92) (envelope-from ) id 1pk0Vl-00050p-8l; Wed, 05 Apr 2023 10:37:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518451.805027; Wed, 05 Apr 2023 10:37:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Vl-00050i-5z; Wed, 05 Apr 2023 10:37:05 +0000 Received: by outflank-mailman (input) for mailman id 518451; Wed, 05 Apr 2023 10:37:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0Vk-00050a-6o for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 10:37:04 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7d00::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ccbf2377-d39d-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 12:37:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8395.eurprd04.prod.outlook.com (2603:10a6:10:247::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 10:37:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 10:36:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccbf2377-d39d-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FGXqNsWaiCWBsLGXCHtB9NVu7xQfSwFyFtWPTySNrymtykz1/+WdsRug7SxjuBRlF3TsT9TDBEEEPkwL//RBILfvDt3E2lPF7anKERPEYrIHn5HZdKPJVk6sHRqx2/AqQY+m6wopXEpRrPPeykSQz6b1jQgwLfVVc9VhGJTwGvMiBLvi6IkkxR/gxFSuLUhMFori1qBC62z/nZIRdrLyarZR8e9NJn6Y+Id/kJcnY6ylFn9/4kvfSAfrKhwp52RpYmaBHd/qg4fP74qNhNxnjdAMWWynpuHUU+e/PY+zh4C7+QzZys+x3CvLo9w3NY/wtq5O8xs+cQaTkgSv3JlBjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuyqy/r8c07AnJqD3GHmViiudIVOTpE8t2D0DhGIOh4=; b=iPRtFEsJ/uwPPijUhRg9/SdbqBfJwLjReIhYm1w9gZBjH7qUOmY2RC+evVR8bKpyBTPXqFzkA2l+/KvsoOdfTgJkcNN4dr2jwUVC2EDITK0UHkZCvHHjGne0bVJyCt7sxORTL/ltslG1P8OYzEMPrd7+6+ITZ+bFvEbfjFGEe1GxdAEWHlwA5hdAlmEh8ZlcCOcNuKV8avxtEt2EiR5Canw4vYWVkdJQGWScm8A3zDujIpUZVewk6td5lq7zN1LoenWDqvfn2F75BRHeKo/Xsla2NpKlvnHusJ3UkpsXiz5IP1gfZDFJWksJb8pCHOvZmM38xESyCfFLPMovJDhf7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuyqy/r8c07AnJqD3GHmViiudIVOTpE8t2D0DhGIOh4=; b=qLrD/PpETL/SfonJsHIntiQuT4NtENzH+AslF9NUw1txvptkdHuFPVlcKF8Vfz8JX0Iy7fLHfHFk5oHrZ4XFsfGJOuMXPauklZF3FbtFdLtIjdYBG/nZpGbhRjnEI9ZHAgKPBvwC5vKN5ZE1qElARPSK2zALg/4E3+4mBFecDVbqCOuK3P5fhUGZ9Y7acMli9AhC+Z9pmhpvFjELJIaIFuVGYzjCM5GCQulv+0G22qDFIyUpPBPLfXRUzYQnTtmVzfvJIGDWUezZpS19TZeYsHnAPEZLsxpWGsTeFq9jniRnMvE+NFo37R2pvubp5mGAz7r7feKZg2CVduwTgJacmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 5 Apr 2023 12:36:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 3/3] multiboot2: do not set StdOut mode unconditionally Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20230331095946.45024-1-roger.pau@citrix.com> <20230331095946.45024-4-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20230331095946.45024-4-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8395:EE_ X-MS-Office365-Filtering-Correlation-Id: 49e671e3-8bc6-48d8-689f-08db35c1ae55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y4qAoOVY9WyhXGl1mNe/YN26Xi9fe5zmsejsCFHRnDvDHdOtHAuYLkSkS8sxCQiPUZTbGfr2fV1T69pZ/6uRHXRyEXFRYFuJT9N0Ii2dbxJl6qFsFX5s73IVvqZiO72qZ6stLRQCMWWjcsFGsQhAN2rhC9aaq2IBCJauGKW1r4Xf6OPuDSDnQ61+R4FZYA4cfeYdVQ36ukaVhvt09o5821L9DSlWalLSKbAQfhVvTKWQSxYCDN6s86zsMSm8BtvWteEfW+hLzGIBo6KLEH9sDQIbUXbeEo25Do7v2r37g1QGtLGPtIA6cofNvDZa3imZM3xg7WbaBH6zjL7eU2fFA/The4C95+Cr6xAiJmsLMM89VGcMYSi1Vzi4H1WT9oE3ZjJXDVpNrpcGdsCtAW+mS6B0W22Na4YxOk3nlQWW6Jbh4eZ2hovFbBV4PXL7HvZfosiYuzhRVyqPK7FuuNkrLi7Pq3LACd+/aoQHqPgslHdUtJOMEutZZ1qjXPnHjSzfGEgKsQvadowehFd+0bKuaBRhH3LCbXZFn0ZLyKiD5bchj7VLo7RHOH+REESgfjwPxlA0/5Pk/9Cq0tKk2yZedq6i/obqHsRHD7BTNODiA/g5DtvjR4oxyhf2OqNtM5oO1IRP4SwhVRitHLXSvSCs+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199021)(31686004)(6486002)(54906003)(41300700001)(66556008)(66476007)(66946007)(6916009)(8676002)(36756003)(478600001)(316002)(86362001)(4326008)(31696002)(53546011)(6506007)(38100700002)(186003)(6512007)(2616005)(2906002)(5660300002)(26005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejZNY2NkRjdUdEtPdDlndmk2MFZxeFFmOHMyWGdtemd5TElsaUNIUWFFSXE1?= =?utf-8?B?NitQVlRwRFVRYWJPV1BLV0N2bFljMmZPT2dVanA4cEQ4RGRFeno5NExxem1G?= =?utf-8?B?aEFDbVJQQ25rdUl0OGRLMVc0ZnN1Q2JLSVIwaWRONWo4bU5ScTZqUm8wMkwz?= =?utf-8?B?SEpFSGNHNTkreVpxUUlIVlhESXNCa0VxTUN6QkdQVVRIbUJueko0RkRyL0Fa?= =?utf-8?B?RG1QSVkyTWJLODJydHc4dDVFU0l6NVVQUSsrcS9HU2hvZUtkUnh5T2xmUmY5?= =?utf-8?B?N0VkejBZdEgvN2xJbW9wb1hDWm1hbVRTVzlqYWV6RnZhNGM3MVNvTk9sdHZ3?= =?utf-8?B?NWVsWDdtYi9mVFNkRlMwMHEvRTVhb0VUd2JtcmZRRzk2Y0tFTHljajFDbXlr?= =?utf-8?B?ZTBRL3lGdDVnZ0NveUp4d3NqNThIdVhYbTNRNzhoK1ltUW1udTNPWm0vcGk5?= =?utf-8?B?d1BVY2p4WnpJSWx3dmJvYjYxS1ZOWlV1aXdhUE0wNTNvaEIrQzlTNHo5NEpw?= =?utf-8?B?aXlEUTJia0VFbE5hemdEamdCK2ZwS21ycVA2YzZSaEMxUlBtQU5seWt4WXlZ?= =?utf-8?B?QWZzTHMwVHJrd2tnK2FZbCtYS1RiRXgrVElmTlY2OFZqbzBKazh3dzBrVDEv?= =?utf-8?B?ZjVzOGJOMFloTmFMZ1ZpbDVqdjRoRzhGay9Ya2RadWdSejUyZi92cjBSMTNS?= =?utf-8?B?ZHZaZWkwUGpaVlZjSnFJeGpJNnJ6enkvdW9vR1BJQmhxZVh5bGo2QmdKUTF5?= =?utf-8?B?LzFBM29yR1JTUWpHckFKR2gwaW11clpaVmZSV3F0cHFBTmczUHkycUZIMW8y?= =?utf-8?B?MHVxK0JLdGJrQUdRVDR0QjVmZzc3Q0QwNjBuZlFTV1RpN0IvSUpuYTU5V0pt?= =?utf-8?B?RDNKV0IxY2Z6Q0tLejY3SUhUYnFzcElJOHFjVGZtMGZ0dFRHdUlNMFhNVnl6?= =?utf-8?B?WSs5UFM3U2J6TDJTZDlYTFByZWRySVUxMGxPT0U4dFdreDJVM0R2aExZdXNt?= =?utf-8?B?dWZST2srOWEzdlR4UGtSZUNjWERkS0pSbXNhRHJVaDMwbEl2cTI0ZnU5SXQw?= =?utf-8?B?Z1hjajBaMTRTV1ZWRmJhQ1RCZDV3YXNoMmFsZ2RGck9NUXlScHhHek1aa3VM?= =?utf-8?B?SEtObGN4MUhyVHB6QXRrQSswdEdGWUJaMnFBUlp4b1dKa1BpTnJrVko4ZWhh?= =?utf-8?B?VTk3QXk4aytLTHpuMXIxY1Y2VVJkM2xPVC9aeE1VN2dEcnpUR0lSNjZ4akZo?= =?utf-8?B?VERMdmRhTi9SVG1TMFFOQTl2MnBKR05kWWo3OEdSc05sczdKZnlwNUl1bXhT?= =?utf-8?B?dUFwZHhIb1B1Y2htV01hcGhtbFdZbEtBZStCZk93TDNlRzdBVFhXZkx5dkE4?= =?utf-8?B?TEVsZDBxd2ZhaEIrNVR3YWlNdTNWRVpyeHczc0tsOUFGdm1GZytsTHlvVVZD?= =?utf-8?B?ajdpaDgwSGZtZXg4aGtIZlg0SHc3V3dDa3U5UEFLcnZuYS9FMlQzQ3FkV1NT?= =?utf-8?B?R241OXZpZk4wMFZ5dXV5aTRScTh2MnpOaWZuY3RFd0dJc2hNemdmR0V5aHBM?= =?utf-8?B?UUlIdUlWcFFVQ0xoSklPN3Nub1VPVTJQYnBjVE1ZUDB1dGxDbW01b3l0ZmVR?= =?utf-8?B?N3JRUElVRy8vbTJKZjVkMjQ2T2liZlhZVTZKbEJYck9RRE0wbmVmZ0IrSGR1?= =?utf-8?B?N0xhWGQ2ZCtkSmdvbWxRemlYaGNGdUZGVVkrZXh3UUFpODVSZ0hhWlc2T0tu?= =?utf-8?B?RmtsTUtKeGJnRVlKeGlxTjduTys5NS9WWDVLcnJ3QWlLRlRTcExVejNOaExF?= =?utf-8?B?ZlQ2S0dQOG5aTXpmVThYUkx5Snk1cFpuTmYyUkpBSlBXdERZd05mUDJsMDN4?= =?utf-8?B?cnh4TVhBcVhhTzZwcUhUU05JUi9QSzlzTzZlZU85elNKNUZiV1FRSDhEbVpS?= =?utf-8?B?ZWdpdnBYS0RIamo3SThJQlJZYm1HUUswbzZsSE9HQjBKbks4UTZleG9lOXpW?= =?utf-8?B?Y3JvRDZaM28rNktiT0xLTXhvMUZzOUR2bGtTUTdZTVV5QW5aL3dEaTFSS2Zs?= =?utf-8?B?SStrMU9lQ05rMVZzV29iazJjOEk1NzZpNEtndW9XeVVtZUh4V1JVbUd5Yk16?= =?utf-8?Q?/gj0gRiKLF7swI0MiYUduigvI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49e671e3-8bc6-48d8-689f-08db35c1ae55 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 10:36:57.4231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fala2Nt6iCUE+kr5I+Y2PhXZQ7K4/lpN9bYc0HCvlji2b3XGVO48EzpdFU4ehG9M0g/5GO18aPex2EQ6OCzZKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8395 On 31.03.2023 11:59, Roger Pau Monne wrote: > @@ -887,6 +881,15 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable > > efi_arch_edid(gop_handle); > } > + else > + { > + /* If no GOP, init ConOut (StdOut) to the max supported size. */ > + efi_console_set_mode(); > + > + if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode, > + &cols, &rows) == EFI_SUCCESS ) > + efi_arch_console_init(cols, rows); > + } Instead of making this an "else", wouldn't you better check that a valid gop_mode was found? efi_find_gop_mode() can return ~0 after all. Furthermore, what if the active mode doesn't support text output? (I consider the spec unclear in regard to whether this is possible, but maybe I simply didn't find the right place stating it.) Finally I think efi_arch_console_init() wants calling nevertheless. So altogether maybe if ( gop_mode == ~0 || StdOut->QueryMode(StdOut, StdOut->Mode->Mode, &cols, &rows) != EFI_SUCCESS ) /* If no usable GOP mode, init ConOut (StdOut) to the max supported size. */ efi_console_set_mode(); if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode, &cols, &rows) == EFI_SUCCESS ) efi_arch_console_init(cols, rows); ? Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 10:45:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 10:45:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518462.805038 (Exim 4.92) (envelope-from ) id 1pk0dO-0006kE-5Y; Wed, 05 Apr 2023 10:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518462.805038; Wed, 05 Apr 2023 10:44:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0dO-0006k7-27; Wed, 05 Apr 2023 10:44:58 +0000 Received: by outflank-mailman (input) for mailman id 518462; Wed, 05 Apr 2023 10:44:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk0dM-0006jx-HL for xen-devel@lists.xen.org; Wed, 05 Apr 2023 10:44:56 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e55f4197-d39e-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 12:44:53 +0200 (CEST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510--SGXi9h-OWiGow7FELWTWw-1; Wed, 05 Apr 2023 06:44:49 -0400 Received: by mail-ed1-f70.google.com with SMTP id n6-20020a5099c6000000b00502c2f26133so4460794edb.12 for ; Wed, 05 Apr 2023 03:44:48 -0700 (PDT) Received: from redhat.com ([2.52.139.22]) by smtp.gmail.com with ESMTPSA id p25-20020a170906a01900b0093a7952411asm7207199ejy.48.2023.04.05.03.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:44:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e55f4197-d39e-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680691492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kq6oZ7N2bYTf0eEXEKbV1aFmSrlbXHt85D5v+zP8YuE=; b=PqPwEh74rny6Rf2DAPJlaQtViJqcvRRT5MlAv6EYUs/M+2iARPJsWMnUGEThKN3DAhKUfJ R23xvhARXG6i94e5BILUVlFyxwnsHYlotpQBqhjb3+fSRS3IyXC/TvpnFbJadtn49rWkWx 9MJjd8qtxWtvLFydBiA4OLy4R4eQh7M= X-MC-Unique: -SGXi9h-OWiGow7FELWTWw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680691488; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kq6oZ7N2bYTf0eEXEKbV1aFmSrlbXHt85D5v+zP8YuE=; b=EI6O2ucWs6IkbSUkEr55u19Z1IQBb7BtSwHBqwFc6FX4EsnO6FauVB52EvZ/wQiHeN qu9xV/+QFDvavxVMZhUNh9jQatUQZ2ks6eqMzpV1ZPjjMYmUtpXj3y4EPYvoTfUs1NFZ XukgO14XtWwuhWiklziGDI/XcGcG1GiW2nHIPAUTY31TWr7U6K5rPkPtRicgoat7QUmv ZcbJ2ZgRuTlvkGOCdacz4FQYGADpkjXJrMMfkODpWdzmwh7ypTtB4dwI8cBaXvI3Vjj/ jIKZgBR3q9/fOVnXyt/dYGBHfNx10Iwu1NILM9C/JLENJLOYOGo4eOYIo7TuQEf192Cq cQSg== X-Gm-Message-State: AAQBX9cTMNSx6HQji+T1/+ebewmL/DoBcAOAR2Wrawo9Lu1lxEXbjx4o umOMkrfxBJ9wh/vNbQCfT9Y1BwI50+SvrHBwNGwHooKZC3NRVmHdbJpRDs3fTOuTBBJZ/1zIiTa RP83Ea7Txxy/irLqK5g== X-Received: by 2002:a17:906:d045:b0:931:624b:6804 with SMTP id bo5-20020a170906d04500b00931624b6804mr2345359ejb.33.1680691487916; Wed, 05 Apr 2023 03:44:47 -0700 (PDT) X-Google-Smtp-Source: AKy350b5k+F7FQS0kEh/ahvkTDuRpd40DUgmdol+8mUYtq06ub6whVh6ZTdy0b/m/9U1TYG1Nw5Bew== X-Received: by 2002:a17:906:d045:b0:931:624b:6804 with SMTP id bo5-20020a170906d04500b00931624b6804mr2345345ejb.33.1680691487657; Wed, 05 Apr 2023 03:44:47 -0700 (PDT) Date: Wed, 5 Apr 2023 06:44:42 -0400 From: "Michael S. Tsirkin" To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: Viresh Kumar , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, Stefan Hajnoczi , Vincent Guittot , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks Message-ID: <20230405064417-mutt-send-email-mst@kernel.org> References: <20230405080512.nvxiw4lv7hyuzqej@vireshk-i7> <87h6tulkae.fsf@linaro.org> <20230405060340-mutt-send-email-mst@kernel.org> <87cz4ilj4j.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <87cz4ilj4j.fsf@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Apr 05, 2023 at 11:24:43AM +0100, Alex Benne wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Benne wrote: > >> > >> Viresh Kumar writes: > >> > >> > On 09-03-23, 14:20, Viresh Kumar wrote: > >> >> Hello, > >> >> > >> >> This patchset tries to update the vhost-user protocol to make it support special > >> >> memory mapping required in case of Xen hypervisor. > >> >> > >> >> The first patch is mostly cleanup and second one introduces a new xen specific > >> >> feature. > >> > > >> > Can we apply this now ? I have developed code for rust-vmm crates > >> > based on this and we need to get this merged/finalized first before > >> > merging those changes. > >> > >> > >> I've queued into my virtio/vhost-user-device series so I'll get merged > >> with that series unless mst wants to take it now. > > > > Well the patches are tagged and I was going to take these after the release. > > Probably easier not to work on this in two trees. > > Still if there's something in your tree being blocked > > by these patches then > > Acked-by: Michael S. Tsirkin > > Let me know. > > The virtio/vhost-user-device tree work is orthogonal to this vhost-user > enhancement although all the work is related to our latest VirtIO > project inside Linaro, Orko: > https://linaro.atlassian.net/wiki/spaces/ORKO/overview > > So if you are happy please take these patches now for when the tree > re-opens. Yes, I tagged them for when the tree reopens. > > > > > >> > > >> > Thanks. > >> > >> > >> -- > >> Alex Benne > >> Virtualisation Tech Lead @ Linaro > > > -- > Alex Benne > Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 05 11:18:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 11:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518468.805068 (Exim 4.92) (envelope-from ) id 1pk19p-0003Q1-5M; Wed, 05 Apr 2023 11:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518468.805068; Wed, 05 Apr 2023 11:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19p-0003Pu-0t; Wed, 05 Apr 2023 11:18:29 +0000 Received: by outflank-mailman (input) for mailman id 518468; Wed, 05 Apr 2023 11:18:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19m-0003OA-OQ for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 11:18:26 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060b.outbound.protection.outlook.com [2a01:111:f400:fe59::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 91da60b8-d3a3-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 13:18:21 +0200 (CEST) Received: from DM6PR06CA0007.namprd06.prod.outlook.com (2603:10b6:5:120::20) by PH0PR12MB7094.namprd12.prod.outlook.com (2603:10b6:510:21d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 11:18:17 +0000 Received: from DM6NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::87) by DM6PR06CA0007.outlook.office365.com (2603:10b6:5:120::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22 via Frontend Transport; Wed, 5 Apr 2023 11:18:17 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT049.mail.protection.outlook.com (10.13.172.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6277.28 via Frontend Transport; Wed, 5 Apr 2023 11:18:17 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 5 Apr 2023 06:18:16 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 5 Apr 2023 06:18:14 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91da60b8-d3a3-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7m5NbTPhzb7l3VwIWfMjPF0agHjhvDRI5bjtLX/cGY/YqGVspD8l/HgOc7rheU0HnfO3CrjzYkiYOrHqpAQODmbHfbaWHiG9ILddNkqjOWCR7X9L8/tQsHHdc9nwrISy7ZSkfOKEvAUebAzFOxukXXZFcsmIKPbitVnCglvdEwpl6mwDE0hQiw15v03PL/DMQq50GQVOZbYgen/UHHtnj2MiY90RKeUsyTf7RW4rGx6N7LbihxnNLRlPFf0UCuRsR0MJjhMu6wmP0A9CPPzqmjZkucJPAZyAbJLgKfHeZcaF4GO6eHT/wFyNZSchFqPhBhmA/qOR5fxHdjbW0heZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g9H/C1PpC36IRqyjibUsIvzP3hGQMaqzwi6jG5cD2/k=; b=LcOD00f4Pwrf/Q9l5/hye4fjRCUSuUfode4Ka8gjlQEMhJsc/4E8M7QcfH7NYuaFLU30b76yQO70tCAjWDUpxjwIzJrI6HKwePMJcMNG8fWhKjftN+/D2kslmBZDPdM+04V+x1CbaK9GUXx8jUOieIJ8/omNZiS2hnQFoIOyABZr53mHKKECVJ5+plWGK97XNNxFZTdV9g7YjV2xnQO78PNe3RKCNehmhjpcoMaW4Dq+zqfsZ167hFYjl5k6DHLJBQBfsCCPAMyzKBai84Ehhsh8YZ8ikuQGhgn4ptdSxmUjml/eBxWwzcgRDEjIQM/sHreLtad//HvjsJJeURTkJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g9H/C1PpC36IRqyjibUsIvzP3hGQMaqzwi6jG5cD2/k=; b=S8u0uFlo56x4SJF28DGuVASrEGaufHrfkZD42Js/oteIoLFAIadIi4lxOxGCdROXvRJ8x+nl4k8FHV4FbfAp8pAAavf43f1O+PXGMO80GMs9E4avFLObGREL5g14kukD116YjGP1yCSYLRRS4LnwkYEbx/hLPsVp/GKjWxOzfZU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments Date: Wed, 5 Apr 2023 13:17:48 +0200 Message-ID: <20230405111750.12491-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230405111750.12491-1-michal.orzel@amd.com> References: <20230405111750.12491-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT049:EE_|PH0PR12MB7094:EE_ X-MS-Office365-Filtering-Correlation-Id: 042fd97e-6201-403b-d9f8-08db35c7748c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0RALEhyx4hTMbmn4HT+qB3sV+Icf8kyI862pPtJsaCk9JidOAgy4PZV3O8LitYNCN9bFdqVZLx4p3ZP+er+6w8xs7MgX+EMhh8iuQxCWxNT1e85I274W0QwUurjN4ulrH8Y218TPtRV0QegQBQ2+eqJ9vaIRZW3zqJWkMaR2E5X4GkKtG4P/JnGajP8Z1cFXQmOBaMqenVPJRd1y1y1+nUDiq2oW91TbCuE7Xq4i1IjFOkJ61mCZ4WnzbYuuixxi01NqfQDPo7gvbQx1RP/mFkoQRrUZyYVPbSImOqDj5eh9v9l0VSoFc6ByXpRaXvuskf5rGhr+f7LYsE+NsKZTinzNURUvSAb86OfijPa5UaZ+BqTL3LrePiJrAG3HvVsRD95VJgQe90+SIDfVk2r+kXt8YIibBiRk0cLX/dMxV6GO4Fq5bATRsFcFxCKlUNbSwM+C5i4dy6khOjGutBvk9FjIe2p7NO8y/cfGyRoF4UnmS+GQWKIdHbI1aJu1NDJfey0rx2necX9nX6o3/jr3zs5evXyueaV1+MYSRhfm1aYx02NwyDQU6wn1d8bThlVtSs9q9HrViDboFcxFzOLLwd3xmXb7bo2sDAkOFZv7duSem4PComl7rXuji47LGPcwCMvjsXbUGkFkezrOy0YXgD8SwxFc2dkMd2c2Bz4WMU+fuSB2oCLx8eTErmxPQvxXe5pGsMtTcfQfCVZyNQ4SjHUSXcSw40fYaejnS7YVpko= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(40470700004)(46966006)(36840700001)(86362001)(2906002)(36756003)(82310400005)(40480700001)(6666004)(2616005)(47076005)(186003)(83380400001)(426003)(336012)(1076003)(26005)(8676002)(4326008)(478600001)(70206006)(36860700001)(41300700001)(40460700003)(70586007)(5660300002)(6916009)(82740400003)(316002)(81166007)(356005)(8936002)(44832011)(54906003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 11:18:17.2427 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 042fd97e-6201-403b-d9f8-08db35c7748c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7094 In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment stating that the guest is expected to read the DR register only if the TXFE bit of FR register is not set. This is obviously logically wrong and it should be RXFE (i.e. RX FIFO empty bit set -> nothing to read). Signed-off-by: Michal Orzel --- xen/arch/arm/vpl011.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 2fa80bc15ac4..0186d8a31834 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -143,8 +143,8 @@ static uint8_t vpl011_read_data_xen(struct domain *d) /* * It is expected that there will be data in the ring buffer when this * function is called since the guest is expected to read the data register - * only if the TXFE flag is not set. - * If the guest still does read when TXFE bit is set then 0 will be returned. + * only if the RXFE flag is not set. + * If the guest still does read when RXFE bit is set then 0 will be returned. */ if ( xencons_queued(in_prod, in_cons, sizeof(intf->in)) > 0 ) { @@ -202,8 +202,8 @@ static uint8_t vpl011_read_data(struct domain *d) /* * It is expected that there will be data in the ring buffer when this * function is called since the guest is expected to read the data register - * only if the TXFE flag is not set. - * If the guest still does read when TXFE bit is set then 0 will be returned. + * only if the RXFE flag is not set. + * If the guest still does read when RXFE bit is set then 0 will be returned. */ if ( xencons_queued(in_prod, in_cons, sizeof(intf->in)) > 0 ) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 11:18:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 11:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518467.805053 (Exim 4.92) (envelope-from ) id 1pk19j-0002xS-US; Wed, 05 Apr 2023 11:18:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518467.805053; Wed, 05 Apr 2023 11:18:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19j-0002x0-Q9; Wed, 05 Apr 2023 11:18:23 +0000 Received: by outflank-mailman (input) for mailman id 518467; Wed, 05 Apr 2023 11:18:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19i-0002uD-JG for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 11:18:22 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20627.outbound.protection.outlook.com [2a01:111:f400:7eaa::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92183f78-d3a3-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 13:18:21 +0200 (CEST) Received: from DM6PR06CA0034.namprd06.prod.outlook.com (2603:10b6:5:120::47) by DM4PR12MB7669.namprd12.prod.outlook.com (2603:10b6:8:106::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Wed, 5 Apr 2023 11:18:18 +0000 Received: from DM6NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::5d) by DM6PR06CA0034.outlook.office365.com (2603:10b6:5:120::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.44 via Frontend Transport; Wed, 5 Apr 2023 11:18:18 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT049.mail.protection.outlook.com (10.13.172.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6277.28 via Frontend Transport; Wed, 5 Apr 2023 11:18:18 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 5 Apr 2023 06:18:17 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 5 Apr 2023 06:18:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92183f78-d3a3-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kaV+HV0ycyoxTc4dkHTLNG3K/5Lf8Nrp6RWQmY7xY/RCfHl5wjPN6xLzuACwqAB8LXSj4+l4lQu+ZdOJJYzgJBYwTIIqBWlAiTO5set3uLlIWptzeYAYbTcNr9ET4OSqAR/NTYXftoAqHkOxCUfr497FQLyTir1c3cNidabbBUg1MgoQklCzmc9bEVCTl0izAjlUBALj1p6Ri8Q41wegJoVSjVrcF68eIfuQFavsZUx9cMSVrwHLPvtkAhzf0y/2hYX5pA2Io3pskB+in6gnGQQFsrM4ux17AFxeqmr+bX7dItVsciPcSCjzJmvL5AL5zQHeh/yauswQAikgVCAiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=faFuTvjumdAB2CRmAM9G85/4bLPNgqkuwbkGeX5rngE=; b=kjcKQVGukCECjqOvmwnNyPf0gBTADZsQJvmNCJaJdAlX8+ngV4qh8nmRmOiZ+RrnbRVTaAZn99vRWxz32iEejmTqhncYyTuOVMjFxOobagQ6GYp4LAxlAIuiBWrPLsEVUz3rLkhDQL1dkvxLNAc7jg9jJCfEKGKd2U0QZJaQDR4LhhIlFOmtlSb/SsssxgGPaFGHSDywdTiiSSXpGEXJpzAyiElsoXVg5p0rvQTlfHljVnIgZI1DFINedb4OuUeH73wSC+5GPumTRTOaqK5rze63t0/LDz3leVeapXIgCWZi3cTurBab/D4huHCQa9FsT33fbwhyC7dR7KD96VHH2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=faFuTvjumdAB2CRmAM9G85/4bLPNgqkuwbkGeX5rngE=; b=RGWTlBzc/JICUHm5hSlDVNLdIDkoqasILDgwRVjJy8Wy5VyTTNIMvLeCRi90OU3dKuueFx5BfRhTFQMoytkKVLLpx8TeRepO1Ht2sFp9EREclTMnzchUyjPPaVnwJOg6GHyhDqYIsuXawjCJvA645nPaTIT6Qp2aa0cFrGZq+8E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/3] xen/arm: vpl011: Handle correctly TXFE when backend in Xen Date: Wed, 5 Apr 2023 13:17:49 +0200 Message-ID: <20230405111750.12491-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230405111750.12491-1-michal.orzel@amd.com> References: <20230405111750.12491-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT049:EE_|DM4PR12MB7669:EE_ X-MS-Office365-Filtering-Correlation-Id: 00ee4a16-6e8e-45a1-6a0d-08db35c77563 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 673hHt9abvZww3bon2Kv6waImqCn0qsquHbGnmusaOu7iVAKUuPp5cX6+6AoDjbO58/zapfGBe7PKWVcNp1zpMIG8Gjy9Tvdcor/6L/iAf8vgPbI2mOQ2ME8tODBjmNyP51Dho96jUFa3eBTG338ii166a4b+m3/eutD+i6Se6O2tdEscxiXIbn7MnDDPfyV0JsVbwHNfeoaZAvhBZUGnGuDl5qbgmi1ZBKaU6AViSlG6J9t6V888PSVNr8dXYWOG6q7d4qmCkO8IzesWXsbXMJBWST/eaPiJ99LLnsYwMtDr+4X177Q5svIQqIC9mCpLT3FEY7VGJD/BkfkdbMn7F33bFWxPa0uysUp9RSO+/AzOeh5+584GxNZPbVn4vixHuSpPk4mZH5hBF53dhWiW0x1iGw4Oa1+RaegIrA/aQKzte7qrCDx6Gc9pmEAYpzaoc3/ZizLqiOgOl/MZcsKaKK7R7PKPfgTlE8Y8nhi/5kghqkRlPIaPWt0lQlhjVC5n8hiBF3DdIpRe8valZsvV3xE8JlBkbHKst7SJePziBKVNs/eXI8uUgYg7ASq3ttqb5fHOSMfsVWjfV4RcDxFEJjIbRyRD/dDY0OVWgpVVb5WDvfqIkdJ25ruz/HLURA0CFnkHHgM3a706skgYR19XL3we5x/Lhfc8P6E0LvgOiSz4MWwdzSnhq85LI+eOuo9ealmotnfaUpcEPp5qmgvpYa1222kEq3j0Wve0Y4v/tM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199021)(40470700004)(36840700001)(46966006)(86362001)(426003)(70206006)(70586007)(41300700001)(4326008)(6666004)(316002)(6916009)(54906003)(8676002)(40480700001)(82310400005)(186003)(44832011)(8936002)(36860700001)(5660300002)(2906002)(356005)(82740400003)(81166007)(478600001)(83380400001)(47076005)(336012)(1076003)(2616005)(26005)(36756003)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 11:18:18.6489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00ee4a16-6e8e-45a1-6a0d-08db35c77563 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7669 When backend is in Xen, the handling of data written to DR register is a bit special because we want to tell guest that we are always ready for new data to be written (i.e. no real FIFO, TXFF/BUSY never set and TXI always set). This conflicts with the current handling of TXFE bit, which we always clear and never set on a write path (we happen to set it when we receive char from serial input due to use of vpl011_data_avail() but this might never be called). This can lead to issues if a guest driver makes use of TXFE bit to check for TX transmission completion (such guest could then wait endlessly). Fix it by keeping TXFE always set to match the current emulation logic. Signed-off-by: Michal Orzel --- We don't have to look far for an example of a PL011/SBSA driver relying on TXFE. If a guest had a driver like we have in Xen, we would end up with no messages being printed. --- xen/arch/arm/vpl011.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 0186d8a31834..ff06deeb645c 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -112,8 +112,14 @@ static void vpl011_write_data_xen(struct domain *d, uint8_t data) } } + /* + * When backend is in Xen, we tell guest we are always ready for new data + * to be written. This is fulfilled by having: + * - TXI/TXFE -> always set, + * - TXFF/BUSY -> never set. + */ vpl011->uartris |= TXI; - vpl011->uartfr &= ~TXFE; + vpl011->uartfr |= TXFE; vpl011_update_interrupt_status(d); VPL011_UNLOCK(d, flags); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 11:18:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 11:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518469.805072 (Exim 4.92) (envelope-from ) id 1pk19p-0003Tf-Fq; Wed, 05 Apr 2023 11:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518469.805072; Wed, 05 Apr 2023 11:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19p-0003TA-AT; Wed, 05 Apr 2023 11:18:29 +0000 Received: by outflank-mailman (input) for mailman id 518469; Wed, 05 Apr 2023 11:18:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19n-0003OA-2Z for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 11:18:27 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20626.outbound.protection.outlook.com [2a01:111:f400:7e88::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93a97213-d3a3-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 13:18:24 +0200 (CEST) Received: from DS7P222CA0022.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::25) by IA1PR12MB7734.namprd12.prod.outlook.com (2603:10b6:208:422::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 11:18:20 +0000 Received: from DM6NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::2f) by DS7P222CA0022.outlook.office365.com (2603:10b6:8:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.37 via Frontend Transport; Wed, 5 Apr 2023 11:18:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT061.mail.protection.outlook.com (10.13.173.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6277.28 via Frontend Transport; Wed, 5 Apr 2023 11:18:20 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 5 Apr 2023 06:18:19 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 5 Apr 2023 06:18:18 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93a97213-d3a3-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHh3tRuCS0Lg5C3Tq6P6x0xOB0FnbYQVfh4OfOuKxKw3t3a+PTDKaebTimcA2ee2m4MqTeUVlbqQbg5cnhOjC0Bmu5VAzxucmSa841KW+S1wfRDXjvDVtYxUCcjPCcZRTh5SG7jhVI5RUuMjerVOJGqvUVn782ESYZKZ7wuaKmbCSFwjZ4mHfnD4e+hBHgHAVhNIyGAuHO6CmIQwk4cznwLUBNcBDN5cmEQFO+ie73yjrwkFezyx3K4kLkQ2qa5ZB0RYr/uMmhCV/toVY8p95UiyG2DxqSXGcF4dXZ7a1Qjl9x09/2LqJb58YaBrUzWsUuzwRy1cvjW/HbuYE6DMcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u4oUaq7lN8GdxSqirWE6VLLbTs/fytDNa65dm3uA6/s=; b=mug+DyJJAZSjAG0UIkT8KjUfmhoWC6M965ZyxpF/CHnPOoTSHVuuNcQCzTqrMzXiu31/qbUpqnngH5eSEw4UsPwGJo30bnnytVsoHZ3UlUhkMLuoJ4dMjEEM+4pUUlafB8t8PM1djhU970gHPSMdgsSwdVFk/S7C3jdk9Il3GqlpuXN2sZhwOho/Z5U/G67nmMEG3uPe56R1rE4UIh1leuwauPjcWioHmhFetyGT068OIaXOv78YP5m9FbjB87yQQty/QQrka+VPBT+I0Gmyj2Y/aBuALCcIUojIicGcdGeVge7HBTAq8j5vzy0FYWv1pb2W757Dk6Erh3H4CGE1TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u4oUaq7lN8GdxSqirWE6VLLbTs/fytDNa65dm3uA6/s=; b=GGPjY6Sk8EY31upxf3pvXMKjvhmR5OWXEIsSh3IwDq9BwOXDEDLGF86X7BQh3y5CIUBjLlrlqt+TsC1EdMBtXvHkKfq7lHp8yBy2RtKO00CPZAqsiBlIrC+DqWV52YftIpby/bregZ9ExP9/gTPyBto3Tx+XuCFXJvEkMMdEaAc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen Date: Wed, 5 Apr 2023 13:17:50 +0200 Message-ID: <20230405111750.12491-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230405111750.12491-1-michal.orzel@amd.com> References: <20230405111750.12491-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT061:EE_|IA1PR12MB7734:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ddf0363-7b25-4ed1-c010-08db35c7765a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7B7zit89wb63fCYp2LFg+8QgEUB4Nx2tYbry3sdtjGK7YV8f0oZfGcKsRh+tuQduXsx3bx4JdJwl+Zy0BgdWsA5sbFH4M3lkEMh24Z1TZ+SoV289UbyghlO5gzxn352weDtNTvaXaAZlN8kH0G/eulweLK4uNuMNNlwDqnkQhkdX5OIwo41rbbSn8Ljt1EsHJmf5RyKH47BzQ3GUrfnyjNmDsF3gf5q4seflzwxPyOi6dQRwGeoPPfW6MCpxMEQkv4/t0CxsQCM6Tj9ECkSvnx3La2Co0+AdGzYNtY10K/dAumfXeLz6qmmhEWAKNVmXLYyEK0UPp5hhUPWC8JY+4N2n+EXJ9X+HMebRy8TYAMFcnUpXE+P5WNYcugAQ+XUSrmzIfcvXwn5QYVu/DWWtq7g+Cm8RyARoARUvIZCAyMsVzdsF9FKnUb0vISBENWhFEzmehgKiyaqBwJokrjMln82CyhQu2HwikmXO9z22bOgNehpMOllzEdXkBn2eMwpkjTkxM9vlxwLD402KFk/sQIwnwHjp6DoRXaA+76W9hYNFqXFZf9SSSNyK28JuTDipwKGVwOFBupeamnwqd75X9I4J+Uyzxolsjhs/kYV+VkkjG0DBtPPRDuH9yS3e8BoXzH8icqDInjU0A0IPHarKY2JMNNVOvvb1AN5jSwkzt8pH1YsvwOCz49RH0Mxvca5NdGy4LIe8satRfLsyf/Y9OUSjr45yQ9izAVICNn6zqyE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199021)(40470700004)(46966006)(36840700001)(2616005)(8936002)(186003)(44832011)(5660300002)(2906002)(26005)(81166007)(82740400003)(1076003)(356005)(36860700001)(54906003)(4326008)(8676002)(6916009)(41300700001)(86362001)(40460700003)(426003)(70586007)(336012)(70206006)(478600001)(316002)(40480700001)(82310400005)(36756003)(47076005)(83380400001)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 11:18:20.2698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ddf0363-7b25-4ed1-c010-08db35c7765a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7734 >From vpl011_rx_char_xen(), we call vpl011_data_avail() that handles both RX and TX state. Because we are passing 0 as out_fifo_level and SBSA_UART_FIFO_SIZE as out_size, we end up calling a function vpl011_update_tx_fifo_status() which performs TXI bit handling depending on the FIFO trigger level. This does not make sense when backend is in Xen, as we maintain a single TX state where data can always be written and as such there is no TX FIFO handling. Furthermore, this function assumes that the backend is in domain by making use of struct xencons_interface unconditionally. Fix it by calling this function only when backend is in domain. Also add an assert for sanity. Signed-off-by: Michal Orzel --- xen/arch/arm/vpl011.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index ff06deeb645c..7856b4b5f5a3 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -261,6 +261,9 @@ static void vpl011_update_tx_fifo_status(struct vpl011 *vpl011, struct xencons_interface *intf = vpl011->backend.dom.ring_buf; unsigned int fifo_threshold = sizeof(intf->out) - SBSA_UART_FIFO_LEVEL; + /* No TX FIFO handling when backend is in Xen */ + ASSERT(vpl011->backend_in_domain); + BUILD_BUG_ON(sizeof(intf->out) < SBSA_UART_FIFO_SIZE); /* @@ -547,7 +550,13 @@ static void vpl011_data_avail(struct domain *d, */ vpl011->uartfr &= ~BUSY; - vpl011_update_tx_fifo_status(vpl011, out_fifo_level); + /* + * When backend is in Xen, we are always ready for new data to be + * written (i.e. no TX FIFO handling), therefore we do not want + * to change the TX FIFO status in such case. + */ + if ( vpl011->backend_in_domain ) + vpl011_update_tx_fifo_status(vpl011, out_fifo_level); } vpl011_update_interrupt_status(d); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 11:18:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 11:18:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518466.805048 (Exim 4.92) (envelope-from ) id 1pk19j-0002uZ-LU; Wed, 05 Apr 2023 11:18:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518466.805048; Wed, 05 Apr 2023 11:18:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19j-0002uS-Im; Wed, 05 Apr 2023 11:18:23 +0000 Received: by outflank-mailman (input) for mailman id 518466; Wed, 05 Apr 2023 11:18:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk19i-0002uD-2G for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 11:18:22 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061f.outbound.protection.outlook.com [2a01:111:f400:fe59::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 90c3ae6a-d3a3-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 13:18:19 +0200 (CEST) Received: from DM6PR13CA0006.namprd13.prod.outlook.com (2603:10b6:5:bc::19) by LV2PR12MB5797.namprd12.prod.outlook.com (2603:10b6:408:17b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Wed, 5 Apr 2023 11:18:16 +0000 Received: from DM6NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:5:bc:cafe::ca) by DM6PR13CA0006.outlook.office365.com (2603:10b6:5:bc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.28 via Frontend Transport; Wed, 5 Apr 2023 11:18:16 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT110.mail.protection.outlook.com (10.13.173.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6277.16 via Frontend Transport; Wed, 5 Apr 2023 11:18:15 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 5 Apr 2023 06:18:14 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 5 Apr 2023 06:18:02 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90c3ae6a-d3a3-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egDyTYTFPoXBuaPuUrAD9TIEGGve+2IIoVmgyF6JUzvYgryJWYPHAMYw20B0KuWW0BtTCS9ACMpeMbWPKy5q28j2N7dEQq0KivkJwRURKPcVa/U671ljgAg6sSaFwAE1mhE70OVIkpWYR+SrMiZ7FN5DZiqf//xounPKlBXfio395jiI+LZxX006EG58Ql1PTuSwkTrd0QAUlfgGkAIdV9WGGRQJ3OhdenRhvqb8i7ujEnS+47xrKcHsMIbFaZEllsD4OG8As4s1f4cHYao7ZiL86nYT4S6J7/ua72vanhWNNI78O0UptfXu8KhBCk8AW2u8BzRa8HjyK72pP8xDMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJXtiKGy9roPQFWOXibFz3rmlQ5I0iIIqdyGcUL9dLg=; b=XKrbqeswns5TthJXJwPqB4Q5KiMpreiKPV12hCDB/K4KweghOGEhuo3QXBrI+DKl1Yher+9Cb2GAEt4VT10Vptox72aFgclSHJiepE8FTZ0f3oeYS1zLcVvKugFRWG2HC65hAORhvJaHKp2Bk2NBENn6eEOebFxj7onjoxw8KVuiIcmao1RbcwRt2EXKe5O5cWqZi4mp11jXeQgCZyDSDqrdJdnfvCsZsdy8uRDiOR5tdCxIXIIX0kZ2nsL1GlQxfNLu4tbcroFA61bSyH9iMr95yiyjAxeO7ZY7L2W00GMwVHn6S/7U8/WmAWVEjZ9cpr6bTsPiEb4OCXNyOjP+uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NJXtiKGy9roPQFWOXibFz3rmlQ5I0iIIqdyGcUL9dLg=; b=xRv0XUvvy2NUHf7BBziOnH3akAQ8WGIbMxKS3dETvK1eGBhCn/iBoxvVf3VLJBAFxg7hYqyDA/HArTxc1UTtmQx9rOBw++4QuQl6jECHRizqNENfgNxDurzsXz+MxztG2WzIEYbGcDXueeSTkM4G/AnRi8zQHGcAHkOtYXzCp70= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/3] xen/arm: vpl011 fixes continuation Date: Wed, 5 Apr 2023 13:17:47 +0200 Message-ID: <20230405111750.12491-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT110:EE_|LV2PR12MB5797:EE_ X-MS-Office365-Filtering-Correlation-Id: 2abba9e8-18d2-44f0-f264-08db35c773cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +cf5rcUvuzkcGJlAeB5SDbeP4/EoGERkmpIX6kGb86VINHd5Tu9VddoOdFcO3a7+jv2Ou/6WzVAh4FKBG26QCQlGR9iu8qHhEKzaqeskYXd1vRHDfXmk2ocG1TwN+Xok9sqLhLZT6I7RPbW7Qd1V6xop3h+p/AZVfr4LzjiLf3AHqdhW0ubgTJlxiJJkH3J4lhoxdtVXbKqZbCu6CXMU+Nqg5tVu70oBXTN+plfiVkRPjpllgZheYq+rS1ghMNqNH9o0b6VgGgJ6rX7dg3w2HDiP+PeBZM+lTqXm4ZNDHcgOTVy/mk1J6//iRAgsdkdgI4wK0hS3jikN4xRtC7BkBAi5XhQBhBeNKh0sM4ixT5ZGaUghdjRQYCa4TiBcrBMRA4Qg8ivdidF7hJIDXkHFkQIFWznn5e/5mijT8HR5jl1IPJKUOJA/pS4zbLqDzvxEle8ZZ0ip3Il7bKXC9asvdNtKW4IlYnB0goQxLN2KmhxeFPK4PxJD7fEmAqUq3VkssGfyZGvRFmpagOpfBIOV+FsLNkEeyWgwAZhxWfyW9T1XYYyguM6D6bE8jtEYR1MnqcxQoax4WegMCz5I37/DIYh7m1ND2Tk3Q+/e+XoNOIfwh3V3aueE3CVdou3vKVd4yW3Bia8SblDLZowKP6hXqhqLdxOSdKakA7ZndZawRy6ZJ44Tvj+ZAhb1LSOJ00Roi7ns0/S3P0ZSl5zYdeDyZ5KEnjtIx5g+S2UqRjqXYdw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199021)(40470700004)(46966006)(36840700001)(2616005)(86362001)(82310400005)(2906002)(36756003)(40480700001)(47076005)(336012)(426003)(83380400001)(186003)(26005)(6666004)(1076003)(4326008)(36860700001)(478600001)(70586007)(8676002)(6916009)(40460700003)(54906003)(70206006)(81166007)(82740400003)(5660300002)(44832011)(41300700001)(356005)(316002)(4744005)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 11:18:15.8848 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2abba9e8-18d2-44f0-f264-08db35c773cb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5797 Another portion of vpl011 fixes/hardening. Michal Orzel (3): xen/arm: vpl011: Fix misleading comments xen/arm: vpl011: Handle correctly TXFE when backend in Xen xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen xen/arch/arm/vpl011.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 11:24:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 11:24:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518483.805087 (Exim 4.92) (envelope-from ) id 1pk1FL-0006JW-64; Wed, 05 Apr 2023 11:24:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518483.805087; Wed, 05 Apr 2023 11:24:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk1FL-0006JP-3P; Wed, 05 Apr 2023 11:24:11 +0000 Received: by outflank-mailman (input) for mailman id 518483; Wed, 05 Apr 2023 11:24:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk1FJ-0006Ix-Nu for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 11:24:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60f995d9-d3a4-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 13:24:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 01ACB22161; Wed, 5 Apr 2023 11:24:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE27A13A31; Wed, 5 Apr 2023 11:24:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XviXLFZaLWT9IgAAMHmgww (envelope-from ); Wed, 05 Apr 2023 11:24:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60f995d9-d3a4-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680693847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oUbQqR93vbZJC0urz3kBptj/FjpSXr9L+EvtWJIzkAY=; b=ezl7dZOyS77RQ86UNc7n8IlIi5lpR0FyYMjVG9l1Cf5GWUeRcyQOZJ8jU0cd5TjdNlJ94l 9lCyJ3o6zwcLlKrhnVg3Owaq+PyqRmfz6Je6gx/VRJ620F4w+6GSyvNoK3ugFohdnh1tgG 2u3UZc5fN6qZhr0n6v7UeNOMtii8Wtc= Message-ID: <563ff69f-0e9d-c90a-d18c-b3c351575716@suse.com> Date: Wed, 5 Apr 2023 13:24:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/2] xen: update CONFIG_DEBUG_INFO help text Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-3-jgross@suse.com> <358e9788-b930-5c51-1e89-232be43f83e5@suse.com> From: Juergen Gross In-Reply-To: <358e9788-b930-5c51-1e89-232be43f83e5@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3BvgmbWaZapsVCTU88DTFarK" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3BvgmbWaZapsVCTU88DTFarK Content-Type: multipart/mixed; boundary="------------hTOaozWB0FeTq5Wz2qESremc"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <563ff69f-0e9d-c90a-d18c-b3c351575716@suse.com> Subject: Re: [PATCH v2 2/2] xen: update CONFIG_DEBUG_INFO help text References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-3-jgross@suse.com> <358e9788-b930-5c51-1e89-232be43f83e5@suse.com> In-Reply-To: <358e9788-b930-5c51-1e89-232be43f83e5@suse.com> --------------hTOaozWB0FeTq5Wz2qESremc Content-Type: multipart/mixed; boundary="------------wL7lCk1Jbl1XcOSznPXSa8r6" --------------wL7lCk1Jbl1XcOSznPXSa8r6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDQuMjMgMTE6MDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMy4wNC4yMDIz IDE4OjI4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL0tjb25maWcuZGVi dWcNCj4+ICsrKyBiL3hlbi9LY29uZmlnLmRlYnVnDQo+PiBAQCAtMTUsOCArMTUsMTQgQEAg Y29uZmlnIERFQlVHX0lORk8NCj4+ICAgCWJvb2wgIkNvbXBpbGUgWGVuIHdpdGggZGVidWcg aW5mbyINCj4+ICAgCWRlZmF1bHQgREVCVUcNCj4+ICAgCWhlbHANCj4+IC0JICBJZiB5b3Ug c2F5IFkgaGVyZSB0aGUgcmVzdWx0aW5nIFhlbiB3aWxsIGluY2x1ZGUgZGVidWdnaW5nIGlu Zm8NCj4+IC0JICByZXN1bHRpbmcgaW4gYSBsYXJnZXIgYmluYXJ5IGltYWdlLg0KPj4gKwkg IFNheSBZIGhlcmUgaWYgeW91IHdhbnQgdG8gYnVpbGQgWGVuIHdpdGggZGVidWcgaW5mb3Jt YXRpb24uIFRoaXMNCj4+ICsJICBpbmZvcm1hdGlvbiBpcyBuZWVkZWQgZS5nLiBmb3IgZG9p bmcgY3Jhc2ggZHVtcCBhbmFseXNpcyBvZiB0aGUNCj4+ICsJICBoeXBlcnZpc29yIHZpYSB0 aGUgImNyYXNoIiB0b29sLg0KPj4gKwkgIFNheWluZyBZIHdpbGwgaW5jcmVhc2UgdGhlIHNp emUgb2YgdGhlIHhlbi1zeW1zIGFuZCB4ZW4uZWZpDQo+PiArCSAgYmluYXJpZXMuIEluIGNh c2UgdGhlIHNwYWNlIG9uIHRoZSBFRkkgYm9vdCBwYXJ0aXRpb24gaXMgcmF0aGVyDQo+PiAr CSAgbGltaXRlZCwgeW91IG1heSB3YW50IHRvIG1ha2UgdXNlIG9mIHRoZSBJTlNUQUxMX0VG SV9TVFJJUCBtYWtlDQo+PiArCSAgdmFyaWFibGUgd2hlbiBidWlsZGluZyB0aGUgaHlwZXJ2 aXNvciwgaW4gb3JkZXIgdG8gc3RyaXAgeGVuLmVmaQ0KPj4gKwkgIGJlZm9yZSBpbnN0YWxs aW5nIGl0IHRvIHRoZSBFRkkgcGFydGl0aW9uLg0KPiANCj4gSG1tLCBJTlNUQUxMX0VGSV9T VFJJUCBpcyBvbmx5IGEgY291cnRlc3kgdG8gZGV2ZWxvcGVycyB3YW50aW5nIHRvIGluc3Rh bGwNCj4geGVuLmVmaSBkaXJlY3RseSBpbnRvIHRoZSBFRkkgcGFydGl0aW9uLiBJdCB3b3Vs ZG4ndCBhZmZlY3QgdGhlIG5vcm1hbA0KPiBmbG93LCBhbmQgaGVuY2UgSSB0aGluayB0aGlz IHdhbnRzIGV4cHJlc3NpbmcgaGVyZSBzdWNoIHRoYXQgYm90aCBraW5kcyBvZg0KPiBwZW9w bGUgaGF2ZSBhdCBsZWFzdCBhIGhpbnQgd2hhdCB0aGV5IG5lZWQgdG8gZG8uIEkuZS4gaW4g dGhlIG5vcm1hbCBjYXNlDQo+IHRoZXknZCBuZWVkIHRvIGFkanVzdCB0aGUgd2F5IHhlbi5l ZmkgaXMgInByb3BhZ2F0ZWQiIGZyb20gaXRzIGluc3RhbGxlZA0KPiBsb2NhdGlvbiBvbnRv IHRoZSBFRkkgcGFydGl0aW9uLCB0byBkbyB0aGUgZGVzaXJlZCBzdHJpcHBpbmcgYXQgdGhh dCB0aW1lLg0KDQpXb3VsZCB5b3UgYmUgZmluZSB3aXRoOg0KDQogICBJbiBjYXNlIHRoZSBz cGFjZSBvbiB0aGUgRUZJIGJvb3QgcGFydGl0aW9uIGlzIHJhdGhlcg0KICAgbGltaXRlZCwg eW91IG1heSB3YW50IHRvIGluc3RhbGwgYSBzdHJpcHBlZCB2YXJpYW50IG9mIHhlbi5lZmkg aW4NCiAgIHRoZSBFRkkgYm9vdCBwYXJ0aXRpb24gKGxvb2sgZm9yICJJTlNUQUxMX0VGSV9T VFJJUCIgaW4NCiAgIGRvY3MvbWlzYy9lZmkucGFuZG9jIGZvciBtb3JlIGluZm9ybWF0aW9u IC0gd2hlbiBub3QgdXNpbmcNCiAgICJtYWtlIGluc3RhbGwteGVuIiBmb3IgaW5zdGFsbGlu ZyB4ZW4uZWZpLCBzdHJpcHBpbmcgbmVlZHMgdG8gYmUNCiAgIGRvbmUgb3V0c2lkZSB0aGUg WGVuIGJ1aWxkIGVudmlyb25tZW50KS4NCg0KDQpKdWVyZ2VuDQo= --------------wL7lCk1Jbl1XcOSznPXSa8r6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------wL7lCk1Jbl1XcOSznPXSa8r6-- --------------hTOaozWB0FeTq5Wz2qESremc-- --------------3BvgmbWaZapsVCTU88DTFarK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmQtWlYFAwAAAAAACgkQsN6d1ii/Ey+O sgf9EmalaxAcqPyJFCxRiUgtTIOgegw1DREeJU+Ds1jGSIz8LoXi8rOJcFj6o+wxtocr67njyeQ2 zb7alst8y00MFFEyUh3Afnke+apjKZ+nIfkYdWrZopTneqcdVDgUr+1COTKiFm5ad6hnMclL7lE9 qSLQTA85Vm4C37k2wQ3BAseVDMMHrcmeUI0FGmPpPTwUT6hi2Ts0/WXqxZh8GU+oB95yMzODX9l1 LG0ilJQr73ZUVn61jm2yFhF3pN5tRX0ttXYLkqDCje76HYWaOWhjYLovt0+/R7dkPDJd7MzqtxtO ya/gHS0J8Lxci3RUcRo1heb0JoIuSb99wHhQ+kq4TA== =s4PX -----END PGP SIGNATURE----- --------------3BvgmbWaZapsVCTU88DTFarK-- From xen-devel-bounces@lists.xenproject.org Wed Apr 05 11:51:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 11:51:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518487.805097 (Exim 4.92) (envelope-from ) id 1pk1fY-0002DO-AU; Wed, 05 Apr 2023 11:51:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518487.805097; Wed, 05 Apr 2023 11:51:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk1fY-0002DH-7t; Wed, 05 Apr 2023 11:51:16 +0000 Received: by outflank-mailman (input) for mailman id 518487; Wed, 05 Apr 2023 11:51:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk1fV-0002D6-Um for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 11:51:14 +0000 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2480ff71-d3a8-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 13:51:06 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 04:51:02 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2023 04:50:52 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pk1f5-00ColQ-2n; Wed, 05 Apr 2023 14:50:47 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2480ff71-d3a8-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680695466; x=1712231466; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CNsMJe3NJRh194M0JTRSE7YPi2b+rJpnYVMeT8Rmlsg=; b=beMB0TzY/9t3ZXnHaXJ+nTAQ/kOAeDt1srIWZRgNoYKgvNW9VOT+0lTP +33amnHV7nZs/Wln0KwMiaqnKDChCwUi9cMmAGnfIZbZ9XTuK5zXEQQap HnriDMwgMQqEta72leV+XgpC3GKh1/+n+Wi8k0OLhNxxK94EZCI6JUxaz AR2ZqNNq+sNQFvh+W9dxgQldeJOFQu8xmMpH904yPKDL3gwKzq28OFLRH RD6it8dX5N3BZp627RfvjLrxPDYxiAplGQaE7Qof5rj8ju2+cCpT40QCm A+OaEMNKhXN2nDAFqfrCuZ8seSnACfClA6MXHoZgFIrNopaiURPShEPJh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="405207771" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="405207771" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="797887729" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="797887729" Date: Wed, 5 Apr 2023 14:50:47 +0300 From: Andy Shevchenko To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 5/7] PCI: Allow pci_bus_for_each_resource() to take less arguments Message-ID: References: <20230330162434.35055-1-andriy.shevchenko@linux.intel.com> <20230330162434.35055-6-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330162434.35055-6-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Mar 30, 2023 at 07:24:32PM +0300, Andy Shevchenko wrote: > Refactor pci_bus_for_each_resource() in the same way as it's done in > pci_dev_for_each_resource() case. This will allow to hide iterator > inside the loop, where it's not used otherwise. > > No functional changes intended. Bjorn, this has wrong author in your tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=resource&id=46dbad19a59e0dd8f1e7065e5281345797fbb365 Or did I misinterpret something? -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Apr 05 12:29:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 12:29:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518492.805108 (Exim 4.92) (envelope-from ) id 1pk2GH-0007LU-BM; Wed, 05 Apr 2023 12:29:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518492.805108; Wed, 05 Apr 2023 12:29:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2GH-0007LN-8X; Wed, 05 Apr 2023 12:29:13 +0000 Received: by outflank-mailman (input) for mailman id 518492; Wed, 05 Apr 2023 12:29:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2GG-0007LA-2h; Wed, 05 Apr 2023 12:29:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2GF-0007Kf-T4; Wed, 05 Apr 2023 12:29:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2GF-0002Bf-JC; Wed, 05 Apr 2023 12:29:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk2GF-0002bc-HU; Wed, 05 Apr 2023 12:29:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rSmjIYVoguXEwcp7J0Zysrmo9pmK9TI7ocrw0C3tQCk=; b=42NFmFsjaNY1OO5PRjMUNrGtJd PXP7zhPgpOwc6BzvqFbS9JKHIFqbQNIdd7mSNt2gcsJc1zJRSH2AKwT+4xfQdiq8XWI8P/jT0DCtq iUMeQJ2JO5rwLrrQFHsFwFdtBou0SFpz0j9iLTAgQ/3IsxicPYreRhbOlnmvoYEEfJHU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180146: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=7d0334e49111787ae19fbc8d29ff6e7347f0605e X-Osstest-Versions-That: qemuu=51a6dc9d394098e8f4141fad869a1ee9585f54f8 From: osstest service owner Date: Wed, 05 Apr 2023 12:29:11 +0000 flight 180146 qemu-mainline real [real] flight 180151 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180146/ http://logs.test-lab.xenproject.org/osstest/logs/180151/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 12 windows-install fail pass in 180151-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail in 180151 like 180136 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180136 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180136 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180136 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180136 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a version targeted for testing: qemuu 7d0334e49111787ae19fbc8d29ff6e7347f0605e baseline version: qemuu 51a6dc9d394098e8f4141fad869a1ee9585f54f8 Last test of basis 180136 2023-04-04 13:08:44 Z 0 days Testing same since 180146 2023-04-05 03:09:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Daniel P. Berrangé David Woodhouse Dr. David Alan Gilbert Dr. David Alan Gilbert Eric Blake Junqiang Wang Marco Liebel Peter Maydell Philippe Mathieu-Daudé Richard Henderson Song Gao tanhongze Thomas Huth Tianrui Zhao Warner Losh Weiwei Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 51a6dc9d39..7d0334e491 7d0334e49111787ae19fbc8d29ff6e7347f0605e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Apr 05 12:34:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 12:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518498.805118 (Exim 4.92) (envelope-from ) id 1pk2L5-0000WY-UZ; Wed, 05 Apr 2023 12:34:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518498.805118; Wed, 05 Apr 2023 12:34:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2L5-0000WR-R8; Wed, 05 Apr 2023 12:34:11 +0000 Received: by outflank-mailman (input) for mailman id 518498; Wed, 05 Apr 2023 12:34:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2L4-0000Vv-Gl; Wed, 05 Apr 2023 12:34:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2L4-0007UA-FX; Wed, 05 Apr 2023 12:34:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2L4-0002XQ-07; Wed, 05 Apr 2023 12:34:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk2L3-0004rT-Vr; Wed, 05 Apr 2023 12:34:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lla/AEeIulxWhi8A1nh0/EHunR5dFLClMwvtKlMkPYA=; b=nHS4TLucBXJSMlu6sWLYMP+cDH QUk3W96Yv5w27xUpUiHc5CVTXZA3pVo+FeIgr1E2BqtQSBqGfbwIY7YkGog2zjAD9DXzXSs1AjJMx zS/Zc4L9cvp3tAwjqwjVJbXSvCm92QE43VlCudcPCwpmUdW6AD0VplsVuw9SznAJi1zM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180150: all pass - PUSHED X-Osstest-Versions-This: ovmf=cdd79996c217805a5bd67bb0c0e4ca05474ef92e X-Osstest-Versions-That: ovmf=7df447930c42addaf2cc0d32916141d95ded677e From: osstest service owner Date: Wed, 05 Apr 2023 12:34:09 +0000 flight 180150 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180150/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cdd79996c217805a5bd67bb0c0e4ca05474ef92e baseline version: ovmf 7df447930c42addaf2cc0d32916141d95ded677e Last test of basis 180141 2023-04-04 17:42:43 Z 0 days Testing same since 180150 2023-04-05 09:43:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7df447930c..cdd79996c2 cdd79996c217805a5bd67bb0c0e4ca05474ef92e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 05 12:38:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 12:38:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518504.805128 (Exim 4.92) (envelope-from ) id 1pk2Oy-0001H4-Fn; Wed, 05 Apr 2023 12:38:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518504.805128; Wed, 05 Apr 2023 12:38:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2Oy-0001Gx-CJ; Wed, 05 Apr 2023 12:38:12 +0000 Received: by outflank-mailman (input) for mailman id 518504; Wed, 05 Apr 2023 12:38:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2Ox-0001Go-Fu for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 12:38:11 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b72a6f23-d3ae-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 14:38:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b72a6f23-d3ae-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680698288; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=y9fFf4bToVg4q4ZBqyMdCtjoZ6FaJ5VIqXWpwJzTqIM=; b=fkghSAuGhX7z90Qt0sbRyLFXhQTnIxYLT5U35M7Ke+g1H0TH8IDjaCJG U6cjhjQrAq3RjuWIus3YnbRPeJEAXxUSKNZVLUeHlvzS2tlxoHZqcKZiJ cqXVnl07P2OGt/8Yq8UPuQoo1X2h4rnEULH/B2OneOdBtB32aoper+fOS s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104823534 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:rgPFbqsYCg4oqqGDQev7+E4sDufnVCleMUV32f8akzHdYApBsoF/q tZmKWHSb66OamTyet12aYnl/EkFvMDQyNI1QQRori42EyMR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGyiFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwFWkvdjCeosiP5LOfTPBTr50zdu6yM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw/ zqarz6iX0pGXDCZ4Tu0yErvt/PhpxLUAZsWCISiteNrpkLGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8UYwgyQzqvf4y6CG3MJCDVGbbQOq8seVTEsk FiTkLvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZTZcwcHDvaQZtzbOatB6L4fsnofSQD6ll lhmsxMCa6UvYd8jjvvrpQ6W22Py+fAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9o4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/i4S4++DKGPPosWCnSUSONg1Hg3DXN8Iki3yBR8+U3BE czznTmQ4YYyVv08kWveqxY12r433CEurV7uqWTA503/i9K2PSfFIYrpxXPSNojVGovY+lSKm zueXuPWoyhivBrWOHCPrtJNcglVdhDWx/ne8qRqSwJKGSI+cElJNhMb6elJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23:0/13Ca4TRXW1EtxEkQPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-IronPort-AV: E=Sophos;i="5.98,319,1673931600"; d="scan'208";a="104823534" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD Subject: [PATCH] tools/libs/guest: Fix build following libx86 changes Date: Wed, 5 Apr 2023 13:37:55 +0100 Message-ID: <20230405123755.1427246-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit I appear to have lost this hunk somewhere... Fixes: 1b67fccf3b02 ("libx86: Update library API for cpu_policy") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Anthony PERARD --- tools/libs/guest/xg_cpuid_x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 33d366a8eb43..bd16a87e489c 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -555,7 +555,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, const uint32_t *dfs; if ( !test_bit(b, disabled_features) || - !(dfs = x86_cpuid_lookup_deep_deps(b)) ) + !(dfs = x86_cpu_policy_lookup_deep_deps(b)) ) continue; for ( i = 0; i < ARRAY_SIZE(disabled_features); ++i ) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 12:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 12:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518508.805137 (Exim 4.92) (envelope-from ) id 1pk2am-0004Ao-Hg; Wed, 05 Apr 2023 12:50:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518508.805137; Wed, 05 Apr 2023 12:50:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2am-0004Ah-Er; Wed, 05 Apr 2023 12:50:24 +0000 Received: by outflank-mailman (input) for mailman id 518508; Wed, 05 Apr 2023 12:50:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2al-0004AS-1m; Wed, 05 Apr 2023 12:50:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2ak-0008PD-Sa; Wed, 05 Apr 2023 12:50:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2ak-0003QK-LP; Wed, 05 Apr 2023 12:50:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk2ak-0004p4-Ku; Wed, 05 Apr 2023 12:50:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/40jwugWICvczquiRvorV8dIpJGVFD+rlTR5bFzBZpg=; b=cL+zKuInMtoVSnS9t9PizpvhTj vHjukMvJEjWmPbQ1SpfoYG7JDr9ddND4ywZF4l7sz+9t0x6zlggx4VHL4nJ5vnuq6w/hzc9Yg/7m5 wgWE/99n5ZAIUI3hv959ULpOCgckwaNmMZ0QqRs6Q00BI4W690z+HwFkDHLrOxbnBxqg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180152: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: xen-unstable-smoke:build-amd64:xen-build:fail:regression xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=994c1553a158ada9db5ab64c9178a0d23c0a42ce X-Osstest-Versions-That: xen=415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 From: osstest service owner Date: Wed, 05 Apr 2023 12:50:22 +0000 flight 180152 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180152/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 180143 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 994c1553a158ada9db5ab64c9178a0d23c0a42ce baseline version: xen 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 Last test of basis 180143 2023-04-04 19:00:27 Z 0 days Testing same since 180152 2023-04-05 11:02:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 fail build-armhf starved build-amd64-libvirt blocked test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 994c1553a158ada9db5ab64c9178a0d23c0a42ce Author: Andrew Cooper Date: Wed Mar 29 13:07:03 2023 +0100 x86: Remove temporary {cpuid,msr}_policy defines With all code areas updated, drop the temporary defines and adjust all remaining users. No practical change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich commit 1b67fccf3b02825f6a036bad06cd17963d0972d2 Author: Andrew Cooper Date: Mon Apr 3 14:18:43 2023 +0100 libx86: Update library API for cpu_policy Adjust the API and comments appropriately. x86_cpu_policy_fill_native() will eventually contain MSR reads, but leave a TODO in the short term. No practical change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich commit a16dcd48c2db3f6820a15ea482551d289bd9cdec Author: Andrew Cooper Date: Mon Apr 3 17:14:14 2023 +0100 tools/fuzz: Rework afl-policy-fuzzer With cpuid_policy and msr_policy merged to form cpu_policy, merge the respective fuzzing logic. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 441b1b2a50ea3656954d75e06d42c96d619ea0fc Author: Andrew Cooper Date: Mon Apr 3 20:03:57 2023 +0100 x86/emul: Switch x86_emulate_ctxt to cpu_policy As with struct domain, retain cpuid as a valid alias for local code clarity. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 8eb56eb959a50bf9afd0fd590ec394e9145970a4 Author: Andrew Cooper Date: Mon Apr 3 19:06:02 2023 +0100 x86/boot: Merge CPUID policy initialisation logic into cpu-policy.c Switch to the newer cpu_policy nomenclature. Do some easy cleanup of includes. No practical change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich commit 4f20f596ce9bd95bde077a1ae0d7e07d20a5f6be Author: Andrew Cooper Date: Mon Apr 3 17:48:43 2023 +0100 x86/boot: Move MSR policy initialisation logic into cpu-policy.c Switch to the newer cpu_policy nomenclature. No practical change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich commit 1027df4c00823f8b448e3a6861cc7b6ce61ba4e4 Author: Andrew Cooper Date: Thu Mar 30 18:21:01 2023 +0100 x86: Out-of-inline the policy<->featureset convertors These are already getting over-large for being inline functions, and are only going to grow further over time. Out of line them, yielding the following net delta from bloat-o-meter: add/remove: 2/0 grow/shrink: 0/4 up/down: 276/-1877 (-1601) Switch to the newer cpu_policy terminology while doing so. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich commit 66c5c99656314451ff9520f91cff5bb39fee9fed Author: Andrew Cooper Date: Wed Mar 29 12:01:33 2023 +0100 x86: Drop struct old_cpu_policy With all the complicated callers of x86_cpu_policies_are_compatible() updated to use a single cpu_policy object, we can drop the final user of struct old_cpu_policy. Update x86_cpu_policies_are_compatible() to take (new) cpu_policy pointers, reducing the amount of internal pointer chasing, and update all callers to pass their cpu_policy objects directly. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit c9985233ca663fea20fc8807cf509d2e3fef0dca Author: Andrew Cooper Date: Wed Mar 29 12:37:33 2023 +0100 x86: Merge xc_cpu_policy's cpuid and msr objects Right now, they're the same underlying type, containing disjoint information. Use a single object instead. Also take the opportunity to rename 'entries' to 'msrs' which is more descriptive, and more in line with nr_msrs being the count of MSR entries in the API. test-tsx uses xg_private.h to access the internals of xc_cpu_policy, so needs updating at the same time. Take the opportunity to improve the code clarity by passing a cpu_policy rather than an xc_cpu_policy into some functions. No practical change. This undoes the transient doubling of storage space from earlier patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit bd13dae34809e61e37ba1cd5de893c5c10c46256 Author: Andrew Cooper Date: Wed Mar 29 11:32:25 2023 +0100 x86: Merge a domain's {cpuid,msr} policy objects Right now, they're the same underlying type, containing disjoint information. Drop the d->arch.msr pointer, and union d->arch.cpuid to give it a second name of cpu_policy in the interim. Merge init_domain_{cpuid,msr}_policy() into a single init_domain_cpu_policy(), moving the implementation into cpu-policy.c No practical change. This undoes the transient doubling of storage space from earlier patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 6bc33366795d14a21a3244d0f3b63f7dccea87ef Author: Andrew Cooper Date: Wed Mar 29 07:39:44 2023 +0100 x86: Merge the system {cpuid,msr} policy objects Right now, they're the same underlying type, containing disjoint information. Introduce a new cpu-policy.{h,c} to be the new location for all policy handling logic. Place the combined objects in __ro_after_init, which is new since the original logic was written. As we're trying to phase out the use of struct old_cpu_policy entirely, rework update_domain_cpu_policy() to not pointer-chase through system_policies[]. This in turn allows system_policies[] in sysctl.c to become static and reduced in scope to XEN_SYSCTL_get_cpu_policy. No practical change. This undoes the transient doubling of storage space from earlier patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 03812da3754d550dd8cbee7289469069ea6f0073 Author: Andrew Cooper Date: Tue Mar 28 21:24:20 2023 +0100 x86: Merge struct msr_policy into struct cpu_policy As with the cpuid side, use a temporary define to make struct msr_policy still work. Note, this means that domains now have two separate struct cpu_policy allocations with disjoint information, and system policies are in a similar position, as well as xc_cpu_policy objects in libxenguest. All of these duplications will be addressed in the following patches. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 743e530380a007774017df9dc2d8cb0659040ee3 Author: Andrew Cooper Date: Tue Mar 28 18:55:19 2023 +0100 x86: Rename struct cpuid_policy to struct cpu_policy Also merge lib/x86/cpuid.h entirely into lib/x86/cpu-policy.h Use a temporary define to make struct cpuid_policy still work. There's one forward declaration of struct cpuid_policy in tools/tests/x86_emulator/x86-emulate.h that isn't covered by the define, and it's easier to rename that now than to rearrange the includes. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 21e3ef57e0406b6b9a783f721f29df8f91a00f99 Author: Andrew Cooper Date: Tue Mar 28 20:48:29 2023 +0100 x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields These weren't great names to begin with, and using {leaves,msrs} matches up better with the existing nr_{leaves,msr} parameters anyway. Furthermore, by renaming these fields we can get away with using some #define trickery to avoid the struct {cpuid,msr}_policy merge needing to happen in a single changeset. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit c2ec94c370f211d73f336ccfbdb32499f1b05f82 Author: Andrew Cooper Date: Tue Mar 28 20:31:33 2023 +0100 x86: Rename struct cpu_policy to struct old_cpuid_policy We want to merge struct cpuid_policy and struct msr_policy together, and the result wants to be called struct cpu_policy. The current struct cpu_policy, being a pair of pointers, isn't terribly useful. Rename the type to struct old_cpu_policy, but it will disappear entirely once the merge is complete. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Apr 05 12:56:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 12:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518515.805148 (Exim 4.92) (envelope-from ) id 1pk2gk-00055I-BC; Wed, 05 Apr 2023 12:56:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518515.805148; Wed, 05 Apr 2023 12:56:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2gk-00055A-8S; Wed, 05 Apr 2023 12:56:34 +0000 Received: by outflank-mailman (input) for mailman id 518515; Wed, 05 Apr 2023 12:56:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2gi-00054z-Q1 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 12:56:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 485f72f6-d3b1-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 14:56:31 +0200 (CEST) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 08:56:28 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DS7PR03MB5398.namprd03.prod.outlook.com (2603:10b6:5:2c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 12:56:25 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Wed, 5 Apr 2023 12:56:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 485f72f6-d3b1-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680699391; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=LG+xH0EesdaTqZvUOLS0x3iH9+npzY9Dt2rpaa6Wl6A=; b=RhOd+GavSqcdW7huMfyp2wWEzFwg2ap/U1CHVuMwmKyKYjCPRmRBAA4K YHZ728Vgi1uKRn1+En8KxhzYn4elefJ6KALGQLlrMC64My5JZqtPj56JK kRuKoBAUu5JtxZrA9IevStpaZYwwrKzfTTAINJ+jQsqcYRu26mdNvFL7S o=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 104325715 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:QkQl+a7WPQtj95A+iXqJlAxRtB7GchMFZxGqfqrLsTDasY5as4F+v mVNXjqEOa2ONjGhLoogaIq/o09Q6MSGn95jT1NrpHg8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m3 Ns1DhVcTTG/3+Od5bmibbB0usARFZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOCF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxX+gAt9NTeDQGvhCgUavlksWDi8teEqm8Nucjx7hXINRE hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQP4MudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9URX5NkcHbC4ACAEDvN/qpdhrigqVF447VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraT0gbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:B1bHBK5f43Mlpx1FOwPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-IronPort-AV: E=Sophos;i="5.98,319,1673931600"; d="scan'208";a="104325715" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+N9EI9TkQ/DhWeNlnE7Yo/sldMCNp1mdQD3T9TuoAYCwkLIviMDTeX2GbQX/ePQTzT5/Vw/6tioKm/LpY0NSMtSiWjv4VCwlDwr/SsP1cNg/3rovm5NsbRviKbUFAi83+zT39tbpu5RWLT4hoDCbqsu82xnv9/GWYG7rmnc9gg4xd7y/bAiUjvra91kWWsgmhKm3kzTVTjbff//E9R0uvEW/H/SV8Jv6eTPIQtE1O9PTArIjscS0S8I5yYpBWcBHFQn7pBQmJoLhSV3SjJExmhCI95ScR5nkOJl8HZRYtgZMNtvWwJMcL07wTvQeu4Vwo0tFaG2NRKDcX7dQM2Tyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aBW7ugeVKCpkm57u3b8Y1zOQVaNuGRpQnnTXZkDDejI=; b=kN8R7AcTMx8DjQ5lZP2vSJmaJ1XVprwYnCJM8/2e6DhRIg2Z/ALx6HTSDoVr7u54cWRnniGV7icvIsMU9+Xxi0jk0okFVB4VE2F906lY/Ggnsar9rdl0jlHFL8T4pPMvN6RjaJEqvk2S7j21vXKUgEd27G29E6UQ+gwkjj5LEwmIo+37jEIxG+zAlCp8Edq+UyGaeiZPjTkLWrYQWNN3NGxF+4z+0lz2En0lXhT2+gcynm04x0MFdcCH+s3aiNxqYf1ie3e3pccxujVinoeyWUm7YGGFk4n2BvuSUGTWRYAlF50jM48EXd619t5a+fJ2SrbFufWGjun+bq255/cT4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aBW7ugeVKCpkm57u3b8Y1zOQVaNuGRpQnnTXZkDDejI=; b=axbWHihRB9XMHG8McbpiQr6H1zhb6Vf4kvdmbSbk6LYSejwopISc8S1gbIysg86hqT46m/SXEn2MoKFDdHe8fKoLXROXiT7T1w6ya8hlGKZ0qp/Ank75iBJZ7D8FJOoaU0gSoWpuc3HsQ9oN1HdSoU+OYSO/Mxoic5O3wiOChuo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 5 Apr 2023 14:56:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu , Anthony PERARD Subject: Re: [PATCH] tools/libs/guest: Fix build following libx86 changes Message-ID: References: <20230405123755.1427246-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230405123755.1427246-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P265CA0278.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37a::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DS7PR03MB5398:EE_ X-MS-Office365-Filtering-Correlation-Id: a79f9569-2f32-4237-b2d4-08db35d52a13 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3atwFRkU9JE+3BrAmpS3zE+v6F8oCgtVdjZBXApsWXo4kh291tRI/4EqWutxaDaJ1ihDtg/N/+uhF9A1DjptX5P2AXXcswpU9kgCiDtVW3lIhoYicmE3/7zN8JKlxNicdYEVvIXvEzckWVEgXuk0dJRKA4jAXRL0XWYLgdKOGPDomcnvRfxv/Fu4plHCmSPzcoEWuGP0EuQ5Z7s0CXDApTDQYqRRE7x6EzdNFjypsNnvIibufIL7NDLKtLA/MZQB9NQukpUWHD4XuRoHY3VQCazKsloxIgnDTxcI8kcLH2IHQv9sNsMorvLXdCtZNihY4bx+EgBjAONBRD8j7G+vQysXUoCYnRRhHex6XKdY7vuI9s8vB2Z9SzkCdBNJnUzkn8PTArB34rPtsAqiCarXLltdS7P0SrGkqo4N+bGDsQC9VRIDtrs+JcrOIiRhJU7f30H4Mrv20PtPDA/mIMtyOq7SeU3ulbdmtCyya01l9RTEBlOGXkB5i13B5VXmQoARp3+bmTOYYzE+jJ+/zEicxbaHh7qiII5jLiSACI5t0659b4xIsCHX2PYigH3aA59Ez/2CVsDD5OO5rFHsKtVTxAhucoTsMt1wdUsm+QxyFtw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199021)(5660300002)(54906003)(316002)(6636002)(6862004)(41300700001)(8936002)(2906002)(186003)(478600001)(66946007)(66556008)(4326008)(66476007)(8676002)(6486002)(107886003)(6666004)(6512007)(6506007)(26005)(9686003)(83380400001)(85182001)(38100700002)(558084003)(82960400001)(33716001)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWEwQUpMTnR6VDlPdmpKclppY2FTQnZNN0VyQ1lySWp4OFNZMFpTY1cvM3Ix?= =?utf-8?B?d29hOXU4WVlFbXhFV2lZU3p1OFFvUmZEYjkrSFdHTUd5dlJGUEc2RGowRzda?= =?utf-8?B?cGlSdjZobnk3dkJEQWI2dTlRczJoS2VwZXRUcXZPVzUyWWJGZHFCMWNSMDVn?= =?utf-8?B?OXU1VXlPV0VrRHhMeUNRNG9TTExNMW45NkVNSXFmWmZWN1pNU3gxWVBNanl0?= =?utf-8?B?QTV6VFJ4d3ZjOUUrU1VlOE5TZFhsQ1pKZER6cHhUYTB4dnQ1UzlrVml0RGlE?= =?utf-8?B?ZkRHZ0lDQWN5NGp6QVhpSmxOMUE2NTJsSENsNEVxSnNxTG8zZitQTDhScnZm?= =?utf-8?B?Vm9La3ZZREdaZG1HSlh3RWpMUmdLTTBIQmcveWhoVFg4NnB4UGZqYWNxazNP?= =?utf-8?B?dCtXVFdnbVRMR0NNbVo3R3Y4R3JHRkkvaGl4WWFPM2ZOWGR6bWRtS0lOb0la?= =?utf-8?B?RjFqRzg2RmlVVXhXWkdBbDhRRlBJVmM0aDlUb2lnaUhDc1d3R21hTXl4REhJ?= =?utf-8?B?c0RCWExGY2ozWDRDb2h5Vk13am9qK2VoeE5Zdzl2RDFFL25uU0w1amQrY0M5?= =?utf-8?B?SmI0Umk3ZUdmUW4rcWVTdDUxNjJsbEdZSmVidHRtUUlTZ2didW0ycGxqS0RL?= =?utf-8?B?MUFybTR6eFFrUk5UWUhaeGdlNWdYMHg2SmljQnpCRjdJUWNSUkZzem5zbHdH?= =?utf-8?B?ak91M3M4bDVCeDV6dENaK1d3c2tDVHNsY1kyUVBQVFJpNjVPeVJZbzhZYk5l?= =?utf-8?B?TVFBRWlZSzVLeG1EOGlPWnZPZTMrQ0pkSXExQWtJaEE5VlhKZ21HQlJBaTQ2?= =?utf-8?B?K3FpS0xYK1hrUFh5UVhET1dGNFVNV0llOXAvNjUyajlNb3RTUklCcU45eUlh?= =?utf-8?B?ay9aaTEwSkxCbCs5R1hrTCt5SDIvMjZXUmRLQjhOYW1HbnhvVEtqM1lQUmhE?= =?utf-8?B?YlFvWlJiclVQazNML0xYT3ROd0NLSmYxSmV0ZkNNNUxkQ09lTXlTMGdLSEZz?= =?utf-8?B?VGpYZGtKS0tYZTduZG40WUZxUjdrN2NaMDczM2FsSGZQSkkzTnN6REZ3OVJW?= =?utf-8?B?VGlrNWY3ZjJhTVF5VE4zeHJhYkdqc2FybTBvcE5iazdzVzltdkpnaVZGTXNi?= =?utf-8?B?VGU3ODFla3doUzRaY3VkbC9YOSt3QTVzOTlSV2I1bVI3QzlGVkFBU1k5bndm?= =?utf-8?B?QjRNTGkwZGJjNFdXQXQ5TEVXc1d4OGQxSWdjdUpwbmI3aWJzeDZGbkZ6YlVy?= =?utf-8?B?ZEdFeE9lSUN6aFlFQm0yV1dEMW5ndzJGY093Z1U2cVJwZFJmbHY1dW1aWjE5?= =?utf-8?B?S2J0czExR2g3N016N2s5THB1c2N4cEg4RUd1bEVNZHh2OGlJOHIxRWNadWVn?= =?utf-8?B?RjMweWl1WnNOYmhzaHFIV3JqMXpJa2VxN1ltUWlPdXQ1Uytja1dkVnpwcE04?= =?utf-8?B?M1FDR0FxVWdBZldPOFhEV0MyMnV2MGRyU3M4QnVTSWRTaytLNmtJQkRVTGpv?= =?utf-8?B?TUxLV0xObGFYSFcyWVNYYzU2T3BaenE4NTFBai9xcUJ2ZXBrbTYrUXd3MC9N?= =?utf-8?B?TkxtTFdsUWhMTzBJd2htZVcvL3h5WUJDZ0QrWU93RDBicThUZG1yR2lkNU5m?= =?utf-8?B?aDk0Vm9CQXNMMVJDeGJta0tnc0JUSEdEdnZuZDJJL2hNUHV2WG5mSkhjdDla?= =?utf-8?B?OHEzOWdPYlFwMktEMllKQ2VDYnFiTmViaXhwMkw0K2hxcXByTGhlNFIzYjVp?= =?utf-8?B?ZVhxb3MwUDM3S2hWQk1rbVE3RXRMazF6MFZHbjBMaTA1NnR4S2IxT3pqZjZr?= =?utf-8?B?b1g3WkxlVVVudUFsWUFMb3dPd0NTS1NrZis5OWJwN2RMcGdqcERWRWpucy9h?= =?utf-8?B?Sm9sV3hiV2RMNjZxQXdoMWJreE96bjNENnhXSEYzY25OTVdYLytvRHd1aVVZ?= =?utf-8?B?bjlaREpwTFllbTNtcG54MGpyVnFiYTZpeTJxMzBYazNlTFFCcnRZeFY5bFRX?= =?utf-8?B?bXV3eHY1alZWTjMzZ09sSkRxa3RJUXQrMHhXZWM5MmNWc2RaVVc1dWloNGI3?= =?utf-8?B?M0VjbmYxYVlQdzJjWjBqcXA0MWlXek10UmZzRXBHUGFUV0dYWk05dnVHQVFB?= =?utf-8?Q?7S4s1zXHYPXDQdhqCL3SjVdMY?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UWraG3vZhzBUlEyzSwtwY5VqQKTWGQUD0hSUMLjGIzMxyyvJLbkDUHxdGCnHSw/+r7ASmrmeTxsPxjV7bjNbljIB+AP7abd7CTbqxKeUBN4KWZ6uHDcJHTwEt8m42Qtk6l2P3J27JJn47Uu/ZGM7Ttgw3eZoy2Jx23SUrAFAghS5qIjxxdEV1FYsazQnglue+boMMGsi1kb8Xpgy5U9DgYYMJZrcTIin4e3p/BlWDVT0wmbLuDdq9PM7vusUbxfSfGM69R7mzCRvm6FYucJ29CXv2pXOPLsEliUDuaMSjBKxuM+LuU7cuIv67/2HroUh7Vtvy/oHa5ugo6FmDDVGCF3hfUB5kWhfzpxdsPGa1WZ14ielQ6kA5YXRiDyVDnErW1oPfE3bBjUuNwHtk1TdQ8mGH/ZQtkYuFVAMPqkWJs2DohIzLx438EFicznE4nM+4ZygI4eQUaTZYI+KjnokI6F6nzGKo5l4FwCIDD4vcnnC6zKsyGjXscoYzTahDs0IfXaVfAC6VHx4/T4FJcNGCbjjr4X470UffGeLJXN6eWFWEyaVFlwi1Qv1kxpFICoxLZv9bWRK4gE4UGVSy+maMLYoE50gblWKmeZtgHmgtgjHH3iLbvXdCdWTEQge0VxoNt53JEBLAIxAg3WkQ8ylGaP+x0fKDPhZEp0YjPz695y9hvhHtLAk8hxnO4lYCO/npYjYF1tytcZj3JWSeTDeTW5yW8BUollnXMRujYvrZBqazt8oJYfuhHmUz0glWa1kZgROAyp9lqurIdmqigngIECWdu/IrgM1dzp8P5ikfP3eq3O2B9NJE1L3hX0/0CjZ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a79f9569-2f32-4237-b2d4-08db35d52a13 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 12:56:25.5555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BIYHNQVKdrzbaAFn7MhEN7fo3OuO9hUaEl6zuDKmwgcFHuRo4+0zu4n3JX2v3ItuEtxRIGWenhfrd5XsHey0TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5398 On Wed, Apr 05, 2023 at 01:37:55PM +0100, Andrew Cooper wrote: > I appear to have lost this hunk somewhere... > > Fixes: 1b67fccf3b02 ("libx86: Update library API for cpu_policy") > Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné Thanks. From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518520.805161 (Exim 4.92) (envelope-from ) id 1pk2ka-0006jc-Rp; Wed, 05 Apr 2023 13:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518520.805161; Wed, 05 Apr 2023 13:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2ka-0006jV-P2; Wed, 05 Apr 2023 13:00:32 +0000 Received: by outflank-mailman (input) for mailman id 518520; Wed, 05 Apr 2023 13:00:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2kY-0006jK-W6 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:00:31 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0607.outbound.protection.outlook.com [2a01:111:f400:fe1e::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d67a0e83-d3b1-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:00:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6897.eurprd04.prod.outlook.com (2603:10a6:208:184::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 13:00:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 13:00:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d67a0e83-d3b1-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bu1LozaZwSHW0gQ8nnl1ClKXoo70m7hMUZeWF+Rn/E8nfQVmzKSa0TREPaf1/O1cpGT5aS0rAgZyYkVw1H1yrD33T9byTv0uGykw5m/Qa5JBRdcHafJwX8C64RjgVlB+99z64J4TZr4gpBSOQ5lKLY3a47ounbO7KX5KoZQmYc2cOvajwbQaxy1ip/vo3VHOuVlPtsxNvr0VyAtx1kLoIsBfkBsnAFUqeeODi5KIxmCiikJr9/wSztmmeQAI3QHkNHF3ldhyYWzTFfx+RxjjqJjkl4W/Kgd5giICbwsHVLOfoBQiJ7R1e+zYVPG1uM8yj+IioyJKcD3yAVIWhBJwBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qAfNC/zjVcbX3wOy+qauUhTJ8tcVsFPgjltxjEMksao=; b=gJFipnJVgve6cXeZRxscll5tkVoMgsxmfSW4MKJKyUdzEO0gpwx9NXUQHvAWXf8EAYq2JBq85h2UDhYii4i6gnrYTzA33mUzDpbp6ppv3sP9LffHMk98k3gQDrMZ/pE8JP7/3dXONJ3joJTvoAec8cHWoVNWAy/N7d3O3n348MzZ3cWt/B7MvE/R1E9aFdrW9w4bkaccufi4thkzNWo62TEINUXxYylSpQVkq5WyURedb5TyxhfBQDhcHMwZ25oY0HTtIZN7+J4z5ON+q20UNHFjEJ9bKQfPcph4PnPX/M5iLVkCORnLq2bf3L5iHOTx/H0gWiAzglvytxZFa8eVlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qAfNC/zjVcbX3wOy+qauUhTJ8tcVsFPgjltxjEMksao=; b=CeIDe/eMpTRstGsb2sF1ACodnSgpT8dCvKFriNw90ZilNoJV9hgRIgZyuizVpJF39hJrLxk3Kh3mbgN2c9jnrCs/TK4lslutRcTikdq2myKVMw1xC2S5BZoGS3N8XqNCQMS4Xp+dr8dEJTUrCA9BA79kJ8PLWCHh0XyjUEGTqAPI19JmcwXjVehCjWj5LRlXpplohKxoy9YrMyqAzSJD10nRGF3r4LDLS32CQauHnJ14PX4xz037H/d+r4JisSmJD/ESzSgTnwrZIBCYwGzxlfukdd67z2zUwp4mT7j8+b3urRvJFpOFRUV32kWl6MJHjYTgoe039tCkTSopJmvHLw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52421029-a058-65fc-074b-fbcb1ccfb1b0@suse.com> Date: Wed, 5 Apr 2023 15:00:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH v3] x86emul: build with -Os Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6897:EE_ X-MS-Office365-Filtering-Correlation-Id: 5476f786-e6e4-400a-1910-08db35d5b94a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TvXv/9UOKXtqvCkHycSojunwrjd/9c3/aGQe07liLNbzlncxfsWsyQWYJ4/CEuSz77gpNXKImNA+DNSWTh2Cx0NkDqIFcMLSrTfQUyLd8I333wT2rOYhv+fKj3pVy+lt7D5x5FFEc+5Bf1ZX6saQy8IXQot6cwdMCi9Ehn6lcU2bYiwtkDQ8dATDuvL0KGLu9vTEtM6ggEzG5WS48JsJAaWTTklyIfG9r/laNGG2rmCqfR3orIKKr4MdgPnK8a7OvRsMeY7LCd+LYf5/7mVr8O0e3tEu/fADhUYF7reOz6Tfi9u52uK0xP1+m1qUD+DG+OhcnPE3uNPlaaLeiXNjvfXWSAgsBZ6aPdJgh3CjaakpRp1qTcMBmTAhGeZmCfpc0CVOAJx0TdKxnezd4+XgopwTizGGE7S6NH0VmpB4JEGvcHEHQBbPDk1og/5pSlISi8D7U78WErXr6M4lxye6quFCy4odTdOgteeSIkjZGKGgGciHzIL9/KpVoeqEmlazu4HG32e4H6Kf6JE8tbHkxp+IMjYX0elpHf6kl7F3O/cOkX528D2EtxSuQOaGspbZVHeZZZxznyEg0mtdzc1BkklMf9PgYOTj/FMdF9EDX7rCyPlCdjwqk2k/4oIQfLHL9AsfG+tuyxOah+IxdHy/Yg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(39850400004)(376002)(346002)(136003)(451199021)(31686004)(2906002)(6512007)(6506007)(26005)(2616005)(186003)(83380400001)(6486002)(5660300002)(8936002)(38100700002)(36756003)(478600001)(54906003)(316002)(41300700001)(31696002)(66556008)(66946007)(86362001)(4326008)(6916009)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R25rVG55aHQ1YmhTMzd6Q0kxdHRYdzk3WWhmb2w1Y0xnODQ5dnRUbjAyZFNm?= =?utf-8?B?cFJHNkd6U2lYTTVHZEpNb3dZZ3RZMDFuL2VKSG8vNTdIQlROeG5QVTdaVm1r?= =?utf-8?B?K1hEbWVGRjNhdUU0SE1QR2NmblJJbXNteGtyZ3BUcm5FemZ0Mnp2a0tjOFB2?= =?utf-8?B?cW91eThXMU9QNjhwWXJSSzRuRUphcHE1YzlSWTRkc3VkRWlHdC9pbVVoRVZx?= =?utf-8?B?dXJ0NEFKNmx6S3JEYnYyR3BGWnVEVmpsUUp6ajF4QTVNUXp5MUdVN1M4alRU?= =?utf-8?B?WlllVjRuQnVvRndFR1YvUjhraWdqTjJ0L3JhNUJyRlNxbjEySnlTZGk1bFVG?= =?utf-8?B?dFptdHhWMVR4WWpXdzBsNmt2SWRsMm11Q3dQTHVxejV6cGdqWHdCMnpXSHRY?= =?utf-8?B?RTNrVkpGTktsQWJ2ckVvcy9IL2luQ044RXFrMStld2VnZDFQWGZJcGFhQTBZ?= =?utf-8?B?YWptYlM5NHBPNmdEZERMVTZYMjhmT3JVdHNESkx2OUg1T2pGYndHYjd6L0p2?= =?utf-8?B?TWVUajh1ajd1UkJEajZZcnlsbFBQanR4b1I4c2VsOGNSR2d3NjZhMVZLbHhD?= =?utf-8?B?QUMrVWlXc0pzbDU0ekV5Zm1KR1Jra254a0Z0TnFBNDZhbXZkWGVVbnlyOG5X?= =?utf-8?B?cjhWZDNac0E4dUlmL3FGK2VoU2FUdkh0Rm05NlNYakh0RzZPYXBpdytEejFB?= =?utf-8?B?SGpjNUw2M2dzY0RCMjdCK2VLQkdEU1paY3ZMeXcrb2dSTVYxc01VSjRGU3Nl?= =?utf-8?B?TW5wVm1uQm8wZUFuUnU3bTlEb1QvRllHNDM4Wi9FMmgwTk1wWmxSVVk1azNS?= =?utf-8?B?amUrRFlVcjc5cm02TCtLTWFJam16MDZ5eElMcW1pc0YvUW15d1EzbUVmdkdF?= =?utf-8?B?a0habCtaMGpkSE94aEVQbG1TaWpjQzY3VWJVby9PZU4rVWl6NlVQZkd4NkUx?= =?utf-8?B?M2hVaGpWdVVIL3RMR3Bwd0RmZkFNcXo2UTJNZlBCSmV6a1RYbEYwd3JNWU52?= =?utf-8?B?cFpjcGwrajhSNmxHSEhRMzZmTDRDZCtGVVFRdjU3TTJJN0hSblgvSkZhQUpr?= =?utf-8?B?RUNjNEhnQkEvTzVsNThQa3hHbVdoVnFqTWIzUy9NcE5nRXZSV2NzNkg0TXEz?= =?utf-8?B?QW1RM0NOczlBZExQYkpsQ2xyTENBTk5LaWx6dE5vSDdET3YyVTZDcmpuK09E?= =?utf-8?B?NXpVZE5EUkc0RE41RmtvQTMrd1hvbDBnTGFGQUNtTlc4cWl4WlRDOUl0ampH?= =?utf-8?B?L0FHd1dJZHhkZjFreXUreU9IcmJIYVdEMDMrQVEvekF0eUJHelJ0akwxcVYy?= =?utf-8?B?RjlpeVBNMk4rRWJac21VSlpnZlRzSG5uS2Z2eXRCUDJxK0dyQzZ4T1dSRVNu?= =?utf-8?B?a0JGcHp4aGFxR2tTR0J1SzhLbFcwRnhpVkF3OS8zeXNnUjhwc3RuYXJBQ1c5?= =?utf-8?B?dllHQUVwZVUwYzhOOVVNZFFaSkM1dy8rRVB2VzFoVU1Nb2lxRmdpUkZjV1FC?= =?utf-8?B?bS9yS0I0cDVjMkIxM0NmWG8zcU85T09IUXJRYzA2RFA3Mit1bURRNEhlL3Zk?= =?utf-8?B?WU5TdWN4blpNVk5yS0w5Vldma3pYcU1IWWl2cVd1YTdqemxDcjNwYVlibUVP?= =?utf-8?B?MEhuSTZpbEZPYTNRbndJelRWSWJjNk5vakZNL0VSZkhGWjY3TWFZVktRbVpJ?= =?utf-8?B?cXY2Wkl3c0hMQVhXbWYzQzBqTTY1NWo5QXhNczIrdENFSkFmeTJvV2J4MFd1?= =?utf-8?B?WUJJUDlwaloxQmxqZndqVlBVY3NqVzIyNzduWmE2Sm5jWTNMSmNNK3NDSUpr?= =?utf-8?B?d2k3cVAvSEVPMWhRZnh5TVhTUnVVSlIxUUNwRU50T0xqb3VtWVJXOGxpK2l3?= =?utf-8?B?WlFvVmhjYW91MDB6WGx3THR2RWFML0VrU003aHdSYk9jUVcveU84R1VvU1Vi?= =?utf-8?B?UWxnUmxidVN1SGwydUhFWlJiR014WllUN0NiUzB3c2dRUkpwZFU0MHFyN3lZ?= =?utf-8?B?YzlXaDNacnViN3d0TkFRL0RUQllMdkIwOFFobHJySXljY1IxdkJIYjVUWnNp?= =?utf-8?B?b1pLM05ldXNzUnBJOVZzZVR0OWJqNXN0Vmh1MGxtSVZwbVdGQ3JXSFl6RFhX?= =?utf-8?Q?Ba9RDbU5X5FhBHUBHTDZp0IkH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5476f786-e6e4-400a-1910-08db35d5b94a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 13:00:25.9426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wsnxvuPlJ5y0pXxlmL5hrbf0w1PGk5z8hzxFbuqt5uH3GVKJYmmD7BNUaHMmah+qmGP+JCUpx5blrR143FbaUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6897 Emulator code is large and involving it in guest operations cannot be expected to be fast anyway. Help binary size as well as, for release builds at least, compile time by building all involved code with size optimization, independent of the build being a debug or a release one. The size savings observed in a release build (with AMX and KeyLocker code in place on top of what's upstream) are above 48k of .text, with gcc 11. To keep what is being tested similar to what's in the hypervisor, apply the override to test and fuzzing harnesses as well (but affecting only the core emulator files, not any auxiliary ones). Signed-off-by: Jan Beulich --- Of course if we were to gain a Kconfig control for selecting the optimization level, the override done here may want to be controllable that way as well then. --- v3: Also apply to test and fuzzing harnesses. v2: New. --- a/tools/fuzz/x86_instruction_emulator/Makefile +++ b/tools/fuzz/x86_instruction_emulator/Makefile @@ -39,6 +39,10 @@ x86-emulate.h: x86_emulate/x86_emulate.h x86-emulate.o x86-emulate-cov.o: x86-emulate.h x86_emulate/x86_emulate.c x86_emulate/private.h fuzz-emul.o fuzz-emul-cov.o wrappers.o: x86-emulate.h +x86-emulate.o x86-emulate-cov.o: CFLAGS += -Os +$(filter x86_emulate/%.o,$(OBJS)): CFLAGS += -Os +$(patsubst %.o,%-cov.o,$(filter x86_emulate/%.o,$(OBJS))): CFLAGS += -Os + $(filter x86_emulate/%.o,$(OBJS)): x86_emulate/%.o: x86_emulate/%.c x86_emulate/private.h $(x86_emulate.h) $(CC) $(CPPFLAGS) $(CFLAGS) $(CFLAGS_$*.o) -c -o $@ $< $(APPEND_CFLAGS) --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -298,7 +298,7 @@ $(OBJS): %.o: %.c $(x86_emulate.h) $(HOSTCC) $(HOSTCFLAGS) -c -g -o $@ $< x86-emulate.o: x86_emulate/x86_emulate.c -x86-emulate.o x86_emulate/%.o: HOSTCFLAGS += -D__XEN_TOOLS__ +x86-emulate.o x86_emulate/%.o: HOSTCFLAGS += -D__XEN_TOOLS__ -Os # In order for our custom .type assembler directives to reliably land after # gcc's, we need to keep it from re-ordering top-level constructs. --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -89,6 +89,7 @@ hostprogs-y += efi/mkreloc # Allows usercopy.c to include itself $(obj)/usercopy.o: CFLAGS-y += -iquote . +$(obj)/x86_emulate.o: CFLAGS-y += -Os ifneq ($(CONFIG_HVM),y) $(obj)/x86_emulate.o: CFLAGS-y += -Wno-unused-label endif --- a/xen/arch/x86/x86_emulate/Makefile +++ b/xen/arch/x86/x86_emulate/Makefile @@ -1,3 +1,5 @@ +CFLAGS-y += -Os + obj-y += 0f01.o obj-y += 0fae.o obj-y += 0fc7.o From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:04:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518524.805171 (Exim 4.92) (envelope-from ) id 1pk2oC-0007ST-CP; Wed, 05 Apr 2023 13:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518524.805171; Wed, 05 Apr 2023 13:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2oC-0007SM-8D; Wed, 05 Apr 2023 13:04:16 +0000 Received: by outflank-mailman (input) for mailman id 518524; Wed, 05 Apr 2023 13:04:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2oA-0007SC-Dp for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:04:14 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0611.outbound.protection.outlook.com [2a01:111:f400:fe02::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c6942ab-d3b2-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 15:04:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9099.eurprd04.prod.outlook.com (2603:10a6:10:2f2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 13:04:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 13:04:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c6942ab-d3b2-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0K2nSDTWCPjyRe5K/YcvofxJxRW4cvVZ3q/yrRSUbbuJuXEfE3+mgtoKr7xphQ4IuYRsVrjj8wj4GpFDMupmwormcIdT4JYXFmLxya7791b3Q/x1stiIXnzOPjDGxmEDWJ5jP3OpJYMP/xH1Ab4xU7ymFeJma0osNeopNoPIjX7aNpWxTE6ZEpKsSQbKjuFChLxKrrle0ERe86Pr40TlPKubM1dhHPw4x/sa4mcYCmFKWsSor7IvgmJx4Ya98h0LYax/tQEdlnFzCIA5BmI8qCp601Y7b9bMeGOXZUOqBBWCHlKiCaVZ3M9jg2k7GkTAFNFIesGljSAJm3RqP8yVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TuJFnVFq4lYzErg+AcntKHgzOzemz92LMQw4cTfU8u4=; b=OKeQPRmFiUELpLtmXyUeRceSqAtltirsMpBjlppkFKlunUlD5gb8/Tqn+DoCEhnVgauyh0yQsT3nmuRsBDGX8malFYbi9cij0yvc1N5Ssp7UMN7hh7GexRSwIf1QZvdE02Wkjgn9vsvcviQw08Hm5VOQfYb2fXf3HAfbMQPEonWW6PYWueyQpI60UP71iC81XB5zhDtUAalVBfHwI8aH2FHNwooIzw6QO6d9ZTZ9eYEWb7csdWPn5aM478sR5vaeFUmTpXG/V8d1uO136h+xL4l3o43pyEdRWB9SEWX76HRarq4h4JJw0lfdH/cnJerAk51+QcRjMtXwj6/0AM0F6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TuJFnVFq4lYzErg+AcntKHgzOzemz92LMQw4cTfU8u4=; b=sc8vbdxCa+AlaKCvvmuaMFLJX1wDgkjEE4BS8c9AJRO8uh+Y7PlViptmWIZTLYizQlDUk5C05c3GDYc6xPNY/qDnz1kUTwXejtA0dyMmjaGCEIt4VldgIxy7zo6vDB9DdYaC1d8gH33grcUI8zkj2+PcbbbLtpjMazZuj2r/IoFOuGI3CRgK8WjJ0DVxJWIUcSJ/I7abhezCz6W7WIbT1/e+eVglTx/astwF9wtMFURIjBFxPT5yFVwnB6FdP7Kunrv+bSbmpmRIr0AdyWuWRiuKSUioEgwPm6ac+Ld/wwsQMWFauWl9SoeUSVO4fCH23KP+YqFl1qFKaIz34b5rbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1fceb2af-cf5e-9e70-59d5-24cbad3cb81f@suse.com> Date: Wed, 5 Apr 2023 15:04:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/2] xen: update CONFIG_DEBUG_INFO help text Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-3-jgross@suse.com> <358e9788-b930-5c51-1e89-232be43f83e5@suse.com> <563ff69f-0e9d-c90a-d18c-b3c351575716@suse.com> From: Jan Beulich In-Reply-To: <563ff69f-0e9d-c90a-d18c-b3c351575716@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9099:EE_ X-MS-Office365-Filtering-Correlation-Id: 179879b0-b9c3-419e-90d5-08db35d63e3c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hKfKDVMU20wogdw0QJfXRjMlvULPEWaEZ3neYzqk3CMTs+JF/wAlG5dYdVoSV//iGOkFlJTCYzgNXe09ig7/qTxDXb05nE+APOT/Obr6vrEewgkAD9eh4vCsNz+uFAIY3pz2I6/UusyZ+GS8oB6jnAUS7rDluudsXrjZFQHnDAppgb0Nz4FcrZjG0uMQZ1Q6FCcve9Kfe6b1T4QuVlcRb4Pd/vshuumwJThQkxyWa54JmRDAtW0JXCp934zBaPHzo1T42TUEhJyzYuxHno5paINWTldIJ4Tz6QCBSOI8mC1AQ6/EB1c5HnPR6oOyjs8M2IFamXZC/M2RDyErgYBmxmHxcQ1VnadSW6AcFojf/YIwDchVwXMyJToBfCkYFT0yyjpiXie2G4pjZM43+yICSoqFFtnA7+zTJUQ95Ji6Gr2SsuG/nYkgXGT25UFULUxEJ8WPbsYCBnjqVX9bo0frARcAWScnwdrMxPekdaSS7Hx6Ncaq8IBJAFFeKQMgVe5qz195be3CkOK5+Xuov4wI39fB0guvNhYuVx8piPJ+OZctPvXG/68VOk+9zq8t827/j3N6Xbfyf6kYp8aCbD+KzditrgNRR880jzXDHMZv3j9JbxO8HU+KkzRKKmiSD5Og0cpJUuWGMPqSXRq3+6AQeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(39860400002)(396003)(136003)(346002)(451199021)(6486002)(83380400001)(36756003)(2616005)(31696002)(86362001)(38100700002)(53546011)(6512007)(6506007)(26005)(186003)(2906002)(54906003)(6636002)(37006003)(316002)(5660300002)(31686004)(8936002)(41300700001)(66946007)(6862004)(66476007)(8676002)(4326008)(66556008)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzZyT0M0QWJiank4NTM5akErcjRiendCTjN2QXdEZ1RqeW10Q2lUYVhobVRH?= =?utf-8?B?ajlFMlp3a2lpS2FCd0JvSnBtTzVhQ214YytrNVZmWGVtWFZCQ0NHRGRnNzRx?= =?utf-8?B?N2Fnd0J3MW9NTlAyaUVlVzRZbEQreHhNNVlCalN3RE5XeVZ4aEhZU2VSQ2tB?= =?utf-8?B?MHpyWFY4andJbk1GR2U5QlBBSE54cHg2UzR5T25OZzRselpXMnlHN2YxVENO?= =?utf-8?B?NDhqd0xoYUdqaWJ2bitGYlBtYlBYTWgzOEpZSUJVdWZFU2hRWnpGUWl4TnQr?= =?utf-8?B?bHY3NFZHcG5iOHhaT1BlSkZXNG9DODh4YmpzSGl5dmtMenZlazVNdFdxSjky?= =?utf-8?B?QjZXZGhMT3B5Vjd4VkwxeGhmWVo4RHd4WFg1MDZHZjErNmxMQWtYZk5lb3Mx?= =?utf-8?B?ZmNvM3ZUZzFWMVVBM05palpUVVhmZHgvdGdwcit2VXptMXozbWpUZVd2ZGVD?= =?utf-8?B?THZSNjBHSUFqakxxRFZKdGVuQTdXQWo1RkVtQ3FLaTk2WHRkZm1WQ1ZpZUFr?= =?utf-8?B?UWt2dzFyRG4xa3NvemJQVTlza0RFUG5DVFBtQjhPNnBFSnVRQmpVV05LRmho?= =?utf-8?B?ZHgxQXlhL0NJYTA5NFhLZjdPOU1yV1lpY0Z6M25xY2ttc3BPZHFTN1U4MXZh?= =?utf-8?B?RjNoTms4NlRxa0g1U2lDZmtBa0ZUM2E1K3lPQUZteFFzeUpRS2Zrd0poWC9l?= =?utf-8?B?elF5NDRZclg5NnN1WVdvblB1VS9DL2o0OXl6a2hyZk1GVTFuRjdjQisyZnNI?= =?utf-8?B?RUhHdFhoWTVRdmFOdWxLK0xrbUlDVlh3THJtMVVuejFiTUZlYnBxT1lUS1g4?= =?utf-8?B?RXJuRk5GZzd6N1daT053UTBReTBRYTFkTmpFajRQa0Y0cXN4TTFsNG5IN1Zj?= =?utf-8?B?ZGFKWGppMFRMdzNlRFNXOUM0UWtMeXZ6SnNaTzFnRkEySWtaY0htVlJPTmRm?= =?utf-8?B?aU9yRHRLL3Ixc2FiL000NFVqVml4NzBjaFNjMUVCbGowZTRsT2VLL1BHR25u?= =?utf-8?B?L1VISVZGV3RXQ0plK3AzekpyRDRTeStWUmFXdUQwOVZGdXJFVTZPZUJ1R2xu?= =?utf-8?B?U003ZG1BaVdxRzVZSmI1TlNsclpiZXQ4amw3ei9xb3VuNTQ0RmowbURoZTZU?= =?utf-8?B?dVpFZElIbXoycW84VE9rZGQ4cHh2UUFTbnhpQ2RSZXJTZDMwS1VwcG9aNDNT?= =?utf-8?B?WHFwSmxybXk1bVJtWld6NnVQUjFWWGM1bmU5a09qbjh0NjF3bXg4QnB0T2Fn?= =?utf-8?B?ckRKUnkrYUhtS1dlQmlOOER1aDJxR0FxKzdKeklxemhZN3c2aE5UbVdPbFlD?= =?utf-8?B?M1pjOUNJNnhHT2FLK0JWQ3hmWi9QQmpwMmVnWVc4UWhkdjM4ZXNxNCs3VVVl?= =?utf-8?B?THk2SVVKeFltQ3h6S1dTdmNSWEpTM2hIdXlacmdNYzBmTEZqTWU4YVFJVkVy?= =?utf-8?B?czJmSkx1bzlmQ2JXeVphL1J2VXU5T2VHWHhqVzV3MWFmZ2phRWE0NDNraVRt?= =?utf-8?B?ejA2QWtWZFUrRFhYVW0yNlhSRy9HeTZSUFY0QzJtT2pHN1NZR2hkUDJhaUUz?= =?utf-8?B?MW9jODA2U2JOMUVLU2doV2NUL0pxOFoxTjVZSGNxUExKTU1UQmtYejlITVJR?= =?utf-8?B?aE9DOUNWWXJwWCtNejg0bWRYd1d6N2tOYlowSGtVY2MxY2VSR2UvVXEzUlhL?= =?utf-8?B?azBmTVNZSlRvT05TWFJvRmFHVndCTXNoN0VHYTQ2THFVT2EwRkFQQnZXVU16?= =?utf-8?B?b2ViME94Vzc5RnVmQmYyQ2Nza1ZvcGpiSlhxOStRTFd5SHlCTnYxakc4OHBX?= =?utf-8?B?Q2FDbDFBdVdqYnh5UWpCam1FenkraXR5RENwNGZKQm1SR0ZFVVBselBVQlJs?= =?utf-8?B?TnlXS0JTYjZsVnExMXlLblpUbXhmS0VhenhuQWtOR0FkQkI3SHJNK09qdkNG?= =?utf-8?B?R054dGxRREppWW9pQXlKNVRBNSsvdEpQcXVNTFN4eU8yeVE1eE1JZWQvczhI?= =?utf-8?B?N04zbDRtSkJZclV0dEk3WGczRzRhS1o5YVE0djJmdHlTcHhVNTNuVUxDS3Bp?= =?utf-8?B?bzdFL1JYRTNCeG1wSlRpV3l2YThXVzZFWktKYTZjU1hldUJrQ2NPSUJ6QWtB?= =?utf-8?Q?gtPIRz8eZ95Qo7IWIQSZvXlNq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 179879b0-b9c3-419e-90d5-08db35d63e3c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 13:04:08.8407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WVMpSXEJ9nO/8PvduEgP3HQOQP6p38FPncw9nweg8QY7ZQtsp7H+BlrYvKY2ilVsiVjOGUXAMEifXsQCzPcMeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9099 On 05.04.2023 13:24, Juergen Gross wrote: > On 04.04.23 11:09, Jan Beulich wrote: >> On 03.04.2023 18:28, Juergen Gross wrote: >>> --- a/xen/Kconfig.debug >>> +++ b/xen/Kconfig.debug >>> @@ -15,8 +15,14 @@ config DEBUG_INFO >>> bool "Compile Xen with debug info" >>> default DEBUG >>> help >>> - If you say Y here the resulting Xen will include debugging info >>> - resulting in a larger binary image. >>> + Say Y here if you want to build Xen with debug information. This >>> + information is needed e.g. for doing crash dump analysis of the >>> + hypervisor via the "crash" tool. >>> + Saying Y will increase the size of the xen-syms and xen.efi >>> + binaries. In case the space on the EFI boot partition is rather >>> + limited, you may want to make use of the INSTALL_EFI_STRIP make >>> + variable when building the hypervisor, in order to strip xen.efi >>> + before installing it to the EFI partition. >> >> Hmm, INSTALL_EFI_STRIP is only a courtesy to developers wanting to install >> xen.efi directly into the EFI partition. It wouldn't affect the normal >> flow, and hence I think this wants expressing here such that both kinds of >> people have at least a hint what they need to do. I.e. in the normal case >> they'd need to adjust the way xen.efi is "propagated" from its installed >> location onto the EFI partition, to do the desired stripping at that time. > > Would you be fine with: > > In case the space on the EFI boot partition is rather > limited, you may want to install a stripped variant of xen.efi in > the EFI boot partition (look for "INSTALL_EFI_STRIP" in > docs/misc/efi.pandoc for more information - when not using > "make install-xen" for installing xen.efi, stripping needs to be > done outside the Xen build environment). SGTM, thanks. Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:15:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:15:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518529.805180 (Exim 4.92) (envelope-from ) id 1pk2yR-00010S-CQ; Wed, 05 Apr 2023 13:14:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518529.805180; Wed, 05 Apr 2023 13:14:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2yR-00010L-9s; Wed, 05 Apr 2023 13:14:51 +0000 Received: by outflank-mailman (input) for mailman id 518529; Wed, 05 Apr 2023 13:14:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk2yQ-00010B-43 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:14:50 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0620.outbound.protection.outlook.com [2a01:111:f400:fe1e::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7716a81-d3b3-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 15:14:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9523.eurprd04.prod.outlook.com (2603:10a6:10:2f6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.28; Wed, 5 Apr 2023 13:14:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 13:14:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7716a81-d3b3-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IK0ByPSu7cNyDE/ZVGvNyUdr4GKHcAVgFKC7pvcaUX9ep5AquFUp/rqOp6dkfsrMr2RYl9Ai++xARhi2nJZ9xk2qvvWw0Vh6tNCeUyziYtmuLUIfYBTWBDTeb3QiCwuoSvThqN9WftfsOS6nEIi57y1z6fy7un8NbEjIWs+qhTAUTtCLCAJyHo3JvGS4XzX8VsXpVPb9eOEIWB7ekKuBwd8wOuXAWZod2nSqbvwkbUrBaaEtdeqgcASHNqrR7PaJAjh2eLMN7gRTcIuypVHe/XaCepRJBsKmuL6xER3qjqmxq5+O75XkA/7uaOH8x0Cz2+ZFAFqKWrodKjf5hIgJFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=imZI6b+yoZSV7HogzUtbHcB4pG1nP8AqkDs/5EMUxAk=; b=dcC8xVBO0KqmilzM+Z8Bvon7nZJwa+eGflSvnn49mg66W4nAKQdRiZATv5YNeHSZvRatDcFbr/qsGBHzFLgzt4eHm+qwW22AzCZQf4f1djYlaDEo2kgfoWzuOp10WpWdMfvrdroqpuc4lSczC7bi+IYb/y8sof6wxpjUB3vCICJmkHn8NDLkGoo22mEubQ/BG+U7yTTtvnzosNtVOD3pOntpot0ZJwUrucX0FDvGMOgAEIqWW2FjosdoGaOVCDxPIq3tndxx4hgaiOfer4CSKvtaY8TOmBZ7jcWzWJM5wKj8JRVphvoSEDOdoOYHM7K8HhiyWve1LWRmnbeDoh+gjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=imZI6b+yoZSV7HogzUtbHcB4pG1nP8AqkDs/5EMUxAk=; b=h1dfp0fOI5TFWwfT75I7xEa0C4Mk83+RgYWi1nwTTSYK46DCFSre/seNXzCE+a221dDV6jwVnF2PhU0oXEBYY/4aY8llcytibb1xUiM2cki4ja3jkBvcMeVW0QrccOfEh7CDbDI0hDjAd2lX9OJhR2mqh/AcuDYUuSeY/exYD2fmxi7UE9Mer5cWT/MBnXawBf+aekZZ7lTJzMscFpSv3LvOqu1S5BkUy+LMpyUjEKvTs75cXAzre43S0KAD2B61o2mDwHAc28m/Kjnefz+GsKHPvKWRl7EHxGvp4aN1GmEBSD8s+8ozz3IL5F4VKDMNwjG5IOylejjfK2t4YJ2OmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 5 Apr 2023 15:14:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-2-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230403162823.30681-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0058.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9523:EE_ X-MS-Office365-Filtering-Correlation-Id: d32427e7-e4ea-4a32-c77e-08db35d7b9be X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b7Gzme0Y2q+/k4HydgpoyBzp9nf/NdugyddVAdefsyYR63o0ZyuF7aAbolQ8iC8kAgNuoGFhVeoVPRu+gCQrXIfIOjwoEwoIwsz/wj/5FQ3MJ+W0FLsWmDXTBDnWV2Qx7+b4kFtp0+yu0OQioWQLeM4YrY5h4bROoT/0fbc4oepF06pBVWio2zWMcOWUs2b2aSkaje0Kuj+KZ3HOytKAzelD1cxlySLWT2J62ms2/0lM8iqmumWIezXxeFF6FmVx8HDAUmoU2pAOSIwyGIfWLQURnvoSkSDS5YAezlooc17AGwdTpWRRhNcXL8W3/4WSxjdOnNG6gDa/w4IthEhdX/7Ys+OWYEENVKapOOpyfKnnPkvMQAzL2uc/Ywa0i4MlnkpqWrRK7BdQiyBICDiG1zkIGnJKKoGmolJpcNRQUSaRkoWM2saHxNzOtvlVOpYkC7o9pA26x1w3Z3GleXnPOsFksNb7so3BvBKtzjnReMu+TPF51d0L5rpbNqIG5yDWkmz5gdkzxEk6ZfnHocIpHBxDYu4tswTfycOSZ2WW5q/ynZuhTs+wwidYEnMZOZfUWDmDhWdk1yKHyT1jGS48JisLm1TNb+UuFS1p5sWqfFhlEqjXTN9pdfwaDpHoG8XZqYZoJbt3SzVN/HNBVtXrLw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199021)(31696002)(2906002)(36756003)(66899021)(86362001)(31686004)(83380400001)(2616005)(186003)(53546011)(6666004)(6486002)(6512007)(26005)(66476007)(5660300002)(478600001)(66556008)(6506007)(66946007)(54906003)(38100700002)(8676002)(41300700001)(316002)(8936002)(6636002)(4326008)(6862004)(37006003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTRDY21EWjlYRFQzSnFwYmM1TVBRa0RrV1Z6S2RvK3FKUnN4ajVPZzFGeUhz?= =?utf-8?B?ZVpsT1ZZdUluRCtTZUEwU1ZIakczbWZJN1lVZFEzeFpaQjd5VmNxRklMUGV5?= =?utf-8?B?KzA3aFF1S2tGK3N6ZWFJUDdJTGJtbGJMK0tMMi8zSlc1VXZsVHBIWHVLOHlC?= =?utf-8?B?VmJPMjNJdmcybWExeGozZ0NrbHJVNm1GV1J3Um9DNGh0clA3WVF3RnM4TVpQ?= =?utf-8?B?OXMvdWFnQTR3OVcvSHcvTmlwSGJxMVhsK21URk1DUWtpbk5mK1ArSnNjMXhN?= =?utf-8?B?T1lnMVFlVVJMU0Zma3VqN2pja29JdE0rZW1wSmovQ2JVR29sTHErNU91SFA2?= =?utf-8?B?ZHJzUzJvanF5R1orS1k5Sm1Wcy9SVHN3eG5nVUFDdmRGT3prM0c1Z1R1ZklC?= =?utf-8?B?SFkzWHpkbmdzOXNWbHJXd0J2c2MyQldLR3JVTVBUYVNxOWlIR285a3h0Skhj?= =?utf-8?B?WFFQRzdheGNWNGdjQllweEJscXluSlNlL2NGZWtTOFhpblBDcmpKWHdHYTRO?= =?utf-8?B?cFE2anBzSy9nTGprVUtpT1F2U0ZCR0owWnd3aTl4V1NGWksweitxVWlDYWtB?= =?utf-8?B?bk55aGVCaW55UWJiN3pvVG9mbkxsN2ZFWEg1akpaYzhYbnl2RTlNV284Mlkz?= =?utf-8?B?MVAyM1BGalgyQkdrRTRDNkxpVnZ0d25CQlBWZkdTNmhlcTgyTWdaL0RDekZy?= =?utf-8?B?QjB4QWpZMHc3WTd5c3lrYW5xMUs3QUhYdnRGWm95WmkwM3N5bnl4eldNcW05?= =?utf-8?B?SDN3ZnlZa002azgydHRQQkJ5c2F2RWxZK1J4eEpBUUVFUEF5eGdtZDRaci9h?= =?utf-8?B?Sm1NZm15K01Tc0tmeVlLUDl0SEVzMDlxWmZnNGN1YzN5WHlYNFg1SzR4ajd1?= =?utf-8?B?a0xINVBDd2cyTS9kVGhSTUMyOWNtcHhzVFFic3d6Mnp5NXBWSGJLNW9jOUox?= =?utf-8?B?blRLRmZGOVNSYmUwYzhhQXpxaUFmQ2Z2RE9kTWQ4ODFnK1ZIbWRiazcrYU5t?= =?utf-8?B?TlFqVWNsNFMyOVdHRVlWWnVuNVR6UjFsUUVGQzZFK0ZwOWpSOHNkSWhmU1hz?= =?utf-8?B?ZVdtNG1jd1YzY3gyMWpSSkh4WVpCN2RPNVJsOXQzMTI2VDdCcE9nbG5xcVF4?= =?utf-8?B?c0pJM2V0dVhMa0I4NFVFcWR6R0pBNWtENTBFU2ErTUthcVprRkdXRXJLU1pz?= =?utf-8?B?cnBlNm1RWU83emdqMjNTYWtDYnZBV2dmMnJybmxyUXhWWUpnbExyVnByUXBI?= =?utf-8?B?dW40Snh0ZXN0aG5DR0ZlK1hXaGxHVVliUTA5R1hhVzN3TlJ6d3p3bVBuUzJv?= =?utf-8?B?N2xmbjJTd3QzQ0c1UTBGcUJ2UExIV09pQjQyU0kwQmZwaTRUQzRMMXJiZnAz?= =?utf-8?B?YzZZVENUQWVZcFF5KzVZQUhxS0QwSHVhV3FvOVdWVUlnaU5ENFBGUURBTGpM?= =?utf-8?B?d1lQa0d0alNaQUtiOCtDNXhnd2djQTFldTlpZG5adkMxZmZhS3pyWXRXS2Zj?= =?utf-8?B?VGltNkg1Q1RTNm1LZnVJcWJON2wxN0syZ3lWV2w1YWQyU1BBMU5XRDBJZ0Rs?= =?utf-8?B?bkFoenpFdzlKTStEb1VZbklQZWVoOUVnVnNTOFhMdWwzeHlXcENEWTVXeG9o?= =?utf-8?B?UGU2TkNtVGJpRHBUMVJSOXlsenM5QStPeHFkSnhUUWFFM0dxWnp0TTRZYm81?= =?utf-8?B?bnlPZE9tR25pVmR5eFY1Y0toMXNOaDBIclVPdlFSSUdhODRqOWxuQ1k5K2Jr?= =?utf-8?B?b2hDQjBKdHVEUkg4d1UvZjFSd0RJZzlHZ0g5VFVSRWRROGpreGppZUoxNGdX?= =?utf-8?B?S1AybFJUYk9VZkhOa2dvTTB1cDB4emFPUzZGMDgxRGxOeGJZYVJ1YVNJVFFR?= =?utf-8?B?QjBYMThmdDM1Yi82U055MzlYeW5wTFJFMnB5UVVCcFRmb0s2SWgyTWlqckxK?= =?utf-8?B?dDhaRDl3c0RkTHZyZS85WkRhZCtLb3VoUm1wSHQ0ZnVsNy9Cb0luTmFOSVpX?= =?utf-8?B?V1QvL3dQL3h5U3RPZUhSOSthVDBnMGR1RFNjdUVFY3RlR1dCUm5KME03elVn?= =?utf-8?B?Z0FNL2twQ2pnL2F3bExXU1JXZ3NWS2ZKNDJqaUJPOXVpWnFUUGR0bkxFWElY?= =?utf-8?Q?EbKkHHvE+kjB60bwUfd4AxpXq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d32427e7-e4ea-4a32-c77e-08db35d7b9be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 13:14:45.7355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wf4DR2jPDU/1CE7EpBhl7kdY7sPLdAAdijKAGh2pKuduZGocX39wxDBBujfsHCuvfiTIgaAnP820S3wUQvpedQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9523 On 03.04.2023 18:28, Juergen Gross wrote: > In order to support hypervisor analysis of crash dumps, xen-syms needs > to contain debug_info. It should be allowed to configure the hypervisor > to be built with CONFIG_DEBUG_INFO in non-debug builds without having > to enable EXPERT. > > Using a rather oldish gcc (7.5) it was verified that code generation > doesn't really differ between CONFIG_DEBUG_INFO on or off without > CONFIG_DEBUG being set (only observed differences were slightly > different symbol addresses, verified via "objdump -d", resulting from > the different config.gz in the binary). The old gcc version selection > was based on the assumption, that newer gcc won't regress in this > regard. > > So move CONFIG_DEBUG_INFO out of the section guarded by EXPERT. > > It should be mentioned that there have been reports that the linking > of the xen.efi might take considerably longer with CONFIG_DEBUG_INFO > selected when using newer binutils. Thinking of it: Because of the need to deal with older binutils, we already force --strip-debug as a linking option for xen.efi in certain cases. Perhaps we could make another (x86-only) Kconfig control which allows to force this mode even with recent binutils? If so, would you be willing to include this right here, or should I take care of this afterwards (or maybe even in parallel)? > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -11,6 +11,13 @@ config DEBUG > > You probably want to say 'N' here. > > +config DEBUG_INFO > + bool "Compile Xen with debug info" > + default DEBUG > + help > + If you say Y here the resulting Xen will include debugging info > + resulting in a larger binary image. > + > if DEBUG || EXPERT Just to repeat my v1 comment (to which your response was "Fine with me"): The new placement isn't very helpful when considering some of the ways kconfig data is presented. At least for the non-graphical presentation it used to be the case that hierarchies were presented properly only when dependencies immediately followed their dependents (i.e. here: DEBUG is a dependent of everything inside the "if" above). Therefore I think rather than moving the block up you may better move it down past the "endif". Jan From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:44:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518534.805191 (Exim 4.92) (envelope-from ) id 1pk3RO-0005jv-J2; Wed, 05 Apr 2023 13:44:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518534.805191; Wed, 05 Apr 2023 13:44:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3RO-0005jo-GI; Wed, 05 Apr 2023 13:44:46 +0000 Received: by outflank-mailman (input) for mailman id 518534; Wed, 05 Apr 2023 13:44:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3RN-0005jZ-LD for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:44:45 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03e8fd71-d3b8-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:44:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CDDF120634; Wed, 5 Apr 2023 13:44:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F42513A31; Wed, 5 Apr 2023 13:44:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IZ/fIEh7LWQtcgAAMHmgww (envelope-from ); Wed, 05 Apr 2023 13:44:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03e8fd71-d3b8-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680702280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PFghx5Gd1bMgaOBQLPmS7nHyfVl84PcJEn2YPi2RhpU=; b=Vug5EE6ZVVNV7Z32SW5o6BNOux/v7tRNnACieTv+QSNgiNpLfnVqj1CVABqe4UnrXimQ4x RE5zvMSy9iczPPOfuwlDRT74l3rWhcgyJ9Ql+oPBD6Ojk8LWSYPT6emuR8ZLzkTpk1Z+im ihRQv4KY+yRXK3LssiJT73gaNG+t3eM= Message-ID: <718c7a92-b3ca-8fb3-e698-5e01464258c3@suse.com> Date: Wed, 5 Apr 2023 15:44:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-2-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------o00O0sD67mTCNvhlEJMiCJzA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------o00O0sD67mTCNvhlEJMiCJzA Content-Type: multipart/mixed; boundary="------------U1KZpPbs6bUVrEt0X0kQ5wrL"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <718c7a92-b3ca-8fb3-e698-5e01464258c3@suse.com> Subject: Re: [PATCH v2 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section References: <20230403162823.30681-1-jgross@suse.com> <20230403162823.30681-2-jgross@suse.com> In-Reply-To: --------------U1KZpPbs6bUVrEt0X0kQ5wrL Content-Type: multipart/mixed; boundary="------------ZU19NvmbvRm5zir8Zt0wfHpu" --------------ZU19NvmbvRm5zir8Zt0wfHpu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDQuMjMgMTU6MTQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMy4wNC4yMDIz IDE4OjI4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gSW4gb3JkZXIgdG8gc3VwcG9ydCBo eXBlcnZpc29yIGFuYWx5c2lzIG9mIGNyYXNoIGR1bXBzLCB4ZW4tc3ltcyBuZWVkcw0KPj4g dG8gY29udGFpbiBkZWJ1Z19pbmZvLiBJdCBzaG91bGQgYmUgYWxsb3dlZCB0byBjb25maWd1 cmUgdGhlIGh5cGVydmlzb3INCj4+IHRvIGJlIGJ1aWx0IHdpdGggQ09ORklHX0RFQlVHX0lO Rk8gaW4gbm9uLWRlYnVnIGJ1aWxkcyB3aXRob3V0IGhhdmluZw0KPj4gdG8gZW5hYmxlIEVY UEVSVC4NCj4+DQo+PiBVc2luZyBhIHJhdGhlciBvbGRpc2ggZ2NjICg3LjUpIGl0IHdhcyB2 ZXJpZmllZCB0aGF0IGNvZGUgZ2VuZXJhdGlvbg0KPj4gZG9lc24ndCByZWFsbHkgZGlmZmVy IGJldHdlZW4gQ09ORklHX0RFQlVHX0lORk8gb24gb3Igb2ZmIHdpdGhvdXQNCj4+IENPTkZJ R19ERUJVRyBiZWluZyBzZXQgKG9ubHkgb2JzZXJ2ZWQgZGlmZmVyZW5jZXMgd2VyZSBzbGln aHRseQ0KPj4gZGlmZmVyZW50IHN5bWJvbCBhZGRyZXNzZXMsIHZlcmlmaWVkIHZpYSAib2Jq ZHVtcCAtZCIsIHJlc3VsdGluZyBmcm9tDQo+PiB0aGUgZGlmZmVyZW50IGNvbmZpZy5neiBp biB0aGUgYmluYXJ5KS4gVGhlIG9sZCBnY2MgdmVyc2lvbiBzZWxlY3Rpb24NCj4+IHdhcyBi YXNlZCBvbiB0aGUgYXNzdW1wdGlvbiwgdGhhdCBuZXdlciBnY2Mgd29uJ3QgcmVncmVzcyBp biB0aGlzDQo+PiByZWdhcmQuDQo+Pg0KPj4gU28gbW92ZSBDT05GSUdfREVCVUdfSU5GTyBv dXQgb2YgdGhlIHNlY3Rpb24gZ3VhcmRlZCBieSBFWFBFUlQuDQo+Pg0KPj4gSXQgc2hvdWxk IGJlIG1lbnRpb25lZCB0aGF0IHRoZXJlIGhhdmUgYmVlbiByZXBvcnRzIHRoYXQgdGhlIGxp bmtpbmcNCj4+IG9mIHRoZSB4ZW4uZWZpIG1pZ2h0IHRha2UgY29uc2lkZXJhYmx5IGxvbmdl ciB3aXRoIENPTkZJR19ERUJVR19JTkZPDQo+PiBzZWxlY3RlZCB3aGVuIHVzaW5nIG5ld2Vy IGJpbnV0aWxzLg0KPiANCj4gVGhpbmtpbmcgb2YgaXQ6IEJlY2F1c2Ugb2YgdGhlIG5lZWQg dG8gZGVhbCB3aXRoIG9sZGVyIGJpbnV0aWxzLCB3ZQ0KPiBhbHJlYWR5IGZvcmNlIC0tc3Ry aXAtZGVidWcgYXMgYSBsaW5raW5nIG9wdGlvbiBmb3IgeGVuLmVmaSBpbg0KPiBjZXJ0YWlu IGNhc2VzLiBQZXJoYXBzIHdlIGNvdWxkIG1ha2UgYW5vdGhlciAoeDg2LW9ubHkpIEtjb25m aWcNCj4gY29udHJvbCB3aGljaCBhbGxvd3MgdG8gZm9yY2UgdGhpcyBtb2RlIGV2ZW4gd2l0 aCByZWNlbnQgYmludXRpbHM/DQo+IElmIHNvLCB3b3VsZCB5b3UgYmUgd2lsbGluZyB0byBp bmNsdWRlIHRoaXMgcmlnaHQgaGVyZSwgb3Igc2hvdWxkIEkNCj4gdGFrZSBjYXJlIG9mIHRo aXMgYWZ0ZXJ3YXJkcyAob3IgbWF5YmUgZXZlbiBpbiBwYXJhbGxlbCk/DQoNCkknbSBwbGFu bmluZyB0byBkbyB0aGUgRUZJIHNpZGUgaW4gdGhlIG5leHQgZGF5cywgaG9waW5nIHRoYXQg SSBjYW4gc2V0dXANCnRoZSB0ZXN0IHN5c3RlbS4NCg0KSSdkIGluY2x1ZGUgdGhhdCBhZGRp dGlvbmFsIGNvbmZpZyBvcHRpb24gaW4gdGhlIHByb2JhYmx5IG5lZWRlZCBwYXRjaChlcykN CnRoZW4gKGNyYXNoIGlzbid0IGhhcHB5IHdpdGggeGVuLmVmaSBhbnl3YXksIHNvIEknbGwg bmVlZCBzb21lIGtpbmQgb2YNCnhlbi1zeW1zLmVmaSBvciB3aGF0ZXZlciB5b3Ugd2FudCB0 byBjYWxsIGl0KS4NCg0KPiANCj4+IC0tLSBhL3hlbi9LY29uZmlnLmRlYnVnDQo+PiArKysg Yi94ZW4vS2NvbmZpZy5kZWJ1Zw0KPj4gQEAgLTExLDYgKzExLDEzIEBAIGNvbmZpZyBERUJV Rw0KPj4gICANCj4+ICAgCSAgWW91IHByb2JhYmx5IHdhbnQgdG8gc2F5ICdOJyBoZXJlLg0K Pj4gICANCj4+ICtjb25maWcgREVCVUdfSU5GTw0KPj4gKwlib29sICJDb21waWxlIFhlbiB3 aXRoIGRlYnVnIGluZm8iDQo+PiArCWRlZmF1bHQgREVCVUcNCj4+ICsJaGVscA0KPj4gKwkg IElmIHlvdSBzYXkgWSBoZXJlIHRoZSByZXN1bHRpbmcgWGVuIHdpbGwgaW5jbHVkZSBkZWJ1 Z2dpbmcgaW5mbw0KPj4gKwkgIHJlc3VsdGluZyBpbiBhIGxhcmdlciBiaW5hcnkgaW1hZ2Uu DQo+PiArDQo+PiAgIGlmIERFQlVHIHx8IEVYUEVSVA0KPiANCj4gSnVzdCB0byByZXBlYXQg bXkgdjEgY29tbWVudCAodG8gd2hpY2ggeW91ciByZXNwb25zZSB3YXMgIkZpbmUgd2l0aCBt ZSIpOg0KPiANCj4gVGhlIG5ldyBwbGFjZW1lbnQgaXNuJ3QgdmVyeSBoZWxwZnVsIHdoZW4g Y29uc2lkZXJpbmcgc29tZSBvZiB0aGUgd2F5cw0KPiBrY29uZmlnIGRhdGEgaXMgcHJlc2Vu dGVkLiBBdCBsZWFzdCBmb3IgdGhlIG5vbi1ncmFwaGljYWwgcHJlc2VudGF0aW9uDQo+IGl0 IHVzZWQgdG8gYmUgdGhlIGNhc2UgdGhhdCBoaWVyYXJjaGllcyB3ZXJlIHByZXNlbnRlZCBw cm9wZXJseSBvbmx5DQo+IHdoZW4gZGVwZW5kZW5jaWVzIGltbWVkaWF0ZWx5IGZvbGxvd2Vk IHRoZWlyIGRlcGVuZGVudHMgKGkuZS4gaGVyZToNCj4gREVCVUcgaXMgYSBkZXBlbmRlbnQg b2YgZXZlcnl0aGluZyBpbnNpZGUgdGhlICJpZiIgYWJvdmUpLiBUaGVyZWZvcmUgSQ0KPiB0 aGluayByYXRoZXIgdGhhbiBtb3ZpbmcgdGhlIGJsb2NrIHVwIHlvdSBtYXkgYmV0dGVyIG1v dmUgaXQgZG93biBwYXN0DQo+IHRoZSAiZW5kaWYiLg0KDQpPaCwgSSBzZWVtIHRvIGhhdmUg bWlzc2VkIHRoYXQgbGFzdCBwYXJhZ3JhcGggd2hlbiBnb2luZyB0aHJvdWdoIHRoZSB0aHJl YWQuDQoNCldpbGwgY29ycmVjdCBpdC4NCg0KDQpKdWVyZ2VuDQoNCg== --------------ZU19NvmbvRm5zir8Zt0wfHpu Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ZU19NvmbvRm5zir8Zt0wfHpu-- --------------U1KZpPbs6bUVrEt0X0kQ5wrL-- --------------o00O0sD67mTCNvhlEJMiCJzA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmQte0gFAwAAAAAACgkQsN6d1ii/Ey8r Kwf+KZyGG/vV4YsXnS/k3jLP3WZ7QBavZ1Y1KmL0eqAvSM3+fgHfX2wjqTjptCWSsVlBsQRpz03o 7QNDBlkJBUClhv3TmzB8g4htgQuZEMFTTOVXi7xwuwctB/VnklJ5BN9gnvLQv2sk7984L2OdrlBl H9rWyLt7RBAyNNLil46PFyHoJonrRzAejQYgLDxA3NqHW21VPfNNfYWQUr1vNbEi4VOVBysKN2xE 9FCUaILN9pgKRSABkiZvlPo1StusNDCEONMlVz8wV2rFlx+W8FMonwUleJQgo6bFikL8l0ALZlRC qJ7MemkhxLdcvqY3YLwJD0FqwWcvYRze7bd8+5JkNQ== =T3r3 -----END PGP SIGNATURE----- --------------o00O0sD67mTCNvhlEJMiCJzA-- From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:56:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:56:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518539.805204 (Exim 4.92) (envelope-from ) id 1pk3cp-0007mZ-NS; Wed, 05 Apr 2023 13:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518539.805204; Wed, 05 Apr 2023 13:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cp-0007mS-Jm; Wed, 05 Apr 2023 13:56:35 +0000 Received: by outflank-mailman (input) for mailman id 518539; Wed, 05 Apr 2023 13:56:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cn-0007mI-UL for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:56:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab7fbc7e-d3b9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:56:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8C40020634; Wed, 5 Apr 2023 13:56:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4458F13A31; Wed, 5 Apr 2023 13:56:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9Rt9Dw9+LWTBeAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 13:56:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab7fbc7e-d3b9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680702991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=w87xtmd4g8BodHHbXoQ5bocxqFz/xo9ToPYB7CD8LlI=; b=XdlbCOExTZNMyIrlim6vD7Csa7IUMhkoLmDalpEf8/FwjTYBQYzpUOkBdm3meJ11MPxhK2 jlKp0mUhfkAs8fcQKkiNIw9ZBRS+7G1PI61pbQWaFtkKAjY/4U73pO7CN9HAbUvPh9LF1r VnlGjjS5PF3JtSrxJWb4JLhfUdbQxEw= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 0/2] xen: some CONFIG_DEBUG_INFO changes Date: Wed, 5 Apr 2023 15:56:27 +0200 Message-Id: <20230405135629.21829-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enabling crash dump analysis of the hypervisor requires the hypervisor having been built with CONFIG_DEBUG_INFO enabled. Today this requires either CONFIG_DEBUG or CONFIG_EXPERT set, which are both not security supported. This small series changes that in order to allow security supported Xen builds with the capability to do crash dump analysis via the "crash" tool. Note that due to problems with test machines proper support for EFI booted systems hasn't been verified, so this will likely need some more work. Changes in V2: - comments addressed Changes in V3: - comments addressed Juergen Gross (2): xen: move CONFIG_DEBUG_INFO out of EXPERT section xen: update CONFIG_DEBUG_INFO help text xen/Kconfig.debug | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:56:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:56:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518540.805214 (Exim 4.92) (envelope-from ) id 1pk3cu-00082a-Tw; Wed, 05 Apr 2023 13:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518540.805214; Wed, 05 Apr 2023 13:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cu-00082P-Qq; Wed, 05 Apr 2023 13:56:40 +0000 Received: by outflank-mailman (input) for mailman id 518540; Wed, 05 Apr 2023 13:56:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cs-0007mI-TH for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:56:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aebb4c0b-d3b9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:56:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2780F20634; Wed, 5 Apr 2023 13:56:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0A4213A31; Wed, 5 Apr 2023 13:56:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cCeONRR+LWTSeAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 13:56:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aebb4c0b-d3b9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680702997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJpVodEY5mLUPTwqhB6PQxZ33ssAbKfS1kQ6CEUaSKQ=; b=ICMD0WG228KSxZpnbPT9WhTr77YIy+K2/4tIt2/1rxBAm33MSOIT5lZcnBXbdPAo165omS tibC4ydjOIu/4lEN2EmBEmqKafzYNwZ7irgtWCTYjikvA7EkRQlcS64l+jI9hR2k5+WNdS Xb7SGc9jYF1y4cFySy5JbUiOwPpTPmA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section Date: Wed, 5 Apr 2023 15:56:28 +0200 Message-Id: <20230405135629.21829-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405135629.21829-1-jgross@suse.com> References: <20230405135629.21829-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to support hypervisor analysis of crash dumps, xen-syms needs to contain debug_info. It should be allowed to configure the hypervisor to be built with CONFIG_DEBUG_INFO in non-debug builds without having to enable EXPERT. Using a rather oldish gcc (7.5) it was verified that code generation doesn't really differ between CONFIG_DEBUG_INFO on or off without CONFIG_DEBUG being set (only observed differences were slightly different symbol addresses, verified via "objdump -d", resulting from the different config.gz in the binary). The old gcc version selection was based on the assumption, that newer gcc won't regress in this regard. So move CONFIG_DEBUG_INFO out of the section guarded by EXPERT. It should be mentioned that there have been reports that the linking of the xen.efi might take considerably longer with CONFIG_DEBUG_INFO selected when using newer binutils. Signed-off-by: Juergen Gross --- V2: - expanded commit message (Jan Beulich) V3: - move DEBUG_INFO block to the end of the file (Jan Beulich) --- xen/Kconfig.debug | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index fad3050d4f..279dbe8274 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -28,13 +28,6 @@ config GDBSX If you want to enable support for debugging guests from dom0 via gdbsx then say Y. -config DEBUG_INFO - bool "Compile Xen with debug info" - default y - ---help--- - If you say Y here the resulting Xen will include debugging info - resulting in a larger binary image. - config FRAME_POINTER bool "Compile Xen with frame pointers" default DEBUG @@ -132,4 +125,11 @@ source "arch/$(SRCARCH)/Kconfig.debug" endif # DEBUG || EXPERT +config DEBUG_INFO + bool "Compile Xen with debug info" + default DEBUG + help + If you say Y here the resulting Xen will include debugging info + resulting in a larger binary image. + endmenu -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:56:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:56:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518541.805224 (Exim 4.92) (envelope-from ) id 1pk3cz-0008KX-86; Wed, 05 Apr 2023 13:56:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518541.805224; Wed, 05 Apr 2023 13:56:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cz-0008KQ-4o; Wed, 05 Apr 2023 13:56:45 +0000 Received: by outflank-mailman (input) for mailman id 518541; Wed, 05 Apr 2023 13:56:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cy-0007mI-Kd for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:56:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b21a5398-d3b9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:56:43 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C81BD20634; Wed, 5 Apr 2023 13:56:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8864513A31; Wed, 5 Apr 2023 13:56:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aZsHIBp+LWTeeAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 13:56:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b21a5398-d3b9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680703002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7E8xLpIHHyBj6gOvbHVGHsCDEUl39NE+WedwK4I/34=; b=MxDaNNi+YFuqUHP7aB796xrZ4HmTYr/kmjo7qmjvN1Tpga2ne9dHvL83hwTuBHGVdDsq/w OEPIkmzi/YgnHxOG9TOPMcAeoa923Ia58r3Y3uMV0P71qbeBjCsURWOcMwHXTz9XNH3A8X xW0xz7fVyw2rQyr01HbJ/MM/MfsnOFI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 2/2] xen: update CONFIG_DEBUG_INFO help text Date: Wed, 5 Apr 2023 15:56:29 +0200 Message-Id: <20230405135629.21829-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405135629.21829-1-jgross@suse.com> References: <20230405135629.21829-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Update the help text of the CONFIG_DEBUG_INFO option to be a little bit more specific. Signed-off-by: Juergen Gross --- V2: - expand help text, especially mentioning INSTALL_EFI_STRIP (Jan Beulich) V3: - expand help text even more (Jan Beulich) --- xen/Kconfig.debug | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 279dbe8274..94e818ee09 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -129,7 +129,15 @@ config DEBUG_INFO bool "Compile Xen with debug info" default DEBUG help - If you say Y here the resulting Xen will include debugging info - resulting in a larger binary image. + Say Y here if you want to build Xen with debug information. This + information is needed e.g. for doing crash dump analysis of the + hypervisor via the "crash" tool. + Saying Y will increase the size of the xen-syms and xen.efi + binaries. In case the space on the EFI boot partition is rather + limited, you may want to install a stripped variant of xen.efi in + the EFI boot partition (look for "INSTALL_EFI_STRIP" in + docs/misc/efi.pandoc for more information - when not using + "make install-xen" for installing xen.efi, stripping needs to be + done outside the Xen build environment). endmenu -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 13:58:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 13:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518552.805234 (Exim 4.92) (envelope-from ) id 1pk3e2-00012P-KG; Wed, 05 Apr 2023 13:57:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518552.805234; Wed, 05 Apr 2023 13:57:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3e2-00012I-HI; Wed, 05 Apr 2023 13:57:50 +0000 Received: by outflank-mailman (input) for mailman id 518552; Wed, 05 Apr 2023 13:57:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3e1-0000PU-4N for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:57:49 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8f46431-d3b9-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 15:57:48 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id l15-20020a05600c4f0f00b003ef6d684102so18489378wmq.3 for ; Wed, 05 Apr 2023 06:57:48 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id t12-20020a7bc3cc000000b003ee42696acesm2281079wmj.16.2023.04.05.06.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 06:57:47 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E0D531FFB7; Wed, 5 Apr 2023 14:57:46 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8f46431-d3b9-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680703067; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=7NetuLM1YNy+KIDJo2AuRwk1MQSAg78qWWaqODIp3uM=; b=STRahmuuUI8KQBpKkK6/PybRdBaAfHp1W+GWkva9949DvsniQ47A/YBs4/K6otGmIQ A7oHq5QZml8oDY9OkaJYXNIDicXknAlahrTy0t885QBs0Lt5BGqY/X1A5hzP+3cG4jyG hqExCPaaG4YfjYDF2Lvk4KZCMdUASYLq+3mofYtWUXbekaC+KANqj/gZ2+SaWy51z2Gx IK4y7wRVW/r+5NSnoD08WImnjxGuzAjZRzafDn3YXT4lhfyMCg0hk6YePHsX9rGEZ0yO 5bbeqBjbAXiB4zUJZFVItGQ8ztZK7Dl/a/IVEwL731YIWMclVzlyNQOD4tFezaYuIqhf O8lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680703067; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7NetuLM1YNy+KIDJo2AuRwk1MQSAg78qWWaqODIp3uM=; b=1zijq7juwmx3MMCqfyV/5sETlfwybfychoJRxCHE3bQNaUuJac3qIvr1hUIuV4bNN4 luYyvIX76KaC6Fb2IJ49yOOh1lStzs6nOZxOngo6vZD4Z/f/XvfF6v5LgciIwISdkjLj X3Z06k8ZDLBkzHWCG++lXAiWQ62Ul78CS+S+uCQXSfgOuSMT2BaXU4XPT5Y4Kl97ErG7 nEJsVrkP8Kd5tVu8+RKIqiTsMuYt/vX4njlS2oSzSfynbCX1VlR6UeChanxex0RLF2H0 8kyq1/637PdJZCLbMxsMofZaHhVz+Sbw3M6DLh6k1Pvxml8rczCRdL/nQHNzAOSSxx/B Uesw== X-Gm-Message-State: AAQBX9flo6vaYCRLpeTPih80o29MQvwCCIUlOSGnmnX/DDPY2lJMpSwO mM2hNQljH9D05932O7RgvwHB+Q== X-Google-Smtp-Source: AKy350amvRA+LsVe3Qrc1qOw8K7TS5SLWtfzWAgqhDokCIDVgX46fW59a21dzTrAyh+jdrLxrPgnHA== X-Received: by 2002:a1c:e916:0:b0:3f0:4f83:22f4 with SMTP id q22-20020a1ce916000000b003f04f8322f4mr4568690wmc.20.1680703067664; Wed, 05 Apr 2023 06:57:47 -0700 (PDT) References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-10-philmd@linaro.org> User-agent: mu4e 1.10.0; emacs 29.0.60 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Reinoud Zandijk Subject: Re: [PATCH 09/14] accel: Allocate NVMM vCPU using g_try_FOO() Date: Wed, 05 Apr 2023 14:55:41 +0100 In-reply-to: <20230405101811.76663-10-philmd@linaro.org> Message-ID: <874jpul9d1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Philippe Mathieu-Daud=C3=A9 writes: > g_malloc0() can not fail. Use g_try_malloc0() instead. > > https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#g= lib-Memory-Allocation.description > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/i386/nvmm/nvmm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c > index 3c7bdd560f..45fd318d23 100644 > --- a/target/i386/nvmm/nvmm-all.c > +++ b/target/i386/nvmm/nvmm-all.c > @@ -942,7 +942,7 @@ nvmm_init_vcpu(CPUState *cpu) > } > } >=20=20 > - qcpu =3D g_malloc0(sizeof(*qcpu)); > + qcpu =3D g_try_malloc0(sizeof(*qcpu)); > if (qcpu =3D=3D NULL) { > error_report("NVMM: Failed to allocate VCPU context."); > return -ENOMEM; Why - if we fail to allocate the vCPU context its game over anyway any established QEMU practice is its ok to assert fail on a malloc when there isn't enough memory. IOW keep the g_malloc0 and remove the error handling case. --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 05 14:37:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 14:37:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518556.805243 (Exim 4.92) (envelope-from ) id 1pk4GK-0006mE-JP; Wed, 05 Apr 2023 14:37:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518556.805243; Wed, 05 Apr 2023 14:37:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4GK-0006m7-Go; Wed, 05 Apr 2023 14:37:24 +0000 Received: by outflank-mailman (input) for mailman id 518556; Wed, 05 Apr 2023 14:37:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4GI-0006lw-MO; Wed, 05 Apr 2023 14:37:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4GI-0003mS-J9; Wed, 05 Apr 2023 14:37:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4GI-0001fk-2w; Wed, 05 Apr 2023 14:37:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk4GI-0004kj-2N; Wed, 05 Apr 2023 14:37:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wumjcVPGMrsKrTvvi/dv6/gQIBDMtg0YVfVW/SQTiLM=; b=izHWXJdvvNdn02gih1RRf8se6i DQW+c97hr1fgy6vo2TfOX+ZDz/YJOR8W3Qm0MDcFv3gWdfwQ5ht4GhRvZ67gcKJGtSQRnelkhe7B/ 1n6pcqgzCLAKLLYYEAPMZFTbsYyJD4BOCO8E4wuG0fMlYxLAN3krtDnTe/G/kL91q6oc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180145: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=76f598ba7d8e2bfb4855b5298caedd5af0c374a8 X-Osstest-Versions-That: linux=148341f0a2f53b5e8808d093333d85170586a15d From: osstest service owner Date: Wed, 05 Apr 2023 14:37:22 +0000 flight 180145 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180145/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180135 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180135 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180135 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180135 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180135 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 76f598ba7d8e2bfb4855b5298caedd5af0c374a8 baseline version: linux 148341f0a2f53b5e8808d093333d85170586a15d Last test of basis 180135 2023-04-04 10:20:26 Z 1 days Testing same since 180145 2023-04-05 00:11:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Kardashevskiy Anup Patel Chuck Lever Dai Ngo Dmytro Maluka Janosch Frank Jeff Layton Jeremi Piotrowski Linus Torvalds Nicholas Piggin Nico Boehr Paolo Bonzini Sean Christopherson Takahiro Itazuri jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 148341f0a2f5..76f598ba7d8e 76f598ba7d8e2bfb4855b5298caedd5af0c374a8 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Apr 05 15:12:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 15:12:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518564.805254 (Exim 4.92) (envelope-from ) id 1pk4nj-0003Xl-8b; Wed, 05 Apr 2023 15:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518564.805254; Wed, 05 Apr 2023 15:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4nj-0003Xe-5v; Wed, 05 Apr 2023 15:11:55 +0000 Received: by outflank-mailman (input) for mailman id 518564; Wed, 05 Apr 2023 15:11:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4nh-0003XQ-Du; Wed, 05 Apr 2023 15:11:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4nh-00056d-C3; Wed, 05 Apr 2023 15:11:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4nh-00040W-03; Wed, 05 Apr 2023 15:11:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk4ng-0003dd-Vv; Wed, 05 Apr 2023 15:11:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Zq/5szviEDWigi1ZG16ruPTO/mrXRW9mMAb8Jijhpnk=; b=yE8Y8w6dM/KwVmM0EKGKsgKK3y kamLDkTyU3rZmiXHzOokcx7Z46w7CWeXr4H0dsAGWFhx6XoLUbFnmblHIj/ITCLVfxtXLt0KMrN8b 51noCRWuG79wNRMwKd4WtSjBVrJb6JUl6wvSL2pllr5YmxW6KmP/dkXtQml+1IbWY/Z8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180155: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=48d76e6da92f9ef76c8468e299349a2f698362fa X-Osstest-Versions-That: xen=415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 From: osstest service owner Date: Wed, 05 Apr 2023 15:11:52 +0000 flight 180155 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180155/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 48d76e6da92f9ef76c8468e299349a2f698362fa baseline version: xen 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 Last test of basis 180143 2023-04-04 19:00:27 Z 0 days Failing since 180152 2023-04-05 11:02:36 Z 0 days 2 attempts Testing same since 180155 2023-04-05 13:01:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 415f7d9404..48d76e6da9 48d76e6da92f9ef76c8468e299349a2f698362fa -> smoke From xen-devel-bounces@lists.xenproject.org Wed Apr 05 15:15:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 15:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518571.805265 (Exim 4.92) (envelope-from ) id 1pk4qj-0004FZ-Tn; Wed, 05 Apr 2023 15:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518571.805265; Wed, 05 Apr 2023 15:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4qj-0004FS-P6; Wed, 05 Apr 2023 15:15:01 +0000 Received: by outflank-mailman (input) for mailman id 518571; Wed, 05 Apr 2023 15:15:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4qi-0004FH-Dq for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 15:15:00 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f4a7723-d3c4-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 17:14:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f4a7723-d3c4-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680707697; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=EJ3ev2JBehdWtPeyrAnBZaPmtmxUVr18gM35xQh8XrI=; b=ZWjvMY9iypUv4t4Edm2mCdtYVPyqaAWjY64mOgjepXB9T06ulkeCjym5 mjOoChhX3AmkTj/fe7WVhFwrEilCpXiZAq733V7I60elfxptr0tknE+MN TM+sRY8wEhEIQ7VahznJ235p0O0PaIo9Ta3zsTboKqODYJC7bO/JOEQnC g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104465613 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:LVFSxqlOxkdm7OGEc2OAvhvo5gxnJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdX2CHaPqCNGTzetEkOY+28ENS75LSndA3T1Fk+Xg2QyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgX5AKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fgpDzsXKTWYvOSrmLS0Dc5WvOJ8Dsa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQth/A+ j6YojqgWXn2MvSkihXd/WKdntTpph3lfaIJOaaEqKVT1Qj7Kms7V0RNCArTTeOComqjUNsZB UUS8ScqqbUa/VauCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OccSCY2z FaPk5XMDCZ2rbyOYXuH8/GfqjbaERcYLCkpZSICZQIf5p/op4Rbpg3LZsZuFuiylNKdMSv32 DqQqy89gZ0ciMcK0+Ow+lWvqzCjvJ/SVSYu+x7aGGmi62tRbZaofYWy5XDH7PxLK8CSSVzpg ZQfs5HAtqZUV8jLzXHTBrxXR9lF+sppLhXYsHlkBd4E7A+r5ialcsd32gtYe2VmZ5NslSDSX KPDhe9AzMYNbCP0PPcmPd3Z59cClva5S4m8PhzARp8XO8UqKlfalM17TRTIt10BhnTAhk3W1 X2zVc+3RUgXBq18pNZdb7dMiOR7rszSKI66eHwa8/hE+eDEDJJtYe1ZWGZil8hghE9+nC3b8 sxEK+yBwAhFXev1b0H/qNBDdQ5RdiJqXsCn86S7k9JvxSI/QQkc5wL5m+t9K+SJYYwO/gs3w p1NchABkweu7ZE2AQ6LdmpieNvSYHqLllpiZXZEFQ/xixAejXOHsP93m20fIeN2q4SODJdcE 5E4Ril3Kq8VEGiWoGhAMMKVQU4LXE3DuD9i9hGNOFAXF6OMjSSQkjM4VmMDLBUzMxc= IronPort-HdrOrdr: A9a23:1tJHzKj6rj9X9XshvrlI23ODQ3BQXvgji2hC6mlwRA09TyX4rb HKoB1/73WYtN9/Yh0dcLy7V5VoOEmskqKdgrNhX4tKPjOHhILAFugL0WKF+VPd8kbFh41gPM lbEpSWP+eAaWSS3fyQ3OBhKadb/DBcytHRuQ4C9QYKcei3UdAa0+6mMHfnLqUYLDM2fKYEKA == X-IronPort-AV: E=Sophos;i="5.98,321,1673931600"; d="scan'208";a="104465613" Date: Wed, 5 Apr 2023 16:14:45 +0100 From: Anthony PERARD To: Luca Fancellu CC: Xen-devel , Bertrand Marquis , Wei Chen , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross , George Dunlap Subject: Re: [PATCH v4 10/12] xen/tools: add sve parameter in XL configuration Message-ID: <8921a9ca-7284-44ce-8ce5-bc631b0980d6@perard> References: <20230327105944.1360856-1-luca.fancellu@arm.com> <20230327105944.1360856-11-luca.fancellu@arm.com> <9bd2924b-bb4a-440d-ae31-0253e66c56e5@perard> <328A9CBD-5FCE-481B-93AF-D139963488D5@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <328A9CBD-5FCE-481B-93AF-D139963488D5@arm.com> On Tue, Apr 04, 2023 at 01:48:34PM +0000, Luca Fancellu wrote: > > On 31 Mar 2023, at 15:23, Anthony PERARD wrote: > > > > On Mon, Mar 27, 2023 at 11:59:42AM +0100, Luca Fancellu wrote: > >> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > >> index 10f37990be57..adf48fe8ac1d 100644 > >> --- a/docs/man/xl.cfg.5.pod.in > >> +++ b/docs/man/xl.cfg.5.pod.in > >> @@ -2952,6 +2952,17 @@ Currently, only the "sbsa_uart" model is supported for ARM. > >> > >> =back > >> > >> +=item B > >> + > >> +To enable SVE, user must specify a number different from zero, maximum 2048 and > >> +multiple of 128. That value will be the maximum number of SVE registers bits > >> +that the hypervisor will impose to this guest. If the platform has a lower > > > > Maybe start by describing what the "sve" value is before imposing > > limits. Maybe something like: > > > > Set the maximum vector length that a guest's Scalable Vector > > Extension (SVE) can use. Or disable it by specifying 0, the default. > > > > Value needs to be a multiple of 128, with a maximum of 2048 or the > > maximum supported by the platform. > > > > Would this, or something like that be a good explanation of the "sve" > > configuration option? > > Yes I can change it, a need to do it anyway because I think also here, the suggestion > From Jan can apply and we could pass a negative value that means “max VL supported > by the platform" Well, it's a config file, not a C ABI, so max allowed here doesn't have to be spelled "-1", it could also be "max", "max-allowed", "max-size-supported", ... So fill free deviate from the restricted C ABI. But "-1" works as long as it's the only allowed negative number. > > > >> +supported bits value, then the domain creation will fail. > >> +A value equal to zero is the default and it means this guest is not allowed to > >> +use SVE. > >> + > >> +=back > >> + > >> =head3 x86 > >> > >> =over 4 > >> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > >> index ddc7b2a15975..16a49031fd51 100644 > >> --- a/tools/libs/light/libxl_arm.c > >> +++ b/tools/libs/light/libxl_arm.c > >> @@ -211,6 +211,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > >> return ERROR_FAIL; > >> } > >> > >> + config->arch.sve_vl = d_config->b_info.arch_arm.sve; > > > > This truncate a 16bit value into an 8bit value, I think you should check > > that the value can actually fit. > > > > And maybe check `d_config->b_info.arch_arm.sve` value here instead of > > `xl` as commented later. > > Yes I can do it, one question, can I use here xc_physinfo to retrieve the maximum > Vector length from arch_capabilities? > I mean, is there a better way or I can go for that? Yeah, there might be a "better" way. I think me suggestion to check the sve value here was wrong. I still want to have it checked in libxl, but it might be better to do that in the previous step, that is "libxl__domain_config_setdefault". libxl__arch_domain_build_info_setdefault() will have `physinfo` so you won't have to call xc_physinfo(). Regarding the default, libxl is capable of selecting a good set of option, depending on the underling hardware. So is it possible that in the future we would want to enable SVE by default? If that's even a remote possibility, the current API wouldn't allow it because we have "default" and "disable" been the same. Since we want to add a max VL supported option, maybe we want to separate the default and disable options. So we could keep the single field `libxl_domain_build_info.arch_arm.sve` and have for example "-1" for max-supported and "-2" for disabled, while "0" mean default. Or alternatively, add an extra field libxl_defbool (can be default/true/false) and keep the second one for VL. (That extra "disabled" option would only be for libxl, for xl we can keep "sve=0" mean disable, and the missing option just mean default.) In any case, libxl__arch_domain_build_info_setdefault() will check `b_info.arch_arm.sve` and set it to the value that can given to Xen. And as of now, libxl__arch_domain_prepare_config() will just copy the value from `b_info` to `config`. (I guess that last step _prepare_config() could still do the division by 128.) Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Apr 05 15:18:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 15:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518575.805274 (Exim 4.92) (envelope-from ) id 1pk4tp-0004xY-Bu; Wed, 05 Apr 2023 15:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518575.805274; Wed, 05 Apr 2023 15:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4tp-0004xR-8h; Wed, 05 Apr 2023 15:18:13 +0000 Received: by outflank-mailman (input) for mailman id 518575; Wed, 05 Apr 2023 15:18:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk4to-0004wx-1S for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 15:18:12 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12e2c4e1-d3c5-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 17:18:09 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id v14-20020a05600c470e00b003f06520825fso1304728wmo.0 for ; Wed, 05 Apr 2023 08:18:09 -0700 (PDT) Received: from [192.168.69.115] (4ab54-h01-176-184-52-81.dsl.sta.abo.bbox.fr. [176.184.52.81]) by smtp.gmail.com with ESMTPSA id i42-20020a05600c4b2a00b003f0321c22basm2461375wmp.12.2023.04.05.08.18.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 08:18:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12e2c4e1-d3c5-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680707889; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=idFXVwnEQw2AeckpahKfXswn5+/Jk4JVx854v+ndXlM=; b=P5FRw1Bg8gByNSRzaVrWUJucc+Ia4IMT8SBajxnMMvSH0nmkPoBKvzzOp8cPpm0043 W55c3pCluAC9R0flUGbEbU7/UOi25PsdH6FiniT+JvE7ldpWa3l6uPy/ngUjkHb2R1nI lDct8ip3jjWb9ZROycFg+zRRunyCOZEJtqUtxAV7aEzkeuiimDkDVTD8s1N/T9AVVfcu ZKoBR5zXSIvJZ2JIo/R2+DR5oTvV0/L9XzKUlEb5jX9SCauc267Ovw8quhwNhbHCnBZ1 8EWK7u4/h6p/P9crBvmOAbjQYbSrYrxaz/Jn0hJ/1Wx9uKiQKBukAv/SHkV2N833Rknz lSnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680707889; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=idFXVwnEQw2AeckpahKfXswn5+/Jk4JVx854v+ndXlM=; b=dp2/D3O2Z9XxHmDHopLfCTW1NXEJOP3QVxP33zNnk95UAhe9LA6UX9Tj5Vn+/yr2xu /wYG08idl9acv6J7vwH+52a2lt8gFF1PcxrnGncqZ3M6l4S3VgwpiE+MWukMQa8nQGXV tAioX7lpcKr9IPDds7qZOxaoRvFK0ZRxCRGuJ4ysunfugtscXE7/ZxvBCftXDoVR7Say w3IJVtTyrXb45p/ONXyPNzYonf5690mtUiV3nULcaZinknzCfQPYdQHfTk+2oNB3R4a1 m18m6mFXAHEroRSvbB9sA77ZjvYaZsMhqMwky6905lSiOxu8IOy9fjVqK77ZUrMiJCLg Uodw== X-Gm-Message-State: AAQBX9fJkVekEjq+oAPUgp9albvS0cYku54CDxob6jmI2H+Dwa6aUZlt v6jF6OHKIuDPQcRQ9JNa5C4RwQ== X-Google-Smtp-Source: AKy350Z6S5WSad5iHIzjt49TqgYs41yzdYlN/8d2eI12bwZ9Xb+YKGePa0vAg6iMH5JR4Z/F8GyAAQ== X-Received: by 2002:a7b:c38b:0:b0:3ed:8bef:6a04 with SMTP id s11-20020a7bc38b000000b003ed8bef6a04mr5244487wmj.27.1680707889387; Wed, 05 Apr 2023 08:18:09 -0700 (PDT) Message-ID: Date: Wed, 5 Apr 2023 17:18:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 09/14] accel: Allocate NVMM vCPU using g_try_FOO() Content-Language: en-US To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Reinoud Zandijk References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-10-philmd@linaro.org> <874jpul9d1.fsf@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <874jpul9d1.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/4/23 15:55, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> g_malloc0() can not fail. Use g_try_malloc0() instead. >> >> https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> target/i386/nvmm/nvmm-all.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c >> index 3c7bdd560f..45fd318d23 100644 >> --- a/target/i386/nvmm/nvmm-all.c >> +++ b/target/i386/nvmm/nvmm-all.c >> @@ -942,7 +942,7 @@ nvmm_init_vcpu(CPUState *cpu) >> } >> } >> >> - qcpu = g_malloc0(sizeof(*qcpu)); >> + qcpu = g_try_malloc0(sizeof(*qcpu)); >> if (qcpu == NULL) { >> error_report("NVMM: Failed to allocate VCPU context."); >> return -ENOMEM; > > Why - if we fail to allocate the vCPU context its game over anyway any > established QEMU practice is its ok to assert fail on a malloc when > there isn't enough memory. IOW keep the g_malloc0 and remove the error > handling case. This was my first approach but then I realized the author took care to warn / return ENOMEM, so I went for _try_; but you are right, since this is "game over" let's simply remove the check. From xen-devel-bounces@lists.xenproject.org Wed Apr 05 15:49:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 15:49:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518579.805284 (Exim 4.92) (envelope-from ) id 1pk5Na-0000a8-IA; Wed, 05 Apr 2023 15:48:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518579.805284; Wed, 05 Apr 2023 15:48:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk5Na-0000a1-FE; Wed, 05 Apr 2023 15:48:58 +0000 Received: by outflank-mailman (input) for mailman id 518579; Wed, 05 Apr 2023 15:48:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk5NZ-0000Zu-Be for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 15:48:57 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c6bc2cc-d3c9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 17:48:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c6bc2cc-d3c9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680709734; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8vWpWya0wN4rZ3x0AJ/glU6yInfi2NjKtrZResNFdMc=; b=WMhKbBk1POGvT8MOwMgTSPHwTIXjzZVTHhmacbMbkORU4dTA4Rfcs3mF l3W3Uq8H0tD9EisJYojgU+CEozK/ZpwSgQ4DzWWQN+MH3NOa8c80nIYcS PfrV1llygfSlljBjxHgB+iW/FX53ajL6PyYnq3I5J6nluHloFN2vuj6ZR s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103233005 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:GsIbL6CCPiJTIRVW/yHjw5YqxClBgxIJ4kV8jS/XYbTApGwghGBSz mRMWTjVOazYZmT3KN9xPN6w8UwO6JOEyoJkQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5+JeKmZu2 tokISlVUzCD2eOanrm6Vbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4TRH54Oxh7Fz o7A1zm6OU8eacOm8zSUrW+iurDFwCnUG6tHQdVU8dY12QbOlwT/EiY+V1G2vP24gU6WQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceTCQnz FaTk/v1BDZkt/ueTnf1y1uPhWrsY25PdzZEPHJaC1JfuLEPvb3fkDrSSv9IF46aqOH8AGnN4 zDUrQRgjLQM2JtjO7qAwbzXv969jsGXHlZrt12GAD3NAhBRP9D8OdHxgbTPxbMZddvCEAHc1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuKGpxeEdMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QeOsYqL1XWp3E/PSZ8OlwBd2B1yMkC1 WqzK57wXR7294w8pNZJewvt+eBynX1vrY8ibZv60w6mwdKjWZJhcp9caAHmRrlgvMu5TPD9r 4432z2il08OD4UTo0D/reYuELz9BSNhX8yn8JAKK7Xrz8gPMDhJNsI9CIgJI+RN95m5XM+Sl p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:ihJHs6Gzj/JunA9MpLqEHseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV86faQslwssR4b9uxoVJPvfZqYz+8W3WBzB8bEYOCFghrKEGgK1+KLrwEIWReOk9K1vZ 0KT0EUMqyVMbEVt6fHCAnTKade/DGEmprY+9s3GR1WPHBXg6IL1XYINu6CeHcGPTWvnfACZe ehDswsnUvZRV0nKv6VK1MiROb5q9jChPvdEGI7705O0nj0sduwgoSKaSSl4g== X-IronPort-AV: E=Sophos;i="5.98,321,1673931600"; d="scan'208";a="103233005" Date: Wed, 5 Apr 2023 16:48:38 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH] x86emul/test: drop bogus .PHONY Message-ID: <3d0c36f9-a715-4971-9031-04848bcd2d0d@perard> References: <515bbf07-91fa-1932-1be1-1411f7814e6e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <515bbf07-91fa-1932-1be1-1411f7814e6e@suse.com> On Tue, Apr 04, 2023 at 08:37:55AM +0200, Jan Beulich wrote: > x86_emulate is a real (directory) target. Indeed, x86_emulate is a directory, so having the target in .PHONY isn't bogus, but kind of expected in most cases. Here, the recipe is written with .PHONY been used, as suggest the used option "-p" from `mkdir` and "-f" from `ln`. Without .PHONY, the recipe will never be executed if the directory exist. And, if the content of the original x86_emulate directory change, the linked directory will never be updated. So, this patch description needs a reason for removing x86_emulate from .PHONY. Is there some kind of bug? > --- a/tools/tests/x86_emulator/Makefile > +++ b/tools/tests/x86_emulator/Makefile > @@ -278,7 +278,6 @@ else > run32 clean32: %32: % > endif > > -.PHONY: x86_emulate > x86_emulate: > mkdir -p $@ > ln -sf $(XEN_ROOT)/xen/arch/x86/$@/*.[ch] $@/ Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Apr 05 16:17:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 16:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518583.805294 (Exim 4.92) (envelope-from ) id 1pk5oZ-0004xD-OK; Wed, 05 Apr 2023 16:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518583.805294; Wed, 05 Apr 2023 16:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk5oZ-0004x6-LW; Wed, 05 Apr 2023 16:16:51 +0000 Received: by outflank-mailman (input) for mailman id 518583; Wed, 05 Apr 2023 16:16:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk5oY-0004wP-MT for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 16:16:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7e1a::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43a4874c-d3cd-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 18:16:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7209.eurprd04.prod.outlook.com (2603:10a6:102:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 16:16:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 16:16:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43a4874c-d3cd-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G51r360AJlTIkzmctJlQi5uTONjZ23w2RzfWg1JTOFp2blJGsYMICvGKY2ZsClzGrsggO/ara3CCk7jKC1owO1iRrXIdZNEBqWkp+/Cpj8clc2XeeCERBrOY5l8JUbMGujzsMWrDolQp2xMouNY9nBBrkUbYwZ0d/qoqMBUKA3ywEAnOWGp0aZ0LHDPUHN+zqE7jyOYUIJE5hQkX5ans0NW6nzSScqq69hNc3A0LESlxmYXa50P15wzs8M9LfSTPPVY8mM0vmrQYkCK8maNDk2q23d9k7B2Tj5jnkFhe4OhfH/FkYACz5j/tqrwY8k0Pu4lfzO9yhr9n5OujtNih7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ED/pJhg31bjLlSP3HBT0D3rUkA+rwZgqc+paNaMixrg=; b=NYLlIQ9/1naOK2VdPAIDzUSt1sq7EoBnWB5XjiaqfNMuYNe7CMy5IbQZCjqzFak63WZKU9g+yP75Rz29eSfFwNImoVpeWSNwx7svXn/ZdMbaGoTwcnIfVRhnXBfBkXxSgaAWQ96XNw/yq+fPh7t3bdF/R2/I1W/9g7JEPbR6pv1RvRcpFLLZSrZMHzkkGtd5QnKUQTCYZMzWEskyU9TBSOaKLHMSF9okZkhpbKa/YnNi7uCERW/MgX0gYnh3/5T5xrlUt6a9mpWq7sQJDmopGHcKPp0sJbdszZ0AsuJcYoYdyNwGCd35qGjC+es51/WnhUzi+ghQjlP6UugBb/4Jow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ED/pJhg31bjLlSP3HBT0D3rUkA+rwZgqc+paNaMixrg=; b=mZNGfpiYZhmLFOJvEJcaXtg0pJFMjEjBHRTXNevU1jOosto2obndKIL51/2anZMxSsW9YCyG4je40Xg5VhCYIj91cU7mmWU09M8PNZeVL+spNQE9KY5S/pICGGrAWBUHzV/n9j3jZl1lHUUHle8RHVO9mKX3ugSg/YZU4M1kvQ/FTGUOAaweGgu73TGuONYdmxvXxCuPrjoo/MSQ4JP02uCqCMaaJp+bVI7vVCcBiTOo4nNqioKQBiDHGSMzZr9iFhMZQdEBUNNUi9ksR4a3rG2Se8Ichjg80keqy2WweOBY02bBIQaepoCmFEmg1n3XA1Sd2O2ozxo15qMQXk0mfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 5 Apr 2023 18:16:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86emul/test: drop bogus .PHONY Content-Language: en-US To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <515bbf07-91fa-1932-1be1-1411f7814e6e@suse.com> <3d0c36f9-a715-4971-9031-04848bcd2d0d@perard> From: Jan Beulich In-Reply-To: <3d0c36f9-a715-4971-9031-04848bcd2d0d@perard> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: 65f408ce-d6fd-4014-eceb-08db35f1265a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VoUg+C1X0ETwSPJ+WM6IWBpLL4EodNswdejUlHFSCoiyLckJMAy58mN1svF7MG2Nc7i573oa9grWPqcQ8Bbq6SxyoAZ3Lw2lLsZIcu52HIo5fdovhdVkVC5wQqeWvynS30Rf0rr0Ma9VXn1A0wk61SndClqL9amarWV4/ykBJS27HScRPnQw/m2vn3bRmejpFCQqBIij4yyxhDq85dANU9JQWty2+U1ITdAtc7SbvMFV1khb6y6vGA7cmVR+tjuDEVltWmgIUegHQubMYrnl+68K42CB2HTMHdtQDcn+A4eo4Q6DD0OSX6hFzJYDALJ6/r4WNpEPfHS1NaxPG2LM6CKzj+Dux37AtOFdlvam3k5XBrFmuvNa14hKBPJbTVosUyNpe5koKI3V6/Co4eJ8ZCWVYGsMxhpdsjrBnEiiCfVHYWrkqq5SJrNvEG7kB9+0+Fm4NFG03nXjRdW6tC6K+tk0xctSmxTzfvLOOFtM/HlwSuLnXna7joCnU8St5sr7PIXNXlltl/NOkRmpuR7dHKPvH2rkq1Zl+Cd+KJyjfOI5vwIa/wzc575V87oxSgEa8U+Qd7yBqPBVZo7wDiznfPDffVbKa/Wf3OSUI4gr4gjdMW7w9h7z8EkkO+rYVvveHJTqP4GrV+niRCGvSpHROWW9KfxwceIxbSUcjP94Z5i0umZPRb81H1vZWSOMJRJp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199021)(6486002)(83380400001)(2616005)(53546011)(6512007)(6506007)(186003)(38100700002)(26005)(8936002)(2906002)(5660300002)(478600001)(36756003)(41300700001)(6916009)(66476007)(66946007)(66556008)(54906003)(8676002)(4326008)(31696002)(86362001)(316002)(31686004)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elhVRmozMGtaeFZSd01EbmZaaXFLR1paSE8xVm12UENrelJuWVJXM0tySUhs?= =?utf-8?B?bmljK0JLQ1FBVVdTVlJ0VzZobGlnS0JrWDdTN3I0TWRPNDhnYXVSMEoxNEpu?= =?utf-8?B?MkhyMjAzVWNXWHB3SXphU3VqRVU1T0ZxME12TG01RUZRM0FyWksraUdXMVZw?= =?utf-8?B?bkJ4Q204Yk1Nclg1YXJEcVNoMFJOMFF2OVgwVitTdGUzOWN1OFFCblUrYU9t?= =?utf-8?B?a3d6QzBKR0FnOENhbWt2Ni9wNUZTaEtqTDNybzB3NEFvMStCZExQcW9CNEFt?= =?utf-8?B?eER6Ni91SDhkWXZGUHYzcFkwakhIbEc0RnBzZEEremp5Z3FYbUh5ZzI0Zi9I?= =?utf-8?B?WHJEcVE5QWJJQUJEc2liYU8xcFdRZ1IzZ1VjdG16Qi9FZ0ltSWF2elpPYmJx?= =?utf-8?B?c3Y4NmNqejJoRUpNM1lKaWZMa3pyNEQxcXdaKzNqaEcvZ2MzUVBTZjFaMFFO?= =?utf-8?B?RTM2OE9hKzQ0ME9McTFOV3pQZE9NeVdhVzRWeUtqYTlpeTRnNFRIUEc4ZGRJ?= =?utf-8?B?TmFrQmhyNmxkdkZkVFpaK2pBYVdIS2daTUU3Ui9sT1l3WWJUTERTREZmSmt2?= =?utf-8?B?VTV2OUd1akQ1NzZMNzNrY1RKbzB0c205ZjVKMXdyODhxeE1PTHJwOEFTUSsv?= =?utf-8?B?OWFiZWwyK1lvSURncEsrT3h1RHZPdTg4bmw3QjJCWnp2TXRFZEFJcC9Pcmo1?= =?utf-8?B?cm9mZHBjYjB6QXJSMmlWM3Faa0QzNHI5V2l3U0VqK3VYRFJHSkpRZkJqZDcw?= =?utf-8?B?dlVSVWlWb0UyR2VwMFJleGZlbkZsclR0R0YwQU9IcWdhOGs5djB3UGUzaEdP?= =?utf-8?B?V2pHN2h2UFJ0YSt6bFB6czB2b3B6bUUzYS9zRldhS2hGN1d2aFFiTnpZaVNS?= =?utf-8?B?MjlWalR2NDI0cllEaFRMSFc0V004OEIraElDMUNNbVJjT1o2S0VNOGhWRE5X?= =?utf-8?B?eVdORnJhSEgzdkNKTndQSTJDNXRXQkNkMG0rRlA4OGZjY3BYQ3VtQVM1MDhF?= =?utf-8?B?YjhTWTh6RlhOUzZ5NEFZSTVvbGttOFg1aVNYODBUNDF3bEdCaGtpMHdOZWRF?= =?utf-8?B?ZDhnOTZYRWFqWFl6QUVHZVFiRWJ3TDRzMWxXVFVwVW41ZlJHMC9sT1ZYaVl2?= =?utf-8?B?NkVsclN0M1IxbFNxdzkxUUdUaUZ6ZWY5L3JUM0J2U0NuOTlhb1RseGQyWGsy?= =?utf-8?B?cU1lQ09KdWFSMnl3OVNuSU5lUWJtMGZoVkJrRC9IWWF3aXh1Y2FiMXhMclFH?= =?utf-8?B?L1lSd2M2cllBc3pLdmVlK2pseCs3aFMzQStZMzVmRmEvU3VBTmxzb0VZMjZi?= =?utf-8?B?ekx1VEFBaWlPOEFHM0FNeXVaZjJ6WkdZWDhueG90SzRsdjlGeFk4S0paSG9s?= =?utf-8?B?a1A0RGJXVXEvbDErTkFicG9KeklNMmZUVzBMT0JWNHUwdS9FTEZkdHZWNmg3?= =?utf-8?B?bm1Wd2NYYlFkUUZ6TFovekdyejZFbzRtNzlTcVVwY0ZUWGwvWnNSUERuYVQ5?= =?utf-8?B?cSt6UDBjZW45Q3k2VlhSN2pVVjczeGJYbENoVVJEMDVpZHY5U2htZ2VGWWFa?= =?utf-8?B?OTAvSUZNZ3R0c1pmOWgvL3cxWU5IR2FrNjhobTkyeDBFSFV0NDJvcUdhQmtx?= =?utf-8?B?RFdQb2ZrUm52bldUZllITkR6WDEya0NYYzFyVWZUeWUrYjdFaXVoRU1QTm5B?= =?utf-8?B?NitXVUFjSUVTTjdDa2Q2TmROZUlHVkRxVWhMUXpQd3FNeG9IRmdLNS8xenZD?= =?utf-8?B?cG5qb0pLSjZ5MzZUNjcxZXp3M3hUa3JPTkhxQm10ak5USzd6d2JxQktKRU9P?= =?utf-8?B?ZUxoN3BwS212YVRJR29hMXB1Z1N2WERCYjVzV0l2MHJCTGt0YWR3ZHFWSjha?= =?utf-8?B?Zzc0RW5sZmgyc1dkcEQrMXR1VGtzaWpyc1FweGIxRVFzSC9CQVR1UXBmZElB?= =?utf-8?B?QTdjaURqY2Z3UVJxUUhYTTBQR05tNklTTjBpcnNodGIyWThFUExVQTVyUm9x?= =?utf-8?B?NktQSVFLWlZMUzRPR1JWMkZ5N1dzNGI5N1V2WHk2cDVUWGU0bWU3VlA5eUl0?= =?utf-8?B?NmdCcm40dVVZeExQTDZncTh2OUdYdlh0WGx1T0pIYUpFMXBHTFBqdEx2N29V?= =?utf-8?Q?dDVP/ux759MFd0lggR7tSXmPT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65f408ce-d6fd-4014-eceb-08db35f1265a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 16:16:45.3713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /hkqCkxhLiFzUQuOdQ/FnH2qB0YKzXT+Mb9IqHxYVDv/QDHrxcPUCrGBh2BsCAszCgEZeQElyltkw2WiR/SoFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7209 On 05.04.2023 17:48, Anthony PERARD wrote: > On Tue, Apr 04, 2023 at 08:37:55AM +0200, Jan Beulich wrote: >> x86_emulate is a real (directory) target. > > Indeed, x86_emulate is a directory, so having the target in .PHONY > isn't bogus, but kind of expected in most cases. > > Here, the recipe is written with .PHONY been used, as suggest the used > option "-p" from `mkdir` and "-f" from `ln`. > > Without .PHONY, the recipe will never be executed if the directory > exist. And, if the content of the original x86_emulate directory > change, the linked directory will never be updated. > > So, this patch description needs a reason for removing x86_emulate from > .PHONY. Is there some kind of bug? Yes, but it was my brain that was buggy. I deliberately added that line long ago when converting the symlink to a real dir, and then for whatever reason thought recently that it was bogus. Right you are, and I'll revert this change. Jan >> --- a/tools/tests/x86_emulator/Makefile >> +++ b/tools/tests/x86_emulator/Makefile >> @@ -278,7 +278,6 @@ else >> run32 clean32: %32: % >> endif >> >> -.PHONY: x86_emulate >> x86_emulate: >> mkdir -p $@ >> ln -sf $(XEN_ROOT)/xen/arch/x86/$@/*.[ch] $@/ > > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed Apr 05 16:34:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 16:34:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518588.805304 (Exim 4.92) (envelope-from ) id 1pk65M-0007h6-8q; Wed, 05 Apr 2023 16:34:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518588.805304; Wed, 05 Apr 2023 16:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk65M-0007gz-55; Wed, 05 Apr 2023 16:34:12 +0000 Received: by outflank-mailman (input) for mailman id 518588; Wed, 05 Apr 2023 16:34:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk65K-0007gq-Ho for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 16:34:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk65I-0008Jr-Tl; Wed, 05 Apr 2023 16:34:08 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.27.242]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pk65I-0000S4-KD; Wed, 05 Apr 2023 16:34:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=LmgBJib0da20mCASfh4kXw+n8JSxgCsO6eclj0adSe0=; b=FVXkGZQB0TLLEayJf5xZme/TcM kyoVaI+PRfMPnuopsqpWBWEZpbZN6cJgjabat8SNyNntVm91JC4wOae/PXs8jZyBbuH70bua3gmSN c82jdLukxKyH0/AeyNEbzpSXxTyMIsBWHpZ2+5jaQvrkrD2s09I5DhBSdOnuInExx36c=; Message-ID: Date: Wed, 5 Apr 2023 17:34:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Stefano Stabellini Cc: Oleksii Kurochko , xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/04/2023 00:15, Stefano Stabellini wrote: > On Fri, 31 Mar 2023, Julien Grall wrote: >> Hi Oleksii, >> >> I was going to ack the patch but then I spotted something that would want some >> clarification. >> >> On 29/03/2023 11:50, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h >>> index cacaf014ab..3fb0471a9b 100644 >>> --- a/xen/arch/arm/include/asm/bug.h >>> +++ b/xen/arch/arm/include/asm/bug.h >>> @@ -1,6 +1,24 @@ >>> #ifndef __ARM_BUG_H__ >>> #define __ARM_BUG_H__ >>> +/* >>> + * Please do not include in the header any header that might >>> + * use BUG/ASSERT/etc maros asthey will be defined later after >>> + * the return to from the current header: >>> + * >>> + * : >>> + * ... >>> + * : >>> + * ... >>> + * >>> + * ... >>> + * ... >>> + * #define BUG() ... >>> + * ... >>> + * #define ASSERT() ... >>> + * ... >>> + */ >>> + >>> #include >>> #if defined(CONFIG_ARM_32) >>> @@ -11,76 +29,7 @@ >>> # error "unknown ARM variant" >>> #endif >>> -#define BUG_FRAME_STRUCT >>> - >>> -struct bug_frame { >>> - signed int loc_disp; /* Relative address to the bug address */ >>> - signed int file_disp; /* Relative address to the filename */ >>> - signed int msg_disp; /* Relative address to the predicate (for >>> ASSERT) */ >>> - uint16_t line; /* Line number */ >>> - uint32_t pad0:16; /* Padding for 8-bytes align */ >>> -}; >>> - >>> -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) >>> -#define bug_file(b) ((const void *)(b) + (b)->file_disp); >>> -#define bug_line(b) ((b)->line) >>> -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) >>> - >>> -/* Many versions of GCC doesn't support the asm %c parameter which would >>> - * be preferable to this unpleasantness. We use mergeable string >>> - * sections to avoid multiple copies of the string appearing in the >>> - * Xen image. BUGFRAME_run_fn needs to be handled separately. >>> - */ >> >> Given this comment ... >> >>> -#define BUG_FRAME(type, line, file, has_msg, msg) do { >>> \ >>> - BUILD_BUG_ON((line) >> 16); >>> \ >>> - BUILD_BUG_ON((type) >= BUGFRAME_NR); >>> \ >>> - asm ("1:"BUG_INSTR"\n" >>> \ >>> - ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" >>> \ >>> - "2:\t.asciz " __stringify(file) "\n" >>> \ >>> - "3:\n" >>> \ >>> - ".if " #has_msg "\n" >>> \ >>> - "\t.asciz " #msg "\n" >>> \ >>> - ".endif\n" >>> \ >>> - ".popsection\n" >>> \ >>> - ".pushsection .bug_frames." __stringify(type) ", \"a\", >>> %progbits\n"\ >>> - "4:\n" >>> \ >>> - ".p2align 2\n" >>> \ >>> - ".long (1b - 4b)\n" >>> \ >>> - ".long (2b - 4b)\n" >>> \ >>> - ".long (3b - 4b)\n" >>> \ >>> - ".hword " __stringify(line) ", 0\n" >>> \ >>> - ".popsection"); >>> \ >>> -} while (0) >>> - >>> -/* >>> - * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the >>> - * flag but instead rely on the default value from the compiler). So the >>> - * easiest way to implement run_in_exception_handler() is to pass the to >>> - * be called function in a fixed register. >>> - */ >>> -#define run_in_exception_handler(fn) do { >>> \ >>> - asm ("mov " __stringify(BUG_FN_REG) ", %0\n" >>> \ >>> - "1:"BUG_INSTR"\n" >>> \ >>> - ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," >>> \ >>> - " \"a\", %%progbits\n" >>> \ >>> - "2:\n" >>> \ >>> - ".p2align 2\n" >>> \ >>> - ".long (1b - 2b)\n" >>> \ >>> - ".long 0, 0, 0\n" >>> \ >>> - ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); >>> \ >>> -} while (0) >>> - >>> -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") >>> - >>> -#define BUG() do { \ >>> - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ >>> - unreachable(); \ >>> -} while (0) >>> - >>> -#define assert_failed(msg) do { \ >>> - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ >>> - unreachable(); \ >>> -} while (0) >>> +#define BUG_ASM_CONST "c" >> >> ... you should explain in the commit message why this is needed and the >> problem described above is not a problem anymore. >> >> For instance, I managed to build it without 'c' on arm64 [1]. But it does >> break on arm32 [2]. I know that Arm is also where '%c' was an issue. >> >> Skimming through linux, the reason seems to be that GCC may add '#' when it >> should not. That said, I haven't look at the impact on the generic >> implementation. Neither I looked at which version may be affected (the >> original message was from 2011). >> >> However, without an explanation, I am afraid this can't go in because I am >> worry we may break some users (thankfully that might just be a compilation >> issues rather than weird behavior). >> >> Bertrand, Stefano, do you know if this is still an issue? > > I don't know, but I confirm your observation. > > In my system, both ARM64 and ARM32 compile without problems with "c". > Without "c', only ARM64 compiles without problems, while ARM32 breaks. > > My ARM32 compiler is: > arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 > > Additing a meaningful explanation to the commit message might be > difficult in this case. Agree. One would need to look at the compiler code to confirm. We should at least acknowledge the change in the commit message and also... > > Maybe instead we could run a few tests with different versions of arm64 > and arm32 gcc to check that everything still works? If everything checks > out, given that the issue has been unchanged for 10+ years we could just > keep "c" and move forward with it? ... confirm that we are still able to compile with GCC 4.9 (arm32) and GCC 5.1 (arm64). Do we have those compiler in the CI? (I couldn't easily confirm from the automation directory). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Apr 05 16:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 16:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518592.805314 (Exim 4.92) (envelope-from ) id 1pk6Aa-0008RA-Sw; Wed, 05 Apr 2023 16:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518592.805314; Wed, 05 Apr 2023 16:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk6Aa-0008R3-PB; Wed, 05 Apr 2023 16:39:36 +0000 Received: by outflank-mailman (input) for mailman id 518592; Wed, 05 Apr 2023 16:39:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk6AY-0008Qu-T3 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 16:39:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk6AU-0000Bi-ND; Wed, 05 Apr 2023 16:39:30 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.27.242]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pk6AU-0000mO-Fq; Wed, 05 Apr 2023 16:39:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TghqaubP4quF0whmmYBRFv5KsbLCk+erblh6nd8HG6w=; b=QiXlO7HZ0QxjPJZsO+e3nyzbqF AwIYrI0pAx+HYqEH8/5HFLJJPRHh3+KPg6VhLoe82A5Lsm60DdTsqvBHJglBs7zPMkG1d9XufZPsS m0Lb5jZPe3LSRkMvFA49/BQ/HkwQ838/4eb29OLFYVQ5fE2ipB+egnlak7xRkihcCaas=; Message-ID: Date: Wed, 5 Apr 2023 17:39:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Oleksii , Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> <9c4ca4a1-1b68-5ee0-0434-e6c9ec7d1ef6@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/04/2023 09:09, Oleksii wrote: > On Tue, 2023-04-04 at 08:41 +0200, Jan Beulich wrote: >> On 03.04.2023 20:40, Oleksii wrote: >>> Hello Julien, >>> On Fri, 2023-03-31 at 22:05 +0100, Julien Grall wrote: >>>> Hi Oleksii, >>>> >>>> I was going to ack the patch but then I spotted something that >>>> would >>>> want some clarification. >>>> >>>> On 29/03/2023 11:50, Oleksii Kurochko wrote: >>>>> diff --git a/xen/arch/arm/include/asm/bug.h >>>>> b/xen/arch/arm/include/asm/bug.h >>>>> index cacaf014ab..3fb0471a9b 100644 >>>>> --- a/xen/arch/arm/include/asm/bug.h >>>>> +++ b/xen/arch/arm/include/asm/bug.h >>>>> @@ -1,6 +1,24 @@ >>>>>   #ifndef __ARM_BUG_H__ >>>>>   #define __ARM_BUG_H__ >>>>> >>>>> +/* >>>>> + * Please do not include in the header any header that might >>>>> + * use BUG/ASSERT/etc maros asthey will be defined later after >>>>> + * the return to from the current header: >>>>> + * >>>>> + * : >>>>> + *  ... >>>>> + *   : >>>>> + *     ... >>>>> + *     >>>>> + *     ... >>>>> + *  ... >>>>> + *  #define BUG() ... >>>>> + *  ... >>>>> + *  #define ASSERT() ... >>>>> + *  ... >>>>> + */ >>>>> + >>>>>   #include >>>>> >>>>>   #if defined(CONFIG_ARM_32) >>>>> @@ -11,76 +29,7 @@ >>>>>   # error "unknown ARM variant" >>>>>   #endif >>>>> >>>>> -#define BUG_FRAME_STRUCT >>>>> - >>>>> -struct bug_frame { >>>>> -    signed int loc_disp;    /* Relative address to the bug >>>>> address >>>>> */ >>>>> -    signed int file_disp;   /* Relative address to the >>>>> filename */ >>>>> -    signed int msg_disp;    /* Relative address to the >>>>> predicate >>>>> (for ASSERT) */ >>>>> -    uint16_t line;          /* Line number */ >>>>> -    uint32_t pad0:16;       /* Padding for 8-bytes align */ >>>>> -}; >>>>> - >>>>> -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) >>>>> -#define bug_file(b) ((const void *)(b) + (b)->file_disp); >>>>> -#define bug_line(b) ((b)->line) >>>>> -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) >>>>> - >>>>> -/* Many versions of GCC doesn't support the asm %c parameter >>>>> which >>>>> would >>>>> - * be preferable to this unpleasantness. We use mergeable >>>>> string >>>>> - * sections to avoid multiple copies of the string appearing >>>>> in >>>>> the >>>>> - * Xen image. BUGFRAME_run_fn needs to be handled separately. >>>>> - */ >>>> >>>> Given this comment ... >>>> >>>>> -#define BUG_FRAME(type, line, file, has_msg, msg) do >>>>> {                      \ >>>>> -    BUILD_BUG_ON((line) >> >>>>> 16);                                             \ >>>>> -    BUILD_BUG_ON((type) >= >>>>> BUGFRAME_NR);                                    \ >>>>> -    asm >>>>> ("1:"BUG_INSTR"\n" >>>>> >>>>> \ >>>>> -         ".pushsection .rodata.str, \"aMS\", %progbits, >>>>> 1\n"                \ >>>>> -         "2:\t.asciz " __stringify(file) >>>>> "\n"                               \ >>>>> - >>>>> "3:\n" >>>>> >>>>> \ >>>>> -         ".if " #has_msg >>>>> "\n"                                               \ >>>>> -         "\t.asciz " #msg >>>>> "\n"                                              \ >>>>> - >>>>> ".endif\n" >>>>> >>>>> \ >>>>> - >>>>> ".popsection\n" >>>>> >>>>> \ >>>>> -         ".pushsection .bug_frames." __stringify(type) ", >>>>> \"a\", >>>>> %progbits\n"\ >>>>> - >>>>> "4:\n" >>>>> >>>>> \ >>>>> -         ".p2align >>>>> 2\n"                                                     \ >>>>> -         ".long (1b - >>>>> 4b)\n"                                                \ >>>>> -         ".long (2b - >>>>> 4b)\n"                                                \ >>>>> -         ".long (3b - >>>>> 4b)\n"                                                \ >>>>> -         ".hword " __stringify(line) ", >>>>> 0\n"                                \ >>>>> - >>>>> ".popsection"); >>>>> >>>>> \ >>>>> -} while (0) >>>>> - >>>>> -/* >>>>> - * GCC will not allow to use "i"  when PIE is enabled (Xen >>>>> doesn't >>>>> set the >>>>> - * flag but instead rely on the default value from the >>>>> compiler). >>>>> So the >>>>> - * easiest way to implement run_in_exception_handler() is to >>>>> pass >>>>> the to >>>>> - * be called function in a fixed register. >>>>> - */ >>>>> -#define  run_in_exception_handler(fn) do >>>>> {                                  \ >>>>> -    asm ("mov " __stringify(BUG_FN_REG) ", >>>>> %0\n"                            \ >>>>> - >>>>> "1:"BUG_INSTR"\n" >>>>> >>>>> \ >>>>> -         ".pushsection .bug_frames." >>>>> __stringify(BUGFRAME_run_fn) >>>>> ","       \ >>>>> -         "             \"a\", >>>>> %%progbits\n"                                 \ >>>>> - >>>>> "2:\n" >>>>> >>>>> \ >>>>> -         ".p2align >>>>> 2\n"                                                     \ >>>>> -         ".long (1b - >>>>> 2b)\n"                                                \ >>>>> -         ".long 0, 0, >>>>> 0\n"                                                  \ >>>>> -         ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) >>>>> );             \ >>>>> -} while (0) >>>>> - >>>>> -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, >>>>> "") >>>>> - >>>>> -#define BUG() do >>>>> {                                              \ >>>>> -    BUG_FRAME(BUGFRAME_bug,  __LINE__, __FILE__, 0, >>>>> "");        \ >>>>> - >>>>> unreachable();                                              \ >>>>> -} while (0) >>>>> - >>>>> -#define assert_failed(msg) do >>>>> {                                 \ >>>>> -    BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, >>>>> msg);     \ >>>>> - >>>>> unreachable();                                              \ >>>>> -} while (0) >>>>> +#define BUG_ASM_CONST   "c" >>>> >>>> ... you should explain in the commit message why this is needed >>>> and >>>> the >>>> problem described above is not a problem anymore. >>>> >>>> For instance, I managed to build it without 'c' on arm64 [1]. But >>>> it >>>> does break on arm32 [2]. I know that Arm is also where '%c' was >>>> an >>>> issue. >>>> >>>> Skimming through linux, the reason seems to be that GCC may add >>>> '#' >>>> when >>>> it should not. That said, I haven't look at the impact on the >>>> generic >>>> implementation. Neither I looked at which version may be affected >>>> (the >>>> original message was from 2011). >>> You are right that some compilers add '#' when it shouldn't. The >>> same >>> thing happens with RISC-V. I am a bit confused with this answer. My point was that on at least on Arm 32-bit we need to use 'c' otherwise it breaks. AFAIU, this is not the same problem on RISC-V... >> >> RISC-V doesn't know of a '#' prefix, does it? '#' is a comment >> character >> there afaik, like for many other architectures. > It doesn't and for RISC-V it's a comment character. > > afaik '%c' is needed to skip prefix('sign' ) (# or $ ( in case of > x86)). > > I mean that RISC-V doesn't put anything before immediate so there is no > need to use %c as we don't need to skip prefix/'sign' before immediate > but if start to use '%c' it will cause an compiler issue. ... because here you say it will break when using 'c'. Did I miss anything? Anyway, it sounds like to me that the default definition in xen/bug.h should be using 'c' rather than been empty because this seems to be the more common approach. To reduce the amount of patch to resend, I was actually thinking to merge patch #1-3 and #5 (so leave this patch alone) and modify the default in a follow-up. Any thoughts? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Apr 05 18:11:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 18:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518596.805325 (Exim 4.92) (envelope-from ) id 1pk7az-0003Cw-Dy; Wed, 05 Apr 2023 18:10:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518596.805325; Wed, 05 Apr 2023 18:10:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7az-0003Cp-95; Wed, 05 Apr 2023 18:10:57 +0000 Received: by outflank-mailman (input) for mailman id 518596; Wed, 05 Apr 2023 18:10:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7ay-0003Cd-7B; Wed, 05 Apr 2023 18:10:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7ay-0003H9-3P; Wed, 05 Apr 2023 18:10:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7ax-0002SL-JK; Wed, 05 Apr 2023 18:10:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk7ax-0004A0-Is; Wed, 05 Apr 2023 18:10:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/1i52yX6gRlUMzxSw4N/F5u5P6Jux3QbIj5h4caLDgg=; b=ZVfxs7BGTfkDUXP1j5YOOZ5LYl Xz2tReEcoPrYPn1778qw2c5O0AdtryNrz54oEaPSbTOi2F9g7StM0AMs+a6RSmrz4OLhR5pryD3FC wtfcEDmTTa6VFydn7XDveRi4KSMqaDzCNjmmszO7eGwuvegHF03NmvdEjoP8cD5ubykk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180147: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=a56833e47a76e406c62ea0531a99ca199ad5b00a X-Osstest-Versions-That: libvirt=d292ddf1cc268bdd8a494f8e7ce76dc3445c26ab From: osstest service owner Date: Wed, 05 Apr 2023 18:10:55 +0000 flight 180147 libvirt real [real] flight 180158 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180147/ http://logs.test-lab.xenproject.org/osstest/logs/180158/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180158-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt a56833e47a76e406c62ea0531a99ca199ad5b00a baseline version: libvirt d292ddf1cc268bdd8a494f8e7ce76dc3445c26ab Last test of basis 180134 2023-04-04 04:20:21 Z 1 days Testing same since 180147 2023-04-05 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git d292ddf1cc..a56833e47a a56833e47a76e406c62ea0531a99ca199ad5b00a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 05 18:11:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 18:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518602.805334 (Exim 4.92) (envelope-from ) id 1pk7bn-0003la-QW; Wed, 05 Apr 2023 18:11:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518602.805334; Wed, 05 Apr 2023 18:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7bn-0003lT-Ma; Wed, 05 Apr 2023 18:11:47 +0000 Received: by outflank-mailman (input) for mailman id 518602; Wed, 05 Apr 2023 18:11:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7bm-0003lJ-FS; Wed, 05 Apr 2023 18:11:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7bm-0003Ie-Dy; Wed, 05 Apr 2023 18:11:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7bl-0002T1-Vx; Wed, 05 Apr 2023 18:11:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk7bl-0004dG-VQ; Wed, 05 Apr 2023 18:11:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XvqHbodCn/9x5CeTWKvxkE+I5MSt9fM5mMCGSYVbKsM=; b=v/Z9SOPegX+4hZ98+bubbwUvx+ DEbZqjtoydOqsZX6tfQtNsyuF1+xe6Bl8cwpy64lItPXGOmP6OzLfM4HLu2HsDd4hGb2gf0pqANr3 TEm92+VGe8g/baHX/vK8Ki+zD+vt0dDT+qW8S1SPVG/fDIyRiR9D8Duf/arEIToKmA4Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180156: all pass - PUSHED X-Osstest-Versions-This: ovmf=a56ee36c494cb1dfe795259b2cba706ef55b5212 X-Osstest-Versions-That: ovmf=cdd79996c217805a5bd67bb0c0e4ca05474ef92e From: osstest service owner Date: Wed, 05 Apr 2023 18:11:45 +0000 flight 180156 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180156/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a56ee36c494cb1dfe795259b2cba706ef55b5212 baseline version: ovmf cdd79996c217805a5bd67bb0c0e4ca05474ef92e Last test of basis 180150 2023-04-05 09:43:16 Z 0 days Testing same since 180156 2023-04-05 16:13:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git cdd79996c2..a56ee36c49 a56ee36c494cb1dfe795259b2cba706ef55b5212 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 05 18:48:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 18:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518610.805343 (Exim 4.92) (envelope-from ) id 1pk8Ar-0007M5-IN; Wed, 05 Apr 2023 18:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518610.805343; Wed, 05 Apr 2023 18:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk8Ar-0007Ly-Fe; Wed, 05 Apr 2023 18:48:01 +0000 Received: by outflank-mailman (input) for mailman id 518610; Wed, 05 Apr 2023 18:48:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk8Ar-0007Lo-22; Wed, 05 Apr 2023 18:48:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk8Ar-0004VU-0r; Wed, 05 Apr 2023 18:48:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk8Aq-0003JA-Le; Wed, 05 Apr 2023 18:48:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pk8Aq-0005yO-LB; Wed, 05 Apr 2023 18:48:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KovrP06rUPrcL/p1LV/clgXy5tUXDJ7YChfuq7BDDgg=; b=Z7GfN3rDtgOiIDI+99iUuh9zuY 4rk4VEiTTFI0smyJCu2BYZWvtbgKY/EP0xhxOtPLI+9Vaf9qQd5dqfyWFqcPYdr06dnUh0wAR5GjS L6tj1f1y7XY+SbIFGnXG3yHfKT5nvQfcgRkYIKgf3l+YG12ZFk0DUSwh16FRaIHpjLYs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180157: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=55c6d4e2257ca8aabb15232f696ede49642efa3c X-Osstest-Versions-That: xen=48d76e6da92f9ef76c8468e299349a2f698362fa From: osstest service owner Date: Wed, 05 Apr 2023 18:48:00 +0000 flight 180157 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180157/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 55c6d4e2257ca8aabb15232f696ede49642efa3c baseline version: xen 48d76e6da92f9ef76c8468e299349a2f698362fa Last test of basis 180155 2023-04-05 13:01:51 Z 0 days Testing same since 180157 2023-04-05 17:01:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 48d76e6da9..55c6d4e225 55c6d4e2257ca8aabb15232f696ede49642efa3c -> smoke From xen-devel-bounces@lists.xenproject.org Wed Apr 05 19:52:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 19:52:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518616.805354 (Exim 4.92) (envelope-from ) id 1pk9Ad-0006Ff-8Q; Wed, 05 Apr 2023 19:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518616.805354; Wed, 05 Apr 2023 19:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk9Ad-0006FY-51; Wed, 05 Apr 2023 19:51:51 +0000 Received: by outflank-mailman (input) for mailman id 518616; Wed, 05 Apr 2023 19:51:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk9Aa-0006FS-Ri for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 19:51:49 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ac0d714-d3eb-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 21:51:46 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 15:51:37 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6114.namprd03.prod.outlook.com (2603:10b6:610:b9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 19:51:35 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 19:51:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ac0d714-d3eb-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680724306; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=h5dPrDhv3AkJwZ5rc0F3+4lMFU5MOn9MEBGjaaxk9aw=; b=QY8ONM94vGqwqVwjcFrpqOPEAp9mF36rYR3AykwcZj3F+Oq7MuzA1IIn lYGO6pxluhcWprf3TJLHaKYeyTiK+vFpJ4tmjl9K5es2IUphIbOGhs5UP N97pWj2pK32yAYNofttg/aoyv7DT2icOPybapK+zhVUTPIQmeLFavXa/T 0=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 103260996 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LEqC5aLUq8ykc4N2FE+R/JQlxSXFcZb7ZxGr2PjKsXjdYENS0TAAy zMeCGuAMquKZ2ehft53PY/joxlVvcKDn9VlTQJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5SDEBu7 PgpcAwVUQyZpseI4rbrT8dz05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMk2Sd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHugAtxKRezmnhJsqEWNhVwpUVowbgKcntu5iU6uWOJtI kNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4J5oflqYRq1BbXFI88T+iyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:BcwX1qtbORdCxu2Wj+vNn/NK7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.98,321,1673931600"; d="scan'208";a="103260996" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqRYTh4Wm3OF383lfTbU6dHQfPP/bE6RWVJBEXvamITSNb8vHBvp0yFK73MRbYLEw4CfYG8Wsn1s/ImNFYXLz28PHlikwtnVHXHsOxJbIrjxTgDYKJtWBqgJDDTnYoTRjNwjLXnw2jiWbQJJv1opDCljSy3zUqyhORNoUC3gRaTSFKNeu6OiSAmaN5lMYL/4sMvOhPArIOXY7HPInf9WINrXcehncqy/75RcqUPl7xpqyl8bRlpw0LujkqJ+VmRsc65sS7ucRW+s+drVSJL+cRKhEKZdnYDxuax4LYH6NLo+3gZ6WngW51sQym9A+id1kgLc8dsqrb7AkNkFl6c5bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xqaxVbZHPGQdakwydD81MgkRk/5WO4ZaS7WH5LX8MG4=; b=EKqKLwHcMJ8J+Lq2yvlYQ8R7NIy7nHizAZUFf1DPMVga+pA6tgZeGDYOqTisbW7zir7Ie4J5YaWY12XTF01xAPOAt4/5tbxcpw36zhaUKrDScD4mFJkb2b6LEMC5qSPhBZ0V/TvRmG0o7NfnK9N204LisWbywvZdvhtkPt2qdB5KazFdKOOUsuAJW3+EybPEnwz7DU4Y53tYbX1YSKAW+5u4RRy0eaRmdjtj3udlnppbfadgCska8FPkFi5CBEP00bV10F5NYvMAt9OrYhwpUn65JbLRj76ZQ2zjAT/F5AiXIan/ooBwi7lRlZNXkSQpJHOI4tXV+y4UnbP3rLzcvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xqaxVbZHPGQdakwydD81MgkRk/5WO4ZaS7WH5LX8MG4=; b=m7QbxSSLQ/OebYrkcmuBNHxXxZMZDjyaBYLP41ZhEaM8pNjFLy0cnWydq9yJ4enWsh+h50/AdLbas0ii2sGBuJ+k6MaepdlPuN7lEcFFCW1VhP+JH44HejfpO8XCQYBVZ8hmVUILYbGS7tJqMug2pGKu1bNqBQt8LGz5yqJSR68= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 5 Apr 2023 20:51:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 3/3] x86/treewide: Drop the TRAP_* legacy names Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> <20230220115956.1522728-4-andrew.cooper3@citrix.com> <1684ac85-f9ac-a57e-9529-f2e09f6f81ff@suse.com> In-Reply-To: <1684ac85-f9ac-a57e-9529-f2e09f6f81ff@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0388.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6114:EE_ X-MS-Office365-Filtering-Correlation-Id: 3fd15747-8ce3-438f-14fd-08db360f2858 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Roy2HTV+3dydpawaMOsbr0tAO+O70Lm2tQKzQAYr09j9QpZEfd6xa4SEG7zbW4qkQOdze9e0sslriuTxmpz2BHb7i4Q+9R1NpyBDWy7/MpFrZdAbVm2O9v74LHppc8R5TcYA2OiC9/+DUQuBu+4goOokJCPg8+bdEjjOoYRfs2kwCgxCLcuSPzJF0xz1HcpoENF1T23dCSNTKk4+TQc3ENjkDlHv0zZERkUCUt3XxSwtRx64AYeF3IpFAJvbJ0X8zplKsiEmWncAR15Trpr2Yy/K4I8zbHhWkzzGlFGrSDr/fzgewvxgqH0OyBULkLSnFl/4mZ2ypVStTIETjkGGod5R4uj57EopHlE7C2qJNWHEHOvb6TyWvx2hq9isXyt/9SoE1Pmm2Jfqgs73VkxCNfZ6+ORY7qZ4JdIz8/ti0wcq/XoDVpil81Y73hpVt6Clo9klPeSdiBf7cd9ZjtqwJkAH/LDMYRbVAKpZ8Ca46+WbCW8Kx8QHINZ1DY/bvENrjZR12SJkTna1Kkpav4CncaOyQaxZfoq3yti5XYJvFSUo3C/BGPFBLiuXsVS/Wgoo2HRchpLi3ODcBun3wWNJJA763KIO6kubNnGX6mGsxO/CbpfmxfGAicA59fFFSdqEjHTdLGduGBHA5qlkx+ynw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199021)(31686004)(6666004)(83380400001)(2616005)(186003)(4326008)(53546011)(6512007)(6506007)(26005)(66556008)(31696002)(38100700002)(66476007)(6916009)(8676002)(2906002)(82960400001)(66946007)(41300700001)(316002)(478600001)(54906003)(5660300002)(86362001)(8936002)(36756003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGVtaUowaExWN0R6ZlArejJXc2UvT2xJdTlnYjk0T2R0RU1WeXRwWXdMQzFl?= =?utf-8?B?eWZ5T3BtclNJUzYxWno3U0JObzM3TFhyR2cwTFBraTU2Vjg5Y3pJWWlvZ3RB?= =?utf-8?B?d1VyUFVQKzNOcFNPTkVjUk5FVVhIMHgwOFpuUW5od2k3K3BGZ2M1TlFGencv?= =?utf-8?B?WDJKR2VSa1hWa2JFVlVUZE92ZWtqQ3NNR092WnBENVhBL0l1aG1UNm8xZWtX?= =?utf-8?B?U1JWbitZRGYwL1lsSnpkOFdoUGVoQSt1aWNCaTVzVTFDZzlsbG8yWU5wb0gv?= =?utf-8?B?b1FUbXJXMHVvbU91Ukw2bEJVMW1qdmMyZ1RSK0krQ1prS0FuZ25QL1ZZSXVa?= =?utf-8?B?MWFsa25oZkJvUVFKdFEvOGRRK1ZpbCtEOCtHU3hsRTVUREdDcmYwTlRlV3Ft?= =?utf-8?B?Y3FON3NOVnhQeDdyZDFjb2hXMWxuRnhxbk5DQjJpY1dvVnFYWCt2N2VuMFpj?= =?utf-8?B?eFZFNmJKYjdTamVxNHJHeFlnazZmUGpjWkppamV4L2t0SnRFTi9NeElUczF5?= =?utf-8?B?Z0JlVzhJK3ltaUM5dVBZRlJ2ZE1KSVBrWDVmMjJwSUVqb1ZKMmFsQ1hOd1BD?= =?utf-8?B?ZUNLZDkxYUVhUE9lUVVTaHJJTU9UN1FGWUJKdGt0SnYxYzdJcVo2UHdhd2F2?= =?utf-8?B?dGV4d3BTbDBWUFErVzVPbWRtTGZsNkdydXJFL01mTlYwRTYrcWliUmlCLzB5?= =?utf-8?B?Vkhjc1Z6Nzh2WEVXbktBb0d2RjJBb2p4MzVSVmg1TU91a3VrOElFRWo4Kzhj?= =?utf-8?B?eFRKS0xuZnl4ZzZnSTVTSDhDUDlpQ2hVd1dZZjkxM3pSbHpRajNCR016cXB4?= =?utf-8?B?WUE5MXlyL3lTdkw2UnJ6TWt6MDNidjM3QXpLZ0wvR0FQaWpHZ1Y1VHFnRk1H?= =?utf-8?B?Q1ZNUXJlQ0FZQy8wd1JVWmg4elBSZnhaS3FGS3FvRTlyQXRGS1Fia2ZYUk4w?= =?utf-8?B?dkpoWm40cTdieVhOZUJnVng0eHVQaUx3RmFCUGRjSlM5L1BFeE9sblZmNk1L?= =?utf-8?B?TGJ2ekpzRU54WXovTXFPRHN3OFcycU1BZWxRU2x3OGRFQW1BVFRSV2txQ1V3?= =?utf-8?B?bXBVRmxCeEZ3REZlemFoYVF5cVIrSTVIZldCQ2Z0K2JVNU9DSG5BOUlnbjRM?= =?utf-8?B?elY0MHU0eStBa2toTFFDS2dveHNLT3lrQlQ2MVBxVmFsek14ZWM5WTFWTklt?= =?utf-8?B?OHlWWnBnaDBybGhObUw1WnpNZjVMMFlLZWJtaUY3OU4yNzhkY2FPVHdwK1VC?= =?utf-8?B?NnM0SVd6b0thMldzMU5lRWtPYU5iSmVZeDRxQXk1bHZmY3BGbUFPTDJWUFV0?= =?utf-8?B?L0plUkVycXNjOWNNSHJ2QTdVNllBM0dQZmg2TUtFVHpMalM4U0phVnFNeVVV?= =?utf-8?B?UkxGSVlWeFNDbVYzMHd4QmVHSTRYZXZmdUYvQ2tFM3hCMWhNbzloNGlHTWR1?= =?utf-8?B?a1Fmd2xpOW1pNDduNHFGbW1rU2k3MXRsc1BIaFZubjkrWUpIOVNNVlJia3pS?= =?utf-8?B?VVQ3V2RhWDZiQVhhK0VRcXl6SzBxZkhMUy9SdDU5SC9vOWlDN3RLVUE2OEhP?= =?utf-8?B?R3cwcldpQm5DREgvSkdGSXM3VGxlWnFJdzk1dDJ2WCsvU1BGdGFBaFJIa2x6?= =?utf-8?B?bXJ2K1ZaTnNFbE56ZnBDZlg3emlocm5HQUpMa1hTR21nSFd6QllrQUNaYWxa?= =?utf-8?B?M0lUQXd4QUltSzJXMkM5cXVYRkM0OFNyWFIrTThoeVFoeTZrMnp1ampYa3Ez?= =?utf-8?B?RElxb3dnaE1hS1dabDYvK0pWSUZpSDBsdTNBeEwrb1UyTHpTVDZDQVM4eWZT?= =?utf-8?B?L0xxQXFSNVBIRk41L1FmMit1OHdJcDlrOWpJYTcyc0dwOUNvWGRtOVA1c0Zn?= =?utf-8?B?WnFpemhkZDFwdkJ2cERZK0FTTW5IaGxTY0VRTzl1MkFhNkdVR0UvSDVyVmxJ?= =?utf-8?B?U2drM2VNK1ZpSk1vRGZMSmFGVkhRTEpEbXJ3RnQ2SCtnS0JRU3B6eHZwRy9H?= =?utf-8?B?aGcwamlSQlhPbDUwU0xZNDNyMFBLYXF1S0NOT2s1TkErdnIvWFE5bkZIWk1H?= =?utf-8?B?NVhqUEtMc2ZCK0ZlWkIzcndzNGNHVHJEKy8zWGZyaTVoQUVGaTYyeFdiSHJN?= =?utf-8?B?OGVXTG1POWZBY0F1Ym03SlpRSW1LK1JEZTAzeXBTOGJISkxtZ1IxVzlqaldi?= =?utf-8?B?dGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p4nSUsZql532w/eZe/RZZ2pAj8dRku0jUvdAzVRzIx8nBu182VhJT+r2oox9bYOey46AslGQTTLKGtYk15ao4p9dJFC+ONPafMNtkeaK6mlx9QS/DddkL4u08TathLMNyJBm6s6DREhv7hLS6iCD/bLcP5wUHimnK53bK6O3S6mlg+CRD6oXVami+CbqSGu+HGHnKjSqafhfdQjN+rdmV5BJLvyWapAqnPfIyqsvVpMrj9Q6v7z4QTCiTg8u+RNnH6hLFxiyCJunj+dpwIdtyRTAe9Ti4OUQtmCiuHdlc2NGXuxJn8CPbdXF4rAWJaw9rr0duw+cgmFy0xUth7wXhJsnUv5jyn+yB0UY8LxaC4a2PM5UqASM+ozNOjIgj3AowUHtZ7gmwmXpJCffSFWRjKnoCWBO50BcBlz8D/oE/dVQxQrkJpQFivy+GIEsRt+P9tloVL8X2rXsB7YsOEbnc0FODmP8yD5/PMwuA6+ZUwsuHszs6dj0oHNI4BgIAjS2u8d8JDE3QWXXMXqdDXy76hyIvKIXQ5hBpNCNud3s/L3K1KYZvEsRarysxwrH+yhk7NQLc/jAavg35dqO41TuQ5P0Ped6zd9na6rA2N7HtvhgjbVS81DvoRa4Cr27U2YqKAiCM90qFgejtwQ5XsjePRSFtrtwGwgYzifY1J6L/wa0r183FHD+3cLavkEpKku0Sk80Tr5xWq8G5Pg35xmB0jyEGnZVtspDnQ+p1k2ohkKFolw9UntUR4V3CGtqgdDLG5qi3v2LnoE874NvXCM8IWSxuRaCKq+h/C1VD7Lm5whYdjqGP/LtIgrZktktJ4JT X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fd15747-8ce3-438f-14fd-08db360f2858 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 19:51:34.6495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9hnIYtHOgQybaIJXyLbH9tSRzYg3tkRxsRhWJDzROtSn+IaKmNjLlVrBMsHQhRbduQeRxdYKzcQ0ZCfZMVa7Ih8fhOfzwxyaaBRdHDA1LU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6114 On 21/02/2023 1:10 pm, Jan Beulich wrote: > On 20.02.2023 12:59, Andrew Cooper wrote: >> We have two naming schemes for exceptions - X86_EXC_?? which use the >> archtiectural abbreviations, and TRAP_* which is a mix of terminology and >> nonstandard abbrevations. Switch to X86_EXC_* uniformly. >> >> No funcational change, confirmed by diffing the disassembly. Only 7 binary >> changes, and they're all __LINE__ being passed into printk(). >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. Given that this is proving a pain to rebase, I've pulled it out on its own and committed it.  I'll rebase patches 1 and 2 over this at some other point. >> --- a/xen/arch/x86/mm/shadow/multi.c >> +++ b/xen/arch/x86/mm/shadow/multi.c >> @@ -2745,9 +2745,9 @@ static int cf_check sh_page_fault( >> * stream under Xen's feet. >> */ >> if ( emul_ctxt.ctxt.event.type == X86_EVENTTYPE_HW_EXCEPTION && >> - ((emul_ctxt.ctxt.event.vector == TRAP_page_fault) || >> - (((emul_ctxt.ctxt.event.vector == TRAP_gp_fault) || >> - (emul_ctxt.ctxt.event.vector == TRAP_stack_error)) && >> + ((emul_ctxt.ctxt.event.vector == X86_EXC_PF) || >> + (((emul_ctxt.ctxt.event.vector == X86_EXC_GP) || >> + (emul_ctxt.ctxt.event.vector == X86_EXC_SS)) && >> emul_ctxt.ctxt.event.error_code == 0)) ) >> hvm_inject_event(&emul_ctxt.ctxt.event); >> else > Entirely unrelated to your change, but seeing that this piece of code is > being touched: Aren't we too lax here with #PF? Shouldn't we refuse > propagation also for e.g. reserved bit faults and insn fetch ones? Maybe > even for anything that isn't a supervisor write? Imagine a guest does a CMPXCHG16B which straddles a page boundary, with the lower part hitting a shadow page table, and the higher half hitting a mapping that the guest has mapped with RSVD bits in the PTE. In this scenario, there would be a VMExit type PF (write to a page which is actually read-only because it's a shadowed pagetable), and during the course of emulation we'd permit the lower half, then encounter PF[Rsvd] for the second half. And the correct action here is genuinely to pass PF[Rsvd] back to the guest.  So no, filtering on Rsvd is not the appropriate course of action.  Similarly for a fetch fault, the guest could genuinely have paged out the frame we're interested in in the time we've been spending in the sh_fault() handler. Whether the else path, choosing UNHANDLEABLE and unshadowing the frame is really the right course of action, is a different question...  I think the current behaviour is safe, and its not as if it's a codepath worth optimising these days. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Apr 05 20:11:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 20:11:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518621.805363 (Exim 4.92) (envelope-from ) id 1pk9U0-0000Lo-TG; Wed, 05 Apr 2023 20:11:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518621.805363; Wed, 05 Apr 2023 20:11:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk9U0-0000Lh-Q5; Wed, 05 Apr 2023 20:11:52 +0000 Received: by outflank-mailman (input) for mailman id 518621; Wed, 05 Apr 2023 20:11:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk9U0-0000Lb-9B for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 20:11:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19985bcf-d3ee-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 22:11:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9660962810; Wed, 5 Apr 2023 20:11:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADAFAC433EF; Wed, 5 Apr 2023 20:11:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19985bcf-d3ee-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680725509; bh=RtwX6KJxYQmKc5eE6Ge2DG54ynisAFNybPH8hjW2Myw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dHKfeTPAenu64KkcwFR/WKz+RNZhtj4dMwwpBM3wvHCNU/ZTyHF9/pkW9hknVc0cZ w7fp/t1tuFEZE/K5DTqgSzyGrz1qcWh7zusMfq4giOpy8g4OyLvojp9PCs9I6WB4rK clFPb/fo8eu8ihkbsVTM4o62kBSyBDbIXU0jPgtBXm9exOFcJgVYeiMbQUYkfN6EK9 XV0ezMaCDooYBPeJf/A5iyTsnCn5G67bVixFgikYhvxBzUA3VpHE5+iVnBVoFC2sqe xqiRjZGTB6oUN9IMzacEfdZ6ZznSh88QQVnCkDLmIu9+eOrCekx5YQQmw2U3RHRDgl zr5da0P/R5hug== Date: Wed, 5 Apr 2023 15:11:47 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Andrew Lunn , Thomas Bogendoerfer , Stefano Stabellini , Yoshinori Sato , Oleksandr Tyshchenko , Gregory Clement , Richard Henderson , Russell King , Nicholas Piggin , Bjorn Helgaas , Rich Felker , Ivan Kokshaysky , John Paul Adrian Glaubitz , Miguel Ojeda , Matt Turner , Anatolij Gustschin , "David S. Miller" , Sebastian Hesselbarth Subject: Re: [PATCH v8 5/7] PCI: Allow pci_bus_for_each_resource() to take less arguments Message-ID: <20230405201147.GA3637852@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 05, 2023 at 02:50:47PM +0300, Andy Shevchenko wrote: > On Thu, Mar 30, 2023 at 07:24:32PM +0300, Andy Shevchenko wrote: > > Refactor pci_bus_for_each_resource() in the same way as it's done in > > pci_dev_for_each_resource() case. This will allow to hide iterator > > inside the loop, where it's not used otherwise. > > > > No functional changes intended. > > Bjorn, this has wrong author in your tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=resource&id=46dbad19a59e0dd8f1e7065e5281345797fbb365 I botched it, sorry, should be fixed now. Bjorn From xen-devel-bounces@lists.xenproject.org Wed Apr 05 20:18:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 20:18:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518626.805374 (Exim 4.92) (envelope-from ) id 1pk9ab-00010p-Iw; Wed, 05 Apr 2023 20:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518626.805374; Wed, 05 Apr 2023 20:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk9ab-00010i-GI; Wed, 05 Apr 2023 20:18:41 +0000 Received: by outflank-mailman (input) for mailman id 518626; Wed, 05 Apr 2023 20:18:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk9aa-00010c-05 for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 20:18:40 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b1f14d8-d3ef-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 22:18:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8C1A62A31; Wed, 5 Apr 2023 20:18:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF579C433EF; Wed, 5 Apr 2023 20:18:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b1f14d8-d3ef-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680725914; bh=nzqjLaTJey3sRM+1TqQcKEYWams7IVp4kAG1Ou4QbaQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=qSIFfK6lOkdOAB5LY9zLp6kglpMt1j7LNegofExp0NbD3DdGJu2FIQSd9fKDakYSF 8EdaJODqwbg6kctJMgL0riv0zeo2GlzJNTyce/xBoaGt5wkbyslXtmEQr79jETD5VN JkGR/SuDh0S5XNaO9WvVcUE8aLyF+fq2KHagkNoYCPN/ufYZsMFzIEL8TOwxz22rru dTfc7KYc7iXQfdVOTiFqncjiOZ6vNACqFFlXmfZkUJ6vh6opIHeXG2F88mLt2+N1/j qSW8PkxMlDLNSe4zXOh05GwayXmUNnmLRiK0jPqk3fXDd1WbPKGLoR9/9OHb8FIaNI uOrsrDeBHNVGg== Date: Wed, 5 Apr 2023 15:18:32 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users Message-ID: <20230405201832.GA3638070@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 05, 2023 at 11:28:27AM +0300, Andy Shevchenko wrote: > On Tue, Apr 04, 2023 at 11:11:01AM -0500, Bjorn Helgaas wrote: > > On Thu, Mar 30, 2023 at 07:24:27PM +0300, Andy Shevchenko wrote: > > > Provide two new helper macros to iterate over PCI device resources and > > > convert users. > > > > > > Looking at it, refactor existing pci_bus_for_each_resource() and convert > > > users accordingly. > > Applied 2-7 to pci/resource for v6.4, thanks, I really like this! > > Btw, can you actually drop patch 7, please? Done. > > I omitted > > > > [1/7] kernel.h: Split out COUNT_ARGS() and CONCATENATE()" > > > > only because it's not essential to this series and has only a trivial > > one-line impact on include/linux/pci.h. > > I'm not sure I understood what exactly "essentiality" means to you, but > I included that because it makes the split which can be used later by > others and not including kernel.h in the header is the objective I want > to achieve. Without this patch the achievement is going to be deferred. > Yet, this, as you have noticed, allows to compile and use the macros in > the rest of the patches. I haven't followed the kernel.h splitting, and I try to avoid incidental changes outside of the files I maintain, so I just wanted to keep this series purely PCI and avoid any possible objections to a new include file or discussion about how it should be done. From xen-devel-bounces@lists.xenproject.org Wed Apr 05 20:45:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 20:45:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518634.805384 (Exim 4.92) (envelope-from ) id 1pkA06-0004Vn-Ol; Wed, 05 Apr 2023 20:45:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518634.805384; Wed, 05 Apr 2023 20:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkA06-0004Vg-LI; Wed, 05 Apr 2023 20:45:02 +0000 Received: by outflank-mailman (input) for mailman id 518634; Wed, 05 Apr 2023 20:45:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkA05-0004Va-IR for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 20:45:01 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9d15acb-d3f2-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 22:44:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9d15acb-d3f2-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680727499; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eZkTQLlgPViTbuqQR+5y7JsM486poKpDOSK+FX/m5MU=; b=MMa1x3ZRZTC0E6IsB9dBmwPGG2jPPZuf9Yv/rWpYOQtX8SoC5+2aSvek 9SPNS3TiwuD9mkWqzL9W3LbK9n6NmdmS9a8TKHQUvHDK1ddDlXh67XXj9 dudx8sWL+4NlnWIjUwi1CJV4/UWEPKJ+K4BXF/p7u4UNBcZgIACa7crqO o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103266266 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:V8DxZ6340MN2FGuC9PbD5axxkn2cJEfYwER7XKvMYLTBsI5bpzVVm GUbXG/QPquKY2Xxe9x3at6x/BwOvMLSy4UySQQ+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfE3sVr fs4FTs2VT+guu2p+fGDWPdDv5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJ0OxBjG/ DyYl4j/KjM/HsGv8R+UzlO9hrWWvR39Aq4ACZTto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jY+cddNF+wx6CmW17HZpQ2eAwAsUTppeNEg8sgsSlQXO kShxo2zQ2Y16fvMFCzbr+3Pxd+vBcQLBX0YPncDbTYO2OLMg7w8kSuMdsR9P5fg27UZBgrML yC2QDkW3utD1ZFRiv/mpjgrkBr3+MGXE1ddChH/Gzv8s1gnPNPNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83oJrW7FF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPdLpVJ17k/m/SI25PhwxUjapSsEoHDJrAQk0PRLAt4wTuBNEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqLH/jTlk33uYdykVbJEd/pxnPSNLFmhE5FyS2Jm +ti2zyikEUDCreuPXiHqub+7zkidBAGOHw/kOQPHsbrH+asMD1J5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:+XmAyaM7CqPesMBcTs2jsMiBIKoaSvp037Eqv3oedfUzSL3+qy nOpoV+6faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSi7cKqAeAJ8SRzIFgPN 9bAspDNOE= X-IronPort-AV: E=Sophos;i="5.98,321,1673931600"; d="scan'208";a="103266266" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts Date: Wed, 5 Apr 2023 21:44:23 +0100 Message-ID: <20230405204423.2113418-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This removes raw number manipulation, and makes the logic easier to follow. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/svm/svm.c | 4 ++-- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 8d8b250101ce..90c2f89c1b0d 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1740,7 +1740,7 @@ static void svm_vmexit_do_cr_access( cr = vmcb->exitcode - VMEXIT_CR0_READ; dir = (cr > 15); cr &= 0xf; - gp = vmcb->exitinfo1 & 0xf; + gp = vmcb->ei.mov.gpr; rc = dir ? hvm_mov_to_cr(cr, gp) : hvm_mov_from_cr(cr, gp); @@ -2961,7 +2961,7 @@ void svm_vmexit_handler(void) case VMEXIT_CR0_READ ... VMEXIT_CR15_READ: case VMEXIT_CR0_WRITE ... VMEXIT_CR15_WRITE: - if ( cpu_has_svm_decode && (vmcb->exitinfo1 & (1ULL << 63)) ) + if ( cpu_has_svm_decode && vmcb->ei.mov.mov_insn ) svm_vmexit_do_cr_access(vmcb, regs); else if ( !hvm_emulate_one_insn(x86_insn_is_cr_access, "CR access") ) hvm_inject_hw_exception(X86_EXC_GP, 0); diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index b809e85507aa..77e3bd9aa048 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -450,6 +450,11 @@ struct vmcb_struct { uint64_t nrip; } io; + struct { + uint64_t gpr:4; + uint64_t :59; + bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ + } mov; struct { uint16_t sel; uint64_t :48; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 21:21:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 21:21:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518641.805394 (Exim 4.92) (envelope-from ) id 1pkAZA-0000aI-Fg; Wed, 05 Apr 2023 21:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518641.805394; Wed, 05 Apr 2023 21:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAZA-0000Zv-CQ; Wed, 05 Apr 2023 21:21:16 +0000 Received: by outflank-mailman (input) for mailman id 518641; Wed, 05 Apr 2023 21:21:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAZ8-0000Zn-VU for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 21:21:15 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c89d1104-d3f7-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 23:21:12 +0200 (CEST) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 17:21:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5458.namprd03.prod.outlook.com (2603:10b6:208:29d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 21:21:05 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 21:21:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c89d1104-d3f7-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680729672; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=zgconbBhy1S8kc6pf8iqApafjGUU32fKIG1lZsK0EeY=; b=ax6u0s9DmOvQ5TDljPdGxd41NBpGX97+vaS97t0K/ZtbnZz20a5WYKhw X6RwQZ/jfQ9CG290CD70qPIM30ciXLYpqNidQZKwziUdlt6TJ4A22c9ca uYa21iS6aVbfCdnI1Dh3mHPevkiLse3JOzOZdL5VruLvSihSoYgLbsMtR w=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 104387275 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:43ERhq/YIhk7ftVUjDVIDrUDZH+TJUtcMsCJ2f8bNWPcYEJGY0x3z mocDWrUM67eamvwfNgjaoyy8hlUsJfdzdJnHlE5qio8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagW5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklkt tNBFg4UfyqhlsWwzu6he+hoxf4seZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUuidABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpOT+3nrKE36LGV7lcIEho5ekernb68rlK5do1GM lQL0QN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc0TzE30 l6Cn/vyGCdi9raSTBq16bO8vT60fy8PIgcqZyAeShAey8L+u4x1hRXKJv5hDaq0g9vdCTz2h TeQo0AWnK4PhMQG06G6+1HvgD+2oJXNCAkv6W3qsnmN6wp4YMuuYNWu4F2CtPJYdt/GFx+Go WQOnNWY4KYWF5aRmSeRQeILWra0+/KCNz6aillqd3U8ywmQF7eYVdg4yFlDyI1Ba67opReBj JfvhD5s IronPort-HdrOrdr: A9a23:4Ny0ua26oZtyGDck/rppSAqjBEIkLtp133Aq2lEZdPU0SKGlfq GV7ZMmPHrP4gr5N0tOpTntAse9qDbnhP1ICOoqTNOftWvd2FdARbsKheffKn/bak/DH4Zmvp uIGJIObeEYY2IasS77ijPIb+rJwrO8gd+VbTG19QYSceloAZsQnjuQEmygYytLrJEtP+tCKH KbjPA33gaISDAsQemQIGIKZOTHr82jruOaXfZXbyRXkDVnlFmTmcXHLyQ= X-IronPort-AV: E=Sophos;i="5.98,322,1673931600"; d="scan'208";a="104387275" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alHUemjVDOP0BqV957UXGvCDGeZ//U9asoSfu5lFIMwrzvhNWy/oFP42qENwnTMquQfa7Yv1V/bjhCpTPsiEstqk/pOLJP7F48bR6rIpKobvZuLJSqgX0Ms1dZCBcl+Gj3hpjKcbwExI7kouvm+sGyzPjx8za9sN+++uVsX0/OY4ghev+yseJUAB66G2E2YgAH+tePEVoM5NQgROWpog7byHYRx4hWpid8iylVE/yggE6mng2bTcg40eaoReLtTH4fG1HBcOccF28ruJIFInISXQN0IgJs5TssQajwFZGBYN/yV3KlVW3TMsuiJElPGQgUQijvmkjCL1MxnDNuasuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgconbBhy1S8kc6pf8iqApafjGUU32fKIG1lZsK0EeY=; b=oCcnllttZKpyMJbbCZfXvSQIsTzZYcnJXMdqfOQtbiQEjL2TT10vS2uj8ntP0f9JbPfg5MzwUBnJBbHoWD9gmTqxUzJgzzT3w7uOLwwQ8HHqvOd44NHWB4UJAlnzorWjSR7SGHNhREahAXrT+m1lFaiG9P8BIR/KAh3jWJqxOCVDFDRWI/rXEqr0Yglozk9gw8f32ZX1x1DGq8WeCla5b+RbsHissMCq1cHWTXZDcc/+sfQQ4KEO+FCfuS9E3cxd+v7L4Vkfj1RkNE1Kea95Nhhw+25TbpE7/NEqjkdsTFLyTVoTuJX3Wj1H9ATnqwEGbrs7vLAcCT4CALabxwH7Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zgconbBhy1S8kc6pf8iqApafjGUU32fKIG1lZsK0EeY=; b=mu4DXo+6yoPkLhH7FIKC451Y1zbp83X1jdskym7haj3t/wFgJoY6heHsV1PxDt7GgV6FMU0SI70ys/M+WUkgO0Hk6P5ZhodNXaZOIoViqFyvmm9BHpzmqgd0mgPd7rKxyHf5EXw592+M6v8LFwdupkQgCmGwPTXhmXxrGO3BJHQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 5 Apr 2023 22:20:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v4 1/3] tools/xenctrl: add xc_get_cpu_version() Content-Language: en-GB To: Sergey Dyasli , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini References: <20230404160655.2354-1-sergey.dyasli@citrix.com> <20230404160655.2354-2-sergey.dyasli@citrix.com> In-Reply-To: <20230404160655.2354-2-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0036.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::24) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5458:EE_ X-MS-Office365-Filtering-Correlation-Id: 6117cd20-48cf-4cf9-d0a3-08db361ba9cf X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /Nxy0idh9GgKElM5mj760WyPzTHt2PouIm/1c5HhirtRcckDQNn1LjSp9Vq/VeKvg5mOkMGra5shPG5O+IiWu+pMQP+pG4sBTYmWjX0NPjmWThx0GHnvTXC+OgLCXgGlF+WyrWUEumylTlswmBTS/WQwQQVvqePjtSnkRiLqL9m1aA8dnVJbicjG4ELeNB6rVWIQcEntCyKU29mNQIJzcbfDsRHisxgjrVyj8f5Hf5Omo+oE3myZWwcwv1g6rrpGVRcj4ic+tRPRM0+FI70N3tQPIaJ4WP39G/a91YqjGzs+ENTGHP13CfTZONjufW9Z3AH9eMfqpoc2XAWjG19bsK6bnOnubIWM6EteCkgVYuvtzzN9h1TzbClIVaWcs//zcPFxyVJc26Zqz3qZcKtiVSbBOddAa87vsPfHSBE2f75kxjQucExiJNpKsfckNv99Qh9sOUuD4FX0jUD9uMwa0bNCqCwI8tz7aCrKZughHkMj9qk99T2ArI7FeXfrGtlGSMMf0g7g8U0RdNEXra6eij+wccItH+g5noZlcXWJSMmNQVN8JVYrQl8lyPzoDENeMkNWztI0OcrAFw60eX2igGNLsgEny7wawoxOOy5KUVcPZNUuXEEK0H+ikt5b1H9Lp5wNt69XGnYC2+86eLdytA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199021)(6486002)(4326008)(82960400001)(66476007)(66556008)(8676002)(66946007)(316002)(558084003)(2906002)(38100700002)(31696002)(36756003)(5660300002)(8936002)(478600001)(41300700001)(86362001)(7416002)(53546011)(54906003)(6512007)(6506007)(26005)(31686004)(186003)(2616005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0tqMFlwWTVCMTVQTktRYU8ybVVGRVBzVktucXZHdC9EMTM0ZVZ6clYrNysw?= =?utf-8?B?T1p3U2ZkYWJJT1Vrd05XQWRoRnRTd2RGTis1UWdEZkowcXdBUkRYaWNDalRN?= =?utf-8?B?MFB5SW9mcGJrdDNiL084Q2dPWkpDdXVLYUx5M0tkcVJ3Rm02cElDMGYzVFht?= =?utf-8?B?bFV5ck1YNW12WGxESEdXOVd4VkdLZmN3MTAvS243bUthd1V0YzM2bitTcEJW?= =?utf-8?B?L0tQVTBLV0FpcmliRityRXNWZXEyVE1NRHg5UVhURlRGbzBSKzBDdUpIVHM2?= =?utf-8?B?RmtoN3A4Yk1lUTJZTUc5cE5ZMTNIdE9aenZ5bHd1cjNVWnhnVkdlcGtmL3d3?= =?utf-8?B?YXBzSjcxRTd2WVZYR2dJQndCUHFQaVhocWVYZXBQaXphRHN5VDg5YlpFUXNX?= =?utf-8?B?S1d5R1ZDeVBBUm9KcEF2S3drS2xaSlVFMTVURDVkNUh3NmFWUFlvNnlGK0d2?= =?utf-8?B?d3R2dWNoLzBJcFFZUWtGZE1TWlBhT3JRRVFkdFZoanN3elNBanAwbHhkMTQ5?= =?utf-8?B?cUJOSnVkdjBrWG5QMGVCaHZRbkFIYXpZKzJQQzFtTFo1M0NYMTdnYk5mSVdJ?= =?utf-8?B?a2sra09pUmNlM3A1bmpMb2Zuc2JsT3l1Uzdyajc4TGZ4bGVrOEs3dzNyZEVQ?= =?utf-8?B?cFVkbU5tNlBUSGwyVXZqQlI1M0FSTmlWUFljMVFSNmFHMVJhUzQ0RWNISzRK?= =?utf-8?B?RlNGOHlZb2o2VFZBbmkzR0dEa2FlN1kzeXFDaWhiTnpUVC9BNDNWN3VnQkRP?= =?utf-8?B?NkZCQnZmelYrMk8rN1JRdERiR1crSWRITXVCVWdxT3hDMFVkbEVlbkl2T2Rv?= =?utf-8?B?RXVqOUtyRW5NN3FGNWg0a3kwMU5BRjRUSVp6NzhwZ1ExUDEreFV4bDF1SURC?= =?utf-8?B?YStjamNYWWlOSGFxNXp5eVpGNnNuVytIbFdWSkdMMkFxSlQ0cFJwb2NYa3NZ?= =?utf-8?B?NWdYbEhKT3ZFUlpZR21vaERSODVKWEV1c1ZISngrTWtMRm9oSGVyUDJVeFZZ?= =?utf-8?B?eWJtaUlKMG5LWlE5OTRuWVgvU21SdlFPbmhxRTg2N1c1ZFpyWEVKeGJKcUFS?= =?utf-8?B?UEFLbDV3aWJ3cDZHbjBhMTRXOVQxQzRkUytaR3dJcUdWYTF4Zitjejk1UTJE?= =?utf-8?B?RGI2MS9HUklUV1hGdVExanV6NitDc1lRUFB6LzdiZlpVR3FaTTdBdWxwV2ZX?= =?utf-8?B?SERuMDRqclRqd3JFdjB2a2ZWM2ZYZHVhYnRxZUFJQXNXMmdmWXVKWGpQb2ZM?= =?utf-8?B?ZHlBRVBlQ1IxSVhsaEJXZmgxMUpUS01qYUk5T2ZCMWdDK0V2THp2WDh5cmFQ?= =?utf-8?B?ZkVLS1RSZ1M0eG0rNkxZWkhQVkNxYmkyRkN0K01DRXhPNm4zM1RIUHJqbC8y?= =?utf-8?B?TzdsYXp4MnloNEVWU2o4b1IydnFDNmlLRlNRUCtXOXpMQ0dIcjRrN2RtUGpq?= =?utf-8?B?VTg4em10Z2s5UUwxb09RV2YrQnpBaHRnUlkybkp4NGpFdzNwUGNOTW1YSW5U?= =?utf-8?B?VHJtay92RzM5WWdrdmQ0cFEvMWhUQVZIOEMxeGxBeis1QTFYdVorNEI1L1kz?= =?utf-8?B?NFpZK3VaampPbUcvMGw4MkxjKy9CeGtTOXNnZmpDQzhIbHBPTTU0VkNFTVNG?= =?utf-8?B?Z3Z6L2U4b3BIR3hlRmY5ZUxNS0VESnpRaFptaENzRmVNR2Z3anNKR1lWSmNr?= =?utf-8?B?MjVBaUVDWmo5aGpnUE5VamxHMGhHTCtsL1liZDlSUkdlZGFRU3d5Ky9lcThh?= =?utf-8?B?M3NRTlQxRzVjSElPT1FSdnFoVnZ6bjlTZzc4SkM0aGRLUkUyaEdWQmhEcUpY?= =?utf-8?B?UmcxY0p4dUM5THFhaFp6Tm16cmJiVFpnYW1mZy9DTVltTHRyU1gvMmNRUWRT?= =?utf-8?B?ekJRWmZxa0tIV2VhUG5PWHloZnhEZVh3TUhjZTFXRXQzZkptZzQ4aktQUWpi?= =?utf-8?B?TjVnM09waHFxZ3FjZ0RSNnc4d05hWW4vRy9aM09TVlUrbFZvNUVidXM5ZDM3?= =?utf-8?B?T3JDMy8xd2Q4T3YyZUJCSXZJdHYzK2Q4a0RQMzRXendvUlBzZ2dpckw3bWZC?= =?utf-8?B?Y3p3bm5ZVTdrNGp3RGJQV29KdzBUUEg1ak1KeEZ2ci9vTUpqSkRvdVJ2SEZK?= =?utf-8?B?WmhIVWNpdHhqa1B0bVh2Ni9KZ29Qb2tuYUJ6R25vclZCSmFHNHZ4Vitza2V3?= =?utf-8?B?UkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hCjHlFqoph5inrOE4jG+qoKXCD5ZDk5WUuGaftmEeQazHCy0IMyw9uhWpG6UdHOIRE8xwj2f7V+WPLCjv6r4oQyPvH/vnkcjTwk47agoYsIqDw8XnA0zJ9bDcWFIYtFrHrk5BpxJFR882QS/eCAX2DfXtTpqCW6uPGj5l9r7KURnlmdNZAk4rKZGsIJ+UGTUgRXvp3s6vkpTAaLD9pVZuhf3VPbLHESP1MEOSknCCZGlJ5tuTBuhQDpQ+YCtRMzfMBAL+OlFEnVgy2JbbMvk8M8xNSKpP2Wt60TMEWP2ekMWkjeaoLI/VKQiaDQvQjeNVyC+m1q6pWFllwXXi4EpG1x7jdGn/ONiFJjEroyrugPMxDvsoLWe7zntp2tHBK4R+A7+XthHqYQYhRRdyW/emO+3JQQw8zvUK3oTquQsoRJA+qHo6ls/XHhQQXFvx63Teeib4dHG180F97tLK/mjzEAglWYlmDejTRQ4wn/xfHkOsVPOyUwD6UqANywU3fcHxMk5N7ijZapMeaCsfxa3FPhwTO9hvrNYOSewTM9xzLl7ERWjplF6owRfAgJF+/eFLLG+nlwyXLf0nXn6DjmNNQwRFmgJ1+5XNLrRY/R2rY40qNTMtJWQQYkkxrk6KRnLaYsBZ6d1d2+RkCp335KGUV4IAB78SiO9dwD8FGUnyQ0moQ1M6nSjmcMz/sh5MqATlhddwflpBUcVnVtMJMRZPm6W4PUMCAIlFzgzNmeyAuvJ4ztTxmNEOnVamftQCKJHbI49AFt2b2CowX1ldY72hxZFMzZqq/W/1RPbYVEedgtURrR1NCrTBDxtI4mgVBKVjbMOqSFDDnhzZZztfe+ycVTrJ/Bsj+nlhkM6O5b4WY8= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6117cd20-48cf-4cf9-d0a3-08db361ba9cf X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 21:21:04.7771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6kHOMNPVDWZ+zksDGjCcM80yVrI/Cmj+T3vTr2VPIwGAJYph2sJmi5htqVk3/pW37fQH4G9wBMy/Ilgo6DH8S0t+Dium8QfpBiV48F1moCs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5458 On 04/04/2023 5:06 pm, Sergey Dyasli wrote: > As a wrapper for XENPF_get_cpu_version platform op. > > Signed-off-by: Sergey Dyasli Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Apr 05 21:30:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 21:30:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518648.805404 (Exim 4.92) (envelope-from ) id 1pkAhq-00027X-Bn; Wed, 05 Apr 2023 21:30:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518648.805404; Wed, 05 Apr 2023 21:30:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAhq-00027Q-8d; Wed, 05 Apr 2023 21:30:14 +0000 Received: by outflank-mailman (input) for mailman id 518648; Wed, 05 Apr 2023 21:30:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAhp-00026F-4u for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 21:30:13 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a8137d6-d3f9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 23:30:10 +0200 (CEST) Received: from mail-sn1nam02lp2048.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 17:30:01 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5571.namprd03.prod.outlook.com (2603:10b6:208:298::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.23; Wed, 5 Apr 2023 21:29:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 21:29:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a8137d6-d3f9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680730210; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=sTRVs8W4txYmej4nd3N6tY1exzKR9taNf+gzQBtLPVo=; b=O0LHEE+sRWz7hd/L0z4W4FbVJXqTNuNdf+q++mQsIwMzqXY69c4ZOW1E 8BQxMvZ8Xtq4SJdVNDGEDWkTFwp4zJUf/rIg5oASQmDghdwM7vB8khN5m 6U9g5A0IAnHD05w3frKEZBe4ma34MeXRO87QGoEsFB+IpBJEtxdBe+7qT U=; X-IronPort-RemoteIP: 104.47.57.48 X-IronPort-MID: 103269853 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jbOo+KA9mGO32RVW/wviw5YqxClBgxIJ4kV8jS/XYbTApDwj1zNVm 2VOXGuGOa3fNGSgftxxPIS/p09QuZDQy9FqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2918I0hPz dckCjE9U0+jlqWY3qyaVbw57igjBJGD0II3nFhFlWucNtB/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxrswA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37eUx32qCN9JfFG+3vpj3VOtxVVUMzk1el258d6rqk35BPsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9KGYDYWofS1ID6ty7+oUr1EqTHpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:vta1F6FCXnJz1zInpLqE+ceALOsnbusQ8zAXPiFKOH5om6mj/f xG88536faZslossQgb6LW90cq7MBDhHPxOgLX5VI3KNGLbUQ2TQ72KhrGD/9SPIUPDytI= X-IronPort-AV: E=Sophos;i="5.98,322,1673931600"; d="scan'208";a="103269853" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYGOxAOOWHIdvloJefrYBtaAhHuXf8l7JYgFSyTm/yiCsBdl3uEnls+Ev3v7y8MpK+7TTmph4uJOIz4cLg4d2I4Uts0YHGLNLIofw8mHdC6bx3qZ1nhsOhfZrVKgHCS5LwTVlVlohvwizQzCvpXXqSC2DhrU5F4G04TJxcx9ZCldCaUHsqAtrMsE1S0rpc3u2sdEo6u1bZjqh+PH5kwwJ5KxdEdgdLYSSs4491GSqNGSkqU5+0EfzJq99yvBHUiRGmVam9tc8rZlWK35KCOdVsIS2pBUr34J4kP+oDUzOHLGcFWwuyibZ7HlZd/L5Im0t1jwjB8UYyJKmGgnus2aKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0SmF1t85NoXdJcE5Z7Mh+1yNn5WUeBPvZXB5ZnLGE/I=; b=a7Po7biwbrjOZ+rIvS/bK+ti4/m2DNSmxvdXeHm3bySw9w2hzU7hYB+pXWeVTUVAi3fHVvAtwNfKqcH2COkEohOeGg3MTFpAGiSJYEGrr0aWJT4fDpOTnqDi0kNMognAKrJ5R1xjzpPLa9N5qNsV3/0hv/sOvNIdwr79FZLjL7q/KlBj4grb266GwAhfm2CicJ5lg+SuHK/2U5604OuvfIrIcBdRQGmTlsouCnPy+IZ93LIEGTIBYrVi96aK/uvCdejOabu02wM6UIoOXPrRozongVFvw3w615jt0hs4cPuAZwMBK98ZR6QTMz1v0kbal+Zfy+WnZpncr1dmUVnGvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0SmF1t85NoXdJcE5Z7Mh+1yNn5WUeBPvZXB5ZnLGE/I=; b=GhaxCfszrF6aWD0EUhmV5YRzVX9uBnF8a9S0YNQAql1A4krC9qUrB+yCRVym6okEyx0sb6F3RwyiIs4mLmhRxuEmyT1c8W5+/aFReXEoPAQFBt8QSXw4PyJlV/IF7PF9L9Tve1gJpfGdcpLbbXwzU0VBskndp6MK5FiRjeZRksM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0c249d10-02c7-9d76-bc3d-2b3e2ece38a9@citrix.com> Date: Wed, 5 Apr 2023 22:29:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 2/9] x86emul: support WRMSRNS Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <0c2ddae9-3222-9755-b6e1-35e51410093b@suse.com> In-Reply-To: <0c2ddae9-3222-9755-b6e1-35e51410093b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0302.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::26) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5571:EE_ X-MS-Office365-Filtering-Correlation-Id: bf6767de-4960-47d8-3306-08db361ce854 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K8E90IrW6uGg7cejCBDcHE1JBzh4K9Gvd+blQAlHvoW/W8WhFGo+ZEADMywBwq0Sv3JG6s1GL7E+TrjiShOy1E+5ZdXZTGWrcuvcmapfzPjBDl17SETg5vm0TLbbYM/L+ndrMsrTwR9vVzsX9gWAJPDgKJmKqfvbHiOqudasXOYxSJqWFsfZf9E4Uh8rOsAqogkLai6X8jmNaV4Ym9kEsN5D1s2/dGd7GKF0gWPFXO7q3iNZKxWQz2ubGWpTEeoGkWAJmyvgLxqDqtiTNwCcFMfs0+L46V+/ug6a2X8ixHSl2hGNmvz4xBRm2wG2Q6ZvBgFsbmbVt4tRORD50zErazI/nEhwzOPiH5Xsmntdfu0JectPP837sH1I5xb9fw8p4Zq5BQadhHplg7/Cnxwu5XUqXXv5yZhDrBrFSBH/bKZ6ofsBCjXk/7Im4QI2da1qsBpcJfLdhnF4LQchvtrp/Ijwt/zc3pf5AFVrpZ2uVSUEhPusqZKCvJVlXsXh9/S8F5DIkHt076+uSEsaFyjXhzUBqwpxMifikISQF+qHjmhRlIaZcZ4zjWuHLkBgKBDhXELwf1G7YXq/xa9rnZRdYiDxIveGnxOyExPIcSYzLEsoPvn+aRejvmLHvvGdt+wwDpXTEtflwg0R5HZxbNHOqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199021)(8936002)(31686004)(107886003)(53546011)(6666004)(6506007)(186003)(31696002)(6512007)(86362001)(5660300002)(82960400001)(54906003)(66946007)(83380400001)(26005)(36756003)(41300700001)(110136005)(478600001)(2616005)(6486002)(66476007)(316002)(38100700002)(66556008)(2906002)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGFiWm9abzJXYTFtVGUwYmErcnhzZElsY3RFeVJDdXAyblp5OGdCblVRTjVX?= =?utf-8?B?M0VoMFpWOHE5Y09TK1MwaUJORlFzRi85d3RFK1NSUW51ZzlzNmlSY1dBUk5I?= =?utf-8?B?NFl3WjAxVWoyb2V1U3lBUkVwY05abHM5c0wwWk8waXEvM3U4dzRvODJhSFJk?= =?utf-8?B?U21yNk9HdHFidEFJUUZOTmwybTFjWEZOZXZiVG41U0dWUkJRUmg3YWV2bEdO?= =?utf-8?B?NjI3QjBRd0ZhcVR0Y2FiZldRWFJlbWlNRllBMHd4ZFFZaVdUNFhTZnUwRVdW?= =?utf-8?B?bDByT1k2SDJEQ2VGT0VESG03UzBybGM5RlA3QnZ2MHA2UDkzYXViYWxCTi81?= =?utf-8?B?VkZOZThrWXRSTW44bEQ5Tm5QNG5Cb0NKU1FkMUlJNE9zSUlaM1NaUFo0MVBp?= =?utf-8?B?WlFudEl4RmdGRDBzYVEyZVkzdGRIY1F2YU8rVnAzM0MzTjhWUXJGeVhXd25J?= =?utf-8?B?S2ZOK1ZZZVlxMUVOYWJIUys0VVZRYzdLaFloRHFZRXpyNUwvb25YUnlIOGIw?= =?utf-8?B?aUJBQ0Qxb0NZdTRHbXpubk9OVkVIZjFINFFmTEdpQi9OdFQvUktSQ0szUjBJ?= =?utf-8?B?QWJqeFU0dGJkZkFJSFFFdUlDc3hhWk8rSkt4ZVBoeHl1Q2g2SnBwNUJtYlFW?= =?utf-8?B?WkFDMlNyaGNwaWZka2YrR3YzVVpWdUttMFVhSXFGK1VqK3JmRzZ1YkRJaDIz?= =?utf-8?B?QTYySVQvUXJ0QXRHY1VSVTFabEVSd3p3ZU1BTDBzSGoxTDcvWC9mWUllc3BT?= =?utf-8?B?WFVyWE9kc3E0aVZPNE5KZ3FXbStwaDJxaS9xSEZBNWJrWUxTM0ZRSW9OVzBM?= =?utf-8?B?VDJlSGJHZnRpa0FlSXdoSmJVTTM5VEVWeEdvRDV2VGJ3QjBKY1JhZWtIMTJW?= =?utf-8?B?QW9YNzdpbFpkRzBza2tBL2FUdWloT2ZMeWxaLzBkdzQwcVBGSy9VTXRTZVAx?= =?utf-8?B?V3E5YXpkOWh1aWsxdlN6NWJZL0h3S2doQ3JpcG5lR0RUZHJoN3h2c2ZxcGZu?= =?utf-8?B?SStadHpQbUdZZGEzOWVDWjFRT0owV2MwSWFUa2J2Vk9OMjNBM0RUUHdRWGpE?= =?utf-8?B?TUFwUGZqMXo4dzIvdm8rM1Z4N2hzZU9JbEoyZzVOWEpQVHNoKzZ6S1lXV1dY?= =?utf-8?B?aDFKMnRpNmdySDc2RUEwRjNQemY0UUNONkNoY1RHT2JFSkZQT1BwUmZiNkdx?= =?utf-8?B?em16ZS9DVjFmZUtkdHdGYy9tUGtkM3hLUU5WNGF6NmFGMWFUTitmYkoyeUEx?= =?utf-8?B?dEM3WnJpeGlxTi9HZVpqSUpmS044eHFSMTVaWUhNRE9LSmpBdk81SEhyMk95?= =?utf-8?B?L2kzY1QvN3JReGFhMTErV0NjTUR2RGlTY0Joc0YzdmpqUXNZNFhxSzFLUVFk?= =?utf-8?B?MTJpcXUrdUNiekhGREU1TFVETXlqL2hMMTRxQ3JINnFVekZBaFpmYzR2aXVF?= =?utf-8?B?OWhzaklHTVBZUjFSVnZxTnFWREJIRzNxaklKRittcjYyemhRTWh1RHhpY1FZ?= =?utf-8?B?a0dyczhMV0FhUG5uOVdWTjdMZ1VRUTBrMFJHVGRsUmFqSnBzRWlPaFVCQ3NF?= =?utf-8?B?amJwTWp4OWdTeXplc1lTR2IxQk9uMjVINW5SVHh6SUt6SEYyY0VZNFNpMDZT?= =?utf-8?B?UmZWU1pUSTNZQmYxZWlGY0tNcmdJZG01S2x0RVg0aXg4NEhDS3F0NWt0WHFD?= =?utf-8?B?R0FPTUpmbzRoaTRXeG12dGdrQ1RpZXBLRFIzV05vTTc0a2llR05DTVd6THhC?= =?utf-8?B?TllOMTh4M21WSWpMaTVMU0l6Um4yOS83NDRKZlJWNTN5cTZ5d1NSM2piMis5?= =?utf-8?B?dHRzdjdoL3VaeUR1V1pyRXBYSnlBbnVpKzEyRmp3QmtRbWViNFVENmU5YkNR?= =?utf-8?B?emJXaGZuUUdKVU9XSGJoMnRWOU5SOUk0SE9wcms1NjFJS1BST3FOQzJhaFZj?= =?utf-8?B?NW5Vc3VsZVA3blZUemY5di9DcHZZLzFqSFhWVkdkVFMxT245YjdkdjJEM0pG?= =?utf-8?B?TjROZFZmK1kvUzFuM1lFMm5QQlE1YzMxVlNzRXVyZEh0dUIwd2NhRENDOTZs?= =?utf-8?B?WS9udWZjNExtNmlLNDJlN1RETWk2c01YZjkzRHB3aEVvS1Avazc2ZDhZZXdM?= =?utf-8?B?TFJ6ZnlDNitHMXpCY1ZHeDhyaURzdG4raHpVWVFsMHNjcGVodW9HalRJWmUr?= =?utf-8?B?SVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mUcftL8RAyeoPAqm6CwXfS07o0Y2S8wcLh160EGO/6xrMQkLBS2XA5odtpY8WGkERgx4YPMf4wFtBCeGtCz9en3o5cAQPjhXOhh27gFILbh3to3fE+tm/OA909Cq2dmv2I9rOeEmVPReV4s67QIGJLUSlweWXY+o9sHG+4tiwWTxs1nKnGHQCIs2bzyMJSrZMSPXyXTEUMxIFjNvX67iyLrzHeJIORJqHDPDnG3m6JbpBPF4XWi71UG+t3g+lhk8eRb6m5H9haElJcWMeSVxuhhIE1pBeNflJx/Rj3EheMNfhUONvsQjKIpr5RdTCw9m7QyU6Kvyy4z3TsSFmVGTXF1kP74d2f43LXlux4g6Jdfv9XcMRmnYzITkQglBzKnwdGtJAQwFbXQIYbOYeU1T+al5kFRTO1fzvNXKWEudtqxzDG8a2MH/k/Frt017N/7EIYnkk483B8COUMtOqcxTkLCngFnTRRmAxYdDWkLhxxd92AGLg+su1Y+cZK7OsAbo1y9qpEBZ6UbN6b1iosOnYwYzynQjevO++JLFN0cEgIaDlEmNNZ8lpUhn8EGQqWRsgUu408V/s2VZOKIHGlGdA5t2RqRM6Dy3rJbdMXCSmELf2R/PCapwjnglzaIp7HCbnfT2BgoLeSFTdEwJF4ZaURpYIjYfEEvAdxwjm2TEt4LsJFeuvARp8VI2p1Jgp06pQb5Jprtpmn+Iq20gaf3RYj5cg0MGbx32ajaoTrmnpCX4r+hOO7qorXj0MRyHKJjgLAQ7r/usTsW7jup/Q1FlFw/0ux2woFmFZ80LjJ/wxTcOzKBxNgZulstsaW0H6QJC X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf6767de-4960-47d8-3306-08db361ce854 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 21:29:59.2309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L7O/ibzcGGUSipEkeVCFEoA1zATkMRLwSk+GG4V8cK3YK10Ir47V957gGKQEC2Hk01+2uYFELfz0VECqdaMusEQ+yMeXw/H2dzFUKKniSSk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5571 On 04/04/2023 3:50 pm, Jan Beulich wrote: > This insn differs from WRMSR solely in the lack of serialization. Hence > the code used there can simply be used here as well, plus a feature > check of course. I have a feeling this is a bit stale now that 0f01.c has moved into a separate file ? > As there's no other infrastructure needed beyond > permitting the insn for PV privileged-op emulation (in particular no > separate new VMEXIT) we can expose the insn to guests right away. There are good reasons not to expose this to PV guests. The #GP fault to trigger emulation is serialising, so from the guest's point of view there is literally no difference between WRMSR and WRMSRNS. All code is going to need to default to WRMSR for compatibility reasons, so not advertising WRMSRNS will save the guest going through and self-modifying itself to use a "more efficient" instruction which is not actually more efficient. But, in general and as said before, I feel it is irresponsible to be continuing to add slow guest-fastpaths without introducing a real fastpath. We desperately need HYPERCALL_pv_priv_op which can take an array of inputs, and has an sub-op for each of CPUID, RDMSR, WRMSR and whatever other ops are trapping because of no fastpath.  Perf testing routinely shows that #GP/#UD faults are only 2 orders of magnitude less rare in PV guests than #PF, which is an insane wastage when guests are supposed to be enlightened and use fastpaths in the first place. The emulation implementation is fine, so Reviewed-by: Andrew Cooper but dependent on the PV guest changes being dropped. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Apr 05 21:49:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 21:49:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518654.805413 (Exim 4.92) (envelope-from ) id 1pkAzn-0003nI-3Q; Wed, 05 Apr 2023 21:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518654.805413; Wed, 05 Apr 2023 21:48:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAzn-0003nB-0Y; Wed, 05 Apr 2023 21:48:47 +0000 Received: by outflank-mailman (input) for mailman id 518654; Wed, 05 Apr 2023 21:48:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAzl-0003n1-Jw; Wed, 05 Apr 2023 21:48:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAzl-0005Gx-Ex; Wed, 05 Apr 2023 21:48:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkAzk-0002ce-SJ; Wed, 05 Apr 2023 21:48:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkAzk-0002Ux-Rk; Wed, 05 Apr 2023 21:48:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PcJXMowNo58duxaMRrj5LVwF7Mv3Qq52bpVZWNfsVH8=; b=hw9qIL/s74dn4Uu3yj+/dQKJh9 ieGi5m4zBAPD+55HP9HLrUPpwStZvCjxFt91wy1SJeH2n6eBRgD4qPWJ7zKgWpe5fExI3dsvW92iv d14qvrS5d79/FB42IFJL78Mf0mGXy/5phBPmVYDfVWTn7N9XIJ3c7bp8ZMIFr5jj9vGw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180160: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=881ba20eb0222305a9d2cd090c9345992794f4f5 X-Osstest-Versions-That: xen=55c6d4e2257ca8aabb15232f696ede49642efa3c From: osstest service owner Date: Wed, 05 Apr 2023 21:48:44 +0000 flight 180160 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180160/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 881ba20eb0222305a9d2cd090c9345992794f4f5 baseline version: xen 55c6d4e2257ca8aabb15232f696ede49642efa3c Last test of basis 180157 2023-04-05 17:01:51 Z 0 days Testing same since 180160 2023-04-05 20:01:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 55c6d4e225..881ba20eb0 881ba20eb0222305a9d2cd090c9345992794f4f5 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Apr 05 21:53:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 21:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518660.805424 (Exim 4.92) (envelope-from ) id 1pkB3n-0005DM-Ky; Wed, 05 Apr 2023 21:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518660.805424; Wed, 05 Apr 2023 21:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkB3n-0005DF-Hz; Wed, 05 Apr 2023 21:52:55 +0000 Received: by outflank-mailman (input) for mailman id 518660; Wed, 05 Apr 2023 21:52:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkB3m-0005D9-5k for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 21:52:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35bc4799-d3fc-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 23:52:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35bc4799-d3fc-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680731572; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YG+tqcOrXnWWW86uHDi9/SgPfWk33wf/QiRsN0bkKP4=; b=GvdV6e6Oun+xMb2swa0tfxNE7IRA52enQkyBq9vZdLMkZQo0O/wMXCaI 1efchE+wz3LUtVY1DigPynNgQH64LAvWwveB4cDkfhrS3/Bojzz99+SOv MaIKvyf1gjC2voZC8aXpYOqG+LA6Ekdy1onC+wWixu1wQu2FCNdE9Jlm2 s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104889208 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:xuGNDKLYiAZ3uZYMFE+R85UlxSXFcZb7ZxGr2PjKsXjdYENS1TNSx jEaDGiCOf/camuge9pwPtjj9k0EupbRm95lSVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRjPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5MEUBQ0 9AHeAwodz2pjt2b6/WBTe5j05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TTHZkFzhfC/ jKuE2LRPEoQE8zG4zS+yH+xncyImyarG75DLejtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QW5yxoq6Ex/U6qS9DVXhukrXrCtRkZM/JTHvM77keRy6PSywefGmUACDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcgTyIZSQoO4/H4vZo+yBnIS75e/LWd14OvX2uqm nbT8XZ43u9I5SIW60ml1WvXoiyKioeZcissyy/eYU+OqTl+Y4HwMuRE9mPnAeZ8wJexFwfR5 CdexpLDt4jiHrnWynXTHbxl8KWBoq/cbWaC2QMH84wJrWzFxpK1QWxHDNiSzm9NO91MRzLma VS7Veh5tM4KZyvCgUOajuuM5yUWIUvIT46Nugj8NIYmX3SIXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyZCVv02kmvpGr5BuVPO+szZ7TqKLa0XMjz9iebODJJrYext3KSyghARs/rf/VS9H yd3PMqW0RRPONDDjt3s2ddLdzgidCFrba0aXuQLLoZv1CI6QjB+YxIQqJt9E7FYc1N9x7eXr y3hBxcBoLc97FWeQTi3hrlYQOuHdf5CQbgTZETA4X7AN6AfXLuS IronPort-HdrOrdr: A9a23:PJwOfqlkYwYdFWNDTD6Mz+s5kl/pDfIo3DAbv31ZSRFFG/Fw9v re5cjzsCWetN9/YgBCpTntAse9qBDnhPtICOsqTNWftWDd0QPDQO5fBOPZslnd8kbFltK1u5 0AT0DSY+ecMbD85vyKhjVRx70bsb66zJw= X-IronPort-AV: E=Sophos;i="5.98,322,1673931600"; d="scan'208";a="104889208" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest" Date: Wed, 5 Apr 2023 22:52:45 +0100 Message-ID: <20230405215245.2137356-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit At the time of XSA-170, the x86 instruction emulator was genuinely broken. It would load arbitrary values into %rip and putting a check here probably was the best stopgap security fix. It should have been reverted following c/s 81d3a0b26c1 "x86emul: limit-check branch targets" which corrected the emulator behaviour. However, everyone involved in XSA-170, myself included, failed to read the SDM correctly. On the subject of %rip consistency checks, the SDM stated: If the processor supports N < 64 linear-address bits, bits 63:N must be identical A non-canonical %rip (and SSP more recently) is an explicitly legal state in x86, and the VMEntry consistency checks are intentionally off-by-one from a regular canonical check. The consequence of this bug is that Xen will currently take a legal x86 state which would successfully VMEnter, and corrupt it into having non-architectural behaviour. Furthermore, in the time this bugfix has been pending in public, I successfully persuaded Intel to clarify the SDM, adding the following clarification: The guest RIP value is not required to be canonical; the value of bit N-1 may differ from that of bit N. Fixes: ffbbfda377 ("x86/VMX: sanitize rIP before re-entering guest") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Jun Nakajima CC: Kevin Tian Rewrite the commit message, but no change to the fix. Fun fact... LAM almost required this to be reverted in order to support, but the penultimate draft of the spec backed down and made LAM only apply to data accesses, not instruction fetches. --- xen/arch/x86/hvm/vmx/vmx.c | 34 +--------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index bfc9693f7e43..79ff59b11c6b 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4035,7 +4035,7 @@ static void undo_nmis_unblocked_by_iret(void) void vmx_vmexit_handler(struct cpu_user_regs *regs) { unsigned long exit_qualification, exit_reason, idtv_info, intr_info = 0; - unsigned int vector = 0, mode; + unsigned int vector = 0; struct vcpu *v = current; struct domain *currd = v->domain; @@ -4730,38 +4730,6 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) out: if ( nestedhvm_vcpu_in_guestmode(v) ) nvmx_idtv_handling(); - - /* - * VM entry will fail (causing the guest to get crashed) if rIP (and - * rFLAGS, but we don't have an issue there) doesn't meet certain - * criteria. As we must not allow less than fully privileged mode to have - * such an effect on the domain, we correct rIP in that case (accepting - * this not being architecturally correct behavior, as the injected #GP - * fault will then not see the correct [invalid] return address). - * And since we know the guest will crash, we crash it right away if it - * already is in most privileged mode. - */ - mode = vmx_guest_x86_mode(v); - if ( mode == 8 ? !is_canonical_address(regs->rip) - : regs->rip != regs->eip ) - { - gprintk(XENLOG_WARNING, "Bad rIP %lx for mode %u\n", regs->rip, mode); - - if ( vmx_get_cpl() ) - { - __vmread(VM_ENTRY_INTR_INFO, &intr_info); - if ( !(intr_info & INTR_INFO_VALID_MASK) ) - hvm_inject_hw_exception(X86_EXC_GP, 0); - /* Need to fix rIP nevertheless. */ - if ( mode == 8 ) - regs->rip = (long)(regs->rip << (64 - VADDR_BITS)) >> - (64 - VADDR_BITS); - else - regs->rip = regs->eip; - } - else - domain_crash(v->domain); - } } static void lbr_tsx_fixup(void) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 05 23:01:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 23:01:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518666.805434 (Exim 4.92) (envelope-from ) id 1pkC7t-0003wv-MR; Wed, 05 Apr 2023 23:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518666.805434; Wed, 05 Apr 2023 23:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkC7t-0003wo-Iu; Wed, 05 Apr 2023 23:01:13 +0000 Received: by outflank-mailman (input) for mailman id 518666; Wed, 05 Apr 2023 23:01:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkC7r-0003we-Jg; Wed, 05 Apr 2023 23:01:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkC7r-0000GA-DC; Wed, 05 Apr 2023 23:01:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkC7q-0004Oj-Pg; Wed, 05 Apr 2023 23:01:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkC7q-0005C9-PI; Wed, 05 Apr 2023 23:01:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jc85nSYJ6tQ3khPKcmN4waFRELzzHGSFhiWPVYGOGMM=; b=xH9yNCrZfzHaprp1LSSPt9xDQk tkqYgdQ5wj7d1e72SQe5xRWolbhfOGSL/h4gfw7BburUOPBm+Z26gekPaceOXx9HhMJ9sj8OutXdR PGJfb57yWyFURwPH77U1ZxjXc5XDMxuGBPXZTC7GYWqACHpST0baX67pcb1PvB7JGgUo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180161: all pass - PUSHED X-Osstest-Versions-This: ovmf=2bb693894920e634153275bea60278a9f192a8ef X-Osstest-Versions-That: ovmf=a56ee36c494cb1dfe795259b2cba706ef55b5212 From: osstest service owner Date: Wed, 05 Apr 2023 23:01:10 +0000 flight 180161 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180161/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2bb693894920e634153275bea60278a9f192a8ef baseline version: ovmf a56ee36c494cb1dfe795259b2cba706ef55b5212 Last test of basis 180156 2023-04-05 16:13:44 Z 0 days Testing same since 180161 2023-04-05 20:42:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Patrick Rudolph Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git a56ee36c49..2bb6938949 2bb693894920e634153275bea60278a9f192a8ef -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 05 23:02:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 23:02:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518672.805444 (Exim 4.92) (envelope-from ) id 1pkC9J-0004TL-14; Wed, 05 Apr 2023 23:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518672.805444; Wed, 05 Apr 2023 23:02:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkC9I-0004TE-U3; Wed, 05 Apr 2023 23:02:40 +0000 Received: by outflank-mailman (input) for mailman id 518672; Wed, 05 Apr 2023 23:02:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkC9G-0004T2-If for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 23:02:38 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f349e007-d405-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 01:02:35 +0200 (CEST) Received: from mail-bn8nam04lp2040.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 19:02:32 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6224.namprd03.prod.outlook.com (2603:10b6:a03:303::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 23:02:29 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 23:02:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f349e007-d405-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680735755; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=kggSEvmhTi06QG6RXgFMaSfrTmF1WUs8NNX6yajr5Kk=; b=FK6itah18DsoGv7nQCrxsMZedTmhXnCKqeJt3l+cKCu0DcwYtsSek7Sn hl5HiXOJ5CEGKO7wdIZkgFw0MmaRaPniuY+919sbARIaMb5GGxIewJpCt ZJVKJzPisYAoGsjuO5iZ4El5bwBpvtpGkCmFfBuZWcjp05ifp1/c5lCIE 0=; X-IronPort-RemoteIP: 104.47.74.40 X-IronPort-MID: 104395586 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NlpvgaPgVMcJTwjvrR1AlsFynXyQoLVcMsEvi/4bfWQNrUpx0D1Uy msbWGzXbPnYY2T0KI1wO4/kp0wA757cmt81Hgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gFmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rsrX3hEp achEykEaznY1v+5wruDVdA506zPLOGzVG8ekldJ6GmFSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vZxvzC7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwXiqBd9CStVU8NZU3n+hmVRKGSZPD32k/vuJs1+BasJmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZDZ8Yhr9QeXiEx2 xmCmNaBLT5ytLyYT1qN+7HSqim9UQAONnMLbyIASQoD4vHgrZs1gxaJScxseIalg9uwFTzuz jSiqCklm65VncMNz7+8/13Mn3SrvJehc+IuzgDeX2bg5AUpYoegP9Cs8QKDsa4GK5uFRF6cu nRCg9KZ8O0FEZCKkmqKXfkJG7aqof2CNVUwnGJSInXozBz1k1bLQGyayGoWyJtBWircRQLUX Q== IronPort-HdrOrdr: A9a23:5AiwL63u4W4NBoYU04Bf+QqjBNEkLtp133Aq2lEZdPU1SKylfq WV98jzuiWYtN98YhsdcLO7WZVoP0myyXcd2+B4AV7IZmXbUQWTQr1f0Q== X-IronPort-AV: E=Sophos;i="5.98,322,1673931600"; d="scan'208";a="104395586" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oh+YcL7tJ4/AgFonvFWWacxR03k2a22euro7a3B5DxHMrHyGszhPpCd8Z8ozehzrh5GD8FdeLF5x2zi1zFL+a77ZcwOJCHNqyPp/bnTdrebgFs6vaworcPG3G+o7rD2xK9bB1WOL4/DbisnEp3rTnlVEK3nrsjzxphFhS9i538uTwwSQcyK8ONXezQfUixkW4HqD0SG8ZirhyjlLZgqTdo48YnML2xmmGiI1vw0hma7BGJ4bjJ6uU6T9ABWH6Y9MtHbML8MmqjPxIZxErGDzoOy8FIc+m5467pvduDrGQxek6aXso2sKbD4OMtg8dH//zrdeGm24X9AMDL/Pp4ll/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UjqZEF+WjGnPfuswrQ6zTxKr03umwBBR1PBsIS+Rk/I=; b=ERsV4lnJTQnRDh+djIj34od6yaqhA2TqsTlXI4bUjPEi8oIg8Qg++CpZkqDJmYYaRJonqP41b5+s1tR3eVhSNsY5qUzJeXjg4jqRX0akPkn+v3On7qAqYvGCVgMTZ8+OIJVLIr1Mqa//aoFc2Me++I/OeekymSHnx0K/QkvtSEXOcPN3Xk6h2h19XMBN+mutDJ2noaQR32ifjk3GvgOC3xlK3fKRqRshYrFkwzDy3vIVk1u35GhddqjRPDJAPUuFthB/keMoyahDv8ReZyi/icsyoJ2LJ7EBAmdwBY3hBFeKySNqOU7Z6W8iCU14oQDicD1AkcbNWHN4IOYEa4GxAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UjqZEF+WjGnPfuswrQ6zTxKr03umwBBR1PBsIS+Rk/I=; b=nbEvXB5dvwBhZjLux6RwGzMDUlztqWm4NyFxSdhC1my6uqq3gsLz/9kKxWretGWSs/nKK+yt6eXu/YIbo6YXDN9F+rkvYh4vURbWK5ZHU4q4bP3zry4YHZEpxpmb0zu+RSs+grbzVqw5XfdARfqAcc7Jsi9tKfb4rjeAYqlrdWI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <724da9d4-2c8f-dc45-78de-5a50e87adba1@citrix.com> Date: Thu, 6 Apr 2023 00:02:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v4 2/3] x86/platform: introduce XENPF_get_ucode_revision Content-Language: en-GB To: Jan Beulich , Sergey Dyasli Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230404160655.2354-1-sergey.dyasli@citrix.com> <20230404160655.2354-3-sergey.dyasli@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0572.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6224:EE_ X-MS-Office365-Filtering-Correlation-Id: cb537f57-3064-4997-b1db-08db3629d45e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zhIOvNl8iQqGcbQymec4lerj+seL6/NFq85kvLgHAaEmnMFLnaZJ/Ptq9U4sAOHH7q0imXKGE/nJritr8sJwPAZjCZzLQkfakD2jJeTP7itIRaOSchFhXRMBKEzok1zdR+Xw7NvhrVMZyDT/wa3F5aOB1GPVNuvM7m6OaV71jdoCeah0Qx/LYcpokJ4FNoazY9BoF9lbfgYVkCyvtmsjohz4KdbpuvClRtoPyiChMHGD6LSpRTAwH36cHsRP9gtfzm8nI8EzLg65tlUMvjecpnVSnq+GPPqyxxWR5aLN4OMLMFzNs5N4dq+hoT/8VLj46q+NovqRSr9+wUFrwITQm1Wtg0F36WaIr0gzEh/99azn4Rb1vIVPsxJw3yePCCRwhioOTJWcIVCsY7r+UwGii1Lk+ZUT5UzU3+bDNr3fQvET6+9YCBqjJN3bYVx7hlu6OeTPyuCIwm60w29yKXWz//DE9fVMNqrPPvK/csmXY7tT3XZCtKv3I8hSkeThQ1e7iC7jekpByIhOp9eDIb9QXoPAXSAG331LhWVr9Zu6jxkQqiPYSs2ckLfshexsVzjFksDf2mz0ABegcz0d7IhBlztIcK+0BmfQGVGa7i6xMptnHkiCX98xKsBVgt5O0AQv7KcMGrwKA0IVc1po9RruNg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199021)(478600001)(54906003)(110136005)(8676002)(316002)(66476007)(6636002)(66946007)(66556008)(6666004)(4326008)(6486002)(2906002)(5660300002)(7416002)(41300700001)(82960400001)(8936002)(38100700002)(86362001)(31696002)(2616005)(6512007)(26005)(6506007)(36756003)(186003)(83380400001)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nkw1WTVzKzZvVzVJdE0xNmZhaEFNRnZaL1RFcCs4Tmx0T21idDViQTF5VE41?= =?utf-8?B?cjRPWWlVYjlBbFZwa1kvTTl1c0dkbzZ6OGRhUXl2dlo0YnQxWnpCOWM2NkJT?= =?utf-8?B?UDNtaVlHLzdlaTdRMU9ZamQ5WnJSODRyV0FWdldBTXZxQ090NVo2UjM2Z1NF?= =?utf-8?B?dzJiRXpWK3JEUjlpd1ZTZndYWVBxQmx1T2FVS0hZbUtja01UbTRzRG5VOGc0?= =?utf-8?B?cmg4VThBWkxvQ0xBU1V6bmU2TmxXeVdjUmh0K0N1RS9LODVxdlZIRk1jTld1?= =?utf-8?B?dDNHQ1ZKc2lQdksvOFQwb214WitJMWY5eGVpQlNRUjc5cVpNWHRVZGxuajhE?= =?utf-8?B?ZVVzK1QzbHp1MmtITzlLSVpBY2Vuc2l0Rms5VmFoQmlkWTBiWVdBQUd1NlNX?= =?utf-8?B?cHpBS0cwNXExUHlYWmlMVStxQzVaRjNWK3oxb01OYk9vVGVWSllia1MyK0dD?= =?utf-8?B?ZG4yRkVQTkdac2haTUlSbEdFREF6a0pGdFAvcFcwM1pZV0N6NEYzQWZxWkI5?= =?utf-8?B?WUNmYjVWcmI3bUhaejVaSTlTem0ybUtRSS82eGNVVUk3a2VFRWZiUmdnVkJC?= =?utf-8?B?SXFBL1ZJbkNKUUZCQ2wxUVN1RUh4bmRnU0hScXpFUzA5elRiT2R0WWVReGZL?= =?utf-8?B?NFBpRnMyZlRUSXZxU2ducTdMN1o3d0dLbmpmSC95SlpiOVVXS0tFT3NOVXBz?= =?utf-8?B?OVJHZDJlSjNpODVsbS9jUGZnUXQzOVVhUTYvOGJ2TnhxRnZ2VkszRnZ6MnVv?= =?utf-8?B?QWg5M3ZWUUFEc21rcm9xYjArQUsvVE1mNlhSdzVwMENNNUNIK2NLbE4wSnpC?= =?utf-8?B?RzFScTlyNkdBRkNQWm5zYWtnZEZvSmVWVWd1UXBBTG5ibm1lY3J1cHpFc0gr?= =?utf-8?B?SDdPRmwwU28zVldGZDBqNnZSdmJRWjJrYlRrQ3ZxcU93V0wxTS9IdE9IZFJP?= =?utf-8?B?bGJkSDZiQWxINnpGeXNUWWx2L0ZZVCtMMUE5UmdsZkY5c0hEK3ZoeXM5b2NS?= =?utf-8?B?QlZGQ1RRbjQwblRNbW94TElSYjVvU3dISkNseHdBSmRjNlppSCtQb25CU0gr?= =?utf-8?B?eE9YaHRpd2xyVDF0UnEvbmZGNExqbVFsUmVBQW5VZGp3TStXc0R6YnVjWisw?= =?utf-8?B?bDh4TURtT2RqZ3pYd0cvSHlESkIvTm5kTzlBMmJhLzBsbFRJZzZxZlkyMDE0?= =?utf-8?B?MUZwYkg0Yjgyb3RaL29nYUtPaVM5UmxvY2t1dGpRemxDSFRpTE1KTElzcGpw?= =?utf-8?B?TlBhQ0tlZSs3ZkNqVXZuVTFGUk5PSDhKZzhBNVhadmU0cWw3QkdVQW1VYUox?= =?utf-8?B?b2l1bFZOczlacVZSeGhxeDhZR21KYzJjR251Uy92ODlnK1VSNDlnUkNBcW5Q?= =?utf-8?B?SzZZRWpNU2orRUJIVWdJb0E0ZjFZTC9ENVU0WXdadjY4bno5b01nb1FUdWRD?= =?utf-8?B?dmFGbURYeFJ5ZDhWdUdjMnpMVnZJTkUydFk3WXRZVlg5VUhFRjd2UGtkdFNj?= =?utf-8?B?cmlWSnRCbzk4bHU3dDlNVGFUdVFPS3VoOFZpY21hYXk3bEVHZXZLcTZ4UURw?= =?utf-8?B?VzE3bkhzMS9UcnJCdUVDTmd6L1pQbE90T2VmY2pGRVg1dDdrSlg3U3gwRmZw?= =?utf-8?B?NmZYcmd6b3g4akI4U3M1QlBQakIrRm9JWEJ1cXlxc0FCUHhQcjh0dmJJNUU1?= =?utf-8?B?dHdFbk00SThqTytPMmx3RG9WUVRrRjBWUnd6d2FZN3Vsd1FwZDJqNDArNUw2?= =?utf-8?B?NTN2VFRUdkxPZXpYT1VtZHkrdWRMQWcvYVNwWWVnNHN4bVorM1hHQkNoLzlK?= =?utf-8?B?aXMvR1BKVFM5RDIzQlRldTNJdGtieVFrQjhsSEhSdXJSS09QbmEzem11b09p?= =?utf-8?B?SEs4R2dnMjVkdGFONWoxQjlmSFFObjJ0bENWakc4dml4RnV6eUtmS1RjdUJR?= =?utf-8?B?OVNFTHcrWWhYWmdzZnozVG9UV3d6Y2NpMEphV2MrTmJMQy9za1FDNlFPc2tF?= =?utf-8?B?d2dxYjhENnVabW5RUDBlb2RjVTZTaEV6Q0NLRnZ2ck5nRWZXRTVUa25QbG9n?= =?utf-8?B?VXZ1QmgweUtkQ3JFc0hHb3lSeVd1c0RVRE5MY1VHSE1mZ1FvV21iYjdIaktr?= =?utf-8?B?MG9ZcGJ6Ly9keXJxZnE5d1VNY3l1Yk13NXg5dGIvcUpmWnM3L2FoY0hxVjg4?= =?utf-8?B?dlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zwTcy4TTKFLSjd3IiBQ7SCC5uOR2jxyXl8rsSAIwR2mxA8+AP9h+J+8L6UqIKfydzUqs242jtNeORtj6AG+gQi/jXkOR8JEMdkUhDd84UFRaQvEUOojoPtY4IgxFet8sM4+Y7in4e6VmfiPHCHkNzLUcBJBfIQgUYoXsarNdEo4PnH489T19bmXNHYll79HoYjAL68prXIE1sMViucjynRqGAZbexhCAO70VW9ah1Mjq3Nfhj/uwCHtDE/PvFGsen5hB2cLGDK4O1yOqxTPNfOnxbGg66rPlEYhMf2EsHPUFmF3gyHBDdxOqbdoSAH/ZVZCoVfGqhiGb9rGxNnqGx9MN+3Bd97LGQDNCRZFhUKXv38u2KDLLibGKmugbTq7gBMCMMrOWEJW2/poduCg17ptb3d2r/oobZIb1H4wgHALqvepJXdrf1y/TaV3drhJoWfBTNLzOnJz5Z0+lAKmWx51cWQ+P759JEDaZ9c1NFUZOC2m5qIqM86rIXrcZVCrB+7f90bdI5JdUO5mYNOBqBsbdJnn621c1n9SAwfJb+P6/OfMJEw6tVAoycjUL1RIbiYzQtzpGCt87GnrEYyaz+7+U4Tty7NtxEQvgvg0BHLW4PAuM7kPbTP9uU5/mZ0t7AjlKfIx48oAukb+WipbqT2zgtJmp9M8jRQTsBlnjEPr/+VQcBM84hRulgCxO/pmSvOFGnBVq8GPitfyyDpZnmB806A+lD4LeGB+yUkIReXtQo8tKrQHGxfbmA7jkHxWmUEluvN5AO6Egs1jM6RxJW5W1VDctCSbj+2VlBvSg/POzZ2mayi0q3JLCEg2Zjw5Yf/ufR4d4PoWcj7MDpj8e7Udvxh+nJOTfXt7P3R280dY= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb537f57-3064-4997-b1db-08db3629d45e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 23:02:29.1020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mWk2ccMoiNjqBD2hJbdD/Xkdjs4obLRkua+HUqZh7ZvINGfQnV1Nda1DdGJXLOkREUeB09r0KU8ipNmkyaM1v4JT1m2rGLQPF2FNgtc90Uw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6224 On 05/04/2023 9:56 am, Jan Beulich wrote: > On 04.04.2023 18:06, Sergey Dyasli wrote: >> --- a/tools/libs/ctrl/xc_misc.c >> +++ b/tools/libs/ctrl/xc_misc.c >> @@ -243,6 +243,24 @@ int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver) >> return 0; >> } >> >> +int xc_get_ucode_revision(xc_interface *xch, >> + struct xenpf_ucode_revision *ucode_rev) >> +{ >> + int ret; >> + struct xen_platform_op op = { >> + .cmd = XENPF_get_ucode_revision, >> + .u.ucode_revision.cpu = ucode_rev->cpu, >> + }; >> + >> + ret = do_platform_op(xch, &op); >> + if ( ret != 0 ) >> + return ret; > Is there anything wrong with omitting this if() and ... > >> + *ucode_rev = op.u.ucode_revision; >> + >> + return 0; > ... using "return ret" here? Conceptually, yes.  *ucode_rev oughtn't to be written to on failure. More importantly though, what Sergey wrote is consistent with the vast majority of libxc, and consistency is far more important than a marginal perf improvement which you won't be able to measure. >> --- a/xen/arch/x86/platform_hypercall.c >> +++ b/xen/arch/x86/platform_hypercall.c >> @@ -640,6 +640,35 @@ ret_t do_platform_op( >> } >> break; >> >> + case XENPF_get_ucode_revision: >> + { >> + struct xenpf_ucode_revision *rev = &op->u.ucode_revision; >> + >> + if ( !get_cpu_maps() ) >> + { >> + ret = -EBUSY; >> + break; >> + } >> + >> + /* TODO: make it possible to know ucode revisions for parked CPUs */ >> + if ( (rev->cpu >= nr_cpu_ids) || !cpu_online(rev->cpu) ) >> + ret = -ENOENT; > While the cpu_online() check needs to be done under lock, it's kind of > misleading for the caller to tell it to try again later when it has > passed an out-of-range CPU number. Honestly, I think you over-estimate the likelihood of the cpu map being contended, and over-estimate by 100% the chances that an out-of-range CPU is going to be passed. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Apr 05 23:25:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 23:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518680.805458 (Exim 4.92) (envelope-from ) id 1pkCUl-00073L-Ve; Wed, 05 Apr 2023 23:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518680.805458; Wed, 05 Apr 2023 23:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCUl-00073E-Sg; Wed, 05 Apr 2023 23:24:51 +0000 Received: by outflank-mailman (input) for mailman id 518680; Wed, 05 Apr 2023 23:24:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCUl-000734-6N; Wed, 05 Apr 2023 23:24:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCUl-0001G0-4Z; Wed, 05 Apr 2023 23:24:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCUk-0004vm-OD; Wed, 05 Apr 2023 23:24:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkCUk-0001vo-Nk; Wed, 05 Apr 2023 23:24:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SlyhLZkFqZWume9UQVwEN6plgx++3D8Lrja8hsqr7b4=; b=Td1R8b4eF86IgMCeK3SbW7rnxJ C/kNZjozNJsyiLPSpbdq1tglHugr1+Xc3OJjUGKNkFy0AraCIuQ0MqFTK7baPS7pc7wh6Jo8Kic8Z HfkEPlt3goHchoAtdjlxlWck+tqre70piwNMXmDYzBABaUsZva2J1i5a7X6VPkY9miyA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180148: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 X-Osstest-Versions-That: xen=658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e From: osstest service owner Date: Wed, 05 Apr 2023 23:24:50 +0000 flight 180148 xen-unstable real [real] flight 180162 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180148/ http://logs.test-lab.xenproject.org/osstest/logs/180162/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 180162-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180139 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180139 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180139 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180139 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180139 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180139 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180139 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180139 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180139 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 baseline version: xen 658fcb7ac90a4d8b0f4736a7c8f21d0252cb492e Last test of basis 180139 2023-04-04 16:39:59 Z 1 days Testing same since 180148 2023-04-05 06:43:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 658fcb7ac9..415f7d9404 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 -> master From xen-devel-bounces@lists.xenproject.org Wed Apr 05 23:49:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Apr 2023 23:49:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518686.805468 (Exim 4.92) (envelope-from ) id 1pkCrw-00017i-UK; Wed, 05 Apr 2023 23:48:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518686.805468; Wed, 05 Apr 2023 23:48:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCrw-00017b-Qw; Wed, 05 Apr 2023 23:48:48 +0000 Received: by outflank-mailman (input) for mailman id 518686; Wed, 05 Apr 2023 23:48:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCrw-00017V-5y for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 23:48:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6619712b-d40c-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 01:48:45 +0200 (CEST) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Apr 2023 19:48:42 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5947.namprd03.prod.outlook.com (2603:10b6:806:11f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Wed, 5 Apr 2023 23:48:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 23:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6619712b-d40c-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680738525; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=8svVWt7HH2xIy0tqQ2OwV8bT1afdTLaVAIvTAUGR4FY=; b=XhqbzWdvCih1xAX1EhLYVRLljp+M5pxYVNqp5Ve42E1P+FSFPMbGF2st 0KVm7ZOZnPMXrMpJ2spynMm+VwATXEWwAfpTzBViJLr77sGq+ZCfvLO35 RFcJ9ZAkGkNr00URqD0jmow+SlIoCf+Sos8bceBVahA61V9pvrIatw+jd 4=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 104398281 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lMjACK8UAA6F4CNyZlG1DrUDZH+TJUtcMsCJ2f8bNWPcYEJGY0x3m DAWUT+OP6mPYDPxf48nPYTipxwF65Pcx9FnTQI9+Sk8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagW5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkli3 906dREBZCnZ2cCpg6iSd9s1ussaeZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUuidABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpOT+zorK4z6LGV7nMuMh0cbna2mPOauFOYQIpUO VZX9BN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnM05Xzsxz XeSgsjkQzdotdW9S2+Z97qShSO/P24SN2BqTTQfUQIP7t3noYcyphHCVNBuFOiylNKdMSH9x XWGoTYzg50XjNUXzOOr8FbfmTWuq5PVCAkv6W3qsnmN6wp4YMuuYNWu4F2CtPJYdt/GFx+Go WQOnNWY4KYWF5aRmSeRQeILWra0+/KCNz6aillqd3U8ywmQF7eYVdg4yFlDyI1Ba67opReBj JfvhD5s IronPort-HdrOrdr: A9a23:63rR6qta9seN7xaHytvvsmQf7skDVdV00zEX/kB9WHVpm7+j5r yTdZUgpGTJYVMqMk3I9urwXpVoLUmslqKdpLNhWYtKPzOWwFdATrsSlLcKqgeIc0afygce79 YET0EXMrzN5DNB/KHHCXyDYqsdKbe8gcKVbCTlo0uFjzsGV0it1WhE436gYzdLrcB9a6YEKA == X-IronPort-AV: E=Sophos;i="5.98,322,1673931600"; d="scan'208";a="104398281" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJMDTH+pScY8ERFsFjI7qubxn3OCYpihgBKYD7h9l4etFodi0kVnECdtGZjfmTNv0Q45xi152wlqTfBq2hW//uDuXvkEVvxd0qlbZT1tmBlTOaSalifS6KZ/sn1ofq3cHseWEZykbc6aE1FH0dNCdu4Eo1o1lGloxNBYslwR7YP0Y/zraSym2dgbxXv1mTCWPseUZ/c/hKIscGn51KhVmCRAII4/EvLTXtMGri4B1w6CZe9UOP74Xe2dIqzsCRfNII15f1LDNR/fwASA7ISg1jwGxTRy9jG/lLsGYLeDSLcMbBszJ+A9+MCrng9oEJmbiWSIV9pda1IIjLq02nnPow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b89C+WDjoBzAWdyAvIeyTESJkKHIuxXpo6ReecPT/Co=; b=FhL62pFx0ntXoHWKMozas0V4YJ4ys4y3SUDNKNAM93vYurt+h4D2Gb3xjeQNdq3n9lk/IjLLfki+wkeMfDJMo8I3cdG/Lmpii2VI5IkFSWWi3jgPKHELW59qynoC5WxFrBAEu5EzDUJAUf0M/JtZAy/DzjoXwuHrWmH1TdQLAjravwWpEA7J8GAkvzUDCzyvINVSOXxAd/NCIbXI5wNodsxgpDDwSa6MMWFx+34xQ3ErMEanl9Ex11rTAfLmT3wxDgPQxPiZnn6fIBT0vCQSHpwIk3bYKYlfjE1bWdbwouBdQosNouXG9jzD8FzEwT5I+hX83oTPVkHWg2gph7dAqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b89C+WDjoBzAWdyAvIeyTESJkKHIuxXpo6ReecPT/Co=; b=vf74fw8r+BOgpbeRF7ibBD4PvejNVO9DrgALKlOA875ORMoqNJVIsq3lZLJEqFSB3+/By2mcYysX6uO6pZH4VNmA/OvzDb+nD+LJ3hSv+Z+/IydQ6asO/v8YNkSZJf8grWHSJVnKvnQAWHJPL979zFC/jbdFX0ntfiP9O7CzFFs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <8bde7944-a9aa-a243-c621-9cef1c657552@citrix.com> Date: Thu, 6 Apr 2023 00:48:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH v4 3/3] tools/xen-ucode: print information about currently loaded ucode Content-Language: en-GB To: Jan Beulich , Sergey Dyasli Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230404160655.2354-1-sergey.dyasli@citrix.com> <20230404160655.2354-4-sergey.dyasli@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0465.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA2PR03MB5947:EE_ X-MS-Office365-Filtering-Correlation-Id: e4e4afa7-7493-4c6b-076e-08db363047f3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wBZ5grUS58HoTF6qlg9Nh7e8YSy0viwxx8ooIhErzv84mW7EEyOKU7yLD2BR0bT7JzLOFZQ4gt9y5ZB4NX4x7dKps2+es5GEgww8qoxW3ynrY9+dxkLZqt5OsO/Fya9arm7fGIuqyqLKu5x71GvTNeqY7WKoPJHhWcKPkRDLsWWDkp+sllxTkrQtczafofhJQLx2Gr+wGXCW3Wn7sFRuxIgoozDHWueBfL5SSheutOh8xUTw3jfBUlAd1mOMZvrJmWUsCXjmkRST0Q20aGNQ9snKcYfIdnsz9t81GIX1EsmPgUmb+Ov6cVSN6RkQRpJ7aY5AXF9WEpfIrdbzQuQ9ydgXlAJjzg9FtGVYl5h8s0nhuSZY9rgf1POrF1BgPcOAcZywpPOKq3OLkEhKgDJICf6CYz0G7D71eywxqLuaRWafktplptHn+eGNGpCbqY85sZEEzwtAiDEbHfm/hk04bj1H+EEiE1k4ZBHyc+xF6Hj0vVmVLophTwTn3/KZixKmlyd5NDnf+zhDEIj2ARBB/g2AMEkArwW1Znk1V4YXBQAPV97KBUqH6UAR2Fpb/pdulq5DTKcd84lDbIzjPe+bw1iH0xANy0jFGmzeZn/oXFSMmEEUBj9DXcZ+nE0Jf9kbYT/Q9P6uJQmHIo+AuiDKMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(451199021)(31686004)(6666004)(2616005)(83380400001)(8676002)(53546011)(6506007)(6512007)(26005)(66476007)(66946007)(4326008)(66556008)(38100700002)(86362001)(2906002)(82960400001)(186003)(41300700001)(478600001)(110136005)(316002)(6636002)(36756003)(7416002)(5660300002)(8936002)(31696002)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFkrV2ZWWkNKUnNzbTF6REp2ekF2T1lqNEF5cGMzb1FKSFF1VzVMdVBkMVFY?= =?utf-8?B?c1hqNUhVQkpneXF6SzBjbFA0TVEvakRlRTdpUmc3Q0tNRE0wemhaaXYyczMw?= =?utf-8?B?OExaQklOQjV6YUFWREdTU2hNai9rdUhTTDl4WFU0RXErOFUzN1RDMmo3TkdE?= =?utf-8?B?SG93VzJKcjlpNDhpOWpDNnpoci9RUmlSZEJKNVZHU1dMNndEd1czOXdnYWo5?= =?utf-8?B?eEN5VGRGR3Y0Sk1FKzhCNlRmb1pHdTFTYkhDcVRsbzkxRGVlUUFsN1JrcTZ4?= =?utf-8?B?VXFTQ0E5RDljMWJ6RS9WTmtVS0JHc1BxS2tHeTJ2bnFyMUJrTnFnSlMzVmdH?= =?utf-8?B?VFZJSm4yYmwwbzNHajZlNnB5OGJHV1BSWFFsZHJ3ZlUwN2tnbXUwRjc0dzVx?= =?utf-8?B?UDQ2ZzN4R3lBbmlKN1diTzZRSzhFZktKVXRjOHZJdEZ6V0VPdlVNM0Q4T0Zo?= =?utf-8?B?WWhrK29zemwyYjBHbFFHRkhFYysrL1RRWlZpSWRzVENwNmZZM3NwaTBSZGhj?= =?utf-8?B?Y253OFV1VmcxN0YraGZCRnUyRi96T1ZEMU0zQXpITStTVTlwSFQzU090UVRj?= =?utf-8?B?UWE2ei9CM2tOQUNPR3czSkdOdmdVdURpdUxBRm84WnBhRTJSSkQrS1BFRFUv?= =?utf-8?B?Q2ovSzd3di9tWVR6eWwwUnhnVVl6Vk1ySFErazA2OTFRUlozT0c1WWtSQ2hC?= =?utf-8?B?UlVmVUlZajE0T3FQdTdUZ0t5YmtBaEljamlhd1pBQmxzNWdEZDEvUmFjcFpH?= =?utf-8?B?VTd4Yk01d0Q1ZEgvanlkTmVsQkl3L0tOR1cvbUtXNlBBTjJIQm1ySjcrQVVZ?= =?utf-8?B?UzZ6cmJjYUZ5WDZIcVI2WG9UOEIxTmFJOVMyS1VuVG5NMVJYMmJkQytQdGZs?= =?utf-8?B?bjBUQzVYSHFVNE0yQ21kQU9oOXl5UzNYNmhqU2U4NnlVS0M0WUVWRDlpWEZB?= =?utf-8?B?b1Y5RnZFNElZbjlYZ29Ra1loRFo3bEYwUFNITElHbDVXNlVOZ21tMVBvNTNS?= =?utf-8?B?SGhMWUFGUHF2KzBUTUM1cHNZNXNGS0lvN0dCZHdaZkd3VXBNRHg0TUczeUNH?= =?utf-8?B?bFlLVXFUamNXL1FhUzAxdXRZeVEwOGc2bHppMUNlOVdncVF3dEpGMVVrdHhr?= =?utf-8?B?TEs1L0pJRUN6T2pYQzFaQ2l3TEorVUp4b3JaQjFvbHNEcUk3NElBeGNsR3kr?= =?utf-8?B?U0xRZW9CL2xVTFlNckhhVFV5M0Fob2g4YnBrdEtjU2Erc3BVYml0MjlYL011?= =?utf-8?B?VUVzdE1mSUJMb1MrOUtvRGI3Z25heGc3cHNJWGJqNkgwYmxwNVZhck5CWWFh?= =?utf-8?B?N2hGNGIrdWpHRG5qWFMvOGtVc2RIVmRwWHoyT0toVUdWenNUTXZKeEg4NWFn?= =?utf-8?B?SnIzSEtiVGRhYTBVZ0xFMVBFc251VjUwc2pubEI5MnJyZkZMWGY1RFRiNXNx?= =?utf-8?B?cmF1b0x4M21FWVQ5NlNEaEdMOXpVNnUyNkpqWVFEdUQvcDBSVXNMdWxSR2Ra?= =?utf-8?B?N0c5dDJKdDd6V05lMTVqajFjZURkQ1lyNUNkWDF1MnVTSGk4U0YxWmREMUxt?= =?utf-8?B?cHM1akNPUVlnRm5FYzVHa1hhT2dSdXQ3UXVJTEFVejlseFhlTnJIa0VZQXl0?= =?utf-8?B?Q3FlaWZ6TGIvRkhqS1pIRnRiK2lacGRlbWFNemZ4YUlBWEZmZE1abXpxL1hO?= =?utf-8?B?ZWQzT2hKViswdlBxNkJWVEVvOUk5RzdTTFA5aUIvSmM4Vk94OURGQUk1ek9X?= =?utf-8?B?YTZROGhHNHZtemNKVmVWRmU3eXErMmN1KzMxTGFaQSswU05tK2ZTcjhEL0Jk?= =?utf-8?B?ME5FcTRnODBmcHN3OXVoTXZnWFd1NXBRdy9CM0pUK3hhQndYa3FneG9kdndB?= =?utf-8?B?dXExQ245ZzBleUhVRnVOSHlzUjJtTkp0dldHeE1wbXUxcVpsaU04SjRCdlFR?= =?utf-8?B?NW1vRGVqbEN6WHBTTjF1b2puQVJVVDUyQ25GTGEyNFZJbkZraWVxQW1BdjVC?= =?utf-8?B?ODB2QVI2OUJTYkQ3dnZWd25Ub29XTFpCcVFodnB5VkRKeEFqNm1TWUQrM2tV?= =?utf-8?B?Vm10WkptZ1RWbEswUHlQaTRZeDJNcVJSRG1MUTJoUUEydEY2R1dRY0dUdkdO?= =?utf-8?B?aVFkUzJyY2h2aDFMc3RXUEJmM3IxVDlxS0pzTVF1VEZJVUNxNTFOMC8rZXpE?= =?utf-8?B?L1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Eh6DUGPuRvjOx0T7xRY8P3tZUnwwujEpK5iX1d8noxfSftjxIMaNlhUC4arA3zE9IlG1uLWqz3WsK2DY/CoF4vYzYP8vFObiYDaIyvNlELgjwTMJC0n+aFgyrLCc9LQEBubmt6bIkJUJYtJr9TYKdYtv3kL/eqxiurYYSqG1mhKR/WvzXLdxx6Sxl9Nv6Fy3DEYr6+SJ5TxkrCvYCp/AUzhg2DNHyjmQwFRE4Bxiud84g5eUrAqyHvq//AYX9ySIIgjkIsTpeSxq/YyjnDzQdjZQAyQ5PK9mI7X14EO1tgEvwKABnllieoH/mOh/9ncmnP9ewTzYAarg253uyvsmhYORDW5yE+yPMpuaLSmu+pwOcNo8rHX9/SmXEFFWACDVGBG3Jw479fsLHV7xhpDDdjQwwTqT4bhF5eWzXKHe8U1KZ/494mG9d0beWrqvyFPEj6KQrfnTGqF+kwfVUoPfvMbF1dzgzxz67Rcxqv2cGt4eSNRGNhl5zu8Wn8vIsXFZVc7Wn7qKHVq6UkXxUaHAcuf3UVmgh4Sg22vbF9/2b2gd9JAd25b3gGBGgw4hQKHbJE0FHZbNaz88RZTvgv8C6dyyZ+aQUlkq8lKcNC8z8HXCkwnqqvJqUMroZS0CrCOW+QHs0c3FwZXzCT8GTBMZ20GJJKC+FowalHxfqTqIfjW0iIzS7Yl8dMnNXeHT+R82ZrQCpyYilngFrwJl7qhTmVfQPq86uKMto7GA0ht+uHUktutsOIceYJ26UmaRdAQ5O6FQ7vqfUxTybrK3wEca4mWPOOoYYum/uIU6JQZAzamSqJoZJ4n69TdxRYfpjpqNgOySGOf4Jur9F5/bwG8iXJcm3haUkZAacHFfx4C5/uc= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4e4afa7-7493-4c6b-076e-08db363047f3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 23:48:39.9875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eCbaLpxVs4iqbCZVncydb/L1V2vcKaKagn7GMT4WJ9dXxBSvu0iP8YwL/b0n6CYmdfCBe/KMOK7BKk3bNT2EAVst0QI78qmIt0KBXlQycXo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5947 On 05/04/2023 10:11 am, Jan Beulich wrote: > On 04.04.2023 18:06, Sergey Dyasli wrote: >> Add an option to xen-ucode tool to print the currently loaded ucode >> revision and also print it during usage info. Print CPU signature and >> platform flags as well. The raw data comes from XENPF_get_cpu_version >> and XENPF_get_ucode_revision platform ops. >> >> Example output: >> Intel: >> CPU signature 06-55-04 (raw 0x00050654) pf 0x1 revision 0x02006e05 >> >> AMD: >> CPU signature fam19h (raw 0x00a00f11) revision 0x0a0011ce > Wouldn't it make sense to also report the model number here, even if > ucode blob file names (currently) don't include it? I have debated FF-MM-SS on AMD several times. AMD do document all their CPUs consistently in hex, and I know the model tables alarmingly well now.  Furthermore, it's not a straight nibble shuffle from the raw value. So yeah, it probably is worth including.  Given that we're not guessing the Linux path of the microcode, it can replace the fam19h without any loss of information. > While for the revision always printing 8 digits is definitely helpful, I > wonder whether the two top nibbles of the raw value wouldn't better be > omitted. (I understand Andrew did ask for this, but it's unclear to me > why he extended this request to the raw fields.) For precisely the same reason.  (With a question like this, you clearly don't work frequently with microcode crossing a wide range of CPUs...) >> --- a/tools/misc/xen-ucode.c >> +++ b/tools/misc/xen-ucode.c >> @@ -12,22 +12,89 @@ >> #include >> #include >> >> +static xc_interface *xch; >> + >> +static const char intel_id[] = "GenuineIntel"; >> +static const char amd_id[] = "AuthenticAMD"; >> + >> +static void show_curr_cpu(FILE *f) >> +{ >> + int ret; >> + struct xenpf_pcpu_version cpu_ver = { .xen_cpuid = 0 }; >> + struct xenpf_ucode_revision ucode_rev = { .cpu = 0 }; > As mentioned before - the current state of the system may be > inconsistent, so I question the entire lack of a way to know of > this by using this tool (even if via a specific command line > option, defaulting to CPU0-only). It's a theoretical problem, not a practical one, and definitely not something worthy to block this patch with. Software always has more up-to-date microcode than firmware these days, and it has probably been a decade since there was a system released which could usefully function with asymmetric microcode. I know we seen it in the past, but only on truly ancient systems. >> + ret = xc_get_cpu_version(xch, &cpu_ver); >> + if ( ret ) >> + { >> + fprintf(f, "Failed to get CPU information. (err: %s)\n", >> + strerror(errno)); >> + exit(1); Use err(), which removes all the boilerplate here. >> + } >> + else if ( memcmp(cpu_ver.vendor_id, amd_id, >> + sizeof(cpu_ver.vendor_id)) == 0 ) >> + { >> + fprintf(f, "CPU signature fam%xh (raw 0x%08x) revision 0x%08x\n", >> + cpu_ver.family, ucode_rev.signature, ucode_rev.revision); >> + } >> + else >> + { >> + fprintf(f, "Unsupported CPU vendor: %s\n", cpu_ver.vendor_id); >> + exit(3); >> + } >> +} >> + >> int main(int argc, char *argv[]) >> { >> int fd, ret; >> char *filename, *buf; >> size_t len; >> struct stat st; >> - xc_interface *xch; >> + >> + xch = xc_interface_open(NULL, NULL, 0); >> + if ( xch == NULL ) >> + { >> + fprintf(stderr, "Error opening xc interface. (err: %s)\n", >> + strerror(errno)); >> + exit(1); >> + } >> >> if ( argc < 2 ) >> { >> - fprintf(stderr, >> - "xen-ucode: Xen microcode updating tool\n" >> - "Usage: %s \n", argv[0]); >> + fprintf(stderr, "xen-ucode: Xen microcode updating tool\n"); >> + show_curr_cpu(stderr); > I recall you had it this way before, but I don't see why this information > needs to be part of argument error handling. Because it is specifically useful information to be given when running xen-ucode with no arguments. But also because this patch predates Spectre/Meltdown going public, and is documented this way for XenServer. That said, the information does need correcting because it's changed to be:   "Usage: %s [show-cpu-info | ]" in this patch.  (and file is specifically more relevant than calling it a blob). ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 03:50:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 03:50:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518695.805478 (Exim 4.92) (envelope-from ) id 1pkGdx-0007pl-8L; Thu, 06 Apr 2023 03:50:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518695.805478; Thu, 06 Apr 2023 03:50:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGdx-0007pc-28; Thu, 06 Apr 2023 03:50:37 +0000 Received: by outflank-mailman (input) for mailman id 518695; Thu, 06 Apr 2023 03:50:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGdw-0007pS-Fq; Thu, 06 Apr 2023 03:50:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGdw-0003xA-C2; Thu, 06 Apr 2023 03:50:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGdv-0007gf-Oh; Thu, 06 Apr 2023 03:50:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkGdv-00033x-M7; Thu, 06 Apr 2023 03:50:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=m+3nNViPA5ifLMVWVnXf4zot/Bk2Ma4Oi1tJwW4iA7E=; b=Mtgz8Hc4QAuIes/2epi2K7CBYk +B/dAFGruCOm1CXu7+0LGQhSFhk/Qg2GT2gWJRYnDwJ0zcna2YA7ZG6eN1TP9tsH084ldSaGAbmMq tCGjeI6tz0Apx+ExYfWQsCzdRt1lzMYh83sKtCtsWY4bJBQK/cQD7tQR4aaaYQvIOEOk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180164: all pass - PUSHED X-Osstest-Versions-This: ovmf=8d185dfb66700e65035d51f149570aeab728c665 X-Osstest-Versions-That: ovmf=2bb693894920e634153275bea60278a9f192a8ef From: osstest service owner Date: Thu, 06 Apr 2023 03:50:35 +0000 flight 180164 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180164/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8d185dfb66700e65035d51f149570aeab728c665 baseline version: ovmf 2bb693894920e634153275bea60278a9f192a8ef Last test of basis 180161 2023-04-05 20:42:13 Z 0 days Testing same since 180164 2023-04-06 01:42:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2bb6938949..8d185dfb66 8d185dfb66700e65035d51f149570aeab728c665 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Apr 06 03:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 03:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518703.805494 (Exim 4.92) (envelope-from ) id 1pkGkz-00005S-5x; Thu, 06 Apr 2023 03:57:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518703.805494; Thu, 06 Apr 2023 03:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGkz-0008WB-19; Thu, 06 Apr 2023 03:57:53 +0000 Received: by outflank-mailman (input) for mailman id 518703; Thu, 06 Apr 2023 03:57:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGky-0008TM-Dh for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 03:57:52 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31275807-d42f-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 05:57:48 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BF15B5C0165; Wed, 5 Apr 2023 23:57:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 05 Apr 2023 23:57:46 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Apr 2023 23:57:45 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31275807-d42f-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1680753466; x=1680839866; bh=93qkb4vCoALCa+SR4SX+CpDYG 2G80pxkOOvzmxxSHTg=; b=iZHL7IEYk5THv6vF8b0ULbkwAYhiBr8RMmecfCf58 obuHqd+Sv8fLyCmsBK4xfR/FXE3aIYYRc0p3F0/0luH0jQu8VBnbQBYv11oeJ+vF O2455X/UV90zurzkYKkXmMACFFj2Sf36JOscKu2rmzGhsg+apZ4OapsQhEnPGp/U U5cbAK2vhYZlyf9v8Xe0X/W9bOXKvA5FRurfde+Z+jCQW7Q+JlhFDLuyu1/IUMfF k5uftt1nHYrLmvqtnUJZZ9MilASPqcjDISSQzsBefLdzKpfxmnjKHmJsLN7cRySm pZ9mTeyuB/1NQqYx1bAAar5xpURXwgTKGl4P4uOLlYUWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1680753466; x=1680839866; bh=9 3qkb4vCoALCa+SR4SX+CpDYG2G80pxkOOvzmxxSHTg=; b=EIM7B2Tj1w88q1gCt oSQAf6kBItLzqwAQNda31yo7c0jKRiYdQI3N/Hgg7xj1oy/pSM6PCwn1gzuk3iu9 5u+/I/mEn8BBhL0lRpV3DdlP25DuHZPvEZjFDrwOJQ9NStx7OiitRdFXfzCFrYwD zr6fkvpSSWpw//bnefAtcw9b4sHsIHoDlXKZa8ohASY47P6r3DQT0fCNcbcx7O1I qKSEoC3u2kHbybvAzuy8FcZmP77+Zqe8UiqKGREQQ5/VPpjEddyBgmdQRemhc0be NJD/VpK9tbgnqGK379ZbNuMqZXzbqEXa2gYhF4gjbqDcTV03xbAxX0ZwPSqcAbO3 zy8eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejvddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre dtredtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggt khhiuceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh eqnecuggftrfgrthhtvghrnhepleekhfduleetleelleetteevfeefteffkeetteejheel gfegkeelgeehhfdthedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdr tghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH v3 0/4] MSI-X support with qemu in stubdomain, and other related changes Date: Thu, 6 Apr 2023 05:57:22 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This series includes changes to make MSI-X working with Linux stubdomain and especially Intel Wifi 6 AX210 card. This takes care of remaining reasons for QEMU to access /dev/mem, but also the Intel Wifi card violating spec by putting some registers on the same page as the MSI-X table. See individual patches for details. Marek Marczykowski-Górecki (4): x86/msi: passthrough all MSI-X vector ctrl writes to device model tools/xendevicemodel: Introduce ..._get_ioreq_server_info_ext x86/hvm: Allow writes to registers on the same page as MSI-X table x86/msi: clear initial MSI-X state on boot tools/include/xendevicemodel.h | 23 ++++- tools/libs/devicemodel/core.c | 16 ++- xen/arch/x86/hvm/vmsi.c | 209 ++++++++++++++++++++++++++++++++-- xen/arch/x86/include/asm/msi.h | 5 +- xen/arch/x86/msi.c | 38 ++++++- xen/common/ioreq.c | 9 +- xen/drivers/passthrough/msi.c | 17 +++- xen/include/public/hvm/dm_op.h | 12 +- 8 files changed, 310 insertions(+), 19 deletions(-) base-commit: 881ba20eb0222305a9d2cd090c9345992794f4f5 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 03:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 03:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518702.805488 (Exim 4.92) (envelope-from ) id 1pkGky-0008Te-Tb; Thu, 06 Apr 2023 03:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518702.805488; Thu, 06 Apr 2023 03:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGky-0008TX-QJ; Thu, 06 Apr 2023 03:57:52 +0000 Received: by outflank-mailman (input) for mailman id 518702; Thu, 06 Apr 2023 03:57:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGkx-0008TM-OO for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 03:57:52 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3244fcb9-d42f-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 05:57:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D583A5C016C; Wed, 5 Apr 2023 23:57:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 05 Apr 2023 23:57:48 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Apr 2023 23:57:46 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3244fcb9-d42f-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680753468; x=1680839868; bh=Fv CSUD7PDGeiswNRgMg7zZom3rqpEr1RXA0kWfFNpvs=; b=IRBTl0BZo62ArcDldO x5wTInwPltu0N3kqFHPdwIr4rnKyHDkUHIoZsFCs1JoZbbnNdcERcr/YpwchvPRm ByRBlIHB32C0sspNmaoMEbN56XIOQ3i9aITpYQCvwqtWCExxvzS58TNapl/wrx8R JlL6z1op0nqFBlPhBfrO3ea7pUp4J5sCL13lAR2hrHXmXYO3sSyG/xoZds59CFpl GhUeiXLMKM1XHpe58mSAuAKS1DXelBO4Y1+rBMciD4TQHJ8PkJx5QBAgWhDurx84 ABvSzBULj8RGLoMdsBTs5QtFssgrHS3g8tBVqdtXuYdqvOHro9kYDknMnt5lTN3L AOtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680753468; x=1680839868; bh=FvCSUD7PDGeiswNRgMg7zZom3rqpEr1RXA0 kWfFNpvs=; b=YYVk8sH4fMz6Huu3gzMg7puPpyyK0TDy0doCcaG+0OeGjI5O2BI HZtmjOT5fLWlfxIfFTK5DeUVDljFlaNts38BYk5T4ToxgLQvh85iETLm5L9jbcWf Sf4lcPOiH24srqsVZinLiIfYXvopyqiCh16eqZIelbMd+HtuonoSu3QgKSzGMv1p f2f/gKvZNguuMn80W0F5Uwsh2HbuxbilI33fZJb1LnhepLH9oTcPJxkcLCGJS2x4 w1a3A2DezelWLI4nX7qmIDX5IopCH3o6I4gcB816eB2B1oUsZeuXFdyR+tFalPPQ o1DXE1ScJi8chnueuNYJoOmpMavDbpr3ADw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejvddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant Subject: [PATCH v3 1/4] x86/msi: passthrough all MSI-X vector ctrl writes to device model Date: Thu, 6 Apr 2023 05:57:23 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit QEMU needs to know whether clearing maskbit of a vector is really clearing, or was already cleared before. Currently Xen sends only clearing that bit to the device model, but not setting it, so QEMU cannot detect it. Because of that, QEMU is working this around by checking via /dev/mem, but that isn't the proper approach. It's just a workaround which in fact is racy. Give all necessary information to QEMU by passing all ctrl writes, including masking a vector. While this commit doesn't move the whole maskbit handling to QEMU (as discussed on xen-devel as one of the possibilities), it is a necessary first step anyway. Including telling QEMU it will get all the required information to do so. The actual implementation would need to include: - a hypercall for QEMU to control just maskbit (without (re)binding the interrupt again - a methor for QEMU to tell Xen it will actually do the work Those are not part of this series. Signed-off-by: Marek Marczykowski-Górecki --- v3: - advertise changed behavior in XEN_DMOP_get_ioreq_server_info - make "flags" parameter IN/OUT - move len check back to msixtbl_write() - will be needed there anyway in a later patch v2: - passthrough quad writes to emulator too (Jan) - (ab)use len==0 for write len=4 completion (Jan), but add descriptive #define for this magic value Should flags on output include only "out" values (current version), or also include those passed in by the caller unchanged? --- xen/arch/x86/hvm/vmsi.c | 18 ++++++++++++++---- xen/common/ioreq.c | 9 +++++++-- xen/include/public/hvm/dm_op.h | 12 ++++++++---- 3 files changed, 29 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 3cd4923060c8..231253a2cbd4 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -272,6 +272,15 @@ out: return r; } +/* + * This function returns X86EMUL_UNHANDLEABLE even if write is properly + * handled, to propagate it to the device model (so it can keep its internal + * state in sync). + * len==0 means really len==4, but as a write completion that will return + * X86EMUL_OKAY on successful processing. Use WRITE_LEN4_COMPLETION to make it + * less confusing. + */ +#define WRITE_LEN4_COMPLETION 0 static int msixtbl_write(struct vcpu *v, unsigned long address, unsigned int len, unsigned long val) { @@ -283,8 +292,9 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, unsigned long flags; struct irq_desc *desc; - if ( (len != 4 && len != 8) || (address & (len - 1)) ) - return r; + if ( (len != 4 && len != 8 && len != WRITE_LEN4_COMPLETION) || + (len && (address & (len - 1))) ) + return X86EMUL_UNHANDLEABLE; rcu_read_lock(&msixtbl_rcu_lock); @@ -345,7 +355,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, unlock: spin_unlock_irqrestore(&desc->lock, flags); - if ( len == 4 ) + if ( len == WRITE_LEN4_COMPLETION ) r = X86EMUL_OKAY; out: @@ -635,7 +645,7 @@ void msix_write_completion(struct vcpu *v) return; v->arch.hvm.hvm_io.msix_unmask_address = 0; - if ( msixtbl_write(v, ctrl_address, 4, 0) != X86EMUL_OKAY ) + if ( msixtbl_write(v, ctrl_address, WRITE_LEN4_COMPLETION, 0) != X86EMUL_OKAY ) gdprintk(XENLOG_WARNING, "MSI-X write completion failure\n"); } diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index ecb8f545e1c4..bd6f074c1e85 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -743,7 +743,8 @@ static int ioreq_server_destroy(struct domain *d, ioservid_t id) static int ioreq_server_get_info(struct domain *d, ioservid_t id, unsigned long *ioreq_gfn, unsigned long *bufioreq_gfn, - evtchn_port_t *bufioreq_port) + evtchn_port_t *bufioreq_port, + uint16_t *flags) { struct ioreq_server *s; int rc; @@ -779,6 +780,9 @@ static int ioreq_server_get_info(struct domain *d, ioservid_t id, *bufioreq_port = s->bufioreq_evtchn; } + /* Advertise supported features/behaviors. */ + *flags = XEN_DMOP_all_msix_writes; + rc = 0; out: @@ -1374,7 +1378,8 @@ int ioreq_server_dm_op(struct xen_dm_op *op, struct domain *d, bool *const_op) NULL : (unsigned long *)&data->ioreq_gfn, (data->flags & XEN_DMOP_no_gfns) ? NULL : (unsigned long *)&data->bufioreq_gfn, - &data->bufioreq_port); + &data->bufioreq_port, &data->flags); + break; } diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index acdf91693d0b..490b151c5dd7 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -70,7 +70,9 @@ typedef struct xen_dm_op_create_ioreq_server xen_dm_op_create_ioreq_server_t; * not contain XEN_DMOP_no_gfns then these pages will be made available and * the frame numbers passed back in gfns and * respectively. (If the IOREQ Server is not handling buffered emulation - * only will be valid). + * only will be valid). When Xen returns XEN_DMOP_all_msix_writes + * flag set, it will notify the IOREQ server about all writes to MSI-X table + * (if it's handled by this IOREQ server), not only those clearing a mask bit. * * NOTE: To access the synchronous ioreq structures and buffered ioreq * ring, it is preferable to use the XENMEM_acquire_resource memory @@ -81,11 +83,13 @@ typedef struct xen_dm_op_create_ioreq_server xen_dm_op_create_ioreq_server_t; struct xen_dm_op_get_ioreq_server_info { /* IN - server id */ ioservid_t id; - /* IN - flags */ + /* IN/OUT - flags */ uint16_t flags; -#define _XEN_DMOP_no_gfns 0 -#define XEN_DMOP_no_gfns (1u << _XEN_DMOP_no_gfns) +#define _XEN_DMOP_no_gfns 0 /* IN */ +#define _XEN_DMOP_all_msix_writes 1 /* OUT */ +#define XEN_DMOP_no_gfns (1u << _XEN_DMOP_no_gfns) +#define XEN_DMOP_all_msix_writes (1u << _XEN_DMOP_all_msix_writes) /* OUT - buffered ioreq port */ evtchn_port_t bufioreq_port; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 03:57:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 03:57:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518704.805508 (Exim 4.92) (envelope-from ) id 1pkGl5-0000au-CR; Thu, 06 Apr 2023 03:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518704.805508; Thu, 06 Apr 2023 03:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGl5-0000am-8G; Thu, 06 Apr 2023 03:57:59 +0000 Received: by outflank-mailman (input) for mailman id 518704; Thu, 06 Apr 2023 03:57:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGl4-0000Z1-Dt for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 03:57:58 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3328af7d-d42f-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 05:57:52 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5D6E55C0176; Wed, 5 Apr 2023 23:57:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 05 Apr 2023 23:57:50 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Apr 2023 23:57:49 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3328af7d-d42f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680753470; x=1680839870; bh=D/ T8tgnYwHUEAgL2AzdECT/ODhwEEHPrmRQMVyr6mbY=; b=hs/M75R9CPozgbKmPG ZW08qrDVQJHKNs+NsRXrC1+vytZM6C+uNBHlzFOiJzbRZcqkAUHkOubllB0BMo6J YDhRjpmig6EYPzKKpIpx084EJM1bj4LWL2YqwqZwIK67jcZKZkc51kOuPBBxnOnE kk4WjXG8cOeAg5aWO48M7w8TN6UVi8uQBwUeK8v/uXOXP1WoMOPq4spa04Zyi0PH S8gnP/f9UBIZx9Ryu25UD5ocXPi5rbALRYgFokBstGm5S4KvjriSpztjeBAo/MzI XO4rP2Pc00B0wpTx35O5DVf5/eIB3UMbDKmPr6KsCBSfQef6wexgdM2xRh+qptiE hKUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680753470; x=1680839870; bh=D/T8tgnYwHUEAgL2AzdECT/ODhwEEHPrmRQ MVyr6mbY=; b=ktX93hm1t6Ke6dLk4j4QQ76cGOlhDm/ItUtXhq7etEB9b4c5AOQ TuzxDZceQlk6Qwcgn5hMJxR/pL1BpZnwpwDXKe1dJVFsUnanWwJ470j5fLoVijC0 ZIfFFPoZHXDy7Uy8H2YpDGYRmC4dktVGxdRTUYaSPAgsH42ljyKI3L7hpe/dzGv4 +pZNkNp+rAAPtGnp4BJU4mJrBCS4lRraZ37LBWNcQ0YOmGI0p0gWnyX6zAutbveo g7uH2l+31w9ldDheps02nXVGIgT+StN53MyXl5F5+Q7gpyp8M5CaTnlQzK25FZgF Lq0HCIUZiFVcPQr8Mk7H46u8DXBJEb7XHvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejvddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v3 2/4] tools/xendevicemodel: Introduce ..._get_ioreq_server_info_ext Date: Thu, 6 Apr 2023 05:57:24 +0200 Message-Id: <1f6dc87eebe5d1c27ae15ec8f5d8006e5aa1c36d.1680752649.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add xendevicemodel_get_ioreq_server_info_ext() which additionally returns output flags that XEN_DMOP_get_ioreq_server_info can now return. Do not change signature of existing xendevicemodel_get_ioreq_server_info() so existing users will not need to be changed. This advertises behavior change of "x86/msi: passthrough all MSI-X vector ctrl writes to device model" patch. Signed-off-by: Marek Marczykowski-Górecki --- v3: - new patch Should there be some HAVE_* #define in the header? Does this change require soname bump (I hope it doesn't...). --- tools/include/xendevicemodel.h | 23 +++++++++++++++++++++++ tools/libs/devicemodel/core.c | 16 ++++++++++++++-- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/tools/include/xendevicemodel.h b/tools/include/xendevicemodel.h index 797e0c6b2961..77a99e670551 100644 --- a/tools/include/xendevicemodel.h +++ b/tools/include/xendevicemodel.h @@ -72,6 +72,29 @@ int xendevicemodel_get_ioreq_server_info( evtchn_port_t *bufioreq_port); /** + * This function retrieves the necessary information to allow an + * emulator to use an IOREQ Server, including feature flags. + * + * @parm dmod a handle to an open devicemodel interface. + * @parm domid the domain id to be serviced + * @parm id the IOREQ Server id. + * @parm ioreq_gfn pointer to a xen_pfn_t to receive the synchronous ioreq + * gfn. (May be NULL if not required) + * @parm bufioreq_gfn pointer to a xen_pfn_t to receive the buffered ioreq + * gfn. (May be NULL if not required) + * @parm bufioreq_port pointer to a evtchn_port_t to receive the buffered + * ioreq event channel. (May be NULL if not required) + * @parm flags pointer to receive flags bitmask, see hvm/dm_op.h for details. + * (May be NULL if not required) + * @return 0 on success, -1 on failure. + */ +int xendevicemodel_get_ioreq_server_info_ext( + xendevicemodel_handle *dmod, domid_t domid, ioservid_t id, + xen_pfn_t *ioreq_gfn, xen_pfn_t *bufioreq_gfn, + evtchn_port_t *bufioreq_port, + unsigned int *flags); + +/** * This function registers a range of memory or I/O ports for emulation. * * @parm dmod a handle to an open devicemodel interface. diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c index 8e619eeb0a1f..337622e608c2 100644 --- a/tools/libs/devicemodel/core.c +++ b/tools/libs/devicemodel/core.c @@ -189,10 +189,10 @@ int xendevicemodel_create_ioreq_server( return 0; } -int xendevicemodel_get_ioreq_server_info( +int xendevicemodel_get_ioreq_server_info_ext( xendevicemodel_handle *dmod, domid_t domid, ioservid_t id, xen_pfn_t *ioreq_gfn, xen_pfn_t *bufioreq_gfn, - evtchn_port_t *bufioreq_port) + evtchn_port_t *bufioreq_port, unsigned int *flags) { struct xen_dm_op op; struct xen_dm_op_get_ioreq_server_info *data; @@ -226,9 +226,21 @@ int xendevicemodel_get_ioreq_server_info( if (bufioreq_port) *bufioreq_port = data->bufioreq_port; + if (flags) + *flags = data->flags; + return 0; } +int xendevicemodel_get_ioreq_server_info( + xendevicemodel_handle *dmod, domid_t domid, ioservid_t id, + xen_pfn_t *ioreq_gfn, xen_pfn_t *bufioreq_gfn, + evtchn_port_t *bufioreq_port) +{ + return xendevicemodel_get_ioreq_server_info_ext( + dmod, domid, id, ioreq_gfn, bufioreq_gfn, bufioreq_port, NULL); +} + int xendevicemodel_map_io_range_to_ioreq_server( xendevicemodel_handle *dmod, domid_t domid, ioservid_t id, int is_mmio, uint64_t start, uint64_t end) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 03:58:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 03:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518705.805518 (Exim 4.92) (envelope-from ) id 1pkGl6-0000ra-P4; Thu, 06 Apr 2023 03:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518705.805518; Thu, 06 Apr 2023 03:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGl6-0000rP-LT; Thu, 06 Apr 2023 03:58:00 +0000 Received: by outflank-mailman (input) for mailman id 518705; Thu, 06 Apr 2023 03:57:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGl4-0000Z1-OO for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 03:57:58 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 350fda72-d42f-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 05:57:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8C1395C0165; Wed, 5 Apr 2023 23:57:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 05 Apr 2023 23:57:53 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Apr 2023 23:57:52 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 350fda72-d42f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680753473; x=1680839873; bh=jp uAaW3PocLxTjAz2gz/L9CxKTd3JuRdv2jiYB1F7uE=; b=CMyh8xUt2/XeuWuWly QYaK3x37WG6/AWwaIZouaj79YATV2yngaZrUzknYh5QowZWBFh8jqXeuLVObvZsp EZE0DMqwRYJUkzmwYTClsVB1dg4iirEZfdyvq0mHZfCz7LNXg5CSauXqCHeUWhiV YE4lVs3VIouNSDtQawOyHbvr4APMvSpJXF/IafpEAFG7rFTsoiaODXyGRBT4wj1Z ghEhB/i5rGNoRC3hDHGh8QtTA/k51E0jqx7U0R2eLnzNYm5NHSdlkPABbEIBU1Nd eUV0aDGEbVyIBDpsZfYMzeCDa0ZA2cpKi5K/Hah2cDHEUdniq446RRdL1xeb2pGY iTpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680753473; x=1680839873; bh=jpuAaW3PocLxTjAz2gz/L9CxKTd3JuRdv2j iYB1F7uE=; b=U4DzV7PsTmqf1zaY1JwFd6kf2wa5MT3kKgH82/AHh332No6k4/d QPIvFWtiX3FUUpUkvM4ILD60sx/zRjWLPJPdcmNz0+FJW942jK6mi087jjplNb+C SJWxzeY8D6mGriqv6gLVPe+WYVG1nsckhKVUdvY89Rp3DGD82V5AZxvQyiNPABoF r3ITXR9HRxVWutswrFJA2h85BTCQoFbku9uLbETBbXxv5TPbD3ozYjWAbuu0onx6 p3qskz8xSy93PsRGgHXcEwQOOSpJNTjC/iAxbHzfKfZRJiQS7oz8d2XwXS4gqJ4c XGWQhfK5yfh+4qubnwk0zJoFTPeD+M3PVPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejvddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jason Andryuk , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 4/4] x86/msi: clear initial MSI-X state on boot Date: Thu, 6 Apr 2023 05:57:26 +0200 Message-Id: <6984a8571dac35d04c85117834d99b00fe1c4184.1680752649.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some firmware/devices are found to not reset MSI-X properly, leaving MASKALL set. Jason reports on his machine MASKALL persists through a warm reboot, but is cleared on cold boot. Xen relies on initial state being MASKALL clear. Especially, pci_reset_msix_state() assumes if MASKALL is set, it was Xen setting it due to msix->host_maskall or msix->guest_maskall. Clearing just MASKALL might be unsafe if ENABLE is set, so clear them both. Reported-by: Jason Andryuk Signed-off-by: Marek Marczykowski-Górecki --- v3: - update comment - clear bits only when they were set --- xen/drivers/passthrough/msi.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/xen/drivers/passthrough/msi.c b/xen/drivers/passthrough/msi.c index ce1a450f6f4a..c9f7eac29ebf 100644 --- a/xen/drivers/passthrough/msi.c +++ b/xen/drivers/passthrough/msi.c @@ -46,6 +46,23 @@ int pdev_msi_init(struct pci_dev *pdev) spin_lock_init(&msix->table_lock); ctrl = pci_conf_read16(pdev->sbdf, msix_control_reg(pos)); + + if ( ctrl & (PCI_MSIX_FLAGS_MASKALL|PCI_MSIX_FLAGS_ENABLE) ) + { + /* + * pci_reset_msix_state() relies on MASKALL not being set + * initially, clear it (and ENABLE too - for safety), to meet that + * expectation. + */ + printk(XENLOG_WARNING + "%pp: unexpected initial MSI-X state (MASKALL=%d, ENABLE=%d), fixing\n", + &pdev->sbdf, + (ctrl & PCI_MSIX_FLAGS_MASKALL) ? 1 : 0, + (ctrl & PCI_MSIX_FLAGS_ENABLE) ? 1 : 0); + ctrl &= ~(PCI_MSIX_FLAGS_ENABLE|PCI_MSIX_FLAGS_MASKALL); + pci_conf_write16(pdev->sbdf, msix_control_reg(pos), ctrl); + } + msix->nr_entries = msix_table_size(ctrl); pdev->msix = msix; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 03:58:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 03:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518706.805522 (Exim 4.92) (envelope-from ) id 1pkGl7-0000vY-2n; Thu, 06 Apr 2023 03:58:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518706.805522; Thu, 06 Apr 2023 03:58:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGl6-0000ue-Ur; Thu, 06 Apr 2023 03:58:00 +0000 Received: by outflank-mailman (input) for mailman id 518706; Thu, 06 Apr 2023 03:57:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkGl5-0000Z1-3G for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 03:57:59 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3428a853-d42f-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 05:57:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0D6C75C0178; Wed, 5 Apr 2023 23:57:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 05 Apr 2023 23:57:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Apr 2023 23:57:50 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3428a853-d42f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680753472; x=1680839872; bh=+x aJZckXvX1k1Bf8G7KYguuLRWvLEosFkkfVW7RbnBc=; b=kJXc197cjVxU8s7j8L ClSe15MEgoDBr304tK+Dvx8Vu/B3o+r+ND+29+fBrtcmiZd9rtUNuUHNx7wvyNzi 928xmpQWPrY6hF5fJvKrWyokQFVbrhC0PqGQtwP4HCOg0WcnzX+yxtwhpMelDqxX 3yFPWKS2f5chuIamgCgfpqdZTXh/VW5l2/1N3bRkSHXf51coS2s8LoD9YnPqTZS8 GElwbf9qNNPIqiTfVIh+LEfUNkfBQ/3XqDoEm98MwINYOgiQYjBA1v7Eur9bX93f 5LKv6euFZx+xVin8gsVhG2QjJr4320TEdmRxXd7a1JMlT7PpAE3jwM80Pe1MHy7Z XeMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680753472; x=1680839872; bh=+xaJZckXvX1k1Bf8G7KYguuLRWvLEosFkkf VW7RbnBc=; b=fBMwm7xs3ACD/y3xTi8IHfZCtBWI47c3FFWWbP+YTMJ3otiDb3W DIrsifgHeTM0BJ1ZshuUJ5H1GbmxliLMJLV2zIqOjopZjNWXOc/GVVE1ALLR4xmz a6lTn9xF1Pf3zem7szRxYS/7M2kvlfFpw98mhGRGGWCoyjH2DilDnq2Slj9nXWZE 5P7/giIpYJcyO3m0btql70vXmnfwgBUIKQ5KmqUai/atmtd0X1AWfSrGPOGB0Fsw QQ//Dk4ivg79EDCiN4oaJer8j1W3SpNtx+1U6TztpKjLvwZWcJ7PKvcmcj+4Q0aO aTpFCtzCJeQS9KrK1EIodxL+wJeo7MtHTIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejvddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 3/4] x86/hvm: Allow writes to registers on the same page as MSI-X table Date: Thu, 6 Apr 2023 05:57:25 +0200 Message-Id: <3a8f54cf631e0342b144935950c853d1884a7eac.1680752649.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers on the same page as MSI-X table. Device model (especially one in stubdomain) cannot really handle those, as direct writes to that page is refused (page is on the mmio_ro_ranges list). Instead, extend msixtbl_mmio_ops to handle such accesses too. Doing this, requires correlating write location with guest view of MSI-X table address. Since QEMU doesn't map MSI-X table to the guest, it requires msixtbl_entry->gtable, which is HVM-only. Similar feature for PV would need to be done separately. This will be also used to read Pending Bit Array, if it lives on the same page, making QEMU not needing /dev/mem access at all (especially helpful with lockdown enabled in dom0). If PBA lives on another page, QEMU will map it to the guest directly. If PBA lives on the same page, discard writes and log a message. Technically, writes outside of PBA could be allowed, but at this moment the precise location of PBA isn't saved, and also no known device abuses the spec in this way (at least yet). To access those registers, msixtbl_mmio_ops need the relevant page mapped. MSI handling already has infrastructure for that, using fixmap, so try to map first/last page of the MSI-X table (if necessary) and save their fixmap indexes. Note that msix_get_fixmap() does reference counting and reuses existing mapping, so just call it directly, even if the page was mapped before. Also, it uses a specific range of fixmap indexes which doesn't include 0, so use 0 as default ("not mapped") value - which simplifies code a bit. GCC gets confused about 'desc' variable: arch/x86/hvm/vmsi.c: In function ‘msixtbl_range’: arch/x86/hvm/vmsi.c:553:8: error: ‘desc’ may be used uninitialized [-Werror=maybe-uninitialized] 553 | if ( desc ) | ^ arch/x86/hvm/vmsi.c:537:28: note: ‘desc’ was declared here 537 | const struct msi_desc *desc; | ^~~~ It's conditional initialization is actually correct (in the case where it isn't initialized, function returns early), but to avoid build failure initialize it explicitly to NULL anyway. Signed-off-by: Marek Marczykowski-Górecki --- v3: - merge handling into msixtbl_mmio_ops - extend commit message v2: - adjust commit message - pass struct domain to msixtbl_page_handler_get_hwaddr() - reduce local variables used only once - log a warning if write is forbidden if MSI-X and PBA lives on the same page - do not passthrough unaligned accesses - handle accesses both before and after MSI-X table --- xen/arch/x86/hvm/vmsi.c | 199 ++++++++++++++++++++++++++++++++-- xen/arch/x86/include/asm/msi.h | 5 +- xen/arch/x86/msi.c | 38 ++++++- 3 files changed, 231 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 231253a2cbd4..6f49493d3f58 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -181,15 +181,21 @@ static bool msixtbl_initialised(const struct domain *d) } static struct msixtbl_entry *msixtbl_find_entry( - struct vcpu *v, unsigned long addr) + struct vcpu *v, unsigned long addr, bool same_page) { struct msixtbl_entry *entry; struct domain *d = v->domain; list_for_each_entry( entry, &d->arch.hvm.msixtbl_list, list ) + { + if ( same_page && + PFN_DOWN(addr) >= PFN_DOWN(entry->gtable) && + PFN_DOWN(addr) <= PFN_DOWN(entry->gtable + entry->table_len) ) + return entry; if ( addr >= entry->gtable && addr < entry->gtable + entry->table_len ) return entry; + } return NULL; } @@ -213,6 +219,144 @@ static struct msi_desc *msixtbl_addr_to_desc( return NULL; } +/* + * Returns: + * - UINT_MAX if no handling should be done + * - UINT_MAX-1 if write should be discarded + * - a fixmap idx to use for handling + */ +#define ADJACENT_DONT_HANDLE UINT_MAX +#define ADJACENT_DISCARD_WRITE (UINT_MAX - 1) +static unsigned int adjacent_handle( + const struct msixtbl_entry *entry, unsigned long addr, bool write) +{ + unsigned int adj_type; + + if ( !entry || !entry->pdev ) + return ADJACENT_DONT_HANDLE; + + if ( PFN_DOWN(addr) == PFN_DOWN(entry->gtable) && addr < entry->gtable ) + adj_type = ADJ_IDX_FIRST; + else if ( PFN_DOWN(addr) == PFN_DOWN(entry->gtable + entry->table_len - 1) && + addr >= entry->gtable + entry->table_len ) + adj_type = ADJ_IDX_LAST; + else + return ADJACENT_DONT_HANDLE; + + ASSERT(entry->pdev->msix); + + if ( !entry->pdev->msix->adj_access_table_idx[adj_type] ) + { + gprintk(XENLOG_WARNING, + "Page for adjacent(%d) MSI-X table access not initialized for %pp (addr %#lx, gtable %#lx\n", + adj_type, &entry->pdev->sbdf, addr, entry->gtable); + + return ADJACENT_DONT_HANDLE; + } + + /* If PBA lives on the same page too, discard writes. */ + if ( write && ( + (adj_type == ADJ_IDX_LAST && + entry->pdev->msix->table.last == entry->pdev->msix->pba.first) || + (adj_type == ADJ_IDX_FIRST && + entry->pdev->msix->table.first == entry->pdev->msix->pba.last)) ) + { + gprintk(XENLOG_WARNING, + "MSI-X table and PBA of %pp live on the same page, " + "writing to other registers there is not implemented\n", + &entry->pdev->sbdf); + return ADJACENT_DISCARD_WRITE; + } + + return entry->pdev->msix->adj_access_table_idx[adj_type]; +} + +static int adjacent_read( + unsigned int fixmap_idx, + uint64_t address, uint32_t len, uint64_t *pval) +{ + const void __iomem *hwaddr; + + *pval = ~0UL; + + if ( !IS_ALIGNED(address, len) ) + { + gdprintk(XENLOG_WARNING, + "Dropping unaligned read from MSI-X table page at %" PRIx64 "\n", + address); + return X86EMUL_OKAY; + } + + ASSERT(fixmap_idx != ADJACENT_DISCARD_WRITE); + + hwaddr = fix_to_virt(fixmap_idx) + PAGE_OFFSET(address); + + switch ( len ) + { + case 1: + *pval = readb(hwaddr); + break; + + case 2: + *pval = readw(hwaddr); + break; + + case 4: + *pval = readl(hwaddr); + break; + + case 8: + *pval = readq(hwaddr); + break; + + default: + ASSERT_UNREACHABLE(); + } + return X86EMUL_OKAY; +} + +static int adjacent_write( + unsigned int fixmap_idx, + uint64_t address, uint32_t len, uint64_t val) +{ + void __iomem *hwaddr; + + if ( !IS_ALIGNED(address, len) ) + { + gdprintk(XENLOG_WARNING, + "Dropping unaligned write to MSI-X table page at %" PRIx64 "\n", + address); + return X86EMUL_OKAY; + } + + if ( fixmap_idx == ADJACENT_DISCARD_WRITE ) + return X86EMUL_OKAY; + + hwaddr = fix_to_virt(fixmap_idx) + PAGE_OFFSET(address); + + switch ( len ) { + case 1: + writeb(val, hwaddr); + break; + + case 2: + writew(val, hwaddr); + break; + + case 4: + writel(val, hwaddr); + break; + + case 8: + writeq(val, hwaddr); + break; + + default: + ASSERT_UNREACHABLE(); + } + return X86EMUL_OKAY; +} + static int cf_check msixtbl_read( const struct hvm_io_handler *handler, uint64_t address, uint32_t len, uint64_t *pval) @@ -220,16 +364,27 @@ static int cf_check msixtbl_read( unsigned long offset; struct msixtbl_entry *entry; unsigned int nr_entry, index; + unsigned int adjacent_fixmap; int r = X86EMUL_UNHANDLEABLE; - if ( (len != 4 && len != 8) || (address & (len - 1)) ) + if ( !IS_ALIGNED(address, len) ) return r; rcu_read_lock(&msixtbl_rcu_lock); - - entry = msixtbl_find_entry(current, address); + entry = msixtbl_find_entry(current, address, true); if ( !entry ) goto out; + + adjacent_fixmap = adjacent_handle(entry, address, false); + if ( adjacent_fixmap != ADJACENT_DONT_HANDLE ) + { + r = adjacent_read(adjacent_fixmap, address, len, pval); + goto out; + } + + if ( len != 4 && len != 8 ) + goto out; + offset = address & (PCI_MSIX_ENTRY_SIZE - 1); if ( offset != PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET ) @@ -291,16 +446,29 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, int r = X86EMUL_UNHANDLEABLE; unsigned long flags; struct irq_desc *desc; + unsigned int adjacent_fixmap; - if ( (len != 4 && len != 8 && len != WRITE_LEN4_COMPLETION) || - (len && (address & (len - 1))) ) - return X86EMUL_UNHANDLEABLE; + if ( len && !IS_ALIGNED(address, len) ) + return r; rcu_read_lock(&msixtbl_rcu_lock); - entry = msixtbl_find_entry(v, address); + entry = msixtbl_find_entry(v, address, true); if ( !entry ) goto out; + + if ( len != WRITE_LEN4_COMPLETION ) + { + adjacent_fixmap = adjacent_handle(entry, address, true); + if ( adjacent_fixmap != ADJACENT_DONT_HANDLE ) + { + r = adjacent_write(adjacent_fixmap, address, len, val); + goto out; + } + if ( len != 4 && len != 8 ) + goto out; + } + nr_entry = array_index_nospec(((address - entry->gtable) / PCI_MSIX_ENTRY_SIZE), MAX_MSIX_TABLE_ENTRIES); @@ -375,14 +543,23 @@ static bool cf_check msixtbl_range( { struct vcpu *curr = current; unsigned long addr = r->addr; - const struct msi_desc *desc; + struct msixtbl_entry *entry; + const struct msi_desc *desc = NULL; + unsigned int adjacent_fixmap; + ASSERT(r->type == IOREQ_TYPE_COPY); rcu_read_lock(&msixtbl_rcu_lock); - desc = msixtbl_addr_to_desc(msixtbl_find_entry(curr, addr), addr); + entry = msixtbl_find_entry(curr, addr, true); + adjacent_fixmap = adjacent_handle(entry, addr, false); + if ( adjacent_fixmap == ADJACENT_DONT_HANDLE ) + desc = msixtbl_addr_to_desc(entry, addr); rcu_read_unlock(&msixtbl_rcu_lock); + if ( adjacent_fixmap != ADJACENT_DONT_HANDLE ) + return 1; + if ( desc ) return 1; @@ -627,7 +804,7 @@ void msix_write_completion(struct vcpu *v) uint32_t data; rcu_read_lock(&msixtbl_rcu_lock); - desc = msixtbl_addr_to_desc(msixtbl_find_entry(v, snoop_addr), + desc = msixtbl_addr_to_desc(msixtbl_find_entry(v, snoop_addr, false), snoop_addr); rcu_read_unlock(&msixtbl_rcu_lock); diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h index a53ade95c9ad..d13cf1c1f873 100644 --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -207,6 +207,10 @@ struct msg_address { PCI_MSIX_ENTRY_SIZE + \ (~PCI_MSIX_BIRMASK & (PAGE_SIZE - 1))) +/* indexes in adj_access_table_idx[] below */ +#define ADJ_IDX_FIRST 0 +#define ADJ_IDX_LAST 1 + struct arch_msix { unsigned int nr_entries, used_entries; struct { @@ -214,6 +218,7 @@ struct arch_msix { } table, pba; int table_refcnt[MAX_MSIX_TABLE_PAGES]; int table_idx[MAX_MSIX_TABLE_PAGES]; + int adj_access_table_idx[2]; spinlock_t table_lock; bool host_maskall, guest_maskall; domid_t warned; diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index d0bf63df1def..c216acbf0e5d 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -961,6 +961,34 @@ static int msix_capability_init(struct pci_dev *dev, domain_crash(d); /* XXX How to deal with existing mappings? */ } + + /* + * If the MSI-X table doesn't start at the page boundary, map the first page for + * passthrough accesses. + */ + if ( PAGE_OFFSET(table_paddr) ) + { + int idx = msix_get_fixmap(msix, table_paddr, table_paddr); + + if ( idx > 0 ) + msix->adj_access_table_idx[ADJ_IDX_FIRST] = idx; + else + gprintk(XENLOG_ERR, "Failed to map first MSI-X table page: %d\n", idx); + } + /* + * If the MSI-X table doesn't span full page(s), map the last page for + * passthrough accesses. + */ + if ( PAGE_OFFSET(table_paddr + msix->nr_entries * PCI_MSIX_ENTRY_SIZE) ) + { + uint64_t entry_paddr = table_paddr + msix->nr_entries * PCI_MSIX_ENTRY_SIZE; + int idx = msix_get_fixmap(msix, table_paddr, entry_paddr); + + if ( idx > 0 ) + msix->adj_access_table_idx[ADJ_IDX_LAST] = idx; + else + gprintk(XENLOG_ERR, "Failed to map last MSI-X table page: %d\n", idx); + } } WARN_ON(msix->table.first != (table_paddr >> PAGE_SHIFT)); ++msix->used_entries; @@ -1090,6 +1118,16 @@ static void _pci_cleanup_msix(struct arch_msix *msix) WARN(); msix->table.first = 0; msix->table.last = 0; + if ( msix->adj_access_table_idx[ADJ_IDX_FIRST] ) + { + msix_put_fixmap(msix, msix->adj_access_table_idx[ADJ_IDX_FIRST]); + msix->adj_access_table_idx[ADJ_IDX_FIRST] = 0; + } + if ( msix->adj_access_table_idx[ADJ_IDX_LAST] ) + { + msix_put_fixmap(msix, msix->adj_access_table_idx[ADJ_IDX_LAST]); + msix->adj_access_table_idx[ADJ_IDX_LAST] = 0; + } if ( rangeset_remove_range(mmio_ro_ranges, msix->pba.first, msix->pba.last) ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 05:54:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 05:54:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518727.805538 (Exim 4.92) (envelope-from ) id 1pkIZp-0006fZ-CI; Thu, 06 Apr 2023 05:54:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518727.805538; Thu, 06 Apr 2023 05:54:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkIZp-0006fS-9Z; Thu, 06 Apr 2023 05:54:29 +0000 Received: by outflank-mailman (input) for mailman id 518727; Thu, 06 Apr 2023 05:54:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkIZn-0006fG-Hx for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 05:54:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0618.outbound.protection.outlook.com [2a01:111:f400:fe0e::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b0ca530-d43f-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 07:54:23 +0200 (CEST) Received: from AS8PR05CA0005.eurprd05.prod.outlook.com (2603:10a6:20b:311::10) by AS8PR08MB5896.eurprd08.prod.outlook.com (2603:10a6:20b:294::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Thu, 6 Apr 2023 05:54:11 +0000 Received: from AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::32) by AS8PR05CA0005.outlook.office365.com (2603:10a6:20b:311::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30 via Frontend Transport; Thu, 6 Apr 2023 05:54:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT017.mail.protection.outlook.com (100.127.140.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.18 via Frontend Transport; Thu, 6 Apr 2023 05:54:10 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 06 Apr 2023 05:54:10 +0000 Received: from a116dc8fa01a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DD35CB03-1301-47DC-8E1F-83A78E497BA7.1; Thu, 06 Apr 2023 05:54:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a116dc8fa01a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 06 Apr 2023 05:54:04 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com (2603:10a6:208:ff::27) by PA4PR08MB5966.eurprd08.prod.outlook.com (2603:10a6:102:ee::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Thu, 6 Apr 2023 05:53:57 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::7b58:72de:8c37:5104]) by AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::7b58:72de:8c37:5104%6]) with mapi id 15.20.6254.033; Thu, 6 Apr 2023 05:53:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b0ca530-d43f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oY4jx1GTbRwnlCdCm9O33GMybE9G6DdERn2IfAZfgFw=; b=kvuJATbuFyao9DC3bMq24h1W6Vx+mpnaDSVteW7unkqYr8nuS7z5zo9Kw8OTAlGLo0l1X33aKWAmifosElXgmyPGBFqRwMpZQk0YZRNLfKimG/JEmb8daX1ImguN6yJyD14sHItdH2xqBKm0xPQzr6IqXNKWKiLSaFf9aSCqa+w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f3424a9ff9d72e78 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+ui8UZbw7a/YVI/klLz5RrvgL8pEzPkNOamcMK0MT7T5/lRjVL2/JVAx2RmQQ81Ij4JEE5UTUEbIH/VQdAE34TTvKOwNw1rdfnjRnf9E5zVn8Fispc6LF6MaOfsMi5m8UulsFCSKPquh+Tom44lVMeHwEbpGD4HHLDerXuJYXlYgs7tTqS/UOvT2uVXc9Tjw4x++MIpRpjnbAPQwoo5W9sz3cgZjSEtyTelYqGgDQSDpnAe5pEyUomDODpwfsEDh35JatM41dR6AH4sqY8IIcARH9nUAxGJx0Xa0XJgky/AM7og8p5NQUiGwotARNdCxxKs8tSf7em9b9WSXdPJ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oY4jx1GTbRwnlCdCm9O33GMybE9G6DdERn2IfAZfgFw=; b=GXrMu+W94DMnFE1sX23cZWTeGOznRY8o7HXB7WR+OVckROmZ5UqO/etVtGlSiIMffsT1iB1y0s7n5b42Y31ZNMOcGNke7yG0QFwg5P0+q/09kduMbgd2YDLJlRLJaUrDBROc7rDoJZODnVhH/O4swFz8tZDxQ5Bmp79Zqmhk8R80bNH4T+bDc2709X3dTpTST7gkc+O5lB4B2WVBwAW6qPFzRyEldtbm+qTTZDlbQgCuFotYXgI8TmD/yxpcbbiRtoKxNhRE8zB+TDDQFwyAqtXDmnsZ1ik1/GM9sN8xiJczfKsCvMlIDgVRk5Y0W9uYSNNmU8b2Iwdn3MKq1kEzyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oY4jx1GTbRwnlCdCm9O33GMybE9G6DdERn2IfAZfgFw=; b=kvuJATbuFyao9DC3bMq24h1W6Vx+mpnaDSVteW7unkqYr8nuS7z5zo9Kw8OTAlGLo0l1X33aKWAmifosElXgmyPGBFqRwMpZQk0YZRNLfKimG/JEmb8daX1ImguN6yJyD14sHItdH2xqBKm0xPQzr6IqXNKWKiLSaFf9aSCqa+w= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross , George Dunlap Subject: Re: [PATCH v4 10/12] xen/tools: add sve parameter in XL configuration Thread-Topic: [PATCH v4 10/12] xen/tools: add sve parameter in XL configuration Thread-Index: AQHZYJtmX5JG1Zpok0mjr+irvDjf6q8U92AAgAY/qICAAap2gIAA9ZmA Date: Thu, 6 Apr 2023 05:53:57 +0000 Message-ID: <15401568-22E5-48B0-8F8C-9CBC50BF883A@arm.com> References: <20230327105944.1360856-1-luca.fancellu@arm.com> <20230327105944.1360856-11-luca.fancellu@arm.com> <9bd2924b-bb4a-440d-ae31-0253e66c56e5@perard> <328A9CBD-5FCE-481B-93AF-D139963488D5@arm.com> <8921a9ca-7284-44ce-8ce5-bc631b0980d6@perard> In-Reply-To: <8921a9ca-7284-44ce-8ce5-bc631b0980d6@perard> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3745:EE_|PA4PR08MB5966:EE_|AM7EUR03FT017:EE_|AS8PR08MB5896:EE_ X-MS-Office365-Filtering-Correlation-Id: a64e1e91-1b54-4382-1229-08db36635812 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CDWvoQ4DIhztbTfWtCBkcfvEKHYM3swLmQXFgZ5IZ9WPAdihAC08vwTlkUDwl2jZeAcwQ6IaHeGulVdvhb0WM5BVm4FBfAlMf82A+vSSPY2a2Y3qmSPa3EEAMK5jBq/8IdgWz30B963rfjXuYpb/znzuXP78kXqM8Kzf7GnZmJ4+7zudy5XMB/wIQXqfuTkdkjw8LZpbqnNyaQnnu5QyGVZ8Bt1sSWD1YtOVe/Yd3gSWKkBMx4hlD/OhlSgkaOw1XooyMmS5E3DnWAkEeuT5NBPTYR1W9pFP8n2sqtyzPkYDPG9AzcJmziBkMnAFdH+5bZu/BLgFLXhqYOxysvK5yn+VR47zXjqyjxNmLSAcSvwDuUUelZgZWF2YcabdFNdyct1mjM7vuafEjid7n7Q/wKsMj7V9oJLgWBoa/dH1RB+9fsq52/SLov7ZBT7HffARLfsGa9g9JCs7oyi2EWpEFLyPJV2RIRDr4nEjH3u3IjsIMkOAX0fW4rf+vjNActp7r9qg0Nja+yKghvt7zOJ/mff8b9wTqsEQ5WIIKatGQ04GRDc4cTNkOuOmHF/djtFsl4vRrtTafeRZv52JZ0jx/QQrL/tQDdMNwcsAtY8AQmwM/dw+bwHgVgPAQO/pgr7nONmmkPoKKJT5GmfD5qT2NA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3745.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(451199021)(2906002)(36756003)(38070700005)(40140700001)(33656002)(86362001)(6486002)(71200400001)(2616005)(83380400001)(186003)(26005)(6512007)(6506007)(76116006)(66476007)(8676002)(66946007)(66446008)(6916009)(41300700001)(66556008)(38100700002)(64756008)(91956017)(122000001)(5660300002)(54906003)(478600001)(316002)(8936002)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <7FC05514D620864F8E8740245053C59B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5966 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 27067f1d-4208-44a2-5abe-08db3663500e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YWojoA5nL//zNN9BIfLeRrMmPHfdU8gYjZDAcQt0lZS6rSHYPfeFi7GE/6oG+0aII44DXvEl4/RX7IBEcrwKnRYMeXa54oPSanJs2BQuuwdfDw+22lG13cjR8MVl8zjO7LPiId1WTo8GFoJgwGf/o/kjF+jECb59ke6IiUyJc/g26QTu4hwygIfcfERi6If/jJNqbd0ehCt7ZHQVMbV2B6C3Jwb13f4OtldNxfI7Dy5xn+gmxgRG/OmHloqlx8LmT17J8NNYr6Hz0b1t4hkNFh0nhtQfdT5UwGF3qPk6RF5I2OuVtuMruCzOyf9p3Zl4JOx0nksNs4DivBdKQADcINCpkkOIvJFI2s92JwoXsl05QseicNPjJUDTqnSgrRwe8tf2XOvsI5N4SIOXyViNNVqWlJfI71SQL8WASvC8/IJsz6UEEtmTo2QGjmtYClf5QHQ+bzyo8gGHoDjrh4S0vC/gIXGhgl1sC5/FviUbcKdtp0Je4uGJH5+pDGElqJJR017Oqpy4SYDlFQhYBAzgFvOFmS+LLPMFpQwIreMrhEo1bbwUHww2U+ufu0BaNp+/WjFWAQQ2GZCtwUkvbvP7tq4elTiQF4qoH9Q4H2U29BoLJuJLVZyYL66AezvW1HIwn0I60YF0mqGs5+z+jn5QIs4F+D8tE7mXbjY9BFjni+zEeQ3C5SkB2kycrD3fAhq4AxMRmDagp/f0f7jm0S1z6g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(136003)(346002)(451199021)(36840700001)(40470700004)(46966006)(40460700003)(40140700001)(33656002)(5660300002)(2906002)(4326008)(36756003)(40480700001)(82310400005)(356005)(81166007)(41300700001)(6862004)(8936002)(70586007)(8676002)(86362001)(70206006)(82740400003)(2616005)(336012)(47076005)(6512007)(36860700001)(83380400001)(186003)(26005)(54906003)(107886003)(6486002)(6506007)(316002)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 05:54:10.9829 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a64e1e91-1b54-4382-1229-08db36635812 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5896 SGkgQW50aG9ueSwNCg0KPj4gDQo+PiBZZXMgSSBjYW4gY2hhbmdlIGl0LCBhIG5lZWQgdG8gZG8g aXQgYW55d2F5IGJlY2F1c2UgSSB0aGluayBhbHNvIGhlcmUsIHRoZSBzdWdnZXN0aW9uDQo+PiBG cm9tIEphbiBjYW4gYXBwbHkgYW5kIHdlIGNvdWxkIHBhc3MgYSBuZWdhdGl2ZSB2YWx1ZSB0aGF0 IG1lYW5zIOKAnG1heCBWTCBzdXBwb3J0ZWQNCj4+IGJ5IHRoZSBwbGF0Zm9ybSINCj4gDQo+IFdl bGwsIGl0J3MgYSBjb25maWcgZmlsZSwgbm90IGEgQyBBQkksIHNvIG1heCBhbGxvd2VkIGhlcmUg ZG9lc24ndCBoYXZlIHRvIGJlDQo+IHNwZWxsZWQgIi0xIiwgaXQgY291bGQgYWxzbyBiZSAibWF4 IiwgIm1heC1hbGxvd2VkIiwNCj4gIm1heC1zaXplLXN1cHBvcnRlZCIsIC4uLiBTbyBmaWxsIGZy ZWUgZGV2aWF0ZSBmcm9tIHRoZSByZXN0cmljdGVkIEMNCj4gQUJJLiBCdXQgIi0xIiB3b3JrcyBh cyBsb25nIGFzIGl0J3MgdGhlIG9ubHkgYWxsb3dlZCBuZWdhdGl2ZSBudW1iZXIuDQoNClllcyB3 aGlsZSB3b3JraW5nIG9uIHRoZSBwYXRjaCBJ4oCZdmUgZm91bmQgdGhhdCBJIGNvdWxkIGRlY2xh cmUgdGhpcyB0eXBlIGluIExpYnhsOg0KDQpsaWJ4bF9zdmVfdHlwZSA9IEVudW1lcmF0aW9uKCJz dmVfdHlwZSIsIFsNCiAgICAoMCwgImRpc2FibGVkIiksDQogICAgKDEyOCwgIjEyOCIpLA0KICAg ICgyNTYsICIyNTYiKSwNCiAgICAoMzg0LCAiMzg0IiksDQogICAgKDUxMiwgIjUxMiIpLA0KICAg ICg2NDAsICI2NDAiKSwNCiAgICAoNzY4LCAiNzY4IiksDQogICAgKDg5NiwgIjg5NiIpLA0KICAg ICgxMDI0LCAiMTAyNCIpLA0KICAgICgxMTUyLCAiMTE1MiIpLA0KICAgICgxMjgwLCAiMTI4MCIp LA0KICAgICgxNDA4LCAiMTQwOCIpLA0KICAgICgxNTM2LCAiMTUzNiIpLA0KICAgICgxNjY0LCAi MTY2NCIpLA0KICAgICgxNzkyLCAiMTc5MiIpLA0KICAgICgxOTIwLCAiMTkyMCIpLA0KICAgICgy MDQ4LCAiMjA0OCIpLA0KICAgICgtMSwgImh3IikNCiAgICBdLCBpbml0X3ZhbCA9ICJMSUJYTF9T VkVfVFlQRV9ESVNBQkxFROKAnSkNCg0KU28gdGhhdCBpbiB4bCBJIGNhbiBqdXN0IHVzZSBsaWJ4 bF9zdmVfdHlwZV9mcm9tX3N0cmluZw0KDQo+IA0KPj4+IA0KPj4+PiArc3VwcG9ydGVkIGJpdHMg dmFsdWUsIHRoZW4gdGhlIGRvbWFpbiBjcmVhdGlvbiB3aWxsIGZhaWwuDQo+Pj4+ICtBIHZhbHVl IGVxdWFsIHRvIHplcm8gaXMgdGhlIGRlZmF1bHQgYW5kIGl0IG1lYW5zIHRoaXMgZ3Vlc3QgaXMg bm90IGFsbG93ZWQgdG8NCj4+Pj4gK3VzZSBTVkUuDQo+Pj4+ICsNCj4+Pj4gKz1iYWNrDQo+Pj4+ ICsNCj4+Pj4gPWhlYWQzIHg4Ng0KPj4+PiANCj4+Pj4gPW92ZXIgNA0KPj4+PiBkaWZmIC0tZ2l0 IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf YXJtLmMNCj4+Pj4gaW5kZXggZGRjN2IyYTE1OTc1Li4xNmE0OTAzMWZkNTEgMTAwNjQ0DQo+Pj4+ IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4+Pj4gKysrIGIvdG9vbHMvbGli cy9saWdodC9saWJ4bF9hcm0uYw0KPj4+PiBAQCAtMjExLDYgKzIxMSw4IEBAIGludCBsaWJ4bF9f YXJjaF9kb21haW5fcHJlcGFyZV9jb25maWcobGlieGxfX2djICpnYywNCj4+Pj4gICAgICAgIHJl dHVybiBFUlJPUl9GQUlMOw0KPj4+PiAgICB9DQo+Pj4+IA0KPj4+PiArICAgIGNvbmZpZy0+YXJj aC5zdmVfdmwgPSBkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfYXJtLnN2ZTsNCj4+PiANCj4+PiBUaGlz IHRydW5jYXRlIGEgMTZiaXQgdmFsdWUgaW50byBhbiA4Yml0IHZhbHVlLCBJIHRoaW5rIHlvdSBz aG91bGQgY2hlY2sNCj4+PiB0aGF0IHRoZSB2YWx1ZSBjYW4gYWN0dWFsbHkgZml0Lg0KPj4+IA0K Pj4+IEFuZCBtYXliZSBjaGVjayBgZF9jb25maWctPmJfaW5mby5hcmNoX2FybS5zdmVgIHZhbHVl IGhlcmUgaW5zdGVhZCBvZg0KPj4+IGB4bGAgYXMgY29tbWVudGVkIGxhdGVyLg0KPj4gDQo+PiBZ ZXMgSSBjYW4gZG8gaXQsIG9uZSBxdWVzdGlvbiwgY2FuIEkgdXNlIGhlcmUgeGNfcGh5c2luZm8g dG8gcmV0cmlldmUgdGhlIG1heGltdW0NCj4+IFZlY3RvciBsZW5ndGggZnJvbSBhcmNoX2NhcGFi aWxpdGllcz8NCj4+IEkgbWVhbiwgaXMgdGhlcmUgYSBiZXR0ZXIgd2F5IG9yIEkgY2FuIGdvIGZv ciB0aGF0Pw0KPiANCj4gWWVhaCwgdGhlcmUgbWlnaHQgYmUgYSAiYmV0dGVyIiB3YXkuIEkgdGhp bmsgbWUgc3VnZ2VzdGlvbiB0byBjaGVjayB0aGUNCj4gc3ZlIHZhbHVlIGhlcmUgd2FzIHdyb25n LiBJIHN0aWxsIHdhbnQgdG8gaGF2ZSBpdCBjaGVja2VkIGluIGxpYnhsLCBidXQNCj4gaXQgbWln aHQgYmUgYmV0dGVyIHRvIGRvIHRoYXQgaW4gdGhlIHByZXZpb3VzIHN0ZXAsIHRoYXQgaXMNCj4g ImxpYnhsX19kb21haW5fY29uZmlnX3NldGRlZmF1bHQiLiBsaWJ4bF9fYXJjaF9kb21haW5fYnVp bGRfaW5mb19zZXRkZWZhdWx0KCkNCj4gd2lsbCBoYXZlIGBwaHlzaW5mb2Agc28geW91IHdvbid0 IGhhdmUgdG8gY2FsbCB4Y19waHlzaW5mbygpLg0KDQpSaWdodCwgSeKAmXZlIHNlZW4gaXQgYmVm b3JlIGJ1dCBJIHdhcyB1bnN1cmUgaWYgaXQgd2FzIHRoZSByaWdodCB3YXksIG5vdyB0aGF0IHlv dQ0Kc3VnZ2VzdGVkIGl0LCBJIHdpbGwgZ28gZm9yIHRoYXQuDQoNClRoYW5rIHlvdS4NCg0KQ2hl ZXJzLA0KTHVjYQ0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu Apr 06 06:05:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 06:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518733.805547 (Exim 4.92) (envelope-from ) id 1pkIkA-0008K3-Ei; Thu, 06 Apr 2023 06:05:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518733.805547; Thu, 06 Apr 2023 06:05:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkIkA-0008Jw-By; Thu, 06 Apr 2023 06:05:10 +0000 Received: by outflank-mailman (input) for mailman id 518733; Thu, 06 Apr 2023 06:05:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkIk8-0008Jq-I0 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 06:05:08 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9fa8b11-d440-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 08:05:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 33EB622851; Thu, 6 Apr 2023 06:05:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 09AD2133E5; Thu, 6 Apr 2023 06:05:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zi6EABFhLmRaHQAAMHmgww (envelope-from ); Thu, 06 Apr 2023 06:05:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9fa8b11-d440-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680761105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iAiGf3cX2GW0bfrFRKXl6BpZg86FVq+iM6Qx7WST+Fk=; b=ubKyyYdlYlaWScuO/QO3mcCFfA3fxykuYorEIU2rTFXl0wvCCTupVmHNPYrQRxaySPw5WL T7VZrWpkUeba4ish02JdcbCp0zGkZxMxymxrUZCZU9BXKL5F4LZqS9l4jU2Xtd95iwv9t0 9dsXSSeu/LBqshHQ6CY8XJhqQYhIy2k= Message-ID: Date: Thu, 6 Apr 2023 08:05:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 2/4] tools/xendevicemodel: Introduce ..._get_ioreq_server_info_ext Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <1f6dc87eebe5d1c27ae15ec8f5d8006e5aa1c36d.1680752649.git-series.marmarek@invisiblethingslab.com> From: Juergen Gross In-Reply-To: <1f6dc87eebe5d1c27ae15ec8f5d8006e5aa1c36d.1680752649.git-series.marmarek@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4yk10507j6h1jUkHG8ZqU8Vz" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4yk10507j6h1jUkHG8ZqU8Vz Content-Type: multipart/mixed; boundary="------------mdcjMNvxzTpVfimRWy4KDUVZ"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v3 2/4] tools/xendevicemodel: Introduce ..._get_ioreq_server_info_ext References: <1f6dc87eebe5d1c27ae15ec8f5d8006e5aa1c36d.1680752649.git-series.marmarek@invisiblethingslab.com> In-Reply-To: <1f6dc87eebe5d1c27ae15ec8f5d8006e5aa1c36d.1680752649.git-series.marmarek@invisiblethingslab.com> --------------mdcjMNvxzTpVfimRWy4KDUVZ Content-Type: multipart/mixed; boundary="------------IYP6TtmdnVCWEa5NYAwiEmVR" --------------IYP6TtmdnVCWEa5NYAwiEmVR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDQuMjMgMDU6NTcsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN Cj4gQWRkIHhlbmRldmljZW1vZGVsX2dldF9pb3JlcV9zZXJ2ZXJfaW5mb19leHQoKSB3aGlj aCBhZGRpdGlvbmFsbHkNCj4gcmV0dXJucyBvdXRwdXQgZmxhZ3MgdGhhdCBYRU5fRE1PUF9n ZXRfaW9yZXFfc2VydmVyX2luZm8gY2FuIG5vdyByZXR1cm4uDQo+IERvIG5vdCBjaGFuZ2Ug c2lnbmF0dXJlIG9mIGV4aXN0aW5nDQo+IHhlbmRldmljZW1vZGVsX2dldF9pb3JlcV9zZXJ2 ZXJfaW5mbygpIHNvIGV4aXN0aW5nIHVzZXJzIHdpbGwgbm90IG5lZWQNCj4gdG8gYmUgY2hh bmdlZC4NCj4gDQo+IFRoaXMgYWR2ZXJ0aXNlcyBiZWhhdmlvciBjaGFuZ2Ugb2YgIng4Ni9t c2k6IHBhc3N0aHJvdWdoIGFsbCBNU0ktWA0KPiB2ZWN0b3IgY3RybCB3cml0ZXMgdG8gZGV2 aWNlIG1vZGVsIiBwYXRjaC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtv d3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCj4gLS0t DQo+IHYzOg0KPiAgIC0gbmV3IHBhdGNoDQo+IA0KPiBTaG91bGQgdGhlcmUgYmUgc29tZSBI QVZFXyogI2RlZmluZSBpbiB0aGUgaGVhZGVyPyBEb2VzIHRoaXMgY2hhbmdlDQo+IHJlcXVp cmUgc29uYW1lIGJ1bXAgKEkgaG9wZSBpdCBkb2Vzbid0Li4uKS4NCg0KWW91IG5lZWQgdG8g YWRkIHZlcnNpb24gMS41IHRvIGxpYnhlbmRldmljZW1vZGVsLm1hcCB3aGljaCBzaG91bGQg ZGVmaW5lDQp0aGUgbmV3IGZ1bmN0aW9uLg0KDQoNCkp1ZXJnZW4NCg== --------------IYP6TtmdnVCWEa5NYAwiEmVR Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------IYP6TtmdnVCWEa5NYAwiEmVR-- --------------mdcjMNvxzTpVfimRWy4KDUVZ-- --------------4yk10507j6h1jUkHG8ZqU8Vz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmQuYRAFAwAAAAAACgkQsN6d1ii/Ey/9 UQf9GAYbrRxg5BEQZ9Hh0Zpihh5MjH79/FibaBJRfZwiNRcbQjWaiX5IGxpMpb3eIyIoLdodIAQ2 BnR6QL/H4RF/ibDEMIsccC6TqUCxA4RjAmMTW7NyJr/xw+Pk2VE4YpaZfhEh/skSbKDWITnpVRXj jEX1ri3EbBg7tHlcQ4nAEc3Q4M60o/QoxT5ANJ8vD/zf1Tkz3gF9F2F26Mvg8DGFN3fGGRZ49jU6 2n1mfcf0l5F3waOrs0rfixO0clsw/sNlPekZWUSXFuAggnvyeJDqatu1VZG+GK0CPaZeTnUDntTn xyJVOjlfrhFwaGPqGKvcFedXMeiu7HAC4slfQ2U84g== =4SkI -----END PGP SIGNATURE----- --------------4yk10507j6h1jUkHG8ZqU8Vz-- From xen-devel-bounces@lists.xenproject.org Thu Apr 06 06:35:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 06:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518737.805558 (Exim 4.92) (envelope-from ) id 1pkJDW-0003ML-OT; Thu, 06 Apr 2023 06:35:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518737.805558; Thu, 06 Apr 2023 06:35:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJDW-0003ME-K8; Thu, 06 Apr 2023 06:35:30 +0000 Received: by outflank-mailman (input) for mailman id 518737; Thu, 06 Apr 2023 06:35:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJDV-0003M8-79 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 06:35:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061d.outbound.protection.outlook.com [2a01:111:f400:7e1b::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3761be9c-d445-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 08:35:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6855.eurprd04.prod.outlook.com (2603:10a6:20b:dc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Thu, 6 Apr 2023 06:35:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 06:35:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3761be9c-d445-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uja96Q1S7FCrP9pZP8tp2MAeK0JSKB4cr3AcDwQjA9szlGS6RiBsldddF/83fewOCUfJkwCwIdIB5w9kN40+h4cw8pybsEcu9T77Q/w0d4svMbeZF83c+fjhVkJk+kzGkO393UuCgwRU8TYZc/emiyKanurEx74va/VQOqLhIyY0Nit1SVq3yXQ9jD1FJKJ3R3Yq9oWjJskv+FdayRwbb1QBPpk1KNTIfwLRxEG1vdpGF2ncNjjr3nQDVGRfet1cHn4IBpSOMP4yG/nacIx13tAU6cbHp9gDpZpLzLAQM2zcmQ+OUCCN8xTXcEujmQhIytX/4j2U+oxwOrDV9Jlvjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ynyCJJbqCagedK2F0kJGUmSwDJt20O0KiqLz/Y/RlX0=; b=VTbDgGbU4qoYj8Lf8wspTjMIEKwd+u3zxT6O+q/3quSyKnyZhrRCYr1jeCo/owuDpQTd8o5w4Ay74eFUbR1nnX37JY70Gvk5s0FsRDs5uGqrsYvOJg1Dm3P2HTas3IbgH/MIbsduZaIwgKTAdrb2dQrsyVJLUSvJIBuFxAUnyrpOGXnEbvFAtVtxEn5uJAvMxmXh5ijAG2g4c+jvtqjiVs4mTz5iM+LI4UmsXD1LBzr6vEOLdSiq9scrtH//4Jc+3KdVyCko6ccL6tAZBqNovMwgpCY96QhTslBSgF9nBRB+ru6Ly8bs+SkAajsUmaVQSqCTCFD8knjh2LbsLZbLGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynyCJJbqCagedK2F0kJGUmSwDJt20O0KiqLz/Y/RlX0=; b=ISG2g9EDrIKOo9dx94jF6+IpaT1fD2C5aBguQxP19Wx/TTq5Gzjo57zmJrf7Ni7CFPnWmk415T1jge3qQcmAdU7DiuTd3eIZG3kvb6whDbWJM7eahM03CQPbLZC7VG44mRhWZQAUhAKw5N7nd1yod47Pt2PMpKt99dfCsQ4P942sng5Rl/pO2h/AKRQ231WMTpgZS2XJy1/SPH8MEXSZPKhSnMNlWFyetgRNmepdrH0x/a+rbhEsEbwi+hg2LFgxld8H47g+DSlxx1UArkSUjfC+keZaAR7M7OJj3MBFh964txJ6JMMB6W4nVEDq01I17YhaZr+SBPDjDDSR6m4+hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8fce2549-a580-6780-759d-f287fa710640@suse.com> Date: Thu, 6 Apr 2023 08:35:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Oleksii References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> <9c4ca4a1-1b68-5ee0-0434-e6c9ec7d1ef6@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0267.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6855:EE_ X-MS-Office365-Filtering-Correlation-Id: f7be412f-a9c3-42e1-ea90-08db36691ac1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pR2w+7FRdyc8BXF35h4fu+6riMXivi+oFv4lZtm1CTyYc87EkRwaCARqpgkOAX2/P8XcwchatHniQMvs/GQLjFKTexfjW1JWIjWBwWlHym7HsyM8zJymapZ+XS2P4xcQYVYGxzBtEvh5K688bMW7qFDY7aiBSFxC1dIXrKqOMs1N7UGyapHAc3MxWNQmzZsXrjVJKFqOc8qrY1cAAmowKKe+bZWG6L5Fh+acE278BG8DHy5hW1jT8Qow3Km34Gz5gZQl1IxBa2wHVdk6zdqzKHM5zk8KQdb4Vlflj256ojmxVi6Q6RuV1quwpD4IrxmYgq2IosarQ0ZFxpli425hY7obLVt8obyLMzne64X7YtXkbA0Xd4WBa2W21ErpbuX7cOHUnWM/dNO/wBMAVZRtemQVJbG3Tri0RvKKX6nTftRs1gqwlIF66Y8IZBrslAYjjytrl3DEmn6aH68nLPd4eyEQI2CuZpjFZe0wVXFK3qhM1R80/bjdQt4C/D+XNJY9nTqzhrSIDeUlex8Qhl6byDuWq/pL5yKV8Sh11FYMbLlruL740Zj9k+IGSt7HBjVHUP7o2COD4XYEJfv2yyP3HTQHZA0ZinlXz4lfXrwKO1hzbRcax0a06pq8hDFoucTwZ9qs/NwaW2EjJpT58ddpZ3lUucYSIL2PXNyka47gVnc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(346002)(136003)(366004)(376002)(396003)(451199021)(5660300002)(31686004)(54906003)(316002)(8936002)(41300700001)(66946007)(186003)(2906002)(478600001)(4326008)(66556008)(8676002)(6916009)(66476007)(6486002)(26005)(53546011)(6506007)(6512007)(36756003)(2616005)(558084003)(31696002)(86362001)(38100700002)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmNRaHhZOWxzRndZWWRneWlhdVpWcXlzWTRsMWI2M0htTEVhZFVQNFhXbXFV?= =?utf-8?B?TWFqajF4djFZa1VmaVUzSmlWSjNaSnZGN0N5TVlzSVBzampKclh4OUwydDh5?= =?utf-8?B?dTZZVWhxRU9OM0lmVGFGTVJpUUdFeWdJZFdkU3c1YmwydmtWbDRzMU00NXNB?= =?utf-8?B?R20xd0xVdTI3b0x1MzZWUHFrNDQxUzBuci9yTTVQUElIS1cvWWZsTXNMVDlZ?= =?utf-8?B?b1lCRkx5eUVRUkxuemhuTzgxT2RIaDdTbnFJUUVBeW1JSkNrTUtWQmFpMGtl?= =?utf-8?B?YUU3aDJHNTkzYzZlUFlmVThsNFBJZWJuQWdEd3pXaEtqSjhYejY2ZVAySXRT?= =?utf-8?B?YWtaTlJhWnVBSkhYeHpuSGF0UnVNdndhQzdTSmpGUFg2OE5JeVBCWEh1NVhN?= =?utf-8?B?WHp2K1ZzQUtBMUswSW9ETWNzbm42ODF2MzduRFM5VTZrMDU3Q0hSSEEya1pD?= =?utf-8?B?V3lZU3YrOEJVMUFlTk5wUnk0UEFaRGx1WFNXQVRvZHRaK1hCdUQvRkhQTjRP?= =?utf-8?B?cWxlTVR2QkxwUjZ5RUJQOUt6RFZBTkpFeGh0QWQ5djBKNEdZNGZqK29zT2FE?= =?utf-8?B?a29Md01uRDIyTGEvQllHZXhzcEZzTk5GcTQ1aFgrNWcyZzBFMHhsdjNiYWJY?= =?utf-8?B?NXN0UWJIU0VTS1B5WXJETWdOeWwwTEtzZC85b0FJbm5jRklkU0t3Z1RzUTdN?= =?utf-8?B?Y0k0SXRzTXgzb3hocjdrUG1zclFraUhXMXZ5Nk94VTlqYVZiUTl0bG5tdFdy?= =?utf-8?B?UWhDbStNQU1aYXkyVTNESldZN2lIbVBTM2x2d2d3ZGV6NTFZcGtyS084aEFy?= =?utf-8?B?Qk00SnVzcmUzS1J6dno2ZGdzcnlLUjNBbTdOUjRGdTRnQ0lkWXRaY2xvUEdo?= =?utf-8?B?VFhXN1dTZVc4OWpLcWhMSmh2NStTWm9YMkd0M0NQZzJvV1MycmQ5b2R2QkVq?= =?utf-8?B?K2R1Z0JtRjBiM0hmMno1ZFFXajVmeWNOZU8vTVVzdEsycWRNOUZDdGNNTWVk?= =?utf-8?B?ZWd5d3hJdzdsS01meDJWUlhpbWJGNWh1QzRSQWhiZnRsMy83Tzl3R2ZyYzZO?= =?utf-8?B?MEJJUUd4djc4MnVaMUpMcGJ5Q1ZvVnFQaXhTSUJxOXlHeTh4ZU8vRExPcEp1?= =?utf-8?B?eGpvT2Q4MHJ3eFVzSmg0bXdCWTV4S2hZNi8xRlRRNlUxY1JlS1gzdlVGSlh1?= =?utf-8?B?QkpKMVk1eDFKWXlLUVNoSUtRdmtvN3luWDFjSUQzWXU0NVpIUGJCa3V2cGM5?= =?utf-8?B?YnJaNlNZN2hZaEd3VlJQMUJPWjY2NndQQnl6VTZGbVl1MUpoSmIxUjBjSGs0?= =?utf-8?B?aU1KaHdJS2UwQ3FOUXdHcmdRQldUTC9tejFDMVVqS3N6QmREZGNwWHpYVHlY?= =?utf-8?B?Y1JNV1o3MGo4V3hPL1ZxOHVmN1cyTGNUWXlqdnUvYjlVc0FUc05yVWNRMGg3?= =?utf-8?B?dWE2U0taZ3NvSXNBNFU5QkZja0FEWE1Ob1BqVG9GdDlVbEF4ZUt0Y0JRVDYv?= =?utf-8?B?WGNoc29PWi94NkNJNGRuaFpjM2NZellmUGJYZS9qdlBSaW1ZTFZNaTVlVi85?= =?utf-8?B?M0UveWNQOWFSZmoxd3JvTkh1YlExVE55SXgvZWZEdGxNV0FXOGJFaWNpdGZG?= =?utf-8?B?dXBhVkFCOWdTcGp2dDBCVW1wKzhKZzk1ZFltbk1LNFU2amVOMDVNeDdranZN?= =?utf-8?B?ai9yRVBZU1FIekJXanhhRmppMEpmc3QvRmdyK2kvaFFpYkJHanN4Wi9SZXNO?= =?utf-8?B?cjBUaGRldlJnUmZzTTZxUTBBRnM5bWRxd2t4cVVpUCt2b01kaG45bnlyblA3?= =?utf-8?B?TUVWcDh6UnVtejVkcUxva1g0RS82WEN0TXVKSHFTWmpxVEpVVkdacTd4S0hZ?= =?utf-8?B?OEt1b3k3UTFVU2dzMkVFdHMraFk4N2xuNVkzaGc1ZnFaQXBFbnVRekNoVk5T?= =?utf-8?B?WnM0OFJCWjl3MkYzNUwrTHM3bVU2SGNrMGIvakF2SXBiWFBYRytkUzlDMHNQ?= =?utf-8?B?UW9ERG05MkFXWnNKcXgwb1AzcjlUb3QvbkhSWG5QZ09FdEhYZnNSZmJuVEdo?= =?utf-8?B?MDVQU0ZKZWdHRnBmTlM3RC9McjJsTjd0b0lGNEYwT24xU2J3TnBrOE1sOE5w?= =?utf-8?Q?N/87Obk2KJ4rVoTWJuIH4GIpL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7be412f-a9c3-42e1-ea90-08db36691ac1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 06:35:25.2833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tXjWiTDSv0LxW9uuo0iHnpBMYR66fFoN6d2SOus9IuYdx6/Dxl/qxD1ssdwQ+cMpOtyp7D2JZD0L4j5Hd0RdgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6855 On 05.04.2023 18:39, Julien Grall wrote: > To reduce the amount of patch to resend, I was actually thinking to > merge patch #1-3 and #5 (so leave this patch alone) and modify the > default in a follow-up. Any thoughts? Well, yes, that's what I did a couple of days ago already. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 06:47:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 06:47:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518743.805567 (Exim 4.92) (envelope-from ) id 1pkJP6-0004te-PK; Thu, 06 Apr 2023 06:47:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518743.805567; Thu, 06 Apr 2023 06:47:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJP6-0004tX-Mf; Thu, 06 Apr 2023 06:47:28 +0000 Received: by outflank-mailman (input) for mailman id 518743; Thu, 06 Apr 2023 06:47:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJP5-0004tR-Sr for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 06:47:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7d00::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3742f38-d446-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 08:47:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9237.eurprd04.prod.outlook.com (2603:10a6:20b:4d1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 06:47:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 06:47:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3742f38-d446-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZfrnU7T+SRufwcOeKKS/RSTyVYU4tJzR9AZhkH/MnZjyo2Map/rNMcIOL/AJxZ0Ab9nuYRSiqAgPosU72iaFlC1TkGy5Uy0UgyXw90YYbAu1YvevdOM3gaR3ghLt5T4vyZNEXXBpSt8xVS2tjZvobWrNJ3ERtHlc4rxphhHn5xBy2qIx9wfqrXEY2aFrIW6RSNrBWeRGAZdvOF4ps6w80U82kAG1ciEl6ZuGayfMyZZIpwFMltB1owD4M3MLrQ+GKj+kvOOtloozMz4WKYPNu6vxrUa5XDu2nTupznJ8gFamASS9k0qOFOBJJUHmXS1NmxBmoXzj98ICBw4tj0WwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8VAXMuarZPILiWCKWQf+oZsYjafLrQh8Xc8wugtXYnk=; b=cgnGf82Z1XpxH3jbq3qeYB40kak/Nr64lckgxFze8TVImlAuz1ieYk5746B7HRejw5dqyWMDmpKKXf4da2ACznmQfPWb958tUADlDhPscRJO5/Cg0v5KYXoAltoylCX6DAExcKgvdQYu2qGOt79nLeYfwoElMrEernTSkHG1Aos3b6cpV87YrHDLxpDiXVrMMr+H4XfCg6X2QNDin7NWLOOAgpKpiOx6n+sHzIoGX+oV0tUPCHzqxlbzDDWeBKHSLBSEiFK2KDrDHzm72dPnH6taZw5jmtrgyORlHZqAnq+g53psLpRw7kxmO7I2N32YbPYXx4w2pb9Cxe8jEPC9qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8VAXMuarZPILiWCKWQf+oZsYjafLrQh8Xc8wugtXYnk=; b=j8OMJ7vPDR078k62lTtRmkm4J/Z3TtzOj3SGCPSkijRHaTSdbKhr7GgLYIsk58UwoFNSXarKVLgc8mCSYErYG2dBickPTADo9ExhmVBCLAgjsLJPMJGUhQbT/d9GRis/5+LyHmHeSKDFCdZqKasn510v3o9Hg5sl63dQtw69v1+/i2ya5dgl67io7sCKTyS23uesZuWZqqDzwWrKz5D1GpKdcrvuHSRuRF9WdOMZOgdkyZnd6Eu/1zvbZt7gZL/OQJgbJ0/haNbTeUvxAZ0D/b3KIWyZBaWbgRX/do38+GY/h/I/NB8ic8MuhFUjtxZ/DOcDVnvt2H02bE4aR0Hn5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2336d321-1463-a1cd-97e6-10c0d7ef5e39@suse.com> Date: Thu, 6 Apr 2023 08:47:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/9] x86emul: support WRMSRNS Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <0c2ddae9-3222-9755-b6e1-35e51410093b@suse.com> <0c249d10-02c7-9d76-bc3d-2b3e2ece38a9@citrix.com> From: Jan Beulich In-Reply-To: <0c249d10-02c7-9d76-bc3d-2b3e2ece38a9@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9237:EE_ X-MS-Office365-Filtering-Correlation-Id: c8348c93-3ddf-48da-090d-08db366ac660 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0syHUBVdoV5zB1/0SJoHupe6b4juRS2m2Oh3+TkYSaTeP/ww5mXUSmJgEnEUMUnPZRS5K3LTVKmBCZBcWOea71bhWqWF2RQfvltaoVeELHLiMtW7kP5LTXEU0arjkJDLUx9vKal4Ih5dl/i5+zZITbSzZz+jh9I/vSLDqfSzCKJtzP7RLUkrSEQMvG0aOvUH+PtXQFnYbeKKp9shqG75geQb0d40AVoWzHhJanootR0IQKF61MJJ8OdaBsmudW+ms/9GxzjtfBY1Dh0oLl73iMHrAMcPXghRfO5Ck71VFQwBEHAB2x2tqZlirgtlvSKZ/CK+dtD3KjMSaqMCYg12C5RVVtanS6cgu8gx1/BGNt6uIdIpn3WPdNSGZg/74VZ4YkVy6oWwmEIag8cyYs9yZYyf7fry4dI6Y0g3CzmbBRuCfgZTilKdB2+K3l1oAYQz0L/QJK3ucgHbF++KaH7hYRasuRWKFMs/PBhwkRkq1NwY9v+yFjrPs6LZ110vWHrAYJ7jDBjeKTvZ4LjuHgVwSxzNiCQdKFstBNbQJrDxgOt5WA7qgy6UyxxlUEcBeDn8y+eVZC1eMVz8ePO3Sp38q/25/9W6RIFghkbB9dTDwc+/MFSB4RyTLo9Y+KGV5XpJWMiI8TFeS5bVrkD01VF2Uw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199021)(2616005)(6486002)(478600001)(316002)(54906003)(26005)(6506007)(6512007)(186003)(53546011)(5660300002)(2906002)(36756003)(38100700002)(4326008)(6916009)(66946007)(66476007)(8676002)(41300700001)(86362001)(66556008)(31696002)(8936002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1laOU5XRERsVG0zUXZGNWlOeU91aW0yWWdaSE1zczJSeS9IMG1PWlpISUdR?= =?utf-8?B?OU5oM2NnRTA0Sm95WGllN3lQRFB0MG96QVRwRDFVR0VhMklZZjJ5VDZhWFda?= =?utf-8?B?RVllTGk2QWc5UkJvT0xIcVZ1SVpCTGpJRmlBMmJzc0N1VkdPWmRoVDh6NXdt?= =?utf-8?B?Y3puc2k1MGJTS0VnRWYzM1FHUDlHMnJEQjZwMFZVbUp1N0xzU29yZHRyWUVt?= =?utf-8?B?R0tFVzh6N2RUZ214U1M5YStMS0d1aTBpUENNaVFDWVg1cGdrR1lLTktTeitG?= =?utf-8?B?ckg5VnZ3aytwUmVTMVlmVnl3d1lsdmJINk1ydmFpODZtNUtHTHFTdkNOTWww?= =?utf-8?B?QlFGSjR6d3d5Wk5keXpWVEFTNFhKMlBUYTRYSUROMWxBbkRrOG41ZEd0V0x6?= =?utf-8?B?cGZvQUVjRE5iaVYyKzhLVzAxbzAvaTBqSVF6WXdmZy9ZVEVKWWxveFM3UVB6?= =?utf-8?B?ZzJsOG1IKzBTTmNQM3AvaVBTVTJrWjZmVWx3MVFxN1F0NXcxYklsZ2FwWVhV?= =?utf-8?B?UG9HQlZuUnF4cm8wd0QzdytGMWRmVzRTSzF4R2lqQTcvOHdIZkNtVGJJQWFB?= =?utf-8?B?bXAydjI3LzdpVVh2RTlLcmhsSjhSZmUyMWZMUEgrZTAwQ29LUEpjWHhxTVFt?= =?utf-8?B?NE9QV3JYNWI4ZGFkNUJ0VVVRSVNBQXpuRnZmbTRZWXNHbE44aDV3b2JYMSs2?= =?utf-8?B?TlpSdW01aC9STk5admR3RytacGYyU3VSWVpsNkRYeVdSNGJIeVM1RnpUdDNQ?= =?utf-8?B?UW1TOVV3QUlhMEFWM3VxU1d2T1QzZERPNzlYd1BBZ3REc0VsMnlTTDg5M1FN?= =?utf-8?B?MlZKM3VNbTU2SDlxSzhneGd4ZnVHa3BuSkN0cWc3UE9iZWdDZGVlQzlEZUxm?= =?utf-8?B?QXEwZHUvR05rQW53QnB6ODZVc2laMDN4SG9OTjR1TXZIZWU2c25XR29tMlh6?= =?utf-8?B?ZE8wYTVUNDNpS1hwZFV2UjVuelhOTGczOXE5VmFUamVka0JGMkthNEU2bi9D?= =?utf-8?B?YytzTTMzRzNMTUFqMGpkZ2lyWHhWbXoxNWF2NmhLQS92K3F4eEVJT3VvZEd1?= =?utf-8?B?WkE3emVCaFhjYnc1KzN4UTI1d0hJbHVMZ1phLzRDdG1QYTN5b1J6RlJQM1dW?= =?utf-8?B?bGY0TXA2WXNFZ09wR3BxNzZ1SGw3bHBQVXpESWVtTUZOUTJxT1pydkZtenhq?= =?utf-8?B?bDVnWHJDaklNaytlZE9Nc2RhZDU1b0llejdwc2p3T21HWjVKS1ArYXA2OG04?= =?utf-8?B?RFB1b2ZjNGw1V2RFMXNaRFpIVDFlMlYyWnNNYkx6Sm4rcXBsNUJOcGZyU3N1?= =?utf-8?B?NGpUWjhDVnRmQmtjYU1yNjFqaGloZEF4VE5JMnVtMjRTeXBQbWp6MnlMNXBi?= =?utf-8?B?eDV5WjBoYVVHNFVQSWxOQlNpcldwMk9uYXFYNGNlUGF4YktlYWpYbmZ0MFZL?= =?utf-8?B?c253RnFNZTVKRnNzVzdiaXlxeU5BWUpUV0FsWmhXV2Jac003c2hLVjY3N1NZ?= =?utf-8?B?VGQveG1XZUtyM0sxYWJBbDZ5S1gxbFkvS2FYaU9jci9GTExDb3pObkZHWnRT?= =?utf-8?B?a2YydHRwaFpDa2dhY0ZJVUdsM3ZFeDZJR2JKQitVWEZiVFV0bDQzaThFN1FL?= =?utf-8?B?bUhUUjhyMDBPQkhDdlgzZHJDNXZQSTFhamdrMTdwTHJSMzNoY0J3eWNPL1RY?= =?utf-8?B?MEh5VU40aHJzKzlSelZzV3hvY1J5L3VtUE5zVmtySzZja3JvQ005Z1R2UUg0?= =?utf-8?B?cE5yMkJDa0xTb0pZM281d0xhMVdqWXZZYnFKZWV0ZmJkTWpDRWVPM2pXNXdq?= =?utf-8?B?dXB0YjRYWVlZai9JckQ3VjVINGhDWmdCSXJITnlENmw0SVJTRDREQlRUS0dU?= =?utf-8?B?bXdGTWVxbHBFWGlRYUlYYWxJVXpYWEQ4MHg5VTVGcmRRUVU0dFdUMElrM2ta?= =?utf-8?B?ZUQwUzFFMXpBY242bWNTMVlOUmc2V05NV2ErdzZDNTNMTUZQL3lLVEtua282?= =?utf-8?B?ajRjcFNOdTh1STBoNTdyTTlrUU53VE56SWdTN2YwOEpGT0ROa2UyWnNaZ0l6?= =?utf-8?B?Q2JFT3lZcjlwaEtqUUlIdnF5TkFiaGY4K1NSWnJUWXJsSnhVMFBPZjVTRnVI?= =?utf-8?Q?Rc49MEsePL/TEtmFmHdIyc8Mr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8348c93-3ddf-48da-090d-08db366ac660 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 06:47:22.6966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FofPGH5EDjFCYUXltfHdBcXI2prkXYR7+iojQePo7Blgolnud4oVDSdJuALh3fbKu/z4zUGDGTgLpSwdwWZN+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9237 On 05.04.2023 23:29, Andrew Cooper wrote: > On 04/04/2023 3:50 pm, Jan Beulich wrote: >> This insn differs from WRMSR solely in the lack of serialization. Hence >> the code used there can simply be used here as well, plus a feature >> check of course. > > I have a feeling this is a bit stale now that 0f01.c has moved into a > separate file ? Hmm, no, not really. This code was written long after the split anyway. "Used here as well" is meant as "copy that code", not "goto ...". >> As there's no other infrastructure needed beyond >> permitting the insn for PV privileged-op emulation (in particular no >> separate new VMEXIT) we can expose the insn to guests right away. > > There are good reasons not to expose this to PV guests. > > The #GP fault to trigger emulation is serialising, so from the guest's > point of view there is literally no difference between WRMSR and WRMSRNS. > > All code is going to need to default to WRMSR for compatibility reasons, > so not advertising WRMSRNS will save the guest going through and > self-modifying itself to use a "more efficient" instruction which is not > actually more efficient. Well, sure, I can drop that again. I don't view "self-modifying itself" as meaningful wastage. Plus I'd consider it reasonable to expose the feature by default only to HVM, while permitting (non-default) exposure to PV (in which case the emul-priv-op.c change would want retaining), except that we can't express this afaict. Even without exposing at all I'd consider it kind of reasonable to allow use of the insn, in case a guest infers its availability (or simply knows from executing raw CPUID). > The emulation implementation is fine, so Reviewed-by: Andrew Cooper > but dependent on the PV guest changes being > dropped. Thanks. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 06:53:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 06:53:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518749.805578 (Exim 4.92) (envelope-from ) id 1pkJUD-0006OR-Fi; Thu, 06 Apr 2023 06:52:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518749.805578; Thu, 06 Apr 2023 06:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJUD-0006OK-D4; Thu, 06 Apr 2023 06:52:45 +0000 Received: by outflank-mailman (input) for mailman id 518749; Thu, 06 Apr 2023 06:52:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJUC-0006OE-2Y for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 06:52:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0606.outbound.protection.outlook.com [2a01:111:f400:fe0d::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0e65c27-d447-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 08:52:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9449.eurprd04.prod.outlook.com (2603:10a6:10:36a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 06:52:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 06:52:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0e65c27-d447-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQRus2hIwPyTwzZUg4hBt3SpxMA4KjJ/hphX9qfOsStxXMzYrywRJcWNCVIjSUSFGPAkD/Kep6eDAjcZR3vB8RsPX96jfRo13YnXXvEJnM//XD8t8f90naUIxcKPdPYxF4lL0afRQZqPN120+la6tJU2b/uf8PNMFs2hH43pwpp+/HGetk4lbmSXrn5Fa83WrYv0uSA5asW47LZrUsUSsJqXBW7bDLBAcNpgqNlHnhZpYLka4AzEbnxb2RulErtFtz17h/kp0i67raqHdaPriWUTpWTskJwJE1iLvs0wIIwDxItnF9tNZsdTKRN4CDiH1Z9IZfElDu+vaaxcYONgeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mp8t5y9kQGZBW8iIjdSHnxCFO8OaixoI+/AozAavHPo=; b=E7AqMNIop6TvoYF9NZlXhQSrGw3xLZKkZuuTpEA8UJodrKMG+d0IZrDYzG7r56rzMLwGNp83Z2Img13yEvOKEDCfWiHIv4ayjTFCN1mq8+iko7U02LAB4drz3jVvHyM0DRhEAaI7zt9EjGU5/adi1l7r8pJ8dBXgoVhz5mDmgTLswoYwVM7F/pixeFpq8Sc7cAZ/PFa/MljelFV3fZppbDz8b1nT9u3kCZZAQLzH5IllBhoZzR+/lCh0nJn67j/lI4RT1QMOJnGFjxvHuv1CDQEa8tp2DjH01sE6jpia4wog55cdg+9y9z2nFuqba9qnjxcoltUB8GG/RByuUJylew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mp8t5y9kQGZBW8iIjdSHnxCFO8OaixoI+/AozAavHPo=; b=YFRhgK5+WWZPpSTR/uJQFx0UFzSCgyTDrNxtgMPCYrz3gPtIbs3vXI/obaZhpaVrIYPLI2uFyewdgjHLPRPwBqtZZkH41VZI0wDytirAQ4Tydztlaa4lJn1hYngkC5hFKP++0SekrvZ9J4bazjkPTYVY5xmaH+RSPlBBpyQi+eIKoxBYf1nzB1/EZ54Kh4tfQQMjpfyE1fw7wMb0ewg19IuLSKKZ7Z04rbefOSufetPPtVgDTulg3659HfdmH3z0AtQT1UKpFKtBfItwVUJZIga6qjn7Hjzwpj1/+LADuCtrIFg/CQS7H6ZEPwnTkic87vzeauip6nfm0lQK6ZgIWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 6 Apr 2023 08:52:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 2/3] x86/platform: introduce XENPF_get_ucode_revision Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Sergey Dyasli References: <20230404160655.2354-1-sergey.dyasli@citrix.com> <20230404160655.2354-3-sergey.dyasli@citrix.com> <724da9d4-2c8f-dc45-78de-5a50e87adba1@citrix.com> From: Jan Beulich In-Reply-To: <724da9d4-2c8f-dc45-78de-5a50e87adba1@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9449:EE_ X-MS-Office365-Filtering-Correlation-Id: d240eac0-f57c-4b59-6be0-08db366b81ee X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KKcth/ur1s3WuiUanGPzFocdWfxoN/+2Zy+ro2zGSCl0PphPqsGiVZAKVzYxXuSQop6VDIT1Tg51DUWD6u5x9F176D6skktfmdlEiTIR+IwhsBEGmHMKH7t9dzf9gf5L5LMbiV4GhfeHdu8OFEKsCnnisx+HK6nVrHBKvmUnTh8IBxCVw3FKD285okEptZZHhHugQ8u0OJf06fwuYTA4u7dRfpxhbFhWL8PPL7wmE/SDpXPm3j4NxW3CutaB6f4X01wQsQcO16UOZ/Vw8CsD3H2hFpSVPT9aUg7yiCEuJA0BMQ4RWfvnukAI9KMGOa5KIULlDChqiegcNyoudL+7knzkDDpHH/VEMLSWTUBjQfXyPO8VDQrVWbpyUFLPtk+9qfnvEomG4zactuCLUtejmQNiuyY+0sJGGLcwwJBK01Ebct0/yboFirZngc1Nr9KEZ1bi5QcyGBvqlhIWvIzlGHZttusWjwmjgIA7SdBpQh74j+EsRQSVFlFDHPikB5R3m1SkV9+Xmv7j6OSwLAZCE0bjhu76+FWcfSC/xjYA7hF1+8r16b+z9ygDOnD2EDUqU53BFdeC3tB4xxI/S4Ons0lDraez1jcvLV1fIxd4E9ATtt4NH5k60GD3aj9/VEM8fHZBiXRXnhzBEP/cbf8www== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(39860400002)(376002)(366004)(451199021)(186003)(6512007)(2906002)(6506007)(26005)(53546011)(38100700002)(31696002)(86362001)(36756003)(2616005)(83380400001)(8936002)(41300700001)(5660300002)(316002)(6486002)(478600001)(54906003)(31686004)(66556008)(66476007)(8676002)(6916009)(4326008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1psTzFpdkZINlJyWWRzRTI2bHArRU1uSEk0OTMzTC9ydzFTdlJFa2tnNmtW?= =?utf-8?B?eCtZZ1FQMHRRYllYdjE4NlJGKzB6KzJtQlNlQ3kwN1N4Rm1LbkZjYjU1ZEpV?= =?utf-8?B?cWl5Vy9ZRjBCZUVRaXd6czdpKys0WFN5ckNSVWgzZHQ1Y3pvdnVUODJyZ21h?= =?utf-8?B?ZFFzNXRsOVRlZDRHaDBpZ0syem5XSmxCb0N4ckE0NFNBSHBwclRVRjJPM2Z0?= =?utf-8?B?TVpLaU51QXh0K1hjSHVGaUpmVlRmTVlFZkZjNlBEU3BLdjg1YW50Q2NrRU5E?= =?utf-8?B?RStXeTBvYnlyRHBaL2tVamRrWUJXR285S3ZzYmZTYmN5aG5IVzcyTndwL1RN?= =?utf-8?B?Q2NNUUpRNXk5bWNwRDJXMTJlaW9qMEN6MWFKS2U0R0xzOVgvM0h3MklMbnE5?= =?utf-8?B?ZEkrLzF6aGZHMGtsZGlFU3k5cVZ2UndZcnFraHIzK2RtQUJBWk5VU1oyUkM4?= =?utf-8?B?NlFOOU5VRVpuc2o2Y0t0VWZLRk1Xa2RoMUh4ejVwQ3JPekY3dGRBdGdteDNv?= =?utf-8?B?NzFQMW50a2NuRzNueUlOSEZQdkYvTitjWUZuOFFjK2J5YkR0aDdXbmNuZjJ1?= =?utf-8?B?VnZGMnRVL3g2SmQ5YUFTdUhNVTZ5Z1pYU0V5K25sa0FNcksrVHYzUW9HRVJu?= =?utf-8?B?Z1lLcVU4NHdkZEhJdjVSYk9MNFhuZWU3RjQveDMyQ2I1ZUF2SkRDT0daZWUv?= =?utf-8?B?Qm03Z2lIbXZMS1lPMWZNYktWYlRmOE1icWUzZVVUNjhtbzg3cTVLMEpzZlRN?= =?utf-8?B?WVhUbmRPa0tXamJpUnV2NmFDTDRWSDlhbHRkdEI3cG0raTBraG16eFJyVm1I?= =?utf-8?B?Z3BXbjV6b2xNUkhodFJldDlVemlGS1E5Rk4zcWFQVjFOblVES09oUVNtblpH?= =?utf-8?B?Yld5Zmp0SEtFNTVZR0lWZk5IK0Y3VEEvRlFjRTMrQ3RDaFVJb1d6MGhsU1ZQ?= =?utf-8?B?dzJHNTg1SEVnL1VLb2JiRG4yRjQwTmQ4MEt3ZGJaL05remxrbFd6TVBna2N0?= =?utf-8?B?azBCaHZWMjdGNE9OM09NbzRLSHVQRmhsckdSSG9TUWZTM1JWQkU3Z0YrVWlN?= =?utf-8?B?UG9LOWNPd1hMeHRwZzlpMFdscXZ1aTNGdnlYSnZmVTBlYmhIaFNJbDZMaHoy?= =?utf-8?B?c2ZreFcza3h4Y0phRW5QMDZhSGllZlZ2UTJLZmRrOXYzYmNzVldzVVI2bnZS?= =?utf-8?B?YUtHOVM1WW5IQTdCMGxFalpWWXc5SlVubkFoVll1YVFMcDBlcTJhRzVTMUMw?= =?utf-8?B?dUZsWGQvMjhldkd2ZkdKV1JOVDJxY3ExS3lqZGMveFRwek95T3JpbTNOV29j?= =?utf-8?B?NHN4azdWNS9kUm9yQXQrU3N6Q3daMVFhWXp4cjdRNS9pSjJ1eFJGMHRDZXQ5?= =?utf-8?B?Z3k0cFhXY3hHSVUwZ1BhRTVaeUxRMFhRTWxxc0VxMWNMTGVFVi9yZk5QMFJz?= =?utf-8?B?L05Ka0dFKzBmUHB6MklXTGJaM3UzRWZqOGFZNkkxU2NacWxlbEtreTBpemxI?= =?utf-8?B?QW83NEhLWEhjejJNODgvZ2Y4ZTF2cEdRVWJrckEydlNrdkY1RTd1SDZycGZ6?= =?utf-8?B?MUpzbENpQjBTVURqZUNoS2V1MWxnVjhXOFpoZkxoWDJBc0l2eDJDcW1BZ0ZZ?= =?utf-8?B?UDJ5a2lHVFF4czh5S0pMeWUwSzg4L0JHTmpPQktheCtSbWZZRENpdnUyb1pZ?= =?utf-8?B?WUZyZmMyZ0N6SVFSUkNRSVBXVHFkNDhVQVdzY3hoUkh3SlhLQ0FBWWpNOGpo?= =?utf-8?B?QVRhUzRkQkpRMFdsZ1RCU3RyUlFmQlBCMmxjclB5aVJXWFBrN3MwOFhocU8w?= =?utf-8?B?alNnMnUyOXhVZmZCY0FQU0JXcFZ3aU9uNFE2YW91UnpkbVBjNmNWUEdtTVJ1?= =?utf-8?B?WEZCZS9mY0pJOVFFeXBmRjc1VThhQnBldHlpcHA4Q1cySXNjOVh3S0dKbmFo?= =?utf-8?B?MnlyYURNbk40c21ZT3pDOEtVa1YyUGpMWWRZcmhwNlM3K256UE1NZSthbjRm?= =?utf-8?B?bVlpb0xOTzMxNEk2L1JUUEQ2cGFtMUdNSURkMVE3MUc2eWJ3Rk5tWTRQRVRY?= =?utf-8?B?ek4zc0JRWDdCODF2WmxIemFlRlM4UjRtSVAxZ1pVSEhxbzVtL0hhaDdqMTBi?= =?utf-8?Q?gRpY7LE6QWnLJ1Olioj/PEX1P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d240eac0-f57c-4b59-6be0-08db366b81ee X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 06:52:37.4617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ak74kSNQaFeh8LndSKiIzvmlblVsIKnDRxxitt02wQ1NB5HBEgrZz9JuOjxK6CXA1QWy4uHdCuDvqQ5JBVFZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9449 On 06.04.2023 01:02, Andrew Cooper wrote: > On 05/04/2023 9:56 am, Jan Beulich wrote: >> On 04.04.2023 18:06, Sergey Dyasli wrote: >>> --- a/tools/libs/ctrl/xc_misc.c >>> +++ b/tools/libs/ctrl/xc_misc.c >>> @@ -243,6 +243,24 @@ int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver) >>> return 0; >>> } >>> >>> +int xc_get_ucode_revision(xc_interface *xch, >>> + struct xenpf_ucode_revision *ucode_rev) >>> +{ >>> + int ret; >>> + struct xen_platform_op op = { >>> + .cmd = XENPF_get_ucode_revision, >>> + .u.ucode_revision.cpu = ucode_rev->cpu, >>> + }; >>> + >>> + ret = do_platform_op(xch, &op); >>> + if ( ret != 0 ) >>> + return ret; >> Is there anything wrong with omitting this if() and ... >> >>> + *ucode_rev = op.u.ucode_revision; >>> + >>> + return 0; >> ... using "return ret" here? > > Conceptually, yes.  *ucode_rev oughtn't to be written to on failure. > > More importantly though, what Sergey wrote is consistent with the vast > majority of libxc, and consistency is far more important than a marginal > perf improvement which you won't be able to measure. My remark was entirely unrelated to performance, and instead solely to (source) code size. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 07:10:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 07:10:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518755.805588 (Exim 4.92) (envelope-from ) id 1pkJlH-0000Rb-U1; Thu, 06 Apr 2023 07:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518755.805588; Thu, 06 Apr 2023 07:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJlH-0000RU-RL; Thu, 06 Apr 2023 07:10:23 +0000 Received: by outflank-mailman (input) for mailman id 518755; Thu, 06 Apr 2023 07:10:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkJlG-0000R5-LU for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 07:10:22 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20607.outbound.protection.outlook.com [2a01:111:f400:7eaf::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 164c8bb1-d44a-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 09:10:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8572.eurprd04.prod.outlook.com (2603:10a6:20b:437::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 07:10:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 07:10:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 164c8bb1-d44a-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a/XvgeW/pYnjs2GLuD5j6QFjqW0aJbkKcayDwJIQ+H/ZIaaHV0H0SR1z7ERRnN6Q+RY4hmYYx7tKN1niEWEx0ngPwH46RYuK2QghV9rx0sMw7ixPAiXdr2R17cK8RqBdZQS9Z04mrr4IPOC055HyrX+2TRecEZ02out1/8djV7Et9R9oyM9gKGhfeJXPrmnmiAfJwTYXvfiYiDR0Kw9ilfbhah3ZeHu0gsCJW9Te8NlRIAUMpN1ihrHG2sfhhSKBixVKolcTrx5/0gY304TXLR3GDhDlG1Xwk/OePBSmXz8eBwVE8kqGJlowTy1DRLUj7sppwV5NazsrIOTG2Kr8Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dPefrZvcEibxdwrsmC7k+QiZGikHI68fSkhMQAQyOcE=; b=TwBCDa77dGpGQmSnhOQl+gPsFQfR6aoe+NQpHFpX5sGVtmXniljs8jz1z1Un+SfiD2hkRjAo9KMGG6VUj5m5p3W9Z2vRGBHV0THFxqlOaHqLCnFpEcZ/QyR41qUtbMFjCyKT8Zt93DGDHJ9rlIzDGKXG7U/ow4bw0AMYL7DobGXWKltIDHP9aYXAv2zZJlKjwWSSMlk11iskYmMvtfu60W4RX/5TdMtIvgSFkakQ6jhJqC6Nvqw25VXGi4ADT5b2uqmowGu252ajj+PbLhBKAC2lTwYWw2ntNKt1Vi/vi2BVEzAUnYunsOU406TwfaqNKRpb34SOotN+/+n94yuPGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPefrZvcEibxdwrsmC7k+QiZGikHI68fSkhMQAQyOcE=; b=w9/NiFksH8H3o4g2jrvdeBBaIpKLKpLoNlR4PGRzCEiKnW2MKWiWQvDCJjEbiZCewF1VvRkJXkuwB9lRuvs4tKTzjNePy+FkVmQsdWzHEiOiGllJSAzEJd4q+rE1HvW8dmh8rLds4j1NWjtor2EftJMRN5ojOnz8qaAkIXZfXMLCNQyqMKN8fSB1TA2PCKsTPVUXo0tcOo+sllcfwrvXODlgFTjk1HhuwgT17PrTon0Y0VKb7d7yGBofEUXCGMCOGQ0FZZ+xTb5m4FikjRSITsE0bY2c/t5SQt0+7v3DbZ3th0OlcezWVpX8B5PP0feSPQOlLCaHdz/Y9/mn3aqQyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 6 Apr 2023 09:10:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest" Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xen-devel References: <20230405215245.2137356-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230405215245.2137356-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8572:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d278d87-dd96-40aa-4dbc-08db366df918 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FRZk6DApjp1EHc+5KhzWYNP0NkCMSyFu1zi7jM2fyeH0wXm8ZvSjMXkZGIz6MjDTcfZXrCTdDUS0Mx0dYoHL+c68gDNi7kvncJ9ARBrvBFcHggnhZ9QmsWGqMa+UAmx9Hud0X1jVsjrGIE7ZgbIujGo5J7JPniMZxokFq3WLsiaEv8A1/ucd0Av37bAVTdjdTAvm7AJap0GN4CJYHWxAybAfmSjfMNHHvQEYCq9PN4cFghkb3L1PM4hEDJhvtAL8Nay0lo8V8EIaH+oHvyaUeR+qfjDVWik3Dc7e4qP7sTsOHsWM6BrQLvEFivlAqcXAI7jfCHrEgOQxkssSFVsTz8jM/WkcRkRtXPhfHak2F0Gwm3LOiezdmuqcoAQLkkPoubMxY8KTgk53C/eAbHOZRkgzR7iQdc1uSUTxvqp+ILeYDe663mLKSE3+edUklHf5RGTWogvi/Lbfq5SaHrErCu4o7Y/0CsKlzh3xNUFLz2PgUDdAmU6Ztg3pY6ylfrgfID57yuEJ5WG+QPAsZO9NZlSCA432xc8UZlbYlMUtGThRLyH6IvX4pN7+t+krRmVCo0igbTOrVYO6V3hzv1fagMMcKtABdpFfdq9fJ+ZRgX8gnvsi4t+lZiqunbu/SJMe4x6QK+l9fdILXRyhDG6qLg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199021)(2616005)(83380400001)(6486002)(478600001)(316002)(54906003)(26005)(6506007)(6512007)(186003)(53546011)(5660300002)(2906002)(36756003)(38100700002)(4326008)(6916009)(66946007)(66476007)(8676002)(41300700001)(86362001)(66556008)(31696002)(8936002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWJ3MDkrSUI4ekpCakZYVzFCcnp6V1JTd0RqbU42UmRvT0VTdm01Slp1dFVD?= =?utf-8?B?cFJrNlZQRkwrMzZSWDNLNUJBNHA1MFV6SmJXYnQ5b2pHOXRTbXVyRVRJS3RO?= =?utf-8?B?QnB4dzBocTg0NzdyTVpSQUZmQi9iNU1XQ2ZSMjg1S01iRkpUN3NhRlJuTGU4?= =?utf-8?B?R0gwVjZIUXYyTXVpeXFtdkErdUNDK1FNYWE0NkFtUkkzanBLU1BlN21TZW9K?= =?utf-8?B?VldrOWEwM1lXcjBJVGRYWXJiaDZFQXB3QXZRZ2J3Wm5XMkozR3poQXpaZ1Zy?= =?utf-8?B?V1I5WW84UTFiSkk4cWxoc2ovUTZ4Nk40UkE4QzlyNk92ejA5VmFuc0lWeFNV?= =?utf-8?B?aTFTeWhnN2pGbWg5KzB4VUl6V2lNODZPb1RBUnE1bkpieHdBcEhrTDJXcVN6?= =?utf-8?B?UXpHOUdlVk00U3NFUVBXcU51a1Zra05zQVd5ZmUvWE1ZUWhRVmxxa0pJTEpo?= =?utf-8?B?d3JGUklQWWRoZnk4c0hYRVVSVXh1OHNuVnllNGlJYWN6dlFnbFBPWXVNNUxN?= =?utf-8?B?RFIvWTZpOXB2U3JKalFhMCs0WDZ2RlhNM1BKV3JGL3J4czcvNTVsdEdrY1NP?= =?utf-8?B?M3RQUzVmYkpLelZYTXY1LytKR1hQQVhFV3hRcWd6WC9vcUZCNkU2WUdtM2lR?= =?utf-8?B?OWh0V1RxSTRJdmtPUDJTNGxOVlVlVEpNNFBIUVhTNjVDWTROcjVYcVExMG9D?= =?utf-8?B?dVJySDhxRUxudStBeVpLL0JUczVFMkhNeDRDM2puSkdhUHF1TGxtamFEaC91?= =?utf-8?B?THNMOHBRcU53ckp0TDBVZnVBQ3dhdEV6YUM3d0xzMlVJb0J3Z21YUHZTRDF3?= =?utf-8?B?NDlsYTB2NzNpS0drek9EbGtBQ25TNDFGczlVV1JsZVlPQ3A5dHNmZEpMdVB6?= =?utf-8?B?UW9zVnlPRFZwanZGN3hHQUVvS0FpdWJ5YjJ3YnRJTWJpeVRVd2h3MnJzemI4?= =?utf-8?B?SzRPa2dsMmZPb3VyL0YwdlVQaU1hNGV3dlhxdGR0R3crQjMrU3B3Nm1nMTli?= =?utf-8?B?UXBubk9LaFV3bzRDb2h2M2xRRFZzRnFmaUNsWWJtTk16UFpMWDVSTzRVRVJo?= =?utf-8?B?aVBCVHNHdkVSSURkNzRrYU1RRWphUldlSnNveDBaL1F6dTJvcllyTlhJY1lw?= =?utf-8?B?SFJHTU53UXpraFc0NTBzZ2swRnFMbWJzZE84TDd0MTlVVHR1bDVidGJUeFFr?= =?utf-8?B?aVBuSEpuVld3MmVIQ0lHbFN3emNiZHJMaEFnNi9DYWxyWUdPYjJDMmF3aC9i?= =?utf-8?B?NW1Sc3dGcnpDS21kN0pHdU5EUTExZHoxOU5TOXFhczk0MGwwMmcydDhnOXIr?= =?utf-8?B?RkRRY213VXJYSTF6RVNoTjJjWHMvTXJzSktGclJ2NjFpWmZvbVVDUmhzTzhp?= =?utf-8?B?VmcvTlV2YThjS3Qzcm5NaGwxL3BxcUR2SndpWTl4YnpFcXprc2tEbjdSSHEw?= =?utf-8?B?Und4Y3k3WDF5b3F5Y1BiZk1ZaFB1VmRyZVB1LzQ3YVlyZGt5cXRMbTJlT1Jv?= =?utf-8?B?Z3d4NXE4UVRYOTBNZkNRazBsMkJwLzRRbndDU1k3MEduclFIZy8yZy9PZ3Vj?= =?utf-8?B?RTgray9XeGRiZzZBa3FyRzhGcnBrWk5xTXE5bkdDanA0VmVQNzRRYnE0MkFS?= =?utf-8?B?c0lSM1BOcTBoM0xvWWh5dFNQaXdkRlF0dm56QzBBbm1YcE94bytpMUdjOGVB?= =?utf-8?B?MUUySE43M240MHF4Z3FvZ2VQQlNVV3NRaXMwVERrYnIzYndMT2hNSDJYM3N6?= =?utf-8?B?VnBmNUQvbTZWZFVmbVVUVDZCdzBXK0lWcjM0Y3RXZzdYWkRmb21CU0Q3Y0xD?= =?utf-8?B?ODN6SVVHRFV6QkptdnNEYS9iYjM2TGpuWjdwN1BNTHJtU0crTEZNSW1oNCtr?= =?utf-8?B?cHExbE1yRkhEOXJ2ZHk5ckdQeHFqWGx1ZWV0UFNjMysrWldUclQzYWo2dnB2?= =?utf-8?B?b0ZNbDRnTmlPVjFrZTVOeXhCQkJMQkhXTDMzSzlFWGNLOVR6OVo5UVlpekFF?= =?utf-8?B?bnowSXo5WkZKV3Zvajk2UHBPaTdMc0VVY1doTWlmRFRoZ1VqM1dzN3hHZ1Zp?= =?utf-8?B?cDZvTTcvdThLejdJaTUwcDZ3aWV2MHBpRWZINjdsWmZQZDJTODdPNm5URXFN?= =?utf-8?Q?G3wMo35uP76TLs1ls2dyMho9+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d278d87-dd96-40aa-4dbc-08db366df918 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 07:10:16.3316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /QZyi7pfCO72y3Q68iZprTMpT08N8ZS+8ZnBJUlP1cHyTmTkD7bv1b2AYs7w6uTjIl3m3HUyS8mjqjH/1fXqkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8572 On 05.04.2023 23:52, Andrew Cooper wrote: > At the time of XSA-170, the x86 instruction emulator was genuinely broken. It > would load arbitrary values into %rip and putting a check here probably was > the best stopgap security fix. It should have been reverted following c/s > 81d3a0b26c1 "x86emul: limit-check branch targets" which corrected the emulator > behaviour. > > However, everyone involved in XSA-170, myself included, failed to read the SDM > correctly. On the subject of %rip consistency checks, the SDM stated: > > If the processor supports N < 64 linear-address bits, bits 63:N must be > identical > > A non-canonical %rip (and SSP more recently) is an explicitly legal state in > x86, and the VMEntry consistency checks are intentionally off-by-one from a > regular canonical check. > > The consequence of this bug is that Xen will currently take a legal x86 state > which would successfully VMEnter, and corrupt it into having non-architectural > behaviour. > > Furthermore, in the time this bugfix has been pending in public, I > successfully persuaded Intel to clarify the SDM, adding the following > clarification: > > The guest RIP value is not required to be canonical; the value of bit N-1 > may differ from that of bit N. > > Fixes: ffbbfda377 ("x86/VMX: sanitize rIP before re-entering guest") > Signed-off-by: Andrew Cooper I am kind of okay with such a full revert, but I'd consider it quite helpful if the description made clear why the alternative of instead doing the spec mandated check isn't necessary / useful. The emulator having gained respective checking is only part of the reason for this, aiui. Plus bugs may be introduced into the emulator again, where the checking here could be a guard against needing to issue an XSA in such a case. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 08:00:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 08:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518763.805598 (Exim 4.92) (envelope-from ) id 1pkKXa-00065d-Sx; Thu, 06 Apr 2023 08:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518763.805598; Thu, 06 Apr 2023 08:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkKXa-00065W-Ov; Thu, 06 Apr 2023 08:00:18 +0000 Received: by outflank-mailman (input) for mailman id 518763; Thu, 06 Apr 2023 08:00:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkKXa-00065G-B8; Thu, 06 Apr 2023 08:00:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkKXa-0003J3-5p; Thu, 06 Apr 2023 08:00:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkKXZ-00082A-ME; Thu, 06 Apr 2023 08:00:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkKXZ-0000Vr-Ln; Thu, 06 Apr 2023 08:00:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IIsLIH/neFqcWgqz19FvOG2UWrYlycCuOvqI7ySeylo=; b=c1yQ59Q4/bY3X05mp7VW6twTPL YxeRZyg1zvaocZrVY86rFlXCt9Qnag/pW3/aLDvjhdreR1/VtTw1aKl2fRkn4qu77iXNT0VVAFXn6 RCCdEgGxYjhaPz5gVI9Xha8qgEOj8h8S74hwqzA8UZKqAJFRCd4XC2X05iq4BYIX51dE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 180149: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-xl:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=32bea3bac5ca484c6f7e302c8c96fc686f62e7b4 X-Osstest-Versions-That: linux=09b1a76e7879184fb35d71a221cae9451b895fff From: osstest service owner Date: Thu, 06 Apr 2023 08:00:17 +0000 flight 180149 linux-5.4 real [real] flight 180165 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180149/ http://logs.test-lab.xenproject.org/osstest/logs/180165/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl 7 xen-install fail pass in 180165-retest test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 180165-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180066 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180066 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180066 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180066 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180066 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180066 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180066 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180066 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180066 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 32bea3bac5ca484c6f7e302c8c96fc686f62e7b4 baseline version: linux 09b1a76e7879184fb35d71a221cae9451b895fff Last test of basis 180066 2023-03-30 13:12:10 Z 6 days Testing same since 180149 2023-04-05 09:43:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrien Thierry Akihiko Odaki Al Viro Alexander Aring Alexander Lobakin Alexander Stein Alexandre Ghiti Alexei Starovoitov Alvin Šipraga Anand Jain Andreas Gruenbacher Andrew Morton Anna Schumaker Arpana Arland (A Contingent worker at Intel) Arseniy Krasnov Bharath SM Caleb Sander Chris Paterson (CIP) Christoph Hellwig Christophe JAILLET Claudiu Beznea # on SAMA7G5 Colin Ian King Coly Li Corinna Vinschen Cristian Marussi Daniel Borkmann Daniil Tatianin David Disseldorp David Howells David S. Miller David Sterba Dmitry Torokhov Dragos-Marian Panait Emanuele Ghidoli Enrico Sau Eric Biggers Eric Dumazet Fabio Estevam Faicker Mo Fedor Pchelkin Felix Fietkau Finn Thain Florian Fainelli Frank Crawford Gaosheng Cui Geert Uytterhoeven Geoff Levand George Kennedy Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Harshit Mogalapalli Heiko Carstens Helge Deller Horatiu Vultur Ivan Bornyakov Ivan Orlov Jakob Koschel Jakub Kicinski Jan Kara Jan Kara via Ocfs2-devel Jason A. Donenfeld Jiasheng Jiang Joel Selvaraj Johan Hovold Johannes Berg Jon Hunter Joseph Qi Juergen Gross Kalesh AP Kuninori Morimoto Li Zetao Liang He Lin Li Lin Ma Linus Torvalds Linus Walleij Linux Kernel Functional Testing Lorenz Bauer Lorenz Bauer Lorenzo Bianconi Lucas Stach Luiz Augusto von Dentz Maher Sanalla Marc Kleine-Budde Marek Szlosek Mario Limonciello Mark Brown Martin K. Petersen Martin KaFai Lau Maurizio Lombardi Meena Shanmugam Michael Chan Michael Schmitz Mika Westerberg Mike Snitzer Mikulas Patocka Miquel Raynal msizanoen Nathan Huckleberry NeilBrown Nilesh Javali Oliver Hartkopp Palmer Dabbelt Paolo Abeni Paulo Alcantara (SUSE) Paulo Alcantara Pawel Laszczak Peter Chen Peter Zijlstra (Intel) Radoslaw Tyl Rafal Romanowski Roger Pau Monne Roger Pau Monné Roman Kagan Ryusuke Konishi Saeed Mahameed Sasha Levin Sebastian Reichel Shawn Guo Shuah Khan Shyam Prasad N Song Liu SongJingyi Stan Johnson Stefan Schmidt Steffen Bätz Stephan Gerhold Steve French Sudeep Holla Szymon Heidrich Takashi Iwai Theodore Ts'o Thomas Bogendoerfer Tomas Henzl Tony Krowiak Tony Nguyen Trond Myklebust Tudor Ambarus Tzung-Bi Shih Vasily Gorbik Vincent Guittot Wei Chen Wolfram Sang Xu Yang Yaroslav Furman Ye Bin Yu Kuai Zhang Changzhong Zhang Qiao Zheng Wang Zubin Mithra Álvaro Fernández Rojas jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl fail test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 09b1a76e7879..32bea3bac5ca 32bea3bac5ca484c6f7e302c8c96fc686f62e7b4 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 08:44:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 08:44:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518770.805608 (Exim 4.92) (envelope-from ) id 1pkLEE-0002C8-7i; Thu, 06 Apr 2023 08:44:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518770.805608; Thu, 06 Apr 2023 08:44:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLEE-0002C1-3X; Thu, 06 Apr 2023 08:44:22 +0000 Received: by outflank-mailman (input) for mailman id 518770; Thu, 06 Apr 2023 08:44:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLED-0002Bv-A9 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 08:44:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLE9-0004hU-1e; Thu, 06 Apr 2023 08:44:17 +0000 Received: from [54.239.6.184] (helo=[192.168.21.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pkLE8-0004Fp-PP; Thu, 06 Apr 2023 08:44:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cfEE4BoPCplRbPqVm1JQdcTkjW5f9vjLSMyN/3E6LSo=; b=X2Ie0M4qskuaS7WagpeRGxeCsL sjWn8UDIVD0sBJQX23cB+Qkaopo5mVqh+wuLcGfyY3j0QVphtiD9oC/03OsSTL8CtA6muRKuYnn7Z lZFrFd9CotT0PcacAyrGh80BKBSGOB7OyXmQDrKXvucl6MxqWAMxoeJWcySCS5Lhubk8=; Message-ID: Date: Thu, 6 Apr 2023 09:44:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Oleksii References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> <605245331bb93b7e60a4a9d65b19b6642d897034.camel@gmail.com> <9c4ca4a1-1b68-5ee0-0434-e6c9ec7d1ef6@suse.com> <8fce2549-a580-6780-759d-f287fa710640@suse.com> From: Julien Grall In-Reply-To: <8fce2549-a580-6780-759d-f287fa710640@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/04/2023 07:35, Jan Beulich wrote: > On 05.04.2023 18:39, Julien Grall wrote: >> To reduce the amount of patch to resend, I was actually thinking to >> merge patch #1-3 and #5 (so leave this patch alone) and modify the >> default in a follow-up. Any thoughts? > > Well, yes, that's what I did a couple of days ago already. Ah. I didn't check the tree when replying. So ignore me. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 06 08:58:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 08:58:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518776.805629 (Exim 4.92) (envelope-from ) id 1pkLRw-000446-OO; Thu, 06 Apr 2023 08:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518776.805629; Thu, 06 Apr 2023 08:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLRw-00043z-JQ; Thu, 06 Apr 2023 08:58:32 +0000 Received: by outflank-mailman (input) for mailman id 518776; Thu, 06 Apr 2023 08:58:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLRv-0003pI-NJ for xen-devel@lists.xen.org; Thu, 06 Apr 2023 08:58:31 +0000 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [2607:f8b0:4864:20::102a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32127944-d459-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 10:58:30 +0200 (CEST) Received: by mail-pj1-x102a.google.com with SMTP id x15so36653780pjk.2 for ; Thu, 06 Apr 2023 01:58:28 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id x22-20020aa793b6000000b0062d85a1df56sm837151pff.178.2023.04.06.01.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 01:58:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32127944-d459-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680771507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wJIrzTwFQA01WlKUp5gnPqmqgvFFVnJLpG/b7bte7e8=; b=fYj9IhtspZTO1c45rT5cqb2UnaJWejpmy/I7Jb3yPwkHvmLkvAK3m4181eanFeguwO SeDbDT7dPWprn5RlScKWm3FaPgdvFky7QhW80ffdPOLiGzm6WXwdxWZ5U6S3Bb+e9l/C Yi9H5wbFVxuyI7f7PvJiQ53X9ftCPgmsswvAfuG7TrwuGfHnbsaQdLLhq64h8suekOuZ xFYPfQMLzF64xH5EDGcAkqzG9axCSQa/U81f3qPm1ffOGvWlAJDiOl7wbH+xqAPVDvmH Sk+CfT78gQcLg9hXyuQ6pdRjvJuz12Ukytnr2gkEZYB8s4Wxf3qOK9F5AyqYTgzgfoI0 DYjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680771507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wJIrzTwFQA01WlKUp5gnPqmqgvFFVnJLpG/b7bte7e8=; b=TzD7GvWb5wFXdWAICq7MDrGRuVOX163coNn3cs4vWx6+xDoSnJnqVDo2oYV3B+TdeM M6QIYJt0uLeDPqVfa1qRg+hoTNi+bEx/jCAYqaV1JXwdkPuaqlnJ/VNKW+0w4QPJZwx+ +CCdh+R0+BDOWwoiqnt7zzAtax0bdFPfnX9aAFmzebKT+AcvoVFBdL7miw/vKJvDgxvP eWxVaNyNHemVtcZXWqqCQw/aNcYcRv31yfFv37/u5yJsFganXFRCW2YhGztVqQiTu1gR rCvHTRHh4BRXRNCKxhiwhfM8WRfcOaDVYvO0FLv5YKWw+53LZAqYx9alOtLstEJrjK/K ZILw== X-Gm-Message-State: AAQBX9cO677LMLjxtf9H/ch+OtZ5HkZ1Z4Nm0UsGdP9BvLmg2BRfs0yi eCQWw2qGLVhiFlJTOEzMcwrYDAGFf7mR9vGKkQw= X-Google-Smtp-Source: AKy350aan+Rv6En7fZ329g/XSQU5SCipZqx70PrdyPW+xTyx5BJ0yf8Nh3iuU7/nwLuqljfErs6vsw== X-Received: by 2002:a05:6a20:ba9c:b0:d9:4d77:643e with SMTP id fb28-20020a056a20ba9c00b000d94d77643emr2166510pzb.4.1680771506861; Thu, 06 Apr 2023 01:58:26 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling , Oleksandr Tyshchenko Subject: [PATCH V3 2/2] libxl: fix matching of generic virtio device Date: Thu, 6 Apr 2023 14:28:18 +0530 Message-Id: <888e60d2ec49f53230bc82df393b6bed4180cb8a.1680771422.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: <18458fa39433ce4ac950a0a20cc64da93db0b03a.1680771422.git.viresh.kumar@linaro.org> References: <18458fa39433ce4ac950a0a20cc64da93db0b03a.1680771422.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The strings won't be an exact match, as we are only looking to match the prefix here, i.e. "virtio,device". This is already done properly in libxl_virtio.c file, lets do the same here too. Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") Signed-off-by: Viresh Kumar Reviewed-by: Oleksandr Tyshchenko --- V2->V3: - Tag from Oleksandr. tools/libs/light/libxl_arm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..97c80d7ed0fa 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1033,10 +1033,14 @@ static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, } else if (!strcmp(type, VIRTIO_DEVICE_TYPE_GPIO)) { res = make_virtio_mmio_node_gpio(gc, fdt); if (res) return res; - } else if (strcmp(type, VIRTIO_DEVICE_TYPE_GENERIC)) { - /* Doesn't match generic virtio device */ - LOG(ERROR, "Invalid type for virtio device: %s", type); - return -EINVAL; + } else { + int len = sizeof(VIRTIO_DEVICE_TYPE_GENERIC) - 1; + + if (strncmp(type, VIRTIO_DEVICE_TYPE_GENERIC, len)) { + /* Doesn't match generic virtio device */ + LOG(ERROR, "Invalid type for virtio device: %s", type); + return -EINVAL; + } } return fdt_end_node(fdt); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 08:58:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 08:58:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518775.805618 (Exim 4.92) (envelope-from ) id 1pkLRv-0003pG-E2; Thu, 06 Apr 2023 08:58:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518775.805618; Thu, 06 Apr 2023 08:58:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLRv-0003p9-BC; Thu, 06 Apr 2023 08:58:31 +0000 Received: by outflank-mailman (input) for mailman id 518775; Thu, 06 Apr 2023 08:58:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLRu-0003p3-7w for xen-devel@lists.xen.org; Thu, 06 Apr 2023 08:58:30 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 304a2780-d459-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 10:58:26 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id ix20so36940117plb.3 for ; Thu, 06 Apr 2023 01:58:25 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id f8-20020a170902860800b001a1adbe215asm904655plo.142.2023.04.06.01.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 01:58:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 304a2780-d459-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680771504; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DEQiq5V6EhExtdzg7l+GGgGWzMI4MYV9sltCbuia9S8=; b=DqZf+45MshOs1nlVyinOhqFrKCuzw0gQlsLOP0ABgx6laBf7Pg+beSuaze8QVVfghR awdDutM8sqXBsgP+BXTWzNrINKIlxL9iBKaOC6FIfHodelL7FbNSBDgVYjhwvLKOgE5m MdjjBz40SWhgR+pdZt5+jIRFtwB9GjMGosHqmqyaRwzYl/f1JBuTl1aMIqxNxdBI9KHf zicgU3cKtHZbiUWCVP2oqG6BYFOJGaCiOczU/tO9FR/zPQr/Xvr7opcZkYDOOoS4h7PS iQfhUMh6M2zx9Qn2jzsUzYLyunaEwrK0rd1FhMpQJRTeuVUHLGXqkeJrdlGtH/t/RBDy 5U7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680771504; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DEQiq5V6EhExtdzg7l+GGgGWzMI4MYV9sltCbuia9S8=; b=VnPy/njpmlu+i3yzYGBra32JD7STFd7O+TZPEwsAD91nD84kQB3vuNVkx929KUxpYB bG3cbUt53eDvw1JmQ5rFFTWRS0aoNPBPTTJ1TxerJn5LVKYT7JSRpJYlDLakdIj/KqIb YAqwF30DS1qPucvs0A61m/tRiKb4zLHkEZMsL4/lhptcR4ygQHQsnLfmc9rEiIguGCVa TqapjUmyTqHJ7DH6q/dRAqTsORxSlMQ4viKwjP+gu54ASlQFUIu+FwbqJaxkgBZvsVdN nzsj9lYPRvIw4Q6ZBjpj6KeMUQh3TXrS+zVwB5dSIJxYxOy8AnWMJFuWPBzxxGIuCD2y XMVg== X-Gm-Message-State: AAQBX9d1iJ5bnqB/FBUhJ77brRGKdW0E/Sru9nzIZhiUhPxWoJuamnc0 rILMSPNqqjIiz+8iAqE/aJLFQaK7ONAXOf45zFc= X-Google-Smtp-Source: AKy350YftpXWO2PU4R2xgveFOOV/hWCgUBa/eRONakgCC5lW+aSPlmCOp88OEaOYp2Sq6SUnduQGYA== X-Received: by 2002:a17:902:f986:b0:1a2:85f0:e73d with SMTP id ky6-20020a170902f98600b001a285f0e73dmr8431947plb.33.1680771503940; Thu, 06 Apr 2023 01:58:23 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling , Oleksandr Tyshchenko Subject: [PATCH V3 1/2] docs: Allow generic virtio device types to contain device-id Date: Thu, 6 Apr 2023 14:28:17 +0530 Message-Id: <18458fa39433ce4ac950a0a20cc64da93db0b03a.1680771422.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For generic virtio devices, where we don't need to add compatible or other special DT properties, the type field is set to "virtio,device". But this misses the case where the user sets the type with a valid virtio device id as well, like "virtio,device1a" for file system device. The complete list of virtio device ids is mentioned here: https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-2160005 Update documentation to support that as well. Fixes: dd54ea500be8 ("docs: add documentation for generic virtio devices") Signed-off-by: Viresh Kumar Reviewed-by: Oleksandr Tyshchenko --- V2->V3: - Updated commit log and clarified / fixed doc. - Tag from Oleksandr. docs/man/xl.cfg.5.pod.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 10f37990be57..24ac92718288 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1608,8 +1608,11 @@ example, "type=virtio,device22" for the I2C device, whose device-tree binding is L -For generic virtio devices, where we don't need to set special or compatible -properties in the Device Tree, the type field must be set to "virtio,device". +For other generic virtio devices, where we don't need to set special or +compatible properties in the Device Tree, the type field must be set to +"virtio,device" or "virtio,device", where "N" is the virtio device id in +hexadecimal format, without the "0x" prefix and all in lower case, like +"virtio,device1a" for the file system device. =item B -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 09:08:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 09:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518783.805638 (Exim 4.92) (envelope-from ) id 1pkLbQ-0005uo-Hf; Thu, 06 Apr 2023 09:08:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518783.805638; Thu, 06 Apr 2023 09:08:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLbQ-0005uh-Em; Thu, 06 Apr 2023 09:08:20 +0000 Received: by outflank-mailman (input) for mailman id 518783; Thu, 06 Apr 2023 09:08:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLbP-0005uX-65; Thu, 06 Apr 2023 09:08:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLbP-0005HC-3Y; Thu, 06 Apr 2023 09:08:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLbO-0001MB-KJ; Thu, 06 Apr 2023 09:08:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkLbO-0006w7-Jr; Thu, 06 Apr 2023 09:08:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EnX4CyUyIlLVd/OPkcT7LpM7eS6oFPZK49HT/hv48gc=; b=VhHd+yKtHh7/uMgxLaj/88lmA4 L/Wbjadli4j3miqIQ7ev2XOovUH3e260o03+XF/4ERal06MhMGsUf/3TSOYIogP2jaIt84qlVLYcr JA4L2vg3kOS7mxHTpTO6/44suuTYUxge/w8vxdPStwcoRMONsqGo7wIPcku3yGQAOVkY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180166: all pass - PUSHED X-Osstest-Versions-This: ovmf=3e3be2cbc286e773ed5bd3afd5942440546888de X-Osstest-Versions-That: ovmf=8d185dfb66700e65035d51f149570aeab728c665 From: osstest service owner Date: Thu, 06 Apr 2023 09:08:18 +0000 flight 180166 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180166/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3e3be2cbc286e773ed5bd3afd5942440546888de baseline version: ovmf 8d185dfb66700e65035d51f149570aeab728c665 Last test of basis 180164 2023-04-06 01:42:38 Z 0 days Testing same since 180166 2023-04-06 07:10:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Jiewen Yao jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8d185dfb66..3e3be2cbc2 3e3be2cbc286e773ed5bd3afd5942440546888de -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Apr 06 09:18:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 09:18:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518789.805648 (Exim 4.92) (envelope-from ) id 1pkLlC-0007Pg-Hd; Thu, 06 Apr 2023 09:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518789.805648; Thu, 06 Apr 2023 09:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLlC-0007PZ-Du; Thu, 06 Apr 2023 09:18:26 +0000 Received: by outflank-mailman (input) for mailman id 518789; Thu, 06 Apr 2023 09:18:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLlA-0007PT-TN for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 09:18:25 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8cc340a-d45b-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 11:18:22 +0200 (CEST) Received: from mail-bn1nam02lp2045.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 05:18:19 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CH2PR03MB5237.namprd03.prod.outlook.com (2603:10b6:610:9c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 09:18:16 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Thu, 6 Apr 2023 09:18:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8cc340a-d45b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680772702; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=b86fja9ztHW6IR8ClYPj80TtEDvVmQLZHm9O83fq7MY=; b=W3f3tELm6H/Hf6gcDEbhdl02fg4o56//CNrFDMBkatgM9j4ftNEjon1+ D6zx7A+IpMH4+V+Xhvd2Mxaatr6AQd251xOJU3v7vlnnOk8ldDTldSJuz VinhDfw7JneaDWvq6NvBGnJm3IcGxAAVD0EmCe6iYR/Y/kQZgpJuXXvx7 A=; X-IronPort-RemoteIP: 104.47.51.45 X-IronPort-MID: 104565972 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PCW4NaJoK4wjPGyxFE+Rz5QlxSXFcZb7ZxGr2PjKsXjdYENShWdRn WVLWjiGOvbYYzOnf9t3aN6/9h8Cvp/UmNQ2SQZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5TK2dB8 uM9BQk2TQCSnfq58p6DR+pV05FLwMnDZOvzu1lG5BSBV7MMZ8mGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dupTSOpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyrw27GSzHyhMG4UPK+i7+9AkACx+kMWJRMLUX2rp8mZ2lHrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAHSThbYdBgq84yRhQtz FaCm96vDjtq2IB5UlqY/7aQ6Dm0YC4cKDdYYTdeFVdYpd7+vIs0kxTDCM55F7K4hcH0Hje2x C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2ONo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:6QOZb6NUjsdiqsBcTuOjsMiBIKoaSvp037BL7TEVdfUxSKb0qy nAppgmPHPP5wr5IUtQ/uxoW5PwI080l6QU3WB5B97LYOCBggWVxepZnOjfKlPbehEWwdQtsZ uII5IUNDQpNykBsS8h2njBLz/8+qjgzEl1v5ak856yd3AWV0kOhz0JczqmLg== X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104565972" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8xNq3oRb7VmN0cOOS3xR+/cJyW6MpesmT4uBtWuSj4MWt6qAdmGPYVKqabs3Cv3uWojdV5QJzwvcZUKwIeXitKV+8xnmN8cZ+FAh4gBFYMfIXfKLF+U8mA4C3diyS/nl7HkOLh9BqDSvPuLDIMBsBWlBir18GTKAu5gzbsJ9E4K/gdItVVRdvpTpMuMfcqzs1bFGJbt/WgjcY1RY9gWyZKyviMMaHZ8z/p/EH8pCAPEwBBi3RYYT0z3s1tMdB+EI4dXJawHUsZ6J1obXw29meFddreNTD3ugZ/ZKuDE74SEgkeqKtSe88yPdjZqsWFL/iO1/5MAqmMWwN5s6n8z6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nnCA7B702KreQwdKNNPADcBQDwWIhYrArbxnmVXIaVQ=; b=fbeeVzboX55rGvvwI/c99TC0gDegBVWafk/j4PfFdAgQIFl0FcXjcF8ARgxYusCYWB4L667FizjWMc+t0i96UzR7d4uHNJNhvxg1R66pE0waP+MlbuR+3sedBxx/gPuGJP0VjN/MZxaDLScU9cosx+3FoSCuORLP7D4FATZt7ELvJBXwj7r1Aigp5wVjvkddoZ4u7GmrgdYwX3/aGyM/OSfnsqFG6Ow8NmtkQTvMxDNSoXIqt7x82zvnM7SJawvrZK/a9CHPQ4ZXRBauiDrcP/fu9MOg+GWsBIzjQwt+4ltWsdCtTbxZewogiwwjU4tLmhTyr9cpc2ojXc0cws9hNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nnCA7B702KreQwdKNNPADcBQDwWIhYrArbxnmVXIaVQ=; b=nWUEDexLPu1CjrQiNvZNAs7jniUtBMzVS4Ct64mNPCKngRmy3Y7CcZD8PtObmDeM2vPGdEDdB9crA89Rf6gfUNZ9cGoSqWogdmRY4nsNAMdYp2zBVFRIWv2NBcqyCoQYsF5OCMbLXj+xUH7Xv/jYquQkbe2gKa8PFPPEQMda4N0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH] livepatch-tools: remove usage of error.h Date: Thu, 6 Apr 2023 11:18:07 +0200 Message-Id: <20230406091807.49028-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0091.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CH2PR03MB5237:EE_ X-MS-Office365-Filtering-Correlation-Id: 994f8dae-6a35-4811-52a4-08db367fda7d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Txfqyi/JpK/S5syxTV94OEV7i6h7Ke/14BKTAFEZzVdPISYfX6LL9Y+EXQ8euQh872rwmQJaSSAtz3PUCSdavELmxNW1LvRlXhJ+qD/2eFQSZ2IEXhg9xbswKWAZwPTkANhZ/3OL3+8ERQPFeZgxbu/mb3D2fOM5lGp4wnZL07RgFkDsOScTeZGcLjqnD/JgSmeiRidjCbz6wZ2kXLLt9WP5deqZJ92nfBd/GG9RQSZ9UEOTs2k0VxopKRRrwvktXo+2+QiXJ3X7oDDc7QIvln9Zr1QF52ttIJR3LpjM5VmEUfiCZEwK98FgdBMGRz3s9nPVwZszwilP1E7CHHwQV6RAb87axj0qzW1sYkZxLBxmKd9WVwQzu10ioY1wD1dEhPCJOaAiB2yHQM5SVEScSnyyMOjRk8Xj8Dr1wgRZ/DQcJ2xQO27l4BtOHBWoybskzC71vu0xXKp/tQj9gMSlmXnqiX1ZP6xlro9QJf9rvC5pHWwXHd9XeptR2p8SDIkxUDoYmRSiwsQ8MtSKK0gunrT7CrpF+zGDbxLNvzCbuL+PXeUwJnTqDeNbRerP7IHC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199021)(316002)(186003)(6506007)(26005)(6512007)(1076003)(2616005)(6486002)(36756003)(6666004)(107886003)(83380400001)(478600001)(54906003)(86362001)(8936002)(82960400001)(41300700001)(2906002)(5660300002)(38100700002)(66946007)(66476007)(66556008)(6916009)(8676002)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUJqME1kb1BZeUhOSG5hRXVaYUpYQVM2aUdOYzZudmppUlJHc3FQTktZKzZX?= =?utf-8?B?YTE4MUcrWi9MR3plaDVaSmxQQlNuSE9FOXJ6VU41TmhMNVQzMkN2L2U1Ykh4?= =?utf-8?B?b0R1YjhEOVYxVFo2YTRQeDJoMkpvMzNWTGYyUjREakFBTFF4TXFPRkxSOWdB?= =?utf-8?B?a0psMnNiRFQwT1I5TzVlRHpId3ZTVkVSbGl3Q1pOZkVqb1l6V0c5ZUlKQkFj?= =?utf-8?B?Qk04bm1TN0lIUDlkbzNrbTlUSHdqd0thanhrUjN2SThpV2s1ZjBEckdQZVlL?= =?utf-8?B?ZURCVjlrYnc1RXNZaS95TFlBeXFsd0FuYjZ2cGJuWWl3SlJ6MnVaazJYWU5L?= =?utf-8?B?eWRWU0JJT1ozb01EbUZNcElBdUFGZE8wUkVaemVrZ0pENDZkOTk1Y2JSemRh?= =?utf-8?B?RlhjSzhDMG9uYUp6eDFpaWZVWG9yT2xEN21hYzY3UWhJYW93VWNmWkYra3FT?= =?utf-8?B?K2Y5Yi82T0NOTFg4Rm04ekVwNEhMMjFTK3FLMENWZ3g3UWNRMzZsOUx4YU53?= =?utf-8?B?NlVxUm9HeEp4Q3JZYUVWMnhsRTIyTkNwV2xjMTBuWnFJaUxsamZ5Sk1WTk5E?= =?utf-8?B?S3RPd2FPNUFCMkltZVkxS1VSRWdiRVZGZTZnbFhCRm1mTlYrUkd6V2NnMFN6?= =?utf-8?B?TG5Cd1c3c0l4YlZQdkNCZjROejNGZmdjNTg0bnBFWkZJazY1dmxMU0tNQ3pa?= =?utf-8?B?a1NxQVVYUFNqbjRZZEVCNmhqdzhMTmNUUmt5anFsVjFlejFab0ZQYnkwOFRk?= =?utf-8?B?N2pMMytJYkRSNXlEdVE0R3g4NkZZYzBJVXhPVXllK21mZnBhbUdUa3B3cDVP?= =?utf-8?B?YTFlRkpPcWkyN1lweW12eWdNMWY1OUlEUytVUFJ0ZkJGT1IycDJCZlZNWVlw?= =?utf-8?B?V0pVZjRqaEFna2cxWDdabnJwKzdrTmM1QlJvM2tadkwrNkExY3U0WDhKcFpE?= =?utf-8?B?KzhoV2JaK2lXT1FCKzlpQUppN1hqSGxjQ05aNU9HaENrR1NiVFVTQnNkNHRo?= =?utf-8?B?VHBRZlZOQXdpQ0JsVEhpdDJjaW5HcHJEQ1RHcUM2bm1KZzlzRnBHWG1oK3U4?= =?utf-8?B?Wld1S2E4MXZaaitZdkswTzRGTHJmNkcwdUJ5QW5zUDJ4QkFhNWFhQmpPODFB?= =?utf-8?B?YnhZMTQ5OVcyOEg2SEwvM3hWdzJjUElkWTBuUlNHSEF5aGhORlplcnhiZ2lw?= =?utf-8?B?aG5jYjR6cUZCUFRoa1BFQnNVVnBiUGo0c2ZRN3phVDNaVGpXTkdnYWVTdHhx?= =?utf-8?B?UHFhbEg3QlAyY3NQQjhoWXBlR2VNUndsWTlOMnRIQ2hrVElNVDJwSnBtODZB?= =?utf-8?B?aXpPUytqV1N0QzI2Q3UzU3lEaEgvNm50ZW1rNFFIZEdaR0ErK1BuQkczWTA3?= =?utf-8?B?NEVWZXFyVWN4YmVzdDVKaVRmaGJCeW9BTmVieUpyRU1KTDBDNlh2dnJDVWlw?= =?utf-8?B?RU5qNmw5OXU1MWtLQXI0dkt3cG5RbXcxM0UxNjRSNk1kZWpCWU5qUTVtTDNs?= =?utf-8?B?RjMwTFpjTFlucTJXWEM3RGxLdUZWT2x2U0NIZVJneTN4d2ZTQUVQSWFMQUp2?= =?utf-8?B?ditjOXBobkxJZ212Ny91eGZsU0pkc2F0T1dNazZiODJYREtxVDhDWUNEaFBL?= =?utf-8?B?RUZIQ3BiRnU0RENkb1pXY3B0ZE5FUlRKZTBwVHlVTkVOQmtBYmxERkVLWDFs?= =?utf-8?B?aE00NWdIQnR1bUFtZXUxMmRhM1lQeXJOZFFCaDF5WWZTYm55T0lqRktaTTJ4?= =?utf-8?B?UGhEUDZkMkdTckwvTkFMU3N6RmhZbU44MmtNa3hCNGVhT0VsK2VXeUwwNFVE?= =?utf-8?B?T1VXN2hxeDVmQnJoVmxRZUdBMU84d0hqVlNlN2hzZzVMaHZjaVNKWGlQSzA1?= =?utf-8?B?a0JKR2U0WnhGOFE5UVdnKyt1bkVXQVVGZ3dGKzFUdkhaOEF4MmpFNXFidWN0?= =?utf-8?B?ZkJyeXNpUGFKUGgvbVhpRldnMHNwNGVjd3B5VTNaNWRBdEVISlNRZ1Q4K3Zw?= =?utf-8?B?V3RjMzV2bklhNTJVSElHcWRId2tOVHJTUTlXYTdFV0lGWE1JOEJzcHF1aTJK?= =?utf-8?B?cHlDSTdsa1ZHR2xIZWpwK2V0VU0rYkJWcUlWczNleFJ4SHZFbEVBL0JDVVRh?= =?utf-8?Q?a9a+a39WHA3D41TZ0emyfNml2?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: T6HaCGxBfx3BWrlvkPsX/Uz5TnRCWLfp92ysKg2JPTG1cDgWPUXpnyE0TKtGZM76b08Im+j4UlActZUi+/LBn+kfjM46rJrnyw1soDsfTJdVz9ThCvpmtC9j8FF1GnSLlki5dYj+aqOq23wG/i53a50HTvk7umsQ6IqgIyQN7+DSYpTHjzfUixQKmrXYRi6SN6RYKX2eBhp+o3Oq7HVlyo2uWbS1VwxZL6JcdKGJi78h2d25goyAXSNFl4TqZcpgmNVUYzGoZqYAdSh7VTOANviccgKwjPkO+msi0XUrXfnFAYZn8uVMmM9E9AQmRjVjYqBzQV7vkdga7u0HRCDOmAKOeic0VqkmlXXoVYrWLD1dw/DChszd3QBTzAFdwB8VVXE6gHlVZUviW+6aqFZn4wX3X0UM2rRMQ5XH8U56b7IMYG/tiH7G9VhxBA1urzDuZqvD2+whwxFX4cWHFPt1AiL2GEElzUKDDirOzNLa9DgHi7bVeE+Zk5Mt7tLig6f6tQVsYJV6M43FhqRg0zz4d4y13Fb4zDN7G5uvqYv3+XpxdH4suS1HetBEOmAn0hbH48f+8wDYE4/xvOenk/isoOyiH3UxFaRrr3cSdU339h02WdLTAA8hZO0C6JOp81oMbEnQM72IZt10ueHaby+RdW5WOkh04Eror+F9chGfv5FiNA7WEnDyaeOC6XGFb4UJJBZQciXWUYu0FSjUakcBJvn0StlXjBXj9SRIyxtDj4kRfjBqpLfStsDntkpBaygj9LXUyhmHDaTbzhRKH8UJWz2/K0ZG01fQkK6NqFjWCjAawZ5fM8XT+kEPAdgs0ome X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 994f8dae-6a35-4811-52a4-08db367fda7d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:18:16.0178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /+Rk58LVKarZQjUR0WYvbYpyzKb5FBmroMkER7wA+KUhP6fVEOxInWsm2A4dAnXRbdV+6/IXF2jZZX2nA+lYXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5237 It's a GNU libc specific header which prevents building on musl for example. Instead open code an equivalent replacement for the usage of ERROR() and DIFF_FATAL() macros. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc: Ross Lagerwall --- common.h | 10 ++++++---- create-diff-object.c | 1 - lookup.c | 7 +++++-- prelink.c | 1 - 4 files changed, 11 insertions(+), 8 deletions(-) diff --git a/common.h b/common.h index 9a9da79..ec2ea33 100644 --- a/common.h +++ b/common.h @@ -1,18 +1,20 @@ #ifndef _COMMON_H_ #define _COMMON_H_ -#include - extern char *childobj; #define ERROR(format, ...) \ - error(1, 0, "ERROR: %s: %s: %d: " format, childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__) +({ \ + fflush(stdout); \ + fprintf(stderr, "ERROR: %s: %s: %d: " format "\n", childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ + exit(1); \ +}) #define DIFF_FATAL(format, ...) \ ({ \ fflush(stdout); \ fprintf(stderr, "ERROR: %s: " format "\n", childobj, ##__VA_ARGS__); \ - error(2, 0, "unreconcilable difference"); \ + exit(2); \ }) #define log_debug(format, ...) log(DEBUG, format, ##__VA_ARGS__) diff --git a/create-diff-object.c b/create-diff-object.c index 780e6c8..d8a0032 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -45,7 +45,6 @@ #include #include #include -#include #include #include #include diff --git a/lookup.c b/lookup.c index 39125c6..b440102 100644 --- a/lookup.c +++ b/lookup.c @@ -28,14 +28,17 @@ #include #include #include -#include #include #include #include "lookup.h" #define ERROR(format, ...) \ - error(1, 0, "%s: %d: " format, __FUNCTION__, __LINE__, ##__VA_ARGS__) +({ \ + fflush(stdout); \ + fprintf(stderr, "%s: %d: " format, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ + exit(1); \ +}) struct symbol { unsigned long value; diff --git a/prelink.c b/prelink.c index 2039e5b..18c5159 100644 --- a/prelink.c +++ b/prelink.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 09:32:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 09:32:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518794.805658 (Exim 4.92) (envelope-from ) id 1pkLyJ-0001O1-PV; Thu, 06 Apr 2023 09:31:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518794.805658; Thu, 06 Apr 2023 09:31:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLyJ-0001Nu-MT; Thu, 06 Apr 2023 09:31:59 +0000 Received: by outflank-mailman (input) for mailman id 518794; Thu, 06 Apr 2023 09:31:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkLyI-0001No-3R for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 09:31:58 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062b.outbound.protection.outlook.com [2a01:111:f400:fe1a::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df6d4c47-d45d-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 11:31:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAWPR04MB10005.eurprd04.prod.outlook.com (2603:10a6:102:385::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Thu, 6 Apr 2023 09:31:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 09:31:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df6d4c47-d45d-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RjJ5lKuGzxJuKMynp6s9tI0FCv0ig1su6zgBMKdjBtkQ8YKf3DGlk6mIaBFLzudZDP61QN1g03oegdIGYRJsm0ditPz5/fAq91NuJ7JRtePOuPXWmdGBtU4ebA3J4ICKx++XFnzOf71mH8n7mAKStkfk9B1dtkEz6DCqrnSBcBdS/KFH6rjksfh6U8zxu9Xca7g43FhqgcmR4fTzONlND64SlypI10/jHbdkydyRvMv9IzdIvN1KIr2kWR8+fsuOgbFC6izlIZSzErwQj8JEw6Xt+dtXmyRzdOBXtWO5LHe4oFj18jNQCNH4J0ciV65ik1xhQVJx1cQqCzlL37Ai8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9L2hFRv6P4F0H7tzS8f0dl8uOz+tEs6WwzZa6b6gSKs=; b=nXV2A2i6P+hMU4lbN/Yp6U51DBK5FNU9CXz02XFhvEe3RgWFVy8rr9nWS+RTaqI13Z1c5qdKMUstGhIA/gA0MbCXI0GXdrUxsF6xA/nuzoLTVcUxCB3RCoLLgfzP9rU/oTe7Y6LRKrs/RMK2iJVfFIbByQqnYnpPlxk4LMJJjO2rlPOXA1OWuJ+ORPIbFYJ89tQ9+VxuyMvf0C5yXvFV0gUXAVrMei0bJOr9UKHYt3gBB5s0XfCtWJfwIB/55NXwbQUsG2Uif0SdMODeKaf0pmu2+ejWfsFgfdkwfgva+i6Q06aWR7UwiWNaQZfJzaOLieQhqE1S+8ho+5f0T45usQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9L2hFRv6P4F0H7tzS8f0dl8uOz+tEs6WwzZa6b6gSKs=; b=xePubQNtrt7ggDcGOloQ5z1xZmsB/XH7hlv+c1xNY7p2mSGZ2k9fy0heqMgXFRnvhSGRY9laP8+/1+S04y5koiVZbKffKroHgO7swo7/I65hU4qeR7DBItroeFQYdvHXD9Z21ZdS+4zfSCA9KNdGEqeqtfVdSFf4zmKX36jALftU6FGSIWzz7LB0VHL8ryQ4QYJDcOk3IS3d6tmNiRF3v0x8nytMh/rSkeH38Kkw8oRFdO2cqSpMJcU+qMRUJ1RcdfLmEH+tr9j9FwMWSyIfhinVm1DtHuwNEQZiZvk2ev94S4qexBZf7+LauD9s+cDfqlWpfGhtg5Vd3Sa7ZtQf+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <313a2a18-020c-ca76-f620-f5694a74efeb@suse.com> Date: Thu, 6 Apr 2023 11:31:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230405204423.2113418-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230405204423.2113418-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAWPR04MB10005:EE_ X-MS-Office365-Filtering-Correlation-Id: 244fe29d-eeb7-414f-bcaf-08db3681c243 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o+XMoBUObTM1601SPK4OlSsUgJeKGoK0G9wL+fMpgMZ7XcZEjhihUveUrAmLRfJOGeHtKEpeBBCdhHiK/GmJtJPw8RxD1sfgM6sReToplBivKOsQ6lgKbe4riigmLctxj0kWLAMR51mRiz+lyBvc5BwbERJj6StYkvoIzkUNEWGsaznUEF63iA3fRnIEcR9PaZGyOKm6xM2ZDdybwU8649qNjXhbKgE3n217TKcHD3gcJo3NX9QilCHKxAPekYxhd0NxzAs5dRS4biEbvhpce/vMkpgqiPesGDR6B7WIBXMInQo2ajVfMSC0HY6xin47b9Ql1woPm1op1Hg3I69FdNhfWc05h4LpnCDU9GhfBvf982z6a+miPgijajIXQSrFQJ2dM7XiXMhVEJU136d6/LyFP4kHFSB2YmD2jWq8GSgBvf5rRAdk53UWNFBYbqZ670TbTUzp8ImLBtx/nJE4HOg8sn4UUgCZLXxVcmJ/h4uZiMtT3pCBQKIO6g91+jx5TCk4xw9nLC6G1hh7V9wB3eFUTyAbxQYCyVjakqmwEOCFKPv9WpfpVsFBQVdSwnJyQfWcUpJRJMwH/do9QnXKoq4EuuiC7HLolmbfZU/bHiHdwHVvyulpoVsXDXWQB7fGR2qP8DEnNmxTBpujucyD3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(366004)(39860400002)(376002)(451199021)(38100700002)(31696002)(86362001)(36756003)(4744005)(6916009)(6512007)(186003)(4326008)(26005)(2906002)(6506007)(5660300002)(66946007)(478600001)(66556008)(316002)(31686004)(41300700001)(8936002)(54906003)(53546011)(66476007)(6486002)(8676002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmVpMWtoR2I0NVFBdWRHNko3a3hJbW9qcDZtYWJoTXk2QzhmTjhtR2FQRjNo?= =?utf-8?B?ZWZQcmJnRXZEZWhiTitHM0orekNZREF1YWRNNDBZN3lvTVdPS3FScC9Vamtw?= =?utf-8?B?NU5tbTJqN0pscmtXWjJtMHgxT2JsSUpxYmltTkVzWFJtK284MCtiTDE4OUNv?= =?utf-8?B?ZDI4Q2dnb3FTUWc5OUYvcFF4bTR3bExROW1QN2JJSHZUb0cvT2VNL01BTUh4?= =?utf-8?B?cU5FNTN0NHJrU2RwUFJHRTVqY2Y2K2I1dElaRldhdnRTK0h4cE05OE5qVDZa?= =?utf-8?B?VTc5dFZyOTBLNXpwWmY4TGUwenNnMzZJaEdxTzE1K0ZzamR4cFo5YXp2bXBa?= =?utf-8?B?YWVYOHZsdmlGYm01WkxZSE85NDdMZ2lIOXA0K3ZQazAvUWlaV2ZlWWdEazRO?= =?utf-8?B?TFhzS2dPUms3LytIN1lxK1BkSkFDekYwVTdabW9NZHQ0VlpMNmJic1pXMHhU?= =?utf-8?B?RUR2MVpHZ3d4TWsrR0w1VDZzN25sRDh2RUt2RkU2a0tidDZGaEM2Y1ZxNWlW?= =?utf-8?B?NUo4QTRFVTdaZHlJZU9adTBQekNlYVFhd3Z6UXdFWmkvOUVybWNsZm1ZeS9J?= =?utf-8?B?WXhCZ0QwMUd5SGtsS05sb1N2Vkt3ZnNqOFcwendTOVMySm45NTA4TEc1QkNR?= =?utf-8?B?ZWx2YWxTYTVyYkw5YUk5cUVPT1VvUDdxREVNTWhnUW85ajA2K0RNNlhOQTFa?= =?utf-8?B?YlM2RXFqa3NUOGRIbitvdWpaTkRYZW13aU1jNXRQZGMvbWpFOExGaFMwM0J6?= =?utf-8?B?bGNETk9SRC8yNHlyTTh1VjFDbWJmTjZkc0N0RExTcWRtRkRoMEdSdHRUNGNI?= =?utf-8?B?V0g5N2NXcnBaM0tkWjdQSFZob0hjN3E0QnhrbnV3bGdZZ3VXU0VSNG5qa28x?= =?utf-8?B?OEMvTW1xN0dtT0VqcjJVUjZhUStyVzdyS0N4eUQ4c2NBQlV4UWl6anpMbGRC?= =?utf-8?B?U1VPcURtaXhvQnZSSGxjZFZqbWsxVlNNYnN4ZDNLRTI5K0g2TTF3UU5kMlZ0?= =?utf-8?B?eVNsL2VEZk40ZXFIbkdBQ2lPMEhtdGhPNk5SeFFnRHBkdTdWWCtBb3FGVU5n?= =?utf-8?B?NkpZeFpLVnl0dUwrVmJwWmx6c2Z6N2w0STBXOUtNbVU4dkRjcFRjUkFFdU5y?= =?utf-8?B?c2tINlF6NDk3SUV5NmJSN1M2STlnNlNoMmo2Q0hubkNvblpDSFFITlFNYXZE?= =?utf-8?B?dGsra0pCV28wd2djWFVTU2ZiT3BQTWFmbXREcTRwV2xJZXJPOFZRVC9sQUVQ?= =?utf-8?B?MlRNSkF3WXdydWw0a1RXYnpUZ3RiQUd1SUR1d2JoSDREaUhoRUkra2x0eGNk?= =?utf-8?B?Z0NiWTV3eVF2NlBFeVV6Q0Vuc3dnS0xGSnpFVjhhVWt6cXpGbU5YM1U0bGI3?= =?utf-8?B?eDRDdkhyV1NiU3NZYm4weGQxSnkxTUYrS29uaTNjYlNrUlc5aE14OFNQWFJP?= =?utf-8?B?M0t0endVdmJpbFRZM2ZqV2treDFhTWRtN2ZtNHNEbnNxUmQ3WjYvMktFVnFQ?= =?utf-8?B?MG9uYmVvZjQ0Y0xHK29jV0hxdUFiMFJFSE1kZGZ4ZkR2TkVPSzBoRGdzdXdJ?= =?utf-8?B?RGRzL1VPTnQ3ZkVNeHVvUlFVZitjQ0xMYWM1RUkzOUl2ZG94Y2lxOG5iSHRM?= =?utf-8?B?TGV1cS9TRWY2WXE0REc1THVPa0h2NmwyZ0phVUVnMnBTRE04bUl4YmJxZXg0?= =?utf-8?B?RGE0U3h2UkxoQkhCNVlFTHdOdFBLQmRKZUxqZXgyU1RRNTlybEN2bXQrSmFE?= =?utf-8?B?cWxVWVllQXVvazJsSUZwL1RlRkd4RDFUWE5hOXFLbm9yNzRacEdMeVlLNFBN?= =?utf-8?B?ZXRTRGtxeUFQakZJYS9xWjNrNzhZa2JUTTdpTy9rYkRadkEvSlpBbGRQM3Qw?= =?utf-8?B?WW11ZWh0c25nUnpGM2xvZE1ING9zQXYzVURIZDZQMUdXc3doU1E1RjJJeWU1?= =?utf-8?B?czRuOWVMKzJPV0hUb0Q0QkEwWnFTQjZpZTNUMm9NNGFWdTUwQlBFdUNPVlZw?= =?utf-8?B?a240Z0ZYc2NiQnZ3MUNnc1duL3pFMjdNQlkrem1PZUVFVG5Dd0Y3L1l2N3Rx?= =?utf-8?B?YnpHZTRZZE1yN0F2anVkZDIyZDRqSnhLUWd1cVVGaEpKS2FJa1dYY0tGb3Zh?= =?utf-8?Q?2KjnB/YxPy4elFZMzoTH/DB1u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 244fe29d-eeb7-414f-bcaf-08db3681c243 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:31:54.3479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bCzUK8qWMIuLtNu2WlU18xzKwmmhgdW9NTOTlvOa/8pOfmiwHbWUfOiaPA/SwNCTokFiioFHSaYIRcyziyy1Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10005 On 05.04.2023 22:44, Andrew Cooper wrote: > This removes raw number manipulation, and makes the logic easier to follow. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich One remark though: > --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h > +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h > @@ -450,6 +450,11 @@ struct vmcb_struct { > > uint64_t nrip; > } io; > + struct { > + uint64_t gpr:4; > + uint64_t :59; > + bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ > + } mov; The field being named just "mov" makes it apparently applicable to DRn moves, too (and the title supports this), yet the top bit doesn't have this meaning there. So perhaps say "MOV-CR" (or alike) in the comment? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 09:37:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 09:37:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518798.805667 (Exim 4.92) (envelope-from ) id 1pkM3A-000200-Bi; Thu, 06 Apr 2023 09:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518798.805667; Thu, 06 Apr 2023 09:37:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkM3A-0001zt-8y; Thu, 06 Apr 2023 09:37:00 +0000 Received: by outflank-mailman (input) for mailman id 518798; Thu, 06 Apr 2023 09:36:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkM39-0001zn-9i for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 09:36:59 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91e3816d-d45e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 11:36:57 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 05:36:45 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6746.namprd03.prod.outlook.com (2603:10b6:a03:409::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Thu, 6 Apr 2023 09:36:43 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 09:36:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91e3816d-d45e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680773817; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=t2dkUTvPu4iQJ9JC/sfi0IQMhAaSfTsB0BbB2aOUB28=; b=CuhwXZz4WMnkWtCo5qkT9hVSwszfRKaHJePzURmeCxqIySucWgK0PqM/ 7j3st3rzub/j/aZuuJmMuF07vCKZLP07BM9GwUcyuIm85/iaibm5ymijl JCbkSgcqBxrK81EUURveIQUuJznEc5/Pz/AXacAN1MJYuUbm2yUAH+8V3 U=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 106966057 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:a3weoao8JLZ+ctnYh8Vq2QtiN7leBmI9ZBIvgKrLsJaIsI4StFCzt garIBmEbvuPMTDyc9wibNmx8U9U6sOGz95nHQQ+rn8zQS4TpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzydNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABsIYw6voc+u+4yQZe5DgvwHJfbkP7pK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIe9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqK803gXOmQT/DjUdflaWqvmoiXWZXoxOB RAs03AWsrIboRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC1 ViPhdrlQyNutL69TmiU/bOZ6zi1PEAowXQqYCYFSU4A/IPlqYRq1BbXFI4/Teiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:t723GKplRNVMq88FTAWyg9YaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="106966057" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsYT0v2X80oAAjqV4g7zDqizvfABnFPRX73JuHqfW3Ov+3zsqZ/j6kN8XMKzrdHB2pAdyLgxCZj1eXODSPX06csYq6nZfQQQz+z5fjRUUeWe7fum8NRwL6QMLD2HuF49TMLEXUDsSbQy1/phnoCJtFmZgQvgBpb9eyIMY3mu7WJif8OtG9mxfs8qT9APMyRlN/f2sQaw5IIU+pXYl8TDDgKFHOA4XDjZ2e/rpTrvuvdQKsU+Y8yqa/ljD6ge9cMLmwVqEwo3maNO71cNTyx/3bbqRxoLHbt9lJurDfWzUKBd0ucRinVR9bOfBxpM3vQ1y5dP6zdK7wjK6Evd8+PUpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HUMCD5S95GqMGMWGQq2L1ujqOJ5fEhqwkrZ8ijeAgxo=; b=UViZDI0R8Ha17jHq1c/T1+gXV66iacOq9W8upkgSRJWuEz7SgfZA5UNGZTsVnBbXqIuTMaqJUt6XVyVYm4MzCoqHdp8M+EMLqM/S8eN1ycfF1PIpKslB06nlF9G/Kcnmm+24pvR/EkQjOuP1Q0TEj0joKEFjtB7Dq+1DaxNBsNy5lGlP30CqWP8Pyxfj/fjzxtondXVXlCbd9vyINE4kfu8WdTD3HYlTP9MnL88xJparkkE5bIhJpj3Do761zKw3yvRqpAe2b/vNAMF9qdUgfSzU+GouNqJrAj3LAUHPkTn9Z8JaIlejlqshYp7+7msMABwq6Mdipn5hFTf23KAYtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HUMCD5S95GqMGMWGQq2L1ujqOJ5fEhqwkrZ8ijeAgxo=; b=SI5eQs9S2u2nkY1YkizmTwuJNinX5HfJBhQvSOe7v0zqDmbw3WfJFUgDWxTKJr1QeI21KVPRMid5fNGUhGzAGDfdw9+Ynoz5XLmNoAZVBN5QZVlzmSA7yCRiTB7un84yLtQSux47DVF221/073HHjEsZm5mQzGbutUc8zoNJuYg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4525547c-e309-c994-3dc7-5d1b398aabe1@citrix.com> Date: Thu, 6 Apr 2023 10:36:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] livepatch-tools: remove usage of error.h Content-Language: en-GB To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Konrad Rzeszutek Wilk , Ross Lagerwall References: <20230406091807.49028-1-roger.pau@citrix.com> From: Andrew Cooper In-Reply-To: <20230406091807.49028-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0386.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6746:EE_ X-MS-Office365-Filtering-Correlation-Id: f1f54af3-d120-4e7e-9e17-08db36826e73 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xytTK0eHICpzCvw98rOmBHwGjIsEWgkycFYWS8PXkZLpIeUI8k8eCsu2TOAGl2sP2zLy69zJbeqmQ8XUMvubtn6rzXqOGCX/HAZGQgPaHqIf4Qy94fDede6cIIWuvxDMJiWUVFLLduVpV/EsQH4qoCqgXS+crkFtfBcoXHJ2COGczAEvFWBQS8JVYU4WgTe0VNU4m6qJBcNo8OdCTZrc//AFT5JslRspWhpdCKrrElq9f1fR1bSFBIeyQC/xIi581eC3+k2DVVii8Sbz5sSq3XGHtCZQofTGjjF0cbmbUxrWjdNMWYey/7XKLw0CYUa9iHCqBfHUwe8MPrY5Z9ZvpYuR7CZtqwABx26BE1A4+unV+KklaLYrEOD7+su5bjZuAWipBdf/oqAJS4KThkTC3qYpYuL7EmNymkXtoRURAivtDddYreEtMH+qum2EVT7SKoGYPzSqBsjXPmvqPVAVMeUnBosGDFSb2GlFrjDIx/APLy790baGRu4SeugnQ7Uklg+KbNOu6RnvFIo7hZTC+SoDWmAfCnDX3z/xM5KWrUgn8dAsxFgGbOQt/RdCAevv5FzmJtm2o11t9xY1IQ7m76czDyGfMFhLSPxtJZmlA5OXtyr3tYeL62nApf0wk7i4D9yvZjfYqAqnoqdsecp0ew== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(366004)(376002)(136003)(39860400002)(451199021)(26005)(31696002)(54906003)(478600001)(86362001)(53546011)(107886003)(6506007)(6486002)(6512007)(6666004)(36756003)(186003)(316002)(82960400001)(66476007)(66556008)(66946007)(4326008)(8676002)(5660300002)(38100700002)(31686004)(83380400001)(41300700001)(2906002)(8936002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkxyRWdkY1Fpang1VGtETTN6V0cxVU9LMGxvNitiaUZsUFdNUWxFUENaWHFl?= =?utf-8?B?T2pyOVdlK3NESitGajJaTlZYdzhSMlhpelVLTlAvSjVTMzFRZzNrNzdidVlz?= =?utf-8?B?RDRsUzlzTnVuWHgrSUhRVHdCOUR6dkVLczluVWM1N0p5NXk2NCtVSUoyemht?= =?utf-8?B?YzFBM2p0bDRIeVgrVHNCRm4yd3ZySTMxTkVoUC9EaldvMnArL0tyVW94b0hy?= =?utf-8?B?WUVFZ0VBL0RwVWVJRHAzbllNb0pBOGZnMDlkZVhRSTFnVDZmR0xQbEJWRWJP?= =?utf-8?B?N0g3QkFkakNUZjZqWXpqMXlDWU9mZGh5S1V6WE9FNkRYREVWQzlJa0ZBc1N2?= =?utf-8?B?OGVtcHhMZTZZS29BWmdwdUNacnZRQkhCNDEzalY1NVhsSnIyNTBOR3ZZWVlv?= =?utf-8?B?RGJ1aGI5Uk9XRVFGd1VLSHV2T1U5aU5xOU5tOStlb0RtanBiM1hZUjk1OWJC?= =?utf-8?B?TlU0TFBVZ1BCSGMweStJSFFFL2NzUzB3NC9QenU5WldmalVndC9Eam9iandF?= =?utf-8?B?Y2dVK1Yzb2pCZFVQMEhXQ21IZGtKSElOdDZYVHEyVGZ0OXFWVkNMRWMrZm1w?= =?utf-8?B?dmtjLzdsRVRjNXhxOWpFQlZFUjdpemNpcWZpVzZad0E5MXA0QVljN2FhRThG?= =?utf-8?B?ZUpLK3M3bWllc2ZTNlFXQ0lZaTFZd0ZLdmtyS0VXbXNnL3Rrd2RZaUg5NjFx?= =?utf-8?B?UDRjWU9scktVS1FxTngyQ0ZoZktnTXhHS24waHNDOWZpVk11V1ZpUGNKMjIy?= =?utf-8?B?KzdzMzJBcFU4VlhwVUsxTTliN2lzKzJrd0grbFFYVndCRE93M2d4L01id0FC?= =?utf-8?B?TDlKYjRJUm0xNVlLdWlPYzJVaVRXZXovRUg1R2lTd1VwOUhzeE0wSFoxbksv?= =?utf-8?B?WEJpcUNxYXBlRERkZjJlUFhMR1BJaDRvbjJNY01WbzUvMGI4VFlWZjEvU0Ro?= =?utf-8?B?WDdJc2NFdFpqOFhsTlpuY2tNT0pPTFgvMUxFa1pSSDdMWjlnU2VOeVVuYUZm?= =?utf-8?B?RUozTEtDYjR4dkM2aFdwb0VWTFJPblpXUitmVWsrc0VHQlI1RUlwamtWL0py?= =?utf-8?B?clZKSmNhcXkwc0k3RHlVYkxMaDlLbDlQY0hWNzQzVGkyS0FJeEJLWkl6Ykpl?= =?utf-8?B?VXljMi9FamRJQnZRNXNNMHRwaXY4MEpuOERpek92aW5lN3o0eVhmWGdvQjRx?= =?utf-8?B?cExiVnBHbGVxbzRtMElhVTRwS2hpcHh5ZjB6NmtKV0lVZVFBZHNySjFyWUY1?= =?utf-8?B?V0FpYmIrZm9CMGxnTjVSQTlRK1VVREZsZ1IrSDU4dm81N3h5OWZXVG9aN0lk?= =?utf-8?B?Wi82aEJHVGx6cGxYd2JSZU5sWENUY3UrZVNPRmtzWVp6Rmc0OTdKU0FuUERU?= =?utf-8?B?Z21tdncxM3dxWDJ5dmw2SmIwU2RFd1ZteVlaeG9pV3hhTG1jcXlPR3NzcTRZ?= =?utf-8?B?ZXlGN0FncFlRWlZERzUwaE95ZmpEWW5jNUN1eG8rV1g0MXNFVm5LemVDNW1t?= =?utf-8?B?R3I5dEZ6N0M0b0tld2haenBvQ3d1TmtGSi9landNeUdzZS9XbldPTjBZbC9n?= =?utf-8?B?VjNDK2FsYVhsY3Jad3E4a1dUTWZCRGFTb0FJUGc3U2plYkdyb0J0YzBFN0xF?= =?utf-8?B?VXUrTVl5dGlyVkJjNkhWak9Oa3dMZEZqczVSazAvTXpCNytXaWNCVFIweXU4?= =?utf-8?B?TlZNSFFvR0FtUVFndlNsVGpkeTNsamNscExtZlpSRUJUVXF3SElQcUVRNERo?= =?utf-8?B?SjNSalh3Si9nVW05Q3YzSGg3dDVMMEJLZ3FtM3JHdFBiaExDWHJONlJUeXlv?= =?utf-8?B?VE10WmQzRnlQeXBKU2VDRXZFNzhhbzExVTlFanl4Mkl1RDExZjRxbkJkNDZL?= =?utf-8?B?MTRscTJ3eGZOeHU4Yk5aVjM3MloyOVB1WnMyTWhKYlphV2F4R3dzTDN1Yk1S?= =?utf-8?B?UkY4SXVpZmNHcXMvanB0cGMrcFBJc3BINGx4WHJROEJFWWUwTUlQVmN6N3d6?= =?utf-8?B?ZHU0SG1jVXZEaTd3T1QzVGx1SGV4M2tJWUhjWDJiQmVkcjFVY1p5a0Q0YnBo?= =?utf-8?B?aUkwZVZ0aVFSZ011K0V3WUVoRGNKS0FZRzJBTjNJTDJaY2lOc3krQmZHSGlX?= =?utf-8?B?SERTTitHSWtUYit4cE9rZjFqSkh2amV4VDB0ZnRjNmYwWGY1UmxkellOZHhD?= =?utf-8?B?eVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LhhrI/jqbfEPskn7w6jPDSHyaa62bJi5V1fE2eDGjY5pjo0ROcK7Hb+BELIAfKfULYDpzl5c7xlB1Kg58yC53lQzXLm2UJR+b/KbHgUpbh+ncmy1FlqWLmvzfPfk5HnCMWL9hlRU5M3/KjOi2yIC42n7D9tevZsjx0hZIPu+4nu7XRuIovkruVnaR/ttJHOuwyiAHc/sok/DoXDNJ+uebS1sGXV8YYRFc36YZCYO/9GvMBRiC5UbukmNaI8dPTFLzQ/SvPS5fh8JSkQ8vWQhycR9+BNrV2x1JahlhpHm7mMgJucmKTLyWgrXlfALc08A1wNjzS8H3B6O3JhEqHLZGWNUiLPBaovCwGYKGQ7CCXhOGgahoSWH19WYO1scKUAv+YaeGGkb76VviCX8Er3RvtfbF/HZz+r7gZAKzJezaW0oQGQsMJ3GLqR73Jb484v/hWjTTuvwI9ZM+b9F75mh2bkFfSUfeKvqUgeNqxo7ItQqP5gOjkhNGAdbBh4L9irFRHmXUslNWqGLg6SyEd7wiIwmDDXC7NN41a8jfj9La1+IvyZw5iyVs+AHbODM2zWBwDw4OmeAkDfieF7HL7kkBhvxuitvOXd8WOA/zujj6B74NR2RihiTns3uPxTP7r/07pK9cpt/rH4/m4vMSoJ3LbSXt9TxVaYDI5tnqXHs7tUuc8i/e2oyh8GEAJzO4qDgXgOEXQVzqAp6KMzHGYpRBywk1xfgXDEZBrYSKK8NzsiL7rp67xmsQQjwaxnt/5rILY9+DO5TXpG2fLbyi9VqZkn3WWBeeTeAi3jzykX+hx0kd3VM9g7CpBQWdTT0TEEC X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1f54af3-d120-4e7e-9e17-08db36826e73 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:36:43.2601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mvy9NxCbeIM0kxk05t6FwnTQmAPzKGA6lxtD7Ar9Aj8ZI1JMk1vsI2TPz7upBmfrT3qdHTZqpHxYx+LL0wH4RhCalN5OXHo1+svlgID/ukk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6746 On 06/04/2023 10:18 am, Roger Pau Monne wrote: > It's a GNU libc specific header which prevents building on musl for > example. Instead open code an equivalent replacement for the usage > of ERROR() and DIFF_FATAL() macros. > > Signed-off-by: Roger Pau Monné > --- > Cc: Konrad Rzeszutek Wilk > Cc: Ross Lagerwall > --- > common.h | 10 ++++++---- > create-diff-object.c | 1 - > lookup.c | 7 +++++-- > prelink.c | 1 - > 4 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/common.h b/common.h > index 9a9da79..ec2ea33 100644 > --- a/common.h > +++ b/common.h > @@ -1,18 +1,20 @@ > #ifndef _COMMON_H_ > #define _COMMON_H_ > > -#include > - > extern char *childobj; > > #define ERROR(format, ...) \ > - error(1, 0, "ERROR: %s: %s: %d: " format, childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__) > +({ \ > + fflush(stdout); \ > + fprintf(stderr, "ERROR: %s: %s: %d: " format "\n", childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ > + exit(1); \ > +}) > > #define DIFF_FATAL(format, ...) \ > ({ \ > fflush(stdout); \ > fprintf(stderr, "ERROR: %s: " format "\n", childobj, ##__VA_ARGS__); \ > - error(2, 0, "unreconcilable difference"); \ > + exit(2); \ > }) Looking at the usage, can't we just use err() instead? Also, I suspect you don't intend to delete the error message in DIFF_FATAL() ? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 09:53:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 09:53:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518802.805678 (Exim 4.92) (envelope-from ) id 1pkMIG-0004NT-N9; Thu, 06 Apr 2023 09:52:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518802.805678; Thu, 06 Apr 2023 09:52:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMIG-0004NM-Jp; Thu, 06 Apr 2023 09:52:36 +0000 Received: by outflank-mailman (input) for mailman id 518802; Thu, 06 Apr 2023 09:52:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMIF-0004NG-Ub for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 09:52:35 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be09b5b3-d460-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 11:52:32 +0200 (CEST) Received: from mail-bn7nam10lp2106.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 05:52:27 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6324.namprd03.prod.outlook.com (2603:10b6:806:1b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Thu, 6 Apr 2023 09:52:25 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 09:52:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be09b5b3-d460-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680774752; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=dpDlh5icSRVarVCK54bUow0cqNLbjUdRZ+A09A0AoZU=; b=evogiJ7wbkdQ6efMCOnaTUFQVV7YHBDA4N3VDTmVteOCEbyrslsGVDfK gLr69bvW8jW5mEJ3FYm0hlHV1RvVhvCJt8l7hqB0+tTEhst9s2ne5G0ev o4yyKYbulrL+k5Q3+6OBdeNVdb6ozNjU5A+Jh0E6vtb3+QQllZN86zYTr 8=; X-IronPort-RemoteIP: 104.47.70.106 X-IronPort-MID: 104949579 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A13gU6uuSGDMQvKzDCQyQQdrYefnVHtfMUV32f8akzHdYApBsoF/q tZmKWDSP/mIYmukeN12a4W1900P7JPVnIQ1GQc/qio2RnwS+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGySFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOnMWQhyNruuPzpmWFeR0puUGLJTsM9ZK0p1g5Wmx4fcOZ7nmGv2Pz/kHmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ouiP60aIS9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqq820QDMlwT/DjUWc3S6jPu+0nWlXuJFI WlJoBRtvJMLoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2hBSQSN9mSfaxloesQW+2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:PE+laqsY6QuPr8Fa8uEVgEDT7skDS9V00zEX/kB9WHVpm62j5q OTdZEgviMc5wxxZJhNo7690cq7Lk80l6QFhLX5VI3KNGOK1FdARLsSj7cKqAeBJ8SRzJ866Y 5QN4R4Fd3sHRxboK/BkXCF+51J+qjizElwv5a480tQ X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104949579" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0hgq3DTqbUwTIZVf4TGGn1CCsbF2o2inFaaliXgsGg/Qt9FB8YDTubMOXkcTbIIi3hHlQRPUtTmvZSA/kP1Yw4fci2sjE9BsDVz+jmExBVgVTQ3xN5Qo7hDZm2NCszd2/H/74rWCmAyjl3Mgxx+5bBRbNAPf3hM8iyCXkX6O2m9ObE4RPjgCuLxBgatsNxNR8pf3LStGsGsICEhL43Voj0GkVlR7qwjV4B3+Z9dkUYBaAhd9oDPqnFMyJOM0SKYQBUgMDhvL72245hr7kCihe96B8XcYQV92k3I+4lnG4w1vxi3zb0wbsnaKipL6tdGPnmqX3sioMy/eNdhauqzyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DryfQqvKLhPUZKX04YcojEKABkspmMe186zBuIMmdKw=; b=aAw0Cc+ACP1iF9TYt8/EeRM80CqVx07H+cewXsgJuIR+nH3cjk+bcnn34zJJm7k9Jw/avcYtQllTdTmTzwp5ynkR53OLbqLCGfWOXMcSPOJzq1F1ELXQwpnLKTwf89hG/KeZIT+22YN60kZpOGxNgcXeKd0HZc50H2fHfcMGiluAPr8g4d8GEJGlUgTEmQehe5IgjhEL0liuSWw4p26LPWBmUktUJn3B+/+PIIdGb/3WoMXN1Z5MrP8dHqSkjWs34MZ+8pvycznqmzJNrU24M7FrIT5Yumi4CXHIiIM6YyB7gG4YDmDs76IjRN4dnyUOhGa/SYPHJuDHLdTNW9qDnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DryfQqvKLhPUZKX04YcojEKABkspmMe186zBuIMmdKw=; b=ZT5lApxF3kZmSdxwV26m7d6Qzv4i9JatLKBewaOT6U82TJzvm8WR21Qe9cYNnRTSZsf13buFhwH8XupUifx+T1Ja0qGDbo1d0J/UMNaYliaBTbBT7aTv26J0DYL/dKhaoHlMd3BCZebs1aWaWL/sI2BPa8+4bdLroN4aX4J44ik= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <24133c6e-3e66-7be9-41af-daa3db4fa961@citrix.com> Date: Thu, 6 Apr 2023 10:52:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230405204423.2113418-1-andrew.cooper3@citrix.com> <313a2a18-020c-ca76-f620-f5694a74efeb@suse.com> In-Reply-To: <313a2a18-020c-ca76-f620-f5694a74efeb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0354.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6324:EE_ X-MS-Office365-Filtering-Correlation-Id: 10c28d9d-431c-4afd-d13d-08db36849fdb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OthXj+pOKt1VjDuRVUYnyZle4NED55VQao1ZA0+jjFEfu1W2hD2O+P3fBh99E3DNakAnOihdwBXPxZnbgocj4ml83Sr53wQnfKUcMKqIB1B7f2Ktc06ptuonE2wCj5+/czdM4DiMv5KgO9ihlVLLEHMl3PvHW/zcobk22qQVKbBEYIAcB5eo3OJvWqqoMWlB3zZIhppoVMp+6yJgnxMPVwJXeAHL0Dw+2Pb40qzXHdJJYiFkrBASobF+f4Cf83cN3hpOSbBPP65zI+ck+EB6XR9OtdC91JcmVGkdXHFoVc34Hc+tJtsj3/xY6odd0U+5vipNFq3RCUsNzftK55PccZAcu++RuE0gxv+ihhBpuyJBtla0w4Zs3NsaGRcAMd+fVjLjVsIwPPiB8rn+89Dx/MuXf0YaS2GbUDTIalMyg/XzouJKUPsjq62y1sldk4b0lDmljJeSsy2+qK7/o71jk1YX2vnf4msQcUts7/a1tZrH/+M78u+ksreu/QIayoTV7VHOumIcfbfvG4hcp2/hqvlI6AE3DZb+3I3msxzfdekuOcbVL9OWdQoXuv6dQzlo146XsQsbJSr05rp8G1B3vveUFQ30fw0DrMkeQmT44oOCMjRNKtL7AU/W+v3PlPXmfzKc6NpmYbZ52AXcLqHB1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199021)(6486002)(6506007)(38100700002)(26005)(6512007)(4326008)(41300700001)(53546011)(6916009)(66946007)(66556008)(66476007)(8676002)(82960400001)(8936002)(2616005)(83380400001)(478600001)(31696002)(186003)(36756003)(5660300002)(2906002)(31686004)(86362001)(6666004)(316002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVJtODBENTd4aVFXNjNsdktuNk1aVzJOUFlKVGxCc3c1QXNtVDdMNGVic2RB?= =?utf-8?B?YVBMNjNaYnRnTXROS3NvaDhaSE5sVVdsM0JoRmMybEIwUU1HczBvc0dnR2VQ?= =?utf-8?B?Snl1OThhT3pubjdFRWZoMzZxbG9sL3E4NVVWK2VISkpHZVJmdTEyMHpFUnkz?= =?utf-8?B?M2NRRGJJOGJTWnJhbTBLOHhVN2VQbGFuQnlyblZFckE3L0J1Q2FNTm9ldWRr?= =?utf-8?B?UVZsL0FzalpJTzdBUGNYLzV3ZzVVUmhGTVpEZ1FlRHgzN2RmcUFnNnQ5U0lj?= =?utf-8?B?NVRnTllBa0JmcDVlRnFoWnYyMG1qdGNtZ1hpd0lEVzYxa1MyVFpPeXQ3R2pk?= =?utf-8?B?ZmRGMC9BaW9lRG1tWUVqUW9KNEtqWjZsT0VWQkRuaVdFcVhHOTRLcTNsN0oy?= =?utf-8?B?ZXlaTGpzTXY1ODVhdURQK015WGNzU0dkTDR1N3FiaUVEWXdwS0ttaFptOUxL?= =?utf-8?B?c2NPVXhoN3hYOXplWDVWYURFdXZ1V3JZTEVpaElORVl1OWdEMjhHSXRJNTIr?= =?utf-8?B?ZDNrendsYkxCNTd4TmZRdjhDcnVEaWx5TzBuVTVUdUs5ZGVhaTJHT2QrZjVL?= =?utf-8?B?cGZKUHVEWmw3bko3aE1wQ09kbDlkTXdwOHhRcE5nTGNkU25TVjJUZ0RJaFVV?= =?utf-8?B?MEdJWWpITE51a1pUTVVRaWNnWUl2U3NWR282djZ1N1JVYU9vYmNBalB4RGMx?= =?utf-8?B?V2lwTGU0NjJ6aWhCaXl2RkhxV3ZzeC9rMjJidDdIQTQ2a2pIL3hGb0UzZ2RO?= =?utf-8?B?d0VBOE90d1B3YnpvaG1SMlRHMjlONVFYL2J4QUtURjgwUDU3eVpFd1JWTnJE?= =?utf-8?B?eDVWMEEwWGdmNUYxdEhzeElSeFA4Z01rOGN6c2J2c1k5bVNkZkhHSWJJd21u?= =?utf-8?B?TUs2aFpyUE1TQ3lnQWtsNGdmL0JxY0ZQNUZiREhaejU3UE5GelY2cnFEVER2?= =?utf-8?B?WU82N1Z4d0RkOHBUYzlvalVoRjNTK2phSjRFMFVpaVNzZFZrM0EyTlhCL2lp?= =?utf-8?B?VUFXSFFNZHZGQlZTNVEyKzBHR2JQUmxHczFtUm9Ma3lxSHlrYVI3UWxMNzgr?= =?utf-8?B?Ym1reTNvL0FVUG04Rnp1U3hWQkpjMGY0YVVtTzB3KzBLQjNja21WdXo3S1pi?= =?utf-8?B?c29QaXdUU2tUWHo1c2hSOTd1QXBpRzY0aTZQVFB4d0hxT1BEZ05NZlV4RlJu?= =?utf-8?B?TlFyTDBHaTBPRFBsb1dVdm8zQ05PUFFyRDFzeEtXWjV6YTVUdkVHLzV6Vk1r?= =?utf-8?B?N2J6Rm1uUHhSaDdpUjlVMXpMbjlGeExnSjdYdDIwcU5zTlN6TVRXQ1hRT1o2?= =?utf-8?B?ODVIb0ZUbFlTSHNNN2pVMm1ZcDhxZFFDTXEzNHRrR29Mams2cVhzTU45d09r?= =?utf-8?B?V3kwQTdVdHQ5Qm5vSURWc3VVSy9tTW83ZEVqN08rL1VTNzVseVhFd0szMTM5?= =?utf-8?B?ZlFkeGV3VVBBeGN0VkRuVW82eWx0VUlYVHBLMU5IY3FOeEdZZFkvMktSRXBZ?= =?utf-8?B?d1kySUVJQ2NqUFlXcllIRTJnK2I3OHVNRU5qUzFMVnFZcmRtRWo4UU5GcnE0?= =?utf-8?B?UExKVWN3TktJb0Y2YThVU1FOSmQxNFFwT2FrdGI0dC9ONUlOR3VzbzNobUVS?= =?utf-8?B?VDJyQnArMzBjU1ZvR2x3TlVoYUNRcUhlRFFJYWNwOEczdml2MGVZL0MrS2dI?= =?utf-8?B?aW03ZXlSbGpyNDdDVG1vK0haS25COG5ORDVjMGlFeC9hZkRra3RwUWNlcExF?= =?utf-8?B?cGUxZHBQVFlhMEhDK0VpU1RBdTFUem1tNzVsbG1PVGVlUnMrdHpzOFBwTlVv?= =?utf-8?B?MzQ5RlZkWGhwalBhbDdvbFBINFo0QTlnWTlNVWlzT29zNXpacGtqNUYyK1I3?= =?utf-8?B?aXY4S3pzbHpQSUhIYm4yRU9CU1liSzlJTyt1Y3M1QXVjcG5oZERaWkg3MzZK?= =?utf-8?B?RkM1WHlOM05Qbk1nUHhwdnJueWRoQVNPRVNGK3RFSXUwdlphWmg5MkMxZDl0?= =?utf-8?B?SmRuZmhqZ1gzUzcxa0NWeXdSZFZ6US9xSUJweHVNRjc4aEFXbjhkbXowN3lp?= =?utf-8?B?UUloVnVJR0NFZkFMVFQzNk9CNUVtVFpQTDM0NzdrclAxdEVxNzNPZHc5Yzhm?= =?utf-8?B?c2F5bnlrNmdtR2QwK2tVK0cyOWk3YmF2dzlVV1JrUW14Y3lSYXhldXFVRUNF?= =?utf-8?B?REE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xoB2nCLB3QYiYYq/Lad3yuxFJbvLGMs3hDn9A7JItNHGbfF37QJrwzkY2zcuiP/4lfvzzN2ahKaM5kU5GZWdmDjvNWYlNALB12ImIC+WH9DTs1DU4lF3MoM3rgPJViyWZtDKk7A+0JoLF5wLcDiOlfAnAaT3Xp8ybTUo5PW9fRKgs55uz1WlOQi2PLWI5N3cGWp+zsny+hugRJt1c4PAxAUcF8E5ZC/sMudIVlEuJul+l47xUau1KtBZ3rDw0Bqyf85Tuh9q9uVaTaB58kyk760QznlkaeibeU2nWXFrIZuaGl8dpZ0gGe3DOjOf549Hj0c/0/17Rgy6wF8BdNwZwK8pw1mWSRM/iRDgZh1GWffvA0ouoWmy6tPbSGFTwEdmyjxIgJt3J6givk31ffIEbgKgftCgUXNE/FYUFtF+riAP9vQa3nPnb+RARmofEBnyVzptZQ+dP1GhRT/lh6mrNSz4TpfCZ39dGUkObriTTmQ6UbEyCf4BsjebN/ZA1f+7jTSzh/8gg6HWlkUrrz4LcGBuKxCTWnFqVrue9eKFH+/r2sUKJdDtB6JN8etshDQ8ivkfX/4dUrJ4eDf9//7p3YLk+3Z+Hue1KUtURy9/j3FZM3nfKUlKYyqjv8wWQLJji7/xFJFbfIeodJ93kTKAOu5snOfq4rl2p8O7DtQ68DWHsh6qzf8WpbYrAXu3sSHJJR9qBwDbEtNN5XkAJ+Nh0hC32gmP8uXuKRGdCUq3k39fadsY0vYVkljjHh8gELlVwocZbChWmLieXnNbP7T8frIAZASXTa9FkSiv43jEeFaBLN7eYKraVOO65mit3ZY6 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10c28d9d-431c-4afd-d13d-08db36849fdb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:52:25.2381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BjvxDHqIuGW3szLS4Yif1KB+nZk4wRF0TVRFdetZKOQ3mwHCgLkUn4L3WxBCsCgVga/DKoeCBHSRst8jjG49tzzLEXihYvLHMF0lwcTZk5c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6324 On 06/04/2023 10:31 am, Jan Beulich wrote: > On 05.04.2023 22:44, Andrew Cooper wrote: >> This removes raw number manipulation, and makes the logic easier to follow. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. > > One remark though: > >> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >> @@ -450,6 +450,11 @@ struct vmcb_struct { >> >> uint64_t nrip; >> } io; >> + struct { >> + uint64_t gpr:4; >> + uint64_t :59; >> + bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ >> + } mov; > The field being named just "mov" makes it apparently applicable to DRn > moves, too (and the title supports this), yet the top bit doesn't have > this meaning there. So perhaps say "MOV-CR" (or alike) in the comment? Hmm - I'd not spotted that distinction. Xen never decodes the exitinfo for a DR access - we just resync dr state, drop the intercept and reenter the guest. Therefore I think it would be better to rename "mov" to "mov_cr" so you can't use the mov_insn field in a context that plausibly looks like a dr access. Thoughts? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 09:59:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 09:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518807.805688 (Exim 4.92) (envelope-from ) id 1pkMOv-00054t-HH; Thu, 06 Apr 2023 09:59:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518807.805688; Thu, 06 Apr 2023 09:59:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMOv-00054m-Eg; Thu, 06 Apr 2023 09:59:29 +0000 Received: by outflank-mailman (input) for mailman id 518807; Thu, 06 Apr 2023 09:59:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMOt-00054c-SQ for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 09:59:27 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20621.outbound.protection.outlook.com [2a01:111:f400:fe12::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b635d1c0-d461-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 11:59:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8890.eurprd04.prod.outlook.com (2603:10a6:20b:409::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 09:59:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 09:59:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b635d1c0-d461-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NsuT9/OJ8GPjepXuRPCmPvTPmbs7xk68/ESIer9nl2tqQjMpJ2daWbDz7z5ODaIG5ZPfT64vwsWTvvkRs04xCAfinUDCfPEMBtDxMgFJYCRFpHEViW81Cng85Dt+kOSBpOAo5oYstxvEN4N+t2YpFj+6w3X0UxkE2Amjhxj0egHVZOPZ6KVgqwmkNTTAVH1sddwa8HecFLctoJRhuxAC8eiq+mb4JExosBEDblu0m3yoxW73UqtP6ce8XzXfCM0WtBBoESGkjUpyQ4t/7PggEiFTso5SOZDhRKLZqOui2mZCIu6VcFM0iWZLMtrl2M/LZX+r8skYlmWd0dyvqWpWYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g5SbSAc4iG86323+6XSRQQY0CLJ/fvoZzH2h7YjVi1I=; b=Z+7PiX+QUjf+kxPWOVWOgdwhN5384o8xHWKu0S2bWCvO2Unf/XdSvdX/cjeHMZ7LR/1SuU91SHzI0XZFRxHBdkfGPCYodr77hUjq94hhWd8/wnA4lTeF9KN3t3UDOj/GGNnByha4pkCH3T6djvPfRmwwBtnQZJln8n2NY8FTEibZ3UKXRtLwxkDYFNzJ0U5jF/hMAUysvzo2qrJYMVTdLkWEuG4I0l9JlQ4Y5+jnwSpCXx87CL+84I32pJ8ASRAnfJdJRw57RU6MW/3EABaCXEKLBtmsUXNB+I5HE8W4335NyYHOPesZEfQVOt8F/5paQ1td9haKqL8m3u2YwPNsuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g5SbSAc4iG86323+6XSRQQY0CLJ/fvoZzH2h7YjVi1I=; b=NYKomSGhPpA4Ayzb9KyC/uyuSHtAwivRZfBH8nRxaJvZ1Hs1NNN3I0gx+iqf3tITqjCEltb6mpXhzNF5Uo5gtaRBckj8COlNPsepD5PN28bnFB8MBjZjJHz5706qTt27+7KgeLEz1WNECh5TNyB5KIRXnHTXbVIN6nYPPPGrvzWBHpY7MGapWSUVrF6GQZWvRTdCz4TOAWtNqXpcfwTqkA6mf0MNWGZGrebJYiZqIy4Oj5KdnoB81BGksKtaqgVsH6oIM/cN8wXMLTIRbsDCf8Tp9Z/MrHMJ/AqZzPLqyEBcsRTLGKq7i7ct4CO+h7mf4ekLjHFS3HbHoHQeMV6nhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 6 Apr 2023 11:59:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230405204423.2113418-1-andrew.cooper3@citrix.com> <313a2a18-020c-ca76-f620-f5694a74efeb@suse.com> <24133c6e-3e66-7be9-41af-daa3db4fa961@citrix.com> From: Jan Beulich In-Reply-To: <24133c6e-3e66-7be9-41af-daa3db4fa961@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8890:EE_ X-MS-Office365-Filtering-Correlation-Id: e4f7aec9-5edb-45d3-e5ca-08db368598fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hOLGS8qHU6Z9giA7qpMTjgFCu5QmjV40t/91Mxh6KzLQXvdiEd2woJ0/FqfTmUXyAWaxAjWOr06PlO7PAn7CjjWxOhovPxeWOkg6O6+/QfuMrjuMmSqkZA80/EgpuLkjMplG/0kCoC/CauPenFPnOs014AAFcWIMuD6+2tKYt6Bo7RfJlFuDFi3WgOaK42jWcayJks0jurt08R5nPduf2ZXQAyxE2PCEuQvZUGUT353jfcuuw1YBFhyyORDL1oP2X3C8gtOrd6S4HjuspzuvD2igj3i1LpiIsV3PUgwAHNMnvekKSwUsjh37fyAZ8lR/p1lEHS5JwnTQA7/yt5JvJWOunafm50K1VjFc1wpX+bAwZ4sFOJgtTDWIkoWxgGOQs22lnKFBXsFIJ60+deYITWgk959kZZK4bvDOlyFXiRWx5nLftaa6EzJ65k4OEwJZmDbbgcp77Sr7yYeyLFAwJ1T/t8ARJ1R53UvtwU+w8Y1LDL9kVQW470D5fXeMciK4FC+bfPyp8wmeskgZerd3iXTIgru3OxwCdKH2Tv26pwHVBeGWg8QIkbfstJA5N47W+B43NL3WZYHSUMoPqWVOGeiURKB+JAOi2Ib5WlKuC/656DL5tVU1OESyeUExvDn8j3xNA7shelKcMppANCxYDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199021)(31686004)(4326008)(36756003)(38100700002)(2906002)(5660300002)(31696002)(8936002)(66476007)(66946007)(6916009)(86362001)(66556008)(8676002)(41300700001)(6486002)(83380400001)(2616005)(6512007)(186003)(53546011)(26005)(6506007)(54906003)(478600001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2pTK1RVSFNpcXlCWkF6UWZXazNZdVNUaGJyeTFCQkhWNElEQndtWjVMWE1H?= =?utf-8?B?c3ZKWEYwRXltTm5VeTI2YmJyQjhHWFM1S0pzNkZQTXhXZExBQ01XU0Vmc0wv?= =?utf-8?B?UTNFRGpuUkRvRHhmeEYxcExFTW81aVFpbHR4SU1ScUZmN3Z0OUtxRDRsdVFJ?= =?utf-8?B?VjdLNDczRTZSeFg3aDZjRzNCWVd4S0t3SXFWMXVISnhDVUVaSkE0b1o0SS91?= =?utf-8?B?a293UkxmYjM2dXpER3NJcFgyWVMxMWI2TS9GbXIzaGd3RUFSVVJtOTl0ejZr?= =?utf-8?B?MldNNzZVZTJTMkUybWNTRDNJcDhic21aeXVvblo1Z00xN1pkZTR4RVdKbDhX?= =?utf-8?B?SkVOZXZvTy9ERmgvRkhoQjRGQ2FEdWZ6T2JuQUxDaEwwWFA3TlhLQnhvaWJW?= =?utf-8?B?elR1ZHhQaHViTFBkUDdDU1VLNHBSZmluSkZhcWdWL05YbXFhaGg4U0Ewbmtq?= =?utf-8?B?Qm0ydVE1eXdtSEF2NWswTklwKzA1dXFxakhJanEydFJzQ0VlMGsxMGNWRFQy?= =?utf-8?B?YnJqNndNdS80enZqMUVxWFNrankvZGRkdXFlRWk0NndFTy9XT0tkbE9lSmNH?= =?utf-8?B?QVBYcW0xZ25VVDJ6VU5HY0t0b1BIbDJKNjBvNmxKVUNVRi94OVdBemJSNjVi?= =?utf-8?B?UDNQSXJEL0tiQUZtQnAzOUsxbzBIMkxxSGMxR0daRjlGN1djUVpWYjJ5MzJT?= =?utf-8?B?ZUxCWDVzdVBZdmhFNHVpOXVza3lHU0tmREdPWDlqVWtkNEdBMFcybGJ2KzJq?= =?utf-8?B?b2NidWl2Vkw3aVhtY1Y5TFdaY2NCNGtCa3RsQWRqYko0eWZBQzdYUEsvcTll?= =?utf-8?B?R0lwbjdveEExZjZyNFo0Z3NmbVROemp2YUtUbXpPb2gzRzFkdnpvUHhpRmI0?= =?utf-8?B?Y1FLb1IvbkorVkhnQXZ4OGQ3QnRJU3FmeG1lcXdIOUxtQjYvNXp0S2J4ZEc2?= =?utf-8?B?cGZxWkcrbytMdHBGbDQvTWtLOFcrV0Q5dVQzUXltQWlPZm03Z1huekx0VWps?= =?utf-8?B?Y2hyNW1MV1h0QVNkNVFIZGsxOUljNTJESU1KM2ZZeXAxcFpsMFRBT0hxd1J0?= =?utf-8?B?WEcraVRIc2thM3owS3Q5MVlicUV5dmZNUy9KWTdPUlJVWThGQkpEdXAvcmEy?= =?utf-8?B?RDJFdnU1QlpwclR4azAwVzdIZmF5aFlPRjUyKzNrT3RGbklVZFMyUmc2YTdj?= =?utf-8?B?cUtsNHhOU1dvWkp6ZFo4VWZLTytvZWQxeDQvVmJDVmV6SThNOTU4UjJzcnFV?= =?utf-8?B?bTZRSnB1T3FpcU5xOG9iWDE5UCtteDZ0V2NCSjEwaFZZY3dlYWdobkptWnpi?= =?utf-8?B?eXVoSER5N1BQL05ITWZsR0Y2Szdra21TU25TdTlaMU5aazdicWp6bGdibmFO?= =?utf-8?B?bFF0Q3EvYWV6d1ZnYmI4VUZxRXoxMUdsdmJoSEdrQmVITzkvWWdtVHgyVjRI?= =?utf-8?B?SEhJRElPOEJCNlBpTHJOdXIyeCs2dVNmMXVjdVR4SS9oc3FqZEJVcXUrcjkx?= =?utf-8?B?NVA0SHQwc3lPQnMyNnNIcURhbEk1NzF1cFpvTTJEMVhvWGM4NFk3bDhFOHlC?= =?utf-8?B?MmhqNWlwamhSOHBESWd2dGl6WjNDV0d4SHFwa3VzaTZTSExRcUg5RVVJOE1v?= =?utf-8?B?WGpEK0VQbk56bjA0YzhUanlTVFhJbUE0dHZPeVdZUlJNZ2hNZ0hZU1RoMStk?= =?utf-8?B?NndpeWtSMEpPTmgvbEtUMTV4b0l4djc1WHJJZUFlM251SkgwbExNSFFBMnNt?= =?utf-8?B?aHlLYUxEd3ROaXVxenNiaWtzL1lmRE5WS1dLV1V6dFdvR0pLeXk3NmpmamJu?= =?utf-8?B?NW9yWExyY1VqSlQwOXppcllkdUFQV1pETHY5NXpIY21RYjlOUXoyVWR6czl6?= =?utf-8?B?bGtxeEFIclowaTIrbE9TYlIrZ0VLSmh4b0swc0wyeVRIekplbFk5ZXNPQTdK?= =?utf-8?B?ZzEwaW1CR0ZHaTU1OEZQNEpyZFVTR0NQZFVaK013SVdmcktlQk13d00zb3BR?= =?utf-8?B?M0tSY2d1c1lweC84MVloc1NTYXZCUTBJMHE2S0pYcEZ0d3dpQWhhWndWVnlT?= =?utf-8?B?T1VkSWFscG9WK0t0UU5MWXpNelgvdGhVOURkRGVBbFJyVGVFNmdtRWExUitP?= =?utf-8?Q?sWuYeRy2BD/nR/oEk5EjinpgX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4f7aec9-5edb-45d3-e5ca-08db368598fa X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:59:23.0005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2E2aTZy9ZUWeMG/mW12zpYyEJT4jAfAAwEiUuv1eYt+m1Uqelzz1jVe9is1K15+vbkDQHQqgz2fjTGt0+pI1GQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8890 On 06.04.2023 11:52, Andrew Cooper wrote: > On 06/04/2023 10:31 am, Jan Beulich wrote: >> On 05.04.2023 22:44, Andrew Cooper wrote: >>> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>> @@ -450,6 +450,11 @@ struct vmcb_struct { >>> >>> uint64_t nrip; >>> } io; >>> + struct { >>> + uint64_t gpr:4; >>> + uint64_t :59; >>> + bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ >>> + } mov; >> The field being named just "mov" makes it apparently applicable to DRn >> moves, too (and the title supports this), yet the top bit doesn't have >> this meaning there. So perhaps say "MOV-CR" (or alike) in the comment? > > Hmm - I'd not spotted that distinction. > > Xen never decodes the exitinfo for a DR access - we just resync dr > state, drop the intercept and reenter the guest. > > Therefore I think it would be better to rename "mov" to "mov_cr" so you > can't use the mov_insn field in a context that plausibly looks like a dr > access. > > Thoughts? That was my other thought; it merely seemed to me that updating the comment would allow future (if ever) use with MOV-DR. So yes, if you prefer going that route: Fine with me. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 10:31:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 10:31:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518811.805698 (Exim 4.92) (envelope-from ) id 1pkMtz-00011X-2F; Thu, 06 Apr 2023 10:31:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518811.805698; Thu, 06 Apr 2023 10:31:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMty-00011Q-VR; Thu, 06 Apr 2023 10:31:34 +0000 Received: by outflank-mailman (input) for mailman id 518811; Thu, 06 Apr 2023 10:31:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMtv-00011K-KL for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 10:31:33 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2eca9e7b-d466-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 12:31:28 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 03:31:23 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2023 03:31:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pkMtX-00DJOA-0t; Thu, 06 Apr 2023 13:31:07 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2eca9e7b-d466-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680777088; x=1712313088; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3ceVcmjc6Ptm9PzaLBlyJdk3QXqcq40nfjFwb4WczVs=; b=XPv9RYSEoAesxqju4O68ghh3S3S58xwk8Zh0KHafHRFDrQ4S799NN2fa tXTdOrzvey0chQpNAXBZLNCHGUWTq9Dl7jJCEwZGpLbZMoXy/HFGBmSKS MdYca52S3+0UwEO2TXkCCicsyTk6APuUt6WtcC8/yK3P7Gn/8h47KtYTl PBrB3CQJWvxzf7ECP6K9OhkH+7FQgOYQJmkW4h9MgBKuqDLzNpJZdxivx zRnCS8Vg4svbmVD/irflttaBnDAKw/HlKL+es58oDscqy933hnlWeTT79 H3DcaV4M5SRhJpGY+qJRwp1/Bu2g3MIofRI+NFkt2ZWPwNxnbRsfTGxk0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="341435044" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="341435044" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="719666156" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="719666156" Date: Thu, 6 Apr 2023 13:31:07 +0300 From: Andy Shevchenko To: Bjorn Helgaas Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users Message-ID: References: <20230405201832.GA3638070@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405201832.GA3638070@bhelgaas> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 05, 2023 at 03:18:32PM -0500, Bjorn Helgaas wrote: > On Wed, Apr 05, 2023 at 11:28:27AM +0300, Andy Shevchenko wrote: > > On Tue, Apr 04, 2023 at 11:11:01AM -0500, Bjorn Helgaas wrote: > > > On Thu, Mar 30, 2023 at 07:24:27PM +0300, Andy Shevchenko wrote: ... > > > I omitted > > > > > > [1/7] kernel.h: Split out COUNT_ARGS() and CONCATENATE()" > > > > > > only because it's not essential to this series and has only a trivial > > > one-line impact on include/linux/pci.h. > > > > I'm not sure I understood what exactly "essentiality" means to you, but > > I included that because it makes the split which can be used later by > > others and not including kernel.h in the header is the objective I want > > to achieve. Without this patch the achievement is going to be deferred. > > Yet, this, as you have noticed, allows to compile and use the macros in > > the rest of the patches. > > I haven't followed the kernel.h splitting, and I try to avoid > incidental changes outside of the files I maintain, so I just wanted > to keep this series purely PCI and avoid any possible objections to a > new include file or discussion about how it should be done. Okay, fair enough :-) Thank you for elaboration, I will send the new version of patch 7 separately. -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Apr 06 10:34:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 10:34:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518815.805709 (Exim 4.92) (envelope-from ) id 1pkMwy-0001Zf-Jv; Thu, 06 Apr 2023 10:34:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518815.805709; Thu, 06 Apr 2023 10:34:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMwy-0001ZY-EB; Thu, 06 Apr 2023 10:34:40 +0000 Received: by outflank-mailman (input) for mailman id 518815; Thu, 06 Apr 2023 10:34:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMwx-0001ZN-HJ; Thu, 06 Apr 2023 10:34:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMwx-0007FK-DV; Thu, 06 Apr 2023 10:34:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkMwx-0003Qy-00; Thu, 06 Apr 2023 10:34:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkMww-0007Tz-Vm; Thu, 06 Apr 2023 10:34:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B2mENXBHBfZcHVvc4Pu1jqgSR0+uiWBGOkqDxS3HZvE=; b=59p0mfYzDYcllL3p4VeiLIjiP7 h3ldrAyscs00RD6FImwYVD9i2HZLgdrD6hSnIQOGPemXol+9ntuOVEsFUlwLd4gJmmKXsEUO1qOaw Ahy/49N1vEOYyysEYsRvFAHm+P6t9sR9T+tukpQo/tNCQKHjgJ9ZkUCa/evdzD62So5Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180153: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=b5fba99ec7969054ab2f3727d2df014b5b72e4f1 X-Osstest-Versions-That: qemuu=7d0334e49111787ae19fbc8d29ff6e7347f0605e From: osstest service owner Date: Thu, 06 Apr 2023 10:34:38 +0000 flight 180153 qemu-mainline real [real] flight 180167 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180153/ http://logs.test-lab.xenproject.org/osstest/logs/180167/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 180167-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 180146 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180146 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180146 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180146 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180146 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu b5fba99ec7969054ab2f3727d2df014b5b72e4f1 baseline version: qemuu 7d0334e49111787ae19fbc8d29ff6e7347f0605e Last test of basis 180146 2023-04-05 03:09:37 Z 1 days Testing same since 180153 2023-04-05 12:38:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Paolo Bonzini Peter Maydell Peter Xu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7d0334e491..b5fba99ec7 b5fba99ec7969054ab2f3727d2df014b5b72e4f1 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Apr 06 10:38:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 10:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518822.805717 (Exim 4.92) (envelope-from ) id 1pkN0x-0002Nn-5q; Thu, 06 Apr 2023 10:38:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518822.805717; Thu, 06 Apr 2023 10:38:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkN0x-0002Ng-2X; Thu, 06 Apr 2023 10:38:47 +0000 Received: by outflank-mailman (input) for mailman id 518822; Thu, 06 Apr 2023 10:38:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkN0v-0002Na-QM for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 10:38:45 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32f213f8-d467-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 12:38:43 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SN7PR12MB7369.namprd12.prod.outlook.com (2603:10b6:806:298::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.23; Thu, 6 Apr 2023 10:38:39 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::659f:af8f:6d3e:8242]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::659f:af8f:6d3e:8242%4]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 10:38:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32f213f8-d467-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ck/VP7+dRStZS8MyRj85qyc5ntU7HrUhkMjLWeSLsVvjRy8spyopnKIJzdudnmpYCK8v2xisC95TvVzjdNbWWxHzVZc2dT3KP15FdmPBHkSnqZtVEp/cfjNXYVTxaeaUTr7c4vaQ3xhGYm7sCjhkmh5B4MVln2ab+mmIrUTE+a0xMTpwQYOJHjMXNw+NYZIsKXPuwQRg4GxwviG2dEiDxuIiILn6kijCGdsEL3bB1vPhqVd2BB+3s1MgknqcJjpOMS4PftvuZJAcFGHUcj02amXqSUhe60QV8CAgfz56G3c0ol8sk47jpSRhGEvu2V8QyBAcOiN2jWSx3PDB2nR0sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LWk4Hi1mF1FVJiebOCrXEQgZdKxWG/iAYVMdyPMXGEw=; b=N8CSQWbxBtrxUGLZRwDlbonfxKxV//WIZlPHbGH27KVWvLDL0QGz2EQQBlE+kxJkci+im1N8K4mxsGc2OS7OAZaVBTAKfi7/q7E1sDtFzdbX74G6osW2E9Bm9H0r1FGNbbyxPCOC0njFV0sIeHDHUmbSuwopHd4Ai8xDs22aQj0LzrldyDeyol5oCjqXen0XSFp0lPcufqTD4pEkw4ov48pdnwbX582Zc7+MA6kRdXd6VZNMp+mLjsdM6uCVdswVPwdQtvlEpnpEE+rmTno+jjP2hmqNyzRjMrosnd2e1XeqaPSq7mVyi3o1LyC38K8m/va+f3LMZseTMwwsA8bk4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LWk4Hi1mF1FVJiebOCrXEQgZdKxWG/iAYVMdyPMXGEw=; b=adywm6TV6IZYJ9WuZ456p9i70XkZT4KlGLF5NHc1DkjBJvQ1e0QBFRUHx8XSzVPTlaWrlH14njKHpS5fZyTGqUowL1oNa8qm28rTjcBHP1A06esKD4WrKmhMEVqdjUF1LqzBOdC7ut3rL+KlDoONAWTkV0XoBaSaLlyFzMWX2hc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <7dc2a51a-f1bd-6370-6b42-0bcf1adad619@amd.com> Date: Thu, 6 Apr 2023 11:38:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-2-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20230405111750.12491-2-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0139.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::14) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SN7PR12MB7369:EE_ X-MS-Office365-Filtering-Correlation-Id: 91dd2ef6-1c2a-4cb8-4c11-08db368b158d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cmccy00UDRbYGrcMOtcO1l0CkJmtyHIEdGCU5UJVNvJz6R6qoY+GRmtu6wZp1hvw4omb5g5gn9CCMk+lmtBBj081vvqxZK+A2yELKcB/pbKqSz6gNf1fNcevbGxHpR5OcbqGtQ45tcO3zh2GgrffcGJIrhpEhpycDUbMYZeaeRApe7mkjdOj90oBtqfAzx4pPAP82DB/lUkN4gtj/aURz8H25mOKoTYSo29rzTj2NFkub+Uq4aMeZAFuQQkRbwr4aFzZCvX1cjmDz+kjRhRRuraaJchIPvAsiQ5/m8yAt/IpjQZZZz/GWhqfZ3HbUqDKQBp5joyhjiRGy115UlqzGuA9v5x73TkUZyGleklGwIsC53eFvQDn7d/b6hWoJ6kg8REUNK29djlXeNo3p+u5+0xc6D+dslK2R31RInQqmm3cC7ENOq9RnoMfC5JyFVlWqSm1CYFGKR16Dm6uXMbbMtxY/LeBvHox1rTeL2SYnXpebyTjx9ccpBy55oyNMWGZnRdhU6j1jMLjah8/mp3rOzbwUeXhZJvjL8KI0uyfHRAUQ/rZWlMAmD2/6gAtrcRE1g/w8z7ihmCdquUZAtqUHG2r/8tU6DmeI1M9VHzteQvcQmp653qEmOUc0uCtuU/vmhgOV6GEdjFsqgdGBoyHwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(451199021)(53546011)(6506007)(6666004)(6512007)(186003)(66556008)(4326008)(316002)(83380400001)(26005)(54906003)(2906002)(8676002)(6486002)(36756003)(478600001)(38100700002)(66946007)(2616005)(66476007)(5660300002)(31696002)(41300700001)(8936002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmx0d1RBdzIyRE53Wk9HNUhjRU5UNVZkVVdvTmdJT25GejM4UGZuS1hIQ0Q1?= =?utf-8?B?djJiL2xURm54WC9nMGJQS0FudW5CeXZhNk9YRk95VDdtdTVMMjl5Z1JPQ2Zs?= =?utf-8?B?Sm5saWFFSTBVNmlUSTN3WE1hODEreEVxYkt1d1l1cVpqNEkzQkt4ckJ1bENE?= =?utf-8?B?QVM0aWlYdXA3TU0vTlRvYWpNZUZxYWhSUWN0SkhtNTJxcmo5dzBYWXFjZGZV?= =?utf-8?B?MnNGYXNZazBPblBtNzQ2UFY0WW5hZVN0Y1JqTkFpVWNvQXN3OEhnYWpTRHhL?= =?utf-8?B?OVdQanVnVGdsS3pjbVQrRVpveVNOUy9BMW8vamtJNjNmTy9MQzdIdDJ5aCsx?= =?utf-8?B?c2Y2ejFOU01XTU9od1UxczVDVkluZlNURjJjc3JFeE9rZTlXOHVkbCtjU3VQ?= =?utf-8?B?aGFmZU52TGxyNnZHbnRXbzdscWNvL0xKVVUyaDh5Tk50RHZjZ3lmcWVGWGNG?= =?utf-8?B?YTdCSGlXUXA3c0ZPV3RYYUQ3OEN3OE5WVWYvZVRLUTBwUStTa2NlZWgvcndS?= =?utf-8?B?V1duZmxTU3U5YURLamlKK0RtT0d2clc3M3JJNWFxd0d3L2d4aDFIbVNodksz?= =?utf-8?B?TVE3UzdIRWR1clJaMnZlUG1vN3N4bWdzclJrSkd1SFU3N2RzL0FhMEk3MDEw?= =?utf-8?B?dGVrOG16a1hTTHpNVjhKRFFUcGJvQk1hU1cybi9UWWFjbnBid05nZ0U0WFNt?= =?utf-8?B?eEQyNkhINnlYVEJKWk9sbXpseDdSMVE3TUw5WFA5SDk1UFNmb0pJQ21rcVc5?= =?utf-8?B?N2xOdDBzMTBqcUozOE52ZXV2OG5CYnJQZ3R5RTNkNUhybzUyMFVQUnRDUjJC?= =?utf-8?B?U0dMTURaaWlxa3VQd1VTWGlsbFJJZy91RFhLU2ZSakpqTDBEZTQ3MXd6ek5O?= =?utf-8?B?bHBMcGZrNElmc3RGTENkNDJ1TitmVGxSc1QvbUR4OW83YkhkM3RJd0pUa2po?= =?utf-8?B?eEVRcEI3NDlvSGc0bHNjd1BKL1gyUmtTRTlTTG9KaGdNZ0xzN1pSeWZsQ2o2?= =?utf-8?B?cEJxc0s1M2hoRFk1NVl3VVR0TG8zOFYrMGlhS3ZiVyt4MWlaVE1KS0tQcVNT?= =?utf-8?B?cFl3UXJPOEZlUExqeWpsVVhJY0VBWDFXK2Q1SkVydGpvZGgycTlhU1JUdFhn?= =?utf-8?B?eng1RW9Ib2NmL2pCZXJXaXF4ay9LMSthVU8wY1ZHcTdqem9WY3l1SjBCVEJI?= =?utf-8?B?bjRzaHM4dkFpRTE2azJaUGl1bTNFMUIzYng4azJEMWx6dXR3Vk51VlQzWmhX?= =?utf-8?B?QU9JdTdVS1h3b29sMGdmc0lpbndNanZLUFVZc1NzaXdJMzdab3k4LzVab21l?= =?utf-8?B?dnRJRXp3bXBMV0h1ZE5oRjkxcFZiYUViZmhqMUZKSm9reGtERWhlNm9oZHhi?= =?utf-8?B?ZHpDMGlhSEh1ZjdPRjIramE5V3BTZDBmYXlTU2pCRmx0cWFZZCs1V25yK1lD?= =?utf-8?B?NXBYaFpsREZvdCt0VjEwUlN2MDJ0S096WnRSa21Jb3JSdDVvT2lFcUFoUWhB?= =?utf-8?B?ajM2cHBIZzNxZFA3a0syd2puQUVVU05tMDRvYXMxcmxFb24yWUlBQWMxbHR3?= =?utf-8?B?WmV4OTZ0K25LU1o1cjF1dXRhZTh5THFnMDVYN1ltZ3lvTHJ0Zk9xMGZ1aEln?= =?utf-8?B?WE9yMFRLSVlsMGRra29OQ29kK0ludEpUL25jbGY4cWZ0Sm1OSUwwOURxOU5y?= =?utf-8?B?ZnJNQUgxaTZjNFlQMmRSaG82UFArRjR4TmZHUEtEVnhpcmpjSk9xMlRranZY?= =?utf-8?B?Z3JVUVZTUHFVQ1cra2prRzhaUGx5bnRSUlR0Y0p3L0h5NmFCL2F0WDdsYWZG?= =?utf-8?B?U055R09qd01vS3dNYVFFNnM2Mk12dGRVc1JaOVBEVXhPeHZ1SGpWQmFkSHRm?= =?utf-8?B?NFhuMUxNbUJZZUFnQ3JwVGdiTTBSS25HUm1GUUxwdTlURUl1RzZuSTVtRCtT?= =?utf-8?B?ZzdIWG5nclhxcGJCZ1dwQ0ZCQ0tVcStoMFZSdGtjNXkwQ2dEbWdHajRDMnhI?= =?utf-8?B?UEI5WkdpblJtOEpQbEIwQ1gydittYytDSTNuMjRrMXZoKytJV2hvaHh3TkNk?= =?utf-8?B?TCtlQ2tCQ3ZpZEFXemxqV2NodXZqMnRCRUZNWEFVSlhRaXptQUE3N2l0d1hW?= =?utf-8?Q?5JEcC0ml3Np+eL/ElogBAamLf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91dd2ef6-1c2a-4cb8-4c11-08db368b158d X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 10:38:39.5147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k9eMoZak6cnD1XgZC1ZkWHY/Utova0ZYqWhGJocqykjw+yIXfR/DOzac8gON58H+TQFUO0heL43VSp4iuTqscw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7369 On 05/04/2023 12:17, Michal Orzel wrote: > In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment > stating that the guest is expected to read the DR register only if the > TXFE bit of FR register is not set. This is obviously logically wrong and > it should be RXFE (i.e. RX FIFO empty bit set -> nothing to read). NIT:- I will prefer if the PL011 TRM is mentioned with the relevant section. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder > --- > xen/arch/arm/vpl011.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 2fa80bc15ac4..0186d8a31834 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -143,8 +143,8 @@ static uint8_t vpl011_read_data_xen(struct domain *d) > /* > * It is expected that there will be data in the ring buffer when this > * function is called since the guest is expected to read the data register > - * only if the TXFE flag is not set. > - * If the guest still does read when TXFE bit is set then 0 will be returned. > + * only if the RXFE flag is not set. > + * If the guest still does read when RXFE bit is set then 0 will be returned. > */ > if ( xencons_queued(in_prod, in_cons, sizeof(intf->in)) > 0 ) > { > @@ -202,8 +202,8 @@ static uint8_t vpl011_read_data(struct domain *d) > /* > * It is expected that there will be data in the ring buffer when this > * function is called since the guest is expected to read the data register > - * only if the TXFE flag is not set. > - * If the guest still does read when TXFE bit is set then 0 will be returned. > + * only if the RXFE flag is not set. > + * If the guest still does read when RXFE bit is set then 0 will be returned. > */ > if ( xencons_queued(in_prod, in_cons, sizeof(intf->in)) > 0 ) > { From xen-devel-bounces@lists.xenproject.org Thu Apr 06 10:54:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 10:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518826.805728 (Exim 4.92) (envelope-from ) id 1pkNG7-0004m5-HZ; Thu, 06 Apr 2023 10:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518826.805728; Thu, 06 Apr 2023 10:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNG7-0004ly-Eg; Thu, 06 Apr 2023 10:54:27 +0000 Received: by outflank-mailman (input) for mailman id 518826; Thu, 06 Apr 2023 10:54:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNG5-0004lZ-Eu for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 10:54:25 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6290d447-d469-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 12:54:22 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 06:54:19 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6530.namprd03.prod.outlook.com (2603:10b6:806:1c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Thu, 6 Apr 2023 10:54:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Thu, 6 Apr 2023 10:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6290d447-d469-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680778462; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=n0HOUBqDK03BjZGCqepxi1ytGZNaJm+Aysk+6zq3pl4=; b=P6iNJTYzTbsVP8NYMp9yd6Zu6LfctSAtPQjvo5xczKR8txJ02P9kuiSf J6JZ46q475vUv4lPxg3QMWCfE700yXznOw5pXhsfbdpnqdBSLycZSR+T4 KFD3GjwxdqdYLWpWJc3g6j7J3lWeJ3LmhhU0mhZUUufP04tyIsaGWMwig c=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 104575953 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/tfCuapO27wDsfOlmQ95dtii73BeBmIBZBIvgKrLsJaIsI4StFCzt garIBnTM/uMY2D0c9hxadjjoRsCvcPRyodrSQE4/ik8HilBopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzydNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG0DXBS7hLmX+oiqE8JhtOM4LZC1YIxK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSFEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdpOSeLlp6Mx6LGV7kwMUQUqdHu+m+CgyRW/acldC hJP/zV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc1Qjow3 1PPgNLtBhRoqrSeTX/b/bCRxQ5eIgAQJG4GICUCHQ0M5oC6pJlp10yfCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:xJ9JzapBcIjOKmXmsKZA85oaV5oCeYIsimQD101hICG9JPbo7/ xG+85rsSMc6QxhPU3J+7i7UpVoJEmwyXcb2+Us1NuZMzUO21HYTr2Kj7GD/9S6IVyGygc178 4JGJSWbuefMbEQt7eY3ODXKbcdKHbsytHSuQ9zpU0dKj2DystbnmFENjo= X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104575953" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nMzOjBpvtoyIEGeguEMooEmr//5NpK3Fr4JcucJ6gUDN3xVfVVntM2UkpXPqW/hWtKvws88vpYWEI5Cau/LbsqAHBzSxoS4HKrNPIxAXG6N5qRs1nVWHl8KsYrilkef+4jq921ZwEWf8Equlc4XqMJanVPEqA/e4JaYOxvz9H1u9viE31sTcaUp8aUiwAubHoiBsP0doNQI0n9kmJUIh74Zo5OOv/yRZParxVMu5xv0s4S1+AM+DdvWMSAaBUgXE0n8vbAlRYtARhf3waGlOTpbDeZRqg3wLl/lBV5tlklRXQUan+HfFQ0PJ0LkPIOdplXFPYuBCDIFB+EBsZgavBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EyMfEoLHM3v5KuwRZuXhJRCyB5szuGQEJtrTdAsqC3U=; b=KQaTi60ZmaEH28TooI+J0pzkXFgw7i/SxrqQ0ACRxpVWlf8YPyYDmc/f6+NLtB5EWZVptzAZvStb21jGlLXIaCDHVpbKEmc6smK79Wdu2NabxGSLIPuuFW80ORduR7DDt1XNdz9IB72pereHlE3p1G0xTWZ4BODhf8or4UG7LgKNxMoNWnaVA/MvSsl0u5Elp1G5iiQbOgZLvvp/0ihAcwoSczB4sRqy9ZtLGUeCusZEQITjb4V+/8vplKDJcbww5WNm/pO4JHI2b1I2GpC2LKJIK5KdQVpOCLe6ZomG8/O5FgUKm14w9Zkca8PnrWhcHZsAp2BOoIqFSm0+bavGxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EyMfEoLHM3v5KuwRZuXhJRCyB5szuGQEJtrTdAsqC3U=; b=iYgYwePhRgcO2OHymBU+JzIBB8lrYeQTsUphjVswsAOIAlsMhFOEdpVvm2mEgE7MgQfEFOIM5Z9vMtU+puSheCUmiZHt7B1luMHu3o50NsMiRV0KfXbdANm9CJZbXkj6kpAVFTFa02t5hr76msG4fGceiyj+jC9KCZAEyx+r5BI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 6 Apr 2023 12:54:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH] livepatch-tools: remove usage of error.h Message-ID: References: <20230406091807.49028-1-roger.pau@citrix.com> <4525547c-e309-c994-3dc7-5d1b398aabe1@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4525547c-e309-c994-3dc7-5d1b398aabe1@citrix.com> X-ClientProxiedBy: BN9PR03CA0972.namprd03.prod.outlook.com (2603:10b6:408:109::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6530:EE_ X-MS-Office365-Filtering-Correlation-Id: 84be8364-0641-432d-7f17-08db368d42a5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uypdFIJuvCrUsSgTSZ6hd6E7ZM9+1myKDvLfju0AVOt6arscxnMFBo1cQBS28vWQFqBvtRh5XYLK8y/rAJruY5mYLrWFDA8tUQ4VLfZyN/xQOERZZ1Z+YBdMbLjb7+ZA6Bfkp3ZmJ8WK2CiDRYXkkhoJKHPEvqUtnk/DbEEmLD9vgGV0u9FU7rJ6rkbWhJxbTTz/tLuRcseHW0LXIBMpuAZNuQpzVcMZy8EB7EXnwthbrl/GgUsk/OzpASUvX4V2xRFtbzTuwzG+lYRvZEpdxVXN9DdRaghr4FJ4tsuAjQIN2Ag1X8a0xC/i1jasM0RtFE42WgXSvgb4P+MEqmHhxn99kx2c7uEwjX0Ks3TwQPqrEUXUkCwz5KWg3+ghw6WcC7HN2/924OGay4erAcueHndpgylzY10wrDJ4M7nP0TeRvRIeMOmaHdpCBjXfleOxeMRqK5/Z37iWVoEe9E+9AuPZlIlOnRMw0qgX7X504Ur1csrbJBe0oJ5E1hlKWAtWBtsVmlVuWjxsnCDmRAfpY+Hu36nE70ilXVnUlzHsc5SJMfMaPzctAU0GDVxkleHw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(451199021)(186003)(5660300002)(85182001)(38100700002)(66946007)(8676002)(8936002)(66476007)(66556008)(82960400001)(6862004)(41300700001)(86362001)(4326008)(33716001)(83380400001)(53546011)(107886003)(2906002)(9686003)(54906003)(6512007)(6636002)(6506007)(6486002)(6666004)(26005)(478600001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE1xZ3h5L3pOVDV3R3FoTGpab3p4YWNXUDRvTDhqR0U3NzJJb1FVMWhnRXNO?= =?utf-8?B?NVJDNHJ0QUJMOVlPdnVlT1IyZHNQdDlDdUFFT1FJZkc0b21lajBSYUdJU1Zn?= =?utf-8?B?VnlDdzZseW4yMTBYOEFZODVMMWdRdVIxcWdoZDhsOFFDdHVGRG9ONnVHOG5C?= =?utf-8?B?NGNWdVBlamhjRXFLeEJFRXZLV3hiSFhKZTVZZjErcDBEbUVmTzNqeE9WcE9X?= =?utf-8?B?MEExUWVUT3JBTDBvSXV5MDMwUHg4dEhLV2Yza0ZaWkNPbS83MzVmY2FoMjZv?= =?utf-8?B?cTEva0lkOHNmZlNNMkpnektlaHQ0QjNGYk5BT3h2dVFzdjdDeWVLcjhMZlNC?= =?utf-8?B?Q2x1dXE3cDlWTTNESGxSUkRzNDNHY0NIY2NOaGJYYU9OMWFHM3c4YWFmeW0w?= =?utf-8?B?UDhwbG12Q29FdXJlMlQrN1JQQVl1SXpHM2l5K1k1WWVpbHVxNVhYOC94NS92?= =?utf-8?B?V1BwM1pNQVFuTVZjR1pyTFRWQkRZc2xubGxOVUl5N1ZEdEc0K3RuSGxjTThx?= =?utf-8?B?Tnk3RFpHdEE0WHlsMTkwekhQZTFMVkE2amtFK0tzRnNWbXprcXBzeEs5VXBq?= =?utf-8?B?WC9ZU0lQME5obmNOckJZTGdFMTZ3c2JZSWMwTk9oOTMzVUZzcFFUajVvUDZa?= =?utf-8?B?SlJ4ZDZoWUdkaUR2dGVXdTlEcFBsNUdlL1ZLai9abVc4SEJRajJiZHMvWnZp?= =?utf-8?B?alVDMVNPZEcwTHE2SHB6dG0vRVZCZzRRM2lHdFNFM1BwZStrR1QrNGMxeWV4?= =?utf-8?B?Q0hBNEMwcis4ODFlSXVZQmg4aUkyUzhFUU0zVUExQlg5dHltdk16K1ZnazF6?= =?utf-8?B?dEw4b2ZNSWo0T1JaZ1U3TlYyL2ZCcDgwVE93YmxKdlJVQkhTN2k5WHRlMFl5?= =?utf-8?B?VEpPa3cxQStzTkhxRldmdExMaG5RaUpaMUhXb3kya2p2UncxZVVqYWNUU1VC?= =?utf-8?B?eTJLWHdGTFg3UlpzaE1IN3Zmd0lzVnAxN094Qkh3dXdOZGNueDBER0Q3amww?= =?utf-8?B?K3VLWDZtN04vbWtFSnlPcjVvNWxvbjNCUHJBZkNrejFLRWlVSERpbHdrTTJX?= =?utf-8?B?MnNQWWQvYlFWbVk0SlFrUk5UTWduSWN4TFdYTkZ3MUVVNU1penFKcURmK3U0?= =?utf-8?B?OHZ5NzJuUno1Zk1rWGRFSzROelY2VitBZDdBQmJjTDFPNG83bHVTZFVpVTFj?= =?utf-8?B?OWNlZ0psNkpjRzd3eTZHcjB1WXpSNlBVMVIxOUZURVk2ZnRGQ3J2NWZ1eDVG?= =?utf-8?B?UWhDVVpsVkxDeENYTmd0Y011RFpEaGdaOXBNaGFZTWUwdzYySEFGWkdsMFZj?= =?utf-8?B?TXJtYVZwenZIL2lUT1FnRGdPRnFKY1VXenZRUjhRVmY1Ukp5VWZKbzUxY0Jz?= =?utf-8?B?SW02SUZwYlhvYjB6dDRRL1g1c0pEcnRLd3YraEc0bG9qWDNuK05XcjdBNTNE?= =?utf-8?B?SVRGeUpXMnFUL1lNM1VoTEE5QlNlR3AzMmhyUURYMVVpZ29LTGVhNUFxcCt5?= =?utf-8?B?ZG92ajA0akVqMy9hT0QrTThBN1FaZDNzeVdWeTAxbTVtMzVOY2V1dUZ4YUZQ?= =?utf-8?B?WXJ6bWRzVHowdXU1dTBsM2h4Q3FqOFMwdlFSZy96Nk1FdHV1V2hUS2U1QW9v?= =?utf-8?B?VzJSc2srUWV0dlgxMWU1VDZ6QmNtbVlwU3ovWTdFWXp3SktmdGdCd2s1Vk9G?= =?utf-8?B?V01FN0xyS2pyeCt4T0FNbW9GTmRBYzk0VkRFbURicGhmWnhuaG5zK1NsQ1A3?= =?utf-8?B?U3lYNHNsSmUwUml4N2FOdjhyQSsvVG9MQWk0NlMrbDArS0JTRDkveXhocjYv?= =?utf-8?B?c0JFaWZDUmduU2FWclllOEhFdkVCRllWRG5RQ09IbjJLY0hEQk9ZQzlVTEN1?= =?utf-8?B?VWl0NHFHZXJWK25Vc3ZSSDBvRzNqTUdGN0pidHhFdG92K3NZV0J1c3hsV3U2?= =?utf-8?B?eDhoSVM3V1gvOXpPZXQzZ3B2SDhWQml4R2lrVVVvMTZkalROM0FYZXVRTkw2?= =?utf-8?B?N2NYZWQ3aWZSeko4SHBnY0tYM3NZRVZNSmx4R084Z1FDN1lSb0EyaFk4dE5V?= =?utf-8?B?amlXQW1tS3BiUTNPMFdxSVhrVUU0QkxzU1Roa0ROcFVaMDBRSGExUFVVc0lF?= =?utf-8?Q?WY9ugsLyQinCesbQI2l1/4iN0?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lwdgjmBzfvTGfdt6gPVzOLn5HcKBede/ss6WUPooGDk4+TI2IBtpoP+UQ9Pb3U66wai5+Inf1XDlYZCa7P81k1sguf9b1cETuRxLmg99iuCNNyH37Smd1u560buiO9mwiar42GIuT4Gbxg8aLMmWVDCWmg9OkE29DFs8ivuhVyJVSkKvS+CckWK/LzDRzLDKBpKja+ynVsjhTj38m2R9bOaPfjHVG7UIMjyv89VephZYkv/r42bQ8nejC4OkKbANIlnwAzbxh57cRy+y+U5pZrYc5gL//6gUPC00urpLp2IV/b+tkhIRk/E5LrnuFoo9ytJSKxqDmEn8CTi0lddG0nedIsTV1d+WlnW8ghkTD1u8034/oeA+8mb6LCdk4brilk+vEWd95eIlPL2BZ6/Ok1YBBxBPI1y5esqwRPfP0RLveDeKLl4LuRzKajC6ZzZFXi7ojsIDfvhBYSIBpTGW2+XMCEoPcbeooBeHS/m8wTHbxolnfnLCbUwsCJUD+L+J/LNz/qHAcD6zduBBHMUhbIU5I259GqAjVAurh07x990/ALa2lR5zfpu/ZxGswk5yYAwznRome1XNsxtoqbNd4rDnl9fIbMCHcvQloBK7YqhqfNnKMHW+wg6tEZgcdKO9ziBM4OqIbNVuIvHathd9qnt9CkZjMssXYYNqRi5Bf/PfStGYIaVpKEDDYCxNzL5EN+EF5l5JyLvFpV5fayUIoLCXGya5X5TEQboFgGN4cs0SArwU8Tj8H/ejpG3YfB1YACJXqWnIJhzpmAXUHu7spPNT3qz+4lhL6D8yK7P7kL6qIWs6MI9+9/jnLAOeCIv3 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84be8364-0641-432d-7f17-08db368d42a5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 10:54:14.6232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: klYusHizOEgwOdStYM8ivWH9VR9ypk8LSM2NRSrxJIGgSrQJW0PW13Hj7+wbybHnMOTLJpiZxUd1iRSlpVcq+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6530 On Thu, Apr 06, 2023 at 10:36:37AM +0100, Andrew Cooper wrote: > On 06/04/2023 10:18 am, Roger Pau Monne wrote: > > It's a GNU libc specific header which prevents building on musl for > > example. Instead open code an equivalent replacement for the usage > > of ERROR() and DIFF_FATAL() macros. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Konrad Rzeszutek Wilk > > Cc: Ross Lagerwall > > --- > > common.h | 10 ++++++---- > > create-diff-object.c | 1 - > > lookup.c | 7 +++++-- > > prelink.c | 1 - > > 4 files changed, 11 insertions(+), 8 deletions(-) > > > > diff --git a/common.h b/common.h > > index 9a9da79..ec2ea33 100644 > > --- a/common.h > > +++ b/common.h > > @@ -1,18 +1,20 @@ > > #ifndef _COMMON_H_ > > #define _COMMON_H_ > > > > -#include > > - > > extern char *childobj; > > > > #define ERROR(format, ...) \ > > - error(1, 0, "ERROR: %s: %s: %d: " format, childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__) > > +({ \ > > + fflush(stdout); \ > > + fprintf(stderr, "ERROR: %s: %s: %d: " format "\n", childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ > > + exit(1); \ > > +}) > > > > #define DIFF_FATAL(format, ...) \ > > ({ \ > > fflush(stdout); \ > > fprintf(stderr, "ERROR: %s: " format "\n", childobj, ##__VA_ARGS__); \ > > - error(2, 0, "unreconcilable difference"); \ > > + exit(2); \ > > }) > > Looking at the usage, can't we just use err() instead? Hm, err() will unconditionaly use errno, which doesn't seem wanted here, as in both cases errnum is passed as 0, effectively preventing printing it. I could use errx(), as that doesn't append an error message, I think that's available on musl. Let me know if you agree with that substitution. > Also, I suspect you don't intend to delete the error message in > DIFF_FATAL() ? I didn't think it was that helpful, but I could keep it. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:00:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:00:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518830.805737 (Exim 4.92) (envelope-from ) id 1pkNMK-0006GZ-7Y; Thu, 06 Apr 2023 11:00:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518830.805737; Thu, 06 Apr 2023 11:00:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNMK-0006GS-4v; Thu, 06 Apr 2023 11:00:52 +0000 Received: by outflank-mailman (input) for mailman id 518830; Thu, 06 Apr 2023 11:00:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNMI-0006GK-I6 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:00:50 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48f4623b-d46a-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:00:49 +0200 (CEST) Received: from mail-dm6nam10lp2106.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 07:00:46 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5683.namprd03.prod.outlook.com (2603:10b6:303:9a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 11:00:44 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 11:00:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48f4623b-d46a-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680778849; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=IlpTgSJI9pfA1iEPVzxBYcTZr86Ef7T3f6t/Sx2AMZU=; b=NlJFMGcRN/Txd6Dek8Ua9BNaPR1Vqx6S7XEG8/FMBz5hWvPz1fCyXRJK f9mbYp017oQtBZqnU+HBpUYKQtRM3VeaUwX/G70BIAOmja6VfdQfUa/iU SDFSF7HejnPP06CUptxk3bo6V1i6T4oVCTUy+AAuGcYKMMiXi5hxCV3dj k=; X-IronPort-RemoteIP: 104.47.58.106 X-IronPort-MID: 104458869 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qZix3KDgzAsPuhVW/w3iw5YqxClBgxIJ4kV8jS/XYbTApD50hmcFx mNKCmCPPPjZNGqnL41zPYvgo01SuZOAn9BhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw+PReBjl+9 NAiChMTZzCxpsyTy5ikc7w57igjBJGD0II3nFhFlGmcIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuuza7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwX+mCNJMRdVU8NZMqmPL5lE1VSFLdmmRmueVsUGbA+pmf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpa9sgrsY6AyMr0 lyhmMngDjhi9raSTBqgGqy8qDqzPW0ZKDEEbCpdFQ8duYC7/sc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:gzQPWq88LBiHJJZZ7a9uk+EKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVcqKRcdcLW7VJVoLkmskaKdjbNhX4tKPzOW21dATrsSlLcKqgeIc0KRltK1vZ 0QC5SWY+eAamSS4/yKhTVQJ+xQu+VvvZrY9tv2/jNId0VHeqtg5wB2BkKyFVB3fhBPAd4cGI CH7sRKijK8cTBPB/7Lc0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfMJ8H TDkSb++qK/2svLuCP05iv21dB7idHhwtxMCIiljdUUECzljkKSaIFoS9S5zU4ISLXE0jcXue iJhy1lE9V46nvXcG3wiwDqwRPc3DEn7GKn4UOEgFP4yPaJDg4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn93d7VTBtn/3DE6kbKqdRjwkC3bLFuIYO57LZvin+9Ka1wax4SPbpXWN WHD6nnlYlrmB2hHjzkV1JUsaCRt0QIb2q7q3c5y7aoOhht7QFEJhgjtbwidzE7heYAd6U= X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104458869" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aM9cyZ+1c6w089f298g0+DD8RyVvyvnLcmRb6lNec9hy7OGsbGDTU4r1pXVKx6jLFfharGl06WBt44Q+kXm/WZYrO3onCH2MubAh+BflPbe4nUH9qIwGLmU2XEx0ViXETqg/Tmu8GUm6sTap6eBhEae+LDPXJntoHvZP5x+3noBExAmFK8By9E5oQ9LPIoySTnuT62vyTspDUvZzGi9+7R6NNSFOtI7RQ90zSIzcD0kphXDrB2k9pR57Q8zV+ozLr8xBhcmAZJMwvBU17F2tspc3fr4edYLajkaxPEScDgzvfG0V3Y6gwAeCCFL10piMa1ykXLY71qmWjTx7jsGtOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2xNSNKUP7UWFvHKNJukQfcArgYn3YiCjUe8bsow8ens=; b=OGjC0bWBb+6lF1MCSGZalYbQXc9yKq3TeSsYdK1KFeMkFiB8F0RLz7S1PAuo8eegAfvSAdYhbF6RSuogiRdjOJopRzxi+jKNxcu84bvYzB4jV2R6MllPL0ld9m3vPckmJeqwCXba8NuCyA+leol3JeEDu2q53mcOoa1ewhywd+Gqo5A2lFkc/+Uqt5LlsEOS2aNbgzx4ws2HjPwQgaZHzPGZ8EL039jFEjpP/ezjXw9oqHLkTESpiftfo8P9ja53PMlbTAozEOekg6E5pWl8YqXB2n0m5QGGrbp3z6j09Camt7LVi1gEXNU7ReY8e/nh0oHXZZib0IxwmZ0OMIanGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xNSNKUP7UWFvHKNJukQfcArgYn3YiCjUe8bsow8ens=; b=dYzRhre05yY9j+3nbifdi0G7JLp25/Uwx96uMIy9mUQ+98RA9YxzXfGxTCR4oQhYfguMoJICMMtkIKVndnQzEnHQQh0mDtcD3gigBECN/dcZwgYMzbSUlr2rNZmaOezk0S9g1fcDIXpGcXfY6NOHTXGs9i/1h0vee3JqzPi5uHc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <00396729-4e60-902a-dbe4-e2ef9ab3fc19@citrix.com> Date: Thu, 6 Apr 2023 12:00:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] livepatch-tools: remove usage of error.h Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk , Ross Lagerwall References: <20230406091807.49028-1-roger.pau@citrix.com> <4525547c-e309-c994-3dc7-5d1b398aabe1@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::32) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO1PR03MB5683:EE_ X-MS-Office365-Filtering-Correlation-Id: ec3473c0-7d7f-4ba1-b20c-08db368e2ad6 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2N1djKhdwr8Ea37Mua45Qb2b5b18jvgmp+ZnAH1l2prOXyHsYmR0ll9PFFRDrQugGkKYhbknCFa91kFETg2iO5H3P6C1V8qewajNMilruglUkyYbTqtnPZx0qTo8BFVGFfAoHbPkYsBe/TER6wifd2tmr+UmTs7Ibt/Tjb7hjOr+0npywaylpyoz3f6pTJTOWhEeL58FRn0O944nvVOZe6wULgN+s/SCBBluCNMF/XFr1cDXkve1ZZ+X//hxK1OJQ7gk1UklmF/jiaR0L3ZTIiWoq00ajJ3ZECU2EO7HIjjRtGzdCR/CiMI4fE3+kK4T1akq2PF5xl6mmHsVOVIms9i72Q/xTfN/MLLGa7ty1bl8FdIq06JLNCvH17lJ+rRSNZ2+HqyCAseeAP5XBAs2qJttwaruNRBbndBdxMSmRx3NJ+ZSFBkCnf7QBDOUYi+o1gIowpi0i4KqYcHiptwe2nFWEMDJ+xf2GCTdnVQjeHdMRvEOV8fhjuXso6BcAQbwoJfOcgK5nBtdtIPoloRA6u1+ER0cXrTzroGFDbkr+ynna/EyA3+mqiT8Zh1kivWwE6QMc5UNVlfacE927hfnTgaUSHggJiQ02/TxRwFnlcRiAluMzj/lVF+/p1G+9dhJi0DkMK6AiEaItDWqXC7X6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(396003)(136003)(39860400002)(346002)(451199021)(31686004)(6486002)(6666004)(478600001)(31696002)(36756003)(83380400001)(38100700002)(82960400001)(86362001)(2616005)(53546011)(2906002)(6636002)(37006003)(316002)(54906003)(6512007)(186003)(107886003)(6506007)(26005)(8936002)(4326008)(8676002)(6862004)(5660300002)(66946007)(66476007)(66556008)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTVpQkVjbmFhR29ocDlxWStSbFNRTTlDQlIyUjlJQ2Z4NXJpeUFrNWFnZndL?= =?utf-8?B?bmF0LytBN1ZIZE4yWm85STRxbFZubzZ6YVFJRFozTTlLckYxZkxaWmo1Um9Y?= =?utf-8?B?bzd2TU85RkpuYWVET2t1SWIrSU91U3VYTEJnQjNWMFluL29JbHVzeVJHaXJM?= =?utf-8?B?UVZnQWExY0tUL0x3WmVraEZQQmtJa1h2L2d5Sm9JT3ZCcE5FT0kzSlFnajht?= =?utf-8?B?SkFOeURXaUs1SysyK0pOcU9mSWJSeFkwaTdza0w1d1hXN0p0L3I0dTBFbXl4?= =?utf-8?B?TnZxTmN1SGpGbFVNbGRDUUdvR3c4NC93cFZPemhpZlNaOHZTdUV6Y2cyc0Ra?= =?utf-8?B?dllXbkVYRmVyVXp3Y2lTUWxPdVBKMDYrclU2QXNKbGYzSUFFalBxWE02TjBp?= =?utf-8?B?am5WNDZBWDZOVndjV1ViSXdVQVFwU0JKVGpmS245NmNhTFUxQVBXNURSMDdN?= =?utf-8?B?TFZCSjE1c3BCSVByR1A3NFpYdXcvS1NFZCtqNHdXL3FtWUxkelkzRnJxTHFo?= =?utf-8?B?RjU2RlVkdDFlWnZaaVZ3eEhsNm5NWEhZQmJwMk9iaGgxaDdzT0l1bUNWdmNE?= =?utf-8?B?WEdHQXFhd2ZFdVdyNWlwR2xqZXBkVU1BVjJzb3hVaXZaVGdFaStKS0FDbENV?= =?utf-8?B?RVVFRGhmT21aVlQ5ZHN6N2xZVjA1YWJOYU1WVjlySFptMm15RkN3TEpDLzJT?= =?utf-8?B?S3Fqdm56eUgrbzlvT2JyYithQTcvdGdJMGdmOFRmWWxhcFZva3hRUWlxRlpD?= =?utf-8?B?U2U5RG5hMC9xVGI1RHg2YUsxdDhKRmROclA1elFra2JsNlQrUG11S0lBdG5x?= =?utf-8?B?TStrR0pYOWhaczZTY1pzcGh6L2NkamZwTGxVVDBMTVpuN0hxZEFWSE93aWNs?= =?utf-8?B?TFB4SnE2cHJacnBTaG5VU0VSWGdxbXR0dU9WVU9CaDVMckpVTTh5SUYyTzlI?= =?utf-8?B?ZFR5WEFNT0p1WnFjUk4wdEtDUnNkcmJiYUFYOVFaMklnOWNrUVdSalJxcTkr?= =?utf-8?B?RndMQmFlYjZORjdKT3lwUEwyTU02aVRPaUlLdThjWW9DYXoyUUhrMlNSYnNy?= =?utf-8?B?YjVDbGdJZ3BkQlltbldwazhsYi9sTE4rQ0NOdFVQTmUvVFBRRlFhbkQrdm4x?= =?utf-8?B?MVNHK1hWR3JvaDJNeHBzVklHQlZxbGxxQlI0bHpDd2laeFZFVXJhQnhyWHVh?= =?utf-8?B?VlJhMlZYc3ZDSWZXaWNpSGhXR1FrcEd3ZzlYZVd6WUpTNnF6TDJldkhaeE1E?= =?utf-8?B?dFMrRkphdFRxZ3VVSkF0Y0hNOXRieEZ3ZXhBT1Q5RFhncWh0bXFXVytlOExq?= =?utf-8?B?aFkzaHRKWVlqNW9BZ1NCL25RQmV0MkpMVklmR25GdytGTWoyZEVWRXlId2pW?= =?utf-8?B?QTVvd3hUQytybHlUOXorMUJWYnNaeDkvcUdwRmI0dFplc3J0d1d4cmpMUFlv?= =?utf-8?B?TyswZTFGeGs4Sm5pYlRlRG8rckpycTFDNHhuTkl4aWxwZllVSGYybjU0ekNK?= =?utf-8?B?ZUV2R2xlVXc0WmkrYmZjQjBTQk5lZnB3R0Q1Zjl0dlgwVnRibjE1Vlk2RE5O?= =?utf-8?B?ZHdCWG9RdGNpOWFSUGNrVUpPdHpaMEtraFZNbWxCbTNaa29La2hUSDB4QUxN?= =?utf-8?B?RWlZb2hXaDBIMS9OMDNpVWNDRElkNzdmL2I5Wm9wa2xGaUNkYUdXRndYbDJI?= =?utf-8?B?ZE9vdS83RCtGVVRBb1RXZUd3QlhJRjBTOVArWmlGZjNrZ0ZCZUxDNlJjMVBJ?= =?utf-8?B?ZjlmeFVmSFNydzQ3b0M4UXRnVkxpMkN0Tm56OE9lWjlhSmVpMnJZSzNmaTAy?= =?utf-8?B?Q1M4NWZzNWFoaVBvRnhYTVdqbXhib0pQVnNmRW1EM2dYVWh2SDdCd0JTTnBz?= =?utf-8?B?aHlTblBrZStpZ0hWQi93VnZuWkFUYXFxYytTWlB6SVIyV0dReE1vUU1Xb0dZ?= =?utf-8?B?R0FkWFhEbGk0OG1Fc0EvU1lySTdyMHpVT1ppYXJiMWpEczJ1YTBlQTgrWW1t?= =?utf-8?B?VnNyYStYTkdpSG5GTUh5c2VmYVFWL1U5cW5URWV5eHJ1YThmeTdGRmF6Rm8x?= =?utf-8?B?V1VqQnpUS2VjWHU3YnBQZkdPaUM2cUFmWEk4YkIwaU4rQUZTS2g4b3N4b0JK?= =?utf-8?B?YnJOM1FzWEN1d0ZmWHZnWFVUNCtNa1Q2Tk5wd2NiWEx0MTJhMWdkUHdhQkZX?= =?utf-8?B?ZHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BTo38nGMK/GWwpRsBwTncd08KNFD9S0mjLv1yGeDHecWbFdBUg8YvXEmJuWxZByyj/tRNFECMm5CuDwzbi8ekqcqsQTjeEjnMi3pF/LnaeWnp/syOPzDJHMl6fChTbgW/LFFDekHJ+XOKHXFqDaGZsah6W/3zsQcIb3rVcxDPyV8ZrkjZpw341XpmUD74QII2nO0xjMT41V7EVbS0UYYqEbo2Ws+7YVQZBmEhoF1e8UkfgsngkharR6mfjQG3WeeNdasDTTcwRjU9iFkggFh6fm/wH4/4LYOnwGUl2CObjneJUn+bYME9CvmNVzClLMQsv4BVfZED1HhIXDIPy3qEvToi9IvW3/QaKjHse7+nB6skF8zve/cgdmxWOpQwvV3QSP8TZJEyqNiXzs0hA3+/xuwXHYMwl0ALXJvX6OCIahIkaN3SsqpTevvrgeZCOh5/b7myqWVEjJXpVVDxtBcautwBBvu1awv98BOiKkrPjlUlYA2BCM8ugw5DFCaQJMe4b8asmsfBKy8QZfAGbK2V2m6Kq5NvxCGXehzNoly+qXXQY3RWNhKcnZR6OvCGEyu+8SulWZassRkyp9Xz/hG/UtKBbmsZQBk0Tvpxfz9uyigISWg17Zzkp3lve0ZxpmpbkEJuIBxGsdcgedQyCOn4XNSYgeQw3vaAtpeKkzFCZb/59wXsLNGMYat4b6EUIGxf2q0ysSB1qrocsaIRSmM5iQYP89UvUX0jMKQeIYwvwxnIr0ijxdyRporKioALXJ4FdtXyEwy7glavATHpGqSJjD/DksVn+Li1wPhiVWdGQfzQay1nMuKZFDrZ4+QzrV7 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec3473c0-7d7f-4ba1-b20c-08db368e2ad6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 11:00:43.8040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L+heuQvxkz7any2GBjAi1FeZAO29rjz808ejCd6TEkZ3kkA7+AhnZooSzWSAIiUaWD+n2y9oCl/bruQdLEW+MwM3BMaud5tFuGXoJ2V9RJI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5683 On 06/04/2023 11:54 am, Roger Pau Monné wrote: > On Thu, Apr 06, 2023 at 10:36:37AM +0100, Andrew Cooper wrote: >> On 06/04/2023 10:18 am, Roger Pau Monne wrote: >>> It's a GNU libc specific header which prevents building on musl for >>> example. Instead open code an equivalent replacement for the usage >>> of ERROR() and DIFF_FATAL() macros. >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> Cc: Konrad Rzeszutek Wilk >>> Cc: Ross Lagerwall >>> --- >>> common.h | 10 ++++++---- >>> create-diff-object.c | 1 - >>> lookup.c | 7 +++++-- >>> prelink.c | 1 - >>> 4 files changed, 11 insertions(+), 8 deletions(-) >>> >>> diff --git a/common.h b/common.h >>> index 9a9da79..ec2ea33 100644 >>> --- a/common.h >>> +++ b/common.h >>> @@ -1,18 +1,20 @@ >>> #ifndef _COMMON_H_ >>> #define _COMMON_H_ >>> >>> -#include >>> - >>> extern char *childobj; >>> >>> #define ERROR(format, ...) \ >>> - error(1, 0, "ERROR: %s: %s: %d: " format, childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__) >>> +({ \ >>> + fflush(stdout); \ >>> + fprintf(stderr, "ERROR: %s: %s: %d: " format "\n", childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ >>> + exit(1); \ >>> +}) >>> >>> #define DIFF_FATAL(format, ...) \ >>> ({ \ >>> fflush(stdout); \ >>> fprintf(stderr, "ERROR: %s: " format "\n", childobj, ##__VA_ARGS__); \ >>> - error(2, 0, "unreconcilable difference"); \ >>> + exit(2); \ >>> }) >> Looking at the usage, can't we just use err() instead? > Hm, err() will unconditionaly use errno, which doesn't seem wanted > here, as in both cases errnum is passed as 0, effectively preventing > printing it. > > I could use errx(), as that doesn't append an error message, I think > that's available on musl. > > Let me know if you agree with that substitution. Yeah, anything in err.h ought to be fine. > >> Also, I suspect you don't intend to delete the error message in >> DIFF_FATAL() ? > I didn't think it was that helpful, but I could keep it. I'd be hesitant to drop it, considering how much shell parsing there is of these tools. But ultimately it's up to Konrad/Ross. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:11:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:11:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518836.805748 (Exim 4.92) (envelope-from ) id 1pkNWU-0007pd-A7; Thu, 06 Apr 2023 11:11:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518836.805748; Thu, 06 Apr 2023 11:11:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNWU-0007pW-7M; Thu, 06 Apr 2023 11:11:22 +0000 Received: by outflank-mailman (input) for mailman id 518836; Thu, 06 Apr 2023 11:11:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNWS-0007pP-Gs for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:11:20 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c099e94a-d46b-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:11:19 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 07:11:17 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW5PR03MB6957.namprd03.prod.outlook.com (2603:10b6:303:1a8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 11:11:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 11:11:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c099e94a-d46b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680779479; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=TmztV2nZ2906F86lRQAVOyoiRJRaRw4XaZyzs5XVePg=; b=AxmY37PULemvRcvo/E2P7Aew/7tZfwk/sP3lLDImmADbIj1nBTBhWDHQ NIPk7/H4ieRge5QAZcFVn1yercszPsFDgXP2A0N+uZ3nk7W7lxymhytox fEJxLxHBy9+/V9iRicR2XUB+Zi/uGYlkGjRV294lPHNfBFimG2cR3emHF o=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 104460191 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xCpjjq15o/4hWcSlqfbD5fFwkn2cJEfYwER7XKvMYLTBsI5bpzwPn TMWUWCPMv/eamr2e9xwbNjno0JQucXRy4VmHVRspC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBmO6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfOUFkp NE9Dnc0SlOEueWQmJ2Zdtldr5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PlWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHunBNxKTezhnhJsqFiJ3GJDLT5GbAuEneC0rROBSd9iE VNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4A/IPlqYRq1BbXFI4/Seiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAszA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:R4phR6lC+bGxeq8A23G/hkkMlNLpDfLz3DAbv31ZSRFFG/Fw9v re+sjzsCWftN9/YgBCpTntAtjjfZq+z+8T3WByB9eftWDd0QPCQe0Mg+rfKlbbaknDH4BmpM JdWpk7Mcb3C1dii8b8/U2XL/YMqeP3iZyAtKPm1HFqQhhta6Z8qyFDKijePHFXaWB9dOIE/L z13Ls8m9NlQwVtUviG X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104460191" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jDpSdODRKyZeIayjbLGbOl2YxFR+Can9uLFAnM8ovDpjuknCuICkjiVKv+/vnCbxMfjSeblEHi36T4sZISu31DAXGuXkBrmL6pkQgToNV4QZcxHduO0/WSVPQNUqd/8fNIJSZ9aSdedTiJRnUDZOc6msmrcwY3SeoTj7ZD+PYc+YSy6e6WMVK0d4ivoC7vWr3RwdByA6cvrzlxb74CGyWW+drWIsqNh8L1qpFj3Vy4z6f9D2OT973ftamxJqx7El17fv8+UGcjNYB12puaJjpAzVteNjRJN3ffiur+dFmE7WKTvy9zLVQCXWQONXxRHTJxAzKkBuTZTYy3/qxPVVXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xQYGpsCo7B1mDdak5WQS3B5OG7n7X0XtcLMqpUqH6mM=; b=IXUG2dtEzk9e3WNEmqcfENSfCI77cb6tSAHs2EL5eXUC5HjgK66SSA4qNHVHHFhK3OYkjm+FqaTVGyBJo1ZiNokRaVXfYQJHzSgYiE+dfhXsAUIVoLie+LLgZWaNmfQKhXUTxXZbyXb4yIVUo+runGoHmLwYZnid5DtUwxHe6n1Gzd2LingC4Hc5TQCUvj6qDpaMipZjUk/5xOuY5v4Ar2rmt1hJH2YYNyBQ+T+taLTP9X9Sl4Hlr66bRA9RBGJ+C4TctF87wjqQp+6iYn6QSBS0brwFvNPI9ya04VHF+IPHxixMlaQ/aCrwfdq/q+hLMMjV82cYkRpyk0VMhtfmnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQYGpsCo7B1mDdak5WQS3B5OG7n7X0XtcLMqpUqH6mM=; b=aYPg8BZkgDjXhNLJLmzj3tL8fCLwb2kA5L5aAnQBhRnAILLKW7h+8sPE2Lj+xoTM4hlP1/k4IMUUvFqbA5mlz55IAkz9HKxjxnn4cxeC3A6Dnf4UM/eUsE2yUdLSd0qOHACRf7TcLtL1zI/nkTlT/v72SLEvLb/AMP55V5aNKpg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0a5ce571-bd1e-e25a-fb76-a3a2ec6de201@citrix.com> Date: Thu, 6 Apr 2023 12:11:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230405204423.2113418-1-andrew.cooper3@citrix.com> <313a2a18-020c-ca76-f620-f5694a74efeb@suse.com> <24133c6e-3e66-7be9-41af-daa3db4fa961@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0688.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW5PR03MB6957:EE_ X-MS-Office365-Filtering-Correlation-Id: a7b7386a-2252-4be2-d6ae-08db368fa07e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xujIu/OY3USW7avdhhbiWs/ktO9Sc9w0SjI2vS2WtbQwxQA22kxHZdujwDX1iJHgR5LRy85dbtDi5B8Og0B1qb0lof63rPOTAfmENskd1zE5g8V+T1rv6e4jsAnB/PiZAViBYrmNcvHiojJh2jixbT3lkrZ+FEoGrj50Rqaw/xRFU6B70YFnkpLnaKisfsOy5iUs7JbwZc/ktMLg5UKSeTpPtCrEXKzWVLF+urTzQPAoXuwhXZ5HFI3MU3acPZW+zcihzjVOKeptNfwNbKCppoOC5uR3K0pvuvaeNMvvVnO+0VcxkZiH+pA/R9XnnopqBshq6btsavKGCiAMKx3UB9wOxPHKqRu58Voe18c46s9Itun3yxsnAPSrNVbit47oy52l6lPdvxH5a1dUWof3taSkKrSeE7iJUHTayTTSzha8bdBANTP5pO7srMBJO1sFY+APODc2HavGqbh12/kcD2UIRJs+VNacCicDXM0/V0bb0scuOOdRrI4ke2zZPUKNiR36XseXvaAN9uqU725/MRTO7QWtJUHNi93kzjjVD/cIPHCtWaotJEBnjMeV9eghTHYP5NHT5dtFyso89sKaFlWbTs9lIv7KtHqKI0j7gysw2LTYTQhJaSftA9SiJAb3o5LmxXaQ3Nq9m6Nynxyx0g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199021)(31686004)(41300700001)(82960400001)(38100700002)(2906002)(5660300002)(8936002)(4326008)(6916009)(8676002)(66946007)(66556008)(66476007)(316002)(31696002)(54906003)(478600001)(86362001)(186003)(6666004)(36756003)(83380400001)(6486002)(53546011)(6512007)(6506007)(26005)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnU0WENScGNPUDB5YjBoSWFTZldZMU5TTjMybzZod2I4QTcwcVRHdW1pY0s3?= =?utf-8?B?WUlmampUQnIyVmQrMU1jb2pPcWtaZGw0NjdyMGVPNzV6Y29sNi9rOUhOVWRn?= =?utf-8?B?ckZ5MEd1MjZ1K05FSndmd0pqRWZNQ3lua1o1cm1aV09sekZrNktXa0J5TnhB?= =?utf-8?B?djYvVVJ6YWpJN2xnMGt4YTI4cGxLU0p3SmNXRVNwUFUrY2d3K0l0Z1FpZ3VV?= =?utf-8?B?blUzZVJCeHROamRzcituMGNXM0UwYkFUY0ZDWVJaS280Vms0SFBtNFNHMUpz?= =?utf-8?B?dUJwMVpwT3A5ZEFXMEVocUhud0VYVCs2clFuOHZLSTJvR3Z5dTYrMGN4bmZt?= =?utf-8?B?aUdiYVBwQ3hlK0RUOHVONXZ3Z2k5ZVZBaWhWcXZHNlJkaHVvNTQ3cS9scUVr?= =?utf-8?B?eHVhV0VRdE15QXpJY2RjVVRQaXY1T2hPRUdCMUk1UnBUbEVGZjVmRDVCL0dR?= =?utf-8?B?Yk9qQTlyWjB0dlVYTGdvQWM2cGlVVHlLaHAwYnpTSERwR2VlL21MbktYNXVE?= =?utf-8?B?WGczbUFkUG0vTEJ1RDNCeVVIcFRmbFV6eHJoYW5vTkZUMXJUekhpb05mUld1?= =?utf-8?B?L2p3UGI1OFpYalRUb0VjREdlR3ludkEzWFB2cjJlRGhLQ0xrTERjcEp3MWlQ?= =?utf-8?B?Tms4VG1XZVVxRjRXSnR0djBKcGtqaDE4ZlZWM2oyVXU5UENkb21GOGR4c1Br?= =?utf-8?B?OG9BR2JaZ0t1NTdIbHdjTUFJcTVaZ09NQmhYWERvL3h0ejF2K043UHJFcnNG?= =?utf-8?B?eG9aRURIeWR2aWFueDV4SXRrU2hXbHVjNW8xTXUzcVZKd2c3UUczREQ2aHZa?= =?utf-8?B?ZUZOZmYxL1ZERzZzZFBHaU9SN0tGQUhyNmVZN0NUL3dQV2VTZmtkbVFnMTNn?= =?utf-8?B?Q1V1ZzFYb1lBMDh2aTQwVWM2dEZjU2F4N3BKdjF4aTVPZ1hyeGhGcmk4VGhl?= =?utf-8?B?aFltTCt0eFRnMHE3cDVUcU5ERjUzTmNJNGxncVZYRmIxaE9zS3Z3WlpJRkdM?= =?utf-8?B?N1NpRU1RenNZZzRJU281OCtqSnZHcWtCbXRHdE9MN2pwbzNCcUJ2bFN2Vklx?= =?utf-8?B?cnl5bmpJbXlFVS92SnVYbmVGckpHNXZUaG1DSGxKODMxSkF5TUVkUG1FYmtn?= =?utf-8?B?SXVWRFBtRU5UWWdKaWo4Y0tZYzBBTzh0Q3VIbGJGcXE5aDdSVXl1bkJMUmMv?= =?utf-8?B?VW14OGlXM1dYenNqdWNEZVhJUUtsclJFYlNDekEvSy9yZE4ySHkvcXdyZXRL?= =?utf-8?B?WUxUbENKQnpGcVFhRkx1c2s4QkVTOHlKV3lvanRPcUtCUXB2b0NIMWtPUjBo?= =?utf-8?B?S1UyZ0tkR2p2SXd3Znlkb1JtZmFiaGE0MWk4WGtqdndGVWV2U3A2WkM1dXF4?= =?utf-8?B?cDNWNWpFb2NYOWc1MGFkcmJGQVFTKytXT3pvMDFnME9yUHRzNU4zeitIc3hw?= =?utf-8?B?cGY5MWM5RmdjbHg3b0x4REFtTERhSW9Oai90ejE2a0pIZ3hVS1NyTy82VTVa?= =?utf-8?B?TkVIUWlDTW9NNTAwZjRVNlkwQ1Jxd2ZrZ3I5cEo2V1VkN2t5TnFVTWZMdXRk?= =?utf-8?B?NHQxanIwMHFwMEpkZUFXbHoyZDFiK2FnUGNmaEpOYjJaeTdNWkNLeHk1elYx?= =?utf-8?B?dXVETTlsK0k3YVgvQ1RWQUIxZy9McUVXS2RYdUlrZ05zMXgxcXVtZWx4bTc1?= =?utf-8?B?S1FUdW4vdWtMQmFIKzlscGhvSlU0VjZ1R2JEREt6T0xOc0d4bXJBV29tVkFu?= =?utf-8?B?OEZKOUtzOUMyaTJhQ0oxaU9BdHJtdFZPd1czZWZROTRBVmJJZmxTV1BsVmJU?= =?utf-8?B?OCt1c3ErZzVmd2hXS1FVRmpSZDc5cE92SUdyM3dEMXpwMzRuNWlhd1gxTkVw?= =?utf-8?B?c1hKY1ZvdDQzOGlVaEI0MFBCdWFxOUVycENBZmJxeXRVNU9XTkRHSHJwSGRz?= =?utf-8?B?YmFzNmdTMG1vQjlYYjZISVZLTVREMk5hekttdytBWUlhZnJCenF3aHl2YnFv?= =?utf-8?B?aU1pYUZQTnlUcndCTXU1N0R3eUliVmsrb1pvK3NzUEZrQW56QlJFT2VHRVVQ?= =?utf-8?B?c1BxNFdpQXIybk5sdVhkSUphZXhqSWxKeTEvRFB3OFhyV0NSNmprTWs2aGJW?= =?utf-8?B?RG1DRWcweHRIZ0VBd0lHVVZYNEthTnM2UnhkS2EzTW84ekg4ZTlabkQ4WEMv?= =?utf-8?B?UUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TENWvx0F89HuKBz38DFDmbeHpybdKIjV3ixUgBt4rU6LsNDq4tM5rpQozRrkw3Q3yDgIl/pbzUdigMDMuYRZxquxL5mBKMruVhKFQG5OQpmlxJXmLVqNcro4v/FEbPevFJi6iFgZxCQaXgGiRS619v8QFcKEWB7gFqVyLqbYMWnu2lo4IMAmy4T+cptJ6Q0ImNnih0bdgW9IhQEZFUZaWq2UTS8y8SPDlS+NZQvauVDO7xJZkTskbitKQrFCkON7ZUdTceeWRbxp8njK70Iz9zWKiDslIPZkXo7924FJGmv81fDsSfDHhPqlYZUZL2+tXhR1yzgZTeFX7FSuSOf1zgwzd/C0RdqRD/wFOqK43Svj5vkrDHf9L0s/CGa6hWcc9Z3pljwKTWUZHFWaiXlZEZGbHMj6kInTmooub4HwpQCQhsqKcjdEfTFbL+hRxAGtFPd8PTVCJ1g56nQI6HcynBpsfP5qnXQROeNHPm5CNH9iTJLosox6CAjPaivTtxGDhdrmFo5bfNqxLaPGcQG248Qnxz0sS+441MGuhGOcoz48leLTkv0k+ZmeXiDo6D6CO8DWTEUgXKBULtQw3DdhaPS9wp3RJlTv9VGCom0t+3dPiXrO0wRTBIVXWo9kxE5mb/5FfemvvQfc00E2Ls0g4nuohWsej9o88oRAgFthqmFqDNAIgJIVQsBQoGksXx/IZ309X8rAJiPHiiwDgwkF1LDY+tngjyNHxNZRKIU8iezXQurNwv3oPNEReEnAV5bButhucwOhy2f6yviw5JHT8lWpm8/TxuGKr6yeCtg1TXsKEoIXHcGp+mxZRYdevvtD X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7b7386a-2252-4be2-d6ae-08db368fa07e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 11:11:10.6614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kLVHbDiqla27d1ZqKGQoeUt4+0nmrr1vlQ6Dujn9q49RL34ggM92aIHzBl81tDu6gfdg/x9woDiruKN7YtQk0xDeSpBS80LY4T9LRnllVqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6957 On 06/04/2023 10:59 am, Jan Beulich wrote: > On 06.04.2023 11:52, Andrew Cooper wrote: >> On 06/04/2023 10:31 am, Jan Beulich wrote: >>> On 05.04.2023 22:44, Andrew Cooper wrote: >>>> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>>> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>>> @@ -450,6 +450,11 @@ struct vmcb_struct { >>>> >>>> uint64_t nrip; >>>> } io; >>>> + struct { >>>> + uint64_t gpr:4; >>>> + uint64_t :59; >>>> + bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ >>>> + } mov; >>> The field being named just "mov" makes it apparently applicable to DRn >>> moves, too (and the title supports this), yet the top bit doesn't have >>> this meaning there. So perhaps say "MOV-CR" (or alike) in the comment? >> Hmm - I'd not spotted that distinction. >> >> Xen never decodes the exitinfo for a DR access - we just resync dr >> state, drop the intercept and reenter the guest. >> >> Therefore I think it would be better to rename "mov" to "mov_cr" so you >> can't use the mov_insn field in a context that plausibly looks like a dr >> access. >> >> Thoughts? > That was my other thought; it merely seemed to me that updating the comment > would allow future (if ever) use with MOV-DR. So yes, if you prefer going > that route: Fine with me. Will do.  I don't foresee us ever needing to inspect the dr decode information. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:32:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:32:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518840.805757 (Exim 4.92) (envelope-from ) id 1pkNqc-0001qn-UE; Thu, 06 Apr 2023 11:32:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518840.805757; Thu, 06 Apr 2023 11:32:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNqc-0001qg-R5; Thu, 06 Apr 2023 11:32:10 +0000 Received: by outflank-mailman (input) for mailman id 518840; Thu, 06 Apr 2023 11:32:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNqc-0001qa-Fu for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:32:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9e897c1-d46e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:32:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F35664650; Thu, 6 Apr 2023 11:32:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B761BC433A1; Thu, 6 Apr 2023 11:32:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e897c1-d46e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780726; bh=JYv8anrELkRS2InyKfowv6LTjAw5NsWku3VF0hOAG1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TUm3KHk747drsNPz+Z0buQynVuBAz2heVtesdzfxaXkIilPM390GQsjsEQQar30ZB CNCgSIoeD8xdqL9Ptpi/m60PXAzEVIDOdjEV4rgEAZxtOTqsXSjkEctqcb9uyLfMRY /bh6sQBcU2s2YuSPjOe8PMgqeJx8VWahD+5g/ne6SB8eV2QusDK4uYU8Fif1rugSU9 r59twVqy81k//UBRHBqdJCVcNW5InJt3pERxGFSPFclXtCxXh6LNuldlFVn2vtX00S g6NukxvPyIGQJYs9UQqgEQL0pEM4bSynpaC3EEZkvy83W2H39DiCJ0F+p0x4ra7/dk MjVFjEZpQH22Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 14/17] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:31:28 -0400 Message-Id: <20230406113131.648213-14-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113131.648213-1-sashal@kernel.org> References: <20230406113131.648213-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 5c266062c08f0..c35c085dbc877 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -996,10 +996,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:32:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518843.805768 (Exim 4.92) (envelope-from ) id 1pkNrF-0002K5-7f; Thu, 06 Apr 2023 11:32:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518843.805768; Thu, 06 Apr 2023 11:32:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNrF-0002Jy-4h; Thu, 06 Apr 2023 11:32:49 +0000 Received: by outflank-mailman (input) for mailman id 518843; Thu, 06 Apr 2023 11:32:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNrD-0001qa-N3 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:32:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0bfc78e-d46e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:32:47 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E10B66459D; Thu, 6 Apr 2023 11:32:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22A6CC4339B; Thu, 6 Apr 2023 11:32:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0bfc78e-d46e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780765; bh=JYv8anrELkRS2InyKfowv6LTjAw5NsWku3VF0hOAG1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TlhXg6GL5mf5rV0n3VwXmCe9PulH8a8MtoXyFv6OONrS0HyqnnsaUhkG+tnx+i6FS hMzSiofU9zHbmdEeAgUwJa9tuO8xehyJ3ftsoCqe89JcT9bVyrwFkc4DJ7KvnfFQ1d 7S2h1mZ62MyPSdt9F4WDrpuD4fWI1QVLi/rjQYN9enSxrd6eddA7pXAeDyOs1G4+ZD tPGNPiivyC7pQgnZFdLVFBb6B7cHKFSyhn+fFKK9OoVcvWvoSkMT9z8QA25keq1oJY AEh/LKzK5g2/5vkxiOysqp5YTp1eQhxV4QuNkuzw0xeY/SUVx7uFBgsCQyDtYcSuEK siLcWKzzJ1m8g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 14/17] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:32:08 -0400 Message-Id: <20230406113211.648424-14-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113211.648424-1-sashal@kernel.org> References: <20230406113211.648424-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 5c266062c08f0..c35c085dbc877 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -996,10 +996,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:33:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:33:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518847.805778 (Exim 4.92) (envelope-from ) id 1pkNrg-0002nP-Fa; Thu, 06 Apr 2023 11:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518847.805778; Thu, 06 Apr 2023 11:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNrg-0002nI-Cg; Thu, 06 Apr 2023 11:33:16 +0000 Received: by outflank-mailman (input) for mailman id 518847; Thu, 06 Apr 2023 11:33:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNrf-0001qa-CJ for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:33:15 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d13ff762-d46e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:33:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC7A4645A1; Thu, 6 Apr 2023 11:33:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61EE2C433A1; Thu, 6 Apr 2023 11:33:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d13ff762-d46e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780793; bh=92M1GKdP/0zGE9SErJaH+kBPncxID6AmAyQ6G+mp5Gk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TGGRLJnk8qjic7eN7c12nElKyNd5bXmMCjG7/bjB3PqqoN+SbVBlfKzalzvLQIReV tyHgF0TW5nnzvp8CWHRO4EaeJATBDVEDxFWA392f+CJK3udrAgiShc9sjRBvpGK98w Ikza+T29g9Yv3i7hYwz7694Oje2lYmQ5nb9hggHiBk8wFQ8OUCg+RV2z+WbjtDEi/p 0yomVtcyjlIngUdgNwxW8JuUFqmJ7R4JNLwFVGLyLHmWcLeI/8NUVpNaYJaWRrCg1z E3fK0pol1vJ/MZ5i1ENnKUYgfVacwAkF3TcmYFGX66k3yYNhUpTiYTfZpzz5ym6ogO giGGe/45zFh6g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 10/11] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:32:49 -0400 Message-Id: <20230406113250.648634-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113250.648634-1-sashal@kernel.org> References: <20230406113250.648634-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 303d8ebbaafc4..63118b56c5289 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -996,10 +996,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:33:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:33:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518850.805787 (Exim 4.92) (envelope-from ) id 1pkNs7-0003Lu-Og; Thu, 06 Apr 2023 11:33:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518850.805787; Thu, 06 Apr 2023 11:33:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNs7-0003Ln-Lz; Thu, 06 Apr 2023 11:33:43 +0000 Received: by outflank-mailman (input) for mailman id 518850; Thu, 06 Apr 2023 11:33:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNs6-0003Jk-5x for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:33:42 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df5972cb-d46e-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 13:33:38 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B75764661; Thu, 6 Apr 2023 11:33:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1936CC43446; Thu, 6 Apr 2023 11:33:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df5972cb-d46e-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780817; bh=PlfyoNysZ9FML7GR+HPb+prC5EAQJfTUe15Aue3wG40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ivl/5fVh1TWiHJGMYcvdcLUZdx09TpE1iQos1OZrSEMA8SocOAi29lAQKD+myDqYl z3QJJHtZEkKrfLHK3dZB5ePP4Md9cSt8YENZWIMOAwjhts3wAXGq9Bc5UEpUXLeLjD /dbs2l8sYNJGLhpj3pn1CRF3XwO29rf8Q7WrV9yX6i6/ZRbqcTJBYOOW7TXf90e/p4 9T3S3KHsypRMOqPo/RR79Vay66qGR3RxuBUybVA3l5TOZAPFZOyzVKJ27Z7QGbpgjK 9jQQfhItmZTG7hi67yje0e88CltNV9UxivunEZztcWoN/LPUmQG9gV5y9joQSIeaMn sDizZyNEsCOdg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 9/9] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:33:15 -0400 Message-Id: <20230406113315.648777-9-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113315.648777-1-sashal@kernel.org> References: <20230406113315.648777-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 67614e7166ac8..379ac9ca60b70 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -996,10 +996,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:34:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:34:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518853.805798 (Exim 4.92) (envelope-from ) id 1pkNsS-0003tA-2l; Thu, 06 Apr 2023 11:34:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518853.805798; Thu, 06 Apr 2023 11:34:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNsS-0003t3-00; Thu, 06 Apr 2023 11:34:04 +0000 Received: by outflank-mailman (input) for mailman id 518853; Thu, 06 Apr 2023 11:34:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNsQ-0001qa-7h for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:34:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed2220a7-d46e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:34:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 90DCA6446C; Thu, 6 Apr 2023 11:34:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE3BC433EF; Thu, 6 Apr 2023 11:33:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed2220a7-d46e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780840; bh=DPDY4dLUTQFSWfyffi7VSXhzq2fp9bKn4Z6f3hsXLJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I3O+lWgS9za640uc/O0WqKXjg9ExsPtbEkIL3gWU41hf7E1ctsPbsjZ9en7ZEPKq2 BfttYxCflZFHdJZWU74UrushclmrnUqLbOYP6DPlvJLhrsviv0nUnM0CvbJMj2WNrn dS+KSjtYq2r/RmdaCmu4swItk+NekGlwVYBMR8Y77ngGriccJgRhW0MuARmSNf3OoB Vyyv3//853X8cfh/V8ICCmxawrg92SvsJkxUFix4nS0Oi548sNtsNHVH2voZSkr8ey oIql7dWyzbs7znGxHoZSz1DQTUAFpKjkHCfAHjOJJ/s6TBUx7Qho7jiR6kgpNRPGSS Zp2cMUbK6Z3CQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 9/9] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:33:37 -0400 Message-Id: <20230406113337.648916-9-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113337.648916-1-sashal@kernel.org> References: <20230406113337.648916-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 3dfc5c66f1408..a3078755939e3 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -989,10 +989,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:34:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:34:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518858.805808 (Exim 4.92) (envelope-from ) id 1pkNt5-0004Yi-D4; Thu, 06 Apr 2023 11:34:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518858.805808; Thu, 06 Apr 2023 11:34:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNt5-0004Yb-8x; Thu, 06 Apr 2023 11:34:43 +0000 Received: by outflank-mailman (input) for mailman id 518858; Thu, 06 Apr 2023 11:34:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNt3-0003Jk-VV for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:34:41 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04309ea0-d46f-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 13:34:40 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3DD046464C; Thu, 6 Apr 2023 11:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73C4CC433D2; Thu, 6 Apr 2023 11:34:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04309ea0-d46f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780878; bh=FyLMAWNPRcnaESuiKhWJ8kZc0wNVgsQO4bWtiLKhM+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZyTB2qmVRdeJYEe1AkE9jSXueWn3qkEgoSP1C47Qx/eiipH68OWecCWliK78mIAai LFSpTul+sm4j3wjuRghYvUAtMoDyf2qA7+NxuCoAr+BJ/Vv32cbGIldMlTWEoNeNJ1 QOHF6VM9vXmz6inUdpkLdQYuZ98FjKxYxjA6J+9UK3Ph5pzq91fFFf/VsUKJJhkk95 fCcY3a6W11lmsF9bls5tbHXrYAeDhOkiIxq+hVtAZMj5gB7g1oyqOdvktfMVVrYGS1 zMPjgYh22yHEvbF8fKUpW2zSXcQYiskZlzB4IFaGM8z5wwoBli11H+KL48MTl0Nwcb yOf0RawYxaYcA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 7/7] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:34:21 -0400 Message-Id: <20230406113421.649149-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113421.649149-1-sashal@kernel.org> References: <20230406113421.649149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 252414a9293db..a141db3f0dc7c 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -991,10 +991,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:39:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:39:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518864.805818 (Exim 4.92) (envelope-from ) id 1pkNxI-0005JT-Uu; Thu, 06 Apr 2023 11:39:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518864.805818; Thu, 06 Apr 2023 11:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNxI-0005JM-RI; Thu, 06 Apr 2023 11:39:04 +0000 Received: by outflank-mailman (input) for mailman id 518864; Thu, 06 Apr 2023 11:39:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNsl-0001qa-Cd for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:34:23 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9976a13-d46e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 13:34:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78EB96468D; Thu, 6 Apr 2023 11:34:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B342DC433EF; Thu, 6 Apr 2023 11:34:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9976a13-d46e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780860; bh=fHd5p+u3wf0voZ3oDttRIL4X67Yo6YPvWVEiI3rElds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kEWGd4RgSq03YTvEn7O6jvEUYCm9BsS4kA2Z3p0phclRBFfJd/F/qJqjZt7gMZ0kP XQRRBx4fVJ9UwU0akyxEjw0p2elkuFIgJEAvFZEPXOKUAZEVJfQ/6cr4xPzoip9F1o jP8NcTU8tTdAHgMpyNUFE5+4YPaxGg0lFOqJosnn79KgKc1MmFLNiRm6NeQQPuVcmm RyQYP4AJj/FlITLV8bTsPEB7P4ucqPmcxiX2a4RGxTntCrVRr3l4sk+WAkeq8MUr/K MdSUZP+goACcxZRbTRV9TqTVP2o0YVaNy2qpZSHQC4CLq3wWDh2i2Udqgc5FpaCQWb 7RZ3OxTrAxs+Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Paolo Abeni , Sasha Levin , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 8/8] xen/netback: use same error messages for same errors Date: Thu, 6 Apr 2023 07:34:00 -0400 Message-Id: <20230406113400.649038-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113400.649038-1-sashal@kernel.org> References: <20230406113400.649038-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ] Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@suse.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index ed644b6824cef..d2b79d7c0b881 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -989,10 +989,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:41:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518869.805827 (Exim 4.92) (envelope-from ) id 1pkNzZ-0006iy-AN; Thu, 06 Apr 2023 11:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518869.805827; Thu, 06 Apr 2023 11:41:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNzZ-0006ir-7j; Thu, 06 Apr 2023 11:41:25 +0000 Received: by outflank-mailman (input) for mailman id 518869; Thu, 06 Apr 2023 11:41:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkNzY-0006ik-Aw for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 11:41:24 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2df4311-d46f-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 13:41:21 +0200 (CEST) Received: from mail-dm3nam02lp2044.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 07:41:18 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6949.namprd03.prod.outlook.com (2603:10b6:a03:43f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Thu, 6 Apr 2023 11:41:17 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::48a7:d1ab:897:acda%6]) with mapi id 15.20.6254.026; Thu, 6 Apr 2023 11:41:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2df4311-d46f-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680781281; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=FSOJcFuyJLoPTZUkurwEgHtgOIn3wm4+zs0pUUG072c=; b=UdNLsgv7Zw0ebBotoJrJ/IXeVIfpuYHfruLA44e80NzD3zj1rlsi1IHT JIHAlaZVqbJrocWwtMycLCoc/bpuNfJiFtbBWJz2eQxGc28S6htlnc+MR Vv5qtikT5zc54E6klymWJYousWiOKnONZ3xYLtdmaRM92HG+Nm/cx/B2I 0=; X-IronPort-RemoteIP: 104.47.56.44 X-IronPort-MID: 104580366 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IcbTPaKBkrdRN7kPFE+Rz5QlxSXFcZb7ZxGr2PjKsXjdYENS0zQPx msZWWyObKuNYWCnftt1bo7g9UpVup/cnNZqTVNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5eI35D7 aVFEgkcTUGao8Lm+o2pY/dj05FLwMnDZOvzu1lG5BSBV7MKZMuGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTSPpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyrw27+Xxn2lMG4UPO2a/MM03wCZ+n0SVyELaUqYjcWlmmfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAHSThbYdBgq84yRhQtz FaCm96vDjtq2IB5UlqY/7aQ6D+3Yi4cKDdYYTdeFVdZpd7+vIs0kxTDCM55F7K4hcH0Hje2x C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2ONo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:Wb7A56M3QeUjxcBcTsajsMiBIKoaSvp037BN7TEWdfU1SL3+qy nKpp8mPHDP+VMssR0b6LO90de7Lk80hKQU3WB5B97LMDUO01HYSL2Kg7GSoQEJ00XFmNK0nc 9bGZSXQrXLYGSTba7BgTWFLw== X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104580366" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNotY7T17C5arjjADDIK3ynwFtruXaQ7q4h/OD3p/0r6yDIqG3JJD/g+e1g/KpQYZTMg2Bsybd2W7di75xTIQNd+IW5Plqe7GM2bBD/iXdr48jAKEVKYCXdAl2rOZhqRhYzo29tlvveVmCD6lAKC9nmOoNj0QK66/w661yeFnCFgFUYoD42bYiAjUrNhZYrQPHZieXrcgQV8Aqfe8N0y1q8fgxg7fEd/ncVigSZhu2a5pAiu6TqwPa9cAIJxqGKAfDRdq/UzoSIc52ctdq6jyTpU6FKQageiwCGLCnnnuWd28gzddwXw9852B6p+aELBFhdriuv2ve7eXVzKsXdVDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waqCQJYQpwRKwKZIL9b/VKrKkOu4lwBg+iCU1akNzjg=; b=oYzQEFjLYksgKWJd+UorPFNdZg7T0OHHgi5aa3/qeED2A5HPLcVlO5tBDN8gspmWigJ3cm2XwteQgAF0/VwfMrnJ/VQYHO1wi98Q7sUXI81hsB/IGSENv0RioWPCf7wHZUhbCVx9uHR3QBgOP5CdfChsSHqo4T+LgvQz9dBxOCwtu2NEV+/NT5iCS5dWh3AwwChVapk+XLDArRuEk3z1v/f+26g7OZFSxEaplVZLPRfV2iy+/jx0SkzXoqk7NxRkcT+TpvF2I/zgmkkwOL5mxGukTbwZ/tAcikKoqkT4tDntWGRaUs7Dwp+pk/WOY9nwHjpWlpHQjx0eLj4SabaSJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=waqCQJYQpwRKwKZIL9b/VKrKkOu4lwBg+iCU1akNzjg=; b=qBH5Jmh0SW1RvRPcbcu9JbI5+BSlpja7zNTjGKDBtuHnkUp9fEEuQrj3UzAR3u8nD0CEBkfss0QtrapPOibsGO1dS8jll+ZZVpUuZi5ZTUD+5OaqaagO/ZDPWhFXy6QCspTsWvXfNU3K2Mh0qfJswIJWrsaKBwuW/O+9ljpJP5Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH v2] livepatch-tools: remove usage of error.h Date: Thu, 6 Apr 2023 13:41:06 +0200 Message-Id: <20230406114106.54735-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN0PR08CA0001.namprd08.prod.outlook.com (2603:10b6:408:142::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6949:EE_ X-MS-Office365-Filtering-Correlation-Id: bd345b09-697c-4b94-987a-08db3693d501 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fz3dFpKXPppw55wCrR5kbp+aaFfUkUlR0L3yuLzzZVLlmfFu3LvHC44bomHaOgo7+2KpaH5wfSCIszAx0b7HgdkHnJbDYrv2yblU4aeDk+Y20K7VG6PHnioCtm73KvuFhUvUXCA4QOzHzZbkHRq8vgV1qbn2sU5+wBohPd2WUzUAezw9JoUpMVuG4n7+aiQ95N1PEVvyxJBsjnfug5i0hXEkN0Tvb+gOXLZAmAVx6BwmvpVvN/kcCU8ynsE5W958zcwehphvqmk5jnd64FI0O89FmsUhV3FuF6Jyw6nveXDJ8lFKdJfLsM/2ivWF9dRckCnnCNVMnk7z0igvHgZqKGRTqk2g6xwhXj33K45vIb0Atz21qaAXClyLTDSoqtDYv9gZ9xybsFX3MvxyGy7/iVN6Am5Q8EW3WPNHmIuBwxeMZ7daF4w7tmOGlbJEOHji/4gkugPx7kvhF2wj6JoSZcuqVf+4FWT/X5eMyZ4O4Gg95EykBo0/CdigzQUSfGeEoFMRYbs+ErUHCNkB664PcYwDXN2YHdXP9dlIN4k0hDC3TQdt2gjpXR6i1ZQVRaGi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(451199021)(26005)(186003)(107886003)(6666004)(54906003)(86362001)(8936002)(8676002)(5660300002)(2906002)(41300700001)(6916009)(2616005)(316002)(1076003)(66556008)(4326008)(478600001)(82960400001)(66476007)(66946007)(6506007)(83380400001)(6512007)(38100700002)(36756003)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTllRXd2NXFyQy8xYi9pcXRhYmpja3ZOSHlBSTZOcG5YZG1rNVhjNVZZWDJ6?= =?utf-8?B?UENlVzFNNlh5UGlTUWtCYzR4YVBBT2U1eGkvQWhFZjF3VzljWndCWjM1ZEFT?= =?utf-8?B?MlQyVlMycVRSNHZFSkl5aWJYL3JEMGk0RFpJMVIvQmhBclFHUStVQmtQOElZ?= =?utf-8?B?WjJ0RlZiRVU3VERKeVczaDM1MGRDWFc3emtpNng2M0hENkNMUXAwMk9xTXE5?= =?utf-8?B?VlI5L0xLVzBMRkYwSXB5WnRmQmVOUVA1QUFzRXljQmlsQzJXQnNaVE5aTHNk?= =?utf-8?B?ZVVFWUNJcExFaTl0V0dMQjNCRlVLQUJ4ZlBEV0xDUjhFUi9rYlk5QVJjd1k5?= =?utf-8?B?MUdONVZBN1dlakdib1ZiTnBtNWtSeHdZSzNhOVg1Y2E4YVgrNjVGRUhwNDMr?= =?utf-8?B?Z3lITEp6ZHBLOUp5cjBFWVBQUmYrSXUxc3hxTUZITFJYRjhtMWsxNGh0S1hV?= =?utf-8?B?dXpkMW5LaGQ2a1l4T1pISnNZc0EvVitRaEZ5aGphVVBDM2F3R1N0enZ6UlFw?= =?utf-8?B?NjB3eXRzeHZyekZFZVk1K2p1WTZzK09nNGlyZTNEbmxYQ0tBWEhYcmNTckky?= =?utf-8?B?QWx1YkhtWnFiV3dwcmlmVVBtYlV0SS9VZDlaN1U0VkNWbXNnc1ZRV3UzaDMw?= =?utf-8?B?amlXbGtEalBuZHBQa2hoUGhNQWFPQVFScUg0M2syVXh4RTd4UW5uSVMyNlll?= =?utf-8?B?L3lUKzVtcGFPc0VjK0EvbFVhZVppN3VERlJTYVVDcGdNYjJlQ1NnZ01TOWln?= =?utf-8?B?STN2MXROL2N2VmlMdGxaVzFPZllSLzNWK0V1c2JpeUZHNzJIcERLR0RIZmJ0?= =?utf-8?B?VFVuUUZHVkNQMGlTTWVEdy9LdnpvTjJjVllTd29lUk9pZ2NrbTdZd1ZIU2R4?= =?utf-8?B?VDNqWVhLNXN2WGhzcGhYRG1CVUpGc2NYSUN3bW96ZHdoclhJc1hQSmptVU8w?= =?utf-8?B?eVY2V3hFdTZNaG8zVHM2WERsOWVHYjBCZGhHbFd5N0tzazFQNW9McmxwdklC?= =?utf-8?B?TUpZdmZhT1BSc2dNN0w3TjR6bDFHK2R1NUhnb2xyUGgzNFc0d09nVlVnc0VZ?= =?utf-8?B?U0ptUlNWUCsyNHR6MGxYbmpaY1JkNVFLZGtaTmZjeExwWVkxcDM1VE1ZUlZx?= =?utf-8?B?UFJoaE5DR010SE15VDhuUXBrd1ZTdldYQ3FJMXlQYzY2N21rMVMrQ2JXeUti?= =?utf-8?B?N21Idm0wS2g0QVp2NkdBQ2hNVTVRMlJMZ2xkT2NDYmJBV1VxM0MxQ0NuZWdB?= =?utf-8?B?RWlJSjVmVW5WNFdGWUh5L2sxdEdJTU1ZR2dBS3ZLbmQ3NUljL0FKcmVaWFJU?= =?utf-8?B?SXZRSjh3SkdCeUFWWFpqZjJGcVJmUTJnWkxUZU1EdERjQnhUNkdsbjdOS015?= =?utf-8?B?ejdmWndUUTRMNENBemNERVNsdnV2UG9DbE0wVmlsSm1yWFF3QllrZ3RFQTBu?= =?utf-8?B?NjlqSUtyVXhaSlVidDVvNXM2OXVDbndkTk5QR1o2UUxTVkVMY1NFU05IT3hV?= =?utf-8?B?NTNvQTUzOFZlblBUMjJRM0NnV2hXUjlacm8vY3FZZWZuUFhBYUx5VEl6WXpI?= =?utf-8?B?Lzc1RHBSMHB2RDhrODRHanZYYXdvMjdBd1ZyWVJLSHR3dDBib1BoM2s2YmF6?= =?utf-8?B?QVVsYWVUcy9DNDJpQ0piVkxBaTFLWDFUaTk3VjNrYmEwMDV1aHRESmFPVUYv?= =?utf-8?B?NGtzcjV2THF5U0NhMWc3a1BpVWptTmtHRVVyL3drUEI4anNFTDdkQ2pUOFRQ?= =?utf-8?B?cUlsdFNlcWV1OEkzem5QM0Y4QjQ3TjQzcXBQTEZxSFJCMytRS2RDQmNtakNB?= =?utf-8?B?eWwyM21yRXlXTlkrbnBPVldKNjVqdm9PcnQwMXVHYWZORGZKUmZNLzFwMHo0?= =?utf-8?B?U1A2REtGNmZrbU5DUHkrYnNzeFFoazRoODA2N2M1M2loeDF2bjFGUHJNME9J?= =?utf-8?B?UnV2N2RNN212Tk5uMjhpYitldExRN1RVSlpSY1F3bFh5UHk4d1lIeTBLYUcv?= =?utf-8?B?UmRqUTYwUDJTNmlkc1I1RlFQdnpYdkNmNlg5T0ZzYTRNMUxjZlpXZWUxaTE3?= =?utf-8?B?MzZHeU1BeXpRMFVrZytpdE9xMllFeEhaV29lWFg2dWdTSXBEWUEzNnpGYXhr?= =?utf-8?Q?Y8cmuN8z6DAoaD+U9cnkpKttI?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Msqkiko7HtJFsnd6KhtuWpRvgqTSNZjtq+2fv/mfS+FAt2eSuH0nobm4x/tffLxgHxGSQ8ZDb1gh+SInPYnqkHh/MKNLjKV5lRimOTlDVmaYue34NNlMPsXt7UAs0vjjnePd1SjptMl717bQOEHXv21eId/YvAz9VDkLsrK1RrN+HTuCRMwxpgLdYEzOKIRwJqV7jsjAassuF4l1wCGfazylmysi8Cjfg/eMxyXUvg6yPja9Reo9YqYADULSxwX0swBlZQg0V9cvo3wBB96/2CSUKTTerCuS2Tg12FZc4kvbLK1k7TWNqfU0jtSDegaxN5srCBdTsBwuFPQCYEFf9KkL06qoIHU9clEYIkxzDLY4vOSBmu4gYMaW+999Moe7JNNLAX3qK6gDypYy48YDtLX+9cXy0UaOT+2KynHYR+XcvGOhUyebbdHKbyjQegVj56fNTaOHD4g3H9O6/zpUQgB97LqXrYI6I8l2WSQWXxFYeRtjjp8d3dy0sQJExx+6ML7lrSjKRLHKlPHcGnTzDNaa6dIekbwy2ZMzjhPTShw5n/Q2Sl1HkCGYxhGy2OLpIeKisTdpKjmAKeWUboMMiNoEMtFUGsycmeYlP6nTqBOuK7MYD5GymzXRi8GgMk4ntlM2J7ju1LGkUaTMTpfrSZJbam4exabSBckfNmdQcULQFFTKyKFfy1cu8Bu6dEYfCWmvByAi68yF1xKB0ghH+ZcXYUOc2hPxeABNnTvmpNpqpVHsr8daYdPaPFYDpqaEv6qRbu71yvV+v51WS+RSuP5zeXmkuSPZ76UAaKinsMbjbTCcy6rB4qbdK5EBvJi7 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd345b09-697c-4b94-987a-08db3693d501 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 11:41:16.8040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2OHCIy5rjj/eTxstseBPzwbouXinUgoFwC9dxeabwWXUYcr2PFFObgQdxG4Z8VVSoD1N6nJsBcYBSb/KF+aeIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6949 It's a GNU libc specific header which prevents building on musl for example. Instead use errx() in ERROR() and DIFF_FATAL() macros. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc: Ross Lagerwall --- Changes since v1: - Use errx(). --- common.h | 9 ++++++--- create-diff-object.c | 1 - lookup.c | 7 +++++-- prelink.c | 1 - 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/common.h b/common.h index 9a9da79..bbaa950 100644 --- a/common.h +++ b/common.h @@ -1,18 +1,21 @@ #ifndef _COMMON_H_ #define _COMMON_H_ -#include +#include extern char *childobj; #define ERROR(format, ...) \ - error(1, 0, "ERROR: %s: %s: %d: " format, childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__) +({ \ + fflush(stdout); \ + errx(1, "ERROR: %s: %s: %d: " format "\n", childobj, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ +}) #define DIFF_FATAL(format, ...) \ ({ \ fflush(stdout); \ fprintf(stderr, "ERROR: %s: " format "\n", childobj, ##__VA_ARGS__); \ - error(2, 0, "unreconcilable difference"); \ + errx(2, "unreconcilable difference"); \ }) #define log_debug(format, ...) log(DEBUG, format, ##__VA_ARGS__) diff --git a/create-diff-object.c b/create-diff-object.c index 780e6c8..d8a0032 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -45,7 +45,6 @@ #include #include #include -#include #include #include #include diff --git a/lookup.c b/lookup.c index 39125c6..9633ea2 100644 --- a/lookup.c +++ b/lookup.c @@ -28,14 +28,17 @@ #include #include #include -#include +#include #include #include #include "lookup.h" #define ERROR(format, ...) \ - error(1, 0, "%s: %d: " format, __FUNCTION__, __LINE__, ##__VA_ARGS__) +({ \ + fflush(stdout); \ + errx(1, "%s: %d: " format, __FUNCTION__, __LINE__, ##__VA_ARGS__); \ +}) struct symbol { unsigned long value; diff --git a/prelink.c b/prelink.c index 2039e5b..18c5159 100644 --- a/prelink.c +++ b/prelink.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 11:55:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 11:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518873.805838 (Exim 4.92) (envelope-from ) id 1pkODF-0008Im-HE; Thu, 06 Apr 2023 11:55:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518873.805838; Thu, 06 Apr 2023 11:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkODF-0008If-E4; Thu, 06 Apr 2023 11:55:33 +0000 Received: by outflank-mailman (input) for mailman id 518873; Thu, 06 Apr 2023 11:55:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkODD-0008IV-SW; Thu, 06 Apr 2023 11:55:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkODD-0000it-Pv; Thu, 06 Apr 2023 11:55:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkODD-0006QK-As; Thu, 06 Apr 2023 11:55:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkODD-0000AV-AL; Thu, 06 Apr 2023 11:55:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UqB+yz6/8FouBPCs62FcLaZy51fC8d0roc/O0QwAfrA=; b=J6kMLmu6CcVIBCzfzMp6udlC1a 4H2165MNnbc4XNRWY7EXg50oYitTJlFnF2/3F7GvetPksS5KA6GVktvT3E/D2WQCpNY/TNPGnxLfV VZE3HvT19zHKP8QKTw1h9tG7fgozpY5FZATa/QivBsWq3tAZiGgcnme+oMjvSMnHjMD4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180159: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=99ddf2254febae9eab7fb0bcc02c5322243f5c49 X-Osstest-Versions-That: linux=76f598ba7d8e2bfb4855b5298caedd5af0c374a8 From: osstest service owner Date: Thu, 06 Apr 2023 11:55:31 +0000 flight 180159 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180159/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180145 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180145 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180145 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180145 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180145 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 99ddf2254febae9eab7fb0bcc02c5322243f5c49 baseline version: linux 76f598ba7d8e2bfb4855b5298caedd5af0c374a8 Last test of basis 180145 2023-04-05 00:11:48 Z 1 days Testing same since 180159 2023-04-05 18:14:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel Bristot de Oliveira John Keeping Linus Torvalds Masami Hiramatsu (Google) Mirsad Todorovac Steven Rostedt (Google) Tze-nan Wu Zheng Yejian jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 76f598ba7d8e..99ddf2254feb 99ddf2254febae9eab7fb0bcc02c5322243f5c49 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Apr 06 12:03:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 12:03:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518880.805848 (Exim 4.92) (envelope-from ) id 1pkOLC-0001Pp-HE; Thu, 06 Apr 2023 12:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518880.805848; Thu, 06 Apr 2023 12:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkOLC-0001Pi-EZ; Thu, 06 Apr 2023 12:03:46 +0000 Received: by outflank-mailman (input) for mailman id 518880; Thu, 06 Apr 2023 12:03:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkOLA-0001Pc-87 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 12:03:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 110cf3b7-d473-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 14:03:41 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 08:03:30 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6987.namprd03.prod.outlook.com (2603:10b6:a03:43b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.28; Thu, 6 Apr 2023 12:03:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 12:03:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 110cf3b7-d473-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680782621; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=eU7mxl30llzqrhO3LN68GckiTQC15SCNsmT0mt0lHKk=; b=RsmdA1coAMUTfAEsi4DV7EJkcr/XSdVJUcVWzGtjVv5KGdXJ45HhCNQJ zFdG7dpn8q9uKX9RS/QRsBziWSYiKKCCEqizNlYFsi/OCdSVgki7cUNmh WQ121H2bHvFYOAxnLHLt/t3s+2Kp0DeXaZKc1d5Lh6wXedW1AbaqjWD7k U=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 103916226 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FRPVnK/EILh/rvNOooCrDrUDpH+TJUtcMsCJ2f8bNWPcYEJGY0x3n GMaCGuFbPbeZ2bxco93YY7n/EhXu5DdzoNkHANp/is8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagV5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklkq PZJJjUzViqogues6ai/SeJvqMsKeZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpi9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpJReTmrKQ06LGV7lc2JgIzXHn8m9ughUCcX5VfF FEU4xN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc1Qjow3 1PPgNLtBhRoqrSeTX/b/bCRxQ5eIgAQJG4GICMBEw0M5oC7pJlp10qUCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb/D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:d7TxqaDGWC6cKLHlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="103916226" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTrJRnWWTdBIZe9cID1HrVYEwuVs1kjWJsCkk/VDHpCXDubzlEAetgOxHYrZjxU9k53JekxQdjocgkyhUel+V7GPbAcgORyP91wpp5gRZYFLLR0tX55DEPyN/IYKprrxlwdgAkeX4Ft86p8gfhgqrriMn6F+QhzCUmXpl1xUslKFxg2QLxCj5ienJgDwWiShm8EwdfZDHNJZIjMlfvBBYxdfA4U0x+BWfQ7PwElqDvcqcQZNkbkBkqmnOOvxBllMp7/yVQGSY+ElBIOMuWz2UKjKmT15rk6L8quA+Kg3TDMjAed8ktxlzuhfEKZ5iFHWsmzWk8ABP9IOhd1FdaIuaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6i38wPZdc2HHQZDfVFyx6muok1UOMPpytAyqDoQ5UiU=; b=huPk0GdIFidvY78QhSIK1PJBqR9UbA5G4c0VhKON1juM459RyoZOk/O/ZO3Md5jMY4ojfQRATRs48l09O8MCP891JJlQGjGfPTE4EmhiUGFPIC27Z13yGTQY0hRyyhlQcAbBKtJxPkXLpMloZ6HYo/qCydL3MR1YOC5ilLH02V9qBlADXmCuy7x725k4i+6N4e4N33B99StETO9AbcUNyM/706TGHvn4nmOQ5FveRrE6QAfdXQWUQWKuoKQGg+J978y0IRld7HpjnrL8ALtvaTgmN+O7esaCrHB+SAOAZVs3s/oh9K5Sie4/vzkn0EZYmIIuQ/O4y8CrtDZd2NZifg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6i38wPZdc2HHQZDfVFyx6muok1UOMPpytAyqDoQ5UiU=; b=RrCF3KP2eeOX71SIYDrm34Us1n/6qH7VKSBOUyHb5n3QIzWYh+NGEGwoLV78Q177IyVtrd+aAYO/GM7cr+LcGQJDJHrm/A2/9F7a6fjdBrivQtNe/Weq1k49erPrQWQmZE7OcTpNITi5rFLG7QP+ZFXR7lxMHpsUDaa8JlUchG4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 6 Apr 2023 13:03:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2] livepatch-tools: remove usage of error.h Content-Language: en-GB To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Konrad Rzeszutek Wilk , Ross Lagerwall References: <20230406114106.54735-1-roger.pau@citrix.com> From: Andrew Cooper In-Reply-To: <20230406114106.54735-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6987:EE_ X-MS-Office365-Filtering-Correlation-Id: ad3f8de8-525c-45d0-37bb-08db3696eb15 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: feejIuUdtno+9H2vaqMCxKylL2bt6/bDgzqdIS4MeAvyPJJQ+iYDqMRckyUKa88x4ceCERnQxCAPv9qvWF68d3urdRM6nbvBs33dAWzEF6KAOUcWKhS1K+Ybm/zd/IrxF5ZfZCHO/8d4ZcrDt8z4wik8e5aUYRbS6U+fxavvWHx08Y6627DrB09rhIFAmG/BBfg27GqqN167rtmVOcv0lH7e5fjt+mbyJyuqa6gLw5Gk9Y7Ced3je6NltqSIfch3F/b+n4nQ/BtZQtt1tYGsz0b8x194dsNfdkDtOBD3MJdeyUcHM4T/+id/WRfrrPHzhDAXE4v/k9t/eqCamMI5FB9qkAawX1r6OTqxMhzDVDtC7RUXCi19be8nuwlTX1iJPXONkGCV0wr+JF1B/EuF3LRnP90vBPPXaQ7tA+1Z57N0VdVC9drZy7VqDPLb4yrUgVnT7fO/mExKUhW/jIHGIfiG0gC6gxjVy2dU4ThJJiAeC/xn0a+9IoAZ3m2bx4am9mWTKpjTt7B/1qA5KMXC6MRxA08zeBh/vmcrS9ix8klo0GmarUywZCtMvpJx2LxQ5iMOZxfNDkIh6j0KLy0mgu8BIaatmeqy6UKULurGGAjw0w0BCL6HmbHAa3DRVrJgSNMM5Hx23opPBPs1QoJqmA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(31686004)(38100700002)(66946007)(6486002)(54906003)(36756003)(41300700001)(316002)(66476007)(66556008)(6666004)(86362001)(31696002)(558084003)(4326008)(107886003)(26005)(2616005)(478600001)(2906002)(8676002)(6506007)(8936002)(5660300002)(6512007)(53546011)(82960400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlU5YjdGRTJJN2g3UFVlYzBmMkN2Y0NCTWVjRGN3RGRLQnJrRURySHhWSy9W?= =?utf-8?B?cnduNVhndzhxaTU4VGg4L2lkQmY5YUhuS0ZWNG5wcllvbDkwM2Rsdld0UkZI?= =?utf-8?B?OVJCSUFjdUpSMFNZelJzd1pZQ09pcEUvaWpVZDNCcGVGVUtWeHloM2oxQzR4?= =?utf-8?B?SzdDUlNsaEp1ckdKalBQenNaNHFJS0ZXblF4REVkcUVJODU0TFdxTEVNNUk5?= =?utf-8?B?QmYwbUtiVVdpeG0vSE04TFJ4d3FsNjZramlHdXBGQmgrU3pNVmJtZjFyZ2Ry?= =?utf-8?B?Yk0vK0dzWVRFcEFSVzA3aDdQVnRtU01vMXdZUllSc0dGcHFsbE1vM1VxRG8r?= =?utf-8?B?VG4vM3VMR1o1VGdRaEdtaUlrc2tuSnVNU0tyVkdYaXoyYis3b3Jkc3hDV1R1?= =?utf-8?B?VkRWRWhLeWtDcDZHNDVoeVVLa1llSDNhcHhiYnA3Z2R3YjJ4RWorTFJjNzYv?= =?utf-8?B?ZndmU1lyazgrQUlnYmlxdkRNN2FyRVhPSFJZNTljVkVZOWc3WVRuR1R1ZkRt?= =?utf-8?B?aGdxdFNLeERhSVp0S0wraTBDN2Uzd0hNMWxZTVJNNU5mbjNsNkhtSG4rY0Ev?= =?utf-8?B?VjIyWXdNMVFCSGZrMXkyTW1MeVNvZ0NHVk0zbGhJV1p2NEllQlAyakpUTDYz?= =?utf-8?B?VVlja3hHdS85emxWYXk3dCtGS3BFSmNGdnVlcmhUTlF0NVdmS2toMjA4L3Zr?= =?utf-8?B?WWEwTTNYUzFDNkx1cmIxeVZRaldBT0tsWDMxR2ZpVzRpUGR1eWFOemtlTU1s?= =?utf-8?B?NWVqK2NNL2h3ZGZBWXk0bHN1SFFSWVNBMmIrQ0VvK0I4d2F1R1JrKzVEZnQr?= =?utf-8?B?Q1NRTnJiVEoxU09YellLemVOOGNua3I5aEhHS3lhaWxtK3Q5Q0QvN0hqN2Vv?= =?utf-8?B?eEE3cncrMjJyK3F6cGNkZUpQdjh1azlIcElaalpDc1RVQTZyelRWYUhGZlRk?= =?utf-8?B?dUpUSWhNMWZNZG1wamd3SDhxZys4OW13N0ZpUTYwY2x0OFlja0dxZlUrakwz?= =?utf-8?B?RzF4N3dmWVAwcDhCTEVxWHkzVGhILythcHp3Q1Ivd1UrY2ZtUTg3R0xKUUNF?= =?utf-8?B?T2FIQ2hCRnRKSER4QzVaZnEycm9yVkI2cGsvTU85Nml6TDc1SFkzc3doZ0Rn?= =?utf-8?B?VnRlZEd0WUthNW1pbmkxcjlLK2d3OXJsVFg1cSsyZWFOZUxTRFpTWWlLelgz?= =?utf-8?B?aHMyVXJjMXVPcUhrVXRFdFhvK1FUMm9zYVZjRkVhd1JWMWpHbnJJVXkrcTVI?= =?utf-8?B?SjRIY2cwTng5eTR5UGptNVV6LzUrbUVEMEVnUCtMMUtZd0ZJOWxQU3lBSjVZ?= =?utf-8?B?RnFUM004ZGVZL2NpZlBRc29DUFRZZUFZeHUzeDM2Wlk0d2N3K0xabEhWekpM?= =?utf-8?B?VFRaSUlDcEczYlJ3dWFNWDBLQjBnai8xZlJ4UUk2Ry9CNlpBVFhqb3dVeTI1?= =?utf-8?B?SkxualJtNFlpUW4xSlEvd2NSNU5XbzJSajNVUEtyaHpYc0VSdVNwbjhuYjQ0?= =?utf-8?B?RWZHYXdMMVh0WVkwVnpKcFcybUFWRFVVZFVhTndsY0lrTzhadW94YmQrZmhP?= =?utf-8?B?bURCSTRPU21QcG9hUmZ6Q25XYlhPSXJBS1EwUTNjVktVOERVakJxeUZFMGpX?= =?utf-8?B?VDJuZmhiTWNyNmRWWlZWdDBtS3dQb1BsMTVOYmp2NUttU01NN1lkSVpIY3px?= =?utf-8?B?eFJVVCtTYXZMbnA4THNRK1VxQzE3TUE3R3BxbjUzZm5RUWM5TWIrbUF5K1Jp?= =?utf-8?B?NTRlV2hjd2cySGNZTkRpS2czZk9vUG16TWVnTjZ1aDlEQ21UYktmOVNMZVNR?= =?utf-8?B?RnFvQ3piTEZUTVBRTWJUM1hLRDJFS3dZbzNjUUoyZHFQdjJ2eHd0T2hnWE5t?= =?utf-8?B?N1lQU1lTZUx5NjM1TDJqMzY3aEhKaGxCOGswZkQ0WVhGRWIzYmVMVCtlMnBR?= =?utf-8?B?N3Y4ajBRcTgrcnYrRjZWNzhNNDdDWDRZbHdVUk4zdWhxdU1YcS9tbk1QNmgr?= =?utf-8?B?KzhYREd2VmlDdDJobjZneWNtSGxFd1creEZyZTB0NnRQYjFjcm55YjZNeHBO?= =?utf-8?B?cEFQQjRCQmQxLzBBUkhRa2ExRWJEcnN5SFFSSkwrTU9pNlFSZDU4VCtmdmhx?= =?utf-8?B?RHR2SXRZaVhLaE91VjJGWGluUkRiaTVmQUlpSkNjVmxkUUNNOVU0M0F3N2sr?= =?utf-8?B?NlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: c9NATHlX099kTY5/bfjafgXO94OWI+TAy6VTyXdtiEioicngMx8bhVboCJuoxSa2A4U/r0TcyNYQr2CQw2vyvQdWSCvXO+nwZiWVUJV9wNbJSS+6zhwNnDhFjnXhj1HyPHXmnvXfaDE+C71DcR7Y6u60CE/Nn5WKqGtunckDD6jI5XtLKybbhgvJxrAcYd+Qep7fKLKZ5rzFwecgwnU1ZhlVLOh2yhDsj80b0K5DsswdYPLF8XZR1rYUyGZUUs130MAiE1EY4/U7edn4E/b9+2vXC9I5tBlRyDlWv7j3KmW+RfNT61NhuVMaVxkYdgueQ7qq4R6uaOtYdWS6bcOjAthVYMW4JYXe3yr2c5w58JRLv13YuVfui6mDuiZi9XOrWoiqLrvLk+Id/7/SQM0DrqdQyTRVI6vGlu/2Vr/ZtCVTBsocqKE2jKAOXb1e26b0Tj6ENuE07X7oJKfii8MjNFkmnbg84KKcMIwtpvzOyPc4XKm8rwEx7S4xl3fD1SJy6MhLjenSIxUiYl+8C/9uPp1TBEZ2zClgwHABfJR/PxZo9CUWm2IFddHQ8qSg7ZNGWn0nFRM5JWChqPQ9ZQwoHavVGwK/EjzDTxT/uS87z7+sNjAHESUtfjMR1GkQQWN0o+VADtAgNJxxkZj4z6LIv5RZxVmGxYJFapA40xuaitVBxYJ58rlAsXOEeNWOIDkjF7HtJSF9SbOy4+frAo/153AMLRPBPTh5TdooxMQarpBcOiLF+vg7BxAUuFzQoY34fRuT35ygIQQJrn+qg/JlSst6aadncuIn6gmiLtFF0iYaNixidnk6bKEOswUwGnFt X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad3f8de8-525c-45d0-37bb-08db3696eb15 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 12:03:22.6327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XXfAgakRayJAD1BS3vL5Obk7GYlbbIHKFzZ1wjfg4KzSGOSLu4IZW5DxyamHlgn09yzQzvVs3m2uQo8JDl0cJ1x6oOtuTPM2K3tyYUNbdzQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6987 On 06/04/2023 12:41 pm, Roger Pau Monne wrote: > It's a GNU libc specific header which prevents building on musl for > example. Instead use errx() in ERROR() and DIFF_FATAL() macros. > > Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Apr 06 12:18:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 12:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518884.805859 (Exim 4.92) (envelope-from ) id 1pkOZ2-0002x1-Oz; Thu, 06 Apr 2023 12:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518884.805859; Thu, 06 Apr 2023 12:18:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkOZ2-0002wu-Jf; Thu, 06 Apr 2023 12:18:04 +0000 Received: by outflank-mailman (input) for mailman id 518884; Thu, 06 Apr 2023 12:18:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkOZ0-0002wo-L0 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 12:18:03 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10d84c89-d475-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 14:17:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10d84c89-d475-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680783479; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kLcrD6Qx/8oKyhJYXTcLhHRibh3zjUkt2HxDgLq/hoo=; b=fpbF+zfMqGb3S/LWSVfuA3cx2OxWT0k40ByJnRa52Jfk8vT8ZY3ENxKv oB3fetyL1J2hfz/2gOY/fm7KgJ8mtqI50BiQgUsIvv9GyisokmDFvwPM/ KMJsCZCr2WEBVQ2esH+VJ3TpGPJzqXhK9NdT1DjRGcsvAY1hEQF+mvkPq 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103918414 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:C4g1DqrxXY7lp2l4gRTEabTcq4ReBmJnZRIvgKrLsJaIsI4StFCzt garIBnTbPaCZmD2ft52bYWz90MGvZ6DyNVgTwQ4r3o9RChH8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzydNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAC0Obh2Govm2+rucDdZ1md4ncti0GJxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj juepDWgUk1DaLRzzxLc8VWjpvTLtBn9VaMQEab71+x3v2yMkzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyMY4NnupaQojijGaZFcCbGvioPkRhXvl mXiQDcFu1kDsSIa//zlrQiY2W/2+8Ohoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawTYu8B66FMYcXPvCdkTNrGwk3PCatM53FyhBwwcnTx 7/AGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+ieD2TCfMGd843K6mMrhRAFWs/F+Er L6y9qKil31ibQEJSnOLqdFJcw5bcyBT6FKfg5U/S9Nv6zFOQAkJY8I9C5t4E2C5t8y5Ttv1w 0w= IronPort-HdrOrdr: A9a23:/Smpl66jdeKQhteUdAPXwPbXdLJyesId70hD6qkRc31om6mj/K qTdZsgpHzJYVoqNU3I4OrwXpVoIkmzyXcW2+Us1N6ZNWHbUAHBFvAa0WKI+VLd8kPFltK02c 9bAspD4NCZNykcsS7xiDPIdurJz7G8gcSVuds= X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="103918414" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/emul: Use existing X86_EXC_* constants Date: Thu, 6 Apr 2023 13:17:53 +0100 Message-ID: <20230406121753.2205968-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... rather than having separate definitions locally. EXC_HAS_EC in particular is missing #CP, #VC and #SX vs X86_EXC_HAVE_EC. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/x86_emulate/x86_emulate.c | 608 ++++++++++++------------- 1 file changed, 294 insertions(+), 314 deletions(-) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index c69f7c65f526..8aa23b929c07 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -135,28 +135,6 @@ static const uint8_t sse_prefix[] = { 0x66, 0xf3, 0xf2 }; /* MXCSR bit definitions. */ #define MXCSR_MM (1U << 17) -/* Exception definitions. */ -#define EXC_DE 0 -#define EXC_DB 1 -#define EXC_BP 3 -#define EXC_OF 4 -#define EXC_BR 5 -#define EXC_UD 6 -#define EXC_NM 7 -#define EXC_DF 8 -#define EXC_TS 10 -#define EXC_NP 11 -#define EXC_SS 12 -#define EXC_GP 13 -#define EXC_PF 14 -#define EXC_MF 16 -#define EXC_AC 17 -#define EXC_XM 19 - -#define EXC_HAS_EC \ - ((1u << EXC_DF) | (1u << EXC_TS) | (1u << EXC_NP) | \ - (1u << EXC_SS) | (1u << EXC_GP) | (1u << EXC_PF) | (1u << EXC_AC)) - /* Segment selector error code bits. */ #define ECODE_EXT (1 << 0) #define ECODE_IDT (1 << 1) @@ -360,11 +338,11 @@ do { \ #define validate_far_branch(cs, ip) ({ \ if ( sizeof(ip) <= 4 ) { \ ASSERT(!ctxt->lma); \ - generate_exception_if((ip) > (cs)->limit, EXC_GP, 0); \ + generate_exception_if((ip) > (cs)->limit, X86_EXC_GP, 0); \ } else \ generate_exception_if(ctxt->lma && (cs)->l \ ? !is_canonical_address(ip) \ - : (ip) > (cs)->limit, EXC_GP, 0); \ + : (ip) > (cs)->limit, X86_EXC_GP, 0); \ }) #define commit_far_branch(cs, newip) ({ \ @@ -431,7 +409,7 @@ int x86emul_get_fpu( return rc; generate_exception_if(!(cr4 & ((type == X86EMUL_FPU_xmm) ? X86_CR4_OSFXSR : X86_CR4_OSXSAVE)), - EXC_UD); + X86_EXC_UD); } rc = ops->read_cr(0, &cr0, ctxt); @@ -444,13 +422,13 @@ int x86emul_get_fpu( } if ( cr0 & X86_CR0_EM ) { - generate_exception_if(type == X86EMUL_FPU_fpu, EXC_NM); - generate_exception_if(type == X86EMUL_FPU_mmx, EXC_UD); - generate_exception_if(type == X86EMUL_FPU_xmm, EXC_UD); + generate_exception_if(type == X86EMUL_FPU_fpu, X86_EXC_NM); + generate_exception_if(type == X86EMUL_FPU_mmx, X86_EXC_UD); + generate_exception_if(type == X86EMUL_FPU_xmm, X86_EXC_UD); } generate_exception_if((cr0 & X86_CR0_TS) && (type != X86EMUL_FPU_wait || (cr0 & X86_CR0_MP)), - EXC_NM); + X86_EXC_NM); } done: @@ -776,7 +754,7 @@ static int ioport_access_check( return rc == X86EMUL_DONE ? X86EMUL_OKAY : rc; /* Ensure the TSS has an io-bitmap-offset field. */ - generate_exception_if(tr.type != 0xb, EXC_GP, 0); + generate_exception_if(tr.type != 0xb, X86_EXC_GP, 0); switch ( rc = read_ulong(x86_seg_tr, 0x66, &iobmp, 2, ctxt, ops) ) { @@ -784,7 +762,7 @@ static int ioport_access_check( break; case X86EMUL_EXCEPTION: - generate_exception_if(!ctxt->event_pending, EXC_GP, 0); + generate_exception_if(!ctxt->event_pending, X86_EXC_GP, 0); /* fallthrough */ default: @@ -799,7 +777,7 @@ static int ioport_access_check( break; case X86EMUL_EXCEPTION: - generate_exception_if(!ctxt->event_pending, EXC_GP, 0); + generate_exception_if(!ctxt->event_pending, X86_EXC_GP, 0); /* fallthrough */ default: @@ -807,7 +785,7 @@ static int ioport_access_check( } generate_exception_if(iobmp & (((1 << bytes) - 1) << (first_port & 7)), - EXC_GP, 0); + X86_EXC_GP, 0); done: return rc; @@ -854,7 +832,7 @@ protmode_load_seg( uint8_t dpl, rpl; int cpl = x86emul_get_cpl(ctxt, ops); uint32_t a_flag = 0x100; - int rc, fault_type = EXC_GP; + int rc, fault_type = X86_EXC_GP; if ( cpl < 0 ) return X86EMUL_UNHANDLEABLE; @@ -982,7 +960,7 @@ protmode_load_seg( /* Segment present in memory? */ if ( !(desc.b & (1 << 15)) && seg != x86_seg_none ) { - fault_type = seg != x86_seg_ss ? EXC_NP : EXC_SS; + fault_type = seg != x86_seg_ss ? X86_EXC_NP : X86_EXC_SS; goto raise_exn; } @@ -1163,7 +1141,7 @@ static unsigned long *decode_vex_gpr( switch ( evex.lr ) \ { \ default: \ - generate_exception(EXC_UD); \ + generate_exception(X86_EXC_UD); \ case 2: \ break; \ case 0: case 1: \ @@ -1273,7 +1251,7 @@ x86_emulate( generate_exception_if((mode_vif() && (_regs.eflags & X86_EFLAGS_VIF) && (_regs.eflags & X86_EFLAGS_VIP)), - EXC_GP, 0); + X86_EXC_GP, 0); rc = x86emul_decode(&state, ctxt, ops); if ( rc != X86EMUL_OKAY ) @@ -1302,7 +1280,7 @@ x86_emulate( #define state (&state) elem_bytes = 4 << evex.w; - generate_exception_if(state->not_64bit && mode_64bit(), EXC_UD); + generate_exception_if(state->not_64bit && mode_64bit(), X86_EXC_UD); if ( ea.type == OP_REG ) ea.reg = _decode_gpr(&_regs, modrm_rm, (d & ByteOp) && !rex_prefix && !vex.opcx); @@ -1420,12 +1398,12 @@ x86_emulate( generate_exception_if(lock_prefix && (vex.opcx || ext != ext_0f || b != 0xc7 || (modrm_reg & 7) != 1 || ea.type != OP_MEM), - EXC_UD); + X86_EXC_UD); dst.type = OP_NONE; break; case DstReg: - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); dst.type = OP_REG; if ( d & ByteOp ) { @@ -1477,17 +1455,17 @@ x86_emulate( d = (d & ~DstMask) | DstMem; /* Becomes a normal DstMem operation from here on. */ case DstMem: - generate_exception_if(ea.type == OP_MEM && evex.z, EXC_UD); + generate_exception_if(ea.type == OP_MEM && evex.z, X86_EXC_UD); if ( state->simd_size ) { - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); break; } ea.bytes = (d & ByteOp) ? 1 : op_bytes; dst = ea; if ( dst.type == OP_REG ) { - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); switch ( dst.bytes ) { case 1: dst.val = *(uint8_t *)dst.reg; break; @@ -1499,7 +1477,7 @@ x86_emulate( else if ( d & Mov ) /* optimisation - avoid slow emulated read */ { /* Lock prefix is allowed only on RMW instructions. */ - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); fail_if(!ops->write); } else if ( !ops->rmw ) @@ -1730,14 +1708,14 @@ x86_emulate( case 0x62: /* bound */ { int lb, ub, idx; - generate_exception_if(src.type != OP_MEM, EXC_UD); + generate_exception_if(src.type != OP_MEM, X86_EXC_UD); if ( (rc = read_ulong(src.mem.seg, truncate_ea(src.mem.off + op_bytes), &ea.val, op_bytes, ctxt, ops)) ) goto done; ub = (op_bytes == 2) ? (int16_t)ea.val : (int32_t)ea.val; lb = (op_bytes == 2) ? (int16_t)src.val : (int32_t)src.val; idx = (op_bytes == 2) ? (int16_t)dst.val : (int32_t)dst.val; - generate_exception_if((idx < lb) || (idx > ub), EXC_BR); + generate_exception_if((idx < lb) || (idx > ub), X86_EXC_BR); dst.type = OP_NONE; break; } @@ -1760,7 +1738,7 @@ x86_emulate( /* arpl */ unsigned int src_rpl = dst.val & 3; - generate_exception_if(!in_protmode(ctxt, ops), EXC_UD); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_UD); dst = ea; dst.bytes = 2; @@ -1957,7 +1935,7 @@ x86_emulate( dst.type = OP_NONE; break; } - generate_exception_if((modrm_reg & 7) != 0, EXC_UD); + generate_exception_if((modrm_reg & 7) != 0, X86_EXC_UD); case 0x88 ... 0x8b: /* mov */ case 0xa0 ... 0xa1: /* mov mem.offs,{%al,%ax,%eax,%rax} */ case 0xa2 ... 0xa3: /* mov {%al,%ax,%eax,%rax},mem.offs */ @@ -1966,7 +1944,7 @@ x86_emulate( case 0x8c: /* mov Sreg,r/m */ seg = modrm_reg & 7; /* REX.R is ignored. */ - generate_exception_if(!is_x86_user_segment(seg), EXC_UD); + generate_exception_if(!is_x86_user_segment(seg), X86_EXC_UD); store_selector: fail_if(ops->read_segment == NULL); if ( (rc = ops->read_segment(seg, &sreg, ctxt)) != 0 ) @@ -1977,14 +1955,14 @@ x86_emulate( break; case 0x8d: /* lea */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); dst.val = ea.mem.off; break; case 0x8e: /* mov r/m,Sreg */ seg = modrm_reg & 7; /* REX.R is ignored. */ generate_exception_if(!is_x86_user_segment(seg) || - seg == x86_seg_cs, EXC_UD); + seg == x86_seg_cs, X86_EXC_UD); if ( (rc = load_seg(seg, src.val, 0, NULL, ctxt, ops)) != 0 ) goto done; if ( seg == x86_seg_ss ) @@ -1993,7 +1971,7 @@ x86_emulate( break; case 0x8f: /* pop (sole member of Grp1a) */ - generate_exception_if((modrm_reg & 7) != 0, EXC_UD); + generate_exception_if((modrm_reg & 7) != 0, X86_EXC_UD); /* 64-bit mode: POP defaults to a 64-bit operand. */ if ( mode_64bit() && (dst.bytes == 4) ) dst.bytes = 8; @@ -2074,7 +2052,7 @@ x86_emulate( if ( rc != X86EMUL_OKAY ) goto done; } - generate_exception_if(!(cr4 & X86_CR4_VME), EXC_GP, 0); + generate_exception_if(!(cr4 & X86_CR4_VME), X86_EXC_GP, 0); src.val = (_regs.flags & ~X86_EFLAGS_IF) | X86_EFLAGS_IOPL; if ( _regs.eflags & X86_EFLAGS_VIF ) src.val |= X86_EFLAGS_IF; @@ -2104,7 +2082,7 @@ x86_emulate( /* All IOPL != 3 POPFs fail, except in vm86 mode. */ generate_exception_if(!(cr4 & X86_CR4_VME) && MASK_EXTR(_regs.eflags, X86_EFLAGS_IOPL) != 3, - EXC_GP, 0); + X86_EXC_GP, 0); } /* * IOPL cannot be modified outside of CPL 0. IF cannot be @@ -2128,11 +2106,11 @@ x86_emulate( if ( (cr4 & X86_CR4_VME) && MASK_EXTR(_regs.eflags, X86_EFLAGS_IOPL) != 3 ) { - generate_exception_if(dst.val & X86_EFLAGS_TF, EXC_GP, 0); + generate_exception_if(dst.val & X86_EFLAGS_TF, X86_EXC_GP, 0); if ( dst.val & X86_EFLAGS_IF ) { generate_exception_if(_regs.eflags & X86_EFLAGS_VIP, - EXC_GP, 0); + X86_EXC_GP, 0); dst.val |= X86_EFLAGS_VIF; } else @@ -2267,7 +2245,7 @@ x86_emulate( break; case 0xc0 ... 0xc1: grp2: /* Grp2 */ - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); switch ( modrm_reg & 7 ) { @@ -2307,7 +2285,7 @@ x86_emulate( case 0xc5: /* lds */ seg = (b & 1) * 3; /* es = 0, ds = 3 */ les: - generate_exception_if(src.type != OP_MEM, EXC_UD); + generate_exception_if(src.type != OP_MEM, X86_EXC_UD); if ( (rc = read_ulong(src.mem.seg, truncate_ea(src.mem.off + src.bytes), &dst.val, 2, ctxt, ops)) != X86EMUL_OKAY ) goto done; @@ -2386,7 +2364,7 @@ x86_emulate( switch ( ctxt->opcode ) { case 0xcc: /* int3 */ - ctxt->event.vector = EXC_BP; + ctxt->event.vector = X86_EXC_BP; ctxt->event.type = X86_EVENTTYPE_SW_EXCEPTION; break; case 0xcd: /* int imm8 */ @@ -2394,11 +2372,11 @@ x86_emulate( ctxt->event.type = X86_EVENTTYPE_SW_INTERRUPT; break; case 0xce: /* into */ - ctxt->event.vector = EXC_OF; + ctxt->event.vector = X86_EXC_OF; ctxt->event.type = X86_EVENTTYPE_SW_EXCEPTION; break; case 0xf1: /* icebp */ - ctxt->event.vector = EXC_DB; + ctxt->event.vector = X86_EXC_DB; ctxt->event.type = X86_EVENTTYPE_PRI_SW_EXCEPTION; break; } @@ -2447,7 +2425,7 @@ x86_emulate( _regs.ax = (uint8_t)(_regs.al + (_regs.ah * n)); else { - generate_exception_if(!n, EXC_DE); + generate_exception_if(!n, X86_EXC_DE); _regs.al = _regs.al % n; _regs.ah = _regs.al / n; } @@ -2551,7 +2529,7 @@ x86_emulate( break; case 0xf4: /* hlt */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); ctxt->retire.hlt = true; break; @@ -2670,7 +2648,7 @@ x86_emulate( v = (uint8_t)src.val; generate_exception_if( div_dbl(u, v) || ((uint8_t)u[0] != (uint16_t)u[0]), - EXC_DE); + X86_EXC_DE); dst.val = (uint8_t)u[0]; _regs.ah = u[1]; break; @@ -2680,7 +2658,7 @@ x86_emulate( v = (uint16_t)src.val; generate_exception_if( div_dbl(u, v) || ((uint16_t)u[0] != (uint32_t)u[0]), - EXC_DE); + X86_EXC_DE); dst.val = (uint16_t)u[0]; _regs.dx = u[1]; break; @@ -2691,7 +2669,7 @@ x86_emulate( v = (uint32_t)src.val; generate_exception_if( div_dbl(u, v) || ((uint32_t)u[0] != u[0]), - EXC_DE); + X86_EXC_DE); dst.val = (uint32_t)u[0]; _regs.rdx = (uint32_t)u[1]; break; @@ -2700,7 +2678,7 @@ x86_emulate( u[0] = _regs.r(ax); u[1] = _regs.r(dx); v = src.val; - generate_exception_if(div_dbl(u, v), EXC_DE); + generate_exception_if(div_dbl(u, v), X86_EXC_DE); dst.val = u[0]; _regs.r(dx) = u[1]; break; @@ -2715,7 +2693,7 @@ x86_emulate( v = (int8_t)src.val; generate_exception_if( idiv_dbl(u, v) || ((int8_t)u[0] != (int16_t)u[0]), - EXC_DE); + X86_EXC_DE); dst.val = (int8_t)u[0]; _regs.ah = u[1]; break; @@ -2725,7 +2703,7 @@ x86_emulate( v = (int16_t)src.val; generate_exception_if( idiv_dbl(u, v) || ((int16_t)u[0] != (int32_t)u[0]), - EXC_DE); + X86_EXC_DE); dst.val = (int16_t)u[0]; _regs.dx = u[1]; break; @@ -2736,7 +2714,7 @@ x86_emulate( v = (int32_t)src.val; generate_exception_if( idiv_dbl(u, v) || ((int32_t)u[0] != u[0]), - EXC_DE); + X86_EXC_DE); dst.val = (int32_t)u[0]; _regs.rdx = (uint32_t)u[1]; break; @@ -2745,7 +2723,7 @@ x86_emulate( u[0] = _regs.r(ax); u[1] = _regs.r(dx); v = src.val; - generate_exception_if(idiv_dbl(u, v), EXC_DE); + generate_exception_if(idiv_dbl(u, v), X86_EXC_DE); dst.val = u[0]; _regs.r(dx) = u[1]; break; @@ -2767,7 +2745,7 @@ x86_emulate( _regs.eflags &= ~X86_EFLAGS_IF; else { - generate_exception_if(!mode_vif(), EXC_GP, 0); + generate_exception_if(!mode_vif(), X86_EXC_GP, 0); _regs.eflags &= ~X86_EFLAGS_VIF; } break; @@ -2783,7 +2761,7 @@ x86_emulate( { generate_exception_if((_regs.eflags & X86_EFLAGS_VIP) || !mode_vif(), - EXC_GP, 0); + X86_EXC_GP, 0); if ( !(_regs.eflags & X86_EFLAGS_VIF) ) ctxt->retire.sti = true; _regs.eflags |= X86_EFLAGS_VIF; @@ -2799,7 +2777,7 @@ x86_emulate( break; case 0xfe: /* Grp4 */ - generate_exception_if((modrm_reg & 7) >= 2, EXC_UD); + generate_exception_if((modrm_reg & 7) >= 2, X86_EXC_UD); /* Fallthrough. */ case 0xff: /* Grp5 */ switch ( modrm_reg & 7 ) @@ -2833,7 +2811,7 @@ x86_emulate( break; case 3: /* call (far, absolute indirect) */ case 5: /* jmp (far, absolute indirect) */ - generate_exception_if(src.type != OP_MEM, EXC_UD); + generate_exception_if(src.type != OP_MEM, X86_EXC_UD); if ( (rc = read_ulong(src.mem.seg, truncate_ea(src.mem.off + op_bytes), @@ -2846,20 +2824,20 @@ x86_emulate( case 6: /* push */ goto push; case 7: - generate_exception(EXC_UD); + generate_exception(X86_EXC_UD); } break; case X86EMUL_OPC(0x0f, 0x00): /* Grp6 */ seg = (modrm_reg & 1) ? x86_seg_tr : x86_seg_ldtr; - generate_exception_if(!in_protmode(ctxt, ops), EXC_UD); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_UD); switch ( modrm_reg & 6 ) { case 0: /* sldt / str */ - generate_exception_if(umip_active(ctxt, ops), EXC_GP, 0); + generate_exception_if(umip_active(ctxt, ops), X86_EXC_GP, 0); goto store_selector; case 2: /* lldt / ltr */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); if ( (rc = load_seg(seg, src.val, 0, NULL, ctxt, ops)) != 0 ) goto done; break; @@ -2877,7 +2855,7 @@ x86_emulate( case X86EMUL_EXCEPTION: if ( ctxt->event_pending ) { - ASSERT(ctxt->event.vector == EXC_PF); + ASSERT(ctxt->event.vector == X86_EXC_PF); default: goto done; } @@ -2887,7 +2865,7 @@ x86_emulate( } break; default: - generate_exception_if(true, EXC_UD); + generate_exception_if(true, X86_EXC_UD); break; } break; @@ -2897,7 +2875,7 @@ x86_emulate( goto dispatch_from_helper; case X86EMUL_OPC(0x0f, 0x02): /* lar */ - generate_exception_if(!in_protmode(ctxt, ops), EXC_UD); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_UD); _regs.eflags &= ~X86_EFLAGS_ZF; switch ( rc = protmode_load_seg(x86_seg_none, src.val, false, &sreg, ctxt, ops) ) @@ -2928,7 +2906,7 @@ x86_emulate( case X86EMUL_EXCEPTION: if ( ctxt->event_pending ) { - ASSERT(ctxt->event.vector == EXC_PF); + ASSERT(ctxt->event.vector == X86_EXC_PF); default: goto done; } @@ -2945,7 +2923,7 @@ x86_emulate( break; case X86EMUL_OPC(0x0f, 0x03): /* lsl */ - generate_exception_if(!in_protmode(ctxt, ops), EXC_UD); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_UD); _regs.eflags &= ~X86_EFLAGS_ZF; switch ( rc = protmode_load_seg(x86_seg_none, src.val, false, &sreg, ctxt, ops) ) @@ -2973,7 +2951,7 @@ x86_emulate( case X86EMUL_EXCEPTION: if ( ctxt->event_pending ) { - ASSERT(ctxt->event.vector == EXC_PF); + ASSERT(ctxt->event.vector == X86_EXC_PF); default: goto done; } @@ -2996,8 +2974,8 @@ x86_emulate( fail_if(ops->read_msr == NULL); if ( (rc = ops->read_msr(MSR_EFER, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; - generate_exception_if((msr_val & EFER_SCE) == 0, EXC_UD); - generate_exception_if(!amd_like(ctxt) && !mode_64bit(), EXC_UD); + generate_exception_if((msr_val & EFER_SCE) == 0, X86_EXC_UD); + generate_exception_if(!amd_like(ctxt) && !mode_64bit(), X86_EXC_UD); if ( (rc = ops->read_msr(MSR_STAR, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; @@ -3065,7 +3043,7 @@ x86_emulate( break; case X86EMUL_OPC(0x0f, 0x06): /* clts */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); fail_if((ops->read_cr == NULL) || (ops->write_cr == NULL)); if ( (rc = ops->read_cr(0, &dst.val, ctxt)) != X86EMUL_OKAY || (rc = ops->write_cr(0, dst.val & ~X86_CR0_TS, ctxt)) != X86EMUL_OKAY ) @@ -3081,10 +3059,10 @@ x86_emulate( fail_if(!ops->read_msr); if ( (rc = ops->read_msr(MSR_EFER, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; - generate_exception_if(!(msr_val & EFER_SCE), EXC_UD); - generate_exception_if(!amd_like(ctxt) && !mode_64bit(), EXC_UD); - generate_exception_if(!mode_ring0(), EXC_GP, 0); - generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0); + generate_exception_if(!(msr_val & EFER_SCE), X86_EXC_UD); + generate_exception_if(!amd_like(ctxt) && !mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_GP, 0); #ifdef __x86_64__ /* * Doing this for just Intel (rather than e.g. !amd_like()) as this is @@ -3093,7 +3071,7 @@ x86_emulate( */ generate_exception_if(ctxt->cpuid->x86_vendor == X86_VENDOR_INTEL && op_bytes == 8 && !is_canonical_address(_regs.rcx), - EXC_GP, 0); + X86_EXC_GP, 0); #endif if ( (rc = ops->read_msr(MSR_STAR, &msr_val, ctxt)) != X86EMUL_OKAY ) @@ -3152,7 +3130,7 @@ x86_emulate( case X86EMUL_OPC(0x0f, 0x08): /* invd */ case X86EMUL_OPC(0x0f, 0x09): /* wbinvd / wbnoinvd */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); fail_if(!ops->cache_op); if ( (rc = ops->cache_op(b == 0x09 ? !repe_prefix() || !vcpu_has_wbnoinvd() @@ -3167,7 +3145,7 @@ x86_emulate( case X86EMUL_OPC(0x0f, 0x0b): /* ud2 */ case X86EMUL_OPC(0x0f, 0xb9): /* ud1 */ case X86EMUL_OPC(0x0f, 0xff): /* ud0 */ - generate_exception(EXC_UD); + generate_exception(X86_EXC_UD); case X86EMUL_OPC(0x0f, 0x0d): /* GrpP (prefetch) */ case X86EMUL_OPC(0x0f, 0x18): /* Grp16 (prefetch/nop) */ @@ -3187,7 +3165,7 @@ x86_emulate( else if ( _3dnow_ext_table[(imm1 >> 4) & 0xf] & (1 << (imm1 & 0xf)) ) host_and_vcpu_must_have(3dnow_ext); else - generate_exception(EXC_UD); + generate_exception(X86_EXC_UD); get_fpu(X86EMUL_FPU_mmx); @@ -3266,7 +3244,7 @@ x86_emulate( /* fall through */ CASE_SIMD_PACKED_FP_VEX(0x0f, 0x2b): /* movntp{s,d} xmm,m128 */ /* vmovntp{s,d} {x,y}mm,mem */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); sfence = true; /* fall through */ CASE_SIMD_ALL_FP_VEX(0x0f, 0x10): /* mov{up,s}{s,d} xmm/mem,xmm */ @@ -3352,7 +3330,7 @@ x86_emulate( break; CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x2b): /* vmovntp{s,d} [xyz]mm,mem */ - generate_exception_if(ea.type != OP_MEM || evex.opmsk, EXC_UD); + generate_exception_if(ea.type != OP_MEM || evex.opmsk, X86_EXC_UD); sfence = true; /* fall through */ CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x10): /* vmovup{s,d} [xyz]mm/mem,[xyz]mm{k} */ @@ -3366,7 +3344,7 @@ x86_emulate( /* vmovs{s,d} to/from memory have only two operands. */ if ( (b & ~1) == 0x10 && ea.type == OP_MEM ) d |= TwoOp; - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); /* fall through */ CASE_SIMD_ALL_FP(_EVEX, 0x0f, 0x51): /* vsqrtp{s,d} [xyz]mm/mem,[xyz]mm{k} */ /* vsqrts{s,d} xmm/m32,xmm,xmm{k} */ @@ -3380,7 +3358,7 @@ x86_emulate( generate_exception_if((evex.w != (evex.pfx & VEX_PREFIX_DOUBLE_MASK) || (ea.type != OP_REG && evex.brs && (evex.pfx & VEX_PREFIX_SCALAR_MASK))), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( ea.type != OP_REG || !evex.brs ) avx512_vlen_check(evex.pfx & VEX_PREFIX_SCALAR_MASK); @@ -3408,7 +3386,7 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f, 0x16): /* vmovhpd m64,xmm,xmm */ CASE_SIMD_PACKED_FP_VEX(0x0f, 0x17): /* movhp{s,d} xmm,m64 */ /* vmovhp{s,d} xmm,m64 */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); /* fall through */ case X86EMUL_OPC(0x0f, 0x12): /* movlps m64,xmm */ /* movhlps xmm,xmm */ @@ -3418,7 +3396,7 @@ x86_emulate( /* movlhps xmm,xmm */ case X86EMUL_OPC_VEX(0x0f, 0x16): /* vmovhps m64,xmm,xmm */ /* vmovlhps xmm,xmm,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); if ( (d & DstMask) != DstMem ) d &= ~TwoOp; op_bytes = 8; @@ -3428,7 +3406,7 @@ x86_emulate( CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x13): /* vmovlp{s,d} xmm,m64 */ case X86EMUL_OPC_EVEX_66(0x0f, 0x16): /* vmovhpd m64,xmm,xmm */ CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x17): /* vmovhp{s,d} xmm,m64 */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX(0x0f, 0x12): /* vmovlps m64,xmm,xmm */ /* vmovhlps xmm,xmm,xmm */ @@ -3436,7 +3414,7 @@ x86_emulate( /* vmovlhps xmm,xmm,xmm */ generate_exception_if((evex.lr || evex.opmsk || evex.brs || evex.w != (evex.pfx & VEX_PREFIX_DOUBLE_MASK)), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( (d & DstMask) != DstMem ) d &= ~TwoOp; @@ -3463,7 +3441,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_F3(0x0f, 0x16): /* vmovshdup [xyz]mm/mem,[xyz]mm{k} */ generate_exception_if((evex.brs || evex.w != (evex.pfx & VEX_PREFIX_DOUBLE_MASK)), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); avx512_vlen_check(false); d |= TwoOp; @@ -3475,7 +3453,7 @@ x86_emulate( CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x14): /* vunpcklp{s,d} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x15): /* vunpckhp{s,d} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ generate_exception_if(evex.w != (evex.pfx & VEX_PREFIX_DOUBLE_MASK), - EXC_UD); + X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x76): /* vpermi2{d,q} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x77): /* vpermi2p{s,d} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -3502,7 +3480,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x65): /* vblendmp{s,d} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ avx512f_no_sae: host_and_vcpu_must_have(avx512f); - generate_exception_if(ea.type != OP_MEM && evex.brs, EXC_UD); + generate_exception_if(ea.type != OP_MEM && evex.brs, X86_EXC_UD); avx512_vlen_check(false); goto simd_zmm; @@ -3512,7 +3490,7 @@ x86_emulate( case X86EMUL_OPC(0x0f, 0x21): /* mov dr,reg */ case X86EMUL_OPC(0x0f, 0x22): /* mov reg,cr */ case X86EMUL_OPC(0x0f, 0x23): /* mov reg,dr */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); if ( b & 2 ) { /* Write to CR/DR. */ @@ -3580,7 +3558,7 @@ x86_emulate( CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x2a): /* vcvtsi2s{s,d} r/m,xmm,xmm */ CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x7b): /* vcvtusi2s{s,d} r/m,xmm,xmm */ generate_exception_if(evex.opmsk || (ea.type != OP_REG && evex.brs), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( !evex.brs ) avx512_vlen_check(true); @@ -3632,7 +3610,7 @@ x86_emulate( } else { - generate_exception_if(vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); @@ -3691,7 +3669,7 @@ x86_emulate( CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x79): /* vcvts{s,d}2usi xmm/mem,reg */ generate_exception_if((evex.reg != 0xf || !evex.RX || evex.opmsk || (ea.type != OP_REG && evex.brs)), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( !evex.brs ) avx512_vlen_check(true); @@ -3711,7 +3689,7 @@ x86_emulate( } else { - generate_exception_if(vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); } @@ -3761,7 +3739,7 @@ x86_emulate( generate_exception_if((evex.reg != 0xf || !evex.RX || evex.opmsk || (ea.type != OP_REG && evex.brs) || evex.w != evex.pfx), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( !evex.brs ) avx512_vlen_check(true); @@ -3772,7 +3750,7 @@ x86_emulate( goto vcomi; case X86EMUL_OPC(0x0f, 0x30): /* wrmsr */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); fail_if(ops->write_msr == NULL); if ( (rc = ops->write_msr(_regs.ecx, ((uint64_t)_regs.r(dx) << 32) | _regs.eax, @@ -3786,7 +3764,7 @@ x86_emulate( fail_if(ops->read_cr == NULL); if ( (rc = ops->read_cr(4, &cr4, ctxt)) ) goto done; - generate_exception_if(cr4 & X86_CR4_TSD, EXC_GP, 0); + generate_exception_if(cr4 & X86_CR4_TSD, X86_EXC_GP, 0); } fail_if(ops->read_msr == NULL); if ( (rc = ops->read_msr(MSR_IA32_TSC, @@ -3797,7 +3775,7 @@ x86_emulate( break; case X86EMUL_OPC(0x0f, 0x32): /* rdmsr */ - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); fail_if(ops->read_msr == NULL); if ( (rc = ops->read_msr(_regs.ecx, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; @@ -3807,15 +3785,15 @@ x86_emulate( case X86EMUL_OPC(0x0f, 0x34): /* sysenter */ vcpu_must_have(sep); - generate_exception_if(amd_like(ctxt) && ctxt->lma, EXC_UD); - generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0); + generate_exception_if(amd_like(ctxt) && ctxt->lma, X86_EXC_UD); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_GP, 0); fail_if(ops->read_msr == NULL); if ( (rc = ops->read_msr(MSR_IA32_SYSENTER_CS, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; - generate_exception_if(!(msr_val & 0xfffc), EXC_GP, 0); + generate_exception_if(!(msr_val & 0xfffc), X86_EXC_GP, 0); _regs.eflags &= ~(X86_EFLAGS_VM | X86_EFLAGS_IF | X86_EFLAGS_RF); @@ -3856,20 +3834,20 @@ x86_emulate( case X86EMUL_OPC(0x0f, 0x35): /* sysexit */ vcpu_must_have(sep); - generate_exception_if(amd_like(ctxt) && ctxt->lma, EXC_UD); - generate_exception_if(!mode_ring0(), EXC_GP, 0); - generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0); + generate_exception_if(amd_like(ctxt) && ctxt->lma, X86_EXC_UD); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); + generate_exception_if(!in_protmode(ctxt, ops), X86_EXC_GP, 0); fail_if(ops->read_msr == NULL); if ( (rc = ops->read_msr(MSR_IA32_SYSENTER_CS, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; - generate_exception_if(!(msr_val & 0xfffc), EXC_GP, 0); + generate_exception_if(!(msr_val & 0xfffc), X86_EXC_GP, 0); generate_exception_if(op_bytes == 8 && (!is_canonical_address(_regs.r(dx)) || !is_canonical_address(_regs.r(cx))), - EXC_GP, 0); + X86_EXC_GP, 0); cs.sel = (msr_val | 3) + /* SELECTOR_RPL_MASK */ (op_bytes == 8 ? 32 : 16); @@ -3917,7 +3895,7 @@ x86_emulate( case X86EMUL_OPC_VEX(0x0f, 0x47): /* kxor{w,q} k,k,k */ case X86EMUL_OPC_VEX_66(0x0f, 0x47): /* kxor{b,d} k,k,k */ case X86EMUL_OPC_VEX_66(0x0f, 0x4a): /* kadd{b,d} k,k,k */ - generate_exception_if(!vex.l, EXC_UD); + generate_exception_if(!vex.l, X86_EXC_UD); opmask_basic: if ( vex.w ) host_and_vcpu_must_have(avx512bw); @@ -3926,7 +3904,7 @@ x86_emulate( opmask_common: host_and_vcpu_must_have(avx512f); generate_exception_if(!vex.r || (mode_64bit() && !(vex.reg & 8)) || - ea.type != OP_REG, EXC_UD); + ea.type != OP_REG, X86_EXC_UD); vex.reg |= 8; d &= ~TwoOp; @@ -3944,16 +3922,16 @@ x86_emulate( case X86EMUL_OPC_VEX(0x0f, 0x44): /* knot{w,q} k,k */ case X86EMUL_OPC_VEX_66(0x0f, 0x44): /* knot{b,d} k,k */ - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); goto opmask_basic; case X86EMUL_OPC_VEX(0x0f, 0x4b): /* kunpck{w,d}{d,q} k,k,k */ - generate_exception_if(!vex.l, EXC_UD); + generate_exception_if(!vex.l, X86_EXC_UD); host_and_vcpu_must_have(avx512bw); goto opmask_common; case X86EMUL_OPC_VEX_66(0x0f, 0x4b): /* kunpckbw k,k,k */ - generate_exception_if(!vex.l || vex.w, EXC_UD); + generate_exception_if(!vex.l || vex.w, X86_EXC_UD); goto opmask_common; #endif /* X86EMUL_NO_SIMD */ @@ -3974,7 +3952,7 @@ x86_emulate( simd_0f_to_gpr: opc[insn_bytes - PFX_BYTES] = 0xc3; - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); if ( vex.opcx == vex_none ) { @@ -3997,7 +3975,7 @@ x86_emulate( } else { - generate_exception_if(vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.reg != 0xf, X86_EXC_UD); if ( b == 0x50 || !vex.l ) host_and_vcpu_must_have(avx); else @@ -4020,7 +3998,7 @@ x86_emulate( CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x57): /* vxorp{s,d} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ generate_exception_if((evex.w != (evex.pfx & VEX_PREFIX_DOUBLE_MASK) || (ea.type != OP_MEM && evex.brs)), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512dq); avx512_vlen_check(false); goto simd_zmm; @@ -4053,7 +4031,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0x5b): /* vcvtps2dq [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_F3(0x0f, 0x5b): /* vcvttps2dq [xyz]mm/mem,[xyz]mm{k} */ - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX(0x0f, 0x5b): /* vcvtdq2ps [xyz]mm/mem,[xyz]mm{k} */ /* vcvtqq2ps [xyz]mm/mem,{x,y}mm{k} */ @@ -4245,7 +4223,7 @@ x86_emulate( #ifndef X86EMUL_NO_SIMD case X86EMUL_OPC_EVEX_66(0x0f, 0xf6): /* vpsadbw [xyz]mm/mem,[xyz]mm,[xyz]mm */ - generate_exception_if(evex.opmsk, EXC_UD); + generate_exception_if(evex.opmsk, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f, 0x60): /* vpunpcklbw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f, 0x61): /* vpunpcklwd [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -4283,13 +4261,13 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x1c): /* vpabsb [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x1d): /* vpabsw [xyz]mm/mem,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); elem_bytes = 1 << (b & 1); goto avx512f_no_sae; case X86EMUL_OPC_EVEX_66(0x0f, 0x62): /* vpunpckldq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f, 0x6a): /* vpunpckhdq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); fault_suppression = false; op_bytes = 16 << evex.lr; goto avx512f_no_sae; @@ -4308,21 +4286,21 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x27): /* vptestm{d,q} [xyz]mm/mem,[xyz]mm,k{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x29): /* vpcmpeqq [xyz]mm/mem,[xyz]mm,k{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x37): /* vpcmpgtq [xyz]mm/mem,[xyz]mm,k{k} */ - generate_exception_if(!evex.r || !evex.R || evex.z, EXC_UD); + generate_exception_if(!evex.r || !evex.R || evex.z, X86_EXC_UD); if ( b & (ext == ext_0f38 ? 1 : 2) ) { - generate_exception_if(b != 0x27 && evex.w != (b & 1), EXC_UD); + generate_exception_if(b != 0x27 && evex.w != (b & 1), X86_EXC_UD); goto avx512f_no_sae; } host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); elem_bytes = 1 << (ext == ext_0f ? b & 1 : evex.w); avx512_vlen_check(false); goto simd_zmm; case X86EMUL_OPC_EVEX_66(0x0f, 0x6b): /* vpackssdw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x2b): /* vpackusdw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(evex.w || evex.brs, EXC_UD); + generate_exception_if(evex.w || evex.brs, X86_EXC_UD); fault_suppression = false; goto avx512f_no_sae; @@ -4333,7 +4311,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0xd4): /* vpaddq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f, 0xf4): /* vpmuludq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x28): /* vpmuldq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); goto avx512f_no_sae; #endif /* X86EMUL_NO_SIMD */ @@ -4344,7 +4322,7 @@ x86_emulate( /* vmov{d,q} xmm,r/m */ if ( vex.opcx != vex_none ) { - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); } @@ -4385,7 +4363,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0x7e): /* vmov{d,q} xmm,r/m */ generate_exception_if((evex.lr || evex.opmsk || evex.brs || evex.reg != 0xf || !evex.RX), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); get_fpu(X86EMUL_FPU_zmm); @@ -4409,7 +4387,7 @@ x86_emulate( case X86EMUL_OPC_66(0x0f, 0xe7): /* movntdq xmm,m128 */ case X86EMUL_OPC_VEX_66(0x0f, 0xe7): /* vmovntdq {x,y}mm,mem */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); sfence = true; /* fall through */ case X86EMUL_OPC_66(0x0f, 0x6f): /* movdqa xmm/m128,xmm */ @@ -4429,7 +4407,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0xe7): /* vmovntdq [xyz]mm,mem */ generate_exception_if(ea.type != OP_MEM || evex.opmsk || evex.w, - EXC_UD); + X86_EXC_UD); sfence = true; /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f, 0x6f): /* vmovdqa{32,64} [xyz]mm/mem,[xyz]mm{k} */ @@ -4437,7 +4415,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0x7f): /* vmovdqa{32,64} [xyz]mm,[xyz]mm/mem{k} */ case X86EMUL_OPC_EVEX_F3(0x0f, 0x7f): /* vmovdqu{32,64} [xyz]mm,[xyz]mm/mem{k} */ vmovdqa: - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); d |= TwoOp; op_bytes = 16 << evex.lr; goto avx512f_no_sae; @@ -4449,7 +4427,7 @@ x86_emulate( goto vmovdqa; case X86EMUL_OPC_VEX_66(0x0f, 0xd6): /* vmovq xmm,xmm/m64 */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); d |= TwoOp; /* fall through */ case X86EMUL_OPC_66(0x0f, 0xd6): /* movq xmm,xmm/m64 */ @@ -4534,11 +4512,11 @@ x86_emulate( case X86EMUL_OPC_EVEX_F3(0x0f, 0x70): /* vpshufhw $imm8,[xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_F2(0x0f, 0x70): /* vpshuflw $imm8,[xyz]mm/mem,[xyz]mm{k} */ if ( evex.pfx == vex_66 ) - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); else { host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); } d = (d & ~SrcMask) | SrcMem | TwoOp; op_bytes = 16 << evex.lr; @@ -4562,7 +4540,7 @@ x86_emulate( goto unrecognized_insn; } simd_0f_shift_imm: - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); if ( vex.opcx != vex_none ) { @@ -4622,7 +4600,7 @@ x86_emulate( { case 2: /* vpsrld $imm8,[xyz]mm/mem,[xyz]mm{k} */ case 6: /* vpslld $imm8,[xyz]mm/mem,[xyz]mm{k} */ - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); /* fall through */ case 0: /* vpror{d,q} $imm8,[xyz]mm/mem,[xyz]mm{k} */ case 1: /* vprol{d,q} $imm8,[xyz]mm/mem,[xyz]mm{k} */ @@ -4670,11 +4648,11 @@ x86_emulate( { case 2: /* vpsrlq $imm8,[xyz]mm/mem,[xyz]mm{k} */ case 6: /* vpsllq $imm8,[xyz]mm/mem,[xyz]mm{k} */ - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); goto avx512f_shift_imm; case 3: /* vpsrldq $imm8,[xyz]mm/mem,[xyz]mm */ case 7: /* vpslldq $imm8,[xyz]mm/mem,[xyz]mm */ - generate_exception_if(evex.opmsk, EXC_UD); + generate_exception_if(evex.opmsk, X86_EXC_UD); goto avx512bw_shift_imm; } goto unrecognized_insn; @@ -4688,7 +4666,7 @@ x86_emulate( case X86EMUL_OPC_VEX(0x0f, 0x77): /* vzero{all,upper} */ if ( vex.opcx != vex_none ) { - generate_exception_if(vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); @@ -4756,7 +4734,7 @@ x86_emulate( } /* fall through */ case X86EMUL_OPC_F2(0x0f, 0x78): /* insertq $imm8,$imm8,xmm,xmm */ - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); host_and_vcpu_must_have(sse4a); get_fpu(X86EMUL_FPU_xmm); @@ -4771,14 +4749,14 @@ x86_emulate( case X86EMUL_OPC_66(0x0f, 0x79): /* extrq xmm,xmm */ case X86EMUL_OPC_F2(0x0f, 0x79): /* insertq xmm,xmm */ - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); host_and_vcpu_must_have(sse4a); op_bytes = 8; goto simd_0f_xmm; case X86EMUL_OPC_EVEX_66(0x0f, 0xe6): /* vcvttpd2dq [xyz]mm/mem,{x,y}mm{k} */ case X86EMUL_OPC_EVEX_F2(0x0f, 0xe6): /* vcvtpd2dq [xyz]mm/mem,{x,y}mm{k} */ - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_F3(0x0f, 0x7a): /* vcvtudq2pd {x,y}mm/mem,[xyz]mm{k} */ /* vcvtuqq2pd [xyz]mm/mem,[xyz]mm{k} */ @@ -4801,7 +4779,7 @@ x86_emulate( else { host_and_vcpu_must_have(avx512f); - generate_exception_if(ea.type != OP_MEM && evex.brs, EXC_UD); + generate_exception_if(ea.type != OP_MEM && evex.brs, X86_EXC_UD); } if ( ea.type != OP_REG || !evex.brs ) avx512_vlen_check(false); @@ -4811,7 +4789,7 @@ x86_emulate( case X86EMUL_OPC_F2(0x0f, 0xf0): /* lddqu m128,xmm */ case X86EMUL_OPC_VEX_F2(0x0f, 0xf0): /* vlddqu mem,{x,y}mm */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_66(0x0f, 0x7c): /* haddpd xmm/m128,xmm */ case X86EMUL_OPC_F2(0x0f, 0x7c): /* haddps xmm/m128,xmm */ @@ -4830,14 +4808,14 @@ x86_emulate( case X86EMUL_OPC_F3(0x0f, 0x7e): /* movq xmm/m64,xmm */ case X86EMUL_OPC_VEX_F3(0x0f, 0x7e): /* vmovq xmm/m64,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); op_bytes = 8; goto simd_0f_int; case X86EMUL_OPC_EVEX_F3(0x0f, 0x7e): /* vmovq xmm/m64,xmm */ case X86EMUL_OPC_EVEX_66(0x0f, 0xd6): /* vmovq xmm,xmm/m64 */ generate_exception_if(evex.lr || !evex.w || evex.opmsk || evex.brs, - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); d |= TwoOp; op_bytes = 8; @@ -4859,11 +4837,11 @@ x86_emulate( case X86EMUL_OPC_VEX(0x0f, 0x91): /* kmov{w,q} k,mem */ case X86EMUL_OPC_VEX_66(0x0f, 0x91): /* kmov{b,d} k,mem */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_VEX(0x0f, 0x90): /* kmov{w,q} k/mem,k */ case X86EMUL_OPC_VEX_66(0x0f, 0x90): /* kmov{b,d} k/mem,k */ - generate_exception_if(vex.l || !vex.r, EXC_UD); + generate_exception_if(vex.l || !vex.r, X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( vex.w ) { @@ -4896,14 +4874,14 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f, 0x92): /* kmovb r32,k */ case X86EMUL_OPC_VEX_F2(0x0f, 0x92): /* kmov{d,q} reg,k */ generate_exception_if(vex.l || !vex.r || vex.reg != 0xf || - ea.type != OP_REG, EXC_UD); + ea.type != OP_REG, X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( vex.pfx == vex_f2 ) host_and_vcpu_must_have(avx512bw); else { - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); if ( vex.pfx ) host_and_vcpu_must_have(avx512dq); } @@ -4933,7 +4911,7 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f, 0x93): /* kmovb k,r32 */ case X86EMUL_OPC_VEX_F2(0x0f, 0x93): /* kmov{d,q} k,reg */ generate_exception_if(vex.l || vex.reg != 0xf || ea.type != OP_REG, - EXC_UD); + X86_EXC_UD); dst = ea; dst.reg = decode_gpr(&_regs, modrm_reg); @@ -4945,7 +4923,7 @@ x86_emulate( } else { - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); dst.bytes = 4; if ( vex.pfx ) host_and_vcpu_must_have(avx512dq); @@ -4978,7 +4956,7 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f, 0x98): /* kortest{b,d} k,k */ case X86EMUL_OPC_VEX_66(0x0f, 0x99): /* ktest{b,d} k,k */ generate_exception_if(vex.l || !vex.r || vex.reg != 0xf || - ea.type != OP_REG, EXC_UD); + ea.type != OP_REG, X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( vex.w ) host_and_vcpu_must_have(avx512bw); @@ -5025,7 +5003,7 @@ x86_emulate( goto done; generate_exception_if((msr_val & MSR_MISC_FEATURES_CPUID_FAULTING), - EXC_GP, 0); /* Faulting active? (Inc. CPL test) */ + X86_EXC_GP, 0); /* Faulting active? (Inc. CPL test) */ rc = ops->cpuid(_regs.eax, _regs.ecx, &cpuid_leaf, ctxt); if ( rc != X86EMUL_OKAY ) @@ -5037,7 +5015,7 @@ x86_emulate( break; case X86EMUL_OPC(0x0f, 0xa3): bt: /* bt */ - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); if ( ops->rmw && dst.type == OP_MEM && (rc = read_ulong(dst.mem.seg, dst.mem.off, &dst.val, @@ -5054,7 +5032,7 @@ x86_emulate( case X86EMUL_OPC(0x0f, 0xad): /* shrd %%cl,r,r/m */ { uint8_t shift, width = dst.bytes << 3; - generate_exception_if(lock_prefix, EXC_UD); + generate_exception_if(lock_prefix, X86_EXC_UD); if ( b & 1 ) shift = _regs.cl; @@ -5202,7 +5180,7 @@ x86_emulate( case 5: goto bts; case 6: goto btr; case 7: goto btc; - default: generate_exception(EXC_UD); + default: generate_exception(X86_EXC_UD); } break; @@ -5320,7 +5298,7 @@ x86_emulate( (ea.type != OP_REG && evex.brs && (evex.pfx & VEX_PREFIX_SCALAR_MASK)) || !evex.r || !evex.R || evex.z), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( ea.type != OP_REG || !evex.brs ) avx512_vlen_check(evex.pfx & VEX_PREFIX_SCALAR_MASK); @@ -5352,7 +5330,7 @@ x86_emulate( CASE_SIMD_PACKED_INT_VEX(0x0f, 0xc4): /* pinsrw $imm8,r32/m16,{,x}mm */ /* vpinsrw $imm8,r32/m16,xmm,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); memcpy(mmvalp, &src.val, 2); ea.type = OP_MEM; state->simd_size = simd_other; @@ -5363,7 +5341,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0xc4): /* vpinsrw $imm8,r32/m16,xmm,xmm */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x20): /* vpinsrb $imm8,r32/m8,xmm,xmm */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x22): /* vpinsr{d,q} $imm8,r/m,xmm,xmm */ - generate_exception_if(evex.lr || evex.opmsk || evex.brs, EXC_UD); + generate_exception_if(evex.lr || evex.opmsk || evex.brs, X86_EXC_UD); if ( b & 2 ) host_and_vcpu_must_have(avx512dq); else @@ -5380,7 +5358,7 @@ x86_emulate( CASE_SIMD_PACKED_INT_VEX(0x0f, 0xc5): /* pextrw $imm8,{,x}mm,reg */ /* vpextrw $imm8,xmm,reg */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); opc = init_prefixes(stub); opc[0] = b; /* Convert GPR destination to %rAX. */ @@ -5397,7 +5375,7 @@ x86_emulate( CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0xc6): /* vshufp{s,d} $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ generate_exception_if(evex.w != (evex.pfx & VEX_PREFIX_DOUBLE_MASK), - EXC_UD); + X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x03): /* valign{d,q} $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ fault_suppression = false; @@ -5405,7 +5383,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x25): /* vpternlog{d,q} $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ avx512f_imm8_no_sae: host_and_vcpu_must_have(avx512f); - generate_exception_if(ea.type != OP_MEM && evex.brs, EXC_UD); + generate_exception_if(ea.type != OP_MEM && evex.brs, X86_EXC_UD); avx512_vlen_check(false); goto simd_imm8_zmm; @@ -5442,7 +5420,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0xe2): /* vpsra{d,q} xmm/m128,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f, 0xf2): /* vpslld xmm/m128,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f, 0xf3): /* vpsllq xmm/m128,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x0c): /* vpermilps [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x0d): /* vpermilpd [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -5455,7 +5433,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0xfe): /* vpaddd [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x1e): /* vpabsd [xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x1f): /* vpabsq [xyz]mm/mem,[xyz]mm{k} */ - generate_exception_if(evex.w != (b & 1), EXC_UD); + generate_exception_if(evex.w != (b & 1), X86_EXC_UD); goto avx512f_no_sae; #endif /* !X86EMUL_NO_SIMD */ @@ -5472,7 +5450,7 @@ x86_emulate( case X86EMUL_OPC_F3(0x0f, 0xd6): /* movq2dq mm,xmm */ case X86EMUL_OPC_F2(0x0f, 0xd6): /* movdq2q xmm,mm */ - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); op_bytes = 8; host_and_vcpu_must_have(mmx); goto simd_0f_int; @@ -5481,7 +5459,7 @@ x86_emulate( #ifndef X86EMUL_NO_MMX case X86EMUL_OPC(0x0f, 0xe7): /* movntq mm,m64 */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); sfence = true; /* fall through */ case X86EMUL_OPC(0x0f, 0xda): /* pminub mm/m64,mm */ @@ -5504,7 +5482,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f, 0xea): /* vpminsw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f, 0xee): /* vpmaxsw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); elem_bytes = b & 0x10 ? 1 : 2; goto avx512f_no_sae; @@ -5521,10 +5499,10 @@ x86_emulate( #endif /* !X86EMUL_NO_SIMD */ CASE_SIMD_PACKED_INT_VEX(0x0f, 0xf7): /* {,v}maskmov{q,dqu} {,x}mm,{,x}mm */ - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); if ( vex.opcx != vex_none ) { - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); d |= TwoOp; host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); @@ -5627,23 +5605,23 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f38, 0x19): /* vbroadcastsd xmm/m64,ymm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x1a): /* vbroadcastf128 m128,ymm */ - generate_exception_if(!vex.l, EXC_UD); + generate_exception_if(!vex.l, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_VEX_66(0x0f38, 0x18): /* vbroadcastss xmm/m32,{x,y}mm */ if ( ea.type != OP_MEM ) { - generate_exception_if(b & 2, EXC_UD); + generate_exception_if(b & 2, X86_EXC_UD); host_and_vcpu_must_have(avx2); } /* fall through */ case X86EMUL_OPC_VEX_66(0x0f38, 0x0c): /* vpermilps {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x0d): /* vpermilpd {x,y}mm/mem,{x,y}mm,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_avx; case X86EMUL_OPC_VEX_66(0x0f38, 0x0e): /* vtestps {x,y}mm/mem,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x0f): /* vtestpd {x,y}mm/mem,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_66(0x0f38, 0x17): /* ptest xmm/m128,xmm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x17): /* vptest {x,y}mm/mem,{x,y}mm */ @@ -5654,7 +5632,7 @@ x86_emulate( } else { - generate_exception_if(vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); } @@ -5729,7 +5707,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x11): /* vpsravw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x12): /* vpsllvw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(!evex.w || evex.brs, EXC_UD); + generate_exception_if(!evex.w || evex.brs, X86_EXC_UD); elem_bytes = 2; goto avx512f_no_sae; @@ -5751,7 +5729,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x33): /* vpmovzxwd {x,y}mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x34): /* vpmovzxwq xmm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x35): /* vpmovzxdq {x,y}mm/mem,[xyz]mm{k} */ - generate_exception_if(evex.w && (b & 7) == 5, EXC_UD); + generate_exception_if(evex.w && (b & 7) == 5, X86_EXC_UD); } else { @@ -5770,22 +5748,22 @@ x86_emulate( case X86EMUL_OPC_EVEX_F3(0x0f38, 0x33): /* vpmovdw [xyz]mm,{x,y}mm/mem{k} */ case X86EMUL_OPC_EVEX_F3(0x0f38, 0x34): /* vpmovqw [xyz]mm,xmm/mem{k} */ case X86EMUL_OPC_EVEX_F3(0x0f38, 0x35): /* vpmovqd [xyz]mm,{x,y}mm/mem{k} */ - generate_exception_if(evex.w || (ea.type != OP_REG && evex.z), EXC_UD); + generate_exception_if(evex.w || (ea.type != OP_REG && evex.z), X86_EXC_UD); d = DstMem | SrcReg | TwoOp; } - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); op_bytes = 32 >> (pmov_convert_delta[b & 7] + 1 - evex.lr); elem_bytes = (b & 7) < 3 ? 1 : (b & 7) != 5 ? 2 : 4; goto avx512f_no_sae; case X86EMUL_OPC_VEX_66(0x0f38, 0x13): /* vcvtph2ps xmm/mem,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); host_and_vcpu_must_have(f16c); op_bytes = 8 << vex.l; goto simd_0f_ymm; case X86EMUL_OPC_EVEX_66(0x0f38, 0x13): /* vcvtph2ps {x,y}mm/mem,[xyz]mm{k} */ - generate_exception_if(evex.w || (ea.type != OP_REG && evex.brs), EXC_UD); + generate_exception_if(evex.w || (ea.type != OP_REG && evex.brs), X86_EXC_UD); host_and_vcpu_must_have(avx512f); if ( !evex.brs ) avx512_vlen_check(false); @@ -5795,19 +5773,19 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f38, 0x16): /* vpermps ymm/m256,ymm,ymm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x36): /* vpermd ymm/m256,ymm,ymm */ - generate_exception_if(!vex.l || vex.w, EXC_UD); + generate_exception_if(!vex.l || vex.w, X86_EXC_UD); goto simd_0f_avx2; case X86EMUL_OPC_EVEX_66(0x0f38, 0x16): /* vpermp{s,d} {y,z}mm/mem,{y,z}mm,{y,z}mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x36): /* vperm{d,q} {y,z}mm/mem,{y,z}mm,{y,z}mm{k} */ - generate_exception_if(!evex.lr, EXC_UD); + generate_exception_if(!evex.lr, X86_EXC_UD); fault_suppression = false; goto avx512f_no_sae; case X86EMUL_OPC_EVEX_66(0x0f38, 0x18): /* vbroadcastss xmm/m32,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x58): /* vpbroadcastd xmm/m32,[xyz]mm{k} */ op_bytes = elem_bytes; - generate_exception_if(evex.w || evex.brs, EXC_UD); + generate_exception_if(evex.w || evex.brs, X86_EXC_UD); avx512_broadcast: /* * For the respective code below the main switch() to work we need to @@ -5828,17 +5806,17 @@ x86_emulate( /* vbroadcastf64x4 m256,zmm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x5b): /* vbroadcasti32x8 m256,zmm{k} */ /* vbroadcasti64x4 m256,zmm{k} */ - generate_exception_if(ea.type != OP_MEM || evex.lr != 2, EXC_UD); + generate_exception_if(ea.type != OP_MEM || evex.lr != 2, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x19): /* vbroadcastsd xmm/m64,{y,z}mm{k} */ /* vbroadcastf32x2 xmm/m64,{y,z}mm{k} */ - generate_exception_if(!evex.lr, EXC_UD); + generate_exception_if(!evex.lr, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x59): /* vpbroadcastq xmm/m64,[xyz]mm{k} */ /* vbroadcasti32x2 xmm/m64,[xyz]mm{k} */ if ( b == 0x59 ) op_bytes = 8; - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); if ( !evex.w ) host_and_vcpu_must_have(avx512dq); goto avx512_broadcast; @@ -5848,7 +5826,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x5a): /* vbroadcasti32x4 m128,{y,z}mm{k} */ /* vbroadcasti64x2 m128,{y,z}mm{k} */ generate_exception_if(ea.type != OP_MEM || !evex.lr || evex.brs, - EXC_UD); + X86_EXC_UD); if ( evex.w ) host_and_vcpu_must_have(avx512dq); goto avx512_broadcast; @@ -5870,7 +5848,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_F3(0x0f38, 0x29): /* vpmov{b,w}2m [xyz]mm,k */ case X86EMUL_OPC_EVEX_F3(0x0f38, 0x39): /* vpmov{d,q}2m [xyz]mm,k */ - generate_exception_if(!evex.r || !evex.R, EXC_UD); + generate_exception_if(!evex.r || !evex.R, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_F3(0x0f38, 0x28): /* vpmovm2{b,w} k,[xyz]mm */ case X86EMUL_OPC_EVEX_F3(0x0f38, 0x38): /* vpmovm2{d,q} k,[xyz]mm */ @@ -5878,14 +5856,14 @@ x86_emulate( host_and_vcpu_must_have(avx512dq); else host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.opmsk || ea.type != OP_REG, EXC_UD); + generate_exception_if(evex.opmsk || ea.type != OP_REG, X86_EXC_UD); d |= TwoOp; op_bytes = 16 << evex.lr; goto avx512f_no_sae; case X86EMUL_OPC_66(0x0f38, 0x2a): /* movntdqa m128,xmm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x2a): /* vmovntdqa mem,{x,y}mm */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); /* Ignore the non-temporal hint for now, using movdqa instead. */ asm volatile ( "mfence" ::: "memory" ); b = 0x6f; @@ -5901,7 +5879,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x2a): /* vmovntdqa mem,[xyz]mm */ generate_exception_if(ea.type != OP_MEM || evex.opmsk || evex.w, - EXC_UD); + X86_EXC_UD); /* Ignore the non-temporal hint for now, using vmovdqa32 instead. */ asm volatile ( "mfence" ::: "memory" ); b = 0x6f; @@ -5912,7 +5890,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_F3(0x0f38, 0x3a): /* vpbroadcastmw2d k,[xyz]mm */ generate_exception_if((ea.type != OP_REG || evex.opmsk || evex.w == ((b >> 4) & 1)), - EXC_UD); + X86_EXC_UD); d |= TwoOp; /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0xc4): /* vpconflict{d,q} [xyz]mm/mem,[xyz]mm{k} */ @@ -5929,7 +5907,7 @@ x86_emulate( { typeof(vex) *pvex; - generate_exception_if(ea.type != OP_MEM || vex.w, EXC_UD); + generate_exception_if(ea.type != OP_MEM || vex.w, X86_EXC_UD); host_and_vcpu_must_have(avx); elem_bytes = 4 << (b & 1); vmaskmov: @@ -6016,7 +5994,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0xbf): /* vfnmsub231s{s,d} xmm/mem,xmm,xmm{k} */ host_and_vcpu_must_have(avx512f); simd_zmm_scalar_sae: - generate_exception_if(ea.type != OP_REG && evex.brs, EXC_UD); + generate_exception_if(ea.type != OP_REG && evex.brs, X86_EXC_UD); if ( !evex.brs ) avx512_vlen_check(true); goto simd_zmm; @@ -6030,7 +6008,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x3c): /* vpmaxsb [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x3e): /* vpmaxuw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); elem_bytes = b & 2 ?: 1; goto avx512f_no_sae; @@ -6050,7 +6028,7 @@ x86_emulate( goto simd_0f38_common; /* fall through */ case X86EMUL_OPC_VEX_66(0x0f38, 0x41): /* vphminposuw xmm/m128,xmm,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); goto simd_0f_avx; case X86EMUL_OPC_VEX_66(0x0f38, 0x50): /* vpdpbusd [xy]mm/mem,[xy]mm,[xy]mm */ @@ -6058,7 +6036,7 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f38, 0x52): /* vpdpwssd [xy]mm/mem,[xy]mm,[xy]mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x53): /* vpdpwssds [xy]mm/mem,[xy]mm,[xy]mm */ host_and_vcpu_must_have(avx_vnni); - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_avx; case X86EMUL_OPC_EVEX_66(0x0f38, 0x50): /* vpdpbusd [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -6066,7 +6044,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x52): /* vpdpwssd [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x53): /* vpdpwssds [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512_vnni); - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); goto avx512f_no_sae; case X86EMUL_OPC_EVEX_F2(0x0f38, 0x72): /* vcvtne2ps2bf16 [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -6078,7 +6056,7 @@ x86_emulate( /* fall through */ case X86EMUL_OPC_EVEX_F3(0x0f38, 0x52): /* vdpbf16ps [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512_bf16); - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); op_bytes = 16 << evex.lr; goto avx512f_no_sae; @@ -6089,13 +6067,13 @@ x86_emulate( op_bytes = 1 << ((!(b & 0x20) * 2) + (b & 1)); /* fall through */ case X86EMUL_OPC_VEX_66(0x0f38, 0x46): /* vpsravd {x,y}mm/mem,{x,y}mm,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_avx2; case X86EMUL_OPC_EVEX_66(0x0f38, 0x4d): /* vrcp14s{s,d} xmm/mem,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x4f): /* vrsqrt14s{s,d} xmm/mem,xmm,xmm{k} */ host_and_vcpu_must_have(avx512f); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); avx512_vlen_check(true); goto simd_zmm; @@ -6104,19 +6082,19 @@ x86_emulate( host_and_vcpu_must_have(avx512_4vnniw); generate_exception_if((ea.type != OP_MEM || evex.w || evex.brs || evex.lr != 2), - EXC_UD); + X86_EXC_UD); op_mask = op_mask & 0xffff ? 0xf : 0; goto simd_zmm; case X86EMUL_OPC_EVEX_66(0x0f38, 0x8f): /* vpshufbitqmb [xyz]mm/mem,[xyz]mm,k{k} */ - generate_exception_if(evex.w || !evex.r || !evex.R || evex.z, EXC_UD); + generate_exception_if(evex.w || !evex.r || !evex.R || evex.z, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x54): /* vpopcnt{b,w} [xyz]mm/mem,[xyz]mm{k} */ host_and_vcpu_must_have(avx512_bitalg); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x66): /* vpblendm{b,w} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); elem_bytes = 1 << evex.w; goto avx512f_no_sae; @@ -6125,7 +6103,7 @@ x86_emulate( goto avx512f_no_sae; case X86EMUL_OPC_VEX_66(0x0f38, 0x5a): /* vbroadcasti128 m128,ymm */ - generate_exception_if(ea.type != OP_MEM || !vex.l || vex.w, EXC_UD); + generate_exception_if(ea.type != OP_MEM || !vex.l || vex.w, X86_EXC_UD); goto simd_0f_avx2; case X86EMUL_OPC_EVEX_66(0x0f38, 0x62): /* vpexpand{b,w} [xyz]mm/mem,[xyz]mm{k} */ @@ -6138,7 +6116,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x8a): /* vcompressp{s,d} [xyz]mm,[xyz]mm/mem{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x8b): /* vpcompress{d,q} [xyz]mm,[xyz]mm/mem{k} */ host_and_vcpu_must_have(avx512f); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); avx512_vlen_check(false); /* * For the respective code below the main switch() to work we need to @@ -6160,13 +6138,13 @@ x86_emulate( case X86EMUL_OPC_EVEX_F2(0x0f38, 0x68): /* vp2intersect{d,q} [xyz]mm/mem,[xyz]mm,k+1 */ host_and_vcpu_must_have(avx512_vp2intersect); - generate_exception_if(evex.opmsk || !evex.r || !evex.R, EXC_UD); + generate_exception_if(evex.opmsk || !evex.r || !evex.R, X86_EXC_UD); op_bytes = 16 << evex.lr; goto avx512f_no_sae; case X86EMUL_OPC_EVEX_66(0x0f38, 0x70): /* vpshldvw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x72): /* vpshrdvw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); elem_bytes = 2; /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x71): /* vpshldv{d,q} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -6181,14 +6159,14 @@ x86_emulate( host_and_vcpu_must_have(avx512_vbmi); else host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); fault_suppression = false; goto avx512f_no_sae; case X86EMUL_OPC_EVEX_66(0x0f38, 0x78): /* vpbroadcastb xmm/m8,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x79): /* vpbroadcastw xmm/m16,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.w || evex.brs, EXC_UD); + generate_exception_if(evex.w || evex.brs, X86_EXC_UD); op_bytes = elem_bytes = 1 << (b & 1); /* See the comment at the avx512_broadcast label. */ op_mask |= !(b & 1 ? !(uint32_t)op_mask : !op_mask); @@ -6197,12 +6175,12 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0x7a): /* vpbroadcastb r32,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x7b): /* vpbroadcastw r32,[xyz]mm{k} */ host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f38, 0x7c): /* vpbroadcast{d,q} reg,[xyz]mm{k} */ generate_exception_if((ea.type != OP_REG || evex.brs || evex.reg != 0xf || !evex.RX), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); avx512_vlen_check(false); get_fpu(X86EMUL_FPU_zmm); @@ -6228,21 +6206,21 @@ x86_emulate( case X86EMUL_OPC_66(0x0f38, 0x82): /* invpcid reg,m128 */ vcpu_must_have(invpcid); - generate_exception_if(ea.type != OP_MEM, EXC_UD); - generate_exception_if(!mode_ring0(), EXC_GP, 0); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); if ( (rc = ops->read(ea.mem.seg, ea.mem.off, mmvalp, 16, ctxt)) != X86EMUL_OKAY ) goto done; - generate_exception_if(mmvalp->xmm[0] & ~0xfff, EXC_GP, 0); + generate_exception_if(mmvalp->xmm[0] & ~0xfff, X86_EXC_GP, 0); dst.val = mode_64bit() ? *dst.reg : (uint32_t)*dst.reg; switch ( dst.val ) { case X86_INVPCID_INDIV_ADDR: generate_exception_if(!is_canonical_address(mmvalp->xmm[1]), - EXC_GP, 0); + X86_EXC_GP, 0); /* fall through */ case X86_INVPCID_SINGLE_CTXT: if ( !mode_64bit() || !ops->read_cr ) @@ -6250,13 +6228,13 @@ x86_emulate( else if ( (rc = ops->read_cr(4, &cr4, ctxt)) != X86EMUL_OKAY ) goto done; generate_exception_if(!(cr4 & X86_CR4_PCIDE) && mmvalp->xmm[0], - EXC_GP, 0); + X86_EXC_GP, 0); break; case X86_INVPCID_ALL_INCL_GLOBAL: case X86_INVPCID_ALL_NON_GLOBAL: break; default: - generate_exception(EXC_GP, 0); + generate_exception(X86_EXC_GP, 0); } fail_if(!ops->tlb_op); @@ -6271,14 +6249,14 @@ x86_emulate( #ifndef X86EMUL_NO_SIMD case X86EMUL_OPC_EVEX_66(0x0f38, 0x83): /* vpmultishiftqb [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); host_and_vcpu_must_have(avx512_vbmi); fault_suppression = false; goto avx512f_no_sae; case X86EMUL_OPC_VEX_66(0x0f38, 0x8c): /* vpmaskmov{d,q} mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0x8e): /* vpmaskmov{d,q} {x,y}mm,{x,y}mm,mem */ - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); host_and_vcpu_must_have(avx2); elem_bytes = 4 << vex.w; goto vmaskmov; @@ -6299,8 +6277,8 @@ x86_emulate( ASSERT(ea.type == OP_MEM); generate_exception_if(modrm_reg == state->sib_index || modrm_reg == mask_reg || - state->sib_index == mask_reg, EXC_UD); - generate_exception_if(!cpu_has_avx, EXC_UD); + state->sib_index == mask_reg, X86_EXC_UD); + generate_exception_if(!cpu_has_avx, X86_EXC_UD); vcpu_must_have(avx2); get_fpu(X86EMUL_FPU_ymm); @@ -6419,7 +6397,7 @@ x86_emulate( generate_exception_if((!evex.opmsk || evex.brs || evex.z || evex.reg != 0xf || modrm_reg == state->sib_index), - EXC_UD); + X86_EXC_UD); avx512_vlen_check(false); host_and_vcpu_must_have(avx512f); get_fpu(X86EMUL_FPU_zmm); @@ -6569,7 +6547,7 @@ x86_emulate( host_and_vcpu_must_have(avx512_4fmaps); generate_exception_if((ea.type != OP_MEM || evex.w || evex.brs || evex.lr != 2), - EXC_UD); + X86_EXC_UD); op_mask = op_mask & 0xffff ? 0xf : 0; goto simd_zmm; @@ -6578,7 +6556,7 @@ x86_emulate( host_and_vcpu_must_have(avx512_4fmaps); generate_exception_if((ea.type != OP_MEM || evex.w || evex.brs || evex.lr == 3), - EXC_UD); + X86_EXC_UD); op_mask = op_mask & 1 ? 0xf : 0; goto simd_zmm; @@ -6599,7 +6577,7 @@ x86_emulate( generate_exception_if((!evex.opmsk || evex.brs || evex.z || evex.reg != 0xf || modrm_reg == state->sib_index), - EXC_UD); + X86_EXC_UD); avx512_vlen_check(false); host_and_vcpu_must_have(avx512f); get_fpu(X86EMUL_FPU_zmm); @@ -6706,7 +6684,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0xb4): /* vpmadd52luq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f38, 0xb5): /* vpmadd52huq [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(avx512_ifma); - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); goto avx512f_no_sae; case X86EMUL_OPC_EVEX_66(0x0f38, 0xc6): @@ -6723,7 +6701,7 @@ x86_emulate( ASSERT(ea.type == OP_MEM); generate_exception_if((!cpu_has_avx512f || !evex.opmsk || evex.brs || evex.z || evex.reg != 0xf || evex.lr != 2), - EXC_UD); + X86_EXC_UD); switch ( modrm_reg & 7 ) { @@ -6734,7 +6712,7 @@ x86_emulate( vcpu_must_have(avx512pf); break; default: - generate_exception(EXC_UD); + generate_exception(X86_EXC_UD); } get_fpu(X86EMUL_FPU_zmm); @@ -6815,7 +6793,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0xcc): /* vrsqrt28p{s,d} zmm/mem,zmm{k} */ host_and_vcpu_must_have(avx512er); generate_exception_if((ea.type != OP_REG || !evex.brs) && evex.lr != 2, - EXC_UD); + X86_EXC_UD); goto simd_zmm; case X86EMUL_OPC_EVEX_66(0x0f38, 0xcb): /* vrcp28s{s,d} xmm/mem,xmm,xmm{k} */ @@ -6829,12 +6807,12 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f38, 0xcf): /* vgf2p8mulb {x,y}mm/mem,{x,y}mm,{x,y}mm */ host_and_vcpu_must_have(gfni); - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_avx; case X86EMUL_OPC_EVEX_66(0x0f38, 0xcf): /* vgf2p8mulb [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(gfni); - generate_exception_if(evex.w || evex.brs, EXC_UD); + generate_exception_if(evex.w || evex.brs, X86_EXC_UD); elem_bytes = 1; goto avx512f_no_sae; @@ -6853,7 +6831,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0xde): /* vaesdec [xyz]mm/mem,[xyz]mm,[xyz]mm */ case X86EMUL_OPC_EVEX_66(0x0f38, 0xdf): /* vaesdeclast [xyz]mm/mem,[xyz]mm,[xyz]mm */ host_and_vcpu_must_have(vaes); - generate_exception_if(evex.brs || evex.opmsk, EXC_UD); + generate_exception_if(evex.brs || evex.opmsk, X86_EXC_UD); goto avx512f_no_sae; #endif /* !X86EMUL_NO_SIMD */ @@ -6926,7 +6904,7 @@ x86_emulate( host_and_vcpu_must_have(bmi2); else host_and_vcpu_must_have(bmi1); - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); buf[0] = 0xc4; *pvex = vex; @@ -6960,7 +6938,7 @@ x86_emulate( goto unrecognized_insn; } - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); buf[0] = 0xc4; *pvex = vex; @@ -7013,7 +6991,7 @@ x86_emulate( case X86EMUL_OPC_VEX_F2(0x0f38, 0xf6): /* mulx r/m,r,r */ vcpu_must_have(bmi2); - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); ea.reg = decode_vex_gpr(vex.reg, &_regs, ctxt); if ( mode_64bit() && vex.w ) asm ( "mulq %3" : "=a" (*ea.reg), "=d" (dst.val) @@ -7025,10 +7003,10 @@ x86_emulate( case X86EMUL_OPC_66(0x0f38, 0xf8): /* movdir64b r,m512 */ host_and_vcpu_must_have(movdir64b); - generate_exception_if(ea.type != OP_MEM, EXC_UD); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); src.val = truncate_ea(*dst.reg); generate_exception_if(!is_aligned(x86_seg_es, src.val, 64, ctxt, ops), - EXC_GP, 0); + X86_EXC_GP, 0); fail_if(!ops->blk); state->blk = blk_movdir; BUILD_BUG_ON(sizeof(*mmvalp) < 64); @@ -7043,11 +7021,11 @@ x86_emulate( case X86EMUL_OPC_F2(0x0f38, 0xf8): /* enqcmd r,m512 */ case X86EMUL_OPC_F3(0x0f38, 0xf8): /* enqcmds r,m512 */ host_and_vcpu_must_have(enqcmd); - generate_exception_if(ea.type != OP_MEM, EXC_UD); - generate_exception_if(vex.pfx != vex_f2 && !mode_ring0(), EXC_GP, 0); + generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); + generate_exception_if(vex.pfx != vex_f2 && !mode_ring0(), X86_EXC_GP, 0); src.val = truncate_ea(*dst.reg); generate_exception_if(!is_aligned(x86_seg_es, src.val, 64, ctxt, ops), - EXC_GP, 0); + X86_EXC_GP, 0); fail_if(!ops->blk); BUILD_BUG_ON(sizeof(*mmvalp) < 64); if ( (rc = ops->read(ea.mem.seg, ea.mem.off, mmvalp, 64, @@ -7055,16 +7033,16 @@ x86_emulate( goto done; if ( vex.pfx == vex_f2 ) /* enqcmd */ { - generate_exception_if(mmvalp->data32[0], EXC_GP, 0); + generate_exception_if(mmvalp->data32[0], X86_EXC_GP, 0); fail_if(!ops->read_msr); if ( (rc = ops->read_msr(MSR_PASID, &msr_val, ctxt)) != X86EMUL_OKAY ) goto done; - generate_exception_if(!(msr_val & PASID_VALID), EXC_GP, 0); + generate_exception_if(!(msr_val & PASID_VALID), X86_EXC_GP, 0); mmvalp->data32[0] = MASK_EXTR(msr_val, PASID_PASID_MASK); } else - generate_exception_if(mmvalp->data32[0] & 0x7ff00000, EXC_GP, 0); + generate_exception_if(mmvalp->data32[0] & 0x7ff00000, X86_EXC_GP, 0); state->blk = blk_enqcmd; if ( (rc = ops->blk(x86_seg_es, src.val, mmvalp, 64, &_regs.eflags, state, ctxt)) != X86EMUL_OKAY ) @@ -7074,7 +7052,7 @@ x86_emulate( case X86EMUL_OPC(0x0f38, 0xf9): /* movdiri mem,r */ host_and_vcpu_must_have(movdiri); - generate_exception_if(dst.type != OP_MEM, EXC_UD); + generate_exception_if(dst.type != OP_MEM, X86_EXC_UD); fail_if(!ops->blk); state->blk = blk_movdir; if ( (rc = ops->blk(dst.mem.seg, dst.mem.off, &src.val, op_bytes, @@ -7087,37 +7065,37 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f3a, 0x00): /* vpermq $imm8,ymm/m256,ymm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x01): /* vpermpd $imm8,ymm/m256,ymm */ - generate_exception_if(!vex.l || !vex.w, EXC_UD); + generate_exception_if(!vex.l || !vex.w, X86_EXC_UD); goto simd_0f_imm8_avx2; case X86EMUL_OPC_EVEX_66(0x0f3a, 0x00): /* vpermq $imm8,{y,z}mm/mem,{y,z}mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x01): /* vpermpd $imm8,{y,z}mm/mem,{y,z}mm{k} */ - generate_exception_if(!evex.lr || !evex.w, EXC_UD); + generate_exception_if(!evex.lr || !evex.w, X86_EXC_UD); fault_suppression = false; goto avx512f_imm8_no_sae; case X86EMUL_OPC_VEX_66(0x0f3a, 0x38): /* vinserti128 $imm8,xmm/m128,ymm,ymm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x39): /* vextracti128 $imm8,ymm,xmm/m128 */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x46): /* vperm2i128 $imm8,ymm/m256,ymm,ymm */ - generate_exception_if(!vex.l, EXC_UD); + generate_exception_if(!vex.l, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x02): /* vpblendd $imm8,{x,y}mm/mem,{x,y}mm,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_imm8_avx2; case X86EMUL_OPC_VEX_66(0x0f3a, 0x06): /* vperm2f128 $imm8,ymm/m256,ymm,ymm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x18): /* vinsertf128 $imm8,xmm/m128,ymm,ymm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x19): /* vextractf128 $imm8,ymm,xmm/m128 */ - generate_exception_if(!vex.l, EXC_UD); + generate_exception_if(!vex.l, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x04): /* vpermilps $imm8,{x,y}mm/mem,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x05): /* vpermilpd $imm8,{x,y}mm/mem,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_imm8_avx; case X86EMUL_OPC_EVEX_66(0x0f3a, 0x04): /* vpermilps $imm8,[xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x05): /* vpermilpd $imm8,[xyz]mm/mem,[xyz]mm{k} */ - generate_exception_if(evex.w != (b & 1), EXC_UD); + generate_exception_if(evex.w != (b & 1), X86_EXC_UD); fault_suppression = false; goto avx512f_imm8_no_sae; @@ -7136,12 +7114,12 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x0a): /* vrndscaless $imm8,xmm/mem,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x0b): /* vrndscalesd $imm8,xmm/mem,xmm,xmm{k} */ - generate_exception_if(ea.type != OP_REG && evex.brs, EXC_UD); + generate_exception_if(ea.type != OP_REG && evex.brs, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x08): /* vrndscaleps $imm8,[xyz]mm/mem,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x09): /* vrndscalepd $imm8,[xyz]mm/mem,[xyz]mm{k} */ host_and_vcpu_must_have(avx512f); - generate_exception_if(evex.w != (b & 1), EXC_UD); + generate_exception_if(evex.w != (b & 1), X86_EXC_UD); avx512_vlen_check(b & 2); goto simd_imm8_zmm; @@ -7177,7 +7155,7 @@ x86_emulate( #ifndef X86EMUL_NO_SIMD case X86EMUL_OPC_EVEX_66(0x0f3a, 0x42): /* vdbpsadbw $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(evex.w, EXC_UD); + generate_exception_if(evex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x0f): /* vpalignr $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ fault_suppression = false; @@ -7225,7 +7203,7 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f3a, 0x15): /* vpextrw $imm8,xmm,r/m */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x16): /* vpextr{d,q} $imm8,xmm,r/m */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x17): /* vextractps $imm8,xmm,r/m */ - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); @@ -7237,7 +7215,7 @@ x86_emulate( goto pextr; case X86EMUL_OPC_EVEX_66(0x0f, 0xc5): /* vpextrw $imm8,xmm,reg */ - generate_exception_if(ea.type != OP_REG, EXC_UD); + generate_exception_if(ea.type != OP_REG, X86_EXC_UD); /* Convert to alternative encoding: We want to use a memory operand. */ evex.opcx = ext_0f3a; b = 0x15; @@ -7251,7 +7229,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x17): /* vextractps $imm8,xmm,r/m */ generate_exception_if((evex.lr || evex.reg != 0xf || !evex.RX || evex.opmsk || evex.brs), - EXC_UD); + X86_EXC_UD); if ( !(b & 2) ) host_and_vcpu_must_have(avx512bw); else if ( !(b & 1) ) @@ -7272,13 +7250,13 @@ x86_emulate( /* vextracti64x2 $imm8,{y,z}mm,xmm/m128{k} */ if ( evex.w ) host_and_vcpu_must_have(avx512dq); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x23): /* vshuff32x4 $imm8,{y,z}mm/mem,{y,z}mm,{y,z}mm{k} */ /* vshuff64x2 $imm8,{y,z}mm/mem,{y,z}mm,{y,z}mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x43): /* vshufi32x4 $imm8,{y,z}mm/mem,{y,z}mm,{y,z}mm{k} */ /* vshufi64x2 $imm8,{y,z}mm/mem,{y,z}mm,{y,z}mm{k} */ - generate_exception_if(!evex.lr, EXC_UD); + generate_exception_if(!evex.lr, X86_EXC_UD); fault_suppression = false; goto avx512f_imm8_no_sae; @@ -7292,7 +7270,7 @@ x86_emulate( /* vextracti64x4 $imm8,zmm,ymm/m256{k} */ if ( !evex.w ) host_and_vcpu_must_have(avx512dq); - generate_exception_if(evex.lr != 2 || evex.brs, EXC_UD); + generate_exception_if(evex.lr != 2 || evex.brs, X86_EXC_UD); fault_suppression = false; goto avx512f_imm8_no_sae; @@ -7306,14 +7284,14 @@ x86_emulate( { generate_exception_if((evex.w || evex.reg != 0xf || !evex.RX || (ea.type != OP_REG && (evex.z || evex.brs))), - EXC_UD); + X86_EXC_UD); host_and_vcpu_must_have(avx512f); avx512_vlen_check(false); opc = init_evex(stub); } else { - generate_exception_if(vex.w || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.w || vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(f16c); opc = init_prefixes(stub); } @@ -7395,12 +7373,12 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x1f): /* vpcmp{d,q} $imm8,[xyz]mm/mem,[xyz]mm,k{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x3e): /* vpcmpu{b,w} $imm8,[xyz]mm/mem,[xyz]mm,k{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x3f): /* vpcmp{b,w} $imm8,[xyz]mm/mem,[xyz]mm,k{k} */ - generate_exception_if(!evex.r || !evex.R || evex.z, EXC_UD); + generate_exception_if(!evex.r || !evex.R || evex.z, X86_EXC_UD); if ( !(b & 0x20) ) goto avx512f_imm8_no_sae; avx512bw_imm: host_and_vcpu_must_have(avx512bw); - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); elem_bytes = 1 << evex.w; avx512_vlen_check(false); goto simd_imm8_zmm; @@ -7416,7 +7394,7 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f3a, 0x20): /* vpinsrb $imm8,r32/m8,xmm,xmm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x22): /* vpinsr{d,q} $imm8,r/m,xmm,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); if ( !mode_64bit() ) vex.w = 0; memcpy(mmvalp, &src.val, src.bytes); @@ -7434,13 +7412,13 @@ x86_emulate( op_bytes = 4; /* fall through */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x41): /* vdppd $imm8,{x,y}mm/mem,{x,y}mm,{x,y}mm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); goto simd_0f_imm8_avx; case X86EMUL_OPC_EVEX_66(0x0f3a, 0x21): /* vinsertps $imm8,xmm/m32,xmm,xmm */ host_and_vcpu_must_have(avx512f); generate_exception_if(evex.lr || evex.w || evex.opmsk || evex.brs, - EXC_UD); + X86_EXC_UD); op_bytes = 4; goto simd_imm8_zmm; @@ -7462,7 +7440,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x27): /* vgetmants{s,d} $imm8,xmm/mem,xmm,xmm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x55): /* vfixupimms{s,d} $imm8,xmm/mem,xmm,xmm{k} */ host_and_vcpu_must_have(avx512f); - generate_exception_if(ea.type != OP_REG && evex.brs, EXC_UD); + generate_exception_if(ea.type != OP_REG && evex.brs, X86_EXC_UD); if ( !evex.brs ) avx512_vlen_check(true); goto simd_imm8_zmm; @@ -7473,7 +7451,7 @@ x86_emulate( host_and_vcpu_must_have(avx512dq); opmask_shift_imm: generate_exception_if(vex.l || !vex.r || vex.reg != 0xf || - ea.type != OP_REG, EXC_UD); + ea.type != OP_REG, X86_EXC_UD); host_and_vcpu_must_have(avx512f); get_fpu(X86EMUL_FPU_opmask); op_bytes = 1; /* Any non-zero value will do. */ @@ -7495,7 +7473,7 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x44): /* vpclmulqdq $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm */ host_and_vcpu_must_have(vpclmulqdq); - generate_exception_if(evex.brs || evex.opmsk, EXC_UD); + generate_exception_if(evex.brs || evex.opmsk, X86_EXC_UD); goto avx512f_imm8_no_sae; case X86EMUL_OPC_VEX_66(0x0f3a, 0x48): /* vpermil2ps $imm,{x,y}mm/mem,{x,y}mm,{x,y}mm,{x,y}mm */ @@ -7507,11 +7485,11 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f3a, 0x4a): /* vblendvps {x,y}mm,{x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0x4b): /* vblendvpd {x,y}mm,{x,y}mm/mem,{x,y}mm,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_imm8_avx; case X86EMUL_OPC_VEX_66(0x0f3a, 0x4c): /* vpblendvb {x,y}mm,{x,y}mm/mem,{x,y}mm,{x,y}mm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_int_imm8; case X86EMUL_OPC_VEX_66(0x0f3a, 0x5c): /* vfmaddsubps {x,y}mm,{x,y}mm/mem,{x,y}mm,{x,y}mm */ @@ -7572,7 +7550,7 @@ x86_emulate( } else { - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); host_and_vcpu_must_have(avx); get_fpu(X86EMUL_FPU_ymm); } @@ -7623,16 +7601,16 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f3a, 0x66): /* vfpclassp{s,d} $imm8,[xyz]mm/mem,k{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x67): /* vfpclasss{s,d} $imm8,xmm/mem,k{k} */ host_and_vcpu_must_have(avx512dq); - generate_exception_if(!evex.r || !evex.R || evex.z, EXC_UD); + generate_exception_if(!evex.r || !evex.R || evex.z, X86_EXC_UD); if ( !(b & 1) ) goto avx512f_imm8_no_sae; - generate_exception_if(evex.brs, EXC_UD); + generate_exception_if(evex.brs, X86_EXC_UD); avx512_vlen_check(true); goto simd_imm8_zmm; case X86EMUL_OPC_EVEX_66(0x0f3a, 0x70): /* vpshldw $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x72): /* vpshrdw $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); elem_bytes = 2; /* fall through */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0x71): /* vpshld{d,q} $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ @@ -7653,13 +7631,13 @@ x86_emulate( case X86EMUL_OPC_VEX_66(0x0f3a, 0xce): /* vgf2p8affineqb $imm8,{x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0xcf): /* vgf2p8affineinvqb $imm8,{x,y}mm/mem,{x,y}mm,{x,y}mm */ host_and_vcpu_must_have(gfni); - generate_exception_if(!vex.w, EXC_UD); + generate_exception_if(!vex.w, X86_EXC_UD); goto simd_0f_imm8_avx; case X86EMUL_OPC_EVEX_66(0x0f3a, 0xce): /* vgf2p8affineqb $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ case X86EMUL_OPC_EVEX_66(0x0f3a, 0xcf): /* vgf2p8affineinvqb $imm8,[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */ host_and_vcpu_must_have(gfni); - generate_exception_if(!evex.w, EXC_UD); + generate_exception_if(!evex.w, X86_EXC_UD); fault_suppression = false; goto avx512f_imm8_no_sae; @@ -7668,14 +7646,14 @@ x86_emulate( host_and_vcpu_must_have(aesni); if ( vex.opcx == vex_none ) goto simd_0f3a_common; - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); goto simd_0f_imm8_avx; #endif /* X86EMUL_NO_SIMD */ case X86EMUL_OPC_VEX_F2(0x0f3a, 0xf0): /* rorx imm,r/m,r */ vcpu_must_have(bmi2); - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); if ( ea.type == OP_REG ) src.val = *ea.reg; else if ( (rc = read_ulong(ea.mem.seg, ea.mem.off, &src.val, op_bytes, @@ -7713,11 +7691,11 @@ x86_emulate( case X86EMUL_OPC_XOP(08, 0xed): /* vpcomuw $imm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0xee): /* vpcomud $imm,xmm/m128,xmm,xmm */ case X86EMUL_OPC_XOP(08, 0xef): /* vpcomuq $imm,xmm/m128,xmm,xmm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_XOP(08, 0xa3): /* vpperm xmm/m128,xmm,xmm,xmm */ /* vpperm xmm,xmm/m128,xmm,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_XOP(08, 0xa2): /* vpcmov {x,y}mm/mem,{x,y}mm,{x,y}mm,{x,y}mm */ /* vpcmov {x,y}mm,{x,y}mm/mem,{x,y}mm,{x,y}mm */ @@ -7747,7 +7725,7 @@ x86_emulate( uint8_t *buf = get_stub(stub); typeof(vex) *pxop = container_of(buf + 1, typeof(vex), raw[0]); - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); buf[0] = 0x8f; *pxop = vex; @@ -7781,7 +7759,7 @@ x86_emulate( case 0: /* llwpcb r */ case 1: /* slwpcb r */ /* LWP is unsupported, so produce #UD unconditionally. */ - generate_exception(EXC_UD); + generate_exception(X86_EXC_UD); } goto unrecognized_insn; @@ -7789,12 +7767,12 @@ x86_emulate( case X86EMUL_OPC_XOP(09, 0x82): /* vfrczss xmm/m128,xmm */ case X86EMUL_OPC_XOP(09, 0x83): /* vfrczsd xmm/m128,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_XOP(09, 0x80): /* vfrczps {x,y}mm/mem,{x,y}mm */ case X86EMUL_OPC_XOP(09, 0x81): /* vfrczpd {x,y}mm/mem,{x,y}mm */ host_and_vcpu_must_have(xop); - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); goto simd_0f_ymm; case X86EMUL_OPC_XOP(09, 0xc1): /* vphaddbw xmm/m128,xmm */ @@ -7812,7 +7790,7 @@ x86_emulate( case X86EMUL_OPC_XOP(09, 0xe2): /* vphsubwd xmm/m128,xmm */ case X86EMUL_OPC_XOP(09, 0xe3): /* vphsubdq xmm/m128,xmm */ case X86EMUL_OPC_XOP(09, 0xe1): /* vphsubbw xmm/m128,xmm */ - generate_exception_if(vex.w, EXC_UD); + generate_exception_if(vex.w, X86_EXC_UD); /* fall through */ case X86EMUL_OPC_XOP(09, 0x90): /* vprotb xmm/m128,xmm,xmm */ /* vprotb xmm,xmm/m128,xmm */ @@ -7838,7 +7816,7 @@ x86_emulate( /* vpshad xmm,xmm/m128,xmm */ case X86EMUL_OPC_XOP(09, 0x9b): /* vpshaq xmm/m128,xmm,xmm */ /* vpshaq xmm,xmm/m128,xmm */ - generate_exception_if(vex.l, EXC_UD); + generate_exception_if(vex.l, X86_EXC_UD); host_and_vcpu_must_have(xop); goto simd_0f_ymm; @@ -7850,7 +7828,7 @@ x86_emulate( typeof(vex) *pxop = container_of(buf + 1, typeof(vex), raw[0]); host_and_vcpu_must_have(tbm); - generate_exception_if(vex.l || vex.reg != 0xf, EXC_UD); + generate_exception_if(vex.l || vex.reg != 0xf, X86_EXC_UD); if ( ea.type == OP_REG ) src.val = *ea.reg; @@ -7879,7 +7857,7 @@ x86_emulate( case 0: /* lwpins $imm32,r/m,r */ case 1: /* lwpval $imm32,r/m,r */ /* LWP is unsupported, so produce #UD unconditionally. */ - generate_exception(EXC_UD); + generate_exception(X86_EXC_UD); } goto unrecognized_insn; @@ -7946,10 +7924,10 @@ x86_emulate( } else if ( state->simd_size ) { - generate_exception_if(!op_bytes, EXC_UD); + generate_exception_if(!op_bytes, X86_EXC_UD); generate_exception_if((vex.opcx && (d & TwoOp) && (vex.reg != 0xf || (evex_encoded() && !evex.RX))), - EXC_UD); + X86_EXC_UD); if ( !opc ) BUG(); @@ -7988,7 +7966,7 @@ x86_emulate( generate_exception_if(!(mxcsr & MXCSR_MM) && !is_aligned(ea.mem.seg, ea.mem.off, op_bytes, ctxt, ops), - EXC_GP, 0); + X86_EXC_GP, 0); EXPECT(elem_bytes > 0); if ( evex.brs ) @@ -8159,14 +8137,15 @@ x86_emulate( #ifdef __XEN__ emulation_stub_failure: - generate_exception_if(stub_exn.info.fields.trapnr == EXC_MF, EXC_MF); - if ( stub_exn.info.fields.trapnr == EXC_XM ) + if ( stub_exn.info.fields.trapnr == X86_EXC_MF ) + generate_exception(X86_EXC_MF); + if ( stub_exn.info.fields.trapnr == X86_EXC_XM ) { unsigned long cr4; if ( !ops->read_cr || ops->read_cr(4, &cr4, ctxt) != X86EMUL_OKAY ) cr4 = X86_CR4_OSXMMEXCPT; - generate_exception(cr4 & X86_CR4_OSXMMEXCPT ? EXC_XM : EXC_UD); + generate_exception(cr4 & X86_CR4_OSXMMEXCPT ? X86_EXC_XM : X86_EXC_UD); } gprintk(XENLOG_WARNING, "exception %u (ec=%04x) in emulation stub (line %u)\n", @@ -8174,7 +8153,8 @@ x86_emulate( stub_exn.line); gprintk(XENLOG_INFO, " stub: %"__stringify(MAX_INST_LEN)"ph\n", stub.func); - generate_exception_if(stub_exn.info.fields.trapnr == EXC_UD, EXC_UD); + if ( stub_exn.info.fields.trapnr == X86_EXC_UD ) + generate_exception(X86_EXC_UD); domain_crash(current->domain); #endif -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 12:51:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 12:51:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518890.805868 (Exim 4.92) (envelope-from ) id 1pkP4u-0007E4-Hf; Thu, 06 Apr 2023 12:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518890.805868; Thu, 06 Apr 2023 12:51:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkP4u-0007Dx-Ea; Thu, 06 Apr 2023 12:51:00 +0000 Received: by outflank-mailman (input) for mailman id 518890; Thu, 06 Apr 2023 12:50:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkP4t-0007Dq-3Z for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 12:50:59 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20602.outbound.protection.outlook.com [2a01:111:f400:7eaf::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab7799c1-d479-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 14:50:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9125.eurprd04.prod.outlook.com (2603:10a6:20b:448::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Thu, 6 Apr 2023 12:50:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 12:50:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab7799c1-d479-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J3NtU0wWqoFjQARZxeccDknpYgzMHrdG0B/1uPOCX0xNEp4P9VYJw4YBNyJQfdSiXkkqZO9g0LV7V+fwhIwMC5MXo94tMOGqgC4RvbwnZP9myL4+Ns4Zp9FuESUF7eO2gSA1WDNUnmrSvJddJz85dJsoMcQVENj25Xc2CLNIf2QdOo3QefpvVGz3kDOwFEKig3cdRL6OP5S+lCGaah0YdRJrRZAIhi1237M/ieinJIQptLbyL8HWrkHqZ7mBkUPKf56fXcTte0NZANFokdF/YDDT9jX9PuagmNLIrzYKBZsZGkhrm39Uh4LflPH6djOFF9Cz2216URTWmQ3S0becfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5xZejxViod/vAIC5FopSmY3XD32mS+AFSGh0OUJ3uR8=; b=mx+3+JedwpW4xdmYgJS62Dat4gcIJdBxqC9Zpr/Mzi9Wp3Atu9/vp6g7FDlV/6zJ1XXNwaUBU6GUD014z/lFMvbZw3F2nsF+jmoBNe3zxmKKnAGgYcNi88LC4ue4NbEYE6DDpUhycXgpfUD/NT9k9nggVP5YVh8jcmyLR6skQMrv7liSZcP+GMrPv2hdM+a/lN61pI8LTaVC4WY9Qoxshd3nr04+RDIpGjJHD9pG/S3eiOE9mkGt4g+mHrkO9X357cXGi35b7lrtVKTtMLUhgQPCD4OSsoha48HRF+YvqKbiHXq8fgEw6wE9Bdkya6eobi4eiwqk5i/0bjXyeMkZWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5xZejxViod/vAIC5FopSmY3XD32mS+AFSGh0OUJ3uR8=; b=ov/BG0ZooURQfQxGo0bVCoJvkcEhdSWHpPK92qyFFSo7qLZFvNEkzfPpWA1MjtR5+ClsMfJQsSJb/SknhbtK36B0Jq3v48eEkIp8xArUc3qU3nRwGDYzrLVNNNDTHrXPF/y8Jf6ucktOAnjtLtCiKkAqlubrFlm99FXP6/9Ob7QuMmcJJ7mrK3WVxo3CCwF2yVElwnQR7/f1N4zbBzgSA4ovsiH/qqCX2pyYkNMOcD5e9E475MlYZToe4wyezkShl5a1sSX9MzK1Of/QsbpLo0MPEwYotCtN57Abu/H6ULCgRdoWTTAM7y5/Q6tMtNfbr1WpPXfDO8T268WAdFmVYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <44079a26-4631-135e-6593-78f7c2d2319f@suse.com> Date: Thu, 6 Apr 2023 14:50:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/emul: Use existing X86_EXC_* constants Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230406121753.2205968-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230406121753.2205968-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9125:EE_ X-MS-Office365-Filtering-Correlation-Id: efc3b920-ae50-4b73-5ee4-08db369d8ea5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6agV14GSanjTleYQAtz2iOuZDBvEeDOCNol/8x2li+O1OoZ3Iqt9oqIbxjH3mthAGPGvkyFl3HV5oXRaOGDEDPGG6951fceclhfjAOubzM/DBDE4+RtfBjk0r8CJMx7E6L+yBCNSF/cqy+3h1qOgfUKVgV7PowjlqMXv3Y449uJl7sdp8Kv6rLCGkJR8yPCmLQDhT7JYZTpcjKvu9qq0PbOjQocAS7/y285Bh85qSozb/OUbA9LXx8Y9yCHeqzzuL9K7VOKC/mYX1N98Ig2jK5szGtkY7HeDXYWBvDLpQRVmaefGXk7QLuEuaVd6o51EO1sBSgwOZUW56B5WdUFMrDX5ee3xlbvHobXcJIZkYAhpRzLC+4BCRmycRZeDOov6p7atZUC0ca+Kyv/Vjga3sznVN/czTKTiFl7U6eHo4OQw0vgGh0Y+VBHyMldJ2o3ydXCqVcuXrGky55yMnHN0Uc5zxlw1bWHwHOnGaR6lA3JgETaEGr2fRqLwjo/IaRfwm6wTBPvED3zzU5WoJVUZZYYZX8vXWzPZUJ3M+r0yUZtv0ibM4wQINcd5kQx4GIazol5qFWFMTacOegrAi3v/2S8zJ80eApXqeKRnI8LXkxPM5j/1B/P+J3yDERhM2+z3ab9UAMoo4BHhpuQbnI5sFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(66556008)(66476007)(54906003)(478600001)(316002)(86362001)(8936002)(36756003)(5660300002)(4744005)(2906002)(4326008)(6916009)(8676002)(31696002)(38100700002)(41300700001)(66946007)(6486002)(186003)(26005)(6512007)(53546011)(31686004)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3IvYW8rVVo2TTNKTkZxdlNJYnFPVVN3YmdZUDlPTElRWDhRYW0vY29QSEJZ?= =?utf-8?B?ZjByZ3VvQmt6TURldm1Bb1RDYmJGckdXUGEzV2JMb3hibzlqWHBoSEM2UjJn?= =?utf-8?B?SjJuSFFIV3loT092U1U4SlEzYTRPTUMvYnR2Yjd1bk9SaXZHMHVZUFRXM1Y1?= =?utf-8?B?R1U3VmJDNENYUmg5eDRmZzdKdkJQYWFjcldGL1I1NUVWb0hCZUhTVGFkVVo1?= =?utf-8?B?U2liSS8wTEZhNHNxNHc0YzZRbVdSdElKUFJUdWVMREhXSTF0ZUx4ZGNrbjhD?= =?utf-8?B?NVI3SDRnbGs2aTFvMlZ5bHpVNEtOZlZHUDNNWUNYN3UyaEJoeFRGaVh2M3Zo?= =?utf-8?B?NE5kcjlxMUNyRk1DcTYwZDFhZkN4a3dGSlZjWFRwOFZHU0NaQ3N3M2hqRmcv?= =?utf-8?B?QXJGSS9FWFlSM3ZJSVF3QmdUaHhGWHlVbk9pVUdHQStlVGFRRGQ3aU4zVnR2?= =?utf-8?B?MFVlc2YxVU54WlVYSDV3MjY1bVc5N1UzQ0NVU01BWUtobitjb0VLWmRaL0dJ?= =?utf-8?B?cDJDbDNTa1U0eVV1S0YvYlNuMWpZdmRHQnB2d1JRZW5tL2hPV1ViNUE3eFdG?= =?utf-8?B?dzFnUU9CRVNpOVk2L3Zmc0FwRTlJZE1YRGM2Q3RJWXZXenA3YUFzWG5kclN6?= =?utf-8?B?Q0NJZUR4TjUvM3NiVkQxaktadlNxcUtVRkk3WWRDcWlXOXNvT3RaclI1elhy?= =?utf-8?B?bHBJc1kzTXVLQlNzeTFsN0NWNCs0c2JGeWprb0ppNUpNbjUvaU56aEx5RDRU?= =?utf-8?B?TWpTRm1jM2JJOUpXNjNVQndXZC85ME01S0RyditWS0VneTgrMENFZ082dndl?= =?utf-8?B?b3dCTjlScTQ5MDhrdllvR2pMTzJYeGRDVkdaek5WZmh4ekN0dTB0dkVienJW?= =?utf-8?B?d1d0KzVCMnFtZkxEMW14Z2xjZ0h2WXhQcGU3ejZTbVovMlJHa0QxTnpLaExD?= =?utf-8?B?WEl0NlhFaVptOS91a0JKeXlRQ1BSU09NVGZKODVVbFd5VWhReDhFNDNNT1Qr?= =?utf-8?B?K3AzMlI1d3VGLzBnU1VCZklsMWNtZzlPYzZSM2pOeld0UiszcEdtcFBIejNT?= =?utf-8?B?R2c2cElSSmx5TGgzOG9wbFBoTTBUa2NJdDJZT3FBbkM0SXdkVjZpeURuYVZL?= =?utf-8?B?ZmRQem44d3lxc2UwN1pXZ0lpNEU1RWtldlU0aGMxSHhYZDNzcWdZeWlDNmln?= =?utf-8?B?Q0MrZnRoSUhGUkVsd2kwR3ZEdzdNclBFc29YcWxNRXhRY1RjcGhkbnpnWSs1?= =?utf-8?B?Ni9Gdlo5RUNvV0ZNaG9DQUZmL1lRNnBHNEtOUjJGMklVYXYvYmVEL0dWZ05p?= =?utf-8?B?VFdpYXlkTFhpR0lrc1FmRGVJdzFtYm9IV29NOXhtMzMrb3duRExXY3QzOE92?= =?utf-8?B?ZUNVeWNENFc5YVJseHllbThrYU5sUWZRWFNrRW9LZlN0MytZVHFpT25PSCtt?= =?utf-8?B?ODQvWDJpNkFiNll0SFoyRzI0VHdRR2s0Q2JoZFpSaW5MVHZRSGgzMzN2djZv?= =?utf-8?B?d2VRVVExSlpLeWlLMnhSRHRITE9HdHBqUnU5L2dZQUNrNkt1eVdOK3U2d0N5?= =?utf-8?B?RkNvMnNmdFJzTW5mdWRkUC9ZWkV1WDlUM1ZUWGZISExNazJsZ2Q5aEgrTFNK?= =?utf-8?B?bFpRNnM4bmg0L3pVNDJRUEpVVW5uUXNocjhzTHV4UytuZHZodHVYclNxaG9n?= =?utf-8?B?NlFWSWFLK3BxeTliMGJVTGhXc0swL0F2NWZHNFRncXhVVnZSdWJHSERGdGJV?= =?utf-8?B?ekZxd3hod1lTTklQMzNMdUJhNU5qdTR4dXhLNU9Vdm45Nk1waVpGaTlwVWtz?= =?utf-8?B?YWVnQ2taS1dCd080eVhOclc3KzFENGswVFd1ejdsY0FxTHJEOWdRWVB0bUsr?= =?utf-8?B?dDA2NFNJanRKcjVRS1ErdDV4S1QrSEl0U2duZXplT0QvUXUxL09LS09CTUll?= =?utf-8?B?eUQ2Si92aGdsK1RYOFkyUlNWaDMzU3ZnVmZ0WlB6VXpQb0hMaDVqaWIvcE1s?= =?utf-8?B?cGZiMTJRd3FRaFMzdTROK0JQMXZxZXdkWUlFNHFaNG9ZUjc4VUM1S2VvM1pm?= =?utf-8?B?OGdvNGYvZ25sNGFkUlovVjVpbXNZdnZTUmhjdkJuNHhuYjhJZCtmYnZkQU9D?= =?utf-8?Q?CcpNklaqO6tgeT7pMePgcO6lY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: efc3b920-ae50-4b73-5ee4-08db369d8ea5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 12:50:53.6372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: knpPdms6tQyIXLmdsi8OKpgWSKo55ZyXMo31l1j/DmCp8N+eHoX0TgmvyTCcuyHutd41i+M3nbfdQr4O2/QskA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9125 On 06.04.2023 14:17, Andrew Cooper wrote: > ... rather than having separate definitions locally. EXC_HAS_EC in particular > is missing #CP, #VC and #SX vs X86_EXC_HAVE_EC. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Yet more re-basing for me to do ... But yes, it needs to happen at some point, and I guess there never really is a good time. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 12:55:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 12:55:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518893.805877 (Exim 4.92) (envelope-from ) id 1pkP9Q-0007qi-2b; Thu, 06 Apr 2023 12:55:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518893.805877; Thu, 06 Apr 2023 12:55:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkP9P-0007qb-WC; Thu, 06 Apr 2023 12:55:40 +0000 Received: by outflank-mailman (input) for mailman id 518893; Thu, 06 Apr 2023 12:55:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkP9P-0007qV-Cf for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 12:55:39 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52aa5002-d47a-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 14:55:37 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 08:55:34 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6055.namprd03.prod.outlook.com (2603:10b6:208:31b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Thu, 6 Apr 2023 12:55:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 12:55:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52aa5002-d47a-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680785737; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=f0e7cYEDAEpcNAwlYi35VuHziRZ/GApB1egynoWXhLI=; b=JpWNA7JuCchMq+xDqoaiTaPh/Rw43ySfeJqR2l0IzUYDHN6dsu82MEI9 veddTKGXveBx/j2mzjt+o+XxiWtKUA9AQlVIZpVpktjndYsZ/q9B8tLN9 SpWZKHlmTyvr0Nvnl0MS2mTRgOZGQ2nvX54vN2fXbPChNTIKCdbdjGG1E g=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 104589109 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RVZPYqCNr+ZYZxVW/wTiw5YqxClBgxIJ4kV8jS/XYbTApG521WRVy TFNC2+DOv2Ma2XzcookbYW2/BxU68TTnIU1QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwqqFSWmdh8 NchKzVRNg2OrfCTkYKnY7w57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvDG7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwX6rCdtKRdVU8NZFkEWR6EFLEiYXXGepm9eX1nCTQ+l2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBRw1V5dDm+ds3lkiWEY8lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:Os7Ei6sch0mc3oz00g0C2zYP7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104589109" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUl88M0CGOehIOeLZBqa0+8IhsJFsbvuaoMkk4f6wSIj/pI+CEqsiG3nCdrScsxSJr1g1Ma7rLhNeOvQ3L4zIIawx7aPnbwgiyOuM3n5OvDkM7nhFyLh7TOepL8F4/BjSKT/b+dEBWTQLztdoqBbX8u/Nawlo6StY0TzIoR/e+dgIbTCOCJoWaBL8Gqho4fbrddMh3BxlnvL3DpKJAwcqzk6t3dSgCkBvjxUn2kiOfQQWqhExrp5v6XlwYTiOaXuT1sXsdhvkPkWfs2UqWef793HiQdT6ttP/rq6D6ESQ5b465ChkfSKCvM8/qufgV9qvqFyVRFwqLntsfeZisPttQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zD9k4AldTQrQV43R4LFqH4lhnBEpEDFokua341KF7u8=; b=XF+9+XqB50Z/+jemjJeTYFhUDENUX8smR8S8FXqMHa60qtf6nnow/zUU6yWLDLXUDjQ5NPmxE9ushx+NJuD1yAxO1lCjpGDSLjT4UYbW0g1ZL78PynIPFlOJgHRSXZ2oHrasA2lCj8aL3nO9e2+j3nvXwjQcJP9j70KDGIO+Vc+7J7RuLeTruGMdPzjnGRoi4ZGpDd8ds3WWlq/OQzZOEME4CSD1N3T7vemQJeDQ6vvPBcRCybIJhkBmOo46ZoXjzwbIjh0a76HjODTd64dQrQRBySB9G5j6ccSwDLYRLnBtzVc6djceF9gLV14Fpt+dCheBW2ruDbPjY9UnfSzhIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zD9k4AldTQrQV43R4LFqH4lhnBEpEDFokua341KF7u8=; b=MFFgN0JZCyL4NzJBxx8oSHirl2NgLX/r8++MV4Z+r4ERhxDwxi59PcmlqwW1iY/9frAeIqlRZ4o8qbT0yGmsWH8CLpQyBqf4Mph4+KD/7GsJk/AyBMmznduIf3FTHiQNlN5QCLOKQRnouzKRMbJFywPQ07CrbPZBnyCyFblmVWs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <18f32ddf-a62f-d3b9-5b57-f808b5b72f06@citrix.com> Date: Thu, 6 Apr 2023 13:55:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/emul: Use existing X86_EXC_* constants Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230406121753.2205968-1-andrew.cooper3@citrix.com> <44079a26-4631-135e-6593-78f7c2d2319f@suse.com> In-Reply-To: <44079a26-4631-135e-6593-78f7c2d2319f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0462.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BL1PR03MB6055:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d1e6a28-400b-4ad4-1972-08db369e346c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xcwu7DNNlSK7wdJ/RRGnfFtLnOTRtB0HI+U95GoiYsHhIEkGRxJHhiOj3bxqFqkHBShyX0HrkMVFeNY5J6WnuUyM673FbQiBhcX1mx73ouW+/1Sv2pUvyVsANHvIp3BNJYIFCwAHGxeWFmiFoyOkbAPgbxXgHCk99sbs3jxqWCcKMir6zHOGLKJ9W+ZtgBykFrqKaU1HQs8mS4EdCe2rsAugwV17oxFXdFi4eUAsli7HTxyUJYhQE/YHKz394AwxzQ+elomBN69DXkaH+P21ffxkVKb4WN3dfCuZbVra+l9+zfEeCWMDxCqxqySO2MKGorC8eYtqSx3sdqroBQsh3SJadVCd02nyUUJW63wDrIyApq1TWPUg+QD591aN4qbHt0fPMiXWhR+xtu4pXY3hfh1q5mZ4Y00FsLK59JpcQ+62v/+dyWTGrj32oqgyo//o/nQ0R3pxDk5d+XEaj1tDoTcacFDaayzSAJJSgjHTaerxBKEFfDmPrHIVjETj0+BlbZEmUmyVBMC8Pw0m+8BiSaAfBrwopx8K/tjGxdzOx8vVyWV8TamfQkWhPQX/Mh78eOTay2srjJ7sdLxbmfwLMJLMceCEA2XrGGUZ/0EsVxn77rf3pgakJzb91cmebjlLfI9Xhl9vg2WlVQclsoT4lw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199021)(6666004)(26005)(6506007)(53546011)(6512007)(31686004)(8936002)(186003)(2616005)(6486002)(478600001)(38100700002)(41300700001)(66946007)(66476007)(2906002)(66556008)(36756003)(6916009)(31696002)(316002)(5660300002)(4326008)(4744005)(8676002)(86362001)(54906003)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXFEVThnanY5S0kwZmZuZG1MaG9uUzl0R2VodlF3dk9DbEM4aXMwRUd2b2Zw?= =?utf-8?B?MEcrZERZcHdGRm9iOVBWTWZRMnZjeGdyY3gvcGhiQUE0TWVWWkpPaEZSOWFw?= =?utf-8?B?Wk9hNGFnY1ltRnhaSkhiS0ZHSFMwV3ViMWl0a094S0YzQVlOb01Cc2RkK0da?= =?utf-8?B?Njd0NndmRUs3UGs2bFJPcjJMNWNrV0J0QjVhd0N0N0F4SEMvOGtCRExSUFg3?= =?utf-8?B?SEhxUDZkNWJqdG5yVlJtb09yUTZ1a25IY3JpcytvTEE5SG1zUnFQM1Mrcldq?= =?utf-8?B?SUxnNWJOOFIwMkN0OWIrYStMZW9tNlg3OEJtSTQwVW9US2pVc0VvVk1sOTRP?= =?utf-8?B?bGQwempDOHRrOVFUU2FUQU5oNzdMbW5mQlI5NWd4bXcvRjVSL1h6Sk9qOXNU?= =?utf-8?B?QUd2RkNiK05LTENSTXdRYkQxV3AwUVFEYlZsTFZ2RmlPbGNhL3pmS005bjY2?= =?utf-8?B?VDE3bzZyQkUxQlVQMmdJb3JqZ1RzYkJyZXVKcGhZWjVtSUI3UFRYK28vdnpX?= =?utf-8?B?UlZITEZEeVBlcGtHL3RvQmpZWTgxZ2NzdVkyVVFORUJIclRsSm8zcjJNbzIr?= =?utf-8?B?OU1hcTlYK1UwNEJnVHpCcGZib1EzK2ZyZDc5Y0hXNFU2a0R3WjBSNzR0T05s?= =?utf-8?B?b0NnRXUvTStxcEhyaWVxbTFLTkxiZHplcUhCdmxyS1VtdDZ4UXg5dkhSMHBX?= =?utf-8?B?cW1zTGZ2bHdxTmlTLytxaHJXUllrdGhQdlpvclpySzlhbGRveUJ3cFY3UHNa?= =?utf-8?B?VFRyanZuOFNia2lPc1VjRVdHWDhpTDl6M21tYTZXMHZranZFcXppODczUTlR?= =?utf-8?B?UTFPVERNekYvS290K21VUCtTZmV4WTVSVWVBaDNCcEpQMkhwbXBhZGp5L29q?= =?utf-8?B?UG51TkFEcGZOVmROdk5FWDhsSnEyZE9ReWo3UnZqbTRnYmhnamlNWlZiYjUx?= =?utf-8?B?MEpWQ2U5dXV5dk5aSThqVDZLczl5WkhTdmtuSWYrOXFPdFVSbTVtVkZoZEZs?= =?utf-8?B?TUtaQ283R3gvOTRCalp2Y21Nc0crS25zNmZ4ejR5eHBDMjJ0dktSdTRIV1Ji?= =?utf-8?B?YnMvWE9semZYQmlieThCVEZnTXp2NEtUbjZWc0VwenYxWXU2VDNXU29wVG95?= =?utf-8?B?MDVlcEY3NngwaEZzY3M5RmVSQWx5TXMyb2VIcTFIUmVLNWlKT3FQMEI5M0Ra?= =?utf-8?B?R2lpamI3aUZ0N3pWZW5pNzlTenBWQWFFdTZ1d2xYZ2lnZVR2SWlKdGxPbDlG?= =?utf-8?B?ZHM3aVRWdUU5V2UxSkZCNDErdDNuMWw5cUJLaWViajlnUkNmOTEzTGc3dlJQ?= =?utf-8?B?Y1pDTjZUT1BZZVlwZXNTSnFzaW40di81VU14NXNhcjRGVTFHWmpFOHE1SCtj?= =?utf-8?B?dlBuMGM5TjZMNHRQcy9XdEt5MW8wWjh3cmdTWEp0Mk1GWXRqTkpDL1VwWVpI?= =?utf-8?B?VmhidG1ac3VTOEFkTm5aVXYwSHlINHlPTmJ3ZThJdHhkZGRPZmVwbkdkNTBQ?= =?utf-8?B?QzFyekRPRUlsVHNnTUM0U0JqR1I3RzgwTS9TNlN4QVdnNk1TT1ZxV2hOVnN5?= =?utf-8?B?Q0tRSHZQQkFGSFdXQzU4Z3ZHNlgyM3c4ZGhDZWlYbkx3N20veXlIWmhDSy9G?= =?utf-8?B?eGY1a2JjWWpxbFZuaFYrNUw2K0dNZnNGeFYyZjBMUUhmaERIRVlDTTZldUdj?= =?utf-8?B?VEpXNUo5bnRaUkZXMW1mZG5HOURzUnRTYzRmc3dqaDVwS3RDOTJIY1UxbGh0?= =?utf-8?B?bk1DVzJ1SUptN082alJtQnRpcnYvd3liQzlZQzNHelNwUWhWMHlMZEU2TmU5?= =?utf-8?B?dlYyQmVYd3BpRFRtTlFkc3hRVzU1T0pIUEJmQTd4dzM5by9Hb3E2RWFTTUY0?= =?utf-8?B?dWdjRUpXemhCc0EwRzhyS1VjQ2lldEJucGgwZFNXQmhaMmxFV20xc0ZMYytY?= =?utf-8?B?U1p3WEFyQ0JWcnV3TFQyTEM3SjdiZUVoRlk3MFBuS0ZIS0xrdU5aK0o1S3Fq?= =?utf-8?B?ZTk5OEZHMit5M1RoNzlGR3pmQURUc1QxUXZGZHQ1UXNiZ1dmMmlXZlBNeFdP?= =?utf-8?B?RTRqdHgreU1DMUNHZXJBem0wYXg5bHJNVVNhZkYvSThNYklvOVpRZTR0bjZt?= =?utf-8?B?NFllY1pXblJqaXhDR1lXN3kxdTBUT0dXWE5jM0xPcHBEREIxMG1GWU9OVDVq?= =?utf-8?B?enc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 09jt7/srIb0/6oUes9oVLsW2Auddca0z5UaISgb55FoHhVuwhBcmqfETzGq7j7XUpn/QWo9a0WOWuH1Mos2HXLqH+UeTEG2duS5M9Y7OjKNgOGM1D4DctXVw37HaNDkzjSBoV539Klv1GlOfNxHJy10vDGhy8KzhAAHk1eZavsZBB0WK/GEtAwAP2louTpWIhAG0TZ2ZBA99rd5ofcm49+OFc3X5ZIT4HOoTqJkiCt+ekrW7LX/DshVmyskcSyAwHKJk0a+06znFteCsxdr8QxK4nhQx4ogsgRtQddcYQR1K5JTmxE/54rI5EjkIeXQz+NzDWHW+pLIlFUu3gu2IBFc9Z7LDw1eVaO6NNhvbJWssQnwp9xYEqvb9/YYovd2VcBPlqRAhKYoPpvM1w1WHa4RoiccIaEMdIbR7PcpmFdwHOd3PvPL88fkJlaCewrZgFKnoUndWlIDJG2uUIduL0FgalyjRhDJs9Tyb7dipO2PZKbVGCElR1HrWaKL1ISSlBjORFScsySFb9tOrzrloxW37mWEyFoJTk8mZwVERiXs9VLWZObLKl79HkgWHbDMIRRXElvrLqxOwFreQhSFr302tI7LhNePbONlbdkAQI5wGtvu0K9wHVV6dBZb2/HfNO0CuXZg9nunGgQKSTll4W62nOoiBrGdZDpCyQA1H90XvRtaNmKNt6aexVwU9JfuA9ClOVREfv+TCYGLgUU4ldxTQyP38Wd+tpVP2X8YOFYY39kqxGg5wvs8mnQQw3cwWDLW0vkvbH/O45a93U7lasfH8u/KbZ6n13xXVIosSWgaYLFkq3DIdbzrRichdIsOe X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d1e6a28-400b-4ad4-1972-08db369e346c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 12:55:31.8326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kHHVWUkwyw7kuyPpqCAq8/uRNLNHAxFsaSWyFj4o99tHnrWIyHnC+lMeRvlZe3Y52iaMbBk6j0nLvqL7VrCUdG3ZbebBEvhz2w98KZabgGM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6055 On 06/04/2023 1:50 pm, Jan Beulich wrote: > On 06.04.2023 14:17, Andrew Cooper wrote: >> ... rather than having separate definitions locally. EXC_HAS_EC in particular >> is missing #CP, #VC and #SX vs X86_EXC_HAVE_EC. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich Thanks. > Yet more re-basing for me to do ... And me... I'm somewhat alarmed with how may branch collisions I've had with the TRAP_* change. > But yes, it needs to happen at some > point, and I guess there never really is a good time. Yeah, but doing it together with the TRAP_* change is going to be least disruptive (overall) to others. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 13:27:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 13:27:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518897.805887 (Exim 4.92) (envelope-from ) id 1pkPe3-0002nq-Gv; Thu, 06 Apr 2023 13:27:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518897.805887; Thu, 06 Apr 2023 13:27:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkPe3-0002nj-ED; Thu, 06 Apr 2023 13:27:19 +0000 Received: by outflank-mailman (input) for mailman id 518897; Thu, 06 Apr 2023 13:27:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkPe1-0002nd-NT for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 13:27:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be64ea88-d47e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 15:27:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be64ea88-d47e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680787635; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=y04BQ2DKaMiAf2Lo6AP/11T/yXr87e1AoI+G7Y+pvh8=; b=gtpOmiZhOxC1QASDeIUsvNOuwTUe/xnG2a4eXMH2FBM+Rw/gEC14B3An MOVDxiodNgVukL9yK1+NouaA8zXOc/+bYCO0DKb6nGFD3ppq1YTh+om29 65U/Yx/ZOyChynkZbQW7f+sKHcQKsdK+pK1CxEHgqCMeSB/6+T/HunqNW 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 104973764 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:U9UVuasLZ48MXQVn4538a63OrOfnVCleMUV32f8akzHdYApBsoF/q tZmKW+FaazeamGmeIgnPYu+oE1XusDcyNFiHARtqi03Ei4W+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGySFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwFA8WdB+t2v2P2b+JWMNjr+syD8/EFdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw/ zqarjuiXU9GXDCZ4WGMqjXzjOXKpx3yZK41EIyb1/9Xv1LGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8UYwgyQzqvf4y6CG3MJCDVGbbQOq8seVTEsk FiTkLvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZTc6+MPsjtwstwvCfMRJH4ean/7zNhill lhmsxMCa6UvYd8jjvvrpQ+d3mjx/fAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9o4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/i4So20CKGLM4MSCnSUSONg1Hg3DXN8Iki3yBR8+U3BE czznTmQ4YYyVv08kWveqxY12r433CEurV7uqWTA503/i9K2PSfFIYrpxXPSNojVGovY+lSKm zueXuPWoyhivBrWOHWPrtRNcwFUdRDWx/ne8qRqSwJKGSI+cElJNhMb6ehJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23:zxa8BKqBkzZArzFf3gdDDgUaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104973764" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/svm: Provide EXITINFO decodes for Exceptions/NPT intercepts Date: Thu, 6 Apr 2023 14:27:08 +0100 Message-ID: <20230406132708.2251000-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Exceptions and NPT intercepts almost have the same layout, but NPT has bits above 31 in the error code, and the name for exitinfo2 really does want distinguishing between cr2 and gpa. In nsvm_vcpu_vmexit_inject() rearrange VMEXIT_NPF to fall through instead of repeating the exitinfo1 write. Use the fallthrough pseudo keyword instead of a comment. In VMEXIT_NPF, as we're editing the printk() anyway, switch to using the newer domain_crash() form. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/svm/nestedsvm.c | 9 +++------ xen/arch/x86/hvm/svm/svm.c | 23 ++++++++++------------- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 10 ++++++++++ 3 files changed, 23 insertions(+), 19 deletions(-) diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 2003f28f66f4..51e437e73a20 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -824,14 +824,11 @@ nsvm_vcpu_vmexit_inject(struct vcpu *v, struct cpu_user_regs *regs, ns_vmcb->exit_int_info = ns_vmcb->event_inj; break; case VMEXIT_EXCEPTION_PF: - ns_vmcb->_cr2 = ns_vmcb->exitinfo2; - /* fall through */ + ns_vmcb->_cr2 = ns_vmcb->ei.exc.cr2; + fallthrough; case VMEXIT_NPF: - /* PF error code */ - ns_vmcb->exitinfo1 = svm->ns_vmexit.exitinfo1; - /* fault address */ ns_vmcb->exitinfo2 = svm->ns_vmexit.exitinfo2; - break; + fallthrough; case VMEXIT_EXCEPTION_NP: case VMEXIT_EXCEPTION_SS: case VMEXIT_EXCEPTION_GP: diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 1b32ef77b643..17359047b396 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -2808,9 +2808,9 @@ void svm_vmexit_handler(void) case VMEXIT_EXCEPTION_PF: { - unsigned long va; - va = vmcb->exitinfo2; - regs->error_code = vmcb->exitinfo1; + unsigned long va = vmcb->ei.exc.cr2; + + regs->error_code = vmcb->ei.exc.ec; HVM_DBG_LOG(DBG_LEVEL_VMMU, "eax=%lx, ebx=%lx, ecx=%lx, edx=%lx, esi=%lx, edi=%lx", regs->rax, regs->rbx, regs->rcx, @@ -2838,7 +2838,7 @@ void svm_vmexit_handler(void) case VMEXIT_EXCEPTION_AC: HVMTRACE_1D(TRAP, X86_EXC_AC); - hvm_inject_hw_exception(X86_EXC_AC, vmcb->exitinfo1); + hvm_inject_hw_exception(X86_EXC_AC, vmcb->ei.exc.ec); break; case VMEXIT_EXCEPTION_UD: @@ -3051,18 +3051,15 @@ void svm_vmexit_handler(void) case VMEXIT_NPF: if ( cpu_has_svm_decode ) v->arch.hvm.svm.cached_insn_len = vmcb->guest_ins_len & 0xf; - rc = vmcb->exitinfo1 & PFEC_page_present - ? p2m_pt_handle_deferred_changes(vmcb->exitinfo2) : 0; + rc = vmcb->ei.npt.ec & PFEC_page_present + ? p2m_pt_handle_deferred_changes(vmcb->ei.npt.gpa) : 0; if ( rc == 0 ) /* If no recal adjustments were being made - handle this fault */ - svm_do_nested_pgfault(v, regs, vmcb->exitinfo1, vmcb->exitinfo2); + svm_do_nested_pgfault(v, regs, vmcb->ei.npt.ec, vmcb->ei.npt.gpa); else if ( rc < 0 ) - { - printk(XENLOG_G_ERR - "%pv: Error %d handling NPF (gpa=%08lx ec=%04lx)\n", - v, rc, vmcb->exitinfo2, vmcb->exitinfo1); - domain_crash(v->domain); - } + domain_crash(v->domain, + "%pv: Error %d handling NPF (gpa=%08lx ec=%04lx)\n", + v, rc, vmcb->ei.npt.gpa, vmcb->ei.npt.ec); v->arch.hvm.svm.cached_insn_len = 0; break; diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index 6cd1c4cfe4fa..05b3fb82bd12 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -436,6 +436,12 @@ struct vmcb_struct { uint64_t exitinfo2; /* offset 0x80 */ }; union { + struct { + uint32_t ec; /* #NP, #SS, #GP, #PF, #AC */ + uint32_t :32; + + uint64_t cr2; /* #PF */ + } exc; struct { bool in:1; bool :1; @@ -455,6 +461,10 @@ struct vmcb_struct { uint64_t :59; bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ } mov_cr; + struct { + uint64_t ec; + uint64_t gpa; + } npt; struct { uint16_t sel; uint64_t :48; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 06 14:15:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 14:15:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518903.805898 (Exim 4.92) (envelope-from ) id 1pkQOs-000894-5v; Thu, 06 Apr 2023 14:15:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518903.805898; Thu, 06 Apr 2023 14:15:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkQOs-00088x-1r; Thu, 06 Apr 2023 14:15:42 +0000 Received: by outflank-mailman (input) for mailman id 518903; Thu, 06 Apr 2023 14:15:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkQOq-00088r-83 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 14:15:40 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20630.outbound.protection.outlook.com [2a01:111:f400:7eaf::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8106c404-d485-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 16:15:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7937.eurprd04.prod.outlook.com (2603:10a6:20b:248::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.26; Thu, 6 Apr 2023 14:15:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 14:15:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8106c404-d485-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sn7gxKHobU4Ut8MWGKwol4LpnWNoQlZU71kdMMIedIPd6AAm6qcsx51LVtUceaLDSuheBy05qW+gdr/kXzq6Cw6UJ7ntQnIN5A5QQP65SHCMbkxzdOZV9whg9qLbLAEnyvAWKVDKqAs58kK72F4z3YtRVCeWhY4LuI/IhmIWVE7yDWS9bIpVyvUErnutNoI0lXrNbnDyKnZufySzxikmsKSITxjSSS+t3MODt2H58PwBVKEz1XncOcdCcgtxJMFfgrBhnSHwzqJQcfAIiB0SVczkQVz2HywSJdP6BApJoCipzQNOb5QdmADr+6oMFOGGEk/jgZI53z9/rulz/JrVGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rKDn1HJCVNxFcLW7Fft9AEmNPUbO0XRVtYZ2AEuomUo=; b=AKLNwFd5fzybubhcbxeZ0lYFNTO4vlCHCJ1QOvvb7nOCQHLYsdBcYGPdljoWOKNs2zK7gkv2x5v3EEIT/bG7QPbaum0oyulrZaVa1hvq6G04O2EnP231ZfutNWxez2WaxYL8wijSIwAIanHtCF0PlHp5euj/2ETsTe7r6VIqzRJMW+d6uDP9xsRRpsURDBYz50zPx0gifgZzSvCNi1eUlZOSJb9LybKnRSsKnsANKh8IlWA8o4ZiJbzKTnonyO3qKVFllJStWSK29KW9nVmPpDg9t8OwVouoequev9cD/voWOBLZcJQMCTcyHvMWMJzFf8HwuUy8gNWRnsu8UqQNyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rKDn1HJCVNxFcLW7Fft9AEmNPUbO0XRVtYZ2AEuomUo=; b=kjgxikcBOA1wiZBU+Sj7LW7oQRH2AFd4dte4YDqzGNPt3DysMMd7TSKHCBvcTsrjuDdenLSKC3CPIl/cdhMjMpaI+931z69QaxyElaUBnvD3fiaI1iq3jKvBVnjAlGt9fbyggY7842tyncNnEe0IIOZRuLb/Uzg4WJCNiQ+IYA6rs9CFLOqeobNU3PvXAIJXPujTudwD/jg8vSfk9zcuIY8EDL9nTF2mKa3ReQQ2vjFGpzSEapG/zBD9H4WKzr9wTSZ725CWiWpfd9l3oXG5wkLvAv1eV5xAi2taEakW20jtimgkFhBnvEj0eXZJdpc5DGt7wjmqAQWyOSgWp51nKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 6 Apr 2023 16:15:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86emul: avoid triggering event related assertions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7937:EE_ X-MS-Office365-Filtering-Correlation-Id: d03a05bf-ad74-47e4-1d0b-08db36a96378 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kMZaGK5EFpF/mXW2Sou0hajWda6KfuGcLAjDpPl44lD8W8VoPPpJtGkHqJcIR7uDp5p/sc/Ty5HM8Stoic0S5iLqj/BVbcOlGkCvQqyBIKRNVyLbKnpiI8YdrQKI17PP2XshOBCt193yks+T27Njmnc/1MwiN1ORBXL74TIQz0rsjinPPs8vv8ATrSVGO5RTpqVde0FaTd7zw8ZHvL+hw0XqLlICoaTRGKcIsNrWfCFoLJzR48elNzLViGUj6VI7SWrrcka6RMdnz5l5h2s+Fe+6D/IMmAX/p7uem5oJByx4AksJSji1ouMI62MrcZjqbJAXGcwX4c5ZfR2+LdJMbEGO8GwszAZQ9chhkCAWMw7GHs4k6OTOegtR8jbtPZm0ZABaN0IKUbnjaF4/VN5Zdx3U46z7BYQnVarDCYNGqEwdh66qm9sLLb2JH3sDhrxyo6ga7F36Dbi0pG0d2novdDlO8n7zYJB9Yuic6HuWYvUrYfc8CopTy7uitC0HCLI+XA/vrNojpKLnXjgaOCDUU7U0UD1L6KddXj2QEAG3HTXRnHqCJ8LoRz1zxge5/zW+mgJWy2KgUODKYfRIogzcDcsbm7LWVizz5Mb+FkWw0x4QW4Qf+tnfWPEiXu/+LWXfQV/nw/5sL8AMNznuB9LgsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199021)(66476007)(66556008)(186003)(6916009)(8676002)(4326008)(54906003)(316002)(86362001)(478600001)(6506007)(6512007)(26005)(6486002)(66946007)(8936002)(38100700002)(5660300002)(2616005)(36756003)(2906002)(31686004)(31696002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk5ZNmI3Szd0MzZoQklMNk9PMDA2anF1ZWJ6UTR0UUlDOVAvYk9Bd2d4N2JZ?= =?utf-8?B?MlUwQ3BXc0lmd21ibzgwdkVwVUR1UE9hT05RSnYvV1MxN3lnWmFBZUEvZ2xr?= =?utf-8?B?aVRYa0dEZGdkaXNDVEtMYkpEQ01sRnB1TWxuRUt1UWNZbTJyRnc5Si9OejEw?= =?utf-8?B?V3dJWW93UndTK2lWQnNJOU45ZFFqUVF2WWxWa3Nxa3RPWjVlT1lYWEQrQ0pr?= =?utf-8?B?NERoM041MllOanN4ckRZT3A5VHNNK1Jia0VsUnpBYUNOdlhMbThJbml0aUor?= =?utf-8?B?UnNzeUxTNFJ6cTZ6QlgvWFFVbkJEUndPWEt1UWVkU0RpeWF5clVXSEFFdHFM?= =?utf-8?B?aE9GVlUvSG1BZUJaTy9ybzlSM3BSQ1FLNXUvb2RyQmN3cEppVWw1Q2h5eTlr?= =?utf-8?B?REdZSE1SV2lMbVNseWtJWEt4ZTdvU3crWllOM3cvMEswZVIwTjN5Zm1PZDNF?= =?utf-8?B?RVhRbFE0Qm5kMi9lOWgxNmVRdUg4QXFFUmhzUzVrUnRnZTdma1JaTkkvamx1?= =?utf-8?B?TklWVWk4K1FwN0JYRTJwSklZTWkzRE9paTFxRDhNd0w3Y1huVVoySHpDMnpE?= =?utf-8?B?bk1sRU1SSThLQkVOOGVIN2NDbWdMWENsSzdhS2VpSjNYZlZpVmJCWTduRHNw?= =?utf-8?B?V3FwTk9yVndEcVRlWnZHS3c5YjBDeDVDcVhXZFovWnpNS0c5QVl3R29qZDQ4?= =?utf-8?B?Ym16WGt6eEI5bzZwMUZ4enh5UW5QVnVSSzZ5MzRrRjdhQ003L2xIb2RSaVoy?= =?utf-8?B?UDl5b2U5STloa0x2MW5zZEV4eGxhQ3hmWnBFRWtaQkhtWk53Uk5seWxKVkln?= =?utf-8?B?MzRLOWs1WC84SzhwSktabkFzUG1xTytvcUJwdFVTdWZUODROcFJMMkUrZ2NZ?= =?utf-8?B?akNobXMxQkdDQkpEbXBrNTU0V1lZRjYzOVVaM2VUOEdsUlBSUG9CRVpRWXc4?= =?utf-8?B?NFpia0xyRm1kQU1RV2czMko3Vzh6VnYveWpsRHpHbHR6VTFQSG5ibVJLSStR?= =?utf-8?B?SXZIUFV1VWxTY3VFRlppN1hNTzM1K2xVNXlmL2ZLeWlma21HajRNZmo5WmVS?= =?utf-8?B?NTdyVUx6T05BbjRaVEdNa21jZndGMmtRUU1vODhlOFlnK2ZXOFlqZmJTOWFj?= =?utf-8?B?Q3puOUtVeUJkSm80RkFxL2ppUzltcXhKSzF2WTM5Y3Rkd25wMWlzQThFR3BJ?= =?utf-8?B?SEtKRUNXbGdHYWp5M2pxVGF0KyttZ0pzdnU4L2lnK1gwY3JlWDM0Q2RxWDlN?= =?utf-8?B?N3ZhRHZZbk9uVisyVWNjU2xURVpVY3NLMm9RQVluRjIxeC9kTFNIbTBML2Fj?= =?utf-8?B?cFplVlJjN052SUhWODF0L0ZLUTI4dmJxZVVZOEVHZXZjZkkzWjB1YitWcWpr?= =?utf-8?B?ZVA0Qk9CamJ6Q2J5OVUrdUI4ZEpKU0Y0blNrOEVFcVFId0RtM280VldiVWJy?= =?utf-8?B?bjdUS09OOS93TXpYbHpOc2N2cjBTRUZVSUZYOTFhUWhpTjk3NVExNHN2dTRK?= =?utf-8?B?a1JqR2xnVSt1a1BCQTRMN1BNdHFVQUZ5OHpiTkpMSlRIM0hhS3gzc2RMN3Bl?= =?utf-8?B?d2MrTGJpbXA3SGQ3TU5wSm01eExvQnVDbWNQekt0QVlsY0RtS0tFNk4wQjcr?= =?utf-8?B?aXlBejJlUFZ4TnpVbzkvU29DOXZKRE9UWVY0M2N3QTV6dFJwdmY1cjloUjhS?= =?utf-8?B?ZXhJN1pFcjFmQmtwV09kM2RYMnNuRmNiaWRHMmxBdEVibmVBOXhVTjA2empS?= =?utf-8?B?UkNKeWsrZmVMTkluenR3WWFFejJvOWc1blhqUHM1TVFaZ0xmK3ZsSks2QVpV?= =?utf-8?B?em1zZTVWSlZ4WUtycFJaOXNYeDFlN0krWCtiWTNEWmZ0SEg2eFJFQitmaFU1?= =?utf-8?B?RG5JN054T1MyN2hOZDcyRU5uQnllN0F4U3NyOStWb2FITHBXRmQ5NTN5bHpJ?= =?utf-8?B?eFRBNVhqdHYzMzRKUnI4a1ZJZW5yTG1vdjFvWGFpcVdyVXFuWmNuYmtBMkp5?= =?utf-8?B?azRWM2lLQXFsQ2FyOFZoN0lTeXJSQ0VNNnhORTkwdU1yZWNOWVVkOUJhRUpY?= =?utf-8?B?cGVrWFNmS3k2U2JmblA5TFd6VW5SYUZlZFRuRWhOMGkvd1JFL2RheFV3OUpq?= =?utf-8?Q?w2QqHb21BsaD+P+OO4GBBMgrG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d03a05bf-ad74-47e4-1d0b-08db36a96378 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 14:15:35.2498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QOOChQkCN52JTcS9te/MurkdoyWj9sLm1WRZ2ldaYtE4DuQeV9SKSm049Lwq9tAMmbhIUaMEmm4yNsr/T/B/RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7937 The assertion at the end of x86_emulate_wrapper() as well as the ones in x86_emul_{hw_exception,pagefault}() can trigger if we ignore X86EMUL_EXCEPTION coming back from certain hook functions. Squash exceptions when merely probing MSRs, plus on SWAPGS'es "best effort" error handling path. In adjust_bnd() add another assertion after the read_xcr(0, ...) invocation, paralleling the one in x86emul_get_fpu() - XCR0 reads should never fault when XSAVE is (implicitly) known to be available. Fixes: 14a6be89ec04 ("x86emul: correct EFLAGS.TF handling") Fixes: cb2626c75813 ("x86emul: conditionally clear BNDn for branches") Fixes: 6eb43fcf8a0b ("x86emul: support SWAPGS") Reported-by: AFL Signed-off-by: Jan Beulich --- EFER reads won't fault in any of the handlers we have, so in principle the respective check could be omitted (and hence has no Fixes: tag). Thoughts? The Fixes: tags are for the commits introducing the affected code; I'm not entirely sure whether the raising of exceptions from hook functions actually pre-dates them, but even if not the issues were at least latent ones already before. --- a/xen/arch/x86/x86_emulate/0f01.c +++ b/xen/arch/x86/x86_emulate/0f01.c @@ -198,8 +198,10 @@ int x86emul_0f01(struct x86_emulate_stat if ( (rc = ops->write_segment(x86_seg_gs, &sreg, ctxt)) != X86EMUL_OKAY ) { - /* Best effort unwind (i.e. no error checking). */ - ops->write_msr(MSR_SHADOW_GS_BASE, msr_val, ctxt); + /* Best effort unwind (i.e. no real error checking). */ + if ( ops->write_msr(MSR_SHADOW_GS_BASE, msr_val, + ctxt) == X86EMUL_EXCEPTION ) + x86_emul_reset_event(ctxt); goto done; } break; --- a/xen/arch/x86/x86_emulate/0fae.c +++ b/xen/arch/x86/x86_emulate/0fae.c @@ -67,7 +67,10 @@ int x86emul_0fae(struct x86_emulate_stat cr4 = X86_CR4_OSFXSR; if ( !ops->read_msr || ops->read_msr(MSR_EFER, &msr_val, ctxt) != X86EMUL_OKAY ) + { + x86_emul_reset_event(ctxt); msr_val = 0; + } if ( !(cr4 & X86_CR4_OSFXSR) || (mode_64bit() && mode_ring0() && (msr_val & EFER_FFXSE)) ) s->op_bytes = offsetof(struct x86_fxsr, xmm[0]); --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1177,10 +1177,18 @@ static bool is_branch_step(struct x86_em const struct x86_emulate_ops *ops) { uint64_t debugctl; + int rc = X86EMUL_UNHANDLEABLE; - return ops->read_msr && - ops->read_msr(MSR_IA32_DEBUGCTLMSR, &debugctl, ctxt) == X86EMUL_OKAY && - (debugctl & IA32_DEBUGCTLMSR_BTF); + if ( !ops->read_msr || + (rc = ops->read_msr(MSR_IA32_DEBUGCTLMSR, &debugctl, + ctxt)) != X86EMUL_OKAY ) + { + if ( rc == X86EMUL_EXCEPTION ) + x86_emul_reset_event(ctxt); + debugctl = 0; + } + + return debugctl & IA32_DEBUGCTLMSR_BTF; } static void adjust_bnd(struct x86_emulate_ctxt *ctxt, @@ -1194,13 +1202,21 @@ static void adjust_bnd(struct x86_emulat if ( !ops->read_xcr || ops->read_xcr(0, &xcr0, ctxt) != X86EMUL_OKAY || !(xcr0 & X86_XCR0_BNDREGS) || !(xcr0 & X86_XCR0_BNDCSR) ) + { + ASSERT(!ctxt->event_pending); return; + } if ( !mode_ring0() ) bndcfg = read_bndcfgu(); else if ( !ops->read_msr || - ops->read_msr(MSR_IA32_BNDCFGS, &bndcfg, ctxt) != X86EMUL_OKAY ) + (rc = ops->read_msr(MSR_IA32_BNDCFGS, &bndcfg, + ctxt)) != X86EMUL_OKAY ) + { + if ( rc == X86EMUL_EXCEPTION ) + x86_emul_reset_event(ctxt); return; + } if ( (bndcfg & IA32_BNDCFGS_ENABLE) && !(bndcfg & IA32_BNDCFGS_PRESERVE) ) { /* From xen-devel-bounces@lists.xenproject.org Thu Apr 06 14:28:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 14:28:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518907.805908 (Exim 4.92) (envelope-from ) id 1pkQba-0001Dc-Az; Thu, 06 Apr 2023 14:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518907.805908; Thu, 06 Apr 2023 14:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkQba-0001DV-8D; Thu, 06 Apr 2023 14:28:50 +0000 Received: by outflank-mailman (input) for mailman id 518907; Thu, 06 Apr 2023 14:28:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkQbY-0001DP-VW for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 14:28:48 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061e.outbound.protection.outlook.com [2a01:111:f400:fe13::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57183b7d-d487-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 16:28:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7764.eurprd04.prod.outlook.com (2603:10a6:20b:244::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 14:28:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 14:28:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57183b7d-d487-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9tlqmYMa4a+dzcHIM/YNWEvRKX1eO6UviwX7D7S/mSeqNwBHGQIBc9TVNLjnilBeqvVTeQmzY3BTRfmzKnBAYiJm5x0jgqnv1+BGi7LBll58f6XL5+z2MXCtcvrq81TBakAkhVwddhn4vwvpBSbJn7D2Zh4yNLF24YvxV390UCc2FJGXtEw5In/F6oIBpsxajZ75Gp+yi9HloH8+k4T/wU4/HLENwZXSi/pSDhngSIl53CtV+lL/gOtF5P9MAalxqdVp8KpFR/rWTAakl/0iQ9hfIxQraWn68vNy9+HreUKqYNvVNCfYeR6ThSxomFLRQkKhslddZxzvusjcxqXEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VTFReQIaRtGB9vNQPjk8BpE+DVD5nFEnKxcMO3XVxCs=; b=i1gdlzc4dD5l57hRl4NBR+6KR2B5Kevn2va713rycesXIsTn7jpHLFl0MNc4w7e7GOZHVdQHe2lBlkhafS9Gw6neYPERdxChPaDF/HAbXvTaKz9ihXPTY3Ooa1ZLn9AhwKdMASNrCIhE7kSeZyqsvtpzZAuNzcPB2btMq32NUow4KF0vXDjU9RRLVs4nW8y4CHCAG5iJQMhEbD+lO0efkpb0n/WhcwHLrOcU7jhgkWIvRss1RGnJhltYF8yDSAyzMYDgRhPso5iCrH0FmirlmnrN+LLIjCnExV8Z5N79SSc0wzNhj2ABRh9uypQV0hcklbBWuG2lXVEnUDudkU3efg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTFReQIaRtGB9vNQPjk8BpE+DVD5nFEnKxcMO3XVxCs=; b=M8KqmYvYOCIqx/TaHCcmZss4Iej05KLuYXEPJsGpTI/To38Ljll7jPrGG0rU8L4J23WGkITJf+x1A+6injV1ovT5Ds3uetKWP6eav8pDhbyG/VkBzaMk7TQLWFG8SSUjNgOFC24lL3D/DhE+jROiNmKbWSM5r3OcDRho0bYMBXFyz7pFpCBa1qaCukP4SkEyx5sqUPjaDrdIR6i6vQ2LYIQ5U8+qKkfcZ6Lg1HgFvcSG33VuH5r16LKnHjRMycLByvI0NMMaKrGi7i1zYbqR34kZcJUXd/Yo2UkxrFFdVPKIwIi0b9yX9oQu+ezgRG6yCb6vYf3QQwSugWdFQfwsIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9edbf4a4-978e-e1bb-43b7-971bdab8f41c@suse.com> Date: Thu, 6 Apr 2023 16:28:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86/svm: Provide EXITINFO decodes for Exceptions/NPT intercepts Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230406132708.2251000-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230406132708.2251000-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7764:EE_ X-MS-Office365-Filtering-Correlation-Id: f821e5b6-9f97-4528-6bd7-08db36ab3a66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bd1lfnTTcgKnjN7sOq4qn7Y3yQcK549xz6P2P0dLbp4bdWMr1reLNg0UtcZjVv2lb+y6Ugx6b5KWXey+qkqbzAV4jSai7EidCL/9nsZs5OkgBDCyDWxhxaihj8sWUVnjnxU3an3uULHupFugc2h43ktgV7RGPQJCrYc/gUTFNl+qYd70F7Pyw/6DY772KRg1sGhoVS4TPO9uRr8j6XPXzzRciUT4nyW99i39FmXZ2M0MBMS3jvN26UYxspgEgyHA9HXl+aOe5gtIBqzmsfAl+zr2cHvPSlfPZQPRVdYmV0pT+4iWH2/9VAXmq3zHrfLfy/2S6/G6GUtqV8Y4Sry7PAXzCT/x/C3sQQY31RonqCdkCLmvKH2e9l6D3kcNEAEidTp5hBuWTJBohXrrXGpoEdm9yV0b+texQZPPHJbE2Vlnl9n6eQAW8TdWxWaxTT+nap8MUF4gE1Ux2+Qov2Q7/GyvVwTr40h+g0XWIJ+HsscV+wr4+YB0OTUER9AUklX6V8lX3qUnvarHC0N26C55ZucP0ofis+jIrmH2S/p1xj+M4cqllf5yKJBxu7WrRfN44ixC9p5DAwStDZ4pDVwDsjhBgH0QZRfTaFQyuAh8haemspgH5hT0GI9qVih7fh9GrmjK2i8fdKGHMKuV6F+S9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(366004)(39860400002)(376002)(451199021)(2616005)(6486002)(478600001)(316002)(6506007)(26005)(54906003)(186003)(53546011)(6512007)(2906002)(4744005)(4326008)(5660300002)(36756003)(38100700002)(6916009)(66476007)(8676002)(66946007)(41300700001)(66556008)(86362001)(31696002)(8936002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bThMZlZMaWxRd0FHM1hwNXF0azFZRGJDaDI5U3FuL2NRcnVRNkJrNkNsYWgr?= =?utf-8?B?YWNxMGc0aG95SkZWNFk0d1ZwcjdmbGg0djYrM044S0lhdldEeHlnR2NteXY1?= =?utf-8?B?QVU2dUJVVXFuN1I0VHdZZlZmWU9COG5KRkdMZ1EyVDJKb205YVlXNkVYcmNy?= =?utf-8?B?NTk3bDV4VGp0KzN0UVpxcEV2ZEhlNFRFd0NGT2FlSzIzU3lhaG43S25kUzl6?= =?utf-8?B?OUtwZHd1TXBjMStqZmUwZFMxZ2dlSXlxcTBrMUEzZTFMQ042RkxzN2pkbUtx?= =?utf-8?B?QzM3OEV1dmlwaEN0SFFnM1k5K3BZT3hMRW45UnFMRytGSkRmWXZ5MHpWVWVO?= =?utf-8?B?eGxXODNWVS9STUF6elEva01MSU51dkpMTURZS1l4dDl0REYybWJaa0d1TGpZ?= =?utf-8?B?UTYvSW1KSytOdFhCNS9CV25WSlY3aEcxK0dyNWRsWXI5ZDg2QjlmN1IzdzNa?= =?utf-8?B?NU1CbXNucUZnWGRqNklFKy8yN1R3bW9wbCswOEZOMWRJQkRPTGRZYWR1L2Vk?= =?utf-8?B?cnRPMW4vWjlmL0NCUWREUkhIOHlxa0dOeTJkWi9HVkhHeGRwMTRYcWQwcWlx?= =?utf-8?B?TElIWTVGU0RTQ3dJZTgzN21OeSt1OHVyZFY2MXhuK3ZDTHlsYTFtOHMxOGJT?= =?utf-8?B?RWRMZGM0WTlQZkVVNjNVazV2RUN0dzZKaUtNU2hYTVJWNmRKSTNHQ2R4SWJi?= =?utf-8?B?cEdPSWlYclcxTGdJOE9yWWk1ZmdFcWZiUDZXZzBId0pNL3VyR1VoMXV2WVR3?= =?utf-8?B?T0xGc3h2NFdJMnlaYmx0UVZWL042OG1NLzFEYkcvNi9tcVBKblpxRzFnbnhi?= =?utf-8?B?dU5GMXMybjF4Z0lObTFvQWNaZFlhdVpMVVIycDhpb0E5bitCRXJha3kxV3g0?= =?utf-8?B?TUlITGZtVU5yNXlOcEc5YXN1TFJJUXZqeW1mRnlFZ3UyRFVOUjN3YjlhL2ZE?= =?utf-8?B?eUJ1ZTBvTXBUdWVsbW9sNy92bThES2l2MmhvTmhiWDNRUWNzeDBzQmdsVnRI?= =?utf-8?B?Y1l0NVpNWFF3bmRqQWpBazNZckNsZkFWUVhlT1RueTVOb1MwMFNGWmN0ZGYw?= =?utf-8?B?UUVjWmI2b3p4TGhadHNHRngyRXFEb0JFbUVhNVU3ZTZnNzd0WkhKaDg4YkZl?= =?utf-8?B?QWlYdnEzQjZUN2FNMTBqQ0pIMzZrZDUyaVVWNzI0MCtoUUx3b2xSMUNXeDRl?= =?utf-8?B?YlYxYlBwVnp0S1hIVitJR0tQQlRCdXd6d2ZTelh2S2NPeVFvbVlOaXN1U1VK?= =?utf-8?B?QytSdVBaci8ycXNGRVNBdVdKdTVtY2hQSksxL0tkc3FMN0VtTE5sRzZSQ3E4?= =?utf-8?B?S3Z6RWlwSkRlV2NsbzhmTk5reTA5Vk03d0lENTJYUHNLWkE5am5sdm1QRWQx?= =?utf-8?B?WmIrc040VnoyMGxjdExBeDgyM0I4WFFFUTRzMFM1TUljOXdVYXptcXlkSlJ6?= =?utf-8?B?YVd4OGNKb09ZNWFaaTFneTFNNXJVYlIrWlYxUUNmRDJnZkRxSlBaNy9KaGo3?= =?utf-8?B?T0lTL0J5TlpCTndrUU96b3FqWVpMaCtaYVdEMFlhNW1yTGRuQjRGSDZINzBv?= =?utf-8?B?OFNLbStybm9DVnlsMnhxaGRrZWhSQkJ4NStmOURGZS9hZUJvMXVwTGJSeGI4?= =?utf-8?B?d1pVUzBQSWt2VEY4TVNab2dPQWVEbVZ0bVlyZ09NalJIalpiY25RVTROcVYv?= =?utf-8?B?c0lyV0NBbFNreURwajFLd3NHUWd5ZVJCOUhnTU11N0c3a3puYXpGVGk4bDJM?= =?utf-8?B?SE95RkNENDU1OE5vT3ZPV3B2L1dOOXVBdW1PUTZqdys4VjI0bmh2clk5VTY3?= =?utf-8?B?c0x1SmJPVHRFUEhWWExrcDVFUTlhZzN1U21nZlAxZUIrNHUvLzNhNWRpZTMz?= =?utf-8?B?WUJjWlVUNEdsZ0RHMUlzSjdIRWd0YjM5a3F1elhYLzR4Z3R6d1dlMUdKdWp0?= =?utf-8?B?bmxaOERmdmI2aW9HUDVsTEkwU1dLRXZhSm1vZ0k3QVZxYnpoN2ZEUkl4cFNi?= =?utf-8?B?ano5NGM4SjZvcVJsSHJKWnlTMkgxNmRkclpJNk8vd0lndDM5aCtuV0Y4TWJH?= =?utf-8?B?OTVacnpsUEovU3UyaEY0elFXZjh6WFMyTjgvQTFwMDNWL3NlbW1HVkQwclpm?= =?utf-8?Q?ss6eQvwPs8odul/QRvzgz+kKI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f821e5b6-9f97-4528-6bd7-08db36ab3a66 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 14:28:45.1854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d3Hjug0Bdx1LReMT1M4mN+K1gr3cahc2K9MIHw7uxlWTLCqapfb6OzB9p78tbp3c7YSROS5R9TNQPekA+lRtYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7764 On 06.04.2023 15:27, Andrew Cooper wrote: > Exceptions and NPT intercepts almost have the same layout, but NPT has bits > above 31 in the error code, and the name for exitinfo2 really does want > distinguishing between cr2 and gpa. > > In nsvm_vcpu_vmexit_inject() rearrange VMEXIT_NPF to fall through instead of > repeating the exitinfo1 write. Use the fallthrough pseudo keyword instead of > a comment. > > In VMEXIT_NPF, as we're editing the printk() anyway, switch to using the newer > domain_crash() form. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one remark / suggestion: > @@ -455,6 +461,10 @@ struct vmcb_struct { > uint64_t :59; > bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ > } mov_cr; > + struct { > + uint64_t ec; > + uint64_t gpa; > + } npt; Maybe better "npf" than "npt", as it's describing the exit/fault? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 14:31:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 14:31:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518911.805918 (Exim 4.92) (envelope-from ) id 1pkQdu-0002bA-Na; Thu, 06 Apr 2023 14:31:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518911.805918; Thu, 06 Apr 2023 14:31:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkQdu-0002b3-Kf; Thu, 06 Apr 2023 14:31:14 +0000 Received: by outflank-mailman (input) for mailman id 518911; Thu, 06 Apr 2023 14:31:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkQdt-0002ax-Tl for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 14:31:14 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9381bbf-d487-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 16:31:06 +0200 (CEST) Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 10:31:03 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6098.namprd03.prod.outlook.com (2603:10b6:610:b9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 14:31:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 14:31:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9381bbf-d487-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680791466; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ogUa40awd4m5Ri/1ZLuwSC2FpKaHSx3ZJ1giQPYxjhs=; b=QqGDjkqo71QIM42GzUfB9MODpPxsSutjxb0luFM8gdDs64jYNp2RsXk3 NzM5PcN3Ip0dcnVUKZ4u4CL9WBbbEQhQw8wiIiICbFI8AkO1HKpZpwdU5 +maFT/BARSJT+HG4gppDxLdnu8WrKNeodMPqewVK4E7eUS3OoaU2x1Fvy k=; X-IronPort-RemoteIP: 104.47.55.103 X-IronPort-MID: 104604306 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Vo+/aq7/EO37lRdSyBXNUwxRtBXGchMFZxGqfqrLsTDasY5as4F+v mIaWWuBO/jeM2fzKIh+Od+zpkJV6peHn95iTVBkrnw0Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4geE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz eM4JmgCUhu6jcXr35GkTvRxufkDM5y+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOOF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtKSOPgqqUy3jV/wEQvCxYPbHq1psOX1BO8fckAJ E4f/wYX+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mpZ5piBvKF45nCPTs1oazHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxaoowFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:evAMiaClFaAQe2zlHelc55DYdb4zR+YMi2TDt3oddfU1SL39qy nKpp4mPHDP5wr5NEtPpTniAtjkfZq/z+8X3WB5B97LMDUO3lHIEGgL1+DfKlbbak/DH4BmtZ uICJIOb+EZDTJB/LrHCAvTKade/DFQmprY+9s3zB1WPHBXg7kL1XYeNu4CeHcGPjWvA/ACZe Ohz/sCnRWMU1INYP+2A3EUNtKz2uEixPrdEGY77wdM0nj0sQ+V X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104604306" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUI/wd0uTYaYDhzqC4rWnh5Zm2HCNWOzTXZhYNM9ZfPYqhdYv9YhH2nS0YvJbL6kqxSuzgU1+NbqhqlOKvr7tjsRUwlafo53RClSqeAZUMaYmWM2PohthRsVEqE/8JTmK5LqUX+S9/Po6k/1IqBxP4wdaEfGtTsiXRJIa1vkCwgCzAhQmp2nXJp2D0ib8v1XvYTHp7lWbv20zqKVYsP2NQwxWTYan0ioAWQc0Xp4A6Mgcfwv3LMRkYdZTH1MMvcDuNNhcgn8nYXxq8hbY+NMSf7DvQiT85xNxeetphh9vgO/GMJy+ha7EuekfzoMuN1RzPsXuwIFk3GmAPWhDlUCxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lbKvxOKsESnEm+UoB7N2Ts/1VLqyZuSkZzZthBYVx30=; b=ddqTz98C+ZtTqdRpjVfm0PQbhwmlBxBiDjZkb2DZwuuX3khzrmt5bXkF3ngKKebfujMZWMnRaEhhBJrTTWh3W/tGaGgKyqird4BIdfNM2n0THmEiAb2SekNz20xmAsiMt5+gsPOkGGBBtQm3zJxKlj4N45W52JJOgycMSRdfOh9OSDgt3JcJTsQrLNeAp8nO/Rm1J3Eo0rkfZESYOj9JXEBEcnAxSoXnkXVTy5ahoctS6XAjbDAMmFmTsKlYziFljf0Vi1Rqm/Uio7YS1LuDezn9TGtQaTRXcnzbgGUCDqQklTk+MMM8KRIshW1fT3wTrDIr0vQCALbTBejdhOit4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lbKvxOKsESnEm+UoB7N2Ts/1VLqyZuSkZzZthBYVx30=; b=nQOYLUrgEEm94YjOfO/6jGvC8Ju/Buj3aDHG8bBCjEB2u++RrFjNHR7WmJw33smpbkJ7TXIiuGx7fvxerss/b9mC/umOkDQ387kc0TzapGrROMv+KvDaMyz70DRkY6dCH8wMk5X3JAG387VsqMKmPpfqxpdf8ZScWMdJMvprrsI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 6 Apr 2023 15:30:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86/svm: Provide EXITINFO decodes for Exceptions/NPT intercepts Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230406132708.2251000-1-andrew.cooper3@citrix.com> <9edbf4a4-978e-e1bb-43b7-971bdab8f41c@suse.com> In-Reply-To: <9edbf4a4-978e-e1bb-43b7-971bdab8f41c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0219.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6098:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e6bbdcb-f2be-4f3d-324e-08db36ab8b26 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bn2Z+P0229x8a4hu/dXHb53WjAZ/3UdYNLbNOP3e/pj8q2VkbYlT0126pZuIOT60ssNJ/YJVjKQkYAX+q7VVZ88TgmHzTl4QleY2ZqBDmBlKleZrc8fhpx6jHy/ACD2WWEsACFkuhd3Mu+2/84MlLoEW2ivjLeF6G6GhWCsjte+ZAApwWIUxBMe7vImQRQwkPdeXuUAKeXvAZpmujlazutsQcq9GK+d0s6w8Ea2XoYloCrGrowmDR1tafTmRyxjRBNU72sV9LZpAydNUdGQ+sbPoPYpAlbCp0Q4pa3OroZfKYUF52vDLcsn7C14JZqRCAOKyYJcthvOlWYBFq5y5FNqQ4uL7ngUSr4Y02iLa/Gul/ePC/+U+mK76+mUIF7/L5AIZfkjf2mnVs5BgafX28fU+CG/rp73Lw4/2TBb7zHkJ3YKjztSeV/4g09vT3GljvOHP+lWYjPUi8hd5/5r/4N+ZlkFKOhWa/d1RCuWk5ZaSUkfyMKjxeyUSPLDdLfxYlAHs4X3TxNRd4Q197U2HKVbGP8UbQjgT/lPDw/IDd9q2SalXFD8P+iBvzt06ufLAy2EKL1uYrFrI0NeU0DEPPzNKZTiPj6tLv+ZF0uhI/n1j999oY6ArSpz2Rx6uK7BcJLDA6WEtlU7RZGpfAU2DFQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(478600001)(31686004)(6506007)(53546011)(26005)(6512007)(6486002)(2616005)(186003)(6666004)(5660300002)(66476007)(38100700002)(41300700001)(54906003)(2906002)(8936002)(82960400001)(6916009)(66556008)(8676002)(4326008)(31696002)(66946007)(86362001)(36756003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXJvaTg1V2s4N1BuWUZES29GNkN4U3lUUUdoSHBqN0lBZ3EydHFaNThUY2lt?= =?utf-8?B?MjJiQk5LaHMySE80cVhjdXR5emFLV2FXTWVLd0JGQnc2QUZ1bU8zLzFmREFK?= =?utf-8?B?dEZ1dU9PQitEVXZVMXV1b0VmRWtlUUpVTzRLeFREMzBhS2FRczlMSHVBamtN?= =?utf-8?B?dm5sMkhDTDFNTW5reXY0dllTMXFNS0dROE01c080WFlaY2NQbW5PQitubmpz?= =?utf-8?B?TGNuWFZoRWlPQUdNVFovL3NMOU4wRmswbzRhK0gvRHpUKzdHYU1BN251WkZ1?= =?utf-8?B?eEwyWHBwWnRQRGcvOHJWWnhmaXVuSGhlTmM2czE4WEdzcHhjVGlWT05GU0pK?= =?utf-8?B?T1UyMkRWMU1RQlRmT3M1NEdBVFhGSmNZdFZxR0xhOFNQVmw3bnVaUWptak14?= =?utf-8?B?UmNwZmE3R0VoSTRzaEh0dTNjemxKSlFGSmxvdmZHREtEcFBrYzJUZldLdllp?= =?utf-8?B?V2JwbDJZNWFsc3RjY3hnN2xYYjJWK1NoUEluUWYwdmtnWmhXQnJBVkZvc3Vt?= =?utf-8?B?aUdrZzJwY29hS05sWVNiQmN6NlFLUzVjVzVFaVRrQmpyRm9ON2JxOE5vREZZ?= =?utf-8?B?RDRvQzZlS3hMdnJoRXNPUUVHKzVqRlUxZFhtNy9nK2V4MWJPUHl3cXBEd2g4?= =?utf-8?B?N25KdnhXbHBSTU9uK2pPeVEwc21UREZZbkxKRG1HbUEyZjNBcTFOdlA2a2ZE?= =?utf-8?B?YmV4ZjBZemd3SFNtazRWTGRFVS80YWR2WFFwODJ5TkE3VmE0VWpMam8rV2VI?= =?utf-8?B?d1pmbU1XbC9tMUdFUkFTN3RVUkR3b0pqQ3BuM2I3RC8yd3QydERqTHh2aTlV?= =?utf-8?B?Z0pPcWhheHJWMjNtTWM2RTlKbGVZTytqMExVN1NpcFlYZFFQc3gwM3Fib0pN?= =?utf-8?B?b3pxRDhLajNDbWp2Skp5MjNrOU9VKzBYSHE5VUdIQXBkS21BaG9qdDhtWDZo?= =?utf-8?B?YzgzbjJaRmJaSHJrWWJmRXhqeTUxcjREWkV3L3IyWGF4d2FxUmw0aVRVWSs1?= =?utf-8?B?OEE4S2Y0OWZLT3ltN09qNU81c2hUZk9hTWx0NHdESU12QWxSTFBhaDhGVFZL?= =?utf-8?B?MkhzYjVXby9VTmVIRVYyakF3N3E2ZDR2UXMxeEZvaVhMVlYzUWJVTnZTcUJm?= =?utf-8?B?dlc4UC9Qa3hQNWdDanpqdTRGcCt2a3NVSXBZVnpQMlhoVUQ0UENLbHdtVFFO?= =?utf-8?B?SUc5M2plVnZxbVpGZW0zSFphdXpoRlMzRXBmNW9WamVkekFNZ2tWOE5vNDZN?= =?utf-8?B?NjZwYnpPbEhKMXRGa09mVVFDb2kwK3lLbDF0cnV1VHJubkR2VllwejdOVytt?= =?utf-8?B?L0cvejdvdjN4NWFsNmtLbGJ6bmhWdldkZTB6M00zajNOOTVtMi9OaUxIdVd3?= =?utf-8?B?d2JsR01sd3d1N29Ocjg2SnpJUi90N3N2QjQvd2dGTVlaYnlUSGdMNmZKcmJj?= =?utf-8?B?OVNmZVNLNi9mVWNEQWVvMDhiNnNKOTViend0M0ErT1cvSWRqeEovTzB3aGc1?= =?utf-8?B?Z2MwZENoWXRCNkdPYVN6VkEzWEl4SVd6cTZaWnBDdUZYTllDVS9BZnJTeS8y?= =?utf-8?B?aVFOVlp6bkVQb3ZlRmxQQWoxOHN2WlMzKzQ1WjhTU2RDdG04Y3J1YUQ3MVVG?= =?utf-8?B?bC9rRms5TnpOYytMM3hBNnU5OUtoajZmVStMMGxOeit4Yk9RZXI2QVZtbzRD?= =?utf-8?B?ekV3N0liWld4MnpOU1F1eURld1NpWXFZQmEvV2JDSFhyZG15M29XZ1lGblRI?= =?utf-8?B?MGFCMnJQd3EzcUo3bXNFaERtYWw5MkdPNUVzMkkwMjNDYURoZmoxWlpCdTVa?= =?utf-8?B?NHFPbkFHVVd4UUR3S3NhQlVOcllhOWJhNnk0TzUxMW95S0NHUEdjUDJoRDZD?= =?utf-8?B?ZUh4UkNhNGxaNXVBRGhNSklWZXUxcXJRc2hiMHROeFF3Q1gzaFQ5R1ZaU2Y2?= =?utf-8?B?OFMyS01QV2JuRHdUS0swTytpaGlBeElNN3VvdHJjazJtdFFxRVRkSlgyUlBO?= =?utf-8?B?UGI5cUdyYnR6eGkxL1FaZnlCNERQTHNxMHpuRm0xR0Z1Q1oyVWVDNzlmU1Nw?= =?utf-8?B?Vkx4ZkpPdXBCaE50b2ZGKy8vMktqS2lKZXp0ZzBTRG5aVzJKdG5ZTW1QWHVj?= =?utf-8?B?M0h3c21zRzgyU3RZdGZNS2g3S1M2enRvNU1nbkUwY1dCZGVtTm4rTERaL1lM?= =?utf-8?B?ZXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cDDOEHv//Dru/2jUqwkFqBwSe41OytLYViqjnOSDqFjjP8HpkS09ptpdeQP+jgFUePxXtBuyJ/cY4zioBOflSEFCsPbnOM/mGGubHw6x+1UPAz5LS1b2keZ+4VVCv8+B0UN0juORgE+MIuctrrPPpE5SuuF7TN8jJk7JwdNGnJovX5W5GWy5wSaPazECQKDhTAOs9hed92eLHaKzrzOEPQJP/CC0SxGJ8wjnsSU9zQPz6LCegAVBJfuXwJvlDGq09bY9juFpJL6xAYLt0Z9KZ+U8QpaUTMwslLa5ZSu0tk54+Quntj4aYHjheAqRJbJe0lU3/Vp69lKMNP0l1SCq4NGwc88osHqMQkvbNmMkVOrDEZ+F2Ab3U3LyOTXgZAwgGugaCUGcv79SPu9BqXaLP+uvnc6JzHfFSHZIFYvyVP6vJcHWU+kiue7Mjo2JER/33Uqn7EMBFw1yTD999h6X/RSvTioor3a5AYI27bkEHs+ssFIUGRRTCw8M/E30J9MjCcr1crKLibbmobZ+uygo2vgTyS1hIRiU5mnUfWzMz01xGJIXW2FEsivLCMv5r7K01PNpVuIfUlQDPyDMENsKZwXPXYdcKrd6Uu3ut2+MTdNyfJp9+gsJQjR4AhaAYVturaqo3nYGM1neetVVblXRwT/DLhcmnebf/xcKochPFp5jF8FCTBIXpubjyPiR9iOiQde32wzgi+JcdzWf6n8dlo256ghSYKqO/QYZZEjJa4fhJuQNbQkOP63bYqQ506OjKtOc9ILGt/2XWpS2fRe45nehlNNrGVH5HpqzOXhDH/weMriZsnA1jgsrmWjCjmC1 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e6bbdcb-f2be-4f3d-324e-08db36ab8b26 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 14:31:01.0888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ThLXgCfdekdOAR1A9BHd/npWORY43QrLvPtkQmim0EON22jQmuv30Qhn0kdQMKMScRgg4umC/SocPzWFPKMtRpPxcLML7qKYOHgk5SXdEk8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6098 On 06/04/2023 3:28 pm, Jan Beulich wrote: > On 06.04.2023 15:27, Andrew Cooper wrote: >> Exceptions and NPT intercepts almost have the same layout, but NPT has bits >> above 31 in the error code, and the name for exitinfo2 really does want >> distinguishing between cr2 and gpa. >> >> In nsvm_vcpu_vmexit_inject() rearrange VMEXIT_NPF to fall through instead of >> repeating the exitinfo1 write. Use the fallthrough pseudo keyword instead of >> a comment. >> >> In VMEXIT_NPF, as we're editing the printk() anyway, switch to using the newer >> domain_crash() form. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich > > with one remark / suggestion: > >> @@ -455,6 +461,10 @@ struct vmcb_struct { >> uint64_t :59; >> bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */ >> } mov_cr; >> + struct { >> + uint64_t ec; >> + uint64_t gpa; >> + } npt; > Maybe better "npf" than "npt", as it's describing the exit/fault? Oh yes, of course.  That is what I'd intended to put here. Thanks. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 14:57:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 14:57:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518918.805928 (Exim 4.92) (envelope-from ) id 1pkR3F-0005C6-VY; Thu, 06 Apr 2023 14:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518918.805928; Thu, 06 Apr 2023 14:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkR3F-0005Bz-RN; Thu, 06 Apr 2023 14:57:25 +0000 Received: by outflank-mailman (input) for mailman id 518918; Thu, 06 Apr 2023 14:57:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkR3E-0005Bt-MH for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 14:57:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 549f176e-d48b-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 16:57:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34AABFEC; Thu, 6 Apr 2023 07:58:04 -0700 (PDT) Received: from [10.1.199.64] (unknown [10.1.199.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5584D3F762; Thu, 6 Apr 2023 07:57:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 549f176e-d48b-11ed-b464-930f4c7d94ae Message-ID: <6b98b95d-d737-5495-9c03-7857886cb1ce@arm.com> Date: Thu, 6 Apr 2023 15:57:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] tools/xendomains: Only save/restore/migrate if supported by xenlight To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, bertrand.marquis@arm.com, Wei Liu References: <20230322135800.3869458-1-peter.hoyes@arm.com> Content-Language: en-US From: Peter Hoyes In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/04/2023 17:28, Anthony PERARD wrote: > On Wed, Mar 22, 2023 at 01:58:00PM +0000, Peter Hoyes wrote: >> From: Peter Hoyes >> >> Saving, restoring and migrating domains are not currently supported on >> arm and arm64 platforms, so xendomains prints the warning: >> >> An error occurred while saving domain: >> command not implemented >> >> when attempting to run `xendomains stop`. It otherwise continues to shut >> down the domains cleanly, with the unsupported steps skipped. > The patch looks kind of ok, but shouldn't $XENDOMAINS_SAVE be set to an > empty string in the config by the admin instead? > > Or is the issue that $XENDOMAINS_SAVE is set by default, even on arm* ? Yea the default is the issue. We are building for embedded, using Yocto, so there isn't really an admin. > > Maybe it's easier to check that the command is implemented at run time > rather than trying to have a good default value for XENDOMAINS_SAVE at > install/package time. It would be cleaner to do this at build time for sure, but I'm not sure the autotools config file approach for sysconfig.xendomains.in can handle the logic for this? Thanks, Peter From xen-devel-bounces@lists.xenproject.org Thu Apr 06 15:18:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 15:18:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518925.805938 (Exim 4.92) (envelope-from ) id 1pkRNc-0007ec-Nx; Thu, 06 Apr 2023 15:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518925.805938; Thu, 06 Apr 2023 15:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRNc-0007eV-Jx; Thu, 06 Apr 2023 15:18:28 +0000 Received: by outflank-mailman (input) for mailman id 518925; Thu, 06 Apr 2023 15:18:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRNa-0007e6-Qn for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 15:18:26 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46a36581-d48e-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 17:18:25 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id l17so2238007ejp.8 for ; Thu, 06 Apr 2023 08:18:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46a36581-d48e-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680794305; x=1683386305; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DTYmK8YkPVhMeVdQAleCZ/tAcp1XekiLSY2jWJ8OVn0=; b=o3sXOGaTy35TBrWdA/ZCTjDHsafZroabmM7isj5bmvtyQzYNf8w0e6W2k5tDIZJOT5 ZtB6SjqdlNsiTLK5jMTOa65QbxUKFL1QtdRlcLTCok/3waNhaSOTzSZm+sRQY+yAK0lW Gi4So07q5CVUbS2L9HUiwJvvYHUB6Q4vj3e6EhKcFFbiC8jMzEAQh9aTrDG3uGQUY/U5 kzzUHFzg/wt6ZN4jsviiQ2NQraL5cbmbtq4S1ATmJ48Y0P7bFi3K5BWWuFpKUGrOiNDC NEYh2UGteXEvs2orgNeNIg/6c4ya/viPWQqtTpBOFtAM6nVYAKwullSbt+p47ZKT1Mhp zyZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680794305; x=1683386305; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DTYmK8YkPVhMeVdQAleCZ/tAcp1XekiLSY2jWJ8OVn0=; b=4Ee/iMwUBLxGRpHM8AWdlZ4CxS1Wd+3HS+nCR6h8DMDNF1S1MepzTUE/5hyc7stnrz jN/0AUADjg7cfVnEUQRWXcqgV3aYDP1wdAr9yYPHddk8XVVOwwQu4ZN3fShbe9so+9zi AYblrZmzjYpsqAJmPJUqEiUGmeoQ3BTkdNjzezYaF5/WsD6eJOAhIlJhliqKdFp2ksq0 GABv5x8vY4Mwtjz0qMX90TsaXr87V2zoqxX90kAfUrzXbOBNPBmCMdVDMfqvrfnx6dQ2 WMBjsaHD/Kbb7FXu2mUJX+iypgFFkOgGG+OJVR90io9/VAlNimzWeOED7PTDYXXdEXbI 31Eg== X-Gm-Message-State: AAQBX9dWnTew+ohena3S8meRRwgwonfMGHTezPCaiWWMr2Y73hUr2gYq TChSzWBXFQHx9ET2B0974fvDW9Y+rkrvzJTBHG4MCQ== X-Google-Smtp-Source: AKy350Zs8ZnFOSDFZhmrHpJmPBzmdZ0OVPINfkHmM71Js2ejfgFIiy9ZLXoyIwUqzPcpT94JVtx18iJ0Fh+BaFTYbQU= X-Received: by 2002:a17:906:73d8:b0:939:a51a:dc30 with SMTP id n24-20020a17090673d800b00939a51adc30mr4786343ejl.2.1680794305057; Thu, 06 Apr 2023 08:18:25 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-15-dwmw2@infradead.org> In-Reply-To: <20230307182707.2298618-15-dwmw2@infradead.org> From: Peter Maydell Date: Thu, 6 Apr 2023 16:18:14 +0100 Message-ID: Subject: Re: [PULL 14/27] hw/xen: Move xenstore_store_pv_console_info to xen_console.c To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Tue, 7 Mar 2023 at 18:28, David Woodhouse wrote: > > From: David Woodhouse > > There's no need for this to be in the Xen accel code, and as we want to > use the Xen console support with KVM-emulated Xen we'll want to have a > platform-agnostic version of it. Make it use GString to build up the > path while we're at it. > > Signed-off-by: David Woodhouse > Reviewed-by: Paul Durrant Hi; Coverity points out a double-free here (CID 1508254): > +static int store_con_info(struct XenConsole *con) > +{ > + Chardev *cs = qemu_chr_fe_get_driver(&con->chr); > + char *pts = NULL; > + char *dom_path; > + GString *path; > + int ret = -1; > + > + /* Only continue if we're talking to a pty. */ > + if (!CHARDEV_IS_PTY(cs)) { > + return 0; > + } > + pts = cs->filename + 4; > + > + dom_path = qemu_xen_xs_get_domain_path(xenstore, xen_domid); > + if (!dom_path) { > + return 0; > + } > + > + path = g_string_new(dom_path); > + free(dom_path); > + > + if (con->xendev.dev) { > + g_string_append_printf(path, "/device/console/%d", con->xendev.dev); > + } else { > + g_string_append(path, "/console"); > + } > + g_string_append(path, "/tty"); > + > + if (xenstore_write_str(con->console, path->str, pts)) { > + fprintf(stderr, "xenstore_write_str for '%s' fail", path->str); > + goto out; > + } > + ret = 0; > + > +out: > + g_string_free(path, true); > + free(path); g_string_free frees the GString, but then we call free() on it as well. Presumably the free() should just be deleted ? > + > + return ret; > +} thanks -- PMM From xen-devel-bounces@lists.xenproject.org Thu Apr 06 15:33:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 15:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518929.805948 (Exim 4.92) (envelope-from ) id 1pkRcQ-0001dL-0P; Thu, 06 Apr 2023 15:33:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518929.805948; Thu, 06 Apr 2023 15:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRcP-0001dE-TY; Thu, 06 Apr 2023 15:33:45 +0000 Received: by outflank-mailman (input) for mailman id 518929; Thu, 06 Apr 2023 15:33:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRcN-0001d8-TA for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 15:33:44 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67a483bb-d490-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 17:33:42 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 11:33:38 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SN4PR03MB6768.namprd03.prod.outlook.com (2603:10b6:806:214::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 15:33:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 15:33:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67a483bb-d490-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680795221; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=BAvJtl8D8wnOaRJr6oR7rTwaR89LKmeaTPG9kn5YroU=; b=PJMFBwaEyvX5mQy4QiEWUZcp0gNbLZo4NfbXl1vJe3eSBaGhFNgK5pEH 5sglr00sqSCci+0AO0UYtlKLThwwviN2GRszLdOv6+GVsEV2aoac9s1Vo uj0ZDYtJ2H6b7jyTl5hZvtPLGsJZRgNeqUAc0lB7Jb6tzvnCaax8xV41e Q=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 104498459 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sDCqw6OL+tNknYnvrR2IlsFynXyQoLVcMsEvi/4bfWQNrUp00DQBn WEaDWuHa67bZDfyf493a9+yo00DsZHXn9AySwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0thsHWFi+ 6EeFG4yfhODuumzypS6Y9A506zPLOGzVG8ekldJ6GiDSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PtxujeJpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxX+nCdJOSezQGvhCkG2z/E0xWQAqCniF/+KTzXybXfxNA hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACAcAvd/qpdhpigqVF4k5VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTzgbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:ht85cKvHnzKYUtHPS3ka1WSK7skDp9V00zEX/kB9WHVpmwKj5q KTddAgpGfJYVcqKQgdcLW7VpVoLkm8yXcY2+ks1PKZLXLbUSiTXf5fBOjZslvd8k/Fh4pgPP xbAtRD4bTLZDAQ56uXjzVQUexQp+Vvm5rY4Ns2oU0dLj1CWuVF5wd9CgGUVmh3XhQuP+tGKH OF3Ls7m9O/QwVsUviG X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104498459" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jk8sq1R7IOBpxOMsa3cjL6R/waHwiG51bfOF9HEPca/tYEC3+v+iJ9eO30QrD4TKsJXyTg1QbbkEPM7fukg7PELHCdjT/b03WRc14EjQr2Hnm36rnYnMiImrM1wBA8jjJbYRRVGPZeSHiZv1hpoUqd7LsMtLGZv6IKO8ixyGwGuUmp8FXorWMxsgJZXt6eqAHS8KJFNDKNRUh+qgd+kEJpNF+Vdj6poMSq0Ix5sX/3ANGovVUKNzgN0kiVLpayz/McJpa75ThIa0MGj1dzZz66mbmhtsv0AiQepYZa1xmgxCXL6mbL4Bx7IJ+9PZFivDeDRg8KjqQ1vX5MM/iJ72GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Mfne7y8aweDKenSHNw4RzZCfFt4bGVZDOLeZa41Gvw=; b=ayOto2LOQc9204BfQIkSK2zCUlBls4PThcFA78KAFVgkDl9fFBWpw0E8cJDDsaG6lZ/9GviOhsx6cmdc6qsEx4/iDqc/6qpPWxhRQcoyXw7l309sYvV81wHGUPemy5fQx+3J60txSPSdY4vOvTKMLdKWoptD7+zwXcsG3C2WF5Wo4PwPUvrij5vZdz+gx2x3tAdgDArs1ZFH/ux7kXRHgKzfv/61d1ccaBco/tEGnO3hyrHKP9LeJGnEq/wvMDnkG1t6YffX8pXp0JKWKzkCZzI0jq+U2cBBe1q3JX/Ws9Sz+p2imq8RIf9uu+pWAkfE+il+40wmUzFMTTNNAkxfJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Mfne7y8aweDKenSHNw4RzZCfFt4bGVZDOLeZa41Gvw=; b=IF3PTjbZGh3nO875qGvIrxSKDJn/XMA9iT9r7rP6yzwogIwJuaSNKXn6GtjjUlHfZu1U8eAESeG+KuJICSgK31UQLXm/6epqF6JdXdSb18wDWzbciUBenm8+13O4UD7sxQf+Ymhg/+BfPPW/Fkquw2PAXrWyJr0p7NCNBhVUKrU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4fc4f5a9-0b9e-bb30-df32-09b5e9e63a57@citrix.com> Date: Thu, 6 Apr 2023 16:33:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH] x86emul: avoid triggering event related assertions Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SN4PR03MB6768:EE_ X-MS-Office365-Filtering-Correlation-Id: 716c6c66-42bb-4f2f-8be2-08db36b449b5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yufdyamwhPkGxL3mdxhoHtTluSuBBDvb4Ka+JJ8jDg9E7A5bniQDrwG7ABF2TP0Z8tFknJXGq2CxH/4Gw1dmIe1dZqY8zvj1F5xi7KAmFfYnku+cFUZ/zbSUVxTqNu4qkcKIiRLPMFxSN2V3tyGau849g/y9PikwYGXyGmNcMOJlJomnAtjQPT7KjzmIaoMyBf7dnNgS9hTHtWTt1RgfXiq+AUpb5nXgeUOjPDoocHq9TOkfjlT0klY1CPIcS1T0Z6TKZXqiX6a/u+WDdX371DL4dZMdAveXqmhRpaGLpuo1tt5Lo+xvAvNor4C4zt2kikZ44qHcSVavw96Q7jSqyscepWMoHXECZLcbjbv3EdAullW1TQMBcvLxPSRWeKYWnkbUC++qQz2upKhUNR79KzsznyHAZqq2v7Natf0auhZl3SF9/WUW0HYmkoypUXfp2ECD2f/SEAbqZ82EJ4eq/DwlPrLPndXt7a3L1UFzZlq9eFfiX//ntZvkjjRDQdcmY8iHtciMUtHX50zrvlPkkSJ5QkNlhrqtrVWaxhgfBqHELr3xkUElsO1G3dFkw7V3T00f5OlG0OvQn39QHnWch7c9Ug2nerNoSUCmxQJ+9N0eMz/dAdVrgH8xCURxrIS/dOGvGE4CYR2k7AkMgHDWwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(86362001)(31696002)(36756003)(316002)(110136005)(66946007)(41300700001)(4326008)(66476007)(6486002)(6666004)(478600001)(66556008)(54906003)(8676002)(8936002)(2906002)(5660300002)(82960400001)(38100700002)(186003)(53546011)(6506007)(26005)(107886003)(2616005)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1dyK0U0cWo1Qmkra1ZoSUFKSnZYL1U3UExFblpncmk4ako0bUZLNmdHNWwv?= =?utf-8?B?ZnMzUE95b213cFpGV1QvT0prSS9CN2xYNUpwTEQzZjcyK2NqdjB6QzdtNjU1?= =?utf-8?B?dzJ2M1IvRzhxSHh2YlNOU3YwWC8wSk83bkFOaE8zOVBoYjdSdkJKU29qSlFp?= =?utf-8?B?YkFRQjRtaXZUV2J4cE15SU5DanZaeERUUlJXZ2RyY1k3UTh5dUZMWXh5ZnpC?= =?utf-8?B?R2xPdzlIaEFpYkcwUGIxWEx1a01lcHdhOTdja0hzK0wwMGVzV3h1N2NJbDVN?= =?utf-8?B?TnJ1Y0pNbVhidmsxNmQzN3VLOXVHNHkzNUpIMFVrdVFaU3V4V1FNd2t4Um9H?= =?utf-8?B?Um91MXBvL2FNTU9QVzU4VGFwdnN2MTdlcEt2M2VYVzNMSTNsWEd0aUNFd2ZG?= =?utf-8?B?RTdjMzh4TVNDVjg0YnM0Qk4ybjAxQU1JZ0VROEtneFRmdFNFK3VxMkVDVGRj?= =?utf-8?B?d3dHZmUyN3luQmI2NW4wdzRSek84VDhOdmVvWE8yNS8wYS9PdVZkNCszd2FJ?= =?utf-8?B?dEFldmJQVkxJZnh0eWsrTSsvYjluUkt3bk1Dci9KYnZlV0FsQUVUNVo5QzdQ?= =?utf-8?B?MmZad284UytNMXJOWnMzdGp0UlFKTVE4dXh6OFdkUCtQNG4yOGJsYzFCenM2?= =?utf-8?B?clBmbUxrb0t6OW0yNWdwR1FobHcrWWhMdHp5bndwd1d6K0NuaVF4QkxteUxq?= =?utf-8?B?TCtFME00QkFmRTg0S1QvV3dNQ0xQWmNseXR5SVRTRWM2Q2lINHVWUTc3dkNa?= =?utf-8?B?bWJhZ1ozWFlUYVVQRkxpYkVOeldPUStWK3k2Zlp2ckJlWXJvTEN0U2xhNzB2?= =?utf-8?B?OGZQMlp2eEpkT2dlQm9GVWZXd0luRDNlSFA4K1lXODZvVWp3Z2lwOUUzeDd5?= =?utf-8?B?VmhIZXE1ekw1bnNTeVBkU2E3MnpJbE4xYmUxR1c4d3B1K3h5dEczcXNpYWsz?= =?utf-8?B?WGRjVmRWTTFkQlgxOTJNMFJ6cUpHeWdYMGc3SWtJWmlRU2hLYlhZdG9EbE12?= =?utf-8?B?NUJyQ2JXeFNXeWJCSzZ5Z2JyVkROcmtTeWo3OWwxU2ZUcHNrWW5rY3lwakYv?= =?utf-8?B?RmFSQUZyV3o2elR0RFR6SFRaZ0JCdWFhM1VTWExuWW5hWEwrMWlYaVl6cGI5?= =?utf-8?B?OWlxYUttbThrMjF6ZlorMFJiMXN6M2x3dWZFa3ZYMUVBaGViWmc0UEhSdlFm?= =?utf-8?B?UDZCTkF5ZmFvOXVIUXR6dW1KWEdFNHFkdUFPY0p2UnBwTjYyT1VoR1U1V3E5?= =?utf-8?B?K3hGeVpGcHBWSTNHUCsxeTE1cGEzUkZGVnVrc0tNQWNnUkVZemk3RUQ3OWc1?= =?utf-8?B?bmdKYUhRbGpENGR1aU4xWCtrb0U1dW9nME5xdXNONE9aVW5VRXc0TktpRm5S?= =?utf-8?B?NmRXY3BvNXNUWGQxaStRWEhvTUNwNVQ5eG9nTFNXbE05cUdJaE13Vm1BYXUx?= =?utf-8?B?RC9XeWdOVHc2WEZiQnhwaDBQQ3UrakNmVUFMdzBRZkJFYjhSZ3lTZHdzU1ZB?= =?utf-8?B?L0pzbkl4WDZHZmlzb0l1TmJiTjRlUDl2TUVhbmhtTlpYU0ZwRlpmZHF6NEMv?= =?utf-8?B?VHIxQjZRV2F1WXp1UTFiSk5NVzVGMlVRWkJTbFliQlc0RExKV09WQ3BtRTN6?= =?utf-8?B?Vk1vVTNEczk0a1kzS1oyWGJjRHV5TUxRVkVlS3FOWVE0NUthSGRwUGJvUEVp?= =?utf-8?B?MC9IemNwY21WQ0hWSG01SFhpbFY2V3NkdW1WQW5JcTNoR3RscklvK2pPOTA5?= =?utf-8?B?QStJeVZ4cjFKQUJLYlIvR2pNb0Q3c3FtbW1TZGpwbzhkODJIeVJqRk1IRWg4?= =?utf-8?B?SzdWZmhkZWVGbFNBK0w0c1ByNnphdWdEK3kxa2Vnd1RKNUJpVzhEbC91VUN3?= =?utf-8?B?N1dXN052dTUyVmQ2VVdBbmhhK1hzMWxlZTZxYURmV3BkTEh0K0JRR2FnTVdn?= =?utf-8?B?c25MMEdGVEF1UWg4eEFhZ3VFVXB1dDFuR2EvWmh2VTFKTTVkRE5uV3U3TWxy?= =?utf-8?B?bThkcWY0V240WlEyN3ZQRzZSa2V0ajR0VmRMWnRrUWRpOEwva2R1Y2dnQ2ZH?= =?utf-8?B?TGRET1hvUlo1cHdhWHpoalE0ZGc1czRZeHdrOFY0T1RhNG91eW4vY0hXb2Yz?= =?utf-8?B?UXNsK20wQTB4UlVLQllJQUVvdmthbkNPMVk5UVRjZUhzWENEWkJuc3BsTjdM?= =?utf-8?B?a3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xUomECeXBtq+WFmCfpv4zrD+GjCWFVP/mBJtFcKw+xMpGbPRyCC34tQkdB0tT7taj2GWBlcHBNRLPyba8bQ009ZEBe7JpyMdhHPldjOs0eoAkdiK4Nonx1DRb1vebrdWMKqOd3/YJYFNwJzdpJZ/KGPnsQ9EXVD53+o+KWHGIC+kX9QlHhnRRjJnKEfgrM9n48gsUedtVLsnZwcaYMOn3pAl51h2rm+WeAr+t55GzVJsLj7ojT4tXIEa4CWTza7j3XP8LABkq5koyie9binPr1Fpnnkr44XauBHBhekHSX+nrDcWox1z+cd9knXPnUE/w5+EZfl3343fv/cYssUulvKSYT7J+h9UacMfHf2gRoiqezS/e/z0U6PxnDSA28hhtQrXAptj0WYZJ67Z/4ZAV6tv68ZMRk66IoaQF61MZuC7caXsoyBgU9UercwrT94CvtSRRaxp4+AahkaDU/tODeAtlqKOciXmqffPaWr2CqB/n4hXWLcfqR+r0nhlq5nkoPHMK5kcUc/UYQ5aizZFcsEmjtoCpkXcONtPoFFr9trM1/uencf9vH+uF5zbH7zxhrqCmMTBnPdcAQi6Q9FH+jHrFfeXPIAG8+izbO19S7gmXEbvb8WB/8dGeAVen9JUpg6khRzVJu7ZhzFKVtV3JzNJJ9qJhZPYXmQUG+dmbUqJ+U8wG19zNELJDwo/NPCM1KmxHGlYWMR2oMR067BiWhlx6N3REKKNUjQ8rXYp697BxqJFJl5W7IECy1P0pgOGUp31WZCwzX7iB0CsgJf9YQGi4VYu3lGUhMkxzGwkgZQ5AKIeqBl1ZsMQ89JkLYZ9 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 716c6c66-42bb-4f2f-8be2-08db36b449b5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 15:33:36.4315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mPaaEM+aXghqzfcT+fXTdwN++BFvDbj0JB5xk+JfTynfAvkAkvktnxMB22Jii8e7qo9JWDhhoHsq4ge+6XmlsAKiej63FJjt98S2iyLJXz4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6768 On 06/04/2023 3:15 pm, Jan Beulich wrote: > The assertion at the end of x86_emulate_wrapper() as well as the ones > in x86_emul_{hw_exception,pagefault}() can trigger if we ignore > X86EMUL_EXCEPTION coming back from certain hook functions. Looking at the comment I wrote back then, I don't think I'd considered this case. What I was fixing at the time was the case where hvm_inject_hw_exception() had raised an exception behind the back of the emulator, and any subsequent exception escalates to #DF. I guess the comment wants updating to discuss this problem too, where the hook queued an exception but we didn't squash it properly when deciding to ignore it. As it's debugging-only anyway, it might be worth rearranging the expression to be if ( ctxt->event_pending )     ASSERT(rc == X86EMUL_EXCEPTION); else     ASSERT(rc != X86EMUL_EXCEPTION); because it distinguishes the two cases without an intermediate round of debugging. > Squash > exceptions when merely probing MSRs, plus on SWAPGS'es "best effort" > error handling path. > > In adjust_bnd() add another assertion after the read_xcr(0, ...) > invocation, paralleling the one in x86emul_get_fpu() - XCR0 reads should > never fault when XSAVE is (implicitly) known to be available. > > Fixes: 14a6be89ec04 ("x86emul: correct EFLAGS.TF handling") > Fixes: cb2626c75813 ("x86emul: conditionally clear BNDn for branches") > Fixes: 6eb43fcf8a0b ("x86emul: support SWAPGS") > Reported-by: AFL > Signed-off-by: Jan Beulich > --- > EFER reads won't fault in any of the handlers we have, so in principle > the respective check could be omitted (and hence has no Fixes: tag). > Thoughts? We already require LMA as input state, and don't have an execution model where EFER is actually absent in the first place, so passing the whole thing wouldn't really be an issue. I have previously considered doing the same for CR0 too, but at best it's marginal so I haven't got around to trying it. > --- a/xen/arch/x86/x86_emulate/0fae.c > +++ b/xen/arch/x86/x86_emulate/0fae.c > @@ -67,7 +67,10 @@ int x86emul_0fae(struct x86_emulate_stat > cr4 = X86_CR4_OSFXSR; > if ( !ops->read_msr || > ops->read_msr(MSR_EFER, &msr_val, ctxt) != X86EMUL_OKAY ) > + { > + x86_emul_reset_event(ctxt); This is the only path you've introduced that doesn't restrict the reset to the X86EMUL_EXCEPTION case. In principle you can get things like RETRY for introspection.  Internally, UNHANDLEABLE is used but I hope that never escapes from guest_{rd,wr}msr(). ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 15:34:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 15:34:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518931.805958 (Exim 4.92) (envelope-from ) id 1pkRd2-00024d-9e; Thu, 06 Apr 2023 15:34:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518931.805958; Thu, 06 Apr 2023 15:34:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRd2-00024W-5P; Thu, 06 Apr 2023 15:34:24 +0000 Received: by outflank-mailman (input) for mailman id 518931; Thu, 06 Apr 2023 15:34:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRd1-00022u-5a for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 15:34:23 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f13c028-d490-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 17:34:21 +0200 (CEST) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 11:34:18 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SN4PR03MB6768.namprd03.prod.outlook.com (2603:10b6:806:214::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 15:34:16 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 15:34:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f13c028-d490-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680795260; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Fo534stp1uE7qEY5cfiGY31pmf7oA8z54TWbmIphH0w=; b=eOvvnPKx4eRb/D2a2cpaX2AIVoUEKpijzx9nf28gPJwRDpqYg0VLnPBb 9p16AyowWnEi2GkVbh5w58Q36uFKzycHAhtVFiKj+2ZmH7dUhoHe8FIGk 0UDs53aTFuuMVJwMoUhKA6B5pAiHO0CzSitL39jWP6XVtJQq3190WXx31 s=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 104498565 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7ODgZqK989CjcTn6FE+R/JQlxSXFcZb7ZxGr2PjKsXjdYENSgmRVz zFKCz/TO62NNDCme4xwOd+08kkG6MfWzNVnSAtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRgPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5aXEFCz fY6CAwtdzqIt+as2ZKQYOtj05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHunBNNCSePlnhJsqEae9kkBBxctblmYs6apgUuXYsocI FNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqYCYFSU4J5oflqYRq1BbXFI88Tuiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAszA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:dT3QeKk5aUjOiwP6nGiDRSwNVo3pDfL93DAbv31ZSRFFG/FwWf re/sjz8SWE8Ar5OUtQ4OxoXZPvfZqyz/9ICOUqXYtKGTOWw1dAb7sSkrcKoAeQfREWlNQtsZ uIKJIOdOEYZGIS5a2RjWXWLz9j+qjhzEnCv5a6854Cd3AIV4hQqyNwCgOaFUMzYQldGPMCZe ShD9J81kedkGosH76GOkU= X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104498565" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixQ8+VxCLOd8BYAkH7zHxzqY/FbO/+Grj7Z+IxXexXTO3lr1PfnXsX9PMETOo6YwLVyddCYfUT5ws6fGPKCS+ZbDsJ5H+9y7/mjPh/w0kILu7Vb1gDD+2KEpaUp8vzwpbgYJPf4GlTTeN/XlMXn+KrSfIowhDAS5cGqsMzGQm6MzFmuoOuHAIVrOe3iTEOJsDR0m2Jr7OAzW4qT9plfR1FqkqRV6TNzW6nf6pjPW6HNNvkaqiWaqNKoogPoKGh6YhRTIZDwpiia4rlYkEV5GiXWD4KwkvaBrPvmTPxWVCeRD5MNEEU7slI82bDg06lA0VaWkNO0rpPq18qxFx8PiSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fo534stp1uE7qEY5cfiGY31pmf7oA8z54TWbmIphH0w=; b=MX7uf6S8zXZtlR4wrRsQusEfGuyyzFNpoSwlxkKLXSAc4gOeZpYewWvA7B2q5+9d3k290PTA2NEEPAiwCLrNSw+gTFSS/pdvA3maDvtIhNTlAOb8pbm53HpasxOFtjy11twgf+b9rDiC8n3G8a2sIA9k3mN3xDWs2V6fgRGb9an7XNqCzFLPcyV9GLYKFPi78jYS2P9kOjcfeNiUcLsM4sPO0ZH99+uIE1N931xubORNY10fNWqgB2o2dZQ5AasszxlPinAU6HJ6Cxq3CmgNyOQXmFByV70xczKYpQnOCjfBRN3lqNEMLTjCMvdeDsP4+o2Yu5ZsBP/VpLS3TqK6Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fo534stp1uE7qEY5cfiGY31pmf7oA8z54TWbmIphH0w=; b=PS2RmEQDoDziKfnwSb6loomN8Xv/bjTyzNMzQPhdvSdblJK5YzymWq1JoMa3IVggRW4r7Wrs1vi3gQH5xjZT1DMLApwf9NHsKVTC3sEpzMFCMAqgULU1HsxzECzjfhvrzxpI0xRb/syWBzezCkAD5W4XAmqExDG7X8jtZaiOPzs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4dabc9c7-7c9f-1fb4-5555-827d282f0567@citrix.com> Date: Thu, 6 Apr 2023 16:34:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 3/9] x86emul: drop regs field from emulator state structure Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0169.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SN4PR03MB6768:EE_ X-MS-Office365-Filtering-Correlation-Id: 267078b5-8c83-4b1e-1719-08db36b46164 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +zUxhH4aE0TYglcYvP78cFAZeHcZ68V6qvLDUnaw8doEcv/soCV8JsJMjMGMFXJAq2i8g8k2Xay+u4xVRDhkRtGaaa+gfaf2aOqAunMnnkIr3VZlU4hX/55rk/eMD8daIJQPlR17gILhLVfhosqad7FtUyvGQt42/GVJtjIELmyChbiPgCFY+7GqfCdGTgfK5LD0teger2GrSp4gQLKr3WWTqPcowUTrL7RVxe/zxI28Q4wUN8eBdIz2XUhHlgPTb6aISaQ5otc7cVl0qGlm+2mNpRupWVyBNP7/2WHAuk9k2rVCzDtMCehH7ZowH8ombEndeXvQb2n2DsoFmDNLl4MYJuSs0HW1YeFUpJd+sTnAhd4vh+micDaAcbYpHXqqHOMoHf+ssWkyEPtA5pqMTcfxi55UI5DZ1zo2q/MJYiJFQMnqkvYoI7vmVZbCCnYmWgcIaeZ41owjqOlBl9wLQRh/cQV9yUIaLKtLRBFYmtL4uvcuV64FSFFur3X+hBfJlv/akEn8PhnpkQk7n7mqvxVkLTTdWlktCyc6sbi0k8jT9zvVUj5+B9kypk60ST39e67LLbM1LLYi231sOgrS/EaRD7xyWi6UgwKOLrrrxSO8cyGONp6pbldDwjuJth8q8RcaNMhpEKq3deiYAutiQg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(86362001)(31696002)(36756003)(316002)(110136005)(66946007)(41300700001)(4326008)(66476007)(6486002)(6666004)(478600001)(66556008)(54906003)(8676002)(8936002)(4744005)(2906002)(5660300002)(82960400001)(38100700002)(186003)(53546011)(6506007)(26005)(107886003)(2616005)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHoxZnpzeHFDdDNuRERqNUFHRFpZaFRkQ0FMQ2YvU0xjZVNjZXlUZm1jOWRI?= =?utf-8?B?Z0I4VUpERmVoWHEvVjZMbUEwcUh6MmlnZTJTdnFNQmNYeTBmYnQ1SysxS094?= =?utf-8?B?NXJNcEdTcEh3Q3JwQ2dEeUpkVXRnQ1g2NWVVZ0ZRQWpMdktrdmZlQXBsV3o5?= =?utf-8?B?cjNNUXJOZlFBZFo3SmVFcDRYRnNvaWdFeWpiRmU3OHlmVUdHQ2pKOEZhWWlI?= =?utf-8?B?V01Yc2M0bmR4MVJXUG41eWkwck1YQ2dDcFFDK2xuZHRFWFUzMEJNNVJjbGZ5?= =?utf-8?B?eFhWTDN0T3Y4UlVKWmNNeUlpcEU5Z3VLSHhMaUlyWUlSYlJuc2hvY3ExTDM0?= =?utf-8?B?K28wWmp2UXI0MTZoU0ZOTlVuWk1Qd2FsaGVFNHpkSnBlK0xhQ245VGV1MXpS?= =?utf-8?B?bTdTS2YwazZCQzIzcGcxZ3FDVjJZWGNXN3hoeUd4dWxQbzBpUVhlcDdoOU1T?= =?utf-8?B?MzhzOHZDM1doRlR3U2U1K2JpRjF3MzhvOXpCZk5jb1MrTkFJWTh4ZWtHazJi?= =?utf-8?B?NXV0YTRYdFFyekkrbXRya21nL3BuL3I5S0RpWUh5cklicWNkYnlWWUNYR0xW?= =?utf-8?B?cVFjUzZYZTN5MDRvYXFlbk5oQXo3NXZIR3BzMW5obDZPalhuRE80aW1IdktH?= =?utf-8?B?Q05EcUw2VGxaQkthLzNmOE5CN3F2LzlnWHphN0ZISmRLTUdXalZuZUM3RTN0?= =?utf-8?B?MU9JaUY4VTJmdTRWc3dlNmQ2KzVyZU5SUDM4UVhtTU9OUHprQVlUK21rZXps?= =?utf-8?B?eEZ2SHpkNEU1OTlzN3NTRzdERmpJQ1oxWmFKakZyMlR4WVRVQjZiSXBNM2sr?= =?utf-8?B?bDVLREZZMzVHUVFVYjc4Wk1hbXVEaGpENXd5cUIzVjRCeU16VUtVenIyaHR0?= =?utf-8?B?SmNwRjJqZjdQSGlXMmFZbnBiTFMvcTZCMXFKbjNHNC8zS2dyR0p0cEJrMWVq?= =?utf-8?B?YjRLNVVjemVIZFJIekhLSzBibU5yL3BOa1ppenc0bHMzWmFQeG9rQ1hDck0y?= =?utf-8?B?TXM3REFqNGRYUDlHSmY4blp4L0EreHlaN0hIKzlNUStEMnBnYkFFajIxbHh0?= =?utf-8?B?UlNsZ2xPUWJxWFV0eVpDZFFQSWpQQ1A4NU1jMWpQWHh0TFcxakJpWFYwaGt6?= =?utf-8?B?bWI3ZHNEd05Ndloyc3R1cCtoK3RLdmlPY1V4cEZPTmpMZXpEV09rSkRHY09E?= =?utf-8?B?cWZubWFoZlZRRGFBSTB5aUt3T2JWQ3lXbzNaSFdWSkdhTFBkb2gzUUFLZG9z?= =?utf-8?B?NmN2SFNZbGhPa1p0MWdDYVYzRDZDSll6STdkOVZSTUlZVlRyS3pVYUwvWFRu?= =?utf-8?B?bWN1V0h5RHRPNEFMaUlDSDRoS1QwWGpiV3dHdXprY2pEemNPV2cxY2p3eHZ5?= =?utf-8?B?SGtneWM1Ym1YV1RCbjlMU0xZOFNpaW9pM25DWDZTeWJGVFV1NE5qRUV5NVBo?= =?utf-8?B?SHk1SVpjYU9MY01QbGJHK21LbGcrV2VUL2k1Q3FFNk0wS2txMmZaRE5FL3U3?= =?utf-8?B?M0Z4d2hrYlZXT0pSU29MZytGTlorekdER0dDQkZZN2owSUlHZTJwdlpuWTVo?= =?utf-8?B?MXZVNVFvbklGWUpvRWZwT1lVdHFmM0tEZGhJZzUyOW95SkxnTm9IMFlONlJo?= =?utf-8?B?Q25OZDhvR2pnOVpKWGw0VUtsZTQ1Wkc2K2REeXp1ZC9DYzk3MUNTcUU1TW53?= =?utf-8?B?UXlQaEFhZWIzQlBxUFhmbHJNRk1Ya2JQSkhMcWg2S3FXL3ZOM1VSSmpHaVVI?= =?utf-8?B?U3ZRdzhoMGVSdlJXS1p0T0ZHb2dBV2FQb0xNYkpJSVE3T09lcjQwTkF4SlRB?= =?utf-8?B?ckpXZGtubEVKOVZSMEs5MmVlenR5WjFBb2I4RStBaTkxQms2R1VIUE1XVm9o?= =?utf-8?B?d3FlUUVzYjFENlMrbS8wQXVDdDM1ckYwRnhvTlNwSlJlV0xnNVcyNUt2NmxK?= =?utf-8?B?ZXZ4K3l1ZWpvWlNNdURtTmVSMUQ4bFF0OVZDRlpWalYzcm9CejM3RzFncVJa?= =?utf-8?B?ZS8yOUxqREp0bm8zZE51SXpJeWVTbmtqMzI5KzZqRXBheDY1U2d4Zy9kbWRl?= =?utf-8?B?eFlOZStyVzdmUWdUL05oR0k0djBrci9IZStYZ052b3dlMnVtK1NxRFRxU1VB?= =?utf-8?B?b3MxTFJCS1JuNzdYM1VxVm5MaU1ac3cvVjVVa21FNmFUMjZFVlRiV21mYzgx?= =?utf-8?B?RXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: L17J5MsdPsNkDCn8jcn+HUBwvjtg8oO7BrrfwyjzMysls4ZvzhFDh3MULyfLii7wc/CYk7Kqn3i40i4Mu0a2a7Q/fx0u5BiOZSJtTgHy6cttrS1yFaZNj1lxqqpN5l1FGS7HRBV7uTVvBVWb4qkgZRl5jDFYTA80PchnsgqyNloWLwf+aEHeKpDuWidE1aknnBB+ZJuY7jGppRl3Rme44iRXiumP0pCaG/HD9R+OwHZjg+5koljNYsFK6Y7g74DYURraj0OrrfXxLHdnbhpHxS8CxCituiuqDUBAa7787iLypm2Og5CYyrkNY1g/ghNuZboMCCSXlAqrOxe6nW4h65zClh7ViZ/bzum5KDRCqQcBFPpbKfFz7sufKZWE9GLyQ8pMnzooD7nvddFqaT7jZZt/6n5dV9X2YbVVgj27Wae5kZYQhIntcnvm775SVqG5lNe5WKccnFFQ9F0B8SxzIuLKUfCStPBhD4DdlIJvbIseuKDHM4oVLpahof1kQVAV4IhuXf15WbG1lmwStonOvEMLqEvGvEkaR/eweK7l5W0zcGMyjnGP/XPv96bmWurKI9h95j3uWpd6ThaOycReglxDkGss5docG12+5KCe9spUZsF+VXCGnpfggfJqujwN6+Qq58xIH37Sq5ldrX1CTx/hGy4uwEf/Er71wF0P8PZ7KoWQ4D5eKl3uCNulRN+lhtHYzgJiROB0jE0q2zNTyu0GORqjfyCT4qdIaf4tv13bpW5H1f/DlDxRQswDLq1hRsIj6IekbwgRldkh81fCGMIcyJWVQxigZmwZzIJwzYuDTiGmCO2O+atMpZIWr4DD X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 267078b5-8c83-4b1e-1719-08db36b46164 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 15:34:16.2125 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MgbqYcmn0r07erzj7/m/oKROZT3iE2Xpw2VH1Wub5g7OnwHV5jWZifQlFYnulKy7wvZJP1XilZXUvx438CeF8bqptdY9BjaXAtczkznARUc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6768 On 04/04/2023 3:51 pm, Jan Beulich wrote: > For an unclear reason 0552a8cfda43 ("x86emul: track only rIP in emulator > state") converted the original struct cpu_user_regs instance to a > pointer, rather than dropping the field altogether: The pointer merely > aliases the one in the context structure. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Apr 06 15:46:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 15:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518938.805969 (Exim 4.92) (envelope-from ) id 1pkRoT-0003oL-GE; Thu, 06 Apr 2023 15:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518938.805969; Thu, 06 Apr 2023 15:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRoT-0003oE-Bf; Thu, 06 Apr 2023 15:46:13 +0000 Received: by outflank-mailman (input) for mailman id 518938; Thu, 06 Apr 2023 15:46:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkRoS-0003o8-4E for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 15:46:12 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0623.outbound.protection.outlook.com [2a01:111:f400:fe0c::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 247cc80c-d492-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 17:46:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7053.eurprd04.prod.outlook.com (2603:10a6:800:12f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 15:46:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 15:46:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 247cc80c-d492-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4UssXYJBhiBhKXc24U4kLrz4ABPVGONvoYBTbKauR5lXiNG8v1fVSv26GQqf7tSaENFasxFzORzyx9Ye5cucNBjUcebpSqN6z8oG7s9trtwSR8WYyzKcSK7ujDZJ2RJGvPur8Rz2FCulNjUKoqlSyQ+URIAVdvZI3FsQhG35JEreN4vNI3hhaQm/JYBfdrBOjnPpNh3PK16qAnHnJdYzDRYmaN8M6p/ruOmwSScN1hQZxVPsDY+gW+nZ8NMlJIZ5O6ulXKAi2ZwWtVot46XGFGgUXVIe9QA9bS080y7u9PaYDL0AMcuschejxnAcnzyR5j9+oPXmMIIMqPMXozecw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=thYrrAGxFG6X4w8l/nrCK7sjikeycPS+9A4eS6t2gXU=; b=nOaYIJKf+oVkyovyP8xoaeWKTIZ0umLtrQfZZyRsUsSwldpeZ6Buqn7Zpm+KJZjR6vqaYyuEPZTEfcKV5Ew1Rr0Q3gejHx/HeJdWjRG41GDWJcfTZ5lnQ29yWL1OoJ6e9hThyeqU12Vdh+4IHOlCW6Zt87sWjQUWc2T9vUWES8djkBDwSuftXSHI5soyETPtrBF5GtlMYAEmwDcifMh0GKE7rkqsfhkwddf5Lqv14qDGnH2pFvqffg4QsztVYsjAssoFzAWk/pgObGwIsMhX4oEDheSqgYnTaslu6q+XrKBcREYm9a82bojc1F3zo6McVq3lBxsp/OeL7WY7fGrDYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=thYrrAGxFG6X4w8l/nrCK7sjikeycPS+9A4eS6t2gXU=; b=gr4BwqNG1O2QaOC4XMYhs7ujM2ILbS7oV01f7skkl7XlONLGUdqUwLrj9n1+4l3EAsfLK0B08BwYgDrKBH8ba+M0D61Hbp36Y9KScmj9XGeHvjqVkHaHgRmJ+tboZou1IEZ+QvokAqSUynQrUjrn/6pRPcrkIs+QKzi+ZS+Mveoh351qt2NdFtColp14C5SzHSkERgIFFK6Qk2HTXfSCbBHOVqsgPuyUXMxIg62BYTqtkgyF084PzNySwwuzZo/c0V5ASadd81FIvqr1jwAZ9NdNVTEs9YJ5bh1S+DU6HoOZy3z7DCajyPH1FCM+n2FaGSa0UYMofyPl41LwNgn4gA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b1ea79e-013e-f5a5-eb36-a79e400a87dd@suse.com> Date: Thu, 6 Apr 2023 17:46:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86emul: avoid triggering event related assertions Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <4fc4f5a9-0b9e-bb30-df32-09b5e9e63a57@citrix.com> From: Jan Beulich In-Reply-To: <4fc4f5a9-0b9e-bb30-df32-09b5e9e63a57@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7053:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f3071a1-9b86-43ec-d921-08db36b606f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kjqlDdbb2WNUYOPqfM9I5B41VwononOqYcD3p595yH3zfTkHi7lh3Nr0L7CWaa8X3xFj0Noyt8hKqR0ojjLuVsaXVKxO2JM3/v9cRUQxaArUP0y/VQwrwXfCGJUN72QNH9zWFOokzCU5rKjCBNjgSZ7emy0MuW5w0Pg7Wpv43vLF4xIl83RK3oTNhfglyNKTbdrHmGkig1Y3lWAYGVuJ0ubzuroHMwq4mUy3c3hNXOooydtZCOhumqQWjT//DKA4ygKuw3FbtWBV6iPdr8xHcfnd+uFjyTlAeaoza+d+qhzsEj5O5Z3JjJisTMWPSMwuxLukyr9NtaFhw2dvcCH1L/N7HO2oTCtlhSalOVLeHNZz/Ydze+2ZEGhYuAxSbiGiTllCM4oiK4TIClE021Q6EVpvUOcRz3qx1mfTQAT8EhWpjnj1ePJjhFgTZIU0BbOSSOdzJgN8SCc1l6bfIxTwvWuXahXfUrSb86jjiILch6mMB0bkiT4K3F0aJY9Q3HXbX/StS1ZyjIqSv7m7lek3K3FJMRiu8Wg3r6A5pp7WwXLnthN+GNE2t2y7NdOndMDvIy7H8pG+fG62fzNE/HthWKBOcnzOuc1h+eVufBRBJI8kCJshXHOBqIrTYF5GKQT9/JaapSGZbe+P7F3TOLsgKg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(366004)(376002)(136003)(39850400004)(451199021)(186003)(26005)(2906002)(6512007)(6506007)(53546011)(38100700002)(31696002)(86362001)(36756003)(2616005)(8936002)(41300700001)(5660300002)(316002)(478600001)(54906003)(31686004)(6486002)(66476007)(6916009)(8676002)(66556008)(4326008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWxMRXNZaEpBZ0RyZTBxcHMrb081bjE1T3Z2QmNBVndiSjFQZ2lkTXl4ekxh?= =?utf-8?B?VXJVa3V4d3hXTFNwMkY5d3pCSndOTVo1MmpRVEtrdERSUzhqTWFyaGxZaTdR?= =?utf-8?B?eUxYMWk3U1prU29LYTJQcjUzUm5FZUlHaDExUHpleTNxYXVDT1dXc2h4aHRQ?= =?utf-8?B?WG1pOUo3ODM4eS9RN2E3NU40OTV6WVN0YWhRTHFXait5aUViblpyK0hJeEdz?= =?utf-8?B?TWtCRzFNSlNtTzVXdUdjeVNOVDRFV2VhbXRYNnhZR1dzb1lwU3lQN3FhSmJa?= =?utf-8?B?YVg0U082S2ZZVmo4VEFjR25qeFNKUitRQnhhTTlnMWpWYVArTmcrMjQvbC9H?= =?utf-8?B?MlRkZGZZemU0TDlqemRab2tjSU01a1U3NEt3SzZJaUVTZGpHeUVRUnc4Tlc4?= =?utf-8?B?enVWZHdFRjR4K0g3a3M3b0hsaEg1Z1d3Y0U1Q3VQdGdHLzZEeHlKdy91MGJI?= =?utf-8?B?NmkrV011VEkyT1J0OUlieWoxaFM0MFovVkErcEZhS0pRYk9qcDRYZ3lWMHVJ?= =?utf-8?B?RU1IeXlndjQ3VG1hM3lDbGdKaElLWnV3eXBsUGRIcmpUUFpCMndXR0E1Y3Rr?= =?utf-8?B?ZVNPNkJzVXVLVlRhSzNadHhUamRTaTVEQmJERGxsL2Q2MWd5QUFYZEFKVmov?= =?utf-8?B?OXZsVWhIOWVBelpTYklLMzRnSWEvc1JDMkZNZHlHeithOEtiRzRnSUVXWHpE?= =?utf-8?B?emxQYlUzT0xTcTd1TUo4WUNsUXc5UXdzZGtrdXhxaDROMjRsS3llemFuUHBN?= =?utf-8?B?Z3ptZXlUSW93bXNyUHViSE1BM3V4ZkdNQStuaXlIUU13UXZPSWF1Q3Njam9l?= =?utf-8?B?TXBxbml0bkRjaGR5dyt5bUtPdnVINkVWN3k0T2VzZDh5a1F2VW5CY0dtdjFR?= =?utf-8?B?QU1paC9TelEwZ1JRTDAxTVkvOUkzVXYwSFY0UFRnWG5ORmZqYmgzc3VIYzF0?= =?utf-8?B?akdWQ2pyY1BtSFlsR1hnZERJaTRkUW05Y05rU0U1TzZUc0JXRDU5dW5KZVhH?= =?utf-8?B?a24ybDZZUHd0NlF1UTVQQThGUDhYOFJiRUp2OGNVRHBYUzVYbUp3TXN1YUMz?= =?utf-8?B?aXl6dEZRNWZ5NXN3SEFOVVFQdnplcWdSYmdsQlJRTzJpZldTQS9YcFUvYWZ1?= =?utf-8?B?TEtwcHZodHJJU1ArSTVNTjlVdHU1ei9GM3JwRnJoSEErVTlmaGRJZXBtbXlp?= =?utf-8?B?ZVNYWm5UWGF5ZGJ2Y3B6bVVURWtWLzdGT0ZzaGo4UE1CQkUyemlLZHp6RWl1?= =?utf-8?B?S0M0b1pWNEtJT1NIWjFQSGVaUUgvbDhaclgxSFRRMCtGVFpHSCswaGFBYWJv?= =?utf-8?B?ZGl1WFJoenlWeE04L1F1ZnJvM1BHbVhVeURJMjBDdXdpRnRaZWxrS3FlUy9m?= =?utf-8?B?ZmZPSGt0NDV6RVVISmQyNmFFMUhhNTBKZTBPaS85UTdRRzdHRDhXYlUwbDl1?= =?utf-8?B?SEVzNDRpUHE3NHJKL0wxUXRaYVo1cUE3Tm1KTUx1dmJrdGZkWWZQUVNsQjEw?= =?utf-8?B?RmxoSWxTNzBlZUxlNGorWE12OU5rVTJPMXhBTHlTSW9jK0M4cXFDUDcwZUdX?= =?utf-8?B?SUdjTjRPV3BRZGR4SWpyR1p5TVRQRERJUXNWcE8zNS9SZ3phZ3ZiWWdsbndC?= =?utf-8?B?WWlZcTVZVFl5dklpdjdURnVaTEliR2I3ZUlRaWZnS0hiN3JFV21kQ05tSXAx?= =?utf-8?B?eTUwVFNIRzBJak5MZEwvZUxQaTljRW1MeVlkNFBSenh3Qm9xWnhkcXg2cVZZ?= =?utf-8?B?eDV3VVB4R24vdkhWRGl2VXhtYWx6Mkl1VnhPbTAzODB5WlZmTEF6aG8rRGdk?= =?utf-8?B?SmtzcC9hTTFHL3lYV3VVd2I5c21zMFJaM25ydW5hYXUzSDd3bHJYODNScE5j?= =?utf-8?B?cDAyVHBDSWhTVEdheGduVEpBT1Raano3amxjQ0JneVBiUGxXNkgxWnkxMTE2?= =?utf-8?B?OGd4WEM5K2VvTHBFS0ZSc1o1YzBYZzdsKzRGOURYZjZaczBhZUlRQ2lBcUZ2?= =?utf-8?B?N2tQYnJmak1TSmtSNWRjbVRIT3JaZmZXNEc1Q1Q4U21QV3JOWjlmZyt3cXU2?= =?utf-8?B?Y3hTQ3dUb3d1dDBiTWpLTUlEemx1TnlDbkE0ajEwcnhkZUJJYThFSHdZRXhs?= =?utf-8?Q?wbbXAj8X+wzl847uQ84Nla7DB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f3071a1-9b86-43ec-d921-08db36b606f7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 15:46:03.4645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X+o1SYKtcG775HbCYT1TlM6VPty0FLGV7Jclr41OMIeGwikcpgyyM+GryPnUhPaOn+CJt876/CB2Gz27Jqn5Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7053 On 06.04.2023 17:33, Andrew Cooper wrote: > On 06/04/2023 3:15 pm, Jan Beulich wrote: >> The assertion at the end of x86_emulate_wrapper() as well as the ones >> in x86_emul_{hw_exception,pagefault}() can trigger if we ignore >> X86EMUL_EXCEPTION coming back from certain hook functions. > > Looking at the comment I wrote back then, I don't think I'd considered > this case. > > What I was fixing at the time was the case where > hvm_inject_hw_exception() had raised an exception behind the back of the > emulator, and any subsequent exception escalates to #DF. > > I guess the comment wants updating to discuss this problem too, where > the hook queued an exception but we didn't squash it properly when > deciding to ignore it. Can do. > As it's debugging-only anyway, it might be worth rearranging the > expression to be > > if ( ctxt->event_pending ) >     ASSERT(rc == X86EMUL_EXCEPTION); > else >     ASSERT(rc != X86EMUL_EXCEPTION); > > because it distinguishes the two cases without an intermediate round of > debugging. Maybe, but I don't think this adjustment would belong here. >> --- >> EFER reads won't fault in any of the handlers we have, so in principle >> the respective check could be omitted (and hence has no Fixes: tag). >> Thoughts? > > We already require LMA as input state, and don't have an execution model > where EFER is actually absent in the first place, so passing the whole > thing wouldn't really be an issue. > > I have previously considered doing the same for CR0 too, but at best > it's marginal so I haven't got around to trying it. Well, that's more longer term plans (and not very clear as you say). I'm afraid this doesn't answer my question, though: Do you think the respective adjustment should stay, or be dropped? >> --- a/xen/arch/x86/x86_emulate/0fae.c >> +++ b/xen/arch/x86/x86_emulate/0fae.c >> @@ -67,7 +67,10 @@ int x86emul_0fae(struct x86_emulate_stat >> cr4 = X86_CR4_OSFXSR; >> if ( !ops->read_msr || >> ops->read_msr(MSR_EFER, &msr_val, ctxt) != X86EMUL_OKAY ) >> + { >> + x86_emul_reset_event(ctxt); > > This is the only path you've introduced that doesn't restrict the reset > to the X86EMUL_EXCEPTION case. Right, other similar ones had to go into individual other patches I have pending. The distinction I made was whether the call was in a helper function (where I want to be careful, because I don't know what state we may have accumulated) vs mainline code. IOW ... > In principle you can get things like RETRY for introspection.  > Internally, UNHANDLEABLE is used but I hope that never escapes from > guest_{rd,wr}msr(). ... other errors are possible, yes, but those shouldn't cause an event to be recorded. Hence it seemed reasonable to me to flush events unconditionally here, i.e. even if none is pending in the first place. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 06 16:22:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 16:22:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518942.805978 (Exim 4.92) (envelope-from ) id 1pkSNg-00008l-8u; Thu, 06 Apr 2023 16:22:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518942.805978; Thu, 06 Apr 2023 16:22:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkSNg-00008e-5b; Thu, 06 Apr 2023 16:22:36 +0000 Received: by outflank-mailman (input) for mailman id 518942; Thu, 06 Apr 2023 16:22:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkSNe-00008U-LJ; Thu, 06 Apr 2023 16:22:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkSNe-0007s8-Gz; Thu, 06 Apr 2023 16:22:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkSNe-0007Ki-03; Thu, 06 Apr 2023 16:22:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkSNd-0006yQ-Vt; Thu, 06 Apr 2023 16:22:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L+bfPhK96tpk6H6YoLpFvcwvHcYpa6zLp+z5/IYzXbA=; b=aHQbYeQAcdyOyi8lOSr7CZOncQ Zx8QhftU4CsmE1Dkz2sk4XntPnwjsDvGLkTkotfSlve+9BjoFCPLJF5vcY6rYTXita7uOasDOrvJx zjR3oGfNBqDdND3b/b3FZcx+Y0/aX4YkKvgjZIgHmpGGVR7/zNygO/RbAnMMmk1hef+c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180169: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a5087069a8c40541ba81fa0e2850471c949932b3 X-Osstest-Versions-That: xen=881ba20eb0222305a9d2cd090c9345992794f4f5 From: osstest service owner Date: Thu, 06 Apr 2023 16:22:33 +0000 flight 180169 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180169/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a5087069a8c40541ba81fa0e2850471c949932b3 baseline version: xen 881ba20eb0222305a9d2cd090c9345992794f4f5 Last test of basis 180160 2023-04-05 20:01:54 Z 0 days Testing same since 180169 2023-04-06 14:03:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 881ba20eb0..a5087069a8 a5087069a8c40541ba81fa0e2850471c949932b3 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 06 19:29:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 19:29:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518950.805988 (Exim 4.92) (envelope-from ) id 1pkVI0-0001Ur-7L; Thu, 06 Apr 2023 19:28:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518950.805988; Thu, 06 Apr 2023 19:28:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVI0-0001Uk-42; Thu, 06 Apr 2023 19:28:56 +0000 Received: by outflank-mailman (input) for mailman id 518950; Thu, 06 Apr 2023 19:28:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVHy-0001Ue-Ji for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 19:28:54 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41bfdbe2-d4b1-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 21:28:52 +0200 (CEST) Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 15:28:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS0PR03MB7201.namprd03.prod.outlook.com (2603:10b6:8:120::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.29; Thu, 6 Apr 2023 19:28:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 19:28:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41bfdbe2-d4b1-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680809332; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ysbyb9angYFcf8d8gX9w1IQesEb2r40c9lFWquA8ZKw=; b=aN520cBRMSY7/UbznaA7+N9daHKM68z4Krx59HW+lcc2WDj/Zrohv+vV Q2rfXtc+2AaF/wVpgKr9C8xhYU53y4y9dcsXQPf3LxdPsdcUzjTBr/n7D zb8JAVik2hFDOpBmgRGjLe2tvHsgVzN4LH8+5YFQxm8tBVa4oQ6W6OFHf E=; X-IronPort-RemoteIP: 104.47.55.103 X-IronPort-MID: 103976512 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:llOviqOtrDpn/cXvrR2IlsFynXyQoLVcMsEvi/4bfWQNrUoi0mZWz GJOUDvVPP2JYTHyeY13bITj9k0E7J6Dx4JmTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tE5gJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rxPB3tUz NI5ExEUS0+JnPju7oPrSeY506zPLOGzVG8ekldJ6GiBSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujCIpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxXiqB9xPTefQGvhCx1qo53ZLATEqTnjhg8OktVPkAdB1J BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACA4aud/qpdhrigqVF444VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTzgbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:Zm3ewqieYkNIr1U+fYtkwF6w53BQX6J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwSpVohEmsg6KdkrNhSItKPTOW9ldASbsP0WKM+UyfJ8STzJ8n6U 4kSdkMNDSSNyk6sS+Z2njILz9I+rDun87Y5pa9vg4dNT2Gc5sB0+46MHfqLqQffngEOXNTLu vg2iMznUveRZ1hVLXGOpBqZZm4mzT+ruOlXTc2QzI34gyHjTel85/9CQWV0y0fXTRG3Ks4/X KAtwDi/K2sv8ihzBXRzXXe4v1t6b7c4+oGKN2Hj8AULjn2qgKwf4RnRpWJoTAyp4iUmTAXue iJjwYrOsxy73/LXmWtuhvrxizpzToo4W+K8y7+vVLT5eDpTjczC85MnrtDdArIzkI8sNZ3wM twrgakXtdsfEv9dOuU3amGazha0m6P5VYym+8aiHJSFaMYdb9qtIQauHhYFZ8RdRiKorzORI NVbf301bJzSxe3fnrZtm5gzJiHRXIoBCqLRUAEp4i8zyVWtGoR9TpI+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqMDHDXSx6kChPNHb3eLtBWB5vxke+q3Fx13pD2RHUw9upppH 0VaiIGiYYwE3ieQvFmkqc7smGffI16NQ6dj/22rKIJzoEUf4CbeRFqkjgV4oydSsUkc4nmsr 6ISeVr6t/YXC3T8NVyrlTDs287EwhTbCXj0uxLFm5m5Pi7cbECntarOcruGA== X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="103976512" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RnxF715zXNCxTFOsqJDp/sz9voXh6/aWCSn2BiI+gWgJzMTyOWxY119jV4zEJxLwNU/hCXefI6TvHw510maiSM4xaDlpXlJl3xYFLRV0exYPSDB33gkf6maHhfGTCoI2oq6DaugwHJZteApY8FGRsRGV0DcCAusBuKyORw7IQzkNXmWVypq8sSeINAe3c3+72ljN4VbZfyK2bY5tzeywacZk3sNZt0kHfU1ObDPckEM+IkknxVcC41P6cVUvMmcrxna2GtpCqOVb9WDLFgfeZhnsUHgSs604k0oU8mX0+hAn4qk6jKugRVtfT6oZU877b0W5VwkB3258WdDGujkkrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5TTQKdhsyUGU4bjLTQMm7FDlgUpl6toPSRU4SGT/cwo=; b=gnsZxey7SuyabkwBr5ZWiDKHnSylpUIQLtxTOjQJp9T90th4Z4rMsErhPR3AfRjk9v3WwqLEFMMCqQ6v21aNr5IroPpnzFtiBihuesyEBHlO/nNqlD3f53Pw3my1SUnHynHHhnRVVKRpmg1FbqAxuKrDf5X3BFrHCigAK/y9628VqfY4OPhyvwbVGqPUJLAqJEseRMM7IBdrPq4Km3u6L/uEhRKaKU2/6uQkm+g6rMqT86o26ixZw2ZLYZrZQfT93KCZm0zvK+m2RCH0KUAB0ELWtRICutg5EWaMdgmPbyG4TBaP1yqQSMa7wTp8Vj/7+iBeN+TJOkdfXldZeNWZMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5TTQKdhsyUGU4bjLTQMm7FDlgUpl6toPSRU4SGT/cwo=; b=xIfynxckhoLEpmcIXF1ztwZCkzo+gP6+dOqk4HnO8MIUZQ8tqeJZVLFpGOIohAgP/LzC5LhI+mwoj7FbOGn32bdowK59UY1P1jEXmyP7ZBKH7e51wqaHzKXcxFdjfpApAQXWD+rwhzRDHUHc221sHiq9vo4TwynJytrhqAKZ3n8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 6 Apr 2023 20:28:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 4/9] x86emul: support CMPccXADD Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <7fdf882f-0667-e0f1-8183-2dc1a344f4fb@suse.com> In-Reply-To: <7fdf882f-0667-e0f1-8183-2dc1a344f4fb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0301.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS0PR03MB7201:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b1c643b-51aa-48a1-eba7-08db36d51fdb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mwJpRKwVuIYZgXlXzkztHuhArta5CYQougG/+UwA3P17I8GLWS/I+mVgA7WAR/LSkdC/DKmoOkSLzzee7r8syb1MN/eBO3LwlBHNfHkaccsLn+7ayo/sjjMwPPpPALgt3uh0GB/p7gJ9uQirf87xZBXqv5/dXYp6fK9VC7dat9fp9aEb9yGTSgrowjHXCrYuvOh7sXCzQNrvtK5Ifg1XjGg338kpykuHFK97iu5zP1CLnbABUJ2gQob+zD2nx4XhSbWAv5j0RhnJz3dCL3IBInFjIQqIbO+LyT3AS83ZXrGwGzh+ujJ3RZvRIYtMsMTDedEB6zS5IxbJV4pyUmoFcuAYBsHeVbRf9Hb+ThJRh/zRY1VCwF3LuyFnqF95hxdr9aNxskGpOmoi0mhO9hD6OXTCtUbjA5UQIo4/3h7pTAubM7KbedKpxiDpQ/CQzvtGgTu9w2oVFPR50r0DKB6VYpvzer1JOk0Miy3slN4ewC/NjjCW0Vs+3iCaC04ZvQjoJsgNgi/x2q3cFspcQkfirknTTW9GXG34lW+y8JriwRfOpvXYpM2XiNmtcueLvlS8xQ+QLMDs6B/ZNSajXbm12ZfqeCogDQhzh/DWWs4i5e2c4giObTruuEuAeeG+NFViyOaVe30MFqXk4dVwfvHKfQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199021)(54906003)(66476007)(8676002)(66946007)(66556008)(41300700001)(5660300002)(110136005)(478600001)(8936002)(38100700002)(316002)(82960400001)(4326008)(53546011)(83380400001)(186003)(2616005)(6486002)(107886003)(6506007)(26005)(6666004)(6512007)(31696002)(86362001)(2906002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXFiekFaQUZPODN5V0MrNXBRRm1xdWIwSmVhdjQ4UERSUkYvM3hKQXNYTUYz?= =?utf-8?B?akJ3bldTOFZKWENLQnUrUDZUQ2FQV1YxandJNXNhaXRiSVBwcE9wRlJsaFVT?= =?utf-8?B?T3Y0cjBFRmxNQytRdytHYTBidEZFVGQyaFRvREI3eGFRU1p0NzFXcXlVeU5t?= =?utf-8?B?U3RvMXE0aHNMSTdkZXIwaHp6NEdZOU9iSXYxNldWVWNaTXRXYUdnZ2NNejlD?= =?utf-8?B?Rys5WW5TMWZiVHpvMFRFdG8wM0txTU5QYmNiU1k1L1kvOFg4WXA4cm5hWC9D?= =?utf-8?B?c2k4U1NDS3JMTFZwSWFkaW1PTHJ1MnIyRVFEZFdjYWowRXJsUFltWmNaRWZy?= =?utf-8?B?cElvQ1E4UVZjSmZCZE15ekZEOGk0MFlIMko0MkQ3SGR1YktwZDM2QWh6ZFZE?= =?utf-8?B?TFg3anJTTlRtcXZqWGdFb1FxRXpJSWIvUGRnVHl5VjlGWm1RaGRLMEYxaEth?= =?utf-8?B?OExoWEdoTGluQWlPQy9ESFAzdHMweUZtL01XaWtCdllQdzAydC9idE9VVjVU?= =?utf-8?B?ZVZUYmdrMXFHd2NNSnU1UUp6dURZczhDYVR4NCtRbllMcmNyak82QmkrcVFE?= =?utf-8?B?QkxSeEcycGVWWUVTb0pzN2dDQW1EVjExV3ZneHhoaXlUaE80UkdRUmN6Z1Fj?= =?utf-8?B?bGs5bCtXb05jZXB0UjRsTS9HN0hHaWFqV2dnR2RoaDJtTEtPc3RRRlRMUzFh?= =?utf-8?B?WFB1L0JISDg3djlreDlYTkhuQmpRR1gvR1NIR3duaUNBTGk2MHorSjVJK3Qx?= =?utf-8?B?elVYWmZyOU9ySmJvbTJOTU9SMFF2ekJBb3BOdnk5TnVOQ1MvYlBFTzV5WHBO?= =?utf-8?B?WTBEKytab2RaQ1U2UHdES1Rad0ZRUE5LQzdReXJURmdaakU3V3BlZDBOUW9x?= =?utf-8?B?NjVSYTJPcjVVUzIzRGVLN3IvM2ZmVk9QOXhrTXU2cXFZU2luNmhhNzRLWkZY?= =?utf-8?B?SXZiSEcyblk1RmR4N2lDN2Vzd3NzSWg5UXNQMGFFZjBYdFlIR0xIejdYOEZD?= =?utf-8?B?Q0VXQkY5dXFpQ3o2THhsQk1PdjYxay9raW9pZkgvMEkvcXVVdDlYUXRQdVk5?= =?utf-8?B?bWpWSit3K0FUSS81UUwwclhVOXN2QmFZSzl5anJyQittNWNmejNqY1A5ODdP?= =?utf-8?B?VHNnd0F1OGhHUDdJVmNjeTN3STV1RUJObS9uVTd3Y0IxdTRXaDlVVW5aTEVP?= =?utf-8?B?K3ZHWmxVTVAzVWw3NDNXeDR2cWhoNlV6akJGRUZXMUhYK3ZHSlhNajJjSFRu?= =?utf-8?B?WWs2ZUg5K2k1T2tJUXhWZjRhQnhLVUdrczRMbDBPUXUrM29ac203dHppODdH?= =?utf-8?B?NzFaeG5zZE83YWJGVFprRW55NmxWZkxpU200VzlMeTRJU2dTVU1rVitHWEtq?= =?utf-8?B?RFhuRVllL3VpN0tyUW5VZ2pKQkhOWnRGRFVMNzhzWFBMaVJGVnlud3hUOFBv?= =?utf-8?B?bkV6NE5wRzh5ODB2VDdsaDRGaS9Cc1NRSWpncTFSNjRXbGpkcDN2ZjA3eDdE?= =?utf-8?B?b3lQbU1DaDVJcW9iUXNVWWRVK21WcXFOY3k4c3JXeWJDcTh6WjlrTFo0ei9V?= =?utf-8?B?cnRYZkRhbGlXWVF5UWo2N1ZLeU5Zdjl3VHFZQmtOanIxVUlUcm93VGZoV0pu?= =?utf-8?B?Qm5pRkQ4Y21pZURSRnVSOGpoV0FJWC9ORno2Q2N2ZExEbFZ5SmhHdmJmcDhS?= =?utf-8?B?OXhVNGtRK0FJdjlROHNNT2U1NGM5TUhEVnFuYjRja1VKdG53dHNlQWFWRmdl?= =?utf-8?B?ODRVMHRRNC9WUllGTXNDOERrczFhL2R2TG05MG9RQWNISnBIQXlOcHpleSs2?= =?utf-8?B?MG1FT2tveUo4N3hGd2VKTnpya0h0Q0h0ZjJpTDZmdUk0THdLdVVaZmFrNkt2?= =?utf-8?B?MnRjajJMUTFLcWtybHFDeTdMQjI5MExuaHozWFpKbk5oZFgrUjVqOU1yWDNh?= =?utf-8?B?UGFheUhhRzRTd2JEQUQyZ0MvODN1VlJEZlhWeXA4eUVhQ0tNTmJkL2hJdldX?= =?utf-8?B?MUZZUm9EbUZ6UUV2Y2hYQ3BkTGNEaGVwVk1Qbytlc3FQZHY4ZnM0cXV0bzJi?= =?utf-8?B?WloyTXRhU2hESFY0Ym9yamtSUGN0NGdOeGpoc1gvYlV2bGJiNGpKQndOTWg1?= =?utf-8?B?QUp2Q1Nwc1ZoYUp1d2UweXY0bVlPSDZtdWMvY3pYeTJoSkFreU9qWi9UbE9T?= =?utf-8?B?UHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DtvDwWUnzh8p0g8U4acjxSarlHAKL1LmnfeIYrFJkZjzB8/edXsHQ+9AkmBE2PS361g+tmBLNOCvUV+qY4747ckBgc1GQ+1Y8X12cwpU4BK6VzQk10IdZd3Kl/JOEqXmkcdmeyIBj8cm/gIacH293PKab+NZ3w5Q8rqjT2I1GNaBPl6ge8FKTRoWG61nI1jfLn1peaRJ/ZHci5GxbiqV+ZPUZkkW2mcPZ3eaB56kDjExebM4TLK929fzY+AmUe4+y8JHhJAz/Nh//gsV2OOZgZ3xfq7cjNN/MvYZpQEaqcjzz2bI3qI6fm5WlOoiE4Fa7YcJsIl/EFMYDk5pUt80txRWTuVphFpzYk0ro8JgjbTT8rD/v6MAjErRIiEgOXpQASpjAQn3fTFWKpS+4iQmemUPDq1N3EDxuVple00KzIdkihPBIkVEPRpuQdZrZtzlWpnjW0XalV3y2bIuI1NTBQWEexSzP6zuuUsqjTZq9nwo3GB6kFQpfY9nq4OV/1E6trUQNTWXvln7v4JBPOjosiUk+OoNtmo5VZX8/jWbbii01tpSiWkXYVyr7jWwq6Y8hCmoZwWGuN7gEAj/jL6+Y6yy7KxBOSGIVdMWE1Wrxj0Sk9CErp1YGNj8dZFoLqzBELfsu2LM/UNAS7UgxNYkNnK2URXKbkuoX5SmkuCms8zo41oDCax2tMH7XtHPwso1Flk/Qo/VvEz7FZlu3j+yZ1jqO2bEkmei6uxPiCfWeUlFKpEifMFEDvTQK82DfeTSqCuAFijx6R8/2GNZea5+pvCPyzw9bVzTdgo6c5LvmVzgMfyGzXHPa5OylrRl5AtC X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1c643b-51aa-48a1-eba7-08db36d51fdb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 19:28:39.6531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ZcVm6bR9aqFiNuhK1cwmyI3C/tnUCI6hyAXhgoU8/wtiV+wFHd0UTyrpl1D0xLCvZF68PnzH7CJNOHX8d6C/b9DbxS2YHvRc7x3KlAgkTs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB7201 On 04/04/2023 3:52 pm, Jan Beulich wrote: > Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() > now wants to construct and invoke a stub, make stub_exn available to it > via a new field in the emulator state structure. IMO, patch 5 should be re-ordered with this, because it removes one incidental change that's not really related to CMPccXADD. > > Signed-off-by: Jan Beulich > --- > # SDE: -grr or -srf The ISE makes a point of noting that CMPccXADD is implicitly locked, like XCHG.  (Unlike XCHG, there isn't a valid reg/reg encoding.) Right now, the xchg emulation overrides lock_prefix, but I have a feeling that's stale now with the rmw() hook in place.  But it is dubious that we let xchg fall back to a non-atomic exchange if the rmw() hook is missing. Either way, I think it would be nice to clean that up so we don't have differences in the handling of instructions which the ISE at least claims are similar. Tangentially, what about the RAO instructions? > --- a/tools/tests/x86_emulator/x86-emulate.h > +++ b/tools/tests/x86_emulator/x86-emulate.h > @@ -934,6 +935,8 @@ decode_0f38(struct x86_emulate_state *s, > ctxt->opcode |= MASK_INSR(s->vex.pfx, X86EMUL_OPC_PFX_MASK); > break; > > + case X86EMUL_OPC_VEX_66(0, 0xe0) > + ... X86EMUL_OPC_VEX_66(0, 0xef): /* cmpxadd */ I know the style is a little mixed in the emulator, but +    case X86EMUL_OPC_VEX_66(0, 0xe0) ... +         X86EMUL_OPC_VEX_66(0, 0xef): /* cmpxadd */ is more consistent with Xen style (because it's somewhat of a binary operator), and more readable IMO. > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -278,6 +278,7 @@ XEN_CPUFEATURE(SSBD, 9*32+31) / > /* Intel-defined CPU features, CPUID level 0x00000007:1.eax, word 10 */ > XEN_CPUFEATURE(AVX_VNNI, 10*32+ 4) /*A AVX-VNNI Instructions */ > XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ > +XEN_CPUFEATURE(CMPCCXADD, 10*32+ 7) /*A CMPccXADD Instructions */ Given the non-triviality of this instruction, I'd prefer to keep this "a" until we've tried it on real hardware. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 19:47:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 19:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518975.806069 (Exim 4.92) (envelope-from ) id 1pkVaA-0004o8-0T; Thu, 06 Apr 2023 19:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518975.806069; Thu, 06 Apr 2023 19:47:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVa9-0004o1-Tu; Thu, 06 Apr 2023 19:47:41 +0000 Received: by outflank-mailman (input) for mailman id 518975; Thu, 06 Apr 2023 19:47:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVa8-0004nr-BQ; Thu, 06 Apr 2023 19:47:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVa8-0004gb-9f; Thu, 06 Apr 2023 19:47:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVa7-0004tS-OI; Thu, 06 Apr 2023 19:47:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkVa7-0001TB-Nj; Thu, 06 Apr 2023 19:47:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ucmgWi8SVyA0sLbQW0FoX6ajpEg7W7Vw8VzJOfak8H8=; b=xqKprWov63qy/EOCVGDYUHeKCS dcsqThfbhdgMFCD8atRjCuL+QRYRD5yIqEejvip66hcPtHWI/HkddFPtregVj79tz+sehdiDlmOH5 DLJ3R7GmJKd0TgQXm7IA3ClxjayM8K89Lt73OhTuRoWGY2XYUwLOtKpA1IEocRWyDD8I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180163: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=881ba20eb0222305a9d2cd090c9345992794f4f5 X-Osstest-Versions-That: xen=415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 From: osstest service owner Date: Thu, 06 Apr 2023 19:47:39 +0000 flight 180163 xen-unstable real [real] flight 180170 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180163/ http://logs.test-lab.xenproject.org/osstest/logs/180170/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 180170-retest test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 180170-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 180170 like 180148 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180148 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180148 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180148 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180148 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180148 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180148 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180148 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180148 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 881ba20eb0222305a9d2cd090c9345992794f4f5 baseline version: xen 415f7d9404171cbc968b1ea22e7d3523ac2f3fc1 Last test of basis 180148 2023-04-05 06:43:52 Z 1 days Testing same since 180163 2023-04-05 23:38:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 415f7d9404..881ba20eb0 881ba20eb0222305a9d2cd090c9345992794f4f5 -> master From xen-devel-bounces@lists.xenproject.org Thu Apr 06 19:48:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 19:48:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518980.806080 (Exim 4.92) (envelope-from ) id 1pkVas-0005Jn-95; Thu, 06 Apr 2023 19:48:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518980.806080; Thu, 06 Apr 2023 19:48:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVas-0005Jg-6H; Thu, 06 Apr 2023 19:48:26 +0000 Received: by outflank-mailman (input) for mailman id 518980; Thu, 06 Apr 2023 19:48:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkVaq-0005FB-S3 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 19:48:25 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb7a61de-d4b3-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 21:48:22 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 15:48:15 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6538.namprd03.prod.outlook.com (2603:10b6:303:125::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Thu, 6 Apr 2023 19:48:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 19:48:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb7a61de-d4b3-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680810502; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZsgUh6XwYy3/O+QPZr6A1ROCkyOu39sZ4l5RK4WQIxo=; b=AiO7DCZRpyKSs+MobuHBjH/sk+kK3DRzxSljw0g0e3sovTyikkG0zQVY RH6u971T/aduMzP4uxyTJ2KE3y6v92P4RHKQ/cMBRwVnUyh7NMmnHDRfd iP3580TUXzW3Ni/9AS2NGBUr9zhuM7I2ENzCpIF+7UkxXJh0984TmsnAQ 4=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 107043711 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:TVgu76LzxG358h7QFE+R/JQlxSXFcZb7ZxGr2PjKsXjdYENS0zxWm DBOW2nTb/iON2L1L94lbYywoUwF78PQzdYwTQNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRgPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c57J38J0 fEUBgoMbw3bueG7muu7dPNF05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMkWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHukAN5JS+ThnhJsqGy82nQTI0wEb0X4nbqS23SXdItgD 0NBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqYCYFSU4J5oflqYRq1BbXFI88Teiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:Fds+w6B9Xe5H1orlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="107043711" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDONPtyNiTo2z+kchG9QvxNMhUbPl0UmtYYbH/vg68b+gZE3I0gc4pSO+DRcKP1dsCyfxnZYY+8yKrVKJhIqIPh/d4xOzJfqRvGXa5Cmjpn6JNDXo0FIvLGhq2e9vuGY+A4s2PEwFX4Bx5YoAy+x1y9d+iATTPrc3x/NvV5y0PP+vR/8nhVqcEK3sSlsP39ALlyVq2IDA/dNnX4CCKRC2B/dod/pR5K+zE2tfcSfbKtHVf2ciXYCtfTR/c08H+2ElCwtBvNcWipFuOnmTLXGYAdOyAXmixsBrVBg60IsQm7ADD9uh6VB8UHZ8GdybzQwCIQqwHYFGDiXH/3lOmfJZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9GEv/vHHfWSr/9qukhjnK/VmYsC3r4UDh5/C75enRlo=; b=AHzJ+FkOcUMSbYkBqU+mcmYxfcHXZRt1/NAV6XGW1C+YLjJB8YJvmjIJeUzTwIiD6n8RCLFhPYAE9xWnxCnP7A7hoYZ1aPVNupCVgm2wfOJmkYcRvHPDSZfyV/V2brSejNL9q90jFbliIQ3vTP2ioI6qyuhOd8Zysfw4x2SWydBlN/o5VmGnbImXxEDSEI7+9sROrr1jEoHUOdc3dq6IvIsDxy2P54jF7zVLhHH8iPd+9WjJYd8EwC3grWiql3pg5uxtUWPYwo73bjbrL1TfUie/dbYSdLq+SXGg3z2tXFBOFg7pcIVPUftPYZhGL1J59dTWbU35k6ODgcYbE3dncA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9GEv/vHHfWSr/9qukhjnK/VmYsC3r4UDh5/C75enRlo=; b=waSE8FxTuVgbjy55rwI/7O2/2xhxrDw9U7e1OFIAN6xnsTBnVXndoUCCFELqLakun05gF9CBD0qITJ9CFGzFnScl7Q0DkP9SJ2mvWkdOp8DdjKMMvj945k5Ic/N7tGVdyutBhvaS/zt5rD/mCclnfd2BK7RDFfhbLVYMwN8H5ro= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <197c2d8a-0a41-da10-771a-87843c9a007d@citrix.com> Date: Thu, 6 Apr 2023 20:48:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 5/9] x86emul: re-use new stub_exn field in state structure Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP123CA0007.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW4PR03MB6538:EE_ X-MS-Office365-Filtering-Correlation-Id: 79c16495-7673-4a48-76c0-08db36d7db55 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YVHMiDGuZVD1vrEMbauouKPVHRpBTNtmtjLmj+FdJr9sLf/zTKuhCzP1nK2mll5+mmSsvcjSNV1Z4B/MU0ebPZ8BRY+Cp2PQnL3gEG2Fg/TR0igX724Kcmq7dScEyMf/W4Q5sLHjTGiY2SPT+Kz4SKk7w9TogN/wkBvfel5rEIUKpFfVkbd15/hIgQ/7FyDr94lVuBDCMGGRSwRClTwxcfTlal6VyV+c36fBvFfBJX8gDU1uSPek1rVL30NXBB96Hga6BpAa7BL7zpadshx6n3T2zTSq99XIfegQAnK5Ovnw74uWlxSxcj7uZqDKU3VZzSyIoc8c4+oMT0knPIqyn1H+Al3BrWFeFml+Ugl0NhVSo7kjtxqTxbzwcXncINiBWB1IIT/EW/l2wSAkgPcgWkE3ZMyceAoYfs2oQhlOfErq2XvczgPokqDD3KxLpjBYGR2JiyyZyZ6Uv42vh4eUNnoYSeCzYj891+EsXKVoRVPXJLpQRmosTTh2k1DTfawW2Rh17YuD3GWxA68kp1lbBAC6xnmeraTZu7JFra0wpJY4s5p+TDJ370oNq+Svg3+jrwpt2XoluRQiKkTy/WE1Mpg6pFMirzLCicDrZtLeNZuzNdlUSj27llkxiTABNwNP+/+7QHAgEz0CWUARk0pUdg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(366004)(39860400002)(376002)(136003)(451199021)(31696002)(2906002)(36756003)(8936002)(31686004)(86362001)(2616005)(83380400001)(107886003)(53546011)(186003)(6666004)(6512007)(478600001)(6506007)(26005)(6486002)(66476007)(66556008)(8676002)(54906003)(4326008)(66946007)(5660300002)(41300700001)(38100700002)(316002)(82960400001)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDVFUDJ0aU9lOVl5ZzVsdFhpeC9YTkZLMWlFZUl3NVJaZUxsYnJpSU45T3VG?= =?utf-8?B?Z3pDa29XbDNSRmQ4b3FPQzZYZy9hMFUrZTVlaWVEY1FxcDdhRFkwdmIwK0VL?= =?utf-8?B?VXc2ZVY2ZFJORVYxa1grcU1YcWlsaGdXVjFHQnBRUW5KMHdieU15eFlHM2dD?= =?utf-8?B?S0REYWoxRkNEeUN1c2d3L1Rjbis2OFNBR2g0cG1iTnEyVUtKUStCb3lkV2cr?= =?utf-8?B?NGE3OC9mc0xreVZyTDZUZjdTSHNkeERGV2JYWnlzbjNST2xaN2hSQWNMa00w?= =?utf-8?B?Z1VqajlrMVlzOWZZcmEwd3lIcHVFZzcycUhPNGJBYXJSYnVRenlxdExUbzJQ?= =?utf-8?B?V1dQY1FsdmZZN0EzZHhVa21yV1pQWVBKWkl2bUJ5cDdhOUkvUGFEZGZmTjFJ?= =?utf-8?B?Sjlra0N0OExWeGhaQ1Y2Nmp3YmZaOVhTM0RsMXJjUmxDN09vYzVvdFpreDZK?= =?utf-8?B?dXJNckpMbVJweXJHZFlUQ3V6VlNoc1kyNzJGTUhHMXE2OHd2bzcvUUU4OEJ0?= =?utf-8?B?cUtuUUs4WEF4TVJyS3h6eXhTYld2SE9EMlFTUDdRb3JkbVpTdS8wV0IxbjV6?= =?utf-8?B?NUduYllSR1ltckllVGJrWW9MU0RaZ3IwdXZTZ3NPWWhqaDZMdjV3ZjY5MG9J?= =?utf-8?B?bDNaY0lnV0lnOVk4YU1iTENwcjdzR2dCOEJMSm03Q20xM3VYckR3cjdkZ3dV?= =?utf-8?B?Q005a2N4R0w4cDc0azRtNWVOYXMxV3NxRXUvRlZNM1JkS1FsbVB3Z2JEa2pF?= =?utf-8?B?NTM2dUtIaFRPL1RCZG5kWVZvMXZBcGZOdVYyTWpITUJubElGQXlFVkpIYXVm?= =?utf-8?B?MWRzTmlxTEhtLzZlc3pSbjlCV04rSmhlRllxYlZRTjdrd0xiSlJZNmxHU1k4?= =?utf-8?B?RFFXWHhIMGxveFh1bkMwNUJFVWhWSUJBS1JoNCtoWnQwMlM3ODJIMHlvbzZW?= =?utf-8?B?a0hsa3lIbkFkMkxPSFhrUWFxSWV3SzdnU0ZUQVBYTU1EWlRZekZPTzV6MjE5?= =?utf-8?B?MWFqb3kwTldxMUtFZm5mRGV0MmFiaWtzVTE4NDVydVN0RVgzSmxCOHAwWXFH?= =?utf-8?B?YVBaNkpJSWtlTWllK012U2Yrd0piWDdKcGQ0ZEJ1dUIxaEtYaFRLa3k5Rzhl?= =?utf-8?B?NTJQKzNwUVRqdXI5NDJYYnZuZjNadWFqTXBIam41VU5TZFFRSjhBS3lyRFNy?= =?utf-8?B?NmYwRkJXcFBhYmowU0FKM3ZicFJwMG1CcTJBRkVlYXdNUGhQUXBudThYMHpy?= =?utf-8?B?MGtKN3pFbjcvNjh5c252SlBHSDQvR3NHTjEzYVBqRjNEbVFuQ0JMVVVTaW1O?= =?utf-8?B?MlE4bWJTb2xGenBPNmhPZ0tSaXBYeUEwNldNcmswZ2FKUUdHRzQ4M1p1SFNw?= =?utf-8?B?Wk55d0dMMzJyam9MdUdVZ0kydk00Z24zUGZ1MWFBTUFTYjF6bUFUbEl1aFdK?= =?utf-8?B?Tm1oM05XazdpOG4rRFlSeTVCVGN1OXRFU2NIYm9lWEpCK3NyT3N1S1BWZGZX?= =?utf-8?B?YlpBc0ptQ0ZaRFV6Rm1hc1VXaHJnRVVsa3hBSzFrOVMvT1BhWkhTa0tlU3FX?= =?utf-8?B?RGtBYkxiVXVGM3RhL0NHR000c0QyWEFnb3ZHUTg1RlZwSG5vWWtjNmtMNStL?= =?utf-8?B?K2xGUHBLL3NlUzZvdTkzMExsL3NOVlM3VHlyQXdUSmdwSk0yeXdSRnp6Tkl4?= =?utf-8?B?YXMwa3cycVBDUERCeWlLOUtiQ3FLWEpzRFVzMVJZY0J0ZGtLV3NJeVBLYlEy?= =?utf-8?B?K1ZnMU52b1o5TGlHWnF3NFJndkZ2OXpkRWZGZXZPd050aktOVmRJRnJxOXBa?= =?utf-8?B?K3Z3VnVlTG1jZ3JmU3JUN25Da05uczRKVnlTU2F2eGJSK2ZVQWhGQ1VlVVcr?= =?utf-8?B?TjZ6NytGemFkNjNLMEg4Zlh4M3JwWGo2d29PdWlMOThuT3NZcW0yMXhlVGYr?= =?utf-8?B?NTVOTkNHY3plMjg1SENVTmMrZ3dMMlBjRHRnUU41S3RkM0Z0RzlHdm4zUTRy?= =?utf-8?B?MnFXRGlyT1YrVVlyWk00Um9IOFBlMWFpS0ZxNXZKQkhPTEkyMlFYdzhnVGlI?= =?utf-8?B?NnFaOTJZSkNjazlCUWkxbGQwM2kyb0UyVSsvcUFKbmI1YzI4TjAyYXFCZ3Zw?= =?utf-8?B?SHlVWm1kdlJ2MmROUzdFTnhQQmlmaGtVRG1nbFJPM0pKUUJqdkhlMUYyWDRE?= =?utf-8?B?RlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hR3JTT/yTDt5+8/LfHBqMSLOrJjfWa2guvNHPLjfWRrjm2xWd6dFMUO9D+FU4efC1pJk6u7w0QpDBxJUsA6q0hzIe8+j31uVPtDCmjSotVnF9WDEWUpp6HS+BNEgXlufM6NqAs2Y79lTJhtfTrVMKOrwbDEQM2cn7RAfrQZMLklOWWWK3YsogP4mWcOYrIYIwafRLdxDeF6X2fcMqAVzzo61hu25iguHfLTRjk+rUG9VTQArBU9DD2TxOt845vAP96nXhEEx69mIJxDNmvUibpDjbFCRkkNK0inlVf6xlhioomaA7rYPcH6FPkL0w9KfRQZP/2ZCt1m8Gq0vTMfQRhSWOo9JZdO8JYFG/dzEZ+yiN77P2GFs0BCuhoHY8l+d72/Hz3JD0o5GQClFn6NHvRDU9nDF81OemS9u7qEO4/r2p4vU/27khatmTp3+hVG49wfTsK7Q+B34Fmj2YB+mAa1vODIwK97jP6oELH0qmoK1daNt1dzUC9D2ivztEyiR22/skBiP2h9rZClbWe+cCiFcReIaoFqF+Qfb5yNjHeeELIdhH1gRpdbGv9PZyY8zdnO+VpZ6eygyNOMblN4+JiRe/FKgQGNOqBFBw2LQmkk57JsC6aIcjDgAVPOMQKJVI2t3f4FOk2nwM154QyC9E+dDVhbDjFLyY16er2Yvyh+MMsN2guCmZ3IQ1WwmtyPiNW7PwqhW7cWUhZknWtyajdWFcuJCGC21FgLNqdejXu22cP0Y0FCwe6Xs2NAvjqlzfCKjB8UsjzOK3luwO49wRM/fGMIQrKqr/D5i1TOKRW+qk1a2BCvu46bmmrl1j51x X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79c16495-7673-4a48-76c0-08db36d7db55 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 19:48:13.2632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G3Phhn+rxFjj28TsgIhIyq3U3yNqZTj0ElLXBIByn1Zdw47Ri3cTGuc4RbNLqPWXuiMDqINSYnDXatB3VcR7Gt56TqsibGOYuucpHWhCWWs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6538 On 04/04/2023 3:53 pm, Jan Beulich wrote: > This can now also be used to reduce the number of parameters > x86emul_fpu() needs to take. > > Signed-off-by: Jan Beulich As said in the previous patch, I think this patch wants reordering forwards and picking up the addition into state. "Because we're going to need it in another hook, and it simplifies an existing one" is a perfectly fine justification in isolation. With that done, Acked-by: Andrew Cooper , although... > --- > We could of course set the struct field once early in x86_emulate(), but > for now I think we're better off leaving it as NULL where not actually > needed. Do we gain anything useful from not doing it once?  it's certainly more to remember, and more code overall, to assign when needed. > > --- a/xen/arch/x86/x86_emulate/fpu.c > +++ b/xen/arch/x86/x86_emulate/fpu.c > @@ -90,9 +90,8 @@ int x86emul_fpu(struct x86_emulate_state > unsigned int *insn_bytes, > enum x86_emulate_fpu_type *fpu_type, > #define fpu_type (*fpu_type) /* for get_fpu() */ > - struct stub_exn *stub_exn, > -#define stub_exn (*stub_exn) /* for invoke_stub() */ > mmval_t *mmvalp) > +#define stub_exn (*s->stub_exn) /* for invoke_stub() */ ... honestly, I'd really like to see these macros purged. I know the general style was done like this to avoid code churn, but hiding indirection is a very rude thing to do, and none of these are usefully shortening the expressions they replace. Also, putting stub_exn in the K&R type space is still weird to read. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 20:52:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 20:52:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518986.806090 (Exim 4.92) (envelope-from ) id 1pkWaW-0004K9-3T; Thu, 06 Apr 2023 20:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518986.806090; Thu, 06 Apr 2023 20:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWaW-0004K2-0e; Thu, 06 Apr 2023 20:52:08 +0000 Received: by outflank-mailman (input) for mailman id 518986; Thu, 06 Apr 2023 20:52:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWaV-0004Jw-6Q for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 20:52:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e001f678-d4bc-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 22:52:02 +0200 (CEST) Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 16:51:55 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5053.namprd03.prod.outlook.com (2603:10b6:208:1a8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Thu, 6 Apr 2023 20:51:53 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 20:51:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e001f678-d4bc-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680814322; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=FPJjCitQs70LnEKKEsJ07wEP56wcTZf3B05zZyNf+DM=; b=PRdwNKXLGVHxd0QvCWgkp1fChjhs4sFshEK9QCArP9BHmFHqB608RYtl oCBCupDVpDVg3yN2UyBAZjAR8DaBE3krakFyKtS7iw5qXcwtjVcaNjFJw 2+7iJBxY1ryzh3RkyPwaIm1trlVUH0MQ7z1n7HGjLgrebLLCX1wPo64cA Y=; X-IronPort-RemoteIP: 104.47.55.175 X-IronPort-MID: 107049219 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3MCJsa84GCDTWonvbsDoDrUDrX+TJUtcMsCJ2f8bNWPcYEJGY0x3z jMYW23QbPyLZTf3e49wO4m//RhX6pDRn9AxQQRrqSE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmOagV5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklx+ eMDchU3MCnThrma4OqRWMpIg+MKeZyD0IM34hmMzBn/JNN/G9XpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUujdABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpNTOHprKc76LGV7nIKDiYMdgWWm9WWlVO8VO1aO mIS/iV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zpptE1hxeWFNJ7Svfq05vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:hwlrHKk2S1eFfl2Fw2rKfaGzNibpDfLZ3DAbv31ZSRFFG/FwWf re5sjzpiWE8Ar5P0tQ6OxoWZPwP080kKQb3WB/B8bHYOCLghrVEGgm1/qc/9SiIVyKygc/79 YGT0EdMqyUMbEgt7eJ3ODQKb9Jq7PrnNHLuQ6d9QYRcegAUdAY0+4WMHfhLqQ7fnghOXP7Lv uhDwh8yQZItU52Uu2LQl0MX+3CoNOOsZL9fHc9dmoaAcC1/FCVAabBYmulNwklIkNy/Ys= X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="107049219" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f91vVwNxGoT3FOtshY/F4R5J0ZmMP5M8zphZ12SG301cyQlMxmLFEiZtIqSugUvafpiq7CvFOtIK7s0oATcCu+QlI+pfUgKMTyqEcR1yHo2ry5zU/emZVEU0GP4iIdrBhxcZoFQUycahNrvuQoDLWzTLj5M7F5WTNzt+AxWtCowgsSqlBeP/T8Obk4U8SbykqmfZIkWexQN/TYKsUSqOSKlVk30VZgU0uAXI0978UBWuUG0iFJrUtDYfZGsXsq+eUdmhGAoMGfHlyipc6nFF5DjZWbSFeJzDO6A6POIqTvrcYLws6df0eNbGccJvlioisKMlRIC9kEaD1bcMtW4K2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FPJjCitQs70LnEKKEsJ07wEP56wcTZf3B05zZyNf+DM=; b=OqbKzQvRYmD73rOsp8gv00Uy5C9G1nKVFDjCGNO7JF37rRDByttpDW0rFZDFpNNUA7b6dYJ/gtVJvesuUko+DOX8O4tFXRChkc9imxw17BlFvvfSvuy2gmTeoCcq+SHJl4Y+18gPDwO1VQr2hy49at/OgmD0a4+z+5NHR7es6NzDao/FO3YmXobu+UZVVictnH/d/yYmzzKx1BUI7hql5nZgxucPpuXltgcBhR8U5geVXhtkq3TIJWK9P+sxUF7NpEfwX3lcxz537DiiyQwRu5E97p7s1P0iF9D2QXfD024nXNUJjcWV6s7KoLClsQkhJKAEJYA8G2z234YwMX/nnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FPJjCitQs70LnEKKEsJ07wEP56wcTZf3B05zZyNf+DM=; b=gF05FE1j0VhAHCN77dNSVGP8+NaJI4q+ioq3CxSxN7ZRmUSWXrn14HL1dPZqJlF3vNiB/JUJtFdU68T9ifqMK5z293AdYYNUrceWAR6h2eZWmR8h1dse0Rg577qR1V/V7nkX8EGEB8sz0QlAWSCoD2SLOWBnotAmFXlfH7acncU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0c94594e-2eb9-b94f-11a2-1c7cb937534b@citrix.com> Date: Thu, 6 Apr 2023 21:51:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 6/9] x86emul: support AVX-IFMA insns Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0203.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5053:EE_ X-MS-Office365-Filtering-Correlation-Id: f81b2d59-eaa7-40cb-ea10-08db36e0bff8 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S3WgowojS6ZA+a2EP/6xqud4B+A++/lONxzJd+dYVcG5+6fHQYOsGY0RY5mfagdDQlWYH2lnhJXUHxxFCjV3+QJ+G5Bm8p7VAHa0Hrwy/iPTM3K1PdzYXiUGJnBiqKq1keiRW1P6ReKNyKln6UR/gJzWiRj97i1sIfemg0OVPnpChr1vDayLiBWfLI3B+A1S6HhyLsL61fJp0hQTKOzMvwBqaOKXHFuR6bBrQd0Ge+KbVQiifPelsp9skMi0aTtvwt+bEqK5ynx2fAK2UA7oXSI3cmFl77wHFYw2636SWu/xvZRDeTirJ3moLoYrYcjFg+c/UN4cUFrE5ryZEZMs/u1d9yMBOTwIaX2WBD1uenVCkoRWoV0viHtbZzjHrosqZg343rgEYpE1+lkj7bBt/2qP+o7TlQX4UbnPcDX6FzjH78XLQxQjk4bHZtTl231+mgh9SfHclXZAkKLUTt8EpPhUOuvvq0bjxPGePLMwkPpE0aaikacLvB+7puz1scRommMP7UTYBTCPQCWyjtV5IZrO55HyfW2wIQtkFtOR295Ch8Rxel4I/1CjNpN99/rryN9lGpuJxPmMUU4Zc8B0cD5aKonQF1dFBd2M6VzGlZPNmPTRspylmtszoA1ZbfcXMECuiVtnqWUFHXrptVGyqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199021)(31686004)(4326008)(41300700001)(38100700002)(36756003)(4744005)(66946007)(66556008)(8936002)(66476007)(86362001)(8676002)(31696002)(82960400001)(5660300002)(2616005)(2906002)(6512007)(110136005)(6486002)(186003)(83380400001)(6666004)(107886003)(6506007)(26005)(53546011)(478600001)(54906003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck0rckw0THFsSVdDZ0pjQXdsM1lkTEdXVms0LzVOblBGQkNDTmhaS1NFOGM5?= =?utf-8?B?Mmo4YjZudElPVVFMUXNKdDFGQ0hpWlFqMlo5QnFyMFZHdG1heWlGM0dHQjdV?= =?utf-8?B?d21oQk1zWkcwa3ZPL2xwcTBaeUtrWFMwQUpRdjRna2FIUjRYK1BOcGRpS2lP?= =?utf-8?B?eHV1RXhoOG04c29ZWUM0akpMRjMxbTBocTduSUpscHJHdGgrL2pwRGRLSzgr?= =?utf-8?B?SHN4Z1gzSy9Cc1VCbzlmajJvUm91ak00ZXBKbDgxSjNqZXpnb0QxbDRocndl?= =?utf-8?B?MDBwUnVORm1Ba1N2Z1lRTkVBaWJxamJ3ZytmTWtkOE5EOW9uVVJHZ0lqOUZY?= =?utf-8?B?VzhZSE1TMDdlVTNXeW8vWTZ6cTNoakQ2bi9nUzdnWURlMDF1clUvdllQOHNL?= =?utf-8?B?Qko3eDhpUlF1MWhYQkw0MHA3TWFMR2pIVmp1TWx0L2thNitzb1FHS2wrWUw0?= =?utf-8?B?NVZ5UzYzMXBOTEljWE1iUFJqWGg0OXVYT0FHNlZvb2U5dmJ0UUhZQzZrRDdh?= =?utf-8?B?c0ZDRTFXRVN5emtkMEszbGFTMU1KSkVpeisxd0hPc0pFY01vd0J1eC9Ld05G?= =?utf-8?B?TGo5UzBqRVd3QzBYdU5IQmw2MnBHTWJJaGxCOHVGalFBWDluM3NlOHh4aWRY?= =?utf-8?B?Rlp3bWtmem54b05HVTFldVYvdjJCSlFrQVlkTjg4dnBDMUxUcm5sU1FOcjdM?= =?utf-8?B?bW9udG1GeVl2RGZITFZxV2ttYitxdE85cHBCSEkrck85NzNUdzBRYmJtZFR5?= =?utf-8?B?S0FIeWROQVZkcTgwaVFiYWh1bU5USk9uMnFzVjY2VjR3QXBReGxzdnlEN1BG?= =?utf-8?B?NWtOSXVpZjExdnUrZTBUWU9pbUxqVnV1dS9BNFBpUi9WdzRTcmtzd3E2Sm5y?= =?utf-8?B?SWoxS0Y4bDJDSXhWaDlYSUEyWmFRWGVvMnd6R3dBbkV0Nmk2bEIyMFB3enJX?= =?utf-8?B?Zks0YmdYaGMyL0NWOTZlRVBhdHlvWkFqZlNCU0VKNlpZeWVoRUxPWWkyaCtz?= =?utf-8?B?Y0l2aFI5S1hpSUFvSzRTdVN6U1ErYjcwVXJmOVJIV1FScUNiZXlXMXFQeW1M?= =?utf-8?B?NmZ4TU0rSlZiL0hJOVY1ZjR3SVQ4TEZKTUp3bFVTZ1F1RVFka3R5RzNtUGZW?= =?utf-8?B?THRRZ2ZRcUw1ZGhsOWdqaWJiaitjZTdsaWNidmtpNkxHZHRFL2Y2ZkxWalhx?= =?utf-8?B?c0dxL28xMFNvZ3RwbGJUSDJtZGIxR0l6ZzZyUHhsdGd2WVpKMStwY3JtLzlF?= =?utf-8?B?M1lyaUZzTTJSTUNkS0krd1ppNWV5SXJROXJMQ0IyRFUwWE5aMkF1REpIUTQ5?= =?utf-8?B?NmYrK0ZPUW5DcnE1NlFWMkg3RE5oTDN1T1hadXJFdHpJVFJxbWh2cDh1NHBx?= =?utf-8?B?amJCcTI4RTViekZwRXBubWJHVFBPUjFZU29TY1ZsNll3THFXdm9lYUloVDRJ?= =?utf-8?B?eFV1THZCandsdm9laXdLbXB4QzhGNGd4NWUvM1dtUmhHVExES3lzNnNtQmVL?= =?utf-8?B?b3Y1RmFZUFgwQm8zZXYzRW1qWDR4Vkg1ZE8raWswUms0cC82Mk9KL0tncit5?= =?utf-8?B?TFY4RkwveU5ZeEFzekVLK1FBeWh0Y1dPRTAvN3QzR204RElnRTJjS1VFWU1y?= =?utf-8?B?YkxvM3JFTTd1MENlcVJ4VXU1WEx3RE9XeEQ3ckp5WjRyNUg3KzJYK3JISjJ1?= =?utf-8?B?VUtocDJ6Ni95aHp3bHJNdHliVnV5NUsyUi9raUNpQmlaUDVxWHE0Sm5XRFlT?= =?utf-8?B?SU1GTnpwT21JYkFEdXJRMWFYWmNibHZ1OWp0VjlBQ3djUm5URzc4RVFmcGJG?= =?utf-8?B?VTNLYm15TXMvVUVuRHNmaWlvS3Znd3RUV2pqdDF4VnR5V0swWGs3Vk5EWDM0?= =?utf-8?B?MGRyckZSTC9pcUFhWmFUV1J4S0hTcDc1WUpzRjllUHd0eFc0MGhuMUM0cURE?= =?utf-8?B?REhnYkxyaUNGemNJZDRzTkUzV2c5OHFsdzF6UGZqVERtK2E1THF3c09QYmRv?= =?utf-8?B?Zk5tcCtHQU1GeDRjTE9ueEQxNnlxdTVKM2JtWnFrSXUvaEw0UmkrZUd1ZVgv?= =?utf-8?B?NWhtakR4SzUxU2hBUEs5M2h2KzRnOGdKRWYrTnU5U3VaVHFHdjJhcEtrNGUz?= =?utf-8?B?bXgwbGo3Uk04NWNqTnpQZ3RwZ2ZGcVoxUlUrZERWTTU1YnBTblZ6NHptZ0dj?= =?utf-8?B?S3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2RR74rlYCM+wQ0wfVRUJEgO4zba2qaJrjBMZd1R5ebeABfxRa/Pz5fJ8zd9b6O9z0eXbD3lINMKDQXVMaMD5i8Q+cQEO/J8NkIrALHneF+ALE9ovlUbh27qIg+NcQ/H1gRbAl+LTfJUHlK/jnlZLY5ilG5WUbyplhbcLROngh+REeeCKAklqGwVauxpHXyQ5SKAkjxFTc/BgTwZjuwyCuvTQEGEt9mEZHxJF/4tgDJZ+RYEtXbNmsVJh2EcXRShi+qoZhX56Q3ysFB+Xbkam+DMaWsE+abR33g/yhykR2S9uC28A287B0xi9/LYVB8950Z0LvJOYTbxMt/RWv5xQ1NOkcmyYaPxLEQeuDIlGZJx2XbK5lfrTkt3HO+DXv7ViE0odDqkmT6DhGgGiJgXEE/wluXewtpkWrcgz/HDprGue4Ohp65UxePSsgldkD9ha3khR7FDLW1LEEwOBMaxKE+uqt2kBScmwPxmFDdUPbDMg38cg5ZIa99pF7IsYRjh1iH9H3r1PRYv8SbKAGLs2q0p3i3aJ4blxM18wXuPzwxJ1foNex0xFkoiRLF1pevM3s9BNQrIL5w7QvXEtPt20fHe3BDqodvpHV//7Np52K//vmoIr+oCpKb8gFzBANgSVfuhwQ35G3XZj24UMJxwc8ofEAMV4NIjh8c/Eh+3oCzvN6KnKezkMDjdr5BhutHjZZCLpIKyJjXH2bchdRBE6mAkQGyvxcIiaVqujyx30A+nt1ygxBTT3KhIGOj3phIDxZF89d4wsx7RqxeHyEWy2oAZ7FEJivJwZ0J8JDcRinHJ3SbtLrU72KnwXttuGfdcr X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f81b2d59-eaa7-40cb-ea10-08db36e0bff8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 20:51:52.8281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vy4dqYm7q+yK2KRRyDiLStU+oglfa8z9xBKRMkUTg2pvHdyXpkoDqgfxQCSyGKvzXTP4p7DHTE3dsnMABMUNs3EC7hg66DR7xO6Yzl+yAD8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5053 On 04/04/2023 3:53 pm, Jan Beulich wrote: > As in a few cases before (in particular: AVX512_IFMA), since the insns > here and in particular their memory access patterns follow the usual > scheme, I didn't think it was necessary to add a contrived test > specifically for them. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Apr 06 20:56:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 20:56:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518990.806100 (Exim 4.92) (envelope-from ) id 1pkWfC-0004wg-Mf; Thu, 06 Apr 2023 20:56:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518990.806100; Thu, 06 Apr 2023 20:56:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWfC-0004wZ-J5; Thu, 06 Apr 2023 20:56:58 +0000 Received: by outflank-mailman (input) for mailman id 518990; Thu, 06 Apr 2023 20:56:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWfB-0004wP-TJ; Thu, 06 Apr 2023 20:56:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWfB-0006Fe-RH; Thu, 06 Apr 2023 20:56:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWfB-0007FG-DK; Thu, 06 Apr 2023 20:56:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkWfB-0008Tl-Ct; Thu, 06 Apr 2023 20:56:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=khMSAbXYvW6v+pNwYg0znAtqn7/qpevD4W+uitRI6ZY=; b=B4OC8000DfaXPnxQCp7Qi02A4x P7wvmXNmDtERgD4klHhTjD25e2xNyp2JACy+XXCVZrKUWSoycYTA1BuIf3E5cUzuWM2GMESUsMdNY 9ueZ7PpsWfMWbjhxfPj3rtWU3WIoOPn4PJKRUd/+oivFF7i1co/LggCNZOpx9fLR927U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180171: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=a5087069a8c40541ba81fa0e2850471c949932b3 From: osstest service owner Date: Thu, 06 Apr 2023 20:56:57 +0000 flight 180171 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180171/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen a5087069a8c40541ba81fa0e2850471c949932b3 Last test of basis 180169 2023-04-06 14:03:37 Z 0 days Testing same since 180171 2023-04-06 19:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a5087069a8..ddaf7bb0cf ddaf7bb0cfd27369252de52e4b03410c4065bad2 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 06 21:02:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 21:02:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.518996.806110 (Exim 4.92) (envelope-from ) id 1pkWjy-0006Pt-9W; Thu, 06 Apr 2023 21:01:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 518996.806110; Thu, 06 Apr 2023 21:01:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWjy-0006Pm-68; Thu, 06 Apr 2023 21:01:54 +0000 Received: by outflank-mailman (input) for mailman id 518996; Thu, 06 Apr 2023 21:01:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWjx-0006Pg-CZ for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 21:01:53 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f41457f-d4be-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 23:01:50 +0200 (CEST) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 17:01:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6092.namprd03.prod.outlook.com (2603:10b6:408:11d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 21:01:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 21:01:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f41457f-d4be-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680814910; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=gKurutHoy7sve8V5n2Kf1VRnA+63mQqgavH5Fq7Cw7k=; b=KobH7JOid6QEoj4NIcAvqvXEaPZzttZZjLsGlTc1KorORFEwAruajQ+v B9B4Jg1BGpSMEeh0GBA2TqdODtj7sQtK6EiBMPJoXOGs+HZFj7KOi3H93 eCo+qGtMWErssYCRBgUWdPLZszVXHxlYHVwCEqhaV5Ji9Yyv8S/ipVWBT M=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 103415141 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xvM0m6AVZfHyShVW/wTiw5YqxClBgxIJ4kV8jS/XYbTApGl00WNVx mMZCmuCaP+LYGH3fdpwb9yy9k1V6pTcxtY3QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwy8IqD2wR6 eEhORtUX02lg+6535z4Rbw57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvDO7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXxn+iBdtOTdVU8NY33EOpxnAyMCESFn+in6HnoWq8Q8BAf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBRw1V5dDm+ds3lkiWEY0lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:unloGqxDLcKhz1Mi3/xoKrPwD71zdoMgy1knxilNoG9uA7Clfq GV7Y8mPHrP4gr5N0tQ/+xoVJPwIk80sKQFhbX5Xo3SJDUO2lHYVb2KhLGKq1aBJ8S9zJ856U 4JSclD4bbLfD9HZLPBkXSF+rgbsbu6GWOT6ds2DU0BceinUc5dBn9Ce3ym+4RNKjV7OQ== X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="103415141" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bre8/qXhJC0qbJtELOf99I+xO1BBwwdpOIsI6DCKplbBfpb/rmG6QuTs8hJJ7QcytJZ7fF/dQgy1jVZKwB10MCz/1iyGVbL6WKnuEzD+89FX5Sr+LSMRDC+OOkUGyk6WSdBD13tQg0JcXOa3TefxUDxTUSi45SG15nTbwfqrROEreAfl32gHXVQJHIk0HUVsGdqN24H56z6EoMhCwS9vkR1+svWmIfvZkI43Ijdnu2gkU6nrr2vPGykzY6fNBGVR3X/b9TziFn/z2plMIz/XREPrvcK7gUKfIIGzMJuI3DfAcY2Xuc3tA2tCSK9NTCVR1SzmLYEadmh/gHwQPLQqWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gKurutHoy7sve8V5n2Kf1VRnA+63mQqgavH5Fq7Cw7k=; b=EYBtzpkANAR3PqpvJJhRwEqsjEyol7K+V2gAVfwgXcBFTj1FiWUdeyPsN2Gndd5dxvGFtklcwrh8KxnDW6xttFZKnHAp2UuP3X1IeN6cG6BK0WmO6GlyZa6z8Vr151bw0EESk5dlRGpR2JPCyD5DRLzKItn6msL7qnG+OIPmMAHnZd6LUWxzl2F7ml5Ad/Ams89XsZ9T5MKZdHwTJ+ZsxB6sGo0nfN2e5A+bq2xtdE5pN2bTNi0J9PuYwCzmPDshnR/n+2teSnwnEyIyExNtiVmGgborm+63z1giB96YiunfPdK+l/GATIBEnXXg35bbQgyCSMvgcWHIThE9GWG6fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gKurutHoy7sve8V5n2Kf1VRnA+63mQqgavH5Fq7Cw7k=; b=Ma5iNDs2VraVm27liMEXNKZyY9n+/8EBAU61SrOnzsFr14WaUF68bbm60Y8rQ+1jahrIJMZ8msUh+bRnaZcXW/q+lhNd2XCwlQDnWDGyXGAkPIaqUaRll1XlfIk5veOjZrmtkvxvv6+fyeabjckNSa8z6HuhP0KT7kSP7U01M6A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1fa826b6-7d85-9f1b-037d-7d6f3d35461a@citrix.com> Date: Thu, 6 Apr 2023 22:01:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 7/9] x86emul: support AVX-VNNI-INT8 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0017.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6092:EE_ X-MS-Office365-Filtering-Correlation-Id: 27cd20b8-7707-4c6d-5132-08db36e21f53 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E4feq0gnkNZJrDfy/17kgUlqR2/zxnIrnmCU4A0AZN6D+OpH5WTmpKueUuc1iUwokKq16N2yMnjl5tOlKfsbWy3cIjm3s5JPQJFWTrj7YUVRtUdsx4onGC54c4GKndu+xavsojTgwFdpV7NGhBv8UKoI+Quxum1VWMqrsF+KswQCSQIV0dRQIkb+4GJPyU9BsPeUj9J61Y/qNxOF8hdQPHXO0MxdbcF990pHTWytyawVJ1CrNMYbd8sFWHg6Bn1XjYQcL+B1WMGVvSaSdw+phUd8sdgF5QkJ7v68PweQT0JLNf0lhKvTV+DgRO/bVOB36lVVcoVGUyRQ0bfdsvwZ4/DHCoV2c/Coik9qZdPkxN2i+7+DKdBy9cKv3SjjUuA9HEpui0IK9gVDAJs31BzCgnsN11f9cGd3DWEyXz9n7cVLq3lh9SNi9eVU5S1nVPNx63P8ZTD/+IvyMA6OnICZwjbQRc+4rUuKwqXOsr5JwEJkAdX16jPDH+fsSD/o+0WUqXGW4rNlty41hWiL08H9jgkANkEyCDX3K1q01uxGAttF5elCXcJ4TvGvGo70687f/U2RpjwMybLnwQswI7jsNi685yEawNe+rLSfZ21OSTg74sjXXyBnH+gZB31R3CRKvHg/OJ+0PsSKG6nGz0sRAg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199021)(31686004)(66946007)(6486002)(66556008)(66476007)(8676002)(4326008)(54906003)(478600001)(41300700001)(316002)(110136005)(36756003)(31696002)(86362001)(83380400001)(2616005)(107886003)(6512007)(6506007)(26005)(53546011)(6666004)(2906002)(5660300002)(8936002)(4744005)(82960400001)(38100700002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amcxeTdxSVBocTZ6c21PN21vYk5lVThqdW5hQjNnVm5aUElaUTkxSXI0aW1T?= =?utf-8?B?NGw1amZ2NEN5ekR3V0IyWDdnSmZqbGpLeWxYU0wrblZEQjhvcHdnbFFiNEVw?= =?utf-8?B?YVB6bHZ2UEI4YW1aUE1CZUFHZHRTV3pEQUJ0OVVXOU03b2FCbFNNY1NHNW15?= =?utf-8?B?MXRQME00clQvNUd4dTEzYUg0Rm55YTZyT1Y3OGV1M1VSOGJKNU1FRTBlc0M3?= =?utf-8?B?UmhPemJtcmVzOTVKaXFqQUpEQjlWNHVnaUxMYXc0blVKS3BSNFR1TUJEWDRT?= =?utf-8?B?ODZsZnloSTVzUzFuenlSYzlUd1BmUDYrMTZJZElPN1VWK1BLc29HSXRQSWg4?= =?utf-8?B?UFFIOVliaW5Cd1h6TU1GRmkrL1JVRkxVcHFhUk9uWFdmeVZKWU9rV2RxUlkz?= =?utf-8?B?akRzcXE5TjZHUksxY0dFZDRJazBBUjBseWpmcXhxd201ZkQvM3hDSHJaOEhy?= =?utf-8?B?MjRoVlJtUkdnOVZOTXE4Y2xmNk5tVmUwTVh6RGFsUDI0bHNxQUpBWUY2Y3Vh?= =?utf-8?B?TzU5QThZT0tFMDBITXUxRXpGeUYyamRRTDc0RExpUXlOQzJyakJhbTRMV2Y1?= =?utf-8?B?VjY5Y0VtdXluKzZqSlZBYU1hdWVDRmtYSWo4WGFhdkNMYlliaE1YczcwYW9O?= =?utf-8?B?Y3FCaytnYmpnRVFFNzR6U3c2ZVNWVytqdVFwSXlrT1grNVkzZjY4ZmU5S1Mw?= =?utf-8?B?VmxMc0R4RVp4SGQrdTZWTXhzRHEzOGtOWm4rKzlnWjh3THZISG42MkdGaWtS?= =?utf-8?B?azNWWEJQZzhYcEU5ZCs4NmMrd1A3S3l5V21xeFFjOUtCYWJFeEZaQ293Y21h?= =?utf-8?B?ZXZXYUVrRW5BUzdkTlNhbDZaT3BzV1Izb3lBdGF4L3dzZloyL1JlNDNsT0ZZ?= =?utf-8?B?MGpxUVNtaENWc2tWVThlVFZSWFgzRmZZcjlRb3NQaVR6UmtRbmZnUUJDZWdT?= =?utf-8?B?VXhSMzFnNXEyYmFjT0MrWGtxY0l6cjBnbUJkcG5vTVBUVm5ZTTE3OUUxclhD?= =?utf-8?B?ZHB1UVU2QnpmUEpmNWZKSkxHRXFWQU1uVi8yMm9YNUxnV0lqTmpvMFJtMEpD?= =?utf-8?B?Tk9EU1ZyOTRyZWpNL0x5UisxL0V1VFpWczRDdFROYm90R0xYV29MY04zeStq?= =?utf-8?B?WlZ4QjFOZDdJekZ3elFNR1hVZDhhKzRYRldBbFJDb3k2cWJyQ3JKQllwMVVK?= =?utf-8?B?RmMvN3RDM1dTNnlpbTVPRElDbkxYOHF4UGpkNWtPdjlsNW4xZEkwSTJPSS9R?= =?utf-8?B?QXhpWG1ESzhJWE5Ha2FscGpVWmJjeVcycmxONGpjTFEvbllwS3RSeTl1SDR1?= =?utf-8?B?ODFNR3l0OEpGT1JtYi9TZ1dHZUpjTCttZ2lSNGovUHVDRWVCaGRWeUZiYkVZ?= =?utf-8?B?dXNxZlpZSTFBQjVEUUU5Tm9Ycmw0M2x3U0JHSUtJSDR0WDlzT1o2T2hXRlpD?= =?utf-8?B?RDEwb0gzUnNoUlJtd2RkMWJSWkJiakZUMmxPTjVuSDgrRW9HbWQyYkovMWRq?= =?utf-8?B?QUVVMkM5SHc5MG96dXg0VW1TODBrN09lQ3djOSs5OTNoR0RZZ2prK3pqV3ZI?= =?utf-8?B?RCtCR01NVWQzYUlhNEcyMzBIT0RBRTdDOTE5TkRwU0VHQlpUU1Z4cm9wTkhV?= =?utf-8?B?Tml2RFZ0Q3N6blMrZk9RNVhxQi9lZDB5a2VUc0xML0llY1puNEcwNHNHNWlj?= =?utf-8?B?bjY3bDlYaHI1TW45eFpnWlN1ZHpkUktXcFFyamloTEVrQS9qZk5FSHpnSkV2?= =?utf-8?B?RTEvc0NtWkFrV3NTTnZXbFJXdmpoZGIvTVVmODBBVDdqQlNmRHBZZ0l0UzMr?= =?utf-8?B?aUhQTW1NcU1LSEJJZGlEd3Iwa2ptTWR5eURHMHpNaWZ4bUFsRUZ3VU1EekdI?= =?utf-8?B?cEZ1ajUrdzlESjgxV0dwSVdKYUJoaVBzd09nSDNDa0NLSCtjL3RDQ2cxSWRB?= =?utf-8?B?ODdhM0ZZNU16a1BjM05hS2doMnVmNzdYZzdtT2RaZzVwYkxvckFDc0F6OERt?= =?utf-8?B?Uk1VN0FTZHdMZ2FKVVJkTXFLZ28rRitlS3VZajNhUzFoN1VQNisyalVxV2tP?= =?utf-8?B?ODcweXFHWERiTFlZK3NzendLMjFJemY2WTNHN3ZlTXI1QU82YjNORkg1dTc2?= =?utf-8?B?blN2cm5jMjJsZEZ3S09jWW1ndXUyWkZuUTNoVUpkT3piZXg5bDdzRlpLTzMy?= =?utf-8?B?WVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HYIZfeqB36tCFoLop5sMPDAEiSegS0gNuQJ8WYrnS1/Gf73ASpaQLi+OiOexkfUmUn9GaszIJfjfcy6mMoH+5/+hgBrZytytk+BrPuRKaACP8BJ4BMIaXI3AoPFoq8CyDGhQ7wNFGj+Vdc3cC/KloZMi1NM9ZwrMUPZU5q0RgB0z0Vsys94zqAq1d0XMPxct3M3a+xXf3ZA9cdBoXMb6m2aZK0vYaJu8Sx/yzI0TP/PKtFGyQWNgfeNzIb7OoQrl505A9POjvnlAI3jdCkAhJSguOsZZzutpNlwVf14zhWQPGP90qz9umyoP98+kbRnjLiD+xeyrKLQ6T7GSGhIICwbWq98fWvWSMNiqUwCh3jV9f1UMJsDCyvuaq3Rn3IRunyfNynORyCTL8sot9DtTiuXyEQY5CEUsL1MUgjIld4nehb0N83sZBFxEVM/+NDtKbbKvhtHpxrLBsJhkLUTsUItsw/FnZVQvCk0ub2B3a72e12tDJrItujEjjXQpN9XQAh+Ca0IOUjOLrjumCV28vbJCESQEmygI8A3nAR+WXNym616un1v4peqe4SkuwKgWxfH18KasIXkz/qj3rqLp0Mr6B8TqCGdOhDd0RXq7phj7Syk7b9WE0BhIzYJS8x+m0kttNGgM6+CNzptEGUdGn79plvzHSqKr46oHPgOXKTdGMdHncZ9wbpFef4YYBIPz/f/OLUNrKNYX3FIzOBsKTBecWFMGYDQl/xuunaC45Ghhihx+8azCkBObcR/ugaHPCRRdORKC+7W/lSLkcMMBzHOy5ZHAWZpoaom/yXe/AacZFbR9tGMik9rjqxQFblhA X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27cd20b8-7707-4c6d-5132-08db36e21f53 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 21:01:42.2335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vaWyGbhYNq3gRyFdKcxAHbDT2ytys4wtGwr6uwEUBl7x6/8lzvtXYR57g6sAjEPinxys37wHm+1kWzKNsHO11AukG4OsS6q5MDaEcwDE7YU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6092 On 04/04/2023 3:54 pm, Jan Beulich wrote: > These are close relatives of the AVX-VNNI ISA extension. Since the insns > here and in particular their memory access patterns follow the usual > scheme (and especially the byte variants of AVX-VNNI), I didn't think it > was necessary to add a contrived test specifically for them. > > While making the addition also re-wire AVX-VNNI's handling to > simd_0f_ymm: There's no reason to check the AVX feature alongside the > one actually of interest (there are a few features where two checks are > actually necessary, e.g. GFNI+AVX, but this isn't the case here). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Apr 06 21:03:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 21:03:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519000.806120 (Exim 4.92) (envelope-from ) id 1pkWla-00071C-Ne; Thu, 06 Apr 2023 21:03:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519000.806120; Thu, 06 Apr 2023 21:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWla-000715-Km; Thu, 06 Apr 2023 21:03:34 +0000 Received: by outflank-mailman (input) for mailman id 519000; Thu, 06 Apr 2023 21:03:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkWlZ-00070z-Fw for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 21:03:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b75b6c1-d4be-11ed-b464-930f4c7d94ae; Thu, 06 Apr 2023 23:03:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ABD860F8A; Thu, 6 Apr 2023 21:03:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77CD6C433EF; Thu, 6 Apr 2023 21:03:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b75b6c1-d4be-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680815008; bh=baSuc3BibvB3PyiGiOM2HhWxK6GVI9IxnZZWwuwsNt0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mM5y2v9V0XrBUWuQ+oK7Za92/KG4pQawUlDfs4D9f8p5l5p/db+J1EMs+aK00T4ah TNhy/0UbJhvvOo+EhrgsHRcFRfqDu6uuWiB2u0FDhll7tBlcXbCwQpnt4C2SzgAQ5o FkCVHvmzLW+3qL3A1MSZWJwiwKaJ7E8ZT9d1S+DXYjxnWmLPMqoGUJ2wfkC3Z5Usds 7kJnUOW47MvF/Er4O8flIxqzXfN78Mx1/jzeHG49Hgp1xcTIUgdOHxb1t/8/CJhZB5 KHNnBB9G5Q0AUzTTNVxjNxFsmWRxy55a1VsqG89cdVCusrafau1kzkiVuTtiv4CFa4 9CjUpyzp5YwVw== Date: Thu, 6 Apr 2023 14:03:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Oleksii Kurochko , xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v9 4/5] xen/arm: switch ARM to use generic implementation of bug.h In-Reply-To: Message-ID: References: <8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com> <3a94ad32-159d-d06f-cba6-3bb40f9f2085@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 5 Apr 2023, Julien Grall wrote: > On 03/04/2023 00:15, Stefano Stabellini wrote: > > On Fri, 31 Mar 2023, Julien Grall wrote: > > > Hi Oleksii, > > > > > > I was going to ack the patch but then I spotted something that would want > > > some > > > clarification. > > > > > > On 29/03/2023 11:50, Oleksii Kurochko wrote: > > > > diff --git a/xen/arch/arm/include/asm/bug.h > > > > b/xen/arch/arm/include/asm/bug.h > > > > index cacaf014ab..3fb0471a9b 100644 > > > > --- a/xen/arch/arm/include/asm/bug.h > > > > +++ b/xen/arch/arm/include/asm/bug.h > > > > @@ -1,6 +1,24 @@ > > > > #ifndef __ARM_BUG_H__ > > > > #define __ARM_BUG_H__ > > > > +/* > > > > + * Please do not include in the header any header that might > > > > + * use BUG/ASSERT/etc maros asthey will be defined later after > > > > + * the return to from the current header: > > > > + * > > > > + * : > > > > + * ... > > > > + * : > > > > + * ... > > > > + * > > > > + * ... > > > > + * ... > > > > + * #define BUG() ... > > > > + * ... > > > > + * #define ASSERT() ... > > > > + * ... > > > > + */ > > > > + > > > > #include > > > > #if defined(CONFIG_ARM_32) > > > > @@ -11,76 +29,7 @@ > > > > # error "unknown ARM variant" > > > > #endif > > > > -#define BUG_FRAME_STRUCT > > > > - > > > > -struct bug_frame { > > > > - signed int loc_disp; /* Relative address to the bug address */ > > > > - signed int file_disp; /* Relative address to the filename */ > > > > - signed int msg_disp; /* Relative address to the predicate (for > > > > ASSERT) */ > > > > - uint16_t line; /* Line number */ > > > > - uint32_t pad0:16; /* Padding for 8-bytes align */ > > > > -}; > > > > - > > > > -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) > > > > -#define bug_file(b) ((const void *)(b) + (b)->file_disp); > > > > -#define bug_line(b) ((b)->line) > > > > -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) > > > > - > > > > -/* Many versions of GCC doesn't support the asm %c parameter which > > > > would > > > > - * be preferable to this unpleasantness. We use mergeable string > > > > - * sections to avoid multiple copies of the string appearing in the > > > > - * Xen image. BUGFRAME_run_fn needs to be handled separately. > > > > - */ > > > > > > Given this comment ... > > > > > > > -#define BUG_FRAME(type, line, file, has_msg, msg) do { > > > > \ > > > > - BUILD_BUG_ON((line) >> 16); > > > > \ > > > > - BUILD_BUG_ON((type) >= BUGFRAME_NR); > > > > \ > > > > - asm ("1:"BUG_INSTR"\n" > > > > \ > > > > - ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" > > > > \ > > > > - "2:\t.asciz " __stringify(file) "\n" > > > > \ > > > > - "3:\n" > > > > \ > > > > - ".if " #has_msg "\n" > > > > \ > > > > - "\t.asciz " #msg "\n" > > > > \ > > > > - ".endif\n" > > > > \ > > > > - ".popsection\n" > > > > \ > > > > - ".pushsection .bug_frames." __stringify(type) ", \"a\", > > > > %progbits\n"\ > > > > - "4:\n" > > > > \ > > > > - ".p2align 2\n" > > > > \ > > > > - ".long (1b - 4b)\n" > > > > \ > > > > - ".long (2b - 4b)\n" > > > > \ > > > > - ".long (3b - 4b)\n" > > > > \ > > > > - ".hword " __stringify(line) ", 0\n" > > > > \ > > > > - ".popsection"); > > > > \ > > > > -} while (0) > > > > - > > > > -/* > > > > - * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set > > > > the > > > > - * flag but instead rely on the default value from the compiler). So > > > > the > > > > - * easiest way to implement run_in_exception_handler() is to pass the > > > > to > > > > - * be called function in a fixed register. > > > > - */ > > > > -#define run_in_exception_handler(fn) do { > > > > \ > > > > - asm ("mov " __stringify(BUG_FN_REG) ", %0\n" > > > > \ > > > > - "1:"BUG_INSTR"\n" > > > > \ > > > > - ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," > > > > \ > > > > - " \"a\", %%progbits\n" > > > > \ > > > > - "2:\n" > > > > \ > > > > - ".p2align 2\n" > > > > \ > > > > - ".long (1b - 2b)\n" > > > > \ > > > > - ".long 0, 0, 0\n" > > > > \ > > > > - ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); > > > > \ > > > > -} while (0) > > > > - > > > > -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") > > > > - > > > > -#define BUG() do { \ > > > > - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ > > > > - unreachable(); \ > > > > -} while (0) > > > > - > > > > -#define assert_failed(msg) do { \ > > > > - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ > > > > - unreachable(); \ > > > > -} while (0) > > > > +#define BUG_ASM_CONST "c" > > > > > > ... you should explain in the commit message why this is needed and the > > > problem described above is not a problem anymore. > > > > > > For instance, I managed to build it without 'c' on arm64 [1]. But it does > > > break on arm32 [2]. I know that Arm is also where '%c' was an issue. > > > > > > Skimming through linux, the reason seems to be that GCC may add '#' when > > > it > > > should not. That said, I haven't look at the impact on the generic > > > implementation. Neither I looked at which version may be affected (the > > > original message was from 2011). > > > > > > However, without an explanation, I am afraid this can't go in because I am > > > worry we may break some users (thankfully that might just be a compilation > > > issues rather than weird behavior). > > > > > > Bertrand, Stefano, do you know if this is still an issue? > > > > I don't know, but I confirm your observation. > > > > In my system, both ARM64 and ARM32 compile without problems with "c". > > Without "c', only ARM64 compiles without problems, while ARM32 breaks. > > > > My ARM32 compiler is: > > arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 > > > > Additing a meaningful explanation to the commit message might be > > difficult in this case. > > Agree. One would need to look at the compiler code to confirm. We should at > least acknowledge the change in the commit message and also... > > > > > Maybe instead we could run a few tests with different versions of arm64 > > and arm32 gcc to check that everything still works? If everything checks > > out, given that the issue has been unchanged for 10+ years we could just > > keep "c" and move forward with it? > > ... confirm that we are still able to compile with GCC 4.9 (arm32) and GCC 5.1 > (arm64). > > Do we have those compiler in the CI? (I couldn't easily confirm from the > automation directory). In the CI we have: - arm64v8/alpine:3.12, gcc 9.3.0 - arm64v8/debian:unstable, gcc 12.2.0 - arm64v8/debian:unstable cross arm32, gcc 12.2.0 - yocto, not sure exactly but it is going to be 9.x or newer From xen-devel-bounces@lists.xenproject.org Thu Apr 06 21:23:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 21:23:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519006.806130 (Exim 4.92) (envelope-from ) id 1pkX4B-00011B-AF; Thu, 06 Apr 2023 21:22:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519006.806130; Thu, 06 Apr 2023 21:22:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkX4B-000114-5p; Thu, 06 Apr 2023 21:22:47 +0000 Received: by outflank-mailman (input) for mailman id 519006; Thu, 06 Apr 2023 21:22:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkX49-00010y-R6 for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 21:22:45 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29b96750-d4c1-11ed-85db-49a42c6b2330; Thu, 06 Apr 2023 23:22:43 +0200 (CEST) Received: from mail-sn1nam02lp2043.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 17:22:40 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5090.namprd03.prod.outlook.com (2603:10b6:408:db::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 21:22:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 21:22:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29b96750-d4c1-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680816163; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=BzJN4JdOofRno5appIBdbLkXJFs7In04tnq68aN6iwQ=; b=PngVGeMJb/uFlRtrpeODSCgCVZzIjnBHcEuMJ56bwe6CtjRUAbclurI9 4Wk0SQzkrWMRUxGnsK7vkCE9Gp8Ax3cRgjYBOGjWOHzEbqS8FWz3y/DnY HOz/ilvmKCKOXChC3dkKDcm+lLPqLHDoMnFK8R7ky+UsnI5p1xUQA7vsl 4=; X-IronPort-RemoteIP: 104.47.57.43 X-IronPort-MID: 104537676 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:42erWapDzMKCcCZx7HsZe6ThSbFeBmI6ZBIvgKrLsJaIsI4StFCzt garIBnTOvqPZzf9KY8gPty39x5Tv8PQztdqSFM5/Hg0FCxA85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCzydNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABQxTjXcmeet+oCiSrdVgJw5M9voGLpK7xmMzRmBZRonabbqZv2QoOR+hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeerbIG9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqqMx3wPMmAT/DjUcTmGE+8n+i3SgdNN9F GAZ6jYOtYoboRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSy2ETgYKykFfyBscOcey9zqoYV2lRSWSN9mSPSxloetRWq2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:3a4AaqpdV2VVisR+cYlvJRAaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="104537676" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHfH2mmXck/2QOKFmUJJzMhdrgvs2fiVXhJ+elNelkV7IFkEnZ1eVgxJ7NUlUl+MGzyFsmUQis/LyLji5lKE7Zj0pUbWn1JTK3C6AML+Bd6HNJkFpa+E+5Ynh1EZ8SLkEOxlVV72HyZyV76s2WvDMOvpVExTDEBg9GtuGP0aP3LCad3qA8fPWNGmBwgSByzYxW5pb6CORN4ItvmqRVA9sAbwKYzurcWYBnJZanCt9H4DkBTbXW9JxME4GerKZ++Pv3tmVat82jHW8nZudKQvl9EoaXYADoBa3QRt3AxQeh45Wvf6zzOAko0jQ4KGAgE9LlSyLulejD85wL7nyDSn6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U60zMlzuDf1vv/6ILqjcYiN2syBoZzzYgyc4F3Axulk=; b=AYHHrkh/9LbOWWt7di+0XQA/o8MFLFvTS1PfiW9vdk2LlhFLVHBqaw74qYWf3maA75OP/xyWNCt7Qh8F6JhpIoudemsVmx7YIIH1lrYE1ualKJpvoJDTvpH2TgS9YgwWnCLR9En5mbE4MZq+XetAEFwjtNz3AbmNEKU5YizvaWpD1mHoIWvuNZcnZPqbjf7i4TU/ia5i7yyhAzEBsbqznPz/AJG7df5iv1z2l4cZzMyPVchoI0Zt0VvX03eBbmS6nSVnOuSxr9g85NvmHOBxH8wSvaMsUKVqstQbrRbjmpNDGEA8xtsacEn9hy8ifb9bF3TxzsXessI0xGoUQlA+cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U60zMlzuDf1vv/6ILqjcYiN2syBoZzzYgyc4F3Axulk=; b=fGdBoA6ZzdRaUkZyFgMqO+ZOF10pTa5RU6qqgkRjAUFh2dRxGtadmFfl2Ujnl5lLHkjITsj3SmAwufJM4xOogNAX+DFnrajmUUjY+OykgdW1f1i/jdKIFkMum3Y3VBHN9NfBiNtI50H908EUZtvz+BMtXVX3+7JLDnLC12DK1YU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <385b175a-5123-3b1f-0663-1a956f5ca3a7@citrix.com> Date: Thu, 6 Apr 2023 22:22:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 8/9] x86emul: support AVX-NE-CONVERT insns Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0417.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN8PR03MB5090:EE_ X-MS-Office365-Filtering-Correlation-Id: ba28c604-f2e6-48c4-cc6d-08db36e509c5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZnuRQ9qqIfmm7S/S6TKDjGq2mHR92KglFDFE0+8rIR77RTqJOdCtQmN83OXj4HHR7i0478eg+Im5IlL1kYSNmb6XFao68fxDpcLMbx0VQElqFNpXqH4s759j0d8sFLxjyrAKuy70HcZoeFhDahXZJhO6OHBXJ1LTWdyzyecjsyZlgdcwxSWuj7s/WG45zqQ2h8I2sVP98tRV2dzYKfwINM3UaWAe6oE+IVMeceX2O9/1GsWVsqiISaU8efTyPmp7tcVLKEvnOlwssqOeD4NNYlDEmd9T1ESjMy5bWg1TeXbCy5cufJ0dJkvXFUIt/KKvXerQPY14UIXuWM3pOIzx4tR6rVXxoUfMEDkrJBwhk+Qdcc5m/l4IG9mmZwBuRPfTvSMwj0B1NmX37e+xseROATkxO/I8uaCQybin8dWJQ5YxhUPRuOYvswO14q74Q/Wq9OYx7ZglYUW4/0Ht5RVK16zecHR4lNXvR36XDMYn+kDHpRthvB0FYmFBM/93KVjPNf9S7LMmhPH/9ESvs4UuNZJQxZM+u59jhjxnj7e4mMezdyrd+oPlx9+5ljIetB/l7ohkgWQJkbdeg4GQoiC0h+0NebxvIWJPRXJo3+O2UKX0isi3EZtOY6p6fm7yY3b9LhROfWDwFt7CTDQeHKCT3A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199021)(8936002)(41300700001)(31686004)(38100700002)(66946007)(66556008)(66476007)(4326008)(8676002)(110136005)(36756003)(2906002)(54906003)(5660300002)(478600001)(6486002)(6512007)(6506007)(31696002)(316002)(107886003)(26005)(6666004)(186003)(86362001)(53546011)(2616005)(82960400001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHRJbm1TTUg4V0Y5U3R2cStXbWhBYjN5SGNOaFdZQVgxQWMyQmZoUDh2UlFj?= =?utf-8?B?Z3pCdmlHcHdSZ1JLcU5PczlIdTQ5YUJ1OFhxVW9takdIMVlxSzRKSWkxdDhG?= =?utf-8?B?QVVPZkhsNzg4bWZKamJlTDE1bWI3ZUY5ZmI3WmdVZzJtT04wLzhydXJNclQ2?= =?utf-8?B?VXJRRWNlbSs0eDdnZkdlWSt3ZE1PMThPTGR4TXI5b2ltR1lQZldOeUkyTWhE?= =?utf-8?B?b3dOUnBnemxtU3ZjQjJHN29DTzVaTjkyTGRjWUZHSkROUHFVbFE0M0VEQzdT?= =?utf-8?B?Tnc4RFQzTzVXQWFNTWNMN0NZbEkvbkw3WWdLem1zSTVLUU5UbXpidStRU2Ez?= =?utf-8?B?OE5IVFJsbWplK1ZFYVNmb2tMNmlSaFZVNG52NUNJOWhjZFF3cW9XTWt6RXRt?= =?utf-8?B?cGNQOWZkbzJnY3hoSVl5TjgwSTJhajc3Z0dOcVBTMGFaV2tFUWpUaWl4TjdP?= =?utf-8?B?Rk5kZlF5Qis4VUY4dExsNFZTdVlJRW8vZTFxV1MrcjBYaHJINnJWNUhWOE1v?= =?utf-8?B?OExXTjZOQTNnVHZJTWFpd0wxa01NUVlkQ2RHZStjK0VOcjRQRnh0TWduY0h5?= =?utf-8?B?SU4zNmtFbXlmNTNmcDhxRDB2aHVuUHNURWR5WmRLZmZZV3BUQ2pSNzRQRk1p?= =?utf-8?B?REI3UTlCMTdQMGxkQ1gzTysyTXRUL0VvMHZMK2hGY3JjVDd6SS8vRUh5TzdV?= =?utf-8?B?YzBLZ2lnZFg2elhrckRtTHlhVEUwYThraXpTSTJpd1NBTVQxMU1Gc0wzS2do?= =?utf-8?B?TnN3VDIvQjNzSjRXSmJsYng3d3h3UWJZc3Z0TlNWcG1IVVdUaVoxeUE2WHRP?= =?utf-8?B?RlFDWHMxV2t2ZDMvR2RGZ0JVcng3WW5NaVE5QWFMaWJlTFZsMXo5NklYZC9u?= =?utf-8?B?amR3VGF3Rmh5aUtPdHZoaU9URlVCVi9HQWZ6NjlYTXkrT1hUYzRSVmhPS2xl?= =?utf-8?B?eWZNekJJb05oUmcwdHZEdDZaR3dpeXRnTnRLMGJBdmpOWkNyK281Q2t2WVNq?= =?utf-8?B?M2ZOTjREVEQxS1FjMTBYZGJzWGttOGpmd2RBZnBjcWhEeEhQMFlRNThQZkRG?= =?utf-8?B?R0tnbG1ic1UxWkVkYmVqdFlKU3dQYlh0U0MvZktwc3RlVXd3WU9yODBWTjE1?= =?utf-8?B?Q0Z4WHlPNXJkQmxHZ1FNcEs2NU1iRUt3cXlSVjV6YTUxTFNyYXFhMDcwaDg5?= =?utf-8?B?ODk3OHMxUTIwKzNpQzV3dXg0dkxCcXpVMkJLN3dHNE5aRGk3MXRSOW1zZXBE?= =?utf-8?B?OGtCSVM2Z1pISEFYLys3NVpwbXJtbnVDWHplTVA5eWxLdkpGVDFLRXBIaDRv?= =?utf-8?B?ZUwxbnk2VVRYamRRQ1VRL1NKRy8xSzJJK3VzanRZUVBkc1dsNGhjMmdmL3dX?= =?utf-8?B?MWpUNml0Rys3WHNLUG82RzhTODhTWTg0YUNGQ2VsRUpndDNOaEc1Y3ZiZTlq?= =?utf-8?B?enQ1UEREZCsrY2h4dHdZTnBmSWNkSVZUczJPQmpNcExHaDJjall6ekdJZEFX?= =?utf-8?B?Y2MrUWRJVXZHNG1QWGx0ZGtLdVR0OFRNcTF4bFN1NEwwRDVPclpIeStnNnB3?= =?utf-8?B?VFNrZ2lQa1VGbDQ2d2M4Wi9CdDR5NmM4SzFZVFg2TDg1USszU21ZcHlzNndy?= =?utf-8?B?eUJ0Ym92WXpRTmVmVmFST1pSZmhxckFkbC84QkdydzczWG11K0UxcFlPU1Zm?= =?utf-8?B?S3Q2b1hxQWR1QWdiT0JIV3Q2aWRyU1U3a0h0anBLai9vNDlpR29lZXkyYmRD?= =?utf-8?B?N0c1TEE1TFhzNVFTUUppZ3ZSL3I5SjZ5WHZFWnMreGo3d1BGbVlwbmZYb2xH?= =?utf-8?B?Q3dJM01CU2p6QlFpaW1KdjFETzZ4RTdIUTNyVjZ4SGRONk1paXhscXQwRnI4?= =?utf-8?B?cVR4ejZlMnY5c0FydW5yR2hxK0NJKy9mdlJucXlzSzVpMm8ycWMreEtuMjYw?= =?utf-8?B?a25ORW5Vb2JTbVdrU1JMb1JjTTNCV1hKYi9SUEE1SnBETzR4RFUxNFYvaFBX?= =?utf-8?B?bVlFYXd3Vjc3NGFhQkZZOVR5djJWR0ttRVpHSXVYcklUazlobzVEMFllbVZv?= =?utf-8?B?bWI0REY1MUQ5Umg3V2ErN3FZSFRNOFZDYlNvQUJzV2VrZE5jUUJiQ0VjYU1Q?= =?utf-8?B?dHFQZy9pQmtmOE53SWR0bGNpSExWcDNqNDhuLzFDMHJzd3pqRkZvcjFiWEh4?= =?utf-8?B?dVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3jvthljj9fw7GjHAGRlKrWtHDA7yFTggXtvn8acUeYCRAb4OUFIEipbtjVCEFXN9KXllWRCKAYhGVshocL7T5T7f09hOfRNJ4NMWyD5MeyQNjEwV9gw8t5B5Um40MQvGfbcnQcfBmDGVhDp0zWsIdUQ143Y3SN+WrmNsiIUt6crmEQhM5EHL74UTwYU1LIFNzvjMchGjz7yAV/B15YVI8sx+jIOEnH/DygXxBa216qmz1nyV84iPPRwNpxsH3jkspNq9c5J7rRnDF2QZ9Qz3OadLQT2HoPm+Yf/ea+MLK96rkj3lLvmFP+VlXLcFM2Te90WwFGeRrlg0NV6ea7+6k4C1Nh5cL8mFOsNB+uIzRiPl94qlMQCfyODJSz1d6k9CxVhMnFgSKhXjcrlfk+JsA9DV9hoZjX99IYbnzYxIoxk+/Wbn7n7ahM/YveiDhA5wBHjHm/eRREfQJhXz76JkOnvRE4wLc4IT4nyWqVUaxLwz6z9lYiyRhoF6QLODu28hFWcdPPZg03wIDTEWuY7q9KtTSwlkTNpDhLVPzo91a2FOXpzAatD61cyLl0mDycIxX+5hDwH3OY11uoH/s2ugBQ7xIi2phfkNAC+/7J+7hC24FlHS4lwBT5t+5MtWXsbZNoBq0M6aP09WaJbc1rrcRlkr6f6D/wqZjRzBWEeG4rP8fPwRbXICfS8518tvMZ+oMChgwTpa/MxescdwwrpyhoIOU4ynDmKGq0LrZvoXvHM7uJQ+3kVk+EXdh3Xk+dN/+g4V3VcPrWEDXiHRsWG0N2mVILlNl/kLmqmhhc9lqLq8HB455if1MMLdEZVtC46C X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba28c604-f2e6-48c4-cc6d-08db36e509c5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 21:22:34.6140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eZ77ri7ZjipakmmXnHHmrHYCpqPHcyi82YdEJ1NkG/RiyVtWdd2e398sCyFB0Q9M05HvWf/tVCBfcSu5qAVbGGOyAxUmOVvH/YS3D7t+ElY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5090 On 04/04/2023 3:54 pm, Jan Beulich wrote: > Matching what was done earlier, explicit tests are added only for > irregular insn / memory access patterns. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper , with two minor requests. > --- a/tools/misc/xen-cpuid.c > +++ b/tools/misc/xen-cpuid.c > @@ -214,7 +214,7 @@ static const char *const str_7c1[32] = > > static const char *const str_7d1[32] = > { > - [ 4] = "avx-vnni-int8", > + [ 4] = "avx-vnni-int8", [ 5] = "avx-ne-convert", I'd leave a bit more horizontal space.  These names are getting rather long, and we're only 10% into this word. > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -6208,6 +6208,19 @@ x86_emulate( > host_and_vcpu_must_have(avx512_vbmi2); > goto avx512f_no_sae; > > + case X86EMUL_OPC_VEX (0x0f38, 0xb0): /* vcvtneoph2ps mem,[xy]mm */ > + case X86EMUL_OPC_VEX_66(0x0f38, 0xb0): /* vcvtneeph2ps mem,[xy]mm */ > + case X86EMUL_OPC_VEX_F3(0x0f38, 0xb0): /* vcvtneebf162ps mem,[xy]mm */ > + case X86EMUL_OPC_VEX_F2(0x0f38, 0xb0): /* vcvtneobf162ps mem,[xy]mm */ > + generate_exception_if(ea.type != OP_MEM, EXC_UD); > + /* fall through */ Only just occurred to me, but we should probably be using fallthrough; in new code, now there's a real attribute to use. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 06 22:04:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Apr 2023 22:04:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519010.806140 (Exim 4.92) (envelope-from ) id 1pkXi1-0005OQ-EC; Thu, 06 Apr 2023 22:03:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519010.806140; Thu, 06 Apr 2023 22:03:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkXi1-0005OJ-A5; Thu, 06 Apr 2023 22:03:57 +0000 Received: by outflank-mailman (input) for mailman id 519010; Thu, 06 Apr 2023 22:03:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkXi0-0005OD-7j for xen-devel@lists.xenproject.org; Thu, 06 Apr 2023 22:03:56 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e940a5ac-d4c6-11ed-b464-930f4c7d94ae; Fri, 07 Apr 2023 00:03:52 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Apr 2023 18:03:39 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5260.namprd03.prod.outlook.com (2603:10b6:5:246::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 22:03:37 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 22:03:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e940a5ac-d4c6-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680818632; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=22ew3TdBsJAvJYmXneHqEiLeFfBjaF1cF229izoB/Wk=; b=c83lxsot8b7idIMqiDFdtz7CYf/gSwweaFCT4//zNx0n0Ls/J3/ScVxd vsv4j0LIupNy3FhVFCDZXL3yb//6s1XZm0avJGHXooShUKCOEAPskDzU/ oYsqSI942+tJN7K06cLKWDnKckgL7xQzi10YXp+SPvbIVln4OvPJ5OzN6 Q=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 107055567 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LONriqtjJIHCYm/izojw7imfiefnVIZfMUV32f8akzHdYApBsoF/q tZmKW/Ua66OajSnKIx+aty38B8EvpCDytQyGQs/ry49QyoR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOGySFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwNGosdy2MqcaP8JG2ReRtiNQKB5H7BdZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xaLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXnrqM33QPMroAVIEAGDHGf/Pqcs0WBBfRaA Uc+4RMwrpFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsTgYb4t+lvIA6iDrOSMpuFOi+ididMTPtx XaMpSs3hbQWhOYK0bm2+RbMhDfEm3TSZgs85wGSW33/6Ap8PdShf9bwtQCd6utcJoGESFXHp GIDh8WV8OEJC9eKiTCJR+IOWrqu4p5pLQHhvLKmJLF5nxzFxpJpVdo4DO1WTKuxDvs5RA== IronPort-HdrOrdr: A9a23:QGDupazBMF60XE0X39P6KrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-IronPort-AV: E=Sophos;i="5.98,323,1673931600"; d="scan'208";a="107055567" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKJr553KU7bXVVQFWZ/Lof42RDWBPBh6kcPFPh5ux3JAa/vEeIBAbPeJdkGEz6jIEGZcsl00O1spx1z4SNXsWoK9AKcZhgsV+smE7nDyBYuB7U0SBwuAj/GHaCIqJ7+LBO/Xfk11ga23avco7jtzDu/SiXttgRI3Zku6eN94KhfaxeE6yXbWXFhwuHdPDZIey1Fscka2aDFD1cQEmTPtaptTSqdpROrXaHxjRiqtuRaUPknZ11OtmcbYMX0JT4Q/VGyL0wm8eHQCs9YX8Es0zi4S820jNIpzpRmJihoriEkvlJQ70rMPfixpTNaYYUga7+oqnTv6bZddOo42ZrJ2Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7nbgt0HD9hbY8GSlnvGTyg7OhKOvJp4JMkJSv7rMRKA=; b=Cq+d5o/MMMx9YXycIlJr8MMzZC6Cuy5SY1WPE72xvPwktgQj1FOC6CfOsgmF9yvYotHq0HzZIk9f6yfoVeNe5S6MXfRlPbe4XuhOZIPb/GhDI6F4r/gVZdRST4xJrT51l8LfsUAs9VsmABI1JQCpyTy1RbmYFXEUSvSto9bU5MBjfw7Hrg/dCT6VvQoIWl8l8RyfTUc1al36VZmVXBPhxmGKxBYdk86/VkT7qT7+FTVjuGJ7GgbwaW2+egzcgMeTDsUbKxuf1ykGd9RJO0DBeVYStEGAtL+Z6cxQYaKP1scL2Y4+aAUtJluw0JdGZWao4+7oA5z2db2AzqMZLlYcYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7nbgt0HD9hbY8GSlnvGTyg7OhKOvJp4JMkJSv7rMRKA=; b=RUzvXovRcnz39/bijGDJojREk7SBGWOUZBr9VvaPkDmoPiCP9pXTy/lix3uyd7V3otC/I+YLmRCyoicGnb+xkghJSYeOZklgQS9Pb2Av+pjFRDbIYuAdq6Gso/MLxlqPsUfX5j/6IsmAbSjVdjRQsvID6z+M/bJz4PX8KS9Y1pE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1c2cfeec-d64a-3e4b-013a-840f812da12b@citrix.com> Date: Thu, 6 Apr 2023 23:03:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Andrew Cooper Subject: Re: [PATCH 9/9] x86emul+VMX: support {RD,WR}MSRLIST Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0046.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::34) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5260:EE_ X-MS-Office365-Filtering-Correlation-Id: 980e2fdb-114c-4412-ed96-08db36eac585 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 34cwPhEuZB159eksHxWjaRqZL/wrZ/r6Pi/DclVlS/Vy2d0rDDBv2tKk1lq/9z2720rlHjo1s2Gm0T+zmZQFlF8XJXHYweAJKM5p2+2OO9lhi/CXAT24E8IR6Q3z4blhgr8XBYofUrtIVBN+LQkN57A69lYZxGkWqiFSpn253GVHwfMK0HwV/Shy8jwJOMfuHCwkktcN/ertW8fXWMmxKU01A7yBz0qchcu77u7bRcHEyJ2SJoJqvkvAb3V7sRnUfC4ytZS0Lu0F4cQN/Av1ATjJ7rGA4t1ijWTKcNKs7pAj/b8wRaqy7jpPZpphBk5ICYNMMOeNQ+KXc6mNhw3R4moIVGy1mLww3HSOY7KllWAWDBifF+TEDMVttUbZ0xieqc8tCHDxQCI6JBIndyM0nojrRqlV9NNEut8d0JHWFFUrUe1w7xjiOL4Vt4pOSP/mf8O8H72AnoWgKBRH3FHrOmidvMjcfLtU+wzUucaSdYI0uLLVffeBH9v2J1OoSL1o+4rVDivLdotW9HBEt1uGisn/iSfKV2qU0b/rnnuSsDNdC0roQhlnTWNEShq4suVIRE5QN331A2l9cdE1jbqG9mem0dQNVGY3n7jhnofkdIlV+MKTYBEaMJ/Kz/XM5HKoXFw2yq8+8dtEgpATKldtHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199021)(31686004)(478600001)(83380400001)(38100700002)(66476007)(66946007)(66556008)(110136005)(36756003)(41300700001)(6666004)(2616005)(6486002)(5660300002)(316002)(54906003)(31696002)(8936002)(86362001)(53546011)(82960400001)(6506007)(4326008)(6512007)(8676002)(26005)(186003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGlOeWxYb3ltdW15VjJHOG5hVTRvcHdjaFBBY2RVTUxkeThUNXoyYXd6ay96?= =?utf-8?B?VkVoSUFZOSt4azVxTkZ4K0dMd1Jxbk1La1F1ekM1WmlvWlVNRXVKcmxTR3or?= =?utf-8?B?anV0bzRJaTRjTkFRbitnMHdjbjlMTUt5TUh0aGx0TGxSaHpJb0h1Z1NNcWlo?= =?utf-8?B?OVllay9KY3NURDFNQjhsVW82Y1dLcFJyTVVzL2RvKzQ1cm50a0pEeWo5RWFE?= =?utf-8?B?Z2hDSUl4MmU0SGRUK1JZbVpjdVEzN3ptMzNEbDNscCtRaGd4YmJGMDdzb09W?= =?utf-8?B?UExBQUFVN2lFcTNHZTh1NE9FbG5RWlJFVldiWW9XZmxrTFA3dU9YMkpITCto?= =?utf-8?B?QXRXek5KTGRHNUxnZFVMUk5KUWIyUjRMdnAveS9SZ1MrY1NFL0JZT1Y2c3BE?= =?utf-8?B?RWpER3hqYy9WaXlra2pJcG5YNldaUm9qN2tvemlUT1JVSjc1bWtDdHdpbHM4?= =?utf-8?B?RnNtOXdsQzIwbUFSU01hblZGSGxrUU52Mk9TOERZNTI0bDYreUpYRzR4d2Y0?= =?utf-8?B?QW1QNEQ2NklaZzMzMVVxQnkzNFAvOXVkM0grc1lPRVpRVmNacG5FWVdGU3VM?= =?utf-8?B?b2htTW5TTVR0WTRJanhZOHJTQXZJektzOGR1VEpUTWRQRWxqeVhCd2t5ay9j?= =?utf-8?B?K1RQQVZ1TWIvTG9KT1JVOW1JZnViYm5ZdUJ6aGtqMDMvTmx5eEV4YXgyMUQ1?= =?utf-8?B?NGxqcmQyOWdBN200NWc0R3hkYnZKTC9EcllQZjZrSVErbTlQeS80Nk9hcUt2?= =?utf-8?B?cktqaWJIK1lKUmpNNi9WS1U2UmIrMURkV3pHOUJKTUxYN2FyQ3VDeTNSYTJp?= =?utf-8?B?K3lOVFQySCs2ZDgyNlNYVU5mei92Nm91cmduM3htdDEwYnlydFpPelc2YVh3?= =?utf-8?B?UXBvdXd4RStFeHdNa1FqQkM4REc2NkJCTGEvSUZZY2lYekxyVmkxWndBaWVX?= =?utf-8?B?dlFXSCs4aXFnTk95cTMwallCWGNhbkpMQWd3YmpzcXFlWlNJSlpVWUFnRGRn?= =?utf-8?B?VXNMVFR4SHBFVFJTbHkwV2luaU53bU16Yk9KcE10V0NWU2plYTRpWXlGVGxm?= =?utf-8?B?RmFNVTRsWFNWdjlGNlk0eHdZc2ZHTXpJTUI1QU5qOU9ac3U1TkpkSm1sMXNR?= =?utf-8?B?V1NYODVnT25EdG5COEQ2cU1Gc3pEQmNYQnFXbmlDWUVJcm9maDNaY1RXdWk1?= =?utf-8?B?RkJWdUliNzFKL0lOOVpSNmdoY01idGJjMWlIZ21xNU1pYU05Y013dFd6YkxV?= =?utf-8?B?eDhFSFlVcWdsQS9sYlE2ckpmdVdHM000NnFVSWhsZjBRZS83SnpjYTVSZ1h5?= =?utf-8?B?UEkzSVNYYitvQlNOREtFNWtvUCtVUzROekJjbjNNOWE4dFRVM3pwakp1RlZo?= =?utf-8?B?bHpWWGVMeVZmQzVESEFoeUZ6ZFptRXhybU9pOG9ydFJ2YmxCa2pSamNBQ2hv?= =?utf-8?B?ZHlGUmxoSlIrL3haL1FtMGxEVkc1VTZ2TkxVNTlJR2lKMDFCSGI4bi93bkZJ?= =?utf-8?B?dnI5eGlsZldnUytGbHora01JZGVTbXVlc2t0VFhGN29MN3RJMkF2M0l4Z2pz?= =?utf-8?B?eUpDQTRFSVc4YnErQi9WcTBKblEwSVhIaHJEaEhTUWJ5clduZWVub3k2YzBt?= =?utf-8?B?L281U1U3amhyOXhLWjYwVE8yREpHSFBFeFVyd3JBenl4U2phS0s5SWtUa21Q?= =?utf-8?B?SmtRN2huTytsNHoxaGp0cnp0RFRqcUM1cVJDR0ZnVUJFdEtXRVpEMnlTcjl5?= =?utf-8?B?b2FyZmp6Uk9GNVRGelYxTnJ4bW5lMk5LcEE5TUdaY05yTTZXOHZrWS9MUjJC?= =?utf-8?B?UDNJTzJCcG91ejZpQlcrenJkcExQSXU2akxkWTE4ZHJQajZBUDFvMHpUZnZi?= =?utf-8?B?YzJvQWo2VVZzUjI3R3ZSNHFCUnBRTHBHZHV1eWVXaEVVZ1k2cHc5d3ErUzVE?= =?utf-8?B?dktzbWY5SEsyU0J5ZXpXT1pSSDkyaWlCR0RiWUJyRm5VU0RmZkRqVC8zMVYy?= =?utf-8?B?WmljVkM2N0tHd1dadGEvWEZNbmF4NjdHVVdhYXlUSGxVM2dvTysvMkREajJh?= =?utf-8?B?Z0I0Z1pxZmdZVTdialpsZ1VsTFBmSlpCTC8wakJ0V210eCswUmQxdVI5cHdE?= =?utf-8?B?dTViQ1Z0K0srODlzY1lTOWhnTlc5MnhZWVN4M1FwblJRcEMzS3NydGdFak9p?= =?utf-8?B?ZUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hf04QenghfBAMMnlDrmuvFglmFI9FuhvOob8JfcTj9UsB/zrT543XzziQSnSRO96srW2rf3M/lyqflRwlcSMcIJ9xY7G0bO95A1k7tr1uBcPLg2WOeg39eO5khxJE8t7ypzEUPHhLapXHtamVLFe5yPDkJBjZirAV6ewjW2VQrlAT0BwlkF7F+fV/ekZ7QL7EjmKi9++GqGIyS5FfOP5JBRhevNmzUc4LwSaGBOxc/n4bd/ZzeetZfjWjv+NQBFHSrhf+/BkDZjFfS0vo/J0Enzb3e7Nzb5xiPpnkYbZ8xPW6PmIcLsk4dasG2R8IRIBikjkQvYdM58Zk+v207F9k3nUJr6mO4MQYhvUXR8S5MW4soN6xkGNQqRY3fr/sQTP/CtImoxaNAyhmtKjSH5zLxUnf7hRh4YQ9MTWFx49YbF1TLU7kSe4BEEWWiJTER4KGjZmclP6rTRMQUFQv1zlTOFKBASkdGKod+je6KHmizv88INNiWqJaY3NEwvWGZET37dMuJMHwdQUwvjxKC5KtErUZQQrxcLmrTei2aPaplWeduDnyXaNv3+wLoIFwpI9kdyPqUrZDKn4cLzylQImyahQPuabw9bbyQp0JRxgb7J9h3Yo1LtNZPNYbdsIVWaBtvzzyAp6z1jdGqRb7CW5zuOfMnj+SGHKLmV1a3T8CscwHnRcD67bLOCE4+/JsZpUIV2uZPt9ecO3P3RUnDIfUWehTvRdJGCuflBCrfG9csyks9u+Uit2zfT7+YxzkIQ10Cuwy+BsA2y/Q4g9b3UsaotW0OO3ffx4afVQjtB+J7t3S61XI+fWsOJCPCTK+E0tQHqyNOxvNz+PZOEzwZkmK880224i9LuAK9fyRVEk47A= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980e2fdb-114c-4412-ed96-08db36eac585 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 22:03:37.0421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wc6VZU7FY8yiBhj8DJZUxgOmz6MYNZq2xcsGDtNnVu3cpTUw32FFXaQ4w59nnDNWC0RXn+dYgrbbL4fqxQ72evfpvjJj1dT8ORN/0SPouSc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5260 On 04/04/2023 3:55 pm, Jan Beulich wrote: > These are "compound" instructions to issue a series of RDMSR / WRMSR > respectively. In the emulator we can therefore implement them by using > the existing msr_{read,write}() hooks. The memory accesses utilize that > the HVM ->read() / ->write() hooks are already linear-address > (x86_seg_none) aware (by way of hvmemul_virtual_to_linear() handling > this case). > > Signed-off-by: Jan Beulich > --- > TODO: Use VMX tertiary execution control (once bit is known; see > //todo-s) and then further adjust cpufeatureset.h. > > RFC: In vmx_vmexit_handler() handling is forwarded to the emulator > blindly. Alternatively we could consult the exit qualification and > process just a single MSR at a time (without involving the > emulator), exiting back to the guest after every iteration. (I > don't think a mix of both models makes a lot of sense.) {RD,WR}MSRLIST are supposed to be used for context switch paths.  They really shouldn't be exiting in the common case. What matters here is the conditional probability of a second MSR being intercepted too, given that one already has been.  And I don't have a clue how to answer this. I would not expect Introspection to be intercepting a fastpath MSR.  (And if it does, frankly it can live with the consequences.) For future scenarios such as reloading PMU/LBR/whatever, these will be all-or-nothing and we'd expect to have them eagerly in context anyway. If I were going to guess, I'd say that probably MSR_XSS or MSR_SPEC_CTRL will be giving us the most grief here, because they're both ones that are liable to be touched on a context switch path, and have split host/guest bits. > RFC: For PV priv_op_ops would need to gain proper read/write hooks, > which doesn't look desirable (albeit there we could refuse to > handle anything else than x86_seg_none); we may want to consider to > instead not support the feature for PV guests, requiring e.g. Linux > to process the lists in new pvops hooks. Ah - funny you should ask.  See patch 2.  These are even better reasons not to support on PV guests. > RFC: I wasn't sure whether to add preemption checks to the loops - > thoughts? I'd be tempted to.  Mostly because a guest can exert 64* longest MSR worth of pressure here, along with associated emulation overhead. 64* "write hypercall page" sounds expensive.  So too does 64* MSR_PAT, given all the EPT actions behind the scenes. Its probably one of those > With the VMX side of the spec still unclear (tertiary execution control > bit unspecified in ISE 046) we can't enable the insn yet for (HVM) guest > use. The precise behavior of MSR_BARRIER is also not spelled out, so the > (minimal) implementation is a guess for now. MSRs are expensive for several reasons.  The %ecx decode alone isn't cheap, nor is the reserved bit checking, and that's before starting the action itself. What the list form gets you is the ability to pipeline the checks on the following MSR while performing the action of the current one.  I suspect there are plans to try and parallelise the actions too if possible. As I understand it, BARRIER just halts the piplineing of processing the next MSR. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Apr 07 00:13:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 00:13:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519017.806149 (Exim 4.92) (envelope-from ) id 1pkZjM-0001qX-0v; Fri, 07 Apr 2023 00:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519017.806149; Fri, 07 Apr 2023 00:13:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkZjL-0001qQ-UJ; Fri, 07 Apr 2023 00:13:27 +0000 Received: by outflank-mailman (input) for mailman id 519017; Fri, 07 Apr 2023 00:13:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkZjK-0001qG-7s; Fri, 07 Apr 2023 00:13:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkZjK-0003EB-5M; Fri, 07 Apr 2023 00:13:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkZjJ-0002Pd-KS; Fri, 07 Apr 2023 00:13:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkZjJ-0007sE-Jx; Fri, 07 Apr 2023 00:13:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dkmuDh8o+p0bO8kRUlosY5ig20axNyNvwTiHf5J2eQA=; b=0qyR5cAbwmuYQWLnCgA2kBgG+E fjsni2ta+qTItxdQ4RPP2b3HuBbK20PLGE2cwQAKU042zDAG10JAQFOW2PFWZTEPoan027hf4i+U4 24cIugsUdomEqV0RcfzeKeE4JRIvoWhy4VRZIL6O9Q6SjregJxO9YOBr7XTs0UqEoFf8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180168: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt-raw:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b X-Osstest-Versions-That: qemuu=b5fba99ec7969054ab2f3727d2df014b5b72e4f1 From: osstest service owner Date: Fri, 07 Apr 2023 00:13:25 +0000 flight 180168 qemu-mainline real [real] flight 180174 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180168/ http://logs.test-lab.xenproject.org/osstest/logs/180174/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 10 xen-install/src_host fail pass in 180174-retest test-amd64-i386-libvirt-raw 19 guest-start/debian.repeat fail pass in 180174-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180153 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180153 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180153 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180153 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180153 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b baseline version: qemuu b5fba99ec7969054ab2f3727d2df014b5b72e4f1 Last test of basis 180153 2023-04-05 12:38:48 Z 1 days Testing same since 180168 2023-04-06 10:37:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael S. Tsirkin Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git b5fba99ec7..c6f3cbca32 c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Apr 07 04:59:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 04:59:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519025.806160 (Exim 4.92) (envelope-from ) id 1pkeC6-0002qs-Ia; Fri, 07 Apr 2023 04:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519025.806160; Fri, 07 Apr 2023 04:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkeC6-0002ql-DZ; Fri, 07 Apr 2023 04:59:26 +0000 Received: by outflank-mailman (input) for mailman id 519025; Fri, 07 Apr 2023 04:59:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkeC5-0002qb-9t; Fri, 07 Apr 2023 04:59:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkeC5-0000g0-5I; Fri, 07 Apr 2023 04:59:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkeC4-00032O-MI; Fri, 07 Apr 2023 04:59:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkeC4-0000hf-Ju; Fri, 07 Apr 2023 04:59:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A17r9BwFn8tKWcPnBxRaVzrXm191/qaVotDZdHCHaAc=; b=EqLnsqEiW14TNhJ5IRpjfNF4wb 1eOdLoQkho2d4Z2qqXPl3VpHu5EdM2+ilrjdjO3x+MgSj9JgL8X+24boOtLLuQvAJkFjSKqHxQIYW SnFx1jED6MxgvmC0DYPHTiWxfttE6WsgZmO1vILb5ykBido4uPrT7vOrKuNsER00HFYY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180172: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f2afccfefe7be1f7346564fe619277110d341f9b X-Osstest-Versions-That: linux=99ddf2254febae9eab7fb0bcc02c5322243f5c49 From: osstest service owner Date: Fri, 07 Apr 2023 04:59:24 +0000 flight 180172 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180172/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180159 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180159 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180159 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180159 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180159 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f2afccfefe7be1f7346564fe619277110d341f9b baseline version: linux 99ddf2254febae9eab7fb0bcc02c5322243f5c49 Last test of basis 180159 2023-04-05 18:14:53 Z 1 days Testing same since 180172 2023-04-06 19:10:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Amit Pundir Andrea Righi Andy Chi Andy Roulin Anh Tuan Phan Armin Wolf Arnd Bergmann Arseniy Krasnov Bard Liao Ben Greear Benjamin Asbach Bobby Eshleman Boris Brezillon chowtom Christian Brauner Christian König Christian König Corinna Vinschen Daniel Golle Daniel Vetter Daniele Ceraolo Spurio David S. Miller Duy Nguyen Eric Dumazet Eugene Huang Felix Fietkau Frank Wunderlich Ge-org Brohammer Greg Ungerer Guennadi Liakhovetski Guenter Roeck Guillaume Nault Gustav Ekelund Hangbin Liu Hans de Goede Jacek Lawrynowicz Jakub Kicinski Jani Nikula Jason Gunthorpe Jason Montleon Jeremy Soller Jiri Slaby (SUSE) Johannes Berg Junfeng Guo Kalle Valo Kalle Valo Karol Herbst Karol Wachowski Khanh Le Kuninori Morimoto Kuniyuki Iwashima Lai Peter Jun Ann Lingyu Liu Linus Torvalds Lorenzo Bianconi Marc Kleine-Budde Marek Szyprowski Mario Limonciello Mark Brown Mark Pearson Martin Blumenstingl Matthew Auld Michael Sit Wei Hong Michal Sojka Min Li Mirsad Goran Todorovac Oleksij Rempel Oliver Hartkopp Paolo Abeni Pengfei Xu Peter Ujfalusi Pierre-Louis Bossart Rafal Romanowski Ram Kumar Dharuman Ranjani Sridharan Ryder Lee Shahab Vahedi Shailend Chand Shengjiu Wang Shuah Khan Shuangpeng Bai Siddharth Vadapalli Simei Su Song Yoong Siang Sricharan Ramabadhran Srinivas Kandagatla Stanislav Lisovskiy Stanislaw Gruszka Takashi Iwai Thierry Reding Thomas Zimmermann Tim Crawford Tony Nguyen Tvrtko Ursulin Uwe Kleine-König Vladimir Oltean Wojciech Drewek Xin Long Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 99ddf2254feb..f2afccfefe7b f2afccfefe7be1f7346564fe619277110d341f9b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Apr 07 06:13:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 06:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519032.806171 (Exim 4.92) (envelope-from ) id 1pkfLY-0002p6-5D; Fri, 07 Apr 2023 06:13:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519032.806171; Fri, 07 Apr 2023 06:13:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkfLY-0002oz-0X; Fri, 07 Apr 2023 06:13:16 +0000 Received: by outflank-mailman (input) for mailman id 519032; Fri, 07 Apr 2023 06:13:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkfLW-0002op-KR; Fri, 07 Apr 2023 06:13:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkfLW-0002qS-I8; Fri, 07 Apr 2023 06:13:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkfLW-00053Z-8K; Fri, 07 Apr 2023 06:13:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkfLW-0008Dr-7o; Fri, 07 Apr 2023 06:13:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c+I7dqIwebt0T0UMEaeP/okWDXEJV3ElKrkGLAFpFH0=; b=2Xnty8S/E/qJ1q6RDGTAIu0cF7 yM247on3NHUUx9Ku8pKdmrx+38db/GKAb/94f5ifC0V5yE9hPopqC/W0pU1nIoeVuPYU8PxN/UYhx ip554JRqYMswqEOQurlyzTmxC3NbRiFj3HKN11DWXlRhFgY04aK1WVTjOESwVW8tD3IA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180175: all pass - PUSHED X-Osstest-Versions-This: ovmf=cdf6ff1719a9453351baec4bd32fcfc30e9ceeac X-Osstest-Versions-That: ovmf=3e3be2cbc286e773ed5bd3afd5942440546888de From: osstest service owner Date: Fri, 07 Apr 2023 06:13:14 +0000 flight 180175 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180175/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cdf6ff1719a9453351baec4bd32fcfc30e9ceeac baseline version: ovmf 3e3be2cbc286e773ed5bd3afd5942440546888de Last test of basis 180166 2023-04-06 07:10:40 Z 0 days Testing same since 180175 2023-04-07 04:13:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: KasimX Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3e3be2cbc2..cdf6ff1719 cdf6ff1719a9453351baec4bd32fcfc30e9ceeac -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 07 09:39:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 09:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519042.806179 (Exim 4.92) (envelope-from ) id 1pkiYe-0006Uf-T9; Fri, 07 Apr 2023 09:39:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519042.806179; Fri, 07 Apr 2023 09:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkiYe-0006UY-QJ; Fri, 07 Apr 2023 09:39:00 +0000 Received: by outflank-mailman (input) for mailman id 519042; Fri, 07 Apr 2023 09:38:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkiYc-0006UO-Vb; Fri, 07 Apr 2023 09:38:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkiYc-0007j0-Sp; Fri, 07 Apr 2023 09:38:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkiYc-0001bz-BB; Fri, 07 Apr 2023 09:38:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkiYc-0003wX-Am; Fri, 07 Apr 2023 09:38:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kBU11CvgCiTZFmiSNigVtmDugrxRWY2IzDHlVYubW8k=; b=OUUSZCIQeWc0HQHwSVIO5JNDVs YH81h2jQR9pdDrZRP6app6jxQh8TwTQeic48zWfpf1iOJDzjtnK/lcbYEXSlmfSnevj+ERBOmkSEO Z13pYRv0EcC4OiejuAFJguVhr5629DhQQVbNdNzTyKMz5SMjCuRWlVQTSNaOKnMbC6MQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180173: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-multivcpu:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a5087069a8c40541ba81fa0e2850471c949932b3 X-Osstest-Versions-That: xen=881ba20eb0222305a9d2cd090c9345992794f4f5 From: osstest service owner Date: Fri, 07 Apr 2023 09:38:58 +0000 flight 180173 xen-unstable real [real] flight 180177 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180173/ http://logs.test-lab.xenproject.org/osstest/logs/180177/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-multivcpu 20 guest-localmigrate/x10 fail pass in 180177-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180177-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 180163 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180163 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180163 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180163 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180163 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180163 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180163 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180163 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180163 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a5087069a8c40541ba81fa0e2850471c949932b3 baseline version: xen 881ba20eb0222305a9d2cd090c9345992794f4f5 Last test of basis 180163 2023-04-05 23:38:37 Z 1 days Testing same since 180173 2023-04-06 19:49:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 881ba20eb0..a5087069a8 a5087069a8c40541ba81fa0e2850471c949932b3 -> master From xen-devel-bounces@lists.xenproject.org Fri Apr 07 13:16:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 13:16:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519052.806199 (Exim 4.92) (envelope-from ) id 1pklxJ-0002s0-I7; Fri, 07 Apr 2023 13:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519052.806199; Fri, 07 Apr 2023 13:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pklxJ-0002rt-CY; Fri, 07 Apr 2023 13:16:41 +0000 Received: by outflank-mailman (input) for mailman id 519052; Fri, 07 Apr 2023 13:16:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pklxI-0002re-Mb; Fri, 07 Apr 2023 13:16:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pklxI-0004CA-Hy; Fri, 07 Apr 2023 13:16:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pklxI-0004FA-5e; Fri, 07 Apr 2023 13:16:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pklxI-0006PZ-5B; Fri, 07 Apr 2023 13:16:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L7vHLPUamHg7iJFcLXHRa8750KD5bY8BXOp7spSyeZE=; b=XHKFx3tnsutCeYus+nY/ST0rOV nlyDCPCscIXoJO/EvJOXNjvY/nYJhcH5ZbQcLRhYln8rbdtkXcsp4QMB4Qef7w9zxnB3bNgCqHlDS 3jTjBN/so5AKlZD/Clem18e8GXIRHGHd5ZHHz/H8H+9To3Lrss2fL+0mgoK8J+IWMXK4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180176: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=7eead248c65f336afd9fd57ddcfe9e182cf30a6d X-Osstest-Versions-That: libvirt=a56833e47a76e406c62ea0531a99ca199ad5b00a From: osstest service owner Date: Fri, 07 Apr 2023 13:16:40 +0000 flight 180176 libvirt real [real] flight 180179 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180176/ http://logs.test-lab.xenproject.org/osstest/logs/180179/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 180179-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 7eead248c65f336afd9fd57ddcfe9e182cf30a6d baseline version: libvirt a56833e47a76e406c62ea0531a99ca199ad5b00a Last test of basis 180147 2023-04-05 04:18:51 Z 2 days Testing same since 180176 2023-04-07 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ján Tomko Jérémie Tarot Michal Privoznik Pavel Borecki Yang Yulin Yuri Chornoivan 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git a56833e47a..7eead248c6 7eead248c65f336afd9fd57ddcfe9e182cf30a6d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 07 15:26:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 15:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519059.806208 (Exim 4.92) (envelope-from ) id 1pknyE-0007pg-Jx; Fri, 07 Apr 2023 15:25:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519059.806208; Fri, 07 Apr 2023 15:25:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pknyE-0007pZ-H6; Fri, 07 Apr 2023 15:25:46 +0000 Received: by outflank-mailman (input) for mailman id 519059; Fri, 07 Apr 2023 15:25:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pknyD-0007pP-GY; Fri, 07 Apr 2023 15:25:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pknyD-00071O-CH; Fri, 07 Apr 2023 15:25:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pknyC-0000G8-Tc; Fri, 07 Apr 2023 15:25:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pknyC-0003Y4-T2; Fri, 07 Apr 2023 15:25:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ByD4i+VqFUirE9zzFzftvTCEaF5vHCznD5cfuN/FWwE=; b=J5QmbukJ8nQyNvcUO3XqgVGoTv 1kKhNZhHdOJETe3BzaGVLte5s3FrwvSIrMLjGtdisPWqc5rYmTShisZoTz8WlDX1BA2R/cAOK47N9 dnQLXt4J5viNEL2toHVlpEaaYUuChMewflfUcOE+Zbf0iFIGtzLwI+9DEmfk5VwFZTA8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180180: all pass - PUSHED X-Osstest-Versions-This: ovmf=6405cd03048c1850d5047bf66fefa04189a05c94 X-Osstest-Versions-That: ovmf=cdf6ff1719a9453351baec4bd32fcfc30e9ceeac From: osstest service owner Date: Fri, 07 Apr 2023 15:25:44 +0000 flight 180180 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180180/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6405cd03048c1850d5047bf66fefa04189a05c94 baseline version: ovmf cdf6ff1719a9453351baec4bd32fcfc30e9ceeac Last test of basis 180175 2023-04-07 04:13:37 Z 0 days Testing same since 180180 2023-04-07 13:43:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git cdf6ff1719..6405cd0304 6405cd03048c1850d5047bf66fefa04189a05c94 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 07 15:48:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 15:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519066.806223 (Exim 4.92) (envelope-from ) id 1pkoKV-0001tv-O1; Fri, 07 Apr 2023 15:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519066.806223; Fri, 07 Apr 2023 15:48:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKV-0001tG-JD; Fri, 07 Apr 2023 15:48:47 +0000 Received: by outflank-mailman (input) for mailman id 519066; Fri, 07 Apr 2023 15:48:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKU-0001rF-LK for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 15:48:46 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad953bc0-d55b-11ed-85db-49a42c6b2330; Fri, 07 Apr 2023 17:48:45 +0200 (CEST) Received: by mail-lj1-x233.google.com with SMTP id s20so23593292ljp.7 for ; Fri, 07 Apr 2023 08:48:45 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id v12-20020a2e9f4c000000b00295a583a20bsm874765ljk.74.2023.04.07.08.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 08:48:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad953bc0-d55b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680882524; x=1683474524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bvofdso7h4C0wbCuGQpq+8NVtokRUIZ6ky3V3PNneG0=; b=UDjqnxv9yR2iTme8IfxrqJoKtTT30hQa3MiTyTzUHwl68nl1Pg/RDJfQve/u477hyf lkcy8haZp0tzhaVuLFKsyA1honQArutrJbWZz954UQQqOpeE7WQ/eO8dJoHJh2OP78oA p43yE+1vK+VNYdcRlgMOimU+ZWNBeUqBTXgbrjzcAVRBZUu1CCU/5thirqS7DOILUpow ABKPjWDmFHYBhcH8HCYvQBZwvv1Vxyk1hd0sehTQBcsv2Dckr2aQqwkVZBoRCri/f9ma 3kyCh2nskDtgpRY+A+KbKJLHMr7MWfb9GSvh67L1+MgwBfQWZMWfL7By8YkqeKPctRGc pdkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680882524; x=1683474524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bvofdso7h4C0wbCuGQpq+8NVtokRUIZ6ky3V3PNneG0=; b=vDRAlXCCUkc4Te2ROzUpdVqAMmxUbtj2FvPGyDoXytQMoFHn2IXHjgb6eTGr/4tNZw n28C77aQf85vyYZEJy6+t/ZRpMDlvwHY0dVstkXlwI4UDe1N04mPaYEQDrltc2/gILvq mfVU/LS5jypSWnYsOoeJJKfirECK4aS17UQw+/LzRGvs8X6wX6gftsUbXG0djpU6bIGm T+apnjLgCmRC+Gkt6Pd5LJbC2aVoVofuTYcuYWPrpW3r5b6TjBLkZuujblKTpFsiVwSV Ec8pYSy48pDUQM2MMTM76/HdW13hWWWBhy+ocRrwAiCHV3UCPtLUJPbZg04GLQQJRIhk 0o7Q== X-Gm-Message-State: AAQBX9cmEqj/nKBrvoqLHy8RtBWYN81iq9jdSo+u3D2MM8R/uzuJ10d/ F3+/bkSF+RH3i2q7Jo0zi4gOHBBP6UE= X-Google-Smtp-Source: AKy350bLe1FW59P/4vvlykz2DGsyUiixloBEybTWDJDX7QqQWSCeG7bP8ED/tSCAql+uRecHRGgN5w== X-Received: by 2002:a2e:9214:0:b0:29c:9223:2f5e with SMTP id k20-20020a2e9214000000b0029c92232f5emr750160ljg.48.1680882524338; Fri, 07 Apr 2023 08:48:44 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 2/3] xen/riscv: setup initial pagetables Date: Fri, 7 Apr 2023 18:48:38 +0300 Message-Id: <2cbb70c8b29713f1faf235b4a90722d78bf258eb.1680882176.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch does two thing: 1. Setup initial pagetables. 2. Enable MMU which end up with code in cont_after_mmu_is_enabled() Signed-off-by: Oleksii Kurochko --- Changes in V4: - Nothing changed. Only rebase --- Changes in V3: - update the commit message that MMU is also enabled here - remove early_printk("All set up\n") as it was moved to cont_after_mmu_is_enabled() function after MMU is enabled. --- Changes in V2: * Update the commit message --- xen/arch/riscv/setup.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 315804aa87..cf5dc5824e 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -21,7 +21,10 @@ void __init noreturn start_xen(unsigned long bootcpu_id, { early_printk("Hello from C env\n"); - early_printk("All set up\n"); + setup_initial_pagetables(); + + enable_mmu(); + for ( ;; ) asm volatile ("wfi"); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Fri Apr 07 15:48:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 15:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519065.806217 (Exim 4.92) (envelope-from ) id 1pkoKV-0001rX-Ew; Fri, 07 Apr 2023 15:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519065.806217; Fri, 07 Apr 2023 15:48:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKV-0001rQ-C5; Fri, 07 Apr 2023 15:48:47 +0000 Received: by outflank-mailman (input) for mailman id 519065; Fri, 07 Apr 2023 15:48:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKU-0001rE-Hs for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 15:48:46 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad08272b-d55b-11ed-b464-930f4c7d94ae; Fri, 07 Apr 2023 17:48:44 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id a44so25247209ljr.10 for ; Fri, 07 Apr 2023 08:48:44 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id v12-20020a2e9f4c000000b00295a583a20bsm874765ljk.74.2023.04.07.08.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 08:48:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad08272b-d55b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680882523; x=1683474523; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=n5vGzdg5KR3sFgMIx6uCZ4DHW95hzYjHqWeD/lfZZlE=; b=DvyRYkPNMC1FS6LbAG0WIH+w+5ZqtKJkon2VKeUvTeA3MfxSThlGVOFOrMkGX+ibM0 m6EiRv2Buf7bi0hj9PJuW2UTk/BDLLX4HP7HGGGEnPAORpG7AcezXnPdGgW5Dbz6EE23 E/lnMv5uJhrkxImToTWgwDA8LUQee052WQbTxsbk83Z4CcH5jbe6Hg57yJbBEz/oqUrF Y0m8L31CU9FAov86ikTe6OBcZ5DzkEj9e9HM1m5Nhu+r9WYHZ0yM1L51OCJoFjb7KjaJ /flVT5RLe4Vg3xPX5h2B1bXWAuywEBgu9KFzrbu5MTtGjfh1+jgGS/MecoaQWjC+rzjV pBZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680882523; x=1683474523; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n5vGzdg5KR3sFgMIx6uCZ4DHW95hzYjHqWeD/lfZZlE=; b=G74LdkQI6Bow3HCuaGVOE62zVhKVuaaO5r6b7zD211FzBuJ+suWusHuoH4kxAfqrIR ciBuM4rXM1IgFA4lhcAsxfZI3+vL7jx7wY6J1ZsLqTvkhGTvSnVYZkFMABEOSZjP6GI5 yAXBhUkmBi5qR58twSucAGSTgolMUUGHNRl14grGHLagJX/CZVDKWhzjq/7XLHOOFHFq kyBNcNWeTh5ookSpw5G1O1E8BSK9LzItfnhAyOXzKzJ9qXUOYMRE9dAqkUClIrdmDzuk 9dwjSqvcGf4SLn3QyZan2SPf+YqksnFcsgkB6/hDZiJywEbljwpgYF7AMLTo0s03jWsH rZ2g== X-Gm-Message-State: AAQBX9eFOhLDt7Rs7iPj9jmGPv0O6FYeUIr/5qfbx2tFn1qYd9b2eOWo 1tMRI8ma1WClXloxNB05ECDboBUZn6Q= X-Google-Smtp-Source: AKy350YgFmRQ1UTY2zWln2c8Tl1UmqPWJBIhChxvfhk5ZQJuAPi68iEhGpcXUSckFx7SHu+pHMDJBQ== X-Received: by 2002:a2e:97c1:0:b0:29e:a3a0:ee2f with SMTP id m1-20020a2e97c1000000b0029ea3a0ee2fmr649529ljj.30.1680882522804; Fri, 07 Apr 2023 08:48:42 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 0/3] enable MMU for RISC-V Date: Fri, 7 Apr 2023 18:48:36 +0300 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series is based on top patches [1] and [2] The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map link-time to physical-time location. 2. Check that Xen is less then page size. 3. Check that load addresses don't overlap with linker addresses. 4. Prepare things for proper switch to virtual memory world. 5. Load the built page table into the SATP 6. Enable MMU. [1] https://lore.kernel.org/xen-devel/2785518800dce64fafb3096480a5ae4c4e026bcb.1678970065.git.oleksii.kurochko@gmail.com/ [2] https://lore.kernel.org/xen-devel/7c066d6dcc0618749df04785b34b93819148087d.1678970065.git.oleksii.kurochko@gmail.com/ --- Changes in V4: * use GB() macros instead of defining SZ_1G * hardcode XEN_VIRT_START and add comment (ADDRESS_SPACE_END + 1 - GB(1)) * remove unnecessary 'asm' word at the end of #error * encapsulate pte_t definition in a struct * rename addr_to_ppn() to ppn_to_paddr(). * change type of paddr argument from const unsigned long to paddr_t * pte_to_paddr() update prototype. * calculate size of Xen binary based on an amount of page tables * use unsgined int instead of 'uint32_t' instead of uint32_t as their use isn't warranted. * remove extern of bss_{start,end} as they aren't used in mm.c anymore * fix code style * add argument for HANDLE_PGTBL macros instead of curr_lvl_num variable * make enable_mmu() as noinline to prevent under link-time optimization because of the nature of enable_mmu() * add function to check that SATP_MODE is supported. * update the commit message * update setup_initial_pagetables to set correct PTE flags in one pass instead of calling setup_pte_permissions after setup_initial_pagetables() as setup_initial_pagetables() isn't used to change permission flags. --- Changes in V3: * Update the cover letter message: the patch series isn't depend on [ RISC-V basic exception handling implementation ] as it was decied to enable MMU before implementation of exception handling. Also MMU patch series is based on two other patches which weren't merged [1] and [2] - Update the commit message for [ [PATCH v3 1/3] xen/riscv: introduce setup_initial_pages ]. - update definition of pte_t structure to have a proper size of pte_t in case of RV32. - update asm/mm.h with new functions and remove unnecessary 'extern'. - remove LEVEL_* macros as only XEN_PT_LEVEL_* are enough. - update paddr_to_pte() to receive permissions as an argument. - add check that map_start & pa_start is properly aligned. - move defines PAGETABLE_ORDER, PAGETABLE_ENTRIES, PTE_PPN_SHIFT to - Rename PTE_SHIFT to PTE_PPN_SHIFT - refactor setup_initial_pagetables: map all LINK addresses to LOAD addresses and after setup PTEs permission for sections; update check that linker and load addresses don't overlap. - refactor setup_initial_mapping: allocate pagetable 'dynamically' if it is necessary. - rewrite enable_mmu in C; add the check that map_start and pa_start are aligned on 4k boundary. - update the comment for setup_initial_pagetable funcion - Add RV_STAGE1_MODE to support different MMU modes. - update the commit message that MMU is also enabled here - set XEN_VIRT_START very high to not overlap with load address range - align bss section --- Changes in V2: * Remove {ZEROETH,FIRST,...}_{SHIFT,MASK, SIZE,...} and introduce instead of them XEN_PT_LEVEL_*() and LEVEL_* * Rework pt_linear_offset() and pt_index based on XEN_PT_LEVEL_*() * Remove clear_pagetables() functions as pagetables were zeroed during .bss initialization * Rename _setup_initial_pagetables() to setup_initial_mapping() * Make PTE_DEFAULT equal to RX. * Update prototype of setup_initial_mapping(..., bool writable) -> setup_initial_mapping(..., UL flags) * Update calls of setup_initial_mapping according to new prototype * Remove unnecessary call of: _setup_initial_pagetables(..., load_addr_start, load_addr_end, load_addr_start, ...) * Define index* in the loop of setup_initial_mapping * Remove attribute "__attribute__((section(".entry")))" for setup_initial_pagetables() as we don't have such section * make arguments of paddr_to_pte() and pte_is_valid() as const. * use instead of declaring extern unsigned long _stext, 0etext, _srodata, _erodata * update 'extern unsigned long __init_begin' to 'extern unsigned long __init_begin[]' * use aligned() instead of "__attribute__((__aligned__(PAGE_SIZE)))" * set __section(".bss.page_aligned") for page tables arrays * fix identatations * Change '__attribute__((section(".entry")))' to '__init' * Remove alignment of {map, pa}_start &= XEN_PT_LEVEL_MAP_MASK(0); in setup_inital_mapping() as they should be already aligned. * Remove clear_pagetables() as initial pagetables will be zeroed during bss initialization * Remove __attribute__((section(".entry")) for setup_initial_pagetables() as there is no such section in xen.lds.S * Update the argument of pte_is_valid() to "const pte_t *p" * Remove patch "[PATCH v1 3/3] automation: update RISC-V smoke test" from the patch series as it was introduced simplified approach for RISC-V smoke test by Andrew Cooper * Add patch [[xen/riscv: remove dummy_bss variable] as there is no any sense in dummy_bss variable after introduction of inittial page tables. --- Oleksii Kurochko (3): xen/riscv: introduce setup_initial_pages xen/riscv: setup initial pagetables xen/riscv: remove dummy_bss variable xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/config.h | 12 +- xen/arch/riscv/include/asm/mm.h | 9 + xen/arch/riscv/include/asm/page-bits.h | 10 + xen/arch/riscv/include/asm/page.h | 65 +++++ xen/arch/riscv/mm.c | 319 +++++++++++++++++++++++++ xen/arch/riscv/riscv64/head.S | 2 + xen/arch/riscv/setup.c | 22 +- xen/arch/riscv/xen.lds.S | 4 + 9 files changed, 435 insertions(+), 9 deletions(-) create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/mm.c -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Fri Apr 07 15:48:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 15:48:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519068.806242 (Exim 4.92) (envelope-from ) id 1pkoKX-0002Mg-7D; Fri, 07 Apr 2023 15:48:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519068.806242; Fri, 07 Apr 2023 15:48:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKX-0002Ls-1z; Fri, 07 Apr 2023 15:48:49 +0000 Received: by outflank-mailman (input) for mailman id 519068; Fri, 07 Apr 2023 15:48:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKV-0001rF-An for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 15:48:47 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad7100aa-d55b-11ed-85db-49a42c6b2330; Fri, 07 Apr 2023 17:48:45 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id bd22so1726694ljb.5 for ; Fri, 07 Apr 2023 08:48:44 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id v12-20020a2e9f4c000000b00295a583a20bsm874765ljk.74.2023.04.07.08.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 08:48:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad7100aa-d55b-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680882524; x=1683474524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LmPb2JvpArMyMhsNogOHkOdzUdZrOYWvyQ6G5yv0Ex4=; b=Du9Fd7xXhKP5Ec9O6tMgoW2N50Btzk+xQq9lW8JFxZ/x2P+PsDdzMMbkUpzhSS6IaK bEyAV6A7SmEqK5FHXZwfNUr2f7x2IS/U0FUkKjth13iJJYU6FsUnapmHi/ApoCvP4SBj viaa/nUeklzEPMaak0qYM+zXZ1wrKaa7wdtQCVnTC9U0RVxit62/nKCdBK5mHAm7VKMU ayhlGXBvxFYnlzB8XAGcaW5tFkKP7ciP6Z8zE/aiPwi6BWs8q6GFxE4+6qzDXQOJXidS nFih+KlCk5GT4WONIeUJeRX/gG1IF6DU0NhIOK84X350KMuuVmO8nGLBX9O0K8qUqG8I X+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680882524; x=1683474524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LmPb2JvpArMyMhsNogOHkOdzUdZrOYWvyQ6G5yv0Ex4=; b=Ou5wx2qUr9UJZR///L75JIld1txxDsC44atFWMn+F8iG4VSgvYUcLjoWTt6LeSA+9M 283m6VUFlBbPuqP4dmVDVaEf4QOURLfhzX9zDrB4+IgV6wVL78I0mqklJUYbLnfGLr/O 2+fnOpIypFlOIFbXgjq7MJgDfrjGUhRZBf2Nv5YQWwnzhFyQe+rbSsQHd9QYvd6ZRoLI tnyvYKAQ0FSdjINKEcOjnMzDBC6Ukgbf0aGJwMtwJ841p4a4TkAtUuaDVkH4VF6QWntq PFeRQk6joQnOMa1BlC4iJjfZO1lyoxsa7n6OcGMxVHhfSPe9lchaLr3XF4riV/gsSZt/ dnHQ== X-Gm-Message-State: AAQBX9c6NYaQnPdvUd532BUU+Qd7VaVCt4QyslKKuAcRafhvDEgV5IkO lWtFY90PRMqaQw/pwS8A+F0hJoQs1eg= X-Google-Smtp-Source: AKy350ZWfsrVbxSNagZoTRjLwxe5AJ9ycaTov9PXA5oVeOpvcWSZ3SsT7pnbDsGhGlaKl/LEna51nw== X-Received: by 2002:a2e:9698:0:b0:298:b045:af96 with SMTP id q24-20020a2e9698000000b00298b045af96mr695028lji.9.1680882523577; Fri, 07 Apr 2023 08:48:43 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 1/3] xen/riscv: introduce setup_initial_pages Date: Fri, 7 Apr 2023 18:48:37 +0300 Message-Id: <50ed83073ccb440fb651070de8b0abebd3888b43.1680882176.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The idea was taken from xvisor but the following changes were done: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add an argument for setup_initial_mapping to have an opportunity to make set PTE flags. * update setup_initial_pagetables function to map sections with correct PTE flags. * Rewrite enable_mmu() to C. * map linker addresses range to load addresses range without 1:1 mapping. It will be 1:1 only in case when load_start_addr is equal to linker_start_addr. * add safety checks such as: * Xen size is less than page size * linker addresses range doesn't overlap load addresses range * Rework macros {THIRD,SECOND,FIRST,ZEROETH}_{SHIFT,MASK} * change PTE_LEAF_DEFAULT to RW instead of RWX. * Remove phys_offset as it is not used now * Remove alignment of {map, pa}_start &= XEN_PT_LEVEL_MAP_MASK(0); in setup_inital_mapping() as they should be already aligned. Make a check that {map_pa}_start are aligned. * Remove clear_pagetables() as initial pagetables will be zeroed during bss initialization * Remove __attribute__((section(".entry")) for setup_initial_pagetables() as there is no such section in xen.lds.S * Update the argument of pte_is_valid() to "const pte_t *p" * Add check that Xen's load address is aligned at 4k boundary * Refactor setup_initial_pagetables() so it is mapping linker address range to load address range. After setup needed permissions for specific section ( such as .text, .rodata, etc ) otherwise RW permission will be set by default. * Add function to check that requested SATP_MODE is supported Origin: git@github.com:xvisor/xvisor.git 9be2fdd7 Signed-off-by: Oleksii Kurochko --- Changes in V4: * use GB() macros instead of defining SZ_1G * hardcode XEN_VIRT_START and add comment (ADDRESS_SPACE_END + 1 - GB(1)) * remove unnecessary 'asm' word at the end of #error * encapsulate pte_t definition in a struct * rename addr_to_ppn() to ppn_to_paddr(). * change type of paddr argument from const unsigned long to paddr_t * pte_to_paddr() update prototype. * calculate size of Xen binary based on an amount of page tables * use unsgined int instead of 'uint32_t' instead of uint32_t as their use isn't warranted. * remove extern of bss_{start,end} as they aren't used in mm.c anymore * fix code style * add argument for HANDLE_PGTBL macros instead of curr_lvl_num variable * make enable_mmu() as noinline to prevent under link-time optimization because of the nature of enable_mmu() * add function to check that SATP_MODE is supported. * update the commit message * update setup_initial_pagetables to set correct PTE flags in one pass instead of calling setup_pte_permissions after setup_initial_pagetables() as setup_initial_pagetables() isn't used to change permission flags. --- Changes in V3: - update definition of pte_t structure to have a proper size of pte_t in case of RV32. - update asm/mm.h with new functions and remove unnecessary 'extern'. - remove LEVEL_* macros as only XEN_PT_LEVEL_* are enough. - update paddr_to_pte() to receive permissions as an argument. - add check that map_start & pa_start is properly aligned. - move defines PAGETABLE_ORDER, PAGETABLE_ENTRIES, PTE_PPN_SHIFT to - Rename PTE_SHIFT to PTE_PPN_SHIFT - refactor setup_initial_pagetables: map all LINK addresses to LOAD addresses and after setup PTEs permission for sections; update check that linker and load addresses don't overlap. - refactor setup_initial_mapping: allocate pagetable 'dynamically' if it is necessary. - rewrite enable_mmu in C; add the check that map_start and pa_start are aligned on 4k boundary. - update the comment for setup_initial_pagetable funcion - Add RV_STAGE1_MODE to support different MMU modes - set XEN_VIRT_START very high to not overlap with load address range - align bss section --- Changes in V2: * update the commit message: * Remove {ZEROETH,FIRST,...}_{SHIFT,MASK, SIZE,...} and introduce instead of them XEN_PT_LEVEL_*() and LEVEL_* * Rework pt_linear_offset() and pt_index based on XEN_PT_LEVEL_*() * Remove clear_pagetables() functions as pagetables were zeroed during .bss initialization * Rename _setup_initial_pagetables() to setup_initial_mapping() * Make PTE_DEFAULT equal to RX. * Update prototype of setup_initial_mapping(..., bool writable) -> setup_initial_mapping(..., UL flags) * Update calls of setup_initial_mapping according to new prototype * Remove unnecessary call of: _setup_initial_pagetables(..., load_addr_start, load_addr_end, load_addr_start, ...) * Define index* in the loop of setup_initial_mapping * Remove attribute "__attribute__((section(".entry")))" for setup_initial_pagetables() as we don't have such section * make arguments of paddr_to_pte() and pte_is_valid() as const. * make xen_second_pagetable static. * use instead of declaring extern unsigned long _stext, 0etext, _srodata, _erodata * update 'extern unsigned long __init_begin' to 'extern unsigned long __init_begin[]' * use aligned() instead of "__attribute__((__aligned__(PAGE_SIZE)))" * set __section(".bss.page_aligned") for page tables arrays * fix identatations * Change '__attribute__((section(".entry")))' to '__init' * Remove phys_offset as it isn't used now. * Remove alignment of {map, pa}_start &= XEN_PT_LEVEL_MAP_MASK(0); in setup_inital_mapping() as they should be already aligned. * Remove clear_pagetables() as initial pagetables will be zeroed during bss initialization * Remove __attribute__((section(".entry")) for setup_initial_pagetables() as there is no such section in xen.lds.S * Update the argument of pte_is_valid() to "const pte_t *p" --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/config.h | 12 +- xen/arch/riscv/include/asm/mm.h | 9 + xen/arch/riscv/include/asm/page-bits.h | 10 + xen/arch/riscv/include/asm/page.h | 65 +++++ xen/arch/riscv/mm.c | 319 +++++++++++++++++++++++++ xen/arch/riscv/riscv64/head.S | 2 + xen/arch/riscv/setup.c | 11 + xen/arch/riscv/xen.lds.S | 4 + 9 files changed, 432 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/mm.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 443f6bf15f..956ceb02df 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += entry.o +obj-y += mm.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index 763a922a04..0cf9673558 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -39,12 +39,22 @@ name: #endif -#define XEN_VIRT_START _AT(UL, 0x80200000) +#ifdef CONFIG_RISCV_64 +#define XEN_VIRT_START 0xFFFFFFFFC0000000 /* (_AC(-1, UL) + 1 - GB(1)) */ +#else +#error "RV32 isn't supported" +#endif #define SMP_CACHE_BYTES (1 << 6) #define STACK_SIZE PAGE_SIZE +#ifdef CONFIG_RISCV_64 +#define RV_STAGE1_MODE SATP_MODE_SV39 +#else +#define RV_STAGE1_MODE SATP_MODE_SV32 +#endif + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h new file mode 100644 index 0000000000..e16ce66fae --- /dev/null +++ b/xen/arch/riscv/include/asm/mm.h @@ -0,0 +1,9 @@ +#ifndef _ASM_RISCV_MM_H +#define _ASM_RISCV_MM_H + +void setup_initial_pagetables(void); + +void enable_mmu(void); +void cont_after_mmu_is_enabled(void); + +#endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/include/asm/page-bits.h b/xen/arch/riscv/include/asm/page-bits.h index 1801820294..0879a527f2 100644 --- a/xen/arch/riscv/include/asm/page-bits.h +++ b/xen/arch/riscv/include/asm/page-bits.h @@ -1,6 +1,16 @@ #ifndef __RISCV_PAGE_BITS_H__ #define __RISCV_PAGE_BITS_H__ +#ifdef CONFIG_RISCV_64 +#define PAGETABLE_ORDER (9) +#else /* CONFIG_RISCV_32 */ +#define PAGETABLE_ORDER (10) +#endif + +#define PAGETABLE_ENTRIES (1 << PAGETABLE_ORDER) + +#define PTE_PPN_SHIFT 10 + #define PAGE_SHIFT 12 /* 4 KiB Pages */ #define PADDR_BITS 56 /* 44-bit PPN */ diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h new file mode 100644 index 0000000000..30406aa614 --- /dev/null +++ b/xen/arch/riscv/include/asm/page.h @@ -0,0 +1,65 @@ +#ifndef _ASM_RISCV_PAGE_H +#define _ASM_RISCV_PAGE_H + +#include +#include + +#define VPN_MASK ((unsigned long)(PAGETABLE_ENTRIES - 1)) + +#define XEN_PT_LEVEL_ORDER(lvl) ((lvl) * PAGETABLE_ORDER) +#define XEN_PT_LEVEL_SHIFT(lvl) (XEN_PT_LEVEL_ORDER(lvl) + PAGE_SHIFT) +#define XEN_PT_LEVEL_SIZE(lvl) (_AT(paddr_t, 1) << XEN_PT_LEVEL_SHIFT(lvl)) +#define XEN_PT_LEVEL_MAP_MASK(lvl) (~(XEN_PT_LEVEL_SIZE(lvl) - 1)) +#define XEN_PT_LEVEL_MASK(lvl) (VPN_MASK << XEN_PT_LEVEL_SHIFT(lvl)) + +#define PTE_VALID BIT(0, UL) +#define PTE_READABLE BIT(1, UL) +#define PTE_WRITABLE BIT(2, UL) +#define PTE_EXECUTABLE BIT(3, UL) +#define PTE_USER BIT(4, UL) +#define PTE_GLOBAL BIT(5, UL) +#define PTE_ACCESSED BIT(6, UL) +#define PTE_DIRTY BIT(7, UL) +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) + +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE) +#define PTE_TABLE (PTE_VALID) + +/* Calculate the offsets into the pagetables for a given VA */ +#define pt_linear_offset(lvl, va) ((va) >> XEN_PT_LEVEL_SHIFT(lvl)) + +#define pt_index(lvl, va) pt_linear_offset(lvl, (va) & XEN_PT_LEVEL_MASK(lvl)) + +/* Page Table entry */ +typedef struct { +#ifdef CONFIG_RISCV_64 +uint64_t pte; +#else +uint32_t pte; +#endif +} pte_t; + +#define addr_to_pte(x) (((x) >> PTE_PPN_SHIFT) << PAGE_SHIFT) + +/* Shift the VPN[x] or PPN[x] fields of a virtual or physical address + * to become the shifted PPN[x] fields of a page table entry */ +#define ppn_to_paddr(x) (((x) >> PAGE_SHIFT) << PTE_PPN_SHIFT) + +static inline pte_t paddr_to_pte(const paddr_t paddr, + const unsigned long permissions) +{ + unsigned long tmp = ppn_to_paddr(paddr); + return (pte_t) { .pte = tmp | permissions }; +} + +static inline paddr_t pte_to_paddr(const pte_t pte) +{ + return addr_to_pte(pte.pte); +} + +static inline bool pte_is_valid(const pte_t p) +{ + return p.pte & PTE_VALID; +} + +#endif /* _ASM_RISCV_PAGE_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c new file mode 100644 index 0000000000..43b7181c33 --- /dev/null +++ b/xen/arch/riscv/mm.c @@ -0,0 +1,319 @@ +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +struct mmu_desc { + unsigned long num_levels; + unsigned int pgtbl_count; + pte_t *next_pgtbl; + pte_t *pgtbl_base; +}; + +extern unsigned char cpu0_boot_stack[STACK_SIZE]; + +#define PHYS_OFFSET ((unsigned long)_start - XEN_VIRT_START) +#define LOAD_TO_LINK(addr) ((addr) - PHYS_OFFSET) +#define LINK_TO_LOAD(addr) ((addr) + PHYS_OFFSET) + + +/* + * It is expected that Xen won't be more then 2 MB. + * The check in xen.lds.S guarantees that. + * At least 4 page (in case when Sv48 or Sv57 are used ) + * tables are needed to cover 2 MB. One for each page level + * table with PAGE_SIZE = 4 Kb + * + * One L0 page table can cover 2 MB + * (512 entries of one page table * PAGE_SIZE). + * + * It might be needed one more page table in case when + * Xen load address isn't 2 MB aligned. + * + */ +#define PGTBL_INITIAL_COUNT (5) + +#define PGTBL_ENTRY_AMOUNT (PAGE_SIZE / sizeof(pte_t)) + +pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) +stage1_pgtbl_root[PGTBL_ENTRY_AMOUNT]; + +pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) +stage1_pgtbl_nonroot[PGTBL_INITIAL_COUNT * PGTBL_ENTRY_AMOUNT]; + +#define HANDLE_PGTBL(curr_lvl_num) \ + index = pt_index(curr_lvl_num, page_addr); \ + if ( pte_is_valid(pgtbl[index]) ) \ + { \ + /* Find L{ 0-3 } table */ \ + pgtbl = (pte_t *)pte_to_paddr(pgtbl[index]); \ + } \ + else \ + { \ + /* Allocate new L{0-3} page table */ \ + if ( mmu_desc->pgtbl_count == PGTBL_INITIAL_COUNT ) \ + { \ + early_printk("(XEN) No initial table available\n"); \ + /* panic(), BUG() or ASSERT() aren't ready now. */ \ + die(); \ + } \ + mmu_desc->pgtbl_count++; \ + pgtbl[index] = paddr_to_pte((unsigned long)mmu_desc->next_pgtbl, \ + PTE_VALID); \ + pgtbl = mmu_desc->next_pgtbl; \ + mmu_desc->next_pgtbl += PGTBL_ENTRY_AMOUNT; \ + } + +static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, + unsigned long map_start, + unsigned long map_end, + unsigned long pa_start, + unsigned long permissions) +{ + unsigned int index; + pte_t *pgtbl; + unsigned long page_addr; + pte_t pte_to_be_written; + unsigned long paddr; + unsigned long tmp_permissions; + + if ( (unsigned long)_start % XEN_PT_LEVEL_SIZE(0) ) + { + early_printk("(XEN) Xen should be loaded at 4k boundary\n"); + die(); + } + + if ( map_start & ~XEN_PT_LEVEL_MAP_MASK(0) || + pa_start & ~XEN_PT_LEVEL_MAP_MASK(0) ) + { + early_printk("(XEN) map and pa start addresses should be aligned\n"); + /* panic(), BUG() or ASSERT() aren't ready now. */ + die(); + } + + page_addr = map_start; + while ( page_addr < map_end ) + { + pgtbl = mmu_desc->pgtbl_base; + + switch (mmu_desc->num_levels) + { + case 4: /* Level 3 */ + HANDLE_PGTBL(3); + case 3: /* Level 2 */ + HANDLE_PGTBL(2); + case 2: /* Level 1 */ + HANDLE_PGTBL(1); + case 1: /* Level 0 */ + index = pt_index(0, page_addr); + paddr = (page_addr - map_start) + pa_start; + + tmp_permissions = permissions; + + if ( is_kernel_text(LINK_TO_LOAD(page_addr)) || + is_kernel_inittext(LINK_TO_LOAD(page_addr)) ) + tmp_permissions = + PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; + + if ( is_kernel_rodata(LINK_TO_LOAD(page_addr)) ) + tmp_permissions = PTE_READABLE | PTE_VALID; + + pte_to_be_written = paddr_to_pte(paddr, tmp_permissions); + + if ( !pte_is_valid(pgtbl[index]) ) + pgtbl[index] = pte_to_be_written; + else + { + /* + * get an adresses of current pte and that one to + * be written without permission flags + */ + unsigned long curr_pte = + pgtbl[index].pte & ~((1 << PTE_PPN_SHIFT) - 1); + + pte_to_be_written.pte &= ~((1 << PTE_PPN_SHIFT) - 1); + + if ( curr_pte != pte_to_be_written.pte ) + { + early_printk("PTE that is intended to write isn't the" + "same that the once are overwriting\n"); + /* panic(), aren't ready now. */ + die(); + } + } + } + + /* Point to next page */ + page_addr += XEN_PT_LEVEL_SIZE(0); + } +} + +static void __init calc_pgtbl_lvls_num(struct mmu_desc *mmu_desc) +{ + unsigned long satp_mode = RV_STAGE1_MODE; + + /* Number of page table levels */ + switch (satp_mode) + { + case SATP_MODE_SV32: + mmu_desc->num_levels = 2; + break; + case SATP_MODE_SV39: + mmu_desc->num_levels = 3; + break; + case SATP_MODE_SV48: + mmu_desc->num_levels = 4; + break; + default: + early_printk("(XEN) Unsupported SATP_MODE\n"); + die(); + } +} + +static bool __init check_pgtbl_mode_support(struct mmu_desc *mmu_desc, + unsigned long load_start, + unsigned long satp_mode) +{ + bool is_mode_supported = false; + unsigned int index; + unsigned int page_table_level = (mmu_desc->num_levels - 1); + unsigned level_map_mask = XEN_PT_LEVEL_MAP_MASK(page_table_level); + + unsigned long aligned_load_start = load_start & level_map_mask; + unsigned long aligned_page_size = XEN_PT_LEVEL_SIZE(page_table_level); + unsigned long xen_size = (unsigned long)(_end - start); + + if ( (load_start + xen_size) > (aligned_load_start + aligned_page_size) ) + { + early_printk("please place Xen to be in range of PAGE_SIZE " + "where PAGE_SIZE is XEN_PT_LEVEL_SIZE( {L3 | L2 | L1} ) " + "depending on expected SATP_MODE \n" + "XEN_PT_LEVEL_SIZE is defined in \n"); + die(); + } + + index = pt_index(page_table_level, aligned_load_start); + stage1_pgtbl_root[index] = paddr_to_pte(aligned_load_start, + PTE_LEAF_DEFAULT | PTE_EXECUTABLE); + + asm volatile("sfence.vma"); + csr_write(CSR_SATP, + ((unsigned long)stage1_pgtbl_root >> PAGE_SHIFT) | + satp_mode << SATP_MODE_SHIFT); + + if ( (csr_read(CSR_SATP) >> SATP_MODE_SHIFT) == satp_mode ) + is_mode_supported = true; + + /* Clean MMU root page table and disable MMU */ + stage1_pgtbl_root[index] = paddr_to_pte(0x0, 0x0); + + csr_write(CSR_SATP, 0); + asm volatile("sfence.vma"); + + return is_mode_supported; +} + +/* + * setup_initial_pagetables: + * + * Build the page tables for Xen that map the following: + * 1. Calculate page table's level numbers. + * 2. Init mmu description structure. + * 3. Check that linker addresses range doesn't overlap + * with load addresses range + * 4. Map all linker addresses and load addresses ( it shouldn't + * be 1:1 mapped and will be 1:1 mapped only in case if + * linker address is equal to load address ) with + * RW permissions by default. + * 5. Setup proper PTE permissions for each section. + */ +void __init setup_initial_pagetables(void) +{ + struct mmu_desc mmu_desc = { 0, 0, NULL, 0 }; + + /* + * Access to _{stard, end } is always PC-relative + * thereby when access them we will get load adresses + * of start and end of Xen + * To get linker addresses LOAD_TO_LINK() is required + * to use + */ + unsigned long load_start = (unsigned long)_start; + unsigned long load_end = (unsigned long)_end; + unsigned long linker_start = LOAD_TO_LINK(load_start); + unsigned long linker_end = LOAD_TO_LINK(load_end); + + if ( (linker_start != load_start) && + (linker_start <= load_end) && (load_start <= linker_end) ) { + early_printk("(XEN) linker and load address ranges overlap\n"); + die(); + } + + calc_pgtbl_lvls_num(&mmu_desc); + + if ( !check_pgtbl_mode_support(&mmu_desc, load_start, RV_STAGE1_MODE) ) + { + early_printk("requested MMU mode isn't supported by CPU\n" + "Please choose different in \n"); + die(); + } + + mmu_desc.pgtbl_base = stage1_pgtbl_root; + mmu_desc.next_pgtbl = stage1_pgtbl_nonroot; + + setup_initial_mapping(&mmu_desc, + linker_start, + linker_end, + load_start, + PTE_LEAF_DEFAULT); +} + +void __init noinline enable_mmu() +{ + /* + * Calculate a linker time address of the mmu_is_enabled + * label and update CSR_STVEC with it. + * MMU is configured in a way where linker addresses are mapped + * on load addresses so in a case when linker addresses are not equal + * to load addresses, after MMU is enabled, it will cause + * an exception and jump to linker time addresses. + * Otherwise if load addresses are equal to linker addresses the code + * after mmu_is_enabled label will be executed without exception. + */ + csr_write(CSR_STVEC, LOAD_TO_LINK((unsigned long)&&mmu_is_enabled)); + + /* Ensure page table writes precede loading the SATP */ + asm volatile("sfence.vma"); + + /* Enable the MMU and load the new pagetable for Xen */ + csr_write(CSR_SATP, + ((unsigned long)stage1_pgtbl_root >> PAGE_SHIFT) | + RV_STAGE1_MODE << SATP_MODE_SHIFT); + + asm volatile(".align 2"); + mmu_is_enabled: + /* + * Stack should be re-inited as: + * 1. Right now an address of the stack is relative to load time + * addresses what will cause an issue in case of load start address + * isn't equal to linker start address. + * 2. Addresses in stack are all load time relative which can be an + * issue in case when load start address isn't equal to linker + * start address. + */ + asm volatile ("mv sp, %0" : : "r"((unsigned long)cpu0_boot_stack + STACK_SIZE)); + + /* + * We can't return to the caller because the stack was reseted + * and it may have stash some variable on the stack. + * Jump to a brand new function as the stack was reseted + */ + cont_after_mmu_is_enabled(); +} + diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 8887f0cbd4..b3309d902c 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,4 +1,5 @@ #include +#include #include .section .text.header, "ax", %progbits @@ -32,3 +33,4 @@ ENTRY(start) add sp, sp, t0 tail start_xen + diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 3786f337e0..315804aa87 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -2,6 +2,7 @@ #include #include +#include /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] @@ -26,3 +27,13 @@ void __init noreturn start_xen(unsigned long bootcpu_id, unreachable(); } + +void __init noreturn cont_after_mmu_is_enabled(void) +{ + early_printk("All set up\n"); + + for ( ;; ) + asm volatile ("wfi"); + + unreachable(); +} diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index f299ea8422..e00b5c803a 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -136,6 +136,7 @@ SECTIONS . = ALIGN(POINTER_ALIGN); __init_end = .; + . = ALIGN(PAGE_SIZE); .bss : { /* BSS */ __bss_start = .; *(.bss.stack_aligned) @@ -169,3 +170,6 @@ SECTIONS ASSERT(!SIZEOF(.got), ".got non-empty") ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") + +ASSERT(_end - _start <= MB(2), "Xen too large for early-boot assumptions") + -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Fri Apr 07 15:48:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 15:48:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519067.806238 (Exim 4.92) (envelope-from ) id 1pkoKW-0002LD-Us; Fri, 07 Apr 2023 15:48:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519067.806238; Fri, 07 Apr 2023 15:48:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKW-0002L6-Ql; Fri, 07 Apr 2023 15:48:48 +0000 Received: by outflank-mailman (input) for mailman id 519067; Fri, 07 Apr 2023 15:48:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkoKV-0001rE-9T for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 15:48:47 +0000 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [2a00:1450:4864:20::22b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae10e726-d55b-11ed-b464-930f4c7d94ae; Fri, 07 Apr 2023 17:48:45 +0200 (CEST) Received: by mail-lj1-x22b.google.com with SMTP id s20so23593326ljp.7 for ; Fri, 07 Apr 2023 08:48:45 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id v12-20020a2e9f4c000000b00295a583a20bsm874765ljk.74.2023.04.07.08.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 08:48:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae10e726-d55b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680882525; x=1683474525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dR16O0lugGTgYXlwGY6UhsQKrRSYw0CGkPTToCj++Ug=; b=WNtfsY4gAIKeRRXFCMruuMW9ZmEahyFB2wL7ubeBg+g9lGealukXMDfhRE1Y8sDvr1 XKpW8xy5x7dKsTnjBzJS9Th7BV7Y2rc5yvDVY4IsrCaRjqCRdzDm3hlymk4pJQN8JBO6 jF+ZvJivr55eMmvEhZhgP5sZ4tpik0pNAIeJ8ApqjKGIG3YEROX3SUxvwo+W2Ncg+QPK Or+Ws0WpsQ4fUmVsn0pUnxU2Zca34uwq2J16MO6bdpgjboqcJAf+zyznCgs1fssWos7B fUgtreelqzzAqy+Fgnqcq2al94r4uQMOmh5Dof4DmeOi1q5x5jyDqYlGNra3kfcEqB3a MhRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680882525; x=1683474525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dR16O0lugGTgYXlwGY6UhsQKrRSYw0CGkPTToCj++Ug=; b=QzowfV09XlT4N7tuOWoTu1TCATz56kWehqiRKabg89IBOxtRZxNZWeKD1q/qSNJ3NI 8+N0tHIxzZEZnUmJG92Ymg+KNhv0XoaA60mDSe1F4rInbBWXyWoPAouE8RQZEdT/nJ4k IiegWpEBXDr/j7h3mFAEr97+q3dhj5jr6DvVYZorrTEw5LCSvRLyWkls/FbRrSmrCCT/ N+AsHewZJdGo/hgMW56CuFYbF0sb2ssam0DLIfttwdt8x1EDSgRx08/jahLPrGT2/arz E7EryCpKNGKWUd5bmSbEuh8sy1S/S7YRrVmZmyvbTheXfRLDSSuzzvVzLYDIyfhJJk0w 2clA== X-Gm-Message-State: AAQBX9fcB+5W5U69V3EZD91GPZLuutfiBM5w2OmcIsvRdYJG2fESAEMu LQluQ3TLqCs2M9HzV9COyHXyMoeOWH8= X-Google-Smtp-Source: AKy350bkZK1Y1VW7X1oCiqKF1QUHOQQXqi85UO/S8xap3BZ/klg3do3at0JUwxjNXS5JlXSehm7jmA== X-Received: by 2002:a2e:9dc7:0:b0:298:39f9:fb2f with SMTP id x7-20020a2e9dc7000000b0029839f9fb2fmr532236ljj.31.1680882525256; Fri, 07 Apr 2023 08:48:45 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 3/3] xen/riscv: remove dummy_bss variable Date: Fri, 7 Apr 2023 18:48:39 +0300 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit After introduction of initial pagetables there is no any sense in dummy_bss variable as bss section will not be empty anymore. Signed-off-by: Oleksii Kurochko --- Changes in V4: - Nothing changed. Only rebase --- Changes in V3: * patch was introduced in the current one patch series (v3). --- Changes in V2: * patch was introduced in the current one patch series (v2). --- xen/arch/riscv/setup.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index cf5dc5824e..845d18d86f 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -8,14 +8,6 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); -/* - * To be sure that .bss isn't zero. It will simplify code of - * .bss initialization. - * TODO: - * To be deleted when the first real .bss user appears - */ -int dummy_bss __attribute__((unused)); - void __init noreturn start_xen(unsigned long bootcpu_id, paddr_t dtb_addr) { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Fri Apr 07 17:37:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 17:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519082.806258 (Exim 4.92) (envelope-from ) id 1pkq1S-0006Zh-5w; Fri, 07 Apr 2023 17:37:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519082.806258; Fri, 07 Apr 2023 17:37:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkq1S-0006Za-2X; Fri, 07 Apr 2023 17:37:14 +0000 Received: by outflank-mailman (input) for mailman id 519082; Fri, 07 Apr 2023 17:37:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkq1Q-0006ZQ-DT; Fri, 07 Apr 2023 17:37:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkq1Q-0002Qo-6h; Fri, 07 Apr 2023 17:37:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkq1P-0004Kf-IS; Fri, 07 Apr 2023 17:37:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkq1P-0000e5-I2; Fri, 07 Apr 2023 17:37:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gJ178f9Rtg6w0oQEQ2AbLo5BNPP1OlPYRar4f2nqo6g=; b=0juSwlsU1UV6XD5kzVE64UpnmW JfDHfBSDqmFRKtWkwmdgnr7dR6VElvYVmQEN+9/opVuThnBO2taB0tTqQakWEj5HdNj1ccAh+108/ xnYjTgugfqmLqbOM+YiwMwG2jf2Vd3M55nmwbK9rP4dzFZQmVlLwppDGkGhATj+NRQjY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180178: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-credit2::broken:regression xen-unstable:test-amd64-amd64-xl-credit2:capture-logs(26):broken:regression xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:regression xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=a5087069a8c40541ba81fa0e2850471c949932b3 From: osstest service owner Date: Fri, 07 Apr 2023 17:37:11 +0000 flight 180178 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180178/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken test-amd64-amd64-xl-credit2 26 capture-logs(26) broken REGR. vs. 180173 test-amd64-i386-examine-uefi 6 xen-install fail REGR. vs. 180173 test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 180173 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 180173 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180173 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180173 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen a5087069a8c40541ba81fa0e2850471c949932b3 Last test of basis 180173 2023-04-06 19:49:58 Z 0 days Testing same since 180178 2023-04-07 09:41:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken broken-step test-amd64-amd64-xl-credit2 capture-logs(26) Not pushing. ------------------------------------------------------------ commit ddaf7bb0cfd27369252de52e4b03410c4065bad2 Author: Andrew Cooper Date: Fri Mar 17 11:10:06 2023 +0000 x86/svm: Provide EXITINFO decodes for Exceptions/NPF intercepts Exceptions and NPF intercepts almost have the same layout, but NPF has bits above 31 in the error code, and the name for exitinfo2 really does want distinguishing between cr2 and gpa. In nsvm_vcpu_vmexit_inject() rearrange VMEXIT_NPF to fall through instead of repeating the exitinfo1 write. Use the fallthrough pseudo keyword instead of a comment. In VMEXIT_NPF, as we're editing the printk() anyway, switch to using the newer domain_crash() form. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Apr 07 21:33:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 21:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519089.806268 (Exim 4.92) (envelope-from ) id 1pkthr-0004tO-4g; Fri, 07 Apr 2023 21:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519089.806268; Fri, 07 Apr 2023 21:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkthr-0004tH-0T; Fri, 07 Apr 2023 21:33:15 +0000 Received: by outflank-mailman (input) for mailman id 519089; Fri, 07 Apr 2023 21:33:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkthp-0004t6-Dn for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 21:33:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9901076-d58b-11ed-b464-930f4c7d94ae; Fri, 07 Apr 2023 23:33:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5148D654EC; Fri, 7 Apr 2023 21:33:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3D73C433D2; Fri, 7 Apr 2023 21:33:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9901076-d58b-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680903186; bh=KgPVxGeJyjHgHWJ1MvOr151jsd1aMT+s+wUu8MCW3MA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=amCe+dN+/bqX1XCsKNLagV3HpIosJbF9FlPy2W51kopEMdLznuiUZF+oveoR+86Sq qXYze2QyhfQOP6pC6wdmzAsxe50fv6TXFNsN6fI7uscQB4pPNpkxyhIrhzXUHCVy/c ioxWxo1YIGRX3533z9pzWXSW/82P2ILXsUyKYHx1y9FhEBfjgduhQb+G5ZS2zwHA8/ JJ7GicQKB1RmOnnKHLdrXnZgXVg9DWjMh7koEGhcAMc1hh327Xyb6k2DiZp4Y7Gzvf 3aNK1gFBTeIlU76UA1f7Kshq0DHQMKgHV7LKMq7L2rAQdGAQtjXmYnEZzeAjphe304 y0GAafVn2dicg== Date: Fri, 7 Apr 2023 14:33:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: Michal Orzel , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments In-Reply-To: <7dc2a51a-f1bd-6370-6b42-0bcf1adad619@amd.com> Message-ID: References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-2-michal.orzel@amd.com> <7dc2a51a-f1bd-6370-6b42-0bcf1adad619@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 6 Apr 2023, Ayan Kumar Halder wrote: > On 05/04/2023 12:17, Michal Orzel wrote: > > In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment > > stating that the guest is expected to read the DR register only if the > > TXFE bit of FR register is not set. This is obviously logically wrong and > > it should be RXFE (i.e. RX FIFO empty bit set -> nothing to read). > NIT:- I will prefer if the PL011 TRM is mentioned with the relevant section. > > > > Signed-off-by: Michal Orzel > Reviewed-by: Ayan Kumar Halder Reviewed-by: Stefano Stabellini > > --- > > xen/arch/arm/vpl011.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > > index 2fa80bc15ac4..0186d8a31834 100644 > > --- a/xen/arch/arm/vpl011.c > > +++ b/xen/arch/arm/vpl011.c > > @@ -143,8 +143,8 @@ static uint8_t vpl011_read_data_xen(struct domain *d) > > /* > > * It is expected that there will be data in the ring buffer when this > > * function is called since the guest is expected to read the data > > register > > - * only if the TXFE flag is not set. > > - * If the guest still does read when TXFE bit is set then 0 will be > > returned. > > + * only if the RXFE flag is not set. > > + * If the guest still does read when RXFE bit is set then 0 will be > > returned. > > */ > > if ( xencons_queued(in_prod, in_cons, sizeof(intf->in)) > 0 ) > > { > > @@ -202,8 +202,8 @@ static uint8_t vpl011_read_data(struct domain *d) > > /* > > * It is expected that there will be data in the ring buffer when this > > * function is called since the guest is expected to read the data > > register > > - * only if the TXFE flag is not set. > > - * If the guest still does read when TXFE bit is set then 0 will be > > returned. > > + * only if the RXFE flag is not set. > > + * If the guest still does read when RXFE bit is set then 0 will be > > returned. > > */ > > if ( xencons_queued(in_prod, in_cons, sizeof(intf->in)) > 0 ) > > { > From xen-devel-bounces@lists.xenproject.org Fri Apr 07 21:42:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 21:42:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519094.806278 (Exim 4.92) (envelope-from ) id 1pktrD-0006T9-1L; Fri, 07 Apr 2023 21:42:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519094.806278; Fri, 07 Apr 2023 21:42:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pktrC-0006T2-Uk; Fri, 07 Apr 2023 21:42:54 +0000 Received: by outflank-mailman (input) for mailman id 519094; Fri, 07 Apr 2023 21:42:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pktrB-0006Su-3S for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 21:42:53 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2577c318-d58d-11ed-85db-49a42c6b2330; Fri, 07 Apr 2023 23:42:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F03066409B; Fri, 7 Apr 2023 21:42:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DECBC433EF; Fri, 7 Apr 2023 21:42:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2577c318-d58d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680903770; bh=lVWwJy+ZKB+OJ2ogGpVmHsex9c5zOoBzr31cr4qWLaU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=d04Gd5vbHDZwvIeRDa2zeLFqGpWu/YOu4ZH0lL9AtbfXnD7XAEexo030Ac6lXvs+m qMGuYNuEuLGKtr7SpKYMh7BEPV2yuBztRjmfJxhJ002fEj1aNvaz2+HcycQpVgGD72 On68uJPoLQap8VKjYTEZ00auiZ99xcOaV7Q4eFDT+pSLwgGQeOuveRxWaZoQitV1MX jgURF+cw4zEm28G14eA2GXDGwqBPuy+DfUeRh1z9SGAswEFIy8JrDtxCYfhEVmi5gx +5tO4fx4/PYfwVR56pFYGJryuC7JIGi6HX4EScnvrTDnzH9zKey6VrtWRMpYInk4Vz DKr2aucx6qJRg== Date: Fri, 7 Apr 2023 14:42:47 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 2/3] xen/arm: vpl011: Handle correctly TXFE when backend in Xen In-Reply-To: <20230405111750.12491-3-michal.orzel@amd.com> Message-ID: References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 5 Apr 2023, Michal Orzel wrote: > When backend is in Xen, the handling of data written to DR register is a > bit special because we want to tell guest that we are always ready for new > data to be written (i.e. no real FIFO, TXFF/BUSY never set and TXI always > set). This conflicts with the current handling of TXFE bit, which we > always clear and never set on a write path (we happen to set it when we > receive char from serial input due to use of vpl011_data_avail() but this > might never be called). This can lead to issues if a guest driver makes > use of TXFE bit to check for TX transmission completion (such guest could > then wait endlessly). Fix it by keeping TXFE always set to match the > current emulation logic. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > We don't have to look far for an example of a PL011/SBSA driver relying on TXFE. > If a guest had a driver like we have in Xen, we would end up with no messages > being printed. > --- > xen/arch/arm/vpl011.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 0186d8a31834..ff06deeb645c 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -112,8 +112,14 @@ static void vpl011_write_data_xen(struct domain *d, uint8_t data) > } > } > > + /* > + * When backend is in Xen, we tell guest we are always ready for new data > + * to be written. This is fulfilled by having: > + * - TXI/TXFE -> always set, > + * - TXFF/BUSY -> never set. > + */ > vpl011->uartris |= TXI; > - vpl011->uartfr &= ~TXFE; > + vpl011->uartfr |= TXFE; > vpl011_update_interrupt_status(d); > > VPL011_UNLOCK(d, flags); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Apr 07 21:45:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 21:45:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519099.806288 (Exim 4.92) (envelope-from ) id 1pkttk-00074i-EN; Fri, 07 Apr 2023 21:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519099.806288; Fri, 07 Apr 2023 21:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkttk-00074Z-BI; Fri, 07 Apr 2023 21:45:32 +0000 Received: by outflank-mailman (input) for mailman id 519099; Fri, 07 Apr 2023 21:45:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pktti-00074P-Nl for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 21:45:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83004f4b-d58d-11ed-85db-49a42c6b2330; Fri, 07 Apr 2023 23:45:29 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 041B6654D8; Fri, 7 Apr 2023 21:45:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 725BAC4339B; Fri, 7 Apr 2023 21:45:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83004f4b-d58d-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680903927; bh=eBSbdsqfNNt6f8OYUMdxJVCz21US87S40JrcPEDoLQA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MLZKZBmudlRnVWoZB4Uwz0xTgAFEZ+RyjUrsS8h+3RaUn0O0fPoczVmlmtrWjHoQX 8PnG/E5E4Ejw3i3yl6aDslCywXyDAe1Q9ciHSIyky0KIxxsmEc311ka5AVerlzRrQ5 QO6fQvM8enrWMyPa/DfSWOxPOdWlDzXsuFQpQON8MwIfGMiORjHHvzef4OCGp/09YX 4eBdCtQWosz0b2N4cFY3zuIyqCBMioH8UG14tilQu+T77lWHHxdYleG6ekeBufirSk ZkBjQuCN1l9+MM5470jpe8m7FvNG9iKRpz6mOSUg+t0lFP2cjzGJtAuH67+qwS+mUt SR1LMxa/Hwmpg== Date: Fri, 7 Apr 2023 14:45:24 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen In-Reply-To: <20230405111750.12491-4-michal.orzel@amd.com> Message-ID: References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 5 Apr 2023, Michal Orzel wrote: > >From vpl011_rx_char_xen(), we call vpl011_data_avail() that handles both > RX and TX state. Because we are passing 0 as out_fifo_level and > SBSA_UART_FIFO_SIZE as out_size, we end up calling a function > vpl011_update_tx_fifo_status() which performs TXI bit handling > depending on the FIFO trigger level. This does not make sense when backend > is in Xen, as we maintain a single TX state where data can always be > written and as such there is no TX FIFO handling. Furthermore, this > function assumes that the backend is in domain by making use of struct > xencons_interface unconditionally. Fix it by calling this function only > when backend is in domain. Also add an assert for sanity. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/vpl011.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index ff06deeb645c..7856b4b5f5a3 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -261,6 +261,9 @@ static void vpl011_update_tx_fifo_status(struct vpl011 *vpl011, > struct xencons_interface *intf = vpl011->backend.dom.ring_buf; > unsigned int fifo_threshold = sizeof(intf->out) - SBSA_UART_FIFO_LEVEL; > > + /* No TX FIFO handling when backend is in Xen */ > + ASSERT(vpl011->backend_in_domain); > + > BUILD_BUG_ON(sizeof(intf->out) < SBSA_UART_FIFO_SIZE); > > /* > @@ -547,7 +550,13 @@ static void vpl011_data_avail(struct domain *d, > */ > vpl011->uartfr &= ~BUSY; > > - vpl011_update_tx_fifo_status(vpl011, out_fifo_level); > + /* > + * When backend is in Xen, we are always ready for new data to be > + * written (i.e. no TX FIFO handling), therefore we do not want > + * to change the TX FIFO status in such case. > + */ > + if ( vpl011->backend_in_domain ) > + vpl011_update_tx_fifo_status(vpl011, out_fifo_level); > } > > vpl011_update_interrupt_status(d); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Apr 07 22:09:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 22:09:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519105.806300 (Exim 4.92) (envelope-from ) id 1pkuGV-0001DL-BB; Fri, 07 Apr 2023 22:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519105.806300; Fri, 07 Apr 2023 22:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkuGV-0001DE-8S; Fri, 07 Apr 2023 22:09:03 +0000 Received: by outflank-mailman (input) for mailman id 519105; Fri, 07 Apr 2023 22:09:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkuGU-0001D8-Oc for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 22:09:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc414c02-d590-11ed-85db-49a42c6b2330; Sat, 08 Apr 2023 00:09:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DF2A64F3C; Fri, 7 Apr 2023 22:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A69C433EF; Fri, 7 Apr 2023 22:08:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc414c02-d590-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680905338; bh=BShoxTWx4HlNjbO6Scv7dYkopvwzFqmn1E8X+A2sdI0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kx76WgITtpOTf5Oj8/rBT7WSkFWZXSM8UTVCTXKjXva63R6gQzvk6w+oDGL/MxYtL pMcPNC9lKEGoyorJ87ePmxgZ62sN5ifaC9ee9Ccd0oZIW8+hg9TZBpJ48O7xy/XW1n aFhiovcvXtDqP6jDIGorEjiK1cJ8ZflXiWldjsKgUxhYDCBOpaA/tz9Xva3w27OWxf Bts6jkI72ebLZC+MXyBUqwL1I37R16QQxvHJ0zmqayZyeHTIsZzK1rZG1L/cI+yEWs 8SnvU07q+9K3pDqDHPMNqW6jK5lV6N5Ccl1ymsWQtRCdKpPRL3IXmmz6ugIEKhwM03 K4H3ft/HkAtng== Date: Fri, 7 Apr 2023 15:08:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: linux-kernel@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Dan Carpenter Subject: Re: [PATCH v2] xen/pvcalls: don't call bind_evtchn_to_irqhandler() under lock In-Reply-To: <20230403092711.15285-1-jgross@suse.com> Message-ID: References: <20230403092711.15285-1-jgross@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 3 Apr 2023, Juergen Gross wrote: > bind_evtchn_to_irqhandler() shouldn't be called under spinlock, as it > can sleep. > > This requires to move the calls of create_active() out of the locked > regions. This is no problem, as the worst which could happen would be > a spurious call of the interrupt handler, causing a spurious wake_up(). > > Reported-by: Dan Carpenter > Link: https://lore.kernel.org/lkml/Y+JUIl64UDmdkboh@kadam/ > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > V2: > - remove stale spin_unlock() (Oleksandr Tyshchenko) > --- > drivers/xen/pvcalls-front.c | 46 +++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 20 deletions(-) > > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index d5d589bda243..b72ee9379d77 100644 > --- a/drivers/xen/pvcalls-front.c > +++ b/drivers/xen/pvcalls-front.c > @@ -227,22 +227,30 @@ static irqreturn_t pvcalls_front_event_handler(int irq, void *dev_id) > > static void free_active_ring(struct sock_mapping *map); > > -static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, > - struct sock_mapping *map) > +static void pvcalls_front_destroy_active(struct pvcalls_bedata *bedata, > + struct sock_mapping *map) > { > int i; > > unbind_from_irqhandler(map->active.irq, map); > > - spin_lock(&bedata->socket_lock); > - if (!list_empty(&map->list)) > - list_del_init(&map->list); > - spin_unlock(&bedata->socket_lock); > + if (bedata) { > + spin_lock(&bedata->socket_lock); > + if (!list_empty(&map->list)) > + list_del_init(&map->list); > + spin_unlock(&bedata->socket_lock); > + } > > for (i = 0; i < (1 << PVCALLS_RING_ORDER); i++) > gnttab_end_foreign_access(map->active.ring->ref[i], NULL); > gnttab_end_foreign_access(map->active.ref, NULL); > free_active_ring(map); > +} > + > +static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, > + struct sock_mapping *map) > +{ > + pvcalls_front_destroy_active(bedata, map); > > kfree(map); > } > @@ -433,19 +441,18 @@ int pvcalls_front_connect(struct socket *sock, struct sockaddr *addr, > pvcalls_exit_sock(sock); > return ret; > } > - > - spin_lock(&bedata->socket_lock); > - ret = get_request(bedata, &req_id); > + ret = create_active(map, &evtchn); > if (ret < 0) { > - spin_unlock(&bedata->socket_lock); > free_active_ring(map); > pvcalls_exit_sock(sock); > return ret; > } > - ret = create_active(map, &evtchn); > + > + spin_lock(&bedata->socket_lock); > + ret = get_request(bedata, &req_id); > if (ret < 0) { > spin_unlock(&bedata->socket_lock); > - free_active_ring(map); > + pvcalls_front_destroy_active(NULL, map); > pvcalls_exit_sock(sock); > return ret; > } > @@ -821,28 +828,27 @@ int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags) > pvcalls_exit_sock(sock); > return ret; > } > - spin_lock(&bedata->socket_lock); > - ret = get_request(bedata, &req_id); > + ret = create_active(map2, &evtchn); > if (ret < 0) { > - clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT, > - (void *)&map->passive.flags); > - spin_unlock(&bedata->socket_lock); > free_active_ring(map2); > kfree(map2); > + clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT, > + (void *)&map->passive.flags); > pvcalls_exit_sock(sock); > return ret; > } > > - ret = create_active(map2, &evtchn); > + spin_lock(&bedata->socket_lock); > + ret = get_request(bedata, &req_id); > if (ret < 0) { > - free_active_ring(map2); > - kfree(map2); > clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT, > (void *)&map->passive.flags); > spin_unlock(&bedata->socket_lock); > + pvcalls_front_free_map(bedata, map2); > pvcalls_exit_sock(sock); > return ret; > } > + > list_add_tail(&map2->list, &bedata->socket_mappings); > > req = RING_GET_REQUEST(&bedata->ring, req_id); > -- > 2.35.3 > From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:01:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519110.806311 (Exim 4.92) (envelope-from ) id 1pkv4x-0007Np-8N; Fri, 07 Apr 2023 23:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519110.806311; Fri, 07 Apr 2023 23:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv4x-0007Ni-5U; Fri, 07 Apr 2023 23:01:11 +0000 Received: by outflank-mailman (input) for mailman id 519110; Fri, 07 Apr 2023 23:01:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv4v-0007Nc-EQ for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:01:09 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12bf9c98-d598-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:01:06 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id n14so25231792plc.8 for ; Fri, 07 Apr 2023 16:01:05 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id s21-20020aa78295000000b0062dc14ee2a7sm3505522pfm.211.2023.04.07.16.01.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:01:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12bf9c98-d598-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pwlm1lMKQRjwxkmrW2F8t3gfYFcIvBu5GbvK5p1f3qI=; b=WYmgbbs2HSI1ZfANhB99p0It58GikHCFHg8GiCJM3VQAfDfBj7TpC/bvTiV2pJ79UV KAS5g4RAW3gC6aKuL00Z27MQAUOxZbmVQcMfZCDSB1r0VuBIuxLsMFHZKi1LaGTK3hGD QdhxTCrlzTDRZmVjPx1eYN/x1bPBMtI6NsRmoM2cgteOFw+t/qEnW3IymFjABKUtyO2w 8JLLbEMqf+MaY87jjDzMDFdSjZ/ZhpXDV5gbgrECBEdb7dvChp+koaU4p/FdyjA+cGPu Q4it2C7c8GRxrjcQrXOBMNxBTHsarpA5kw1bkpmHXyGaIy0+DjId1bO+doBUisVu8LKa wxmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pwlm1lMKQRjwxkmrW2F8t3gfYFcIvBu5GbvK5p1f3qI=; b=yNJr1H9IkWTa1Ljy+zSaY3DaEi4NWBkZr4ST4bnHfs8mw99lzSnOX8DUeWu/QfqKHD c7O1b7pLgHoUBZSCz6N1zHMGANRuue3EeqOI6Uum+s0lCPif5rx+2KzyKO0cUUSY3Ajz J2Mp+GF/pbEI3rgu36gKNxNVFtjwWGM9LYeca1fToYOyDrnMWZajYMSVZsKUHkRjYBG3 BOz/uIJaMpk7TbRToCEmkrASoR9x8sMWCk0Il2Ln00LVHhtuFHyV+ugpaZNluGcLx9xb vs1Fj3d0hgkfAH0UcsBY9XdAscZN5sNf1W+O1+apjUpgw0BeVXaNb3stU0CkPwCUV7mt K07A== X-Gm-Message-State: AAQBX9etslf8UpUgY9sxt4Xb9VUO3huLLjgZjXb5O1LWLy4lkTIxuF/7 PSGfB4VQfRlYuuCJ0I2VvgRQeg== X-Google-Smtp-Source: AKy350aJv8JM6VFQdChjoum7LkzJsp3BEooDRP1tQQsqzUK9IOYyaf2AaDi9zqTn0y042mdujiyLbw== X-Received: by 2002:a05:6a20:cd5d:b0:d9:f539:727f with SMTP id hn29-20020a056a20cd5d00b000d9f539727fmr4424102pzb.28.1680908463869; Fri, 07 Apr 2023 16:01:03 -0700 (PDT) Message-ID: <8174dba8-3d19-58e6-9bcc-cb8b58d76c1b@linaro.org> Date: Fri, 7 Apr 2023 16:01:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 01/14] accel: Document generic accelerator headers Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Reinoud Zandijk , Sunil Muthuswamy , Stefano Stabellini , Anthony Perard , Paul Durrant References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-2-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-2-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:17, Philippe Mathieu-Daudé wrote: > These headers are meant to be include by any file to check > the availability of accelerators, thus are not accelerator > specific. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/hax.h | 2 ++ > include/sysemu/kvm.h | 2 ++ > include/sysemu/nvmm.h | 2 ++ > include/sysemu/tcg.h | 2 ++ > include/sysemu/whpx.h | 2 ++ > include/sysemu/xen.h | 2 ++ > 6 files changed, 12 insertions(+) Acked-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:01:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519111.806321 (Exim 4.92) (envelope-from ) id 1pkv57-0007eD-IB; Fri, 07 Apr 2023 23:01:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519111.806321; Fri, 07 Apr 2023 23:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv57-0007e2-Ds; Fri, 07 Apr 2023 23:01:21 +0000 Received: by outflank-mailman (input) for mailman id 519111; Fri, 07 Apr 2023 23:01:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv55-0007Nc-Pr for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:01:19 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a6d04b8-d598-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:01:18 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id pc4-20020a17090b3b8400b0024676052044so87304pjb.1 for ; Fri, 07 Apr 2023 16:01:18 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id n10-20020a170902968a00b0019f3cc463absm3447735plp.0.2023.04.07.16.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:01:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a6d04b8-d598-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908477; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FM1IoSWydLocj7jgKW9MEFCM/UyoS3Vw58k8MbYXpPI=; b=VQRL/jwZ/iwhTjW4uDgB/xQLypDFRo9dz1YtZKQWTGVtHNnhpUq2Kgr4tJlXpVc9Qj KBbQLfG2Z5FHXSI2VMMAmE9q1dOQk2iWj8kn9Q3lFDBbsPO0CVUPQMhVWuKl2kkGhFG/ 8Zx43AFsVbKUnCTXY9xLDWzf05mzNP0m7zfiIrbp+mM1baQPyagVzxLIe6pjmdO2GbAF FeHj3l+btpKL7NfDJ58MeRoUTWNwI8jp8DY7i9J3B7PBjUoMr2KbS1QbvXFBz9wfhpPH DHITQUJiwZ2kYMJ1/oiVdG61WqG2rvBx9o0dwXq2wqhvT0EMxe8M67t1dsAj1odQ8rE9 zrLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908477; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FM1IoSWydLocj7jgKW9MEFCM/UyoS3Vw58k8MbYXpPI=; b=5N9o5spoxtihNK7B9eTgJNVFIfR+RVt1Z+5LgP67uiDzv48u+6RwJ/zItYipYouDnu nGG9+YPw404v6hD0j3W5XmMwerDQyrvQXvgtDjVmTWDJpdFXwgbzYTer1yoPRIFQE1W8 h1dUDBos83KP8i/NpKK/wkBOvmjijSpVf2ZG/sDcNhepuSrKBFj9rWxxz2yuNg7UBaX8 ptEfX4LxrWaAD+3QQsDX9Axe4lfoYk1Ro76WGehicKcad8aTN9VgVmSxCo3K5VOHTtm4 6xXCvdvPqT+XtLVi4ksjxurwRVaJG6XUt10zSsiTD8PafhK4y8jQKKUYSWa5/MYP8KXo X7Kg== X-Gm-Message-State: AAQBX9e1er5oa5MXn0J02hb8cx7Jlz8UWkQ7eEQFjqKE0+jsU9Mjv8hg +5HWD2+52M7R9zBabBV1ZoaGcQ== X-Google-Smtp-Source: AKy350bRqvhbX5rOLuwqRdImyfLdTcBcyn1BquKHrKT2CT3Zjs0A2Q1f98kdBv1POsH49ZV8G3BXyw== X-Received: by 2002:a17:902:d2c9:b0:1a0:50bd:31a8 with SMTP id n9-20020a170902d2c900b001a050bd31a8mr5700663plc.26.1680908476761; Fri, 07 Apr 2023 16:01:16 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:01:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 02/14] accel: Remove unused hThread variable on TCG/WHPX Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Sunil Muthuswamy References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-3-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-3-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:17, Philippe Mathieu-Daudé wrote: > On Windows hosts, cpu->hThread is assigned but never accessed: > remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/tcg/tcg-accel-ops-mttcg.c | 4 ---- > accel/tcg/tcg-accel-ops-rr.c | 3 --- > target/i386/whpx/whpx-accel-ops.c | 3 --- > 3 files changed, 10 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:01:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:01:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519116.806331 (Exim 4.92) (envelope-from ) id 1pkv5S-000891-Vb; Fri, 07 Apr 2023 23:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519116.806331; Fri, 07 Apr 2023 23:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv5S-00088s-RZ; Fri, 07 Apr 2023 23:01:42 +0000 Received: by outflank-mailman (input) for mailman id 519116; Fri, 07 Apr 2023 23:01:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv5R-0007Nc-SY for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:01:41 +0000 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [2607:f8b0:4864:20::1036]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27981dfc-d598-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:01:40 +0200 (CEST) Received: by mail-pj1-x1036.google.com with SMTP id q102so40802556pjq.3 for ; Fri, 07 Apr 2023 16:01:40 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id l2-20020a17090aec0200b0023fda235bb5sm3162546pjy.33.2023.04.07.16.01.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:01:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27981dfc-d598-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908499; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TyPr1D+jmxon9z6cKE0o6xLl1ClF9NGYyNAHslJg3cw=; b=qw2wYpt5HKJz5r2a7OsRAzIXXkpT+qRLgdZ/nuCwMrIJrOzNH3fD9ex8LmkqgpG98t P7PSjtCmHjdONgfStzQ+Ft1yGw+mfPAJthFu3pkWjLS+Cx48M7Vchp8/VYXnCx8F0Q2l rMqzBqzxBQ+l/wpnRRrS/rTAmA759a2Cy1DvVHxMSI3cQ01dOcepbymKuIRh7i5+Rj3y 2E5GOExso1G5XPyhGSXfoim2hbUkG2QTnQTTe8bwyEhXxDoEojVOcZO2EHhYS1wbqqGZ YjJzG7gBuAZ1vZfTsQ5mtob4797mWInf+aP3yIRHgPoJedv7oF+XRHI69l3pt0FE3cNd WV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908499; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TyPr1D+jmxon9z6cKE0o6xLl1ClF9NGYyNAHslJg3cw=; b=5Nv2YnOaUPSyVfNAU5+T6mPGNcdg54VgISDv3PbHoMA1TNdXuLkEpK/jkjgLjSb6jO diFZhfCMm8NUNEwYRKjVxJQRS9vJFPDk+B/RgmeXL17d/5WNYG3iK5KyIpCl6o0U5HPK M2ka5debBPzKlLk9ZrA5PFqqbriqCb3jpv5d3a86uuEvDkLUs0VXESiaYrurlGLKL1iE yPEpxeDWihzwLgC3nDMkLCsHU1r2v2vZJ/blv0C1ORmXN4nP+fMZO2NZX6DzXh30uL17 z3tL33fYzIQ7oriln5lKyFFBeybgPNT/081WmIMrpDPTSyKYZKbKCpkAL0tW16upOZuZ PR9g== X-Gm-Message-State: AAQBX9eNu7cb6qA+EWmGAnJgzhs7G5m88+CnFMuuFa7WUnUnnAMQLD8V KME7XS3TbtMnoNhdlgoTsejV9VamNSiMgNhW8SI= X-Google-Smtp-Source: AKy350ZQLIgsGvtQbrBz25NftlqZ9SOXyQK0RAxFlNjlFwKEYf49WMV87F8ttHZLtHbQzsn5rLkPTA== X-Received: by 2002:a17:90a:34c2:b0:246:6b3e:38dc with SMTP id m2-20020a17090a34c200b002466b3e38dcmr1539291pjf.10.1680908498904; Fri, 07 Apr 2023 16:01:38 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:01:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 03/14] accel: Fix a leak on Windows HAX Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-4-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > hThread is only used on the error path in hax_kick_vcpu_thread(). > > Fixes: b0cb0a66d6 ("Plumb the HAXM-based hardware acceleration support") > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/hax/hax-all.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:03:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:03:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519126.806341 (Exim 4.92) (envelope-from ) id 1pkv7c-0000ch-B6; Fri, 07 Apr 2023 23:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519126.806341; Fri, 07 Apr 2023 23:03:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv7c-0000ca-7q; Fri, 07 Apr 2023 23:03:56 +0000 Received: by outflank-mailman (input) for mailman id 519126; Fri, 07 Apr 2023 23:03:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkv7b-0000cU-Eu for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:03:55 +0000 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [2607:f8b0:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76e36e35-d598-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:03:53 +0200 (CEST) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-63255e756bfso12345b3a.2 for ; Fri, 07 Apr 2023 16:03:53 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id b13-20020aa7870d000000b0062e26487e7esm3525658pfo.155.2023.04.07.16.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:03:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76e36e35-d598-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908632; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hZqP/mMtrcpUQSJ0MIEuq6L7i9BJbItpoxQhlUdV2j0=; b=OScsKdJq+aKS4EMfnsQDF1A4ZpE9lHLC3dBugCWoYJ+T+zxfKuy7Bcfowv1Z4sMNGt 5Tvqtj2tiQHF/cjx4hdeKJ6bZl9Y/HxUihnLOA+u6o+0o8KEhFMiBHXApK9qw2CCJXQY B/O1pBojgVNojn4tHZwtZ9Gj8964Bhc4vqVPOXtmkWUbZHDB/khpku9T9hNbVRaYpnKf 6WkmzIgkqbHy5Lu85TuUalah4TTDdXAr+WRzB+W03rr+p/gGfvJi+W66/flHhGLrSK6a w5iWxWFxH44qZpC/JwuKPFVtQLmfZeKHX2acjMCobg3Mcp8TCtZQwPxUU3D6tMzl+TdP a4Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908632; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hZqP/mMtrcpUQSJ0MIEuq6L7i9BJbItpoxQhlUdV2j0=; b=cVKd6ApFSDrvpps4mp1Z1h9LxXqqMZr+SFFMZ7Jdwi+vZZP+uNCLWuTIw7RVPeiEcf T8cbxN7C9ekuMM2/ZeZb0W/9YY6Q/Sp5PyAQVUfQO8saKDGZSU8mRh4y73a8a9RitXe5 7KbAYr+n0XcbsMjLGCOcETx+4h1lsTR4coWSwkZTr6iGHuYntW2iyomqAbkwX7RAuWXj JlkRJprgQ/hkFjGeLW3oGtqmI/rnHP+jbbF1/gdOe3FooLNAQ6nKYswxHR+KqZB4GUoY bUElkvLtPE1Y4cmiwMZQ8mEELIJru2r5fNI5tWQnSCffqxPtrOU0ngFAmZbtOcuV+6NF K88w== X-Gm-Message-State: AAQBX9cTFy3HiAbv/vP6eSQZyxVbzhlKP7h8JHuFewCFTCtgnBeUDWIp tFFoFpWLmyp5Mx7cZZfZehEmjQ== X-Google-Smtp-Source: AKy350an52aELf6hlPTEwYKQg2oGfdoio44PzUivo7lHIUSuO2HA+GtnFtvlc2ICRNAVAvj8q2M6tQ== X-Received: by 2002:a62:5e41:0:b0:626:2ae6:31f6 with SMTP id s62-20020a625e41000000b006262ae631f6mr3993369pfb.7.1680908631953; Fri, 07 Apr 2023 16:03:51 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:03:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 05/14] accel: Rename 'hax_vcpu' as 'accel' in CPUState Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Reinoud Zandijk , Sunil Muthuswamy References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-6-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-6-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > All accelerators will share a single opaque context > in CPUState. Start by renaming 'hax_vcpu' as 'accelCPUState'. Pasto in 'accel' here. Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:07:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519131.806351 (Exim 4.92) (envelope-from ) id 1pkvAu-0001Hd-Px; Fri, 07 Apr 2023 23:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519131.806351; Fri, 07 Apr 2023 23:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvAu-0001HW-N3; Fri, 07 Apr 2023 23:07:20 +0000 Received: by outflank-mailman (input) for mailman id 519131; Fri, 07 Apr 2023 23:07:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvAt-0001HQ-LZ for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:07:19 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0989c9b-d598-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:07:17 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id m18so64689plx.5 for ; Fri, 07 Apr 2023 16:07:17 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id w8-20020a63c108000000b005141e2c733dsm3117978pgf.11.2023.04.07.16.07.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:07:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0989c9b-d598-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908836; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JAx0qx3C6KbkeA3/DQYQ7BheR/mOc8zbOwn50MI/ySU=; b=mbYbKfx8mUmFoekiQdkNphSpXLmmbqH8glL3AwV4W3HVWtDJAciucY0lPbRfBpEDFq gLlOvNgZ1aLfgvbPXG+Qx/8/igjS3HTbQe0TOOhogHHLu6CsdelnF0yAQM3P4NvkeUlZ /xxR7Zdqi7rV2zCgA4fHc1MzHVBEyEVNb2vgXSmk+/mwYBQWFUuxDl3NGR/k474i1eEt GapH/ZtfQMmDXQlxBXlVSl3mvt6+PQYPigGuP+NMhSb2Yk4I8i4WH+/5bJi5N0/JyBg7 qvyMaJ5KjlSKrhsg0GppELpMFE4U4M6ddit4DbdCD0iuZxi2OYxIn/vTltNF+s2Tq4mQ uM6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908836; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JAx0qx3C6KbkeA3/DQYQ7BheR/mOc8zbOwn50MI/ySU=; b=xzX81L5bM0BKKevQDGg89IiHg8hwZ31qiy3DHjC4XsaSyHRNayCJzh41GxLdXbP8fU UK5timuTba37tgsIRU3roOZC/qUezamZ3MhByWctbbA9XdRgy3+S+uuGTbwzzlP2MYe/ wNTjkF88G22frSqnb3g/rbGOd827ysb4jtulPivqnPDa4sQXeyCv0YS1AK/ctOM/C9oL NmGIYmrc8VE6alTTi4tC64KiIkz2ERtW+9PVsfEQNBhNtwRqVZtGwtUhHrQa633cVic3 qb8GGJ961CT9nPPSFiaYS/I/dWAu8wgZQtj+kN98VzovLkXk62rZB/Ut2rKYuP4023zx TAgA== X-Gm-Message-State: AAQBX9fPZlHKA7KCt3uvXmUCyJPp2QQS/Ju/GnhXuVv+IQD4aTvagxsc 3Lk63sUK07vXABx4vCzujhmw6Q== X-Google-Smtp-Source: AKy350ZaLWvNZM1+jRdEw1wsK7EItizE9LE7fAUvdw6zSKnESjRPfP7KFdel4FWtCgR78LROUj0RRA== X-Received: by 2002:a05:6a20:ca4e:b0:d7:34a1:85b9 with SMTP id hg14-20020a056a20ca4e00b000d734a185b9mr108846pzb.7.1680908836058; Fri, 07 Apr 2023 16:07:16 -0700 (PDT) Message-ID: <7f1385f0-b0bc-090a-4437-434cb72a7cc6@linaro.org> Date: Fri, 7 Apr 2023 16:07:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 07/14] accel: Rename struct hax_vcpu_state -> struct AccelvCPUState Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Reinoud Zandijk , Sunil Muthuswamy References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-8-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-8-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > We want all accelerators to share the same opaque pointer in > CPUState. Start with the HAX context, renaming its forward > declarated structure 'hax_vcpu_state' as 'AccelvCPUState'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 7 +++---- > target/i386/hax/hax-i386.h | 3 ++- > target/i386/nvmm/nvmm-all.c | 2 +- > target/i386/whpx/whpx-all.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) Can this be squashed with previous? It seems odd to change the name twice in a row. Is the "v" in AccelvCPUState helpful? > + struct AccelvCPUState *accel; > /* shared by kvm, hax and hvf */ > bool vcpu_dirty; Move below the comment? Or is that later? r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:07:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:07:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519134.806360 (Exim 4.92) (envelope-from ) id 1pkvBM-0001kb-25; Fri, 07 Apr 2023 23:07:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519134.806360; Fri, 07 Apr 2023 23:07:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvBL-0001kU-Vf; Fri, 07 Apr 2023 23:07:47 +0000 Received: by outflank-mailman (input) for mailman id 519134; Fri, 07 Apr 2023 23:07:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvBK-0001kC-Fz for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:07:46 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01520507-d599-11ed-85db-49a42c6b2330; Sat, 08 Apr 2023 01:07:45 +0200 (CEST) Received: by mail-pj1-x102d.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso8842973pjc.1 for ; Fri, 07 Apr 2023 16:07:45 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id p2-20020a17090adf8200b002465e66256asm1238484pjv.11.2023.04.07.16.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:07:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01520507-d599-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wgiL/ifYNfwo++KDFPg/Dio8zORaAFAk5bB5YtGhmQk=; b=MEGGWwlxDpwujW+GajFwMICW/+ZkQuiv23sCYl3JUT/QGW1SCye8aT/VwuveZyUz00 danOwxCDQO8rPdclT/eLT0VCKJMmNVgE8cYX5i7MRWsQ4coyPuqnScvQZwZTRvGxdYvC FhJkRJCGIWp5W6kFxgNUJaKiGOLx9njvZfXCvRgcLvuhm7FACslFqNbhm4hJWCgiDvo2 7hWTApcGKjnMgABAvptKlm34znz02qQ8vUOi0oekStr3YQbTAa5sGe+i21fWdcw/Aq1j c4DzqVmZej5HD6YvnXJJwa+uihhiloPCbj7INDw5KTL3mAU/KBhEKOkI7ZdD4FMRBbcu Juyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wgiL/ifYNfwo++KDFPg/Dio8zORaAFAk5bB5YtGhmQk=; b=iCinFRRNOkTvhEtv3cPKeJoygZJfq96etAATtQ04vE2gCNSfNwJ6Plnk659phgaIpy AdRLe12sT2uGVXlzMMXlOBgr/bO0cgQ9nTRpFs5KH4YV9F8SZpUDW2VVLrjmCDdviBoi 7hE3T8YI5AHBXAa9DNhhnm2NGDn2mLuShFo0VL0XYhsSZiuv+D93eE//JX+gG/HHN/hA qz1+e+20TLDr3KPhXPT/8DSVCOo6A7kf2uMrNjtxkQpIcHckKeWaefvkFigHMkN+gX9o Qj5YFp21uDwFNxSXY8rdCHY358mVjoXQATWhuusoC+QB2AeqC3ZM/Iy+I6i4XOF3rC7b OKvg== X-Gm-Message-State: AAQBX9fWhbQkMX6X2+R29jLA+9WDD7wPGNWN/RGWKWgwVwUehUHD/DhK TeaxGvaUBc6WIk40w5nyXg1tcg== X-Google-Smtp-Source: AKy350bXcZjgyQUuRpp6nyP3eJ+x1rlN/eQIhLU/UutS8vew5xsari6fdOQWku6HCBWiasGwTXkzQw== X-Received: by 2002:a17:902:e5cb:b0:1a1:e112:461c with SMTP id u11-20020a170902e5cb00b001a1e112461cmr12302648plf.30.1680908864146; Fri, 07 Apr 2023 16:07:44 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:07:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 08/14] accel: Move HAX hThread to accelerator context Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Eduardo Habkost , Marcel Apfelbaum , Yanan Wang References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-9-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-9-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > hThread variable is only used by the HAX accelerator, > so move it to the accelerator specific context. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 1 - > target/i386/hax/hax-i386.h | 3 +++ > target/i386/hax/hax-accel-ops.c | 2 +- > target/i386/hax/hax-all.c | 2 +- > target/i386/hax/hax-windows.c | 2 +- > 5 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519141.806371 (Exim 4.92) (envelope-from ) id 1pkvD8-0002Ot-DL; Fri, 07 Apr 2023 23:09:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519141.806371; Fri, 07 Apr 2023 23:09:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvD8-0002Om-AL; Fri, 07 Apr 2023 23:09:38 +0000 Received: by outflank-mailman (input) for mailman id 519141; Fri, 07 Apr 2023 23:09:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvD6-0002Oe-BF for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:09:36 +0000 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [2607:f8b0:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42e029cd-d599-11ed-85db-49a42c6b2330; Sat, 08 Apr 2023 01:09:35 +0200 (CEST) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-517c01e6660so18595a12.2 for ; Fri, 07 Apr 2023 16:09:35 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id f3-20020aa78b03000000b005aa60d8545esm3564626pfd.61.2023.04.07.16.09.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:09:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42e029cd-d599-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680908974; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XvSIGGl7kyzrRPKD+1h4YAIP7+IU0OISKySWyKHO+jg=; b=iv6gr2hKVqwKYI+iTQN+8od7y6Vm/m73ky9/2diyxBhZPqEorU219WD2XJzyvYDYRT EQnhzs/V9uvYpJLy4VBiCLJDPSSyy/mk7kdUnBMVS5pdIZkqIfGf52EThRLsFjAEdEsI 75R64mVKrvYX9fSs1K2fFq6b2G/rdvEnYm5oV115etWVrXcUd06SIATm2soLvb5zJ2rS aLj36ZCRtc9CMFkr4v9c3m54c5MWwJYwceHUVQL+Hc3QAWiaTznLDbwG3uZRQ1o+xHSV QewZOhFy9l4j9VEGUvSVoAuQtIMQ9HwTJxUwxMmvV2wdOiXGWIwjq9EvrUIb00tY50Wg 1WyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680908974; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XvSIGGl7kyzrRPKD+1h4YAIP7+IU0OISKySWyKHO+jg=; b=t2GXLzkczR/QAZSWUSfUCNrJslAw5GKzXI0k/tmGeEpqRIJYFtGIXRn0P1cNTzrj6/ tek5e2pMsneZygp3zp85yTA2jztAQSSze+/aL58mtj3YC9YjAyjqsN5JwqFFXbciRwhW 3J841P1XfKkwNASXu5r2jNuD/RbRH0UmVufTypPlox9kYAdDTGe6N52yoGRxTpfrzcdn F3ovDdI/fza0rdfoqB/QaJCkwnfkfyZpBnX+OCJVtP+cRNtYC/GYrlCSMfMoZZG2I9i+ +T76fOFDzD0m1tLDVgVclKSeWq8ZSiW9AhTcCR9fqXfvSjdRYXmp5Yl1VDo9HM5Y04Zb 5LRQ== X-Gm-Message-State: AAQBX9djz6kNUvIcSkPqTxNZuLCyKJrdHkaxiJNNqH4DCQMXjDMaVJsf oY9+mapUoACU7zJxN1RjxKoDxQ== X-Google-Smtp-Source: AKy350Yqp9FrNOy78lp7BrA74JA2K1IJ9euoV6m53eCZnb3f4VQZGuFjTlRtLSsG6RBgf5M2spk2Qw== X-Received: by 2002:aa7:8bd1:0:b0:62a:9d6f:98dc with SMTP id s17-20020aa78bd1000000b0062a9d6f98dcmr3877311pfd.11.1680908974132; Fri, 07 Apr 2023 16:09:34 -0700 (PDT) Message-ID: <48b9e338-e20e-95f9-c611-3878b24ccec0@linaro.org> Date: Fri, 7 Apr 2023 16:09:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 07/14] accel: Rename struct hax_vcpu_state -> struct AccelvCPUState Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Reinoud Zandijk , Sunil Muthuswamy References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-8-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-8-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > +struct AccelvCPUState; Missing typedef? r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:11:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:11:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519146.806381 (Exim 4.92) (envelope-from ) id 1pkvEX-0003nm-P4; Fri, 07 Apr 2023 23:11:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519146.806381; Fri, 07 Apr 2023 23:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvEX-0003nf-L7; Fri, 07 Apr 2023 23:11:05 +0000 Received: by outflank-mailman (input) for mailman id 519146; Fri, 07 Apr 2023 23:11:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvEW-0003nU-P6 for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:11:04 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77979410-d599-11ed-85db-49a42c6b2330; Sat, 08 Apr 2023 01:11:04 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id p8so184862plk.9 for ; Fri, 07 Apr 2023 16:11:04 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id ik23-20020a170902ab1700b001967580f60fsm3360481plb.260.2023.04.07.16.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:11:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77979410-d599-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680909062; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+8sjrQkKmFa0fDEbK0ByEbj8xRVyyoXwt3mONWUrCjg=; b=fu0fc9kQ3M2sfVtK3t68zTbYFucNlj5oFSUSteqUYRu6VDv3uTItwTOkzCaPFNHOei Df/jKMmHFnnEBVa21r/eZ50XSQaDi0Hdouvc5bo4bnXn3NaTSvMg4uk2qfa5HE0KEHPK G/hnmvZSmlnUfmxSrzAzCG2somHL6hF+eFvhEfvqMO4TRTM4MdDjEbP4M3dgQLLmAJUt NQ70V3GEiNeBy6LgXX+ZifscCDpUsnjTSs3RYovPOLuMKgkROChad5HQjq9TyjzVOy/W ikj4D19qkBrRoB4IJxSKljZsM9kEwp6vq/D91lh+Kurhgan8M73NHLiK5l1wy/jRVm4c 8CpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680909062; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+8sjrQkKmFa0fDEbK0ByEbj8xRVyyoXwt3mONWUrCjg=; b=4H6Y7kdbGPpD+gmoFNrjvHAumoTzlCcxscceakYxWRHVoG2uTPFocs0S1hzoeTlamv axA/ZL2nt0rvlCxfto1/wdEFtxVTF6/flH+o22ChOPxyd8zWlYyrClfp7inXy5jOvhm6 h2PAMKNlIyMF9u7ocxn1gwPd1E54B9ZcvFWLFui809/ZxjNzcveBl+SYOWHnhZZdUz84 v9miEQs7JqjtH0Hi4SoRIDkpFyUBjAFBIAdD6uoeFfAB20glm1w1AJ6QS+X0M50uJ4Dq 6I973CApWEZS62GrGoFDFRU0Hq/fbJ7GyjXV1lJgvYdKjqn0Yw0umXODALgYUTUPx1+H VkUQ== X-Gm-Message-State: AAQBX9cphCe+e4Fx6f3T5Dd9T6Mvzh4iqB7cQwALVzY6TkFkYCCIIyey b4cJ+5AiW5zoHTPfq0W/aaxG8g== X-Google-Smtp-Source: AKy350Z01RjDdvFrn3SDcNSR06u3kONrO463lNJW2mYVi5QEQlyqB2hcRXm9iVwIpLBrSzeEsGCq9A== X-Received: by 2002:a17:903:3093:b0:1a2:ca:c6cd with SMTP id u19-20020a170903309300b001a200cac6cdmr3648934plc.43.1680909062629; Fri, 07 Apr 2023 16:11:02 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:11:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 10/14] accel: Rename NVMM struct qemu_vcpu -> struct AccelvCPUState Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Reinoud Zandijk References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-11-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-11-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > - struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu); > + struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu); With the typedef in hw/core/cpu.h, you can drop the 'struct' at the same time. Otherwise, Reviewed-by: Richard Henderson > - qcpu = g_try_malloc0(sizeof(*qcpu)); > + qcpu = g_try_new0(struct AccelvCPUState, 1); Another 'try' to clean up. :-) r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:11:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519150.806391 (Exim 4.92) (envelope-from ) id 1pkvF3-0004I5-0n; Fri, 07 Apr 2023 23:11:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519150.806391; Fri, 07 Apr 2023 23:11:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvF2-0004Hy-UB; Fri, 07 Apr 2023 23:11:36 +0000 Received: by outflank-mailman (input) for mailman id 519150; Fri, 07 Apr 2023 23:11:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvF1-0003nU-T6 for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:11:35 +0000 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [2607:f8b0:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a40117d-d599-11ed-85db-49a42c6b2330; Sat, 08 Apr 2023 01:11:35 +0200 (CEST) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-51396f3e6b0so146058a12.1 for ; Fri, 07 Apr 2023 16:11:35 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id 80-20020a630253000000b005136d5a2b26sm3141345pgc.60.2023.04.07.16.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:11:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a40117d-d599-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680909094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4cErFy4VVSXH+T35LT4D8bhMQRXEc0jWj0rx0ggjSPk=; b=OJFinG4r+Jx35MVNhHZcNTMCoIxRVzugHa8wQb0aF3/WTzIXXBfPwEM81GLW5qzvA3 5ETEJsnkXy63xKZpvH1BGx4E4mJabdebFUPIucQkQ109TgyzR/OJANaStfogZeUwJSvB +n0AkGdqt/wNTf7EIX5oMoy0GvlBdDdwbxgBQ/FNmniodkjKXrGRz7rWA6vw+T9AgziT RkNSL9rUUEBJmTGgAlLH2V6qPGr0J/0/wvBQXd6nbZl2I2R617/+2FmNyTRd56JrEd17 LWo9ZJvzBF+Jg+CjaCPLtDsd5FPc+J0a2N1UTbzoR7A8cxU06vM7OEL1iLwmOTtAizig nHRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680909094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4cErFy4VVSXH+T35LT4D8bhMQRXEc0jWj0rx0ggjSPk=; b=3pFIiv4VH49Ty4AxFiMV6H1p3/kEbOLEyi4uMyuEaGkoJEdNsDrJUXKGTt7gXMFKvS kCEUDOFdiF0sssitNZJUc4FGSv7jwXXfEpOn6kDC6Mr7nDgL81dYCSBWdXHREuAbiwiz B/Epsw8DZGP4Ofy23BM7d15sRl5IOwdGVCYEf9dLkZcC0xJNuRKLNDlSH1KY6hhxyA+R cY0hAIEzUp9P66rzVaufsH0A8R6wiIgeWI+tTcfE+iENpApkKWD1CoSX36YkPzUZznWY hzTagxPIJyfOrbQq1KYTDlOq4hXI0dblsM++sZTyS7io6SPn+pq82NTW+x03KFHvsMpu 1abw== X-Gm-Message-State: AAQBX9dPzzt7hIoim3z0/OxRd7UZkRQWPO+an0hfFPcTtHbOwcCvDfoP DvrS8b7KXyPLR8C0RlfDxAPCyOFQdhcTVk39VgI= X-Google-Smtp-Source: AKy350bXu0YXNAHiNTKVWIi38x7qw1rEbHmvanIsHsxL3sMeptcsGTDsDeyKqZftiwBuvO2w43WOyw== X-Received: by 2002:a62:1850:0:b0:62d:8376:3712 with SMTP id 77-20020a621850000000b0062d83763712mr155681pfy.28.1680909093896; Fri, 07 Apr 2023 16:11:33 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:11:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 11/14] accel: Inline NVMM get_qemu_vcpu() Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Reinoud Zandijk References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-12-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-12-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > No need for this helper to access the CPUState::accel field. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/nvmm/nvmm-all.c | 28 +++++++++++----------------- > 1 file changed, 11 insertions(+), 17 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:13:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:13:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519157.806400 (Exim 4.92) (envelope-from ) id 1pkvGU-0004xa-Gx; Fri, 07 Apr 2023 23:13:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519157.806400; Fri, 07 Apr 2023 23:13:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvGU-0004xT-E3; Fri, 07 Apr 2023 23:13:06 +0000 Received: by outflank-mailman (input) for mailman id 519157; Fri, 07 Apr 2023 23:13:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvGT-0004xG-6F for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:13:05 +0000 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [2607:f8b0:4864:20::1030]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf128a8b-d599-11ed-85db-49a42c6b2330; Sat, 08 Apr 2023 01:13:03 +0200 (CEST) Received: by mail-pj1-x1030.google.com with SMTP id r21-20020a17090aa09500b0024663a79050so1560399pjp.4 for ; Fri, 07 Apr 2023 16:13:03 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id g24-20020a63dd58000000b004fcda0e59c3sm3091950pgj.69.2023.04.07.16.13.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:13:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf128a8b-d599-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680909182; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aYIkZBIFK2ZpHWvSfO0jyCWHXEmHKEa00eKczku2HgE=; b=vKfScPpZZuTSQjVvlLzoq0nu/oNEzhegH0VN4qBbTDX1lF4jluykpN2c1wbw5Qjmnj Rb66ndQEM5IDPq+PkYMGfaYi9++yYdHMhB0dAtUmxQ0utcdT4d11dzuZmSQZmMmkR0YZ f19qZTPpNtjEBVCVK7fCUEY08KnyfjOg+z/5iwxAqvdo+K6M9MEOq/E2MXr0jeAqB+Kq suEXAJqiAwgQTQ/MyX+nLK78aB5JsXiZWTSWLDWgP46FZ/9UiE6oqKOC79oVNQyZQwyZ gs3Q/speYE/HWvXViIfmClwbFvilbHwN6YPaYwEE4apNDw1NyVzvGBqI622hYSkVaakq kurg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680909182; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aYIkZBIFK2ZpHWvSfO0jyCWHXEmHKEa00eKczku2HgE=; b=RqTvOVAYeEv0Ows1Ns1anfM6cwHRbFxZ0jbi+wByDR38H73wsgRLMZl+A+PSH7uXP9 p+kVey7gkhrvhnLLqTXcNohwPutBfrO/UDnSOAAPYciEJ6pltIz2QHEnQp7MHcRJ/5v6 bCCpKVSY3OKjgfh7BVeLnBhs5QqNcGXupAKz2+i67bZm852M+qr4cOqrl+O82VsRCQ/Q Qybr/O9NKoLvXX1QozIHYWDBNSrrnwAxBBxpLP99wB8X9/dcbo+Fyqhbg91ETgGHJUGa YNAvEH0eLfuna8q50nB0DXfu2gjV0dlE6We+CtWzJqg7bhjS6AwfyfdaHe5HmoI0H9xk +6bg== X-Gm-Message-State: AAQBX9edAbuYN1jdNl/xbt/1U9hHCu1ysePdQFe4kordyozCK+UlUvpA JFaK63NkJssbjX/FdGfAGSDLeg== X-Google-Smtp-Source: AKy350bDgHCmk88fi7lKmF1o3TyQSTwibPI+P0wHGQ0hTOjZ8sVom4CqWEwPGykeBzb76cAn0hafQQ== X-Received: by 2002:a05:6a20:4ca3:b0:d9:dbb6:2e67 with SMTP id fq35-20020a056a204ca300b000d9dbb62e67mr4159798pzb.31.1680909182482; Fri, 07 Apr 2023 16:13:02 -0700 (PDT) Message-ID: <5a0297f8-ddc6-4fac-b896-1b1ecede844e@linaro.org> Date: Fri, 7 Apr 2023 16:13:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 12/14] accel: Rename WHPX struct whpx_vcpu -> struct AccelvCPUState Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Sunil Muthuswamy References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-13-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-13-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > We want all accelerators to share the same opaque pointer in > CPUState. Rename WHPX 'whpx_vcpu' as 'AccelvCPUState'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/whpx/whpx-all.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c > index 70eadb7f05..2372c4227a 100644 > --- a/target/i386/whpx/whpx-all.c > +++ b/target/i386/whpx/whpx-all.c > @@ -229,7 +229,7 @@ typedef enum WhpxStepMode { > WHPX_STEP_EXCLUSIVE, > } WhpxStepMode; > > -struct whpx_vcpu { > +struct AccelvCPUState { > WHV_EMULATOR_HANDLE emulator; > bool window_registered; > bool interruptable; > @@ -260,9 +260,9 @@ static bool whpx_has_xsave(void) > * VP support > */ > > -static struct whpx_vcpu *get_whpx_vcpu(CPUState *cpu) > +static struct AccelvCPUState *get_whpx_vcpu(CPUState *cpu) > { > - return (struct whpx_vcpu *)cpu->accel; > + return (struct AccelvCPUState *)cpu->accel; Same comment about removing 'struct'. Reviewed-by: Richard Henderson > - vcpu = g_new0(struct whpx_vcpu, 1); > + vcpu = g_new0(struct AccelvCPUState, 1); > > if (!vcpu) { > error_report("WHPX: Failed to allocte VCPU context."); Hah. And a "can't happen" error_report, since we're not actually using try here. :-P r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:13:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:13:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519159.806410 (Exim 4.92) (envelope-from ) id 1pkvGk-0005KH-Nv; Fri, 07 Apr 2023 23:13:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519159.806410; Fri, 07 Apr 2023 23:13:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvGk-0005KA-LL; Fri, 07 Apr 2023 23:13:22 +0000 Received: by outflank-mailman (input) for mailman id 519159; Fri, 07 Apr 2023 23:13:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvGi-0005Ev-KI for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:13:20 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c80f6c5d-d599-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:13:19 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id o2so122996plg.4 for ; Fri, 07 Apr 2023 16:13:19 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id x22-20020a170902821600b001a199972508sm3382209pln.124.2023.04.07.16.13.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:13:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c80f6c5d-d599-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680909197; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+ItnoDxjRyq5NxF6TJi+AQI7ZLK0+7Nql3EFIwnRinE=; b=tBpx2Whb4QzegaMnt95h9v7OIs3R0veH7QI0AUG8m9HbqbV69oRmE1Lp3HyvnMwLin McrVCRHDPd0x2sKbwU88FmIlMhQnR+/8x5bkAEnXgzjwWrTRhDDlXblkJAD/Gz648Xwc 5Raj8RHXLDPLqPir8wxUa9xK9fb7aGTo1JHNiEa3mGeWRYIsyKtHdFiZJYaxFCiRB9Sw e3YuDa9UieI9e3U+MI+GMOtmitZ6G286gVAMwWk6LF3ANI4RVLMGHfTrXI4s+jKap2JY LvI5E5XUdmS2/NCFq1bHDfM8/DxpdIw7Sp0m9wmFWfggE3O13TldNX65vBYEOTNlWaI7 hICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680909197; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+ItnoDxjRyq5NxF6TJi+AQI7ZLK0+7Nql3EFIwnRinE=; b=bhqY53vuCmAMHhHohma2geZjl7/NAIYvFF1DNaALZHlB4/cy2EKZqOy31mzv+cYXUG MoqRvh93MOZ+plSvZaYv227CassUKdG1Iaai+T9mTL8nb1t4YRVTzSji2xoZ4N2PMt6n Yrm9qIHsNcc04/1YGqEAVi52r3vczrX/Vn/mImvEJsGGOAVtFhR5S/9/hnfakkwolqnw D0MbjQV9PEEdIxtxf+Sz37uSnFiOyI2lMSMWDQFODxaz1bcGfV90781h2T4V6z2N7mJi SpzyW27raEcfh0ooyVa3NXsaukf3jT5tiwxseX7778Q0UJbs2A8e6IQtG0PnVpnGXkkZ 26Qg== X-Gm-Message-State: AAQBX9fG5Ag8agHXX0xA4mMrdN3MzC/xy77nScHoXNQ169AgJjeccNrc FtSm2efSfaXBDq+83BMwNq7GZA== X-Google-Smtp-Source: AKy350Y3lzjtZw4RK/yOE1pq/rsEAaEwouoQEVbujzz2mrQjMkOvcprqVjsdpaOumVHAhvkYih/Nlw== X-Received: by 2002:a17:902:f544:b0:1a1:b8cc:59da with SMTP id h4-20020a170902f54400b001a1b8cc59damr5210653plf.33.1680909197678; Fri, 07 Apr 2023 16:13:17 -0700 (PDT) Message-ID: <9a1a1a4a-ef80-61a8-8d2c-55817fd12496@linaro.org> Date: Fri, 7 Apr 2023 16:13:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 13/14] accel: Inline WHPX get_whpx_vcpu() Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Sunil Muthuswamy References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-14-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-14-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > No need for this helper to access the CPUState::accel field. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/whpx/whpx-all.c | 29 ++++++++++------------------- > 1 file changed, 10 insertions(+), 19 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Apr 07 23:14:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Apr 2023 23:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519167.806420 (Exim 4.92) (envelope-from ) id 1pkvHW-00061Y-0U; Fri, 07 Apr 2023 23:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519167.806420; Fri, 07 Apr 2023 23:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvHV-00061R-UC; Fri, 07 Apr 2023 23:14:09 +0000 Received: by outflank-mailman (input) for mailman id 519167; Fri, 07 Apr 2023 23:14:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkvHU-0005Ev-QZ for xen-devel@lists.xenproject.org; Fri, 07 Apr 2023 23:14:08 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4ce64e0-d599-11ed-b464-930f4c7d94ae; Sat, 08 Apr 2023 01:14:07 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id pc4-20020a17090b3b8400b0024676052044so104462pjb.1 for ; Fri, 07 Apr 2023 16:14:07 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8? ([2602:ae:1541:f901:8bb4:5a9d:7ab7:b4b8]) by smtp.gmail.com with ESMTPSA id jh3-20020a170903328300b001963a178dfcsm1477074plb.244.2023.04.07.16.14.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 16:14:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4ce64e0-d599-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680909246; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZEtxxHTBPYDx1m8Q5UryyRdPATKO4VY3g+smnvxOwf4=; b=con+E+nBuUuL8bc6aBTNFmZw3A88rUFZYxGTFhDreXq5RHJZKuVoYlJBjJANRic/qc d5s0aIniIw0RL+malEGtEBMEHpe94GQp29//JHjND3LOTt2Qz6neACI5ima/6Bs8ADdA yo/JWYahYMsh7ErPLucmzyNckoeMuF0c9x1qrf9zMQmx6Bnh5MEN+0uiyAhmVmsWPJFI pWVaQ9k2ZnUgguA6EPAKVUUEzJY96hKZT4/VabPIIz8klAbW+JC3mY3jjRBuLk3fSGy5 mfIp7D/2faI4Ti1BgkVfeheIv0888nglBVVCpOLVsdTkwhfsjv/mG9K919FmrAqv8UV4 NPiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680909246; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZEtxxHTBPYDx1m8Q5UryyRdPATKO4VY3g+smnvxOwf4=; b=BmpybB9a8L6zOZIbSLPZKlUs1wvXxxJfrgZpopGgFeUtouEGrqS0t/jIhKTGJ8YU9+ FFg626Z0zu+byPUMNL62awH5BlwHcwp+Nm57qeUxzKjyCxmgabp6471sEvTaiCNG+zHt g/zWOrglujcEKBk1XQdamcU0DIMs61N0UDn/lP5mI+xNay4XocLU4hhPVGQkXfMQhbIw GyDn9DNTiaj/kfYZdJLglzG99hSyHA/CrsW6L3e7AcIgNrplNhV5OxJUn2LlpQPNjJbF vvrmb9h0eC5eMndkz1//22zvp7G01RU4Au4L+IemWUkjEFAWe0m51oRl12bgHqkRDU7Z DXzw== X-Gm-Message-State: AAQBX9fllYsEBfYeDNshlfwX7mWDQJav8EcXzRbd61HlRQs4Xcs3LqHy HJyeJOrcEYIGK73JjIDlsdBp7w== X-Google-Smtp-Source: AKy350aI+71oWAmO3OSiaf8U410Jg/WRlz+R9/yR6IazGZ/MKyDHhEtyo9+noerB1d8Pc0Zo6Qu0ww== X-Received: by 2002:a17:903:183:b0:1a1:e33f:d567 with SMTP id z3-20020a170903018300b001a1e33fd567mr5603426plg.52.1680909245863; Fri, 07 Apr 2023 16:14:05 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 16:14:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 14/14] accel: Rename HVF struct hvf_vcpu_state -> struct AccelvCPUState Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Cameron Esfahani , Roman Bolshakov , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Alexander Graf , Peter Maydell , qemu-arm@nongnu.org References: <20230405101811.76663-1-philmd@linaro.org> <20230405101811.76663-15-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230405101811.76663-15-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/5/23 03:18, Philippe Mathieu-Daudé wrote: > We want all accelerators to share the same opaque pointer in > CPUState. > > Rename the 'hvf_vcpu_state' structure as 'AccelvCPUState'. > > Use the generic 'accel' field of CPUState instead of 'hvf'. > > Replace g_malloc0() by g_new0() for readability. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 3 -- > include/sysemu/hvf_int.h | 2 +- > accel/hvf/hvf-accel-ops.c | 16 ++++----- > target/arm/hvf/hvf.c | 70 +++++++++++++++++++-------------------- > 4 files changed, 44 insertions(+), 47 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Sat Apr 08 04:04:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Apr 2023 04:04:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519178.806431 (Exim 4.92) (envelope-from ) id 1pkznc-0000AX-RW; Sat, 08 Apr 2023 04:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519178.806431; Sat, 08 Apr 2023 04:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkznc-0000A7-Ky; Sat, 08 Apr 2023 04:03:36 +0000 Received: by outflank-mailman (input) for mailman id 519178; Sat, 08 Apr 2023 04:03:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkzna-00009p-TB; Sat, 08 Apr 2023 04:03:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkzna-0000qp-P5; Sat, 08 Apr 2023 04:03:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pkzna-0007Md-CU; Sat, 08 Apr 2023 04:03:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pkzna-0004ib-A1; Sat, 08 Apr 2023 04:03:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PQumjNl3YpE6W8W2axOQVSYxFK+AxJE2pdDbPoCKqU0=; b=E5+bH3aLQsOiZZaEbUuQSqVirm LmHY72AEUChMI5aOQ0u6sU+fHjrkYgKCqM7kmBw1qz0j/RHcLih8ig1LMy9kEnzwhHf46QK+yKo3r XeJD1iDvE6DoTkFBPiaPyonumGZNzsE1E1TNfXImkeHNh6zWzGtoo/iK5eem/p7CBf3Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180182: trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-credit2::broken:regression xen-unstable:test-amd64-amd64-xl-credit2:capture-logs(26):broken:heisenbug xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=a5087069a8c40541ba81fa0e2850471c949932b3 From: osstest service owner Date: Sat, 08 Apr 2023 04:03:34 +0000 flight 180182 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180182/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken in 180178 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 26 capture-logs(26) broken in 180178 pass in 180182 test-amd64-i386-examine-uefi 6 xen-install fail in 180178 pass in 180182 test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail in 180178 pass in 180182 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 180178 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 180178 like 180173 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 180173 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180173 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180173 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen a5087069a8c40541ba81fa0e2850471c949932b3 Last test of basis 180173 2023-04-06 19:49:58 Z 1 days Testing same since 180178 2023-04-07 09:41:23 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken Not pushing. ------------------------------------------------------------ commit ddaf7bb0cfd27369252de52e4b03410c4065bad2 Author: Andrew Cooper Date: Fri Mar 17 11:10:06 2023 +0000 x86/svm: Provide EXITINFO decodes for Exceptions/NPF intercepts Exceptions and NPF intercepts almost have the same layout, but NPF has bits above 31 in the error code, and the name for exitinfo2 really does want distinguishing between cr2 and gpa. In nsvm_vcpu_vmexit_inject() rearrange VMEXIT_NPF to fall through instead of repeating the exitinfo1 write. Use the fallthrough pseudo keyword instead of a comment. In VMEXIT_NPF, as we're editing the printk() anyway, switch to using the newer domain_crash() form. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Apr 08 06:34:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Apr 2023 06:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519186.806441 (Exim 4.92) (envelope-from ) id 1pl29C-0007Uk-FZ; Sat, 08 Apr 2023 06:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519186.806441; Sat, 08 Apr 2023 06:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl29C-0007Ud-BA; Sat, 08 Apr 2023 06:34:02 +0000 Received: by outflank-mailman (input) for mailman id 519186; Sat, 08 Apr 2023 06:34:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl29B-0007UT-3f; Sat, 08 Apr 2023 06:34:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl29A-0004vQ-Si; Sat, 08 Apr 2023 06:34:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl29A-000610-6M; Sat, 08 Apr 2023 06:34:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pl29A-0007hp-5v; Sat, 08 Apr 2023 06:34:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fRbaKRTgdUOPwHl+wsegb2Ncl+Oecl0i2lNUo9EYjEA=; b=FKUvd14C+shrFykA1xQ37oD7Dc 1iBuofs8c36bdWxkPQhV8uGSFLIcPhNz1U1JsTw7BSa2falTrRiO5YIKRC+E8dchxSAl8Qp3ngJ2n R7lIqFtRuwL5SG3+93C0oqwm79yz3oZSbF2lit44gbD7WG8wR+0WMzNwD9zlNBBqhzgo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180183: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=aa318c48808c0aa73216bd94c54c4553d3663add X-Osstest-Versions-That: linux=f2afccfefe7be1f7346564fe619277110d341f9b From: osstest service owner Date: Sat, 08 Apr 2023 06:34:00 +0000 flight 180183 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180183/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180172 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180172 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180172 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180172 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180172 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux aa318c48808c0aa73216bd94c54c4553d3663add baseline version: linux f2afccfefe7be1f7346564fe619277110d341f9b Last test of basis 180172 2023-04-06 19:10:15 Z 1 days Testing same since 180183 2023-04-07 21:10:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bartosz Golaszewski Catalin Marinas Dhruva Gole Hans de Goede Keerthy Linus Torvalds Marios Makassikis Michael Walle Namjae Jeon Rafael J. Wysocki Randy Dunlap Steve French Tom Rix jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git f2afccfefe7b..aa318c48808c aa318c48808c0aa73216bd94c54c4553d3663add -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Apr 08 11:47:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Apr 2023 11:47:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519215.806455 (Exim 4.92) (envelope-from ) id 1pl71c-00047q-Ko; Sat, 08 Apr 2023 11:46:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519215.806455; Sat, 08 Apr 2023 11:46:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl71c-00047j-Hx; Sat, 08 Apr 2023 11:46:32 +0000 Received: by outflank-mailman (input) for mailman id 519215; Sat, 08 Apr 2023 11:46:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl71a-00047Z-I0; Sat, 08 Apr 2023 11:46:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl71a-0003mX-GB; Sat, 08 Apr 2023 11:46:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pl71Z-000830-R4; Sat, 08 Apr 2023 11:46:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pl71Z-0003r4-Qi; Sat, 08 Apr 2023 11:46:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2DNR3E2BaaMGtoxrKAIZ0b2+O9pm4xdmdk0kLASLRC0=; b=z6J5C+2Wxdhu8OCzsS3VUG0uB/ MsPQgPUQrdvEMergKCAZ5Ygj35zqwDfy4laAKX99bzDIgm//xf2LYNW1p1v4mCMkIVXCW4eV2o/ej 6JPss9diBM7AoqYBj62WRT5tHntFX6HazzlTjaLt5J3QvPA5M8YLF5i2Eh7RS2cijEnY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180184: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=a5087069a8c40541ba81fa0e2850471c949932b3 From: osstest service owner Date: Sat, 08 Apr 2023 11:46:29 +0000 flight 180184 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180184/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 180182 pass in 180184 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 180182 test-amd64-i386-xl-qemut-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 180182 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 180182 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 180173 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180173 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180173 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180173 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180173 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen a5087069a8c40541ba81fa0e2850471c949932b3 Last test of basis 180173 2023-04-06 19:49:58 Z 1 days Testing same since 180178 2023-04-07 09:41:23 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a5087069a8..ddaf7bb0cf ddaf7bb0cfd27369252de52e4b03410c4065bad2 -> master From xen-devel-bounces@lists.xenproject.org Sun Apr 09 03:09:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Apr 2023 03:09:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519282.806465 (Exim 4.92) (envelope-from ) id 1plLQh-0007JN-Pk; Sun, 09 Apr 2023 03:09:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519282.806465; Sun, 09 Apr 2023 03:09:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plLQh-0007JF-JS; Sun, 09 Apr 2023 03:09:23 +0000 Received: by outflank-mailman (input) for mailman id 519282; Sun, 09 Apr 2023 03:09:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plLQg-0007J5-6F; Sun, 09 Apr 2023 03:09:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plLQg-0007jj-2u; Sun, 09 Apr 2023 03:09:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plLQf-0007bo-OZ; Sun, 09 Apr 2023 03:09:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plLQf-0005hQ-Nm; Sun, 09 Apr 2023 03:09:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4m4qTnMRLOEtgWnq9vxv0V/Hwr0o4k8E0CuYD8A7GoY=; b=vK6dXHQYXQ3r9sGTsmPrdUGqpB dY/ryEDv1Ii3LK9ORQcym9u8+P08Cac8+QBKh0cd4wN7suxcDEK21NnxN+BZAOW5DeXOx5TWsXYXv OexbQLQP0SAl3E+vbHZWX5qTIqKquMyrAkUs9F3c70kXkpdt6lsDK/1Y6FIp+0vRy/rQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180185: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=a79d5c76f705de81cb6b55ad279dde9759da06d2 X-Osstest-Versions-That: linux=aa318c48808c0aa73216bd94c54c4553d3663add From: osstest service owner Date: Sun, 09 Apr 2023 03:09:21 +0000 flight 180185 linux-linus real [real] flight 180186 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180185/ http://logs.test-lab.xenproject.org/osstest/logs/180186/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 180186-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180183 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180183 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180183 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180183 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180183 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux a79d5c76f705de81cb6b55ad279dde9759da06d2 baseline version: linux aa318c48808c0aa73216bd94c54c4553d3663add Last test of basis 180183 2023-04-07 21:10:18 Z 1 days Testing same since 180185 2023-04-08 19:13:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrien Thierry Alistair Popple Andrew Morton Christoph Hellwig Daniel Wagner David Hildenbrand Dexuan Cui Florian Fainelli Jens Axboe Keith Busch Laurence Oberman Leonard Göhrs Li Zetao Liam Howlett Liam R. Howlett Linus Torvalds Martin K. Petersen Ming Lei Muchun Song Muhammad Usama Anjum Peng Zhang Peter Xu Petr Tesarik Ranjan Kumar Rongwei Wang Ryusuke Konishi Sergey Senozhatsky Shin'ichiro Kawasaki Shiyang Ruan Steven Rostedt (Google) Suren Baghdasaryan Tetsuo Handa Tiezhu Yang Uwe Kleine-König Wojciech Lukowicz Yafang Shao ye xingchen Yongchen Yin Yu Kuai Zheng Yejian Zhong Jinghua jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git aa318c48808c..a79d5c76f705 a79d5c76f705de81cb6b55ad279dde9759da06d2 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Apr 09 08:49:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Apr 2023 08:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519308.806475 (Exim 4.92) (envelope-from ) id 1plQjn-0007Bq-7N; Sun, 09 Apr 2023 08:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519308.806475; Sun, 09 Apr 2023 08:49:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plQjn-0007Bj-4S; Sun, 09 Apr 2023 08:49:27 +0000 Received: by outflank-mailman (input) for mailman id 519308; Sun, 09 Apr 2023 08:49:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plQjl-0007BX-Ny; Sun, 09 Apr 2023 08:49:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plQjl-0007qJ-LB; Sun, 09 Apr 2023 08:49:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plQjl-0008Qw-5l; Sun, 09 Apr 2023 08:49:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plQjl-0005mC-5P; Sun, 09 Apr 2023 08:49:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jAzyI+BdnrlSbxvQ+lRAeHkj6vabYYoxfXFA+nn9zdY=; b=pEsuTej0/t8XXEqMBHXgJXuJIM cy+Ghf6m9RGFXgVVmrGNlz6gwBzWL7NUs2UeSUD+HCjJ8ufmfAsKEyOxrovHQgg5knMAd8Im/GG60 tzL0v87UJhlKGIrg+jxzLPRxbZMyrD5dT+iBXZM85UHSWYrVixPWtdhdXfSuSoGBFmR4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180187: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 From: osstest service owner Date: Sun, 09 Apr 2023 08:49:25 +0000 flight 180187 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180187/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-install fail in 180184 pass in 180187 test-amd64-i386-xl-qemut-debianhvm-amd64 18 guest-localmigrate/x10 fail in 180184 pass in 180187 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 180184 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 180184 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180184 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180184 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180184 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180184 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180184 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 180184 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180184 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180184 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180184 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180184 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 Last test of basis 180187 2023-04-09 01:51:59 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Apr 09 14:21:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Apr 2023 14:21:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519363.806485 (Exim 4.92) (envelope-from ) id 1plVuJ-0006DH-E4; Sun, 09 Apr 2023 14:20:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519363.806485; Sun, 09 Apr 2023 14:20:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plVuJ-0006DA-BH; Sun, 09 Apr 2023 14:20:39 +0000 Received: by outflank-mailman (input) for mailman id 519363; Sun, 09 Apr 2023 14:20:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plVuI-0006D0-51; Sun, 09 Apr 2023 14:20:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plVuI-0006hs-0z; Sun, 09 Apr 2023 14:20:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plVuH-0007VC-HE; Sun, 09 Apr 2023 14:20:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plVuH-0005Ih-Gp; Sun, 09 Apr 2023 14:20:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qRKBS9wYy29ngsH/xxR4oW0rnZ3RhvasB0bX3I7iegI=; b=LTpX3h8nhh1UDMf/3SFg+B+q3t Lgxz4Tlpebw/QwL/YmOTU780jUk17TnnBkDyJpTkgCWNDqfkHWoxUUZKYcSwSli0nrtNPl316qlqM 6dkjynoZAFNqnnoel+fKCtFZwGxHerR4LfuukJjsjPV0tt2dH9JQg7HyLJSx/Uk6MuSo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180188: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=cdc9718d5e590d6905361800b938b93f2b66818e X-Osstest-Versions-That: linux=a79d5c76f705de81cb6b55ad279dde9759da06d2 From: osstest service owner Date: Sun, 09 Apr 2023 14:20:37 +0000 flight 180188 linux-linus real [real] flight 180189 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180188/ http://logs.test-lab.xenproject.org/osstest/logs/180189/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180189-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180185 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180185 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180185 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180185 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail like 180185 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180185 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux cdc9718d5e590d6905361800b938b93f2b66818e baseline version: linux a79d5c76f705de81cb6b55ad279dde9759da06d2 Last test of basis 180185 2023-04-08 19:13:27 Z 0 days Testing same since 180188 2023-04-09 03:13:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Shevchenko Arnd Bergmann Biju Das Bjørn Mork D Scott Phillips Dan Carpenter David Lechner Enrico Sau Geert Uytterhoeven Greg Kroah-Hartman Hans de Goede Haotien Hsu Heikki Krogerus Ian Ray Ibrahim Tilki Ilpo Järvinen Jens Axboe Johan Hovold Jonathan Cameron Kai-Heng Feng Kees Jan Koster Krzysztof Kozlowski Lars-Peter Clausen Linus Torvalds Marc Zyngier Mathias Nyman Mehdi Djait Mirsad Goran Todorovac Mårten Lindahl Nuno Sá Patrik Dahlström Pawel Laszczak RD Babiera Sandeep Dhavale Sherry Sun Steve Clevenger Steve French Suzuki K Poulose Thiago Rafael Becker Wayne Chang William Breathitt Gray jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git a79d5c76f705..cdc9718d5e59 cdc9718d5e590d6905361800b938b93f2b66818e -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Apr 10 00:24:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Apr 2023 00:24:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519430.806494 (Exim 4.92) (envelope-from ) id 1plfK2-00060i-4K; Mon, 10 Apr 2023 00:23:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519430.806494; Mon, 10 Apr 2023 00:23:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plfK2-00060b-19; Mon, 10 Apr 2023 00:23:50 +0000 Received: by outflank-mailman (input) for mailman id 519430; Mon, 10 Apr 2023 00:23:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plfK0-00060R-Mk; Mon, 10 Apr 2023 00:23:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plfK0-0004uX-JX; Mon, 10 Apr 2023 00:23:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plfK0-0007Tm-2l; Mon, 10 Apr 2023 00:23:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plfK0-0006io-2C; Mon, 10 Apr 2023 00:23:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rxTbtFR6M4X3MyhMwnvdYHD1x4laf0t2NbiwMzo84FQ=; b=TDxLM/SDDO6FFefQB0pD0j5ULB 5zOU8Qg4X/zJy0D0fvyvpPbHzxpYgZV8Y54zsyIK1aJ8XszZmEVsyawOchMbJMBFW0Z5Ts4qUWFX2 5/0N1rO0p8yyYUOUxUvOGVzT1gNs1UlEVyPK6LwX4lFzrGO/YxjlOnZnDEW/C8Z+XPcw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180190: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start.2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=faf8f41858e2792925b2c526e16d2f539a53a730 X-Osstest-Versions-That: linux=cdc9718d5e590d6905361800b938b93f2b66818e From: osstest service owner Date: Mon, 10 Apr 2023 00:23:48 +0000 flight 180190 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180190/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-vhd 22 guest-start.2 fail blocked in 180188 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180188 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180188 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180188 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180188 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180188 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux faf8f41858e2792925b2c526e16d2f539a53a730 baseline version: linux cdc9718d5e590d6905361800b938b93f2b66818e Last test of basis 180188 2023-04-09 03:13:59 Z 0 days Testing same since 180190 2023-04-09 17:41:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bjorn Helgaas Borislav Petkov (AMD) Dan Williams Dave Jiang David R Eric DeVolder Gregory Price Ira Weiny Jonathan Cameron Kan Liang Linus Torvalds Lukas Wunner Mario Limonciello Peter Zijlstra (Intel) Peter Zijlstra Thomas Gleixner Tony Luck jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git cdc9718d5e59..faf8f41858e2 faf8f41858e2792925b2c526e16d2f539a53a730 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Apr 10 08:00:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Apr 2023 08:00:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519456.806504 (Exim 4.92) (envelope-from ) id 1plmRF-0007Tb-Ae; Mon, 10 Apr 2023 07:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519456.806504; Mon, 10 Apr 2023 07:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plmRF-0007TU-82; Mon, 10 Apr 2023 07:59:45 +0000 Received: by outflank-mailman (input) for mailman id 519456; Mon, 10 Apr 2023 07:59:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plmRD-0007TK-PX; Mon, 10 Apr 2023 07:59:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plmRD-0006kl-Mr; Mon, 10 Apr 2023 07:59:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plmRD-0003O8-7E; Mon, 10 Apr 2023 07:59:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plmRD-0000bK-6k; Mon, 10 Apr 2023 07:59:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qyD7GKUih4UvNk+sg61LBgr1MK3ZJtttrdTHE7luv1A=; b=q4H+tE++JWEe5hqwxVoB0YNVjX +2Ok7Y8ozwLSjejII5ATrTtmvYyFWpfRYymBFZuhdp+1uCQvyn9vKzzN+Dc5e9nPXDb6HY/xfma7p TIVLvA/A+6qEmqaM0G8U09BiVSz+bq+prBQ7DZdVdY1RySg1JAFY7kYodMzT3KIpeJzo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180193: all pass - PUSHED X-Osstest-Versions-This: ovmf=cf4af503fb61e7a942e05e61627364cad48c5781 X-Osstest-Versions-That: ovmf=6405cd03048c1850d5047bf66fefa04189a05c94 From: osstest service owner Date: Mon, 10 Apr 2023 07:59:43 +0000 flight 180193 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180193/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cf4af503fb61e7a942e05e61627364cad48c5781 baseline version: ovmf 6405cd03048c1850d5047bf66fefa04189a05c94 Last test of basis 180180 2023-04-07 13:43:54 Z 2 days Testing same since 180193 2023-04-10 06:12:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chris Johnson Jiewen Yao Liming Gao Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6405cd0304..cf4af503fb cf4af503fb61e7a942e05e61627364cad48c5781 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Apr 10 08:40:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Apr 2023 08:40:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519469.806515 (Exim 4.92) (envelope-from ) id 1pln4D-00040m-RW; Mon, 10 Apr 2023 08:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519469.806515; Mon, 10 Apr 2023 08:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pln4D-000409-Nv; Mon, 10 Apr 2023 08:40:01 +0000 Received: by outflank-mailman (input) for mailman id 519469; Mon, 10 Apr 2023 08:40:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pln4C-0003xJ-Hf; Mon, 10 Apr 2023 08:40:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pln4C-0008Ji-Fa; Mon, 10 Apr 2023 08:40:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pln4C-0004Oz-1Z; Mon, 10 Apr 2023 08:40:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pln4C-0002k9-16; Mon, 10 Apr 2023 08:40:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oI5t8EYVe3CMtZPAvTZbwvGad2l6d5EFXj8gs9Vhisw=; b=YRZ2BsolizuwYyTbkklK7DFcRq ukDNtTNawioYbzM3VEfJD0mRfpzhTfLyLNc1IIa+Y4Q71OfS3NHNZQQsKOL7wpbQwC9KSQx0tIGb+ oops6BOUZIGIi6/4u4067hgzQmx69HnyU68cc+rHQ/baf8Wh79GAvLFFvx21eFtDB9IE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180191: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=09a9639e56c01c7a00d6c0ca63f4c7c41abe075d X-Osstest-Versions-That: linux=faf8f41858e2792925b2c526e16d2f539a53a730 From: osstest service owner Date: Mon, 10 Apr 2023 08:40:00 +0000 flight 180191 linux-linus real [real] flight 180194 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180191/ http://logs.test-lab.xenproject.org/osstest/logs/180194/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180194-retest test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 180194-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180190 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180190 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180190 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180190 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180190 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d baseline version: linux faf8f41858e2792925b2c526e16d2f539a53a730 Last test of basis 180190 2023-04-09 17:41:25 Z 0 days Testing same since 180191 2023-04-10 00:42:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git faf8f41858e2..09a9639e56c0 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Apr 10 11:08:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Apr 2023 11:08:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519509.806525 (Exim 4.92) (envelope-from ) id 1plpO3-0001rf-BG; Mon, 10 Apr 2023 11:08:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519509.806525; Mon, 10 Apr 2023 11:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plpO3-0001rY-6v; Mon, 10 Apr 2023 11:08:39 +0000 Received: by outflank-mailman (input) for mailman id 519509; Mon, 10 Apr 2023 11:08:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plpO1-0001rO-JU; Mon, 10 Apr 2023 11:08:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plpO1-0003ED-FZ; Mon, 10 Apr 2023 11:08:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plpO0-0000De-T2; Mon, 10 Apr 2023 11:08:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plpO0-0006ov-SY; Mon, 10 Apr 2023 11:08:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Eo8V4wRWDDNdeDmFAFd+nCc9EVo1NzjJ+qXiNc4szrU=; b=CHsExxIDbGYnjW5aG0B3jDExVi /+3xoVzRHspMzeUogS03g7c6Va1x06wgZZgkAuyVy1YniAXML09fshlHQBtog5a5Cmee6uZk1Mu4b ix0U1Bi2H2rlTBxXV1KYv2UGHBmAsYPT2ijkilXcNx2f3QmiHYIHqSRwxDj69/dr9iD4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180192: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 From: osstest service owner Date: Mon, 10 Apr 2023 11:08:36 +0000 flight 180192 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180192/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 180187 pass in 180192 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 180187 pass in 180192 test-amd64-i386-libvirt 7 xen-install fail pass in 180187 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 180187 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180187 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 180187 like 180184 test-amd64-i386-libvirt 15 migrate-support-check fail in 180187 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180187 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180187 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180187 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180187 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180187 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180187 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180187 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180187 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180187 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 Last test of basis 180192 2023-04-10 01:52:35 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Apr 10 16:39:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Apr 2023 16:39:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519542.806535 (Exim 4.92) (envelope-from ) id 1pluYE-0000Ov-Fw; Mon, 10 Apr 2023 16:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519542.806535; Mon, 10 Apr 2023 16:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pluYE-0000Oo-CR; Mon, 10 Apr 2023 16:39:30 +0000 Received: by outflank-mailman (input) for mailman id 519542; Mon, 10 Apr 2023 16:39:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pluYD-0000Oe-E7; Mon, 10 Apr 2023 16:39:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pluYD-0003La-C8; Mon, 10 Apr 2023 16:39:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pluYC-0002ek-SF; Mon, 10 Apr 2023 16:39:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pluYC-0008L7-Ro; Mon, 10 Apr 2023 16:39:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XB5ke6pxsM4SVEjmueJhrWhiqKxPUEEamVn9vkeaWdQ=; b=du472UvvHqmQdReA30qT0QKeMK sYZowh5ACodDh5u75gyl8EBfxZaq/EFmzEo1tXAf5ED0iFy4FHw3Xh03soUXe1U3lz4YqtRKklyLE 4YXXm+ecfYVf99BMLVuvUXERO0b7Y+U/Tmvai4qMzUOJkl6ynotVJaRbkoIHDt4/Zz3w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180196: all pass - PUSHED X-Osstest-Versions-This: ovmf=61652efd04a7585a779226137d0f9739a75aac69 X-Osstest-Versions-That: ovmf=cf4af503fb61e7a942e05e61627364cad48c5781 From: osstest service owner Date: Mon, 10 Apr 2023 16:39:28 +0000 flight 180196 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180196/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 61652efd04a7585a779226137d0f9739a75aac69 baseline version: ovmf cf4af503fb61e7a942e05e61627364cad48c5781 Last test of basis 180193 2023-04-10 06:12:15 Z 0 days Testing same since 180196 2023-04-10 14:40:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git cf4af503fb..61652efd04 61652efd04a7585a779226137d0f9739a75aac69 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Apr 10 20:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Apr 2023 20:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519558.806546 (Exim 4.92) (envelope-from ) id 1plyPb-00089O-Di; Mon, 10 Apr 2023 20:46:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519558.806546; Mon, 10 Apr 2023 20:46:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plyPb-00089H-8R; Mon, 10 Apr 2023 20:46:51 +0000 Received: by outflank-mailman (input) for mailman id 519558; Mon, 10 Apr 2023 20:46:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plyPa-000896-KH; Mon, 10 Apr 2023 20:46:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plyPa-0000Mu-DF; Mon, 10 Apr 2023 20:46:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1plyPZ-0000pn-Vi; Mon, 10 Apr 2023 20:46:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1plyPZ-0001L0-VF; Mon, 10 Apr 2023 20:46:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EPF9VAc5EtJ5H7fVFrLJnYoesRL+m7pjnVnsj9CoN9Y=; b=xENq8GQMab2xlrMV4iuXLfcHaR DQsvkwMylpH8UsPe29P5s7k9RzzaYpxpC1l7EemyuHtb/jinaM0PMaJG9xCB2O7IM9luV58p40yEJ wVm24/chcQjbSw6Tj2yRkFMeLkwaawTBlmwIS9IKaThpP81bPrVml/fops6r9aRbNYG4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180195: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=08dede07030973c1053868bc64de7e10bfa02ad6 X-Osstest-Versions-That: qemuu=c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b From: osstest service owner Date: Mon, 10 Apr 2023 20:46:49 +0000 flight 180195 qemu-mainline real [real] flight 180197 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180195/ http://logs.test-lab.xenproject.org/osstest/logs/180197/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 180197-retest test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 180197-retest test-amd64-amd64-xl-qcow2 22 guest-start.2 fail pass in 180197-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180197-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180168 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180168 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180168 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180168 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180168 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 08dede07030973c1053868bc64de7e10bfa02ad6 baseline version: qemuu c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b Last test of basis 180168 2023-04-06 10:37:17 Z 4 days Testing same since 180195 2023-04-10 13:39:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cédric Le Goater Peter Maydell Richard Henderson Stefan Berger jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git c6f3cbca32..08dede0703 08dede07030973c1053868bc64de7e10bfa02ad6 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Apr 11 05:59:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 05:59:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519581.806555 (Exim 4.92) (envelope-from ) id 1pm72N-0001a0-Ts; Tue, 11 Apr 2023 05:59:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519581.806555; Tue, 11 Apr 2023 05:59:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm72N-0001Zs-PT; Tue, 11 Apr 2023 05:59:27 +0000 Received: by outflank-mailman (input) for mailman id 519581; Tue, 11 Apr 2023 05:59:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm72M-0001Zi-6K; Tue, 11 Apr 2023 05:59:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm72M-0004U3-3o; Tue, 11 Apr 2023 05:59:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm72L-00022j-LT; Tue, 11 Apr 2023 05:59:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pm72L-0008D8-Kg; Tue, 11 Apr 2023 05:59:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UEQ4XIEi+F4a7HOzfrNhoD8BNy8nW7nRLP12fi23a3A=; b=FNtbrqeh8kSoPG5QOeqhDAGACc wa2X881yVsa6BQKRTn+qE5t0aUg0a7nLSMHOQ1irETLujkhIb1kvnnlnOXpF+iXpX/2dB5QWOSDtx 6l9j8W5tGQRh4brveOzVEzS6NaXqWUuAD04AcFfSCrzV7QqjQv9NGQs2GnhYxorPllNE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180198: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=26aeb3b5894e0f3d17354e306002c59fa060e1c5 X-Osstest-Versions-That: qemuu=08dede07030973c1053868bc64de7e10bfa02ad6 From: osstest service owner Date: Tue, 11 Apr 2023 05:59:25 +0000 flight 180198 qemu-mainline real [real] flight 180201 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180198/ http://logs.test-lab.xenproject.org/osstest/logs/180201/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 180201-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180195 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180195 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180195 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180195 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180195 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 26aeb3b5894e0f3d17354e306002c59fa060e1c5 baseline version: qemuu 08dede07030973c1053868bc64de7e10bfa02ad6 Last test of basis 180195 2023-04-10 13:39:02 Z 0 days Testing same since 180198 2023-04-10 21:08:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 08dede0703..26aeb3b589 26aeb3b5894e0f3d17354e306002c59fa060e1c5 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Apr 11 08:50:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 08:50:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519598.806565 (Exim 4.92) (envelope-from ) id 1pm9h4-00029h-IY; Tue, 11 Apr 2023 08:49:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519598.806565; Tue, 11 Apr 2023 08:49:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm9h4-00029a-Fg; Tue, 11 Apr 2023 08:49:38 +0000 Received: by outflank-mailman (input) for mailman id 519598; Tue, 11 Apr 2023 08:49:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm9h3-00029Q-LL; Tue, 11 Apr 2023 08:49:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm9h3-0000OV-GF; Tue, 11 Apr 2023 08:49:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pm9h3-0006aQ-8v; Tue, 11 Apr 2023 08:49:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pm9h3-0007YC-8U; Tue, 11 Apr 2023 08:49:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zOoTt19u0fkUjIzYFKjN5Jbw40+8n+0j0w+ATl6eIBY=; b=FxpUwTLjcSalwFAzO3ctEnb7CR qxJPkrAufrqFI73OB39dvWK1h7AyxqmB9N1R0g0d5lyS3wkNvZM4/SfppG66ZrWGjgqSlF15DJJNc EuHD9jhPt4UtoTKRjeU0HHM7ac1zoZWlMDPGVujUeHtKxUPZFvuJ75gtdGvDrdJUnN1M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180199: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-arm64-arm64-xl:debian-install:fail:heisenbug linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=0d3eb744aed40ffce820cded61d7eac515199165 X-Osstest-Versions-That: linux=09a9639e56c01c7a00d6c0ca63f4c7c41abe075d From: osstest service owner Date: Tue, 11 Apr 2023 08:49:37 +0000 flight 180199 linux-linus real [real] flight 180202 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180199/ http://logs.test-lab.xenproject.org/osstest/logs/180202/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl 12 debian-install fail pass in 180202-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 15 migrate-support-check fail in 180202 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 180202 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180191 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180191 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180191 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180191 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180191 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 0d3eb744aed40ffce820cded61d7eac515199165 baseline version: linux 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d Last test of basis 180191 2023-04-10 00:42:31 Z 1 days Testing same since 180199 2023-04-10 21:41:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arthur Grillo Christian Schoenebeck David Gow Dmitry Fomichev Dominique Martinet Eli Cohen Eric Van Hensbergen Ivan Orlov Jason Wang Linus Torvalds Michael S. Tsirkin Mike Christie Paul E. McKenney Richard Weinberger Roberto Sassu Ross Zwisler Ross Zwisler SeongJae Park Stefano Garzarella Uladzislau Rezki (Sony) Zheng Wang Ziwei Dai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 09a9639e56c0..0d3eb744aed4 0d3eb744aed40ffce820cded61d7eac515199165 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Apr 11 09:47:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 09:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519609.806574 (Exim 4.92) (envelope-from ) id 1pmAbD-0008QT-Sm; Tue, 11 Apr 2023 09:47:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519609.806574; Tue, 11 Apr 2023 09:47:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmAbD-0008QM-Q9; Tue, 11 Apr 2023 09:47:39 +0000 Received: by outflank-mailman (input) for mailman id 519609; Tue, 11 Apr 2023 09:47:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmAbC-0008QC-Dw; Tue, 11 Apr 2023 09:47:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmAbC-0001eW-Bx; Tue, 11 Apr 2023 09:47:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmAbB-0000Rv-W6; Tue, 11 Apr 2023 09:47:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmAbB-0007si-VT; Tue, 11 Apr 2023 09:47:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vxyce2jNMGY/qFEBEkuv4jDLk2/6we2Tca4ZRPSHPDw=; b=qLXVCOFUSvZ6x2qBJG1Izx3VEj z7O49UtdsKJn6Jl/LjkEx/ggD8gLaVIv5htGYbwNJJxvBlMaokY/EmIROgTTAsNfsZdfwX53MdI6O /iq8taNwS6qyHZxmNqeFpEAvcGkXo1kKA6oHE/qADjAghy8iTwwnoztqktwtYKUqe1Gs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180203: all pass - PUSHED X-Osstest-Versions-This: ovmf=51734dfc48466eddfb0f8acdb24518266c36c905 X-Osstest-Versions-That: ovmf=61652efd04a7585a779226137d0f9739a75aac69 From: osstest service owner Date: Tue, 11 Apr 2023 09:47:37 +0000 flight 180203 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180203/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 51734dfc48466eddfb0f8acdb24518266c36c905 baseline version: ovmf 61652efd04a7585a779226137d0f9739a75aac69 Last test of basis 180196 2023-04-10 14:40:49 Z 0 days Testing same since 180203 2023-04-11 07:40:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Lin, MillerX MillerX Lin jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 61652efd04..51734dfc48 51734dfc48466eddfb0f8acdb24518266c36c905 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Apr 11 10:31:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 10:31:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519618.806585 (Exim 4.92) (envelope-from ) id 1pmBGs-0005Hl-6I; Tue, 11 Apr 2023 10:30:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519618.806585; Tue, 11 Apr 2023 10:30:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmBGs-0005He-3S; Tue, 11 Apr 2023 10:30:42 +0000 Received: by outflank-mailman (input) for mailman id 519618; Tue, 11 Apr 2023 10:30:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmBGq-0005HY-7j for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 10:30:40 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e56b8fec-d853-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 12:30:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9CA585C01FA; Tue, 11 Apr 2023 06:30:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 11 Apr 2023 06:30:35 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Apr 2023 06:30:33 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e56b8fec-d853-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1681209035; x= 1681295435; bh=uvIpKHbegzj4xJPF2DM2w/cwsEorqqtDcMgBzDcQiro=; b=M XRgYMx/i98nvYqN4igFeDSN8a7RAmtIwdDTTj/cwqHrzkOrZO6kl1Sht0uxQsxa+ awf/kIEfOVg9PVGUSd34h3lvxW4QzsdGcPZBcixeC6trV83NmvfitqSm81nWC/Ci jgSdgn0JovxylGbSFyR3KmZMFY5pjPYq4rJjjY04Wmcr9R6RNA1gaeZT4Z/3ElG8 DTd2iKQ5xMZZQaHbycv13Z8lZNMEhjPg9O5FAuyCpdEgRi8LPLtkfEoefJoLVq6m s2CiKi0J3Ut/19RRRQsSAaQU0XdlFRESEFRmP51+MtbGbPeIW3r4UL0C5RphgfeF 4wa6+tMQ8sAqaCGJ+o2oQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681209035; x=1681295435; bh=uvIpKHbegzj4xJPF2DM2w/cwsEorqqtDcMg BzDcQiro=; b=K1avxbKVpjhEKX4yRjjGqz78k5/JPOdDrS3fgKY0SqX/EcEePoE nr8y7H/A1f5i8ePjjXo91IV+IPybpB8jTpR/96NGtwt4nuclMGORuD4ZCrbQUnYt aAFrT9Cq2FXEwYhTxHy5N71e6Lz1DaWRt/MXDehDCygdQoBgQ1/BOn1lEESnbo+K h9rUn7yXRl4zccj9q3kyPiAVW0f68ieT+H4DIMTzXQk2IX4JEOOtUPuJ4nniOJMl SZ95SVTk2vNbt2rYh1FXMCR7ZD4uvYMb4nHRN4hYlT6zQwEliuPsGKIQYOn/ZLwm fPi8Kf54eqCXyz2hb3m6lPZXWjoRY7c7rLw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffggfvvefhufgtsehgtderredttdejnecuhfhrohhmpefuihhmohhnucfi rghishgvrhcuoehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh eqnecuggftrfgrthhtvghrnhepheegfeelteekieeuvdduvdffheetieeiheelgfeiheff veefhffhgfejveevieehnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsihhmohhnsehinhhv ihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: Date: Tue, 11 Apr 2023 12:30:10 +0200 MIME-Version: 1.0 Content-Language: en-US To: xen-devel Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= From: Simon Gaiser Subject: RFC: disable HPET legacy mode after timer check Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------xK2STNKhiONHp1GmYwabHL6P" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------xK2STNKhiONHp1GmYwabHL6P Content-Type: multipart/mixed; boundary="------------voXpEBUiwVU5bYblL6WJgkAT"; protected-headers="v1" From: Simon Gaiser To: xen-devel Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: Subject: RFC: disable HPET legacy mode after timer check --------------voXpEBUiwVU5bYblL6WJgkAT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I have been recently looking into getting S0ix working on Xen [1]. Thanks to a tip from Andrew I found that the HPET legacy mode was preventing my test system from reaching a package C-state lower than PC7 and thereby also preventing S0ix residency. For testing I simply modified check_timer() to disable it again after it checked the timer irq: --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1966,6 +1969,8 @@ static void __init check_timer(void) =20 if ( timer_irq_works() ) { + hpet_disable_legacy_replacement_mode(); local_irq_restore(flags); return; } With this [2] I'm able to reach S0ix residency for some time and for shor= t periods the systems power consumption goes down to the same level as with= native Linux! It reaches low power states only for a fraction of the suspend to idle time, so something still makes the CPU/chipset think it should leave the low power mode, but that's another topic. I tried to understand how all the timer code interacts with disabling the legacy mode. I think it only would break cpuidle if X86_FEATURE_ARAT is not available (Which is available on my test system and indeed I didn't run into obvious breakage).=20 Is this (disabled PIT && !ARAT) a configuration that exists (and needs to be supported)? Did I miss something else? (Very much possible, given that this is way above my existing experience with X86 and Xen internals.) Simon [1]: https://lore.kernel.org/xen-devel/9051e484-b128-715a-9253-48af8e47bb= 9d@invisiblethingslab.com/ [2]: Plus [3] and some hack to have mwait-idle on Tiger Lake. [3]: https://lore.kernel.org/xen-devel/20230313134102.3157-1-simon@invisi= blethingslab.com/ --------------voXpEBUiwVU5bYblL6WJgkAT-- --------------xK2STNKhiONHp1GmYwabHL6P Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmQ1NrQACgkQkO9xfO/x ly82/hAAnCpnkQefmNsAVFIbmpZOLKU3sQajgcA5wswNrvFXk9ApnZ3MbGfgjYxv gyZtgTjbl1yTdC07CNA5upmqu2jO1wFmSyq/dpVgWHlXVtbBF/zxPf+AbFk252wb f4eEm7hSjBnUr8TrG59ZcM5VrQDa/jQkzodE0C7pEpzyBt9HECFc0blmPNL1Ot85 FdjvZvHfbXP1wn8/5znpArBldab68vh4bA7puA9Wrmr2zuBr/Jo/7pA/+7DACo4I wYMBLUkAra8fA+EDKT14OfwvDGkF5MuutFQRkgYDgFNP0j0qrZ0HgqTCmOJgp2+Z WjKi5FSab50KPTPJhFO7fjsvEXwHrT9i/p6gB+LsVxTbCJwLFH8wbMsjkvaowzKA H6CK1AN3yUSQo1uW59bmZYqXe5ZlaNIM2l8dGpX/CsKQ83z5NdlhwalkQIadYy5t nCDrV02fQzIQw+otyoj23rkzKU9mJOabw5q0kfDHy6t6Wr9GD930SdLb5nK+Rl5z XWbv5CM/pVoJjXv2ksDPqdKnv5uqIi8ZIEtiuYicaJM3bOFrqG4uGZmdP4yX021D cNThqzSnMb46QihF/rbaHOh4rEYTM9eUXWvSqTjxeoh7Hjuih7hOYupARwpoy64U D/xfOVZEPt2zwuQMgrBuUj4VnAMd78vaXGa4vUKzmO2A5yAzdrk= =zCNu -----END PGP SIGNATURE----- --------------xK2STNKhiONHp1GmYwabHL6P-- From xen-devel-bounces@lists.xenproject.org Tue Apr 11 11:21:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 11:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519629.806594 (Exim 4.92) (envelope-from ) id 1pmC3q-0002GM-TV; Tue, 11 Apr 2023 11:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519629.806594; Tue, 11 Apr 2023 11:21:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmC3q-0002GF-Qq; Tue, 11 Apr 2023 11:21:18 +0000 Received: by outflank-mailman (input) for mailman id 519629; Tue, 11 Apr 2023 11:21:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmC3o-0002G8-Oj for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 11:21:16 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f77e551e-d85a-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 13:21:14 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Apr 2023 07:21:12 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM8PR03MB6229.namprd03.prod.outlook.com (2603:10b6:8:24::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Tue, 11 Apr 2023 11:21:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.036; Tue, 11 Apr 2023 11:21:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f77e551e-d85a-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681212074; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=xv3mdbnecSply7SEWRhsOO1AtD/e1KmcibV1xhGs/Ho=; b=TVs12RONVfH/f6QThQ30ixMlr4zHUWWaLpJYAqtruPEqZTytrc0bt3O3 y3IcB34ZQjs96UXs+sPcq6CY/qYc8Xyj3Zs7NkzCuGnVrsEq5z8h8cM1W ALhCdpgAQYfSS8Y/XVHQmGGZ3OXcOLYf7/lYtm4b1mKwfVkEhj6u/77Oq o=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 105088851 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GpgvPqkkyEbcy2VIO7nafd3o5gxMJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdXWGBMquCNmr2ct1/adu19U0C68eBy4BhGwA4rSE3QiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgX5QaGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 d0CbzcRPzPdvt31zLbiTcNBqcpzIPC+aevzulk4pd3YJdAPZMmZBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkV03ieewWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTODgpq463QT7Kmo7ORwmcWCJoN+ArGGZVtRTK 1EbpiQrhP1nnKCsZpynN/Gim1afvxsbXfJRFfM78wCHzqfI4wefCXMARzQHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTSoNVw4M+dTgiIA1kBPUT9xnHbK1j9v6AjX5y XaBqy1WulkIpcsC1qH+8VWZhTup/8LNVlRsuViRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGe0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:SaC0SqgUzNIaoS31RKTXaRtKvnBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.98,336,1673931600"; d="scan'208";a="105088851" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ECABTnGxn/BCHjXlOaT3EWISMacfPIgxb+i3A1QgYV8aA769SsNyobmuXPn5yTieO62GErYSTUPrgL7QipEEpIWaue5AF6znshNaWpBx6uT4CNuMvCdpNmSKdMHABjUmUAgssAZXYCsTfvZYw5IExzRMQUuO31zIoevNresstLXFT6+ABGehg/Cm78Os4hp8kWPqqIRChXe9Ky06T+4DMIXf1lHtywQkgEvquERMXmTthOdXYLrahBjDgVGwN+vXnnKaSs/Q6gR4tthftzox2TOQfuprnnIY7R4j5XtS04G7c/yjLETdJGxq67IKTJx0xLi0RmV1gmF13N12i0g9kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mF6vPimqJVDHjhK2HcaQdB5HMWxQvcp8sa26GFl1IT8=; b=nwMpN3Vue2OrrBlrwiyHrx0tJzsSQNgy9H4dsdUll1u41EJ6JCIcDnpY+Ix5Q1O5kVEtT4xJ+CmBUIznLMG09IXc/aCLK3dX7SEdiSclP+MJew5YzpcxgGI7bLaBH9XxGL1LS107vy7v4zA8AqemFUStGz71WH3YszUdAFzqDm/c2BUcUNqhDisOyF7j2q9h1eEIKgxEAumAUh6TBi4tnjd6GXJRVYfvlOuCMFt5zDDe3OPb8WmaXZj+ycLnvM+Cdb5aN81e2sLzywI1ORXXJcJXaDwMbRhd6QatDtp3MZh+LgbtN6YAX6GG9GyKo0+3EZFy72YlzHC+HrRx5pxuXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mF6vPimqJVDHjhK2HcaQdB5HMWxQvcp8sa26GFl1IT8=; b=tTugQdwpMLyAP33XThmMHWOqaYkKhe36SGPnGeazXeagfU77f2WWTvDZ81FpnkQJyRvRiurPxTzIORpHj/O2zYLDW24WJOUifl0qT39NxOTlSL08S4VQ3poBS53oH2h+YOwmZykvF6QwRm+ZNC2eyleLaBJbDyy1UAWLIh2X/7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0ac3fce6-dcd2-4521-6207-ede4d90e656b@citrix.com> Date: Tue, 11 Apr 2023 12:20:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: RFC: disable HPET legacy mode after timer check Content-Language: en-GB To: Simon Gaiser , xen-devel Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0680.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::9) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM8PR03MB6229:EE_ X-MS-Office365-Filtering-Correlation-Id: 03dd4f92-6424-4dd0-684e-08db3a7ed8cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SuzMyLDS4eHsXMH3BBSem+AyVe2EJ8Z73W3t6VTfFKixo8yGhQF1DEl/6NmoyQSj7HilNfTAxoatwHeYAMG1oXCfO0d3U8ufuECk72qjAFsnEe1xC304zoBqc4a0dk5LmdavHjRUS+Vqckd7YO/kBWxUhusHr+FPL/yc2Ue0uLWXhMgGqNkprXcdosL5uN0T5h74Ey3I/flMPW+Dn5BtviAUGuhpGN/AiYBUy8IWi0bb5GPORks1QvBQOhDM720/XZR7ryurHvV9f1/ULKoqPDJcjSpeQ9hRIyV98kv+h/ibK8gKRZyALt1I6p5+xyNvtgwT2CwMNEeXXNyIYm1KpvewEM4T9ql28jdy6CtZS6zc+fuEGpunXAwTvCgDqQoK7wvxUh0bms4y8B5PClbdhLtF56C5xROFgJZ1PVOvx6dmABMPkcjLpXQPTipTVn06wqEQ2NU+cWjx8TBt6ouAHFNMtrQzFl3IwhK0+txktn3+RRDFGSquwODCtl60gTkFFcAzzzK5tuBc3inlBHietX4CMe5BQriccb5HETCImQ94vDL5NwwNSIK/YkJHD+94ovmm6h/BrWcyFYO2EXV3R+cCXu3aDt5rRhQ+v4Vc7EYrC4raF7A4Tsm79tyo+bNvGLOVNCqt/w/ZsH5VrBS9Jg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199021)(86362001)(31696002)(36756003)(53546011)(6512007)(6506007)(26005)(186003)(6666004)(2906002)(2616005)(478600001)(4326008)(66476007)(316002)(6486002)(8676002)(66946007)(31686004)(110136005)(41300700001)(5660300002)(8936002)(83380400001)(66556008)(38100700002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djRtWGdkQzR6U1RuVWJ0Vlpyc3RTWUJBWHh2WHcyZ05KUm9QNWRjL1RITG9k?= =?utf-8?B?dVlnanRhRzNmNXFjaUF4bnF4a1dlcVFoYk9qSWR0L2p0d1R5WXNhYjBUalBX?= =?utf-8?B?RzRnZDNtdFpEbnB6dWdpVFlxWkVLMjJIclRYVTFEMFgrMmE5S0t0aTVsM0x2?= =?utf-8?B?LzFycFBLVFU3c3FNelFsZlNQb3BVb2F3WGFPa3pSWGNjRjZjbWlscm5ucWlT?= =?utf-8?B?bmJpQ0JNUUprUnhldDYvUDRDUm9LSDcrOTIzMjh5ZzQ3OExZV2dwSDkrbEtC?= =?utf-8?B?NGQ0Y1BHcVFjNUlsVmVSRUZBWGZjTHJTR1A0bnNSeTAvVnNPNkcyaGxHbGdh?= =?utf-8?B?U2IzQ2pMVW9JYnNCT0pEbkc4SkNIUEwrVnEwSzJXeXlwcmo5SmZ1a1lUUm0v?= =?utf-8?B?d2EvS1FNWnE5dytFRXJQOGZMZTFKRXBHcnFHbG45dXVMRHhpdHN4elNBd3hC?= =?utf-8?B?N290SE1MQVQ2b2M4ZHlUNkZOQThNdDJ5dkVQUWF1RW5sWmRWMzNDbjg1TFZk?= =?utf-8?B?ZkZoc0xKeDlwdGE3NnlhMU5xZ1IvSWJ1eGc2ZVRoSEhrODREVjBNSEo0NWlE?= =?utf-8?B?d0hPc2FOaVl3RVlIMC9PN2djeXZrQjhtVy92ekFOd2UrUGxnZHNDOWowWUZo?= =?utf-8?B?dkZFN0xCQVgycTl1OUkxVUdWQ2VtdWljSkEzaXh4dWM2dHBibmVXeXYrenk1?= =?utf-8?B?UjBwcnU4ZHJQUFdQVHc4MXhRbVVYbyttVEtpZlA1bTZVUUlFTjMyY3hDM3g4?= =?utf-8?B?QzVIa2VrYUZYY0t0bEpEczBYM2tYSnUwaGhjZGtrQWZuQ1pCKzZhZEVsMVFh?= =?utf-8?B?VURBWXU4bUdGTlBSRWVydmpEeUJsbklCODZUbnQyVE5vc2xtM2JMNG8zZjNh?= =?utf-8?B?MENJelBxSXdvWWx1bTRLVHgvN1RXL0lLVG1HMGZJbmxOczVKNGZJQmx4c0ZV?= =?utf-8?B?VlE2MnUvMjQwcDc2ZTVkaVhBUEUyZ2lSbXBSYzhxaXVRaFVsWGwwbEFreHZC?= =?utf-8?B?czF4Zlg5bEdSazdHZG11RmlGZTV6WEE3RVcwT0xQSEk4UWMvdkFnejdjdHNH?= =?utf-8?B?bk5WZHlETFNyTEJBLzY1QlYzRGtkeXExZDk1WUJVUFJTQU41V3JpamhJV1dF?= =?utf-8?B?dXFvRzRtK3I1RFdYTlpxdzMvc0lwcitLeFZWSytNcWwwME13NjUxUFRQKzJF?= =?utf-8?B?UTdVcEduL0IrV0dUYlB6LzV6QVFiY1lkRTg4WVpjZlhRL1VrTFZEcVEwaWR6?= =?utf-8?B?blVWMGlGdDV4dkdhVGwxV2xPTlg0M05YVU45R2Z3VXpwaGc4SUZMb3gvWStH?= =?utf-8?B?SXhjVDI0OVRUL2h2K2xNaytOazZWbkFJWkRqMkRCWWtUQUVZZEpMSGhORVlo?= =?utf-8?B?RWg2Z2ZIUmRQMUNZdk4rdlB0NFdxY1RzdHkxRjJsbFp5bEhSNUU2U0JsRnZX?= =?utf-8?B?OXpuVUZUZUJpL01HRHY0a2RGRkIwNWp0YktlUmZSbHp6eEpVcG85SXdkcFQ4?= =?utf-8?B?cGg4T0VkL040L1drU010eDZkNk1zVjExUGYzdXg4MklBVzBCSy9BcWVzbnlz?= =?utf-8?B?WmYzQTRkNTd6OE8zMlVaVnJQU3NoaU1SeTBTa0dLNEtPQmxiZ3BVZERCbjRr?= =?utf-8?B?a0RxSnd3NDlRQXY4UnE2ZVp3aGhrbW15Z3hwU2JkeVNjbURramtzYmxYU1NO?= =?utf-8?B?TDUxUEtybUhwdEJVNzl6bDQ1Mm40OEtkNVcrakFlelBJRlcvTVpLdk1VSGkz?= =?utf-8?B?QldxUXdPdXpSVVNKRkhUNzFkMmdScW9sdk9VamRrTENVWmU2UGl2bWFER1Zn?= =?utf-8?B?cjRIZjBiay9WUjRaczJDd1d6Z1Z0UEhpWS9lRURJOFZGbkM4TVFSN1dPYk03?= =?utf-8?B?YlhoMTB5dXkrSG9PN0NRWVBjbVBybUlVN214V2N5bFQ5M1JhNjJVeEMveDNo?= =?utf-8?B?Y25ScTJUY3d4Q0R2cmZ0dXVLa1E0RWpBcjFWNHhFOWs1WE5TSmd1dlVBbFQz?= =?utf-8?B?czQ2QkVka1dibi9WNndQWWU4czJxZ3l5M2lvRGloMGV5T3dZM0IrWjFPQ2dI?= =?utf-8?B?L1Q3OVQrN3J4c0ZTK01pY3AyS0h6a2F2QW1ybnUzS0xqN0ZTU3lNaDNkdGRD?= =?utf-8?B?QzJsVEtWK0ZYS3dFZGU3WS9wWUR1QllLTTN5eEhnREdrRU5rUEVuc2F5UTJT?= =?utf-8?B?bEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K5pixMSOq2MOuqbrnZDyvBMa90SPZzvEhxnsalIHOaDMzi2RXTd4sRv1FUYu3NP97Te2M6BgV81WP8ApATdPGCoxbo0BNgFh62b8XoLDhWzjtKTBivy/rzz27HhyKRTJVh88hykUyw1SJtNSYE4OjZX8XRp6X+nTwTwVbpMcrjqX5biqnNZfr8HFSxnyKj8V5igCEJ/gOoD5h3haspwJxmQte2yOngUBN4ASYQp2zyElTU/CuCKJ18oUourkcWtovdewbedvOzkraw+4bSus8R7fwXvnXuRUF8N19w6OAL7Sshqm1IixCwk/asKPn+KQUFbiEd9v3Co1+YqkE8jhCwJ0rRxTXzEejsqooBQ9z59/FML7ZU6m2qFUQ+JfyIq3QOBH/oA3KJQbwFaKtFr6+6MUGFUUjbZsCINZb9m36yxF8Hwh59V76wGQ7hnK4nSLTtuRNbDRujUzRRByY4KIvfEddFSl7SwS3nFggsvshd5B77R1m9eKRVvFlQP/d/bDbQAO5u+WrJKJw86c+0OWyxZ8+XSkZThk/XQg21t492Weus0W1YmYi+soxWDMEbOMwZY1NzBiDj9ov/ZhSuTu3bJRNU0retbZleF7QPfAC9yGH8HZ8H6e+FbHJ4C8fRbkHxwIQIXQIg03l8me7nRAEQWeAMYj07XYeMrrnq1CUvE1fZrSRam6VLnBVhtafdyfGnURrAXw4JH4nuFXmNjM8LG8bnLNCgLL8PcjrLWRX6sHITc2D1pXeaoJ00Iz546oQfX4uw1SFH4qsNdpVQD5NgRVuVgvrshToL5v8o297MHzimrJ8zj7ENEVqzQDxvlLahfOWPo3qf9gEEDOPzgUGw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03dd4f92-6424-4dd0-684e-08db3a7ed8cc X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 11:21:08.3674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WXRyY/d1FOnC5J8q/+2tF6CwxMHpSnR9th5E1JS8mjs+z0QF5eTf2SoikSBmS6in4708SomZgh7Pu6kGx0B3t0Ifz1qR/W6E/bFNVh/i/6M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6229 On 11/04/2023 11:30 am, Simon Gaiser wrote: > Hi, > > I have been recently looking into getting S0ix working on Xen [1]. > > Thanks to a tip from Andrew I found that the HPET legacy mode was > preventing my test system from reaching a package C-state lower than PC7 > and thereby also preventing S0ix residency. > > For testing I simply modified check_timer() to disable it again after it > checked the timer irq: > > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -1966,6 +1969,8 @@ static void __init check_timer(void) > > if ( timer_irq_works() ) > { > + hpet_disable_legacy_replacement_mode(); > local_irq_restore(flags); > return; > } > > > With this [2] I'm able to reach S0ix residency for some time and for short > periods the systems power consumption goes down to the same level as with > native Linux! Excellent progress! > It reaches low power states only for a fraction of the suspend to idle > time, so something still makes the CPU/chipset think it should leave the > low power mode, but that's another topic. Do you have any further info here?  There are a range of possibilities, from excess timers in Xen (e.g. PV guests default to a 100Hz timer even though no guests actually want it AFAICT), or the 1s TSC rendezvous (which isn't actually needed on modern systems), all the way to the platform devices not entering d3hot. > > I tried to understand how all the timer code interacts with disabling > the legacy mode. I think it only would break cpuidle if X86_FEATURE_ARAT > is not available (Which is available on my test system and indeed I > didn't run into obvious breakage). > > Is this (disabled PIT && !ARAT) a configuration that exists (and needs > to be supported)? > > Did I miss something else? (Very much possible, given that this is way > above my existing experience with X86 and Xen internals.) Xen's code is a mess and needs an overhaul. Right now, we're using the timer as "a source of interrupts" to try and check that we've got things set up suitably.  But this doesn't need to be the PIT, or a timer at all - it just needs to be "an interrupt coming in from the platform". Furthermore, there will soon be client platforms with no PIT/HPET/etc at all.  (HPET is known broken in Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 12:40:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519649.806611 (Exim 4.92) (envelope-from ) id 1pmDIE-00026P-TA; Tue, 11 Apr 2023 12:40:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519649.806611; Tue, 11 Apr 2023 12:40:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDIE-00026I-Ol; Tue, 11 Apr 2023 12:40:14 +0000 Received: by outflank-mailman (input) for mailman id 519649; Tue, 11 Apr 2023 12:40:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDID-00025y-RB for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 12:40:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDIA-0005UB-L8; Tue, 11 Apr 2023 12:40:10 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.30.1]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmDIA-0003xn-DP; Tue, 11 Apr 2023 12:40:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=UiXpTl1a3tG+ZCl5AQUOykdSeTWIEtGDm225q3yNNVo=; b=mPdQ4uLy7ViBBQ8Lh7Nx61rIce XL26Et34t/buVnZkMLO+0k1L966qONZqTYqaXGPugeiGeP77bWbDAsZqt0u8EwoJyPSML8HBjtPbx 6hwSJHQt/D1H9ZPixPQY7yNEXDKfPtY/W8C68iOL0JRbmy6iG2iZHacYDQ88CcJZcYQ8=; Message-ID: <235a284c-48d6-fda3-2aa2-3670856d1547@xen.org> Date: Tue, 11 Apr 2023 13:40:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c Content-Language: en-US To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , Stefano Stabellini References: <20230327184520.81828-1-julien@xen.org> <20230327184520.81828-3-julien@xen.org> <96d6a307-14dd-aa0e-4039-d84d67cf7ed6@suse.com> From: Julien Grall In-Reply-To: <96d6a307-14dd-aa0e-4039-d84d67cf7ed6@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/03/2023 10:16, Jan Beulich wrote: > On 28.03.2023 02:53, Stefano Stabellini wrote: >> On Mon, 27 Mar 2023, Julien Grall wrote: >>> From: Julien Grall >>> >>> It is easier to understand the license of a file when using SPDX. >>> >>> This is replacing the below pattern with the SPDX tag GPL-2.0-only >>> in xen/arch/x86/*.c: >>> >>> * This program is free software; you can redistribute it and/or modify it >>> * under the terms and conditions of the GNU General Public License, >>> * version 2, as published by the Free Software Foundation. >>> * >>> * This program is distributed in the hope it will be useful, but WITHOUT >>> * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >>> * more details. >>> * >>> * You should have received a copy of the GNU General Public License along with >>> * this program; If not, see . >>> >>> Signed-off-by: Julien Grall >>> >>> --- >>> >>> Changes in v2: >>> * Switch to GPL-2.0-only >>> * Rebase >>> >>> 42sh> cat gpl-2.0.txt >>> * This program is free software; you can redistribute it and/or modify it >>> * under the terms and conditions of the GNU General Public License, >>> * version 2, as published by the Free Software Foundation. >>> * >>> * This program is distributed in the hope it will be useful, but WITHOUT >>> * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >>> * more details. >>> * >>> * You should have received a copy of the GNU General Public License along with >>> * this program; If not, see . >>> 42sh> find xen/arch/x86/ -name '*.c' -exec replace_license.py gpl-2.0.txt GPL-2.0-only {} \; >> >> I confirm that the commands above lead to this exact patch. I ran them >> on my system and checked that the resulting changes are the same. >> >> Acked-by: Stefano Stabellini > > On this basis then also > Acked-by: Jan Beulich > for this and the subsequent patches. Thanks. I have pushed with the series with both of your acks. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Apr 11 12:53:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 12:53:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519653.806621 (Exim 4.92) (envelope-from ) id 1pmDUt-0003dN-0j; Tue, 11 Apr 2023 12:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519653.806621; Tue, 11 Apr 2023 12:53:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDUs-0003dG-TO; Tue, 11 Apr 2023 12:53:18 +0000 Received: by outflank-mailman (input) for mailman id 519653; Tue, 11 Apr 2023 12:53:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDUr-0003d6-TR; Tue, 11 Apr 2023 12:53:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDUr-0005gW-Pp; Tue, 11 Apr 2023 12:53:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmDUr-0000Qw-BB; Tue, 11 Apr 2023 12:53:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmDUr-0006qH-Af; Tue, 11 Apr 2023 12:53:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zMVQ13PDCxim6hymiWfz/yn93WLKDbNCJcEfrrqDoLQ=; b=f7L++lcvekBnOL7h5pnTtUqw7y kvso/712BY1AszIodztTw0QRzWjhuVU06Trt3vY3/1XVTI21f9H5Lx75Nyj2qDGdpMn9nzKv+THTr tWl9BEKCNGkOWpYKIzyQGdz5VSvPV1Ht1p7SUuCRZzM0qs5w/3Z3pjoAQiGytyMhnCWc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180200: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 X-Osstest-Versions-That: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 From: osstest service owner Date: Tue, 11 Apr 2023 12:53:17 +0000 flight 180200 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180200/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail in 180192 pass in 180200 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 180192 pass in 180200 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail pass in 180192 test-amd64-i386-xl-xsm 7 xen-install fail pass in 180192 Tests which did not succeed, but are not blocking: test-amd64-i386-pair 11 xen-install/dst_host fail like 180192 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180192 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180192 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180192 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180192 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180192 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180192 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180192 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180192 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180192 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 baseline version: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 Last test of basis 180200 2023-04-11 01:53:29 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Apr 11 14:21:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 14:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519663.806631 (Exim 4.92) (envelope-from ) id 1pmEro-0004LX-Ek; Tue, 11 Apr 2023 14:21:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519663.806631; Tue, 11 Apr 2023 14:21:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmEro-0004LQ-BG; Tue, 11 Apr 2023 14:21:04 +0000 Received: by outflank-mailman (input) for mailman id 519663; Tue, 11 Apr 2023 14:21:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmErn-0004LG-3Z; Tue, 11 Apr 2023 14:21:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmErn-0007i6-14; Tue, 11 Apr 2023 14:21:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmErm-0003TS-HY; Tue, 11 Apr 2023 14:21:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmErm-0006yP-HA; Tue, 11 Apr 2023 14:21:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oViWm03fcP/JOWc+IsE7owOrN8Cx8w79BBCUGqgy9lg=; b=03tu7jy4i8HBMNXouMAfKMYqPG TQejnX4HoZp3b+dht7kgn6/EbBiCjFMcVNwyh3+0Om7XYc2kW0wvAFO1GKjBOzhvl/wyWSDoyM2L+ mnOz/bj8jkTNsfwYFMfidMYBejRuIwB7BvGO8hbtmmxXXLXQFpc/AkfE4rWgcrhbyQI8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180205: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f X-Osstest-Versions-That: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 From: osstest service owner Date: Tue, 11 Apr 2023 14:21:02 +0000 flight 180205 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180205/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f baseline version: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 Last test of basis 180171 2023-04-06 19:00:24 Z 4 days Testing same since 180205 2023-04-11 13:03:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ddaf7bb0cf..5ea03c570c 5ea03c570c8610d4359f8bbf5f093d215344ce3f -> smoke From xen-devel-bounces@lists.xenproject.org Tue Apr 11 17:47:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 17:47:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519752.806679 (Exim 4.92) (envelope-from ) id 1pmI5k-0001zV-8F; Tue, 11 Apr 2023 17:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519752.806679; Tue, 11 Apr 2023 17:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmI5k-0001zO-5k; Tue, 11 Apr 2023 17:47:40 +0000 Received: by outflank-mailman (input) for mailman id 519752; Tue, 11 Apr 2023 17:47:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmI5i-0001zI-P1 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 17:47:39 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0cae525-d890-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 19:47:35 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-94a356c7419so213604466b.2 for ; Tue, 11 Apr 2023 10:47:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0cae525-d890-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681235254; x=1683827254; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=89D/U2/ABD8Hnu1Y3Qqw4jqD4G1xSecynmnwgvqJh1E=; b=YnBxk/BjOwvAHI0NJ7QNqauiFlUOEHqqJtYcO4wshZ5d4biGRT67xd+gtKmL2yTAG1 /spFeX1cHhQgfRHw3qLE5gFE7DRVJIMjMwU0DKeOPP0up7qHE+6ksN0ALNPK6hDQfnEC 1sV/LtYwA/6V9r7/ZEqPfrGe5yyGQXOSKvcaxXB4v6K6z1xRdLMUuK2JPIv3XQ3tgxtX p3Ltf49Z5yLqWpbA8sgb666/3Gc2TXDl8ibXyTw+niQhw+3KVsqdSceIVC0Vi+7rN3c8 cmNFc/doZli6PfAphk5aF7x2UCDJ1v0sdXqMpgHst/1sSiaUnbaNpir21qrErLs7O43a 94+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681235254; x=1683827254; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=89D/U2/ABD8Hnu1Y3Qqw4jqD4G1xSecynmnwgvqJh1E=; b=D+Kug/RWbwvJ/XkWufEbRly7eH5prDZT/oO/GaR0pzBQy1zbH0q75GaZcdg6M8zSFS OZgfHVcKIrnx1bhYAo9W7FT5IYnzSNFZzEYBec1uUS8ndNlLc14L2X/wC2WoxTq3BRG+ MlfYcXRanUoeN/ANTWj7hZQhUtQHQaXSmNhAmpFbLwWdHSVhxtJmST0hoGpPvtecvABe IJbwKsFnw9p65/sqbf/d9FqSJ+phPGMlqLh/MdfQLUNXRKgj6EHW608IFdPHhDGo/QFJ 7E9mSmZu74NnKznqeMBGd6fH22bHBP6d9JL1JZfqVzo64Yk4GMGn1r2YWD3o50cBEYd3 1/CA== X-Gm-Message-State: AAQBX9ejJMVs+nsq7XSqtFwcyb+GP87xVkq51m+QglLAukywmDcY9AKO ZVVMBOIYWmiWwue4Az6E0k6nRPogCCDgZ0TC0qT8xg== X-Google-Smtp-Source: AKy350ahP395VbSvIx11nYGRgeo6TcVvzT9+ov1e9nkBImUEMlhVDS3j04fcNMoH4CH/1w9Xg8+N3piLIX+Q3hmx3y4= X-Received: by 2002:a50:baea:0:b0:4fc:fc86:5f76 with SMTP id x97-20020a50baea000000b004fcfc865f76mr5594114ede.6.1681235254106; Tue, 11 Apr 2023 10:47:34 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-23-dwmw2@infradead.org> In-Reply-To: <20230307182707.2298618-23-dwmw2@infradead.org> From: Peter Maydell Date: Tue, 11 Apr 2023 18:47:23 +0100 Message-ID: Subject: Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Now that we have an internal implementation of XenStore, we can populate > the xenstore_backend_ops to allow PV backends to talk to it. > > Watches can't be processed with immediate callbacks because that would > call back into XenBus code recursively. Defer them to a QEMUBH to be run > as appropriate from the main loop. We use a QEMUBH per XS handle, and it > walks all the watches (there shouldn't be many per handle) to fire any > which have pending events. We *could* have done it differently but this > allows us to use the same struct watch_event as we have for the guest > side, and keeps things relatively simple. > +static struct qemu_xs_handle *xs_be_open(void) > +{ > + XenXenstoreState *s = xen_xenstore_singleton; > + struct qemu_xs_handle *h; > + > + if (!s && !s->impl) { Coverity points out that this will dereference a NULL pointer if you hand it one, and will happily let through a XenXenstoreState where s->impl is NULL. Should be "!s || !s->impl" I guess ? CID 1508131. > + errno = -ENOSYS; > + return NULL; > + } > + > + h = g_new0(struct qemu_xs_handle, 1); > + h->impl = s->impl; > + > + h->watch_bh = aio_bh_new(qemu_get_aio_context(), be_watch_bh, h); > + > + return h; > +} thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Apr 11 18:07:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 18:07:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519756.806689 (Exim 4.92) (envelope-from ) id 1pmIPG-0004aO-S2; Tue, 11 Apr 2023 18:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519756.806689; Tue, 11 Apr 2023 18:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmIPG-0004aH-PY; Tue, 11 Apr 2023 18:07:50 +0000 Received: by outflank-mailman (input) for mailman id 519756; Tue, 11 Apr 2023 18:07:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmIPF-0004aA-0d for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 18:07:49 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c372ae83-d893-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 20:07:47 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id sg7so33995401ejc.9 for ; Tue, 11 Apr 2023 11:07:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c372ae83-d893-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681236466; x=1683828466; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=p+ZXlQzojGZSUw8Sbrj54moAbTxBe6kr2mEZxRk868M=; b=htQd6MnaVmc6ChTU9ga2AKBuKN/jMCHPNppmEK68X4N53Qb1vdWgV8+ScDciTYIfNf yTTv+p+l/7zd7JnjzLpoI0T9rpGVoM3rBovx9O9MYXZOOZAHEGAEofuZXYNMCMm4S2je HrVEnuiyo58GeRHtEWg1acuDtaAm6cAXPjFpqpLP5RG7wvqkVgDZy63tt4L/jkH3PrAd Sr0luoY0PXQkxG7c620MMgKqeEVWRqOW0XxeVlYVPHJ9+xt8lWSFR5GsDF9XgX9moyki BeRspCtNH3VYVNWx8BrwC9LwJQBkchSkeHcXsjk9cpa6LVSFcMgpqK+vqEBZEk7zBBSP tJPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681236466; x=1683828466; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p+ZXlQzojGZSUw8Sbrj54moAbTxBe6kr2mEZxRk868M=; b=rxAfwC4h7aLRzzI/ANzKh2HJT5OM+2tRQK+HN+jFo+Lx5sRq2YQEKzHO1zoIOxgN66 iDM4+1RdeDQ6Q20cK7vBJpeYgn0DQt3MdpTFhHfBNq7AV73Z6IVJh9YEtzSjxLVAZbHL hKc6VaFGkBUhKk64k4A2WWZPW5StDONIkbJSbPP+4/F4va3KoYCSXGg3ELF5YAFpg2Uk ewN4h0crTHFycOi6XlaQ5j/4NeNkisP1Dd2maj/fCQfM1qd76Sqmlm3bL6YzvUcsWDrg BduNI0Ppys5+DQNJf1gbYzOd1sHI4Yn6gWJkWeQHMEPHz9mr+tGfUqkU/fskDBHrx+aL nKUw== X-Gm-Message-State: AAQBX9fezB8PnJNPFbw0R1MEohjWcrVbQY8geySekq1pnzXCxfgawa4g BkBCd8OnsVxa6VjmnAunwo2aCdWa00XPUtFI2PuHmA== X-Google-Smtp-Source: AKy350aJKxcJXaacrbJSaqSrXddCMNffIuvTCBmwTQDw5caxmJIJZoc5CGUDO73D9H9Mawv/lNkDNQ71sykqnrtiSRU= X-Received: by 2002:a17:906:2a48:b0:920:da8c:f7b0 with SMTP id k8-20020a1709062a4800b00920da8cf7b0mr5987227eje.6.1681236466538; Tue, 11 Apr 2023 11:07:46 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-23-dwmw2@infradead.org> In-Reply-To: <20230307182707.2298618-23-dwmw2@infradead.org> From: Peter Maydell Date: Tue, 11 Apr 2023 19:07:35 +0100 Message-ID: Subject: Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Now that we have an internal implementation of XenStore, we can populate > the xenstore_backend_ops to allow PV backends to talk to it. > > Watches can't be processed with immediate callbacks because that would > call back into XenBus code recursively. Defer them to a QEMUBH to be run > as appropriate from the main loop. We use a QEMUBH per XS handle, and it > walks all the watches (there shouldn't be many per handle) to fire any > which have pending events. We *could* have done it differently but this > allows us to use the same struct watch_event as we have for the guest > side, and keeps things relatively simple. > > Signed-off-by: David Woodhouse > Reviewed-by: Paul Durrant > +static void xs_be_unwatch(struct qemu_xs_handle *h, struct qemu_xs_watch *w) > +{ > + xs_impl_unwatch(h->impl, DOMID_QEMU, w->path, NULL, xs_be_watch_cb, w); Coverity points out that this is the only call to xs_impl_unwatch() where we don't check the return value. Is there some useful way we can report the error, or is it a "we're closing everything down anyway, no way to report anything" situation? (This particular Coverity heuristic is quite prone to false positives, so if that's the way it is I'll just mark it as a f-p in the coverity UI.) > + h->watches = g_list_remove(h->watches, w); > + g_list_free_full(w->events, (GDestroyNotify)free_watch_event); > + g_free(w->path); > + g_free(w); > +} thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Apr 11 18:35:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 18:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519760.806700 (Exim 4.92) (envelope-from ) id 1pmIqB-0008Al-0d; Tue, 11 Apr 2023 18:35:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519760.806700; Tue, 11 Apr 2023 18:35:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmIqA-0008Ae-U5; Tue, 11 Apr 2023 18:35:38 +0000 Received: by outflank-mailman (input) for mailman id 519760; Tue, 11 Apr 2023 18:35:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmIq9-0008AU-LM; Tue, 11 Apr 2023 18:35:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmIq9-0005TK-I7; Tue, 11 Apr 2023 18:35:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmIq9-0005dD-06; Tue, 11 Apr 2023 18:35:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmIq8-0005Sy-Vv; Tue, 11 Apr 2023 18:35:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LBnWzs/U9QCWpGlHuuaTO3d+qvXmIMmgZdWYt5MPk58=; b=SlLgkza13KumwxwdtkX3r14U1i e6kF3hkbmbj8dUyf0hrAt6YOC51JvZj0Bh0SbJcWlY9onAzLKrpt6Om7ZEnA2c6undgMyCrVq6Yqv CyNo6xuYlbR8BDDv3s7b9VU1dVJCB1iiTgrN+OjjJdtiSgz+4qLqKWz5mzKuyULqPzPc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180204: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:guest-start.2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=dda860b9c031d6a2768f75e5e622545d41d4b688 X-Osstest-Versions-That: qemuu=26aeb3b5894e0f3d17354e306002c59fa060e1c5 From: osstest service owner Date: Tue, 11 Apr 2023 18:35:36 +0000 flight 180204 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180204/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 22 guest-start.2 fail blocked in 180198 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180198 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180198 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180198 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180198 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180198 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu dda860b9c031d6a2768f75e5e622545d41d4b688 baseline version: qemuu 26aeb3b5894e0f3d17354e306002c59fa060e1c5 Last test of basis 180198 2023-04-10 21:08:28 Z 0 days Testing same since 180204 2023-04-11 09:38:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Mark Cave-Ayland Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 26aeb3b589..dda860b9c0 dda860b9c031d6a2768f75e5e622545d41d4b688 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519769.806740 (Exim 4.92) (envelope-from ) id 1pmJUI-0004zv-8U; Tue, 11 Apr 2023 19:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519769.806740; Tue, 11 Apr 2023 19:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUI-0004zo-5D; Tue, 11 Apr 2023 19:17:06 +0000 Received: by outflank-mailman (input) for mailman id 519769; Tue, 11 Apr 2023 19:17:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUG-0004Ta-DQ for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:04 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062a.outbound.protection.outlook.com [2a01:111:f400:fe5b::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f9ec66c-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:02 +0200 (CEST) Received: from BN9PR03CA0074.namprd03.prod.outlook.com (2603:10b6:408:fc::19) by DS0PR12MB7927.namprd12.prod.outlook.com (2603:10b6:8:147::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Tue, 11 Apr 2023 19:16:59 +0000 Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::4b) by BN9PR03CA0074.outlook.office365.com (2603:10b6:408:fc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:16:59 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:16:59 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:58 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:57 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:57 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f9ec66c-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsnvahqefEJcrGbq8TaKoxKIRcJ8k6g3h4CnC8ViW6gsJNOkIj7iYXQL9Ii413JsBQybdidGJ6LrYp4fbkQfkCB+uk9G8JtQNGWQEg7I2zZVvPT0EekScDapJsrHJ2zroYwVXqobef3b6SibjN1W95m4XVNV8awgAgRxS+ctdQe76N96+hxiTZeE6koUtR3VImFtKbEN7dLGN9hrSzfE8pxKNgYKtUkx5df4BxHctIT+EYRqjZiKki1Ixz3dScKqCfPRWYYBMY/C9zXeYJx1kov8c46c5urOiOJlWKEhQzyGMoDaeydbYpyedbXcu8qGhtYFZ2jrveqP13TX74XUSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aXlXQRcv7U/T/rRXFeXTNVQL0ZVDEHTt5u8gFMIkdTA=; b=L19PP9YIoz2ENayQ10udRQtImwhc0jGVL9fhd/yJy3oG4NYnKeU5Uo7S9PfQ9S8C1q+F4AwS7Y77NS815xEiRFBaNIOjsCyiACllRlkf8xpQYjufEogNI1/VWI9eg7Am75r3yQL14wxPA0vDfIwf8/6m9kPfVD1Vqw1QEzg7RC+e1UwfTZBxCjLz0wKU3mIcfVUrw0bJmuGMsNCCKlVGcwz2mvlqPpWHMLSxVYXyT6DuugcjRPXS2YanxJLXxvxMB+b8bGYlUNFrk6RRU3hRJjZHjJkQnbf1S2sz5s3uYyet8zguNevVPntPXjgvfXEy9umt/iGpNr6PZusNGspcJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXlXQRcv7U/T/rRXFeXTNVQL0ZVDEHTt5u8gFMIkdTA=; b=WEz5Ij5Kp8boEyjMUb91XSI7OHDNJpWmshSsP8z3y16orb5bMbZYN4Ifo6hwDNVLqS9pcLJn7M7tz6Hpl6WM6nVl3T2uL2+3WmAzWkPtgLlRVYNE7KBVjbwOq/kRR34spEH0g+H7ltXDphzhcRAXoKFJL30lTxKV8Cm8wEzuk5w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Vikram Garhwal , David Gibson Subject: [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target() Date: Tue, 11 Apr 2023 12:16:06 -0700 Message-ID: <20230411191636.26926-6-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT066:EE_|DS0PR12MB7927:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f074106-fed4-47f9-7c35-08db3ac1529c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oC7YWE9imiHPDPvyBdq1PTLkB0ISDaGkF+VlhetZPVZnrzr6qM7i8dNDmV+QzgsOCOuzwqrGgKNhT6Gc22W0h6Jl/VO52RYpH5NKqj6nuXeOvhDgl5n1sZfailtvZQ88ra2YqPqoWwMRZ/ranbQZks7SlxvR9ZlSLAbrSFWtdAI34AOBnT71936i+XeHyBYcVEF/jOWTxjkh/+G45mkAZLAGk32lNWO7+a0YoA55yRJDH5xXnogPn3Oqx1XIFtciV347wsEzKAHR/q5xdxufvwgEuBDl0xOC5mxRQ+FOxXjsenAxKvYFPe5qgzV08T1nisxhvhRijfLnun7V25nvhtfCXFCf+A2UTc1DtYM6oe2k0vbMOqhnAYKnwVMNkHszSH897j6urVNiCCXBv+SeywRIahq1UOkE9rHubtMSbGU7Bgh3uczPNvtnDxuc9yjluZZ/3UFlw9ymuEWobZgLUULm812dpGF2tKKTCu7rUz6qRg0clEn/C4NfeKoeGw2eQnPQRcGNOBdoc38sFsycpXmByMev6cjJxEVKXcaLXzH48i3nRDdI57qPVYuvkt3zWy/ri3F6DbdkhSXIIX6EWE+EbF4BziXbNg/ovhq0lb891h54Gpe7MePtoE+87lj72BOYskDuhcpNVoO/NCN7u9vRlpXEi/C5sECMSM31b4uyhfDxhXHIaU8+69B/HAcsq73Pb+ALVezM4Jeq7j1OBL8v9Evy9xODkhsWbiLMfmw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199021)(46966006)(40470700004)(36840700001)(47076005)(82740400003)(36860700001)(40480700001)(2616005)(426003)(316002)(966005)(26005)(478600001)(6666004)(186003)(1076003)(54906003)(83380400001)(2906002)(336012)(81166007)(8676002)(5660300002)(4326008)(36756003)(356005)(40460700003)(44832011)(6916009)(41300700001)(70586007)(8936002)(82310400005)(70206006)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:16:59.1674 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f074106-fed4-47f9-7c35-08db3ac1529c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7927 Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays because Xen needs to do further processing of the overlay nodes, e.g. mapping of resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc. Signed-off-by: Vikram Garhwal Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> Signed-off-by: David Gibson Origin: https://github.com/dgibson/dtc 45f3d1a095dd Signed-off-by: Vikram Garhwal --- xen/common/libfdt/fdt_overlay.c | 29 +++++++---------------------- xen/common/libfdt/version.lds | 1 + xen/include/xen/libfdt/libfdt.h | 18 ++++++++++++++++++ 3 files changed, 26 insertions(+), 22 deletions(-) diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c index 7b95e2b639..acf0c4c2a6 100644 --- a/xen/common/libfdt/fdt_overlay.c +++ b/xen/common/libfdt/fdt_overlay.c @@ -41,37 +41,22 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) return fdt32_to_cpu(*val); } -/** - * overlay_get_target - retrieves the offset of a fragment's target - * @fdt: Base device tree blob - * @fdto: Device tree overlay blob - * @fragment: node offset of the fragment in the overlay - * @pathp: pointer which receives the path of the target (or NULL) - * - * overlay_get_target() retrieves the target offset in the base - * device tree of a fragment, no matter how the actual targeting is - * done (through a phandle or a path) - * - * returns: - * the targeted node offset in the base device tree - * Negative error code on error - */ -static int overlay_get_target(const void *fdt, const void *fdto, - int fragment, char const **pathp) +int fdt_overlay_target_offset(const void *fdt, const void *fdto, + int fragment_offset, char const **pathp) { uint32_t phandle; const char *path = NULL; int path_len = 0, ret; /* Try first to do a phandle based lookup */ - phandle = overlay_get_target_phandle(fdto, fragment); + phandle = overlay_get_target_phandle(fdto, fragment_offset); if (phandle == (uint32_t)-1) return -FDT_ERR_BADPHANDLE; /* no phandle, try path */ if (!phandle) { /* And then a path based lookup */ - path = fdt_getprop(fdto, fragment, "target-path", &path_len); + path = fdt_getprop(fdto, fragment_offset, "target-path", &path_len); if (path) ret = fdt_path_offset(fdt, path); else @@ -638,7 +623,7 @@ static int overlay_merge(void *fdt, void *fdto) if (overlay < 0) return overlay; - target = overlay_get_target(fdt, fdto, fragment, NULL); + target = fdt_overlay_target_offset(fdt, fdto, fragment, NULL); if (target < 0) return target; @@ -781,7 +766,7 @@ static int overlay_symbol_update(void *fdt, void *fdto) return -FDT_ERR_BADOVERLAY; /* get the target of the fragment */ - ret = overlay_get_target(fdt, fdto, fragment, &target_path); + ret = fdt_overlay_target_offset(fdt, fdto, fragment, &target_path); if (ret < 0) return ret; target = ret; @@ -803,7 +788,7 @@ static int overlay_symbol_update(void *fdt, void *fdto) if (!target_path) { /* again in case setprop_placeholder changed it */ - ret = overlay_get_target(fdt, fdto, fragment, &target_path); + ret = fdt_overlay_target_offset(fdt, fdto, fragment, &target_path); if (ret < 0) return ret; target = ret; diff --git a/xen/common/libfdt/version.lds b/xen/common/libfdt/version.lds index 7ab85f1d9d..cbce5d4a8b 100644 --- a/xen/common/libfdt/version.lds +++ b/xen/common/libfdt/version.lds @@ -77,6 +77,7 @@ LIBFDT_1.2 { fdt_appendprop_addrrange; fdt_setprop_inplace_namelen_partial; fdt_create_with_flags; + fdt_overlay_target_offset; local: *; }; diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index c71689e2be..fabddbee8c 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -2109,6 +2109,24 @@ int fdt_del_node(void *fdt, int nodeoffset); */ int fdt_overlay_apply(void *fdt, void *fdto); +/** + * fdt_overlay_target_offset - retrieves the offset of a fragment's target + * @fdt: Base device tree blob + * @fdto: Device tree overlay blob + * @fragment_offset: node offset of the fragment in the overlay + * @pathp: pointer which receives the path of the target (or NULL) + * + * fdt_overlay_target_offset() retrieves the target offset in the base + * device tree of a fragment, no matter how the actual targeting is + * done (through a phandle or a path) + * + * returns: + * the targeted node offset in the base device tree + * Negative error code on error + */ +int fdt_overlay_target_offset(const void *fdt, const void *fdto, + int fragment_offset, char const **pathp); + /**********************************************************************/ /* Debugging / informational functions */ /**********************************************************************/ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519767.806720 (Exim 4.92) (envelope-from ) id 1pmJUF-0004U6-Lt; Tue, 11 Apr 2023 19:17:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519767.806720; Tue, 11 Apr 2023 19:17:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUF-0004Tx-Hx; Tue, 11 Apr 2023 19:17:03 +0000 Received: by outflank-mailman (input) for mailman id 519767; Tue, 11 Apr 2023 19:17:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUE-0004Ta-U4 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:02 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on20623.outbound.protection.outlook.com [2a01:111:f400:7e83::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e0c351d-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:00 +0200 (CEST) Received: from BN9PR03CA0604.namprd03.prod.outlook.com (2603:10b6:408:106::9) by MW4PR12MB5601.namprd12.prod.outlook.com (2603:10b6:303:168::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:16:56 +0000 Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:408:106:cafe::3) by BN9PR03CA0604.outlook.office365.com (2603:10b6:408:106::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 19:16:56 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:16:55 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:55 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:55 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e0c351d-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5odVlwbleoZs5wA2Fen6R9qmt+TiYhz/GpyppkIzbqswKQkuXyCbkxlQkjB8nSBOC20onufEscuNKm8vNm/j8yfswu3WLAnPgPOmNfR0T9GpLsMwbeW08oSzC1XnlUtEyHEDQlWFwA0VgmbcWHu+8ImpdPqQNNPYJVB9kGOgqahApezPnCwhGAVm6Fk/gJlRBBaxRQU2dbVZQlrSGqFNw5ze+hpUvgkOqmrl0qa67NkZZzimM2in0Ulk6CErHvk43d48O/zoqDAx/6h/d2jN/HJ5cMTC0cdC4wsTytksf5KinwvIQS5rOH9t2nsVXBKrTq1ZGqTcEvHCDNupHfXYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0odwSwlZEbTJvdLLf27PaAsLK4pjjIm+Jsb7s8Lqv7g=; b=fR7WKLv54LP01SNa8MUepB3sId6Q718wi+GEOAuTATUVrbm5NmItXz521gJfoVce67ZdtDj3uDs+G6apBoBxTE+lCnDL+cIRrkpbDo+X29siGtAjog02PguifLjPmmhd8qYgMAvhHaDsn8UsmECzWKFzzUOhiLt4WhPPrKmffXvzcNBvFlzv6jZzite09ifNwof4EuwxN2kq2I3KKwQJaK/2yK/LxpPm5tIOOFf7NE7Y3kRp1BxBnxe34Tr9Stx0nbskob0ru6CJZf1I/vEDbXoZTHIrcEC4b542tPSX1IKI1PJ3H4zpeOLcL8feazxofP/zOOuTgyJ/MLkR38YXNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0odwSwlZEbTJvdLLf27PaAsLK4pjjIm+Jsb7s8Lqv7g=; b=Md5NgPnF/dZc6LSjpF9zQvCHu3SnY1fZQYKEa4Ctv2VO6o6TW+wqH6xsxLNdN88/nIjeb8ZQwPcGMwej8/143x3pPhkp5fPtJvG1Ou/G/K/OCJj1pfKEpnGaKFb417l4ClhSo/MkCvoC3HbxphnPRiypyMP4AOyNZm/zoYvzbgI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Date: Tue, 11 Apr 2023 12:16:03 -0700 Message-ID: <20230411191636.26926-3-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT052:EE_|MW4PR12MB5601:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a55ab8b-09ca-432d-daf6-08db3ac15098 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tRF8rJuNDr5YAn1IKIgQmYgV4Xg3sb4+bNUMt0OUvk/7+9ZimF1PYMvu+V9AR319u1kO/w+2FZjcOha9YM1YSyz8nG5g9SE5swyVF/F+bEKokoJeyZlCGBUMjnmu0lJE4JbCc3xzHtHKY5Ms/JgGqNJAt5aPewk/of/WaAL4Lj20+TsmvONcyw99ZcJdonUU5JqIXalTOBeCU6LUDFk2QU1Asw0Vm304GjCHVxWrqTSHrYN0E/jLVwB3f/+YW/1sPJuZeQNFvstg22Jw0OXhnltLLL2MXutboZ3A2s/JUu4+O14c7+3ikq0T0o1Vkeysarod4OYoIVZJaexZXZcmgJ3HapzUw5MVMbTil7/FvNupjYSq4qin63K9Xg/L/zSZqk5ZbWdqZTUCGXxCmlsIme6PMcpMpTSb1rJ73dYjHhzrz0da2vQtGwplOitZCAQm608CDDedenQ66kEZ+Bp31uBouNN4Ysj1zBuMIbCjBzgWSF5zGisvcxfBdidoqHKji3INiI+kzIbrWYl1yUso8UkOxMe+3AwCpH1jx0nxOTOxLi2WV3jUmxGgFs1fCcABD+iXeskYnd9CSFppMreCQiqmZixCd0zBtyd4oMmPL992mXabbPY4c872k51Exb4Q5U+9QvpVvdNU8vuDKrQsP4jufjckzAgiCd21astDPcag/QPqJbpZI2BGHExZBL57fhM9FJWIEbmXcPSsn+fF9vs/Emc8/qMF2RqBHC2Wlhc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199021)(40470700004)(46966006)(36840700001)(36860700001)(54906003)(2616005)(47076005)(478600001)(26005)(1076003)(6666004)(81166007)(82740400003)(356005)(41300700001)(316002)(4326008)(6916009)(186003)(336012)(83380400001)(426003)(70206006)(70586007)(2906002)(5660300002)(44832011)(36756003)(82310400005)(40460700003)(86362001)(40480700001)(8676002)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:16:55.7882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a55ab8b-09ca-432d-daf6-08db3ac15098 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5601 Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove static function type. 3. Add handling of memory allocation. This will be useful in dynamic node programming when we unflatten the dt during runtime memory allocation can fail. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 10 ++++++---- xen/include/xen/device_tree.h | 5 +++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index aed38ff63c..bf847b2584 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const void *fdt, } /** - * __unflatten_device_tree - create tree of device_nodes from flat blob + * unflatten_device_tree - create tree of device_nodes from flat blob * * unflattens a device-tree, creating the * tree of struct device_node. It also fills the "name" and "type" @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static void __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; @@ -2079,6 +2078,9 @@ static void __unflatten_device_tree(const void *fdt, /* Allocate memory for the expanded device tree */ mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct dt_device_node)); + if ( !mem ) + panic("Cannot allocate memory for unflatten device tree\n"); + ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); dt_dprintk(" unflattening %lx...\n", mem); @@ -2179,7 +2181,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) void __init dt_unflatten_host_device_tree(void) { - __unflatten_device_tree(device_tree_flattened, &dt_host); + unflatten_device_tree(device_tree_flattened, &dt_host); dt_alias_scan(); } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 19a74909ce..58ac12abe3 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -178,6 +178,11 @@ int device_tree_for_each_node(const void *fdt, int node, */ void dt_unflatten_host_device_tree(void); +/** + * unflatten any device tree. + */ +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes); + /** * IRQ translation callback * TODO: For the moment we assume that we only have ONE -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519768.806730 (Exim 4.92) (envelope-from ) id 1pmJUG-0004ji-Ui; Tue, 11 Apr 2023 19:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519768.806730; Tue, 11 Apr 2023 19:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUG-0004jb-QV; Tue, 11 Apr 2023 19:17:04 +0000 Received: by outflank-mailman (input) for mailman id 519768; Tue, 11 Apr 2023 19:17:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUF-0004Ta-KC for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:03 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20601.outbound.protection.outlook.com [2a01:111:f400:fe5a::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f89fd80-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:02 +0200 (CEST) Received: from BN9PR03CA0077.namprd03.prod.outlook.com (2603:10b6:408:fc::22) by DM6PR12MB4282.namprd12.prod.outlook.com (2603:10b6:5:223::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:16:59 +0000 Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::5b) by BN9PR03CA0077.outlook.office365.com (2603:10b6:408:fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:16:58 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:16:58 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:57 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:57 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:56 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f89fd80-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dqfHvUQkKRI+G1Rz6oofnKIRzyCknyLcK0EUyws71WyuEo6e0kx4wVRS09qucjTXA9EqkU8e+z63bCu/YkL+kfC8GOSrj7rwUj/hevwvj9CRfVNBXfSRMd26MnOj3P8VppZyJsbOp7oN9ULsAUdBY38gE9097qaUlMR1paZy56dBemNS5UHDTkVZOl1r3tGL1yoFI1mzVv0ozo9bM9zVFJZ/DRtGpVz1Qx60rijmc4vA9vapQqD+RSk23+p1T2rJWJbUrSzG8xgrWNwYoabwKn3Zx7YQvsbVjj6T73nkM0AEDfvtaOEkS0oh/1/GuMZ4JZyfsyyma955nur+H1rWYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+aOH8wbfxJ3CDB9n8z4otIPVVDXaY3ZnHxlpPeTlbO8=; b=XVfer5z5EHUilHhV+QpewCTkSOCiPTyjg/flVMZDEAzRK7xS4U90MmLS2j6XCxJadMrTyfIFtqZgoV8tE5knDGCt9Oy0pJnHl/YgFH12ggxAV7MMV8Fr+WG99/NQCfuORKTWXweHXckRRu6Ghyd9EzVd+cdZhZgDEOTfJrOaND763U12ywlONjxb2o0xNbsw08P4nJPuYUvA34TqM5tdqXE4UKXbylbIoJu4mMYx3dg+VOB48TH9m8UNMBnMYOUnFMnaNJhPMSzo+GyHnp1zexnQxanpVOmx8/4ez4aN6AvQjfluvkCvSi4wU3+b/2iwK54aukTqwBjwLwEyLBAb8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aOH8wbfxJ3CDB9n8z4otIPVVDXaY3ZnHxlpPeTlbO8=; b=rl/f+0LCUCpB609QADltQg+rTxdAOrQiu8YujzkFf1OQB3AAg5ivux1ExrlGxmgNX4gA13RYWWZLejjd2CoSI8Y6BCICQIu+vn/vyCh/BDlKvHSYiFlDmHWaQLT2ceA64UDpUA/XJ+8ZOo+WqDeTLlbQI3mUA4YsgiIRfgsyJ2A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 04/17] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. Date: Tue, 11 Apr 2023 12:16:05 -0700 Message-ID: <20230411191636.26926-5-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT066:EE_|DM6PR12MB4282:EE_ X-MS-Office365-Filtering-Correlation-Id: a9c843cc-4c85-4c96-a8c6-08db3ac15246 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E5mZY9arVfIz4R/AVfjqkQGX6I4NgpAdkIvjkuVZqz5BKhyPZEDL6b5Xq8b3aZ8yk9JU+rCdeveWZbPStUFbHz4rOiSVlz3wiAZwUYR0jRVcmHdSCANP2OdgfJgacMgBX58liZjifMHUHzC/32dEBes0dT/X0sVh0V0ClZ/pmvVNF2vnoktMpqFl7WQQ6/bzuXUT8t6RLcCdF1n/3N0pUtC3AMR9H2HHoI73W91MU1zSRQ9p3o//hEvudGpbf1Q/O9EyfgJP5cn6D5Wa+pOcUC+a0wuMf94oRCG6cfHd5p9GA/HhF+Rw7SezASSeL6IA6UysRg+9vzAPtm0ZN/6sMk48bGE1upLmFIspEKzE5Xx6I6Oa3iUBQemvUG0GRGf4bdhWntvbrDNu30WquTcxt+EoHMzvNBdW59Z2Q54ECfZK69MyfO0N3SILS823JJrSKR2I444zyf/CPE3tEfFHX91CO9QOXC+5ALFlZGMr2X28jaiAhNzEM19Os8Ea7kh5ySxKv0vuydLq5lJtnjoAQwr5BCuUnxCWZO7KKKfDzxM4jLQXG2exYJ7Yc61JwrHEHD0D39MpQ1pWsM0R7MGeR2RyYy8cukIRVhn2m5REcOmNb6w6YBFsOkQbj9rXjK4kFARvTQo2T2N1Y9AaR02BFnvB9oY1v1UmFgnOGiR1+Qql+LFy4XNhSrlWdx9PgLB67O/ky0Ps9USxEUlIXO9dY9kMQK7XS1nWTKovgA0R31I= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(36756003)(54906003)(86362001)(41300700001)(83380400001)(316002)(70586007)(4326008)(478600001)(70206006)(6916009)(8676002)(82310400005)(5660300002)(40480700001)(8936002)(2906002)(4744005)(44832011)(36860700001)(356005)(186003)(82740400003)(81166007)(6666004)(26005)(1076003)(426003)(336012)(2616005)(47076005)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:16:58.6206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a9c843cc-4c85-4c96-a8c6-08db3ac15246 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4282 This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal Acked-by: Julien Grall --- xen/common/libfdt/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile index 75aaefa2e3..d50487aa6e 100644 --- a/xen/common/libfdt/Makefile +++ b/xen/common/libfdt/Makefile @@ -1,7 +1,11 @@ include $(src)/Makefile.libfdt SECTIONS := text data $(SPECIAL_DATA_SECTIONS) + +# For CONFIG_OVERLAY_DTB, libfdt functionalities will be needed during runtime. +ifneq ($(CONFIG_OVERLAY_DTB),y) OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) +endif obj-y += libfdt.o nocov-y += libfdt.o -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519766.806710 (Exim 4.92) (envelope-from ) id 1pmJU8-0004De-5r; Tue, 11 Apr 2023 19:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519766.806710; Tue, 11 Apr 2023 19:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJU8-0004DX-2g; Tue, 11 Apr 2023 19:16:56 +0000 Received: by outflank-mailman (input) for mailman id 519766; Tue, 11 Apr 2023 19:16:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJU6-0004DR-Ab for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:16:54 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20610.outbound.protection.outlook.com [2a01:111:f400:7e89::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67dbd682-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:16:50 +0200 (CEST) Received: from BN9PR03CA0143.namprd03.prod.outlook.com (2603:10b6:408:fe::28) by MW6PR12MB8997.namprd12.prod.outlook.com (2603:10b6:303:23e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:16:43 +0000 Received: from BN8NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::5d) by BN9PR03CA0143.outlook.office365.com (2603:10b6:408:fe::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:16:43 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT090.mail.protection.outlook.com (10.13.177.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:16:42 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:42 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:42 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67dbd682-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ew2aiM153IebdZ51yzNra06Kl9mM25TsDnKfivWygS65BEpXhoawrogqnDdjjIC9vbLaC/wbSt6K7ZMAQ96foHVPQIFMx1z8S8lv/9WNwqxQ/4NqjIgwV+NuwO81GAoRfBFSBSXqUKuOnACRF5ZxiLXm1Ax84gYgRskhpyb3UHE7liJZb+6A6Ij6q0J5WdH7fhx7m6W53pLO8LgDhoY6H01mOpGKtOt8lM1dECSk1P2pddFgjIdc5FTPdCpzuIjErtqaIMFeLQoNvjCabf6aDmWDIW/bPHAG/enaYGCNuMcQsmSUXsRygM5pkOgW657f09s45IDovMPjHcTgP9t7hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hw2g30xtcvBa51vtOCCSs3IGMhpfBDNnN9dvV4fBjSk=; b=RukjOJoqD2n/mHx/m2eV6KVZLukNhlyEkcMgEVEopf/ZBxe0TDwNLA4JpHHwtOle952Btdj+s+d0miNJ2Ilyj2MhN5KkpZWJUP7eXkLepG18xDdf7EJCF16LTgGXFtZH3Uq1u/SUGh/mJrDBrpiSFLU485DCfNpJtMZd6Ulob4GGDfCCqGO4LJnFQ54SR4fsOcHfoRfyswEbAvr6KXF6HJHz8M5Tj5rzPvYe2ho7AB+rMP3hbjM0G1EvvA0w3R88VbaTHu8YT2stmysKTQpP93nDn0JWNTvS09tUSFahLAD64cO30lPXeylHQ+1qWH7cHMjD3wWGQPp58TQdiavBnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hw2g30xtcvBa51vtOCCSs3IGMhpfBDNnN9dvV4fBjSk=; b=5IJhn74+mcYpGGrffiF8APF/b19yvnApDraSDN9to2eQsvF6VxKlzj9FmOSoRnYmsFUIeOgEs6TmVA+fgSlo5IRYW2VsxOHgP3+5ud/SCSaPfDyAyX+AjSc4jWac2ftO92LRzyvCjuXR1nC5+xDZjz7A+L2BNy9zd1JV3mW5Lbc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , "Jan Beulich" , Wei Liu , Rahul Singh , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v5 00/17] dynamic node programming using overlay dtbo Date: Tue, 11 Apr 2023 12:16:01 -0700 Message-ID: <20230411191636.26926-1-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT090:EE_|MW6PR12MB8997:EE_ X-MS-Office365-Filtering-Correlation-Id: 2584fd03-1918-43d8-5ac6-08db3ac148f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: adKKCHa+6ja/Kc6S4MUnTSDiZZSB5vtvNKcKRS9+jOyBL/QW+npLt193WrP38VLHD+S8nfiznhm7bJl3XTBBbTBSrJ9eVf8fLkMSx1fETIZUabDFVB71fVmpdhJeSvmOFf+G7fNPalwQGS/h1ofAN0zchKJWMPVA+DntuF5PMDdOmEgFLaIHZRDodNG/Qh0hYKVO+gvyt1sk2a68HkmP7tTLCc0QIui1iRHFmMhMR9VdTUT7W+UI16ojJEnlPeyxwMoRCdhfKzIiENIsFm7UzgWX9Bnlyw8JgzccBUnKltmS/buWoBlYsLeq4iyDvCmUQMD5VH7qKZQmUq7fjDxU8F2XQgYjkh1ICLcCFviVsQU2iY9Zbwsdypwy3bKNYgKGg7E09emLI56ct5FK0MIUaW7uLveBB6tJ1K6OMs8KblAd25oB5AJTwBqkVcwQQBUfNbmaPFtJ+d6dxh6NtHsEANI5HdXwGIWX+yArXWLkGOzSEfqFLTuH65kjur5yTBOYpsRNIFSDutx9kdkicRKk7nNIQs9bzWTI6wjBOvo2smU4SzVaVR/FYHvSD2ZU4Eu1mNJc9hYNpKo9Qx9E/oo3hWfQscYMoTEM0MvUypzkWXRcrqaeJ2fxZC55/pIS8z3+uzpwmJlfG/V8GUPDvm05f1Ld5iMTfMsgtARx0Ztxm9UH5thxslbp3QMB1PetkRNh8OSNC3mQGX/PbZjPmKjgkeHU8OnVsautIQqTz230kFE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(46966006)(40470700004)(36840700001)(478600001)(83380400001)(86362001)(40460700003)(40480700001)(36756003)(82740400003)(81166007)(356005)(47076005)(36860700001)(336012)(2616005)(426003)(2906002)(1076003)(26005)(316002)(54906003)(186003)(44832011)(5660300002)(82310400005)(8676002)(6666004)(6916009)(7416002)(8936002)(41300700001)(4326008)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:16:42.9545 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2584fd03-1918-43d8-5ac6-08db3ac148f7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8997 Hi, The main purpose of this series to address first part of the dynamic programming i.e. making Xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/set IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt will be unflattened to a new dt_host_new 3. Extract the newly added node information from dt_host_new 4. Add the added node under correct parent in original dt_host. For removing a node: 1. Find the node with given path. 2. Check if the node is used by any of domus. Removes the node only when it's not used by any domain. 3. Removes IRQ permissions and MMIO access. 5. Find the node in dt_host and delete the device node entry from dt_host. 6. Free the overlay_tracker entry which means free dt_host_new also(created in adding node step). To map IOREQ and IOMMU during runtime, there will be another small series after this one where we will do the actual IOMMU and IRQ mapping to a running domain and will call unmap_mmio_regions() to remove the mapping. Change Log: v4 -> v5: Split patch 01/16 to two patches. One with function type changes and another with changes inside unflatten_device_tree(). Change dt_overlay xl command to dt-overlay. Protect overlay functionality with CONFIG(arm). Fix rwlock issues. Move include "device_tree.h" to c file where arch_cpu_init() is called and forward declare dt_device_node. This was done to avoid circular deps b/w device_tree.h and rwlock.h Address Michal's comment on coding style. v3 -> v4: Add support for adding node's children. Add rwlock to dt_host functions. Corrected fdt size issue when applying overlay into it. Add memory allocation fail handling for unflatten_device_tree(). Changed xl overlay to xl dt_overlay. Correct commit messages. Addressed code issue from v3 review. v2 -> v3: Moved overlay functionalities to dt_overlay.c file. Renamed XEN_SYSCTL_overlay to XEN_SYSCTL_dt_overlay. Add dt_* prefix to overlay_add/remove_nodes. Added dtdevs_lock to protect iommu_add_dt_device(). For iommu, moved spin_lock to caller. Address code issue from v2 review. v1 -> v2: Add support for multiple node addition/removal using dtbo. Replaced fpga-add and fpga-remove with one hypercall overlay_op. Moved common domain_build.c function to device.c Add OVERLAY_DTB configuration. Renamed overlay_get_target() to fdt_overlay_get_target(). Split remove_device patch into two patches. Moved overlay_add/remove code to sysctl and changed it from domctl to sysctl. Added all overlay code under CONFIG_OVERLAY_DTB Renamed all tool domains fpga function to overlay Addressed code issues from v1 review. Regards, Vikram Vikram Garhwal (17): xen/arm/device: Remove __init from function type common/device_tree: change __unflatten_device_tree() xen/arm: Add CONFIG_OVERLAY_DTB libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. libfdt: overlay: change overlay_get_target() xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree xen/smmu: Add remove_device callback for smmu_iommu ops xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller xen/iommu: protect iommu_add_dt_device() with dtdevs_lock xen/iommu: Introduce iommu_remove_dt_device() asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h common/device_tree: Add rwlock for dt_host xen/arm: Implement device tree node removal functionalities xen/arm: Implement device tree node addition functionalities tools/libs/ctrl: Implement new xc interfaces for dt overlay tools/libs/light: Implement new libxl functions for device tree overlay ops tools/xl: Add new xl command overlay for device tree overlay support SUPPORT.md | 6 + tools/include/libxl.h | 11 + tools/include/xenctrl.h | 5 + tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 48 ++ tools/libs/light/Makefile | 3 + tools/libs/light/libxl_dt_overlay.c | 71 ++ tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 + tools/xl/xl_vmcontrol.c | 52 ++ xen/arch/arm/Kconfig | 5 + xen/arch/arm/device.c | 145 ++++ xen/arch/arm/domain_build.c | 142 ---- xen/arch/arm/include/asm/domain_build.h | 2 - xen/arch/arm/include/asm/setup.h | 6 + xen/arch/arm/include/asm/smp.h | 3 +- xen/arch/arm/smpboot.c | 1 + xen/arch/arm/sysctl.c | 16 +- xen/common/Makefile | 1 + xen/common/device_tree.c | 30 +- xen/common/dt_overlay.c | 897 ++++++++++++++++++++++++ xen/common/libfdt/Makefile | 4 + xen/common/libfdt/fdt_overlay.c | 29 +- xen/common/libfdt/version.lds | 1 + xen/drivers/passthrough/arm/smmu.c | 56 ++ xen/drivers/passthrough/device_tree.c | 109 ++- xen/include/public/sysctl.h | 24 + xen/include/xen/device_tree.h | 28 +- xen/include/xen/dt_overlay.h | 59 ++ xen/include/xen/iommu.h | 2 + xen/include/xen/libfdt/libfdt.h | 18 + 31 files changed, 1595 insertions(+), 187 deletions(-) create mode 100644 tools/libs/ctrl/xc_dt_overlay.c create mode 100644 tools/libs/light/libxl_dt_overlay.c create mode 100644 xen/common/dt_overlay.c create mode 100644 xen/include/xen/dt_overlay.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519770.806750 (Exim 4.92) (envelope-from ) id 1pmJUK-0005JE-Lj; Tue, 11 Apr 2023 19:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519770.806750; Tue, 11 Apr 2023 19:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUK-0005J7-I8; Tue, 11 Apr 2023 19:17:08 +0000 Received: by outflank-mailman (input) for mailman id 519770; Tue, 11 Apr 2023 19:17:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUH-0004Ta-Dk for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:05 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061e.outbound.protection.outlook.com [2a01:111:f400:7e8a::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7003e71b-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:03 +0200 (CEST) Received: from MW3PR05CA0004.namprd05.prod.outlook.com (2603:10b6:303:2b::9) by MW6PR12MB8734.namprd12.prod.outlook.com (2603:10b6:303:249::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Tue, 11 Apr 2023 19:17:00 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::33) by MW3PR05CA0004.outlook.office365.com (2603:10b6:303:2b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:16:59 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:16:59 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:54 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:54 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:53 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7003e71b-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZoaxB4bFLbZgS5WHHZcc7Q2JNIUjaW6J+JCxA2fmYTW3nBQ2j9coBWisKiCfCXFOcjrFMTstSF0xWUGWtuCyep3JhovZ1XV5inwtQLmZy8uO+FYvx5mDwiBdcL6PLqd7EtB0GLquF5Pl5Hc3LXu3CAC5oEyM2rZxbBCL/58jxvE9aoxo740ZUVX9Rc6bvUJF38XrQzk2NUYrPSrAhccYEYaOVr9n8MtwIG5hYV9tJIj4yvzsJtJrwbmEeS+fC6IHFmMm/bvOdHFwjnL2/nqmODQhBwPEuwI8zon1FpL9EZrM/5fHWNQdLAd2OCFdQc3h07QoCzui9AlPZ6uYGsIPRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2clB4UixcJGvwOZJ+XN0wD+kcnhi2QU+8ofkZ5Co48=; b=RoZApb5D1WrOD7o9t5X9invczFFpM8bXTIFK1x6yv+3TUxNKFSmB3f68ySJc6moMrpmguITRrb8G1Z9Eg3iya5EzPRP+eX5XFexXisbGVyF8um0COhhoJ5Q60FEdFev7CbsZfo3Nt8rZxN01+IMhyockuz+HdWmLRaKZdG4XyuUd3nXoC0wL1cp5ZFD9k6A+Pj9kMr4J53LXAoFI4P4+WvAlcgIhu8ZwmNwQ1Jx2+AwSIRnLemwiCNYf5EGvOu9TFG08pVt9Vk2KQWMx6GV0rO1D1qq7YnJGeh4MRQV91Cifi3JAZig53CQDi60kteeemQDfNSWCOjT/oK5dr/GgKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z2clB4UixcJGvwOZJ+XN0wD+kcnhi2QU+8ofkZ5Co48=; b=uG3yZ2q5CylqwilEN0w1lucY3u1hCuIw3gAflcKN2wFvTGJlsbJOVoocZsN62RVXs8md4ynK/i2EJD4Kd9n+L3YDixHpgt81Xdc+yDJdzoZagvx0OA/iP3eR6k6AmI+5qyCX8MgdbB80bE5ShP9n6Sk9LC4s8FzM/+ovwThwI8I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 01/17] xen/arm/device: Remove __init from function type Date: Tue, 11 Apr 2023 12:16:02 -0700 Message-ID: <20230411191636.26926-2-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|MW6PR12MB8734:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ccc9639-ecdb-4de5-16fc-08db3ac152be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1nZdWlJL/siybVTnbTI1lAmr6TWeqSDLIc0m/tAf95v6A7UuW3OoeXSDRffUjaQ+5Y85O6S+9kI0qym75WjJBPFA7AizyTun88WjRujaWDHA08ihv7jXoXXTPfhDLoBmI1EgY09qrTQh7zlyBDJsJ2mnCieg7+TsGy668oLevSG4Hy2X76p+WPkuFVS0dJKrgQI3EGrduQCHwm160dyE/AUQmh60Ov4ohYORM3d6at/H+cokq0m+Lut5JFcFaeCMFqhv76PNthhld8VWHra1d3Wm9/WPWNdhH9HJklCuH7vg/nN6dzeua6f8bxzkardLfOQkV4xdccn9O7fop9mjDuIcnpKxZHls2hluVbFRGyv0c6xkcdni+fp5RlOq+mZzOS1YS5CfHNdfJHm63D1qY+qNCPo9OC3w+NI3qV+0ZRTPmF06wtM0tgBwmb3RN1D+jSL9QTlkGKZdgnSzntFKK0thEzDeObN3TdVFALa/KUNOdgEI2Ztmvhm1BGjBE93tWwGQk2Dy9C65WddhIJiWDP3SDLeQqrdt16CQQsvfp1flbBKBDKvx27Cs79UCsdWff/SMB7cUTwE6HvubGxEoi07+jeM8O+omQnrsvEzn6RuYUXjJOOIR4XvRy4wWhVMGGEM1r4O+H3y1MkVStWMMpexk67WObCUn+G3Zv84x+DcDNYbYuISH1tZWs8pZ1cPhATNDJY4+mD6sj31xuWqyuPbN6UsLH5H0ZsDIQh294sE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199021)(40470700004)(36840700001)(46966006)(30864003)(8936002)(8676002)(41300700001)(47076005)(81166007)(2616005)(2906002)(5660300002)(44832011)(356005)(4326008)(83380400001)(70586007)(6916009)(336012)(36860700001)(40460700003)(426003)(70206006)(6666004)(478600001)(316002)(36756003)(86362001)(40480700001)(82310400005)(1076003)(54906003)(186003)(82740400003)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:16:59.2939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ccc9639-ecdb-4de5-16fc-08db3ac152be X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8734 Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupt() 3. map_range_to_domain() 4. unflatten_dt_node() 5. unflatten_device_tree() Move map_irq_to_domain() prototype from domain_build.h to setup.h. To avoid the breaking the build, following changes are also done: 1. Move map_irq_to_domain(), handle_device_interrupt() and map_range_to_domain() to device.c. After removing __init type, these functions are not specific to domain building, so moving them out of domain_build.c to device.c. 2. Remove static type from handle_device_interrupt(). Overall, these changes are done to support the dynamic programming of a nodes where an overlay node will be added to fdt and unflattened node will be added to dt_host. Furthermore, IRQ and mmio mapping will be done for the added node. Signed-off-by: Vikram Garhwal --- xen/arch/arm/device.c | 145 ++++++++++++++++++++++++ xen/arch/arm/domain_build.c | 142 ----------------------- xen/arch/arm/include/asm/domain_build.h | 2 - xen/arch/arm/include/asm/setup.h | 6 + xen/common/device_tree.c | 16 +-- 5 files changed, 159 insertions(+), 152 deletions(-) diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c index ca8539dee5..fec6e29c42 100644 --- a/xen/arch/arm/device.c +++ b/xen/arch/arm/device.c @@ -12,6 +12,9 @@ #include #include #include +#include +#include +#include extern const struct device_desc _sdevice[], _edevice[]; extern const struct acpi_device_desc _asdevice[], _aedevice[]; @@ -75,6 +78,148 @@ enum device_class device_get_class(const struct dt_device_node *dev) return DEVICE_UNKNOWN; } +int map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname) +{ + int res; + + res = irq_permit_access(d, irq); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", + d->domain_id, irq); + return res; + } + + if ( need_mapping ) + { + /* + * Checking the return of vgic_reserve_virq is not + * necessary. It should not fail except when we try to map + * the IRQ twice. This can legitimately happen if the IRQ is shared + */ + vgic_reserve_virq(d, irq); + + res = route_irq_to_guest(d, irq, irq, devname); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", + irq, d->domain_id); + return res; + } + } + + dt_dprintk(" - IRQ: %u\n", irq); + return 0; +} + +int map_range_to_domain(const struct dt_device_node *dev, + u64 addr, u64 len, void *data) +{ + struct map_range_data *mr_data = data; + struct domain *d = mr_data->d; + int res; + + /* + * reserved-memory regions are RAM carved out for a special purpose. + * They are not MMIO and therefore a domain should not be able to + * manage them via the IOMEM interface. + */ + if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", + strlen("/reserved-memory/")) != 0 ) + { + res = iomem_permit_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); + return res; + } + } + + if ( !mr_data->skip_mapping ) + { + res = map_regions_p2mt(d, + gaddr_to_gfn(addr), + PFN_UP(len), + maddr_to_mfn(addr), + mr_data->p2mt); + + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map 0x%"PRIx64 + " - 0x%"PRIx64" in domain %d\n", + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, + d->domain_id); + return res; + } + } + + dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", + addr, addr + len, mr_data->p2mt); + + return 0; +} + +/* + * handle_device_interrupts retrieves the interrupts configuration from + * a device tree node and maps those interrupts to the target domain. + * + * Returns: + * < 0 error + * 0 success + */ +int handle_device_interrupts(struct domain *d, + struct dt_device_node *dev, + bool need_mapping) +{ + unsigned int i, nirq; + int res; + struct dt_raw_irq rirq; + + nirq = dt_number_of_irq(dev); + + /* Give permission and map IRQs */ + for ( i = 0; i < nirq; i++ ) + { + res = dt_device_get_raw_irq(dev, i, &rirq); + if ( res ) + { + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + /* + * Don't map IRQ that have no physical meaning + * ie: IRQ whose controller is not the GIC + */ + if ( rirq.controller != dt_interrupt_controller ) + { + dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", + i, dt_node_full_name(rirq.controller)); + continue; + } + + res = platform_get_irq(dev, i); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to get irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); + if ( res ) + return res; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4f9d4f9d88..6ab18c53ab 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2256,41 +2256,6 @@ int __init make_chosen_node(const struct kernel_info *kinfo) return res; } -int __init map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname) -{ - int res; - - res = irq_permit_access(d, irq); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", - d->domain_id, irq); - return res; - } - - if ( need_mapping ) - { - /* - * Checking the return of vgic_reserve_virq is not - * necessary. It should not fail except when we try to map - * the IRQ twice. This can legitimately happen if the IRQ is shared - */ - vgic_reserve_virq(d, irq); - - res = route_irq_to_guest(d, irq, irq, devname); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", - irq, d->domain_id); - return res; - } - } - - dt_dprintk(" - IRQ: %u\n", irq); - return 0; -} - static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, const struct dt_irq *dt_irq, void *data) @@ -2322,57 +2287,6 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, return 0; } -int __init map_range_to_domain(const struct dt_device_node *dev, - u64 addr, u64 len, void *data) -{ - struct map_range_data *mr_data = data; - struct domain *d = mr_data->d; - int res; - - /* - * reserved-memory regions are RAM carved out for a special purpose. - * They are not MMIO and therefore a domain should not be able to - * manage them via the IOMEM interface. - */ - if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", - strlen("/reserved-memory/")) != 0 ) - { - res = iomem_permit_access(d, paddr_to_pfn(addr), - paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIx64" - 0x%"PRIx64"\n", - d->domain_id, - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); - return res; - } - } - - if ( !mr_data->skip_mapping ) - { - res = map_regions_p2mt(d, - gaddr_to_gfn(addr), - PFN_UP(len), - maddr_to_mfn(addr), - mr_data->p2mt); - - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map 0x%"PRIx64 - " - 0x%"PRIx64" in domain %d\n", - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, - d->domain_id); - return res; - } - } - - dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", - addr, addr + len, mr_data->p2mt); - - return 0; -} - /* * For a node which describes a discoverable bus (such as a PCI bus) * then we may need to perform additional mappings in order to make @@ -2400,62 +2314,6 @@ static int __init map_device_children(const struct dt_device_node *dev, return 0; } -/* - * handle_device_interrupts retrieves the interrupts configuration from - * a device tree node and maps those interrupts to the target domain. - * - * Returns: - * < 0 error - * 0 success - */ -static int __init handle_device_interrupts(struct domain *d, - struct dt_device_node *dev, - bool need_mapping) -{ - unsigned int i, nirq; - int res; - struct dt_raw_irq rirq; - - nirq = dt_number_of_irq(dev); - - /* Give permission and map IRQs */ - for ( i = 0; i < nirq; i++ ) - { - res = dt_device_get_raw_irq(dev, i, &rirq); - if ( res ) - { - printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - /* - * Don't map IRQ that have no physical meaning - * ie: IRQ whose controller is not the GIC - */ - if ( rirq.controller != dt_interrupt_controller ) - { - dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", - i, dt_node_full_name(rirq.controller)); - continue; - } - - res = platform_get_irq(dev, i); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to get irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); - if ( res ) - return res; - } - - return 0; -} - /* * For a given device node: * - Give permission to the guest to manage IRQ and MMIO range diff --git a/xen/arch/arm/include/asm/domain_build.h b/xen/arch/arm/include/asm/domain_build.h index 34ceddc995..b9329c9ee0 100644 --- a/xen/arch/arm/include/asm/domain_build.h +++ b/xen/arch/arm/include/asm/domain_build.h @@ -4,8 +4,6 @@ #include #include -int map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname); int make_chosen_node(const struct kernel_info *kinfo); void evtchn_allocate(struct domain *d); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..1d636e8a4a 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -163,9 +163,15 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells, u32 device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt); +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, + bool need_mapping); + int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len, void *data); +int map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname); + extern const char __ro_after_init_start[], __ro_after_init_end[]; struct init_info diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7b..aed38ff63c 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -1811,12 +1811,12 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, * @allnextpp: pointer to ->allnext from last allocated device_node * @fpsize: Size of the node path up at the current depth. */ -static unsigned long __init unflatten_dt_node(const void *fdt, - unsigned long mem, - unsigned long *p, - struct dt_device_node *dad, - struct dt_device_node ***allnextpp, - unsigned long fpsize) +static unsigned long unflatten_dt_node(const void *fdt, + unsigned long mem, + unsigned long *p, + struct dt_device_node *dad, + struct dt_device_node ***allnextpp, + unsigned long fpsize) { struct dt_device_node *np; struct dt_property *pp, **prev_pp = NULL; @@ -2056,8 +2056,8 @@ static unsigned long __init unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static void __init __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +static void __unflatten_device_tree(const void *fdt, + struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519771.806754 (Exim 4.92) (envelope-from ) id 1pmJUL-0005OG-0z; Tue, 11 Apr 2023 19:17:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519771.806754; Tue, 11 Apr 2023 19:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUK-0005MU-SE; Tue, 11 Apr 2023 19:17:08 +0000 Received: by outflank-mailman (input) for mailman id 519771; Tue, 11 Apr 2023 19:17:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUI-0004DR-7o for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:06 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2062b.outbound.protection.outlook.com [2a01:111:f400:fe59::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70c37f42-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:04 +0200 (CEST) Received: from MW3PR05CA0004.namprd05.prod.outlook.com (2603:10b6:303:2b::9) by SJ2PR12MB7962.namprd12.prod.outlook.com (2603:10b6:a03:4c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:01 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::87) by MW3PR05CA0004.outlook.office365.com (2603:10b6:303:2b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:01 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:01 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:56 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:56 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:55 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70c37f42-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxpCf3u8aQhuKKrQ0T4SThXXP1/7rOEjefrnQSrBSTFBH+2vet0/BkN9/96BSOh7BRc29yBAuGPfWBrzsmO+z5fnIfCwZv+/W19BY/NV8YANilCikYT1V6SYpNidRCML6foQhvXzNpSPdoWeuYsSgXeXBoRcw30A9hLweGC05laY3bfZd0nKDfZygI2pHhb+DVTBGxMKHmbwxn5ZVbZ7WJk6S5aqZRc1vjlpRsq2ZVXjC8+8eeuht7v/iiIdbRQyVVxOlmpJIwUjwPmg0cum0s/L0CtRf+4gtmJkTKc71Q13em4p8IVwFzZY2HoSwbOnofwG8X+xRU252Zq5wh0tew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5jE5w9tUBXYNb4GkaW66AGdvE8156w4aHYPgYkE7PU=; b=J8chaI68GCgVd6yiVlsCc2D6W9f8W6rt3VGRxdijG5QkKl4XmOHnBv8yIOYI/Rgw6Klo5ZQhcfIdeK4P15dtOyfRXRvLNo/MftvzVHrbSeH/vaYcM9RFyEJ7NUhxXpfNqKRi+aR0qwKnJVPtlrB7QQh00GsQM9m0Rodu36ZTFZeAjjD47Mx2VrRjvv9dtW52pf3kcqkolch+iGosTYvrcT784CYrbxufSy0xOdAiTpXV1A0iS3ImLKKJp6281qCGzbhF9c9Xln6UIHd4NKB3CWweckTiIqaye45CAj0ZJkXf6BnGjxwtBMmifjilgQ5RjO+UazrA0bzcIwYk090FzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5jE5w9tUBXYNb4GkaW66AGdvE8156w4aHYPgYkE7PU=; b=wxWB/BWXY2CO32y5vRS7236kub8VwKV+uQFpF+1OL7L0gNQP0NFpjSVE+5iJrM4LMKSlT0XcPeLcswieKsQ8nTGed5rjuOLbVuJXYhTiPU4/xfe0O9OCoYPR1oCufxMZ35hDCStB3gc6PZlfTqyQ9vA0Q0yoWaW96zC54AlnEGs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 03/17] xen/arm: Add CONFIG_OVERLAY_DTB Date: Tue, 11 Apr 2023 12:16:04 -0700 Message-ID: <20230411191636.26926-4-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|SJ2PR12MB7962:EE_ X-MS-Office365-Filtering-Correlation-Id: 93a1cd42-a56c-4eb5-c800-08db3ac153f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XWH3oXWHqcZD9sTbyewkrsWBFCMU89fDJmR4pzMiPZW5pze/IlzoIeNqgMO+onWgXaj7kkAxDBoDLNVOcSQsC8idNUm+ugK7ePoigLJoBTkuI4LPtr6TpF1Hu96MhwTrlzVFaMa8sY/LwPPV4Jv9pxEySrnK4eUpkPnpbZIFmvfQwFd2u2XDDj5UI2KTlnkYAVF8I4WaxTvn1RsWJ01pNp1scH91N4EH6kjSdx9cp9nn4MhQKQyquijx0FvB96sd8lhRvXqKnGN4ej9l87xkd6gaBZFF2QDaWi/bx8h82ONNlZbn/6Bdf9FCl4EgW9/S3afztXOAIZr0zPtDkxpYUmdBxecv9dJ0AWU5e18XbD9auKVMJm/1NlaTK8CnG5SPzNnfl840lBkZdlL1otUt/ycx6XbjnQ8Pg18BFGRMa54ksmJgSg7RBkpYZ0ebggriUDOCaJTYHTG1iDX7k35EY/ACLzaqqPtlL8QkBkYeLj32xs5mlb5IuZUXzwgAMxGmvvp6TOPOE+EMrXpxYCmby1nAHtZ6i/vJHIVuc8xH9wvDpCtCcA1gw/nFOXZ0eiJaWGH/JmKExlvCImja4S1yoLikS/kf61uDhiWCluec1ISqzh7nToVQZBqAlEykzumK+3IM04rzaalN6zkN/upDRJ+JUwM+HvF/xC7nLvPig/jILnqLMs5OG7+4ucnYho7ogyInqZSxFbkoEr5V6l8vHITm7LFWVa+3ZtQdrpW0ie8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199021)(36840700001)(40470700004)(46966006)(36860700001)(70206006)(70586007)(8676002)(4326008)(6916009)(5660300002)(86362001)(186003)(426003)(336012)(40480700001)(41300700001)(6666004)(82310400005)(316002)(8936002)(478600001)(54906003)(2906002)(36756003)(40460700003)(26005)(44832011)(82740400003)(1076003)(2616005)(47076005)(356005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:01.3563 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93a1cd42-a56c-4eb5-c800-08db3ac153f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7962 Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Signed-off-by: Vikram Garhwal --- SUPPORT.md | 6 ++++++ xen/arch/arm/Kconfig | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index aa1940e55f..0a31f40af4 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -822,6 +822,12 @@ No support for QEMU backends in a 16K or 64K domain. Status: Supported +### Device Tree Overlays + +Add/Remove device tree nodes using a device tree overlay binary(.dtbo). + + Status: Supported for ARM + ### ARM: Guest ACPI support Status: Supported diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..1fe3d698a5 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -53,6 +53,11 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config OVERLAY_DTB + bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED + help + Dynamic addition/removal of Xen device tree nodes using a dtbo. + config HVM def_bool y -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519772.806761 (Exim 4.92) (envelope-from ) id 1pmJUL-0005Uc-Hg; Tue, 11 Apr 2023 19:17:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519772.806761; Tue, 11 Apr 2023 19:17:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUL-0005Si-A6; Tue, 11 Apr 2023 19:17:09 +0000 Received: by outflank-mailman (input) for mailman id 519772; Tue, 11 Apr 2023 19:17:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUJ-0004Ta-L8 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:07 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20613.outbound.protection.outlook.com [2a01:111:f400:7eab::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7205330f-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:06 +0200 (CEST) Received: from MW3PR05CA0006.namprd05.prod.outlook.com (2603:10b6:303:2b::11) by DM4PR12MB5357.namprd12.prod.outlook.com (2603:10b6:5:39b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:03 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::94) by MW3PR05CA0006.outlook.office365.com (2603:10b6:303:2b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:02 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:58 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:58 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:58 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7205330f-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSIe8IWtkogZDuJROEuyEa4L5qtz0r0ub7oLaSfO1oYNN6uZkXy/AYkEa3PeoOYonr9wYRQt+vHxHp+g/sYWlxHPL5FypP2L333pRjkvdOHBFru51nKqqPmtHjUq8o8GrG5y8yDBLzH8tnluod1ewfCDKM4wcoGOPGGStdCZjVWAwUNmZr5A9t2PuUIYrZjRaoSZUWNZTqyMP+OYSaGEH1hCgOgsJ3vJs2EyLcRAlUvGXsMRB0pozooPmglFCVbN34KWvZrvQUmwLSVu0nZ1ELhtlGW0nNHvKq6OCci9womzrMTovnYOKR2qZWd8RrqKtlTmvon+x8XhFJpGe+Fl9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IPRvr0PydrbevxDRuC5bBe8hAAj8BLWppbzz+G6AD20=; b=Q6QuNO/MJsxQ0Mfgmqv9Fc2TTQvDV0zliZG80oSqKGwzzpfT9J7UZ2FuPaiYfXU/qiOYHT7fHQP1t/QBxkf012+VIOerMfB3Dt6nDxwpI6myg11MXW+FBGeex1p/gIZzfUq33QTMvrNskEHqisXKNHnCX7jcmrseAw5RwEvaEafIOJ2EThr5w/RXlVXFLxiGBqOtb8NJBRHVXwuxBkFFg/2byl1vVO1ABs4TYzz0/3GqkGZZEFmVOoH2X8bA4bhzAOBAwZicx47pyOkjCng0OPhHTyoKK5D2zLgqyQj2e2lwqaorRkw+Gg9QI3UT3rfGtJroT25tHoWNkBIhp7696Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IPRvr0PydrbevxDRuC5bBe8hAAj8BLWppbzz+G6AD20=; b=KDu9AlO4fQb4RnMxIBoAkLNp+pI1dLaayOR4hzEGfRdnkwnBMysAjR/rLTC3LnlSxfeTfOoBcgV7J2cmTTfYIMihNqqMdDt0ekAxFiY2Rvo00w9cwKWP85ONIYg9S2Q4lQM+yFt67X9yvcEUyhncpYclWgTkKAv6Gp/j6YjnUoc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 06/17] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Date: Tue, 11 Apr 2023 12:16:07 -0700 Message-ID: <20230411191636.26926-7-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|DM4PR12MB5357:EE_ X-MS-Office365-Filtering-Correlation-Id: 92748e6e-4e36-4f2d-f5b0-08db3ac154cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: POXz1WG1hmvtmv5RRF+iVjz+L8Z++hE0T36YgoND+tvNfXU/Rd6SPUicT57Mcps7aDrp6/TmvJJRrlH6FadTG1hn4VFTdykLIM4JnRdvcd1mf/i1lRmcPBSrHMP+Im8G8qLaN7BXyrxnrrH/yOOwAzOpRDrG8IOa12/TZkyjJadsajlTtO4WDHpR8O+nVF+NkYSTWfDzv7AqcPsvh9r3KCDIzHfBFurWQ6Kz3waGiXRtZtGZ8BDRDJ+Ehde4oNdx/Jhh5iuIEPauPu6juAmCzj6Jw07AJ4Bo6qvTPRfHt7AM6yIxi7U6+vVNDzyVZGYtuxhRP/MyQKl5wdkGY3Y/U/dGmoxFNMyNVRvKaL69tpU+m9J7iGTxkbbs+O/EIboBocgQrs2YE6q3MMpNR0pAw3av7s45/S2QnBRJgvfcYOxuvoT31hUUewjypoQ2OI+Ce+RbA6xziFmiOaE0XOWv5buUBnwRohqZZkALRJRtuUKYsDDDKs539xqAA86hV2ihzXiQzSAkL7GWAaMm5RBxEH96prsa3Ha9XE4D67wF6GK6vkDkzuLGzurXbz4rw7Q2wMTZdaihTT04kxLSPbswtunugHmQQB/eKBcU1LZr2dwByFx+JEfIIXiRF3SOmnEwaDeqK6nwrGqe0tmJoYnQ+rsI+rCoLcosJVnzaOchF7EnmLYwRMMP9ENiQhoAfopd2dzm2C63Ud1EGkJKAnjkzZXwSKT5coSqN2lJ962XuiXWU7p/NRVEOg94z+CrKbPrKEUI1p+5Ot9Zk6tZkaCHLg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(4326008)(478600001)(6916009)(54906003)(8676002)(70206006)(41300700001)(70586007)(316002)(86362001)(36756003)(83380400001)(426003)(2616005)(336012)(26005)(1076003)(6666004)(2906002)(8936002)(44832011)(40480700001)(5660300002)(82310400005)(36860700001)(82740400003)(356005)(186003)(81166007)(47076005)(37363002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:02.7468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92748e6e-4e36-4f2d-f5b0-08db3ac154cc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5357 Add device_tree_find_node_by_path() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflattened to a dt_host_new. Next, we need to find the overlay nodes in dt_host_new, find the overlay node's parent in dt_host and add the nodes as child under their parent in the dt_host. Thus we need this function to search for node in different unflattened device trees. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 5 +++-- xen/include/xen/device_tree.h | 17 +++++++++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index bf847b2584..507b4ac5b6 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -358,11 +358,12 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, return np; } -struct dt_device_node *dt_find_node_by_path(const char *path) +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, + const char *path) { struct dt_device_node *np; - dt_for_each_device_node(dt_host, np) + dt_for_each_device_node(dt, np) if ( np->full_name && (dt_node_cmp(np->full_name, path) == 0) ) break; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 58ac12abe3..998f972ebc 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -534,13 +534,26 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, struct dt_device_node *dt_find_node_by_alias(const char *alias); /** - * dt_find_node_by_path - Find a node matching a full DT path + * device_tree_find_node_by_path - Generic function to find a node matching the + * full DT path for any given unflatten device tree + * @dt_node: The device tree to search * @path: The full path to match * * Returns a node pointer. */ -struct dt_device_node *dt_find_node_by_path(const char *path); +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, + const char *path); +/** + * dt_find_node_by_path - Find a node matching a full DT path in dt_host + * @path: The full path to match + * + * Returns a node pointer. + */ +static inline struct dt_device_node *dt_find_node_by_path(const char *path) +{ + return device_tree_find_node_by_path(dt_host, path); +} /** * dt_find_node_by_gpath - Same as dt_find_node_by_path but retrieve the -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519773.806769 (Exim 4.92) (envelope-from ) id 1pmJUM-0005hl-A9; Tue, 11 Apr 2023 19:17:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519773.806769; Tue, 11 Apr 2023 19:17:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUM-0005gq-4P; Tue, 11 Apr 2023 19:17:10 +0000 Received: by outflank-mailman (input) for mailman id 519773; Tue, 11 Apr 2023 19:17:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUK-0004Ta-Pp for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:08 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20611.outbound.protection.outlook.com [2a01:111:f400:fe59::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 739189b0-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:08 +0200 (CEST) Received: from MW3PR05CA0017.namprd05.prod.outlook.com (2603:10b6:303:2b::22) by BN9PR12MB5257.namprd12.prod.outlook.com (2603:10b6:408:11e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:17:05 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::4a) by MW3PR05CA0017.outlook.office365.com (2603:10b6:303:2b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 19:17:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:04 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:04 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:03 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:03 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 739189b0-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RnOWGfhR+alOXtb1kEbH7mY9GHTUEb4Fh/Fq5W+ejuEBGScgkN+8M1kOzS1mFU4cA3rfTYuCUVidDnhaZwcIb3yH4MUbng3sDhlaGnQNs2bLeLWU+QLALHyOh6CCJhJQ35Fv0tfwvwbfL/RVHk4qdplIJ6NK9iWXfIv59MjOsILUtV/+MaRpY9HuwnDQh1R2S+1WxwGgc2i6+DPVMRL9v6qFUU46v4NtKiUIhGPHgtmRxH0AoZsyJEY9Kjj3m1REYDdpCUA4+p4qwj21PDv3c+9WAoLdNmEiTWZ1c2zIcG7SesZD2zVy+jc545NHBmf4mtQzOAGaAOrGiljWyw30fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zOQW4Omju1dTUno8ADGoDg+I28lOLIV01naa3ZWrW1o=; b=AfQz2DOlaIMvQKAfoj502N6k0Jzk3taYs6o6qwigXCHpwW9phuQL1ITtRk4IU4J3E9NW7amG3/ALbGXLT5qtSR/E78kmN0/SGnoIuH3ZklgOvT69Vgiste+lkcBBzOTpqZnmNqJHaI8nvqy9GkgQxNOezhqE18ZkBNOVddwf1TgIaJuwB4/MVqX7ZryKA4OXdowle9i35wq0g55QFrE2CaAXwmnFk7yQ5C72gzfecJg05Z8FViqa9a0TieJdOuPJzwaF3XJoql9riQPR7cpExcFwxk7tSvAArFJhJxJ0qDJhDi7kFBDo9XCjVSBw5u7OLEOkT5yS6dCv/wG+WRmLgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOQW4Omju1dTUno8ADGoDg+I28lOLIV01naa3ZWrW1o=; b=yxZPsIxPbBZxAQRHbKz6JQv92aqGSLAVhz9iyCR72zNrtSEZDD/8sdBXFUVIUlg8q8cq3Nz60IlR1Gp2e7TcV6+htFinDnkGslGbL1h/edwWvv6KV5dmwrIBDYGlYaMPQ0QtCijJ0IRHkCLQQn4cHAy94E8McblhaOHAsSIB5ng= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Date: Tue, 11 Apr 2023 12:16:13 -0700 Message-ID: <20230411191636.26926-13-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|BN9PR12MB5257:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c5bf8b1-3ea5-4fb3-321a-08db3ac1561d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QhfFyki35SJbRekBupI7TtH1V3WKYpDwoOfoHKrgY+p0KezPSeQt3siAWShc/QMBXA+1E2Alz5IVPwpto5fOu0pPF3dg1ZSOaysK/53rpx8PXrCDgOKlLGXLzMl8nR5wlJhLoHzmvG5bzi9shRnWClX6oAJRfKsSZqE0A27pLeOMJFcig7YwOd73TTCH37VmFh46V9uY66e3pWOZlm2pVv9ABTpMJaVcnRqtq4BgYqR9JGyCzuZB7H+vxmxoUyKdi97Z+bfAdJJsOVB7yamKBwyS9FLGOG0h8OnvnH8/3VudTqh0TaoRqhhZ/tSALeKw7cxetA1NkG8gKfCuzfpd1NtSfEbHB452W64YVPYrmtr7OrMaw4uga/aqEPeRRmt+eJ6TC1BXum2xBhu0eofYNTIYXg6SROb8t0CxYbPKCVGfqeu9h/XgTaLv5SGd9MTUR/3R8aENWmMrHhHESYCIj9aTFP0KjIV9WgU6hcZ2Ovhx3N6sVjA4W7XY3cwbsif9JTp08qjzIFanvRRZ011vcEKrCxhDKupQ9WbDjejzxoo35ggY0btzTNQDAYe83SgaIc0SH516ef74Kb1MN+zPK+Ozu3pZtoeYCOOPjp4tS+ZqjZjKTs/Pi3VJ7go13Q4q04+vWqTU1Jzarorqoku8E5LYWnFcWulNlnjo1UB6k8qMLAZqBSt3LAjT4QccAqgXz8W3GGqRfz8aLuVruJQvuzgBavv9/PZa4GCONwDeNHg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199021)(40470700004)(36840700001)(46966006)(478600001)(40480700001)(47076005)(36756003)(83380400001)(86362001)(40460700003)(81166007)(356005)(82740400003)(426003)(2616005)(2906002)(316002)(1076003)(336012)(36860700001)(54906003)(44832011)(26005)(186003)(8676002)(8936002)(6666004)(6916009)(82310400005)(41300700001)(5660300002)(70586007)(4326008)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:04.9504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5bf8b1-3ea5-4fb3-321a-08db3ac1561d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5257 Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 3 +++ xen/drivers/passthrough/device_tree.c | 39 +++++++++++++++++++++++++++ xen/include/xen/device_tree.h | 6 +++++ 3 files changed, 48 insertions(+) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 507b4ac5b6..b330e6a013 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2098,6 +2098,9 @@ void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) *allnextp = NULL; dt_dprintk(" <- unflatten_device_tree()\n"); + + /* Init r/w lock for host device tree. */ + rwlock_init(&dt_host->lock); } static void dt_alias_add(struct dt_alias_prop *ap, diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index a77a217f3d..74f994b9da 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -112,6 +112,8 @@ int iommu_release_dt_devices(struct domain *d) if ( !is_iommu_enabled(d) ) return 0; + read_lock(&dt_host->lock); + list_for_each_entry_safe(dev, _dev, &hd->dt_devices, domain_list) { rc = iommu_deassign_dt_device(d, dev); @@ -119,10 +121,14 @@ int iommu_release_dt_devices(struct domain *d) { dprintk(XENLOG_ERR, "Failed to deassign %s in domain %u\n", dt_node_full_name(dev), d->domain_id); + + read_unlock(&dt_host->lock); return rc; } } + read_unlock(&dt_host->lock); + return 0; } @@ -259,11 +265,15 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, spin_lock(&dtdevs_lock); + read_lock(&dt_host->lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) { + read_unlock(&dt_host->lock); + spin_unlock(&dtdevs_lock); break; @@ -272,6 +282,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, ret = xsm_assign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); if ( ret ) { + read_unlock(&dt_host->lock); + spin_unlock(&dtdevs_lock); break; @@ -287,6 +299,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, ret = -EINVAL; } + read_unlock(&dt_host->lock); + spin_unlock(&dtdevs_lock); break; @@ -295,22 +309,31 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, spin_unlock(&dtdevs_lock); if ( d == dom_io ) + { + read_unlock(&dt_host->lock); return -EINVAL; + } ret = iommu_add_dt_device(dev); if ( ret < 0 ) { printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n", dt_node_full_name(dev)); + + read_unlock(&dt_host->lock); break; } ret = iommu_assign_dt_device(d, dev); if ( ret ) + { printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\"" " to dom%u failed (%d)\n", dt_node_full_name(dev), d->domain_id, ret); + } + + read_unlock(&dt_host->lock); break; case XEN_DOMCTL_deassign_device: @@ -322,25 +345,41 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, if ( domctl->u.assign_device.flags ) break; + read_lock(&dt_host->lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) + { + read_unlock(&dt_host->lock); break; + } ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); + if ( ret ) + { + read_unlock(&dt_host->lock); break; + } if ( d == dom_io ) + { + read_unlock(&dt_host->lock); return -EINVAL; + } ret = iommu_deassign_dt_device(d, dev); if ( ret ) + { printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\"" " to dom%u failed (%d)\n", dt_node_full_name(dev), d->domain_id, ret); + } + + read_unlock(&dt_host->lock); break; default: diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 998f972ebc..b7272bbccc 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -18,6 +18,7 @@ #include #include #include +#include #define DEVICE_TREE_MAX_DEPTH 16 @@ -106,6 +107,11 @@ struct dt_device_node { struct list_head domain_list; struct device dev; + + /* + * Lock that protects r/w updates to unflattened device tree i.e. dt_host. + */ + rwlock_t lock; }; #define dt_to_dev(dt_node) (&(dt_node)->dev) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519774.806777 (Exim 4.92) (envelope-from ) id 1pmJUN-0005rE-2i; Tue, 11 Apr 2023 19:17:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519774.806777; Tue, 11 Apr 2023 19:17:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUM-0005nZ-Kb; Tue, 11 Apr 2023 19:17:10 +0000 Received: by outflank-mailman (input) for mailman id 519774; Tue, 11 Apr 2023 19:17:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUL-0004DR-4f for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:09 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20600.outbound.protection.outlook.com [2a01:111:f400:7e89::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 727aca3a-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:07 +0200 (CEST) Received: from MW3PR05CA0015.namprd05.prod.outlook.com (2603:10b6:303:2b::20) by SA3PR12MB7975.namprd12.prod.outlook.com (2603:10b6:806:320::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:17:03 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::98) by MW3PR05CA0015.outlook.office365.com (2603:10b6:303:2b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 19:17:03 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:03 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:16:59 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:16:59 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:16:59 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 727aca3a-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DDZel6WEBGb2aTYAnYAotrmzVbZ3s3kcfUhLpszVA23+8sB6m7eS38UT9bYqoRo6RP23ED4kQur/HOYEtasxuVNCH2OINnUCwHgjJBrrPz/EQEzneYHUaMhiwE6tSOH7ZTDIbyopUVlTXoj1irUeAIHzr0qJa79iKrprkvfH0bGG478A723b3fPn0GdS2JgFHW8dj8i9FwM19w51JAtejG+N24Sw9LsGNC5yJy9IV8OiftA4AyouNKMQhf9HDP23SNhsv7wJqyAC+07IxAtkNBrK0996Ut17FGuOYWMYtSLrVwrJbwiG7C3759csDuFlp7vdsfzDkoqFHwGNTVXo8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SvjprfsFjT2q+G0BBsMISOBPht18qx5Ov6rcUISgUjE=; b=dw5LUMyKeF5kkahMH7yGjNK1hZL2dfKx4esYNnvJI8FmdkkhcX8LaD/tLlW+JYtNFKxonu4qD8NlSbJO9k7b6LEo5QMSpEznWwTFYdC8p/kK9JkcBBv0FPlcWd7M6PN6EdR1nuGk6dCABARmo33RFDXAM4OYiTXk16JNTyg6My8aoS8Im3Yae7e+z3VwdLecvoxpgiMWhUtLotEM8m3Nz7NxyCcrc031cS8qmdxC2SNOr6fGWaEv/VleGwn6A8tOwATNZKIvLo++UhVR8W5Az4qEAa+jS8kt6vu1yl8bi0nblYOPf1hMg3ZR2UXNdVip2ZhsluYEnJZb05efiLzOoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SvjprfsFjT2q+G0BBsMISOBPht18qx5Ov6rcUISgUjE=; b=37Bcs5BNxuIQA4OVW40raq+uSYlN3KhcoUpYSnVGbWlCEJDzDZYDouCqG/QsSbIcef6GSJ6TPWTkiNkRQPAYIrAAWmRrEtsOY9jdJolx4wj10djxsKpGqzim6xKu8aUSgLSfZDP8Av4z2wQDegFm51ZAjcZrZE1XNNQewGfi+1k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Rahul Singh , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 07/17] xen/smmu: Add remove_device callback for smmu_iommu ops Date: Tue, 11 Apr 2023 12:16:08 -0700 Message-ID: <20230411191636.26926-8-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|SA3PR12MB7975:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f9a7f2f-a193-4b53-18b5-08db3ac15512 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DR+ixQxTfr4F1T81YK50UlMuZ859lngTVfX60KdhxnLbhinqY03bYxNAzFU/gcCZ5s6LA5Js9UQZcEl8RamVvLuIvh1Fuy6KKfhr4tsA2xxQrmnR08hnkxfJeGCQaSmDAXvL3eHxqgo1TiQqGaAV1Sf5feOZjPeIM9s0AHubsl1BRLMcTCi538v0w3WLCKKKH21Y9zPDunYZVpx/bkVQpu1bGxi01n8wb+H0DH84qci3sRFtGa7o/ertOi3A2igLGal3mDlIQGedktPkaa1iNb5KYb1iJYEH2FS7UkPknbiL2NV7vp6RMK4PA4czQjI3EgMKg+wM/nW42TYgAs7vbPx+ksJRTeFi2pxLPB7G74Y2ww+IfL8ViFTev06tC9+FGtaP8B+U/BujH+Lm8s6qUEJw6BFL/g6C3onBWcrDDLoObosYP1b7FqPX4DAxQA8jvl6pr94dAw3HavaHiH0nyxwAqpzt+mTUcyd7WUiu/roG43XjG0fPZilSbqr0EWEHdSvhx6L0+Sb+XDj1m6/5KzFkhYF5L/+q1dWSihWClC+4bTJaWvm1S48337U87hTkHZAn5ub1bE7WfIwFS+upjkIZkXWVPEryBw3ftrJKGuP93tx0y7xIebcj1aAyv87qSH5xcEcnMhr/r8Bz9ZTst5YYo21V6teKVAT1TEXOyPgmSE8SV3p1G79jpyQ+GLNHHubHTSA48X6q1d6MJ96hXiLDCfQWy3iPMYV9fhgAoLA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(70586007)(70206006)(4326008)(478600001)(6916009)(8676002)(41300700001)(316002)(36756003)(54906003)(86362001)(47076005)(426003)(336012)(2616005)(26005)(1076003)(6666004)(8936002)(44832011)(5660300002)(40480700001)(82310400005)(81166007)(2906002)(82740400003)(186003)(36860700001)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:03.1999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9a7f2f-a193-4b53-18b5-08db3ac15512 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7975 Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Remove the SMMU master Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/arm/smmu.c | 56 ++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3..14e15f1bc6 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -816,6 +816,19 @@ static int insert_smmu_master(struct arm_smmu_device *smmu, return 0; } +static int remove_smmu_master(struct arm_smmu_device *smmu, + struct arm_smmu_master *master) +{ + if (!smmu->masters.rb_node) { + ASSERT_UNREACHABLE(); + return -ENOENT; + } + + rb_erase(&master->node, &smmu->masters); + + return 0; +} + static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, struct device *dev, struct iommu_fwspec *fwspec) @@ -853,6 +866,32 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, return insert_smmu_master(smmu, master); } +static int arm_smmu_dt_remove_device_legacy(struct arm_smmu_device *smmu, + struct device *dev) +{ + struct arm_smmu_master *master; + struct device_node *dev_node = dev_get_dev_node(dev); + int ret; + + master = find_smmu_master(smmu, dev_node); + if (master == NULL) { + dev_err(dev, + "No registrations found for master device %s\n", + dev_node->name); + return -EINVAL; + } + + ret = remove_smmu_master(smmu, master); + + if (ret) + return ret; + + dev_node->is_protected = false; + + kfree(master); + return 0; +} + static int register_smmu_master(struct arm_smmu_device *smmu, struct device *dev, struct of_phandle_args *masterspec) @@ -876,6 +915,22 @@ static int register_smmu_master(struct arm_smmu_device *smmu, fwspec); } +static int arm_smmu_dt_remove_device_generic(u8 devfn, struct device *dev) +{ + struct arm_smmu_device *smmu; + struct iommu_fwspec *fwspec; + + fwspec = dev_iommu_fwspec_get(dev); + if (fwspec == NULL) + return -ENXIO; + + smmu = find_smmu(fwspec->iommu_dev); + if (smmu == NULL) + return -ENXIO; + + return arm_smmu_dt_remove_device_legacy(smmu, dev); +} + static int arm_smmu_dt_add_device_generic(u8 devfn, struct device *dev) { struct arm_smmu_device *smmu; @@ -2858,6 +2913,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = { .init = arm_smmu_iommu_domain_init, .hwdom_init = arch_iommu_hwdom_init, .add_device = arm_smmu_dt_add_device_generic, + .remove_device = arm_smmu_dt_remove_device_generic, .teardown = arm_smmu_iommu_domain_teardown, .iotlb_flush = arm_smmu_iotlb_flush, .assign_device = arm_smmu_assign_dev, -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519775.806786 (Exim 4.92) (envelope-from ) id 1pmJUN-0005z6-O5; Tue, 11 Apr 2023 19:17:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519775.806786; Tue, 11 Apr 2023 19:17:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUN-0005x3-4z; Tue, 11 Apr 2023 19:17:11 +0000 Received: by outflank-mailman (input) for mailman id 519775; Tue, 11 Apr 2023 19:17:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUL-0004DR-DB for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:09 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20606.outbound.protection.outlook.com [2a01:111:f400:7e8d::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72be6fba-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:07 +0200 (CEST) Received: from MW3PR05CA0009.namprd05.prod.outlook.com (2603:10b6:303:2b::14) by DS7PR12MB6360.namprd12.prod.outlook.com (2603:10b6:8:93::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:04 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::93) by MW3PR05CA0009.outlook.office365.com (2603:10b6:303:2b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 19:17:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:04 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:01 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:01 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:00 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72be6fba-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDNOOUoUQrDMzJfKXlJfbBxfcLNE2ExFDTv865MP0/28SIEbvp9JnZjJDr5LiG2XgsPaddpgjmGypo4MdsgnlyvwAvcH5/tAVyON4tcV29yB5Ax5/rzMW6ngkXaB1UBKGYvq2j+aZVZmhrNwjVcuwB0KKYXqfz/ptE6F65s+mJEjq8G2VLHNZg4X4aI+pQhT+GVYB2esbpZP5Le+4vQaIRdvSESALv92/hOY2ohpeVzIb8GKRKbpFZlCAH/NKZEy8kHh6QD5+Iy7xS7PSL5SGScUzX7Q3pYlRuIDFqeQ8QY0Umpam1vCOps3ut4ieAid0xpteHShUAq767fEik0JzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qd0QFdZvzHUGWrw0BfIrEu3cWkp8jWSV4vPT9FURuHE=; b=BLJ69mgmDOC4R6oelAOdYmiz7bsaXr3tCsp/n9jVQSfNwQkvbwB8mNzPAXedghQGVKl73r9eHZiXnJDEgi6/5PIi785YsAGhLn/NjQVkncwcrUtvIO3Ub6EdFenIHqnvqeDVN+21UtIh+Agwu3sYvQtHLFYcsiEX8fDmQ8SxvaMsHl2nIL8WKgr0dF1fefO9Zd3hLLl1qRtq0ONlThpsSekvWPCjEdCdGe18ABWfwzYnKYzMpFoX/bFTV5a9F1lWAvL7nMGpRo/DHrjB9bZ+Wq0GxePVPj7o0sU+FM9Jnt0wqPJ5dJ0WJKD0FQVylkqF6rg4pG5aaacy8nY5HFtxPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qd0QFdZvzHUGWrw0BfIrEu3cWkp8jWSV4vPT9FURuHE=; b=ydjZWvY1P/SI3BwD6fN+ts4m/35w6s58norWJb8ajYjmOcxbz3+nrGWMPxgzBAof3asGEfFsqYqJX+24SJKCU0VWnbnkWYCLCKikt1G3NmUzCNGNO6RCVa+N34wH/DUa74ovVoxQDb1Q4ujmxsdoFPr8gxaJg5RL2qb538w68hc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 09/17] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Date: Tue, 11 Apr 2023 12:16:10 -0700 Message-ID: <20230411191636.26926-10-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|DS7PR12MB6360:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ab94d90-81ed-4d5a-7551-08db3ac1559c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qApyCw/eRhNKr9aze4U/rylhAkLcEqFW2qkkpLpyGUEdW2AgCK6S44/p2a67w1EuRCOHOm8BHUSpGgB9zXZ/Ac8aWvzxeFHcn+Gh5fQCW7wznN0MXMeYGWOr8xRnW2zrjSd8TadH8++Qaqe9vvGXNJaAcKZ5LNgkE/09f4wCEemxWSE/QVJ9HtFE9r9ehK/pb1HXoFwvHKYWhHgipn/QH/68Cj9kOEaQ9eIcIKU2DzYu/x3NWq8hbgQBJxAVoz1FRURZUtTkhzGZVW/DyKVMYu5NjzEBKekSLWPWvrIpLPAU45Acb1aQ/Q15gRkhEnUnPbe4UTxH3INxGJui8bfLeQ65cibYQCatpgNnCYr/08gyMg7prvQrE+8+41WLV4dXlHGSswThx20toJwjzJu0RaGii9JoQossCFqzOwXj3cNVH44tvvejdre2iIAhssiBRrApAzRdaNkLbd0kytp4OYeit8PRWwCskR4Xr7+qfYx1nPDzot+qTkZ31qz4oF5QYy1/VGAolU1Dh9dQSS7K3kF7fUiF+XrYB6Jjem6uybz2J0GNJQ28hMf6vMjeNx7Qj2S20XUxo7Fv+ofCyrSIBSz2JnN1IJvo7PBotlBZk8siV0EgvqNdK1qqC1eJIo3w4GJJ0m7IGxURagIbwE93lQ0DRC/u33VvRuxQlF48aqlSw0gUYORcOya+QbJs79vSJMyWczmowmgjZfg+dN6orTbpzeYxYKZjKFfO4LE+BQM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199021)(40470700004)(46966006)(36840700001)(1076003)(356005)(82740400003)(8936002)(8676002)(4326008)(86362001)(6666004)(5660300002)(6916009)(41300700001)(44832011)(40460700003)(82310400005)(36756003)(316002)(2906002)(478600001)(54906003)(70586007)(70206006)(40480700001)(47076005)(83380400001)(26005)(81166007)(186003)(36860700001)(2616005)(336012)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:04.1067 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab94d90-81ed-4d5a-7551-08db3ac1559c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6360 Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access add. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/device_tree.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index bb4cf7784d..457df333a0 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -146,6 +146,8 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( dev_iommu_fwspec_get(dev) ) return 0; + spin_lock(&dtdevs_lock); + /* * According to the Documentation/devicetree/bindings/iommu/iommu.txt * from Linux. @@ -158,7 +160,10 @@ int iommu_add_dt_device(struct dt_device_node *np) * these callback implemented. */ if ( !ops->add_device || !ops->dt_xlate ) - return -EINVAL; + { + rc = -EINVAL; + goto fail; + } if ( !dt_device_is_available(iommu_spec.np) ) break; @@ -189,6 +194,8 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( rc < 0 ) iommu_fwspec_free(dev); +fail: + spin_unlock(&dtdevs_lock); return rc; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519776.806793 (Exim 4.92) (envelope-from ) id 1pmJUO-0006Fq-JH; Tue, 11 Apr 2023 19:17:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519776.806793; Tue, 11 Apr 2023 19:17:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUO-0006DA-3H; Tue, 11 Apr 2023 19:17:12 +0000 Received: by outflank-mailman (input) for mailman id 519776; Tue, 11 Apr 2023 19:17:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUL-0004Ta-UB for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:09 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20611.outbound.protection.outlook.com [2a01:111:f400:fe59::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73e6f7e9-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:09 +0200 (CEST) Received: from BN9PR03CA0142.namprd03.prod.outlook.com (2603:10b6:408:fe::27) by SA0PR12MB4461.namprd12.prod.outlook.com (2603:10b6:806:9c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:06 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::68) by BN9PR03CA0142.outlook.office365.com (2603:10b6:408:fe::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:06 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.22 via Frontend Transport; Tue, 11 Apr 2023 19:17:05 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:03 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:02 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:02 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73e6f7e9-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EE2Ctn9GNlCFsItgMw8F9HmYXg17oJOdiP9I9XI4gGGOLXsCtSbDBSqC61H+Dq+MLsM7lxptVaIo+tOpPZPzzMDUlCj/wE4F6cekg2BKBn6/Lo9J9ZDhfqwtpK/9IY1089A9Q867ER7/LITYmQibC71RbKQVmwQGce9+X5tjUYl3mShbhsOu8sRmoCVk/82SwIkHBA0S/pxssD5JCg+BWCV4HX/8NOUZm+GqDJPV/BsZhURrKd9nJXFRya41E9vv9DuOzNDjwYbJ5xo+9I8FY/BzeL3GPEYu4G6QlZSHWIXlZp5tfgNRPLpwRbKvetPtBqkQF/6ytR5INCV8dx6KlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1PNAnqijXbZmLbaJTz/bnk2u6mRzrBSQaqCUQeSU5s=; b=jaL9+qOMzRad5tarJg4rEj4AKXrLNbMCDZlevdOeN1RNicT0Vj4aGC2TpobcwtvzX7YLo5mFaIpM/8ulm1opSE0QM2dTfcTf+xjX0o/MfWBBCLKrIfMG4b3D39A3YuA0fhCjqtpKPBGsMN/cjpUibFTkyhbO+SToa+IxsW4Vu2rS7dD6RbdMLXSMN3IF1G05npHhRVG9BabpwY7H+D6HQI0DUuznXWTDFXOS2Tx//5JnZtFgOpDe9Ck2R9xUkNMQmOz+Y2p0ORVooRxFOIzonSG/hvi6aJR7+oABL/WNh62YxFEGv7Frl7HiY+NUrkun81OMteRtRID/tKwmaCyugw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x1PNAnqijXbZmLbaJTz/bnk2u6mRzrBSQaqCUQeSU5s=; b=utGqqoXglk4yU5u11TW967K8k1NpxM1j7Bmkllm4Bn7wCTX1ogO1oSrTPEHf13ml2qCcv7EmB00zIOviy+PnFtwWVV26CjjThzvZrLhKh2848DLvyL841LgU937KVR6dXT4JeV+TpyfgP5FucG/R6tH+0XCreVFnWdWGjbUzCDM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Date: Tue, 11 Apr 2023 12:16:12 -0700 Message-ID: <20230411191636.26926-12-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|SA0PR12MB4461:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c464d7b-9522-41af-e4d2-08db3ac156aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T1rYiXDUh4QnttGRazlOfWqjXoFP74k7bGx8YZ1wWb56PmvEsA86NABuo8umFlX5ixEi3YYq+E2xjZP6eBbWnvYB8jxJWUKeG79Av4TW3jJB0aDKOibhxbA8op9ZEslTO2VsDBJsW4puJuLQF7PNsVPhHaCsz5gSEg86dt60nC2ol7cScOcmegiDeOXY+tXSJiIhUvybYfmsyq869lb3lyUcRji4lT2SPZkgGwlhtMALVu5CEvyb4OD12v3OB56KM6iv8RWFhILrbyKWRqnCZ8PzKzi/TvS9SiFw0ahr+L4ptt3IZFsM19tr9C3tZrfGcKox5W6ERt+1bkk5UtbxL53hbKEx4hQyEZ/9oV76ao9yEIiAK6As55jinHTIfSUmYt/NK1WegBul9N/cwFSkVrvI6svGFAWb6w9labchneUXBergLWfB3IMNsYi0urR6/e0DNYLNxyZrf0Oukje6aAbxrhkjmnEDG+zm2iyCshjIIYqYIoQI9aZ/nxZMUfWlQiKtFnaRJj0554loeuyY/TkoOT4sXNZeygfCwwjgY9UgFvt8oxTkAmwMW/Lizz5BqYQSUsCa4r6xDDcLKsHV/YDmBTYJ89hw78Le2RG7Ls5rR68UcuQHYCXuNRbn9NHVB0APiSi70L1uADioPmuqiUCXQ/o8LtHvjZWYSeM5OZ8GxB3fuIZB6BJujSECBgvXC/F8hNVXBAFgT6WhzWUjtt7RdHucICoh2uh3QgMCCbk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(4326008)(6916009)(8676002)(54906003)(70586007)(70206006)(478600001)(41300700001)(316002)(36756003)(86362001)(336012)(47076005)(2616005)(426003)(6666004)(1076003)(26005)(83380400001)(44832011)(5660300002)(2906002)(36860700001)(8936002)(82310400005)(40480700001)(356005)(186003)(82740400003)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:05.9727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c464d7b-9522-41af-e4d2-08db3ac156aa X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4461 Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host. But adding rwlock in device_tree.h causes following circular dependency: device_tree.h->rwlock.h->smp.h->asm/smp.h->device_tree.h To fix this, removed the "#include and forward declared "struct dt_device_node". Signed-off-by: Vikram Garhwal --- xen/arch/arm/include/asm/smp.h | 3 ++- xen/arch/arm/smpboot.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h index 8133d5c295..afe6129276 100644 --- a/xen/arch/arm/include/asm/smp.h +++ b/xen/arch/arm/include/asm/smp.h @@ -3,13 +3,14 @@ #ifndef __ASSEMBLY__ #include -#include #include #endif DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); +struct dt_device_node; + #define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) #define smp_processor_id() get_processor_id() diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 412ae22869..336a7d418b 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519777.806801 (Exim 4.92) (envelope-from ) id 1pmJUP-0006Pl-CE; Tue, 11 Apr 2023 19:17:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519777.806801; Tue, 11 Apr 2023 19:17:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUO-0006LA-OY; Tue, 11 Apr 2023 19:17:12 +0000 Received: by outflank-mailman (input) for mailman id 519777; Tue, 11 Apr 2023 19:17:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUM-0004DR-4r for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:10 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20600.outbound.protection.outlook.com [2a01:111:f400:fe59::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7309f7e2-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:08 +0200 (CEST) Received: from BN9PR03CA0125.namprd03.prod.outlook.com (2603:10b6:408:fe::10) by BN9PR12MB5084.namprd12.prod.outlook.com (2603:10b6:408:135::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:05 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::84) by BN9PR03CA0125.outlook.office365.com (2603:10b6:408:fe::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:05 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.22 via Frontend Transport; Tue, 11 Apr 2023 19:17:04 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:00 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:00 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:00 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7309f7e2-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f5hwxHDiJ6cPXtGVi0oDhgGm3os2tvfuJk/rvPeOs5IMC2wLTyxhSHPzGdvuuRI/bYz0Ev6Rre1K2rIqyc6Ri59vS16WiVSCQ1l2QfFetjgsYV5Yff3j66E4dGWelns5JVGmuHmyH1IJ/kbG8OD8pCblaMZ0E+AZIamdZgxFL6/rMSeIGdzBgffGT18CcjFfcjPhq0SrSrarKjXWWlLoGAmgksCM4eUYqtYTTyJn79+PXiCL8X26kfGxK59CnhJuMs3jKTv4FM3xgKbn0JR2wtFqYfeAhFWUzF9AQNhkj4t7gwiq4fg9M5y2vc9uwGkqFYIy5rGppra40oH/rnLn+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hbn+9h9tF7QZlww7kr6YoDzwWCRUPyZKofdb3QDs5Ls=; b=QNK9jA3ONnSE1MrYZppf2BKDWAJikpDz/GOU3l1M5GQWpOa3zeWUIQHywMUMYHK0RC5LhxeEzDXtfOIAQM0QmgHUemK4J03w6+oy55pd+1fcryOg5UQwJPlFbpsShvUrxOvN3WuucMqSP7vpnPTswMhoDr+e5riI0lrri1kXnMMExr7tbXY2OIjsGQRMoYLXtR0TaNRsThkS/pCIwVm+3tEDFUWCdgtZB+TMJ0Br/XCmGe3kqYmcHtx8/disPE18Rg/weHlFOUxiy8yaxbv3rxBSTJ1V5a/C6+kS0j+q55PYoyljRW2We6QxUC4N36NIpQdhyaeMVVjcoS/mlftlmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hbn+9h9tF7QZlww7kr6YoDzwWCRUPyZKofdb3QDs5Ls=; b=auVQJ0UMG/mylausafR6rHAq+f0clyeouWECzrLAe+0FRFpwvUeGm/ek4sst6QIP7jQR4I5kTJUXKwX0yStFdEbrBAO1c2cp3KYtzvbqVOIAn8vSEU5dQerSPjGyH1T2jf7RtpXR85IyJQbGr+k7taprljIZT/DgVkW0Mua+GrE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 08/17] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Date: Tue, 11 Apr 2023 12:16:09 -0700 Message-ID: <20230411191636.26926-9-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|BN9PR12MB5084:EE_ X-MS-Office365-Filtering-Correlation-Id: 7bc72af7-9755-4072-ca37-08db3ac155e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aesU9CuNguun7Fu2Zu/Im/OValFm4zDIlA3vKluqIupLhBGOIhKJzL3kOBw9pc+M1uTqxvlV8M2MTLGidHSoQ9QYcZBNx5MMH4dzfVw9fHu7qhFgBOaDdU8yRkB/fpClf7vqVCXPJ1Qxo4cxojToznqjQ/baIHSEtTZfQSWDudyCvjxHCPZFDwqNLaq+Ah60vqJm/EhkmqwcHG9R1XA9y0IpflLQMperCGb1aIxadYWQRdN5a4EH0mC1C8e+dYSNpSaKavZkUiA+V2EX9NmlJ12gA+grRZfQMeksLwPkOQ5FNG+v0wlI22li2TB2cRwLDpz1No5Ao1bKRC7zkV3QaTsndXFhkrek7dVSAIrr8hAAWVzEq9n0xupoLdEtcP9yRez/dnhChpBsKdBbThmlvePtmhEY94uxyHALWIqEehztR9Yg/vkejNFzOw6ZYDzEL+XYrOIS4550vkADN18wNBsXdqTyNbygFJLwD0Iv21Ur58i01+RybNF6VvAKeqE7L9W5hZ/WPTdbA40j54Ab4SO/tSnJEw7LtXld4XERgzT4obmEtWSRllwB7nDL1sHWdinxTBN9pzhsBq6l7qW5ow7vY+9M2nJo5yHXIC3C0zVcOX/O2eqxZCsYvMIV81j7AW3n92+55NFguWetyfdNr2sKQDUo1FM+r7ncCtaDSeoKVob3SxQQosMjKUzuebtDao5PsQKzn0dHOwcXMmUi5flVdoIVD7EJQkivGjwgH4g= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(36756003)(86362001)(478600001)(41300700001)(316002)(4326008)(6916009)(70586007)(70206006)(8676002)(54906003)(8936002)(40480700001)(82310400005)(44832011)(5660300002)(2906002)(36860700001)(356005)(186003)(82740400003)(81166007)(1076003)(26005)(2616005)(426003)(47076005)(336012)(83380400001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:04.7072 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc72af7-9755-4072-ca37-08db3ac155e9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5084 Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_lock(). Moving spin_lock to caller was done to prevent the concurrent access to iommu_dt_device_is_assigned while doing add/remove/assign/deassign. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/device_tree.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 1c32d7b50c..bb4cf7784d 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -83,16 +83,15 @@ fail: return rc; } -static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) +static bool_t + iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev) { bool_t assigned = 0; if ( !dt_device_is_protected(dev) ) return 0; - spin_lock(&dtdevs_lock); assigned = !list_empty(&dev->domain_list); - spin_unlock(&dtdevs_lock); return assigned; } @@ -213,27 +212,43 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, if ( (d && d->is_dying) || domctl->u.assign_device.flags ) break; + spin_lock(&dtdevs_lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) + { + spin_unlock(&dtdevs_lock); + break; + } ret = xsm_assign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); if ( ret ) + { + spin_unlock(&dtdevs_lock); + break; + } if ( domctl->cmd == XEN_DOMCTL_test_assign_device ) { - if ( iommu_dt_device_is_assigned(dev) ) + + if ( iommu_dt_device_is_assigned_locked(dev) ) { printk(XENLOG_G_ERR "%s already assigned.\n", dt_node_full_name(dev)); ret = -EINVAL; } + + spin_unlock(&dtdevs_lock); + break; } + spin_unlock(&dtdevs_lock); + if ( d == dom_io ) return -EINVAL; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519778.806807 (Exim 4.92) (envelope-from ) id 1pmJUQ-0006fJ-99; Tue, 11 Apr 2023 19:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519778.806807; Tue, 11 Apr 2023 19:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUP-0006dJ-LC; Tue, 11 Apr 2023 19:17:13 +0000 Received: by outflank-mailman (input) for mailman id 519778; Tue, 11 Apr 2023 19:17:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUN-0004DR-58 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:11 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20625.outbound.protection.outlook.com [2a01:111:f400:fe5a::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73919cc7-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:09 +0200 (CEST) Received: from BN9PR03CA0142.namprd03.prod.outlook.com (2603:10b6:408:fe::27) by DM4PR12MB7526.namprd12.prod.outlook.com (2603:10b6:8:112::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Tue, 11 Apr 2023 19:17:05 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::a2) by BN9PR03CA0142.outlook.office365.com (2603:10b6:408:fe::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:05 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.22 via Frontend Transport; Tue, 11 Apr 2023 19:17:05 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:02 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:02 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:01 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73919cc7-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvRZFbWVxaHzD4dC4eg10s+JGeIh41RGjpq+bd3XY0t9hcciIFmAIf/xunvaYze63VcqaP8lDQIBoG0ArOGN3q0ezmZKBrhNS2VJPfRvLgWOtBxvXk3wP/Y5hb2gRua+HQqpFQyZBbhT3GPys5oZctzZiNmO07UsUtWReK6Cg2TnoZSShhAhjMNYMANyre5ctqTUhJ168r8N2bb4rLzUQpDH5ymPpE4a5xQlb6SGLgwEOJ48CAgd5flxzlaA7xH6uelUGpzk4lPdrhLlBwtJRfy529sag0IAv2JGcwAaMlK8rPanjPldyLK9auTZUvD4AY9kEDEfTcPAtisaOwrzdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gLWShZkghSoju5aCTSrHjPTktEFI3gdZrQ2ShX60hx0=; b=KxsI1IgHe4kyjJTYgsFZFWdpdnVOjddPLs48Hx2uUh+5zs2jS8/T0oe6xPIASt4IeeHSuiDMdecDtOM2c7WT0UFmNL2oWFvv3Ifeptc6jTvcwgO7xzganDpzZ3AKixd0P+QFPSA8SQ5lvbGx0E5bM3eQ6c5kZZvKd1mhKIdHtOp1utdCrQjJDiLbtRVo/tw8/cfAQAm9l7W+Nj+aiee3nWIK4QxyTi0SOcGq5aXtKKn3rjqDqpIrtT2tZECCubVI5sByrivWKtBTUXFTBWcJFerV0eQF8yZGMvGwmBdH3hx6kc80uQLYkaQp1XyV12Inde5nQdIAuMlDKkvw42GQUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLWShZkghSoju5aCTSrHjPTktEFI3gdZrQ2ShX60hx0=; b=NWggMp+NbZSoS74+iEW/lnwNxS/0+U45dx/xyGra3jRZCZ/dfkfv8fv3DPfx3rxJ7FZc8iSwFmlouf7C98Zy+LTDNBg0U7IISXWuutersEy7dJTx5zPfo0BU9grO+Uy/1sa/8XNWxNOd/BoFskPRKMLnF063zd0vUd3Kc6RMoNs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN][PATCH v5 10/17] xen/iommu: Introduce iommu_remove_dt_device() Date: Tue, 11 Apr 2023 12:16:11 -0700 Message-ID: <20230411191636.26926-11-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|DM4PR12MB7526:EE_ X-MS-Office365-Filtering-Correlation-Id: e678d25e-8dd0-4fed-c468-08db3ac15646 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4SMf3AeZxBcqMh+wCIuBWx4KpJmrSvC3Q6Fd/cdWCkn2sVjgyyZjynVpyRRCVplD4p7cX1bmJX8PzrHIYXpPfTZBmYKZFLRIbVNsdcPSiwHAsvtxVPdMUM3rYt0uBAwi3CbZQtanTiEDypOO3bHozVcvs9edN4GDqQayKQwrdlpZwqTUM7Dn3xGqLlQjth+k/NrdL3/fDAT75zeiPZn8Jrrw1aU29UNz+QImHUOTkkhEa2r0uyHUvWdT59Z1M/kyzQwOOJyqOGY4pbrxq6ZMYFAzX7k03In/TlaL+uXrLnDZnZ82Xxbw+g/mtEHlci2wm4JJNySUal8bPXdhEiLRZVDNqiA28f5E3FCAKaTbohv+nRaWhpKe8E3tTKFTC1KAFtngaI+KOaUHNdYMqtmeErZCaWnzMeWVTWhD81JubVi20aQviby1gBWMXZ/YVTAlSn2+ghFDMRKzziSt/jLbRI0sdUpQxNtpe6VHYWGTXv6FTuDmejueMdxSLoobwU01xwNiRaAgBSvoNF3kSyxmrWV3CX/sXLvkFqDPZ7g/uX4vjREiVIhb9XJb8XMnMNyWqNK+Zf4tCGCRxenOxYvbIlc/2jKxVc4sw/ojHVzauZE11kuFcpV1MVUZB7L8aigy5lElgLw7MIX696Bg9wmTK9ASSE9XBvuEaUsBOS8eGAgK1d6KhQJg2qzZqbpOVRPGpAsIA4UWS08+78bJnaCz4M6SNCLP5vfAGm5WdPlqAho= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199021)(40470700004)(36840700001)(46966006)(478600001)(40480700001)(47076005)(36756003)(83380400001)(86362001)(40460700003)(81166007)(356005)(82740400003)(426003)(2616005)(2906002)(316002)(1076003)(336012)(36860700001)(54906003)(44832011)(26005)(186003)(8676002)(8936002)(6666004)(6916009)(82310400005)(41300700001)(5660300002)(70586007)(4326008)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:05.3322 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e678d25e-8dd0-4fed-c468-08db3ac15646 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7526 Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal --- xen/drivers/passthrough/device_tree.c | 38 +++++++++++++++++++++++++++ xen/include/xen/iommu.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 457df333a0..a77a217f3d 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -126,6 +126,44 @@ int iommu_release_dt_devices(struct domain *d) return 0; } +int iommu_remove_dt_device(struct dt_device_node *np) +{ + const struct iommu_ops *ops = iommu_get_ops(); + struct device *dev = dt_to_dev(np); + int rc; + + if ( !ops ) + return -EOPNOTSUPP; + + spin_lock(&dtdevs_lock); + + if ( iommu_dt_device_is_assigned_locked(np) ) + { + rc = -EBUSY; + goto fail; + } + + /* + * The driver which supports generic IOMMU DT bindings must have + * these callback implemented. + */ + if ( !ops->remove_device ) + { + rc = -EOPNOTSUPP; + goto fail; + } + + /* Remove master device from the IOMMU if latter is present and available. */ + rc = ops->remove_device(0, dev); + + if ( !rc ) + iommu_fwspec_free(dev); + +fail: + spin_unlock(&dtdevs_lock); + return rc; +} + int iommu_add_dt_device(struct dt_device_node *np) { const struct iommu_ops *ops = iommu_get_ops(); diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 405db59971..079c06321e 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -218,6 +218,8 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev); int iommu_dt_domain_init(struct domain *d); int iommu_release_dt_devices(struct domain *d); +int iommu_remove_dt_device(struct dt_device_node *np); + /* * Helper to add master device to the IOMMU using generic IOMMU DT bindings. * -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519779.806822 (Exim 4.92) (envelope-from ) id 1pmJUS-0007Ds-DN; Tue, 11 Apr 2023 19:17:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519779.806822; Tue, 11 Apr 2023 19:17:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUR-0007Bc-SA; Tue, 11 Apr 2023 19:17:15 +0000 Received: by outflank-mailman (input) for mailman id 519779; Tue, 11 Apr 2023 19:17:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUO-0004Ta-VA for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:13 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2060f.outbound.protection.outlook.com [2a01:111:f400:7e8d::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75176950-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:11 +0200 (CEST) Received: from BN9PR03CA0140.namprd03.prod.outlook.com (2603:10b6:408:fe::25) by PH7PR12MB6717.namprd12.prod.outlook.com (2603:10b6:510:1b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 11 Apr 2023 19:17:06 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::d5) by BN9PR03CA0140.outlook.office365.com (2603:10b6:408:fe::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:06 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.22 via Frontend Transport; Tue, 11 Apr 2023 19:17:06 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:05 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:04 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:04 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75176950-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fcX85IqJccCGBe/QojBYX98xNDGdabmYF+Zf31yQxBGDff6mnyC5036RjUc+vNeCVVM9gONrC9zUraMNMVOWRsNICeIxhzmjMi/dltGM84fA19Tq+ErybnmMlSpZje5r2zPQg3lnZazpNhNAdM+5KVJko8GlumURs0aXbNPQtBIFMvc5llhGsEaw/qXzVis6NlV9143xMNg0CpJBVPElRmu+5InH9K9uWE5t3fT9rokREVUnuFNcgMTf6rhWQ1sZl+Wgl+IiZLHkhAGzRErEIbNamxllm2/jsIyFYUc9TstI8SCMkZdJEQaf9wMixXzJSg03SrL2uwj0docX5gDAEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vXy30MDq5H9lVjpDCmPPgeX6WY9DS2JY3kC1QKAn9No=; b=EWdxnXZIHj9Q2jeSvYo16U1pFYbKoWoC2fSjscISmOZTKCjofhAH3otiYoq9EgsrwA7oblZnJxGTiwNVcX7lSLiGc3H5bUurk38eDYFOVRNcRk7s2yR/qbQl81SGxhUArMIPYIdeWuA31izTVpMFixl/s4VNKWmWLoN8XrlIId2tCMZ3YYXv66oiVEsbxVGOBOZGyNLdYFbP228nsgbfOrhFqjA1x1NSea8/ftLR42H7zjNHSoEhUa9th3DOONoNPMYD8eHNrxdwBEKR5PGU5RmRmyaxMxcg/OTlGzyesyf3oK3aSKRwHJB54fTKkTTtiXR5njZTFEy61ILRaFryRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vXy30MDq5H9lVjpDCmPPgeX6WY9DS2JY3kC1QKAn9No=; b=TB5K3tBM/Q6w1B75wjMitVnL7DqvAIonQ11xUEnWZ5E17YXNhU7YqMMxdEGzS9TQHnpD1Vsb/aAYnooiZvtNCkXG0+oiVFCsZAdOExBypXdAzv17r9OuhyxrTvcE1HGe9oEfHchBAULwoNvRClZ0Z0aFDHo7aXHqDF6EFdPgq6c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , "Jan Beulich" , Wei Liu Subject: [XEN][PATCH v5 13/17] xen/arm: Implement device tree node removal functionalities Date: Tue, 11 Apr 2023 12:16:14 -0700 Message-ID: <20230411191636.26926-14-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|PH7PR12MB6717:EE_ X-MS-Office365-Filtering-Correlation-Id: d0188860-8724-4ff4-1c1e-08db3ac156e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ETK2kqVrnWW6vEg7dU542k+8z7yWzf4PQnFPqlH3d7oKxJwQjx69chGqA9JIEedbE0LNWVxNifNQELyLIY0R87SVx+5b+Oekmwp0ETMWwHohlVZVHARguE611aybKX+R+jSUUm94ojGqd4OjisXeErDBqWU9cjnWHMs8ZmqE04qTAYIwSct1FVKl7eAbAiD6KqKORABiFkLCE3JEYLXTmYu0oO/wqQwEawVhzp+ChRYki4iaCE5Q+hT+CfgMn9hi1UMmMD2o+vAETEXv4HFthHlQdZnAxJZ3oYbNLBys9BR5EdWL/O1pHfmKHkEjbTkTC1WnwGcoMFW47DKP14ZDFdl1UFeeQvIsZ8m1ClthAer+yEdf1Tzbh8aspHgjfCjXXztApP3NSNvl6dYhPWR6AV6lW27C7NojPCzisjvsjn2N4w2sjdSBA046RzSXi+2/27ifxkgUhNY1e0BpghcuKuWjbzJ6aWcmMrE8aZwaRgudGzYCk4AqgX7UJLZK+MckPdx6fhtFQUh/S4GpSwWu3IyPapi78woFVIV1YtKesRTEXsU4Vsne6hSVkeHxVjxzPFeAu3a4KoC/52Gfp3FX3rDQfvFHRCeypuyHDGuGz2vFL8kNzTGr0udzCArpmC5/f1I7nv4L6MATLHOP0vh6LoKz7jGorLGWUfg4xhGSs7/+V2keNPsO/X/Pm8OAeUeBDpwO1SFBuOnpkpbwD+kI5rCbxUgdQF0zX+F4ENiuFksxwEUAkCEgwhX8byXjH3Ne5bDJoK6qJZdmMjhZQbgnCw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199021)(36840700001)(46966006)(40470700004)(86362001)(30864003)(186003)(5660300002)(44832011)(426003)(336012)(82310400005)(47076005)(356005)(1076003)(26005)(83380400001)(82740400003)(36860700001)(81166007)(316002)(8936002)(8676002)(54906003)(6666004)(40480700001)(478600001)(40460700003)(2616005)(70586007)(6916009)(70206006)(36756003)(41300700001)(4326008)(2906002)(403724002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:06.3633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0188860-8724-4ff4-1c1e-08db3ac156e4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6717 Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes in dt_host and delete the device node entries from dt_host. The nodes get removed only if it is not used by any of dom0 or domio. Also, added overlay_track struct to keep the track of added node through device tree overlay. overlay_track has dt_host_new which is unflattened form of updated fdt and name of overlay nodes. When a node is removed, we also free the memory used by overlay_track for the particular overlay node. Nested overlay removal is supported in sequential manner only i.e. if overlay_child nests under overlay_parent, it is assumed that user first removes overlay_child and then removes overlay_parent. Signed-off-by: Vikram Garhwal --- xen/arch/arm/sysctl.c | 16 +- xen/common/Makefile | 1 + xen/common/dt_overlay.c | 415 +++++++++++++++++++++++++++++++++++ xen/include/public/sysctl.h | 24 ++ xen/include/xen/dt_overlay.h | 59 +++++ 5 files changed, 514 insertions(+), 1 deletion(-) create mode 100644 xen/common/dt_overlay.c create mode 100644 xen/include/xen/dt_overlay.h diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c index b0a78a8b10..672db61650 100644 --- a/xen/arch/arm/sysctl.c +++ b/xen/arch/arm/sysctl.c @@ -12,6 +12,7 @@ #include #include #include +#include void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { @@ -21,7 +22,20 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) long arch_do_sysctl(struct xen_sysctl *sysctl, XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) { - return -ENOSYS; + long ret = 0; + + switch ( sysctl->cmd ) + { + case XEN_SYSCTL_dt_overlay: + ret = dt_sysctl(&sysctl->u.dt_overlay); + break; + + default: + ret = -ENOSYS; + break; + } + + return ret; } /* diff --git a/xen/common/Makefile b/xen/common/Makefile index 46049eac35..be78c9a8c2 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o +obj-$(CONFIG_OVERLAY_DTB) += dt_overlay.o obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c new file mode 100644 index 0000000000..516e8010c5 --- /dev/null +++ b/xen/common/dt_overlay.c @@ -0,0 +1,415 @@ +/* + * SPDX-License-Identifier: GPL-2.0 + * + * xen/common/dt_overlay.c + * + * Device tree overlay support in Xen. + * + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. + * Written by Vikram Garhwal + * + */ +#include +#include +#include +#include +#include + +static LIST_HEAD(overlay_tracker); +static DEFINE_SPINLOCK(overlay_lock); + +/* Find last descendants of the device_node. */ +static struct dt_device_node *find_last_descendants_node( + struct dt_device_node *device_node) +{ + struct dt_device_node *child_node; + + for ( child_node = device_node->child; child_node->sibling != NULL; + child_node = child_node->sibling ) + { + } + + /* If last child_node also have children. */ + if ( child_node->child ) + child_node = find_last_descendants_node(child_node); + + return child_node; +} + +static int dt_overlay_remove_node(struct dt_device_node *device_node) +{ + struct dt_device_node *np; + struct dt_device_node *parent_node; + struct dt_device_node *device_node_last_descendant = device_node->child; + + parent_node = device_node->parent; + + if ( parent_node == NULL ) + { + dt_dprintk("%s's parent node not found\n", device_node->name); + return -EFAULT; + } + + np = parent_node->child; + + if ( np == NULL ) + { + dt_dprintk("parent node %s's not found\n", parent_node->name); + return -EFAULT; + } + + /* If node to be removed is only child node or first child. */ + if ( !dt_node_cmp(np->full_name, device_node->full_name) ) + { + parent_node->child = np->sibling; + + /* + * Iterate over all child nodes of device_node. Given that we are + * removing parent node, we need to remove all it's descendants too. + */ + if ( device_node_last_descendant ) + { + device_node_last_descendant = + find_last_descendants_node(device_node); + parent_node->allnext = device_node_last_descendant->allnext; + } + else + parent_node->allnext = np->allnext; + + return 0; + } + + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) + { + if ( !dt_node_cmp(np->sibling->full_name, device_node->full_name) ) + { + /* Found the node. Now we remove it. */ + np->sibling = np->sibling->sibling; + + if ( np->child ) + np = find_last_descendants_node(np); + + /* + * Iterate over all child nodes of device_node. Given that we are + * removing parent node, we need to remove all it's descendants too. + */ + if ( device_node_last_descendant ) + device_node_last_descendant = + find_last_descendants_node(device_node); + + if ( device_node_last_descendant ) + np->allnext = device_node_last_descendant->allnext; + else + np->allnext = np->allnext->allnext; + + break; + } + } + + return 0; +} + +/* Basic sanity check for the dtbo tool stack provided to Xen. */ +static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) +{ + if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) || + fdt_check_header(overlay_fdt) ) + { + printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device Tree\n"); + return -EINVAL; + } + + return 0; +} + +/* Count number of nodes till one level of __overlay__ tag. */ +static unsigned int overlay_node_count(void *fdto) +{ + unsigned int num_overlay_nodes = 0; + int fragment; + + fdt_for_each_subnode(fragment, fdto, 0) + { + int subnode; + int overlay; + + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + + /* + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for + * overlay >= 0. So, no need for a overlay>=0 check here. + */ + fdt_for_each_subnode(subnode, fdto, overlay) + { + num_overlay_nodes++; + } + } + + return num_overlay_nodes; +} + +static int handle_remove_irq_iommu(struct dt_device_node *device_node) +{ + int rc = 0; + struct domain *d = hardware_domain; + domid_t domid; + unsigned int naddr, len; + unsigned int i, nirq; + uint64_t addr, size; + + domid = dt_device_used_by(device_node); + + dt_dprintk("Checking if node %s is used by any domain\n", + device_node->full_name); + + /* Remove the node iff it's assigned to domain 0 or domain io. */ + if ( domid != 0 && domid != DOMID_IO ) + { + printk(XENLOG_ERR "Device %s as it is being used by domain %d. Removing nodes failed\n", + device_node->full_name, domid); + return -EINVAL; + } + + dt_dprintk("Removing node: %s\n", device_node->full_name); + + nirq = dt_number_of_irq(device_node); + + /* Remove IRQ permission */ + for ( i = 0; i < nirq; i++ ) + { + rc = platform_get_irq(device_node, i);; + + if ( irq_access_permitted(d, rc) == false ) + { + printk(XENLOG_ERR "IRQ %d is not routed to domain %d\n", rc, + domid); + return -EINVAL; + } + /* + * TODO: We don't handle shared IRQs for now. So, it is assumed that + * the IRQs was not shared with another devices. + */ + rc = irq_deny_access(d, rc); + if ( rc ) + { + printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n", + i, device_node->full_name); + return rc; + } + } + + /* Check if iommu property exists. */ + if ( dt_get_property(device_node, "iommus", &len) ) + { + rc = iommu_remove_dt_device(device_node); + if ( rc != 0 && rc != -ENXIO ) + return rc; + } + + naddr = dt_number_of_address(device_node); + + /* Remove mmio access. */ + for ( i = 0; i < naddr; i++ ) + { + rc = dt_device_get_address(device_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(device_node)); + return rc; + } + + rc = iomem_deny_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + size - 1))); + if ( rc ) + { + printk(XENLOG_ERR "Unable to remove dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1); + return rc; + } + + } + + return rc; +} + +/* Removes all descendants of the given node. */ +static int remove_all_descendant_nodes(struct dt_device_node *device_node) +{ + int rc = 0; + struct dt_device_node *child_node; + + for ( child_node = device_node->child; child_node != NULL; + child_node = child_node->sibling ) + { + if ( child_node->child ) + remove_all_descendant_nodes(child_node); + + rc = handle_remove_irq_iommu(child_node); + if ( rc ) + return rc; + } + + return rc; +} + +/* Remove nodes from dt_host. */ +static int remove_nodes(const struct overlay_track *tracker) +{ + int rc = 0; + struct dt_device_node *overlay_node; + unsigned int j; + + for ( j = 0; j < tracker->num_nodes; j++ ) + { + overlay_node = (struct dt_device_node *)tracker->nodes_address[j]; + if ( overlay_node == NULL ) + { + printk(XENLOG_ERR "Device %s is not present in the tree. Removing nodes failed\n", + overlay_node->full_name); + return -EINVAL; + } + + rc = remove_all_descendant_nodes(overlay_node); + + /* All children nodes are unmapped. Now remove the node itself. */ + rc = handle_remove_irq_iommu(overlay_node); + if ( rc ) + return rc; + + read_lock(&dt_host->lock); + + rc = dt_overlay_remove_node(overlay_node); + if ( rc ) + { + read_unlock(&dt_host->lock); + + return rc; + } + + read_unlock(&dt_host->lock); + } + + return rc; +} + +/* + * First finds the device node to remove. Check if the device is being used by + * any dom and finally remove it from dt_host. IOMMU is already being taken care + * while destroying the domain. + */ +static long handle_remove_overlay_nodes(void *overlay_fdt, + uint32_t overlay_fdt_size) +{ + int rc = 0; + struct overlay_track *entry, *temp, *track; + bool found_entry = false; + + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); + if ( rc ) + return rc; + + if ( overlay_node_count(overlay_fdt) == 0 ) + return -ENOMEM; + + spin_lock(&overlay_lock); + + /* + * First check if dtbo is correct i.e. it should one of the dtbo which was + * used when dynamically adding the node. + * Limitation: Cases with same node names but different property are not + * supported currently. We are relying on user to provide the same dtbo + * as it was used when adding the nodes. + */ + list_for_each_entry_safe( entry, temp, &overlay_tracker, entry ) + { + if ( memcmp(entry->overlay_fdt, overlay_fdt, overlay_fdt_size) == 0 ) + { + track = entry; + found_entry = true; + break; + } + } + + if ( found_entry == false ) + { + rc = -EINVAL; + + printk(XENLOG_ERR "Cannot find any matching tracker with input dtbo." + " Removing nodes is supported for only prior added dtbo. Please" + " provide a valid dtbo which was used to add the nodes.\n"); + goto out; + + } + + rc = remove_nodes(entry); + + if ( rc ) + { + printk(XENLOG_ERR "Removing node failed\n"); + goto out; + } + + list_del(&entry->entry); + + xfree(entry->dt_host_new); + xfree(entry->fdt); + xfree(entry->overlay_fdt); + + xfree(entry->nodes_address); + + xfree(entry); + +out: + spin_unlock(&overlay_lock); + return rc; +} + +long dt_sysctl(struct xen_sysctl_dt_overlay *op) +{ + long ret; + void *overlay_fdt; + + if ( op->overlay_fdt_size <= 0 || op->overlay_fdt_size > KB(500) ) + return -EINVAL; + + overlay_fdt = xmalloc_bytes(op->overlay_fdt_size); + + if ( overlay_fdt == NULL ) + return -ENOMEM; + + ret = copy_from_guest(overlay_fdt, op->overlay_fdt, op->overlay_fdt_size); + if ( ret ) + { + gprintk(XENLOG_ERR, "copy from guest failed\n"); + xfree(overlay_fdt); + + return -EFAULT; + } + + switch ( op->overlay_op ) + { + case XEN_SYSCTL_DT_OVERLAY_REMOVE: + ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); + xfree(overlay_fdt); + + break; + + default: + xfree(overlay_fdt); + break; + } + + return ret; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 2b24d6bfd0..1158c1efb3 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -1057,6 +1057,25 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); #endif +#if defined(__arm__) || defined (__aarch64__) +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 +#define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 + +/* + * XEN_SYSCTL_dt_overlay + * Performs addition/removal of device tree nodes under parent node using dtbo. + * This does in three steps: + * - Adds/Removes the nodes from dt_host. + * - Adds/Removes IRQ permission for the nodes. + * - Adds/Removes MMIO accesses. + */ +struct xen_sysctl_dt_overlay { + XEN_GUEST_HANDLE_64(void) overlay_fdt; /* IN: overlay fdt. */ + uint32_t overlay_fdt_size; /* IN: Overlay dtb size. */ + uint8_t overlay_op; /* IN: Add or remove. */ +}; +#endif + struct xen_sysctl { uint32_t cmd; #define XEN_SYSCTL_readconsole 1 @@ -1087,6 +1106,7 @@ struct xen_sysctl { #define XEN_SYSCTL_livepatch_op 27 /* #define XEN_SYSCTL_set_parameter 28 */ #define XEN_SYSCTL_get_cpu_policy 29 +#define XEN_SYSCTL_dt_overlay 30 uint32_t interface_version; /* XEN_SYSCTL_INTERFACE_VERSION */ union { struct xen_sysctl_readconsole readconsole; @@ -1117,6 +1137,10 @@ struct xen_sysctl { #if defined(__i386__) || defined(__x86_64__) struct xen_sysctl_cpu_policy cpu_policy; #endif + +#if defined(__arm__) || defined (__aarch64__) + struct xen_sysctl_dt_overlay dt_overlay; +#endif uint8_t pad[128]; } u; }; diff --git a/xen/include/xen/dt_overlay.h b/xen/include/xen/dt_overlay.h new file mode 100644 index 0000000000..2cd975a070 --- /dev/null +++ b/xen/include/xen/dt_overlay.h @@ -0,0 +1,59 @@ +/* + * SPDX-License-Identifier: GPL-2.0 + * + * xen/dt_overlay.h + * + * Device tree overlay support in Xen. + * + * Copyright (c) 2022 AMD Inc. + * Written by Vikram Garhwal + * + */ +#ifndef __XEN_DT_SYSCTL_H__ +#define __XEN_DT_SYSCTL_H__ + +#include +#include +#include +#include + +/* + * overlay_node_track describes information about added nodes through dtbo. + * @entry: List pointer. + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. + * @fdt: Stores the fdt. + * @nodes_fullname: Stores the full name of nodes. + * @nodes_irq: Stores the IRQ added from overlay dtb. + * @node_num_irq: Stores num of IRQ for each node in overlay dtb. + * @num_nodes: Stores total number of nodes in overlay dtb. + */ +struct overlay_track { + struct list_head entry; + struct dt_device_node *dt_host_new; + void *fdt; + void *overlay_fdt; + unsigned long *nodes_address; + unsigned int num_nodes; +}; + +struct xen_sysctl_dt_overlay; + +#ifdef CONFIG_OVERLAY_DTB +long dt_sysctl(struct xen_sysctl_dt_overlay *op); +#else +static inline long dt_sysctl(struct xen_sysctl_dt_overlay *op) +{ + return -ENOSYS; +} +#endif +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519780.806829 (Exim 4.92) (envelope-from ) id 1pmJUT-0007Qi-98; Tue, 11 Apr 2023 19:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519780.806829; Tue, 11 Apr 2023 19:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUS-0007Lm-LY; Tue, 11 Apr 2023 19:17:16 +0000 Received: by outflank-mailman (input) for mailman id 519780; Tue, 11 Apr 2023 19:17:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUP-0004Ta-VN for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:14 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20616.outbound.protection.outlook.com [2a01:111:f400:7e89::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75148f5c-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:12 +0200 (CEST) Received: from MW4PR04CA0047.namprd04.prod.outlook.com (2603:10b6:303:6a::22) by MN2PR12MB4502.namprd12.prod.outlook.com (2603:10b6:208:263::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:07 +0000 Received: from CO1NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::73) by MW4PR04CA0047.outlook.office365.com (2603:10b6:303:6a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT085.mail.protection.outlook.com (10.13.174.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:06 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:06 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:05 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:05 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75148f5c-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZdxqLJLgKXDWMojKmWYYz9UnYELtxncFWW4wx0bV5HcVbaJrpZBh04U5pSoVFPsQkFcKZDIq1Cg8njnRsZo6At6d4z/W7Zb556MDP3/UZ4X1Wb5wU8M5Er5sE3aE8e8e1aOyEtOXb76xht+yVKRN7MYBlIlizy+KTpDxKe4zd1CmkCF4sn+uCQ0yjObeHk7/SE6yLnGUgnlu68frNEVqHXGYkKu5drI0ZpXtqvO3qVhNk/rpBs+02yeuqTefgfStDVLs8Nuc0LaUnIWCzCro0vRIkBdCAavv7c2RUSxDWRs+0RhhYHkJuRPKWQPVvsr5gpIkF3+fZ5oLOfEcn4RWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+cCBf3g6fBI4ES7DG61XJTRWpPAgPp5V0YvFzOd6Q8=; b=KJK2ygR2wbBhuVxFyoZFLe+hjdtRm5koMDZd9Oeof9o6Aryt6qAPXH4LSXA53BlJtoWTl7/QMpPB3rE1/jgDjcVx6BzJS2qm1j1Nzza7P1YhA10GSS0bJNqHNjNK7+g9BV0KMtvFYvDXV4I+yVf5/9R1o0iETEgk5CSteU9Iuq8c1w26r9xNQoxbwSH7Xf31WwyiYOFDY1Z8BWsfLWkNm4M35eIeZSkN2Px0Y9WJI6r1y6CaciDRh+ALhIi+01A2xtV+iMUUCCug8h1kLS0BerTPjTmiuO8KQzFu4jVy1oFWzmC8mSZ7Prz+LFeloL+VwtbV04/T7J/jbrAjQpbNMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3+cCBf3g6fBI4ES7DG61XJTRWpPAgPp5V0YvFzOd6Q8=; b=brYbKaGU8Q72lJSgTQfQSW8LmLDO7PvXt2hCa4KPGUB8MerKituz4Z9o0vpiMd3zauNzeTF9tRf/OkKJfza8PRinChP0AN4UqPhRxE7AF4B7Ohpaal8qYF6xk+4HuIFn2jQ6lgAMkQS8ir7ykY4Ws1ZcEeHGCpeoyIoCKF37Z+I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN][PATCH v5 14/17] xen/arm: Implement device tree node addition functionalities Date: Tue, 11 Apr 2023 12:16:15 -0700 Message-ID: <20230411191636.26926-15-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT085:EE_|MN2PR12MB4502:EE_ X-MS-Office365-Filtering-Correlation-Id: c6a6d862-d820-4db3-7343-08db3ac15750 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MmAyEa5oVIVl3CtWWYgdlvLVK6ewQoub2983E5bimxekYFO5Peb8HJsCasTmDKy/FzyLzXzOVomWOv2EFfH7ERRVTuHUGIYfKq54yrOp0jb8L+OG6ab/c/7eSpMtPAQeyXF1dyw7OlLUZV7gMQCeGsE2wKS6BmaFmzlBR80+wO7Z/IMmuca/CSfj4rCyJBtwSBtlAjnDlaJ6+5ulPhbbNEeddu0NNyXLzXtnhQgQo/sPjTEdQIlHQVC5wrJt+Q2dHRPbcLz90zCboCsQl5U+OcqJlPg6sZ0RLrXEdmqnEN7Ox3+7UupKtwwqmjgb34j4AyBqYsr1ZO7FWUP84f44ybjswyvoIlbJkiYcx5pyYDjerN7W4GaXoctw5xFMzz7eNNlzlGuTtURm1KSrhOEqnnnm1s9NU6n53DJuPYQL3njtUgGoQhYtMqFiXhYMXTKWLyBiaV8k5ew7WeCfLAFAR6y+YAc0EwCQYAcCemvz7YJKA1XGh7ygvZ6b+qrUXSH3W1iyKgQLTBD3h5gd+NdUHWzsVWQR9HfOajVGzAivWRoRRYkj2GMll49MUooNSHSWL5C5TAi7sj6hYuXl324GMIYIdayWJn4emzVeGGRfVyRYQZsXtk4BhqaF9SselyMrRpSuMC62XFvr1Q6AcaoQc5IZhXJXLs3UU5cTaVUeSB/uJgnQHukVeTC9TL4ycINQumm2Kk0n0lrIEEZJb8+WMESo8HpBytE9R4oFUgdIvk8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199021)(36840700001)(46966006)(40470700004)(316002)(82310400005)(54906003)(82740400003)(36860700001)(356005)(81166007)(70586007)(8676002)(70206006)(4326008)(86362001)(6916009)(478600001)(426003)(336012)(47076005)(186003)(2616005)(26005)(41300700001)(36756003)(1076003)(2906002)(83380400001)(30864003)(40460700003)(44832011)(40480700001)(8936002)(6666004)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:06.9640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6a6d862-d820-4db3-7343-08db3ac15750 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4502 Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition using device tree overlay. xl dt-overlay add file.dtbo: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflattened to a dt_host_new. Next, it checks if any of the overlay nodes already exists in the dt_host. If overlay nodes doesn't exist then find the overlay nodes in dt_host_new, find the overlay node's parent in dt_host and add the nodes as child under their parent in the dt_host. The node is attached as the last node under target parent. Finally, add IRQs, add device to IOMMUs, set permissions and map MMIO for the overlay node. When a node is added using overlay, a new entry is allocated in the overlay_track to keep the track of memory allocation due to addition of overlay node. This is helpful for freeing the memory allocated when a device tree node is removed. The main purpose of this to address first part of dynamic programming i.e. making xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/setting IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". Signed-off-by: Vikram Garhwal --- xen/common/dt_overlay.c | 482 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 482 insertions(+) diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c index 516e8010c5..3344bad313 100644 --- a/xen/common/dt_overlay.c +++ b/xen/common/dt_overlay.c @@ -36,6 +36,25 @@ static struct dt_device_node *find_last_descendants_node( return child_node; } +/* + * Returns next node to the input node. If node has children then return + * last descendant's next node. +*/ +static struct dt_device_node *dt_find_next_node(struct dt_device_node *dt, + const struct dt_device_node *node) +{ + struct dt_device_node *np; + + dt_for_each_device_node(dt, np) + if ( np == node ) + break; + + if ( np->child ) + np = find_last_descendants_node(np); + + return np->allnext; +} + static int dt_overlay_remove_node(struct dt_device_node *device_node) { struct dt_device_node *np; @@ -109,6 +128,72 @@ static int dt_overlay_remove_node(struct dt_device_node *device_node) return 0; } +static int dt_overlay_add_node(struct dt_device_node *device_node, + const char *parent_node_path) +{ + struct dt_device_node *parent_node; + struct dt_device_node *np, *np_last_descendant; + struct dt_device_node *next_node; + struct dt_device_node *device_node_last_descendant; + + parent_node = dt_find_node_by_path(parent_node_path); + + if ( parent_node == NULL ) + { + dt_dprintk("Node not found. Overlay node will not be added\n"); + return -EINVAL; + } + + /* If parent has no child. */ + if ( parent_node->child == NULL ) + { + next_node = parent_node->allnext; + device_node->parent = parent_node; + parent_node->allnext = device_node; + parent_node->child = device_node; + } + else + { + /* If parent has at least one child node. + * Iterate to the last child node of parent. + */ + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ); + + /* Iterate over all child nodes of np node. */ + if ( np->child ) + { + np_last_descendant = find_last_descendants_node(np); + + next_node = np_last_descendant->allnext; + np_last_descendant->allnext = device_node; + } + else + { + next_node = np->allnext; + np->allnext = device_node; + } + + device_node->parent = parent_node; + np->sibling = device_node; + np->sibling->sibling = NULL; + } + + /* Iterate over all child nodes of device_node to add children too. */ + if ( device_node->child ) + { + device_node_last_descendant = find_last_descendants_node(device_node); + /* Plug next_node at the end of last children of device_node. */ + device_node_last_descendant->allnext = next_node; + } + else + { + /* Now plug next_node at the end of device_node. */ + device_node->allnext = next_node; + } + + return 0; +} + /* Basic sanity check for the dtbo tool stack provided to Xen. */ static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) { @@ -148,6 +233,79 @@ static unsigned int overlay_node_count(void *fdto) return num_overlay_nodes; } +/* + * overlay_get_nodes_info will get full name with path for all the nodes which + * are in one level of __overlay__ tag. This is useful when checking node for + * duplication i.e. dtbo tries to add nodes which already exists in device tree. + */ +static int overlay_get_nodes_info(const void *fdto, char ***nodes_full_path, + unsigned int num_overlay_nodes) +{ + int fragment; + + *nodes_full_path = xzalloc_bytes(num_overlay_nodes * sizeof(char *)); + + if ( *nodes_full_path == NULL ) + return -ENOMEM; + + fdt_for_each_subnode(fragment, fdto, 0) + { + int target; + int overlay; + int subnode; + const char *target_path; + + target = fdt_overlay_target_offset(device_tree_flattened, fdto, + fragment, &target_path); + if ( target < 0 ) + return target; + + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + + /* + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for + * overlay >= 0. So, no need for a overlay>=0 check here. + */ + fdt_for_each_subnode(subnode, fdto, overlay) + { + const char *node_name = NULL; + int node_name_len; + unsigned int target_path_len = strlen(target_path); + unsigned int node_full_name_len; + unsigned int node_num = 0; + + node_name = fdt_get_name(fdto, subnode, &node_name_len); + + if ( node_name == NULL ) + return node_name_len; + + /* + * Magic number 2 is for adding '/'. This is done to keep the + * node_full_name in the correct full node name format. + */ + node_full_name_len = target_path_len + node_name_len + 2; + + (*nodes_full_path)[node_num] = xmalloc_bytes(node_full_name_len); + + if ( (*nodes_full_path)[node_num] == NULL ) + return -ENOMEM; + + memcpy((*nodes_full_path)[node_num], target_path, target_path_len); + + (*nodes_full_path)[node_num][target_path_len] = '/'; + + memcpy((*nodes_full_path)[node_num] + target_path_len + 1, + node_name, node_name_len); + + (*nodes_full_path)[node_num][node_full_name_len - 1] = '\0'; + + node_num++; + } + } + + return 0; +} + static int handle_remove_irq_iommu(struct dt_device_node *device_node) { int rc = 0; @@ -367,6 +525,322 @@ out: return rc; } +/* + * Handles IRQ and IOMMU mapping for the overlay_node and all descendants of the + * overlay_nodes. + */ +static int handle_add_irq_iommu(struct domain *d, + struct dt_device_node *overlay_node) +{ + int rc; + unsigned int naddr, i, len; + uint64_t addr, size; + struct dt_device_node *np; + + /* First let's handle the interrupts. */ + rc = handle_device_interrupts(d, overlay_node, false); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Interrupt failed\n"); + return rc; + } + + /* Check if iommu property exists. */ + if ( dt_get_property(overlay_node, "iommus", &len) ) + { + + /* Add device to IOMMUs. */ + rc = iommu_add_dt_device(overlay_node); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Failed to add %s to the IOMMU\n", + dt_node_full_name(overlay_node)); + return rc; + } + } + + /* Set permissions. */ + naddr = dt_number_of_address(overlay_node); + + dt_dprintk("%s passthrough = %d naddr = %u\n", + dt_node_full_name(overlay_node), false, naddr); + + /* Give permission for map MMIOs */ + for ( i = 0; i < naddr; i++ ) + { + /* + * For now, we skip_mapping which means it will only permit iomem access + * to hardware_domain using iomem_permit_access() but will never map as + * map_range_p2mt() will not be called. + */ + struct map_range_data mr_data = { .d = d, + .p2mt = p2m_mmio_direct_c, + .skip_mapping = true }; + + rc = dt_device_get_address(overlay_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(overlay_node)); + return rc; + } + + rc = map_range_to_domain(overlay_node, addr, size, &mr_data); + if ( rc ) + return rc; + } + + /* Map IRQ and IOMMU for overlay_node's children. */ + for ( np = overlay_node->child; np != NULL; np = np->sibling) + { + rc = handle_add_irq_iommu(d, np); + if ( rc ) + { + printk(XENLOG_ERR "Adding IRQ and IOMMU failed\n"); + return rc; + } + } + + return rc; +} + +/* + * Adds device tree nodes under target node. + * We use tr->dt_host_new to unflatten the updated device_tree_flattened. This + * is done to avoid the removal of device_tree generation, iomem regions mapping + * to hardware domain done by handle_node(). + */ +static long handle_add_overlay_nodes(void *overlay_fdt, + uint32_t overlay_fdt_size) +{ + int rc, j, i; + struct dt_device_node *overlay_node, *prev_node, *next_node; + struct domain *d = hardware_domain; + struct overlay_track *tr = NULL; + char **nodes_full_path = NULL; + unsigned int new_fdt_size; + + tr = xzalloc(struct overlay_track); + if ( tr == NULL ) + return -ENOMEM; + + new_fdt_size = fdt_totalsize(device_tree_flattened) + + fdt_totalsize(overlay_fdt); + + tr->fdt = xzalloc_bytes(new_fdt_size); + if ( tr->fdt == NULL ) + { + xfree(tr); + return -ENOMEM; + } + + tr->num_nodes = overlay_node_count(overlay_fdt); + if ( tr->num_nodes == 0 ) + { + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + tr->nodes_address = xzalloc_bytes(tr->num_nodes * sizeof(unsigned long)); + if ( tr->nodes_address == NULL ) + { + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); + if ( rc ) + { + xfree(tr->nodes_address); + xfree(tr->fdt); + xfree(tr); + return rc; + } + + /* + * Keep a copy of overlay_fdt as fdt_overlay_apply will change the input + * overlay's content(magic) when applying overlay. + */ + tr->overlay_fdt = xzalloc_bytes(overlay_fdt_size); + if ( tr->overlay_fdt == NULL ) + { + xfree(tr->nodes_address); + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + memcpy(tr->overlay_fdt, overlay_fdt, overlay_fdt_size); + + spin_lock(&overlay_lock); + + memcpy(tr->fdt, device_tree_flattened, + fdt_totalsize(device_tree_flattened)); + + /* Open tr->fdt with more space to accommodate the overlay_fdt. */ + fdt_open_into(tr->fdt, tr->fdt, new_fdt_size); + + /* + * overlay_get_nodes_info is called to get the node information from dtbo. + * This is done before fdt_overlay_apply() because the overlay apply will + * erase the magic of overlay_fdt. + */ + rc = overlay_get_nodes_info(overlay_fdt, &nodes_full_path, + tr->num_nodes); + if ( rc ) + { + printk(XENLOG_ERR "Getting nodes information failed with error %d\n", + rc); + goto err; + } + + rc = fdt_overlay_apply(tr->fdt, overlay_fdt); + if ( rc ) + { + printk(XENLOG_ERR "Adding overlay node failed with error %d\n", rc); + goto err; + } + + /* + * Check if any of the node already exists in dt_host. If node already exits + * we can return here as this overlay_fdt is not suitable for overlay ops. + */ + for ( j = 0; j < tr->num_nodes; j++ ) + { + overlay_node = dt_find_node_by_path(nodes_full_path[j]); + if ( overlay_node != NULL ) + { + printk(XENLOG_ERR "node %s exists in device tree\n", + nodes_full_path[j]); + rc = -EINVAL; + goto err; + } + } + + /* Unflatten the tr->fdt into a new dt_host. */ + unflatten_device_tree(tr->fdt, &tr->dt_host_new); + + for ( j = 0; j < tr->num_nodes; j++ ) + { + dt_dprintk("Adding node: %s\n", nodes_full_path[j]); + + /* Find the newly added node in tr->dt_host_new by it's full path. */ + overlay_node = device_tree_find_node_by_path(tr->dt_host_new, + nodes_full_path[j]); + if ( overlay_node == NULL ) + { + dt_dprintk("%s node not found\n", nodes_full_path[j]); + rc = -EFAULT; + goto remove_node; + } + + /* + * Find previous and next node to overlay_node in dt_host_new. We will + * need these nodes to fix the dt_host_new mapping. When overlay_node is + * take out of dt_host_new tree and added to dt_host, link between + * previous node and next_node is broken. We will need to refresh + * dt_host_new with correct linking for any other overlay nodes + * extraction in future. + */ + dt_for_each_device_node(tr->dt_host_new, prev_node) + if ( prev_node->allnext == overlay_node ) + break; + + next_node = dt_find_next_node(tr->dt_host_new, overlay_node); + + read_lock(&dt_host->lock); + + /* Add the node to dt_host. */ + rc = dt_overlay_add_node(overlay_node, overlay_node->parent->full_name); + if ( rc ) + { + read_unlock(&dt_host->lock); + + /* Node not added in dt_host. */ + goto remove_node; + } + + read_unlock(&dt_host->lock); + + prev_node->allnext = next_node; + + overlay_node = dt_find_node_by_path(overlay_node->full_name); + if ( overlay_node == NULL ) + { + /* Sanity check. But code will never come here. */ + ASSERT_UNREACHABLE(); + goto remove_node; + } + + rc = handle_add_irq_iommu(d, overlay_node); + if ( rc ) + { + printk(XENLOG_ERR "Adding IRQ and IOMMU failed\n"); + return rc; + } + + /* Keep overlay_node address in tracker. */ + tr->nodes_address[j] = (unsigned long)overlay_node; + } + + INIT_LIST_HEAD(&tr->entry); + list_add_tail(&tr->entry, &overlay_tracker); + + spin_unlock(&overlay_lock); + + if ( nodes_full_path != NULL ) + { + for ( i = 0; i < tr->num_nodes && nodes_full_path[i] != NULL; + i++ ) + { + xfree(nodes_full_path[i]); + } + xfree(nodes_full_path); + } + + return rc; + +/* + * Failure case. We need to remove the nodes, free tracker(if tr exists) and + * tr->dt_host_new. + */ +remove_node: + tr->num_nodes = j; + rc = remove_nodes(tr); + + if ( rc ) + { + /* If removing node fails, this may cause memory leaks. */ + printk(XENLOG_ERR "Removing node failed.\n"); + spin_unlock(&overlay_lock); + return rc; + } + +err: + spin_unlock(&overlay_lock); + + xfree(tr->dt_host_new); + xfree(tr->fdt); + xfree(tr->overlay_fdt); + xfree(tr->nodes_address); + + if ( nodes_full_path != NULL ) + { + for ( i = 0; i < tr->num_nodes && nodes_full_path[i] != NULL; + i++ ) + { + xfree(nodes_full_path[i]); + } + xfree(nodes_full_path); + } + + xfree(tr); + + return rc; +} + long dt_sysctl(struct xen_sysctl_dt_overlay *op) { long ret; @@ -391,6 +865,14 @@ long dt_sysctl(struct xen_sysctl_dt_overlay *op) switch ( op->overlay_op ) { + case XEN_SYSCTL_DT_OVERLAY_ADD: + ret = handle_add_overlay_nodes(overlay_fdt, op->overlay_fdt_size); + + if ( ret ) + xfree(overlay_fdt); + + break; + case XEN_SYSCTL_DT_OVERLAY_REMOVE: ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); xfree(overlay_fdt); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519782.806842 (Exim 4.92) (envelope-from ) id 1pmJUV-0007pa-9l; Tue, 11 Apr 2023 19:17:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519782.806842; Tue, 11 Apr 2023 19:17:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUU-0007iE-Ba; Tue, 11 Apr 2023 19:17:18 +0000 Received: by outflank-mailman (input) for mailman id 519782; Tue, 11 Apr 2023 19:17:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUQ-0004Ta-Vc for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:14 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75d4f138-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:13 +0200 (CEST) Received: from MW4PR04CA0033.namprd04.prod.outlook.com (2603:10b6:303:6a::8) by SA0PR12MB4559.namprd12.prod.outlook.com (2603:10b6:806:9e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:09 +0000 Received: from CO1NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::c1) by MW4PR04CA0033.outlook.office365.com (2603:10b6:303:6a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:09 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT085.mail.protection.outlook.com (10.13.174.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:09 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:08 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:08 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:08 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75d4f138-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTml8cnkj84ksqDvwmgLUZtR0xNNi8j8gmyZZ50NnJf6XmYk4HgUz7aoClfr4FK1jkfk4g7plQg+djTV75FFKMdPB0MHeFeu0W4d0eHgep/Ape8kzIMtibQyKSlQ2HcwCfkhZzQ61cG3MKquXcpIboKoRpvhINdRYEs+179ympYaKf2fbqF8cKSx9vE423zovjpRNHKf8rT7ooFcREz351MXGRmnGy6V3YM6zUOi5R2bLLuPmsJUV1ZOd6WLqzdMTidyptnQAZ1a+SAT06XcG4KIgsiHhXXdlILV4juyOxujiRVVO0R3sE+nX8flJHmSfRO67haMXeHYRNxVuNkp7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W8ANf04rvVBwwTVoSmk1wMh7BnV4jbgpw3PgliDnkIY=; b=HnPfgKNaLFifYRiXm89CjxS4F6TXWN/XgNhsUBNeY+VHE1YVDqBxhjNCQQL9rrOaT2XRtjgRmxCcikoVKx8LaB9Nq4VyTfo4SF/u9kg79qz3XWzXcmnK15+nx4p9iJf2zR5U/9VawbiiPi4Z5SGyGvtbLAqpw0w0GhF0M6caGbWoLlFL5cc9AGmrKvApx63v4pC5aQMtmIDvV66olDZ6NDoOZSfW/jgb4Xt+R4ldKtWAwvLbNW+VuVEhubTNm4sw1xwK+i4JH+RcZC1LwUr+euvvnhE8w4TQmOoN4wA6g1Bup0r8nhtRTHJ4UaCYiJ8oJsInS9QTJaAyt/2IDafrXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8ANf04rvVBwwTVoSmk1wMh7BnV4jbgpw3PgliDnkIY=; b=rkrcfNVyCeJcZHMV3Mza5hd29yd4W4yc4A3VEwlix84TV47Qvdg/J/YD/UzPLoW9asNTunX/Xp1eeCtMc+rad/aRjHlgyONX5dtS7Tsk6n5H+vz4iSpN/C0apzzGMBWgTn55O00uFgxIx77ez6Pq5BTvsFNeOEPLg5z4cgq0ftM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , Wei Liu , Anthony PERARD Subject: [XEN][PATCH v5 17/17] tools/xl: Add new xl command overlay for device tree overlay support Date: Tue, 11 Apr 2023 12:16:18 -0700 Message-ID: <20230411191636.26926-18-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT085:EE_|SA0PR12MB4559:EE_ X-MS-Office365-Filtering-Correlation-Id: e028d683-9b8b-4468-33f4-08db3ac158bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: acc5R9HxREvMwAXUxJDUDLP/yKj+S5WJ6zRQIH7J2xdWmf3Jqiu7x0lcP9LSJvCgCr61Qk9r2NXH5f2ToI2cyrpaUf67UPfRtH+cqDrbkgcuvmndpY8kp99iOxQzTV1MwgCXPdcXVFz8AqacI55kDNTUEpxempIAws7UXihOK5HmtDyLJfKyUMrlGm+W+kSv9q7RCCboOcVU2zwbraBLJ/0S+2kv0PIBQQZK8YFeNFVBOaJipQSAHQvdYRdtf5rXVjWEGhawFasc9dkrtYACET2+YgH6HTx3qyGDJU78m1Hu94wiaswrAQl1PdxBrodzHvqioimRUT8hz7VWmUOM9gA5iHF17CLEjxD9XDCeES0fvA4ZGBxWwI3uRoHYiCw0hniX07Rpwu7kM9Ce0cZyFL0a22B/DWq2394y70mdK5twYuNIKSb5TrZHA9bsEcOq6xrTzbrZPDSXEDTL33u6+yH5VG6Ut3qdKkOPbeNxkSY2S7bVPMPWJ0QsunegqlGFmg1GXz3QMTj+7WHEEJ4Ycwp96sfqQnX0a3b3xCSimkkQe3OwPzn5xpQtaFKyW8zg9UykK3EN/efvjcUGcsr6qxgLBnSjYk0k/XXVX8TqWHZAafajz+PAMfJc+aRFCDzRABFLsJdzfmHz+XhqKWdWA1DifLmYYxeIF5IRWUthWjHyOK6pCs9V561lQJMWq3rmDuoT29l5fO/6WKMwB/z54sksBswB4M1iehdjS67IFk8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199021)(46966006)(40470700004)(36840700001)(478600001)(40460700003)(40480700001)(47076005)(83380400001)(36756003)(82740400003)(356005)(81166007)(426003)(86362001)(2616005)(336012)(36860700001)(6666004)(44832011)(2906002)(316002)(1076003)(186003)(5660300002)(26005)(54906003)(41300700001)(8936002)(6916009)(82310400005)(8676002)(70206006)(70586007)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:09.3544 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e028d683-9b8b-4468-33f4-08db3ac158bd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4559 Signed-off-by: Vikram Garhwal --- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 +++++ tools/xl/xl_vmcontrol.c | 52 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 59 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 72538d6a81..a923daccd3 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -138,6 +138,7 @@ int main_shutdown(int argc, char **argv); int main_reboot(int argc, char **argv); int main_list(int argc, char **argv); int main_vm_list(int argc, char **argv); +int main_dt_overlay(int argc, char **argv); int main_create(int argc, char **argv); int main_config_update(int argc, char **argv); int main_button_press(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index ccf4d83584..db0acff62a 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -630,6 +630,12 @@ const struct cmd_spec cmd_table[] = { "Issue a qemu monitor command to the device model of a domain", " ", }, + { "dt-overlay", + &main_dt_overlay, 0, 1, + "Add/Remove a device tree overlay", + "add/remove <.dtbo>" + "-h print this help\n" + }, }; const int cmdtable_len = ARRAY_SIZE(cmd_table); diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 5518c78dc6..de56e00d8b 100644 --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1265,6 +1265,58 @@ int main_create(int argc, char **argv) return 0; } +int main_dt_overlay(int argc, char **argv) +{ + const char *overlay_ops = NULL; + const char *overlay_config_file = NULL; + void *overlay_dtb = NULL; + int rc; + uint8_t op; + int overlay_dtb_size = 0; + const int overlay_add_op = 1; + const int overlay_remove_op = 2; + + if (argc < 2) { + help("dt_overlay"); + return EXIT_FAILURE; + } + + overlay_ops = argv[1]; + overlay_config_file = argv[2]; + + if (strcmp(overlay_ops, "add") == 0) + op = overlay_add_op; + else if (strcmp(overlay_ops, "remove") == 0) + op = overlay_remove_op; + else { + fprintf(stderr, "Invalid dt overlay operation\n"); + return EXIT_FAILURE; + } + + if (overlay_config_file) { + rc = libxl_read_file_contents(ctx, overlay_config_file, + &overlay_dtb, &overlay_dtb_size); + + if (rc) { + fprintf(stderr, "failed to read the overlay device tree file %s\n", + overlay_config_file); + free(overlay_dtb); + return ERROR_FAIL; + } + } else { + fprintf(stderr, "overlay dtbo file not provided\n"); + return ERROR_FAIL; + } + + rc = libxl_dt_overlay(ctx, overlay_dtb, overlay_dtb_size, op); + + free(overlay_dtb); + + if (rc) + return EXIT_FAILURE; + + return rc; +} /* * Local variables: * mode: C -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519783.806848 (Exim 4.92) (envelope-from ) id 1pmJUV-0007ww-RZ; Tue, 11 Apr 2023 19:17:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519783.806848; Tue, 11 Apr 2023 19:17:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUV-0007uF-01; Tue, 11 Apr 2023 19:17:19 +0000 Received: by outflank-mailman (input) for mailman id 519783; Tue, 11 Apr 2023 19:17:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUR-0004DR-Q0 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:15 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20606.outbound.protection.outlook.com [2a01:111:f400:7e8c::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75bcde91-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:13 +0200 (CEST) Received: from MW4PR04CA0041.namprd04.prod.outlook.com (2603:10b6:303:6a::16) by IA1PR12MB6529.namprd12.prod.outlook.com (2603:10b6:208:3a6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Tue, 11 Apr 2023 19:17:08 +0000 Received: from CO1NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::d0) by MW4PR04CA0041.outlook.office365.com (2603:10b6:303:6a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 19:17:08 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT085.mail.protection.outlook.com (10.13.174.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:08 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:07 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:06 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:06 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75bcde91-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YpIDKdgdf7yz2eJTAnEtGnIAAnvHfpj3300VLO6iafBOlyg9uKGtWR8AlWLxZXP7jXq9z+MOemUrxotW3ALnTbYqRKLYnv4hTlBU7fOiISFawFTn2sfZGHNIb/LaE9ZO2I+2Qd/HNcuwn5+M8fnxdXlS6Bqmzr3N6eCnwFV/c9YZRm82uhULvb8h7wuS9Mip6Y5DUmuTbpTPaJGax/zVmWaporPWDtZGvPYZXRhakfjvF5Glz2cx6XgfjW78lAGD/6ddcqxVFNiG3vicbmGg0mYIVHVd7jMXYOiGlYnApFw9Vr1UlR226LBQIzbrDZb7A5rL6hhtY7hLB1EWpHlorQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkwDgQcNvE9UkGiRuGgnKgAIS4K7kLAxiI7Z7Wg7YaY=; b=F5OZE8ajLmHZ/3smvtrG3B3WH5oV4QmrHteG/vHTRllwu508EHSaQPST7gJiFbgHoDWf/e2BCweqleNSWP9MHT+GLdqcgZK5AiBmzlg2os1366qXKVcQlnDk4JdYYrnROOe5Sy2X4NZVgweQrs5LGeNMPwrv8/9f4U0UI7nyceUS39HZ6pA7+XALE0/zSb90fv+KxfUmpme0YPQeuQrPeuVfI61ZaGeJM97fGAA/SZn+rC4m0cvg6C0lUtesgR/EQkCsDqHidnogKC/o+r6wpScV0HDwk2GrA1yn+zaL2Xc7m9py2DDfF9tBZfERXRPetcpYXqwXCxeV7y22lYa4UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkwDgQcNvE9UkGiRuGgnKgAIS4K7kLAxiI7Z7Wg7YaY=; b=34B69AbRgoSes/U8YltA7jp1SIRw84uuhNt7TRQZNULohAXDZZhsPhgLOiVTgnRk+J/lfOOIctNDhuCdHAaPGqQfAc3uPDMpNjcUypQ3tyfJV2gzFGg9cZP7f0PTD/hRhQXzyre6jKZVAHVEzs9NDOUJMKcbR6jeo+riXyEmy8o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v5 15/17] tools/libs/ctrl: Implement new xc interfaces for dt overlay Date: Tue, 11 Apr 2023 12:16:16 -0700 Message-ID: <20230411191636.26926-16-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT085:EE_|IA1PR12MB6529:EE_ X-MS-Office365-Filtering-Correlation-Id: 79fb94b7-2e1f-4cd8-dde2-08db3ac15800 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: osc+4KnrjY/eXHRp/c21nvn18/PBqzgrfrXWovfYXG3QrplR0MgbJ72hALFCiEcxPhk3QCSjzTFO0dTXS6yY9bt/J8GQaZ3WYGZnBX2YGioCcALoBjUowaD5pS+r/sLI+L2YN/4s9DHwAJKZFS2+nLiYjL1EMqTc6AHTqNHVpeHyOcIaMNldU5M5EzDaASxUhO3oCEUMTi96Ba4RbWsjp3sMkNFeeKj7mdIpNg39NVoQtJJrexrczJ3CXJ4N5k3KSt8jbO0kW511tYq5p+Ahe7LLGnRU0SMi7baInhIHt0mb5n2gFKkRFvd0ht9LB96tkW4dWRFp3QKStHnhBh7nZG/l8PXpbqpgzp4viFw2WKasPQ5v0VkIlSn0xAafRSR/qj3De+tPh/fTVyxfhRntQdkTvcpxMSsXaIHjID7Nyxx24+li9JVuGCxeXyewaEMKOsrFzaQ4y+oj7CslTKxiL9D0SR+uWSi/EfyxI8TfNgnalPhnHrEZzPQOsBKxFrh0eaXeS/MW13vx6/MePibxA9oju6iZnUa+Hc80Zf2Dr5VbNvLe7Tl+P13UgrnjzYNyI9vQS+oO0EdP89r4GuGuwIdysUR9FW1yxvmTteTro8D60MVMkOZyS/XwStAp5xf8DPld7jEQcQpzt8I5BHTNI+rEq3SpHSmv7VEwN27rRCI+IUMoActsf1te3hUn69CJxWUpjJw0GHVSd/eNq7wywPqJvAYdGBddDOaD8uiSerCTHaw/TBAANLwczdGUStdu X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(70206006)(4326008)(478600001)(8676002)(54906003)(41300700001)(316002)(70586007)(6916009)(86362001)(36756003)(47076005)(2616005)(336012)(26005)(1076003)(426003)(6666004)(5660300002)(44832011)(2906002)(82310400005)(40480700001)(8936002)(356005)(82740400003)(186003)(81166007)(36860700001)(2004002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:08.1201 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79fb94b7-2e1f-4cd8-dde2-08db3ac15800 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6529 xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and overlay operation type i.e. add or remove to xen. Signed-off-by: Vikram Garhwal --- tools/include/xenctrl.h | 5 ++++ tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 48 +++++++++++++++++++++++++++++++++ 3 files changed, 54 insertions(+) create mode 100644 tools/libs/ctrl/xc_dt_overlay.c diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 05967ecc92..b932589c8d 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2637,6 +2637,11 @@ int xc_livepatch_replace(xc_interface *xch, char *name, uint32_t timeout, uint32 int xc_domain_cacheflush(xc_interface *xch, uint32_t domid, xen_pfn_t start_pfn, xen_pfn_t nr_pfns); +#if defined(__arm__) || defined(__aarch64__) +int xc_dt_overlay(xc_interface *xch, void *overlay_fdt, + uint32_t overlay_fdt_size, uint8_t overlay_op); +#endif + /* Compat shims */ #include "xenctrl_compat.h" diff --git a/tools/libs/ctrl/Makefile.common b/tools/libs/ctrl/Makefile.common index 0a09c28fd3..247afbe5f9 100644 --- a/tools/libs/ctrl/Makefile.common +++ b/tools/libs/ctrl/Makefile.common @@ -24,6 +24,7 @@ OBJS-y += xc_hcall_buf.o OBJS-y += xc_foreign_memory.o OBJS-y += xc_kexec.o OBJS-y += xc_resource.o +OBJS-$(CONFIG_ARM) += xc_dt_overlay.o OBJS-$(CONFIG_X86) += xc_psr.o OBJS-$(CONFIG_X86) += xc_pagetab.o OBJS-$(CONFIG_Linux) += xc_linux.o diff --git a/tools/libs/ctrl/xc_dt_overlay.c b/tools/libs/ctrl/xc_dt_overlay.c new file mode 100644 index 0000000000..202fc906f4 --- /dev/null +++ b/tools/libs/ctrl/xc_dt_overlay.c @@ -0,0 +1,48 @@ +/* + * + * Device Tree Overlay functions. + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + */ + +#include "xc_private.h" + +int xc_dt_overlay(xc_interface *xch, void *overlay_fdt, + uint32_t overlay_fdt_size, uint8_t overlay_op) +{ + int err; + DECLARE_SYSCTL; + + DECLARE_HYPERCALL_BOUNCE(overlay_fdt, overlay_fdt_size, + XC_HYPERCALL_BUFFER_BOUNCE_IN); + + if ( (err = xc_hypercall_bounce_pre(xch, overlay_fdt)) ) + goto err; + + sysctl.cmd = XEN_SYSCTL_dt_overlay; + sysctl.u.dt_overlay.overlay_op = overlay_op; + sysctl.u.dt_overlay.overlay_fdt_size = overlay_fdt_size; + + set_xen_guest_handle(sysctl.u.dt_overlay.overlay_fdt, overlay_fdt); + + if ( (err = do_sysctl(xch, &sysctl)) != 0 ) + PERROR("%s failed", __func__); + +err: + xc_hypercall_bounce_post(xch, overlay_fdt); + + return err; +} -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:17:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:17:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519784.806859 (Exim 4.92) (envelope-from ) id 1pmJUX-0008Ei-R9; Tue, 11 Apr 2023 19:17:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519784.806859; Tue, 11 Apr 2023 19:17:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUW-00089U-B1; Tue, 11 Apr 2023 19:17:20 +0000 Received: by outflank-mailman (input) for mailman id 519784; Tue, 11 Apr 2023 19:17:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUT-0004DR-4C for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:17 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2062a.outbound.protection.outlook.com [2a01:111:f400:7eb2::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 771c4613-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:15 +0200 (CEST) Received: from BN9P221CA0007.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::26) by SA1PR12MB7104.namprd12.prod.outlook.com (2603:10b6:806:29e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:17:11 +0000 Received: from BN8NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::b5) by BN9P221CA0007.outlook.office365.com (2603:10b6:408:10a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT113.mail.protection.outlook.com (10.13.176.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:11 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:10 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:10 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 771c4613-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZCntpfDjlU7bvxwIp3bh4NQamhz8bpTDYo97gW0u+wMi4TyyzH24dA9vddIIPPPpGW+cmmXSixmLW4zjPrg/NPvfYyBrIuXJ4X+1d/Qu7HCDYvAGUWg0Hn6Hn/3/I3Du/SW4/Gz4Abm6XcoxgvuBA4qDNhEAAIgtyaKHkWMQ7niTiME8PeanhQvZKk4x9jZ5ogm7SQYyEWkpjWbxV/YAgRaIqkRVZ9+ZBgYbSayN33edDezxvJ7kHwWqGEu9WKYUcyf49eaF79C0Tr37lvbY/jlEjG5VlawA/YUe9MD0JNz5hu62XBbhyCHsfH/OJbglHeiO8jzx7fBaW78RJL2+Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2clB4UixcJGvwOZJ+XN0wD+kcnhi2QU+8ofkZ5Co48=; b=O9v0T+PyvauZzj/zb0BDPvK1AvsUjiy2Dz9Krp5DhRXqIBlwkRFYiyY8BcfRR+03rMFtVdmu56h3h56eiVquwNwVj6713IzFpnWcdkJ5Y+VlMgIKk4MIgwxGaqlQjcgb9fPDv9qkV1riewcBw+41QvJaCYI1aH+HYwTC0/ExJS+ehe5ywTsgY5fefTdnmb4me0WuD5tP3OyJwKf5Y42wKjvc/83dg1W5zj4KPf+LoBOloV1+F1xhwLOp0yhTyn8fOqCyerPsC0wmmDvh9jDCL3IWHUFtBWfp+7dZ0UH9iH5qR6hAmSc7gYXQULmKZE9V+qhyrfYhlrrjem2y0s642g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z2clB4UixcJGvwOZJ+XN0wD+kcnhi2QU+8ofkZ5Co48=; b=ThtM+MEUeVsRifpSzpg6l+6DHWGYRGYDH4jmJf5iAiBLQgXjj+inCmV1xKq7LBTQOGjbBMUITDSe6XVcGfge7MqfgphuprtLS6pCPNR9EZ5IKEnSBACZ16KGOCmexvC04LZr+imaKF5Rn9i4sEK+JFqzwa2XPLa92X9dUWZRe1s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 01/17] xen/arm/device: Remove __init from function type Date: Tue, 11 Apr 2023 12:16:20 -0700 Message-ID: <20230411191636.26926-20-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT113:EE_|SA1PR12MB7104:EE_ X-MS-Office365-Filtering-Correlation-Id: 197fc178-d1c0-4c52-5cbb-08db3ac159dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q19Ab48E2BZeSHFpac25Yyrbd44cGvHmrkZcuJb1ggFsQuJyAmUF0Mfoz9A1OkKNuv3VLwy17kDisYJXBkp83av5cqnmHMCmGG0QLlueGm3YuCzXclIw5ncEXT6NRV0emnt3d/eqZ0E7qTokPVv7SzNahC1kFqx1gtEFsldwlVwpnGSTpkcmIwuxEE3M1TqMN7j9bCEl04I59de8LwUAp1bEjSz7nE9vm19mn9NyOuKJjLOxqiyowWp7jsCf2ukSVXUo+0cMkPgECL/Zkl0SpY2FYrH39zAxiO6nc7DJ1XZBfiVJIk/aG4qOoN57L7G78oKEsqeAHnWg1pBa4YsQDP2w1UWM9Hn9pAcVY63MnC/mzTcj2wgHhL5qRRPSlE/nFX7ISU0EeWrA6GUhSHE2NeXdnCMcXSPmqy9XypkVJPkFUR04KZD7x/SPgpNsY4M1RLMrrexW4HAoQPnT5gq6N3m4uH1xWRVwjLD8xKQycbw9zMuav0oQNxLKFf4OKJOjWKADUw/ELFvcd5WDXGWk+dCOE3EpDr1q4cgSASZEJGqMJh5z1FaSsONuCfd413w0DEX3/ExXhN579c4QoF9SH5jG1+e5NedsBz2abSlQoH7d44tYGOdJQOG5w3D2+reHs3TuS6unsPFXmSxkTzWnBgOgMmy1tyFfb+8/lpyy3VFYVd822KVxOBv3XJRHszY1tPuCpwZDJEEHcQ+4yfbz/vb6PGocrGp09G20EHEKjDM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(4326008)(70206006)(70586007)(1076003)(86362001)(26005)(316002)(6916009)(186003)(40460700003)(36756003)(6666004)(54906003)(47076005)(40480700001)(478600001)(36860700001)(8676002)(8936002)(2616005)(41300700001)(356005)(81166007)(5660300002)(2906002)(30864003)(83380400001)(44832011)(82310400005)(426003)(336012)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:11.3366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 197fc178-d1c0-4c52-5cbb-08db3ac159dd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7104 Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupt() 3. map_range_to_domain() 4. unflatten_dt_node() 5. unflatten_device_tree() Move map_irq_to_domain() prototype from domain_build.h to setup.h. To avoid the breaking the build, following changes are also done: 1. Move map_irq_to_domain(), handle_device_interrupt() and map_range_to_domain() to device.c. After removing __init type, these functions are not specific to domain building, so moving them out of domain_build.c to device.c. 2. Remove static type from handle_device_interrupt(). Overall, these changes are done to support the dynamic programming of a nodes where an overlay node will be added to fdt and unflattened node will be added to dt_host. Furthermore, IRQ and mmio mapping will be done for the added node. Signed-off-by: Vikram Garhwal --- xen/arch/arm/device.c | 145 ++++++++++++++++++++++++ xen/arch/arm/domain_build.c | 142 ----------------------- xen/arch/arm/include/asm/domain_build.h | 2 - xen/arch/arm/include/asm/setup.h | 6 + xen/common/device_tree.c | 16 +-- 5 files changed, 159 insertions(+), 152 deletions(-) diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c index ca8539dee5..fec6e29c42 100644 --- a/xen/arch/arm/device.c +++ b/xen/arch/arm/device.c @@ -12,6 +12,9 @@ #include #include #include +#include +#include +#include extern const struct device_desc _sdevice[], _edevice[]; extern const struct acpi_device_desc _asdevice[], _aedevice[]; @@ -75,6 +78,148 @@ enum device_class device_get_class(const struct dt_device_node *dev) return DEVICE_UNKNOWN; } +int map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname) +{ + int res; + + res = irq_permit_access(d, irq); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", + d->domain_id, irq); + return res; + } + + if ( need_mapping ) + { + /* + * Checking the return of vgic_reserve_virq is not + * necessary. It should not fail except when we try to map + * the IRQ twice. This can legitimately happen if the IRQ is shared + */ + vgic_reserve_virq(d, irq); + + res = route_irq_to_guest(d, irq, irq, devname); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", + irq, d->domain_id); + return res; + } + } + + dt_dprintk(" - IRQ: %u\n", irq); + return 0; +} + +int map_range_to_domain(const struct dt_device_node *dev, + u64 addr, u64 len, void *data) +{ + struct map_range_data *mr_data = data; + struct domain *d = mr_data->d; + int res; + + /* + * reserved-memory regions are RAM carved out for a special purpose. + * They are not MMIO and therefore a domain should not be able to + * manage them via the IOMEM interface. + */ + if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", + strlen("/reserved-memory/")) != 0 ) + { + res = iomem_permit_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); + return res; + } + } + + if ( !mr_data->skip_mapping ) + { + res = map_regions_p2mt(d, + gaddr_to_gfn(addr), + PFN_UP(len), + maddr_to_mfn(addr), + mr_data->p2mt); + + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map 0x%"PRIx64 + " - 0x%"PRIx64" in domain %d\n", + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, + d->domain_id); + return res; + } + } + + dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", + addr, addr + len, mr_data->p2mt); + + return 0; +} + +/* + * handle_device_interrupts retrieves the interrupts configuration from + * a device tree node and maps those interrupts to the target domain. + * + * Returns: + * < 0 error + * 0 success + */ +int handle_device_interrupts(struct domain *d, + struct dt_device_node *dev, + bool need_mapping) +{ + unsigned int i, nirq; + int res; + struct dt_raw_irq rirq; + + nirq = dt_number_of_irq(dev); + + /* Give permission and map IRQs */ + for ( i = 0; i < nirq; i++ ) + { + res = dt_device_get_raw_irq(dev, i, &rirq); + if ( res ) + { + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + /* + * Don't map IRQ that have no physical meaning + * ie: IRQ whose controller is not the GIC + */ + if ( rirq.controller != dt_interrupt_controller ) + { + dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", + i, dt_node_full_name(rirq.controller)); + continue; + } + + res = platform_get_irq(dev, i); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to get irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); + if ( res ) + return res; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4f9d4f9d88..6ab18c53ab 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2256,41 +2256,6 @@ int __init make_chosen_node(const struct kernel_info *kinfo) return res; } -int __init map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname) -{ - int res; - - res = irq_permit_access(d, irq); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", - d->domain_id, irq); - return res; - } - - if ( need_mapping ) - { - /* - * Checking the return of vgic_reserve_virq is not - * necessary. It should not fail except when we try to map - * the IRQ twice. This can legitimately happen if the IRQ is shared - */ - vgic_reserve_virq(d, irq); - - res = route_irq_to_guest(d, irq, irq, devname); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", - irq, d->domain_id); - return res; - } - } - - dt_dprintk(" - IRQ: %u\n", irq); - return 0; -} - static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, const struct dt_irq *dt_irq, void *data) @@ -2322,57 +2287,6 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, return 0; } -int __init map_range_to_domain(const struct dt_device_node *dev, - u64 addr, u64 len, void *data) -{ - struct map_range_data *mr_data = data; - struct domain *d = mr_data->d; - int res; - - /* - * reserved-memory regions are RAM carved out for a special purpose. - * They are not MMIO and therefore a domain should not be able to - * manage them via the IOMEM interface. - */ - if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", - strlen("/reserved-memory/")) != 0 ) - { - res = iomem_permit_access(d, paddr_to_pfn(addr), - paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIx64" - 0x%"PRIx64"\n", - d->domain_id, - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); - return res; - } - } - - if ( !mr_data->skip_mapping ) - { - res = map_regions_p2mt(d, - gaddr_to_gfn(addr), - PFN_UP(len), - maddr_to_mfn(addr), - mr_data->p2mt); - - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map 0x%"PRIx64 - " - 0x%"PRIx64" in domain %d\n", - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, - d->domain_id); - return res; - } - } - - dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", - addr, addr + len, mr_data->p2mt); - - return 0; -} - /* * For a node which describes a discoverable bus (such as a PCI bus) * then we may need to perform additional mappings in order to make @@ -2400,62 +2314,6 @@ static int __init map_device_children(const struct dt_device_node *dev, return 0; } -/* - * handle_device_interrupts retrieves the interrupts configuration from - * a device tree node and maps those interrupts to the target domain. - * - * Returns: - * < 0 error - * 0 success - */ -static int __init handle_device_interrupts(struct domain *d, - struct dt_device_node *dev, - bool need_mapping) -{ - unsigned int i, nirq; - int res; - struct dt_raw_irq rirq; - - nirq = dt_number_of_irq(dev); - - /* Give permission and map IRQs */ - for ( i = 0; i < nirq; i++ ) - { - res = dt_device_get_raw_irq(dev, i, &rirq); - if ( res ) - { - printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - /* - * Don't map IRQ that have no physical meaning - * ie: IRQ whose controller is not the GIC - */ - if ( rirq.controller != dt_interrupt_controller ) - { - dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", - i, dt_node_full_name(rirq.controller)); - continue; - } - - res = platform_get_irq(dev, i); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to get irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); - if ( res ) - return res; - } - - return 0; -} - /* * For a given device node: * - Give permission to the guest to manage IRQ and MMIO range diff --git a/xen/arch/arm/include/asm/domain_build.h b/xen/arch/arm/include/asm/domain_build.h index 34ceddc995..b9329c9ee0 100644 --- a/xen/arch/arm/include/asm/domain_build.h +++ b/xen/arch/arm/include/asm/domain_build.h @@ -4,8 +4,6 @@ #include #include -int map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname); int make_chosen_node(const struct kernel_info *kinfo); void evtchn_allocate(struct domain *d); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..1d636e8a4a 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -163,9 +163,15 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells, u32 device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt); +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, + bool need_mapping); + int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len, void *data); +int map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname); + extern const char __ro_after_init_start[], __ro_after_init_end[]; struct init_info diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7b..aed38ff63c 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -1811,12 +1811,12 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, * @allnextpp: pointer to ->allnext from last allocated device_node * @fpsize: Size of the node path up at the current depth. */ -static unsigned long __init unflatten_dt_node(const void *fdt, - unsigned long mem, - unsigned long *p, - struct dt_device_node *dad, - struct dt_device_node ***allnextpp, - unsigned long fpsize) +static unsigned long unflatten_dt_node(const void *fdt, + unsigned long mem, + unsigned long *p, + struct dt_device_node *dad, + struct dt_device_node ***allnextpp, + unsigned long fpsize) { struct dt_device_node *np; struct dt_property *pp, **prev_pp = NULL; @@ -2056,8 +2056,8 @@ static unsigned long __init unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static void __init __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +static void __unflatten_device_tree(const void *fdt, + struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519806.806890 (Exim 4.92) (envelope-from ) id 1pmJWB-0005cQ-Pa; Tue, 11 Apr 2023 19:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519806.806890; Tue, 11 Apr 2023 19:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWB-0005cJ-Kw; Tue, 11 Apr 2023 19:19:03 +0000 Received: by outflank-mailman (input) for mailman id 519806; Tue, 11 Apr 2023 19:19:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUW-0004Ta-0r for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:20 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20611.outbound.protection.outlook.com [2a01:111:f400:7e8b::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78375fb9-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:16 +0200 (CEST) Received: from BN9PR03CA0142.namprd03.prod.outlook.com (2603:10b6:408:fe::27) by MW4PR12MB7166.namprd12.prod.outlook.com (2603:10b6:303:224::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Tue, 11 Apr 2023 19:17:13 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::68) by BN9PR03CA0142.outlook.office365.com (2603:10b6:408:fe::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:13 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.22 via Frontend Transport; Tue, 11 Apr 2023 19:17:13 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:12 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:11 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78375fb9-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2ZtciHNQZJ1CW8HGjWQBQaYU9j7azTGq6d429aQHdzUVfNY+HEgTexkd1sVJO95biDcrw3hgcE8H0Nhfj6TVvlcjMKaZcfDuC/c9XeHnS9V6r9rSmjMYVn3FEsNiW1LtemPqHGo5qL25K31njuz1We61WKQV2YKzT+gP6pozm0ir/rloUptHimg11gAPZEhFFsHc+nx+vEEXyNLoujb5SteJ374nbnXx8ini/09XWbtmfiystSKJZmvIykJr3Rs+uqbEChCRx4bFKC9flyn2KIoTFOSeDWvCzM2mVwkBLUcHfeusV4036wQatGP8EOvvN/VmDXJw9KT8Zwq5O5V2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5jE5w9tUBXYNb4GkaW66AGdvE8156w4aHYPgYkE7PU=; b=YxFnbaNOWzAlnzIFiw5613yOUxX5R0jVPGMcq9tgF0BRy+RgiKllDzuhPiGZi4U/anDvOkAhTzSxfD32QfPw4G5qPtW0FMVYC6cLJXEYYBtqLhxaar+tvmo1OSPE11OsG1AC6NzIT/IZ8H72vJ/Dr3IQJ1BtAsnbw3q2jN5KnREaiSATqwdksWmYNidCxWdfIwd+2sry/2/Lw24edOu8VlR8AVk/1JZJbnXZIXfJLAvODKVdsolt14jiPzYuPgOjMmqdEonYpHHT+lkiovERI2trJrfi+11dpHvgsbzW7tWEcbXGzQoNmKnDllw7C86cqYxNHsQjlLPs0WPYuFrUew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5jE5w9tUBXYNb4GkaW66AGdvE8156w4aHYPgYkE7PU=; b=JQ/hU2P8vnyDzTVBSxNElxt8ZK5IT7TJQ8XEi+uUvWOa4YWebyhtS7WVkuVhxIIX8e3Dhu+yBATcGbf7wjzBLwILdKKGViPVecu7FoMITWx/tdHMCZz8NVhjbni0K1Nid5jHmBpNw7nTztLWeeA7mXUiK6oVmWGAoeWIeEJHmaM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 03/17] xen/arm: Add CONFIG_OVERLAY_DTB Date: Tue, 11 Apr 2023 12:16:22 -0700 Message-ID: <20230411191636.26926-22-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|MW4PR12MB7166:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d21aa73-be46-49f3-61ab-08db3ac15aec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Ye5PZBaC4XZ9/w0ud9o+0cmn0rwEgLvLYNNpTFIOK1wvfkPHxko6LLG21O64/yuJ4XkFLLeJfgt07VWzZQ6JKyRwMV7YuL3ktryLnBiE5FbYWIA7nwElkY1UInIzC79O/6u/lKjWh8ae0Wl/YfBxRZ21t7APPccxvQJtL3b/kmbb2ZZEaNKP4TqZWcAIBEr+SUmZoRwFsAJZlY0sBjtdXR6SyXy7+A/BOiLmp+Ns3yYGXCxFgZ7SSbDIHVWxBS+gADFTtSP6IER7T6efdjCTiEmp5n2I3tCyZHGEdVphRHLZOqHuxM8PSDxE7aCaIOdjHhU3J0SDgNHSYN1u2uTeJNYYIdAXidar1rYAm1afauzkt34f7P7JagqmOLb23Ja0TKBHTZAReO9KhQfeHojhCjSr/YMWcVW7KHcbSiP4Ow4sbvKdO1RNWgUxmBl4xHWZrq+YQkPHZG36AO5bDuRBU3RTIQZgw71y0j9xIXjZ+CYlEIvpopbvkwurva+eKQoDtyJDbCHXvLPrX9wtJhv0AcDJWXM8B6ckzwg5rfgL9tX2ZlkZUuYxPpkUCnDlz+sxYQNy+OznMRmAlNwAzmgCRHeI6hNoH4l8jygKzfZCXmRvd8L9MrxbyG0abRgdFOT1JnQGMwv495pWlcqa63M4JWnGw49JDeL5fSLeLIWIzaaWbcCC1qUzZO0lgbhfbcImPt6/qXunohb3VRLPLFamNJ3L0x8obJ4/8DUowVr41s= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199021)(36840700001)(40470700004)(46966006)(186003)(8936002)(1076003)(26005)(40460700003)(478600001)(82310400005)(36860700001)(316002)(70206006)(54906003)(40480700001)(4326008)(6916009)(81166007)(6666004)(36756003)(86362001)(356005)(8676002)(70586007)(82740400003)(41300700001)(44832011)(2616005)(2906002)(47076005)(426003)(336012)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:13.1128 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d21aa73-be46-49f3-61ab-08db3ac15aec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7166 Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Signed-off-by: Vikram Garhwal --- SUPPORT.md | 6 ++++++ xen/arch/arm/Kconfig | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index aa1940e55f..0a31f40af4 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -822,6 +822,12 @@ No support for QEMU backends in a 16K or 64K domain. Status: Supported +### Device Tree Overlays + +Add/Remove device tree nodes using a device tree overlay binary(.dtbo). + + Status: Supported for ARM + ### ARM: Guest ACPI support Status: Supported diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..1fe3d698a5 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -53,6 +53,11 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config OVERLAY_DTB + bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED + help + Dynamic addition/removal of Xen device tree nodes using a dtbo. + config HVM def_bool y -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519812.806899 (Exim 4.92) (envelope-from ) id 1pmJWI-0005v8-12; Tue, 11 Apr 2023 19:19:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519812.806899; Tue, 11 Apr 2023 19:19:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWH-0005v1-U5; Tue, 11 Apr 2023 19:19:09 +0000 Received: by outflank-mailman (input) for mailman id 519812; Tue, 11 Apr 2023 19:19:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUX-0004Ta-0y for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:21 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20629.outbound.protection.outlook.com [2a01:111:f400:7e8d::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 799897a0-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:19 +0200 (CEST) Received: from MW4PR03CA0203.namprd03.prod.outlook.com (2603:10b6:303:b8::28) by BY5PR12MB4209.namprd12.prod.outlook.com (2603:10b6:a03:20d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:15 +0000 Received: from CO1NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::c5) by MW4PR03CA0203.outlook.office365.com (2603:10b6:303:b8::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:15 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT096.mail.protection.outlook.com (10.13.175.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:14 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:13 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 799897a0-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXpPdrD59NHcZced6N+ReY2rzQPGHtm40Xv7ICsxIt/xl5azaRgbg/FpXDbBbgSewjJItDYzLHIs+vPw639QRQa7qwZH5zrduXWD9kv8CFmN8FKuRSH2JI9fBoSNFQjipdW6hobv15IL6dNzc4fAi+/pkD2phxqPTUkk+cL1b07NMwx3LkrgEZzfVRB041phzXLdlD0aq0pTOYaLhL1/dxxJwFvsA6R0gI6oXRThSiq2OovUzCLI0T4rPXDjmWhztfRLeVKHHDIzTttnJ6E3nEZtplNw5FpKxiJwi1W0BA2eMXUoxhPTMuHwgqLEqS6vaF9YVZDLmzu2PCq8DcBiMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+aOH8wbfxJ3CDB9n8z4otIPVVDXaY3ZnHxlpPeTlbO8=; b=cksZoW0ks3716PsidDanbIitYQa+dR1UVj/3ZfkfzDYwBV4HM0p5HaJDaiJqjrwy0bWn7nx/Nj6IDIjqwMHEkw6PJVeyPnNpLs5kYAXMa4TxEVDe2C3mRj1IRSpGvprN3FJr26Kqy3IKvA51h3MLFZorE7J3CJ3DsOc+NOZ7GTklZciqfOUfZHF6RD40qsP7ijZncH4Z0dxPPiFf7rOaP7j/mis5HABhIf6WwiXpRFDWklw/SsdbeH2e1m0QVNH4y4mzzTG5a746gRPQKahAhxgNODv13BxfDsWfW+yG3EXtFKSwUN+DskgWMPoJLgDXrhriCkLT0fURLXudLW8psw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aOH8wbfxJ3CDB9n8z4otIPVVDXaY3ZnHxlpPeTlbO8=; b=C8LnUlJK8/O5qvHp1MAOesiGzHauPP4chRPeau8EzNQHbWxjGd1E++r0vWFVvMOhDGikzO9d8m3aAWft9gjihUuvmmSU6xIL1/S78nTyco3qOZccbzYNHX2eoGMx9gyTdDz6XzcmGKhz+yyGfhMkjCaBQ735nslsas2Mn29N7io= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 04/17] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. Date: Tue, 11 Apr 2023 12:16:23 -0700 Message-ID: <20230411191636.26926-23-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT096:EE_|BY5PR12MB4209:EE_ X-MS-Office365-Filtering-Correlation-Id: 778a1185-cf2d-464a-ab52-08db3ac15ba7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3+4G1HcuhJ+RiYvsVU7dkqReSPNLwMFDbQ/azTNjZysqNxtVxfff/YnYzEUt2wAkHB2yvZUfBol6uUCA4r0dblCaMB7aZcUX6OXNqj8fJ23o/K4lN4fYhO6BIh1VqCx9vJKsEmiQb+qYais8rHA0bggCJUVGcLbT5DroM5n7GRQhzx5yy3b09oKhcxmMgz80BjWkgo/1CfMPyJLEhwRC06Ayko9Rewr+r9Sfn317zCyy9tW0ia+3Sz2FyfDm57eL/7Tp8cZ2F+Pm11bL+AaKmrRIFgGTwyQlFeOMQOMVe6KEptapev+8/nihgkdFIRsC1EA3F82tXmJMt+jx6HsZXjSe1H7Jjo53Bw7nIu4yjp73lNm2x/lAARgP2o84IkduqpNNbvAOYDTc776rZToKOlZ3bMBuBrh8Wyzrmo34dnLD6J4jPG/HlKyhlnepVkCa51bOJ0GyWMKgjKjwj3xvQC8eH8BylFZMRL7MJLdVDb/b1rjNS2PP0zOZx1gpqPTo9EWrfEmR6QsoOSxoP3lIJFXmtjFhgd3Cz89gCybOFi3x93wPXGWFdV9olZjnviDD6iyTgvvgVeIh8uh4X/y3QD5dl6VwhV2W1+l69rIbCfmvPxveBsK0yHK0V64w6goLA8KgbGF+Fk4H1TgymT2xbnDR7GeIWhIJMk5YU8ihtkIJVRkWv/xmXEyN9yKt3BUr2IjGzAGzG9S7/v2awZJhCoA4NvTOQFaIqbDvKGVB6rA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199021)(36840700001)(46966006)(40470700004)(36756003)(86362001)(70586007)(41300700001)(70206006)(316002)(54906003)(478600001)(6916009)(6666004)(4326008)(40480700001)(83380400001)(82310400005)(4744005)(44832011)(8936002)(8676002)(2906002)(36860700001)(5660300002)(82740400003)(186003)(356005)(81166007)(1076003)(26005)(47076005)(336012)(2616005)(426003)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:14.2308 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 778a1185-cf2d-464a-ab52-08db3ac15ba7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4209 This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal Acked-by: Julien Grall --- xen/common/libfdt/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile index 75aaefa2e3..d50487aa6e 100644 --- a/xen/common/libfdt/Makefile +++ b/xen/common/libfdt/Makefile @@ -1,7 +1,11 @@ include $(src)/Makefile.libfdt SECTIONS := text data $(SPECIAL_DATA_SECTIONS) + +# For CONFIG_OVERLAY_DTB, libfdt functionalities will be needed during runtime. +ifneq ($(CONFIG_OVERLAY_DTB),y) OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) +endif obj-y += libfdt.o nocov-y += libfdt.o -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519813.806904 (Exim 4.92) (envelope-from ) id 1pmJWI-0005xm-AO; Tue, 11 Apr 2023 19:19:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519813.806904; Tue, 11 Apr 2023 19:19:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWI-0005x2-6M; Tue, 11 Apr 2023 19:19:10 +0000 Received: by outflank-mailman (input) for mailman id 519813; Tue, 11 Apr 2023 19:19:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUf-0004DR-BP for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:29 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20616.outbound.protection.outlook.com [2a01:111:f400:7eab::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e5a69a4-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:26 +0200 (CEST) Received: from BN8PR04CA0032.namprd04.prod.outlook.com (2603:10b6:408:70::45) by BY1PR12MB8446.namprd12.prod.outlook.com (2603:10b6:a03:52d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:18 +0000 Received: from BN8NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::84) by BN8PR04CA0032.outlook.office365.com (2603:10b6:408:70::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:18 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT010.mail.protection.outlook.com (10.13.177.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:18 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:17 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:17 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e5a69a4-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F51bULKW9b+g2uxlrVXvYKaoRY/BibCkb2SPb5ObheoJoI53wTk2aDI9+YohJii69KmGma19PCO3tW4tMnTXwVRBluuokfqiZBvHbDix5pAxbJkCPdGIZks3izhxcCg/FRDhnDNJ3UXX/IOp/0QeQ3BXuKu/SZr5c/FTmVDulC6JFE3uw6eUf7SOgl7lQpI/HoxiwWGC6RHH2eBjYOLKf1bYGiBhb3Fh6EJvskGhjE56TCzyHpQFn6ti2rK4E/vW7JD/RPalmCsxNhe8kw6+k7G/itVKHq8vFCxCqUMXg8eOk7jPmHah208vRKPqp4AoWBNBSnT/oWo9SYFr8TIcJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qd0QFdZvzHUGWrw0BfIrEu3cWkp8jWSV4vPT9FURuHE=; b=GVHkLjWTfBaR1e9+F+dbVMwK2uPs8b88ZM46uVIzIjudv3ZNg96WWLSa45UoP0/uNAJuubbd04wbbqWC6cwzCsQOBwsVxaMBD51h4I2wWjJAca+nC56si7I1vHpQCn2CLfRof8p9kzafAbAKIl2fh6trQu5fSolcjQmEgVIIVwVK8CfDMLkLaRDZE9ooGA/Nziwh5MSwBbJes2JFzfHHstxsIuTrLDLAh99xsCijJiRte6+1KsyBLwCx3tTzppZz7Ki7Q+PzcUF7dmzdCnBAWBXsO4FfKq+pdP2F2FoZh/KFFM7eemF3P6yTRltC+HwNwejPVGZSSpkdSRy0XDiYIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qd0QFdZvzHUGWrw0BfIrEu3cWkp8jWSV4vPT9FURuHE=; b=UeV9rIjPsBcg+PwgcsDBTnzu7kPN8nOMhtQyadhmsSoW+nUgdraiApOXwmBYNc5z+TyS1KVrqcIj6Cw4BABNtfalpWqlmSOPwib3dFZ/lfKYtoGlgu2/tHWkNtX4WKoNmaUoLhzGDoycrB0cG3HCUXiHeQoyuq4WuEQ7pAphK6s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 09/17] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Date: Tue, 11 Apr 2023 12:16:28 -0700 Message-ID: <20230411191636.26926-28-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT010:EE_|BY1PR12MB8446:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ccc8d77-ac1a-43f3-f466-08db3ac15dfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 87wQgUV/Rs/rhMoHDyAXQevmpXRLXB2USDKIB2K94zIe7mzQF4qIHmhhubJj04rWW2nT2FatrLn3Kt8TGmgFjqK8f+qmX2eM0pKIu79MzkElNpmXfWbrUaoiCeOaVjOVtpMTxwVQ/TVBMRz9BCMSQNuQD7Yggd5Mo+h21Ax/tfIZ+YiZBBX+9fdtphasJMnj3JRIzmTExGeWivt1ezYxPXs4F4xWL0+X5Yj9dWPCGKw+h3sHRw7bAPByNK58TZLfzTgYWIgW8luPcTV/oAwPC9JiFuoC777ounPNB5yFl5DJCz9C+JKqlYkaoedAk88jGQSLo8CW3pBpxb5am0CHJA80bu2hS4PZqD8NLGcxlKMCaJ+N0a5ddFyndjGV7vP5bWWVMGBJU8Hv25YMfG6TfRLhBGE0QnJkQfch2iPUPwmhw6Sn/hbNxmxJTrmk+636iDCuR22Iut9OGQHXPnzwZrKS7E3zemncGSI9VQ9Xs2DefUg0nQOVAKEM1MeuZ8yjZCO6OFasSOW47C3+i8oRpXXPQgLNzA3CxXZy5WpPWMC5y/2+lo0O6MVsOvvW2cLK61qnya3zCk204VPco9hwJ4jdelqsO1Dd7FvswYqso3rvOkQBKMVXIBwwf0X5IR0xnCtzvo8Uc+9JvpjbyurI9BjfqmKp6TrYNniNUyM0JMLWW3MpsYSijbeV0MgLrq2QriGdg3+sbqYIospL1ZsJLywJOiUaDKK+1yovMUWyhRw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(46966006)(40470700004)(36840700001)(82310400005)(82740400003)(356005)(54906003)(36860700001)(81166007)(70206006)(70586007)(8676002)(86362001)(6916009)(478600001)(4326008)(336012)(47076005)(426003)(186003)(2616005)(26005)(316002)(41300700001)(36756003)(2906002)(1076003)(83380400001)(44832011)(40460700003)(40480700001)(8936002)(6666004)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:18.2324 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ccc8d77-ac1a-43f3-f466-08db3ac15dfb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB8446 Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access add. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/device_tree.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index bb4cf7784d..457df333a0 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -146,6 +146,8 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( dev_iommu_fwspec_get(dev) ) return 0; + spin_lock(&dtdevs_lock); + /* * According to the Documentation/devicetree/bindings/iommu/iommu.txt * from Linux. @@ -158,7 +160,10 @@ int iommu_add_dt_device(struct dt_device_node *np) * these callback implemented. */ if ( !ops->add_device || !ops->dt_xlate ) - return -EINVAL; + { + rc = -EINVAL; + goto fail; + } if ( !dt_device_is_available(iommu_spec.np) ) break; @@ -189,6 +194,8 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( rc < 0 ) iommu_fwspec_free(dev); +fail: + spin_unlock(&dtdevs_lock); return rc; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519817.806920 (Exim 4.92) (envelope-from ) id 1pmJWL-0006Tw-Jp; Tue, 11 Apr 2023 19:19:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519817.806920; Tue, 11 Apr 2023 19:19:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWL-0006Td-FF; Tue, 11 Apr 2023 19:19:13 +0000 Received: by outflank-mailman (input) for mailman id 519817; Tue, 11 Apr 2023 19:19:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUe-0004DR-BM for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:28 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d49f6a6-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:25 +0200 (CEST) Received: from BN9PR03CA0582.namprd03.prod.outlook.com (2603:10b6:408:10d::17) by CH2PR12MB5020.namprd12.prod.outlook.com (2603:10b6:610:65::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Tue, 11 Apr 2023 19:17:21 +0000 Received: from BN8NAM11FT020.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10d:cafe::82) by BN9PR03CA0582.outlook.office365.com (2603:10b6:408:10d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:21 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT020.mail.protection.outlook.com (10.13.176.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:21 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:21 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:21 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:20 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d49f6a6-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ibWlJlAzJCwMexqfvCpGmZ6XhEB8FJ4xNsD0SrVfgFoEotE23Ikc6A04vt89teQXMdxung1NIw2OB3J1E2TG0a3GkcgUlQwtq/vRkcVfrah6AK4wbnGxM60PLseV0s2c+yhXJgO5639NUb5Fsag58ZU2NVSnu7d1Fvh2Sc2cbQWt5+axFB/n+Tuux5Zchjd5UvLpYz9l+9azgN0KrgVEzk8qkKLxzq7Oav6ibp7NRr96ImmUxP9bkkSIPfbx2q7imNaFiXlWFfz0RbG20pT+5N4aNCeBTMth+tl7C+VljWZNO2y174I6iw9NtHTTQDER+B21Zz0/E/2BOQBkDhpPkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vXy30MDq5H9lVjpDCmPPgeX6WY9DS2JY3kC1QKAn9No=; b=ZvkD6tuYNHXuUPhrT56khdRe6Ep7R8oju15YD7KJv4EX+T8pUzFXntKFluORwoLvkWGQ2plxbfo22vg3Pq6SFlGdREoKquhLhFtl9XSnfWREcnAnoO9voaEdEZP3eVsIMMvScgIUnqAwW6Oi5ct/pGE3AP/0F3fBB2C2yRlgyNr4bAr6vLE7oFgekcky2j7Er8Y3V8fYSZ1+1AjV+d0si7A5SQMrTvyPTcc45u2RdonItJj0ybJo8sl9tzlgzE9UQFdvQmZ2ORmomNUOZDxkb4wHj0pWGx9P6RALJOZwnwdrLc3bgkA8xJVQKFcg7Jd2OBCDqXlEVR6Y4ygc/lOzbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vXy30MDq5H9lVjpDCmPPgeX6WY9DS2JY3kC1QKAn9No=; b=CvONxjfIyVRzv3f+Pmw+eh0tckqwwueTCTaLxtMjD31wLOLT4FyuVH5CVvxOyFx9QA2/AAlfmiJMzQKWBrePSawrUDnhNeOgvaWCo2UE1zMR2LTeKWVbhebCFPgiq4WiQ4VUcLiIGu67hq1yV3GJ52XKHwxpwG44HkKZPISip7s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , "Jan Beulich" , Wei Liu Subject: [XEN][PATCH v5 13/17] xen/arm: Implement device tree node removal functionalities Date: Tue, 11 Apr 2023 12:16:32 -0700 Message-ID: <20230411191636.26926-32-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT020:EE_|CH2PR12MB5020:EE_ X-MS-Office365-Filtering-Correlation-Id: 6086e7bd-38a6-4ddc-2e3f-08db3ac16013 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5EE62jWduwEF8oWuL9B5C/JPyVk+v9e4sC11SOTrWWP4qxhUg/YVbv+PRzWrKGfCPvTY2ebYsCHKlRgYBxEeEgXxQILhwCj0OPERE8r52eSwUCLiTlPWXWeXqw4LyW7Sjnru5/hm2bY0ZW4DnUqbqXJndUY9VGXdwxgoJmtmXdfWnHX0d0vgoltkNFsRa+kC5qwwDkfpyINBZ6cXQ6qztXW/CuzreqH2RZTAk4UkecJ//4hzg9+jMxRWFVdQOfSLDlu1KjiNf7jCb4VPPHdKClS3GpPgCmyUFqB7QFdAHxNekab0fxJBjOw3tyIuTdT9//8GoYVW1wTPAlU+bwUcVQ79sAYukSB6vEqvbLspGDXSNODvvBbRFGoHa7+HLPTLowGoKB1lSCPNdeXwDhyMgedxMFHwqfTQb0b4QLwdingK5nbMCqBm6FyccgRFjTQ665yp7TJayFp9vQqE58lGLjWTttZKJFxaBWY//5moDHA1Bn0bUBem0TdLI7GknKTBJ5n1U3i0RWxPkCeSwO8qF1bm7/PUbECOuEqtWCMexCoYzszeCkEAkvsx8G1IpStAOiuUBlOA3Ml5JUJ2OnTdtaHBKniauYlb9RxURc0ndhHQ1VjXz1148hA+tRD6wTDnIC42ahHxEx4PGUSe1vkA5pBrNE+JNK7JQ12YTU04U0HcEtiFmCdauwN2rxRLlQcn7TPdXuhTFVIX1tdvi21Aiy/KVsnBgK30LF+YzTgI6BWGcQK5488luJvOtM8FPliibbSP4WQXKefS2HhseXVFXg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199021)(40470700004)(46966006)(36840700001)(1076003)(356005)(82740400003)(8936002)(8676002)(4326008)(86362001)(6666004)(5660300002)(6916009)(41300700001)(44832011)(40460700003)(82310400005)(36756003)(316002)(2906002)(30864003)(478600001)(54906003)(70586007)(70206006)(40480700001)(47076005)(83380400001)(26005)(81166007)(186003)(36860700001)(2616005)(336012)(426003)(403724002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:21.7557 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6086e7bd-38a6-4ddc-2e3f-08db3ac16013 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT020.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5020 Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes in dt_host and delete the device node entries from dt_host. The nodes get removed only if it is not used by any of dom0 or domio. Also, added overlay_track struct to keep the track of added node through device tree overlay. overlay_track has dt_host_new which is unflattened form of updated fdt and name of overlay nodes. When a node is removed, we also free the memory used by overlay_track for the particular overlay node. Nested overlay removal is supported in sequential manner only i.e. if overlay_child nests under overlay_parent, it is assumed that user first removes overlay_child and then removes overlay_parent. Signed-off-by: Vikram Garhwal --- xen/arch/arm/sysctl.c | 16 +- xen/common/Makefile | 1 + xen/common/dt_overlay.c | 415 +++++++++++++++++++++++++++++++++++ xen/include/public/sysctl.h | 24 ++ xen/include/xen/dt_overlay.h | 59 +++++ 5 files changed, 514 insertions(+), 1 deletion(-) create mode 100644 xen/common/dt_overlay.c create mode 100644 xen/include/xen/dt_overlay.h diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c index b0a78a8b10..672db61650 100644 --- a/xen/arch/arm/sysctl.c +++ b/xen/arch/arm/sysctl.c @@ -12,6 +12,7 @@ #include #include #include +#include void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { @@ -21,7 +22,20 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) long arch_do_sysctl(struct xen_sysctl *sysctl, XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) { - return -ENOSYS; + long ret = 0; + + switch ( sysctl->cmd ) + { + case XEN_SYSCTL_dt_overlay: + ret = dt_sysctl(&sysctl->u.dt_overlay); + break; + + default: + ret = -ENOSYS; + break; + } + + return ret; } /* diff --git a/xen/common/Makefile b/xen/common/Makefile index 46049eac35..be78c9a8c2 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o +obj-$(CONFIG_OVERLAY_DTB) += dt_overlay.o obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c new file mode 100644 index 0000000000..516e8010c5 --- /dev/null +++ b/xen/common/dt_overlay.c @@ -0,0 +1,415 @@ +/* + * SPDX-License-Identifier: GPL-2.0 + * + * xen/common/dt_overlay.c + * + * Device tree overlay support in Xen. + * + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. + * Written by Vikram Garhwal + * + */ +#include +#include +#include +#include +#include + +static LIST_HEAD(overlay_tracker); +static DEFINE_SPINLOCK(overlay_lock); + +/* Find last descendants of the device_node. */ +static struct dt_device_node *find_last_descendants_node( + struct dt_device_node *device_node) +{ + struct dt_device_node *child_node; + + for ( child_node = device_node->child; child_node->sibling != NULL; + child_node = child_node->sibling ) + { + } + + /* If last child_node also have children. */ + if ( child_node->child ) + child_node = find_last_descendants_node(child_node); + + return child_node; +} + +static int dt_overlay_remove_node(struct dt_device_node *device_node) +{ + struct dt_device_node *np; + struct dt_device_node *parent_node; + struct dt_device_node *device_node_last_descendant = device_node->child; + + parent_node = device_node->parent; + + if ( parent_node == NULL ) + { + dt_dprintk("%s's parent node not found\n", device_node->name); + return -EFAULT; + } + + np = parent_node->child; + + if ( np == NULL ) + { + dt_dprintk("parent node %s's not found\n", parent_node->name); + return -EFAULT; + } + + /* If node to be removed is only child node or first child. */ + if ( !dt_node_cmp(np->full_name, device_node->full_name) ) + { + parent_node->child = np->sibling; + + /* + * Iterate over all child nodes of device_node. Given that we are + * removing parent node, we need to remove all it's descendants too. + */ + if ( device_node_last_descendant ) + { + device_node_last_descendant = + find_last_descendants_node(device_node); + parent_node->allnext = device_node_last_descendant->allnext; + } + else + parent_node->allnext = np->allnext; + + return 0; + } + + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) + { + if ( !dt_node_cmp(np->sibling->full_name, device_node->full_name) ) + { + /* Found the node. Now we remove it. */ + np->sibling = np->sibling->sibling; + + if ( np->child ) + np = find_last_descendants_node(np); + + /* + * Iterate over all child nodes of device_node. Given that we are + * removing parent node, we need to remove all it's descendants too. + */ + if ( device_node_last_descendant ) + device_node_last_descendant = + find_last_descendants_node(device_node); + + if ( device_node_last_descendant ) + np->allnext = device_node_last_descendant->allnext; + else + np->allnext = np->allnext->allnext; + + break; + } + } + + return 0; +} + +/* Basic sanity check for the dtbo tool stack provided to Xen. */ +static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) +{ + if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) || + fdt_check_header(overlay_fdt) ) + { + printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device Tree\n"); + return -EINVAL; + } + + return 0; +} + +/* Count number of nodes till one level of __overlay__ tag. */ +static unsigned int overlay_node_count(void *fdto) +{ + unsigned int num_overlay_nodes = 0; + int fragment; + + fdt_for_each_subnode(fragment, fdto, 0) + { + int subnode; + int overlay; + + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + + /* + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for + * overlay >= 0. So, no need for a overlay>=0 check here. + */ + fdt_for_each_subnode(subnode, fdto, overlay) + { + num_overlay_nodes++; + } + } + + return num_overlay_nodes; +} + +static int handle_remove_irq_iommu(struct dt_device_node *device_node) +{ + int rc = 0; + struct domain *d = hardware_domain; + domid_t domid; + unsigned int naddr, len; + unsigned int i, nirq; + uint64_t addr, size; + + domid = dt_device_used_by(device_node); + + dt_dprintk("Checking if node %s is used by any domain\n", + device_node->full_name); + + /* Remove the node iff it's assigned to domain 0 or domain io. */ + if ( domid != 0 && domid != DOMID_IO ) + { + printk(XENLOG_ERR "Device %s as it is being used by domain %d. Removing nodes failed\n", + device_node->full_name, domid); + return -EINVAL; + } + + dt_dprintk("Removing node: %s\n", device_node->full_name); + + nirq = dt_number_of_irq(device_node); + + /* Remove IRQ permission */ + for ( i = 0; i < nirq; i++ ) + { + rc = platform_get_irq(device_node, i);; + + if ( irq_access_permitted(d, rc) == false ) + { + printk(XENLOG_ERR "IRQ %d is not routed to domain %d\n", rc, + domid); + return -EINVAL; + } + /* + * TODO: We don't handle shared IRQs for now. So, it is assumed that + * the IRQs was not shared with another devices. + */ + rc = irq_deny_access(d, rc); + if ( rc ) + { + printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n", + i, device_node->full_name); + return rc; + } + } + + /* Check if iommu property exists. */ + if ( dt_get_property(device_node, "iommus", &len) ) + { + rc = iommu_remove_dt_device(device_node); + if ( rc != 0 && rc != -ENXIO ) + return rc; + } + + naddr = dt_number_of_address(device_node); + + /* Remove mmio access. */ + for ( i = 0; i < naddr; i++ ) + { + rc = dt_device_get_address(device_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(device_node)); + return rc; + } + + rc = iomem_deny_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + size - 1))); + if ( rc ) + { + printk(XENLOG_ERR "Unable to remove dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1); + return rc; + } + + } + + return rc; +} + +/* Removes all descendants of the given node. */ +static int remove_all_descendant_nodes(struct dt_device_node *device_node) +{ + int rc = 0; + struct dt_device_node *child_node; + + for ( child_node = device_node->child; child_node != NULL; + child_node = child_node->sibling ) + { + if ( child_node->child ) + remove_all_descendant_nodes(child_node); + + rc = handle_remove_irq_iommu(child_node); + if ( rc ) + return rc; + } + + return rc; +} + +/* Remove nodes from dt_host. */ +static int remove_nodes(const struct overlay_track *tracker) +{ + int rc = 0; + struct dt_device_node *overlay_node; + unsigned int j; + + for ( j = 0; j < tracker->num_nodes; j++ ) + { + overlay_node = (struct dt_device_node *)tracker->nodes_address[j]; + if ( overlay_node == NULL ) + { + printk(XENLOG_ERR "Device %s is not present in the tree. Removing nodes failed\n", + overlay_node->full_name); + return -EINVAL; + } + + rc = remove_all_descendant_nodes(overlay_node); + + /* All children nodes are unmapped. Now remove the node itself. */ + rc = handle_remove_irq_iommu(overlay_node); + if ( rc ) + return rc; + + read_lock(&dt_host->lock); + + rc = dt_overlay_remove_node(overlay_node); + if ( rc ) + { + read_unlock(&dt_host->lock); + + return rc; + } + + read_unlock(&dt_host->lock); + } + + return rc; +} + +/* + * First finds the device node to remove. Check if the device is being used by + * any dom and finally remove it from dt_host. IOMMU is already being taken care + * while destroying the domain. + */ +static long handle_remove_overlay_nodes(void *overlay_fdt, + uint32_t overlay_fdt_size) +{ + int rc = 0; + struct overlay_track *entry, *temp, *track; + bool found_entry = false; + + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); + if ( rc ) + return rc; + + if ( overlay_node_count(overlay_fdt) == 0 ) + return -ENOMEM; + + spin_lock(&overlay_lock); + + /* + * First check if dtbo is correct i.e. it should one of the dtbo which was + * used when dynamically adding the node. + * Limitation: Cases with same node names but different property are not + * supported currently. We are relying on user to provide the same dtbo + * as it was used when adding the nodes. + */ + list_for_each_entry_safe( entry, temp, &overlay_tracker, entry ) + { + if ( memcmp(entry->overlay_fdt, overlay_fdt, overlay_fdt_size) == 0 ) + { + track = entry; + found_entry = true; + break; + } + } + + if ( found_entry == false ) + { + rc = -EINVAL; + + printk(XENLOG_ERR "Cannot find any matching tracker with input dtbo." + " Removing nodes is supported for only prior added dtbo. Please" + " provide a valid dtbo which was used to add the nodes.\n"); + goto out; + + } + + rc = remove_nodes(entry); + + if ( rc ) + { + printk(XENLOG_ERR "Removing node failed\n"); + goto out; + } + + list_del(&entry->entry); + + xfree(entry->dt_host_new); + xfree(entry->fdt); + xfree(entry->overlay_fdt); + + xfree(entry->nodes_address); + + xfree(entry); + +out: + spin_unlock(&overlay_lock); + return rc; +} + +long dt_sysctl(struct xen_sysctl_dt_overlay *op) +{ + long ret; + void *overlay_fdt; + + if ( op->overlay_fdt_size <= 0 || op->overlay_fdt_size > KB(500) ) + return -EINVAL; + + overlay_fdt = xmalloc_bytes(op->overlay_fdt_size); + + if ( overlay_fdt == NULL ) + return -ENOMEM; + + ret = copy_from_guest(overlay_fdt, op->overlay_fdt, op->overlay_fdt_size); + if ( ret ) + { + gprintk(XENLOG_ERR, "copy from guest failed\n"); + xfree(overlay_fdt); + + return -EFAULT; + } + + switch ( op->overlay_op ) + { + case XEN_SYSCTL_DT_OVERLAY_REMOVE: + ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); + xfree(overlay_fdt); + + break; + + default: + xfree(overlay_fdt); + break; + } + + return ret; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 2b24d6bfd0..1158c1efb3 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -1057,6 +1057,25 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); #endif +#if defined(__arm__) || defined (__aarch64__) +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 +#define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 + +/* + * XEN_SYSCTL_dt_overlay + * Performs addition/removal of device tree nodes under parent node using dtbo. + * This does in three steps: + * - Adds/Removes the nodes from dt_host. + * - Adds/Removes IRQ permission for the nodes. + * - Adds/Removes MMIO accesses. + */ +struct xen_sysctl_dt_overlay { + XEN_GUEST_HANDLE_64(void) overlay_fdt; /* IN: overlay fdt. */ + uint32_t overlay_fdt_size; /* IN: Overlay dtb size. */ + uint8_t overlay_op; /* IN: Add or remove. */ +}; +#endif + struct xen_sysctl { uint32_t cmd; #define XEN_SYSCTL_readconsole 1 @@ -1087,6 +1106,7 @@ struct xen_sysctl { #define XEN_SYSCTL_livepatch_op 27 /* #define XEN_SYSCTL_set_parameter 28 */ #define XEN_SYSCTL_get_cpu_policy 29 +#define XEN_SYSCTL_dt_overlay 30 uint32_t interface_version; /* XEN_SYSCTL_INTERFACE_VERSION */ union { struct xen_sysctl_readconsole readconsole; @@ -1117,6 +1137,10 @@ struct xen_sysctl { #if defined(__i386__) || defined(__x86_64__) struct xen_sysctl_cpu_policy cpu_policy; #endif + +#if defined(__arm__) || defined (__aarch64__) + struct xen_sysctl_dt_overlay dt_overlay; +#endif uint8_t pad[128]; } u; }; diff --git a/xen/include/xen/dt_overlay.h b/xen/include/xen/dt_overlay.h new file mode 100644 index 0000000000..2cd975a070 --- /dev/null +++ b/xen/include/xen/dt_overlay.h @@ -0,0 +1,59 @@ +/* + * SPDX-License-Identifier: GPL-2.0 + * + * xen/dt_overlay.h + * + * Device tree overlay support in Xen. + * + * Copyright (c) 2022 AMD Inc. + * Written by Vikram Garhwal + * + */ +#ifndef __XEN_DT_SYSCTL_H__ +#define __XEN_DT_SYSCTL_H__ + +#include +#include +#include +#include + +/* + * overlay_node_track describes information about added nodes through dtbo. + * @entry: List pointer. + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. + * @fdt: Stores the fdt. + * @nodes_fullname: Stores the full name of nodes. + * @nodes_irq: Stores the IRQ added from overlay dtb. + * @node_num_irq: Stores num of IRQ for each node in overlay dtb. + * @num_nodes: Stores total number of nodes in overlay dtb. + */ +struct overlay_track { + struct list_head entry; + struct dt_device_node *dt_host_new; + void *fdt; + void *overlay_fdt; + unsigned long *nodes_address; + unsigned int num_nodes; +}; + +struct xen_sysctl_dt_overlay; + +#ifdef CONFIG_OVERLAY_DTB +long dt_sysctl(struct xen_sysctl_dt_overlay *op); +#else +static inline long dt_sysctl(struct xen_sysctl_dt_overlay *op) +{ + return -ENOSYS; +} +#endif +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519832.806930 (Exim 4.92) (envelope-from ) id 1pmJWv-0007o6-3O; Tue, 11 Apr 2023 19:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519832.806930; Tue, 11 Apr 2023 19:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWv-0007nz-0F; Tue, 11 Apr 2023 19:19:49 +0000 Received: by outflank-mailman (input) for mailman id 519832; Tue, 11 Apr 2023 19:19:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUX-0004DR-UL for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:21 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20605.outbound.protection.outlook.com [2a01:111:f400:fe5b::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a02f9d4-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:19 +0200 (CEST) Received: from MW4PR03CA0193.namprd03.prod.outlook.com (2603:10b6:303:b8::18) by BY5PR12MB4082.namprd12.prod.outlook.com (2603:10b6:a03:212::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Tue, 11 Apr 2023 19:17:16 +0000 Received: from CO1NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::50) by MW4PR03CA0193.outlook.office365.com (2603:10b6:303:b8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:16 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT096.mail.protection.outlook.com (10.13.175.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:16 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:15 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:15 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:14 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a02f9d4-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P0exrgxOsL3/n+mSGDHDH6/A5pjNuEf1TPtfLeN1YNCdk/0fcuZKfeBQ+kAUCR1oHXMjAPvE4GWoEgdLcUa5IXQSPdX3maD/MO6bq+CXTHU5LaU0IqsbKChtU0AktrZN5df86NdF3mDTlVhNjIcY41LV/rIZwWJLWlSjQRhxQB0isasO/zfTdo4LRCsid8vbMYikhwEtk4/933RhXZmxSNbei+shE8xh3yKyNkG0jhYwCaTFBEFaptQ8zIjLdzCvxToy6C8bW4lxVLJV5YKiItoUp/mGckp+lYgoZKKJT8bDmgYke5UlqVKgdukX8f/G4+27OvNAJDhnOJ7u4Df+Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IPRvr0PydrbevxDRuC5bBe8hAAj8BLWppbzz+G6AD20=; b=lrxwKTPqIWTKUtX/8wpDACNNInoA3QgYgqgmcAw+exLo9MtAX5xaaT3gL7prU8bDv23L70gZ55n1nXx+zfkcxjOVA23gHjB3oceDq7HyhmCQgBkKPmA+d/3KKyK1HDmR0RkbE95MoYRQ4EX1rra2gYqQfSuAPzvbKCMRpy3K0TyVlckDUw5BJBbXjQi4LNY/776Fwk1Ht3PhRqhjP2vSys3UfL0iKFekLlyDzUSyClKrvMAa0zXHOuq523iRvuiWLOAByCmBUeaRCIxa8QuahtSZCEshumzaxrAbHWEVRXZbPq9++7ZKY7hYrABhEj4Zk2EjecLRsBHCsbn96lcVCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IPRvr0PydrbevxDRuC5bBe8hAAj8BLWppbzz+G6AD20=; b=qH59dc/ukbVX2ZGRfg7805zmZ0sNdHiS/3/rE6u+NrZ0/AfFAQfuPd9pdmWOSQ45slWxwf4a6PXicvYGdbvsLrV0wkn3Tbmrblpj4tSOH/+MOzHoEx4K4IWLyxnY8IS4TQkrGX57VadXkvNt3dnpjGsjO533SpnFoTsgNemL2Pc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 06/17] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Date: Tue, 11 Apr 2023 12:16:25 -0700 Message-ID: <20230411191636.26926-25-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT096:EE_|BY5PR12MB4082:EE_ X-MS-Office365-Filtering-Correlation-Id: b7acaf12-230c-4e31-5eb6-08db3ac15cc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1MfYvPhUa7cLMUQI3UZmTwYyclh+2tL8706Z/bu7eT1dEfy1NAyms7VzyXY5KTCL7NL8JlCu0W1DTsziZzFOz1LkKWWz+hJvfclNY8rCnVN1x7MAjO8H6RhcfhfSJY6EpQLqpjqRpgkRrDTVxp/rhMbvVOWCJc5OzNmCp3dEopgFV44w2pd6ZMUe6EtR5Nu2NU1I7vpxMOs7P1FtgwpQRfP77kZwvanCXLNaI97U71brqvYCDejv6Sn/TJYD+HL4c8A6viwc1bO1W1rNtiJuGrJ8f7wyFIJJISfrqnjUZWXE4OmWJp4fDDk7JD0LTLc5og9uQgXZur+RGQmy9khxVVSklL22dU3GFR8EnsVLVJIb6KU6WogwgkaWgvfQBd2FJLbMRnNgUmL9vzQTwmHUcVU3jmw0cDjqLb7OrMNKOX4zpNpB9gfNQJ4t50f7XMYW+A1imJwbKNMM/lyEOY0Pu8R/ona/GRwnTilEsXuD0PQ8gQxA+Lx3UeLlrPQlix1s5OrdiwcW/AlBCdiDOLDkMPq4jLQOImaGCyrN48Ggk5tpeDYClOPsb1pC2l3ncx/npuVCUnBDsFJL0cTjRJweqVf0zi0Stb2shucwvX2ux25bQrD7r/PTfv3EoIw6ymXFqoTlQGQDqOR+q2Q8G2KUdg0tN6qIbWgz/jeVjII7nW8sl8vgtzC+kGsH8Bv9fw9aE5DTuLubkCAIz7nbgwIyPDGdG1H6YMM0ekmJ29YvqaezDp3wJZke+4Zf1TCiwCxfKW3M2hmkU4kbJk2kIuzQiw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(36840700001)(40470700004)(46966006)(478600001)(1076003)(26005)(316002)(186003)(44832011)(54906003)(2906002)(5660300002)(4326008)(70586007)(70206006)(8676002)(6916009)(6666004)(82310400005)(41300700001)(8936002)(81166007)(356005)(82740400003)(47076005)(40480700001)(83380400001)(86362001)(40460700003)(36756003)(2616005)(426003)(36860700001)(336012)(37363002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:16.0901 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7acaf12-230c-4e31-5eb6-08db3ac15cc3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4082 Add device_tree_find_node_by_path() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflattened to a dt_host_new. Next, we need to find the overlay nodes in dt_host_new, find the overlay node's parent in dt_host and add the nodes as child under their parent in the dt_host. Thus we need this function to search for node in different unflattened device trees. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 5 +++-- xen/include/xen/device_tree.h | 17 +++++++++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index bf847b2584..507b4ac5b6 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -358,11 +358,12 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, return np; } -struct dt_device_node *dt_find_node_by_path(const char *path) +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, + const char *path) { struct dt_device_node *np; - dt_for_each_device_node(dt_host, np) + dt_for_each_device_node(dt, np) if ( np->full_name && (dt_node_cmp(np->full_name, path) == 0) ) break; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 58ac12abe3..998f972ebc 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -534,13 +534,26 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, struct dt_device_node *dt_find_node_by_alias(const char *alias); /** - * dt_find_node_by_path - Find a node matching a full DT path + * device_tree_find_node_by_path - Generic function to find a node matching the + * full DT path for any given unflatten device tree + * @dt_node: The device tree to search * @path: The full path to match * * Returns a node pointer. */ -struct dt_device_node *dt_find_node_by_path(const char *path); +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, + const char *path); +/** + * dt_find_node_by_path - Find a node matching a full DT path in dt_host + * @path: The full path to match + * + * Returns a node pointer. + */ +static inline struct dt_device_node *dt_find_node_by_path(const char *path) +{ + return device_tree_find_node_by_path(dt_host, path); +} /** * dt_find_node_by_gpath - Same as dt_find_node_by_path but retrieve the -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519837.806936 (Exim 4.92) (envelope-from ) id 1pmJWv-0007rh-Cz; Tue, 11 Apr 2023 19:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519837.806936; Tue, 11 Apr 2023 19:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWv-0007qt-87; Tue, 11 Apr 2023 19:19:49 +0000 Received: by outflank-mailman (input) for mailman id 519837; Tue, 11 Apr 2023 19:19:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUi-0004DR-CQ for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:32 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062f.outbound.protection.outlook.com [2a01:111:f400:7eab::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f2d845c-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:28 +0200 (CEST) Received: from BN7PR02CA0013.namprd02.prod.outlook.com (2603:10b6:408:20::26) by DS7PR12MB6216.namprd12.prod.outlook.com (2603:10b6:8:94::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:17:23 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:20:cafe::c5) by BN7PR02CA0013.outlook.office365.com (2603:10b6:408:20::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 19:17:23 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:22 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:22 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:21 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f2d845c-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QhVPwCHPBd0JqSv8CuQhxwh7IwEIlkz5sDOLIQoApkzz+fDG8H3ckb4RW2xe1A6GP/beE8nO6wLtzAfmVAyjvSEv2yKsT7X+dfjcEwyALwDkIEhJAaKQZNX+pgRXCcjHm6Yin/4G23Ar6Q41WxmcDxfHNDTh/1Ms2OU0xsm3CVtBRAY8uJLCCESO+dJRTRscHO2zUrsIPhhkEH6KlXV/jTocmaVYYctPPU1yKmmLKLnJFmlUUMT0x91+KDsGYQ5Hka3GEgFsMbgufym9BD8yAGDjMe8JeSxwjtdUgvpw2JpgbCsQy0UnwCaWBvxlQy1lg51N0sYsqW3S04xY8X5LBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+cCBf3g6fBI4ES7DG61XJTRWpPAgPp5V0YvFzOd6Q8=; b=Kk7BuBTpE4tduXmrudfAI3Fo4DlKtKQFO3HrA+7ZlGTSCCpxvej7ika47IqM43+1FbEWwyXZAN0zQYxGhiTLgzHGAIdG89qtx4uPv6WBCRXaA0qt4RGCFNXIVCOVCrBA21Q3kNWn5ngbSH21DEqmfMnDx4uIdXm9N8fc/NAQbO4rLgoEX/4EX2So76MrlEV7zdBrE8evE9WcbLGW2KXgDXOka9w35ts4fUs3Ri6xQLUFcfRgK0UO/7Yppxwp3iZyC2/WqcOYiG8vPXG5bdOsp6fxc+G71x7n/cL5kr7OA/aY0KMQjMLNIOx6oyX5/IG4wpdxDV9YdOHEcfO6W9bO2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3+cCBf3g6fBI4ES7DG61XJTRWpPAgPp5V0YvFzOd6Q8=; b=QNeE23U21k2usTifMLPD62BNgxvVZhA1lzql9jc0s5JylFMBCkzq4iQprqGL78CJ8RdIwnwc0qLcCfZpRiTemKXkCSCsmFk+Pz6uya/t5QSBl1iXjj8zvEYXONR3FW93AGTHvk9wsBr1pXtR3BNbF+27jLtYwEfB1QvFIvGHKyw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN][PATCH v5 14/17] xen/arm: Implement device tree node addition functionalities Date: Tue, 11 Apr 2023 12:16:33 -0700 Message-ID: <20230411191636.26926-33-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|DS7PR12MB6216:EE_ X-MS-Office365-Filtering-Correlation-Id: c115fdb8-a23b-44d5-3ea3-08db3ac160a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 25OgTU+pwi5Jek33LVmE9JLfv8q5jD3oVUA3yVVaKNM7y4JUV6U0EqP4k8B+1MCK9P2rVG/cY6Xdxlc9CiJCU8cSMFjnmRNdZ/WiZKy69MqXz4Jr0JayAYLw71fqiLZFzv1XlMO9hwvnQXPGh7I777aHghv9JNlvkkEes6o0qIk8MWIGGHe3+TjCfJpVbSz9IgAlptmWDajNadmQS9KwOIAshXbip0Jdhh9duBUDk3G0QVfKEIl3oYixSyO/WtTfeOhqf0PvoyDz3zTh9vdddKsNvZBVzHZD4FvZgvRIYt4P1pNTGkmiA6XN4vbXAtIxbL1zoXZJIUIIIYG0oyR+qa9ZoUC49zx7cDbG3Q1DtmcxFdApJ0aRXVOneqs9ikfEpQhKQowPwC04jy5QZ/OeZJoFmIpUc6vqCNSuTnxvS0Cf9bzBhA6H6mAcmLRYD1G1MSlaZuGlp+HyVNoceftO04G4vaOJ6VDfpU/TbzW8sSSfh9j4uCe5yWxZ5jfC1FOHCFSx/6XX/geZ2Sz4tIpWNY9XQ7FyC+cEhKZgNSGDCZzYVja4g381K1I/vE9Zk/LqPnMRreG8vnIU+flRUY5glwi4RqcqoJgX23ZHZw1ymY6iE/RRrRgfANX4HBGZveF7gYtuDyQjnVnV3EewXF2gXxt+BVPvJt6TcBaWWe/3ye0DVO6bPnPKcTClCMh/+g8BW5YSk+vdB2vAbRHiN8vq3zjGaNCtbz5hvRqBXpG6N20= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(46966006)(40470700004)(36840700001)(478600001)(83380400001)(86362001)(40460700003)(40480700001)(36756003)(82740400003)(81166007)(356005)(47076005)(36860700001)(336012)(2616005)(426003)(30864003)(2906002)(1076003)(26005)(316002)(54906003)(186003)(44832011)(5660300002)(82310400005)(8676002)(6666004)(6916009)(8936002)(41300700001)(4326008)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:22.6958 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c115fdb8-a23b-44d5-3ea3-08db3ac160a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6216 Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition using device tree overlay. xl dt-overlay add file.dtbo: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflattened to a dt_host_new. Next, it checks if any of the overlay nodes already exists in the dt_host. If overlay nodes doesn't exist then find the overlay nodes in dt_host_new, find the overlay node's parent in dt_host and add the nodes as child under their parent in the dt_host. The node is attached as the last node under target parent. Finally, add IRQs, add device to IOMMUs, set permissions and map MMIO for the overlay node. When a node is added using overlay, a new entry is allocated in the overlay_track to keep the track of memory allocation due to addition of overlay node. This is helpful for freeing the memory allocated when a device tree node is removed. The main purpose of this to address first part of dynamic programming i.e. making xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/setting IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". Signed-off-by: Vikram Garhwal --- xen/common/dt_overlay.c | 482 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 482 insertions(+) diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c index 516e8010c5..3344bad313 100644 --- a/xen/common/dt_overlay.c +++ b/xen/common/dt_overlay.c @@ -36,6 +36,25 @@ static struct dt_device_node *find_last_descendants_node( return child_node; } +/* + * Returns next node to the input node. If node has children then return + * last descendant's next node. +*/ +static struct dt_device_node *dt_find_next_node(struct dt_device_node *dt, + const struct dt_device_node *node) +{ + struct dt_device_node *np; + + dt_for_each_device_node(dt, np) + if ( np == node ) + break; + + if ( np->child ) + np = find_last_descendants_node(np); + + return np->allnext; +} + static int dt_overlay_remove_node(struct dt_device_node *device_node) { struct dt_device_node *np; @@ -109,6 +128,72 @@ static int dt_overlay_remove_node(struct dt_device_node *device_node) return 0; } +static int dt_overlay_add_node(struct dt_device_node *device_node, + const char *parent_node_path) +{ + struct dt_device_node *parent_node; + struct dt_device_node *np, *np_last_descendant; + struct dt_device_node *next_node; + struct dt_device_node *device_node_last_descendant; + + parent_node = dt_find_node_by_path(parent_node_path); + + if ( parent_node == NULL ) + { + dt_dprintk("Node not found. Overlay node will not be added\n"); + return -EINVAL; + } + + /* If parent has no child. */ + if ( parent_node->child == NULL ) + { + next_node = parent_node->allnext; + device_node->parent = parent_node; + parent_node->allnext = device_node; + parent_node->child = device_node; + } + else + { + /* If parent has at least one child node. + * Iterate to the last child node of parent. + */ + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ); + + /* Iterate over all child nodes of np node. */ + if ( np->child ) + { + np_last_descendant = find_last_descendants_node(np); + + next_node = np_last_descendant->allnext; + np_last_descendant->allnext = device_node; + } + else + { + next_node = np->allnext; + np->allnext = device_node; + } + + device_node->parent = parent_node; + np->sibling = device_node; + np->sibling->sibling = NULL; + } + + /* Iterate over all child nodes of device_node to add children too. */ + if ( device_node->child ) + { + device_node_last_descendant = find_last_descendants_node(device_node); + /* Plug next_node at the end of last children of device_node. */ + device_node_last_descendant->allnext = next_node; + } + else + { + /* Now plug next_node at the end of device_node. */ + device_node->allnext = next_node; + } + + return 0; +} + /* Basic sanity check for the dtbo tool stack provided to Xen. */ static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) { @@ -148,6 +233,79 @@ static unsigned int overlay_node_count(void *fdto) return num_overlay_nodes; } +/* + * overlay_get_nodes_info will get full name with path for all the nodes which + * are in one level of __overlay__ tag. This is useful when checking node for + * duplication i.e. dtbo tries to add nodes which already exists in device tree. + */ +static int overlay_get_nodes_info(const void *fdto, char ***nodes_full_path, + unsigned int num_overlay_nodes) +{ + int fragment; + + *nodes_full_path = xzalloc_bytes(num_overlay_nodes * sizeof(char *)); + + if ( *nodes_full_path == NULL ) + return -ENOMEM; + + fdt_for_each_subnode(fragment, fdto, 0) + { + int target; + int overlay; + int subnode; + const char *target_path; + + target = fdt_overlay_target_offset(device_tree_flattened, fdto, + fragment, &target_path); + if ( target < 0 ) + return target; + + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + + /* + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for + * overlay >= 0. So, no need for a overlay>=0 check here. + */ + fdt_for_each_subnode(subnode, fdto, overlay) + { + const char *node_name = NULL; + int node_name_len; + unsigned int target_path_len = strlen(target_path); + unsigned int node_full_name_len; + unsigned int node_num = 0; + + node_name = fdt_get_name(fdto, subnode, &node_name_len); + + if ( node_name == NULL ) + return node_name_len; + + /* + * Magic number 2 is for adding '/'. This is done to keep the + * node_full_name in the correct full node name format. + */ + node_full_name_len = target_path_len + node_name_len + 2; + + (*nodes_full_path)[node_num] = xmalloc_bytes(node_full_name_len); + + if ( (*nodes_full_path)[node_num] == NULL ) + return -ENOMEM; + + memcpy((*nodes_full_path)[node_num], target_path, target_path_len); + + (*nodes_full_path)[node_num][target_path_len] = '/'; + + memcpy((*nodes_full_path)[node_num] + target_path_len + 1, + node_name, node_name_len); + + (*nodes_full_path)[node_num][node_full_name_len - 1] = '\0'; + + node_num++; + } + } + + return 0; +} + static int handle_remove_irq_iommu(struct dt_device_node *device_node) { int rc = 0; @@ -367,6 +525,322 @@ out: return rc; } +/* + * Handles IRQ and IOMMU mapping for the overlay_node and all descendants of the + * overlay_nodes. + */ +static int handle_add_irq_iommu(struct domain *d, + struct dt_device_node *overlay_node) +{ + int rc; + unsigned int naddr, i, len; + uint64_t addr, size; + struct dt_device_node *np; + + /* First let's handle the interrupts. */ + rc = handle_device_interrupts(d, overlay_node, false); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Interrupt failed\n"); + return rc; + } + + /* Check if iommu property exists. */ + if ( dt_get_property(overlay_node, "iommus", &len) ) + { + + /* Add device to IOMMUs. */ + rc = iommu_add_dt_device(overlay_node); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Failed to add %s to the IOMMU\n", + dt_node_full_name(overlay_node)); + return rc; + } + } + + /* Set permissions. */ + naddr = dt_number_of_address(overlay_node); + + dt_dprintk("%s passthrough = %d naddr = %u\n", + dt_node_full_name(overlay_node), false, naddr); + + /* Give permission for map MMIOs */ + for ( i = 0; i < naddr; i++ ) + { + /* + * For now, we skip_mapping which means it will only permit iomem access + * to hardware_domain using iomem_permit_access() but will never map as + * map_range_p2mt() will not be called. + */ + struct map_range_data mr_data = { .d = d, + .p2mt = p2m_mmio_direct_c, + .skip_mapping = true }; + + rc = dt_device_get_address(overlay_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(overlay_node)); + return rc; + } + + rc = map_range_to_domain(overlay_node, addr, size, &mr_data); + if ( rc ) + return rc; + } + + /* Map IRQ and IOMMU for overlay_node's children. */ + for ( np = overlay_node->child; np != NULL; np = np->sibling) + { + rc = handle_add_irq_iommu(d, np); + if ( rc ) + { + printk(XENLOG_ERR "Adding IRQ and IOMMU failed\n"); + return rc; + } + } + + return rc; +} + +/* + * Adds device tree nodes under target node. + * We use tr->dt_host_new to unflatten the updated device_tree_flattened. This + * is done to avoid the removal of device_tree generation, iomem regions mapping + * to hardware domain done by handle_node(). + */ +static long handle_add_overlay_nodes(void *overlay_fdt, + uint32_t overlay_fdt_size) +{ + int rc, j, i; + struct dt_device_node *overlay_node, *prev_node, *next_node; + struct domain *d = hardware_domain; + struct overlay_track *tr = NULL; + char **nodes_full_path = NULL; + unsigned int new_fdt_size; + + tr = xzalloc(struct overlay_track); + if ( tr == NULL ) + return -ENOMEM; + + new_fdt_size = fdt_totalsize(device_tree_flattened) + + fdt_totalsize(overlay_fdt); + + tr->fdt = xzalloc_bytes(new_fdt_size); + if ( tr->fdt == NULL ) + { + xfree(tr); + return -ENOMEM; + } + + tr->num_nodes = overlay_node_count(overlay_fdt); + if ( tr->num_nodes == 0 ) + { + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + tr->nodes_address = xzalloc_bytes(tr->num_nodes * sizeof(unsigned long)); + if ( tr->nodes_address == NULL ) + { + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); + if ( rc ) + { + xfree(tr->nodes_address); + xfree(tr->fdt); + xfree(tr); + return rc; + } + + /* + * Keep a copy of overlay_fdt as fdt_overlay_apply will change the input + * overlay's content(magic) when applying overlay. + */ + tr->overlay_fdt = xzalloc_bytes(overlay_fdt_size); + if ( tr->overlay_fdt == NULL ) + { + xfree(tr->nodes_address); + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + memcpy(tr->overlay_fdt, overlay_fdt, overlay_fdt_size); + + spin_lock(&overlay_lock); + + memcpy(tr->fdt, device_tree_flattened, + fdt_totalsize(device_tree_flattened)); + + /* Open tr->fdt with more space to accommodate the overlay_fdt. */ + fdt_open_into(tr->fdt, tr->fdt, new_fdt_size); + + /* + * overlay_get_nodes_info is called to get the node information from dtbo. + * This is done before fdt_overlay_apply() because the overlay apply will + * erase the magic of overlay_fdt. + */ + rc = overlay_get_nodes_info(overlay_fdt, &nodes_full_path, + tr->num_nodes); + if ( rc ) + { + printk(XENLOG_ERR "Getting nodes information failed with error %d\n", + rc); + goto err; + } + + rc = fdt_overlay_apply(tr->fdt, overlay_fdt); + if ( rc ) + { + printk(XENLOG_ERR "Adding overlay node failed with error %d\n", rc); + goto err; + } + + /* + * Check if any of the node already exists in dt_host. If node already exits + * we can return here as this overlay_fdt is not suitable for overlay ops. + */ + for ( j = 0; j < tr->num_nodes; j++ ) + { + overlay_node = dt_find_node_by_path(nodes_full_path[j]); + if ( overlay_node != NULL ) + { + printk(XENLOG_ERR "node %s exists in device tree\n", + nodes_full_path[j]); + rc = -EINVAL; + goto err; + } + } + + /* Unflatten the tr->fdt into a new dt_host. */ + unflatten_device_tree(tr->fdt, &tr->dt_host_new); + + for ( j = 0; j < tr->num_nodes; j++ ) + { + dt_dprintk("Adding node: %s\n", nodes_full_path[j]); + + /* Find the newly added node in tr->dt_host_new by it's full path. */ + overlay_node = device_tree_find_node_by_path(tr->dt_host_new, + nodes_full_path[j]); + if ( overlay_node == NULL ) + { + dt_dprintk("%s node not found\n", nodes_full_path[j]); + rc = -EFAULT; + goto remove_node; + } + + /* + * Find previous and next node to overlay_node in dt_host_new. We will + * need these nodes to fix the dt_host_new mapping. When overlay_node is + * take out of dt_host_new tree and added to dt_host, link between + * previous node and next_node is broken. We will need to refresh + * dt_host_new with correct linking for any other overlay nodes + * extraction in future. + */ + dt_for_each_device_node(tr->dt_host_new, prev_node) + if ( prev_node->allnext == overlay_node ) + break; + + next_node = dt_find_next_node(tr->dt_host_new, overlay_node); + + read_lock(&dt_host->lock); + + /* Add the node to dt_host. */ + rc = dt_overlay_add_node(overlay_node, overlay_node->parent->full_name); + if ( rc ) + { + read_unlock(&dt_host->lock); + + /* Node not added in dt_host. */ + goto remove_node; + } + + read_unlock(&dt_host->lock); + + prev_node->allnext = next_node; + + overlay_node = dt_find_node_by_path(overlay_node->full_name); + if ( overlay_node == NULL ) + { + /* Sanity check. But code will never come here. */ + ASSERT_UNREACHABLE(); + goto remove_node; + } + + rc = handle_add_irq_iommu(d, overlay_node); + if ( rc ) + { + printk(XENLOG_ERR "Adding IRQ and IOMMU failed\n"); + return rc; + } + + /* Keep overlay_node address in tracker. */ + tr->nodes_address[j] = (unsigned long)overlay_node; + } + + INIT_LIST_HEAD(&tr->entry); + list_add_tail(&tr->entry, &overlay_tracker); + + spin_unlock(&overlay_lock); + + if ( nodes_full_path != NULL ) + { + for ( i = 0; i < tr->num_nodes && nodes_full_path[i] != NULL; + i++ ) + { + xfree(nodes_full_path[i]); + } + xfree(nodes_full_path); + } + + return rc; + +/* + * Failure case. We need to remove the nodes, free tracker(if tr exists) and + * tr->dt_host_new. + */ +remove_node: + tr->num_nodes = j; + rc = remove_nodes(tr); + + if ( rc ) + { + /* If removing node fails, this may cause memory leaks. */ + printk(XENLOG_ERR "Removing node failed.\n"); + spin_unlock(&overlay_lock); + return rc; + } + +err: + spin_unlock(&overlay_lock); + + xfree(tr->dt_host_new); + xfree(tr->fdt); + xfree(tr->overlay_fdt); + xfree(tr->nodes_address); + + if ( nodes_full_path != NULL ) + { + for ( i = 0; i < tr->num_nodes && nodes_full_path[i] != NULL; + i++ ) + { + xfree(nodes_full_path[i]); + } + xfree(nodes_full_path); + } + + xfree(tr); + + return rc; +} + long dt_sysctl(struct xen_sysctl_dt_overlay *op) { long ret; @@ -391,6 +865,14 @@ long dt_sysctl(struct xen_sysctl_dt_overlay *op) switch ( op->overlay_op ) { + case XEN_SYSCTL_DT_OVERLAY_ADD: + ret = handle_add_overlay_nodes(overlay_fdt, op->overlay_fdt_size); + + if ( ret ) + xfree(overlay_fdt); + + break; + case XEN_SYSCTL_DT_OVERLAY_REMOVE: ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); xfree(overlay_fdt); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519844.806950 (Exim 4.92) (envelope-from ) id 1pmJWx-0008My-SM; Tue, 11 Apr 2023 19:19:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519844.806950; Tue, 11 Apr 2023 19:19:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWx-0008Mn-Nv; Tue, 11 Apr 2023 19:19:51 +0000 Received: by outflank-mailman (input) for mailman id 519844; Tue, 11 Apr 2023 19:19:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUV-0004DR-JA for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:19 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20623.outbound.protection.outlook.com [2a01:111:f400:fe5b::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 796fc584-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:17 +0200 (CEST) Received: from BN9PR03CA0130.namprd03.prod.outlook.com (2603:10b6:408:fe::15) by BL1PR12MB5873.namprd12.prod.outlook.com (2603:10b6:208:395::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:14 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::74) by BN9PR03CA0130.outlook.office365.com (2603:10b6:408:fe::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 19:17:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.22 via Frontend Transport; Tue, 11 Apr 2023 19:17:14 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:14 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:14 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 796fc584-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bs1J3pf2zY4xwRkL2xusjQN+dy/Hb3CaMEHIoZ23NB46HoFsLYKnIIwlW0XBpwPCN7sBqHrLf1rhal5UYE17cMnksix5aN6nMbrkNv+6GmJ5qE6Uj2V6c4owe1QhxzF+plzdo56ixceaOUEADAn48uVrOvUxGe/8gwQd7g34rc6cYj7wio0UF4K0lnKZR06l9DojTR1D15uuLKKtytOGPEUeIXqhf8Sx8C1aqbmRLYFtBZYzmFR5F48AkQdQrv/laftAZcrj63fbiKIrPrOrv6s05wQbb/pqCWRTMoqCUYYgrPu9iN2oZ4GLTNTH+nujRbHFxLhI6ij6sTF2rC+xPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aXlXQRcv7U/T/rRXFeXTNVQL0ZVDEHTt5u8gFMIkdTA=; b=dyMSY9mhc6T6gLBQ322vHVv2gtQ+FagNKnGJbC0oXLxhAW+OqmqmgtM1hUq9FTG6PNVRkzoe58KwtA/vmxD/ESwZ1JTgEYunaBP5t59JxcdCmdKOcVYrQnu3oB/KlXeX0FYiBgTTs35uN8/3UKbNZRs6FX1NUtZnv0go3t6Qw27Che+yW3qKUKNdY6YpdfzcNyhQ9jzRnERJjNe1k99DL1RmlD0P6RQmz5/u6BJADWhJ3glO2TBhAWUJkO4Oz1NwEk653E1Tau5l+VFx7AklCyjcwbn/SovfgCL4uQvoHODEgI/o5xqWQiCFFmSdagI+9yw3yz5w3W4UqLG4k+K6qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXlXQRcv7U/T/rRXFeXTNVQL0ZVDEHTt5u8gFMIkdTA=; b=AWISUh6SBvJgSoIVRMU5xu4akTc/rzbLimZg/dOzu2AZQmrJyx/aPaQNUFlWQRm3lFXICp+ky2stwepnVeprzphrV52xhw71Tna0Mff4itrrZStzZyt4faOE08CRCKzPkYH6mOB3Fs3jzGw3qpm3+6CdtL4IZFKtCm8NVjQDxDs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Vikram Garhwal , David Gibson Subject: [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target() Date: Tue, 11 Apr 2023 12:16:24 -0700 Message-ID: <20230411191636.26926-24-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|BL1PR12MB5873:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cf27a4a-d6d4-4ebc-9f12-08db3ac15bf2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UCHVU1GAWIXT5Vr+KAVVr/ta9BYbkCgoPqfm4WTdrU3RoPTLQlW5CXh242muGzIhtQJsutSR/AdTUTv3GXr9K6JpMHuCZpPgs666nQKZ+jyc2N657XVz/DG1JfeYyH+UcWG/zsLLdQIkR9TPf5QQxXO3KzR1KWAR9inkhIW9JVJhUmK7g+JsBobErTBk/ouoY2iADGrjzKIa89n5JoSdMp8yv7NSFZySqlc/CSKXAOrE1VgmQMTmNJqaeIhmt+UUnmPo7zeZweX7qfx977UfWyIXZUsLLcEPhXrEt9k8lE7sZFtW2nB8HFv6uqvC+9BvwEIHAHe7Z7xGvhZ6+ELaVxfIQuSP3JK0gHSS3V8Y59Yspvf3wWUjb/Y0B56ZRzLpTVXmfhlXFMa2BkSMfuxN2NV2Ro+nTR9LbuaBpgAamSXCmQcHDuUpz7CP4fK0zOvvqp/FHDM7cRViQi3HUNhjIssB/bUmhGW1BRrjzUDc/dUaTPibCgktd9ZIvqNZK6JWRogn5f1gE+KAf+2ZyFfozJ00rZ+4W7YBkJ7BUi4uzIl2qwfss4/iIU/tT2OunavEHSE4KsJW/6LdesyEcjRU03lv41GqBpdvagpa2C5kqBZQ5Qt7PGsPbiqQizXbrXcQPL0tIZkgJG/MxC4yoPPQxOGqcOQ9atH73lJKOpkeLX7PxcBtbNYX14FLELAG1txN4zzogOP1tuMTvoTYSpBCFl7eMflZIfm2eZXnK/bk8jk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199021)(36840700001)(46966006)(40470700004)(36756003)(86362001)(41300700001)(316002)(54906003)(8676002)(4326008)(966005)(70206006)(478600001)(6916009)(70586007)(82310400005)(5660300002)(40480700001)(36860700001)(2906002)(8936002)(44832011)(356005)(186003)(81166007)(82740400003)(6666004)(26005)(1076003)(336012)(2616005)(83380400001)(426003)(47076005)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:14.8314 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf27a4a-d6d4-4ebc-9f12-08db3ac15bf2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5873 Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays because Xen needs to do further processing of the overlay nodes, e.g. mapping of resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc. Signed-off-by: Vikram Garhwal Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> Signed-off-by: David Gibson Origin: https://github.com/dgibson/dtc 45f3d1a095dd Signed-off-by: Vikram Garhwal --- xen/common/libfdt/fdt_overlay.c | 29 +++++++---------------------- xen/common/libfdt/version.lds | 1 + xen/include/xen/libfdt/libfdt.h | 18 ++++++++++++++++++ 3 files changed, 26 insertions(+), 22 deletions(-) diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c index 7b95e2b639..acf0c4c2a6 100644 --- a/xen/common/libfdt/fdt_overlay.c +++ b/xen/common/libfdt/fdt_overlay.c @@ -41,37 +41,22 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) return fdt32_to_cpu(*val); } -/** - * overlay_get_target - retrieves the offset of a fragment's target - * @fdt: Base device tree blob - * @fdto: Device tree overlay blob - * @fragment: node offset of the fragment in the overlay - * @pathp: pointer which receives the path of the target (or NULL) - * - * overlay_get_target() retrieves the target offset in the base - * device tree of a fragment, no matter how the actual targeting is - * done (through a phandle or a path) - * - * returns: - * the targeted node offset in the base device tree - * Negative error code on error - */ -static int overlay_get_target(const void *fdt, const void *fdto, - int fragment, char const **pathp) +int fdt_overlay_target_offset(const void *fdt, const void *fdto, + int fragment_offset, char const **pathp) { uint32_t phandle; const char *path = NULL; int path_len = 0, ret; /* Try first to do a phandle based lookup */ - phandle = overlay_get_target_phandle(fdto, fragment); + phandle = overlay_get_target_phandle(fdto, fragment_offset); if (phandle == (uint32_t)-1) return -FDT_ERR_BADPHANDLE; /* no phandle, try path */ if (!phandle) { /* And then a path based lookup */ - path = fdt_getprop(fdto, fragment, "target-path", &path_len); + path = fdt_getprop(fdto, fragment_offset, "target-path", &path_len); if (path) ret = fdt_path_offset(fdt, path); else @@ -638,7 +623,7 @@ static int overlay_merge(void *fdt, void *fdto) if (overlay < 0) return overlay; - target = overlay_get_target(fdt, fdto, fragment, NULL); + target = fdt_overlay_target_offset(fdt, fdto, fragment, NULL); if (target < 0) return target; @@ -781,7 +766,7 @@ static int overlay_symbol_update(void *fdt, void *fdto) return -FDT_ERR_BADOVERLAY; /* get the target of the fragment */ - ret = overlay_get_target(fdt, fdto, fragment, &target_path); + ret = fdt_overlay_target_offset(fdt, fdto, fragment, &target_path); if (ret < 0) return ret; target = ret; @@ -803,7 +788,7 @@ static int overlay_symbol_update(void *fdt, void *fdto) if (!target_path) { /* again in case setprop_placeholder changed it */ - ret = overlay_get_target(fdt, fdto, fragment, &target_path); + ret = fdt_overlay_target_offset(fdt, fdto, fragment, &target_path); if (ret < 0) return ret; target = ret; diff --git a/xen/common/libfdt/version.lds b/xen/common/libfdt/version.lds index 7ab85f1d9d..cbce5d4a8b 100644 --- a/xen/common/libfdt/version.lds +++ b/xen/common/libfdt/version.lds @@ -77,6 +77,7 @@ LIBFDT_1.2 { fdt_appendprop_addrrange; fdt_setprop_inplace_namelen_partial; fdt_create_with_flags; + fdt_overlay_target_offset; local: *; }; diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index c71689e2be..fabddbee8c 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -2109,6 +2109,24 @@ int fdt_del_node(void *fdt, int nodeoffset); */ int fdt_overlay_apply(void *fdt, void *fdto); +/** + * fdt_overlay_target_offset - retrieves the offset of a fragment's target + * @fdt: Base device tree blob + * @fdto: Device tree overlay blob + * @fragment_offset: node offset of the fragment in the overlay + * @pathp: pointer which receives the path of the target (or NULL) + * + * fdt_overlay_target_offset() retrieves the target offset in the base + * device tree of a fragment, no matter how the actual targeting is + * done (through a phandle or a path) + * + * returns: + * the targeted node offset in the base device tree + * Negative error code on error + */ +int fdt_overlay_target_offset(const void *fdt, const void *fdto, + int fragment_offset, char const **pathp); + /**********************************************************************/ /* Debugging / informational functions */ /**********************************************************************/ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519846.806960 (Exim 4.92) (envelope-from ) id 1pmJWz-0000Cy-4q; Tue, 11 Apr 2023 19:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519846.806960; Tue, 11 Apr 2023 19:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJWz-0000Cp-1c; Tue, 11 Apr 2023 19:19:53 +0000 Received: by outflank-mailman (input) for mailman id 519846; Tue, 11 Apr 2023 19:19:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUb-0004DR-Au for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:25 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060f.outbound.protection.outlook.com [2a01:111:f400:7eab::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c43909a-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:23 +0200 (CEST) Received: from BN8PR04CA0065.namprd04.prod.outlook.com (2603:10b6:408:d4::39) by MW5PR12MB5598.namprd12.prod.outlook.com (2603:10b6:303:193::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:20 +0000 Received: from BN8NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:408:d4:cafe::d) by BN8PR04CA0065.outlook.office365.com (2603:10b6:408:d4::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Tue, 11 Apr 2023 19:17:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT069.mail.protection.outlook.com (10.13.176.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:19 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:19 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:19 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:18 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c43909a-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kTkfvHMw4fwZfUXsGYwMWqNK9TBfbtOjNei/7m39xnNYGph1NAu8DmaU7G6RySe+rPUyKwHKLe99naA3atslI4+AtkslwbNRuNPYKKLdJofW3MMmOnpzeJGo5XiutQUte1DlFCfhFhdj87Gq49q4IuDy+mjjnfUTiAwGt/o5zZ5/X7mij/jUiRVQ/ypK4xXSK93zZTk3/8P6pzHFzO8Mz8QipY2YO5nk4KY2Qz+AsD8VOFDR84tsR6FIQhSvNDNrtx8rgi8WPHsHHO+VA4ZP2zTUMxJMFUnRfG64qCT0S3ZwpNR+Qdc+W0XXbvCxXDG3/qaB0QWPh0Jl+kbHQyfRDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1PNAnqijXbZmLbaJTz/bnk2u6mRzrBSQaqCUQeSU5s=; b=FFOrj0o6TWzAcl90jAx+ZHpRzHGwNIn49bwTOzhpxT9xczQKuC+bOv3XbPGefV2DAUNjs8LPXlSJl7eeFxcl3Js77kcXAsjSpBo/pZ4FoAXUZluAod0dSF+4iK/AuJ9jqq+FZ5F+2w0CfPVA7EZ4T4KfIah77GdUw1DS5OspoVVRjpfVj6GivPDwnhiMA3xRShQrR80etqXS8yQrlNOZTaQGIE8hgoTJY2lTkLjnOa5fqC2hGR0lXlxwWyZmiVfUaHtO1lh3TN7b+FkSX04YJucGOjqJ0o2GNVZbQy75ZPPjLf2LMYA+6320fVpyHymJTLTV9G0wLwN/smWITJA8og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x1PNAnqijXbZmLbaJTz/bnk2u6mRzrBSQaqCUQeSU5s=; b=wuntfbt/6RBi8we1bEE2MT1iJltEJu3U0H+EIy9i2cz6kFGZok1kVKid9tZJ9YA4toycLlEjO+CWZBRQ5Ip6Z+OBgVQZJU7x0141SchJob5+X1IMGwlxoqatul6fHZdmGPXqUhYG7EPBT0MeLCz1tnHGX9EHSUVraItI7oKzduE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Date: Tue, 11 Apr 2023 12:16:30 -0700 Message-ID: <20230411191636.26926-30-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT069:EE_|MW5PR12MB5598:EE_ X-MS-Office365-Filtering-Correlation-Id: 65b4fc63-54fd-44d5-795c-08db3ac15eef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6qps8HEQfzg6wg3LtuU3NpVWgiVYlUptzQkTg/BZ9Gx9WDs1l6HDyz8G0SoDMCc7LRHWlB2Y195o8IxiFIGfe00rQ/Y3jE/uWYyf5hxB27tMEFxn1Fdd6XND800/0MYjrtNWAW/Ufrmiu+8+pVwS4GhBT71kAKdVlGPP0YQpQDVJdpnZQecPzZY7fnz0onN5GjRImXxLG4hsGswv9MCwizwqJSUGDHRyT37u9jW3d+zqsh58sUrcN42JdNpKAqqehq9UeUx+7oEyEg3VF0kkwlLlJCSooQC/+ltMLVfVL4683p2wWl0i3tyVPCV8kwcWlNj6jUBwmN56BB0sZRFDgNRhER5ttELBJ4ZW2773SZmdfgy5USZsnKt8GKjAULUjv+j7lw4iCNNri/oMGPQkPKBRdRRZ5Rj0VzcaJJsWKtXhIzIGNXUXDO2AuoJtI8NLFbnEI/S48bTKGPUdapAW+VBlIm/h/G70ED2XUZKdmmGkDdyxYKDk3l8+05eGdoSl962L8Vn6Cb3L7fvK5ZuzulOuPd2l8cho+UpIXAZQ3fwTJ3Of0NqHKN19SEO3kOS6bENVhoHroexpz2sOI75rMGp8cu/JSihG39ZB7hrL/WfXleR3Gc/hGE2a7d6jqMSK6Q8WHI6/L/kSKmd2JiJ/N3XGO02+YbtfE3pOn2KgsnxTSMlHFHGilsOflgK3M9qWL5Q3XQCshZtJ5/VRIvbzztT0cU2B2oSekLyp1Hqb1Q0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(36756003)(44832011)(82310400005)(40460700003)(2906002)(5660300002)(8936002)(86362001)(40480700001)(8676002)(26005)(6666004)(1076003)(36860700001)(54906003)(478600001)(2616005)(47076005)(336012)(426003)(83380400001)(186003)(70206006)(70586007)(81166007)(82740400003)(41300700001)(356005)(4326008)(6916009)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:19.8440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65b4fc63-54fd-44d5-795c-08db3ac15eef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598 Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host. But adding rwlock in device_tree.h causes following circular dependency: device_tree.h->rwlock.h->smp.h->asm/smp.h->device_tree.h To fix this, removed the "#include and forward declared "struct dt_device_node". Signed-off-by: Vikram Garhwal --- xen/arch/arm/include/asm/smp.h | 3 ++- xen/arch/arm/smpboot.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h index 8133d5c295..afe6129276 100644 --- a/xen/arch/arm/include/asm/smp.h +++ b/xen/arch/arm/include/asm/smp.h @@ -3,13 +3,14 @@ #ifndef __ASSEMBLY__ #include -#include #include #endif DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); +struct dt_device_node; + #define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) #define smp_processor_id() get_processor_id() diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 412ae22869..336a7d418b 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519849.806970 (Exim 4.92) (envelope-from ) id 1pmJX1-0000ZH-HL; Tue, 11 Apr 2023 19:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519849.806970; Tue, 11 Apr 2023 19:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJX1-0000Yx-Am; Tue, 11 Apr 2023 19:19:55 +0000 Received: by outflank-mailman (input) for mailman id 519849; Tue, 11 Apr 2023 19:19:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUf-0004Ta-7y for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:29 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20620.outbound.protection.outlook.com [2a01:111:f400:7eb2::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f308f27-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:28 +0200 (CEST) Received: from MW4PR03CA0028.namprd03.prod.outlook.com (2603:10b6:303:8f::33) by CH3PR12MB8996.namprd12.prod.outlook.com (2603:10b6:610:170::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:24 +0000 Received: from CO1NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::e) by MW4PR03CA0028.outlook.office365.com (2603:10b6:303:8f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35 via Frontend Transport; Tue, 11 Apr 2023 19:17:23 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT048.mail.protection.outlook.com (10.13.175.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:23 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:20 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:20 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f308f27-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THcWC/giHtyMgrprcuU0OA3pwHxXNMdUgtgLjl6l1LPlqw6WBVt+khXjjWFhmDAgzqUF7UiMdv4dI7KWtb5aoVLa/2a1Y+jNT54qVZqUfaryLTfy3bcXNi4WS7eBXNJQuMazFGshN/GyCG3iZjEDyRotCMcyl8OIon1WyMhHg3d3vSGUw7gPuRUi6ZhWQ8rrE8c/S0AnJjHAENIq/CR2R77j2thE+wXaZMe3J2JXbPoL7aTEG1RQInihHjKdcDSKDJ37nDlLMAnlAfv6ruLrQhgvrW/w4t+/8YX2QUEsp20mea+4gQ/4C9/BJmUWKVscO92M0C/s1VhjpNku0TiJ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zOQW4Omju1dTUno8ADGoDg+I28lOLIV01naa3ZWrW1o=; b=Imta5BSur4SKHpXK1OWAg6ScqRx0I/4QXi5mKvt+7uUc4PMTlrEaF+jP8s2QdCGY3pC2xjOm9jxiv/buyrsEa6FtMTjHl5AAEsMQhlXhltPJXnRQgqUMILcl8g0Q+GKiRz0imGZl257O4n9t9aPcExhjDLkTorHq7p5aL1iMQdjfAnb5iXP8Eyoo4Tr9D7V1xSoxINEhabj8mGrEd2xiU+HEL+/AiZADEq7U5y63LFYzH1pA3M5wx5WcX+fGNnJFMng58wqLLP2z0AQ16WAaoUsa1xOveF6d9rojy4kmPJV9c5NwSpaPoiV4h391VR63Gwy/Mhd9G3UsDszCym8MjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOQW4Omju1dTUno8ADGoDg+I28lOLIV01naa3ZWrW1o=; b=bVqMaj/2byuHZk9KB58ch3tZUaCTDN6A8dmi21o0MZKHRB5YR1KnXT41/CI674SqlxxK0rfv06M811p4s2tWNoY1hIV3e0C1gugQoMlb6HPEbuMlMZlO0SSLbZL2uzlxhMaMLJrfz0I6wimh4GqV1YGKtSiADK/XtU1PLmOxWl8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Date: Tue, 11 Apr 2023 12:16:31 -0700 Message-ID: <20230411191636.26926-31-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT048:EE_|CH3PR12MB8996:EE_ X-MS-Office365-Filtering-Correlation-Id: a4eb61d8-5ff6-40fc-bc5e-08db3ac16151 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HiPueW2wg3jaIMtd+UEEbXnwFPVrbmrZrGMl75Sfc/2DQnY7SCJkWLuxxLohuemFBARCMfBdCO3U3IKWJOCpKJWbUHFo+lZKF72rRQ7WmHKrCm1nrPV6jU+39VpsKIH783g/qXfZ+K3ys6k/BoC6AbXcd+5EAO5kuDLUKnEbxa5F1k9w4aYebEYTImOag5DUi50X8oVWYwtC0a9bzzVs3n+dhyRWokbof6EQ2XFh+BewN+4alARJcaE8xKzioSXJ9N9UZPKmA3E0SwyqRaZwKi+nl+aFHCaRQoHKW8VmEPfa4lTKVyjhWBQqHjOYmJ5QlKWqPwZQ0ISt1xX6o/1rkW14LZoZPq0kuLNJQ1T9yV4ORenDnYbpjb4/RjLm4gYCHYrdVBObuS/Wo1iGmXMnSQvDA8/Ou9BOAiNvanNo/YWa810hFcOc1vXjS8Zk0YcZFCWQvUHgKn0/NY2JU84vZa+7+HrnLw18HEXqYn3olKpfUyR7OBPzirk2NkSOj3DQLJEjaU8xPB8wyK99m+x2zdYg4rCEj04nDf8IR1hTzrrLXNJIaG4vRYDxhYiBWJWnTavnTYirvpBL0pXGIvTBjuRyGwOe+aezVRNvoS7B3azuwZUVecMvdphTkQbLzOHcF27V5DSQ3qsWVZW7pVi+ePwvhN/npoFLtFZs4P3gtG4TRrxykQl4smaZOcPB/KmFBWmxubxnDS6D2+hoJRabj0hE7dyjPEeZ73+6TLpsBp8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199021)(40470700004)(36840700001)(46966006)(5660300002)(40460700003)(44832011)(8936002)(26005)(1076003)(40480700001)(6666004)(83380400001)(2906002)(47076005)(36756003)(186003)(426003)(2616005)(336012)(356005)(81166007)(82740400003)(86362001)(82310400005)(36860700001)(478600001)(41300700001)(6916009)(4326008)(70206006)(8676002)(70586007)(316002)(54906003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:23.7496 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4eb61d8-5ff6-40fc-bc5e-08db3ac16151 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8996 Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 3 +++ xen/drivers/passthrough/device_tree.c | 39 +++++++++++++++++++++++++++ xen/include/xen/device_tree.h | 6 +++++ 3 files changed, 48 insertions(+) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 507b4ac5b6..b330e6a013 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2098,6 +2098,9 @@ void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) *allnextp = NULL; dt_dprintk(" <- unflatten_device_tree()\n"); + + /* Init r/w lock for host device tree. */ + rwlock_init(&dt_host->lock); } static void dt_alias_add(struct dt_alias_prop *ap, diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index a77a217f3d..74f994b9da 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -112,6 +112,8 @@ int iommu_release_dt_devices(struct domain *d) if ( !is_iommu_enabled(d) ) return 0; + read_lock(&dt_host->lock); + list_for_each_entry_safe(dev, _dev, &hd->dt_devices, domain_list) { rc = iommu_deassign_dt_device(d, dev); @@ -119,10 +121,14 @@ int iommu_release_dt_devices(struct domain *d) { dprintk(XENLOG_ERR, "Failed to deassign %s in domain %u\n", dt_node_full_name(dev), d->domain_id); + + read_unlock(&dt_host->lock); return rc; } } + read_unlock(&dt_host->lock); + return 0; } @@ -259,11 +265,15 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, spin_lock(&dtdevs_lock); + read_lock(&dt_host->lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) { + read_unlock(&dt_host->lock); + spin_unlock(&dtdevs_lock); break; @@ -272,6 +282,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, ret = xsm_assign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); if ( ret ) { + read_unlock(&dt_host->lock); + spin_unlock(&dtdevs_lock); break; @@ -287,6 +299,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, ret = -EINVAL; } + read_unlock(&dt_host->lock); + spin_unlock(&dtdevs_lock); break; @@ -295,22 +309,31 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, spin_unlock(&dtdevs_lock); if ( d == dom_io ) + { + read_unlock(&dt_host->lock); return -EINVAL; + } ret = iommu_add_dt_device(dev); if ( ret < 0 ) { printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n", dt_node_full_name(dev)); + + read_unlock(&dt_host->lock); break; } ret = iommu_assign_dt_device(d, dev); if ( ret ) + { printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\"" " to dom%u failed (%d)\n", dt_node_full_name(dev), d->domain_id, ret); + } + + read_unlock(&dt_host->lock); break; case XEN_DOMCTL_deassign_device: @@ -322,25 +345,41 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, if ( domctl->u.assign_device.flags ) break; + read_lock(&dt_host->lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) + { + read_unlock(&dt_host->lock); break; + } ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); + if ( ret ) + { + read_unlock(&dt_host->lock); break; + } if ( d == dom_io ) + { + read_unlock(&dt_host->lock); return -EINVAL; + } ret = iommu_deassign_dt_device(d, dev); if ( ret ) + { printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\"" " to dom%u failed (%d)\n", dt_node_full_name(dev), d->domain_id, ret); + } + + read_unlock(&dt_host->lock); break; default: diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 998f972ebc..b7272bbccc 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -18,6 +18,7 @@ #include #include #include +#include #define DEVICE_TREE_MAX_DEPTH 16 @@ -106,6 +107,11 @@ struct dt_device_node { struct list_head domain_list; struct device dev; + + /* + * Lock that protects r/w updates to unflattened device tree i.e. dt_host. + */ + rwlock_t lock; }; #define dt_to_dev(dt_node) (&(dt_node)->dev) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519853.806975 (Exim 4.92) (envelope-from ) id 1pmJX2-0000fQ-6Z; Tue, 11 Apr 2023 19:19:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519853.806975; Tue, 11 Apr 2023 19:19:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJX1-0000da-S4; Tue, 11 Apr 2023 19:19:55 +0000 Received: by outflank-mailman (input) for mailman id 519853; Tue, 11 Apr 2023 19:19:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUa-0004Ta-1x for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:24 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b2923f8-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:21 +0200 (CEST) Received: from BN8PR04CA0036.namprd04.prod.outlook.com (2603:10b6:408:70::49) by BY5PR12MB4259.namprd12.prod.outlook.com (2603:10b6:a03:202::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Tue, 11 Apr 2023 19:17:17 +0000 Received: from BN8NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::e1) by BN8PR04CA0036.outlook.office365.com (2603:10b6:408:70::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:17 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT010.mail.protection.outlook.com (10.13.177.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:17 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:16 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:16 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b2923f8-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrtgAUF9Ql0p+k/3sbtJEEchhDJAFMiITvM5wvWAKrtZSJIjO/6bQ2SPX+rz/sappAVESgdPQ90GX61i3lkvKAUVAagdoKWZ+qGhdSqDj+1W3M78hBsQRPDvQEuP0zOaiwjBa1WdLKRdDgiPhCNC7bL+7NzgG+8yC5lDDbPWYrska49kaV8IRd4vCiddB8YjwsNqIijO3tP21NPdOOWtFamZ7xcHO7lRokyVp79nclMttnFjF63ePo6t8QqOSnwmt1qqCp32NS001hcwr0hcwauDEZiLw26N0xIwN4FZd5VzUnZmjO5JK/NdRSiQBB0c0PYZbIfpLKjaVzyjr7nXhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hbn+9h9tF7QZlww7kr6YoDzwWCRUPyZKofdb3QDs5Ls=; b=Y7u0NYxfZCHpmoCI6mcjMl+Z5AL5PPIYLf23plUFQFvxZIu8fvLzCeXV5nbGm35DbTKpGszQ380njpPIqH+SPu84vjpMPGsP7LCTf7YNv0nTs24ijswVw0zcB7DChv87DDhAVxByw1yAvt3xPi4/5bDP73uupyKAAj6V64XzqgDyJcnz+ZgJ2beVWBHqqHR69h6DqGA1+qRJZFk1u+AgQcy5s+Pa8KYdNOo3YrjOwskLAWPNMijG7j7YiIyj5wYE0BnbwynIwd0cBCzdLKd1Y+05b3Sxw1yj4tjsaztqB8JjZSBgYRDBej2dcQO+XyLqqC3pEHhQM7oQAXYWVeFebw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hbn+9h9tF7QZlww7kr6YoDzwWCRUPyZKofdb3QDs5Ls=; b=aXEeV2TDU5sVp4LNobPoDDRxdR0iWKUUyeDVrTIdLuz4fjJq/9AdC2FfmUKyk39Fvlf/pAaRkKeyUMtPzf90H3Z5+XN2xLCDyPoyuDGBQu8nyn3di2VJMCtHSSj6p5D+5sUEqjovHkYzqqu9cnKeNlQCvHRDKnORE8FF8B25tD4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 08/17] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Date: Tue, 11 Apr 2023 12:16:27 -0700 Message-ID: <20230411191636.26926-27-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT010:EE_|BY5PR12MB4259:EE_ X-MS-Office365-Filtering-Correlation-Id: 637928ec-8ec6-4807-adc7-08db3ac15d71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CajsAvd3Asi4MY6PTH9AjYDhGuRLyIwHjUjHGwBlOXg/mHrNQQ8RiN84aM42F9kCb8Cj4tDnawyfBdVqDnZ8RqIzMiOzOKHgvctzORSeTk02QwNr0WWCWp7/nipg+IxDjTM1PVxZgOek64p3GZ0ECZa8pxSl9dSzVyRsSenGOdKrYT4DC6h1nn4k6w6rrCZTkIaSdCbsnsa0asPmvRthqP53z3EhoNruocdb7RmDD0YKlDsCRs5PVM4wPG5M5Nut1WPFnjRKr6fhVbgKYMf0toL+bjgEG7nwQm24XGmapqg+w5fIaxNCNMj+kLSfSdtG+q/oV/FHmgD9h+v7orTiVklY6RNqzL7fBSMLZtdDStxtCgky06t2z3eGSkpWLSOyUMUryUkp4c1FyvhioYctp/DV9JSIAz/DhyHtQG933bmMtu9ltETVRF1TLmEzgawRqhVELxPcHcPwxGrHYQaRrEBynCvQk2Bx/Ak8dNiZEtMD71+2iudOjcviAcCCHLOqJu9sq1wvjj4JiYka0yl/3mS/39QJvuXBIJ0ivA6qLCGID6FXgVHONDH3fATNdTiUJ7ToRHGvX6qoWnp88Gxk7fREU2zwfTgn6vxhBnCkLjc6rIPWTGoiS4OEL0gKlqfZ5pO5PcqNV6ghDbqgdt9EnYT6lh4WDOlhMIL7GcOeCSM+p21BYtPi9saJs4TL50putv3/Xj+ZBrT6cvhG2ZejYl4ByzFU7356fVcMZZO6Fg4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(46966006)(40470700004)(36840700001)(478600001)(83380400001)(86362001)(40460700003)(40480700001)(36756003)(82740400003)(81166007)(356005)(47076005)(36860700001)(336012)(2616005)(426003)(2906002)(1076003)(26005)(316002)(54906003)(186003)(44832011)(5660300002)(82310400005)(8676002)(6666004)(6916009)(8936002)(41300700001)(4326008)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:17.3574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 637928ec-8ec6-4807-adc7-08db3ac15d71 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4259 Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_lock(). Moving spin_lock to caller was done to prevent the concurrent access to iommu_dt_device_is_assigned while doing add/remove/assign/deassign. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/device_tree.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 1c32d7b50c..bb4cf7784d 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -83,16 +83,15 @@ fail: return rc; } -static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) +static bool_t + iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev) { bool_t assigned = 0; if ( !dt_device_is_protected(dev) ) return 0; - spin_lock(&dtdevs_lock); assigned = !list_empty(&dev->domain_list); - spin_unlock(&dtdevs_lock); return assigned; } @@ -213,27 +212,43 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, if ( (d && d->is_dying) || domctl->u.assign_device.flags ) break; + spin_lock(&dtdevs_lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) + { + spin_unlock(&dtdevs_lock); + break; + } ret = xsm_assign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); if ( ret ) + { + spin_unlock(&dtdevs_lock); + break; + } if ( domctl->cmd == XEN_DOMCTL_test_assign_device ) { - if ( iommu_dt_device_is_assigned(dev) ) + + if ( iommu_dt_device_is_assigned_locked(dev) ) { printk(XENLOG_G_ERR "%s already assigned.\n", dt_node_full_name(dev)); ret = -EINVAL; } + + spin_unlock(&dtdevs_lock); + break; } + spin_unlock(&dtdevs_lock); + if ( d == dom_io ) return -EINVAL; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519859.806988 (Exim 4.92) (envelope-from ) id 1pmJX3-00012Q-Ha; Tue, 11 Apr 2023 19:19:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519859.806988; Tue, 11 Apr 2023 19:19:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJX3-00011E-BM; Tue, 11 Apr 2023 19:19:57 +0000 Received: by outflank-mailman (input) for mailman id 519859; Tue, 11 Apr 2023 19:19:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUV-0004Ta-0W for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:19 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20609.outbound.protection.outlook.com [2a01:111:f400:7e8b::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77e9e886-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:16 +0200 (CEST) Received: from MW4PR04CA0265.namprd04.prod.outlook.com (2603:10b6:303:88::30) by MW4PR12MB6826.namprd12.prod.outlook.com (2603:10b6:303:20c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 11 Apr 2023 19:17:11 +0000 Received: from CO1NAM11FT019.eop-nam11.prod.protection.outlook.com (2603:10b6:303:88:cafe::78) by MW4PR04CA0265.outlook.office365.com (2603:10b6:303:88::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Tue, 11 Apr 2023 19:17:11 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT019.mail.protection.outlook.com (10.13.175.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:10 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:09 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:08 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77e9e886-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FHBwRl823hZHqaHvlJEDD9c0hgJYEYyzHw7+HTSe3zci0HAjvN2K8OG2rhN3gDvOIqw484GPO48nWzNRr6OEQuK9Ri49wrw2/uM0uPdUX+IhkHRgjy/sT1qn5ZgK0cuX7Q3w0MI0vEz/vk804UEtknUZ5UBrPxbDjalphVoPLCHCioRfVnN5oIwTgQEfcIB4Ut7Sl4EOsvPtxd3HLWA2TCcsrn6Sle4uxtbkSUfPvYTpPDaRAbM9Jaz95bgDEd6569wHV0sop2tU2CrQqk2LXQpCW6Mu+PG+7cRc3laoMxcJdn/b8XPF7ilUQp2z0N9N/XRW49A/6ySSJUDr2aCfaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hw2g30xtcvBa51vtOCCSs3IGMhpfBDNnN9dvV4fBjSk=; b=WF5a2E5cX1Cldnw4kycbLzrRT96Y2n9DabXE21Qn4h/ak9llBaQBfwceaY0HRCSLMiz6j8wDiPQ1f+Yq5ho+cTCuHrzbOb/rqT6Qy6gXdDePXr6GbPhL7hwsQZN8ZvDGO6usrEaCF2kZMwV03NNxzP49lR1GPpWhxKGM26bDuYITrcd3TRCIydSIH7QPt6sDnQYD+SPwGZAFwHfMyzQ3uTsO0l63+ohTWOlJTus0+7nVFCDj4VpgNYWzfjRLBjQY1bBLdQsJy+3J/IEX/B22ZdHHs0oQqlOgj+9ZH2pqzQMzXJgoJv9C1G7TeaOQvoyD3tCluDmp9nTfiS2+UQaKAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hw2g30xtcvBa51vtOCCSs3IGMhpfBDNnN9dvV4fBjSk=; b=S9efHmq59byr7CoVacRkxGSKidI32MJIGuyDa9VEV8CDAInJatmvdxGjc3Rpe4q6es2psc/FEi8tTa4WvVs2hZWWTNOyw87pUZeckigavYUq50NwEtYTVsEqNPJgJxj0wCTpvydY2yn7aQPfPOo3bC8twb9QrEfnSFCiR20KN+I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , "Jan Beulich" , Wei Liu , Rahul Singh , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v5 00/17] dynamic node programming using overlay dtbo Date: Tue, 11 Apr 2023 12:16:19 -0700 Message-ID: <20230411191636.26926-19-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT019:EE_|MW4PR12MB6826:EE_ X-MS-Office365-Filtering-Correlation-Id: b9d2ea11-1fd7-4bdc-b624-08db3ac1598d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mZ9k7sGiGuqKUJ2aHqC1WS7N6XihTTKyLAp3o5cybz4tyD18X3rr24xohcciAIwFxrlYRAlxC39CesC/zJfb4qVm9BifAsx13LsP7Sl0M5pf6Cr6j1LkbAX4MxIli/+6Lyt0wd006TTbvejBeOIUv4oBZW2Hma6eVB57z/E6P/xEWgu2g2oEVvqgOPvyNsUwI16tdQcnDAHa2RcAL1Ib0A240Lp66ZKKwfi4Je4s5HxsHRzlgzLE3aJWK6LppTWQ5MuVZQiWCzbi65py7+C4pIZKApOC49drEG6FS5YFGO0C0dv7FXPnV7zaWCWxfJ3+U8jI++igbm3uoBafyO5e2Sr7pa+7FzFAK/X/1ORpeQt+P0ReIC2Zynjd5Lm/btt7dRZg6HAra9sl1broasHovOeDEtj7JpB0fTNoX1zXcPmUZcOfdn75bL5d5hm8c41Tl7gI2QiDZqavzAzg00G4O71GqTtbh6y6WQEn3S6tMSLXiHdZo1SijsM1nZ3GRT6YPw3BMauYjgA1RSS6xFPsx+SFRl2ZFZJ9jwIcdLPFnbnIpCXJlBlU+DiJ/6sPx+8HDsKEj1dJjqDxBolg54cwBPBPKtWmZ5HOPSbNlY419djNaB9Jbuz6BFarfhXX88aUixCAVMl4UHtiZ9tOVt+9EWBIRf9+Kh6w9X6ckMVyJqOxeA/8X1e0ztKBUJFaBBb3rdLgLIjnJvYEiHOnaKRPbGGgW/YtcOnCZhn1HzKVH7o= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199021)(46966006)(36840700001)(40470700004)(6666004)(47076005)(2616005)(426003)(336012)(83380400001)(4326008)(40460700003)(186003)(86362001)(26005)(478600001)(2906002)(6916009)(70586007)(8676002)(82740400003)(41300700001)(70206006)(356005)(44832011)(81166007)(54906003)(36756003)(1076003)(82310400005)(316002)(8936002)(7416002)(5660300002)(36860700001)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:10.7209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9d2ea11-1fd7-4bdc-b624-08db3ac1598d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT019.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6826 Hi, The main purpose of this series to address first part of the dynamic programming i.e. making Xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/set IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt will be unflattened to a new dt_host_new 3. Extract the newly added node information from dt_host_new 4. Add the added node under correct parent in original dt_host. For removing a node: 1. Find the node with given path. 2. Check if the node is used by any of domus. Removes the node only when it's not used by any domain. 3. Removes IRQ permissions and MMIO access. 5. Find the node in dt_host and delete the device node entry from dt_host. 6. Free the overlay_tracker entry which means free dt_host_new also(created in adding node step). To map IOREQ and IOMMU during runtime, there will be another small series after this one where we will do the actual IOMMU and IRQ mapping to a running domain and will call unmap_mmio_regions() to remove the mapping. Change Log: v4 -> v5: Split patch 01/16 to two patches. One with function type changes and another with changes inside unflatten_device_tree(). Change dt_overlay xl command to dt-overlay. Protect overlay functionality with CONFIG(arm). Fix rwlock issues. Move include "device_tree.h" to c file where arch_cpu_init() is called and forward declare dt_device_node. This was done to avoid circular deps b/w device_tree.h and rwlock.h Address Michal's comment on coding style. v3 -> v4: Add support for adding node's children. Add rwlock to dt_host functions. Corrected fdt size issue when applying overlay into it. Add memory allocation fail handling for unflatten_device_tree(). Changed xl overlay to xl dt_overlay. Correct commit messages. Addressed code issue from v3 review. v2 -> v3: Moved overlay functionalities to dt_overlay.c file. Renamed XEN_SYSCTL_overlay to XEN_SYSCTL_dt_overlay. Add dt_* prefix to overlay_add/remove_nodes. Added dtdevs_lock to protect iommu_add_dt_device(). For iommu, moved spin_lock to caller. Address code issue from v2 review. v1 -> v2: Add support for multiple node addition/removal using dtbo. Replaced fpga-add and fpga-remove with one hypercall overlay_op. Moved common domain_build.c function to device.c Add OVERLAY_DTB configuration. Renamed overlay_get_target() to fdt_overlay_get_target(). Split remove_device patch into two patches. Moved overlay_add/remove code to sysctl and changed it from domctl to sysctl. Added all overlay code under CONFIG_OVERLAY_DTB Renamed all tool domains fpga function to overlay Addressed code issues from v1 review. Regards, Vikram Vikram Garhwal (17): xen/arm/device: Remove __init from function type common/device_tree: change __unflatten_device_tree() xen/arm: Add CONFIG_OVERLAY_DTB libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. libfdt: overlay: change overlay_get_target() xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree xen/smmu: Add remove_device callback for smmu_iommu ops xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller xen/iommu: protect iommu_add_dt_device() with dtdevs_lock xen/iommu: Introduce iommu_remove_dt_device() asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h common/device_tree: Add rwlock for dt_host xen/arm: Implement device tree node removal functionalities xen/arm: Implement device tree node addition functionalities tools/libs/ctrl: Implement new xc interfaces for dt overlay tools/libs/light: Implement new libxl functions for device tree overlay ops tools/xl: Add new xl command overlay for device tree overlay support SUPPORT.md | 6 + tools/include/libxl.h | 11 + tools/include/xenctrl.h | 5 + tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 48 ++ tools/libs/light/Makefile | 3 + tools/libs/light/libxl_dt_overlay.c | 71 ++ tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 + tools/xl/xl_vmcontrol.c | 52 ++ xen/arch/arm/Kconfig | 5 + xen/arch/arm/device.c | 145 ++++ xen/arch/arm/domain_build.c | 142 ---- xen/arch/arm/include/asm/domain_build.h | 2 - xen/arch/arm/include/asm/setup.h | 6 + xen/arch/arm/include/asm/smp.h | 3 +- xen/arch/arm/smpboot.c | 1 + xen/arch/arm/sysctl.c | 16 +- xen/common/Makefile | 1 + xen/common/device_tree.c | 30 +- xen/common/dt_overlay.c | 897 ++++++++++++++++++++++++ xen/common/libfdt/Makefile | 4 + xen/common/libfdt/fdt_overlay.c | 29 +- xen/common/libfdt/version.lds | 1 + xen/drivers/passthrough/arm/smmu.c | 56 ++ xen/drivers/passthrough/device_tree.c | 109 ++- xen/include/public/sysctl.h | 24 + xen/include/xen/device_tree.h | 28 +- xen/include/xen/dt_overlay.h | 59 ++ xen/include/xen/iommu.h | 2 + xen/include/xen/libfdt/libfdt.h | 18 + 31 files changed, 1595 insertions(+), 187 deletions(-) create mode 100644 tools/libs/ctrl/xc_dt_overlay.c create mode 100644 tools/libs/light/libxl_dt_overlay.c create mode 100644 xen/common/dt_overlay.c create mode 100644 xen/include/xen/dt_overlay.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:19:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519861.806993 (Exim 4.92) (envelope-from ) id 1pmJX4-00019e-2w; Tue, 11 Apr 2023 19:19:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519861.806993; Tue, 11 Apr 2023 19:19:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJX3-00017T-Q5; Tue, 11 Apr 2023 19:19:57 +0000 Received: by outflank-mailman (input) for mailman id 519861; Tue, 11 Apr 2023 19:19:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUR-0004Ta-Vq for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:15 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20615.outbound.protection.outlook.com [2a01:111:f400:7eaa::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76edfa86-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:14 +0200 (CEST) Received: from BN9P221CA0020.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::32) by BY5PR12MB4322.namprd12.prod.outlook.com (2603:10b6:a03:20a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:11 +0000 Received: from BN8NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::eb) by BN9P221CA0020.outlook.office365.com (2603:10b6:408:10a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Tue, 11 Apr 2023 19:17:10 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT113.mail.protection.outlook.com (10.13.176.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:10 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:07 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:07 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:07 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76edfa86-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E8b/gdsp9EhJpwqEqWnSuieF6eymTrNe7CZCQIhNlXPnI9rbzaQ9wvtKtsjf8kP5i3R8URY/xdnXA4z5xpo6gHBEMWaxZykiVSxkS5IX9GPzCVHxrsWjarIu4i2Gai1OZW1LhqjKfQ3613hbwJtVwcHRkvsqrjZQMhmB1zr+3fL7NYtkYjn/O/lE3EtnFmvqnRpqZjW2HhvCO8FLrJFTjXGgjdfpCxF+iPM1wo6kyd6vUyRKgOAiYIQGCBzoEf0Qa6jDfyC4ZMVRSiSGssuo3vgTR2fcrzTK+5aDDiUAsT2QnfwW7VVz06WpZOzG8MrZh1Rzisa1hHvAHTmyd6+Ukw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91E2KEtRfiC4xks88DcPT08G46pT034ykx3UwRRlezk=; b=nxIqwyEEBoGjZ2Kuiet6/zxQ1rXzFTD9+Tb8gozYJ/K69DjIujomDliSsWjN6KFcbMnN2aGkwTczNRgYS6wjhAw1GVWvCHbB877FDdlw/Z7ryiq0f0E0TkFr6zwbr6c+9/31vEwBGNPKAdGpMRl/1MRnkUrrkz2ExOW5z/Z0zUwocZDZe/bCYvRT+gZkSJQEFXS9Co2Di9Fi9PdJNEPQh4Q9FWsxvw/v6dOeJyMpOK92Qi76t4Up2UXXyPumbKQtuUsjFySgj4hkfiGchNgMjtqJzNIDEQ6BlcddYezacJLktwxN2ZYOhv3OVqVhnjwCzVsVvyy5irVapGD5gnheKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91E2KEtRfiC4xks88DcPT08G46pT034ykx3UwRRlezk=; b=Mlr/+9OeakKs1WY2xZ18xA0mf8IJHjFeJSeRCQ20Q0zD8LVeRq1TGn30xKGU8oa4JxImKkmgn4JGZaMnjvON9eZpaV/sVxo6PY/uIkYeMQfwhCSOKw8PW/xN+uEztqYsTT2xIFp0708WEh0TgXAcyESUMJ/qgIrlxY3WqsNsi6o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v5 16/17] tools/libs/light: Implement new libxl functions for device tree overlay ops Date: Tue, 11 Apr 2023 12:16:17 -0700 Message-ID: <20230411191636.26926-17-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT113:EE_|BY5PR12MB4322:EE_ X-MS-Office365-Filtering-Correlation-Id: f399bca7-e537-444f-ca75-08db3ac15925 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K+t5V2+TAUOZSEpGSwWXK//7mVQ+/eyBcdLVEKdtEN4WY/OiGfcf1/gyhYIYcIO+xc2Z7SKl80+536Xeh5lp8rzwgmEG+EG1jTi+Dc0f7A5bykEp6HZNuGr4lWbKv/EtVCJdoFEo8wFwiEixU7By7P0fVXx77hwcPYNUCbnNTvhi4G3SB0PBW/wO19rtokte+XM11+gBEn3zZLSuFoIrdn97DHMFYsLdHHXCNCittTwO1WBOKmJPPZWZG6KA7wHnG8RYBi22flUwZQtwFON5Hv6xc2GS+LmOAlQsq3MSkv6Et51WAhgS6vECFMCqK+g7NSO5gvOm5emZJmtZTbipCt/XJ/VfOBh4Oa0djPeXy7z7gAgQqYxYVbz7N0Nuv3zzlGhZGDoQHxYkDAj4MNPHjlLD2z2CO2u/I8yj5k9ensKm4kjHEvBsvwLu2yiDG2oOYcvP7DfwpkT3fzXLKr1X6wKEXFe6tZv9rv5pz9WAzKXzusNAXLtYbtLK98MfTMptlzToh300Tn8FXSC3hHdECNcZfnPYVizzo/ogVgkdudl1bnIT1gI2jcjL7rKGZEXwY6i1IcLpLD37kdpYHv8szq26znZyba7r1Ca3/pdwXujCrw2C6froyU9xQXa4UdpI7Fh86Axdin70rTa6Hnd/Uv7KoVvjilC8Mzrj+v/lshuDw2ue+66wdjmcpghqxa2/+reQkMaVbByvXO+5tG6+1jiyC12STT/1S0UlEImC/76aPg8EpW7OH3jfEVSOg3NG X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199021)(36840700001)(46966006)(40470700004)(8936002)(5660300002)(44832011)(82310400005)(41300700001)(70206006)(70586007)(40460700003)(4326008)(8676002)(6916009)(316002)(2906002)(478600001)(54906003)(6666004)(36756003)(86362001)(40480700001)(1076003)(26005)(2616005)(336012)(426003)(186003)(356005)(81166007)(82740400003)(47076005)(36860700001)(2004002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:10.1336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f399bca7-e537-444f-ca75-08db3ac15925 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4322 Signed-off-by: Vikram Garhwal --- tools/include/libxl.h | 11 +++++ tools/libs/light/Makefile | 3 ++ tools/libs/light/libxl_dt_overlay.c | 71 +++++++++++++++++++++++++++++ 3 files changed, 85 insertions(+) create mode 100644 tools/libs/light/libxl_dt_overlay.c diff --git a/tools/include/libxl.h b/tools/include/libxl.h index cfa1a19131..1c5e8abaae 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -250,6 +250,12 @@ */ #define LIBXL_HAVE_DEVICETREE_PASSTHROUGH 1 +#if defined(__arm__) || defined(__aarch64__) +/** + * This means Device Tree Overlay is supported. + */ +#define LIBXL_HAVE_DT_OVERLAY 1 +#endif /* * libxl_domain_build_info has device_model_user to specify the user to * run the device model with. See docs/misc/qemu-deprivilege.txt. @@ -2453,6 +2459,11 @@ libxl_device_pci *libxl_device_pci_list(libxl_ctx *ctx, uint32_t domid, int *num); void libxl_device_pci_list_free(libxl_device_pci* list, int num); +#if defined(__arm__) || defined(__aarch64__) +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay, + uint32_t overlay_size, uint8_t overlay_op); +#endif + /* * Turns the current process into a backend device service daemon * for a driver domain. diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 96daeabc47..563a1e8d0a 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,9 @@ OBJS-y += _libxl_types.o OBJS-y += libxl_flask.o OBJS-y += _libxl_types_internal.o +# Device tree overlay is enabled only for ARM architecture. +OBJS-$(CONFIG_ARM) += libxl_dt_overlay.o + ifeq ($(CONFIG_LIBNL),y) CFLAGS_LIBXL += $(LIBNL3_CFLAGS) endif diff --git a/tools/libs/light/libxl_dt_overlay.c b/tools/libs/light/libxl_dt_overlay.c new file mode 100644 index 0000000000..a6c709a6dc --- /dev/null +++ b/tools/libs/light/libxl_dt_overlay.c @@ -0,0 +1,71 @@ +/* + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ +#include "libxl_internal.h" +#include +#include + +static int check_overlay_fdt(libxl__gc *gc, void *fdt, size_t size) +{ + int r; + + if (fdt_magic(fdt) != FDT_MAGIC) { + LOG(ERROR, "Overlay FDT is not a valid Flat Device Tree"); + return ERROR_FAIL; + } + + r = fdt_check_header(fdt); + if (r) { + LOG(ERROR, "Failed to check the overlay FDT (%d)", r); + return ERROR_FAIL; + } + + if (fdt_totalsize(fdt) > size) { + LOG(ERROR, "Overlay FDT totalsize is too big"); + return ERROR_FAIL; + } + + return 0; +} + +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay_dt, uint32_t overlay_dt_size, + uint8_t overlay_op) +{ + int rc; + int r; + GC_INIT(ctx); + + if (check_overlay_fdt(gc, overlay_dt, overlay_dt_size)) { + LOG(ERROR, "Overlay DTB check failed"); + rc = ERROR_FAIL; + goto out; + } else { + LOG(DEBUG, "Overlay DTB check passed"); + rc = 0; + } + + r = xc_dt_overlay(ctx->xch, overlay_dt, overlay_dt_size, overlay_op); + + if (r) { + LOG(ERROR, "%s: Adding/Removing overlay dtb failed.", __func__); + rc = ERROR_FAIL; + } + +out: + GC_FREE; + return rc; +} + -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:20:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:20:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519868.807010 (Exim 4.92) (envelope-from ) id 1pmJX7-0001tn-Pm; Tue, 11 Apr 2023 19:20:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519868.807010; Tue, 11 Apr 2023 19:20:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJX7-0001tT-HI; Tue, 11 Apr 2023 19:20:01 +0000 Received: by outflank-mailman (input) for mailman id 519868; Tue, 11 Apr 2023 19:19:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUh-0004Ta-FG for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:31 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20631.outbound.protection.outlook.com [2a01:111:f400:7eab::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80933d9d-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:30 +0200 (CEST) Received: from BN7PR02CA0032.namprd02.prod.outlook.com (2603:10b6:408:20::45) by MW4PR12MB5667.namprd12.prod.outlook.com (2603:10b6:303:18a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Tue, 11 Apr 2023 19:17:26 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:20:cafe::27) by BN7PR02CA0032.outlook.office365.com (2603:10b6:408:20::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 19:17:26 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:26 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:23 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:23 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80933d9d-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJ0O6GHtiT21f4jamG/1nkPHCqa4FcTuvEoiZY7rnNzRVvZcMWqD+22gBPXrCKVZRbuhqzacuoSI40GoahdOs9YmS1GUW5+yVMr/ZuE/dTYJdv8Jv5NNTEJgukvDUr4a9yAD3cmLLDo21ymy8VNH2GtsPC5m4+aNyWl+PlH0v3MgXFDrZ4cxMi45wX2y05e/FdpGkGLOA573pcDtxRkZ/CJe9pYbdh5JC46HIJLI0Fij2qLWr5/Ti/FRgDc4OB5t9wCMzA9hykIEg+4d0EVWwvnHFKXAXAfcJdm56KTciJjx6ZOZE+MBDg2chC1GRaEzxa8wIwoc1fqOnOA6wDFltw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91E2KEtRfiC4xks88DcPT08G46pT034ykx3UwRRlezk=; b=Uxtz+1EHP7Es6fMd/EjL8S02P7I1hCuklZeceuPRvGkwc418ulHBVILrSdEbq2w4q59M5OA9jDTiy23+Ri6lwJtN4HRAKnhN7O8U1zaro/ZMdCNAw6ym0zTH20WiDj+RiI3/VD7eQ3MdaI8WZc2aHI0O12VpkNTrYocifrJHBWASnr73YLEAD4EioXEyhETX790iFZ41oRe7YM0SQQuEnT6JqP9Hz3FraOoVouW8t0qT/Z/phjJzjL7A7CxPhyeAZu2PiibxbekpY0qokVbEc8GbGzR8caiRTwIIr/npCXSPFMc9nNUV9L78rvMXRXVSoUhnmgRrXKZpmrMfOz3LkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91E2KEtRfiC4xks88DcPT08G46pT034ykx3UwRRlezk=; b=jiBfdo0psJ+gincF4tYwny/wZE4YYqB+6weFDtEz4RDwWLvG1btBljprsLUqj7qRKvmdPI0tVipKGrL5HCSTJodkdK7Wum/AeI1WkuOse3Yuh+L8rqsvyudOZPx1cgMZ+NwJH9bS9/63FzMuLOe5hqM9bJkKmMMcC+uA+zTfq6c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v5 16/17] tools/libs/light: Implement new libxl functions for device tree overlay ops Date: Tue, 11 Apr 2023 12:16:35 -0700 Message-ID: <20230411191636.26926-35-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|MW4PR12MB5667:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a392f45-94a7-4efa-ba31-08db3ac162ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0zobVB8q1qtHq3f8MXBx+n29ojXpLxjihYItaqooTtF8rfKBKAgmA5h2vRJvDxizfMIzSGZ3LBBi1Gb+MQGRui+yi3I327vpPoiHA6f8qRPbFOUhXncHvsUavOxX9l0rF815NWNH3APr3iVo1sRHaBdWhaJuul3bnVEZFvD2MjkSS5yjlYSU3HYX3I1otNAeam3xZ+VQHgQdniUUZ7ZHubJvg7zP3EU3cgzNGi3bJvz1Pv9FJRfVd+aas3ck15keQ8uZUdWwNCkT1H4pEHPGB2R0qlAq5pIzkI/k0EkHc7som6HxPQ32GAnSYTnJ/DTfDOCwvWqEZaofe51SkyeS2TUKVJMohIdXu1mMnZWX6iacg+USLyWny7QAat1VGwpWSV3apZubruWU4t1zDRqeJbBnopkKvUAvQfDUtD6f8XadAllpbvEVe5RzykvQvsAEY16aTGK1fdjpkA6RwQSPMdwLn4muAScMkEUvl93iubdM1r5awDcl3syKXHzdB5nFVpz4NXS7tdmH2uXP7hoXWQDhsdMr1mbV8qPafbv02S4k1nlOgSOlgBu1cBAsx+Lz036WMSxCSaJ9a/8BAqZgzynCiHx8Sxs07e9phhWHsmNXl+jbVvzSFMLr1XS7NTPugI+zeP1gvUBnN661TojN3pliFUBfvmcWhh7t1jnLmgc6gp1908WNuDkzEA2CsBI5nTZPJHa/9v0+Qh+bbdbuEn58S/Dawz7ZFuo1d4Ar3xI99rq912bMGpKJbziARJl6 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(36756003)(44832011)(82310400005)(40460700003)(2906002)(5660300002)(8936002)(86362001)(40480700001)(8676002)(26005)(6666004)(1076003)(36860700001)(54906003)(478600001)(2616005)(47076005)(336012)(426003)(186003)(70206006)(70586007)(81166007)(82740400003)(41300700001)(356005)(4326008)(6916009)(316002)(2004002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:26.1174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a392f45-94a7-4efa-ba31-08db3ac162ac X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5667 Signed-off-by: Vikram Garhwal --- tools/include/libxl.h | 11 +++++ tools/libs/light/Makefile | 3 ++ tools/libs/light/libxl_dt_overlay.c | 71 +++++++++++++++++++++++++++++ 3 files changed, 85 insertions(+) create mode 100644 tools/libs/light/libxl_dt_overlay.c diff --git a/tools/include/libxl.h b/tools/include/libxl.h index cfa1a19131..1c5e8abaae 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -250,6 +250,12 @@ */ #define LIBXL_HAVE_DEVICETREE_PASSTHROUGH 1 +#if defined(__arm__) || defined(__aarch64__) +/** + * This means Device Tree Overlay is supported. + */ +#define LIBXL_HAVE_DT_OVERLAY 1 +#endif /* * libxl_domain_build_info has device_model_user to specify the user to * run the device model with. See docs/misc/qemu-deprivilege.txt. @@ -2453,6 +2459,11 @@ libxl_device_pci *libxl_device_pci_list(libxl_ctx *ctx, uint32_t domid, int *num); void libxl_device_pci_list_free(libxl_device_pci* list, int num); +#if defined(__arm__) || defined(__aarch64__) +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay, + uint32_t overlay_size, uint8_t overlay_op); +#endif + /* * Turns the current process into a backend device service daemon * for a driver domain. diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 96daeabc47..563a1e8d0a 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,9 @@ OBJS-y += _libxl_types.o OBJS-y += libxl_flask.o OBJS-y += _libxl_types_internal.o +# Device tree overlay is enabled only for ARM architecture. +OBJS-$(CONFIG_ARM) += libxl_dt_overlay.o + ifeq ($(CONFIG_LIBNL),y) CFLAGS_LIBXL += $(LIBNL3_CFLAGS) endif diff --git a/tools/libs/light/libxl_dt_overlay.c b/tools/libs/light/libxl_dt_overlay.c new file mode 100644 index 0000000000..a6c709a6dc --- /dev/null +++ b/tools/libs/light/libxl_dt_overlay.c @@ -0,0 +1,71 @@ +/* + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ +#include "libxl_internal.h" +#include +#include + +static int check_overlay_fdt(libxl__gc *gc, void *fdt, size_t size) +{ + int r; + + if (fdt_magic(fdt) != FDT_MAGIC) { + LOG(ERROR, "Overlay FDT is not a valid Flat Device Tree"); + return ERROR_FAIL; + } + + r = fdt_check_header(fdt); + if (r) { + LOG(ERROR, "Failed to check the overlay FDT (%d)", r); + return ERROR_FAIL; + } + + if (fdt_totalsize(fdt) > size) { + LOG(ERROR, "Overlay FDT totalsize is too big"); + return ERROR_FAIL; + } + + return 0; +} + +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay_dt, uint32_t overlay_dt_size, + uint8_t overlay_op) +{ + int rc; + int r; + GC_INIT(ctx); + + if (check_overlay_fdt(gc, overlay_dt, overlay_dt_size)) { + LOG(ERROR, "Overlay DTB check failed"); + rc = ERROR_FAIL; + goto out; + } else { + LOG(DEBUG, "Overlay DTB check passed"); + rc = 0; + } + + r = xc_dt_overlay(ctx->xch, overlay_dt, overlay_dt_size, overlay_op); + + if (r) { + LOG(ERROR, "%s: Adding/Removing overlay dtb failed.", __func__); + rc = ERROR_FAIL; + } + +out: + GC_FREE; + return rc; +} + -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:20:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:20:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519874.807016 (Exim 4.92) (envelope-from ) id 1pmJX8-0001zM-Ch; Tue, 11 Apr 2023 19:20:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519874.807016; Tue, 11 Apr 2023 19:20:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJX8-0001y6-0c; Tue, 11 Apr 2023 19:20:02 +0000 Received: by outflank-mailman (input) for mailman id 519874; Tue, 11 Apr 2023 19:20:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUY-0004Ta-1E for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:22 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20613.outbound.protection.outlook.com [2a01:111:f400:7e89::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a4ad9dd-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:20 +0200 (CEST) Received: from BN8PR04CA0029.namprd04.prod.outlook.com (2603:10b6:408:70::42) by PH0PR12MB8029.namprd12.prod.outlook.com (2603:10b6:510:26c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:17 +0000 Received: from BN8NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::9a) by BN8PR04CA0029.outlook.office365.com (2603:10b6:408:70::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 19:17:16 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT010.mail.protection.outlook.com (10.13.177.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:16 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:15 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:15 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a4ad9dd-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BzNQr2SLdVAdJZYxI0PgizBtvdz3yZFN10NELXNrTWTkU1yT4d7zyT2qsaTk80El/bDeQAg3eLkaD6zK0YlyCxErvuB/hbDhLaivuG8jpOszKOszktekyI3kO8ueiyKjr7s5QNyI2rzQzJ+sXp6OSRorFiWNigWWaprbhjv3b/+vafq6IZpGAMksC4MW+YAg9Fmg7pJujgMRO7dKME+DIDnkp+Bnh95+Xlx/BShiu0fJ+tZBeSBo6n3ILgNw9CSpRaEAPUvaAtlMjZmoc8vFZ6MU0sGKeeJsfHT5Ho+zmWY6stgP0Bn6XxUhiF7gsBD+qrQwW71ya+Icczl+7tRoQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SvjprfsFjT2q+G0BBsMISOBPht18qx5Ov6rcUISgUjE=; b=nkBUXiMU6lIQQwpdxAbfbWFCZ6TYiWvoM8erBKwAbx7S7ytEd1CkM3YMbbLQHGkM+/D2+jQEt1iaI/Wh9ulQRjrDj+9WNz7nUgYw1JRrnBfgMBsUKx2YcgxX+jxfzRkFsiKuvv1A/BcAg0emVYelnD2g0leMjx+sVgecT7fJwv+tuNkr36z3t5wE3KYcIHOPIcWigW2ZZ+yU1/0AmdWv6xPczWDvFG21vHld3xEciPzBvKFR7bYDvB17YUmic+s2doVAodUrVQwedABB5GeLL/o6UdHMU+vZ3d+8VdnZ4138SitgcnGQcrvrhyaUTBIoamUCqGLJ5iO6VWITMa/kEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SvjprfsFjT2q+G0BBsMISOBPht18qx5Ov6rcUISgUjE=; b=Ly+lUQ0+M/IUp+B4OQS8qNOM8TYaB5uasdcrjoYspgz20WyS/UPD0htASwL6rO45lrVjKtv8zb6YxuNzTMM1uTmjU0flvEfsxmBavxHdB/ufDqqEZWLLSAFmnaLL+IjjgPzHVDv/wtlfuCX/w5b2upQNQONkaX8hn9CWp9zKrug= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Rahul Singh , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v5 07/17] xen/smmu: Add remove_device callback for smmu_iommu ops Date: Tue, 11 Apr 2023 12:16:26 -0700 Message-ID: <20230411191636.26926-26-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT010:EE_|PH0PR12MB8029:EE_ X-MS-Office365-Filtering-Correlation-Id: 50790be0-6352-4be7-7b8f-08db3ac15cdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mAFf3vbwh8xgKfEkCpsPWufkJqzgszk8dRjmBqwJbNWlxJ+4MaLJCrh3ccDNlcLfayxl9wcH/xmIKVAon8eO33lB0xgU9U/mor0WczGDwNKR83kQdcfRIWBJoTm5tvf676K0Yg5hTKLKUUHJo69ZZ60lOLw2LeRT1zUJC/d3aXabjaQ47+PkrR5xRMsAY9mxb4XXREnJS2IKVeE0zjlkyJOSrktcywagpler50PR5tZCgeGKw+16N/Nf9ynCTBAUzF0/7UOm+Ey8dTNW0WDjnsrkoj+h44NAWDnlQ/6Giwl4Y+7PwmCvUUR9Z0ZlMsEfcy+5aoGNqM3WESMk+CSupsa1o2EPANS9moVe/epI1meG7z4vn3CcSAdraj1xoP2gaXUcMGV1avcP46Wsj9MBpxB+6QuUIw16OGnTafMmWuyVeigwyN0+plpQAiOBvz5I7QNEJuQyymxLF7yjcmpG9mbkf6mb9WxpW16MF5cu/0GP04gsRdDyXHaK9gkGhQ71n+sVvZT9utYjYXMUoIZB+3S3BdHO/WE0p9hEtyUDthLPRqx+skjdOhOVdgMus8lxMtzsPFH/mlauhsMLCyXE5t0Xet9Kz8iQDLKEUlVzHK3LnZePD5pWg5QRmmoDnbwMkiIuylXMQdCnYMRUTPJ6lI69oxCT6V2edfu5EHECe2G7J58mNFTUsGGZjjRdvMaLqkljziga/kiAm/tydIdQBCPQSpD6whYnqMsIZgNgYFM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199021)(36840700001)(46966006)(40470700004)(82310400005)(2906002)(5660300002)(8936002)(41300700001)(47076005)(40460700003)(4326008)(8676002)(6916009)(70586007)(70206006)(6666004)(316002)(36756003)(44832011)(478600001)(54906003)(186003)(81166007)(86362001)(36860700001)(356005)(26005)(336012)(426003)(2616005)(1076003)(82740400003)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:16.3575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50790be0-6352-4be7-7b8f-08db3ac15cdb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8029 Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Remove the SMMU master Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/arm/smmu.c | 56 ++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3..14e15f1bc6 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -816,6 +816,19 @@ static int insert_smmu_master(struct arm_smmu_device *smmu, return 0; } +static int remove_smmu_master(struct arm_smmu_device *smmu, + struct arm_smmu_master *master) +{ + if (!smmu->masters.rb_node) { + ASSERT_UNREACHABLE(); + return -ENOENT; + } + + rb_erase(&master->node, &smmu->masters); + + return 0; +} + static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, struct device *dev, struct iommu_fwspec *fwspec) @@ -853,6 +866,32 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, return insert_smmu_master(smmu, master); } +static int arm_smmu_dt_remove_device_legacy(struct arm_smmu_device *smmu, + struct device *dev) +{ + struct arm_smmu_master *master; + struct device_node *dev_node = dev_get_dev_node(dev); + int ret; + + master = find_smmu_master(smmu, dev_node); + if (master == NULL) { + dev_err(dev, + "No registrations found for master device %s\n", + dev_node->name); + return -EINVAL; + } + + ret = remove_smmu_master(smmu, master); + + if (ret) + return ret; + + dev_node->is_protected = false; + + kfree(master); + return 0; +} + static int register_smmu_master(struct arm_smmu_device *smmu, struct device *dev, struct of_phandle_args *masterspec) @@ -876,6 +915,22 @@ static int register_smmu_master(struct arm_smmu_device *smmu, fwspec); } +static int arm_smmu_dt_remove_device_generic(u8 devfn, struct device *dev) +{ + struct arm_smmu_device *smmu; + struct iommu_fwspec *fwspec; + + fwspec = dev_iommu_fwspec_get(dev); + if (fwspec == NULL) + return -ENXIO; + + smmu = find_smmu(fwspec->iommu_dev); + if (smmu == NULL) + return -ENXIO; + + return arm_smmu_dt_remove_device_legacy(smmu, dev); +} + static int arm_smmu_dt_add_device_generic(u8 devfn, struct device *dev) { struct arm_smmu_device *smmu; @@ -2858,6 +2913,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = { .init = arm_smmu_iommu_domain_init, .hwdom_init = arch_iommu_hwdom_init, .add_device = arm_smmu_dt_add_device_generic, + .remove_device = arm_smmu_dt_remove_device_generic, .teardown = arm_smmu_iommu_domain_teardown, .iotlb_flush = arm_smmu_iotlb_flush, .assign_device = arm_smmu_assign_dev, -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:20:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:20:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519877.807028 (Exim 4.92) (envelope-from ) id 1pmJXA-0002g0-Tq; Tue, 11 Apr 2023 19:20:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519877.807028; Tue, 11 Apr 2023 19:20:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJXA-0002fC-Ko; Tue, 11 Apr 2023 19:20:04 +0000 Received: by outflank-mailman (input) for mailman id 519877; Tue, 11 Apr 2023 19:20:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUc-0004Ta-Ky for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:26 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on20627.outbound.protection.outlook.com [2a01:111:f400:7e83::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7dc924f3-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:26 +0200 (CEST) Received: from MW4PR03CA0021.namprd03.prod.outlook.com (2603:10b6:303:8f::26) by PH0PR12MB5419.namprd12.prod.outlook.com (2603:10b6:510:e9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Tue, 11 Apr 2023 19:17:23 +0000 Received: from CO1NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::8e) by MW4PR03CA0021.outlook.office365.com (2603:10b6:303:8f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:23 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT048.mail.protection.outlook.com (10.13.175.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:22 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:18 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 12:17:18 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:17 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dc924f3-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mc7+AWllmzix4mhii1U8rnfn6L8ASn96uvHv2soW2G7oS/3cPcG/WPHUuDLB+gHbOMNpDcX5jRXZqCgLhpusyEg1R0n+mz/yllTm5QaeY4RI32zVz4/gYMdFKTJKM1aSfofl01QwWJ60BIb5tzqUHYHmw2+LokFw44QIaOMTEccm+xh/MP4D6Mr2c0WftqUjLDtMZuFXUbW1dP573ft+kB+iOw8Uec9EU+SgqOkjEmleM400hkhMhM1xTVs1yzcTwh8cv/23Fibu5oHI/h5g6ToYlPm1PWlzi/cXlBbGWYHRZTJ4Et9UEnxpUwGWGtm91S/vxOibgh5Reu43WmfIUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gLWShZkghSoju5aCTSrHjPTktEFI3gdZrQ2ShX60hx0=; b=ZzvG+mK/iy4AgUZDTYFPIQYPZO+KAPqS1wjw2S3ySjkMCrDPW/p7P0Pb9tYbfao7N2wXlSB+GOhajUT1r93LBMrYMaOStDb2tWPzI1R0WOlD2uNAFRdBX/nd4IY8s/4ELcLxSCcTfOUBOWR8olwMUeKCZ12nCKQlN2Z/0tPfdDw05IlQHVJA5ojUFqjObsvOzDxxicj2mBS9V+asAN7T7vGq1+42BEvVUnrPd3H8jN/pln2atHXnmNF6xB57s6Oz0oW80KFunQ8oA34qGYuswx/4ZWg52NjAa/27D57vY+zFiyoq9ZOx5T/F1ZoYLY9KF5aDQg10Mv/Dn3cK+QCDVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLWShZkghSoju5aCTSrHjPTktEFI3gdZrQ2ShX60hx0=; b=KVktFdAFizbAL/V23oXfjwGQ1VwQmvuLOLNg9ydmkLqePyqfEfZtuz9SgQnQ3IGivyHAElCOHj9+oLQza55PUBKSr1IglMdUNBPbvmbJZ0zY59ftKxbgf49iWnuXKBY0p2zGrDCylHIKyzQ/gfZDtc+nt8cYRs7fhLIAcfwjGUk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN][PATCH v5 10/17] xen/iommu: Introduce iommu_remove_dt_device() Date: Tue, 11 Apr 2023 12:16:29 -0700 Message-ID: <20230411191636.26926-29-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT048:EE_|PH0PR12MB5419:EE_ X-MS-Office365-Filtering-Correlation-Id: 6efa7f57-ca98-45af-4f83-08db3ac160c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9q1fBSp1v32ZaZSlxWE5iV198r5t8GU1JGK5iYoab7v6pemY0mVsLrBfn3g3VIFB+ZSQeujLUZ9GW0FrxRlTMlchWsvewHOZF8yrhIrEucnfpn4+KA9W2R5ZvXMlIfrd8QPZzs2Gck1ubm3WL0SbOe5FbHeVHi5DFRWO0LRfN8m1oKh6WguUgZF19ZQ8yjHqSmHEpt7WnWGL9OSUamL9m9t9z53G88xg96P6nnkUCkjLmhyBq/lA8gflXEfMAXNgI6BSWXo0817OFAar17z0qEkXP0siB+Jittc3yAtJPsLuihLnllrhjOjZzttP4/NaUCOShrajkPSXmVEMM2zaqnUWZ5EufNFS4NVEqqutDC7y+m8ILU4iLtPdq5CTFf51CrrXc+eaxZKyx1UghtgQOqucUCkY8lgDEv3Mjpy0zVCb2n5cgoWDtSUNYcEGdqzow+n6uVl38+8AEoWXjMdEsd0Z8kz4NJ6guUKHMgmEk4uOj1lG339ZbES9JzzTqfoJWqExFGTlNBk00PGOs15RDv2ArSC/ZjN61mGL56Bu77qclZqQqIwZN3c03bJCo0AjvIQl9OSx7UJPGoqclZEsRfVrpNz+5MYCSvEStuGF0HAgwqGcU6smopMuGzBx4N6dUNB1H0DMqDnDqH/CmkOhJSPcCkAbasO1aeOr9qiXSZOO5yTaz/aAV/1180qKkVw4BCdR74iZ4fR4pPPZn0njt3mA1CNd+NPtSbNRVLB8YOk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(70206006)(478600001)(54906003)(70586007)(4326008)(6916009)(8676002)(41300700001)(316002)(86362001)(36756003)(83380400001)(426003)(2616005)(336012)(26005)(1076003)(6666004)(8936002)(2906002)(44832011)(40480700001)(5660300002)(82310400005)(36860700001)(82740400003)(356005)(186003)(81166007)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:22.7966 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6efa7f57-ca98-45af-4f83-08db3ac160c0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5419 Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal --- xen/drivers/passthrough/device_tree.c | 38 +++++++++++++++++++++++++++ xen/include/xen/iommu.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 457df333a0..a77a217f3d 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -126,6 +126,44 @@ int iommu_release_dt_devices(struct domain *d) return 0; } +int iommu_remove_dt_device(struct dt_device_node *np) +{ + const struct iommu_ops *ops = iommu_get_ops(); + struct device *dev = dt_to_dev(np); + int rc; + + if ( !ops ) + return -EOPNOTSUPP; + + spin_lock(&dtdevs_lock); + + if ( iommu_dt_device_is_assigned_locked(np) ) + { + rc = -EBUSY; + goto fail; + } + + /* + * The driver which supports generic IOMMU DT bindings must have + * these callback implemented. + */ + if ( !ops->remove_device ) + { + rc = -EOPNOTSUPP; + goto fail; + } + + /* Remove master device from the IOMMU if latter is present and available. */ + rc = ops->remove_device(0, dev); + + if ( !rc ) + iommu_fwspec_free(dev); + +fail: + spin_unlock(&dtdevs_lock); + return rc; +} + int iommu_add_dt_device(struct dt_device_node *np) { const struct iommu_ops *ops = iommu_get_ops(); diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 405db59971..079c06321e 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -218,6 +218,8 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev); int iommu_dt_domain_init(struct domain *d); int iommu_release_dt_devices(struct domain *d); +int iommu_remove_dt_device(struct dt_device_node *np); + /* * Helper to add master device to the IOMMU using generic IOMMU DT bindings. * -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:20:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519883.807039 (Exim 4.92) (envelope-from ) id 1pmJXD-0003M8-K3; Tue, 11 Apr 2023 19:20:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519883.807039; Tue, 11 Apr 2023 19:20:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJXD-0003LY-Ev; Tue, 11 Apr 2023 19:20:07 +0000 Received: by outflank-mailman (input) for mailman id 519883; Tue, 11 Apr 2023 19:20:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUk-0004DR-CY for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:34 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20620.outbound.protection.outlook.com [2a01:111:f400:fe59::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80294892-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:30 +0200 (CEST) Received: from BN7PR02CA0032.namprd02.prod.outlook.com (2603:10b6:408:20::45) by CH0PR12MB8505.namprd12.prod.outlook.com (2603:10b6:610:193::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 19:17:27 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:20:cafe::fb) by BN7PR02CA0032.outlook.office365.com (2603:10b6:408:20::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 19:17:27 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:26 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:24 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80294892-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bXcp6be5EOxaRQCLBYG53j+05Hu7TinVPhvIYfE9gJxAavjYLIKc6/7NioHLDCrcurhEiJ8Z2L+kT8x8gZErqZHQveFz/ruJQC4QkbuQqpM+92ljIOdfuP1I2u/pM4nz1sHzr2x8WdmSAXTeG2eg/BC+DDTNeWk8lZjUOdCyn5diec1fDD9yvuLTOeQ5YgC0gn68dAKFW97Q16ccg8J0j/r0k1YHoqXrxJVxZogmu9dMnkw80x5/LFGjdetpX2PvM8gZoSG8Fdn4fE+/BJeN2UF7mygE1eUVZUG4NOffEyu08L0s9wDgjSKyuYNR4a6rehID9pHzKBo806PvJx6twA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W8ANf04rvVBwwTVoSmk1wMh7BnV4jbgpw3PgliDnkIY=; b=UESNVU5X4U7Mb1sIUnUW6Y8bS06cx8WSLF1wrd4oXl7LaOBS0lr2K4Qe0+ehQ4ecstfVO8GS+uIHD58VyL/8yZaXE/DygxLfAybnwrm984eiL5SYI0oqjyWMNEyuQdrRqupBzXpjJIi19DjBXsAG0H0LpvXjM9vfuom1IOdVOVhKy9TyxbfNtu2BtzMXEUFOcZOUNiEBsqb/5jL951M0S0Qprc0Qm/rS23Ykn9k6VAfTYSm7Bei64FeQbd9n/gDX+HlnvFgBlEEZ7mgdlduem0kBgsuoRoMTv/hkzr2rYS+E1YtH83fyufPQzFdQCIK5LLUkEsBxy6Vf9O97nLxQQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8ANf04rvVBwwTVoSmk1wMh7BnV4jbgpw3PgliDnkIY=; b=1GiTmjkOyBemqL8wpiEBx/y65ZzIdEqTLmoD55ye5iseqtdm0w/3O0UOXVUz9BaJUICEmxgiIUKELqme1d8WUFiyqIehMkIZFtdJjfne7ZG3siohBJ3oBuULNFkBPUYiciJZmCtGOKSInpWejEyWQCnaqdfWD0LwyroHP+ufIqY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , Wei Liu , Anthony PERARD Subject: [XEN][PATCH v5 17/17] tools/xl: Add new xl command overlay for device tree overlay support Date: Tue, 11 Apr 2023 12:16:36 -0700 Message-ID: <20230411191636.26926-36-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|CH0PR12MB8505:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d59fb95-371e-40ee-d911-08db3ac1632f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nW4r2U3H6TrJMWIKgWISxhpfKTRgrSgjfkPPjFEqwV+PV72ixWavNRL57lf2zNDQvBzpHxBd5fpfXOKDOoZuT0F9iXe5r2UGkLbHTo6FDWqwLxgsVqgBDxQYeUyVovX0KXicgBcTNmyPeNshlu+kRcDVyNvkn0Ryy5uBzfKG+LQctr271k1kF/ky7COwagWYTdwNcUctEsn+FhjKBK0+QXRmkZxEoZry2EUPvR3YK7IHS0SxTml6xucxAGGASNSmJpKQ0uiyfGDDjXnpZvfU2XL27qCF0OqLy9kXAtayBDdOisSra46hjYIDTtFTX39UaUk88yN1vPb0y6lYaDNMjkpp0U1qDpba40BDxhUgF7J0YL3bi31c5fX4jlBNiaLBxs3mElWEAgWdiXNCmVXwWFSfYwpjqq6L8CQgQZ/qUolUvE7N5+NJo1FJi0NXaiK4Oyv9lizIqEXHugZILPEbXo0NMfd1UTeSxPaMCK3iAi82zqUogxDD6kmvFO70tx/W32bf5hrPW08ShFLiMMB4cNea0g2f4SJ9AarBaBKiClsUNU+cnOX/XrGaWwzWVky1+pPgzMt0P0aZwIOHXWKQB682ONv95mLVneYfIc6DkQXBeXpGxsQtFtsGo62JFcw0lRgf7pUQwrPbHvo+63NR+VUp5MY9uhdzRvacRJq61i0hCX6nkI0QPvIdactc/McmqnLOvsBVAvi+O6tG0bbpOhvPh1fsTupE8G+oJmTh9RU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(6916009)(54906003)(8676002)(70206006)(70586007)(478600001)(4326008)(41300700001)(316002)(36756003)(86362001)(83380400001)(336012)(2616005)(426003)(26005)(1076003)(6666004)(47076005)(8936002)(2906002)(44832011)(82310400005)(5660300002)(40480700001)(36860700001)(81166007)(186003)(82740400003)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:26.9767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d59fb95-371e-40ee-d911-08db3ac1632f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8505 Signed-off-by: Vikram Garhwal --- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 +++++ tools/xl/xl_vmcontrol.c | 52 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 59 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 72538d6a81..a923daccd3 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -138,6 +138,7 @@ int main_shutdown(int argc, char **argv); int main_reboot(int argc, char **argv); int main_list(int argc, char **argv); int main_vm_list(int argc, char **argv); +int main_dt_overlay(int argc, char **argv); int main_create(int argc, char **argv); int main_config_update(int argc, char **argv); int main_button_press(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index ccf4d83584..db0acff62a 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -630,6 +630,12 @@ const struct cmd_spec cmd_table[] = { "Issue a qemu monitor command to the device model of a domain", " ", }, + { "dt-overlay", + &main_dt_overlay, 0, 1, + "Add/Remove a device tree overlay", + "add/remove <.dtbo>" + "-h print this help\n" + }, }; const int cmdtable_len = ARRAY_SIZE(cmd_table); diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 5518c78dc6..de56e00d8b 100644 --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1265,6 +1265,58 @@ int main_create(int argc, char **argv) return 0; } +int main_dt_overlay(int argc, char **argv) +{ + const char *overlay_ops = NULL; + const char *overlay_config_file = NULL; + void *overlay_dtb = NULL; + int rc; + uint8_t op; + int overlay_dtb_size = 0; + const int overlay_add_op = 1; + const int overlay_remove_op = 2; + + if (argc < 2) { + help("dt_overlay"); + return EXIT_FAILURE; + } + + overlay_ops = argv[1]; + overlay_config_file = argv[2]; + + if (strcmp(overlay_ops, "add") == 0) + op = overlay_add_op; + else if (strcmp(overlay_ops, "remove") == 0) + op = overlay_remove_op; + else { + fprintf(stderr, "Invalid dt overlay operation\n"); + return EXIT_FAILURE; + } + + if (overlay_config_file) { + rc = libxl_read_file_contents(ctx, overlay_config_file, + &overlay_dtb, &overlay_dtb_size); + + if (rc) { + fprintf(stderr, "failed to read the overlay device tree file %s\n", + overlay_config_file); + free(overlay_dtb); + return ERROR_FAIL; + } + } else { + fprintf(stderr, "overlay dtbo file not provided\n"); + return ERROR_FAIL; + } + + rc = libxl_dt_overlay(ctx, overlay_dtb, overlay_dtb_size, op); + + free(overlay_dtb); + + if (rc) + return EXIT_FAILURE; + + return rc; +} /* * Local variables: * mode: C -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:20:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519884.807045 (Exim 4.92) (envelope-from ) id 1pmJXE-0003Sb-6Q; Tue, 11 Apr 2023 19:20:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519884.807045; Tue, 11 Apr 2023 19:20:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJXD-0003Qd-T5; Tue, 11 Apr 2023 19:20:07 +0000 Received: by outflank-mailman (input) for mailman id 519884; Tue, 11 Apr 2023 19:20:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUU-0004Ta-0J for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:18 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20612.outbound.protection.outlook.com [2a01:111:f400:7e88::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7825769c-d89d-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 21:17:15 +0200 (CEST) Received: from BN9P221CA0020.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::32) by DM4PR12MB6541.namprd12.prod.outlook.com (2603:10b6:8:88::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Tue, 11 Apr 2023 19:17:12 +0000 Received: from BN8NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::f6) by BN9P221CA0020.outlook.office365.com (2603:10b6:408:10a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Tue, 11 Apr 2023 19:17:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT113.mail.protection.outlook.com (10.13.176.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.29 via Frontend Transport; Tue, 11 Apr 2023 19:17:12 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:11 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:11 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7825769c-d89d-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nd9RHJF2398b5isOKaYdNprBPl/JNuJF6/ge3zT77zkGtEPFSzds6zzf69EGMJAgklQy0X2u3+v9EzkoUL8og3kVHQixgbWQ5Njigjp66elYLenh+J7QZEtnku2fMxbv6PBqSq6XIUj6sva/sCfwpP1PsxcwsbfWdY496muh8Z0FNB87I9udOfbP5c8smQ5H8CGbfH5c8V32AP2JJfi9boLHlUPpiFHk0Qj5HgGnWlTpfQLHfHGfKZoeheoD6EWHaF6sTHYHVSB6UxxLD5olg3jxzi0vdP4lQP8I1jTuxUMXF086TLemBhklKP1rC8U3EvYFa6TzY3yYcxuxpEoqJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0odwSwlZEbTJvdLLf27PaAsLK4pjjIm+Jsb7s8Lqv7g=; b=K3LK6ruFsTA4TPqFt/ammZSl/L8ggQ6E16nomQr5n3ta6K0P+pc/IVT5pkNN8uKuBfN33CHrxT49q9EbSeedM+cJ9eBr5YKtjSRzUXAS3ki2vEzEcU272lsMobTIFxbZ35sDe9X5OMw0QP19LbdEUNveyReAdEinT6VGWtcOt+sjJ9t7O+TOqVZif8yPg+IlNbIbZP8MPBIDycowyRdg/OKXXvmcDnzoQccPxD8YtsQm4XyAdJ4AkjRQYTqVnIMebgRyjh176UgkFlaschPgOCAyq6aJPbs4nOJl6xueJtw7xLSbE+NNKhSn8K67xZDLZt4Q8tdSLM3GSuEmGpXf+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0odwSwlZEbTJvdLLf27PaAsLK4pjjIm+Jsb7s8Lqv7g=; b=udgPt9YgeXZs+lWeAZV5aVlBBUqHsJP0l5aFIU9sPSKpCRYAo6zY4oeKvcTzYBmDZyLZotUsv/O38LNzRY1kN4j00nm0f0Ez1qkF7ftHoqc3b5GBw/5Fn7K2kCVzTaM+aOmAX1jvjcawQ5Tu8Dbr5fDa5Ck2tJ50YmouDiOODDY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , "Julien Grall" Subject: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Date: Tue, 11 Apr 2023 12:16:21 -0700 Message-ID: <20230411191636.26926-21-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT113:EE_|DM4PR12MB6541:EE_ X-MS-Office365-Filtering-Correlation-Id: 1db08cfe-55db-45a7-8ea6-08db3ac15a73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1doF2RKmkOdJFbpJzZWghxFTAGAl514VARfqJ35cis52xR+3+oTUWV7ecTA9tKoXEKyGmv7DeTyTrn1VDEGDx/kRtGkMVfurLAzr3fmJ4pBmQdekjSGNIDH1N0cXBF6OUke7faWga+sa998uw4TOw3DoQ/ToBFwAdRYVw3ORW2bCw3CKqlDTkeWUTabLkD3nWScqZzDjja/4LTm64WuivS6yhyYd/Ii3uNNf5ro+GxpN6ZiodW8WCjVqwatrM/UVGv08GLDQdWwzL+F4hvaWnOcy/j3DB0hvzRM3jtIHUQuwsZgoWE+Rqh3A+urm8gt6jYpvjBOASs0e/IipHUuMt+O86Qj77dCQYN1slyKzUHekyTJeOlZVP81zPuFoeYm8SsS+mTyp2K7gjE8urSEac5HkMpLitJBbkq42mBPwi1T9xdWWPNEk2iCCQ3Ubw2GcoX91M+l+OLegeqjPAu5lfbcOYUV+qHO37OZgHoxDn9rrWJlrwi5QWNUyIHhImMeIW/LOAcTTPcioLXZhjat6OP1f3QkWaloNc8AqDPrW27sxOojetd31kuyEfyfDg83pkXVS/zg0wsA2MstlSabqI+yKf9vWvPk6pVX1MhUJPmwEsOpNJOnMZG6t8sLnWaFCWf3GlT7WDsP/jknupLlnu68GqnnzU3JPq+AEY4WHEzSCD/IlHew1+8I+3eiEp0NrYGUzGLLZIh3bJM3hbhbusjnEhQ1sqMouBCmmovcEbDM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199021)(46966006)(36840700001)(40470700004)(40480700001)(36860700001)(82740400003)(47076005)(336012)(426003)(83380400001)(8676002)(316002)(54906003)(478600001)(36756003)(1076003)(26005)(2616005)(6666004)(186003)(44832011)(4326008)(81166007)(5660300002)(2906002)(6916009)(40460700003)(356005)(70586007)(86362001)(70206006)(8936002)(82310400005)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:12.3366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1db08cfe-55db-45a7-8ea6-08db3ac15a73 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6541 Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove static function type. 3. Add handling of memory allocation. This will be useful in dynamic node programming when we unflatten the dt during runtime memory allocation can fail. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 10 ++++++---- xen/include/xen/device_tree.h | 5 +++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index aed38ff63c..bf847b2584 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const void *fdt, } /** - * __unflatten_device_tree - create tree of device_nodes from flat blob + * unflatten_device_tree - create tree of device_nodes from flat blob * * unflattens a device-tree, creating the * tree of struct device_node. It also fills the "name" and "type" @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static void __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; @@ -2079,6 +2078,9 @@ static void __unflatten_device_tree(const void *fdt, /* Allocate memory for the expanded device tree */ mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct dt_device_node)); + if ( !mem ) + panic("Cannot allocate memory for unflatten device tree\n"); + ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); dt_dprintk(" unflattening %lx...\n", mem); @@ -2179,7 +2181,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) void __init dt_unflatten_host_device_tree(void) { - __unflatten_device_tree(device_tree_flattened, &dt_host); + unflatten_device_tree(device_tree_flattened, &dt_host); dt_alias_scan(); } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 19a74909ce..58ac12abe3 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -178,6 +178,11 @@ int device_tree_for_each_node(const void *fdt, int node, */ void dt_unflatten_host_device_tree(void); +/** + * unflatten any device tree. + */ +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes); + /** * IRQ translation callback * TODO: For the moment we assume that we only have ONE -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 19:20:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 19:20:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519885.807052 (Exim 4.92) (envelope-from ) id 1pmJXE-0003cy-Rs; Tue, 11 Apr 2023 19:20:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519885.807052; Tue, 11 Apr 2023 19:20:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJXE-0003aE-GY; Tue, 11 Apr 2023 19:20:08 +0000 Received: by outflank-mailman (input) for mailman id 519885; Tue, 11 Apr 2023 19:20:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmJUg-0004DR-Bm for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 19:17:30 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20616.outbound.protection.outlook.com [2a01:111:f400:7e88::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e6342f1-d89d-11ed-8611-37d641c3527e; Tue, 11 Apr 2023 21:17:27 +0200 (CEST) Received: from BN7PR02CA0011.namprd02.prod.outlook.com (2603:10b6:408:20::24) by PH0PR12MB5607.namprd12.prod.outlook.com (2603:10b6:510:142::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 19:17:23 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:20:cafe::21) by BN7PR02CA0011.outlook.office365.com (2603:10b6:408:20::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 19:17:23 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 19:17:23 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 14:17:23 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 14:17:22 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e6342f1-d89d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYkT+9ybedTAThsa69OTF8pDiP0MapFqOpgACARH+6PwvEwplOikd1yK31DLgjqTQ+NwL2NhFM612qQn1Zk2T6REA9HurY0vIUfm6ASLw9cTfNiqAXo+zsYiW6NgkFbMtRVKKhWh4zBVeAkVUpov/tkhNshlfcm6pDULZyjl7BxJEuemGsbPWwSyfD6XE+czKIfu5bjD6FARRQyZ7BSQ/ScOW4mlS7kUXbzqxyUCsuuV4a9Jg+k+It3c1BmoiLLTyBBu747DBAhbcOA4ZtDg4TTTcsWT0QhuXgHC9nxog1Mu0qoXwfoBkK86oQvEyUwcSFZYZIitwdjyAhkTJ7lT7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkwDgQcNvE9UkGiRuGgnKgAIS4K7kLAxiI7Z7Wg7YaY=; b=bFkwv0hRmgWPKHlPE78WePjeyze5djTM4XidulgttiHnANW6RcfIX235Ic4iOQ4EGGu2nm2KmYzhwCKpyv1ofZ5ALGFn+RObauX7gT5t745XCjHJ9bqBeA38DW350O8BXLiMRHHvlBc89Am8iYZW67l5N96Bc5fMa8BJmAf/jAccbFHW1rtmsF3iJvhcB/dHEj6H9a2PDFep+nPqawQo3qh46GeX5UaAw2jnFBFPp4gNMcTKkYm3f/R/mFy21DQhOYhAr38KHm6H1ibY158dC/TZRwmcN2ICQPNWbW3TUv+gnOVdtKLqXE41I1KX8TopAf2UKqG4E9XVt/sAwJhIrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkwDgQcNvE9UkGiRuGgnKgAIS4K7kLAxiI7Z7Wg7YaY=; b=21/M39zzNkj6wIHkED3tJss5gecgEfRVwuaFUsyo+K3x1WdUj1VY+Ix1f+ggPHp698D1EViTsLUcnRtHqsqNJokVJHXZPoxBvyLa2VuGdBFmfVOkuwkwBiLs2e+dHETrO539r0RHzhgqZGOQUSD7Yh2xicGbe5d3/hZ3/KZT7Kg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , Vikram Garhwal , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v5 15/17] tools/libs/ctrl: Implement new xc interfaces for dt overlay Date: Tue, 11 Apr 2023 12:16:34 -0700 Message-ID: <20230411191636.26926-34-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com> References: <20230411191636.26926-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|PH0PR12MB5607:EE_ X-MS-Office365-Filtering-Correlation-Id: 7bb3dab3-66a2-4d94-0fae-08db3ac16115 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NjdL+dF7YtTYsdvEmz+gwZtMQejePwuqoUCxVtuOYQWysB0NMs9qEb+cfhvo6TJNzD/9vi69QT2fhp+OJDVPgfUkgVu1tn/qlZAYyWuVTf3N0cFFtJo0+Qx/bvE/w4ztWaOrlR/LK4EUmD9HZWW2Ty6fwF+EGqbSftprSFjA0H6RQ0+31wdLq+JOh4Lvz5Qk8XhjB7JOof5mawk2Vm9n5GJHTQmZUM0XZVb/FLLM3YKedjjhJ7lIt36Kr3VO8TDnbLJ7/aUA3ic4jmVm6ApUiUEZcumHQ/jubuNqi/Kb3NeQDu6KCmMYpYYV68o5Tti7/XfZ1i24vD2De9ayV9gEHlj7jKjNUFoHiifxaHbvGh6U6+T2zQE23AybgmDS/cbFmj4+XbtJauR6nf+e3wc231biL3TBFKbqW2zNtuEZpUYEan3mwwB5X4LJvnHctA5YPldL020mz4UjL0046VI2BorKesLR1Ssm9sqkz8EI5kZxExFETPQ3kOeNcrjqJiwHxl107F2ywBiqNv8UPmLLd3dmLWJmcgRO4nzQeWQ/1oxK6chL1Ec9vfiz7VemckQRV5zKIvroPRvvRjFCfQQOKrFcxUIP+ZcOI/7ZffJpIOW0jxZVakknuR3y4YWkzL4UhICB285ipDmmK59cQxfz7/GjtyTeuY3L1pK+xfCHtwUmmCkdNybWCEk8g6NdEFg/RQ2TRdGemRpmRCb4oJQ4qkxW7GWizOkLjuulhdFCLmhvzgZvWSIgztkxhXpne7E9 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(46966006)(40470700004)(36840700001)(82310400005)(82740400003)(356005)(54906003)(36860700001)(81166007)(70206006)(70586007)(8676002)(86362001)(6916009)(478600001)(4326008)(336012)(47076005)(426003)(186003)(2616005)(26005)(316002)(41300700001)(36756003)(2906002)(1076003)(44832011)(40460700003)(40480700001)(8936002)(6666004)(5660300002)(2004002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 19:17:23.4457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb3dab3-66a2-4d94-0fae-08db3ac16115 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5607 xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and overlay operation type i.e. add or remove to xen. Signed-off-by: Vikram Garhwal --- tools/include/xenctrl.h | 5 ++++ tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 48 +++++++++++++++++++++++++++++++++ 3 files changed, 54 insertions(+) create mode 100644 tools/libs/ctrl/xc_dt_overlay.c diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 05967ecc92..b932589c8d 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2637,6 +2637,11 @@ int xc_livepatch_replace(xc_interface *xch, char *name, uint32_t timeout, uint32 int xc_domain_cacheflush(xc_interface *xch, uint32_t domid, xen_pfn_t start_pfn, xen_pfn_t nr_pfns); +#if defined(__arm__) || defined(__aarch64__) +int xc_dt_overlay(xc_interface *xch, void *overlay_fdt, + uint32_t overlay_fdt_size, uint8_t overlay_op); +#endif + /* Compat shims */ #include "xenctrl_compat.h" diff --git a/tools/libs/ctrl/Makefile.common b/tools/libs/ctrl/Makefile.common index 0a09c28fd3..247afbe5f9 100644 --- a/tools/libs/ctrl/Makefile.common +++ b/tools/libs/ctrl/Makefile.common @@ -24,6 +24,7 @@ OBJS-y += xc_hcall_buf.o OBJS-y += xc_foreign_memory.o OBJS-y += xc_kexec.o OBJS-y += xc_resource.o +OBJS-$(CONFIG_ARM) += xc_dt_overlay.o OBJS-$(CONFIG_X86) += xc_psr.o OBJS-$(CONFIG_X86) += xc_pagetab.o OBJS-$(CONFIG_Linux) += xc_linux.o diff --git a/tools/libs/ctrl/xc_dt_overlay.c b/tools/libs/ctrl/xc_dt_overlay.c new file mode 100644 index 0000000000..202fc906f4 --- /dev/null +++ b/tools/libs/ctrl/xc_dt_overlay.c @@ -0,0 +1,48 @@ +/* + * + * Device Tree Overlay functions. + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + */ + +#include "xc_private.h" + +int xc_dt_overlay(xc_interface *xch, void *overlay_fdt, + uint32_t overlay_fdt_size, uint8_t overlay_op) +{ + int err; + DECLARE_SYSCTL; + + DECLARE_HYPERCALL_BOUNCE(overlay_fdt, overlay_fdt_size, + XC_HYPERCALL_BUFFER_BOUNCE_IN); + + if ( (err = xc_hypercall_bounce_pre(xch, overlay_fdt)) ) + goto err; + + sysctl.cmd = XEN_SYSCTL_dt_overlay; + sysctl.u.dt_overlay.overlay_op = overlay_op; + sysctl.u.dt_overlay.overlay_fdt_size = overlay_fdt_size; + + set_xen_guest_handle(sysctl.u.dt_overlay.overlay_fdt, overlay_fdt); + + if ( (err = do_sysctl(xch, &sysctl)) != 0 ) + PERROR("%s failed", __func__); + +err: + xc_hypercall_bounce_post(xch, overlay_fdt); + + return err; +} -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 21:05:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 21:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519947.807070 (Exim 4.92) (envelope-from ) id 1pmLAz-00028n-DN; Tue, 11 Apr 2023 21:05:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519947.807070; Tue, 11 Apr 2023 21:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmLAz-00027q-9z; Tue, 11 Apr 2023 21:05:17 +0000 Received: by outflank-mailman (input) for mailman id 519947; Tue, 11 Apr 2023 21:05:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmLAx-00027i-VZ for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 21:05:16 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20609.outbound.protection.outlook.com [2a01:111:f400:fe59::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c77a037-d8ac-11ed-b21e-6b7b168915f2; Tue, 11 Apr 2023 23:05:13 +0200 (CEST) Received: from MN2PR01CA0042.prod.exchangelabs.com (2603:10b6:208:23f::11) by PH8PR12MB7424.namprd12.prod.outlook.com (2603:10b6:510:228::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.33; Tue, 11 Apr 2023 21:05:10 +0000 Received: from BL02EPF000145B9.namprd05.prod.outlook.com (2603:10b6:208:23f:cafe::5a) by MN2PR01CA0042.outlook.office365.com (2603:10b6:208:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 21:05:09 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL02EPF000145B9.mail.protection.outlook.com (10.167.241.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 21:05:09 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 16:05:08 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 16:05:08 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c77a037-d8ac-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jegRTeJSpZuE5Q3pTyaHRqHQvGxMY6P+irT7jYSVekWN5rAyXxR1So/cwGjL5Z/MnE0/jDfYXl1Aw2mIV+DLEgOhpsS4n66xuv8Rzht9Scr7ACfDjQVBlkMGgC97Bhf+QtA3vDbt/WPC5xcanZ280jYCW82zAxdI3wpqXFvdVO73ROJJbZiGvvWQhmEar6PpXkbsqNDP86EQ8lfgN0GAwa1Rg1MvGv+4Z96tFmELn2OnNVjv+I7lm2S7NyKuaHwKzQxc+nf+YMczgy37zVJhMiqA6gpYFUGO1jTvOW0lns0UDiUn1H+WIwKySbu6KBIFOnwqD2ZB6AxqNBUmzd3C1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dyQCgywzSPQJgk3l7gPLyp/Wd2+MwFaNmcvT4lvITlY=; b=VTXEPXu8h5R2+ITRNrw9ekN6qqrpfoelBZDfFPTJ0hAAW6a/iI6RDagUQaNhSMdf9ses+zqkHjDdLrwnDIPpfMoLhb0JqlepZLPa9pXrnRKCN/VhmzNvCcSBUjewg7W0a/7m3+5yz00Dd5KphnaVof07SNeLsyXsbecRdKsGlgysZqe/3JV59pg5OHfEqxT7ROI2rP9VjGeTFkVLGCGKxymmB99gUzHBYGqChSNoKgmWw5NM7Nu3z+bYZmkhUmLpsWwPuulDT0zzgp7c/sqgfS2knxKidJhKNxM7bx/NKlBJiq+tbLtqQCGSXWgwp/Rd7zge/yknwNn33GDTIbs/IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dyQCgywzSPQJgk3l7gPLyp/Wd2+MwFaNmcvT4lvITlY=; b=HIAOrlOoPf1lOufdYmhQtb0i+ul2zvBLxwuklWzGQSL6JdKDRU4mtCJcC4HOM6kZqEok146MDaD30EKcnw2MngI74Kq+jNzxTk51XcACqXWJ3Xz536mXij8irfBlM6W+/9Dzi67z18xq5lDIlMnGuC1o7xrUlpGklhpQBZb3Aj0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , "Wainer dos Santos Moschetta" , Beraldo Leal Subject: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen Date: Tue, 11 Apr 2023 14:04:22 -0700 Message-ID: <20230411210422.24255-1-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000145B9:EE_|PH8PR12MB7424:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c46b70e-6ee8-44ab-b23f-08db3ad06f05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RN1w/NXEhX5pXZwc0HtFOl0/F+RYHwjclG4S+a/RqRG+m2nbAQvVjY0RovoCmHqlNh968194MTBhC8ECFgct7SZeAKkYmXNDYR6Ed+GdrjjpKwAyPqTbZxtufa5NfTsgwHuCuE5ATlLeYv5qrD153ip4g1bZ9u/Sfw+lekGksvzeE+zcQoRI7yGsrZ/zMEX1TkKTi6yF2e82W8s6vMF7v0zC6MEdK+qnam17685sXlJMJA7xNsyTXfiq7fMWmiR+Sja5J5DR+bhJCKcxr4OYpPH1Xke8pIwyrUQM5OIBYy5NXwUWGdikmY0iL852sUnToJNrtwXfopbV1suD7UQPxvYyFo0bO2FdPlB6qQIlGrjnOuZNhg2Z0/E//k0rfyV8WZ6bKqJ9+3lIlpcIkUOCPQaVX/un8OKG4M0I7YFDtZGdnVPAx9JX8pM2ghicaZllNtWLx0iIuiub3FGTdvVepkZMTZv8HuEcstlyxcXap3aIbEcC0isVJSNDc3w98DnExBh7J6Ojg1jcQPeXpfZOZ4xa5F2PIyBlGhbec2MTYNqjFib1b25Vn0vMuoOvro4FouEswSpVTs/t8qcZyDy9sCmzF1/gzD24iG1OcMKpQd6erYBY6CkxaULL5hsd38LltVg2MvYERXYDPe6W6G153+nrbpZZI+p2wXS9pNFt47zy+Iwb5fSjPmqJ+attx+twCbNj8YQM+J6uW6ZG3KoGX/1U/RMKdOCqXt38WG1azuA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199021)(40470700004)(46966006)(36840700001)(86362001)(36756003)(40460700003)(40480700001)(26005)(186003)(83380400001)(1076003)(2906002)(966005)(336012)(47076005)(2616005)(6666004)(478600001)(426003)(8676002)(70206006)(4326008)(5660300002)(70586007)(54906003)(6916009)(44832011)(4744005)(8936002)(316002)(41300700001)(82310400005)(36860700001)(81166007)(356005)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 21:05:09.2841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c46b70e-6ee8-44ab-b23f-08db3ad06f05 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000145B9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7424 Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target. Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html Signed-off-by: Vikram Garhwal --- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 61b8ac86ee..6867839248 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm cross-arm64-xen-only: extends: .cross_accel_build_job @@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:28:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:28:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519957.807080 (Exim 4.92) (envelope-from ) id 1pmMTK-0001ob-5D; Tue, 11 Apr 2023 22:28:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519957.807080; Tue, 11 Apr 2023 22:28:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMTK-0001oU-2S; Tue, 11 Apr 2023 22:28:18 +0000 Received: by outflank-mailman (input) for mailman id 519957; Tue, 11 Apr 2023 22:28:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMTJ-0001oO-0s for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:28:17 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2607fd85-d8b8-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 00:28:15 +0200 (CEST) Received: from pps.filterd (m0174683.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 33BH66r3003071; Tue, 11 Apr 2023 22:28:00 GMT Received: from eur04-db3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3pw8jehpd8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2023 22:28:00 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by AS8PR03MB6870.eurprd03.prod.outlook.com (2603:10a6:20b:29f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 22:27:46 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3%3]) with mapi id 15.20.6277.034; Tue, 11 Apr 2023 22:27:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2607fd85-d8b8-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KMfA1SKBtkQTIq0hIBTVNbba8WABg5EJ122/OmR8G+fKHrexC6TSLJWYRc2GZhwVt5pxy7M8BzzUhpc6eyyjl9/lxIjPhZj1zwpyoMtEQMQfugF4JSWUIgSP86g0vVGfNuY0KjKZDA4mgdFAiduAGsStgWunX6nMIwBtHIrjV5TTpEorSoHmwxvFwy1TWHzDUQU+Z2qr0b70a/L2RRRX1fSpBO3GT+bCWzfRFKy68I8Rgyz3X1qcKp+/Rgg7stvnAQGyZDL675ebCZECa8GwHdfZw2JxbYwNDkRrfEDcK1RdYDXHFbCvfyxC0PaalgAktbUIg8nZPJpL1dU502gIpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkiCktxs4VSNFb5+LI+rK6V+Cf5t5MxyAXN+OKTAnxI=; b=d9OrkvNA6ItuYIfSJOO4TQsKBtkzIdzTYIHbLGWpH0fCO77DNO7W8Teu8rcpl7/uiKtW0+bZg9wGNJz8Ya0aX01Re79UM74AqqqfBe8vlZOPVYucZwEPg5yki6Irx2RBVi1uTuEckze5Db1FChjA89Zf+BYTIGgI9/RFID+zPNoJ695CkgXS7RJkPKoPWYzeUPpChNBL+BNpZeQP+xannzAFCEq2Qhd5AP4vsewcpjs4gNd1ZLy9GJOqo1BxqRsY9ZXwt9j7AMPF6O+m6PIA1RYeihwzRaMrc5hwGUu0Gfmt9TEUL8ZI8nPIloE5c6EPWLasIE6h5pkLIusWFt+95w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkiCktxs4VSNFb5+LI+rK6V+Cf5t5MxyAXN+OKTAnxI=; b=SD5sjgMZOvEPaEQL22m58WNiijf6em28tO0Bc6ZKnIqn1cWjlJ4p/34NSeWv/NoVMH9mSVIrqTgD++yktJr+ktwnT1Qn6C1FrHkfJC4BogfK/h8uaWpwDACm9MobVWr37Dg1TvYDeMDmo7r2GssgVnTXfjThpzmC0Q9ZHKGGGax/KnyalK2eOw0gKdAI9c65iijGz+Ml0FLnI9uWoGlRkvsgwD6PRuIrZnPURoAfai5XZTbg8uossrRarZIH9rZDFXBT7Kna2CIufHgy6c7M+C+RTddtp9zPpqlIZh8Gxszd5UXs11Q47YMuO7SN4mb95pOMrIVAsmPoFqHVAoV6RQ== From: Volodymyr Babchuk To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v3 1/6] xen: add reference counter support Thread-Topic: [PATCH v3 1/6] xen: add reference counter support Thread-Index: AQHZVrdyBx9pogLqRUq3RbhGdjZNSK79cEwAgClpiQA= Date: Tue, 11 Apr 2023 22:27:45 +0000 Message-ID: <87h6tmxden.fsf@epam.com> References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-2-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|AS8PR03MB6870:EE_ x-ms-office365-filtering-correlation-id: de4f9997-687e-4b4a-5603-08db3adbf973 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TjrnYb+lenGgK2LgbYUoRT+69DB9ECEkUNOzfE19N08uZFgNS0AhGtHK0nI13nUKtlPqMjxxJnDvy6tbMYW7xoDUZ/kEFYYuN/d821rSeJwywfiNLaA9xWuTPgdr46XsCNVSvGB1MLg8j5IEd0kdc8IfpovEA6YyOiZgPCyZNx5n9w40+g/Goeagf1watIpOjklnLL8S/1FnH2t7bHcICzDEPAVC8BKSreQMTYbAfp4m24Q4Bkzj5UYbQAre6nM7GF16kyvSu2h/5Yddj+qDet07W5cl8mh7qu4zsh80I7QbMFh3RgWc9LEeu6UxTXaQOZfJv6QbaeDMl9oWIJB0fMGsyP8aKVUWGwJ33ftl052Owd8glhYX7Rp+xF/lWNS0m8d1y4bmMyfe2wytG9bxRjjvCODjtoZ0/5JGMU4OUfpz+kI/4ggYC4NqKxA5Itq9a0/zzQuN+YYTk7rtvr3MeF0M1mmnRPvfEKqQPW1jhGiAluN2Fttv89v7xK1cV+Df4RaguYIDTIsZRvvS/htdwftsLA439cTCVY5fwNPCDgtZ4jxdQMi1Jnzlvt8ZTcrR63QGq5xRRHVlwj4ymQnuBsJQcQcSrZgNocjR6hnB3bjvktJ6ty39lwADNxG2Oom0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199021)(2906002)(38100700002)(6486002)(5660300002)(122000001)(71200400001)(38070700005)(83380400001)(8936002)(55236004)(6512007)(6506007)(41300700001)(26005)(2616005)(66476007)(66446008)(6916009)(66946007)(76116006)(66556008)(86362001)(91956017)(4326008)(8676002)(186003)(316002)(64756008)(36756003)(54906003)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q1U1QjVrS2ZzMFZaMVhRSndhcWtadXFjb0JoNktxRm9IQzJ4WDJVRnYyekh6?= =?utf-8?B?OVIyQnl1cTdOVE5CKzlwU3lmQ0ZRTGU5ckpsUXNNSFF5Lzl3WHMrWEhQV2dP?= =?utf-8?B?b2duM05mZ3hhMFlKcitBTG5JaVpFOWpSelNVdSs5SmhVb1VQVk9NTVZXcjdi?= =?utf-8?B?Um9aNTJDVzU3S2lQWmJzK3c1RHZ6Q0xZVWlFbloyeTUzdFBYczRDZXhOaEhP?= =?utf-8?B?ai9YM0ZKb3R1SmViYmNXRVljRFJBbjJ0TVQ2eGgrVVZJZE1zN2RMU21YQVFo?= =?utf-8?B?UUZTQ0xHSXUvUjNLd2FIRDhOYlJkUEtLTjBZdGN2byt5MDVMV2xsQW5ZcURx?= =?utf-8?B?SmV0QXMxTHBBbnhmYU1kY2U3N0JMdjFVTHJEN1h3RFpTUDdJUWZmbWxJRDkx?= =?utf-8?B?MTkxUzVLcDJtS2NtVzlyOE51cC92bEZIWU90L3ZuQ3k4aCtZbDJCVTB6cUJB?= =?utf-8?B?NUtiNDErNkprcU5QdkY1NkdHaGZwNDJjdHEyeStMa0d0T096bCt4QkMxWDdJ?= =?utf-8?B?N3lCK1ltK2E2VUk3T3JmTEpUTmJEa0pvYzhENkEwQy84ODF2S1ZIajFudFY4?= =?utf-8?B?eVBhUVByZTMxcGEzNkwxME9XWVMrMnZ1ZDc3T29hbGpnOG8wUmUyQTh5MWNt?= =?utf-8?B?WllmTW5FOTU2ejRvdThiOElJbDFoN0wvblRNQWs0Vkh2NnNGeTJMTlBzZXlF?= =?utf-8?B?NGJ0anBHdnRjYWFpeFVuV2xJNlphV01kdEFHWkFZajVKYkV6MVpOY1l1RWZR?= =?utf-8?B?OENuVEZZc3k4Z2JvUWlEMGE4RGVQL3J3TzFjWFU3dFIxZUlpR0ZjU21BV2x0?= =?utf-8?B?T2trenV6Y2hEeUtVOC9pWnFlTTlmZVVjYVVqR1NkMkdRa2hrZlZlbkdmRC9T?= =?utf-8?B?VjdVODJQa3llMFgzV0hkK0dhb1FiZ0JYZ0Vnb2grT1NKRDVhNnFDdXZ5WU5l?= =?utf-8?B?T0c3NVp3djRxdXo5Sm1BOFJucjVrUWdiN3EzTVRGOHZhMXlUYXRxWWhZNzZ0?= =?utf-8?B?dVZOMWtPRlBpQm5FL2xrNk9TNlFwZldUcWNRY1ppSFhSU29qNUhPUy8wK2Ft?= =?utf-8?B?VGlVOW9XU3VTWkEzQ3liOGM5Y055ZjVUR0Z1NCtHU1g1Nng5M1R6S0hJNGpx?= =?utf-8?B?djJXQ2lvRjVUQllsajNRSGtSamwyMFlqUFoyZU9Cd1lJM0N6eFAzMEpnVEdY?= =?utf-8?B?SjdXekFoK2NUb1JmZ3hPeHgweTN0NDdQYStEd1hNVnlxTTlGZ0J6cjZ2YlVj?= =?utf-8?B?eDh4TmtueVBuOXRZVmJuZ3ljNVU2K1FmWFdWeE43NjZ4SHpvUjk0UW9UQUcx?= =?utf-8?B?VmxQQWcrUmt5RDZLUVcreUJhVFpZc1AxTDI3a1VUcUg5SmZaQ3pKdVlYenhs?= =?utf-8?B?QmVQYVlwT3oraCtPd2huNzFndUN2cklmcUdjQmRsVW1ONmpLQ0V1TStvbGU5?= =?utf-8?B?V3NPd0dEYkprbTVrY29ZSExodFlwWFRSQnZhM3h4VjBSNjBtMVBFdnR2Yno3?= =?utf-8?B?TTdOZWJoSmRmQ1RFOEVQeXBZVzZXaW5tRDQrY0JXOWZYY2JBb1BRMEtlQXRr?= =?utf-8?B?Q0VHL1pnVEtSOTZ0TEYxeWZ4N3c1Q1FlWWZPT2E0ckNZU0RnbnF1TFBGK2t2?= =?utf-8?B?WFFjdjh0VlpZRkN2QUFsWDN6YU55SmNONEQyNFhkMEtuVnY2QlNOb290bmo1?= =?utf-8?B?Mkxzd3JOZEU1MzA5SmNUcEZRcnRna2xaMjgydE9EN2FnMENiUDdlc0JmVzVL?= =?utf-8?B?WkhGbEtKZ2VrWitJYWQremIwRFc4Si9qUVJ1WHl1LzJmMTRyZCtPZmhYR0U0?= =?utf-8?B?bjhKS1ozOEdpRnJMSm9SQnF2di94Y2ZhSW1Oc0pPYkthYTkveFVpRmZvaFZC?= =?utf-8?B?NjZOazJxNktYdFQxKzA4Z1d3UkMzdnh3Y1pKbjBGNTg1ZFV3aEQ5dTIrVVpV?= =?utf-8?B?RGhjeFVRTDgxaTBqWXg3WGpOb0VzWHZNaW9ZWFVtQjkzVHFQdG1QNGlHNDJk?= =?utf-8?B?NzgxdWhnYUxQRTlhVEJIWFVCWXlqTDFFWEE4NEdyZEtNNVVCc1MrSVJEeUxk?= =?utf-8?B?Ujlid2hlaHBDWXJjdGpZT2hKZzk4dWNmRVJKTC9GdFMxTFAzWitDN3NzMjhm?= =?utf-8?B?QUoyc0NYa05VZjgzY2FuVzc0dXpvVkJhd01oQWg5VUx5NW0yN2VnSDJscUJV?= =?utf-8?B?aFE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <5E946897F8C693429C3A38C9D0704C15@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de4f9997-687e-4b4a-5603-08db3adbf973 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 22:27:46.0247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfybyA4BX7/UhsfbxqHIPjCf2V0CDwW6cxxvqht+qWYTG1xcA5gc92s7fONUcM2ayIUF4YdInnsq6G5Am7hagxx2YwaPkNyDDowjEEe3BDo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6870 X-Proofpoint-GUID: JuQqmSocrXSbpyv1VGRk_no9VtP0zqXJ X-Proofpoint-ORIG-GUID: JuQqmSocrXSbpyv1VGRk_no9VtP0zqXJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-11_16,2023-04-11_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 clxscore=1011 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304110202 DQpIZWxsbyBSb2dlciwNCg0KU29ycnkgZm9yIHRoZSBsYXRlIGFuc3dlci4NCg0KUm9nZXIgUGF1 IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyaXRlczoNCg0KPiBPbiBUdWUsIE1hciAx NCwgMjAyMyBhdCAwODo1NjoyOVBNICswMDAwLCBWb2xvZHlteXIgQmFiY2h1ayB3cm90ZToNCj4+ IFdlIGNhbiB1c2UgcmVmZXJlbmNlIGNvdW50ZXIgdG8gZWFzZSB1cCBvYmplY3QgbGlmZXRpbWUg bWFuYWdlbWVudC4NCj4+IFRoaXMgcGF0Y2ggYWRkcyB2ZXJ5IGJhc2ljIHN1cHBvcnQgZm9yIHJl ZmVyZW5jZSBjb3VudGVycy4gcmVmY250DQo+PiBzaG91bGQgYmUgdXNlZCBpbiB0aGUgZm9sbG93 aW5nIHdheToNCj4+IA0KPj4gMS4gUHJvdGVjdGVkIHN0cnVjdHVyZSBzaG91bGQgaGF2ZSByZWZj bnRfdCBmaWVsZA0KPj4gDQo+PiAyLiBUaGlzIGZpZWxkIHNob3VsZCBiZSBpbml0aWFsaXplZCB3 aXRoIHJlZmNudF9pbml0KCkgZHVyaW5nIG9iamVjdA0KPj4gY29uc3RydWN0aW9uLg0KPj4gDQo+ PiAzLiBJZiBjb2RlIGhvbGRzIGEgdmFsaWQgcG9pbnRlciB0byBhIHN0cnVjdHVyZS9vYmplY3Qg aXQgY2FuIGluY3JlYXNlDQo+PiByZWZjb3VudCB3aXRoIHJlZmNudF9nZXQoKS4gTm8gYWRkaXRp b25hbCBsb2NraW5nIGlzIHJlcXVpcmVkLg0KPj4gDQo+PiA0LiBDb2RlIHNob3VsZCBjYWxsIHJl ZmNudF9wdXQoKSBiZWZvcmUgZHJvcHBpbmcgcG9pbnRlciB0byBhDQo+PiBwcm90ZWN0ZWQgc3Ry dWN0dXJlLiBgZGVzdHJ1Y3RvcmAgaXMgYSBjYWxsIGJhY2sgZnVuY3Rpb24gdGhhdCBzaG91bGQN Cj4+IGRlc3RydWN0IG9iamVjdCBhbmQgZnJlZSBhbGwgcmVzb3VyY2VzLCBpbmNsdWRpbmcgc3Ry dWN0dXJlIHByb3RlY3RlZA0KPj4gaXRzZWxmLiBEZXN0cnVjdG9yIHdpbGwgYmUgY2FsbGVkIGlm IHJlZmVyZW5jZSBjb3VudGVyIHJlYWNoZXMgemVyby4NCj4+IA0KPj4gNS4gSWYgY29kZSBkb2Vz IG5vdCBob2xkIGEgdmFsaWQgcG9pbnRlciB0byBhIHByb3RlY3RlZCBzdHJ1Y3R1cmUgaXQNCj4+ IHNob3VsZCB1c2Ugb3RoZXIgbG9ja2luZyBtZWNoYW5pc20gdG8gb2J0YWluIGEgcG9pbnRlci4g Rm9yIGV4YW1wbGUsDQo+PiBpdCBzaG91bGQgbG9jayBhIGxpc3QgdGhhdCBob2xkIHByb3RlY3Rl ZCBvYmplY3RzLg0KPg0KPiBTb3JyeSwgSSBkaWRuJ3QgbG9vayBhdCB0aGUgcHJldmlvdXMgdmVy c2lvbnMsIGJ1dCBkaWQgd2UgY29uc2lkZXINCj4gaW1wb3J0aW5nIHJlZmNvdW50X3QgYW5kIHJl bGF0ZWQgbG9naWMgZnJvbSBMaW51eD8NCg0KV2VsbCwgSSBjb25zaWRlcmVkIHRoaXMuIEJ1dCBp dCBpcyBtb3JlIGNvbXBsZXguIEl0IGhhcyBzZXBhcmF0ZQ0KcmVmY291bnQgbW9kdWxlLCB3aGlj aCBqdXN0IGNvdW50cyByZWZlcmVuY2VzICsga3JlZiBjb2RlLCB0aGF0IGlzDQpjYXBhYmxlIG9m IGNhbGxpbmcgZGVzdHJ1Y3RvcnMuIEkgYW0gbm90IHN1cmUgaWYgWGVuIG5lZWQgdGhpcw0KZGl2 aXNpb24uIEluIGFueSBjYXNlLCBJIHRyaWVkIHRvIHJlcGxpY2F0ZSBMaW51eCBiZWhhdmlvciBh cyBjbG9zZSBhcw0KcG9zc2libGUuIE9uIG90aGVyIGhhbmQsIEphbiBzdWdnZXN0cyB0byByZXdv cmsgQVBJLCBzbyBpdCB3aWxsIGJlDQpkaWZmZXIgZnJvbSBMaW51eCBvbmUuLi4NCg0KLS0gDQpX QlIsIFZvbG9keW15cg== From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519961.807090 (Exim 4.92) (envelope-from ) id 1pmMdu-0003Km-4l; Tue, 11 Apr 2023 22:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519961.807090; Tue, 11 Apr 2023 22:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMdu-0003Kf-1n; Tue, 11 Apr 2023 22:39:14 +0000 Received: by outflank-mailman (input) for mailman id 519961; Tue, 11 Apr 2023 22:39:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMds-0003KZ-Mg for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:39:12 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad00b5c5-d8b9-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 00:39:11 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33BEvnMg025232; Tue, 11 Apr 2023 22:39:01 GMT Received: from eur04-db3-obe.outbound.protection.outlook.com (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3pvr2vmgca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2023 22:39:01 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by GVXPR03MB8425.eurprd03.prod.outlook.com (2603:10a6:150:5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 22:38:57 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3%3]) with mapi id 15.20.6277.034; Tue, 11 Apr 2023 22:38:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad00b5c5-d8b9-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvJjmrM7M3IQZEKpfk/1/0fX7L+q3Hpr5kVbX5otyatiHmap6aWNVzCv3UWCIFHo84zOqPb2DL9OrWWBoa3sBhiGK0BQHPemLXePDcpaj0dRtxcVdymd0Q/6xf4LXcAtRPbSd1s2YQgDufk3F1wrT5GK2ENkt3tJwRutRCD+wj1GdgcPkkXooc+sZe5dQT1NLlfVLhycmQwCoeKv6jvfGyuZ8Ea+obmyep/v7dOZt1gH0DyIzrWhXaFQFlvc4yPk0SJiPtxeHSgmX5oe7+56IGK7iJOEYM3zYLPdg1Xu5Fh3X9MMJlJxJ6oREIuBjxUcYWK1I43GTj6yK2r8TjQZ2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BVMeI+YDw0P+RLQYwajulzk0QC6yTYde2vQfAduLjHg=; b=TV3TpcHLdqKn1LvUqmrKQRvANg4jmrh+kb1hvNiPU1KECCjK1I+RvvkLMA7skNkH3CSs2gcq0ki1oeudY6EYyWuoDw/afdFbtDgPneAobBLf8lEphoAB3j+DUk6ml380oNtXJp1t4uV8M6V1Ev7EzKy9w9cVUezVpr9GUZX6TeqzKERDKvcch9ZILdAZZM4fXlzFHCAkVQk9q+GQ5ZoMzHw9OVzB4wNkZhPKgEF1qtMotjM+7u+aEfpszTme6fI0dD4WAhBg4KQcpJXRtPpdj/EyvSkDmsDz5Wul5q2WyhT2re+IWciY090z4uCa9I9wV1XUXZKTrRYvK9MRMsrqjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BVMeI+YDw0P+RLQYwajulzk0QC6yTYde2vQfAduLjHg=; b=TRC9N0pKEFakCEQcosA1+oR6wtQ6Vk4qMRgN5wlHEKSNWaHnG6czy/LKIVd23zUcw+QU7tf9PLONtUSz4rlLRmJQgZBVaPSft9fpILfq3z/Cj4PdhsmSFbYooUCD/n65R8KMeR2ikNnQEVF7as3bQHtHkSItrp4/jGWcBYfkGlxj0CJ8Bk9RgCnxBfeeiV/+2cGBrWA1xsWyTz+PCbHxxdaS5bRccZGgFUpZXXbMpH7tPXRvIool04o31fvKMKCsUA6gfnRjwTZpVQuBiXrQdSCH1Xgh9eK0ASlZXsIwoauQ5e+tbtt9ANnvGspEkWTTjIdn2hOYgAqbpO96bJm89w== From: Volodymyr Babchuk To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 1/6] xen: add reference counter support Thread-Topic: [PATCH v3 1/6] xen: add reference counter support Thread-Index: AQHZVrdyBx9pogLqRUq3RbhGdjZNSK79pIaAgCk3xwA= Date: Tue, 11 Apr 2023 22:38:56 +0000 Message-ID: <87a5zexcw0.fsf@epam.com> References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-2-volodymyr_babchuk@epam.com> <57c7c2e4-ae68-19c4-2140-f5a41fc1a6d3@suse.com> In-Reply-To: <57c7c2e4-ae68-19c4-2140-f5a41fc1a6d3@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|GVXPR03MB8425:EE_ x-ms-office365-filtering-correlation-id: 2a2fc1da-2c54-474f-1513-08db3add8921 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kU/Txwe+dAk1M/l+7jEholiJn3Oz0mP3gb+cKtxlXml6sW5zy0Dwmk/H7Ln7tEBv45db919C6kx1gBDT7o81Pn9rvG7IUSG7xcQXbWuN0Q+RNxw36Nql7Ms57+M3E2BzQu3me2yusckCR4v8OgcnTzD7VMJVuaiJlyvGLFp/c/DRKSr3Dj0JtjJf92N8B2ojnkqnq1ys2UBh5CmIrplc00K0YS4+Sor1mLlBB/xjb6i1I0pwG5KzHwbzRlpH/ZWexbubd3fkk7uJXWeU7Q1mZRWlQZSWueWpHV2fy6iNhyDJo20Jkj/ekmoOuvZAufXPqEKYSFD9oRbeJ1Yv7fg5mHao9tkxrI3Iq/C8KvKX19B+QS9axzoajFfXTa4kp6LdZdFWzQMwB6aH5YEYsPQvMCh6KdwmJTEzgr1bv/TDxYJTQAj87kODpx5667cOuHgxhw3vUZfpPm2di55ZMamt0VdeK5dC+mOmH9lCFgMOdZlmaHxiG6hjx7hgKVql7J44VnJ0fmjG86RYxvEaC03LmlJ7aK6pZJrRuQ6Twgmou+obetyGCRINKYEVNMDZiKJfqJWSDqA1Sxr7eq++3jOc1nAPT4fBIyKKw2ISmuK+Lma9kAqj+p+PWiqQylvP2Ljd x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(396003)(366004)(39860400002)(136003)(451199021)(53546011)(55236004)(478600001)(26005)(54906003)(38100700002)(6512007)(6506007)(186003)(8676002)(8936002)(316002)(41300700001)(66476007)(66946007)(66556008)(64756008)(6916009)(66446008)(122000001)(4326008)(76116006)(86362001)(36756003)(71200400001)(6486002)(91956017)(2616005)(2906002)(83380400001)(38070700005)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?3f7QP3NMdyqKNHAJXTIEhib5iE7Y6uhPluRIyYF4EUyQsiuez5w6uSEje/?= =?iso-8859-1?Q?edYwGvsmCnhO/X6UbtiI0RFxMtAXztaNh9u6Y/I+TIxXx+so0R8xm6Jvgt?= =?iso-8859-1?Q?dXgNgv+OhbrGv4B8H8PTMEPr9MELYVm6opAtzGeo4iJjAC2Ss9oHTwh883?= =?iso-8859-1?Q?rANJDbHqcPezlu5IaY6iMAxZllkxtyXLvegMn4Wf7l6uGZ+lTKpyDgVoiK?= =?iso-8859-1?Q?6V/aAzZr+GwzwjmCIymLJBpdTDPwoOcwmqK+79pM9vFaQX4T7I8Y/S14oS?= =?iso-8859-1?Q?ilQeeDw8cTqpE9VwBAabFlqUhoiNXid/AeLnxN3w5NYYz2uDIiOQAvClgS?= =?iso-8859-1?Q?NmWz39Elz/w6CyHowirjI259M09De5Yj6A09XHyeQepquK0y9SpmppR19H?= =?iso-8859-1?Q?DegePslURKznI9MYavTok7alANncLq8+Jkeg0kIHlK9I+MIDy2QstoFmRl?= =?iso-8859-1?Q?AHR9MFYlx4torF+C+9u6m/VhrXTVSMkzLHFYfWGJEFvo30wCHvP056pGo+?= =?iso-8859-1?Q?yZs3Oc0MB5n2Azf4CeVI11/P4uFQZZOe36rW6o3kGiLIeeT8ZxDqVfknHm?= =?iso-8859-1?Q?lirnlHphSPJyQm1zycvXI42HIU282dFETlFf4tXd0PCRnPUbI/u+cPbzFg?= =?iso-8859-1?Q?c2RzEfOJK/XkgMUBlkp9PJoIcJl+rpKtG8S5q03InfGI3gO4HraCKTIg8S?= =?iso-8859-1?Q?8Zs1mICf0OB0TCQY0YzOxeXtlU9bUXHUOIuFCJH3crYwAMmVAcq/pzF3Dl?= =?iso-8859-1?Q?N6YR/HnKtWnUvk0ELcxiwcLxi3F8dnngnC5pnudhXSUuoF2qGeq7Y3nkIu?= =?iso-8859-1?Q?lBYB+Jw6uhX74V8Ckg1tv7/T3QwfTcqEGLvEqxEGkc3Scum9gc5JQwDaav?= =?iso-8859-1?Q?WF0J/evKz3ET626DNSL3Y6zBmFz222EGUf+Dh9m0xQi4BAc7PEt32v4zHS?= =?iso-8859-1?Q?FfI2FtopEMiRKRCI/kQ6bLkHAb6a9WL5FvIukVGACtAjCusL709tTM/OKm?= =?iso-8859-1?Q?moPgNqTwb+XjF8Pse/aJ04f/A1G4Fx4kl7Dj4LGM1qX5jTt6mG2MELAiI7?= =?iso-8859-1?Q?qJkbGYC3OjN53fUKXdwPkSbWgTmEjLDhZF5MnV5XCr4q/MtsDmoEm4iyRT?= =?iso-8859-1?Q?gyy9t2G2mBIw9eUKvO/UqY7mOCkZLWzV3IlAF1DbL3MnGjbr5zvA24r+uh?= =?iso-8859-1?Q?8eJ6EFgE12Q7R839I5TOMrBMJhE4W7249NC41vCl2vnqS3ujFBN5Adk3ft?= =?iso-8859-1?Q?HE4KhhTQKESE04eSNa3M6+/wSDH8pyYba0VMFBs0GDDPE/D7UBvYYXxoc+?= =?iso-8859-1?Q?YsP7Fgv/oo5ZUoZsFj2gy7SOgStk2sQZLXiBBiF0u9jBktJDz0Xk5b5a6t?= =?iso-8859-1?Q?9ukSx4U63wHw+L1MlqAiQTwhk6LAxJtIN303Lby/4Oj/aTDqQW/+GnFmj7?= =?iso-8859-1?Q?yySdmvG4B/ddU2YoFSe51tvN06Xmr+44mX81tT3kwwXuw3yiTQjAUNDl2G?= =?iso-8859-1?Q?lZgCUW8gnQsdpPZKyvOTqmcmb1FEjE0pxRbOB8B7BNXrpHpJqot3443MK+?= =?iso-8859-1?Q?zWfotLTs984clx9TbIOInLP/6P1iC7RU1M+lEGQPwBa3XupR2QCtSU3ZFg?= =?iso-8859-1?Q?+PEEDYs2LeyDj6l+W9mKTrJTwYvRcTG4HjsI93MDH8NgQi6RRbYqNfYQ?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2fc1da-2c54-474f-1513-08db3add8921 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 22:38:56.5586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: As8uLz4ga5JNBtS2OoY4lER6g8FAz3d2rgnzwWGOhBa4hcTIGL+BwgtTOQ2NatYQLl4TbJY6+ux11ReUTLAnoXfQQNNdg6wvx3xS/rtLRTI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR03MB8425 X-Proofpoint-GUID: GQyNidjuNw7Zjaqc_mizmRHmaTxCBT2b X-Proofpoint-ORIG-GUID: GQyNidjuNw7Zjaqc_mizmRHmaTxCBT2b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-11_16,2023-04-11_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 mlxscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=900 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304110204 Jan Beulich writes: > On 14.03.2023 21:56, Volodymyr Babchuk wrote: >> +static inline void refcnt_put(refcnt_t *refcnt, void (*destructor)(refc= nt_t *refcnt)) > > Hmm, this means all callers need to pass (and agree on) the supposedly > single destructor function that needs calling. Wouldn't the destructor > function better be stored elsewhere (and supplied to e.g. refcnt_init())? > I tried to replicate Linux approach. They provide destructor function every time. On other hand, kref_put() is often called from a wrapper function (like pdev_put() in our case), so destructor in fact, is provided only once. >> +{ >> + int ret =3D atomic_dec_return(&refcnt->refcnt); >> + >> + if ( ret =3D=3D 0 ) >> + destructor(refcnt); >> + >> + if ( unlikely(ret < 0)) >> + { >> + atomic_set(&refcnt->refcnt, REFCNT_SATURATED); > > It's undefined whether *refcnt still exists once the destructor was > called (which would have happened before we can make it here). While > even the atomic_dec_return() above would already have acted in an > unknown way in this case I don't think it's a good idea to access the > object yet another time. (Same for the "negative" case in > refcnt_get() then.) Okay, then I'll remove saturation logic. --=20 WBR, Volodymyr= From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519967.807100 (Exim 4.92) (envelope-from ) id 1pmMmO-0004tx-2t; Tue, 11 Apr 2023 22:48:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519967.807100; Tue, 11 Apr 2023 22:48:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmN-0004tq-W9; Tue, 11 Apr 2023 22:47:59 +0000 Received: by outflank-mailman (input) for mailman id 519967; Tue, 11 Apr 2023 22:47:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmM-0004tk-5y for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:47:58 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2060d.outbound.protection.outlook.com [2a01:111:f400:7e8d::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5186b5d-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:47:55 +0200 (CEST) Received: from DS7PR03CA0166.namprd03.prod.outlook.com (2603:10b6:5:3b2::21) by DM4PR12MB6349.namprd12.prod.outlook.com (2603:10b6:8:a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 22:47:51 +0000 Received: from DS1PEPF0000E650.namprd02.prod.outlook.com (2603:10b6:5:3b2:cafe::7d) by DS7PR03CA0166.outlook.office365.com (2603:10b6:5:3b2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 22:47:51 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E650.mail.protection.outlook.com (10.167.18.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:47:51 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:50 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 15:47:50 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:50 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5186b5d-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6Qst0FnUKccO1kawVj0Dr4+p8lN8Hh2C3K9lbNrYo8JaCaCOqWqCCDlzpLJJ+eABmiiVNNaxs4CUkEKVFAJdhet2zyeUcRi35CRZcueTfrIaFH619Nt5D0u5wrrmILjhwbX1jNx96LAzGLDI51X1b1FgYbyeIgA+brj9w9WkzF3v55rKaZm8ZYIv1fehyZkRaiNTpXk319FRfXRkmcOfFFTlCvjm8dBEubQrpJ2Y38EnGQQOSK9qYHvi/YZv0q3urjxvN7Z8+FkMcetYxr0HX09HLvi/zWgE7nQiLBLntcQ1tG3euNsiKEnF0GTsP6RJ4zoVdLPSm5HF6yF1rZ6FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ekDE0eiudwYgbUq+PMKOx/34dRSx7wTAoRnsZ6NgBnA=; b=RZoZntukHShejgj3EW3bAPo1nQJYc+w8FE3wy4vepXElKJ6xyUqOCM43lr4JnAHD6tXv2E0YqfrUj+67h7H1b5nOEScbUqOQFdGQ3QNZavpkqvFWkri+88aiRMItYUBwzdUXNeBqkVg/PSW8F//OxuHLtLo+7HJQRLggoVLVIprCH4m2coAci17Iwjn4slpxL/DXXcH7JskFoWwojWmd0t7jrO5zibkFI/pGciPj2RL95sGDNEz74PgJa77Agsr+SFIpQnPfXU2WLMcNyNMzYZ+GKgQv2nCWmDEw9udTRznfB8vDyqyMvvnnx9RhZLDG+UHWaJDPfEJh7VKUFOb2gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekDE0eiudwYgbUq+PMKOx/34dRSx7wTAoRnsZ6NgBnA=; b=hAoInk28qiStAOXZBrt5jGkhwuULYdrRY2iAFjPDOb3di+nwYN0+4Ts58iU4N4v8RDN0PGF7tGqlOeNUhfRr/bwn5aTaeEZg3nOad+oxjoIZHvS++CtEZXUdyiMCbWT6yLBEI8IDTEuhfWGg9UJKK55bd5pnGtqNQGZ5/oPMzcw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , Subject: [QEMU][PATCH v6 00/10] Introduce xenpvh machine for arm architecture Date: Tue, 11 Apr 2023 15:47:36 -0700 Message-ID: <20230411224746.16152-1-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E650:EE_|DM4PR12MB6349:EE_ X-MS-Office365-Filtering-Correlation-Id: 73f2d8bf-93ae-4be7-dcb6-08db3adec7e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MlzEbrGaZYdcCuRU2YlSvmSMwspQVOYTm5smEpGJnCAQNXD5/9xFne8JYmJKqGHD7SWIW1geF2plrQUd2naINYYqGA3eIihXs16TF+GiEjO67txRFAvEWaig5Vo0p3k/flVBhO0dJmY2hIoa8y313lLhaKHnyr4LmLcxMRVyhXEmbUdcAxr/0jz8Mt+JWx+K9oTDBmsLhKIZquFba+zLv4In4dv8uyLdXvFUVTP9jHamz+xMc4y8A+6g3ZprtQIBfRz/w7qrfJu5tf576GWY6P92yPO2rVdOZaNBGNQ7I+i6+M+cW2Im6mxxqnMcB4akOWdxxZZrouX/Nm8NjmRZdgvQd3iv+grtofKuexfh30RhxmBosTFhP6KH82pRE7kIC9RfH6pED6kcBAbyz+7xLCkdVJtxr/p8sAi0Vd2dORQ2LWOxyjkoDe3Gb8hk72x4A3MNqBdCT+BiPDd90xaEnOO0IEWz6cU8AO9RdDiPvwMYLIJF1S/FLFu2anVY2z61xvDBEIpPrj9nbLaUItTu767SxlHr2qY6CiZ/xDQtIDWDTYUmn2OXmfEv/kLVA5eY6t8wSXRM8saSN+dF0fcCf5EjxP1+tfxbI3XiqrNIG/XNJvKF2rVULEKk5IAxP62/HIAZLV7U+bnb+TDpHJvyka4wUjhrUKo05lL5FH8J2Qo7rToG5UTpBv5yFhDcmRHU/7Ij6huJhwVkRAQoOh3KnHglt0jyljqa3x1gsvzMhuM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199021)(36840700001)(46966006)(40470700004)(36756003)(86362001)(41300700001)(70586007)(316002)(478600001)(6916009)(4326008)(966005)(70206006)(8676002)(54906003)(40480700001)(36860700001)(5660300002)(82310400005)(44832011)(2906002)(8936002)(81166007)(47076005)(82740400003)(356005)(186003)(6666004)(26005)(1076003)(2616005)(426003)(336012)(83380400001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:47:51.3091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73f2d8bf-93ae-4be7-dcb6-08db3adec7e4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E650.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6349 Hi, Rebased and resending the series with latest QEMU as it's been quite sometime. There are no code changes. Also, this series has dependency on following gitlab-ci patch: https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg01641.html. This series add xenpvh machine for aarch64. Motivation behind creating xenpvh machine with IOREQ and TPM was to enable each guest on Xen aarch64 to have it's own unique and emulated TPM. This series does following: 1. Moved common xen functionalities from hw/i386/xen to hw/xen/ so those can be used for aarch64. 2. We added a minimal xenpvh arm machine which creates an IOREQ server and support TPM. Also, checkpatch.pl fails for 03/12 and 06/12. These fails are due to moving old code to new place which was not QEMU code style compatible. No new add code was added. Regards, Vikram ChangeLog: v5->v6: rebased series with latest branch. No code change. v4->v5: Fix missing 3 lines of codes in xen_exit_notifier() due to rebase. Fix 07/10 patch subject. v3->v4: Removed the out of series 04/12 patch. v2->v3: 1. Change machine name to xenpvh as per Jurgen's input. 2. Add docs/system/xenpvh.rst documentation. 3. Removed GUEST_TPM_BASE and added tpm_base_address as property. 4. Correct CONFIG_TPM related issues. 5. Added xen_register_backend() function call to xen_register_ioreq(). 6. Added Oleksandr's suggestion i.e. removed extra interface opening and used accel=xen option v1 -> v2 Merged patch 05 and 06. 04/12: xen-hvm-common.c: 1. Moved xen_be_init() and xen_be_register_common() from xen_register_ioreq() to xen_register_backend(). 2. Changed g_malloc to g_new and perror -> error_setg_errno. 3. Created a local subroutine function for Xen_IOREQ_register. 4. Fixed build issues with inclusion of xenstore.h. 5. Fixed minor errors. Stefano Stabellini (5): hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common include/hw/xen/xen_common: return error from xen_create_ioreq_server hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure meson.build: do not set have_xen_pci_passthrough for aarch64 targets Vikram Garhwal (5): hw/i386/xen/: move xen-mapcache.c to hw/xen/ hw/i386/xen: rearrange xen_hvm_init_pc hw/xen/xen-hvm-common: Use g_new and error_report hw/arm: introduce xenpvh machine meson.build: enable xenpv machine build for ARM docs/system/arm/xenpvh.rst | 34 + docs/system/target-arm.rst | 1 + hw/arm/meson.build | 2 + hw/arm/xen_arm.c | 181 +++++ hw/i386/meson.build | 1 + hw/i386/xen/meson.build | 1 - hw/i386/xen/trace-events | 19 - hw/i386/xen/xen-hvm.c | 1075 +++--------------------------- hw/xen/meson.build | 7 + hw/xen/trace-events | 19 + hw/xen/xen-hvm-common.c | 879 ++++++++++++++++++++++++ hw/{i386 => }/xen/xen-mapcache.c | 0 include/hw/arm/xen_arch_hvm.h | 9 + include/hw/i386/xen_arch_hvm.h | 11 + include/hw/xen/arch_hvm.h | 5 + include/hw/xen/xen-hvm-common.h | 99 +++ include/hw/xen/xen_native.h | 13 +- meson.build | 4 +- 18 files changed, 1350 insertions(+), 1010 deletions(-) create mode 100644 docs/system/arm/xenpvh.rst create mode 100644 hw/arm/xen_arm.c create mode 100644 hw/xen/xen-hvm-common.c rename hw/{i386 => }/xen/xen-mapcache.c (100%) create mode 100644 include/hw/arm/xen_arch_hvm.h create mode 100644 include/hw/i386/xen_arch_hvm.h create mode 100644 include/hw/xen/arch_hvm.h create mode 100644 include/hw/xen/xen-hvm-common.h -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519969.807120 (Exim 4.92) (envelope-from ) id 1pmMmS-0005Ov-KU; Tue, 11 Apr 2023 22:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519969.807120; Tue, 11 Apr 2023 22:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmS-0005Om-G2; Tue, 11 Apr 2023 22:48:04 +0000 Received: by outflank-mailman (input) for mailman id 519969; Tue, 11 Apr 2023 22:48:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmQ-0004tk-QV for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:02 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060c.outbound.protection.outlook.com [2a01:111:f400:7eaa::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e857821c-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:00 +0200 (CEST) Received: from DM5PR07CA0070.namprd07.prod.outlook.com (2603:10b6:4:ad::35) by PH8PR12MB6817.namprd12.prod.outlook.com (2603:10b6:510:1c8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 11 Apr 2023 22:47:54 +0000 Received: from DS1PEPF0000E653.namprd02.prod.outlook.com (2603:10b6:4:ad:cafe::cc) by DM5PR07CA0070.outlook.office365.com (2603:10b6:4:ad::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 22:47:54 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E653.mail.protection.outlook.com (10.167.18.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:47:54 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:53 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 15:47:53 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:52 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e857821c-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hz5163pAoWJ2ZQ+zoM+kkRyAWo7OO6avTpHz7Bu983vvbR86QwVdAw5Z5uKjbSOhB1swJskoQt71Bbt0x2q/ehy7SuSMcJEe8d+VxbnIbKjjx62Jwb1ajqIrA8ppf8Y7XLA6P+/rsiwj9DVG00R0k9QjArTGgE6PQUW2QY6Elu6Ssl/KvaNnGRXOu9f9Q0ylMT7K3PuiSn1lGrzwJZINPC7GLJdF1NxwJDBS7SRZ3g6i/94NrOuWvI3g6etbT7I3MK2N0uAA11OMxq88WfldGX6qXJP0F1DuBClMjtQuRLh9oFVlVdgBrxZqxRfIK7hEiE3YS7RS3LsmL0+aXGVNEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oDSuDO2maVMFN1l7RQU+96HCYXUpMutEwT5v2DbnewQ=; b=mEnJB6Ff/wZ04ogd0bSMarz5lOEj93I0ED1p0VnJZyxWXkNDmzOodZW0FqxnwupleHfYqgDTPZ/ybKOqhqbNNRheLQ6eR3TFK2oXZ3Lfabo1v9Dn2m2230ZnA3zMWO+YO2bRHa5yY1wEhPnIENhBoOWDJSTWtuAj4iHDxqY0NXtPcW3wWVBbVR6Qea/8yU23aF/Qm+11dGjFne3cjPcOPgRJDHTI50FeOhUNyoUZaK5OL+ktCo+16m6a9u/FUz1UkUScqCPLRq4irvdWtg27bapSxJ931PA9wPRcaBO8HLjFMA0tZSN4uZiETZGq/qZwLqOqQbrE9bexC9EC+legyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDSuDO2maVMFN1l7RQU+96HCYXUpMutEwT5v2DbnewQ=; b=biK3WJGL8H0acN6Y+3qlv00oO0m6n+AghO2mN4hHs4qSfV140GDaIwULltVJ+vsMpxA4NQW0Qkg3co9C8j2m/j+bZxYev6Hynvv1Zk+ON9MnfTsTmn+laYG7+p4itLX2wNir/f7H9549uurythBvJAjTjdZlva8aBCGIr6khxPE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , "Michael S. Tsirkin" , "Marcel Apfelbaum" , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Stefano Stabellini , "Anthony Perard" , Paul Durrant Subject: [QEMU][PATCH v6 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Date: Tue, 11 Apr 2023 15:47:37 -0700 Message-ID: <20230411224746.16152-2-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E653:EE_|PH8PR12MB6817:EE_ X-MS-Office365-Filtering-Correlation-Id: ba59163f-ef3b-4fb4-f65e-08db3adec9ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b+FTQ4VVXuGv7PY1pGM3+BrSHmgZQS0IbtfZO1oPmAXmuWvTUK7RdGQ57q+uhm2rBsU59uPQvwMF3fxfAyeC/9uq06+igiXDfgcOp+J03ZhgBpbOSk11LPPa+BVgTAF5riDvLGyAVb9gyqhoOWVKbcpmX4m+7EsPls7edeh24bNANKsdx31QXDFcuQ18o37Z+wE0zoGhOB38AVOm4VMBPt3Sb/GW5GDLeBN6rFCUrGp8yJdkJdODwCfEAjmPZY7MMIK3Qvjba3fVbBqdZbh2zoRGzot1STMhBnXbzQdKIPdRnJd5aUC84v70Qv4ACMoLKig2g2l44dWeUFT36T6v0CNi51j69aBXpu+rgsI9qmE0ZE+xH373G3wABZhKChUPwR9Bu5WxMl07e2n8iKQdKcXI8K8VZmH4Y96DuITJsqc/akeKCLhCBuLt3PB/gtHFJUhaQSrX3u++DZhWe53vDMRPZ2jXYcC84ltDKBy8D2PUTdD+VN0JOn+gtZiWtlEhD5HUPb3xRF7gOHp6L9CUTgCRXmpC9+bPJw1bi0T2QkpLzTWEzHnpxiFuEIywt4mMPI9yzIm6yzrwzeGkHaPQ9/RgvAXSVht/BZ9aYfM/Ec5L6190C6hcBAM6eq/2KxSndDnU75e+OzE7z5DDwy+H6InAW92q20Ou5zy4brMvwBPWUsLvWm+OPovxsQIXb8AM1N9HOJjCtIaBBLb07Au6MwHrRn3dCQnBZY7qg5Qv7lQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199021)(40470700004)(46966006)(36840700001)(2906002)(86362001)(7416002)(336012)(426003)(82740400003)(5660300002)(40480700001)(478600001)(6916009)(2616005)(41300700001)(8936002)(36756003)(6666004)(40460700003)(4326008)(316002)(44832011)(70206006)(26005)(8676002)(70586007)(54906003)(356005)(186003)(1076003)(81166007)(82310400005)(47076005)(83380400001)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:47:54.3112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba59163f-ef3b-4fb4-f65e-08db3adec9ae X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E653.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6817 xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/meson.build | 1 + hw/i386/xen/meson.build | 1 - hw/i386/xen/trace-events | 5 ----- hw/xen/meson.build | 4 ++++ hw/xen/trace-events | 5 +++++ hw/{i386 => }/xen/xen-mapcache.c | 0 6 files changed, 10 insertions(+), 6 deletions(-) rename hw/{i386 => }/xen/xen-mapcache.c (100%) diff --git a/hw/i386/meson.build b/hw/i386/meson.build index 213e2e82b3..cfdbfdcbcb 100644 --- a/hw/i386/meson.build +++ b/hw/i386/meson.build @@ -33,5 +33,6 @@ subdir('kvm') subdir('xen') i386_ss.add_all(xenpv_ss) +i386_ss.add_all(xen_ss) hw_arch += {'i386': i386_ss} diff --git a/hw/i386/xen/meson.build b/hw/i386/xen/meson.build index 2e64a34e16..3dc4c4f106 100644 --- a/hw/i386/xen/meson.build +++ b/hw/i386/xen/meson.build @@ -1,6 +1,5 @@ i386_ss.add(when: 'CONFIG_XEN', if_true: files( 'xen-hvm.c', - 'xen-mapcache.c', 'xen_apic.c', 'xen_pvdevice.c', )) diff --git a/hw/i386/xen/trace-events b/hw/i386/xen/trace-events index 5d6be61090..a0c89d91c4 100644 --- a/hw/i386/xen/trace-events +++ b/hw/i386/xen/trace-events @@ -21,8 +21,3 @@ xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p" cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" -# xen-mapcache.c -xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64 -xen_remap_bucket(uint64_t index) "index 0x%"PRIx64 -xen_map_cache_return(void* ptr) "%p" - diff --git a/hw/xen/meson.build b/hw/xen/meson.build index 19c6aabc7c..202752e557 100644 --- a/hw/xen/meson.build +++ b/hw/xen/meson.build @@ -26,3 +26,7 @@ else endif specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss) + +xen_ss = ss.source_set() + +xen_ss.add(when: 'CONFIG_XEN', if_true: files('xen-mapcache.c')) diff --git a/hw/xen/trace-events b/hw/xen/trace-events index 55c9e1df68..f977c7c8c6 100644 --- a/hw/xen/trace-events +++ b/hw/xen/trace-events @@ -41,3 +41,8 @@ xs_node_vprintf(char *path, char *value) "%s %s" xs_node_vscanf(char *path, char *value) "%s %s" xs_node_watch(char *path) "%s" xs_node_unwatch(char *path) "%s" + +# xen-mapcache.c +xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64 +xen_remap_bucket(uint64_t index) "index 0x%"PRIx64 +xen_map_cache_return(void* ptr) "%p" diff --git a/hw/i386/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c similarity index 100% rename from hw/i386/xen/xen-mapcache.c rename to hw/xen/xen-mapcache.c -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519968.807110 (Exim 4.92) (envelope-from ) id 1pmMmR-00059C-BH; Tue, 11 Apr 2023 22:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519968.807110; Tue, 11 Apr 2023 22:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmR-000595-7b; Tue, 11 Apr 2023 22:48:03 +0000 Received: by outflank-mailman (input) for mailman id 519968; Tue, 11 Apr 2023 22:48:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmP-0004tk-E8 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:01 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20625.outbound.protection.outlook.com [2a01:111:f400:7e88::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e876fe83-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:47:59 +0200 (CEST) Received: from CYZPR12CA0006.namprd12.prod.outlook.com (2603:10b6:930:8b::22) by PH7PR12MB5830.namprd12.prod.outlook.com (2603:10b6:510:1d5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 22:47:56 +0000 Received: from CY4PEPF0000C97D.namprd02.prod.outlook.com (2603:10b6:930:8b:cafe::d6) by CYZPR12CA0006.outlook.office365.com (2603:10b6:930:8b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 22:47:55 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C97D.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.25 via Frontend Transport; Tue, 11 Apr 2023 22:47:55 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:55 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:54 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:53 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e876fe83-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ml8IWApAM/Y+CpPbi26hXoz1YL4wM93WnZqBELl/H4zJX5i5gZPZt2DOponO8axbIp3noPREdbZVku680ZxyyfHNFQmPW6BtMkeTjLYfCUAt9kt4iMV8Y72rNrTy1LLP9o2PHlbmnNzpgniIcGFUDBzE2shlBGaFeWZHr54F4xJbgBEtCnkKNwBsRS/y1Q/550xuYNs/3hMAR5S5O0g3MMqTBKP7OQUPidlmczNMzZI4YO5/g+Wz3keXqq4aO9IxDBK0mrbVwKsGMODjCgRaKdejCxKBBZ20ZqHBMCddJrS1U/10ARozQt+cKYhtdnCf8GcPsqsszEoWzi2kBtzARQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gNOkxasZFjLHtu5kunUMzoJvRLjjI2EYoAqF9wsm5vg=; b=lW9OBEfC+geE5ZV8JuGUvImaLGKjHO5xconbE/vP4EhPW9GMouL43COlAOhNyLO69dLnXv2JsXbJfQT7cf9tTUfM+gcZcC4oVirwMyZ00TmtgLGaSmKHZ3lXJyQ3SAHpJK/x96SjNOJH90f8aIiMOOWtGpxNUhtxAX5YhxAeZkoBawFtukWDBs758C79vuO7DaT0hh6r2daxyD/vhn60Y9fB2AYuRUSMEOV9kzOEnRkkc7bXapO1QBNyiQyOlq0SVKIT2u/P6RR+UHopjm60BePnfJfcHCe88cd4d7ugwC5pBSZ4zC3ZqYicH73BhMfnZxezmuXbB5Cop3cicw39nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gNOkxasZFjLHtu5kunUMzoJvRLjjI2EYoAqF9wsm5vg=; b=oKegRFjWBYeZxVDIZ+8JT+EP2sK3MNCEH7wS0/YCp3OjDYhRN2qzW38YpxBU7Oo9kXzAymrxv9i/6JmQfXC4TdX6cKfFNmzpAlZytU9k4vstKCym6SVx2WUNQXwSx5KUcsUgFwzKuFRMkT6ZZJJmREmvXZNDEEhnsPvXsm1Ytag= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , "Richard Henderson" , Eduardo Habkost Subject: [QEMU][PATCH v6 02/10] hw/i386/xen: rearrange xen_hvm_init_pc Date: Tue, 11 Apr 2023 15:47:38 -0700 Message-ID: <20230411224746.16152-3-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97D:EE_|PH7PR12MB5830:EE_ X-MS-Office365-Filtering-Correlation-Id: dbb9fae0-3dc9-4b6c-28fc-08db3adeca75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1DUA5dfU5ZEonWalEs4FC78dDWo+c5tHirqd+i1O168JJlsmlPIuXgEyTi/NGrKTt7sdxa9Up+mh1cDVTXHlUn8OfHw2gtVSGpkFjMd5ZKrwUiWvOw/EY2/JFQPXfYFGQUn8Ko79yK3o35i/wB4NioiKWdoVwbuw/60BGvLcsoCjxpsB0rFwClgbaofON4E33YMdmyCEsg+4W8JEePvyyKvuAPMGf10tmWo3Zj4fOOiJHMzae2VthQJjN4gEemN+69Bhadw0QwNgnAHZ3zUMmDGTBDdqe5LBr5b/JVAqzUQ/LqFukieK1v8vLjr842DaQG+CzERxkb7+iwwkbvEwb5QW88DH6h68ZxDhQf5q6C3Jq2kQSgWXfdWYyejk4XAUps3g2y+IV+CKitw40RPzsHpsn2Uzu/oWXqQMP7LJJEp/fnpfN1skxwacp1AgvghmWuNAX6FvXb+3KDD6dnLd3zbBT04CKZ5fRmOq0MO9UlbNrDJsNzBCQQtXfIeG6JYsA3CpuHXMyiWnkcZ8bMQ+GZ770DQA5+qfc8GvyGjAgMELqP6X8UqEuI8UOhlx2HgJ+YM7KyXbB0ZmwI6vTQnk43fxBYGiRA9bg3oE3K231yOdbH5d+Bq8lVKaHdXctX00opiGD3TXOY+/h7mks6yeSSRAQMVR1OApryO7aia/m4fU/uFC7E98EEl/mybZHxrtuS9xS1OD3eYY+kum7PQ8iQvcmWGaUYVT+mqLs5qR3LM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199021)(40470700004)(46966006)(36840700001)(2906002)(86362001)(36756003)(82310400005)(40480700001)(6666004)(2616005)(426003)(83380400001)(186003)(336012)(47076005)(36860700001)(26005)(1076003)(70586007)(478600001)(6916009)(4326008)(316002)(70206006)(40460700003)(7416002)(8936002)(356005)(82740400003)(41300700001)(8676002)(81166007)(5660300002)(44832011)(54906003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:47:55.5946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dbb9fae0-3dc9-4b6c-28fc-08db3adeca75 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5830 In preparation to moving most of xen-hvm code to an arch-neutral location, move non IOREQ references to: - xen_get_vmport_regs_pfn - xen_suspend_notifier - xen_wakeup_notifier - xen_ram_init towards the end of the xen_hvm_init_pc() function. This is done to keep the common ioreq functions in one place which will be moved to new function in next patch in order to make it common to both x86 and aarch64 machines. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/xen/xen-hvm.c | 49 ++++++++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 56641a550e..5403ac4b89 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -1419,12 +1419,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) state->exit.notify = xen_exit_notifier; qemu_add_exit_notifier(&state->exit); - state->suspend.notify = xen_suspend_notifier; - qemu_register_suspend_notifier(&state->suspend); - - state->wakeup.notify = xen_wakeup_notifier; - qemu_register_wakeup_notifier(&state->wakeup); - /* * Register wake-up support in QMP query-current-machine API */ @@ -1435,23 +1429,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) goto err; } - rc = xen_get_vmport_regs_pfn(xen_xc, xen_domid, &ioreq_pfn); - if (!rc) { - DPRINTF("shared vmport page at pfn %lx\n", ioreq_pfn); - state->shared_vmport_page = - xenforeignmemory_map(xen_fmem, xen_domid, PROT_READ|PROT_WRITE, - 1, &ioreq_pfn, NULL); - if (state->shared_vmport_page == NULL) { - error_report("map shared vmport IO page returned error %d handle=%p", - errno, xen_xc); - goto err; - } - } else if (rc != -ENOSYS) { - error_report("get vmport regs pfn returned error %d, rc=%d", - errno, rc); - goto err; - } - /* Note: cpus is empty at this point in init */ state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus); @@ -1490,7 +1467,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) #else xen_map_cache_init(NULL, state); #endif - xen_ram_init(pcms, ms->ram_size, ram_memory); qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); @@ -1511,6 +1487,31 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) QLIST_INIT(&xen_physmap); xen_read_physmap(state); + state->suspend.notify = xen_suspend_notifier; + qemu_register_suspend_notifier(&state->suspend); + + state->wakeup.notify = xen_wakeup_notifier; + qemu_register_wakeup_notifier(&state->wakeup); + + rc = xen_get_vmport_regs_pfn(xen_xc, xen_domid, &ioreq_pfn); + if (!rc) { + DPRINTF("shared vmport page at pfn %lx\n", ioreq_pfn); + state->shared_vmport_page = + xenforeignmemory_map(xen_fmem, xen_domid, PROT_READ|PROT_WRITE, + 1, &ioreq_pfn, NULL); + if (state->shared_vmport_page == NULL) { + error_report("map shared vmport IO page returned error %d handle=%p", + errno, xen_xc); + goto err; + } + } else if (rc != -ENOSYS) { + error_report("get vmport regs pfn returned error %d, rc=%d", + errno, rc); + goto err; + } + + xen_ram_init(pcms, ms->ram_size, ram_memory); + /* Disable ACPI build because Xen handles it */ pcms->acpi_build_enabled = false; -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519970.807129 (Exim 4.92) (envelope-from ) id 1pmMmU-0005fW-3J; Tue, 11 Apr 2023 22:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519970.807129; Tue, 11 Apr 2023 22:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmU-0005fP-0R; Tue, 11 Apr 2023 22:48:06 +0000 Received: by outflank-mailman (input) for mailman id 519970; Tue, 11 Apr 2023 22:48:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmS-0004tk-VH for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:04 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060a.outbound.protection.outlook.com [2a01:111:f400:7e89::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e882a2ec-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:02 +0200 (CEST) Received: from DM6PR13CA0038.namprd13.prod.outlook.com (2603:10b6:5:134::15) by PH7PR12MB8016.namprd12.prod.outlook.com (2603:10b6:510:26b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 11 Apr 2023 22:47:57 +0000 Received: from DS1PEPF0000E651.namprd02.prod.outlook.com (2603:10b6:5:134:cafe::1e) by DM6PR13CA0038.outlook.office365.com (2603:10b6:5:134::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 22:47:56 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E651.mail.protection.outlook.com (10.167.18.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:47:56 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:56 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:55 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:55 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e882a2ec-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhmBbkW6M1d9ZSz4x2jESuuyePSazESG2fD0YFKdqvuflVga/72KwMHuXUEOSbwSVXLOSCvqfC0h2i/WAWphU9EskfbMR0JeJPsh6Wu2OJfqmaZnE3ctyj3HnfunPgYOOWR9Ixr4uXPyaHGnUDQgv5X+H33khPYkzsEuCbayhSVxNQEdfY6yy388ZS10C7bUM0So+dpIquYDfTKNWXPBeSr5nifpzJdAwdiejmOeDyPBr3L2Imdd21m+XAZ2fPP6JD0206PD5CoqstcLhoIG/6nzfYIKLcmZHrCwwOSqYpnglvVL+b0evvnOBLCuox/xAnld9VD4AVsVPKnITZbItg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=moDpzrNRsIQ+F6BoWEVODEFb14KOCFj6iOm1H5bs3as=; b=Wans1hYuBlTzN/3t7kfC+V/wP468ERZEBREgIAB21ts2qahc6HzrknCBr+xYBYiFgQRwIzDKNm7omL4PhKhTdzV/Af5Qebpado190R2cZxbc8EEK61yjkorypyFzjEiySKJoNBu0mkiDCBkVz3oKR+YW0vT1GfM6+WN98IJvrpFXSIJiwXaz/BWgYr1TI3oT4XMRC/l+rAsi+XpOKSAhm5Zwk964bva8WsoAIhWVFigbCahY37tNfIhTn5QdrJekLOoeXhYZ9l4xAA2dxRTkCYScnsHVMs8zq2YHizVbg7afxYb4rwbH50xcSg7BXrAoQUjU12RZTeD44gUZ7aqeAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=moDpzrNRsIQ+F6BoWEVODEFb14KOCFj6iOm1H5bs3as=; b=gcw8KrKoSCZWiW+HFJBHzpP+cV2+8hLtl+UcIPqlnwFiACIG+QwQp4+Y+Q7PR8/v33hca1qiCdTA+YMctLeDgy2XbcspB0RI7iKmSO8koV7q2wxtWOZxXJ78qkIHLtqx1B+tCy/t8tm9a1A6amUbgY6E6OS0qV5EXnDWG7AnKWA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [QEMU][PATCH v6 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState Date: Tue, 11 Apr 2023 15:47:39 -0700 Message-ID: <20230411224746.16152-4-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E651:EE_|PH7PR12MB8016:EE_ X-MS-Office365-Filtering-Correlation-Id: 30c9e9f2-43c7-4571-57be-08db3adecb1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hEYdzjc5CRBT+IE/TU3KP1GB1I7xQjHd/SE6vP9u3A0EP85TmaOazB2J6nii2oIu0Q/BmZTCvAM/uhDv9rks8uj3/fWn5iCZ2X+wYLXae1uoJYDMxpiyg1V6CbO8suqQYSbvzlTBlQH98Tq0M6RfVODMiVx4ISWVd9EEHZcZecapnALI3GYr3gGGTc/9Wz4ZhZDE8Hk+LefvbicrIsbWQ4HvncGjwJ3gX2WbwySgxHxUgv7ZjGixPkq7u8JjnV6VXFRiIPFm5dZFZQgebLH4SnIwnLry7tEwP4LtPnhMJhLPJpqKqD1uF2OnW2XduQ+Ki4OW4kZpdCbR/iFGaOpdOM3/kmGHr1opUyghv3ID3pFcmrq2NrmFBK0ojSzOH5+ok6DrZj+fgQjZq4IVnRRb4Qvh8RFxPRmN9SJ2raBldidCVbRTT6t9eMXApZujiRCzz05z29q/88Zh3jtVnyUIatFYqdjH41/8Rv7TT+HRn08PBQfRGf5y0ZQ5U9r1Tkz/Hordd8CHctjm2hQxNFWzWoglnifxKgaes78UqFzMC3lAKjZXdBuLSCnY4ypOLL4SZ4Bqf9hDGBke72E4EmU9OxU9Jws9haN/TF/bKsL0t5sdeNNxjV0I9RXUlSh0rBaVgTD9VnOeM1UphzXNaAwnnP9XK0sCg9nvl+WB9LeSXzWP7S5qBG85scXwgk7JeOYavMb/GM+39/8oV+ETlHVeDw8ZmvRoC8nFWe5uddlN9rs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(5660300002)(7416002)(2906002)(41300700001)(54906003)(316002)(186003)(8936002)(8676002)(44832011)(70206006)(70586007)(478600001)(4326008)(6916009)(6666004)(47076005)(1076003)(356005)(336012)(26005)(40460700003)(81166007)(83380400001)(426003)(36756003)(40480700001)(2616005)(66574015)(82740400003)(36860700001)(82310400005)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:47:56.6993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30c9e9f2-43c7-4571-57be-08db3adecb1b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E651.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8016 From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated XenIOState can be used for both aarch64 and x86. Also, remove free_phys_offset as it was unused. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Paul Durrant Reviewed-by: Alex Bennée --- hw/i386/xen/xen-hvm.c | 58 ++++++++++++++++++++----------------------- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 5403ac4b89..6be5a250a8 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -74,6 +74,7 @@ struct shared_vmport_iopage { }; typedef struct shared_vmport_iopage shared_vmport_iopage_t; #endif +static shared_vmport_iopage_t *shared_vmport_page; static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i) { @@ -96,6 +97,11 @@ typedef struct XenPhysmap { } XenPhysmap; static QLIST_HEAD(, XenPhysmap) xen_physmap; +static const XenPhysmap *log_for_dirtybit; +/* Buffer used by xen_sync_dirty_bitmap */ +static unsigned long *dirty_bitmap; +static Notifier suspend; +static Notifier wakeup; typedef struct XenPciDevice { PCIDevice *pci_dev; @@ -106,7 +112,6 @@ typedef struct XenPciDevice { typedef struct XenIOState { ioservid_t ioservid; shared_iopage_t *shared_page; - shared_vmport_iopage_t *shared_vmport_page; buffered_iopage_t *buffered_io_page; xenforeignmemory_resource_handle *fres; QEMUTimer *buffered_io_timer; @@ -126,14 +131,8 @@ typedef struct XenIOState { MemoryListener io_listener; QLIST_HEAD(, XenPciDevice) dev_list; DeviceListener device_listener; - hwaddr free_phys_offset; - const XenPhysmap *log_for_dirtybit; - /* Buffer used by xen_sync_dirty_bitmap */ - unsigned long *dirty_bitmap; Notifier exit; - Notifier suspend; - Notifier wakeup; } XenIOState; /* Xen specific function for piix pci */ @@ -463,10 +462,10 @@ static int xen_remove_from_physmap(XenIOState *state, } QLIST_REMOVE(physmap, list); - if (state->log_for_dirtybit == physmap) { - state->log_for_dirtybit = NULL; - g_free(state->dirty_bitmap); - state->dirty_bitmap = NULL; + if (log_for_dirtybit == physmap) { + log_for_dirtybit = NULL; + g_free(dirty_bitmap); + dirty_bitmap = NULL; } g_free(physmap); @@ -627,16 +626,16 @@ static void xen_sync_dirty_bitmap(XenIOState *state, return; } - if (state->log_for_dirtybit == NULL) { - state->log_for_dirtybit = physmap; - state->dirty_bitmap = g_new(unsigned long, bitmap_size); - } else if (state->log_for_dirtybit != physmap) { + if (log_for_dirtybit == NULL) { + log_for_dirtybit = physmap; + dirty_bitmap = g_new(unsigned long, bitmap_size); + } else if (log_for_dirtybit != physmap) { /* Only one range for dirty bitmap can be tracked. */ return; } rc = xen_track_dirty_vram(xen_domid, start_addr >> TARGET_PAGE_BITS, - npages, state->dirty_bitmap); + npages, dirty_bitmap); if (rc < 0) { #ifndef ENODATA #define ENODATA ENOENT @@ -651,7 +650,7 @@ static void xen_sync_dirty_bitmap(XenIOState *state, } for (i = 0; i < bitmap_size; i++) { - unsigned long map = state->dirty_bitmap[i]; + unsigned long map = dirty_bitmap[i]; while (map != 0) { j = ctzl(map); map &= ~(1ul << j); @@ -677,12 +676,10 @@ static void xen_log_start(MemoryListener *listener, static void xen_log_stop(MemoryListener *listener, MemoryRegionSection *section, int old, int new) { - XenIOState *state = container_of(listener, XenIOState, memory_listener); - if (old & ~new & (1 << DIRTY_MEMORY_VGA)) { - state->log_for_dirtybit = NULL; - g_free(state->dirty_bitmap); - state->dirty_bitmap = NULL; + log_for_dirtybit = NULL; + g_free(dirty_bitmap); + dirty_bitmap = NULL; /* Disable dirty bit tracking */ xen_track_dirty_vram(xen_domid, 0, 0, NULL); } @@ -1022,9 +1019,9 @@ static void handle_vmport_ioreq(XenIOState *state, ioreq_t *req) { vmware_regs_t *vmport_regs; - assert(state->shared_vmport_page); + assert(shared_vmport_page); vmport_regs = - &state->shared_vmport_page->vcpu_vmport_regs[state->send_vcpu]; + &shared_vmport_page->vcpu_vmport_regs[state->send_vcpu]; QEMU_BUILD_BUG_ON(sizeof(*req) < sizeof(*vmport_regs)); current_cpu = state->cpu_by_vcpu_id[state->send_vcpu]; @@ -1472,7 +1469,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) state->memory_listener = xen_memory_listener; memory_listener_register(&state->memory_listener, &address_space_memory); - state->log_for_dirtybit = NULL; state->io_listener = xen_io_listener; memory_listener_register(&state->io_listener, &address_space_io); @@ -1487,19 +1483,19 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) QLIST_INIT(&xen_physmap); xen_read_physmap(state); - state->suspend.notify = xen_suspend_notifier; - qemu_register_suspend_notifier(&state->suspend); + suspend.notify = xen_suspend_notifier; + qemu_register_suspend_notifier(&suspend); - state->wakeup.notify = xen_wakeup_notifier; - qemu_register_wakeup_notifier(&state->wakeup); + wakeup.notify = xen_wakeup_notifier; + qemu_register_wakeup_notifier(&wakeup); rc = xen_get_vmport_regs_pfn(xen_xc, xen_domid, &ioreq_pfn); if (!rc) { DPRINTF("shared vmport page at pfn %lx\n", ioreq_pfn); - state->shared_vmport_page = + shared_vmport_page = xenforeignmemory_map(xen_fmem, xen_domid, PROT_READ|PROT_WRITE, 1, &ioreq_pfn, NULL); - if (state->shared_vmport_page == NULL) { + if (shared_vmport_page == NULL) { error_report("map shared vmport IO page returned error %d handle=%p", errno, xen_xc); goto err; -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519971.807134 (Exim 4.92) (envelope-from ) id 1pmMmU-0005iG-Ft; Tue, 11 Apr 2023 22:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519971.807134; Tue, 11 Apr 2023 22:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmU-0005hJ-9Q; Tue, 11 Apr 2023 22:48:06 +0000 Received: by outflank-mailman (input) for mailman id 519971; Tue, 11 Apr 2023 22:48:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmT-0004tk-AL for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:05 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20628.outbound.protection.outlook.com [2a01:111:f400:7e89::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eaba3a4e-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:03 +0200 (CEST) Received: from DM6PR07CA0127.namprd07.prod.outlook.com (2603:10b6:5:330::28) by SJ2PR12MB8064.namprd12.prod.outlook.com (2603:10b6:a03:4cc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 22:48:00 +0000 Received: from DS1PEPF0000E64E.namprd02.prod.outlook.com (2603:10b6:5:330:cafe::b3) by DM6PR07CA0127.outlook.office365.com (2603:10b6:5:330::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35 via Frontend Transport; Tue, 11 Apr 2023 22:47:59 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E64E.mail.protection.outlook.com (10.167.18.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:47:59 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:58 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 15:47:58 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:57 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaba3a4e-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YD2Sjvqw1aiCb/5kve5wM4Bz/reAjtkCRm1Bz1PzaJAg3ac3PjndSuNORPqR4weXADEWEJAK1GLDKJJEhNmAbCj3VAuq6azfHDLcnHvQ3bEHjRo1GPdUESOsak21BurEHu6eCJa/IXMjpDBep4prig6MZOYPlRJg7qg4PTGbLARsYYzTXUshn5yH8vLBvxr23vvGUIhHcQJ1n2XF8TpAVF52pR8e9PeucwlHOB55FumD7xaKzGpB3uQg40NriAGF3DD/BRnS+sD9PqNdWLlwczTxbQzB/T+CXw4lVHncO8UzTyqV/UoAa5mvMHtNkkL7lc/xmfVao06e/WMgPJCfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FMxXRBFxRmkD0pWrYu+sj44qnNzbURauoioUBy1Lo+4=; b=U5KMC9g4P5MHtmS6GLiha1q6hKu1eSxJ7jtVF4QwVignsYxpiZg6aAsTkNP+RRylwFHJr3uw8dqov33uroCaTrU/tktbRSL5Q67b924H5me+1YK6EXHRyLBq99SQMXHmkWMxx82JqBJAOH8crsa4aw2j5bNtWQIbSCsoEBZt5dfVvmTZAbP4zLEwv1nwFVpXGYWALqaX4Rn5GSOmI5NIFrSpGz13F5eQcM75i4PCyo+HAw+m+hYwfAqHmrNcfDxqzsDDlAIfYUACMdT6Vh+l5GIK/vRfgB6/w60UFGJ3q+h9jX1okXLkmg8oW6jCiogC1yIxkI5aRYIbp2j3yqlCfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMxXRBFxRmkD0pWrYu+sj44qnNzbURauoioUBy1Lo+4=; b=yUBAoDuJqmaZVGyBnfL0Dq0J48SosZrNjzgJXHQW/TYeQ8TQO32JpJZzh6CsduofqeSGBWCdNwTaadZ2gRiSTRn0CSPm72YgZt4lTZ8K/eFqolMBLX7ifoVKmceSouuJ4ET5HynkrbMW1LtBUpTZ99Zz659z6+tIrIBw3yhMAuk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: [QEMU][PATCH v6 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server Date: Tue, 11 Apr 2023 15:47:41 -0700 Message-ID: <20230411224746.16152-6-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E64E:EE_|SJ2PR12MB8064:EE_ X-MS-Office365-Filtering-Correlation-Id: afb312bc-de3f-4ebc-60d9-08db3adecc92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: obenWLWhq6bdrYeodulUvswme8fWEcMGn7qxPqRobjL/QaGgmCOIsSUGuNOX02ssYXN/5TsJ59VzleK+FoDZlUpoSiiO1j0uaDOvyRk+Ts3eg3Oy5n7dC1Ip0QgPN5x1FrWc/9UempJCZQZILuDo4vKo+OZElGTVaYJ7Mz8UKW5ib720tn6PHf9qe6MXfojbwJbzYQ46MW5SyyU+xdhrcbMcq8o6IomAs+nRwI/FjqMp825ujie3MMSWrrLfv2YjDdAoljykKkzDxlTWWGWAiYgAuKOwBBqp0K2anabLPQmUr3IOIP6TRpoPIqEvDuLE+ryPKxLaVBNXAoiV90x3xiy5dEpn9qN9ZQcBJB3mqOMucgF1/enNNjPafIvixZP3FUgO3t9umkr2IevaAh3pJeajfPhjDUMDyZHJbQBIEnYgxKBxngZ5kVoNzGAGai+g91IYXsmufLrvpAt7h42FkBOQbvd9hRNam/zWRRCPYV5sp5XT+9B1pTRa8aR3nBcvOWyzHcjBSS4Mi8umgWv8eTZ4CMfdmZ3UAcSCXIhPrPrqlvI5BpMjcXPEAAq81uL4SKFbId7kqouT4uS/VH0ExKbElvX2mUy2Djw4Rh0JE/aXLPpelx6g3Dpj1Zny+gFQQ2uQfvxCJ5eGD7BHcucddBTm0zyUIbzOhq8l4Hv3lHMtXUCEOfMNy8UDJHOpxtqpRwD3b6tjcadMwykfSQhKvRIv+nawL5i9dsoocwqV6vM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199021)(36840700001)(40470700004)(46966006)(36756003)(86362001)(41300700001)(316002)(478600001)(70206006)(4326008)(8676002)(6916009)(70586007)(54906003)(40480700001)(36860700001)(5660300002)(82310400005)(2906002)(44832011)(8936002)(81166007)(47076005)(82740400003)(356005)(186003)(6666004)(26005)(1076003)(2616005)(426003)(336012)(83380400001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:47:59.1727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afb312bc-de3f-4ebc-60d9-08db3adecc92 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E64E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8064 From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- include/hw/xen/xen_native.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h index 6bcc83baf9..8b01b071e5 100644 --- a/include/hw/xen/xen_native.h +++ b/include/hw/xen/xen_native.h @@ -433,9 +433,10 @@ static inline void xen_unmap_pcidev(domid_t dom, { } -static inline void xen_create_ioreq_server(domid_t dom, - ioservid_t *ioservid) +static inline int xen_create_ioreq_server(domid_t dom, + ioservid_t *ioservid) { + return 0; } static inline void xen_destroy_ioreq_server(domid_t dom, @@ -566,8 +567,8 @@ static inline void xen_unmap_pcidev(domid_t dom, PCI_FUNC(pci_dev->devfn)); } -static inline void xen_create_ioreq_server(domid_t dom, - ioservid_t *ioservid) +static inline int xen_create_ioreq_server(domid_t dom, + ioservid_t *ioservid) { int rc = xendevicemodel_create_ioreq_server(xen_dmod, dom, HVM_IOREQSRV_BUFIOREQ_ATOMIC, @@ -575,12 +576,14 @@ static inline void xen_create_ioreq_server(domid_t dom, if (rc == 0) { trace_xen_ioreq_server_create(*ioservid); - return; + return rc; } *ioservid = 0; use_default_ioreq_server = true; trace_xen_default_ioreq_server(); + + return rc; } static inline void xen_destroy_ioreq_server(domid_t dom, -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519972.807150 (Exim 4.92) (envelope-from ) id 1pmMmW-0006Du-NI; Tue, 11 Apr 2023 22:48:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519972.807150; Tue, 11 Apr 2023 22:48:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmW-0006Dj-J5; Tue, 11 Apr 2023 22:48:08 +0000 Received: by outflank-mailman (input) for mailman id 519972; Tue, 11 Apr 2023 22:48:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmU-0004tk-ME for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:06 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20604.outbound.protection.outlook.com [2a01:111:f400:7e88::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb089360-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:04 +0200 (CEST) Received: from DS7P222CA0028.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::21) by SA1PR12MB7198.namprd12.prod.outlook.com (2603:10b6:806:2bf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 22:48:02 +0000 Received: from DS1PEPF0000E64F.namprd02.prod.outlook.com (2603:10b6:8:2e:cafe::8e) by DS7P222CA0028.outlook.office365.com (2603:10b6:8:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 22:48:01 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E64F.mail.protection.outlook.com (10.167.18.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:48:01 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:00 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 15:48:00 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:59 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb089360-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWFwXSh/XJsVrrBDH6oSynniQ/IglXdM8mpvw4/iGS4UwF19F99brSYRUXG1fELOy1vVYZ5mYDnRFWxCVSkUCglZA5ie/LzlLLzIvGHQ3rQbCxrOauKrasTnfoDK9MdY6ImbW0YUOC0sINYeHpQ+HnqcojhZvjNp8VztPZP0qhVkhaRrG5cF2+EWHVPKTcuci0o8+3up1yireVb6GXOZ0+T29B7RNYeD+1gm/bp2jU8GM11KYAB1QzNGgNp1RTEwPtu53S51/LbmhPLf14r9laj3E4+UgkJt6skQyZOY2pVof3N5/07YlsDrtQwHCkrBC10/KGlQgHZF9n/FllYqxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ujYfJM4vaNtZk1zA3MwYT/E3tRvcfbmfzK5faMVAmdY=; b=brMGnhH/Tl8QzxLRkf8oULCS+fcHO/YO8Qpe/DajdjjrjudKQ5fXpSIULTstO6EUiim+HJ9NmpjHcGKxF4GxjlmIVRfwOt4M3LlE0j6aRj4gpD0FM/pUC9PxCowVJ91b/Vvn6pPSjhLvb8IGsgJOpXuyVKcJ5QmzgInXYapIijvko0KVk/PIjehTqZ2hiY63VBpN86IUKdyMACdVieqxvElDPJvVhCLebeSNNiO8UYX5JI0MAGIP/5xnjtdOIvZE48ULiiSbbuZorroT9VMWy9T97eVFKQESSYq+3ejJGzN+ai60AwXCy3VUiBVmfACoup42pZUtwSaTQO74C0py0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ujYfJM4vaNtZk1zA3MwYT/E3tRvcfbmfzK5faMVAmdY=; b=fxiyOeyBcL/x4CyCKdICWV04zsQOnnz+VCXpWT+0t6/zf5OXkJB9Vc9GzQ/Pldt0f9cW7aEffwbsbHQEKmi4pzh7LwiqQrBh6IX5adcIbYqrIc0qZ7hJQUHEXL7f0ec8NuMUxPRzpQAItV0Vz8DzitbPE6A/ZlQbPqfcxmBbTak= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: [QEMU][PATCH v6 07/10] hw/xen/xen-hvm-common: Use g_new and error_report Date: Tue, 11 Apr 2023 15:47:43 -0700 Message-ID: <20230411224746.16152-8-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E64F:EE_|SA1PR12MB7198:EE_ X-MS-Office365-Filtering-Correlation-Id: 91e3f26d-b041-4293-93a8-08db3adece1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ry1nPJe5ps0zWI4ft2ZGrmnMusAWHy8AQjIAzB/D5qeuiawc4EjbBwTj/1Oj5ZtpLWmybZ0dTsf8hCfVU5qtXPMTvJXfLtsMXA4TgqDomrJkUYAfSuXQSv3iHWRojwAc7fSZ4qGKc4MdtFmLUV7DdpZgypQp8mJD7+hLOrhk1PVNUSFP1eWL7ZRC4clVm9ri6fP9vMQYIF84BHNwmdqmGA+r8vdp0+FEj90hgZVCys9A9rIkEIeb056jY/aRLuItVdu75FIcekCLr0BJud8CznnxkyZ70O+kWQQBlRB1lpGEa3E5LTnZJzgC3WKg8xb70Cl5wUTiYZrOK3iV027P18ZIjaX6Fc6US3M6PUh/fpiJOimUegt3ZA1SCfIDQFYsSmIS+jkALDsC+njyBVEVG0xmWKOavOQmtdGP0Sz0GHGmqsmZrRh7xH7oK5X1Rwklow49dcvSAMHGKSb+nmArJxbhByxYdTUKRdXtXEMS0Eni755tVIeAktZyjCpmPDAKAholE06sqC1SxIFctQRXX+Xzvv+2cS7soe9C3kRxfm5ctxi0zWq0EwyvywJ/xikZHX2OJ4um8OyK47t6KA/fiMdECqnvMndIKARmjbd9nB67pdQcxuKzWQbZ6Aj5mg5mvw73LJgRAPRGbDpqo18AlLTEX6W7ueOJJllLlfC1RYX3ZsUiSzf/kj97wuEPFkWXdy9CWcDaCGGYIa4PrhXZ+7SZdpBvpkqK/lIcsBO405k= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199021)(40470700004)(36840700001)(46966006)(86362001)(41300700001)(316002)(4326008)(478600001)(36756003)(54906003)(70586007)(70206006)(8676002)(6916009)(40480700001)(82310400005)(356005)(5660300002)(2906002)(8936002)(44832011)(36860700001)(81166007)(82740400003)(186003)(26005)(1076003)(6666004)(2616005)(336012)(426003)(47076005)(83380400001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:48:01.7562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91e3f26d-b041-4293-93a8-08db3adece1c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E64F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7198 Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index cb82f4b83d..42339c96bd 100644 --- a/hw/xen/xen-hvm-common.c +++ b/hw/xen/xen-hvm-common.c @@ -33,7 +33,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr, trace_xen_ram_alloc(ram_addr, size); nr_pfn = size >> TARGET_PAGE_BITS; - pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn); + pfn_list = g_new(xen_pfn_t, nr_pfn); for (i = 0; i < nr_pfn; i++) { pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i; @@ -730,7 +730,7 @@ void destroy_hvm_domain(bool reboot) return; } if (errno != ENOTTY /* old Xen */) { - perror("xendevicemodel_shutdown failed"); + error_report("xendevicemodel_shutdown failed with error %d", errno); } /* well, try the old thing then */ } @@ -784,7 +784,7 @@ static void xen_do_ioreq_register(XenIOState *state, } /* Note: cpus is empty at this point in init */ - state->cpu_by_vcpu_id = g_malloc0(max_cpus * sizeof(CPUState *)); + state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus); rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true); if (rc < 0) { @@ -793,7 +793,7 @@ static void xen_do_ioreq_register(XenIOState *state, goto err; } - state->ioreq_local_port = g_malloc0(max_cpus * sizeof (evtchn_port_t)); + state->ioreq_local_port = g_new0(evtchn_port_t, max_cpus); /* FIXME: how about if we overflow the page here? */ for (i = 0; i < max_cpus; i++) { @@ -850,13 +850,13 @@ void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, state->xce_handle = qemu_xen_evtchn_open(); if (state->xce_handle == NULL) { - perror("xen: event channel open"); + error_report("xen: event channel open failed with error %d", errno); goto err; } state->xenstore = xs_daemon_open(); if (state->xenstore == NULL) { - perror("xen: xenstore open"); + error_report("xen: xenstore open failed with error %d", errno); goto err; } -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519973.807155 (Exim 4.92) (envelope-from ) id 1pmMmX-0006Ht-31; Tue, 11 Apr 2023 22:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519973.807155; Tue, 11 Apr 2023 22:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmW-0006HK-Se; Tue, 11 Apr 2023 22:48:08 +0000 Received: by outflank-mailman (input) for mailman id 519973; Tue, 11 Apr 2023 22:48:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmV-00060o-E8 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:07 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20610.outbound.protection.outlook.com [2a01:111:f400:fe59::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb0ae277-d8ba-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 00:48:05 +0200 (CEST) Received: from CYZPR12CA0016.namprd12.prod.outlook.com (2603:10b6:930:8b::29) by IA0PR12MB8696.namprd12.prod.outlook.com (2603:10b6:208:48f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 22:48:01 +0000 Received: from CY4PEPF0000C97D.namprd02.prod.outlook.com (2603:10b6:930:8b:cafe::f) by CYZPR12CA0016.outlook.office365.com (2603:10b6:930:8b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 22:48:01 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C97D.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.25 via Frontend Transport; Tue, 11 Apr 2023 22:48:01 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:59 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 15:47:59 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:58 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb0ae277-d8ba-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JRCZk4s7Ii4EdN1B74IqEOBLTVU1HXBuT1qc5KzCanwkL6+fzGV3JXjHWjuI6deXYHABYS0YYSRmi5IRb8CulQAPLl0YxFh1M55E4Sv+smIvWSycac1Ra0gCOrtNZgoR9SoF9f7JJjBcTs1lSXCxyWfhn4f/Guy6BI3oW7ZHKaZsJbadhQXdfvZ6VLd5R7xFCy8YAOBXgIlM5cpMIldwiOswb8S4si4hgg0prtLf5HfdQwysRRDN5H0RJ62C2bIpzrvqLrioOmxKmP18cGqUdd0f3Al2NL3ThsBSO5lxMc/0qOPmOVAN8fbPwtg+yndESNYOnPVMcUi3aMJVy3G4+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/uOpZiqStaRi7+Ygxu1TUCLhyLdSY+19OW/XA3O2IUs=; b=M/Hr1cvtNvi17dGN0v5w1aKj6s+7gnihp0iCHuBDtGtRnOPo+0JmcUXrDxAvm0hh/6/UHzrr7iD74GXu1fOxl4lNYXOGmWu8DsQ1U5CwNsGOsZHvzbQ6UILYFtqrFfPcZ80tzzdWTBkwNboEwLxSSvMQ4xQblzgSjZl6TwgAopYAhT3KqghmDNUKuj3DPqzj4jcgfUneumnoUcNE1sejiuLaSpjW+3hi8IAn1MWDCvbvm06eOdbqoPubnDweI3/rcC6v23CIXFNa4/WP9lPq5CmxwLOhseXeTuRQM8w4YWI16Yv5twybk/pa2CH7iP2NpTf30Pn8M4MobRGTKGnYkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/uOpZiqStaRi7+Ygxu1TUCLhyLdSY+19OW/XA3O2IUs=; b=FQLqW+DEDlfSpoOhisp8UwcBcnJgYmAPdKvPrI1o19LHPtgG1FsWFUXsyrr3PWXnM0Gzv7wWPEase5Qj+J1zkdwaKhi68Q7JZiej9HrfN1eKW5RZ+CcP3ZucphlwuTR9B1hlWs4M9TVhTfLN3ywqZ36iLcL6GWMpc+TqPNvrpOg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: [QEMU][PATCH v6 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Date: Tue, 11 Apr 2023 15:47:42 -0700 Message-ID: <20230411224746.16152-7-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97D:EE_|IA0PR12MB8696:EE_ X-MS-Office365-Filtering-Correlation-Id: 30eacd88-8e45-4048-b00d-08db3adecdca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7bPuRk+3vt1vNfZklRi2A3XGXwTsjmGSTcl6GZ1Qq8+OVNH5kuDrflKxNZiU7bc9Bi8FObp9zgOoFNy/qY0g/tOYXhGPs1IGsMHY68Qhtbf5C6MMFflErcyX9sTYH/SrsrK2j9Uo7ByurFOR0nstFu6pMGdKLRtN2GG6jKvjFAM+lmqaGR6x05+GUSv62PlWwNQRXfO57Fj5JffZTc4FfGr92To6qkLKXu747pFegzr3YtAGtRkJo+IVI3AxnXYNjeRm/Q+WYOzYz8Q2e+wrHTJRJER5DxI5tqlyTB6LRloybU/TrUGGHgM8dnWyNt5FAfGwR2Hz7yZjx3d5fPw7Yfqxt43iWiCPNebZVWjTIuXlYElnA/Z1m7PXiEyeHMxAkOll6zMszqM6VQG2bwdKtE/KbCgSpv1HaG5CUL6F3RW0+yzeMv8+gL6DsaVgH/9U7meqVY/BPr1fOfnCzTk4LgVILrQwtitX/M8Eis1+4HKzm5EQep+jemW5WUmHbqtqKJtauL7R83fNzBc6GQnsvPq2o/ddL/UEWcyPD9hgI7hr1oY7C4VF3C0AqoPi0GJkphheouYVUVpt61kXMgsuDwtdsMDGaZjbM2IM+wgYNW7pnBZmz1IU1L+Zfpno8XGkUtnsx0SL9JbGL3mcxc8foH3hHUKVa1Y/E+i6YNLL47jSB53Ua/Gk/6GPs3qa3SY+dv5t2+qnnztzQp2Qymg7+NFOg2HOnr1G2TitAs63I8A= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199021)(36840700001)(46966006)(40470700004)(26005)(6916009)(70206006)(1076003)(4326008)(86362001)(70586007)(316002)(186003)(40460700003)(36756003)(6666004)(54906003)(36860700001)(40480700001)(478600001)(8936002)(8676002)(2616005)(5660300002)(356005)(41300700001)(81166007)(2906002)(44832011)(47076005)(82310400005)(426003)(336012)(83380400001)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:48:01.1414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30eacd88-8e45-4048-b00d-08db3adecdca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8696 From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function xen_do_ioreq_register(). Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 57 +++++++++++++++++++++++++++-------------- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index a31b067404..cb82f4b83d 100644 --- a/hw/xen/xen-hvm-common.c +++ b/hw/xen/xen-hvm-common.c @@ -764,27 +764,12 @@ void xen_shutdown_fatal_error(const char *fmt, ...) qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR); } -void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, - MemoryListener xen_memory_listener) +static void xen_do_ioreq_register(XenIOState *state, + unsigned int max_cpus, + MemoryListener xen_memory_listener) { int i, rc; - setup_xen_backend_ops(); - - state->xce_handle = qemu_xen_evtchn_open(); - if (state->xce_handle == NULL) { - perror("xen: event channel open"); - goto err; - } - - state->xenstore = xs_daemon_open(); - if (state->xenstore == NULL) { - perror("xen: xenstore open"); - goto err; - } - - xen_create_ioreq_server(xen_domid, &state->ioservid); - state->exit.notify = xen_exit_notifier; qemu_add_exit_notifier(&state->exit); @@ -849,12 +834,46 @@ void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, QLIST_INIT(&state->dev_list); device_listener_register(&state->device_listener); + return; + +err: + error_report("xen hardware virtual machine initialisation failed"); + exit(1); +} + +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, + MemoryListener xen_memory_listener) +{ + int rc; + + setup_xen_backend_ops(); + + state->xce_handle = qemu_xen_evtchn_open(); + if (state->xce_handle == NULL) { + perror("xen: event channel open"); + goto err; + } + + state->xenstore = xs_daemon_open(); + if (state->xenstore == NULL) { + perror("xen: xenstore open"); + goto err; + } + + rc = xen_create_ioreq_server(xen_domid, &state->ioservid); + if (!rc) { + xen_do_ioreq_register(state, max_cpus, xen_memory_listener); + } else { + warn_report("xen: failed to create ioreq server"); + } + xen_bus_init(); xen_be_init(); return; + err: - error_report("xen hardware virtual machine initialisation failed"); + error_report("xen hardware virtual machine backend registration failed"); exit(1); } -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519974.807160 (Exim 4.92) (envelope-from ) id 1pmMmX-0006QJ-JG; Tue, 11 Apr 2023 22:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519974.807160; Tue, 11 Apr 2023 22:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmX-0006Ng-CB; Tue, 11 Apr 2023 22:48:09 +0000 Received: by outflank-mailman (input) for mailman id 519974; Tue, 11 Apr 2023 22:48:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmV-0004tk-ED for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:07 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eaa::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb4b3643-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:05 +0200 (CEST) Received: from DS7P222CA0028.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::21) by BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.33; Tue, 11 Apr 2023 22:48:02 +0000 Received: from DS1PEPF0000E64F.namprd02.prod.outlook.com (2603:10b6:8:2e:cafe::ce) by DS7P222CA0028.outlook.office365.com (2603:10b6:8:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Tue, 11 Apr 2023 22:48:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E64F.mail.protection.outlook.com (10.167.18.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:48:02 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:01 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:01 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:48:00 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb4b3643-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z8LbizSGQNuImsKV2JiCgRPBuNK5PpUGtGUHwaXbJpk74fDJE761l4N6GgHgswxT/PD9p+9gwN0XuBKz5zwKZ6D1YxNMmldXsM/DCeLfnRPGdPcan4W+j6dqIULDqPGjs2x92Zg4B5iGsN7e5USuW449zzfD1xvS6Avt+9fXaXsT06hYaDLrRsYeVAAQ97tJEQTNf1TJKIBiHlAZDIo70pVG9Y+vQDedg3+9b9eplYaE2LdQGL3NUgn8mxBPMAejUL6RKTeUFtxjkQ8m9ExjEBR1AO8hf/5/25b68ELhwCXV9Qwhlc1eEo32d9kz01psUltYhrIMuIPQbHPglDUagQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r4LfuuzS6bsMM7PpjlXU3TZGIWAHgT1E78TzwKVxfOw=; b=kX3WTLDJVpe3gWs9M1htHG5W2p1S4dg6ePhNSWkNg24vCxQ3+moozKUiUt1hSg2pa5zpaa6vqiKZtLWcTXzU0gPCueQjx7k/E8rQ4jj9yBuhfpTrd4Gl4fYVA7qfgDTWNah6637opWqYUk6SlOMX7NPoSdKTPrZqEBiFGISSId+RR7O2HyJqmZ/aO6ZAs+FTmRHA2y/6hC+hUHd22Cur3IhFj6+Ee3Grw1WiE4FdfgYECtdTjWq7Ta1Rq3K8hYOe7XIOTXe/LW+axLsINeDCvi2ThjFNT1RBJZk1OwC3jGGiiOEqSWb9JZ1sdIxIICcPXcitHPvQs/aDII7IOpBK9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r4LfuuzS6bsMM7PpjlXU3TZGIWAHgT1E78TzwKVxfOw=; b=12o8kRtfU76dz/NFnJwmvdO7VN04cJ6r/o7cwWmGxggMqXQ535omGUktXEbDI4zyauW5LddOql6N1vdS0N8rcMym/ixpD9fdhtmDKu3tnobu/BaxQCA4OIlTHdcHRHQUme2asdwbDv7n68qe6QjUaNX/cIEUPgTqC+0/BPUY6uk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [QEMU][PATCH v6 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets Date: Tue, 11 Apr 2023 15:47:44 -0700 Message-ID: <20230411224746.16152-9-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E64F:EE_|BL0PR12MB4948:EE_ X-MS-Office365-Filtering-Correlation-Id: 4700fb71-d47e-4c98-4174-08db3adece6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PB56rwWPkNs4DeI0XxyZs93+wwisuZf//D1UMVN3p39f/P051boLubv1fI8fxeSbigREmTcptsy128NCGwgAGlQmqxkQM7sl34x3AG8x+qWeVhdwDEycr47NwAlglLigxdh6L2dtdLn46yKH5uT3GK5nXoWNbkj2GtALWQn/Fq4RwEDmG7Ql9dLO362xi4GmCtlF4MrRvvS5IT3fmQYBpTeyOgSCxI6zINaNyJucjUDd58taX1Lj8Qi/u6Adok9BXQCraHoEKbF1AURmyQTzNTd6PM1NvUlk4Dt2xAh+y7WUGuk/MYUKa2RByqWhaS7aqE7ffg6jYCbeusXrYV25YyzJn7wzr/QOESONsFpDYFaO+6JfFrLcqC2qvQQptW37Du8SePik4EQoBFiadmd/UKoFDj5knyZQM0dQ/qUj//tMN3Li1NklUgvsGYTu2JIGN7qazPyXjZ1Ay2C2pnH+0/xbBxrb9SaY0g8bG9Lu8+XvuZOHRtCHfp0fd+7dAvW9aHn3uxO+UiKuLwXRpo/zhKO/aFYaJVBwgUChu2SocKWt/MlIuxMi4yDxPfCllbuRIY3smtdACazUdh9KRHGvee4YmyVTPY+0UClf0DbZw2LfEs/TVe34JBkG4te2UfLpEq97sg0WEAeesg64m69LNGZk9h15Jm5sM2cmyj45u6W/KIAM9/zQkzfA/lPmAPZYaULj9JEF+/gFhaTRf4uKaTPr+4ESdXpJut+Xx1aLKrs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199021)(46966006)(36840700001)(40470700004)(36756003)(86362001)(70206006)(70586007)(316002)(4326008)(8676002)(41300700001)(478600001)(54906003)(6916009)(82310400005)(40480700001)(5660300002)(44832011)(8936002)(4744005)(356005)(81166007)(36860700001)(2906002)(82740400003)(186003)(26005)(1076003)(2616005)(426003)(83380400001)(336012)(47076005)(6666004)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:48:02.2562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4700fb71-d47e-4c98-4174-08db3adece6b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E64F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4948 From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 29f8644d6d..52c3995c9d 100644 --- a/meson.build +++ b/meson.build @@ -1467,6 +1467,8 @@ have_xen_pci_passthrough = get_option('xen_pci_passthrough') \ error_message: 'Xen PCI passthrough requested but Xen not enabled') \ .require(targetos == 'linux', error_message: 'Xen PCI passthrough not available on this platform') \ + .require(cpu == 'x86' or cpu == 'x86_64', + error_message: 'Xen PCI passthrough not available on this platform') \ .allowed() -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519975.807169 (Exim 4.92) (envelope-from ) id 1pmMmY-0006bK-GU; Tue, 11 Apr 2023 22:48:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519975.807169; Tue, 11 Apr 2023 22:48:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmY-0006XX-3i; Tue, 11 Apr 2023 22:48:10 +0000 Received: by outflank-mailman (input) for mailman id 519975; Tue, 11 Apr 2023 22:48:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmW-0004tk-80 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:08 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20631.outbound.protection.outlook.com [2a01:111:f400:7eaa::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec250365-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:06 +0200 (CEST) Received: from DM6PR03CA0101.namprd03.prod.outlook.com (2603:10b6:5:333::34) by DS7PR12MB8201.namprd12.prod.outlook.com (2603:10b6:8:e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 22:48:04 +0000 Received: from DS1PEPF0000E655.namprd02.prod.outlook.com (2603:10b6:5:333:cafe::e0) by DM6PR03CA0101.outlook.office365.com (2603:10b6:5:333::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 22:48:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E655.mail.protection.outlook.com (10.167.18.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Tue, 11 Apr 2023 22:48:03 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:03 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:03 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:48:02 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec250365-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cpCzqrcKkc4cjgV6C9+XLDIAG9fTypdq9VK8dYRsbsL78HskN9YjVQ6n3HZVJqSuGmPe6Zt+UyDd2JNZNRpO+ihpGpMZmu7MeageoEr4fZusvitoK3i+FqAV8KRnnbTR6qQidlMK+l9kKUZd43Ls6stBh9VYoYxlusQKF5FzUFhOIXFn38upo+QDejjTG39oUyYpDp/gcQwugLvSBDtWfcIGpJlE9ikCUkBAsaAgOXarRDbnzgNe5J7joqPylc7LfHSQTTflBplH5qAlfgr4x8mkxJV3FleMi/E9z0sXI/UavnePw7ZRZaqkIZos6wdxMbv3+iFpsTl6ycPNXWOWtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jmblM95zvi2ytozurVmKkWMS6LTJXUZA+FjuQuy4Brw=; b=OThx/cSOIooUslYkRKLX08FWpc/qto2zZXPR+mi3vftKINrm0NBz67KxfhGIaBQ9D7g+oAkXQRWqu1g8Rx4GGYlpNnZLcobT2Qtyk4VviPXNnqWesLRSAJEF3LFxjqfJH9nWWGIxFkGjS1w2GTyTbzHFbRcwsdZn2mtb9ntcVKBShMGaM93ecbx1pbTu5vvhu69Y1e7jfjDO3LCtaUeXQcmDh3WzRYlahZKlTj3h6QF6uoQesHw5jVjsUrlbzPNkN0paIWp2bVllflhO5naeNnzRp0RTk7n3gIYD8TQb3jmhLX+sL11pCTj7DDUQP4NLikh7vNhcmDTi8vgngukLtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jmblM95zvi2ytozurVmKkWMS6LTJXUZA+FjuQuy4Brw=; b=1yH6lmG0NOkBJEwHNgmeTWShUeogFlBM02ud79eOoP9pWFtoPgVDjbhkGpv2JO9XL4CmdcJ7fjbgwKoq94rYwuYb8CmF849ZEp1Kqs+YE8CfZj3tl8MoPtyex9tJVxHh7Iv5jWvFS4G9HtbtMr9LC1uDx7GEA6/5uSGvVo/H3Js= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [QEMU][PATCH v6 10/10] meson.build: enable xenpv machine build for ARM Date: Tue, 11 Apr 2023 15:47:46 -0700 Message-ID: <20230411224746.16152-11-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E655:EE_|DS7PR12MB8201:EE_ X-MS-Office365-Filtering-Correlation-Id: 673a436c-a4c9-4ad1-4827-08db3adecf71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B7FppZGjYAs0J1RgHfhjQV4DfpRWg/VXFUte8wSnpWXIiZEUfQyF5/nmmmi3R1hKpx9pZhDCRvxUv2gR2C6LnBHP68Y2QQkM8HNJvI0Vo1uxIqbw0vrQGDEs/G7uenme8+09A5NjS34Wmgg7mNL6CnEz3kvPu2IZsJQOoXHrooe3xuGcQ2nE4zSNSV/D+vw8oI5EBgnfp0diW0BcSEoGqT/B4BqlHMSLQK3wzYD3Rv7RRcYiZXx/CaHVGRGAEWELEkTXwX6IKEHKQMPGDhY/KQuL8/5Qgtz6s8Fy84R7+I4TbhWqoQIYbNDsQMhmWsJuLtnCmzdNpN7THl5U8dfbEAH0/M50nEEwYcCo9oO9pQM/PqHF9IwwAp6vmnXEVrMhC8n2gip4D3Rp2QPAowQ2fsLAclE+WiKRPVKUKHnBuLMemfATYT9iC5Vr+kFfv/ZJYVVVS6RKm8eKp0EGF9GbmTCHlncJtGsqcw7O3IHJtsPi8rVVHpQecxk80b4FROGXQ29BWSJgkbEIHZdH2/ISrfdkfBQelYNXAsZVtiH5a1rMC1PHw0yvBCoEGCmfUk/7knWqyqplIkaFTLgtnwujiEGLG41bOpgXDgMcWbIWkzGCy45Crm+YsGDG9UHhGz1x72+WWkrKrJ5yJRpeiyVDsfNncGEO2gALLq4QfmU7wyKDj/fa2yJXwqWGkxxh5vZ34GJY3I7XTdul2wXbNa+zLeRcKGXAhIDS212cNzsA2Us= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199021)(40470700004)(46966006)(36840700001)(6666004)(478600001)(26005)(316002)(186003)(54906003)(2906002)(336012)(4744005)(44832011)(5660300002)(70206006)(70586007)(8676002)(4326008)(41300700001)(6916009)(8936002)(82310400005)(356005)(82740400003)(81166007)(47076005)(40480700001)(66574015)(40460700003)(36756003)(83380400001)(86362001)(1076003)(36860700001)(2616005)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:48:03.9578 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 673a436c-a4c9-4ad1-4827-08db3adecf71 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E655.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8201 Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 52c3995c9d..eb5bb305ae 100644 --- a/meson.build +++ b/meson.build @@ -135,7 +135,7 @@ endif if cpu in ['x86', 'x86_64', 'arm', 'aarch64'] # i386 emulator provides xenpv machine type for multiple architectures accelerator_targets += { - 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu'], + 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu', 'aarch64-softmmu'], } endif if cpu in ['x86', 'x86_64'] -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519976.807177 (Exim 4.92) (envelope-from ) id 1pmMmZ-0006mZ-6y; Tue, 11 Apr 2023 22:48:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519976.807177; Tue, 11 Apr 2023 22:48:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmY-0006ho-Os; Tue, 11 Apr 2023 22:48:10 +0000 Received: by outflank-mailman (input) for mailman id 519976; Tue, 11 Apr 2023 22:48:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmX-00060o-1q for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:09 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20618.outbound.protection.outlook.com [2a01:111:f400:7e88::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebc2165b-d8ba-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 00:48:06 +0200 (CEST) Received: from CYZPR12CA0001.namprd12.prod.outlook.com (2603:10b6:930:8b::8) by CH3PR12MB7762.namprd12.prod.outlook.com (2603:10b6:610:151::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Tue, 11 Apr 2023 22:48:00 +0000 Received: from CY4PEPF0000C97D.namprd02.prod.outlook.com (2603:10b6:930:8b:cafe::5e) by CYZPR12CA0001.outlook.office365.com (2603:10b6:930:8b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Tue, 11 Apr 2023 22:48:00 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C97D.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.25 via Frontend Transport; Tue, 11 Apr 2023 22:48:00 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:57 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:47:57 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:47:56 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebc2165b-d8ba-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K9SzP0FBBf9SUYqgTF4o/Sz8oINLOIgPYVgUeJWbbaaGqOzi3WnOSOyuwGEKg/r1luk0nlXErdrayuU+FJa8WuF2kMvApFcdInQ6lD7j8GJYkEY5C8bsiiVbgrTMVQxPLoWVtOAOoIZElAGvHPoY6BeFhWsa/3oSomkIHcQGH9AR2TxpYyVI5BjC4F7CdctnVeS4x/uJPWjQGcUHHLoIvXl2qacFTrQy1Uh115+Vb1iRZZHJStPJzkIv2JNIlM6lZC1e8S/vJquHCR9u97CFUMAjTK6QP81hheymH+W1DRAQhK8B+XRul6MJV76aluVdppTcnxowMJYCgYcFwXVlUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wIZIFcEluMLarFziGuZ+tNtfbECwk02fJil82lSHuSo=; b=b18gyK/T0iXHVC6D3jTjFhoNDwXSq8X3TIDJWfMtuVX1Hj+fW28uDkMAFMxAVN6qKcy1ftYdyzl6bNSZJOXAtrNaiXoihQHfvg4qKT7eiqCdQxTActGyFLxHxRPjZ15kX1tqDpdM0rKzRbs8dR9T0gCrLC4xfkBFJbTEqMc9rJU7eJZ0qLuQ2mOyU/R5eXMGsFplWzttJgkmKRuqPitzekXmKwpLmCut4/DTGtzyiFCiYOfH+xYC8hbK2ly0ZnCw1M2K8lYPsNGhJ3hCeMjOlOllAltk7F46GPpXsYhTejNNeEgW6y/HQzdVO++XDmGbqT5kbCo9JGYMnPgGUQ3+Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wIZIFcEluMLarFziGuZ+tNtfbECwk02fJil82lSHuSo=; b=b7MmAEPsP7TpVCRz250eu3R3LVxIY9UAUeqS1NgcqE/1Ei6qt7ov6XlK85tPDcRIdSzoFdcvmt/bMcTDJbNloPMxK3+BdBwVHEtfjaug32uirRKIKLvtD4I1V4fMHOErptbgd+m2FnerV+7eVLYQ8L9aAWNSrZgfeLeUh9JoO0c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [QEMU][PATCH v6 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common Date: Tue, 11 Apr 2023 15:47:40 -0700 Message-ID: <20230411224746.16152-5-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97D:EE_|CH3PR12MB7762:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ff20461-d2a4-4736-0590-08db3adecd5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CABI988Q0U8KWOTCEQfyL++X9Kte3o1wSlWAL5huGdFf8AgATwUC7elcL4Ck3UkOVNu8vyBI/p52cp6xrjL78eOhNqojLnbyociesjJ10zr9bom29SzQsvp45QwlHHPy+DW84El5FyIOCMvvrBjDe9igceV1SKzxYe5qKIXZk8CubINeDDvCbWU2VD2iIi3yaaT2amCWB1pf/9NOdK0abm+9qIOLencq3E8AQW+IRFePGqXCQHH2RNfhmfVZpHSXD3mZeA21t4HY+Bt8SYK/01ZSWgJE4gF5uwMH6jzw4xwDOKZskxKxprbdcacjpJzWR6Pn2MaBfebYRpkprsd8l4yBhaucuryOhJjwJQWMEPdsVoSao9XKkc/pUrjsie0EySNxnxEvP5AaDYrjst24VTsePoOxJHqMqOVFpRIQO7rY62DqLebRFZj8gd2tmKEUBEZ5O9qENf+RidMoyyhi8dRsoiKyHTURc/S3CZC8MyF5i9kqvRJ4PwqdTh3qBjP6UpxY7J/buTSSqcMdFUaKNLHNUwXikjvCREF4f9MLYG8qkZIh3Zy6rgsu9RoQeqj1OQ7u/rpPdoXwMbd8NirjXj3NAFBiNS+J6zorW34VuFDjF0b1dU3q1mFF08RTXUzCBCjNgqZdOruz5xDMAufXHtdFgE/TOxaqYQO7MwC9ST3KmQPuCxWFD3gJXswLc4SJnMIfadQwC9rdVmOmknE+hGUxNWuhcZ2eae/W766FmN4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199021)(40470700004)(36840700001)(46966006)(30864003)(2906002)(40460700003)(356005)(41300700001)(81166007)(5660300002)(7416002)(8936002)(8676002)(44832011)(82310400005)(36756003)(86362001)(40480700001)(6666004)(1076003)(26005)(54906003)(478600001)(2616005)(36860700001)(83380400001)(336012)(426003)(47076005)(186003)(316002)(70206006)(70586007)(4326008)(6916009)(82740400003)(36900700001)(579004)(559001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:48:00.4539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff20461-d2a4-4736-0590-08db3adecd5d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7762 From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move handle_vmport_ioreq to arch_handle_ioreq. 2. Pure code movement: move common functions to hw/xen/xen-hvm-common.c Extract common functionalities from hw/i386/xen/xen-hvm.c and move them to hw/xen/xen-hvm-common.c. These common functions are useful for creating an IOREQ server. xen_hvm_init_pc() contains the architecture independent code for creating and mapping a IOREQ server, connecting memory and IO listeners, initializing a xen bus and registering backends. Moved this common xen code to a new function xen_register_ioreq() which can be used by both x86 and ARM machines. Following functions are moved to hw/xen/xen-hvm-common.c: xen_vcpu_eport(), xen_vcpu_ioreq(), xen_ram_alloc(), xen_set_memory(), xen_region_add(), xen_region_del(), xen_io_add(), xen_io_del(), xen_device_realize(), xen_device_unrealize(), cpu_get_ioreq_from_shared_memory(), cpu_get_ioreq(), do_inp(), do_outp(), rw_phys_req_item(), read_phys_req_item(), write_phys_req_item(), cpu_ioreq_pio(), cpu_ioreq_move(), cpu_ioreq_config(), handle_ioreq(), handle_buffered_iopage(), handle_buffered_io(), cpu_handle_ioreq(), xen_main_loop_prepare(), xen_hvm_change_state_handler(), xen_exit_notifier(), xen_map_ioreq_server(), destroy_hvm_domain() and xen_shutdown_fatal_error() 3. Removed static type from below functions: 1. xen_region_add() 2. xen_region_del() 3. xen_io_add() 4. xen_io_del() 5. xen_device_realize() 6. xen_device_unrealize() 7. xen_hvm_change_state_handler() 8. cpu_ioreq_pio() 9. xen_exit_notifier() 4. Replace TARGET_PAGE_SIZE with XC_PAGE_SIZE to match the page side with Xen. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/xen/trace-events | 14 - hw/i386/xen/xen-hvm.c | 1016 ++----------------------------- hw/xen/meson.build | 5 +- hw/xen/trace-events | 14 + hw/xen/xen-hvm-common.c | 860 ++++++++++++++++++++++++++ include/hw/i386/xen_arch_hvm.h | 11 + include/hw/xen/arch_hvm.h | 3 + include/hw/xen/xen-hvm-common.h | 99 +++ 8 files changed, 1054 insertions(+), 968 deletions(-) create mode 100644 hw/xen/xen-hvm-common.c create mode 100644 include/hw/i386/xen_arch_hvm.h create mode 100644 include/hw/xen/arch_hvm.h create mode 100644 include/hw/xen/xen-hvm-common.h diff --git a/hw/i386/xen/trace-events b/hw/i386/xen/trace-events index a0c89d91c4..5d0a8d6dcf 100644 --- a/hw/i386/xen/trace-events +++ b/hw/i386/xen/trace-events @@ -7,17 +7,3 @@ xen_platform_log(char *s) "xen platform: %s" xen_pv_mmio_read(uint64_t addr) "WARNING: read from Xen PV Device MMIO space (address 0x%"PRIx64")" xen_pv_mmio_write(uint64_t addr) "WARNING: write to Xen PV Device MMIO space (address 0x%"PRIx64")" -# xen-hvm.c -xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: 0x%lx, size 0x%lx" -xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty) "0x%"PRIx64" size 0x%lx, log_dirty %i" -handle_ioreq(void *req, uint32_t type, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p type=%d dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" -handle_ioreq_read(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p read type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" -handle_ioreq_write(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p write type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" -cpu_ioreq_pio(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p pio dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" -cpu_ioreq_pio_read_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio read reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" -cpu_ioreq_pio_write_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio write reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" -cpu_ioreq_move(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p copy dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" -xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p" -cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" -cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" - diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 6be5a250a8..a1ff5be4e1 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -10,43 +10,21 @@ #include "qemu/osdep.h" #include "qemu/units.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-migration.h" +#include "trace.h" -#include "cpu.h" -#include "hw/pci/pci.h" -#include "hw/pci/pci_host.h" #include "hw/i386/pc.h" #include "hw/irq.h" -#include "hw/hw.h" #include "hw/i386/apic-msidef.h" -#include "hw/xen/xen_native.h" -#include "hw/xen/xen-legacy-backend.h" -#include "hw/xen/xen-bus.h" #include "hw/xen/xen-x86.h" -#include "qapi/error.h" -#include "qapi/qapi-commands-migration.h" -#include "qemu/error-report.h" -#include "qemu/main-loop.h" #include "qemu/range.h" -#include "sysemu/runstate.h" -#include "sysemu/sysemu.h" -#include "sysemu/xen.h" -#include "sysemu/xen-mapcache.h" -#include "trace.h" -#include +#include "hw/xen/xen-hvm-common.h" +#include "hw/xen/arch_hvm.h" #include -//#define DEBUG_XEN_HVM - -#ifdef DEBUG_XEN_HVM -#define DPRINTF(fmt, ...) \ - do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) \ - do { } while (0) -#endif - -static MemoryRegion ram_memory, ram_640k, ram_lo, ram_hi; +static MemoryRegion ram_640k, ram_lo, ram_hi; static MemoryRegion *framebuffer; static bool xen_in_migration; @@ -74,27 +52,8 @@ struct shared_vmport_iopage { }; typedef struct shared_vmport_iopage shared_vmport_iopage_t; #endif -static shared_vmport_iopage_t *shared_vmport_page; -static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i) -{ - return shared_page->vcpu_ioreq[i].vp_eport; -} -static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu) -{ - return &shared_page->vcpu_ioreq[vcpu]; -} - -#define BUFFER_IO_MAX_DELAY 100 - -typedef struct XenPhysmap { - hwaddr start_addr; - ram_addr_t size; - const char *name; - hwaddr phys_offset; - - QLIST_ENTRY(XenPhysmap) list; -} XenPhysmap; +static shared_vmport_iopage_t *shared_vmport_page; static QLIST_HEAD(, XenPhysmap) xen_physmap; static const XenPhysmap *log_for_dirtybit; @@ -103,38 +62,6 @@ static unsigned long *dirty_bitmap; static Notifier suspend; static Notifier wakeup; -typedef struct XenPciDevice { - PCIDevice *pci_dev; - uint32_t sbdf; - QLIST_ENTRY(XenPciDevice) entry; -} XenPciDevice; - -typedef struct XenIOState { - ioservid_t ioservid; - shared_iopage_t *shared_page; - buffered_iopage_t *buffered_io_page; - xenforeignmemory_resource_handle *fres; - QEMUTimer *buffered_io_timer; - CPUState **cpu_by_vcpu_id; - /* the evtchn port for polling the notification, */ - evtchn_port_t *ioreq_local_port; - /* evtchn remote and local ports for buffered io */ - evtchn_port_t bufioreq_remote_port; - evtchn_port_t bufioreq_local_port; - /* the evtchn fd for polling */ - xenevtchn_handle *xce_handle; - /* which vcpu we are serving */ - int send_vcpu; - - struct xs_handle *xenstore; - MemoryListener memory_listener; - MemoryListener io_listener; - QLIST_HEAD(, XenPciDevice) dev_list; - DeviceListener device_listener; - - Notifier exit; -} XenIOState; - /* Xen specific function for piix pci */ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) @@ -247,42 +174,6 @@ static void xen_ram_init(PCMachineState *pcms, } } -void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr, - Error **errp) -{ - unsigned long nr_pfn; - xen_pfn_t *pfn_list; - int i; - - if (runstate_check(RUN_STATE_INMIGRATE)) { - /* RAM already populated in Xen */ - fprintf(stderr, "%s: do not alloc "RAM_ADDR_FMT - " bytes of ram at "RAM_ADDR_FMT" when runstate is INMIGRATE\n", - __func__, size, ram_addr); - return; - } - - if (mr == &ram_memory) { - return; - } - - trace_xen_ram_alloc(ram_addr, size); - - nr_pfn = size >> TARGET_PAGE_BITS; - pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn); - - for (i = 0; i < nr_pfn; i++) { - pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i; - } - - if (xc_domain_populate_physmap_exact(xen_xc, xen_domid, nr_pfn, 0, 0, pfn_list)) { - error_setg(errp, "xen: failed to populate ram at " RAM_ADDR_FMT, - ram_addr); - } - - g_free(pfn_list); -} - static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size) { XenPhysmap *physmap = NULL; @@ -472,144 +363,6 @@ static int xen_remove_from_physmap(XenIOState *state, return 0; } -static void xen_set_memory(struct MemoryListener *listener, - MemoryRegionSection *section, - bool add) -{ - XenIOState *state = container_of(listener, XenIOState, memory_listener); - hwaddr start_addr = section->offset_within_address_space; - ram_addr_t size = int128_get64(section->size); - bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA); - hvmmem_type_t mem_type; - - if (section->mr == &ram_memory) { - return; - } else { - if (add) { - xen_map_memory_section(xen_domid, state->ioservid, - section); - } else { - xen_unmap_memory_section(xen_domid, state->ioservid, - section); - } - } - - if (!memory_region_is_ram(section->mr)) { - return; - } - - if (log_dirty != add) { - return; - } - - trace_xen_client_set_memory(start_addr, size, log_dirty); - - start_addr &= TARGET_PAGE_MASK; - size = TARGET_PAGE_ALIGN(size); - - if (add) { - if (!memory_region_is_rom(section->mr)) { - xen_add_to_physmap(state, start_addr, size, - section->mr, section->offset_within_region); - } else { - mem_type = HVMMEM_ram_ro; - if (xen_set_mem_type(xen_domid, mem_type, - start_addr >> TARGET_PAGE_BITS, - size >> TARGET_PAGE_BITS)) { - DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n", - start_addr); - } - } - } else { - if (xen_remove_from_physmap(state, start_addr, size) < 0) { - DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n", start_addr); - } - } -} - -static void xen_region_add(MemoryListener *listener, - MemoryRegionSection *section) -{ - memory_region_ref(section->mr); - xen_set_memory(listener, section, true); -} - -static void xen_region_del(MemoryListener *listener, - MemoryRegionSection *section) -{ - xen_set_memory(listener, section, false); - memory_region_unref(section->mr); -} - -static void xen_io_add(MemoryListener *listener, - MemoryRegionSection *section) -{ - XenIOState *state = container_of(listener, XenIOState, io_listener); - MemoryRegion *mr = section->mr; - - if (mr->ops == &unassigned_io_ops) { - return; - } - - memory_region_ref(mr); - - xen_map_io_section(xen_domid, state->ioservid, section); -} - -static void xen_io_del(MemoryListener *listener, - MemoryRegionSection *section) -{ - XenIOState *state = container_of(listener, XenIOState, io_listener); - MemoryRegion *mr = section->mr; - - if (mr->ops == &unassigned_io_ops) { - return; - } - - xen_unmap_io_section(xen_domid, state->ioservid, section); - - memory_region_unref(mr); -} - -static void xen_device_realize(DeviceListener *listener, - DeviceState *dev) -{ - XenIOState *state = container_of(listener, XenIOState, device_listener); - - if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { - PCIDevice *pci_dev = PCI_DEVICE(dev); - XenPciDevice *xendev = g_new(XenPciDevice, 1); - - xendev->pci_dev = pci_dev; - xendev->sbdf = PCI_BUILD_BDF(pci_dev_bus_num(pci_dev), - pci_dev->devfn); - QLIST_INSERT_HEAD(&state->dev_list, xendev, entry); - - xen_map_pcidev(xen_domid, state->ioservid, pci_dev); - } -} - -static void xen_device_unrealize(DeviceListener *listener, - DeviceState *dev) -{ - XenIOState *state = container_of(listener, XenIOState, device_listener); - - if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { - PCIDevice *pci_dev = PCI_DEVICE(dev); - XenPciDevice *xendev, *next; - - xen_unmap_pcidev(xen_domid, state->ioservid, pci_dev); - - QLIST_FOREACH_SAFE(xendev, &state->dev_list, entry, next) { - if (xendev->pci_dev == pci_dev) { - QLIST_REMOVE(xendev, entry); - g_free(xendev); - break; - } - } - } -} - static void xen_sync_dirty_bitmap(XenIOState *state, hwaddr start_addr, ram_addr_t size) @@ -717,277 +470,6 @@ static MemoryListener xen_memory_listener = { .priority = 10, }; -static MemoryListener xen_io_listener = { - .name = "xen-io", - .region_add = xen_io_add, - .region_del = xen_io_del, - .priority = 10, -}; - -static DeviceListener xen_device_listener = { - .realize = xen_device_realize, - .unrealize = xen_device_unrealize, -}; - -/* get the ioreq packets from share mem */ -static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu) -{ - ioreq_t *req = xen_vcpu_ioreq(state->shared_page, vcpu); - - if (req->state != STATE_IOREQ_READY) { - DPRINTF("I/O request not ready: " - "%x, ptr: %x, port: %"PRIx64", " - "data: %"PRIx64", count: %u, size: %u\n", - req->state, req->data_is_ptr, req->addr, - req->data, req->count, req->size); - return NULL; - } - - xen_rmb(); /* see IOREQ_READY /then/ read contents of ioreq */ - - req->state = STATE_IOREQ_INPROCESS; - return req; -} - -/* use poll to get the port notification */ -/* ioreq_vec--out,the */ -/* retval--the number of ioreq packet */ -static ioreq_t *cpu_get_ioreq(XenIOState *state) -{ - MachineState *ms = MACHINE(qdev_get_machine()); - unsigned int max_cpus = ms->smp.max_cpus; - int i; - evtchn_port_t port; - - port = qemu_xen_evtchn_pending(state->xce_handle); - if (port == state->bufioreq_local_port) { - timer_mod(state->buffered_io_timer, - BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); - return NULL; - } - - if (port != -1) { - for (i = 0; i < max_cpus; i++) { - if (state->ioreq_local_port[i] == port) { - break; - } - } - - if (i == max_cpus) { - hw_error("Fatal error while trying to get io event!\n"); - } - - /* unmask the wanted port again */ - qemu_xen_evtchn_unmask(state->xce_handle, port); - - /* get the io packet from shared memory */ - state->send_vcpu = i; - return cpu_get_ioreq_from_shared_memory(state, i); - } - - /* read error or read nothing */ - return NULL; -} - -static uint32_t do_inp(uint32_t addr, unsigned long size) -{ - switch (size) { - case 1: - return cpu_inb(addr); - case 2: - return cpu_inw(addr); - case 4: - return cpu_inl(addr); - default: - hw_error("inp: bad size: %04x %lx", addr, size); - } -} - -static void do_outp(uint32_t addr, - unsigned long size, uint32_t val) -{ - switch (size) { - case 1: - return cpu_outb(addr, val); - case 2: - return cpu_outw(addr, val); - case 4: - return cpu_outl(addr, val); - default: - hw_error("outp: bad size: %04x %lx", addr, size); - } -} - -/* - * Helper functions which read/write an object from/to physical guest - * memory, as part of the implementation of an ioreq. - * - * Equivalent to - * cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i, - * val, req->size, 0/1) - * except without the integer overflow problems. - */ -static void rw_phys_req_item(hwaddr addr, - ioreq_t *req, uint32_t i, void *val, int rw) -{ - /* Do everything unsigned so overflow just results in a truncated result - * and accesses to undesired parts of guest memory, which is up - * to the guest */ - hwaddr offset = (hwaddr)req->size * i; - if (req->df) { - addr -= offset; - } else { - addr += offset; - } - cpu_physical_memory_rw(addr, val, req->size, rw); -} - -static inline void read_phys_req_item(hwaddr addr, - ioreq_t *req, uint32_t i, void *val) -{ - rw_phys_req_item(addr, req, i, val, 0); -} -static inline void write_phys_req_item(hwaddr addr, - ioreq_t *req, uint32_t i, void *val) -{ - rw_phys_req_item(addr, req, i, val, 1); -} - - -static void cpu_ioreq_pio(ioreq_t *req) -{ - uint32_t i; - - trace_cpu_ioreq_pio(req, req->dir, req->df, req->data_is_ptr, req->addr, - req->data, req->count, req->size); - - if (req->size > sizeof(uint32_t)) { - hw_error("PIO: bad size (%u)", req->size); - } - - if (req->dir == IOREQ_READ) { - if (!req->data_is_ptr) { - req->data = do_inp(req->addr, req->size); - trace_cpu_ioreq_pio_read_reg(req, req->data, req->addr, - req->size); - } else { - uint32_t tmp; - - for (i = 0; i < req->count; i++) { - tmp = do_inp(req->addr, req->size); - write_phys_req_item(req->data, req, i, &tmp); - } - } - } else if (req->dir == IOREQ_WRITE) { - if (!req->data_is_ptr) { - trace_cpu_ioreq_pio_write_reg(req, req->data, req->addr, - req->size); - do_outp(req->addr, req->size, req->data); - } else { - for (i = 0; i < req->count; i++) { - uint32_t tmp = 0; - - read_phys_req_item(req->data, req, i, &tmp); - do_outp(req->addr, req->size, tmp); - } - } - } -} - -static void cpu_ioreq_move(ioreq_t *req) -{ - uint32_t i; - - trace_cpu_ioreq_move(req, req->dir, req->df, req->data_is_ptr, req->addr, - req->data, req->count, req->size); - - if (req->size > sizeof(req->data)) { - hw_error("MMIO: bad size (%u)", req->size); - } - - if (!req->data_is_ptr) { - if (req->dir == IOREQ_READ) { - for (i = 0; i < req->count; i++) { - read_phys_req_item(req->addr, req, i, &req->data); - } - } else if (req->dir == IOREQ_WRITE) { - for (i = 0; i < req->count; i++) { - write_phys_req_item(req->addr, req, i, &req->data); - } - } - } else { - uint64_t tmp; - - if (req->dir == IOREQ_READ) { - for (i = 0; i < req->count; i++) { - read_phys_req_item(req->addr, req, i, &tmp); - write_phys_req_item(req->data, req, i, &tmp); - } - } else if (req->dir == IOREQ_WRITE) { - for (i = 0; i < req->count; i++) { - read_phys_req_item(req->data, req, i, &tmp); - write_phys_req_item(req->addr, req, i, &tmp); - } - } - } -} - -static void cpu_ioreq_config(XenIOState *state, ioreq_t *req) -{ - uint32_t sbdf = req->addr >> 32; - uint32_t reg = req->addr; - XenPciDevice *xendev; - - if (req->size != sizeof(uint8_t) && req->size != sizeof(uint16_t) && - req->size != sizeof(uint32_t)) { - hw_error("PCI config access: bad size (%u)", req->size); - } - - if (req->count != 1) { - hw_error("PCI config access: bad count (%u)", req->count); - } - - QLIST_FOREACH(xendev, &state->dev_list, entry) { - if (xendev->sbdf != sbdf) { - continue; - } - - if (!req->data_is_ptr) { - if (req->dir == IOREQ_READ) { - req->data = pci_host_config_read_common( - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, - req->size); - trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, - req->size, req->data); - } else if (req->dir == IOREQ_WRITE) { - trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, - req->size, req->data); - pci_host_config_write_common( - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, - req->data, req->size); - } - } else { - uint32_t tmp; - - if (req->dir == IOREQ_READ) { - tmp = pci_host_config_read_common( - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, - req->size); - trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, - req->size, tmp); - write_phys_req_item(req->data, req, 0, &tmp); - } else if (req->dir == IOREQ_WRITE) { - read_phys_req_item(req->data, req, 0, &tmp); - trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, - req->size, tmp); - pci_host_config_write_common( - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, - tmp, req->size); - } - } - } -} - static void regs_to_cpu(vmware_regs_t *vmport_regs, ioreq_t *req) { X86CPU *cpu; @@ -1031,226 +513,6 @@ static void handle_vmport_ioreq(XenIOState *state, ioreq_t *req) current_cpu = NULL; } -static void handle_ioreq(XenIOState *state, ioreq_t *req) -{ - trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr, - req->addr, req->data, req->count, req->size); - - if (!req->data_is_ptr && (req->dir == IOREQ_WRITE) && - (req->size < sizeof (target_ulong))) { - req->data &= ((target_ulong) 1 << (8 * req->size)) - 1; - } - - if (req->dir == IOREQ_WRITE) - trace_handle_ioreq_write(req, req->type, req->df, req->data_is_ptr, - req->addr, req->data, req->count, req->size); - - switch (req->type) { - case IOREQ_TYPE_PIO: - cpu_ioreq_pio(req); - break; - case IOREQ_TYPE_COPY: - cpu_ioreq_move(req); - break; - case IOREQ_TYPE_VMWARE_PORT: - handle_vmport_ioreq(state, req); - break; - case IOREQ_TYPE_TIMEOFFSET: - break; - case IOREQ_TYPE_INVALIDATE: - xen_invalidate_map_cache(); - break; - case IOREQ_TYPE_PCI_CONFIG: - cpu_ioreq_config(state, req); - break; - default: - hw_error("Invalid ioreq type 0x%x\n", req->type); - } - if (req->dir == IOREQ_READ) { - trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr, - req->addr, req->data, req->count, req->size); - } -} - -static bool handle_buffered_iopage(XenIOState *state) -{ - buffered_iopage_t *buf_page = state->buffered_io_page; - buf_ioreq_t *buf_req = NULL; - bool handled_ioreq = false; - ioreq_t req; - int qw; - - if (!buf_page) { - return 0; - } - - memset(&req, 0x00, sizeof(req)); - req.state = STATE_IOREQ_READY; - req.count = 1; - req.dir = IOREQ_WRITE; - - for (;;) { - uint32_t rdptr = buf_page->read_pointer, wrptr; - - xen_rmb(); - wrptr = buf_page->write_pointer; - xen_rmb(); - if (rdptr != buf_page->read_pointer) { - continue; - } - if (rdptr == wrptr) { - break; - } - buf_req = &buf_page->buf_ioreq[rdptr % IOREQ_BUFFER_SLOT_NUM]; - req.size = 1U << buf_req->size; - req.addr = buf_req->addr; - req.data = buf_req->data; - req.type = buf_req->type; - xen_rmb(); - qw = (req.size == 8); - if (qw) { - if (rdptr + 1 == wrptr) { - hw_error("Incomplete quad word buffered ioreq"); - } - buf_req = &buf_page->buf_ioreq[(rdptr + 1) % - IOREQ_BUFFER_SLOT_NUM]; - req.data |= ((uint64_t)buf_req->data) << 32; - xen_rmb(); - } - - handle_ioreq(state, &req); - - /* Only req.data may get updated by handle_ioreq(), albeit even that - * should not happen as such data would never make it to the guest (we - * can only usefully see writes here after all). - */ - assert(req.state == STATE_IOREQ_READY); - assert(req.count == 1); - assert(req.dir == IOREQ_WRITE); - assert(!req.data_is_ptr); - - qatomic_add(&buf_page->read_pointer, qw + 1); - handled_ioreq = true; - } - - return handled_ioreq; -} - -static void handle_buffered_io(void *opaque) -{ - XenIOState *state = opaque; - - if (handle_buffered_iopage(state)) { - timer_mod(state->buffered_io_timer, - BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); - } else { - timer_del(state->buffered_io_timer); - qemu_xen_evtchn_unmask(state->xce_handle, state->bufioreq_local_port); - } -} - -static void cpu_handle_ioreq(void *opaque) -{ - XenIOState *state = opaque; - ioreq_t *req = cpu_get_ioreq(state); - - handle_buffered_iopage(state); - if (req) { - ioreq_t copy = *req; - - xen_rmb(); - handle_ioreq(state, ©); - req->data = copy.data; - - if (req->state != STATE_IOREQ_INPROCESS) { - fprintf(stderr, "Badness in I/O request ... not in service?!: " - "%x, ptr: %x, port: %"PRIx64", " - "data: %"PRIx64", count: %u, size: %u, type: %u\n", - req->state, req->data_is_ptr, req->addr, - req->data, req->count, req->size, req->type); - destroy_hvm_domain(false); - return; - } - - xen_wmb(); /* Update ioreq contents /then/ update state. */ - - /* - * We do this before we send the response so that the tools - * have the opportunity to pick up on the reset before the - * guest resumes and does a hlt with interrupts disabled which - * causes Xen to powerdown the domain. - */ - if (runstate_is_running()) { - ShutdownCause request; - - if (qemu_shutdown_requested_get()) { - destroy_hvm_domain(false); - } - request = qemu_reset_requested_get(); - if (request) { - qemu_system_reset(request); - destroy_hvm_domain(true); - } - } - - req->state = STATE_IORESP_READY; - qemu_xen_evtchn_notify(state->xce_handle, - state->ioreq_local_port[state->send_vcpu]); - } -} - -static void xen_main_loop_prepare(XenIOState *state) -{ - int evtchn_fd = -1; - - if (state->xce_handle != NULL) { - evtchn_fd = qemu_xen_evtchn_fd(state->xce_handle); - } - - state->buffered_io_timer = timer_new_ms(QEMU_CLOCK_REALTIME, handle_buffered_io, - state); - - if (evtchn_fd != -1) { - CPUState *cpu_state; - - DPRINTF("%s: Init cpu_by_vcpu_id\n", __func__); - CPU_FOREACH(cpu_state) { - DPRINTF("%s: cpu_by_vcpu_id[%d]=%p\n", - __func__, cpu_state->cpu_index, cpu_state); - state->cpu_by_vcpu_id[cpu_state->cpu_index] = cpu_state; - } - qemu_set_fd_handler(evtchn_fd, cpu_handle_ioreq, NULL, state); - } -} - - -static void xen_hvm_change_state_handler(void *opaque, bool running, - RunState rstate) -{ - XenIOState *state = opaque; - - if (running) { - xen_main_loop_prepare(state); - } - - xen_set_ioreq_server_state(xen_domid, - state->ioservid, - (rstate == RUN_STATE_RUNNING)); -} - -static void xen_exit_notifier(Notifier *n, void *data) -{ - XenIOState *state = container_of(n, XenIOState, exit); - - xen_destroy_ioreq_server(xen_domid, state->ioservid); - if (state->fres != NULL) { - xenforeignmemory_unmap_resource(xen_fmem, state->fres); - } - - qemu_xen_evtchn_close(state->xce_handle); - xs_daemon_close(state->xenstore); -} - #ifdef XEN_COMPAT_PHYSMAP static void xen_read_physmap(XenIOState *state) { @@ -1310,175 +572,17 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data) xc_set_hvm_param(xen_xc, xen_domid, HVM_PARAM_ACPI_S_STATE, 0); } -static int xen_map_ioreq_server(XenIOState *state) -{ - void *addr = NULL; - xen_pfn_t ioreq_pfn; - xen_pfn_t bufioreq_pfn; - evtchn_port_t bufioreq_evtchn; - int rc; - - /* - * Attempt to map using the resource API and fall back to normal - * foreign mapping if this is not supported. - */ - QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_bufioreq != 0); - QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_ioreq(0) != 1); - state->fres = xenforeignmemory_map_resource(xen_fmem, xen_domid, - XENMEM_resource_ioreq_server, - state->ioservid, 0, 2, - &addr, - PROT_READ | PROT_WRITE, 0); - if (state->fres != NULL) { - trace_xen_map_resource_ioreq(state->ioservid, addr); - state->buffered_io_page = addr; - state->shared_page = addr + TARGET_PAGE_SIZE; - } else if (errno != EOPNOTSUPP) { - error_report("failed to map ioreq server resources: error %d handle=%p", - errno, xen_xc); - return -1; - } - - rc = xen_get_ioreq_server_info(xen_domid, state->ioservid, - (state->shared_page == NULL) ? - &ioreq_pfn : NULL, - (state->buffered_io_page == NULL) ? - &bufioreq_pfn : NULL, - &bufioreq_evtchn); - if (rc < 0) { - error_report("failed to get ioreq server info: error %d handle=%p", - errno, xen_xc); - return rc; - } - - if (state->shared_page == NULL) { - DPRINTF("shared page at pfn %lx\n", ioreq_pfn); - - state->shared_page = xenforeignmemory_map(xen_fmem, xen_domid, - PROT_READ | PROT_WRITE, - 1, &ioreq_pfn, NULL); - if (state->shared_page == NULL) { - error_report("map shared IO page returned error %d handle=%p", - errno, xen_xc); - } - } - - if (state->buffered_io_page == NULL) { - DPRINTF("buffered io page at pfn %lx\n", bufioreq_pfn); - - state->buffered_io_page = xenforeignmemory_map(xen_fmem, xen_domid, - PROT_READ | PROT_WRITE, - 1, &bufioreq_pfn, - NULL); - if (state->buffered_io_page == NULL) { - error_report("map buffered IO page returned error %d", errno); - return -1; - } - } - - if (state->shared_page == NULL || state->buffered_io_page == NULL) { - return -1; - } - - DPRINTF("buffered io evtchn is %x\n", bufioreq_evtchn); - - state->bufioreq_remote_port = bufioreq_evtchn; - - return 0; -} - void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) { MachineState *ms = MACHINE(pcms); unsigned int max_cpus = ms->smp.max_cpus; - int i, rc; + int rc; xen_pfn_t ioreq_pfn; XenIOState *state; - setup_xen_backend_ops(); - state = g_new0(XenIOState, 1); - state->xce_handle = qemu_xen_evtchn_open(); - if (state->xce_handle == NULL) { - perror("xen: event channel open"); - goto err; - } - - state->xenstore = xs_daemon_open(); - if (state->xenstore == NULL) { - perror("xen: xenstore open"); - goto err; - } - - xen_create_ioreq_server(xen_domid, &state->ioservid); - - state->exit.notify = xen_exit_notifier; - qemu_add_exit_notifier(&state->exit); - - /* - * Register wake-up support in QMP query-current-machine API - */ - qemu_register_wakeup_support(); - - rc = xen_map_ioreq_server(state); - if (rc < 0) { - goto err; - } - - /* Note: cpus is empty at this point in init */ - state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus); - - rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true); - if (rc < 0) { - error_report("failed to enable ioreq server info: error %d handle=%p", - errno, xen_xc); - goto err; - } - - state->ioreq_local_port = g_new0(evtchn_port_t, max_cpus); - - /* FIXME: how about if we overflow the page here? */ - for (i = 0; i < max_cpus; i++) { - rc = qemu_xen_evtchn_bind_interdomain(state->xce_handle, xen_domid, - xen_vcpu_eport(state->shared_page, - i)); - if (rc == -1) { - error_report("shared evtchn %d bind error %d", i, errno); - goto err; - } - state->ioreq_local_port[i] = rc; - } - - rc = qemu_xen_evtchn_bind_interdomain(state->xce_handle, xen_domid, - state->bufioreq_remote_port); - if (rc == -1) { - error_report("buffered evtchn bind error %d", errno); - goto err; - } - state->bufioreq_local_port = rc; - - /* Init RAM management */ -#ifdef XEN_COMPAT_PHYSMAP - xen_map_cache_init(xen_phys_offset_to_gaddr, state); -#else - xen_map_cache_init(NULL, state); -#endif - - qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); - - state->memory_listener = xen_memory_listener; - memory_listener_register(&state->memory_listener, &address_space_memory); - - state->io_listener = xen_io_listener; - memory_listener_register(&state->io_listener, &address_space_io); - - state->device_listener = xen_device_listener; - QLIST_INIT(&state->dev_list); - device_listener_register(&state->device_listener); - - xen_bus_init(); - xen_be_init(); + xen_register_ioreq(state, max_cpus, xen_memory_listener); QLIST_INIT(&xen_physmap); xen_read_physmap(state); @@ -1518,59 +622,11 @@ err: exit(1); } -void destroy_hvm_domain(bool reboot) -{ - xc_interface *xc_handle; - int sts; - int rc; - - unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff; - - if (xen_dmod) { - rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason); - if (!rc) { - return; - } - if (errno != ENOTTY /* old Xen */) { - perror("xendevicemodel_shutdown failed"); - } - /* well, try the old thing then */ - } - - xc_handle = xc_interface_open(0, 0, 0); - if (xc_handle == NULL) { - fprintf(stderr, "Cannot acquire xenctrl handle\n"); - } else { - sts = xc_domain_shutdown(xc_handle, xen_domid, reason); - if (sts != 0) { - fprintf(stderr, "xc_domain_shutdown failed to issue %s, " - "sts %d, %s\n", reboot ? "reboot" : "poweroff", - sts, strerror(errno)); - } else { - fprintf(stderr, "Issued domain %d %s\n", xen_domid, - reboot ? "reboot" : "poweroff"); - } - xc_interface_close(xc_handle); - } -} - void xen_register_framebuffer(MemoryRegion *mr) { framebuffer = mr; } -void xen_shutdown_fatal_error(const char *fmt, ...) -{ - va_list ap; - - va_start(ap, fmt); - vfprintf(stderr, fmt, ap); - va_end(ap); - fprintf(stderr, "Will destroy the domain.\n"); - /* destroy the domain */ - qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR); -} - void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length) { if (unlikely(xen_in_migration)) { @@ -1602,3 +658,57 @@ void qmp_xen_set_global_dirty_log(bool enable, Error **errp) memory_global_dirty_log_stop(GLOBAL_DIRTY_MIGRATION); } } + +void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section, + bool add) +{ + hwaddr start_addr = section->offset_within_address_space; + ram_addr_t size = int128_get64(section->size); + bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA); + hvmmem_type_t mem_type; + + if (!memory_region_is_ram(section->mr)) { + return; + } + + if (log_dirty != add) { + return; + } + + trace_xen_client_set_memory(start_addr, size, log_dirty); + + start_addr &= TARGET_PAGE_MASK; + size = TARGET_PAGE_ALIGN(size); + + if (add) { + if (!memory_region_is_rom(section->mr)) { + xen_add_to_physmap(state, start_addr, size, + section->mr, section->offset_within_region); + } else { + mem_type = HVMMEM_ram_ro; + if (xen_set_mem_type(xen_domid, mem_type, + start_addr >> TARGET_PAGE_BITS, + size >> TARGET_PAGE_BITS)) { + DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n", + start_addr); + } + } + } else { + if (xen_remove_from_physmap(state, start_addr, size) < 0) { + DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n", start_addr); + } + } +} + +void arch_handle_ioreq(XenIOState *state, ioreq_t *req) +{ + switch (req->type) { + case IOREQ_TYPE_VMWARE_PORT: + handle_vmport_ioreq(state, req); + break; + default: + hw_error("Invalid ioreq type 0x%x\n", req->type); + } + + return; +} diff --git a/hw/xen/meson.build b/hw/xen/meson.build index 202752e557..afd20754a1 100644 --- a/hw/xen/meson.build +++ b/hw/xen/meson.build @@ -29,4 +29,7 @@ specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss) xen_ss = ss.source_set() -xen_ss.add(when: 'CONFIG_XEN', if_true: files('xen-mapcache.c')) +xen_ss.add(when: 'CONFIG_XEN', if_true: files( + 'xen-mapcache.c', + 'xen-hvm-common.c', +)) diff --git a/hw/xen/trace-events b/hw/xen/trace-events index f977c7c8c6..67a6c41926 100644 --- a/hw/xen/trace-events +++ b/hw/xen/trace-events @@ -42,6 +42,20 @@ xs_node_vscanf(char *path, char *value) "%s %s" xs_node_watch(char *path) "%s" xs_node_unwatch(char *path) "%s" +# xen-hvm.c +xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: 0x%lx, size 0x%lx" +xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty) "0x%"PRIx64" size 0x%lx, log_dirty %i" +handle_ioreq(void *req, uint32_t type, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p type=%d dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" +handle_ioreq_read(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p read type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" +handle_ioreq_write(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p write type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" +cpu_ioreq_pio(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p pio dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" +cpu_ioreq_pio_read_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio read reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" +cpu_ioreq_pio_write_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio write reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" +cpu_ioreq_move(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p copy dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" +xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p" +cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" +cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" + # xen-mapcache.c xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64 xen_remap_bucket(uint64_t index) "index 0x%"PRIx64 diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c new file mode 100644 index 0000000000..a31b067404 --- /dev/null +++ b/hw/xen/xen-hvm-common.c @@ -0,0 +1,860 @@ +#include "qemu/osdep.h" +#include "qemu/units.h" +#include "qapi/error.h" +#include "trace.h" + +#include "hw/pci/pci_host.h" +#include "hw/xen/xen-hvm-common.h" +#include "hw/xen/xen-bus.h" +#include "hw/boards.h" +#include "hw/xen/arch_hvm.h" + +MemoryRegion ram_memory; + +void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr, + Error **errp) +{ + unsigned long nr_pfn; + xen_pfn_t *pfn_list; + int i; + + if (runstate_check(RUN_STATE_INMIGRATE)) { + /* RAM already populated in Xen */ + fprintf(stderr, "%s: do not alloc "RAM_ADDR_FMT + " bytes of ram at "RAM_ADDR_FMT" when runstate is INMIGRATE\n", + __func__, size, ram_addr); + return; + } + + if (mr == &ram_memory) { + return; + } + + trace_xen_ram_alloc(ram_addr, size); + + nr_pfn = size >> TARGET_PAGE_BITS; + pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn); + + for (i = 0; i < nr_pfn; i++) { + pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i; + } + + if (xc_domain_populate_physmap_exact(xen_xc, xen_domid, nr_pfn, 0, 0, pfn_list)) { + error_setg(errp, "xen: failed to populate ram at " RAM_ADDR_FMT, + ram_addr); + } + + g_free(pfn_list); +} + +static void xen_set_memory(struct MemoryListener *listener, + MemoryRegionSection *section, + bool add) +{ + XenIOState *state = container_of(listener, XenIOState, memory_listener); + + if (section->mr == &ram_memory) { + return; + } else { + if (add) { + xen_map_memory_section(xen_domid, state->ioservid, + section); + } else { + xen_unmap_memory_section(xen_domid, state->ioservid, + section); + } + } + + arch_xen_set_memory(state, section, add); +} + +void xen_region_add(MemoryListener *listener, + MemoryRegionSection *section) +{ + memory_region_ref(section->mr); + xen_set_memory(listener, section, true); +} + +void xen_region_del(MemoryListener *listener, + MemoryRegionSection *section) +{ + xen_set_memory(listener, section, false); + memory_region_unref(section->mr); +} + +void xen_io_add(MemoryListener *listener, + MemoryRegionSection *section) +{ + XenIOState *state = container_of(listener, XenIOState, io_listener); + MemoryRegion *mr = section->mr; + + if (mr->ops == &unassigned_io_ops) { + return; + } + + memory_region_ref(mr); + + xen_map_io_section(xen_domid, state->ioservid, section); +} + +void xen_io_del(MemoryListener *listener, + MemoryRegionSection *section) +{ + XenIOState *state = container_of(listener, XenIOState, io_listener); + MemoryRegion *mr = section->mr; + + if (mr->ops == &unassigned_io_ops) { + return; + } + + xen_unmap_io_section(xen_domid, state->ioservid, section); + + memory_region_unref(mr); +} + +void xen_device_realize(DeviceListener *listener, + DeviceState *dev) +{ + XenIOState *state = container_of(listener, XenIOState, device_listener); + + if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { + PCIDevice *pci_dev = PCI_DEVICE(dev); + XenPciDevice *xendev = g_new(XenPciDevice, 1); + + xendev->pci_dev = pci_dev; + xendev->sbdf = PCI_BUILD_BDF(pci_dev_bus_num(pci_dev), + pci_dev->devfn); + QLIST_INSERT_HEAD(&state->dev_list, xendev, entry); + + xen_map_pcidev(xen_domid, state->ioservid, pci_dev); + } +} + +void xen_device_unrealize(DeviceListener *listener, + DeviceState *dev) +{ + XenIOState *state = container_of(listener, XenIOState, device_listener); + + if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { + PCIDevice *pci_dev = PCI_DEVICE(dev); + XenPciDevice *xendev, *next; + + xen_unmap_pcidev(xen_domid, state->ioservid, pci_dev); + + QLIST_FOREACH_SAFE(xendev, &state->dev_list, entry, next) { + if (xendev->pci_dev == pci_dev) { + QLIST_REMOVE(xendev, entry); + g_free(xendev); + break; + } + } + } +} + +MemoryListener xen_io_listener = { + .name = "xen-io", + .region_add = xen_io_add, + .region_del = xen_io_del, + .priority = 10, +}; + +DeviceListener xen_device_listener = { + .realize = xen_device_realize, + .unrealize = xen_device_unrealize, +}; + +/* get the ioreq packets from share mem */ +static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu) +{ + ioreq_t *req = xen_vcpu_ioreq(state->shared_page, vcpu); + + if (req->state != STATE_IOREQ_READY) { + DPRINTF("I/O request not ready: " + "%x, ptr: %x, port: %"PRIx64", " + "data: %"PRIx64", count: %u, size: %u\n", + req->state, req->data_is_ptr, req->addr, + req->data, req->count, req->size); + return NULL; + } + + xen_rmb(); /* see IOREQ_READY /then/ read contents of ioreq */ + + req->state = STATE_IOREQ_INPROCESS; + return req; +} + +/* use poll to get the port notification */ +/* ioreq_vec--out,the */ +/* retval--the number of ioreq packet */ +static ioreq_t *cpu_get_ioreq(XenIOState *state) +{ + MachineState *ms = MACHINE(qdev_get_machine()); + unsigned int max_cpus = ms->smp.max_cpus; + int i; + evtchn_port_t port; + + port = qemu_xen_evtchn_pending(state->xce_handle); + if (port == state->bufioreq_local_port) { + timer_mod(state->buffered_io_timer, + BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); + return NULL; + } + + if (port != -1) { + for (i = 0; i < max_cpus; i++) { + if (state->ioreq_local_port[i] == port) { + break; + } + } + + if (i == max_cpus) { + hw_error("Fatal error while trying to get io event!\n"); + } + + /* unmask the wanted port again */ + qemu_xen_evtchn_unmask(state->xce_handle, port); + + /* get the io packet from shared memory */ + state->send_vcpu = i; + return cpu_get_ioreq_from_shared_memory(state, i); + } + + /* read error or read nothing */ + return NULL; +} + +static uint32_t do_inp(uint32_t addr, unsigned long size) +{ + switch (size) { + case 1: + return cpu_inb(addr); + case 2: + return cpu_inw(addr); + case 4: + return cpu_inl(addr); + default: + hw_error("inp: bad size: %04x %lx", addr, size); + } +} + +static void do_outp(uint32_t addr, + unsigned long size, uint32_t val) +{ + switch (size) { + case 1: + return cpu_outb(addr, val); + case 2: + return cpu_outw(addr, val); + case 4: + return cpu_outl(addr, val); + default: + hw_error("outp: bad size: %04x %lx", addr, size); + } +} + +/* + * Helper functions which read/write an object from/to physical guest + * memory, as part of the implementation of an ioreq. + * + * Equivalent to + * cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i, + * val, req->size, 0/1) + * except without the integer overflow problems. + */ +static void rw_phys_req_item(hwaddr addr, + ioreq_t *req, uint32_t i, void *val, int rw) +{ + /* Do everything unsigned so overflow just results in a truncated result + * and accesses to undesired parts of guest memory, which is up + * to the guest */ + hwaddr offset = (hwaddr)req->size * i; + if (req->df) { + addr -= offset; + } else { + addr += offset; + } + cpu_physical_memory_rw(addr, val, req->size, rw); +} + +static inline void read_phys_req_item(hwaddr addr, + ioreq_t *req, uint32_t i, void *val) +{ + rw_phys_req_item(addr, req, i, val, 0); +} +static inline void write_phys_req_item(hwaddr addr, + ioreq_t *req, uint32_t i, void *val) +{ + rw_phys_req_item(addr, req, i, val, 1); +} + + +void cpu_ioreq_pio(ioreq_t *req) +{ + uint32_t i; + + trace_cpu_ioreq_pio(req, req->dir, req->df, req->data_is_ptr, req->addr, + req->data, req->count, req->size); + + if (req->size > sizeof(uint32_t)) { + hw_error("PIO: bad size (%u)", req->size); + } + + if (req->dir == IOREQ_READ) { + if (!req->data_is_ptr) { + req->data = do_inp(req->addr, req->size); + trace_cpu_ioreq_pio_read_reg(req, req->data, req->addr, + req->size); + } else { + uint32_t tmp; + + for (i = 0; i < req->count; i++) { + tmp = do_inp(req->addr, req->size); + write_phys_req_item(req->data, req, i, &tmp); + } + } + } else if (req->dir == IOREQ_WRITE) { + if (!req->data_is_ptr) { + trace_cpu_ioreq_pio_write_reg(req, req->data, req->addr, + req->size); + do_outp(req->addr, req->size, req->data); + } else { + for (i = 0; i < req->count; i++) { + uint32_t tmp = 0; + + read_phys_req_item(req->data, req, i, &tmp); + do_outp(req->addr, req->size, tmp); + } + } + } +} + +static void cpu_ioreq_move(ioreq_t *req) +{ + uint32_t i; + + trace_cpu_ioreq_move(req, req->dir, req->df, req->data_is_ptr, req->addr, + req->data, req->count, req->size); + + if (req->size > sizeof(req->data)) { + hw_error("MMIO: bad size (%u)", req->size); + } + + if (!req->data_is_ptr) { + if (req->dir == IOREQ_READ) { + for (i = 0; i < req->count; i++) { + read_phys_req_item(req->addr, req, i, &req->data); + } + } else if (req->dir == IOREQ_WRITE) { + for (i = 0; i < req->count; i++) { + write_phys_req_item(req->addr, req, i, &req->data); + } + } + } else { + uint64_t tmp; + + if (req->dir == IOREQ_READ) { + for (i = 0; i < req->count; i++) { + read_phys_req_item(req->addr, req, i, &tmp); + write_phys_req_item(req->data, req, i, &tmp); + } + } else if (req->dir == IOREQ_WRITE) { + for (i = 0; i < req->count; i++) { + read_phys_req_item(req->data, req, i, &tmp); + write_phys_req_item(req->addr, req, i, &tmp); + } + } + } +} + +static void cpu_ioreq_config(XenIOState *state, ioreq_t *req) +{ + uint32_t sbdf = req->addr >> 32; + uint32_t reg = req->addr; + XenPciDevice *xendev; + + if (req->size != sizeof(uint8_t) && req->size != sizeof(uint16_t) && + req->size != sizeof(uint32_t)) { + hw_error("PCI config access: bad size (%u)", req->size); + } + + if (req->count != 1) { + hw_error("PCI config access: bad count (%u)", req->count); + } + + QLIST_FOREACH(xendev, &state->dev_list, entry) { + if (xendev->sbdf != sbdf) { + continue; + } + + if (!req->data_is_ptr) { + if (req->dir == IOREQ_READ) { + req->data = pci_host_config_read_common( + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, + req->size); + trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, + req->size, req->data); + } else if (req->dir == IOREQ_WRITE) { + trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, + req->size, req->data); + pci_host_config_write_common( + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, + req->data, req->size); + } + } else { + uint32_t tmp; + + if (req->dir == IOREQ_READ) { + tmp = pci_host_config_read_common( + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, + req->size); + trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, + req->size, tmp); + write_phys_req_item(req->data, req, 0, &tmp); + } else if (req->dir == IOREQ_WRITE) { + read_phys_req_item(req->data, req, 0, &tmp); + trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, + req->size, tmp); + pci_host_config_write_common( + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, + tmp, req->size); + } + } + } +} + +static void handle_ioreq(XenIOState *state, ioreq_t *req) +{ + trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr, + req->addr, req->data, req->count, req->size); + + if (!req->data_is_ptr && (req->dir == IOREQ_WRITE) && + (req->size < sizeof (target_ulong))) { + req->data &= ((target_ulong) 1 << (8 * req->size)) - 1; + } + + if (req->dir == IOREQ_WRITE) + trace_handle_ioreq_write(req, req->type, req->df, req->data_is_ptr, + req->addr, req->data, req->count, req->size); + + switch (req->type) { + case IOREQ_TYPE_PIO: + cpu_ioreq_pio(req); + break; + case IOREQ_TYPE_COPY: + cpu_ioreq_move(req); + break; + case IOREQ_TYPE_TIMEOFFSET: + break; + case IOREQ_TYPE_INVALIDATE: + xen_invalidate_map_cache(); + break; + case IOREQ_TYPE_PCI_CONFIG: + cpu_ioreq_config(state, req); + break; + default: + arch_handle_ioreq(state, req); + } + if (req->dir == IOREQ_READ) { + trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr, + req->addr, req->data, req->count, req->size); + } +} + +static bool handle_buffered_iopage(XenIOState *state) +{ + buffered_iopage_t *buf_page = state->buffered_io_page; + buf_ioreq_t *buf_req = NULL; + bool handled_ioreq = false; + ioreq_t req; + int qw; + + if (!buf_page) { + return 0; + } + + memset(&req, 0x00, sizeof(req)); + req.state = STATE_IOREQ_READY; + req.count = 1; + req.dir = IOREQ_WRITE; + + for (;;) { + uint32_t rdptr = buf_page->read_pointer, wrptr; + + xen_rmb(); + wrptr = buf_page->write_pointer; + xen_rmb(); + if (rdptr != buf_page->read_pointer) { + continue; + } + if (rdptr == wrptr) { + break; + } + buf_req = &buf_page->buf_ioreq[rdptr % IOREQ_BUFFER_SLOT_NUM]; + req.size = 1U << buf_req->size; + req.addr = buf_req->addr; + req.data = buf_req->data; + req.type = buf_req->type; + xen_rmb(); + qw = (req.size == 8); + if (qw) { + if (rdptr + 1 == wrptr) { + hw_error("Incomplete quad word buffered ioreq"); + } + buf_req = &buf_page->buf_ioreq[(rdptr + 1) % + IOREQ_BUFFER_SLOT_NUM]; + req.data |= ((uint64_t)buf_req->data) << 32; + xen_rmb(); + } + + handle_ioreq(state, &req); + + /* Only req.data may get updated by handle_ioreq(), albeit even that + * should not happen as such data would never make it to the guest (we + * can only usefully see writes here after all). + */ + assert(req.state == STATE_IOREQ_READY); + assert(req.count == 1); + assert(req.dir == IOREQ_WRITE); + assert(!req.data_is_ptr); + + qatomic_add(&buf_page->read_pointer, qw + 1); + handled_ioreq = true; + } + + return handled_ioreq; +} + +static void handle_buffered_io(void *opaque) +{ + XenIOState *state = opaque; + + if (handle_buffered_iopage(state)) { + timer_mod(state->buffered_io_timer, + BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); + } else { + timer_del(state->buffered_io_timer); + qemu_xen_evtchn_unmask(state->xce_handle, state->bufioreq_local_port); + } +} + +static void cpu_handle_ioreq(void *opaque) +{ + XenIOState *state = opaque; + ioreq_t *req = cpu_get_ioreq(state); + + handle_buffered_iopage(state); + if (req) { + ioreq_t copy = *req; + + xen_rmb(); + handle_ioreq(state, ©); + req->data = copy.data; + + if (req->state != STATE_IOREQ_INPROCESS) { + fprintf(stderr, "Badness in I/O request ... not in service?!: " + "%x, ptr: %x, port: %"PRIx64", " + "data: %"PRIx64", count: %u, size: %u, type: %u\n", + req->state, req->data_is_ptr, req->addr, + req->data, req->count, req->size, req->type); + destroy_hvm_domain(false); + return; + } + + xen_wmb(); /* Update ioreq contents /then/ update state. */ + + /* + * We do this before we send the response so that the tools + * have the opportunity to pick up on the reset before the + * guest resumes and does a hlt with interrupts disabled which + * causes Xen to powerdown the domain. + */ + if (runstate_is_running()) { + ShutdownCause request; + + if (qemu_shutdown_requested_get()) { + destroy_hvm_domain(false); + } + request = qemu_reset_requested_get(); + if (request) { + qemu_system_reset(request); + destroy_hvm_domain(true); + } + } + + req->state = STATE_IORESP_READY; + qemu_xen_evtchn_notify(state->xce_handle, + state->ioreq_local_port[state->send_vcpu]); + } +} + +static void xen_main_loop_prepare(XenIOState *state) +{ + int evtchn_fd = -1; + + if (state->xce_handle != NULL) { + evtchn_fd = qemu_xen_evtchn_fd(state->xce_handle); + } + + state->buffered_io_timer = timer_new_ms(QEMU_CLOCK_REALTIME, handle_buffered_io, + state); + + if (evtchn_fd != -1) { + CPUState *cpu_state; + + DPRINTF("%s: Init cpu_by_vcpu_id\n", __func__); + CPU_FOREACH(cpu_state) { + DPRINTF("%s: cpu_by_vcpu_id[%d]=%p\n", + __func__, cpu_state->cpu_index, cpu_state); + state->cpu_by_vcpu_id[cpu_state->cpu_index] = cpu_state; + } + qemu_set_fd_handler(evtchn_fd, cpu_handle_ioreq, NULL, state); + } +} + + +void xen_hvm_change_state_handler(void *opaque, bool running, + RunState rstate) +{ + XenIOState *state = opaque; + + if (running) { + xen_main_loop_prepare(state); + } + + xen_set_ioreq_server_state(xen_domid, + state->ioservid, + (rstate == RUN_STATE_RUNNING)); +} + +void xen_exit_notifier(Notifier *n, void *data) +{ + XenIOState *state = container_of(n, XenIOState, exit); + + xen_destroy_ioreq_server(xen_domid, state->ioservid); + if (state->fres != NULL) { + xenforeignmemory_unmap_resource(xen_fmem, state->fres); + } + + qemu_xen_evtchn_close(state->xce_handle); + xs_daemon_close(state->xenstore); +} + +static int xen_map_ioreq_server(XenIOState *state) +{ + void *addr = NULL; + xen_pfn_t ioreq_pfn; + xen_pfn_t bufioreq_pfn; + evtchn_port_t bufioreq_evtchn; + int rc; + + /* + * Attempt to map using the resource API and fall back to normal + * foreign mapping if this is not supported. + */ + QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_bufioreq != 0); + QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_ioreq(0) != 1); + state->fres = xenforeignmemory_map_resource(xen_fmem, xen_domid, + XENMEM_resource_ioreq_server, + state->ioservid, 0, 2, + &addr, + PROT_READ | PROT_WRITE, 0); + if (state->fres != NULL) { + trace_xen_map_resource_ioreq(state->ioservid, addr); + state->buffered_io_page = addr; + state->shared_page = addr + XC_PAGE_SIZE; + } else if (errno != EOPNOTSUPP) { + error_report("failed to map ioreq server resources: error %d handle=%p", + errno, xen_xc); + return -1; + } + + rc = xen_get_ioreq_server_info(xen_domid, state->ioservid, + (state->shared_page == NULL) ? + &ioreq_pfn : NULL, + (state->buffered_io_page == NULL) ? + &bufioreq_pfn : NULL, + &bufioreq_evtchn); + if (rc < 0) { + error_report("failed to get ioreq server info: error %d handle=%p", + errno, xen_xc); + return rc; + } + + if (state->shared_page == NULL) { + DPRINTF("shared page at pfn %lx\n", ioreq_pfn); + + state->shared_page = xenforeignmemory_map(xen_fmem, xen_domid, + PROT_READ | PROT_WRITE, + 1, &ioreq_pfn, NULL); + if (state->shared_page == NULL) { + error_report("map shared IO page returned error %d handle=%p", + errno, xen_xc); + } + } + + if (state->buffered_io_page == NULL) { + DPRINTF("buffered io page at pfn %lx\n", bufioreq_pfn); + + state->buffered_io_page = xenforeignmemory_map(xen_fmem, xen_domid, + PROT_READ | PROT_WRITE, + 1, &bufioreq_pfn, + NULL); + if (state->buffered_io_page == NULL) { + error_report("map buffered IO page returned error %d", errno); + return -1; + } + } + + if (state->shared_page == NULL || state->buffered_io_page == NULL) { + return -1; + } + + DPRINTF("buffered io evtchn is %x\n", bufioreq_evtchn); + + state->bufioreq_remote_port = bufioreq_evtchn; + + return 0; +} + +void destroy_hvm_domain(bool reboot) +{ + xc_interface *xc_handle; + int sts; + int rc; + + unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff; + + if (xen_dmod) { + rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason); + if (!rc) { + return; + } + if (errno != ENOTTY /* old Xen */) { + perror("xendevicemodel_shutdown failed"); + } + /* well, try the old thing then */ + } + + xc_handle = xc_interface_open(0, 0, 0); + if (xc_handle == NULL) { + fprintf(stderr, "Cannot acquire xenctrl handle\n"); + } else { + sts = xc_domain_shutdown(xc_handle, xen_domid, reason); + if (sts != 0) { + fprintf(stderr, "xc_domain_shutdown failed to issue %s, " + "sts %d, %s\n", reboot ? "reboot" : "poweroff", + sts, strerror(errno)); + } else { + fprintf(stderr, "Issued domain %d %s\n", xen_domid, + reboot ? "reboot" : "poweroff"); + } + xc_interface_close(xc_handle); + } +} + +void xen_shutdown_fatal_error(const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + vfprintf(stderr, fmt, ap); + va_end(ap); + fprintf(stderr, "Will destroy the domain.\n"); + /* destroy the domain */ + qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR); +} + +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, + MemoryListener xen_memory_listener) +{ + int i, rc; + + setup_xen_backend_ops(); + + state->xce_handle = qemu_xen_evtchn_open(); + if (state->xce_handle == NULL) { + perror("xen: event channel open"); + goto err; + } + + state->xenstore = xs_daemon_open(); + if (state->xenstore == NULL) { + perror("xen: xenstore open"); + goto err; + } + + xen_create_ioreq_server(xen_domid, &state->ioservid); + + state->exit.notify = xen_exit_notifier; + qemu_add_exit_notifier(&state->exit); + + /* + * Register wake-up support in QMP query-current-machine API + */ + qemu_register_wakeup_support(); + + rc = xen_map_ioreq_server(state); + if (rc < 0) { + goto err; + } + + /* Note: cpus is empty at this point in init */ + state->cpu_by_vcpu_id = g_malloc0(max_cpus * sizeof(CPUState *)); + + rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true); + if (rc < 0) { + error_report("failed to enable ioreq server info: error %d handle=%p", + errno, xen_xc); + goto err; + } + + state->ioreq_local_port = g_malloc0(max_cpus * sizeof (evtchn_port_t)); + + /* FIXME: how about if we overflow the page here? */ + for (i = 0; i < max_cpus; i++) { + rc = qemu_xen_evtchn_bind_interdomain(state->xce_handle, xen_domid, + xen_vcpu_eport(state->shared_page, + i)); + if (rc == -1) { + error_report("shared evtchn %d bind error %d", i, errno); + goto err; + } + state->ioreq_local_port[i] = rc; + } + + rc = qemu_xen_evtchn_bind_interdomain(state->xce_handle, xen_domid, + state->bufioreq_remote_port); + if (rc == -1) { + error_report("buffered evtchn bind error %d", errno); + goto err; + } + state->bufioreq_local_port = rc; + + /* Init RAM management */ +#ifdef XEN_COMPAT_PHYSMAP + xen_map_cache_init(xen_phys_offset_to_gaddr, state); +#else + xen_map_cache_init(NULL, state); +#endif + + qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); + + state->memory_listener = xen_memory_listener; + memory_listener_register(&state->memory_listener, &address_space_memory); + + state->io_listener = xen_io_listener; + memory_listener_register(&state->io_listener, &address_space_io); + + state->device_listener = xen_device_listener; + QLIST_INIT(&state->dev_list); + device_listener_register(&state->device_listener); + + xen_bus_init(); + + xen_be_init(); + + return; +err: + error_report("xen hardware virtual machine initialisation failed"); + exit(1); +} diff --git a/include/hw/i386/xen_arch_hvm.h b/include/hw/i386/xen_arch_hvm.h new file mode 100644 index 0000000000..1000f8f543 --- /dev/null +++ b/include/hw/i386/xen_arch_hvm.h @@ -0,0 +1,11 @@ +#ifndef HW_XEN_ARCH_I386_HVM_H +#define HW_XEN_ARCH_I386_HVM_H + +#include +#include "hw/xen/xen-hvm-common.h" + +void arch_handle_ioreq(XenIOState *state, ioreq_t *req); +void arch_xen_set_memory(XenIOState *state, + MemoryRegionSection *section, + bool add); +#endif diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h new file mode 100644 index 0000000000..26674648d8 --- /dev/null +++ b/include/hw/xen/arch_hvm.h @@ -0,0 +1,3 @@ +#if defined(TARGET_I386) || defined(TARGET_X86_64) +#include "hw/i386/xen_arch_hvm.h" +#endif diff --git a/include/hw/xen/xen-hvm-common.h b/include/hw/xen/xen-hvm-common.h new file mode 100644 index 0000000000..858ea07075 --- /dev/null +++ b/include/hw/xen/xen-hvm-common.h @@ -0,0 +1,99 @@ +#ifndef HW_XEN_HVM_COMMON_H +#define HW_XEN_HVM_COMMON_H + +#include "qemu/osdep.h" +#include "qemu/units.h" + +#include "cpu.h" +#include "hw/pci/pci.h" +#include "hw/hw.h" +#include "hw/xen/xen_native.h" +#include "hw/xen/xen-legacy-backend.h" +#include "sysemu/runstate.h" +#include "sysemu/sysemu.h" +#include "sysemu/xen.h" +#include "sysemu/xen-mapcache.h" + +#include + +extern MemoryRegion ram_memory; +extern MemoryListener xen_io_listener; +extern DeviceListener xen_device_listener; + +//#define DEBUG_XEN_HVM + +#ifdef DEBUG_XEN_HVM +#define DPRINTF(fmt, ...) \ + do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0) +#else +#define DPRINTF(fmt, ...) \ + do { } while (0) +#endif + +static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i) +{ + return shared_page->vcpu_ioreq[i].vp_eport; +} +static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu) +{ + return &shared_page->vcpu_ioreq[vcpu]; +} + +#define BUFFER_IO_MAX_DELAY 100 + +typedef struct XenPhysmap { + hwaddr start_addr; + ram_addr_t size; + const char *name; + hwaddr phys_offset; + + QLIST_ENTRY(XenPhysmap) list; +} XenPhysmap; + +typedef struct XenPciDevice { + PCIDevice *pci_dev; + uint32_t sbdf; + QLIST_ENTRY(XenPciDevice) entry; +} XenPciDevice; + +typedef struct XenIOState { + ioservid_t ioservid; + shared_iopage_t *shared_page; + buffered_iopage_t *buffered_io_page; + xenforeignmemory_resource_handle *fres; + QEMUTimer *buffered_io_timer; + CPUState **cpu_by_vcpu_id; + /* the evtchn port for polling the notification, */ + evtchn_port_t *ioreq_local_port; + /* evtchn remote and local ports for buffered io */ + evtchn_port_t bufioreq_remote_port; + evtchn_port_t bufioreq_local_port; + /* the evtchn fd for polling */ + xenevtchn_handle *xce_handle; + /* which vcpu we are serving */ + int send_vcpu; + + struct xs_handle *xenstore; + MemoryListener memory_listener; + MemoryListener io_listener; + QLIST_HEAD(, XenPciDevice) dev_list; + DeviceListener device_listener; + + Notifier exit; +} XenIOState; + +void xen_exit_notifier(Notifier *n, void *data); + +void xen_region_add(MemoryListener *listener, MemoryRegionSection *section); +void xen_region_del(MemoryListener *listener, MemoryRegionSection *section); +void xen_io_add(MemoryListener *listener, MemoryRegionSection *section); +void xen_io_del(MemoryListener *listener, MemoryRegionSection *section); +void xen_device_realize(DeviceListener *listener, DeviceState *dev); +void xen_device_unrealize(DeviceListener *listener, DeviceState *dev); + +void xen_hvm_change_state_handler(void *opaque, bool running, RunState rstate); +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, + MemoryListener xen_memory_listener); + +void cpu_ioreq_pio(ioreq_t *req); +#endif /* HW_XEN_HVM_COMMON_H */ -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 22:48:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 22:48:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.519977.807183 (Exim 4.92) (envelope-from ) id 1pmMma-00070u-6s; Tue, 11 Apr 2023 22:48:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 519977.807183; Tue, 11 Apr 2023 22:48:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmZ-0006zX-OK; Tue, 11 Apr 2023 22:48:11 +0000 Received: by outflank-mailman (input) for mailman id 519977; Tue, 11 Apr 2023 22:48:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmMmX-0004tk-RE for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 22:48:09 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20600.outbound.protection.outlook.com [2a01:111:f400:fe5b::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec76f6fe-d8ba-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 00:48:07 +0200 (CEST) Received: from CY5PR22CA0056.namprd22.prod.outlook.com (2603:10b6:930:1d::19) by PH0PR12MB5466.namprd12.prod.outlook.com (2603:10b6:510:d7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 22:48:03 +0000 Received: from CY4PEPF0000C976.namprd02.prod.outlook.com (2603:10b6:930:1d:cafe::27) by CY5PR22CA0056.outlook.office365.com (2603:10b6:930:1d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Tue, 11 Apr 2023 22:48:03 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C976.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.25 via Frontend Transport; Tue, 11 Apr 2023 22:48:03 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:02 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 11 Apr 2023 17:48:02 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 11 Apr 2023 17:48:01 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec76f6fe-d8ba-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DUrpHrhygylW65EIGNgcYhyexOOetItaPx0tXwn+r1Nhk2FpPQfqu+wT7GLbIDCkLUooB3qcX0M3ECrdMMMOmZ6VIUgKwFjIw41vz0KdtGaEtxG/QyEncf0kPiN72WJ8PsNndKF/zUouoRasRKv94zAE3qCyiD8AldWPBZsHVAfVJ89rgp0WZUDye2T+5ggkZ/AwnvSTOhbPxwSnucIlipvrZmNZDVnvKajmVU/HlRYBPKCXb1JZSKhqDheqslKdPGXT3UMFa2e8KuvDUKdsD+0Rz2xd6uFxyaGWyP8iEnnIt8uqZabmccSZop2pFWWcUVGFWOqJ2vjaiSbJOzUHdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ceVVG2Mcqf7l56uhkCH1ot2RTwEnUox0BY709RE34rI=; b=Qn684BdjEZvJ2qQaif7WhfImqtNfnJV2pjMHN5aYYpd8f3CiJSok4OasgTjuHOx45u4+fZ0+3qmSamnOoW6Cq1lZ3M7CTr7VKkpeEboo8DzN7rKbNIV8tnmb+z+O9/ucZHHmS8/RGu8+mCH8LMrfNy3onLGbn7alWwDPSgoJ8zQ+RNfHLdWIOKoLSYAJUsuakiR22HZJgX/CH36IdFAbErvE/OHkbWmtUwhsP4daIKXqJRJO6dmskfWArK2zQYHRULKSc7eU6mEHK/B2nJJHhw7YfpzcG+HIAfQOtlY+7PT1ILpeymje1IwE85vp361OCsrnmCzKgyesK5oFIm6iZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ceVVG2Mcqf7l56uhkCH1ot2RTwEnUox0BY709RE34rI=; b=hgJQ6e907CCExPV87MF+D+1190Op0Xb+Q2JFOCxPezvgsR6a1pWlFqpYv9yJxvzwuuHJ5kfQ15QfpkqR0Rw6nCyNn4jHST4+j6HNtkS4MWcVKH5T90nxrK4/rO6Uo1xaXvv2BvALEjdgC0esMBHdaYl0cHudKDsPldu6mbUZEQI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Peter Maydell , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:ARM TCG CPUs" Subject: [QEMU][PATCH v6 09/10] hw/arm: introduce xenpvh machine Date: Tue, 11 Apr 2023 15:47:45 -0700 Message-ID: <20230411224746.16152-10-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230411224746.16152-1-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C976:EE_|PH0PR12MB5466:EE_ X-MS-Office365-Filtering-Correlation-Id: 24af51b0-eff8-4248-c079-08db3adecee9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i09bwLH20tj3WrE9gVcw90DTYx5/l0lmcMzwmQpsrfurGGhp+OmvxAqeFWBVHKru5GREPdyinfiS/p1aG0tNvqwD98tPWc3fH9lGAJrxt9QR3WH85jnx8/WWdvHSDGPxY1UviGzQVgnbThKIPefslBeNH2LAFl7rFPQMWblOXb24G1aOiTguVMA+JmOf4AI0YW2lDJq3Cd4W6OoplP5jRZPEqWZc5UFD1bK23+7jWee0rREmxGnXEk+28lL3nYyRBbfR6V6amvcsz9JN/JDeoErpIvB7SDHvEobRNf8g8vpryiEtzI/aZXp9snpSUiSbza37VDL7yc01tW6OMh0c0QZmA82k+8btSWW31XBjDtEke729ZpwmnVL2DhHJtX2niGfGXiqmdq3BXugoREEsbrqBYhBkKRPaSnoDL4VBmu+xQA8dVrfI47zKmfoPg/pi0/oHm1MFsPq0qmqQNsbCbD9+Ks6eXL3u4UmSYdBCNmzrSvCVDfblo7Jqt/lYsFqpmGnytrgQqoPfG2N3ms2I/tz1TwdyDYgk/kEyEmDOdQfgtuWnqkIFn9L/PzNUKIaBcKpXzCw3HCwJ/gVcyjod55jv3A7QUrEbZnKz2toBHAuatC4JMSwQpDJwUEKvjZpXrd8Q3eSbpt56CGEupPSbLEt5HD09vqDnQY8gp1x1psKHuv17qCN3PiGXQ4Nf6YXP0UUSX8Om62ljVl+xcWQ8ZVwXccnpe7rAGs72jZ6pYFw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199021)(36840700001)(46966006)(40470700004)(6666004)(8936002)(66899021)(40480700001)(44832011)(40460700003)(966005)(5660300002)(86362001)(70206006)(70586007)(8676002)(6916009)(4326008)(478600001)(82310400005)(82740400003)(356005)(54906003)(36860700001)(81166007)(2906002)(83380400001)(1076003)(186003)(2616005)(336012)(47076005)(426003)(316002)(41300700001)(36756003)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 22:48:03.0539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24af51b0-eff8-4248-c079-08db3adecee9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C976.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5466 Add a new machine xenpvh which creates a IOREQ server to register/connect with Xen Hypervisor. Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a TPM emulator and connects to swtpm running on host machine via chardev socket and support TPM functionalities for a guest domain. Extra command line for aarch64 xenpvh QEMU to connect to swtpm: -chardev socket,id=chrtpm,path=/tmp/myvtpm2/swtpm-sock \ -tpmdev emulator,id=tpm0,chardev=chrtpm \ -machine tpm-base-addr=0x0c000000 \ swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on libtpms and provides access to TPM functionality over socket, chardev and CUSE interface. Github repo: https://github.com/stefanberger/swtpm Example for starting swtpm on host machine: mkdir /tmp/vtpm2 swtpm socket --tpmstate dir=/tmp/vtpm2 \ --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock & Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- docs/system/arm/xenpvh.rst | 34 +++++++ docs/system/target-arm.rst | 1 + hw/arm/meson.build | 2 + hw/arm/xen_arm.c | 181 ++++++++++++++++++++++++++++++++++ include/hw/arm/xen_arch_hvm.h | 9 ++ include/hw/xen/arch_hvm.h | 2 + 6 files changed, 229 insertions(+) create mode 100644 docs/system/arm/xenpvh.rst create mode 100644 hw/arm/xen_arm.c create mode 100644 include/hw/arm/xen_arch_hvm.h diff --git a/docs/system/arm/xenpvh.rst b/docs/system/arm/xenpvh.rst new file mode 100644 index 0000000000..e1655c7ab8 --- /dev/null +++ b/docs/system/arm/xenpvh.rst @@ -0,0 +1,34 @@ +XENPVH (``xenpvh``) +========================================= +This machine creates a IOREQ server to register/connect with Xen Hypervisor. + +When TPM is enabled, this machine also creates a tpm-tis-device at a user input +tpm base address, adds a TPM emulator and connects to a swtpm application +running on host machine via chardev socket. This enables xenpvh to support TPM +functionalities for a guest domain. + +More information about TPM use and installing swtpm linux application can be +found at: docs/specs/tpm.rst. + +Example for starting swtpm on host machine: +.. code-block:: console + + mkdir /tmp/vtpm2 + swtpm socket --tpmstate dir=/tmp/vtpm2 \ + --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock & + +Sample QEMU xenpvh commands for running and connecting with Xen: +.. code-block:: console + + qemu-system-aarch64 -xen-domid 1 \ + -chardev socket,id=libxl-cmd,path=qmp-libxl-1,server=on,wait=off \ + -mon chardev=libxl-cmd,mode=control \ + -chardev socket,id=libxenstat-cmd,path=qmp-libxenstat-1,server=on,wait=off \ + -mon chardev=libxenstat-cmd,mode=control \ + -xen-attach -name guest0 -vnc none -display none -nographic \ + -machine xenpvh -m 1301 \ + -chardev socket,id=chrtpm,path=tmp/vtpm2/swtpm-sock \ + -tpmdev emulator,id=tpm0,chardev=chrtpm -machine tpm-base-addr=0x0C000000 + +In above QEMU command, last two lines are for connecting xenpvh QEMU to swtpm +via chardev socket. diff --git a/docs/system/target-arm.rst b/docs/system/target-arm.rst index 91ebc26c6d..af8d7c77d6 100644 --- a/docs/system/target-arm.rst +++ b/docs/system/target-arm.rst @@ -106,6 +106,7 @@ undocumented; you can get a complete list by running arm/stm32 arm/virt arm/xlnx-versal-virt + arm/xenpvh Emulated CPU architecture support ================================= diff --git a/hw/arm/meson.build b/hw/arm/meson.build index b545ba0e4f..1b2a01a005 100644 --- a/hw/arm/meson.build +++ b/hw/arm/meson.build @@ -62,6 +62,8 @@ arm_ss.add(when: 'CONFIG_FSL_IMX7', if_true: files('fsl-imx7.c', 'mcimx7d-sabre. arm_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmuv3.c')) arm_ss.add(when: 'CONFIG_FSL_IMX6UL', if_true: files('fsl-imx6ul.c', 'mcimx6ul-evk.c')) arm_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_soc.c')) +arm_ss.add(when: 'CONFIG_XEN', if_true: files('xen_arm.c')) +arm_ss.add_all(xen_ss) softmmu_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmu-common.c')) softmmu_ss.add(when: 'CONFIG_EXYNOS4', if_true: files('exynos4_boards.c')) diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c new file mode 100644 index 0000000000..19b1cb81ad --- /dev/null +++ b/hw/arm/xen_arm.c @@ -0,0 +1,181 @@ +/* + * QEMU ARM Xen PVH Machine + * + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ + +#include "qemu/osdep.h" +#include "qemu/error-report.h" +#include "qapi/qapi-commands-migration.h" +#include "qapi/visitor.h" +#include "hw/boards.h" +#include "hw/sysbus.h" +#include "sysemu/block-backend.h" +#include "sysemu/tpm_backend.h" +#include "sysemu/sysemu.h" +#include "hw/xen/xen-hvm-common.h" +#include "sysemu/tpm.h" +#include "hw/xen/arch_hvm.h" + +#define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh") +OBJECT_DECLARE_SIMPLE_TYPE(XenArmState, XEN_ARM) + +static MemoryListener xen_memory_listener = { + .region_add = xen_region_add, + .region_del = xen_region_del, + .log_start = NULL, + .log_stop = NULL, + .log_sync = NULL, + .log_global_start = NULL, + .log_global_stop = NULL, + .priority = 10, +}; + +struct XenArmState { + /*< private >*/ + MachineState parent; + + XenIOState *state; + + struct { + uint64_t tpm_base_addr; + } cfg; +}; + +void arch_handle_ioreq(XenIOState *state, ioreq_t *req) +{ + hw_error("Invalid ioreq type 0x%x\n", req->type); + + return; +} + +void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section, + bool add) +{ +} + +void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length) +{ +} + +void qmp_xen_set_global_dirty_log(bool enable, Error **errp) +{ +} + +#ifdef CONFIG_TPM +static void xen_enable_tpm(XenArmState *xam) +{ + Error *errp = NULL; + DeviceState *dev; + SysBusDevice *busdev; + + TPMBackend *be = qemu_find_tpm_be("tpm0"); + if (be == NULL) { + DPRINTF("Couldn't fine the backend for tpm0\n"); + return; + } + dev = qdev_new(TYPE_TPM_TIS_SYSBUS); + object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp); + object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp); + busdev = SYS_BUS_DEVICE(dev); + sysbus_realize_and_unref(busdev, &error_fatal); + sysbus_mmio_map(busdev, 0, xam->cfg.tpm_base_addr); + + DPRINTF("Connected tpmdev at address 0x%lx\n", xam->cfg.tpm_base_addr); +} +#endif + +static void xen_arm_init(MachineState *machine) +{ + XenArmState *xam = XEN_ARM(machine); + + xam->state = g_new0(XenIOState, 1); + + xen_register_ioreq(xam->state, machine->smp.cpus, xen_memory_listener); + +#ifdef CONFIG_TPM + if (xam->cfg.tpm_base_addr) { + xen_enable_tpm(xam); + } else { + DPRINTF("tpm-base-addr is not provided. TPM will not be enabled\n"); + } +#endif +} + +#ifdef CONFIG_TPM +static void xen_arm_get_tpm_base_addr(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + XenArmState *xam = XEN_ARM(obj); + uint64_t value = xam->cfg.tpm_base_addr; + + visit_type_uint64(v, name, &value, errp); +} + +static void xen_arm_set_tpm_base_addr(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + XenArmState *xam = XEN_ARM(obj); + uint64_t value; + + if (!visit_type_uint64(v, name, &value, errp)) { + return; + } + + xam->cfg.tpm_base_addr = value; +} +#endif + +static void xen_arm_machine_class_init(ObjectClass *oc, void *data) +{ + + MachineClass *mc = MACHINE_CLASS(oc); + mc->desc = "Xen Para-virtualized PC"; + mc->init = xen_arm_init; + mc->max_cpus = 1; + mc->default_machine_opts = "accel=xen"; + +#ifdef CONFIG_TPM + object_class_property_add(oc, "tpm-base-addr", "uint64_t", + xen_arm_get_tpm_base_addr, + xen_arm_set_tpm_base_addr, + NULL, NULL); + object_class_property_set_description(oc, "tpm-base-addr", + "Set Base address for TPM device."); + + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS); +#endif +} + +static const TypeInfo xen_arm_machine_type = { + .name = TYPE_XEN_ARM, + .parent = TYPE_MACHINE, + .class_init = xen_arm_machine_class_init, + .instance_size = sizeof(XenArmState), +}; + +static void xen_arm_machine_register_types(void) +{ + type_register_static(&xen_arm_machine_type); +} + +type_init(xen_arm_machine_register_types) diff --git a/include/hw/arm/xen_arch_hvm.h b/include/hw/arm/xen_arch_hvm.h new file mode 100644 index 0000000000..8fd645e723 --- /dev/null +++ b/include/hw/arm/xen_arch_hvm.h @@ -0,0 +1,9 @@ +#ifndef HW_XEN_ARCH_ARM_HVM_H +#define HW_XEN_ARCH_ARM_HVM_H + +#include +void arch_handle_ioreq(XenIOState *state, ioreq_t *req); +void arch_xen_set_memory(XenIOState *state, + MemoryRegionSection *section, + bool add); +#endif diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h index 26674648d8..c7c515220d 100644 --- a/include/hw/xen/arch_hvm.h +++ b/include/hw/xen/arch_hvm.h @@ -1,3 +1,5 @@ #if defined(TARGET_I386) || defined(TARGET_X86_64) #include "hw/i386/xen_arch_hvm.h" +#elif defined(TARGET_ARM) || defined(TARGET_ARM_64) +#include "hw/arm/xen_arch_hvm.h" #endif -- 2.17.0 From xen-devel-bounces@lists.xenproject.org Tue Apr 11 23:41:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Apr 2023 23:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520019.807210 (Exim 4.92) (envelope-from ) id 1pmNc9-0008QG-1W; Tue, 11 Apr 2023 23:41:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520019.807210; Tue, 11 Apr 2023 23:41:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmNc8-0008Q9-Ut; Tue, 11 Apr 2023 23:41:28 +0000 Received: by outflank-mailman (input) for mailman id 520019; Tue, 11 Apr 2023 23:41:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmNc6-0008Q0-H5 for xen-devel@lists.xenproject.org; Tue, 11 Apr 2023 23:41:27 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c478059-d8c2-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 01:41:21 +0200 (CEST) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33BJgr56026489; Tue, 11 Apr 2023 23:41:10 GMT Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3pw43vtrb2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2023 23:41:10 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by DBAPR03MB6358.eurprd03.prod.outlook.com (2603:10a6:10:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 23:41:05 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3%3]) with mapi id 15.20.6277.034; Tue, 11 Apr 2023 23:41:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c478059-d8c2-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VSl54BxMIS/LRC689wNJe0FViLOMWlQrZSgRWINqjENzjdgda+8VVWBXYB1D05VIaHeXPqOiNOv6BVmb+jfSiCKhiPB3JkWzQJwBdg4//lhZwHMuAlGbEaVUW4xjuFSr2crBCYf08Ms9b7lYZNYzbrXZHTAu614QPjV8+mw617DWZ98h5dr8r5HoHR3FawmcRWSjW389Hh9hEakB3kWAG9JCZ8viNzGRySTULPpMtfR2mrL2SgRCh5k1zjI0ZOrMjeROxDbk/hh1jcG0PXpR+QQd//wySgbA1GX3ohtzVgMbb3Bx8YVLJHSASEbdQeepzsF8YFaBjlngxgWXA54t1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eJtZlAWsizs0bUKr7ZMUM4O/+fMTn+dea7fKlJpYbe8=; b=e7P8mSSe41Yli0AZg94xUeIA2YW5jn9Pr09MdqiZ9umAjIoR+QjZww5r0trn/0HHlton1OhQn0FDiOaXcvANHQEiTE7SMaqsZEaWjVz8ZYraOVcKbFg9FXlHl+LMB6Bkl6ZqfIIl9SBVdF79pPiXl2WHrt9GUvKVZ5wOuPA9hsTpaiM/Ys3iobgt1SLcGBAJfc1OTJtbF3+3QBN5XNzNurnSMxx1k3XUgtb5TdI1SC9fmB04faDu2qa8N5xYWWpQnjydOmvXiSjDlzyl75vquHX115AJHvgzs5xd57Ius7RgEre2jUUcxhRfsYTHRyZcIoyI3ZoSjupO90aYUttbBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJtZlAWsizs0bUKr7ZMUM4O/+fMTn+dea7fKlJpYbe8=; b=YCOfc03JAQPWs9wTvWOms9KkZIxL5WkWBEqjXvu8+lHVc1K5YLygo69vpMPsw67NLQLL8KhHUYDsy32ou3Pnks02fVYPClcpK3+05kq+hekDGWKXAa6EbVwdasPBlxctyenjZexjTo2QhcgqqL8aGRO32WAgis8IKP9nj9jee/3V3ewEZm1Ce1Q2NpSkLL8ERazoN+he4je5RB8eMTp0mcgvD8Iyk2WUGu+g0zYWYL0AUBKBCywUnUVN6fJSSnvlKfT6I+ctdJXCds8479T+rXFYWmHv3YqsIkHrp0Y9R3hPsV38410DtB4rLebDK7YnB7gLdxMqhSxWpUjQnKKbpg== From: Volodymyr Babchuk To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: "xen-devel@lists.xenproject.org" , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Kevin Tian Subject: Re: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Thread-Topic: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Thread-Index: AQHZVrdzsdckomMx4kauxHkZQ597Iq79mAMAgClI2AA= Date: Tue, 11 Apr 2023 23:41:04 +0000 Message-ID: <873556xa0g.fsf@epam.com> References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-3-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|DBAPR03MB6358:EE_ x-ms-office365-filtering-correlation-id: 26f9804a-65d3-41e3-06ad-08db3ae6371c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fiQFJWj8fiZOVY/B9QisSu4HHIiMIthYCtm051MNdLAnstyX3OtSK5V5InQtzlbCq+eqIqOyFPU8XVBKmXa1BDtbK8He+uOHQxANrFSIsSSzOeeXSDcdD3lPjd9epb+qo6uX0sx++VsJFh02TTrZNOvYCdBOU22iFDUNnfo7nnQe5/NYIINsz/AsPZJbGhL0QS+d6I3t85by7Cmx7QF6CiRLcphzFE+NFfErRVhpTF+lHA1aEXxYnc5YvorOJBMXfFZiitEvmRA90N2nMiWnL+jXyGGJM1B5HJZ4ZPHOV7wnZkQe8gzIg2cugNQmCIQlIw8AB8bBrB7mNNIu1wAQSEVgGLYCwkb5ITgL+fcGtewIq5NWnDYCD/WI7YdGIVWSr+PbtqSQnQvQJam/V/1TfXP880vXOYMkwtq58vUagdistt1cxg++a/squlwMlgOGNhrbBjCKCLcNoVhfPTncM2dwfQ8GNiWe7Ry0mhqaGyO0zNzBpSivBK4TO8FXGbwsIw6/XekVLDRgmlG6RKtNflUlmNxMqUMvh1kk61XEoJPOWaHaKFxcUDd6ljaV0sljyPE30M1LFnBIhTtJedUqjkf7G1Gs6ypSVh1mzx1Kpi0FgWkWwbuWirdjnUFkolSCpWmYTS1NePC00GXOiXf6pg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199021)(2906002)(38100700002)(7416002)(6486002)(5660300002)(122000001)(30864003)(71200400001)(38070700005)(83380400001)(8936002)(55236004)(6506007)(6512007)(41300700001)(26005)(2616005)(66476007)(6916009)(66946007)(66446008)(76116006)(66556008)(86362001)(91956017)(4326008)(186003)(316002)(8676002)(64756008)(36756003)(54906003)(478600001)(21314003)(559001)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Mkp3c0dvMWtyVVhhZU9hRkJvSzZyMkxyZlFuU21KL2cvZUM4SEZqMWI5S2ww?= =?utf-8?B?cktJKzN3WmlNY2VVdVlIUEtsVFFOalA0NndmL1RKNXhsam5UZGFtb3BNNjZB?= =?utf-8?B?b0NBZTN1aWRQV0x1d01aczdMRnc3VmQzeU1XSXBpZHNFOHBjUEF0UmgyVlQz?= =?utf-8?B?M3d2eFRQaktJeGFXNHpUbXJnS1UvSDlDM05wZFNVaDB6V0pFWVFoQktCa1lo?= =?utf-8?B?MmpYRWxiVHB2cHVWNzN0M2NSQmsydkMxYitlZG1WOWdTRVYxeU5udktVTm1v?= =?utf-8?B?SzhtVzhYRTFwRHNmUXlIZWwyQlpXTVN6cUJaay9QdFJHeGNMMEs2Uk9aL0FH?= =?utf-8?B?U3U3U2NjNUR0M0NFYlBVQ2FCYWRMZ1JYZ3VCYUFkY1l2TjdJMGQzYWFUWEdU?= =?utf-8?B?SHFHNHZDc3ZLYk54b1BHRGl4Ymc2UUlLaXM2UU9ERmRLdEsxQ3BDNFE0Uk5t?= =?utf-8?B?LzhxR05tLzNNQjRVYUZEdVhXcDkwZ0pPRzNLQTZtMWlVemFZbzBpb1hXNkto?= =?utf-8?B?T20zZERtZjFrNHVUTy84YnNnVkVUaGZzbkFkSjl2VjhHc1ZQYktyWk5QZjBZ?= =?utf-8?B?TFZqYnliMUU4NjRlUk41S0lZclV5a1VvTUk1b1JscGk3bUZucHoxbGFzK1ZZ?= =?utf-8?B?OWdkSTkyZVlDNU9IZGdOd1BHeE9WTFNpYkRCQ250eUwwelZrOFNhVTdPUzRD?= =?utf-8?B?eWJQcEdIRnpyTFpQRDJxRUFjTFVLNUpGUU1lc2Rsck1LQXIvQmJHV1ZoNEw0?= =?utf-8?B?SktYa3RYUlN6ZGVyOGROeGJLYWpMcmhmbmgvMFAxd1JWYms0N0lBQUxMNGY2?= =?utf-8?B?SVNSZ1ROTjJraW1sOXo2VUk3R3IwK0xZVGw2YVBsSDBob2huNmJZRFdTb1hk?= =?utf-8?B?SVNiVXhpVWZrYktEeXNWdUFPc2lqU2prRTRXZkh2UnlZWW5zd3U0WFBoR3VL?= =?utf-8?B?Q3p5RnJUajUzNUhNRG1EdHhXa0tsdzZubGVTMDgrUmJCbUV2VWFTTU9iSHU4?= =?utf-8?B?N21JdC9RZk1oMGwyS3JLZUtDbHQ0SnB6SGh6dS8vZHh0SXgxRGZZUzUrRXRU?= =?utf-8?B?N1ZaN2laVTgwUzAzS2NXWkNZQ3ZYWktQY09KLzFWZTE5R1Q2aUJ1OUlldkFk?= =?utf-8?B?emNzZzUvaWpPdjlKVWVpTjJCZHEyTVZicHZCNVdMbmg4bkF0bllmQkczQ2t1?= =?utf-8?B?Q2NnTkl0UGx4MTVvUHBKSjVqa0VINHZqYjdvTVpyYU1VKzVUZkZLWjZRcDJr?= =?utf-8?B?MVMvaHpMekhQR0FTeXg0dkVvYStTMjV1T2NXOXhFTGJnbFY1a2lOWEVlY2pS?= =?utf-8?B?cVJuQm9TMEF2aDd1ZnZhRHNjejRKWjdzN0g1TllTTzQ0SVF3MzJJSG1MdHFR?= =?utf-8?B?NTk4UlFWbm5mTmZEc2lIek5tSzRhMEIyNlo1a21XK2p5TWMzZ2ZFdnRnZWZk?= =?utf-8?B?Y0dUTWYzakxNeE8rT0dpaDNUYzNEMFBDS2sxY2FUb3QyVEJ3YjRRMmhJUHRw?= =?utf-8?B?U01HbjNMSWsraDVZaDRqMXRmdFpnOWdmUVVnZVB3TVpDdEFkYmYyQ0tMVU1x?= =?utf-8?B?UkJRTWJLcW9Ja0NvbUcxQTlESk1OcWMySGhCcWQ1MHhXZlJ4WkdFMkw0cm16?= =?utf-8?B?MkN0OGI3ZFhhRVVVL3FjT0lsdUMxSy9hSk9DZE9BcFZnZVE4Q1c2Q3Vxa2xn?= =?utf-8?B?MUFpM3VWMGtqemNWQTRQYmdSSThxNHNZNzNKenVvejViNDA5RGRwZHBWUnNF?= =?utf-8?B?aXA0UEtZMGlMWjc3QnB3d25XWVprZHAxeUg2VGJUcm5rZ0FRd3VaV0laWnNE?= =?utf-8?B?TENrOXdYSHMvY3BLWTF1NXlMVUdzU0xIR3p2eXY0Y3lyMkNFL1VGRmtmWldN?= =?utf-8?B?NjhjbEsvZFNRbENHNWFVQm1iZlgwWkttZW5qWjhUTWlCM2x4anBaTm8rTzln?= =?utf-8?B?U0xReFhvVHBWcFhPdVdaQnFRUHRSYS9JRzIwdWY4aWtNa3E0V2EyZWxNV0dS?= =?utf-8?B?TC82NmthR0pCalE3SkFEd3ZzamhldVV0QVM5MkNXT0FjWFMrakxvamc4ejhZ?= =?utf-8?B?VDBrYjgyRWw4WUxRU21CSjZ5MjNYVGprMDNnbjRkcC83US9ib245dDZJd0pU?= =?utf-8?B?c0N3NFQrQkM4Wk82aGhKZ05vbko5Q05heXRvTk0zTzF2L2xtNVJZRGNZVVAv?= =?utf-8?B?Q3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26f9804a-65d3-41e3-06ad-08db3ae6371c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 23:41:04.3932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NZbzsBNY+3WSfna+FKgdlfrADCnTo0bsqNYdZR5jTixlnV+SoKW6ch46HSupSBuaXHffqruAZae0oSkNrZYy4vqEdKBH81lVzl+nIKRXCOQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR03MB6358 X-Proofpoint-ORIG-GUID: NBWx1qpd7oTfHIlgL1c21heI70KuBW85 X-Proofpoint-GUID: NBWx1qpd7oTfHIlgL1c21heI70KuBW85 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-11_16,2023-04-11_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304110213 DQpIaSBSb2dlciwNCg0KUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdy aXRlczoNCg0KPiBPbiBUdWUsIE1hciAxNCwgMjAyMyBhdCAwODo1NjoyOVBNICswMDAwLCBWb2xv ZHlteXIgQmFiY2h1ayB3cm90ZToNCj4+IFByaW9yIHRvIHRoaXMgY2hhbmdlLCBsaWZldGltZSBv ZiBwY2lfZGV2IG9iamVjdHMgd2FzIHByb3RlY3RlZCBieSBnbG9iYWwNCj4+IHBjaWRldnNfbG9j aygpLiBMb25nLXRlcm0gcGxhbiBpcyB0byByZW1vdmUgdGhpcyBsb2csIHNvIHdlIG5lZWQgc29t ZQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBe IGxvY2sNCj4NCj4gSSB3b3VsZG4ndCBzYXkgcmVtb3ZlLCBhcyBvbmUgd2F5IG9yIGFub3RoZXIg d2UgbmVlZCBhIGxvY2sgdG8gcHJvdGVjdA0KPiBjb25jdXJyZW50IGFjY2Vzc2VzLg0KPg0KDQpJ J2xsIHdyaXRlICJyZXBsYWNlIHRoaXMgZ2xvYmFsIGxvY2sgd2l0aCBjb3VwbGUgb2YgbW9yZSBn cmFudWxhcg0KbG9ja2luZyBkZXZpY2VzIg0KaWYgdGhpcyBpcyBva2F5IGZvciB5b3UuDQoNCj4+ IG90aGVyIG1lY2hhbmlzbSB0byBlbnN1cmUgdGhhdCB0aG9zZSBvYmplY3RzIHdpbGwgbm90IGRp c2FwcGVhciB1bmRlcg0KPj4gZmVldCBvZiBjb2RlIHRoYXQgYWNjZXNzIHRoZW0uIFJlZmVyZW5j ZSBjb3VudGluZyBpcyBhIGdvb2QgY2hvaWNlIGFzDQo+PiBpdCBwcm92aWRlcyBlYXN5IHRvIGNv bXByZWhlbmQgd2F5IHRvIGNvbnRyb2wgb2JqZWN0IGxpZmV0aW1lLg0KPj4gDQo+PiBUaGlzIHBh dGNoIGFkZHMgdHdvIG5ldyBoZWxwZXIgZnVuY3Rpb25zOiBwY2lkZXZfZ2V0KCkgYW5kDQo+PiBw Y2lkZXZfcHV0KCkuIHBjaWRldl9nZXQoKSB3aWxsIGluY3JlYXNlIHJlZmVyZW5jZSBjb3VudGVy LCB3aGlsZQ0KPj4gcGNpZGV2X3B1dCgpIHdpbGwgZGVjcmVhc2UgaXQsIGRlc3Ryb3lpbmcgb2Jq ZWN0IHdoZW4gY291bnRlciByZWFjaGVzDQo+PiB6ZXJvLg0KPj4gDQo+PiBwY2lkZXZfZ2V0KCkg c2hvdWxkIGJlIHVzZWQgb25seSB3aGVuIHlvdSBhbHJlYWR5IGhhdmUgYSB2YWxpZCBwb2ludGVy DQo+PiB0byB0aGUgb2JqZWN0IG9yIHlvdSBhcmUgaG9sZGluZyBsb2NrIHRoYXQgcHJvdGVjdHMg b25lIG9mIHRoZQ0KPj4gbGlzdHMgKGRvbWFpbiwgcHNlZyBvciBhdHMpIHRoYXQgc3RvcmUgcGNp X2RldiBzdHJ1Y3RzLg0KPj4gDQo+PiBwY2lkZXZfZ2V0KCkgaXMgcmFyZWx5IHVzZWQgZGlyZWN0 bHksIGJlY2F1c2UgdGhlcmUgYWxyZWFkeSBhcmUNCj4+IGZ1bmN0aW9ucyB0aGF0IHdpbGwgcHJv dmlkZSB2YWxpZCBwb2ludGVyIHRvIHBjaV9kZXYgc3RydWN0Og0KPj4gcGNpX2dldF9wZGV2KCks IHBjaV9nZXRfcmVhbF9wZGV2KCkuIFRoZXkgd2lsbCBsb2NrIGFwcHJvcHJpYXRlIGxpc3QsDQo+ PiBmaW5kIG5lZWRlZCBvYmplY3QgYW5kIGluY3JlYXNlIGl0cyByZWZlcmVuY2UgY291bnRlciBi ZWZvcmUgcmV0dXJuaW5nDQo+PiB0byB0aGUgY2FsbGVyLg0KPj4gDQo+PiBOYXR1cmFsbHksIHBj aV9wdXQoKSBzaG91bGQgYmUgY2FsbGVkIGFmdGVyIGZpbmlzaGluZyB3b3JraW5nIHdpdGggYQ0K Pj4gcmVjZWl2ZWQgb2JqZWN0LiBUaGlzIGlzIHRoZSByZWFzb24gd2h5IHRoaXMgcGF0Y2ggaGF2 ZSBzbyBtYW55DQo+PiBwY2lkZXZfcHV0KClzIGFuZCBzbyBsaXR0bGUgcGNpZGV2X2dldCgpczog ZXhpc3RpbmcgY2FsbHMgdG8NCj4+IHBjaV9nZXRfKigpIGZ1bmN0aW9ucyBub3cgd2lsbCBpbmNy ZWFzZSByZWZlcmVuY2UgY291bnRlcg0KPj4gYXV0b21hdGljYWxseSwgd2UganVzdCBuZWVkIHRv IGRlY3JlYXNlIGl0IGJhY2sgd2hlbiB3ZSBmaW5pc2hlZC4NCj4NCj4gQWZ0ZXIgbG9va2luZyBh IGJpdCBpbnRvIHRoaXMsIEkgd291bGQgbGlrZSB0byBhc2sgd2hldGhlciBpdCdzIGJlZW4NCj4g Y29uc2lkZXJlZCB0aGUgbmVlZCB0byBpbmNyZWFzZSB0aGUgcmVmY291bnQgZm9yIGVhY2ggdXNl IG9mIGEgcGRldi4NCj4NCg0KVGhpcyBpcyBob3cgTGludXggdXNlcyByZWZlcmVuY2UgbG9ja2lu Zy4gSXQgZGVjcmVhc2VzIGNvZ25pdGl2ZSBsb2FkDQphbmQgY2hhbmNlIGZvciBhbiBlcnJvciwg YXMgdGhlcmUgaXMgYSBzaW1wbGUgc2V0IG9mIHJ1bGVzLCB3aGljaCB5b3UNCmZvbGxvdy4NCg0K PiBGb3IgZXhhbXBsZSBJIHdvdWxkIGNvbnNpZGVyIHRoZSBpbml0aWFsIGFsbG9jX3BkZXYoKSB0 byB0YWtlIGENCj4gcmVmY291bnQsIGFuZCB0aGVuIHBjaV9yZW1vdmVfZGV2aWNlKCkgX211c3Rf IGJlIHRoZSBmdW5jdGlvbiB0aGF0DQo+IHJlbW92ZXMgdGhlIGxhc3QgcmVmY291bnQsIHNvIHRo YXQgaXQgY2FuIHJldHVybiAtRUJVU1kgb3RoZXJ3aXNlIChzZWUNCj4gbXkgY29tbWVudCBiZWxv dykuDQoNCkkgdGVuZCB0byBkaXNhZ3JlZSB0aGVyZSwgYXMgdGhpcyBydWlucyB0aGUgdmVyeSBp ZGVhIG9mIHJlZmVyZW5jZQ0KY291bnRpbmcuIFdlIGNhbid0IGtub3cgd2hvIGVsc2UgaG9sZHMg cmVmZXJlbmNlIHJpZ2h0IG5vdy4gT2theSwgd2UNCm1pZ2h0IGtub3csIGJ1dCB0aGlzIHJlcXVp cmVzIGFkZGl0aW9uYWwgbG9jayB0byBzZXJpYWxpemUNCmFjY2Vzc2VzLiBXaGljaCwgaW4gdHVy biwgbWFrZXMgcmVmY291bnQgdW4tbmVlZGVkLg0KDQo+DQo+IEkgd291bGQgYWxzbyB0aGluayB0 aGF0IGhhdmluZyB0aGUgZGV2aWNlIGFzc2lnbmVkIHRvIGEgZ3Vlc3Qgd2lsbCB0YWtlDQo+IGFu b3RoZXIgcmVmY291bnQsIGFuZCB0aGVuIGFueSB1c2FnZSBmcm9tIGZ1cnRoZXIgY2FsbGVycyAo aWU6IGxpa2UNCj4gdnBjaSkgd2lsbCBuZWVkIHNvbWUga2luZCBvZiBwcm90ZWN0aW9uIGZyb20g cHJldmVudGluZyB0aGUgZGV2aWNlDQo+IGZyb20gYmVpbmcgZGVhc3NpZ25lZCBmcm9tIGEgZG9t YWluIHdoaWxlIHZQQ0kgaGFuZGxlcnMgYXJlIHJ1bm5pbmcsDQo+IGFuZCB0aGUgY3VycmVudCBy ZWZjb3VudCB3b24ndCBoZWxwIHdpdGggdGhhdC4NCg0KWWVzLCBpZGVhIG9mIHRoaXMgcmVmY291 bnRpbmcgaXMgdG8gZW5zdXJlIHRoYXQgYSBwZGV2IG9iamVjdCBleGlzdHMgYXMgYW4NCnZhbGlk IG9iamVjdCBpbiBtZW1vcnkgaWYgd2UgYXJlIGhvbGRpbmcgYSBsb25nLXRlcm0gcG9pbnRlciB0 bw0KaXQuIEluZGVlZCwgdlBDSSBoYW5kbGVycyBzaG91bGQgdXNlIHNvbWUgb3RoZXIgbWVjaGFu aXNtIHRvIGVuc3VyZSB0aGF0DQpwZGV2IGlzIG5vdCBiZWluZyByZS1hc3NpZ25lZCB3aGlsZSBo YW5kbGVycyBhcmUgcnVubmluZy4gSSBiZWxpZXZlLA0KdGhpcyBpcyB0aGUgdGFzayBvZiB2cGNp LT5sb2NrLiBTaG91bGQgd2UgY2FsbA0KdnBjaV9yZW1vdmVfZGV2aWNlL3ZwY2lfYWRkX2hhbmRs ZXJzIGVhY2ggdGltZSB3ZSByZS1hc3NpZ24gYSBQQ0kgZGV2aWNlPw0KDQo+DQo+IFRoYXQgbWFr ZXMgbWUgd29uZGVyIGlmIGZvciBleGFtcGxlIGNhbGxlcnMgb2YgcGNpX2dldF9wZGV2KGQsIHNi ZGYpDQo+IGRvIG5lZWQgdG8gdGFrZSBhbiBleHRyYSByZWZjb3VudCwgYmVjYXVzZSBzdWNoIGFj Y2VzcyBpcyBhbHJlYWR5DQo+IHByb3RlY3RlZCBmcm9tIHRoZSBwZGV2IGdvaW5nIGF3YXkgYnkg dGhlIGZhY3QgdGhhdCB0aGUgZGV2aWNlIGlzDQo+IGFzc2lnbmVkIHRvIGEgZ3Vlc3QuICBCdXQg bWF5YmUgaXQncyB0b28gbXVjaCB3b3JrIHRvIHNlcGFyYXRlIHVzZXJzDQo+IG9mIHBjaV9nZXRf cGRldihkLCAuLi4pOyB2cyBwY2lfZ2V0X3BkZXYoTlVMTCwgLi4uKTsuDQo+DQo+IFRoZXJlJ3Mg YWxzbyBhIHdpbmRvdyB3aGVuIHRoZSByZWZjb3VudCBpcyBkcm9wcGVkIHRvIDAsIGFuZCB0aGUN Cj4gZGVzdHJ1Y3Rpb24gZnVuY3Rpb24gaXMgY2FsbGVkLCBidXQgYXQgdGhlIHNhbWUgdGltZSBh IGNvbmN1cnJlbnQNCj4gdGhyZWFkIGNvdWxkIGF0dGVtcHQgdG8gdGFrZSBhIHJlZmVyZW5jZSB0 byB0aGUgcGRldiBzdGlsbD8NCg0KTGFzdCBwY2lkZXZfcHV0KCkgd291bGQgYmUgY2FsbGVkIGJ5 IHBjaV9yZW1vdmVfZGV2aWNlKCksIGFmdGVyIHJlbW92aW5nDQppdCBmcm9tIGFsbCBsaXN0cy4g VGhpcyBzaG91bGQgcHJldmVudCBvdGhlciB0aHJlYWRzIGZyb20gb2J0YWluaW5nIGEgdmFsaWQN CnJlZmVyZW5jZSB0byB0aGUgcGRldi4NCg0KPg0KPj4gDQo+PiBUaGlzIHBhdGNoIHJlbW92ZXMg ImNvbnN0IiBxdWFsaWZpZXIgZnJvbSBzb21lIHBkZXYgcG9pbnRlcnMgYmVjYXVzZQ0KPj4gcGNp ZGV2X3B1dCgpIHRlY2huaWNhbGx5IGFsdGVycyB0aGUgY29udGVudHMgb2YgcGNpX2RldiBzdHJ1 Y3R1cmUuDQo+PiANCj4+IFNpZ25lZC1vZmYtYnk6IFZvbG9keW15ciBCYWJjaHVrIDx2b2xvZHlt eXJfYmFiY2h1a0BlcGFtLmNvbT4NCj4+IFN1Z2dlc3RlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPg0KPj4gDQo+PiAtLS0NCj4+IA0KPj4gdjM6DQo+PiAgLSBNb3ZlZCBpbiBm cm9tIGFub3RoZXIgcGF0Y2ggc2VyaWVzDQo+PiAgLSBGaXhlZCBjb2RlIGZvcm1hdHRpbmcgKHRh YnMgLT4gc3BhY2VzKQ0KPj4gIC0gUmVtb3ZlZCBlcnJvbmVvdXMgcGNpZGV2X3B1dCBpbiB2Z2Eu Yw0KPj4gIC0gQWRkZWQgbWlzc2luZyBwY2lkZXZfcHV0IGluIGNvdXBsZSBvZiBwbGFjZXMNCj4+ ICAtIHJlbW92ZWQgbWVudGlvbiBvZiBwY2lfZ2V0X3BkZXZfYnlfZG9tYWluKCkNCj4+IC0tLQ0K Pj4gIHhlbi9hcmNoL3g4Ni9odm0vdm1zaS5jICAgICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4+ ICB4ZW4vYXJjaC94ODYvaXJxLmMgICAgICAgICAgICAgICAgICAgICAgIHwgICA0ICsNCj4+ICB4 ZW4vYXJjaC94ODYvbXNpLmMgICAgICAgICAgICAgICAgICAgICAgIHwgIDQ0ICsrKysrKystDQo+ PiAgeGVuL2FyY2gveDg2L3BjaS5jICAgICAgICAgICAgICAgICAgICAgICB8ICAgMyArDQo+PiAg eGVuL2FyY2gveDg2L3BoeXNkZXYuYyAgICAgICAgICAgICAgICAgICB8ICAxNyArKy0NCj4+ICB4 ZW4vY29tbW9uL3N5c2N0bC5jICAgICAgICAgICAgICAgICAgICAgIHwgICA3ICstDQo+PiAgeGVu L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYyB8ICAxMiArLQ0KPj4gIHhlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYyAgfCAgIDYgKy0NCj4+ICB4ZW4vZHJp dmVycy9wYXNzdGhyb3VnaC9wY2kuYyAgICAgICAgICAgIHwgMTM4ICsrKysrKysrKysrKysrKy0t LS0tLS0tDQo+PiAgeGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3F1aXJrcy5jICAgICB8ICAg MiArDQo+PiAgeGVuL2RyaXZlcnMvdmlkZW8vdmdhLmMgICAgICAgICAgICAgICAgICB8ICAgNyAr LQ0KPj4gIHhlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jICAgICAgICAgICAgICAgICAgfCAgMTYgKyst DQo+PiAgeGVuL2luY2x1ZGUveGVuL3BjaS5oICAgICAgICAgICAgICAgICAgICB8ICAxOCArKysN Cj4+ICAxMyBmaWxlcyBjaGFuZ2VkLCAyMTUgaW5zZXJ0aW9ucygrKSwgNjEgZGVsZXRpb25zKC0p DQo+PiANCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYyBiL3hlbi9hcmNo L3g4Ni9odm0vdm1zaS5jDQo+PiBpbmRleCAzY2Q0OTIzMDYwLi44YzNkNjczODcyIDEwMDY0NA0K Pj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92bXNpLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9o dm0vdm1zaS5jDQo+PiBAQCAtOTE0LDcgKzkxNCw3IEBAIGludCB2cGNpX21zaXhfYXJjaF9wcmlu dChjb25zdCBzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4KQ0KPj4gIA0KPj4gICAgICAgICAgICAgIHNw aW5fdW5sb2NrKCZtc2l4LT5wZGV2LT52cGNpLT5sb2NrKTsNCj4+ICAgICAgICAgICAgICBwcm9j ZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+IC0gICAgICAgICAgICAvKiBOQjogd2UgYXNzdW1l IHRoYXQgcGRldiBjYW5ub3QgZ28gYXdheSBmb3IgYW4gYWxpdmUgZG9tYWluLiAqLw0KPj4gKw0K Pj4gICAgICAgICAgICAgIGlmICggIXBkZXYtPnZwY2kgfHwgIXNwaW5fdHJ5bG9jaygmcGRldi0+ dnBjaS0+bG9jaykgKQ0KPj4gICAgICAgICAgICAgICAgICByZXR1cm4gLUVCVVNZOw0KPj4gICAg ICAgICAgICAgIGlmICggcGRldi0+dnBjaS0+bXNpeCAhPSBtc2l4ICkNCj4+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC94ODYvaXJxLmMgYi94ZW4vYXJjaC94ODYvaXJxLmMNCj4+IGluZGV4IDIwMTUw YjFjN2YuLjg3NDY0ZDgyYzggMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaXJxLmMNCj4+ ICsrKyBiL3hlbi9hcmNoL3g4Ni9pcnEuYw0KPj4gQEAgLTIxNzUsNiArMjE3NSw3IEBAIGludCBt YXBfZG9tYWluX3BpcnEoDQo+PiAgICAgICAgICAgICAgICAgIG1zaS0+ZW50cnlfbnIgPSByZXQ7 DQo+PiAgICAgICAgICAgICAgICAgIHJldCA9IC1FTkZJTEU7DQo+PiAgICAgICAgICAgICAgfQ0K Pj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgICAgICAgICAgZ290byBk b25lOw0KPj4gICAgICAgICAgfQ0KPj4gIA0KPj4gQEAgLTIxODksNiArMjE5MCw3IEBAIGludCBt YXBfZG9tYWluX3BpcnEoDQo+PiAgICAgICAgICAgICAgbXNpX2Rlc2MtPmlycSA9IC0xOw0KPj4g ICAgICAgICAgICAgIG1zaV9mcmVlX2lycShtc2lfZGVzYyk7DQo+PiAgICAgICAgICAgICAgcmV0 ID0gLUVCVVNZOw0KPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgICAg ICAgICAgZ290byBkb25lOw0KPj4gICAgICAgICAgfQ0KPj4gIA0KPj4gQEAgLTIyNzMsMTAgKzIy NzUsMTIgQEAgaW50IG1hcF9kb21haW5fcGlycSgNCj4+ICAgICAgICAgICAgICB9DQo+PiAgICAg ICAgICAgICAgbXNpX2Rlc2MtPmlycSA9IC0xOw0KPj4gICAgICAgICAgICAgIG1zaV9mcmVlX2ly cShtc2lfZGVzYyk7DQo+PiArICAgICAgICAgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICAgICAg ICAgICAgICBnb3RvIGRvbmU7DQo+PiAgICAgICAgICB9DQo+PiAgDQo+PiAgICAgICAgICBzZXRf ZG9tYWluX2lycV9waXJxKGQsIGlycSwgaW5mbyk7DQo+PiArICAgICAgICBwY2lkZXZfcHV0KHBk ZXYpOw0KPj4gICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGVzYy0+bG9jaywgZmxh Z3MpOw0KPj4gICAgICB9DQo+PiAgICAgIGVsc2UNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvbXNpLmMgYi94ZW4vYXJjaC94ODYvbXNpLmMNCj4+IGluZGV4IGQwYmY2M2RmMWQuLjkxOTI2 ZmNlNTAgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvbXNpLmMNCj4+ICsrKyBiL3hlbi9h cmNoL3g4Ni9tc2kuYw0KPj4gQEAgLTU3Miw2ICs1NzIsMTAgQEAgaW50IG1zaV9mcmVlX2lycShz dHJ1Y3QgbXNpX2Rlc2MgKmVudHJ5KQ0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgIHZpcnRf dG9fZml4KCh1bnNpZ25lZCBsb25nKWVudHJ5LT5tYXNrX2Jhc2UpKTsNCj4+ICANCj4+ICAgICAg bGlzdF9kZWwoJmVudHJ5LT5saXN0KTsNCj4+ICsNCj4+ICsgICAgLyogQ29ycmVzcG9uZHMgdG8g cGNpZGV2X2dldCgpIGluIG1zaVt4XV9jYXBhYmlsaXR5X2luaXQoKSAgKi8NCj4+ICsgICAgcGNp ZGV2X3B1dChlbnRyeS0+ZGV2KTsNCj4+ICsNCj4+ICAgICAgeGZyZWUoZW50cnkpOw0KPj4gICAg ICByZXR1cm4gMDsNCj4+ICB9DQo+PiBAQCAtNjQ0LDYgKzY0OCw3IEBAIHN0YXRpYyBpbnQgbXNp X2NhcGFiaWxpdHlfaW5pdChzdHJ1Y3QgcGNpX2RldiAqZGV2LA0KPj4gICAgICAgICAgICAgIGVu dHJ5W2ldLm1zaS5tcG9zID0gbXBvczsNCj4+ICAgICAgICAgIGVudHJ5W2ldLm1zaS5udmVjID0g MDsNCj4+ICAgICAgICAgIGVudHJ5W2ldLmRldiA9IGRldjsNCj4+ICsgICAgICAgIHBjaWRldl9n ZXQoZGV2KTsNCj4+ICAgICAgfQ0KPj4gICAgICBlbnRyeS0+bXNpLm52ZWMgPSBudmVjOw0KPj4g ICAgICBlbnRyeS0+aXJxID0gaXJxOw0KPj4gQEAgLTcwMywyMiArNzA4LDM2IEBAIHN0YXRpYyB1 NjQgcmVhZF9wY2lfbWVtX2Jhcih1MTYgc2VnLCB1OCBidXMsIHU4IHNsb3QsIHU4IGZ1bmMsIHU4 IGJpciwgaW50IHZmKQ0KPj4gICAgICAgICAgICAgICAhbnVtX3ZmIHx8ICFvZmZzZXQgfHwgKG51 bV92ZiA+IDEgJiYgIXN0cmlkZSkgfHwNCj4+ICAgICAgICAgICAgICAgYmlyID49IFBDSV9TUklP Vl9OVU1fQkFSUyB8fA0KPj4gICAgICAgICAgICAgICAhcGRldi0+dmZfcmxlbltiaXJdICkNCj4+ ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAgICBpZiAoIHBkZXYgKQ0KPj4gKyAgICAgICAgICAg ICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPj4gICAgICAgICAgICAgIHJldHVybiAwOw0KPj4gKyAg ICAgICAgfQ0KPj4gICAgICAgICAgYmFzZSA9IHBvcyArIFBDSV9TUklPVl9CQVI7DQo+PiAgICAg ICAgICB2ZiAtPSBQQ0lfQkRGKGJ1cywgc2xvdCwgZnVuYykgKyBvZmZzZXQ7DQo+PiAgICAgICAg ICBpZiAoIHZmIDwgMCApDQo+PiArICAgICAgICB7DQo+PiArICAgICAgICAgICAgcGNpZGV2X3B1 dChwZGV2KTsNCj4+ICAgICAgICAgICAgICByZXR1cm4gMDsNCj4+ICsgICAgICAgIH0NCj4+ICAg ICAgICAgIGlmICggc3RyaWRlICkNCj4+ICAgICAgICAgIHsNCj4+ICAgICAgICAgICAgICBpZiAo IHZmICUgc3RyaWRlICkNCj4+ICsgICAgICAgICAgICB7DQo+PiArICAgICAgICAgICAgICAgIHBj aWRldl9wdXQocGRldik7DQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiAwOw0KPj4gKyAgICAg ICAgICAgIH0NCj4+ICAgICAgICAgICAgICB2ZiAvPSBzdHJpZGU7DQo+PiAgICAgICAgICB9DQo+ PiAgICAgICAgICBpZiAoIHZmID49IG51bV92ZiApDQo+PiArICAgICAgICB7DQo+PiArICAgICAg ICAgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICAgICAgICAgICAgICByZXR1cm4gMDsNCj4+ICsg ICAgICAgIH0NCj4+ICAgICAgICAgIEJVSUxEX0JVR19PTihBUlJBWV9TSVpFKHBkZXYtPnZmX3Js ZW4pICE9IFBDSV9TUklPVl9OVU1fQkFSUyk7DQo+PiAgICAgICAgICBkaXNwID0gdmYgKiBwZGV2 LT52Zl9ybGVuW2Jpcl07DQo+PiAgICAgICAgICBsaW1pdCA9IFBDSV9TUklPVl9OVU1fQkFSUzsN Cj4+ICsgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgIH0NCj4+ICAgICAgZWxzZSBz d2l0Y2ggKCBwY2lfY29uZl9yZWFkOChQQ0lfU0JERihzZWcsIGJ1cywgc2xvdCwgZnVuYyksDQo+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0hFQURFUl9UWVBFKSAmIDB4 N2YgKQ0KPj4gQEAgLTkyNSw2ICs5NDQsOCBAQCBzdGF0aWMgaW50IG1zaXhfY2FwYWJpbGl0eV9p bml0KHN0cnVjdCBwY2lfZGV2ICpkZXYsDQo+PiAgICAgICAgICBlbnRyeS0+ZGV2ID0gZGV2Ow0K Pj4gICAgICAgICAgZW50cnktPm1hc2tfYmFzZSA9IGJhc2U7DQo+PiAgDQo+PiArICAgICAgICBw Y2lkZXZfZ2V0KGRldik7DQo+PiArDQo+PiAgICAgICAgICBsaXN0X2FkZF90YWlsKCZlbnRyeS0+ bGlzdCwgJmRldi0+bXNpX2xpc3QpOw0KPj4gICAgICAgICAgKmRlc2MgPSBlbnRyeTsNCj4+ICAg ICAgfQ0KPj4gQEAgLTk5OSw2ICsxMDIwLDcgQEAgc3RhdGljIGludCBfX3BjaV9lbmFibGVfbXNp KHN0cnVjdCBtc2lfaW5mbyAqbXNpLCBzdHJ1Y3QgbXNpX2Rlc2MgKipkZXNjKQ0KPj4gIHsNCj4+ ICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiAgICAgIHN0cnVjdCBtc2lfZGVzYyAqb2xk X2Rlc2M7DQo+PiArICAgIGludCByZXQ7DQo+PiAgDQo+PiAgICAgIEFTU0VSVChwY2lkZXZzX2xv Y2tlZCgpKTsNCj4+ICAgICAgcGRldiA9IHBjaV9nZXRfcGRldihOVUxMLCBtc2ktPnNiZGYpOw0K Pj4gQEAgLTEwMTAsNiArMTAzMiw3IEBAIHN0YXRpYyBpbnQgX19wY2lfZW5hYmxlX21zaShzdHJ1 Y3QgbXNpX2luZm8gKm1zaSwgc3RydWN0IG1zaV9kZXNjICoqZGVzYykNCj4+ICAgICAgew0KPj4g ICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgImlycSAlZCBhbHJlYWR5IG1hcHBlZCB0byBNU0kg b24gJXBwXG4iLA0KPj4gICAgICAgICAgICAgICAgIG1zaS0+aXJxLCAmcGRldi0+c2JkZik7DQo+ PiArICAgICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPj4gICAgICAgICAgcmV0dXJuIC1FRVhJU1Q7 DQo+PiAgICAgIH0NCj4+ICANCj4+IEBAIC0xMDIwLDcgKzEwNDMsMTAgQEAgc3RhdGljIGludCBf X3BjaV9lbmFibGVfbXNpKHN0cnVjdCBtc2lfaW5mbyAqbXNpLCBzdHJ1Y3QgbXNpX2Rlc2MgKipk ZXNjKQ0KPj4gICAgICAgICAgX19wY2lfZGlzYWJsZV9tc2l4KG9sZF9kZXNjKTsNCj4+ICAgICAg fQ0KPj4gIA0KPj4gLSAgICByZXR1cm4gbXNpX2NhcGFiaWxpdHlfaW5pdChwZGV2LCBtc2ktPmly cSwgZGVzYywgbXNpLT5lbnRyeV9ucik7DQo+PiArICAgIHJldCA9IG1zaV9jYXBhYmlsaXR5X2lu aXQocGRldiwgbXNpLT5pcnEsIGRlc2MsIG1zaS0+ZW50cnlfbnIpOw0KPj4gKyAgICBwY2lkZXZf cHV0KHBkZXYpOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gcmV0Ow0KPj4gIH0NCj4+ICANCj4+ICBz dGF0aWMgdm9pZCBfX3BjaV9kaXNhYmxlX21zaShzdHJ1Y3QgbXNpX2Rlc2MgKmVudHJ5KQ0KPj4g QEAgLTEwNTQsMjAgKzEwODAsMjkgQEAgc3RhdGljIGludCBfX3BjaV9lbmFibGVfbXNpeChzdHJ1 Y3QgbXNpX2luZm8gKm1zaSwgc3RydWN0IG1zaV9kZXNjICoqZGVzYykNCj4+ICB7DQo+PiAgICAg IHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KPj4gICAgICBzdHJ1Y3QgbXNpX2Rlc2MgKm9sZF9kZXNj Ow0KPj4gKyAgICBpbnQgcmV0Ow0KPj4gIA0KPj4gICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQo KSk7DQo+PiAgICAgIHBkZXYgPSBwY2lfZ2V0X3BkZXYoTlVMTCwgbXNpLT5zYmRmKTsNCj4+ICAg ICAgaWYgKCAhcGRldiB8fCAhcGRldi0+bXNpeCApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGlm ICggcGRldiApDQo+PiArICAgICAgICAgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICAgICAgICAg IHJldHVybiAtRU5PREVWOw0KPj4gKyAgICB9DQo+PiAgDQo+PiAgICAgIGlmICggbXNpLT5lbnRy eV9uciA+PSBwZGV2LT5tc2l4LT5ucl9lbnRyaWVzICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAg cGNpZGV2X3B1dChwZGV2KTsNCj4+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gKyAgICB9 DQo+PiAgDQo+PiAgICAgIG9sZF9kZXNjID0gZmluZF9tc2lfZW50cnkocGRldiwgbXNpLT5pcnEs IFBDSV9DQVBfSURfTVNJWCk7DQo+PiAgICAgIGlmICggb2xkX2Rlc2MgKQ0KPj4gICAgICB7DQo+ PiAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiaXJxICVkIGFscmVhZHkgbWFwcGVkIHRvIE1T SS1YIG9uICVwcFxuIiwNCj4+ICAgICAgICAgICAgICAgICBtc2ktPmlycSwgJnBkZXYtPnNiZGYp Ow0KPj4gKyAgICAgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICAgICAgICAgIHJldHVybiAtRUVY SVNUOw0KPj4gICAgICB9DQo+PiAgDQo+PiBAQCAtMTA3OCw3ICsxMTEzLDExIEBAIHN0YXRpYyBp bnQgX19wY2lfZW5hYmxlX21zaXgoc3RydWN0IG1zaV9pbmZvICptc2ksIHN0cnVjdCBtc2lfZGVz YyAqKmRlc2MpDQo+PiAgICAgICAgICBfX3BjaV9kaXNhYmxlX21zaShvbGRfZGVzYyk7DQo+PiAg ICAgIH0NCj4+ICANCj4+IC0gICAgcmV0dXJuIG1zaXhfY2FwYWJpbGl0eV9pbml0KHBkZXYsIG1z aSwgZGVzYyk7DQo+PiArICAgIHJldCA9IG1zaXhfY2FwYWJpbGl0eV9pbml0KHBkZXYsIG1zaSwg ZGVzYyk7DQo+PiArDQo+PiArICAgIHBjaWRldl9wdXQocGRldik7DQo+PiArDQo+PiArICAgIHJl dHVybiByZXQ7DQo+PiAgfQ0KPj4gIA0KPj4gIHN0YXRpYyB2b2lkIF9wY2lfY2xlYW51cF9tc2l4 KHN0cnVjdCBhcmNoX21zaXggKm1zaXgpDQo+PiBAQCAtMTE1OSw2ICsxMTk4LDcgQEAgaW50IHBj aV9wcmVwYXJlX21zaXgodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgYm9vbCBvZmYpDQo+PiAg ICAgIH0NCj4+ICAgICAgZWxzZQ0KPj4gICAgICAgICAgcmMgPSBtc2l4X2NhcGFiaWxpdHlfaW5p dChwZGV2LCBOVUxMLCBOVUxMKTsNCj4+ICsgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICAgICAg cGNpZGV2c191bmxvY2soKTsNCj4+ICANCj4+ICAgICAgcmV0dXJuIHJjOw0KPj4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9wY2kuYyBiL3hlbi9hcmNoL3g4Ni9wY2kuYw0KPj4gaW5kZXggOTdi NzkyZTU3OC4uYzFmY2RmMDhkNiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9wY2kuYw0K Pj4gKysrIGIveGVuL2FyY2gveDg2L3BjaS5jDQo+PiBAQCAtOTIsNyArOTIsMTAgQEAgaW50IHBj aV9jb25mX3dyaXRlX2ludGVyY2VwdCh1bnNpZ25lZCBpbnQgc2VnLCB1bnNpZ25lZCBpbnQgYmRm LA0KPj4gIA0KPj4gICAgICBwZGV2ID0gcGNpX2dldF9wZGV2KE5VTEwsIFBDSV9TQkRGKHNlZywg YmRmKSk7DQo+PiAgICAgIGlmICggcGRldiApDQo+PiArICAgIHsNCj4+ICAgICAgICAgIHJjID0g cGNpX21zaV9jb25mX3dyaXRlX2ludGVyY2VwdChwZGV2LCByZWcsIHNpemUsIGRhdGEpOw0KPj4g KyAgICAgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICsgICAgfQ0KPj4gIA0KPj4gICAgICBwY2lk ZXZzX3VubG9jaygpOw0KPj4gIA0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9waHlzZGV2 LmMgYi94ZW4vYXJjaC94ODYvcGh5c2Rldi5jDQo+PiBpbmRleCAyZjFkOTU1YTk2Li45NjIxNGEz ZDQwIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gveDg2L3BoeXNkZXYuYw0KPj4gKysrIGIveGVu L2FyY2gveDg2L3BoeXNkZXYuYw0KPj4gQEAgLTUzMyw3ICs1MzMsMTQgQEAgcmV0X3QgZG9fcGh5 c2Rldl9vcChpbnQgY21kLCBYRU5fR1VFU1RfSEFORExFX1BBUkFNKHZvaWQpIGFyZykNCj4+ICAg ICAgICAgIHBjaWRldnNfbG9jaygpOw0KPj4gICAgICAgICAgcGRldiA9IHBjaV9nZXRfcGRldihO VUxMLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfU0JERigwLCByZXN0b3Jl X21zaS5idXMsIHJlc3RvcmVfbXNpLmRldmZuKSk7DQo+PiAtICAgICAgICByZXQgPSBwZGV2ID8g cGNpX3Jlc3RvcmVfbXNpX3N0YXRlKHBkZXYpIDogLUVOT0RFVjsNCj4+ICsgICAgICAgIGlmICgg cGRldiApDQo+PiArICAgICAgICB7DQo+PiArICAgICAgICAgICAgcmV0ID0gcGNpX3Jlc3RvcmVf bXNpX3N0YXRlKHBkZXYpOw0KPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAr ICAgICAgICB9DQo+PiArICAgICAgICBlbHNlDQo+PiArICAgICAgICAgICAgcmV0ID0gLUVOT0RF VjsNCj4+ICsNCj4+ICAgICAgICAgIHBjaWRldnNfdW5sb2NrKCk7DQo+PiAgICAgICAgICBicmVh azsNCj4+ICAgICAgfQ0KPj4gQEAgLTU0OCw3ICs1NTUsMTMgQEAgcmV0X3QgZG9fcGh5c2Rldl9v cChpbnQgY21kLCBYRU5fR1VFU1RfSEFORExFX1BBUkFNKHZvaWQpIGFyZykNCj4+ICANCj4+ICAg ICAgICAgIHBjaWRldnNfbG9jaygpOw0KPj4gICAgICAgICAgcGRldiA9IHBjaV9nZXRfcGRldihO VUxMLCBQQ0lfU0JERihkZXYuc2VnLCBkZXYuYnVzLCBkZXYuZGV2Zm4pKTsNCj4+IC0gICAgICAg IHJldCA9IHBkZXYgPyBwY2lfcmVzdG9yZV9tc2lfc3RhdGUocGRldikgOiAtRU5PREVWOw0KPj4g KyAgICAgICAgaWYgKCBwZGV2ICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAgICByZXQg PSAgcGNpX3Jlc3RvcmVfbXNpX3N0YXRlKHBkZXYpOw0KPj4gKyAgICAgICAgICAgIHBjaWRldl9w dXQocGRldik7DQo+PiArICAgICAgICB9DQo+PiArICAgICAgICBlbHNlDQo+PiArICAgICAgICAg ICAgcmV0ID0gLUVOT0RFVjsNCj4+ICAgICAgICAgIHBjaWRldnNfdW5sb2NrKCk7DQo+PiAgICAg ICAgICBicmVhazsNCj4+ICAgICAgfQ0KPj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vc3lzY3Rs LmMgYi94ZW4vY29tbW9uL3N5c2N0bC5jDQo+PiBpbmRleCAwMjUwNWFiMDQ0Li45YWYwN2ZhOTJh IDEwMDY0NA0KPj4gLS0tIGEveGVuL2NvbW1vbi9zeXNjdGwuYw0KPj4gKysrIGIveGVuL2NvbW1v bi9zeXNjdGwuYw0KPj4gQEAgLTQzOCw3ICs0MzgsNyBAQCBsb25nIGRvX3N5c2N0bChYRU5fR1VF U1RfSEFORExFX1BBUkFNKHhlbl9zeXNjdGxfdCkgdV9zeXNjdGwpDQo+PiAgICAgICAgICB7DQo+ PiAgICAgICAgICAgICAgcGh5c2Rldl9wY2lfZGV2aWNlX3QgZGV2Ow0KPj4gICAgICAgICAgICAg IHVpbnQzMl90IG5vZGU7DQo+PiAtICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBk ZXY7DQo+PiArICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiAgDQo+PiAgICAg ICAgICAgICAgaWYgKCBjb3B5X2Zyb21fZ3Vlc3Rfb2Zmc2V0KCZkZXYsIHRpLT5kZXZzLCBpLCAx KSApDQo+PiAgICAgICAgICAgICAgew0KPj4gQEAgLTQ1NCw4ICs0NTQsMTEgQEAgbG9uZyBkb19z eXNjdGwoWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fc3lzY3RsX3QpIHVfc3lzY3RsKQ0KPj4g ICAgICAgICAgICAgICAgICBub2RlID0gWEVOX0lOVkFMSURfTk9ERV9JRDsNCj4+ICAgICAgICAg ICAgICBlbHNlDQo+PiAgICAgICAgICAgICAgICAgIG5vZGUgPSBwZGV2LT5ub2RlOw0KPj4gLSAg ICAgICAgICAgIHBjaWRldnNfdW5sb2NrKCk7DQo+PiAgDQo+PiArICAgICAgICAgICAgaWYgKCBw ZGV2ICkNCj4+ICsgICAgICAgICAgICAgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICsNCj4+ICsg ICAgICAgICAgICBwY2lkZXZzX3VubG9jaygpOw0KPj4gICAgICAgICAgICAgIGlmICggY29weV90 b19ndWVzdF9vZmZzZXQodGktPm5vZGVzLCBpLCAmbm9kZSwgMSkgKQ0KPj4gICAgICAgICAgICAg IHsNCj4+ICAgICAgICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsNCj4+IGRpZmYgLS1naXQgYS94 ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5pdC5jIGIveGVuL2RyaXZlcnMvcGFz c3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYw0KPj4gaW5kZXggOTc3M2NjZmNiNC4uZjkwYjFjMWU1 OCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0 LmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMNCj4+ IEBAIC02NDYsNiArNjQ2LDcgQEAgc3RhdGljIHZvaWQgY2ZfY2hlY2sgcGFyc2VfcHByX2xvZ19l bnRyeShzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwgdTMyIGVudHJ5W10pDQo+PiAgDQo+PiAgICAg IGlmICggcGRldiApDQo+PiAgICAgICAgICBndWVzdF9pb21tdV9hZGRfcHByX2xvZyhwZGV2LT5k b21haW4sIGVudHJ5KTsNCj4+ICsgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICB9DQo+PiAgDQo+ PiAgc3RhdGljIHZvaWQgaW9tbXVfY2hlY2tfcHByX2xvZyhzdHJ1Y3QgYW1kX2lvbW11ICppb21t dSkNCj4+IEBAIC03NDksNiArNzUwLDExIEBAIHN0YXRpYyBib29sX3QgX19pbml0IHNldF9pb21t dV9pbnRlcnJ1cHRfaGFuZGxlcihzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSkNCj4+ICAgICAgfQ0K Pj4gIA0KPj4gICAgICBwY2lkZXZzX2xvY2soKTsNCj4+ICsgICAgLyoNCj4+ICsgICAgICogWFhY OiBpdCBpcyB1bmNsZWFyIGlmIHRoaXMgZGV2aWNlIGNhbiBiZSByZW1vdmVkLiBSaWdodCBub3cN Cj4+ICsgICAgICogdGhlcmUgaXMgbm8gY29kZSB0aGF0IGNsZWFycyBtc2kuZGV2LCBzbyBubyBv bmUgd2lsbCBkZWNyZWFzZQ0KPj4gKyAgICAgKiByZWZjb3VudCBvbiBpdC4NCj4+ICsgICAgICov DQo+PiAgICAgIGlvbW11LT5tc2kuZGV2ID0gcGNpX2dldF9wZGV2KE5VTEwsIFBDSV9TQkRGKGlv bW11LT5zZWcsIGlvbW11LT5iZGYpKTsNCj4NCj4gSSBkb24ndCB0aGluayB3ZSBjYW4gcmVtb3Zl IGFuIElPTU1VIGZyb20gdGhlIHN5c3RlbSwgc28gdGhpcyBpcw0KPiBmaW5lIGFzLWlzIEFGQUlD VC4NCj4NCg0KT2gsIHRoYW5rIHlvdSBmb3IgdGhlIGNsYXJpZmljYXRpb24uIEknbGwgcmVtb3Zl IHRoZSBjb21tZW50IHRoZW4uDQoNCj4+ICAgICAgcGNpZGV2c191bmxvY2soKTsNCj4+ICAgICAg aWYgKCAhaW9tbXUtPm1zaS5kZXYgKQ0KPj4gQEAgLTEyNzQsNyArMTI4MCw3IEBAIHN0YXRpYyBp bnQgX19pbml0IGNmX2NoZWNrIGFtZF9pb21tdV9zZXR1cF9kZXZpY2VfdGFibGUoDQo+PiAgICAg IHsNCj4+ICAgICAgICAgIGlmICggaXZyc19tYXBwaW5nc1tiZGZdLnZhbGlkICkNCj4+ICAgICAg ICAgIHsNCj4+IC0gICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IE5VTEw7 DQo+PiArICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSBOVUxMOw0KPj4gIA0KPj4g ICAgICAgICAgICAgIC8qIGFkZCBkZXZpY2UgdGFibGUgZW50cnkgKi8NCj4+ICAgICAgICAgICAg ICBpb21tdV9kdGVfYWRkX2RldmljZV9lbnRyeSgmZHRbYmRmXSwgJml2cnNfbWFwcGluZ3NbYmRm XSk7DQo+PiBAQCAtMTI5OSw3ICsxMzA1LDEwIEBAIHN0YXRpYyBpbnQgX19pbml0IGNmX2NoZWNr IGFtZF9pb21tdV9zZXR1cF9kZXZpY2VfdGFibGUoDQo+PiAgICAgICAgICAgICAgICAgICAgICAg ICAgcGRldi0+bXNpeCA/IHBkZXYtPm1zaXgtPm5yX2VudHJpZXMNCj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDogcGRldi0+bXNpX21heHZlYyk7DQo+PiAgICAgICAgICAg ICAgICAgIGlmICggIWl2cnNfbWFwcGluZ3NbYmRmXS5pbnRyZW1hcF90YWJsZSApDQo+PiArICAg ICAgICAgICAgICAgIHsNCj4+ICsgICAgICAgICAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7 DQo+PiAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4+ICsgICAgICAgICAg ICAgICAgfQ0KPj4gIA0KPj4gICAgICAgICAgICAgICAgICBpZiAoIHBkZXYtPnBoYW50b21fc3Ry aWRlICkNCj4+ICAgICAgICAgICAgICAgICAgew0KPj4gQEAgLTEzMTcsNiArMTMyNiw3IEBAIHN0 YXRpYyBpbnQgX19pbml0IGNmX2NoZWNrIGFtZF9pb21tdV9zZXR1cF9kZXZpY2VfdGFibGUoDQo+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5pbnRyZW1h cF9pbnVzZTsNCj4+ICAgICAgICAgICAgICAgICAgICAgIH0NCj4+ICAgICAgICAgICAgICAgICAg fQ0KPj4gKyAgICAgICAgICAgICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPj4gICAgICAgICAgICAg IH0NCj4+ICANCj4+ICAgICAgICAgICAgICBhbWRfaW9tbXVfc2V0X2ludHJlbWFwX3RhYmxlKA0K Pj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYyBi L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYw0KPj4gaW5kZXggOTkzYmFj NmY4OC4uOWQ2MjFlM2QzNiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2FtZC9pb21tdV9tYXAuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lv bW11X21hcC5jDQo+PiBAQCAtNzI0LDE0ICs3MjQsMTggQEAgaW50IGNmX2NoZWNrIGFtZF9pb21t dV9nZXRfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeSgNCj4+ICAgICAgICAgIGlmICggIWlvbW11ICkN Cj4+ICAgICAgICAgIHsNCj4+ICAgICAgICAgICAgICAvKiBNYXkgbmVlZCB0byB0cmlnZ2VyIHRo ZSB3b3JrYXJvdW5kIGluIGZpbmRfaW9tbXVfZm9yX2RldmljZSgpLiAqLw0KPj4gLSAgICAgICAg ICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KPj4gKyAgICAgICAgICAgIHN0cnVjdCBw Y2lfZGV2ICpwZGV2Ow0KPj4gIA0KPj4gICAgICAgICAgICAgIHBjaWRldnNfbG9jaygpOw0KPj4g ICAgICAgICAgICAgIHBkZXYgPSBwY2lfZ2V0X3BkZXYoTlVMTCwgc2JkZik7DQo+PiAgICAgICAg ICAgICAgcGNpZGV2c191bmxvY2soKTsNCj4+ICANCj4+ICAgICAgICAgICAgICBpZiAoIHBkZXYg KQ0KPj4gKyAgICAgICAgICAgIHsNCj4+ICAgICAgICAgICAgICAgICAgaW9tbXUgPSBmaW5kX2lv bW11X2Zvcl9kZXZpY2Uoc2VnLCBiZGYpOw0KPj4gKyAgICAgICAgICAgICAgICAvKiBYWFg6IFNo b3VsZCB3ZSBob2xkIHBkZXYgcmVmZXJlbmNlIHRpbGwgZW5kIG9mIHRoZSBsb29wPyAqLw0KPj4g KyAgICAgICAgICAgICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPg0KPiBJIGRvbid0IHRoaW5rIHlv dSBuZWVkIHRvIGhvbGQgYSByZWZlcmVuY2UgdG8gdGhlIGRldmljZSB1bnRpbCB0aGUgZW5kDQo+ IG9mIHRoZSBsb29wLCB0aGUgZGF0YSBmZXRjaGVkIHRoZXJlIGlzIGZyb20gdGhlIEFDUEkgdGFi bGVzLiAgSWYgdGhlDQo+IGZ1bmMoKSBoZWxwZXIgYWxzbyBuZWVkcyBhIHBkZXYgaW5zdGFuY2Ug aXMgaXQncyB0YXNrIHRvIGdldCBvbmUuDQo+DQoNClRoYW5rIHlvdSBmb3IgdGhlIGNsYXJpZmlj YXRpb24uIEknbGwgcmVtb3ZlIHRoZSBjb21tZW50Lg0KDQo+PiArICAgICAgICAgICAgfQ0KPj4g ICAgICAgICAgICAgIGlmICggIWlvbW11ICkNCj4+ICAgICAgICAgICAgICAgICAgY29udGludWU7 DQo+PiAgICAgICAgICB9DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv cGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gaW5kZXggYjQyYWNiOGQ3 Yy4uYjMyMzgyYWNhMCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj aS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gQEAgLTMyOCw2 ICszMjgsNyBAQCBzdGF0aWMgc3RydWN0IHBjaV9kZXYgKmFsbG9jX3BkZXYoc3RydWN0IHBjaV9z ZWcgKnBzZWcsIHU4IGJ1cywgdTggZGV2Zm4pDQo+PiAgICAgICooKHU4KikgJnBkZXYtPmJ1cykg PSBidXM7DQo+PiAgICAgICooKHU4KikgJnBkZXYtPmRldmZuKSA9IGRldmZuOw0KPj4gICAgICBw ZGV2LT5kb21haW4gPSBOVUxMOw0KPj4gKyAgICByZWZjbnRfaW5pdCgmcGRldi0+cmVmY250KTsN Cj4+ICANCj4+ICAgICAgYXJjaF9wY2lfaW5pdF9wZGV2KHBkZXYpOw0KPj4gIA0KPj4gQEAgLTQy MiwzMyArNDIzLDYgQEAgc3RhdGljIHN0cnVjdCBwY2lfZGV2ICphbGxvY19wZGV2KHN0cnVjdCBw Y2lfc2VnICpwc2VnLCB1OCBidXMsIHU4IGRldmZuKQ0KPj4gICAgICByZXR1cm4gcGRldjsNCj4+ ICB9DQo+PiAgDQo+PiAtc3RhdGljIHZvaWQgZnJlZV9wZGV2KHN0cnVjdCBwY2lfc2VnICpwc2Vn LCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+IC17DQo+PiAtICAgIC8qIHVwZGF0ZSBidXMyYnJp ZGdlICovDQo+PiAtICAgIHN3aXRjaCAoIHBkZXYtPnR5cGUgKQ0KPj4gLSAgICB7DQo+PiAtICAg ICAgICB1bnNpZ25lZCBpbnQgc2VjX2J1cywgc3ViX2J1czsNCj4+IC0NCj4+IC0gICAgICAgIGNh c2UgREVWX1RZUEVfUENJZTJQQ0lfQlJJREdFOg0KPj4gLSAgICAgICAgY2FzZSBERVZfVFlQRV9M RUdBQ1lfUENJX0JSSURHRToNCj4+IC0gICAgICAgICAgICBzZWNfYnVzID0gcGNpX2NvbmZfcmVh ZDgocGRldi0+c2JkZiwgUENJX1NFQ09OREFSWV9CVVMpOw0KPj4gLSAgICAgICAgICAgIHN1Yl9i dXMgPSBwY2lfY29uZl9yZWFkOChwZGV2LT5zYmRmLCBQQ0lfU1VCT1JESU5BVEVfQlVTKTsNCj4+ IC0NCj4+IC0gICAgICAgICAgICBzcGluX2xvY2soJnBzZWctPmJ1czJicmlkZ2VfbG9jayk7DQo+ PiAtICAgICAgICAgICAgZm9yICggOyBzZWNfYnVzIDw9IHN1Yl9idXM7IHNlY19idXMrKyApDQo+ PiAtICAgICAgICAgICAgICAgIHBzZWctPmJ1czJicmlkZ2Vbc2VjX2J1c10gPSBwc2VnLT5idXMy YnJpZGdlW3BkZXYtPmJ1c107DQo+PiAtICAgICAgICAgICAgc3Bpbl91bmxvY2soJnBzZWctPmJ1 czJicmlkZ2VfbG9jayk7DQo+PiAtICAgICAgICAgICAgYnJlYWs7DQo+PiAtDQo+PiAtICAgICAg ICBkZWZhdWx0Og0KPj4gLSAgICAgICAgICAgIGJyZWFrOw0KPj4gLSAgICB9DQo+PiAtDQo+PiAt ICAgIGxpc3RfZGVsKCZwZGV2LT5hbGxkZXZzX2xpc3QpOw0KPj4gLSAgICBwZGV2X21zaV9kZWlu aXQocGRldik7DQo+PiAtICAgIHhmcmVlKHBkZXYpOw0KPj4gLX0NCj4+IC0NCj4+ICBzdGF0aWMg dm9pZCBfX2luaXQgX3BjaV9oaWRlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICB7 DQo+PiAgICAgIGlmICggcGRldi0+ZG9tYWluICkNCj4+IEBAIC01MTcsMTAgKzQ5MSwxNCBAQCBz dHJ1Y3QgcGNpX2RldiAqcGNpX2dldF9yZWFsX3BkZXYocGNpX3NiZGZfdCBzYmRmKQ0KPj4gICAg ICB7DQo+PiAgICAgICAgICBpZiAoICEoc2JkZi5kZXZmbiAmIHN0cmlkZSkgKQ0KPj4gICAgICAg ICAgICAgIGNvbnRpbnVlOw0KPj4gKw0KPg0KPiBVbnJlbGF0ZWQgY2hhbmdlPyAgVGhlcmUgYXJl IHNvbWUgb2YgdGhvc2UgaW4gdGhlIHBhdGNoLCBzaG91bGQgYmUNCj4gcmVtb3ZlZC4NCg0KWWVz LCBzb3JyeSBmb3IgdGhpcy4NCg0KPg0KPj4gICAgICAgICAgc2JkZi5kZXZmbiAmPSB+c3RyaWRl Ow0KPj4gICAgICAgICAgcGRldiA9IHBjaV9nZXRfcGRldihOVUxMLCBzYmRmKTsNCj4+ICAgICAg ICAgIGlmICggcGRldiAmJiBzdHJpZGUgIT0gcGRldi0+cGhhbnRvbV9zdHJpZGUgKQ0KPj4gKyAg ICAgICAgew0KPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgICAgICAg ICAgcGRldiA9IE5VTEw7DQo+PiArICAgICAgICB9DQo+PiAgICAgIH0NCj4+ICANCj4+ICAgICAg cmV0dXJuIHBkZXY7DQo+PiBAQCAtNTQ4LDEzICs1MjYsMTggQEAgc3RydWN0IHBjaV9kZXYgKnBj aV9nZXRfcGRldihjb25zdCBzdHJ1Y3QgZG9tYWluICpkLCBwY2lfc2JkZl90IHNiZGYpDQo+PiAg ICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5ICggcGRldiwgJnBzZWctPmFsbGRldnNfbGlzdCwg YWxsZGV2c19saXN0ICkNCj4+ICAgICAgICAgICAgICBpZiAoIHBkZXYtPnNiZGYuYmRmID09IHNi ZGYuYmRmICYmDQo+PiAgICAgICAgICAgICAgICAgICAoIWQgfHwgcGRldi0+ZG9tYWluID09IGQp ICkNCj4+ICsgICAgICAgICAgICB7DQo+PiArICAgICAgICAgICAgICAgIHBjaWRldl9nZXQocGRl dik7DQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiBwZGV2Ow0KPj4gKyAgICAgICAgICAgIH0N Cj4+ICAgICAgfQ0KPj4gICAgICBlbHNlDQo+PiAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5 ICggcGRldiwgJmQtPnBkZXZfbGlzdCwgZG9tYWluX2xpc3QgKQ0KPj4gICAgICAgICAgICAgIGlm ICggcGRldi0+c2JkZi5iZGYgPT0gc2JkZi5iZGYgKQ0KPj4gKyAgICAgICAgICAgIHsNCj4+ICsg ICAgICAgICAgICAgICAgcGNpZGV2X2dldChwZGV2KTsNCj4+ICAgICAgICAgICAgICAgICAgcmV0 dXJuIHBkZXY7DQo+PiAtDQo+PiArICAgICAgICAgICAgfQ0KPj4gICAgICByZXR1cm4gTlVMTDsN Cj4+ICB9DQo+PiAgDQo+PiBAQCAtNjYzLDcgKzY0NiwxMCBAQCBpbnQgcGNpX2FkZF9kZXZpY2Uo dTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgUENJX1NCREYoc2VnLCBpbmZvLT5waHlzZm4uYnVzLA0KPj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbmZvLT5waHlzZm4uZGV2Zm4pKTsNCj4+ICAgICAgICAgIGlm ICggcGRldiApDQo+PiArICAgICAgICB7DQo+PiAgICAgICAgICAgICAgcGZfaXNfZXh0Zm4gPSBw ZGV2LT5pbmZvLmlzX2V4dGZuOw0KPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+ PiArICAgICAgICB9DQo+PiAgICAgICAgICBwY2lkZXZzX3VubG9jaygpOw0KPj4gICAgICAgICAg aWYgKCAhcGRldiApDQo+PiAgICAgICAgICAgICAgcGNpX2FkZF9kZXZpY2Uoc2VnLCBpbmZvLT5w aHlzZm4uYnVzLCBpbmZvLT5waHlzZm4uZGV2Zm4sDQo+PiBAQCAtODE4LDcgKzgwNCw5IEBAIGlu dCBwY2lfcmVtb3ZlX2RldmljZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuKQ0KPj4gICAgICAg ICAgICAgIGlmICggcGRldi0+ZG9tYWluICkNCj4+ICAgICAgICAgICAgICAgICAgbGlzdF9kZWwo JnBkZXYtPmRvbWFpbl9saXN0KTsNCj4+ICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0RFQlVH ICJQQ0kgcmVtb3ZlIGRldmljZSAlcHBcbiIsICZwZGV2LT5zYmRmKTsNCj4+IC0gICAgICAgICAg ICBmcmVlX3BkZXYocHNlZywgcGRldik7DQo+PiArICAgICAgICAgICAgbGlzdF9kZWwoJnBkZXYt PmFsbGRldnNfbGlzdCk7DQo+PiArICAgICAgICAgICAgcGRldl9tc2lfZGVpbml0KHBkZXYpOw0K Pj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+DQo+IEhtLCBJIHRoaW5rIGhlcmUg d2Ugd2FudCB0byBtYWtlIHN1cmUgdGhhdCB0aGUgZGV2aWNlIGhhcyBiZWVuIGZyZWVkLA0KPiBv ciBlbHNlIHlvdSB3b3VsZCBoYXZlIHRvIHJldHVybiAtRUJVU1kgdG8gdGhlIGNhbGxzIHRvIG5v dGlmeSB0aGF0DQo+IHRoZSBkZXZpY2UgaXMgc3RpbGwgaW4gdXNlLg0KDQpXaHk/IEFzIEkgY2Fu IHNlZSwgcGRldiBvYmplY3QgaXMgc3RpbGwgbWF5IHBvdGVudGlhbGx5IGJlIGFjY2Vzc2VkIGJ5 DQpzb21lIG90aGVyIENQVSByaWdodCBub3cuIFNvIHBkZXYgb2JqZWN0IHdpbGwgYmUgZnJlZWQg YWZ0ZXIgbGFzdA0KcmVmZXJlbmNlIGlzIGRyb3BwZWQuIEFzIGl0IGlzIGFscmVhZHkgcmVtb3Zl ZCBmcm9tIGFsbCB0aGUgbGlzdHMsDQpwY2lfZGV2X2dldCgpIHdpbGwgbm90IGZpbmQgaXQgYW55 bW9yZS4NCg0KQWN0dWFsbHksIEkgY2FuJ3Qgc2VlIGhvdyB0aGlzIGNhbiBoYXBwZW4gaW4gcmVh bGl0eSwgYXMgVlBDSSwgTVNJIGFuZA0KSU9NTVUgYXJlIGFscmVhZHkgZGVhY3RpdmF0ZWQgZm9y IHRoaXMgZGV2aWNlLiBTbywgbm8gb25lIHdvdWxkIHRvdWNoIGl0Lg0KDQo+DQo+IEkgdGhpbmsg d2UgbmVlZCBhbiBleHRyYSBwY2lkZXZfcHV0X2ZpbmFsKCkgb3Igc2ltaWxhciB0aGF0IGNhbiBi ZQ0KPiB1c2VkIGluIHBjaV9yZW1vdmVfZGV2aWNlKCkgdG8gYXNzZXJ0IHRoYXQgdGhlIGRldmlj ZSBoYXMgYmVlbg0KPiBhY3R1YWxseSByZW1vdmVkLg0KDQpXaWxsIHNvbWV0aGluZyBicmVhayBp ZiB3ZSBkb24ndCBkbyB0aGlzPyBJIGNhbid0IHNlZSBob3cgdGhpcyBjYW4NCmhhcHBlbi4NCg0K Pg0KPj4gICAgICAgICAgICAgIGJyZWFrOw0KPj4gICAgICAgICAgfQ0KPj4gIA0KPj4gQEAgLTg0 OCw3ICs4MzYsNyBAQCBzdGF0aWMgaW50IGRlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpk LCB1aW50MTZfdCBzZWcsIHVpbnQ4X3QgYnVzLA0KPj4gICAgICB7DQo+PiAgICAgICAgICByZXQg PSBpb21tdV9xdWFyYW50aW5lX2Rldl9pbml0KHBjaV90b19kZXYocGRldikpOw0KPj4gICAgICAg ICAgaWYgKCByZXQgKQ0KPj4gLSAgICAgICAgICAgcmV0dXJuIHJldDsNCj4+ICsgICAgICAgICAg ICBnb3RvIG91dDsNCj4+ICANCj4+ICAgICAgICAgIHRhcmdldCA9IGRvbV9pbzsNCj4+ICAgICAg fQ0KPj4gQEAgLTg3OCw2ICs4NjYsNyBAQCBzdGF0aWMgaW50IGRlYXNzaWduX2RldmljZShzdHJ1 Y3QgZG9tYWluICpkLCB1aW50MTZfdCBzZWcsIHVpbnQ4X3QgYnVzLA0KPj4gICAgICBwZGV2LT5m YXVsdC5jb3VudCA9IDA7DQo+PiAgDQo+PiAgIG91dDoNCj4+ICsgICAgcGNpZGV2X3B1dChwZGV2 KTsNCj4+ICAgICAgaWYgKCByZXQgKQ0KPj4gICAgICAgICAgcHJpbnRrKFhFTkxPR19HX0VSUiAi JXBkOiBkZWFzc2lnbiAoJXBwKSBmYWlsZWQgKCVkKVxuIiwNCj4+ICAgICAgICAgICAgICAgICBk LCAmUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSwgcmV0KTsNCj4+IEBAIC0xMDExLDcgKzEwMDAs MTAgQEAgdm9pZCBwY2lfY2hlY2tfZGlzYWJsZV9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBk ZXZmbikNCj4+ICAgICAgICAgICAgICBwZGV2LT5mYXVsdC5jb3VudCA+Pj0gMTsNCj4+ICAgICAg ICAgIHBkZXYtPmZhdWx0LnRpbWUgPSBub3c7DQo+PiAgICAgICAgICBpZiAoICsrcGRldi0+ZmF1 bHQuY291bnQgPCBQVF9GQVVMVF9USFJFU0hPTEQgKQ0KPj4gKyAgICAgICAgew0KPj4gKyAgICAg ICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgICAgICAgICAgcGRldiA9IE5VTEw7DQo+ PiArICAgICAgICB9DQo+PiAgICAgIH0NCj4+ICAgICAgcGNpZGV2c191bmxvY2soKTsNCj4+ICAN Cj4+IEBAIC0xMDIyLDYgKzEwMTQsOCBAQCB2b2lkIHBjaV9jaGVja19kaXNhYmxlX2RldmljZSh1 MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuKQ0KPj4gICAgICAgKiBjb250cm9sIGl0IGZvciB1cy4g Ki8NCj4+ICAgICAgY3dvcmQgPSBwY2lfY29uZl9yZWFkMTYocGRldi0+c2JkZiwgUENJX0NPTU1B TkQpOw0KPj4gICAgICBwY2lfY29uZl93cml0ZTE2KHBkZXYtPnNiZGYsIFBDSV9DT01NQU5ELCBj d29yZCAmIH5QQ0lfQ09NTUFORF9NQVNURVIpOw0KPj4gKw0KPj4gKyAgICBwY2lkZXZfcHV0KHBk ZXYpOw0KPj4gIH0NCj4+ICANCj4+ICAvKg0KPj4gQEAgLTExMzgsNiArMTEzMiw3IEBAIHN0YXRp YyBpbnQgX19od2RvbV9pbml0IGNmX2NoZWNrIF9zZXR1cF9od2RvbV9wY2lfZGV2aWNlcygNCj4+ ICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HICJEb20lZCBvd25pbmcgJXBw P1xuIiwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHBkZXYtPmRvbWFpbi0+ZG9tYWluX2lk LCAmcGRldi0+c2JkZik7DQo+PiAgDQo+PiArICAgICAgICAgICAgcGNpZGV2X3B1dChwZGV2KTsN Cj4+ICAgICAgICAgICAgICBpZiAoIGlvbW11X3ZlcmJvc2UgKQ0KPj4gICAgICAgICAgICAgIHsN Cj4+ICAgICAgICAgICAgICAgICAgcGNpZGV2c191bmxvY2soKTsNCj4+IEBAIC0xMzg1LDMzICsx MzgwLDI4IEBAIHN0YXRpYyBpbnQgaW9tbXVfcmVtb3ZlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAq cGRldikNCj4+ICAgICAgcmV0dXJuIGlvbW11X2NhbGwoaGQtPnBsYXRmb3JtX29wcywgcmVtb3Zl X2RldmljZSwgZGV2Zm4sIHBjaV90b19kZXYocGRldikpOw0KPj4gIH0NCj4+ICANCj4+IC1zdGF0 aWMgaW50IGRldmljZV9hc3NpZ25lZCh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuKQ0KPj4gK3N0 YXRpYyBpbnQgZGV2aWNlX2Fzc2lnbmVkKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gIHsNCj4+ IC0gICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiAgICAgIGludCByYyA9IDA7DQo+PiAgDQo+ PiAgICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsNCj4+IC0gICAgcGRldiA9IHBjaV9nZXRf cGRldihOVUxMLCBQQ0lfU0JERihzZWcsIGJ1cywgZGV2Zm4pKTsNCj4+IC0NCj4+IC0gICAgaWYg KCAhcGRldiApDQo+PiAtICAgICAgICByYyA9IC1FTk9ERVY7DQo+PiAgICAgIC8qDQo+PiAgICAg ICAqIElmIHRoZSBkZXZpY2UgZXhpc3RzIGFuZCBpdCBpcyBub3Qgb3duZWQgYnkgZWl0aGVyIHRo ZSBoYXJkd2FyZQ0KPj4gICAgICAgKiBkb21haW4gb3IgZG9tX2lvIHRoZW4gaXQgbXVzdCBiZSBh c3NpZ25lZCB0byBhIGd1ZXN0LCBvciBiZQ0KPj4gICAgICAgKiBoaWRkZW4gKG93bmVkIGJ5IGRv bV94ZW4pLg0KPj4gICAgICAgKi8NCj4+IC0gICAgZWxzZSBpZiAoIHBkZXYtPmRvbWFpbiAhPSBo YXJkd2FyZV9kb21haW4gJiYNCj4+IC0gICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiAhPSBkb21f aW8gKQ0KPj4gKyAgICBpZiAoIHBkZXYtPmRvbWFpbiAhPSBoYXJkd2FyZV9kb21haW4gJiYNCj4+ ICsgICAgICAgICBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkNCj4+ICAgICAgICAgIHJjID0gLUVC VVNZOw0KPj4gIA0KPj4gICAgICByZXR1cm4gcmM7DQo+PiAgfQ0KPj4gIA0KPj4gIC8qIENhbGxl ciBzaG91bGQgaG9sZCB0aGUgcGNpZGV2c19sb2NrICovDQo+DQo+IEkgd291bGQgYXNzdW1lIHRo ZSBjYWxsZXIgaGFzIHRha2VuIGFuIGV4dHJhIHJlZmVyZW5jZSB0byB0aGUgcGRldiwgc28NCj4g aG9sZGluZyB0aGUgcGNpZGV2c19sb2NrIGlzIG5vIGxvbmdlciBuZWVkZWQ/DQoNCkkgYW0gYXNz dW1lZCB0aGF0IGxvY2sgbWF5IGJlIHJlcXVpcmVkIGJ5IE1TSVggb3IgSU9NTVUgZnVuY3Rpb25z LCB0aGF0DQphcmUgYmVpbmcgY2FsbGVkIGhlcmUuIEZvciBleGFtcGxlLCBJIGNhbiBzZWUgdGhh dCByZWFzc2lnbl9kZXZpY2UoKSBpbg0KcGNpX2FtZF9pb21tdS5jIG1hbmlwdWxhdGVzIHdpdGgg c29tZSBsaXN0cy4gSSBiZWxpZXZlLCBpdCBzaG91bGQgYmUNCnByb3RlY3RlZCB3aXRoIHRoZSBs b2NrLg0KDQo+DQo+PiAtc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQs IHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gK3N0YXRpYyBpbnQgYXNz aWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdTMyIGZs YWcpDQo+PiAgew0KPj4gICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9p b21tdShkKTsNCj4+IC0gICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiArICAgIHVpbnQ4X3Qg ZGV2Zm47DQo+PiAgICAgIGludCByYyA9IDA7DQo+PiAgDQo+PiAgICAgIGlmICggIWlzX2lvbW11 X2VuYWJsZWQoZCkgKQ0KPj4gQEAgLTE0MjIsMTAgKzE0MTIsMTEgQEAgc3RhdGljIGludCBhc3Np Z25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUz MiBmbGFnKQ0KPj4gIA0KPj4gICAgICAvKiBkZXZpY2VfYXNzaWduZWQoKSBzaG91bGQgYWxyZWFk eSBoYXZlIGNsZWFyZWQgdGhlIGRldmljZSBmb3IgYXNzaWdubWVudCAqLw0KPj4gICAgICBBU1NF UlQocGNpZGV2c19sb2NrZWQoKSk7DQo+PiAtICAgIHBkZXYgPSBwY2lfZ2V0X3BkZXYoTlVMTCwg UENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+PiAgICAgIEFTU0VSVChwZGV2ICYmIChwZGV2 LT5kb21haW4gPT0gaGFyZHdhcmVfZG9tYWluIHx8DQo+PiAgICAgICAgICAgICAgICAgICAgICBw ZGV2LT5kb21haW4gPT0gZG9tX2lvKSk7DQo+PiAgDQo+PiArICAgIGRldmZuID0gcGRldi0+ZGV2 Zm47DQo+PiArDQo+PiAgICAgIC8qIERvIG5vdCBhbGxvdyBicm9rZW4gZGV2aWNlcyB0byBiZSBh c3NpZ25lZCB0byBndWVzdHMuICovDQo+PiAgICAgIHJjID0gLUVCQURGOw0KPj4gICAgICBpZiAo IHBkZXYtPmJyb2tlbiAmJiBkICE9IGhhcmR3YXJlX2RvbWFpbiAmJiBkICE9IGRvbV9pbyApDQo+ PiBAQCAtMTQ2MCw3ICsxNDUxLDcgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBk b21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gICBkb25l Og0KPj4gICAgICBpZiAoIHJjICkNCj4+ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5H ICIlcGQ6IGFzc2lnbiAoJXBwKSBmYWlsZWQgKCVkKVxuIiwNCj4+IC0gICAgICAgICAgICAgICBk LCAmUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSwgcmMpOw0KPj4gKyAgICAgICAgICAgICAgIGQs ICZQQ0lfU0JERihwZGV2LT5zZWcsIHBkZXYtPmJ1cywgZGV2Zm4pLCByYyk7DQo+PiAgICAgIC8q IFRoZSBkZXZpY2UgaXMgYXNzaWduZWQgdG8gZG9tX2lvIHNvIG1hcmsgaXQgYXMgcXVhcmFudGlu ZWQgKi8NCj4+ICAgICAgZWxzZSBpZiAoIGQgPT0gZG9tX2lvICkNCj4+ICAgICAgICAgIHBkZXYt PnF1YXJhbnRpbmUgPSB0cnVlOw0KPj4gQEAgLTE1OTUsNiArMTU4Niw5IEBAIGludCBpb21tdV9k b19wY2lfZG9tY3RsKA0KPj4gICAgICAgICAgQVNTRVJUKGQpOw0KPj4gICAgICAgICAgLyogZmFs bCB0aHJvdWdoICovDQo+PiAgICAgIGNhc2UgWEVOX0RPTUNUTF90ZXN0X2Fzc2lnbl9kZXZpY2U6 DQo+PiArICAgIHsNCj4+ICsgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KPj4gKw0KPj4g ICAgICAgICAgLyogRG9uJ3Qgc3VwcG9ydCBzZWxmLWFzc2lnbm1lbnQgb2YgZGV2aWNlcy4gKi8N Cj4+ICAgICAgICAgIGlmICggZCA9PSBjdXJyZW50LT5kb21haW4gKQ0KPj4gICAgICAgICAgew0K Pj4gQEAgLTE2MjIsMjYgKzE2MTYsMzYgQEAgaW50IGlvbW11X2RvX3BjaV9kb21jdGwoDQo+PiAg ICAgICAgICBzZWcgPSBtYWNoaW5lX3NiZGYgPj4gMTY7DQo+PiAgICAgICAgICBidXMgPSBQQ0lf QlVTKG1hY2hpbmVfc2JkZik7DQo+PiAgICAgICAgICBkZXZmbiA9IFBDSV9ERVZGTihtYWNoaW5l X3NiZGYpOw0KPj4gLQ0KPj4gICAgICAgICAgcGNpZGV2c19sb2NrKCk7DQo+PiAtICAgICAgICBy ZXQgPSBkZXZpY2VfYXNzaWduZWQoc2VnLCBidXMsIGRldmZuKTsNCj4+ICsgICAgICAgIHBkZXYg PSBwY2lfZ2V0X3BkZXYoTlVMTCwgUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+PiArICAg ICAgICBpZiAoICFwZGV2ICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAgICBwcmludGso WEVOTE9HX0dfSU5GTyAiJXBwIG5vbi1leGlzdGVudFxuIiwNCj4+ICsgICAgICAgICAgICAgICAg ICAgJlBDSV9TQkRGKHNlZywgYnVzLCBkZXZmbikpOw0KPj4gKyAgICAgICAgICAgIHJldCA9IC1F SU5WQUw7DQo+PiArICAgICAgICAgICAgYnJlYWs7DQo+PiArICAgICAgICB9DQo+PiArDQo+PiAr ICAgICAgICByZXQgPSBkZXZpY2VfYXNzaWduZWQocGRldik7DQo+PiAgICAgICAgICBpZiAoIGRv bWN0bC0+Y21kID09IFhFTl9ET01DVExfdGVzdF9hc3NpZ25fZGV2aWNlICkNCj4+ICAgICAgICAg IHsNCj4+ICAgICAgICAgICAgICBpZiAoIHJldCApDQo+PiAgICAgICAgICAgICAgew0KPj4gLSAg ICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfSU5GTyAiJXBwIGFscmVhZHkgYXNzaWduZWQs IG9yIG5vbi1leGlzdGVudFxuIiwNCj4+ICsgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19H X0lORk8gIiVwcCBhbHJlYWR5IGFzc2lnbmVkXG4iLA0KPj4gICAgICAgICAgICAgICAgICAgICAg ICAgJlBDSV9TQkRGKHNlZywgYnVzLCBkZXZmbikpOw0KPj4gICAgICAgICAgICAgICAgICByZXQg PSAtRUlOVkFMOw0KPj4gICAgICAgICAgICAgIH0NCj4+ICAgICAgICAgIH0NCj4+ICAgICAgICAg IGVsc2UgaWYgKCAhcmV0ICkNCj4+IC0gICAgICAgICAgICByZXQgPSBhc3NpZ25fZGV2aWNlKGQs IHNlZywgYnVzLCBkZXZmbiwgZmxhZ3MpOw0KPj4gKyAgICAgICAgICAgIHJldCA9IGFzc2lnbl9k ZXZpY2UoZCwgcGRldiwgZmxhZ3MpOw0KPj4gKw0KPj4gKyAgICAgICAgcGNpZGV2X3B1dChwZGV2 KTsNCj4NCj4gSSB3b3VsZCB0aGluayB5b3UgbmVlZCB0byBrZWVwIHRoZSByZWZjb3VudCBoZXJl IGlmIHJldCA9PSAwLCBzbyB0aGF0DQo+IHRoZSBkZXZpY2UgY2Fubm90IGJlIHJlbW92ZWQgd2hp bGUgYXNzaWduZWQgdG8gYSBkb21haW4/DQoNCkxvb2tzIGxpa2Ugd2UgYXJlIHBlcmNlaXZpbmcg ZnVuY3Rpb24gb2YgcmVmY250IGluIGEgZGlmZmVyZW50DQp3YXlzLiBGb3IgbWUsIHRoaXMgaXMg dGhlIG1lY2hhbmlzbSB0byBndWFyYW50ZWUgdGhhdCBpZiB3ZSBoYXZlIGEgdmFsaWQNCnBvaW50 ZXIgdG8gYW4gb2JqZWN0LCB0aGlzIG9iamVjdCB3aWxsIG5vdCBkaXNhcHBlYXIgdW5kZXIgb3Vy DQpmZWV0LiBUaGlzIGlzIHRoZSBtYWluIGZ1bmN0aW9uIG9mIGtyZWZzIGluIHRoZSBsaW51eCBr ZXJuZWw6IGlmIHlvdXINCmNvZGUgaG9sZHMgYSByZWZlcmVuY2UgdG8gYW4gb2JqZWN0LCB5b3Ug Y2FuIGJlIHN1cmUgdGhhdCB0aGlzIG9iamVjdCBpcw0KZXhpc3RzIGluIG1lbW9yeS4NCg0KT24g b3RoZXIgaGFuZCwgaXQgc2VlbXMgdGhhdCB5b3UgYXJlIGNvbnNpZGVyaW5nIHRoaXMgcmVmY250 IGFzIGFuIHVzYWdlDQpjb3VudGVyIGZvciBhbiBhY3R1YWwgUENJIGRldmljZSwgbm90ICJzdHJ1 Y3QgcGRldiIgdGhhdCByZXByZXNlbnQNCml0LiBUaG9zZSBhcmUgdHdvIHJlbGF0ZWQgdGhpbmdz LCBidXQgbm90IHRoZSBzYW1lLiBTbywgSSBjYW4gc2VlIHdoeQ0KeW91IGFyZSBzdWdnZXN0aW5n IHRvIGdldCBhZGRpdGlvbmFsIHJlZmVyZW5jZSB0aGVyZS4gQnV0IGZvciBtZSwgdGhpcw0KbG9v a3MgdW5uZWNlc3Nhcnk6IHRoZSB2ZXJ5IGZpcnN0IHJlZmNvdW50IGlzIG9idGFpbmVkIGluDQpw Y2lfYWRkX2RldmljZSgpIGFuZCB0aGVyZSBpcyB0aGUgY29ycmVzcG9uZGluZyBmdW5jdGlvbg0K cGNpX3JlbW92ZV9kZXZpY2UoKSB0aGF0IHdpbGwgZHJvcCB0aGlzIHJlZmNvdW50LiBTbywgZm9y IG1lLCBpZiBhZG1pbg0Kd2FudHMgdG8gcmVtb3ZlIGEgUENJIGRldmljZSB3aGljaCBpcyBhc3Np Z25lZCB0byBhIGRvbWFpbiwgdGhleSBjYW4gZG8NCnRoaXMgYXMgdGhleSB3ZXJlIGFibGUgdG8g ZG8gdGhpcyBwcmlvciB0aGlzIHBhdGNoZXMuDQoNClRoZSBtYWluIHZhbHVlIG9mIGludHJvZHVj aW5nIHJlZmNudCBpcyB0byBiZSBhYmxlIHRvIGFjY2VzcyBwZGV2IG9iamVjdHMNCndpdGhvdXQg aG9sZGluZyB0aGUgZ2xvYmFsIHBjaWRldnNfbG9jaygpLiBUaGlzIGRvZXMgbm90IG1lYW4gdGhh dCB5b3UNCmRvbid0IG5lZWQgbG9ja2luZyBhdCBhbGwuIEJ1dCB0aGlzIGFsbG93cyB5b3UgdG8g dXNlIHBkZXYtPmxvY2sgKHdoaWNoDQpkb2VzIG5vdCBleGlzdHMgaW4gdGhpcyBzZXJpZXMsIGJ1 dCB3YXMgaW50cm9kdWNlZCBpbiBhIFJGQyBlYXJsaWVyKSwgb3INCnZwY2ktPmxvY2ssIG9yIGFu eSBvdGhlciBzdWJzeXN0ZW0tPmxvY2suDQoNCj4NCj4+ICAgICAgICAgIHBjaWRldnNfdW5sb2Nr KCk7DQo+PiAgICAgICAgICBpZiAoIHJldCA9PSAtRVJFU1RBUlQgKQ0KPj4gICAgICAgICAgICAg IHJldCA9IGh5cGVyY2FsbF9jcmVhdGVfY29udGludWF0aW9uKF9fSFlQRVJWSVNPUl9kb21jdGws DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImgi LCB1X2RvbWN0bCk7DQo+PiAgICAgICAgICBicmVhazsNCj4+IC0NCj4+ICsgICAgfQ0KPj4gICAg ICBjYXNlIFhFTl9ET01DVExfZGVhc3NpZ25fZGV2aWNlOg0KPj4gICAgICAgICAgLyogRG9uJ3Qg c3VwcG9ydCBzZWxmLWRlYXNzaWdubWVudCBvZiBkZXZpY2VzLiAqLw0KPj4gICAgICAgICAgaWYg KCBkID09IGN1cnJlbnQtPmRvbWFpbiApDQo+PiBAQCAtMTY4MSw2ICsxNjg1LDQ2IEBAIGludCBp b21tdV9kb19wY2lfZG9tY3RsKA0KPj4gICAgICByZXR1cm4gcmV0Ow0KPj4gIH0NCj4+ICANCj4+ ICtzdGF0aWMgdm9pZCByZWxlYXNlX3BkZXYocmVmY250X3QgKnJlZmNudCkNCj4+ICt7DQo+PiAr ICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gY29udGFpbmVyX29mKHJlZmNudCwgc3RydWN0IHBj aV9kZXYsIHJlZmNudCk7DQo+PiArICAgIHN0cnVjdCBwY2lfc2VnICpwc2VnID0gZ2V0X3BzZWco cGRldi0+c2VnKTsNCj4+ICsNCj4+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAiUENJIHJlbGVh c2UgZGV2aWNlICVwcFxuIiwgJnBkZXYtPnNiZGYpOw0KPj4gKw0KPj4gKyAgICAvKiB1cGRhdGUg YnVzMmJyaWRnZSAqLw0KPj4gKyAgICBzd2l0Y2ggKCBwZGV2LT50eXBlICkNCj4+ICsgICAgew0K Pj4gKyAgICAgICAgdW5zaWduZWQgaW50IHNlY19idXMsIHN1Yl9idXM7DQo+PiArDQo+PiArICAg ICAgICBjYXNlIERFVl9UWVBFX1BDSWUyUENJX0JSSURHRToNCj4+ICsgICAgICAgIGNhc2UgREVW X1RZUEVfTEVHQUNZX1BDSV9CUklER0U6DQo+PiArICAgICAgICAgICAgc2VjX2J1cyA9IHBjaV9j b25mX3JlYWQ4KHBkZXYtPnNiZGYsIFBDSV9TRUNPTkRBUllfQlVTKTsNCj4+ICsgICAgICAgICAg ICBzdWJfYnVzID0gcGNpX2NvbmZfcmVhZDgocGRldi0+c2JkZiwgUENJX1NVQk9SRElOQVRFX0JV Uyk7DQo+PiArDQo+PiArICAgICAgICAgICAgc3Bpbl9sb2NrKCZwc2VnLT5idXMyYnJpZGdlX2xv Y2spOw0KPj4gKyAgICAgICAgICAgIGZvciAoIDsgc2VjX2J1cyA8PSBzdWJfYnVzOyBzZWNfYnVz KysgKQ0KPj4gKyAgICAgICAgICAgICAgICBwc2VnLT5idXMyYnJpZGdlW3NlY19idXNdID0gcHNl Zy0+YnVzMmJyaWRnZVtwZGV2LT5idXNdOw0KPj4gKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZw c2VnLT5idXMyYnJpZGdlX2xvY2spOw0KPj4gKyAgICAgICAgICAgIGJyZWFrOw0KPj4gKw0KPj4g KyAgICAgICAgZGVmYXVsdDoNCj4+ICsgICAgICAgICAgICBicmVhazsNCj4+ICsgICAgfQ0KPj4g Kw0KPj4gKyAgICB4ZnJlZShwZGV2KTsNCj4+ICt9DQo+PiArDQo+PiArdm9pZCBwY2lkZXZfZ2V0 KHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgcmVmY250X2dldCgmcGRldi0+ cmVmY250KTsNCj4+ICt9DQo+PiArDQo+PiArdm9pZCBwY2lkZXZfcHV0KHN0cnVjdCBwY2lfZGV2 ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgcmVmY250X3B1dCgmcGRldi0+cmVmY250LCByZWxlYXNl X3BkZXYpOw0KPj4gK30NCj4+ICsNCj4+ICAvKg0KPj4gICAqIExvY2FsIHZhcmlhYmxlczoNCj4+ ICAgKiBtb2RlOiBDDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRk L3F1aXJrcy5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL3F1aXJrcy5jDQo+PiBpbmRl eCBmY2M4ZjczZThiLi5kMjQwZGEwNDE2IDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvcGFz c3Rocm91Z2gvdnRkL3F1aXJrcy5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92 dGQvcXVpcmtzLmMNCj4+IEBAIC00MjksNiArNDI5LDggQEAgc3RhdGljIGludCBfX211c3RfY2hl Y2sgbWFwX21lX3BoYW50b21fZnVuY3Rpb24oc3RydWN0IGRvbWFpbiAqZG9tYWluLA0KPj4gICAg ICAgICAgcmMgPSBkb21haW5fY29udGV4dF91bm1hcF9vbmUoZG9tYWluLCBkcmhkLT5pb21tdSwg MCwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ERVZGTihk ZXYsIDcpKTsNCj4+ICANCj4+ICsgICAgcGNpZGV2X3B1dChwZGV2KTsNCj4+ICsNCj4+ICAgICAg cmV0dXJuIHJjOw0KPj4gIH0NCj4+ICANCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92aWRl by92Z2EuYyBiL3hlbi9kcml2ZXJzL3ZpZGVvL3ZnYS5jDQo+PiBpbmRleCAwYTAzNTA4YmVlLi4x MDQ5ZDRkYTZkIDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdmlkZW8vdmdhLmMNCj4+ICsr KyBiL3hlbi9kcml2ZXJzL3ZpZGVvL3ZnYS5jDQo+PiBAQCAtMTE0LDcgKzExNCw3IEBAIHZvaWQg X19pbml0IHZpZGVvX2VuZGJvb3Qodm9pZCkNCj4+ICAgICAgICAgIGZvciAoIGJ1cyA9IDA7IGJ1 cyA8IDI1NjsgKytidXMgKQ0KPj4gICAgICAgICAgICAgIGZvciAoIGRldmZuID0gMDsgZGV2Zm4g PCAyNTY7ICsrZGV2Zm4gKQ0KPj4gICAgICAgICAgICAgIHsNCj4+IC0gICAgICAgICAgICAgICAg Y29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiArICAgICAgICAgICAgICAgIHN0cnVjdCBw Y2lfZGV2ICpwZGV2Ow0KPj4gICAgICAgICAgICAgICAgICB1OCBiID0gYnVzLCBkZiA9IGRldmZu LCBzYjsNCj4+ICANCj4+ICAgICAgICAgICAgICAgICAgcGNpZGV2c19sb2NrKCk7DQo+PiBAQCAt MTI2LDcgKzEyNiwxMSBAQCB2b2lkIF9faW5pdCB2aWRlb19lbmRib290KHZvaWQpDQo+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9DTEFTU19ERVZJQ0UpICE9IDB4 MDMwMCB8fA0KPj4gICAgICAgICAgICAgICAgICAgICAgICEocGNpX2NvbmZfcmVhZDE2KFBDSV9T QkRGKDAsIGJ1cywgZGV2Zm4pLCBQQ0lfQ09NTUFORCkgJg0KPj4gICAgICAgICAgICAgICAgICAg ICAgICAgKFBDSV9DT01NQU5EX0lPIHwgUENJX0NPTU1BTkRfTUVNT1JZKSkgKQ0KPj4gKyAgICAg ICAgICAgICAgICB7DQo+PiArICAgICAgICAgICAgICAgICAgICBpZiAoIHBkZXYgKQ0KPj4gKyAg ICAgICAgICAgICAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgICAgICAgICAg ICAgICAgICBjb250aW51ZTsNCj4+ICsgICAgICAgICAgICAgICAgfQ0KPj4gIA0KPj4gICAgICAg ICAgICAgICAgICB3aGlsZSAoIGIgKQ0KPj4gICAgICAgICAgICAgICAgICB7DQo+PiBAQCAtMTU3 LDYgKzE2MSw3IEBAIHZvaWQgX19pbml0IHZpZGVvX2VuZGJvb3Qodm9pZCkNCj4+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBidXMsIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4p KTsNCj4+ICAgICAgICAgICAgICAgICAgICAgIHBjaV9oaWRlX2RldmljZSgwLCBidXMsIGRldmZu KTsNCj4+ICAgICAgICAgICAgICAgICAgfQ0KPj4gKyAgICAgICAgICAgICAgICBwY2lkZXZfcHV0 KHBkZXYpOw0KPj4gICAgICAgICAgICAgIH0NCj4+ICAgICAgfQ0KPj4gIA0KPj4gZGlmZiAtLWdp dCBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+ IGluZGV4IDZkNDhkNDk2YmIuLjUyMzJmOTYwNWIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVy cy92cGNpL3ZwY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+IEBAIC0z MTcsOCArMzE3LDggQEAgc3RhdGljIHVpbnQzMl90IG1lcmdlX3Jlc3VsdCh1aW50MzJfdCBkYXRh LCB1aW50MzJfdCBuZXcsIHVuc2lnbmVkIGludCBzaXplLA0KPj4gIA0KPj4gIHVpbnQzMl90IHZw Y2lfcmVhZChwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBz aXplKQ0KPj4gIHsNCj4+IC0gICAgY29uc3Qgc3RydWN0IGRvbWFpbiAqZCA9IGN1cnJlbnQtPmRv bWFpbjsNCj4+IC0gICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiArICAgIHN0cnVj dCBkb21haW4gKmQgPSBjdXJyZW50LT5kb21haW47DQo+DQo+IFdoeSBkbyB5b3UgbmVlZCB0byBk cm9wIHRoZSBjb25zdCBvbiBkb21haW4gaGVyZT8NCj4NCg0KTG9va3MgbGlrZSBsZWZ0b3ZlciBm cm9tIGEgcHJldmlvdXMgdmVyc2lvbi4gV2lsbCByZW1vdmUuDQoNCj4+ICsgICAgc3RydWN0IHBj aV9kZXYgKnBkZXY7DQo+PiAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX3JlZ2lzdGVyICpyOw0KPj4g ICAgICB1bnNpZ25lZCBpbnQgZGF0YV9vZmZzZXQgPSAwOw0KPj4gICAgICB1aW50MzJfdCBkYXRh ID0gfih1aW50MzJfdCkwOw0KPj4gQEAgLTMzMiw3ICszMzIsMTEgQEAgdWludDMyX3QgdnBjaV9y ZWFkKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IHNpemUp DQo+PiAgICAgIC8qIEZpbmQgdGhlIFBDSSBkZXYgbWF0Y2hpbmcgdGhlIGFkZHJlc3MuICovDQo+ PiAgICAgIHBkZXYgPSBwY2lfZ2V0X3BkZXYoZCwgc2JkZik7DQo+PiAgICAgIGlmICggIXBkZXYg fHwgIXBkZXYtPnZwY2kgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBpZiAoIHBkZXYgKQ0KPj4g KyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiAgICAgICAgICByZXR1cm4gdnBjaV9y ZWFkX2h3KHNiZGYsIHJlZywgc2l6ZSk7DQo+PiArICAgIH0NCj4+ICANCj4+ICAgICAgc3Bpbl9s b2NrKCZwZGV2LT52cGNpLT5sb2NrKTsNCj4+ICANCj4+IEBAIC0zNzgsNiArMzgyLDcgQEAgdWlu dDMyX3QgdnBjaV9yZWFkKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywgdW5zaWdu ZWQgaW50IHNpemUpDQo+PiAgICAgICAgICBBU1NFUlQoZGF0YV9vZmZzZXQgPCBzaXplKTsNCj4+ ICAgICAgfQ0KPj4gICAgICBzcGluX3VubG9jaygmcGRldi0+dnBjaS0+bG9jayk7DQo+PiArICAg IHBjaWRldl9wdXQocGRldik7DQo+PiAgDQo+PiAgICAgIGlmICggZGF0YV9vZmZzZXQgPCBzaXpl ICkNCj4+ICAgICAgew0KPj4gQEAgLTQyMCw4ICs0MjUsOCBAQCBzdGF0aWMgdm9pZCB2cGNpX3dy aXRlX2hlbHBlcihjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+ICB2b2lkIHZwY2lfd3Jp dGUocGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgc2l6ZSwN Cj4+ICAgICAgICAgICAgICAgICAgdWludDMyX3QgZGF0YSkNCj4+ICB7DQo+PiAtICAgIGNvbnN0 IHN0cnVjdCBkb21haW4gKmQgPSBjdXJyZW50LT5kb21haW47DQo+PiAtICAgIGNvbnN0IHN0cnVj dCBwY2lfZGV2ICpwZGV2Ow0KPj4gKyAgICBzdHJ1Y3QgZG9tYWluICpkID0gY3VycmVudC0+ZG9t YWluOw0KPj4gKyAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldjsNCg0KLS0gDQpXQlIsIFZvbG9keW15 cg0K From xen-devel-bounces@lists.xenproject.org Wed Apr 12 02:51:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 02:51:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520025.807220 (Exim 4.92) (envelope-from ) id 1pmQZk-00018l-7A; Wed, 12 Apr 2023 02:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520025.807220; Wed, 12 Apr 2023 02:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmQZk-00018d-1D; Wed, 12 Apr 2023 02:51:12 +0000 Received: by outflank-mailman (input) for mailman id 520025; Wed, 12 Apr 2023 02:51:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmQZi-00018T-PF; Wed, 12 Apr 2023 02:51:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmQZi-0002gq-I0; Wed, 12 Apr 2023 02:51:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmQZi-0007l4-1U; Wed, 12 Apr 2023 02:51:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmQZh-00036I-WD; Wed, 12 Apr 2023 02:51:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YjnMIFcgKr1sN1zkHM6fwNbRt2MIYv9HW2gISw40VZY=; b=AV2qCwnIA3DnEqaJTeJGg4q0Un EkME3w6DZFaV8C1P22kFe+Dx8nD+Yeskqm8LqzckjXBIpoX0gEcBlUEFJRM/5mEcNf9A/poSY+vXM yiB1ltX4bCrVWNc/QdNXRxvbAkCv7vJryARdQPM+CptSEJ6EaovQKYzbJKW57iwiA/Nk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180206: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f X-Osstest-Versions-That: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 From: osstest service owner Date: Wed, 12 Apr 2023 02:51:10 +0000 flight 180206 xen-unstable real [real] flight 180210 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180206/ http://logs.test-lab.xenproject.org/osstest/logs/180210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 180200 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 180187 test-amd64-i386-xl-xsm 7 xen-install fail like 180200 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180200 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180200 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180200 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180200 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180200 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f baseline version: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 Last test of basis 180200 2023-04-11 01:53:29 Z 1 days Testing same since 180206 2023-04-11 14:37:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 5ea03c570c8610d4359f8bbf5f093d215344ce3f Author: Julien Grall Date: Mon Mar 27 19:45:20 2023 +0100 xen/x86: Replace GPL v2.0+ license boilerplate with an SPDX tag in *.h It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-or-later in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; If not, see . Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Jan Beulich commit f68674efb79745cbcb80f333f1f1bd3007ad9f1e Author: Julien Grall Date: Mon Mar 27 19:45:19 2023 +0100 xen/x86: Replace GPL v2.0+ license boilerplate with an SPDX tag in *.c It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-or-later in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; If not, see . Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Jan Beulich commit 406f0f593ef33f67e64f96c3742fecf20b341b3e Author: Julien Grall Date: Mon Mar 27 19:45:18 2023 +0100 xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.h (part 3) It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU General Public * License, version 2, as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this program; If not, see . Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Jan Beulich commit 0f10cd10f44b0868194071865f7ec3aac0aed2b2 Author: Julien Grall Date: Mon Mar 27 19:45:17 2023 +0100 xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.h It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; If not, see . Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Jan Beulich commit 831a1c2da01f13bf66b2922896abd37f94aecddb Author: Julien Grall Date: Mon Mar 27 19:45:16 2023 +0100 xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c (part 3) It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU General Public * License, version 2, as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this program; If not, see . Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Jan Beulich commit fc269f81fd6535392bbb8ac14360ce705d7d8e27 Author: Julien Grall Date: Mon Mar 27 19:45:15 2023 +0100 xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; If not, see . Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Jan Beulich commit a778dbdf443d81d30eed802018ecd498b8dd043f Author: Julien Grall Date: Mon Mar 27 19:45:14 2023 +0100 LICENSES: Clarify that the SPDX tag GPL-2.0 is deprecated From https://spdx.org/licenses/GPL-2.0.html, the SPDX tag GPL-2.0 is deprecated. Instead, GPL-2.0-only should be used. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Apr 12 05:39:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 05:39:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520036.807239 (Exim 4.92) (envelope-from ) id 1pmTCh-0000dt-Cl; Wed, 12 Apr 2023 05:39:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520036.807239; Wed, 12 Apr 2023 05:39:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTCh-0000dm-9q; Wed, 12 Apr 2023 05:39:35 +0000 Received: by outflank-mailman (input) for mailman id 520036; Wed, 12 Apr 2023 05:39:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTCg-0000df-I0 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 05:39:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65eef55e-d8f4-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 07:39:32 +0200 (CEST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-JQc_aQzRMJS6h635kSrpkA-1; Wed, 12 Apr 2023 01:39:29 -0400 Received: by mail-ej1-f71.google.com with SMTP id r12-20020a1709062ccc00b0092fce91a838so3594910ejr.20 for ; Tue, 11 Apr 2023 22:39:29 -0700 (PDT) Received: from [192.168.8.105] (tmo-096-44.customers.d1-online.com. [80.187.96.44]) by smtp.gmail.com with ESMTPSA id s21-20020a1709060c1500b0094a85f6074bsm2889674ejf.33.2023.04.11.22.39.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 22:39:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65eef55e-d8f4-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681277971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VHCdvDKrd6SHmT5+4IxRxVZw2qNaGEXhrgpsq6j6904=; b=alIzvP4R9DRwmMLLw7sGq/zhvb+mNNzrNWSmktRTobBXyGMOYn/V+z5Rx/rwKxdm0iHuUF K5IOgv7R9DepU+b+9mdUkAd1J3SlFA7hxG6hHDjwVGM3w2TzX2KPwMRQOXI+HzGtspUnWW UireaiFfk84teqvuOMiHa6wEJzaMHPA= X-MC-Unique: JQc_aQzRMJS6h635kSrpkA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681277968; x=1683869968; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VHCdvDKrd6SHmT5+4IxRxVZw2qNaGEXhrgpsq6j6904=; b=bLh1A+/knq2m7I4kEW5oKh73VQf6lkLeB37+6v2z5jxb/Znc3j1sCaB90VnAmiv3vo zX5MSn48Iu80WF1t44v77SEwItqS6D8HNkZmHLCKVhtPC80eawXrPgR9yhRBKDvIWTyg XyP2EMQ6WCscg95gc1uGCE79R4vsCgSMhnQ2F7n+NeT/Z0EbCAQyIbUNRp8paWuj4s5w HZdm1IwU6xWhZybfevlKz3rAXe1re1CJqpTG/3w0rbRikJZ9eG+DQ8Uc7OZfb+P4M02I 5bvsL9TZnj5fexPk7sQm3+0a7n1RqocG41KZd+MHSJ1fZNIGQfbnw8kzCc2okcJw+RYo uuSA== X-Gm-Message-State: AAQBX9fXNIaqp1Gzk9jYwkMPbTH7twl5/8I/uDpthZ/Pqi9Y9IIFIUtG 8FUtxpsjU8iFPsmT6BYzMieZwcdRoQrCJVtX5Gma6TaAkntPfacn1QcJY9/vV/pjcmYZ98NCOsN UoK4hG1XtXaonJlYcsnUVztPHC/o= X-Received: by 2002:a17:906:1401:b0:94e:5224:b21e with SMTP id p1-20020a170906140100b0094e5224b21emr1134981ejc.14.1681277968556; Tue, 11 Apr 2023 22:39:28 -0700 (PDT) X-Google-Smtp-Source: AKy350aiVhpgQoLUs6/2V6EcX+z/iUJaQs6ANB2YdA1maYchDM3UA/NUeo7RWULN8e+iRtBMgK9+FQ== X-Received: by 2002:a17:906:1401:b0:94e:5224:b21e with SMTP id p1-20020a170906140100b0094e5224b21emr1134974ejc.14.1681277968264; Tue, 11 Apr 2023 22:39:28 -0700 (PDT) Message-ID: <895bcdd3-350d-38e7-1982-899948072b93@redhat.com> Date: Wed, 12 Apr 2023 07:39:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, =?UTF-8?Q?Alex_Benn=c3=a9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Wainer dos Santos Moschetta , Beraldo Leal References: <20230411210422.24255-1-vikram.garhwal@amd.com> From: Thomas Huth In-Reply-To: <20230411210422.24255-1-vikram.garhwal@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/04/2023 23.04, Vikram Garhwal wrote: > Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the > build for aarch64 target. > > Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html > > Signed-off-by: Vikram Garhwal > --- > .gitlab-ci.d/crossbuilds.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > index 61b8ac86ee..6867839248 100644 > --- a/.gitlab-ci.d/crossbuilds.yml > +++ b/.gitlab-ci.d/crossbuilds.yml > @@ -186,7 +186,7 @@ cross-amd64-xen-only: > variables: > IMAGE: debian-amd64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm > > cross-arm64-xen-only: > extends: .cross_accel_build_job > @@ -195,4 +195,4 @@ cross-arm64-xen-only: > variables: > IMAGE: debian-arm64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm This patch looks wrong. I'm pretty sure we wanted to test the build without TCG here. Building with TCG enabled is already done in other jobs. So instead of removing "--disable-tcg" here the question is rather: Why does it not build with this flag anymore? Can those problems be fixed instead? Thomas From xen-devel-bounces@lists.xenproject.org Wed Apr 12 06:17:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 06:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520042.807248 (Exim 4.92) (envelope-from ) id 1pmTnR-00055q-F2; Wed, 12 Apr 2023 06:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520042.807248; Wed, 12 Apr 2023 06:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTnR-00055j-CP; Wed, 12 Apr 2023 06:17:33 +0000 Received: by outflank-mailman (input) for mailman id 520042; Wed, 12 Apr 2023 06:17:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTnP-00055Z-QG; Wed, 12 Apr 2023 06:17:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTnP-0007mi-Nu; Wed, 12 Apr 2023 06:17:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTnP-0008RC-7Y; Wed, 12 Apr 2023 06:17:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmTnP-0002Hi-76; Wed, 12 Apr 2023 06:17:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YVJ9R5lxIqSYVV0OeV9+lAmJP3BxA+AKRho7KzIBlBw=; b=ixb7Wsw0ecvnjrgiYQFN8q6+Dk 0D0Apt19hoXQ/vuMuSjd+eJwCo6EENDOzcJvQqQU6a5awbOEx6i0+bZZ33XhjYrN7SUxx5JKK/CGr F8D49nUC+7CZPjJMe+igomBeQy1y2S2xg/H12Kv7fVg0du04p0zG/7bboAXZWme5GR1Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180207: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=6c50845a9183610cfd4cfffd48dfc704cd340882 X-Osstest-Versions-That: qemuu=dda860b9c031d6a2768f75e5e622545d41d4b688 From: osstest service owner Date: Wed, 12 Apr 2023 06:17:31 +0000 flight 180207 qemu-mainline real [real] flight 180215 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180207/ http://logs.test-lab.xenproject.org/osstest/logs/180215/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 180215-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180215-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180204 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180204 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180204 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180204 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180204 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 6c50845a9183610cfd4cfffd48dfc704cd340882 baseline version: qemuu dda860b9c031d6a2768f75e5e622545d41d4b688 Last test of basis 180204 2023-04-11 09:38:32 Z 0 days Testing same since 180207 2023-04-11 18:40:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git dda860b9c0..6c50845a91 6c50845a9183610cfd4cfffd48dfc704cd340882 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Apr 12 06:22:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 06:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520048.807259 (Exim 4.92) (envelope-from ) id 1pmTrc-0006Vy-0p; Wed, 12 Apr 2023 06:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520048.807259; Wed, 12 Apr 2023 06:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTrb-0006Vr-U6; Wed, 12 Apr 2023 06:21:51 +0000 Received: by outflank-mailman (input) for mailman id 520048; Wed, 12 Apr 2023 06:21:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmTra-0006Vj-Vb for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 06:21:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0c::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e0e0f21-d8fa-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 08:21:48 +0200 (CEST) Received: from AM6PR04CA0068.eurprd04.prod.outlook.com (2603:10a6:20b:f0::45) by PAXPR08MB6544.eurprd08.prod.outlook.com (2603:10a6:102:157::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 06:21:46 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::64) by AM6PR04CA0068.outlook.office365.com (2603:10a6:20b:f0::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Wed, 12 Apr 2023 06:21:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Wed, 12 Apr 2023 06:21:45 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Wed, 12 Apr 2023 06:21:45 +0000 Received: from 3dd2b681c351.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 802509AA-3554-47F9-BF16-535B220D3E67.1; Wed, 12 Apr 2023 06:21:36 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3dd2b681c351.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Apr 2023 06:21:36 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB5520.eurprd08.prod.outlook.com (2603:10a6:803:135::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 06:21:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6277.034; Wed, 12 Apr 2023 06:21:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e0e0f21-d8fa-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3pOZzwPMMV1DuJnSfPi/4WZieEoZhtGCWT5AFri2azU=; b=nm+QF3bsYc0vNf4C+gVWneVgJDy0Sq/KA+A3AIFM4n8go09/lJ4Rdn6CUN44fc1uPq42MyoEWkeNlgwzxxHY253mY/QjHnzQnhhKVUKXmA3JudMzxuox7czk8lO8kK82OalfxwJKCsFBiAoXVuOjhbYwh/3hTwBhdqR2qQkTCjU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5fdIfojZSLOEm8yVjlvrglenTFRKAnLe4InAyul0DxS5c7xj5p266IGRD+s8eB/t2Y6hev0ZQlbWNDWGBHPNxp4yfNzP8q4O86MzPSCmr2W6j9WeOGhOsWQhIc/KHtuw/JPCfMky4ClBd4RdZlod2wtGFb+N8b9IHJozXDxb+6g2DzgdxybbZSzKcSZWCqNDxYXyjz6jrADoKCkQcPA0UNgO0zQrJRgEp4cGOj2RR2IQc8uJiUYk0ItncegTEUpbTga6Pfwc3WGOJCaxLKEayAqS+gAV/6Xa1QtZVLFT9PgyMjt1EFlO9stQnZbIhr6IV81pPert3zR67VlPU6X+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pOZzwPMMV1DuJnSfPi/4WZieEoZhtGCWT5AFri2azU=; b=OJPgqgWY4566BH2p7ZGP2/XgrSKonYA0YqqG0utqf3bhN+cbHZ63bwnspB0HZdtzAewsXjWZBgCaZo9QxaHlrnClBBkmdvLoEsd66Odw0aAx7mHJBWdr0k6S03g/FT2QVd9o9mJcXjFgVL8CZKkSojb/0NLIFDoHe/vUBsbmCaYf9lRtwACanX/1QqyA4S02SiU4eqQSLb6hjJ5aYD5y5+4NCE5jjQCwnyCAjrk/2IgLVyf73+l90zqY7ovNdBKGyOv6ogdT2T4xF3HBFxwDBKs14sxPyGxJ4gwOBkMZ/TXU3CrRtguyYLVsvvMHlLmrK4cxk+TvHA/pAIxtascrDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3pOZzwPMMV1DuJnSfPi/4WZieEoZhtGCWT5AFri2azU=; b=nm+QF3bsYc0vNf4C+gVWneVgJDy0Sq/KA+A3AIFM4n8go09/lJ4Rdn6CUN44fc1uPq42MyoEWkeNlgwzxxHY253mY/QjHnzQnhhKVUKXmA3JudMzxuox7czk8lO8kK82OalfxwJKCsFBiAoXVuOjhbYwh/3hTwBhdqR2qQkTCjU= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments Thread-Topic: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments Thread-Index: AQHZZ7BiVWY3mibtKkuaZtbP8Fag3a8nPoCg Date: Wed, 12 Apr 2023 06:21:29 +0000 Message-ID: References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-2-michal.orzel@amd.com> In-Reply-To: <20230405111750.12491-2-michal.orzel@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F07AB8ADDB37B84AB094A345987E9277.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VI1PR08MB5520:EE_|AM7EUR03FT052:EE_|PAXPR08MB6544:EE_ X-MS-Office365-Filtering-Correlation-Id: 92ac399f-3749-43ba-a29d-08db3b1e30b0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MTM5EREg8xJPMRv05d1Io9TWxqNSPdPhZZ72t4Xey47EVl4SQKvKfMI6jfagdwHf4n83qKiZ4VOt4KbCi6tbtCeCtMlv7mfVBOiRrbBZWNNsRQvVRu3dMT12ChgJowoAFCcooaWxO5NKzhkv50pqIbN5KA97SnZ2Ls3oI200HkFxUdvH21MRKTpSPlnh2ONlWVHu0+EhTio+u3r6ZyyRAMtj7KJqiZJIpco4HTWgzZl8syyKBRQ4fTstEKejuvs+Efu0rek959RfYUGgNTy2koiK7v6Ixh3xAq2IQm3sRRLxtO5XfGqekaaBoDKe5YQItjXMREcr0o/r4Zplse2Le+sxCdwPsLd9H+irtMNmJAHJbJOPmckXqXPklVC/1Ab4WE0irW/6/nJhnRosH/nSP067sg4zkJmtHvsinrB8YE+VUIgLqs9+a6YhkWLtVC2sRv2ZFqw94uQJcTJU8PUvtmX0STYM0EYUghYNBFGqtDqaDd2M7zZ511QTbA9PL9C1YF08sBPEdGmR5zz1LUh/VmG0gCx7Ftw7qV6yWLexcxlHF2wU0NkBIurryA53RbJl/BX0o9gCCzE8lLwAn7/WGto14E2+VJqFwcQ/SgAg/A/p0X7m4whQu+TUmAUoXO0U X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199021)(71200400001)(478600001)(7696005)(26005)(316002)(110136005)(6506007)(186003)(5660300002)(54906003)(9686003)(4744005)(2906002)(4326008)(66446008)(66946007)(76116006)(8676002)(64756008)(66476007)(41300700001)(66556008)(52536014)(8936002)(122000001)(55016003)(86362001)(83380400001)(33656002)(38070700005)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5520 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: edcebe21-1819-479b-3240-08db3b1e2733 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ja222fkM5Pqy7lZJm79fuDaupKXC1qmcSMvtB5f0HYpgWfAINItbKeNhU+YvDoQlpysMS0K4LbLSkRwPZ6V6nRdA4TWVrw8bRRtHyxZhQ3iUEzd1JrIyEnH5Bn5thVqn79V4Sf0DsXMMyy6ypS5Q6bZYQ/24WY51SLrf125zDxN0KNobJByH1TtcqhXeq0X1V/YNDb7KdhK0h8VLx2ZSYLGzwzGVetX2R25FgE73CGnsn05t6VbPLB7GzS5yAm0vkUXxGElcsFYT9NsMFFZWxjjVPG/bCTLqtMwpgI562oOAqJ5FA5l1tEL34gKVWQnO1KGpyWwrUb0IzGEIFLmCT2OoVRZ53BHpm++3oxKyXjfIhRg3G1tzNeohm7EO0QfqEjogNe4sM8aErzgWFazVgNfNHpfthg+IqWhxt1ml+Az1NmxCiab9xemxLRELdxqQI52iw114+4KiTBYMqRFWae0egPvF47C99DBIRw0JJ+Yu5NQVUUdPhtzvvXFeM51rz/ezwUvZeMaX0Q41MZNUh6sME4yd9QEX+DNgiUGwzwiLlmdpMB4O8XkeAbPCTYslUU5ATIdYPRvsrZtpSfWE+tUjl8da7Lf2A0cE+Cn9Wpm4xHbhLJuSv2tZ5mxjajMCrS55qQBbmpXM4kbA09BGPGolYUVY8N5g+bTPA12R+SbguLsqlc+suQgJXSvJ+EfjfzJkG9oOGsqT5AT2J4HzaQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199021)(46966006)(36840700001)(40470700004)(82740400003)(83380400001)(478600001)(82310400005)(47076005)(316002)(110136005)(54906003)(356005)(81166007)(107886003)(36860700001)(186003)(40480700001)(9686003)(6506007)(26005)(55016003)(336012)(7696005)(33656002)(40460700003)(41300700001)(8676002)(8936002)(4326008)(70206006)(70586007)(4744005)(2906002)(86362001)(52536014)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 06:21:45.4372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92ac399f-3749-43ba-a29d-08db3b1e30b0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6544 Hi Michal, > -----Original Message----- > Subject: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments >=20 > In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment > stating that the guest is expected to read the DR register only if the > TXFE bit of FR register is not set. This is obviously logically wrong and > it should be RXFE (i.e. RX FIFO empty bit set -> nothing to read). >=20 > Signed-off-by: Michal Orzel Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Wed Apr 12 06:56:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 06:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520054.807272 (Exim 4.92) (envelope-from ) id 1pmUOf-0001WX-KQ; Wed, 12 Apr 2023 06:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520054.807272; Wed, 12 Apr 2023 06:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmUOf-0001WQ-Hb; Wed, 12 Apr 2023 06:56:01 +0000 Received: by outflank-mailman (input) for mailman id 520054; Wed, 12 Apr 2023 06:56:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmUOe-0001WK-Iy for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 06:56:00 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12cf5f27-d8ff-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 08:55:56 +0200 (CEST) Received: from AS4PR10CA0030.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::11) by AS2PR08MB8381.eurprd08.prod.outlook.com (2603:10a6:20b:558::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 06:55:20 +0000 Received: from AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d8:cafe::62) by AS4PR10CA0030.outlook.office365.com (2603:10a6:20b:5d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Wed, 12 Apr 2023 06:55:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT057.mail.protection.outlook.com (100.127.140.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Wed, 12 Apr 2023 06:55:19 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Wed, 12 Apr 2023 06:55:19 +0000 Received: from 8ce5651f1bbc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4343D40D-5391-4EEA-8F3E-466E5BA9F7B3.1; Wed, 12 Apr 2023 06:55:13 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8ce5651f1bbc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Apr 2023 06:55:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB9817.eurprd08.prod.outlook.com (2603:10a6:102:31d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 06:55:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6277.034; Wed, 12 Apr 2023 06:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12cf5f27-d8ff-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iVWSCWaPCaSF2F5CYJf465h0SbWQLJccfkSY+GBw/Bc=; b=bP7iWe/TLAJ6UpL96lDBW9EFwcNXHKigvl+DisnWf+2c4KvO787DgH3J3P+xRwgCTWxDme5fZPBmU35XS0/e17vyi9IwsgH/GylZuvYdcMAouiSHKtRfbnQza62Lzm5QqMlXSJ6kiYw916/t++5Ewx97dev85+cbM7GX/bkmHSQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKHN3oBp9P3+6EHVHS5ZEXDL0F7wNLgdr3HWV0kq3Ip20LhJyu7D+dZLjoTTc13RJtUMqrewef5LzQquDnMt5vOpS1ZzTBW362EApfoDxBFrSGfV2TEYqxLs5q5hf7Lx7A80UiU7+XVLRIEaNVFJMpoRSPMUzUUH6hr6RffwiSOVB7O/MfqTKAJSPhLQtAOiJ6eWQBswKsiF3kcGiyTKUaZEsN70FxqqrNPtKcM+1xLlYPqxDLamsGdlrqDnfx9VCZyKTzPNQ0UkIVsUHXWDXRevirONE4DDsM3jfuWV51X6b4xOiEr8fYGBzObD9iYbIHG7IF8QdiWlbMKd75bImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iVWSCWaPCaSF2F5CYJf465h0SbWQLJccfkSY+GBw/Bc=; b=QvBCQV1mY19LAH0LB9i7KUq8Cfuc1PeT6Ck7Ex+8vhyzoKXL8CRzrSe7M6RFIOplwd4kT6cnEMMptegnaPfIUlkbIvfFljaAzRqRUEX+L5W443/u9AE/apGoM9PJsxWrfeySIwiCLSOPrZjQuMnozv3yJ6PpaPL5ulR0zju9K3pgFHrcpR211Ms0mjnXM4ndj+jNGK39JvN5ckFvYek4R9BAFoghZsxPLh+6kzXJwo9m8S7OyM4ZcDLSW0FL+no31JUOw9ykwj41PM3GlDmB/ZfpznJMDn7BuGDFi4fylvWv4MxifQBIEV1Wb5XpwcKJNuj1jMJPXW6UtT2coPIrUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iVWSCWaPCaSF2F5CYJf465h0SbWQLJccfkSY+GBw/Bc=; b=bP7iWe/TLAJ6UpL96lDBW9EFwcNXHKigvl+DisnWf+2c4KvO787DgH3J3P+xRwgCTWxDme5fZPBmU35XS0/e17vyi9IwsgH/GylZuvYdcMAouiSHKtRfbnQza62Lzm5QqMlXSJ6kiYw916/t++5Ewx97dev85+cbM7GX/bkmHSQ= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen Thread-Topic: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen Thread-Index: AQHZZ7BhM9d/TecBu020qzDpPrY4KK8nPD6g Date: Wed, 12 Apr 2023 06:55:11 +0000 Message-ID: References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-4-michal.orzel@amd.com> In-Reply-To: <20230405111750.12491-4-michal.orzel@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 49045ABDCBE97E4392E7DD52327A3008.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAVPR08MB9817:EE_|AM7EUR03FT057:EE_|AS2PR08MB8381:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f2fe3dd-53db-4226-d4a0-08db3b22e11e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TsNLowLfNpIpfZDhOUqRdxL8C5E+rw+oA3rmqR7Avw55gYVYgAkpkF1NKYe9eBmfVTw0DmIx40RHxwICLGEbS32zUWjEKcKVWBqJ3DscUYWXIRU36avbzsdOK4PQXltaN45ksU2C9hFzzrBJ8w4ggo4u9D4yjuccctdr2sajiaQ6gp8VdKR1pVWEL0B0uI0ZTiKwARW63yGcziMvEiX7O//DTbeLPtrl2yKZDxG9LPn+ckE3vnxSFaOGoM2NrVZC/bpk1hYMVBZxWzJpdNh8l5mNSGqTFdh9KD8PLrImhJztvtLM8yMWhPxoR4jZ4nglKtFvTu3lYl1B2Pa4/dT4BAg/WvB6SCngrM0ej6FaNYznml1WiteiR0kpChkvinfP2YRnM+M782dzmZ8asrKYnoVCDHv3wbKMIBXthW0DDHSFU6ndbTo2fUjhKMc+mw+6j3zDrzskogW4SgPQUddEQ7A+qrTNwJlvldmajmBZOoeEIHoH4aH4W2EPDudPIiwDJBWNRUjAaz+FwsvD3z8dKVsHlI+1psHMKwbMwTHf8El3CykMeu/kIhbn5M7qAV0SQz4ut0k3KYgkJ9YdAJmK59aGYSPDDwVCQdX6tcckUJtPvnoJO8XnyE+ir1lN8T1x X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199021)(66476007)(8676002)(66446008)(4326008)(7696005)(66556008)(64756008)(71200400001)(66946007)(76116006)(54906003)(478600001)(41300700001)(110136005)(316002)(33656002)(86362001)(83380400001)(9686003)(6506007)(26005)(8936002)(2906002)(5660300002)(55016003)(38070700005)(38100700002)(186003)(52536014)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9817 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 51587d48-102d-4b71-0f5c-08db3b22dc25 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /3jL306WTHXVGJvhmWF9fjkTKkn/X3n+LHl+nZDblk8Xvg0uMf8qoIuSWm/h65CerlOZPpdrCTVO7tYEIzVRIc0qdDhr8MA8Oysa0DKEY73mCxhl8J89xq+39Ew/HC2CpFmzdw4rj/5vVoGvGkTMq7vA7/xw/8bDr6E7jFgh8DvKA5KfIdCM1w2N/uzm7Lq/ol0DndTpVCpbaNt3wVCsfkDsxkA2PrU9/rERL1SHtGlohQwNrpjQR2s43KPToPkQvmU30gu8pa80k5kNxBRqRQNQuB//UijrF4mC6gq/qrxzIyrCQbuAbPMr3qVSqZf5BKBOnCcCqzHwQrP9GXVD5s/urORK+MlyUFCjG7PDEjPKTtWz/55l4k5fizIbm6aHBNqbD2/ZZvIjWecZPyTlISf7dkqTYXTNsQODZmpw5JzH2PC0Qsee5j8JqO2dmKWM0OhXUmWRzAwtaTLAHMSBIqpW5BCxubAzwBZ4tjl+ran5Wuix8mi9+3w+FRBiDCA7B1StOFcA/Ul980chqwbdXCkm4ucgpKqeFufLcu6cLsJb/c5ePYlwLVfAo6tSdzraO9eQYfViI+JByeUC3qEtnP/jseqzvr42E66EI43uaxr54tWhckypVzxR8FV0BaDZAG7KH6eDEGHxkj3siPpRa33E/EQKFxvwgeyeGY/ILwFmBWGX5WjcMT8WciG2n3QNCdhu7t8XfRKttw4/xktNlQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(36840700001)(40470700004)(46966006)(478600001)(7696005)(40460700003)(86362001)(83380400001)(33656002)(55016003)(40480700001)(81166007)(356005)(82740400003)(47076005)(336012)(36860700001)(2906002)(26005)(316002)(110136005)(6506007)(54906003)(9686003)(186003)(5660300002)(82310400005)(107886003)(8936002)(52536014)(41300700001)(8676002)(4326008)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 06:55:19.4253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f2fe3dd-53db-4226-d4a0-08db3b22e11e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8381 Hi Michal, > -----Original Message----- > Subject: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status > when backend in Xen >=20 > From vpl011_rx_char_xen(), we call vpl011_data_avail() that handles both > RX and TX state. Because we are passing 0 as out_fifo_level and > SBSA_UART_FIFO_SIZE as out_size, we end up calling a function > vpl011_update_tx_fifo_status() which performs TXI bit handling > depending on the FIFO trigger level. This does not make sense when backen= d > is in Xen, as we maintain a single TX state where data can always be > written and as such there is no TX FIFO handling. Furthermore, this > function assumes that the backend is in domain by making use of struct > xencons_interface unconditionally. Fix it by calling this function only > when backend is in domain. Also add an assert for sanity. >=20 > Signed-off-by: Michal Orzel I've tested the patch by manually running the XTP on FVP_Base, and this patch works fine. So: Tested-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Wed Apr 12 07:18:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 07:18:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520059.807281 (Exim 4.92) (envelope-from ) id 1pmUk7-000475-Dr; Wed, 12 Apr 2023 07:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520059.807281; Wed, 12 Apr 2023 07:18:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmUk7-00046y-B9; Wed, 12 Apr 2023 07:18:11 +0000 Received: by outflank-mailman (input) for mailman id 520059; Wed, 12 Apr 2023 07:18:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmUk5-00046s-Io for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 07:18:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7e1b::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c638a7e-d902-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 09:18:08 +0200 (CEST) Received: from DB8PR06CA0018.eurprd06.prod.outlook.com (2603:10a6:10:100::31) by DBBPR08MB6315.eurprd08.prod.outlook.com (2603:10a6:10:209::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Wed, 12 Apr 2023 07:18:00 +0000 Received: from DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::31) by DB8PR06CA0018.outlook.office365.com (2603:10a6:10:100::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Wed, 12 Apr 2023 07:18:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT012.mail.protection.outlook.com (100.127.142.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Wed, 12 Apr 2023 07:18:00 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Wed, 12 Apr 2023 07:18:00 +0000 Received: from 7d22e4c8651a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DEB2799E-E68B-4E4C-A210-5916B48206A0.1; Wed, 12 Apr 2023 07:17:49 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7d22e4c8651a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Apr 2023 07:17:49 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB9684.eurprd08.prod.outlook.com (2603:10a6:10:460::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Wed, 12 Apr 2023 07:17:45 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6277.034; Wed, 12 Apr 2023 07:17:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c638a7e-d902-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Fnve0Ztn4Wjfr4f/V2rjsT2NHcKUk9HKR+bwZFLvtc=; b=CAqdnEz25wKZE4gSHr90pjg5KnXY3kQEG0gaVO0v3dJMYF1lNr3RZwVdf+fSmLts2iUbCNy5AbiXgilcNoq8OghVcVpzNKZvcCQM9IFJcITjV3J2yW+CJW6WFFCbzz5L6ZWCp31AQj9D9ntMwUf9Z10iaJ/XKdBVu2eko3fOnIM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J1crUVwBDPTW1NvxRDV5eMksN6QeaD8uO3cmHDY0LWsYuCRlUflwn0Yu/jYpyqED2+9E/OQaqtA+cgHOVy7VE4gSTRKTkWjagZPzoeVqIhAgiMyy3VR4cyl4k69DWW0cblcsvbiF+mX2JrmYk+xgZv4AXMBx62DRt/HCRTTbPruC1C2iXHgu6g/LRWXKkSf5AzzSafkTSShH10hpziOU+7flaRW+1CcFbnMp6nPqD8y+W+7ne6cGD6EJyYc07AcUa3kALETaMXjAvnQOLdUAeVxSNgSvDSNEe5FNdj3XXYlqnDk0GjAjZeqa83bJNaK1A3VeO9I5B+T9eew16DVykQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Fnve0Ztn4Wjfr4f/V2rjsT2NHcKUk9HKR+bwZFLvtc=; b=EfCwq65pgHkLjORH9b+qT3uYCSFr34Z5cjX/cHJMAKSxq8f2e+2vqUsPyP3Ol33vYrHepexNNOG6tKcaL7mJf9932RsBQbof6JGtlIfVso2/08ojBBCUlCb6oqOHMhy3FgMxUv3S5IYBeMPSlUsUO+c11d1iMDHS82mda5cWGHJ+RsJAQ7PNBiPxBKU2v4QgodAdQ178yXrvVkeYOo5j//8/Hxj33ikGv3ED7JBY+sSpk8wAP4oD7pjrFDANzVdoqaQWVDPPYRBlIxYR0+nkCcy99tGTB6bYHMhbnHjIEfEdDyZVgFhiTe0FCd6XTLD3oYsWb7q73x4Fucv99QzIYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Fnve0Ztn4Wjfr4f/V2rjsT2NHcKUk9HKR+bwZFLvtc=; b=CAqdnEz25wKZE4gSHr90pjg5KnXY3kQEG0gaVO0v3dJMYF1lNr3RZwVdf+fSmLts2iUbCNy5AbiXgilcNoq8OghVcVpzNKZvcCQM9IFJcITjV3J2yW+CJW6WFFCbzz5L6ZWCp31AQj9D9ntMwUf9Z10iaJ/XKdBVu2eko3fOnIM= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 2/3] xen/arm: vpl011: Handle correctly TXFE when backend in Xen Thread-Topic: [PATCH 2/3] xen/arm: vpl011: Handle correctly TXFE when backend in Xen Thread-Index: AQHZZ7BjfTPA7ZSpsEidFkEBoEBCAa8nPfIg Date: Wed, 12 Apr 2023 07:17:45 +0000 Message-ID: References: <20230405111750.12491-1-michal.orzel@amd.com> <20230405111750.12491-3-michal.orzel@amd.com> In-Reply-To: <20230405111750.12491-3-michal.orzel@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D65879B074B6EA42AC8C56E519FC8DAF.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB9684:EE_|DBAEUR03FT012:EE_|DBBPR08MB6315:EE_ X-MS-Office365-Filtering-Correlation-Id: 337f0675-ee7f-4aec-d694-08db3b260c3b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oxrzO5H0Ik6PQI3RZJlN0xOz/FZxQISaBcqoCEGlcFtjFw2vllvb+0iIGYh4xqtQCBxF+5ND610YK2ykqtbBeT02NaEPSTg0T410fF9UvbiAYKsN0ptbSMPEN5SSiH0Or1+J7juSdl6OFF8MtL6prNUI8sA7u6vmABgVJlpEPis6mWIEYyUs66+dGyuldF3UGfQ+lf2JajawnZvI1dXyhZgieljcX0vDMqLcxVqHSfyRH3OTQvwBpkEh0g5ZGxtKIDM4CVMeIRmIzbpqVXaoF+Xq9nvK0QOyNlnD7r0U0YZQysl2cANLQyYRqI/jSbSxt3nFiwmWPl8ZUduHwwwK9jcfM8AZ2W97ayYlKbvJgfaOXfDuMiD20CMOPDolL8KJQ+jhlfvpPtRG/D9IHAicwsUFQT/bpHg16wCgfMvt4LPxq1XvuPZbmybm2/AE7jwyThhMxWQd8g1kUBTyispJSU0kpMzVNTHVi1IcvSvmAgAlDs5miV4DZqOslxCmxddj9ScAGcTrRuzGGVcHuRoeVfURIWaz4RMTytC20SOXDpkHe83qOnELhJkFEAVOIvQ3v8YptBS3g0UaG/K5/JlXH+v+DXKvTXn+0NkN2qeSRC8S70RHdqG2Y20orCKtSJUm X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(451199021)(33656002)(86362001)(76116006)(110136005)(316002)(64756008)(71200400001)(41300700001)(54906003)(7696005)(66946007)(8676002)(4326008)(478600001)(66476007)(66446008)(66556008)(5660300002)(55016003)(8936002)(2906002)(4744005)(122000001)(38070700005)(52536014)(38100700002)(186003)(83380400001)(26005)(6506007)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9684 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3084d2e2-1f7e-4595-0ad1-08db3b260348 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K/5TPRNLPKViX0Tp3VTdvqnZI04de9Dhj7YoQvjTXz3upqPXYoDiFdR/CjbYwmHlvt9vlTIaChCv4YWkqxWjKMkB+fHCaCBTBJdTrINI2/MT/YueMNKr/zY04a6U8/bwl0LyMzQnKXdtJE6pPyYoPbGyX3NV4NZSNIfK9OVINH2LOcCVe2ycg8XCxTTwcoLuuTBuPba89W6R6UGzRAt3hsBPdNZlg30URTg9sSWBoMZjVwRkFeefCqYshjzJN6ZQFfdqmJ4/iDc5Hx//nSNRtgTyFyCowckrK09EgczFnsJBDFOrbQXtHN7RFUEmOBHrEGyEtYfrPcKTZAd/IHNWRTt2F4a0vvv/w9v7jDW9YLLtWyozIN4NxKNNgyRW5SNzFgL6r5JdSiNQ8M9nSXlJ/3ACpTi1fil8l36OasvGPgn0f4YDSm6E0lzyEVJyB3tvJg8JQBAijFO5LuMthgVDE4D+C25+0ccOJGZgaI/tzyD1IPDZ2hWQLf4muppE9wTmLh6APHYGIaQWNT/xjaghHDxDt1KAlfi/9blctgiJIF4qpp6qJeAcuJ3tWfUZMMdg9kmokMC75sKfwMDb2j4hMD1v7ezm0+8yOBXmqeeXroqcOAx7lZtlHzoMhXazuNmiZ7kodfBoczPSkI7EoxgDGk7krD8QwnX11XFY7ZFzuW0w5/ZD9XLrbDMJQQLL0OBf4sfiKiKGx483+7NW7wBmrw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199021)(46966006)(40470700004)(36840700001)(2906002)(4744005)(356005)(40460700003)(41300700001)(81166007)(52536014)(5660300002)(8936002)(8676002)(82310400005)(33656002)(86362001)(40480700001)(7696005)(55016003)(9686003)(6506007)(26005)(107886003)(54906003)(36860700001)(83380400001)(478600001)(336012)(47076005)(186003)(316002)(70206006)(70586007)(4326008)(110136005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 07:18:00.3101 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 337f0675-ee7f-4aec-d694-08db3b260c3b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6315 Hi Michal, > -----Original Message----- > Subject: [PATCH 2/3] xen/arm: vpl011: Handle correctly TXFE when backend = in > Xen >=20 > When backend is in Xen, the handling of data written to DR register is a > bit special because we want to tell guest that we are always ready for ne= w > data to be written (i.e. no real FIFO, TXFF/BUSY never set and TXI always > set). This conflicts with the current handling of TXFE bit, which we > always clear and never set on a write path (we happen to set it when we > receive char from serial input due to use of vpl011_data_avail() but this > might never be called). This can lead to issues if a guest driver makes > use of TXFE bit to check for TX transmission completion (such guest could > then wait endlessly). Fix it by keeping TXFE always set to match the > current emulation logic. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Henry Wang Tested-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Wed Apr 12 08:44:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 08:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520065.807292 (Exim 4.92) (envelope-from ) id 1pmW5B-00057j-Om; Wed, 12 Apr 2023 08:44:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520065.807292; Wed, 12 Apr 2023 08:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmW5B-00057c-LX; Wed, 12 Apr 2023 08:44:01 +0000 Received: by outflank-mailman (input) for mailman id 520065; Wed, 12 Apr 2023 08:44:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmW5A-00057O-57; Wed, 12 Apr 2023 08:44:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmW5A-00038b-2S; Wed, 12 Apr 2023 08:44:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmW59-0007wT-JJ; Wed, 12 Apr 2023 08:43:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmW59-00063j-Gb; Wed, 12 Apr 2023 08:43:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3JFpmcgnGXT87F7+LhsTc5a5sKrJMy9tEoW1Bm+evp0=; b=t+A7Z0t4fICYvsp5NKhkd6Czn1 WdZya+E2L7M+dody6UrsJcY8Ep8cPE280zgElJDsx2VpoGJ2uADtk2PM/5mjW8nSPtNbCB2Kwn/j/ /tmPmyRd+JjAK3p+K9xWckIum29OowtMHiZjGUdY1o9ESR0IKAGhnDtPEsfR3xFMBZdk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180208: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=e62252bc55b6d4eddc6c2bdbf95a448180d6a08d X-Osstest-Versions-That: linux=0d3eb744aed40ffce820cded61d7eac515199165 From: osstest service owner Date: Wed, 12 Apr 2023 08:43:59 +0000 flight 180208 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180208/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180199 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180199 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180199 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180199 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180199 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux e62252bc55b6d4eddc6c2bdbf95a448180d6a08d baseline version: linux 0d3eb744aed40ffce820cded61d7eac515199165 Last test of basis 180199 2023-04-10 21:41:48 Z 1 days Testing same since 180208 2023-04-11 19:10:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arseniy Krasnov Bang Li Basavaraj Natikar Bjorn Helgaas Christoph Hellwig Christophe Kerello Damien Le Moal David Sterba Fuad Tabba Jon Hunter Linus Torvalds Miquel Raynal Oliver Upton Paolo Bonzini Reiji Watanabe Reinette Chatre Richard Weinberger Rob Herring Thomas Glanzmann jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0d3eb744aed4..e62252bc55b6 e62252bc55b6d4eddc6c2bdbf95a448180d6a08d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:08:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:08:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520071.807302 (Exim 4.92) (envelope-from ) id 1pmWSa-0007cd-O9; Wed, 12 Apr 2023 09:08:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520071.807302; Wed, 12 Apr 2023 09:08:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmWSa-0007cW-LX; Wed, 12 Apr 2023 09:08:12 +0000 Received: by outflank-mailman (input) for mailman id 520071; Wed, 12 Apr 2023 09:01:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmWMC-0007XZ-F4 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:01:36 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f19566a-d910-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:01:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f19566a-d910-11ed-8611-37d641c3527e From: Alexander Kanavin DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681290092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ASDAJcN9ZDCx7m2Ft89Q46dO/QfgStSaLx/RmpoqlmE=; b=j9n5cvIz7zoE/PDOF9CPf+FJcl6xd+Q8njqcaKJTWCkpCrqxeijmMdF2w3qJEWtCHStLLW MRidshZoi5xM6kQN79R9ICW3OPGW/6YXfHTI9GluBPlwkNDaMRV/HCmrNUZL7rtKms4tBX 7C+3WRWa00YnmxvhZP58E+SjWYDpDDKlak+XxBv3HcCKyRKDWLpiS1snhiz25YKP9FrkIA SuNumLFhyiEf3saSBjqX3H/+TAE7f3ktg3g8Zr4t3wJBgvK5KFHXXazQFoRPQcO6h2VV28 YY5Ec68PwYuZEJKhJ4zzjHgN5tZL2XWA0Yp5OtRoRgZVnFl2x5rEhTaL80XljQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681290092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ASDAJcN9ZDCx7m2Ft89Q46dO/QfgStSaLx/RmpoqlmE=; b=Y2N2se/Zydec6sWuFFSISLM+R1HkD+nTrPu9DD9ulcZYJ+sX3ceUARERhH3Vs8eLjjndEA hoZs6wFhmyk91LDA== To: xen-devel@lists.xenproject.org Cc: Alexander Kanavin , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH] tools/xenstore/xenstored_control.c: correctly print time_t Date: Wed, 12 Apr 2023 11:01:04 +0200 Message-Id: <20230412090104.3794213-1-alex@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On 32 bit systems with 64 bit time_t (hello, Y2038 problem), the following error occurs otherwise: | xenstored_control.c: In function 'lu_reject_reason': | xenstored_control.c:646:70: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'time_t' {aka 'long long int'} [-Werror=format=] Signed-off-by: Alexander Kanavin --- tools/xenstore/xenstored_control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index cbd62556c3..8683947d25 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -668,10 +668,10 @@ static const char *lu_reject_reason(const void *ctx) list_for_each_entry(conn, &connections, list) { if (conn->ta_start_time && (now - conn->ta_start_time >= lu_status->timeout)) { - ret = talloc_asprintf(ctx, "%s\nDomain %u: %ld s", + ret = talloc_asprintf(ctx, "%s\nDomain %u: %jd s", ret ? : "Domains with long running transactions:", conn->id, - now - conn->ta_start_time); + (intmax_t)now - conn->ta_start_time); } } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:14:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520078.807311 (Exim 4.92) (envelope-from ) id 1pmWYM-0000gA-G6; Wed, 12 Apr 2023 09:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520078.807311; Wed, 12 Apr 2023 09:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmWYM-0000g3-D6; Wed, 12 Apr 2023 09:14:10 +0000 Received: by outflank-mailman (input) for mailman id 520078; Wed, 12 Apr 2023 09:14:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmWYK-0000fx-Q9 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:14:09 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5df577ba-d912-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:14:04 +0200 (CEST) Received: from mail-mw2nam04lp2173.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Apr 2023 05:13:58 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by BN8PR03MB4931.namprd03.prod.outlook.com (2603:10b6:408:d8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 09:13:54 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 09:13:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5df577ba-d912-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681290845; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2991Y1o0h26C9mYfga/O1VOH3rPvqbiCrW9xHOa9IfQ=; b=B34CwRx++heqcu99TsrhSr3RDYWq6a9bwOfaiMwVV1se8MzW6QBZuRmY VtEpvmPmA9Q+qaFSTGGWcQk7x7RkEWKzjPH41Kt0gW04jUbROgRVADFgX cwxCvdNW9hcmwFKl+sLHt/m6gUpFSWlYaquN7GKEZl7tf1tjfA8e+fy4j c=; X-IronPort-RemoteIP: 104.47.73.173 X-IronPort-MID: 107631059 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FLSQ7a2UyrwK8F7Z2/bD5V1wkn2cJEfYwER7XKvMYLTBsI5bp2MHn GQeWG2PMveKamSnfd4kYN+18B8Fu5CGzIcwTAdtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gBnP6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLHleq ewjAigxMEqK2M7p3bjjRsNwmZF2RCXrFNt3VnBI6xj8VapjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6Kk1cZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13rCRxnqjBdN6+LuQx+VJmQSh7D0oEAA0WUe+pqOrkG2BcocKQ 6AT0m90xUQoz2SVSd36Uwy9sWSzlBcWUNpNEMU38AiIjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHLv4Ubnh/JCNF5H8adjMDxGDz26 yCHqm45nbp7pdUQy6yx8FTDgjStjpvEVAg44kPQRG3NxhtweYqNd4Gur1/B4p5oL4uHT1/Ho HkNneCf6vwDCdeGkynlfQkWNLSg5vLANSKGh1dqR8Ul7270pCXlep1M6jZjIksvKtwDZTLif E7Uv0VW+YNXO3ypK6RwZupdFvgX8EQpLvy9Pti8UzaESsIZmNOvlM22WXOt4g== IronPort-HdrOrdr: A9a23:eWUF+6Np4prdvsBcTvmjsMiBIKoaSvp037Eqv3oBKiC9E/b1qy nKpp9w6faaslsssQ4b6LS90cW7L080l6QFhLX5TI3SPjUO0VHARL2KhrGC/9SPIU3DH+dmpM BdWqJjEsD3CVRgreuS2maFL+o= X-IronPort-AV: E=Sophos;i="5.98,338,1673931600"; d="scan'208";a="107631059" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRI/DNIdat9Yxq9em9NW7+zqMf/zi9mgU/w7GjDei02GUaDGCgVLceNJZRbX/4pwaw3CNsnkh4kogxvnCBjyUYZMd3tTOGX0QLrCFGqd92fB154AV9o8lxkQjrwwE/jlR5CujZcXsiWcXl/Ti79BxFXYsJPmAcaNqYXnahx2xc1KylYamfO61O+FeO2UfdE0eYZWsFcMJ8w7iwiHT47ywZsGWCLzcyKelEYu4AhYvrwHEeHSyC7moV20Za+Y469VgwhW7qV65I4DATCb9nRje9wxsg1AUOQXpBgmEru8pIrmjUnY3RxxXpUM3nodgCB1Mk+/njNSiiDL1SugOAZK3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HK/G2jZPuDIzdh5segEY+bnvxm5SocI73p3sLSt9VtI=; b=cy+2WOhKdXKipqA+evdEDMNeh9KwuUqDgaX/I+DTvrcgqG7U7sk3/CasnZvA/qqCnh59Vy/os7ffDgBGK8n3ZBoetVXA1TSGfl9li0gc8k1SAWmOLvSQTQQpoEJevj9XrVVFkkOMgKUIp4K3us+QPadzPqmsmmUzHEWFab6zVWgQrOvnTnX9J6CFEl7iNxTIAOO4mftan3a1srmdaX8c7LLLIjS1KZaWulGEokpYOzZB59i6WMijhMy7CWzhE+eGq/L+HoCDSxaArP5PraagH6tAln1AtBNBDUDp4YmGGYor96t1t8dz9xJatsibn2iw4VRGMQ72XOcIJrffoQP1nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HK/G2jZPuDIzdh5segEY+bnvxm5SocI73p3sLSt9VtI=; b=wifTpD/GczYOpvGKSpQ5pRbinAQPtInC5ScuzjpVRYfPQlKMuH89ERMdMJllG0HYrZ9j87CvOdrXut1nM1lOqRg8j8DgNj3/i7AOTiDEgko4FSEVc4jp5OyosoxurimQo7GVEf2pMGCG15oIa/EGGCxDA0fOQCGA4Ql/rPaFx7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 12 Apr 2023 11:13:47 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Kevin Tian Subject: Re: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Message-ID: References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-3-volodymyr_babchuk@epam.com> <873556xa0g.fsf@epam.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <873556xa0g.fsf@epam.com> X-ClientProxiedBy: LO2P265CA0222.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::18) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|BN8PR03MB4931:EE_ X-MS-Office365-Filtering-Correlation-Id: c20940d5-8f31-4eb6-d1ae-08db3b363d20 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LciPqFrnk0CSu/fNPFNSgD6E/JZCDw6TpwGdwbW057YH2CaPbSlxUc5p8XhSckvb85Bwomal9ykyZGQT+ZLknivfd8WnMKSMA2xhxdn4FlhVmn4C8wQYSuYfRlX98lnvRzSA5y8Ej/QRHqRllxba1VrYbcQ7RilmRZpj6bnkzhuHG61d8fluET6GiO6Qf+gldkXUmURKcVzcwc7M2gNLNbuCRY0Yr530qQ+TENoKfjHIV6e6KNOytyXUVnNiOFvUEWh4MXBnwboQK2ONStDWifnA1unstgy1MsdElRJMhSPXgyVtml6TTgcsDoNAER4yHAVJTRJk9yxKIghWY2QP5T+AI4PWBajBNuYQN7bmg5f3BbBG29vbnUc1Xng6Vcg7KCWGAcKaoKHnQrQ2b4hKutbsSVptDE2r9wWH9rlcS/CoO1/lfJqttas9ZhLOIBKT7FkAyhHBAaxxhFheP6OvxmgHGfOtZ3NHYGG3/uEvnE2ZdUyNZ4bpTHyMMBWNnmADnb5lCjMaIJxGeQ2a+9cjsIoGqS02uEdp6bzT515SohgeG1cxzDvVgu+Xk/CGjHNk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199021)(54906003)(41300700001)(66476007)(66556008)(66946007)(8676002)(4326008)(478600001)(6486002)(6916009)(316002)(85182001)(86362001)(26005)(6512007)(6506007)(6666004)(9686003)(83380400001)(8936002)(2906002)(7416002)(82960400001)(5660300002)(33716001)(30864003)(38100700002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDVqTkJCcytOTklZdkFwMWc4ekdVT3dteHRzMnFIY29qSHduSm96TUpDYmlF?= =?utf-8?B?cUVYZm5lVjhhZklGc3hoSlB4ZGhFd3NaU1g0ODMzekcrOW1ESXpqMlp0YnZ0?= =?utf-8?B?VHQ5a1NyTTB6WDhncnhJODdZczJrU2Y2eDNPQnM0R1pESmtBZ0xJR21pc1hs?= =?utf-8?B?dzc2QTJCRUQrUXJISDg5UmJpOG5aQUhneXMydVpRcThEL1NsRVUzR0dsUjFs?= =?utf-8?B?SEN6VGJCaDR5czRNUyt5RkhkWDJNWFpMdkVWMzUvZHo1ZkpCRzBaalFQekw5?= =?utf-8?B?di9LNUY0L1ZKNHN2ZG80Y0pzeks3dldOUEtRRVRwblpVSUxHSFdPWkhaZktV?= =?utf-8?B?OFM2SUlXaXQxdGQ1aVFZQTRYYjBsYWdUTVdDRDJRajZ3VWpvYjZBR1RHaUZL?= =?utf-8?B?T05CRnoxNWdIQzVHTTRTL0xSQ29Cam9Cb3VpdXdkVURHU2EwQjFFTzFHYzFI?= =?utf-8?B?dU5aLzJOcWtBdWpoUUY0UGllR2c3THFiSCtYTlRmeklidmMrdkM1MHljMGg1?= =?utf-8?B?ODlYM2JMN1Jia1dmNjBiRHl3YkVSMnFzdDdVSmJ6VkhaSlYyRnVwdVo3NmlB?= =?utf-8?B?Uk9oaVRqRjdPaGdEZFlDdC84Zjl2bnBxSXBQdEh4eExIQWJxM2p1R0Vjdnp3?= =?utf-8?B?Y3VUWDVhV1IrSEVYRHY2clBoNkNVOXBHb1Badk1MZmpHSHFYM3ZtN3lYQUpV?= =?utf-8?B?QkxSVkRBcmY3UkJpUnRiazJUN3pXVmJuOTV2QlpsenFUenFwWEZBbEF1akpq?= =?utf-8?B?aGwwZEFWdEJ1Wms5STJCU3BwVXhZMXlzNnJVMUxWc281aDBSazZFa285eUZj?= =?utf-8?B?Tk4zQzJpOU1Pa1ZZRjhOaEwxcnMrMUJzRDhqWjcrd09iUUR0Nzd6cXVzLzJY?= =?utf-8?B?cHQ4dHpZU1VyRE5LWlgyN3k5bmZzaGpPemxpY040cktFNmpxWVpDOHcxY0Ey?= =?utf-8?B?Q0ppbnhOU0FsM1ZaZEkrLzRzaTNRSVR6WC9LV3VvUlNxbm01ZFdCNFE1b2Vm?= =?utf-8?B?RkRCZi9RUUdabjVDOE9kSmZ6dFQxRVhpR0ZqVmEvS0pLbWtjcFdyNU1TcVNa?= =?utf-8?B?eDJ0SnJOaXkxZEV3WXFJZUVTUHo5eDJVNmF3NU5KMXAzUHdDSkRjU0lqVDN3?= =?utf-8?B?UkorV2RqU045OHhFakVLUG9yVlhnVG1XZTMvN0J0c2s1ckkwOXk4cG1mazZv?= =?utf-8?B?NjVSMWVFYSs3VWU3ano3YVVyeXYwcStvOWI1V1Q4RnFnZFNOMVErRnZRQVIv?= =?utf-8?B?dkZYblQ1OVlQK3V0NEJvZFo3Uld4MnhlL2NFTnJHZHhUMDlOMElVU3RCcGVx?= =?utf-8?B?dGpRK0RWZmdVUEpXOWpJUTRXY1FpS09venFldHRJNWVWdnd4NmxtVnVDNHBu?= =?utf-8?B?bi9Ja0pkVmY0d0FoU2NhNHZkTlVibGhldmNybGduZ1BUODY4eWZqL0pKRnla?= =?utf-8?B?VWVJZldQYXB2dHZJY2Zha1pVM0pUUmU2bEhxeXN1YVU5MnViMDQ5bnlLVnBI?= =?utf-8?B?NndCNUFuTnhkd1JkNFhuQjErcytmdkRlRXZ3ZmZuN2c2UldlRlJpREd6Skh3?= =?utf-8?B?dmdLTXpGZDVuMFlJQ1RBQit3b3lnOUdlV09adWE3Rmk0bXpDZnBkWVJqZWpN?= =?utf-8?B?U3ZFN0dyczhwVWwwSmwvaGh2TzdTNGVNblgvb2pCNWUxY3p3ZkhmbDJXaDdm?= =?utf-8?B?NVJFTmdYZFZTMDBQNTlMWXl3cDJleUpJMmdZNmlNT2J0ZGRoNy9nc0Q4OFVW?= =?utf-8?B?ZWNJaEtXMmMwQUQxZk90TW9oYXJhbnc1L0RFZmNXa1RkelFjKzRxV2V1VWV3?= =?utf-8?B?STFBaS9PaTJFR0FESGRkYndtbUhITlozeDFIQ1ZxVVk2TzkrY1QycXZHRG03?= =?utf-8?B?a1BDejZRVEZ0dWx0RWpaWEhqV2ZLUHVoTHVSSkNqUXBxUUpVUUxwMW9FQlo1?= =?utf-8?B?bHY3UjNqVFFvbGtqQ3RMMHZkOHY2ZysrWGlCdERPaW5PVkNyZGYveFJFZmRo?= =?utf-8?B?dGpPcm82Q2hCaCs2QURtVFcvN3IrMjAwclBQL2x0OTUzK2JOVVhQb05RV1dv?= =?utf-8?B?RVM0K3V0b1ZZcHc5OG1ZUDRLR1daNi81UkNqQ2Jsenp3SVlnMGVsamNpRGd4?= =?utf-8?Q?ZmFqFsxIVbgFUrx8wTYTGJ/jI?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8ggj53bxZXMKKJXvysyvWg03wXUSK7id5DpJA1AGZ7hg0NYytihLy+cJyiDy+/H5FpTncx8vCJuOskqvlQ14xwbTcHO+RUffzbACviYtcGjkNpQlZ3Yk7UIoN5BmT6oHv2uaTqxsROCB5Ue1NfgrUBrV87Dfnt2Yai5uyvjeFUEZs6x20wJlgmjY/PJpPJWQlhy6WJkfP3yeW0K3s0NSmO0BcFeNbPvissh2D9rGufmAu+X4uw2bLZy0j6f1Gt648v1+Uy45OPFdRRGyEuYi1FRdlnBio3kn8u5K+DnpJKrF6hu4liJQAjRsF3sVVT525u84Nw5ml+Xko4hPWiFaYNOR8d/2uqdKS30pPeeDLQtPNrZqaHmjUlMRcX4tyPV33TqRdnavNXJuhrUpj1j/+z8MWK0/toTCEhbFOrMCiZYQrEE8+Uf2OXUJJ/9yNtBIWNqQ3qiDKUHR2rA96lfVdlaoPkHcgJXCOReYlEQW87xLWtLCGkDBwhsTGOPcQB3d5XDXYeKHoDnEwQa+f+lVGI07UoHQhugY5dQ6DfB/1CaL9vlkjwBIVLSwFUvShR1DRtGB3tRzI4BgiS603IfGtJHWB2R1Vv4ZPl0IPLE7n5pYJf+mv2TzkXjD9ggxRod/QMqQsbGWK277AaUN+17HzT5RiQqSUfvUgflQhh6PCR82IR3MTe9C8Zilqq560tLiZ+u4N+q4zIhxiNiSiOU7SAFNxN1RjC9Ga9QaPajzDxG9Ze8HL7HTDaXhZDaumbQjq278nV1oy8buR4p+HsoJBB0sWXOWCv3NPBuBwf2YTfPNfi/1IjNEaLDsiE1/FKkBOFy9VdbKHyM3uxowWUqtXpjnGCJFGQI981WVTUVjvDfFh1RsUSfRgC58fvgLkp/3eIxDpNbotO0o3JIEdUDJoQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c20940d5-8f31-4eb6-d1ae-08db3b363d20 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 09:13:54.5879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vxJo11qcy+ow6KJNBMWlRPbRVzykqUFes2mJg25PfQFk5qGdqsU+1nLw91PlBg68tFf88nGMIC3PUDK6YnTIOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4931 On Tue, Apr 11, 2023 at 11:41:04PM +0000, Volodymyr Babchuk wrote: > > Hi Roger, > > Roger Pau Monné writes: > > > On Tue, Mar 14, 2023 at 08:56:29PM +0000, Volodymyr Babchuk wrote: > >> Prior to this change, lifetime of pci_dev objects was protected by global > >> pcidevs_lock(). Long-term plan is to remove this log, so we need some > > ^ lock > > > > I wouldn't say remove, as one way or another we need a lock to protect > > concurrent accesses. > > > > I'll write "replace this global lock with couple of more granular > locking devices" > if this is okay for you. > > >> other mechanism to ensure that those objects will not disappear under > >> feet of code that access them. Reference counting is a good choice as > >> it provides easy to comprehend way to control object lifetime. > >> > >> This patch adds two new helper functions: pcidev_get() and > >> pcidev_put(). pcidev_get() will increase reference counter, while > >> pcidev_put() will decrease it, destroying object when counter reaches > >> zero. > >> > >> pcidev_get() should be used only when you already have a valid pointer > >> to the object or you are holding lock that protects one of the > >> lists (domain, pseg or ats) that store pci_dev structs. > >> > >> pcidev_get() is rarely used directly, because there already are > >> functions that will provide valid pointer to pci_dev struct: > >> pci_get_pdev(), pci_get_real_pdev(). They will lock appropriate list, > >> find needed object and increase its reference counter before returning > >> to the caller. > >> > >> Naturally, pci_put() should be called after finishing working with a > >> received object. This is the reason why this patch have so many > >> pcidev_put()s and so little pcidev_get()s: existing calls to > >> pci_get_*() functions now will increase reference counter > >> automatically, we just need to decrease it back when we finished. > > > > After looking a bit into this, I would like to ask whether it's been > > considered the need to increase the refcount for each use of a pdev. > > > > This is how Linux uses reference locking. It decreases cognitive load > and chance for an error, as there is a simple set of rules, which you > follow. > > > For example I would consider the initial alloc_pdev() to take a > > refcount, and then pci_remove_device() _must_ be the function that > > removes the last refcount, so that it can return -EBUSY otherwise (see > > my comment below). > > I tend to disagree there, as this ruins the very idea of reference > counting. We can't know who else holds reference right now. Okay, we > might know, but this requires additional lock to serialize > accesses. Which, in turn, makes refcount un-needed. In principle pci_remove_device() must report whether the device is ready to be physically removed from the system, so it must return -EBUSY if there are still users accessing the device. A user would use PHYSDEVOP_manage_pci_remove to signal Xen it's trying to physically remove a PCI device from a system, so we must ensure that when the hypervisor returns success the device is ready to be physically removed. Or at least that's my understanding of how this should work. > > > > I would also think that having the device assigned to a guest will take > > another refcount, and then any usage from further callers (ie: like > > vpci) will need some kind of protection from preventing the device > > from being deassigned from a domain while vPCI handlers are running, > > and the current refcount won't help with that. > > Yes, idea of this refcounting is to ensure that a pdev object exists as an > valid object in memory if we are holding a long-term pointer to > it. Indeed, vPCI handlers should use some other mechanism to ensure that > pdev is not being re-assigned while handlers are running. I believe, > this is the task of vpci->lock. Should we call > vpci_remove_device/vpci_add_handlers each time we re-assign a PCI device? Yes, I think this was also part of a comment I've made on a different patch. The device state needs to be cleared when assigned to a different guest (as the hardware domain will also perform a device reset). I think there are some points that needs to be part of the commit message so the code can be properly evaluated: - The reference counting is only used to ensure the object cannot be removed while in use. Users of the pci device object should implement whatever protections required in order to get mutual exclusion between them and device state changes. > > > > That makes me wonder if for example callers of pci_get_pdev(d, sbdf) > > do need to take an extra refcount, because such access is already > > protected from the pdev going away by the fact that the device is > > assigned to a guest. But maybe it's too much work to separate users > > of pci_get_pdev(d, ...); vs pci_get_pdev(NULL, ...);. > > > > There's also a window when the refcount is dropped to 0, and the > > destruction function is called, but at the same time a concurrent > > thread could attempt to take a reference to the pdev still? > > Last pcidev_put() would be called by pci_remove_device(), after removing > it from all lists. This should prevent other threads from obtaining a valid > reference to the pdev. What if a concurrent user has taken a reference to the object before pci_remove_device() has removed the device from the lists, and still holds it when pci_remove_device() performs the supposedly last pcidev_put() call? > > > >> sbdf.devfn &= ~stride; > >> pdev = pci_get_pdev(NULL, sbdf); > >> if ( pdev && stride != pdev->phantom_stride ) > >> + { > >> + pcidev_put(pdev); > >> pdev = NULL; > >> + } > >> } > >> > >> return pdev; > >> @@ -548,13 +526,18 @@ struct pci_dev *pci_get_pdev(const struct domain *d, pci_sbdf_t sbdf) > >> list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list ) > >> if ( pdev->sbdf.bdf == sbdf.bdf && > >> (!d || pdev->domain == d) ) > >> + { > >> + pcidev_get(pdev); > >> return pdev; > >> + } > >> } > >> else > >> list_for_each_entry ( pdev, &d->pdev_list, domain_list ) > >> if ( pdev->sbdf.bdf == sbdf.bdf ) > >> + { > >> + pcidev_get(pdev); > >> return pdev; > >> - > >> + } > >> return NULL; > >> } > >> > >> @@ -663,7 +646,10 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, > >> PCI_SBDF(seg, info->physfn.bus, > >> info->physfn.devfn)); > >> if ( pdev ) > >> + { > >> pf_is_extfn = pdev->info.is_extfn; > >> + pcidev_put(pdev); > >> + } > >> pcidevs_unlock(); > >> if ( !pdev ) > >> pci_add_device(seg, info->physfn.bus, info->physfn.devfn, > >> @@ -818,7 +804,9 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn) > >> if ( pdev->domain ) > >> list_del(&pdev->domain_list); > >> printk(XENLOG_DEBUG "PCI remove device %pp\n", &pdev->sbdf); > >> - free_pdev(pseg, pdev); > >> + list_del(&pdev->alldevs_list); > >> + pdev_msi_deinit(pdev); > >> + pcidev_put(pdev); > > > > Hm, I think here we want to make sure that the device has been freed, > > or else you would have to return -EBUSY to the calls to notify that > > the device is still in use. > > Why? As I can see, pdev object is still may potentially be accessed by > some other CPU right now. So pdev object will be freed after last > reference is dropped. As it is already removed from all the lists, > pci_dev_get() will not find it anymore. > > Actually, I can't see how this can happen in reality, as VPCI, MSI and > IOMMU are already deactivated for this device. So, no one would touch it. Wouldn't it be possible for a concurrent user to hold a reference from befoe the device has been 'deactivated'? > > > > I think we need an extra pcidev_put_final() or similar that can be > > used in pci_remove_device() to assert that the device has been > > actually removed. > > Will something break if we don't do this? I can't see how this can > happen. As mentioned above, once pci_remove_device() returns 0 the admin should be capable of physically removing the device from the system. > > > >> break; > >> } > >> > >> @@ -848,7 +836,7 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, > >> { > >> ret = iommu_quarantine_dev_init(pci_to_dev(pdev)); > >> if ( ret ) > >> - return ret; > >> + goto out; > >> > >> target = dom_io; > >> } > >> @@ -878,6 +866,7 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, > >> pdev->fault.count = 0; > >> > >> out: > >> + pcidev_put(pdev); > >> if ( ret ) > >> printk(XENLOG_G_ERR "%pd: deassign (%pp) failed (%d)\n", > >> d, &PCI_SBDF(seg, bus, devfn), ret); > >> @@ -1011,7 +1000,10 @@ void pci_check_disable_device(u16 seg, u8 bus, u8 devfn) > >> pdev->fault.count >>= 1; > >> pdev->fault.time = now; > >> if ( ++pdev->fault.count < PT_FAULT_THRESHOLD ) > >> + { > >> + pcidev_put(pdev); > >> pdev = NULL; > >> + } > >> } > >> pcidevs_unlock(); > >> > >> @@ -1022,6 +1014,8 @@ void pci_check_disable_device(u16 seg, u8 bus, u8 devfn) > >> * control it for us. */ > >> cword = pci_conf_read16(pdev->sbdf, PCI_COMMAND); > >> pci_conf_write16(pdev->sbdf, PCI_COMMAND, cword & ~PCI_COMMAND_MASTER); > >> + > >> + pcidev_put(pdev); > >> } > >> > >> /* > >> @@ -1138,6 +1132,7 @@ static int __hwdom_init cf_check _setup_hwdom_pci_devices( > >> printk(XENLOG_WARNING "Dom%d owning %pp?\n", > >> pdev->domain->domain_id, &pdev->sbdf); > >> > >> + pcidev_put(pdev); > >> if ( iommu_verbose ) > >> { > >> pcidevs_unlock(); > >> @@ -1385,33 +1380,28 @@ static int iommu_remove_device(struct pci_dev *pdev) > >> return iommu_call(hd->platform_ops, remove_device, devfn, pci_to_dev(pdev)); > >> } > >> > >> -static int device_assigned(u16 seg, u8 bus, u8 devfn) > >> +static int device_assigned(struct pci_dev *pdev) > >> { > >> - struct pci_dev *pdev; > >> int rc = 0; > >> > >> ASSERT(pcidevs_locked()); > >> - pdev = pci_get_pdev(NULL, PCI_SBDF(seg, bus, devfn)); > >> - > >> - if ( !pdev ) > >> - rc = -ENODEV; > >> /* > >> * If the device exists and it is not owned by either the hardware > >> * domain or dom_io then it must be assigned to a guest, or be > >> * hidden (owned by dom_xen). > >> */ > >> - else if ( pdev->domain != hardware_domain && > >> - pdev->domain != dom_io ) > >> + if ( pdev->domain != hardware_domain && > >> + pdev->domain != dom_io ) > >> rc = -EBUSY; > >> > >> return rc; > >> } > >> > >> /* Caller should hold the pcidevs_lock */ > > > > I would assume the caller has taken an extra reference to the pdev, so > > holding the pcidevs_lock is no longer needed? > > I am assumed that lock may be required by MSIX or IOMMU functions, that > are being called here. For example, I can see that reassign_device() in > pci_amd_iommu.c manipulates with some lists. I believe, it should be > protected with the lock. OK, so that's pcidevs_lock being used to protect something else that's not strictly a pci device, but a related structure. > > > >> -static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > >> +static int assign_device(struct domain *d, struct pci_dev *pdev, u32 flag) > >> { > >> const struct domain_iommu *hd = dom_iommu(d); > >> - struct pci_dev *pdev; > >> + uint8_t devfn; > >> int rc = 0; > >> > >> if ( !is_iommu_enabled(d) ) > >> @@ -1422,10 +1412,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > >> > >> /* device_assigned() should already have cleared the device for assignment */ > >> ASSERT(pcidevs_locked()); > >> - pdev = pci_get_pdev(NULL, PCI_SBDF(seg, bus, devfn)); > >> ASSERT(pdev && (pdev->domain == hardware_domain || > >> pdev->domain == dom_io)); > >> > >> + devfn = pdev->devfn; > >> + > >> /* Do not allow broken devices to be assigned to guests. */ > >> rc = -EBADF; > >> if ( pdev->broken && d != hardware_domain && d != dom_io ) > >> @@ -1460,7 +1451,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > >> done: > >> if ( rc ) > >> printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", > >> - d, &PCI_SBDF(seg, bus, devfn), rc); > >> + d, &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc); > >> /* The device is assigned to dom_io so mark it as quarantined */ > >> else if ( d == dom_io ) > >> pdev->quarantine = true; > >> @@ -1595,6 +1586,9 @@ int iommu_do_pci_domctl( > >> ASSERT(d); > >> /* fall through */ > >> case XEN_DOMCTL_test_assign_device: > >> + { > >> + struct pci_dev *pdev; > >> + > >> /* Don't support self-assignment of devices. */ > >> if ( d == current->domain ) > >> { > >> @@ -1622,26 +1616,36 @@ int iommu_do_pci_domctl( > >> seg = machine_sbdf >> 16; > >> bus = PCI_BUS(machine_sbdf); > >> devfn = PCI_DEVFN(machine_sbdf); > >> - > >> pcidevs_lock(); > >> - ret = device_assigned(seg, bus, devfn); > >> + pdev = pci_get_pdev(NULL, PCI_SBDF(seg, bus, devfn)); > >> + if ( !pdev ) > >> + { > >> + printk(XENLOG_G_INFO "%pp non-existent\n", > >> + &PCI_SBDF(seg, bus, devfn)); > >> + ret = -EINVAL; > >> + break; > >> + } > >> + > >> + ret = device_assigned(pdev); > >> if ( domctl->cmd == XEN_DOMCTL_test_assign_device ) > >> { > >> if ( ret ) > >> { > >> - printk(XENLOG_G_INFO "%pp already assigned, or non-existent\n", > >> + printk(XENLOG_G_INFO "%pp already assigned\n", > >> &PCI_SBDF(seg, bus, devfn)); > >> ret = -EINVAL; > >> } > >> } > >> else if ( !ret ) > >> - ret = assign_device(d, seg, bus, devfn, flags); > >> + ret = assign_device(d, pdev, flags); > >> + > >> + pcidev_put(pdev); > > > > I would think you need to keep the refcount here if ret == 0, so that > > the device cannot be removed while assigned to a domain? > > Looks like we are perceiving function of refcnt in a different > ways. For me, this is the mechanism to guarantee that if we have a valid > pointer to an object, this object will not disappear under our > feet. This is the main function of krefs in the linux kernel: if your > code holds a reference to an object, you can be sure that this object is > exists in memory. > > On other hand, it seems that you are considering this refcnt as an usage > counter for an actual PCI device, not "struct pdev" that represent > it. Those are two related things, but not the same. So, I can see why > you are suggesting to get additional reference there. But for me, this > looks unnecessary: the very first refcount is obtained in > pci_add_device() and there is the corresponding function > pci_remove_device() that will drop this refcount. So, for me, if admin > wants to remove a PCI device which is assigned to a domain, they can do > this as they were able to do this prior this patches. This is all fine, but needs to be stated in the commit message. > The main value of introducing refcnt is to be able to access pdev objects > without holding the global pcidevs_lock(). This does not mean that you > don't need locking at all. But this allows you to use pdev->lock (which > does not exists in this series, but was introduced in a RFC earlier), or > vpci->lock, or any other subsystem->lock. I guess I was missing this other bit about introducing a per-device lock, would it be possible to bundle all this together into a single patch series? It would be good to place this change together with any other locking related change that you have pending. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:45:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:45:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520082.807322 (Exim 4.92) (envelope-from ) id 1pmX2r-00047G-Uo; Wed, 12 Apr 2023 09:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520082.807322; Wed, 12 Apr 2023 09:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX2r-000479-S3; Wed, 12 Apr 2023 09:45:41 +0000 Received: by outflank-mailman (input) for mailman id 520082; Wed, 12 Apr 2023 09:45:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX2q-00046z-1q; Wed, 12 Apr 2023 09:45:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX2p-0004hN-V2; Wed, 12 Apr 2023 09:45:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX2p-0002bT-HS; Wed, 12 Apr 2023 09:45:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmX2p-000807-Gz; Wed, 12 Apr 2023 09:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VMKyUUjzjrTCk4213uS93aIez0iiAg7/17gbjT222pE=; b=uOqOAWwB534Zuf+hcrZ6BMf0kQ aALRJJ7pQuORy7hD72VdaLRYB2KO30XF7mJUKsxIUDF0Xv2+aTwqmbjH+qY9KvPuBcLD8HYjnJGwK u0QT1j+2QTh362yNDcDDoulTucEF032YSlboM84JbIq1EOJCjt08e8ETysdKPpJ8rHF8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180216: all pass - PUSHED X-Osstest-Versions-This: ovmf=b991aec0509f24ae7573d732ba337549ecee310c X-Osstest-Versions-That: ovmf=51734dfc48466eddfb0f8acdb24518266c36c905 From: osstest service owner Date: Wed, 12 Apr 2023 09:45:39 +0000 flight 180216 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180216/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b991aec0509f24ae7573d732ba337549ecee310c baseline version: ovmf 51734dfc48466eddfb0f8acdb24518266c36c905 Last test of basis 180203 2023-04-11 07:40:42 Z 1 days Testing same since 180216 2023-04-12 07:13:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yu Pu Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 51734dfc48..b991aec050 b991aec0509f24ae7573d732ba337549ecee310c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:49:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520090.807336 (Exim 4.92) (envelope-from ) id 1pmX6x-0004oJ-Vw; Wed, 12 Apr 2023 09:49:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520090.807336; Wed, 12 Apr 2023 09:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6x-0004nq-QE; Wed, 12 Apr 2023 09:49:55 +0000 Received: by outflank-mailman (input) for mailman id 520090; Wed, 12 Apr 2023 09:49:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6w-0004lU-6N for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5f7e0b57-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:49:53 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C899A168F; Wed, 12 Apr 2023 02:50:36 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1211B3F587; Wed, 12 Apr 2023 02:49:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f7e0b57-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Date: Wed, 12 Apr 2023 10:49:28 +0100 Message-Id: <20230412094938.2693890-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add sve_vl field to arch_domain and xen_arch_domainconfig struct, to allow the domain to have an information about the SVE feature and the number of SVE register bits that are allowed for this domain. sve_vl field is the vector length in bits divided by 128, this allows to use less space in the structures. The field is used also to allow or forbid a domain to use SVE, because a value equal to zero means the guest is not allowed to use the feature. Check that the requested vector length is lower or equal to the platform supported vector length, otherwise fail on domain creation. Signed-off-by: Luca Fancellu --- Changes from v4: - Return 0 in get_sys_vl_len() if sve is not supported, code style fix, removed else if since the conditions can't fallthrough, removed not needed condition checking for VL bits validity because it's already covered, so delete is_vl_valid() function. (Jan) Changes from v3: - don't use fixed types when not needed, use encoded value also in arch_domain so rename sve_vl_bits in sve_vl. (Jan) - rename domainconfig_decode_vl to sve_decode_vl because it will now be used also to decode from arch_domain value - change sve_vl from uint16_t to uint8_t and move it after "type" field to optimize space. Changes from v2: - rename field in xen_arch_domainconfig from "sve_vl_bits" to "sve_vl" and use the implicit padding after gic_version to store it, now this field is the VL/128. (Jan) - Created domainconfig_decode_vl() function to decode the sve_vl field and use it as plain bits value inside arch_domain. - Changed commit message reflecting the changes Changes from v1: - no changes Changes from RFC: - restore zcr_el2 in sve_restore_state, that will be introduced later in this serie, so remove zcr_el2 related code from this patch and move everything to the later patch (Julien) - add explicit padding into struct xen_arch_domainconfig (Julien) - Don't lower down the vector length, just fail to create the domain. (Julien) --- xen/arch/arm/arm64/sve.c | 12 ++++++++++++ xen/arch/arm/domain.c | 27 +++++++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sve.h | 12 ++++++++++++ xen/arch/arm/include/asm/domain.h | 5 +++++ xen/include/public/arch-arm.h | 2 ++ xen/include/public/domctl.h | 2 +- 6 files changed, 59 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index 6f3fb368c59b..78f7482619da 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -6,6 +6,7 @@ */ #include +#include #include #include #include @@ -48,3 +49,14 @@ register_t vl_to_zcr(unsigned int vl) ASSERT(vl > 0); return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; } + +/* Get the system sanitized value for VL in bits */ +unsigned int get_sys_vl_len(void) +{ + if ( !cpu_has_sve ) + return 0; + + /* ZCR_ELx len field is ((len+1) * 128) = vector bits length */ + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * + SVE_VL_MULTIPLE_VAL; +} diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index adb6ace2e24d..769fae8fe25e 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -13,6 +13,7 @@ #include #include +#include #include #include #include @@ -550,6 +551,8 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); v->arch.cptr_el2 = get_default_cptr_flags(); + if ( is_sve_domain(v->domain) ) + v->arch.cptr_el2 &= ~HCPTR_CP(8); v->arch.hcr_el2 = get_default_hcr_flags(); @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) unsigned int max_vcpus; unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); + unsigned int sve_vl_bits = sve_decode_vl(config->arch.sve_vl); if ( (config->flags & ~flags_optional) != flags_required ) { @@ -602,6 +606,26 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) return -EINVAL; } + /* Check feature flags */ + if ( sve_vl_bits > 0 ) + { + unsigned int zcr_max_bits = get_sys_vl_len(); + + if ( !zcr_max_bits ) + { + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); + return -EINVAL; + } + + if ( sve_vl_bits > zcr_max_bits ) + { + dprintk(XENLOG_INFO, + "Requested SVE vector length (%u) > supported length (%u)\n", + sve_vl_bits, zcr_max_bits); + return -EINVAL; + } + } + /* The P2M table must always be shared between the CPU and the IOMMU */ if ( config->iommu_opts & XEN_DOMCTL_IOMMU_no_sharept ) { @@ -744,6 +768,9 @@ int arch_domain_create(struct domain *d, if ( (rc = domain_vpci_init(d)) != 0 ) goto fail; + /* Copy the encoded vector length sve_vl from the domain configuration */ + d->arch.sve_vl = config->arch.sve_vl; + return 0; fail: diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index 144d2b1cc485..a4c53e3e8e2e 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -13,10 +13,17 @@ /* Vector length must be multiple of 128 */ #define SVE_VL_MULTIPLE_VAL (128U) +static inline unsigned int sve_decode_vl(unsigned int sve_vl) +{ + /* SVE vector length is stored as VL/128 in xen_arch_domainconfig */ + return sve_vl * SVE_VL_MULTIPLE_VAL; +} + #ifdef CONFIG_ARM64_SVE register_t compute_max_zcr(void); register_t vl_to_zcr(unsigned int vl); +unsigned int get_sys_vl_len(void); #else /* !CONFIG_ARM64_SVE */ @@ -30,6 +37,11 @@ static inline register_t vl_to_zcr(unsigned int vl) return 0; } +static inline unsigned int get_sys_vl_len(void) +{ + return 0; +} + #endif /* CONFIG_ARM64_SVE */ #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index e776ee704b7d..78cc2da3d4e5 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -31,6 +31,8 @@ enum domain_type { #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) +#define is_sve_domain(d) ((d)->arch.sve_vl > 0) + /* * Is the domain using the host memory layout? * @@ -67,6 +69,9 @@ struct arch_domain enum domain_type type; #endif + /* max SVE encoded vector length */ + uint8_t sve_vl; + /* Virtual MMU */ struct p2m_domain p2m; diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced5097a..38311f559581 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -300,6 +300,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); struct xen_arch_domainconfig { /* IN/OUT */ uint8_t gic_version; + /* IN - Contains SVE vector length divided by 128 */ + uint8_t sve_vl; /* IN */ uint16_t tee_type; /* IN */ diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 529801c89ba3..e2e22cb534d6 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -21,7 +21,7 @@ #include "hvm/save.h" #include "memory.h" -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016 /* * NB. xen_domctl.domain is an IN/OUT parameter for this operation. -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:49:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520091.807340 (Exim 4.92) (envelope-from ) id 1pmX6y-0004st-78; Wed, 12 Apr 2023 09:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520091.807340; Wed, 12 Apr 2023 09:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6y-0004qd-36; Wed, 12 Apr 2023 09:49:56 +0000 Received: by outflank-mailman (input) for mailman id 520091; Wed, 12 Apr 2023 09:49:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6w-0004lO-Aw for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5df35070-d917-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:49:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 452C01684; Wed, 12 Apr 2023 02:50:35 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D2B3B3F587; Wed, 12 Apr 2023 02:49:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5df35070-d917-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Date: Wed, 12 Apr 2023 10:49:27 +0100 Message-Id: <20230412094938.2693890-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enable Xen to handle the SVE extension, add code in cpufeature module to handle ZCR SVE register, disable trapping SVE feature on system boot only when SVE resources are accessed. While there, correct coding style for the comment on coprocessor trapping. Now cptr_el2 is part of the domain context and it will be restored on context switch, this is a preparation for saving the SVE context which will be part of VFP operations, so restore it before the call to save VFP registers. To save an additional isb barrier, restore cptr_el2 before an existing isb barrier and move the call for saving VFP context after that barrier. Change the KConfig entry to make ARM64_SVE symbol selectable, by default it will be not selected. Create sve module and sve_asm.S that contains assembly routines for the SVE feature, this code is inspired from linux and it uses instruction encoding to be compatible with compilers that does not support SVE. Signed-off-by: Luca Fancellu --- Changes from v4: - don't use fixed types in vl_to_zcr, forgot to address that in v3, by mistake I changed that in patch 2, fixing now (Jan) Changes from v3: - no changes Changes from v2: - renamed sve_asm.S in sve-asm.S, new files should not contain underscore in the name (Jan) Changes from v1: - Add assert to vl_to_zcr, it is never called with vl==0, but just to be sure it won't in the future. Changes from RFC: - Moved restoring of cptr before an existing barrier (Julien) - Marked the feature as unsupported for now (Julien) - Trap and un-trap only when using SVE resources in compute_max_zcr() (Julien) --- xen/arch/arm/Kconfig | 10 +++-- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/cpufeature.c | 7 ++-- xen/arch/arm/arm64/sve-asm.S | 48 +++++++++++++++++++++++ xen/arch/arm/arm64/sve.c | 50 ++++++++++++++++++++++++ xen/arch/arm/cpufeature.c | 6 ++- xen/arch/arm/domain.c | 9 +++-- xen/arch/arm/include/asm/arm64/sve.h | 43 ++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 1 + xen/arch/arm/include/asm/cpufeature.h | 14 +++++++ xen/arch/arm/include/asm/domain.h | 1 + xen/arch/arm/include/asm/processor.h | 2 + xen/arch/arm/setup.c | 5 ++- xen/arch/arm/traps.c | 28 +++++++------ 14 files changed, 201 insertions(+), 24 deletions(-) create mode 100644 xen/arch/arm/arm64/sve-asm.S create mode 100644 xen/arch/arm/arm64/sve.c create mode 100644 xen/arch/arm/include/asm/arm64/sve.h diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c7f..41f45d8d1203 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -112,11 +112,15 @@ config ARM64_PTR_AUTH This feature is not supported in Xen. config ARM64_SVE - def_bool n + bool "Enable Scalar Vector Extension support (UNSUPPORTED)" if UNSUPPORTED depends on ARM_64 help - Scalar Vector Extension support. - This feature is not supported in Xen. + Scalar Vector Extension (SVE/SVE2) support for guests. + + Please be aware that currently, enabling this feature will add latency on + VM context switch between SVE enabled guests, between not-enabled SVE + guests and SVE enabled guests and viceversa, compared to the time + required to switch between not-enabled SVE guests. config ARM64_MTE def_bool n diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 6d507da0d44d..24e08fd42596 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -12,6 +12,7 @@ obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += smc.o obj-y += smpboot.o +obj-$(CONFIG_ARM64_SVE) += sve.o sve-asm.o obj-y += traps.o obj-y += vfp.o obj-y += vsysreg.o diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c index d9039d37b2d1..b4656ff4d80f 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -455,15 +455,11 @@ static const struct arm64_ftr_bits ftr_id_dfr1[] = { ARM64_FTR_END, }; -#if 0 -/* TODO: use this to sanitize SVE once we support it */ - static const struct arm64_ftr_bits ftr_zcr[] = { ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ ARM64_FTR_END, }; -#endif /* * Common ftr bits for a 32bit register with all hidden, strict @@ -603,6 +599,9 @@ void update_system_features(const struct cpuinfo_arm *new) SANITIZE_ID_REG(zfr64, 0, aa64zfr0); + if ( cpu_has_sve ) + SANITIZE_REG(zcr64, 0, zcr); + /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git a/xen/arch/arm/arm64/sve-asm.S b/xen/arch/arm/arm64/sve-asm.S new file mode 100644 index 000000000000..4d1549344733 --- /dev/null +++ b/xen/arch/arm/arm64/sve-asm.S @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Arm SVE assembly routines + * + * Copyright (C) 2022 ARM Ltd. + * + * Some macros and instruction encoding in this file are taken from linux 6.1.1, + * file arch/arm64/include/asm/fpsimdmacros.h, some of them are a modified + * version. + */ + +/* Sanity-check macros to help avoid encoding garbage instructions */ + +.macro _check_general_reg nr + .if (\nr) < 0 || (\nr) > 30 + .error "Bad register number \nr." + .endif +.endm + +.macro _check_num n, min, max + .if (\n) < (\min) || (\n) > (\max) + .error "Number \n out of range [\min,\max]" + .endif +.endm + +/* SVE instruction encodings for non-SVE-capable assemblers */ +/* (pre binutils 2.28, all kernel capable clang versions support SVE) */ + +/* RDVL X\nx, #\imm */ +.macro _sve_rdvl nx, imm + _check_general_reg \nx + _check_num (\imm), -0x20, 0x1f + .inst 0x04bf5000 \ + | (\nx) \ + | (((\imm) & 0x3f) << 5) +.endm + +/* Gets the current vector register size in bytes */ +GLOBAL(sve_get_hw_vl) + _sve_rdvl 0, 1 + ret + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c new file mode 100644 index 000000000000..6f3fb368c59b --- /dev/null +++ b/xen/arch/arm/arm64/sve.c @@ -0,0 +1,50 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#include +#include +#include +#include +#include + +extern unsigned int sve_get_hw_vl(void); + +register_t compute_max_zcr(void) +{ + register_t cptr_bits = get_default_cptr_flags(); + register_t zcr = vl_to_zcr(SVE_VL_MAX_BITS); + unsigned int hw_vl; + + /* Remove trap for SVE resources */ + WRITE_SYSREG(cptr_bits & ~HCPTR_CP(8), CPTR_EL2); + isb(); + + /* + * Set the maximum SVE vector length, doing that we will know the VL + * supported by the platform, calling sve_get_hw_vl() + */ + WRITE_SYSREG(zcr, ZCR_EL2); + + /* + * Read the maximum VL, which could be lower than what we imposed before, + * hw_vl contains VL in bytes, multiply it by 8 to use vl_to_zcr() later + */ + hw_vl = sve_get_hw_vl() * 8U; + + /* Restore CPTR_EL2 */ + WRITE_SYSREG(cptr_bits, CPTR_EL2); + isb(); + + return vl_to_zcr(hw_vl); +} + +/* Takes a vector length in bits and returns the ZCR_ELx encoding */ +register_t vl_to_zcr(unsigned int vl) +{ + ASSERT(vl > 0); + return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; +} diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index c4ec38bb2554..83b84368f6d5 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -9,6 +9,7 @@ #include #include #include +#include #include DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS); @@ -143,6 +144,9 @@ void identify_cpu(struct cpuinfo_arm *c) c->zfr64.bits[0] = READ_SYSREG(ID_AA64ZFR0_EL1); + if ( cpu_has_sve ) + c->zcr64.bits[0] = compute_max_zcr(); + c->dczid.bits[0] = READ_SYSREG(DCZID_EL0); c->ctr.bits[0] = READ_SYSREG(CTR_EL0); @@ -199,7 +203,7 @@ static int __init create_guest_cpuinfo(void) guest_cpuinfo.pfr64.mpam = 0; guest_cpuinfo.pfr64.mpam_frac = 0; - /* Hide SVE as Xen does not support it */ + /* Hide SVE by default to the guests */ guest_cpuinfo.pfr64.sve = 0; guest_cpuinfo.zfr64.bits[0] = 0; diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 99577adb6c69..adb6ace2e24d 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -181,9 +181,6 @@ static void ctxt_switch_to(struct vcpu *n) /* VGIC */ gic_restore_state(n); - /* VFP */ - vfp_restore_state(n); - /* XXX MPU */ /* Fault Status */ @@ -234,6 +231,7 @@ static void ctxt_switch_to(struct vcpu *n) p2m_restore_state(n); /* Control Registers */ + WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); WRITE_SYSREG(n->arch.cpacr, CPACR_EL1); /* @@ -258,6 +256,9 @@ static void ctxt_switch_to(struct vcpu *n) #endif isb(); + /* VFP */ + vfp_restore_state(n); + /* CP 15 */ WRITE_SYSREG(n->arch.csselr, CSSELR_EL1); @@ -548,6 +549,8 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); + v->arch.cptr_el2 = get_default_cptr_flags(); + v->arch.hcr_el2 = get_default_hcr_flags(); v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA; diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h new file mode 100644 index 000000000000..144d2b1cc485 --- /dev/null +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#ifndef _ARM_ARM64_SVE_H +#define _ARM_ARM64_SVE_H + +#define SVE_VL_MAX_BITS (2048U) + +/* Vector length must be multiple of 128 */ +#define SVE_VL_MULTIPLE_VAL (128U) + +#ifdef CONFIG_ARM64_SVE + +register_t compute_max_zcr(void); +register_t vl_to_zcr(unsigned int vl); + +#else /* !CONFIG_ARM64_SVE */ + +static inline register_t compute_max_zcr(void) +{ + return 0; +} + +static inline register_t vl_to_zcr(unsigned int vl) +{ + return 0; +} + +#endif /* CONFIG_ARM64_SVE */ + +#endif /* _ARM_ARM64_SVE_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 463899951414..4cabb9eb4d5e 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -24,6 +24,7 @@ #define ICH_EISR_EL2 S3_4_C12_C11_3 #define ICH_ELSR_EL2 S3_4_C12_C11_5 #define ICH_VMCR_EL2 S3_4_C12_C11_7 +#define ZCR_EL2 S3_4_C1_C2_0 #define __LR0_EL2(x) S3_4_C12_C12_ ## x #define __LR8_EL2(x) S3_4_C12_C13_ ## x diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index c62cf6293fd6..6d703e051906 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -32,6 +32,12 @@ #define cpu_has_thumbee (boot_cpu_feature32(thumbee) == 1) #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) +#ifdef CONFIG_ARM64_SVE +#define cpu_has_sve (boot_cpu_feature64(sve) == 1) +#else +#define cpu_has_sve (0) +#endif + #ifdef CONFIG_ARM_32 #define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) @@ -323,6 +329,14 @@ struct cpuinfo_arm { }; } isa64; + union { + register_t bits[1]; + struct { + unsigned long len:4; + unsigned long __res0:60; + }; + } zcr64; + struct { register_t bits[1]; } zfr64; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 2a51f0ca688e..e776ee704b7d 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -190,6 +190,7 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t cptr_el2; register_t hcr_el2; register_t mdcr_el2; diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 54f253087718..bc683334125c 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -582,6 +582,8 @@ void do_trap_guest_serror(struct cpu_user_regs *regs); register_t get_default_hcr_flags(void); +register_t get_default_cptr_flags(void); + /* * Synchronize SError unless the feature is selected. * This is relying on the SErrors are currently unmasked. diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90e3..5459cc4f5e62 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -135,10 +135,11 @@ static void __init processor_id(void) cpu_has_el2_32 ? "64+32" : cpu_has_el2_64 ? "64" : "No", cpu_has_el1_32 ? "64+32" : cpu_has_el1_64 ? "64" : "No", cpu_has_el0_32 ? "64+32" : cpu_has_el0_64 ? "64" : "No"); - printk(" Extensions:%s%s%s\n", + printk(" Extensions:%s%s%s%s\n", cpu_has_fp ? " FloatingPoint" : "", cpu_has_simd ? " AdvancedSIMD" : "", - cpu_has_gicv3 ? " GICv3-SysReg" : ""); + cpu_has_gicv3 ? " GICv3-SysReg" : "", + cpu_has_sve ? " SVE" : ""); /* Warn user if we find unknown floating-point features */ if ( cpu_has_fp && (boot_cpu_feature64(fp) >= 2) ) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd68..a78a99ddadd0 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -93,6 +93,21 @@ register_t get_default_hcr_flags(void) HCR_TID3|HCR_TSC|HCR_TAC|HCR_SWIO|HCR_TIDCP|HCR_FB|HCR_TSW); } +register_t get_default_cptr_flags(void) +{ + /* + * Trap all coprocessor registers (0-13) except cp10 and + * cp11 for VFP. + * + * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. + * + * On ARM64 the TCPx bits which we set here (0..9,12,13) are all + * RES1, i.e. they would trap whether we did this write or not. + */ + return ((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | + HCPTR_TTA | HCPTR_TAM); +} + static enum { SERRORS_DIVERSE, SERRORS_PANIC, @@ -122,6 +137,7 @@ __initcall(update_serrors_cpu_caps); void init_traps(void) { + register_t cptr_bits = get_default_cptr_flags(); /* * Setup Hyp vector base. Note they might get updated with the * branch predictor hardening. @@ -135,17 +151,7 @@ void init_traps(void) /* Trap CP15 c15 used for implementation defined registers */ WRITE_SYSREG(HSTR_T(15), HSTR_EL2); - /* Trap all coprocessor registers (0-13) except cp10 and - * cp11 for VFP. - * - * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. - * - * On ARM64 the TCPx bits which we set here (0..9,12,13) are all - * RES1, i.e. they would trap whether we did this write or not. - */ - WRITE_SYSREG((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | - HCPTR_TTA | HCPTR_TAM, - CPTR_EL2); + WRITE_SYSREG(cptr_bits, CPTR_EL2); /* * Configure HCR_EL2 with the bare minimum to run Xen until a guest -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:49:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520089.807332 (Exim 4.92) (envelope-from ) id 1pmX6x-0004lm-Ln; Wed, 12 Apr 2023 09:49:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520089.807332; Wed, 12 Apr 2023 09:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6x-0004lf-Iy; Wed, 12 Apr 2023 09:49:55 +0000 Received: by outflank-mailman (input) for mailman id 520089; Wed, 12 Apr 2023 09:49:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6v-0004lO-L7 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5d4f5d4b-d917-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:49:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11FF5C14; Wed, 12 Apr 2023 02:50:34 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53B1F3F587; Wed, 12 Apr 2023 02:49:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d4f5d4b-d917-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Nick Rosbrook , Anthony PERARD , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Henry Wang , Community Manager Subject: [PATCH v5 00/12] SVE feature for arm guests Date: Wed, 12 Apr 2023 10:49:26 +0100 Message-Id: <20230412094938.2693890-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This serie is introducing the possibility for Dom0 and DomU guests to use sve/sve2 instructions. SVE feature introduces new instruction and registers to improve performances on floating point operations. The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE field, and when available the ID_AA64ZFR0_EL1 register provides additional information about the implemented version and other SVE feature. New registers added by the SVE feature are Z0-Z31, P0-P15, FFR, ZCR_ELx. Z0-Z31 are scalable vector register whose size is implementation defined and goes from 128 bits to maximum 2048, the term vector length will be used to refer to this quantity. P0-P15 are predicate registers and the size is the vector length divided by 8, same size is the FFR (First Fault Register). ZCR_ELx is a register that can control and restrict the maximum vector length used by the exception level and all the lower exception levels, so for example EL3 can restrict the vector length usable by EL3,2,1,0. The platform has a maximum implemented vector length, so for every value written in ZCR register, if this value is above the implemented length, then the lower value will be used. The RDVL instruction can be used to check what vector length is the HW using after setting ZCR. For an SVE guest, the V0-V31 registers are part of the Z0-Z31, so there is no need to save them separately, saving Z0-Z31 will save implicitly also V0-V31. SVE usage can be trapped using a flag in CPTR_EL2, hence in this serie the register is added to the domain state, to be able to trap only the guests that are not allowed to use SVE. This serie is introducing a command line parameter to enable Dom0 to use SVE and to set its maximum vector length that by default is 0 which means the guest is not allowed to use SVE. Values from 128 to 2048 mean the guest can use SVE with the selected value used as maximum allowed vector length (which could be lower if the implemented one is lower). For DomUs, an XL parameter with the same way of use is introduced and a dom0less DTB binding is created. The context switch is the most critical part because there can be big registers to be saved, in this serie an easy approach is used and the context is saved/restored every time for the guests that are allowed to use SVE. Luca Fancellu (12): xen/arm: enable SVE extension for Xen xen/arm: add SVE vector length field to the domain xen/arm: Expose SVE feature to the guest xen/arm: add SVE exception class handling arm/sve: save/restore SVE context switch xen/common: add dom0 xen command line argument for Arm xen: enable Dom0 to use SVE feature xen/physinfo: encode Arm SVE vector length in arch_capabilities tools: add physinfo arch_capabilities handling for Arm xen/tools: add sve parameter in XL configuration xen/arm: add sve property for dom0less domUs xen/changelog: Add SVE and "dom0" options to the changelog for Arm CHANGELOG.md | 5 + docs/man/xl.cfg.5.pod.in | 15 ++ docs/misc/arm/device-tree/booting.txt | 11 + docs/misc/xen-command-line.pandoc | 18 +- tools/golang/xenlight/helpers.gen.go | 4 + tools/golang/xenlight/types.gen.go | 24 +++ tools/include/libxl.h | 11 + .../include/xen-tools/arm-arch-capabilities.h | 28 +++ tools/include/xen-tools/common-macros.h | 2 + tools/libs/light/libxl.c | 1 + tools/libs/light/libxl_arm.c | 28 +++ tools/libs/light/libxl_internal.h | 1 - tools/libs/light/libxl_types.idl | 23 +++ tools/ocaml/libs/xc/xenctrl.ml | 4 +- tools/ocaml/libs/xc/xenctrl.mli | 4 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 8 +- tools/python/xen/lowlevel/xc/xc.c | 8 +- tools/xl/xl_info.c | 8 + tools/xl/xl_parse.c | 8 + xen/arch/arm/Kconfig | 10 +- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/cpufeature.c | 7 +- xen/arch/arm/arm64/sve-asm.S | 189 ++++++++++++++++++ xen/arch/arm/arm64/sve.c | 141 +++++++++++++ xen/arch/arm/arm64/vfp.c | 79 ++++---- xen/arch/arm/arm64/vsysreg.c | 39 +++- xen/arch/arm/cpufeature.c | 6 +- xen/arch/arm/domain.c | 43 +++- xen/arch/arm/domain_build.c | 56 ++++++ xen/arch/arm/include/asm/arm64/sve.h | 83 ++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 4 + xen/arch/arm/include/asm/arm64/vfp.h | 10 + xen/arch/arm/include/asm/cpufeature.h | 14 ++ xen/arch/arm/include/asm/domain.h | 8 + xen/arch/arm/include/asm/processor.h | 3 + xen/arch/arm/setup.c | 5 +- xen/arch/arm/sysctl.c | 4 + xen/arch/arm/traps.c | 40 +++- xen/arch/x86/dom0_build.c | 48 ++--- xen/common/domain.c | 23 +++ xen/common/kernel.c | 25 +++ xen/include/public/arch-arm.h | 2 + xen/include/public/domctl.h | 2 +- xen/include/public/sysctl.h | 4 + xen/include/xen/domain.h | 1 + xen/include/xen/lib.h | 10 + 46 files changed, 963 insertions(+), 105 deletions(-) create mode 100644 tools/include/xen-tools/arm-arch-capabilities.h create mode 100644 xen/arch/arm/arm64/sve-asm.S create mode 100644 xen/arch/arm/arm64/sve.c create mode 100644 xen/arch/arm/include/asm/arm64/sve.h -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:49:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:49:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520092.807360 (Exim 4.92) (envelope-from ) id 1pmX6z-0005UZ-Lx; Wed, 12 Apr 2023 09:49:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520092.807360; Wed, 12 Apr 2023 09:49:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6z-0005TL-Hq; Wed, 12 Apr 2023 09:49:57 +0000 Received: by outflank-mailman (input) for mailman id 520092; Wed, 12 Apr 2023 09:49:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6x-0004lO-NT for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5f8292ed-d917-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:49:53 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E05321691; Wed, 12 Apr 2023 02:50:37 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 944A23F587; Wed, 12 Apr 2023 02:49:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f8292ed-d917-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v5 03/12] xen/arm: Expose SVE feature to the guest Date: Wed, 12 Apr 2023 10:49:29 +0100 Message-Id: <20230412094938.2693890-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a guest is allowed to use SVE, expose the SVE features through the identification registers. Signed-off-by: Luca Fancellu --- CHanges from v4: - no changes Changes from v3: - no changes Changes from v2: - no changes Changes from v1: - No changes Changes from RFC: - No changes --- xen/arch/arm/arm64/vsysreg.c | 39 ++++++++++++++++++++++++++++++++++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index 758750983c11..10048bb4d221 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -18,6 +18,7 @@ #include +#include #include #include #include @@ -295,7 +296,28 @@ void do_sysreg(struct cpu_user_regs *regs, GENERATE_TID3_INFO(MVFR0_EL1, mvfr, 0) GENERATE_TID3_INFO(MVFR1_EL1, mvfr, 1) GENERATE_TID3_INFO(MVFR2_EL1, mvfr, 2) - GENERATE_TID3_INFO(ID_AA64PFR0_EL1, pfr64, 0) + + case HSR_SYSREG_ID_AA64PFR0_EL1: + { + register_t guest_reg_value = guest_cpuinfo.pfr64.bits[0]; + + if ( is_sve_domain(v->domain) ) + { + /* 4 is the SVE field width in id_aa64pfr0_el1 */ + uint64_t mask = GENMASK(ID_AA64PFR0_SVE_SHIFT + 4 - 1, + ID_AA64PFR0_SVE_SHIFT); + /* sysval is the sve field on the system */ + uint64_t sysval = cpuid_feature_extract_unsigned_field_width( + system_cpuinfo.pfr64.bits[0], + ID_AA64PFR0_SVE_SHIFT, 4); + guest_reg_value &= ~mask; + guest_reg_value |= (sysval << ID_AA64PFR0_SVE_SHIFT) & mask; + } + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } + GENERATE_TID3_INFO(ID_AA64PFR1_EL1, pfr64, 1) GENERATE_TID3_INFO(ID_AA64DFR0_EL1, dbg64, 0) GENERATE_TID3_INFO(ID_AA64DFR1_EL1, dbg64, 1) @@ -306,7 +328,20 @@ void do_sysreg(struct cpu_user_regs *regs, GENERATE_TID3_INFO(ID_AA64MMFR2_EL1, mm64, 2) GENERATE_TID3_INFO(ID_AA64AFR0_EL1, aux64, 0) GENERATE_TID3_INFO(ID_AA64AFR1_EL1, aux64, 1) - GENERATE_TID3_INFO(ID_AA64ZFR0_EL1, zfr64, 0) + + case HSR_SYSREG_ID_AA64ZFR0_EL1: + { + /* + * When the guest has the SVE feature enabled, the whole id_aa64zfr0_el1 + * needs to be exposed. + */ + register_t guest_reg_value = guest_cpuinfo.zfr64.bits[0]; + if ( is_sve_domain(v->domain) ) + guest_reg_value = system_cpuinfo.zfr64.bits[0]; + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } /* * Those cases are catching all Reserved registers trapped by TID3 which -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:49:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:49:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520093.807367 (Exim 4.92) (envelope-from ) id 1pmX70-0005ZH-3l; Wed, 12 Apr 2023 09:49:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520093.807367; Wed, 12 Apr 2023 09:49:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6z-0005YF-TV; Wed, 12 Apr 2023 09:49:57 +0000 Received: by outflank-mailman (input) for mailman id 520093; Wed, 12 Apr 2023 09:49:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6x-0004lU-Mb for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 60c4e9c5-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:49:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 03FA21684; Wed, 12 Apr 2023 02:50:39 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC3433F587; Wed, 12 Apr 2023 02:49:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c4e9c5-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v5 04/12] xen/arm: add SVE exception class handling Date: Wed, 12 Apr 2023 10:49:30 +0100 Message-Id: <20230412094938.2693890-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SVE has a new exception class with code 0x19, introduce the new code and handle the exception. Signed-off-by: Luca Fancellu --- Changes from v4: - No changes Changes from v3: - No changes Changes from v2: - No changes Changes from v1: - No changes Changes from RFC: - No changes --- xen/arch/arm/include/asm/processor.h | 1 + xen/arch/arm/traps.c | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index bc683334125c..7e42ff8811fc 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -426,6 +426,7 @@ #define HSR_EC_HVC64 0x16 #define HSR_EC_SMC64 0x17 #define HSR_EC_SYSREG 0x18 +#define HSR_EC_SVE 0x19 #endif #define HSR_EC_INSTR_ABORT_LOWER_EL 0x20 #define HSR_EC_INSTR_ABORT_CURR_EL 0x21 diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index a78a99ddadd0..c2e30feafd5a 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -2160,6 +2160,13 @@ void do_trap_guest_sync(struct cpu_user_regs *regs) perfc_incr(trap_sysreg); do_sysreg(regs, hsr); break; + case HSR_EC_SVE: + GUEST_BUG_ON(regs_mode_is_32bit(regs)); + gprintk(XENLOG_WARNING, + "Domain id %d tried to use SVE while not allowed\n", + current->domain->domain_id); + inject_undef_exception(regs, hsr); + break; #endif case HSR_EC_INSTR_ABORT_LOWER_EL: @@ -2189,6 +2196,11 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) case HSR_EC_BRK: do_trap_brk(regs, hsr); break; + case HSR_EC_SVE: + /* An SVE exception is a bug somewhere in hypervisor code */ + printk("SVE trap at EL2.\n"); + do_unexpected_trap("Hypervisor", regs); + break; #endif case HSR_EC_DATA_ABORT_CURR_EL: case HSR_EC_INSTR_ABORT_CURR_EL: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:49:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520094.807380 (Exim 4.92) (envelope-from ) id 1pmX71-00061A-Bf; Wed, 12 Apr 2023 09:49:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520094.807380; Wed, 12 Apr 2023 09:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX71-0005zh-7j; Wed, 12 Apr 2023 09:49:59 +0000 Received: by outflank-mailman (input) for mailman id 520094; Wed, 12 Apr 2023 09:49:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX6z-0004lU-Ic for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6181944e-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:49:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 379A31691; Wed, 12 Apr 2023 02:50:40 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4ED53F587; Wed, 12 Apr 2023 02:49:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6181944e-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v5 05/12] arm/sve: save/restore SVE context switch Date: Wed, 12 Apr 2023 10:49:31 +0100 Message-Id: <20230412094938.2693890-6-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR who can be maximum 256 bits, the allocated memory depends on how many bits is the vector length for the domain and how many bits are supported by the platform. Save P0-15 whose length is maximum 256 bits each, in this case the memory used is from the fpregs field in struct vfp_state, because V0-31 are part of Z0-31 and this space would have been unused for SVE domain otherwise. Create zcr_el{1,2} fields in arch_vcpu, initialise zcr_el2 on vcpu creation given the requested vector length and restore it on context switch, save/restore ZCR_EL1 value as well. Remove headers from sve.c that are already included using xen/sched.h. Signed-off-by: Luca Fancellu --- Changes from v4: - No changes Changes from v3: - don't use fixed len types when not needed (Jan) - now VL is an encoded value, decode it before using. Changes from v2: - No changes Changes from v1: - No changes Changes from RFC: - Moved zcr_el2 field introduction in this patch, restore its content inside sve_restore_state function. (Julien) --- xen/arch/arm/arm64/sve-asm.S | 141 +++++++++++++++++++++++ xen/arch/arm/arm64/sve.c | 68 ++++++++++- xen/arch/arm/arm64/vfp.c | 79 +++++++------ xen/arch/arm/domain.c | 7 ++ xen/arch/arm/include/asm/arm64/sve.h | 13 +++ xen/arch/arm/include/asm/arm64/sysregs.h | 3 + xen/arch/arm/include/asm/arm64/vfp.h | 10 ++ xen/arch/arm/include/asm/domain.h | 2 + 8 files changed, 284 insertions(+), 39 deletions(-) diff --git a/xen/arch/arm/arm64/sve-asm.S b/xen/arch/arm/arm64/sve-asm.S index 4d1549344733..8c37d7bc95d5 100644 --- a/xen/arch/arm/arm64/sve-asm.S +++ b/xen/arch/arm/arm64/sve-asm.S @@ -17,6 +17,18 @@ .endif .endm +.macro _sve_check_zreg znr + .if (\znr) < 0 || (\znr) > 31 + .error "Bad Scalable Vector Extension vector register number \znr." + .endif +.endm + +.macro _sve_check_preg pnr + .if (\pnr) < 0 || (\pnr) > 15 + .error "Bad Scalable Vector Extension predicate register number \pnr." + .endif +.endm + .macro _check_num n, min, max .if (\n) < (\min) || (\n) > (\max) .error "Number \n out of range [\min,\max]" @@ -26,6 +38,54 @@ /* SVE instruction encodings for non-SVE-capable assemblers */ /* (pre binutils 2.28, all kernel capable clang versions support SVE) */ +/* STR (vector): STR Z\nz, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_str_v nz, nxbase, offset=0 + _sve_check_zreg \nz + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe5804000 \ + | (\nz) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* LDR (vector): LDR Z\nz, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_ldr_v nz, nxbase, offset=0 + _sve_check_zreg \nz + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0x85804000 \ + | (\nz) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* STR (predicate): STR P\np, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_str_p np, nxbase, offset=0 + _sve_check_preg \np + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe5800000 \ + | (\np) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* LDR (predicate): LDR P\np, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_ldr_p np, nxbase, offset=0 + _sve_check_preg \np + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0x85800000 \ + | (\np) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + /* RDVL X\nx, #\imm */ .macro _sve_rdvl nx, imm _check_general_reg \nx @@ -35,11 +95,92 @@ | (((\imm) & 0x3f) << 5) .endm +/* RDFFR (unpredicated): RDFFR P\np.B */ +.macro _sve_rdffr np + _sve_check_preg \np + .inst 0x2519f000 \ + | (\np) +.endm + +/* WRFFR P\np.B */ +.macro _sve_wrffr np + _sve_check_preg \np + .inst 0x25289000 \ + | ((\np) << 5) +.endm + +.macro __for from:req, to:req + .if (\from) == (\to) + _for__body %\from + .else + __for %\from, %((\from) + ((\to) - (\from)) / 2) + __for %((\from) + ((\to) - (\from)) / 2 + 1), %\to + .endif +.endm + +.macro _for var:req, from:req, to:req, insn:vararg + .macro _for__body \var:req + .noaltmacro + \insn + .altmacro + .endm + + .altmacro + __for \from, \to + .noaltmacro + + .purgem _for__body +.endm + +.macro sve_save nxzffrctx, nxpctx, save_ffr + _for n, 0, 31, _sve_str_v \n, \nxzffrctx, \n - 32 + _for n, 0, 15, _sve_str_p \n, \nxpctx, \n + cbz \save_ffr, 1f + _sve_rdffr 0 + _sve_str_p 0, \nxzffrctx + _sve_ldr_p 0, \nxpctx + b 2f +1: + str xzr, [x\nxzffrctx] // Zero out FFR +2: +.endm + +.macro sve_load nxzffrctx, nxpctx, restore_ffr + _for n, 0, 31, _sve_ldr_v \n, \nxzffrctx, \n - 32 + cbz \restore_ffr, 1f + _sve_ldr_p 0, \nxzffrctx + _sve_wrffr 0 +1: + _for n, 0, 15, _sve_ldr_p \n, \nxpctx, \n +.endm + /* Gets the current vector register size in bytes */ GLOBAL(sve_get_hw_vl) _sve_rdvl 0, 1 ret +/* + * Save the SVE context + * + * x0 - pointer to buffer for Z0-31 + FFR + * x1 - pointer to buffer for P0-15 + * x2 - Save FFR if non-zero + */ +GLOBAL(sve_save_ctx) + sve_save 0, 1, x2 + ret + +/* + * Load the SVE context + * + * x0 - pointer to buffer for Z0-31 + FFR + * x1 - pointer to buffer for P0-15 + * x2 - Restore FFR if non-zero + */ +GLOBAL(sve_load_ctx) + sve_load 0, 1, x2 + ret + /* * Local variables: * mode: ASM diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index 78f7482619da..5485648850a0 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -5,14 +5,29 @@ * Copyright (C) 2022 ARM Ltd. */ -#include -#include +#include +#include #include -#include -#include -#include extern unsigned int sve_get_hw_vl(void); +extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); +extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, + int restore_ffr); + +static inline unsigned int sve_zreg_ctx_size(unsigned int vl) +{ + /* + * Z0-31 registers size in bytes is computed from VL that is in bits, so VL + * in bytes is VL/8. + */ + return (vl / 8U) * 32U; +} + +static inline unsigned int sve_ffrreg_ctx_size(unsigned int vl) +{ + /* FFR register size is VL/8, which is in bytes (VL/8)/8 */ + return (vl / 64U); +} register_t compute_max_zcr(void) { @@ -60,3 +75,46 @@ unsigned int get_sys_vl_len(void) return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * SVE_VL_MULTIPLE_VAL; } + +int sve_context_init(struct vcpu *v) +{ + unsigned int sve_vl_bits = sve_decode_vl(v->domain->arch.sve_vl); + uint64_t *ctx = _xzalloc(sve_zreg_ctx_size(sve_vl_bits) + + sve_ffrreg_ctx_size(sve_vl_bits), + L1_CACHE_BYTES); + + if ( !ctx ) + return -ENOMEM; + + v->arch.vfp.sve_context = ctx; + + return 0; +} + +void sve_context_free(struct vcpu *v) +{ + xfree(v->arch.vfp.sve_context); +} + +void sve_save_state(struct vcpu *v) +{ + unsigned int sve_vl_bits = sve_decode_vl(v->domain->arch.sve_vl); + uint64_t *sve_ctx_zreg_end = v->arch.vfp.sve_context + + (sve_zreg_ctx_size(sve_vl_bits) / sizeof(uint64_t)); + + v->arch.zcr_el1 = READ_SYSREG(ZCR_EL1); + + sve_save_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); +} + +void sve_restore_state(struct vcpu *v) +{ + unsigned int sve_vl_bits = sve_decode_vl(v->domain->arch.sve_vl); + uint64_t *sve_ctx_zreg_end = v->arch.vfp.sve_context + + (sve_zreg_ctx_size(sve_vl_bits) / sizeof(uint64_t)); + + WRITE_SYSREG(v->arch.zcr_el1, ZCR_EL1); + WRITE_SYSREG(v->arch.zcr_el2, ZCR_EL2); + + sve_load_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); +} diff --git a/xen/arch/arm/arm64/vfp.c b/xen/arch/arm/arm64/vfp.c index 47885e76baae..2d0d7c2e6ddb 100644 --- a/xen/arch/arm/arm64/vfp.c +++ b/xen/arch/arm/arm64/vfp.c @@ -2,29 +2,35 @@ #include #include #include +#include void vfp_save_state(struct vcpu *v) { if ( !cpu_has_fp ) return; - asm volatile("stp q0, q1, [%1, #16 * 0]\n\t" - "stp q2, q3, [%1, #16 * 2]\n\t" - "stp q4, q5, [%1, #16 * 4]\n\t" - "stp q6, q7, [%1, #16 * 6]\n\t" - "stp q8, q9, [%1, #16 * 8]\n\t" - "stp q10, q11, [%1, #16 * 10]\n\t" - "stp q12, q13, [%1, #16 * 12]\n\t" - "stp q14, q15, [%1, #16 * 14]\n\t" - "stp q16, q17, [%1, #16 * 16]\n\t" - "stp q18, q19, [%1, #16 * 18]\n\t" - "stp q20, q21, [%1, #16 * 20]\n\t" - "stp q22, q23, [%1, #16 * 22]\n\t" - "stp q24, q25, [%1, #16 * 24]\n\t" - "stp q26, q27, [%1, #16 * 26]\n\t" - "stp q28, q29, [%1, #16 * 28]\n\t" - "stp q30, q31, [%1, #16 * 30]\n\t" - : "=Q" (*v->arch.vfp.fpregs) : "r" (v->arch.vfp.fpregs)); + if ( is_sve_domain(v->domain) ) + sve_save_state(v); + else + { + asm volatile("stp q0, q1, [%1, #16 * 0]\n\t" + "stp q2, q3, [%1, #16 * 2]\n\t" + "stp q4, q5, [%1, #16 * 4]\n\t" + "stp q6, q7, [%1, #16 * 6]\n\t" + "stp q8, q9, [%1, #16 * 8]\n\t" + "stp q10, q11, [%1, #16 * 10]\n\t" + "stp q12, q13, [%1, #16 * 12]\n\t" + "stp q14, q15, [%1, #16 * 14]\n\t" + "stp q16, q17, [%1, #16 * 16]\n\t" + "stp q18, q19, [%1, #16 * 18]\n\t" + "stp q20, q21, [%1, #16 * 20]\n\t" + "stp q22, q23, [%1, #16 * 22]\n\t" + "stp q24, q25, [%1, #16 * 24]\n\t" + "stp q26, q27, [%1, #16 * 26]\n\t" + "stp q28, q29, [%1, #16 * 28]\n\t" + "stp q30, q31, [%1, #16 * 30]\n\t" + : "=Q" (*v->arch.vfp.fpregs) : "r" (v->arch.vfp.fpregs)); + } v->arch.vfp.fpsr = READ_SYSREG(FPSR); v->arch.vfp.fpcr = READ_SYSREG(FPCR); @@ -37,23 +43,28 @@ void vfp_restore_state(struct vcpu *v) if ( !cpu_has_fp ) return; - asm volatile("ldp q0, q1, [%1, #16 * 0]\n\t" - "ldp q2, q3, [%1, #16 * 2]\n\t" - "ldp q4, q5, [%1, #16 * 4]\n\t" - "ldp q6, q7, [%1, #16 * 6]\n\t" - "ldp q8, q9, [%1, #16 * 8]\n\t" - "ldp q10, q11, [%1, #16 * 10]\n\t" - "ldp q12, q13, [%1, #16 * 12]\n\t" - "ldp q14, q15, [%1, #16 * 14]\n\t" - "ldp q16, q17, [%1, #16 * 16]\n\t" - "ldp q18, q19, [%1, #16 * 18]\n\t" - "ldp q20, q21, [%1, #16 * 20]\n\t" - "ldp q22, q23, [%1, #16 * 22]\n\t" - "ldp q24, q25, [%1, #16 * 24]\n\t" - "ldp q26, q27, [%1, #16 * 26]\n\t" - "ldp q28, q29, [%1, #16 * 28]\n\t" - "ldp q30, q31, [%1, #16 * 30]\n\t" - : : "Q" (*v->arch.vfp.fpregs), "r" (v->arch.vfp.fpregs)); + if ( is_sve_domain(v->domain) ) + sve_restore_state(v); + else + { + asm volatile("ldp q0, q1, [%1, #16 * 0]\n\t" + "ldp q2, q3, [%1, #16 * 2]\n\t" + "ldp q4, q5, [%1, #16 * 4]\n\t" + "ldp q6, q7, [%1, #16 * 6]\n\t" + "ldp q8, q9, [%1, #16 * 8]\n\t" + "ldp q10, q11, [%1, #16 * 10]\n\t" + "ldp q12, q13, [%1, #16 * 12]\n\t" + "ldp q14, q15, [%1, #16 * 14]\n\t" + "ldp q16, q17, [%1, #16 * 16]\n\t" + "ldp q18, q19, [%1, #16 * 18]\n\t" + "ldp q20, q21, [%1, #16 * 20]\n\t" + "ldp q22, q23, [%1, #16 * 22]\n\t" + "ldp q24, q25, [%1, #16 * 24]\n\t" + "ldp q26, q27, [%1, #16 * 26]\n\t" + "ldp q28, q29, [%1, #16 * 28]\n\t" + "ldp q30, q31, [%1, #16 * 30]\n\t" + : : "Q" (*v->arch.vfp.fpregs), "r" (v->arch.vfp.fpregs)); + } WRITE_SYSREG(v->arch.vfp.fpsr, FPSR); WRITE_SYSREG(v->arch.vfp.fpcr, FPCR); diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 769fae8fe25e..060fc30bbb5d 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -552,7 +552,12 @@ int arch_vcpu_create(struct vcpu *v) v->arch.cptr_el2 = get_default_cptr_flags(); if ( is_sve_domain(v->domain) ) + { + if ( (rc = sve_context_init(v)) != 0 ) + goto fail; v->arch.cptr_el2 &= ~HCPTR_CP(8); + v->arch.zcr_el2 = vl_to_zcr(sve_decode_vl(v->domain->arch.sve_vl)); + } v->arch.hcr_el2 = get_default_hcr_flags(); @@ -582,6 +587,8 @@ fail: void arch_vcpu_destroy(struct vcpu *v) { + if ( is_sve_domain(v->domain) ) + sve_context_free(v); vcpu_timer_destroy(v); vcpu_vgic_free(v); free_xenheap_pages(v->arch.stack, STACK_ORDER); diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index a4c53e3e8e2e..fc162c9d2cf7 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -24,6 +24,10 @@ static inline unsigned int sve_decode_vl(unsigned int sve_vl) register_t compute_max_zcr(void); register_t vl_to_zcr(unsigned int vl); unsigned int get_sys_vl_len(void); +int sve_context_init(struct vcpu *v); +void sve_context_free(struct vcpu *v); +void sve_save_state(struct vcpu *v); +void sve_restore_state(struct vcpu *v); #else /* !CONFIG_ARM64_SVE */ @@ -42,6 +46,15 @@ static inline unsigned int get_sys_vl_len(void) return 0; } +static inline int sve_context_init(struct vcpu *v) +{ + return 0; +} + +static inline void sve_context_free(struct vcpu *v) {} +static inline void sve_save_state(struct vcpu *v) {} +static inline void sve_restore_state(struct vcpu *v) {} + #endif /* CONFIG_ARM64_SVE */ #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 4cabb9eb4d5e..3fdeb9d8cdef 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -88,6 +88,9 @@ #ifndef ID_AA64ISAR2_EL1 #define ID_AA64ISAR2_EL1 S3_0_C0_C6_2 #endif +#ifndef ZCR_EL1 +#define ZCR_EL1 S3_0_C1_C2_0 +#endif /* ID registers (imported from arm64/include/asm/sysreg.h in Linux) */ diff --git a/xen/arch/arm/include/asm/arm64/vfp.h b/xen/arch/arm/include/asm/arm64/vfp.h index e6e8c363bc16..8af714cb8ecc 100644 --- a/xen/arch/arm/include/asm/arm64/vfp.h +++ b/xen/arch/arm/include/asm/arm64/vfp.h @@ -6,7 +6,17 @@ struct vfp_state { + /* + * When SVE is enabled for the guest, fpregs memory will be used to + * save/restore P0-P15 registers, otherwise it will be used for the V0-V31 + * registers. + */ uint64_t fpregs[64] __vfp_aligned; + /* + * When SVE is enabled for the guest, sve_context contains memory to + * save/restore Z0-Z31 registers and FFR. + */ + uint64_t *sve_context; register_t fpcr; register_t fpexc32_el2; register_t fpsr; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 78cc2da3d4e5..6b5ec3bd0680 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -195,6 +195,8 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t zcr_el1; + register_t zcr_el2; register_t cptr_el2; register_t hcr_el2; register_t mdcr_el2; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520095.807391 (Exim 4.92) (envelope-from ) id 1pmX73-0006Qu-OQ; Wed, 12 Apr 2023 09:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520095.807391; Wed, 12 Apr 2023 09:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX73-0006QJ-KH; Wed, 12 Apr 2023 09:50:01 +0000 Received: by outflank-mailman (input) for mailman id 520095; Wed, 12 Apr 2023 09:49:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX71-0004lO-R7 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:49:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 61d7f23c-d917-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:49:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D61281684; Wed, 12 Apr 2023 02:50:41 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 04F2F3F587; Wed, 12 Apr 2023 02:49:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61d7f23c-d917-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v5 06/12] xen/common: add dom0 xen command line argument for Arm Date: Wed, 12 Apr 2023 10:49:32 +0100 Message-Id: <20230412094938.2693890-7-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently x86 defines a Xen command line argument dom0= where there can be specified dom0 controlling sub-options, to use it also on Arm, move the code that loops through the list of arguments from x86 to the common code and from there, call architecture specific functions to handle the comma separated sub-options. No functional changes are intended. Signed-off-by: Luca Fancellu Reviewed-by: Jan Beulich --- Changes from v4: - return EINVAL in Arm implementation of parse_arch_dom0_param, shorten variable name in the funtion from str_begin, str_end to s, e. Removed variable rc from x86 parse_arch_dom0_param implementation. (Jan) - Add R-By Jan Changes from v3: - new patch --- xen/arch/arm/domain_build.c | 5 ++++ xen/arch/x86/dom0_build.c | 48 ++++++++++++++----------------------- xen/common/domain.c | 23 ++++++++++++++++++ xen/include/xen/domain.h | 1 + 4 files changed, 47 insertions(+), 30 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4f9d4f9d8867..eeb4662f0eee 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -59,6 +59,11 @@ static int __init parse_dom0_mem(const char *s) } custom_param("dom0_mem", parse_dom0_mem); +int __init parse_arch_dom0_param(const char *s, const char *e) +{ + return -EINVAL; +} + /* Override macros from asm/page.h to make them work with mfn_t */ #undef virt_to_mfn #define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 79234f18ff01..9f5300a3efbb 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -266,42 +266,30 @@ bool __initdata opt_dom0_pvh = !IS_ENABLED(CONFIG_PV); bool __initdata opt_dom0_verbose = IS_ENABLED(CONFIG_VERBOSE_DEBUG); bool __initdata opt_dom0_msr_relaxed; -static int __init cf_check parse_dom0_param(const char *s) +int __init parse_arch_dom0_param(const char *s, const char *e) { - const char *ss; - int rc = 0; + int val; - do { - int val; - - ss = strchr(s, ','); - if ( !ss ) - ss = strchr(s, '\0'); - - if ( IS_ENABLED(CONFIG_PV) && !cmdline_strcmp(s, "pv") ) - opt_dom0_pvh = false; - else if ( IS_ENABLED(CONFIG_HVM) && !cmdline_strcmp(s, "pvh") ) - opt_dom0_pvh = true; + if ( IS_ENABLED(CONFIG_PV) && !cmdline_strcmp(s, "pv") ) + opt_dom0_pvh = false; + else if ( IS_ENABLED(CONFIG_HVM) && !cmdline_strcmp(s, "pvh") ) + opt_dom0_pvh = true; #ifdef CONFIG_SHADOW_PAGING - else if ( (val = parse_boolean("shadow", s, ss)) >= 0 ) - opt_dom0_shadow = val; + else if ( (val = parse_boolean("shadow", s, e)) >= 0 ) + opt_dom0_shadow = val; #endif - else if ( (val = parse_boolean("verbose", s, ss)) >= 0 ) - opt_dom0_verbose = val; - else if ( IS_ENABLED(CONFIG_PV) && - (val = parse_boolean("cpuid-faulting", s, ss)) >= 0 ) - opt_dom0_cpuid_faulting = val; - else if ( (val = parse_boolean("msr-relaxed", s, ss)) >= 0 ) - opt_dom0_msr_relaxed = val; - else - rc = -EINVAL; - - s = ss + 1; - } while ( *ss ); + else if ( (val = parse_boolean("verbose", s, e)) >= 0 ) + opt_dom0_verbose = val; + else if ( IS_ENABLED(CONFIG_PV) && + (val = parse_boolean("cpuid-faulting", s, e)) >= 0 ) + opt_dom0_cpuid_faulting = val; + else if ( (val = parse_boolean("msr-relaxed", s, e)) >= 0 ) + opt_dom0_msr_relaxed = val; + else + return -EINVAL; - return rc; + return 0; } -custom_param("dom0", parse_dom0_param); static char __initdata opt_dom0_ioports_disable[200] = ""; string_param("dom0_ioports_disable", opt_dom0_ioports_disable); diff --git a/xen/common/domain.c b/xen/common/domain.c index 626debbae095..7779ba088675 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -364,6 +364,29 @@ static int __init cf_check parse_extra_guest_irqs(const char *s) } custom_param("extra_guest_irqs", parse_extra_guest_irqs); +static int __init cf_check parse_dom0_param(const char *s) +{ + const char *ss; + int rc = 0; + + do { + int ret; + + ss = strchr(s, ','); + if ( !ss ) + ss = strchr(s, '\0'); + + ret = parse_arch_dom0_param(s, ss); + if ( ret && !rc ) + rc = ret; + + s = ss + 1; + } while ( *ss ); + + return rc; +} +custom_param("dom0", parse_dom0_param); + /* * Release resources held by a domain. There may or may not be live * references to the domain, and it may or may not be fully constructed. diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 26f9c4f6dd5b..1df8f933d076 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -16,6 +16,7 @@ typedef union { struct vcpu *vcpu_create(struct domain *d, unsigned int vcpu_id); unsigned int dom0_max_vcpus(void); +int parse_arch_dom0_param(const char *s, const char *e); struct vcpu *alloc_dom0_vcpu0(struct domain *dom0); int vcpu_reset(struct vcpu *); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520096.807397 (Exim 4.92) (envelope-from ) id 1pmX74-0006UM-AW; Wed, 12 Apr 2023 09:50:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520096.807397; Wed, 12 Apr 2023 09:50:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX74-0006TF-0D; Wed, 12 Apr 2023 09:50:02 +0000 Received: by outflank-mailman (input) for mailman id 520096; Wed, 12 Apr 2023 09:50:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX72-0004lU-CY for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:50:00 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 635adcb8-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:49:59 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64ED8C14; Wed, 12 Apr 2023 02:50:43 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2CE13F587; Wed, 12 Apr 2023 02:49:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 635adcb8-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: [PATCH v5 07/12] xen: enable Dom0 to use SVE feature Date: Wed, 12 Apr 2023 10:49:33 +0100 Message-Id: <20230412094938.2693890-8-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a command line parameter to allow Dom0 the use of SVE resources, the command line parameter sve=, sub argument of dom0=, controls the feature on this domain and sets the maximum SVE vector length for Dom0. Add a new function, parse_signed_integer(), to parse an integer command line argument. Signed-off-by: Luca Fancellu --- Changes from v4: - Negative values as user param means max supported HW VL (Jan) - update documentation, make use of no_config_param(), rename parse_integer into parse_signed_integer and take long long *, also put a comment on the -2 return condition, update declaration comment to reflect the modifications (Jan) Changes from v3: - Don't use fixed len types when not needed (Jan) - renamed domainconfig_encode_vl to sve_encode_vl - Use a sub argument of dom0= to enable the feature (Jan) - Add parse_integer() function Changes from v2: - xen_domctl_createdomain field has changed into sve_vl and its value now is the VL / 128, create an helper function for that. Changes from v1: - No changes Changes from RFC: - Changed docs to explain that the domain won't be created if the requested vector length is above the supported one from the platform. --- docs/misc/xen-command-line.pandoc | 18 ++++++++++++++++-- xen/arch/arm/arm64/sve.c | 21 +++++++++++++++++++++ xen/arch/arm/domain_build.c | 27 +++++++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sve.h | 15 +++++++++++++++ xen/common/kernel.c | 25 +++++++++++++++++++++++++ xen/include/xen/lib.h | 10 ++++++++++ 6 files changed, 114 insertions(+), 2 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index e0b89b7d3319..9c0790ce6c7c 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -777,9 +777,9 @@ Specify the bit width of the DMA heap. ### dom0 = List of [ pv | pvh, shadow=, verbose=, - cpuid-faulting=, msr-relaxed= ] + cpuid-faulting=, msr-relaxed= ] (x86) - Applicability: x86 + = List of [ sve= ] (Arm) Controls for how dom0 is constructed on x86 systems. @@ -838,6 +838,20 @@ Controls for how dom0 is constructed on x86 systems. If using this option is necessary to fix an issue, please report a bug. +Enables features on dom0 on Arm systems. + +* The `sve` integer parameter enables Arm SVE usage for Dom0 domain and sets + the maximum SVE vector length. + A value equal to 0 disables the feature, this is the default value. + Values below 0 means the feature uses the maximum SVE vector length + supported by hardware, please be aware that if the hardware doesn't supports + SVE, the feature remains disabled. + Values above 0 explicitly set the maximum SVE vector length for Dom0, + allowed values are from 128 to maximum 2048, being multiple of 128. + Please note that when the user explicitly specify the value, if that value + is above the hardware supported maximum SVE vector length, the domain + creation will fail and the system will stop. + ### dom0-cpuid = List of comma separated booleans diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index 5485648850a0..ad5db62e1805 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -9,6 +9,9 @@ #include #include +/* opt_dom0_sve: allow Dom0 to use SVE and set maximum vector length. */ +int __initdata opt_dom0_sve; + extern unsigned int sve_get_hw_vl(void); extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, @@ -118,3 +121,21 @@ void sve_restore_state(struct vcpu *v) sve_load_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); } + +int __init sve_sanitize_vl_param(int val, unsigned int *out) +{ + /* + * Negative SVE parameter value means to use the maximum supported + * vector length, otherwise if a positive value is provided, check if the + * vector length is a multiple of 128 and not bigger than the maximum value + * 2048 + */ + if ( val < 0 ) + *out = get_sys_vl_len(); + else if ( ((val % SVE_VL_MULTIPLE_VAL) == 0) && (val <= SVE_VL_MAX_BITS) ) + *out = val; + else + return -1; + + return 0; +} diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index eeb4662f0eee..3f30ef5c37b6 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -61,6 +62,21 @@ custom_param("dom0_mem", parse_dom0_mem); int __init parse_arch_dom0_param(const char *s, const char *e) { + long long val; + + if ( !parse_signed_integer("sve", s, e, &val) ) + { +#ifdef CONFIG_ARM64_SVE + if ( (val >= INT_MIN) && (val <= INT_MAX) ) + opt_dom0_sve = val; + else + printk(XENLOG_INFO "'sve=%lld' value out of range!\n", val); +#else + no_config_param("ARM64_SVE", "sve", s, e); +#endif + return 0; + } + return -EINVAL; } @@ -4109,6 +4125,17 @@ void __init create_dom0(void) if ( iommu_enabled ) dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; + if ( opt_dom0_sve ) + { + unsigned int vl; + + if ( !sve_sanitize_vl_param(opt_dom0_sve, &vl) ) + dom0_cfg.arch.sve_vl = sve_encode_vl(vl); + else + printk(XENLOG_WARNING + "SVE vector length error, disable feature for Dom0\n"); + } + dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap); if ( IS_ERR(dom0) ) panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index fc162c9d2cf7..f1801876b5de 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -19,8 +19,15 @@ static inline unsigned int sve_decode_vl(unsigned int sve_vl) return sve_vl * SVE_VL_MULTIPLE_VAL; } +static inline unsigned int sve_encode_vl(unsigned int sve_vl_bits) +{ + return sve_vl_bits / SVE_VL_MULTIPLE_VAL; +} + #ifdef CONFIG_ARM64_SVE +extern int opt_dom0_sve; + register_t compute_max_zcr(void); register_t vl_to_zcr(unsigned int vl); unsigned int get_sys_vl_len(void); @@ -28,9 +35,12 @@ int sve_context_init(struct vcpu *v); void sve_context_free(struct vcpu *v); void sve_save_state(struct vcpu *v); void sve_restore_state(struct vcpu *v); +int sve_sanitize_vl_param(int val, unsigned int *out); #else /* !CONFIG_ARM64_SVE */ +#define opt_dom0_sve (0) + static inline register_t compute_max_zcr(void) { return 0; @@ -55,6 +65,11 @@ static inline void sve_context_free(struct vcpu *v) {} static inline void sve_save_state(struct vcpu *v) {} static inline void sve_restore_state(struct vcpu *v) {} +static inline int sve_sanitize_vl_param(int val, unsigned int *out) +{ + return -1; +} + #endif /* CONFIG_ARM64_SVE */ #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/common/kernel.c b/xen/common/kernel.c index f7b1f65f373c..29d05282c8bb 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -314,6 +314,31 @@ int parse_boolean(const char *name, const char *s, const char *e) return -1; } +int __init parse_signed_integer(const char *name, const char *s, const char *e, + long long *val) +{ + size_t slen, nlen; + const char *str; + long long pval; + + slen = e ? ({ ASSERT(e >= s); e - s; }) : strlen(s); + nlen = strlen(name); + + /* Does s start with name or contains only the name? */ + if ( (slen <= nlen) || strncmp(s, name, nlen) || (s[nlen] != '=') ) + return -1; + + pval = simple_strtoll(&s[nlen + 1], &str, 0); + + /* Number not recognised */ + if ( str != e ) + return -2; + + *val = pval; + + return 0; +} + int cmdline_strcmp(const char *frag, const char *name) { for ( ; ; frag++, name++ ) diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index e914ccade095..5343ee7a944a 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -94,6 +94,16 @@ int parse_bool(const char *s, const char *e); */ int parse_boolean(const char *name, const char *s, const char *e); +/** + * Given a specific name, parses a string of the form: + * $NAME= + * returning 0 and a value in val, for a recognised integer. + * Returns -1 for name not found, general errors, or -2 if name is found but + * not recognised number. + */ +int parse_signed_integer(const char *name, const char *s, const char *e, + long long *val); + /** * Very similar to strcmp(), but will declare a match if the NUL in 'name' * lines up with comma, colon, semicolon or equals in 'frag'. Designed for -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520097.807406 (Exim 4.92) (envelope-from ) id 1pmX75-0006jy-F4; Wed, 12 Apr 2023 09:50:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520097.807406; Wed, 12 Apr 2023 09:50:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX75-0006h2-1d; Wed, 12 Apr 2023 09:50:03 +0000 Received: by outflank-mailman (input) for mailman id 520097; Wed, 12 Apr 2023 09:50:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX73-0004lU-Jj for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:50:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6448c5f3-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:50:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7FF41684; Wed, 12 Apr 2023 02:50:44 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 31C993F587; Wed, 12 Apr 2023 02:49:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6448c5f3-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v5 08/12] xen/physinfo: encode Arm SVE vector length in arch_capabilities Date: Wed, 12 Apr 2023 10:49:34 +0100 Message-Id: <20230412094938.2693890-9-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the arm platform supports SVE, advertise the feature in the field arch_capabilities in struct xen_sysctl_physinfo by encoding the SVE vector length in it. Signed-off-by: Luca Fancellu --- Changes from v4: - Write arch_capabilities from arch_do_physinfo instead of using stub functions (Jan) Changes from v3: - domainconfig_encode_vl is now named sve_encode_vl Changes from v2: - Remove XEN_SYSCTL_PHYSCAP_ARM_SVE_SHFT, use MASK_INSR and protect with ifdef XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK (Jan) - Use the helper function sve_arch_cap_physinfo to encode the VL into physinfo arch_capabilities field. Changes from v1: - Use only arch_capabilities and some defines to encode SVE VL (Bertrand, Stefano, Jan) Changes from RFC: - new patch --- xen/arch/arm/sysctl.c | 4 ++++ xen/include/public/sysctl.h | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c index b0a78a8b10d0..e9a0661146e4 100644 --- a/xen/arch/arm/sysctl.c +++ b/xen/arch/arm/sysctl.c @@ -11,11 +11,15 @@ #include #include #include +#include #include void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { pi->capabilities |= XEN_SYSCTL_PHYSCAP_hvm | XEN_SYSCTL_PHYSCAP_hap; + + pi->arch_capabilities |= MASK_INSR(sve_encode_vl(get_sys_vl_len()), + XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK); } long arch_do_sysctl(struct xen_sysctl *sysctl, diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 2b24d6bfd00e..9d06e92d0f6a 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -94,6 +94,10 @@ struct xen_sysctl_tbuf_op { /* Max XEN_SYSCTL_PHYSCAP_* constant. Used for ABI checking. */ #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2 +#if defined(__arm__) || defined(__aarch64__) +#define XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK (0x1FU) +#endif + struct xen_sysctl_physinfo { uint32_t threads_per_core; uint32_t cores_per_socket; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520098.807421 (Exim 4.92) (envelope-from ) id 1pmX77-0007S3-M2; Wed, 12 Apr 2023 09:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520098.807421; Wed, 12 Apr 2023 09:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX77-0007RI-Gw; Wed, 12 Apr 2023 09:50:05 +0000 Received: by outflank-mailman (input) for mailman id 520098; Wed, 12 Apr 2023 09:50:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX75-0004lU-TV for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:50:03 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6570b679-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:50:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE35D1684; Wed, 12 Apr 2023 02:50:46 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B57853F587; Wed, 12 Apr 2023 02:50:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6570b679-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Christian Lindig Subject: [PATCH v5 09/12] tools: add physinfo arch_capabilities handling for Arm Date: Wed, 12 Apr 2023 10:49:35 +0100 Message-Id: <20230412094938.2693890-10-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Arm, the SVE vector length is encoded in arch_capabilities field of struct xen_sysctl_physinfo, make use of this field in the tools when building for arm. Create header arm-arch-capabilities.h to handle the arch_capabilities field of physinfo for Arm. Removed include for xen-tools/common-macros.h in python/xen/lowlevel/xc/xc.c because it is already included by the arm-arch-capabilities.h header. Signed-off-by: Luca Fancellu Acked-by: George Dunlap Acked-by: Christian Lindig --- Changes from v4: - Move arm-arch-capabilities.h into xen-tools/, add LIBXL_HAVE_, fixed python return type to I instead of i. (Anthony) Changes from v3: - add Ack-by for the Golang bits (George) - add Ack-by for the OCaml tools (Christian) - now xen-tools/libs.h is named xen-tools/common-macros.h - changed commit message to explain why the header modification in python/xen/lowlevel/xc/xc.c Changes from v2: - rename arm_arch_capabilities.h in arm-arch-capabilities.h, use MASK_EXTR. - Now arm-arch-capabilities.h needs MASK_EXTR macro, but it is defined in libxl_internal.h, it doesn't feel right to include that header so move MASK_EXTR into xen-tools/libs.h that is also included in libxl_internal.h Changes from v1: - now SVE VL is encoded in arch_capabilities on Arm Changes from RFC: - new patch --- tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 6 ++++ .../include/xen-tools/arm-arch-capabilities.h | 28 +++++++++++++++++++ tools/include/xen-tools/common-macros.h | 2 ++ tools/libs/light/libxl.c | 1 + tools/libs/light/libxl_internal.h | 1 - tools/libs/light/libxl_types.idl | 1 + tools/ocaml/libs/xc/xenctrl.ml | 4 +-- tools/ocaml/libs/xc/xenctrl.mli | 4 +-- tools/ocaml/libs/xc/xenctrl_stubs.c | 8 ++++-- tools/python/xen/lowlevel/xc/xc.c | 8 ++++-- tools/xl/xl_info.c | 8 ++++++ 13 files changed, 62 insertions(+), 12 deletions(-) create mode 100644 tools/include/xen-tools/arm-arch-capabilities.h diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index 0a203d22321f..35397be2f9e2 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -3506,6 +3506,7 @@ x.CapVmtrace = bool(xc.cap_vmtrace) x.CapVpmu = bool(xc.cap_vpmu) x.CapGnttabV1 = bool(xc.cap_gnttab_v1) x.CapGnttabV2 = bool(xc.cap_gnttab_v2) +x.ArchCapabilities = uint32(xc.arch_capabilities) return nil} @@ -3540,6 +3541,7 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace) xc.cap_vpmu = C.bool(x.CapVpmu) xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1) xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2) +xc.arch_capabilities = C.uint32_t(x.ArchCapabilities) return nil } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index a7c17699f80e..3d968a496744 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -1079,6 +1079,7 @@ CapVmtrace bool CapVpmu bool CapGnttabV1 bool CapGnttabV2 bool +ArchCapabilities uint32 } type Connectorinfo struct { diff --git a/tools/include/libxl.h b/tools/include/libxl.h index cfa1a191318c..4fa09ff7635a 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -525,6 +525,12 @@ */ #define LIBXL_HAVE_PHYSINFO_CAP_GNTTAB 1 +/* + * LIBXL_HAVE_PHYSINFO_ARCH_CAPABILITIES indicates that libxl_physinfo has a + * arch_capabilities field. + */ +#define LIBXL_HAVE_PHYSINFO_ARCH_CAPABILITIES 1 + /* * LIBXL_HAVE_MAX_GRANT_VERSION indicates libxl_domain_build_info has a * max_grant_version field for setting the max grant table version per diff --git a/tools/include/xen-tools/arm-arch-capabilities.h b/tools/include/xen-tools/arm-arch-capabilities.h new file mode 100644 index 000000000000..ac44c8b14344 --- /dev/null +++ b/tools/include/xen-tools/arm-arch-capabilities.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2023 ARM Ltd. + */ + +#ifndef ARM_ARCH_CAPABILITIES_H +#define ARM_ARCH_CAPABILITIES_H + +#include +#include + +#include + +static inline +unsigned int arch_capabilities_arm_sve(unsigned int arch_capabilities) +{ +#if defined(__aarch64__) + unsigned int sve_vl = MASK_EXTR(arch_capabilities, + XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK); + + /* Vector length is divided by 128 before storing it in arch_capabilities */ + return sve_vl * 128U; +#else + return 0; +#endif +} + +#endif /* ARM_ARCH_CAPABILITIES_H */ diff --git a/tools/include/xen-tools/common-macros.h b/tools/include/xen-tools/common-macros.h index 76b55bf62085..d53b88182560 100644 --- a/tools/include/xen-tools/common-macros.h +++ b/tools/include/xen-tools/common-macros.h @@ -72,6 +72,8 @@ #define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1)) #endif +#define MASK_EXTR(v, m) (((v) & (m)) / ((m) & -(m))) + #ifndef __must_check #define __must_check __attribute__((__warn_unused_result__)) #endif diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index a0bf7d186f69..175d6dde0b80 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -409,6 +409,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v1); physinfo->cap_gnttab_v2 = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2); + physinfo->arch_capabilities = xcphysinfo.arch_capabilities; GC_FREE; return 0; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 5244fde6239a..8aba3e138909 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -132,7 +132,6 @@ #define DIV_ROUNDUP(n, d) (((n) + (d) - 1) / (d)) -#define MASK_EXTR(v, m) (((v) & (m)) / ((m) & -(m))) #define MASK_INSR(v, m) (((v) * ((m) & -(m))) & (m)) #define LIBXL__LOGGING_ENABLED diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index c10292e0d7e3..fd31dacf7d5a 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -1133,6 +1133,7 @@ libxl_physinfo = Struct("physinfo", [ ("cap_vpmu", bool), ("cap_gnttab_v1", bool), ("cap_gnttab_v2", bool), + ("arch_capabilities", uint32), ], dir=DIR_OUT) libxl_connectorinfo = Struct("connectorinfo", [ diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index e4096bf92c1d..bf23ca50bb15 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -128,12 +128,10 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 -type arm_physinfo_cap_flag - type x86_physinfo_cap_flag type arch_physinfo_cap_flags = - | ARM of arm_physinfo_cap_flag list + | ARM of int | X86 of x86_physinfo_cap_flag list type physinfo = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index ef2254537430..ed1e28ea30a0 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -113,12 +113,10 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 -type arm_physinfo_cap_flag - type x86_physinfo_cap_flag type arch_physinfo_cap_flags = - | ARM of arm_physinfo_cap_flag list + | ARM of int | X86 of x86_physinfo_cap_flag list type physinfo = { diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 6ec9ed6d1e6f..526a3610fa42 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -853,13 +853,15 @@ CAMLprim value stub_xc_physinfo(value xch_val) arch_cap_list = Tag_cons; arch_cap_flags_tag = 1; /* tag x86 */ -#else - caml_failwith("Unhandled architecture"); -#endif arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag); Store_field(arch_cap_flags, 0, arch_cap_list); Store_field(physinfo, 10, arch_cap_flags); +#elif defined(__aarch64__) + Store_field(physinfo, 10, Val_int(c_physinfo.arch_capabilities)); +#else + caml_failwith("Unhandled architecture"); +#endif CAMLreturn(physinfo); } diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c index 35901c2d63b6..94b0354cf52f 100644 --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -22,6 +22,7 @@ #include #include +#include #include /* Needed for Python versions earlier than 2.3. */ @@ -897,7 +898,7 @@ static PyObject *pyxc_physinfo(XcObject *self) if ( p != virt_caps ) *(p-1) = '\0'; - return Py_BuildValue("{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s:s}", + return Py_BuildValue("{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s:s,s:I}", "nr_nodes", pinfo.nr_nodes, "threads_per_core", pinfo.threads_per_core, "cores_per_socket", pinfo.cores_per_socket, @@ -907,7 +908,10 @@ static PyObject *pyxc_physinfo(XcObject *self) "scrub_memory", pages_to_kib(pinfo.scrub_pages), "cpu_khz", pinfo.cpu_khz, "hw_caps", cpu_cap, - "virt_caps", virt_caps); + "virt_caps", virt_caps, + "arm_sve_vl", + arch_capabilities_arm_sve(pinfo.arch_capabilities) + ); } static PyObject *pyxc_getcpuinfo(XcObject *self, PyObject *args, PyObject *kwds) diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 712b7638b013..ddc42f96b979 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -27,6 +27,7 @@ #include #include #include +#include #include "xl.h" #include "xl_utils.h" @@ -224,6 +225,13 @@ static void output_physinfo(void) info.cap_gnttab_v2 ? " gnttab-v2" : "" ); + /* Print arm SVE vector length only on ARM platforms */ +#if defined(__aarch64__) + maybe_printf("arm_sve_vector_length : %u\n", + arch_capabilities_arm_sve(info.arch_capabilities) + ); +#endif + vinfo = libxl_get_version_info(ctx); if (vinfo) { i = (1 << 20) / vinfo->pagesize; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520099.807429 (Exim 4.92) (envelope-from ) id 1pmX79-0007p0-CO; Wed, 12 Apr 2023 09:50:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520099.807429; Wed, 12 Apr 2023 09:50:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX79-0007nF-4Y; Wed, 12 Apr 2023 09:50:07 +0000 Received: by outflank-mailman (input) for mailman id 520099; Wed, 12 Apr 2023 09:50:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX77-0004lU-7E for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:50:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 662b20b6-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:50:04 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07E0CC14; Wed, 12 Apr 2023 02:50:48 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7AB0F3F587; Wed, 12 Apr 2023 02:50:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 662b20b6-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [PATCH v5 10/12] xen/tools: add sve parameter in XL configuration Date: Wed, 12 Apr 2023 10:49:36 +0100 Message-Id: <20230412094938.2693890-11-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add sve parameter in XL configuration to allow guests to use SVE feature. Signed-off-by: Luca Fancellu --- Changes from v4: - Rename sve field to sve_vl (Anthony), changed type to libxl_sve_type - Sanity check of sve field in libxl instead of xl, update docs (Anthony) - drop Ack-by from George because of the changes in the Golang bits Changes from v3: - no changes Changes from v2: - domain configuration field name has changed to sve_vl, also its value now is VL/128. - Add Ack-by George for the Golang bits Changes from v1: - updated to use arch_capabilities field for vector length Changes from RFC: - changed libxl_types.idl sve field to uint16 - now toolstack uses info from physinfo to check against the sve XL value - Changed documentation --- docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 23 +++++++++++++++++++++++ tools/include/libxl.h | 5 +++++ tools/libs/light/libxl_arm.c | 28 ++++++++++++++++++++++++++++ tools/libs/light/libxl_types.idl | 22 ++++++++++++++++++++++ tools/xl/xl_parse.c | 8 ++++++++ 7 files changed, 103 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 10f37990be57..e5f9c76737b3 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2952,6 +2952,21 @@ Currently, only the "sbsa_uart" model is supported for ARM. =back +=item B + +Enable the use of SVE feature for the guest and set the maximum vector length +that a guest's Scalable Vector Extension (SVE) can use. Or disable it by +specifying "disabled", which is the default value. +Allowed values are "disabled", "128", "256", "384", "512", "640", "768", "896", +"1024", "1152", "1280", "1408", "1536", "1664", "1792", "1920", "2048", "hw". +Specifying "hw" means that the maximum vector length supported by the platform +will be used. +Please be aware that if a specific vector length is passed and its value is +above the maximum vector length supported by the platform, an error will be +raised. + +=back + =head3 x86 =over 4 diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index 35397be2f9e2..cd1a16e32eac 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1149,6 +1149,7 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} x.ArchArm.GicVersion = GicVersion(xc.arch_arm.gic_version) x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) +x.ArchArm.SveVl = SveType(xc.arch_arm.sve_vl) if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } @@ -1653,6 +1654,7 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} xc.arch_arm.gic_version = C.libxl_gic_version(x.ArchArm.GicVersion) xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) +xc.arch_arm.sve_vl = C.libxl_sve_type(x.ArchArm.SveVl) if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 3d968a496744..adb32bfa5bf0 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -490,6 +490,28 @@ TeeTypeNone TeeType = 0 TeeTypeOptee TeeType = 1 ) +type SveType int +const( +SveTypeDisabled SveType = 0 +SveType128 SveType = 128 +SveType256 SveType = 256 +SveType384 SveType = 384 +SveType512 SveType = 512 +SveType640 SveType = 640 +SveType768 SveType = 768 +SveType896 SveType = 896 +SveType1024 SveType = 1024 +SveType1152 SveType = 1152 +SveType1280 SveType = 1280 +SveType1408 SveType = 1408 +SveType1536 SveType = 1536 +SveType1664 SveType = 1664 +SveType1792 SveType = 1792 +SveType1920 SveType = 1920 +SveType2048 SveType = 2048 +SveTypeHw SveType = -1 +) + type RdmReserve struct { Strategy RdmReserveStrategy Policy RdmReservePolicy @@ -564,6 +586,7 @@ TypeUnion DomainBuildInfoTypeUnion ArchArm struct { GicVersion GicVersion Vuart VuartType +SveVl SveType } ArchX86 struct { MsrRelaxed Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 4fa09ff7635a..cac641a7eba2 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -283,6 +283,11 @@ */ #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 +/* + * libxl_domain_build_info has the arch_arm.sve_vl field. + */ +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SVE_VL 1 + /* * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing * 'soft reset' for domains and there is 'soft_reset' shutdown reason diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..1e69dac2c4fa 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -3,6 +3,8 @@ #include "libxl_libfdt_compat.h" #include "libxl_arm.h" +#include + #include #include #include @@ -211,6 +213,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + /* Parameter is sanitised in libxl__arch_domain_build_info_setdefault */ + if (d_config->b_info.arch_arm.sve_vl) { + /* Vector length is divided by 128 in struct xen_domctl_createdomain */ + config->arch.sve_vl = d_config->b_info.arch_arm.sve_vl / 128U; + } + return 0; } @@ -1681,6 +1689,26 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); + /* Sanitise SVE parameter */ + if (b_info->arch_arm.sve_vl) { + unsigned int max_sve_vl = + arch_capabilities_arm_sve(physinfo->arch_capabilities); + + if (!max_sve_vl) { + LOG(ERROR, "SVE is unsupported on this machine."); + return ERROR_FAIL; + } + + if (LIBXL_SVE_TYPE_HW == b_info->arch_arm.sve_vl) { + b_info->arch_arm.sve_vl = max_sve_vl; + } else if (b_info->arch_arm.sve_vl > max_sve_vl) { + LOG(ERROR, + "Invalid sve value: %d. Platform supports up to %u bits", + b_info->arch_arm.sve_vl, max_sve_vl); + return ERROR_FAIL; + } + } + if (b_info->type != LIBXL_DOMAIN_TYPE_PV) return 0; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index fd31dacf7d5a..9e48bb772646 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -523,6 +523,27 @@ libxl_tee_type = Enumeration("tee_type", [ (1, "optee") ], init_val = "LIBXL_TEE_TYPE_NONE") +libxl_sve_type = Enumeration("sve_type", [ + (-1, "hw"), + (0, "disabled"), + (128, "128"), + (256, "256"), + (384, "384"), + (512, "512"), + (640, "640"), + (768, "768"), + (896, "896"), + (1024, "1024"), + (1152, "1152"), + (1280, "1280"), + (1408, "1408"), + (1536, "1536"), + (1664, "1664"), + (1792, "1792"), + (1920, "1920"), + (2048, "2048") + ], init_val = "LIBXL_SVE_TYPE_DISABLED") + libxl_rdm_reserve = Struct("rdm_reserve", [ ("strategy", libxl_rdm_reserve_strategy), ("policy", libxl_rdm_reserve_policy), @@ -690,6 +711,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), + ("sve_vl", libxl_sve_type), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), ])), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1f6f47daf4e1..f036e56fc239 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2887,6 +2887,14 @@ skip_usbdev: } } + if (!xlu_cfg_get_string (config, "sve", &buf, 1)) { + e = libxl_sve_type_from_string(buf, &b_info->arch_arm.sve_vl); + if (e) { + fprintf(stderr, "Unknown sve \"%s\" specified\n", buf); + exit(EXIT_FAILURE); + } + } + parse_vkb_list(config, d_config); d_config->virtios = NULL; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520100.807435 (Exim 4.92) (envelope-from ) id 1pmX79-0007u6-TN; Wed, 12 Apr 2023 09:50:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520100.807435; Wed, 12 Apr 2023 09:50:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX79-0007sX-MM; Wed, 12 Apr 2023 09:50:07 +0000 Received: by outflank-mailman (input) for mailman id 520100; Wed, 12 Apr 2023 09:50:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX77-0004lU-OR for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:50:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 66aff3eb-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:50:05 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 202D6168F; Wed, 12 Apr 2023 02:50:49 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C7E793F587; Wed, 12 Apr 2023 02:50:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66aff3eb-d917-11ed-b21e-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v5 11/12] xen/arm: add sve property for dom0less domUs Date: Wed, 12 Apr 2023 10:49:37 +0100 Message-Id: <20230412094938.2693890-12-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a device tree property in the dom0less domU configuration to enable the guest to use SVE. Update documentation. Signed-off-by: Luca Fancellu --- Changes from v4: - Now it is possible to specify the property "sve" for dom0less device tree node without any value, that means the platform supported VL will be used. Changes from v3: - Now domainconfig_encode_vl is named sve_encode_vl Changes from v2: - xen_domctl_createdomain field name has changed into sve_vl and its value is the VL/128, use domainconfig_encode_vl to encode a plain VL in bits. Changes from v1: - No changes Changes from RFC: - Changed documentation --- docs/misc/arm/device-tree/booting.txt | 11 +++++++++++ xen/arch/arm/domain_build.c | 24 ++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 3879340b5e0a..f9d2ecdda48a 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -193,6 +193,17 @@ with the following properties: Optional. Handle to a xen,cpupool device tree node that identifies the cpupool where the guest will be started at boot. +- sve + + Optional. A number that, when above 0, enables SVE for this guest and sets + its maximum SVE vector length. The default value is 0, that means this + guest is not allowed to use SVE, the maximum value allowed is 2048, any + other value must be multiple of 128. + Please note that if the platform supports a lower value of bits, then the + domain creation will fail. + Specifying this property with no value, means that the SVE vector length + will be set equal to the maximum vector length supported by the platform. + - xen,enhanced A string property. Possible property values are: diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3f30ef5c37b6..c1f0d1d78431 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -4004,6 +4004,30 @@ void __init create_domUs(void) d_cfg.max_maptrack_frames = val; } + if ( dt_get_property(node, "sve", &val) ) + { + unsigned int sve_vl_bits; + + if ( !val ) + { + /* Property found with no value, means max HW VL supported */ + rc = sve_sanitize_vl_param(-1, &sve_vl_bits); + } + else + { + if ( dt_property_read_u32(node, "sve", &val) ) + rc = sve_sanitize_vl_param(val, &sve_vl_bits); + else + panic("Error reading 'sve' property"); + } + + if ( !rc ) + d_cfg.arch.sve_vl = sve_encode_vl(sve_vl_bits); + else + printk(XENLOG_WARNING + "SVE vector length error, disable feature for Dom0less DomU\n"); + } + /* * The variable max_init_domid is initialized with zero, so here it's * very important to use the pre-increment operator to call -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:50:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520102.807446 (Exim 4.92) (envelope-from ) id 1pmX7B-0008Nc-R3; Wed, 12 Apr 2023 09:50:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520102.807446; Wed, 12 Apr 2023 09:50:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX7B-0008LB-HN; Wed, 12 Apr 2023 09:50:09 +0000 Received: by outflank-mailman (input) for mailman id 520102; Wed, 12 Apr 2023 09:50:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmX79-0004lO-Sn for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:50:07 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 66c20f5b-d917-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 11:50:05 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CC69C14; Wed, 12 Apr 2023 02:50:50 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF61D3F587; Wed, 12 Apr 2023 02:50:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66c20f5b-d917-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Henry Wang , Community Manager Subject: [PATCH v5 12/12] xen/changelog: Add SVE and "dom0" options to the changelog for Arm Date: Wed, 12 Apr 2023 10:49:38 +0100 Message-Id: <20230412094938.2693890-13-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412094938.2693890-1-luca.fancellu@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Arm now can use the "dom0=" Xen command line option and the support for guests running SVE instructions is added, put entries in the changelog. Signed-off-by: Luca Fancellu --- Changes from v4: - No changes Change from v3: - new patch --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c978cfd9b68f..a24951603359 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD +### Changed +- The "dom0" option is now supported on Arm and "sve=" sub-option can be used + to enable dom0 guest to use SVE/SVE2 instructions. + ### Added - On x86, support for features new in Intel Sapphire Rapids CPUs: - PKS (Protection Key Supervisor) available to HVM/PVH guests. @@ -14,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system wide impact of a guest misusing atomic instructions. - xl/libxl can customize SMBIOS strings for HVM guests. + - On Arm, Xen supports guests running SVE/SVE2 instructions. ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-12 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 09:53:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 09:53:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520114.807462 (Exim 4.92) (envelope-from ) id 1pmXAl-0004Ww-BO; Wed, 12 Apr 2023 09:53:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520114.807462; Wed, 12 Apr 2023 09:53:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXAl-0004Wp-8V; Wed, 12 Apr 2023 09:53:51 +0000 Received: by outflank-mailman (input) for mailman id 520114; Wed, 12 Apr 2023 09:53:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXAj-0004Wj-Td for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 09:53:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1b::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebf629ff-d917-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 11:53:48 +0200 (CEST) Received: from AM6PR0502CA0072.eurprd05.prod.outlook.com (2603:10a6:20b:56::49) by AS2PR08MB9197.eurprd08.prod.outlook.com (2603:10a6:20b:57b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 09:53:45 +0000 Received: from AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:56:cafe::aa) by AM6PR0502CA0072.outlook.office365.com (2603:10a6:20b:56::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Wed, 12 Apr 2023 09:53:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT018.mail.protection.outlook.com (100.127.140.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Wed, 12 Apr 2023 09:53:44 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Wed, 12 Apr 2023 09:53:44 +0000 Received: from 67a50924a495.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 36914FB2-8A4A-4FA4-B5DB-DE8B80D3CC03.1; Wed, 12 Apr 2023 09:53:37 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 67a50924a495.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Apr 2023 09:53:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB9259.eurprd08.prod.outlook.com (2603:10a6:102:307::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Wed, 12 Apr 2023 09:53:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6277.034; Wed, 12 Apr 2023 09:53:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebf629ff-d917-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QO87h/B4tZJozq0ApWzW4uhvl9hVnbZ2lFC/3noO028=; b=C/L9risaHhZUG3Dmu3fQ/dmwj6LvlLersWBeU5ksbHuZic/ZT1VeXYvD+pB8c7rkwkfyJw6+HvBnG4bsemmzt+eT0gmGwKziqFrC04GQFgn25DbYoFZiLrgouhqwLFvNwFqZ2Eedae9BSp6BSZR98HLaIHBJRFmNDL53pbL6BYo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UoNwsXgjmy1EAIdyurOWW6n4leyLPEljdROlzYVGG1fEWlSBd16IbBvYxtQmaf6k65JDU4Dtod+dEkCM+V+Dpb/fIWEOKlEUnYO9uEv59v3CRFempIu+gzIUnMwGRlxID47ql732cMr3mFetdavvMZ2Cr4BjafZLu+abQZIcg1uFM9v/OF5fRdnJqIgq1M1JbzWDiFb66oghgmHxvEylT5DPwhyv7seWdAuyxGQMBuIzS8z4GGR0LAmwXNFBa90fG+ikf70KHCYcfHbOhk1eOgoMQ8VyEc326lnXYVEhbj0n1rYwhpvTfy8Cfmt9Y4c5JhtdaRMG6vxcPS14Jm6YZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QO87h/B4tZJozq0ApWzW4uhvl9hVnbZ2lFC/3noO028=; b=Jf/TFL+SkzxTP/iP6jeW5IKycRdLzQPmN5A4Omd6FG4Y7m0GVp2xy5dcjcEKfjmEa0JiJI3e5XDoMjqWzP6Lz1Ddij3xnQGpL15mDM3fP8fGPo5ffGLvyzTyEGYebkFPxENGvr4wcx4HxW4xt/SRVHJUPtDFFr0Pzv5YIUBQlPbi8Lw+SMagOfNur2CwYObubQ7qjzM6JQT/Av+EnBLcDAUhdpEmOUSGk52qvEy6eFwFYcaM14JinT9xctbTMV1+UY4xQZ2jHLIt058i4GOczUhYYSojsamBW799f+GdLvl8obdwLxEZh10zgrB+jO0cGOrWvZEzgA9G2R6UGoGXvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QO87h/B4tZJozq0ApWzW4uhvl9hVnbZ2lFC/3noO028=; b=C/L9risaHhZUG3Dmu3fQ/dmwj6LvlLersWBeU5ksbHuZic/ZT1VeXYvD+pB8c7rkwkfyJw6+HvBnG4bsemmzt+eT0gmGwKziqFrC04GQFgn25DbYoFZiLrgouhqwLFvNwFqZ2Eedae9BSp6BSZR98HLaIHBJRFmNDL53pbL6BYo= From: Henry Wang To: Luca Fancellu , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Wei Chen , Community Manager Subject: RE: [PATCH v5 12/12] xen/changelog: Add SVE and "dom0" options to the changelog for Arm Thread-Topic: [PATCH v5 12/12] xen/changelog: Add SVE and "dom0" options to the changelog for Arm Thread-Index: AQHZbSQvpEqMQcYfY0uxDJPB32sRQK8nbmLA Date: Wed, 12 Apr 2023 09:53:30 +0000 Message-ID: References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-13-luca.fancellu@arm.com> In-Reply-To: <20230412094938.2693890-13-luca.fancellu@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5324AD9204C32D4C878C8D9CCB826009.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAVPR08MB9259:EE_|AM7EUR03FT018:EE_|AS2PR08MB9197:EE_ X-MS-Office365-Filtering-Correlation-Id: 341cf477-8d53-49c5-99c7-08db3b3bcdef x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xN8aDDBN3fuygun8SjjIegaQaie0tu5S5wPUnHvxN6plyoeBl8eHGVP3B/lwDCuvIkCOy8GBdBt/HfiJV3m6QXC9bIo8IuaShasVWlPypnNjhMQKdYnAIcqPRXBeXKvkDWz4w+E22qfbdcxE9ATzYQkpHbDGFNgT1M6vyAEbD3vbURKCe/cqRUPUQcujyighDxjhOKqhuelb3mBQd/GhW//oi4pPy4eBvBwwu22LhLMUcPXhkfSKPtxXa1YcXrFUGUVMB+pHFmSg8a4Xbh5rSco0N2p9dn2dvFEGA/9Jvnexfo/UbE0zE+xNIgEaPKZN81fbK18Psh51px+x9FcC7BXD8uG/TNQHfXxN/kQcJeyiKymljThFqS5z2SG3wrqY0+Xa2ZHQU0qOqhsJWFBEeJMGRLVsRwLYIjSeeP+HmmDiUaE4ofamlb/qfqgH6MLlWcdGOOgZP44k6+0J8gGiwLCX3pxKl9uRVKcOqWeuAHZnWinZ9kOGD1M/kzefGl711U7U18xJCmLI+7pkY9UxS+8Y91DyfYJyrZfyW+zT9dCt7GAJKLhqqKdcNYv+BDuItYQdC3dIlbbabdWLRk8nKb1z6aJ/ROPx2ocefBLXiZwDyJmkFbHfKkJlCFaXXzL4EUW3iA/YIt9AnmqKAkKfeiGPzvObC2KWetx21Eea6Wn9lk1cY0BLckbvlFYxdIaeiLj/XmVO5I60SEAx53M88A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199021)(38070700005)(110136005)(38100700002)(54906003)(122000001)(76116006)(66446008)(66476007)(66946007)(316002)(8676002)(64756008)(86362001)(66556008)(83380400001)(33656002)(478600001)(4326008)(186003)(26005)(41300700001)(9686003)(6506007)(71200400001)(2906002)(7696005)(4744005)(8936002)(52536014)(55016003)(5660300002)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9259 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 78b7cde3-9b4f-4587-f4d6-08db3b3bc5be X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pn/9IaGY6XTNLgidpgRzDNPZ29+uVXLwCmAMP+DzzDurhaDEVDZNlHtSIjpQ+il9lTm2+0EwMZPmIgCiYr7nSogQuAd5zbOTl2UwSstk7qfBs5UwqHRuNi55nesZZgyOgSoeJSnVvktlvQTVQZQ1eQVJyGnWeQhiLVQxOtzo+v4bQxwlGxjagOdGNQEBmYeaDmAWIigqbNA5DwMoYjrsELMmRTLnpBZDSxO59aA0w6q4cewmyaNXHAQ1WiPeK2st2f6OSy+2hsJg0YLC+eIjwCeePglMC0eMf1/5dMqj4Ju3jjUdIofHpucF1dPuLGl4oX4ZGdOpVfW6/E6vpDJxM/slnxRBI4GvyjGWXmuCFkxduk4z0c494xVAa6Xv1nnN3dlFV8JacGinmy1vP12k1HjwRv8+ENKvPKtpPAa9zusejdSQGa4UYgr1Gmt6c/djRpMxfurKVNGawzCNeNUaalhmmEzfpiAfA4n0IkLUWo7UC9yDBpscNY40paprsCx1ocKVL25A0JfBGoI19S7rDDR2cke0Ay/HnW5ZJUl5y3ZvHt4vGIx0Vc7z4aqBM4d1DN5ZgfVS+YLLcEshYffyVD5G93p3MCZ+k4kkShzslDh2JUYwJU6OEN10VqXsS8DWTLJVcagAsePQecMBJV09gO/Giz8p5bnBNpsiphXhZebXDO96+shggM3hd7ifCSc1nEP8bEvPwc/2Kx0p+/H67QQGKAFU/ExRFmSMTx5UtaONJx0rxebjy+d+jSgcb7mJDk61wVnM2ZfDwcIAbTbUGWa04bGjUzdWDT8Xgqnrni4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(46966006)(40470700004)(36840700001)(36860700001)(336012)(47076005)(83380400001)(478600001)(7696005)(54906003)(26005)(186003)(6506007)(110136005)(9686003)(41300700001)(2906002)(52536014)(4744005)(33656002)(82740400003)(40460700003)(5660300002)(70206006)(4326008)(81166007)(356005)(82310400005)(70586007)(8936002)(316002)(55016003)(86362001)(8676002)(40480700001)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 09:53:44.6729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 341cf477-8d53-49c5-99c7-08db3b3bcdef X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9197 Hi Luca, > -----Original Message----- > Subject: [PATCH v5 12/12] xen/changelog: Add SVE and "dom0" options to th= e > changelog for Arm >=20 > Arm now can use the "dom0=3D" Xen command line option and the support > for guests running SVE instructions is added, put entries in the > changelog. >=20 > Signed-off-by: Luca Fancellu If Arm maintainers don't have any other comments, you can keep my: Acked-by: Henry Wang If they do have some comments about the wording, please respect their comments, thanks! Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Wed Apr 12 10:06:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 10:06:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520156.807471 (Exim 4.92) (envelope-from ) id 1pmXNA-0006FE-ED; Wed, 12 Apr 2023 10:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520156.807471; Wed, 12 Apr 2023 10:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXNA-0006F7-BU; Wed, 12 Apr 2023 10:06:40 +0000 Received: by outflank-mailman (input) for mailman id 520156; Wed, 12 Apr 2023 10:06:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXN9-0006F1-1b for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 10:06:39 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3fc7726-d919-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 12:06:33 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id he11-20020a05600c540b00b003ef6d684102so4018103wmb.3 for ; Wed, 12 Apr 2023 03:06:34 -0700 (PDT) Received: from [192.168.69.115] ([176.187.216.226]) by smtp.gmail.com with ESMTPSA id m2-20020a05600c3b0200b003f0652084b8sm1865060wms.20.2023.04.12.03.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 03:06:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3fc7726-d919-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681293994; x=1683885994; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nodu07HKidxKPxvOg7xbv/1Polhi/238wioQUMdq6YU=; b=Xk3y6DXBeCFFzJr+vithiTz5Beg0CXzofhffIWROJNMLkIZ7q26zdzFL4KJtA4YxyU Il4dRd58xoKO29XLYhdAiWdEM4huVsdPW7tera/P7GyqMzKKr5sQFUsTfalIJ40UoLt5 RZNqZzfSgstPdGFJ4R0YX5dBPr8yhN791OWpFaBmqSRZApEh4jrE+bwym33YTPmGkOEI 7gr68QxBAS8wdpi6KH/Bcx+0ZH++esjWqvsINZI9qV3ixkUf50FIyXp6LuCXItCKkmpu w95X1V7K9gFRCUDsJeIqJJ4IrgOgZWYJ5NN9Uve6hEwbGvxbD9cVhTlpHNiW7ruAt4Ob FUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681293994; x=1683885994; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nodu07HKidxKPxvOg7xbv/1Polhi/238wioQUMdq6YU=; b=iYUBTFRUGLg1Zku10Ubx8cR5LhqjvanBrad2vEJyOaDsdyLbEOntJqBEUipfxTEMjo 00HOu36Jit3yE9XLGfKfhJeWCrd7VUPkMN/MNmzVaVFhOKa4YYu0NVsJ3bS67oBQYR8r koDm6R+50iHggqptaLn0oLMVaHHvgWd4wc3MHwiG0CxlIl+eBh7KL82YrFR5eLb1XpRl eKTLwAu4MpSW7CC8n409IuhwmGqcGqHCPddG/WJWDiysame2jt/A5MMn2Zv0tO96MmiX IHkrF49ph9IaruKLkIxwBPKPq5XYYF2+SpObGWXzOwo6muuLeMiapWHi0ddkeZGh86vz /0FA== X-Gm-Message-State: AAQBX9fr+qnLy6o7XooFpAnhj5NGi+D5t9JaIRdDrEqfQdYLmfQXRfZO PtqvNNY3oTGH5ZangPdTG4T/gA== X-Google-Smtp-Source: AKy350a38QzxrOG40N/FCLtmNOZJ6NWu2hOiFQSQbZsWgPAmb1mo1As6jLt15bkoB1132d1qV+yodA== X-Received: by 2002:a05:600c:b56:b0:3ee:7e12:f50 with SMTP id k22-20020a05600c0b5600b003ee7e120f50mr1516825wmr.8.1681293994158; Wed, 12 Apr 2023 03:06:34 -0700 (PDT) Message-ID: <72ee7e72-5ec1-d53b-94fa-e88f68880c2f@linaro.org> Date: Wed, 12 Apr 2023 12:06:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen Content-Language: en-US To: Thomas Huth , Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Wainer dos Santos Moschetta , Beraldo Leal References: <20230411210422.24255-1-vikram.garhwal@amd.com> <895bcdd3-350d-38e7-1982-899948072b93@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <895bcdd3-350d-38e7-1982-899948072b93@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/4/23 07:39, Thomas Huth wrote: > On 11/04/2023 23.04, Vikram Garhwal wrote: >> Xen is supported for aarch64 via xenpvh machine. disable-tcg option >> fails the >> build for aarch64 target. >> >> Link for xen on arm patch series: >> https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html >> >> Signed-off-by: Vikram Garhwal >> --- >>   .gitlab-ci.d/crossbuilds.yml | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >> index 61b8ac86ee..6867839248 100644 >> --- a/.gitlab-ci.d/crossbuilds.yml >> +++ b/.gitlab-ci.d/crossbuilds.yml >> @@ -186,7 +186,7 @@ cross-amd64-xen-only: >>     variables: >>       IMAGE: debian-amd64-cross >>       ACCEL: xen >> -    EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> +    EXTRA_CONFIGURE_OPTS: --disable-kvm >>   cross-arm64-xen-only: >>     extends: .cross_accel_build_job >> @@ -195,4 +195,4 @@ cross-arm64-xen-only: >>     variables: >>       IMAGE: debian-arm64-cross >>       ACCEL: xen >> -    EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> +    EXTRA_CONFIGURE_OPTS: --disable-kvm > > This patch looks wrong. I'm pretty sure we wanted to test the build > without TCG here. Building with TCG enabled is already done in other > jobs. So instead of removing "--disable-tcg" here the question is > rather: Why does it not build with this flag anymore? Can those problems > be fixed instead? I concur, this used to work. Did this config bit-rotted? The latest /master job succeeded: https://gitlab.com/qemu-project/qemu/-/jobs/4094506462 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 10:10:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 10:10:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520163.807482 (Exim 4.92) (envelope-from ) id 1pmXQS-0007PI-Uy; Wed, 12 Apr 2023 10:10:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520163.807482; Wed, 12 Apr 2023 10:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXQS-0007OY-QR; Wed, 12 Apr 2023 10:10:04 +0000 Received: by outflank-mailman (input) for mailman id 520163; Wed, 12 Apr 2023 10:10:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXQR-00075J-9t for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 10:10:03 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f337a2d-d91a-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 12:10:00 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id j1so14313778wrb.0 for ; Wed, 12 Apr 2023 03:10:01 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id z16-20020a5d4410000000b002f490a0cd1asm1080829wrq.92.2023.04.12.03.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 03:10:00 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 190F31FFB7; Wed, 12 Apr 2023 11:10:00 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f337a2d-d91a-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681294201; x=1683886201; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=bPJ2SFierbyb3Cclh63Wlefmv6JskXMO+atr4mXdl8I=; b=BScgF6Er6TmA9oO9n/EyYK3mPOlQAD+EaBbBo1rH+wjOVZNNffPA5u8mTVh3sa9rAd QHL+9y7eA4QlOM3dyrIeluXkvHuwijSBYc25rAQSnSY41YwmH6MRPHChCzVJ4vm8FZX4 5ebp5hfJis2nUoxbankpexnCPOMMn9n+Fl8A8S52wn/8zWiNcd9wti3k0LgL9iYgsG2H LSxKzu/DesSxMfYHcYjnym0+FpfzyNZUD+IuLQ1UJfJHADUtRUkxAajjpL4xVZUAVupL 6VU9hq/G3upGGHaf8TMUHF5mDs6JMlXa7eqGqeUUOqlnGB9+CYU1PclzWUb7I8YuWA2d v6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681294201; x=1683886201; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bPJ2SFierbyb3Cclh63Wlefmv6JskXMO+atr4mXdl8I=; b=xAaZJSiwBZFMTUHL1K5kvkqjdt3C0n5ltyNRozMc+xW7lltSxr2CUjqbjZjXE7fna0 7aBaKm0fRI98195Lqy+9qNEwrNDQhR9DIWlDYEwZ59yIr/FsyycdCL997xzWextktl1+ +8cS9VQhvmoTB5yqlGjFMAnmCqQodIgWLPuRZnXKLUSNTPFEB+bjpgAGvynSaFJi5A3+ KlgeKiw9y45NikHo37fzlwxKzsNL5r0FsIO/rEr0+4auL/fXS6fZpTlJ8IUBoEORpVsL HNIr6zDrBxWQQByReKdC7t8mejLSyi38SghnA9049lTuSyNKCj9SxDMKOv22fiox2GWU RDIg== X-Gm-Message-State: AAQBX9dsfmHjfG/r/Ol4NLzkSOD5xtIybZl1aXkxEeo1+X5PvRVay0sK NLYOPcbpjxe2qh7oHMPw62qCPA== X-Google-Smtp-Source: AKy350aBY3mwROC5VviG3+/nxUD4IH6ZvxN1KXZmddzemSoJH/nDLqqfeanFjDkNN3oVWK6yU/IRoQ== X-Received: by 2002:adf:ee0f:0:b0:2d0:354e:dc77 with SMTP id y15-20020adfee0f000000b002d0354edc77mr9024079wrn.66.1681294200833; Wed, 12 Apr 2023 03:10:00 -0700 (PDT) References: <20230411210422.24255-1-vikram.garhwal@amd.com> User-agent: mu4e 1.10.0; emacs 29.0.90 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Vikram Garhwal Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: Re: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen Date: Wed, 12 Apr 2023 11:08:50 +0100 In-reply-to: <20230411210422.24255-1-vikram.garhwal@amd.com> Message-ID: <877cuhpg1z.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vikram Garhwal writes: > Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails= the > build for aarch64 target. > > Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-= devel/2023-02/msg03979.html > > Signed-off-by: Vikram Garhwal > --- > .gitlab-ci.d/crossbuilds.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > index 61b8ac86ee..6867839248 100644 > --- a/.gitlab-ci.d/crossbuilds.yml > +++ b/.gitlab-ci.d/crossbuilds.yml > @@ -186,7 +186,7 @@ cross-amd64-xen-only: > variables: > IMAGE: debian-amd64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm x86 should handle --disable-tcg fine. >=20=20 > cross-arm64-xen-only: > extends: .cross_accel_build_job > @@ -195,4 +195,4 @@ cross-arm64-xen-only: > variables: > IMAGE: debian-arm64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm Currently this builds qemu-system-i386, but with your changes and the work Fabiano is doing: Message-Id: <20230313151058.19645-1-farosas@suse.de> Date: Mon, 13 Mar 2023 12:10:48 -0300 Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=3Dn builds From: Fabiano Rosas We should be able to have a qemu-system-aarch64 supporting Xen without TCG --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 12 10:12:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 10:12:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520168.807491 (Exim 4.92) (envelope-from ) id 1pmXSk-0008J0-Fi; Wed, 12 Apr 2023 10:12:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520168.807491; Wed, 12 Apr 2023 10:12:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXSk-0008It-Cz; Wed, 12 Apr 2023 10:12:26 +0000 Received: by outflank-mailman (input) for mailman id 520168; Wed, 12 Apr 2023 10:12:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmXSj-0008In-MT for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 10:12:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84034ac4-d91a-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 12:12:24 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Apr 2023 06:12:14 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6110.namprd03.prod.outlook.com (2603:10b6:5:395::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 10:12:12 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 10:12:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84034ac4-d91a-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681294343; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=nkmtczLzb6GNy4XEaW8RkYxPle9XiClkPiW3KoeJLwE=; b=hg8JNBsgUfnpc0c0IOs0pAKiu2uZ5OQIjzlLDnTMZBFTum3pgtkajyvI xNKKGMhzNgnHBef7vCnZYTlghdCPzkdqrYAa6/Bfe+CvEHIetMHnW7aS2 F2ztJyvGw0zLTFjtsBdvQiNTaUo2wSWQ9furZcJT4hZnYAnoTpbX0MJ1N Q=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 104558752 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:M0iZQ6D5b6woVxVW/8viw5YqxClBgxIJ4kV8jS/XYbTApDl01zJWn GZOCDyOPK3eY2b2c48gO4vi9ENV6J7Wz95hQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9B5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw4MxSWzFl8 84hOW4HQR/c3eSm8Zy5Y7w57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvDS7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqi7x27+QwHmTtIQ6CbOW+v9IsVyogS8XWC0WT2SYkKKchRvrMz5YA wlOksY0loAM80isQsj4TgePineOtR4BWPJdC+Q/rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqf/LqJqTK5OQAOMHQPIyQDSGMt4cTnoYw1pgLCSJBkCqHdpsbuBTj6z jSOrS4/r7Yel8gG0+O851+vqy2ojojESEgy/Aq/Y46+xgZwZYrga4n271HetK9ENNzAEQXHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGpxslePBC KMLhT5s2Q== IronPort-HdrOrdr: A9a23:xWYB7K15bhx7g/Yd09QZCgqjBQhyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHO1OkPMs1NaZLULbUQ6TQL2KgrGSpAEIdxeeygcZ79 YZT0EcMqy7MbEZt7ed3ODQKb9Jr7e6GeKT9J7jJhxWPGNXgtRbnmNE43GgYyhLrWd9ZaYRJd 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njDsRqYrJrBVzSI1BYXVD1ChZ0493 LergD/7qK/99mm1x7n0XPJ5Zg+oqqv9jIDPr3DtiEmEESttu+aXvUjZ1REhkF2nAib0idqrD ALmWZkAy080QKUQoj/m2qQ5+Cp6kdQ11bSjXuVhmbip8viLQhKdvapw7gpPycxonBQwu1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRj+UC3fLFuHIO5l7Zvi399AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8vC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eV66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBsPkoLVeL+zNbFwg2PwqT+GLEXQI+llluhEhoE= X-IronPort-AV: E=Sophos;i="5.98,339,1673931600"; d="scan'208";a="104558752" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjaZUU1gW5/aoVSRY5GSDXFZrVphfdUWzFMmjXqe6lXybFJVyjYRKY0Fzl4gQ2amX58cj0KpGFSy5yllhKy5jYUp6B3UNiWcAcm7GGDGoksDW88pF3BJns32oNxTTXm/xhz+KJmGIBngWvvt8bkw8iZR7dk4SuCUBLyf2OyfodBPRAX3C6aLE/Mfkx9NvFLs/LwQ2IxIgjA28QiQx5ZXTUotlJDtSIacSsLKGCWFwRR4rVB1BNvkSQPRvgmv5Xm6ebuFNljhIMN/k508Mf//0MFFvCDM9na+V36oIrSSKKslDkDFGKYRYJHgPFnvEUl8psuXarY1WczamQfPMP0MwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XGLAXe+N1thtgbkL0MNg4MOYeKvGBwUt6nAxSEZ7hAE=; b=bU2WHp39JQw32OAfFvhVPcjDP8StWjuHN8uc5H65YhPkPDFeajMnZFQpq7OhSooPbEqcrBT9KrAk048RMn0O5Gj29doBTviIcLTf7nBqXa448nmuM6C79LKHQ/LwM7o5bVNcSHLATOo49xYRDKwLR03Rg8815vFogbjOU7PqYu5OuDfAxrq1VzwduHWqT5wOgSAPrIBvopryCtvaP5h/+EcZzusvvFCQAul25PGpPomiOxzM6JO7EYbX+1llgfPm6brcv6tKdCJZ7+MMFtSp6YGrzpcAFim/ICYnrxSy9uyfQmjFDnqlDcSRxIahtK7ToxKIFssdcXp2JOR+JMaIEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XGLAXe+N1thtgbkL0MNg4MOYeKvGBwUt6nAxSEZ7hAE=; b=aLkYrPn9Cj799pSHFIsrXpaPRbfhh5k/H/7bNvu0VA21Jl6zgcOZ9tyGrILM3M5cN5RIx0UZP+pJ20NXypeqPa77+6z45DXnNH4U/RucIWUj7J4EZdR+/cALduyZ0dPz2h7PaHCLYMzhJ6+od0JtvM6/zotqWyiceTIySnTFSn0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 12 Apr 2023 12:12:06 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v3 1/6] xen: add reference counter support Message-ID: References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-2-volodymyr_babchuk@epam.com> <87h6tmxden.fsf@epam.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h6tmxden.fsf@epam.com> X-ClientProxiedBy: LO4P123CA0434.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::7) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6110:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fcf486c-475c-4d42-afdd-08db3b3e6202 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tB2YoYaFAyRJCC3Bj2xw5Hda+zLU0xbEzeLg5UmwPHc0vb/iCQMB3ZLrDt6IMFiDAF0xKCHoyOOIps+3S9YLocRVwTR6WMk3iPNcCJhN5Vw3V1zXNmh1xMYCHErZuQWnUEMeGSpUy7wmv50WfWXzXzlkpOjK1UBP0y/L472VwDBry2BAMsDiX8ZkjOeX2MiaCugcbgT0yNEVoeZnzP60TggDKR4OcfyA5plflbS7cpMiEK9ApFzHkrWXp9cbtxzPX/BwUtKc2X4LZHKHbF8V25zq64TpO9o432b0oK7JUKACm107GHJh7ZUieKXa1/k1ysdk2S9cni+YIzxWzS53yDTNl70b/dn+YfgBrcfBAbd3X1yCTqPY5rPSyOMs07aQAMZMoa6weYnlQ5ajH41j0yzrSTh52C864gXSx6HsV47zaRfe6mWcEmxlKaVUzrcuffZI9Q45jX+QSh9Egg6dPyAxPSSo9qSOC8djwru90iMPjPrT6zgSyL80VtNw/mDn+Oost0mXwKCC/2jSM89NwWsrDQ7uP8EE/hcyXfIx25Dvg6XnVTjRrfwxHql8WP7a X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199021)(26005)(66556008)(4326008)(6916009)(66946007)(66476007)(6512007)(6506007)(9686003)(85182001)(2906002)(6666004)(6486002)(83380400001)(186003)(33716001)(54906003)(86362001)(5660300002)(8936002)(8676002)(38100700002)(478600001)(41300700001)(316002)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0JFY2kwSDRWU0V0OWJlR3V1eWttWVh6NGdZM2xkblJzbG11YXRWUXJDcDdz?= =?utf-8?B?VTdCWEpSbldPcjBVU3B2dGZvWExlZ1E0TDBRb256OWxPYjJWZi9NSS8xVHN5?= =?utf-8?B?U2EzNUFVcjJDTHFhQVo1R1ZVcjhheWk1L3FXWlM3VzRRUVFJL3JoY2grUDRR?= =?utf-8?B?dVprcGRkdWo2dm5vQjV1YWhoWVIvUVM2a3MwN3RpandUOWtTK21zbkVnakRB?= =?utf-8?B?b1RKci9oS2x3WmhMOGRTOG5wbEVKc1BuYklIL050ZkptQlkrakJzVnFpTW9L?= =?utf-8?B?KzBLSkVnRE1pT0kzMnFzUEZhSUNaTVpqUXNZbE9qQjFZNVpnN2t0cGJyZ2Uv?= =?utf-8?B?VmFyeGh4c0h0b0d4QzJUN3laUzBTcUR0RHhWdjlzWThiNkhCZHhSSDB0akhH?= =?utf-8?B?SmRmZ3NCd2p1bjdKNzF4S0JCa2x5czdBZW9hcktwTWgwQ0FyNituZDNlMUI3?= =?utf-8?B?QnJ4cXZEVGJ2RlJNRkNQSDNjWHg2aXJ3NkdGbFkzMTdzTzVKSUFvNERQRjEv?= =?utf-8?B?MDRhRmNDdERxU0F6U0JIa3FZSU5oT1FONGFjQVp4NmI5bURDVkVSeHlGWlh4?= =?utf-8?B?QVo4ZnFlc0lEZ0hNT1ViU05pdWp3cEJhY2tlTlRVbCtJN3B5YWI2RnhUbnB2?= =?utf-8?B?RWZYQTJnb1UvalpvSUVGZWNESGFtSHJyRTE1QkkrWXVTTVZZczI2NzJyLzFt?= =?utf-8?B?RDZ2dUxOL1FJUjZKRExXbHFMODcvSWZwaFFQNS9BdGZ2UzdhSy9ZUHNaK2Vo?= =?utf-8?B?VEQ4TFlaelNxczBoWGs5a3V3UFdRdlp6MUNCTC90Q3FycFhKWWl5cmZ4VkhB?= =?utf-8?B?d0RsaFVhc0gxNmZmd2VycEY0M1doTXZ0OU9ROStOMm9rbHJrSGdIR3lhT3Mw?= =?utf-8?B?QW56KzYwbGZlSGhOMW1xYmhlTWdDaHBlaUVJK1dZVGtVaGhBNS9PL0RyckpE?= =?utf-8?B?bW5OQ1JuSEY5N1pJK09wbUNLeGtCV08xbU9vcEFTUzlJUXJoVXZXWDRkbURt?= =?utf-8?B?Ky9EK3RHR3dLRjR0dUkwTWRZSEZwT3Q2em1Ib1VoT1dUOXJKem16VmhwMkhX?= =?utf-8?B?cEJERlJ5VThRWFZNbFVSN3ROWTFlakpZRmtreTVoRDVCMG5sVENqeis2NHhj?= =?utf-8?B?MVhvTERWUVJlTGwrKzFQOHJzOEFqdStRVktBVHpXVDJoazdTdlNBbE1UcjBz?= =?utf-8?B?OFpVUGZ4SGlnYmhFOFBlb3JPeklvZHM5emYzYitVS0pMOVZqT1BqWm1jTlFa?= =?utf-8?B?UUF3KzBFTGVHa2YwSzJmRGJ5dklOcEQ0Ri9Gc2tlR2o2U0hwdnNRdjN2dmVX?= =?utf-8?B?MmxGc0FOZ2ZvZi9Pa01Xbk45YnZNdzBQQ2NQMGhza0xORlVnOWVmQURxYnNQ?= =?utf-8?B?dEY3cnA0LzBOekFQV2xFdHhodkJnQnJyNG1JT3dxVUlWSlFOeDh2cEtsbkl2?= =?utf-8?B?Q2hZTFJxV2dNL0NVVTBNY0pjVHpXVUxzZ0RuZFFXZGNIRW1GVFkrbUVJVzVN?= =?utf-8?B?cmo3cUQzVWpMMFAzdUtyczBjbzFEbFk3SnRiVEU3Mm9kZ3Nab0t1ZGsyY0tz?= =?utf-8?B?aEtwdHQzZEZ6R24wSUVSSTd5WFFWOG9vc3RUY29seDloUWcvZjFnUDVJM1Uw?= =?utf-8?B?bUJNWGxGUUtUdS9MaG0rSDdTWGtzRlIrRmJOSmFhUXJsNFc4S2JINEtrUTBX?= =?utf-8?B?S2k1eXJYNFBUZkJVVU85bmlURFRrdkRIUk81RVlPTlJQQmp6eHJvNlJxdUdZ?= =?utf-8?B?YnNkR01QWTlka0UzMHZ5WjdoMmY5am9KeHhlMFlzaHRqUmY3a25IN3VjWkVP?= =?utf-8?B?dld2cURBR0ZzVlFaS2RoWHJndjRqa0hlejJpT25jUU50WFVneGZTcExtR0V2?= =?utf-8?B?SUhKN1h1MzVVUHNTTGhOTmo5TFk4YmYwR2dYa2RZdVNzMDczWXdoWXNza0Jl?= =?utf-8?B?dC83Vi9wTzZxanBrZ1lTTTlXTmIyU2RFYnBZYVdRVGR2Y3dtNDBuQXV6Q2xO?= =?utf-8?B?TFZ4eTFsdzd5WGsrbWM5Q2s2emRZcEI2SzRONTFERTRjYk95NldXWjdwSHJv?= =?utf-8?B?Vkk5MDQ4bi94MWU0Q3Z1UWVqb254bTRvcXYzNHVoaUlNV2ZHelNvV1did014?= =?utf-8?B?am9KeEdON2FkZE1TOU5DaXkxd09VOGFQYnNORVgvU0wrbkM0bnkyYzFabnFy?= =?utf-8?B?c1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0J2J5JEH7vsSNHxtUXIHnTInFNsZxYGxGnxuAC/SK9RNguE5nEbTJWfWfYo6gkWZZkyjD1P+6nijQM2R/CEtD2cmJuqLtqJs/lkFBLnWolr4PiFcN5DC0kH4aQaN5p08DnZpzaNDN6xXJv5CZY78VhlrfxX3fwvpHKYgG933ra48v2eRCBv3uaF6icz/HFTRHFAZxqRa9mtcpXYZv7Wz8HNbPIqvD18bxnCEJdhmzpSijnPtKNFIjiNQ6EV5vEGnbXe/eIOJirPgTf3upw8n1XxnD0OMJwWIvuc7Y6byQkYyjGF4iSON/7Cu6POM7OsIWVLsFZzGWUGUse4Cv98bHYE1CRT1GK2whpczIPMfyDrL0OBZmtzL5zZuZnfoKqo1+KofW98UB0XD/7nzM5z8m1N4qidUIODEMden2ysaMiom/OGkJDbfUo7ihKGKL8jYh50C6JHuJoI5JXNp4HgT6VHT7avDnQZKJksEt4vOQZM/w3N2Yz2NBSZvT4uRw7+cR0ehnmBUpgQV+KcivTUQKjVFW0qnbOFlMbNa78HpO6rpMGXSDX3V52U1hBGcnWXqOp2CMz/U5oUpLhQzaC2ZstyparOpJyWKzi2c3KjMc6SHZK3lcjM+K83priWrZupm67WdukSK/5IgaFfkLopNEI5wH8Hhb5G3i1DGUJVubqBIRaLx78A7jJ2QR53Jsjs6RqO8qo4eR0R8AerR9uc6DaYePL1pFZHTdp248YdBAPq9nphSTu1eOO3hfpjvPTBw5b1vYpQ28libueB/gNZkzRaBFl305rm7+686fJH1ynTC5GPU32jG0xUQvsioK6mAwoTf2SgHaICqxjTmXWKZ3whtM41RF7uMlOGYera6NuyI/g6Tjhojr0OZWbVkORUJ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fcf486c-475c-4d42-afdd-08db3b3e6202 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 10:12:12.4592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O5PbhQAJy3womqlFmx5yoEo9BfeHnffIylOxCkupRvH8C3TocLVKRLrabUdoIC6ZehFBOoR/LmsRm6iNBy5m3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6110 On Tue, Apr 11, 2023 at 10:27:45PM +0000, Volodymyr Babchuk wrote: > > Hello Roger, > > Sorry for the late answer. > > Roger Pau Monné writes: > > > On Tue, Mar 14, 2023 at 08:56:29PM +0000, Volodymyr Babchuk wrote: > >> We can use reference counter to ease up object lifetime management. > >> This patch adds very basic support for reference counters. refcnt > >> should be used in the following way: > >> > >> 1. Protected structure should have refcnt_t field > >> > >> 2. This field should be initialized with refcnt_init() during object > >> construction. > >> > >> 3. If code holds a valid pointer to a structure/object it can increase > >> refcount with refcnt_get(). No additional locking is required. > >> > >> 4. Code should call refcnt_put() before dropping pointer to a > >> protected structure. `destructor` is a call back function that should > >> destruct object and free all resources, including structure protected > >> itself. Destructor will be called if reference counter reaches zero. > >> > >> 5. If code does not hold a valid pointer to a protected structure it > >> should use other locking mechanism to obtain a pointer. For example, > >> it should lock a list that hold protected objects. > > > > Sorry, I didn't look at the previous versions, but did we consider > > importing refcount_t and related logic from Linux? > > Well, I considered this. But it is more complex. It has separate > refcount module, which just counts references + kref code, that is > capable of calling destructors. I am not sure if Xen need this > division. In any case, I tried to replicate Linux behavior as close as > possible. On other hand, Jan suggests to rework API, so it will be > differ from Linux one... OK, just asking because it's likely for the interface to grow if there are more users of refcounting, and at some point we might need a set of features similar to Linux. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Apr 12 11:26:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 11:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520175.807502 (Exim 4.92) (envelope-from ) id 1pmYc8-0007F4-Vh; Wed, 12 Apr 2023 11:26:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520175.807502; Wed, 12 Apr 2023 11:26:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmYc8-0007Ex-Rp; Wed, 12 Apr 2023 11:26:12 +0000 Received: by outflank-mailman (input) for mailman id 520175; Wed, 12 Apr 2023 11:26:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmYc6-0007Er-Nf for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 11:26:11 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd5e2407-d924-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 13:26:03 +0200 (CEST) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Apr 2023 07:25:59 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by CO6PR03MB6227.namprd03.prod.outlook.com (2603:10b6:5:358::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 11:25:56 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 11:25:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd5e2407-d924-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681298762; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6J7iWm4iSPCoESaN81BwvrsTYthin0+NWUfWLWrh4YM=; b=P982LGsERJ00AjMchkN2Uq6LX8TIvdMwfNPLS/I8nu9Ej0nXeqB/KDxs 6d1IcwCCNZ5+GlIwKxs6e6fRET+0vid/hlnW5NEOaTmnhJ/yt96tI8ASm Ms6HHOCGMEhsDeLAFdlbHGllb7gCDKfdkX3/RjUAw2DuaSznRWH7U86qN 0=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 105626508 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lhfcXqth59NllZTtkspcPwT8H+fnVJBfMUV32f8akzHdYApBsoF/q tZmKWGEP/jeMTGmfot+Otm2o0pSuJPSnII3G1Fo/3pnRH5H+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOHzSFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAxEAQAqD3/+KyY28Wss0h+IRA9TLFdZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4S9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAN9MTuPlrq4CbFu7nEsQIzgxDUOCg/SCzXagR/VSM X1F5X97xUQ13AnxJjXnZDWjoXuDuDYdXcRRCOww7AyRyqvS7B2dD2JCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BWoLfyoNVwYGy9jlvoAojxjLQ8pjEai6ldn8E3f7x DXikcQlr7AajMpO3aPr+1nC2miovsKQEVBz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6/t3OH06bK3I6Qcyg== IronPort-HdrOrdr: A9a23:QvMwaqyXHa9EWHxyXq+DKrPxS+gkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvoRZxRBf7LdUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrXAgWVxRAXVhJI2PMH/X LemwL0y62/u7XjoyWsmlP73tBzop/M29FDDMuDhow8LSjtsB+hYMBMSqCPpzc8pcCo8RIPnM PXqxktEsxv4zf6f32zozHqxw78uQxeoUPK+Bu9uz/OsMb5TDU1B45ogp9YSALQ7w4FsMtn2K xG8mqFv94PZCmw1xjV1pztbVVHh0C0qX0tnao6iGFea5IXbPt0oZYE9E1YPZ8cFGbR6ZwhEs NpEMbAjcwmOW+yXjT8hC1C0dasVnM8ElOvRVUDgNWc13xskHVw3yIjtbgit0ZF0Kh4Z4hP5u zCPKgtvqpJVNUqYaV0A/pEaderC0TWKCi8cV66EBDCLuUqKnjNo5n47PEe/+exYqEFy5M0hd DoTE5Yj2gvYEjjYPf+kqGjyiq9A1lVYA6diP23v/NCy/jBrfvQQGK+oWkV4oudS651OLyeZx 6xUKgmdsMLY1GeXrqh5DeOK6W6GUNuLvH9hexLKm5mgvi7XbEC5darBsr7Ff7KLQsOfF/ZLz 8qYAXTTf8wnHxDHEWIzCTsZw== X-IronPort-AV: E=Sophos;i="5.98,339,1673931600"; d="scan'208";a="105626508" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wtr7brGMUlrZFWmFb33NIYD/Ug0h0BNvu16CW/wpYvluKWJD/rS/aqosg0jpSRnHEe+0JdQ5TvcngWXcoDbirH+W0IdKZi/IY3zz24TfGMa/QbiF0AEmgA+r3KumI7rb9Hb6tnddwDSLQrNXobMoKFtZ1mmnuNR7Y+9oDt1LbuB/85mDnsVkgszZ4W59VZvwRqd+AyIKXC8glNz/Gua95ZpfgyzZmgsLAJGgbCKYys/7wtG/NBCEJCwEhqnGrktud4YIf8ZG5wz6L1+bx6D/p806yO1EhLLYryRPcrKO2udiSaSsS40dFUde6TO0u5JWJhR3S5C+llHkTYbA2+Eamg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVv+u4ZD0bgtW12ZnZ97zJ8R98hI71abvFB8dGcBmG0=; b=OBTNBGglc6vRbc4GxozfP0vWIAqID0YhD2GBZSH38JyBeqDqJm54VoHbDL+I/pBm2vV7GX2AQu/RX0Ute2sT0kQalew1keGiJ4efyMOdtHuU13+EKjjoggMNPl6v3atBqKnL9XNNiZEEHkyH3uE0Nt9yRUxyryzp7JxsfxdI2s/IfKAx5MVnBxQkFIAJruZ4W9jl2Hppjm69Yuewra1pBGHU9tQxHsm6BBXc7MFDiE8x3XRgf0NBprpmNX4KBpWrGlB0o0vcF7qTZ/4FpH/vB0F8tMP/aQO+1b2Zp3EibV6qBI/Yd9JwHMU6uTpDUpr7Ib5SYp1Sjgh4FeHHxLBYuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVv+u4ZD0bgtW12ZnZ97zJ8R98hI71abvFB8dGcBmG0=; b=fQYRGMe0psAtl+md8iCXG4NpP/htdu+TpZAOek8xPy6pLDX49mpD8B31ga4YNpmQc+Chc8KrKJBjXyzeSikyM9rPPVZ4eOMwJVyB6kYCAclkOqnyvg9w3sWg7R8wj4XI7ZI2tITt4r843+tLi5xEOuOOXsvoYyBmR9QSXcFz5fM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 12 Apr 2023 13:25:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Simon Gaiser , xen-devel , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: RFC: disable HPET legacy mode after timer check Message-ID: References: <0ac3fce6-dcd2-4521-6207-ede4d90e656b@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0ac3fce6-dcd2-4521-6207-ede4d90e656b@citrix.com> X-ClientProxiedBy: LO2P265CA0459.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::15) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|CO6PR03MB6227:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ece3b53-98a6-4b6d-a4f3-08db3b48aedf X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Q3oGv3rBKT6NP9QoowZn4lWHPowYVmRrbnB+v52vKNjI5y7wsA6EQDDyP7imcF7YOUkNKsp4uSqoJK8unCYyQtWZokoTQ/5r3vQXczvRbou/ZwoHdaNtDkBq2YJigvgUkjD2U0ikjv4DU2BSEw9ZM6BQU1ww+i9ufPP6/p2dUEy/ObNeDY6jpP0q4oNqOcbuYkoeojH2hPlnhfAVzkwk3AfOW6j0um13C+4nj0QZ/IXCCP6jOxTEz8m29G+4zOIAhZk/q7c2uXIgcQtznhYaUNsBZeT36/ZxD2rcyNQc+5fF83MxUIJEjjXLJmxA7XdZkvJVl8GQEYoHQHszrVDLWA6DBQwjox9omQHSGDPyl2KYG/0qCfKez3eIniwz3N9KfOnz5iTA2DaqSE98WOtVg468NSL/BvEoESZ4MoR4oDkJuSnzZ2Fk82CYYOwZoR1enKIF8JGbRkjy4kHx/ihTfIRWPKho36WQmrTsfHIwYuJjUBc/GC1Wt8AywANtzYCqpeMYBvgoKvLzkqJP4MX10FeRLiwDm+9jPrCr361mpwQftQ+xiGNuOJXgw4z9FYv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(366004)(136003)(396003)(39860400002)(346002)(376002)(451199021)(83380400001)(478600001)(6486002)(6666004)(186003)(26005)(54906003)(6506007)(6636002)(53546011)(9686003)(6512007)(33716001)(2906002)(85182001)(38100700002)(5660300002)(66946007)(82960400001)(4326008)(41300700001)(66556008)(66476007)(6862004)(8676002)(8936002)(316002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU9UYmdaeFNVSytKemFEKzZabEI1MVZFNjIxeUM0VzRkWTN1ajZCR1ZqV3BP?= =?utf-8?B?SXpBdHQ4UnFkOC9iL0FpUnVjdWRqRFkwbm44RnhnNmhPSzlCK1RiZkVWTi8v?= =?utf-8?B?L3k5Qkw4cjN1a1V2bGxGSVd2WDZOSTdmRC9WbnFkTCsrUFJxVXhvM2xpZ0x0?= =?utf-8?B?cmNKNGpLZWFNc2ZOcDhvT3pBYytvQWZMb25odTEzQzI1bTdyamFnRGhaejNy?= =?utf-8?B?ZzYxOHJub3ZPbENzTzEzL1FXVGR6eFRGL2VJeUh5OVhFdnJqK3hISGdVenlu?= =?utf-8?B?VzM2VlI4a1d6amVTMHU1cUYxeFJFN2E1R01zVVR4ZXVDRWVLNm5aSHNITTh0?= =?utf-8?B?YzNlWHdsMFBuQzNCbE9NWDY5V1p2d2ZIOXNpUmFNZC9lN082Nk9FWUR3WndW?= =?utf-8?B?VHJnU2NBbDF6bHRHN0Z5UTErNWZISi9nRXg0ME94dEYxVlNUS05LRU5nalox?= =?utf-8?B?VTcvdGNsSkYvb0tTRU5kYnRJSEMwUHA4QzJocUwvK2I4cDJOa0tldkhLY0Zq?= =?utf-8?B?NDk1Ky9zd0RRQVAwMVVveVVBSm5tRStzWjBvN2FsVERuLzl0ZHNFc21Td2gr?= =?utf-8?B?WEFtTjB6ZGcwd21tMk5YN29NWVV4WWw4VXU1VnBwS1d1RkF1SStya28zVVZD?= =?utf-8?B?RGRyN3lGcXF0QVJjUUpHaGhZc2NiWVRRNW9VeWdFM1EvR1NXVVZGbUhLVUJI?= =?utf-8?B?YUwwd0I3eW4yUlNYOGE3K0FzOVpMaEJEUkhWRmEvL0VPMUhuT3VYeStubm1Q?= =?utf-8?B?ZXYrTXB1SFk5L0FSTXlVN0J2TU9NRUJlYk1SMGZZR08yc1BLbHNqeURVYWIv?= =?utf-8?B?WVVJTm1hWStEVXZiSE1qNVJ1T3ZBS29ERTZxK01XTnR6TTJ6eEYxd2pQVzRw?= =?utf-8?B?L1lVSW11SmlhTG1aS21XTlAwUFVDSDcyTHJYSFZlTVBTR20rR0ZwNGpMbDNZ?= =?utf-8?B?T2RyUitoNnlvOTBUdGdxdEx5VFhRTkpUa1pqdkxjUWFVdmljamw5S2J3U2ow?= =?utf-8?B?aUZOTytKdzd1YVlHWnpONTc0RzdySk9uOEJUTi84Wi9CZUZUZm1RRGZQOFpF?= =?utf-8?B?eit6YWVBYWtoekJyV0IxWWdUUjNCV0FiMG11N0pSdEdLazN3MUZWWU5RMlo0?= =?utf-8?B?WGYzdFV1NUdUL1JSOGs0OVhTay9SSGs1NEJ0N1U3ZzE2RmJQZnVPRjhqVmJV?= =?utf-8?B?M0tlenRBaWFOY0RqeGZhdXhQVWZzZ2xNVElqaklrait2NWEreG5Sa2c0SGtB?= =?utf-8?B?ZXNGcnM5eUhTamhPaTIyZGIwZkwxTGtXRkd0bE9vV2hRRm4wZ2RkR2t2UWJw?= =?utf-8?B?UkJwdER1OVlGZmNlbnRYS2drRmw2dkZHTHp1WCtzOFVkak5NQVAvdjdQSjI0?= =?utf-8?B?RGJ0KzBXYTVkVUlhcEZEME5oK1BEM2k1S3R2Y1dWbEx1eG1ONTU0MVF5TDlZ?= =?utf-8?B?QTVnbHdTbEtBSmswdHZoN1Z0d1RFMXg2VmMyUmpCU0RZcmZJN2U0ckUzcmRF?= =?utf-8?B?M1Q2M3dzS2xCdER2U2ZnSEc5c3V6YWEwbnZYYThIQ3F2Qi92bXdEYVB2b3JC?= =?utf-8?B?Zmh4N1ExSFpndnNHalBhZWdob3NTM3pUNWphZFROUWhSYlEwb2hUcWV4bXJs?= =?utf-8?B?Qkdmdi9DSEJFRTY5NDRCRE5sOUwzdklwdTVwTFNqY1BiTHR2dkhOcTh4S3dG?= =?utf-8?B?Wk1FRTh4VDZZVkQrUk1hanVjN0t5NXlSS2R5ZFNWSE9ic1JDV2Nsc1dWcGp1?= =?utf-8?B?Ri9lZ29rdkYyMWJVcnNxdU84UE8vcExJMk1ibkpOUTdUbUgwVHJ4R3BEdWxJ?= =?utf-8?B?MG1yVVA3UlFVVytTcmdMSjhNcy9kTDNJTmZnRjEzUEN0cGs2MythbWYrbVRz?= =?utf-8?B?MDJleFIyVFhzOWhjRUV6aWNkM0h4WE1EUld4ZzdYcmo4ZFREOTJiaG43aWlF?= =?utf-8?B?ZjQ5ZW5WamppTGNnbG1UNW41TndncnBKVzVwKzVmUGxydFd5VDVvRUFvNWFU?= =?utf-8?B?M0UxWXJNTUI3bjVNUXBXVEFOZTR3NlBxSTAxdTlBSWlmdXZxVDJOVnNBeEJj?= =?utf-8?B?ZVNuenhMTzJkR1BnZVJLNWdadHoyNHFCK0lteExKanNuck1CTVNRMlRvWnZW?= =?utf-8?Q?GEOWjoJBgiKhAH6sUdJElqa9w?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: MSdUblyKRUE4yzyZu/6G1FyMAw+JT1Hmxyo44deF2S2Tfc/5hGJ72Xuh4ZVPWs7BaKHRpjiKtM47oJGTBBweHkoQA2ih6Sgy+mOfC/+VHWKD2XhEAjJFtulQkrmXz0EkLCKLUeeWKGFDAQ0wI/qnPR/Qd34rOxkJwNZzutylssTqRT4vjnDKMbpvBD2JarA1l0NQZGnfrd/jAh92ouwgczQk9/13yUMUW6eylw61siYiVhHbgFmtBiq7KCQavWxVHS9xxY3XMWMNy2iwWrnN2xmoB7R1tb92Fm4prQpk0RpxsR7zMuZi4rm76epc7k+Aa/DseHSJWZqjIbqkIkebgFxLeij5P8lYwOhcljEAHlKvbmEfwEFjse1suI4C6ClHXbx1UFwI80z2hqTpm1/1onbnNHGIwgyBv8RYFfV+TWGJii8YP6UWrZk6NGfGt0RPtplVy1/JsJgKagh4jDUG1IAnFdffUSrwUn9whfiVGZJh3cyLNIhhhiOQYbxxe6VZWgm5RymBn6flWEQDkztWruJ5euRFU/khxSar9q8MBLJTDiTNbfNpoeK0pMLT+Q17WriPtPqBpf8AGWeH3c7GxbsRXsDQR0ffZn0GTsUxjd01DzrckB0tE5px27HyzbXMvW3mYasRCjiLRIG/2V5rhSphrcprIN60g7nIznOk7K1JL/v+lwfZkJLJR6Bi4Eh5MOQwrRiFShbn3DKZL1QGmImCXvBBuU7F4FfkEJPl0pJdXGP3PjcgUpAl3WWS/Q+q3sBlXn42/5jU+sWZFVTZKtdp4xWZoAY3Xoblgd3Tmz/QfKSBCrprdPleOniq//RzjQrlnKDQPz96JjVQKakGHg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ece3b53-98a6-4b6d-a4f3-08db3b48aedf X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 11:25:56.3181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Nao5uXLAyfAWqCJ9JYGxEfVzTreyw5E5t2xR3v8PepK9sNB1Sx2O0afHTaGpmhkPSMqtevkxwyf47k/kMvyvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6227 On Tue, Apr 11, 2023 at 12:20:13PM +0100, Andrew Cooper wrote: > On 11/04/2023 11:30 am, Simon Gaiser wrote: > > Hi, > > > > I have been recently looking into getting S0ix working on Xen [1]. > > > > Thanks to a tip from Andrew I found that the HPET legacy mode was > > preventing my test system from reaching a package C-state lower than PC7 > > and thereby also preventing S0ix residency. > > > > For testing I simply modified check_timer() to disable it again after it > > checked the timer irq: > > > > --- a/xen/arch/x86/io_apic.c > > +++ b/xen/arch/x86/io_apic.c > > @@ -1966,6 +1969,8 @@ static void __init check_timer(void) > > > > if ( timer_irq_works() ) > > { > > + hpet_disable_legacy_replacement_mode(); > > local_irq_restore(flags); > > return; > > } > > > > > > With this [2] I'm able to reach S0ix residency for some time and for short > > periods the systems power consumption goes down to the same level as with > > native Linux! > > Excellent progress! > > > It reaches low power states only for a fraction of the suspend to idle > > time, so something still makes the CPU/chipset think it should leave the > > low power mode, but that's another topic. > > Do you have any further info here?  There are a range of possibilities, > from excess timers in Xen (e.g. PV guests default to a 100Hz timer even > though no guests actually want it AFAICT), or the 1s TSC rendezvous > (which isn't actually needed on modern systems), all the way to the > platform devices not entering d3hot. > > > > > I tried to understand how all the timer code interacts with disabling > > the legacy mode. I think it only would break cpuidle if X86_FEATURE_ARAT > > is not available (Which is available on my test system and indeed I > > didn't run into obvious breakage). > > > > Is this (disabled PIT && !ARAT) a configuration that exists (and needs > > to be supported)? > > > > Did I miss something else? (Very much possible, given that this is way > > above my existing experience with X86 and Xen internals.) > > Xen's code is a mess and needs an overhaul. > > Right now, we're using the timer as "a source of interrupts" to try and > check that we've got things set up suitably.  But this doesn't need to > be the PIT, or a timer at all - it just needs to be "an interrupt coming > in from the platform". I would even question whether that testing is useful overall. We test a single IO-APIC pin, which still leaves room for the rest of them to not be properly configured, and Xen might not be using the PIT timer at the end. IOW: I think it's fine to test that the timer is working, but forcing that to be routed through the IO-APIC is wrong. HPET for example can support FSB, which skips the IO-APIC and injects the vector directly into the local APIC. We do support the APIC deadline timer, so I'm confused as to why we also need to use the PIT or HPET. I don't think I fully understand the relation between the usage of PIT/HPET/APIC deadline timers on Xen. Roger. From xen-devel-bounces@lists.xenproject.org Wed Apr 12 12:17:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 12:17:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520197.807517 (Exim 4.92) (envelope-from ) id 1pmZPV-0004Yo-84; Wed, 12 Apr 2023 12:17:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520197.807517; Wed, 12 Apr 2023 12:17:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmZPV-0004Yh-4L; Wed, 12 Apr 2023 12:17:13 +0000 Received: by outflank-mailman (input) for mailman id 520197; Wed, 12 Apr 2023 12:17:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmZPU-0004YX-Kh; Wed, 12 Apr 2023 12:17:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmZPU-0008Qb-Eg; Wed, 12 Apr 2023 12:17:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmZPT-0004w3-Vf; Wed, 12 Apr 2023 12:17:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmZPT-00042D-VC; Wed, 12 Apr 2023 12:17:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=01lRaplkKQyfQBYwOAh13Aq5EN5AiVg7fx436qDACUM=; b=RM9AeRNED6f/tsZckZZ9aTucv2 hgFGqdE+fhJ36btBAh5aXzm+ufcFVM7HPrKM48c4a9u/2tG2ReE+8xNHvb4Zr455fJ0HcIb8YL6xR nblI7taRTO8+Z0T6/Odtm5vIurWP4KG3Sf21wuf+svoekyJnnomrLBbTuRny76lmDnX0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 180209: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=e4a5fb9227889bec99ab212b839680f4d5b51e60 X-Osstest-Versions-That: xen=7758cd57e002c5096b2296ede67c59fca68724d7 From: osstest service owner Date: Wed, 12 Apr 2023 12:17:11 +0000 flight 180209 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/180209/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180084 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180084 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180084 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180084 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180084 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180084 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180084 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180084 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180084 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen e4a5fb9227889bec99ab212b839680f4d5b51e60 baseline version: xen 7758cd57e002c5096b2296ede67c59fca68724d7 Last test of basis 180084 2023-03-31 06:37:07 Z 12 days Testing same since 180209 2023-04-11 22:08:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Michal Orzel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 7758cd57e0..e4a5fb9227 e4a5fb9227889bec99ab212b839680f4d5b51e60 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 12:57:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 12:57:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520216.807551 (Exim 4.92) (envelope-from ) id 1pma1s-0000pT-Jq; Wed, 12 Apr 2023 12:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520216.807551; Wed, 12 Apr 2023 12:56:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pma1s-0000pM-HJ; Wed, 12 Apr 2023 12:56:52 +0000 Received: by outflank-mailman (input) for mailman id 520216; Wed, 12 Apr 2023 12:51:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmZx7-0000k9-Gy for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 12:51:57 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cda8aab8-d930-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 14:51:55 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B5D2421977; Wed, 12 Apr 2023 12:51:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3AA23132C7; Wed, 12 Apr 2023 12:51:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SKu3AGqpNmRpYwAAMHmgww (envelope-from ); Wed, 12 Apr 2023 12:51:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cda8aab8-d930-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681303914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VoGmIlsqcWdORKcz9FoVFULPzoKHb5NjNQeKmVcafvU=; b=JR/bMA+GwKZEzsACqpuP4Wf8MuOlQK+oDSTIhVDIuiCMwiSRpOdRoj5Sx6DmOXsSFPshjm Ka2lfN1czFyI8vSpqpdVTYulvpJW3yc/foUuH+tP41J5DoFfxH+VEY3OXw9hI2YPcoYWCr veZj6X34Z9SdVYes0e5YJUUf57/hGfs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681303914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VoGmIlsqcWdORKcz9FoVFULPzoKHb5NjNQeKmVcafvU=; b=BZMyoLWjCvmZ+9aDz5x6X+k9CqX5aypGuZvUHO2ffwsSxItR4TDrJ+aCY8NmZgL3m3mCyv 7aO8HjHldCi4V/Dw== From: Fabiano Rosas To: Alex =?utf-8?Q?Benn=C3=A9e?= , Vikram Garhwal Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: Re: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen In-Reply-To: <877cuhpg1z.fsf@linaro.org> References: <20230411210422.24255-1-vikram.garhwal@amd.com> <877cuhpg1z.fsf@linaro.org> Date: Wed, 12 Apr 2023 09:51:51 -0300 Message-ID: <87ile1clg8.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Benn=C3=A9e writes: > Vikram Garhwal writes: > >> Xen is supported for aarch64 via xenpvh machine. disable-tcg option fail= s the >> build for aarch64 target. >> >> Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu= -devel/2023-02/msg03979.html >> >> Signed-off-by: Vikram Garhwal >> --- >> .gitlab-ci.d/crossbuilds.yml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >> index 61b8ac86ee..6867839248 100644 >> --- a/.gitlab-ci.d/crossbuilds.yml >> +++ b/.gitlab-ci.d/crossbuilds.yml >> @@ -186,7 +186,7 @@ cross-amd64-xen-only: >> variables: >> IMAGE: debian-amd64-cross >> ACCEL: xen >> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> + EXTRA_CONFIGURE_OPTS: --disable-kvm > > x86 should handle --disable-tcg fine. > >>=20=20 >> cross-arm64-xen-only: >> extends: .cross_accel_build_job >> @@ -195,4 +195,4 @@ cross-arm64-xen-only: >> variables: >> IMAGE: debian-arm64-cross >> ACCEL: xen >> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> + EXTRA_CONFIGURE_OPTS: --disable-kvm > > Currently this builds qemu-system-i386, but with your changes and the > work Fabiano is doing: > > Message-Id: <20230313151058.19645-1-farosas@suse.de> > Date: Mon, 13 Mar 2023 12:10:48 -0300 > Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=3Dn builds > From: Fabiano Rosas > > We should be able to have a qemu-system-aarch64 supporting Xen without TCG The build should already be working on current master after Philippe fixed the gdbstub issues. My remaining patches fix tests and general runtime issues. I just sent v10 to the list. From xen-devel-bounces@lists.xenproject.org Wed Apr 12 13:19:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 13:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520221.807561 (Exim 4.92) (envelope-from ) id 1pmaNx-0003J6-DV; Wed, 12 Apr 2023 13:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520221.807561; Wed, 12 Apr 2023 13:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmaNx-0003Iz-AR; Wed, 12 Apr 2023 13:19:41 +0000 Received: by outflank-mailman (input) for mailman id 520221; Wed, 12 Apr 2023 13:19:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmaNv-0003Is-H6 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 13:19:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id acce0f1a-d934-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 15:19:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 96821218FA; Wed, 12 Apr 2023 13:19:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1E86F13498; Wed, 12 Apr 2023 13:19:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PSm5NeivNmTLcgAAMHmgww (envelope-from ); Wed, 12 Apr 2023 13:19:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acce0f1a-d934-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681305577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZnQgldug7U+NIeAhYftaDVy/YRzrSi0DIbP1KUpKmbw=; b=AKnMWaq1qCMQA1L1wez2jgyW8rQSLoHi/KNVsAUC1GC9EQcJwLUh86WjwPMLxoYYTDS6eO IJwY7kMeRUiNsHVwPkFPYBv2TUm6/X5wRN8x3Qm52/2FjcLCh0QQ8WROAqBQsjcnZoYQ4S l6PV/6JRHVzJ5Pt+59KiF1bFhVSveUA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681305577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZnQgldug7U+NIeAhYftaDVy/YRzrSi0DIbP1KUpKmbw=; b=i4w3/kGmJytP7NS46yu7iHK4IZRrRljaV/DXUJFf4JyH0u4i4CyvXrD5aAAxRs1qxj8FU1 QuSXRK+kKUIhN3Cw== From: Fabiano Rosas To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, vikram.garhwal@amd.com, stefano.stabellini@amd.com, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [QEMU][PATCH v6 10/10] meson.build: enable xenpv machine build for ARM In-Reply-To: <20230411224746.16152-11-vikram.garhwal@amd.com> References: <20230411224746.16152-1-vikram.garhwal@amd.com> <20230411224746.16152-11-vikram.garhwal@amd.com> Date: Wed, 12 Apr 2023 10:19:34 -0300 Message-ID: <87fs95ck61.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vikram Garhwal writes: > Add CONFIG_XEN for aarch64 device to support build for ARM targets. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini > Reviewed-by: Alex Benn=C3=A9e > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 52c3995c9d..eb5bb305ae 100644 > --- a/meson.build > +++ b/meson.build > @@ -135,7 +135,7 @@ endif > if cpu in ['x86', 'x86_64', 'arm', 'aarch64'] > # i386 emulator provides xenpv machine type for multiple architectures > accelerator_targets +=3D { > - 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu'], > + 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu', > 'aarch64-softmmu'], I'm not familiar with Xen, so pardon my ignorance, but would it (ever) make sense to do a 1:1 map of host architecture and qemu target? So we don't have to deal with having a build on x86 pulling aarch64-softmmu and vice-versa. Do we expect both x86_64-softmmu and aarch64-softmmu binaries to be used in the same host? From xen-devel-bounces@lists.xenproject.org Wed Apr 12 13:36:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 13:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520226.807572 (Exim 4.92) (envelope-from ) id 1pmadf-0005g7-O8; Wed, 12 Apr 2023 13:35:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520226.807572; Wed, 12 Apr 2023 13:35:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmadf-0005g0-LL; Wed, 12 Apr 2023 13:35:55 +0000 Received: by outflank-mailman (input) for mailman id 520226; Wed, 12 Apr 2023 13:35:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmadf-0005fu-6Q for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 13:35:55 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2058777-d936-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 15:35:53 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id gw13so6549799wmb.3 for ; Wed, 12 Apr 2023 06:35:53 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id p4-20020a1c7404000000b003ee44b2effasm2413602wmc.12.2023.04.12.06.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 06:35:52 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E78071FFB7; Wed, 12 Apr 2023 14:35:51 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2058777-d936-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681306552; x=1683898552; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=pp/vZNTH1CdYoakxWMjsbyXkrBnC6lsoL8fgM36jhHA=; b=UdnscHMEvQz45UkLik37L0hEIoYpItpzh0YlKZDl85OiVjf15e/Kusv7Q22Nt/B7Sg 8U4bUJwS+rxvIUcFzhv6pw/xeOvQlhS/4KG0r+++aLXVNeR8BBGBM8ffToibmc7lxJPM vT0qxlkgOwxmtM0U68ttNyjdRl7SBaon2terdXX7UoK/9dJDyAHYxzcqjNVtP3HhnvRR 0Zxw5ugxQcXH7EkWUIh3vkXLSiyyr7m1tYeC8hg2QKx1AMlF0AJ6xwx9E3D0r3f+oiO3 Eb5vACUdhbCOiTSA+KErKHtsDc3JfFPxWP9+qCDfbkz7QMp1qcfNJE1TtE3BAOnAVms1 MaYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681306552; x=1683898552; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pp/vZNTH1CdYoakxWMjsbyXkrBnC6lsoL8fgM36jhHA=; b=Pt8fAX/trDB+yauhwf/a5kBhFrhJC18o/YiwtfK3V3QT8xw2+Jh4kZ7ijrFIwy7jen SQIBvk5i2PwSGW4Qoa1b/P3US9Im35b2U868r0qJesKTG+jZ2dy22IUJUAF0uqK7nU3k 7LcXQISWM1QKvPMpIiH3IBwZSx3U+/ATmirEIJGYcLsWzl52RYGUFoxzE/9CFLDaeUoo UpQToQuoBacUvJ8u3FARxStsihs+8WqeGn1/TWh0w2HMZEKMj0tApNSSt+497HkKCc5Z SByab2v/d2uwCmEcwWN4keIZpddgI+uO6k/75mo+lQcK28qIbZo5QpjUqoywc0PS/kpq Vy6g== X-Gm-Message-State: AAQBX9fn0iYgyIR3A1zLTmhC15N0g978nk2TWtdkMWPeBFHHFqqLaHyA rL99UPxG5YPCg8OIaLfRGKp1PA== X-Google-Smtp-Source: AKy350ZMvSEee+J206l5ykzqOZYJksxor/SX5VB6FJI2pHRVAyrysQrLIuP9OKazZ7dvbgMZlvebZw== X-Received: by 2002:a1c:ed18:0:b0:3ed:5eed:5581 with SMTP id l24-20020a1ced18000000b003ed5eed5581mr2256488wmh.2.1681306552665; Wed, 12 Apr 2023 06:35:52 -0700 (PDT) References: <20230411224746.16152-1-vikram.garhwal@amd.com> <20230411224746.16152-11-vikram.garhwal@amd.com> <87fs95ck61.fsf@suse.de> User-agent: mu4e 1.10.0; emacs 29.0.90 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Fabiano Rosas Cc: xen-devel@lists.xenproject.org, vikram.garhwal@amd.com, stefano.stabellini@amd.com, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Subject: Re: [QEMU][PATCH v6 10/10] meson.build: enable xenpv machine build for ARM Date: Wed, 12 Apr 2023 14:32:03 +0100 In-reply-to: <87fs95ck61.fsf@suse.de> Message-ID: <87pm89nryg.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Fabiano Rosas writes: > Vikram Garhwal writes: > >> Add CONFIG_XEN for aarch64 device to support build for ARM targets. >> >> Signed-off-by: Vikram Garhwal >> Signed-off-by: Stefano Stabellini >> Reviewed-by: Alex Benn=C3=A9e >> --- >> meson.build | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meson.build b/meson.build >> index 52c3995c9d..eb5bb305ae 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -135,7 +135,7 @@ endif >> if cpu in ['x86', 'x86_64', 'arm', 'aarch64'] >> # i386 emulator provides xenpv machine type for multiple architectures >> accelerator_targets +=3D { >> - 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu'], >> + 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu', >> 'aarch64-softmmu'], > > I'm not familiar with Xen, so pardon my ignorance, but would it (ever) > make sense to do a 1:1 map of host architecture and qemu target? So we > don't have to deal with having a build on x86 pulling aarch64-softmmu > and vice-versa. > > Do we expect both x86_64-softmmu and aarch64-softmmu binaries to be used > in the same host? Xen is different from the other accelerators as it isn't really guest CPU aware. It is merely io device emulation backend albeit one that supports a non-paravirtualised guest on x86. But you are right that using qemu-system-i386 as a backend on aarch64 hosts does cause some cognitive dissonance for users. For aarch64 hosts we would only support the VirtIO guests. --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Apr 12 15:03:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 15:03:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520242.807617 (Exim 4.92) (envelope-from ) id 1pmbzo-0006jq-Ke; Wed, 12 Apr 2023 15:02:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520242.807617; Wed, 12 Apr 2023 15:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmbzo-0006jj-Hm; Wed, 12 Apr 2023 15:02:52 +0000 Received: by outflank-mailman (input) for mailman id 520242; Wed, 12 Apr 2023 15:02:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmbzm-0006jY-V7; Wed, 12 Apr 2023 15:02:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmbzm-0003zH-TT; Wed, 12 Apr 2023 15:02:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmbzm-0005hl-CY; Wed, 12 Apr 2023 15:02:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmbzm-0003Ry-C4; Wed, 12 Apr 2023 15:02:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IXE4p6CRxNgxxkFLgwNbXuDtLKhZwUYTZdPeTqYO48M=; b=QTqdmbGNkSTAsgcVgnjG1pU7yh JA+UBsLtTIGe7rvVWzaY01fiqd9pnL6v8NzpYxH4bxjqByIza4HsWj22ZtOoVM8yV0YmJ0Kj5LkrI L/b3YhJcZzKaQC3VhhE08skR1cuS1Z5oK/dE2+XGCI/b+3r31WBp5fFwTht3UU3+/S58=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 180217: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.14-testing:build-armhf:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=622675cdbc5f249bddfe970054f43a867d3ebed0 X-Osstest-Versions-That: xen=e49571868d67944b9f4a546ade130e0b6e506b65 From: osstest service owner Date: Wed, 12 Apr 2023 15:02:50 +0000 flight 180217 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/180217/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 179840 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 179840 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 179840 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 179840 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 179840 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 179840 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 179840 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 179840 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 179840 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a version targeted for testing: xen 622675cdbc5f249bddfe970054f43a867d3ebed0 baseline version: xen e49571868d67944b9f4a546ade130e0b6e506b65 Last test of basis 179840 2023-03-21 12:36:28 Z 22 days Testing same since 180217 2023-04-12 08:06:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Julien Grall Roger Pau Monné Stefano Stabellini Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e49571868d..622675cdbc 622675cdbc5f249bddfe970054f43a867d3ebed0 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 15:14:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 15:14:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520248.807627 (Exim 4.92) (envelope-from ) id 1pmcAX-0008Fe-LH; Wed, 12 Apr 2023 15:13:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520248.807627; Wed, 12 Apr 2023 15:13:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmcAX-0008FX-II; Wed, 12 Apr 2023 15:13:57 +0000 Received: by outflank-mailman (input) for mailman id 520248; Wed, 12 Apr 2023 15:13:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmcAV-0008FR-D3 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 15:13:55 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2062f.outbound.protection.outlook.com [2a01:111:f400:7e8c::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1ecc93e-d944-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 17:13:53 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by IA0PR12MB7603.namprd12.prod.outlook.com (2603:10b6:208:439::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Wed, 12 Apr 2023 15:13:48 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.028; Wed, 12 Apr 2023 15:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1ecc93e-d944-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4CJLINdkooA43MQr8C58k69DehRV4CFeX4n8Jo1c2g05nrDNrSaIbqbccDOZ9OLXpE6j9S6ERS3zFYP7x6840neJWQn52JF4KqVXO9t5sHCorRkYpYkbUxcjlPd9wZyV0XU6MkdXfhJlgXA8vNn9A8mR5VcIAdeChoPQbTeGbpYGdGdMm3JpHzufuOWAP6Tlei5Qsk4vfKnwhUHTzonxvFmezj6l+/45tQcyxBmuh1/KEG+rkEhCGdJdC7SAyUD/2z4XOxqcRY6vm/is07wK3Ru/fjH/J4JHp4WO40MTvvZ3TdsHhuDO+pVRWrXHIF6SQH00M0p+gDZJXiktfjA5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UTQlqOpWjyxi5i6sQJNA7jdhRycZqCJb3WK+QddfC3I=; b=VMAL1Kkq6kZKfpEeKq3x+yrwNKqvNbg5G/y8cy2QSEqsJ2dpI95FNFP/5KyeHp8OJvyXYmfGTxTIbgQ59sDRYB20LZeLKODuWqLLWLvPtd2Nu9WL1igATrw4aKli6CScZUyVRQFdpJWyGnG6Vr8e0izcv5SplMdcX8pTX/gROhsIAOXtY9D7WsOaV/bUD5STHx2eEr7X9iP9ScBgNM6DBnhNjrmZ7PPm+Phi4UOqYojla1dVUwGHsv8+UPcWKtiwjVXimoyXFcJIUCPBEXCuaxsWsxaIKWVlZSbBuIaNvzAMB7ZeuDUsYpAWFsdnf/uUsN9E/zlFnmuVJW+zFTqNHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UTQlqOpWjyxi5i6sQJNA7jdhRycZqCJb3WK+QddfC3I=; b=a5bo6F9I5l+hiKp3LVPTQFE81zcwCrIxmxGj7GG0hFXzz5duJ6a0PxQRB3iTiAijVuMiuDJ/vSJwnx6BIlaKwpoJ7wCpQO2WQm0e8aJXVvaqirC9BXkFgHMS+7nATarFRhbLl0ZWM5ujZLvLWeHmagqSaUMAyloBGVD9qpbhFK0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <41e4a106-c06b-ea29-4be4-ac46b561e17a@amd.com> Date: Wed, 12 Apr 2023 08:12:03 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen Content-Language: en-US To: Fabiano Rosas , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal References: <20230411210422.24255-1-vikram.garhwal@amd.com> <877cuhpg1z.fsf@linaro.org> <87ile1clg8.fsf@suse.de> From: Vikram Garhwal In-Reply-To: <87ile1clg8.fsf@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0203.namprd05.prod.outlook.com (2603:10b6:a03:330::28) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|IA0PR12MB7603:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c649a81-fd7a-4467-ac5c-08db3b6883d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JQB+wd4d+wpf889o0ntlAXJpcBnTscZCn0PQMCPOkoy7tweyvw1AtoXakiMaLmZ/qHw9Mo2YtfOWWYBiTDz1lRcjY5eapa/JVtSDU82g/fqk+dCUQKHlDU0HQfusbewLWUx2IkqT53RFZIAUf3t570zKqHSSZFDOngjUuBKH5UJ3t1IIudmNXFjKXHCAVfFO+Ct/Jzbm5rkK9qEeQhF2mzbAebHthV4Wvk865fHJwIl8hmwA0ulyPyqFXzotyrdsa/rZp3dvm2HEcHExxdQ+H354jWQG5QDGEymxpQUXmfh97h47SGTUgLGVmo6Trnz5fAVCPveRnem4KUFa/5I1uL4ts+WwnLP7QZ7CEdGa4Z/AqFdbgx9p6Af/DqhkBROBFjRI1YzhZWq0SdwL6bZwDB0ewKR/SqX80+Et3rp4D58vreYWK9s7n1U+JtipWHYglozvpDGSua1LuN3lFBOakRYVHkPRBcPIMRv7KtlHR0vK4WKDLoLT6m3r+WKB7XuLCSjb5jcklMiEfHjNMslLhucezNHcFILRQ0EC4/851FSNo3kOMm7u91/8Q60tPtulMYRv6pxTfXeE1uGm0OU2ZzJDvhksn7ERXhkjWSZqppGZgdPKAPjgdF6BmLGjsIUwF/UUGdGH+oNCsG5FMhQleA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(451199021)(6666004)(8936002)(44832011)(6486002)(966005)(5660300002)(31696002)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(478600001)(31686004)(110136005)(54906003)(38100700002)(53546011)(316002)(26005)(6506007)(2906002)(6512007)(2616005)(83380400001)(41300700001)(36756003)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTVOYVlYL2N4RUlIeU15TGZhcTlVajNHNVh2ak54dERnUzZuMFZ2WjlTdXlU?= =?utf-8?B?TGZSVThnSkFjY0p4MUpZd0lWbnNHbkg0K01aSDQ0dG13QTR4MFVJUzdsWHdF?= =?utf-8?B?WE9KZWtNUENKL2lZU3Y4NkVtbGljNXI3RXRRa1RMaWtUMU4xcGlIY0x3YTV5?= =?utf-8?B?c0F3c205cDR6dS9PWHNGeE9OOVA1dCs5TkJzZUFwMmtSSERYaDZnbFNueHVN?= =?utf-8?B?NzhYdDBIWE1HeE9PUmg2WHhFNkdaWGFQK0FPQUtaTStqYmIrbWYrR2htb1l0?= =?utf-8?B?SDlKZlhQMUxoMDNyWGdLenQwWjZmekdoMGdzdGlBOGhsM01QZGswR2ZvbUJI?= =?utf-8?B?ekhxSHozdXNwNFkrZnRjUVgxYXpkajI3aDQ2OWJOSjgwYk54L1RXdFl4ZGJQ?= =?utf-8?B?bFlTSnI4NG1ZWFV5SVd6WTkwM1ZSdzVZczFndTBJbjdiM2hKaENDN2oxT0lM?= =?utf-8?B?WUJ5WnJpVGcvTkx1S0VHRHZDWWlnMjhuQ1hWLzdiWGdibHdxY1p3Z2NGdVNk?= =?utf-8?B?cVRFTStIbXVrN2hzc25vTG9uRDZqSjFaK05ORDQ2Yjh3clRsRmRFQXZnZm1D?= =?utf-8?B?NW0yZDFTYzh6SHBvMTJZVTY1Q3JXSHlraERjQ2tHOTh3UUxYeStydE1DYytj?= =?utf-8?B?aUlDQTRnS0NlUXBqbnJrVE4rZXlOckxWZDRjSWZ6ZWdWWUpoM3VpWmV6dyto?= =?utf-8?B?NWw0QzJqMUhtVDhjSkRNMS9aLzF6N3B1NGpjZkJIT2V1UldkTFNzTUt6TnFn?= =?utf-8?B?Sjgvb3FHZGpUaDFNcDN6dVdKeW1IMDdOUmVQcnk5UGFNbDc5VXVLb204dVFM?= =?utf-8?B?eEVCTUxTMUh6MEdsR0FQeWZ4SEJmLzVaSlpXcE8rNnY3VE1FL2F4YXpyWEEw?= =?utf-8?B?SzlkNHZlVGJOR1BXMHZiZVhhT2d0SXRISHVZejI2S2M0ZTM0VDIvbUprVTE1?= =?utf-8?B?QWNqM3FjWFNHMENJK0VEVXB2ZER4aWw1T1pTTWZoc2w4NUhNQWltSmdSMFNQ?= =?utf-8?B?L2pXcUc2VjJmbE5BdDhQR1o5emx4YjQyQW5jSTRVeVhZTlUwUmNQYkNFU01I?= =?utf-8?B?bHoramRYTXdUZXdDMnpmd2tSZE9LYUY4bVNPd0hGZGJINzRFNWczQkYzVEVo?= =?utf-8?B?YUNidTIxYXRzQ25jY1VtYXhucEFkcmNtSUpCTm1jOEdSNlZRd3FTZVJWNWF5?= =?utf-8?B?RVkvVVBreElFTHVHVWwrY2hHbjhVa1J4WHRzbXpOUFc2VmsrNHE1NnZYU0pU?= =?utf-8?B?dzFTMWVkQnlreFo0WERRSXRGeXZFdzRwNEVxcTc4Ymg4ZHZFRWdyekpPaVNs?= =?utf-8?B?SmlnbFAra05SeGgzVVZ0aG5zQm9nRE9NMEtVWGx6SkZ2RmlvdFRzVFozbFR0?= =?utf-8?B?TExZVXV4dDZBREtmRUYveVdOTFgwdEFadCt5NmFQd3dyZnBxSm54eGZuTGNK?= =?utf-8?B?a2dNTHJQSDA1RXdKQ2Q0U21pWk1aRy9jdmhDcndsOVNpNFl2bVc3QTFieHJW?= =?utf-8?B?ZzhqQSszZW5NYmxLdDRxbXlWbEU2OXhrRDZycnMzc09zOCtHaXMrVlpOamNP?= =?utf-8?B?d2ZqQ2NZTFEvL0wwcE1DOTZFUXgzNjFYNVl2cElPY3NNejVUeGhSbFlDVVZP?= =?utf-8?B?NkJVeFkrbWprTzVaRS95bTQwZlZrUlY4OUx4L3daYVcvcGRZelU3U2lLK0VX?= =?utf-8?B?ZXFqalBZU2tGbzVBK3pjaDR0cCtjZmczc3pUL3djSXI3RTExbjRZeUFETmYw?= =?utf-8?B?ZC8weWhHUUxxNjB6SExYVVUzSUNMbEE0eFhPVFBVckJBR2dBeHRYNkhGRVhL?= =?utf-8?B?dzhoSGZjcFhBTFFTRHMyaDlSc1RIc1E1OHVBVTdvMVM1aFlCWElEZTFhNVpU?= =?utf-8?B?dE1JbDBYNTFEUTRyUUVJcTZMNXdzK1FpY3pFakNqZENER3ZnUDBBcklKWTVu?= =?utf-8?B?Z0VSSU81M05IcmpYNXRHMTZKYVFjZHNFK0NvZ3poN0VBOCtwZkhySVpCR1p1?= =?utf-8?B?UndNZmRJOEpNUTlHSW96Ym1rU01UUGozSFdQTjVtY0ltaG1RUit6ajhPcVRH?= =?utf-8?B?bkEreTdOZ2loRzVvdCt1SmJSUFd2cFlZeGdjZitxenRiN2E1czU4SUVrYnJV?= =?utf-8?Q?cE5WM0mKFclvp7CL+pdl920Yj?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c649a81-fd7a-4467-ac5c-08db3b6883d4 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 15:13:48.0904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yU0jEEMPNN6yexGevDFCMMIsBFrUeKxOvW0ntI0xa3+WzwJ7go/mSw66MdUof4ihDtP46dJhEWLrvhJkYmPiOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7603 Hi all, Yes, gdbstub build issue is only for for aarch64-softmmu target and that was the reason for this patch. x86 targets build fine with ''disable-tcg" option. Thanks Fabiano & Philippe for sharing the existing patch series for this. Regards, Vikram On 4/12/23 5:51 AM, Fabiano Rosas wrote: > Alex Bennée writes: > >> Vikram Garhwal writes: >> >>> Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the >>> build for aarch64 target. >>> >>> Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html >>> >>> Signed-off-by: Vikram Garhwal >>> --- >>> .gitlab-ci.d/crossbuilds.yml | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >>> index 61b8ac86ee..6867839248 100644 >>> --- a/.gitlab-ci.d/crossbuilds.yml >>> +++ b/.gitlab-ci.d/crossbuilds.yml >>> @@ -186,7 +186,7 @@ cross-amd64-xen-only: >>> variables: >>> IMAGE: debian-amd64-cross >>> ACCEL: xen >>> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >>> + EXTRA_CONFIGURE_OPTS: --disable-kvm >> x86 should handle --disable-tcg fine. >> >>> >>> cross-arm64-xen-only: >>> extends: .cross_accel_build_job >>> @@ -195,4 +195,4 @@ cross-arm64-xen-only: >>> variables: >>> IMAGE: debian-arm64-cross >>> ACCEL: xen >>> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >>> + EXTRA_CONFIGURE_OPTS: --disable-kvm >> Currently this builds qemu-system-i386, but with your changes and the >> work Fabiano is doing: >> >> Message-Id: <20230313151058.19645-1-farosas@suse.de> >> Date: Mon, 13 Mar 2023 12:10:48 -0300 >> Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=n builds >> From: Fabiano Rosas >> >> We should be able to have a qemu-system-aarch64 supporting Xen without TCG > The build should already be working on current master after Philippe > fixed the gdbstub issues. My remaining patches fix tests and general > runtime issues. I just sent v10 to the list. From xen-devel-bounces@lists.xenproject.org Wed Apr 12 15:49:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 15:49:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520253.807637 (Exim 4.92) (envelope-from ) id 1pmciL-0003Gt-6C; Wed, 12 Apr 2023 15:48:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520253.807637; Wed, 12 Apr 2023 15:48:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmciL-0003Gm-3J; Wed, 12 Apr 2023 15:48:53 +0000 Received: by outflank-mailman (input) for mailman id 520253; Wed, 12 Apr 2023 15:48:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmciJ-0003Gf-GC for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 15:48:51 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84108b4c-d949-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 17:48:49 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso11523826wmr.0 for ; Wed, 12 Apr 2023 08:48:49 -0700 (PDT) Received: from [192.168.2.1] (82-64-138-184.subs.proxad.net. [82.64.138.184]) by smtp.googlemail.com with ESMTPSA id p23-20020a1c7417000000b003f0824e8c92sm2785131wmc.7.2023.04.12.08.48.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 08:48:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84108b4c-d949-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rabbit-lu.20210112.gappssmtp.com; s=20210112; t=1681314528; x=1683906528; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6LBfq31O2AAEWRG4ywnAOsuD4uMl32CAztINfYySm/o=; b=FomN/lr86BLNsr3Y6cWC+1+pMbxorYG9R719VX9WrNvHZJTeZ4y4gy7Hxc8h0IuPFv Obb5gp+sgDGmu6fI2h9Rz36/Vq/uhoDSvPzjHhTLKNDZlT0W1kTOVIHy3YeSIgD+907Y k2+cAIZRcpzgLey++BfSxQysBcaqm83FKMdY6AuRlgt6RfCdRjWdhw/vZBQwzgjSYUyD 8a1KSEZ4kug8fGGNzrdEKpV5KssgDq7w6Zdd2Z8HeUmAz+wJnzlXZKE0auPiSbIM4uFX YmzCz31IcXt+TMYZolqT+Ca4fen/pcrZBDE4f6dJaKqkln/Mf4IWh6EhbJ9GV9D2q9Rx K4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681314528; x=1683906528; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6LBfq31O2AAEWRG4ywnAOsuD4uMl32CAztINfYySm/o=; b=g03A9ZG63od65j7Q9eoLTZmAX2zSPIHay1V+5IStWVh+/B4FfEi16M4zJ0LZJKuNf1 2qhzo92DFwQ/KrbxBRp69mv5JBDKUAlJDYn9+s780xDpXhjt3QHOZ5gEWTmoTEV0b2V5 yxEQhN2b9VSjbOqKR45DkX5vagTurWZsxavzEDGVq+SJPYFWgxTg/s024UOIietztrg9 dUCd7OcFXPAYg7n9nbdnzS1Je3UWQYFwOdqRe4Ntb2yqx0mHUupQFO7bjEWDZBfWhYa1 CI/KU05eLbw90FhyWpZVzdmH1CskUGqw6bt9WMDEn3VgJNP+pz3y/LNRGrlxW1r8e05J 3V5w== X-Gm-Message-State: AAQBX9d1UZ3A2AMD2s79vM04McIr/tZc5aXNfHfqPpn8FgRxWDzVNe3t k1mL+GdFQiZPXhwvjggXV1UzIN/jDfmsxCQFxfI= X-Google-Smtp-Source: AKy350ZulnTz82F7LR/eWwDJDfiN8TI/mkgCMOD78h2qvnKeIWRImZdwnFRQOMiUurBImH3ktPxG+g== X-Received: by 2002:a7b:c4c8:0:b0:3f0:9b53:b997 with SMTP id g8-20020a7bc4c8000000b003f09b53b997mr2609182wmk.35.1681314528622; Wed, 12 Apr 2023 08:48:48 -0700 (PDT) Message-ID: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> Date: Wed, 12 Apr 2023 17:48:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: zithro Subject: xenstored: EACCESS error accessing control/feature-balloon 1 To: xen-devel@lists.xenproject.org Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi all, this is what I have in "xenstored-access.log" in dom0 : [20230411T23:48:27.917Z] D5 write control/feature-balloon 1 [20230411T23:48:27.917Z] D5 error EACCES [20230411T23:48:27.923Z] D5 write data/updated Wed Apr 12 01:48:27 CEST 2023 It happens once each minute, on two different hosts, both amd64. (both hosts using the same config, only the hardware differs). I tried looking up for a similar bug, but didn't find one. I apologize in advance if this error is known, and if this is not the place to report this ! ----------------------- Technical infos ----------------------- dom0s: Debian stable, kernel 5.10.0-21-amd64 Xen 4.14.5 xl.conf has : autoballoon="0" GRUB_CMDLINE_XEN="dom0_mem=2048M,max:2048M dom0_max_vcpus=4 dom0_vcpus_pin loglvl=all guest_loglvl=all ucode=scan iommu=verbose" Running "xenstore-ls -f -p | grep balloon" returns no result ----------------------- domUs (D5 in above logs): HVM TrueNAS Core, based on FreeBSD 13.1-RELEASE-p7 (it happened also on previous FreeBSD realeases, but don't remember when it started, logs have been filled and rotated). In cfg files, using either the same value for "memory" and "maxmem" or only setting "memory" give the same results. What's strange is that I have xen* commands in FreeNAS : xen-detect xenstore-control xenstore-ls xenstore-watch xenstore xenstore-exists xenstore-read xenstore-write xenstore-chmod xenstore-list xenstore-rm root@truenas[~]# xenstore-ls xenstore-ls: xs_directory (/): Permission denied root@truenas[~]# ps aux root [...] 0:36.98 [xenwatch] root [...] 0:01.01 [xenstore_rcv] root [...] 0:00.00 [balloon] root [...] 0:01.74 /bin/sh /usr/local/sbin/xe-daemon -p /var/run/xe-daemon.pid [...] The xe-daemon looks strange also, I don't use XenServer/XCP-ng, only "raw" Xen. And this script which hand I also use PFsense domUs (based on FreeBSD), but they don't exhibit this behaviour (ie. no xenstore access error in dom0, no xen* commands in domU). So is this a problem with TrueNAS rather than with Xen ? If so I apologize for wasting your time. Thanks, have a nice day ! (and as it's my first post here: thx for Xen, it rocks) zithro From xen-devel-bounces@lists.xenproject.org Wed Apr 12 15:59:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 15:59:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520258.807647 (Exim 4.92) (envelope-from ) id 1pmcsm-0004pz-9k; Wed, 12 Apr 2023 15:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520258.807647; Wed, 12 Apr 2023 15:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmcsm-0004ps-6f; Wed, 12 Apr 2023 15:59:40 +0000 Received: by outflank-mailman (input) for mailman id 520258; Wed, 12 Apr 2023 15:59:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmcsl-0004pm-Dj for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 15:59:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 063aafaa-d94b-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 17:59:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9D1F721852; Wed, 12 Apr 2023 15:59:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8400613498; Wed, 12 Apr 2023 15:59:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rN2CHmjVNmQVQwAAMHmgww (envelope-from ); Wed, 12 Apr 2023 15:59:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 063aafaa-d94b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1681315176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r2sDQFE0958jm+r9RCHSMtJJSFOUbPg85D4fX12sQKU=; b=Wovnyqf/iXpjFBFaKebkCa3aM60LRrj7jXW15Fc0nEtDrvGELbhpIMGubaBU+St7eETdzA RBx4ecleQ98HMfetMrl2W8i1895WY40lUnEMlfD75jLXmhaRW2eSe/bxtQHgujcKq+JykS 5d5Zd+zDhjBjncF4lMV5taqerszA54Q= Message-ID: <4df0a9b9-db58-c25e-f166-878efd53e5d1@suse.com> Date: Wed, 12 Apr 2023 17:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 Content-Language: en-US To: zithro , xen-devel@lists.xenproject.org References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> From: Juergen Gross In-Reply-To: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9yO0uIg1vua9CFsYKNPhS6qZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9yO0uIg1vua9CFsYKNPhS6qZ Content-Type: multipart/mixed; boundary="------------p3P0VdE0yxKc78Ow5j7oQ4Vz"; protected-headers="v1" From: Juergen Gross To: zithro , xen-devel@lists.xenproject.org Message-ID: <4df0a9b9-db58-c25e-f166-878efd53e5d1@suse.com> Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> In-Reply-To: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> --------------p3P0VdE0yxKc78Ow5j7oQ4Vz Content-Type: multipart/mixed; boundary="------------yL0GrpwVDbBsGQJmvbglSETD" --------------yL0GrpwVDbBsGQJmvbglSETD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDQuMjMgMTc6NDgsIHppdGhybyB3cm90ZToNCj4gSGkgYWxsLA0KPiANCj4gdGhp cyBpcyB3aGF0IEkgaGF2ZSBpbiAieGVuc3RvcmVkLWFjY2Vzcy5sb2ciIGluIGRvbTAgOg0K PiANCj4gWzIwMjMwNDExVDIzOjQ4OjI3LjkxN1pdwqAgRDXCoMKgwqDCoMKgwqDCoMKgIHdy aXRlwqDCoMKgwqAgY29udHJvbC9mZWF0dXJlLWJhbGxvb24gMQ0KPiBbMjAyMzA0MTFUMjM6 NDg6MjcuOTE3Wl3CoCBENcKgwqDCoMKgwqDCoMKgwqAgZXJyb3LCoMKgwqDCoCBFQUNDRVMN Cj4gWzIwMjMwNDExVDIzOjQ4OjI3LjkyM1pdwqAgRDXCoMKgwqDCoMKgwqDCoMKgIHdyaXRl wqDCoMKgwqAgZGF0YS91cGRhdGVkIFdlZCBBcHIgMTIgMDE6NDg6MjcgDQo+IENFU1QgMjAy Mw0KPiANCj4gSXQgaGFwcGVucyBvbmNlIGVhY2ggbWludXRlLCBvbiB0d28gZGlmZmVyZW50 IGhvc3RzLCBib3RoIGFtZDY0Lg0KPiAoYm90aCBob3N0cyB1c2luZyB0aGUgc2FtZSBjb25m aWcsIG9ubHkgdGhlIGhhcmR3YXJlIGRpZmZlcnMpLg0KPiANCj4gSSB0cmllZCBsb29raW5n IHVwIGZvciBhIHNpbWlsYXIgYnVnLCBidXQgZGlkbid0IGZpbmQgb25lLg0KPiBJIGFwb2xv Z2l6ZSBpbiBhZHZhbmNlIGlmIHRoaXMgZXJyb3IgaXMga25vd24sIGFuZCBpZiB0aGlzIGlz IG5vdCB0aGUNCj4gcGxhY2UgdG8gcmVwb3J0IHRoaXMgIQ0KDQpUaGlzIGlzIG5vcm1hbCBi ZWhhdmlvci4gQSBndWVzdCBpc24ndCBhbGxvd2VkIHRvIGNyZWF0ZSByYW5kb20gbmV3IG5v ZGVzDQpiZWxvdyAiY29udHJvbCIsIGFuZCAiZmVhdHVyZS1iYWxsb29uIiBpc24ndCBjcmVh dGVkIGJ5IHRoZSBYZW4gdG9vbHMsIHNvDQp0aGUgZ3Vlc3QgY2FuJ3Qgd3JpdGUgImNvbnRy b2wvZmVhdHVyZS1iYWxsb29uIi4NCg0KDQpKdWVyZ2VuDQo= --------------yL0GrpwVDbBsGQJmvbglSETD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------yL0GrpwVDbBsGQJmvbglSETD-- --------------p3P0VdE0yxKc78Ow5j7oQ4Vz-- --------------9yO0uIg1vua9CFsYKNPhS6qZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmQ21WgFAwAAAAAACgkQsN6d1ii/Ey8X iAf9FWt+pJn+P3pI4pDGa5L4WrLIfxNPj1Wc24Oeo6PzGbsIh0fvb/dSNKP/RexYJqZi2huTIGrk aNj2iKgZB7lf7PtiehIs2Uy8zw9FYsecgOT6E8bzWY0QBtSr5e1zCXTEv2AqqmtdattYis8OcyOK OGLt+coIZQzSHBmW8inGIcUeonemsIChszRxUk9w0osBO/V1ZzyKtYsKosEHC/pOun/EOh4bF3tQ D1lp8iLAKFsAiLL1jlo5PAg8MgPdcJrA+/4BuWv2HesUeDLGq/A0zR+1f/GlDwwpw+6AyjmZVVLZ Eeic7OnZKtMuO1in2WKOq2FLFQfiVAioK+zxZUhkwQ== =4QLz -----END PGP SIGNATURE----- --------------9yO0uIg1vua9CFsYKNPhS6qZ-- From xen-devel-bounces@lists.xenproject.org Wed Apr 12 16:06:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 16:06:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520262.807657 (Exim 4.92) (envelope-from ) id 1pmcz2-0006qo-Ud; Wed, 12 Apr 2023 16:06:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520262.807657; Wed, 12 Apr 2023 16:06:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmcz2-0006qh-Rq; Wed, 12 Apr 2023 16:06:08 +0000 Received: by outflank-mailman (input) for mailman id 520262; Wed, 12 Apr 2023 16:06:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmcz1-0006qb-Ui for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 16:06:08 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ebeb381b-d94b-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 18:06:04 +0200 (CEST) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Apr 2023 12:06:00 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6578.namprd03.prod.outlook.com (2603:10b6:806:1c9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 16:05:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.036; Wed, 12 Apr 2023 16:05:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebeb381b-d94b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681315564; h=message-id:date:subject:to:references:cc:from: in-reply-to:content-transfer-encoding:mime-version; bh=3nmMro4PyJ8UWY3AplUrckhKfWxJt0OMYrLX6n8kRDo=; b=Tx6w8H4mMYs26HOioEDAqcJcCd3hl88QHxooP1h2k+b67LNJG+6Sn/CY PQNeo/ibKbl0BfR6SGV7ZDOPfSYU3rYSgvW78dGQ0J2nKQeIdfSXABvH/ s3D16jseiTDm+6cG5AdKVcxn9VzK5NGNtdBROSCOg8RbBV9uv0oyqMilr M=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 105166298 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KRh5CaCALf/TVhVW//7iw5YqxClBgxIJ4kV8jS/XYbTApGh00zEEz jAZXGvVP/6NY2ahL911O9i/9RsEvsTdnNJmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9B5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/9gpGF9J3 9YicDFKaz6HnsuTwrapRbw57igjBJGD0II3nFhFlGmcIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuuzK7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwHqlBthDRNVU8NY7mGSdllMrKyYORFiDhP/62m20CuJmf hl8Fi0G6PJaGFaQZsL5Vha7iGSNtBQdR5xUDoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRtv6eSUmm17aqPoHW5Pi19BW0fYS4JSyMV7t+lp5s85jrCQsliFuipicfyGhn7x zeXoG41gLB7sCIQ/6Cy/FSCjzfyoJHMF1Yx/l+OBjjj6R5lbom4YYDu8ULc8ftLMIeeSB+Go WQAnM+dqusJCPlhiRCwfQnEJ5nxj97tDdEWqQcH80UJn9h1x0OeQA== IronPort-HdrOrdr: A9a23:h6+ThqpjWLc3bcIlEMr7IDIaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-Talos-CUID: =?us-ascii?q?9a23=3A8JBYEGk4BDy3wn7E8cNWsDC39LjXOXjjkm7uJGW?= =?us-ascii?q?SMz5oD7i7TUa53aFggcU7zg=3D=3D?= X-Talos-MUID: 9a23:2NM0MwVljuEhOAHq/G70vT8yC/9L2Ly/C3gol9ZWmMPVBRUlbg== X-IronPort-AV: E=Sophos;i="5.98,339,1673931600"; d="scan'208";a="105166298" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQVBIj64aHWA7MEPIbA8jS4FvaFS+BznGRXbhDcku+/DwzRFvHMHkzpiOobnulYiKNc8tx6W5Q9m7VhFy/5ULZlNlANZAfVdjJlZ7DASsdRtc4PRdlniAiJeGB69HS2I/FTz2GzFtr2Vd9mA8OAdzWI/Gd8KBfEKB6Okfo4ZJtsHvxn3yfrSy2D4+3tRWNLho0WX4nQW6sMjT4WNCCXat79Z/VIJ9qU6AKKFpS1Dh4DvzPezwt7MyRWe7m4KBkqHXrfgpfrOWpznA0WeOJQZwopKB1cBDZJ+d4UDbRn21vZb+hjZZzGJ20zlL4fYCW571u1dEsg/anZbd1YdD5TSuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3nmMro4PyJ8UWY3AplUrckhKfWxJt0OMYrLX6n8kRDo=; b=ATc1Au19UECefjVk+BDkfDN+pjalYbO5VMu+L0vibi0JItc3VHwNKLfvQJQjWE0O7v0m5AuHoUrjLtUPOkDNsdk0kwIDv7quW21q8JgiBTUz2YoQUNrH1PPyAsw7keQ4tHuQnhyhWX+BplcHuMvuAM2xxWpaWkmhT/Gb6NNbf/vemc/vfrpthqJOjpf+mFTG5AOzBzUWwkt8h0ziQqu5qb2Hk7lIUAfei7hDo8CEw2v4TsMMegoJqTEloZZFZi3GLkcUkE8nAeUbfNeUuvuBHLAVmR2D7Iqsj11WQBC61MkxJf1klJ8WN6Rhq8FwJMAcqLe1Ikng4qWWcrkKuKHbVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3nmMro4PyJ8UWY3AplUrckhKfWxJt0OMYrLX6n8kRDo=; b=qTaXcxgyXbX3JMdS+juZaD+snZ58HHFoq3BnQOh8beBNP7yzq4wnPemARkWed+Nwj+V9N8t1kvIEYihhcqhswSzVA490FZLRfTIqiMytwpMC1+Mo5nsxrEIPehUxryeSVamww9peBjAjZ/xCwfCGiyN9N63bFAL2T9R7QRfURaw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> Date: Wed, 12 Apr 2023 17:05:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 Content-Language: en-GB To: zithro , xen-devel@lists.xenproject.org References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> Cc: Juergen Gross , Julien Grall , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= From: Andrew Cooper In-Reply-To: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6578:EE_ X-MS-Office365-Filtering-Correlation-Id: a70278b2-05f6-459b-83d4-08db3b6fcc82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zVUJ6KDQRHY+5j6bdl52xMAtIHGKxOs4qKOLRW1ZM/4RKhB7GE2A4KIvHAHM0vul66tXHZRwzl1zp+FR/1iuiYXRMvRSp3jarogX/gzlia9X/DdifoAtnnFXK87sYrYogi2O7d+mhZndIQPdgx5iuYxsA4akgqd/hdv5ggGu39bPyfYt4pjHrab+FKqItveXcfzv29EAw0oVSR8mWrKoLH88zBmIFw8S+D4xDLubIUo+ekaNkobnu9BnQGIU+ntIsu9B/XibEwe9mV/1rSm+ma3XB9wAH3qF0B/9N82vk+OdJCCaCeP5X9ieukPimD501k1DdO3m9L3qI4kXa+yvhQn31SNFmc+eQ6pR08qJKWs8nT7Ae/evTC5FKbiw9GGPqaOITSvcBI70F8Qdi9SAgDFB7heYhUojHTiSEb9CNnFEynUvDh0uPAcBoluz9EibEonCiWVfeHWsRwGlwADuCKfPrp77iVvSszC9sFB1h6wnGI37hmp0iRsD6dxiyAob10iDFMc3Jd9HklK06pv9lC2PWNCG/SVq4BZeLMGhk8Yg5/9JkkykRUeVD1KO0IQUnA+zVnUFI2tZZ4fSfChnkHnKdGpIgmXXv1oJR9isNXHdh0lKd3t3uYFpuuTzqzGKBekmW6crFIZrwGL7b7zHhTRqRrcWW0MDLCl7bzTsUdR+VNcGxMMOJwkYoESkHFJn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199021)(316002)(41300700001)(6486002)(6512007)(26005)(53546011)(6506007)(38100700002)(6666004)(86362001)(186003)(966005)(31696002)(2616005)(36756003)(66476007)(82960400001)(83380400001)(66556008)(66946007)(4326008)(54906003)(478600001)(8676002)(8936002)(5660300002)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TiswWDJjZ2tWNVNDbnlOdThBN0ZoWXdnemh4clo5SWc3QnhjSmpTbEprK05l?= =?utf-8?B?YVpyWnEvbFQrY0I3VHdQY3hBSng0eEl5NS8xVXlpVkZZMklrcktEU1c3Z0Nj?= =?utf-8?B?YktETnJDZnNSak5rZVhtN2toVEYzNkhoU1JEWmNiZW1yR2VZVGZyQ1QxdlUv?= =?utf-8?B?MmxUWEhlSkpqTnNxbVN1eFhCWXRHK3NRR1pueVQ1OFUrMzVuMmpLWllsOHhx?= =?utf-8?B?aGUxYU5uSVNPamNTSHVIcXQ0VDRkdEtIV05udWlmR0RRcVMxSzhIRTY4VTdJ?= =?utf-8?B?aXBPZzZHeTA0SWRmTW1WS1B4akp2WStHZW41c3d3a1RSOE1walBVTU5naXJa?= =?utf-8?B?YUZlajNOb0FlVU5MdmxxWkJZZXF5dGNvYTVFeUc0THRnYUdDekVUN2M1dDVh?= =?utf-8?B?Rm5KNjVKaGIvd1V6ZjNvaXpYNHllMkkzaURmWmUvRjdUNWJ2dU1GcXZJdVkz?= =?utf-8?B?bjlFMjdsNm1qRFJwd29LWXUrUmxmaVJWVkJVdXJqRzFwYkVWSERxeWNZMzBP?= =?utf-8?B?QUVJaFUxSkwvWGtPVTZzNVRuMjJTaitmYU1uMjhsTE5ySFVEbk1GcmY0SEli?= =?utf-8?B?eVRPaTZHNk9qRWVPREVCSU53MkR2VGhBZmRiTENJZkRNcFROdVlmcjd4QkhC?= =?utf-8?B?TGlkNE5wODBRTjJMSEpybXllUWtrdldha3U2LzAwbFpaaE9peDFwZXBWZ1Fm?= =?utf-8?B?RVJKWUZtc05jbWRmYUgrd0l2Q0M3Q1NNcmxHRVF6TDVDbk04OUVLekc3SDVY?= =?utf-8?B?L2xMMWlvQWZHU3pDb0ZHRFhsZTc3ODFycURTb29nYmQxa01WclhOM1doLzR1?= =?utf-8?B?TEdnRmxzbFFzNHU3MXdFVnE5Q24yTUV6SDJKaW0yZ3BTZTc2L3UwYlFWYy9F?= =?utf-8?B?QUpCU08zMnVzRlo1dkp2cWhMVnNXcjRyZEIyaXQvTTdJbFZ0U2Z5dkNURzBQ?= =?utf-8?B?MXZ1aW0rZGJqNVE4N2Jaa3VnL20zenJzak1GaExCN3I5UVZYMXRuWHVUK3Zl?= =?utf-8?B?dmRBQXZGVnBGcHQ4dWlNSytNYVlyUis0Tkh3SzhLRkt1bUlMWWUyM0JGQ3VV?= =?utf-8?B?TlFUMXhQdllmSVlGTXFNOEJOc2tFYW1FVE5kc2d6Vml4RVA4TGNhYy9TaGNn?= =?utf-8?B?Skpod3BLZVpid0NiMHFsZHFEbnA5ZjZrK0xOSnhLMEk4NHRIN21tM3g0ZU9J?= =?utf-8?B?QkQ0cjh6OFFXNlhsU21mUWZWQmtUbUc3OU8vS0Fvb0cwYWtJc3FlNWRzdy81?= =?utf-8?B?UXVwL2FoQ1AvTTIxcnQ2WS9vTjJUZ2dUQmN1eHoxL2YwTjFScFZtNmtMVzBv?= =?utf-8?B?RkhmNlBXeWczUm1ZQVEwbTNHd0dOTTFoRTdZWG1RYUF0WDIxTVVhMjkyZW5v?= =?utf-8?B?dWlkTmtXS3dHRXM2YTdhVGZpMkI0N2hhdHlyUndHVHFtQ3gwV0ZiR2lqV3FP?= =?utf-8?B?dkF0WTBPOTlRWExhcEhRem83YVJ3TDFaYlNBcStzZEYvaExTQk5Jc3hnU2d4?= =?utf-8?B?OVZyWXE3cllMSFhQQ3RNYzJSbDZGZEhnYkZ0emVRNmZLL3hvSDQvbmg4NU5D?= =?utf-8?B?Q0tscXYwWTEvNDJaUHBveVVWM3dsek1QRHVJRHEvejczSHBPLy9yQXNnYnpv?= =?utf-8?B?UWJSOHhkVzdhaEQwSGgvdFdrbkx1UVI2VFhybkpITzNOTGloWW92NnVlTzht?= =?utf-8?B?OUhHNmFnOWxDNk51ZCtxYzZwZ0JtV2s4cXpjRTRXK2d2ZDdjSVM4OEJ0T3Yx?= =?utf-8?B?ZmFFVDdFNWR1ZFhWWTNtWW5jYVZoOXpVNXpJcjFpaUw2d0FRcm5TMkxaZXcz?= =?utf-8?B?UldzMWFDLzRmaHFwL2U0NzB6ejVNandTRk5PQU5ab3lMdGpCckpSS2hoUHVH?= =?utf-8?B?QlRYUjBxU1NCT2pmaHVlNnFMRSttdFVzUHcxVlRxOXpkbGFXOFVqU2JPdVBq?= =?utf-8?B?M0NlUUZzaGNZS1ptMWtyeCtvUjdCVEFZNmVLUlVrZEtNZWpPbko0SzRQUUV5?= =?utf-8?B?L2RCRjVmVVQ1bUZYV1FNbVI1MEw4b0dIeEdsdENyZHdTdnBGWmVKVUN5b0VG?= =?utf-8?B?bG5ZYkE1eUYrV3c3cm0vdDNZSG9ZakY4VDJlejFLRW0rQTlTenpia2tvSHpt?= =?utf-8?B?NTk3MWpxaEFzUlpjdmxobmFIaVpQdUtHbGYxajZqUWd4MVZrNklod1E2N1Nt?= =?utf-8?B?OVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: RnBonBBgzMDqYMRnYvZ0WQIkI/TQKDNvUc7oYaNSWmaSZOBVjFaywTSkK+qunOHDqGpN0YDmTZn3sb9k/xytO1uBeZNREcBh7liJPsZyydLZAW3KRqR/nGLM1lrEjlmtiu4TT7lbuaCv4Ija1/JBeXqGNKSfXb9wXs1Wj2RtANovENPlJi46p/X8yNbaNYGb9Y26cokWKP2aHa3aNBihLZwDSV9zXtD5eMQaVWssRu0c7GoBEtzeOrvgPN80cZHE/VPjQPTjzIez1guzim6gg5sW/xYn66dUsJQCoOLi5gF1UTEfJ39NCli21KyQwJwJm17gpk+K1u4KJAzkwnnChTdtnVtgDZsai2WoMbmjvwbixITfwyPd+51cmwcRlaAiMx/x8mjOj7MNVrHFOjC332U2vGOqso3kMyX7yZ7xACOG/HrsBJNa4xUMJz3k3O9MKnWtZIksADpwpx0lPWEUQEdlT/mKKJ3XDytW/6aH0UEWDlzUb8WDmegM6DbFuvCCXZdcieRieD82twBFIQaQEStyh8YnjUrfzg2x6XO1QBQqihZ9WdNLzuW1XKTGFm17dQuyVHd4netlKK3L1n89ZB7TWFgA+K4nL32pUti4kppShhDxwD11KFXIun4olz2GGrSU7uTvEvjGfNPYlMEADjiifycl0A2LJqcBqhtQTUrWFSfZuCAA4xf1Fa96N0/C3SMqSJ1atVfL1TGJJ0hPGxjmEU4CV2+9m9l7t78toq7P78DyHpnkWZyiiqo8TYf+1OWppgWULQEPgswj/f8rZopW1JwrggIn1DABcKP6giFx0/+zmwjbpWpH1dPN1d75eyBYGDnf9Ff77tB9A4iQGaW3coFBSMtH8ajl5/6ZPLFwiGuCWgNCrKA+LHeFonGD X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a70278b2-05f6-459b-83d4-08db3b6fcc82 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 16:05:56.9254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MYRqNDyvry0ajFYRGGJkiNGd1fBfyDKInasa2Ty5eiEZOLKM4Vd/Cnm/RVmYmxS6GKyuK8VAZCsQAe0OidUV6lFrZBw9KTf7EyQ0pOxGL88= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6578 On 12/04/2023 4:48 pm, zithro wrote: > Hi all, > > this is what I have in "xenstored-access.log" in dom0 : > > [20230411T23:48:27.917Z]  D5         write     control/feature-balloon 1 > [20230411T23:48:27.917Z]  D5         error     EACCES > [20230411T23:48:27.923Z]  D5         write     data/updated Wed Apr 12 > 01:48:27 CEST 2023 > > It happens once each minute, on two different hosts, both amd64. > (both hosts using the same config, only the hardware differs). > > I tried looking up for a similar bug, but didn't find one. > I apologize in advance if this error is known, and if this is not the > place to report this ! > > ----------------------- > Technical infos > ----------------------- > dom0s: > > Debian stable, kernel 5.10.0-21-amd64 > Xen 4.14.5 > xl.conf has : autoballoon="0" > GRUB_CMDLINE_XEN="dom0_mem=2048M,max:2048M dom0_max_vcpus=4 > dom0_vcpus_pin loglvl=all guest_loglvl=all ucode=scan iommu=verbose" > Running "xenstore-ls -f -p | grep balloon" returns no result > ----------------------- > domUs (D5 in above logs): > > HVM TrueNAS Core, based on FreeBSD 13.1-RELEASE-p7 > (it happened also on previous FreeBSD realeases, but don't remember when > it started, logs have been filled and rotated). > In cfg files, using either the same value for "memory" and "maxmem" or > only setting "memory" give the same results. > > What's strange is that I have xen* commands in FreeNAS : > > xen-detect        xenstore-control  xenstore-ls       xenstore-watch > xenstore          xenstore-exists   xenstore-read     xenstore-write > xenstore-chmod    xenstore-list     xenstore-rm > > root@truenas[~]# xenstore-ls > xenstore-ls: xs_directory (/): Permission denied > > root@truenas[~]# ps aux > root   [...]     0:36.98 [xenwatch] > root   [...]     0:01.01 [xenstore_rcv] > root   [...]     0:00.00 [balloon] > root   [...]     0:01.74 /bin/sh /usr/local/sbin/xe-daemon -p > /var/run/xe-daemon.pid > [...] > > The xe-daemon looks strange also, I don't use XenServer/XCP-ng, only > "raw" Xen. > And this script which hand > > I also use PFsense domUs (based on FreeBSD), but they don't exhibit > this behaviour (ie. no xenstore access error in dom0, no xen* > commands in domU). > > So is this a problem with TrueNAS rather than with Xen ? > If so I apologize for wasting your time. > > Thanks, have a nice day ! > (and as it's my first post here: thx for Xen, it rocks) Hello, (Leaving the full report intact so CC'd people can see it whole) Yes, it is TrueNAS trying to re-write that file every minute.  It appears that TrueNAS has inherited (from debian?) a rather old version of https://github.com/xenserver/xe-guest-utilities/ https://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html doesn't list feature-balloon as a permitted feature node. But, I suspect that it used to be the case that guests could write arbitrary feature nodes, and I suspect we tightened the permissions in a security fix to reduce worst-case memory usage of xenstored. I suspect the best (/least bad) thing to do here is formally introduce feature-ballon as a permitted node, and have the toolstack initialise it to "" like we do with all other nodes, after which TrueNAS ought to be able to set it successfully and not touch it a second time. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Apr 12 16:41:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 16:41:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520271.807666 (Exim 4.92) (envelope-from ) id 1pmdXa-0002gG-LA; Wed, 12 Apr 2023 16:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520271.807666; Wed, 12 Apr 2023 16:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmdXa-0002g9-IO; Wed, 12 Apr 2023 16:41:50 +0000 Received: by outflank-mailman (input) for mailman id 520271; Wed, 12 Apr 2023 16:41:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmdXY-0002g3-Ez for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 16:41:48 +0000 Received: from mail136-25.atl41.mandrillapp.com (mail136-25.atl41.mandrillapp.com [198.2.136.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e91b97a0-d950-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 18:41:45 +0200 (CEST) Received: from pmta11.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail136-25.atl41.mandrillapp.com (Mailchimp) with ESMTP id 4PxT4m3534z35hjR4 for ; Wed, 12 Apr 2023 16:41:44 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id cc6b503e5fa0409fa2eeb092e8a9f553; Wed, 12 Apr 2023 16:41:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e91b97a0-d950-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1681317704; x=1681375304; i=yann.dirson@vates.fr; bh=3JTXjkmoPGh0ttTfkEsTFYXtthTwOcD8aDvT7t9kOso=; h=From:Subject:Message-Id:To:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=XpZktOdtZSTN6L3Y0D/3a+svDlbMllPmTEsPvZFup8oOh6+9XU68GfoG1IDdPLPHg MquK1nTt0TufVg0a/6BoL8aWG+5Tl3vgAyXsUqGim91DGrl1lpsK43g7Q99ihw69d8 G+u25KvAQJDDHj4GPPlhfACpEzeFjfnoWa3j4ny8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1681317704; h=From : Subject : Message-Id : To : References : In-Reply-To : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=3JTXjkmoPGh0ttTfkEsTFYXtthTwOcD8aDvT7t9kOso=; b=aAz8xn02E6Lzb1c19IB1SBKRJXAlqRuDDXzimIymw9OUJfS1is8tYMDDzKAUuWuy7duzu4 ODLipWXY9o4F0LWhTeIn7dIJJg5R8DVhXJEqjuEERKUZbF7JrIgq7g+CQl68WlkmrBsyYmlx T+9ikeP0tdY9gSn7ANV/wmfHZwN/4= From: Yann Dirson Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: aebc14ef-2387-424b-ab1b-4782f58676dc X-Bm-Transport-Timestamp: 1681317702247 Message-Id: <678df1ff-df18-b063-eda3-2a1aed6d40f8@vates.fr> To: xen-devel@lists.xenproject.org References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> In-Reply-To: <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> X-Native-Encoded: 0 X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.cc6b503e5fa0409fa2eeb092e8a9f553 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230412:md Date: Wed, 12 Apr 2023 16:41:44 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi all, On 4/12/23 18:05, Andrew Cooper wrote: > On 12/04/2023 4:48 pm, zithro wrote: >> Hi all, >> >> this is what I have in "xenstored-access.log" in dom0 : >> >> [20230411T23:48:27.917Z]=C2=A0 D5=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 write=C2=A0=C2=A0=C2=A0=C2=A0 control/feature-balloon 1 >> [20230411T23:48:27.917Z]=C2=A0 D5=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 error=C2=A0=C2=A0=C2=A0=C2=A0 EACCES >> [20230411T23:48:27.923Z]=C2=A0 D5=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 write=C2=A0=C2=A0=C2=A0=C2=A0 data/updated Wed Apr 12 >> 01:48:27 CEST 2023 >> >> It happens once each minute, on two different hosts, both amd64. >> (both hosts using the same config, only the hardware differs). >> >> I tried looking up for a similar bug, but didn't find one. >> I apologize in advance if this error is known, and if this is not the >> place to report this ! >> >> ----------------------- >> Technical infos >> ----------------------- >> dom0s: >> >> Debian stable, kernel 5.10.0-21-amd64 >> Xen 4.14.5 >> xl.conf has : autoballoon=3D"0" >> GRUB_CMDLINE_XEN=3D"dom0_mem=3D2048M,max:2048M dom0_max_vcpus=3D4 >> dom0_vcpus_pin loglvl=3Dall guest_loglvl=3Dall ucode=3Dscan iommu=3Dverb= ose" >> Running "xenstore-ls -f -p | grep balloon" returns no result >> ----------------------- >> domUs (D5 in above logs): >> >> HVM TrueNAS Core, based on FreeBSD 13.1-RELEASE-p7 >> (it happened also on previous FreeBSD realeases, but don't remember when >> it started, logs have been filled and rotated). >> In cfg files, using either the same value for "memory" and "maxmem" or >> only setting "memory" give the same results. >> >> What's strange is that I have xen* commands in FreeNAS : >> >> xen-detect=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xenstore-control=C2= =A0 xenstore-ls=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xenstore-watch >> xenstore=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xenstore-= exists=C2=A0=C2=A0 xenstore-read=C2=A0=C2=A0=C2=A0=C2=A0 xenstore-write >> xenstore-chmod=C2=A0=C2=A0=C2=A0 xenstore-list=C2=A0=C2=A0=C2=A0=C2=A0 x= enstore-rm >> >> root@truenas[~]# xenstore-ls >> xenstore-ls: xs_directory (/): Permission denied >> >> root@truenas[~]# ps aux >> root=C2=A0=C2=A0 [...]=C2=A0=C2=A0=C2=A0=C2=A0 0:36.98 [xenwatch] >> root=C2=A0=C2=A0 [...]=C2=A0=C2=A0=C2=A0=C2=A0 0:01.01 [xenstore_rcv] >> root=C2=A0=C2=A0 [...]=C2=A0=C2=A0=C2=A0=C2=A0 0:00.00 [balloon] >> root=C2=A0=C2=A0 [...]=C2=A0=C2=A0=C2=A0=C2=A0 0:01.74 /bin/sh /usr/loca= l/sbin/xe-daemon -p >> /var/run/xe-daemon.pid >> [...] >> >> The xe-daemon looks strange also, I don't use XenServer/XCP-ng, only >> "raw" Xen. >> And this script which hand >> >> I also use PFsense domUs (based on FreeBSD), but they don't exhibit >> this behaviour (ie. no xenstore access error in dom0, no xen* >> commands in domU). >> >> So is this a problem with TrueNAS rather than with Xen ? >> If so I apologize for wasting your time. >> >> Thanks, have a nice day ! >> (and as it's my first post here: thx for Xen, it rocks) > Hello, > > (Leaving the full report intact so CC'd people can see it whole) > > Yes, it is TrueNAS trying to re-write that file every minute.=C2=A0 It > appears that TrueNAS has inherited (from debian?) a rather old version > of https://github.com/xenserver/xe-guest-utilities/ TrueNAS being FreeBSD-based probably inherits this from the sysutils/xe-guest-utilities port, which installs a fork of the shell version which predates this golang repository. > https://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html doesn't > list feature-balloon as a permitted feature node. > > But, I suspect that it used to be the case that guests could write > arbitrary feature nodes, and I suspect we tightened the permissions in a > security fix to reduce worst-case memory usage of xenstored. > > I suspect the best (/least bad) thing to do here is formally introduce > feature-ballon as a permitted node, and have the toolstack initialise it > to "" like we do with all other nodes, after which TrueNAS ought to be > able to set it successfully and not touch it a second time. Is there anything besides XAPI using this node, or the other data published by xe-daemon? Maybe the original issue is just that there is no reason to have xe-guest-utilities installed in this setup? Best regards, -- Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.tech | xcp-ng.org | xen-orchestra.com Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com From xen-devel-bounces@lists.xenproject.org Wed Apr 12 17:09:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 17:09:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520276.807677 (Exim 4.92) (envelope-from ) id 1pmdxe-0005F7-Vt; Wed, 12 Apr 2023 17:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520276.807677; Wed, 12 Apr 2023 17:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmdxe-0005F0-Sg; Wed, 12 Apr 2023 17:08:46 +0000 Received: by outflank-mailman (input) for mailman id 520276; Wed, 12 Apr 2023 17:08:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmdxd-0005Eu-28 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 17:08:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id abf1074f-d954-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 19:08:42 +0200 (CEST) Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Apr 2023 13:08:38 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6239.namprd03.prod.outlook.com (2603:10b6:a03:3ad::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 17:08:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.036; Wed, 12 Apr 2023 17:08:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abf1074f-d954-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681319321; h=message-id:date:to:from:subject:cc: content-transfer-encoding:mime-version; bh=BtD/8AvZNPytXou2Hlw9qZJmjNoCMdu898mKJ+GnOoA=; b=KzH09fwdFjllksIr1WXREIKG9Izj/LMjYX3vMcVBQ7f75kXFZ9Kmgkkp sU38NdPKeuLhGVGzYsro/WcATGe2E/3j+IVSwU7BHdv76X5kJVTOe4IxG rnRmwRNe1oAQ181fsT4dQvZyf0eQAkpBWSY4JMDwImGz7u5sIAgimUmAl 0=; X-IronPort-RemoteIP: 104.47.55.101 X-IronPort-MID: 105298112 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:CGDWOqo5VhRwq+ZC2sQ4OzCsrv9eBmKwZBIvgKrLsJaIsI4StFCzt garIBnVa/bbMWHwcohyPI+zo0ID7cLUzYRhTFFo+yszEXhH9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weCziNNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACoTQy2jrv+E+7b4aMlsms94L8PUFZxK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKMEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqMw0Q3KnzZ75Bs+SH27/dewtWSHRYh7d 09N6AEnlpE2+xn+JjX6d1jiyJKehTYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ lSOmtboGSBiqqa9WX+b7q2Trz65JW4SN2BqTS0OQBYB4tLjiJoulR+JRdFmeIaulcH8Ezz0x zGMrQA9iq8VgMpN0L+0lXjigjmsr5yPaRQn6wH/V3igqAh+YeaNbIWy5V/Wxf1JNoqeQx+Ku 31ss82X9uUHF5yOvC2LXuQWHbut6uqFMTvTmlpmFd8q8DHF016ue5pBpg53IkhBO9wBPzTuZ SfuVRh54ZZSOD6vcvVxaofoU8Ayl/G4TJLiS+zeacdIbt5pbgib8SpyZEmWmWfwjEwrlqJ5M pCeGSqxMUsn5W1c5GLeb48gPXUDnEjSGUu7qUjH8ima IronPort-HdrOrdr: A9a23:D8EMs62nvJHiy5Op3lPE8QqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP+VUssQ4b6LK90cW7L080lqQY3WByB9eftWDd0QOVxepZgrcKrQeAJ8T2zJ856Z td X-Talos-CUID: 9a23:9065JGO0bIj+j+5DQjdKyW49B/Iedj7/7HfMKBS7A1lAV+jA X-Talos-MUID: 9a23:8db73QZIKI0CSeBTqhns2B9rC+1R/f6KVENUg74PgPCAOnkl X-IronPort-AV: E=Sophos;i="5.98,339,1673931600"; d="scan'208";a="105298112" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dkHHcB9HciYGK9Ja1WmMAQKJ49R5T4r3mlZVzLOisUg8N2xjdnzg6CE7bkfyNylKtvB8q4GEP6gjF/K1YrAyECJijHRa29azA8e2OD3B9WsTcIPdehR3PArVkMRpHq72F9CEhjZFzeIGMYs7jwLked8hCrg1hWCfkECLo4VRCPulyl14qDCcviB32N6zuMilydG8Xs3R53PQoKNMvkbvCF40YjH+uP+i/YBaagFkyCGcZZiJtkT/khV4ta6uDYnKfEtZHsN6f0Vh7vBPjyPSbdm4XRF6WjgXio1TWcTPuqz0TYPyJsYoFWWqLT8LLx9Ss7CY9pQiTWjiXZCCTeH5fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BtD/8AvZNPytXou2Hlw9qZJmjNoCMdu898mKJ+GnOoA=; b=gwsoK/Hkm1P3QvpRpAZKKQukUTj0icu/Ag3XReUA+lB4ISC5gp4wKlKr77xTeDm5Gn79s2bnaNIyXJZ+/5a2MUo862aQplFCuD0NvHnE9vavHa8tq7zf1yxodrkILNRpQOlzvpns2PC23Zajc3BCwtV11HKgvVUoXjiHu2i0j4erXbiuiep+RBdaH2qCGj+AKpx8wgqC+jnZ+Er8MVg1+1vuDT1kZ6hwy5tjQ0KER50hFDI6eXSqkr6VrMtpJGymMjyBK0sMpg2xIo8zZM4wwwV0HWSgaWjfbLsZD+8sUtOJiUs+hZTPy+IqKh+AKO9Pq/jOViwPHnYpYKsf0MsNDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BtD/8AvZNPytXou2Hlw9qZJmjNoCMdu898mKJ+GnOoA=; b=pBFZd6hfvGwQIqxyqWwOU15KmmltVTB2Px3yUBrcEz3hRw6AMKfkMsrEpXdrFRFdO3c9UVS2bHkIi7DG6ZQ3kiOh6XG+Xc2lMWwxf1w2PWIS8s5KwZu4HvXRLdVXOzFaT2vXzgs0u7UXImh/bMGMXgnpAUFXKabCQXH6ksdDQdI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <193206bf-76a0-818d-8fa8-1886a15ad5e5@citrix.com> Date: Wed, 12 Apr 2023 18:08:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-GB To: xen-devel From: Andrew Cooper Subject: Gitlab status on older branches (Inc some 4.18 blockers) Cc: "committers@xenproject.org" , Jan Beulich , Anthony PERARD , Stefano Stabellini , Michal Orzel , Doug Goldstein , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Henry Wang Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0358.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6239:EE_ X-MS-Office365-Filtering-Correlation-Id: 698c16ca-3baf-43be-67f7-08db3b788db4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mq0gkoaNvjh047BUcJRWhlJrcD8s5NUTYuo5xtOkhI+DdRl5yQ9Np1ciGfDfTpdPXI6Xkp1zny1CPpT9pB806iP6jxdIgwyHfdsyOtdMWuqIVNAePadjvW6xOZhJvfsroxQV3sN8SSXhcEMGjRHr4DaehTlkr8lky6KfQ4p4N1quZgkp//ls/7P4RS4NdWa3a0gqG0f1nIv8cbyylswF6wfhjtKjUMJTDbkd1cIxrKBHED+T/MJVrrXqtXeDKzTbicE8uwqrT32KQJEgzlQUSkipF2b33FsZ6JPYHoIVZMEIVx1HbrL4r6KaANYDlXaPd9M1JhSHonGarFVkecboYchkBk+Eo1RUNT0sJCXntvVq5+3oGEBrFMafItumbO6tMYneOVBAEmnu+1deKR6Mu0F9vdS63rYTfC7GRskhNXuXfmsedviL6nRXVii0MF3JN/Y8zmMkYC5zFKGy2q3FDZ+wmtAJ/VUnYHJ7TjTOGZVq9icfbyA+EZ8c4ox4Mz1pzmEF2wzgmHcIR7BDjTE2E/lMq9In2n3VTQDVz045tyOTavKfmFzdiPg3o1pe8jChgVDWRklMCEN0JJvuKz6CRTIfZh0ZLYG48HdV6o5rpFD6iTMRsc9JiP1vsKNd7Bnncl6PdU0B8JlYVznrv4y9UjzwqoSY0guBEb/avxd6O6Vv0imb6BQ5UKaN9nRRGaCV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199021)(83380400001)(2616005)(966005)(6666004)(6486002)(26005)(186003)(6506007)(54906003)(478600001)(6512007)(2906002)(36756003)(5660300002)(38100700002)(6916009)(4326008)(82960400001)(41300700001)(66556008)(66946007)(8936002)(8676002)(316002)(86362001)(66476007)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXIreUhuQ3dGdFlNWkZnWnBhVURKSTF3bm9UbHgvRTJUQXQ5VzV3UHh5YXh2?= =?utf-8?B?VkdFcGhIaWd1U05remtFV0NKVDVlZzFPYTMzdzYvSzJmaXZYdzdTbUVQVVBR?= =?utf-8?B?QkZ3VGxBMHNPMThvcU1sYmloWTZwQUNFWnIvcDZNbmNGWUYyZGxzOHdISlN6?= =?utf-8?B?QkRzditUTVg5WVk2OExOV1A1dUZQTmxmdjRNZE0rd2V5WXNxOGZNc25CWnlN?= =?utf-8?B?SlYxcVZTV1lwVTMyMDFFeWZhem1HYWZZQnI0SzFhd0VIaGdsSGI4eWxTS3o4?= =?utf-8?B?L2NPTy8zaGJWbEYxUnNBZlAxcXVkSmVmckZaeEdXNER6M2RVakxBN0dkaktw?= =?utf-8?B?Y1phU1F3NC9Kd2lzNDAwT05BTTN4TjF2OW1IUHpDam9tb3hVdlZEZ3AxemIz?= =?utf-8?B?WCt2Q00vV3Bhc0lCc2xnLzJhdWtmTWtCanNQVzQ3YUZmZ3BoSGFBRnlNa2l1?= =?utf-8?B?SkY2cUFEdGVscG1Ydk51V1VUY3hXQmZRRDN2ZDhQc3U2eFVsY0FPcitrTTEv?= =?utf-8?B?R0F1eUpQcnh4dWhyM0ppZ2ZvckE2OXpSWjFId0F1NHgxVXMxQlZESVBDL2x4?= =?utf-8?B?ejJucU5JZWhIOFpWY2R6ZTVDWXpDM2R0TThjb1FJYVdJSjB1cjdJdStvMEtp?= =?utf-8?B?VFpJcGVyS0JmNlErUDRRdDl1STJNM2lVcmsvdG9ZcS92TmU3ZWZCVk9wNmhQ?= =?utf-8?B?ZEtzKzYrL0c0RkRmc0tqZjc2RWZabjVCWWduSGlsN2twVXNsWFVseUJkVnpi?= =?utf-8?B?MmxzTk1oOG9uL1hZdlVBWTlTUmJGS0Roc2xXYnhHRWU2UWFVZi8wdFpYT0Rl?= =?utf-8?B?TnZ2NDhSeW9VSVRHZndCM2hUa1NCeGNGS1N5SEhTQ0xLajZUNHRLY3o2Ymk3?= =?utf-8?B?Y2x4c2ZzY0dhaFNwaXJaWHBxMk9uR2F5emd6dVBnVy9KWjRxWDZMNVpmbjRS?= =?utf-8?B?bE9IUHhUS3MyVW5heUpMcDVvS0NxRTNHLy9GYVlVT292SStRQmJHRlF3bG9O?= =?utf-8?B?eWltcFd3MzZsY1NCV1dMMGw1MnZrUUhKZlZnbkp3M0N3QitlNkllVVN4NFdY?= =?utf-8?B?S3FBc1FHaFlyVEVaMnE1N0lFQTlGK21USlM1WDBTQ09wYWRhZXI2cUFjaVhk?= =?utf-8?B?SHIzRzlvVStkblk2eWFNb0QwQVc5YlByTHR3L1YrZDR4NFJ0eTNVUXdpeHZF?= =?utf-8?B?amhXaDh4Z1FmcFE2N3owR1J2cE4rMkw5blhaM3pqby8wSHdFamQ3ZjNISHp6?= =?utf-8?B?WjRtZlBITjZOeVRZVXVQU204eFdFcHNTSDFIRXhNeFl4TCtQQzZFREMyb1dD?= =?utf-8?B?a2ZqSm4wOXpLSllaWlVBVXdVcDJiUWN5aWUyYXNZenJGU3Ftd09rSjRmclpq?= =?utf-8?B?WTEzQUFITmpjQURTM0lwekxXNTRjcmNvdm9GemVDRFBwQjQ5TW8xMXdJY0NB?= =?utf-8?B?cHVhZW94MTNFUENrdE9kUkRNWmZrTEdDelVDaU1va2JWQmo1enR0cjIvUFpM?= =?utf-8?B?UmZiWWdtSXhCbDU5dFdDSXdNdnVoSG1uQ2lQVWUvQXNtTHRQL096ZVgwd3VF?= =?utf-8?B?K0lqUXpGUjNHdU1kbTMrT3V3QlNQdnJBdFJXaTgrdHVHdWJjY1IvNmVxWlJi?= =?utf-8?B?YnFGeWZVbDczQ3hEalo0N3NmaFllSldsaVh6VXEzZUhTcm1OOVFISE9vY0Ev?= =?utf-8?B?MXpOQ2hoMXBKZlc1M3lGb3oxc2lSWUluUEMwcXZmRGpuMFdHWEMvZ080REZz?= =?utf-8?B?UlZwM0FpYkhNNW0rcVJBZFJUTkNERFZGYkd1SmhXYVJ1Mjk2Vk5MMUdjclRy?= =?utf-8?B?M1hQd3B0czJ6Q21xZEZsYnpUck04czJXdlh4SEZwM3NIT3BYdGhRdUlqQ3Vx?= =?utf-8?B?dTJFck1oTVpEQUZlaE8rcE5qbVB5SGNzUnRTMWVmSW5Na1ZYV3VQSENHdTlU?= =?utf-8?B?bm5QcWFtU2FoVGRJZmo3dnRKMDF5bWFMd210bTJVR2VpRWpSdzlJM3pVb2Fv?= =?utf-8?B?Uk5XcDU2MnRKNExDUWxDdDI2dVdpUm4yRjllMVV0bjJIKytzY0xKNE54Y2Jo?= =?utf-8?B?Ti9Od1h0bFRNdndyZUxyRVlPK2VWUElaMG9HdUhsc2lKc2ROK1NNQVorVmFi?= =?utf-8?B?Vk5PWlZMMlVxV0YyM1pTYlBtS20zWVR5N1BrajVhdE9qYzhVQVdpM2doOEZk?= =?utf-8?B?cEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?QWIyWDBzU3lBdFphR2RYd0NPK3haU2JtaVJyMGxhK3hRREN3TFR2M1YrNTBL?= =?utf-8?B?QmRRVy9wMnlkcmNUQmtKdVd4MTBhc2pYdHkyMXFERXVJNTVmTllidDJzUWpz?= =?utf-8?B?SmhLQnJHU0VLYlpTUjVHUE5GS2d2dG1XVnlRU2V3VStDWlMwL05KT0N0VVM3?= =?utf-8?B?dWhEQVBSMTZadllNMFpJeVgySDRwUlllajg5WmZQQ2FFTWRUNzJDeW1sTVFR?= =?utf-8?B?aFJrZndZRjNYb21yanZjRkJQK1lwNGJEaHpyZm5KWnNOektHSVh2NlVtbU1p?= =?utf-8?B?MklydXR1ZGhSR21idGg2MEx1MllobGJLNFoxVjd2NkcwUUJJNC9GM0wwY1Vv?= =?utf-8?B?K290ZTVpVkMwenF4bm1oZ2F0VUtZL1RNRlQ1M3dEamxIWlFMaGw0dUcyM2tr?= =?utf-8?B?ZGpFbzhEdGxHRnQwVEhrVGVjMjNQM09DWlB4Z281VnR4ZFVHSjhmRzlTQ2Jy?= =?utf-8?B?eFh3Y3NPb0NtNTBKY2FOT3k0eUM3WVdGR0srb0RLVnhBK1hoQVlScndJa1VG?= =?utf-8?B?QXFGTDRibG9DcFZ6UlJWWDNja3BZbkhLTUc1aTNEUXJDR0tEVEtwYzhaaHdN?= =?utf-8?B?NnRmcDVmQmdVSjcwamI5cDZLeE5mNSs1UnJncnhESC96d0pQNEZWWWVXSEhP?= =?utf-8?B?bkdDbkZtdmF3N2VxWjdIMjQzNlYyRENiS2taYTlIdW92ajdBMThpUWgvZVk2?= =?utf-8?B?K3pYcHFYMW1yOElrTGk0anNGcnp1NlZGWGZVTE5ha3RLZisyZ1JyRFUxaDNG?= =?utf-8?B?bEpra29GSW5CV0lBOCs5MFNvVDRoM0J1TTI1OGZDTmhvRDd1aytoTVg4YkFE?= =?utf-8?B?MmxxTTZEL3BJbjRtcU44UWFJbEdQcWcyRUF0dzlyTTBadkJZOEx0UnBJaktS?= =?utf-8?B?NHkrZXBuL2lLQ1NkZ1o5bXJET2RzWkZxblJoOGNWTWVvMnBYS2Z2QlRuSVZv?= =?utf-8?B?V2F1SVl3bjgvK2Zkdi80SGZFRjFiOCtnbE95aVRuTzBSakd3bk9KU0FVWERo?= =?utf-8?B?YW5HWllVbkdoeHBITmt4ampyQ3VRUm1yR1FXR2NzUkh6VlJjeVJpa0szR0FY?= =?utf-8?B?b0VYdm54WkdBUGVEUDhZTjlMTmNXUFFCWXVFTXFxNjA0RzhGQk9zbkYyUGtv?= =?utf-8?B?MHFJc2dvNSs1Z3BpcjVvUVpCYlV0ZVZBMFI1ckZpRnB5aFpqZ3R2L1hWMTBP?= =?utf-8?B?c0xudnQ1NHhEbHJKVnYvbks0cE9NN0pIVGdDNU1ZTmNNbHJNdWpOZE1JQmhE?= =?utf-8?B?QzJ5UUM2T0drUWEzVk83R0dmTVBYU0xoQ1JBclpQakhOS3RNU3dqYndoRDd0?= =?utf-8?Q?rrPjzQPchcs+I=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 698c16ca-3baf-43be-67f7-08db3b788db4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 17:08:36.5468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i9wJyVSZepS+jCuNQ0XrPakP9ydXw1kfDlmqTTlKajww3N8unaEalSxXHerH7VXiGCcIykknTeyl9Ge+F/io/TwzwB91g5aTYHuAPJuZBCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6239 Hello, I've done various backports to staging-4.14 and later trying to improve the state of Gitlab testing. The good news is that 4.16 and 4.17 now pass.  The bad news is that there are still bugs which need fixing, but lets start with the older branches. Also, I was forced to backport an update to SeaBIOS 1.16 to all branches in order to fix compile failures in build environments we supported at the time of each of these releases.  I honestly don't know what we were failing to do testing wise back then, but whatever we missed ought to have been release blockers. 4.15: https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/834460832 Individual failure instances: 1) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232265 This is a -Werror=array-bounds failure in HVMLoader but the same job/container works in 4.16 and newer, and the underlying code is the same.  There must be some change in the build environment, but I haven't worked out what yet. 2) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232266 This is a -Werror=array-bounds in iPXE.  Probably needs an update like SeaBIOS too. 3) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232290 This is a Qemu upstream failure which I do vaguely recall.  Bit it also means that Xen 4.15 had a dead-on-arrival version of qemu which call into question a number of our normal release activities.  Probably the least-bad option is to backport the one fix relevant to this, because changing the version of qemu in the security-only trees is far riskier than changing one of the in-guest ROMs. 4) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232334 I have no idea what's going on here.  If nothing else, we're failing to collect all the relevant log files from a build and that probably wants fixing and backporting. 5) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232324 This isn't so much about the failure, as the fact that the OpenSUSE Leap tests (which were replaced with tumbleweed in newer versions of Xen) probably want the same doing to them.  And being marked as non-blocking.  This is a failure somewhere in the middle of qemu. But, on top of all of ^, I discovered that we have a majority of tests being debian/unstable which, when we refreshed to fix the HTTPS issue, ended up retrofitting a newer-than-at-release-time build environment to the old trees. This has come up previously, and not addressed, so I'm now declaring it a blocker for 4.18.  Only tests against a fixed disto version can be blocking; those against an unstable distro must be non-blocking, and most of the currently unstable things should be transformed into their stable alternative.  For backports, we want to retrofit what debian/unstable was at the time of release, rather than what it currently is. Furthermore, the fixed distros we currently test in staging are old bordering on obsolete.  Which is not a healthy position to be in as far as the 4.18 release goes. 4.14: https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/834461234 6) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097236330 This is the only 4.14 failure I can see which isn't a duplicate of a 4.15 failure, but it is an OpenSUSE leap failure in qemu so perhaps related to #5 As a general note, we still have too much testing (and/or insufficient testing resource).  It's very painful waiting 2h for each branch to complete.  I'm very tempted to trim things down further on staging and backport the results. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Apr 12 17:52:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 17:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520280.807686 (Exim 4.92) (envelope-from ) id 1pmedG-0001z6-5j; Wed, 12 Apr 2023 17:51:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520280.807686; Wed, 12 Apr 2023 17:51:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmedG-0001yz-23; Wed, 12 Apr 2023 17:51:46 +0000 Received: by outflank-mailman (input) for mailman id 520280; Wed, 12 Apr 2023 17:51:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmedF-0001yp-0U; Wed, 12 Apr 2023 17:51:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmedE-0008CX-TR; Wed, 12 Apr 2023 17:51:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmedE-0000C4-Bt; Wed, 12 Apr 2023 17:51:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmedE-0003Cc-BR; Wed, 12 Apr 2023 17:51:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=syCZeO6YXALore4fuin+JnwNvBu5+zRRo2BqRduIp9Y=; b=pT84bADO1WxocjDVreMrLEapLb O++BScFPZhaxHDPBoGoZPlr1acXv/bk12HkcTIGGLjZnWSUAfD0QY7TcGn50pSNA7ErHC/cG04hGk GwXf9s4q4gnNDxbSxGJzY76uNYGV2AykEatAAoSjugm587ZpQXvqvTEtv/aUdKKgXxMs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180211: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f X-Osstest-Versions-That: xen=ddaf7bb0cfd27369252de52e4b03410c4065bad2 From: osstest service owner Date: Wed, 12 Apr 2023 17:51:44 +0000 flight 180211 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180211/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 7 xen-install fail in 180206 pass in 180211 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 180206 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 180206 like 180187 test-amd64-i386-xl-xsm 7 xen-install fail in 180206 like 180200 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180200 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180200 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180200 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180200 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180200 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180200 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f baseline version: xen ddaf7bb0cfd27369252de52e4b03410c4065bad2 Last test of basis 180200 2023-04-11 01:53:29 Z 1 days Testing same since 180206 2023-04-11 14:37:01 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ddaf7bb0cf..5ea03c570c 5ea03c570c8610d4359f8bbf5f093d215344ce3f -> master From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:23:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520294.807725 (Exim 4.92) (envelope-from ) id 1pmf7Q-0005oO-7b; Wed, 12 Apr 2023 18:22:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520294.807725; Wed, 12 Apr 2023 18:22:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmf7Q-0005oH-4M; Wed, 12 Apr 2023 18:22:56 +0000 Received: by outflank-mailman (input) for mailman id 520294; Wed, 12 Apr 2023 18:22:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmf7N-0005o9-DE for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:22:54 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0808e238-d95f-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 20:22:51 +0200 (CEST) Received: from [2001:8b0:10b:5:d4a3:d89c:c03d:e45c] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmf7A-0076Pj-Ki; Wed, 12 Apr 2023 18:22:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0808e238-d95f-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FMgErKlvTq/DZ1hsfRQ5x+/8tteMVJxJl1K2G+ztm2E=; b=r+b0LY0NHCggqPQ0RVv0bmzUhf lV8QwoxNrzHT0HCozeE8EeQOq3dxq1tgyS4TuuTsJB00qBw+TyaXuxLysyGRws2vMJ5Pml4SJF/9X 7hnYzlza5TWWbYq5R3n7RM+tAJSpjbsYJgLLZV6XTkZTWvCAWInbdRwhQ3cmM6K9jZPqNVCspxaO9 PG08IkKAVKGwmXuzNSLWQBbXTCxOx5Rr6URQHgE/3hWmIFKGw3vHTWxuF6ML5ysUaIvKtkouRJwGt JPx7NuT9VObawsogWqoFn77swrD7y0/nL1jkVhoq7zWiHIFXZWQltNQAUzhZxr1+OAAtgxkCwqfhV EC742khA==; Message-ID: <92e10c45117dce9c07304a567fd412434ea0ddd3.camel@infradead.org> Subject: Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations From: David Woodhouse To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Date: Wed, 12 Apr 2023 19:22:38 +0100 In-Reply-To: References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-23-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-Xp0bkBS/xd5/DOVDOVjB" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-Xp0bkBS/xd5/DOVDOVjB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-04-11 at 19:07 +0100, Peter Maydell wrote: >=20 >=20 > > +static void xs_be_unwatch(struct qemu_xs_handle *h, struct > > qemu_xs_watch *w) > > +{ > > +=C2=A0=C2=A0=C2=A0 xs_impl_unwatch(h->impl, DOMID_QEMU, w->path, NULL, > > xs_be_watch_cb, w); >=20 > Coverity points out that this is the only call to xs_impl_unwatch() > where we don't check the return value. Is there some useful way > we can report the error, or is it a "we're closing everything down > anyway, no way to report anything" situation? (This particular > Coverity heuristic is quite prone to false positives, so if that's > the way it is I'll just mark it as a f-p in the coverity UI.) This is because the Xen libxenstore API doesn't return an error, and this is the ops function which emulates that same API. I suppose we could explicitly cast to void with a comment to that effect, to avoid having it linger in Coverity? I think that's sufficient to make Coverity shut up, isn't it? --=-Xp0bkBS/xd5/DOVDOVjB Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDEyMTgyMjM4WjAvBgkqhkiG9w0BCQQxIgQgJ0U7/4DY IOLbvjX7/V1CfHz2x4x+x2tqnhDjPo1c5FEwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgB/0bmG8i4XLIiZKhZfVQi7Riv5DfIbsBMd RwsoOUxPloK9v7nylfD6IsvRGL9vRAs6/mA70i2Gg5Pnm+q4bdRE35V6kVML1jsfb6hP342HLM+H k8Npmq6PYbfR8y8K1NmBbpNCO6l7vEwFwDjTrt7Er96Xbuct2UCFReNtDZcPldugsfIsbrUhsK1Q s4nVtGGBcBuifXwAV1qIcu/V159h0g/5ardYKvzcnjbOLBU7pt9QXm8GLxhsE4L+SLda0O2wkul2 Apdj7pRhpMAz7deOWl2huW/HPOdJga2ssuFKFtaw2HYxxNZBS7F4MklC5bxS37D5pLjw7PW3Qf1x hsdOjlntErh4C/peVYtRrJsh8FgosaOKgdwI/1PK1XTxy5o48e9fZL248/UGe7GtXjbhkXD8cOhL jITcmME68Mev3lgJ3LnoklZFUbF07onGJhH2mPwjwJSTZs5Qu/xTWRl/c+nLHP1leB4FUIkjQ0z1 2rta7txQGxkNRokt+uFFVVeAoXhAQblm6oTf5tzVYQWvMrVE0MSnr6TqQGPsNXEaSkNT0Mvd1R1x eXg4rYC3KzLGfDYJ8Kf6xANVd+dgs9OgIqfZy57x2wDB89m0O1vW2Tmi8bN+bc2G0RMKIOKe+IeT 6ukYeRro7teUDaVP+Fj9hWIcPPVcGfo52dSc7ochbQAAAAAAAA== --=-Xp0bkBS/xd5/DOVDOVjB-- From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:34:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:34:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520301.807735 (Exim 4.92) (envelope-from ) id 1pmfIL-0007K0-66; Wed, 12 Apr 2023 18:34:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520301.807735; Wed, 12 Apr 2023 18:34:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfIL-0007Jt-3T; Wed, 12 Apr 2023 18:34:13 +0000 Received: by outflank-mailman (input) for mailman id 520301; Wed, 12 Apr 2023 18:34:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfII-0007Jn-Ot for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:34:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ac37d79-d960-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:34:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ac37d79-d960-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681324447; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=E8aR5c3iwwAn+MHFxqQ3wmB9i/4CaPvwKAvF/3XXZ3g=; b=KOViJcXlDzXr9mI+CZmSqEg58U+I5q7FRZJWiGBzDTOASoKsU+H1iHy+ mofvW8GTUkrtRNrJ0Pofr5ooc7h3h5yel5Uc0urenlYAiD4BBOabkn9Hc 0lyvJeNQw+HDDL0IQBO5aK9pNYGyUUQayi+baFeAUHmU+V/AXCZp7MjoI 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 105184545 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:OXLSlK4Q+aV6onN0c7L+yQxRtCnHchMFZxGqfqrLsTDasY5as4F+v mAeDDqAPv6JN2WmfNAgYNm2pE0EvpaAnd9kGlRrqitmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawS5geF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0 6EWDBoqfi2/ge+V8eKeTPtg18EiFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9xx7F/ zKaojikav0cHNajmRyv2XKdvM3goj/wUtgZNrSRpsc/1TV/wURMUUZLBDNXu8KRkVWiUthSL 0gV/CsGrqUo8kGvCN7nUHWQhX+PvhcYHf1KAeA+wAiXz+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+pQSiaYHZPazVYPGldEFVDuoO4yG0usv7RZvA+Hoqfqc3IJTf94 AHaiS4si+QWjPdegs1X4mv7byKQSonhF1Blv1+JAD30smuVd6b+OdX2tAGzAeJoad/AEwLf5 CVsd922trhmMH2bqMCarAzh9pmN7u3NDjDTiEUH83IJp2X0oC7LkWy9DVhDyKZV3iUsI2WBj Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMgoLlTYrXwzPRHMt4wIrKTKuftnU Xt8WZ/1ZUv29Iw9lGbmLwvj+eRDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGazghQCxPrc+m39q o8HX+PTkkU3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI9STB/UqOAnux9E2Gn9owM/tr1E riGchcw4DLCabfvcG1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:QPwYt6sikskfLQfjgTOXzHRz7skDZ9V00zEX/kB9WHVpm62j+v xG+c5xvyMc5wxhO03I5urwWpVoLUmzyXcX2+Us1NWZPDUO0VHARL2KhrGM/9SPIUzDH+dmpM JdT5Q= X-Talos-CUID: 9a23:N8yBcGOICzdayu5DfnRp0GQzCv0ZdHD+/Sf1JV20WGNocejA X-Talos-MUID: =?us-ascii?q?9a23=3A0MhzRA+mez78Ib/XnjrSqACQf81Us4KEI0A8q7c?= =?us-ascii?q?phNWPP3Z7GT603A3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.98,339,1673931600"; d="scan'208";a="105184545" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , "Stefano Stabellini" , Michal Orzel Subject: [PATCH] CI: Update FreeBSD to 13.2 Date: Wed, 12 Apr 2023 19:33:56 +0100 Message-ID: <20230412183356.2986459-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel Successful run: https://cirrus-ci.com/task/6232358978846720 --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index b133afb74057..9bb6cce4ead3 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -23,7 +23,7 @@ task: task: name: 'FreeBSD 13' freebsd_instance: - image_family: freebsd-13-1 + image_family: freebsd-13-2 << : *FREEBSD_TEMPLATE task: -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:35:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:35:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520305.807745 (Exim 4.92) (envelope-from ) id 1pmfJY-0007si-Fv; Wed, 12 Apr 2023 18:35:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520305.807745; Wed, 12 Apr 2023 18:35:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfJY-0007sb-Ct; Wed, 12 Apr 2023 18:35:28 +0000 Received: by outflank-mailman (input) for mailman id 520305; Wed, 12 Apr 2023 18:35:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfJX-0007sT-AS for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:35:27 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9410ef3-d960-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:35:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9410ef3-d960-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681324524; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=rHGJGCPiZIDqX0+lu5FAg42KZJHmVLthhNzInWrh6ko=; b=JTnx8lsgQgYALHW74mPmonm5yV2xD4IUxdSMW4mmKSJ3GbMztdMxgWOR vk24XrM6IPh54tWc9gsKzU7k0g2I59NbACcZLORkmqCHO+np81Y6+T2DC ugGqVirZV7Fqz4FpxMJBEdX+GPAyIcoyLp6oWieYG1AtIvdxo3m2n6OTb k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 105184657 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6GDp8qtmGQVdYTdyklliJzYym+fnVFZeMUV32f8akzHdYApBsoF/q tZmKWzXOPaNMGqjfN50YIrg/B5QuJfUydUwSgVo/yBhQXgX+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AOHzSFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBBk0aiG+jruNzui3euxOu80Tc9LWM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw/ zqbpjSlXExFXDCZ4TmAzmq1uN7dp3LmUqsvP6ab/aZmskLGkwT/DzVJDADm8JFVkHWWRNZ3O 0ESvC00osAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAmZDNcbN0ttOctWCcnk FSOmrvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZScs2t3SnYhqtRyVQuZmMpO8voLuJD6ll lhmsxMCa6UvYd8jjvvrpAqZ3W39+vAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9o4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/i5T4+6B62JNoUSCnSUSONh1Hs2DaJ39zm0+HXAbIllY cvLGSpSJS1y5VtbIMqeGL5GjO5DKtEWzmLPX5HrpymaPU6lTCfNE98taQLWBshgtfPsnekg2 4sGXyd8404EC7OWj+i+2dN7EG3m2lBgVMGo8pAGKbHfSuekcUl4Y8LsLXoaU9QNt8xoei3gp xlRhmcwJILDuED6 IronPort-HdrOrdr: A9a23:EhX1qqlgtBNjPhU/oGZfCDIwM2vpDfJP3DAbv31ZSRFFG/Fw9v rPoB1/73TJYVkqNU3I9errBEDiexLhHOBOjrX5VI3KNDUO01HFEGgN1+Xf/wE= X-Talos-CUID: =?us-ascii?q?9a23=3A2CCosWkAxiHU4wQUanEnph4RncDXOVH09XPhHkb?= =?us-ascii?q?hMmgzRI2Qa2KZyPx/rsU7zg=3D=3D?= X-Talos-MUID: 9a23:Ua085AZTnZX5FuBTtDrQnChcBdVSsrmkIX0mirYN48W2Knkl X-IronPort-AV: E=Sophos;i="5.98,339,1673931600"; d="scan'208";a="105184657" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/hvm: Disallow CR0.PG 1->0 transitions when CS.L=1 Date: Wed, 12 Apr 2023 19:35:19 +0100 Message-ID: <20230412183519.2996902-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The Long Mode consistency checks exist to "ensure that the processor does not enter an undefined mode or state that results in unpredictable behavior". APM Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row preventing the OS from trying to exit Long mode while in 64bit mode. This could leave the CPU in Protected Mode with an %rip above the 4G boundary. Experimentally, AMD CPUs really do permit this state transition. An OS which tries it hits an instant SHUTDOWN, even in cases where the truncation I expect to be going on behind the scenes ought to result in sane continued execution. Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" section instructs peoples to switch to a compatibility mode segment first before clearing CR0.PG, which does clear out the upper bits in %rip. This is further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 Architecture". Either way, this appears to have been a genuine oversight in the AMD64 spec. Intel, on the other hand, rejects this state transition with #GP. Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to 4.1.2 "Paging-Mode Enable" was altered from: If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP); software should clear CR4.PCIDE before attempting to disable paging. to If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP). Software should transition to compatibility mode and clear CR4.PCIDE before attempting to disable paging. which acknowledges this corner case, but there doesn't appear to be any other discussion even in the relevant Long Mode sections. So it appears that Intel spotted and addressed the corner case in IA-32e mode, but where 15 years late to document it. Xen was written to the AMD spec, and misses the check. Follow the Intel behaviour, because it is more sensible and avoids hitting a VMEntry failure. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/hvm.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 1454c1732d95..3c8d28a2d8be 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2340,6 +2340,21 @@ int hvm_set_cr0(unsigned long value, bool may_defer) } else if ( !(value & X86_CR0_PG) && (old_value & X86_CR0_PG) ) { + struct segment_register cs; + + hvm_get_segment_register(v, x86_seg_cs, &cs); + + /* + * Intel documents a #GP fault in this case, and VMEntry checks reject + * it as a valid state. AMD permits the state transition, and hits + * SHUTDOWN immediately thereafter. Follow the Intel behaviour. + */ + if ( cs.l ) + { + HVM_DBG_LOG(DBG_LEVEL_1, "Guest attempts to clear CR0.PG while CS.L=1"); + return X86EMUL_EXCEPTION; + } + if ( hvm_pcid_enabled(v) ) { HVM_DBG_LOG(DBG_LEVEL_1, "Guest attempts to clear CR0.PG " -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:51:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:51:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520311.807754 (Exim 4.92) (envelope-from ) id 1pmfYs-0001qg-R1; Wed, 12 Apr 2023 18:51:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520311.807754; Wed, 12 Apr 2023 18:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYs-0001qZ-Nv; Wed, 12 Apr 2023 18:51:18 +0000 Received: by outflank-mailman (input) for mailman id 520311; Wed, 12 Apr 2023 18:51:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYr-0001qS-9T for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:51:17 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00c3d2ca-d963-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 20:51:16 +0200 (CEST) Received: from [2001:8b0:10b:5::ebe] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmfYf-0077lB-4g; Wed, 12 Apr 2023 18:51:05 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYe-001r1B-1f; Wed, 12 Apr 2023 19:51:04 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 00c3d2ca-d963-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=FAopztqETbo2fPeQeCNjHsbWvQfvN+qB27Usma2Ee8w=; b=j2olmn1su4XXnixX5a0dl5WOQs tGYDDng0Lu+7HnGPetpa5EKtx3Lh/D8nFMhXglOuKJzqlsQwOBDoQXWNtMljZQblzaKOV87EDsLRZ pKAmiO3JtQ1YIlqJfjTzOZJaXMkA3Nl6WPyaJbSPv7KJzgTV/r5skMbPF4geX7HCxRpVQQGcyuob5 qZVUs4cPDm0csrie7Ly5YZ8Zxr7tQbe/0n/V2YJDDMijpRdLW9YQCRiOI/yknWTPT3OPM1/KBR/r7 4gA+a3Oju3jyc4FeBjWcLFL9ogJsiMqaX7dvj6CqYVHCf7rGfp9punMadb1R04bsjxcg2Z8OxJDKY NA37yTRg==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes Date: Wed, 12 Apr 2023 19:50:57 +0100 Message-Id: <20230412185102.441523-1-dwmw2@infradead.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Some Coverity fixes and minor cleanups. And most notably, dropping support for Xen libraries older than 4.7.1. I believe there are two issues that remain to be fixed. The x32 build fails, and I've seen patches which attempt to detect x32 and disable the Xen emulation. Along with assertions that we just shouldn't care. I don't have a strong opinion either way but it seems to be in hand. The other is the question of what Xen *actually* does if you try to unmap an IRQ_MSI_EMU PIRQ. I don't think Linux guests try that, and I'm fairly sure Windows doesn't even use MSI→PIRQ mappings in the first place, and I doubt any other guests care either. I'd like to establish the 'correct' behaviour and implement it, ideally before the 8.0 release, but it's going to take me a few days more. David Woodhouse (5): hw/xen: Simplify emulated Xen platform init hw/xen: Fix memory leak in libxenstore_open() for Xen xen: Drop support for Xen versions below 4.7.1 hw/xen: Fix double-free in xen_console store_con_info() hw/xen: Fix broken check for invalid state in xs_be_open() hw/char/xen_console.c | 13 ++---- hw/i386/kvm/xen_evtchn.c | 40 ++++++++--------- hw/i386/kvm/xen_evtchn.h | 3 +- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/pc.c | 13 ++---- hw/xen/xen-operations.c | 59 +----------------------- include/hw/xen/xen_native.h | 107 +------------------------------------------- meson.build | 5 +-- scripts/xen-detect.c | 60 ------------------------- 9 files changed, 33 insertions(+), 269 deletions(-) From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:51:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:51:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520314.807785 (Exim 4.92) (envelope-from ) id 1pmfYw-0002bs-MT; Wed, 12 Apr 2023 18:51:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520314.807785; Wed, 12 Apr 2023 18:51:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYw-0002bj-Jl; Wed, 12 Apr 2023 18:51:22 +0000 Received: by outflank-mailman (input) for mailman id 520314; Wed, 12 Apr 2023 18:51:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYu-0001qk-QE for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:51:20 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00cacccc-d963-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:51:15 +0200 (CEST) Received: from [2001:8b0:10b:5::ebe] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmfYf-0077lC-4l; Wed, 12 Apr 2023 18:51:05 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYe-001r1E-1o; Wed, 12 Apr 2023 19:51:04 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 00cacccc-d963-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=tO8ebQO7hdBkDVSP4r+H8wDgeYM8ejzEVuKZ0cLSybE=; b=XNrj8BMABVv6sUMXdtjglSDnX8 3vqc0BHSKUVoTm4KdYsPLXfvX4sg8NBLll2N3jWqzzy1XjtXhTso4UClv3zK+Wo/lXaWTIKROWAXk n8V6T9UBtmYBSg9NMdsP7hiQhPxZoolCMSUzWdMFVrb/wHfVc4To4//Se0e86u8oU9+t4hyPezTbH f5MJasfK2wQfTiJs7w5l/hYZYx2CDcsMh7Hwr5uho1w8CUdyi62f2QwEgOT7RJLjBRi8CwnVD9JNN 4T2rynFSIcpVIvoF02xBSckWGDbUY0yH2mpFcVj7EgK7zOJFQpvAXN7f/sN77jA/1LGpvocufAjv5 3J7SUvwQ==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: [PATCH 1/5] hw/xen: Simplify emulated Xen platform init Date: Wed, 12 Apr 2023 19:50:58 +0100 Message-Id: <20230412185102.441523-2-dwmw2@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> References: <20230412185102.441523-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html From: David Woodhouse I initially put the basic platform init (overlay pages, grant tables, event channels) into mc->kvm_type because that was the earliest place that could sensibly test for xen_mode==XEN_EMULATE. The intent was to do this early enough that we could then initialise the XenBus and other parts which would have depended on them, from a generic location for both Xen and KVM/Xen in the PC-specific code, as seen in https://lore.kernel.org/qemu-devel/20230116221919.1124201-16-dwmw2@infradead.org/ However, then the Xen on Arm patches came along, and *they* wanted to do the XenBus init from a 'generic' Xen-specific location instead: https://lore.kernel.org/qemu-devel/20230210222729.957168-4-sstabellini@kernel.org/ Since there's no generic location that covers all three, I conceded to do it for XEN_EMULATE mode in pc_basic_devices_init(). And now there's absolutely no point in having some of the platform init done from pc_machine_kvm_type(); we can move it all up to live in a single place in pc_basic_devices_init(). This has the added benefit that we can drop the separate xen_evtchn_connect_gsis() function completely, and pass just the system GSIs in directly to xen_evtchn_create(). While I'm at it, it does no harm to explicitly pass in the *number* of said GSIs, because it does make me twitch a bit to pass an array of impicit size. During the lifetime of the KVM/Xen patchset, that had already changed (albeit just cosmetically) from GSI_NUM_PINS to IOAPIC_NUM_PINS. And document a bit better that this is for the *output* GSI for raising CPU0's events when the per-CPU vector isn't available. The fact that we create a whole set of them and then only waggle the one we're told to, instead of having a single output and only *connecting* it to the GSI that it should be connected to, is still non-intuitive for me. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/kvm/xen_evtchn.c | 40 ++++++++++++++++++++-------------------- hw/i386/kvm/xen_evtchn.h | 3 +-- hw/i386/pc.c | 13 ++++--------- 3 files changed, 25 insertions(+), 31 deletions(-) diff --git a/hw/i386/kvm/xen_evtchn.c b/hw/i386/kvm/xen_evtchn.c index 3048329474..3d810dbd59 100644 --- a/hw/i386/kvm/xen_evtchn.c +++ b/hw/i386/kvm/xen_evtchn.c @@ -147,7 +147,10 @@ struct XenEvtchnState { QemuMutex port_lock; uint32_t nr_ports; XenEvtchnPort port_table[EVTCHN_2L_NR_CHANNELS]; - qemu_irq gsis[IOAPIC_NUM_PINS]; + + /* Connected to the system GSIs for raising callback as GSI / INTx */ + unsigned int nr_callback_gsis; + qemu_irq *callback_gsis; struct xenevtchn_handle *be_handles[EVTCHN_2L_NR_CHANNELS]; @@ -299,7 +302,7 @@ static void gsi_assert_bh(void *opaque) } } -void xen_evtchn_create(void) +void xen_evtchn_create(unsigned int nr_gsis, qemu_irq *system_gsis) { XenEvtchnState *s = XEN_EVTCHN(sysbus_create_simple(TYPE_XEN_EVTCHN, -1, NULL)); @@ -310,8 +313,19 @@ void xen_evtchn_create(void) qemu_mutex_init(&s->port_lock); s->gsi_bh = aio_bh_new(qemu_get_aio_context(), gsi_assert_bh, s); - for (i = 0; i < IOAPIC_NUM_PINS; i++) { - sysbus_init_irq(SYS_BUS_DEVICE(s), &s->gsis[i]); + /* + * These are the *output* GSI from event channel support, for + * signalling CPU0's events via GSI or PCI INTx instead of the + * per-CPU vector. We create a *set* of irqs and connect one to + * each of the system GSIs which were passed in from the platform + * code, and then just trigger the right one as appropriate from + * xen_evtchn_set_callback_level(). + */ + s->nr_callback_gsis = nr_gsis; + s->callback_gsis = g_new0(qemu_irq, nr_gsis); + for (i = 0; i < nr_gsis; i++) { + sysbus_init_irq(SYS_BUS_DEVICE(s), &s->callback_gsis[i]); + sysbus_connect_irq(SYS_BUS_DEVICE(s), i, system_gsis[i]); } /* @@ -336,20 +350,6 @@ void xen_evtchn_create(void) xen_evtchn_ops = &emu_evtchn_backend_ops; } -void xen_evtchn_connect_gsis(qemu_irq *system_gsis) -{ - XenEvtchnState *s = xen_evtchn_singleton; - int i; - - if (!s) { - return; - } - - for (i = 0; i < IOAPIC_NUM_PINS; i++) { - sysbus_connect_irq(SYS_BUS_DEVICE(s), i, system_gsis[i]); - } -} - static void xen_evtchn_register_types(void) { type_register_static(&xen_evtchn_info); @@ -430,8 +430,8 @@ void xen_evtchn_set_callback_level(int level) return; } - if (s->callback_gsi && s->callback_gsi < IOAPIC_NUM_PINS) { - qemu_set_irq(s->gsis[s->callback_gsi], level); + if (s->callback_gsi && s->callback_gsi < s->nr_callback_gsis) { + qemu_set_irq(s->callback_gsis[s->callback_gsi], level); if (level) { /* Ensure the vCPU polls for deassertion */ kvm_xen_set_callback_asserted(); diff --git a/hw/i386/kvm/xen_evtchn.h b/hw/i386/kvm/xen_evtchn.h index bfb67ac2bc..b740acfc0d 100644 --- a/hw/i386/kvm/xen_evtchn.h +++ b/hw/i386/kvm/xen_evtchn.h @@ -16,10 +16,9 @@ typedef uint32_t evtchn_port_t; -void xen_evtchn_create(void); +void xen_evtchn_create(unsigned int nr_gsis, qemu_irq *system_gsis); int xen_evtchn_soft_reset(void); int xen_evtchn_set_callback_param(uint64_t param); -void xen_evtchn_connect_gsis(qemu_irq *system_gsis); void xen_evtchn_set_callback_level(int level); int xen_evtchn_set_port(uint16_t port); diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 1489abf010..25584cb8f3 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1319,7 +1319,10 @@ void pc_basic_device_init(struct PCMachineState *pcms, #ifdef CONFIG_XEN_EMU if (xen_mode == XEN_EMULATE) { - xen_evtchn_connect_gsis(gsi); + xen_overlay_create(); + xen_evtchn_create(IOAPIC_NUM_PINS, gsi); + xen_gnttab_create(); + xen_xenstore_create(); if (pcms->bus) { pci_create_simple(pcms->bus, -1, "xen-platform"); } @@ -1868,14 +1871,6 @@ static void pc_machine_initfn(Object *obj) int pc_machine_kvm_type(MachineState *machine, const char *kvm_type) { -#ifdef CONFIG_XEN_EMU - if (xen_mode == XEN_EMULATE) { - xen_overlay_create(); - xen_evtchn_create(); - xen_gnttab_create(); - xen_xenstore_create(); - } -#endif return 0; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:51:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:51:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520312.807765 (Exim 4.92) (envelope-from ) id 1pmfYu-00025d-2G; Wed, 12 Apr 2023 18:51:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520312.807765; Wed, 12 Apr 2023 18:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYt-00025V-Ub; Wed, 12 Apr 2023 18:51:19 +0000 Received: by outflank-mailman (input) for mailman id 520312; Wed, 12 Apr 2023 18:51:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYt-0001qk-4D for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:51:19 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00c6275a-d963-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:51:15 +0200 (CEST) Received: from [2001:8b0:10b:5::ebe] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmfYf-0077lE-7x; Wed, 12 Apr 2023 18:51:06 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYe-001r1R-2I; Wed, 12 Apr 2023 19:51:04 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 00c6275a-d963-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=pvefxXf1YhjL3JSf+V8JRgGjqQjxWW3E4QNSUXU8Vyk=; b=TjPE0dW5/ekjTjDaeeWQk5fUJV nNUgr4r4gwcl33okRN07A5zJwF7Q0B4b01PnDXOtfu3v7VarXGfsZZNSPBiwmIfLc2EdIZ2EGBo4o QTqoNs4SeLgJml9Y/6rUfD8FuNIh2wI+nWzJS/7XYaEwpMo+wj7PQJ9f5m1MKj8o0U6AFB1l5km3X rElR8Zf42jdPGjQ1hHcqk1DSpdw5yW/z9RBJwQGSUYukk2JFnGU7rFkK9jtVNSx3ySS6kedTvELwC pvVDHGxtrOnUPo8v7MBvIwMGNL0HzMnLXSZ8RfjifLwUOnrHdF05EhNKDHsy1O0kxGie2f4iVThoa QyhSoxew==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info() Date: Wed, 12 Apr 2023 19:51:01 +0100 Message-Id: <20230412185102.441523-5-dwmw2@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> References: <20230412185102.441523-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html From: David Woodhouse Coverity spotted a double-free (CID 1508254); we g_string_free(path) and then for some reason immediately call free(path) too. We should just use g_autoptr() for it anyway, which simplifies the code a bit. Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to xen_console.c") Signed-off-by: David Woodhouse --- hw/char/xen_console.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c index c7a19c0e7c..810dae3f44 100644 --- a/hw/char/xen_console.c +++ b/hw/char/xen_console.c @@ -178,8 +178,7 @@ static int store_con_info(struct XenConsole *con) Chardev *cs = qemu_chr_fe_get_driver(&con->chr); char *pts = NULL; char *dom_path; - GString *path; - int ret = -1; + g_autoptr(GString) path = NULL; /* Only continue if we're talking to a pty. */ if (!CHARDEV_IS_PTY(cs)) { @@ -204,15 +203,9 @@ static int store_con_info(struct XenConsole *con) if (xenstore_write_str(con->console, path->str, pts)) { fprintf(stderr, "xenstore_write_str for '%s' fail", path->str); - goto out; + return -1; } - ret = 0; - -out: - g_string_free(path, true); - free(path); - - return ret; + return 0; } static int con_init(struct XenLegacyDevice *xendev) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:51:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:51:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520313.807775 (Exim 4.92) (envelope-from ) id 1pmfYv-0002Lv-E3; Wed, 12 Apr 2023 18:51:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520313.807775; Wed, 12 Apr 2023 18:51:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYv-0002Lk-BD; Wed, 12 Apr 2023 18:51:21 +0000 Received: by outflank-mailman (input) for mailman id 520313; Wed, 12 Apr 2023 18:51:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYt-0001qk-Q3 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:51:19 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00ceabaf-d963-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:51:16 +0200 (CEST) Received: from [2001:8b0:10b:5::ebe] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmfYf-0077lF-7n; Wed, 12 Apr 2023 18:51:05 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYe-001r1V-2S; Wed, 12 Apr 2023 19:51:04 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 00ceabaf-d963-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=NIk/dSGE1S/XkSMWglE5vSkIy2Aotr95wrmjXgO3qTE=; b=jjZUxe9t2zm5dC09PCwBEOxg1z joZy6jDOxzr1nMq4pNbcp3WLngm4pYpiqE8AoYSdmmYEq9kGeF6bv9Z2a4WWxpA7YiY0Xtz7jkDNZ VMLSp2/tDON07Uv3Yd4BFcaGPn27lWka2nduaqL3piYJyOoFIM7uSZqKzax8Kh6VsHdHz0zYgSqqO ILzM43hX1ULSuqD1DrDrzjbRoUwQetje20sfAqhL/5s+GMRopH8X5yY3w5y/cRZoRoZGcwy+b3i9P WZYW1Tl6JlHkIlCYN93JjtiITKBL2dr6Oz/qojqVcvQj/3dU01ZHLF4uYLj6QxJIzAGsOfpqp4I7B a9J7iXrQ==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open() Date: Wed, 12 Apr 2023 19:51:02 +0100 Message-Id: <20230412185102.441523-6-dwmw2@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> References: <20230412185102.441523-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html From: David Woodhouse Coverity points out that if (!s && !s->impl) isn't really what we intended to do here. CID 1508131. Fixes: 032475127225 ("hw/xen: Add emulated implementation of XenStore operations") Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 900679af8a..65f91e87d7 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kvm/xen_xenstore.c @@ -1688,7 +1688,7 @@ static struct qemu_xs_handle *xs_be_open(void) XenXenstoreState *s = xen_xenstore_singleton; struct qemu_xs_handle *h; - if (!s && !s->impl) { + if (!s || !s->impl) { errno = -ENOSYS; return NULL; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:51:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:51:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520315.807794 (Exim 4.92) (envelope-from ) id 1pmfYy-0002tS-UA; Wed, 12 Apr 2023 18:51:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520315.807794; Wed, 12 Apr 2023 18:51:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYy-0002tL-RD; Wed, 12 Apr 2023 18:51:24 +0000 Received: by outflank-mailman (input) for mailman id 520315; Wed, 12 Apr 2023 18:51:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYx-0001qS-Kg for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:51:24 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 045f501b-d963-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 20:51:22 +0200 (CEST) Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYf-00E0VL-3D; Wed, 12 Apr 2023 18:51:06 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYe-001r1H-1y; Wed, 12 Apr 2023 19:51:04 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 045f501b-d963-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=Xa7ooeKNSf+k8dNFDJzvKocJu/52pawuc5iQqeYJl9c=; b=nxQF+PYllY75sHqovcNk2BH4Gi RpVSWDgHzGp6LR/J9XHEZ/8NcMhK+wvi2yYuhn1/gaMykPZ42EuBEZDwbpl+7j+9ffR82KtYbpKHp jDMpMfdHfLyMA6cWiFQ9a+98ywwxU3E4Ks45R78pIEPXpoIkT8fg91nyZVcDyzekRslNMu+N3+Dmi vWtqtkYz9VGIPOJ6qJHf/pF+xK8y0jdGcEwCDtzTR1tSBnHGNjIVmY6iljd5SJMmR7UXzcXXwRDsC ZEJtD3rZKBTKNS1GAyETt1GMxjt9mnIJoRAy5zmBRb9118HdiHPaxBwJA1NYFEIvolFPS+Z3L+hAX p3eq+52w==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: [PATCH 2/5] hw/xen: Fix memory leak in libxenstore_open() for Xen Date: Wed, 12 Apr 2023 19:50:59 +0100 Message-Id: <20230412185102.441523-3-dwmw2@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> References: <20230412185102.441523-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html From: David Woodhouse There was a superfluous allocation of the XS handle, leading to it being leaked on both the error path and the success path (where it gets allocated again). Spotted by Coverity (CID 1508098). Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to internal emulation") Suggested-by: Peter Maydell Signed-off-by: David Woodhouse Reviewed-by: Peter Maydell --- hw/xen/xen-operations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen-operations.c b/hw/xen/xen-operations.c index 4b78fbf4bd..3d213d28df 100644 --- a/hw/xen/xen-operations.c +++ b/hw/xen/xen-operations.c @@ -287,7 +287,7 @@ static void watch_event(void *opaque) static struct qemu_xs_handle *libxenstore_open(void) { struct xs_handle *xsh = xs_open(0); - struct qemu_xs_handle *h = g_new0(struct qemu_xs_handle, 1); + struct qemu_xs_handle *h; if (!xsh) { return NULL; -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:51:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:51:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520316.807805 (Exim 4.92) (envelope-from ) id 1pmfZ0-0003AM-7z; Wed, 12 Apr 2023 18:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520316.807805; Wed, 12 Apr 2023 18:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfZ0-00039k-42; Wed, 12 Apr 2023 18:51:26 +0000 Received: by outflank-mailman (input) for mailman id 520316; Wed, 12 Apr 2023 18:51:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfYy-0001qS-Ki for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:51:24 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04a6bb6f-d963-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 20:51:22 +0200 (CEST) Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYg-00E0VM-03; Wed, 12 Apr 2023 18:51:06 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmfYe-001r1N-2D; Wed, 12 Apr 2023 19:51:04 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 04a6bb6f-d963-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=r0KrVFy8wO5hkkGDmOWYariQi9uMlzauvQswU3PX06g=; b=ksJ5J0ZCaGPS+w9bWo3qQ38f/f 5dx1E09HdQlfCQ7zAQv5t2wDpola+fKSQIlh1VljOSAovETc/RoDS2hP3KrOuLWG9duJ5tX9z9DaW taNp+hP4l9lhhhObZc8K4m8DgnbwxhK9vx6czSEsBsDqOXqeXUDOEh28woBd+9HCM1BEPGXEaYzoV l8v2T/LFJWOzVC1kPWOvBjP7dR8xE41+HAp7IxxgMcgQzxkCQXqYiF9Rx2XJqYn6KM1GSM3i8zmw9 2DVadTK32LRFcm29UdnVR0tSfHTiHb1bXNHb8L4WHF7YnzgGmkL7bxff29Izie8M7mcFw9H83AOyG 9x+LnoVg==; From: David Woodhouse To: qemu-devel@nongnu.org Cc: no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: [PATCH 3/5] xen: Drop support for Xen versions below 4.7.1 Date: Wed, 12 Apr 2023 19:51:00 +0100 Message-Id: <20230412185102.441523-4-dwmw2@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> References: <20230412185102.441523-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html From: David Woodhouse In restructuring to allow for internal emulation of Xen functionality, I broke compatibility for Xen 4.6 and earlier. Fix this by explicitly removing support for anything older than 4.7.1, which is also ancient but it does still build, and the compatibility support for it is fairly unintrusive. Fixes: 15e283c5b684 ("hw/xen: Add foreignmem operations to allow redirection to internal emulation") Signed-off-by: David Woodhouse --- hw/xen/xen-operations.c | 57 +------------------ include/hw/xen/xen_native.h | 107 +----------------------------------- meson.build | 5 +- scripts/xen-detect.c | 60 -------------------- 4 files changed, 3 insertions(+), 226 deletions(-) diff --git a/hw/xen/xen-operations.c b/hw/xen/xen-operations.c index 3d213d28df..e00983ec44 100644 --- a/hw/xen/xen-operations.c +++ b/hw/xen/xen-operations.c @@ -28,46 +28,13 @@ #include /* - * We don't support Xen prior to 4.2.0. + * We don't support Xen prior to 4.7.1. */ -/* Xen 4.2 through 4.6 */ -#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40701 - -typedef xc_evtchn xenevtchn_handle; -typedef evtchn_port_or_error_t xenevtchn_port_or_error_t; - -#define xenevtchn_open(l, f) xc_evtchn_open(l, f); -#define xenevtchn_close(h) xc_evtchn_close(h) -#define xenevtchn_fd(h) xc_evtchn_fd(h) -#define xenevtchn_pending(h) xc_evtchn_pending(h) -#define xenevtchn_notify(h, p) xc_evtchn_notify(h, p) -#define xenevtchn_bind_interdomain(h, d, p) xc_evtchn_bind_interdomain(h, d, p) -#define xenevtchn_unmask(h, p) xc_evtchn_unmask(h, p) -#define xenevtchn_unbind(h, p) xc_evtchn_unbind(h, p) - -typedef xc_gnttab xengnttab_handle; - -#define xengnttab_open(l, f) xc_gnttab_open(l, f) -#define xengnttab_close(h) xc_gnttab_close(h) -#define xengnttab_set_max_grants(h, n) xc_gnttab_set_max_grants(h, n) -#define xengnttab_map_grant_ref(h, d, r, p) xc_gnttab_map_grant_ref(h, d, r, p) -#define xengnttab_unmap(h, a, n) xc_gnttab_munmap(h, a, n) -#define xengnttab_map_grant_refs(h, c, d, r, p) \ - xc_gnttab_map_grant_refs(h, c, d, r, p) -#define xengnttab_map_domain_grant_refs(h, c, d, r, p) \ - xc_gnttab_map_domain_grant_refs(h, c, d, r, p) - -typedef xc_interface xenforeignmemory_handle; - -#else /* CONFIG_XEN_CTRL_INTERFACE_VERSION >= 40701 */ - #include #include #include -#endif - /* Xen before 4.8 */ static int libxengnttab_fallback_grant_copy(xengnttab_handle *xgt, @@ -223,26 +190,6 @@ static struct gnttab_backend_ops libxengnttab_backend_ops = { .unmap = libxengnttab_backend_unmap, }; -#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40701 - -static void *libxenforeignmem_backend_map(uint32_t dom, void *addr, int prot, - size_t pages, xfn_pfn_t *pfns, - int *errs) -{ - if (errs) { - return xc_map_foreign_bulk(xen_xc, dom, prot, pfns, errs, pages); - } else { - return xc_map_foreign_pages(xen_xc, dom, prot, pfns, pages); - } -} - -static int libxenforeignmem_backend_unmap(void *addr, size_t pages) -{ - return munmap(addr, pages * XC_PAGE_SIZE); -} - -#else /* CONFIG_XEN_CTRL_INTERFACE_VERSION >= 40701 */ - static void *libxenforeignmem_backend_map(uint32_t dom, void *addr, int prot, size_t pages, xen_pfn_t *pfns, int *errs) @@ -256,8 +203,6 @@ static int libxenforeignmem_backend_unmap(void *addr, size_t pages) return xenforeignmemory_unmap(xen_fmem, addr, pages); } -#endif - struct foreignmem_backend_ops libxenforeignmem_backend_ops = { .map = libxenforeignmem_backend_map, .unmap = libxenforeignmem_backend_unmap, diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h index 6bcc83baf9..f11eb423e3 100644 --- a/include/hw/xen/xen_native.h +++ b/include/hw/xen/xen_native.h @@ -24,23 +24,11 @@ extern xc_interface *xen_xc; /* - * We don't support Xen prior to 4.2.0. + * We don't support Xen prior to 4.7.1. */ -/* Xen 4.2 through 4.6 */ -#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40701 - -typedef xc_interface xenforeignmemory_handle; - -#define xenforeignmemory_open(l, f) xen_xc -#define xenforeignmemory_close(h) - -#else /* CONFIG_XEN_CTRL_INTERFACE_VERSION >= 40701 */ - #include -#endif - extern xenforeignmemory_handle *xen_fmem; #if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40900 @@ -148,8 +136,6 @@ static inline xendevicemodel_handle *xendevicemodel_open( return xen_xc; } -#if CONFIG_XEN_CTRL_INTERFACE_VERSION >= 40500 - static inline int xendevicemodel_create_ioreq_server( xendevicemodel_handle *dmod, domid_t domid, int handle_bufioreq, ioservid_t *id) @@ -211,8 +197,6 @@ static inline int xendevicemodel_set_ioreq_server_state( return xc_hvm_set_ioreq_server_state(dmod, domid, id, enabled); } -#endif /* CONFIG_XEN_CTRL_INTERFACE_VERSION >= 40500 */ - static inline int xendevicemodel_set_pci_intx_level( xendevicemodel_handle *dmod, domid_t domid, uint16_t segment, uint8_t bus, uint8_t device, uint8_t intx, unsigned int level) @@ -340,15 +324,6 @@ static inline int xen_get_vmport_regs_pfn(xc_interface *xc, domid_t dom, } #endif -/* Xen before 4.6 */ -#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40600 - -#ifndef HVM_IOREQSRV_BUFIOREQ_ATOMIC -#define HVM_IOREQSRV_BUFIOREQ_ATOMIC 2 -#endif - -#endif - static inline int xen_get_default_ioreq_server_info(domid_t dom, xen_pfn_t *ioreq_pfn, xen_pfn_t *bufioreq_pfn, @@ -386,84 +361,6 @@ static inline int xen_get_default_ioreq_server_info(domid_t dom, return 0; } -/* Xen before 4.5 */ -#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40500 - -#ifndef HVM_PARAM_BUFIOREQ_EVTCHN -#define HVM_PARAM_BUFIOREQ_EVTCHN 26 -#endif - -#define IOREQ_TYPE_PCI_CONFIG 2 - -typedef uint16_t ioservid_t; - -static inline void xen_map_memory_section(domid_t dom, - ioservid_t ioservid, - MemoryRegionSection *section) -{ -} - -static inline void xen_unmap_memory_section(domid_t dom, - ioservid_t ioservid, - MemoryRegionSection *section) -{ -} - -static inline void xen_map_io_section(domid_t dom, - ioservid_t ioservid, - MemoryRegionSection *section) -{ -} - -static inline void xen_unmap_io_section(domid_t dom, - ioservid_t ioservid, - MemoryRegionSection *section) -{ -} - -static inline void xen_map_pcidev(domid_t dom, - ioservid_t ioservid, - PCIDevice *pci_dev) -{ -} - -static inline void xen_unmap_pcidev(domid_t dom, - ioservid_t ioservid, - PCIDevice *pci_dev) -{ -} - -static inline void xen_create_ioreq_server(domid_t dom, - ioservid_t *ioservid) -{ -} - -static inline void xen_destroy_ioreq_server(domid_t dom, - ioservid_t ioservid) -{ -} - -static inline int xen_get_ioreq_server_info(domid_t dom, - ioservid_t ioservid, - xen_pfn_t *ioreq_pfn, - xen_pfn_t *bufioreq_pfn, - evtchn_port_t *bufioreq_evtchn) -{ - return xen_get_default_ioreq_server_info(dom, ioreq_pfn, - bufioreq_pfn, - bufioreq_evtchn); -} - -static inline int xen_set_ioreq_server_state(domid_t dom, - ioservid_t ioservid, - bool enable) -{ - return 0; -} - -/* Xen 4.5 */ -#else - static bool use_default_ioreq_server; static inline void xen_map_memory_section(domid_t dom, @@ -624,6 +521,4 @@ static inline int xen_set_ioreq_server_state(domid_t dom, enable); } -#endif - #endif /* QEMU_HW_XEN_NATIVE_H */ diff --git a/meson.build b/meson.build index c44d05a13f..1f223ae7fc 100644 --- a/meson.build +++ b/meson.build @@ -1425,16 +1425,13 @@ if get_option('xen').enabled() or (get_option('xen').auto() and have_system) endif endif if not xen.found() - xen_tests = [ '4.11.0', '4.10.0', '4.9.0', '4.8.0', '4.7.1', '4.6.0', '4.5.0', '4.2.0' ] + xen_tests = [ '4.11.0', '4.10.0', '4.9.0', '4.8.0', '4.7.1' ] xen_libs = { '4.11.0': [ 'xenstore', 'xenctrl', 'xendevicemodel', 'xenforeignmemory', 'xengnttab', 'xenevtchn', 'xentoolcore' ], '4.10.0': [ 'xenstore', 'xenctrl', 'xendevicemodel', 'xenforeignmemory', 'xengnttab', 'xenevtchn', 'xentoolcore' ], '4.9.0': [ 'xenstore', 'xenctrl', 'xendevicemodel', 'xenforeignmemory', 'xengnttab', 'xenevtchn' ], '4.8.0': [ 'xenstore', 'xenctrl', 'xenforeignmemory', 'xengnttab', 'xenevtchn' ], '4.7.1': [ 'xenstore', 'xenctrl', 'xenforeignmemory', 'xengnttab', 'xenevtchn' ], - '4.6.0': [ 'xenstore', 'xenctrl' ], - '4.5.0': [ 'xenstore', 'xenctrl' ], - '4.2.0': [ 'xenstore', 'xenctrl' ], } xen_deps = {} foreach ver: xen_tests diff --git a/scripts/xen-detect.c b/scripts/xen-detect.c index 85e8206490..db049e605c 100644 --- a/scripts/xen-detect.c +++ b/scripts/xen-detect.c @@ -138,66 +138,6 @@ return 0; } -#elif CONFIG_XEN_CTRL_INTERFACE_VERSION == 40600 - #include - #include - #include - #include - #if !defined(HVM_MAX_VCPUS) - # error HVM_MAX_VCPUS not defined - #endif - int main(void) { - xc_interface *xc; - xs_daemon_open(); - xc = xc_interface_open(0, 0, 0); - xc_hvm_set_mem_type(0, 0, HVMMEM_ram_ro, 0, 0); - xc_gnttab_open(NULL, 0); - xc_domain_add_to_physmap(0, 0, XENMAPSPACE_gmfn, 0, 0); - xc_hvm_inject_msi(xc, 0, 0xf0000000, 0x00000000); - xc_hvm_create_ioreq_server(xc, 0, HVM_IOREQSRV_BUFIOREQ_ATOMIC, NULL); - xc_reserved_device_memory_map(xc, 0, 0, 0, 0, NULL, 0); - return 0; - } - -#elif CONFIG_XEN_CTRL_INTERFACE_VERSION == 40500 - #include - #include - #include - #include - #if !defined(HVM_MAX_VCPUS) - # error HVM_MAX_VCPUS not defined - #endif - int main(void) { - xc_interface *xc; - xs_daemon_open(); - xc = xc_interface_open(0, 0, 0); - xc_hvm_set_mem_type(0, 0, HVMMEM_ram_ro, 0, 0); - xc_gnttab_open(NULL, 0); - xc_domain_add_to_physmap(0, 0, XENMAPSPACE_gmfn, 0, 0); - xc_hvm_inject_msi(xc, 0, 0xf0000000, 0x00000000); - xc_hvm_create_ioreq_server(xc, 0, 0, NULL); - return 0; - } - -#elif CONFIG_XEN_CTRL_INTERFACE_VERSION == 40200 - #include - #include - #include - #include - #if !defined(HVM_MAX_VCPUS) - # error HVM_MAX_VCPUS not defined - #endif - int main(void) { - xc_interface *xc; - xs_daemon_open(); - xc = xc_interface_open(0, 0, 0); - xc_hvm_set_mem_type(0, 0, HVMMEM_ram_ro, 0, 0); - xc_gnttab_open(NULL, 0); - xc_domain_add_to_physmap(0, 0, XENMAPSPACE_gmfn, 0, 0); - xc_hvm_inject_msi(xc, 0, 0xf0000000, 0x00000000); - return 0; - } - #else #error invalid CONFIG_XEN_CTRL_INTERFACE_VERSION #endif -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:54:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:54:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520329.807814 (Exim 4.92) (envelope-from ) id 1pmfbj-0005EX-Tw; Wed, 12 Apr 2023 18:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520329.807814; Wed, 12 Apr 2023 18:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfbj-0005EQ-RL; Wed, 12 Apr 2023 18:54:15 +0000 Received: by outflank-mailman (input) for mailman id 520329; Wed, 12 Apr 2023 18:54:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfbi-0005EC-3F for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:54:14 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68b94743-d963-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:54:10 +0200 (CEST) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-504718a2282so3778162a12.0 for ; Wed, 12 Apr 2023 11:54:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68b94743-d963-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681325649; x=1683917649; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OCBM1eYOuCRMs+HWvFuj5wOCzBihsmjaSCKE5mxqFgI=; b=VXQdX4vyMY3Ts0kkSN2W7HmWqpWcjPqeqmESwkSYw/q+25N8hvpY4U6FCHolp/aSvK MNKlEndf4lQRDiitq6UIN/+34xz3Q7//qS6jjPrgY6j8IHZHoZJ3fOwKmuVDRlkTQ0jA xE7LoPfyFE5cmWTELrHJ5NIQ/1Q5ioX4YcfBW3IbzyXXMmLqaMDaQjndFk7+sXFoSz+A Mbusyjbo6iE+llpLR9OFKLxabubeD369SAwLc2bQfq8kh8o3gk/AhTStNyTVDXZ0THrE 4bGnZhRjZYE+yVpugd4VoPmQYiuTZGQlS6Gm1GePZxuvuniS954uRoeLQ0SOjiZpCHym HIrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681325649; x=1683917649; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OCBM1eYOuCRMs+HWvFuj5wOCzBihsmjaSCKE5mxqFgI=; b=jYg11YJFCJnni/WOkjUCBTQklHTkQHtQEF5yl3ITg4VTX9mFt5XJeg9215CwdVxi1Q vPKrzUPmR/D7MIMI9GZZaV5dqp0g5zySZDBfYuea9XWrI7kmDs6b0VK8Xd1OtgzBmOJh ygQ1pAaJ+6JTnYLnqhQAFwf54y9mAl3P5GrsHHeR9livBehiPqrnubmDcmLeG538n8sM ZwcHDs2ezBzYaRpcNRwbJcLgU9HqTYbF/bGMzhQx67QSKt+iokXJFiq/RZO96BruKXgu vPdT47vqm8BedrppLkc45BoH1obz3oEFB2le5NdABSUagrOmbt5iECq3xhy1NxYp+MSQ M8+g== X-Gm-Message-State: AAQBX9cqtmyd/xfFZZ9X8ngJnrTJPwrY5lEI3HrYKDgvUc/qgsYOMvZ3 q0K0os2eKEtcuCVI4ZBni+LCMe/EkR0Y9EAFJpTL+g== X-Google-Smtp-Source: AKy350YpkBKagCiorTlciXGC1XIYvr/Cp6SiNr9+jL2am6FQOLrXgpQ/KR800WHaG6IAXmEJFIDhvRUdZb691xauqlI= X-Received: by 2002:a50:9f65:0:b0:505:521:7880 with SMTP id b92-20020a509f65000000b0050505217880mr1382745edf.6.1681325649641; Wed, 12 Apr 2023 11:54:09 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-23-dwmw2@infradead.org> <92e10c45117dce9c07304a567fd412434ea0ddd3.camel@infradead.org> In-Reply-To: <92e10c45117dce9c07304a567fd412434ea0ddd3.camel@infradead.org> From: Peter Maydell Date: Wed, 12 Apr 2023 19:53:58 +0100 Message-ID: Subject: Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Wed, 12 Apr 2023 at 19:22, David Woodhouse wrote: > > On Tue, 2023-04-11 at 19:07 +0100, Peter Maydell wrote: > > > > > > > +static void xs_be_unwatch(struct qemu_xs_handle *h, struct > > > qemu_xs_watch *w) > > > +{ > > > + xs_impl_unwatch(h->impl, DOMID_QEMU, w->path, NULL, > > > xs_be_watch_cb, w); > > > > Coverity points out that this is the only call to xs_impl_unwatch() > > where we don't check the return value. Is there some useful way > > we can report the error, or is it a "we're closing everything down > > anyway, no way to report anything" situation? (This particular > > Coverity heuristic is quite prone to false positives, so if that's > > the way it is I'll just mark it as a f-p in the coverity UI.) > > This is because the Xen libxenstore API doesn't return an error, and > this is the ops function which emulates that same API. I suppose we > could explicitly cast to void with a comment to that effect, to avoid > having it linger in Coverity? I think that's sufficient to make > Coverity shut up, isn't it? I've just marked it a false-positive in the UI. Coverity's generally good at not resurfacing old false-positives, so don't bother changing the code unless you think it would improve clarity for a human reader. thanks -- PMM From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:55:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520333.807825 (Exim 4.92) (envelope-from ) id 1pmfcs-0005rH-6q; Wed, 12 Apr 2023 18:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520333.807825; Wed, 12 Apr 2023 18:55:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfcs-0005rA-49; Wed, 12 Apr 2023 18:55:26 +0000 Received: by outflank-mailman (input) for mailman id 520333; Wed, 12 Apr 2023 18:55:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfcr-0005r2-1b for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:55:25 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94c16079-d963-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 20:55:24 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-94a342ef3beso236757466b.0 for ; Wed, 12 Apr 2023 11:55:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94c16079-d963-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681325723; x=1683917723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V4pWJbzUQpY8EmvUozfn2vkGqj1/INMaAK1x13wucOs=; b=toMZkIj6jmJNXgvJM2iCJhd+tD4KlpE79RuzB12bmf2Vf6UYUICXsSC75ScnWgNUlp tNF09+6k1wHrTegGkF+f3yr7jQ460DjY/5MoH1XJXhPYVXFBWkltlvFLbpRHOS3TyzEy qNV0aH3PtcM/Ao9OvaQ6Lgo5RbfjMqNgHeaqznU2zrfidOotrI8elhxFU891tmc2KMWm IbeT3qpoGz+4emMfmcmeYbAj4t+ZGsD76hNBskqsfWYLEaDfiMkLgGmwEd5OsO+TXFF+ CIhidmHbcloULT6o0kItJmZYi1RglGW+MqFbeYMRkHQkYwjGDoJKusElTRbKQhNnEAZr tcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681325723; x=1683917723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V4pWJbzUQpY8EmvUozfn2vkGqj1/INMaAK1x13wucOs=; b=GL6hqq4UzbbhwAvUdlXLKto0Wy/hAKVhUiV4lv4e7w1kPeuKk3mWsA3UY5JqquUFzD jBOkmJV50vgdGET050kfNRlvDBRSkApZBebh13U45dfGEkxubApiGHh+JPYQ1dVlI/Gd J/LVUtUhM5ktfofjivFW/ZvS841ZsW4aAcmpNAj/nga9qTFgOLRhoVgsvHBwTqMydckU R/lvrewev5d5FIH20ihT/LxOAlEnDkxAYl+FGRKW0KOgVtANWlpKKd41XshuEySp3pWJ IwgW6GN0Xh5rghxcWfRNmsZtELNp5ez/xJK3VZdGZF+aUtcpwbHRTiya/VMoyOYccxoM JaUA== X-Gm-Message-State: AAQBX9dJ9oRx8hAkLHbNCkuDLJE+KgEm1oF0NvdFEqN2ar5B4vbyPyDZ GSeMqJairJj7tFYyb/+1yiCB+mmb7lFBDI7P/8/OXg== X-Google-Smtp-Source: AKy350brHiGejy7/I5Am1Uiea2aUHJKtqkhZKfRHYEYkw1NA/RSGTtjpBQnE8UYQsaFjrtq6Yg3S62pCjzMkAKOp+BA= X-Received: by 2002:a50:9f65:0:b0:505:521:7880 with SMTP id b92-20020a509f65000000b0050505217880mr1384308edf.6.1681325723523; Wed, 12 Apr 2023 11:55:23 -0700 (PDT) MIME-Version: 1.0 References: <20230412185102.441523-1-dwmw2@infradead.org> In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> From: Peter Maydell Date: Wed, 12 Apr 2023 19:55:12 +0100 Message-ID: Subject: Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes To: David Woodhouse Cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote: > > Some Coverity fixes and minor cleanups. And most notably, dropping > support for Xen libraries older than 4.7.1. > > I believe there are two issues that remain to be fixed. The x32 build > fails, and I've seen patches which attempt to detect x32 and disable > the Xen emulation. Along with assertions that we just shouldn't care. > I don't have a strong opinion either way but it seems to be in hand. > > The other is the question of what Xen *actually* does if you try to > unmap an IRQ_MSI_EMU PIRQ. I don't think Linux guests try that, and > I'm fairly sure Windows doesn't even use MSI=E2=86=92PIRQ mappings in the > first place, and I doubt any other guests care either. I'd like to > establish the 'correct' behaviour and implement it, ideally before > the 8.0 release, but it's going to take me a few days more. > > David Woodhouse (5): > hw/xen: Simplify emulated Xen platform init > hw/xen: Fix memory leak in libxenstore_open() for Xen > xen: Drop support for Xen versions below 4.7.1 > hw/xen: Fix double-free in xen_console store_con_info() > hw/xen: Fix broken check for invalid state in xs_be_open() > This is highly unlikely to make 8.0 at this point, FYI. If there's anything in this you think is super-critical we might be able to sneak it in. thanks -- PMM From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:57:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520337.807835 (Exim 4.92) (envelope-from ) id 1pmffD-0006RQ-Jp; Wed, 12 Apr 2023 18:57:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520337.807835; Wed, 12 Apr 2023 18:57:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmffD-0006RJ-GL; Wed, 12 Apr 2023 18:57:51 +0000 Received: by outflank-mailman (input) for mailman id 520337; Wed, 12 Apr 2023 18:57:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmffC-0006RB-6b for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:57:50 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eac0b8dd-d963-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:57:48 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-94a34a0fc1dso297428266b.1 for ; Wed, 12 Apr 2023 11:57:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eac0b8dd-d963-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681325868; x=1683917868; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mwuMRWTckpmHAxe9wcRRZwJ9PRGYotK6uPdDjaX47Hw=; b=UFvkjSNf07xqd6h81iyqZZVbdIKwVidmZpnv982GZosyT3wl3xhCoALO9/LDw45xnq 0vzZ7KxG3EtKzQgOX3qdBV0FRh+Qoxi+WvK2hFMxIdDaAszhRqaKgcSYYnL50ZjlSM4n gQQkYf0xVtuA+P5lWQTrymgcX2CxMzrqm75TY/dEFCchTk8RsyB5djPO2M0olMCkXTtu NRu5ImExgJ6ZVZi0c5PAOCgjTSJxejwJHKI4ekw4imu8ReQYQfpmqNjfAGEzQNxewuyQ meemcXyNP1InerS5KRghmuEGZE0+/ABLAQA1gcBDnrDwER+q2cZ1eO0IlLQwb1yRLqHC PFHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681325868; x=1683917868; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mwuMRWTckpmHAxe9wcRRZwJ9PRGYotK6uPdDjaX47Hw=; b=IDvjXLvadYmfSXRr8nFusoYhido4OKwQ5z3s6MSO3Wy2ouPoymhIkTYJ1wTDDHpLzP Mokc4Pszn9ep3AJb51bTXV0PZf8pjx+U6FEr6z8DyRiUMGjYQzun/4x5MmtUIkDO/lVi K4UUt0TesgqyAVZOzM28gnJ9SvI8kamtXAxMrjXKx2ZPoTVMsyLB1uBFGUa9j4bmtLGD Z3sshSeSDHfAsZhxnizAYlxrFIKr2Piu3OP3WbuhhkkRwLlUEvqVbSiyZ1y2TFlhmoHt BFY6Tqz/75CVWJsH6ivIZssxN2+wKhX5W7Dvf+Slfy5ZmoE+v9/bI0vZcKKT+nt4f6uu y4CQ== X-Gm-Message-State: AAQBX9d4JWqonS2y10Cj6nAlaPP/0bvzryQNNUlZhpzrG58VSZeEeIG2 Z76bkeaDCtnDxT4dspULVis7zxGO5MsTzgwAoGn8sw== X-Google-Smtp-Source: AKy350b4Tq5Y77eGxUkuJXiU9YL7lKJFcM6uLvpeqBXHaxWzpKfedPmHYoMDes2bLhYp48y7W4tZfu4nqa5bO2ofXBQ= X-Received: by 2002:a50:d71e:0:b0:504:9c1f:1c65 with SMTP id t30-20020a50d71e000000b005049c1f1c65mr6052761edi.6.1681325867781; Wed, 12 Apr 2023 11:57:47 -0700 (PDT) MIME-Version: 1.0 References: <20230412185102.441523-1-dwmw2@infradead.org> <20230412185102.441523-6-dwmw2@infradead.org> In-Reply-To: <20230412185102.441523-6-dwmw2@infradead.org> From: Peter Maydell Date: Wed, 12 Apr 2023 19:57:37 +0100 Message-ID: Subject: Re: [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open() To: David Woodhouse Cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote: > > From: David Woodhouse > > Coverity points out that if (!s && !s->impl) isn't really what we intended > to do here. CID 1508131. > > Fixes: 032475127225 ("hw/xen: Add emulated implementation of XenStore operations") > Signed-off-by: David Woodhouse > --- Reviewed-by: Peter Maydell thanks -- PMM From xen-devel-bounces@lists.xenproject.org Wed Apr 12 18:59:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 18:59:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520350.807844 (Exim 4.92) (envelope-from ) id 1pmfgr-00071l-To; Wed, 12 Apr 2023 18:59:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520350.807844; Wed, 12 Apr 2023 18:59:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfgr-00071e-RJ; Wed, 12 Apr 2023 18:59:33 +0000 Received: by outflank-mailman (input) for mailman id 520350; Wed, 12 Apr 2023 18:59:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfgr-00071Y-5T for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 18:59:33 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27f1d415-d964-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 20:59:31 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-94a4a898649so223231666b.2 for ; Wed, 12 Apr 2023 11:59:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27f1d415-d964-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681325970; x=1683917970; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rfKtPIZLyI/9kyv0UlHMQW/E9H0QfT6xiEL4AwLN9MA=; b=mMglum5fqjfiCG7dFKCTVMDKeWjPt0TTq66CTLfgOcTIRq7JNlX+ickLCdUi669e1C GvykWxqeZRdVcPEBFuaLBzprxK8efJXDWK0ryJAYraZLFjAzQuTcNgihiu3y8Fx/bG4j 0rzmVV9NZ3L9tRjU48S01OFPLBEvTA+LKl6YHEPLWriBH+1tPJgDqdYtTke4wSdh+r9C 8DfQGztPQfD+wDrkiDMBUSf8MMat4W6chryhuxWCWg+c3wB2Gqg0GUzKQ33dI7R+UAw8 hF6bbkEFmyJCS68UEPqY9ywQvXP/TlWXQnICcXyZxL51Y4Ci/px0t40bjvEqXu3wrtp9 nPQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681325970; x=1683917970; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rfKtPIZLyI/9kyv0UlHMQW/E9H0QfT6xiEL4AwLN9MA=; b=V+TA7Pq+nl/Nv4HVoqPyZRsY4rkeiapBdL/KpFioCKejtBd04LoqZs72mmcLQRACcl m+9CDagf18GajogAfExcVFwXFUL85/0JagNjCZQlm9KCtST66+PrBKgtM+bbvz0OQeYL UoRMOqNrk9NgWEFBPx11o3bpBm3yYs1er5NU6A5Mnwmbs1NojUXuaNmAyoWJHwvuPYD1 LBCqZ/z+n8/1TRef6w+jaJQhDpcq3k6u4yEOjWw72l0ShaZcBmc6oQinp9mhSh4qURRn SHu883ZC4dgiW1CTHKkL8BuSQHpqkreMyYfEQlBw2MvPgJp6ynaW8H1mn2HbfDuiBkIp zkVg== X-Gm-Message-State: AAQBX9dfpe2p9Wa+UY3zkA/jpbrk7eO0IqO2RAhj1Q7PAGLMQlEqHtNO eXo7FX+3Glz3DZbnVJ16vAyfYRzq2n/vbmhWFm8MkQ== X-Google-Smtp-Source: AKy350axA4G9jLT9eVbrgGwoJ8edxXEnerhD+zot/u3c030bUJZC7VGQJkI6O/FFhxjTF6mlsmSnzBPsK6fIIXKEV88= X-Received: by 2002:a50:cd42:0:b0:506:6ca5:3128 with SMTP id d2-20020a50cd42000000b005066ca53128mr82975edj.6.1681325970501; Wed, 12 Apr 2023 11:59:30 -0700 (PDT) MIME-Version: 1.0 References: <20230412185102.441523-1-dwmw2@infradead.org> <20230412185102.441523-5-dwmw2@infradead.org> In-Reply-To: <20230412185102.441523-5-dwmw2@infradead.org> From: Peter Maydell Date: Wed, 12 Apr 2023 19:59:19 +0100 Message-ID: Subject: Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info() To: David Woodhouse Cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote: > > From: David Woodhouse > > Coverity spotted a double-free (CID 1508254); we g_string_free(path) and > then for some reason immediately call free(path) too. > > We should just use g_autoptr() for it anyway, which simplifies the code > a bit. > > Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to xen_console.c") > Signed-off-by: David Woodhouse Reviewed-by: Peter Maydell thanks -- PMM From xen-devel-bounces@lists.xenproject.org Wed Apr 12 19:01:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 19:01:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520354.807854 (Exim 4.92) (envelope-from ) id 1pmfj2-0008T6-9t; Wed, 12 Apr 2023 19:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520354.807854; Wed, 12 Apr 2023 19:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfj2-0008Sz-6p; Wed, 12 Apr 2023 19:01:48 +0000 Received: by outflank-mailman (input) for mailman id 520354; Wed, 12 Apr 2023 19:01:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfj0-0008St-Gs for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 19:01:46 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76bf6d42-d964-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 21:01:43 +0200 (CEST) Received: from [2001:8b0:10b:5:bf9d:c0ec:e079:876a] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmfik-00789I-P3; Wed, 12 Apr 2023 19:01:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76bf6d42-d964-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IPYtVkA5Vq0tNDE8dtZeWC5ZqapWHQVzVZtmTBnL1ZQ=; b=XepvWdNzPbSLUlexNxvVOu2U4m Tm0WKDGqScwiYlWMsZeeuXfPlrUT0kBVASk6XfXH0As4vYiNvucpCT6JQvD62Y3IDXKGr8D1Wjulj itbYwWJDWr+3ehhmLqDgTndJ0caf8HZ55qry3MIl/2Z1DhVF7cSQEYud6H3KHsFAzkgK+LUcoq3M6 91dfUjr3LGcsVyXZIU+RYCv+fW223GLJ6cqAWdmbq0WWVDWNgPS3ilW41Jt8vl+iAC/N3NmPAdEZo yWdhsQofAotmzmNnDa2Vv1YEEjYCjjJffc19BBZce/v6SMChVOlUO+Xzv9VJU/cQXs59WVjVOlpTJ XM22Jc9w==; Message-ID: Subject: Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes From: David Woodhouse To: Peter Maydell Cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , "Daniel P." =?ISO-8859-1?Q?Berrang=E9?= , Thomas Huth , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , xen-devel@lists.xenproject.org Date: Wed, 12 Apr 2023 20:01:29 +0100 In-Reply-To: References: <20230412185102.441523-1-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-hAPWpF3HBMdZEXQCQF5D" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-hAPWpF3HBMdZEXQCQF5D Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2023-04-12 at 19:55 +0100, Peter Maydell wrote: > On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote= : > >=20 > > Some Coverity fixes and minor cleanups. And most notably, dropping > > support for Xen libraries older than 4.7.1. > >=20 > > I believe there are two issues that remain to be fixed. The x32 build > > fails, and I've seen patches which attempt to detect x32 and disable > > the Xen emulation. Along with assertions that we just shouldn't care. > > I don't have a strong opinion either way but it seems to be in hand. > >=20 > > The other is the question of what Xen *actually* does if you try to > > unmap an IRQ_MSI_EMU PIRQ. I don't think Linux guests try that, and > > I'm fairly sure Windows doesn't even use MSI=E2=86=92PIRQ mappings in t= he > > first place, and I doubt any other guests care either. I'd like to > > establish the 'correct' behaviour and implement it, ideally before > > the 8.0 release, but it's going to take me a few days more. > >=20 > > David Woodhouse (5): > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Simplify emulated Xen platform i= nit > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Fix memory leak in libxenstore_o= pen() for Xen > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xen: Drop support for Xen versions below= 4.7.1 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Fix double-free in xen_console s= tore_con_info() > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Fix broken check for invalid sta= te in xs_be_open() > >=20 >=20 > This is highly unlikely to make 8.0 at this point, FYI. > If there's anything in this you think is super-critical we > might be able to sneak it in. Nothing is super-critical except maybe the double-free in store_con_info(). That could lead to a crash on startup if the QEMU Xen console is being used. --=-hAPWpF3HBMdZEXQCQF5D Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDEyMTkwMTI5WjAvBgkqhkiG9w0BCQQxIgQgmCpRZJqf 5qtPDua4xjlAYzxr8V2F4/r+0GhSfRSQgv0wgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAjDxyV8ymhUJRPPtLfucBwphBSYPC+XRaB Zf7Rzwa1OcB43p2gsFmEz8SmLlI2x7H1Q3cKxc/aExqWpL/KbRpfzya0DS+EEdcTRoPofl7E3JDv nMmzXCqhpj1BgN821wkEPuUzUDL7mXn/UxmzVKA7RE3hQG0BniXmcv9LNHfqdaMFiTyFRWnu3AiD E34qskQW5LqG1ggKo0Zgrf0e7ZgsYPj9XNihX6OUa/R7NDWspsqEZ0lLfAL+gSt4x1QmRLwsMWeN pVr+mC5olbu53Y/3vslknx3YvorAbY032JAdXR985PsGv/6TkMFLGS66sSLcVyQOiuxlwV1kBSbu owDVqBB8SRp0DztFvgnhztphrsEjdERd6zIctEkdebb3xedVdDIEgQ/DDXdVQ0+uCCqttHoc2H+E BBqeESkScIQpM3kccmy5Rp+xDQHGwuPWTUhcGS/h3Ej3V98hgzTHHsr/EJ6qnOwQpoefQYL8jtvR RpZWfdWpfOw47vx/4RjFFOEmjnvnyOSjZQuDnjZ8pRuN87A/dRRw/YHdY/NUX7Fz+3Vg+kv33knn 6qFcX0GsOJ1hbs6ajGcLYMFT0kDOlF9UQn54CU9dbPfCjsAiH66CLpVEp86hs8RjHXuGQ+j613RD VqaGfy7Gw+fUvPddqfsS+PBhFRn9zBYabjw3opAJXAAAAAAAAA== --=-hAPWpF3HBMdZEXQCQF5D-- From xen-devel-bounces@lists.xenproject.org Wed Apr 12 19:08:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 19:08:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520360.807865 (Exim 4.92) (envelope-from ) id 1pmfpV-0000nT-3G; Wed, 12 Apr 2023 19:08:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520360.807865; Wed, 12 Apr 2023 19:08:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfpV-0000nM-0R; Wed, 12 Apr 2023 19:08:29 +0000 Received: by outflank-mailman (input) for mailman id 520360; Wed, 12 Apr 2023 19:08:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmfpT-0000nE-Fe for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 19:08:27 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66e8884c-d965-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 21:08:26 +0200 (CEST) Received: from [2001:8b0:10b:5:bf9d:c0ec:e079:876a] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmfpI-0078TD-37; Wed, 12 Apr 2023 19:08:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66e8884c-d965-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mZoMi8L2CGkeUh70HowUzZy76uyvh1EHPMDqyJF+jSQ=; b=pt6tJNuxqio0xIzwCenSsPnkc0 mc2gGVIY72qbHxUQiSAlE3IolAcJZuJmDTFc/dJ64o0iveGkZamZ0noeuC02vRVc2S2bMREAD/tHP Swy58UEct7DWbpa6630gteGOTcDZXFYC/XjTq854kj2xgEMRNY56hg3Ke800BfbwDqeQTRvrIpbMv UPawFscf2h+n70N8Aak+3nH5aGHpZT3Rd462ovkAXUrpBLvTGd2bklcFidTOleabp2Fw70gWMABOC GD+3rVwwGA4OArTl4xe7mLEi2qWVja4DX3OXoPpx/YPUHXitz0mzdt0IlrGaXPGx7OTK0kOPjgpco LjEtet3g==; Message-ID: <43bd491a139a2dd8ade04927ba318b8988dda4e4.camel@infradead.org> Subject: Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes From: David Woodhouse To: Peter Maydell Cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , "Daniel P." =?ISO-8859-1?Q?Berrang=E9?= , Thomas Huth , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , xen-devel@lists.xenproject.org Date: Wed, 12 Apr 2023 20:08:14 +0100 In-Reply-To: References: <20230412185102.441523-1-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-xWkwo3ffcuylPKwCMhTB" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-xWkwo3ffcuylPKwCMhTB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2023-04-12 at 20:01 +0100, David Woodhouse wrote: > On Wed, 2023-04-12 at 19:55 +0100, Peter Maydell wrote: > > On Wed, 12 Apr 2023 at 19:52, David Woodhouse wro= te: > > >=20 > > > Some Coverity fixes and minor cleanups. And most notably, dropping > > > support for Xen libraries older than 4.7.1. > > >=20 > > > I believe there are two issues that remain to be fixed. The x32 build > > > fails, and I've seen patches which attempt to detect x32 and disable > > > the Xen emulation. Along with assertions that we just shouldn't care. > > > I don't have a strong opinion either way but it seems to be in hand. > > >=20 > > > The other is the question of what Xen *actually* does if you try to > > > unmap an IRQ_MSI_EMU PIRQ. I don't think Linux guests try that, and > > > I'm fairly sure Windows doesn't even use MSI=E2=86=92PIRQ mappings in= the > > > first place, and I doubt any other guests care either. I'd like to > > > establish the 'correct' behaviour and implement it, ideally before > > > the 8.0 release, but it's going to take me a few days more. > > >=20 > > > David Woodhouse (5): > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Simplify emulated Xen platform= init > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Fix memory leak in libxenstore= _open() for Xen > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xen: Drop support for Xen versions bel= ow 4.7.1 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Fix double-free in xen_console= store_con_info() > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw/xen: Fix broken check for invalid s= tate in xs_be_open() > > >=20 > >=20 > > This is highly unlikely to make 8.0 at this point, FYI. > > If there's anything in this you think is super-critical we > > might be able to sneak it in. >=20 > Nothing is super-critical except maybe the double-free in > store_con_info(). That could lead to a crash on startup if the QEMU Xen > console is being used. Although we could just do the one-liner that drops the extra 'free' instead of converting to g_autoptr. --=-xWkwo3ffcuylPKwCMhTB Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwNDEyMTkwODE0WjAvBgkqhkiG9w0BCQQxIgQgfyx9B51J Unl3bvNoUg9ozMJomlOgSsZyFejr9gfIKHIwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAF6H//9WMzgcw9g6Je+Lkmf6ddLx9+hM7S LsZlyyirMYEF4mlTfqxeDeUxFiz8ebjoW2PZZPcRJvLS/JLDveJf0v0s+/VqRrzCcXVH7PbzEb1D K47XmqL19c09GdAI9j/RFHkl83kREbZg2hubi+hs9dnPogsZoljm5N9jMfIJYw6fL04AaGdQEKlr vxn6P2bve+zUX6AYde54COGEjfHt0BRagjPICCqCVhEt+/jcxczHVus2wO90BYTW/cOf+q4tjd96 M4QxeE8c4g+mxGF/fIg0RYJzXkv2vjsMTuc3Y2rziKyo7J7BwFr4jaHg5AICdiyMboYfxerYpx6A Hnlz+oFH0bDFf0N3uXDOhqRFHKLLiOkNcDNLGMWqFgzanJ/Z9yQc3AAlMwUytuXVjnEUDxlBtNbD T4xNFyF7Nt2hS5/xmjEaSZINahJ1fdR1VifxSX1RAkXRY+8+JNLKrLcW1qeK/d9faYisCUzb56uv ShOK2YoOIeA2nSm7bQUCFiMCWhmBJIvWBSQsG1qDzGF+0+UXIsptAGeOo7GrtgxmpsVbX3pmOHGN SSAYCu4PVN60Ih+sb0mSqWsdjb8yqnlYxSKBPK+gbUBqwSWaK9WvMZBHpPnVJ5mXVa+64fpiX9l3 pFJdxdGbslx32eV7MWE3aNfos4l/FOt8iJ09UJTyoQAAAAAAAA== --=-xWkwo3ffcuylPKwCMhTB-- From xen-devel-bounces@lists.xenproject.org Wed Apr 12 19:23:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 19:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520364.807875 (Exim 4.92) (envelope-from ) id 1pmg3x-0003El-CM; Wed, 12 Apr 2023 19:23:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520364.807875; Wed, 12 Apr 2023 19:23:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmg3x-0003Ee-8V; Wed, 12 Apr 2023 19:23:25 +0000 Received: by outflank-mailman (input) for mailman id 520364; Wed, 12 Apr 2023 19:23:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmg3w-0003EU-Sc; Wed, 12 Apr 2023 19:23:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmg3w-0001wq-QG; Wed, 12 Apr 2023 19:23:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmg3w-0004Ln-Cp; Wed, 12 Apr 2023 19:23:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmg3w-0003My-CL; Wed, 12 Apr 2023 19:23:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uSmtsTWaov06wpgREGReyhxDchumTUqWKni7VZLnN/w=; b=gVajRp/esVobMnpGsWegXDRehT Be3KVIGkgKp5aCM0bHygbW3p8+lhfKWDJb5pzB7S+nqyatodzVrjJjLAJ/oz74Aps0KWA/b5UyEOA TRzjtnHiR8zgZhtCh/gHjJQaHyemDaAyBPXcTtgCr+uCicstIuoHaze0yV5PEfO/BZ3s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180221: all pass - PUSHED X-Osstest-Versions-This: ovmf=89520115b89d755ae79f61850c356aae4be2d9ad X-Osstest-Versions-That: ovmf=b991aec0509f24ae7573d732ba337549ecee310c From: osstest service owner Date: Wed, 12 Apr 2023 19:23:24 +0000 flight 180221 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180221/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 89520115b89d755ae79f61850c356aae4be2d9ad baseline version: ovmf b991aec0509f24ae7573d732ba337549ecee310c Last test of basis 180216 2023-04-12 07:13:37 Z 0 days Testing same since 180221 2023-04-12 12:11:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Benjamin Doron Sean Rhodes jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b991aec050..89520115b8 89520115b89d755ae79f61850c356aae4be2d9ad -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 12 20:04:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 20:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520370.807885 (Exim 4.92) (envelope-from ) id 1pmghM-0007fu-EQ; Wed, 12 Apr 2023 20:04:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520370.807885; Wed, 12 Apr 2023 20:04:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmghM-0007fn-Az; Wed, 12 Apr 2023 20:04:08 +0000 Received: by outflank-mailman (input) for mailman id 520370; Wed, 12 Apr 2023 20:04:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmghK-0007fh-GV for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 20:04:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmghJ-00039z-CT; Wed, 12 Apr 2023 20:04:05 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmghJ-0004cU-5q; Wed, 12 Apr 2023 20:04:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=rf55FNKq+3vzbc7Nnoy2CdPTLoMelHYpsXH6DzqDWIo=; b=vTNhmpSQZqXYkXD/IOY7ipUExn 1W1u0knuQaen6LdHmYmQR2pQewwqSSdlgpZOA4iksIaodBBzL9dDvtr9FfX4zFIyyPutN95D3A12u /ctLeufxH1xQrmU6iee82+N4IvU58IGZUz3QGb4/+wnwD0PqOCcsc/saOF5gN99YRkcA=; Message-ID: <4d4ecf63-dd07-439d-4fdf-85cebea05b29@xen.org> Date: Wed, 12 Apr 2023 21:04:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Andrew Cooper , zithro , xen-devel@lists.xenproject.org Cc: Juergen Gross , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> From: Julien Grall Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 In-Reply-To: <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 12/04/2023 17:05, Andrew Cooper wrote: > On 12/04/2023 4:48 pm, zithro wrote: >> Hi all, >> >> this is what I have in "xenstored-access.log" in dom0 : >> >> [20230411T23:48:27.917Z]  D5         write     control/feature-balloon 1 >> [20230411T23:48:27.917Z]  D5         error     EACCES >> [20230411T23:48:27.923Z]  D5         write     data/updated Wed Apr 12 >> 01:48:27 CEST 2023 >> >> It happens once each minute, on two different hosts, both amd64. >> (both hosts using the same config, only the hardware differs). >> >> I tried looking up for a similar bug, but didn't find one. >> I apologize in advance if this error is known, and if this is not the >> place to report this ! >> >> ----------------------- >> Technical infos >> ----------------------- >> dom0s: >> >> Debian stable, kernel 5.10.0-21-amd64 >> Xen 4.14.5 >> xl.conf has : autoballoon="0" >> GRUB_CMDLINE_XEN="dom0_mem=2048M,max:2048M dom0_max_vcpus=4 >> dom0_vcpus_pin loglvl=all guest_loglvl=all ucode=scan iommu=verbose" >> Running "xenstore-ls -f -p | grep balloon" returns no result >> ----------------------- >> domUs (D5 in above logs): >> >> HVM TrueNAS Core, based on FreeBSD 13.1-RELEASE-p7 >> (it happened also on previous FreeBSD realeases, but don't remember when >> it started, logs have been filled and rotated). >> In cfg files, using either the same value for "memory" and "maxmem" or >> only setting "memory" give the same results. >> >> What's strange is that I have xen* commands in FreeNAS : >> >> xen-detect        xenstore-control  xenstore-ls       xenstore-watch >> xenstore          xenstore-exists   xenstore-read     xenstore-write >> xenstore-chmod    xenstore-list     xenstore-rm >> >> root@truenas[~]# xenstore-ls >> xenstore-ls: xs_directory (/): Permission denied >> >> root@truenas[~]# ps aux >> root   [...]     0:36.98 [xenwatch] >> root   [...]     0:01.01 [xenstore_rcv] >> root   [...]     0:00.00 [balloon] >> root   [...]     0:01.74 /bin/sh /usr/local/sbin/xe-daemon -p >> /var/run/xe-daemon.pid >> [...] >> >> The xe-daemon looks strange also, I don't use XenServer/XCP-ng, only >> "raw" Xen. >> And this script which hand >> >> I also use PFsense domUs (based on FreeBSD), but they don't exhibit >> this behaviour (ie. no xenstore access error in dom0, no xen* >> commands in domU). >> >> So is this a problem with TrueNAS rather than with Xen ? >> If so I apologize for wasting your time. >> >> Thanks, have a nice day ! >> (and as it's my first post here: thx for Xen, it rocks) > > Hello, > > (Leaving the full report intact so CC'd people can see it whole) > > Yes, it is TrueNAS trying to re-write that file every minute.  It > appears that TrueNAS has inherited (from debian?) a rather old version > of https://github.com/xenserver/xe-guest-utilities/ > > https://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html doesn't > list feature-balloon as a permitted feature node. > > But, I suspect that it used to be the case that guests could write > arbitrary feature nodes, and I suspect we tightened the permissions in a > security fix to reduce worst-case memory usage of xenstored. From a brief look, this is very similar to the patch below that was sent 3 years ago. I bet no-one ever tested the driver against libxl. commit 30a970906038 Author: Vitaly Kuznetsov Date: Tue Sep 4 13:39:29 2018 +0200 libxl: create control/sysrq xenstore node 'xl sysrq' command doesn't work with modern Linux guests with the following message in guest's log: xen:manage: sysrq_handler: Error -13 writing sysrq in control/sysrq xenstore trace confirms: IN 0x24bd9a0 20180904 04:36:32 WRITE (control/sysrq ) OUT 0x24bd9a0 20180904 04:36:32 ERROR (EACCES ) The problem seems to be in the fact that we don't pre-create control/sysrq xenstore node and libxl_send_sysrq() doing libxl__xs_printf() creates it as read-only. As we want to allow guests to clean 'control/sysrq' after the requested action is performed, we need to make this node writable. Signed-off-by: Vitaly Kuznetsov Acked-by: Wei Liu diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 60676304e9b5..dcfde7787e2c 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -695,6 +695,9 @@ retry_transaction: GCSPRINTF("%s/control/feature-s4", dom_path), rwperm, ARRAY_SIZE(rwperm)); } + libxl__xs_mknod(gc, t, + GCSPRINTF("%s/control/sysrq", dom_path), + rwperm, ARRAY_SIZE(rwperm)); libxl__xs_mknod(gc, t, GCSPRINTF("%s/device/suspend/event-channel", dom_path), rwperm, ARRAY_SIZE(rwperm)); > > I suspect the best (/least bad) thing to do here is formally introduce > feature-ballon as a permitted node, and have the toolstack initialise it > to "" like we do with all other nodes, after which TrueNAS ought to be > able to set it successfully and not touch it a second time. +1. This would match how libxl already deal "feature-s3" & co. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Apr 12 20:09:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 20:09:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520374.807894 (Exim 4.92) (envelope-from ) id 1pmgmV-0008Hw-0n; Wed, 12 Apr 2023 20:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520374.807894; Wed, 12 Apr 2023 20:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmgmU-0008Hp-UJ; Wed, 12 Apr 2023 20:09:26 +0000 Received: by outflank-mailman (input) for mailman id 520374; Wed, 12 Apr 2023 20:09:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmgmU-0008Hj-33 for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 20:09:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb58dd50-d96d-11ed-b21e-6b7b168915f2; Wed, 12 Apr 2023 22:09:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4EF662F85; Wed, 12 Apr 2023 20:09:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46C3FC433EF; Wed, 12 Apr 2023 20:09:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb58dd50-d96d-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681330163; bh=8B2OVPHQHUwiNOLLrscY/I401k0vtxih3jLGGUDSZUk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=isH2hHlC7MKcTEpi3cvYBuFwSXm7bfi+7UtiCiSxRhJvoJrz1bZTtaEX878g9+FO8 ZZuTFhx3o0CydAnW4JtkqWFL/IS1rIea/bPm/69Vs72f5GTfYgCkanvHSEojuUtCNH rMrcizdGo05D0QTIVEWIKkSGHjIQv3z8oPVt4Lycz58HVAx5lRkqHPhYv4e/iemkm2 UlLe8bzNTJ4ztwDIZkYpmsVhIYNjFn8K47YZm3ZH4HZPnD7cai47soX5RIsO8wahf2 8KAX4BdpEqi/qDwiOJjWH7M9TZHYiwvHMtwpCOlCfl/WYt4Xo1QdQB0UTl5zmdDc2Y hnLqFZYN3h/Hw== Date: Wed, 12 Apr 2023 13:09:19 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: David Woodhouse cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes In-Reply-To: <20230412185102.441523-1-dwmw2@infradead.org> Message-ID: References: <20230412185102.441523-1-dwmw2@infradead.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 Apr 2023, David Woodhouse wrote: > Some Coverity fixes and minor cleanups. And most notably, dropping > support for Xen libraries older than 4.7.1. I just wanted to say that I am fine with this From xen-devel-bounces@lists.xenproject.org Wed Apr 12 20:14:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 20:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520378.807904 (Exim 4.92) (envelope-from ) id 1pmgrT-0001Hd-Jd; Wed, 12 Apr 2023 20:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520378.807904; Wed, 12 Apr 2023 20:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmgrT-0001HW-Gp; Wed, 12 Apr 2023 20:14:35 +0000 Received: by outflank-mailman (input) for mailman id 520378; Wed, 12 Apr 2023 20:14:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmgrS-0001HQ-7v for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 20:14:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a292907b-d96e-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 22:14:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D2B763232; Wed, 12 Apr 2023 20:14:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4BA9C433EF; Wed, 12 Apr 2023 20:14:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a292907b-d96e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681330470; bh=Nuluv8nBOkGlpny4WJ71/qwluqzH+ARqb7rxaDBOxIQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Tg6RQ7lPQa6yC5/X/KzV4OMvhJChlXUxBtjOpEH7+R2nXAzM2be3HC8AfF9OBjJqg nl3pLN26fPrlyX80s8elIMSGSKON9MMigQydFBNh036wqXpGTo+3jfY8uQTVmZpOzL tiduPIwDi5qH6BeP0f32VYwAr54/KLm2QAZrTbE08FTf+I/KSq+/fsqGYk6BqRRrL9 1UrhcDWssyQgYjLw3YGw3HttltKmzsSNjjohdeVGtve2Gfuk8fn3UIW16ecEXysPqt 3bsdExDzVRhNZPzKI298AAjeqF6XBloTF4iBeDQZ0+M5PygnfYdXYmjun6pQOODLYW BbTetaWnMqlbg== Date: Wed, 12 Apr 2023 13:14:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Michal Orzel Subject: Re: [PATCH] CI: Update FreeBSD to 13.2 In-Reply-To: <20230412183356.2986459-1-andrew.cooper3@citrix.com> Message-ID: References: <20230412183356.2986459-1-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-2103527278-1681330470=:15580" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2103527278-1681330470=:15580 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 12 Apr 2023, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Acked-by: Stefano Stabellini > --- > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Michal Orzel > > Successful run: > https://cirrus-ci.com/task/6232358978846720 > --- > .cirrus.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.cirrus.yml b/.cirrus.yml > index b133afb74057..9bb6cce4ead3 100644 > --- a/.cirrus.yml > +++ b/.cirrus.yml > @@ -23,7 +23,7 @@ task: > task: > name: 'FreeBSD 13' > freebsd_instance: > - image_family: freebsd-13-1 > + image_family: freebsd-13-2 > << : *FREEBSD_TEMPLATE > > task: > -- > 2.30.2 > --8323329-2103527278-1681330470=:15580-- From xen-devel-bounces@lists.xenproject.org Wed Apr 12 20:47:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 20:47:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520383.807915 (Exim 4.92) (envelope-from ) id 1pmhNJ-0004kt-6H; Wed, 12 Apr 2023 20:47:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520383.807915; Wed, 12 Apr 2023 20:47:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmhNJ-0004km-32; Wed, 12 Apr 2023 20:47:29 +0000 Received: by outflank-mailman (input) for mailman id 520383; Wed, 12 Apr 2023 20:47:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmhNH-0004kc-Dr; Wed, 12 Apr 2023 20:47:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmhNH-0004IL-Au; Wed, 12 Apr 2023 20:47:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmhNG-00013E-M8; Wed, 12 Apr 2023 20:47:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmhNG-0004w6-Lk; Wed, 12 Apr 2023 20:47:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+b5x3DWwpcqjB/9g9IEackBZQAJwKEq6ChyW9mjFfoo=; b=WgEvcRKPncAt1u3N9fKDazGabs GDgaplnXJrDsIACdzm0+lroOz4J/UyxSDVH57ZjWsx3ueXEPyX68nmjEFs0LQkYJaKwEew3uKcOTQ 8ytJMnwR0WDQ8CxdLvvukdbTpymIkky2CtvVOkHoZDxcw3cDtRVXNQpb1raxmL4YwBdQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180213: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=7e1b4cc19cefba11763d09799f2b742658a9a03a X-Osstest-Versions-That: libvirt=7eead248c65f336afd9fd57ddcfe9e182cf30a6d From: osstest service owner Date: Wed, 12 Apr 2023 20:47:26 +0000 flight 180213 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180213/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 7e1b4cc19cefba11763d09799f2b742658a9a03a baseline version: libvirt 7eead248c65f336afd9fd57ddcfe9e182cf30a6d Last test of basis 180176 2023-04-07 04:18:49 Z 5 days Testing same since 180213 2023-04-12 04:20:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Krempa Remus-Gabriel Chelu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 7eead248c6..7e1b4cc19c 7e1b4cc19cefba11763d09799f2b742658a9a03a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 12 21:36:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 21:36:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520389.807925 (Exim 4.92) (envelope-from ) id 1pmi93-0001b3-QA; Wed, 12 Apr 2023 21:36:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520389.807925; Wed, 12 Apr 2023 21:36:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmi93-0001aw-N4; Wed, 12 Apr 2023 21:36:49 +0000 Received: by outflank-mailman (input) for mailman id 520389; Wed, 12 Apr 2023 21:36:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmi92-0001am-01; Wed, 12 Apr 2023 21:36:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmi91-0005ZX-TU; Wed, 12 Apr 2023 21:36:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmi91-00033J-CT; Wed, 12 Apr 2023 21:36:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmi91-0006wH-C5; Wed, 12 Apr 2023 21:36:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GZgkiwoKGHEopYJwhWrhHdliT63KV7XQXMNuoYtFrhk=; b=Dj0kqyuvqjpUhOmvAUndUC+TM5 xsHtFx/6YtKFWR+PsFQhu6Ybyq2El0mWoRxfv33C+R/H4mPrCUDVNbcZ1qHTB/YfS9Mv0IKAac7Fc uloO/AwcaUwGBZ+z5OX1Uep7+etPbpzrIXDHhw8oHg/oaTqUEkvy+zTeTMokqTPRaH2I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180223: all pass - PUSHED X-Osstest-Versions-This: ovmf=5430f7f60dee3747fff906b48718db8afb4589d9 X-Osstest-Versions-That: ovmf=89520115b89d755ae79f61850c356aae4be2d9ad From: osstest service owner Date: Wed, 12 Apr 2023 21:36:47 +0000 flight 180223 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180223/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5430f7f60dee3747fff906b48718db8afb4589d9 baseline version: ovmf 89520115b89d755ae79f61850c356aae4be2d9ad Last test of basis 180221 2023-04-12 12:11:24 Z 0 days Testing same since 180223 2023-04-12 19:43:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jeff Brasen Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 89520115b8..5430f7f60d 5430f7f60dee3747fff906b48718db8afb4589d9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Apr 12 21:54:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 21:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520397.807935 (Exim 4.92) (envelope-from ) id 1pmiQJ-0003z3-Be; Wed, 12 Apr 2023 21:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520397.807935; Wed, 12 Apr 2023 21:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmiQJ-0003yw-8c; Wed, 12 Apr 2023 21:54:39 +0000 Received: by outflank-mailman (input) for mailman id 520397; Wed, 12 Apr 2023 21:54:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmiQH-0003yq-Aw for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 21:54:37 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ade299c-d97c-11ed-8611-37d641c3527e; Wed, 12 Apr 2023 23:54:32 +0200 (CEST) Received: from pps.filterd (m0174678.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33CGB4kA030903; Wed, 12 Apr 2023 21:54:18 GMT Received: from eur02-vi1-obe.outbound.protection.outlook.com (mail-vi1eur02lp2049.outbound.protection.outlook.com [104.47.11.49]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3pwrwhatfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 21:54:17 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by DB9PR03MB7273.eurprd03.prod.outlook.com (2603:10a6:10:22f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 21:54:12 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3%3]) with mapi id 15.20.6298.030; Wed, 12 Apr 2023 21:54:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ade299c-d97c-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6GLVl387ZrE80wvyItqIgZ+yYpRggbraWYA6bT3tPwZrRdZnLoC9xoOXXZMquiTCQWrnUvqgNi5kneD3VO1KTJVn1dKDiiqRTFYJZv50nROoZhCSbi/9BrhrV2I/PKg3ctUoe67dnMev7JN0zbietpzkfaTiskFp2oIJCV9pBnQuu+H9v8FtWyPLJTsfN5bZxa41bpEgsHlNMzZz/s2AwrSowwS7cHLLS1EllJ04ITAi+nxYf3LVBBV1Zpdtf5eZMRyILCvWnLe3TJj3R00gysxNcAJdhrw4xofQRs0qabvDJno5K4sTCxiCnSP/mHMApgL3jBfdYaMdomfCE6DhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hlxlCw/RFtXuleUg42Tg0KKb8+9yk2ViQOEkqs2gl2A=; b=O66MBguRLmkJzvATzeV1d3RI6xykDI6Fr8HK702aPL1qPnWPmrnKOvE9wF++E3jk2pARgnq4/BG/Xf/eBuqqGTU5fYMvZQbydJWrC5L9cesa0yOWhHU3koicYiloBS/cdC7JHBteEwKbZQZLkTRhaQlqjmnHHa8U+nHvBo+F6+1yW31y7xs6E0DaNTAxLq6gLtpoOhRZ9y+HVlaOeKDXvuFUmbzTMStZwEey0Bx6NGvikSVefcuyMeKlXSDrW9WW9WTsgcoH3jrfrkbkrTp99lzssUZHti6SQBp0pnQEBamfgTxXmcXduj/IAScCVoNiX6n/qD3AvaNyDCNAk0/b5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hlxlCw/RFtXuleUg42Tg0KKb8+9yk2ViQOEkqs2gl2A=; b=NQOIXr4UojOVy65+omauUceM4kKsWVuwb/9dQlOt3T0WcJXFl2Ge8xMlXsI7d0s35UqeXX+h3sgHpurce/wUkk17jzqPs3xZuh4oPYciqfgCoEf95xg+BHTcQiV6+1bx9+z4DhVmr5TeiTzJmw7c93F3BipTczLYiwiMKhpHHHHOQnAURiKJ0ZimVqXzFhOqT/iudF0a8/fwJHxqKLg3NUGVLWT6CmNH1eXA9WnfOJsUrqU1Rtolys0NFyNjOlEYt72735f22Ot9oKWQ92PzY2ZSHmL/L6Tgr45EgAmIyGM7EGOBPmfhRqu62UF5w+8kyhJrUaQX3j1HLN6pBuR0mQ== From: Volodymyr Babchuk To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: "xen-devel@lists.xenproject.org" , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Kevin Tian Subject: Re: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Thread-Topic: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Thread-Index: AQHZVrdzsdckomMx4kauxHkZQ597Iq79mAMAgClI2ACAAK/igIAAVGGA Date: Wed, 12 Apr 2023 21:54:12 +0000 Message-ID: <87v8i0wyv0.fsf@epam.com> References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-3-volodymyr_babchuk@epam.com> <873556xa0g.fsf@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|DB9PR03MB7273:EE_ x-ms-office365-filtering-correlation-id: 5b1d0827-00f8-46f8-d438-08db3ba073ca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zQUakqcvCwF65m8IKsS+ihj1nBvJUJgm30uuPDY4di74TjDy+qptEGHuB3d6vCCpTWz+g5S7QobjWGyksc9Bi+BjYt+lANOsegsuMXt+mwlZYRMm8zZm4irenjT5XPBkVirYfJjKFisYfLtxKYwSB7T4/osa3Qj+PDBcZOUeRiZRQF62txgpJghWjQDU0qZTZhFr/ttXQbnt0gvNNHcpHxZfT6oN8HHe7Z8bgBd1+v4lJGJSO/YMKgx0Mnc5EAZfc7zHFsFMmQhy4eVow+XLUAPoXJyTJRAZaY19Fo0/JS4M2y3EFXyUnfXTrAK+9QEv/VKXRsoCm93aX/MmOOjV3b54r8+4mfSnwT7AmUyclynCL9AIyy8CnwHMkc26HMkuCsYkD1/G202rd5YY8i2KKNkmvkljKLYCH2HCmWMn9N/auKkxy5qlYDBEGyY0iD1sHZfuLXD+BR2dHsNV54GfJO7rUBGswKPHx9gvQIK3GLvxmEla0YDUswdtuGv8yC0mVwt40AX8Gfw9Dg1AUj8uFV0dxcbFwROCSAY/wA9TxeM7G1fzrZ0I9JWshe2MLeNL8Maj03zno+IPuF4QidBlZKt/y94JLpv4KEhSCEeHAnw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(346002)(136003)(396003)(376002)(451199021)(316002)(54906003)(6916009)(4326008)(91956017)(76116006)(66946007)(66476007)(64756008)(966005)(66446008)(66556008)(6486002)(71200400001)(478600001)(5660300002)(8676002)(8936002)(41300700001)(7416002)(30864003)(36756003)(122000001)(2906002)(38070700005)(86362001)(38100700002)(83380400001)(2616005)(26005)(55236004)(6506007)(6512007)(186003)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZndaT3FhSXdBRUNiSHZoVThNcGY1WmM4SUZNZlJ6anE1aUlURitoRVoveTE3?= =?utf-8?B?TTdwT1RaY2tGMVdRQko0ZTNPWU9IODV6c3N2bm96UldkL2NLRWljM0hsb0Z6?= =?utf-8?B?VVA2MEJkL0UwNTVvWDJ6QVFyM0Q4TEQ1V1NwSjJKOHBNUHRHb0ZwY28wMldv?= =?utf-8?B?SXk2RmlrMnJERm05NUhwNUFVdi9CUW1mQnZmT2hTaHRFcENkMVIxV2pFdDJX?= =?utf-8?B?MjhMeGx6QmIvcDE4eGFKeWhUTXpHa1pEQXQ0VStPU0drb0JhVGFFUUp4MHJH?= =?utf-8?B?MzA0WWtnQWFkSUtJV2pWbm5ZaFZaRmsrUTNsUGdPSWEyWFVRNWkxT05yTXM5?= =?utf-8?B?S0RqbExlKzk2Z0cvWGJtV2NNT3c2TGVnQnIzSDlsd25xY2NPN2lXd053MXZM?= =?utf-8?B?cHpXamNmSExuZUkrdWxZME1uQ0dpcmk3di8wakhzQlNHS0FER2VDR2dkQlp0?= =?utf-8?B?V2RoUmxkanBQRm5aeDc4bUdjMmRBd1VkTUxwWWdEcldmcUpEamNndVlqL3o2?= =?utf-8?B?d3kzS1lHZ1Fsd24vczRUd2xxKzljQW05QTB2bVY4dE5Td2xGb3g3TFNCczNT?= =?utf-8?B?Ly9BRzlTVG5QOVNRNUZuSGJlL25Lamc2NG5ISEJja1kzdTdHUFNLY25FbHUx?= =?utf-8?B?NkNOMDJ5UG1CSUZhMlhieTg2VzNlSHNWQldFN2ZaSFBNdXBQY0lyS1p4WVRi?= =?utf-8?B?cGtBR2paS2syUEdBZWlMOWFla1gwUStxb0VTQUN2a0JpL1VzVFZ3MnViYXU3?= =?utf-8?B?cE5DSDJPK1FtYkNBcmdvSGRiYVlId1dLaVlNTEh4Umo4a3VGVzUwcGswVGlS?= =?utf-8?B?dzhMMmoxT3RPYStkUFlnMWJ2emYvakJCbkFGbmdSSU4rU2d3QVd5NFlxVEda?= =?utf-8?B?WEltZzFua1lPTjFvWS96WCt6dXF1TzhDR3JrS0I2dWlsbWJwUlNtZ01SeUpl?= =?utf-8?B?VTVDSVJHYTRDdmk1K21OMzhYSE1RVWd5eDVIMTFleFBubmdiRnAzL2xmZk1V?= =?utf-8?B?c0FnK3RsVnhxaUpiUm5NbUprSUpJR25mZk1UdGZ1KzdsTUY3YUkxOUNyTmx6?= =?utf-8?B?TjVQcnNRQm0zTG0yZmVKMncxcGhaKzBLVjljYVZ0eEo0OHBySGc4TytwdlhT?= =?utf-8?B?K09ySThSNExueWxGWGNEcy8vcTlRYjhWUnlKbHQ2Tml1bTVtNGc0akZBeGU2?= =?utf-8?B?TTJNVVBWREVBYzZNMnZjcHdxMzdUMXFlT2xUckFMSXRqTHR5NnZ3dkpBeUtv?= =?utf-8?B?MmpVN1ZlMnJmU1haWFpXK3ZlVWg2ZWkvRXdPTWJseUVadWRXYjkzYW5CQjAy?= =?utf-8?B?UXFhTlBEYVVPVWJrMGpEK1VkRWZBSjc0WVFEK1B6WGxqc2lLbGRPQUZTKzd5?= =?utf-8?B?Z2pyaXR4UFo2aHRpekt1Q01zcUdRdVlPaGdqZWZ0djFFNUZ3N083bHJGTWdM?= =?utf-8?B?WjByMWp6NjB6T1h5Qll1b0Q1THpKY3NJOUlIT29pVnZ2eWp6VGc5a3oyLzVl?= =?utf-8?B?Q2wwN2FwZC8zR29kQlRNVDdRQW02elloRHFHbDg2blJHblV4cUFHaU5kdU45?= =?utf-8?B?cWk2UWhodDNaQjZHODJZSW9LVis3OGsrS2xOWXRMQUJqMzhacm9VM0ZmTWx0?= =?utf-8?B?OHVOclZ6R3lIMjRiclNNTnNETTh6TG56Zml3ZGpHMktxSndKZTA0WjkwMk1t?= =?utf-8?B?d014SzQ0c2FMZ3c2MlgyZUJRY1d0Y1RCY3NIaW1YcWpTeUFoNmx0L3VwUmpQ?= =?utf-8?B?OWRiMWNFbkFOdnZpczZ0aGVhZDhYM1MvVjEweFl2TGhBUndtSEdrRk9rWG9I?= =?utf-8?B?TDc4TVc3MXdvcjNMMzFFeHVoZS9lcEp5c3NRbFIvdVpSdzVFZWZwRUlJWFAw?= =?utf-8?B?QXRGcnNVb05FTFdiMGRhQ2tZb3FRallMbXZYS2JiSVVtV0NjNmpOTTJ1UTBX?= =?utf-8?B?YUxhQytrWFl1RjZjcUJXanhHYkYwUjRTQ2dXZXVhYWdza0xGbjZWMVhyRlVH?= =?utf-8?B?bUkzTWE2dngzVGtZeU9IU2RYZ2NCQjJmQUZ5L1J3MGRVaTIybldJMmlKUnln?= =?utf-8?B?N0Rsenk4aXVES1ZVZFkvNG9QSVV6cm5pKzVhbmlZRFErem5kSHQ3WTdseG9O?= =?utf-8?B?M0g0eGg4Y2ZhNlpyUURPZ0ZTRkI4U29OQnp4Kzh3ODZieFlUckVYZHljR281?= =?utf-8?B?bXc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <7AA23B5AD2C5324CAAF5852778763AF9@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b1d0827-00f8-46f8-d438-08db3ba073ca X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 21:54:12.6334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d7XdYb4w4kHdoLPzVQS+5pvrEmkQVfp0eCvkkd5nzwPWX0ryIg66R6kldTZ2w4j+1du62jEBI41nkyNpCyXTem/B/cB3kTQ21K/RlsVFVRU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7273 X-Proofpoint-ORIG-GUID: o3vUuPCoyRd1aiAp6Zk_FFOMh1K8xJwC X-Proofpoint-GUID: o3vUuPCoyRd1aiAp6Zk_FFOMh1K8xJwC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-12_12,2023-04-12_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1011 bulkscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304120186 DQpIaSBSb2dlciwNCg0KRmlyc3Qgb2YgYWxsLCBJIHdhbnQgdG8gcHJvdmlkZSBsaW5rIFsxXSB0 byB0aGUgUkZDIHNlcmllcyB3aGVyZSBJIHRyaWVkDQp0b3RhbCBQQ0kgbG9ja2luZyByZXdvcmsu IEFmdGVyIGRpc2N1c3Npbmcgd2l0aCBKYW4sIGl0IGJlY2FtZSBjbGVhciBmb3INCm1lLCB0aGF0 IHRhc2sgaXMgbXVjaCBoYXJkZXIsIHRoYW4gSSBhbnRpY2lwYXRlZC4gU28sIGl0IHdhcyBkZWNp ZGVkIHRvDQptb3ZlIHdpdGggYSBzbWFsbGVyIHN0ZXBzLiBGaXJzdCBzdGVwIGlzIHRvIG1ha2Ug dlBDSSBjb2RlIGluZGVwZW5kZWQNCmZyb20gdGhlIGdsb2JhbCBQQ0kgbG9jay4gQWN0dWFsbHks IHRoaXMgaXMgbm90IHRoZSBmaXJzdCB0cnkuDQpPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB0cmll ZCB0byB1c2Ugci93IGxvY2sgZm9yIHRoaXM6IFsyXS4gQnV0LA0KSmFuIHN1Z2dlc3RlZCB0byB1 c2UgcmVmY291bnRpbmcgaW5zdGVhZCBvZiByL3cgbG9ja3MsIGFuZCBJIGxpa2VkIHRoZQ0KaWRl YS4gU28sIHRoaXMgaXMgd2h5IHlvdSBhcmUgc2VlaW5nIHRoaXMgcGF0Y2ggc2VyaWVzLg0KDQoN Cg0KUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyaXRlczoNCg0KPiBP biBUdWUsIEFwciAxMSwgMjAyMyBhdCAxMTo0MTowNFBNICswMDAwLCBWb2xvZHlteXIgQmFiY2h1 ayB3cm90ZToNCj4+IA0KPj4gSGkgUm9nZXIsDQo+PiANCj4+IFJvZ2VyIFBhdSBNb25uw6kgPHJv Z2VyLnBhdUBjaXRyaXguY29tPiB3cml0ZXM6DQo+PiANCj4+ID4gT24gVHVlLCBNYXIgMTQsIDIw MjMgYXQgMDg6NTY6MjlQTSArMDAwMCwgVm9sb2R5bXlyIEJhYmNodWsgd3JvdGU6DQo+PiA+PiBQ cmlvciB0byB0aGlzIGNoYW5nZSwgbGlmZXRpbWUgb2YgcGNpX2RldiBvYmplY3RzIHdhcyBwcm90 ZWN0ZWQgYnkgZ2xvYmFsDQo+PiA+PiBwY2lkZXZzX2xvY2soKS4gTG9uZy10ZXJtIHBsYW4gaXMg dG8gcmVtb3ZlIHRoaXMgbG9nLCBzbyB3ZSBuZWVkIHNvbWUNCj4+ID4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXiBsb2NrDQo+PiA+DQo+PiA+IEkg d291bGRuJ3Qgc2F5IHJlbW92ZSwgYXMgb25lIHdheSBvciBhbm90aGVyIHdlIG5lZWQgYSBsb2Nr IHRvIHByb3RlY3QNCj4+ID4gY29uY3VycmVudCBhY2Nlc3Nlcy4NCj4+ID4NCj4+IA0KPj4gSSds bCB3cml0ZSAicmVwbGFjZSB0aGlzIGdsb2JhbCBsb2NrIHdpdGggY291cGxlIG9mIG1vcmUgZ3Jh bnVsYXINCj4+IGxvY2tpbmcgZGV2aWNlcyINCj4+IGlmIHRoaXMgaXMgb2theSBmb3IgeW91Lg0K Pj4gDQo+PiA+PiBvdGhlciBtZWNoYW5pc20gdG8gZW5zdXJlIHRoYXQgdGhvc2Ugb2JqZWN0cyB3 aWxsIG5vdCBkaXNhcHBlYXIgdW5kZXINCj4+ID4+IGZlZXQgb2YgY29kZSB0aGF0IGFjY2VzcyB0 aGVtLiBSZWZlcmVuY2UgY291bnRpbmcgaXMgYSBnb29kIGNob2ljZSBhcw0KPj4gPj4gaXQgcHJv dmlkZXMgZWFzeSB0byBjb21wcmVoZW5kIHdheSB0byBjb250cm9sIG9iamVjdCBsaWZldGltZS4N Cj4+ID4+IA0KPj4gPj4gVGhpcyBwYXRjaCBhZGRzIHR3byBuZXcgaGVscGVyIGZ1bmN0aW9uczog cGNpZGV2X2dldCgpIGFuZA0KPj4gPj4gcGNpZGV2X3B1dCgpLiBwY2lkZXZfZ2V0KCkgd2lsbCBp bmNyZWFzZSByZWZlcmVuY2UgY291bnRlciwgd2hpbGUNCj4+ID4+IHBjaWRldl9wdXQoKSB3aWxs IGRlY3JlYXNlIGl0LCBkZXN0cm95aW5nIG9iamVjdCB3aGVuIGNvdW50ZXIgcmVhY2hlcw0KPj4g Pj4gemVyby4NCj4+ID4+IA0KPj4gPj4gcGNpZGV2X2dldCgpIHNob3VsZCBiZSB1c2VkIG9ubHkg d2hlbiB5b3UgYWxyZWFkeSBoYXZlIGEgdmFsaWQgcG9pbnRlcg0KPj4gPj4gdG8gdGhlIG9iamVj dCBvciB5b3UgYXJlIGhvbGRpbmcgbG9jayB0aGF0IHByb3RlY3RzIG9uZSBvZiB0aGUNCj4+ID4+ IGxpc3RzIChkb21haW4sIHBzZWcgb3IgYXRzKSB0aGF0IHN0b3JlIHBjaV9kZXYgc3RydWN0cy4N Cj4+ID4+IA0KPj4gPj4gcGNpZGV2X2dldCgpIGlzIHJhcmVseSB1c2VkIGRpcmVjdGx5LCBiZWNh dXNlIHRoZXJlIGFscmVhZHkgYXJlDQo+PiA+PiBmdW5jdGlvbnMgdGhhdCB3aWxsIHByb3ZpZGUg dmFsaWQgcG9pbnRlciB0byBwY2lfZGV2IHN0cnVjdDoNCj4+ID4+IHBjaV9nZXRfcGRldigpLCBw Y2lfZ2V0X3JlYWxfcGRldigpLiBUaGV5IHdpbGwgbG9jayBhcHByb3ByaWF0ZSBsaXN0LA0KPj4g Pj4gZmluZCBuZWVkZWQgb2JqZWN0IGFuZCBpbmNyZWFzZSBpdHMgcmVmZXJlbmNlIGNvdW50ZXIg YmVmb3JlIHJldHVybmluZw0KPj4gPj4gdG8gdGhlIGNhbGxlci4NCj4+ID4+IA0KPj4gPj4gTmF0 dXJhbGx5LCBwY2lfcHV0KCkgc2hvdWxkIGJlIGNhbGxlZCBhZnRlciBmaW5pc2hpbmcgd29ya2lu ZyB3aXRoIGENCj4+ID4+IHJlY2VpdmVkIG9iamVjdC4gVGhpcyBpcyB0aGUgcmVhc29uIHdoeSB0 aGlzIHBhdGNoIGhhdmUgc28gbWFueQ0KPj4gPj4gcGNpZGV2X3B1dCgpcyBhbmQgc28gbGl0dGxl IHBjaWRldl9nZXQoKXM6IGV4aXN0aW5nIGNhbGxzIHRvDQo+PiA+PiBwY2lfZ2V0XyooKSBmdW5j dGlvbnMgbm93IHdpbGwgaW5jcmVhc2UgcmVmZXJlbmNlIGNvdW50ZXINCj4+ID4+IGF1dG9tYXRp Y2FsbHksIHdlIGp1c3QgbmVlZCB0byBkZWNyZWFzZSBpdCBiYWNrIHdoZW4gd2UgZmluaXNoZWQu DQo+PiA+DQo+PiA+IEFmdGVyIGxvb2tpbmcgYSBiaXQgaW50byB0aGlzLCBJIHdvdWxkIGxpa2Ug dG8gYXNrIHdoZXRoZXIgaXQncyBiZWVuDQo+PiA+IGNvbnNpZGVyZWQgdGhlIG5lZWQgdG8gaW5j cmVhc2UgdGhlIHJlZmNvdW50IGZvciBlYWNoIHVzZSBvZiBhIHBkZXYuDQo+PiA+DQo+PiANCj4+ IFRoaXMgaXMgaG93IExpbnV4IHVzZXMgcmVmZXJlbmNlIGxvY2tpbmcuIEl0IGRlY3JlYXNlcyBj b2duaXRpdmUgbG9hZA0KPj4gYW5kIGNoYW5jZSBmb3IgYW4gZXJyb3IsIGFzIHRoZXJlIGlzIGEg c2ltcGxlIHNldCBvZiBydWxlcywgd2hpY2ggeW91DQo+PiBmb2xsb3cuDQo+PiANCj4+ID4gRm9y IGV4YW1wbGUgSSB3b3VsZCBjb25zaWRlciB0aGUgaW5pdGlhbCBhbGxvY19wZGV2KCkgdG8gdGFr ZSBhDQo+PiA+IHJlZmNvdW50LCBhbmQgdGhlbiBwY2lfcmVtb3ZlX2RldmljZSgpIF9tdXN0XyBi ZSB0aGUgZnVuY3Rpb24gdGhhdA0KPj4gPiByZW1vdmVzIHRoZSBsYXN0IHJlZmNvdW50LCBzbyB0 aGF0IGl0IGNhbiByZXR1cm4gLUVCVVNZIG90aGVyd2lzZSAoc2VlDQo+PiA+IG15IGNvbW1lbnQg YmVsb3cpLg0KPj4gDQo+PiBJIHRlbmQgdG8gZGlzYWdyZWUgdGhlcmUsIGFzIHRoaXMgcnVpbnMg dGhlIHZlcnkgaWRlYSBvZiByZWZlcmVuY2UNCj4+IGNvdW50aW5nLiBXZSBjYW4ndCBrbm93IHdo byBlbHNlIGhvbGRzIHJlZmVyZW5jZSByaWdodCBub3cuIE9rYXksIHdlDQo+PiBtaWdodCBrbm93 LCBidXQgdGhpcyByZXF1aXJlcyBhZGRpdGlvbmFsIGxvY2sgdG8gc2VyaWFsaXplDQo+PiBhY2Nl c3Nlcy4gV2hpY2gsIGluIHR1cm4sIG1ha2VzIHJlZmNvdW50IHVuLW5lZWRlZC4NCj4NCj4gSW4g cHJpbmNpcGxlIHBjaV9yZW1vdmVfZGV2aWNlKCkgbXVzdCByZXBvcnQgd2hldGhlciB0aGUgZGV2 aWNlIGlzDQo+IHJlYWR5IHRvIGJlIHBoeXNpY2FsbHkgcmVtb3ZlZCBmcm9tIHRoZSBzeXN0ZW0s IHNvIGl0IG11c3QgcmV0dXJuDQo+IC1FQlVTWSBpZiB0aGVyZSBhcmUgc3RpbGwgdXNlcnMgYWNj ZXNzaW5nIHRoZSBkZXZpY2UuDQo+DQo+IEEgdXNlciB3b3VsZCB1c2UgUEhZU0RFVk9QX21hbmFn ZV9wY2lfcmVtb3ZlIHRvIHNpZ25hbCBYZW4gaXQncyB0cnlpbmcNCj4gdG8gcGh5c2ljYWxseSBy ZW1vdmUgYSBQQ0kgZGV2aWNlIGZyb20gYSBzeXN0ZW0sIHNvIHdlIG11c3QgZW5zdXJlDQo+IHRo YXQgd2hlbiB0aGUgaHlwZXJ2aXNvciByZXR1cm5zIHN1Y2Nlc3MgdGhlIGRldmljZSBpcyByZWFk eSB0byBiZQ0KPiBwaHlzaWNhbGx5IHJlbW92ZWQuDQo+DQo+IE9yIGF0IGxlYXN0IHRoYXQncyBt eSB1bmRlcnN0YW5kaW5nIG9mIGhvdyB0aGlzIHNob3VsZCB3b3JrLg0KPg0KDQpBcyBJIGNhbiBz ZWUsIHRoaXMgaXMgbm90IGhvdyBpdCBpcyBpbXBsZW1lbnRlZCByaWdodA0Kbm93LiBwY2lfcmVt b3ZlX2RldmljZSgpIGlzIG5vdCBjaGVja2luZyBpZiBkZXZpY2UgaXMgbm90IGFzc2lnbmVkIHRv IGENCmRvbWFpbi4gSWQgZG9lcyBub3QgY2hlY2sgaWYgdGhlcmUgYXJlIHN0aWxsIHVzZXJzIGFj Y2Vzc2luZyB0aGUNCmRldmljZS4gSXQganVzdCByZWxpZXMgb24gYSB0aGUgZ2xvYmFsIFBDSSBs b2NrIHRvIGVuc3VyZSB0aGF0IGRldmljZSBpcw0KcmVtb3ZlZCBpbiBhbiBvcmRlcmx5IG1hbm5l ci4NCg0KTXkgcGF0Y2ggc2VyaWVzIGhhcyBubyBpbnRlbnRpb24gdG8gY2hhbmdlIHRoaXMgYmVo YXZpb3IuIEFsbCB3aGF0IEkNCndhbnQgdG8gYWNoaWV2ZSAtIGlzIHRvIGFsbG93IHZwY2kgY29k ZSBhY2Nlc3Mgc3RydWN0IHBkZXYgb2JqZWN0cw0Kd2l0aG91dCBob2xkaW5nIHRoZSBnbG9iYWwg UENJIGxvY2suIA0KDQo+PiA+DQo+PiA+IEkgd291bGQgYWxzbyB0aGluayB0aGF0IGhhdmluZyB0 aGUgZGV2aWNlIGFzc2lnbmVkIHRvIGEgZ3Vlc3Qgd2lsbCB0YWtlDQo+PiA+IGFub3RoZXIgcmVm Y291bnQsIGFuZCB0aGVuIGFueSB1c2FnZSBmcm9tIGZ1cnRoZXIgY2FsbGVycyAoaWU6IGxpa2UN Cj4+ID4gdnBjaSkgd2lsbCBuZWVkIHNvbWUga2luZCBvZiBwcm90ZWN0aW9uIGZyb20gcHJldmVu dGluZyB0aGUgZGV2aWNlDQo+PiA+IGZyb20gYmVpbmcgZGVhc3NpZ25lZCBmcm9tIGEgZG9tYWlu IHdoaWxlIHZQQ0kgaGFuZGxlcnMgYXJlIHJ1bm5pbmcsDQo+PiA+IGFuZCB0aGUgY3VycmVudCBy ZWZjb3VudCB3b24ndCBoZWxwIHdpdGggdGhhdC4NCj4+IA0KPj4gWWVzLCBpZGVhIG9mIHRoaXMg cmVmY291bnRpbmcgaXMgdG8gZW5zdXJlIHRoYXQgYSBwZGV2IG9iamVjdCBleGlzdHMgYXMgYW4N Cj4+IHZhbGlkIG9iamVjdCBpbiBtZW1vcnkgaWYgd2UgYXJlIGhvbGRpbmcgYSBsb25nLXRlcm0g cG9pbnRlciB0bw0KPj4gaXQuIEluZGVlZCwgdlBDSSBoYW5kbGVycyBzaG91bGQgdXNlIHNvbWUg b3RoZXIgbWVjaGFuaXNtIHRvIGVuc3VyZSB0aGF0DQo+PiBwZGV2IGlzIG5vdCBiZWluZyByZS1h c3NpZ25lZCB3aGlsZSBoYW5kbGVycyBhcmUgcnVubmluZy4gSSBiZWxpZXZlLA0KPj4gdGhpcyBp cyB0aGUgdGFzayBvZiB2cGNpLT5sb2NrLiBTaG91bGQgd2UgY2FsbA0KPj4gdnBjaV9yZW1vdmVf ZGV2aWNlL3ZwY2lfYWRkX2hhbmRsZXJzIGVhY2ggdGltZSB3ZSByZS1hc3NpZ24gYSBQQ0kgZGV2 aWNlPw0KPg0KPiBZZXMsIEkgdGhpbmsgdGhpcyB3YXMgYWxzbyBwYXJ0IG9mIGEgY29tbWVudCBJ J3ZlIG1hZGUgb24gYSBkaWZmZXJlbnQNCj4gcGF0Y2guICBUaGUgZGV2aWNlIHN0YXRlIG5lZWRz IHRvIGJlIGNsZWFyZWQgd2hlbiBhc3NpZ25lZCB0byBhDQo+IGRpZmZlcmVudCBndWVzdCAoYXMg dGhlIGhhcmR3YXJlIGRvbWFpbiB3aWxsIGFsc28gcGVyZm9ybSBhIGRldmljZQ0KPiByZXNldCku DQo+DQo+IEkgdGhpbmsgdGhlcmUgYXJlIHNvbWUgcG9pbnRzIHRoYXQgbmVlZHMgdG8gYmUgcGFy dCBvZiB0aGUgY29tbWl0DQo+IG1lc3NhZ2Ugc28gdGhlIGNvZGUgY2FuIGJlIHByb3Blcmx5IGV2 YWx1YXRlZDoNCj4NCj4gIC0gVGhlIHJlZmVyZW5jZSBjb3VudGluZyBpcyBvbmx5IHVzZWQgdG8g ZW5zdXJlIHRoZSBvYmplY3QgY2Fubm90IGJlDQo+ICAgIHJlbW92ZWQgd2hpbGUgaW4gdXNlLiAg VXNlcnMgb2YgdGhlIHBjaSBkZXZpY2Ugb2JqZWN0IHNob3VsZA0KPiAgICBpbXBsZW1lbnQgd2hh dGV2ZXIgcHJvdGVjdGlvbnMgcmVxdWlyZWQgaW4gb3JkZXIgdG8gZ2V0IG11dHVhbA0KPiAgICBl eGNsdXNpb24gYmV0d2VlbiB0aGVtIGFuZCBkZXZpY2Ugc3RhdGUgY2hhbmdlcy4NCj4NCg0KU3Vy ZSwgSSB3aWxsIGFkZCB0aGlzLg0KDQo+PiA+DQo+PiA+IFRoYXQgbWFrZXMgbWUgd29uZGVyIGlm IGZvciBleGFtcGxlIGNhbGxlcnMgb2YgcGNpX2dldF9wZGV2KGQsIHNiZGYpDQo+PiA+IGRvIG5l ZWQgdG8gdGFrZSBhbiBleHRyYSByZWZjb3VudCwgYmVjYXVzZSBzdWNoIGFjY2VzcyBpcyBhbHJl YWR5DQo+PiA+IHByb3RlY3RlZCBmcm9tIHRoZSBwZGV2IGdvaW5nIGF3YXkgYnkgdGhlIGZhY3Qg dGhhdCB0aGUgZGV2aWNlIGlzDQo+PiA+IGFzc2lnbmVkIHRvIGEgZ3Vlc3QuICBCdXQgbWF5YmUg aXQncyB0b28gbXVjaCB3b3JrIHRvIHNlcGFyYXRlIHVzZXJzDQo+PiA+IG9mIHBjaV9nZXRfcGRl dihkLCAuLi4pOyB2cyBwY2lfZ2V0X3BkZXYoTlVMTCwgLi4uKTsuDQo+PiA+DQo+PiA+IFRoZXJl J3MgYWxzbyBhIHdpbmRvdyB3aGVuIHRoZSByZWZjb3VudCBpcyBkcm9wcGVkIHRvIDAsIGFuZCB0 aGUNCj4+ID4gZGVzdHJ1Y3Rpb24gZnVuY3Rpb24gaXMgY2FsbGVkLCBidXQgYXQgdGhlIHNhbWUg dGltZSBhIGNvbmN1cnJlbnQNCj4+ID4gdGhyZWFkIGNvdWxkIGF0dGVtcHQgdG8gdGFrZSBhIHJl ZmVyZW5jZSB0byB0aGUgcGRldiBzdGlsbD8NCj4+IA0KPj4gTGFzdCBwY2lkZXZfcHV0KCkgd291 bGQgYmUgY2FsbGVkIGJ5IHBjaV9yZW1vdmVfZGV2aWNlKCksIGFmdGVyIHJlbW92aW5nDQo+PiBp dCBmcm9tIGFsbCBsaXN0cy4gVGhpcyBzaG91bGQgcHJldmVudCBvdGhlciB0aHJlYWRzIGZyb20g b2J0YWluaW5nIGEgdmFsaWQNCj4+IHJlZmVyZW5jZSB0byB0aGUgcGRldi4NCj4NCj4gV2hhdCBp ZiBhIGNvbmN1cnJlbnQgdXNlciBoYXMgdGFrZW4gYSByZWZlcmVuY2UgdG8gdGhlIG9iamVjdCBi ZWZvcmUNCj4gcGNpX3JlbW92ZV9kZXZpY2UoKSBoYXMgcmVtb3ZlZCB0aGUgZGV2aWNlIGZyb20g dGhlIGxpc3RzLCBhbmQgc3RpbGwNCj4gaG9sZHMgaXQgd2hlbiBwY2lfcmVtb3ZlX2RldmljZSgp IHBlcmZvcm1zIHRoZSBzdXBwb3NlZGx5IGxhc3QNCj4gcGNpZGV2X3B1dCgpIGNhbGw/DQoNCldl bGwsIGxldCdzIGNvbnNpZGVyIFZQQ0kgY29kZSBhcyB0aGlzIGNvbmN1cnJlbnQgdXNlciwgZm9y DQpleGFtcGxlLiBGaXJzdCwgaXQgd2lsbCB0cnkgdG8gdGFrZSB2cGNpLT5sb2NrLiBEZXBlbmRp bmcgb24gd2hlcmUgaW4NCnBjaV9yZW1vdl9kZXZpY2UoKSB0aGVyZSB3aWxsIGJlIHRocmVlIGNh c2VzOg0KDQoxLiBMb2NrIGlzIHRha2VuIGJlZm9yZSB2cGNpX3JlbW92ZV9kZXZpY2UoKSB0YWtl cyB0aGUgbG9jay4gSW4gdGhpcw0KY2FzZSB2cGNpIGNvZGUgd29ya3MgYXMgYWx3YXlzDQoNCjIu IEl0IHRyaWVzIHRvIHRha2UgdGhlIGxvY2sgd2hlbiB2cGNpX3JlbW92ZV9kZXZpY2UoKSBpcyBh bHJlYWR5IGxvY2tlZA0KdGhpcy4gSW4gdGhpcyBjYXNlIHdlIGFyZSBmYWxsaW5nIHRvIHRoZSBu ZXh0IGNhc2U6DQoNCjMuIExvY2sgaXMgdGFrZW4gYWZ0ZXIgdnBjaV9yZW1vdmVfZGV2aWNlKCkg aGFkIGZpbmlzaGVkIGl0J3Mgd29yay4gSW4gdGhpcw0KY2FzZSB2UENJIGNvZGUgc2VlcyB0aGF0 IGl0IHdhcyBjYWxsZWQgZm9yIGEgZGV2aWNlIGluIGFuIGludmFsaWQgc3RhdGUNCmFuZCBleGl0 cy4NCg0KQXMgeW91IGNhbiBzZWUsIHRoZXJlIGlzIG5vIGNhc2Ugd2hlcmUgdlBDSSBjb2RlIGlz IHJ1bm5pbmcgb24gYW4gZGV2aWNlDQp3aGljaCB3YXMgcmVtb3ZlZC4NCg0KQWZ0ZXIgdlBDSSBj b2RlIGRyb3BzIHJlZmNvdW50ZXIsIHBkZXYgb2JqZWN0IHdpbGwgYmUgZnJlZWQgb25jZSBhbmQg Zm9yDQphbGwuIFBsZWFzZSBub2RlLCB0aGF0IEkgYW0gdGFsa2luZyBhYm91dCBwZGV2IG9iamVj dCB0aGVyZSwgbm90IGFib3V0DQpQQ0kgZGV2aWNlLCBiZWNhdXNlIFBDSSBkZXZpY2UgKGFzIGEg aGlnaC1sZXZlbCBlbnRpdHkpIHdhcyBkZXN0cm95ZWQgYnkNCnBjaV9yZW1vdmVfZGV2aWNlKCku IHJlZmNvdW50IGlzIG5lZWRlZCBqdXN0IGZvciB0aGUgbGFzdCBjbGVhbi11cA0Kb3BlcmF0aW9u cy4NCg0KPg0KPj4gPg0KPj4gPj4gICAgICAgICAgc2JkZi5kZXZmbiAmPSB+c3RyaWRlOw0KPj4g Pj4gICAgICAgICAgcGRldiA9IHBjaV9nZXRfcGRldihOVUxMLCBzYmRmKTsNCj4+ID4+ICAgICAg ICAgIGlmICggcGRldiAmJiBzdHJpZGUgIT0gcGRldi0+cGhhbnRvbV9zdHJpZGUgKQ0KPj4gPj4g KyAgICAgICAgew0KPj4gPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiA+PiAg ICAgICAgICAgICAgcGRldiA9IE5VTEw7DQo+PiA+PiArICAgICAgICB9DQo+PiA+PiAgICAgIH0N Cj4+ID4+ICANCj4+ID4+ICAgICAgcmV0dXJuIHBkZXY7DQo+PiA+PiBAQCAtNTQ4LDEzICs1MjYs MTggQEAgc3RydWN0IHBjaV9kZXYgKnBjaV9nZXRfcGRldihjb25zdCBzdHJ1Y3QgZG9tYWluICpk LCBwY2lfc2JkZl90IHNiZGYpDQo+PiA+PiAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5ICgg cGRldiwgJnBzZWctPmFsbGRldnNfbGlzdCwgYWxsZGV2c19saXN0ICkNCj4+ID4+ICAgICAgICAg ICAgICBpZiAoIHBkZXYtPnNiZGYuYmRmID09IHNiZGYuYmRmICYmDQo+PiA+PiAgICAgICAgICAg ICAgICAgICAoIWQgfHwgcGRldi0+ZG9tYWluID09IGQpICkNCj4+ID4+ICsgICAgICAgICAgICB7 DQo+PiA+PiArICAgICAgICAgICAgICAgIHBjaWRldl9nZXQocGRldik7DQo+PiA+PiAgICAgICAg ICAgICAgICAgIHJldHVybiBwZGV2Ow0KPj4gPj4gKyAgICAgICAgICAgIH0NCj4+ID4+ICAgICAg fQ0KPj4gPj4gICAgICBlbHNlDQo+PiA+PiAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5ICgg cGRldiwgJmQtPnBkZXZfbGlzdCwgZG9tYWluX2xpc3QgKQ0KPj4gPj4gICAgICAgICAgICAgIGlm ICggcGRldi0+c2JkZi5iZGYgPT0gc2JkZi5iZGYgKQ0KPj4gPj4gKyAgICAgICAgICAgIHsNCj4+ ID4+ICsgICAgICAgICAgICAgICAgcGNpZGV2X2dldChwZGV2KTsNCj4+ID4+ICAgICAgICAgICAg ICAgICAgcmV0dXJuIHBkZXY7DQo+PiA+PiAtDQo+PiA+PiArICAgICAgICAgICAgfQ0KPj4gPj4g ICAgICByZXR1cm4gTlVMTDsNCj4+ID4+ICB9DQo+PiA+PiAgDQo+PiA+PiBAQCAtNjYzLDcgKzY0 NiwxMCBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+ ID4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX1NCREYoc2VnLCBpbmZvLT5waHlz Zm4uYnVzLA0KPj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmZv LT5waHlzZm4uZGV2Zm4pKTsNCj4+ID4+ICAgICAgICAgIGlmICggcGRldiApDQo+PiA+PiArICAg ICAgICB7DQo+PiA+PiAgICAgICAgICAgICAgcGZfaXNfZXh0Zm4gPSBwZGV2LT5pbmZvLmlzX2V4 dGZuOw0KPj4gPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7DQo+PiA+PiArICAgICAg ICB9DQo+PiA+PiAgICAgICAgICBwY2lkZXZzX3VubG9jaygpOw0KPj4gPj4gICAgICAgICAgaWYg KCAhcGRldiApDQo+PiA+PiAgICAgICAgICAgICAgcGNpX2FkZF9kZXZpY2Uoc2VnLCBpbmZvLT5w aHlzZm4uYnVzLCBpbmZvLT5waHlzZm4uZGV2Zm4sDQo+PiA+PiBAQCAtODE4LDcgKzgwNCw5IEBA IGludCBwY2lfcmVtb3ZlX2RldmljZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuKQ0KPj4gPj4g ICAgICAgICAgICAgIGlmICggcGRldi0+ZG9tYWluICkNCj4+ID4+ICAgICAgICAgICAgICAgICAg bGlzdF9kZWwoJnBkZXYtPmRvbWFpbl9saXN0KTsNCj4+ID4+ICAgICAgICAgICAgICBwcmludGso WEVOTE9HX0RFQlVHICJQQ0kgcmVtb3ZlIGRldmljZSAlcHBcbiIsICZwZGV2LT5zYmRmKTsNCj4+ ID4+IC0gICAgICAgICAgICBmcmVlX3BkZXYocHNlZywgcGRldik7DQo+PiA+PiArICAgICAgICAg ICAgbGlzdF9kZWwoJnBkZXYtPmFsbGRldnNfbGlzdCk7DQo+PiA+PiArICAgICAgICAgICAgcGRl dl9tc2lfZGVpbml0KHBkZXYpOw0KPj4gPj4gKyAgICAgICAgICAgIHBjaWRldl9wdXQocGRldik7 DQo+PiA+DQo+PiA+IEhtLCBJIHRoaW5rIGhlcmUgd2Ugd2FudCB0byBtYWtlIHN1cmUgdGhhdCB0 aGUgZGV2aWNlIGhhcyBiZWVuIGZyZWVkLA0KPj4gPiBvciBlbHNlIHlvdSB3b3VsZCBoYXZlIHRv IHJldHVybiAtRUJVU1kgdG8gdGhlIGNhbGxzIHRvIG5vdGlmeSB0aGF0DQo+PiA+IHRoZSBkZXZp Y2UgaXMgc3RpbGwgaW4gdXNlLg0KPj4gDQo+PiBXaHk/IEFzIEkgY2FuIHNlZSwgcGRldiBvYmpl Y3QgaXMgc3RpbGwgbWF5IHBvdGVudGlhbGx5IGJlIGFjY2Vzc2VkIGJ5DQo+PiBzb21lIG90aGVy IENQVSByaWdodCBub3cuIFNvIHBkZXYgb2JqZWN0IHdpbGwgYmUgZnJlZWQgYWZ0ZXIgbGFzdA0K Pj4gcmVmZXJlbmNlIGlzIGRyb3BwZWQuIEFzIGl0IGlzIGFscmVhZHkgcmVtb3ZlZCBmcm9tIGFs bCB0aGUgbGlzdHMsDQo+PiBwY2lfZGV2X2dldCgpIHdpbGwgbm90IGZpbmQgaXQgYW55bW9yZS4N Cj4+IA0KPj4gQWN0dWFsbHksIEkgY2FuJ3Qgc2VlIGhvdyB0aGlzIGNhbiBoYXBwZW4gaW4gcmVh bGl0eSwgYXMgVlBDSSwgTVNJIGFuZA0KPj4gSU9NTVUgYXJlIGFscmVhZHkgZGVhY3RpdmF0ZWQg Zm9yIHRoaXMgZGV2aWNlLiBTbywgbm8gb25lIHdvdWxkIHRvdWNoIGl0Lg0KPg0KPiBXb3VsZG4n dCBpdCBiZSBwb3NzaWJsZSBmb3IgYSBjb25jdXJyZW50IHVzZXIgdG8gaG9sZCBhIHJlZmVyZW5j ZSBmcm9tDQo+IGJlZm9lIHRoZSBkZXZpY2UgaGFzIGJlZW4gJ2RlYWN0aXZhdGVkJz8NCj4NCg0K WWVzLCBpdCBjYW4gaG9sZCBhIHJlZmVyZW5jZS4gVGhpcyBpcyB3aHkgd2UgbmVlZCBhZGRpdGlv bmFsIGxvY2tpbmcgdG8NCmVuc3VyZSB0aGF0LCBzYXksIHBjaV9jbGVhbnVwX21zaSgpIGRvZXMg bm90IHJhY2VzIHdpdGggcmVzdCBvZiB0aGUgTVNJDQpjb2RlLiBSaWdodCBub3cgdGhpcyBpcyBl bnN1cmVkIGJ5IHRoZW4gZ2xvYmFsIFBDSSBsb2NrLg0KDQo+PiA+DQo+PiA+IEkgdGhpbmsgd2Ug bmVlZCBhbiBleHRyYSBwY2lkZXZfcHV0X2ZpbmFsKCkgb3Igc2ltaWxhciB0aGF0IGNhbiBiZQ0K Pj4gPiB1c2VkIGluIHBjaV9yZW1vdmVfZGV2aWNlKCkgdG8gYXNzZXJ0IHRoYXQgdGhlIGRldmlj ZSBoYXMgYmVlbg0KPj4gPiBhY3R1YWxseSByZW1vdmVkLg0KPj4gDQo+PiBXaWxsIHNvbWV0aGlu ZyBicmVhayBpZiB3ZSBkb24ndCBkbyB0aGlzPyBJIGNhbid0IHNlZSBob3cgdGhpcyBjYW4NCj4+ IGhhcHBlbi4NCj4NCj4gQXMgbWVudGlvbmVkIGFib3ZlLCBvbmNlIHBjaV9yZW1vdmVfZGV2aWNl KCkgcmV0dXJucyAwIHRoZSBhZG1pbg0KPiBzaG91bGQgYmUgY2FwYWJsZSBvZiBwaHlzaWNhbGx5 IHJlbW92aW5nIHRoZSBkZXZpY2UgZnJvbSB0aGUgc3lzdGVtLg0KPg0KDQpUaGlzIHBhdGNoIHNl cmllcyBkb2VzIG5vdCBhbHRlciB0aGlzIHJlcXVpcmVtZW50LiBBZG1pbiBpcyBzdGlsbA0KY2Fw YWJsZSBvZiBwaHlzaWNhbGx5IHJlbW92aW5nIHRoZSBkZXZpY2UgZnJvbSB0aGUgc3lzdGVtLiBB ZnRlcg0Kc3VjY2Vzc2Z1bCBjYWxsIHRvIHRoZSBwY2lfcmVtb3ZlX2RldmljZSgpDQoNCj4+ID4N Cj4+ID4+ICAgICAgICAgICAgICBicmVhazsNCj4+ID4+ICAgICAgICAgIH0NCj4+ID4+ICANCj4+ ID4+IEBAIC04NDgsNyArODM2LDcgQEAgc3RhdGljIGludCBkZWFzc2lnbl9kZXZpY2Uoc3RydWN0 IGRvbWFpbiAqZCwgdWludDE2X3Qgc2VnLCB1aW50OF90IGJ1cywNCj4+ID4+ICAgICAgew0KPj4g Pj4gICAgICAgICAgcmV0ID0gaW9tbXVfcXVhcmFudGluZV9kZXZfaW5pdChwY2lfdG9fZGV2KHBk ZXYpKTsNCj4+ID4+ICAgICAgICAgIGlmICggcmV0ICkNCj4+ID4+IC0gICAgICAgICAgIHJldHVy biByZXQ7DQo+PiA+PiArICAgICAgICAgICAgZ290byBvdXQ7DQo+PiA+PiAgDQo+PiA+PiAgICAg ICAgICB0YXJnZXQgPSBkb21faW87DQo+PiA+PiAgICAgIH0NCj4+ID4+IEBAIC04NzgsNiArODY2 LDcgQEAgc3RhdGljIGludCBkZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdWludDE2 X3Qgc2VnLCB1aW50OF90IGJ1cywNCj4+ID4+ICAgICAgcGRldi0+ZmF1bHQuY291bnQgPSAwOw0K Pj4gPj4gIA0KPj4gPj4gICBvdXQ6DQo+PiA+PiArICAgIHBjaWRldl9wdXQocGRldik7DQo+PiA+ PiAgICAgIGlmICggcmV0ICkNCj4+ID4+ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlIgIiVw ZDogZGVhc3NpZ24gKCVwcCkgZmFpbGVkICglZClcbiIsDQo+PiA+PiAgICAgICAgICAgICAgICAg ZCwgJlBDSV9TQkRGKHNlZywgYnVzLCBkZXZmbiksIHJldCk7DQo+PiA+PiBAQCAtMTAxMSw3ICsx MDAwLDEwIEBAIHZvaWQgcGNpX2NoZWNrX2Rpc2FibGVfZGV2aWNlKHUxNiBzZWcsIHU4IGJ1cywg dTggZGV2Zm4pDQo+PiA+PiAgICAgICAgICAgICAgcGRldi0+ZmF1bHQuY291bnQgPj49IDE7DQo+ PiA+PiAgICAgICAgICBwZGV2LT5mYXVsdC50aW1lID0gbm93Ow0KPj4gPj4gICAgICAgICAgaWYg KCArK3BkZXYtPmZhdWx0LmNvdW50IDwgUFRfRkFVTFRfVEhSRVNIT0xEICkNCj4+ID4+ICsgICAg ICAgIHsNCj4+ID4+ICsgICAgICAgICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPj4gPj4gICAgICAg ICAgICAgIHBkZXYgPSBOVUxMOw0KPj4gPj4gKyAgICAgICAgfQ0KPj4gPj4gICAgICB9DQo+PiA+ PiAgICAgIHBjaWRldnNfdW5sb2NrKCk7DQo+PiA+PiAgDQo+PiA+PiBAQCAtMTAyMiw2ICsxMDE0 LDggQEAgdm9pZCBwY2lfY2hlY2tfZGlzYWJsZV9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBk ZXZmbikNCj4+ID4+ICAgICAgICogY29udHJvbCBpdCBmb3IgdXMuICovDQo+PiA+PiAgICAgIGN3 b3JkID0gcGNpX2NvbmZfcmVhZDE2KHBkZXYtPnNiZGYsIFBDSV9DT01NQU5EKTsNCj4+ID4+ICAg ICAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCBQQ0lfQ09NTUFORCwgY3dvcmQgJiB+UENJ X0NPTU1BTkRfTUFTVEVSKTsNCj4+ID4+ICsNCj4+ID4+ICsgICAgcGNpZGV2X3B1dChwZGV2KTsN Cj4+ID4+ICB9DQo+PiA+PiAgDQo+PiA+PiAgLyoNCj4+ID4+IEBAIC0xMTM4LDYgKzExMzIsNyBA QCBzdGF0aWMgaW50IF9faHdkb21faW5pdCBjZl9jaGVjayBfc2V0dXBfaHdkb21fcGNpX2Rldmlj ZXMoDQo+PiA+PiAgICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORyAiRG9tJWQg b3duaW5nICVwcD9cbiIsDQo+PiA+PiAgICAgICAgICAgICAgICAgICAgICAgICBwZGV2LT5kb21h aW4tPmRvbWFpbl9pZCwgJnBkZXYtPnNiZGYpOw0KPj4gPj4gIA0KPj4gPj4gKyAgICAgICAgICAg IHBjaWRldl9wdXQocGRldik7DQo+PiA+PiAgICAgICAgICAgICAgaWYgKCBpb21tdV92ZXJib3Nl ICkNCj4+ID4+ICAgICAgICAgICAgICB7DQo+PiA+PiAgICAgICAgICAgICAgICAgIHBjaWRldnNf dW5sb2NrKCk7DQo+PiA+PiBAQCAtMTM4NSwzMyArMTM4MCwyOCBAQCBzdGF0aWMgaW50IGlvbW11 X3JlbW92ZV9kZXZpY2Uoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiA+PiAgICAgIHJldHVybiBp b21tdV9jYWxsKGhkLT5wbGF0Zm9ybV9vcHMsIHJlbW92ZV9kZXZpY2UsIGRldmZuLCBwY2lfdG9f ZGV2KHBkZXYpKTsNCj4+ID4+ICB9DQo+PiA+PiAgDQo+PiA+PiAtc3RhdGljIGludCBkZXZpY2Vf YXNzaWduZWQodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbikNCj4+ID4+ICtzdGF0aWMgaW50IGRl dmljZV9hc3NpZ25lZChzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ID4+ICB7DQo+PiA+PiAtICAg IHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KPj4gPj4gICAgICBpbnQgcmMgPSAwOw0KPj4gPj4gIA0K Pj4gPj4gICAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7DQo+PiA+PiAtICAgIHBkZXYgPSBw Y2lfZ2V0X3BkZXYoTlVMTCwgUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+PiA+PiAtDQo+ PiA+PiAtICAgIGlmICggIXBkZXYgKQ0KPj4gPj4gLSAgICAgICAgcmMgPSAtRU5PREVWOw0KPj4g Pj4gICAgICAvKg0KPj4gPj4gICAgICAgKiBJZiB0aGUgZGV2aWNlIGV4aXN0cyBhbmQgaXQgaXMg bm90IG93bmVkIGJ5IGVpdGhlciB0aGUgaGFyZHdhcmUNCj4+ID4+ICAgICAgICogZG9tYWluIG9y IGRvbV9pbyB0aGVuIGl0IG11c3QgYmUgYXNzaWduZWQgdG8gYSBndWVzdCwgb3IgYmUNCj4+ID4+ ICAgICAgICogaGlkZGVuIChvd25lZCBieSBkb21feGVuKS4NCj4+ID4+ICAgICAgICovDQo+PiA+ PiAtICAgIGVsc2UgaWYgKCBwZGV2LT5kb21haW4gIT0gaGFyZHdhcmVfZG9tYWluICYmDQo+PiA+ PiAtICAgICAgICAgICAgICBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkNCj4+ID4+ICsgICAgaWYg KCBwZGV2LT5kb21haW4gIT0gaGFyZHdhcmVfZG9tYWluICYmDQo+PiA+PiArICAgICAgICAgcGRl di0+ZG9tYWluICE9IGRvbV9pbyApDQo+PiA+PiAgICAgICAgICByYyA9IC1FQlVTWTsNCj4+ID4+ ICANCj4+ID4+ICAgICAgcmV0dXJuIHJjOw0KPj4gPj4gIH0NCj4+ID4+ICANCj4+ID4+ICAvKiBD YWxsZXIgc2hvdWxkIGhvbGQgdGhlIHBjaWRldnNfbG9jayAqLw0KPj4gPg0KPj4gPiBJIHdvdWxk IGFzc3VtZSB0aGUgY2FsbGVyIGhhcyB0YWtlbiBhbiBleHRyYSByZWZlcmVuY2UgdG8gdGhlIHBk ZXYsIHNvDQo+PiA+IGhvbGRpbmcgdGhlIHBjaWRldnNfbG9jayBpcyBubyBsb25nZXIgbmVlZGVk Pw0KPj4gDQo+PiBJIGFtIGFzc3VtZWQgdGhhdCBsb2NrIG1heSBiZSByZXF1aXJlZCBieSBNU0lY IG9yIElPTU1VIGZ1bmN0aW9ucywgdGhhdA0KPj4gYXJlIGJlaW5nIGNhbGxlZCBoZXJlLiBGb3Ig ZXhhbXBsZSwgSSBjYW4gc2VlIHRoYXQgcmVhc3NpZ25fZGV2aWNlKCkgaW4NCj4+IHBjaV9hbWRf aW9tbXUuYyBtYW5pcHVsYXRlcyB3aXRoIHNvbWUgbGlzdHMuIEkgYmVsaWV2ZSwgaXQgc2hvdWxk IGJlDQo+PiBwcm90ZWN0ZWQgd2l0aCB0aGUgbG9jay4NCj4NCj4gT0ssIHNvIHRoYXQncyBwY2lk ZXZzX2xvY2sgYmVpbmcgdXNlZCB0byBwcm90ZWN0IHNvbWV0aGluZyBlbHNlIHRoYXQncw0KPiBu b3Qgc3RyaWN0bHkgYSBwY2kgZGV2aWNlLCBidXQgYSByZWxhdGVkIHN0cnVjdHVyZS4NCj4NCg0K WWVzLiBJIGhhdmUgZm91bmQgbXVsdGlwbGUgc3VjaCBwbGFjZXMsIHdoZW4gSSB0cmllZCB0b3Rh bCBQQ0kgbG9ja2luZw0KcmV3b3JraW5nLg0KDQo+PiA+DQo+PiA+PiAtc3RhdGljIGludCBhc3Np Z25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUz MiBmbGFnKQ0KPj4gPj4gK3N0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpk LCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdTMyIGZsYWcpDQo+PiA+PiAgew0KPj4gPj4gICAgICBj b25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsNCj4+ID4+IC0gICAg c3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiA+PiArICAgIHVpbnQ4X3QgZGV2Zm47DQo+PiA+PiAg ICAgIGludCByYyA9IDA7DQo+PiA+PiAgDQo+PiA+PiAgICAgIGlmICggIWlzX2lvbW11X2VuYWJs ZWQoZCkgKQ0KPj4gPj4gQEAgLTE0MjIsMTAgKzE0MTIsMTEgQEAgc3RhdGljIGludCBhc3NpZ25f ZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBm bGFnKQ0KPj4gPj4gIA0KPj4gPj4gICAgICAvKiBkZXZpY2VfYXNzaWduZWQoKSBzaG91bGQgYWxy ZWFkeSBoYXZlIGNsZWFyZWQgdGhlIGRldmljZSBmb3IgYXNzaWdubWVudCAqLw0KPj4gPj4gICAg ICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7DQo+PiA+PiAtICAgIHBkZXYgPSBwY2lfZ2V0X3Bk ZXYoTlVMTCwgUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+PiA+PiAgICAgIEFTU0VSVChw ZGV2ICYmIChwZGV2LT5kb21haW4gPT0gaGFyZHdhcmVfZG9tYWluIHx8DQo+PiA+PiAgICAgICAg ICAgICAgICAgICAgICBwZGV2LT5kb21haW4gPT0gZG9tX2lvKSk7DQo+PiA+PiAgDQo+PiA+PiAr ICAgIGRldmZuID0gcGRldi0+ZGV2Zm47DQo+PiA+PiArDQo+PiA+PiAgICAgIC8qIERvIG5vdCBh bGxvdyBicm9rZW4gZGV2aWNlcyB0byBiZSBhc3NpZ25lZCB0byBndWVzdHMuICovDQo+PiA+PiAg ICAgIHJjID0gLUVCQURGOw0KPj4gPj4gICAgICBpZiAoIHBkZXYtPmJyb2tlbiAmJiBkICE9IGhh cmR3YXJlX2RvbWFpbiAmJiBkICE9IGRvbV9pbyApDQo+PiA+PiBAQCAtMTQ2MCw3ICsxNDUxLDcg QEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4 IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gPj4gICBkb25lOg0KPj4gPj4gICAgICBpZiAo IHJjICkNCj4+ID4+ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICIlcGQ6IGFzc2ln biAoJXBwKSBmYWlsZWQgKCVkKVxuIiwNCj4+ID4+IC0gICAgICAgICAgICAgICBkLCAmUENJX1NC REYoc2VnLCBidXMsIGRldmZuKSwgcmMpOw0KPj4gPj4gKyAgICAgICAgICAgICAgIGQsICZQQ0lf U0JERihwZGV2LT5zZWcsIHBkZXYtPmJ1cywgZGV2Zm4pLCByYyk7DQo+PiA+PiAgICAgIC8qIFRo ZSBkZXZpY2UgaXMgYXNzaWduZWQgdG8gZG9tX2lvIHNvIG1hcmsgaXQgYXMgcXVhcmFudGluZWQg Ki8NCj4+ID4+ICAgICAgZWxzZSBpZiAoIGQgPT0gZG9tX2lvICkNCj4+ID4+ICAgICAgICAgIHBk ZXYtPnF1YXJhbnRpbmUgPSB0cnVlOw0KPj4gPj4gQEAgLTE1OTUsNiArMTU4Niw5IEBAIGludCBp b21tdV9kb19wY2lfZG9tY3RsKA0KPj4gPj4gICAgICAgICAgQVNTRVJUKGQpOw0KPj4gPj4gICAg ICAgICAgLyogZmFsbCB0aHJvdWdoICovDQo+PiA+PiAgICAgIGNhc2UgWEVOX0RPTUNUTF90ZXN0 X2Fzc2lnbl9kZXZpY2U6DQo+PiA+PiArICAgIHsNCj4+ID4+ICsgICAgICAgIHN0cnVjdCBwY2lf ZGV2ICpwZGV2Ow0KPj4gPj4gKw0KPj4gPj4gICAgICAgICAgLyogRG9uJ3Qgc3VwcG9ydCBzZWxm LWFzc2lnbm1lbnQgb2YgZGV2aWNlcy4gKi8NCj4+ID4+ICAgICAgICAgIGlmICggZCA9PSBjdXJy ZW50LT5kb21haW4gKQ0KPj4gPj4gICAgICAgICAgew0KPj4gPj4gQEAgLTE2MjIsMjYgKzE2MTYs MzYgQEAgaW50IGlvbW11X2RvX3BjaV9kb21jdGwoDQo+PiA+PiAgICAgICAgICBzZWcgPSBtYWNo aW5lX3NiZGYgPj4gMTY7DQo+PiA+PiAgICAgICAgICBidXMgPSBQQ0lfQlVTKG1hY2hpbmVfc2Jk Zik7DQo+PiA+PiAgICAgICAgICBkZXZmbiA9IFBDSV9ERVZGTihtYWNoaW5lX3NiZGYpOw0KPj4g Pj4gLQ0KPj4gPj4gICAgICAgICAgcGNpZGV2c19sb2NrKCk7DQo+PiA+PiAtICAgICAgICByZXQg PSBkZXZpY2VfYXNzaWduZWQoc2VnLCBidXMsIGRldmZuKTsNCj4+ID4+ICsgICAgICAgIHBkZXYg PSBwY2lfZ2V0X3BkZXYoTlVMTCwgUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+PiA+PiAr ICAgICAgICBpZiAoICFwZGV2ICkNCj4+ID4+ICsgICAgICAgIHsNCj4+ID4+ICsgICAgICAgICAg ICBwcmludGsoWEVOTE9HX0dfSU5GTyAiJXBwIG5vbi1leGlzdGVudFxuIiwNCj4+ID4+ICsgICAg ICAgICAgICAgICAgICAgJlBDSV9TQkRGKHNlZywgYnVzLCBkZXZmbikpOw0KPj4gPj4gKyAgICAg ICAgICAgIHJldCA9IC1FSU5WQUw7DQo+PiA+PiArICAgICAgICAgICAgYnJlYWs7DQo+PiA+PiAr ICAgICAgICB9DQo+PiA+PiArDQo+PiA+PiArICAgICAgICByZXQgPSBkZXZpY2VfYXNzaWduZWQo cGRldik7DQo+PiA+PiAgICAgICAgICBpZiAoIGRvbWN0bC0+Y21kID09IFhFTl9ET01DVExfdGVz dF9hc3NpZ25fZGV2aWNlICkNCj4+ID4+ICAgICAgICAgIHsNCj4+ID4+ICAgICAgICAgICAgICBp ZiAoIHJldCApDQo+PiA+PiAgICAgICAgICAgICAgew0KPj4gPj4gLSAgICAgICAgICAgICAgICBw cmludGsoWEVOTE9HX0dfSU5GTyAiJXBwIGFscmVhZHkgYXNzaWduZWQsIG9yIG5vbi1leGlzdGVu dFxuIiwNCj4+ID4+ICsgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX0lORk8gIiVwcCBh bHJlYWR5IGFzc2lnbmVkXG4iLA0KPj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAgJlBDSV9T QkRGKHNlZywgYnVzLCBkZXZmbikpOw0KPj4gPj4gICAgICAgICAgICAgICAgICByZXQgPSAtRUlO VkFMOw0KPj4gPj4gICAgICAgICAgICAgIH0NCj4+ID4+ICAgICAgICAgIH0NCj4+ID4+ICAgICAg ICAgIGVsc2UgaWYgKCAhcmV0ICkNCj4+ID4+IC0gICAgICAgICAgICByZXQgPSBhc3NpZ25fZGV2 aWNlKGQsIHNlZywgYnVzLCBkZXZmbiwgZmxhZ3MpOw0KPj4gPj4gKyAgICAgICAgICAgIHJldCA9 IGFzc2lnbl9kZXZpY2UoZCwgcGRldiwgZmxhZ3MpOw0KPj4gPj4gKw0KPj4gPj4gKyAgICAgICAg cGNpZGV2X3B1dChwZGV2KTsNCj4+ID4NCj4+ID4gSSB3b3VsZCB0aGluayB5b3UgbmVlZCB0byBr ZWVwIHRoZSByZWZjb3VudCBoZXJlIGlmIHJldCA9PSAwLCBzbyB0aGF0DQo+PiA+IHRoZSBkZXZp Y2UgY2Fubm90IGJlIHJlbW92ZWQgd2hpbGUgYXNzaWduZWQgdG8gYSBkb21haW4/DQo+PiANCj4+ IExvb2tzIGxpa2Ugd2UgYXJlIHBlcmNlaXZpbmcgZnVuY3Rpb24gb2YgcmVmY250IGluIGEgZGlm ZmVyZW50DQo+PiB3YXlzLiBGb3IgbWUsIHRoaXMgaXMgdGhlIG1lY2hhbmlzbSB0byBndWFyYW50 ZWUgdGhhdCBpZiB3ZSBoYXZlIGEgdmFsaWQNCj4+IHBvaW50ZXIgdG8gYW4gb2JqZWN0LCB0aGlz IG9iamVjdCB3aWxsIG5vdCBkaXNhcHBlYXIgdW5kZXIgb3VyDQo+PiBmZWV0LiBUaGlzIGlzIHRo ZSBtYWluIGZ1bmN0aW9uIG9mIGtyZWZzIGluIHRoZSBsaW51eCBrZXJuZWw6IGlmIHlvdXINCj4+ IGNvZGUgaG9sZHMgYSByZWZlcmVuY2UgdG8gYW4gb2JqZWN0LCB5b3UgY2FuIGJlIHN1cmUgdGhh dCB0aGlzIG9iamVjdCBpcw0KPj4gZXhpc3RzIGluIG1lbW9yeS4NCj4+IA0KPj4gT24gb3RoZXIg aGFuZCwgaXQgc2VlbXMgdGhhdCB5b3UgYXJlIGNvbnNpZGVyaW5nIHRoaXMgcmVmY250IGFzIGFu IHVzYWdlDQo+PiBjb3VudGVyIGZvciBhbiBhY3R1YWwgUENJIGRldmljZSwgbm90ICJzdHJ1Y3Qg cGRldiIgdGhhdCByZXByZXNlbnQNCj4+IGl0LiBUaG9zZSBhcmUgdHdvIHJlbGF0ZWQgdGhpbmdz LCBidXQgbm90IHRoZSBzYW1lLiBTbywgSSBjYW4gc2VlIHdoeQ0KPj4geW91IGFyZSBzdWdnZXN0 aW5nIHRvIGdldCBhZGRpdGlvbmFsIHJlZmVyZW5jZSB0aGVyZS4gQnV0IGZvciBtZSwgdGhpcw0K Pj4gbG9va3MgdW5uZWNlc3Nhcnk6IHRoZSB2ZXJ5IGZpcnN0IHJlZmNvdW50IGlzIG9idGFpbmVk IGluDQo+PiBwY2lfYWRkX2RldmljZSgpIGFuZCB0aGVyZSBpcyB0aGUgY29ycmVzcG9uZGluZyBm dW5jdGlvbg0KPj4gcGNpX3JlbW92ZV9kZXZpY2UoKSB0aGF0IHdpbGwgZHJvcCB0aGlzIHJlZmNv dW50LiBTbywgZm9yIG1lLCBpZiBhZG1pbg0KPj4gd2FudHMgdG8gcmVtb3ZlIGEgUENJIGRldmlj ZSB3aGljaCBpcyBhc3NpZ25lZCB0byBhIGRvbWFpbiwgdGhleSBjYW4gZG8NCj4+IHRoaXMgYXMg dGhleSB3ZXJlIGFibGUgdG8gZG8gdGhpcyBwcmlvciB0aGlzIHBhdGNoZXMuDQo+DQo+IFRoaXMg aXMgYWxsIGZpbmUsIGJ1dCBuZWVkcyB0byBiZSBzdGF0ZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdl Lg0KPg0KDQpTdXJlLCBJIHdpbGwgYWRkIHRoaXMuDQoNCj4+IFRoZSBtYWluIHZhbHVlIG9mIGlu dHJvZHVjaW5nIHJlZmNudCBpcyB0byBiZSBhYmxlIHRvIGFjY2VzcyBwZGV2IG9iamVjdHMNCj4+ IHdpdGhvdXQgaG9sZGluZyB0aGUgZ2xvYmFsIHBjaWRldnNfbG9jaygpLiBUaGlzIGRvZXMgbm90 IG1lYW4gdGhhdCB5b3UNCj4+IGRvbid0IG5lZWQgbG9ja2luZyBhdCBhbGwuIEJ1dCB0aGlzIGFs bG93cyB5b3UgdG8gdXNlIHBkZXYtPmxvY2sgKHdoaWNoDQo+PiBkb2VzIG5vdCBleGlzdHMgaW4g dGhpcyBzZXJpZXMsIGJ1dCB3YXMgaW50cm9kdWNlZCBpbiBhIFJGQyBlYXJsaWVyKSwgb3INCj4+ IHZwY2ktPmxvY2ssIG9yIGFueSBvdGhlciBzdWJzeXN0ZW0tPmxvY2suDQo+DQo+IEkgZ3Vlc3Mg SSB3YXMgbWlzc2luZyB0aGlzIG90aGVyIGJpdCBhYm91dCBpbnRyb2R1Y2luZyBhDQo+IHBlci1k ZXZpY2UgbG9jaywgd291bGQgaXQgYmUgcG9zc2libGUgdG8gYnVuZGxlIGFsbCB0aGlzIHRvZ2V0 aGVyIGludG8NCj4gYSBzaW5nbGUgcGF0Y2ggc2VyaWVzPw0KDQpBcyBJIHNhaWQgYXQgdGhlIHRv cCBvZiB0aGlzIGVtYWlsLCBpdCB3YXMgdHJpZWQuIFlvdSBjYW4gY2hlY2sgUkZDIGF0IFsxXS4N Cg0KPg0KPiBJdCB3b3VsZCBiZSBnb29kIHRvIHBsYWNlIHRoaXMgY2hhbmdlIHRvZ2V0aGVyIHdp dGggYW55IG90aGVyIGxvY2tpbmcNCj4gcmVsYXRlZCBjaGFuZ2UgdGhhdCB5b3UgaGF2ZSBwZW5k aW5nLg0KDQpIb25lc3RseSwgbXkgbWFpbiBnb2FsIGlzIHRvIGZpeCB0aGUgY3VycmVudCBpc3N1 ZXMgd2l0aCB2UENJLCBzbyBBUk0NCmNhbiBtb3ZlIGZvcndhcmQgb24gYWRkaW5nIFBDSSBzdXBw b3J0IGZvciB0aGUgcGxhdGZvcm0uIFNvLCBJIGFtDQpmb2N1c2luZyBvbiB0aGlzIHJpZ2h0IG5v dy4NCg0KWzFdDQpodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVs L2NvdmVyLzIwMjIwODMxMTQxMDQwLjEzMjMxLTEtdm9sb2R5bXlyX2JhYmNodWtAZXBhbS5jb20v DQoNClsyXQ0KaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9j b3Zlci8yMDIyMDIxNjE1MTYyOC4xNjEwNzc3LTEtYW5kcjIwMDBAZ21haWwuY29tLw0KDQotLSAN CldCUiwgVm9sb2R5bXly From xen-devel-bounces@lists.xenproject.org Wed Apr 12 23:25:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Apr 2023 23:25:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520409.807945 (Exim 4.92) (envelope-from ) id 1pmjq1-0004p9-Tc; Wed, 12 Apr 2023 23:25:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520409.807945; Wed, 12 Apr 2023 23:25:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmjq1-0004p2-Qk; Wed, 12 Apr 2023 23:25:17 +0000 Received: by outflank-mailman (input) for mailman id 520409; Wed, 12 Apr 2023 23:25:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmjq0-0004ow-DM for xen-devel@lists.xenproject.org; Wed, 12 Apr 2023 23:25:16 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45f9ca5e-d989-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 01:25:13 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20EEB62E1D; Wed, 12 Apr 2023 23:25:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3A99C433EF; Wed, 12 Apr 2023 23:25:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45f9ca5e-d989-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681341911; bh=vPbyqvQQY1g9sdApUh+HKPuhZ4O391Xu9iswHov8S3E=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SPWtHMDfw22R1+xyrL3WXUPwDIm73YYfsCPu7ALXE7hzQf66/Hs+UGgPZ36t0uBy6 PGPLEUpXAhNDPhpFwvcFSmO4jXj5j0+keYBkpSjlaFAV6Yz7HsBQPRsIKsUKxaMD4B 0OU+sRtst683UepYfjcBjGHxDubT1O9r+N7bhsElqIzQxL0iXo8TQfVx/WRttLL6b8 FPU8aMiQzPOWh1YbQT8+peLo7IwNQU1XDEyx9o1zB84Vt0NY9ln03oGlhsDb3CJAC+ jb+39oSJTZOIMqmi2NTDMrW9YcfAz15tgrcuicNSfLwrvLHoeYtvrR1n5ZYDcoBzPK bdX5Zw5dvQGqQ== Date: Wed, 12 Apr 2023 16:25:08 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: xen-devel , "committers@xenproject.org" , Jan Beulich , Anthony PERARD , Stefano Stabellini , Doug Goldstein , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Henry Wang , michal.orzel@amd.com, anthony.perard@citrix.com, george.dunlap@cloud.com, julien@xen.org Subject: Re: Gitlab status on older branches (Inc some 4.18 blockers) In-Reply-To: <193206bf-76a0-818d-8fa8-1886a15ad5e5@citrix.com> Message-ID: References: <193206bf-76a0-818d-8fa8-1886a15ad5e5@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1692276256-1681338173=:15580" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1692276256-1681338173=:15580 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 12 Apr 2023, Andrew Cooper wrote: > Hello, > > I've done various backports to staging-4.14 and later trying to improve > the state of Gitlab testing. > > The good news is that 4.16 and 4.17 now pass.  The bad news is that > there are still bugs which need fixing, but lets start with the older > branches. > > Also, I was forced to backport an update to SeaBIOS 1.16 to all branches > in order to fix compile failures in build environments we supported at > the time of each of these releases.  I honestly don't know what we were > failing to do testing wise back then, but whatever we missed ought to > have been release blockers. > > > 4.15: > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/834460832 > > Individual failure instances: > > 1) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232265 > > This is a -Werror=array-bounds failure in HVMLoader but the same > job/container works in 4.16 and newer, and the underlying code is the > same.  There must be some change in the build environment, but I haven't > worked out what yet. > 2) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232266 > > This is a -Werror=array-bounds in iPXE.  Probably needs an update like > SeaBIOS too. Also seeing your valid comments below about using stable releases for tests, I think it would be reasonable to disable or allow_failure the archlinux tests in stable trees, given that archlinux is a rolling distro. This would "solve" 1) and 2) and also 5) and probably 6) below In the sense that maybe it doesn't make sense to backport fixes to 4.15 so that we can build 4.15 with versions of GCC released after 4.15 was out. I am open to all options, and also OK if we prefer to fix it. That leaves us with 3) and 4). > 3) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232290 > > This is a Qemu upstream failure which I do vaguely recall.  Bit it also > means that Xen 4.15 had a dead-on-arrival version of qemu which call > into question a number of our normal release activities.  Probably the > least-bad option is to backport the one fix relevant to this, because > changing the version of qemu in the security-only trees is far riskier > than changing one of the in-guest ROMs. This seems to be an header inclusion problem: /usr/include/linux/swab.h is picking up the BITS_PER_LONG implementation from QEMU (include/qemu/bitops.h) instead of the one from somewhere else under /usr/include. /usr/include/linux/swab.h:137:5: error: token is not a valid binary operator in a preprocessor subexpression #if BITS_PER_LONG == 64 ^~~~~~~~~~~~~ /builds/xen-project/people/andyhhp/xen/tools/qemu-xen-dir/include/qemu/bitops.h:20:41: note: expanded from macro 'BITS_PER_LONG' #define BITS_PER_LONG (sizeof (unsigned long) * BITS_PER_BYTE) ~~~~~~ ^ CC block/commit.o 1 error generated. /builds/xen-project/people/andyhhp/xen/tools/qemu-xen-dir/rules.mak:69: recipe for target 'block/file-posix.o' failed make: *** [block/file-posix.o] Error 1 I don't know which specific QEMU commit would solve this. Or whether we can get away with remove/install one or more Debian Stretch packages to make it work. There is a one more different failure here: https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232292 This one is: qemu-xen-dir/include/qemu/bitops.h:20:34: error: "sizeof" is not defined [-Werror=undef] #define BITS_PER_LONG (sizeof (unsigned long) * BITS_PER_BYTE) And it seems to match from qemu.git: commit b5d621ff4a7d86e82a58104d5706bda2b4238626 Author: Thomas Huth Date: Wed May 20 10:38:37 2020 +0200 gitlab-ci: Do not use the standard container images from gitlab which points to a problem with the base container image. > 4) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232334 > > I have no idea what's going on here.  If nothing else, we're failing to > collect all the relevant log files from a build and that probably wants https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01103.html >From the thread, the same error before happened when the QEMU configure invocation didn't have: -I$(XEN_ROOT)/tools/libs/devicemodel/include -L$(XEN_ROOT)/tools/libs/devicemodel in --extra-cflags However, there are no changes in tools/Makefile between 4.15 and 4.16 which makes me think this issue was fixed on the QEMU side instead. > 5) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097232324 > > This isn't so much about the failure, as the fact that the OpenSUSE Leap > tests (which were replaced with tumbleweed in newer versions of Xen) > probably want the same doing to them.  And being marked as > non-blocking.  This is a failure somewhere in the middle of qemu. > > But, on top of all of ^, I discovered that we have a majority of tests > being debian/unstable which, when we refreshed to fix the HTTPS issue, > ended up retrofitting a newer-than-at-release-time build environment to > the old trees. > > This has come up previously, and not addressed, so I'm now declaring it > a blocker for 4.18.  Only tests against a fixed disto version can be > blocking; those against an unstable distro must be non-blocking, and > most of the currently unstable things should be transformed into their > stable alternative.  For backports, we want to retrofit what > debian/unstable was at the time of release, rather than what it > currently is. Yes this is a good idea, +1 > Furthermore, the fixed distros we currently test in staging are old > bordering on obsolete.  Which is not a healthy position to be in as far > as the 4.18 release goes. > > > 4.14: > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/834461234 > > 6) https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4097236330 > > This is the only 4.14 failure I can see which isn't a duplicate of a > 4.15 failure, but it is an OpenSUSE leap failure in qemu so perhaps > related to #5 > > > As a general note, we still have too much testing (and/or insufficient > testing resource).  It's very painful waiting 2h for each branch to > complete.  I'm very tempted to trim things down further on staging and > backport the results. On the ARM side we should still be OK. On the x86 side, I was hoping to get more HW resources very soon. I wonder if any of the people in this thread have any updates? Otherwise, anyone that can temporarily contribute a workstation/server to run a gitlab-runner? --8323329-1692276256-1681338173=:15580-- From xen-devel-bounces@lists.xenproject.org Thu Apr 13 01:48:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 01:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520430.807986 (Exim 4.92) (envelope-from ) id 1pmm4k-00014a-BD; Thu, 13 Apr 2023 01:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520430.807986; Thu, 13 Apr 2023 01:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmm4k-00014T-7N; Thu, 13 Apr 2023 01:48:38 +0000 Received: by outflank-mailman (input) for mailman id 520430; Thu, 13 Apr 2023 01:48:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmm4j-00014J-I6; Thu, 13 Apr 2023 01:48:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmm4j-0001n3-GU; Thu, 13 Apr 2023 01:48:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmm4i-0001fQ-T0; Thu, 13 Apr 2023 01:48:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmm4i-0001Nx-SU; Thu, 13 Apr 2023 01:48:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Efr1PpMxeF4PwMSDVfXXEZlbxscJRHezAn5eQPmWoD0=; b=Y+LBEqdFRciHPggwSsBBLSRH/A TdG9XIcJT4SC5MYLVOj9WnRJG8fugwOfTXaHFNYv2pKjhtW9M/u8ZpSWGqsKIPYHMl8ZiAENankpz rpReNH3/aOvFdKQS92/laG4Knu46mWhvkGCSlcfOgNwYLZkh5LtcG+pnpXhXKLgMCpVs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 180218: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=7963cdbf91d8a8d2f8338171adab3807b20f658a X-Osstest-Versions-That: xen=11193e13e5359ba1896be46be3e9b468154c1295 From: osstest service owner Date: Thu, 13 Apr 2023 01:48:36 +0000 flight 180218 xen-4.15-testing real [real] flight 180224 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180218/ http://logs.test-lab.xenproject.org/osstest/logs/180224/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180224-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 179841 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 179841 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 179841 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 179841 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 179841 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 179841 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 179841 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 179841 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 179841 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 7963cdbf91d8a8d2f8338171adab3807b20f658a baseline version: xen 11193e13e5359ba1896be46be3e9b468154c1295 Last test of basis 179841 2023-03-21 12:36:45 Z 22 days Testing same since 180218 2023-04-12 08:06:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Julien Grall Roger Pau Monné Stefano Stabellini Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 11193e13e5..7963cdbf91 7963cdbf91d8a8d2f8338171adab3807b20f658a -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 04:12:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 04:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520437.807997 (Exim 4.92) (envelope-from ) id 1pmoK4-0007us-7s; Thu, 13 Apr 2023 04:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520437.807997; Thu, 13 Apr 2023 04:12:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmoK4-0007ul-4H; Thu, 13 Apr 2023 04:12:36 +0000 Received: by outflank-mailman (input) for mailman id 520437; Thu, 13 Apr 2023 04:12:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmoK2-0007ub-0L; Thu, 13 Apr 2023 04:12:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmoK1-0005h4-Rk; Thu, 13 Apr 2023 04:12:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmoK1-0005SO-F4; Thu, 13 Apr 2023 04:12:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmoK1-0004wt-Ee; Thu, 13 Apr 2023 04:12:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3piTDhAffuACSWOgcOwBkOjX2G8AOqMRvKGGVuuub0o=; b=zV8ncQl4oDVzW2YDo9R6C0cZFz uJK5bMzJa/ZL68+KhGf/+O/nwImzaQnr+LcvYcl7SdQ0PJhU4AwwDWlPLo2o8HeJfE0vqFHfVLY0m vWusGXZJaX9YDiqyJeF1QxkvEW896hwuk0t5OHBWA7sCM40wz1IAXYji5N+DBJRyJs7I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180226: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=f872a624cbf92de9944483eea7674ef80ced1380 X-Osstest-Versions-That: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f From: osstest service owner Date: Thu, 13 Apr 2023 04:12:33 +0000 flight 180226 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180226/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen f872a624cbf92de9944483eea7674ef80ced1380 baseline version: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f Last test of basis 180205 2023-04-11 13:03:27 Z 1 days Testing same since 180226 2023-04-13 02:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5ea03c570c..f872a624cb f872a624cbf92de9944483eea7674ef80ced1380 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 13 05:31:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 05:31:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520447.808006 (Exim 4.92) (envelope-from ) id 1pmpYL-00087i-Uo; Thu, 13 Apr 2023 05:31:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520447.808006; Thu, 13 Apr 2023 05:31:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmpYL-00087b-Rs; Thu, 13 Apr 2023 05:31:25 +0000 Received: by outflank-mailman (input) for mailman id 520447; Thu, 13 Apr 2023 05:31:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmpYL-00087R-2J; Thu, 13 Apr 2023 05:31:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmpYK-0008B0-VI; Thu, 13 Apr 2023 05:31:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmpYK-0000p8-BP; Thu, 13 Apr 2023 05:31:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmpYK-0002Gd-Ao; Thu, 13 Apr 2023 05:31:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+DEAbIgF2M9Hv8ngGWvCsnS1wOMBT/vILP8Mvt38pR4=; b=xBj8oz84jowqbDBKzm+TR0hUQO x05glM2gbF7S2XtEKjPHu3mgwfWdZjl/BY1j50XPjnYLOEgf5iXZr88VlPNuMmxJocmsrKDEp0DBm fEkgpooxcTepDYCXlbDwlX2bgpjyzDCXhpQ1YbV5f5ryRLG6NJ//x1R3gXPw3Jaw80Rg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 180219: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=31627a059c2e186f4ad12d171d964b09abe8a4a9 X-Osstest-Versions-That: xen=06264af090ac69a95cdadbc261cc82d964dcb568 From: osstest service owner Date: Thu, 13 Apr 2023 05:31:24 +0000 flight 180219 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/180219/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180086 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180086 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180086 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180086 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180086 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180086 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180086 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180086 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180086 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 31627a059c2e186f4ad12d171d964b09abe8a4a9 baseline version: xen 06264af090ac69a95cdadbc261cc82d964dcb568 Last test of basis 180086 2023-03-31 07:08:31 Z 12 days Testing same since 180219 2023-04-12 08:06:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Julien Grall Michal Orzel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 06264af090..31627a059c 31627a059c2e186f4ad12d171d964b09abe8a4a9 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520463.808071 (Exim 4.92) (envelope-from ) id 1pmrBN-0002Q4-Kz; Thu, 13 Apr 2023 07:15:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520463.808071; Thu, 13 Apr 2023 07:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBN-0002Px-Gc; Thu, 13 Apr 2023 07:15:49 +0000 Received: by outflank-mailman (input) for mailman id 520463; Thu, 13 Apr 2023 07:15:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBL-0001gr-Fq for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:47 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02094e23-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:15:45 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id u12so153802lfu.5 for ; Thu, 13 Apr 2023 00:15:45 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02094e23-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370145; x=1683962145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T8pIVujHEbhV2cnHgvkx7ic1HrkG7oPR2753cV35Lic=; b=j/zN3l9fv0KQLVQaEiGtYmZHRVx12v/6iL5ap9JHNd+d76QxhLEM7GP+H7rIAd+TjL DMa4mn0kjlYjBOTlMNIU6WzhszIdGrH9wEBvum0FYuM9tPkC/2IW7fvsK6ehOD9bBYEf 2pbG8Redd+mN7UYsohGRPBCPUqhc+6fqGkFA8WcXtnYF/HNJ1OT43UmhD11IvM7x17xs 7w+x4zBBLPtipshfSJya2xR+pE7uT+5vDvfUTn3wnvm4n95QkDutQt6Bl2syeeBGzUk2 20tatdWDtF8jLhYBzgwtZjuiImQfwc3UpJbjhPcDQ1JjZ71Ioo/5ge1+rA0oPatUzp9g B2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370145; x=1683962145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T8pIVujHEbhV2cnHgvkx7ic1HrkG7oPR2753cV35Lic=; b=XwBma4TmzI0scF73ODBGIHoFOmvlIAPc6finYzaf0PJwbY4FJt+mt6UfqlHqXTeuYH mrsZSyTvlfseiyE2bFe+S4TO/7uh/3yECFrDF9rNzUde7kMKcf+9WAxeZZHRwLRMfvdP RIBSU/zxBMv3RzjBxFHFKNno0Yo+j7s3hdaBLmk7/AXr9kv61OUlPyYChVasaUi9ZoCL URPAGlLN9xXVZnHjtNa1pBscJax+AcJYoGFf60jTw3olEACinHCaPYagSxjUFZNCVcaj nQZ5XatlQBRAOrERuQS+ppys9ImBIvUSuvJwyu8YykvkWp4g1E+lesbpTdePgFe0goyO BBNg== X-Gm-Message-State: AAQBX9ezts9t1CYa30ocvo49PYGdqyuC6bdJU4z5CmbkOl1IVZJEvi0C +kdmb5NGbE/UVvQLycS0wYq9zR5yB8tfG1wKb/Y= X-Google-Smtp-Source: AKy350bj4BD08C0CLbkgoYe6CCcHFDtvUrsW3hSspX4zO5IYWVp0t7iWRBIc5cwXOha6KG3DUvErSA== X-Received: by 2002:ac2:5d4e:0:b0:4eb:c18:efae with SMTP id w14-20020ac25d4e000000b004eb0c18efaemr591180lfd.17.1681370144856; Thu, 13 Apr 2023 00:15:44 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH v8 02/22] xen/arm: tee: add a primitive FF-A mediator Date: Thu, 13 Apr 2023 09:14:04 +0200 Message-Id: <20230413071424.3273490-3-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. This commit brings in only the parts needed to negotiate FF-A version number with guest and SPMC. [1] https://developer.arm.com/documentation/den0077/e Signed-off-by: Jens Wiklander --- xen/arch/arm/include/asm/psci.h | 4 + xen/arch/arm/include/asm/tee/ffa.h | 35 +++++ xen/arch/arm/tee/Kconfig | 11 ++ xen/arch/arm/tee/Makefile | 1 + xen/arch/arm/tee/ffa.c | 219 +++++++++++++++++++++++++++++ xen/arch/arm/vsmc.c | 17 ++- xen/include/public/arch-arm.h | 1 + 7 files changed, 285 insertions(+), 3 deletions(-) create mode 100644 xen/arch/arm/include/asm/tee/ffa.h create mode 100644 xen/arch/arm/tee/ffa.c diff --git a/xen/arch/arm/include/asm/psci.h b/xen/arch/arm/include/asm/psci.h index 832f77afff3a..4780972621bb 100644 --- a/xen/arch/arm/include/asm/psci.h +++ b/xen/arch/arm/include/asm/psci.h @@ -24,6 +24,10 @@ void call_psci_cpu_off(void); void call_psci_system_off(void); void call_psci_system_reset(void); +/* Range of allocated PSCI function numbers */ +#define PSCI_FNUM_MIN_VALUE _AC(0,U) +#define PSCI_FNUM_MAX_VALUE _AC(0x1f,U) + /* PSCI v0.2 interface */ #define PSCI_0_2_FN32(nr) ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ ARM_SMCCC_CONV_32, \ diff --git a/xen/arch/arm/include/asm/tee/ffa.h b/xen/arch/arm/include/asm/tee/ffa.h new file mode 100644 index 000000000000..44361a4e78e4 --- /dev/null +++ b/xen/arch/arm/include/asm/tee/ffa.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/include/asm/tee/ffa.h + * + * Arm Firmware Framework for ARMv8-A(FFA) mediator + * + * Copyright (C) 2023 Linaro Limited + */ + +#ifndef __ASM_ARM_TEE_FFA_H__ +#define __ASM_ARM_TEE_FFA_H__ + +#include +#include + +#include +#include + +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) + +static inline bool is_ffa_fid(uint32_t fid) +{ + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; + + return fn >= FFA_FNUM_MIN_VALUE && fn <= FFA_FNUM_MAX_VALUE; +} + +#ifdef CONFIG_FFA +#define FFA_NR_FUNCS 12 +#else +#define FFA_NR_FUNCS 0 +#endif + +#endif /*__ASM_ARM_TEE_FFA_H__*/ diff --git a/xen/arch/arm/tee/Kconfig b/xen/arch/arm/tee/Kconfig index 392169b2559d..923f08ba8cb7 100644 --- a/xen/arch/arm/tee/Kconfig +++ b/xen/arch/arm/tee/Kconfig @@ -8,3 +8,14 @@ config OPTEE virtualization-enabled OP-TEE present. You can learn more about virtualization for OP-TEE at https://optee.readthedocs.io/architecture/virtualization.html + +config FFA + bool "Enable FF-A mediator support (UNSUPPORTED)" if UNSUPPORTED + default n + depends on ARM_64 + help + This option enables a minimal FF-A mediator. The mediator is + generic as it follows the FF-A specification [1], but it only + implements a small subset of the specification. + + [1] https://developer.arm.com/documentation/den0077/latest diff --git a/xen/arch/arm/tee/Makefile b/xen/arch/arm/tee/Makefile index 982c87968447..58a1015e40e0 100644 --- a/xen/arch/arm/tee/Makefile +++ b/xen/arch/arm/tee/Makefile @@ -1,2 +1,3 @@ +obj-$(CONFIG_FFA) += ffa.o obj-y += tee.o obj-$(CONFIG_OPTEE) += optee.o diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c new file mode 100644 index 000000000000..aaf74c287aef --- /dev/null +++ b/xen/arch/arm/tee/ffa.c @@ -0,0 +1,219 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/tee/ffa.c + * + * Arm Firmware Framework for ARMv8-A (FF-A) mediator + * + * Copyright (C) 2023 Linaro Limited + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +/* Error codes */ +#define FFA_RET_OK 0 +#define FFA_RET_NOT_SUPPORTED -1 +#define FFA_RET_INVALID_PARAMETERS -2 +#define FFA_RET_NO_MEMORY -3 +#define FFA_RET_BUSY -4 +#define FFA_RET_INTERRUPTED -5 +#define FFA_RET_DENIED -6 +#define FFA_RET_RETRY -7 +#define FFA_RET_ABORTED -8 + +/* FFA_VERSION helpers */ +#define FFA_VERSION_MAJOR_SHIFT 16U +#define FFA_VERSION_MAJOR_MASK 0x7FFFU +#define FFA_VERSION_MINOR_SHIFT 0U +#define FFA_VERSION_MINOR_MASK 0xFFFFU +#define MAKE_FFA_VERSION(major, minor) \ + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ + ((minor) & FFA_VERSION_MINOR_MASK)) + +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) +/* The minimal FF-A version of the SPMC that can be supported */ +#define FFA_MIN_SPMC_VERSION FFA_VERSION_1_1 + +/* + * This is the version we want to use in communication with guests and SPs. + * During negotiation with a guest or a SP we may need to lower it for + * that particular guest or SP. + */ +#define FFA_MY_VERSION_MAJOR 1U +#define FFA_MY_VERSION_MINOR 1U +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ + FFA_MY_VERSION_MINOR) + +/* Function IDs */ +#define FFA_ERROR 0x84000060U +#define FFA_SUCCESS_32 0x84000061U +#define FFA_VERSION 0x84000063U + +struct ffa_ctx { + /* FF-A version used by the guest */ + uint32_t guest_vers; +}; + +/* Negotiated FF-A version to use with the SPMC */ +static uint32_t ffa_version __ro_after_init; + +static bool ffa_get_version(uint32_t *vers) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_VERSION, + .a1 = FFA_MY_VERSION, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) + { + gprintk(XENLOG_ERR, "ffa: FFA_VERSION returned not supported\n"); + return false; + } + + *vers = resp.a0; + + return true; +} + +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, + register_t v2, register_t v3, register_t v4, register_t v5, + register_t v6, register_t v7) +{ + set_user_reg(regs, 0, v0); + set_user_reg(regs, 1, v1); + set_user_reg(regs, 2, v2); + set_user_reg(regs, 3, v3); + set_user_reg(regs, 4, v4); + set_user_reg(regs, 5, v5); + set_user_reg(regs, 6, v6); + set_user_reg(regs, 7, v7); +} + +static void handle_version(struct cpu_user_regs *regs) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + uint32_t vers = get_user_reg(regs, 1); + + if ( vers < FFA_VERSION_1_1 ) + vers = FFA_VERSION_1_0; + else + vers = FFA_VERSION_1_1; + + ctx->guest_vers = vers; + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); +} + +static bool ffa_handle_call(struct cpu_user_regs *regs) +{ + uint32_t fid = get_user_reg(regs, 0); + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + if ( !ctx ) + return false; + + switch ( fid ) + { + case FFA_VERSION: + handle_version(regs); + return true; + + default: + gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); + return false; + } +} + +static int ffa_domain_init(struct domain *d) +{ + struct ffa_ctx *ctx; + + if ( !ffa_version ) + return -ENODEV; + + ctx = xzalloc(struct ffa_ctx); + if ( !ctx ) + return -ENOMEM; + + d->arch.tee = ctx; + + return 0; +} + +/* This function is supposed to undo what ffa_domain_init() has done */ +static int ffa_relinquish_resources(struct domain *d) +{ + struct ffa_ctx *ctx = d->arch.tee; + + if ( !ctx ) + return 0; + + XFREE(d->arch.tee); + + return 0; +} + +static bool ffa_probe(void) +{ + uint32_t vers; + unsigned int major_vers; + unsigned int minor_vers; + + /* + * psci_init_smccc() updates this value with what's reported by EL-3 + * or secure world. + */ + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) + { + printk(XENLOG_ERR + "ffa: unsupported SMCCC version %#x (need at least %#x)\n", + smccc_ver, ARM_SMCCC_VERSION_1_2); + return false; + } + + if ( !ffa_get_version(&vers) ) + return false; + + if ( vers < FFA_MIN_SPMC_VERSION || vers > FFA_MY_VERSION ) + { + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers); + return false; + } + + major_vers = (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR_MASK; + minor_vers = vers & FFA_VERSION_MINOR_MASK; + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", + FFA_MY_VERSION_MAJOR, FFA_MY_VERSION_MINOR); + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", + major_vers, minor_vers); + + ffa_version = vers; + + return true; +} + +static const struct tee_mediator_ops ffa_ops = +{ + .probe = ffa_probe, + .domain_init = ffa_domain_init, + .relinquish_resources = ffa_relinquish_resources, + .handle_call = ffa_handle_call, +}; + +REGISTER_TEE_MEDIATOR(ffa, "FF-A", XEN_DOMCTL_CONFIG_TEE_FFA, &ffa_ops); diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index cd68fa80e98a..7f2f5eb9ce3d 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -24,7 +25,7 @@ #define XEN_SMCCC_FUNCTION_COUNT 3 /* Number of functions currently supported by Standard Service Service Calls. */ -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) { @@ -188,13 +189,23 @@ static bool handle_existing_apis(struct cpu_user_regs *regs) return do_vpsci_0_1_call(regs, fid); } +static bool is_psci_fid(uint32_t fid) +{ + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; + + return fn >= PSCI_FNUM_MIN_VALUE && fn <= PSCI_FNUM_MAX_VALUE; +} + /* PSCI 0.2 interface and other Standard Secure Calls */ static bool handle_sssc(struct cpu_user_regs *regs) { uint32_t fid = (uint32_t)get_user_reg(regs, 0); - if ( do_vpsci_0_2_call(regs, fid) ) - return true; + if ( is_psci_fid(fid) ) + return do_vpsci_0_2_call(regs, fid); + + if ( is_ffa_fid(fid) ) + return tee_handle_call(regs); switch ( fid ) { diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced5097a..92aff923056a 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -296,6 +296,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); #define XEN_DOMCTL_CONFIG_TEE_NONE 0 #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 +#define XEN_DOMCTL_CONFIG_TEE_FFA 2 struct xen_arch_domainconfig { /* IN/OUT */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520468.808119 (Exim 4.92) (envelope-from ) id 1pmrBR-0003e2-Tt; Thu, 13 Apr 2023 07:15:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520468.808119; Thu, 13 Apr 2023 07:15:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBR-0003cB-NB; Thu, 13 Apr 2023 07:15:53 +0000 Received: by outflank-mailman (input) for mailman id 520468; Thu, 13 Apr 2023 07:15:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBP-0001gq-Dc for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:51 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0550939e-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:50 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id d7so28946612lfj.3 for ; Thu, 13 Apr 2023 00:15:50 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0550939e-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370150; x=1683962150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/vIqA0Q41NfcSAHoiP+QU7NDN221D0N/8z0QGKDCRsU=; b=NZKECmgRCwD3/Qt/bQB0GE/LjYiBu8Q2NiBGD0tYIoffAUzZUEIEg1ZhPAEM7wCIzB HVRzL93FmjUV+sQFKE63TqJy5SYL88iVwe0lhTKx8TzLqP5FsngVGv7NwsYdzj95bZkq 74bNTFshVeGzooHtp9hPQFnB4uaRKEG/Lisi2zZPBdCp48nfvov6kx6pBaF3+rbPaAzr SmyHDDmGE4vy/RGBE2uPyLO0X9dMF9dNbI0JYHkyKS1Qzyc6KKfvWp4ukx1qDGyP8Tga 56Od1+AyTWKqEYvWJ6u5nmVv+eavkqdnMP3m2gs7QCgLCxg0HySO9LooAAMSod4CTMFt OznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370150; x=1683962150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/vIqA0Q41NfcSAHoiP+QU7NDN221D0N/8z0QGKDCRsU=; b=I4l2vRPuCadQetVMKL9mQ/0Y+xyxaa2XQIgG9VZDqJj1jAJJFB0hQ8xaKep9BlBHmI enCxi0yYmNVl91TWoJDiE4YkvBXSrPxRCtF0wwsk15tyCS/QsroA5P0Ke/d5k9FKIKe/ yhGTT9u7l0l4WNnkn5bq7YeALK6qGOa726SYzwRzNmwTDbfa7JisUctKunQq2iRAXJH/ 8Oxpk5sFvqYucgpBQ5iZNGOlJjNExUcR4Uk8u46voMRUxeA1+7eIokKAR269rGylOBqJ 45UxuDXjkolvQKG/y4XdFDEfNThsfUQi/ACoDPcNCooLYI2FXxpNOYMUm5/I7wALkmsS cScQ== X-Gm-Message-State: AAQBX9dCU6fStQ8+Joxv3VV3JlEkgw/qi+bbF620h3GCyomyrb9HPQ9i G9uHZlidmK7FpGfl+cI7KAMnEL1N2gcxtNcdVQQ= X-Google-Smtp-Source: AKy350Yeiq68Y6+HSv/qOyPfcMO+tL0U6l+2JdS8VPoPn1UifZK4LBUiSq/JMu8PwrkWsTEHHs2mfQ== X-Received: by 2002:a19:f60e:0:b0:4e8:5576:98f4 with SMTP id x14-20020a19f60e000000b004e8557698f4mr563090lfe.45.1681370150463; Thu, 13 Apr 2023 00:15:50 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Date: Thu, 13 Apr 2023 09:14:11 +0200 Message-Id: <20230413071424.3273490-10-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for sending a FF-A direct request. Checks that the SP also supports handling a 32-bit direct request. 64-bit direct requests are not used by the mediator itself so there is not need to check for that. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 112 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index f129879c5b81..f2cce955d981 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) return true; } +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) +{ + switch ( resp->a0 ) + { + case FFA_ERROR: + if ( resp->a2 ) + return resp->a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + case FFA_SUCCESS_64: + return FFA_RET_OK; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a2, + register_t a3, register_t a4) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = fid, + .a1 = a1, + .a2 = a2, + .a3 = a3, + .a4 = a4, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + return get_ffa_ret_code(&resp); +} + +static int32_t ffa_features(uint32_t id) +{ + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); +} + +static bool check_mandatory_feature(uint32_t id) +{ + int32_t ret = ffa_features(id); + + if (ret) + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing: error %d\n", + id, ret); + + return !ret; +} + static uint16_t get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -222,6 +272,57 @@ static void handle_version(struct cpu_user_regs *regs) set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); } +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) +{ + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; + struct arm_smccc_1_2_regs resp = { }; + struct domain *d = current->domain; + uint32_t src_dst; + uint64_t mask; + + if ( smccc_is_conv_64(fid) ) + mask = GENMASK_ULL(63, 0); + else + mask = GENMASK_ULL(31, 0); + + src_dst = get_user_reg(regs, 1); + if ( (src_dst >> 16) != get_vm_id(d) ) + { + resp.a0 = FFA_ERROR; + resp.a2 = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + arg.a1 = src_dst; + arg.a2 = get_user_reg(regs, 2) & mask; + arg.a3 = get_user_reg(regs, 3) & mask; + arg.a4 = get_user_reg(regs, 4) & mask; + arg.a5 = get_user_reg(regs, 5) & mask; + arg.a6 = get_user_reg(regs, 6) & mask; + arg.a7 = get_user_reg(regs, 7) & mask; + + arm_smccc_1_2_smc(&arg, &resp); + switch ( resp.a0 ) + { + case FFA_ERROR: + case FFA_SUCCESS_32: + case FFA_SUCCESS_64: + case FFA_MSG_SEND_DIRECT_RESP_32: + case FFA_MSG_SEND_DIRECT_RESP_64: + break; + default: + /* Bad fid, report back. */ + memset(&arg, 0, sizeof(arg)); + arg.a0 = FFA_ERROR; + arg.a1 = src_dst; + arg.a2 = FFA_RET_ABORTED; + } + +out: + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & mask, + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); +} + static bool ffa_handle_call(struct cpu_user_regs *regs) { uint32_t fid = get_user_reg(regs, 0); @@ -239,6 +340,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_ID_GET: set_regs_success(regs, get_vm_id(d), 0); return true; + case FFA_MSG_SEND_DIRECT_REQ_32: + case FFA_MSG_SEND_DIRECT_REQ_64: + handle_msg_send_direct_req(regs, fid); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -326,6 +431,13 @@ static bool ffa_probe(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); + /* + * TODO save result of checked features and use that information to + * accept or reject requests from guests. + */ + if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + return false; + ffa_version = vers; return true; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520460.808041 (Exim 4.92) (envelope-from ) id 1pmrBL-0001hE-Jw; Thu, 13 Apr 2023 07:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520460.808041; Thu, 13 Apr 2023 07:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBL-0001h7-Gs; Thu, 13 Apr 2023 07:15:47 +0000 Received: by outflank-mailman (input) for mailman id 520460; Thu, 13 Apr 2023 07:15:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBK-0001gr-5N for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:46 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0100e1cd-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:15:43 +0200 (CEST) Received: by mail-lf1-x133.google.com with SMTP id i26so18220895lfc.6 for ; Thu, 13 Apr 2023 00:15:43 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0100e1cd-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370143; x=1683962143; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VMvjySMspSE015gZK69lV2WbUjdretJTAbkf7n0CxhU=; b=Lz+hZG3+qpCZKO5KqfGN+4tEOzNy3kN9j0ZEJl4JORDnXfr4lDA1vuEuexCKwVNBGb 5LT+zFisK/EdFBTpnjecyWIN5QQWQP2XOvGyYaKP5pItVCvNJFaXaXekZ6vIWcQYqh4t f1XDAkPkVqVrtorHhOz2mKbPwS5S1CH7emTH0H7t1bBKQyFK9rU9kA2gfs0+1bI6KycG 9k0Wh7lYUHpgCVAjntR7Kz6Bf4epqpw40EtYPZgTYGPUv0c+6EKzq29NLyKZVpRuB1qx ngEkneWug6IEOVJ5aeSZzT3XwDmYCH45UQ6zr9xoyFjk9u50Q2Jk6sPyz9Luu7CbU4hP qJxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370143; x=1683962143; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VMvjySMspSE015gZK69lV2WbUjdretJTAbkf7n0CxhU=; b=ZWQHm6pWqQ4UVrGLLRqB0Kda/BncgBxfgGJCVR8yzhF7lVZgk+ighQPeq/JUD5hxO1 6tPKo2bSDYJyMK8TCy5VAx8b5QxcobsYYuVcfOID/dvE/wWwbvHX+S2qhxMl7W6NqbIx WYPXEQ4qydChpEHCOZINpIvrkSsLzZvRVSKpHAjpPCS8dy5ceDgO7S5KEFX8bxYmfloR SLf7TBpTMX3QnbJlp3eJ8a/XCShQ9ZgVBdguolWzhxt1YEhhz5uLj4N4qXGo4zJBq33g Gxlxf0x98Tox0uG6+4Ha/2l9zp2jJ6qsfryuLJDWbaR0TwRnd8Roz9O/29/0GcVu77xk rjeQ== X-Gm-Message-State: AAQBX9ejH1NwoLK/UnF/QtxYAs064sKRh5zJwGLwZpzCW/1kGbJ8dHiY YlvnIv/vwfwT1FovULFJ99sn7DfLAU5acR49S+I= X-Google-Smtp-Source: AKy350Z7Z6sTH2OTRU5VHM21XPoxz9a5+BQOI0gle7wcKkeA8xcOkzPoaWtTBGKGHARxcWkEYj4TTw== X-Received: by 2002:a19:c215:0:b0:4b6:f51e:b8b6 with SMTP id l21-20020a19c215000000b004b6f51eb8b6mr486047lfc.56.1681370142959; Thu, 13 Apr 2023 00:15:42 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Luca Fancellu , Julien Grall , Michal Orzel Subject: [XEN PATCH v8 00/22] Xen FF-A mediator Date: Thu, 13 Apr 2023 09:14:02 +0200 Message-Id: <20230413071424.3273490-1-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This patch sets add an FF-A [1] mediator to the TEE mediator framework already present in Xen. The FF-A mediator implements the subset of the FF-A 1.1 specification needed to communicate with OP-TEE using FF-A as transport mechanism instead of SMC/HVC as with the TEE mediator. It allows a similar design in OP-TEE as with the TEE mediator where OP-TEE presents one virtual partition of itself to each guest in Xen. The FF-A mediator is generic in the sense it has nothing OP-TEE specific except that only the subset needed for OP-TEE is implemented so far. The hooks needed to inform OP-TEE that a guest is created or destroyed are part of the FF-A specification. It should be possible to extend the FF-A mediator to implement a larger portion of the FF-A 1.1 specification without breaking with the way OP-TEE is communicated with here. So it should be possible to support any TEE or Secure Partition using FF-A as transport with this mediator. The patches are also available at https://github.com/jenswi-linaro/xen branch "xen_ffa_v8". With help from Bertrand I've integrated this in a test setup with OP-TEE. Please check prerequisites at https://optee.readthedocs.io/en/latest/building/prerequisites.html My setup is duplicated using: repo init -u https://github.com/jenswi-linaro/manifest.git -m qemu_v8.xml \ -b qemu_xen_ffa repo sync -j8 cd build make -j8 toolchains make -j8 all make run-only Test in dom0 with for instance: xtest 1004 at the prompt. To start up a domu and connect to it do: cd /mnt/host/build/qemu_v8/xen xl create guest_ffa.cfg xl console domu Then test as usual with "xtest 1004". The setup uses the branch "ffa" from https://github.com/jenswi-linaro/xen. That's currently the same as the "xen_ffa_v8" branch, but the "ffa" branch may change later as I update for a new version of the patch set. [1] https://developer.arm.com/documentation/den0077/latest Thanks, Jens v7->v8: * Adding "xen/arm: ffa: list current limitations" as requested * Adding tags to "xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers" * Patch "xen/arm: tee: add a primitive FF-A mediator": - Changing license for ffa.h and ffa.c to GPL-2.0-only - Avoiding IS_ENABLED() in the constant FFA_NR_FUNCS - Accepting version 1.1 SPMC only to keep things simple - Removes 32bit and only supports 64bit to keep things simple * Patch "tools: add Arm FF-A mediator" - Adding Reviewed-by: Bertrand Marquis - Adding LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE_FFA for the "ffa" value in arch_arm.tee * Patch "docs: add Arm FF-A mediator" - Fixing a spell error - Moving the patch last in the series * Patch "xen/arm: ffa: add remaining SMC function IDs" - Adding Reviewed-by: Bertrand Marquis - Renaming the define FFA_MSG_RUN to FFA_RUN to match the specification * Patch "xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET" - Updating the comment describing the flags for FFA_PARTITION_INFO_GET * Patch "xen/arm: ffa: add defines for framework direct request/response messages" - Updating the comment describing the flags for MSG_SEND_DIRECT_REQ/RESP * Patch "xen/arm: ffa: enforce dependency on 4k pages" - Updating title of patch - Adding Reviewed-by: Bertrand Marquis * Patch "xen/arm: ffa: add support for FFA_ID_GET" - In ffa_domain_init(), check that domain_id isn't greater than UINT16_MAX to avoid a future potential integer overflow in get_vm_id() * Patch "xen/arm: ffa: add direct request support" - Move preemption (interrupted) parts to a separate patch "xen/arm: ffa: support preemption of SP during direct request" - Remove loop in handle_msg_send_direct_req() to return eventual errors back to the VM instead of the SP. * Patch "xen/arm: ffa: map SPMC rx/tx buffers" - Adding a FFA_RXTX_PAGE_COUNT define instead of using 1 directly * New patch "xen/arm: ffa: support preemption of SP during direct request" * Patch "xen/arm: ffa: send guest events to Secure Partitions" - Replacing unsigned int with uint16_t for subscr_vm_created_count and subscr_vm_destroyed_count plus the needed range check to see that they don't overflow. * Patch "xen/arm: ffa: support mapping guest RX/TX buffers" - Limit the number of pages in VM RX/TX buffers to 32 using a new FFA_MAX_RXTX_PAGE_COUNT define. * Patch "xen/arm: ffa: support guest FFA_PARTITION_INFO_GET" - Renaming tx_is_mine to rx_is_free as requested - Simplified the FFA_PARTITION_INFO_GET_COUNT_FLAG check in handle_partition_info_get() - Adding a comment on ownership of the RX buffer - Adding the patch "xen/arm: ffa: improve lock granularity" to address parts of the locking concerns. * Patch "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" - Adding Reviewed-by: Bertrand Marquis * Patch "xen/arm: ffa: add defines for sharing memory" - Fixing reference for FFA_NORMAL_MEM_REG_ATTR and FFA_MEM_ACC_RW - Updating descirption for FFA_MAX_SHM_PAGE_COUNT * Patch "xen/arm: ffa: add ABI structs for sharing memory" - Changing name of the "global_handle" memeber in struct ffa_mem_transaction_* to "handle". * Patch "xen/arm: ffa: support sharing memory" - Use FFA_MEM_SHARE_64 only since we changed to only suporting ARM_64. - Rename struct ffa_mem_transaction_x to struct ffa_mem_transaction_int as requested. - Adding a check that shm->page_count isn't 0 before calling share_shm() - Masking return value from FFA_MEM_FRAG_RX to avoid an implic cast to the int32_t returned by ffa_mem_share(). * Patch "xen/arm: ffa: add support to reclaim shared memory" - Adding Reviewed-by: Bertrand Marquis * Patch "xen/arm: ffa: support sharing large memory ranges" - Adding commetns for struct ffa_ctx - Cleaning up and removing the fragmentation state if handle_mem_frag_tx() detects an error. * Adding "xen/arm: ffa: improve lock granularity" to address some of the locking concerns. v6->v7: * Split some of the larger patches into smaller patches for easier review. For instance, the v6 patch "xen/arm: add a primitive FF-A mediator" has been replaced with: - "xen/arm: add a primitive FF-A mediator" - "tools: add Arm FF-A mediator" - "docs: add Arm FF-A mediator" - "xen/arm: ffa: add remaining SMC function IDs" * Some small fixes in the error path for handle_mem_share() * Switched to SPDX for license in new files. * Fixed comment style issues in "xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers" * Made FFA support UNSUPPORTED in "xen/arm: add a primitive FF-A mediator" * Replaced ffa_get_call_count() with FFA_NR_FUNCS * Update the FFA_MAX_SHM_PAGE_COUNT with a formula instead of a value. * Replaced XEN_ARM_FLAGS_FFA with XEN_DOMCTL_CONFIG_TEE_FFA to minimize impact on struct xen_arch_domainconfig. This works because the FF-A mediator and the OP-TEE mediator will not be used at the same time in by a guest. * Replaced "ffa" boolean in the guest config with a new "ffa" value to the enumeration "tee_type". * Integrated the FF-A mediator in the TEE mediator framework instead of being its own. * Rebased on staging as of 2023-02-16 v5->v6: * Updated "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" commit message and moved the patch right before the patch which needs it. Applied Michal Orzel's R-B tag. * Renamed the guest configuration option "ffa_enabled" to "ffa" and updated the description. * More tools update in "xen/arm: add a primitive FF-A mediator" with the "ffa" option, including golang and ocaml. * Update ffa_domain_init() to return an error if communication with the SPMC can't be established. * Factored out a ffa_domain_destroy() from ffa_relinquish_resources(). * Added ffa_get_call_count() to give an accurate number of FF-A function, updated in each patch as new FF-A functions are added. * Added a flags field in struct xen_arch_domainconfig that replaces the ffa_enabled field. * Made check_mandatory_feature() __init * Replaced a few printk() calls with gprintk() where needed. * Rebased on staging as of 2022-09-14 V4->v5: * Added "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" * Added documentation for the "ffa_enabled" guest config flag * Changed to GPL license for xen/arch/arm/ffa.c * Added __read_mostly and const where applicable * Added more describing comments in the code * Moved list of shared memory object ("ffa_mem_list") into the guest context as they are guest specific * Simplified a few of the simple wrapper functions for SMC to SPMC * Added a BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE) since the mediator currently depends on the page size to be same as FFA_PAGE_SIZE (4k). * Added max number of shared memory object per guest and max number of size of each shared memory object * Added helper macros to calculate offsets of different FF-A data structures in the communication buffer instead of relying on pointer arithmetic * Addressed style issues and other comments * Broke the commit "xen/arm: add FF-A mediator" into multiple parts, trying to add a few features at a time as requested * Added a missing call to rxtx_unmap() in ffa_relinquish_resources() * Assignment of "ffa_enabled" is kept as is until I have something definitive on the type etc. * Tested with CONFIG_DEBUG=y v3->v4: * Missed v3 and sent a v4 instead by mistake. v2->v3: * Generates offsets into struct arm_smccc_1_2_regs with asm-offsets.c in order to avoid hard coded offsets in the assembly function arm_smccc_1_2_smc() * Adds an entry in SUPPORT.md on the FF-A status * Adds a configuration variable "ffa_enabled" to tell if FF-A should be enabled for a particular domu guest * Moves the ffa_frag_list for fragmented memory share requests into struct ffa_ctx instead to keep it per guest in order to avoid mixups and simplify locking * Adds a spinlock to struct ffa_ctx for per guest locking * Addressing style issues and suggestions * Uses FFA_FEATURES to check that all the needed features are available before initializing the mediator * Rebased on staging as of 2022-06-20 v1->v2: * Rebased on staging to resolve some merge conflicts as requested Jens Wiklander (22): xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers xen/arm: tee: add a primitive FF-A mediator tools: add Arm FF-A mediator xen/arm: ffa: add remaining SMC function IDs xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET xen/arm: ffa: add defines for framework direct request/response messages xen/arm: ffa: enforce dependency on 4k pages xen/arm: ffa: add support for FFA_ID_GET xen/arm: ffa: add direct request support xen/arm: ffa: map SPMC rx/tx buffers xen/arm: ffa: send guest events to Secure Partitions xen/arm: ffa: support mapping guest RX/TX buffers xen/arm: ffa: support guest FFA_PARTITION_INFO_GET xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h xen/arm: ffa: add defines for sharing memory xen/arm: ffa: add ABI structs for sharing memory xen/arm: ffa: support sharing memory xen/arm: ffa: add support to reclaim shared memory xen/arm: ffa: support sharing large memory ranges xen/arm: ffa: improve lock granularity xen/arm: ffa: list current limitations docs: add Arm FF-A mediator SUPPORT.md | 8 + docs/man/xl.cfg.5.pod.in | 15 + tools/include/libxl.h | 5 + tools/libs/light/libxl_arm.c | 3 + tools/libs/light/libxl_types.idl | 3 +- xen/arch/arm/arm64/asm-offsets.c | 9 + xen/arch/arm/arm64/smc.S | 42 + xen/arch/arm/include/asm/psci.h | 4 + xen/arch/arm/include/asm/regs.h | 12 + xen/arch/arm/include/asm/smccc.h | 40 + xen/arch/arm/include/asm/tee/ffa.h | 35 + xen/arch/arm/tee/Kconfig | 11 + xen/arch/arm/tee/Makefile | 1 + xen/arch/arm/tee/ffa.c | 1950 ++++++++++++++++++++++++++++ xen/arch/arm/tee/optee.c | 11 - xen/arch/arm/vsmc.c | 19 +- xen/include/public/arch-arm.h | 1 + 17 files changed, 2153 insertions(+), 16 deletions(-) create mode 100644 xen/arch/arm/include/asm/tee/ffa.h create mode 100644 xen/arch/arm/tee/ffa.c -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520465.808083 (Exim 4.92) (envelope-from ) id 1pmrBO-0002cz-Ge; Thu, 13 Apr 2023 07:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520465.808083; Thu, 13 Apr 2023 07:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBO-0002bP-Bd; Thu, 13 Apr 2023 07:15:50 +0000 Received: by outflank-mailman (input) for mailman id 520465; Thu, 13 Apr 2023 07:15:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBM-0001gq-PI for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:48 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 036225ef-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:47 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id d7so28946432lfj.3 for ; Thu, 13 Apr 2023 00:15:47 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 036225ef-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370147; x=1683962147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=09FoNIBfx/AhxypRHIQzVNktgeSQpjk+3JcEVMVKSbQ=; b=mL3AGTAscDTr06MSOYuyOae/9mF5PB5pXeLkrsbHjr7olu0YfJ8Jy5+7ZIUDQG0x/e r+bvqpbM2txxDX1PdmXV6Rr8mr0rp8uqqqm+9VxnBFE3x1TPAjZcVMskqm3G5xnlZ4gW v4ak64XkvDUjMOkYgUY5KPCsFxiM3UlVYGmackYnC6HlqAoKnUtfMpv/khYJ1MMJbU66 MD1R1MsSPgAJawf26IakdMQ1Lf8+EQDHRdEVo7NNBWl2ioMhR6D5k88Ru88KE+vJeraX RC2ZoqUjsyZoDJsQlj6lFscE96hlR5xbIZW7FDy0ZzDIDVtI+fLqpUBuQ+03HRjbQezk 7aIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370147; x=1683962147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=09FoNIBfx/AhxypRHIQzVNktgeSQpjk+3JcEVMVKSbQ=; b=N8owYxrnxmRUUnnJAyx1008JKere+IsFKpEUa7DGvNYVVtrm6kWxsn5LcbRXnaRkFa JFmW6jde8GB5X5RkX0kU1Pw/wbcbntju8ACPjpkYckQNWW/UnYlOymCB2rQLhARde5nj RoDbEI370RCR9a340W5KJfQnrXb9NJa5rvuH9flhpzOWS29kMeY8QtnhchbgX72bcgX5 YeQbxP3hHQRM1+WI15RHCXnWgVKUJF+1xIaDpXgkFujN8BOdGFkpvPrDgQGC8NXqX5YP qknOovM2OKPWc8KXsK3GN5ePeVuuJajiA7mxp+SXAqFGPeM56AAJ5kuat7q2ItM3MMEa oGJA== X-Gm-Message-State: AAQBX9csACw1OB0PX2ZJxmTyybv3UHfiGLylYibClV86oOrsxqbfn+Us ta09cTsEdozi6m0ipf1lPGfZfLF6UOM9LUdhQ8Y= X-Google-Smtp-Source: AKy350Zu4mlvVFjzT3PBZkyGciR4NH8yu2tbn2rzyYy9BZQSqAIwB2Q8kebTAuck9yLTVDRzxW+ibg== X-Received: by 2002:ac2:4199:0:b0:4ec:a218:4f8f with SMTP id z25-20020ac24199000000b004eca2184f8fmr509860lfh.8.1681370147122; Thu, 13 Apr 2023 00:15:47 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Date: Thu, 13 Apr 2023 09:14:07 +0200 Message-Id: <20230413071424.3273490-6-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Defines flags used for the function FFA_PARTITION_INFO_GET. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index ba0942e76993..72e7d0575de5 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -57,6 +57,40 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* + * Flags to determine partition properties in FFA_PARTITION_INFO_GET return + * message: + * BIT(0): Supports receipt of direct requests + * BIT(1): Can send direct requests + * BIT(2): Can send and receive indirect messages + * BIT(3): Supports receipt of notifications + * BIT(4-5): Partition ID is a PE endpoint ID + * BIT(6): Partition must be informed about each VM that is created by + * the Hypervisor + * BIT(7): Partition must be informed about each VM that is destroyed by + * the Hypervisor + * BIT(8): Partition runs in the AArch64 execution state else AArch32 + * execution state + */ +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) +#define FFA_PART_PROP_IS_MASK (3U << 4) +#define FFA_PART_PROP_IS_PE_ID (0U << 4) +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) + +/* + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition + * count only. + */ +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) + /* Function IDs */ #define FFA_ERROR 0x84000060U #define FFA_SUCCESS_32 0x84000061U -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520462.808052 (Exim 4.92) (envelope-from ) id 1pmrBM-0001oM-9N; Thu, 13 Apr 2023 07:15:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520462.808052; Thu, 13 Apr 2023 07:15:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBM-0001mg-2c; Thu, 13 Apr 2023 07:15:48 +0000 Received: by outflank-mailman (input) for mailman id 520462; Thu, 13 Apr 2023 07:15:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBL-0001gq-7R for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:47 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 027433b3-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:46 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id 26so1146103lfq.11 for ; Thu, 13 Apr 2023 00:15:46 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 027433b3-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370145; x=1683962145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jvHKHuXznPMzD/YrdwjpNkW0g0k7uCPv2OF4tumTIDg=; b=DxBHQVm8UihnJHYKIUCIRR4mhys8QHkTlgKUvBv8RJDmjDYQTMTPuDqqbViOSBsbn2 TNVIM8CmIpsufjdLysMS5NUS4UnMM5V/uwkNyVXARSx0YudIWg47FsTbgoiUHhKGzk3i /j0A6GHghGov3HPZGsQSdoKqlqR3bH34EeaysF2xnw5mjSTa1CzzPYQ+LoQsutJ7NPkm 6jQGzFuqFkX0M/O44D7zzJS3Y0vrkJB4s05OQBzsCMDuO+ThxyZlM1inrgAZwLbKPMF/ iFZPHdsAekJLRjDwylEiL1Jswv+jzPIiPlylHHf0VQR5MJ9dXMtSfVePZ2PtzRhGlflx CJmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370145; x=1683962145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvHKHuXznPMzD/YrdwjpNkW0g0k7uCPv2OF4tumTIDg=; b=IEZXGBrwI4SCipDzuZ7WcbEU9GOYlKr77+YwzGTGYg4MvvTH/qlsJXieUzftyYSsbw jleNGuGrJNogSBvSfiKt8EEimCVscvj/Qgf6ov3V1PeIHkHHoeHzow4zpc+xJC0XbUDR cJQvSWxV9eNLqdrzaPYkwO2Rq+1Fz1XrEio+4GEDHJDflFmWXlpGQIb1kWrT+sPeA3gJ pkEA80J5qgRI3im59hQYXEan/hVPu+V3vaZxkGicbqvW/MtyVDQgYwd/LgpMO4E0cu+h jsTRfghPXh8P8npSR3zqyADurHW/sWx7/MR9TQz359X3RAjMG+Ri6reVqW7iscaRVN1h omDA== X-Gm-Message-State: AAQBX9fdkFzylwaxLpvgcLSP3X6mwzU0fT4zQXS+taD9t8po/RoWn3QQ odBKi9OCwH7njn5J6svPr/x26vb+NNZkOf405tk= X-Google-Smtp-Source: AKy350a8U/l3Qa0bSPOl21Sj+Fuz5NilmrG2kLfKY3kCeRxYyC5CV0tP0CCqVlw1bSHkvy9bxluygQ== X-Received: by 2002:ac2:43bc:0:b0:4ea:f526:5bea with SMTP id t28-20020ac243bc000000b004eaf5265beamr386992lfl.27.1681370145684; Thu, 13 Apr 2023 00:15:45 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Wei Liu , Anthony PERARD , Juergen Gross , Bertrand Marquis Subject: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator Date: Thu, 13 Apr 2023 09:14:05 +0200 Message-Id: <20230413071424.3273490-4-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a guest is trusted to use FF-A. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- tools/include/libxl.h | 5 +++++ tools/libs/light/libxl_arm.c | 3 +++ tools/libs/light/libxl_types.idl | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index cfa1a191318c..7c48e8d8472e 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -283,6 +283,11 @@ */ #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 +/* + * arch_arm.tee field in libxl_domain_build_info has ffa value. + */ +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE_FFA 1 + /* * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing * 'soft reset' for domains and there is 'soft_reset' shutdown reason diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..601890dda1ce 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -205,6 +205,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, case LIBXL_TEE_TYPE_OPTEE: config->arch.tee_type = XEN_DOMCTL_CONFIG_TEE_OPTEE; break; + case LIBXL_TEE_TYPE_FFA: + config->arch.tee_type = XEN_DOMCTL_CONFIG_TEE_FFA; + break; default: LOG(ERROR, "Unknown TEE type %d", d_config->b_info.tee); diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index c10292e0d7e3..1a680d0f8839 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -520,7 +520,8 @@ libxl_gic_version = Enumeration("gic_version", [ libxl_tee_type = Enumeration("tee_type", [ (0, "none"), - (1, "optee") + (1, "optee"), + (2, "ffa"), ], init_val = "LIBXL_TEE_TYPE_NONE") libxl_rdm_reserve = Struct("rdm_reserve", [ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520469.808127 (Exim 4.92) (envelope-from ) id 1pmrBT-0003kh-7c; Thu, 13 Apr 2023 07:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520469.808127; Thu, 13 Apr 2023 07:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBS-0003in-Cd; Thu, 13 Apr 2023 07:15:54 +0000 Received: by outflank-mailman (input) for mailman id 520469; Thu, 13 Apr 2023 07:15:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBP-0001gr-PC for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:51 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04d9ebc3-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:15:50 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id i6so6145839lfp.1 for ; Thu, 13 Apr 2023 00:15:50 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04d9ebc3-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370149; x=1683962149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xdtgtks0Z+0OQgcElk/gBwu5R5RBnZenMx5onSQ1voY=; b=pCCHs+6Bq8GYnAbcHC07R7jVm1hYJMLtVTHERhDWKLdVIDcQUDt8p+ovEdZg90KOMF U7ikJbSTPvG8WwfYE2yJzKe6Sn8HTuV9XZw5KJShNA3lrW4KF58SZu+KBwrFaa5H38Ow aupikAeEB3nBQMonVVpV0oQrYW3HZDD3X/dKWCquf27RNt39OVWuphK4LUyAG85qNDq4 zvo6ydDk0GF+rYM0anyskX5B8LIV/JpxfB2oQ5Xm9iOYkr2e0wWUR2rjG81K7TOJoz6I Sh8FSpb9+k4Cnln8+AM3a2BocKbGq606CPIrx71oRf0ufxgE//vnlkvrqGzyFu9upJb6 IcdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370149; x=1683962149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xdtgtks0Z+0OQgcElk/gBwu5R5RBnZenMx5onSQ1voY=; b=Sl0VyrA2jr7H0GXtE8vcOJt3ySJvHqREiFE74GBXX225YYe2aBu1+WK2hbLYPMlwVN iW1oTTCno4w/aJ8PPUMYjnYNhYWfkwNKaF0gJWPiHEMCk33GYabMDvsGVuroaNl5pxPs d+jnl4AzsaXaNwHAeIqyEQIpu5wFWYQ603LXz/aURFrespoARyqH+oFIr9o3XdUEQAMd Z8dsr4CDRDHRoVkRmkSs8oFlylIzELeZqpkndH+74adgof38RPSiSXir6wOp4cs4gQ4S u6JpbpykUTO01VHf4hyPP3GFmnwXnFXT0XlzNJOyWvfVst2yHJSQ1ur83sL01HM/5lir /qMg== X-Gm-Message-State: AAQBX9ei0QsGl2SBuCcR4TW182GBuMV3sUxeR8Xh7WIxuI/g7sDL32Y/ /ADk/tMSGvOMkYz1d3idnBEJlEeiLPG96qesMis= X-Google-Smtp-Source: AKy350YzDtXtY7GPdfoFCSuzwqUBv5NtAssSt/D/m1g+loRAlXuUWXfnFaxlPX9CUMS+xBFkbVlYWg== X-Received: by 2002:ac2:50cd:0:b0:4ec:8615:303e with SMTP id h13-20020ac250cd000000b004ec8615303emr495805lfm.33.1681370149673; Thu, 13 Apr 2023 00:15:49 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET Date: Thu, 13 Apr 2023 09:14:10 +0200 Message-Id: <20230413071424.3273490-9-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for the FF-A function FFA_ID_GET to return the ID of the calling client. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 90ed71cbfda3..f129879c5b81 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -181,6 +181,12 @@ static bool ffa_get_version(uint32_t *vers) return true; } +static uint16_t get_vm_id(const struct domain *d) +{ + /* +1 since 0 is reserved for the hypervisor in FF-A */ + return d->domain_id + 1; +} + static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, register_t v2, register_t v3, register_t v4, register_t v5, register_t v6, register_t v7) @@ -195,6 +201,12 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, set_user_reg(regs, 7, v7); } +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, + uint32_t w3) +{ + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); +} + static void handle_version(struct cpu_user_regs *regs) { struct domain *d = current->domain; @@ -224,6 +236,9 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_VERSION: handle_version(regs); return true; + case FFA_ID_GET: + set_regs_success(regs, get_vm_id(d), 0); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -237,6 +252,12 @@ static int ffa_domain_init(struct domain *d) if ( !ffa_version ) return -ENODEV; + /* + * We can't use that last possible domain ID or get_vm_id() would cause + * an overflow. + */ + if ( d->domain_id >= UINT16_MAX) + return -ERANGE; ctx = xzalloc(struct ffa_ctx); if ( !ctx ) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520464.808076 (Exim 4.92) (envelope-from ) id 1pmrBO-0002Tm-08; Thu, 13 Apr 2023 07:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520464.808076; Thu, 13 Apr 2023 07:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBN-0002T7-Q9; Thu, 13 Apr 2023 07:15:49 +0000 Received: by outflank-mailman (input) for mailman id 520464; Thu, 13 Apr 2023 07:15:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBL-0001gq-Oz for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:47 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02f5e23d-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:47 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id z8so19679192lfb.12 for ; Thu, 13 Apr 2023 00:15:47 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02f5e23d-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370146; x=1683962146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kGRv/GDtKkNvjjvcwSxhfbYecPI7h/XXuKkIl9vhng4=; b=X7rve2g9D2aLGlQZAHVPmtlYVObpWW8EnmykiL2WKGnNOywY4Q7OFH9UXDFlEwRMMT NH7Qec7/QDvnggmptfJs7QyBetrWYrnNxAu32nF1Xxppf9sS/j2aCNReb3+aXew09pdi M8VBf3qKLuG9tVNafbEZmokeH28cZXT/d3H0h1Wk8lL91cL3Ajddyi4bSE7nbNk7ytOn dNol1rAilxv2tWFhxOZaH7pzeUxb9/BPN8zRTC+iSsBUFKOl3p0le9TNfNLFr5JIm2Jq b+CTrYLAl9OSg5jvg5C01cTx1i9PnvXt/xUA7xR7P99ElC2cPiTLm1KLUQXaBm5eir0Y tTxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370146; x=1683962146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kGRv/GDtKkNvjjvcwSxhfbYecPI7h/XXuKkIl9vhng4=; b=M9WlmdJkLX9R+ua6U0WrUWwJjeRlMkkr4qMJalUsEvkvIeex74lgDxUT9U2Xm7dTO+ svm+TIzDbkHCsuEahQ0KWUn8pXOGgW9x6VnomM2FtooD8V8H19kn2CrXKJfi5nIuNLeZ Cwkp39wGp3XfG+q4zNgtyqcGkCMtNHvH3J0GLrPLlrzrDl/uLEYtxjFzsvDdiqY13zjR WdPZyMtq2+wQutIcpAgam6iIXTqMD9y8PEKVkt8InMSFVE/7nkawL5S2dEyWpWHmBWif ldlNv3miMTjQy8q6H7bY21hlUDzFllG8ntVSCjNRrSq5K7vxETddfLIu8YxBhkQ4DzBC 1FQQ== X-Gm-Message-State: AAQBX9dRRP6JkPOorjS/2b6hzMb6ZWUMvKPFTOGKmVo38QakBD9TYgTo c+Rnm7aon2IijxbWXBpqZcuTM4yeubij2OXoWgg= X-Google-Smtp-Source: AKy350Y8rJotM9HbgaonmZirdkGyCcpi9jzouFQD7iz2ghgpp2OU5rPRMQUwThOKh97sZcboONDI2w== X-Received: by 2002:a05:6512:11c6:b0:4ea:f526:5bee with SMTP id h6-20020a05651211c600b004eaf5265beemr456649lfr.11.1681370146419; Thu, 13 Apr 2023 00:15:46 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function IDs Date: Thu, 13 Apr 2023 09:14:06 +0200 Message-Id: <20230413071424.3273490-5-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds the remaining SMC function IDs from FF-A 1.1 specification. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index aaf74c287aef..ba0942e76993 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -60,7 +60,41 @@ /* Function IDs */ #define FFA_ERROR 0x84000060U #define FFA_SUCCESS_32 0x84000061U +#define FFA_SUCCESS_64 0xC4000061U +#define FFA_INTERRUPT 0x84000062U #define FFA_VERSION 0x84000063U +#define FFA_FEATURES 0x84000064U +#define FFA_RX_ACQUIRE 0x84000084U +#define FFA_RX_RELEASE 0x84000065U +#define FFA_RXTX_MAP_32 0x84000066U +#define FFA_RXTX_MAP_64 0xC4000066U +#define FFA_RXTX_UNMAP 0x84000067U +#define FFA_PARTITION_INFO_GET 0x84000068U +#define FFA_ID_GET 0x84000069U +#define FFA_SPM_ID_GET 0x84000085U +#define FFA_MSG_WAIT 0x8400006BU +#define FFA_MSG_YIELD 0x8400006CU +#define FFA_RUN 0x8400006DU +#define FFA_MSG_SEND2 0x84000086U +#define FFA_MSG_SEND_DIRECT_REQ_32 0x8400006FU +#define FFA_MSG_SEND_DIRECT_REQ_64 0xC400006FU +#define FFA_MSG_SEND_DIRECT_RESP_32 0x84000070U +#define FFA_MSG_SEND_DIRECT_RESP_64 0xC4000070U +#define FFA_MEM_DONATE_32 0x84000071U +#define FFA_MEM_DONATE_64 0xC4000071U +#define FFA_MEM_LEND_32 0x84000072U +#define FFA_MEM_LEND_64 0xC4000072U +#define FFA_MEM_SHARE_32 0x84000073U +#define FFA_MEM_SHARE_64 0xC4000073U +#define FFA_MEM_RETRIEVE_REQ_32 0x84000074U +#define FFA_MEM_RETRIEVE_REQ_64 0xC4000074U +#define FFA_MEM_RETRIEVE_RESP 0x84000075U +#define FFA_MEM_RELINQUISH 0x84000076U +#define FFA_MEM_RECLAIM 0x84000077U +#define FFA_MEM_FRAG_RX 0x8400007AU +#define FFA_MEM_FRAG_TX 0x8400007BU +#define FFA_MSG_SEND 0x8400006EU +#define FFA_MSG_POLL 0x8400006AU struct ffa_ctx { /* FF-A version used by the guest */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520461.808046 (Exim 4.92) (envelope-from ) id 1pmrBM-0001ko-0A; Thu, 13 Apr 2023 07:15:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520461.808046; Thu, 13 Apr 2023 07:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBL-0001jz-Pm; Thu, 13 Apr 2023 07:15:47 +0000 Received: by outflank-mailman (input) for mailman id 520461; Thu, 13 Apr 2023 07:15:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBL-0001gq-0O for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:47 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0182c663-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:44 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id d7so28946280lfj.3 for ; Thu, 13 Apr 2023 00:15:44 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0182c663-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370144; x=1683962144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sPB2Dc6t3Zgd1EEjPsex1QWFM8C9VFNKedpjWqBxO5k=; b=EvXtGtaw0BIV2NMQMuY4QKgGrDz+ryd3caJ2Qw+PTBLFkehwADpIx1R7gReCRzoJSa b9GnenXOP5EM0wQM9GtwCIVbCQVRv5eFGLfAAzn6BCYX3JXdJd3ToNbJvllEJix8BfkT 78PwvoaHZJ9jgydmRYGzedCTgOy0WXpUtRL3IpOTCFIn/muvvbfEaLdaUZh0qkhTt85R 4Zb3B15KDi7OexYQdYu9LpG7IOcibytoXe5KyvfN0ImMCWmMAN4aTGiKD25jO2GzYanX tNdGds9mCtnYQpPXmGHJkPYZONy6ckogZ0sGx6ZJ7G5meQb/vvFNiKZ9ySAUmfF3b/G7 M2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370144; x=1683962144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sPB2Dc6t3Zgd1EEjPsex1QWFM8C9VFNKedpjWqBxO5k=; b=WMNZCr1AwrZdzSJwgGucafP4Ziy35GmvplfFfPKHP+fDJKpMBodMa763rCm/AWsp6y 0LL+0iCGO7v15bYVRrqgtdtcw+fEPup70xryzuwz5u+D9F0K5E1/Gar5nkc5h7U+vj/o PgwrDPcISgzLlzkmbqI5iZtOpE9HzVJX/T+XMYXW5TPy/KH7KYI/7UpGmVBW47X39dpW vrbgM+E/UKdlnEZoYiYdu2otchQ2BUUVBu6PSxwvbIbXKgIG3l7dAPq4FexTc3qC2Gjm CFvMunxmiebkdBUU8CQWZBnaxE2ikW/LzfGm9Zypwc80n9K3iVQJE7QwmOhVFOWFOZaY eI9g== X-Gm-Message-State: AAQBX9fbolx1CHYv6xOX9aQ/sqm9DIDSVRurBE8FprGSQchSKKtkWduX NJPZKlPA3TQQGAcAhqC1Lpe2O8qy+nMnIjHOXCk= X-Google-Smtp-Source: AKy350ahhVJexmXN4HqaSvh9J9OfzgvqpB3LvRahdZVySM2Hj7+tIQKdZi3psAdn0wNK35trjyeemQ== X-Received: by 2002:ac2:4946:0:b0:4c0:2ddc:4559 with SMTP id o6-20020ac24946000000b004c02ddc4559mr489919lfi.69.1681370143951; Thu, 13 Apr 2023 00:15:43 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Luca Fancellu , Julien Grall Subject: [XEN PATCH v8 01/22] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers Date: Thu, 13 Apr 2023 09:14:03 +0200 Message-Id: <20230413071424.3273490-2-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SMCCC v1.2 [1] AArch64 allows x0-x17 to be used as both parameter registers and result registers for the SMC and HVC instructions. Arm Firmware Framework for Armv8-A specification makes use of x0-x7 as parameter and result registers. Let us add new interface to support this extended set of input/output registers. This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 extended input/output registers") by Sudeep Holla from the Linux kernel The SMCCC version reported to the VM is bumped to 1.2 in order to support handling FF-A messages. [1] https://developer.arm.com/documentation/den0028/c/?lang=en Signed-off-by: Jens Wiklander Reviewed-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Julien Grall --- xen/arch/arm/arm64/asm-offsets.c | 9 +++++++ xen/arch/arm/arm64/smc.S | 42 ++++++++++++++++++++++++++++++++ xen/arch/arm/include/asm/smccc.h | 40 ++++++++++++++++++++++++++++++ xen/arch/arm/vsmc.c | 2 +- 4 files changed, 92 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/asm-offsets.c b/xen/arch/arm/arm64/asm-offsets.c index 7226cd9b2eb0..7adb67a1b81a 100644 --- a/xen/arch/arm/arm64/asm-offsets.c +++ b/xen/arch/arm/arm64/asm-offsets.c @@ -57,6 +57,15 @@ void __dummy__(void) BLANK(); OFFSET(SMCCC_RES_a0, struct arm_smccc_res, a0); OFFSET(SMCCC_RES_a2, struct arm_smccc_res, a2); + OFFSET(ARM_SMCCC_1_2_REGS_X0_OFFS, struct arm_smccc_1_2_regs, a0); + OFFSET(ARM_SMCCC_1_2_REGS_X2_OFFS, struct arm_smccc_1_2_regs, a2); + OFFSET(ARM_SMCCC_1_2_REGS_X4_OFFS, struct arm_smccc_1_2_regs, a4); + OFFSET(ARM_SMCCC_1_2_REGS_X6_OFFS, struct arm_smccc_1_2_regs, a6); + OFFSET(ARM_SMCCC_1_2_REGS_X8_OFFS, struct arm_smccc_1_2_regs, a8); + OFFSET(ARM_SMCCC_1_2_REGS_X10_OFFS, struct arm_smccc_1_2_regs, a10); + OFFSET(ARM_SMCCC_1_2_REGS_X12_OFFS, struct arm_smccc_1_2_regs, a12); + OFFSET(ARM_SMCCC_1_2_REGS_X14_OFFS, struct arm_smccc_1_2_regs, a14); + OFFSET(ARM_SMCCC_1_2_REGS_X16_OFFS, struct arm_smccc_1_2_regs, a16); } /* diff --git a/xen/arch/arm/arm64/smc.S b/xen/arch/arm/arm64/smc.S index 91bae62dd4d2..fc6b676e2ee3 100644 --- a/xen/arch/arm/arm64/smc.S +++ b/xen/arch/arm/arm64/smc.S @@ -27,3 +27,45 @@ ENTRY(__arm_smccc_1_0_smc) stp x2, x3, [x4, #SMCCC_RES_a2] 1: ret + +/* + * void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, + * struct arm_smccc_1_2_regs *res) + */ +ENTRY(arm_smccc_1_2_smc) + /* Save `res` and free a GPR that won't be clobbered by SMC call */ + stp x1, x19, [sp, #-16]! + + /* Ensure `args` won't be clobbered while loading regs in next step */ + mov x19, x0 + + /* Load the registers x0 - x17 from the struct arm_smccc_1_2_regs */ + ldp x0, x1, [x19, #ARM_SMCCC_1_2_REGS_X0_OFFS] + ldp x2, x3, [x19, #ARM_SMCCC_1_2_REGS_X2_OFFS] + ldp x4, x5, [x19, #ARM_SMCCC_1_2_REGS_X4_OFFS] + ldp x6, x7, [x19, #ARM_SMCCC_1_2_REGS_X6_OFFS] + ldp x8, x9, [x19, #ARM_SMCCC_1_2_REGS_X8_OFFS] + ldp x10, x11, [x19, #ARM_SMCCC_1_2_REGS_X10_OFFS] + ldp x12, x13, [x19, #ARM_SMCCC_1_2_REGS_X12_OFFS] + ldp x14, x15, [x19, #ARM_SMCCC_1_2_REGS_X14_OFFS] + ldp x16, x17, [x19, #ARM_SMCCC_1_2_REGS_X16_OFFS] + + smc #0 + + /* Load the `res` from the stack */ + ldr x19, [sp] + + /* Store the registers x0 - x17 into the result structure */ + stp x0, x1, [x19, #ARM_SMCCC_1_2_REGS_X0_OFFS] + stp x2, x3, [x19, #ARM_SMCCC_1_2_REGS_X2_OFFS] + stp x4, x5, [x19, #ARM_SMCCC_1_2_REGS_X4_OFFS] + stp x6, x7, [x19, #ARM_SMCCC_1_2_REGS_X6_OFFS] + stp x8, x9, [x19, #ARM_SMCCC_1_2_REGS_X8_OFFS] + stp x10, x11, [x19, #ARM_SMCCC_1_2_REGS_X10_OFFS] + stp x12, x13, [x19, #ARM_SMCCC_1_2_REGS_X12_OFFS] + stp x14, x15, [x19, #ARM_SMCCC_1_2_REGS_X14_OFFS] + stp x16, x17, [x19, #ARM_SMCCC_1_2_REGS_X16_OFFS] + + /* Restore original x19 */ + ldp xzr, x19, [sp], #16 + ret diff --git a/xen/arch/arm/include/asm/smccc.h b/xen/arch/arm/include/asm/smccc.h index b3dbeecc90ad..1adcd37443c7 100644 --- a/xen/arch/arm/include/asm/smccc.h +++ b/xen/arch/arm/include/asm/smccc.h @@ -33,6 +33,7 @@ #define ARM_SMCCC_VERSION_1_0 SMCCC_VERSION(1, 0) #define ARM_SMCCC_VERSION_1_1 SMCCC_VERSION(1, 1) +#define ARM_SMCCC_VERSION_1_2 SMCCC_VERSION(1, 2) /* * This file provides common defines for ARM SMC Calling Convention as @@ -265,6 +266,45 @@ void __arm_smccc_1_0_smc(register_t a0, register_t a1, register_t a2, else \ arm_smccc_1_0_smc(__VA_ARGS__); \ } while ( 0 ) + +/* + * struct arm_smccc_1_2_regs - Arguments for or Results from SMC call + * @a0-a17 argument values from registers 0 to 17 + */ +struct arm_smccc_1_2_regs { + unsigned long a0; + unsigned long a1; + unsigned long a2; + unsigned long a3; + unsigned long a4; + unsigned long a5; + unsigned long a6; + unsigned long a7; + unsigned long a8; + unsigned long a9; + unsigned long a10; + unsigned long a11; + unsigned long a12; + unsigned long a13; + unsigned long a14; + unsigned long a15; + unsigned long a16; + unsigned long a17; +}; + +/* + * arm_smccc_1_2_smc() - make SMC calls + * @args: arguments passed via struct arm_smccc_1_2_regs + * @res: result values via struct arm_smccc_1_2_regs + * + * This function is used to make SMC calls following SMC Calling Convention + * v1.2 or above. The content of the supplied param are copied from the + * structure to registers prior to the SMC instruction. The return values + * are updated with the content from registers on return from the SMC + * instruction. + */ +void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, + struct arm_smccc_1_2_regs *res); #endif /* CONFIG_ARM_64 */ #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index 7335276f3fa1..cd68fa80e98a 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -85,7 +85,7 @@ static bool handle_arch(struct cpu_user_regs *regs) switch ( fid ) { case ARM_SMCCC_VERSION_FID: - set_user_reg(regs, 0, ARM_SMCCC_VERSION_1_1); + set_user_reg(regs, 0, ARM_SMCCC_VERSION_1_2); return true; case ARM_SMCCC_ARCH_FEATURES_FID: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520467.808104 (Exim 4.92) (envelope-from ) id 1pmrBQ-0003D2-FL; Thu, 13 Apr 2023 07:15:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520467.808104; Thu, 13 Apr 2023 07:15:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBQ-0003A1-4Y; Thu, 13 Apr 2023 07:15:52 +0000 Received: by outflank-mailman (input) for mailman id 520467; Thu, 13 Apr 2023 07:15:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBO-0001gr-LB for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:50 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 043dabf0-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:15:49 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id u12so154018lfu.5 for ; Thu, 13 Apr 2023 00:15:49 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 043dabf0-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370148; x=1683962148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s7kR9rwQGILBw8tLRM1a/b6iPghICXgNju4KgQlDbBQ=; b=XkCTd+94xqCLh7P6D6XNMY/dneEGpJmdtidCJu6cK4qLOm4YDvaAwSa7WVeCDWKGPu +MTs6jMcap41uebOt1s38dHYurwDB3UZXB8eF6gKf/e2siAfgT4ZDWn/UtGMC0xe5PJQ xuMUF4UN9RMqnVfKg6aDM+G6bApMh3recCTS4qdHgkZHTIxfXrqP+NKFtksT31Nf5VNE GrwYr+1O+5mOSGReSqtMtlVDvBWBaR1XSgnll0v57TBFrf8/dOswCmSBg2xPz7ve6qGh VPlfcx7d35srxBkV8RxFmjn2cNCxW5OxnI+jLGQnjJ3PHyxIfJSX7Wt06JWr1V5PKK6S DSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370148; x=1683962148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s7kR9rwQGILBw8tLRM1a/b6iPghICXgNju4KgQlDbBQ=; b=Tzv7InO/UqQw2Ra0ERmLzhf37TmEEN+etsiUJ7Vw1fejOTGMlfXsjOJz6uo1JTEpdV ED6d5R+tPMC5qWd/bCCSCWBC416NXaRYr66ndazMrfcwh6sQtsnF4W+Mp6PCE1860KdY CVKDYRn14us36YIsFuVXjU+YNGUfp5AkpqZR1fUZkmctXFRoEhKs6Mh0qW5P2YyJEtwJ 50itJ8odkS+z4iuOmRPl72VptJcK0QgO2gKkg9H+hQgFHL7yAdDzuSRv5JCljz3sfop/ Y92IYX9Q5kflUDHRg+rBgYTD2swAUFU0dlqRZcg5zW5Ux8Q8516rQsumgN+jJfoYSI5R CR8w== X-Gm-Message-State: AAQBX9dcH2MEuyCvr2TFtOp97fE1sHO4ZltHIDK3huyKv4lpdtfkPuBo e85axPV2mrEvY8hdU91OvQShAfrqoAx9/g+XvEs= X-Google-Smtp-Source: AKy350Z7CY4MuGRuwwnHSScNY/LH434Frkw+9N7zWTQ1lAI4TZU2KZM8qPHQmQHr3wLFJgimUoc4bQ== X-Received: by 2002:ac2:5dcd:0:b0:4ec:9df9:f11a with SMTP id x13-20020ac25dcd000000b004ec9df9f11amr690577lfq.9.1681370148638; Thu, 13 Apr 2023 00:15:48 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 07/22] xen/arm: ffa: enforce dependency on 4k pages Date: Thu, 13 Apr 2023 09:14:09 +0200 Message-Id: <20230413071424.3273490-8-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A mediator since the current implementation only works if Xen page size is the same as the FFA page size. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index cf7b7545aa03..90ed71cbfda3 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -57,6 +57,16 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* + * The FF-A specification explicitly works with 4K pages as a measure of + * memory size, for example, FFA_RXTX_MAP takes one parameter "RX/TX page + * count" which is the number of contiguous 4K pages allocated. Xen may use + * a different page size depending on the configuration to avoid confusion + * with PAGE_SIZE use a special define when it's a page size as in the FF-A + * specification. + */ +#define FFA_PAGE_SIZE SZ_4K + /* * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: * BIT(31): Framework or partition message @@ -256,6 +266,17 @@ static bool ffa_probe(void) unsigned int major_vers; unsigned int minor_vers; + /* + * FF-A often works in units of 4K pages and currently it's assumed + * that we can map memory using that granularity. See also the comment + * above the FFA_PAGE_SIZE define. + * + * It is possible to support a PAGE_SIZE larger than 4K in Xen, but + * until that is fully handled in this code make sure that we only use + * 4K page sizes. + */ + BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE); + /* * psci_init_smccc() updates this value with what's reported by EL-3 * or secure world. -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520466.808099 (Exim 4.92) (envelope-from ) id 1pmrBP-00035F-S2; Thu, 13 Apr 2023 07:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520466.808099; Thu, 13 Apr 2023 07:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBP-000347-Kb; Thu, 13 Apr 2023 07:15:51 +0000 Received: by outflank-mailman (input) for mailman id 520466; Thu, 13 Apr 2023 07:15:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBN-0001gq-PK for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:49 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03ce63d4-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:48 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id a23so18385405lfk.4 for ; Thu, 13 Apr 2023 00:15:48 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03ce63d4-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370148; x=1683962148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4h8RYyh5bzZRCknS4UVtSZ4pAXzS4T4Tgcv5Vo44wYc=; b=A82X0qygBUotlb7DfIfBGFrNRMxjB6Hi05AXYcE8ng1UX27OkAmm6Q/PFJxKqveD7i EB7UqFSYK0P5TZDMiPSPv/ixIlCi6gshIcsvr7Dutopp5imfc1DZBqnTQNSSjN/WYMTp BIUVVW8yS8fksYfPJ78t6mQ2SCX1iQYa+vYfY6LH/TKAVAuWC4wzBbR+2A+OmxLuRZz6 mxdz/AmtFt+RH4qdWt053i/mFucNmnjypNZTxu8RScA4pLwdig6WHhpbJGhtv5phInhY tiIlH6/Y1/KbHDIyudkgxuxvjt01vEIN8BXPdWTWTInkwAJQ+KiirwVJC39pozeRQLbi S94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370148; x=1683962148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4h8RYyh5bzZRCknS4UVtSZ4pAXzS4T4Tgcv5Vo44wYc=; b=df8AFcW20vdiZnBhTQqquMjtlsaonyiNq1TYPBe6ua/B+JiNx5EP51xcBPj0YqL7ZX DkNT8s8taohm1rIaxRwGWohLS2El/Z/1RHLYd6rX5+f7WjfD83ZNeOaxDkJ8SRB7Ufib HbPZf9tb0LCqzQ0ixU1mVKIsIWXdQ/pjNIQN9ssdL3kjU5seflZFV0rcwoB/i4xNYz5X XHiWNwrDKKm26bZMwlbQYvTL2fbpJD6KdGoQnkWiKK8lE18PJk+oo6xto0G5qE/jlMVN Azw5MdoOyzk4DsFxvP7CBLAk/fnVfhGnwlgpinPGdbzHCPb/YZN2JUNEfAIurTxLJ9dz Bydg== X-Gm-Message-State: AAQBX9e30JWBemLWUZBobmldPHaJmWeZDED+Tan5ma3DoIxHYHwpXtyK W2YAyIZvKl/tn4DnAdyjeg+0XMt3vHcPED1BOyE= X-Google-Smtp-Source: AKy350beH+O+9f6FocX15Q6eI3oQwCr9xsNRMnzQDFyL45vH8snBqVe9+m1d9CZ9/Az5vOcXP12/uA== X-Received: by 2002:a05:6512:3902:b0:4e8:45d5:53bf with SMTP id a2-20020a056512390200b004e845d553bfmr548369lfu.40.1681370147940; Thu, 13 Apr 2023 00:15:47 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct request/response messages Date: Thu, 13 Apr 2023 09:14:08 +0200 Message-Id: <20230413071424.3273490-7-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds defines for framework direct request/response messages. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 72e7d0575de5..cf7b7545aa03 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -57,6 +57,19 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* + * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: + * BIT(31): Framework or partition message + * BIT(7-0): Message type for frameworks messages + */ +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) +#define FFA_MSG_TYPE_MASK 0xFFU; +#define FFA_MSG_PSCI 0x0U +#define FFA_MSG_SEND_VM_CREATED 0x4U +#define FFA_MSG_RESP_VM_CREATED 0x5U +#define FFA_MSG_SEND_VM_DESTROYED 0x6U +#define FFA_MSG_RESP_VM_DESTROYED 0x7U + /* * Flags to determine partition properties in FFA_PARTITION_INFO_GET return * message: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520470.808131 (Exim 4.92) (envelope-from ) id 1pmrBT-0003qr-JK; Thu, 13 Apr 2023 07:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520470.808131; Thu, 13 Apr 2023 07:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBS-0003op-VB; Thu, 13 Apr 2023 07:15:54 +0000 Received: by outflank-mailman (input) for mailman id 520470; Thu, 13 Apr 2023 07:15:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBQ-0001gq-6z for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:52 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05beb46c-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:51 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id t14so17730665lft.7 for ; Thu, 13 Apr 2023 00:15:51 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05beb46c-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370151; x=1683962151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pRYh9rViyFOvZCJSQQWOLQPi8YGZ6hqxd9UhBA1/mVQ=; b=bGID0BM3IKCyBs9Fb+1qCm7grvNZP5aDga9QzxfN/qFX7WEy7SRlMd81xJeklLXa7J 98uZFaWKBlZ3aFWumgJ/uZm5Fmhaip+2yGt/pdwc8BmshtqAsIBEiwkiBfwCLodxC5Oo X6VUUVdaDUNnLCB+ftfVskw2RB71YMwmk3xdtG+aU+C/2rZ3VRdEPfhxQzCRvT2nq885 W4keD+/B6xfHT1Ttr9il2iuJThDE+wLRp29p9vmrnSem6prPLe9+ZZmFzi4zJhXyPuSa tFRVihRNqdtIPPcJBrgZYbvZmCvqC2AQ4P95iHs0304lx5mSn/eFR8VCw6FYjbFopYR7 Z51A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370151; x=1683962151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pRYh9rViyFOvZCJSQQWOLQPi8YGZ6hqxd9UhBA1/mVQ=; b=KjyzWcSz12Sy8vDlUv5EmF55NXWUgaIGD1EPXix8u68GoNRnFW+uVxDGN8YV9Z87EQ Hb0PBURkTn6cGt+aZjNDGDm4VQLqxeDvHyv9T80Z675e24jg8gxVFiE0matYkj7kIkZz yaUAiURiMCLR4navEegL1JxAUoi0APf2/s5IoXtVVLOoWKhOOTxJHTPZ0veaNce7YWOV XPQiQwN6eTHGjQLiapTPxv43mHUb8liIwiSzkUCglxdTE4ohNf8MTAOhGx6c9qI8sX37 gpWL8NwMxCYKJJs5uFmKG/ed9pelV36K9eM9r9LGrmnWpOsIZhGRqNCfG8PIYeA3u3FS c8xQ== X-Gm-Message-State: AAQBX9eHO6RoM7zVIUtzpN4JlwRBa2nL0rQ2MurYajoGcywaCV6JgxPF 5ZThvJwYXlNr2Vd7qYHYbsQkzntXGloDs+yTcow= X-Google-Smtp-Source: AKy350Zl091Qic1jeEJAh4/nzkT6NnQXBmuUhjxdulYlyB0Q3Uok5N2ISXaclmkeNym5ht4Hh/RUpQ== X-Received: by 2002:a19:f602:0:b0:4eb:3f80:3ca3 with SMTP id x2-20020a19f602000000b004eb3f803ca3mr471078lfe.48.1681370151154; Thu, 13 Apr 2023 00:15:51 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 10/22] xen/arm: ffa: map SPMC rx/tx buffers Date: Thu, 13 Apr 2023 09:14:12 +0200 Message-Id: <20230413071424.3273490-11-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When initializing the FF-A mediator map the RX and TX buffers shared with the SPMC. These buffer are later used to to transmit data that cannot be passed in registers only. Adds a check that the SP supports the needed FF-A features FFA_RXTX_MAP_64 and FFA_RXTX_UNMAP. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 50 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index f2cce955d981..054121fe4321 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -67,6 +68,12 @@ */ #define FFA_PAGE_SIZE SZ_4K +/* + * The number of pages used for each of the RX and TX buffers shared with + * the SPMC. + */ +#define FFA_RXTX_PAGE_COUNT 1 + /* * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: * BIT(31): Framework or partition message @@ -161,6 +168,13 @@ struct ffa_ctx { /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; +/* + * Our rx/tx buffers shared with the SPMC. FFA_RXTX_PAGE_COUNT is the + * number of pages used in each of these buffers. + */ +static void *ffa_rx __read_mostly; +static void *ffa_tx __read_mostly; + static bool ffa_get_version(uint32_t *vers) { const struct arm_smccc_1_2_regs arg = { @@ -231,6 +245,12 @@ static bool check_mandatory_feature(uint32_t id) return !ret; } +static int32_t ffa_rxtx_map(paddr_t tx_addr, paddr_t rx_addr, + uint32_t page_count) +{ + return ffa_simple_call(FFA_RXTX_MAP_64, tx_addr, rx_addr, page_count, 0); +} + static uint16_t get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -389,6 +409,7 @@ static int ffa_relinquish_resources(struct domain *d) static bool ffa_probe(void) { uint32_t vers; + int e; unsigned int major_vers; unsigned int minor_vers; @@ -435,12 +456,39 @@ static bool ffa_probe(void) * TODO save result of checked features and use that information to * accept or reject requests from guests. */ - if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + if ( + !check_mandatory_feature(FFA_RXTX_MAP_64) || + !check_mandatory_feature(FFA_RXTX_UNMAP) || + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + return false; + + ffa_rx = alloc_xenheap_pages(get_order_from_pages(FFA_RXTX_PAGE_COUNT), 0); + if ( !ffa_rx ) return false; + ffa_tx = alloc_xenheap_pages(get_order_from_pages(FFA_RXTX_PAGE_COUNT), 0); + if ( !ffa_tx ) + goto err_free_ffa_rx; + + e = ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), FFA_RXTX_PAGE_COUNT); + if ( e ) + { + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", e); + goto err_free_ffa_tx; + } ffa_version = vers; return true; + +err_free_ffa_tx: + free_xenheap_pages(ffa_tx, 0); + ffa_tx = NULL; +err_free_ffa_rx: + free_xenheap_pages(ffa_rx, 0); + ffa_rx = NULL; + ffa_version = 0; + + return false; } static const struct tee_mediator_ops ffa_ops = -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520471.808140 (Exim 4.92) (envelope-from ) id 1pmrBU-0004Gx-SM; Thu, 13 Apr 2023 07:15:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520471.808140; Thu, 13 Apr 2023 07:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBU-0004EK-Ir; Thu, 13 Apr 2023 07:15:56 +0000 Received: by outflank-mailman (input) for mailman id 520471; Thu, 13 Apr 2023 07:15:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBR-0001gq-5d for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:53 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 063a7a26-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:52 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id t14so17730699lft.7 for ; Thu, 13 Apr 2023 00:15:52 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 063a7a26-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370152; x=1683962152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LUHuc1SEEBwu3k5oaDgiHqlkqyD0euvjsOMhi6KaWmA=; b=rHpQDktneg32sQ9YVbFF0X51AsyYDiifK58Xl6+ydvoAcCLhMgdnDWl5hEGDcekivh zeU7sI6uJZ0O1dO9+Udg6oabVH15iMsF5vRxpKMc75/sBa9WFlfpQ1bCPxEa7xSkIM41 qWEfgPaFjFmsHbHNbx/ePFpnjGMSfJQeae9lCw8W5ZBfN/Vv+CjzSngNOnlG0dM6D8rP N+02TE1AhUSXP4+QOnzMk0Y77sKVXrZPluGGccgF1z6hqOk42O8xPvqZUR0Z9zCXxaI3 QWuNqNQsFMJPmayiVuuNOOBtt6U9NrzW1Thb4ojCGX5+VdIJnvPNfoWfATq+8NaW4//s 8CBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370152; x=1683962152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LUHuc1SEEBwu3k5oaDgiHqlkqyD0euvjsOMhi6KaWmA=; b=KvtpL24WaElCQw44odIJDkUwgbqnUSiRBMCBRvRYrCu755pRD8MU+jyuGO1fVMat8y FpAA+M6aFgLWGWikALCUDSnE5KKwPX5m0ijPhHQDEXFkW1zvs35B0N8AjTu+tdLgDPem ukjFKyTrZDOKrhFQtysDDp02ZGCcLAEknDCmBCaU0MqOd1wSYkhRSe1Qm4ICYTwfRQq7 2KJ9eH5sSS5h0bWikZVJ8n/rPFK5nbsT4oRjD5pBX9ap+Y4hSS2UILbSFW7JQsRkf3Xt pAkN8dMu6ka1WhFrRERt2fA5kYkb2D5jSTLkWMXj4xJ7nQpxNZjMctLbPrvXYaVz5Bd0 mlwA== X-Gm-Message-State: AAQBX9d3JuggbsSJ+DXmhGXzTfEENEmUDp5/scjWmNeeyfT4HrVvm16l hsZgsrtYDX+e6AL4avVVT3bwAWMFzsKbz4Q1MqA= X-Google-Smtp-Source: AKy350Y1XOnbdxrY/+pdsHCDPtT49ARaxmuTprdYzygYwrCh8xdQWpD3Nq34I2yYJHU8uH8uB6T+CA== X-Received: by 2002:ac2:5d4e:0:b0:4eb:c18:efae with SMTP id w14-20020ac25d4e000000b004eb0c18efaemr591339lfd.17.1681370151879; Thu, 13 Apr 2023 00:15:51 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 11/22] xen/arm: ffa: send guest events to Secure Partitions Date: Thu, 13 Apr 2023 09:14:13 +0200 Message-Id: <20230413071424.3273490-12-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The FF-A specification defines framework messages sent as direct requests when certain events occurs. For instance when a VM (guest) is created or destroyed. Only SPs which have subscribed to these events will receive them. An SP can subscribe to these messages in its partition properties. Adds a check that the SP supports the needed FF-A features FFA_PARTITION_INFO_GET and FFA_RX_RELEASE. The partition properties of each SP is retrieved with FFA_PARTITION_INFO_GET which returns the information in our RX buffer. Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the caller (us), so once we're done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 200 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 199 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 054121fe4321..b4fea65ce31d 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -160,6 +160,14 @@ #define FFA_MSG_SEND 0x8400006EU #define FFA_MSG_POLL 0x8400006AU +/* Partition information descriptor */ +struct ffa_partition_info_1_1 { + uint16_t id; + uint16_t execution_context; + uint32_t partition_properties; + uint8_t uuid[16]; +}; + struct ffa_ctx { /* FF-A version used by the guest */ uint32_t guest_vers; @@ -168,6 +176,12 @@ struct ffa_ctx { /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; +/* SPs subscribing to VM_CREATE and VM_DESTROYED events */ +static uint16_t *subscr_vm_created __read_mostly; +static uint16_t subscr_vm_created_count __read_mostly; +static uint16_t *subscr_vm_destroyed __read_mostly; +static uint16_t subscr_vm_destroyed_count __read_mostly; + /* * Our rx/tx buffers shared with the SPMC. FFA_RXTX_PAGE_COUNT is the * number of pages used in each of these buffers. @@ -251,6 +265,72 @@ static int32_t ffa_rxtx_map(paddr_t tx_addr, paddr_t rx_addr, return ffa_simple_call(FFA_RXTX_MAP_64, tx_addr, rx_addr, page_count, 0); } +static int32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, + uint32_t w4, uint32_t w5, + uint32_t *count) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_PARTITION_INFO_GET, + .a1 = w1, + .a2 = w2, + .a3 = w3, + .a4 = w4, + .a5 = w5, + }; + struct arm_smccc_1_2_regs resp; + uint32_t ret; + + arm_smccc_1_2_smc(&arg, &resp); + + ret = get_ffa_ret_code(&resp); + if ( !ret ) + *count = resp.a2; + + return ret; +} + +static int32_t ffa_rx_release(void) +{ + return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); +} + +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, + uint8_t msg) +{ + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; + int32_t res; + + if ( msg == FFA_MSG_SEND_VM_CREATED ) + exp_resp |= FFA_MSG_RESP_VM_CREATED; + else if ( msg == FFA_MSG_SEND_VM_DESTROYED ) + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; + else + return FFA_RET_INVALID_PARAMETERS; + + do { + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, + .a1 = sp_id, + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, + .a5 = vm_id, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) + { + /* + * This is an invalid response, likely due to some error in the + * implementation of the ABI. + */ + return FFA_RET_INVALID_PARAMETERS; + } + res = resp.a3; + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); + + return res; +} + static uint16_t get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -374,6 +454,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) static int ffa_domain_init(struct domain *d) { struct ffa_ctx *ctx; + unsigned int n; + unsigned int m; + unsigned int c_pos; + int32_t res; if ( !ffa_version ) return -ENODEV; @@ -388,24 +472,134 @@ static int ffa_domain_init(struct domain *d) if ( !ctx ) return -ENOMEM; + for ( n = 0; n < subscr_vm_created_count; n++ ) + { + res = ffa_direct_req_send_vm(subscr_vm_created[n], get_vm_id(d), + FFA_MSG_SEND_VM_CREATED); + if ( res ) + { + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %u to %u: res %d\n", + get_vm_id(d), subscr_vm_created[n], res); + c_pos = n; + goto err; + } + } + d->arch.tee = ctx; return 0; + +err: + /* Undo any already sent vm created messaged */ + for ( n = 0; n < c_pos; n++ ) + for ( m = 0; m < subscr_vm_destroyed_count; m++ ) + if ( subscr_vm_destroyed[m] == subscr_vm_created[n] ) + ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id(d), + FFA_MSG_SEND_VM_DESTROYED); + + return -EIO; } /* This function is supposed to undo what ffa_domain_init() has done */ static int ffa_relinquish_resources(struct domain *d) { struct ffa_ctx *ctx = d->arch.tee; + unsigned int n; + int32_t res; if ( !ctx ) return 0; + for ( n = 0; n < subscr_vm_destroyed_count; n++ ) + { + res = ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id(d), + FFA_MSG_SEND_VM_DESTROYED); + + if ( res ) + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_id %u to %u: res %d\n", + get_vm_id(d), subscr_vm_destroyed[n], res); + } + XFREE(d->arch.tee); return 0; } +static void uninit_subscribers(void) +{ + subscr_vm_created_count = 0; + subscr_vm_destroyed_count = 0; + XFREE(subscr_vm_created); + XFREE(subscr_vm_destroyed); +} + +static bool init_subscribers(struct ffa_partition_info_1_1 *fpi, uint16_t count) +{ + uint16_t n; + uint16_t c_pos; + uint16_t d_pos; + + subscr_vm_created_count = 0; + subscr_vm_destroyed_count = 0; + for ( n = 0; n < count; n++ ) + { + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) + subscr_vm_created_count++; + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) + subscr_vm_destroyed_count++; + } + + if ( subscr_vm_created_count ) + subscr_vm_created = xzalloc_array(uint16_t, subscr_vm_created_count); + if ( subscr_vm_destroyed_count ) + subscr_vm_destroyed = xzalloc_array(uint16_t, + subscr_vm_destroyed_count); + if ( (subscr_vm_created_count && !subscr_vm_created) || + (subscr_vm_destroyed_count && !subscr_vm_destroyed) ) + { + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"); + uninit_subscribers(); + return false; + } + + for ( c_pos = 0, d_pos = 0, n = 0; n < count; n++ ) + { + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) + subscr_vm_created[c_pos++] = fpi[n].id; + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED ) + subscr_vm_destroyed[d_pos++] = fpi[n].id; + } + + return true; +} + +static bool init_sps(void) +{ + bool ret = false; + uint32_t count; + int e; + + e = ffa_partition_info_get(0, 0, 0, 0, 0, &count); + if ( e ) + { + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", e); + goto out; + } + + if ( count >= UINT16_MAX ) + { + printk(XENLOG_ERR "ffa: Impossible number of SPs: %u\n", count); + goto out; + } + + ret = init_subscribers(ffa_rx, count); + +out: + ffa_rx_release(); + + return ret; +} + static bool ffa_probe(void) { uint32_t vers; @@ -456,7 +650,8 @@ static bool ffa_probe(void) * TODO save result of checked features and use that information to * accept or reject requests from guests. */ - if ( + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || + !check_mandatory_feature(FFA_RX_RELEASE) || !check_mandatory_feature(FFA_RXTX_MAP_64) || !check_mandatory_feature(FFA_RXTX_UNMAP) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) @@ -478,6 +673,9 @@ static bool ffa_probe(void) } ffa_version = vers; + if ( !init_sps() ) + goto err_free_ffa_tx; + return true; err_free_ffa_tx: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520472.808148 (Exim 4.92) (envelope-from ) id 1pmrBV-0004Si-OS; Thu, 13 Apr 2023 07:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520472.808148; Thu, 13 Apr 2023 07:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBV-0004QD-CJ; Thu, 13 Apr 2023 07:15:57 +0000 Received: by outflank-mailman (input) for mailman id 520472; Thu, 13 Apr 2023 07:15:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBR-0001gq-QI for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:53 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06a81776-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:53 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id h37so1074263lfv.0 for ; Thu, 13 Apr 2023 00:15:53 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06a81776-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370152; x=1683962152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xuOrFGzp3bQy6WF/rcEt04FHwlM3ACHxMEsVNb5k43M=; b=C2cwYx0xgzJnKg9vDH7Al2RhRIpKXc3PMJ5q7dtFkoiIX62/R95NCUz5GZpPvj1xzn adjqcbajRJ6eh5vX/MJGIVljuc6wwbmhgBvSjx7eytIIGCI/llssQDclboM0bSTVcUZg S2YPoqxUDRRkqVNYrGqa9JmA++d10SF0WEb3XJyBtyIzJePnRBMmTIrS8qmOL5WAl8mK Rd9jID2u9u52+AZ7SQOxvvY4pLlB1eHf73RauurMg/aa0Cr+QasTS+t4s0HS1QzhAH7W 0EqLMngiZl7G8Ka8lyngFzW1F8ZNBnl6mkQcwj7bFEVZGy/t1+4CQZRQfb80YzWX3tlt PnvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370152; x=1683962152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xuOrFGzp3bQy6WF/rcEt04FHwlM3ACHxMEsVNb5k43M=; b=JbMRp/BzQ1sWS7MvN0Oxwiz84O7GwNjByqjOMRuJabfZavMHL9Fk1vhj/hTurCknc6 CpdG9NVmtFAhNGzkNsByWr5fo+BYfJb+3ouoi54KqjD/JA4qCezBYYwQtuk4o26ato7D VIMEjDvN/kNuzeoM0VPYZC+BENWQpAOZV6Y2zWF7I+VEhuK5mkKf8N+Lqd0GFGnco3ex LaVqaP+B79foiHFrVBaqGyMXHMMjPajdwITZvnXN16BpmxthyAUfDvPV4+sAV90ivmKc vdg4DbeT+nWbIXpLXDpE5VhG46o3kDRGGy+Phm0Ic5ruYKEty8oz57gg7eAOHFSwmrpm LuBQ== X-Gm-Message-State: AAQBX9cNYdGmeYNct9IqY1Ng7Se7qhCBYYHjMB5GnnVwZWzAf1tO2eLi EMiaZzroLWsjFGOE7f+ULiMwc/cECrJ0N90kLLU= X-Google-Smtp-Source: AKy350ZTVFbXDHijwkV8Xa+5i4VYHTf+Be6BMZHtsfXpiolxEsUHP1ZKdCCeiS99RxfioLYUbsjClQ== X-Received: by 2002:ac2:50ca:0:b0:4eb:40d4:e0d3 with SMTP id h10-20020ac250ca000000b004eb40d4e0d3mr563100lfm.35.1681370152689; Thu, 13 Apr 2023 00:15:52 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 12/22] xen/arm: ffa: support mapping guest RX/TX buffers Date: Thu, 13 Apr 2023 09:14:14 +0200 Message-Id: <20230413071424.3273490-13-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support in the mediator to map and unmap the RX and TX buffers provided by the guest using the two FF-A functions FFA_RXTX_MAP and FFA_RXTX_UNMAP. These buffer are later used to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 137 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 137 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index b4fea65ce31d..127397d8e448 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -74,6 +74,12 @@ */ #define FFA_RXTX_PAGE_COUNT 1 +/* + * Limits the number of pages RX/TX buffers guests can map. This value has + * been chosen arbitrary. + */ +#define FFA_MAX_RXTX_PAGE_COUNT 32 + /* * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: * BIT(31): Framework or partition message @@ -169,8 +175,15 @@ struct ffa_partition_info_1_1 { }; struct ffa_ctx { + void *rx; + const void *tx; + struct page_info *rx_pg; + struct page_info *tx_pg; + /* Number of 4kB pages in each of rx/rx_pg and tx/tx_pg */ + unsigned int page_count; /* FF-A version used by the guest */ uint32_t guest_vers; + bool tx_is_free; }; /* Negotiated FF-A version to use with the SPMC */ @@ -351,6 +364,11 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, set_user_reg(regs, 7, v7); } +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) +{ + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); +} + static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, uint32_t w3) { @@ -372,6 +390,105 @@ static void handle_version(struct cpu_user_regs *regs) set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); } +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, + register_t rx_addr, uint32_t page_count) +{ + uint32_t ret = FFA_RET_INVALID_PARAMETERS; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + struct page_info *tx_pg; + struct page_info *rx_pg; + p2m_type_t t; + void *rx; + void *tx; + + if ( !smccc_is_conv_64(fid) ) + { + /* + * Calls using the 32-bit calling convention must ignore the upper + * 32 bits in the argument registers. + */ + tx_addr &= UINT32_MAX; + rx_addr &= UINT32_MAX; + } + + if ( page_count > FFA_MAX_RXTX_PAGE_COUNT ) { + printk(XENLOG_ERR "ffa: RXTX_MAP: error: %u pages requested (limit %u)\n", + page_count, FFA_MAX_RXTX_PAGE_COUNT); + return FFA_RET_NOT_SUPPORTED; + } + + /* Already mapped */ + if ( ctx->rx ) + return FFA_RET_DENIED; + + tx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(tx_addr)), &t, P2M_ALLOC); + if ( !tx_pg ) + return FFA_RET_INVALID_PARAMETERS; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + goto err_put_tx_pg; + + rx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(rx_addr)), &t, P2M_ALLOC); + if ( !tx_pg ) + goto err_put_tx_pg; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + goto err_put_rx_pg; + + tx = __map_domain_page_global(tx_pg); + if ( !tx ) + goto err_put_rx_pg; + + rx = __map_domain_page_global(rx_pg); + if ( !rx ) + goto err_unmap_tx; + + ctx->rx = rx; + ctx->tx = tx; + ctx->rx_pg = rx_pg; + ctx->tx_pg = tx_pg; + ctx->page_count = page_count; + ctx->tx_is_free = true; + return FFA_RET_OK; + +err_unmap_tx: + unmap_domain_page_global(tx); +err_put_rx_pg: + put_page(rx_pg); +err_put_tx_pg: + put_page(tx_pg); + + return ret; +} + +static void rxtx_unmap(struct ffa_ctx *ctx) +{ + unmap_domain_page_global(ctx->rx); + unmap_domain_page_global(ctx->tx); + put_page(ctx->rx_pg); + put_page(ctx->tx_pg); + ctx->rx = NULL; + ctx->tx = NULL; + ctx->rx_pg = NULL; + ctx->tx_pg = NULL; + ctx->page_count = 0; + ctx->tx_is_free = false; +} + +static uint32_t handle_rxtx_unmap(void) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + if ( !ctx->rx ) + return FFA_RET_INVALID_PARAMETERS; + + rxtx_unmap(ctx); + + return FFA_RET_OK; +} + static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) { struct arm_smccc_1_2_regs arg = { .a0 = fid, }; @@ -428,6 +545,7 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) uint32_t fid = get_user_reg(regs, 0); struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.tee; + int e; if ( !ctx ) return false; @@ -440,6 +558,22 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_ID_GET: set_regs_success(regs, get_vm_id(d), 0); return true; + case FFA_RXTX_MAP_32: + case FFA_RXTX_MAP_64: + e = handle_rxtx_map(fid, get_user_reg(regs, 1), get_user_reg(regs, 2), + get_user_reg(regs, 3)); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; + case FFA_RXTX_UNMAP: + e = handle_rxtx_unmap(); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; case FFA_MSG_SEND_DIRECT_REQ_32: case FFA_MSG_SEND_DIRECT_REQ_64: handle_msg_send_direct_req(regs, fid); @@ -520,6 +654,9 @@ static int ffa_relinquish_resources(struct domain *d) get_vm_id(d), subscr_vm_destroyed[n], res); } + if ( ctx->rx ) + rxtx_unmap(ctx); + XFREE(d->arch.tee); return 0; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:15:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520473.808156 (Exim 4.92) (envelope-from ) id 1pmrBX-0004hy-0k; Thu, 13 Apr 2023 07:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520473.808156; Thu, 13 Apr 2023 07:15:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBW-0004eX-GH; Thu, 13 Apr 2023 07:15:58 +0000 Received: by outflank-mailman (input) for mailman id 520473; Thu, 13 Apr 2023 07:15:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBS-0001gq-QV for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:54 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 072bf309-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:54 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id q26so5660539lfe.9 for ; Thu, 13 Apr 2023 00:15:54 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 072bf309-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370153; x=1683962153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GR2XQOhN0lHMXLb5++oGf9JMuFsfS462ejdMhNzV4DY=; b=gGIRIObi89IrBahA6+sVARSNDH2wnEHfLGa2RrKoJNoix8BkRVP8wMKo1zIy0o4O6l riib/Kkt/TVJF0iHt9qdoHRCHHQ6QZqTR1RwRz+p1X6Vd16TYaCiSjlnDd3gvQXOAXeD oEMqSC6wOoZeobzdx9OVckFDx07TSkKlVG05BXl8g0HSzGz4iHjlfkLQY+ZNvak5s0dB fJrjUeZQNW/ZSphGIXV+xuNlLq/NZdkg6DaTG+ER8PNiVWiwngan7uN1w8GCM4Y+383/ E6lHRWyN2GPZ6CSET4S6lCJuBcPby9+uzJifTetCAM/4ns/7cRBrozAOIfINtn5wQ5Fy r81Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370153; x=1683962153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GR2XQOhN0lHMXLb5++oGf9JMuFsfS462ejdMhNzV4DY=; b=eopmVtXhuFc8qJchad0YJGfpyNTt31b4EYqh+pTONNJBsuOQrmLhVx3rklNWC+gPIk TrlBCZ3QfZU2jSdtYTdNIsD2Kbo9l38N+5kUr1ho8cGiNGi2eUvZdW12xMCfODlbTG3O LNHC66Mh3lVuzKiYoxi555Y7tip1UM4MV7yEvBUNGjNE26bbtBb8tzyfWYIpmS6kJleg 4KUQGkKgbBbUwV4v6n7EZCxLboAFaiV8WLBg3Wa3O6uU9qJXp26/8dNCCozu1mAf7yIL ahRoa69JMjMlYx0J1hKlIhJ0jf8Qc8xhIAQs2dcB7mo4w6/YlBSgOGpxwQuhf/Rd1DA2 HRfg== X-Gm-Message-State: AAQBX9cHzVHEt1LaRdL9cbdslY9DMfKn//EzA29j8/6oFnVVIIs3a0gA XrVqoXVzgpy4X0WdTvWWNj0xUMhjm/rcgmZ7jvM= X-Google-Smtp-Source: AKy350ab5t5FQhmU9qvLXFWPGFpKyD3JH7lTCDpinTADeMzIc498fZhRGX4cr3+LeonWPEkBuIqvng== X-Received: by 2002:ac2:515a:0:b0:4ed:5c73:79cb with SMTP id q26-20020ac2515a000000b004ed5c7379cbmr20947lfd.21.1681370153558; Thu, 13 Apr 2023 00:15:53 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 13/22] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET Date: Thu, 13 Apr 2023 09:14:15 +0200 Message-Id: <20230413071424.3273490-14-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests from a guest. The requests are forwarded to the SPMC and the response is translated according to the FF-A version in use by the guest. Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the caller (the guest in this case), so once it is done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 137 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 134 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 127397d8e448..74b8c517afb8 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -166,7 +166,18 @@ #define FFA_MSG_SEND 0x8400006EU #define FFA_MSG_POLL 0x8400006AU +/* + * Structs below ending with _1_0 are defined in FF-A-1.0-REL and + * struct ending with _1_1 are defined in FF-A-1.1-REL0. + */ + /* Partition information descriptor */ +struct ffa_partition_info_1_0 { + uint16_t id; + uint16_t execution_context; + uint32_t partition_properties; +}; + struct ffa_partition_info_1_1 { uint16_t id; uint16_t execution_context; @@ -183,7 +194,8 @@ struct ffa_ctx { unsigned int page_count; /* FF-A version used by the guest */ uint32_t guest_vers; - bool tx_is_free; + bool rx_is_free; + spinlock_t lock; }; /* Negotiated FF-A version to use with the SPMC */ @@ -198,9 +210,15 @@ static uint16_t subscr_vm_destroyed_count __read_mostly; /* * Our rx/tx buffers shared with the SPMC. FFA_RXTX_PAGE_COUNT is the * number of pages used in each of these buffers. + * + * The RX buffer is protected from concurrent usage with ffa_rx_buffer_lock. + * Note that the SPMC is also tracking the ownership of our RX buffer so + * for calls which uses our RX buffer to deliver a result we must call + * ffa_rx_release() to let the SPMC know that we're done with the buffer. */ static void *ffa_rx __read_mostly; static void *ffa_tx __read_mostly; +static DEFINE_SPINLOCK(ffa_rx_buffer_lock); static bool ffa_get_version(uint32_t *vers) { @@ -449,7 +467,7 @@ static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, ctx->rx_pg = rx_pg; ctx->tx_pg = tx_pg; ctx->page_count = page_count; - ctx->tx_is_free = true; + ctx->rx_is_free = true; return FFA_RET_OK; err_unmap_tx: @@ -473,7 +491,7 @@ static void rxtx_unmap(struct ffa_ctx *ctx) ctx->rx_pg = NULL; ctx->tx_pg = NULL; ctx->page_count = 0; - ctx->tx_is_free = false; + ctx->rx_is_free = false; } static uint32_t handle_rxtx_unmap(void) @@ -489,6 +507,100 @@ static uint32_t handle_rxtx_unmap(void) return FFA_RET_OK; } +static int32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, + uint32_t w4, uint32_t w5, + uint32_t *count) +{ + int32_t ret = FFA_RET_DENIED; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + /* + * FF-A v1.0 has w5 MBZ while v1.1 allows + * FFA_PARTITION_INFO_GET_COUNT_FLAG to be non-zero. + */ + if ( w5 == FFA_PARTITION_INFO_GET_COUNT_FLAG && + ctx->guest_vers == FFA_VERSION_1_1 ) + return ffa_partition_info_get(w1, w2, w3, w4, w5, count); + if ( w5 ) + return FFA_RET_INVALID_PARAMETERS; + + if ( !ffa_rx ) + return FFA_RET_DENIED; + + spin_lock(&ctx->lock); + if ( !ctx->page_count || !ctx->rx_is_free ) + goto out; + spin_lock(&ffa_rx_buffer_lock); + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); + if ( ret ) + goto out_rx_buf_unlock; + /* + * ffa_partition_info_get() succeeded so we now own the RX buffer we + * share with the SPMC. We must give it back using ffa_rx_release() + * once we've copied the content. + */ + + if ( ctx->guest_vers == FFA_VERSION_1_0 ) + { + size_t n; + struct ffa_partition_info_1_1 *src = ffa_rx; + struct ffa_partition_info_1_0 *dst = ctx->rx; + + if ( ctx->page_count * FFA_PAGE_SIZE < *count * sizeof(*dst) ) + { + ret = FFA_RET_NO_MEMORY; + goto out_rx_release; + } + + for ( n = 0; n < *count; n++ ) + { + dst[n].id = src[n].id; + dst[n].execution_context = src[n].execution_context; + dst[n].partition_properties = src[n].partition_properties; + } + } + else + { + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); + + if ( ctx->page_count * FFA_PAGE_SIZE < sz ) + { + ret = FFA_RET_NO_MEMORY; + goto out_rx_release; + } + + + memcpy(ctx->rx, ffa_rx, sz); + } + ctx->rx_is_free = false; +out_rx_release: + ffa_rx_release(); +out_rx_buf_unlock: + spin_unlock(&ffa_rx_buffer_lock); +out: + spin_unlock(&ctx->lock); + + return ret; +} + +static int32_t handle_rx_release(void) +{ + int32_t ret = FFA_RET_DENIED; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + spin_lock(&ctx->lock); + if ( !ctx->page_count || ctx->rx_is_free ) + goto out; + ret = FFA_RET_OK; + ctx->rx_is_free = true; +out: + spin_unlock(&ctx->lock); + + return ret; +} + static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) { struct arm_smccc_1_2_regs arg = { .a0 = fid, }; @@ -545,6 +657,7 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) uint32_t fid = get_user_reg(regs, 0); struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.tee; + uint32_t count; int e; if ( !ctx ) @@ -574,6 +687,24 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) else set_regs_success(regs, 0, 0); return true; + case FFA_PARTITION_INFO_GET: + e = handle_partition_info_get(get_user_reg(regs, 1), + get_user_reg(regs, 2), + get_user_reg(regs, 3), + get_user_reg(regs, 4), + get_user_reg(regs, 5), &count); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, count, 0); + return true; + case FFA_RX_RELEASE: + e = handle_rx_release(); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; case FFA_MSG_SEND_DIRECT_REQ_32: case FFA_MSG_SEND_DIRECT_REQ_64: handle_msg_send_direct_req(regs, fid); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:16:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:16:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520474.808164 (Exim 4.92) (envelope-from ) id 1pmrBY-0004t1-4s; Thu, 13 Apr 2023 07:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520474.808164; Thu, 13 Apr 2023 07:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBX-0004ob-9I; Thu, 13 Apr 2023 07:15:59 +0000 Received: by outflank-mailman (input) for mailman id 520474; Thu, 13 Apr 2023 07:15:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBV-0001gr-RI for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:57 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 087a2851-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:15:56 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id u12so154347lfu.5 for ; Thu, 13 Apr 2023 00:15:56 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 087a2851-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370155; x=1683962155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WQr8Av63Y05+KRPqQW2MMZI9t0v676Nzga708PFgZbs=; b=xvxXEBK2Compws42neNLU7+SQEYWylb37C3YXI+KnyyvdTZWisC+dizJ54qPLe/7BC F11IjC/0l2XcefIx8iJhYi3TF+WZWHPvfub72LmSh53AbtCaW9NIy3kY3Qja74ixd6PH dbyKlzrPuNpdAPqs4RGvaaVEx6hpV2OCdK1RbrAIyqwpOkJ6V5xMls0Fal+x6mJttwyD BXSFedWxmKUb5ec+JCbveQxkxKeJ5szHSwzzAfR9pPIVITVVN2iaOOtNDQYx5la3dSWo SZ3GQwv9ZHzTFkBJJDDO2IbPbD3586GTH9NzfXhR/C4dFl6khMr7vgaGNKbaIphF+riY vwmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370155; x=1683962155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WQr8Av63Y05+KRPqQW2MMZI9t0v676Nzga708PFgZbs=; b=YoD1S/G4Fn6dunZ6G4PLzQ1PR99OJr3crDXKwhquv5xYIDkHrwfAAk2A+sc+yS8vHe zD20h1qm869TlTyPyKSk7h2VxJ/h+AOc9SmCea1iH6rqXSPmVlApxrWE6qxHghW7sSmq hdJQr6/mmdmn8Fkf+FOhIEKwf+YOl7Bd67SPPQfAEc5cVHKW8ARdtkck0jQjcRtodWDC MmnVd7zhIzFy9BlBoK0+4uTldDkU9eXCV9mScf32I6X/Ie/COcR/Axb3KtNLT7uXoDqE TcdPAx46NJaUvDgLgEwNQALUWK3ixJrF5EVmhxD6wdeCyYRdGYnza/qFLILFGI56iBf4 6ybw== X-Gm-Message-State: AAQBX9e+aeVqNYZ65eeEnrH1B4Xe0MGJdftf2X//TTlyf4EORUzSPUQi CvRgmUFozuzGUPhrJQSiulBBL1KbTlr45TzOR/E= X-Google-Smtp-Source: AKy350Zs8E4alI77NZ8nPoBbhBLjXrkqVWz+tUygSw+cu9HmXrFfnPMlnm+5FI3jSslmcHKSwGkg1A== X-Received: by 2002:a19:f00f:0:b0:4eb:2b32:feab with SMTP id p15-20020a19f00f000000b004eb2b32feabmr444477lfc.50.1681370155779; Thu, 13 Apr 2023 00:15:55 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 16/22] xen/arm: ffa: add ABI structs for sharing memory Date: Thu, 13 Apr 2023 09:14:18 +0200 Message-Id: <20230413071424.3273490-17-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds the ABI structs used by function FFA_MEM_SHARE and friends for sharing memory. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 69 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 58c581c8ffc7..f3e05911e16e 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -245,6 +245,75 @@ struct ffa_partition_info_1_1 { uint8_t uuid[16]; }; +/* Constituent memory region descriptor */ +struct ffa_address_range { + uint64_t address; + uint32_t page_count; + uint32_t reserved; +}; + +/* Composite memory region descriptor */ +struct ffa_mem_region { + uint32_t total_page_count; + uint32_t address_range_count; + uint64_t reserved; + struct ffa_address_range address_range_array[]; +}; + +/* Memory access permissions descriptor */ +struct ffa_mem_access_perm { + uint16_t endpoint_id; + uint8_t perm; + uint8_t flags; +}; + +/* Endpoint memory access descriptor */ +struct ffa_mem_access { + struct ffa_mem_access_perm access_perm; + uint32_t region_offs; + uint64_t reserved; +}; + +/* Lend, donate or share memory transaction descriptor */ +struct ffa_mem_transaction_1_0 { + uint16_t sender_id; + uint8_t mem_reg_attr; + uint8_t reserved0; + uint32_t flags; + uint64_t handle; + uint64_t tag; + uint32_t reserved1; + uint32_t mem_access_count; + struct ffa_mem_access mem_access_array[]; +}; + +struct ffa_mem_transaction_1_1 { + uint16_t sender_id; + uint16_t mem_reg_attr; + uint32_t flags; + uint64_t handle; + uint64_t tag; + uint32_t mem_access_size; + uint32_t mem_access_count; + uint32_t mem_access_offs; + uint8_t reserved[12]; +}; + +/* Endpoint RX/TX descriptor */ +struct ffa_endpoint_rxtx_descriptor_1_0 { + uint16_t sender_id; + uint16_t reserved; + uint32_t rx_range_count; + uint32_t tx_range_count; +}; + +struct ffa_endpoint_rxtx_descriptor_1_1 { + uint16_t sender_id; + uint16_t reserved; + uint32_t rx_region_offs; + uint32_t tx_region_offs; +}; + struct ffa_ctx { void *rx; const void *tx; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:16:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:16:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520475.808176 (Exim 4.92) (envelope-from ) id 1pmrBZ-0005MJ-Qx; Thu, 13 Apr 2023 07:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520475.808176; Thu, 13 Apr 2023 07:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBZ-0005Jb-9X; Thu, 13 Apr 2023 07:16:01 +0000 Received: by outflank-mailman (input) for mailman id 520475; Thu, 13 Apr 2023 07:15:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBX-0001gr-B5 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:59 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 096abe3f-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:15:57 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id u12so154417lfu.5 for ; Thu, 13 Apr 2023 00:15:57 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 096abe3f-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370157; x=1683962157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ul/1FA/L6eAJ4JFgbgtNcnhIDZBc/H8WlYcLQZsgqf4=; b=gt9n3iyMe7ujsjYVCsHKczv2GRF+eCg0yIseZ/d3zg7kq7p0mXW7qumqQ4m3zom+4s sgFc1hD5ZxXD5D4hgjHNHJAe+WWFSi4rGZMU4BICPkyUT3+mCg+IGbyWvyiHpsNvNvbR PCyk7QuUpfkeG1of60PFJ6umYlFrBo4V85VB7igwQ0rDpgwViKLOyecfqv0iA1zZuIbf ebNKYsqSycPoAXUa1ZsLPjVxGUuGN44qerYrHAXJ9DeEr9eeSwDL/KAA0cwGnMl5ZpYN 0Gwt2TWjFGMmBmyOp9OZjIkZsbnuGw8SEcecI9sohJBJBgexCOttwJgcdMxgjXsGexF/ Ou1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370157; x=1683962157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ul/1FA/L6eAJ4JFgbgtNcnhIDZBc/H8WlYcLQZsgqf4=; b=BlqrqzacRnodGiGgjL6rNmCFfXXZSbiUPcBqNNsqriwbrJG+IL1JPbOcuLWiZ/yUnH yPyQpsSuFE0/7mpgna8GY4YUHycbzD9Gu8bfwvAgWN+Jdhzt4AmvYpI1B5WWhT5Tukg8 InQHdS7WYG2EzXm2hEKC85HhLY4v76kkRwyIX25dHIu6g+2/izE1ytPYoB7VCs4cqPI4 kwqCT+fZGH35n7aYUMOY0kMWAW4dBBrDxLCPmvZTFCo1qjL8jZbSRYSHRwivx9RNj/NG j3YDoCrW1XiFQ4mPuNudFcqfqJTVyvTlaeKVIAFMm4esqV9G3+omjDbSfgrKPfUz6QDZ MORw== X-Gm-Message-State: AAQBX9epkTs4zDOOCR/xaIcpcd8GDvqAo7wVHxM2Dzwis05+n3qmjwPd BINCkL2z68EInMXlrqJumlQjotPmX4b/b/KXXg8= X-Google-Smtp-Source: AKy350bZfh7qZ51cjeaR08/Y3OCAVeKqhEC41a1zdISPOxbkbb1wGKx3EkXrHZZ5gvKNgbhX2ITudQ== X-Received: by 2002:a19:f017:0:b0:4e8:4b58:bfbd with SMTP id p23-20020a19f017000000b004e84b58bfbdmr615879lfc.10.1681370157386; Thu, 13 Apr 2023 00:15:57 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 18/22] xen/arm: ffa: add support to reclaim shared memory Date: Thu, 13 Apr 2023 09:14:20 +0200 Message-Id: <20230413071424.3273490-19-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support to reclaim memory previously shared with FFA_MEM_SHARE. A memory region that doesn't need to be shared any longer can be reclaimed with FFA_MEM_RECLAIM once the SP doesn't use it any longer. This is checked by the SPMC and not in control of the mediator. Adds a check that the SP supports the needed FF-A feature FFA_MEM_RECLAIM. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 53 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 438e0b21d1ea..47ff899eca32 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -535,6 +535,12 @@ static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, } } +static int32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, + uint32_t flags) +{ + return ffa_simple_call(FFA_MEM_RECLAIM, handle_lo, handle_hi, flags, 0); +} + static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, uint8_t msg) { @@ -1256,6 +1262,43 @@ out_set_ret: set_regs_error(regs, ret); } +static int handle_mem_reclaim(uint64_t handle, uint32_t flags) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + struct ffa_shm_mem *shm; + register_t handle_hi; + register_t handle_lo; + int ret; + + spin_lock(&ctx->lock); + list_for_each_entry(shm, &ctx->shm_list, list) + { + if ( shm->handle == handle ) + goto found_it; + } + shm = NULL; + ret = FFA_RET_INVALID_PARAMETERS; + goto out; +found_it: + + uint64_to_regpair(&handle_hi, &handle_lo, handle); + ret = ffa_mem_reclaim(handle_lo, handle_hi, flags); + if ( ret ) + { + shm = NULL; + goto out; + } + + list_del(&shm->list); + +out: + free_ffa_shm_mem(ctx, shm); + spin_unlock(&ctx->lock); + + return ret; +} + static bool ffa_handle_call(struct cpu_user_regs *regs) { uint32_t fid = get_user_reg(regs, 0); @@ -1317,6 +1360,15 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_MEM_SHARE_64: handle_mem_share(regs); return true; + case FFA_MEM_RECLAIM: + e = handle_mem_reclaim(regpair_to_uint64(get_user_reg(regs, 2), + get_user_reg(regs, 1)), + get_user_reg(regs, 3)); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -1534,6 +1586,7 @@ static bool ffa_probe(void) !check_mandatory_feature(FFA_MEM_SHARE_64) || !check_mandatory_feature(FFA_RXTX_UNMAP) || !check_mandatory_feature(FFA_MEM_SHARE_32) || + !check_mandatory_feature(FFA_MEM_RECLAIM) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:16:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520476.808197 (Exim 4.92) (envelope-from ) id 1pmrBe-0006Ia-Ih; Thu, 13 Apr 2023 07:16:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520476.808197; Thu, 13 Apr 2023 07:16:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBd-0006FW-40; Thu, 13 Apr 2023 07:16:05 +0000 Received: by outflank-mailman (input) for mailman id 520476; Thu, 13 Apr 2023 07:16:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBa-0001gr-LR for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:16:02 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b48f696-d9cb-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 09:16:01 +0200 (CEST) Received: by mail-lf1-x133.google.com with SMTP id o1so17896811lfc.2 for ; Thu, 13 Apr 2023 00:16:01 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:16:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b48f696-d9cb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370160; x=1683962160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bHjUSAX1G+PSTsVlSk/rHD6dSlwHglC2zbE6BMp+VKo=; b=btNr9S7x7r1kSXq07/s61mffJI59SVCiAB7WMvILy3nvyhwmRc49W267xWGxNrQGe4 uZ/bePskes7286wzyRplVA/AXc+q/d3GwJP+NjiHv41DvwIXAV7VZPSy5ZLDo7fRpIO/ Afz6rk03wZDSD1+3HjPimoXN11zLN1uLy5v1KYLFn8EfGShlBXaRDjxypm/iA8aQMayx kDrOf4kD+R7f7sZZaC51CEahX7GYucH0U4DKajspeSyDHl5NXzH/3/W5f3ziz9k4Qwsv m+LWayOSWZRcy1Ax714BDl+tpd35jcyfBVfvbhYCtJ5HWEWKOfB9q/S4YpRavvntvdUP xf7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370160; x=1683962160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bHjUSAX1G+PSTsVlSk/rHD6dSlwHglC2zbE6BMp+VKo=; b=WKpv1E+oFYrlaWebcqlK0/tkUaqScx2R8DqIqnGLIiYpuplQkgfBBrfcNZ2Kch4KoO ga8iVvII91j+ZuEli6PfoxBLVov+Q1NV5I4wK+2I1UAAbpg8TGiuB1o3Xn/hvC5hXAza tA9AF+q9nOGYqb5kYD0uhe5BC8r4tK/Sb6jJRQjfEDqMkv8/rmFL+4wkt4CFDWDied83 1KNHoqkvBRkX/RuSbbRREMm3jurD+rVtTkROu/W9zFrpZkv0ycbU4gbIpoqxYvjL11GP 4bMuOkKKPFABgcHHfZR2gyPZ5pJo7i9BcWNLKxN6Zpok173KPyeHfr2uXphdHOr5DIU9 4q9A== X-Gm-Message-State: AAQBX9ck5LpFes6S8H0HsXcgplmRtf36GAof49cMreza+gdsJx1mU/Y7 UIMZ7SJxX/C8jNjF0okyDlAx7yp2i27ThxdoKBo= X-Google-Smtp-Source: AKy350YWU9r6iN+MQQbR65FG8mulx+cLkSIkEYhbzgpG253YbNkvwHiggHR8kCHk4ZKcRQGM0YA/Hg== X-Received: by 2002:ac2:454e:0:b0:4ec:89d3:a8ac with SMTP id j14-20020ac2454e000000b004ec89d3a8acmr459019lfm.30.1681370160490; Thu, 13 Apr 2023 00:16:00 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator Date: Thu, 13 Apr 2023 09:14:24 +0200 Message-Id: <20230413071424.3273490-23-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describes a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md | 8 ++++++++ docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index aa1940e55f09..1fd746f7f7f2 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -818,6 +818,14 @@ that covers the DMA of the device to be passed through. No support for QEMU backends in a 16K or 64K domain. +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator + + Status, Arm64: Tech Preview + +There are still some code paths where a vCPU may hog a pCPU longer than +necessary. The FF-A mediator is not yet implemented for Arm32. Part of the +FF-A specification is not supported. + ### ARM: Guest Device Tree support Status: Supported diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 10f37990be57..bba99c576b48 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1645,6 +1645,21 @@ in OP-TEE. This feature is a B. +=item B + +B Allow a guest to communicate via FF-A with Secure Partitions +(SP), default false. + +Currently is only a small subset of the FF-A specification supported. Just +enough to communicate with OP-TEE. In general only direct messaging and +sharing memory with one SP. More advanced use cases where memory might be +shared or donated to multple SPs are not supported. + +See L for more +informantion about FF-A. + +This feature is a B. + =back =back -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:16:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:16:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520491.808211 (Exim 4.92) (envelope-from ) id 1pmrCG-0001yC-4R; Thu, 13 Apr 2023 07:16:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520491.808211; Thu, 13 Apr 2023 07:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCG-0001y3-05; Thu, 13 Apr 2023 07:16:44 +0000 Received: by outflank-mailman (input) for mailman id 520491; Thu, 13 Apr 2023 07:16:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCE-0001wd-Ga for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:16:42 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0905fb16-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:57 +0200 (CEST) Received: by mail-lj1-x236.google.com with SMTP id x34so907330ljq.1 for ; Thu, 13 Apr 2023 00:15:57 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0905fb16-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370156; x=1683962156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8ZCEdSFHwslEgaIydy46nytop0ECS1ocVnr/aHKCQRk=; b=SeDjGg7l463KhgfWyWGSRKKBJwYa1xPY3KJchJoSqOmVer4k516NpP7GKfvOctp81R H+8IWvi+Jl5z9xCsyo9luagc2VZEZbTFXwgvZG0YiJSctGIT3rLgXHZRTY8GJpOGwsHA yJKv+V+FsiINqiHkCMUGI3rXN9jcjB0Rn4OcyIZ7Lnj0dME7Qg9UzTCIpgpg72Zq0EZw v3CTmvW+lZNGzxjsjy08f3HRr6Y02KIbzyrth9J5Zd8zjwY6wKOOv0AovCPC5uvLN005 2gVBYZpcW4dtlLw8gFj79f+ZwmeI4EKlnKoZFBWwr4y42IfGY/i0U31ZVCWff6vlr54z V5OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370156; x=1683962156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ZCEdSFHwslEgaIydy46nytop0ECS1ocVnr/aHKCQRk=; b=eurVkONe0JzwW0Nl1xj6oWsXOyUROI4IkQ0omhRShD4BOzjncT45e3gmRCO+vkobHQ ms2xOFvqe38PAn8u6jpY9HsvDSvFfcKQDTOFxZjvGj2Vcvg5P0husbrpJGVqq6W6RdLT dKTXONpP/bn7Bl97W1EcGehTenF0uNblw7PWDXdemkQRVgPe0d414u3yJHDEslDu1RLx +1naRlD/s7Dj/k/rKcbzLHH8Lyb6HnY2W85RifNvxwvEIdlH5m74up1a2UvR+YS4v391 l9ImGyBRLJYcBNCJ78JLLbBmk8PgMHvjplw9z8/v7F3fmhcIXTN96Q32zD9+VXREoP0P GKrA== X-Gm-Message-State: AAQBX9eiEXDlTYTzP+rAqBpCV+k0SwScbY2Pg+wz6IVfTb+/L+aA+xVw MYrgMt1//TvfC6XaOqBmZ2B/TELq05FmenfAJY8= X-Google-Smtp-Source: AKy350YK+HbgR9hM+KGDovRsTyxsnfWzKnI/0keGOj9aRz2024n97uAT+dey9VRIssh4Bkirsd3r+Q== X-Received: by 2002:a2e:97c5:0:b0:2a7:75aa:40c with SMTP id m5-20020a2e97c5000000b002a775aa040cmr454342ljj.10.1681370156514; Thu, 13 Apr 2023 00:15:56 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 17/22] xen/arm: ffa: support sharing memory Date: Thu, 13 Apr 2023 09:14:19 +0200 Message-Id: <20230413071424.3273490-18-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for a guest to share memory with an SP using FFA_MEM_SHARE. Only memory regions small enough to be shared with a single call to FFA_MEM_SHARE are supported. With this commit we have a FF-A version 1.1 [1] mediator able to communicate with a Secure Partition in secure world using shared memory. The secure world must use FF-A version 1.1, but the guest is free to use version 1.0 or version 1.1. Adds a check that the SP supports the needed FF-A features FFA_MEM_SHARE_64 or FFA_MEM_SHARE_32. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 483 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 483 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index f3e05911e16e..438e0b21d1ea 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -299,6 +299,38 @@ struct ffa_mem_transaction_1_1 { uint8_t reserved[12]; }; +/* Calculate offset of struct ffa_mem_access from start of buffer */ +#define MEM_ACCESS_OFFSET(access_idx) \ + ( sizeof(struct ffa_mem_transaction_1_1) + \ + ( access_idx ) * sizeof(struct ffa_mem_access) ) + +/* Calculate offset of struct ffa_mem_region from start of buffer */ +#define REGION_OFFSET(access_count, region_idx) \ + ( MEM_ACCESS_OFFSET(access_count) + \ + ( region_idx ) * sizeof(struct ffa_mem_region) ) + +/* Calculate offset of struct ffa_address_range from start of buffer */ +#define ADDR_RANGE_OFFSET(access_count, region_count, range_idx) \ + ( REGION_OFFSET(access_count, region_count) + \ + ( range_idx ) * sizeof(struct ffa_address_range) ) + +/* + * The parts needed from struct ffa_mem_transaction_1_0 or struct + * ffa_mem_transaction_1_1, used to provide an abstraction of difference in + * data structures between version 1.0 and 1.1. This is just an internal + * interface and can be changed without changing any ABI. + */ +struct ffa_mem_transaction_int { + uint16_t sender_id; + uint8_t mem_reg_attr; + uint8_t flags; + uint8_t mem_access_size; + uint8_t mem_access_count; + uint16_t mem_access_offs; + uint64_t handle; + uint64_t tag; +}; + /* Endpoint RX/TX descriptor */ struct ffa_endpoint_rxtx_descriptor_1_0 { uint16_t sender_id; @@ -324,9 +356,22 @@ struct ffa_ctx { /* FF-A version used by the guest */ uint32_t guest_vers; bool rx_is_free; + /* Used shared memory objects, struct ffa_shm_mem */ + struct list_head shm_list; + /* Number of allocated shared memory object */ + unsigned int shm_count; spinlock_t lock; }; +struct ffa_shm_mem { + struct list_head list; + uint16_t sender_id; + uint16_t ep_id; /* endpoint, the one lending */ + uint64_t handle; /* FFA_HANDLE_INVALID if not set yet */ + unsigned int page_count; + struct page_info *pages[]; +}; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -348,6 +393,7 @@ static uint16_t subscr_vm_destroyed_count __read_mostly; static void *ffa_rx __read_mostly; static void *ffa_tx __read_mostly; static DEFINE_SPINLOCK(ffa_rx_buffer_lock); +static DEFINE_SPINLOCK(ffa_tx_buffer_lock); static bool ffa_get_version(uint32_t *vers) { @@ -454,6 +500,41 @@ static int32_t ffa_rx_release(void) return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); } +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, + register_t addr, uint32_t pg_count, + uint64_t *handle) +{ + struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MEM_SHARE_64, + .a1 = tot_len, + .a2 = frag_len, + .a3 = addr, + .a4 = pg_count, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_ERROR: + if ( resp.a2 ) + return resp.a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + *handle = regpair_to_uint64(resp.a3, resp.a2); + return FFA_RET_OK; + case FFA_MEM_FRAG_RX: + *handle = regpair_to_uint64(resp.a2, resp.a1); + if ( resp.a3 > INT32_MAX ) /* Impossible value */ + return FFA_RET_ABORTED; + return resp.a3 & INT32_MAX; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, uint8_t msg) { @@ -781,6 +862,400 @@ out: resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); } +/* + * Gets all page and assigns them to the supplied shared memory object. If + * this function fails then the caller is still expected to call + * put_shm_pages() as a cleanup. + */ +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, + const struct ffa_address_range *range, + uint32_t range_count, unsigned int start_page_idx, + unsigned int *last_page_idx) +{ + unsigned int pg_idx = start_page_idx; + gfn_t gfn; + unsigned int n; + unsigned int m; + p2m_type_t t; + uint64_t addr; + + for ( n = 0; n < range_count; n++ ) + { + for ( m = 0; m < range[n].page_count; m++ ) + { + if ( pg_idx >= shm->page_count ) + return FFA_RET_INVALID_PARAMETERS; + + addr = read_atomic(&range[n].address); + gfn = gaddr_to_gfn(addr + m * FFA_PAGE_SIZE); + shm->pages[pg_idx] = get_page_from_gfn(d, gfn_x(gfn), &t, + P2M_ALLOC); + if ( !shm->pages[pg_idx] ) + return FFA_RET_DENIED; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + return FFA_RET_DENIED; + pg_idx++; + } + } + + *last_page_idx = pg_idx; + + return FFA_RET_OK; +} + +static void put_shm_pages(struct ffa_shm_mem *shm) +{ + unsigned int n; + + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) + { + put_page(shm->pages[n]); + shm->pages[n] = NULL; + } +} + +static struct ffa_shm_mem *alloc_ffa_shm_mem(struct ffa_ctx *ctx, + unsigned int page_count) +{ + struct ffa_shm_mem *shm; + + if ( page_count >= FFA_MAX_SHM_PAGE_COUNT || + ctx->shm_count >= FFA_MAX_SHM_COUNT ) + return NULL; + + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); + if ( shm ) + { + ctx->shm_count++; + shm->page_count = page_count; + } + + return shm; +} + +static void free_ffa_shm_mem(struct ffa_ctx *ctx, struct ffa_shm_mem *shm) +{ + if ( shm ) { + ASSERT(ctx->shm_count > 0); + ctx->shm_count--; + put_shm_pages(shm); + xfree(shm); + } +} + +static void init_range(struct ffa_address_range *addr_range, + paddr_t pa) +{ + memset(addr_range, 0, sizeof(*addr_range)); + addr_range->address = pa; + addr_range->page_count = 1; +} + +/* + * This function uses the ffa_tx buffer to transmit the memory transaction + * descriptor. The function depends ffa_tx_buffer_lock to be used to guard + * the buffer from concurrent use. + */ +static int share_shm(struct ffa_shm_mem *shm) +{ + const uint32_t max_frag_len = FFA_RXTX_PAGE_COUNT * FFA_PAGE_SIZE; + struct ffa_mem_access *mem_access_array; + struct ffa_mem_transaction_1_1 *descr; + struct ffa_address_range *addr_range; + struct ffa_mem_region *region_descr; + const unsigned int region_count = 1; + void *buf = ffa_tx; + uint32_t frag_len; + uint32_t tot_len; + paddr_t last_pa; + unsigned int n; + paddr_t pa; + + ASSERT(spin_is_locked(&ffa_tx_buffer_lock)); + ASSERT(shm->page_count); + + descr = buf; + memset(descr, 0, sizeof(*descr)); + descr->sender_id = shm->sender_id; + descr->handle = shm->handle; + descr->mem_reg_attr = FFA_NORMAL_MEM_REG_ATTR; + descr->mem_access_count = 1; + descr->mem_access_size = sizeof(*mem_access_array); + descr->mem_access_offs = MEM_ACCESS_OFFSET(0); + + mem_access_array = buf + descr->mem_access_offs; + memset(mem_access_array, 0, sizeof(*mem_access_array)); + mem_access_array[0].access_perm.endpoint_id = shm->ep_id; + mem_access_array[0].access_perm.perm = FFA_MEM_ACC_RW; + mem_access_array[0].region_offs = REGION_OFFSET(descr->mem_access_count, 0); + + region_descr = buf + mem_access_array[0].region_offs; + memset(region_descr, 0, sizeof(*region_descr)); + region_descr->total_page_count = shm->page_count; + + region_descr->address_range_count = 1; + last_pa = page_to_maddr(shm->pages[0]); + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) + { + pa = page_to_maddr(shm->pages[n]); + if ( last_pa + FFA_PAGE_SIZE == pa ) + continue; + region_descr->address_range_count++; + } + + tot_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, + region_descr->address_range_count); + if ( tot_len > max_frag_len ) + return FFA_RET_NOT_SUPPORTED; + + addr_range = region_descr->address_range_array; + frag_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, 1); + last_pa = page_to_maddr(shm->pages[0]); + init_range(addr_range, last_pa); + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) + { + pa = page_to_maddr(shm->pages[n]); + if ( last_pa + FFA_PAGE_SIZE == pa ) + { + addr_range->page_count++; + continue; + } + + frag_len += sizeof(*addr_range); + addr_range++; + init_range(addr_range, pa); + } + + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); +} + +static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, + struct ffa_mem_transaction_int *trans) +{ + uint16_t mem_reg_attr; + uint32_t flags; + uint32_t count; + uint32_t offs; + uint32_t size; + + if ( ffa_vers >= FFA_VERSION_1_1 ) + { + const struct ffa_mem_transaction_1_1 *descr; + + if ( blen < sizeof(*descr) ) + return FFA_RET_INVALID_PARAMETERS; + + descr = buf; + trans->sender_id = descr->sender_id; + mem_reg_attr = descr->mem_reg_attr; + flags = descr->flags; + trans->handle = descr->handle; + trans->tag = descr->tag; + + count = descr->mem_access_count; + size = descr->mem_access_size; + offs = descr->mem_access_offs; + } + else + { + const struct ffa_mem_transaction_1_0 *descr; + + if ( blen < sizeof(*descr) ) + return FFA_RET_INVALID_PARAMETERS; + + descr = buf; + trans->sender_id = descr->sender_id; + mem_reg_attr = descr->mem_reg_attr; + flags = descr->flags; + trans->handle = descr->handle; + trans->tag = descr->tag; + + count = descr->mem_access_count; + size = sizeof(struct ffa_mem_access); + offs = offsetof(struct ffa_mem_transaction_1_0, mem_access_array); + } + /* + * Make sure that "descr" which is shared with the guest isn't accessed + * again after this point. + */ + barrier(); + + /* + * We're doing a rough check to see that no information is lost when + * tranfering the values into a struct ffa_mem_transaction_int below. + * The fields in struct ffa_mem_transaction_int are wide enough to hold + * any valid value so being out of range means that something is wrong. + */ + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_MAX || + count > UINT8_MAX || offs > UINT16_MAX ) + return FFA_RET_INVALID_PARAMETERS; + + /* Check that the endpoint memory access descriptor array fits */ + if ( size * count + offs > blen ) + return FFA_RET_INVALID_PARAMETERS; + + trans->mem_reg_attr = mem_reg_attr; + trans->flags = flags; + trans->mem_access_size = size; + trans->mem_access_count = count; + trans->mem_access_offs = offs; + + return 0; +} + +static void handle_mem_share(struct cpu_user_regs *regs) +{ + uint32_t tot_len = get_user_reg(regs, 1); + uint32_t frag_len = get_user_reg(regs, 2); + uint64_t addr = get_user_reg(regs, 3); + uint32_t page_count = get_user_reg(regs, 4); + const struct ffa_mem_region *region_descr; + const struct ffa_mem_access *mem_access; + struct ffa_mem_transaction_int trans; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + struct ffa_shm_mem *shm = NULL; + unsigned int last_page_idx = 0; + register_t handle_hi = 0; + register_t handle_lo = 0; + int ret = FFA_RET_DENIED; + uint32_t range_count; + uint32_t region_offs; + + /* + * We're only accepting memory transaction descriptors via the rx/tx + * buffer. + */ + if ( addr ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_set_ret; + } + + /* Check that fragment length doesn't exceed total length */ + if ( frag_len > tot_len ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_set_ret; + } + + /* We currently only support a single fragment */ + if ( frag_len != tot_len ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_set_ret; + } + + spin_lock(&ctx->lock); + + if ( frag_len > ctx->page_count * FFA_PAGE_SIZE ) + goto out_unlock; + + ret = read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &trans); + if ( ret ) + goto out_unlock; + + if ( trans.mem_reg_attr != FFA_NORMAL_MEM_REG_ATTR ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + /* Only supports sharing it with one SP for now */ + if ( trans.mem_access_count != 1 ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + if ( trans.sender_id != get_vm_id(d) ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_unlock; + } + + /* Check that it fits in the supplied data */ + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) + goto out_unlock; + + mem_access = ctx->tx + trans.mem_access_offs; + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + region_offs = read_atomic(&mem_access->region_offs); + if ( sizeof(*region_descr) + region_offs > frag_len ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + region_descr = ctx->tx + region_offs; + range_count = read_atomic(®ion_descr->address_range_count); + page_count = read_atomic(®ion_descr->total_page_count); + + if ( !page_count ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_unlock; + } + + shm = alloc_ffa_shm_mem(ctx, page_count); + if ( !shm ) + { + ret = FFA_RET_NO_MEMORY; + goto out_unlock; + } + shm->sender_id = trans.sender_id; + shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); + + /* + * Check that the Composite memory region descriptor fits. + */ + if ( sizeof(*region_descr) + region_offs + + range_count * sizeof(struct ffa_address_range) > frag_len ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, + 0, &last_page_idx); + if ( ret ) + goto out; + if ( last_page_idx != shm->page_count ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + /* Note that share_shm() uses our tx buffer */ + spin_lock(&ffa_tx_buffer_lock); + ret = share_shm(shm); + spin_unlock(&ffa_tx_buffer_lock); + if ( ret ) + goto out; + + list_add_tail(&shm->list, &ctx->shm_list); + + uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); + +out: + if ( ret ) + free_ffa_shm_mem(ctx, shm); +out_unlock: + spin_unlock(&ctx->lock); + +out_set_ret: + if ( ret == 0) + set_regs_success(regs, handle_lo, handle_hi); + else + set_regs_error(regs, ret); +} + static bool ffa_handle_call(struct cpu_user_regs *regs) { uint32_t fid = get_user_reg(regs, 0); @@ -838,6 +1313,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_MSG_SEND_DIRECT_REQ_64: handle_msg_send_direct_req(regs, fid); return true; + case FFA_MEM_SHARE_32: + case FFA_MEM_SHARE_64: + handle_mem_share(regs); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -879,6 +1358,8 @@ static int ffa_domain_init(struct domain *d) } } + INIT_LIST_HEAD(&ctx->shm_list); + d->arch.tee = ctx; return 0; @@ -1050,7 +1531,9 @@ static bool ffa_probe(void) if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || !check_mandatory_feature(FFA_RX_RELEASE) || !check_mandatory_feature(FFA_RXTX_MAP_64) || + !check_mandatory_feature(FFA_MEM_SHARE_64) || !check_mandatory_feature(FFA_RXTX_UNMAP) || + !check_mandatory_feature(FFA_MEM_SHARE_32) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:16:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:16:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520493.808221 (Exim 4.92) (envelope-from ) id 1pmrCH-0002EW-D3; Thu, 13 Apr 2023 07:16:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520493.808221; Thu, 13 Apr 2023 07:16:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCH-0002EB-7u; Thu, 13 Apr 2023 07:16:45 +0000 Received: by outflank-mailman (input) for mailman id 520493; Thu, 13 Apr 2023 07:16:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCG-0001wd-6K for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:16:44 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ac74948-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:16:00 +0200 (CEST) Received: by mail-lf1-x12c.google.com with SMTP id d7so28947048lfj.3 for ; Thu, 13 Apr 2023 00:16:00 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ac74948-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370159; x=1683962159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yodICrBL6WOIoQq7XouRka4JhH5GEeCWApa9x3I7zt0=; b=TQjlYR0eNL3PQqTubzL6FvZ4C8RV2/tVxlgPb2sFYtuNXlIpwOWCppcmvIe4zIe6VV h/id3+UsnHaa+wwPJh3Yk05O3O4PzFz2lywfhUvt3lH4hHwVNclytoMHsiGyTkYaTn1H JXhGyHGP/xcNp7ni5CCR8pVsHdhlTJcClMvRX8kCRpTaYs1/qgElR1ZG5z0TOXl39bUl k6p7C2DA/NAf4h/hJ/oKU4Ni18Y3e5VPe5J5M3rIzab0gFCACyYOuHsLvAzeEM6+RF25 s/0kLV8cVrCWZcbYAZQO8Bzv8ZDC/7jG53JulrOjbCXDMjF32i15ivwz15XrQwF1uv/g uOHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370159; x=1683962159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yodICrBL6WOIoQq7XouRka4JhH5GEeCWApa9x3I7zt0=; b=iS7TF9cZURWBlGkzHebP/LAchVAqlXqn/sbO9rJv7owncJ9y6JIAT561FDvcG2vYEt UALnF2JLPyYCJMcqTcBgwnfxDq4lcJh3aL9Wlm2wVUQvwDd57LbFWORu+CURc8OkC22o nsHezcBGt5itZ51FJqPGjsIzwkNSnZDHyjNPy5wCj00IU0JeMsKV2B5y8NE86WTQyXkX cVoQoBjJHWlw7O2FPfykYFMsrJw7z6eIx63sz3W7S9/9RK9aHvnb1DroBC/2CPSpbnae HKpSmwqTLfL7Xw58m/TzsVYPPgH4ILwLAYzuQxKlsrMdsp5nctko9O/B1VCbyP0X4EjR LLGw== X-Gm-Message-State: AAQBX9dSJELDOQ4IQe6YDDM+aC8IUr/hdtPXMJVAk+s2SioqX5kPpmoI hI0fW/1Senkl3ESHzdaavf07eX4B5usxh4BXuRE= X-Google-Smtp-Source: AKy350bdjDbsFWiQejACd34meF454MJsfUSzRAHwjvgKOixy0ULG2yl6IgQa9uz5wrrP2F/JvSeG9A== X-Received: by 2002:ac2:5a1c:0:b0:4ca:98ec:7d9a with SMTP id q28-20020ac25a1c000000b004ca98ec7d9amr550426lfn.15.1681370159616; Thu, 13 Apr 2023 00:15:59 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations Date: Thu, 13 Apr 2023 09:14:23 +0200 Message-Id: <20230413071424.3273490-22-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a comments with a list of unsupported FF-A interfaces and limitations in the implemented FF-A interfaces. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 0948cc636871..6424c222c885 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -13,6 +13,38 @@ * https://developer.arm.com/documentation/den0077/e * TEEC-1.0C: TEE Client API Specification version 1.0c available at * https://globalplatform.org/specs-library/tee-client-api-specification/ + * + * Notes on the the current implementstion. + * + * Unsupported FF-A interfaces: + * o FFA_MSG_POLL and FFA_MSG_SEND - deprecated in FF-A-1.1-REL0 + * o FFA_MEM_RETRIEVE_* - Used when sharing memory from an SP to a VM + * o FFA_MEM_DONATE_* and FFA_MEM_LEND_* - Used when tranferring ownership + * or access of a memory readion + * o FFA_MSG_SEND2 and FFA_MSG_WAIT - Used for indirect messaging + * o FFA_MSG_YIELD + * o FFA_INTERRUPT - Used to report preemption + * o FFA_RUN + * + * Limitations in the implemented FF-A interfaces: + * o FFA_RXTX_MAP_*: + * - Maps at most 32 4k pages large RX and TX buffers + * - RT/TX buffers must be normal RAM + * - Doesn't support forwarding this call on behalf of an endpoint + * o FFA_MEM_SHARE_*: only supports sharing + * - from a VM to an SP + * - with one borrower + * - with the memory transaction descriptor in the RX/TX buffer + * - normal memory + * - at most 512 kB large memory regions + * - at most 32 shared memory regions per guest + * o FFA_MSG_SEND_DIRECT_REQ: + * - only supported from a VM to an SP + * + * There are some large locked sections with ffa_tx_buffer_lock and + * ffa_rx_buffer_lock. Especially the ffa_tx_buffer_lock spinlock used + * around share_shm() is a very large locked section which can let one VM + * affect another VM. */ #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:16:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:16:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520494.808231 (Exim 4.92) (envelope-from ) id 1pmrCJ-0002XJ-NV; Thu, 13 Apr 2023 07:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520494.808231; Thu, 13 Apr 2023 07:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCJ-0002Wq-KH; Thu, 13 Apr 2023 07:16:47 +0000 Received: by outflank-mailman (input) for mailman id 520494; Thu, 13 Apr 2023 07:16:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCH-0001wd-6d for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:16:45 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09e05e9c-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:58 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id d7so28946978lfj.3 for ; Thu, 13 Apr 2023 00:15:58 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09e05e9c-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370158; x=1683962158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=++rL2jsxUxRm5qFt5hBWNof5SzDBga+okTGdWBhdlBo=; b=G5BbTYqiSbzMXxtdyqd2Z8QovoHQoRitdheZIo/ph2u7styw58M7tIX9aUo0jRbZFp zGvyFwY5WjAOQYSNp+zNKFDZslgxwH8Lrry6Ewjw2bQtihPWJ0LOzaeimXOkRzQN8XIn NhXJv0joRONF4I0cwS0T/K4akUweFtNe+1pdDxb4UoJvRmegZJ9YsskTQSWX8bkDcqC1 zqlqgI6+Mg0sNyiiFX2fYEmDi92IeVwfn/xpM0wzGVRWyWDZ9KTdMu6YKN5C+RuhV/7u ikBjLgVB0pWQ53RJ60asijR6aOIpv2Dxw1agHIajNs5KmbXD/6UNc4qAD3KlpLlGulBc Enbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370158; x=1683962158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=++rL2jsxUxRm5qFt5hBWNof5SzDBga+okTGdWBhdlBo=; b=ht8X1T3lsuaOx8UN+mUAUJSyALWq/66Ms8iuS6SeDsqJ1EaFl6KVs+jKVjVnEFEFSF EMFEX51HvMn7UbKmdQm7NycfXE9Y1lbRyCx5BxP0fndnyMyjpG9Obo93xu9/puCBQCHy ro6Zxl3BbwHLal4tkh9FURp0KjMOXs5zM+LvP2owGduDuwqUb5KRr7dfjMDWPLj1pBkV fdcQ3OSRk/+gYAl8P/z0GgfEkxPiTbe/Toj+URA2FSRbXmWFuxI+1R/DI1nX3D2DZLBn CW/CFg8n4h9QfhyBeHLcOXpHNWsOCeN045DEmZJdjJYnLqj6jgW273q4/+TD9OqjTda1 cCew== X-Gm-Message-State: AAQBX9dfxtTWSW7ghvwT4Xv0CEkOq8e0uQGtJdyJU+1YObIIQoFKv/4I 1Cs5WX34ZuzxgbWP2Ws9tr3nJFGhQHB2GShU0hA= X-Google-Smtp-Source: AKy350bJBmtxrb0v4lr9dv4qiCmPEngcbPR6AmM3VYhlPBzTM5TLdZGlcVcxTV9g4xHfF2f26ISMCg== X-Received: by 2002:ac2:4195:0:b0:4e1:8309:1db5 with SMTP id z21-20020ac24195000000b004e183091db5mr505672lfh.2.1681370158063; Thu, 13 Apr 2023 00:15:58 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 19/22] xen/arm: ffa: support sharing large memory ranges Date: Thu, 13 Apr 2023 09:14:21 +0200 Message-Id: <20230413071424.3273490-20-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for sharing large memory ranges transmitted in fragments using FFA_MEM_FRAG_TX. The implementation is the bare minimum to be able to communicate with OP-TEE running as an SPMC at S-EL1. Adds a check that the SP supports the needed FF-A feature FFA_MEM_FRAG_TX. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 253 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 240 insertions(+), 13 deletions(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 47ff899eca32..888e3f9265c2 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -356,6 +356,8 @@ struct ffa_ctx { /* FF-A version used by the guest */ uint32_t guest_vers; bool rx_is_free; + /* Currently used fragment states, struct mem_frag_state */ + struct list_head frag_list; /* Used shared memory objects, struct ffa_shm_mem */ struct list_head shm_list; /* Number of allocated shared memory object */ @@ -372,6 +374,18 @@ struct ffa_shm_mem { struct page_info *pages[]; }; +struct mem_frag_state { + struct list_head list; + struct ffa_shm_mem *shm; + uint32_t range_count; + unsigned int current_page_idx; + unsigned int frag_offset; + unsigned int range_offset; + const uint8_t *buf; + unsigned int buf_size; + struct ffa_address_range range; +}; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -535,6 +549,36 @@ static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, } } +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, + uint16_t sender_id) +{ + struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MEM_FRAG_TX, + .a1 = handle & UINT32_MAX, + .a2 = handle >> 32, + .a3 = frag_len, + .a4 = (uint32_t)sender_id << 16, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_ERROR: + if ( resp.a2 ) + return resp.a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + return FFA_RET_OK; + case FFA_MEM_FRAG_RX: + return resp.a3; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + static int32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, uint32_t flags) { @@ -609,6 +653,14 @@ static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); } +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, + uint32_t handle_hi, uint32_t frag_offset, + uint16_t sender_id) +{ + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, + (uint32_t)sender_id << 16, 0, 0, 0); +} + static void handle_version(struct cpu_user_regs *regs) { struct domain *d = current->domain; @@ -977,6 +1029,8 @@ static int share_shm(struct ffa_shm_mem *shm) paddr_t last_pa; unsigned int n; paddr_t pa; + bool first; + int ret; ASSERT(spin_is_locked(&ffa_tx_buffer_lock)); ASSERT(shm->page_count); @@ -1012,13 +1066,23 @@ static int share_shm(struct ffa_shm_mem *shm) tot_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, region_descr->address_range_count); - if ( tot_len > max_frag_len ) - return FFA_RET_NOT_SUPPORTED; + /* + * Sharing memory with secure world may have to be done with multiple + * calls depending on how many address ranges will be needed. If we're + * sharing physically contiguous memory we will only need one range but + * we will also need to deal with the worst case where all physical + * pages are non-contiguous. For the first batch of address ranges we + * call ffa_mem_share() and for all that follows ffa_mem_frag_tx(). + * + * We use frag_len to keep track of how far into the transmit buffer we + * have gone. + */ addr_range = region_descr->address_range_array; frag_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, 1); last_pa = page_to_maddr(shm->pages[0]); init_range(addr_range, last_pa); + first = true; for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) { pa = page_to_maddr(shm->pages[n]); @@ -1028,12 +1092,34 @@ static int share_shm(struct ffa_shm_mem *shm) continue; } - frag_len += sizeof(*addr_range); - addr_range++; + if ( frag_len == max_frag_len ) + { + if ( first ) + { + ret = ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + first = false; + } + else + { + ret = ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); + } + if ( ret <= 0 ) + return ret; + frag_len = sizeof(*addr_range); + addr_range = buf; + } + else + { + frag_len += sizeof(*addr_range); + addr_range++; + } init_range(addr_range, pa); } - return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + if ( first ) + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + else + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); } static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, @@ -1110,8 +1196,53 @@ static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, return 0; } +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int offs, + unsigned int frag_len) +{ + struct domain *d = current->domain; + unsigned int o = offs; + unsigned int l; + int ret; + + if ( frag_len < o ) + return FFA_RET_INVALID_PARAMETERS; + + /* Fill up the first struct ffa_address_range */ + l = min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_offset); + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); + s->range_offset += l; + o += l; + if ( s->range_offset != sizeof(s->range) ) + goto out; + s->range_offset = 0; + + while ( true ) + { + ret = get_shm_pages(d, s->shm, &s->range, 1, s->current_page_idx, + &s->current_page_idx); + if ( ret ) + return ret; + if ( s->range_count == 1 ) + return 0; + s->range_count--; + if ( frag_len - o < sizeof(s->range) ) + break; + memcpy(&s->range, s->buf + o, sizeof(s->range)); + o += sizeof(s->range); + } + + /* Collect any remaining bytes for the next struct ffa_address_range */ + s->range_offset = frag_len - o; + memcpy(&s->range, s->buf + o, frag_len - o); +out: + s->frag_offset += frag_len; + + return s->frag_offset; +} + static void handle_mem_share(struct cpu_user_regs *regs) { + static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; uint32_t tot_len = get_user_reg(regs, 1); uint32_t frag_len = get_user_reg(regs, 2); uint64_t addr = get_user_reg(regs, 3); @@ -1146,13 +1277,6 @@ static void handle_mem_share(struct cpu_user_regs *regs) goto out_set_ret; } - /* We currently only support a single fragment */ - if ( frag_len != tot_len ) - { - ret = FFA_RET_NOT_SUPPORTED; - goto out_set_ret; - } - spin_lock(&ctx->lock); if ( frag_len > ctx->page_count * FFA_PAGE_SIZE ) @@ -1218,6 +1342,36 @@ static void handle_mem_share(struct cpu_user_regs *regs) shm->sender_id = trans.sender_id; shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); + if ( frag_len != tot_len ) + { + struct mem_frag_state *s = xzalloc(struct mem_frag_state); + + if ( !s ) + { + ret = FFA_RET_NO_MEMORY; + goto out; + } + s->shm = shm; + s->range_count = range_count; + s->buf = ctx->tx; + s->buf_size = FFA_RXTX_PAGE_COUNT * FFA_PAGE_SIZE; + ret = add_mem_share_frag(s, sizeof(*region_descr) + region_offs, + frag_len); + if ( ret <= 0 ) + { + xfree(s); + if ( ret < 0 ) + goto out; + } + else + { + shm->handle = next_handle++; + uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); + list_add_tail(&s->list, &ctx->frag_list); + } + goto out_unlock; + } + /* * Check that the Composite memory region descriptor fits. */ @@ -1256,7 +1410,75 @@ out_unlock: spin_unlock(&ctx->lock); out_set_ret: - if ( ret == 0) + if ( ret > 0 ) + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.sender_id); + else if ( ret == 0) + set_regs_success(regs, handle_lo, handle_hi); + else + set_regs_error(regs, ret); +} + +static struct mem_frag_state *find_frag_state(struct ffa_ctx *ctx, + uint64_t handle) +{ + struct mem_frag_state *s; + + list_for_each_entry(s, &ctx->frag_list, list) + if ( s->shm->handle == handle ) + return s; + + return NULL; +} + +static void handle_mem_frag_tx(struct cpu_user_regs *regs) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + uint32_t frag_len = get_user_reg(regs, 3); + uint32_t handle_lo = get_user_reg(regs, 1); + uint32_t handle_hi = get_user_reg(regs, 2); + uint64_t handle = regpair_to_uint64(handle_hi, handle_lo); + struct mem_frag_state *s; + uint16_t sender_id = 0; + int ret; + + spin_lock(&ctx->lock); + s = find_frag_state(ctx, handle); + if ( !s ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + sender_id = s->shm->sender_id; + + if ( frag_len > s->buf_size ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_free_s; + } + + ret = add_mem_share_frag(s, 0, frag_len); + if ( ret < 0 ) + goto out_free_s; + + /* Note that share_shm() uses our tx buffer */ + spin_lock(&ffa_tx_buffer_lock); + ret = share_shm(s->shm); + spin_unlock(&ffa_tx_buffer_lock); + if ( ret < 0 ) + goto out_free_s; + list_add_tail(&s->shm->list, &ctx->shm_list); +out_free_s: + if ( ret < 0 ) + free_ffa_shm_mem(ctx, s->shm); + list_del(&s->list); + xfree(s); +out: + spin_unlock(&ctx->lock); + + if ( ret > 0 ) + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id); + else if ( ret == 0) set_regs_success(regs, handle_lo, handle_hi); else set_regs_error(regs, ret); @@ -1369,6 +1591,9 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) else set_regs_success(regs, 0, 0); return true; + case FFA_MEM_FRAG_TX: + handle_mem_frag_tx(regs); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -1410,6 +1635,7 @@ static int ffa_domain_init(struct domain *d) } } + INIT_LIST_HEAD(&ctx->frag_list); INIT_LIST_HEAD(&ctx->shm_list); d->arch.tee = ctx; @@ -1586,6 +1812,7 @@ static bool ffa_probe(void) !check_mandatory_feature(FFA_MEM_SHARE_64) || !check_mandatory_feature(FFA_RXTX_UNMAP) || !check_mandatory_feature(FFA_MEM_SHARE_32) || + !check_mandatory_feature(FFA_MEM_FRAG_TX) || !check_mandatory_feature(FFA_MEM_RECLAIM) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:19:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520509.808241 (Exim 4.92) (envelope-from ) id 1pmrET-0004My-FX; Thu, 13 Apr 2023 07:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520509.808241; Thu, 13 Apr 2023 07:19:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrET-0004Mr-9g; Thu, 13 Apr 2023 07:19:01 +0000 Received: by outflank-mailman (input) for mailman id 520509; Thu, 13 Apr 2023 07:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrCP-0001wd-7V for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:16:53 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a5cc3e4-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:59 +0200 (CEST) Received: by mail-lj1-x229.google.com with SMTP id be27so14525387ljb.12 for ; Thu, 13 Apr 2023 00:15:59 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a5cc3e4-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370159; x=1683962159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AWMfdA9HpSiI1qDObUeAHUi8FAHJApSAQ901NaR8YIk=; b=ilktQ26XzJ4n2sJx6Kp+98uQyeKojkT1UGZZHwt26/EHVvDL/hzyJC04WzfdBm51/T 6fgUEBd84Hg2QaI536ykBWPMyBZfVt5TsBpAnT9Wv1U+AW0EUTRQS0LgD3rDPHlvFG/Y tzaqt0zLmnJh8bA2Z9LpITJo9QM4jABS4faREWjii9jhPmOThPvq3WayjcFNe+ojnS6a F8QfR8cpV1SZ98n3JXp7rZNlIAQM+gt6rI73g4rF8potof+/3zSt+2dN63aEKWn2R6la I6fl3OVBz2U1k9nVbtvB56KLRVTKKmcQeWH8UIuMYUmgizyS/EFCYnDEXM44ETXUwFn1 zgKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370159; x=1683962159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AWMfdA9HpSiI1qDObUeAHUi8FAHJApSAQ901NaR8YIk=; b=aQc23mOcNzsVfdD6dQeZQx14Zo40Xg2Cw+M3P3116UJ6bAApB27wF5zJ+j5InxQsvg oJIWM0qsSrDZFquTqRYUg+onYBXX1nWIjM+qyxsfRVKqIkv81N4mpzGZFY234tLs7ImG TEzKxK2lWlXgOh6YqGbDy7wBnzZBDeiLCKgoktBsj8lZ9azBKnenPnrtek3i/AfM10vm o30jVXCLGB8PGN4b7xXQc5k63OmxuHGuM0fXrUHWBVyz2GoHc7EwjwX+nnHFR6+v5mhO FIsqEV9aUwwn1XPcx3Z1Zx8vWZ1dPf3dHXkXJsLr+xqYAc0TKa6ElMHuAovc3bM7QHqj V7sg== X-Gm-Message-State: AAQBX9cZ8F3SbssddMKOWQvl9lFz55C+aRdapomv/32EIGbm39yjHe0C oPRkMLNFqGfevmUVdAFssNkwycKfDX3tpTmzm0A= X-Google-Smtp-Source: AKy350bGmfrrRvHIGr0xu/AMw2wt+/mtPTeA7AKRuu86fhugHg801zDTzTHURvTo0DZpwjgCsXPKsw== X-Received: by 2002:a2e:9d4d:0:b0:2a6:1960:4367 with SMTP id y13-20020a2e9d4d000000b002a619604367mr481467ljj.8.1681370158883; Thu, 13 Apr 2023 00:15:58 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 20/22] xen/arm: ffa: improve lock granularity Date: Thu, 13 Apr 2023 09:14:22 +0200 Message-Id: <20230413071424.3273490-21-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The single lock in struct ffa_ctx is complemented with rx_lock and tx_lock. The old lock is used for small critical sections, like increasing shm_count or adding another shm to shm_list. rx_lock and tx_lock are only acquired using spin_trylock() which for well-behaving guests should always succeed. Guests using the RX and TX buffers are expected to serialize accesses before doing the FF-A request. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 124 ++++++++++++++++++++++++++++++----------- 1 file changed, 91 insertions(+), 33 deletions(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 888e3f9265c2..0948cc636871 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -362,6 +362,13 @@ struct ffa_ctx { struct list_head shm_list; /* Number of allocated shared memory object */ unsigned int shm_count; + /* + * tx_lock is used to serialize access to tx + * rx_lock is used to serialize access to rx + * lock is used for the rest in this struct + */ + spinlock_t tx_lock; + spinlock_t rx_lock; spinlock_t lock; }; @@ -796,7 +803,9 @@ static int32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, if ( !ffa_rx ) return FFA_RET_DENIED; - spin_lock(&ctx->lock); + if ( !spin_trylock(&ctx->rx_lock) ) + return FFA_RET_BUSY; + if ( !ctx->page_count || !ctx->rx_is_free ) goto out; spin_lock(&ffa_rx_buffer_lock); @@ -847,7 +856,7 @@ out_rx_release: out_rx_buf_unlock: spin_unlock(&ffa_rx_buffer_lock); out: - spin_unlock(&ctx->lock); + spin_unlock(&ctx->rx_lock); return ret; } @@ -858,13 +867,15 @@ static int32_t handle_rx_release(void) struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.tee; - spin_lock(&ctx->lock); + if ( !spin_trylock(&ctx->rx_lock) ) + return FFA_RET_BUSY; + if ( !ctx->page_count || ctx->rx_is_free ) goto out; ret = FFA_RET_OK; ctx->rx_is_free = true; out: - spin_unlock(&ctx->lock); + spin_unlock(&ctx->rx_lock); return ret; } @@ -973,30 +984,52 @@ static void put_shm_pages(struct ffa_shm_mem *shm) } } +static bool inc_ctx_shm_count(struct ffa_ctx *ctx) +{ + bool ret = true; + + spin_lock(&ctx->lock); + if (ctx->shm_count >= FFA_MAX_SHM_COUNT) + ret = false; + else + ctx->shm_count++; + spin_unlock(&ctx->lock); + + return ret; +} + +static void dec_ctx_shm_count(struct ffa_ctx *ctx) +{ + spin_lock(&ctx->lock); + ASSERT(ctx->shm_count > 0); + ctx->shm_count--; + spin_unlock(&ctx->lock); +} + static struct ffa_shm_mem *alloc_ffa_shm_mem(struct ffa_ctx *ctx, unsigned int page_count) { struct ffa_shm_mem *shm; - if ( page_count >= FFA_MAX_SHM_PAGE_COUNT || - ctx->shm_count >= FFA_MAX_SHM_COUNT ) + if ( page_count >= FFA_MAX_SHM_PAGE_COUNT ) + return NULL; + if ( !inc_ctx_shm_count(ctx) ) return NULL; shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); if ( shm ) - { - ctx->shm_count++; shm->page_count = page_count; - } + else + dec_ctx_shm_count(ctx); return shm; } static void free_ffa_shm_mem(struct ffa_ctx *ctx, struct ffa_shm_mem *shm) { - if ( shm ) { - ASSERT(ctx->shm_count > 0); - ctx->shm_count--; + if ( shm ) + { + dec_ctx_shm_count(ctx); put_shm_pages(shm); xfree(shm); } @@ -1277,7 +1310,11 @@ static void handle_mem_share(struct cpu_user_regs *regs) goto out_set_ret; } - spin_lock(&ctx->lock); + if ( !spin_trylock(&ctx->tx_lock) ) + { + ret = FFA_RET_BUSY; + goto out_set_ret; + } if ( frag_len > ctx->page_count * FFA_PAGE_SIZE ) goto out_unlock; @@ -1399,7 +1436,9 @@ static void handle_mem_share(struct cpu_user_regs *regs) if ( ret ) goto out; + spin_lock(&ctx->lock); list_add_tail(&shm->list, &ctx->shm_list); + spin_unlock(&ctx->lock); uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); @@ -1407,7 +1446,7 @@ out: if ( ret ) free_ffa_shm_mem(ctx, shm); out_unlock: - spin_unlock(&ctx->lock); + spin_unlock(&ctx->tx_lock); out_set_ret: if ( ret > 0 ) @@ -1442,7 +1481,12 @@ static void handle_mem_frag_tx(struct cpu_user_regs *regs) uint16_t sender_id = 0; int ret; - spin_lock(&ctx->lock); + if ( !spin_trylock(&ctx->tx_lock) ) + { + ret = FFA_RET_BUSY; + goto out_set_ret; + } + s = find_frag_state(ctx, handle); if ( !s ) { @@ -1467,15 +1511,20 @@ static void handle_mem_frag_tx(struct cpu_user_regs *regs) spin_unlock(&ffa_tx_buffer_lock); if ( ret < 0 ) goto out_free_s; + + spin_lock(&ctx->lock); list_add_tail(&s->shm->list, &ctx->shm_list); + spin_unlock(&ctx->lock); + out_free_s: if ( ret < 0 ) free_ffa_shm_mem(ctx, s->shm); list_del(&s->list); xfree(s); out: - spin_unlock(&ctx->lock); + spin_unlock(&ctx->tx_lock); +out_set_ret: if ( ret > 0 ) set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id); else if ( ret == 0) @@ -1484,6 +1533,18 @@ out: set_regs_error(regs, ret); } +/* Must only be called with ctx->lock held */ +static struct ffa_shm_mem *find_shm_mem(struct ffa_ctx *ctx, uint64_t handle) +{ + struct ffa_shm_mem *shm; + + list_for_each_entry(shm, &ctx->shm_list, list) + if ( shm->handle == handle ) + return shm; + + return NULL; +} + static int handle_mem_reclaim(uint64_t handle, uint32_t flags) { struct domain *d = current->domain; @@ -1494,29 +1555,26 @@ static int handle_mem_reclaim(uint64_t handle, uint32_t flags) int ret; spin_lock(&ctx->lock); - list_for_each_entry(shm, &ctx->shm_list, list) - { - if ( shm->handle == handle ) - goto found_it; - } - shm = NULL; - ret = FFA_RET_INVALID_PARAMETERS; - goto out; -found_it: + shm = find_shm_mem(ctx, handle); + if ( shm ) + list_del(&shm->list); + spin_unlock(&ctx->lock); + if ( !shm ) + return FFA_RET_INVALID_PARAMETERS; uint64_to_regpair(&handle_hi, &handle_lo, handle); ret = ffa_mem_reclaim(handle_lo, handle_hi, flags); + if ( ret ) { - shm = NULL; - goto out; + spin_lock(&ctx->lock); + list_add_tail(&shm->list, &ctx->shm_list); + spin_unlock(&ctx->lock); + } + else + { + free_ffa_shm_mem(ctx, shm); } - - list_del(&shm->list); - -out: - free_ffa_shm_mem(ctx, shm); - spin_unlock(&ctx->lock); return ret; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:19:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520513.808251 (Exim 4.92) (envelope-from ) id 1pmrEU-0004d6-Nr; Thu, 13 Apr 2023 07:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520513.808251; Thu, 13 Apr 2023 07:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrEU-0004cl-Io; Thu, 13 Apr 2023 07:19:02 +0000 Received: by outflank-mailman (input) for mailman id 520513; Thu, 13 Apr 2023 07:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBT-0001gq-Qa for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:55 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07a336ea-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:54 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id z8so19679568lfb.12 for ; Thu, 13 Apr 2023 00:15:54 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07a336ea-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370154; x=1683962154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OTVH9FKVgFMYmzPdlzuBZ/KTps+v6zvJIPz4zAQrzVk=; b=qhns4ayM4yU9XmaqWG8lePkqfyjARvlK8qOXmAnt7exl47vJPlIG7GOkizIDKe85cr 87B0Z17dFrb952cUnI1MkOTr/HHEqF3hVUvroNHzidG61Ks6lKtj7GDQlyTuvrTKkNQP e94BO3L+xfeNkOIHfEVkAGp9SUDdTSmPkLHxjHeXfbEzjy9iGpqbR4hIEXEv85aO0zva Yv2chyl12UQxsl7Po0tVJd6H1bWn5s8M0qdNZjN6bjNMhyLF3FvmtPn4cLkoogsZmKSD 1Bdt0EZLdxHxx0SkwX1NMR3eRhr6mmmoLS6mby0jvNPUYCa3m35mzaBLDzmSPImhrATt cQ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370154; x=1683962154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OTVH9FKVgFMYmzPdlzuBZ/KTps+v6zvJIPz4zAQrzVk=; b=WLvMSN6h0a0jcAzxXgayxQWZdgcXLJdCSnTV7SYabHcqltDfmTgyMoaLDWTdfenSne nXPQ2sPpriK2ftciTOE9oCS9feEaATJzPYeCrWguFwiznjQ9Mv4Gl7hkx0hkq+f58JnJ 5cn7skFunvEGzGlhuKJjJolLdRD8j3qoH+lxt4/AjddOyXlZh69D/ER4tugqQ1BkJaP2 OYm2CSiWGZwT1Syvb3ksBCXxr0gV74iNdw7vtVnP3Sk0svZ+eWEQgxI8AX/f2E2v38uP FyDrKYZBDt+Nt27DXdRrcuztJWwmm8N7we1D656jr27H5PdmgDepa632BEwzpcYM0pDF P4/w== X-Gm-Message-State: AAQBX9e69hFDvBwEi+xQR8nlwrKixceYRfzoLGKR+hxMeowWKJIHrrdx h19aV6mq3ZRSgrgcjVBAOEyPLSvdKI5uu12GT4k= X-Google-Smtp-Source: AKy350az7dkINsL9Mv2dlGn6+WRY2SwA1BjsfL4s8/eqQ95rDG24jwsgOfVPQduKpoGhhcELdoJTTg== X-Received: by 2002:ac2:592a:0:b0:4eb:3021:3a8f with SMTP id v10-20020ac2592a000000b004eb30213a8fmr580571lfi.61.1681370154377; Thu, 13 Apr 2023 00:15:54 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel Subject: [XEN PATCH v8 14/22] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h Date: Thu, 13 Apr 2023 09:14:16 +0200 Message-Id: <20230413071424.3273490-15-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Moves the two helper functions regpair_to_uint64() and uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm specific regs.h. This enables reuse of these functions in the FF-A mediator in a subsequent patch. Signed-off-by: Jens Wiklander Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/arch/arm/include/asm/regs.h | 12 ++++++++++++ xen/arch/arm/tee/optee.c | 11 ----------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/include/asm/regs.h b/xen/arch/arm/include/asm/regs.h index 0693a681315f..aa39e83ee5f4 100644 --- a/xen/arch/arm/include/asm/regs.h +++ b/xen/arch/arm/include/asm/regs.h @@ -60,6 +60,18 @@ static inline bool guest_mode(const struct cpu_user_regs *r) register_t get_user_reg(struct cpu_user_regs *regs, int reg); void set_user_reg(struct cpu_user_regs *regs, int reg, register_t val); +static inline uint64_t regpair_to_uint64(register_t reg0, register_t reg1) +{ + return ((uint64_t)reg0 << 32) | (uint32_t)reg1; +} + +static inline void uint64_to_regpair(register_t *reg0, register_t *reg1, + uint64_t val) +{ + *reg0 = val >> 32; + *reg1 = (uint32_t)val; +} + #endif #endif /* __ARM_REGS_H__ */ diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 9cb9f16d43cb..47027ecef47c 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -268,17 +268,6 @@ static int optee_domain_init(struct domain *d) return 0; } -static uint64_t regpair_to_uint64(register_t reg0, register_t reg1) -{ - return ((uint64_t)reg0 << 32) | (uint32_t)reg1; -} - -static void uint64_to_regpair(register_t *reg0, register_t *reg1, uint64_t val) -{ - *reg0 = val >> 32; - *reg1 = (uint32_t)val; -} - static struct page_info *get_domain_ram_page(gfn_t gfn) { struct page_info *page; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:19:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:19:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520534.808261 (Exim 4.92) (envelope-from ) id 1pmrEr-0005YW-W9; Thu, 13 Apr 2023 07:19:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520534.808261; Thu, 13 Apr 2023 07:19:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrEr-0005YN-Sd; Thu, 13 Apr 2023 07:19:25 +0000 Received: by outflank-mailman (input) for mailman id 520534; Thu, 13 Apr 2023 07:19:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrBU-0001gq-Qo for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 07:15:56 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0823b4e8-d9cb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 09:15:55 +0200 (CEST) Received: by mail-lf1-x129.google.com with SMTP id m4so17676305lfj.13 for ; Thu, 13 Apr 2023 00:15:55 -0700 (PDT) Received: from rayden.urgonet (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n12-20020ac2490c000000b004dc83d04840sm181354lfi.79.2023.04.13.00.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:15:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0823b4e8-d9cb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681370155; x=1683962155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8pVvJSmvEUbWoR8Cd3hbfPcIyCeeGauP1BW/rZN5S8A=; b=RNWnGeHLfTdsBTj5l1au/ZPEzs0NX4KpVVgZq3rrBHb2zkglV7qAy9hipsYphVje+K d8xDdthy83lot7BtgNvicD6dVPsyZFv7bg5MfTvH9A/EvuRxYRSPf5cnzSNaoyNd+Ylk iHTl8GiMQMGMGebCKZLMZ4qngMBiz4NsjkI8S4XopdD6xnPyig/tQbPOiOX/nnBapHx8 OnIsHydBrAUiGBbHOQ8Zp/hRcjqOHrEUUcX+7iNSe2E6eXa62GOEW90XldApCFVbLNXg X4YRtzOG8vPcnbNCViNmn6nuFuPARWZ5OE7gCPtLS4rmMXXDPjzpigisTYTFJ37b7pLU LWBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370155; x=1683962155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8pVvJSmvEUbWoR8Cd3hbfPcIyCeeGauP1BW/rZN5S8A=; b=gQlRvEv77admM5hxR8ltLqdI9yn6hoHo7K9k8VH3ErrAtm0H4qHra68q4+zuBxL6dx MMxmaw3Ji90lXG85dpkNajKaDJgj5rMUd+g9f6wPjprZPzYq89rkZWoqDliHW8sM9tX/ l5EH6LtXzD/C+ztYfcT74/GOO9Y9j0VrKIrFBZBlfC4riNRWu14+lxJALbMu+U8c/jy1 WHwA9/LpQrhKvcPwi3YfBs91OaQNVLokQGkcEA9br1uQncv2lat6YBlwfOCqgUKLg9nI racTcAxa4+rm6x9wz6z7A9Nz2FChIYkI/aFjqSrA1HtLkFGIairCgAUZHJtzW6OKTGv4 17qg== X-Gm-Message-State: AAQBX9cDwrzhNsigzQJlDPZqhD02aL0o+5KR8flpVZ7Ot+AcqAug4+5f iAawriKTq+YrGyPySZNl4+n1+K8wS31LB5Zbmy8= X-Google-Smtp-Source: AKy350aISGmyJtT6PnyRYtke2nmyaEfxDFKxQorAbQ5fkpsNjHgfVnvRPhyT/3byMsJ8NdgcOkumvA== X-Received: by 2002:ac2:5296:0:b0:4eb:11c:f83 with SMTP id q22-20020ac25296000000b004eb011c0f83mr599448lfm.49.1681370155064; Thu, 13 Apr 2023 00:15:55 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v8 15/22] xen/arm: ffa: add defines for sharing memory Date: Thu, 13 Apr 2023 09:14:17 +0200 Message-Id: <20230413071424.3273490-16-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413071424.3273490-1-jens.wiklander@linaro.org> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds defines needed for sharing using the function FFA_MEM_SHARE and friends. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 60 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 74b8c517afb8..58c581c8ffc7 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -5,6 +5,14 @@ * Arm Firmware Framework for ARMv8-A (FF-A) mediator * * Copyright (C) 2023 Linaro Limited + * + * References: + * FF-A-1.0-REL: FF-A specification version 1.0 available at + * https://developer.arm.com/documentation/den0077/a + * FF-A-1.1-REL0: FF-A specification version 1.1 available at + * https://developer.arm.com/documentation/den0077/e + * TEEC-1.0C: TEE Client API Specification version 1.0c available at + * https://globalplatform.org/specs-library/tee-client-api-specification/ */ #include @@ -80,6 +88,58 @@ */ #define FFA_MAX_RXTX_PAGE_COUNT 32 +/* + * Limit for shared buffer size. Please note that this define limits + * number of pages. But user buffer can be not aligned to a page + * boundary. So it is possible that user would not be able to share + * exactly FFA_MAX_SHM_BUFFER_PG * FFA_PAGE_SIZE bytes. + * + * FF-A doesn't have any direct requirments on GlobalPlatform or vice + * versa, but an implementation can very well use FF-A in order to provide + * a GlobalPlatform interface on top. + * + * Global Platform specification for TEE requires that any TEE + * implementation should allow to share buffers with size of at least + * 512KB, defined in TEEC-1.0C page 24, Table 4-1, + * TEEC_CONFIG_SHAREDMEM_MAX_SIZE. + * Due to align issue mentioned above, we need to increase this + * value with one. + */ +#define FFA_MAX_SHM_PAGE_COUNT (SZ_512K / FFA_PAGE_SIZE + 1) + +/* + * Limits the number of shared buffers that guest can have at once. This + * is to prevent case, when guests tricks XEN into exhausting its own + * memory by allocating many small buffers. This value has been chosen + * arbitrary. + */ +#define FFA_MAX_SHM_COUNT 32 + +/* FF-A-1.1-REL0 section 10.9.2 Memory region handle, page 167 */ +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL + +/* + * Memory attributes: Normal memory, Write-Back cacheable, Inner shareable + * Defined in FF-A-1.1-REL0 Table 10.18 at page 175. + */ +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU +/* + * Memory access permissions: Read-write + * Defined in FF-A-1.1-REL0 Table 10.15 at page 168. + */ +#define FFA_MEM_ACC_RW 0x2U + +/* FF-A-1.1-REL0 section 10.11.4 Flags usage, page 184-187 */ +/* Clear memory before mapping in receiver */ +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) +/* Relayer may time slice this operation */ +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) +/* Clear memory after receiver relinquishes it */ +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) +/* Share memory transaction */ +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) + /* * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: * BIT(31): Framework or partition message -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 07:29:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 07:29:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520547.808271 (Exim 4.92) (envelope-from ) id 1pmrOC-0007La-V5; Thu, 13 Apr 2023 07:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520547.808271; Thu, 13 Apr 2023 07:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrOC-0007LT-QI; Thu, 13 Apr 2023 07:29:04 +0000 Received: by outflank-mailman (input) for mailman id 520547; Thu, 13 Apr 2023 07:29:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrOC-0007LJ-1N; Thu, 13 Apr 2023 07:29:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrOB-0002So-Sf; Thu, 13 Apr 2023 07:29:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrOB-0007Jg-AZ; Thu, 13 Apr 2023 07:29:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmrOB-0007Sy-A9; Thu, 13 Apr 2023 07:29:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Uv7ypzs0/6mNaD/KTbc1L7eBNl1ONLFO4trSnEXMadI=; b=zEtUQ9lbjVAGPPe5FwuZV17nXO vxDPVS3LWWI0bdJKHRUX5RqbT9r/OVhBtHMwzgzusbpqkrpGx2VIK0vDi+6J2MNKlKCT+gg9djluj zKvFn1Yx/8rY31z7np73Ithj4bhPrSPCXAgHyHFUepxKt1OKHSd6DrlH22TDu+mf7AZw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180222: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking linux-linus:build-arm64-pvops:hosts-allocate:starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=0bcc4025550403ae28d2984bddacafbca0a2f112 X-Osstest-Versions-That: linux=e62252bc55b6d4eddc6c2bdbf95a448180d6a08d From: osstest service owner Date: Thu, 13 Apr 2023 07:29:03 +0000 flight 180222 linux-linus real [real] flight 180228 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180222/ http://logs.test-lab.xenproject.org/osstest/logs/180228/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 180208 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180228-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180208 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180208 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180208 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180208 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180208 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl 1 build-check(1) starved n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-arm64-arm64-examine 1 build-check(1) starved n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved n/a build-arm64-pvops 2 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 0bcc4025550403ae28d2984bddacafbca0a2f112 baseline version: linux e62252bc55b6d4eddc6c2bdbf95a448180d6a08d Last test of basis 180208 2023-04-11 19:10:17 Z 1 days Testing same since 180222 2023-04-12 16:43:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Howells Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops starved build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine starved test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 0bcc4025550403ae28d2984bddacafbca0a2f112 Author: David Howells Date: Wed Apr 12 13:18:57 2023 +0100 netfs: Fix netfs_extract_iter_to_sg() for ITER_UBUF/IOVEC Fix netfs_extract_iter_to_sg() for ITER_UBUF and ITER_IOVEC to set the size of the page to the part of the page extracted, not the remaining amount of data in the extracted page array at that point. This doesn't yet affect anything as cifs, the only current user, only passes in non-user-backed iterators. Fixes: 018584697533 ("netfs: Add a function to extract an iterator into a scatterlist") Signed-off-by: David Howells Reviewed-by: Jeff Layton Cc: Steve French Cc: Shyam Prasad N Cc: Rohith Surabattula Signed-off-by: Linus Torvalds From xen-devel-bounces@lists.xenproject.org Thu Apr 13 08:00:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 08:00:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520566.808281 (Exim 4.92) (envelope-from ) id 1pmrs3-0002XB-Dj; Thu, 13 Apr 2023 07:59:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520566.808281; Thu, 13 Apr 2023 07:59:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrs3-0002X4-B3; Thu, 13 Apr 2023 07:59:55 +0000 Received: by outflank-mailman (input) for mailman id 520566; Thu, 13 Apr 2023 07:59:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrs2-0002Wu-13; Thu, 13 Apr 2023 07:59:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrs1-0003Dl-VC; Thu, 13 Apr 2023 07:59:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmrs1-0001Cd-H8; Thu, 13 Apr 2023 07:59:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmrs1-0000Ag-Gj; Thu, 13 Apr 2023 07:59:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zO1qOIfB3F3Pz5XhwVLrj13qfFYpX86DZpPKCSyHt1Q=; b=y8zAy49bG6j2Css7PBMka6uamt pYfn5EQ23IkvGEGgmqn6K5oPolbiX03ywSLwvtZV/aQulMg04OMwK+NVNATaHZ7qOXDj3ApIb6CRV Az7v8rayV7TGIugHSw74g/MdGDz7upq6sENZaT+tKq63qVKox1Zu8HoG+UcnGbLi7SRs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180229: all pass - PUSHED X-Osstest-Versions-This: ovmf=42b0443599a69c703034079cf2bd389fa3a6bfde X-Osstest-Versions-That: ovmf=5430f7f60dee3747fff906b48718db8afb4589d9 From: osstest service owner Date: Thu, 13 Apr 2023 07:59:53 +0000 flight 180229 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180229/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 42b0443599a69c703034079cf2bd389fa3a6bfde baseline version: ovmf 5430f7f60dee3747fff906b48718db8afb4589d9 Last test of basis 180223 2023-04-12 19:43:57 Z 0 days Testing same since 180229 2023-04-13 06:12:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Sam Kaynor jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5430f7f60d..42b0443599 42b0443599a69c703034079cf2bd389fa3a6bfde -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Apr 13 09:10:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 09:10:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520574.808291 (Exim 4.92) (envelope-from ) id 1pmsyA-0002fQ-Vg; Thu, 13 Apr 2023 09:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520574.808291; Thu, 13 Apr 2023 09:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmsyA-0002fJ-RS; Thu, 13 Apr 2023 09:10:18 +0000 Received: by outflank-mailman (input) for mailman id 520574; Thu, 13 Apr 2023 09:10:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmsy9-0002f7-Rl for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 09:10:17 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01591ccf-d9db-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 11:10:16 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id xi5so35699109ejb.13 for ; Thu, 13 Apr 2023 02:10:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01591ccf-d9db-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681377016; x=1683969016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Do4v+4gSZeDj6LuHJ8qdjlM3TTHlOiF+w4OATSLeFHM=; b=wGEP9wcTBajPafFO4L3RzrwQHHWrL+ZU6umu2uZGYSrXLPRSkdnGU1d65GUly6zZRq eT5qK00lxgi99YdAnBIOcG/PH83oNEnVkA0xsIOQS+EswUmmr2F+lluejQirkr9aF6N4 2VDk+Fsz2QFbCWmSmlXB0hYER+MXHNCtOZSolffaY2IJ9owFQPuWjt+cfjsDpAJ6MEmC lDlrwyZRtVlkmzOEey5kzjgRgOvUj2wQmWeMy6SyFISVS3qd3YcTRCKgDC79OMf7GZ1T S3btuB1ODhmxglf2hpZTVM0MzrYorI2jz7bT8HxaSgYjbXpV79K4SG50b3eyTs1JKthu TcQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681377016; x=1683969016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Do4v+4gSZeDj6LuHJ8qdjlM3TTHlOiF+w4OATSLeFHM=; b=FsdrJvOiKGc/B1buCEauEbEfrjjSgCHI+QtHc8xppLmzWZM+ZfuHRIMzMy0kW3IlvG YaGgp1RJ4fTdXKDxMhG/0pEhhR7MaHFwpHVrod2dzJKTOGp4+saFICUTCzpfb/Qa2uwf nsKRAPvIUhDASsAQMz1p8Xcsd36UzusoBw7JO/+t1fk13npN7rlLYHqcdFHdF6VIwRax 4LmywohRk/2KUD2BOTKRM+Gb3ZPj8cgjAAR4D3wKzdbf+rDh43Vb1ARx7vqcuMNHlcrd ZiXUh5sHoRIJYN1oo1NPDZnuumpqNBkbpyBob7bevhH/dF8j914uUCQulFF5atX0Lgh5 Cdtw== X-Gm-Message-State: AAQBX9daLbb7JlEK9IAsS/8W5rbdCcaam7sPqRV+AWGo12Fa5Lq4vN3t WiG7g3YJXT41x29UYr0WYJDCBx8wZFJg5xGikboEbw== X-Google-Smtp-Source: AKy350byjrmiwhEHWnHNrUEegIDr5idiF0lEE4xD/k/48btffTUnjrwf7orRfE/QIRyTnbVQIaHIDqnClr3J21bxCL0= X-Received: by 2002:a17:906:3c52:b0:94e:5c27:dc5f with SMTP id i18-20020a1709063c5200b0094e5c27dc5fmr883617ejg.6.1681377015834; Thu, 13 Apr 2023 02:10:15 -0700 (PDT) MIME-Version: 1.0 References: <20230412185102.441523-1-dwmw2@infradead.org> In-Reply-To: From: Peter Maydell Date: Thu, 13 Apr 2023 10:10:04 +0100 Message-ID: Subject: Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes To: David Woodhouse Cc: qemu-devel@nongnu.org, no Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 12 Apr 2023 at 20:01, David Woodhouse wrote: > > On Wed, 2023-04-12 at 19:55 +0100, Peter Maydell wrote: > > On Wed, 12 Apr 2023 at 19:52, David Woodhouse wro= te: > > > > > > Some Coverity fixes and minor cleanups. And most notably, dropping > > > support for Xen libraries older than 4.7.1. > > > > > > I believe there are two issues that remain to be fixed. The x32 build > > > fails, and I've seen patches which attempt to detect x32 and disable > > > the Xen emulation. Along with assertions that we just shouldn't care. > > > I don't have a strong opinion either way but it seems to be in hand. > > > > > > The other is the question of what Xen *actually* does if you try to > > > unmap an IRQ_MSI_EMU PIRQ. I don't think Linux guests try that, and > > > I'm fairly sure Windows doesn't even use MSI=E2=86=92PIRQ mappings in= the > > > first place, and I doubt any other guests care either. I'd like to > > > establish the 'correct' behaviour and implement it, ideally before > > > the 8.0 release, but it's going to take me a few days more. > > > > > > David Woodhouse (5): > > > hw/xen: Simplify emulated Xen platform init > > > hw/xen: Fix memory leak in libxenstore_open() for Xen > > > xen: Drop support for Xen versions below 4.7.1 > > > hw/xen: Fix double-free in xen_console store_con_info() > > > hw/xen: Fix broken check for invalid state in xs_be_open() > > > > > > > This is highly unlikely to make 8.0 at this point, FYI. > > If there's anything in this you think is super-critical we > > might be able to sneak it in. > > Nothing is super-critical except maybe the double-free in > store_con_info(). That could lead to a crash on startup if the QEMU Xen > console is being used. I've cherry-picked that double-free patch to apply for 8.0; thanks. -- PMM From xen-devel-bounces@lists.xenproject.org Thu Apr 13 09:14:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 09:14:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520578.808301 (Exim 4.92) (envelope-from ) id 1pmt1v-0003EB-FN; Thu, 13 Apr 2023 09:14:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520578.808301; Thu, 13 Apr 2023 09:14:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmt1v-0003E4-Bs; Thu, 13 Apr 2023 09:14:11 +0000 Received: by outflank-mailman (input) for mailman id 520578; Thu, 13 Apr 2023 09:14:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmt1u-0003Du-4Z; Thu, 13 Apr 2023 09:14:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmt1u-0005ka-1w; Thu, 13 Apr 2023 09:14:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmt1t-0004DN-P9; Thu, 13 Apr 2023 09:14:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmt1t-0008Gq-OY; Thu, 13 Apr 2023 09:14:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=03mdalFGTVRv2rQnLt0Qmf3ASWvgXlzu0GsEW9bNnSY=; b=mkkbLdJs6R1yqPDEsn5lImKlJ6 5U1JVenjeMQsPj0SAGPgVtDgyQQG1LDqsxCwze1FTnf2QPsts6nbTXWHNJDnzpcx6P6nIjOj6KwyL nqbhPA3i1E9SYzbMpVlaJtmLFC+zl8BVP7cDUwKPq55OZCAcl6hKj9mdnRF6AK9iQjvo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180220: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=abb02ce0e76a8e00026699a863ab2d11d88f56d4 X-Osstest-Versions-That: qemuu=6c50845a9183610cfd4cfffd48dfc704cd340882 From: osstest service owner Date: Thu, 13 Apr 2023 09:14:09 +0000 flight 180220 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180220/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180207 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180207 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 180207 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180207 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180207 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180207 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu abb02ce0e76a8e00026699a863ab2d11d88f56d4 baseline version: qemuu 6c50845a9183610cfd4cfffd48dfc704cd340882 Last test of basis 180207 2023-04-11 18:40:13 Z 1 days Testing same since 180220 2023-04-12 12:10:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kevin Wolf Lukas Tschoke Paolo Bonzini Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6c50845a91..abb02ce0e7 abb02ce0e76a8e00026699a863ab2d11d88f56d4 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Apr 13 09:19:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 09:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520584.808310 (Exim 4.92) (envelope-from ) id 1pmt7G-0003sP-2k; Thu, 13 Apr 2023 09:19:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520584.808310; Thu, 13 Apr 2023 09:19:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmt7F-0003sI-WF; Thu, 13 Apr 2023 09:19:42 +0000 Received: by outflank-mailman (input) for mailman id 520584; Thu, 13 Apr 2023 09:19:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmt7E-0003sB-N6 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 09:19:41 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eab::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4fe6dfb0-d9dc-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 11:19:37 +0200 (CEST) Received: from CY5PR22CA0002.namprd22.prod.outlook.com (2603:10b6:930:16::11) by PH0PR12MB8005.namprd12.prod.outlook.com (2603:10b6:510:26c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Thu, 13 Apr 2023 09:19:33 +0000 Received: from CY4PEPF0000C964.namprd02.prod.outlook.com (2603:10b6:930:16:cafe::77) by CY5PR22CA0002.outlook.office365.com (2603:10b6:930:16::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 09:19:33 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000C964.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Thu, 13 Apr 2023 09:19:33 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 04:19:32 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 04:19:31 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fe6dfb0-d9dc-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j1uJH9teiH/Qn4AgQdU7+QbwJa6CGDjg0581Vn62iJTueGlk3B7l48xh2s2eiR0ppkb2pjNk5z+xA6u3bcIVFUsPzbCEmXczFdbOKAUl5dSz/5Gfw6J1lHGYyEWQ+o6cuopLYcmX7Ie7q9K/CEzKZ8TuzHFn0tYymdmTRJqwG01t+Kp6HdfFsnODlPKlXxK2cXi1wk7C+/CkCSciX5n9ZNST9r4xi9cXfzVaL2qSa3be3CHNjlCdUnIXVrDmicJ0Z9poWY+LZ0O8h2sqtER0+uPIEvFQ+WsVs8dz5o0jDxg+5vX/AsY5kvLGlE4B3R33R+AA/k4VEdUponkRP9Qt7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rhId+4L7TrpgnRGi0eVPN6ygrjDhOuIpBpqxIPPVTL4=; b=nd2K3SWXZpgtIy7biFLI9suKMhmBF9vTKi8w4XOiC5XcRLHCYpnPvId6Z09fmwmeNVj0N1AyLMY7ssVeMdk8t0sPsHqrVp+jH7FbcpXblOFAAttDBhnp74tZ4ioK1s2JeH1Ugh6Lh3H5oikAshS40Pnj9fKrsg2TmQuKgxrcLDx0As0ahkFeZ7Vu/+Z/cC7ScoxXR86tymB7qAuDHQxJj+rEJg0aDXBLurEjzIn79LnmApM3u9ebAp14lq2atBrRxX1ScxHSHkU7XIto2vkQRs3O0xRxC8f7UTeiFkcOsAJgDisMf9jDFpu/18/MluMQKvnhCtI+w+FAQGTgY/cGig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhId+4L7TrpgnRGi0eVPN6ygrjDhOuIpBpqxIPPVTL4=; b=SbAVmjuP69ZYNgwwKurCGP6UasO8sgQIosYJMwLRt+1oflz2teaVqrkMkKjmw6Q6joQ2aF7tf0hdI4IlnF6sVH3fBaX4L4eJp1h3c5o22DTAjUtW1shDRKS/+zMyO3wRbSZz+aEqn6B7QL4ZiWEQvkIvd9Ax1H5WkDseOVZDIjg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <836d2629-b097-9a8e-7aea-3f83fd13228f@amd.com> Date: Thu, 13 Apr 2023 11:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 01/17] xen/arm/device: Remove __init from function type To: Vikram Garhwal , CC: , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-2-vikram.garhwal@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20230411191636.26926-2-vikram.garhwal@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C964:EE_|PH0PR12MB8005:EE_ X-MS-Office365-Filtering-Correlation-Id: d05e48d2-1a3e-4ec6-fce8-08db3c003182 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nkDZdVSaZ8WSAwZiSKeVyOVTy+EDpVyOZDFlNgyHq/NrlZVdHjxUHoo5nl7q8XmrHkcwgofoMSmDy5wB3nQD8khSjGr9FRqlGggHZM+8ca3Z9I/uOykYDbvwXBDv4vdet6ZtJwY/VYs7lceH08fCF6xLIeZJr4MccUG2wgvfg8uNV6agfUg1QUh6m5xdFDYzb/HGGqc2PCeSC3ip72Tp8jBccYMTlW3hGZciyw+Fo9NYAYE7WcEfiBb18ThFFn1zLpE0+7hwm5PIkQS9gdrkaP+Vx4goQtIDU+C0vWdp5z/aEw9IWJ3BRCglhJZNe9PHarL9FCqn70oeU9UDYy3QuoSOk4mt9pLMHlYs9DK/NMGhsa5frQS3n1qc1QrybqXU7+aBtdnXyVFTX11OGnKpHBGBmzlUBr56vDf+lRWSd6j3PwdV84qlPV3rZ4V6yP+VEPLvo0qla0ei61XDBhS/B+IzZC8671Fss3inL4J4+itKDXo2U8jB/Y+Ac0foLwvY45MAToxQ1SWxCZs//vpDtIxAX0yQQHNxBAjKHntyklOyX3CMjjzxdpqhY2kJQmbreotOh90tRqyzwQKnibcEMzXaKFxhtlqj4pAPtkn3Un8wqiiwv3ariQ5yS/JWp4SuTSuCjPO5rZ1gM25uv7bUQfXDNf8IlYZHuxctTJKa5pHOIA0DGNnym4w5LzIMg+cYVCPRdpEI3znGjvi6V/nTtQ02ko0qPIRVOiLFNkd3LsQvHckDS9z5vXlYNZWQGCYKvz1UZ22pRdjYH6SaWEPUUQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199021)(46966006)(40470700004)(36840700001)(31686004)(36860700001)(5660300002)(36756003)(2906002)(44832011)(31696002)(316002)(86362001)(8676002)(8936002)(40480700001)(82310400005)(356005)(70206006)(4326008)(70586007)(81166007)(41300700001)(40460700003)(2616005)(82740400003)(336012)(426003)(83380400001)(47076005)(54906003)(186003)(26005)(110136005)(53546011)(16576012)(478600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 09:19:33.0297 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d05e48d2-1a3e-4ec6-fce8-08db3c003182 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C964.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8005 Hi Vikram, On 11/04/2023 21:16, Vikram Garhwal wrote: > > > Remove __init from following function to access during runtime: > 1. map_irq_to_domain() > 2. handle_device_interrupt() s/interrupt/interrupts/ since there is no handle_device_interrupt() function. > 3. map_range_to_domain() > 4. unflatten_dt_node() > 5. unflatten_device_tree() > > Move map_irq_to_domain() prototype from domain_build.h to setup.h. > > To avoid the breaking the build, following changes are also done: 'avoid breaking' instead of 'avoid the breaking'. > 1. Move map_irq_to_domain(), handle_device_interrupt() and map_range_to_domain() to s/interrupt/interrupts/ > device.c. After removing __init type, these functions are not specific to > domain building, so moving them out of domain_build.c to device.c. > 2. Remove static type from handle_device_interrupt(). > > Overall, these changes are done to support the dynamic programming of a nodes > where an overlay node will be added to fdt and unflattened node will be added to > dt_host. Furthermore, IRQ and mmio mapping will be done for the added node. > > Signed-off-by: Vikram Garhwal > --- > xen/arch/arm/device.c | 145 ++++++++++++++++++++++++ > xen/arch/arm/domain_build.c | 142 ----------------------- > xen/arch/arm/include/asm/domain_build.h | 2 - > xen/arch/arm/include/asm/setup.h | 6 + > xen/common/device_tree.c | 16 +-- > 5 files changed, 159 insertions(+), 152 deletions(-) > > diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c > index ca8539dee5..fec6e29c42 100644 > --- a/xen/arch/arm/device.c > +++ b/xen/arch/arm/device.c > @@ -12,6 +12,9 @@ > #include > #include > #include > +#include > +#include I can't see why do we need to include this header. > +#include You should keep the alphabetical order so: - iocap goes after init.h - setup.h goes after device.h Apart from that, it looks ok so: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Apr 13 09:46:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 09:46:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520589.808320 (Exim 4.92) (envelope-from ) id 1pmtWv-0007P7-6H; Thu, 13 Apr 2023 09:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520589.808320; Thu, 13 Apr 2023 09:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtWv-0007P0-2t; Thu, 13 Apr 2023 09:46:13 +0000 Received: by outflank-mailman (input) for mailman id 520589; Thu, 13 Apr 2023 09:46:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtWt-0007Ou-T9 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 09:46:11 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20624.outbound.protection.outlook.com [2a01:111:f400:fe5b::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03443134-d9e0-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 11:46:08 +0200 (CEST) Received: from MW4PR04CA0115.namprd04.prod.outlook.com (2603:10b6:303:83::30) by MW3PR12MB4588.namprd12.prod.outlook.com (2603:10b6:303:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 09:46:04 +0000 Received: from CO1NAM11FT043.eop-nam11.prod.protection.outlook.com (2603:10b6:303:83:cafe::b8) by MW4PR04CA0115.outlook.office365.com (2603:10b6:303:83::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Thu, 13 Apr 2023 09:46:04 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT043.mail.protection.outlook.com (10.13.174.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 09:46:03 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 04:46:02 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 02:45:57 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 04:45:57 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03443134-d9e0-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrAc0zm+IydeOP9bEwZoAMbbOGokSPSy+fMqeGJToExmQbpzxgzhPZKL8EJEtw3xqA3XzmIdUF8f9A+xnZSihZD7k2qE2EW+WSL/ea34IQDvRmNS81WgxomopV8ebOSQ/GWuZaGs7DHslBrsDKpBbX+jQT2QUNdWUbx2Ar8XcJrFSc6SLRk1Wd1fqReuqNXLKsHQLLz/r3n97GJ1fj+1te6hgu03Wz6nnMyhw8+WeUXUJHEt297g/7/66LKaOQCb8ht2mrzjE71m5DojCtCq6/v9dIemfH++/2Gzs9yT446OU2lbwsPnLy9uP9aWasfiTUvLaJPR6BTsHuGPpCSqPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yBE32qRAmtmPbFr0kHVShrV/37fYMBBmHh6EfBSAWCA=; b=OdtewoJGY/wUSlJ7ePeAf+dEvl0c3iRYJUmcfDcVq9fNXTvEvANuKKDl1wAg4RWS+CdQql3G1DawhpSOpk+xhnbctSiBSo+LEqlq/hauf2JOuwwDgIsjmOg9cO+nWuSnHsaqgXL2oVrGOu8MvOrkOi7yX1fWgn9K/xWls2/MDKEs9XtsDmGRVR+dS1wkFjZXgRbgX4x2526F47NpGzbqpKTNwRCnynJNMqUVipTTfCa5jQ8ED63TGrTYGXNJpQMIzLBwu6lnJ+vxO8Go11B5Jq/DJq739J+8w9sb1xwpFdKsoSNmyONoGV0bF9CyUe+b6S1Aq22HadlYpZn9I3o0sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yBE32qRAmtmPbFr0kHVShrV/37fYMBBmHh6EfBSAWCA=; b=Mm/3/EIfnpaSPE4ed0Bzpb4RMs/1X5SuPTbkRm0gK6EazRAZOoXkFdin7fnCjKlK/Cq8zS0Mfm/JNlWIupE3tZdBggdle57mm4Rv7pTMuO5hSe4G00py50nly68Q2KMDnLO7VWHSutIAphyB7XJMNPN5zfHdz1emgODbqKnFAh4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <3f98a8b0-dea6-4ae4-137a-312e89af879b@amd.com> Date: Thu, 13 Apr 2023 11:45:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Content-Language: en-US To: Vikram Garhwal , CC: , Julien Grall References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-3-vikram.garhwal@amd.com> From: Michal Orzel In-Reply-To: <20230411191636.26926-3-vikram.garhwal@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT043:EE_|MW3PR12MB4588:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e9e7ae2-0701-4a4c-2067-08db3c03e5c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bbeuh9WHfASCepKZohvmeTSMfS1TuhzHoregaTFlt1jKbqnLlqJ6v3nfaGEdrsbQEWcLFlv1HC5CwajTOuhlHNZNFozSAZ7X8VnuvJLxqLmQRjtBQb8EMXnXjjWq1x2i/sgYp6mq8b1uiWthTf3f6aPPtI0p0SEyXuebRb4ckhb9uHY86l/FHphL7sL9lpsqgYWsfhOh4kpzE/P6bAPCujv8BJRePCqeSfik6mMipj6aSLkakL3XTvxB5LFFlQX8eYylkLZl2NaWGmSEDJGLcJzX1soTSlQv+eK8FckCufOOginuDDa4YCuRz8gDWVHI9omuZzYvVMBeKr+MGOGSZwsXcz7yDZ0aj33+1L6ijN2MnY94grltjD/yNoy5Lfk/bHljFfN87DBbrEtkPqznqs1rKeM5iZR+YFid4cyb/BdSZTIC/3f/WJRyOpF9nx+FiLKil6gzoZLGlMBPzsX9T+d9wkvW6Z4pjgRW/UroTrQpWz7NZVpe6qQIpa1rTjk02sPlzjvprUJwP5yv5rxEPoYY0XqN4CQfiLLUgQhsabNpH2TID9A5czB/jWPXAtpfQD3UFItEaQf/nDl1lrr4UoSCP4CuP20rsJRXWdSV0xEyhDZquPjveg4vGCOjSm8H70jcsBwbUZQBGBptSf/RojvVTO6+G4tGWhbqrBI1xjrq2kPOlMu2JecDHppgr9fARU2mK+nUWYNsBA0UUt5eMFjX4r5YSCa2ogTDbATNS62iaGOsztNa+WABY3HRM0twFySxxL/eVBZCdFaIfEkhwg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(46966006)(36840700001)(40470700004)(31686004)(36860700001)(336012)(5660300002)(36756003)(4744005)(2906002)(44832011)(31696002)(316002)(40480700001)(8676002)(8936002)(86362001)(41300700001)(81166007)(356005)(40460700003)(82310400005)(4326008)(82740400003)(70206006)(426003)(70586007)(2616005)(47076005)(54906003)(16576012)(186003)(478600001)(110136005)(26005)(53546011)(6666004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 09:46:03.9317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e9e7ae2-0701-4a4c-2067-08db3c03e5c8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4588 Hi Vikram, On 11/04/2023 21:16, Vikram Garhwal wrote: > > > Following changes are done to __unflatten_device_tree(): > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > 2. Remove static function type. I think there was no need to touch this function in patch 1 if you are modifying it here additionally in a separate patch. > 3. Add handling of memory allocation. This will be useful in dynamic node > programming when we unflatten the dt during runtime memory allocation > can fail. Didn't we say that checking if the memory allocation failed or not should be done as a separate patch (i.e. a prerequisite to your series) as part of hardening? In any case (depending on the maintainers vote), the change itself looks ok, so: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Apr 13 09:54:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 09:54:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520594.808333 (Exim 4.92) (envelope-from ) id 1pmteG-0000Tt-W0; Thu, 13 Apr 2023 09:53:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520594.808333; Thu, 13 Apr 2023 09:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmteG-0000Tm-TO; Thu, 13 Apr 2023 09:53:48 +0000 Received: by outflank-mailman (input) for mailman id 520594; Thu, 13 Apr 2023 09:53:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmteF-0000Tg-VR for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 09:53:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmteF-0006bU-So; Thu, 13 Apr 2023 09:53:47 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmteF-0006bg-Lb; Thu, 13 Apr 2023 09:53:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3TMnKaazw7RkdLGoudNI4e9xwLmqht+031sHO8iWC7s=; b=CUnW6t+sGMVByDDCo4bpqGLBZN mj4xEuar3YKYVTV+Uks8TXvHqSrSe8/BWtTo1SQUnmhe3Zbf4Vx2APUUDNQR7GJOJFlgnhf4ob80F y61AH9urPjtA7/SLBn9+JkTQT+XDmWJVA7EW3XPHGHjjO2NUCGe8yw6S08MvI4c5h/CU=; Message-ID: Date: Thu, 13 Apr 2023 10:53:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Content-Language: en-US To: Michal Orzel , Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-3-vikram.garhwal@amd.com> <3f98a8b0-dea6-4ae4-137a-312e89af879b@amd.com> From: Julien Grall In-Reply-To: <3f98a8b0-dea6-4ae4-137a-312e89af879b@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/04/2023 10:45, Michal Orzel wrote: > On 11/04/2023 21:16, Vikram Garhwal wrote: >> >> >> Following changes are done to __unflatten_device_tree(): >> 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). >> 2. Remove static function type. > I think there was no need to touch this function in patch 1 if you are modifying it here > additionally in a separate patch. > >> 3. Add handling of memory allocation. This will be useful in dynamic node >> programming when we unflatten the dt during runtime memory allocation >> can fail. > Didn't we say that checking if the memory allocation failed or not should be done > as a separate patch (i.e. a prerequisite to your series) as part of hardening? > > In any case (depending on the maintainers vote), the change itself looks ok, so: Yes it should be separate because this is something we may want to consider to backport. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 09:58:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 09:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520598.808344 (Exim 4.92) (envelope-from ) id 1pmtib-00018u-GR; Thu, 13 Apr 2023 09:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520598.808344; Thu, 13 Apr 2023 09:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtib-00018n-Dj; Thu, 13 Apr 2023 09:58:17 +0000 Received: by outflank-mailman (input) for mailman id 520598; Thu, 13 Apr 2023 09:58:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtia-00018h-NY for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 09:58:16 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061a.outbound.protection.outlook.com [2a01:111:f400:7eaa::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b367ec3a-d9e1-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 11:58:13 +0200 (CEST) Received: from BN6PR17CA0038.namprd17.prod.outlook.com (2603:10b6:405:75::27) by MW4PR12MB7440.namprd12.prod.outlook.com (2603:10b6:303:223::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 09:58:10 +0000 Received: from BN8NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:405:75:cafe::29) by BN6PR17CA0038.outlook.office365.com (2603:10b6:405:75::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.33 via Frontend Transport; Thu, 13 Apr 2023 09:58:09 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT078.mail.protection.outlook.com (10.13.176.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 09:58:09 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 04:58:09 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 02:58:08 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 04:58:07 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b367ec3a-d9e1-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AdmCoO3i0uOWdS5tE2iX6csiz103s+ES9/P7W8pL8UVqCVu5MA7+cZ0SeKxVtbguyHRQGByHw5ICRQSgmw4/Ph0RdsoouRs/G7n6cg1+8dgAEoevWzk+9N/ZwMDN+wob372C0XRtFaEYy6sDq6fjYNt7/s84pNQHS0KRwdydkCnW2d0PfGuo6lNqQb9XGEH8KvklEVdVSZO5vkVrkJf6JRX8iTITz/WG9Vcq8LYh3gGOd7SFgpt1EYtVLo5N6Djyalw0CDMDq391Vxaz+/v83+Y7fYCCUiNgsbCrZLtLfqd7gvary2augLNs3VtB1yazeLEczFDXdLI/IqfGCmh5yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s7hXF7uogdRLXdoz4J9okqV8ECVMCAycJUpqZlbPpR0=; b=frUgQpfv5ZZDlnfLjv1Wg4goY2RiR4OKPdFX4WZEim8PoZkKvuBXG9HDZyNV97IwNvpliw5f3mICS0CHp8bwdyMjgAonXjEIg8JhcF3y9hHQmb4MTu5i+k18Tc4Z5Jv8sevBcJ372zddHnFHaUa7Es9TvpDa/Mb8LQ+3we7BQXwephPmhnh7AHCAD23pJjn86TMG2zrnSZkB1RdAd3Q+Sbe4sNsJ2efXLRq3MFjdQxJqwPNPD38Mj6SZjF6XRAW027/aVow1jLnNB2oAuE7kikFmo6/Y9+G7CjoWrx3ayDoZKa3rJklq5uIsplB8Wavrund7rCokHt+xNCh8khjW7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7hXF7uogdRLXdoz4J9okqV8ECVMCAycJUpqZlbPpR0=; b=pyQ+Gcn37YLFnaHc9oeV6toAmVZ9nOB7yCnRy7TqqyD+WZF47xf+JKZgoJuT2nERs0AZVLDuXQKwKj5xVQd//4zWRr6Q9bDbnt/5PM4DPkj5ebnJjJiSfYu54CrwJqFdgWM1QIEZlvLanUHjKnX36a0IPQI0q+zON08Lo9khQnE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 13 Apr 2023 11:58:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 03/17] xen/arm: Add CONFIG_OVERLAY_DTB Content-Language: en-US To: Vikram Garhwal , CC: , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-4-vikram.garhwal@amd.com> From: Michal Orzel In-Reply-To: <20230411191636.26926-4-vikram.garhwal@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT078:EE_|MW4PR12MB7440:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d35228e-0865-42e8-e1f5-08db3c059624 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K6bFRhAp3Jj9muTMjbZRkaGPHRroE40YOyRvmA9QZbqq4sZ7/WBXV3p8mapAUIlRd9sk/eOJWbYclZ5CZkRaa1InDGz4Oxm9SxcD8uw4asILUIQJPyeOGEO+tzG2Rj86J1gbR82iH3DwBaHIUlL1i84Svu6sLk0lbXKIJT2ACHYjDHRI3hfEGzNNSjjJ3Uq+tNZgCszEJFiyj+3MyFRVlka7visOKikbfvjRHhb68deuDW64hmzS/O7Oc27NN8ZTnaAjOsYcHK5plwKzZukx3hw+ECoG8Ts3+JgSMnVp1Q94S8ExeW39QTklvueSuQaXXResbiS0ydPtvW4I+a3kTAuCghI74r5Agk62CqoLZE+l33SMAEpJAuV7E2ZK3Ii9S4OgaPd+VoQTdybT0/UPwTfBzf9kCW2qx8W5O96VC16xRCvKQMCha916XfjtntEMYunGIKloGxUTQPvj6g3HHIUd7uIwIlKJsCp2oaTeV7MtWSYGSgrPR7mmLFouyU/aLwCFBNsCxuwG+WStnqZPM8VVpEFcvvgKZRnStpu1lS4pdh/obmO1uihU2NslTH9nS+Z1XEkmHOqAWMgMkVEPS1iliuh/lXwXaA02MnvkixDTFOf44+XjQOMmBpilKT1XiiXi9fHaQ+2tE40MQVLMgbWg0QSmvMrz2PVPy97v2n6JPdVLoXvXGh05EEF/MV8P2mK27zT87ZbQhOvx5jHx7TWdJ9NTFUbL0n2I9ocgfXrgs36Fw/g8uEEbRWtw/yP47HPMEUUx7DkcL+5KgxtA5w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(2906002)(31686004)(8676002)(70586007)(70206006)(8936002)(5660300002)(44832011)(478600001)(41300700001)(40460700003)(316002)(40480700001)(82740400003)(426003)(336012)(36756003)(16576012)(54906003)(110136005)(4326008)(186003)(86362001)(26005)(81166007)(53546011)(2616005)(36860700001)(82310400005)(356005)(47076005)(31696002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 09:58:09.4091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d35228e-0865-42e8-e1f5-08db3c059624 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7440 Hi Vikram, On 11/04/2023 21:16, Vikram Garhwal wrote: > > > Introduce a config option where the user can enable support for adding/removing > device tree nodes using a device tree binary overlay. > > Signed-off-by: Vikram Garhwal > --- > SUPPORT.md | 6 ++++++ > xen/arch/arm/Kconfig | 5 +++++ > 2 files changed, 11 insertions(+) > > diff --git a/SUPPORT.md b/SUPPORT.md > index aa1940e55f..0a31f40af4 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -822,6 +822,12 @@ No support for QEMU backends in a 16K or 64K domain. > > Status: Supported > > +### Device Tree Overlays > + > +Add/Remove device tree nodes using a device tree overlay binary(.dtbo). > + > + Status: Supported for ARM Hmm, so here you say supported but in Kconfig - unsupported. I think, this should be: Status, ARM: Tech Preview or Experimental > + > ### ARM: Guest ACPI support > > Status: Supported > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 239d3aed3c..1fe3d698a5 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -53,6 +53,11 @@ config HAS_ITS > bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED > depends on GICV3 && !NEW_VGIC && !ARM_32 > > +config OVERLAY_DTB > + bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED > + help > + Dynamic addition/removal of Xen device tree nodes using a dtbo. > + > config HVM > def_bool y > > -- > 2.17.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Thu Apr 13 10:03:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 10:03:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520602.808354 (Exim 4.92) (envelope-from ) id 1pmtnc-0002f6-2H; Thu, 13 Apr 2023 10:03:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520602.808354; Thu, 13 Apr 2023 10:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtnb-0002ez-Va; Thu, 13 Apr 2023 10:03:27 +0000 Received: by outflank-mailman (input) for mailman id 520602; Thu, 13 Apr 2023 10:03:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtna-0002et-VM for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 10:03:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmtna-00072s-RR; Thu, 13 Apr 2023 10:03:26 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmtna-00078e-Iv; Thu, 13 Apr 2023 10:03:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Eheui3wJSAP0Xc1BwIsLqFdWXjNT/C88bEtOr2Jl/Dk=; b=6sNyxDYML5/Rq8oIqxggdsoKjX 2b6OWbV4Z+LpptbSUKOJ+p/sHt8hw2LcmzkOuiZg/GCVVpUOu+wzmxuew2IIbBkbjANHzFP8FBTTC jJlRwCR2Z5KA11kz/bEx9lnlIfhqEuozUyIhgObsaHC06pQfNyWj2RdMr/K8CwxAEQgY=; Message-ID: <869d014a-d325-6592-d51e-e3638ba04076@xen.org> Date: Thu, 13 Apr 2023 11:03:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Content-Language: en-US To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-3-vikram.garhwal@amd.com> From: Julien Grall In-Reply-To: <20230411191636.26926-3-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/04/2023 20:16, Vikram Garhwal wrote: > Following changes are done to __unflatten_device_tree(): > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > 2. Remove static function type. > 3. Add handling of memory allocation. This will be useful in dynamic node > programming when we unflatten the dt during runtime memory allocation > can fail. > > Signed-off-by: Vikram Garhwal > --- > xen/common/device_tree.c | 10 ++++++---- > xen/include/xen/device_tree.h | 5 +++++ > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index aed38ff63c..bf847b2584 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const void *fdt, > } > > /** > - * __unflatten_device_tree - create tree of device_nodes from flat blob > + * unflatten_device_tree - create tree of device_nodes from flat blob > * > * unflattens a device-tree, creating the > * tree of struct device_node. It also fills the "name" and "type" > @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const void *fdt, > * @fdt: The fdt to expand > * @mynodes: The device_node tree created by the call > */ > -static void __unflatten_device_tree(const void *fdt, > - struct dt_device_node **mynodes) > +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) > { > unsigned long start, mem, size; > struct dt_device_node **allnextp = mynodes; > @@ -2079,6 +2078,9 @@ static void __unflatten_device_tree(const void *fdt, > /* Allocate memory for the expanded device tree */ > mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct dt_device_node)); > > + if ( !mem ) > + panic("Cannot allocate memory for unflatten device tree\n"); After your series, unflatten_device_tree() will be called after boot, so we should not unconditionally called panic(). Instead, unflatten_device_tree() should return an error and let the caller decide what to do. I suggest to read misc/xen-error-handling.txt to understand when to use panic()/BUG() & co. For... > + > ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); > > dt_dprintk(" unflattening %lx...\n", mem); > @@ -2179,7 +2181,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) > > void __init dt_unflatten_host_device_tree(void) > { > - __unflatten_device_tree(device_tree_flattened, &dt_host); > + unflatten_device_tree(device_tree_flattened, &dt_host); ... this caller this should be a panic() (this is OK here because it is boot code). But for your new caller, you should properly report the error back the toolstack. Also, unflatten_dt_node() (called by __unflatten_device_tree()) seems to have some failure cases. Can you explain why they are not properly propagated in your case? Are you trusting the device-tree to always be valid? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 10:19:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 10:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520606.808364 (Exim 4.92) (envelope-from ) id 1pmu2O-0004Dn-DQ; Thu, 13 Apr 2023 10:18:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520606.808364; Thu, 13 Apr 2023 10:18:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmu2O-0004Dg-9s; Thu, 13 Apr 2023 10:18:44 +0000 Received: by outflank-mailman (input) for mailman id 520606; Thu, 13 Apr 2023 10:18:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmu2M-0004DW-OP for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 10:18:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7e1a::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d589bed-d9e4-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 12:18:37 +0200 (CEST) Received: from DU2P250CA0001.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::6) by VE1PR08MB5807.eurprd08.prod.outlook.com (2603:10a6:800:1b2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 10:18:30 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::cb) by DU2P250CA0001.outlook.office365.com (2603:10a6:10:231::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 10:18:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 10:18:30 +0000 Received: ("Tessian outbound 3570909035da:v136"); Thu, 13 Apr 2023 10:18:29 +0000 Received: from 97e27bb58b8d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E73DDC16-C863-42D5-AD3D-2BF3107F8604.1; Thu, 13 Apr 2023 10:18:23 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 97e27bb58b8d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 10:18:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB8668.eurprd08.prod.outlook.com (2603:10a6:150:86::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 10:18:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 10:18:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d589bed-d9e4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6DoXTvtCegDEgg3NGPXql67sOC/wpT/TaHEjZ1NZZk=; b=pqY0tFfxs971YjEHXADAgYNLDGpTCffSDI8E9JttbBt/+htE0Xo70eye3mXCZL2E9uQ33y076veCKi7rauioB8Ft2RSMHEVfOFtzusC2xNSbMNl39OzPPW/G8KTXrA2tr17iMlGHUm0hAOBKHc3E2oE9+TGPEnaVAblPKbV6Z4M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 106133614934fda5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gszU1sd8qfw8fsi6mkJtF99lxoBGvOEBdHBSbWipedks+ejGCF2GuKN4MrsSFArQNiAfO2VDniE73lKAxlDC8OCdeEUyJXvuf/W8o/tc+SDkcohhomY57ktYxrS78+8WHxiTcHrxZBvjFrRsfXBk+KLb+AYR/VoR/QR2BXwk1uK2HxcuHGfWjPmSWmryihJFhZSrGZdnrdO2CITNEAv3zoked8CJmdI9wMlAquYDwNKirtMiW3gntH33m+OZcJM4A/l/L3eHvLt+hXLCIePMWd8dfEa1hiF+2wVri1GvQAxNR+lB2gIAyll/3ci0UlXdp/O/LBCIxGP+2CbdcvlpSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6DoXTvtCegDEgg3NGPXql67sOC/wpT/TaHEjZ1NZZk=; b=jMOHpDrlnKVwEQkiRH5nIFkRTJ/KZPvnbJO3FXDJRI+USqj1JGtlI3zqOs5pnSp4dn4fGaDfgcUsFTxx9hzorhv7g3goX4teYtgY8ivLeQitC2ovs8FnvDnRIlN5HAXfng+4H2KND6xvOJnMESoYzb+8LoKUiGmJ8NyRX2/+FOQ8SWER7x/METapMBwYPXE9cNxgnjHZT3ebzXtxtejEn1NOv7jq9BdmNvFh8oRAqpPT0OiD3RM5tcoQJAVKQsOQKWNjG9cAGJNg91mZgWusrkGO5V0ktWwnuYkWROevt5pZ48OitgdjG6B2rHXuHOpf3ET1en73nIfE9hXirJe64Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6DoXTvtCegDEgg3NGPXql67sOC/wpT/TaHEjZ1NZZk=; b=pqY0tFfxs971YjEHXADAgYNLDGpTCffSDI8E9JttbBt/+htE0Xo70eye3mXCZL2E9uQ33y076veCKi7rauioB8Ft2RSMHEVfOFtzusC2xNSbMNl39OzPPW/G8KTXrA2tr17iMlGHUm0hAOBKHc3E2oE9+TGPEnaVAblPKbV6Z4M= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function IDs Thread-Topic: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function IDs Thread-Index: AQHZbdfQvOZjy0avwkmKCeVOj5Eyzq8pBU1w Date: Thu, 13 Apr 2023 10:18:21 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-5-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-5-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7F3587952335594DB45AB22285B60C93.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GV1PR08MB8668:EE_|DBAEUR03FT035:EE_|VE1PR08MB5807:EE_ X-MS-Office365-Filtering-Correlation-Id: 7916772e-a785-44a5-b46c-08db3c086dad x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZUXIWunWcQ/qHWTlj9yh7YSVsZ2Fqhu+iJg4YYpP/XM5B7JTNpFrS5tjEWYIAS6NQzid7DYqtGd3GSYWd8yDfPidDybKlKVhhu2njsQQYNzgNaqE6CbB/sNPtN//lh/xT3RJ3hjgck/rm+EUPYdH0PrZKt3vs1VW5Y7RvVfL6e5h4SCs4vB9Sy+EgI8IJsBxVcthIiVlRoTj5iCEVBhXkQQNO9IxBVtTaAa23J4j004KdK/WVaSf+y5uAKTpVTR65tYKiZGg9gC8h/u2SW33WhbCD+I2UXocphYND7s1p8fdN/B2cX5M0b2vS/iwYsId+C0h1QGeZGjfcS9aOu4RNfhm/UglGnf1Sie+8+Qdly0jYkxat8CxvPJ/gHQylYx+elgSOFPYl6r+AhOoQpZdaueIQ5/otAOncG3bbox1Kw+pPyaPclS1DnNBLhW5CE1eTinukF4kPLjjY1s4iD/qnQbe3VwyHT2jnDD8gWhvi/QlHE5tk1GNndyVUTw/tQRdwyDgQAUqPIHuuRFfGZ/ZlHcWdtmuiODKlCfl2ajkIH8Kvezaq9mdc5VrSCln98M/RGG8eVRYyNaHtOVfNqZUzinS48JXKWqQfbwd6EmAEGbwLIHvAFxt/WNrA1odjZuO X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199021)(71200400001)(478600001)(7696005)(83380400001)(122000001)(55016003)(86362001)(38100700002)(38070700005)(33656002)(2906002)(4744005)(6506007)(26005)(110136005)(316002)(9686003)(54906003)(5660300002)(76116006)(186003)(64756008)(52536014)(4326008)(8676002)(8936002)(41300700001)(66446008)(66476007)(66946007)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8668 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0d26029d-1b20-4376-ee90-08db3c086884 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WlGwhmcYj7EN9Y+J4vh28p8HAqCmT1i8WO/9Au1qn0PI8W+ThYBXk/valbaEyVZ+SVLxSHU5GxHJLXIrIMEXkromi6ExIl661cvgMWKlb0yuvGkPCryqmk+IgFZSOAKzAx5YRXQ6Dywq+0wVR9SjyHdkPjovpijSc7avDmvaruryj7KSUHew14/85PnzM0wGX3/sxnI0ybYZH1vZ2wSbpI1hXnFSCoEqk5tIo59LN+dIPdJaCG93bkdnCYLyK24jOJNDRCKt+oQCtGypQtiGNrNZcv3b5JDa9wIj9SkcsfBjvB3BKLzDvpwTjsh1JTGQhwV7+au3qxvX2+14FOdDqbUVZke62/DGsm/qlObl7jKHswZpQHRy73Dy4lKixcWsFPigXzSgDdnWTSieEy9f1ZQNSjj9PXs2Od32fxYUSx8v57jhYWqk4POeiBIVcMVZ4Om/oHCZGCDFEOb18xMVxCSsvk+rEwnJ0IQlwQvPfNFEHQ+Qe3Nqzpvb/qhkV+5pmTsJLLZRMqodlsNj70SMaiAWpFr0D2989ubmQ22zghUOqYr62GeMuTdCY33wPbFd9YEhaM6w4z+wc4IgRvM5TfwT6HqQUv72IsdPjgi6uHXUADMdvHOBGjyWqZ6l1r8aotowtVGl5/09jwuXpWsR9QTxzmsg2maaCAEtNsPh1Es8LiIBx8naw0Ix0D2ObEUHYOYjl4Mf5T3UNqmbRyZnmQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(36860700001)(70586007)(47076005)(83380400001)(70206006)(6506007)(4326008)(26005)(54906003)(7696005)(478600001)(110136005)(186003)(9686003)(52536014)(2906002)(40460700003)(33656002)(5660300002)(4744005)(316002)(81166007)(356005)(82310400005)(336012)(82740400003)(41300700001)(55016003)(8936002)(86362001)(8676002)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 10:18:30.0562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7916772e-a785-44a5-b46c-08db3c086dad X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5807 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function ID= s >=20 > Adds the remaining SMC function IDs from FF-A 1.1 specification. Nit: I would suggest that in commit message you can mention the documentati= on number you used. During my review of this patch I am using DEN0077A version 1.1 REL0. >=20 > Signed-off-by: Jens Wiklander > Reviewed-by: Bertrand Marquis I also confirm that the macro values introduced by this patch is consistent= with the spec in commit message, hence: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 10:28:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 10:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520611.808374 (Exim 4.92) (envelope-from ) id 1pmuCD-0005m2-DT; Thu, 13 Apr 2023 10:28:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520611.808374; Thu, 13 Apr 2023 10:28:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuCD-0005lv-AN; Thu, 13 Apr 2023 10:28:53 +0000 Received: by outflank-mailman (input) for mailman id 520611; Thu, 13 Apr 2023 10:28:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuCC-0005lp-Br for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 10:28:52 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20600.outbound.protection.outlook.com [2a01:111:f400:7eaf::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa81314e-d9e5-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 12:28:49 +0200 (CEST) Received: from AS9PR04CA0122.eurprd04.prod.outlook.com (2603:10a6:20b:531::24) by PR3PR08MB5707.eurprd08.prod.outlook.com (2603:10a6:102:8b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Thu, 13 Apr 2023 10:28:47 +0000 Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:531:cafe::5a) by AS9PR04CA0122.outlook.office365.com (2603:10a6:20b:531::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 10:28:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Thu, 13 Apr 2023 10:28:46 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Thu, 13 Apr 2023 10:28:46 +0000 Received: from bf118fd0be95.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 90881DDF-AD1E-45BE-A0AB-ACE3A38CCFDF.1; Thu, 13 Apr 2023 10:28:35 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf118fd0be95.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 10:28:35 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAWPR08MB10044.eurprd08.prod.outlook.com (2603:10a6:102:362::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 10:28:32 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 10:28:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa81314e-d9e5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTfLyCN+fkRfuN0F3YonH3ulHsbdCoNdxmseEkV5p6E=; b=bd5muEGq3UdxCmY/IWmF9TfpwTbEjqSmccp9NQoBt/Fqw86ThqIaZe/fUrTdejZ1dOC5kJt6B/IrCNFtbJ300aZU05A6J5MJFxSApvDQ3HXjv2wR7IEWmk4ZkYos6L/a6fMlPLZBlfINfPP994QOSnE54aFQIZrYplpEO45pgpY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 105883896882219a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aBja5EV1Q3CTT/efdWDogIBK6SaDsLAbdrCmamMZe2fgqUTkKMu0f9B0SK3TQGOK3Tz9LOnv1XlaeJx6nBRkL3msT7cl1k69JKbW/kp45zrTM/JOlflMuY7la8etghUF54RUM6JlMqwBSN652b6h9Rvq1C0q+srmnygOqyqrMnEI64kMpwfCGQ0tLqIVZ5nrHelkcpKKi4CVyakkkc2CTuW+8I2TtlFUpVPXNxzspz/rU6Pvs5bV4/cPFDOUw6KgdXIymwn7mp6o49Zk6ylMEL1++G6aeYNYcbJ3QNcPCEbutnhj1cIVUH0LvuSDqydoPAkG6bZpl7Ru/30zCrVV8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PTfLyCN+fkRfuN0F3YonH3ulHsbdCoNdxmseEkV5p6E=; b=GPA/1yNFI1ELc89KaibtrPykCdwRGpk93P+yxemHrBRxKMptvEDWa8FVKXPDK25bGkTb9zQE23VgRzO5YojChvPPfvodIdQOMR5VD7qlQVTzUn4/mub1YLh63ZKZKn+yJmKfbFZ4X/8Kr7qJcJBkaFiCv9ctNkD43KAkLGFeQI8A1YuzD/8ALFNOfq/pHQ7nHNzVbjCQkl4QRwwGH2zjUJBwQ8268CSfgXiM2718P3aRMEwhI/3pRU0Pg1KZ5xPae6Ezp273pyRV1b/Y0zGNW/Rb5mY8rBJ/CnJTa93QJhiPZGg0iajk7hWcGNilgLrXhGdTzX80C7FgGm7Zo2Z7sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTfLyCN+fkRfuN0F3YonH3ulHsbdCoNdxmseEkV5p6E=; b=bd5muEGq3UdxCmY/IWmF9TfpwTbEjqSmccp9NQoBt/Fqw86ThqIaZe/fUrTdejZ1dOC5kJt6B/IrCNFtbJ300aZU05A6J5MJFxSApvDQ3HXjv2wR7IEWmk4ZkYos6L/a6fMlPLZBlfINfPP994QOSnE54aFQIZrYplpEO45pgpY= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Thread-Topic: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Thread-Index: AQHZbdfQYdI+Ke10g0y9D6f6Y8dBZq8pCBXg Date: Thu, 13 Apr 2023 10:28:32 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-6-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-6-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4F5B102125D24D46A420CEEA92276860.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAWPR08MB10044:EE_|AM7EUR03FT009:EE_|PR3PR08MB5707:EE_ X-MS-Office365-Filtering-Correlation-Id: dc55f43e-70ae-40f5-edd3-08db3c09dd49 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GDdBHOUZRu7x/LLEd4YfEe2DZ+8KECTFA+y5bnxNNcJpkg/tCcnmBn+U8XPBYCaM8PMQibVAz3OcK7b9lClHipd0WFaCwBw77zFTZ0aPEXzojBn3VNatnxoCEHjlWMc01cb4UxALtTQuEcHI6E98JJeuVarDJAqhYdrC8ARAkNiZNjuMLLiFu7ppSvUAgAX1CFowFHFQoJj4JwLZjhk4dcFnvBB2zKnhjkmhO6jwWMFOuEJPynacT1A9viiK+dS2uznz82E7mSa6l9Cof6NvVV2u1LjKbtsTUFTxfucOdwPyYaYQI/tXog9zW+uP4+ruOIhRtVxOCErBEKsEedk+kgC56NQSafwRvbXJnQtumuRf4Yxa3LToYihxzEnvBc7y0Ib7khE7MxSetk2o2R0IkmsKv6r9xO/8Iu/02lmGUWCc9rUA2ZjtlpvCKl75sjJ1sx/WcCxBm63glcGlWWIFBMQxgFSIpI5zKcuIRFoYgiL/3NUfEAqd3SGypbncT7VFh/Lz8StYRwC+zUUXXpSSNSVhFwcQZLnDOYWwgs3lsR41+pAdLH7LtkKw9zMuxsmPayRebKPys96t3rCBI6TzINYcc7f20zupyTk3gWzD+4YI7WhExkZNAaPLvRRG8TwW X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199021)(478600001)(64756008)(66446008)(52536014)(55016003)(38070700005)(5660300002)(4326008)(2906002)(76116006)(66946007)(66476007)(66556008)(41300700001)(8936002)(8676002)(122000001)(33656002)(186003)(9686003)(38100700002)(316002)(26005)(110136005)(6506007)(86362001)(54906003)(83380400001)(71200400001)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10044 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 26ec4f1e-5931-4834-ead8-08db3c09d487 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBQH98YUjfG0JLRLMXE0oXCYH6cVisRA5/tij5Gsay+u4IicDe/cqdyOgONF24jH/FfTSeLHP+teON7nS03q321BWNO8yVuEZHLfrBWz5xaqk4MghcHhL6oLGmL3gCL0D6c13yInLJeZh/7H+CJ3mgY/wrI9Fr0BoCY+Xph+3VtyECKyDLHOu+8NezQs9R5TqyrW7yQ6PampSH1ZZv3kACrh0WHES7mgHNBmvxRGEdxNEp1krpPp5Kb42AtJSXich+fJgdV0Ujlnbwa+O7F0teHPc25s0SyFVOW4b+8f+R2Mwm4Sj2k/cop4C+oChg37HOCgt61pCdNmSvUt9Ti3gakt4gNUJXyHAL/RlA9eZc6l/tT+JvxMDpoD+F1ySdhyI+Ni7NK+oeewZjUbnhmNxLRWyQyIrONXfwkuZS/dBtqLZCUYDjTMyCHkfQDH7ATujqr2q5GKOhvQ+W+ClrWY/hy0HyTTc2uTcB6QGRYq87OUY1X0Ts003uoc/o48WsvYYRC/mZO7wUDEL2XdNeDLWhIOwyEiSQsO1o+fPYO6S4rrD97GF8O9/mCqXUrWXMzzsR/nMUdddwkouyAfWE8WXrByO/DJlzCGTwuthgLkOV349GLHZcAeTng13n8+KQvdmNAtnWraiu8JOvFK4CNI23eyjV6dVIf+M3BK+u/am8psSvH+eIuNqgQvnC6EevrT5ZmRICospuFvWwB0NAimHw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(136003)(346002)(451199021)(36840700001)(40470700004)(46966006)(54906003)(36860700001)(83380400001)(478600001)(55016003)(7696005)(40480700001)(6506007)(9686003)(26005)(70586007)(70206006)(316002)(82740400003)(110136005)(4326008)(47076005)(336012)(186003)(5660300002)(52536014)(8676002)(8936002)(356005)(40460700003)(2906002)(81166007)(41300700001)(86362001)(33656002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 10:28:46.7414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc55f43e-70ae-40f5-edd3-08db3c09dd49 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5707 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for > FFA_PARTITION_INFO_GET >=20 > Defines flags used for the function FFA_PARTITION_INFO_GET. Nit: Similarly as my comment for patch #4, I would suggest that in commit message you can mention the documentation number and the chapter of FFA_PARTITION_INFO_GET. Something like: "According to DEN0077A version 1.1 REL0, section 13.8, defines flags used for the function FFA_PARTITION_INFO_GET" >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index ba0942e76993..72e7d0575de5 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -57,6 +57,40 @@ > #define FFA_MY_VERSION > MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > FFA_MY_VERSION_MINOR) >=20 > +/* > + * Flags to determine partition properties in FFA_PARTITION_INFO_GET > return > + * message: > + * BIT(0): Supports receipt of direct requests > + * BIT(1): Can send direct requests > + * BIT(2): Can send and receive indirect messages > + * BIT(3): Supports receipt of notifications > + * BIT(4-5): Partition ID is a PE endpoint ID > + * BIT(6): Partition must be informed about each VM that is created by > + * the Hypervisor > + * BIT(7): Partition must be informed about each VM that is destroyed by > + * the Hypervisor > + * BIT(8): Partition runs in the AArch64 execution state else AArch32 > + * execution state > + */ > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > +#define FFA_PART_PROP_IS_MASK (3U << 4) I am a bit confused here, here (3U<<4) is "IS_MASK" but... > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) ...here the same value is used for "IS_AUX_ID". According to the spec that I referred to, bit[5:4] has the following encoding: b'11: Partition ID is an auxiliary ID. Hence I guess the above "IS_MASK" should be removed? I confirm the values of other fields are consistent with the spec. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 10:37:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 10:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520615.808384 (Exim 4.92) (envelope-from ) id 1pmuK7-0007GK-8X; Thu, 13 Apr 2023 10:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520615.808384; Thu, 13 Apr 2023 10:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuK7-0007GD-3q; Thu, 13 Apr 2023 10:37:03 +0000 Received: by outflank-mailman (input) for mailman id 520615; Thu, 13 Apr 2023 10:37:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuK5-0007G7-CR for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 10:37:01 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d74c1fc-d9e7-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 12:36:59 +0200 (CEST) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Apr 2023 06:36:52 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6379.namprd03.prod.outlook.com (2603:10b6:303:11e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 10:36:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Thu, 13 Apr 2023 10:36:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d74c1fc-d9e7-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681382219; h=message-id:date:to:from:subject: content-transfer-encoding:mime-version; bh=7o/zoZvLpO8iuKHhAUnS6ufHTV8O/4SsFt5DFoyrqSQ=; b=cuZtoDiBPD/C6Mr/fg+RYjdBW5OCH4e/vH+wCtTwmcsCdtbdxUI3ZAmD 50TFbsP+BhshWaQfYQdrbiQuQ7L9OzYQMcCKjGk11bGK4aIm352unvY3y nlDQzfIRax5Y4s7dNo8MHhAsxSfxhzTdznSYBD0j45auR41Jb2vkcQPJf A=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 107797070 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:CNjO6qh5LFp06etRCUYABjj4X161eREKZh0ujC45NGQN5FlHY01je htvUGyBbvzeMDHxf98nPYzg9B4B7J7QztY2SlRorXw2Fn8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT4AaFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ/KSpUVS2dxNv10ZCHYbFOiMU5b9bkadZ3VnFIlVk1DN4AaLWaG+Dgw4Ad2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMpluG1bbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXnqa812ALLroAVID4XUFiwhfC6s2mvY9lCN m87/jArrKdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQo3 FKUm9LiBRR0raaYD3ma89+pQSiaPCEUKSoIY3ACRA5cu937+thr01TIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPuZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:As6Zz6Dg2SuPnnjlHelc55DYdb4zR+YMi2TDt3oddfU1SL3+qy nKpp4mPHDP5wr5NEtPpTnEAtjifZq+z+8Q3WByB9eftWDd0QPFEGgh1/qB/9SJIUbDH4VmpM JdmsZFaeEZDTJB/LrHCAvTKade/DFQmprY+9s3zB1WPHBXg7kL1XYeNu4CeHcGPjWvA/ACZe Ohz/sCnRWMU1INYP+2A3EUNtKz2uEixPrdEGY77wdM0nj0sQ+V X-Talos-CUID: =?us-ascii?q?9a23=3AHm4iHmi2SjAjHmPxnOlLFg/c4jJuVXzHlUztPQy?= =?us-ascii?q?BSndLdJbNa1GR4uB7nJ87?= X-Talos-MUID: =?us-ascii?q?9a23=3A7ik9xg43h/+X20ed/bdGHWYpxoxL4qGtA2QEkqw?= =?us-ascii?q?hqvGPKDFTFDOHiTW4F9o=3D?= X-IronPort-AV: E=Sophos;i="5.98,341,1673931600"; d="scan'208";a="107797070" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CTZg9dXvjL/Z6Tcrj4hKJP4JyLXxfahnJtEpspXDa2/VpCsAOrP1fRP8mAKbbBQ/o3Eye79UJyNgUeNjCPFj0f/71SbtEst6OAVKrV72IkbVWMv89PCieAtJAd0Klgy/1XsuD+g53T6n8HqoCYSpHpE4EHoz2ALwoYaiK9Q0ZPhbA9SonZoDGjGINmpOKeV48p81cFusB2zl77Ss07HLVgbBxCJzG+JB+AP4vrRZblYQO+jIcFhACNV6Tq7vzExFWBR0nxtKKzccVI17KVgZZW3IH6R/XL1jmkBW3K6kLA3wVdTdPWSIjHJIoohSYy9HwACa/E51evSfhTG27J4Qlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7o/zoZvLpO8iuKHhAUnS6ufHTV8O/4SsFt5DFoyrqSQ=; b=PqmLiHYU84Mu/fSyO7zp0qiXoT71mTog7RWgIWhrH7G3iHCTkgRlGI6X8iO4wDhKRv0onzz3I5QGbvM6w45aYOXCdhimZ6NiXAzeTSBuzyCsHVuVyUnQSHhcMqj3k6wkePcqEklZ90qpXZpcbUtZVSzMLdbDabhsRkcuWApeYV8vH1Kw7AZQesON9nb7qj0g0HlFcCze3jpCOJdzDJObZlQyNXK2lPKQ1ka/22v+Kb4TVYSCT6AZdx0nLddSYGZ+tg8XB2k+T2/ZuFyT64eBqP8ON0JQb6/CQhtYImayXcl8ftFFzDeH1k6nBc2iJ8JPdKVgcb/GgTsalvq8/tLKww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7o/zoZvLpO8iuKHhAUnS6ufHTV8O/4SsFt5DFoyrqSQ=; b=nXNsAPQWnPjWQrBHxWAchQ/jX+mn6v8eRChjlWvLlsf5lcASpUWS0a805oSI8m5y5k8kvp/6PTcmecJ2DULP/8RAdyT+0gn7aB/nKncmQCBLjEI0R3q3vnnwcfy4T3brQuio6FYF/68TSP8dAVsxna3FsrFLBJwUAMibxHuFvS0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <19944c81-8dd4-6c89-0fa0-f4837648c7d5@citrix.com> Date: Thu, 13 Apr 2023 11:36:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-GB To: xen-devel , Jan Beulich , Anthony PERARD From: Andrew Cooper Subject: Parallel build regression in the emulator harness Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW4PR03MB6379:EE_ X-MS-Office365-Filtering-Correlation-Id: 5536b235-eee8-476d-a8ac-08db3c0afc55 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ekTbf1YQIlGn2o9xdOCYCH+G5xyPE7zMId2NkTYLsfJfabXUeA40IMER5iL4xuy0O11QalS4SOqPmm0umXY6N7Yf//sw5+NTuuQ3HFLUXYpx1MdxpDVMUKviky/sVlTODRToNdPo/cKkdS8df5IAO9j1pgbUnrYsLZby7jEfTGcmUn8J+LiQ9Y2wq/Ih+aX9a7wlhUnXJYFJc71E+ckGATIWz40Hps9LEi5iQTakCYl4YbQi6saTLcmI86Xxv/dQZQ9VQQGJrskrbepnst516AITuSFw6bbGRSjDxxiD38QKHYhhg4npUSbD6rquZyPkuK+sk0JWfX/e+D+Yrgnbfn9hOQfNqtyAzmgi+nnfPZ189seRQnBQ/g6V9x00z3oEMuy8qAuYD61Us8zMfoyl4UfS0eBlBDnzCyJPksRkmmCq9+O8x2qNNDeJg7UQQ0C6MsV29L+hJMERGYWrEuBJHTESQjpeqb+8sUJhU/3vJPk/XHS6ab4ZRbcMN6zFxFnJ0Xn02cKT8//Y396S1DeQuxVQY2eN6ySfb4uVOHhxtINq8NKZx315I0z0pNhGh2j8Tk0HwxAOgmTr238+4A7JwVo9N0l8bf0OuatUXoRg4JW+Ni/SwMgEZ7o0/CbV923B/ztuKSSn+4TCnYitnKdT7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199021)(6512007)(110136005)(966005)(316002)(6636002)(66946007)(66476007)(66556008)(5660300002)(478600001)(8936002)(6666004)(6486002)(8676002)(41300700001)(82960400001)(4744005)(2906002)(36756003)(86362001)(31696002)(38100700002)(2616005)(26005)(186003)(6506007)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDdDQ09wcWdGQ1FxclVqMkc2djJzTEUvQjlhMGI0VVBwREZGUmgzZlJ4amh2?= =?utf-8?B?Y2Y0WVorRHh4b0NOTVY3S3VaamVUb29zUGhxbUlRVlh1QVJQNXoyLzFWenBZ?= =?utf-8?B?STJiMzNrakNEVFZaN0FyN2tVbTFHb3dSa29pWENxVlg4WkxZbUJLN01ISktz?= =?utf-8?B?T3ZrbFN0a3lOMnJ0SExwVVNrM210SjYxT3JWbzFZNUYrZTRxRFpUZkowOVlJ?= =?utf-8?B?MW03eGdlVHBseGozWmpUVTJBaHpxZ1M0WktsRmRMc3ZaRlhOVUpEWVU2MVFa?= =?utf-8?B?Q1dCUGRhWEZ3YU1TeFVvc09wWXZGR2lPcnVEV1JzN1Z2eHlqTTcrNkVRbFp0?= =?utf-8?B?cEpnNEt1SjFLVE9JclNGUnp1djRITGU3Wk84UWdrSG1MYit3aTRwL3lYWUg3?= =?utf-8?B?TGFEQStSZVN5MnI5TUZ1WHlpL1dGaTRBazh6Tmp6MkxLK2lXcFZVTGExR3Qz?= =?utf-8?B?cjhtRk9FeUMrNGJHb29Rd1BteDNiWkU3amd3MGFSZWZ2QWFMZ2lKQWdQVEtI?= =?utf-8?B?SHlLQmJseXUvT2p6emR4MXVCZ1JHZGhUdG1rdWplWkJVa0M4QjYxZWJwdkN6?= =?utf-8?B?M3llNk5zanRya0ZtVXNDcjcwSWErek44TW41RzBSZ3JzMlRnREo5ak8xVCth?= =?utf-8?B?VWVVSWJuY3NNejlVM1dJSU5kTkZvaEd0R2cxZ09Xek5qQkJPNGRnbk1zOUJh?= =?utf-8?B?Y3lUQnViYU5oTmZWZlFaNzd3SkRWMzAwemQ2VEdPUVd0cjBjbTZMSUczUGty?= =?utf-8?B?aWU0dmk4STJyRFlBOTlVTEN3QmswdVUrSHJFY1phL21EUkx2aHNKQWFQWHl3?= =?utf-8?B?Wm0vN0g1MzRjR3VLRkdHM2ZCNFFSZm9iUHB4OHpxWHFDZHVrT0NNWXZlVTBl?= =?utf-8?B?Y1hPSHN4a0lTUzVtbm9rU1pEZVFvWk5ZcTV3TEt3dnBjYjJGcGdRN25TME5O?= =?utf-8?B?R3lPam80YzIrZlZYS3JXaGxyRHdjeWI0anZmMXpnYnA2cUVkcUxPV3MyK1lw?= =?utf-8?B?MXN0ZHliUUd6VjVJTm9TTUhmdnZrdWpsTGlZQ01IZWs3SGZtbDZsOTgrZGxl?= =?utf-8?B?eWxxWUVqcUVyVlR0b0V6SEN2OG1IMHlialBXVFR3ME9pTUpFYzV1SDl6NlJY?= =?utf-8?B?MS90YzQyWnpYdWhlSGdpVXVxbE9NUmxxT0c0MENZRnpzbXlDUVZmYndaUGJ5?= =?utf-8?B?ZmN5OFo2THdhdXVrMTk5VFRkcjNLNWoyZExobFNzaE5RbUZibTdaWjFKczR0?= =?utf-8?B?bDgxQjIyLzVpZHFoRDBqQVlHRWZGUVFwZFNTZ0gyZVd5Q09oL01pUDBNVXU3?= =?utf-8?B?Q2lTbFc4RlZhYlI5RUhoanU3Rmh5OGMvS01zaFJEazVzOS9ocWZ2OGw3dmFu?= =?utf-8?B?Z3FqNEJmb2JXYjZCaXVFdlJ6UWNNUWhhTmtUQVVFZmNZVW9XQUo2eWI1aWE0?= =?utf-8?B?b1F3M29Benl3SnJNdXk5Sy9Ra0t0OFVhRDdCeDZhU3hVbksyUFo2VG12Y0pO?= =?utf-8?B?SHBZK1FGc1J6bURKc2U0MUg3SnI5S2NzbUhMeWpiQTNZSlduam1wUE9XZTk5?= =?utf-8?B?Q2FhNkFGcmJSZ1lwdDdJbWM1T0RtV1l5b3ZpbVBUY1N1RW9KeG10alNHemFM?= =?utf-8?B?WndmQ1ZEd0RFUGQ4cjFFN0ZCSW9aWFdYcENTZVd2eWovM291RjdQWW9YdGw4?= =?utf-8?B?OXhXVnR4UUkxK1RYNjlGNjUySGRocWpubktLaExBTk05WStjdXl6dWp2dkU1?= =?utf-8?B?M2NCNllWZitPN1pzTWNaWi90Rjg0VWI5dzdjMjZDek9FR2hoN1VkZE12b09C?= =?utf-8?B?eFBsZ1ZvNWIzSmJiK0JhVFMzN0JJaVo3QkVCOGc5MC9hejc0Ukt0OHhscENM?= =?utf-8?B?a3J4SkZuMXhHaE1UVXlhcGRuWk4weENhc2VIcHR2cHBhUTdHMEZaYTljb2tU?= =?utf-8?B?aFZmOCtTazRtcUhxbHROQXRsWHhBZmpDcU9LT29BazNZU1NOUm5sVjN3ZU5F?= =?utf-8?B?MVZ3WFBKaW16MVYvc0x2MXJpMW9LUkQ3ZGJQOXNUSHRwTSt4MWprR0c2RHI0?= =?utf-8?B?dWpPQzA1OUQ5ay9iTlZwOVk4dTFPbXA3a1BwNmxxV01HMjNRa2JqR3FQU0Iy?= =?utf-8?B?bU5sZjFQVDd0ZUxJNFU5Um5jNW5xOEFsRElqODJOU2J2bzZmYjVzQlNOVmRB?= =?utf-8?B?Z1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: i6EYP9E8dEZ5u06rkJvyrVxNJ9VcEvWL6uEKFw3WkdZ/NniTUHB+F9WVSzMA7JcoHWYHLjIq/KCgWfeM8OEnpKSFu+Oc3/Z7hz65dGsGtrqnouiiVqt9HjGL3GkxyoLhbhb6ylvKIz3MYNlVWymYu8VxxagdIyJlYHU6g5gzFW7oiz0QPjNPxafyo0tVanlbLDfUqOZof4Zoe8YqjXQO51U/6TnOF4kKJ/Dyz7+5dev/awQJvY4EM06RzFysOpAxD6qf+2y5QJx2egaUGRDfz2S4c8CjmYaFuAmSnOe8rMPzpoWOcrBuEfAfNDPBp0U1uuG21fgks/dHQnM2/8wqJFrn3NzRrYERwq5PxavtrUry2IpsrLVtOxZ8QxnuRKdJ2cMsbqOCmZavN7r9HPfcZzBgDzgj7Ec99jlECmhHLpBCpSp8TS1/vvwoy61fnd/ZzWTHTo9sHglOwNcL3kY8Wvp4v/4yL+3RgMYdWXJle4GjNVhYYEiUG7uf/npd628AGvHuqrhwcAB4pGxpjX8OgW7CCIC+0Y0Xn6gcf14nHeo0F+Y10V3yluJv6O7pJN8eslhwFqI9MILZe/mB++wxo2ib8NAQKiMi9M5HMRU1bbFVtBP4tU1kEo8cJznYFO8gfD7KoYhtI6VHGt4rrZMYb6OI6vU0Yewmfqnv9irC+/1LdlVvH5X03P/LCJCoW7qECrKQHa/47cA9iH2YW1DY5LlB59wvsVNLGW/4yd3ojE/c+57vFEyjdPdBuXLRKhmHor/pGWqMXaF5ZgTJB9EV3gu4YG+alvvrsly57+rbmEjaUwlLDYkVJT6/SJojA8y1 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5536b235-eee8-476d-a8ac-08db3c0afc55 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 10:36:48.7503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7JRZ3i7fmIcbKiDce3tV/VC6B5ApEBOYBDUrpxkmTZh7ZfRCNBIXMaJV6GqeJmKIdbKGYEBuq4Ljwc4WFx8itfmmpah24p48bjKzozbflkc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6379 Hi, Gitlab has started very occasionally failing with this: https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4104532296 While the individual log lines appear to be in the right order, the build is clearly failing because compiling decode.o is happening before the x86-emulate.h symlink is properly in place. This will be an error in the recent splitting, but I've not had time to investigate further at this juncture. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 13 10:51:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 10:51:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520619.808395 (Exim 4.92) (envelope-from ) id 1pmuXj-0001Br-HR; Thu, 13 Apr 2023 10:51:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520619.808395; Thu, 13 Apr 2023 10:51:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuXj-0001Bk-Cv; Thu, 13 Apr 2023 10:51:07 +0000 Received: by outflank-mailman (input) for mailman id 520619; Thu, 13 Apr 2023 10:51:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuXi-0001Be-4q for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 10:51:06 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1a::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 156e8975-d9e9-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 12:51:03 +0200 (CEST) Received: from AS4P190CA0036.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d1::7) by VI1PR08MB5358.eurprd08.prod.outlook.com (2603:10a6:803:13c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 10:50:55 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d1:cafe::c) by AS4P190CA0036.outlook.office365.com (2603:10a6:20b:5d1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 10:50:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Thu, 13 Apr 2023 10:50:54 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 13 Apr 2023 10:50:54 +0000 Received: from f5188b42cb7d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 82771DA4-E170-425C-B69C-2443DD83CFF8.1; Thu, 13 Apr 2023 10:50:53 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f5188b42cb7d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 10:50:53 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB6684.eurprd08.prod.outlook.com (2603:10a6:10:26d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 10:50:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 10:50:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 156e8975-d9e9-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnanJ/Xo/U/t2aXUs2oKoot5SwX5CsZYxI13BH5G38U=; b=RY0/SdiOhCAgGL5bYS3RbRcOx+ETNGk6cWGsPbCWOPQzIuvYq0Hwt5CqPhop31cU32JinjiQ+/vtyx7thVctF17w+psqnk0Wzm8D88iiSHYIi9kMSpJ92kbbKgpN0CzrccjDIEN35S+DSBft0roGWeASqxZnnFL4+l8RO9NWiP4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EpyXA0tFxl01egftUCULgvupUKuORwiN3XlYQSxR3tvhO4d5cBZ+6jY9epiMd2uXkgqgkn1LrFjH4SSF4n7GxXoUBBkiIpqC7KBYpXhuVwCL15gkxP+GXKIX6cQOMwQkrOSIBkfpWwQMfC9jkZlQ8QjzP2ibf3AhX4ldJqLuJc3M9lkhQJv0WWfTXaj/KiB7Jw4IaqxCVDTxkwbM3r4iHd9Qga/Aikdyq0DHI9PMqBAU+MVPY/OUeClWh2NT4BOjvZD5nwo28TlHPq8UbyrWgB+//YU1Qsyn+6Uq0B0AVJLsScSDQgg/7ua+D5RhRJk3fMN1UaJME4F7ys+ZgXRNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OnanJ/Xo/U/t2aXUs2oKoot5SwX5CsZYxI13BH5G38U=; b=ishhqhc4c6V/WDdk+F+/QgklHVBUQmc08CaQSoBhRyXtMJjsNGMDvo23aGCmSNA1hR5nvX+u8T0ljS/xZPTMCDk2MniArNtUe8c+CLnYH4BiMzUE46z1uxQEU1jN4hzcPzCl1uBEYhcGm8IhC92j0dchMOek3R1EPyGg05duqmgGHfgoHTHaG9DDtQWdEfxiHmGFxr5KjY06iXnlEvhypgxT5HlDi2OaTjD2RaAvHRgbFI8k/X6vF7n+ZZbucrclLaw7HDc41k6kNCXKVVnYCbGOqqtNwtq/fD9EOq3rPI5ShRza7oy7ytSw6ZFdYKMCcURLq+5h/TzSDDXOC+QbNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnanJ/Xo/U/t2aXUs2oKoot5SwX5CsZYxI13BH5G38U=; b=RY0/SdiOhCAgGL5bYS3RbRcOx+ETNGk6cWGsPbCWOPQzIuvYq0Hwt5CqPhop31cU32JinjiQ+/vtyx7thVctF17w+psqnk0Wzm8D88iiSHYIi9kMSpJ92kbbKgpN0CzrccjDIEN35S+DSBft0roGWeASqxZnnFL4+l8RO9NWiP4= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct request/response messages Thread-Topic: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct request/response messages Thread-Index: AQHZbdfR/bDbMlylSUmzQmA1LCqNwK8pDjBA Date: Thu, 13 Apr 2023 10:50:45 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-7-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-7-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4B458A3ED24A7E44A1401B89678F16FD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB6684:EE_|AM7EUR03FT036:EE_|VI1PR08MB5358:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d253a80-8989-4ac3-7ba4-08db3c0cf4ba x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6LchsenPIN+ocvX2timcV7g7PyjsyfY/29Cum5GMgVABkeKOkWjS5PvdeF62I22HBNnPRHLXoAYwUuBwLVdW9IZXls9rc6E3e6HEMLxdYx2TWWulrlYfsg6558K8rQxvz3mavfA2JE2arfwrQJ8zof51oJebzu1ZH3BZLnUvBy1l6d78Eb12AWsRPpR+l1neAClftTOIENpX3xAM1EZUkSv+ZWRlPZCurFRrZ39WZ3BPBRRgHO2YFIROD5y2bX96PN7Xn40bW734nL4hKokOEJGN1W8DLSr3OxFrqDXrbgywodc/mD9iStA9Zy4+evwvCTRBuzwWfJnlwnDCHGSaKcwSTZtduvS/sAmtZIKrJU5DgJ0sEfwnCBhHAUxGG7sPeuzqO9H3MaRjZLp4W40IZRa5To2cQVy0wZ/LC1+KqY41n7a9CEHzXZ3w9olTXqQ/OHnIyMWA+LPqocFlsolU/70lQNSJin0pMF3rt7gCBFBrdp+SegbvvyH4oAqbuSOO2JQIo8dlfLD4eexqW+hG90oEiO5P5OTK8j+S623BBjr9AtGyfx/Y9vn1mf2vEBqNG7yLSp3u5Q+K+/vtJwMFtf7oq9uMD0uC+RKAD35BC1zD4AXSiHgX29Imc+5F0POt X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(451199021)(33656002)(55016003)(478600001)(54906003)(110136005)(7696005)(71200400001)(122000001)(41300700001)(8676002)(8936002)(38100700002)(66556008)(66946007)(76116006)(66476007)(316002)(64756008)(66446008)(4326008)(83380400001)(6506007)(9686003)(26005)(186003)(86362001)(52536014)(15650500001)(4744005)(2906002)(38070700005)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6684 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ae4e6c8-d752-4162-e99e-08db3c0cef78 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XNZFXGgvdJqJonSRI9w1IQf47RO1OWYcV4KM7TTPj4CIY8k4YxLXNqcWmdcF9rx1Vsvc6f4JBLsHwBG5ZQsTOcenirCPQbuiHEtTkzwalVM471NsRssRGwuQyCLz9D2Pbt95/Q/bTDIp7TOJo3TlC6XtIPYdT7AnhpMSgTiw73xCM9DydPsgl9GLXuMTLAgLuwoWNo/W9seaT7MHV/VO0Dpuj7s4UfN5CyMsVDzQPm3C35getl2uhXR6Melh1kpNkjJFscW16c99rjPHg+F4wdC2+F4PE8ss+5261SUNBjCI/vP7K+O2zBRf9m2qTadqpncW9MVYfGeFIREgISuw594s9SPjTNTmB05ChEuF/2FpKcKI1oBjmAh+7X8kJrYP7VOu9B9dzs94oiQSjNgfkODvnnRbmuZpLBOK3z4Smw1mMvSsUhz+nyMT+HzJ1rss4g0n2PmlNzpCBFwJHc37+dfJaOiaSbtATGrDv0Jz01SoBRi9wNO97BTqht0KWudMPPGWiYzA+fgTyqYGAmtFh4VCrkZQKadpuQwOpMg9MrBCNcBhzTD9cSUjKNY53ZXuTbVAQzH8S/J+ZtvXdRi3dCWeSnZP6954PoZmw7IwvalZUZnqQHx/vD+vn0pYyh5TC695kgHFhLyE1hmQ8hENzE6jAi+Tifa6nGBQHSJlRDzvrXOX6hYF3rw0q3NMEEn7QpbMW1mqkduwZJVJu77P+w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39850400004)(451199021)(36840700001)(46966006)(40470700004)(2906002)(4744005)(8676002)(70586007)(70206006)(8936002)(5660300002)(52536014)(15650500001)(478600001)(41300700001)(33656002)(40460700003)(316002)(40480700001)(83380400001)(82740400003)(336012)(55016003)(54906003)(110136005)(4326008)(7696005)(186003)(86362001)(6506007)(26005)(9686003)(81166007)(36860700001)(82310400005)(356005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 10:50:54.5568 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d253a80-8989-4ac3-7ba4-08db3c0cf4ba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5358 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework dir= ect > request/response messages >=20 > Adds defines for framework direct request/response messages. Same here, it actually took me a while to find the related chapters about this patch, so I would suggest that we can add more details about where the values are from. >From the spec that I referred to (DEN0077A version 1.1 REL0), they are in section 18.3, Table 18.{21, 25, 26, 27,28}. >=20 > Signed-off-by: Jens Wiklander I confirm the values introduced by this patch are consistent with the above spec, hence: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 10:55:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 10:55:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520624.808404 (Exim 4.92) (envelope-from ) id 1pmuc9-0001rJ-5m; Thu, 13 Apr 2023 10:55:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520624.808404; Thu, 13 Apr 2023 10:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuc9-0001rC-2o; Thu, 13 Apr 2023 10:55:41 +0000 Received: by outflank-mailman (input) for mailman id 520624; Thu, 13 Apr 2023 10:55:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuc7-0001r6-NP for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 10:55:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060c.outbound.protection.outlook.com [2a01:111:f400:7d00::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b912dceb-d9e9-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 12:55:37 +0200 (CEST) Received: from DUZPR01CA0277.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::21) by GVXPR08MB7728.eurprd08.prod.outlook.com (2603:10a6:150:6a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 10:55:33 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::f7) by DUZPR01CA0277.outlook.office365.com (2603:10a6:10:4b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 10:55:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 10:55:32 +0000 Received: ("Tessian outbound 3570909035da:v136"); Thu, 13 Apr 2023 10:55:32 +0000 Received: from 4080c0bc5b40.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 448A4F4C-DD8C-4774-B5BD-5762DF691FF4.1; Thu, 13 Apr 2023 10:55:27 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4080c0bc5b40.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 10:55:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB10099.eurprd08.prod.outlook.com (2603:10a6:20b:628::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 10:55:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 10:55:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b912dceb-d9e9-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7an/gZhtDrWRNg2OCaW8n6WhijrkmtfSxkjWDk2/8wU=; b=ESitETdiT1Ie66Gv8DiGSlWKjNt4wtMQDCo1vah4/P+ef9+MpOPBLmg5GY7FbpF6wcoNISR0J8UTtnvuRLAR6U8sfQeIzuL4AqUm2uzKoBKjZqJF1FYcnltIhKuYvBM1Q7Okdriw+Ofdf9A6zWr73CG0hsFksLYHkdD7wOa79f0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yh+lifeKc2lLyKL4NbEaZ775l2BpKDxCBtFI3AVfGZQylXpoP682RgB90BfPqxlS63JF3IBCjpV76TnaAHbnqJytVywVvk/RXeEfljAA1E16MRVexL/lXqFmn7uejZGQxgEtLqwjLO7bcARg5Tpkn5kWTdDPURNpToetHnlttaUDlSrPpjhHm1fRuChNxxTAM/L5N4gJ3eIF9o1gdOuz/uMR7ufbX1okvqrtTSs8HS4Ezz6fdez18PNtbADBQMD/IVHSVpAF9CD5nlXWPmpF1Io/xNPpoiC2IBFTE4gpDcVzRzoRZvY9B9kkEFHDWJdIGRzaw93MayllX9yFsURjww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7an/gZhtDrWRNg2OCaW8n6WhijrkmtfSxkjWDk2/8wU=; b=XCySfI+Xaa/Ay7S8qP+BQo0P8023gwh8AyYXwBQj37ejpdvNJ6pvzq+jBTQ3nMZtv2O/7HB1sIdKMbhXDqakTSsXFtf6hVVYs8wdxouEbzIT/n8Z1iNyj7E/rGQovKwvjcGRqwtJ6Ju8srK+C4pDef72iq1CZcnakMiVQLWXYRbpmn+ExEtzeu5dTn2OZsKLFkSTzT7noCPlM8KfGLaqtxd/x6OR3dn1a1Gc8jbK+Em5S8a/fM47SDsDA0FCCBeSbEdhcJmw4n2BGNz/K8qi2//vmrRIHtAoACDfg7Dmmglld2LUvdPBQeQZjcHFMlLItsuwMyeDl9gikHiT1GoXIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7an/gZhtDrWRNg2OCaW8n6WhijrkmtfSxkjWDk2/8wU=; b=ESitETdiT1Ie66Gv8DiGSlWKjNt4wtMQDCo1vah4/P+ef9+MpOPBLmg5GY7FbpF6wcoNISR0J8UTtnvuRLAR6U8sfQeIzuL4AqUm2uzKoBKjZqJF1FYcnltIhKuYvBM1Q7Okdriw+Ofdf9A6zWr73CG0hsFksLYHkdD7wOa79f0= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 07/22] xen/arm: ffa: enforce dependency on 4k pages Thread-Topic: [XEN PATCH v8 07/22] xen/arm: ffa: enforce dependency on 4k pages Thread-Index: AQHZbdfbHuhV0b3KPUiyzqcZuUyyg68pEPqQ Date: Thu, 13 Apr 2023 10:55:13 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-8-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-8-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3767CAB25120244EB39A17645D99F2A6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB10099:EE_|DBAEUR03FT039:EE_|GVXPR08MB7728:EE_ X-MS-Office365-Filtering-Correlation-Id: e0e2aefb-fd21-4ac1-7c55-08db3c0d9a74 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: k9+hC3buFul2nfqkP2IP/Md9zXujGPlfzzDy9IHyB7B2Ppn2Wn9FJmoa608IALFkWzPN4LVAhKmvMz0kFsUyBTgK5UgwIVjfvmtagn8T4QXIaYwvxpCn8ycqW8/0b8JGKl0jC8Kn3QkDxdRULwVtmxWUz7UzURu52P62c8BLXhllHFn62mMQLe+65JXgF5kPW6fgZVxpbKVMDyC5G+wKbdENry+4bZEZ9RJp3VUn3lrUNqZEF57s+2WVpYRPoV+4zxaWUJ1zPD1Q4rDiCJRYciWZLIXIh+Zlrdcgbe0leBf5ISpXq7JgHfc3JNxHjj1oduo1GCyzHOA/bIdh9tvMfff6h030vPhxhSm9QXi3seJC9NSeyEHZvCCVhy+BSfwLdOav4ylN3hw0IGEdL0/SRAMTJhHBErqmEGUO6YbouDV16yayJG5wbq8h/izyyKexxJpPO/Jf8XgU385iGYPApRjleq3v5W4ZfiXiYL/OCc31v2bsNbJ05ml1R+iScx5eZ3coqtkkk2f6sAwEohZC0+iMBW0S71uP9JxWf29hRopuO4p/0gc6TVHmZSreo195jzLA55m3Jb4DrpPyAzuaQwx2Y6ZvZbFO15g5qCpvJjI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(451199021)(5660300002)(41300700001)(33656002)(122000001)(38100700002)(4744005)(2906002)(52536014)(55016003)(38070700005)(8676002)(86362001)(4326008)(66556008)(8936002)(66446008)(66946007)(64756008)(66476007)(316002)(83380400001)(76116006)(6506007)(54906003)(110136005)(26005)(9686003)(186003)(7696005)(478600001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10099 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e0ec7bc-7f98-4615-eace-08db3c0d8ec8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eZNQY1OQQ2l+TvsJjOCfqYoR0G3hkzQBdmH1MWEtanK/MLNhCGWKYcS85z+gjcKsh7X9XQt7WQN0nOwXSN+czz1xvscBVU5cgzLhsF1Er2zAwiKwlv0OT4wu9aaLp+4xzOUUkrDHaXuCyu2R6z3HIUR2ecVpGpsvO5ML3Q/lp1Snp9V0ReFTPS0bAH4x/xodu2DKMXvyDu1dYlc491z8TOaeZXMpnsV/YPG3jvuGAFWhxnEclWoM/LE5iqwS8h+5SBftEpvo+2Jsv61Y8VwIegfSNeYBLvlVshIWyBG+ZBfiWQBXABBvVrxW3KS2UtlQFS9OkEruTCc/TO96LLN4bN+9bY3+2Ko2ejJfXphoRvRJ6z9RPgMkdfxzTE474kTj+a6fA+UThY+tSuDsW13UqdXTFFnYD5WR7JH/VqES5V1vcnwzJSA2iTZA4spwYWbdQx0XxQs7AbL6V3eHZ7sRs9eQ8aQ9sgoex5WnJf78+kgEhn5lcvUaTU/YyGm1O6R5J/nsBw1twXSaWjZI4R0X6KRtUjYR7oUV1h74IHhSjh97Esay6I5RxcURCo1vhm9+E1HNkSdeVB/JCsH4gxRGyW4YL3bTumyqU35ZzCPg71a0uC4/Sc/ZKvdHWMblOD0vrGKcYlFftw7xsFvpHP5G3iFr4Ywfw/Im9pXkdMq0Cdx3YKWaiO2yCmTPUXne17xP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(7696005)(8676002)(70206006)(4326008)(54906003)(478600001)(70586007)(41300700001)(110136005)(316002)(33656002)(86362001)(336012)(9686003)(6506007)(26005)(47076005)(83380400001)(4744005)(40480700001)(82310400005)(5660300002)(36860700001)(55016003)(8936002)(186003)(52536014)(81166007)(2906002)(82740400003)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 10:55:32.6623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0e2aefb-fd21-4ac1-7c55-08db3c0d9a74 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7728 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 07/22] xen/arm: ffa: enforce dependency on 4k page= s >=20 > Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A > mediator since the current implementation only works if Xen page size is > the same as the FFA page size. >=20 > Signed-off-by: Jens Wiklander > Reviewed-by: Bertrand Marquis Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:07:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520628.808414 (Exim 4.92) (envelope-from ) id 1pmunV-0003Nh-7M; Thu, 13 Apr 2023 11:07:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520628.808414; Thu, 13 Apr 2023 11:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmunV-0003Na-4W; Thu, 13 Apr 2023 11:07:25 +0000 Received: by outflank-mailman (input) for mailman id 520628; Thu, 13 Apr 2023 11:07:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmunU-0003NU-Ju for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:07:24 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0622.outbound.protection.outlook.com [2a01:111:f400:fe1f::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5dd9f92b-d9eb-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 13:07:23 +0200 (CEST) Received: from DU2PR04CA0303.eurprd04.prod.outlook.com (2603:10a6:10:2b5::8) by GV2PR08MB8170.eurprd08.prod.outlook.com (2603:10a6:150:74::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 11:07:13 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::78) by DU2PR04CA0303.outlook.office365.com (2603:10a6:10:2b5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 11:07:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 11:07:13 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 13 Apr 2023 11:07:13 +0000 Received: from 583c30d9f038.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5692465-EF07-44D4-8B09-58C394C9F5BA.1; Thu, 13 Apr 2023 11:07:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 583c30d9f038.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:07:07 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB9575.eurprd08.prod.outlook.com (2603:10a6:20b:619::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 11:07:04 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:07:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dd9f92b-d9eb-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJWgnlrg0Wg4hkIVgIUCJl1zVVBS0VE1HQf7JQV7XmE=; b=0IvQBB02+ryCJFB31AN3SgAaFH2GruzdAEfFHELAX2o0zqn0FOqmKDA16GfbfiFsMWPZPt/TNhYcD7GXmAwrNmJmQycqc4JMdmWhUhw48/IfmJFs8L0IuN2wxYNBT5ct/u0BW0xULLgpuXZOCgqq7LMlbw+J0Du/C3bmQb2bURM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYxpVoQiolbrAZwtaaG74oJOTiGlSQcF/CcrnGTGPeFdcfKgdJ5aoWa6ub2V0d3LHzbmyYjG+ODUfaywRcohSRBVF+TcWeJVGg4tb0QGhCHt8O22FbTQ+wkR2KcLZufEfx/TEngKVIFdK97UTh6r7Rw7d+k5s6e6ciwpVmMNe5BDgkmEHKIuYt+C0YRDxWRnWZcEda04XugUlZFVxniz80EmGT6w+c7OtIysGnFrtl64JcAxjYWQgQ6zePNRLxPQSKeNkUF2Aq0EYxPfTYtrjjhPpKdwDxfTL7oX5dcLTpCBnnVC2yFIELlWxOJKZiM1ujJUX7Nksqo1TM7mEJavXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJWgnlrg0Wg4hkIVgIUCJl1zVVBS0VE1HQf7JQV7XmE=; b=j6HlG/SHaxh/tVVfEbLbKIpk1FfzQ6YCqIiOiMTFNa0nT2nN2jzn5yvnaRfzFFeZrJZD1nxjKDZGlJnvGPRwrMTMCMIJtBgz9vlROUYYeiuUJy+R8NTLPSrb/MuQd2jXy/COLh1//0reAt7ejheRIh97FiROYgbj1KqlurTZL/3dOID0Gm8ma++mM7cllr5XvFM6O4t4nriEkKhM5WZSDdmT9SjFjgiWCDbUBuI+tpSZEQ6/6Te9mbWZj+wdsVnj7ixJD4lc7hWWQi8B1c2/1J3WinSW1LwJjwHF/aqzEJLsGikUO+pOmTQokDtZwOw0KWN/tt7zmeb7KdeZTB+ghw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJWgnlrg0Wg4hkIVgIUCJl1zVVBS0VE1HQf7JQV7XmE=; b=0IvQBB02+ryCJFB31AN3SgAaFH2GruzdAEfFHELAX2o0zqn0FOqmKDA16GfbfiFsMWPZPt/TNhYcD7GXmAwrNmJmQycqc4JMdmWhUhw48/IfmJFs8L0IuN2wxYNBT5ct/u0BW0xULLgpuXZOCgqq7LMlbw+J0Du/C3bmQb2bURM= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET Thread-Topic: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET Thread-Index: AQHZbdfdlkWasQb0b0OUu0VnJOxcoK8pEVxw Date: Thu, 13 Apr 2023 11:07:04 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-9-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-9-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EDEA08A656D40C4DA2380F8808E3DB5A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB9575:EE_|DBAEUR03FT045:EE_|GV2PR08MB8170:EE_ X-MS-Office365-Filtering-Correlation-Id: edcb7e6b-2cba-4591-5a78-08db3c0f3c03 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d/YWIZg8OFsN8TObEvR+Sm89L9a2gb0kajVkrioXR1dtZThz2kPSHihZ12MNeSiZak2pWOisaZoWGjXo1u7f8sLG8spqjJ+RcDCQk4L9OuCNARl3LnqABdSb8r0/7wYb4PPxMyc0zypTzJsP24FRqHmEwEFQCKqHL15FAkw4AaLxzYwJutb3nWIsM85XNHnJoialUM3YVFfI8mWy8uBf/0ESNum6NEUGpMWtHfDV2Enrz9LzrZNkhSg/7zoBVRX1B9KhMU3lTS1iOyl9zyMwraAZPjgRJ801LGk+u4tHmwYQkNC1ziBiD1gN9mWeUvEs08cTYgaeuAEFQ93jNUmUgBziGyP4nLh8fwmAwfbsNaN0446g3EKfChPplBUxKXKLX9NYRHG75qEhH7t5FNmkpRxoQvjiKEdCsqsX1kVDWdbXa0AQkVJRnrWukQxLUWGCbFF8PYR9PgBwVWQ7KJQu0R50pPxE7h6Wk+16PU2BzzSYrnkPSxbyWlrTZ7Wcmcz8ZNHogWfVvSoKIDEDxgEXmVks8jKEg8JJ2RrmrkoL+B+EEZsSY4RMDTxMiqg78IMa2OqkTR33N4/e1UsL82FQXTSDYdO4RzS3o0p/b0SEMv0Ss9Z4GsMsaDdvMV8plBI+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(451199021)(478600001)(71200400001)(7696005)(52536014)(33656002)(55016003)(83380400001)(122000001)(38100700002)(38070700005)(86362001)(2906002)(4744005)(316002)(26005)(5660300002)(9686003)(6506007)(110136005)(186003)(66446008)(8676002)(64756008)(66476007)(41300700001)(4326008)(8936002)(76116006)(54906003)(66556008)(66946007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9575 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 45487b85-16a8-44dd-fe35-08db3c0f36e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7kQ1jFSIFJyjlfcsiFgtjWEB1i7EErLPiov6yIGxzxk0W9bqtcaMlKx0XVCs6tLwerEqTiafck0pLQKh7OVj3aiLFSPSbenq9LgBIZ/4P7y8T5aWUg7UNiAnMNDLC2i/gwwrhxWSyYyA79E4Zj1ftZ10MVrNFTDXaDhT46pvldJQEK646gtXpWNaRh0cOOemAF2kqeyShiq3XLeKmNd1lHQRGd4Up2MlzPRqPsyOed65bKzSCdAw4AFLPnoqIOCjpNgFVHPBMANEIW934z4wmU1dmj2MihlTKdDDkj9JSyuWOLDeoPX1zK13ZeiRDGoFiLWlXI6fPuMUFbB+lWQahy4sPoGjEugknaMvxkozO2DxdOE7+vbECNED2baa+f3N9ETODvQe4TccS2MVGEutXxZx18KdlEepvI50+zD10LO4Vs/lj6EL/zuTDdCRjGOu0SKyQF7bvL2EdDKd+60GtqMBgktYUajZUATjiPUg56NToEQg4BSyERK6HRy3g+h+KsWW6J6Z3KUmmbPtdRc/64zegaJz0Uy5hzgra1aquiWc9UMterfr3/RI9oD95SjzqibTQM6HC8ttw6a9xGpxj6I25Ek6uZCwhPx47Kgpy4eSIZxEjHWT8At/auKWrt9O2+hbt0xem7Kl7fCZ491XD8bNRNTnvQ1r8IoNFSSvczyqsS5y95r7osJ6QWKbXj+IyDrkEWWFe2yyrI9eSuGzYQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199021)(36840700001)(40470700004)(46966006)(47076005)(40460700003)(7696005)(70206006)(41300700001)(54906003)(478600001)(8676002)(70586007)(4326008)(316002)(110136005)(81166007)(86362001)(33656002)(336012)(6506007)(9686003)(83380400001)(26005)(55016003)(4744005)(2906002)(5660300002)(40480700001)(36860700001)(82310400005)(8936002)(82740400003)(186003)(52536014)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:07:13.2085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edcb7e6b-2cba-4591-5a78-08db3c0f3c03 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8170 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET >=20 > Adds support for the FF-A function FFA_ID_GET to return the ID of the > calling client. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 90ed71cbfda3..f129879c5b81 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -181,6 +181,12 @@ static bool ffa_get_version(uint32_t *vers) > return true; > } >=20 > +static uint16_t get_vm_id(const struct domain *d) > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; Since here you want 0 to be reserved, I think maybe you can use the "d->arch.p2m.vmid"? According to the logic in p2m_alloc_vmid(), the "d->arch.p2m.vmid" is also a per-domain u16 value that starts from 1. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:16:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520633.808427 (Exim 4.92) (envelope-from ) id 1pmuwY-0004sL-4n; Thu, 13 Apr 2023 11:16:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520633.808427; Thu, 13 Apr 2023 11:16:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuwY-0004sE-1z; Thu, 13 Apr 2023 11:16:46 +0000 Received: by outflank-mailman (input) for mailman id 520633; Thu, 13 Apr 2023 11:16:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmuwW-0004s8-Qp for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:16:44 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20610.outbound.protection.outlook.com [2a01:111:f400:7eaf::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaaf72df-d9ec-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 13:16:42 +0200 (CEST) Received: from AS9PR01CA0035.eurprd01.prod.exchangelabs.com (2603:10a6:20b:542::14) by AS8PR08MB5942.eurprd08.prod.outlook.com (2603:10a6:20b:29f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:16:38 +0000 Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:542:cafe::7e) by AS9PR01CA0035.outlook.office365.com (2603:10a6:20b:542::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 11:16:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 11:16:36 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Thu, 13 Apr 2023 11:16:35 +0000 Received: from 0d84159f08d7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 33B58FD5-443D-4119-98CF-B201F18E2EDA.1; Thu, 13 Apr 2023 11:16:28 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0d84159f08d7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:16:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB6226.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:16:22 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:16:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaaf72df-d9ec-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8bA0eVWBnPdXLQXkC9X3VWUJ+ot9sWzORV2Kx2lSobI=; b=aelvx9QnNuU1cppr+I9HrbkmcZuCDMaAGbjjNW9XGWw7Em0qmoWYGo5WDGo+MFWdQB8UzuSFTh8N6clVGQIhNQQ9tbUcZycPqr6rOEp4pJi1rJRaOcnfLXZSH7Z4r29W7sExBN/vqTkPOcz+eAjNt8iddk0aWnz4c43h/d8nNC4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tc6t2s1WPEAs37dKPda17MAHFqbgc00cS075TBex9EHlUtA0Rqm5zxHFkMuBqngwtwSNPdy0slE36sVd2vZRgaJGQ+POfGGFBL8oFRgx0FeEKsYfO+8/64CKiJNEMG+o4g2fnkXzmZQSVdA+Pn7KpmJsIHCIrDRNVp33EbZxR51dflDcVbuPywW24fvCXaobhZMqsbXYHOcWT/tVxMgWHzZWiHiksn520YVMpLETa6p8BkdbYPOeFhnd8ZKWVX1DAsJzUUX2Fnq0jszyb3MbrlsnZf8B7uDGnLeKH2ds7GY54X14ii2hPHO1WKM83yo/rnEfZdYzB0VP7shgR0j33g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8bA0eVWBnPdXLQXkC9X3VWUJ+ot9sWzORV2Kx2lSobI=; b=LUkKrRWCmt/cCsQBfQJXwWqarRnb8nUjNVhEcHSoIVsPrbOSHd8XFcCFoR2j3TRRhxDhiaM7pd1qCZrYsLFwfY1qg6JGa2gjt1krcC9uVFLzSQHHYbUV77lwL8FpzzS37zBxapRSnU7pSK7EMT2ZRJHTS+AF8fZkMr/5RqmDFUIE/XPvEjtpyCckVw41B9tGIb0mXNJQDTZdoGtJHvK9gf2g1JmSo8Sx5EE0uNtPoPaLqiUKPIKZoFlidEUoV4OTb3s+iodK9RzsDX+Cg+pVvRuOV9J8RQ2WWptb0NkQpS1hzsxblNrL8EkOKDB80ayOi5LWChomUexJ6swcb0xbcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8bA0eVWBnPdXLQXkC9X3VWUJ+ot9sWzORV2Kx2lSobI=; b=aelvx9QnNuU1cppr+I9HrbkmcZuCDMaAGbjjNW9XGWw7Em0qmoWYGo5WDGo+MFWdQB8UzuSFTh8N6clVGQIhNQQ9tbUcZycPqr6rOEp4pJi1rJRaOcnfLXZSH7Z4r29W7sExBN/vqTkPOcz+eAjNt8iddk0aWnz4c43h/d8nNC4= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Thread-Topic: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Thread-Index: AQHZbdfc5IUuFaQpQE2OHTLbOE6lL68pFi8g Date: Thu, 13 Apr 2023 11:16:22 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-10-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6AE5779DD03AEF4B9F88C8470DE294F9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM9PR08MB6226:EE_|AM7EUR03FT051:EE_|AS8PR08MB5942:EE_ X-MS-Office365-Filtering-Correlation-Id: 6482099a-1398-4ea6-1d27-08db3c108b8b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gzzaCJQn2mmxhJ9vQyyc88FFg8ZglnfhQ6kjctnF69vtP3Fmj+FAG5999uvNg9ch/Bp2FlJQX0KYGPpeTyLtg2pltZISegpbwNwlOvxRPzgW6WqM2OXHUscZW5PJG6Xf3bOZy0EUg3sXkugDG+p8VBF6v1Cg7mQY50/HTMdl7xZ0SAc7DnxeKvCzqZFzlUwSr9vOIuv/awGo0jtzCgvZu1glNdotuvO0DEwY2mvJbxEpVPk6m2g7yFiVGuQPyvsuq5E8wVIFJSOtaV7VZP43UsR40cvTjT36tDjB9Ktq7Jh+Aga9abadwBAMPALZlgJbnkUncwVTjyTEA4+aPBWdjEgEjq7jRIIsPG5+M9hGsOCnhFLRU+RMmnPbZ3MQ05nVHIcMijUq8mpPtNgyO1upbdHPD1QEQaZ8C7BHyjLFktkq7HlG7A26GJqkRpJu2pgu7wlfawIqdI63ahTsOFo1jS6CoriDJRT6x/RXzZr1b84ubD4jLJ8yIn/odV4LC7VJ362Yn3phpEUVhveJVfO/rC29wq+JrFi+GjuvDxpLqMCLBVdagC1g8NSnExvWfYHFUf1IDpWc1cAHvbFusUSIlknHwn/H2yv/Yu0pG/wdgWjjEGpoP5AHdlX/goJI9k8b X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199021)(26005)(8676002)(186003)(8936002)(38100700002)(6506007)(9686003)(478600001)(316002)(33656002)(54906003)(86362001)(76116006)(66946007)(110136005)(64756008)(4326008)(66556008)(7696005)(66476007)(66446008)(71200400001)(55016003)(41300700001)(122000001)(83380400001)(38070700005)(52536014)(5660300002)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6226 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05d54294-d292-4bce-3b75-08db3c10835a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Ik2TXdFCAdcQCi1+Jq7+BFke9bMsNpjHS25MYOrt1/GPM8dsGLIAHHiPGXiG3NNQFfhxrnZMWyeyeeD26DLl8PGJlBGkOGw68FWIDmRkuray0lVFTiz+Y5O9PQY0ZioohSViEhI6YHnWjI4zy6mFYK15lT/0tg+4+IeFECeLAy1aaYq3g5t6ZqIP9IIgUzJYcoRIPHmM/8etr90HUW0ff2dQLCBcd9cDuBs1OvCHzMBzAcaCUA5gjr7aI7Q2QljbvsLqnFXqVyJ8nDWFZvQBB9Ila4/qGhNIV2L6kfJCpXvk5tHqUfw7PEiSF/HNpNh0txIKc+vxj+6qipfZxNXDjecYWW0N8eeoGN/FOiOvSaigE3MwaIhLF7iPeHV+6OvXv3RPQQlFqvII0Y1W1mukPfv45zKxk8qEkd9S9QTk4M9C8iTmy+gShvPpn6HtvCxZsA+i3wpR9r/UcE/TlIKM/S6oiK3oXsYY0RWtDMIjRc0RRrYq4hbUSKpXI7/8Rvxwr9aU2upbURJOuFngOXHxFyCnDE/E8MOT+l310jE2r6lnSGV0JNOJ7A9T97bXT6BhaslIFAXAzVxQdS846VNDtJ8asYesW/s0CGd3x8JAYujBIqPrOZZkVh1oOMOpIi5ay0Mq8yOcRTqkrmXDvLbv8rhZL3BOXGU0Ay82tYE+Nl3SzN+8jNXCaX2l15K3XI5K/xT8lgv+NkVgu+0vYNLFA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199021)(36840700001)(40470700004)(46966006)(8676002)(33656002)(36860700001)(83380400001)(47076005)(336012)(7696005)(478600001)(40460700003)(26005)(6506007)(54906003)(110136005)(9686003)(186003)(2906002)(52536014)(5660300002)(81166007)(316002)(4326008)(356005)(82310400005)(70586007)(70206006)(41300700001)(55016003)(82740400003)(8936002)(40480700001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:16:36.0725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6482099a-1398-4ea6-1d27-08db3c108b8b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5942 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support >=20 > Adds support for sending a FF-A direct request. Checks that the SP also > supports handling a 32-bit direct request. 64-bit direct requests are > not used by the mediator itself so there is not need to check for that. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 112 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 112 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index f129879c5b81..f2cce955d981 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) > return true; > } >=20 > +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > +{ > + switch ( resp->a0 ) > + { > + case FFA_ERROR: > + if ( resp->a2 ) > + return resp->a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + return FFA_RET_OK; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a= 2, > + register_t a3, register_t a4) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D fid, > + .a1 =3D a1, > + .a2 =3D a2, > + .a3 =3D a3, > + .a4 =3D a4, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_features(uint32_t id) > +{ > + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); > +} > + > +static bool check_mandatory_feature(uint32_t id) > +{ > + int32_t ret =3D ffa_features(id); > + > + if (ret) Coding style nit: You need spaces before and after "ret", i.e. if ( ret ) With this fixed: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:20:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:20:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520638.808436 (Exim 4.92) (envelope-from ) id 1pmv07-0006Lg-OF; Thu, 13 Apr 2023 11:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520638.808436; Thu, 13 Apr 2023 11:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmv07-0006LZ-LY; Thu, 13 Apr 2023 11:20:27 +0000 Received: by outflank-mailman (input) for mailman id 520638; Thu, 13 Apr 2023 11:20:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmv05-0006LI-Pa for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:20:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7e1a::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c9b8484-d9ed-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 13:20:20 +0200 (CEST) Received: from AM3PR07CA0090.eurprd07.prod.outlook.com (2603:10a6:207:6::24) by DB5PR08MB10164.eurprd08.prod.outlook.com (2603:10a6:10:4a1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:20:17 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:207:6:cafe::b7) by AM3PR07CA0090.outlook.office365.com (2603:10a6:207:6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6 via Frontend Transport; Thu, 13 Apr 2023 11:20:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 11:20:17 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Thu, 13 Apr 2023 11:20:16 +0000 Received: from ea88f1c3a20e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 87783C65-DE60-4F96-BA21-B9EFE4E583E8.1; Thu, 13 Apr 2023 11:20:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea88f1c3a20e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:20:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8662.eurprd08.prod.outlook.com (2603:10a6:10:402::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 11:20:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:20:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c9b8484-d9ed-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V4I0Ly3VMIqge6eo/oxfppyc3rD8Kuvq1z0VJHkg0MQ=; b=jPZ8wBh1dbImg2GMAhyjeoNv+YVyND/OCDHY1OMn9ZvMiopM+sysg4fAk/0UHi1l4ywow+g+QeecLObGUWJZKjwReYqJKGGkHGpU9p4KvPc+Eg4rKrjfK4I1g7k5EQ84AyisJFCXO7NW3lJZtWtG+p0GWl0Mv+FmouVk8OyU+ds= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNar9kSHTk9oPnDWajJWaMJ9TNcnUCxxWZb9Zw1Ln2ogobxBd0XwRMiTiHOaSK7ahBoGtWBIjHG3dkjtDzBaAQq/34V4cGp7wD9zYgxEH5QV0Xu2eHOQgx4rnQjKncr0H+WJ7SPl04Mdw98U1QfahfUHJo3Qcfb9atLPvrILW9ZRQBvFSC9LjDue6KLT08SvJEYr3rNiS9VYXjqDyTvPtocOgF0g7owfc3SakeAW/KvD/4adfsrt0q7H88hGbZU85I+1FPx2e4rqD0BS2Z7l+WHk4uxO4SJTnIFGZdzZSLPgFhF+DUJ6PK7Sk62ZJZXwOcY7RM+6ClDkVcT/41DgEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V4I0Ly3VMIqge6eo/oxfppyc3rD8Kuvq1z0VJHkg0MQ=; b=DvqLaj9v042aIvN55KGR457kqCR0qlRxbtJ+yfrgScbtnnNkP19FdF7bZbfCbKdQYd74naj4Vj9aZaHE025x/Z53fAKJ8aGxHph0LHZTdsX9v2aL2Iohe43zQk1c4FnJrm4mQHLWYgau4cEurq5EHZtulCdtnrEDEmldlGx3Pj24uKbQimiJU8v27v7JtgroM5m4Uqsen+gWyjPWTyDDBFsMmVMfXeDXP33o7wF5BDvunGHO81fSCqMuLqTCW8MCmvohz3+/e+2Ra3F0BAoJ9kAxgkOhqgqwDtMQUSkNz4FbAOpMVZulQHz5jek8Q7ONlGTERJYHiszFB/boro2B6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V4I0Ly3VMIqge6eo/oxfppyc3rD8Kuvq1z0VJHkg0MQ=; b=jPZ8wBh1dbImg2GMAhyjeoNv+YVyND/OCDHY1OMn9ZvMiopM+sysg4fAk/0UHi1l4ywow+g+QeecLObGUWJZKjwReYqJKGGkHGpU9p4KvPc+Eg4rKrjfK4I1g7k5EQ84AyisJFCXO7NW3lJZtWtG+p0GWl0Mv+FmouVk8OyU+ds= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: RE: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator Thread-Topic: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator Thread-Index: AQHZbdfkK4+Lpc3ia0Cwa4AcAShE7K8pF0vQ Date: Thu, 13 Apr 2023 11:20:01 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-23-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-23-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D794DA9012850145B3787C7B4B253050.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8662:EE_|AM7EUR03FT046:EE_|DB5PR08MB10164:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dffd47e-076c-45ea-687c-08db3c110f43 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9W7k1OX8qJTJhnSyPFJFRSNOrZMjSFgz9WCCnVPIvLLs+0PKR8pHtc2gH3qeoEMoymGcJtxfVtNkhC7qyaDrQ5RxlzstF65iRF5LYG0OKN3abk1dcRXlzEe2dRdHpk8L1Ke5cS95XVoG/uAMuqP0j4B+EKlWIYKpIGecyAXv1AxwDeAR8c7OEiM4T8INkFqQ+38F60AE+zX8XhtfB1ZRQssXvgHgAlc/Ea4P4wpLS9Djvd5muJy3wZJeg+CD3QShGvIaP65K/joE8CfQWXmOvvw+HmkeC8/G8XWVWtryoC7RSsvE83JemoI8i30Drj+zrAbcEc4QA7ZvfZ6NAkNHLQ0YmnSWmL+vqnU+mPsNZCf54zCXe2LUIkunLSonWWu5J9y5Pw1bCoidJQcoo9UBQ8cjYXLRGLGf4Tsnmbh95iDSMNOuCbhm+YNXCwRpncano6Tbbgt4kISx6YX8Ena+R6dzBQEViLYxhcl9pteqdho3Bpa7k/gjLGQAKmqs1/Jq+ZY8LvpndBrFDVaPro6bn5N+Yhrcv8mmIM7+m5Y2silYZM6eaI+gUn1KmtHLqrebJk+juV1pN2amj7kEeM+wS+Bl6pmdQ9l7IZRYVRFzC8s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(4326008)(71200400001)(41300700001)(66446008)(66946007)(54906003)(64756008)(66556008)(478600001)(8676002)(966005)(66476007)(76116006)(110136005)(316002)(33656002)(86362001)(6506007)(9686003)(83380400001)(26005)(7696005)(122000001)(2906002)(55016003)(4744005)(5660300002)(38070700005)(8936002)(38100700002)(186003)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8662 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 51d9b2bd-d348-4319-58aa-08db3c1105fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2qYJAIeL4JAEMgucaI1evwoUBFcRg3dJddbjGacdhC2SBkHB4W+6c3Pn+AUCKF+DcTvM+gQgJDFtezf5ns+iFkUEH+OVwK3RQ26b7fjZwk9kY6NPlGLHGw75Gy3FzCAaXeKDyyWwv76LgfR15lRJq4mPtSSv3ldjrTwRUtimmFDc6oZelMkiKPp7l9M8PDIv978x1Ea2mM+f0ww1Jk0UFWhRVnC6aALHTGcgJMJyWnTkzVTx38mJbiSI/FWkNJjt3bsqcFoPePECeHu7IQrqnBOntLCBHXY6dPqqwdF92+grUEviqCAEM5oLWxuvruTvncXUC4y5oGEP78RYFkl3HgqlNwEgRk9Cw519nuEGejglUMN4lnxkfr/mIPEoo69CpQzyR+ag85ctP5uu4V3Tm+dW6Y1uAMHT7rbZFFxHUfGqmi7hc+6oFZdS7nUogmrsQmVorTVt5Ysj6MqcBAntPmq5opPjNi3vBY2QdSHD6Qs1WlBa+FcF5OdYkk/I6VxMoSnmNW6gpcmvf7pHU6LAcqk6WZdb3hQQKgXSuk/9QqtzAtBR8rxnZMAXi4BCbk0DIzyQ19qLw9JKdJEurhwEcy7C9TS5krwQrHTKNLPxF/gLequ6aoo4Y2WVJFL6Trz8FQ9foGx5eCwtulo7/mQWolVbC1eDCJSt3nwXtHfyo0rcbGfCroobVFcv/cSEcZK3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39850400004)(396003)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(110136005)(54906003)(478600001)(83380400001)(336012)(36860700001)(33656002)(6506007)(186003)(86362001)(55016003)(26005)(9686003)(107886003)(47076005)(81166007)(82740400003)(40480700001)(82310400005)(356005)(40460700003)(7696005)(966005)(2906002)(41300700001)(70206006)(316002)(70586007)(4326008)(4744005)(8676002)(8936002)(52536014)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:20:17.0618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dffd47e-076c-45ea-687c-08db3c110f43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10164 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator >=20 > Describes a FF-A version 1.1 [1] mediator to communicate with a Secure > Partition in secure world. >=20 > [1] https://developer.arm.com/documentation/den0077/latest > Signed-off-by: Jens Wiklander > --- > SUPPORT.md | 8 ++++++++ > docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ > 2 files changed, 23 insertions(+) > > +B Allow a guest to communicate via FF-A with Secure Partition= s > +(SP), default false. > + > +Currently is only a small subset of the FF-A specification supported. Ju= st I am not a native English speaker but I think this sentence would better be= : "Currently only a small subset of the FF-A specification is supported." Other parts look good to me, so: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:25:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:25:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520642.808447 (Exim 4.92) (envelope-from ) id 1pmv4M-0006vX-A0; Thu, 13 Apr 2023 11:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520642.808447; Thu, 13 Apr 2023 11:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmv4M-0006vQ-75; Thu, 13 Apr 2023 11:24:50 +0000 Received: by outflank-mailman (input) for mailman id 520642; Thu, 13 Apr 2023 11:24:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmv4L-0006vK-Nh for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:24:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7e1a::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc1b33f7-d9ed-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 13:24:47 +0200 (CEST) Received: from DUZPR01CA0032.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::11) by AM7PR08MB5480.eurprd08.prod.outlook.com (2603:10a6:20b:de::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:24:33 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:468:cafe::1b) by DUZPR01CA0032.outlook.office365.com (2603:10a6:10:468::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 11:24:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 11:24:32 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 13 Apr 2023 11:24:32 +0000 Received: from 80e7a1cdee1c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F1F9C4C4-5C27-4C9C-8F01-058FA06429BE.1; Thu, 13 Apr 2023 11:24:26 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 80e7a1cdee1c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:24:26 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB6641.eurprd08.prod.outlook.com (2603:10a6:20b:306::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:24:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:24:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc1b33f7-d9ed-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5k82IwOeVZsMCaZrdotkzys+/bc2SQkXVVA1MVPmjuM=; b=wGf5d89sfvHgJlnh3gZNsXPo2fQJ+L6az8CGWbawMjSqzPn5Lfh54W6R2Z+d1Rr6JgR4Iu05vR6LnXavHSxzrnDkJ8iSwNLGL2XpW/J4Fc2aUGwh2JGOiemEx/bCEQil0IDX/irFueicOne24tebl6D/7V56PXefidBx6W3h53k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GK4LcPAhxphz0DN+iuE5iGG5iVxOj5D3RPaWqFDnhvqI3XJqwwDOYqi5bC7i5cejhaqYL8wXihIPteWaS8TH5uxXFzTp3tbg/iukAfsFBGFMsXoUrtoASD/UpAZZ1h48Pv/ZTAKv7mt0kvvlWsLbFeZ6JfVkUj5PD2ksbR81TJ6+dg6Lta1Rn/DuS0B4/m/G1N8pq1lVQRuiY8Jkg/Zbg8CLfqSFa3bORacjNtbyO6f0cxrlV46ZY4EP/F9ygmt4L+9H/Dfs5hbF6enULm9lJW5r6ETsIjdG8ju4PHwDs47/yaAjr/pQSoT/1TJDPCgPrh2mPL2cczo9U3hcjeMXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5k82IwOeVZsMCaZrdotkzys+/bc2SQkXVVA1MVPmjuM=; b=LqCC5OneCzWqr2UtZgfVQ72q8u/tVvgFoGrvp6TNJnNZkL8O1lofuTI66hclGu0wGUkOE/7n/QVkFbqEDXcFyZIS2SZ7RDwtAloufd/57kIle7y95e3ryCCeztM6OIjM3S+1Ps6lzyIn/0pxPWipMpb4LffqN48BrGQ9tDuI9FfIChzU1kNdAKWpfnTgzd9SWiNHUOvlmOiWaZpggofYDOfHsqs734fBE5XfT467ImGRaMdw+dow5HdnHQdHJotcmyHKypevt1k9yk/QS1AqT9U6ogDv8XKNZ2MhHNfePbjjt6GUEB90X7FPF5X9zjdU60+l8HLzT3MOfFAPdwSFkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5k82IwOeVZsMCaZrdotkzys+/bc2SQkXVVA1MVPmjuM=; b=wGf5d89sfvHgJlnh3gZNsXPo2fQJ+L6az8CGWbawMjSqzPn5Lfh54W6R2Z+d1Rr6JgR4Iu05vR6LnXavHSxzrnDkJ8iSwNLGL2XpW/J4Fc2aUGwh2JGOiemEx/bCEQil0IDX/irFueicOne24tebl6D/7V56PXefidBx6W3h53k= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations Thread-Topic: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations Thread-Index: AQHZbdf3MKIAKwiaG0CPrYU6IaiuNK8pGDOg Date: Thu, 13 Apr 2023 11:24:24 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-22-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-22-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0D6EEA0095F4834E8EDFE70681FBFCAD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM9PR08MB6641:EE_|DBAEUR03FT023:EE_|AM7PR08MB5480:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b3cb212-52bb-44cb-bf11-08db3c11a779 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WpTbuMSBIIamfo14OOL35PhS5nph+9NHkUUZYp36iXGoNW5YjpdQQV6Qip/RISA6aHslthaL/DMp593zvneGTjEapHa64N0BZApA5E0ITIBzNxeYfB+wWt7XOc8MsX2SqeIgLzHAa2Bw6efPXWslAYEoFDoJKPGXf5jySh4lXJ1dtWdB6PQfX0dgcAG+w8iR69AcZcfSTllrSZDZ9RN+oYMBZjAaGKtglzsx/YlJp50wD+/txKOeO1Vj2FwXGDDJ0ayNIDCdI4sabCM784tBDcSUBhGXasm7uFWQvCLUV3qtg1UcVVR7/kWrUs93tn0UTX4WSnBCbcpXgb2ja9vbBobWVvVs0NY8/1cRY48UAlvcTgfcHltFYM48BBQRdEIyHhipdViAu5e8uA96dDlGfdMYaUGWeCajjch/i/7X3sJhE3mEAhIC0y+nEBGFiG9z+6pHbUdS6QG5VZDQd48RBbiTuC2EKiC83uGpRsLpgTKO8mJRnPN4Jluc8TTZ26iHGxz9hw/z0QDMMesgxDvtEF9ceZyPSur2/YRJFi6IwQhEgEaZQ0kfRABcQ2gM2IIydnp6K/GxMCfNvNp5qJh++MtzSejn8EbuXzH7yicicuk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199021)(9686003)(26005)(6506007)(186003)(2906002)(83380400001)(64756008)(8676002)(66446008)(4326008)(66476007)(66556008)(76116006)(66946007)(71200400001)(41300700001)(54906003)(110136005)(316002)(478600001)(5660300002)(7696005)(8936002)(966005)(52536014)(55016003)(38100700002)(122000001)(38070700005)(86362001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6641 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8ba5d430-0da1-4f6e-515f-08db3c11a293 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: idgqJOQ8S6/nay58TObFZaq/f7/kGeeJjmjg1FiXRRU11KVppHog3cNdbyySPkWQ8+x6vAdhiCcnBbzNbQ6m2A446qfRHddFhPI3xq55ijjBMLkrcggMQ/WXn3WeQzO0NB6zXp7iPRWZU1fTlkyOPZ+hvvJzkGiMXc4wbCsqCFBE1gbuaaQZ8YcNTSbZ2+W2oKiQxzsyqF14fi2C2Y1tbnQ8ASt4tI4IzHl9WoTBnu32U0bGVxSS6Mnnu04JO2dYMEpl6FfRUSdhLZuGZmjb6z24dOCaIRhVjHZ/ZER3sWWV8Q22EqIqF38M77wplr5yElQZWMz02FSlDP7IEZbT4x9gdex2J/NWprdrZUCENV8Ql4+BiJ4PXFsu7RjpzZngI/R1jwMoAqmREF4+8mA0GAAPNA6o2Y9yb+Mbfr0Hm84uFn0SP9NqN+HeHss3RKte7vu9LnUzh4VMxp5/5uv1Y6Q8ZS4LassPrF/5IuZpvnOqKoUk2Nm57LNHAlG2vrh1U/riUz2arr/UOIGYBpKuJ/ckYQjN/Yj6oLFh+isq1BTmkwo47m9wjGX5r/AkGlPNLwilFaxqRwL7qV09/9Ld6q3D/ltTSIZ0AmhawMmmhjHHim410eFJZopjlabanRGkeuteAklolsu+TbUF6VT8MUDLsvQM6RgnpyvSHLuHv747tifhq1IZop9ngrKrZMQF X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39850400004)(346002)(376002)(451199021)(46966006)(36840700001)(40470700004)(36860700001)(70586007)(47076005)(83380400001)(70206006)(6506007)(4326008)(966005)(26005)(54906003)(7696005)(478600001)(110136005)(186003)(9686003)(52536014)(2906002)(40460700003)(33656002)(5660300002)(316002)(81166007)(356005)(82310400005)(336012)(82740400003)(41300700001)(55016003)(8936002)(86362001)(8676002)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:24:32.4785 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b3cb212-52bb-44cb-bf11-08db3c11a779 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5480 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations >=20 > Adds a comments with a list of unsupported FF-A interfaces and Typo: s/a comments/comments/ > limitations in the implemented FF-A interfaces. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 0948cc636871..6424c222c885 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -13,6 +13,38 @@ > * https://developer.arm.com/documentation/den0077/e > * TEEC-1.0C: TEE Client API Specification version 1.0c available at > * https://globalplatform.org/specs-library/tee-client-api-sp= ecification/ > + * > + * Notes on the the current implementstion. Typo: s/implementstion/implementation/ > + * > + * Unsupported FF-A interfaces: > + * o FFA_MSG_POLL and FFA_MSG_SEND - deprecated in FF-A-1.1-REL0 > + * o FFA_MEM_RETRIEVE_* - Used when sharing memory from an SP to a > VM > + * o FFA_MEM_DONATE_* and FFA_MEM_LEND_* - Used when tranferring > ownership > + * or access of a memory readion Typo "readion"? Maybe I am wrong but I cannot find this word in the spec. With above typos corrected: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:31:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:31:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520646.808457 (Exim 4.92) (envelope-from ) id 1pmvAu-0008Nm-1O; Thu, 13 Apr 2023 11:31:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520646.808457; Thu, 13 Apr 2023 11:31:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvAt-0008Nf-Ud; Thu, 13 Apr 2023 11:31:35 +0000 Received: by outflank-mailman (input) for mailman id 520646; Thu, 13 Apr 2023 11:31:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvAt-0008NZ-AU for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:31:35 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061a.outbound.protection.outlook.com [2a01:111:f400:fe12::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bdaec907-d9ee-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 13:31:33 +0200 (CEST) Received: from DB3PR08CA0036.eurprd08.prod.outlook.com (2603:10a6:8::49) by AS2PR08MB8310.eurprd08.prod.outlook.com (2603:10a6:20b:555::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 11:31:27 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::8b) by DB3PR08CA0036.outlook.office365.com (2603:10a6:8::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Thu, 13 Apr 2023 11:31:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 11:31:27 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Thu, 13 Apr 2023 11:31:27 +0000 Received: from f99560a82f49.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A8043CDE-EBAF-40DB-BC5E-C5BFE48B29EE.1; Thu, 13 Apr 2023 11:31:16 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f99560a82f49.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:31:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB8331.eurprd08.prod.outlook.com (2603:10a6:150:86::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:31:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:31:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdaec907-d9ee-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=agRwrRlllO1RgHAX9L5poJQYfyokSC1xSJJLk9b08DY=; b=IHACNtRS/xQTn7IeqS7UF1Xv6ooMq1KxTGgkdoP9M4XR/iCKcGeubiAVJl9o3jYWmqIAVPEiLUhJGiz+4P6+3He9j7eb4eTPBmDTFDBgaHoORQpcXXqQGcYZ4LDHa3ldr9dsg3VZysmQpWRFCW3DATghLxrbb6Ot0N6q3D3i5mE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ao0EgnI9VQ7baSq1IquIPFnl3f2pvCy5EM8czhuyHb2pWyVWon2KiuNhrVL1gIFV+8hZeLvM1EYeGApMrqX2QzT6hBG+yaNvGyY5byRWR4GWm3UHMjXmq9I3O1/N4ZESeUCP9xRZYHC+LC+nWQFjChxlLYQt0nSFWXBFbL+bdI9tXc+aBefn/zBw0/BTQoOw/UJV9CuzIsTs6q67GwR5YkIfZdilfYsk1k1a5LnaEeweRsAHn8Ne2SHKbwbYn5Mou9NQyhKBuIWi9SG01oCADrMvEeOHmmLrz7Mx/XSByd2mYcLq7hBorDf9d7fjc6iYr3EDJDt41hvQ/ZUpE2Lfiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=agRwrRlllO1RgHAX9L5poJQYfyokSC1xSJJLk9b08DY=; b=ibV+hGLq9XrESRf4wJ3WduIE61j8QrCe5pfN/A4each+J9zPaQheNiVp3atHAmOON+bht5qTZhlJx5YiuVbuuqffCcCwQn7T1nb7gwi1D3JqnSfLpdyimJFDNKCGtKZIEGvb9e2gfsJiOui2oOLHixB2050FM+xC5LpP+mAtQSyDzWXhXfuP/hP22ibCfDnfosTqrrkQHSq6MO41YjHRJ6Tu8rplIOztR1ZxHQnSf+InUgHmWSmQBIPM6Q/YqFQ9YJM2gfugQSuSRM8Ga+WVeXkRMJccIbHr4hUSFMyWUl19rNpRPGDi/l2JnApExNNeE57xZk2hqS/6I7hEZrL4OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=agRwrRlllO1RgHAX9L5poJQYfyokSC1xSJJLk9b08DY=; b=IHACNtRS/xQTn7IeqS7UF1Xv6ooMq1KxTGgkdoP9M4XR/iCKcGeubiAVJl9o3jYWmqIAVPEiLUhJGiz+4P6+3He9j7eb4eTPBmDTFDBgaHoORQpcXXqQGcYZ4LDHa3ldr9dsg3VZysmQpWRFCW3DATghLxrbb6Ot0N6q3D3i5mE= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel Subject: RE: [XEN PATCH v8 14/22] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h Thread-Topic: [XEN PATCH v8 14/22] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h Thread-Index: AQHZbdhGMHWAhk4AakOJfz+iMxVrZa8pGvlA Date: Thu, 13 Apr 2023 11:31:11 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-15-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-15-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 363F3F4C22C48D45998409FFDB132FB8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GV1PR08MB8331:EE_|DBAEUR03FT052:EE_|AS2PR08MB8310:EE_ X-MS-Office365-Filtering-Correlation-Id: df56719b-03a1-4bc7-4105-08db3c129ec2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jgzaqY0KqXRIWSnRBw0lfEFtMwmjrtpNYVEmhmUDeVQx4IRlC4tGJM12rYOOGQRBQvYdMXQgd2/y8FiZlTOc05/oBeGnmpXIKzujGP+5i6AThuZAsleo7Yf2CsnK9c0xvusCozRhg2ICdPNTAP/IMOntSqi6mZ9JL3JsWZOCaIpNf2CygnDrIVjuA5nNhZDtZFWjXPULN0o+bJmJrwcRut3074YbR6xfcq7k9ic436k3/qHvvD0tKsk8AFU1T12ROUFDwkep7YPT1qZOe+LNPgOunRzmIMBu6QeUoJ+Zu0Oz8qLx/39SeiXglmzMPB+MW9KzSJYpjoNrQgbXvyo5HajBjV/8BWHLGU0SPBRbxEhCZX+g5rf4MhkDyKDQ3MA/GvxBhIEPUFBWbbFdCrGAwFkIhTTG5JdtzpVqHYkjUcSGBDM4pbu4+RcK2kYyj/nJ1DQRsyv4Bmah17Y56UKbUE2hBHOlrAAlNyagtsggN+vyHFi2lgR+93usDoO+EYjGDHKz8isyMRLAyzTpbQtv6kCBuvEOkxElGm8jyEZ/uB9U8CXnr0KlsESZZDOPchJrWKdWNpSgHDfk7tIfwVCVdQtEXwTJkndQiVnuiVUQiHRJ35/Kl3u+PHbSwE/lz0LJ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199021)(38100700002)(5660300002)(4744005)(2906002)(52536014)(38070700005)(55016003)(86362001)(316002)(8936002)(8676002)(4326008)(122000001)(64756008)(66556008)(66446008)(66946007)(66476007)(41300700001)(83380400001)(76116006)(26005)(186003)(110136005)(9686003)(6506007)(478600001)(7696005)(54906003)(71200400001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8331 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5c8d7118-a72e-4d7e-38c6-08db3c129515 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kvM8EmC/8UI2f4+YzVniItzuv4Zbn87fdUXrbZWC6IOqqB6ZBC1EheA9bXTXSBzaTDw5QHdCp0w0c5Y/cB1qD0yvmHwDgYFmwj6hpKraPRiJfshYscRZJBNAgoDPYCtHBrAS1dVbJwJ08CW4HLQU6bYbwl0J1lT9u0sj5m25vhaYTrC+6ZdBLVulsMpN3lJZ2rdmWpNUfQn9cLkp+kj+vPOSh4ymAa16ymNnrcH2Qxpxy+cWhYWjDMbi2JPUXIiIg7DVQev2XIPDygLey0VKCMPdLE0s0+jErW1D9yE8/SzFdSpfOrFgcXR/PFSBq34fsnRCoxu0ZwYpCrKFXP22nDsvBmV6nVRxOywJhGfJlTKLMxcrzLkNclxtgQwk+AFS0bAnuvjV8MzqmsFjWPFhZsck7XvG2cQ5cDJkuJX+704ZF8e/A6x8d2/oYwt76LYfmV3YsnsGfXThpJeW2yhAO/BJisfclE30U3m1eanrjbQrpWZo9hutows9sR0X1H1odJ3K8OoaEIv/zdsV707swljCXw3eoUY5lAIiPclbKCCc25YD+ji/cTXuZOxuTW8JSqxyMH0l53G8SCW46EQwLMCIEXsbxgaI1R4azEsN9EO8TByT5rPBK0B4a5FNhIfEUQEO2jGaffo24I2UvUxnQGETllGP7P+pzuAAfGa2P2uMl5VFIHmqEWNvxtq7jbd/odvnHF6aNW0HzmnMtcwoXw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(7696005)(8676002)(70206006)(4326008)(54906003)(478600001)(70586007)(41300700001)(110136005)(316002)(33656002)(86362001)(336012)(9686003)(6506007)(26005)(47076005)(83380400001)(4744005)(40480700001)(82310400005)(5660300002)(36860700001)(55016003)(8936002)(186003)(52536014)(81166007)(2906002)(82740400003)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:31:27.3509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df56719b-03a1-4bc7-4105-08db3c129ec2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8310 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 14/22] xen/arm: move regpair_to_uint64() and > uint64_to_regpair() to regs.h >=20 > Moves the two helper functions regpair_to_uint64() and > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm > specific regs.h. This enables reuse of these functions in the FF-A > mediator in a subsequent patch. >=20 > Signed-off-by: Jens Wiklander > Reviewed-by: Michal Orzel > Reviewed-by: Bertrand Marquis Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:47:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520651.808466 (Exim 4.92) (envelope-from ) id 1pmvQB-0001aq-C3; Thu, 13 Apr 2023 11:47:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520651.808466; Thu, 13 Apr 2023 11:47:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvQB-0001aj-9G; Thu, 13 Apr 2023 11:47:23 +0000 Received: by outflank-mailman (input) for mailman id 520651; Thu, 13 Apr 2023 11:47:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvQ9-0001ad-RI for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:47:21 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7e1a::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f18e9345-d9f0-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 13:47:19 +0200 (CEST) Received: from DU2PR04CA0309.eurprd04.prod.outlook.com (2603:10a6:10:2b5::14) by DB9PR08MB7472.eurprd08.prod.outlook.com (2603:10a6:10:36c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:47:16 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::a7) by DU2PR04CA0309.outlook.office365.com (2603:10a6:10:2b5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 11:47:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 11:47:15 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Thu, 13 Apr 2023 11:47:15 +0000 Received: from b0881e927402.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4EF8F059-50DC-4055-81F9-3256CD8EDB95.1; Thu, 13 Apr 2023 11:47:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0881e927402.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:47:09 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS4PR08MB8047.eurprd08.prod.outlook.com (2603:10a6:20b:587::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:46:59 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f18e9345-d9f0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kldRuhPLful5lckP+1pa4Nka1yK3wWVImOAu6JXy/wo=; b=cFTqr8UH4rcUVKFLHT/+FuL2Bp8UvLA/daG8hLIHfcGM9MBEUhVSMHcy2Am/bZhYON/13upX9T0V5GqQNyTPwtEpzsuZ5mnCNAHKVZFk0cF+A3iIT+bbOhaDed2cmPFiFTf1hHIMRf37RpAgfnoQoxST17PHkKXA1Tk6JXnXfLg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQb0TfzET0VtJ8ScGdEmGsWv+lDOmcRoQPy+dK68L3PXRLFNn+3cpYBHTxha4YrliRhSu3lhKaW+GsRJfaNj51+CJndWdzsV+jTjFUr8p9Fe0MmX8tkf1AUicgDAGy+Mcwu3mkM3GtvX9lcnjkAjrVahpgZtxpZTK2KWeFCqB9ARuCsbn4MZsf7uMDHK+Pp8j9n9IYHceYrsI9SmjMQYGBXP3VFIIFSvIoSfhzWpNKDIpmK6/HMXu4OeD4a7gEnfWJ6FKgeMGIkiI7qcJjMBpM+e6qk5cnvmfog5bpwTi9MeV0SE0JLJCc6FPK1pSgMitZVGGYUddVMuS/WqvAWpOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kldRuhPLful5lckP+1pa4Nka1yK3wWVImOAu6JXy/wo=; b=DaNo9raLfPmNnsNDNC5oFJzNEx/QveKHZxq/UE64F6dBSjBkTB8NVb6cqfpIZntabrZNz8M6ZJ3C+F5P9FdUUtzBjHD8EoIx0203Y95WopmehztIAUUlBZ+k6h77w7eANGwVpMq161pt+H3gUB58ZTLGLDMTuX0LucEUoDADXrfNvhFK2AmmgLVI4cbvu6VAGnuQmSz7qN+O1SXoRj4Nql+fs5HUY9ffKC2AUHx5JJigjreveoW0nhnaNT+j0Z3TNISyJoXvwhrYppS2cvkrMMPtJOLLQI7aE+vpRGmMW+zBKioWT1VdGMVVNYpL/dF6ida/sR7xJhfmMGpceD5+kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kldRuhPLful5lckP+1pa4Nka1yK3wWVImOAu6JXy/wo=; b=cFTqr8UH4rcUVKFLHT/+FuL2Bp8UvLA/daG8hLIHfcGM9MBEUhVSMHcy2Am/bZhYON/13upX9T0V5GqQNyTPwtEpzsuZ5mnCNAHKVZFk0cF+A3iIT+bbOhaDed2cmPFiFTf1hHIMRf37RpAgfnoQoxST17PHkKXA1Tk6JXnXfLg= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 15/22] xen/arm: ffa: add defines for sharing memory Thread-Topic: [XEN PATCH v8 15/22] xen/arm: ffa: add defines for sharing memory Thread-Index: AQHZbdhXhHRhSefTr0SCWhhFgt3t1K8pG5rg Date: Thu, 13 Apr 2023 11:46:59 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-16-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-16-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EC8D0DEB56B5594F85B83D6046A37D1A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS4PR08MB8047:EE_|DBAEUR03FT055:EE_|DB9PR08MB7472:EE_ X-MS-Office365-Filtering-Correlation-Id: b934e56e-f009-4b3e-cdb0-08db3c14d3bf x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FzrkwmufMJXB/sKU2IXKfCzBdVUpdqFXsLnwoLPwYWCy4LJoYnlI8jOJ0NrF+bjlGrxDfgPVt3dC6wTPeG78VXM1weQxTBpO3sOC7YfABYSoD7505YQ53/yMhXaw3++2sCgKHrUyAkoQuc5okcCMkDyOFONE7r10eKRpGKs3tLeJBZwgIxGj0JamYHTTcG/aLak6zqnvbjehGy+m0lyXUodzaKX7zdB3RQhV04RS/xJ2EUeKFnsfJtbC7WLwV8eEn9TvbZhRVXIz1YpOM7tNwWlNin3tEhY8cKbO4eZt1zSy672PSN0tsO/ROfEkUqh4pGi/2zBNDM3qUKRtv0F0gxETIZ76QS2PiVYnHf2D305Tw5rj5gQsq9ptjt/fsjk1itVa4F7A2kVaVTvXOVTGg+4NjUdaD4PRvTETbgbFvZuJwnEfMdWT7L8rrPWT73azltHNPb6YUIp7V7RsToNOfjQwdgnv8wGcoweTXIWBtrk0Cmc8KH0GVg7l0R25qvJX8QmVJ4oywwyenAa6XDm0NqAgrp441im9Zozc2vst+NMk/ESFHBF/+ocI2j7ube0XcD7+1baoZYgq21iudaZzzVV8Osl5A2UuV87HtF/bsi6Qpv6OMD7mVG35/yfF9/eI X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199021)(8676002)(8936002)(76116006)(41300700001)(5660300002)(52536014)(66446008)(66476007)(66556008)(66946007)(64756008)(122000001)(4326008)(316002)(2906002)(478600001)(54906003)(110136005)(86362001)(38070700005)(38100700002)(7696005)(186003)(9686003)(6506007)(55016003)(71200400001)(83380400001)(26005)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8047 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8570bbb7-4713-400c-6319-08db3c14ca6a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mmvWpRSnCggVWBxggvOukhv/EL2tSWDlsCH4xvRit/Pqqkzvj35gphYWrkx4ndQYzcWtSfk8NVwHcFwBT5DmkDhD9QHFb+nLO7GgGdgprKdyYLr6uurYMHJE9KOERPdU/LSuxplWciH4PLhPt6DtmcUyU6OgqrQagTgn+PxIQwvx/CJ7Pci7hd46dp9p2++QaH6P+ylyDlx2f/C45KOn/Ou3dllZli2CgbeE2rNSsP9UgEtVJLFiewvy0Wc+jCt5c7/GU+EDB+XprDVJ6AD/K2MC8krshkZkjqtuSNNw+3fRiBc2idEsfurzf8gAmTRRTf0sX6uEbCxPSGSTRNPDGUZWV61RTF0p5hlgUxHy7FipWXaSBhU3ceacdoH3KJBfkuANZJObr2SEPBqCOd5Gyz9uBNfwLDNhsxuMfDrzoT6WcLartcicohu7UE1XVD+g2jMyyfdsgmVka0H8AIkQcKW4y2Hc5iOszquzfax8JbuAYTrn0l0C8rbu9xbBnIJ8EFxXk29ueyD3VplSQ+1PfLZU9c6Gkm1thwrSioLqah9+mfGVpO/Ozj1sHd2xt9+Tpp4sygv/1MZBMGErR+RxxKoEONg/zM1V7jHVhjajOxH52PwWnAjpedg1uLDNV6Jq7jPvR23QmeVXb0MdPjw+nbDUlw0U110XA3+O2r5kQfJLtS36iBzqfvYUs5YDkaqkg4NUqe5BO1DTOhDusCirMw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(46966006)(40470700004)(36840700001)(36860700001)(5660300002)(41300700001)(33656002)(82740400003)(40460700003)(2906002)(52536014)(55016003)(8676002)(86362001)(40480700001)(356005)(4326008)(8936002)(70586007)(70206006)(81166007)(82310400005)(316002)(83380400001)(336012)(47076005)(6506007)(54906003)(110136005)(26005)(9686003)(186003)(7696005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:47:15.2632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b934e56e-f009-4b3e-cdb0-08db3c14d3bf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7472 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 15/22] xen/arm: ffa: add defines for sharing memor= y >=20 > Adds defines needed for sharing using the function FFA_MEM_SHARE and > friends. Same as my comments in previous patches, I would suggest to also mention the references in commit message. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 60 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) >=20 > + * FF-A doesn't have any direct requirments on GlobalPlatform or vice Typo: s/requirements/requirements/ > + * versa, but an implementation can very well use FF-A in order to provi= de > + * a GlobalPlatform interface on top. > + * > + * Global Platform specification for TEE requires that any TEE > + * implementation should allow to share buffers with size of at least > + * 512KB, defined in TEEC-1.0C page 24, Table 4-1, > + * TEEC_CONFIG_SHAREDMEM_MAX_SIZE. > + * Due to align issue mentioned above, we need to increase this s/align issue/alignment issue/ ? > + * value with one. > + */ > +#define FFA_MAX_SHM_PAGE_COUNT (SZ_512K / FFA_PAGE_SIZE + 1) > + > +/* > + * Limits the number of shared buffers that guest can have at once. This > + * is to prevent case, when guests tricks XEN into exhausting its own Typo: s/tricks/trick/ > + * memory by allocating many small buffers. This value has been chosen > + * arbitrary. Typo: s/ arbitrary/arbitrarily/ > + */ > +#define FFA_MAX_SHM_COUNT 32 > + > +/* FF-A-1.1-REL0 section 10.9.2 Memory region handle, page 167 */ > +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) > +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL > + > +/* > + * Memory attributes: Normal memory, Write-Back cacheable, Inner > shareable > + * Defined in FF-A-1.1-REL0 Table 10.18 at page 175. > + */ > +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU > +/* > + * Memory access permissions: Read-write > + * Defined in FF-A-1.1-REL0 Table 10.15 at page 168. > + */ > +#define FFA_MEM_ACC_RW 0x2U > + > +/* FF-A-1.1-REL0 section 10.11.4 Flags usage, page 184-187 */ > +/* Clear memory before mapping in receiver */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > +/* Relayer may time slice this operation */ > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > +/* Clear memory after receiver relinquishes it */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > +/* Share memory transaction */ > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) > + I confirm the values introduced in this patch are consistent with in-code comments on top of them. Thanks for the pointer :) With the typos corrected: Reviewed-by: Henry Wang Kind regards, Henry > /* > * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: > * BIT(31): Framework or partition message > -- > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:50:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:50:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520655.808477 (Exim 4.92) (envelope-from ) id 1pmvSn-0002sP-RH; Thu, 13 Apr 2023 11:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520655.808477; Thu, 13 Apr 2023 11:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvSn-0002sI-Nf; Thu, 13 Apr 2023 11:50:05 +0000 Received: by outflank-mailman (input) for mailman id 520655; Thu, 13 Apr 2023 11:50:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvSn-0002nV-41 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:50:05 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20612.outbound.protection.outlook.com [2a01:111:f400:fe1a::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 536c908c-d9f1-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 13:50:03 +0200 (CEST) Received: from DUZPR01CA0078.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::20) by AS8PR08MB8733.eurprd08.prod.outlook.com (2603:10a6:20b:565::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:49:57 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46a:cafe::b9) by DUZPR01CA0078.outlook.office365.com (2603:10a6:10:46a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 11:49:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 11:49:57 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 13 Apr 2023 11:49:57 +0000 Received: from fe975fe53355.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FA495623-D270-40D6-8A34-9D226E5F055C.1; Thu, 13 Apr 2023 11:49:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fe975fe53355.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:49:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB9387.eurprd08.prod.outlook.com (2603:10a6:20b:5aa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.42; Thu, 13 Apr 2023 11:49:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:49:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 536c908c-d9f1-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KENF3SNCqPm8wKQyaXsksLT5Ho8kPPZq6WXd2priraM=; b=zVTsnV6uWLmr6km9bMLi3bO8BMY6XkYuP3s3M1EGTbhG9yHwkU4LipazsElv9lTYtP6fCJoZYo7SHDMIT1wD+2ye41txPc1qC8GCtM3y9LUR5wiQVWu2Cwnc0oPQ+ac7w5w7LpcQZiU/sT9U+b3Gk5wMpaRg72Cu17nYKrJBuAY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=edmPGFuwO9J+KypHiLoVG0aVPJkRodKolRfHjb2GanqC3b6MeZspAHe1ah17XLayVnjfJIQtNYPC4wPSt4vgXGMZc3Np+1/WXe0sws6AnELVzGw8GhTeqFYg/b5traqFo+vKzgb3UCKRwNv4B/9EemH2iyNUnnJizey057W5W6myX/GBmSlNVrNwEKISOMa+1GPE5MtqprHn3SRSf3kIkpnQ7s9yzXTY8O3KQ7AexfQPylx3xcwT1RYqcmjqXyQbDzbil+ayL4DNgWUTY3EYoJADT2ksIjCB9fyjeNltYLpSMyX/geG+1RqMauNPVjt/7XadpKBPRUHZsGqkEmnvRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KENF3SNCqPm8wKQyaXsksLT5Ho8kPPZq6WXd2priraM=; b=DcSjNa1ULkTMOtL5Y7r2zqfcUpuwyAn6kQZYf95a9eye51MUSETnpazEBY5ckEXTIOr3YtsnuxxvcXgi1JLV8qZ+NGMTmLyP4Gf9aiswQ9nsIUJL7Dq499uhKhWpEMWrPCfaIhCagw/vEKLDjnl+nJMfuuCfu/wGRF29lGz8BNDpUU55HYo0ytf3aaEmJ7N2kGN/pIIdjNXkFsbQDL5fuk+A0QeRhNUfgzkqyeiCuGpC/KS2BxybI3LcX0Zed6EVsAnhszdJk2eJQDW1Rbp1B+GF6M6JG/44ECgt+B33D99jvhtD40NhViSzEEMRVrB3cuoBDaZdrrLuHuhXwGncjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KENF3SNCqPm8wKQyaXsksLT5Ho8kPPZq6WXd2priraM=; b=zVTsnV6uWLmr6km9bMLi3bO8BMY6XkYuP3s3M1EGTbhG9yHwkU4LipazsElv9lTYtP6fCJoZYo7SHDMIT1wD+2ye41txPc1qC8GCtM3y9LUR5wiQVWu2Cwnc0oPQ+ac7w5w7LpcQZiU/sT9U+b3Gk5wMpaRg72Cu17nYKrJBuAY= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: RE: [XEN PATCH v8 16/22] xen/arm: ffa: add ABI structs for sharing memory Thread-Topic: [XEN PATCH v8 16/22] xen/arm: ffa: add ABI structs for sharing memory Thread-Index: AQHZbdfWFMmwO7dS/0GyxucHcZRHm68pIDaw Date: Thu, 13 Apr 2023 11:49:44 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-17-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-17-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BC511DC5E2FDEE4F8677F399D504E0F2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB9387:EE_|DBAEUR03FT026:EE_|AS8PR08MB8733:EE_ X-MS-Office365-Filtering-Correlation-Id: 3db85b56-7abb-412b-cfe3-08db3c153454 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vUe7HQ0w6R8lutg1HQ4KUtOc2ZVBc33mMrjsmSFI8ZobYzMaQ2R9pj79zBRfhcfAV60Fe/ansOdbmcXJcjarssDVLy7O+1mxpwPk/B8cNHIKd7hYHUd+6NbQZFTgL7f1xTmYng0NrO4gwQRAufe8BrKUYKltmGQM3B0zF829b/VgzMD3tc6eNDyl0Wrnk1TiSIYtc4A00ZQIrE6ykuAS0Gurh6VaLKc412/4K17zFYr7ecszbbfSkXKDCzhf9cflysqvf8IjU47CQVGqxw9C64RLW76x9uBmDuWEhd6aKPKbqcMgzBctxptbIfHjuGSQ5KMpaWQDPtU07K1Rdwi83adpmUX9o2sCkvJPhdgW6EDStBBS3UNW93UoERs4mFvYMg4pi1l8NvgxMDbtiMpWYurEnVoRmT7vgnTjevUqgvhmNxRH4RHsxFvwoFrH4C9nbX1vfWr7R98YLJqabFKxR3wWjWezuhue4rsg87deYxHYo5wnpC4EvhOSBo4/h5I75kUGsgihjMXhk3VRBq76UDE+ZPzPwdd/SLFRyJqOpfAjwL70oMqyOuG4v4JtoYWsHeVCsyTqqy5QtvKx2+mIJP+QufnqqXsXK9OGtUJzAC3SyeLuK44NamHS/oojIhLD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(376002)(396003)(346002)(136003)(451199021)(86362001)(186003)(33656002)(6506007)(9686003)(26005)(38070700005)(2906002)(4744005)(71200400001)(7696005)(83380400001)(5660300002)(8936002)(478600001)(4326008)(55016003)(54906003)(52536014)(316002)(110136005)(64756008)(66446008)(66476007)(66556008)(66946007)(8676002)(38100700002)(76116006)(122000001)(41300700001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9387 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fa84e76b-c697-4f61-9724-08db3c152cb1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZdkISEIfWy3B7DIL24Maa4gYurqAZAhu9ntM94M7FjkAb/F1O0M4DBlCrR2rWiJadjBnzJ1wZSAK8GKhAbL1+zzibpsoQKJQantcx/HzjTAZpcGwe9K/P/VauGAKGAs9jp9wTsr8mxF0mWyx4iaqUlGNhF49nvQSPxzqUyqqRj2fp26+cUx/Q412i3/89qmH0KGimj7jBztqNbDre5JGaznMffe4vLnTffrKf4brbRi1/4XSqvVutrizPtCPxpyFWMfAoKYx5wubro5g/wYR2/rYfgdKALq4pJEe+zCjeh/YuORDjOmFXbklDxGeZNeuYpplG9Ax5UZcA70zf41JdMQeXQ2o9VVUsZP/rGS1qv3EtNOvRb5KaxdoNepeshY1qelHKRApaAOubr3pk1wmDvnrcjZh7E3F64lD8nRPXCjEfk81PBgtanMxQNAdQJixHlA+p066zsQT3EIqR14eI/6WEYwnDYYMsJqLQr4u1yOKl+lQSgtk0JvnGRhXZ/Bc9IuFMQgChYWKf0Ew0eVREY3kcnaaR6gS4FAxQ+0WEMmwRLpAe1mgrTFQ74eqqAk7bvu97vRq9pRXjainT0bxVbTrmwHbl44GfS3cmg+yq0EYwSqPDgrX9Ck4gcgQ2hjhlaXMW4A8n/oSmtwokUA2YeCsSKDOAqgObNc0L5dLFk6zVOKfo1TPJ2Q+P/B9mEVhCVEkWh0UYENMKElnV8FLcw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199021)(40470700004)(46966006)(36840700001)(40480700001)(41300700001)(70206006)(70586007)(110136005)(478600001)(54906003)(7696005)(316002)(4326008)(2906002)(4744005)(40460700003)(36860700001)(83380400001)(82740400003)(55016003)(186003)(26005)(8676002)(8936002)(5660300002)(52536014)(47076005)(82310400005)(86362001)(33656002)(336012)(9686003)(6506007)(81166007)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:49:57.2854 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3db85b56-7abb-412b-cfe3-08db3c153454 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8733 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 16/22] xen/arm: ffa: add ABI structs for sharing > memory >=20 > Adds the ABI structs used by function FFA_MEM_SHARE and friends for > sharing memory. >=20 > Signed-off-by: Jens Wiklander > Reviewed-by: Bertrand Marquis Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 11:53:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 11:53:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520659.808487 (Exim 4.92) (envelope-from ) id 1pmvW3-0003Zh-92; Thu, 13 Apr 2023 11:53:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520659.808487; Thu, 13 Apr 2023 11:53:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvW3-0003Za-5l; Thu, 13 Apr 2023 11:53:27 +0000 Received: by outflank-mailman (input) for mailman id 520659; Thu, 13 Apr 2023 11:53:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvW2-0003ZU-2F for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 11:53:26 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061f.outbound.protection.outlook.com [2a01:111:f400:fe1a::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb767ea8-d9f1-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 13:53:25 +0200 (CEST) Received: from AM6P193CA0041.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::18) by AM8PR08MB5796.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 11:53:13 +0000 Received: from AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::ec) by AM6P193CA0041.outlook.office365.com (2603:10a6:209:8e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 11:53:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT017.mail.protection.outlook.com (100.127.140.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Thu, 13 Apr 2023 11:53:12 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Thu, 13 Apr 2023 11:53:12 +0000 Received: from 96011df6c354.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 04D84B93-A4DA-4053-807A-F56D9AD4BEA8.1; Thu, 13 Apr 2023 11:53:06 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96011df6c354.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 11:53:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB5453.eurprd08.prod.outlook.com (2603:10a6:803:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40; Thu, 13 Apr 2023 11:53:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 11:53:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb767ea8-d9f1-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AwTaoUcDceKDe8aMgaY2EUZfNFklPvhP/ajqp4DZwok=; b=HF/kp3u5ggsfjTwQ1syyCTuBduzU3dm+qwfWiV0BRnLIXZaUVeOWqahz4Bg5ZrMxaLGCB/K3qN8c5C4FbLDMEuUR6wOxpatUshVGf3dOh1khle9x0xyCRyWuXILayaouvnou4gIlNs79Q7AoBlaccV1C78ofphNNnwEnJStSio0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aU1WK6+EslAU1x5zyfCxZed8okzchAQ+dOt23ChPE6bgChAmv2buxJKzrZaCw3iv/ccBWNJavuc57sfDVKRt5olSuG7NP4XfSfEjlUPP4C0PYhV4dqXpCzFFCJe3Xpg7QnrrIWfF9tjMq6gvRYbAVQZTWrYU/HwP9qodMPpeCYmXh8vhm8TpsLvWiXMwR9V9+zumk30Wlc+xd+aIQH2LYvLRqu+zxuZhT++5itl2mw98jlR8KqBJLzFRx8gtNbhfbRf03sohbcl4NAZIwNvNi9ntwD8VgP89cyqwvhyudz/NMy6NDRsRYU9Gr+TwZDRHcFzfNN96oMg2Ou4g5RP8wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AwTaoUcDceKDe8aMgaY2EUZfNFklPvhP/ajqp4DZwok=; b=XkBS6gQCCeqTpb5H7hauWC9QXsP7taFtmqPpGO+uVqpDkea7E5AWhDhP4uYFflSRKfJYQ3wLcI83BLfLht0upMtRcK+cdkJpoxloFdildS9eozRF8TqwLBj243BFjwTo2OHrQjdpmUqQd0XHFrGUNku9oqxBiOg1iZSM/ZWMbQSIf7F3trCW2azAP79pV66Ih9A9rbUa2ux4mjLIThJlsQWmXXpoE2j6HGkVA42Rz0tOTNeO6rBWhKJ5m5gsDAmxPeJYpKzf1h9XvcoSstNNVTDm+qSeAmI4Kl/rugxdUdY9sYfeuUiOKH4For9SACV6lNGhUixved4a08vPS4VsOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AwTaoUcDceKDe8aMgaY2EUZfNFklPvhP/ajqp4DZwok=; b=HF/kp3u5ggsfjTwQ1syyCTuBduzU3dm+qwfWiV0BRnLIXZaUVeOWqahz4Bg5ZrMxaLGCB/K3qN8c5C4FbLDMEuUR6wOxpatUshVGf3dOh1khle9x0xyCRyWuXILayaouvnou4gIlNs79Q7AoBlaccV1C78ofphNNnwEnJStSio0= From: Henry Wang To: Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Wei Liu , Anthony PERARD , Juergen Gross , Bertrand Marquis Subject: RE: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator Thread-Topic: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator Thread-Index: AQHZbdfU80uw6OSkAUuNnMAzzeK71K8pIJ8Q Date: Thu, 13 Apr 2023 11:53:03 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-4-jens.wiklander@linaro.org> In-Reply-To: <20230413071424.3273490-4-jens.wiklander@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 25D1E2305DEFB24E8474D15D83D5F973.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VI1PR08MB5453:EE_|AM7EUR03FT017:EE_|AM8PR08MB5796:EE_ X-MS-Office365-Filtering-Correlation-Id: 00cf5b37-18a9-436e-72bb-08db3c15a8ac x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OX1FC7UdbzWPDdCmgdVPKQJ53K0IpF9hC6etv2w18sS4SR9ILoclnSjTxRcHc6NoxiodFTFM/OCj8V6yk4QqdUIJDlE9cRLgu72vp6dwraRj7jUf8/3bUHCMykUtvt0YrqpS0wN5myI6E76Vwf/DB3SMz+OhcKIU2r/Dp2yrBmZTt3d0bPtSXhkCAlptYhVFpLm7WvzdFpk1l01nBwj9p8jynO3Reey1qHPzTt5WP8hboL9ePdFM2yZ486jRljhJoFkw5qGXvxoOMlKZIs8nk5OuEVXNydekIZsose0nlTbcjoySoH7uycmEk3iJpT1HugpWH+4ot4OW7d9S4Sw4hwhPR89SyiSZ6ZsEiJOr0dXGnVzK2wQmaniYi6X1Kh/Fm8lXL2L6TFZZacGCs6e7gsHEQRuT7DY9PJJhJ63fn/1018kSVIYSpiBykT8b/SfxjV80ihCDEY9VqZHg1qOADKCxlUPU5nvhkkYHPupKLurfloU3JoWZBiG6e7JK3yEF9Cbq0TuK6zgnQYI+/PQZf+mrDvUzDEhEunD5r4+tKlY38IVclSn62qs/xfnz8dGSV+Eu2GtAM2NhLz+DR6lK8WBhIcTwJ5KFNYThJYTToMNT1J/vNGliFmDWM/IkYycj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(8936002)(186003)(52536014)(9686003)(26005)(6506007)(55016003)(5660300002)(4744005)(122000001)(86362001)(33656002)(478600001)(38070700005)(38100700002)(316002)(83380400001)(54906003)(41300700001)(110136005)(2906002)(71200400001)(76116006)(66476007)(7696005)(66556008)(66946007)(8676002)(4326008)(66446008)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5453 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05301706-18e1-4fe6-a7c4-08db3c15a36a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hZGma7JOomUUAAfHVFIc1A610LLeAMk7dbVAHEwrZqI6lJh6Mp7SxE+OfQzSWT7WO8QUH3/M2Qe617tXXYyOuBUur9Nmzvj+oGjcYcZzp6P17EwvoDX6k7TjcAhZ3TLh0p+AUwG9MYokmcWxNKM17Z1LGtpkQimYH2sL6lKD2pGpJkA/UttsPJYJr5hM1MEc0hVX2f4nSJyXzrx9uCkl7ic54skKCoxZDuyEFYMqUtsKmScXYCJnMJiJ/ELznCsIsvvrSVNH+eG5iJZbZiHR8bVWOO1pt/AzXrPaMjqz4pvptfn6eTr4kUH8Hew6I/cgZiqMyt2kq7WJgA5pL3wPQUJyYFbTaP+zOtHRLM4et4M2W/28jU1blMKqVgzZtvxij6gICgA1cdWMD39C5/pb0eqZ6NzdepM9jkwpwbUiSWyfNifja+jE5RAc6x/WLQtuhJ8wa6TMBGIIAJpBWwT+BjGSzOyt+WR7OK42X1qzFNZwLuHU3r6mH7K3Kwk5m1JIURkal1mu4FUIifWjR/0Iu6lumcoRoSI3CX1c0JpLnF8S8R68aZG/E8P+XmBmudzb1XB/YP5+Dii+/nW+bcXHc/TAjUFk7pqNPzfj/a9Io52ZeHIrJrUN9PJqa4qKgcs7gMaFa74Tk4rKx9QCuLaM38O2llijJefpBwYzS4iAmdqmNlb4UVCS7Z4WxhMGjx9ygWZ4D3/OY1FDqKnZzbzZtQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(46966006)(36840700001)(40470700004)(8676002)(8936002)(41300700001)(5660300002)(52536014)(4326008)(81166007)(316002)(356005)(2906002)(70206006)(4744005)(70586007)(478600001)(54906003)(110136005)(86362001)(82740400003)(7696005)(186003)(9686003)(6506007)(40460700003)(82310400005)(55016003)(83380400001)(336012)(26005)(40480700001)(33656002)(36860700001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 11:53:12.4285 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00cf5b37-18a9-436e-72bb-08db3c15a8ac X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5796 Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator >=20 > Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a > guest is trusted to use FF-A. >=20 > Signed-off-by: Jens Wiklander > Reviewed-by: Bertrand Marquis Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:09:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520667.808497 (Exim 4.92) (envelope-from ) id 1pmvkw-0005FD-OF; Thu, 13 Apr 2023 12:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520667.808497; Thu, 13 Apr 2023 12:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvkw-0005F6-LR; Thu, 13 Apr 2023 12:08:50 +0000 Received: by outflank-mailman (input) for mailman id 520667; Thu, 13 Apr 2023 12:08:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvku-0005F0-VZ for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:08:49 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efb02f32-d9f3-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 14:08:46 +0200 (CEST) Received: from mail-mw2nam04lp2172.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Apr 2023 08:08:43 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6256.namprd03.prod.outlook.com (2603:10b6:a03:303::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:08:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Thu, 13 Apr 2023 12:08:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efb02f32-d9f3-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681387726; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=NyKC7ful0tmjXCvD/cE0aEjeiVra+yd+nIM9MxeMqkU=; b=VvNWghZIFUFSCtiBjYSuzW/iijYXUXaT7QKG9ij5p9tlrq+UeiQYd7/w 5MmQeONamTB4GONJE84Lo/7h9MPdsGVd6mBwaYq/9XLVZBSjqukwMNMly SgZF/tphqiiShybjDKdCEem1Uf//OGNibImOo6yP0z6kptmh/OmNNTFOg 4=; X-IronPort-RemoteIP: 104.47.73.172 X-IronPort-MID: 105401415 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Dr/FlKoMvLn0YMDuFv1DM76j8EZeBmI1ZBIvgKrLsJaIsI4StFCzt garIBnXOP3YZmOkKYtybd+z8UgA7J7RzIQyTARk+ChmF3gWpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weCziJNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACAvdzGAgOWa/Or4evN8lJw9NOXxP6pK7xmMzRmBZRonabbqZv2WoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+OraYWPEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqM22ATPnzF75Bs+e2DgvOurhk2CSctaE 0Uz8TYfooII3Rn+JjX6d1jiyJKehTYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ n2jks7tBDdvmKaIUn/b/bCRxRutPQAFIGlEYjULJTbp+PHmqYA3yxfQFNBqFfbpisWvQG6qh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:BMPltqFwDClf4LpQpLqEMceALOsnbusQ8zAXPiFKOGFom6mj/P xG88576faKskd2ZJhNo7y90eq7MArhHOdOkPIs1O6ZLXPbUQiTXf1fBOnZowEIcheWnoRgPM FbHJSWY+ecMbEVt6jHCHTRKadZ/DBSytHLuQ+jp00dKj2CE5sQjDuR/TzrdnGe7TM2YKYEKA == X-Talos-CUID: 9a23:DprlHGFsl3B0pquCqmJ31lc1GcciXkGFj0fKM13gF35FUr68HAo= X-Talos-MUID: =?us-ascii?q?9a23=3A3k36jAzomZ2ZQt9MNKnSGsHURcCaqIqVU10fg5k?= =?us-ascii?q?Fh9udMBR5HDyBvTudeKZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,341,1677560400"; d="scan'208";a="105401415" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0Jjc31Gti3egFW9Qhs5dLK/uYaUJ+c0KGrWoyq7mssKd28gkDNpe0j+8y2Ph6MOSgvVErAyrpEBZ61fY1UjhhKiqs/0WgYeVBn2G+7dIU9+8qT5F+ka19qvWbYo+J7dATxz6zUscGpXE7Ox40CuGOaYISfWV0fjJ0N7K0kE+Fk4SAqIDc7n7abj3Zvk8BwpQ3db7LgB95jA0n8G4vT2q6LkZG0RyVeqPGHIp+yV1C5PGLljpCFqeCWJfPwUZJWJejuScXZOHXY4edXrOgjN7eM3aYFPg95o0sud76W6XUDBROuhEpUQcxsbqpkiY+ZaSprnxU3y0ZoOGHF9y2BbhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7KazW/e7IpADiN0sjCBUE50+wnvHb9vU6fgRXtc6R2I=; b=g6b+TQ/AGvG5TOKj0WwfPpcv+ibqPDmqpduMmUiIj4t6KOBcx905VIsMIG8+gr0RQLq1guUclNUN6hoqXMMeboHeJDClIiO8Ch0KFJ0yMnP0NcWSMEG7j09oWKeaKkYybmqn4hp7vHmEvsy13JJ2dwBhXo8QKgzTo6zYzLqtg7tCpL7m2Wb0fMo0g6skMkcV6Om8n5yk7HKaz1+9Dn/frEJdCRV+udA6q9CQ6fHQhhP0U/CyJzAEbgN6eQMinf1G20q/Bdhn/Cp9BdjMHT+dKhg+Ge0KBIlVoe1G3ZQLCPCA91hwBqP8xCU+zArBhLrecVxZLD0fOYOpRC6GpybJyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7KazW/e7IpADiN0sjCBUE50+wnvHb9vU6fgRXtc6R2I=; b=qc9Ogh0x9VlpZXe+Olxeah7lU1GeTlpn2Z8EouGyRuh1GUF3kVRI/js9IOIGormbqyp8Rn61Nf0nAKXboThEEibrDrpedN8o2nyHrO2fU79YrbG9luzJs+iIecA9i40CI3UxSlo186EueT/LP6ptRRttoKrMpfrdEkUSkAIPcBs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <71d52d94-806a-7919-72f9-b8e42e34d146@citrix.com> Date: Thu, 13 Apr 2023 13:08:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] x86/hvm: Disallow CR0.PG 1->0 transitions when CS.L=1 Content-Language: en-GB To: Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230412183519.2996902-1-andrew.cooper3@citrix.com> In-Reply-To: <20230412183519.2996902-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0079.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6256:EE_ X-MS-Office365-Filtering-Correlation-Id: 73330da1-9246-4348-e6dd-08db3c17d180 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1flO0QNeJ22avbbqDKcRGqPk/wB8CD1JqXRs44EUSz50hJcec2pPBnqTAAH9Zd0GWsT2z3WVLqfr9h2ZND9PN0CWdmm3s3OcgD+t3f2sD63UK/XvGa5FKIkZjHf85q5Bx3jSif33XRdXYyGLOOXiuS8Re255R07Dn2P/MxHloBjjACytvzaRZstGgVcRMu/K2cTIFnQdI9npCObqXn/eIP1zj/Xt+6Bgm2FuDFTruDLK9BllEIHgiduyjmQOCHQ0MXFtjEVkFnnatboY1WDih58UtpZ1u8NPmPdKla2oWWEgKdYuji3v/L5kgbrtNtDMQmYZQtIZABFnaLuj/bEKrcFbWT3GtH4V5XKjlwf2L+DUTG/Rti5aHeL/l5C2lI5flmG8bHWyx84QwMLiXHbXG3fmwUNMSXWaxbNj0pkz0m4WKu9rey9w/8d7FXHKNrEcpNFGcix20kmzrAITyM74O/6A+DJzx0wR6+rzUMo7cDMYY3n0mE8TL1hxL/MDrd2JRY2+Iajb0R62rHnGy7HLJ5l1z1Iermq2MH2y2MzDSWu/U6h7jV9vS/Irtn6TiQJZ5VwpK+u6KdUXAHDcA12jXtRLUv0w3tO04TojCS/uAXz/lX9PSt5iixrQVcEcvz64+lXy9mIhPQXeGaQc1ayYEA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199021)(31686004)(38100700002)(5660300002)(36756003)(2906002)(31696002)(316002)(8676002)(8936002)(86362001)(66556008)(41300700001)(66946007)(6916009)(66476007)(82960400001)(4326008)(2616005)(83380400001)(54906003)(6506007)(186003)(478600001)(26005)(6512007)(53546011)(6486002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2F3UjlmamRuOEJuNUxCMjN3ZU84eFcxbDJBUG5BdUxnMm5hTWJ6TWFPY1FW?= =?utf-8?B?Ym8wZVZ4QWlRTFF0YzN1SnYyaFlCTUF4dnM3Tm8raENkV3ZYZ2RGR0xHU0VR?= =?utf-8?B?aWU4MWRndlFWSzZmUjU0MU1qV2ZrRU5RNUtIU0JyTXhDOFdNM3NOSXhEWnBC?= =?utf-8?B?S1JNZ3EyQ25MSUltS205dndYcURwN3RFc2dFQ0hxUzZKbjBUaVp5UHBDMmh1?= =?utf-8?B?WjdScFVob255Um05UW5VQXdaSzc0VDZXbHFrUFdKcjAxRTVyajZmdTV3UXhr?= =?utf-8?B?eXhxYlN6SnFOTCtJVHNmRjhWR1BFQ2dDS0xrVDRwcGhmZ3JUQS9nT3c5TURk?= =?utf-8?B?cVl5MVA4WGpuWWhyUFUxaStDTHFkVVM0dzJXMVQvWmV1UENsTUp0RXRPNjkr?= =?utf-8?B?WGpONlJYV2FMYWYwYTNiNnprWkN5MkF2WHBjdlZ5MGFkVjVjSjN0WkhVUXJ2?= =?utf-8?B?OUJ4TkZ6L240bDcva0ZwQnF1dk5VOWgrRTNBTWJ6d2FsdlNzR3V1TzM2K3VE?= =?utf-8?B?SDg1VGFMYXM0b1pIM0x2RmdzbGR5YzNQYUVRYllFcCtoV2xzazhiTERXNUJM?= =?utf-8?B?OEQvZVhORGIyQ1NaTkR6NU1WTVZrcEEwUFFOV2N0NlZNQVNrd3Y2clBxM2J5?= =?utf-8?B?cTBXdXFXUnM3Ukw2cWIzM0E3WnpWNHRrRU5IV3QwNFhUak80WWZ4UEZXQTEy?= =?utf-8?B?aFZPQWxiZFc1V3AySjJjM0hYUkpYS0hiUGFXZzFFVlM0NXdreVlJMFdWTUFY?= =?utf-8?B?bFdqVEJsV2FkQ0hLMkM1dEFBbGVyK0h6TUR5dWtKdlpoa09DdzlEVXluenQ5?= =?utf-8?B?dkpCWlFOeWo0bFlDa2Q5NHFOcFl6V01laWZKZXpBVHBLRnBVTDQ4Nk92ejRl?= =?utf-8?B?bTcvT0E1czZPbWNBZk9CcDJ2M2grZnkvRUZFTW1BOCsyUHl6anFlSVc3OU9D?= =?utf-8?B?TThXQnRPZGp1R281ZmJVYU1lTnhUUE9WZUY1OG1rU2NsN29ERHNvZFpvNGNa?= =?utf-8?B?MmFzdzBUdXRCZnFZZUNaUjNyK2pQc2JNdXhoYkZGY1J3TWNJUU1oZXF3VEVS?= =?utf-8?B?QzdwSkFwbEVDOTVPK3FmYWFlaHRBaXlyZjV3VGNzNHdHbjlnRFlWN2d1a2ZP?= =?utf-8?B?WWtDT0xiODRVakd3M1hDeUVtWEcrOE82NVo3bDRrVVhXbGpYYmU4ODBhMmJE?= =?utf-8?B?UkRrSzhBSytuS0Rna0UyRmUwNlAyTWJIaEVSS1crNWJhcDIyRm42OTNpVk9p?= =?utf-8?B?aGM3amdCallKajBYOGxWdkJxV0RxUnhWUUpiOWxnNnZFcm8yRk95M0c3TURD?= =?utf-8?B?K2ZKMDRIbDlKVE9ZeWR1am5WS0E1OWxtbjBqTHRhUzRJd2hsdUp2V2RxWFpB?= =?utf-8?B?OVdtUXVyV2ZUTkVkdTNpbDgvZnRQdVN2UHNHUzRFanZyMU9DLzY0RlFnb1FR?= =?utf-8?B?Z00wa2JaQ2VvREZ2Uy95dHF3MDlDVXd2ZW95bG82ZnlsT003UkU5MTZpM0Ri?= =?utf-8?B?K0JpeUp5eEI2U3E0STR5R0U0WjhKb3hYRHA0YS9GUFRDVlhNNkRlTTZLUzhZ?= =?utf-8?B?K2NVOGFYYThHOWlTL2xVcVRmWURVQ2tqdEtmUUFYL3RGczMyYU1UekJ3MXRQ?= =?utf-8?B?TVNWWmdBTFduRitCRzc3V2hBaS9IZFZ2enBPWkZEMG1wNGo3TW1DaVNSNjhB?= =?utf-8?B?SG04d0g1VTNTVVpnYk4yY2RIMzdKOG5vNmc1VnVmVm1CTDNPcHpUQ0xUREJi?= =?utf-8?B?cEVFNU4vZU01MzJYSHVwdVBiWDNXa09aa2s2NFZwNzZXVlFtV0FnL0FLdXF3?= =?utf-8?B?SWVaYU04WTBRYUgwNkpGbzdCNFJuaXNpZVV4QkREa1dhWitUMW4yZHdDM0Uy?= =?utf-8?B?S2FVTFhyODFmeXBieUtqQVN4WWdhdHRFSzJ1K3U0V2NOa3N5UGtmUStBdnpX?= =?utf-8?B?Y3JjNlpUTWJHUTRzVkREdFdpcXJhdFdvWE5zNXhhckNmSnU5ZnFKR1dCakFy?= =?utf-8?B?WTdvdzg3MkdOMHpXUEpZTldEdGZCNE9qeGdBSHl0V2J5Mi9uNkpPbVo4V0JZ?= =?utf-8?B?aXp0eEdCM0w2YWw5eGdKTUdEME5RUnpjYzRwakJmT3hycXR4QitHTjFlT2pT?= =?utf-8?B?b1gyb0k4WWFGckpqaVd3eDJQUEhQYS9GaTRuK2pjb25hOFpGaEN0UzV2NndS?= =?utf-8?B?REE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Zrz4U+umDLZX/Xma6Ts27+20V087EZFF2lkkhdwiUiIjPAmOdgVE8YoOtKCC9ekdTr0YCGDwP2DEKclAwqwqjrg1TxAUeAMet83mv0Wpc6zDAVoiCqQNKCdZXspCA2cTIcf70UDksgi8RBoWXw4YLBiYjmYOtuaan0r75ho+fLn4XJHewRVLjAbW0Xh+hZRq8Gb6EENEJ2BwmHN/vDT3WbNvWXagJG5tQI+G+Iytg8H27K/vcRK/MuRVDUY2xnnUqb/2cf4rU8j+jQtRKamf6nrzv/SEkz7+iTFn1/TJ8qPH0QEC55q5ZjWjocCDVjNbet5wJx2q1S0mqHn0gg2/jFPkM8UksicM0KhljFw/jj2S98kM0Rw1xpeFCoxZzftJy2CcoOE7XhegBjwHCi1ikRiY/jVEiTzM1fj/ZxLuwHuTb0sZTsRDWWB6R1gAL5/4icFsHNgl8l/P9/woDwxjvEhwpf1rGiQt/8QvKoPGvBB/FDU+8Fgriu+8BdGWT5jeJ9unZl2BEULovDOVM0ZgKDB3iqa7qI07b/uLmyYj504ZLa1VRHYATg5SzqZ2LZMYfykhPZH/n3ElfWvQ7PGAS68kBr/abUPR5GdshJKZtOUBpFNVipjN0Uk7FcTCAV2k4Lt9KYFeh6ImyGsoYC5X2BquDeNloCkyv/8Y84Spn+TJihJrqexY6O3x5z98kC2gtZ6+usTgPi66doPnyMxWRorpq53lRRnImUzTKcMveHfK34qATSRXOVisqB1nNuq7Y6vY5xfXODLgVQ0MY0RMnmCrQq6N2++DX7bhTT+0hkw5Ybuk9qbsbMTKRJW+UWacejI28bNQ+V8AVfT0nsmxRQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73330da1-9246-4348-e6dd-08db3c17d180 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 12:08:40.6961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sMCjrPNhhmdBpGEQRDvqBf7im0950dV6c83rJWncdESmvrOYpnJJuwapz1pIq7nZlkVVnUBxEJs/ovUjZ14ta53ef8hFtnO0IAbHQZM+qtU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256 On 12/04/2023 7:35 pm, Andrew Cooper wrote: > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 1454c1732d95..3c8d28a2d8be 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -2340,6 +2340,21 @@ int hvm_set_cr0(unsigned long value, bool may_defer) > } > else if ( !(value & X86_CR0_PG) && (old_value & X86_CR0_PG) ) > { > + struct segment_register cs; > + > + hvm_get_segment_register(v, x86_seg_cs, &cs); > + > + /* > + * Intel documents a #GP fault in this case, and VMEntry checks reject > + * it as a valid state. AMD permits the state transition, and hits > + * SHUTDOWN immediately thereafter. Follow the Intel behaviour. > + */ > + if ( cs.l ) It occurs to me that this needs to be qualified with LME first, because cs.l is software-available outside of long mode. ~Andrew > + { > + HVM_DBG_LOG(DBG_LEVEL_1, "Guest attempts to clear CR0.PG while CS.L=1"); > + return X86EMUL_EXCEPTION; > + } > + > if ( hvm_pcid_enabled(v) ) > { > HVM_DBG_LOG(DBG_LEVEL_1, "Guest attempts to clear CR0.PG " From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:24:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:24:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520672.808507 (Exim 4.92) (envelope-from ) id 1pmvzb-0007bR-1b; Thu, 13 Apr 2023 12:23:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520672.808507; Thu, 13 Apr 2023 12:23:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvza-0007bK-V2; Thu, 13 Apr 2023 12:23:58 +0000 Received: by outflank-mailman (input) for mailman id 520672; Thu, 13 Apr 2023 12:23:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmvzZ-0007bE-4X for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:23:57 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cf44ba9-d9f6-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 14:23:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AA16B5C0144; Thu, 13 Apr 2023 08:23:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 13 Apr 2023 08:23:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 08:23:50 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cf44ba9-d9f6-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1681388631; x=1681475031; bh=H4jzTRmNuiASiivtBudmUIm91 iIj5Qc7O7FtvJTdyD8=; b=TfRjBKIgdBL7hNfjovnNfQRebm+pnn6643rTt6zN6 hmOIAYHIDKTmkVCxqvCGSRkU/97NrBgurbkS/Bx3ZW5aIIrzICo8NSsoXpQb7RS5 WQJV5SsohhCSHRlPaBg5ke3iVdnvn1+aQGN9kz42dzsfc9JI2P1iCjBVALhsKbvw lx3kF3ixRjIViG9yEQFtZIDk8K/zY4zjVlJm1ffCc+i+Om55H2KZsi587N40AidW c/Vx6f/4ClhHGoFsd7eweK6T9hdCFQSqp9UKSdJltWUi8jJNLXWc15JSo3SH38vV BcVOe5QNqfKzR1idOf/1mSpgMo7JFBVOBH6tknRXy5GKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1681388631; x=1681475031; bh=H 4jzTRmNuiASiivtBudmUIm91iIj5Qc7O7FtvJTdyD8=; b=eVzccDoe7Ibp2jJk8 bxkVqCUXlUoQoSyUp7pnReWWGm+B8bHaGSSWpCRcxK1Ti7h3MeEj8qy5EQgELeu3 FnnRuNp6ZcICWOeRdY4LN02qMnBTqLljZTXP/25OlgFw0bo5H0cVTmE+qrRM5xAG jrAqA9pqM2FgOq1+/+CttkMxD8XOexbWD2lMHkXHeRe3pH49yzXCEFhpPimFCi1h YWgzDclIo+JMrM0g1NbuodR5MY91awqMO8KwkZg+wLOsGPtTfEk1gbAnJH0s3eul YlGWTvllExR/bfvDVQtoLL9PylEuLASWNHcPRKKBaAXDC2XKlg7QCeGA9/z9n87w vU+jw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekkedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH] automation: switch ADL hw tests to debug build Date: Thu, 13 Apr 2023 14:23:40 +0200 Message-Id: <20230413122340.47233-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This should give a lot more useful information in case of a failure, and also enable some asserts for extra checks. Signed-off-by: Marek Marczykowski-Górecki --- automation/gitlab-ci/test.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 0916b367ea90..d68c584269dd 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -131,21 +131,21 @@ xilinx-smoke-dom0less-arm64-gcc: - *arm64-test-needs - alpine-3.12-gcc-arm64 -adl-smoke-x86-64-gcc: +adl-smoke-x86-64-gcc-debug: extends: .adl-x86-64 script: - ./automation/scripts/qubes-x86-64.sh 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc + - alpine-3.12-gcc-debug -adl-suspend-x86-64-gcc: +adl-suspend-x86-64-gcc-debug: extends: .adl-x86-64 script: - ./automation/scripts/qubes-x86-64.sh s3 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc + - alpine-3.12-gcc-debug qemu-smoke-dom0-arm64-gcc: extends: .qemu-arm64 -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:25:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:25:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520677.808517 (Exim 4.92) (envelope-from ) id 1pmw15-0008A1-Cn; Thu, 13 Apr 2023 12:25:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520677.808517; Thu, 13 Apr 2023 12:25:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmw15-00089u-AE; Thu, 13 Apr 2023 12:25:31 +0000 Received: by outflank-mailman (input) for mailman id 520677; Thu, 13 Apr 2023 12:25:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmw14-00089l-Un for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:25:30 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45662288-d9f6-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 14:25:28 +0200 (CEST) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Apr 2023 08:25:25 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6198.namprd03.prod.outlook.com (2603:10b6:208:31e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:25:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Thu, 13 Apr 2023 12:25:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45662288-d9f6-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681388728; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=nw8B0PqzZkmEgNqIfZy+uVF3ETSAfu8vkeNNFIBfcIs=; b=UpoYQRe6mfRFz8E0OgKhHD2U/UnZoXVLKLeUTX4A/w01J3mNuZQyccqg jwSi2HPibSbrTnC8+VIXIs4Pms0Euo6V/4SI+Yd6iTI+fBXmTRg7kPjDN LJItlGX3GSu9qFFfTpRl9fEQFfT+Yn97SSJ8xn68kk8isrEnkn+tTE9AR s=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 105277033 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XzOWK6pKpn1klJv32w/QfGZCrYpeBmLIZBIvgKrLsJaIsI4StFCzt garIBmAafeDZmH8ft11OoS3pxsD6pPVzIRhHgtopX9kRCka8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weCziJNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADA1SBKI2c3r+5W2ScVVmdpkMpjrNapK7xmMzRmBZRonabbqZvyToPR/hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jearaYWIEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqMw3wLLnTd75Bs+b1C8ntmLsBGCRNNTC As71xsrtfgvzRn+JjX6d1jiyJKehTYZUsBVGvc36ymMzLTV+AeTAmUYTj9HZ8civcVwTjsvv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty9Lquo00gzrER8xvF6PzhdrwcRnr2 CyDpiU6g7QVjOYI2r+98FSBhCijzqUlVSYw7wTTG2mitwVwYdf8Y5TysAeGq/FdMIyeU1+N+ mAenNST5/wPCpfLkzGRROIKH/ei4PPt3CDgvGOD1qIJr1yFk0NPt6gJiN2iDC+F6vo5RAI= IronPort-HdrOrdr: A9a23:t8uu5qzGYN0jf04dHdqYKrPwL71zdoMgy1knxilNoH1uA6+lfq WV98jzuiWftN9vYgBGpTntAsW9qArnhPpICOoqXYtKPjOKhILAFugL0WOJqAeQfhEWkNQz6U 4KSclD4bPLY2ST4K3BkWuFL+o= X-Talos-CUID: =?us-ascii?q?9a23=3AsT0d8mjg1GNYNzKvcVyTv1E0IjJuckX7znyODBK?= =?us-ascii?q?DLmtqZISKVxiOqaNtup87?= X-Talos-MUID: 9a23:7ETkNgpVNs8HcEhrE10ezwtpM/hI0Z7xNF8MnbZBlOS1MDQgJg7I2Q== X-IronPort-AV: E=Sophos;i="5.99,341,1677560400"; d="scan'208";a="105277033" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5NMW2E0vCAbYcESnlgYK325SNjhZW/OtTNDwzXJT7RcB0f7SC7NMSHtlhPq8waAAXlt1dSvdnkyFXToZn+3/MHRIeMxuuDE0OCDGOD0UjbP12C5nwOr8/EYFx8VFHeKN6vXpZGjckbXdpXlKPIm0AFHmtNA5pWpLFYXbzx6ihg7GddgNkjDQCXeO62oHobPJGfMXCoX+6mxUwjKkIor0EYEZpP1ByC9+1+LPEi6hwaQJqqDZBWFW/JK2ztF2I1psBPAZw0Qi4Zv3jAz7ssTaE04aF82uQ5PtTGRNKadY2SW61etoz+ZWvcB0MVa9nZMcT8ttlLvR/+d3EyBX41vdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nw8B0PqzZkmEgNqIfZy+uVF3ETSAfu8vkeNNFIBfcIs=; b=d2xAhR+FdFhFqtPc+NXIMw/Zj135B22nUQacq8Yp7mNQvqAieuoLrpeySEq1LNnoB7E5QNpp4rW3DKX1J28b2LX9wBdi5BjYfwv+9lArJiLvFNS9ZYyJqOEoP6YlLGBmVh8RetoLLLw/2Xqsm0ySG+ENgtDqhEbxZ8UZ/ssU9AX04PJ8Eqo1KOEdT/tUpIHMrgWUQuQn3NC8E6Qm3HPYNka4dOGXgtOi79mktRnxpnd6oMv4NJOYWX8WiDiduC2JWONIUtXUBkkPisINLzshxWUczOpXkcUqM56sCDa3TLLlWuuYBDvPUMW6AXntIwqrFNf7+6SWA0ptB7HW49tWNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nw8B0PqzZkmEgNqIfZy+uVF3ETSAfu8vkeNNFIBfcIs=; b=Q4xMhWa5vxTOR7nugplsg6k4e6RvU8AWuShDm94BfLtOJOWEn4Y93Jo/KqMC2h8fN9WeV1JGAkQg4qI+28hRZBOhz9Vhf01fy5t2p6Bgfg7a4r69kZBMmk9jLayU4g2uDaQwXToYvZW+esEB5kU2jupC9M7l0Dv3xjM5hqcPDKs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <50de28eb-f661-fc55-8d7b-7ba07b160c25@citrix.com> Date: Thu, 13 Apr 2023 13:25:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] automation: switch ADL hw tests to debug build Content-Language: en-GB To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230413122340.47233-1-marmarek@invisiblethingslab.com> From: Andrew Cooper In-Reply-To: <20230413122340.47233-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0324.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BL1PR03MB6198:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e64e8d0-c4a3-402d-b634-08db3c1a2759 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BGSzvVApVqVS6BhuK6MY08lLHJCjwEnSv/evmBBSvzKq3QQOw6xd/z+bj5ZEw0nmNkJlfX+k0meLeg4GEpYVtiC1tl/gm8eXYMe0oj1vHFsOFZRwMx+qf7glhGQ81eb2SG6Ck4Ftey1F5jDRWoO9TR1WEs40Yq3bC9yzEjy4vF8eSMxRZrDudQARQ9/PPwZpZ/syV+iGDVxwHl5YJy3Esg6PiFnLN+sUol1v7tGhANSpUbjF1ag96LeswKZnvwaiHeD/QtewMlCyXeBG1rAcIZFCZ04DYv9ude0WDZ63D4HUMU0inrPMY5VIhza2FPl2ho9GdrnAE5Ky9MFfZbDcQC3V8vTG3c2AgIrM9/mnr5FZU/ekfU6WtyvV2l3uPLCbPUaRwkyRBJIrKDSda9IrsFYnB+yvwZnHc5lPKY+J2hXaldIcfUo2AgGD6qjkPrVP+yhWIH3g0EMaXVzqkC0k0mVprVbQ3u41dg7hzMvKhjkCq8e6bcFkVpVpo2LCwv/y6kWWSCxIOWD3+NVgrlWrZ826Cbsy9WY2HpwGTaKcpEAmupdL3PXZiBv+sEtJ2yphM3XWFWhWX+6gBp9y0dQeJp0PqsTy7OWgbOOcC5wm+fYgzd2sy9B0zS2Q1/j5VZvBbhsKKtbhSX56hvHUXbnaTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199021)(8676002)(8936002)(82960400001)(4744005)(2906002)(31696002)(86362001)(26005)(186003)(53546011)(6512007)(6506007)(36756003)(6666004)(6486002)(31686004)(83380400001)(66574015)(2616005)(66556008)(66476007)(66946007)(38100700002)(4326008)(41300700001)(54906003)(478600001)(5660300002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUZ5a3lGT1BuY2JtbWkwM0tuL0dObWVPN2pHN3F5ZjlUTUdpSDQxdEZKRUxL?= =?utf-8?B?N2V5QytkMVhIeHp2bW01NHJhUnhIaS9TZXJ6dkttYmdyQ1J5UGhXZ29aakI4?= =?utf-8?B?YjVlaW1maW1NclF2dVNtQ1dtS2hxKzJreDRxaVQyWHJNK2JSbE5zcmpEemNv?= =?utf-8?B?dm9DSTVua3ZydWZSRE5FN0FONWFCQVZpRlBHY2dXM2hXaEttTk9JYjl6NTJY?= =?utf-8?B?RTNieUJqL1BjVk0zc2Q5Y1QwY0x0SFFYMjRBNUpoNUhhZXdpZW1kVlNCbVl4?= =?utf-8?B?NUl6LzR2Y2ZkWHgvaStUd2hqTmdVOGowS1hiYS9BYStLMnB1clYwYXNGaHoz?= =?utf-8?B?Y1N6VEQweENRU3hPRnU4OXVJQTNuVW9nOTZtaWtMYUdtc0t6ZVk0TGp5RVAr?= =?utf-8?B?UXpsU2hzRFhVdGRjaUVSYXpoV0JRb1lZWnVIM01sUW50YktlbnprcUNva2Jo?= =?utf-8?B?VzBjMEZReFJGbG5jV0NDcXZGZno5MmJoRjJKNnE5ZGlkK2dwYjloM2JaWnhB?= =?utf-8?B?STBBNHJXT1FaOWJ0a0JaU3UyVkYrWGN1UGVGT3ArZHp4bzFTcENYNVpacG82?= =?utf-8?B?N2FaMm1TZDJaNDFqdENYbTAvSXBMVElNU2RWQ2hTYlFENFN0SGRGUHdockhP?= =?utf-8?B?dUJKYUtsMXFKVzBxTE51NHdHZUVseDNjaUd4OU5GczE0MTYvK0tNcHFYVzlM?= =?utf-8?B?MFpMenBySTBxc3lZTjVObHNhcHc1MjdaUWN4dUxyZFdmTVIyT05SRC8wSzAx?= =?utf-8?B?M1BCZXAwejg2RWdGK2c3RkZiTUg3Y0h1b1UzRHR2clNFNld4VjNvMXNDY0dZ?= =?utf-8?B?SG5QRWYwOWVqOTdEenFGaDlvYURhODBCVmhFd0xaaDJkMDQvQWg2VHNBWjhV?= =?utf-8?B?ZnoyMjYxcU9tc1h3NDE2ckhvYWVINzZBeERXK1N3TXdCOG9LMU5DdEZkVktX?= =?utf-8?B?T3lOWDdsNEhiQnpyUnFJM2xpVjZiZy92QUFGMExJYVRNM3JFeFJsdTJ4ZWNG?= =?utf-8?B?Nm40RVp0MXRJQWNucVIxYURFMndNSUV3Rmwwc3I4VEl1NXQxT0JSTXBFVmh0?= =?utf-8?B?aVNNWmREWC84S2x4WWZlWDBkNGQ0N3BDSXNybFVWR1hTK25xVlo1QXB1NXZl?= =?utf-8?B?MmdmUjFCWWFISU9vbjdZSEFkRlVLOUlqc1Z2K1UrWDdGYldrWU5NUlFMTXR0?= =?utf-8?B?azFrSmUxQVNPSTdEZm4wR0YvVEg1WWNCb0REQmtYRUNWV1VYd2VvUDB1TzAy?= =?utf-8?B?RVJBcy9NRGkyOTRBeGQrNUVqVm13TU5tbjdiZEFDUkdGUUh2cmtPYlJ2RkdI?= =?utf-8?B?VjBkNVBNSDNFdUZINjlFSWFnSXBKRHlSemhWQmtFWG5BcUZxcXFWVGR5b2Jm?= =?utf-8?B?UWxMS0ZJMjVHeEE5R00yL2Z1bXBBN2NuajlrdFpWVEM4c2hwMjNKMnFSYnVt?= =?utf-8?B?Vm11dlI0Z0pTY1BrcStKNzJRMDJZNkdEcjBBZjQ4U1ZJWGJTUldmM0M3V21y?= =?utf-8?B?K2hSaHpJRUg2UmxPaDRVblg5WWNtbFpRZ25SK3p2Vkt1RGlNZ28ySWt3aS9j?= =?utf-8?B?UVdzWXpVOUpQNWFDTWg2Nm4rUGN4bUtjaEhTeUZVYmNBRkEzYlVVRGlpVHRh?= =?utf-8?B?ekZybnNWVmNUbkdLWGhEeEFrcmFZd21vTDNpcjcwbGt2WVRGVDVibVFCc0FN?= =?utf-8?B?WFJndmVVdGRtNFExTkZzRUVLRDIrMTFVMGpTdUhoQ0k0T2IyQnlkZmtSSitX?= =?utf-8?B?Q2N5Y0YrMXZzWDNVWkZBREZSdGJPYmgvUWt5S3E5ZXhkTHRLWmpET21qNG11?= =?utf-8?B?NVkrWkxJYjJuQkYvMjlIYUxweTEyeWNSQzNPL1lZN20zYmVrcitHdmxRNEpV?= =?utf-8?B?bVE5bHlMa1BVRkZ0N2hzUGlrbDNBdWtaQ0VyR0V6NG51TXFqK0hxNlp0Y253?= =?utf-8?B?VFU1NE9VZUtnL0w3SjFsRjNPaitlUVpGWUYyMGdKMUR3d2ZlKzBtNjZ0T2VI?= =?utf-8?B?aGlINDBlZjJJbjNLRC9mbEFNdy9mNWh5bWdlMEEzZGhNNUlybXNBY2ptSldT?= =?utf-8?B?bXQ0WHV4WVJjaDdZSHVZbHRON3VncUtzc1hwY2k0Vzh2eVhteXdQdC9XMGJC?= =?utf-8?B?elR1TVZ3d1NmQnV2UStJVlk2QUZqeWU3dW9uMWgrTjdqZ0J5cTYyUHcwdlEr?= =?utf-8?B?Qmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9qizroPoeI8F2lPM42z6pF+pOkjuzghjlIyKfjC7+YpVG+S6GYU6c0OzFLoFS20DbuBtoZ8JbnOQeQZBK4o2bKd5R2l3pBCO+LTZovo8BRbY+qaZVNsbOcWm/BGLM5iznxC164K3R68tt+2FwF+cpiRtws7bK9SDCxbcIde04KBLJdUMhOW/iGdQHHSFntUA48Y3BX1GJemENdJJ9Op/iZYzH4vG0w3HzN9sqhffLWdbDulnP48FfopRFavs4PsSturLamQseea8UPoaFIP/2Kecg5T9CunLB9WYz7E6LpIiCLep5YQfCVtMt3QhAkER8SasFTErk0mAugFnOGE39wgKziMvWlJMOIRJROt7xIvbq5rDckMcxs8rkGddg0iVkMDlQw3Zo6LY6br7hS3PnvMizuWh6Gjg/aH9x9otTX/nFRB/iEE3bwNHVrab5Cg1hI0rX6+O2CFq3+zCeNGM5uAvniMwftbPC0zmMrfRlBaQpCp2yn9dafUAS6fVqnkiT2XmLBQnhNd+zgB2KDFXtorGYLsskYWc6ECsoq92Mc/iSu5F9vsrXpJmhqpXOLGh6I20XC+PGZK3Lix7r/YY+OoEwIN4TjzFtAgBHnbYqqWp/zrmjXPSoqQSDEWjOYp1f/1tzR+h7Zg9Rb/N73aHokNm/+i5emc9x/wzI8wrnL0hr4dXYk6FTDG+b5e+BeLMsAHeAhqCanLdDyqwK/wO4VqXSG3KPmlpmI4MZ7WT8qIGFRKan/5AQlZrk16Zj5EeNpqnqZEPJ4o3vIA+BVuTqGhu8uhPWkoebujo8mAl1JzHF7QRo1f8R5PPNn+liHHJAXkqvi7znWUT8GB+0A8BeEJZ4TqdIkNzDJepbwiZnYo0lzr/k+CEjtLhTLGiy4leWGdvYGYO+1PC4KuNXM85xA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e64e8d0-c4a3-402d-b634-08db3c1a2759 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 12:25:23.3774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aDsLRiFLIM7jnEvaw/LsNDXdpzgz/Qc7Rmx5NQ8MFjEhj1Ay06zgPozyErIAlogEx4XkBHnteQxWgrQ03lomI4vuw37yeq5jixzPp3I5z4U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6198 On 13/04/2023 1:23 pm, Marek Marczykowski-Górecki wrote: > This should give a lot more useful information in case of a failure, and > also enable some asserts for extra checks. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper I'll merge this shortly. From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:26:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:26:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520682.808527 (Exim 4.92) (envelope-from ) id 1pmw1t-0000Ju-P3; Thu, 13 Apr 2023 12:26:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520682.808527; Thu, 13 Apr 2023 12:26:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmw1t-0000Jn-Lt; Thu, 13 Apr 2023 12:26:21 +0000 Received: by outflank-mailman (input) for mailman id 520682; Thu, 13 Apr 2023 12:26:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmw1t-0000Jd-0J for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:26:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmw1s-0001jK-LU; Thu, 13 Apr 2023 12:26:20 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmw1s-0004af-DB; Thu, 13 Apr 2023 12:26:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jOO+IcLy6m2G+FcfCMMlFmJIrteZRP85wg/5Z1eG/mc=; b=pfwaeJqPTxtNQ5xgPsx8+VM0QL ryrPsPK/Yv1uy+nqs4QiqlOxe7SH6EWx+fW/cVU+T+1FObsNGXiAtU1F8ug/nN3iFA5cPoPT6I5XP ihrEPdlo21ZQ5TVxv/Vrbwu+DUIDHaMVYrqkYh1k0tzP4tJJZXGqOR6hP8qICevh8WbM=; Message-ID: Date: Thu, 13 Apr 2023 13:26:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN PATCH v8 02/22] xen/arm: tee: add a primitive FF-A mediator Content-Language: en-US To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Stefano Stabellini , Volodymyr Babchuk References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-3-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20230413071424.3273490-3-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, Mainly reviewing this patch from a Xen PoV. I will leave the others to review the patch from a spec-compliance PoV. On 13/04/2023 08:14, Jens Wiklander wrote: > +struct ffa_ctx { > + /* FF-A version used by the guest */ > + uint32_t guest_vers; > +}; > + > +/* Negotiated FF-A version to use with the SPMC */ > +static uint32_t ffa_version __ro_after_init; Coding style: We tend to add attributes just after the type. E.g.: static uint32_t __ro_after_init ffa_version; I can deal with this one on commit if there is nothing else to change. [...] > +static int ffa_domain_init(struct domain *d) > +{ > + struct ffa_ctx *ctx; > + > + if ( !ffa_version ) > + return -ENODEV; > + > + ctx = xzalloc(struct ffa_ctx); > + if ( !ctx ) > + return -ENOMEM; > + > + d->arch.tee = ctx; > + > + return 0; > +} > + > +/* This function is supposed to undo what ffa_domain_init() has done */ I think there is a problem in the TEE framework. The callback .relinquish_resources() will not be called if domain_create() failed. So this will result to a memory leak. We also can't call .relinquish_resources() on early domain creation failure because relinquishing resources can take time and therefore needs to be preemptible. So I think we need to introduce a new callback domain_free() that will be called arch_domain_destroy(). Is this something you can look at? > +static int ffa_relinquish_resources(struct domain *d) > +{ > + struct ffa_ctx *ctx = d->arch.tee; > + > + if ( !ctx ) > + return 0; > + > + XFREE(d->arch.tee); > + > + return 0; > +} Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:36:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:36:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520688.808540 (Exim 4.92) (envelope-from ) id 1pmwBg-0001tv-Or; Thu, 13 Apr 2023 12:36:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520688.808540; Thu, 13 Apr 2023 12:36:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwBg-0001to-L1; Thu, 13 Apr 2023 12:36:28 +0000 Received: by outflank-mailman (input) for mailman id 520688; Thu, 13 Apr 2023 12:36:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwBf-0001tf-HJ for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:36:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwBf-00025L-3y; Thu, 13 Apr 2023 12:36:27 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmwBe-00056E-TF; Thu, 13 Apr 2023 12:36:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rFaQOQZqtnuZCv66vbPgUNGabOZCkbkvgGmoXQcw9Yw=; b=TXYAaVXq0oLG7bDbTNU6uUCqSE VqnqfX7vZp3irdfobVXvVSjoQ4XDv6WNcsbG5Nhmu+2szP99ainFVkbqMWU7RviO26XsKK3gD2wtF mIARx/mUsmOUwtdvG+IhyGDskc4SgnV1lx8CloV3O/Krcq6ktI/q0sqQk4B9ycIXC5W4=; Message-ID: <137a1457-aacc-e763-b313-4266be3fa032@xen.org> Date: Thu, 13 Apr 2023 13:36:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET Content-Language: en-US To: Henry Wang , Jens Wiklander , "xen-devel@lists.xenproject.org" Cc: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-9-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/04/2023 12:07, Henry Wang wrote: > Hi Jens, > >> -----Original Message----- >> Subject: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET >> >> Adds support for the FF-A function FFA_ID_GET to return the ID of the >> calling client. >> >> Signed-off-by: Jens Wiklander >> --- >> xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c >> index 90ed71cbfda3..f129879c5b81 100644 >> --- a/xen/arch/arm/tee/ffa.c >> +++ b/xen/arch/arm/tee/ffa.c >> @@ -181,6 +181,12 @@ static bool ffa_get_version(uint32_t *vers) >> return true; >> } >> >> +static uint16_t get_vm_id(const struct domain *d) >> +{ >> + /* +1 since 0 is reserved for the hypervisor in FF-A */ >> + return d->domain_id + 1; > > Since here you want 0 to be reserved, I think maybe you can use > the "d->arch.p2m.vmid"? According to the logic in p2m_alloc_vmid(), > the "d->arch.p2m.vmid" is also a per-domain u16 value that starts > from 1. I would rather not do that for a few reasons: 1) This is assuming the P2M code is initialized first 2) We should not rely on the VMID to be fixed. We may need to change that if we want to run more VMs than the number of VMIDs (we may even need multiple VMIDs per domain...). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:40:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:40:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520692.808550 (Exim 4.92) (envelope-from ) id 1pmwFY-0003Jd-AE; Thu, 13 Apr 2023 12:40:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520692.808550; Thu, 13 Apr 2023 12:40:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwFY-0003JW-5e; Thu, 13 Apr 2023 12:40:28 +0000 Received: by outflank-mailman (input) for mailman id 520692; Thu, 13 Apr 2023 12:40:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwFW-0003JQ-Tt for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:40:26 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060d.outbound.protection.outlook.com [2a01:111:f400:fe1f::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5bca9401-d9f8-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 14:40:23 +0200 (CEST) Received: from DB8PR04CA0017.eurprd04.prod.outlook.com (2603:10a6:10:110::27) by DB9PR08MB9681.eurprd08.prod.outlook.com (2603:10a6:10:45c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 12:40:21 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::89) by DB8PR04CA0017.outlook.office365.com (2603:10a6:10:110::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 12:40:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 12:40:21 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 13 Apr 2023 12:40:21 +0000 Received: from 4ec3420f14fc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8C77334E-929B-45AD-9867-4B675EFF8411.1; Thu, 13 Apr 2023 12:40:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4ec3420f14fc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 12:40:15 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB6500.eurprd08.prod.outlook.com (2603:10a6:20b:361::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:40:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 12:40:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bca9401-d9f8-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ka1TPzcvs3wzjFmSld0UHQItCpr3ZxdcmEzmyQ6RIU=; b=xgHEBrnEB8nQOsInbiEUtLqgUaBjPAZU6k06+3H4OqEPP0/2m840OIuExlekdmLk92YvUjHOX+zYfoA3thcrn91Xc28LxoDQajIUuwhraR9XhTuNfUVn7NQh9jPVYBIESM/ln41pYAkVnwas4/+lxANa9prksnhxmpqP3o/DDZ4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FG9y0t9VkxUd3tv0sx4/MJVTUQw03TJKIEtymlJ3QCeLLMdVLe9XrlLv23iGaXE/wVpXeeFYlZP4iL79fFbC8IYZxF7SpUtirmHX2cSTxgdiilOQhDxSe/b5MFVnk31JiYaXSA5aheS0FIc/MnHUii5GnX0ojL7xJY+GGASl1vVEKMHDfmj6zACPqHP+spJr551hEsc3UTfaf48TAfMfld/bOTGyj7MBfMaXa7qKWjnrgIhu4lRbezN7HFqWXPSLixilkJMJvyKV5IgS1nvZUYVeWdHQz+sqZLitUKh6j7bkzPl7/e7plCzVw0hBtXXjzRaUIa8+H/3PBZcGkQUxvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ka1TPzcvs3wzjFmSld0UHQItCpr3ZxdcmEzmyQ6RIU=; b=gWsAIRSljjuDWRKXkXOPth0oM3/gqNAaiJ3+UT9/1AV7fth6fHXdP9CjV9OQlfcKytPO6yxe3swIW0otfXgchlC53VdLOvRUAYxT+4W4IVth/XpE4DeyJOUlUaBKBaCLTrtHdbD2AVYV/P3VlyRNEgo/D1QE3hZQCyHbiYJjQZQUzDeMYXrwUzozs7+cK6j+q5Tjtqf8H9Jrz5OuXdBAlvfFIaxHy7/YT/GlRtG070usl1PoNUxunH9xUZ+qf+Rx6hTl0WBMY3xeHXrNlrl8ux+Ek83lFg9G9oCT6I/OWUETg0EOtL6Fx6gS42qyVnK+jRgmB1y8IFkZvpsTKOH6oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ka1TPzcvs3wzjFmSld0UHQItCpr3ZxdcmEzmyQ6RIU=; b=xgHEBrnEB8nQOsInbiEUtLqgUaBjPAZU6k06+3H4OqEPP0/2m840OIuExlekdmLk92YvUjHOX+zYfoA3thcrn91Xc28LxoDQajIUuwhraR9XhTuNfUVn7NQh9jPVYBIESM/ln41pYAkVnwas4/+lxANa9prksnhxmpqP3o/DDZ4= From: Henry Wang To: Julien Grall , Jens Wiklander , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini Subject: RE: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET Thread-Topic: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET Thread-Index: AQHZbdfdlkWasQb0b0OUu0VnJOxcoK8pEVxwgAAcEICAAABzkA== Date: Thu, 13 Apr 2023 12:40:13 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-9-jens.wiklander@linaro.org> <137a1457-aacc-e763-b313-4266be3fa032@xen.org> In-Reply-To: <137a1457-aacc-e763-b313-4266be3fa032@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1CA69413958B9B4CBF580C8ADA194074.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM8PR08MB6500:EE_|DBAEUR03FT034:EE_|DB9PR08MB9681:EE_ X-MS-Office365-Filtering-Correlation-Id: 838fd2dc-af41-41a8-91cd-08db3c1c3ed9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: j6V0MDx3IHi+Cl40rz/jcWeq1t4CX6lUKVA+50qRPSUVTBhG7sYZVExU81trri93G/JVUDW9edpyT+orWqofaaL7Bp6m0IxfduWJeWQAdaXtK8nSfxrsohbC4iz4PcMUVbNzIDBqX34rOhxTt86MKDFlF63SMB5BOKb9of5J7vDzKygsu+MV5Mv9o0c5Vk5NOkDl58bdZmA1kFsQmFhuBldUSzqpJZu2o3c1T0UW1gi+FVkCj9OdSEJMS2ML6ejLfUhhtnMo4vimxXJLZHK8J7AsLlmPV+0b4TEci0gE2wV6DGNMYCBLPUDtG9sWAck3lSxUP1oz9yUoSrNqbqqCHleqh7jCdPsIScWt8FHkCjGTghMILKg+gaZ4WqJ3QaDU1el+aA1p5QFH/pdXL+cCH9WB6Qkb48VjuHJtKv7E0clVJsmc41epy5CpOwQLxuKr9MdQQHGYbsE+/ymyvEdIQHhiVZzbqu785OhOu/R0F/7jPMCWeAf7ZqMKMkSXz3GU6afA+bgCN3LFqVQ9SwKrQDhOnkPEE9pr8b1IbgVrktdApAa2okoLCSoxrh0u4XKL2sxURrVKX/g1CaMQlvPJr83o+owc+LguGUjvW4vOBi7Ofm7hvkRdi+OhaoSO28nG X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(66476007)(316002)(66946007)(76116006)(64756008)(66446008)(4326008)(83380400001)(7696005)(478600001)(54906003)(110136005)(8936002)(8676002)(41300700001)(38100700002)(66556008)(71200400001)(122000001)(52536014)(38070700005)(5660300002)(4744005)(2906002)(186003)(9686003)(26005)(6506007)(86362001)(33656002)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6500 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e0d4c870-0d90-4a93-f82b-08db3c1c3a4d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bxd7BhhsE/XYXTqoz2PLm/zzNOiP8fWNannp+lLMIOUsLcLBYuF6PlY3KHIorQddgKIgfw+Jaa4rBcH0xdVqn9/Jro01JCGSrYkjaB44mzMtpONZE2eTY2ewpmiSSNNDHNbCW7vwtZXlrKifVNYXBtWawxPIlSFFrnleMtdAz9JnHQA3cYdkPChR3itpkjessltCF/1JJC9C62WoQhNPv572EAzDF+tyGtHqnY1Hbfb4uiEQrYOSbxeqmAMxGcxqoaodLekpBUQohx/gxYvDJGsTaMz3I6BxGTzpibeXN8+2TOzzHeT/tDNjEvKGeG1HouoJnctAQkced7p9k+kzG1T1zVTuCqLw4ZB8UU3YiJxC/Wny7BsTevZtqp5WKwOJiIl4kfdhHShwtbj0wk1w0S7/jesFvtlJrfIv0+6uYPx4/9qSYNnEcX0FsC5NFRX0OQPIp/95ya8cU7Tr8n1w7kKY+YlA7D7tOHBSQfgLgVQUo2aeJ2aKR+WEZ9FuZUlWbSleLxg49g+o7FDqF21Z17S3qGc1y8alwKaGC5cDzSrplFgBe5JC+gFE6oYy+s8yhtjPBdE5Rc/3ioTmjQ3aSGg9gQJuFBlP8kwC6KM/xN/XXdrsZlax4vC0Q6Hm1lWzWeR+kaYLW8LbGZQgrbNIuiDLKgJr/nv1WTtpC1Y/uw3f6FfNqKjOTsKdoNR9CxWP4SpYa5q9X1bxHRm/bUtZ4A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(478600001)(41300700001)(82310400005)(36860700001)(86362001)(316002)(54906003)(8676002)(70586007)(70206006)(4326008)(110136005)(7696005)(8936002)(52536014)(5660300002)(40460700003)(4744005)(336012)(186003)(356005)(81166007)(82740400003)(33656002)(9686003)(26005)(6506007)(83380400001)(2906002)(47076005)(40480700001)(55016003)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 12:40:21.4097 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 838fd2dc-af41-41a8-91cd-08db3c1c3ed9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9681 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbWEVOIFBBVENIIHY4IDA4 LzIyXSB4ZW4vYXJtOiBmZmE6IGFkZCBzdXBwb3J0IGZvciBGRkFfSURfR0VUDQo+ID4+ICtzdGF0 aWMgdWludDE2X3QgZ2V0X3ZtX2lkKGNvbnN0IHN0cnVjdCBkb21haW4gKmQpDQo+ID4+ICt7DQo+ ID4+ICsgICAgLyogKzEgc2luY2UgMCBpcyByZXNlcnZlZCBmb3IgdGhlIGh5cGVydmlzb3IgaW4g RkYtQSAqLw0KPiA+PiArICAgIHJldHVybiBkLT5kb21haW5faWQgKyAxOw0KPiA+DQo+ID4gU2lu Y2UgaGVyZSB5b3Ugd2FudCAwIHRvIGJlIHJlc2VydmVkLCBJIHRoaW5rIG1heWJlIHlvdSBjYW4g dXNlDQo+ID4gdGhlICJkLT5hcmNoLnAybS52bWlkIj8gQWNjb3JkaW5nIHRvIHRoZSBsb2dpYyBp biBwMm1fYWxsb2Nfdm1pZCgpLA0KPiA+IHRoZSAiZC0+YXJjaC5wMm0udm1pZCIgaXMgYWxzbyBh IHBlci1kb21haW4gdTE2IHZhbHVlIHRoYXQgc3RhcnRzDQo+ID4gZnJvbSAxLg0KPiANCj4gSSB3 b3VsZCByYXRoZXIgbm90IGRvIHRoYXQgZm9yIGEgZmV3IHJlYXNvbnM6DQo+ICAgMSkgVGhpcyBp cyBhc3N1bWluZyB0aGUgUDJNIGNvZGUgaXMgaW5pdGlhbGl6ZWQgZmlyc3QNCj4gICAyKSBXZSBz aG91bGQgbm90IHJlbHkgb24gdGhlIFZNSUQgdG8gYmUgZml4ZWQuIFdlIG1heSBuZWVkIHRvIGNo YW5nZQ0KPiB0aGF0IGlmIHdlIHdhbnQgdG8gcnVuIG1vcmUgVk1zIHRoYW4gdGhlIG51bWJlciBv ZiBWTUlEcyAod2UgbWF5IGV2ZW4NCj4gbmVlZCBtdWx0aXBsZSBWTUlEcyBwZXIgZG9tYWluLi4u KS4NCg0KWWVhaCB0aGVzZSBhcmd1bWVudHMgYXJlIHJlYXNvbmFibGUuIEZvcmdldCBhYm91dCBt eSBjb21tZW50cyB0aGVuLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMs DQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520696.808559 (Exim 4.92) (envelope-from ) id 1pmwMI-0003wb-0E; Thu, 13 Apr 2023 12:47:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520696.808559; Thu, 13 Apr 2023 12:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwMH-0003wU-TF; Thu, 13 Apr 2023 12:47:25 +0000 Received: by outflank-mailman (input) for mailman id 520696; Thu, 13 Apr 2023 12:47:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwMF-0003wO-Uy for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:47:24 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20625.outbound.protection.outlook.com [2a01:111:f400:fe12::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55a5d9c5-d9f9-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 14:47:23 +0200 (CEST) Received: from DB8PR09CA0012.eurprd09.prod.outlook.com (2603:10a6:10:a0::25) by AS8PR08MB8223.eurprd08.prod.outlook.com (2603:10a6:20b:52b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:47:18 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0::4) by DB8PR09CA0012.outlook.office365.com (2603:10a6:10:a0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 12:47:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 12:47:17 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Thu, 13 Apr 2023 12:47:17 +0000 Received: from dafbc1c48e49.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AA2553E5-1DDC-4E0D-BC9A-BBE9232C4840.1; Thu, 13 Apr 2023 12:47:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dafbc1c48e49.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 12:47:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB9303.eurprd08.prod.outlook.com (2603:10a6:150:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:47:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 12:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55a5d9c5-d9f9-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYSNyVTp8W/FB7GwWnYK3bCKTHKAmsNBpUFfPF0J3sk=; b=7hgFXUVMbiJ7Xo1HjWj+0ndJs+/vDeVB+cASc2g2X68Dd4ec3tnHCoMw34augXRJQdUUdN5Wmal+a8G+4txIDc6HVirJ7toDSUzY7u4mqrQNIulVicfoepoy0vWbOJObvMCIqMi1297XOxVvenisB9MHJNIGFjvcTEE1EV7JVVs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b6977f6572de6333 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F2HZ3hRY0bEFOZGJiL36bVNPr/qs9XhAt7zHaDR9+As87iiw5FdlyROY55peNAJKbprN82dImc9GLsmpdcY/jRiSpCBnflEtL3XgXKlqzhzzmt0UN8lrUCXvrJb87V0tG5Kj+i54RBYiY1ETg6IFheVFKU2EEF4gJ0eKWzq/cX64cV3Ncu1Rg1co0evVg5g0MstnNGzwL8HJDbt2+/Q4TEEI3QotnhLL7VrmRHlTbrSoVq+c+r4yWDoHC1sx7E80uLJEDuSAybrFJhkFlSvkH9ld1qtez5cpXTwZdxQHi80a7f4I0kysAMkPLRpI2WtLOxcRlxHo7LEfSC3YoqW9mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYSNyVTp8W/FB7GwWnYK3bCKTHKAmsNBpUFfPF0J3sk=; b=g1sqZJtVb/Th+AHabQL+OChYkNcI8JO9fkKU4Bzlc26CK+YtzoEKhWd6DWcP6zzw0ZmTYU1yjVga1GVcIBW1yMWZMjmNpzXO+Ymo+Ps8dg9loE8HZN4x6+Aeh8SF6SWrYckIwHvpQHL/F7ZiPgB9g78U+o/1Bk2INxn9HxIhKwwIHWyLSyIgbqNKJL6VSiqtRHTBQKZ1ODy4eB5bH33t42JrRNBeB7pdORDw1abFdsOTJx1bkkWZvZOvRT2SIRD/DzO5jGOovF8cYdnFNn8iZ2VgB6Tf3wWmnHqnYQW85SV8QaQVpyhDFR0wl7wObAOm8rh77s+oNGQvHbrhfD/CDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYSNyVTp8W/FB7GwWnYK3bCKTHKAmsNBpUFfPF0J3sk=; b=7hgFXUVMbiJ7Xo1HjWj+0ndJs+/vDeVB+cASc2g2X68Dd4ec3tnHCoMw34augXRJQdUUdN5Wmal+a8G+4txIDc6HVirJ7toDSUzY7u4mqrQNIulVicfoepoy0vWbOJObvMCIqMi1297XOxVvenisB9MHJNIGFjvcTEE1EV7JVVs= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Thread-Topic: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Thread-Index: AQHZbSQnZHhi12xjyUK0b5ypet9SdK8pMcIA Date: Thu, 13 Apr 2023 12:47:02 +0000 Message-ID: <190AEC88-68BE-4DEA-84D5-9DDF0F63A365@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-2-luca.fancellu@arm.com> In-Reply-To: <20230412094938.2693890-2-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV2PR08MB9303:EE_|DBAEUR03FT032:EE_|AS8PR08MB8223:EE_ X-MS-Office365-Filtering-Correlation-Id: d8659d4c-50fd-412c-6170-08db3c1d3721 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G1/kKWLWtfq1Ih6vfQZDmdHc5EfSKHQhLcoJEzCZZUmZ5MDaYi1zL2dTEglvoo0Ew3m8quMHIKIJY8UN9VxxOldsoJG8xPE6PyDT8jX6ac7zaE243PsiJYLr3Y5Km9q8O1+/yZhZmEhQc0pe1u2lVoRdc776DcxwHODBmTFo9iWgTrO3gEmqwHJoGBonJyIrvEqstJhJcwyzGbX21msjtCsf9LKjhHHa+ie9gkn53zu8+Aw+cD0UV2ZzRnaLMOEzTJXJCM2MUuZ9xxsNcVWY09SraiiMAjN+ZsOKn+VQLjTBG752GwHJb411BiQce67+YGbfvtvWdcGPhVTr0u05QRoK0YUOXLPFXRVp3uKgT70HdZ0DthMJ4xM36JxEOrpmIDJEcuWaKIZbb2x9boQ1yAmcXUM+N4NEDmsAT8jhjmnHHQet2SM77BYeH0i4RkBYxTmOu2Nj5k+Lhzt/Aact9tpdBMCe+hndUAX53x8cakX3+W55r9VuB9zWsQ6aTG6twMbGFvxNvr0MCrb+X1rP2PyEi2xcFeXAhTS0FnJIhcMeTUfnqa4jTC9yCRvXjKD0jCwmTqBJzM8TCFSJKI0PCuoefFp4hqo3naTotStrBVKlPpJ8ZeexsldQ9GZ7+J271E6+Du/2ldpMFg/evBTNIziEo8v0xvJg8s/uvBgYkzE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199021)(71200400001)(6486002)(64756008)(66446008)(66476007)(66556008)(66946007)(4326008)(36756003)(76116006)(91956017)(37006003)(30864003)(2906002)(38070700005)(86362001)(122000001)(41300700001)(33656002)(5660300002)(8676002)(8936002)(6862004)(316002)(38100700002)(478600001)(54906003)(6636002)(53546011)(6512007)(6506007)(26005)(2616005)(186003)(83380400001)(21314003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <2FAC3C652EDC8B4CA1BEA307BC42661D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9303 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 86a3bd36-fcc8-47b9-51bc-08db3c1d2e07 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XKriwFsla8SlnX7RH06F8Xj6vbc94kc7cpa+iPpRtpA/CXgsZSc81pYY/T/5Rhh7h/HhWHJXnENqGyyJ3G0I8A0BPsjpoz47xrTGONKsl/wK/HE311N2vja8oO689cNb+Z7FFaCiCPR0/tTfW6mNWrrBeUmFDvid5sd5cA3aFXvUv66Ubtz8DlaONMSFq2a666ElQOZjoxP5/hTzy0nmuFAnYZoBOBYHsiQyI9TNJMRSVpLTYIu+wbfrToquTVWo43o9AnC34FI7N3nBvcAOC24Uh7EproYy8lpWOyTb4Eg7WDw80FPfm3dSBOpbHYnddVG/b79GQZq6T/eIuFWo5ABA4BmlrCuldi/fVd6ku2WyVFyDT5csWRDbgdB+jTonHnSDovaQXAU3kUQ7xsPBXnYNWH9roZYCl+QqNloV5sofoZPJxR9I4qcfCsSuQPTLvrGr4I7oMndvgvY8r34J6RD+jQPnzBGqCU5ywC4g0xLwxI6j1HcA6KJR+5QA64cLrcUZbm6Fzg80dEn7WbgowA3BvL0ZoTJKoGBK7SNoaCZAfr7F7SYe//iFY6RTyXjll3DFvctumt76FSPGXKeqo9/kv/H5FOnoPm8aYbpXn9jI7CsyVfNPJksCjufT3zlKLaknN7sUYE7vE9eBUBVv4HkEntxYMwfWEVocSTnsoD/aqpa3ujOqdj1g6ZOKJbIYOg6f2Rg+mpQr6ZrtCnF6lnneYCGuP5zMqzESrXLc/Q8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(36840700001)(40470700004)(46966006)(4326008)(6636002)(316002)(54906003)(37006003)(70206006)(70586007)(6486002)(478600001)(41300700001)(40480700001)(8936002)(5660300002)(6862004)(8676002)(82310400005)(30864003)(2906002)(81166007)(356005)(36756003)(82740400003)(86362001)(36860700001)(33656002)(336012)(2616005)(53546011)(6512007)(107886003)(40460700003)(186003)(26005)(47076005)(83380400001)(6506007)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 12:47:17.9709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8659d4c-50fd-412c-6170-08db3c1d3721 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8223 Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >=20 > Enable Xen to handle the SVE extension, add code in cpufeature module > to handle ZCR SVE register, disable trapping SVE feature on system > boot only when SVE resources are accessed. > While there, correct coding style for the comment on coprocessor > trapping. >=20 > Now cptr_el2 is part of the domain context and it will be restored > on context switch, this is a preparation for saving the SVE context > which will be part of VFP operations, so restore it before the call > to save VFP registers. > To save an additional isb barrier, restore cptr_el2 before an > existing isb barrier and move the call for saving VFP context after > that barrier. >=20 > Change the KConfig entry to make ARM64_SVE symbol selectable, by > default it will be not selected. >=20 > Create sve module and sve_asm.S that contains assembly routines for > the SVE feature, this code is inspired from linux and it uses > instruction encoding to be compatible with compilers that does not > support SVE. >=20 > Signed-off-by: Luca Fancellu > --- > Changes from v4: > - don't use fixed types in vl_to_zcr, forgot to address that in > v3, by mistake I changed that in patch 2, fixing now (Jan) > Changes from v3: > - no changes > Changes from v2: > - renamed sve_asm.S in sve-asm.S, new files should not contain > underscore in the name (Jan) > Changes from v1: > - Add assert to vl_to_zcr, it is never called with vl=3D=3D0, but just > to be sure it won't in the future. > Changes from RFC: > - Moved restoring of cptr before an existing barrier (Julien) > - Marked the feature as unsupported for now (Julien) > - Trap and un-trap only when using SVE resources in > compute_max_zcr() (Julien) > --- > xen/arch/arm/Kconfig | 10 +++-- > xen/arch/arm/arm64/Makefile | 1 + > xen/arch/arm/arm64/cpufeature.c | 7 ++-- > xen/arch/arm/arm64/sve-asm.S | 48 +++++++++++++++++++++++ > xen/arch/arm/arm64/sve.c | 50 ++++++++++++++++++++++++ > xen/arch/arm/cpufeature.c | 6 ++- > xen/arch/arm/domain.c | 9 +++-- > xen/arch/arm/include/asm/arm64/sve.h | 43 ++++++++++++++++++++ > xen/arch/arm/include/asm/arm64/sysregs.h | 1 + > xen/arch/arm/include/asm/cpufeature.h | 14 +++++++ > xen/arch/arm/include/asm/domain.h | 1 + > xen/arch/arm/include/asm/processor.h | 2 + > xen/arch/arm/setup.c | 5 ++- > xen/arch/arm/traps.c | 28 +++++++------ > 14 files changed, 201 insertions(+), 24 deletions(-) > create mode 100644 xen/arch/arm/arm64/sve-asm.S > create mode 100644 xen/arch/arm/arm64/sve.c > create mode 100644 xen/arch/arm/include/asm/arm64/sve.h >=20 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 239d3aed3c7f..41f45d8d1203 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -112,11 +112,15 @@ config ARM64_PTR_AUTH > This feature is not supported in Xen. >=20 > config ARM64_SVE > - def_bool n > + bool "Enable Scalar Vector Extension support (UNSUPPORTED)" if UNSUPPOR= TED > depends on ARM_64 > help > - Scalar Vector Extension support. > - This feature is not supported in Xen. > + Scalar Vector Extension (SVE/SVE2) support for guests. I would prevent to mention SVE2 here unless both versions of SVE are suppor= ted with this config. Is it the case ? Cheers Bertrand > + > + Please be aware that currently, enabling this feature will add latency= on > + VM context switch between SVE enabled guests, between not-enabled SVE > + guests and SVE enabled guests and viceversa, compared to the time > + required to switch between not-enabled SVE guests. >=20 > config ARM64_MTE > def_bool n > diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile > index 6d507da0d44d..24e08fd42596 100644 > --- a/xen/arch/arm/arm64/Makefile > +++ b/xen/arch/arm/arm64/Makefile > @@ -12,6 +12,7 @@ obj-y +=3D insn.o > obj-$(CONFIG_LIVEPATCH) +=3D livepatch.o > obj-y +=3D smc.o > obj-y +=3D smpboot.o > +obj-$(CONFIG_ARM64_SVE) +=3D sve.o sve-asm.o > obj-y +=3D traps.o > obj-y +=3D vfp.o > obj-y +=3D vsysreg.o > diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeat= ure.c > index d9039d37b2d1..b4656ff4d80f 100644 > --- a/xen/arch/arm/arm64/cpufeature.c > +++ b/xen/arch/arm/arm64/cpufeature.c > @@ -455,15 +455,11 @@ static const struct arm64_ftr_bits ftr_id_dfr1[] = =3D { > ARM64_FTR_END, > }; >=20 > -#if 0 > -/* TODO: use this to sanitize SVE once we support it */ > - > static const struct arm64_ftr_bits ftr_zcr[] =3D { > ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, > ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ > ARM64_FTR_END, > }; > -#endif >=20 > /* > * Common ftr bits for a 32bit register with all hidden, strict > @@ -603,6 +599,9 @@ void update_system_features(const struct cpuinfo_arm = *new) >=20 > SANITIZE_ID_REG(zfr64, 0, aa64zfr0); >=20 > + if ( cpu_has_sve ) > + SANITIZE_REG(zcr64, 0, zcr); > + > /* > * Comment from Linux: > * Userspace may perform DC ZVA instructions. Mismatched block sizes > diff --git a/xen/arch/arm/arm64/sve-asm.S b/xen/arch/arm/arm64/sve-asm.S > new file mode 100644 > index 000000000000..4d1549344733 > --- /dev/null > +++ b/xen/arch/arm/arm64/sve-asm.S > @@ -0,0 +1,48 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Arm SVE assembly routines > + * > + * Copyright (C) 2022 ARM Ltd. > + * > + * Some macros and instruction encoding in this file are taken from linu= x 6.1.1, > + * file arch/arm64/include/asm/fpsimdmacros.h, some of them are a modifi= ed > + * version. > + */ > + > +/* Sanity-check macros to help avoid encoding garbage instructions */ > + > +.macro _check_general_reg nr > + .if (\nr) < 0 || (\nr) > 30 > + .error "Bad register number \nr." > + .endif > +.endm > + > +.macro _check_num n, min, max > + .if (\n) < (\min) || (\n) > (\max) > + .error "Number \n out of range [\min,\max]" > + .endif > +.endm > + > +/* SVE instruction encodings for non-SVE-capable assemblers */ > +/* (pre binutils 2.28, all kernel capable clang versions support SVE) */ > + > +/* RDVL X\nx, #\imm */ > +.macro _sve_rdvl nx, imm > + _check_general_reg \nx > + _check_num (\imm), -0x20, 0x1f > + .inst 0x04bf5000 \ > + | (\nx) \ > + | (((\imm) & 0x3f) << 5) > +.endm > + > +/* Gets the current vector register size in bytes */ > +GLOBAL(sve_get_hw_vl) > + _sve_rdvl 0, 1 > + ret > + > +/* > + * Local variables: > + * mode: ASM > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c > new file mode 100644 > index 000000000000..6f3fb368c59b > --- /dev/null > +++ b/xen/arch/arm/arm64/sve.c > @@ -0,0 +1,50 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Arm SVE feature code > + * > + * Copyright (C) 2022 ARM Ltd. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +extern unsigned int sve_get_hw_vl(void); > + > +register_t compute_max_zcr(void) > +{ > + register_t cptr_bits =3D get_default_cptr_flags(); > + register_t zcr =3D vl_to_zcr(SVE_VL_MAX_BITS); > + unsigned int hw_vl; > + > + /* Remove trap for SVE resources */ > + WRITE_SYSREG(cptr_bits & ~HCPTR_CP(8), CPTR_EL2); > + isb(); > + > + /* > + * Set the maximum SVE vector length, doing that we will know the VL > + * supported by the platform, calling sve_get_hw_vl() > + */ > + WRITE_SYSREG(zcr, ZCR_EL2); > + > + /* > + * Read the maximum VL, which could be lower than what we imposed be= fore, > + * hw_vl contains VL in bytes, multiply it by 8 to use vl_to_zcr() l= ater > + */ > + hw_vl =3D sve_get_hw_vl() * 8U; > + > + /* Restore CPTR_EL2 */ > + WRITE_SYSREG(cptr_bits, CPTR_EL2); > + isb(); > + > + return vl_to_zcr(hw_vl); > +} > + > +/* Takes a vector length in bits and returns the ZCR_ELx encoding */ > +register_t vl_to_zcr(unsigned int vl) > +{ > + ASSERT(vl > 0); > + return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; > +} > diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c > index c4ec38bb2554..83b84368f6d5 100644 > --- a/xen/arch/arm/cpufeature.c > +++ b/xen/arch/arm/cpufeature.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include >=20 > DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS); > @@ -143,6 +144,9 @@ void identify_cpu(struct cpuinfo_arm *c) >=20 > c->zfr64.bits[0] =3D READ_SYSREG(ID_AA64ZFR0_EL1); >=20 > + if ( cpu_has_sve ) > + c->zcr64.bits[0] =3D compute_max_zcr(); > + > c->dczid.bits[0] =3D READ_SYSREG(DCZID_EL0); >=20 > c->ctr.bits[0] =3D READ_SYSREG(CTR_EL0); > @@ -199,7 +203,7 @@ static int __init create_guest_cpuinfo(void) > guest_cpuinfo.pfr64.mpam =3D 0; > guest_cpuinfo.pfr64.mpam_frac =3D 0; >=20 > - /* Hide SVE as Xen does not support it */ > + /* Hide SVE by default to the guests */ > guest_cpuinfo.pfr64.sve =3D 0; > guest_cpuinfo.zfr64.bits[0] =3D 0; >=20 > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 99577adb6c69..adb6ace2e24d 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -181,9 +181,6 @@ static void ctxt_switch_to(struct vcpu *n) > /* VGIC */ > gic_restore_state(n); >=20 > - /* VFP */ > - vfp_restore_state(n); > - > /* XXX MPU */ >=20 > /* Fault Status */ > @@ -234,6 +231,7 @@ static void ctxt_switch_to(struct vcpu *n) > p2m_restore_state(n); >=20 > /* Control Registers */ > + WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); > WRITE_SYSREG(n->arch.cpacr, CPACR_EL1); >=20 > /* > @@ -258,6 +256,9 @@ static void ctxt_switch_to(struct vcpu *n) > #endif > isb(); >=20 > + /* VFP */ > + vfp_restore_state(n); > + > /* CP 15 */ > WRITE_SYSREG(n->arch.csselr, CSSELR_EL1); >=20 > @@ -548,6 +549,8 @@ int arch_vcpu_create(struct vcpu *v) >=20 > v->arch.vmpidr =3D MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); >=20 > + v->arch.cptr_el2 =3D get_default_cptr_flags(); > + > v->arch.hcr_el2 =3D get_default_hcr_flags(); >=20 > v->arch.mdcr_el2 =3D HDCR_TDRA | HDCR_TDOSA | HDCR_TDA; > diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/= asm/arm64/sve.h > new file mode 100644 > index 000000000000..144d2b1cc485 > --- /dev/null > +++ b/xen/arch/arm/include/asm/arm64/sve.h > @@ -0,0 +1,43 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Arm SVE feature code > + * > + * Copyright (C) 2022 ARM Ltd. > + */ > + > +#ifndef _ARM_ARM64_SVE_H > +#define _ARM_ARM64_SVE_H > + > +#define SVE_VL_MAX_BITS (2048U) > + > +/* Vector length must be multiple of 128 */ > +#define SVE_VL_MULTIPLE_VAL (128U) > + > +#ifdef CONFIG_ARM64_SVE > + > +register_t compute_max_zcr(void); > +register_t vl_to_zcr(unsigned int vl); > + > +#else /* !CONFIG_ARM64_SVE */ > + > +static inline register_t compute_max_zcr(void) > +{ > + return 0; > +} > + > +static inline register_t vl_to_zcr(unsigned int vl) > +{ > + return 0; > +} > + > +#endif /* CONFIG_ARM64_SVE */ > + > +#endif /* _ARM_ARM64_SVE_H */ > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/incl= ude/asm/arm64/sysregs.h > index 463899951414..4cabb9eb4d5e 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -24,6 +24,7 @@ > #define ICH_EISR_EL2 S3_4_C12_C11_3 > #define ICH_ELSR_EL2 S3_4_C12_C11_5 > #define ICH_VMCR_EL2 S3_4_C12_C11_7 > +#define ZCR_EL2 S3_4_C1_C2_0 >=20 > #define __LR0_EL2(x) S3_4_C12_C12_ ## x > #define __LR8_EL2(x) S3_4_C12_C13_ ## x > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include= /asm/cpufeature.h > index c62cf6293fd6..6d703e051906 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -32,6 +32,12 @@ > #define cpu_has_thumbee (boot_cpu_feature32(thumbee) =3D=3D 1) > #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) >=20 > +#ifdef CONFIG_ARM64_SVE > +#define cpu_has_sve (boot_cpu_feature64(sve) =3D=3D 1) > +#else > +#define cpu_has_sve (0) > +#endif > + > #ifdef CONFIG_ARM_32 > #define cpu_has_gicv3 (boot_cpu_feature32(gic) >=3D 1) > #define cpu_has_gentimer (boot_cpu_feature32(gentimer) =3D=3D 1) > @@ -323,6 +329,14 @@ struct cpuinfo_arm { > }; > } isa64; >=20 > + union { > + register_t bits[1]; > + struct { > + unsigned long len:4; > + unsigned long __res0:60; > + }; > + } zcr64; > + > struct { > register_t bits[1]; > } zfr64; > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm= /domain.h > index 2a51f0ca688e..e776ee704b7d 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -190,6 +190,7 @@ struct arch_vcpu > register_t tpidrro_el0; >=20 > /* HYP configuration */ > + register_t cptr_el2; > register_t hcr_el2; > register_t mdcr_el2; >=20 > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/= asm/processor.h > index 54f253087718..bc683334125c 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -582,6 +582,8 @@ void do_trap_guest_serror(struct cpu_user_regs *regs)= ; >=20 > register_t get_default_hcr_flags(void); >=20 > +register_t get_default_cptr_flags(void); > + > /* > * Synchronize SError unless the feature is selected. > * This is relying on the SErrors are currently unmasked. > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 1f26f67b90e3..5459cc4f5e62 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -135,10 +135,11 @@ static void __init processor_id(void) > cpu_has_el2_32 ? "64+32" : cpu_has_el2_64 ? "64" : "No", > cpu_has_el1_32 ? "64+32" : cpu_has_el1_64 ? "64" : "No", > cpu_has_el0_32 ? "64+32" : cpu_has_el0_64 ? "64" : "No"); > - printk(" Extensions:%s%s%s\n", > + printk(" Extensions:%s%s%s%s\n", > cpu_has_fp ? " FloatingPoint" : "", > cpu_has_simd ? " AdvancedSIMD" : "", > - cpu_has_gicv3 ? " GICv3-SysReg" : ""); > + cpu_has_gicv3 ? " GICv3-SysReg" : "", > + cpu_has_sve ? " SVE" : ""); >=20 > /* Warn user if we find unknown floating-point features */ > if ( cpu_has_fp && (boot_cpu_feature64(fp) >=3D 2) ) > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 061c92acbd68..a78a99ddadd0 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -93,6 +93,21 @@ register_t get_default_hcr_flags(void) > HCR_TID3|HCR_TSC|HCR_TAC|HCR_SWIO|HCR_TIDCP|HCR_FB|HCR_TSW); > } >=20 > +register_t get_default_cptr_flags(void) > +{ > + /* > + * Trap all coprocessor registers (0-13) except cp10 and > + * cp11 for VFP. > + * > + * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. > + * > + * On ARM64 the TCPx bits which we set here (0..9,12,13) are all > + * RES1, i.e. they would trap whether we did this write or not. > + */ > + return ((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | > + HCPTR_TTA | HCPTR_TAM); > +} > + > static enum { > SERRORS_DIVERSE, > SERRORS_PANIC, > @@ -122,6 +137,7 @@ __initcall(update_serrors_cpu_caps); >=20 > void init_traps(void) > { > + register_t cptr_bits =3D get_default_cptr_flags(); > /* > * Setup Hyp vector base. Note they might get updated with the > * branch predictor hardening. > @@ -135,17 +151,7 @@ void init_traps(void) > /* Trap CP15 c15 used for implementation defined registers */ > WRITE_SYSREG(HSTR_T(15), HSTR_EL2); >=20 > - /* Trap all coprocessor registers (0-13) except cp10 and > - * cp11 for VFP. > - * > - * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. > - * > - * On ARM64 the TCPx bits which we set here (0..9,12,13) are all > - * RES1, i.e. they would trap whether we did this write or not. > - */ > - WRITE_SYSREG((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | > - HCPTR_TTA | HCPTR_TAM, > - CPTR_EL2); > + WRITE_SYSREG(cptr_bits, CPTR_EL2); >=20 > /* > * Configure HCR_EL2 with the bare minimum to run Xen until a guest > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520697.808570 (Exim 4.92) (envelope-from ) id 1pmwMJ-0004Br-DV; Thu, 13 Apr 2023 12:47:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520697.808570; Thu, 13 Apr 2023 12:47:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwMJ-0004Bi-9i; Thu, 13 Apr 2023 12:47:27 +0000 Received: by outflank-mailman (input) for mailman id 520697; Thu, 13 Apr 2023 12:47:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwMI-0003wO-Gf for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:47:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7d00::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57aa59ef-d9f9-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 14:47:26 +0200 (CEST) Received: from AS9PR06CA0062.eurprd06.prod.outlook.com (2603:10a6:20b:464::12) by PAWPR08MB10019.eurprd08.prod.outlook.com (2603:10a6:102:362::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 12:47:24 +0000 Received: from AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::80) by AS9PR06CA0062.outlook.office365.com (2603:10a6:20b:464::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 12:47:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT034.mail.protection.outlook.com (100.127.140.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 12:47:23 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 13 Apr 2023 12:47:23 +0000 Received: from ccdb36c774c0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 66580BF8-7DA3-4829-8CD8-35E1FB063A95.1; Thu, 13 Apr 2023 12:47:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ccdb36c774c0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 12:47:17 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB9303.eurprd08.prod.outlook.com (2603:10a6:150:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:47:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 12:47:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57aa59ef-d9f9-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WtygNClpbjg3pL0Vy527GsUXVXEkKMNbd269i/PqNMo=; b=ETlS/QOdPpTuECTtWEZyp3D9n060bLmEZwx8Onjq1xblOQIk5IP97UfChQE1txEjbf81APQNqNKVzZ3XAPziMKHngegmRL5Ke22vq6j1vB3jof5KZ6icjhdiGPWksozVZf2s0RiNV9x0HKEkdEtM+njrFrh+CmngQAuznRCLLug= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a0b35fb7e16df590 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FhqgCvgDE4o7F6D3ZlPK5jMSkditeh3lTLpGpcARQJZhNy3ORKlZ7jM8j5HGMu27yYJQpswjoPfwAoKByxPDWIHSP7+iA7Cs/2XRgd4lhb4mZMzANRG60cPzlfVZeJCYVHj4hBOutC0TKsNjBO+1Kba6AdOFFmrP92y/op6LYh/e3OXg4TpdD5/v8AQr/fTNHKmQ8PT0gku+U74xedzKyiTCzGjpzqTtYGxMh/ZoHfC0bfI7q0bk4NEqemfQU/7QSznkygD33rQSSlV7hHiO08T4vmcnJU/Xtx54kFsdI1YVjvkrNNfDclN6Ddw4UHqVBcZ/59qEUM8LVE4iRmqdpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WtygNClpbjg3pL0Vy527GsUXVXEkKMNbd269i/PqNMo=; b=JFm64lKTGW1DC91hFjvHBcejgR2TYxLgeoH2+8En99qM9ndJpz65P/WE+CvosbQ3AcRkoa/nROTENSezjbSpl+NHpv8OiRdbpx9hjOsKe5OAMNk6OkndwipbTN+mAl5GTk22N+ejXDscS6tZov+xQzf6gg2Duldp68KNbTjnkeSAt7NHG8IjP4wxb+jsZ9CFSG55XUB8Jr344g1h7ruZkWUk/NjTsbVmZUroS5RLgrVnyQUS6wq/SWlyBMXDSYvFvkeyJ/kwMYS1lpLqJbSUps07TeSIWD56/uZvg3vbnH905iTpS2+6H1uxhz5EImNsgMfaRQRnuFTu9M/Xod6HxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WtygNClpbjg3pL0Vy527GsUXVXEkKMNbd269i/PqNMo=; b=ETlS/QOdPpTuECTtWEZyp3D9n060bLmEZwx8Onjq1xblOQIk5IP97UfChQE1txEjbf81APQNqNKVzZ3XAPziMKHngegmRL5Ke22vq6j1vB3jof5KZ6icjhdiGPWksozVZf2s0RiNV9x0HKEkdEtM+njrFrh+CmngQAuznRCLLug= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v5 03/12] xen/arm: Expose SVE feature to the guest Thread-Topic: [PATCH v5 03/12] xen/arm: Expose SVE feature to the guest Thread-Index: AQHZbSQuM7VmfjG4MUSvggInCqBRn68pMdAA Date: Thu, 13 Apr 2023 12:47:14 +0000 Message-ID: <43CDAEBF-D406-4DD8-9C17-00971867B4B8@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-4-luca.fancellu@arm.com> In-Reply-To: <20230412094938.2693890-4-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV2PR08MB9303:EE_|AM7EUR03FT034:EE_|PAWPR08MB10019:EE_ X-MS-Office365-Filtering-Correlation-Id: 6adee899-713e-4829-e4f8-08db3c1d3a72 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lB9lvKG5/lxn9WHr5boZApxnt3l3J5FVFEi2A618vWkcR/cRZH4jQQmiiV8dm8B8EF4ePcWIZ1JZHUbR/MiVd1XxbJ4a4tacq7gXyvgbgDqdoCsgoV9+772GFyCnxnrN5PnqHFO3clMQbr3gjL7IpLH+bDaO6wOwkIFyLk4ZJmQIwkggdwPvyz0NzhuZe5s90MzdzOvwGVxTQo1+/Zt+ff+bTWeXZA5Qk1p5rjSVL2OSOosoVbv+1f++xolXAyNYBsDUCq9h6MwAiO+WX4JWqWTPuIagE4SjuEVOSSAexizpGFZqUfkAETihGiWiupCORZGeb4TmJ6IH1fLnNPB98lqGFvOe0l8/c92i6moN8V/EYvmQHG6nPuOQA9+ewncbAuGTt1FeClB59ipsSHyC/pN5ryworVWyU/y5EjARSXuVm7Owex0nh6h10edac+SeOsN4yNMdA1lYjsarYldKaHQCItB1zdHMNpXZczFYekkj0lizvZ1JKld+/69LIXUBDRHiDZRmavOK/74M7AgjD/ZB2OB5+sTIaX4pdb0jhwrAphT3cRtbk2lFylMVbD1TbRKnlGbprmGq6kq8Yn+EE8R3ovSVGpYwgBYxUZ/wzLv2m/9UcFOOM1gLTrObVIgiyWqM/hSg/pYq6cGRc3b1Iw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199021)(71200400001)(6486002)(64756008)(66446008)(66476007)(66556008)(66946007)(4326008)(36756003)(76116006)(91956017)(37006003)(2906002)(38070700005)(86362001)(122000001)(41300700001)(33656002)(5660300002)(8676002)(8936002)(6862004)(316002)(38100700002)(478600001)(54906003)(6636002)(53546011)(6512007)(6506007)(26005)(2616005)(186003)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <929C3E3C7C006D4CA470CDFCA214CDFA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9303 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f640fbef-ab04-43e7-9890-08db3c1d351d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pu4nV/XhyAXCO2vVeK0uF2MSk6NX4zNnj335MgUhl3SICHum/9faaJk/QGYgmVGNhPlQe3XLN/Nr+yHpc7WCLo2i+0sl72lexDpvgrskJsfayN/C3b/Ng0fFUkHEwJ6O2xSGtch9z8SkIoyFTfthxIf2RwaasPC/JBXVhi7NRBtLknTcnT5g7XiwognzIBBv4XFupfSUq9aQKBXRgZGQiFXUveK052ths19tzUP17bXWYOEZgPBy52nX6/fmN2vgG4vo0ZeTiyMzdGlkMWmwE2/P4xxFteDJMm0vHz3+DZkg75XA+5BZppuCD0ze/E1pvzha2zJFT+eiJ3+7m8ZDQrKMdbS9l0W4tu+aTccozcHozkLedYUsKk4hbOn2YkXlacNX8TGlmbX+ilsHSUWTZnUvYBW6jwrGGXvrIuhXpYMC8P8jHwfEna4E41NxTFGjd8z770kI2Kll5Pq1R9VgeFfdymhJasvlAb+z9PzbbHPKtRrx+9OpxvrAdGg57SXtBeX0XJcJxCal0K0PDF2dAvMSkhoHOY/+BpX51t+0kdV1CoQ845UCE7Y8SxCzk+X57VoK8izvBYAzTZJWKuzdtj0O8Pmi2bwWXQeuaUdWS2LR5ctk4h2t1mHJG84RCPURdd/NCqV8TROXNRWhVBAQa4LYUtL3uf0swxvEIoNiKfgeLMa8cywwe+O4ghbYWMEEZqJ6Hr9bgNlpiGGsgosRWw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199021)(36840700001)(46966006)(40470700004)(70206006)(4326008)(336012)(107886003)(81166007)(37006003)(86362001)(36756003)(54906003)(82310400005)(2906002)(8936002)(8676002)(5660300002)(6862004)(33656002)(478600001)(41300700001)(6636002)(316002)(70586007)(40480700001)(40460700003)(356005)(82740400003)(6506007)(6512007)(26005)(53546011)(6486002)(2616005)(36860700001)(83380400001)(186003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 12:47:23.4758 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6adee899-713e-4829-e4f8-08db3c1d3a72 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10019 Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >=20 > When a guest is allowed to use SVE, expose the SVE features through > the identification registers. >=20 > Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > CHanges from v4: > - no changes > Changes from v3: > - no changes > Changes from v2: > - no changes > Changes from v1: > - No changes > Changes from RFC: > - No changes > --- > xen/arch/arm/arm64/vsysreg.c | 39 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 37 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c > index 758750983c11..10048bb4d221 100644 > --- a/xen/arch/arm/arm64/vsysreg.c > +++ b/xen/arch/arm/arm64/vsysreg.c > @@ -18,6 +18,7 @@ >=20 > #include >=20 > +#include > #include > #include > #include > @@ -295,7 +296,28 @@ void do_sysreg(struct cpu_user_regs *regs, > GENERATE_TID3_INFO(MVFR0_EL1, mvfr, 0) > GENERATE_TID3_INFO(MVFR1_EL1, mvfr, 1) > GENERATE_TID3_INFO(MVFR2_EL1, mvfr, 2) > - GENERATE_TID3_INFO(ID_AA64PFR0_EL1, pfr64, 0) > + > + case HSR_SYSREG_ID_AA64PFR0_EL1: > + { > + register_t guest_reg_value =3D guest_cpuinfo.pfr64.bits[0]; > + > + if ( is_sve_domain(v->domain) ) > + { > + /* 4 is the SVE field width in id_aa64pfr0_el1 */ > + uint64_t mask =3D GENMASK(ID_AA64PFR0_SVE_SHIFT + 4 - 1, > + ID_AA64PFR0_SVE_SHIFT); > + /* sysval is the sve field on the system */ > + uint64_t sysval =3D cpuid_feature_extract_unsigned_field_wid= th( > + system_cpuinfo.pfr64.bits[0], > + ID_AA64PFR0_SVE_SHIFT, 4); > + guest_reg_value &=3D ~mask; > + guest_reg_value |=3D (sysval << ID_AA64PFR0_SVE_SHIFT) & mas= k; > + } > + > + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, > + guest_reg_value); > + } > + > GENERATE_TID3_INFO(ID_AA64PFR1_EL1, pfr64, 1) > GENERATE_TID3_INFO(ID_AA64DFR0_EL1, dbg64, 0) > GENERATE_TID3_INFO(ID_AA64DFR1_EL1, dbg64, 1) > @@ -306,7 +328,20 @@ void do_sysreg(struct cpu_user_regs *regs, > GENERATE_TID3_INFO(ID_AA64MMFR2_EL1, mm64, 2) > GENERATE_TID3_INFO(ID_AA64AFR0_EL1, aux64, 0) > GENERATE_TID3_INFO(ID_AA64AFR1_EL1, aux64, 1) > - GENERATE_TID3_INFO(ID_AA64ZFR0_EL1, zfr64, 0) > + > + case HSR_SYSREG_ID_AA64ZFR0_EL1: > + { > + /* > + * When the guest has the SVE feature enabled, the whole id_aa64= zfr0_el1 > + * needs to be exposed. > + */ > + register_t guest_reg_value =3D guest_cpuinfo.zfr64.bits[0]; > + if ( is_sve_domain(v->domain) ) > + guest_reg_value =3D system_cpuinfo.zfr64.bits[0]; > + > + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, > + guest_reg_value); > + } >=20 > /* > * Those cases are catching all Reserved registers trapped by TID3 wh= ich > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520698.808579 (Exim 4.92) (envelope-from ) id 1pmwMM-0004Si-Lp; Thu, 13 Apr 2023 12:47:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520698.808579; Thu, 13 Apr 2023 12:47:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwMM-0004SZ-IJ; Thu, 13 Apr 2023 12:47:30 +0000 Received: by outflank-mailman (input) for mailman id 520698; Thu, 13 Apr 2023 12:47:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwMK-0003wO-TA for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:47:29 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062d.outbound.protection.outlook.com [2a01:111:f400:7eaf::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58fe0859-d9f9-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 14:47:28 +0200 (CEST) Received: from AM8P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:21b::25) by DU0PR08MB10365.eurprd08.prod.outlook.com (2603:10a6:10:40b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:47:25 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:21b:cafe::7b) by AM8P251CA0020.outlook.office365.com (2603:10a6:20b:21b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 12:47:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 12:47:25 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Thu, 13 Apr 2023 12:47:25 +0000 Received: from c0ea31a0b597.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BE3E619E-DE64-4BA1-ACF0-87A088E72251.1; Thu, 13 Apr 2023 12:47:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0ea31a0b597.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 12:47:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB9303.eurprd08.prod.outlook.com (2603:10a6:150:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 12:47:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 12:47:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58fe0859-d9f9-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zNNA5Fs2ECk9W1QxRKusEU1FI9146iq0S4uPgQ9X4p4=; b=qPJpbpTU5aILNCwtzCg1/HJiplJXKfymVlgW5Tnbglmwy/TjkqF2QMbvR9+dFtClmMAI0Z/HuD37KzNgP9WhZ2pauLOH9GXR8VwczVYJBQ4PZWc0ii70y1G/DkUYm9ltACVe2o6/eHuG4/w5rUUz02MsZ3FomUSglHV7JkHGyEg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: fc6176764ed79353 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8kOLa0CoF0sajb3xxWz98uzFRyIz1fUTjOgb7oIlc+9sBg6O+cTx93N8jvWgYAuaQ1csg4dpc3oGZ9L5aRpOq2TX0sV1YyDmJKBMai+spUtaAr6tnTNuboyLu97w+dQzlH8iotN/H2RgJHuhsJQ7bT5nPM24P1AJ0lg+H4Y6y1I2vcNrZT6sayke1PUxd/9GuvdUQUemtOUGOQw22CE7GF/5EHX3NGheJ760C9upd/PIc+pR7DZx5C6Y21x9/xOblKzU6GJzaY/7nkHECSbLhsAeEu6N1NB5IN8Tb9fKD2DaiinWhZ0Rzx3zKu64YS3SpyMIA1eyeyw8HoGUIbDuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zNNA5Fs2ECk9W1QxRKusEU1FI9146iq0S4uPgQ9X4p4=; b=arapsL8xJNiNzwU+7hkRQ3kdnSeQMrW9mU4wwmuQNiXEfmzi8bZK0BFKcnJIrrWf8l8TAUASSnNg728u5+mjUxee9yoTG4ABVjfiQhyvy7u8kNNlxxNMjxLlHhKDg17yf7ZJzuxL/UFbaSjITkcT1tq8xxWU2A2TKKdlh3zJm0gZm3KAKWaE3xvC7Ff4J4/AtPaOG0JGgFPrkQjEw468+X/Gwn290/FCvjHWBKV/lkCLDDhqluP+WXyT305NYhVOhT9wpVdhpDYwFyulHkHJSeym5y4/IUhwmHFqJ/Uf34rDchFm6FYbfYJ6SiM/2pJcTEMoy/R2Agr4QtdJhmkQdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zNNA5Fs2ECk9W1QxRKusEU1FI9146iq0S4uPgQ9X4p4=; b=qPJpbpTU5aILNCwtzCg1/HJiplJXKfymVlgW5Tnbglmwy/TjkqF2QMbvR9+dFtClmMAI0Z/HuD37KzNgP9WhZ2pauLOH9GXR8VwczVYJBQ4PZWc0ii70y1G/DkUYm9ltACVe2o6/eHuG4/w5rUUz02MsZ3FomUSglHV7JkHGyEg= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Topic: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Index: AQHZbSQrDABwD/+it0m8/HJNYINaK68pMcyA Date: Thu, 13 Apr 2023 12:47:11 +0000 Message-ID: <9486E559-879E-49AF-9145-B929A8EE9301@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> In-Reply-To: <20230412094938.2693890-3-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV2PR08MB9303:EE_|AM7EUR03FT045:EE_|DU0PR08MB10365:EE_ X-MS-Office365-Filtering-Correlation-Id: 235f773e-a398-4c4b-704c-08db3c1d3bac x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qtpnxEsJglGJtaVJS1gd0+NAc2h/fDA7anNR0lRTLNdnQxZS6wnxT8sS+SeEjsi6dJJFOCx0t3w4t23blFlbzXbCIldPwEQ8e66O/0/Lj4U6lNQxeLiJp7J+PmgAwl6m34GhP677CxwbLXcO+Dxay8YpzVQtTZvEx4KyETTcLu/IE5Mb3I843TWz8bkPFejTaVAa3QjN8qhnR+/K7wbwrhNvVF1prtBVh6ztG2S9V0kW0L9mCdYAmV9ZBu7eKFwAvclEOEHxMIXVCtZIJhkYy9C6uinUnznTjXwrR3J/Lqb4RfJpW6rStRcIj6Xsm48WTN8xX89NV/oGIseyfmdiGn3/fDaQOn+o+m4HjoXRSNirff5ClOj03ZJnV7BLkZQsjMeao8ruTU47KvYwVEWKq/xyaOQlv1OwzYtHuLdVv3hD8JQE+Ujzvk2MSopRw5BZm4Mkzm3lmxDmLYu0tahlpVGomAvZ+Z0bpMrmsC5IVw8U2fdxfJqzf7tlXCsuKfEB+F1Dhqnav04nGKC7+xBMcNkT5sQkU608l2Q9AdsfpbQ47G6AtgzPhiJ8MunEFuZiS7zkNIh2VVINm8PL35bhAZgB9C5GH3OD/hqdrCBD3H1qq3NxskQkCgq8mO+EDVWW5H/QOwPkWUgWcc9NtwyjBw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199021)(71200400001)(6486002)(64756008)(66446008)(66476007)(66556008)(66946007)(4326008)(36756003)(76116006)(91956017)(37006003)(2906002)(38070700005)(86362001)(122000001)(41300700001)(33656002)(5660300002)(8676002)(8936002)(6862004)(316002)(38100700002)(478600001)(54906003)(6636002)(53546011)(6512007)(6506007)(26005)(2616005)(186003)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9303 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 67c33dcd-4937-410a-dae4-08db3c1d3353 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F9LRtjO4DVq56VTr+Tuyy8SAg4pQfZTYyUsFaManOQpsCQg1F3kYVIINKfz8gx1Thp4VeuBnRBDoVuPeZFbLDxE8x1hIb42M3vTfRqgbEXzeJQ9O3xvJED9tkRfvDcFMqHn70jdDmmoTRT0XomSh+y7AOAG/1QBeqiE+M8F1E+LSCUFinGUhcmNpxzEZe7YxLNbaa+R2AEuM/BDel8WiHOS3b3mheG7pLUGArlEMUaZmAZEMy8bCtrcAlxsMoWxVbUprs4udrKuVcdHNU3QsQiQR+FyKUW9RydfQlC5+aYzhfwl7/oPIGPNW+Df0SArMDhzNM4JPdXr1wOazo8nWNaChCn8g+xjnP3lkuIsPuA6KuBSHg2ZXr3h4AUN5hsBdjRaOgmgWdWFiHGyi2yzraUIJoO9Udi8zdSnwsyLfdLf3mAcmZ7OCuSvqa/a2+12/sDyZba8llbltcOFqn/zhUzJonW9Ro/vYLPswpphnxvDCozr3Rh6Jyd2pQlqYezLWvsW+hVRYGTv/5KRKNZx/X+REYAU5hXKMTnaAsOR1RCSc4XAuKsaStdXjM5tNYloi/WffTRidgUFlZvsoUFuCi9WJLjW3PB6LguTWrmJyS9YIcDTy8vS5A0rhAkEg6xxjCj7V7tBDXfuQAZGEaYXsplux5oK5jJnxZv0m3BK0VueKfvMvBuMtknbxni4gLYmrwu7EVVbFrLK5KK6PPVjIig== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199021)(36840700001)(40470700004)(46966006)(36860700001)(40480700001)(82740400003)(2616005)(336012)(47076005)(53546011)(40460700003)(6506007)(6512007)(2906002)(26005)(33656002)(186003)(82310400005)(81166007)(356005)(8936002)(83380400001)(70206006)(70586007)(86362001)(6486002)(478600001)(36756003)(6636002)(5660300002)(6862004)(316002)(4326008)(8676002)(54906003)(41300700001)(37006003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 12:47:25.5150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 235f773e-a398-4c4b-704c-08db3c1d3bac X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10365 Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >=20 > Add sve_vl field to arch_domain and xen_arch_domainconfig struct, > to allow the domain to have an information about the SVE feature > and the number of SVE register bits that are allowed for this > domain. >=20 Please mention in the commit message that you are bumping domctl interface version. > sve_vl field is the vector length in bits divided by 128, this > allows to use less space in the structures. >=20 > The field is used also to allow or forbid a domain to use SVE, > because a value equal to zero means the guest is not allowed to > use the feature. >=20 > Check that the requested vector length is lower or equal to the > platform supported vector length, otherwise fail on domain > creation. >=20 > Signed-off-by: Luca Fancellu With the commit message fixed: Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes from v4: > - Return 0 in get_sys_vl_len() if sve is not supported, code style fix, > removed else if since the conditions can't fallthrough, removed not > needed condition checking for VL bits validity because it's already > covered, so delete is_vl_valid() function. (Jan) > Changes from v3: > - don't use fixed types when not needed, use encoded value also in > arch_domain so rename sve_vl_bits in sve_vl. (Jan) > - rename domainconfig_decode_vl to sve_decode_vl because it will now > be used also to decode from arch_domain value > - change sve_vl from uint16_t to uint8_t and move it after "type" field > to optimize space. > Changes from v2: > - rename field in xen_arch_domainconfig from "sve_vl_bits" to > "sve_vl" and use the implicit padding after gic_version to > store it, now this field is the VL/128. (Jan) > - Created domainconfig_decode_vl() function to decode the sve_vl > field and use it as plain bits value inside arch_domain. > - Changed commit message reflecting the changes > Changes from v1: > - no changes > Changes from RFC: > - restore zcr_el2 in sve_restore_state, that will be introduced > later in this serie, so remove zcr_el2 related code from this > patch and move everything to the later patch (Julien) > - add explicit padding into struct xen_arch_domainconfig (Julien) > - Don't lower down the vector length, just fail to create the > domain. (Julien) > --- > xen/arch/arm/arm64/sve.c | 12 ++++++++++++ > xen/arch/arm/domain.c | 27 +++++++++++++++++++++++++++ > xen/arch/arm/include/asm/arm64/sve.h | 12 ++++++++++++ > xen/arch/arm/include/asm/domain.h | 5 +++++ > xen/include/public/arch-arm.h | 2 ++ > xen/include/public/domctl.h | 2 +- > 6 files changed, 59 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c > index 6f3fb368c59b..78f7482619da 100644 > --- a/xen/arch/arm/arm64/sve.c > +++ b/xen/arch/arm/arm64/sve.c > @@ -6,6 +6,7 @@ > */ >=20 > #include > +#include > #include > #include > #include > @@ -48,3 +49,14 @@ register_t vl_to_zcr(unsigned int vl) > ASSERT(vl > 0); > return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; > } > + > +/* Get the system sanitized value for VL in bits */ > +unsigned int get_sys_vl_len(void) > +{ > + if ( !cpu_has_sve ) > + return 0; > + > + /* ZCR_ELx len field is ((len+1) * 128) =3D vector bits length */ > + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * > + SVE_VL_MULTIPLE_VAL; > +} > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index adb6ace2e24d..769fae8fe25e 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -13,6 +13,7 @@ > #include >=20 > #include > +#include > #include > #include > #include > @@ -550,6 +551,8 @@ int arch_vcpu_create(struct vcpu *v) > v->arch.vmpidr =3D MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); >=20 > v->arch.cptr_el2 =3D get_default_cptr_flags(); > + if ( is_sve_domain(v->domain) ) > + v->arch.cptr_el2 &=3D ~HCPTR_CP(8); >=20 > v->arch.hcr_el2 =3D get_default_hcr_flags(); >=20 > @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_cre= atedomain *config) > unsigned int max_vcpus; > unsigned int flags_required =3D (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_= hap); > unsigned int flags_optional =3D (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CD= F_vpmu); > + unsigned int sve_vl_bits =3D sve_decode_vl(config->arch.sve_vl); >=20 > if ( (config->flags & ~flags_optional) !=3D flags_required ) > { > @@ -602,6 +606,26 @@ int arch_sanitise_domain_config(struct xen_domctl_cr= eatedomain *config) > return -EINVAL; > } >=20 > + /* Check feature flags */ > + if ( sve_vl_bits > 0 ) > + { > + unsigned int zcr_max_bits =3D get_sys_vl_len(); > + > + if ( !zcr_max_bits ) > + { > + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"= ); > + return -EINVAL; > + } > + > + if ( sve_vl_bits > zcr_max_bits ) > + { > + dprintk(XENLOG_INFO, > + "Requested SVE vector length (%u) > supported length= (%u)\n", > + sve_vl_bits, zcr_max_bits); > + return -EINVAL; > + } > + } > + > /* The P2M table must always be shared between the CPU and the IOMMU = */ > if ( config->iommu_opts & XEN_DOMCTL_IOMMU_no_sharept ) > { > @@ -744,6 +768,9 @@ int arch_domain_create(struct domain *d, > if ( (rc =3D domain_vpci_init(d)) !=3D 0 ) > goto fail; >=20 > + /* Copy the encoded vector length sve_vl from the domain configurati= on */ > + d->arch.sve_vl =3D config->arch.sve_vl; > + > return 0; >=20 > fail: > diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/= asm/arm64/sve.h > index 144d2b1cc485..a4c53e3e8e2e 100644 > --- a/xen/arch/arm/include/asm/arm64/sve.h > +++ b/xen/arch/arm/include/asm/arm64/sve.h > @@ -13,10 +13,17 @@ > /* Vector length must be multiple of 128 */ > #define SVE_VL_MULTIPLE_VAL (128U) >=20 > +static inline unsigned int sve_decode_vl(unsigned int sve_vl) > +{ > + /* SVE vector length is stored as VL/128 in xen_arch_domainconfig */ > + return sve_vl * SVE_VL_MULTIPLE_VAL; > +} > + > #ifdef CONFIG_ARM64_SVE >=20 > register_t compute_max_zcr(void); > register_t vl_to_zcr(unsigned int vl); > +unsigned int get_sys_vl_len(void); >=20 > #else /* !CONFIG_ARM64_SVE */ >=20 > @@ -30,6 +37,11 @@ static inline register_t vl_to_zcr(unsigned int vl) > return 0; > } >=20 > +static inline unsigned int get_sys_vl_len(void) > +{ > + return 0; > +} > + > #endif /* CONFIG_ARM64_SVE */ >=20 > #endif /* _ARM_ARM64_SVE_H */ > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm= /domain.h > index e776ee704b7d..78cc2da3d4e5 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -31,6 +31,8 @@ enum domain_type { >=20 > #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) >=20 > +#define is_sve_domain(d) ((d)->arch.sve_vl > 0) > + > /* > * Is the domain using the host memory layout? > * > @@ -67,6 +69,9 @@ struct arch_domain > enum domain_type type; > #endif >=20 > + /* max SVE encoded vector length */ > + uint8_t sve_vl; > + > /* Virtual MMU */ > struct p2m_domain p2m; >=20 > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.= h > index 1528ced5097a..38311f559581 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -300,6 +300,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > + /* IN - Contains SVE vector length divided by 128 */ > + uint8_t sve_vl; > /* IN */ > uint16_t tee_type; > /* IN */ > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index 529801c89ba3..e2e22cb534d6 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -21,7 +21,7 @@ > #include "hvm/save.h" > #include "memory.h" >=20 > -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 > +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016 >=20 > /* > * NB. xen_domctl.domain is an IN/OUT parameter for this operation. > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 12:57:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 12:57:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520710.808590 (Exim 4.92) (envelope-from ) id 1pmwVz-0006e2-PY; Thu, 13 Apr 2023 12:57:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520710.808590; Thu, 13 Apr 2023 12:57:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwVz-0006dv-MJ; Thu, 13 Apr 2023 12:57:27 +0000 Received: by outflank-mailman (input) for mailman id 520710; Thu, 13 Apr 2023 12:57:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwVx-0006dp-NG for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 12:57:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwVx-0002Vl-7Q; Thu, 13 Apr 2023 12:57:25 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmwVw-00061S-Vg; Thu, 13 Apr 2023 12:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=euzWDavnCtCzLiLiWNGNCKiDquQF7a7twnh2ruC0fqw=; b=2lqpvHyeicongDvjHdkFlly8za qhrlAPqaxNQla6oXuF1lT9/o1+z7Dne5zHlkounh7AcpyQuB4w9CpgR361OIh0g6WCr+8gy1Zgjb/ hDevg7+ZKTCu9NJfiMy2o2MNOJmYl9n3p5l13u0FeaJCU3SwIT96GpICHw3CVkQhkdiY=; Message-ID: <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> Date: Thu, 13 Apr 2023 13:57:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230412094938.2693890-3-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 12/04/2023 10:49, Luca Fancellu wrote: > Add sve_vl field to arch_domain and xen_arch_domainconfig struct, > to allow the domain to have an information about the SVE feature > and the number of SVE register bits that are allowed for this > domain. > > sve_vl field is the vector length in bits divided by 128, this > allows to use less space in the structures. > > The field is used also to allow or forbid a domain to use SVE, > because a value equal to zero means the guest is not allowed to > use the feature. > > Check that the requested vector length is lower or equal to the > platform supported vector length, otherwise fail on domain > creation. > > Signed-off-by: Luca Fancellu > --- > Changes from v4: > - Return 0 in get_sys_vl_len() if sve is not supported, code style fix, > removed else if since the conditions can't fallthrough, removed not > needed condition checking for VL bits validity because it's already > covered, so delete is_vl_valid() function. (Jan) > Changes from v3: > - don't use fixed types when not needed, use encoded value also in > arch_domain so rename sve_vl_bits in sve_vl. (Jan) > - rename domainconfig_decode_vl to sve_decode_vl because it will now > be used also to decode from arch_domain value > - change sve_vl from uint16_t to uint8_t and move it after "type" field > to optimize space. > Changes from v2: > - rename field in xen_arch_domainconfig from "sve_vl_bits" to > "sve_vl" and use the implicit padding after gic_version to > store it, now this field is the VL/128. (Jan) > - Created domainconfig_decode_vl() function to decode the sve_vl > field and use it as plain bits value inside arch_domain. > - Changed commit message reflecting the changes > Changes from v1: > - no changes > Changes from RFC: > - restore zcr_el2 in sve_restore_state, that will be introduced > later in this serie, so remove zcr_el2 related code from this > patch and move everything to the later patch (Julien) > - add explicit padding into struct xen_arch_domainconfig (Julien) > - Don't lower down the vector length, just fail to create the > domain. (Julien) > --- > xen/arch/arm/arm64/sve.c | 12 ++++++++++++ > xen/arch/arm/domain.c | 27 +++++++++++++++++++++++++++ > xen/arch/arm/include/asm/arm64/sve.h | 12 ++++++++++++ > xen/arch/arm/include/asm/domain.h | 5 +++++ > xen/include/public/arch-arm.h | 2 ++ > xen/include/public/domctl.h | 2 +- > 6 files changed, 59 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c > index 6f3fb368c59b..78f7482619da 100644 > --- a/xen/arch/arm/arm64/sve.c > +++ b/xen/arch/arm/arm64/sve.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -48,3 +49,14 @@ register_t vl_to_zcr(unsigned int vl) > ASSERT(vl > 0); > return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; > } > + > +/* Get the system sanitized value for VL in bits */ > +unsigned int get_sys_vl_len(void) > +{ > + if ( !cpu_has_sve ) > + return 0; > + > + /* ZCR_ELx len field is ((len+1) * 128) = vector bits length */ > + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * > + SVE_VL_MULTIPLE_VAL; > +} > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index adb6ace2e24d..769fae8fe25e 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -13,6 +13,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -550,6 +551,8 @@ int arch_vcpu_create(struct vcpu *v) > v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); > > v->arch.cptr_el2 = get_default_cptr_flags(); > + if ( is_sve_domain(v->domain) ) > + v->arch.cptr_el2 &= ~HCPTR_CP(8); > > v->arch.hcr_el2 = get_default_hcr_flags(); > > @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) > unsigned int max_vcpus; > unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); > unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); > + unsigned int sve_vl_bits = sve_decode_vl(config->arch.sve_vl); > > if ( (config->flags & ~flags_optional) != flags_required ) > { > @@ -602,6 +606,26 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) > return -EINVAL; > } > > + /* Check feature flags */ > + if ( sve_vl_bits > 0 ) > + { > + unsigned int zcr_max_bits = get_sys_vl_len(); > + > + if ( !zcr_max_bits ) > + { > + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); > + return -EINVAL; > + } > + > + if ( sve_vl_bits > zcr_max_bits ) > + { > + dprintk(XENLOG_INFO, > + "Requested SVE vector length (%u) > supported length (%u)\n", > + sve_vl_bits, zcr_max_bits); > + return -EINVAL; > + } Is SVE supported for 32-bit guest? If not, then you should had a check here to prevent the creation of the domain if sve_vl_bits is set. > + } > + > /* The P2M table must always be shared between the CPU and the IOMMU */ > if ( config->iommu_opts & XEN_DOMCTL_IOMMU_no_sharept ) > { > @@ -744,6 +768,9 @@ int arch_domain_create(struct domain *d, > if ( (rc = domain_vpci_init(d)) != 0 ) > goto fail; > > + /* Copy the encoded vector length sve_vl from the domain configuration */ > + d->arch.sve_vl = config->arch.sve_vl; > + > return 0; > > fail: > diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h > index 144d2b1cc485..a4c53e3e8e2e 100644 > --- a/xen/arch/arm/include/asm/arm64/sve.h > +++ b/xen/arch/arm/include/asm/arm64/sve.h > @@ -13,10 +13,17 @@ > /* Vector length must be multiple of 128 */ > #define SVE_VL_MULTIPLE_VAL (128U) > > +static inline unsigned int sve_decode_vl(unsigned int sve_vl) > +{ > + /* SVE vector length is stored as VL/128 in xen_arch_domainconfig */ > + return sve_vl * SVE_VL_MULTIPLE_VAL; > +} > + > #ifdef CONFIG_ARM64_SVE > > register_t compute_max_zcr(void); > register_t vl_to_zcr(unsigned int vl); > +unsigned int get_sys_vl_len(void); > > #else /* !CONFIG_ARM64_SVE */ > > @@ -30,6 +37,11 @@ static inline register_t vl_to_zcr(unsigned int vl) > return 0; > } > > +static inline unsigned int get_sys_vl_len(void) > +{ > + return 0; > +} > + > #endif /* CONFIG_ARM64_SVE */ > > #endif /* _ARM_ARM64_SVE_H */ > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > index e776ee704b7d..78cc2da3d4e5 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -31,6 +31,8 @@ enum domain_type { > > #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) > > +#define is_sve_domain(d) ((d)->arch.sve_vl > 0) > + > /* > * Is the domain using the host memory layout? > * > @@ -67,6 +69,9 @@ struct arch_domain > enum domain_type type; > #endif > > + /* max SVE encoded vector length */ > + uint8_t sve_vl; > + Can we move this somewhere else to avoid adding extra padding? Also shouldn't this be protected with #ifdef CONFIG_ARM_64 to make clear this is not supported on Xen 32-bit? > /* Virtual MMU */ > struct p2m_domain p2m; > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index 1528ced5097a..38311f559581 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -300,6 +300,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > + /* IN - Contains SVE vector length divided by 128 */ > + uint8_t sve_vl; > /* IN */ > uint16_t tee_type; > /* IN */ > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index 529801c89ba3..e2e22cb534d6 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -21,7 +21,7 @@ > #include "hvm/save.h" > #include "memory.h" > > -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 > +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016 > > /* > * NB. xen_domctl.domain is an IN/OUT parameter for this operation. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:02:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520714.808600 (Exim 4.92) (envelope-from ) id 1pmwb0-00087N-BR; Thu, 13 Apr 2023 13:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520714.808600; Thu, 13 Apr 2023 13:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwb0-00087G-8h; Thu, 13 Apr 2023 13:02:38 +0000 Received: by outflank-mailman (input) for mailman id 520714; Thu, 13 Apr 2023 13:02:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwaz-000879-Hy for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:02:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwaz-0002n9-5E; Thu, 13 Apr 2023 13:02:37 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmway-0006K5-Qg; Thu, 13 Apr 2023 13:02:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lLBVMFdXzSBS66TcytgO+g8bcAII3N0qP+rdanIkDHQ=; b=tedVXxabetuTfyaivXg1gnnsAk ZbSl6eRRYKWwj+x8yqtpPAXHoya6hubplba9I5G690pY9495YDzbO5aMuITBA0mt/98si6ADua3UI lYpriE9aU+DQTBG2weHoXE5pdZ6loGyHivgfkbMezfe5rB8oDutS1g0W7IzoZwjYecF0=; Message-ID: Date: Thu, 13 Apr 2023 14:02:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5 04/12] xen/arm: add SVE exception class handling Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-5-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230412094938.2693890-5-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 12/04/2023 10:49, Luca Fancellu wrote: > SVE has a new exception class with code 0x19, introduce the new code > and handle the exception. > > Signed-off-by: Luca Fancellu > --- > Changes from v4: > - No changes > Changes from v3: > - No changes > Changes from v2: > - No changes > Changes from v1: > - No changes > Changes from RFC: > - No changes > --- > xen/arch/arm/include/asm/processor.h | 1 + > xen/arch/arm/traps.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h > index bc683334125c..7e42ff8811fc 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -426,6 +426,7 @@ > #define HSR_EC_HVC64 0x16 > #define HSR_EC_SMC64 0x17 > #define HSR_EC_SYSREG 0x18 > +#define HSR_EC_SVE 0x19 > #endif > #define HSR_EC_INSTR_ABORT_LOWER_EL 0x20 > #define HSR_EC_INSTR_ABORT_CURR_EL 0x21 > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index a78a99ddadd0..c2e30feafd5a 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -2160,6 +2160,13 @@ void do_trap_guest_sync(struct cpu_user_regs *regs) > perfc_incr(trap_sysreg); > do_sysreg(regs, hsr); > break; > + case HSR_EC_SVE: > + GUEST_BUG_ON(regs_mode_is_32bit(regs)); > + gprintk(XENLOG_WARNING, > + "Domain id %d tried to use SVE while not allowed\n", > + current->domain->domain_id); gprintk() will already print the domain/vCPU for you. Also, if you want to print a domain ID, then you should use ("%pd", d) rather than ("%d", d->domain_id). > + inject_undef_exception(regs, hsr); > + break; > #endif > > case HSR_EC_INSTR_ABORT_LOWER_EL: > @@ -2189,6 +2196,11 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) > case HSR_EC_BRK: > do_trap_brk(regs, hsr); > break; > + case HSR_EC_SVE: > + /* An SVE exception is a bug somewhere in hypervisor code */ > + printk("SVE trap at EL2.\n"); > + do_unexpected_trap("Hypervisor", regs); I think it would be better if you pass "SVE trap at EL2" as a string rather than adding your own printk above. > + break; > #endif > case HSR_EC_DATA_ABORT_CURR_EL: > case HSR_EC_INSTR_ABORT_CURR_EL: Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:12:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520720.808620 (Exim 4.92) (envelope-from ) id 1pmwjv-0001Q1-Fy; Thu, 13 Apr 2023 13:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520720.808620; Thu, 13 Apr 2023 13:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwjv-0001Pu-DE; Thu, 13 Apr 2023 13:11:51 +0000 Received: by outflank-mailman (input) for mailman id 520720; Thu, 13 Apr 2023 13:11:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwjt-0001Je-VE for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:11:50 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20620.outbound.protection.outlook.com [2a01:111:f400:7e89::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be31e67d-d9fc-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 15:11:48 +0200 (CEST) Received: from MW4PR04CA0316.namprd04.prod.outlook.com (2603:10b6:303:82::21) by CH0PR12MB5297.namprd12.prod.outlook.com (2603:10b6:610:d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:11:41 +0000 Received: from CO1NAM11FT098.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::8a) by MW4PR04CA0316.outlook.office365.com (2603:10b6:303:82::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 13:11:41 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT098.mail.protection.outlook.com (10.13.174.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:11:40 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 08:11:40 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 06:11:14 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 08:11:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be31e67d-d9fc-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzzymER0toW5nB1v0r0f2DToC/RXaZF4U7IwogO2bnKAwVWktI2PsFALZNF0lakDL1f2egZY3hMuCIl6391JkXXhnEj+KTAhqktTySXC9ykUZpdAOlfrfu6ktlTqRiOhlmVaAmq9MFq++bpKM+30c5hki+l2xdH4WrhNGA2O3n1o4N5d/mOzIZVN7Zz3dCAOvFB3G2u6Tv2Cjere2TPUzhRx8qvsI1wTgzTq8RTnJltCPg2YBPG6hbTdsEXzNNhDXOKMjZWPfE+YoZmKkZ78F2WptIthHxuyBbGhCwSLvmDQuKs91d9fBCspSr8Wh6agtqkFyicA60oeN8AEinCoiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TqkGxVz3dOyXztzEvg0vAz1bCZKFuJHjXDqMEbM0hmg=; b=iDGUKblwiUMmNyed67Y1WqLR0xolo81hyjTGtd1rkYZyXN55VNzKoL0DmOI7CXDTosrYzesuIq4jp5uB4NCxxW8KWmNBihvVHXavbp5ePs8LzrL/LGr+3npTnR1eUj81vwg8Ivv1o6UdbEaea2ssrPDKUSlwxPW6MKxZrcRvhdqCK0e02Tyx7O7IcM0BQW0wDWOfRQUeCCnIRx9tmVG3NkTh3umWPUF8kbI64RX40J6bJVfn8xupOv7oP0diNJ1aJsTwu05z43lC+TvOxwsmnkfMLt36s3ZTuqMY8wV08jy2nBSLeG0zPI8Z3qJJCFsU/x7TXqCQEid9EtUoPsmvSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TqkGxVz3dOyXztzEvg0vAz1bCZKFuJHjXDqMEbM0hmg=; b=JcYQA51yhZphLxR6iLl4oNhK0nWgvxMphMRgYPAsvd/lMNpF8bbJnoGQj1y2Q/JltqHzW3x0asVwqnZKw9ahie4VWKq8h94Fx3RBYppX9ExmbtEKnq8V4QXRK5q8VBCOk807Jyw4oHnGTGtdr6CaFhQPKHNW/emE8RxWaBmsWCw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <601858e2-79b5-35da-df00-2d9061d8ff22@amd.com> Date: Thu, 13 Apr 2023 15:11:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target() Content-Language: en-US To: Vikram Garhwal , CC: , Julien Grall , Vikram Garhwal , David Gibson References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-6-vikram.garhwal@amd.com> From: Michal Orzel In-Reply-To: <20230411191636.26926-6-vikram.garhwal@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT098:EE_|CH0PR12MB5297:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ef6d78c-5b73-49a7-5ea5-08db3c209ef1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kiE6guV/k+HDzEEn1ZkFLD85vm2IdTtJhI8Q/sIbbvGhGAAPKnGwd1e56yCm3+pKbnrBy6eiFcEGsFFT4prsgS7vu7JXQ3b2Q9Zo0lhpQ7qUyAi4aIoETX+8im40s9hZZ8j7BkS9om65HEf3mlGvfpDvmQ6aoKXjpFdfb+G5CDCKTCoiGi7bKZhr3UlHr4u2shmOcMTg+WqlHD+qsiWWltSHVH1QI+ts7Q9IlhYZ2tnzRHNTzkc1wnVF3Wo8mLqCO8Eudpl88HoVMg+NrDp+9oCYbzelqnK1ftrzGw5go4+1NoHR5dElavof8PnHCdBXDuASSANM40hoyXvWXqYfKVZV5zrdbZff/KJFmT98mSOEiYZ28Ctzj2xwuyXGRD45HCoIdMHBScpmPsdaKmH0H0cgYW1aFKhftp3kt4QeOr2RziNNC0KQvNLcRC5lanVru+rHOuTU5BMsr+Mfr8EodjXuUsm5WuHw2KFS/SaU2r6g4ySYvlfLdZZXMF8toO2unStZQnftq0nzBOe3yQlglmqgbhusu6ndy+uAOLUR2o4/hZ4MctqhBTop01VezrUstvOjlKy1s8HtWgFvMtxIDH37yDym9xsoI61sG084JuuveQWJkxLUZbH7p/UQykuYlfEnGON+NZSiBMm2ajx4QL71SbB04sPTts+/ix45Om8vqAem3oR+5hOa8k20MHMFLrbNekdRtHxbYf13diuFWnwDQ2QjS/FgWagz6vt+lIRHh2Qlx/yJHtMTtq4OUbnX X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(46966006)(36840700001)(40470700004)(31686004)(36860700001)(336012)(5660300002)(36756003)(2906002)(44832011)(31696002)(316002)(40480700001)(8676002)(8936002)(86362001)(41300700001)(81166007)(356005)(40460700003)(82310400005)(4326008)(82740400003)(966005)(70206006)(426003)(70586007)(2616005)(83380400001)(47076005)(54906003)(16576012)(186003)(478600001)(110136005)(26005)(53546011)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:11:40.4577 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef6d78c-5b73-49a7-5ea5-08db3c209ef1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT098.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5297 Hi Vikram, On 11/04/2023 21:16, Vikram Garhwal wrote: > > > Rename overlay_get_target() to fdt_overlay_target_offset() and remove static > function type. > > This is done to get the target path for the overlay nodes which is very useful > in many cases. For example, Xen hypervisor needs it when applying overlays > because Xen needs to do further processing of the overlay nodes, e.g. mapping of > resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc. > > Signed-off-by: Vikram Garhwal > Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> > Signed-off-by: David Gibson > Origin: https://github.com/dgibson/dtc 45f3d1a095dd Wouldn't it be better to point to the main dtc repository under kernel.org rather than github? Origin: git://git.kernel.org/pub/scm/utils/dtc/dtc.git 45f3d1a095dd > > Signed-off-by: Vikram Garhwal In any case: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:12:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520719.808610 (Exim 4.92) (envelope-from ) id 1pmwjt-0001B2-7K; Thu, 13 Apr 2023 13:11:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520719.808610; Thu, 13 Apr 2023 13:11:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwjt-0001Av-4B; Thu, 13 Apr 2023 13:11:49 +0000 Received: by outflank-mailman (input) for mailman id 520719; Thu, 13 Apr 2023 13:11:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwjr-0001Al-Jp for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:11:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwjr-0002wV-9t; Thu, 13 Apr 2023 13:11:47 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmwjr-0006lZ-2G; Thu, 13 Apr 2023 13:11:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cB0gGg5I8BEmRP1ArCMDNiP+A+rPj1v4EFP5w+9h0Ag=; b=NOCJdMWRKxQvB1M3A+YCfXQXle CdjRmnSswtmSpUGuO6gjgVFOieDVNsyHCp4I9L7QfifT5P85vtia+FvbJjM04vzyyNBhBVemU0LF2 Jhwwvj5JFrv45+scamQYgya016BvJfvc+SU9itteOZdqXubltOTY9e6n/3K7ImXvVtfk=; Message-ID: Date: Thu, 13 Apr 2023 14:11:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5 05/12] arm/sve: save/restore SVE context switch Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-6-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230412094938.2693890-6-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/04/2023 10:49, Luca Fancellu wrote: > Save/restore context switch for SVE, allocate memory to contain > the Z0-31 registers whose length is maximum 2048 bits each and > FFR who can be maximum 256 bits, the allocated memory depends on > how many bits is the vector length for the domain and how many bits > are supported by the platform. > > Save P0-15 whose length is maximum 256 bits each, in this case the > memory used is from the fpregs field in struct vfp_state, > because V0-31 are part of Z0-31 and this space would have been > unused for SVE domain otherwise. > > Create zcr_el{1,2} fields in arch_vcpu, initialise zcr_el2 on vcpu > creation given the requested vector length and restore it on > context switch, save/restore ZCR_EL1 value as well. > > Remove headers from sve.c that are already included using > xen/sched.h. I dislike this because ... > diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c > index 78f7482619da..5485648850a0 100644 > --- a/xen/arch/arm/arm64/sve.c > +++ b/xen/arch/arm/arm64/sve.c > @@ -5,14 +5,29 @@ > * Copyright (C) 2022 ARM Ltd. > */ > > -#include > -#include ... it is not entirely obvious that sched.h will import asm/cpufeatures.h. This could easily change in the future and would only require us to re-add those includes. > +#include > +#include > #include > -#include > -#include > -#include > > extern unsigned int sve_get_hw_vl(void); > +extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); > +extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, > + int restore_ffr); > + > +static inline unsigned int sve_zreg_ctx_size(unsigned int vl) > +{ > + /* > + * Z0-31 registers size in bytes is computed from VL that is in bits, so VL > + * in bytes is VL/8. > + */ > + return (vl / 8U) * 32U; > +} > + > +static inline unsigned int sve_ffrreg_ctx_size(unsigned int vl) > +{ > + /* FFR register size is VL/8, which is in bytes (VL/8)/8 */ > + return (vl / 64U); > +} > > register_t compute_max_zcr(void) > { > @@ -60,3 +75,46 @@ unsigned int get_sys_vl_len(void) > return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * > SVE_VL_MULTIPLE_VAL; > } > + > +int sve_context_init(struct vcpu *v) > +{ > + unsigned int sve_vl_bits = sve_decode_vl(v->domain->arch.sve_vl); > + uint64_t *ctx = _xzalloc(sve_zreg_ctx_size(sve_vl_bits) + > + sve_ffrreg_ctx_size(sve_vl_bits), > + L1_CACHE_BYTES); > + > + if ( !ctx ) > + return -ENOMEM; > + > + v->arch.vfp.sve_context = ctx; > + > + return 0; > +} > + > +void sve_context_free(struct vcpu *v) > +{ > + xfree(v->arch.vfp.sve_context); > +} Please use XFREE(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:15:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:15:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520726.808630 (Exim 4.92) (envelope-from ) id 1pmwnD-0002Ne-33; Thu, 13 Apr 2023 13:15:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520726.808630; Thu, 13 Apr 2023 13:15:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwnC-0002NX-VD; Thu, 13 Apr 2023 13:15:14 +0000 Received: by outflank-mailman (input) for mailman id 520726; Thu, 13 Apr 2023 13:15:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwnB-0002Me-GP for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:15:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwnB-000314-3S; Thu, 13 Apr 2023 13:15:13 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmwnA-0006qO-TD; Thu, 13 Apr 2023 13:15:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XyEECiqCsWYUcu8zF9/Wwizrl1PUl1S/MULOV7hgBww=; b=v3x4K+RG9NNucUjIEChgxj90Iz j8V9idAWeLZoCoiDPN6zVIjI3CMgyCfuBqqsBj8CPQ1Wb1gLsPyvCewb7HQueClSINQx4e9DZsS+6 QqY93LWXfHbI9djQ+7GxVRlYIBlnzQMup7EW8aP9I3FifVz7Cq9BqsIrTWaQ3S9FtqpU=; Message-ID: <2359695e-f8f8-cf51-27f9-5f0c776feca5@xen.org> Date: Thu, 13 Apr 2023 14:15:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Content-Language: en-US To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20230413071424.3273490-10-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/04/2023 08:14, Jens Wiklander wrote: > Adds support for sending a FF-A direct request. Checks that the SP also > supports handling a 32-bit direct request. 64-bit direct requests are > not used by the mediator itself so there is not need to check for that. > > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 112 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 112 insertions(+) > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index f129879c5b81..f2cce955d981 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) > return true; > } > > +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > +{ > + switch ( resp->a0 ) > + { > + case FFA_ERROR: > + if ( resp->a2 ) > + return resp->a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + return FFA_RET_OK; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a2, > + register_t a3, register_t a4) > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = fid, > + .a1 = a1, > + .a2 = a2, > + .a3 = a3, > + .a4 = a4, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_features(uint32_t id) > +{ > + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); > +} > + > +static bool check_mandatory_feature(uint32_t id) > +{ > + int32_t ret = ffa_features(id); > + > + if (ret) > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing: error %d\n", > + id, ret); > + > + return !ret; > +} > + > static uint16_t get_vm_id(const struct domain *d) > { > /* +1 since 0 is reserved for the hypervisor in FF-A */ > @@ -222,6 +272,57 @@ static void handle_version(struct cpu_user_regs *regs) > set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > } > > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) > +{ > + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; > + struct arm_smccc_1_2_regs resp = { }; > + struct domain *d = current->domain; > + uint32_t src_dst; > + uint64_t mask; > + > + if ( smccc_is_conv_64(fid) ) > + mask = GENMASK_ULL(63, 0); > + else > + mask = GENMASK_ULL(31, 0); > + > + src_dst = get_user_reg(regs, 1); > + if ( (src_dst >> 16) != get_vm_id(d) ) > + { > + resp.a0 = FFA_ERROR; > + resp.a2 = FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + arg.a1 = src_dst; > + arg.a2 = get_user_reg(regs, 2) & mask; > + arg.a3 = get_user_reg(regs, 3) & mask; > + arg.a4 = get_user_reg(regs, 4) & mask; > + arg.a5 = get_user_reg(regs, 5) & mask; > + arg.a6 = get_user_reg(regs, 6) & mask; > + arg.a7 = get_user_reg(regs, 7) & mask; > + > + arm_smccc_1_2_smc(&arg, &resp); > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + case FFA_MSG_SEND_DIRECT_RESP_32: > + case FFA_MSG_SEND_DIRECT_RESP_64: > + break; > + default: > + /* Bad fid, report back. */ > + memset(&arg, 0, sizeof(arg)); > + arg.a0 = FFA_ERROR; > + arg.a1 = src_dst; > + arg.a2 = FFA_RET_ABORTED; > + } > + > +out: > + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & mask, > + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); > +} > + > static bool ffa_handle_call(struct cpu_user_regs *regs) > { > uint32_t fid = get_user_reg(regs, 0); > @@ -239,6 +340,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) > case FFA_ID_GET: > set_regs_success(regs, get_vm_id(d), 0); > return true; > + case FFA_MSG_SEND_DIRECT_REQ_32: > + case FFA_MSG_SEND_DIRECT_REQ_64: > + handle_msg_send_direct_req(regs, fid); > + return true; > > default: > gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); > @@ -326,6 +431,13 @@ static bool ffa_probe(void) > printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > major_vers, minor_vers); > > + /* > + * TODO save result of checked features and use that information to > + * accept or reject requests from guests. > + */ I am not entirely sure I understand this TODO. Does it mean a guest can currently use a request that is not supported by FFA? > + if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > + return false; > + > ffa_version = vers; > > return true; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:21:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520730.808639 (Exim 4.92) (envelope-from ) id 1pmwsh-0003oE-M5; Thu, 13 Apr 2023 13:20:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520730.808639; Thu, 13 Apr 2023 13:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwsh-0003o7-JG; Thu, 13 Apr 2023 13:20:55 +0000 Received: by outflank-mailman (input) for mailman id 520730; Thu, 13 Apr 2023 13:20:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwsg-0003o1-Op for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:20:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062c.outbound.protection.outlook.com [2a01:111:f400:fe0e::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0347dfc0-d9fe-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:20:52 +0200 (CEST) Received: from DU2PR04CA0188.eurprd04.prod.outlook.com (2603:10a6:10:28d::13) by VI1PR08MB5343.eurprd08.prod.outlook.com (2603:10a6:803:12d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:20:49 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::6a) by DU2PR04CA0188.outlook.office365.com (2603:10a6:10:28d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:20:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 13:20:48 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Thu, 13 Apr 2023 13:20:48 +0000 Received: from 64e2bc829647.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 404CC043-21C9-4D8E-B634-03A4DFB41E67.1; Thu, 13 Apr 2023 13:20:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 64e2bc829647.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 13:20:37 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAWPR08MB10210.eurprd08.prod.outlook.com (2603:10a6:102:367::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:20:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 13:20:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0347dfc0-d9fe-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UkSsLVJWM0/MxcpvXmJ6fWZcYRv/ReE4568KPGnB7Lg=; b=BSUvBrfaXzcfVlZrwgky4C7LeceN3x7jwh3z68/hcGXhsRsFhVxgyrQaLTcmU/pt6WshuuwkkvUs8sAh/G8x40MwgJndc20dGbm6kWJP8SA8B2DsXLy6jPEIr1qJmHNrCc5VlGI3YAHsQIlmVbSJl4MUzLmByOXw9pOwkx1j2r0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 755511fa65ce1425 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jcgplabmw/+th2YDJPZJFubTQKp7mQIcKduKxKFNNawzOcIBCEdlfEKiP169wd7SM33PYP/K7F6A7fQVYaokRpGhfqKP/oGu4nDwP6bEONeTJnqn3G8YIMU2s7lCdFDIBIb5pfwcb5h36QJAU4sDAurwDXK3s43S8xkOkE1Ohz+BjtBQrHkx55jr/Dr44eEHVp9MPhtpxTAtVrRrJZbuKdwsBdyvgOOkcRRjAZbRfo4XK3WZzBb335ToLY6DAYIbq5B+88ydC9/Wal5DSStsqM4HDPkfkTDr7zutT5DWG8f4LhS63A5WgdXtuu2GL/jT+C7XXEG+i0QjGHm4rl2kdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UkSsLVJWM0/MxcpvXmJ6fWZcYRv/ReE4568KPGnB7Lg=; b=guz8JirCqbygg1zTMKQB80umcfTLDJaUZHPYxAMGO5vQPCU4+L8+nNjzqG2F6HThAfElqqNh8yq88qo7yC95itWRpZFxIYfniVlNNgzSHv3zFU3z1wD79+Msw2z47PnEW6efiUTly54GbAFX/XAH/gFS6ZQ995/4yZ9Cq2Kp1MeGaz3EBOiGDatMnIngtG7HY2EqlV5ypTPo6djFV5VVG/wYgID3bVpKSIBPsOzVc9WDeYtlTx2zUF4fcKPZ/w/IzM/CnRPGNLfbREN5G46j1poEfl0zivxk4N/Ea/e0zJ4YNs/FHPzVg1+Kr3YwStLvDiRHrTVeRIIC9/MFBpU13w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UkSsLVJWM0/MxcpvXmJ6fWZcYRv/ReE4568KPGnB7Lg=; b=BSUvBrfaXzcfVlZrwgky4C7LeceN3x7jwh3z68/hcGXhsRsFhVxgyrQaLTcmU/pt6WshuuwkkvUs8sAh/G8x40MwgJndc20dGbm6kWJP8SA8B2DsXLy6jPEIr1qJmHNrCc5VlGI3YAHsQIlmVbSJl4MUzLmByOXw9pOwkx1j2r0= From: Bertrand Marquis To: Julien Grall CC: Jens Wiklander , Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini Subject: Re: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Thread-Topic: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Thread-Index: AQHZbdfL0AxH2Xu3t0igFa2jZHjA9K8pOEIAgAABeIA= Date: Thu, 13 Apr 2023 13:20:36 +0000 Message-ID: <916BB708-3028-4AAB-BD6A-BCABAFBD7C45@arm.com> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> <2359695e-f8f8-cf51-27f9-5f0c776feca5@xen.org> In-Reply-To: <2359695e-f8f8-cf51-27f9-5f0c776feca5@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAWPR08MB10210:EE_|DBAEUR03FT010:EE_|VI1PR08MB5343:EE_ X-MS-Office365-Filtering-Correlation-Id: cfc6ec32-3680-42b3-f96b-08db3c21e5c6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vw73FFR3gv+vpynZa1wljssxFfhiMjE/wIcoqPjOYlLlTl1P1ugdu0AzQkcfXorXeM2UVsIe9Daoe/6y1Xb1fKDver+uLoEWvRtftdeK6h/pQN/+p9d2BnGpEXExAXDEeQz90QM28LeOSUVxLgKpZMNoqfwWgPWYsIL5DtAjNdbkUPaBs1buLhpLN8GwZnasJUjylQ+FASs86AbSaZ8vFZFfhcHe4Su3FXKkSSwSI5hpHeZWAbQl+PuE2AttyknSWebVRyeK5Uv+rb3DNfC1rpgieyPdJhJiL6ifo0wzfshnE+NIdGdzpKWcy1U0Os5ParISv/7ramsILeptVk3E9C9R5WkZIEpURxf53MfE/IliS6rbWYaKNhtDNQP8NqVDJSqpwBhqOSY4c/002xc5T3rDXRHelEt4Wtz6NOtprQXYot4fHPkHBp7A+yikEYl3crcCQ9k77g31l9DLIgtEOFO2nKfdIk2xG4ylANtAQsVan9xF5k75nGg4pvAy8FaD8Vyq8IFlm+R5XM065wZYwm9HyfxdaT1K5gZAwBNsVDYNSnn5VTr/77EwDvmHObXTwr18UtBQPak75CSATrVWL31IlSdeK3Man0oQCBxCvep7nBdQw5D8rEiPESJzsrOgm1UYPyFSNtUFtRnvAzCEkg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199021)(71200400001)(33656002)(38100700002)(122000001)(5660300002)(36756003)(2906002)(316002)(38070700005)(8676002)(8936002)(86362001)(66446008)(66556008)(64756008)(41300700001)(66946007)(6916009)(66476007)(4326008)(91956017)(76116006)(2616005)(83380400001)(54906003)(6506007)(186003)(478600001)(26005)(6512007)(53546011)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1FB4E54CB59B9C47AD3A69B6CDAC874F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10210 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ebe6749b-fefd-469e-2c46-08db3c21de22 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tYygeYU2C2hHpMFoFSe52WQGrdu0LQIPt5IK0lgDts7Vb0FlFdciImMCcsImldxCV7iNqI2QJBDIFEOxlAS3Zo3psITJ12T5F2Pm/19BZmQ1SEPFoh8WESInqbRQ6pgeBaqGEhJkanpFT+1ipCTXUJAtG2NLNChC1znDy7qBCA5x/VYrGh81Km3Rwi+6JaFZxvHynvLLqpV/j8dfnyS5R170ADMEXee1ro1LIrphtRWXoml5k1c9MeKwmCvttR7x7N8vVrpnmbXDUkFxMYZnzfrU20AW6uPIIMmHsFeqW/OMxfY2o4gMbwHoCSBkV7x8rqSX2xwkWks+rhchPSRMhsf4VocH1EDIR63VMkB0n2+ZALG3prISeDqP7FuK7zc1guzJxdF/9PDMYe/3Qgvie39+Y2U4UMOyNiP3X7CgKPSuCwpJ8NDWIOs11KnLtosEqvL6ksJOSPjOOkHp8PKLCTIHmcnXmTzfJnYONFXtm5ELXIbs3VcYEdsBbvcbMiL0D3s/DAHwkN+XAK1gr4rF34eWvhIAstV/nBUAmay/lN6alAH3gBK3pJUudwkmG9uPR+htoG45KpzAQVIk+JTPh84cGC9DLqY0bK6DHfdDmeTNfpnMNYNC7DLzxvXFnRu3krUlOW56exVWewCBUlp5vXQWluhIcS2H5wUkiBA54r3rln4MPrQeG/2GNJ3wBbKzP0ziXvh5GBNKJxooc827Lw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(46966006)(40470700004)(36840700001)(36860700001)(5660300002)(41300700001)(33656002)(82740400003)(40460700003)(36756003)(2906002)(6862004)(8676002)(86362001)(40480700001)(356005)(4326008)(8936002)(70586007)(70206006)(81166007)(82310400005)(316002)(107886003)(2616005)(83380400001)(336012)(47076005)(6506007)(54906003)(6512007)(26005)(53546011)(186003)(478600001)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:20:48.9510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cfc6ec32-3680-42b3-f96b-08db3c21e5c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5343 Hi Julien, > On 13 Apr 2023, at 15:15, Julien Grall wrote: >=20 > Hi, >=20 > On 13/04/2023 08:14, Jens Wiklander wrote: >> Adds support for sending a FF-A direct request. Checks that the SP also >> supports handling a 32-bit direct request. 64-bit direct requests are >> not used by the mediator itself so there is not need to check for that. >> Signed-off-by: Jens Wiklander >> --- >> xen/arch/arm/tee/ffa.c | 112 +++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 112 insertions(+) >> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c >> index f129879c5b81..f2cce955d981 100644 >> --- a/xen/arch/arm/tee/ffa.c >> +++ b/xen/arch/arm/tee/ffa.c >> @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) >> return true; >> } >> +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) >> +{ >> + switch ( resp->a0 ) >> + { >> + case FFA_ERROR: >> + if ( resp->a2 ) >> + return resp->a2; >> + else >> + return FFA_RET_NOT_SUPPORTED; >> + case FFA_SUCCESS_32: >> + case FFA_SUCCESS_64: >> + return FFA_RET_OK; >> + default: >> + return FFA_RET_NOT_SUPPORTED; >> + } >> +} >> + >> +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t = a2, >> + register_t a3, register_t a4) >> +{ >> + const struct arm_smccc_1_2_regs arg =3D { >> + .a0 =3D fid, >> + .a1 =3D a1, >> + .a2 =3D a2, >> + .a3 =3D a3, >> + .a4 =3D a4, >> + }; >> + struct arm_smccc_1_2_regs resp; >> + >> + arm_smccc_1_2_smc(&arg, &resp); >> + >> + return get_ffa_ret_code(&resp); >> +} >> + >> +static int32_t ffa_features(uint32_t id) >> +{ >> + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); >> +} >> + >> +static bool check_mandatory_feature(uint32_t id) >> +{ >> + int32_t ret =3D ffa_features(id); >> + >> + if (ret) >> + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing: error= %d\n", >> + id, ret); >> + >> + return !ret; >> +} >> + >> static uint16_t get_vm_id(const struct domain *d) >> { >> /* +1 since 0 is reserved for the hypervisor in FF-A */ >> @@ -222,6 +272,57 @@ static void handle_version(struct cpu_user_regs *re= gs) >> set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); >> } >> +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uin= t32_t fid) >> +{ >> + struct arm_smccc_1_2_regs arg =3D { .a0 =3D fid, }; >> + struct arm_smccc_1_2_regs resp =3D { }; >> + struct domain *d =3D current->domain; >> + uint32_t src_dst; >> + uint64_t mask; >> + >> + if ( smccc_is_conv_64(fid) ) >> + mask =3D GENMASK_ULL(63, 0); >> + else >> + mask =3D GENMASK_ULL(31, 0); >> + >> + src_dst =3D get_user_reg(regs, 1); >> + if ( (src_dst >> 16) !=3D get_vm_id(d) ) >> + { >> + resp.a0 =3D FFA_ERROR; >> + resp.a2 =3D FFA_RET_INVALID_PARAMETERS; >> + goto out; >> + } >> + >> + arg.a1 =3D src_dst; >> + arg.a2 =3D get_user_reg(regs, 2) & mask; >> + arg.a3 =3D get_user_reg(regs, 3) & mask; >> + arg.a4 =3D get_user_reg(regs, 4) & mask; >> + arg.a5 =3D get_user_reg(regs, 5) & mask; >> + arg.a6 =3D get_user_reg(regs, 6) & mask; >> + arg.a7 =3D get_user_reg(regs, 7) & mask; >> + >> + arm_smccc_1_2_smc(&arg, &resp); >> + switch ( resp.a0 ) >> + { >> + case FFA_ERROR: >> + case FFA_SUCCESS_32: >> + case FFA_SUCCESS_64: >> + case FFA_MSG_SEND_DIRECT_RESP_32: >> + case FFA_MSG_SEND_DIRECT_RESP_64: >> + break; >> + default: >> + /* Bad fid, report back. */ >> + memset(&arg, 0, sizeof(arg)); >> + arg.a0 =3D FFA_ERROR; >> + arg.a1 =3D src_dst; >> + arg.a2 =3D FFA_RET_ABORTED; >> + } >> + >> +out: >> + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & m= ask, >> + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & = mask); >> +} >> + >> static bool ffa_handle_call(struct cpu_user_regs *regs) >> { >> uint32_t fid =3D get_user_reg(regs, 0); >> @@ -239,6 +340,10 @@ static bool ffa_handle_call(struct cpu_user_regs *r= egs) >> case FFA_ID_GET: >> set_regs_success(regs, get_vm_id(d), 0); >> return true; >> + case FFA_MSG_SEND_DIRECT_REQ_32: >> + case FFA_MSG_SEND_DIRECT_REQ_64: >> + handle_msg_send_direct_req(regs, fid); >> + return true; >> default: >> gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); >> @@ -326,6 +431,13 @@ static bool ffa_probe(void) >> printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", >> major_vers, minor_vers); >> + /* >> + * TODO save result of checked features and use that information to >> + * accept or reject requests from guests. >> + */ >=20 > I am not entirely sure I understand this TODO. Does it mean a guest can c= urrently use a request that is not supported by FFA? In fact this is a bit the opposite: in the following patch we check that al= l features we could need are supported but if a guest is only using a subse= t we might not need to have all of them. Idea of this TODO would be to save the features supported and refuse guest = requests depending on the features needed for them. Cheers Bertrand >=20 >> + if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) >> + return false; >> + >> ffa_version =3D vers; >> return true; >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:24:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:24:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520733.808650 (Exim 4.92) (envelope-from ) id 1pmwvj-0004Mj-55; Thu, 13 Apr 2023 13:24:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520733.808650; Thu, 13 Apr 2023 13:24:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwvj-0004Mc-1N; Thu, 13 Apr 2023 13:24:03 +0000 Received: by outflank-mailman (input) for mailman id 520733; Thu, 13 Apr 2023 13:24:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwvi-0004MS-4w for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:24:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwvh-000391-PC; Thu, 13 Apr 2023 13:24:01 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmwvh-00078L-IP; Thu, 13 Apr 2023 13:24:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cY4vS72LVwklu7Jew54sP8KEU4l53pjfjrYouwzFacw=; b=Vu9jlyHvIFPSNC4qm50WYG4kE3 DzQ1lMiftua6vIZGbvhiIldunTwfhrrVoZeSRnV/IFm4YbZfZ5ajLb4pY4x46W5CytBMpsqsYH/Uc 363Qr6Bmd4WFgDF+j7WGvP8xR1GOHTRXAjUqnHPdO/nlZVbltvxD5o8IH09LpU5cQE9o=; Message-ID: Date: Thu, 13 Apr 2023 14:23:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN PATCH v8 11/22] xen/arm: ffa: send guest events to Secure Partitions Content-Language: en-US To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-12-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20230413071424.3273490-12-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/04/2023 08:14, Jens Wiklander wrote: > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > + uint8_t msg) > +{ > + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; > + int32_t res; > + > + if ( msg == FFA_MSG_SEND_VM_CREATED ) > + exp_resp |= FFA_MSG_RESP_VM_CREATED; > + else if ( msg == FFA_MSG_SEND_VM_DESTROYED ) > + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; > + else > + return FFA_RET_INVALID_PARAMETERS; > + > + do { > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, > + .a1 = sp_id, > + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, > + .a5 = vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) > + { > + /* > + * This is an invalid response, likely due to some error in the > + * implementation of the ABI. > + */ > + return FFA_RET_INVALID_PARAMETERS; > + } > + res = resp.a3; > + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); This loop seems potentially unbounded to me. Can you add a comment explaining why this is fine? > + > + return res; > +} > + Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:25:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:25:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520737.808660 (Exim 4.92) (envelope-from ) id 1pmwww-0004wT-Dx; Thu, 13 Apr 2023 13:25:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520737.808660; Thu, 13 Apr 2023 13:25:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwww-0004wM-B2; Thu, 13 Apr 2023 13:25:18 +0000 Received: by outflank-mailman (input) for mailman id 520737; Thu, 13 Apr 2023 13:25:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwwv-0004vu-H0 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:25:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0601.outbound.protection.outlook.com [2a01:111:f400:fe0c::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9eb57539-d9fe-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:25:12 +0200 (CEST) Received: from DB6PR0202CA0041.eurprd02.prod.outlook.com (2603:10a6:4:a5::27) by AM9PR08MB6035.eurprd08.prod.outlook.com (2603:10a6:20b:2d9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:25:10 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::ca) by DB6PR0202CA0041.outlook.office365.com (2603:10a6:4:a5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 13:25:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 13:25:08 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Thu, 13 Apr 2023 13:25:08 +0000 Received: from 29f2334368a9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E3E3F3F3-9300-48CD-8F68-80C65B1A15F0.1; Thu, 13 Apr 2023 13:24:55 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 29f2334368a9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 13:24:55 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB7691.eurprd08.prod.outlook.com (2603:10a6:10:3a5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Thu, 13 Apr 2023 13:24:51 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 13:24:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eb57539-d9fe-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XDlP7wrlTDsn66ctfF6VxZhhr/8wAWkk0cmlLOo5TMI=; b=6gjrkpCSXMvTAdYCkFA+OmOiKPfGrorpb2AiKmu1UC5tCI40Llx1sElxD7tCpzyHCvfEIJL14A6QIJNxC1SLOt4b37VIaDPOI+Zsq6dT1vcMSoN15W4JcQuADcnMh0/04DSRewl2S7y43/3CGQyYEczhocpEi62hoKCQvI1s9Z4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 43011ed1a40fe462 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IrjZY6LJfv6PRH38ESwI4vnco6mFZp0yT6SYgYTI3luB0mizJxar5ARwViZKp+qe5Zu1ZXC0Fh3wEkoU4WJagq4JxbHeVaoCoJZWOKSwvhdszctlMHx9jZhEsoSxu6kFylXKioulH0gvOvMAd/tm9KD/xINN9jM5pIAC2WtqhRziWhcFYaIBTF/EaQNrCqh6hu5lBmdKXDrERTWUI4MVSsCIRg7y4hRpV73+CIIjP2cQ9rDwB98x1VLO90eG1oOag6DMyHNX0l3JngcUlnb48NSCPyUZdWuE6sXTl1BRj7E9+3xdFVoDFxCPHxH4kguGipZyUavG172FtL+EqmAFEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XDlP7wrlTDsn66ctfF6VxZhhr/8wAWkk0cmlLOo5TMI=; b=PhE3l549RZ1MKWMzN0ReFqWcZNk5upO0uXOTVVvrJXwlpIe0pzWY9GJUWcosS+NxgLG1vHZcAtvIDKUeyEOzNzThfTyBSTIxnjsumrUDW0uNWkTmZjq7hQ4JoikD45/xY2HmTlg+R1Zs6IIaj7IW+LBtrkFP1MZXYNbuKt3pCiqdyXeRodypeMs4Eu0CpR4KjhADMZxZoTwU3FgfaKrPdZA27oAkBFIsis+olZco4jWzGzqJrF4fCU5R8/kIveJGLhuRvyxxQ1VW/rL40BKwMw9NGZvn/RZZyWKyIGyR/wj1XHU8zbiwtarU3OWGpNp+RsVKTcFxHXb6sn14SiaoFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XDlP7wrlTDsn66ctfF6VxZhhr/8wAWkk0cmlLOo5TMI=; b=6gjrkpCSXMvTAdYCkFA+OmOiKPfGrorpb2AiKmu1UC5tCI40Llx1sElxD7tCpzyHCvfEIJL14A6QIJNxC1SLOt4b37VIaDPOI+Zsq6dT1vcMSoN15W4JcQuADcnMh0/04DSRewl2S7y43/3CGQyYEczhocpEi62hoKCQvI1s9Z4= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Topic: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Index: AQHZbSQ9GJqCFHqaX0uCiT+EC9U7s68pNK+AgAAHnIA= Date: Thu, 13 Apr 2023 13:24:46 +0000 Message-ID: References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> In-Reply-To: <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB7691:EE_|DBAEUR03FT032:EE_|AM9PR08MB6035:EE_ X-MS-Office365-Filtering-Correlation-Id: e61db3f3-91da-47a1-5a8f-08db3c228061 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QBbHbWAwViTAcr+WnJdHz4bWznUi8w8ZvcPYnJ+e8tjC6kKpQW00mqdvNnyopJlgssL5u7QXFXO8lex2an7iczrFSPru8lc184rgffOOcZCxmTQv3ZyLEtamUXFQ7SRX9gNUrbfKgRG0UQ9MScwVQ9/BnxdpbPrLy9Q8uCh98H8AJxLYC+BeUlWKfDJl0P0+dbWAHw1gkITCqIQYjFwxBftjuZSJWyCJLUDDEF8S4JFbyGO9UBnncpxlQhXtT97PfxuE90EJd6U554JJpqSiO052uujNWBv3gvXgSanw8xeuQUNm4hVT1e8jnGDIQBP/bdQSvq8i3iy1HZysYpsExC4afC+8t8V5FzzknH2nf3mZqW2SKu9JxkTFr2JBKytgDIVsi9z4TiXDiJpoKnGC9zh5GVxqszeLjdjG7KxUePXZ3PFKUj6fCQfnTx/FTi9nsRYebi3r1sAkhuIybfXKAaRMZ4Jhbf1l7bnCs/lBtSEruxJakhQYOWKXnnWa1C/otQLn7VQJ7dSowMm+VlUylmy8lSGUw2jAmViO+OzddWCc5r2W5wm9830aIDUNz5Hn3H47YOU01Rsn8dQHUneEE8gmBEI4z7UsJ3nGAgqqLmgSNBNPivuU4pEsZ7WQ1KQEI4sATu1bgildFScHpYuQ+NiRjU6u263VIx7qN/be1R957mVqLR9HPcB4hrkzq8+zKv8RsWv6C5zhVQ/nmahO2g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(451199021)(71200400001)(6666004)(478600001)(6506007)(186003)(6512007)(26005)(64756008)(6486002)(66476007)(2906002)(91956017)(66946007)(66556008)(54906003)(76116006)(41300700001)(5660300002)(8936002)(66446008)(316002)(6916009)(8676002)(4326008)(122000001)(38100700002)(36756003)(83380400001)(38070700005)(33656002)(2616005)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7691 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8c0c4329-ba9a-437b-7502-08db3c2273ad X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MOw20nxea/NPqUvWozZbGcqpdj+OmrS9IhIiaKJf7RUocNNE538mfTtmDQv6nhfUPUDyFXVJR6uO0EGNwyldZcCFWUQT3IfbW4NJMTSdEseBM6gixwL/sf2rkFWMxgXawHz4NSP8GbxZvqsPUkLAKDeU06KbbD/LUxEq0wGZ4SI+U/wUTIx3jC68uH8IU7Yu5TzR/Q+3vtoMlEbSs14yLmixtR5iAfPNL88xXFFlfH1yRWNeziRYwD8akQMYfNEnzOW2YbKHAR3xsQ6ez14tHVN8LYtDzKq2hH2bvkdiTn4fpb1gs1hjbTa8E+4Ly3xO/mY+JZAqHMG7nHy5hKBn2lNvLrIWQCZbE0GAiEehi5vCphobzNEqaSZCJHqmkYuoeGsOETKFmzKesJ+eId25Sz0W3kwRMpCuDjaAdP63BaVMDTDHPBZ1l1VCZbFgOmb6+ZsWyagiRShsuRluWNBDXSaxVwe8GDSeK4pfjNWwyFpa61R3ggs+x+I5Ic2Jok+hKwbIv4gx11MuyZesRjGoFeNcgvZmM+tEdjW3qYS1ShaIzu/+SB2IQjaCjB9StrdXhyb+vS4nfvNVhkQV7r+8SClnrLEa1MB4nUSHAcjh2K/glHADEvhkt6owY2oAvAduL2YB5q5JctjFKGJTbhO3p/OaV0d5tn+IZdQtXshr+0GqFzUZ7Z4fhj0KxRtCyjm6fPKQcgZ76zpTg4XEXVj6YQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199021)(36840700001)(40470700004)(46966006)(54906003)(316002)(6512007)(6666004)(6506007)(26005)(36860700001)(40480700001)(478600001)(81166007)(41300700001)(356005)(82740400003)(83380400001)(47076005)(2616005)(6486002)(186003)(336012)(70206006)(70586007)(4326008)(5660300002)(6862004)(8936002)(8676002)(2906002)(40460700003)(33656002)(86362001)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:25:08.2225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e61db3f3-91da-47a1-5a8f-08db3c228061 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6035 SGkgSnVsaWVuLA0KDQoNCj4+ICBAQCAtNTk0LDYgKzU5Nyw3IEBAIGludCBhcmNoX3Nhbml0aXNl X2RvbWFpbl9jb25maWcoc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+ PiAgICAgIHVuc2lnbmVkIGludCBtYXhfdmNwdXM7DQo+PiAgICAgIHVuc2lnbmVkIGludCBmbGFn c19yZXF1aXJlZCA9IChYRU5fRE9NQ1RMX0NERl9odm0gfCBYRU5fRE9NQ1RMX0NERl9oYXApOw0K Pj4gICAgICB1bnNpZ25lZCBpbnQgZmxhZ3Nfb3B0aW9uYWwgPSAoWEVOX0RPTUNUTF9DREZfaW9t bXUgfCBYRU5fRE9NQ1RMX0NERl92cG11KTsNCj4+ICsgICAgdW5zaWduZWQgaW50IHN2ZV92bF9i aXRzID0gc3ZlX2RlY29kZV92bChjb25maWctPmFyY2guc3ZlX3ZsKTsNCj4+ICAgICAgICBpZiAo IChjb25maWctPmZsYWdzICYgfmZsYWdzX29wdGlvbmFsKSAhPSBmbGFnc19yZXF1aXJlZCApDQo+ PiAgICAgIHsNCj4+IEBAIC02MDIsNiArNjA2LDI2IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFp bl9jb25maWcoc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+PiAgICAg ICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICAgICAgfQ0KPj4gICsgICAgLyogQ2hlY2sgZmVhdHVy ZSBmbGFncyAqLw0KPj4gKyAgICBpZiAoIHN2ZV92bF9iaXRzID4gMCApDQo+PiArICAgIHsNCj4+ ICsgICAgICAgIHVuc2lnbmVkIGludCB6Y3JfbWF4X2JpdHMgPSBnZXRfc3lzX3ZsX2xlbigpOw0K Pj4gKw0KPj4gKyAgICAgICAgaWYgKCAhemNyX21heF9iaXRzICkNCj4+ICsgICAgICAgIHsNCj4+ ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19JTkZPLCAiU1ZFIGlzIHVuc3VwcG9ydGVkIG9u IHRoaXMgbWFjaGluZS5cbiIpOw0KPj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4g KyAgICAgICAgfQ0KPj4gKw0KPj4gKyAgICAgICAgaWYgKCBzdmVfdmxfYml0cyA+IHpjcl9tYXhf Yml0cyApDQo+PiArICAgICAgICB7DQo+PiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5G TywNCj4+ICsgICAgICAgICAgICAgICAgICAgICJSZXF1ZXN0ZWQgU1ZFIHZlY3RvciBsZW5ndGgg KCV1KSA+IHN1cHBvcnRlZCBsZW5ndGggKCV1KVxuIiwNCj4+ICsgICAgICAgICAgICAgICAgICAg IHN2ZV92bF9iaXRzLCB6Y3JfbWF4X2JpdHMpOw0KPj4gKyAgICAgICAgICAgIHJldHVybiAtRUlO VkFMOw0KPj4gKyAgICAgICAgfQ0KPiANCj4gSXMgU1ZFIHN1cHBvcnRlZCBmb3IgMzItYml0IGd1 ZXN0PyBJZiBub3QsIHRoZW4geW91IHNob3VsZCBoYWQgYSBjaGVjayBoZXJlIHRvIHByZXZlbnQg dGhlIGNyZWF0aW9uIG9mIHRoZSBkb21haW4gaWYgc3ZlX3ZsX2JpdHMgaXMgc2V0Lg0KDQpObyBT VkUgaXMgbm90IHN1cHBvcnRlZCBmb3IgMzIgYml0IGd1ZXN0cywgaGVyZSBJIHRoaW5rIHdlIHdp bGwgZ2V0IOKAnFNWRSBpcyB1bnN1cHBvcnRlZCBvbiB0aGlzIG1hY2hpbmXigJ0gYmVjYXVzZSBn ZXRfc3lzX3ZsX2xlbigpIHdpbGwgcmV0dXJuIDAuDQoNCkkgY2FuIGhvd2V2ZXIgcHV0IGV2ZXJ5 dGhpbmcgaW5zaWRlICNpZmRlZiBDT05GSUdfQVJNNjRfU1ZFIG9yIENPTkZJR19BUk1fNjQgaWYg eW91IHByZWZlcg0KDQo+PiANCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9h c20vZG9tYWluLmggYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZG9tYWluLmgNCj4+IGluZGV4 IGU3NzZlZTcwNGI3ZC4uNzhjYzJkYTNkNGU1IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL2RvbWFpbi5oDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v ZG9tYWluLmgNCj4+IEBAIC0zMSw2ICszMSw4IEBAIGVudW0gZG9tYWluX3R5cGUgew0KPj4gICAg I2RlZmluZSBpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSAoKGQpLT5jZGYgJiBDREZfZGlyZWN0 bWFwKQ0KPj4gICsjZGVmaW5lIGlzX3N2ZV9kb21haW4oZCkgKChkKS0+YXJjaC5zdmVfdmwgPiAw KQ0KPj4gKw0KPj4gIC8qDQo+PiAgICogSXMgdGhlIGRvbWFpbiB1c2luZyB0aGUgaG9zdCBtZW1v cnkgbGF5b3V0Pw0KPj4gICAqDQo+PiBAQCAtNjcsNiArNjksOSBAQCBzdHJ1Y3QgYXJjaF9kb21h aW4NCj4+ICAgICAgZW51bSBkb21haW5fdHlwZSB0eXBlOw0KPj4gICNlbmRpZg0KPj4gICsgICAg LyogbWF4IFNWRSBlbmNvZGVkIHZlY3RvciBsZW5ndGggKi8NCj4+ICsgICAgdWludDhfdCBzdmVf dmw7DQo+PiArDQo+IENhbiB3ZSBtb3ZlIHRoaXMgc29tZXdoZXJlIGVsc2UgdG8gYXZvaWQgYWRk aW5nIGV4dHJhIHBhZGRpbmc/IEFsc28gc2hvdWxkbid0IHRoaXMgYmUgcHJvdGVjdGVkIHdpdGgg I2lmZGVmIENPTkZJR19BUk1fNjQgdG8gbWFrZSBjbGVhciB0aGlzIGlzIG5vdCBzdXBwb3J0ZWQg b24gWGVuIDMyLWJpdD8NCg0KWWVzLCBJ4oCZbGwgbW92ZSBpdCBhbmQgcHJvdGVjdCB3aXRoIENP TkZJR19BUk1fNjQsIGlzIGl0IG9rIGZvciB5b3UgaWYgSSBtb3ZlIGl0IGFmdGVyOg0KDQovKiBN b25pdG9yIG9wdGlvbnMgKi8NCnN0cnVjdCB7DQogICAgdWludDhfdCBwcml2aWxlZ2VkX2NhbGxf ZW5hYmxlZCA6IDE7DQp9IG1vbml0b3I7DQoNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:27:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520743.808675 (Exim 4.92) (envelope-from ) id 1pmwyx-0005bq-1R; Thu, 13 Apr 2023 13:27:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520743.808675; Thu, 13 Apr 2023 13:27:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwyw-0005bj-V1; Thu, 13 Apr 2023 13:27:22 +0000 Received: by outflank-mailman (input) for mailman id 520743; Thu, 13 Apr 2023 13:27:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwyv-0005bd-In for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:27:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwyv-0003DS-7A; Thu, 13 Apr 2023 13:27:21 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmwyu-0007CE-UR; Thu, 13 Apr 2023 13:27:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9/n7hnNMcYoNgoCz7dxwE/VXQp/HTEyugpR8WeQ2158=; b=jHv18kU29a4bFg7THOxcDLqP/b ElGSFhdnhFShbiJBdq75Ik7vpT7BPkukQ5JbqeDOrbir/CmVQSnNEojI9rCX63i5iiDZeJu12YsTO 7ZH2nwkSd4zObjnuqkXB/gqnIOJNCko/HBONXD0wasM7BUX0eXAodkep0qcB3KijcQls=; Message-ID: <2dba6372-330d-a068-241f-59e19b837150@xen.org> Date: Thu, 13 Apr 2023 14:27:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Content-Language: en-US To: Bertrand Marquis Cc: Jens Wiklander , Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> <2359695e-f8f8-cf51-27f9-5f0c776feca5@xen.org> <916BB708-3028-4AAB-BD6A-BCABAFBD7C45@arm.com> From: Julien Grall In-Reply-To: <916BB708-3028-4AAB-BD6A-BCABAFBD7C45@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/04/2023 14:20, Bertrand Marquis wrote: > Hi Julien, > >> On 13 Apr 2023, at 15:15, Julien Grall wrote: >> >> Hi, >> >> On 13/04/2023 08:14, Jens Wiklander wrote: >>> Adds support for sending a FF-A direct request. Checks that the SP also >>> supports handling a 32-bit direct request. 64-bit direct requests are >>> not used by the mediator itself so there is not need to check for that. >>> Signed-off-by: Jens Wiklander >>> --- >>> xen/arch/arm/tee/ffa.c | 112 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 112 insertions(+) >>> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c >>> index f129879c5b81..f2cce955d981 100644 >>> --- a/xen/arch/arm/tee/ffa.c >>> +++ b/xen/arch/arm/tee/ffa.c >>> @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) >>> return true; >>> } >>> +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) >>> +{ >>> + switch ( resp->a0 ) >>> + { >>> + case FFA_ERROR: >>> + if ( resp->a2 ) >>> + return resp->a2; >>> + else >>> + return FFA_RET_NOT_SUPPORTED; >>> + case FFA_SUCCESS_32: >>> + case FFA_SUCCESS_64: >>> + return FFA_RET_OK; >>> + default: >>> + return FFA_RET_NOT_SUPPORTED; >>> + } >>> +} >>> + >>> +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a2, >>> + register_t a3, register_t a4) >>> +{ >>> + const struct arm_smccc_1_2_regs arg = { >>> + .a0 = fid, >>> + .a1 = a1, >>> + .a2 = a2, >>> + .a3 = a3, >>> + .a4 = a4, >>> + }; >>> + struct arm_smccc_1_2_regs resp; >>> + >>> + arm_smccc_1_2_smc(&arg, &resp); >>> + >>> + return get_ffa_ret_code(&resp); >>> +} >>> + >>> +static int32_t ffa_features(uint32_t id) >>> +{ >>> + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); >>> +} >>> + >>> +static bool check_mandatory_feature(uint32_t id) >>> +{ >>> + int32_t ret = ffa_features(id); >>> + >>> + if (ret) >>> + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing: error %d\n", >>> + id, ret); >>> + >>> + return !ret; >>> +} >>> + >>> static uint16_t get_vm_id(const struct domain *d) >>> { >>> /* +1 since 0 is reserved for the hypervisor in FF-A */ >>> @@ -222,6 +272,57 @@ static void handle_version(struct cpu_user_regs *regs) >>> set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); >>> } >>> +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) >>> +{ >>> + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; >>> + struct arm_smccc_1_2_regs resp = { }; >>> + struct domain *d = current->domain; >>> + uint32_t src_dst; >>> + uint64_t mask; >>> + >>> + if ( smccc_is_conv_64(fid) ) >>> + mask = GENMASK_ULL(63, 0); >>> + else >>> + mask = GENMASK_ULL(31, 0); >>> + >>> + src_dst = get_user_reg(regs, 1); >>> + if ( (src_dst >> 16) != get_vm_id(d) ) >>> + { >>> + resp.a0 = FFA_ERROR; >>> + resp.a2 = FFA_RET_INVALID_PARAMETERS; >>> + goto out; >>> + } >>> + >>> + arg.a1 = src_dst; >>> + arg.a2 = get_user_reg(regs, 2) & mask; >>> + arg.a3 = get_user_reg(regs, 3) & mask; >>> + arg.a4 = get_user_reg(regs, 4) & mask; >>> + arg.a5 = get_user_reg(regs, 5) & mask; >>> + arg.a6 = get_user_reg(regs, 6) & mask; >>> + arg.a7 = get_user_reg(regs, 7) & mask; >>> + >>> + arm_smccc_1_2_smc(&arg, &resp); >>> + switch ( resp.a0 ) >>> + { >>> + case FFA_ERROR: >>> + case FFA_SUCCESS_32: >>> + case FFA_SUCCESS_64: >>> + case FFA_MSG_SEND_DIRECT_RESP_32: >>> + case FFA_MSG_SEND_DIRECT_RESP_64: >>> + break; >>> + default: >>> + /* Bad fid, report back. */ >>> + memset(&arg, 0, sizeof(arg)); >>> + arg.a0 = FFA_ERROR; >>> + arg.a1 = src_dst; >>> + arg.a2 = FFA_RET_ABORTED; >>> + } >>> + >>> +out: >>> + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & mask, >>> + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); >>> +} >>> + >>> static bool ffa_handle_call(struct cpu_user_regs *regs) >>> { >>> uint32_t fid = get_user_reg(regs, 0); >>> @@ -239,6 +340,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) >>> case FFA_ID_GET: >>> set_regs_success(regs, get_vm_id(d), 0); >>> return true; >>> + case FFA_MSG_SEND_DIRECT_REQ_32: >>> + case FFA_MSG_SEND_DIRECT_REQ_64: >>> + handle_msg_send_direct_req(regs, fid); >>> + return true; >>> default: >>> gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); >>> @@ -326,6 +431,13 @@ static bool ffa_probe(void) >>> printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", >>> major_vers, minor_vers); >>> + /* >>> + * TODO save result of checked features and use that information to >>> + * accept or reject requests from guests. >>> + */ >> >> I am not entirely sure I understand this TODO. Does it mean a guest can currently use a request that is not supported by FFA? > > In fact this is a bit the opposite: in the following patch we check that all features we could need are supported but if a guest is only using a subset we might not need to have all of them. > Idea of this TODO would be to save the features supported and refuse guest requests depending on the features needed for them. Thanks. I would suggest the following comment: /* * At the moment domains must supports the same features used by Xen. * TODO: Rework the code to allow domain to use a subset of the features * supported. */ Note that I am using "domains" rather than "guests" because the latter doesn't include dom0. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:27:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520744.808686 (Exim 4.92) (envelope-from ) id 1pmwz1-0005ro-9Y; Thu, 13 Apr 2023 13:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520744.808686; Thu, 13 Apr 2023 13:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwz1-0005rh-62; Thu, 13 Apr 2023 13:27:27 +0000 Received: by outflank-mailman (input) for mailman id 520744; Thu, 13 Apr 2023 13:27:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwyy-0005qb-Hb for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:27:25 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e97e78c4-d9fe-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:27:21 +0200 (CEST) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Apr 2023 09:27:08 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5824.namprd03.prod.outlook.com (2603:10b6:a03:2d0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:27:06 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Thu, 13 Apr 2023 13:27:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e97e78c4-d9fe-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681392441; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=r0MfYP8Wrn/gvQc3A35Iu17mJutW0KFbhur4W7xAmNM=; b=BprTPBdu8bg/Xyz87zIJqREbpdi0xpjC3ZyJM/wurshdfyHyT/s03OcO hKrhe7gp7IVVO0f82aIjljLiA1qlFY341w5SVoyJotAwNotgj8Ta25lRH 2/l1ltlfqACm0NL4CewZo31Fs+OSIPhkt+O0KbnKynIG+JIn//cfcI++y g=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 104168221 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vxB5BqsS+zR+cMMd6AaLjVNTSufnVP5fMUV32f8akzHdYApBsoF/q tZmKWmEM/eLa2L9eNonYd+yoEJV6pTVnNBiTQRtr3hhEH5H+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AOHzCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwERIVdAqq3uGNwLPiYLlXwcZ8EO62I9ZK0p1g5Wmx4fcOZ7nmGv2PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60aIq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqqc00AfJnwT/DjUKUluLjMW1inehUo5wA GAV9CUfk4cboRnDot7VGkfQTGS/lhwBX9tdFcUq5QfLzbDbiy6bC24fCCFAa9gvssM7XxQu1 1mAhdSvAiZg2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZvxuCrKvh9v5XxT52 SmXrTMWjq8Wy8UM0s2T+FndiHSmoZ7PTwU0zgzNWySu6QYRTIeuZ42ur1fG9epJBI+DSx+Ku 31ss9OF8OkEAJWJlSqMaOYABrek47CCKjK0qWBoG54t5jG84UmJdIpb4Cx9DEpxO8NCcjjsC HI/oitU7Z5XeX61N6l+ZtvpD9xwlPCwU9P4SvrTc9xCJIBrcxOK9z1vYkjW2H3xlE8rkuc0P pLznduQMEv2wJ9PlFKeL9rxG5d3rszi7Qs/nazG8ik= IronPort-HdrOrdr: A9a23:znOweqjue/whnwXg5HKdHYKPvHBQX1B13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftWjdySOVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNykwsS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Lk1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoOOCXMsLlbFtzfsHfoWG1TYczDgNnzmpDt1L8eqq iDn/7nBbUw15qeRBDxnfKn4Xic7N9n0Q6f9bbfuwqonSWxfkNEN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3am+a/hGrDvAnZMZq59ms1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgn/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9MKOM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaCqDgDKFC66 gpfGkoxVLaIXied/Fm9Kc7gyzwfA== X-Talos-CUID: 9a23:elUmhWC/SzGqgqP6ExBF7FQOM5kmSX3clV2AGAi6VlpOFaLAHA== X-Talos-MUID: =?us-ascii?q?9a23=3Aze67rQzpJvP/2VrN0wdOwxdlMvqaqLipCHAgrZk?= =?us-ascii?q?GgtaNaQNbFzaTgwWJbaZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,193,1677560400"; d="scan'208";a="104168221" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QO6Th7zRZ0WB+3rGUrGuuNyAAHYVJEkq9dwKT3jO7oRF2yazjnozjrW/j8+bC+3A/4KM2xTJmugDViFjEQSah+gKhkkA9dkfMh+crHuxbr+fZuj4/kS0egO5eLZMPRpolKdjXy9nqe9lRWwBeYJJLKlxACWamhPPvY4NTbYI1NvEOA2zNrolecIBCnXRCIBU99qogvpxuIz/eL+hEj/2emB+K3xUZub/R+Futc2j61clxx3vIh+95OeGWJixI8Z6xL2IjoyPYl8yydXXtm5ikLYvDfywz4ZSScrmAF0pgOrtKd7R3+MFFiVvkUXGZ30gScc6awQRPOlt5uWP3EXisQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r0MfYP8Wrn/gvQc3A35Iu17mJutW0KFbhur4W7xAmNM=; b=MFYoaOr44U5Tv+WUjELtd3dPFqpEm+n8qQHTymMZwZdz5y2xFibSG2evltvFv7UhmnlHAj+Oi1fKd0mhsVK2H7BN3YCxDrVU4NMcOvQlDddT+i6ssVCigxwa/GABQNnkZAbewb/d1TGdPblwrpDgfs0drwDLsa3gc68M6NT8TMYP9If4ikpgb1qw26gv6Hfriwo6VkJFq5qnoDVYUbSHJu9yhztWbeUWYKSVCMqt7PVmgLj/tXdy0XRv0pCjJEVugGcZIdUfb0ALIc6uAUEul/KHzthrZdjxdK7BUiI1v2uugqBzJd62/bR2xOXH0aiBhjuG+VivXoInwCu2sT0i8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r0MfYP8Wrn/gvQc3A35Iu17mJutW0KFbhur4W7xAmNM=; b=iAm2CTIeDPCg5Pp+lvNQYfTLXvjvXBzAgqQh3Ttc2/fkZTuZBIvESqKTflUvSbPRUhGGOib4tPycts5S92vLfsK2UD17zAN7j+UFWQc3St5T/xgePLtbEwkI+ICMK7mO2+qokPwxK328WXY7tV4WmyQqIbfX+B3N8Sx2Spbyd2c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 13 Apr 2023 14:26:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN PATCH v8 02/22] xen/arm: tee: add a primitive FF-A mediator Content-Language: en-GB To: Julien Grall , Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Stefano Stabellini , Volodymyr Babchuk References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-3-jens.wiklander@linaro.org> From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0406.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5824:EE_ X-MS-Office365-Filtering-Correlation-Id: 37544ae6-4e45-42bb-031a-08db3c22c62a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dKUsDklUK1GRYi3J8PFG/pDkc8aDWd8TsPcDbCV5NLlEEf0JHfYcGp1FuE6zRtZ2/u1p1neY/VUTsMMGGlI/b5fUf4UXCf3zdkWcSj/Qqswtc0fnn8jjI45ThPBp47oH0jGaxdSKJ0FkhgilAu2WtEZM21ekOwDXB9DJECCJro6g9KTW0qmmjZT1l6JNqKU+qFayn+clhg5uAPJHQ7e3Bs1Ei3/4I592/W6imgF2SJxRZ8R730ib8QN8+xxCURfWZeTukaHEzKtEd7Dxh33OYFL2BbBqgMEMZ7QR9DbzdaUjVdlytvKtgpkGSO1NSjTTVp0ehVKbqm7PbuJmG9WM1mO2Zi5lpzU8ActMcCWtt1bZANI5q1LCunxntjidwoOVsw6P1gFvN9QTtXUUW1BsZD+jsDe2QVtM69D8pvkKGZsOg5LeIT468wYlkWl1nrFHx7HLGgtuHfF8MmCrRJz5PPDOpF8Xm39tmUuOeph3Eq0vXM2UHIlMsa5VDwwSnBa7aHSjut7smfcJJrcAjBKe1hQA9MeYcvAw2hVw8F/xsUBbqgDjNLr7ssOhxRt4ZD2gtXJbrgsi3BwhbJiHVn2FqsmGvbrHDotFml9hDQ7EBSMxkuFyuxYA7A48UGFyLEkHcAnLrxylD1jXa+G+zrANQA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199021)(6666004)(6486002)(66476007)(66556008)(66946007)(4326008)(36756003)(110136005)(2906002)(31696002)(86362001)(41300700001)(82960400001)(5660300002)(8676002)(8936002)(316002)(38100700002)(478600001)(54906003)(53546011)(6512007)(6506007)(26005)(31686004)(2616005)(186003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1R0ZFRHSFZ5SlZxd0hIVitsTE05QWZqdmVBL3drOXlnSXAwVkhmWWZRSlh2?= =?utf-8?B?bGVUbjR3WXFsQmpWWWN1d2ZuSjl5RkJ3b0JqMzR5cEVZbm5vTnR6azNSWDF0?= =?utf-8?B?cnFNYXF1N2VtYmt6UHd2cGNDSU1VbkpITXpjOUtzVnhFb29OaU5JQUdpeWtk?= =?utf-8?B?MlIvMDdjcXJFUHNyODZUNTdWeXVraElDRm56N2VzdWNrK0o0aTdLejExRTJl?= =?utf-8?B?Y0I4UWpScVpKZFh4ZGcwT1FoQlBBTDZCTFZBM0M3cGhWNUJ1blZOVGpXQ2lG?= =?utf-8?B?QnpMbW1JcnNjbkcrZ3ljOExmWXZzNnhBSHFldDhveURCV1RJZmcvWm5kQ09O?= =?utf-8?B?N2V5b2dvNEdENm9xNnlkOTJIOUhqY1dNQkRSckNyaGVwWkpsNHBlWnpoa3JT?= =?utf-8?B?dDZxUkx6ay9MZzdDTURPL2h6ZnJ1ajBYQllWOEVlUjdsb3ZmZ1UyRWtmN1E4?= =?utf-8?B?WUVzRThJcE5PSFQ5bGs5YzYzWEg1Slo0S0Fjb0l4MXJJc0RMZEJ2KzRYWXZE?= =?utf-8?B?TEwrM1lGTTBtamZORUdiM3NTcE1QOXhMMll6cDJaejJLVHJCZGQ2Y2xMSWxF?= =?utf-8?B?Z1QvdGsvZ04xaVZQU3FqRlg0SHplelFhOEtWc2JIQ1h4akpXdmxxeEd0UGxx?= =?utf-8?B?bitxVzRicVBJNURPcFhSdEIzUDhBUlZ3NWJGUHJMRllvTWc3N1BkY05BZ0N5?= =?utf-8?B?NXp4blp1OVN4alZaMkJBY2VIVjJmTzZsK1dUWk0wYTZ6eHVGK3lkNUhLS2d2?= =?utf-8?B?aW5KODdDNk41YUZUcXZmdTZ1YVV1MCtlTzYzY1dleENzYkpMSlZpOEs5RklD?= =?utf-8?B?MWRjVTA3dG0xamRpdmZyQlY0ZmU4K2VuV29QeHBjU0MyVUwvRHV2eUpkVXpz?= =?utf-8?B?NFBMZ3hYRldQdDdRdnI0M1NKc1ZlVVQ0QnBWOTZwK21hZWhURlp4bHIwa2xv?= =?utf-8?B?cXBFTXpEdWJhdlBuNE9rc0g5Rml4Q1BrZXN2K0hLZnZUZVk3Q3ZlQ2VHL1Ar?= =?utf-8?B?NnVUL3g5azZzWllrR2VlRUhZZ21LS3dQWlNMV2s2bElJeWF4SnVZNlIyN0pl?= =?utf-8?B?OEc5ZU0vRUpsQ0xnTXVYZ2sxR1liTGgzdnhvcDZZNllmaiszMmc4b1dCVWIr?= =?utf-8?B?ajRjQnkwTEFaNHBSV0kxNWhCRnVaNFIrOWhLSUtMcWN4R2k1L2RHcndNcEtM?= =?utf-8?B?UEJReTZIZSs2OWpjZFFoWGFVOXhCUGtTRWc3MkJNOEpadU9sV1FpYU0yV2wx?= =?utf-8?B?dU1ucE5MSm9QeERVVE9ybk5PdTJOQm5XcitLY3NvcXdiZkQwUnQyaVpNL2lQ?= =?utf-8?B?SUZtcDhYL3NSWUNza3JCNDBsQ1liUFR1ckFoL3dzbzlGbS9yNEI0Wi91VHNX?= =?utf-8?B?UWowSlRHK2YzMDJhNEFxdU1jUE1qWjlvb1h0ZUd1QlFMbmtnWHZNZytNT0pY?= =?utf-8?B?eFJlMjUyMWIza01oRmk3ZGFVdlFjeWxqaGYvendXdGRFdThpblJkVEdJSkpT?= =?utf-8?B?Qlh6SHIzdFpLYWh0WDhtcWNuVnlNWmJBWHFZb3pKV244ZStFTk5USVBYcjBv?= =?utf-8?B?cGFZalR2d1dNRE9JcHlQZjJhSGM1dkw5OG9VNWZwdEs3dGkveDBqODdaNHFZ?= =?utf-8?B?RXFZYnBLelM1eUhhbGpNOUFWK081STFQRmMyWFl3ZEhreENuaGhVLy90ZkxS?= =?utf-8?B?S0JEdURxOEtRbk96OFA2MUJ6UEJGYXV6aEhBT1YvRkc2NEN6NGVrbzRGL253?= =?utf-8?B?MTU1TkVtdHVnclNsZUZockdobmdVYVh6RGRrZzNGYSs1bG4zNXZBUTFZQWMw?= =?utf-8?B?MHNFdlV3RlVaQWk5S1dMUEFvMko0L2NXbzBlUUN6OEFRcmFaSlhDVHFGSVFx?= =?utf-8?B?eHB0M1J6eG8rc0wvUTduekdScmJ0RjZYaWdJQk5qN2Y2YmpSMXQ4WFRkcVQz?= =?utf-8?B?V3dUTFc1Wjc3WFNYcjBOTG04OWF0bHRoMGFZV3R1c2pWeHBsckhXMlhYMnQw?= =?utf-8?B?WlRHWmxZSmluMERmL1hsZ21mWFRia2VvRnZYRlZBeGxLN0lZbEx0TC9YV0Nz?= =?utf-8?B?d3dneVM2T255dDk4eDVZUHcyMkJDMlI2emw0eCtxalZOa1RnRVFFZk9KWEhV?= =?utf-8?B?d2Rocm14dW5wdVVkcndLUkhCMHFNM3N5K3RGMnJadU5XVy8vMnpLVFVYUHB3?= =?utf-8?B?Zmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g2HpqDSPs1UWzoV93MCYkA6IlhBGNqbZUvauUaAI81Tdsqq6iq6/vl3Nu2Aji8yDjDjFq5oJNzihSJ9SFs6ZBoA7r6il4Gi7NWnGT7BJXzxPySk9iopzjRoU4LwqvymFqMT+hbp2HvUf3tafJdLqNXKmaAE9S7oD+YYZKNGapt+EYJk1v7QVE0SDrPsqLFYZS0oqlXgMiBg2W5ablih4oJV9iFoX1F5sfs12ks3oPJ01wQLytW4pWN4tTD2nzJJzofj6/MBIncmtJoTQ/dBKLb/TDWpF3AP4q9iyNyt9b/gDCtrmdi7JBO0jTg27wOgSM6Sdu2BOSxrdsxgc5JYJhz/nedowY/GHsoIM6XsPbW17Z83GbZhHn8P/e6kDusJQQpbqxeyKN5AsnhbBRfBDPJuZ+o3zQXEUsnFTacgd05rHBRNpxpOGGCiwmhetriIZ9NuQ6wnl9xC4QTX6qTg3/CZYriG/LeN+dMPUZ8cyLk+RzlbwMyYRzNNwyCpIc03+GwSA+xT9S1kngMFm6fP0BA8EEJP4IqaG3wEix4n6zKLiZbjrU00zf7MOOwyyVUCPQGxndOyi1gZNCCc+4pV6G0sugJYqSG7wDHopQMQvepJ+HfwXogyGVIdPIfzfHSpcUmb/ow9hnMfw4HDBR7/bx+MYzRogASglOUHT2xs3Z5S5h9Uf+DP9kTQVqA/sVJwPMU3wIbiho9RB0BFSXgU79kCQO9tH2I0Xh9/fnzcDfoMxwCns3Baz+3Nty53MtqboNdBa55xDJg2LRXZQC0RTFxWFi+AeUtereREq5lXlL++a6z5LKFetaaPfKdYgUzTUD3R67bNfZathHDSyuyGOl6lP1ghK1AEVXpJq2XF6NEEnlxKX/bWMCWGexwC+sk9XXAhcni/WNH1/dU+NBJ44PQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37544ae6-4e45-42bb-031a-08db3c22c62a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:27:05.7191 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ZIvLrlQ7euwEIiKXaqE8s+m96IpwhKkt72yn/eC8N6HVWBqZSs3SHaMJrD/CGNjLcitGakoardLLckochw6TwnVge/gSOoSpIRD24dPssU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5824 On 13/04/2023 1:26 pm, Julien Grall wrote: >> +static int ffa_domain_init(struct domain *d) >> +{ >> +    struct ffa_ctx *ctx; >> + >> +    if ( !ffa_version ) >> +        return -ENODEV; >> + >> +    ctx = xzalloc(struct ffa_ctx); >> +    if ( !ctx ) >> +        return -ENOMEM; >> + >> +    d->arch.tee = ctx; >> + >> +    return 0; >> +} >> + >> +/* This function is supposed to undo what ffa_domain_init() has done */ > > I think there is a problem in the TEE framework. The callback > .relinquish_resources() will not be called if domain_create() failed. > So this will result to a memory leak. > > We also can't call .relinquish_resources() on early domain creation > failure because relinquishing resources can take time and therefore > needs to be preemptible. > > So I think we need to introduce a new callback domain_free() that will > be called arch_domain_destroy(). Is this something you can look at? Cleanup of an early domain creation failure, however you do it, is at most "the same amount of time again".  It cannot (absent of development errors) take the same indefinite time periods of time that a full domain_destroy() can. The error path in domain_create() explicitly does call domain_teardown() so we can (eventually) purge these duplicate cleanup paths.  There are far too many easy errors to be made which occur from having split cleanup, and we have had to issue XSAs in the past to address some of them.  (Hence the effort to try and specifically change things, and remove the ability to introduce the errors in the first place.) Right now, it is specifically awkward to do this nicely because domain_teardown() doesn't call into a suitable arch hook. IMO the best option here is extend domain_teardown() with an arch_domain_teardown() state/hook, and wire in the TEE cleanup path into this too. Anything else is explicitly adding to technical debt that I (or someone else) is going to have to revert further down the line. If you want, I am happy to prototype the arch_domain_teardown() bit of the fix, but I will have to defer wiring in the TEE part to someone capable of testing it. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:28:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520749.808695 (Exim 4.92) (envelope-from ) id 1pmwzc-0006cL-IU; Thu, 13 Apr 2023 13:28:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520749.808695; Thu, 13 Apr 2023 13:28:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwzc-0006cE-Ff; Thu, 13 Apr 2023 13:28:04 +0000 Received: by outflank-mailman (input) for mailman id 520749; Thu, 13 Apr 2023 13:28:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmwzb-0005qb-KY for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:28:03 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20600.outbound.protection.outlook.com [2a01:111:f400:fe1a::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0328be83-d9ff-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:28:01 +0200 (CEST) Received: from DUZPR01CA0163.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::25) by PAWPR08MB9736.eurprd08.prod.outlook.com (2603:10a6:102:2ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:27:59 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b3:cafe::31) by DUZPR01CA0163.outlook.office365.com (2603:10a6:10:4b3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:27:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 13:27:59 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Thu, 13 Apr 2023 13:27:59 +0000 Received: from 4a6a96a6ad27.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 07377B3D-DB35-4508-8E0B-4F85C873DCB7.1; Thu, 13 Apr 2023 13:27:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4a6a96a6ad27.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 13:27:52 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM0PR08MB5489.eurprd08.prod.outlook.com (2603:10a6:208:18e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:27:50 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 13:27:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0328be83-d9ff-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLiqadu5AG8GrrWoQG7VBbBfiLxOAYVHW7Po1uAAX34=; b=vvvlebrTgNSMqrutYMyhDdCQ5capYmxdP07/9l6OTWNM6cU5DLfNPyDUQG9E7MJSOPAf+olQKcUoWVEhv1yuSX/uKQCp91iUINX8JPHHOKfluvlFl3KOZkPn5UCclwXqS0nAFDI7w9Ztlt32GuYivc9pz4aeik1X33A9NFvH46g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 533f5e52ad0b60ef X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=boEMpuluaGVaTAvrPJx5n8KdGDpNN183GSScEMsBr4LG9PB4lJCN27Yt8oWc79YapkitdqsPbsAQXz6AZ/DkKw4upwpiScqXknDyNPthDrIbRi54niytK75fLKFoNbGZSlg2kjcqWQ/brATSfyAqm9Bogt5078srCf+YVcVQs1rz4CRz2vXhEohZ7HWYKi+BGr/6niC1o9XX5Dk5ueu3VbCyu2uTISQ6CpMoOkg7Vj+eoZyHUsBiIRCB88IMf/igXq9IdgGyvdPxpEeusgoCmoRbNUKC45/MuW7Y+GC37YKWi96gcCMa/oZGU2ANQtME/R15F8p4/YuP/skKlu1L2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cLiqadu5AG8GrrWoQG7VBbBfiLxOAYVHW7Po1uAAX34=; b=X8WSc6wRcLdqeIIhywXMuxV7ktvy59/k2FqOTrkiI2+qkxafiiiRgyFaxHKlupGKdkb8UEtRTa94DRugOGPp59kYAYljrgFAO6KmBvrbjAD73c/Wh9gaMi3AtqyJE1mrUzVD5/fY/yJEr/OITStk6MRYFLQ0Y/dqc/7FtCLIhq3bo3sLvuhlf/xg6lNhg2+CcTcYvVk69gvAYy19x2Q0y1saig5UCIg+jLlDz3vWq8QWBDFwRQ/oaiz+b3E9OmawpWuF726DubAtV0+GxeJrgNcbMuxCneHcEUSF+xPl/sojTQrM/P7XpYURPJjMLruN8GgkcmY1CJdvaCkBOvkrPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLiqadu5AG8GrrWoQG7VBbBfiLxOAYVHW7Po1uAAX34=; b=vvvlebrTgNSMqrutYMyhDdCQ5capYmxdP07/9l6OTWNM6cU5DLfNPyDUQG9E7MJSOPAf+olQKcUoWVEhv1yuSX/uKQCp91iUINX8JPHHOKfluvlFl3KOZkPn5UCclwXqS0nAFDI7w9Ztlt32GuYivc9pz4aeik1X33A9NFvH46g= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v5 04/12] xen/arm: add SVE exception class handling Thread-Topic: [PATCH v5 04/12] xen/arm: add SVE exception class handling Thread-Index: AQHZbSQzMQ+GouBmA0y3P+pRTDiAq68pNiQAgAAHA4A= Date: Thu, 13 Apr 2023 13:27:50 +0000 Message-ID: References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-5-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM0PR08MB5489:EE_|DBAEUR03FT041:EE_|PAWPR08MB9736:EE_ X-MS-Office365-Filtering-Correlation-Id: e22c8ac6-a553-472a-1bcf-08db3c22e633 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BWI8JAZCh/TVHVx9JpTphva1KorqYmMY3syXIbBz9to1c/znVrdlRrMNBBMDpCfLAs7QJtJ8uKVt5m09BGcdhOypUq2D84GJdKcJuslECqqXk21QY4rLXWnehIpvr+JreqYoKpfEZ72BkGdbCndkJhgPi6R2cWqDxID/3c/WpvqXwll1VavwMfH8IiHXZBjTznu141WGJ7cJ265HcrY6MI9pXheC9KalO4VikYmhYSxWuHBxAfU3tVDwoe49L/O3jiccyPT62ONV/WhPiQVE8pzd8rNjheI7AaB4icxIqbpgmrqjSgPKjkORGT9NOdVbdG+7PcGjXqhMA9Z3xFGYZRGBHRJaAujQGrxiwfzs3XWCE87VXCdwoetf3uWpeQcLu8n2UWcB5uPOfl7hcIoff71HGuHPn/2zkh+md75jryxLQN514VQrE/Incdr82J+uwDTXD4SGATNOEbRL7ZxZr9hOqhyJfE4O93gGuCrKgGzKpVQATgU+gEJ8gtB7a+y1JA18bhgAki0aVI0yjkI4VrrcDwDT3R+PyKTIGgJ6MOtJLG9aEtvj0QVuVXVYxud1OhO0vzTd040FUaNC0CJv6xb9k+edvxmVil0wEjU1X6mXU3uZ1bZ0uzszFcWRmadg4Twsso2H7UrNbJbIxFmjeg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(366004)(451199021)(38070700005)(478600001)(316002)(54906003)(86362001)(122000001)(66446008)(38100700002)(6916009)(4326008)(66476007)(66946007)(66556008)(64756008)(91956017)(76116006)(33656002)(6486002)(83380400001)(2616005)(41300700001)(2906002)(36756003)(26005)(186003)(71200400001)(6506007)(5660300002)(6512007)(8676002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <11F32304C51EBB4B95704D58160D405E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5489 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bdd4a059-81a2-4015-2639-08db3c22e123 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GaxOB+QFhlceuw/3Xp1u+mBb26j90EJZ+zjM3vTZIMOFDP2ngTWV5Fy26CIPKozLsNJQlFIzLtO/qM/2RMq+0KAoGPJsAdTghVKe/3SE0mtk2B9caPS8m6CLx9RoiN04bd7jQfnoNG0EITWa0HZ/vz9+2JeVuyAT+G5kK9lvnb/LfkrFKiuqB7zQx7mZCseaE6vSxga5AueD1s0OuME3mWCpV8bfJ+H7Zw+br0GJLhyXDDhZQJzZmZ+eO17Ihx+lowWz53GuxMF62zwT0dzgfaWQnGt6/QK2HmYfiJNaSVlQ8OzmuGw9t77RyM2F6cxVzzfS9WlK2y0cbE1KhFp98WhNm7S4pSJPiCJHhPacKBWz0DAGp33gepUOjA/YnnHVa3Zhp4AogWIUoQfFsXHfqR7NKuewwf92d9fWltZWefkgfnzCOxBW9PkGjBtQTlQDysbCgIk8IjiNnEnsO0SyT0gZuWOguqVTuoIVvDk/bOt0TZb5fcB4ro+gBGGu7kPmdtUL8m/tOStN2WP94yhu9UKwKrmgPn6wCi2uJ2b6arscOafqUc/86/TJAhOlUSrwQCn48/pkgSCQmeELQWhkWj+JtHPI4t2NHPwh3m0ZvhSXt69EWUmPeivylvB91KEpYDI24Ul3lDu2qzoBmg+BDaJzt+evspTSG+21AibUfFZqPPwlET/UPHqFYlNgk9q3SY5ZWEjGjqnMO8q6XcMUhw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(6486002)(40460700003)(70206006)(70586007)(4326008)(36756003)(2906002)(86362001)(81166007)(82740400003)(356005)(41300700001)(33656002)(5660300002)(82310400005)(8676002)(8936002)(6862004)(316002)(478600001)(40480700001)(54906003)(6512007)(6506007)(26005)(336012)(36860700001)(2616005)(186003)(107886003)(47076005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:27:59.1720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e22c8ac6-a553-472a-1bcf-08db3c22e633 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9736 DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vdHJhcHMuYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3Ry YXBzLmMNCj4+IEBAIC0yMTYwLDYgKzIxNjAsMTMgQEAgdm9pZCBkb190cmFwX2d1ZXN0X3N5bmMo c3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpDQo+PiAgICAgICAgICBwZXJmY19pbmNyKHRyYXBf c3lzcmVnKTsNCj4+ICAgICAgICAgIGRvX3N5c3JlZyhyZWdzLCBoc3IpOw0KPj4gICAgICAgICAg YnJlYWs7DQo+PiArICAgIGNhc2UgSFNSX0VDX1NWRToNCj4+ICsgICAgICAgIEdVRVNUX0JVR19P TihyZWdzX21vZGVfaXNfMzJiaXQocmVncykpOw0KPj4gKyAgICAgICAgZ3ByaW50ayhYRU5MT0df V0FSTklORywNCj4+ICsgICAgICAgICAgICAgICAgIkRvbWFpbiBpZCAlZCB0cmllZCB0byB1c2Ug U1ZFIHdoaWxlIG5vdCBhbGxvd2VkXG4iLA0KPj4gKyAgICAgICAgICAgICAgICBjdXJyZW50LT5k b21haW4tPmRvbWFpbl9pZCk7DQo+IA0KPiBncHJpbnRrKCkgd2lsbCBhbHJlYWR5IHByaW50IHRo ZSBkb21haW4vdkNQVSBmb3IgeW91LiBBbHNvLCBpZiB5b3Ugd2FudCB0byBwcmludCBhIGRvbWFp biBJRCwgdGhlbiB5b3Ugc2hvdWxkIHVzZSAoIiVwZCIsIGQpIHJhdGhlciB0aGFuICgiJWQiLCBk LT5kb21haW5faWQpLg0KDQpPayBJ4oCZbGwgY2hhbmdlIGl0IHRvOg0KDQpncHJpbnRrKFhFTkxP R19XQVJOSU5HLCAiRG9tYWluIHRyaWVkIHRvIHVzZSBTVkUgd2hpbGUgbm90IGFsbG93ZWRcbiIp Ow0KDQo+IA0KPj4gKyAgICAgICAgaW5qZWN0X3VuZGVmX2V4Y2VwdGlvbihyZWdzLCBoc3IpOw0K Pj4gKyAgICAgICAgYnJlYWs7DQo+PiAgI2VuZGlmDQo+PiAgICAgICAgY2FzZSBIU1JfRUNfSU5T VFJfQUJPUlRfTE9XRVJfRUw6DQo+PiBAQCAtMjE4OSw2ICsyMTk2LDExIEBAIHZvaWQgZG9fdHJh cF9oeXBfc3luYyhzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykNCj4+ICAgICAgY2FzZSBIU1Jf RUNfQlJLOg0KPj4gICAgICAgICAgZG9fdHJhcF9icmsocmVncywgaHNyKTsNCj4+ICAgICAgICAg IGJyZWFrOw0KPj4gKyAgICBjYXNlIEhTUl9FQ19TVkU6DQo+PiArICAgICAgICAvKiBBbiBTVkUg ZXhjZXB0aW9uIGlzIGEgYnVnIHNvbWV3aGVyZSBpbiBoeXBlcnZpc29yIGNvZGUgKi8NCj4+ICsg ICAgICAgIHByaW50aygiU1ZFIHRyYXAgYXQgRUwyLlxuIik7DQo+PiArICAgICAgICBkb191bmV4 cGVjdGVkX3RyYXAoIkh5cGVydmlzb3IiLCByZWdzKTsNCj4gDQo+IEkgdGhpbmsgaXQgd291bGQg YmUgYmV0dGVyIGlmIHlvdSBwYXNzICJTVkUgdHJhcCBhdCBFTDIiIGFzIGEgc3RyaW5nIHJhdGhl ciB0aGFuIGFkZGluZyB5b3VyIG93biBwcmludGsgYWJvdmUuDQoNCk9rIEnigJlsbCByZW1vdmUg dGhlIHByaW50ayBhbmQgZG8ganVzdCBkb191bmV4cGVjdGVkX3RyYXAoIlNWRSB0cmFwIGF0IEVM MiIsIHJlZ3MpOw0KDQo+IA0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiAgI2VuZGlmDQo+PiAgICAg IGNhc2UgSFNSX0VDX0RBVEFfQUJPUlRfQ1VSUl9FTDoNCj4+ICAgICAgY2FzZSBIU1JfRUNfSU5T VFJfQUJPUlRfQ1VSUl9FTDoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3Jh bGwNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:30:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520754.808706 (Exim 4.92) (envelope-from ) id 1pmx1d-00088A-5h; Thu, 13 Apr 2023 13:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520754.808706; Thu, 13 Apr 2023 13:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmx1d-000881-30; Thu, 13 Apr 2023 13:30:09 +0000 Received: by outflank-mailman (input) for mailman id 520754; Thu, 13 Apr 2023 13:30:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmx1b-00087q-Ob for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:30:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmx1b-0003Hy-EN; Thu, 13 Apr 2023 13:30:07 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.20.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pmx1b-0007Ed-5L; Thu, 13 Apr 2023 13:30:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=v7H1LFc+RZzX3FjhIKOTo0D/cMmXgeAh9UuYM+IlyqE=; b=BP3GZR88T5E5p09n7NJusPAn80 uwp9rmi4J0Hy8c/yuvdgK968/tSY1Yzdk1NtuY00apOp0by/DcFmzjUGTOI0TONbFaz9R6R3aT0Vz LX/HCaiJzWJrNBv/BSZU8p4JiUy8HJNWa3YAxpOU2qe9HDg+fDbzNfxeWDeP+NPSH15s=; Message-ID: Date: Thu, 13 Apr 2023 14:30:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/04/2023 14:24, Luca Fancellu wrote: > Hi Julien, Hi Luca, >>> @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>> unsigned int max_vcpus; >>> unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); >>> unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); >>> + unsigned int sve_vl_bits = sve_decode_vl(config->arch.sve_vl); >>> if ( (config->flags & ~flags_optional) != flags_required ) >>> { >>> @@ -602,6 +606,26 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>> return -EINVAL; >>> } >>> + /* Check feature flags */ >>> + if ( sve_vl_bits > 0 ) >>> + { >>> + unsigned int zcr_max_bits = get_sys_vl_len(); >>> + >>> + if ( !zcr_max_bits ) >>> + { >>> + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); >>> + return -EINVAL; >>> + } >>> + >>> + if ( sve_vl_bits > zcr_max_bits ) >>> + { >>> + dprintk(XENLOG_INFO, >>> + "Requested SVE vector length (%u) > supported length (%u)\n", >>> + sve_vl_bits, zcr_max_bits); >>> + return -EINVAL; >>> + } >> >> Is SVE supported for 32-bit guest? If not, then you should had a check here to prevent the creation of the domain if sve_vl_bits is set. > > No SVE is not supported for 32 bit guests, here I think we will get “SVE is unsupported on this machine” because get_sys_vl_len() will return 0. From my understanding, get_sys_vl_len() will return the len supported by the hosts. So if you run a 32-bit guest on top of a 64-bit hosts, then I believe get_sys_vl_len() will be non-zero. >> Can we move this somewhere else to avoid adding extra padding? Also shouldn't this be protected with #ifdef CONFIG_ARM_64 to make clear this is not supported on Xen 32-bit? > > Yes, I’ll move it and protect with CONFIG_ARM_64, is it ok for you if I move it after: > > /* Monitor options */ > struct { > uint8_t privileged_call_enabled : 1; > } monitor; Please check the padding with "pahole". If possible, it would be better to re-use an existing one. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:33:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520758.808716 (Exim 4.92) (envelope-from ) id 1pmx4T-0000KY-Ip; Thu, 13 Apr 2023 13:33:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520758.808716; Thu, 13 Apr 2023 13:33:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmx4T-0000KR-Fy; Thu, 13 Apr 2023 13:33:05 +0000 Received: by outflank-mailman (input) for mailman id 520758; Thu, 13 Apr 2023 13:33:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmx4S-0000KH-9R for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:33:04 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b719632f-d9ff-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 15:33:03 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id n9-20020a05600c4f8900b003f05f617f3cso14767826wmq.2 for ; Thu, 13 Apr 2023 06:33:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b719632f-d9ff-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681392782; x=1683984782; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4K1UoNLB5Wh1WQWKgQkyNekfW4Vh91Orm3gyoXK+OJI=; b=hTXsYSWz5Dn9kvDBeZ0XboBhjt7uqGu2jk483osiWXjOtVRqk/5dT+U1eS71bIcjR0 UMlJQ8B1GlyFrqpDr4NUdHNiBV65MYiwnS9rO941CfebCd+NZDyWSM+WOg/nC41xynmW +fpE/uitj2GPKKMpUYW8Q1ZIOgHb9fTOK4XdZsYLHBzx5+DBwCOKx5ZxMQEbqE+b+rwU MFFBOjg38BdJ8a+XiTIg1xp9euR1wXMFUGc1hWsjNOGTiN7Xg7eIMe1lEkhLCW2sP25E E1AnGys5R7T/C1n5V+WXMNhe1zk5yd7KSezlWrEHGl+e1jV9MAqllKNIzTIyP1XF6EFa 6Ajg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681392782; x=1683984782; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4K1UoNLB5Wh1WQWKgQkyNekfW4Vh91Orm3gyoXK+OJI=; b=Hj40aOlhZ6I/qZSNDVjGYZrTdA694MwhaGH9zfUjwH82M8W+k69QJk5K2aNTBoeV8J RNAoeyv6zTWhEKNCVoHuJDrOHvWyq5je9DBuDygrjkuY0OSCKNRqxErhZ/cSmcCTppTn vWRYDKwhptCx9zp23I7bp0OdkZuf4Jh4/keZpazmq6BMAx1MqQBTGyig5Xfjuaq6Ynm/ UI1KeTSIaxg7M1wOZABJgJ+u9uFoZ3Bkzt27pDlIOiDAa3AL4/1yIuGkyIkV3W6YtX6K sQhJ/3dIfVL2Wbha5hY4PVc8wtwZRnNQb3nYy2Hubjr1H0vmQ9Mndh6S6XgdizNUpIx9 ps0Q== X-Gm-Message-State: AAQBX9cuAXA2cLq40p5Q4hGFxxLD10RQDkeZcmfOyKkrnhV7zYyXgTTz W49xAzKk2tW/AkwahpRVaTjqj8KWDcvMlKpoqiUi0Q== X-Google-Smtp-Source: AKy350Yj2W0pP0IaXaltscmIrZBLEU5xTRF8xqKcfSByIv/x+OFAODxCo8j1+sHOjWAx5c4VWIs382d/bMIGCD9Dijs= X-Received: by 2002:a1c:f302:0:b0:3df:97de:8bab with SMTP id q2-20020a1cf302000000b003df97de8babmr574193wmq.4.1681392782610; Thu, 13 Apr 2023 06:33:02 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-5-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 15:32:51 +0200 Message-ID: Subject: Re: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function IDs To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 12:18=E2=80=AFPM Henry Wang wr= ote: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function = IDs > > > > Adds the remaining SMC function IDs from FF-A 1.1 specification. > > Nit: I would suggest that in commit message you can mention the documenta= tion > number you used. During my review of this patch I am using > DEN0077A version 1.1 REL0. OK, I'll add that. > > > > > Signed-off-by: Jens Wiklander > > Reviewed-by: Bertrand Marquis > > I also confirm that the macro values introduced by this patch is consiste= nt with > the spec in commit message, hence: > > Reviewed-by: Henry Wang Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:40:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:40:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520761.808726 (Exim 4.92) (envelope-from ) id 1pmxBW-0001pA-9o; Thu, 13 Apr 2023 13:40:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520761.808726; Thu, 13 Apr 2023 13:40:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxBW-0001p3-74; Thu, 13 Apr 2023 13:40:22 +0000 Received: by outflank-mailman (input) for mailman id 520761; Thu, 13 Apr 2023 13:40:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxBV-0001ox-70 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:40:21 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2061b.outbound.protection.outlook.com [2a01:111:f400:fe5a::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9800453-da00-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:40:18 +0200 (CEST) Received: from BN9PR03CA0553.namprd03.prod.outlook.com (2603:10b6:408:138::18) by CYYPR12MB8855.namprd12.prod.outlook.com (2603:10b6:930:bb::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:40:14 +0000 Received: from BN8NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:408:138:cafe::71) by BN9PR03CA0553.outlook.office365.com (2603:10b6:408:138::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:40:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT079.mail.protection.outlook.com (10.13.177.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:40:13 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 08:40:12 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 08:40:13 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 08:40:11 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9800453-da00-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j/EHzSU1RUuhpswNi2nUztmMWzsk7GkxZti2iDB5ceo7Hde6lFstFgo7+E1XTGYUzyl4JVUYRdWXxhiXKl//GenrkP5lG+5+V3gDBwSArRvSnSoujq386dheAdU8O5PwCAG8K2T3juapCk/gYVeniZuRKEBURX87B+0OVtKXfjnz2YhQ31b0RnMFf3T3p5q4khYvj46sdn/+/tjuyex+ddG3i1EHKbOSZiF6szz9ZwL3nGt4Gn9vB+QiMsJy3Ni9iX86Wqd0lDXfZ6bH66HPmvlRSqj/YYeAycgCe0oNXCGHfRKBZUJTxVswX2wSQMXmiUAaMa2fB6BOZMsGznio9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E2N7a2FPedQrW8HRhTsmPLwKB/iTYWUt1peWJYN7LVg=; b=B03Hk7CL/S0nMpEyH9roLfVJfLliktGvhM0AcuQX5eSTQ3nHGUK7iKUa2JrGhJnmTZMhsgcMEsWgUfc9Sll3tUS9uRKC4gNyTF9mybz2ENVM2TSIhQ3gQJy6ioe0n7enXsdZB9xKqvLbMVDPzgOz/ZAbPyw2ORMRaU085tPIlk+dVEJ44jeWAToKkS8nevyNcUDFwNOIBikl8wmiiPTItk/9fhj3cxbUjs3b2vVpaUN+AJ+chU4JNeRBu/qkx7v76Ei++Gn+lna0pluzselizkC5jx0W96e4rWAYDxzJFpG19p6xTO1KIqDtj2dnwnzDK7LCAkrJA0/Y76dlT1Tk7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E2N7a2FPedQrW8HRhTsmPLwKB/iTYWUt1peWJYN7LVg=; b=GhCBKVrpHfqQyeaZzRRwEPe3kdl04bAACax8W/IVJ6bh6o/+yqckjvZniXxI7PGh5bhjF9UGPwM51p6YnCeNjZLsQelwkApDfeaOSjhPE7Xx1h8B4oyBpl0fAfAt5JqkoueEqmQv95IZ6fqOUAYBcG/9f13Vcuak+JRje/Cdrp4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <9211242e-102c-4468-c35b-c88f8e31b274@amd.com> Date: Thu, 13 Apr 2023 15:40:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [XEN][PATCH v5 06/17] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Content-Language: en-US To: Vikram Garhwal , CC: , Julien Grall References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-7-vikram.garhwal@amd.com> From: Michal Orzel In-Reply-To: <20230411191636.26926-7-vikram.garhwal@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT079:EE_|CYYPR12MB8855:EE_ X-MS-Office365-Filtering-Correlation-Id: 52a2ce5e-2806-4659-2df5-08db3c249c0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8r4mmPuq33zQyJJgXBtiZXWvzmiXFbdfXLQ7WDm4ddQFpwREnYpBLn+ik8ls7KW5JMI2mN3Xph5oTutNawf6wveW1jnxUOxIrkHZtjLbkk3dqf+T6p2OU1ov6LBZ7p5jMJ0kyYfo2XrE/GfbfWixN+SoLiZ1y4Kcu6aF3GtA2ScQ413P+nvB29rBxsDgEsslLs/clWa3BcF0M3GI0602ojKSQ2V6sq/kReBdK2FWL9JbEjbkpyDMrDbc1q9oQVh81P+qndMTJmCfz8/Vjombrv3IV4jS6tcR+zYIDR2Tsk3MX1q5c2I2a2UzWKbZf6HyV6GZX93LUGOUwFHMao5v9NU6cysYLKt/YiovBKLA5WKYY3e0asM4+FVT2upxJrC2LX6tOKrcfQxA754n/hCYiMjda0KDzG3Y9y+56NlD5W46bPXzVO+hjlunXb6lFGH73oaBB3XaqLB0fEe6HzVxUGZ4PUkbhh9G6m7MvqgFtrUEqFpIxeWHKWT5PAIRerjDeuR7Pt6bOM4+T0iERsM/H7bd8pGVWDspxOc4BY/ikPYQxGPbqYTXNs3HTs8S1ZAc7U0ZD4TYezrdyGsh5J3xNk16fdVhbejNQMBUA/XDnsnjcRASru0TRuSiWmzWbqtTpf0IUqbawxNpTZcsyzjZpYLSnFJPZ/ZsMdoGbnFJrbUwqZZDyxbmL+q+Cr72CUsS2pNXhjpFVova7eTlXZk7AEqGUXoqJWUFrliQnf7dk1EVjic7Om3RVfT/kCcwz3TBBU9CgWnRzk3mHiCjBjwu6dNTZEh549myEeqHwoC+fFQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(2906002)(31686004)(8676002)(70586007)(70206006)(8936002)(5660300002)(44832011)(478600001)(41300700001)(40460700003)(316002)(40480700001)(83380400001)(82740400003)(426003)(336012)(36756003)(16576012)(54906003)(110136005)(4326008)(186003)(86362001)(6666004)(26005)(81166007)(53546011)(2616005)(36860700001)(82310400005)(356005)(47076005)(31696002)(37363002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:40:13.7055 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52a2ce5e-2806-4659-2df5-08db3c249c0b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8855 Hi Vikram, On 11/04/2023 21:16, Vikram Garhwal wrote: > > > Add device_tree_find_node_by_path() to find a matching node with path for a > dt_device_node. > > Reason behind this function: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flattened) is created and updated with overlay nodes. This > updated fdt is further unflattened to a dt_host_new. Next, we need to find > the overlay nodes in dt_host_new, find the overlay node's parent in dt_host > and add the nodes as child under their parent in the dt_host. Thus we need > this function to search for node in different unflattened device trees. You do not mention making dt_find_node_by_path() static inline. > > Signed-off-by: Vikram Garhwal > --- > xen/common/device_tree.c | 5 +++-- > xen/include/xen/device_tree.h | 17 +++++++++++++++-- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index bf847b2584..507b4ac5b6 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -358,11 +358,12 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, > return np; > } > > -struct dt_device_node *dt_find_node_by_path(const char *path) > +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, > + const char *path) > { > struct dt_device_node *np; > > - dt_for_each_device_node(dt_host, np) > + dt_for_each_device_node(dt, np) > if ( np->full_name && (dt_node_cmp(np->full_name, path) == 0) ) > break; > > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index 58ac12abe3..998f972ebc 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -534,13 +534,26 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, > struct dt_device_node *dt_find_node_by_alias(const char *alias); > > /** > - * dt_find_node_by_path - Find a node matching a full DT path > + * device_tree_find_node_by_path - Generic function to find a node matching the > + * full DT path for any given unflatten device tree > + * @dt_node: The device tree to search This should be @dt to match the parameter. Also, shouldn't the description say: "the node to start searching from" or "device tree root node" FWICS, you expect to pass a root node as dt node. However, in device_tree_find_node_by_path() you do not check if a provided node is a root node or not (e.g. no parent). Is this intended? ~Michal From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:44:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520765.808735 (Exim 4.92) (envelope-from ) id 1pmxFC-0002P7-PA; Thu, 13 Apr 2023 13:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520765.808735; Thu, 13 Apr 2023 13:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxFC-0002P0-MK; Thu, 13 Apr 2023 13:44:10 +0000 Received: by outflank-mailman (input) for mailman id 520765; Thu, 13 Apr 2023 13:44:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxFB-0002Ou-LW for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:44:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062e.outbound.protection.outlook.com [2a01:111:f400:fe0e::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42b6aca9-da01-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 15:44:09 +0200 (CEST) Received: from DUZPR01CA0262.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::24) by DBBPR08MB5930.eurprd08.prod.outlook.com (2603:10a6:10:200::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Thu, 13 Apr 2023 13:44:02 +0000 Received: from DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::d2) by DUZPR01CA0262.outlook.office365.com (2603:10a6:10:4b9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 13:44:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT005.mail.protection.outlook.com (100.127.142.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 13:44:01 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 13 Apr 2023 13:44:01 +0000 Received: from 2b12832b2021.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F72E3F02-77E9-473B-8CF2-552D0F44A20B.1; Thu, 13 Apr 2023 13:43:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b12832b2021.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 13:43:50 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS4PR08MB8120.eurprd08.prod.outlook.com (2603:10a6:20b:58c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:43:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 13:43:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42b6aca9-da01-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpDiLgjmhcno6+YylSBX0/fbamyJ59nPjnU0JZsH9h0=; b=c4lU0SlM2QE7utx0koHKHKLb3neiF4IvhtQCgwiXEq2f6VhTg/maBcElAov+4m5wUcLqMsJPTFAPg99UWMrjYGKXDyJzLWsIyeqCLOhClPz/J1OnyqS+lDttUF3kQBrwG8eU+nIPihwCsZ9bx/humBLPTcwQ/y9kforJIF6zzYw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0d7973943360cc7f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OXIhkfPb8W2jvGuxMia47xLqRxJiNyfEqSMFd4WI3Mi637MxvtB6AhHkJ7Bjg82GyLqap5AKBgcrZ5BwIlVHnvbmVLskviVqsJTQwYExhHCA9zKnlrtFdi6FEbfsCoU0JMqqRDLfYzyogVWGkuqcZ9YcDQ8Ln9eq4i2B/IX8bt7fyaRb6zarxOE9sd45VF9j91FiMkssWmycSoAMVk8OsX9xGoWourHDh61ZD681JVxYWd08LpO38XK+fM+xMIKoT57m51mk5jckSBdC2muCYn96xw/25+F6MIFNc8uFoxsolAk6selhLJM91Mfis1sGBgEMEmLspnJkSg68SujktQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QpDiLgjmhcno6+YylSBX0/fbamyJ59nPjnU0JZsH9h0=; b=L2uQv33w8X/7bQyfekx68R/OetJrh2yFaTqhZx1xo6GlZLRuZkf/sou8hRZU8edh5rWYCqGygksefJtM3NvCy4jBTICopILCJ5EbMTaRG6UyDNphd/JiNBCtND54HEl1s0ubuFtmLQe39yOhNf14KOYauUboxuo3uBayoMwdeMv95qEckkMSUUEpXiGbYXEy1/h54KVwbEqCudbLUXipf9F/OkD2hzm0ofBcuS9UbaaQDUrYeD2mqXCPDfSj65fQsCpJcKQYVK2fuVMw5Vh85Uy1jWyTS1XqHOHq6qmtxmgrShWZmUJW0nSE3qQ38v25M0XfMCpebIkUWVbRcIM2xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpDiLgjmhcno6+YylSBX0/fbamyJ59nPjnU0JZsH9h0=; b=c4lU0SlM2QE7utx0koHKHKLb3neiF4IvhtQCgwiXEq2f6VhTg/maBcElAov+4m5wUcLqMsJPTFAPg99UWMrjYGKXDyJzLWsIyeqCLOhClPz/J1OnyqS+lDttUF3kQBrwG8eU+nIPihwCsZ9bx/humBLPTcwQ/y9kforJIF6zzYw= From: Bertrand Marquis To: Julien Grall CC: Jens Wiklander , Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini Subject: Re: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Thread-Topic: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support Thread-Index: AQHZbdfL0AxH2Xu3t0igFa2jZHjA9K8pOEIAgAABeICAAAHsAIAABI2A Date: Thu, 13 Apr 2023 13:43:45 +0000 Message-ID: <0B0212E8-BAC7-4557-B21B-B49EB14F1D09@arm.com> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> <2359695e-f8f8-cf51-27f9-5f0c776feca5@xen.org> <916BB708-3028-4AAB-BD6A-BCABAFBD7C45@arm.com> <2dba6372-330d-a068-241f-59e19b837150@xen.org> In-Reply-To: <2dba6372-330d-a068-241f-59e19b837150@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS4PR08MB8120:EE_|DBAEUR03FT005:EE_|DBBPR08MB5930:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e23ba76-8fca-4159-3365-08db3c25240f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OTuEzy7Kw4oF+10rTaxvq5bddZFm92HxVS1hTbC+GOLuh5FRysrjCKnDegkQxdjDQFam0rZzqHwxAF4ksKZPdkCYlzvY1upNFVjDLwAHBduFysQ3JBLFU1doeYt4QLZGY0XvtpAJ1FZEMysjpC2miwsSu7wBh3QaHL8QDDZkSaNSVZf1bGkEmNwkoXOGoFT9+4wrkeGWHcIGN12OFog6CHvrX37kdjKld0Yvejz3izGPwQ9Xoo2Ay/0vL01MTKAoe5Q7l0NRyfbmtFQf8EmiMn5V2HLIdyl7Hxd8pItSqcpqhZMIWtHbQqvYKJoUvdefqpNomLQjxtVxnJoTSYwcIrD2HPoPKUQazwbARxf/FYZzws8nbDnGp0WJMBdLsJtQC06zivUm6LYdAiFNK92VmtELkV9inTxwW5nyMkyBEcY83LMFymS9UoDLhvWoxkLnCWypn78uoc1aBsKbIUNlzXMHckx8npxZPbuwClP3uiKt8OM1n5jv/VSALlhDXGZvgEw6vqXoz6vqGbQlcnRl6gCqK9XaZhXlNZamjpx1uBMxF7/enlCpEWd7E9dV/VaPxUVdt1qCMf/f8dJyZ8sR/yw1Phk5ZjXKoDzPEwy3ZfENxnAZ9wppgVd1yyv0qDceeALgfZ0g5B7gBUFZ9iCvvQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199021)(41300700001)(2616005)(4326008)(6916009)(64756008)(66446008)(66476007)(66556008)(76116006)(66946007)(91956017)(36756003)(186003)(83380400001)(2906002)(5660300002)(38070700005)(33656002)(8676002)(8936002)(86362001)(6666004)(71200400001)(54906003)(478600001)(6486002)(6506007)(6512007)(53546011)(26005)(316002)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6D9D03559D10EB42A969834AE2120A57@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8120 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 18b6463f-39b3-4b90-69d4-08db3c251a86 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pWQs48axZRvGiKqefU4FZKVobYWzkCdVxW2EmL8Wkp2g7rkHkEDqRE6mzUkkCoimTWumVymVzRmaMjnGs+3zGci2/5e/topYy8lH8ygKzFyo9DAKxn2gaimZ3D+J2UyxEAVkKPSKfnPRt4gBq+zXh9wjp3aWWBfKF292BkOmc3d6X+ENShjVRoGcyCBGen+w1HtPFpNaqZadNV8G7Gjma6VtgPz81337YYJws0xcyIRv60APDyp1F5Dae9YZduEc9WCy7i2WsPvq0/L1MZUQplI2BZ7Yyta6Dskv/OPPBN9ldXEpT3326a+gqDKYe33gO/qY7tI6Tlxwn2VWCD2cbISvOSg6Zhv5PFBAJ/G2KRifl9A2taf1LRaa/5npgFjsyccAlDadX+0ijKIU22wBfsGsv1HUNbcG2hwROeLJiq8+ZyBcfQwLDOC3j4F/2hfqEv5ay+64biR2drTkB3g4X1glE5KQ4G/t3LG26AagoxGdWVdrpo509I+mEclQGWECX+FtDKeNL84cNt1MZPwLwhagrq+c87xg5mcLqOcCupMylS2rqdI5DiIdFQ8x2LmyB/tZyDk73qkSeop9QUMtlu/EuNjVZi71SXtxBwB8DEjSzDeopC+DPfrm0i5QH0Db6ffYhyOF+Yg7CrQzLX9Z2r+o2SzXlh+tuV1ohgZzSgjiRDK3FsODjsQ/1jrAEYL8D8lm/Yt631I/8ErnPmKIOQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(36840700001)(40470700004)(46966006)(5660300002)(316002)(54906003)(478600001)(83380400001)(2616005)(336012)(47076005)(107886003)(6512007)(33656002)(36756003)(6666004)(6506007)(40480700001)(53546011)(186003)(26005)(356005)(81166007)(36860700001)(82310400005)(86362001)(82740400003)(6486002)(40460700003)(41300700001)(6862004)(70586007)(2906002)(8676002)(4326008)(70206006)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:44:01.9020 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e23ba76-8fca-4159-3365-08db3c25240f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5930 Hi, > On 13 Apr 2023, at 15:27, Julien Grall wrote: >=20 >=20 >=20 > On 13/04/2023 14:20, Bertrand Marquis wrote: >> Hi Julien, >>> On 13 Apr 2023, at 15:15, Julien Grall wrote: >>>=20 >>> Hi, >>>=20 >>> On 13/04/2023 08:14, Jens Wiklander wrote: >>>> Adds support for sending a FF-A direct request. Checks that the SP als= o >>>> supports handling a 32-bit direct request. 64-bit direct requests are >>>> not used by the mediator itself so there is not need to check for that= . >>>> Signed-off-by: Jens Wiklander >>>> --- >>>> xen/arch/arm/tee/ffa.c | 112 ++++++++++++++++++++++++++++++++++++++++= + >>>> 1 file changed, 112 insertions(+) >>>> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c >>>> index f129879c5b81..f2cce955d981 100644 >>>> --- a/xen/arch/arm/tee/ffa.c >>>> +++ b/xen/arch/arm/tee/ffa.c >>>> @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) >>>> return true; >>>> } >>>> +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *res= p) >>>> +{ >>>> + switch ( resp->a0 ) >>>> + { >>>> + case FFA_ERROR: >>>> + if ( resp->a2 ) >>>> + return resp->a2; >>>> + else >>>> + return FFA_RET_NOT_SUPPORTED; >>>> + case FFA_SUCCESS_32: >>>> + case FFA_SUCCESS_64: >>>> + return FFA_RET_OK; >>>> + default: >>>> + return FFA_RET_NOT_SUPPORTED; >>>> + } >>>> +} >>>> + >>>> +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_= t a2, >>>> + register_t a3, register_t a4) >>>> +{ >>>> + const struct arm_smccc_1_2_regs arg =3D { >>>> + .a0 =3D fid, >>>> + .a1 =3D a1, >>>> + .a2 =3D a2, >>>> + .a3 =3D a3, >>>> + .a4 =3D a4, >>>> + }; >>>> + struct arm_smccc_1_2_regs resp; >>>> + >>>> + arm_smccc_1_2_smc(&arg, &resp); >>>> + >>>> + return get_ffa_ret_code(&resp); >>>> +} >>>> + >>>> +static int32_t ffa_features(uint32_t id) >>>> +{ >>>> + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); >>>> +} >>>> + >>>> +static bool check_mandatory_feature(uint32_t id) >>>> +{ >>>> + int32_t ret =3D ffa_features(id); >>>> + >>>> + if (ret) >>>> + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing: err= or %d\n", >>>> + id, ret); >>>> + >>>> + return !ret; >>>> +} >>>> + >>>> static uint16_t get_vm_id(const struct domain *d) >>>> { >>>> /* +1 since 0 is reserved for the hypervisor in FF-A */ >>>> @@ -222,6 +272,57 @@ static void handle_version(struct cpu_user_regs *= regs) >>>> set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); >>>> } >>>> +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, u= int32_t fid) >>>> +{ >>>> + struct arm_smccc_1_2_regs arg =3D { .a0 =3D fid, }; >>>> + struct arm_smccc_1_2_regs resp =3D { }; >>>> + struct domain *d =3D current->domain; >>>> + uint32_t src_dst; >>>> + uint64_t mask; >>>> + >>>> + if ( smccc_is_conv_64(fid) ) >>>> + mask =3D GENMASK_ULL(63, 0); >>>> + else >>>> + mask =3D GENMASK_ULL(31, 0); >>>> + >>>> + src_dst =3D get_user_reg(regs, 1); >>>> + if ( (src_dst >> 16) !=3D get_vm_id(d) ) >>>> + { >>>> + resp.a0 =3D FFA_ERROR; >>>> + resp.a2 =3D FFA_RET_INVALID_PARAMETERS; >>>> + goto out; >>>> + } >>>> + >>>> + arg.a1 =3D src_dst; >>>> + arg.a2 =3D get_user_reg(regs, 2) & mask; >>>> + arg.a3 =3D get_user_reg(regs, 3) & mask; >>>> + arg.a4 =3D get_user_reg(regs, 4) & mask; >>>> + arg.a5 =3D get_user_reg(regs, 5) & mask; >>>> + arg.a6 =3D get_user_reg(regs, 6) & mask; >>>> + arg.a7 =3D get_user_reg(regs, 7) & mask; >>>> + >>>> + arm_smccc_1_2_smc(&arg, &resp); >>>> + switch ( resp.a0 ) >>>> + { >>>> + case FFA_ERROR: >>>> + case FFA_SUCCESS_32: >>>> + case FFA_SUCCESS_64: >>>> + case FFA_MSG_SEND_DIRECT_RESP_32: >>>> + case FFA_MSG_SEND_DIRECT_RESP_64: >>>> + break; >>>> + default: >>>> + /* Bad fid, report back. */ >>>> + memset(&arg, 0, sizeof(arg)); >>>> + arg.a0 =3D FFA_ERROR; >>>> + arg.a1 =3D src_dst; >>>> + arg.a2 =3D FFA_RET_ABORTED; >>>> + } >>>> + >>>> +out: >>>> + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 &= mask, >>>> + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 = & mask); >>>> +} >>>> + >>>> static bool ffa_handle_call(struct cpu_user_regs *regs) >>>> { >>>> uint32_t fid =3D get_user_reg(regs, 0); >>>> @@ -239,6 +340,10 @@ static bool ffa_handle_call(struct cpu_user_regs = *regs) >>>> case FFA_ID_GET: >>>> set_regs_success(regs, get_vm_id(d), 0); >>>> return true; >>>> + case FFA_MSG_SEND_DIRECT_REQ_32: >>>> + case FFA_MSG_SEND_DIRECT_REQ_64: >>>> + handle_msg_send_direct_req(regs, fid); >>>> + return true; >>>> default: >>>> gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); >>>> @@ -326,6 +431,13 @@ static bool ffa_probe(void) >>>> printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", >>>> major_vers, minor_vers); >>>> + /* >>>> + * TODO save result of checked features and use that information = to >>>> + * accept or reject requests from guests. >>>> + */ >>>=20 >>> I am not entirely sure I understand this TODO. Does it mean a guest can= currently use a request that is not supported by FFA? >> In fact this is a bit the opposite: in the following patch we check that= all features we could need are supported but if a guest is only using a su= bset we might not need to have all of them. >> Idea of this TODO would be to save the features supported and refuse gue= st requests depending on the features needed for them. >=20 > Thanks. I would suggest the following comment: >=20 > /* > * At the moment domains must supports the same features used by Xen. > * TODO: Rework the code to allow domain to use a subset of the features > * supported. > */ >=20 > Note that I am using "domains" rather than "guests" because the latter do= esn't include dom0. Makes sense and new comment is nice. Up to Jens to say if he is ok with it. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:45:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520770.808745 (Exim 4.92) (envelope-from ) id 1pmxGe-00031D-7z; Thu, 13 Apr 2023 13:45:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520770.808745; Thu, 13 Apr 2023 13:45:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxGe-000316-5P; Thu, 13 Apr 2023 13:45:40 +0000 Received: by outflank-mailman (input) for mailman id 520770; Thu, 13 Apr 2023 13:45:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxGc-00030t-Qr for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:45:38 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78d01c93-da01-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 15:45:37 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso13130222wmr.0 for ; Thu, 13 Apr 2023 06:45:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78d01c93-da01-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681393537; x=1683985537; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vyrGnitHbdUQwqT6RzMJ7xCDQTyGge708Ud+KeXIuOo=; b=vPDgz4ZuYSkCfQN1oGmbPdFR/lSJnvxtNfM6Jem1xta7eVlogCwNKcR74qi/w7KEkt Llq3LNWZhr5UJio9mPoFZYKiyapBR2jJ0QQ7pe+WEec8fJXZ25UYJpXA0Qbjd9L6aFX8 gjTFux7rWot6b+eXZBGokLv0tX8w8jsGlc6isYO9zgTyMoMotTfSzspApSWZ5KO6cuXc CEhQLH7WQD88rfRsWJCKpA8Xh4MeO2h3oKmBsc9yg3em2ip74WNWay5N3hro9uBVizNl By2iuNFRToDGuTHmfiuby3W8L7sXiaGgY+9b71akncSFkjevf3r6wkwsAPP+WLXbt0QS NhLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681393537; x=1683985537; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vyrGnitHbdUQwqT6RzMJ7xCDQTyGge708Ud+KeXIuOo=; b=R8XSBewCl59jY1u7brBCJag/EOLP4jVW8KFQt3zfYSX7pblPhg19eIgvafKW4pI5JT eCi5Dsdr6c6KpIFLOA6JhYe0H0nf3yGNrt88sno/ecifJKS72Uc8QP919EG3w+1+5O3E zRQkAyaa+3Uek/wc75t99r5NNReuY0lm3hiAe0O8VlhNNtRyPfuDDQ2YQDYAhZySgCpS QCRnJmKVOw6Ar5tr06Ox7nRf+5pDcYHRHIfitUQc7DknvZOLkXfEI06Z+ASB3UAAHkY/ QANSdOc2XWghHtVr/G9zc0LMb0KLaeGpEB184W7sT2dGFxfhudqgRBXX/1J+0Krc+zib xbRg== X-Gm-Message-State: AAQBX9dB8on/q8zvLrvCoB/cFyAlQkh7Ok0KYiuYtRKUIIIjRPCTvLWM 8b7A1Qnx+suCY6I6UDUx893XfpFhiY0Gb4RO/kmxlQ== X-Google-Smtp-Source: AKy350ZswUTkpoHgm+BaPSSDOy/tKOK15YjSzcEmz1HZMPqZXjTmeRGSjcvzIxZSHzYbnrRWNsuqd2zyR+jn1nOvFq8= X-Received: by 2002:a05:600c:201:b0:3f0:4428:94eb with SMTP id 1-20020a05600c020100b003f0442894ebmr487362wmi.4.1681393537130; Thu, 13 Apr 2023 06:45:37 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-6-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 15:45:26 +0200 Message-ID: Subject: Re: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 13, 2023 at 12:28=E2=80=AFPM Henry Wang wr= ote: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for > > FFA_PARTITION_INFO_GET > > > > Defines flags used for the function FFA_PARTITION_INFO_GET. > > Nit: Similarly as my comment for patch #4, I would suggest that in > commit message you can mention the documentation number and > the chapter of FFA_PARTITION_INFO_GET. Something like: > "According to DEN0077A version 1.1 REL0, section 13.8, defines > flags used for the function FFA_PARTITION_INFO_GET" I'll add that. > > > > > Signed-off-by: Jens Wiklander > > --- > > xen/arch/arm/tee/ffa.c | 34 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > > index ba0942e76993..72e7d0575de5 100644 > > --- a/xen/arch/arm/tee/ffa.c > > +++ b/xen/arch/arm/tee/ffa.c > > @@ -57,6 +57,40 @@ > > #define FFA_MY_VERSION > > MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > > FFA_MY_VERSION_MINOR) > > > > +/* > > + * Flags to determine partition properties in FFA_PARTITION_INFO_GET > > return > > + * message: > > + * BIT(0): Supports receipt of direct requests > > + * BIT(1): Can send direct requests > > + * BIT(2): Can send and receive indirect messages > > + * BIT(3): Supports receipt of notifications > > + * BIT(4-5): Partition ID is a PE endpoint ID > > + * BIT(6): Partition must be informed about each VM that is created by > > + * the Hypervisor > > + * BIT(7): Partition must be informed about each VM that is destroyed = by > > + * the Hypervisor > > + * BIT(8): Partition runs in the AArch64 execution state else AArch32 > > + * execution state > > + */ > > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > > +#define FFA_PART_PROP_IS_MASK (3U << 4) > > I am a bit confused here, here (3U<<4) is "IS_MASK" but... > > > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) > > ...here the same value is used for "IS_AUX_ID". According to > the spec that I referred to, bit[5:4] has the following encoding: > b'11: Partition ID is an auxiliary ID. Hence I guess the above > "IS_MASK" should be removed? FFA_PART_PROP_IS_MASK is supposed to be used when extracting the bits to compare with one of the other FFA_PART_PROP_IS_* defines. For example: if ((props & FFA_PART_PROP_IS_MASK) =3D=3D FFA_PART_PROP_IS_PE_ID) using if ((props & FFA_PART_PROP_IS_AUX_ID) =3D=3D FFA_PART_PROP_IS_PE_ID) doesn't seem right. > > I confirm the values of other fields are consistent with the spec. Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:52:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:52:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520774.808756 (Exim 4.92) (envelope-from ) id 1pmxMl-0004U3-V6; Thu, 13 Apr 2023 13:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520774.808756; Thu, 13 Apr 2023 13:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxMl-0004Tw-Qo; Thu, 13 Apr 2023 13:51:59 +0000 Received: by outflank-mailman (input) for mailman id 520774; Thu, 13 Apr 2023 13:51:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxMk-0004Tq-Tu for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:51:58 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ab890de-da02-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:51:56 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id l16so8071206wms.1 for ; Thu, 13 Apr 2023 06:51:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ab890de-da02-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681393916; x=1683985916; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bi8hFeyLb1wtgcL73aZmUI9/nlIn4MwZ/hV9h9PzSJA=; b=y9X7e5x3js+izG438LeC1AhCpvDq6t/rItKXY/kwYKAZKe/3cLmHpAfRJIQQxG+QuD FPYfNh3mJylLvT1Ty5H/7xtjnBOMa+QBejtHS6lF2aaLYc2Fey7b5mrBaKVD0EK/UL48 3Ur3F2voxg5/HEXQmbF8/dLAKl0ehgegrxduvtKXJ2SPqSV50tS8+49XPi0GFPD5nZWL 64/NYS3HYhpv3bZqcY1i5qdrqxs6T6yJdySvCBLDW2ql7IXp+plil79yVk44OeU0QY5a VHBY/PeAtHSp9ol50ehvIWYc6C06TfvzNYmNbRJggLItPc3e2qk4zueChijKBjQa2Vnv 71VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681393916; x=1683985916; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bi8hFeyLb1wtgcL73aZmUI9/nlIn4MwZ/hV9h9PzSJA=; b=VWltT80G5jPTOPAB8LDghdSWngpKAsBvXLTdO8zrdk775Mj6bZPYAKaU03H44PDAMe bcUqt6DSEF1MWnpk2XxRVRju4x4I/seTc6PiFbYstDrP2d4hWRGiaJX7tSPmfIMaoKPl 5FftV9MHKxZAxhBGADbGm0PNFCvzm9fWYkyFSses7cXsezn5OT7sHTvIXcwiptxmMoE3 5Ii7R5hR+ui9tka3BM70cZolrkFrweUSJbbQq7+ACfww7XIMr8wv1a2WYJtG4cSS/t5G +SSalg6RAcRjGapg+1qA5ShG9vwJAHcujVubdFyoUU3RwPDKL2RwosdOPQrMOv+PaIQG ICkA== X-Gm-Message-State: AAQBX9fJ6IpTbmbRrKOjhOaH1NficLU6Fgeq8DhZVy54IocLYS75lvhL sZRqPwwZKWDQN0BGOpVahABos//vNEhQILsqlsf/qg== X-Google-Smtp-Source: AKy350YB6S6RKRB7rmgQ7y0ai4x80rdo5aGQytRTIaOdAgl7Ml5rxXp5ZfffiyiZPXt6jnNJtzGquxitYt+muVcJxlE= X-Received: by 2002:a05:600c:b4e:b0:3ee:9c6d:832a with SMTP id k14-20020a05600c0b4e00b003ee9c6d832amr595980wmr.4.1681393916086; Thu, 13 Apr 2023 06:51:56 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-7-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 15:51:45 +0200 Message-ID: Subject: Re: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct request/response messages To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 12:51=E2=80=AFPM Henry Wang wr= ote: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework d= irect > > request/response messages > > > > Adds defines for framework direct request/response messages. > > Same here, it actually took me a while to find the related chapters > about this patch, so I would suggest that we can add more details > about where the values are from. > > From the spec that I referred to (DEN0077A version 1.1 REL0), they are > in section 18.3, Table 18.{21, 25, 26, 27,28}. OK, I'll add it. > > > > > Signed-off-by: Jens Wiklander > > I confirm the values introduced by this patch are consistent with the > above spec, hence: > > Reviewed-by: Henry Wang Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:53:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:53:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520777.808766 (Exim 4.92) (envelope-from ) id 1pmxOH-00051W-8w; Thu, 13 Apr 2023 13:53:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520777.808766; Thu, 13 Apr 2023 13:53:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxOH-00051P-68; Thu, 13 Apr 2023 13:53:33 +0000 Received: by outflank-mailman (input) for mailman id 520777; Thu, 13 Apr 2023 13:53:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxOF-00051J-SH for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:53:31 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061a.outbound.protection.outlook.com [2a01:111:f400:7e1b::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 920bcd8a-da02-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 15:53:29 +0200 (CEST) Received: from AM5PR0202CA0021.eurprd02.prod.outlook.com (2603:10a6:203:69::31) by GV2PR08MB8027.eurprd08.prod.outlook.com (2603:10a6:150:77::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Thu, 13 Apr 2023 13:53:25 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:69:cafe::a3) by AM5PR0202CA0021.outlook.office365.com (2603:10a6:203:69::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 13:53:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Thu, 13 Apr 2023 13:53:24 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Thu, 13 Apr 2023 13:53:24 +0000 Received: from f0e5d4ac022f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22D427B3-6A3D-4AD2-98A1-D12CD192B6F5.1; Thu, 13 Apr 2023 13:53:17 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f0e5d4ac022f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 13:53:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR3PR08MB5563.eurprd08.prod.outlook.com (2603:10a6:102:89::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 13:53:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 13:53:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 920bcd8a-da02-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/IiZS1H1pLzzQw8lxikRzQ5nWgyR1+jPu0WKdMTNjc=; b=nm7nbIVzgJdADF7rej5vFCPKbODKG2Sg0lZW6FwMmjtEppOJMT788w2snrez3drA+inVAFmO3szIUQrexgtTbsRnotrF8U+zLdACArZqsz9duQ9mm4K2CA58zXP1CU2o9RNZxszMJkzgNOBuFTae/PClcZHSmWhNFFYYu5PBvrw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gy6uKaLkpLZXAJKeAF+RACDIQioF8CPa7zV+125vQUYtFzkOmF3AlflQAe8CWbUMick//9uECIVrBlDALhwJjMQTjR3lYnUZTvJKbsf87xWYJpSpnNikbyiHnhNNRjij9l/l7N765H4HDwWBEMCdmqw/Mxlu7StsjP+gxhg9CInb+uCqNaCqo6tfEFn4K3Kv/fZyxLwRw/thQNJNOgXwnjPzioFHIbAxBvAnLj+hhZbF1mpaIBvlx0hsQvno/J62CZskY+OEZug5EKrSLwpS6qGVvFbMloKQzmeiaG4lPKLrq8sTdpgyNjRWOZNy4ITZgw+03Wsjps+fuUhOqawPiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X/IiZS1H1pLzzQw8lxikRzQ5nWgyR1+jPu0WKdMTNjc=; b=K1DNe5MeToeS+KC6X7aLaxxxgf0D+cw+mHJnraTnUgtI0HNT9jbBbhgG/5tQiIuXOdmNpIGOfHQDdVfy8aBp+RrrWfH70sQ10XjQLFlZe9vA1PceeA3k1EmJGr6VHjh/1O7ObHoQISrq0xACj/KS4YdGBmZGtxt3aqlyFI6mRcV1uhgyV9KD/fk01H5ezfSzjUFUZX0+VT/e+9j9i/R3yx9KxVjcR88aGjKnLlLtdlh24W1hK7Yzppra5P/BBxkSB/Xi+iARG1Ok9l2IiH9wesP/MdHVpUlJG/MDhU9BtIpwuqLcL78aUQTrPaLuCj4Nr1JTuTQS8LiYmzPMCeKIUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/IiZS1H1pLzzQw8lxikRzQ5nWgyR1+jPu0WKdMTNjc=; b=nm7nbIVzgJdADF7rej5vFCPKbODKG2Sg0lZW6FwMmjtEppOJMT788w2snrez3drA+inVAFmO3szIUQrexgtTbsRnotrF8U+zLdACArZqsz9duQ9mm4K2CA58zXP1CU2o9RNZxszMJkzgNOBuFTae/PClcZHSmWhNFFYYu5PBvrw= From: Henry Wang To: Jens Wiklander CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: RE: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Thread-Topic: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Thread-Index: AQHZbdfQYdI+Ke10g0y9D6f6Y8dBZq8pCBXggAA4ogCAAAB2UA== Date: Thu, 13 Apr 2023 13:53:11 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-6-jens.wiklander@linaro.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CD35A620DCA0CA42B04F4775A9FD4A73.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PR3PR08MB5563:EE_|AM7EUR03FT040:EE_|GV2PR08MB8027:EE_ X-MS-Office365-Filtering-Correlation-Id: 23265e6d-4a17-4572-997b-08db3c2673a9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Kiw833tvy6p2VfGa30IJc4oruS7bWITyj1OHTUiDGjklItRiDrsIrAplUESIZ/vG8F0XB6EcDH2d69sTeykMFbdHp8o6HvpkTebszE6up/lBW2HHLYqvecTGFXGibBWs8xMUGq2LqXBG9Mp2A1yaancJXHs1W3kyrTRqY3SX6CSSzpiLfDQFnBqxSC1aQquJrm0rm1JJkzVWtsXGGuBaG0ZAiMJr2mOUmnlqkjpvxowAVEM4xNi92t1u62P8jcoN4mxMXuiTcJ56suzz8+Fqw5GCghH/6JhnIWpnmpMiQseDdjIe/nXMhzrrQsNypYUOXzdP/nUDQYSD4I98qlhUTEz9aMM3vksl4DLJxH6AhH6oQ+2x4NEldhchQ0hEmIwuc74irpLyoN/gqp31cS8DQCrvWRAo73BxOq/JNnPgUzxsvZa3YK5z03xK1+ljDNpssiD3EgFRPGgFf95qj2EJTkK3DN53gT0g+t8YKtT/jlckWvCsA7W9MMHlYLwtTUbeQkALXF+Vf9cvrCQWaPJHBh0zu1IqZ8U1C31zEAOEVZ2Ba1Wz8qkrog4E+bplU7fXH+rVF403Qa5wzwIcZss49ukya+qtZY2iCGPWsHW1l7qaKnv+q4j1OJa2CrOlJOkV X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199021)(8676002)(8936002)(76116006)(41300700001)(5660300002)(52536014)(66446008)(66476007)(66556008)(66946007)(64756008)(122000001)(6916009)(4326008)(316002)(2906002)(478600001)(54906003)(86362001)(38070700005)(38100700002)(7696005)(186003)(9686003)(6506007)(55016003)(71200400001)(83380400001)(26005)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5563 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 170c55e6-2a8b-41bc-6b82-08db3c266b9d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dePGJLiQc016Mm1JrOzms7JrxzI5M8Am8mHzkUd8CuRvkzb07inabgQYAGml/KZixqcjMGG6RAKsRJzSITcWsj4gO9rz2wQQEgM9uOpdAJDrhzBguxEolfvYOUHMnakMR9Z7Xg8rovCu35/GNLX6eIWjPt2TgNJA5kpVvo/U2/6O9yrBQRSfnwq7coypj5ZQqiy4JJS4xN6Haji0YYLibWhNkK8JSu1md16DSQcAi+RM1hnkRu4t97CbYeJv6SXxsErWgABq9MhY9USGzNTIUjn9qQeZ8eaUzvpmYVivjuFjSOXiVq1VP+eg8c1SYNCS6feJTDJ4hS/iZflRMnsGio14BnM4RzeQg0Ffjh4xXkLJYgLdRJ/MUJo/GvO4x39WN2mVefq/cIq5Ge64AmiJ0qvE+3nUqciIAKCWIKGI75ZAc98UPsTsFx9UjAepkRDwe+kVgmdiWLuiGlHDGikOw3sivmduymo1K4rBSHjf93CKDcoOSF6gRcrKSNjHSEbUuMLB/Dk7yd5o73ycoD7P0BoXCryD/ANsAiFziFKnt4APut3on1ofL8KWaR7W0J8aiKKLx5kdKyvEyxa355575XDXNndvv557GfcpINm4nChW6HEksLj91PkTDNrGuOS24rA6qD6imZFBhCttj2rE17JadMr3mMJF6up/RIkKjMFIg5s0Nk6B3o/qSMc3NIA45SzkntqWVnM4HWIDgaPh3g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199021)(36840700001)(40470700004)(46966006)(478600001)(7696005)(83380400001)(40480700001)(55016003)(47076005)(356005)(81166007)(82740400003)(33656002)(336012)(86362001)(36860700001)(2906002)(316002)(6506007)(9686003)(26005)(186003)(54906003)(5660300002)(82310400005)(6862004)(52536014)(8936002)(41300700001)(40460700003)(8676002)(4326008)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 13:53:24.9506 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23265e6d-4a17-4572-997b-08db3c2673a9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8027 SGkgSmVucywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKZW5zIFdp a2xhbmRlciA8amVucy53aWtsYW5kZXJAbGluYXJvLm9yZz4NCj4gU3ViamVjdDogUmU6IFtYRU4g UEFUQ0ggdjggMDUvMjJdIHhlbi9hcm06IGZmYTogYWRkIGZsYWdzIGZvcg0KPiBGRkFfUEFSVElU SU9OX0lORk9fR0VUDQo+ID4gPiArI2RlZmluZSBGRkFfUEFSVF9QUk9QX0RJUkVDVF9SRVFfUkVD ViAgIEJJVCgwLCBVKQ0KPiA+ID4gKyNkZWZpbmUgRkZBX1BBUlRfUFJPUF9ESVJFQ1RfUkVRX1NF TkQgICBCSVQoMSwgVSkNCj4gPiA+ICsjZGVmaW5lIEZGQV9QQVJUX1BST1BfSU5ESVJFQ1RfTVNH UyAgICAgQklUKDIsIFUpDQo+ID4gPiArI2RlZmluZSBGRkFfUEFSVF9QUk9QX1JFQ1ZfTk9USUYg ICAgICAgIEJJVCgzLCBVKQ0KPiA+ID4gKyNkZWZpbmUgRkZBX1BBUlRfUFJPUF9JU19NQVNLICAg ICAgICAgICAoM1UgPDwgNCkNCj4gPg0KPiA+IEkgYW0gYSBiaXQgY29uZnVzZWQgaGVyZSwgaGVy ZSAoM1U8PDQpIGlzICJJU19NQVNLIiBidXQuLi4NCj4gPg0KPiA+ID4gKyNkZWZpbmUgRkZBX1BB UlRfUFJPUF9JU19QRV9JRCAgICAgICAgICAoMFUgPDwgNCkNCj4gPiA+ICsjZGVmaW5lIEZGQV9Q QVJUX1BST1BfSVNfU0VQSURfSU5ERVAgICAgKDFVIDw8IDQpDQo+ID4gPiArI2RlZmluZSBGRkFf UEFSVF9QUk9QX0lTX1NFUElEX0RFUCAgICAgICgyVSA8PCA0KQ0KPiA+ID4gKyNkZWZpbmUgRkZB X1BBUlRfUFJPUF9JU19BVVhfSUQgICAgICAgICAoM1UgPDwgNCkNCj4gPg0KPiA+IC4uLmhlcmUg dGhlIHNhbWUgdmFsdWUgaXMgdXNlZCBmb3IgIklTX0FVWF9JRCIuIEFjY29yZGluZyB0bw0KPiA+ IHRoZSBzcGVjIHRoYXQgSSByZWZlcnJlZCB0bywgYml0WzU6NF0gaGFzIHRoZSBmb2xsb3dpbmcg ZW5jb2Rpbmc6DQo+ID4gYicxMTogUGFydGl0aW9uIElEIGlzIGFuIGF1eGlsaWFyeSBJRC4gSGVu Y2UgSSBndWVzcyB0aGUgYWJvdmUNCj4gPiAiSVNfTUFTSyIgc2hvdWxkIGJlIHJlbW92ZWQ/DQo+ IA0KPiBGRkFfUEFSVF9QUk9QX0lTX01BU0sgaXMgc3VwcG9zZWQgdG8gYmUgdXNlZCB3aGVuIGV4 dHJhY3RpbmcgdGhlIGJpdHMNCj4gdG8gY29tcGFyZSB3aXRoIG9uZSBvZiB0aGUgb3RoZXIgIEZG QV9QQVJUX1BST1BfSVNfKiBkZWZpbmVzLiBGb3INCj4gZXhhbXBsZToNCj4gaWYgKChwcm9wcyAm IEZGQV9QQVJUX1BST1BfSVNfTUFTSykgPT0gRkZBX1BBUlRfUFJPUF9JU19QRV9JRCkNCg0KT2ho IEkgbm93IHVuZGVyc3RhbmQsIHRoZSBuYW1pbmcgZG9lcyBub3QgbWVhbiBpdCAiaXMgYSBtYXNr IiBidXQgYWN0dWFsbHkNCm1lYW5zICJ0aGlzIGlzIGEgbWFzayBmb3IgRkZBX1BBUlRfUFJPUF9J U18iLiBUaGF0IG1ha2VzIGEgbG90IG9mIHNlbnNlLg0KDQpUbyBhdm9pZCB0aGlzIGtpbmQgb2Yg YW1iaWd1aXR5LCBkbyB5b3UgdGhpbmsgY2hhbmdpbmcgdGhlIG5hbWUgdG8gc29tZXRoaW5nDQps aWtlICJGRkFfUEFSVF9QUk9QX0lTX1RZUEVfTUFTSyIgbWFrZXMgc2Vuc2UgaGVyZT8gTm90ZSB0 aGF0IHRoaXMNCmlzIGp1c3QgbXkgc3VnZ2VzdGlvbiwgeW91IGNhbiBkZWNpZGUgdG8gY2hhbmdl IG9yIG5vdCwgSSBhbSBhc2tpbmcganVzdA0KYmVjYXVzZSBJIGRvd25sb2FkZWQgdGhlIHdob2xl IHNlcmllcyBhbmQgZm91bmQgdGhhdCBjdXJyZW50bHkNCkZGQV9QQVJUX1BST1BfSVNfTUFTSyBp cyBub3QgdXNlZCBhbnl3aGVyZSwgc28gYmVmb3JlIGl0IGlzIHVzZWQgZXZlcnl3aGVyZQ0KaW4g dGhlIGNvZGUsIGl0IG1pZ2h0IGJlIGdvb2QgdG8gdXNlIGEgbW9yZSBjbGVhciBuYW1lLg0KDQo+ IA0KPiB1c2luZw0KPiBpZiAoKHByb3BzICYgRkZBX1BBUlRfUFJPUF9JU19BVVhfSUQpID09IEZG QV9QQVJUX1BST1BfSVNfUEVfSUQpDQo+IA0KPiBkb2Vzbid0IHNlZW0gcmlnaHQuDQoNCkluZGVl ZC4gUGxlYXNlIHNlZSBteSBhYm92ZSByZXBseS4NCg0KUGVyc29uYWxseSBhZnRlciB0aGUgYWJv dmUgY2xhcmlmaWNhdGlvbiwgSSBhbSBnb29kIHdpdGggdGhlIHBhdGNoLCBzbzoNCg0KUmV2aWV3 ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0K SGVucnkNCg0KPiANCj4gPg0KPiA+IEkgY29uZmlybSB0aGUgdmFsdWVzIG9mIG90aGVyIGZpZWxk cyBhcmUgY29uc2lzdGVudCB3aXRoIHRoZSBzcGVjLg0KPiANCj4gVGhhbmtzLA0KPiBKZW5zDQo+ IA0KPiA+DQo+ID4gS2luZCByZWdhcmRzLA0KPiA+IEhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:53:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:53:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520778.808776 (Exim 4.92) (envelope-from ) id 1pmxOQ-0005Je-Gs; Thu, 13 Apr 2023 13:53:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520778.808776; Thu, 13 Apr 2023 13:53:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxOQ-0005JV-E7; Thu, 13 Apr 2023 13:53:42 +0000 Received: by outflank-mailman (input) for mailman id 520778; Thu, 13 Apr 2023 13:53:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxOP-0005J3-Q7 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:53:41 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98db509d-da02-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 15:53:40 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id n9-20020a05600c4f8900b003f05f617f3cso14822555wmq.2 for ; Thu, 13 Apr 2023 06:53:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98db509d-da02-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681394020; x=1683986020; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EMNbENZ/an/kqDDNkeCv4pxr/53e2QvX/R0pQ4lykeQ=; b=oLq/2keE4B1A6VNLw5cBwA/8gYSagdHEiJZOPBxxVr82/z4v2zuE0jXWPOjiww/0WJ Y40CmAgf6nQvjhMXl/by94OXN6cgbO0cnZHo919qwd1Ho8uoCh5n1TpM/xWugZFVwi+D B4Hk7XVZgt5/OL0YS7yoz4Ki35lv7Jwlgxvvf8I0NMzuzhDX2b9kGphR0R4gv6D6pXUJ 3pf7onvgb4iseYCuD59Ouxtfclf39UulFq5to/qz/YGOzyEaspVSGEdUDQSwbXrvhjXg klDSdBBZBeJe1e2kEiwjIoO8Bk8dMtC7ssgKq9fzWuJgm/T+yA9kDfZbxqlCnaba0nzs zAJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681394020; x=1683986020; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EMNbENZ/an/kqDDNkeCv4pxr/53e2QvX/R0pQ4lykeQ=; b=Koz+CMeqyqrcy55Cte1BNeXSzRMTjliDTisrl5pxh7w7fk7w5DQKXMVYVLtpE8QTfO AM6+NTgH8Z+31a1jkzz8/g5OaQGeu16PVbFWxO3M2/7TNBrFLQuuCv2km+YVcsbJgiN8 jCx6nkw3Q/9+AwrtejBFrOnaZ37XPKo3op40NgssRrU8sq2H+3tgbTY/9+f9fLl907tr Fh5mI2VsON1fwGbGORGKGl680cOACX//cFRc4IThU6lyc87MuhV+KRRjbTb/ITxqz/ek bZfjqGQpFcRKO4ozL+GLnLSsOTXKZ2+NT2MqIQ2UeFU09lzeHaoRHuooyfQDdkBCC87k NdAg== X-Gm-Message-State: AAQBX9ezfbz0BfqDIfQFo0NtVQ8JjCEle+HXkuq+6RWV7CEOgA7ubFXo mQcNabE4Dqy9ZoMQtjceznbzgOi4voaoijPVfElhyDVtWP4SeBTN X-Google-Smtp-Source: AKy350a746AeL5Gds3W5jEKlBuDR4I4Al2+ghgojas/6QlIgOOyTOf0iG4jd9RBggZQzgLFsE4FISYcSBaLI9q4/pYc= X-Received: by 2002:a1c:7901:0:b0:3ee:41a8:729a with SMTP id l1-20020a1c7901000000b003ee41a8729amr618534wme.4.1681394020360; Thu, 13 Apr 2023 06:53:40 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-8-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 15:53:29 +0200 Message-ID: Subject: Re: [XEN PATCH v8 07/22] xen/arm: ffa: enforce dependency on 4k pages To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 12:55=E2=80=AFPM Henry Wang wr= ote: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 07/22] xen/arm: ffa: enforce dependency on 4k pa= ges > > > > Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A > > mediator since the current implementation only works if Xen page size i= s > > the same as the FFA page size. > > > > Signed-off-by: Jens Wiklander > > Reviewed-by: Bertrand Marquis > > Reviewed-by: Henry Wang I'll add that. Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 13:56:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 13:56:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520785.808786 (Exim 4.92) (envelope-from ) id 1pmxRB-0006FO-4v; Thu, 13 Apr 2023 13:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520785.808786; Thu, 13 Apr 2023 13:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxRB-0006FH-27; Thu, 13 Apr 2023 13:56:33 +0000 Received: by outflank-mailman (input) for mailman id 520785; Thu, 13 Apr 2023 13:56:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxR9-0006FB-CX for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 13:56:31 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fde3aef7-da02-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 15:56:30 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id eo6-20020a05600c82c600b003ee5157346cso10083289wmb.1 for ; Thu, 13 Apr 2023 06:56:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fde3aef7-da02-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681394190; x=1683986190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eos6FtVFfmj4vjZAg3YpgEZaX/+K/gklwxVdRbaWJ3g=; b=FdkS6+FW2dOBE82Ak23abgGnZabZmz9UwCDBa+6K18eQg6jPg9uEAk+jNJWv4DdM+N 6KYZIfaIaSoIDqEaQ+QKik6VVdseXfC2V6w3IXTLJIRPTmUM/IgPw6teQPEn+U31Pf4x YgOC/javi6IEmllwW0Jbtp1KoGOVhZaYMw7PNAW/ZqelYGEnEv5eL0iVksfgdm6qzHwL FpMS7AV4OIaOQrDhm4uOW5oexgbzy5qB2Pzrq5n26/c9dP/a58xjqPONkrfh+OonyfQZ WqBQ8eFTDU+e1XdIrhKy4xXHYaRfIp4SDA67HEwWAfNEEzJ3rynY7UkT6duyx6BGum5u I/UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681394190; x=1683986190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eos6FtVFfmj4vjZAg3YpgEZaX/+K/gklwxVdRbaWJ3g=; b=IVhwfxqp1L3D+C4wVHFF+lECsT6rK7z+izX/YnxeoCLPJAD69I5MFvytnJ5Ddx357b QN0DjgOVbg1EVsGP8T6jPRS1XYEL8uM8YMh8nu0VK2uRUhZgQUKXQyPE6LcgeMMdsxrQ 3/LrN3rZWhNluyAs1/dxcw+AgKZhgLSRhfko/3IXBLKYMLCXJ1JyA8MU2XtCUnVpuLQC 8nuMbrpQl0slX7zLdUTzVlILTFY56LIvmRsnJ5anAcfImbgr4qDesKXHS12uoeV2OyQC 9+J54OVYyMfpRsrrHET33ZBWGZq36lIUTImiUwpXBb1GLcOiC0/PgebqjTTA6PP12N/E WcbQ== X-Gm-Message-State: AAQBX9eVnUR0Pqpt8YZ5UyymQfin2vRFnjx929l/ie2mSN83Jh+ifFX+ byYNvOjm4DMKcCK2mYjHT4wJZHoOkHq85Y3dgv5xXw== X-Google-Smtp-Source: AKy350Y7hOZ50TyXoDficd6HOGGSmV9+Q3hwnaNEOGF+13yEh1joIr8iN2QrzT17EEjxkTJLDRdRyO49u8lawH4lM5g= X-Received: by 2002:a05:6000:1e02:b0:2f4:2e72:5bf7 with SMTP id bj2-20020a0560001e0200b002f42e725bf7mr2017521wrb.0.1681394189922; Thu, 13 Apr 2023 06:56:29 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-23-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 15:56:19 +0200 Message-ID: Subject: Re: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:20=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator > > > > Describes a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > [1] https://developer.arm.com/documentation/den0077/latest > > Signed-off-by: Jens Wiklander > > --- > > SUPPORT.md | 8 ++++++++ > > docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ > > 2 files changed, 23 insertions(+) > > > > +B Allow a guest to communicate via FF-A with Secure Partiti= ons > > +(SP), default false. > > + > > +Currently is only a small subset of the FF-A specification supported. = Just > > I am not a native English speaker but I think this sentence would better = be: > "Currently only a small subset of the FF-A specification is supported." I'll update it. > > Other parts look good to me, so: > > Reviewed-by: Henry Wang Thanks, Jens > > Kind regards, > Henry > From xen-devel-bounces@lists.xenproject.org Thu Apr 13 14:01:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 14:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520790.808796 (Exim 4.92) (envelope-from ) id 1pmxWB-0007ks-NR; Thu, 13 Apr 2023 14:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520790.808796; Thu, 13 Apr 2023 14:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxWB-0007kl-KI; Thu, 13 Apr 2023 14:01:43 +0000 Received: by outflank-mailman (input) for mailman id 520790; Thu, 13 Apr 2023 14:01:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxW9-0007kf-Uq for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 14:01:41 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b71d7150-da03-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 16:01:41 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id v14-20020a05600c470e00b003f06520825fso13663414wmo.0 for ; Thu, 13 Apr 2023 07:01:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b71d7150-da03-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681394500; x=1683986500; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9RXkq2jdJZj3WkYLgQrisz4aUlz+yyWAXOXNOUYobdE=; b=LEEpELcDajdGCgkadq4t6L3cbCoEejx02/O97elAwivac5XZNmE+VuD+2H87iY4O9O qEqb5D5V2vm3pyRpyCzmuCZqJvtdE5PoJclhIdyrz6xwPD9nu8xP+psQh99p541rP3YR dDLhSLH1LeexL8GMaCvLr+9qeqjbGcXCWpG4WQoAhKY4hzHotTI6ub+Z6tsYhHS5qUKN +SlpWawj45T/nRdbyDa7TZQCY3SJAfBoauSSUU8y4Myr8amrcotdOnSC0zl4t9z/sml2 T4/C1g4Om20NYR1Y2u4wf0wL2uXl7H1ovDAMJ8oPJ9mcsHZ+PvBxI3w9ITc5qiX00Xwg c7LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681394500; x=1683986500; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9RXkq2jdJZj3WkYLgQrisz4aUlz+yyWAXOXNOUYobdE=; b=Llvz/Qh0RLorYfMmGgcAjV3AMuKnChzWDYvUVqvUAT9Xe14pOBTgAKBQBSiP1HqOHG 8eORkfaBc3S+JRcvbxzqh6pJtJMdQ0v/KN9oClQw6L1fjINqWYdkFiuAyupAVGXZ0f1B fmwrDn4nip74dw3NvSQ77ZxhSq0B/GlRDsIW9YNKsBYylxMCQg4EYIpHXUjqXrYKtdnS mc3rtT7DSeGc5FrMTBMbWbyFJQxn0AbdJAAfAAHhJRs3X4sakWKbVohSwz7IRocTxYL1 KGqaa9wEh5Wmrokk4u4QJ53mWP7NPcj8ifu2KFS2HP9VKFS/D2+/jst5+vCRxEVRz+mz Hpfg== X-Gm-Message-State: AAQBX9c5+71/1ew69UfjOFajCAN9LhZEYz9eZh6d281gLRJwVos0ar2Q jMRHscH5HMWyGoslvnkwUZV/wiZsibauDm5X23gr8w== X-Google-Smtp-Source: AKy350aB9V4mekAsIeBZvwmR+xLOZvJFC1bjXrg3eO5nfWw270ujaWfAV4VD3WeYgovVitnWJ70YG2muxxklrD7YLzo= X-Received: by 2002:adf:df83:0:b0:2f4:1214:d5b4 with SMTP id z3-20020adfdf83000000b002f41214d5b4mr402098wrl.3.1681394500484; Thu, 13 Apr 2023 07:01:40 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-22-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 16:01:29 +0200 Message-ID: Subject: Re: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:24=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations > > > > Adds a comments with a list of unsupported FF-A interfaces and > > Typo: s/a comments/comments/ OK > > > limitations in the implemented FF-A interfaces. > > > > Signed-off-by: Jens Wiklander > > --- > > xen/arch/arm/tee/ffa.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > > index 0948cc636871..6424c222c885 100644 > > --- a/xen/arch/arm/tee/ffa.c > > +++ b/xen/arch/arm/tee/ffa.c > > @@ -13,6 +13,38 @@ > > * https://developer.arm.com/documentation/den0077/e > > * TEEC-1.0C: TEE Client API Specification version 1.0c available at > > * https://globalplatform.org/specs-library/tee-client-api-= specification/ > > + * > > + * Notes on the the current implementstion. > > Typo: s/implementstion/implementation/ OK > > > + * > > + * Unsupported FF-A interfaces: > > + * o FFA_MSG_POLL and FFA_MSG_SEND - deprecated in FF-A-1.1-REL0 > > + * o FFA_MEM_RETRIEVE_* - Used when sharing memory from an SP to a > > VM > > + * o FFA_MEM_DONATE_* and FFA_MEM_LEND_* - Used when tranferring > > ownership > > + * or access of a memory readion > > Typo "readion"? Maybe I am wrong but I cannot find this word in the spec. I'll fix it. > > With above typos corrected: > > Reviewed-by: Henry Wang Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 14:04:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 14:04:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520794.808806 (Exim 4.92) (envelope-from ) id 1pmxYy-0008JQ-4o; Thu, 13 Apr 2023 14:04:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520794.808806; Thu, 13 Apr 2023 14:04:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxYy-0008JJ-1E; Thu, 13 Apr 2023 14:04:36 +0000 Received: by outflank-mailman (input) for mailman id 520794; Thu, 13 Apr 2023 14:04:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxYw-0008JD-FR for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 14:04:34 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d31a31b-da04-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 16:04:32 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id he11-20020a05600c540b00b003ef6d684102so6459930wmb.3 for ; Thu, 13 Apr 2023 07:04:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d31a31b-da04-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681394672; x=1683986672; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tef11HamORpWrO4zt3gqCOD3tNCnJEUhR/3tGw75Byo=; b=En+0pKx3uy5Mnn+GGSiASx+oSfjuCd4RNPd7sIyf5eCKUisFJd7NH37cTKIeVen3WT S5Z4kjtpFFNIow6mgmfSDIVz0HDfRZ2cKqUWq0YJWiz3cVW1TLxT+Zu/V9VVU81jg7QY Fiio/k+0PpOGFgWpEptKpEoFZd6UCEa7yBzDtr60XhLxxjMmMTOChgg4H/erxSRPLbjb 7/DP21wuPHraUMGIecKmg66TZhCJPyTNC+gaUaNpZXZlqiwK8cqkP5DoT8XLOdO8lSRP PXq4B14kBLQN0jHojN6+I9DEvSK+scFbsH0IbV22vLJHWIs4hfVgIbkC/p76xbvu1YJ9 BcEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681394672; x=1683986672; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tef11HamORpWrO4zt3gqCOD3tNCnJEUhR/3tGw75Byo=; b=ku9Fatt2ThHwDTr0FNtLiO9vWY/dAFeRKuloPIP+yv9Oj5jW3Hz8nUh2AORkc/T0e1 JSLIQ3KxpMaNN73OvBctphjvshQ+hiz69Z6v3rIDy5lClEm5kU+CsXPzKVFqgU5J/5Sd UdiKh/Z4f6O2k3vGXgze+cIA3ZxolhQjoXtR2LuUgM6rqP0zFo6byVFuHGgDOsdGZ0p0 tUROYWp/uc5/+DJwfgIR6fnNx+2mOWrOpks2ga5BPj3vTAJlX/cAxAYFu9U4IeBrMPjy XQltpjyKpUbgTzPbMoS/JTjhNQw1/UK6o6ynKNOtM6TwaNFRN83Fs4SurjKPg0c8EaJe Rn4Q== X-Gm-Message-State: AAQBX9eHaRUuXw1ojw+L1VQqWBVNz+U9CXkUaI9rgtjfzdD6NxF/mDX0 PB6qhFZVSeBoYKf86/lXpSCvtQX36GkVgkJ733W2Kw== X-Google-Smtp-Source: AKy350b/N/foTgSiIYTBBi1PSq0BNKihoARgBMwt1YyHQzgotCZCq77/mpuOt3p2AsNvDnotLSxVCyZZRJXRpgHx12U= X-Received: by 2002:adf:df83:0:b0:2f4:1214:d5b4 with SMTP id z3-20020adfdf83000000b002f41214d5b4mr404765wrl.3.1681394671929; Thu, 13 Apr 2023 07:04:31 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-15-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 16:04:21 +0200 Message-ID: Subject: Re: [XEN PATCH v8 14/22] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Michal Orzel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:31=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 14/22] xen/arm: move regpair_to_uint64() and > > uint64_to_regpair() to regs.h > > > > Moves the two helper functions regpair_to_uint64() and > > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm > > specific regs.h. This enables reuse of these functions in the FF-A > > mediator in a subsequent patch. > > > > Signed-off-by: Jens Wiklander > > Reviewed-by: Michal Orzel > > Reviewed-by: Bertrand Marquis > > Reviewed-by: Henry Wang I'll add it. Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Thu Apr 13 14:06:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 14:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520797.808816 (Exim 4.92) (envelope-from ) id 1pmxaH-0000S6-Fz; Thu, 13 Apr 2023 14:05:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520797.808816; Thu, 13 Apr 2023 14:05:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxaH-0000Rz-Cz; Thu, 13 Apr 2023 14:05:57 +0000 Received: by outflank-mailman (input) for mailman id 520797; Thu, 13 Apr 2023 14:05:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxaG-0000Rt-Jg for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 14:05:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0c::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e115510-da04-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 16:05:55 +0200 (CEST) Received: from DUZP191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::16) by GV2PR08MB7932.eurprd08.prod.outlook.com (2603:10a6:150:7f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 14:05:52 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4f9:cafe::ef) by DUZP191CA0006.outlook.office365.com (2603:10a6:10:4f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 14:05:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Thu, 13 Apr 2023 14:05:52 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Thu, 13 Apr 2023 14:05:52 +0000 Received: from 5bcdf09bd711.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 26D03264-6603-41F1-A6C6-DE02BF857EC2.1; Thu, 13 Apr 2023 14:05:45 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5bcdf09bd711.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 14:05:45 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM9PR08MB6065.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 14:05:34 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 14:05:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e115510-da04-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ntKU0qB25tzCe84Gkqv7uUIcg8aNldac8nLZ9xZICc=; b=hkaD3G9Oykzo1gRrBqfG2zy+phaZeCD5vO1exVMLeLSEgqjS+XQlDjIjDHvKvYUs0sF+os76DGWcnTSDPFkx9nKl6jtrhLKUcUzrkD3EoJ8TndmavVSxTg8YyynJ91MIJsJ18MeATSoqHF6AAZemjaTVXBBO5Jy36sj0V+a2x0Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b0a1d0c3ab2b01fb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gaf5h/m0A+LxqIE9Q5PBFYjuEuacUNRQUXg2p0HjoBptYKD9sAvIKNEZM1h3l9HLtvdlrka4hhIv0/P3hWG2PEygQWR/WVvKV/7mm95Od78JxCd5IbQe73tO7Xe3xjdcMbefYAjk5KAmQUNFmjRxn263iEvebsm16QENA8f+0V9N/XxagsHzS6jE8OBW9IDxAXyuOoTmpKKQAdiqrgksqVae7rPEqkwaYNpMK43SszCjgqTAaGkTEZOXvfyogpJq27D55yzx/NppI/mIhLFpZ2qrI4ljRQrzPu/6TMHc6n5uXVRVb9NrI3Cop9Lo7HH7IZdZ0OyOYmLRN4pPzoBQ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ntKU0qB25tzCe84Gkqv7uUIcg8aNldac8nLZ9xZICc=; b=RgT/ACmN4aEFk0yCX/ydcatyZoyjjiJ/+EEx07dX/8/BCwyVFYjF3Xc59bgohYgjKZ69XTItp/oX1XvuaY+nkDT8xj2Ar7EZAKn/JD1ujBdjxMUTG6neg3euohZJP9sS4JGQNYRkgkEcoKz5r+vNGIO2IJeb0C8hq0d+PVBs3vDUwBLHBsTX3V22YLdlDr1/FDrnE2VNVDQaua4hHvspvyoPCAv5+Bx6mBfrs+FowghDIL+nGO/wxlN9IftiKdJcZBQJ60vFAzMZijncYHJtkIDoTbTneFAFP8kRlV2f6Z7IGAziLbor0Dk9fCb7k1P3ZOCeyqOtkI5pDmpSvNvbJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ntKU0qB25tzCe84Gkqv7uUIcg8aNldac8nLZ9xZICc=; b=hkaD3G9Oykzo1gRrBqfG2zy+phaZeCD5vO1exVMLeLSEgqjS+XQlDjIjDHvKvYUs0sF+os76DGWcnTSDPFkx9nKl6jtrhLKUcUzrkD3EoJ8TndmavVSxTg8YyynJ91MIJsJ18MeATSoqHF6AAZemjaTVXBBO5Jy36sj0V+a2x0Y= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Topic: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Index: AQHZbSQ9GJqCFHqaX0uCiT+EC9U7s68pNK+AgAAHnICAAAGIAIAACdqA Date: Thu, 13 Apr 2023 14:05:30 +0000 Message-ID: <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM9PR08MB6065:EE_|DBAEUR03FT018:EE_|GV2PR08MB7932:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b15dd7f-6a45-4d9f-ef28-08db3c283124 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RgSznKWfxl8m3Ahu1CbR/Hfg6/lvGHsldj3WMY7SsCvKIe5969I2Gj7jfsRrE56RtPof6+DuMXHzB4CCCZhAtQYQx5iL74BkeRNWNZJklmMedis0xB2E1CZ9o4fwWXbpISfcQzkmvpgAnEskXViozI4EPBKyTWe9Hde2TYX337QBputjqbbGbjthmvidf8XqwoA+67Sog92t3oAZgmHceUEb5DZCJfK4buNKuHc0CBEpWqeByc8MRD1PyuoaLOYsQChdik2tMZXQoTThhJpgYNL8rqaVv88jFKk6vx+i+utOuY8Nr6UVaRh6kZXrObAf4g2VAp4Hew5a+8IOE7AlOvdJuVETqH6PPhiaUjyohBf5ZEgCPmecYI5F3FTaCd6+8t4v24KpFLEIynXL3z1FvLPWcifWDnK9CluQsvv0usCPjvWWtv2eR9HeVq8+Pue8VU9Ut7Znh3SOQ6nscYxcCwmDQt4QiWWgfeBn3u8uhYZ1X3DWVba6AONLeXbx9wze6kZV19qYTr4WXQj9EPWQocWyUKAVPIiwCa28hzp8LijlLsy1Rvb3h5nrIj4SkHbXori8LxdEp9HUfNojTGfFbSfXh8IaBqx8kjZVT3p5Uf50XJE1dzh2SqCXxKYf08YLrP6jyaaztDceIpHcKSX0uw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(451199021)(5660300002)(41300700001)(33656002)(122000001)(38100700002)(36756003)(2906002)(38070700005)(8676002)(86362001)(4326008)(6916009)(66556008)(8936002)(66446008)(66946007)(64756008)(66476007)(316002)(91956017)(2616005)(83380400001)(76116006)(6506007)(54906003)(6512007)(26005)(53546011)(186003)(478600001)(6486002)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8C2C74ED4696DC4795D6E4B68AB82C1F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6065 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3d14a642-65c9-4dd4-0ac0-08db3c2823df X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U4H9aoFTTh8dL3+X2PYAz7MwzphRRA4OkVBNNru9NFDjvKl7vgaYlOzRD67HafqYX28w+q7wQoY1jG/TJeTAt9tiwGj159q7djXl6Up6xV3xWg9RzG2djIoMvGWkqGPIGr2D8FaIlky2OdEibWqSxpYhg9pVZunrbIjxZpbSWdskbVsGONsA7DEz7rCKGmUjv7JCPJwYg9WvuJ9phuPMuxnlD722lQPKdNdpuo3oK3u+2jBUxVm16t0SzAgeepHSuXGYenpTmZaK/fGF53HhEAYPO/9+z5pKJcZVbllaYbsxlNXl+66lFqwp71yEm5TEf0V6ODZlBdYyauYzR7GTRuy/QVfZSA5QHcAinDXsVA9juPh+HQ0Fc/GYD0xm4rQLvgpH+6hx5Cz8/UyYfSfv8OoE1v2gbu90LC7O60zwIijl95l0nnRJI8FEqH3M+Ju2HHbwMukkTwbkE+rC4dGcWWKPW+n0cs1O3pCkVtDf7mDtoYtgMFf/aUG8NGLmtPhzUuLx1cMh//fS8W0qhMuuInsvb38w6EW4wtNxTBetU3V6/Pw8/S2Pma3a+ifBCxrgu5GkaV2+YZc2pf+JFPvO3DlQ/oPObroYySuhwHtg2Ags5G/ZlUlEnicOsZbJKtu5CcfU1QioOKPmNyHh8ZyRR/ysDs/L6IZWAoOWRl7ymxq9SgCjVN2RzPXsqvuwp7BvxM026VjzPhHC19Iep4u1bA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(86362001)(478600001)(54906003)(6486002)(36860700001)(47076005)(36756003)(2616005)(33656002)(336012)(83380400001)(26005)(40480700001)(186003)(6512007)(6506007)(53546011)(40460700003)(82740400003)(82310400005)(81166007)(316002)(356005)(4326008)(2906002)(70206006)(70586007)(8676002)(8936002)(5660300002)(6862004)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 14:05:52.3763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b15dd7f-6a45-4d9f-ef28-08db3c283124 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB7932 DQoNCj4gT24gMTMgQXByIDIwMjMsIGF0IDE0OjMwLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMTMvMDQvMjAyMyAxNDoyNCwgTHVjYSBGYW5j ZWxsdSB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPj4+PiAgQEAg LTU5NCw2ICs1OTcsNyBAQCBpbnQgYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKHN0cnVjdCB4 ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiAqY29uZmlnKQ0KPj4+PiAgICAgIHVuc2lnbmVkIGludCBt YXhfdmNwdXM7DQo+Pj4+ICAgICAgdW5zaWduZWQgaW50IGZsYWdzX3JlcXVpcmVkID0gKFhFTl9E T01DVExfQ0RGX2h2bSB8IFhFTl9ET01DVExfQ0RGX2hhcCk7DQo+Pj4+ICAgICAgdW5zaWduZWQg aW50IGZsYWdzX29wdGlvbmFsID0gKFhFTl9ET01DVExfQ0RGX2lvbW11IHwgWEVOX0RPTUNUTF9D REZfdnBtdSk7DQo+Pj4+ICsgICAgdW5zaWduZWQgaW50IHN2ZV92bF9iaXRzID0gc3ZlX2RlY29k ZV92bChjb25maWctPmFyY2guc3ZlX3ZsKTsNCj4+Pj4gICAgICAgIGlmICggKGNvbmZpZy0+Zmxh Z3MgJiB+ZmxhZ3Nfb3B0aW9uYWwpICE9IGZsYWdzX3JlcXVpcmVkICkNCj4+Pj4gICAgICB7DQo+ Pj4+IEBAIC02MDIsNiArNjA2LDI2IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWco c3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+Pj4+ICAgICAgICAgIHJl dHVybiAtRUlOVkFMOw0KPj4+PiAgICAgIH0NCj4+Pj4gICsgICAgLyogQ2hlY2sgZmVhdHVyZSBm bGFncyAqLw0KPj4+PiArICAgIGlmICggc3ZlX3ZsX2JpdHMgPiAwICkNCj4+Pj4gKyAgICB7DQo+ Pj4+ICsgICAgICAgIHVuc2lnbmVkIGludCB6Y3JfbWF4X2JpdHMgPSBnZXRfc3lzX3ZsX2xlbigp Ow0KPj4+PiArDQo+Pj4+ICsgICAgICAgIGlmICggIXpjcl9tYXhfYml0cyApDQo+Pj4+ICsgICAg ICAgIHsNCj4+Pj4gKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0lORk8sICJTVkUgaXMgdW5z dXBwb3J0ZWQgb24gdGhpcyBtYWNoaW5lLlxuIik7DQo+Pj4+ICsgICAgICAgICAgICByZXR1cm4g LUVJTlZBTDsNCj4+Pj4gKyAgICAgICAgfQ0KPj4+PiArDQo+Pj4+ICsgICAgICAgIGlmICggc3Zl X3ZsX2JpdHMgPiB6Y3JfbWF4X2JpdHMgKQ0KPj4+PiArICAgICAgICB7DQo+Pj4+ICsgICAgICAg ICAgICBkcHJpbnRrKFhFTkxPR19JTkZPLA0KPj4+PiArICAgICAgICAgICAgICAgICAgICAiUmVx dWVzdGVkIFNWRSB2ZWN0b3IgbGVuZ3RoICgldSkgPiBzdXBwb3J0ZWQgbGVuZ3RoICgldSlcbiIs DQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgIHN2ZV92bF9iaXRzLCB6Y3JfbWF4X2JpdHMpOw0K Pj4+PiArICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+Pj4+ICsgICAgICAgIH0NCj4+PiAN Cj4+PiBJcyBTVkUgc3VwcG9ydGVkIGZvciAzMi1iaXQgZ3Vlc3Q/IElmIG5vdCwgdGhlbiB5b3Ug c2hvdWxkIGhhZCBhIGNoZWNrIGhlcmUgdG8gcHJldmVudCB0aGUgY3JlYXRpb24gb2YgdGhlIGRv bWFpbiBpZiBzdmVfdmxfYml0cyBpcyBzZXQuDQo+PiBObyBTVkUgaXMgbm90IHN1cHBvcnRlZCBm b3IgMzIgYml0IGd1ZXN0cywgaGVyZSBJIHRoaW5rIHdlIHdpbGwgZ2V0IOKAnFNWRSBpcyB1bnN1 cHBvcnRlZCBvbiB0aGlzIG1hY2hpbmXigJ0gYmVjYXVzZSBnZXRfc3lzX3ZsX2xlbigpIHdpbGwg cmV0dXJuIDAuDQo+IA0KPiBGcm9tIG15IHVuZGVyc3RhbmRpbmcsIGdldF9zeXNfdmxfbGVuKCkg d2lsbCByZXR1cm4gdGhlIGxlbiBzdXBwb3J0ZWQgYnkgdGhlIGhvc3RzLiBTbyBpZiB5b3UgcnVu IGEgMzItYml0IGd1ZXN0IG9uIHRvcCBvZiBhIDY0LWJpdCBob3N0cywgdGhlbiBJIGJlbGlldmUg Z2V0X3N5c192bF9sZW4oKSB3aWxsIGJlIG5vbi16ZXJvLg0KDQpZZXMgeW91IGFyZSByaWdodCwg SSByZWFsaXNlIHRoYXQgSSBuZWVkIHRoZSBkb21haW4gdHlwZSBpbmZvcm1hdGlvbiBhbmQgSSBj YW7igJl0IGhhdmUgaXQgaW4gYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnLCBob3dldmVyIHRo ZXkgbWlnaHQgaGF2ZSBzZW5zZSB0aGVyZSwgYW5kIEkgY2FuIGRvIGEgY2hlY2sNCmxpa2UgdGhp cyBhZnRlcndhcmRzOg0KDQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5j IGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQppbmRleCBjMWYwZDFkNzg0MzEuLmNlMTIz NWMyNTc2OSAxMDA2NDQNCi0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KKysrIGIv eGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQpAQCAtMzY5NCw2ICszNjk0LDEyIEBAIHN0YXRp YyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IGtl cm5lbF9pbmZvICpraW5mbykNCiAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KICAgICB9DQogDQor ICAgIGlmICggZC0+YXJjaC5zdmVfdmwgJiYgKGtpbmZvLT50eXBlID09IERPTUFJTl8zMkJJVCkg KQ0KKyAgICB7DQorICAgICAgICBwcmludGsoIlNWRSBpcyBub3QgYXZhaWxhYmxlIGZvciAzMi1i aXQgZG9tYWluXG4iKTsNCisgICAgICAgIHJldHVybiAtRUlOVkFMOw0KKyAgICB9DQorDQogICAg IGlmICggaXNfNjRiaXRfZG9tYWluKGQpICkNCiAgICAgICAgIHZjcHVfc3dpdGNoX3RvX2FhcmNo NjRfbW9kZSh2KTsNCg0KV291bGQgaXQgYmUgb2sgZm9yIHlvdT8NCg0KDQo+IA0KPj4+IENhbiB3 ZSBtb3ZlIHRoaXMgc29tZXdoZXJlIGVsc2UgdG8gYXZvaWQgYWRkaW5nIGV4dHJhIHBhZGRpbmc/ IEFsc28gc2hvdWxkbid0IHRoaXMgYmUgcHJvdGVjdGVkIHdpdGggI2lmZGVmIENPTkZJR19BUk1f NjQgdG8gbWFrZSBjbGVhciB0aGlzIGlzIG5vdCBzdXBwb3J0ZWQgb24gWGVuIDMyLWJpdD8NCj4+ IFllcywgSeKAmWxsIG1vdmUgaXQgYW5kIHByb3RlY3Qgd2l0aCBDT05GSUdfQVJNXzY0LCBpcyBp dCBvayBmb3IgeW91IGlmIEkgbW92ZSBpdCBhZnRlcjoNCj4+IC8qIE1vbml0b3Igb3B0aW9ucyAq Lw0KPj4gc3RydWN0IHsNCj4+ICAgICB1aW50OF90IHByaXZpbGVnZWRfY2FsbF9lbmFibGVkIDog MTsNCj4+IH0gbW9uaXRvcjsNCj4gDQo+IFBsZWFzZSBjaGVjayB0aGUgcGFkZGluZyB3aXRoICJw YWhvbGUiLiBJZiBwb3NzaWJsZSwgaXQgd291bGQgYmUgYmV0dGVyIHRvIHJlLXVzZSBhbiBleGlz dGluZyBvbmUuDQoNCk9rIEnigJlsbCB0cnkgdG8gdXNlIHRoZSB0b29sDQoNCj4gDQo+IENoZWVy cywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Apr 13 14:19:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 14:19:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520807.808827 (Exim 4.92) (envelope-from ) id 1pmxn5-00024B-QG; Thu, 13 Apr 2023 14:19:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520807.808827; Thu, 13 Apr 2023 14:19:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxn5-000244-LJ; Thu, 13 Apr 2023 14:19:11 +0000 Received: by outflank-mailman (input) for mailman id 520807; Thu, 13 Apr 2023 14:19:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxn4-00023y-PM for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 14:19:10 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27657f9d-da06-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 16:19:08 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id e7so4259531wrc.12 for ; Thu, 13 Apr 2023 07:19:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27657f9d-da06-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681395548; x=1683987548; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jnxv1d+DPOzXFsYGT8fPh7cpyORkn3S4h2c0JMmojyY=; b=i2RrQtWy/A7bUtrdoyr5sTSUySe67dRrSsliXVPVJc/P2sLIqZjAucxTPd1GrskY7t AKOya4TNVorwCxcjKxsY3bDh5J3cZPlS7GdSC8V0LlnAP5AqLO2SHv+kvdEZ4X55Jdlp wcRhIYABuH1Q9Ug1rftjC8JUWTAm9sDAHI62WrU/T7SlBySVbacE/zxmlz7qpT5H6LM0 eAQ3dVtXMC509lNLWU7FZoyUAvluUs2A9YB1yNWXJzww3Ca0e10nPos1ztyOrYxnR3cO OFC7oNXJHLaJvvEgTVlKZ0rQ0tzu7wAWAFG5VNZSXQ4mneGgrt7A0oDxJFJNG/EocKGJ wZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681395548; x=1683987548; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jnxv1d+DPOzXFsYGT8fPh7cpyORkn3S4h2c0JMmojyY=; b=jmPFvFi/Z8GmHbaXrMiqltcuIiHmqtgV0sTItBS7bz4YPKS72AcuuQ2jB/zrqQj0/Y F+EGei1ouZEpoq6jw7mP/gPrmCVCTi6PtS4L/At5HdAsRXfgd2ZD8GJ0Iz9IkaVhkkij lXQENRtrcMIZeUSOx5Z0BVR6eQu1BifNE25VyGrgSsIHlLULh5vSUyTVY5FsB2pEP1X0 nMI2I5vzp1qq3XepfBDNRTQNwtObIt9+P97bAHl/mOeCkkfBmPbAvoHju61oVCGCPorS KenqRxhvQNI6vr7S9SIzOeR8VhhP04G8vh9lKWuAxSSXyyKLjE1R0mNKc6HcTKRSt5gX IhKQ== X-Gm-Message-State: AAQBX9fSvJIrHc2gBqQo/+nuMHgP3Z9UuYR2hB/ojMRKTAP/RulE5V3t wntVGlHhSDjdoitxrmiueUdMmUzUtRPhr06FQbjpUg== X-Google-Smtp-Source: AKy350adar8VeKRFQ5PBoxwjPmgqVh84AAZAOPLUj5qBijC4tUca+gUdapTJ2ICBQ76nii1wCwNo/0k9Tk968+K4MJA= X-Received: by 2002:a5d:6881:0:b0:2f5:6a2f:660f with SMTP id h1-20020a5d6881000000b002f56a2f660fmr466484wru.3.1681395547982; Thu, 13 Apr 2023 07:19:07 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-16-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 13 Apr 2023 16:18:56 +0200 Message-ID: Subject: Re: [XEN PATCH v8 15/22] xen/arm: ffa: add defines for sharing memory To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:47=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 15/22] xen/arm: ffa: add defines for sharing mem= ory > > > > Adds defines needed for sharing using the function FFA_MEM_SHARE and > > friends. > > Same as my comments in previous patches, I would suggest to also mention > the references in commit message. OK, I'll add something. > > > > > Signed-off-by: Jens Wiklander > > --- > > xen/arch/arm/tee/ffa.c | 60 > > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > > > + * FF-A doesn't have any direct requirments on GlobalPlatform or vice > > Typo: s/requirements/requirements/ OK > > > + * versa, but an implementation can very well use FF-A in order to pro= vide > > + * a GlobalPlatform interface on top. > > + * > > + * Global Platform specification for TEE requires that any TEE > > + * implementation should allow to share buffers with size of at least > > + * 512KB, defined in TEEC-1.0C page 24, Table 4-1, > > + * TEEC_CONFIG_SHAREDMEM_MAX_SIZE. > > + * Due to align issue mentioned above, we need to increase this > > s/align issue/alignment issue/ ? Yes, I'll make it "the alignment issue". > > > + * value with one. > > + */ > > +#define FFA_MAX_SHM_PAGE_COUNT (SZ_512K / FFA_PAGE_SIZE + 1) > > + > > +/* > > + * Limits the number of shared buffers that guest can have at once. Th= is > > + * is to prevent case, when guests tricks XEN into exhausting its own > > Typo: s/tricks/trick/ OK > > > + * memory by allocating many small buffers. This value has been chosen > > + * arbitrary. > > Typo: s/ arbitrary/arbitrarily/ OK > > > + */ > > +#define FFA_MAX_SHM_COUNT 32 > > + > > +/* FF-A-1.1-REL0 section 10.9.2 Memory region handle, page 167 */ > > +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) > > +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL > > + > > +/* > > + * Memory attributes: Normal memory, Write-Back cacheable, Inner > > shareable > > + * Defined in FF-A-1.1-REL0 Table 10.18 at page 175. > > + */ > > +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU > > +/* > > + * Memory access permissions: Read-write > > + * Defined in FF-A-1.1-REL0 Table 10.15 at page 168. > > + */ > > +#define FFA_MEM_ACC_RW 0x2U > > + > > +/* FF-A-1.1-REL0 section 10.11.4 Flags usage, page 184-187 */ > > +/* Clear memory before mapping in receiver */ > > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > > +/* Relayer may time slice this operation */ > > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > > +/* Clear memory after receiver relinquishes it */ > > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > > +/* Share memory transaction */ > > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) > > + > > I confirm the values introduced in this patch are consistent with in-code > comments on top of them. Thanks for the pointer :) :-) > > With the typos corrected: > Reviewed-by: Henry Wang Great. Thanks, Jens > > Kind regards, > Henry > > > > /* > > * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: > > * BIT(31): Framework or partition message > > -- > > 2.34.1 > > > From xen-devel-bounces@lists.xenproject.org Thu Apr 13 14:27:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 14:27:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520813.808836 (Exim 4.92) (envelope-from ) id 1pmxuZ-0003X0-G2; Thu, 13 Apr 2023 14:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520813.808836; Thu, 13 Apr 2023 14:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxuZ-0003Wt-DN; Thu, 13 Apr 2023 14:26:55 +0000 Received: by outflank-mailman (input) for mailman id 520813; Thu, 13 Apr 2023 14:26:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxuY-0003Wj-FR; Thu, 13 Apr 2023 14:26:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxuY-0004eN-8y; Thu, 13 Apr 2023 14:26:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmxuX-0002Vs-QR; Thu, 13 Apr 2023 14:26:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmxuX-0000zi-Pv; Thu, 13 Apr 2023 14:26:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=00Ml6wI2+YZbNfEYdh0VrbG/4F2r7tGSkmGiUEQt0+E=; b=ukvKb7kWvVFzhlm7aYCSnwSo28 weLkqLOTKdmJ8Yt5s/r6MRp9d2Ij/quRMVurfk4rMdLtdLxy0RayyBCFG2FoJI2HUkOuBusdTNRqZ YakWDaerTDqBl/Hll/1QiG1uS4tUeSZJ3MrwReA5HXHJi3aISDjtXJIniHnJE70SD8uw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180225: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f X-Osstest-Versions-That: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f From: osstest service owner Date: Thu, 13 Apr 2023 14:26:53 +0000 flight 180225 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180225/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail in 180211 pass in 180225 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180211 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 180211 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 180211 like 180206 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180211 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180211 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180211 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180211 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180211 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180211 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180211 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180211 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f baseline version: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f Last test of basis 180225 2023-04-13 01:53:23 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Apr 13 14:36:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 14:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520821.808846 (Exim 4.92) (envelope-from ) id 1pmy3W-00050j-CT; Thu, 13 Apr 2023 14:36:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520821.808846; Thu, 13 Apr 2023 14:36:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmy3W-00050c-9m; Thu, 13 Apr 2023 14:36:10 +0000 Received: by outflank-mailman (input) for mailman id 520821; Thu, 13 Apr 2023 14:36:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmy3V-00050R-5D for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 14:36:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20617.outbound.protection.outlook.com [2a01:111:f400:7e1b::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 839e0870-da08-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 16:36:02 +0200 (CEST) Received: from AS9PR0301CA0012.eurprd03.prod.outlook.com (2603:10a6:20b:468::25) by VE1PR08MB5743.eurprd08.prod.outlook.com (2603:10a6:800:1b2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 14:35:57 +0000 Received: from AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:468:cafe::a) by AS9PR0301CA0012.outlook.office365.com (2603:10a6:20b:468::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 14:35:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT016.mail.protection.outlook.com (100.127.140.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 14:35:57 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 13 Apr 2023 14:35:57 +0000 Received: from 9618f815e1ca.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 84741A9D-6DB9-48FF-9220-4C008AABF99B.1; Thu, 13 Apr 2023 14:35:56 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9618f815e1ca.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 14:35:56 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV1PR08MB8237.eurprd08.prod.outlook.com (2603:10a6:150:5d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 14:35:46 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 14:35:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839e0870-da08-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lXArFAPv3OLfJYe5yu5owMpv8nCKDOluVtSJurcjWrs=; b=y3qhKWMnPspyoGW07gH6EpH1dn5b7QxSL0MQTXJy3S3GXuFYRsXfAbRUJ/tS/3wFqJVs2Sf/taRq25/h/97ipV7CACX9lHu9OV9diIYCPvLp66tb1YQufu4z8uW724B6snhO7gY0G5hm4ZGSKhJu7C5MQuRujtAKyv9Rf6G+t2A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d4a1fb7c697ffd9b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNX86LFJq/Y116OYwhQ4i3eeZCPtd1ERpd12kq3u7VTytPexCK7mlfPabjTxFwCB3sO10EQT/FJKoGWQ9+xK7GDcMzh6KUiXZ6OXnV+kvdB3H0a5PP0C1+9YtswwqgDA3A1oDN0sZBj2Su9pnursseFm19Mvf5GAO4uFxbpy9TyMYQblEJOubcJHt51AGE/DyRUHPKO56YAC0OuuzSybds09YssTI8yXvytKBjpMLYhL65rjyOr8U6ZPL1Z8WHgcjxGHRDXjXrbYn/NW0lDj1LruWWX7uBG//BIa9Q1+maodmFtT4z4XXWVymk6DB5ny/dgtOrUMya3wDBauDaDHrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lXArFAPv3OLfJYe5yu5owMpv8nCKDOluVtSJurcjWrs=; b=IPgl0oMCmOrux1K8jv6or0ejTQ3v9mAs7o1aymsxttX487SEvHrzfM0Q4NzlQ24n8OTwsCc/b48S0hYvvM3HZVlsfc42usYfdZtRBlYnzCw1gQ6eCirca4iUIVN/MK6oykv+d0GXlszuA9NQ2XeWih4IyuddrqlceN3g/EaohU7wVz0X9zeNjHS8OIIly9IhjDx4v6MuV3ESafFS8A4yUYt0PebPBjOkxKILX74TyAysMzbkEItwRLAmO7Acj6Q4zd3K7rId2I/D4pnsLcYcQAhe+LreQLJ0teZsn5lenq9Uywa9kC/3R6ItyKJ5o65SmjKDVxhI9flR0XK7KxqLsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lXArFAPv3OLfJYe5yu5owMpv8nCKDOluVtSJurcjWrs=; b=y3qhKWMnPspyoGW07gH6EpH1dn5b7QxSL0MQTXJy3S3GXuFYRsXfAbRUJ/tS/3wFqJVs2Sf/taRq25/h/97ipV7CACX9lHu9OV9diIYCPvLp66tb1YQufu4z8uW724B6snhO7gY0G5hm4ZGSKhJu7C5MQuRujtAKyv9Rf6G+t2A= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v5 05/12] arm/sve: save/restore SVE context switch Thread-Topic: [PATCH v5 05/12] arm/sve: save/restore SVE context switch Thread-Index: AQHZbSQ26+FC1T02dEGoq+zimN/6Ra8pOLQAgAAXa4A= Date: Thu, 13 Apr 2023 14:35:44 +0000 Message-ID: <6DDCEF6B-F07B-44EA-83D0-33BED5EAC506@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-6-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV1PR08MB8237:EE_|AM7EUR03FT016:EE_|VE1PR08MB5743:EE_ X-MS-Office365-Filtering-Correlation-Id: c4bf5996-285a-43e7-dff4-08db3c2c6515 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fJyx/6sD+R+yHyMCsV1Hqojs0hfZyFtmoVLVyWnEOeytS9OdHCwPye1rbWvcj1b+JFEQldrdqcKmQlFXv+1wWxNhZXlcoyRCJ7w8byCdi6DBbQgByZO9OokHIDURkcvf4QOeDvrWnVzsG/XV+FXA4pCHiQRzEjNnKP5OYhNr4sp2FpO0jbcsEUeqsuQUmSfDuWiWpC/7Z1wyf2eluo6Im4ysLs54Xed3psKlc5kY1DcNmBQ2DZCPzdJq16NDsXLJX06OBATlxy9IQ5b0G8p/JnFHYS2Kpppv/zmAQH5EdIPUUGS7njXSxmx7e9rks1NsTK98wtr3wTeXZ6wWL0EZpTGXsdMbUrR/PVdx+Yj1RfPph4vUfUpmU96R/CeKCye0+EyZGV9gkF8gcKGZqCHlOyWo2dGUtOJJALyDEwEfvTCNXiklHmUt+GgnIN7tMifcrzlPIWDzxG15T3bb7/Lj/a2Itlu3a9M3LTyeJ7nCQM6kDzgG39F0LUgqCJK8iz0YLOXNK5y/yLw3TCl3j0wsSO52TT3QNzbYLPWZ1ZX4pnKBn2At57Uv4nXu4hYdu0+vi0l3lCZrIPWzQ8eWmFiPd28LstlqDJ3+mE7DvIzW1cV+NB03qRVwkt8i/F2KNlXtsbh7vUB4YDAoV5rdyMl6uQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199021)(316002)(8676002)(66446008)(4326008)(66556008)(66476007)(66946007)(71200400001)(54906003)(64756008)(6916009)(478600001)(76116006)(41300700001)(91956017)(33656002)(36756003)(86362001)(2616005)(6512007)(6506007)(26005)(6486002)(53546011)(83380400001)(2906002)(5660300002)(8936002)(38070700005)(38100700002)(122000001)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8237 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9dc1d2e4-e8c7-4075-7d0b-08db3c2c5d4a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wkVTt8HInfGx0dQQH5b6DlYJ9pPxtwD9wboMeCFLs5T9vSQeBFrz4iyGf5kh4pIt7jXgt5xrn7g0WWL35SDu1LZesZI88Zv84kmJMq/Tj7W4jx/kmqCrAndsoMCbo7INvbbiyQSOr9vQaGeX8nn1wFfpeB/Im0H7rdYxTCMfyzB/DX2HQZ2VGdvEc83pqAN5YZu0ttU6hCm/bPjqc46iMiXoaQxBzw0Ye4HLxj0OpWPOqki+NQkkebCc2D9UVPjLHzSNuK3LgrGGNw6QWJTK0dFx8SkwWQKX1vOYsI8b/w3S3eiLy9JR9lapb8mTya/lxNt2Agxil+/qdJxngkSf9vBA5f92SpQRoe97RrsAwIFgs2tvPsoGrt4sfFiPPGdX0rl0CTKlyUyl92Z3oe6dGKeVnEj29eAbODOnP7IGQrXeWlYBIIcPGOXDOZZFPNdISvuXlY5GkPXGU7m/gP/JpHTw/30NKZIRDOMnI0d8t19gqyz5vffgDqBeD8IldRyTikqH5F8nJo5RDkEfUfx35C/e7Dd/wHXMjtsAQmsls8HcMAi9UNT+ZWLGyrMmPkzazcIkw/aXGdK/o6ggSB+qDmMx5KFF/moL4AUI18OIh5qPA8jfOFZ9L+iZkzMkgZ2MC5anFATLJvPpWBo9sR9lcfJpni30Dg0SfBvUlGSuCXoIe3dRDiDt7WtB87ewZ9tReRbVg36IGIIipxch5g2kEg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39850400004)(451199021)(36840700001)(46966006)(40470700004)(2906002)(6862004)(8676002)(70586007)(70206006)(8936002)(5660300002)(478600001)(41300700001)(33656002)(40460700003)(316002)(40480700001)(83380400001)(82740400003)(336012)(36756003)(54906003)(4326008)(186003)(86362001)(6486002)(6506007)(26005)(81166007)(53546011)(6512007)(2616005)(36860700001)(82310400005)(356005)(107886003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 14:35:57.4435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4bf5996-285a-43e7-dff4-08db3c2c6515 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5743 DQoNCj4gT24gMTMgQXByIDIwMjMsIGF0IDE0OjExLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMTIvMDQvMjAyMyAxMDo0OSwgTHVjYSBGYW5j ZWxsdSB3cm90ZToNCj4+IFNhdmUvcmVzdG9yZSBjb250ZXh0IHN3aXRjaCBmb3IgU1ZFLCBhbGxv Y2F0ZSBtZW1vcnkgdG8gY29udGFpbg0KPj4gdGhlIFowLTMxIHJlZ2lzdGVycyB3aG9zZSBsZW5n dGggaXMgbWF4aW11bSAyMDQ4IGJpdHMgZWFjaCBhbmQNCj4+IEZGUiB3aG8gY2FuIGJlIG1heGlt dW0gMjU2IGJpdHMsIHRoZSBhbGxvY2F0ZWQgbWVtb3J5IGRlcGVuZHMgb24NCj4+IGhvdyBtYW55 IGJpdHMgaXMgdGhlIHZlY3RvciBsZW5ndGggZm9yIHRoZSBkb21haW4gYW5kIGhvdyBtYW55IGJp dHMNCj4+IGFyZSBzdXBwb3J0ZWQgYnkgdGhlIHBsYXRmb3JtLg0KPj4gU2F2ZSBQMC0xNSB3aG9z ZSBsZW5ndGggaXMgbWF4aW11bSAyNTYgYml0cyBlYWNoLCBpbiB0aGlzIGNhc2UgdGhlDQo+PiBt ZW1vcnkgdXNlZCBpcyBmcm9tIHRoZSBmcHJlZ3MgZmllbGQgaW4gc3RydWN0IHZmcF9zdGF0ZSwN Cj4+IGJlY2F1c2UgVjAtMzEgYXJlIHBhcnQgb2YgWjAtMzEgYW5kIHRoaXMgc3BhY2Ugd291bGQg aGF2ZSBiZWVuDQo+PiB1bnVzZWQgZm9yIFNWRSBkb21haW4gb3RoZXJ3aXNlLg0KPj4gQ3JlYXRl IHpjcl9lbHsxLDJ9IGZpZWxkcyBpbiBhcmNoX3ZjcHUsIGluaXRpYWxpc2UgemNyX2VsMiBvbiB2 Y3B1DQo+PiBjcmVhdGlvbiBnaXZlbiB0aGUgcmVxdWVzdGVkIHZlY3RvciBsZW5ndGggYW5kIHJl c3RvcmUgaXQgb24NCj4+IGNvbnRleHQgc3dpdGNoLCBzYXZlL3Jlc3RvcmUgWkNSX0VMMSB2YWx1 ZSBhcyB3ZWxsLg0KPj4gUmVtb3ZlIGhlYWRlcnMgZnJvbSBzdmUuYyB0aGF0IGFyZSBhbHJlYWR5 IGluY2x1ZGVkIHVzaW5nDQo+PiB4ZW4vc2NoZWQuaC4NCj4gSSBkaXNsaWtlIHRoaXMgYmVjYXVz ZSAuLi4NCj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2FybTY0L3N2ZS5jIGIveGVu L2FyY2gvYXJtL2FybTY0L3N2ZS5jDQo+PiBpbmRleCA3OGY3NDgyNjE5ZGEuLjU0ODU2NDg4NTBh MCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9hcm02NC9zdmUuYw0KPj4gKysrIGIveGVu L2FyY2gvYXJtL2FybTY0L3N2ZS5jDQo+PiBAQCAtNSwxNCArNSwyOSBAQA0KPj4gICAqIENvcHly aWdodCAoQykgMjAyMiBBUk0gTHRkLg0KPj4gICAqLw0KPj4gIC0jaW5jbHVkZSA8eGVuL3R5cGVz Lmg+DQo+PiAtI2luY2x1ZGUgPGFzbS9jcHVmZWF0dXJlLmg+DQo+IA0KPiAuLi4gaXQgaXMgbm90 IGVudGlyZWx5IG9idmlvdXMgdGhhdCBzY2hlZC5oIHdpbGwgaW1wb3J0IGFzbS9jcHVmZWF0dXJl cy5oLiBUaGlzIGNvdWxkIGVhc2lseSBjaGFuZ2UgaW4gdGhlIGZ1dHVyZSBhbmQgd291bGQgb25s eSByZXF1aXJlIHVzIHRvIHJlLWFkZCB0aG9zZSBpbmNsdWRlcy4NCg0KT2sgSSB3aWxsIHJlaW50 cm9kdWNlICNpbmNsdWRlIDxhc20vY3B1ZmVhdHVyZS5oPiwgZG8gSSB1bmRlcnN0YW5kIGNvcnJl Y3RseSB0aGF0IGlzIHRoZSBvbmx5IGhlYWRlciB5b3Ugd291bGQgbGlrZSBtZSB0byByZXRhaW4/ DQoNCj4gDQo+PiArI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4vc2l6 ZXMuaD4gPiAgICNpbmNsdWRlIDxhc20vYXJtNjQvc3ZlLmg+DQo+PiAtI2luY2x1ZGUgPGFzbS9h cm02NC9zeXNyZWdzLmg+DQo+PiAtI2luY2x1ZGUgPGFzbS9wcm9jZXNzb3IuaD4NCj4+IC0jaW5j bHVkZSA8YXNtL3N5c3RlbS5oPg0KPj4gICAgZXh0ZXJuIHVuc2lnbmVkIGludCBzdmVfZ2V0X2h3 X3ZsKHZvaWQpOw0KPj4gK2V4dGVybiB2b2lkIHN2ZV9zYXZlX2N0eCh1aW50NjRfdCAqc3ZlX2N0 eCwgdWludDY0X3QgKnByZWdzLCBpbnQgc2F2ZV9mZnIpOw0KPj4gK2V4dGVybiB2b2lkIHN2ZV9s b2FkX2N0eCh1aW50NjRfdCBjb25zdCAqc3ZlX2N0eCwgdWludDY0X3QgY29uc3QgKnByZWdzLA0K Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmVzdG9yZV9mZnIpOw0KPj4gKw0KPj4g K3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IHN2ZV96cmVnX2N0eF9zaXplKHVuc2lnbmVkIGlu dCB2bCkNCj4+ICt7DQo+PiArICAgIC8qDQo+PiArICAgICAqIFowLTMxIHJlZ2lzdGVycyBzaXpl IGluIGJ5dGVzIGlzIGNvbXB1dGVkIGZyb20gVkwgdGhhdCBpcyBpbiBiaXRzLCBzbyBWTA0KPj4g KyAgICAgKiBpbiBieXRlcyBpcyBWTC84Lg0KPj4gKyAgICAgKi8NCj4+ICsgICAgcmV0dXJuICh2 bCAvIDhVKSAqIDMyVTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIGlubGluZSB1bnNpZ25lZCBp bnQgc3ZlX2ZmcnJlZ19jdHhfc2l6ZSh1bnNpZ25lZCBpbnQgdmwpDQo+PiArew0KPj4gKyAgICAv KiBGRlIgcmVnaXN0ZXIgc2l6ZSBpcyBWTC84LCB3aGljaCBpcyBpbiBieXRlcyAoVkwvOCkvOCAq Lw0KPj4gKyAgICByZXR1cm4gKHZsIC8gNjRVKTsNCj4+ICt9DQo+PiAgICByZWdpc3Rlcl90IGNv bXB1dGVfbWF4X3pjcih2b2lkKQ0KPj4gIHsNCj4+IEBAIC02MCwzICs3NSw0NiBAQCB1bnNpZ25l ZCBpbnQgZ2V0X3N5c192bF9sZW4odm9pZCkNCj4+ICAgICAgcmV0dXJuICgoc3lzdGVtX2NwdWlu Zm8uemNyNjQuYml0c1swXSAmIFpDUl9FTHhfTEVOX01BU0spICsgMVUpICoNCj4+ICAgICAgICAg ICAgICBTVkVfVkxfTVVMVElQTEVfVkFMOw0KPj4gIH0NCj4+ICsNCj4+ICtpbnQgc3ZlX2NvbnRl eHRfaW5pdChzdHJ1Y3QgdmNwdSAqdikNCj4+ICt7DQo+PiArICAgIHVuc2lnbmVkIGludCBzdmVf dmxfYml0cyA9IHN2ZV9kZWNvZGVfdmwodi0+ZG9tYWluLT5hcmNoLnN2ZV92bCk7DQo+PiArICAg IHVpbnQ2NF90ICpjdHggPSBfeHphbGxvYyhzdmVfenJlZ19jdHhfc2l6ZShzdmVfdmxfYml0cykg Kw0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3ZlX2ZmcnJlZ19jdHhfc2l6ZShz dmVfdmxfYml0cyksDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBMMV9DQUNIRV9C WVRFUyk7DQo+PiArDQo+PiArICAgIGlmICggIWN0eCApDQo+PiArICAgICAgICByZXR1cm4gLUVO T01FTTsNCj4+ICsNCj4+ICsgICAgdi0+YXJjaC52ZnAuc3ZlX2NvbnRleHQgPSBjdHg7DQo+PiAr DQo+PiArICAgIHJldHVybiAwOw0KPj4gK30NCj4+ICsNCj4+ICt2b2lkIHN2ZV9jb250ZXh0X2Zy ZWUoc3RydWN0IHZjcHUgKnYpDQo+PiArew0KPj4gKyAgICB4ZnJlZSh2LT5hcmNoLnZmcC5zdmVf Y29udGV4dCk7DQo+PiArfQ0KPiANCj4gUGxlYXNlIHVzZSBYRlJFRSgpLg0KDQpTdXJlIEnigJls bCBkbw0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Apr 13 15:00:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 15:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520826.808856 (Exim 4.92) (envelope-from ) id 1pmyQx-0008NR-D9; Thu, 13 Apr 2023 15:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520826.808856; Thu, 13 Apr 2023 15:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmyQx-0008NK-AU; Thu, 13 Apr 2023 15:00:23 +0000 Received: by outflank-mailman (input) for mailman id 520826; Thu, 13 Apr 2023 15:00:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmyQw-0008NE-6T for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 15:00:22 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e76090a4-da0b-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 17:00:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e76090a4-da0b-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681398019; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YHcnmoXK+tJ5/GNdoQIGjtqmj4LyJsQsX2kB3uia3M0=; b=WL5vqUB2MMHn0jwqaKNt2JLkvJXrN3LtoiDKAT9XqgTT5qUI/rQVSdvd hlxFaqTVdr90sxnnDiyryQzLU24q41MNuIyFnOkB7LXn8MT6SzkS1Jlbb xbIrYGO460y2UWsx4wTV8Nzl6h1PPi7Pq7zXfuYcndAHM2t0T3ZOsaT50 A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 104748591 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:a0Tiqaz/316ncZtG0qp6t+dNxirEfRIJ4+MujC+fZmUNrF6WrkUBm zYZD22DPKuJNGH8Kdl3OYTj8xgO6JOBx9M3SFA5+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRiPKsT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU0Vr fxDdW8TVxeKhMWN7Zjhbfhnm8t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZwNwhnE9 j+XpgwVBDkRHYOn6iOJwE6yoazJhgbiXropOOOBo6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0efBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC6 7OSt4q3X3o16uTTEC/DsO7O9lteJBT5M0cuPncEFlZa/eDkqYIUtT/lFPFyG7O624id9S7L/ 9yakMQvr+xN3ZdRifvkrAyvbyGE/caQEFNsjunDdif8t14iOtb4D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XC3273k5JbVdoMiAyS3W8wWir+RRfnY VXIpSRa74JJMX2hYMdfOtzhUp9wkfW5TYu7CJg4i+aihbAoLWe6ENxGPxbMjwgBbmB3+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHcqT503+idK2PSfFIYrpxXPTN4jVGovf+16Lm zueXuPXoyhivBrWOHOPrdVPdAhUdhDWx/ne8qRqSwJKGSI+cElJNhMb6ehJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23:ObCwBaGfzMtUP9j1pLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5r mTdZUgpHnJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YZT0EUMrzN5DZB4voSmDPIceod/A== X-Talos-CUID: =?us-ascii?q?9a23=3APkA5vWuRpWH8pP6eb+LplTm76IsJKSXdlyqPPXa?= =?us-ascii?q?/AGVOc5C/E3iB875rxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AEK7gQw8cWNudRHMjvmL3i+iQf8xBvJyNEUw/rYs?= =?us-ascii?q?h+M+fEDV2Awyx0g3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,194,1677560400"; d="scan'208";a="104748591" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86/hvm: Disallow CR0.PG 1->0 transitions when CS.L=1 Date: Thu, 13 Apr 2023 16:00:09 +0100 Message-ID: <20230413150009.3145462-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230412183519.2996902-1-andrew.cooper3@citrix.com> References: <20230412183519.2996902-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The Long Mode consistency checks exist to "ensure that the processor does not enter an undefined mode or state that results in unpredictable behavior". APM Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row preventing the OS from trying to exit Long mode while in 64bit mode. This could leave the CPU in Protected Mode with an %rip above the 4G boundary. Experimentally, AMD CPUs really do permit this state transition. An OS which tries it hits an instant SHUTDOWN, even in cases where the truncation I expect to be going on behind the scenes ought to result in sane continued execution. Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" section instructs peoples to switch to a compatibility mode segment first before clearing CR0.PG, which does clear out the upper bits in %rip. This is further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 Architecture". Either way, this appears to have been a genuine oversight in the AMD64 spec. Intel, on the other hand, rejects this state transition with #GP. Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to 4.1.2 "Paging-Mode Enable" was altered from: If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP); software should clear CR4.PCIDE before attempting to disable paging. to If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP). Software should transition to compatibility mode and clear CR4.PCIDE before attempting to disable paging. which acknowledges this corner case, but there doesn't appear to be any other discussion even in the relevant Long Mode sections. So it appears that Intel spotted and addressed the corner case in IA-32e mode, but were 15 years late to document it. Xen was written to the AMD spec, and misses the check. Follow the Intel behaviour, because it is more sensible and avoids hitting a VMEntry failure. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Restrict to when Long Mode is enabled. --- xen/arch/x86/hvm/hvm.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 1454c1732d95..c63c7d4d6bcf 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2340,6 +2340,21 @@ int hvm_set_cr0(unsigned long value, bool may_defer) } else if ( !(value & X86_CR0_PG) && (old_value & X86_CR0_PG) ) { + struct segment_register cs; + + hvm_get_segment_register(v, x86_seg_cs, &cs); + + /* + * Intel documents a #GP fault in this case, and VMEntry checks reject + * it as a valid state. AMD permits the state transition, and hits + * SHUTDOWN immediately thereafter. Follow the Intel behaviour. + */ + if ( (v->arch.hvm.guest_efer & EFER_LME) && cs.l ) + { + HVM_DBG_LOG(DBG_LEVEL_1, "Guest attempts to clear CR0.PG while CS.L=1"); + return X86EMUL_EXCEPTION; + } + if ( hvm_pcid_enabled(v) ) { HVM_DBG_LOG(DBG_LEVEL_1, "Guest attempts to clear CR0.PG " -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 15:00:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 15:00:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520828.808866 (Exim 4.92) (envelope-from ) id 1pmyRQ-0000JO-Lt; Thu, 13 Apr 2023 15:00:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520828.808866; Thu, 13 Apr 2023 15:00:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmyRQ-0000JH-IV; Thu, 13 Apr 2023 15:00:52 +0000 Received: by outflank-mailman (input) for mailman id 520828; Thu, 13 Apr 2023 15:00:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmyRO-0000Gq-Ec for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 15:00:50 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7c9d368-da0b-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 17:00:47 +0200 (CEST) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Apr 2023 11:00:43 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB5712.namprd03.prod.outlook.com (2603:10b6:a03:2dd::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 15:00:40 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Thu, 13 Apr 2023 15:00:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7c9d368-da0b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681398047; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ErrKj++KGuoinzmjbMMKSr6tPwXsEhw/7+UFjFENxLo=; b=AtIC323yRzHhLuQwGraGc+YKkWAaKY6RZMjI3IDQvwuluLVaulmTIOXZ jiOA0ojZmyEBmhiJTOA7TfBoOqq5n/fF9TTD2R9JsG+7Ea1AvYEMbb28I BdwietqaBfv8om5wWlRipavNdviHbjeXTBkp6oMbx6Zmc3hDZfAQjsB8G o=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 104183524 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:w/VRZq07uE+2i10HtPbD5V1wkn2cJEfYwER7XKvMYLTBsI5bpzEBz TFLD2HUbvuONGH1fNB/O9u1p0IPuJODzt5hHQRtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gBnPqgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfOz9zs tkmNwo0QhWng8u4mpGbEvk1mZF2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFcZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13rOWzXimAt56+LuQx95JkWy5+HQqLgwTXkW4mvK9sFSdRIcKQ 6AT0m90xUQoz2SVSd36Uwy9sWSzlBcWUNpNEMU38AiIjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHLv4Ubnh/JCNF5H8adjMDxGDz26 yCHqm45nbp7pdUQy6yx8FTDgjStjpvEVAg44kPQRG3NxhtweYqNd4Gur1/B4p5oL4uHT1/Ho HkNneCf6vwDCdeGkynlfQkWNLSg5vLAOjuDh1dqRsEl7270oyXlep1M6jZjIksvKtwDZTLif E7Uv0VW+YNXO3ypK6RwZupdFvgX8EQpLvy9Pti8UzaESsQZmNOvlM22WXOt4g== IronPort-HdrOrdr: A9a23:TJlfe67/rJPu9sbp9QPXwPfXdLJyesId70hD6qm+c20tTiX4rb HXoB1/73XJYVkqKRQdcLy7Scu9qDbnhP1ICOoqXItKPjOW3FdARbsKheDfKn/bexEWndQtsp uIHZIObuEYzmIXsS852mSF+hobr+VvOZrHudvj X-Talos-CUID: 9a23:t9zyVmx/AHAPO6JCoU0fBgUuRP1iV0PC9k78Jmu8IGgza53NWQaPrfY= X-Talos-MUID: =?us-ascii?q?9a23=3AChNfwA7P960rd5MBB8YdvQ0YxoxZw4e/OWoziaw?= =?us-ascii?q?gqsyPKy9LMDOnlheoF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,194,1677560400"; d="scan'208";a="104183524" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0L7+DovZFNZOk7OAr3CZDT0NDO8iXWld6ZXDWktOFHmnOkYNNOpuCIOUScffqlmyWFRfZj1y5CY7ad9z8dZNGo0bPA+tqg6Xa7Y1pEaNJrprgWo7xFpnmm1GIW4ng1JkVttgHbIgjIE9IqDcsQiOsBxooLLwmFkE7E0zInaVSLcgNS6wj3rrRfVG90aYR4p7mtuDjB1fQNYw75WS9vd1HOIEzJWT1v96adQVCPYRGAik327aAaPHQIV/HWnHdiSOPWTQx00fLRPE79DCObhMMxkdlcr9iVdx2F7d41C6QJbekYQGE4jQafVzCAJw74FmB6wNMGIitXSUDXiheyVKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=klEoG/X0C1nj76ubJnwT76H/xIUNuYrHoSpaG2B1Quc=; b=ngJrEfgKDJ0YHWAhgu9J3pvrGRTVp6XIIHYP47a0CdIJ4ke+SFOii+FUNeE9SEzncC4Q/B6BIh9/sqCqygnMu2O1UrWrHJDRg2E/oePjQixGJNQpfSO6LW27eAgmJzWkkqsKCp3gYtIPHVrodn/8KCKra8j11rIOByIr3BdXMcxYna15wgbjWUKWsaTtBiaGPdULO6ApZFLdCIMFl8jDMP94+ljhru3kVx0VfSm46yN3/5JTMdSckG/JtnfnWxGnZriJ3B2qiLbaobn2dLVGeU+20asJbCYeUSeAzcUdUoCyRYmqcdumWfMWJ3X+ZjNkxhDcHp+zVW7CTi6JpKFidg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=klEoG/X0C1nj76ubJnwT76H/xIUNuYrHoSpaG2B1Quc=; b=QvI0Jc2Ly+zuM7Ppy00VsEECYq7nfVi7IE5mcyAZapbuYWq5L1eSU3P2Yp8NxX87ewnMYYjLsDtJq2QNBKbAfQtBgEZf6njjLPGp/uAV5y3nQc3Gsb0E0MpGcw7ZXbyNkuoAdQY37eswDaLk8B81oTN+vCKmqN/jsb8y6qxqtNQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 13 Apr 2023 17:00:33 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Kevin Tian Subject: Re: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Message-ID: References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-3-volodymyr_babchuk@epam.com> <873556xa0g.fsf@epam.com> <87v8i0wyv0.fsf@epam.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87v8i0wyv0.fsf@epam.com> X-ClientProxiedBy: LO4P123CA0441.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::14) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB5712:EE_ X-MS-Office365-Filtering-Correlation-Id: c2812498-98c9-4ad8-9fef-08db3c2fd89e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: giRn09I/fvWGJXe2eH03OIaDaWyUiKrIm8kI/iSH2x1N9wKvX8TeiuH4PtuXC1kjgmd13qJRdZjn/yD8ABXPhZq5BEK44G2iQH5rQEVSFw4sG2JxXW+7QVOpdnaG1eZZO2ZVu+llmrZtSGOe6vBjbTWjNMNlTPfSLdk7XpJDUfixTsbg1qpJA3Vtn1UMje1jMnQJLjLy52eZsabkNz6UifdBCwdgbuj6TQxfSlzigcVOv3tA0jVulN/4vfcBOhQrwzfDFfOaJcZIIykoV7BKS6uxGJhwoMW85DPU+fW/yXiSwcM5aK71rJrmTw7cUHNcGdKBYBUTxZ1LteWzyMoPgfKi9UHlRZbxCoeHgHs8dzFprqF5GflqwVjk8TFk4ypsKDjw4t13fkcZ6CPa/I4KCID6RZ6xqHB2aAD9fVxNnM5HxkKPAgJyteQ3myOilcYTsBatDzyEPJnQb85f8DSqqqflFBG7MkYkNxabXvtHKa8TyOoZt8p3WDpRTQSXycQib9bQNELzHZJZUDCqrtPKuU1NeUydjvlxkCULsaVJS/ca8WvC/9KbUxbkOVrv03fM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199021)(6666004)(6486002)(6916009)(66476007)(66556008)(66946007)(4326008)(85182001)(30864003)(2906002)(7416002)(33716001)(86362001)(41300700001)(82960400001)(5660300002)(8676002)(8936002)(316002)(38100700002)(478600001)(54906003)(9686003)(6512007)(6506007)(26005)(186003)(66899021)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NktNUDBQMWlSRUJUdnE1K05hL1dkS21oSG01WG15Z1Z4dWpwODVrUTRxZ2dQ?= =?utf-8?B?M0pUZVU0YXI2QUZXekxmMk9QS2xjQVlqVmNPRjRubGVXdVFwN2hOaElDN3ZV?= =?utf-8?B?bXIydGFBeXBLa282M24xTFNINytURm9scWk1WDROb2pYdStrZHd3bjhOZUQr?= =?utf-8?B?RVRXcE1UNzQzVmxMVEIyaS9SYzlSd0VyTUVyN2FaOGZVS0pQT2FIakYrbDRo?= =?utf-8?B?RVY1VkN6cVBNd0I5QTltbmlqVXFYdTUwUm1aS1k5a01GMWRuQXZqZy9IazEz?= =?utf-8?B?dXBSTnJTMzRqNE1zQmpZZWt1Ym5ITkJSR3NFN1cvNEY3R0JWNzBaZlRwdmln?= =?utf-8?B?ZFMvUnB3VzdmQWNIaTR2TjdHLzh0U2lac2lTWXUrOWl5T2tEMlFOWG0xVUFi?= =?utf-8?B?ekFPRUdheEhhWVhzcUg5QmhxcWoxTG9DVU16S3RjUjQxcXpidFhIaHhVdXRC?= =?utf-8?B?RUIrYkdRSWdFRmlrV2tWK29kTzJMa2YyMjBpbjJxb0oxZUJPSUJBd2ZhL09v?= =?utf-8?B?aThoMWFzUUpCdzdiWWJRREh4Q3IwS3VRbXByQVlvaGdZeDBjb0IzTlYrSDcy?= =?utf-8?B?T2I4OHA0TkRWZWFkNXdreWVpSW94T2VPRVY3a0dXYmZlbmJVVjlXV3VvQlZw?= =?utf-8?B?VFBlVFdUdGVkSVVPODl0ODY2TWhmcVhRMG9LMHM0QTZWa29zOUJsaHFXcmdz?= =?utf-8?B?T21iWDhxZElkVXZ1M0h2RHJrRElFditnMjNZUFYyOHJreUpSR3d4S3I0VDU2?= =?utf-8?B?ZmV1dlF1cWFTZ3krazBPT0MzblVYOVhiS2pDVzI0c2FDQlgrM0NzK0lMWk9i?= =?utf-8?B?dW9BWWRDdlMrVUd1cEdLTEpvYXJnZ2g4c2ZGc2NkdldueXFFS3BFbHdDRmdE?= =?utf-8?B?R1RyN1lReVpNc1lhWVhXVDB5RGdJWmZyYWxpaE5QVnlXRENjaFMrMmNVNURV?= =?utf-8?B?L244bVpzRlFFb05ZOFUwNm1rOWQwNlk4VmZ1NE5kY3F3Zi9BMXora2xOZVNN?= =?utf-8?B?UElHN09NeUQxNUR2amdnT29xNXIyVmpTMlgzalh5V2oyRndBaExNZWFNS0dY?= =?utf-8?B?QmFEUzRPNENGZE4yank5UGU1S3JyWVMyOFNHbGVLeEJEemNxejZRWnJ3QlhB?= =?utf-8?B?SURDMlc1ekhVQmZlK0REWFRQcnZBV3pZZUZpNHhDdE5BdjN6ZENUb1c4NWJY?= =?utf-8?B?SU5ubnVCU3V4VGN6UGhJZXk4MXVqK29iUm11bU1zT2M1OUhrcVVtMStHMFZh?= =?utf-8?B?NnZmcUtha0FRcDhBNjA4S3R5QjVxQ3RsdEIzTmhNZm1iZG5UaUlWNlhDbURD?= =?utf-8?B?VlpLeERiaHNsc01vUWtoT1d2VlptaWoydFVtbGc2cklzeXV2eXAxK3JXY0tk?= =?utf-8?B?dHdhOXdGSTdOQ1hPWTJFMTBPVUF6Nk9PQkZYd3IwNFdoTURKYmE4Mjc3eVoz?= =?utf-8?B?d0xTTlYwdE8xUUF0ZzRVc1VtS3pzYjduVnZBZTZmZFdrYmRta2hxNTJDYm1R?= =?utf-8?B?QmlyclVYdE5MVjU3NzBlYWp5U1MvMHo5dldZdGtWR2JCaUorUnltSFRTNnls?= =?utf-8?B?S3dPVHFwcmR3dlBpTk5iRWlYZXBuVm51NUgrVzVJWEVNc1dTMSs3bmJLTXZo?= =?utf-8?B?ZXlOQWppNmZraU96NlpuSi9XTmFNYUN2akdBMEFGRVQ0VFFscXRoWFBOS1Rp?= =?utf-8?B?ZzAyOE5UeXpEM21xVGhvMklzamxuUXpqcE92dmhPa3Z5VlBKc1kzcXVrVDV6?= =?utf-8?B?TXovMnBkVkFGUUZ1Z2VHbkFXbFFiU2R3Um1kMmlyWjFuMHQ0UzRkbFVmZGxw?= =?utf-8?B?WHI2T2hoVWNFRDdLNDRueUR4Zy91MjJwTUdCRzFha3BZUWlYeGJBbmh5NG5I?= =?utf-8?B?WnprYlhRMlN4S0V3SEdLc28rRGtTdlAwYzFQS3ZJbHVVSzZCMW1JSWFDTmZY?= =?utf-8?B?Y25NZ1U3dlRHZ2VzZlF1ZVk4bmsyRG9wVHZNZU1iY1NDZjU5cUpPb2RTTDJ6?= =?utf-8?B?dVJrL2ozQ1F3TE1zMDNJYnNGU3BlVnU0dHR2a3d4eEJWZ2ZMUXhQQ3JlOXpN?= =?utf-8?B?VFB2bmZNOWtQWmpsb3ZsRjVQTDBuTUxXYUViS1ZGb2ZDdFR4YWZMMCtnSTZT?= =?utf-8?Q?VABD8QlzNwiKUuIF2M0AzLZ2B?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nwV6xTNeFZ1ivcHBz348OzL6OZQK9knKQIZH+9BxlFMGRU1KQE7Jo0/AsqxhQ90i9ZPFxdNkeFzlslmWueWu2hiji/lU7fvMdYzjppRPf0K2JC1lrWSTtWUIJVg4OzkIeWV4XHYN0XPlQ6z7zm2y1uMsR1H9Ro24tun+5Jcau/KGweAwLhdKea5K4i8kxR5ylf3otZsp/8Sm4GItGZs66BfOIk0W125ZxPe5N8gPeyT07/pTxEORU0nF6xxzXjwEO1LCYG8ozexgDPLO5Og4+1XmG/5glVb7HcO8yNUDUZU/6w+M7rITuvN8PnIZ3idU2Poi8l56g3S5kisGP8l/2Mqn3R1TwelzNHaIS1OrLUk1jcr4Q4fngdTxdJvOpDRKsowzR3ptqGgd5DZlQeeofmd7/jYIcAsiFitLJBQtgqPs9t9rci5SJnsqtnoWjLNPDaS/jpXH4SFldUr76P7qBycnDoKXkiyO15JhKEA22s79881fRE4lEzwyefLA1m89dnnCamcQ2ppLMeuO7Ez1gSTcDv/JB+7oWUcTXLbbb65pvX5UjZCK690OosiW2IDLLwbIlZZP46npRMlOlLBHWyLCzA6urQLhkAvwlz4CenlxKVJLxQbuAhId6p5jgJpEjVdqiaO84DgfZPswMSX5ilWedHN4A4hqtW/uzuzoIXM0N+Cw6peO+fY+4tEV45isJwkM+IGMH9EKvXmq7pOYIQDAv0dtjRjcPjk2dp08P1SAaSTWLJxgVkYAZ0+S/nbldHndXX3sFLmTVUCrpDWqCX09jhrNK51eeawYz7gliXDuAWVpyv/r8qQxyFhcsW/t/pkA1sUkRB1sOeZsOJ4MG1FzzaaQy/s0PUq0DUmPk837+wga90nWCTrGXYJ4m/jzeqMZ88wdhlMIu0vhf3Ev6w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2812498-98c9-4ad8-9fef-08db3c2fd89e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 15:00:40.4667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SB+fCq6ERjR+XO5cvIOFLejM7wBvN5XsSs6jeF02w7DoM1HVx5SsWoDG9ffzF72YeLGxGgdp9Rd7mGYaSiWFBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5712 On Wed, Apr 12, 2023 at 09:54:12PM +0000, Volodymyr Babchuk wrote: > > Hi Roger, > > First of all, I want to provide link [1] to the RFC series where I tried > total PCI locking rework. After discussing with Jan, it became clear for > me, that task is much harder, than I anticipated. So, it was decided to > move with a smaller steps. First step is to make vPCI code independed > from the global PCI lock. Actually, this is not the first try. > Oleksandr Andrushchenko tried to use r/w lock for this: [2]. But, > Jan suggested to use refcounting instead of r/w locks, and I liked the > idea. So, this is why you are seeing this patch series. Thanks, I've been on leave for long periods recently and I've missed some of the series. > > > Roger Pau Monné writes: > > > On Tue, Apr 11, 2023 at 11:41:04PM +0000, Volodymyr Babchuk wrote: > >> > >> Hi Roger, > >> > >> Roger Pau Monné writes: > >> > >> > On Tue, Mar 14, 2023 at 08:56:29PM +0000, Volodymyr Babchuk wrote: > >> >> Prior to this change, lifetime of pci_dev objects was protected by global > >> >> pcidevs_lock(). Long-term plan is to remove this log, so we need some > >> > ^ lock > >> > > >> > I wouldn't say remove, as one way or another we need a lock to protect > >> > concurrent accesses. > >> > > >> > >> I'll write "replace this global lock with couple of more granular > >> locking devices" > >> if this is okay for you. > >> > >> >> other mechanism to ensure that those objects will not disappear under > >> >> feet of code that access them. Reference counting is a good choice as > >> >> it provides easy to comprehend way to control object lifetime. > >> >> > >> >> This patch adds two new helper functions: pcidev_get() and > >> >> pcidev_put(). pcidev_get() will increase reference counter, while > >> >> pcidev_put() will decrease it, destroying object when counter reaches > >> >> zero. > >> >> > >> >> pcidev_get() should be used only when you already have a valid pointer > >> >> to the object or you are holding lock that protects one of the > >> >> lists (domain, pseg or ats) that store pci_dev structs. > >> >> > >> >> pcidev_get() is rarely used directly, because there already are > >> >> functions that will provide valid pointer to pci_dev struct: > >> >> pci_get_pdev(), pci_get_real_pdev(). They will lock appropriate list, > >> >> find needed object and increase its reference counter before returning > >> >> to the caller. > >> >> > >> >> Naturally, pci_put() should be called after finishing working with a > >> >> received object. This is the reason why this patch have so many > >> >> pcidev_put()s and so little pcidev_get()s: existing calls to > >> >> pci_get_*() functions now will increase reference counter > >> >> automatically, we just need to decrease it back when we finished. > >> > > >> > After looking a bit into this, I would like to ask whether it's been > >> > considered the need to increase the refcount for each use of a pdev. > >> > > >> > >> This is how Linux uses reference locking. It decreases cognitive load > >> and chance for an error, as there is a simple set of rules, which you > >> follow. > >> > >> > For example I would consider the initial alloc_pdev() to take a > >> > refcount, and then pci_remove_device() _must_ be the function that > >> > removes the last refcount, so that it can return -EBUSY otherwise (see > >> > my comment below). > >> > >> I tend to disagree there, as this ruins the very idea of reference > >> counting. We can't know who else holds reference right now. Okay, we > >> might know, but this requires additional lock to serialize > >> accesses. Which, in turn, makes refcount un-needed. > > > > In principle pci_remove_device() must report whether the device is > > ready to be physically removed from the system, so it must return > > -EBUSY if there are still users accessing the device. > > > > A user would use PHYSDEVOP_manage_pci_remove to signal Xen it's trying > > to physically remove a PCI device from a system, so we must ensure > > that when the hypervisor returns success the device is ready to be > > physically removed. > > > > Or at least that's my understanding of how this should work. > > > > As I can see, this is not how it is implemented right > now. pci_remove_device() is not checking if device is not assigned to a > domain. Id does not check if there are still users accessing the > device. It just relies on a the global PCI lock to ensure that device is > removed in an orderly manner. Right, the expectation is that any path inside of the hypervisor using the device will hold the pcidevs lock, and thus bny holding it while removing we assert that no users (inside the hypervisor) are left. I don't think we have been very consistent about the usage of the pcidevs lock, and hence most of this is likely broken. Hopefully removing a PCI device from a system is a very uncommon operation. > My patch series has no intention to change this behavior. All what I > want to achieve - is to allow vpci code access struct pdev objects > without holding the global PCI lock. That's all fine, but we need to make sure it doesn't make things worse and what they currently are, and ideally it should make things easier. That's why I would like to understand exactly what's the purpose of the refcount, and how it should be used. The usage of the refcount should be compatible with the intended behaviour of pci_remove_device(), regardless of whether the current implementation is not correct. We don't want to be piling up more broken stuff on top of an already broken implementation. > >> > > >> > That makes me wonder if for example callers of pci_get_pdev(d, sbdf) > >> > do need to take an extra refcount, because such access is already > >> > protected from the pdev going away by the fact that the device is > >> > assigned to a guest. But maybe it's too much work to separate users > >> > of pci_get_pdev(d, ...); vs pci_get_pdev(NULL, ...);. > >> > > >> > There's also a window when the refcount is dropped to 0, and the > >> > destruction function is called, but at the same time a concurrent > >> > thread could attempt to take a reference to the pdev still? > >> > >> Last pcidev_put() would be called by pci_remove_device(), after removing > >> it from all lists. This should prevent other threads from obtaining a valid > >> reference to the pdev. > > > > What if a concurrent user has taken a reference to the object before > > pci_remove_device() has removed the device from the lists, and still > > holds it when pci_remove_device() performs the supposedly last > > pcidev_put() call? > > Well, let's consider VPCI code as this concurrent user, for > example. First, it will try to take vpci->lock. Depending on where in > pci_remov_device() there will be three cases: > > 1. Lock is taken before vpci_remove_device() takes the lock. In this > case vpci code works as always > > 2. It tries to take the lock when vpci_remove_device() is already locked > this. In this case we are falling to the next case: > > 3. Lock is taken after vpci_remove_device() had finished it's work. In this > case vPCI code sees that it was called for a device in an invalid state > and exits. For 2) and 3) you will hit a dereference, as the lock (vpci->lock) would have been freed by vpci_remove_device() while a concurrent user is waiting on pci_remov_device() to release the lock. I'm not sure how the user sees the device is in an invalid state, because it was waiting on a lock (vpci->lock) that has been removed under it's feet. This is an existing issue not made worse by the refcounting, but it's not a great example. > > As you can see, there is no case where vPCI code is running on an device > which was removed. > > After vPCI code drops refcounter, pdev object will be freed once and for > all. Please node, that I am talking about pdev object there, not about > PCI device, because PCI device (as a high-level entity) was destroyed by > pci_remove_device(). refcount is needed just for the last clean-up > operations. Right, but pci_remove_device() will return success even when there are some users holding a refcount to the device, which is IMO undesirable. As I understand it the purpose of pci_remove_device() is that once it returns success the device can be physically removed from the system. > > > >> > > >> >> sbdf.devfn &= ~stride; > >> >> pdev = pci_get_pdev(NULL, sbdf); > >> >> if ( pdev && stride != pdev->phantom_stride ) > >> >> + { > >> >> + pcidev_put(pdev); > >> >> pdev = NULL; > >> >> + } > >> >> } > >> >> > >> >> return pdev; > >> >> @@ -548,13 +526,18 @@ struct pci_dev *pci_get_pdev(const struct domain *d, pci_sbdf_t sbdf) > >> >> list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list ) > >> >> if ( pdev->sbdf.bdf == sbdf.bdf && > >> >> (!d || pdev->domain == d) ) > >> >> + { > >> >> + pcidev_get(pdev); > >> >> return pdev; > >> >> + } > >> >> } > >> >> else > >> >> list_for_each_entry ( pdev, &d->pdev_list, domain_list ) > >> >> if ( pdev->sbdf.bdf == sbdf.bdf ) > >> >> + { > >> >> + pcidev_get(pdev); > >> >> return pdev; > >> >> - > >> >> + } > >> >> return NULL; > >> >> } > >> >> > >> >> @@ -663,7 +646,10 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, > >> >> PCI_SBDF(seg, info->physfn.bus, > >> >> info->physfn.devfn)); > >> >> if ( pdev ) > >> >> + { > >> >> pf_is_extfn = pdev->info.is_extfn; > >> >> + pcidev_put(pdev); > >> >> + } > >> >> pcidevs_unlock(); > >> >> if ( !pdev ) > >> >> pci_add_device(seg, info->physfn.bus, info->physfn.devfn, > >> >> @@ -818,7 +804,9 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn) > >> >> if ( pdev->domain ) > >> >> list_del(&pdev->domain_list); > >> >> printk(XENLOG_DEBUG "PCI remove device %pp\n", &pdev->sbdf); > >> >> - free_pdev(pseg, pdev); > >> >> + list_del(&pdev->alldevs_list); > >> >> + pdev_msi_deinit(pdev); > >> >> + pcidev_put(pdev); > >> > > >> > Hm, I think here we want to make sure that the device has been freed, > >> > or else you would have to return -EBUSY to the calls to notify that > >> > the device is still in use. > >> > >> Why? As I can see, pdev object is still may potentially be accessed by > >> some other CPU right now. So pdev object will be freed after last > >> reference is dropped. As it is already removed from all the lists, > >> pci_dev_get() will not find it anymore. > >> > >> Actually, I can't see how this can happen in reality, as VPCI, MSI and > >> IOMMU are already deactivated for this device. So, no one would touch it. > > > > Wouldn't it be possible for a concurrent user to hold a reference from > > befoe the device has been 'deactivated'? > > > > Yes, it can hold a reference. This is why we need additional locking to > ensure that, say, pci_cleanup_msi() does not races with rest of the MSI > code. Right now this is ensured by then global PCI lock. > > >> > > >> > I think we need an extra pcidev_put_final() or similar that can be > >> > used in pci_remove_device() to assert that the device has been > >> > actually removed. > >> > >> Will something break if we don't do this? I can't see how this can > >> happen. > > > > As mentioned above, once pci_remove_device() returns 0 the admin > > should be capable of physically removing the device from the system. > > > > This patch series does not alter this requirement. Admin is still > capable of physically removing the device from the system. After > successful call to the pci_remove_device() Indeed, but there might be users in the hypervisor still holding a reference to the pdev. > >> >> -static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > >> >> +static int assign_device(struct domain *d, struct pci_dev *pdev, u32 flag) > >> >> { > >> >> const struct domain_iommu *hd = dom_iommu(d); > >> >> - struct pci_dev *pdev; > >> >> + uint8_t devfn; > >> >> int rc = 0; > >> >> > >> >> if ( !is_iommu_enabled(d) ) > >> >> @@ -1422,10 +1412,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > >> >> > >> >> /* device_assigned() should already have cleared the device for assignment */ > >> >> ASSERT(pcidevs_locked()); > >> >> - pdev = pci_get_pdev(NULL, PCI_SBDF(seg, bus, devfn)); > >> >> ASSERT(pdev && (pdev->domain == hardware_domain || > >> >> pdev->domain == dom_io)); > >> >> > >> >> + devfn = pdev->devfn; > >> >> + > >> >> /* Do not allow broken devices to be assigned to guests. */ > >> >> rc = -EBADF; > >> >> if ( pdev->broken && d != hardware_domain && d != dom_io ) > >> >> @@ -1460,7 +1451,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > >> >> done: > >> >> if ( rc ) > >> >> printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", > >> >> - d, &PCI_SBDF(seg, bus, devfn), rc); > >> >> + d, &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc); > >> >> /* The device is assigned to dom_io so mark it as quarantined */ > >> >> else if ( d == dom_io ) > >> >> pdev->quarantine = true; > >> >> @@ -1595,6 +1586,9 @@ int iommu_do_pci_domctl( > >> >> ASSERT(d); > >> >> /* fall through */ > >> >> case XEN_DOMCTL_test_assign_device: > >> >> + { > >> >> + struct pci_dev *pdev; > >> >> + > >> >> /* Don't support self-assignment of devices. */ > >> >> if ( d == current->domain ) > >> >> { > >> >> @@ -1622,26 +1616,36 @@ int iommu_do_pci_domctl( > >> >> seg = machine_sbdf >> 16; > >> >> bus = PCI_BUS(machine_sbdf); > >> >> devfn = PCI_DEVFN(machine_sbdf); > >> >> - > >> >> pcidevs_lock(); > >> >> - ret = device_assigned(seg, bus, devfn); > >> >> + pdev = pci_get_pdev(NULL, PCI_SBDF(seg, bus, devfn)); > >> >> + if ( !pdev ) > >> >> + { > >> >> + printk(XENLOG_G_INFO "%pp non-existent\n", > >> >> + &PCI_SBDF(seg, bus, devfn)); > >> >> + ret = -EINVAL; > >> >> + break; > >> >> + } > >> >> + > >> >> + ret = device_assigned(pdev); > >> >> if ( domctl->cmd == XEN_DOMCTL_test_assign_device ) > >> >> { > >> >> if ( ret ) > >> >> { > >> >> - printk(XENLOG_G_INFO "%pp already assigned, or non-existent\n", > >> >> + printk(XENLOG_G_INFO "%pp already assigned\n", > >> >> &PCI_SBDF(seg, bus, devfn)); > >> >> ret = -EINVAL; > >> >> } > >> >> } > >> >> else if ( !ret ) > >> >> - ret = assign_device(d, seg, bus, devfn, flags); > >> >> + ret = assign_device(d, pdev, flags); > >> >> + > >> >> + pcidev_put(pdev); > >> > > >> > I would think you need to keep the refcount here if ret == 0, so that > >> > the device cannot be removed while assigned to a domain? > >> > >> Looks like we are perceiving function of refcnt in a different > >> ways. For me, this is the mechanism to guarantee that if we have a valid > >> pointer to an object, this object will not disappear under our > >> feet. This is the main function of krefs in the linux kernel: if your > >> code holds a reference to an object, you can be sure that this object is > >> exists in memory. > >> > >> On other hand, it seems that you are considering this refcnt as an usage > >> counter for an actual PCI device, not "struct pdev" that represent > >> it. Those are two related things, but not the same. So, I can see why > >> you are suggesting to get additional reference there. But for me, this > >> looks unnecessary: the very first refcount is obtained in > >> pci_add_device() and there is the corresponding function > >> pci_remove_device() that will drop this refcount. So, for me, if admin > >> wants to remove a PCI device which is assigned to a domain, they can do > >> this as they were able to do this prior this patches. > > > > This is all fine, but needs to be stated in the commit message. > > > > Sure, I will add this. > > >> The main value of introducing refcnt is to be able to access pdev objects > >> without holding the global pcidevs_lock(). This does not mean that you > >> don't need locking at all. But this allows you to use pdev->lock (which > >> does not exists in this series, but was introduced in a RFC earlier), or > >> vpci->lock, or any other subsystem->lock. > > > > I guess I was missing this other bit about introducing a > > per-device lock, would it be possible to bundle all this together into > > a single patch series? > > As I said at the top of this email, it was tried. You can check RFC at [1]. > > > > > It would be good to place this change together with any other locking > > related change that you have pending. > > Honestly, my main goal is to fix the current issues with vPCI, so ARM > can move forward on adding PCI support for the platform. So, I am > focusing on this right now. Thanks, we need to be careful however as to not accumulate more bandaids on top just to workaround the fact that the locking we have regarding the pci devices is not suitable. I think it's important to keep all the usages of the pci_dev struct in mind when designing a solution. Overall it seems like might help vPCI on Arm, I think the only major request I have is the one related to pci_remove_device() only returning success when there are not refcounts left. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 13 15:29:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 15:29:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520836.808876 (Exim 4.92) (envelope-from ) id 1pmytG-000348-38; Thu, 13 Apr 2023 15:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520836.808876; Thu, 13 Apr 2023 15:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmytG-000341-0S; Thu, 13 Apr 2023 15:29:38 +0000 Received: by outflank-mailman (input) for mailman id 520836; Thu, 13 Apr 2023 15:29:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmytE-00033v-Sn for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 15:29:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe6d4212-da0f-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 17:29:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 395DE6182A; Thu, 13 Apr 2023 15:29:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA1E8C433D2; Thu, 13 Apr 2023 15:29:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe6d4212-da0f-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681399773; bh=6YdWOQ0NUZ+UngXtsJhd6s1Sck8wLHWwB86rNg5G0y8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hS+1wQQHpoNr9n7nx0QyQ5GAInVAhzMZqqUwwJMuj4fGjVQ4hNdmYqCN2ZJaU8KX0 3CnI9sk0LPGCMmk6gAMCziTgTtInvEKwlo5/1rBEAqZ0yiszxhH+w6K/52X08j2VjA zFFr6RcweeN3DZKUVtiMd4pAl5GfBwT5wySn7gDinKL2AMstEgAJOe0dOM+78Kg3kr qQvQnZluph4QqS58g0DSeJPAUnYSu13XAG5iNh8pN2lY+S9i+GSAt2RDaP/KoEvG/L mzLvxKfUTzlX+lcIcg7Az7msuw3ISlo7NdMe0fqkNlQ9N1tEOesDTlTjoBPt1Besxy zQjan80FY5sLw== Date: Thu, 13 Apr 2023 08:29:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH] automation: switch ADL hw tests to debug build In-Reply-To: <20230413122340.47233-1-marmarek@invisiblethingslab.com> Message-ID: References: <20230413122340.47233-1-marmarek@invisiblethingslab.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-656519186-1681399773=:15580" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-656519186-1681399773=:15580 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 13 Apr 2023, Marek Marczykowski-Górecki wrote: > This should give a lot more useful information in case of a failure, and > also enable some asserts for extra checks. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Stefano Stabellini > --- > automation/gitlab-ci/test.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 0916b367ea90..d68c584269dd 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -131,21 +131,21 @@ xilinx-smoke-dom0less-arm64-gcc: > - *arm64-test-needs > - alpine-3.12-gcc-arm64 > > -adl-smoke-x86-64-gcc: > +adl-smoke-x86-64-gcc-debug: > extends: .adl-x86-64 > script: > - ./automation/scripts/qubes-x86-64.sh 2>&1 | tee ${LOGFILE} > needs: > - *x86-64-test-needs > - - alpine-3.12-gcc > + - alpine-3.12-gcc-debug > > -adl-suspend-x86-64-gcc: > +adl-suspend-x86-64-gcc-debug: > extends: .adl-x86-64 > script: > - ./automation/scripts/qubes-x86-64.sh s3 2>&1 | tee ${LOGFILE} > needs: > - *x86-64-test-needs > - - alpine-3.12-gcc > + - alpine-3.12-gcc-debug > > qemu-smoke-dom0-arm64-gcc: > extends: .qemu-arm64 > -- > 2.39.2 > --8323329-656519186-1681399773=:15580-- From xen-devel-bounces@lists.xenproject.org Thu Apr 13 16:02:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 16:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520842.808885 (Exim 4.92) (envelope-from ) id 1pmzOR-0007mx-J3; Thu, 13 Apr 2023 16:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520842.808885; Thu, 13 Apr 2023 16:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmzOR-0007mq-GK; Thu, 13 Apr 2023 16:01:51 +0000 Received: by outflank-mailman (input) for mailman id 520842; Thu, 13 Apr 2023 16:01:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmzOQ-0007mg-6z; Thu, 13 Apr 2023 16:01:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmzOQ-0007P1-0Q; Thu, 13 Apr 2023 16:01:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmzOO-0005mS-Sj; Thu, 13 Apr 2023 16:01:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pmzOO-0006Gq-RS; Thu, 13 Apr 2023 16:01:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Go2j0v20RRlaFZNAEg84mxHo/tFaYNVz1AsvL69XM/0=; b=rwjua5hnzt3dWDV0V7hxUM2qaj OvBNZUnqG+qO9qlTwLFgBlnQjJV3cPvsmvGBkoJBBOoD857yAIWcCRH/MySZhLbg0vwcJnT2wxdR2 MkkYMSV2C+hbPD9RSSpn2YhQ/iw0hTLN4faJ3DLIMyN/eieF2IGwdRGxOsUpDzEJj/h8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180237: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=8363b1f62e561cfb73073b4b094516fcbbd7020e X-Osstest-Versions-That: xen=f872a624cbf92de9944483eea7674ef80ced1380 From: osstest service owner Date: Thu, 13 Apr 2023 16:01:48 +0000 flight 180237 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180237/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 8363b1f62e561cfb73073b4b094516fcbbd7020e baseline version: xen f872a624cbf92de9944483eea7674ef80ced1380 Last test of basis 180226 2023-04-13 02:00:25 Z 0 days Testing same since 180237 2023-04-13 14:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f872a624cb..8363b1f62e 8363b1f62e561cfb73073b4b094516fcbbd7020e -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 13 16:10:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 16:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520848.808896 (Exim 4.92) (envelope-from ) id 1pmzWt-0000qq-FX; Thu, 13 Apr 2023 16:10:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520848.808896; Thu, 13 Apr 2023 16:10:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmzWt-0000qj-Co; Thu, 13 Apr 2023 16:10:35 +0000 Received: by outflank-mailman (input) for mailman id 520848; Thu, 13 Apr 2023 16:10:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pmzWr-0000qd-Cp for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 16:10:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0c::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6230a02-da15-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 18:10:30 +0200 (CEST) Received: from AM6P191CA0074.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::15) by AM9PR08MB6114.eurprd08.prod.outlook.com (2603:10a6:20b:287::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 16:10:28 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::dd) by AM6P191CA0074.outlook.office365.com (2603:10a6:209:8a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 16:10:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 16:10:27 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Thu, 13 Apr 2023 16:10:26 +0000 Received: from 2ce8db9ec33a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A89ADFEA-9121-4F97-A769-EACAB67D62D0.1; Thu, 13 Apr 2023 16:10:16 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2ce8db9ec33a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 16:10:16 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB9867.eurprd08.prod.outlook.com (2603:10a6:20b:5ab::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 16:10:13 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 16:10:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6230a02-da15-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IO2qus3IghDRLaMTgWF8VVy8MG262oH2O/6uT+AqoAo=; b=U30/iUJTfAElTiLhpXEDFlK9Wx8H6poIg/tiHoblMLAE+zSN0auDTDjWEqi7CnXsmU+pVjDw1ijxmBz3r2cEkUd8jCmnVVcr+76rwMVQtkM3FIEP1oT4BgnSJxbXnbLB9oW/bVL9bJaQf48qrBw0Mb6TDnR2NGOW1EzPYfShw0M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7b36245694e2b994 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=behBL2xBPSwaFw1jUmKfiDCzr9fcq3nL+2jrsPeosm44WoBazoX8jdYs065GaDW8YRTHxewqVDyOB741ygbLzGbB9XB+jxyewvxbrY1mKE3RyoYdqTpe6H72i0ELNCzAWe+xc0FTlwAGtjIi+EfWyO8aIrs1MVN56Ue9q+r0f8IYNA0VJ5EQqPi+JHAHIMIx6yjLwS5etCwoxm51ixMQRgjMsPzv06TiThf2pC1KLI3KseBTKMF8z4RX3swUFZMI7mxJb5XtZLs6jFtYL7K0gfEzR+Ufhh3nGNK6NyRI9ahvTQ82a+AgJhnXwEtO3+mQZaEy2ov0nqvg5YB0S9Ax/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IO2qus3IghDRLaMTgWF8VVy8MG262oH2O/6uT+AqoAo=; b=KdSLeSXLM/ClIh10YjREFY13CZCjdoj6Tzl9GSac4blFqwgCBjq4JEL0bdsxENvNwsSvf1qidS5GAqqIhjXenNKMtk3LoSIsdjEsjQOhoVCODfedR9rxFlGUE7xh0om993Q2vlijfyShYTBspYWlNV4qlNSHviqsVTm6BuafPhwsFCXUovvHoFFjMQ8nB6FYnVhkNv6mcRl+G+C/XXK/NWsuG+UxRKWOVazEBiZsRWHjtaeydE0HUYBmv/jXVZqdKvn4nweXPjNFqXQKZS5tY6Zti8LjLseB84VxELZWVJvqhKGoZqsXW2abX//1XFvv+xUpFpxJItMchuglIrjw0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IO2qus3IghDRLaMTgWF8VVy8MG262oH2O/6uT+AqoAo=; b=U30/iUJTfAElTiLhpXEDFlK9Wx8H6poIg/tiHoblMLAE+zSN0auDTDjWEqi7CnXsmU+pVjDw1ijxmBz3r2cEkUd8jCmnVVcr+76rwMVQtkM3FIEP1oT4BgnSJxbXnbLB9oW/bVL9bJaQf48qrBw0Mb6TDnR2NGOW1EzPYfShw0M= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Topic: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Index: AQHZbSQ9GJqCFHqaX0uCiT+EC9U7s68pNK+AgAAHnICAAAGIAIAACdqAgAAi2YA= Date: Thu, 13 Apr 2023 16:10:13 +0000 Message-ID: <92DA4B4F-7BB9-4CAC-9276-0B6A10550164@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> In-Reply-To: <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB9867:EE_|AM7EUR03FT032:EE_|AM9PR08MB6114:EE_ X-MS-Office365-Filtering-Correlation-Id: 98059bcb-7759-4077-3c6f-08db3c39988b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fl9+qnvjAK/eQHm4GFaYdZG4fUNJ+jE1/qa0kF6RVNjYKihmW2xHSB29F3qr2kWL/lKcjKcJnO1T1n+2gHyEp0n0yNrtTDLbMqZg8+sUwDHLQmRPmA6AAxHXJ2E2KWMeNOM1WTQ0y9NO/tqoOkrcHLBrtZzbQF7U120sac4PsilAHd4fGQBL8lavzv/khH/uUyrBCs57+fwEROY0g4QZhLYkFA/HEY3uWaslz42u5nmQjScGe/Pp67lWHXHvxh8X7IbrcK6Kj6MutC88Nv3TkYNxXEafHls1wVHdcMmJu4wLq24hXxLkDX+JSYNF6j3xSPTN68KdJ3ogZ5KBuRJ6y7CmnPYWjnIcc05H/KbwZdqxyOVaI1wnmSoxwdCO16L2Mv9UzjRaH/ZuPthpqzwWOVE+Mp40l/YxGg+etmwMp8kXIAu6RrSleZxlZXu5+hQDO3V5CzO/w/gnGcq/RfqRxBORfE3As7Yb3R5GrrubQRjK+Mq3tWvY2Pf52qicwRKn4k+viMjuXHr1x2g4nVTyyIgL4rNfIYtvJqYpaNK3pUo9QkGFuhUg+YznZ4aq7BTbQ52TczXauC/THGQEyQYfRgLqcvzWpDv6DklU9bEHK2czTUN30w92FHwAvLsGmC+9lLsZ8kMkfk1Gk4c8VUMeF61gG57Kkb4nWRRPQkStivc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199021)(71200400001)(33656002)(38100700002)(122000001)(5660300002)(36756003)(2906002)(316002)(38070700005)(8676002)(8936002)(86362001)(66446008)(66556008)(64756008)(41300700001)(66946007)(6916009)(66476007)(4326008)(91956017)(76116006)(2616005)(54906003)(6506007)(186003)(478600001)(26005)(6512007)(6486002)(21314003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <74803F1FFFE1674E9D8A4431348410A7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9867 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 005ea367-2196-4d15-6a70-08db3c399059 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tmt2Vkk13zbk2XzpzPDvL2CZYxbRF2nxw8jJEvIQJW4SkBNzZv4+k80YUy5NCoTrffLUYaYtOj6eG0n6kSm1MSohb2F+U5HLTELAHJZxsYznCL07WdugD/r0m73v061liiSGlx5ObtCxE3EG2aHU+GdkbZM70Blst5hnZki+64ZKokVnDYQoj3BqK3uKWtByhoGtrWZClfY5zSvujxVciKX5AvQklOBjk3oAbGcu+KZwjonV9E8PnZS8k0nVJLiWOQdZH8W7hD4FAQ5gA3lenzRWxprmA4ybfVF0ZCqaehOQsAyt1kdazlj/tNDNDTQCkUOe3Et0DL0JTTRjPOQymTshxEDL5au6WP4by1Q4Zp4Z9lGHiVk7zDxjV12d0GaxIelKgfHz2O3E9XHYdg7VrsKnuECx5fz92tOS6sI+4f0K21QQZA24rvfGIPVr5ojQOFGB6o+NH9q9x2cT9KFo1bI4pcZ0NDYYObfQXwXRKzW5JpUUlZ6KTJMhOrO/em4qDTjAKSNLXpd2dea6W9Yy/4ZCXW+U2QMCIrPDbdgFRYwupj+6b/mUGMMVL8+eCwlAM/Fi9VsVW81Md3RhM/dG9FF38p4rE9Ij7OwjggKyTYXPX6uUBXLxRNiNhyS1G9uwKO/e6fD6cdJr1zcrp6S6ewrqaYkCEktO18MpvafnM/I/bxe33p33rAvVBbGxAeTRIvd5goB5rUH5v5SIKKXxdjh/fw+nNQ5uRm87qAZm3gI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(6486002)(40460700003)(70206006)(70586007)(4326008)(36756003)(2906002)(86362001)(81166007)(82740400003)(356005)(41300700001)(33656002)(5660300002)(82310400005)(8676002)(8936002)(6862004)(316002)(478600001)(40480700001)(54906003)(6512007)(6506007)(26005)(336012)(36860700001)(2616005)(186003)(47076005)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 16:10:27.2496 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98059bcb-7759-4077-3c6f-08db3c39988b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6114 PiANCj4gDQo+PiANCj4+Pj4gQ2FuIHdlIG1vdmUgdGhpcyBzb21ld2hlcmUgZWxzZSB0byBhdm9p ZCBhZGRpbmcgZXh0cmEgcGFkZGluZz8gQWxzbyBzaG91bGRuJ3QgdGhpcyBiZSBwcm90ZWN0ZWQg d2l0aCAjaWZkZWYgQ09ORklHX0FSTV82NCB0byBtYWtlIGNsZWFyIHRoaXMgaXMgbm90IHN1cHBv cnRlZCBvbiBYZW4gMzItYml0Pw0KPj4+IFllcywgSeKAmWxsIG1vdmUgaXQgYW5kIHByb3RlY3Qg d2l0aCBDT05GSUdfQVJNXzY0LCBpcyBpdCBvayBmb3IgeW91IGlmIEkgbW92ZSBpdCBhZnRlcjoN Cj4+PiAvKiBNb25pdG9yIG9wdGlvbnMgKi8NCj4+PiBzdHJ1Y3Qgew0KPj4+ICAgIHVpbnQ4X3Qg cHJpdmlsZWdlZF9jYWxsX2VuYWJsZWQgOiAxOw0KPj4+IH0gbW9uaXRvcjsNCj4+IA0KPj4gUGxl YXNlIGNoZWNrIHRoZSBwYWRkaW5nIHdpdGggInBhaG9sZSIuIElmIHBvc3NpYmxlLCBpdCB3b3Vs ZCBiZSBiZXR0ZXIgdG8gcmUtdXNlIGFuIGV4aXN0aW5nIG9uZS4NCj4gDQo+IE9rIEnigJlsbCB0 cnkgdG8gdXNlIHRoZSB0b29sDQoNCknigJl2ZSBtYW5hZ2VkIHRvIHVzZSB0aGUgdG9vbCwgdGhl IGZpZWxkIHNlZW1zIGFscmVhZHkgaW4gYSBnb29kIHNwb3Q6DQoNCnN0cnVjdCBhcmNoX2RvbWFp biB7DQoJZW51bSBkb21haW5fdHlwZSAgICAgICAgICAgdHlwZTsgICAgICAgICAgICAgICAgIC8q ICAgICAwICAgICA0ICovDQoJdWludDhfdCAgICAgICAgICAgICAgICAgICAgc3ZlX3ZsOyAgICAg ICAgICAgICAgIC8qICAgICA0ICAgICAxICovDQoNCgkvKiBYWFggMyBieXRlcyBob2xlLCB0cnkg dG8gcGFjayAqLw0KDQoJc3RydWN0IHAybV9kb21haW4gICAgICAgICAgcDJtOyAgICAgICAgICAg ICAgICAgIC8qICAgICA4ICAgMzI4ICovDQoJLyogLS0tIGNhY2hlbGluZSA1IGJvdW5kYXJ5ICgz MjAgYnl0ZXMpIHdhcyAxNiBieXRlcyBhZ28gLS0tICovDQoJc3RydWN0IGh2bV9kb21haW4gICAg ICAgICAgaHZtOyAgICAgICAgICAgICAgICAgIC8qICAgMzM2ICAgMzEyICovDQoJLyogLS0tIGNh Y2hlbGluZSAxMCBib3VuZGFyeSAoNjQwIGJ5dGVzKSB3YXMgOCBieXRlcyBhZ28gLS0tICovDQoJ c3RydWN0IHBhZ2luZ19kb21haW4gICAgICAgcGFnaW5nOyAgICAgICAgICAgICAgIC8qICAgNjQ4 ICAgIDMyICovDQoJc3RydWN0IHZtbWlvICAgICAgICAgICAgICAgdm1taW87ICAgICAgICAgICAg ICAgIC8qICAgNjgwICAgIDMyICovDQoJLyogLS0tIGNhY2hlbGluZSAxMSBib3VuZGFyeSAoNzA0 IGJ5dGVzKSB3YXMgOCBieXRlcyBhZ28gLS0tICovDQoJdW5zaWduZWQgaW50ICAgICAgICAgICAg ICAgcmVsX3ByaXY7ICAgICAgICAgICAgIC8qICAgNzEyICAgICA0ICovDQoNCgkvKiBYWFggNCBi eXRlcyBob2xlLCB0cnkgdG8gcGFjayAqLw0KDQoJc3RydWN0IHsNCgkJdWludDY0X3QgICAgICAg ICAgIG9mZnNldDsgICAgICAgICAgICAgICAvKiAgIDcyMCAgICAgOCAqLw0KCQlzX3RpbWVfdCAg ICAgICAgICAgbmFub3NlY29uZHM7ICAgICAgICAgIC8qICAgNzI4ICAgICA4ICovDQoJfSB2aXJ0 X3RpbWVyX2Jhc2U7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qICAgNzIwICAgIDE2 ICovDQoJc3RydWN0IHZnaWNfZGlzdCAgICAgICAgICAgdmdpYzsgICAgICAgICAgICAgICAgIC8q ICAgNzM2ICAgMjAwICovDQoNCgkvKiBYWFggbGFzdCBzdHJ1Y3QgaGFzIDIgYnl0ZXMgb2YgcGFk ZGluZyAqLw0KDQoJLyogLS0tIGNhY2hlbGluZSAxNCBib3VuZGFyeSAoODk2IGJ5dGVzKSB3YXMg NDAgYnl0ZXMgYWdvIC0tLSAqLw0KCXN0cnVjdCB2dWFydCAgICAgICAgICAgICAgIHZ1YXJ0OyAg ICAgICAgICAgICAgICAvKiAgIDkzNiAgICAzMiAqLw0KCS8qIC0tLSBjYWNoZWxpbmUgMTUgYm91 bmRhcnkgKDk2MCBieXRlcykgd2FzIDggYnl0ZXMgYWdvIC0tLSAqLw0KCXVuc2lnbmVkIGludCAg ICAgICAgICAgICAgIGV2dGNobl9pcnE7ICAgICAgICAgICAvKiAgIDk2OCAgICAgNCAqLw0KCXN0 cnVjdCB7DQoJCXVpbnQ4X3QgICAgICAgICAgICBwcml2aWxlZ2VkX2NhbGxfZW5hYmxlZDoxOyAv KiAgIDk3MjogMCAgMSAqLw0KCX0gbW9uaXRvcjsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAvKiAgIDk3MiAgICAgMSAqLw0KDQoJLyogWFhYIDMgYnl0ZXMgaG9sZSwgdHJ5 IHRvIHBhY2sgKi8NCg0KCXN0cnVjdCB2cGwwMTEgICAgICAgICAgICAgIHZwbDAxMTsgICAgICAg ICAgICAgICAvKiAgIDk3NiAgICA3MiAqLw0KDQoJLyogc2l6ZTogMTE1MiwgY2FjaGVsaW5lczog MTgsIG1lbWJlcnM6IDEzICovDQoJLyogc3VtIG1lbWJlcnM6IDEwMzgsIGhvbGVzOiAzLCBzdW0g aG9sZXM6IDEwICovDQoJLyogcGFkZGluZzogMTA0ICovDQoJLyogcGFkZGluZ3M6IDEsIHN1bSBw YWRkaW5nczogMiAqLw0KfSBfX2F0dHJpYnV0ZV9fKChfX2FsaWduZWRfXygxMjgpKSk7DQoNCj4g DQo+PiANCj4+IENoZWVycywNCj4+IA0KPj4gLS0gDQo+PiBKdWxpZW4gR3JhbGwNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520853.808916 (Exim 4.92) (envelope-from ) id 1pn0tW-0000sY-95; Thu, 13 Apr 2023 17:38:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520853.808916; Thu, 13 Apr 2023 17:38:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tW-0000sP-4w; Thu, 13 Apr 2023 17:38:02 +0000 Received: by outflank-mailman (input) for mailman id 520853; Thu, 13 Apr 2023 17:38:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tV-0000a4-4r for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:01 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20626.outbound.protection.outlook.com [2a01:111:f400:7e8c::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee2535ea-da21-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 19:37:59 +0200 (CEST) Received: from BN9PR03CA0953.namprd03.prod.outlook.com (2603:10b6:408:108::28) by MN2PR12MB4343.namprd12.prod.outlook.com (2603:10b6:208:26f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:37:55 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:108:cafe::38) by BN9PR03CA0953.outlook.office365.com (2603:10b6:408:108::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 17:37:55 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.33 via Frontend Transport; Thu, 13 Apr 2023 17:37:55 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:37:54 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:37:53 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee2535ea-da21-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tf+hTJOTwnRQItM+0d9OL6rf+uqcqFfFY8B3hFtgght/vCOqFTiUl4X0OTy0K3oe7sADIjbffvBBBStswj6hogWzeiTjaap1mNC6F7sR/rUWASzit3f+XyW+dIuopljfr7Vq6TLjeJ0NvPNoOUgiw3ZO1EbSzc8a42plAL/igTHQNS6C/jmj+hoV+HCJEqefOz983DZwLGcYs+dY/5mcf7yEFP5VemhgwOR/b5ng5wTMEBk/pZL1/xy0XWyVifD7p/QjfpX8v1X8FvR2N1+jdtZS6BODYSlRbHvuovO2gYPTK28sySBVpp8HR3PbyBtyc/1EK2IDfOJfUBIUt7g7ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QaWVuZvjIQT6qz1jrl/Hs9hItflDrISzlZiBLoKD23Y=; b=NEUCe6ByQVb5PrMDbGElKhQrITSDKEHbRwtX8bjZo/RI/h7njFhybD8KBGJawUCSiQvEKx4byUSRTM6Tl+DLwG6FeuJksTVFQT6SpRUIUTrC6RPS7SmNV3FGl5vDLHo6uCEeT0ObrPMpE3Q3a1kHjFKJyFxu6InndeFEFIYNpSnWX3KGp58oEJcUxGKNdDigEg8EB69Sy3SFS9kqGgSubcCmUIA61glU+JFuD5eu10DbMabt9dW/ZpEqPdGwXsdHfRDbuy/MsLgyomILs41NikUIyuF9SHmhhXdPz0w7BOjPbjCIJjMyp5jsEzANTrrLQv3tTYLHWhWH3MOrXfjD3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QaWVuZvjIQT6qz1jrl/Hs9hItflDrISzlZiBLoKD23Y=; b=kS9duPNvN38Fih7IQ9M6X2HKpaUg0SbzuqXORINOQhk6stZ6mQpEeYYvuFhGQjXu2KOebS3W1colCLvVGX4qsgEgn7UFBmP9FEEPt6LzAufDSGLZqQlUll6NdKL0nLy4LJuUK8FnR2FU90nqL8Jo4mKRoBV98COjxOXUzFG2byU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 02/10] xen/arm: Typecast the DT values into paddr_t Date: Thu, 13 Apr 2023 18:37:27 +0100 Message-ID: <20230413173735.48387-3-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|MN2PR12MB4343:EE_ X-MS-Office365-Filtering-Correlation-Id: 56f16cf2-22ed-4bf8-c163-08db3c45d0a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l/ZiAlgGXaOYtpDMdgJKswLeprohb+3vZgBiSE0Wf2KqO2NbXmOJ0Y45107MH0fM/dphPxMdzpmT9tqvWCISGClSxuBCsn6Hgl6ZtJe/1ciiV3/RsFtIyMJJ0gsmSbTD1u8/RalZfXiyKDCVTKVBy+kqwXFgBlD38vEBNZ89eTTWd2ezb18UBXJqJIpJYTIuRH/gJoCiQY+Upmf/G7A7n1heG5KkHtZOEEFeIDV95fkOIuyo2VQ1PNdIW5USzs1OROQTxBB5kUAVnq0UKrNtMKJYV/uTACyyOG5XZeIWgjIJE5kU6VaAxwRnFljlOYR2ivmYe/BryGzbrXjGTEZ9SqL/LAb6xIyfqULWhBpeaSA4XnK3vKYUMMAJUR8QXPjABAdz08SqtkVSvKxu+Etp0s2deaZdG1lzJd0POBZU9cSZR30s9GCWR4ir4FhQcXKSooGa6YcU6uyjOtF1v/3ehnp//oBFyIB2HLAg3ObzzjCqndfuBWHsQW2i9F8gfuYoACGWzYrR4HLNHay0JI0kgAAPVWvDMcLkCH0fsABCaO2no+v/zPxoI64vbJ6wiKyyHJj/ljBIpTFV8MWLQP3GQ3h9Sn8xKRE4QzZE1xkjktfCTAQreuvT/lLdfe57skoJ8emEeTjXJ/oojFYH5esZlZYOUtBarDzvLMQqvQwEHgAkSJFAGdbPzoYvDhKUBFm++YsUKUSj25rJOvYygbVeFoF2M5nBKhOqkMTLpGh3j1c= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199021)(36840700001)(40470700004)(46966006)(316002)(6916009)(4326008)(82740400003)(70206006)(70586007)(2616005)(47076005)(426003)(336012)(5660300002)(41300700001)(82310400005)(6666004)(36756003)(86362001)(40460700003)(54906003)(40480700001)(26005)(186003)(1076003)(103116003)(2906002)(83380400001)(30864003)(7416002)(8676002)(8936002)(36860700001)(478600001)(356005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:37:55.3350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56f16cf2-22ed-4bf8-c163-08db3c45d0a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4343 The DT functions (dt_read_number(), device_tree_get_reg(), fdt_get_mem_rsv()) currently accept or return 64-bit values. In future when we support 32-bit physical address, these DT functions are expected to accept/return 32-bit or 64-bit values (depending on the width of physical address). Also, we wish to detect if any truncation has occurred (i.e. while parsing 32-bit physical addresses from 64-bit values read from DT). device_tree_get_reg() should now be able to return paddr_t. This is invoked by various callers to get DT address and size. For fdt_get_mem_rsv(), we have introduced a wrapper named fdt_get_mem_rsv_paddr() which will invoke fdt_get_mem_rsv() and translate uint64_t to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as it has been imported from external source. For dt_read_number(), we have also introduced a wrapper named dt_read_paddr() dt_read_paddr() to read physical addresses. We chose not to modify the original function as it is used in places where it needs to specifically read 64-bit values from dt (For e.g. dt_property_read_u64()). Xen prints warning when it detects truncation in cases where it is not able to return error. Also, replaced u32/u64 with uint32_t/uint64_t in the functions touched by the code changes. Also, initialized variables to fix the warning "-Werror=maybe-uninitialized". Signed-off-by: Ayan Kumar Halder --- Changes from v1 - 1. Dropped "[XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t" and "[XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t", instead this approach achieves the same purpose. 2. No need to check for truncation while converting values from u64 to paddr_t. v2 - 1. Use "( (dt_start >> (PADDR_SHIFT - 1)) > 1 )" to detect truncation. 2. Introduced libfdt_xen.h to implement fdt_get_mem_rsv_paddr 3. Logged error messages in case truncation is detected. v3 - 1. Renamed libfdt_xen.h to libfdt-xen.h. 2. Replaced u32/u64 with uint32_t/uint64_t 3. Use "(paddr_t)val != val" to check for truncation. 4. Removed the alias "#define PADDR_SHIFT PADDR_BITS". v4 - 1. Added a WARN() when truncation is detected. 2. Always check the return value of fdt_get_mem_rsv(). xen/arch/arm/bootfdt.c | 48 +++++++++++++++++++------ xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/include/asm/setup.h | 4 +-- xen/arch/arm/setup.c | 18 +++++----- xen/arch/arm/smpboot.c | 2 +- xen/include/xen/device_tree.h | 23 ++++++++++++ xen/include/xen/libfdt/libfdt-xen.h | 55 +++++++++++++++++++++++++++++ 7 files changed, 129 insertions(+), 23 deletions(-) create mode 100644 xen/include/xen/libfdt/libfdt-xen.h diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0085c28d74..ac8148da55 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include #include @@ -52,11 +52,37 @@ static bool __init device_tree_node_compatible(const void *fdt, int node, return false; } -void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, - u32 size_cells, u64 *start, u64 *size) +void __init device_tree_get_reg(const __be32 **cell, uint32_t address_cells, + uint32_t size_cells, paddr_t *start, + paddr_t *size) { - *start = dt_next_cell(address_cells, cell); - *size = dt_next_cell(size_cells, cell); + uint64_t dt_start, dt_size; + + /* + * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit. + * Thus, there is an implicit cast from uint64_t to paddr_t. + */ + dt_start = dt_next_cell(address_cells, cell); + dt_size = dt_next_cell(size_cells, cell); + + if ( dt_start != (paddr_t)dt_start ) + { + printk("Error: Physical address greater than max width supported\n"); + WARN(); + } + + if ( dt_size != (paddr_t)dt_size ) + { + printk("Error: Physical size greater than max width supported\n"); + WARN(); + } + + /* + * Xen will truncate the address/size if it is greater than the maximum + * supported width and it will give an appropriate warning. + */ + *start = dt_start; + *size = dt_size; } static int __init device_tree_get_meminfo(const void *fdt, int node, @@ -326,7 +352,7 @@ static int __init process_chosen_node(const void *fdt, int node, printk("linux,initrd-start property has invalid length %d\n", len); return -EINVAL; } - start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); + start = dt_read_paddr((void *)&prop->data, dt_size_to_cells(len)); prop = fdt_get_property(fdt, node, "linux,initrd-end", &len); if ( !prop ) @@ -339,7 +365,7 @@ static int __init process_chosen_node(const void *fdt, int node, printk("linux,initrd-end property has invalid length %d\n", len); return -EINVAL; } - end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); + end = dt_read_paddr((void *)&prop->data, dt_size_to_cells(len)); if ( start >= end ) { @@ -593,10 +619,12 @@ static void __init early_print_info(void) nr_rsvd = fdt_num_mem_rsv(device_tree_flattened); for ( i = 0; i < nr_rsvd; i++ ) { - paddr_t s, e; - if ( fdt_get_mem_rsv(device_tree_flattened, i, &s, &e) < 0 ) + paddr_t s = 0, e = 0; + + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, i, &s, &e) < 0 ) continue; - /* fdt_get_mem_rsv returns length */ + + /* fdt_get_mem_rsv_paddr returns length */ e += s; printk(" RESVD[%u]: %"PRIpaddr" - %"PRIpaddr"\n", i, s, e); } diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c8f08d8ee2..15c8bdd9e4 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -949,7 +949,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, BUG_ON(!prop); cells = (const __be32 *)prop->value; device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); - psize = dt_read_number(cells, size_cells); + psize = dt_read_paddr(cells, size_cells); if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) { printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..7b697d879e 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -157,8 +157,8 @@ const char *boot_module_kind_as_string(bootmodule_kind kind); extern uint32_t hyp_traps_vector[]; void init_traps(void); -void device_tree_get_reg(const __be32 **cell, u32 address_cells, - u32 size_cells, u64 *start, u64 *size); +void device_tree_get_reg(const __be32 **cell, uint32_t address_cells, + uint32_t size_cells, paddr_t *start, paddr_t *size); u32 device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90..d2a3d8c340 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -29,7 +29,7 @@ #include #include #include -#include +#include #include #include #include @@ -220,13 +220,13 @@ static void __init dt_unreserved_regions(paddr_t s, paddr_t e, for ( i = first; i < nr ; i++ ) { - paddr_t r_s, r_e; + paddr_t r_s = 0, r_e = 0; - if ( fdt_get_mem_rsv(device_tree_flattened, i, &r_s, &r_e ) < 0 ) + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, i, &r_s, &r_e ) < 0 ) /* If we can't read it, pretend it doesn't exist... */ continue; - r_e += r_s; /* fdt_get_mem_rsv returns length */ + r_e += r_s; /* fdt_get_mem_rsv_paddr returns length */ if ( s < r_e && r_s < e ) { @@ -500,15 +500,15 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, for ( ; i < mi->nr_mods + nr; i++ ) { - paddr_t mod_s, mod_e; + paddr_t mod_s = 0, mod_e = 0; - if ( fdt_get_mem_rsv(device_tree_flattened, - i - mi->nr_mods, - &mod_s, &mod_e ) < 0 ) + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, + i - mi->nr_mods, + &mod_s, &mod_e ) < 0 ) /* If we can't read it, pretend it doesn't exist... */ continue; - /* fdt_get_mem_rsv returns length */ + /* fdt_get_mem_rsv_paddr returns length */ mod_e += mod_s; if ( s < mod_e && mod_s < e ) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 412ae22869..c15c177487 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -159,7 +159,7 @@ static void __init dt_smp_init_cpus(void) continue; } - addr = dt_read_number(prop, dt_n_addr_cells(cpu)); + addr = dt_read_paddr(prop, dt_n_addr_cells(cpu)); hwid = addr; if ( hwid != addr ) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 19a74909ce..11bda2fd3d 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -241,6 +241,29 @@ static inline u64 dt_read_number(const __be32 *cell, int size) return r; } +/* Wrapper for dt_read_number() to return paddr_t (instead of uint64_t) */ +static inline paddr_t dt_read_paddr(const __be32 *cell, int size) +{ + uint64_t dt_r = 0; + paddr_t r; + + dt_r = dt_read_number(cell, size); + + if ( dt_r != (paddr_t)dt_r ) + { + printk("Error: Physical address greater than max width supported\n"); + WARN(); + } + + /* + * Xen will truncate the address/size if it is greater than the maximum + * supported width and it will give an appropriate warning. + */ + r = dt_r; + + return r; +} + /* Helper to convert a number of cells to bytes */ static inline int dt_cells_to_size(int size) { diff --git a/xen/include/xen/libfdt/libfdt-xen.h b/xen/include/xen/libfdt/libfdt-xen.h new file mode 100644 index 0000000000..3296a368a6 --- /dev/null +++ b/xen/include/xen/libfdt/libfdt-xen.h @@ -0,0 +1,55 @@ +/* + * SPDX-License-Identifier: GPL-2.0-only + * + * xen/include/xen/libfdt/libfdt-xen.h + * + * Wrapper functions for device tree. This helps to convert dt values + * between uint64_t and paddr_t. + * + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. + */ + +#ifndef LIBFDT_XEN_H +#define LIBFDT_XEN_H + +#include + +static inline int fdt_get_mem_rsv_paddr(const void *fdt, int n, + paddr_t *address, + paddr_t *size) +{ + uint64_t dt_addr; + uint64_t dt_size; + int ret = 0; + + ret = fdt_get_mem_rsv(fdt, n, &dt_addr, &dt_size); + if ( ret ) + return ret; + + if ( dt_addr != (paddr_t)dt_addr ) + { + printk("Error: Physical address greater than max width supported\n"); + return -FDT_ERR_MAX; + } + + if ( dt_size != (paddr_t)dt_size ) + { + printk("Error: Physical size greater than max width supported\n"); + return -FDT_ERR_MAX; + } + + *address = dt_addr; + *size = dt_size; + + return ret; +} + +#endif /* LIBFDT_XEN_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520852.808905 (Exim 4.92) (envelope-from ) id 1pn0tI-0000aI-Sa; Thu, 13 Apr 2023 17:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520852.808905; Thu, 13 Apr 2023 17:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tI-0000aB-Pr; Thu, 13 Apr 2023 17:37:48 +0000 Received: by outflank-mailman (input) for mailman id 520852; Thu, 13 Apr 2023 17:37:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tH-0000a4-5P for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:37:47 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20617.outbound.protection.outlook.com [2a01:111:f400:fe5b::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e56df47a-da21-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 19:37:44 +0200 (CEST) Received: from BN1PR12CA0015.namprd12.prod.outlook.com (2603:10b6:408:e1::20) by DM4PR12MB5793.namprd12.prod.outlook.com (2603:10b6:8:60::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:37:41 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::40) by BN1PR12CA0015.outlook.office365.com (2603:10b6:408:e1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:37:41 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:37:41 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:37:40 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 10:37:40 -0700 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:37:38 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e56df47a-da21-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SQWmIdc2SKkD4LjHcrpjH3iWug6JZo3LuEg+yHwHO8Dp4K37seXaYYoAmuo3AW+bjrIs43Ocr0g0I96tU/xVBAaazLInjwJYIM4Hdq1lVnJAVBNMbXghR5qzEEZ3ZQNVxMimsEZ1NghNw90hkW+THc6sQWXMyURCSuuK95RhNCZ2eY1+3dw8FZeZeV5JZUIb7IuFsMpcR5VCdGspOe0oAmNiLvZE6CP4nTngtW8/8CWrLL8zCB35oLqhwOVWzTIHYb4qq+PetKEfoM493x7vh71SjE11pmo2ort2YUXGQUzzgYZNNyEVGu34Q3/NIHRR5a8QdhNadXO3NYbsfjGVkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s1VKaqIv1xUd9qTOea23vuzeYmLFJZeuxTrWrpWWn/U=; b=EP3VsEOyWh5wVLDKMkbwbK/DunA/HG6Rh8LVdojSuxAMqU2B7Nl/BtGA7IKn+kJvYyoCl+gQtHpB3PdE1DdA5RbozB3SppDSAgtukixX/miW+ZletGyN0/j4HpVhJ/Zp+Q/VwUPAZ8el+y8c52Kh+3EaIWTN4Li73hue+HW+W9+XCq53xHFNC8MslPHN4e4zFqPZJChPyZIq1PzXqMfPUEOGt37ets9SjBObg0lkinm+cgZaOpOIgydNAGQMXXI7S5c5X2vWqtVp6Oi8QMTptShoc8wAMl4NymG//Q7pvmIwetF06ekJasTaYYSiDutbnLtBxzUNE7Z47KzZfSuiQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s1VKaqIv1xUd9qTOea23vuzeYmLFJZeuxTrWrpWWn/U=; b=f4pCpH/PX3J4GDai+2cAEWLUB3lVvyiU/BPUkmJcwv+/rVN0V4zpEX5bFI7K8JCctRpVyQ/JbDiQt9SxCDgQ/d60RZhPyoh/xf5O0Xve9YL1jyskim1p23vcQgyAmiHl8yWQev3EgkVMvz0OrrrqxKqG3cxb/20N5cg7L1PmkrM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 00/10] Add support for 32-bit physical address Date: Thu, 13 Apr 2023 18:37:25 +0100 Message-ID: <20230413173735.48387-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|DM4PR12MB5793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c3edd7f-2df5-48e5-c423-08db3c45c81d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0tmH1vaMOZyUTJXOaX3BB4fCLIfJpCgCq4CHZxGbq6xpmI6th4eCFP4sRqwkDmDY4pSFRkrnuSTofX09LHm3CjcLY/sjsWyvjtjKxjquXa54iwWWWm3382Lq5pjlJWwWk3MOJLOiXZy8UDQdlac7xPJ51f+xHGkI1Pe4FYIf9f4L2fudMqv147iy20IIf7mv+/IThLDdUauof4y6ftRDKVm8i+o1bab/c5N00ondUi74QV/vbVZSEb78jmLKhh5ueQE5TJHnde4RwIBnp/pq0EO+DzdIeH5L1oGGngBtK+yCfENC4PwXeVTZ9rNbftjxt6jtC/Ic7Ggbt8DjfVd9poIegISERIQB7BV9ADQFPble7WbHbGbBCbbiym6S/grYKHTZkGfzsetX6FDn21nV4diVXuK+7nNT42sZosEbDYIP3x8OPHKVFcVRZSleWIGKGV3XYE3gB41KRQd2DM1/WSHTYJXONdcCXDw3FUIeqq7FaCLM9C7zPPssndAdH6gaYyPpFx+k8NVepaf8B7oqbrYVQL7U9l9cQxkbc/AZzBpUqy1ibMD1VajafiSjSVwZZ9VTseul1ykNfn4kNLfx4Loq/PTjv6qVbwlF7YKsewt6LoioMG62pBtunocJPX1iYWJhEDF0QtocI84e+86s93McYR+GLnXt02YACKzB7A5y6IghCHJZQjiWMxjCI1wEcfDfiqIMZ7lqxJxNAgvDLQEDPzNO/Adl6bZkb2jSlB7LU2+ytiATotBBfMglUmsuZay/WdgnupXU0oL4tNP8GQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(316002)(41300700001)(81166007)(1076003)(26005)(966005)(186003)(86362001)(6666004)(47076005)(356005)(36860700001)(2616005)(82310400005)(426003)(336012)(83380400001)(82740400003)(6916009)(4326008)(54906003)(36756003)(40480700001)(70206006)(70586007)(8676002)(8936002)(5660300002)(2906002)(7416002)(103116003)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:37:41.0401 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c3edd7f-2df5-48e5-c423-08db3c45c81d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5793 Hi All, Please have a look at https://lists.xenproject.org/archives/html/xen-devel/2022-11/msg01465.html for the context. The benefits of using 32 bit physical addresses are as follows :- 1. It helps to use Xen on platforms (for eg R52) which supports 32-bit physical addresses and has no support for large physical address extension. On 32-bit MPU systems which supports flat-mapping (for eg R52), it helps to translate 32 bit VA into 32 bit PA. 2. It also helps in code optimization when the underlying platform does not use large physical address extension. The following points are to be noted :- 1. Device tree always use uint64_t for address and size. The caller needs to translate between uint64_t and uint32_t (when 32 bit physical addressing is used). 2. Currently, we have enabled this option for Arm_32 as the MMU for Arm_64 uses 48-bit physical addressing. 3. https://lists.xenproject.org/archives/html/xen-devel/2022-12/msg00117.html has been added to this series. Changes from : v1 - 1. Reordered the patches such that the first three patches fixes issues in the existing codebase. These can be applied independent of the remaining patches in this serie. 2. Dropped translate_dt_address_size() for the address/size translation between paddr_t and u64 (as parsed from the device tree). Also, dropped the check for truncation (while converting u64 to paddr_t). Instead now we have modified device_tree_get_reg() and typecasted the return for dt_read_number(), to obtain paddr_t. Also, introduced wrappers for fdt_get_mem_rsv() and dt_device_get_address() for the same purpose. These can be found in patch 4/11 and patch 6/11. 3. Split "Other adaptations required to support 32bit paddr" into the following individual patches for each adaptation : xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_ARM_PA_32" 4. Introduced "xen/arm: p2m: Enable support for 32bit IPA". v2 - 1. Dropped patches 1/11, 2/11 and 3/11 from the v2 as it has already been committed (except 2/11 - "[XEN v5] xen/arm: Use the correct format specifier" which is waiting to be committed). 2. Introduced a new patch "xen/drivers: ns16550: Use paddr_t for io_base/io_size". v3 - 1. Combined the patches from https://lists.xenproject.org/archives/html/xen-devel/2023-02/msg00656.html in this series. v4 - 1. Dropped "xen/drivers: ns16550: Use paddr_t for io_base/io_size" from the patch series. As Jan (jbeulich@suse.com) had pointed out in https://lore.kernel.org/xen-devel/20230321140357.24094-5-ayan.kumar.halder@amd.com/, ns16550 driver requires some prior cleanup. Also, ns16550 can be ignored for now for the 32-bit paddr support (which is mainly targeted for Arm). I will send out separate patches to fix this once the current serie is committed (or in ready to commit state). I hope that is fine with Jan ? 2. Introduced "xen/arm: domain_build: Check if the address fits the range of physical address". 3. "xen/arm: Use the correct format specifier" has been committed in v4. Ayan Kumar Halder (10): xen/arm: domain_build: Track unallocated pages using the frame number xen/arm: Typecast the DT values into paddr_t xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 xen/arm: Introduce choice to enable 64/32 bit physical addressing xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_PHYS_ADDR_T_32" xen/arm: Restrict zeroeth_table_offset for ARM_64 xen/arm: domain_build: Check if the address fits the range of physical address xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64 xen/arm: p2m: Enable support for 32bit IPA for ARM_32 xen/arch/Kconfig | 3 + xen/arch/arm/Kconfig | 37 +++++++++++- xen/arch/arm/bootfdt.c | 48 ++++++++++++---- xen/arch/arm/domain_build.c | 67 +++++++++++++++------- xen/arch/arm/gic-v2.c | 10 ++-- xen/arch/arm/gic-v3-its.c | 4 +- xen/arch/arm/gic-v3.c | 10 ++-- xen/arch/arm/guest_walk.c | 2 + xen/arch/arm/include/asm/lpae.h | 4 ++ xen/arch/arm/include/asm/p2m.h | 8 +-- xen/arch/arm/include/asm/page-bits.h | 6 +- xen/arch/arm/include/asm/setup.h | 4 +- xen/arch/arm/include/asm/types.h | 6 ++ xen/arch/arm/mm.c | 12 ++-- xen/arch/arm/p2m.c | 35 +++++------ xen/arch/arm/pci/pci-host-common.c | 6 +- xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- xen/arch/arm/platforms/brcm.c | 6 +- xen/arch/arm/platforms/exynos5.c | 32 +++++------ xen/arch/arm/platforms/sunxi.c | 2 +- xen/arch/arm/platforms/xgene-storm.c | 2 +- xen/arch/arm/setup.c | 18 +++--- xen/arch/arm/smpboot.c | 2 +- xen/common/device_tree.c | 35 +++++++++++ xen/drivers/char/cadence-uart.c | 4 +- xen/drivers/char/exynos4210-uart.c | 4 +- xen/drivers/char/imx-lpuart.c | 4 +- xen/drivers/char/meson-uart.c | 4 +- xen/drivers/char/mvebu-uart.c | 4 +- xen/drivers/char/omap-uart.c | 4 +- xen/drivers/char/pl011.c | 6 +- xen/drivers/char/scif-uart.c | 4 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 +-- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 23 ++++---- xen/include/xen/device_tree.h | 36 ++++++++++++ xen/include/xen/libfdt/libfdt-xen.h | 55 ++++++++++++++++++ 37 files changed, 369 insertions(+), 150 deletions(-) create mode 100644 xen/include/xen/libfdt/libfdt-xen.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520854.808926 (Exim 4.92) (envelope-from ) id 1pn0tX-00018O-IR; Thu, 13 Apr 2023 17:38:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520854.808926; Thu, 13 Apr 2023 17:38:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tX-00018H-FR; Thu, 13 Apr 2023 17:38:03 +0000 Received: by outflank-mailman (input) for mailman id 520854; Thu, 13 Apr 2023 17:38:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tW-0000rf-GV for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:02 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062c.outbound.protection.outlook.com [2a01:111:f400:fe5a::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecbbc965-da21-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:37:57 +0200 (CEST) Received: from BN9PR03CA0958.namprd03.prod.outlook.com (2603:10b6:408:108::33) by DM6PR12MB4202.namprd12.prod.outlook.com (2603:10b6:5:219::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 17:37:51 +0000 Received: from BN8NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:408:108:cafe::4d) by BN9PR03CA0958.outlook.office365.com (2603:10b6:408:108::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:37:50 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT044.mail.protection.outlook.com (10.13.177.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:37:50 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:37:50 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:37:48 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecbbc965-da21-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIIaANzpNZ7sR6SWB3wWxHB3yCmB4NanzJ67NrzqA3YpabBLdiWjjRb39fjG59mT43FtC/SgKuNkCyj5nQ/Nq6ffEu8A3PXth3GyHFS2rDiE5Ahnsj2rbm/lZ4+iSQMlw0gzWKCwklGAUeb3fhWKL7zokfmxMDXPMqzHEcHBJrsTJZnfG3DCrKhLqQ6MCF6+PImincO+yO+UoKXtjEUOLj3Jwl5Ka8iW/9v+z9EvRTkRGjPqkzlS6ei7aXSHq/ed7NFzFeGx6eKDSIpvq2FEqHaA3kB0ya3/KjLubx97pABg9LMoD/QB9wsnTE5Y6tVJPg8pXy2PY3ytAfhuZWKx1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0wU8LetK/R9TLjWfaj0Ei8tmEBa20JjFHMWBU/8feQ=; b=S0I/hG9O6rQL6tFs0vSYCXMHCzvOTq5PMJxcvocIbENWnsg8of6C9BCo+2j5tquc0qXrkzRDbzbuS4yd6qcBDluuy+VdT9uLmgi8/kkzr/ri4FJ38m/SpsceGdSjUpf0Ho2NFlCp1x3WLbqwwuJsywRPQGeTKohQU1V6zpnLeRYrt6fJ8tgFztQDZaiN/vk53ak0NKKolQpKR7F9O90BtfKoO0jGPQMPL8LE9j+bXkxdCgDBbqDSfhxZkzwdNBV7/pD0Dgp4FUDUFq1Ub87qVJ2fEzdB0JF1RqvJlUzdSsvd5BS40/EVVhAKb3CznqP1yPRtInC9GqfU7eHHjXhxiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0wU8LetK/R9TLjWfaj0Ei8tmEBa20JjFHMWBU/8feQ=; b=gVSj9zJMEzq3VGqgrDqDbbLWPo9wLAFioxbxhxUezt8zdRd9vIWrfvzDxAHN5Axll8uTiAefe8xlwLF3kAA7+CViIjyPftPrjI1g0FoKXmFM6GUzssnRC1k5WcDx4V5FGdapFLqs2GX2Lu25fbaKYEXgTRFxrJSFYCO3XB0N3Ho= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 01/10] xen/arm: domain_build: Track unallocated pages using the frame number Date: Thu, 13 Apr 2023 18:37:26 +0100 Message-ID: <20230413173735.48387-2-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT044:EE_|DM6PR12MB4202:EE_ X-MS-Office365-Filtering-Correlation-Id: 8945d385-c3ad-4b0c-a44b-08db3c45cdc4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WxOROidkwfJIIDo5gTWo8XScyTi5Uc7QriwwU1I31OMjNkI2xaLlDG1/ldBxFh5CKjf6h/D7EuA0yRIVAj3p4cu0aBu022IlFYTInym+ef3kp4b9nF6hWZ4uJB71cYPyB0IwO+49mBpYuoP9uXaFFelETJnuH8VNl1cPnhUBX7t94JGxCX3kvF6PbxMbAPWjJcH4ARh4JqAxmeD91Ve7H8U5PPS15qfDgwl/TC0W6+7G01pD+xWH/M0BeqdMBpOfjCXqzzdPFGo1u1/gWZOgLLbeCunO2PtMx2CF5XQ4HHgjKhWpf8i1W3rB/lcnUgHVZ/htd8y8ViKEoFc713TxQoRB42Um3aGq7naV2oZW7Z7RvZMDlyaRemIdHOJjan1yvoOiXA/CRqo1/myldWMU+kCWL4Ir9E26iXYIFY7pJMonc1fYFmYJp5z1HA3FHNeWCmKx0owupbzh2hcRlod14AEakPPyBqazziLlHyzYmQGGGh/dbG3uD79BLzaXv6Cmn6+vsgXvB+KbxoYoZu9Yk51OHR9z6fKf+W7BipUkQsGWd+9+9NcnoK6EKqoviyFRVOJXPGPvfY+o+QJ0oCZtd0Z7SsuPpLADREI8NwxWtzvrkdlrNKkdZNo0FxM/T+nZIweZUIlsxeSV11zjfpJIzWsmkBhxRbmpBosskyLlUhFx0Ui2v5qCJvwb8cdYja5hs4lvPfQ7Fv35JJz3pBWdoNgTQ0sS4Fm1hXt8QdvNgO1GK2wVH3cQHKryscQwEHos X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199021)(40470700004)(46966006)(36840700001)(82310400005)(5660300002)(7416002)(8936002)(41300700001)(103116003)(40460700003)(83380400001)(6916009)(4326008)(8676002)(70206006)(2906002)(70586007)(6666004)(36756003)(316002)(966005)(47076005)(478600001)(54906003)(356005)(86362001)(81166007)(36860700001)(26005)(186003)(426003)(336012)(1076003)(40480700001)(82740400003)(2616005)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:37:50.5214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8945d385-c3ad-4b0c-a44b-08db3c45cdc4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4202 rangeset_{xxx}_range() functions are invoked with 'start' and 'size' as arguments which are either 'uint64_t' or 'paddr_t'. However, the function accepts 'unsigned long' for 'start' and 'size'. 'unsigned long' is 32 bits for Arm32. Thus, there is an implicit downcasting from 'uint64_t'/'paddr_t' to 'unsigned long' when invoking rangeset_{xxx}_range(). So, it may seem there is a possibility of lose of data due to truncation. In reality, 'start' and 'size' are always page aligned. And Arm32 currently supports 40 bits as the width of physical address. So if the addresses are page aligned, the last 12 bits contain zeroes. Thus, we could instead pass page frame number which will contain 28 bits (40-12 on Arm32) and this can be represented using 'unsigned long'. On Arm64, this change will not induce any adverse side effect as the width of physical address is 48 bits. Thus, the width of 'gfn' (ie 48 - 12 = 36) can be represented using 'unsigned long' (which is 64 bits wide). Signed-off-by: Ayan Kumar Halder --- Changes from - v3 - 1. Extracted the patch from https://lists.xenproject.org/archives/html/xen-devel/2023-02/msg00657.html and added it to this series. 2. Modified add_ext_regions(). This accepts a frame number instead of physical address. v4 - 1. Reworded the commit message to use Arm32/Arm64 (32-bit/64-bit Arm architecture). 2. Replaced pfn with gfn to denote guest frame number in add_ext_regions(). 3. Use pfn_to_paddr() to return a physical address from the guest frame number. xen/arch/arm/domain_build.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4f9d4f9d88..c8f08d8ee2 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1500,10 +1500,13 @@ static int __init make_resv_memory_node(const struct domain *d, return res; } -static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) +static int __init add_ext_regions(unsigned long s_gfn, unsigned long e_gfn, + void *data) { struct meminfo *ext_regions = data; paddr_t start, size; + paddr_t s = pfn_to_paddr(s_gfn); + paddr_t e = pfn_to_paddr(e_gfn); if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) ) return 0; @@ -1566,7 +1569,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, { start = bootinfo.mem.bank[i].start; end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size; - res = rangeset_add_range(unalloc_mem, start, end - 1); + res = rangeset_add_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1580,7 +1584,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, { start = assign_mem->bank[i].start; end = assign_mem->bank[i].start + assign_mem->bank[i].size; - res = rangeset_remove_range(unalloc_mem, start, end - 1); + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1595,7 +1600,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, start = bootinfo.reserved_mem.bank[i].start; end = bootinfo.reserved_mem.bank[i].start + bootinfo.reserved_mem.bank[i].size; - res = rangeset_remove_range(unalloc_mem, start, end - 1); + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1607,7 +1613,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, /* Remove grant table region */ start = kinfo->gnttab_start; end = kinfo->gnttab_start + kinfo->gnttab_size; - res = rangeset_remove_range(unalloc_mem, start, end - 1); + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1617,7 +1623,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, start = 0; end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_report_ranges(unalloc_mem, start, end, + res = rangeset_report_ranges(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end), add_ext_regions, ext_regions); if ( res ) ext_regions->nr_banks = 0; @@ -1639,7 +1645,7 @@ static int __init handle_pci_range(const struct dt_device_node *dev, start = addr & PAGE_MASK; end = PAGE_ALIGN(addr + len); - res = rangeset_remove_range(mem_holes, start, end - 1); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1677,7 +1683,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, /* Start with maximum possible addressable physical memory range */ start = 0; end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_add_range(mem_holes, start, end); + res = rangeset_add_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end)); if ( res ) { printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1708,7 +1714,8 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, start = addr & PAGE_MASK; end = PAGE_ALIGN(addr + size); - res = rangeset_remove_range(mem_holes, start, end - 1); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1735,7 +1742,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, start = 0; end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_report_ranges(mem_holes, start, end, + res = rangeset_report_ranges(mem_holes, PFN_DOWN(start), PFN_DOWN(end), add_ext_regions, ext_regions); if ( res ) ext_regions->nr_banks = 0; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520855.808936 (Exim 4.92) (envelope-from ) id 1pn0tj-0001bG-1M; Thu, 13 Apr 2023 17:38:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520855.808936; Thu, 13 Apr 2023 17:38:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0ti-0001b9-TM; Thu, 13 Apr 2023 17:38:14 +0000 Received: by outflank-mailman (input) for mailman id 520855; Thu, 13 Apr 2023 17:38:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tg-0000a4-MG for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:12 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061b.outbound.protection.outlook.com [2a01:111:f400:7eab::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4dd232e-da21-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 19:38:11 +0200 (CEST) Received: from BN9P221CA0015.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::20) by IA1PR12MB6162.namprd12.prod.outlook.com (2603:10b6:208:3ea::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:38:06 +0000 Received: from BN8NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::83) by BN9P221CA0015.outlook.office365.com (2603:10b6:408:10a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:06 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT038.mail.protection.outlook.com (10.13.176.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:06 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:06 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 10:38:05 -0700 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:04 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4dd232e-da21-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FjnpaNQgeB09VBLKGlQ0sJYvmiqhGvzsDcXao1Us+0osoovi2UxchVODf3IE99rXyTLOvALePYHeEZZntRIGG3OrFo89SzaCgTWlB8+Hf5yabx++zGe8dEtSef9yKxdm+OyX/b/0snNmMX7XH/7ik846ZhwI+PK/R/3WHYvN5OPz9l3xhckc+3bIkbv2wWsnJ/9Qd/2qQ54uY7EXqbHkBkGCAyKClcrHm/rPdQHC1pXijH0of69Amg2iaA4+ry1liM9fpZYkKkhHofEJy9ZKVokUxYVz0NeU2tYKX5meUIMbiE7JNmjoLughKZo+lCKYFLhFn+/VvcjM601epKRoJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C+5czMOChY06NbD7GBIlDCpf1fZosY+JcIjRqcYf2ok=; b=lEBn6g3F4vf0MU4cSvu8Fm6UhrsVHmjAxej8vUnPldlccjfyqAnpn/RjHx8S7A4tsE5uFJmEuMjKFYBtynHyYZrHwrN1Mx5RMBBxNgXsEyh2VeeoCJ4LOU0TQaqe3Lu041cHZR7VzLPBZtat/7TSz0LMX9KVvLvSn/1oVDM9wDWtvhs/79atYga1GMeRFLNxhsh1CLKGiNiXAwV73lcKFZO8pobnaiDLuqQKLMbEcvKg14yj1DZu0LxONi2zkDqyp57O+nt8Kv1ypnQtHOdslDr1hvCq14/4a9ZOTLVHYrd+7QYZMYseI+0oIGXLSs+D+caXVbUgXTRICKOv3oJRLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C+5czMOChY06NbD7GBIlDCpf1fZosY+JcIjRqcYf2ok=; b=KmPEj3yWExJKc6dOITUkp/OzXtHs04BLGAm/5lTaR7QVHTAJB8HZIgptGH+67Kh3KxCQBHd1osPIWwC1frpMDTpRgBcMmm9NTgnBPVxNYfFz6UR1JkFyBclxdGFcMBv4sOQ2D91y7/kSb/eXZK8euh/cu/Ww8tdE1uMnpWyWSv8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 03/10] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t Date: Thu, 13 Apr 2023 18:37:28 +0100 Message-ID: <20230413173735.48387-4-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT038:EE_|IA1PR12MB6162:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e35c369-2398-4e22-8367-08db3c45d750 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NjT3a55Y92ln30oEP7rU+udXS1MzAdqohmmEoWQ9wdPdsgWd8KzMxVcX/9j2s3up40EuE+cCyXC8J8ZQV7As2IeNTc/tC+T6hrRMLG8NgUbp5v1Gkx//fhEUM2+n/Poo70/+JJ8LIDZzcvrRNNZuVEbT5QtxoU/JUHbO6qAphZGuTOxTBy7KlqWdYSVkzP5GvJZlT2eYKwG1Wc3UMSaEYZ7uNtfHpsmTGZnAH2Ngr6kJiRuPsCn2psjo3DEgf2HXxfsjoqy02NKfEhQWLymJ3/Zq9KBcuVvuJ1tX8yHfpnmubEw1CrgYJgeOBa7D22n4ZeVl+asw/zERj32nupB9/Lja206auWuazefQWE4ClKKLS2LF+GxdM8vluBWXnxfgcd50SzeW49BhALIXgTFscAmchOAMz7c7bqE2W8Lb6YxjPby6PzAKotnVGGc04TPbGd/cEdlW/JnBSguO+xp69OzX23hidzHdVe4bOczKhZTbbqAGB33Um4ksgZ1xRNVd3iIgIp3ksVZJYwP/qtPJdDZevGU0rUOXrino8mg0S34TCGlGrflA7Tdm0crLCUzlvpjshpUI/ESv7YAvUMMfrPUwK63P+bPwvxcsNlzRbu+HDoZmq+TMIVO+x3/Aly85I8AxJft2c+nYjl8pnOMlrnOwrPm+Lvo+0rnvcCLdDJNy3j+mr+lRkk7ssACzYJFt2IchgBhgkqdC1lmNfPu/6klbwplSuiXMF2RmXnw4MPE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199021)(46966006)(36840700001)(40470700004)(7416002)(47076005)(36860700001)(82740400003)(2616005)(5660300002)(83380400001)(30864003)(2906002)(336012)(426003)(40460700003)(26005)(1076003)(186003)(8936002)(8676002)(6666004)(54906003)(36756003)(6916009)(4326008)(86362001)(70586007)(70206006)(316002)(81166007)(356005)(40480700001)(41300700001)(966005)(103116003)(82310400005)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:06.5376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e35c369-2398-4e22-8367-08db3c45d750 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6162 dt_device_get_address() can accept uint64_t only for address and size. However, the address/size denotes physical addresses. Thus, they should be represented by 'paddr_t'. Consequently, we introduce a wrapper for dt_device_get_address() ie dt_device_get_paddr() which accepts address/size as paddr_t and inturn invokes dt_device_get_address() after converting address/size to uint64_t. The reason for introducing this is that in future 'paddr_t' may not always be 64-bit. Thus, we need an explicit wrapper to do the type conversion and return an error in case of truncation. With this, callers can now invoke dt_device_get_paddr(). Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. New patch. v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" into this patch. 2. dt_device_get_address() callers now invoke dt_device_get_paddr() instead. 3. Logged error in case of truncation. v3 - 1. Modified the truncation checks as "dt_addr != (paddr_t)dt_addr". 2. Some sanity fixes. v4 - 1. Some sanity fixes. 2. Preserved the declaration of dt_device_get_address() in xen/include/xen/device_tree.h. The reason being it is currently used by ns16550.c. This driver requires some more changes as pointed by Jan in https://lore.kernel.org/xen-devel/6196e90f-752e-e61a-45ce-37e46c22b812@suse.com/ which is to be addressed as a separate series. xen/arch/arm/domain_build.c | 10 +++---- xen/arch/arm/gic-v2.c | 10 +++---- xen/arch/arm/gic-v3-its.c | 4 +-- xen/arch/arm/gic-v3.c | 10 +++---- xen/arch/arm/pci/pci-host-common.c | 6 ++-- xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- xen/arch/arm/platforms/brcm.c | 6 ++-- xen/arch/arm/platforms/exynos5.c | 32 ++++++++++---------- xen/arch/arm/platforms/sunxi.c | 2 +- xen/arch/arm/platforms/xgene-storm.c | 2 +- xen/common/device_tree.c | 35 ++++++++++++++++++++++ xen/drivers/char/cadence-uart.c | 4 +-- xen/drivers/char/exynos4210-uart.c | 4 +-- xen/drivers/char/imx-lpuart.c | 4 +-- xen/drivers/char/meson-uart.c | 4 +-- xen/drivers/char/mvebu-uart.c | 4 +-- xen/drivers/char/omap-uart.c | 4 +-- xen/drivers/char/pl011.c | 6 ++-- xen/drivers/char/scif-uart.c | 4 +-- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++--- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 8 ++--- xen/include/xen/device_tree.h | 13 ++++++++ 23 files changed, 116 insertions(+), 68 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 15c8bdd9e4..7d28b75517 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1698,13 +1698,13 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, dt_for_each_device_node( dt_host, np ) { unsigned int naddr; - u64 addr, size; + paddr_t addr, size; naddr = dt_number_of_address(np); for ( i = 0; i < naddr; i++ ) { - res = dt_device_get_address(np, i, &addr, &size); + res = dt_device_get_paddr(np, i, &addr, &size); if ( res ) { printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", @@ -2478,7 +2478,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, unsigned int naddr; unsigned int i; int res; - u64 addr, size; + paddr_t addr, size; bool own_device = !dt_device_for_passthrough(dev); /* * We want to avoid mapping the MMIO in dom0 for the following cases: @@ -2533,7 +2533,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, /* Give permission and map MMIOs */ for ( i = 0; i < naddr; i++ ) { - res = dt_device_get_address(dev, i, &addr, &size); + res = dt_device_get_paddr(dev, i, &addr, &size); if ( res ) { printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", @@ -2964,7 +2964,7 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo, if ( res ) { printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIx64" - 0x%"PRIx64"\n", + " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", kinfo->d->domain_id, mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); return res; diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 5d4d298b86..6476ff4230 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -993,7 +993,7 @@ static void gicv2_extension_dt_init(const struct dt_device_node *node) continue; /* Get register frame resource from DT. */ - if ( dt_device_get_address(v2m, 0, &addr, &size) ) + if ( dt_device_get_paddr(v2m, 0, &addr, &size) ) panic("GICv2: Cannot find a valid v2m frame address\n"); /* @@ -1018,19 +1018,19 @@ static void __init gicv2_dt_init(void) paddr_t vsize; const struct dt_device_node *node = gicv2_info.node; - res = dt_device_get_address(node, 0, &dbase, NULL); + res = dt_device_get_paddr(node, 0, &dbase, NULL); if ( res ) panic("GICv2: Cannot find a valid address for the distributor\n"); - res = dt_device_get_address(node, 1, &cbase, &csize); + res = dt_device_get_paddr(node, 1, &cbase, &csize); if ( res ) panic("GICv2: Cannot find a valid address for the CPU\n"); - res = dt_device_get_address(node, 2, &hbase, NULL); + res = dt_device_get_paddr(node, 2, &hbase, NULL); if ( res ) panic("GICv2: Cannot find a valid address for the hypervisor\n"); - res = dt_device_get_address(node, 3, &vbase, &vsize); + res = dt_device_get_paddr(node, 3, &vbase, &vsize); if ( res ) panic("GICv2: Cannot find a valid address for the virtual CPU\n"); diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 1ec9934191..3aa4edda10 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -1004,12 +1004,12 @@ static void gicv3_its_dt_init(const struct dt_device_node *node) */ dt_for_each_child_node(node, its) { - uint64_t addr, size; + paddr_t addr, size; if ( !dt_device_is_compatible(its, "arm,gic-v3-its") ) continue; - if ( dt_device_get_address(its, 0, &addr, &size) ) + if ( dt_device_get_paddr(its, 0, &addr, &size) ) panic("GICv3: Cannot find a valid ITS frame address\n"); add_to_host_its_list(addr, size, its); diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index bb59ea94cd..4e6c98bada 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1377,7 +1377,7 @@ static void __init gicv3_dt_init(void) int res, i; const struct dt_device_node *node = gicv3_info.node; - res = dt_device_get_address(node, 0, &dbase, NULL); + res = dt_device_get_paddr(node, 0, &dbase, NULL); if ( res ) panic("GICv3: Cannot find a valid distributor address\n"); @@ -1393,9 +1393,9 @@ static void __init gicv3_dt_init(void) for ( i = 0; i < gicv3.rdist_count; i++ ) { - uint64_t rdist_base, rdist_size; + paddr_t rdist_base, rdist_size; - res = dt_device_get_address(node, 1 + i, &rdist_base, &rdist_size); + res = dt_device_get_paddr(node, 1 + i, &rdist_base, &rdist_size); if ( res ) panic("GICv3: No rdist base found for region %d\n", i); @@ -1417,10 +1417,10 @@ static void __init gicv3_dt_init(void) * For GICv3 supporting GICv2, GICC and GICV base address will be * provided. */ - res = dt_device_get_address(node, 1 + gicv3.rdist_count, + res = dt_device_get_paddr(node, 1 + gicv3.rdist_count, &cbase, &csize); if ( !res ) - dt_device_get_address(node, 1 + gicv3.rdist_count + 2, + dt_device_get_paddr(node, 1 + gicv3.rdist_count + 2, &vbase, &vsize); } diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index a8ece94303..5550f9478d 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -93,7 +93,7 @@ gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops) cfg_reg_idx = 0; /* Parse our PCI ecam register address */ - err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size); + err = dt_device_get_paddr(dev, cfg_reg_idx, &addr, &size); if ( err ) goto err_exit; @@ -349,10 +349,10 @@ int __init pci_host_bridge_mappings(struct domain *d) for ( i = 0; i < dt_number_of_address(dev); i++ ) { - uint64_t addr, size; + paddr_t addr, size; int err; - err = dt_device_get_address(dev, i, &addr, &size); + err = dt_device_get_paddr(dev, i, &addr, &size); if ( err ) { printk(XENLOG_ERR diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c index 811b40b1a6..407ec07f63 100644 --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c @@ -64,7 +64,7 @@ static void __iomem *rpi4_map_watchdog(void) if ( !node ) return NULL; - ret = dt_device_get_address(node, 0, &start, &len); + ret = dt_device_get_paddr(node, 0, &start, &len); if ( ret ) { printk("Cannot read watchdog register address\n"); diff --git a/xen/arch/arm/platforms/brcm.c b/xen/arch/arm/platforms/brcm.c index d481b2c60f..951e4d6cc3 100644 --- a/xen/arch/arm/platforms/brcm.c +++ b/xen/arch/arm/platforms/brcm.c @@ -40,7 +40,7 @@ static __init int brcm_get_dt_node(char *compat_str, u32 *reg_base) { const struct dt_device_node *node; - u64 reg_base_64; + paddr_t reg_base_paddr; int rc; node = dt_find_compatible_node(NULL, NULL, compat_str); @@ -50,7 +50,7 @@ static __init int brcm_get_dt_node(char *compat_str, return -ENOENT; } - rc = dt_device_get_address(node, 0, ®_base_64, NULL); + rc = dt_device_get_paddr(node, 0, ®_base_paddr, NULL); if ( rc ) { dprintk(XENLOG_ERR, "%s: missing \"reg\" prop\n", __func__); @@ -61,7 +61,7 @@ static __init int brcm_get_dt_node(char *compat_str, *dn = node; if ( reg_base ) - *reg_base = reg_base_64; + *reg_base = reg_base_paddr; return 0; } diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c index 6560507092..c48093cd4f 100644 --- a/xen/arch/arm/platforms/exynos5.c +++ b/xen/arch/arm/platforms/exynos5.c @@ -42,8 +42,8 @@ static int exynos5_init_time(void) void __iomem *mct; int rc; struct dt_device_node *node; - u64 mct_base_addr; - u64 size; + paddr_t mct_base_addr; + paddr_t size; node = dt_find_compatible_node(NULL, NULL, "samsung,exynos4210-mct"); if ( !node ) @@ -52,14 +52,14 @@ static int exynos5_init_time(void) return -ENXIO; } - rc = dt_device_get_address(node, 0, &mct_base_addr, &size); + rc = dt_device_get_paddr(node, 0, &mct_base_addr, &size); if ( rc ) { dprintk(XENLOG_ERR, "Error in \"samsung,exynos4210-mct\"\n"); return -ENXIO; } - dprintk(XENLOG_INFO, "mct_base_addr: %016llx size: %016llx\n", + dprintk(XENLOG_INFO, "mct_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", mct_base_addr, size); mct = ioremap_nocache(mct_base_addr, size); @@ -97,9 +97,9 @@ static int __init exynos5_smp_init(void) struct dt_device_node *node; void __iomem *sysram; char *compatible; - u64 sysram_addr; - u64 size; - u64 sysram_offset; + paddr_t sysram_addr; + paddr_t size; + paddr_t sysram_offset; int rc; node = dt_find_compatible_node(NULL, NULL, "samsung,secure-firmware"); @@ -125,13 +125,13 @@ static int __init exynos5_smp_init(void) return -ENXIO; } - rc = dt_device_get_address(node, 0, &sysram_addr, &size); + rc = dt_device_get_paddr(node, 0, &sysram_addr, &size); if ( rc ) { dprintk(XENLOG_ERR, "Error in %s\n", compatible); return -ENXIO; } - dprintk(XENLOG_INFO, "sysram_addr: %016llx size: %016llx offset: %016llx\n", + dprintk(XENLOG_INFO,"sysram_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"offset: 0x%"PRIpaddr"\n", sysram_addr, size, sysram_offset); sysram = ioremap_nocache(sysram_addr, size); @@ -189,7 +189,7 @@ static int exynos5_cpu_power_up(void __iomem *power, int cpu) return 0; } -static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) +static int exynos5_get_pmu_baseandsize(paddr_t *power_base_addr, paddr_t *size) { struct dt_device_node *node; int rc; @@ -208,14 +208,14 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) return -ENXIO; } - rc = dt_device_get_address(node, 0, power_base_addr, size); + rc = dt_device_get_paddr(node, 0, power_base_addr, size); if ( rc ) { dprintk(XENLOG_ERR, "Error in \"samsung,exynos5XXX-pmu\"\n"); return -ENXIO; } - dprintk(XENLOG_DEBUG, "power_base_addr: %016llx size: %016llx\n", + dprintk(XENLOG_DEBUG, "power_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", *power_base_addr, *size); return 0; @@ -223,8 +223,8 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) static int exynos5_cpu_up(int cpu) { - u64 power_base_addr; - u64 size; + paddr_t power_base_addr; + paddr_t size; void __iomem *power; int rc; @@ -256,8 +256,8 @@ static int exynos5_cpu_up(int cpu) static void exynos5_reset(void) { - u64 power_base_addr; - u64 size; + paddr_t power_base_addr; + paddr_t size; void __iomem *pmu; int rc; diff --git a/xen/arch/arm/platforms/sunxi.c b/xen/arch/arm/platforms/sunxi.c index e8e4d88bef..2b2c215f20 100644 --- a/xen/arch/arm/platforms/sunxi.c +++ b/xen/arch/arm/platforms/sunxi.c @@ -50,7 +50,7 @@ static void __iomem *sunxi_map_watchdog(bool *new_wdt) return NULL; } - ret = dt_device_get_address(node, 0, &wdt_start, &wdt_len); + ret = dt_device_get_paddr(node, 0, &wdt_start, &wdt_len); if ( ret ) { dprintk(XENLOG_ERR, "Cannot read watchdog register address\n"); diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index befd0c3c2d..6fc2f9679e 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -50,7 +50,7 @@ static void __init xgene_check_pirq_eoi(void) if ( !node ) panic("%s: Can not find interrupt controller node\n", __func__); - res = dt_device_get_address(node, 0, &dbase, NULL); + res = dt_device_get_paddr(node, 0, &dbase, NULL); if ( res ) panic("%s: Cannot find a valid address for the distributor\n", __func__); diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7b..fdef74e7ff 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -955,6 +955,41 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, return 0; } +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, + paddr_t *addr, paddr_t *size) +{ + uint64_t dt_addr = 0, dt_size = 0; + int ret; + + ret = dt_device_get_address(dev, index, &dt_addr, &dt_size); + if ( ret ) + return ret; + + if ( addr ) + { + if ( dt_addr != (paddr_t)dt_addr ) + { + printk("Error: Physical address 0x%"PRIx64" for node=%s is greater than max width (%zu bytes) supported\n", + dt_addr, dev->name, sizeof(paddr_t)); + return -ERANGE; + } + + *addr = dt_addr; + } + + if ( size ) + { + if ( dt_size != (paddr_t)dt_size ) + { + printk("Error: Physical size 0x%"PRIx64" for node=%s is greater than max width (%zu bytes) supported\n", + dt_size, dev->name, sizeof(paddr_t)); + return -ERANGE; + } + *size = dt_size; + } + + return ret; +} int dt_for_each_range(const struct dt_device_node *dev, int (*cb)(const struct dt_device_node *, diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-uart.c index 22905ba66c..c38d7ed143 100644 --- a/xen/drivers/char/cadence-uart.c +++ b/xen/drivers/char/cadence-uart.c @@ -158,14 +158,14 @@ static int __init cuart_init(struct dt_device_node *dev, const void *data) const char *config = data; struct cuart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &cuart_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("cadence: Unable to retrieve the base" diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c index 43aaf02e18..2503392ccd 100644 --- a/xen/drivers/char/exynos4210-uart.c +++ b/xen/drivers/char/exynos4210-uart.c @@ -303,7 +303,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, const char *config = data; struct exynos4210_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); @@ -316,7 +316,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, uart->parity = PARITY_NONE; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("exynos4210: Unable to retrieve the base" diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c index 9c1f3b71a3..77f70c2719 100644 --- a/xen/drivers/char/imx-lpuart.c +++ b/xen/drivers/char/imx-lpuart.c @@ -204,7 +204,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, const char *config = data; struct imx_lpuart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); @@ -216,7 +216,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, uart->parity = 0; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("imx8-lpuart: Unable to retrieve the base" diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c index b1e25e0468..c627328122 100644 --- a/xen/drivers/char/meson-uart.c +++ b/xen/drivers/char/meson-uart.c @@ -209,14 +209,14 @@ static int __init meson_uart_init(struct dt_device_node *dev, const void *data) const char *config = data; struct meson_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &meson_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("meson: Unable to retrieve the base address of the UART\n"); diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c index a00618b96f..cc55173513 100644 --- a/xen/drivers/char/mvebu-uart.c +++ b/xen/drivers/char/mvebu-uart.c @@ -231,14 +231,14 @@ static int __init mvebu_uart_init(struct dt_device_node *dev, const void *data) const char *config = data; struct mvebu3700_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &mvebu3700_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("mvebu3700: Unable to retrieve the base address of the UART\n"); diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c index d6a5d59aa2..8e643cb039 100644 --- a/xen/drivers/char/omap-uart.c +++ b/xen/drivers/char/omap-uart.c @@ -324,7 +324,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, struct omap_uart *uart; u32 clkspec; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); @@ -344,7 +344,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, uart->parity = UART_PARITY_NONE; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("omap-uart: Unable to retrieve the base" diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index be67242bc0..052a651251 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -222,7 +222,7 @@ static struct uart_driver __read_mostly pl011_driver = { .vuart_info = pl011_vuart, }; -static int __init pl011_uart_init(int irq, u64 addr, u64 size, bool sbsa) +static int __init pl011_uart_init(int irq, paddr_t addr, paddr_t size, bool sbsa) { struct pl011 *uart; @@ -258,14 +258,14 @@ static int __init pl011_dt_uart_init(struct dt_device_node *dev, { const char *config = data; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) { printk("WARNING: UART configuration is not supported\n"); } - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("pl011: Unable to retrieve the base" diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c index 2fccafe340..1b28ba90e9 100644 --- a/xen/drivers/char/scif-uart.c +++ b/xen/drivers/char/scif-uart.c @@ -311,14 +311,14 @@ static int __init scif_uart_init(struct dt_device_node *dev, const char *config = data; struct scif_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &scif_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("scif-uart: Unable to retrieve the base" diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 091f09b217..611d9eeba5 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -794,7 +794,7 @@ static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu) static __init bool ipmmu_stage2_supported(void) { struct dt_device_node *np; - uint64_t addr, size; + paddr_t addr, size; void __iomem *base; uint32_t product, cut; bool stage2_supported = false; @@ -806,7 +806,7 @@ static __init bool ipmmu_stage2_supported(void) return false; } - if ( dt_device_get_address(np, 0, &addr, &size) ) + if ( dt_device_get_paddr(np, 0, &addr, &size) ) { printk(XENLOG_ERR "ipmmu: Failed to get PRR MMIO\n"); return false; @@ -884,7 +884,7 @@ static int ipmmu_probe(struct dt_device_node *node) { const struct dt_device_match *match; struct ipmmu_vmsa_device *mmu; - uint64_t addr, size; + paddr_t addr, size; uint32_t reg; int irq, ret; @@ -905,7 +905,7 @@ static int ipmmu_probe(struct dt_device_node *node) bitmap_zero(mmu->ctx, IPMMU_CTX_MAX); /* Map I/O memory and request IRQ. */ - ret = dt_device_get_address(node, 0, &addr, &size); + ret = dt_device_get_paddr(node, 0, &addr, &size); if ( ret ) { dev_err(&node->dev, "Failed to get MMIO\n"); diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index bfdb62b395..b7fa2e90f7 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -2428,7 +2428,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) } /* Base address */ - ret = dt_device_get_address(np, 0, &ioaddr, &iosize); + ret = dt_device_get_paddr(np, 0, &ioaddr, &iosize); if (ret) goto out_free_smmu; diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3..79281075ba 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -73,8 +73,8 @@ /* Xen: Helpers to get device MMIO and IRQs */ struct resource { - u64 addr; - u64 size; + paddr_t addr; + paddr_t size; unsigned int type; }; @@ -101,7 +101,7 @@ static struct resource *platform_get_resource(struct platform_device *pdev, switch (type) { case IORESOURCE_MEM: - ret = dt_device_get_address(pdev, num, &res.addr, &res.size); + ret = dt_device_get_paddr(pdev, num, &res.addr, &res.size); return ((ret) ? NULL : &res); @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev, ptr = ioremap_nocache(res->addr, res->size); if (!ptr) { dev_err(dev, - "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", + "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n", res->addr, res->size); return ERR_PTR(-ENOMEM); } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 11bda2fd3d..c1dc5400e1 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -581,6 +581,19 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, */ const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); +/** + * dt_device_get_paddr - Resolve an address for a device + * @device: the device whose address is to be resolved + * @index: index of the address to resolve + * @addr: address filled by this function + * @size: size filled by this function + * + * This function resolves an address, walking the tree, for a give + * device-tree node. It returns 0 on success. + */ +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, + paddr_t *addr, paddr_t *size); + /** * dt_device_get_address - Resolve an address for a device * @device: the device whose address is to be resolved -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520856.808942 (Exim 4.92) (envelope-from ) id 1pn0tj-0001ik-IZ; Thu, 13 Apr 2023 17:38:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520856.808942; Thu, 13 Apr 2023 17:38:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tj-0001hd-D8; Thu, 13 Apr 2023 17:38:15 +0000 Received: by outflank-mailman (input) for mailman id 520856; Thu, 13 Apr 2023 17:38:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0ti-0000rf-Pk for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:14 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061b.outbound.protection.outlook.com [2a01:111:f400:fe5b::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f63001a6-da21-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:38:13 +0200 (CEST) Received: from BN8PR15CA0010.namprd15.prod.outlook.com (2603:10b6:408:c0::23) by IA0PR12MB7723.namprd12.prod.outlook.com (2603:10b6:208:431::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:38:09 +0000 Received: from BN8NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:408:c0:cafe::f9) by BN8PR15CA0010.outlook.office365.com (2603:10b6:408:c0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT056.mail.protection.outlook.com (10.13.177.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:09 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:08 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:07 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f63001a6-da21-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xs+R+dY11cRv/AkZmz3QR253FUC5U1/Vup5WaDUnPv7yK2JMj1zW3pYEY5UIeJdXT/Og5OX/HgIOp5yUa/SOQd7GvqUrj+39WmYUL6dQ4Fb7a9nYTf0birpKUUrzNeWTmRtFPEz3E9d2I9KIZwwg8UtlvH7jMSs5i33/Au+iwbhkozJGncPZcGhI8UcmigqtHsW+vLVs22kPpR11YOGEI8ZYeG2TZZhRpMw3QdIOy58XKrBaTdXJwihW/G7nC8RuwhJdjFlPWDsMSjf4D9qBWRtNfPhotBua3dK8uc4m8jVVsKoWJz5Ilp3XUg5GVZwo1soIM8+KlfPloTRmmEjufw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=84Q/bSxo/zI/eadAn9/P6keU8t8kk/hED39X4Kpg+4k=; b=cHCO+BxWFaXQH2iY/Z4wvhNEyADR4mO1DkHFLK51X+KQcYRhB860SFEbJijHnyDDEPSo2P4p59JM15Z85PRqTyc/9n00NvJxzdvVfU+vfihMamJ3xXhVIuKPD5kZd9w6c5nDDHbJh3cOAVIjeS011fTrn7cDYOFexnoH3/P4CCk8tLfaXuEBmLc0oFMq2rysuvVYq4w24cH0mZBhw/QJNqtvxFNAREg1aPXmaYZSYjHqFv+92jt76tCYTI3LpdVM24+gHi/o+5bBNNDEY+Xm/sC3AkW5DheJmhg1mVJwptSmKnOwKOumAcU6b/TPrngeeoLzqPyhM3JsiTxKy0Ryig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84Q/bSxo/zI/eadAn9/P6keU8t8kk/hED39X4Kpg+4k=; b=0SSkUOsUlrD+tnVrzTBjvZbL4V9Ykah6RYry47qHRraw1axt8/gouRabnTNdCtX8bLp7x/q+N7+jgTwA0ogcVcyrmmFV3GGX9pZbO+V8Dl8NtPLLAXGHrtfJh8P5mrl64nR6g2q0C4D/cs1uyuBWn6sikrxSdLMDVGIicMwiahs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 04/10] xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 Date: Thu, 13 Apr 2023 18:37:29 +0100 Message-ID: <20230413173735.48387-5-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT056:EE_|IA0PR12MB7723:EE_ X-MS-Office365-Filtering-Correlation-Id: d4fd22d6-3c30-4f17-a19e-08db3c45d902 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TsSmC5OHrPe9eiU8xz5clgHDvdA+woZQuuXp9lju1jwW89oj4yjHE+zSG5mTvUlipPMy93VyVBjoEcERR6cRwhezJMT6i7jwH3oGIQN+pxg3yd7DXsZp2BgeIB4Un5e1+D1LZ8PHaOVLzuuKd/pIEJ61ZXXinR4jZlknGeKXPCKrvKh0a01FUz9tztxtRK2uCQTUJDvL9f7/Ja5gqgevDtrYpWPZjMoxeb1zwzqEIeyTRRxyDMonnprADCXN9KOCi2M3Nmt8F4bxX4373KSjm6mEQpLwAPWw8hGTVh0nqKZ/M4ylkfjyhSk8v01MpxOvjkyXsfZ+TC6DHs8E3+vP14+R323E+YIdiqH6wB00/MbDfvwmomBfle1vT18XKFW8SSZPuvwkagUexBvwE3y8UGKEDqSXELdV8jCx8eKj7wl4c6lxNM6S0dEi2AdyHn9N2g2+mLPeWXde63RKfhb3YsE1H2cDp73sNGJ0S9YEps+zK2uI1rzSVWwRLaYkDYscFW2tqr+Xf+jzVd0P1eBBMyVb45hmYNvRlWTIJwJZbYMe37tXdCcK133FE+jWxkuGa7+Wq8LkQj/YSn4HFIj/xtXyJIw/PeKcjDttbsYLMi1fNQwZymw5zoARXCfi0WPk2m0ZU3PZK95OQkxO+DU7rT7yNSsCE+mrstgONmExfj+1UkoIkWcN2GTYfk7FnIcF5Mde5UG/Abq4Q9bft+lTlDOUuaQWtwRa/2f75f6ngS8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(6666004)(40460700003)(6916009)(70206006)(70586007)(4326008)(36756003)(2906002)(7416002)(86362001)(81166007)(82740400003)(356005)(41300700001)(103116003)(5660300002)(82310400005)(8676002)(8936002)(316002)(478600001)(40480700001)(54906003)(1076003)(26005)(336012)(426003)(36860700001)(2616005)(186003)(47076005)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:09.3826 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4fd22d6-3c30-4f17-a19e-08db3c45d902 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7723 Refer ARM IHI 0062D.c ID070116 (SMMU 2.0 spec), 17-360, 17.3.9, SMMU_CBn_TTBR0 is a 64 bit register. Thus, one can use writeq_relaxed_non_atomic() to write to it instead of invoking writel_relaxed() twice for lower half and upper half of the register. This also helps us as p2maddr is 'paddr_t' (which may be u32 in future). Thus, one can assign p2maddr to a 64 bit register and do the bit manipulations on it, to generate the value for SMMU_CBn_TTBR0. Signed-off-by: Ayan Kumar Halder Reviewed-by: Stefano Stabellini --- Changes from - v1 - 1. Extracted the patch from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". Use writeq_relaxed_non_atomic() to write u64 register in a non-atomic fashion. v2 - 1. Added R-b. v3 - 1. No changes. v4 - 1. Reordered the R-b. No further changes. (This patch can be committed independent of the series). xen/drivers/passthrough/arm/smmu.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 79281075ba..c8ef2a925f 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -499,8 +499,7 @@ enum arm_smmu_s2cr_privcfg { #define ARM_SMMU_CB_SCTLR 0x0 #define ARM_SMMU_CB_RESUME 0x8 #define ARM_SMMU_CB_TTBCR2 0x10 -#define ARM_SMMU_CB_TTBR0_LO 0x20 -#define ARM_SMMU_CB_TTBR0_HI 0x24 +#define ARM_SMMU_CB_TTBR0 0x20 #define ARM_SMMU_CB_TTBCR 0x30 #define ARM_SMMU_CB_S1_MAIR0 0x38 #define ARM_SMMU_CB_FSR 0x58 @@ -1083,6 +1082,7 @@ static void arm_smmu_flush_pgtable(struct arm_smmu_device *smmu, void *addr, static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) { u32 reg; + u64 reg64; bool stage1; struct arm_smmu_cfg *cfg = &smmu_domain->cfg; struct arm_smmu_device *smmu = smmu_domain->smmu; @@ -1177,12 +1177,13 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) dev_notice(smmu->dev, "d%u: p2maddr 0x%"PRIpaddr"\n", smmu_domain->cfg.domain->domain_id, p2maddr); - reg = (p2maddr & ((1ULL << 32) - 1)); - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO); - reg = (p2maddr >> 32); + reg64 = p2maddr; + if (stage1) - reg |= ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT; - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI); + reg64 |= (((uint64_t) (ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT)) + << 32); + + writeq_relaxed_non_atomic(reg64, cb_base + ARM_SMMU_CB_TTBR0); /* * TTBCR -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520858.808956 (Exim 4.92) (envelope-from ) id 1pn0tl-0002H4-Tg; Thu, 13 Apr 2023 17:38:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520858.808956; Thu, 13 Apr 2023 17:38:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tl-0002Go-PC; Thu, 13 Apr 2023 17:38:17 +0000 Received: by outflank-mailman (input) for mailman id 520858; Thu, 13 Apr 2023 17:38:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tk-0000a4-Qi for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:16 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8380ab3-da21-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 19:38:15 +0200 (CEST) Received: from BN8PR03CA0034.namprd03.prod.outlook.com (2603:10b6:408:94::47) by MN0PR12MB5931.namprd12.prod.outlook.com (2603:10b6:208:37e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:38:13 +0000 Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:408:94:cafe::ef) by BN8PR03CA0034.outlook.office365.com (2603:10b6:408:94::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:13 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:12 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:12 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:10 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8380ab3-da21-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/W/qQZ/U0+/znam5EFu1zzL1byXAU25t3wksNhuQg0gB+oRRGivzRQQl25QNBuzq7iN71tRHcsAK2djH3WpOaPbJj3Yjj+iGotVEyHPWPDnZs1Bjsa53RlkNEmRWfSjDMDmAk0sxZoQMlD6mHb+HEVSG0U6QE8Jzsc/vVXyA4+83GkmfY+HzWcvpgeZcar2sD3+YiisCZSqVwDw7o2O53ccZwzjUPfZnget8yHox1UnVoTGe2FRl5QE9ejNimXfbvvSLCA8pBBhp9NxV/F6iKG/XsCrhfjftOoZaYsud1QZwiIX9Ufvi93W381qc0BerYkeQND3zh4HCWriVpNENw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rTjpNh+BHfToII30u7IVf5AGDUbfYB8YKJohyCLK1pQ=; b=oFSfRGim8riEmY+EBg1Tp3kn3Etl8U0qo/ClbnYhrHzORJ7Mx8CLvv3qxRy1Em6fY8oJI78zRX+yj8Pt237B+Ssib/7Wj1beW+xf4Q3ImIRmaRowZ260wtUTZQyr6585qthxULDUO8y8k1CYzpRr3M3t3drPc+An6I6bdUsPAZVtkPdLIgLhQCA7jXgG8bUdnwLspFJlgq58xVkt/WoIykbIf4zrr4AlqaITtI7GKRNsvzkAJQOEQXbb+ZlcMZcNhpldtRC7GuQn0QuOUPtCHdxUgdHXvExzOfOCFyKBExw8fD3anvAys05p7l3uCSEv5pMDvBBk72BndOqPLESLvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rTjpNh+BHfToII30u7IVf5AGDUbfYB8YKJohyCLK1pQ=; b=tEhm6AW4eQRfV6ho0FbQogVzJddsBYsVAdmf7jk04n65gm1+Dv9KoEUfmRPVHLBc5w2GCibGKHR1RPLtukblXNq6vQ2vSNg13Qq0EAu1j/fOGYuLINUdVaWbFLUZvZhHJNgkQYIdauvVEWWyue2c+4ecCqu4k6QFoTEqlT8QPDU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 05/10] xen/arm: Introduce choice to enable 64/32 bit physical addressing Date: Thu, 13 Apr 2023 18:37:30 +0100 Message-ID: <20230413173735.48387-6-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT022:EE_|MN0PR12MB5931:EE_ X-MS-Office365-Filtering-Correlation-Id: cbdf1f5b-395a-4866-7162-08db3c45dafd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PerdVabi5ZzwYIBT1Jnn0FQ5u42GWVrc8Sxcf2ZQZg9nZQbMOjaTtfKnMxgMK1afKkXvK/JvTcNloFclamJYxy7R9H2NSgjdEJp87EqLvttz/wzPyLnI48cjaYdKPDYgs1XsWVhhpcVLOuezbP38elN5L8sewsO+1MKjrGrK4idAXNNzUWjKPjMEjCfbzwfiI2/uhPHSdqVVxJT0MJoZgCNsSxgU1ED1FyPvhj9vucxKIDUd39gLyVR0BKFRkBiq0KC1jvj8sWyurLPO2xSS/dzZmZRPYRXnGCJIwdyXntDkA/KEbBKSMSff+SlZC+FdJ9ug1+vMzmPw9r4gjMAkYdlI2NSSjc4qdEYWRXWkODKpBMj8jOc6MKXR9kMWK4lNifSs04rGLm3B6QblM6T5OeMwnKiNsMXrMCiZK5buF7rYIomJ463Rs1dEQgemIZ//YsxIUQklFhIuGzR4UZP4mVPtoSNp0bkW5AY3n9g5hVFYdvYBTZAD86qML0xaxXea2TtNYyqFm7UGzTFB3MA8fOXuXcMFOYP5pnIdWbFIUCSvcG8ZncRAh7fjx3k7wDd/XsM4fpy5yHN6mjgMGqDe9/11WwMKvTdzvWlZpI6GJK5UVKUwjWubmuFHweA+UCO5jRVkZMqOA6N3fNrH6Q8fEo4EAIZ7ZZSCMZTEMKlKdkYw9oPXwhV2zVAgAO0TLTRK4CIqKQxBBxxPSjrTVfodGRiUY6as5bWp+U16BgtNcVQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(2906002)(7416002)(8676002)(70586007)(70206006)(8936002)(5660300002)(103116003)(478600001)(41300700001)(40460700003)(316002)(40480700001)(83380400001)(82740400003)(426003)(336012)(36756003)(54906003)(6916009)(4326008)(186003)(86362001)(6666004)(26005)(81166007)(1076003)(2616005)(36860700001)(82310400005)(356005)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:12.7041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbdf1f5b-395a-4866-7162-08db3c45dafd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5931 Some Arm based hardware platforms which does not support LPAE (eg Cortex-R52), uses 32 bit physical addresses. Also, users may choose to use 32 bits to represent physical addresses for optimization. To support the above use cases, we have introduced arch independent configs to choose if the physical address can be represented using 32 bits (PHYS_ADDR_T_32) or 64 bits (!PHYS_ADDR_T_32). For now only ARM_32 provides support to enable 32 bit physical addressing. When PHYS_ADDR_T_32 is defined, PADDR_BITS is set to 32. When PHYS_ADDR_T_32 is not defined for ARM_32, PADDR_BITS is set to 40. When PHYS_ADDR_T_32 is not defined for ARM_64, PADDR_BITS is set to 48. The last two are same as the current configuration used today on Xen. PADDR_BITS is also set to 48 when ARM_64 is defined. The reason being the choice to select ARM_PA_BITS_32/ARM_PA_BITS_40/ARM_PA_BITS_48 is currently allowed when ARM_32 is defined. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". v2 - 1. Introduced Kconfig choice. ARM_64 can select PHYS_ADDR_64 only whereas ARM_32 can select PHYS_ADDR_32 or PHYS_ADDR_64. 2. For CONFIG_ARM_PA_32, paddr_t is defined as 'unsigned long'. v3 - 1. Allow user to define PADDR_BITS by selecting different config options ARM_PA_BITS_32, ARM_PA_BITS_40 and ARM_PA_BITS_48. 2. Add the choice under "Architecture Features". v4 - 1. Removed PHYS_ADDR_T_64 as !PHYS_ADDR_T_32 means PHYS_ADDR_T_32. xen/arch/Kconfig | 3 +++ xen/arch/arm/Kconfig | 37 ++++++++++++++++++++++++++-- xen/arch/arm/include/asm/page-bits.h | 6 +---- xen/arch/arm/include/asm/types.h | 6 +++++ xen/arch/arm/mm.c | 5 ++++ 5 files changed, 50 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index 7028f7b74f..67ba38f32f 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -1,6 +1,9 @@ config 64BIT bool +config PHYS_ADDR_T_32 + bool + config NR_CPUS int "Maximum number of CPUs" range 1 4095 diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..3f6e13e475 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -19,13 +19,46 @@ config ARM select HAS_PMAP select IOMMU_FORCE_PT_SHARE +menu "Architecture Features" + +choice + prompt "Physical address space size" if ARM_32 + default ARM_PA_BITS_48 if ARM_64 + default ARM_PA_BITS_40 if ARM_32 + help + User can choose to represent the width of physical address. This can + sometimes help in optimizing the size of image when user chooses a + smaller size to represent physical address. + +config ARM_PA_BITS_32 + bool "32-bit" + help + On platforms where any physical address can be represented within 32 bits, + user should choose this option. This will help is reduced size of the + binary. + select PHYS_ADDR_T_32 + depends on ARM_32 + +config ARM_PA_BITS_40 + bool "40-bit" + depends on ARM_32 + +config ARM_PA_BITS_48 + bool "40-bit" + depends on ARM_48 +endchoice + +config PADDR_BITS + int + default 32 if ARM_PA_BITS_32 + default 40 if ARM_PA_BITS_40 + default 48 if ARM_PA_BITS_48 || ARM_64 + config ARCH_DEFCONFIG string default "arch/arm/configs/arm32_defconfig" if ARM_32 default "arch/arm/configs/arm64_defconfig" if ARM_64 -menu "Architecture Features" - source "arch/Kconfig" config ACPI diff --git a/xen/arch/arm/include/asm/page-bits.h b/xen/arch/arm/include/asm/page-bits.h index 5d6477e599..deb381ceeb 100644 --- a/xen/arch/arm/include/asm/page-bits.h +++ b/xen/arch/arm/include/asm/page-bits.h @@ -3,10 +3,6 @@ #define PAGE_SHIFT 12 -#ifdef CONFIG_ARM_64 -#define PADDR_BITS 48 -#else -#define PADDR_BITS 40 -#endif +#define PADDR_BITS CONFIG_PADDR_BITS #endif /* __ARM_PAGE_SHIFT_H__ */ diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h index e218ed77bd..e3cfbbb060 100644 --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -34,9 +34,15 @@ typedef signed long long s64; typedef unsigned long long u64; typedef u32 vaddr_t; #define PRIvaddr PRIx32 +#if defined(CONFIG_PHYS_ADDR_T_32) +typedef unsigned long paddr_t; +#define INVALID_PADDR (~0UL) +#define PRIpaddr "08lx" +#else typedef u64 paddr_t; #define INVALID_PADDR (~0ULL) #define PRIpaddr "016llx" +#endif typedef u32 register_t; #define PRIregister "08x" #elif defined (CONFIG_ARM_64) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index b99806af99..6dc37be97e 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -690,6 +690,11 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); int rc; + /* + * The size of paddr_t should be sufficient for the complete range of + * physical address. + */ + BUILD_BUG_ON((sizeof(paddr_t) * 8) < PADDR_BITS); BUILD_BUG_ON(sizeof(struct page_info) != PAGE_INFO_SIZE); if ( frametable_size > FRAMETABLE_SIZE ) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520867.808966 (Exim 4.92) (envelope-from ) id 1pn0u0-0003OQ-7l; Thu, 13 Apr 2023 17:38:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520867.808966; Thu, 13 Apr 2023 17:38:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0u0-0003OH-2d; Thu, 13 Apr 2023 17:38:32 +0000 Received: by outflank-mailman (input) for mailman id 520867; Thu, 13 Apr 2023 17:38:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0tx-0000rf-Vv for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:29 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20624.outbound.protection.outlook.com [2a01:111:f400:fe5a::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff2291d1-da21-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:38:28 +0200 (CEST) Received: from BN9P223CA0023.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::28) by SJ1PR12MB6099.namprd12.prod.outlook.com (2603:10b6:a03:45e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:38:22 +0000 Received: from BN8NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10b:cafe::f6) by BN9P223CA0023.outlook.office365.com (2603:10b6:408:10b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:21 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT010.mail.protection.outlook.com (10.13.177.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.33 via Frontend Transport; Thu, 13 Apr 2023 17:38:21 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:21 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 10:38:20 -0700 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff2291d1-da21-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTAkMA4qWNy5q7AncRiVsRwX/Y3Qu1od1qromFsPaqgUv5cMHBc/oHTNDRERP0biw+4lHXWPY+7AiVKVkQA73Xo7U3Omyi3Uwl7uhTw7xhJnjPB2vxSoZjoF0YFHFeOhRu4comZXNnVqjB/MbMV0dN+qd6rwz6TPPfl5/Zja/v86vfKiP8tfx1Dgyq7FfGB6AG/mbRKZ2BZlZGLSeplLhB6rU/tVx8MDE9yB0uMpNfSGLlmmA5fMjo0fpdnAY7uEsHu5TlR4hGVIlESCPPDgvq4mKdQFEhRkHeFOSjwEGxIUh3PGCmwpzLKTwTfgY97BTItfnRu++mAM6BLuHtFQug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eTQJ7lPK89ZtnWjeWUiqYAA5GuUNieXG2h1mgdQDvYw=; b=QdMKqOmqqWuZ2g7ks9ZCSbK/joHEmJncSmxizfVXTyzdpihHkosinviFCrHKgdR/1fRYDum+U/PJEyS5bjhYxa0tmET0UEC0lpNLbIqOStHCh3x7q4nMezJi8GEbRBKO2KJpnNZ2SGY4MIYSeFGo7YlRS2QCzOkH3Cdvy/S8jd27MqfD4JB3mj2oVhX9Pj7WFAesd0KUcXTngISzxLgPX6PqU0WQm2b8ufMttTneawb3e1PSfcSeDpw0/lr8cvzvW1OfDoymZni4ORPOlaC4eihVkCqVUXS0TxTTRv0hp83VO6NmWCKWeopsztvoAjRFNup2x3M5bQZZV+DZO1ACtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTQJ7lPK89ZtnWjeWUiqYAA5GuUNieXG2h1mgdQDvYw=; b=vqHOMzgyq886Y1jjUWpFN3KHM7/VP2C/5TVEbTt7HIDsj1blMl6FsHRWmcY7uwKJgyQxybq33DTw6wQHhf0jWbKMg4F7RNFcCW4VA3DAjBpweHUm3LU0EXwWQQB8rVt6c4wamMgwyePtSc3AcUfHNfxCPU4Mk5EFoaHlXmHnkpA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 06/10] xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_PHYS_ADDR_T_32" Date: Thu, 13 Apr 2023 18:37:31 +0100 Message-ID: <20230413173735.48387-7-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT010:EE_|SJ1PR12MB6099:EE_ X-MS-Office365-Filtering-Correlation-Id: edeceec4-7f4a-4f4c-54cd-08db3c45e046 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sXZ/mepfmmEommLgduBj8X7Rq+imLHEjXk+9t4ECL+FTnjEuN+QMWM6tIw/KJSdVxiVaH9iz9H8QLzLNJ1hc5Ew0BHnEdMt02fgRbMtXlc3FHjbfEztZI3tO3W0IHAer+0/FYY/pBSTqpHwnoWgGt/hC8oedIFI4uwajR4lXnbdfyrQC7bxbqCRH1VYj5reynX1eq1M8FiLn9WVhgzWM3PxO6YUpR0HL4TAZWeMZqnj216Wcx8V057HKAAyGkZToye+aM8unSp7cXXPUciCjNsXa017GJkerITYGEabvzfR7FWx2jnS/MCCzXwgmSaXOIGjTOKC5c301zP9zyxbdlaArNC+nANVkhwuH3RfXDCTgA0QtT3+P7zT0P6wHVFV6QI2r+HndtUG59NZ6pIxCe9H3cPBoso5kg1lcmqFxx+BX/+5g4CM3JYi6G6PypipuFt8n6Zm1Pl8oXxfKoAo8lRkHi3DTHD9P5TfmRkSBn2Lui1VO755SbPYbXLsLF1hd1Yo6l4VrpfQ4ky81Rqnfn9xlDEDUWgo/GFuBkLUBXmIQXZlmNkas9GNAZuXPBBaVuaT5DX6EBD6+xeiFf/8+q8CfIjYNyUlqw3O4U/1813Jvwy7BeLhjoGMD7Vszts2w2D9bfNz+abQWfCisudshRLDCW4ck7DL+AoAldQ23W16DOMTzCJaRh+ZWYLaugFSU5aY7JXSmxVONbaNpnFl8iAgUXy/LClDLNQplxxQz7wQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199021)(36840700001)(40470700004)(46966006)(316002)(6916009)(4326008)(82740400003)(70206006)(70586007)(2616005)(47076005)(426003)(336012)(5660300002)(41300700001)(82310400005)(6666004)(36756003)(86362001)(40460700003)(54906003)(40480700001)(26005)(186003)(1076003)(103116003)(2906002)(83380400001)(7416002)(8676002)(8936002)(36860700001)(478600001)(356005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:21.5704 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edeceec4-7f4a-4f4c-54cd-08db3c45e046 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6099 As the previous patch introduces CONFIG_PHYS_ADDR_T_32 to support 32 bit physical addresses, the code specific to "Large Physical Address Extension" (ie LPAE) should be enclosed within "ifndef CONFIG_PHYS_ADDR_T_32". Refer xen/arch/arm/include/asm/short-desc.h, "short_desc_l1_supersec_t" unsigned int extbase1:4; /* Extended base address, PA[35:32] */ unsigned int extbase2:4; /* Extended base address, PA[39:36] */ Thus, extbase1 and extbase2 are not valid when 32 bit physical addresses are supported. Signed-off-by: Ayan Kumar Halder Acked-by: Stefano Stabellini --- Changes from - v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". v2 - 1. Reordered this patch so that it appears after CONFIG_ARM_PA_32 is introduced (in 6/9). v3 - 1. Updated the commit message. 2. Added Ack. v4 - 1. No changes. xen/arch/arm/guest_walk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c index 43d3215304..c80a0ce55b 100644 --- a/xen/arch/arm/guest_walk.c +++ b/xen/arch/arm/guest_walk.c @@ -154,8 +154,10 @@ static bool guest_walk_sd(const struct vcpu *v, mask = (1ULL << L1DESC_SUPERSECTION_SHIFT) - 1; *ipa = gva & mask; *ipa |= (paddr_t)(pte.supersec.base) << L1DESC_SUPERSECTION_SHIFT; +#ifndef CONFIG_PHYS_ADDR_T_32 *ipa |= (paddr_t)(pte.supersec.extbase1) << L1DESC_SUPERSECTION_EXT_BASE1_SHIFT; *ipa |= (paddr_t)(pte.supersec.extbase2) << L1DESC_SUPERSECTION_EXT_BASE2_SHIFT; +#endif /* CONFIG_PHYS_ADDR_T_32 */ } /* Set permissions so that the caller can check the flags by herself. */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520869.808973 (Exim 4.92) (envelope-from ) id 1pn0u0-0003Rd-Jm; Thu, 13 Apr 2023 17:38:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520869.808973; Thu, 13 Apr 2023 17:38:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0u0-0003QK-Bd; Thu, 13 Apr 2023 17:38:32 +0000 Received: by outflank-mailman (input) for mailman id 520869; Thu, 13 Apr 2023 17:38:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0ty-0000rf-Jp for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:30 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2060e.outbound.protection.outlook.com [2a01:111:f400:7e83::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff6d9a91-da21-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:38:28 +0200 (CEST) Received: from BN9PR03CA0804.namprd03.prod.outlook.com (2603:10b6:408:13f::29) by CO6PR12MB5459.namprd12.prod.outlook.com (2603:10b6:303:13b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:38:25 +0000 Received: from BN8NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13f:cafe::d0) by BN9PR03CA0804.outlook.office365.com (2603:10b6:408:13f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:25 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT103.mail.protection.outlook.com (10.13.176.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:24 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:24 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:23 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:22 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff6d9a91-da21-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQn2M8pWbl2jB7tc/Ag8Zx07cgVO49EN7iGXkxIbIW+FZUV+jqbOcXIq1sENatxoLbtEhB0Zyj/OL7W5CEOFbBYmQu32o+hGsRAnx1UeHuvmmUZwFEZHPjxmpp9/3FERydTxtBUiDLOJB8JMzOqFVvDuZo9g/WdIkTvm7Fane1K+u+k1wOBFG6eyq9u4YbAevnJYmstQWZfv5u+uUpWk5sbFCOeOdKQtSq9LtehYDkxKnEItGGOf0WgiM2Ty0LsEVINg4ltwHbu2bLnmCdQuXjIGkahE/gLBx2yjnF0AoixxIOpbEpidOp7PVFfAxaO5tESklzqokz4Rjk6ZbMvFcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mYDtZ/9ITc1VO1Lc7mTKB3Dr1Wuk5Ug6oJSWDmGegSc=; b=A43q0DJB7kb2klo9rLvydenhxMyVW3/danjiK3WNmgAoPqPwKVDGOhGpMC1zvbtJGHHlOkkmYvlWmFh1hRMg/L/zc4m4Wj4jDeH0V5YjVmoTJWxiQHPDeFFoX7cSIA/tKR1Id5Ypnrh3bZLmNvAx3YRiuQlfjROVB/ikwGRWwS4IJfcZW0pRL/qlOGO5Bk2icKeYtyYMP3sjik41nE0jOd7JOG1dHZB3mb1/Zi8rm0aJjrcC8PmfPYvtKZcaGkj+J1CvvuG2N3gEgGxKJ+hZdJm/oO8pJIy+zWQ7rArmtDcEdJCPXeMF6Qyws0fou9r2d/iqOA7SwYWApgZHdR3UMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mYDtZ/9ITc1VO1Lc7mTKB3Dr1Wuk5Ug6oJSWDmGegSc=; b=B74EyGQmT0A80kK5WDbx9XYlYeIgKjTcAZ/wBrClnIDoB/UYIgKbYMWrUjSySxnRKbYu9ILLBW/4Fktpy0M1Yd8GaLXswY34OL3ZRb/5JZ7p1dDdEan8l0enr+dKRHE9P+eglWo3p2eI52K1puT0GVlW+rOT/8OSTW1/EdFLVwM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 07/10] xen/arm: Restrict zeroeth_table_offset for ARM_64 Date: Thu, 13 Apr 2023 18:37:32 +0100 Message-ID: <20230413173735.48387-8-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT103:EE_|CO6PR12MB5459:EE_ X-MS-Office365-Filtering-Correlation-Id: a09b65e1-a62c-4f92-61d3-08db3c45e1f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aMbQQyI0lhjB3Ol7ogO4+excqyipn5GqqqDSeN/UqMAq9vzOnoFksbyhlkHEk2P0n86ZZeMpenwIQ+cogYthlkd5q7xYOFsRpzmCGDsVfAj6+nqRFgpqKpW+F2pxUAbutXyBqdUstnApCphwDvhcpdaHLAjfpKQPzTR4iSy1guPC1woiN2bploUbzHWSgOQ9Gd3O56hACfjUALgjuwbsDayZ7hKzdTpjNbae3mvHPZyFTf57PMzV6RqOZHMBB7gocl5TB18SxkpPuHW9Sw7uKG2/gbCtSPOlkCCMccMsnBnVwAl6x6XpFpN9JgPJ7b/Ci3bfADvA3dvChmnZQO7ed069ao89BHm0caX3h3KGx0TcZ/74nzbwKKe4rS3hIzWt/GgDclhqZ8evNXXDfp/NZOVF0fLqOw//3RhgQCOcaxZWjtgrLa+v7MqktRdpYeYHrE9cjBtvoYPt30mfByFuFMhbXWuDRdzuIocaSqKmtuVLf+AoBsf8mKxZwnUyyL4rrjxbZ6bMP/skcA0F5vKddUgVyJShphqw96MKTwjApHojV5WLSNEyMMbsXuWvkRzbdpkkMrTs+gg6yN3srKAUaleITMpoc5W3Qt9kq/mE3hvbuZc1myOJuVtKX8mKbbpgY5CSg8eqi8uoPHKf4CoGJqc6syA6qjMOZlmeeg9Wx7H29e0H7hoYKNd46RHO7umEfrFGBSl5TeKA172PFskc/WJ6oulYJPEqkmbvg433Fvg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(316002)(41300700001)(81166007)(1076003)(26005)(186003)(86362001)(6666004)(47076005)(356005)(36860700001)(2616005)(82310400005)(426003)(336012)(83380400001)(82740400003)(6916009)(4326008)(54906003)(36756003)(40480700001)(70206006)(70586007)(8676002)(8936002)(5660300002)(2906002)(7416002)(103116003)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:24.3756 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a09b65e1-a62c-4f92-61d3-08db3c45e1f2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5459 When 32 bit physical addresses are used (ie PHYS_ADDR_T_32=y), "va >> ZEROETH_SHIFT" causes an overflow. Also, there is no zeroeth level page table on Arm32. Also took the opportunity to clean up dump_pt_walk(). One could use DECLARE_OFFSETS() macro instead of declaring the declaring an array of page table offsets. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - Removed the duplicate declaration for DECLARE_OFFSETS. v2 - 1. Reworded the commit message. 2. Use CONFIG_ARM_PA_32 to restrict zeroeth_table_offset. v3 - 1. Added R-b and Ack. v4 - 1. Removed R-b and Ack as we use CONFIG_PHYS_ADDR_T_32 instead of CONFIG_ARM_PA_BITS_32. This is to be in parity with our earlier patches where we use CONFIG_PHYS_ADDR_T_32 to denote 32-bit physical addr support. xen/arch/arm/include/asm/lpae.h | 4 ++++ xen/arch/arm/mm.c | 7 +------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h index 3fdd5d0de2..7d2f6fd1bd 100644 --- a/xen/arch/arm/include/asm/lpae.h +++ b/xen/arch/arm/include/asm/lpae.h @@ -259,7 +259,11 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); #define first_table_offset(va) TABLE_OFFSET(first_linear_offset(va)) #define second_table_offset(va) TABLE_OFFSET(second_linear_offset(va)) #define third_table_offset(va) TABLE_OFFSET(third_linear_offset(va)) +#ifdef CONFIG_PHYS_ADDR_T_32 +#define zeroeth_table_offset(va) 0 +#else #define zeroeth_table_offset(va) TABLE_OFFSET(zeroeth_linear_offset(va)) +#endif /* * Macros to define page-tables: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 6dc37be97e..247510ac57 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -221,12 +221,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr, { static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; const mfn_t root_mfn = maddr_to_mfn(ttbr); - const unsigned int offsets[4] = { - zeroeth_table_offset(addr), - first_table_offset(addr), - second_table_offset(addr), - third_table_offset(addr) - }; + DECLARE_OFFSETS(offsets, addr); lpae_t pte, *mapping; unsigned int level, root_table; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:38:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:38:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520870.808986 (Exim 4.92) (envelope-from ) id 1pn0u2-0003xL-15; Thu, 13 Apr 2023 17:38:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520870.808986; Thu, 13 Apr 2023 17:38:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0u1-0003x8-Sx; Thu, 13 Apr 2023 17:38:33 +0000 Received: by outflank-mailman (input) for mailman id 520870; Thu, 13 Apr 2023 17:38:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0u0-0000rf-43 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:32 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20616.outbound.protection.outlook.com [2a01:111:f400:fe5b::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00b15c15-da22-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:38:30 +0200 (CEST) Received: from BN9PR03CA0464.namprd03.prod.outlook.com (2603:10b6:408:139::19) by CH0PR12MB5106.namprd12.prod.outlook.com (2603:10b6:610:bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 17:38:27 +0000 Received: from BN8NAM11FT104.eop-nam11.prod.protection.outlook.com (2603:10b6:408:139:cafe::75) by BN9PR03CA0464.outlook.office365.com (2603:10b6:408:139::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:27 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT104.mail.protection.outlook.com (10.13.177.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:27 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:26 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 10:38:26 -0700 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:25 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00b15c15-da22-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aH+Zr849Fo64fg+pXGsVYf5EHX5ceYm9v4BSa/xIJEgJySUpm/TpwUvcclB6UglPqEbI2T9x28+ki+kzBGxtG+hLW7e0oshtjWcOVlNt2XPxpBAgrFaM8s+wQlVNwQeU67sX13QgtJz1xqEB01dY+FKyhkZKOOiXuHBPye3I0Z77y1dA6za2TvBbqmvwRQgwuB/SNaW97xKacVXXiVQ1/Xk/4OBqkivCV3EgZSNPE2hEDu+0XUM9xFnNZopUefD8hghPBDpsXVBgtUZHCacJMEVoDsuaP9Jr7BVlojoPGtpWMLoqIiNYVRMCDK6JjqFDapz00N7PI0jX5i3aXm8yjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8DOUnV1l7YFE+Fgge1cDptrXAMS0Z5E0PBq8a/I6OGs=; b=JdS3NgRtL+UpNBoW+sWqzDwtV9iViFx/ZYPAmtqpfFF4SokOHjj4wbTt+7YuGlJ7SdE7b/Vo5m6x7Ws2YsqpPdof+ekcrbb1p9i+4+xx3TlhvH8EYrF/2Wlx6eokrx4fu1SrNP46EXn5aXwHwAjet21IrEbLyX5VkoFy8kUmddVJ3RAg/oJEgUObHN5L3zbL1dnALhHQ8aBj5rpQasIjRDgTL1b0F+7Ie3rIcmF6+UTThd3PZweliXboJBZednVP5eZGQhanyXaTnst6PdIzIDyFxnD1eCcoFCnoqy89Pzy25pBXiI5KSzKzHt7qmAfAH4tliDQAGlL9GzVd9hTHRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8DOUnV1l7YFE+Fgge1cDptrXAMS0Z5E0PBq8a/I6OGs=; b=MsdUC9FOjQo0KMvXQ8Yj50daQlpRrKzCmyMX4QbJhGKuw3uc/STM+JVy1JKdTKzvhO/L0770htzBZkOaReYSg956Gah8r8mgIgidudSw0Wsb+fVVY7dUkipXilMQtjoAx0rFHR6MuKyBkYH6HkseYSu3z3vyHWp6J4dDIH+UV/E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 08/10] xen/arm: domain_build: Check if the address fits the range of physical address Date: Thu, 13 Apr 2023 18:37:33 +0100 Message-ID: <20230413173735.48387-9-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT104:EE_|CH0PR12MB5106:EE_ X-MS-Office365-Filtering-Correlation-Id: 94e40bd9-7988-4fb9-219f-08db3c45e389 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vaf4P9OhiNSluRFPCbbs7OSxO7iGI4TRH6O1mrpYku5q1HrBOkngH2ehaCCyjBEOjy/+E5I+zHN01gSTLz911cDtkQFw6PXLnF0ofZH/fjXysb7OqyPs3hcEEt3onqgffjqMfDIvn1xOf9XDh4U06ZqxB0ieUl2hAXCcFI8PEZuboZhgTWTXn/Q1XnPomNTiftSlFiP/vxDLRaj7qULQun1+7js0ffSkp5miloQQhGUtTYX/8AWIELNINdiuGMDU9WSly53NKyK4kntAtHASS2mnc977t7SyE9WBYne9b8aDdu0cl0UtiumfrmwN1V1ffW8G7zmNgCfNOC2PB4dyML7IqaWmtX3TfKsYqjJPk0E1I/P9+/zMG5fEafAnHVTrRazQ9KWfW0mEn++Whr7zqElqfrTQY4y/lB9BMIKNwOvCoHXLgvwaDVNefgR+j3YeDlEy7d3oheBVXRTl6rxEjt8d7IjQdlUxjOnF25cD9qkjAWxuSCjM6AXCKHJGEG+VqK2UOw5U/Ss+S0/3KzWNq1wSpyZa1Q+56FAEZrATgok8SvuLrmYJy9+CZe7vKVZ+ojyKmO3Y62CVUJ5yxj0LUzjpqvGzY1ZgjH9zGa1RMRYWObzZEkePVvhRBHKuCWz0sVBIa0YVedIQYeGx/sdik6nsG3juUJSk0o5uZbo819u+rxDppwUXD8TR6jsuwShJO9xzmEgzkcG82AwfZt8qYxqvgQusO61W7UbhOl0XEXY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199021)(46966006)(40470700004)(36840700001)(103116003)(36756003)(86362001)(41300700001)(316002)(4326008)(478600001)(8676002)(70206006)(6916009)(54906003)(70586007)(82310400005)(6666004)(7416002)(40480700001)(5660300002)(82740400003)(8936002)(2906002)(356005)(36860700001)(186003)(81166007)(83380400001)(1076003)(336012)(426003)(2616005)(26005)(47076005)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:27.0413 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94e40bd9-7988-4fb9-219f-08db3c45e389 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT104.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5106 handle_pci_range() and map_range_to_domain() take addr and len as uint64_t parameters. Then frame numbers are obtained from addr and len by right shifting with PAGE_SHIFT. The page frame numbers are saved using unsigned long. Now if 64-bit >> PAGE_SHIFT, the result will have 52-bits as valid. On a 32-bit system, 'unsigned long' is 32-bits. Thus, there is a potential loss of value when the result is stored as 'unsigned long'. To mitigate this issue, we check if the starting and end address can be contained within the range of physical address supported on the system. If not, then an appropriate error is returned. Also, the end address is computed once and used when required. And replaced u64 with uint64_t. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1...v4 - NA. New patch introduced in v5. xen/arch/arm/domain_build.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 7d28b75517..b98ee506a8 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1637,15 +1637,23 @@ out: } static int __init handle_pci_range(const struct dt_device_node *dev, - u64 addr, u64 len, void *data) + uint64_t addr, uint64_t len, void *data) { struct rangeset *mem_holes = data; paddr_t start, end; int res; + uint64_t end_addr = addr + len - 1; + + if ( addr != (paddr_t)addr || end_addr != (paddr_t)end_addr ) + { + printk(XENLOG_ERR "addr (0x%"PRIx64") or end_addr (0x%"PRIx64") exceeds the maximum allowed width (%d bits) for physical address\n", + addr, end_addr, CONFIG_PADDR_BITS); + return -ERANGE; + } start = addr & PAGE_MASK; - end = PAGE_ALIGN(addr + len); - res = rangeset_remove_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end - 1)); + end = PAGE_ALIGN(end_addr); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -2330,11 +2338,19 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, } int __init map_range_to_domain(const struct dt_device_node *dev, - u64 addr, u64 len, void *data) + uint64_t addr, uint64_t len, void *data) { struct map_range_data *mr_data = data; struct domain *d = mr_data->d; int res; + uint64_t end_addr = addr + len - 1; + + if ( addr != (paddr_t)addr || end_addr != (paddr_t)end_addr ) + { + printk(XENLOG_ERR "addr (0x%"PRIx64") or end_addr (0x%"PRIx64") exceeds the maximum allowed width (%d bits) for physical address\n", + addr, end_addr, CONFIG_PADDR_BITS); + return -ERANGE; + } /* * reserved-memory regions are RAM carved out for a special purpose. @@ -2345,13 +2361,13 @@ int __init map_range_to_domain(const struct dt_device_node *dev, strlen("/reserved-memory/")) != 0 ) { res = iomem_permit_access(d, paddr_to_pfn(addr), - paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); + paddr_to_pfn(PAGE_ALIGN(end_addr))); if ( res ) { printk(XENLOG_ERR "Unable to permit to dom%d access to" " 0x%"PRIx64" - 0x%"PRIx64"\n", d->domain_id, - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); + addr & PAGE_MASK, PAGE_ALIGN(end_addr) - 1); return res; } } @@ -2368,7 +2384,7 @@ int __init map_range_to_domain(const struct dt_device_node *dev, { printk(XENLOG_ERR "Unable to map 0x%"PRIx64 " - 0x%"PRIx64" in domain %d\n", - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, + addr & PAGE_MASK, PAGE_ALIGN(end_addr) - 1, d->domain_id); return res; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:39:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:39:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520877.808996 (Exim 4.92) (envelope-from ) id 1pn0uR-0005I9-Dv; Thu, 13 Apr 2023 17:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520877.808996; Thu, 13 Apr 2023 17:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0uR-0005Hs-Ay; Thu, 13 Apr 2023 17:38:59 +0000 Received: by outflank-mailman (input) for mailman id 520877; Thu, 13 Apr 2023 17:38:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0uD-0000rf-Tc for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:45 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20629.outbound.protection.outlook.com [2a01:111:f400:fe59::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08bf1265-da22-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:38:44 +0200 (CEST) Received: from BN1PR12CA0029.namprd12.prod.outlook.com (2603:10b6:408:e1::34) by CH3PR12MB7618.namprd12.prod.outlook.com (2603:10b6:610:14c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Thu, 13 Apr 2023 17:38:40 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::b3) by BN1PR12CA0029.outlook.office365.com (2603:10b6:408:e1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:40 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:40 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:40 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:40 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:38 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08bf1265-da22-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IpfOCpxxw3i55eJofDliLG79xwMHrN9zM1RrU9iUWchqAFkd6S/h3eyDrs3pGiFo8Ifb2DXpAn+x2VmhjkyiXWLSiAnAwG2gQJaL6WUWOWng9NUVDoeGxYe4OoUJ3BVDVTbodyN+Vha6/VlC8pjDQQncwSnwL6klmbPdU3rKVy8jP67Uh92iAckIHaXT2WrUOIdmKkJ8c48LuLOy8LWE8KqpU4Mx30VQgpEnyNKVYQG1KV31akTAx4yS3JFrwilK7Hbx/cMRxuR7ZnXPgU2+mdqbRBmaOz3F8lyQj9A1nI7mUrvdWFaamXv5E4OL/Tdq91vsyo/39MYltQ5YlCBYTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s0Jv/eP8TblDgr/FC5ImnfRMvlRSI+Z7UaQME8KEVKw=; b=Rmi2FH3pDqxm9aw9ZkTnkAI0xvbQhNlUE/3FyAh+2KS5A+DmYzuuDUmXgDI6z3zvHt8myxHR8d+ss4c9SowWBFVo9gY8APVpx7aSScrNieyjpABWs2XTKq1RzXezD6jOrC/116OG/iNxPeOYQdZwe1kQHMae5SfU/ZuK4dBBIPOKBFg9yxcK42PLvrNv2Yu13zF34PPP6dJiYf9pZDffQWMkW3YCIQHJTjXpesoBTqaaoJtoOGqIX+GwQ4Gxe0ze9os+98I0SHfx+Ok7HMnBonjJ0hI17DF7xpnhg6RMXOTkTEMwB9QgzljkJRz2tt4UKeQ20obghAphboK9FreBLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s0Jv/eP8TblDgr/FC5ImnfRMvlRSI+Z7UaQME8KEVKw=; b=gflHkHsPF8gff8+/kbhJx8Li+Yw2ZffhstP+ft8TB6nJm7TJ9G19nBru/g04I+kQvjPI+pehGelE+h5r4MO1X+Q/ee7QPPsMI71W3/NnaaElDKGnht72tlLlOIWDE8HUJQ70/hoYjWVy9VWWZ88mXRzhpOulFg/NSPUzT1JOeac= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 09/10] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64 Date: Thu, 13 Apr 2023 18:37:34 +0100 Message-ID: <20230413173735.48387-10-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|CH3PR12MB7618:EE_ X-MS-Office365-Filtering-Correlation-Id: 21a193d6-7f89-415a-42af-08db3c45ebbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zv3qJxC33MucVc5vCEjLXLBXbDu7K1QsBy1Cb2EdaNGYX2Lx8M+79hyS5AIJjRED/uW3KwsDObiIvpPMfNO9S4wAYZQJbpsQ8Vwev2NNq+fXsv3z1l+b1EWihmrzNO39mExgopc8bFjZ5kO8SlLgpFCxfr/Mzd8T7NvjLnGMhn1mVIzIhFwC/bf42RMa7PhBYjzBrOhfz2Ea7/g8Yz91vCjqaC9sc9XbVh/eHA9RLAhKSZ6ODhgxri4s8HHycyUIU5Q6JQK1+D+7smPCDys+6FvoFHqyDTadurejah6VGXuXNzNpUxLOxdirMiJn+zLBjcF6WTxB+dI9q4Zu6QWeG3EavMksmgvuVykn324DPbY8NrV2+VHbZy4WxxkiduOo9didWBPzC9UNdS4/RxFtN7y/6z1aUVeHm1Jn9ENyWUvnP1+B5esN8f7wWaNzWBh0dm4fGC3KEwO7jWq2zfSwJKGtPHG1Z4vbzwfMumyvDEJXVvyfditoHHL+QRd8lx1DdqM9ltzaYel3hykMfFMboxoBQqfiJTLXJgDKTS3OSu6o0LlXWJVk50VTRxsEuh6DKN+xHS+dY6xff/Ku2BkHjqPQhx9pHeQR+1FjsQ5BuUl4JWbPAS6m9dzaCGiNJLHbwzMoX9ND/Pal4GWfXh+WMdiLud6B0ctED5/gtWrgIsB1f16J/nZ09OI5qdyu/EHcJDX95Lc2PNgJLJ7nVLhzsHuJVDE88PMWVVp4CWRCzRg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199021)(36840700001)(46966006)(40470700004)(26005)(1076003)(40460700003)(186003)(103116003)(478600001)(36860700001)(82310400005)(316002)(54906003)(36756003)(5660300002)(7416002)(8936002)(2906002)(4326008)(6916009)(8676002)(81166007)(356005)(82740400003)(86362001)(70206006)(70586007)(41300700001)(40480700001)(6666004)(83380400001)(2616005)(426003)(336012)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:40.8052 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21a193d6-7f89-415a-42af-08db3c45ebbd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7618 Restructure the code so that one can use pa_range_info[] table for both ARM_32 as well as ARM_64. Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as p2m_root_order can be obtained from the pa_range_info[].root_order and p2m_root_level can be obtained from pa_range_info[].sl0. Refer ARM DDI 0406C.d ID040418, B3-1345, "Use of concatenated first-level translation tables ...However, a 40-bit input address range with a translation granularity of 4KB requires a total of 28 bits of address resolution. Therefore, a stage 2 translation that supports a 40-bit input address range requires two concatenated first-level translation tables,..." Thus, root-order is 1 for 40-bit IPA on ARM_32. Refer ARM DDI 0406C.d ID040418, B3-1348, "Determining the required first lookup level for stage 2 translations For a stage 2 translation, the output address range from the stage 1 translations determines the required input address range for the stage 2 translation. The permitted values of VTCR.SL0 are: 0b00 Stage 2 translation lookup must start at the second level. 0b01 Stage 2 translation lookup must start at the first level. VTCR.T0SZ must indicate the required input address range. The size of the input address region is 2^(32-T0SZ) bytes." Thus VTCR.SL0 = 1 (maximum value) and VTCR.T0SZ = -8 when the size of input address region is 2^40 bytes. Thus, pa_range_info[].t0sz = 1 (VTCR.S) | 8 (VTCR.T0SZ) ie 11000b which is 24. Signed-off-by: Ayan Kumar Halder --- Changes from - v3 - 1. New patch introduced in v4. 2. Restructure the code such that pa_range_info[] is used both by ARM_32 as well as ARM_64. v4 - 1. Removed the hardcoded definitions of P2M_ROOT_ORDER and P2M_ROOT_LEVEL. The reason being root_order will not be always 1 (See the next patch). 2. Updated the commit message to explain t0sz, sl0 and root_order values for 32-bit IPA on Arm32. 3. Some sanity fixes. xen/arch/arm/include/asm/p2m.h | 8 +------- xen/arch/arm/p2m.c | 34 ++++++++++++++++++---------------- 2 files changed, 19 insertions(+), 23 deletions(-) diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index 91df922e1c..28c68428d3 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -14,16 +14,10 @@ /* Holds the bit size of IPAs in p2m tables. */ extern unsigned int p2m_ipa_bits; -#ifdef CONFIG_ARM_64 extern unsigned int p2m_root_order; extern unsigned int p2m_root_level; -#define P2M_ROOT_ORDER p2m_root_order +#define P2M_ROOT_ORDER p2m_root_order #define P2M_ROOT_LEVEL p2m_root_level -#else -/* First level P2M is always 2 consecutive pages */ -#define P2M_ROOT_ORDER 1 -#define P2M_ROOT_LEVEL 1 -#endif struct domain; diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 948f199d84..4583658f92 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -19,9 +19,9 @@ #define INVALID_VMID 0 /* VMID 0 is reserved */ -#ifdef CONFIG_ARM_64 unsigned int __read_mostly p2m_root_order; unsigned int __read_mostly p2m_root_level; +#ifdef CONFIG_ARM_64 static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; /* VMID is by default 8 bit width on AArch64 */ #define MAX_VMID max_vmid @@ -2265,16 +2265,6 @@ void __init setup_virt_paging(void) /* Setup Stage 2 address translation */ register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; -#ifdef CONFIG_ARM_32 - if ( p2m_ipa_bits < 40 ) - panic("P2M: Not able to support %u-bit IPA at the moment\n", - p2m_ipa_bits); - - printk("P2M: 40-bit IPA\n"); - p2m_ipa_bits = 40; - val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ - val |= VTCR_SL0(0x1); /* P2M starts at first level */ -#else /* CONFIG_ARM_64 */ static const struct { unsigned int pabits; /* Physical Address Size */ unsigned int t0sz; /* Desired T0SZ, minimum in comment */ @@ -2283,19 +2273,24 @@ void __init setup_virt_paging(void) } pa_range_info[] __initconst = { /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ /* PA size, t0sz(min), root-order, sl0(max) */ - [0] = { 32, 32/*32*/, 0, 1 }, - [1] = { 36, 28/*28*/, 0, 1 }, - [2] = { 40, 24/*24*/, 1, 1 }, + [0] = { 40, 24/*24*/, 1, 1 }, +#ifdef CONFIG_ARM_64 + [1] = { 32, 32/*32*/, 0, 1 }, + [2] = { 36, 28/*28*/, 0, 1 }, [3] = { 42, 22/*22*/, 3, 1 }, [4] = { 44, 20/*20*/, 0, 2 }, [5] = { 48, 16/*16*/, 0, 2 }, [6] = { 52, 12/*12*/, 4, 2 }, [7] = { 0 } /* Invalid */ +#else + [1] = { 0 } /* Invalid */ +#endif }; unsigned int i; unsigned int pa_range = 0x10; /* Larger than any possible value */ +#ifdef CONFIG_ARM_64 /* * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured * with IPA bits == PA bits, compare against "pabits". @@ -2309,6 +2304,9 @@ void __init setup_virt_paging(void) */ if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) max_vmid = MAX_VMID_16_BIT; +#else + p2m_ipa_bits = PADDR_BITS; +#endif /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) @@ -2324,24 +2322,28 @@ void __init setup_virt_paging(void) if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range); +#ifdef CONFIG_ARM_64 val |= VTCR_PS(pa_range); val |= VTCR_TG0_4K; /* Set the VS bit only if 16 bit VMID is supported. */ if ( MAX_VMID == MAX_VMID_16_BIT ) val |= VTCR_VS; + + p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; +#endif + val |= VTCR_SL0(pa_range_info[pa_range].sl0); val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); p2m_root_order = pa_range_info[pa_range].root_order; p2m_root_level = 2 - pa_range_info[pa_range].sl0; - p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; printk("P2M: %d-bit IPA with %d-bit PA and %d-bit VMID\n", p2m_ipa_bits, pa_range_info[pa_range].pabits, ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); -#endif + printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 17:39:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 17:39:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520878.809000 (Exim 4.92) (envelope-from ) id 1pn0uR-0005Ld-Mf; Thu, 13 Apr 2023 17:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520878.809000; Thu, 13 Apr 2023 17:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0uR-0005Kg-JE; Thu, 13 Apr 2023 17:38:59 +0000 Received: by outflank-mailman (input) for mailman id 520878; Thu, 13 Apr 2023 17:38:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn0uI-0000rf-70 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 17:38:50 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20601.outbound.protection.outlook.com [2a01:111:f400:fe59::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b131b5c-da22-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 19:38:48 +0200 (CEST) Received: from DM6PR14CA0070.namprd14.prod.outlook.com (2603:10b6:5:18f::47) by SA1PR12MB5613.namprd12.prod.outlook.com (2603:10b6:806:23e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.43; Thu, 13 Apr 2023 17:38:44 +0000 Received: from DM6NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:5:18f:cafe::db) by DM6PR14CA0070.outlook.office365.com (2603:10b6:5:18f::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 17:38:44 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT089.mail.protection.outlook.com (10.13.173.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.33 via Frontend Transport; Thu, 13 Apr 2023 17:38:44 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:38:43 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 12:38:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b131b5c-da22-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JyCC0Wrq25jNWdJuqRlARvbyioVPtBe3BnWn08ydgVjAOrcKsJhgPhjLajeNFNuKsJ0z95iHkQZKTH+ZXYxYscokU2RugHLNVqyEITxUR+5Z8XdGO5BS2CjOAXMiIJz4anzYpft3WdVPLT7xgB93xTPdPTcUZRc4uGba7NnRsYXp9E3OfiU2pHY3YYKRZIwAf2l1n7W5quG2fUbIRRQKFfy9w28aejTtvSiTGXxN2Q9dBOimqop4mSs1Af7JSLKUqXe+w6uHgATKMmd5DU8cruewg4ApvcM1AhdUWoMWnpRLO5zzRK6Yhoa0mzN0OBjpSuzQsrPnykaLmvs63BxyBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vf1B+8bx5vatlGHL4Tv5xbYFLO09J4Ep2zXFRUGljAc=; b=f2+O95wcvF1I+OM851PIc9wfxLgzNrR1vWl+uewcfRKOnEh9se+hQ0JvvIejtOPrgJ6Hljemigq3fIiX1SCj5XBkhp+WZLk+6Q8D5dBgH1fN6vWBmACcJzeqUdYTHjLOxFDQSCEQDHEYFexdzOzzi39+CIfBffxjEknI1MT7/+K5fIpLeMjUCWUlQ4QFyJVGOiBixlVoE13/MYbBra4lc/b/0UFddZhHLVTUNDbHU+cJUck462bepEDpxmJBeJmkEpeo6zcURo5e+T+giKlorU5vYB+Bgk1Xye8sAmecUlvAX3qc2qMebGN9dYEq8QCa4CSkjt67yHeiIwcTzfBAhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vf1B+8bx5vatlGHL4Tv5xbYFLO09J4Ep2zXFRUGljAc=; b=5C7jYlvjlYl3IJJ9QSCqkQZXNAJFN3WP974TtsnanagY2sHy9yTJynyz6WIJcbG5Shu+TzJovEPy2qjSlAiOzyMP0HDGcVDSI48gCWQpIrwkV5OAxk+RRNVsz5Ejj6f81tkwg+RwyTxWyvta0txWSEw4l9gblUUmXCynWsUmgfE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v5 10/10] xen/arm: p2m: Enable support for 32bit IPA for ARM_32 Date: Thu, 13 Apr 2023 18:37:35 +0100 Message-ID: <20230413173735.48387-11-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230413173735.48387-1-ayan.kumar.halder@amd.com> References: <20230413173735.48387-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT089:EE_|SA1PR12MB5613:EE_ X-MS-Office365-Filtering-Correlation-Id: 963d6794-6a95-4b08-355b-08db3c45edca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ER1z/29ZTOY8UO9h2tgQxGQDoiWQW9PGvVYq5nWExc9gg6pMYgtFW7w1Q5Ra4s+Zi41VAXLs7aRnptqUlgsuKmh5pda5q9gx3uzWw8u0IIxQPbPSlMZrNir88wnNKGTFKl+76f11tgldfVRHelY1X5BNWdaSYPitS/sWeMVP+78mey98PP6pPO62ntHqctcSdfExR6t5p2zK0iQljtupIug3ZzpzNs/QGosKzGwI5AQVROFACm4D0QyvJjn0/D/OQdcMLFwJGDIR/f2BlNt0UY3OZmtn4TNHGwn4+Da6024oqd5dTmXdiSvqho4bZPdpyDSN2G04gwC0Ky400imP0qILQod5l+sTSJns66pQFWmRn7Osb0iv4VMeuHiojBYO06dsEBAyzNbCWdcjQX3Dgz+VPrRK5WEU8JID+/gofpTFkFkA+W+z70Kun4GZb5Oy4dlJVidD6Y8ZM85QhBvIUlPLlh1QXAOLp7evGkjWFJimxaN2UFmn7G0To1hPgjiM0P4R2hjrh+Gl7dQGlMAkWZUgcdiE7pPjsSPbKxbAND6ivh+o0iNJUyQVF0aOJK9YPL7dn8HUgmg0mRqkV6vDY8XQ3VauxGDZfZ+1239M4qJUL32SqiHmo4TFC7jb34xLvBReFU94kwKtTDVnZK58h1n7SGSrqt8TZ7luwAmZ/znEzcvx5/ZMPdzI/ZTXNhwBmh4E50N7rqW6SrJdO/siEKKs1SnnKFzgItXPe4WYHc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199021)(40470700004)(36840700001)(46966006)(103116003)(82310400005)(40460700003)(36756003)(40480700001)(478600001)(36860700001)(4326008)(6916009)(8676002)(70586007)(70206006)(41300700001)(316002)(54906003)(2616005)(47076005)(83380400001)(426003)(336012)(6666004)(186003)(1076003)(26005)(86362001)(5660300002)(7416002)(356005)(82740400003)(8936002)(81166007)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 17:38:44.2105 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 963d6794-6a95-4b08-355b-08db3c45edca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5613 Refer ARM DDI 0406C.d ID040418, B3-1345, "A stage 2 translation with an input address range of 31-34 bits can start the translation either: - With a first-level lookup, accessing a first-level translation table with 2-16 entries. - With a second-level lookup, accessing a set of concatenated second-level translation tables" Thus, for 32 bit IPA, there will be no concatenated root level tables. So, the root-order is 0. Also, Refer ARM DDI 0406C.d ID040418, B3-1348 "Determining the required first lookup level for stage 2 translations For a stage 2 translation, the output address range from the stage 1 translations determines the required input address range for the stage 2 translation. The permitted values of VTCR.SL0 are: 0b00 Stage 2 translation lookup must start at the second level. 0b01 Stage 2 translation lookup must start at the first level. VTCR.T0SZ must indicate the required input address range. The size of the input address region is 2^(32-T0SZ) bytes." Thus VTCR.SL0 = 1 (maximum value) and VTCR.T0SZ = 0 when the size of input address region is 2^32 bytes. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - New patch. v2 - 1. Added Ack. v3 - 1. Dropped Ack. 2. Rebased the patch based on the previous change. v4 - 1. t0sz is 0 for 32-bit IPA on Arm32. 2. Updated the commit message to explain t0sz, sl0 and root_order. xen/arch/arm/p2m.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 4583658f92..746b6553e5 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -2283,7 +2283,8 @@ void __init setup_virt_paging(void) [6] = { 52, 12/*12*/, 4, 2 }, [7] = { 0 } /* Invalid */ #else - [1] = { 0 } /* Invalid */ + [1] = { 32, 0/*0*/, 0, 1 }, + [2] = { 0 } /* Invalid */ #endif }; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 18:52:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 18:52:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520901.809015 (Exim 4.92) (envelope-from ) id 1pn23A-00064g-5e; Thu, 13 Apr 2023 18:52:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520901.809015; Thu, 13 Apr 2023 18:52:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn23A-00064Z-2q; Thu, 13 Apr 2023 18:52:04 +0000 Received: by outflank-mailman (input) for mailman id 520901; Thu, 13 Apr 2023 18:52:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn238-00064P-7W; Thu, 13 Apr 2023 18:52:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn238-0002iL-3D; Thu, 13 Apr 2023 18:52:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn237-0006R9-Nz; Thu, 13 Apr 2023 18:52:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pn237-0004oD-NV; Thu, 13 Apr 2023 18:52:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TjXxm45zBNVOIash0eUhuMIhvkDb3dpZsGiqpfo5Z6I=; b=VKBy2rcwvrHJAkZZbukxmexqb1 Z0f/Ek7dZ+p2Xp52IHTYMhTW3IqolXvqd3h8rYgMC9XzByFMTgDqou2LMQEY9vQVWAaDgMCbJxH3F MPm1hYiGU2eJ7a48gBNR+x3yCKBnoOFgv0eTqROdnquVnWIepXOp+wpoHGy/yVrXqbbs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180227: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=152770333449cd3b78b4f5a9f1148fc1f482d842 X-Osstest-Versions-That: libvirt=7e1b4cc19cefba11763d09799f2b742658a9a03a From: osstest service owner Date: Thu, 13 Apr 2023 18:52:01 +0000 flight 180227 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180227/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 152770333449cd3b78b4f5a9f1148fc1f482d842 baseline version: libvirt 7e1b4cc19cefba11763d09799f2b742658a9a03a Last test of basis 180213 2023-04-12 04:20:27 Z 1 days Testing same since 180227 2023-04-13 04:20:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Jim Fehlig K Shiva K Shiva Kiran Michal Privoznik Pavel Borecki Tamara Schmitz jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 7e1b4cc19c..1527703334 152770333449cd3b78b4f5a9f1148fc1f482d842 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:22:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:22:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520907.809026 (Exim 4.92) (envelope-from ) id 1pn2WP-00012C-It; Thu, 13 Apr 2023 19:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520907.809026; Thu, 13 Apr 2023 19:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2WP-000125-Ev; Thu, 13 Apr 2023 19:22:17 +0000 Received: by outflank-mailman (input) for mailman id 520907; Thu, 13 Apr 2023 19:22:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2WN-00011z-G3 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:22:15 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ca232e4-da30-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 21:22:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ca232e4-da30-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681413732; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=krpY0wtoNjWcMka31rRBRO3yp3RjVetI0sS//BE8xhw=; b=KAzTi0p3iFpFj1hL1O/KOpNMnir565ZlNUb/NvKUj2oBbsZr+YBWkBT6 pTab9fmbds9y3+T3hLIgm4w8j4fuaFxn+9G0VBxA+d7oT3lgrAUvuPMku NrzFoPXJhp8YsmG3JZlKi0LLjv8jmgs5OTSoYZTwCW7ssuyQhhBFP8pyj w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 104783135 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:+eEsY6rynIfM5cg0R6oLAwQ8vT1eBmJjZRIvgKrLsJaIsI4StFCzt garIBnUbvuINjTyKYp+bYi08xhTsMCDnIMxHQA//iA1ECNDpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weCziJNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABU/SS2GjbLo++qQZ/J1tNQscdLzMqpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jueozupWUhBabRzzxKJwlaIrL7exR+kc6BVTZaVqsQ2jnaqkzl75Bo+CgLg/KjRZlSFc81bA 1wZ/Gwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbBRMddgnv88eXiEx2 xmCmNaBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyMg0f7epYtj0CmXZft4CZylgYDuAT/Zl mXiQDcFu1kDsSIa//zlrQmb223y/Mihoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawTIi8DqCENYYWOfCdkTNrGwk3PCatM53FyhBwwcnTx 7/AGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+ieD2TCfMEd8taQLeBt3VGYvZ+W05B f4EbJDUo/ieOcWjChTqHXk7fA9aciNkVcutwyGVH8baSjdb9KgaI6e56dscl0ZNxMy5Ss+gE qmBZ3Jl IronPort-HdrOrdr: A9a23:USoH2a/v/kMMr7SNbgFuk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M 5bAsxD4QTLfDpHsfo= X-Talos-CUID: =?us-ascii?q?9a23=3A4DpzJGugqkSH6A0bDW8SeoDo6IsAQFrgyX2AfXT?= =?us-ascii?q?gIktyUY+FRgKL4K1Nxp8=3D?= X-Talos-MUID: 9a23:MFKmwAX3nEn3pvvq/DPcoBVIZdYw3/uFKgdUurhagZWKHhUlbg== X-IronPort-AV: E=Sophos;i="5.99,194,1677560400"; d="scan'208";a="104783135" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen: Fold exit paths in find_text_region() Date: Thu, 13 Apr 2023 20:22:01 +0100 Message-ID: <20230413192201.3255984-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Despite rcu_read_unlock() being fully inlineable, the optimiser cannot fold these exit paths, because of the various compiler barriers providing RCU safety. Help the compiler out. This compiles to marginally better code in all cases. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/common/virtual_region.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/common/virtual_region.c b/xen/common/virtual_region.c index 30b0b4ab9c85..5ecdba9c08ed 100644 --- a/xen/common/virtual_region.c +++ b/xen/common/virtual_region.c @@ -40,20 +40,20 @@ static DEFINE_RCU_READ_LOCK(rcu_virtual_region_lock); const struct virtual_region *find_text_region(unsigned long addr) { - const struct virtual_region *region; + const struct virtual_region *iter, *region = NULL; rcu_read_lock(&rcu_virtual_region_lock); - list_for_each_entry_rcu( region, &virtual_region_list, list ) + list_for_each_entry_rcu ( iter, &virtual_region_list, list ) { - if ( (void *)addr >= region->start && (void *)addr < region->end ) + if ( (void *)addr >= iter->start && (void *)addr < iter->end ) { - rcu_read_unlock(&rcu_virtual_region_lock); - return region; + region = iter; + break; } } rcu_read_unlock(&rcu_virtual_region_lock); - return NULL; + return region; } void register_virtual_region(struct virtual_region *r) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:28:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:28:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520911.809035 (Exim 4.92) (envelope-from ) id 1pn2bl-0001eR-5l; Thu, 13 Apr 2023 19:27:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520911.809035; Thu, 13 Apr 2023 19:27:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2bl-0001eK-30; Thu, 13 Apr 2023 19:27:49 +0000 Received: by outflank-mailman (input) for mailman id 520911; Thu, 13 Apr 2023 19:27:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2bj-0001eD-TS for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:27:48 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062c.outbound.protection.outlook.com [2a01:111:f400:7eaa::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43a66ac0-da31-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 21:27:45 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by IA1PR12MB6019.namprd12.prod.outlook.com (2603:10b6:208:3d5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Thu, 13 Apr 2023 19:27:41 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 19:27:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43a66ac0-da31-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dbMjtnn6XXHNi3qbL/Ikf97TDDREslIOhyTqgaN690dknApJVZ3EznKbCckGaSidZE5GSHMEIjxEF75EKCs+L4k0GozkkWRPA2slhDR8Rvj04XCtyeZYft/kd+vvD/wzuzRARlZppiztdMx69WE35nOmndg52BBt+mqX/RHp2QAhSg+LzV/afMArxAv9xYt2XJ3YaNRa4Na7kcfd8GdYL6fXgENoRqlyaKcB0fUDE3AmYYiQRMmD49UZSFLVBvnMtFf1kqXPPPeFJ0RvbvGBt6KuhC4j27nmvYzwHLzhzeNbt4DjUGC5TPLfoIVJuudC53pZbLcewzkvQc15SP3HdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PL8Oe2EKSeHiiX45CknT0nJ4Lkp6F7sg+e7i9HnZpWU=; b=PqyGtT/B9uS46so+lSK3vsSqJ079mvNcJwCGDZgdv9/kQ6dxXS/f6DmVqDsdWgJ869GvUaUR3FDsOsBkjoRf9Q6zGrkb0jWx/CtukU+vL5e14kh1Sgq4GNEItp2n9WWhgR7dgZ7AeIc1LNQUHXZzuC1VSub2TYRifW8zE+oDWaRtHkrZGTCsoLcBQZi9RdTaA7R1B88Mg6ub/7E2SSCSR+HSq0PdOTFZtDJigX7ur7bD5Dcp1ynBZKDTQlsV3lZ7GC0ezkO3TGDv2Cn2i9CwiPjV6Owdi4U26PzcAKyXCcj4wl3CLFEXi04vFhIbRAHmL0VdsAIM+cV2OtgVuOgjSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PL8Oe2EKSeHiiX45CknT0nJ4Lkp6F7sg+e7i9HnZpWU=; b=YJ/LH0m8wwbb8QPXXgiK1QuAdl8ZJnwLJMunRcci6+1xj0pQtH32b27+QlSqe0jPl7o9F6UCN0RcGlNqwl1b2M1elqebMnDT6Evrl8cjCN4SKEYKqOM9DjgKfEhvqMKj3sxflq/1BdKeiXJDNXS2W8Cno+LyrxTB4ubUyQuZIg8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <7ce2f5e3-4f22-46e2-2e51-197aba861671@amd.com> Date: Thu, 13 Apr 2023 12:27:19 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 03/17] xen/arm: Add CONFIG_OVERLAY_DTB Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-4-vikram.garhwal@amd.com> From: Vikram Garhwal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR05CA0110.namprd05.prod.outlook.com (2603:10b6:a03:334::25) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|IA1PR12MB6019:EE_ X-MS-Office365-Filtering-Correlation-Id: d3d7d03c-dbb7-47dd-a556-08db3c552620 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gDmkD2xtf4RrQB3t3mQz5aloJo1G7rh0jt6/qTdhLsX2YZwlPYJqCfAANhCLqLLSob0LYhvGxuNuPAK1uyNrxtewRmEJ21ftovZpWgrY68F/oYJfDcmHlmb/JR48sJVRganQroFlcieaJi3lxPbk/tAmxnYeF9jDh1tOpQHRNlTmnFfHPy6EZN7QwgabUuNxMpQebLn15oVabAgUPxMTXuUdyYRKctWNQUxst7UkT2jZcpyMJCUuTqaOmIpY8EOm0yX0dT7mTXS1azWOe8gv5Vc6N2LUu97t1ut2Qt97Ji8DANU8tgyFVoPtNUKjfZ9ECvZs6jxdPr0XLppr+fGJiXiGxfsxOZPgT5YvKdjk905VB1ixbKIPNszMhyuaLu0Y9XkewUAYBOvjmwhB31ZTvEedVdsRm7hs//6+sZJn5GJZQqjEwdNJR3zdsJu0oL71G5NSd710jIVYSaolNOqrg+lsHuqr/pm0VmiN/2pkd8Kk2qqWA5/qJBsASG3eskC9sQJSRr9DQuXHyHMm+KF5Fs1lI/aHem60xGRBQcmFPTMD2xUrE7I6Uj1+ULCKhi0qDE70YQybhkpwMZDAiqHfhycbekXHhOSzQ78HyoRYGHIRh2qWe1dGS28wAEtflUT6ImjlLjuKh9l9zrbZXooENg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(451199021)(86362001)(31686004)(38100700002)(31696002)(36756003)(41300700001)(8936002)(6512007)(6666004)(6486002)(44832011)(478600001)(5660300002)(4326008)(316002)(186003)(2616005)(53546011)(54906003)(2906002)(26005)(8676002)(6506007)(66556008)(66476007)(66946007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VG05UzF6V3FZM09LVXZkSlE4RlZ5VmZtUHNES1Z2SUVQdGdldDRsRnN5T0ZN?= =?utf-8?B?b2h4OUd1R29CL1pSLy9PZlprVWhxa3MzVDZBTUJoajNONnpGaXh3cWFwYnBY?= =?utf-8?B?RmpKcjBLUW9ncTRzSDhlcE04SHN2MXNRZFJkRjRTeEU2ZE43bkMwY05XUmU2?= =?utf-8?B?WDNjbXlvMmpjMWpJekpCVWwwV21RYVJYSnczVEpVaE9UTk5VeTJFbFhxeGE5?= =?utf-8?B?VFp0eFhHSDB0YzB5cXUvaEcrTENjTC9CaURjWlB2SkxTbEhFZ2FnNDBIc3lI?= =?utf-8?B?dWhUU2xzZHhBcDg5K2I3ZUdQUGQ1NFNKQnYwRUMrNFpSWHZHVWRpUVVXbENr?= =?utf-8?B?WTR0MmdWeGc4WGJwRUFORW5abkJvNGdMdDF4TWhMT2tiZWFoSUVJTHJPL1BV?= =?utf-8?B?ZW9NY2ZkNzB2TWtmU2xsWlM2cFRuaXJTZjJGK3B6MzZSWHozc3BnYWNNZ01s?= =?utf-8?B?dmpON0wrak0yd0s3Uzlra1krb0ZKeE9SZGlXZWpqMlRsWjRTVVZHTTdUUG1x?= =?utf-8?B?ZTI1RVlaeFd2Yzh0UzBsZFhLWk0wNVQ4RU0yV0MwclYvR1NpT1FQSGtaWW9F?= =?utf-8?B?UTNXajlsY2tjOW1tVTRDc1l5eVRRWVRXUUpRRGNKT1RGcytxSmpiVVgyZ1FO?= =?utf-8?B?RGlqQ0o4NUoxV1J3elJPWlZtU2V3NnptRDJWK3hXUHoycmliY0hWbXVJeG1o?= =?utf-8?B?MlJ3SFdLRVRUL0h0SXhOaG4yalU0dVdwWHFmb3dadkFBbVk2UDhFdVRaaXdO?= =?utf-8?B?K1QweUJZbHRYTGRob2Z2QXpQbS8zVFlxTUpjeGxPSVVHczV2Q2FCeUJJM3l1?= =?utf-8?B?ZFlNR3hSYUpRbFIzdTBXOWtUMkhhU29kd2RobjdXZ2FBRzFOZ29tWVVnNjR4?= =?utf-8?B?V25RTWN2MTVaR2l6ZTE3aktXelFoVHd4MUVUZUxNUjdDUGJic3g3YmxQOElv?= =?utf-8?B?cDlYZVVTa01GUmxXZm9NRmYrTEZDRnVENENyQVdUdEhNTWcybG5xc2F6Smg5?= =?utf-8?B?ZmV0d2dVdkNZemx6VVpsbU16TlAweTcxY3RadUU0Q0paMnJRUzZOeVNXR2Nk?= =?utf-8?B?QjVENUMrRExaUlQweHoxVWNKWWd2RXNvc2VBQTFDWEJOallQcEpBdXFqK294?= =?utf-8?B?eHlnZHRZR3Nhd0dqQ213NDZuQkVxeEZwS05MWFZnTkZETTZiTy9HS2JoRVBn?= =?utf-8?B?YmZKYUNucWlLQnl2cUVlMGJqQ3U1djNoaUQ3RTBEMENuMWQ1eHFRSUR5TWxK?= =?utf-8?B?SDlyaC8yWFRPSmU1SlhXeThJOXpUMXppVTZ4V3hZNDFqbE8rb3daZEUycktt?= =?utf-8?B?Y0VCT0oyUVJXeVZVTnk5dmx4dEczRm1LNDh6OXIyMWJRSzJBYTJGdFNRYWIv?= =?utf-8?B?NVd3c3dQMGw3dXpFT3pwVGhJUktJbHJMenUwT0lSK0dkUzR1L0FzcDNjOXpO?= =?utf-8?B?QlI0MGNTSEZaYS9aK0p5RDZuc2pWZjlFWXZzOW01SXlrelliTWxtdHpER1p5?= =?utf-8?B?OFp6WHZNV1RHczhwVU9UdTNZWkozNURiUEZlOGpWZ3V3TWFqcWVza3h6cFZP?= =?utf-8?B?WjczZy9VUGRhb0xLaktNSk9pSHBndUN6aXhaWlRVbTJXODVaQzh5bkJNVFJo?= =?utf-8?B?TjFrRmtudnBpSHZ4U0ZaY0c1cUYvU0lwMjcrNk1TSjdmZ0VPb3lUdXQydFh0?= =?utf-8?B?akhlTVkrWUdSZGhsMTlaaWRKWk51ZitXV0tjWmxQL3RrWmJBR0xuZm1zZm5m?= =?utf-8?B?OHF1Tk02R1RhaWRybms3THFPN1IrZE93aGVmVkpsckM4VDNON3FtOFhlMXlQ?= =?utf-8?B?aHgzU3ZvN2NFWnVUbDJMamxUb2tyeDQ2T1JiTjNtYUhjYnNuUTdySENaMnRQ?= =?utf-8?B?UE42eHFubnBJOTZabjdyVHdva085dXNsOGtrZjlDRmw5b3JDMVVkYXRXUVFZ?= =?utf-8?B?SnRpbFZNcjAxM2xRa3ZyRGJ6NStIbElwUEtmS3ZSRXJnbEhMTUpjWFJnbktv?= =?utf-8?B?WGVydzkrbnpVNllHL040RUh2VWhSSmN2RUw5aGpoc0poTTZxMG5wTU83bDlV?= =?utf-8?B?a0JJcTV2WnROTldob214NUJCcnhiYVNrbVNwVEJQcFpaaTFsRU1UYU95alBZ?= =?utf-8?Q?bm2sOC8UWTO15zriBFeqPiOf6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3d7d03c-dbb7-47dd-a556-08db3c552620 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 19:27:41.4652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Anuavt911F1VhPcn77OI1VJE/xNiqwIfTOzStT5Aw0EORqbVu4yXVbNVH2INyGTAW5FQwsq1vQfVoXRRvTxtBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6019 Hi Michal, On 4/13/23 2:58 AM, Michal Orzel wrote: > Hi Vikram, > > On 11/04/2023 21:16, Vikram Garhwal wrote: >> >> Introduce a config option where the user can enable support for adding/removing >> device tree nodes using a device tree binary overlay. >> >> Signed-off-by: Vikram Garhwal >> --- >> SUPPORT.md | 6 ++++++ >> xen/arch/arm/Kconfig | 5 +++++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/SUPPORT.md b/SUPPORT.md >> index aa1940e55f..0a31f40af4 100644 >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -822,6 +822,12 @@ No support for QEMU backends in a 16K or 64K domain. >> >> Status: Supported >> >> +### Device Tree Overlays >> + >> +Add/Remove device tree nodes using a device tree overlay binary(.dtbo). >> + >> + Status: Supported for ARM > Hmm, so here you say supported but in Kconfig - unsupported. > I think, this should be: > Status, ARM: Tech Preview > or Experimental Experimental sounds better to me. Will update it. >> + >> ### ARM: Guest ACPI support >> >> Status: Supported >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 239d3aed3c..1fe3d698a5 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -53,6 +53,11 @@ config HAS_ITS >> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED >> depends on GICV3 && !NEW_VGIC && !ARM_32 >> >> +config OVERLAY_DTB >> + bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED >> + help >> + Dynamic addition/removal of Xen device tree nodes using a dtbo. >> + >> config HVM >> def_bool y >> >> -- >> 2.17.1 >> >> > ~Michal From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:40:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520916.809045 (Exim 4.92) (envelope-from ) id 1pn2nb-0003YI-CR; Thu, 13 Apr 2023 19:40:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520916.809045; Thu, 13 Apr 2023 19:40:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2nb-0003Xq-9S; Thu, 13 Apr 2023 19:40:03 +0000 Received: by outflank-mailman (input) for mailman id 520916; Thu, 13 Apr 2023 19:40:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2na-0003NY-8k; Thu, 13 Apr 2023 19:40:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2na-0003rE-6T; Thu, 13 Apr 2023 19:40:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2nZ-0007jj-Ik; Thu, 13 Apr 2023 19:40:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pn2nZ-0002Lq-IH; Thu, 13 Apr 2023 19:40:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=70YuiFdaBmGYRLXWsf/sjI9TxOH8QbwNtHlLuyqweXg=; b=H6r8TCNAvn9kpkeOdPzX2Xl+tb lGcax7he2LMTMW0JPde6nDp+uS3RZz3iQPHitcBnwdrY4LoSed3aHJNo4cn2+iUcP3vF6HBOpbswX 4wZ0AhCoswnmYEwAymz4mA3UrYKDMrGJiVRdKnm6HgqMH9ukE7++QhO3Q98djh+8gKKw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180248: all pass - PUSHED X-Osstest-Versions-This: ovmf=d795fb571b9b2c2ee67ceaef372d5cc461767859 X-Osstest-Versions-That: ovmf=42b0443599a69c703034079cf2bd389fa3a6bfde From: osstest service owner Date: Thu, 13 Apr 2023 19:40:01 +0000 flight 180248 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180248/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d795fb571b9b2c2ee67ceaef372d5cc461767859 baseline version: ovmf 42b0443599a69c703034079cf2bd389fa3a6bfde Last test of basis 180229 2023-04-13 06:12:19 Z 0 days Testing same since 180248 2023-04-13 16:40:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Corvin Köhne jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 42b0443599..d795fb571b d795fb571b9b2c2ee67ceaef372d5cc461767859 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:52:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:52:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520922.809056 (Exim 4.92) (envelope-from ) id 1pn2zl-0005ak-Hx; Thu, 13 Apr 2023 19:52:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520922.809056; Thu, 13 Apr 2023 19:52:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2zl-0005ad-DK; Thu, 13 Apr 2023 19:52:37 +0000 Received: by outflank-mailman (input) for mailman id 520922; Thu, 13 Apr 2023 19:52:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2zk-0005aX-As for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:52:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn2zj-00042K-On; Thu, 13 Apr 2023 19:52:35 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn2zj-0003lk-IF; Thu, 13 Apr 2023 19:52:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=j1KrRqqmhEktj1V6/+wIzgGRKMBaGQ84ANZtwb9CGZU=; b=r0oHIxKERQxW0Ur9kAIO1RSUtG nEmiKIUzLW6vRdnvnP6ScdWgMxkfRFYDezwYt1rk9IB+PJ6YeMOsiHB/j1A3bizvW0Rlg5c88OKpo ZIytpeKSZkzv8a3YzgD0TQ2qVBP+UIuClUgn+Iqldszbf+wcwx3GYbgnBhkjS3jQYQww=; Message-ID: <03cc0c98-c5ef-16f1-ed24-6a39320b08e5@xen.org> Date: Thu, 13 Apr 2023 20:52:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain To: Luca Fancellu Cc: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> From: Julien Grall In-Reply-To: <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 13/04/2023 15:05, Luca Fancellu wrote: > > >> On 13 Apr 2023, at 14:30, Julien Grall wrote: >> >> >> >> On 13/04/2023 14:24, Luca Fancellu wrote: >>> Hi Julien, >> >> Hi Luca, >> >>>>> @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>>>> unsigned int max_vcpus; >>>>> unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); >>>>> unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); >>>>> + unsigned int sve_vl_bits = sve_decode_vl(config->arch.sve_vl); >>>>> if ( (config->flags & ~flags_optional) != flags_required ) >>>>> { >>>>> @@ -602,6 +606,26 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>>>> return -EINVAL; >>>>> } >>>>> + /* Check feature flags */ >>>>> + if ( sve_vl_bits > 0 ) >>>>> + { >>>>> + unsigned int zcr_max_bits = get_sys_vl_len(); >>>>> + >>>>> + if ( !zcr_max_bits ) >>>>> + { >>>>> + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); >>>>> + return -EINVAL; >>>>> + } >>>>> + >>>>> + if ( sve_vl_bits > zcr_max_bits ) >>>>> + { >>>>> + dprintk(XENLOG_INFO, >>>>> + "Requested SVE vector length (%u) > supported length (%u)\n", >>>>> + sve_vl_bits, zcr_max_bits); >>>>> + return -EINVAL; >>>>> + } >>>> >>>> Is SVE supported for 32-bit guest? If not, then you should had a check here to prevent the creation of the domain if sve_vl_bits is set. >>> No SVE is not supported for 32 bit guests, here I think we will get “SVE is unsupported on this machine” because get_sys_vl_len() will return 0. >> >> From my understanding, get_sys_vl_len() will return the len supported by the hosts. So if you run a 32-bit guest on top of a 64-bit hosts, then I believe get_sys_vl_len() will be non-zero. > > Yes you are right, I realise that I need the domain type information and I can’t have it in arch_sanitise_domain_config, however they might have sense there, and I can do a check > like this afterwards: > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index c1f0d1d78431..ce1235c25769 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3694,6 +3694,12 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) > return -EINVAL; > } > > + if ( d->arch.sve_vl && (kinfo->type == DOMAIN_32BIT) ) > + { > + printk("SVE is not available for 32-bit domain\n"); > + return -EINVAL; > + } > + > if ( is_64bit_domain(d) ) > vcpu_switch_to_aarch64_mode(v); > > Would it be ok for you? construct_domain() is only going to be used for domains created by Xen. You would need the same check for the ones created by the toolstack. Do you need to know the SVE length when the domain is created? If not, then I would suggest to create a new domctl that would be called after we switch the domain to 32-bit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:53:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520926.809065 (Exim 4.92) (envelope-from ) id 1pn30r-00066c-Q1; Thu, 13 Apr 2023 19:53:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520926.809065; Thu, 13 Apr 2023 19:53:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn30r-00066V-NQ; Thu, 13 Apr 2023 19:53:45 +0000 Received: by outflank-mailman (input) for mailman id 520926; Thu, 13 Apr 2023 19:53:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn30q-00066J-4M for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:53:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn30p-00043a-M0; Thu, 13 Apr 2023 19:53:43 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn30p-0003nc-FM; Thu, 13 Apr 2023 19:53:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=iMMxluHVcsuTLcFu23H9V+dhod04vKsQB3GqixWtHiY=; b=yf5wySg29qO11NYv26lmNzoDcI oLd7br1mPxMQeM3oO5kz9A1pFCCTlzG2Vf1+5dhNue9z+0EY7gIbkHvGlB7orr1Imu1Y0Ww7sdndX ueMYD91/zb/x9enHBjkSZVnyHtf+o3W4EaWudSYNbTitQ4CBDShtmZinIySBDKirGMZQ=; Message-ID: Date: Thu, 13 Apr 2023 20:53:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain To: Luca Fancellu Cc: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> <92DA4B4F-7BB9-4CAC-9276-0B6A10550164@arm.com> From: Julien Grall In-Reply-To: <92DA4B4F-7BB9-4CAC-9276-0B6A10550164@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 13/04/2023 17:10, Luca Fancellu wrote: >> >> >>> >>>>> Can we move this somewhere else to avoid adding extra padding? Also shouldn't this be protected with #ifdef CONFIG_ARM_64 to make clear this is not supported on Xen 32-bit? >>>> Yes, I’ll move it and protect with CONFIG_ARM_64, is it ok for you if I move it after: >>>> /* Monitor options */ >>>> struct { >>>> uint8_t privileged_call_enabled : 1; >>>> } monitor; >>> >>> Please check the padding with "pahole". If possible, it would be better to re-use an existing one. >> >> Ok I’ll try to use the tool > > I’ve managed to use the tool, the field seems already in a good spot: ok. Thanks for checking. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:55:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:55:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520930.809076 (Exim 4.92) (envelope-from ) id 1pn31w-0006g5-5L; Thu, 13 Apr 2023 19:54:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520930.809076; Thu, 13 Apr 2023 19:54:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn31w-0006fy-1B; Thu, 13 Apr 2023 19:54:52 +0000 Received: by outflank-mailman (input) for mailman id 520930; Thu, 13 Apr 2023 19:54:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn31v-0006fs-8t for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:54:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn31v-00044y-1i; Thu, 13 Apr 2023 19:54:51 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn31u-0003oO-So; Thu, 13 Apr 2023 19:54:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tg3OWKBqkAnwBlRFVwHPX9YwMY8VMLa79Z8mOEtHzXA=; b=bVIsmCOH4eI4lEz7gBMNopYWm7 WqsDJ31IYPQ12izK0xGIYH+WzWjf9ENAO0ijE0hbSH7HKZ+ucWtVuQ0rC6pa3txhJyZQXwPcPuFHE COu7K0aBqSQJ6xeRBZTHtXLOik7/LEhzHK7R+UObsGUJ7Caqe6Jx/QzJmM34uKVXf4Uo=; Message-ID: Date: Thu, 13 Apr 2023 20:54:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 05/12] arm/sve: save/restore SVE context switch To: Luca Fancellu Cc: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-6-luca.fancellu@arm.com> <6DDCEF6B-F07B-44EA-83D0-33BED5EAC506@arm.com> From: Julien Grall In-Reply-To: <6DDCEF6B-F07B-44EA-83D0-33BED5EAC506@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 13/04/2023 15:35, Luca Fancellu wrote: > > >> On 13 Apr 2023, at 14:11, Julien Grall wrote: >> >> >> >> On 12/04/2023 10:49, Luca Fancellu wrote: >>> Save/restore context switch for SVE, allocate memory to contain >>> the Z0-31 registers whose length is maximum 2048 bits each and >>> FFR who can be maximum 256 bits, the allocated memory depends on >>> how many bits is the vector length for the domain and how many bits >>> are supported by the platform. >>> Save P0-15 whose length is maximum 256 bits each, in this case the >>> memory used is from the fpregs field in struct vfp_state, >>> because V0-31 are part of Z0-31 and this space would have been >>> unused for SVE domain otherwise. >>> Create zcr_el{1,2} fields in arch_vcpu, initialise zcr_el2 on vcpu >>> creation given the requested vector length and restore it on >>> context switch, save/restore ZCR_EL1 value as well. >>> Remove headers from sve.c that are already included using >>> xen/sched.h. >> I dislike this because ... >> >>> diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c >>> index 78f7482619da..5485648850a0 100644 >>> --- a/xen/arch/arm/arm64/sve.c >>> +++ b/xen/arch/arm/arm64/sve.c >>> @@ -5,14 +5,29 @@ >>> * Copyright (C) 2022 ARM Ltd. >>> */ >>> -#include >>> -#include >> >> ... it is not entirely obvious that sched.h will import asm/cpufeatures.h. This could easily change in the future and would only require us to re-add those includes. > > Ok I will reintroduce #include , do I understand correctly that is the only header you would like me to retain? My remark was for all the headers you removed. It is not obvious that any of them will be included by sched.h. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:55:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:55:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520934.809086 (Exim 4.92) (envelope-from ) id 1pn32S-0007DI-DH; Thu, 13 Apr 2023 19:55:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520934.809086; Thu, 13 Apr 2023 19:55:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn32S-0007CJ-9f; Thu, 13 Apr 2023 19:55:24 +0000 Received: by outflank-mailman (input) for mailman id 520934; Thu, 13 Apr 2023 19:55:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn32R-0007C4-3y for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:55:23 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20601.outbound.protection.outlook.com [2a01:111:f400:7ea9::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e1c0413-da35-11ed-8611-37d641c3527e; Thu, 13 Apr 2023 21:55:20 +0200 (CEST) Received: from DM6PR06CA0083.namprd06.prod.outlook.com (2603:10b6:5:336::16) by DM6PR12MB4909.namprd12.prod.outlook.com (2603:10b6:5:1ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 19:55:17 +0000 Received: from DM6NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::85) by DM6PR06CA0083.outlook.office365.com (2603:10b6:5:336::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 19:55:17 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT054.mail.protection.outlook.com (10.13.173.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 19:55:16 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 14:55:16 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:55:16 -0700 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 14:55:15 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e1c0413-da35-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=giPucoljItkLXmTWzh2BABJFAT5txkUAwDWrNXk0NdmxXMrULw3GB85YcmaTvxsqYr4KJ0CbUkbXTdsTVhU61C+x9br/ieUX9QxfxZjZmqJq7okvS9+H3NA4f97Igs1UcqmQ8EQFJHNyVW1wpdbH5Hkj12Y8J76STRGubPfXqsh4wpj3YodYR3LsJI36UGRBueNRqtEtIVc8fs4ezklnrVAfKNTdFs1kd9M0EQ6m9JYAft9yp35n8C1i3hrzYOuzi+Pg09ZpzWwemf0zwp1q0OakZmsmcxXxMRW8pbGgMr/tugOzrHnJkO+zOz6XdkBif6N0kgUFNTITh7wbTomKxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AbR0ZOV6YHp3unjdtxF89oo88L3tukNm7J1yJytBJd0=; b=QTMbF4uNartpWetvgEmx3ru55X6arkT+yBkDaX8mGDJ+vFgEZbKRDPeFdLbgDLseFrrGU6Wo0D+EL1Ggnf+sThQaio1j582NYVQ8XGYt1vb36Hzu+Xh6fxcs2+SVjC/686NvGhujk9Dhy4wgpA9+3aVLVlAoZjsnq1clYaBVC4h9V9+rSDIEG20oYEBJU0wSpjjtPRpgouJBvQ9cuO71nY8AeXfZ6ylA+ztcrjnz+AD2wkZmhAFVpGA8BTc7OA+wldiNH3E89xGLzNxNVuGm4276IxojDBFq/A/oBMTtZqUXDwwTB1oRC6FOlGphV/knxT3gLbZdO1o5QOfvGNHzgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AbR0ZOV6YHp3unjdtxF89oo88L3tukNm7J1yJytBJd0=; b=jI6tkFt4ParB2RTOiV9VERM+vn3Z1pQuohxOWfaI9mVHinTgf2hpCbeYwVuyaDEMdgDQ+RuLkHXwSk5Mw3De9uPRMgdEG0U4BT9sclGbJrUyW83+rXBKz9/PUpqxvRGmdY4SEGn4gQ9IOc5eK1YWuKKKbIGDIZZ48s0ZMb1/Trs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <19cf0a82-3b79-8548-44ba-1e4b2c6dbfe8@amd.com> Date: Thu, 13 Apr 2023 15:55:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 2/8] xen/arm: re-define a set of data structures for static shared memory region Content-Language: en-US To: Penny Zheng , CC: , Stefano Stabellini , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk References: <20230223054105.2357217-1-Penny.Zheng@arm.com> <20230223054105.2357217-3-Penny.Zheng@arm.com> From: Stewart Hildebrand In-Reply-To: <20230223054105.2357217-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT054:EE_|DM6PR12MB4909:EE_ X-MS-Office365-Filtering-Correlation-Id: f0c8cad1-84e6-49bd-9e3a-08db3c59010a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W+43QDT5QNModEEJq1UPIAOPOayoUtv+D5bYGGi3jGdnkmVLbYSmYYYeV6aielISstYfPOHkh3Qf5cGkC9lJt84prJfFfjSWwOdUI9ZSR4pan4UdHfPWLYEQqcTL66JZwO3MKrt6ukbqms+A+onRwzkLck4Vo1YOjjJu8RWaGk3UaK5gsDhK3titYfva2WRM1NfCv7Y7XzgH1/VPSCerw7ZsUeyli7+X7jdR6/kVzxgQrW6pcDIedYlURWoA3YFurZuhozpJdNAThbWEMa0aIZyYVcT0HIglrkWVRtotSvm1rz7WOmMqiaaiPRA6v8duTkUvwOqIypsrRIZNkdzlCAyJZXfYDZbrDwjUaeTi6cBdvwUX/yX7eAhIRB5jEg+C4l3GvSZNi+3LEp92OfYkoKWXW/rfhUxSSpE2LsKszVrWcX2s1z6QXXA/l9CFS/Vwfi00ZVqcdmftlAlbYSYhkxE8g+2VpWU597+uSRRMcFPbPDfP108MhITSIsHEgyUri69tyQu+hK9q65/mEnUw+xdnrvlbalfBNPFGNsKe77q91dBiaqrKc0PbQK808Q6JH+vsc4rsGestIKuP1eQYsRqaZ1rqVlILkcf9NtvMMjXi9TZkkr+PBnjkkcf0Sm7j3soNAaXIR76UHRDugmhSBU6KG1wPy3ofCY92AObUzCtOAwKgGWvl9ak5lVymJB9MQgH01lIRguvk6/h2YEgPS/E4yVqA4NRR3xwluNwkXwqYlqW7x9qUml+mFREYLLDkg7Y9P04yzNQomVHw82A+fw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(40470700004)(36840700001)(46966006)(336012)(36860700001)(70586007)(426003)(70206006)(47076005)(83380400001)(2616005)(54906003)(26005)(110136005)(16576012)(478600001)(186003)(53546011)(44832011)(2906002)(36756003)(5660300002)(81166007)(356005)(41300700001)(4326008)(82740400003)(40460700003)(82310400005)(40480700001)(316002)(31696002)(8676002)(86362001)(8936002)(31686004)(66899021)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 19:55:16.9504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0c8cad1-84e6-49bd-9e3a-08db3c59010a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4909 Hi Penny On 2/23/23 00:40, Penny Zheng wrote: > This commit introduces a set of separate data structures to deal with > static shared memory at different stages. > > In boot-time host device tree parsing, we introduce a new structure > "struct shm_node" and a new field "shm_info" in bootinfo to describe and > store parsed shm info. > only SHMID and "nr_borrowers", which describes the number of borrower domain, > are considered here for per shm node. > We also introduce a new local global data "shm_data" in bootfdt.c, in which, > reserved memory bank is recorded together with shm node, to assist doing > shm node verification. > > In order to apply above changes in acquire_nr_borrower_domain, we now use SHMID > to iterate "shminfo" to find requested shm node, then acquiring the information > of "nr_borrowers". > > In the last, a new anonymized structure "shminfo", which is a array of > compound structure that contains SHMID and a "struct membank membank" > describing shared memory regions in guest address space, is created in "kinfo" > when dealing with domain information. > > Signed-off-by: Penny Zheng > --- > v1 -> v2: > - As the original "struct shm_membank" was making reserving memory more > complex and actually memory information could be still got from host Device\ > Tree when dealing with domain construction, we introduce a new simple structure > "struct shm_node" in bootinfo to only store SHMID and "nr_borrowers" > - Further restrict the scope of the local variable > "struct meminfo *mem = &bootinfo.reserved_mem" > - Introduce a new local global data "shm_data" in bootfdt.c. In which, reserved > memory bank is recorded together with the shm node, to assist doing shm node > verification. > - Define a set of local variables that point to > "shm_data.shm_nodes[i].membank->start", etc, to make the code more readable. > - Use SHMID to iterate "shminfo" to find requested shm node, as we no > longer store host memory bank info in shm node. > - A new anonymized structure, which is a array of compound structure that > contains SHMID and a "struct membank membank", describing shared memory region > in guest, is introduced in "kinfo". This patch no longer applies cleanly to master since 64c21916167e ("xen/arm: Use the correct format specifier") From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:55:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:55:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520937.809096 (Exim 4.92) (envelope-from ) id 1pn32s-0007jV-MX; Thu, 13 Apr 2023 19:55:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520937.809096; Thu, 13 Apr 2023 19:55:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn32s-0007jO-JA; Thu, 13 Apr 2023 19:55:50 +0000 Received: by outflank-mailman (input) for mailman id 520937; Thu, 13 Apr 2023 19:55:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn32r-00078B-1J for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:55:49 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20616.outbound.protection.outlook.com [2a01:111:f400:7eaa::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e1cf23e-da35-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 21:55:48 +0200 (CEST) Received: from DM6PR06CA0074.namprd06.prod.outlook.com (2603:10b6:5:336::7) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 19:55:43 +0000 Received: from DM6NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::86) by DM6PR06CA0074.outlook.office365.com (2603:10b6:5:336::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 19:55:43 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT054.mail.protection.outlook.com (10.13.173.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 19:55:43 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 14:55:43 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 12:55:42 -0700 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 14:55:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e1cf23e-da35-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L1RumNiDMJmG1hM1kZQr0d4OTr4PfEOdC5AHLO9hw1ReWAj7YL81K26iwHiojYIn/N4RAIjY3I2MJsrqwVVBYJtE3Aj1+xQhme/uqAyAbUNtaH3E/axOptF18F9fKmBnevVNZxBSjiTOcDMM8KrYaJ7z+P8to2BZsRYxFLzymSnbdtLr20kf5DLXHbFKZz1lU8DsWVcZ1MrXQWgZxhU4R6SyaPEOLj7pl8etuvFusyKoBCGhy4DJ9sEkaJjxqkBhic2kXAWEMOIvN9RydWU1tJ452JiORA+Fnnn78XGNhAUUzD/Ny4+CEdWnEfIHojq6VhvOTdWj6lbVTJ4DX01ftQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/18PWwB/WDEzRgk5tqv7qd4aPS6M0W9Cu4ti6yz3Lfo=; b=hAbMo//v3mMHziciVHh5Y7530YWttAzOzNPZfkzpF3yNzH3IbOE/0sQmOz6Kxv+BmH2E2It+Qtz3EhLEhc3GdlOfTkrXXbpsL49/A6BPP2Gki+G9ryGxdzIgRcgerm2gMTBIwiTh0cafmaX0vSNld4e4PSoCSdUuLO3M03KuvejRz/9+qiGnBz38XfsaDKW8eHxEeABfviLAOKWGplzjEXdGHW8Cv817ctSY1F+39HddrJKZdUX/hz8EEA+jFvKgGqvTTTZV6tTSyk0uFHQPHb4vLafS51QaJX0suB1eoor1Yc7H7M626u8x1GQAi7sEYvCblVKe4N16IhWi+wwUIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/18PWwB/WDEzRgk5tqv7qd4aPS6M0W9Cu4ti6yz3Lfo=; b=4FkaS2PfIbRuoZqv+2k60RXGkkSUoHbzzroS3WMZmszwrqGA98zxyQKOVt7s2IsgNIdVg27tc93+viBF1MuFQHcdOHJDToeEygtu0637SwMBEBYHysml05sKP40xjokL2Yw9/JA+Yy2s7b6RVE/Dt4/R0eP4Sbn/s7pm7/1qHIU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 13 Apr 2023 15:55:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 5/8] xen/arm: support static shared memory when host address not provided To: Penny Zheng , CC: , Stefano Stabellini , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk References: <20230223054105.2357217-1-Penny.Zheng@arm.com> <20230223054105.2357217-6-Penny.Zheng@arm.com> Content-Language: en-US From: Stewart Hildebrand In-Reply-To: <20230223054105.2357217-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT054:EE_|BN9PR12MB5228:EE_ X-MS-Office365-Filtering-Correlation-Id: 2891d8cd-9fc8-44e0-7c45-08db3c5910fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +btdOB3tVf1KrCcTvt4szeT2vlKwzr17aB44/LLJZE+iHp4pov4PLadHkQLus+G3FR0WpEz+z7OHLQ9VkDzhg/imOYtSxIsxQigcWJ4eOO8ZBgUHG1bkifDXsCKVgO31FLaAuIDp3gs+/hI3BHb4NJA4u/ZTK98oqq0usXuJHwifturc+1ngdfUjVJN1wcfd8eVMAtKpdX8TeRSSkX3xUOt6UHJz9/E1zxrLgALhUtOrT9cOgkhDqC9IlY61keH9ZFp/bTe7YcPrP8o5KTXd3O4b5YzH1vRU2ZBZ3EyJEl4U/0C3EUzKOPGrvkGnXvZ1VrG0z/aB6hGwMNwV0LEH5OXunAOGv0RRRXUjZZZi2vBuPNpZF7VYtwy+H1iP7vMiEPTmtUe9dU8ic6jD6mm3x/1IKzF9bSw9GExCuxS6BpImZ48x+WhB24fUMRSgvU/qmRlpqORtcJVyzwUiMCWG0F+Qqkc9bo5gzT25Bvz6un24js7BYm/hn2D2Hn522uho/f9NTivpF1nABFmV7IbZX7AP4fN3NegE/lt/1FLCGsZ5IXxQt82f6JYBBH1j9PUB85+R/zTAUyLLITtkeSpHPWr1HpVHKJdedoj/a6FBLFIpLgbC2w3uWNW6D6Iiy4kYnWfVapEBV1ar6eHQPPKjjCiMZG0L0srN8wsLnbRAE/me4B6dR4EHDPfjBAQNj8aX+YW+znZNZBAUV8QjXu8zzA5eW/BcGS3+QAUTdhsBQJyeNAAPflg010z2lGxKX+y0S6LDIncCezVMIpw5D5vAZA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(336012)(426003)(26005)(31686004)(40480700001)(70586007)(70206006)(53546011)(36756003)(31696002)(2906002)(30864003)(83380400001)(82310400005)(47076005)(2616005)(186003)(36860700001)(4326008)(40460700003)(44832011)(110136005)(54906003)(86362001)(16576012)(5660300002)(8676002)(8936002)(81166007)(478600001)(316002)(356005)(41300700001)(82740400003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 19:55:43.7301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2891d8cd-9fc8-44e0-7c45-08db3c5910fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Hi Penny On 2/23/23 00:41, Penny Zheng wrote: > In order to support static shared memory when host address not provided, > we shall do the following modification: > - we shall let Xen allocate memory from heap for static shared memory > at first domain, no matter it is owner or borrower. > - In acquire_shared_memory_bank, as static shared memory has already > been allocated from heap, we shall assign them to the owner domain > using function "assign_pages". > - Function get_shm_pages_reference is created to add as many > additional reference as the number of borrowers. > - We implement a new helper "add_foreign_mapping_for_borrower" to set > up foreign memory mapping for borrower. > > Instead of using multiple function parameters to deliver various shm-related > info, like host physical address, SHMID, etc, and with the introduction > of new struct "shm_memnode" to include banked host memory info, we switch to > use "shm_memnode" as function parameter to replace them all, to make codes more > clear and tidy. > > Signed-off-by: Penny Zheng > --- > v1 -> v2: > - combine commits 4 - 6 in Serie 1 > - Adapt to changes of introducing "struct shm_memnode" > --- > xen/arch/arm/domain_build.c | 222 +++++++++++++++++++++++++----------- > 1 file changed, 155 insertions(+), 67 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 91feb8f37c..9b4aabaf22 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -869,6 +869,11 @@ static void __init assign_static_memory_11(struct domain *d, > } > > #ifdef CONFIG_STATIC_SHM > +static bool __init is_shm_allocated_from_heap(struct shm_memnode *node) > +{ > + return (node->meminfo.nr_banks != 0); > +} > + > static int __init acquire_nr_borrower_domain(const char *shm_id, > unsigned long *nr_borrowers) > { > @@ -912,12 +917,12 @@ static struct shm_memnode * __init find_shm_memnode(const char *shm_id) > * This function checks whether the static shared memory region is > * already allocated to dom_io. > */ > -static bool __init is_shm_allocated_to_domio(paddr_t pbase) > +static bool __init is_shm_allocated_to_domio(struct shm_memnode *node) > { > struct page_info *page; > struct domain *d; > > - page = maddr_to_page(pbase); > + page = maddr_to_page(node->meminfo.bank[0].start); > d = page_get_owner_and_reference(page); > if ( d == NULL ) > return false; > @@ -935,67 +940,129 @@ static bool __init is_shm_allocated_to_domio(paddr_t pbase) > } > > static mfn_t __init acquire_shared_memory_bank(struct domain *d, > - paddr_t pbase, paddr_t psize) > + struct shm_meminfo *meminfo, > + bool paddr_assigned) > { > - mfn_t smfn; > - unsigned long nr_pfns; > int res; > + unsigned int i = 0; > > - /* > - * Pages of statically shared memory shall be included > - * into domain_tot_pages(). > - */ > - nr_pfns = PFN_DOWN(psize); > - if ( (UINT_MAX - d->max_pages) < nr_pfns ) > + for ( ; i < meminfo->nr_banks; i++ ) > { > - printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", > - d, nr_pfns); > + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; > + unsigned long nr_pfns; > + > + /* > + * Pages of statically shared memory shall be included > + * into domain_tot_pages(). > + */ > + nr_pfns = PFN_DOWN(psize); > + if ( (UINT_MAX - d->max_pages) < nr_pfns ) > + { > + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", > + d, nr_pfns); > + return INVALID_MFN; > + } > + d->max_pages += nr_pfns; > + > + if ( paddr_assigned ) > + { > + res = acquire_domstatic_pages(d, maddr_to_mfn(pbase), nr_pfns, 0); > + if ( res ) > + { > + printk(XENLOG_ERR > + "%pd: failed to acquire static memory: %d.\n", d, res); > + goto fail; > + } > + } > + else > + /* > + * When host address is not provided, static shared memory is > + * allocated from heap and shall be assigned to owner domain. > + */ > + if ( assign_pages(maddr_to_page(pbase), nr_pfns, d, 0) ) > + goto fail; > + } > + > + return maddr_to_mfn(meminfo->bank[0].start); > + > + fail: > + while( --i >= 0 ) This is an infinite loop. When building with EXTRA_CFLAGS_XEN_CORE="-Wtype-limits -Wno-error=type-limits", we see: arch/arm/domain_build.c: In function ‘acquire_shared_memory_bank’: arch/arm/domain_build.c:989:20: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 989 | while( --i >= 0 ) | ^~ Also, the indentation seems off here. > + d->max_pages -= PFN_DOWN(meminfo->bank[i].size); > return INVALID_MFN; > +} > + > +static int __init get_shm_pages_reference(struct domain *d, > + struct shm_meminfo *meminfo, > + unsigned long count) > +{ > + struct page_info *page; > + unsigned int i = 0, j; > + > + for ( ; i < meminfo->nr_banks; i++ ) > + { > + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; > + unsigned long nr_pages = PFN_DOWN(psize); > + > + page = maddr_to_page(pbase); > + for ( j = 0; j < nr_pages; j++ ) > + { > + if ( !get_page_nr(page + j, d, count) ) > + { > + printk(XENLOG_ERR > + "Failed to add %lu references to page %"PRI_mfn".\n", > + count, mfn_x(page_to_mfn(page + j))); > + goto fail; > + } > + } > } > - d->max_pages += nr_pfns; > > - smfn = maddr_to_mfn(pbase); > - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); > - if ( res ) > + return 0; > + > + fail: > + while ( --j >= 0 ) Infinite loop [-Wtype-limits] > + put_page_nr(page + j, count); > + while ( --i >= 0 ) Infinite loop [-Wtype-limits] > { > - printk(XENLOG_ERR > - "%pd: failed to acquire static memory: %d.\n", d, res); > - d->max_pages -= nr_pfns; > - return INVALID_MFN; > + page = maddr_to_page(meminfo->bank[i].start); > + j = PFN_DOWN(meminfo->bank[i].size); > + while ( --j >= 0 ) Infinite loop [-Wtype-limits] > + put_page_nr(page + j, count); > } > + return -EINVAL; > > - return smfn; > } > - > static int __init assign_shared_memory(struct domain *d, > - paddr_t pbase, paddr_t psize, > - paddr_t gbase, const char *shm_id) > + struct shm_memnode *node, paddr_t gbase, > + bool paddr_assigned) > { > mfn_t smfn; > - int ret = 0; > - unsigned long nr_pages, nr_borrowers, i; > - struct page_info *page; > - > - printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > - d, pbase, pbase + psize); > + int ret; > + unsigned long nr_borrowers, i; > + struct shm_meminfo *meminfo = &node->meminfo; > > - smfn = acquire_shared_memory_bank(d, pbase, psize); > + smfn = acquire_shared_memory_bank(d, meminfo, paddr_assigned); > if ( mfn_eq(smfn, INVALID_MFN) ) > return -EINVAL; > > - /* > - * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need > - * to create mapping in the P2M. > - */ > - nr_pages = PFN_DOWN(psize); > - if ( d != dom_io ) > + for ( i = 0; i < meminfo->nr_banks; i++ ) > { > - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, > - PFN_DOWN(psize)); > - if ( ret ) > + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; > + > + /* > + * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do > + * not need to create mapping in the P2M. > + */ > + if ( d != dom_io ) > { > - printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); > - return ret; > + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), > + maddr_to_mfn(pbase), > + PFN_DOWN(psize)); > + if ( ret ) > + { > + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); > + return ret; > + } > + gbase += psize; > } > } > > @@ -1003,7 +1070,7 @@ static int __init assign_shared_memory(struct domain *d, > * Get the right amount of references per page, which is the number of > * borrower domains. > */ > - ret = acquire_nr_borrower_domain(shm_id, &nr_borrowers); > + ret = acquire_nr_borrower_domain(node->shm_id, &nr_borrowers); > if ( ret ) > return ret; > > @@ -1015,24 +1082,30 @@ static int __init assign_shared_memory(struct domain *d, > * So if the borrower is created first, it will cause adding pages > * in the P2M without reference. > */ > - page = mfn_to_page(smfn); > - for ( i = 0; i < nr_pages; i++ ) > + return get_shm_pages_reference(d, meminfo, nr_borrowers); > +} > + > +static int __init add_foreign_mapping_for_borrower(struct domain *d, > + struct shm_memnode *node, > + paddr_t gbase) > +{ > + unsigned int i = 0; > + struct shm_meminfo *meminfo = &node->meminfo; > + > + for ( ; i < meminfo->nr_banks; i++ ) > { > - if ( !get_page_nr(page + i, d, nr_borrowers) ) > - { > - printk(XENLOG_ERR > - "Failed to add %lu references to page %"PRI_mfn".\n", > - nr_borrowers, mfn_x(smfn) + i); > - goto fail; > - } > + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; > + int ret; > + > + /* Set up P2M foreign mapping for borrower domain. */ > + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), > + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); > + if ( ret ) > + return ret; > + gbase += psize; > } > > return 0; > - > - fail: > - while ( --i >= 0 ) > - put_page_nr(page + i, nr_borrowers); > - return ret; > } > > static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > @@ -1156,7 +1229,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > > dt_for_each_child_node(node, shm_node) > { > - paddr_t gbase, pbase, psize; > + paddr_t gbase; > int ret = 0; > const char *role_str; > const char *shm_id; > @@ -1185,15 +1258,30 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > shm_id); > if ( !shm_memnode ) > return -EINVAL; > - pbase = shm_memnode->meminfo.bank[0].start; > - psize = shm_memnode->meminfo.bank[0].size; > + > + /* > + * When host address is not provided in "xen,shared-mem", > + * we let Xen allocate memory from heap at first domain. > + */ > + if ( !paddr_assigned && !is_shm_allocated_from_heap(shm_memnode) ) > + { > + if ( !allocate_domheap_memory(NULL, shm_memnode->meminfo.tot_size, > + (void *)&shm_memnode->meminfo, > + SHM_MEMINFO) ) > + { > + printk(XENLOG_ERR > + "Failed to allocate (%"PRIpaddr"MB) pages as static shared memory from heap\n", > + shm_memnode->meminfo.tot_size >> 20); > + return -EINVAL; > + } > + } > > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > * only find the borrowers. > */ > - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > + if ( (owner_dom_io && !is_shm_allocated_to_domio(shm_memnode)) || > (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > /* > @@ -1201,16 +1289,14 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > * specified, so they should be assigned to dom_io. > */ > ret = assign_shared_memory(owner_dom_io ? dom_io : d, > - pbase, psize, gbase, shm_id); > + shm_memnode, gbase, paddr_assigned); > if ( ret ) > return ret; > } > > if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) > { > - /* Set up P2M foreign mapping for borrower domain. */ > - ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), > - _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); > + ret = add_foreign_mapping_for_borrower(d, shm_memnode, gbase); > if ( ret ) > return ret; > } > @@ -1219,7 +1305,9 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > * Record static shared memory region info for later setting > * up shm-node in guest device tree. > */ > - ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); > + ret = append_shm_bank_to_domain(kinfo, gbase, > + shm_memnode->meminfo.tot_size, > + shm_memnode->shm_id); > if ( ret ) > return ret; > } > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Thu Apr 13 19:56:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 19:56:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520943.809106 (Exim 4.92) (envelope-from ) id 1pn33I-0008LM-5A; Thu, 13 Apr 2023 19:56:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520943.809106; Thu, 13 Apr 2023 19:56:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn33I-0008LF-2G; Thu, 13 Apr 2023 19:56:16 +0000 Received: by outflank-mailman (input) for mailman id 520943; Thu, 13 Apr 2023 19:56:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn33G-00078B-AH for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 19:56:14 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20631.outbound.protection.outlook.com [2a01:111:f400:7e88::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d549394-da35-11ed-b21e-6b7b168915f2; Thu, 13 Apr 2023 21:56:12 +0200 (CEST) Received: from BN0PR03CA0048.namprd03.prod.outlook.com (2603:10b6:408:e7::23) by BL1PR12MB5046.namprd12.prod.outlook.com (2603:10b6:208:313::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 19:56:09 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::79) by BN0PR03CA0048.outlook.office365.com (2603:10b6:408:e7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 19:56:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.32 via Frontend Transport; Thu, 13 Apr 2023 19:56:09 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 14:56:09 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 13 Apr 2023 14:56:08 -0500 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 13 Apr 2023 14:56:07 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d549394-da35-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKvKgSveCPYfmptBtizcv0+TImHvFUaC3+4DNvXAJHMAOlcJkIOtZq+moW0RcPDIJXW42cMd/2c/bHI+zTmv63NpsVrhmYLyYRQ403iZV80aF+1DNKlPtZgUAsCVhuXLppziDZogOyzy/JNn9UMLWBOR8PP6XSy1/DMb/bRta7nNdAlh7XGs6TkOGcsIfnSGIb4QK41dZe//my3OsOaevxdSXJ4K3QSEBRICcON+jKnl+9ro43T/b44iQsdNeP2nid9R+DKZYAbFwOTXFL20F3oYFC5lJaFs+ruoJIDtu8OCrFnyHqt2ZhzybS376zjuCzb5XBGo9moSrO9ab8JONA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXg/prYLx5EALCUgzFznssa0CZnjCJteDGfMgsf99ZQ=; b=ORGV0J4x6cWye8nLtorjcK4G9eEAIntvY9tMg2MeVU2pzkgmvtXFygRUCsWWdZgKJjNSKhR5GWvZdd2pg4iRnbsD2euq/igAgBn601l2+btAUauSFqyo1gdZO+pU6Bt/7OeUGMZpKNVMdg5BmdQYk3vOi0tVSne6CpkdHdwkiKAwPL23DR+Cvus+kih+E6pteZQkULCMzeLM8Sl0dbFzDfW1RgFk6n6H4rARQTlbPdSFI2sl+qrCIGgPWFIepvSPdhh6Nz+2fGtBkY94DWx/hgmkPIOBn+hhrWihjFnojTwGa1NMRX5bbHkaGAPAAiH0okJ43RiPC5NcJlqGIqA1Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iXg/prYLx5EALCUgzFznssa0CZnjCJteDGfMgsf99ZQ=; b=z5nW4dgCeAW+XqcEeNlGq2Jq/9p7bvRazwtvtGvI+PPwMJLD6PpDDFUgve2QDUH07hgtt0rmJXe5cBXKlSN95k+KUt5VCYoNyX8j9Oxa11w1VGaQEwiOU4efHII5ah4WCMdE8/rF5E4giITcwlSvetUuN95YTbZIKlF/nQXwMSA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <8acf5625-a60e-0357-6ba0-96af35930c17@amd.com> Date: Thu, 13 Apr 2023 15:56:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 6/8] xen/arm: remove shm holes for extended regions Content-Language: en-US To: Penny Zheng , CC: , Stefano Stabellini , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk References: <20230223054105.2357217-1-Penny.Zheng@arm.com> <20230223054105.2357217-7-Penny.Zheng@arm.com> From: Stewart Hildebrand In-Reply-To: <20230223054105.2357217-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT017:EE_|BL1PR12MB5046:EE_ X-MS-Office365-Filtering-Correlation-Id: 3afb3ce7-df12-4448-8161-08db3c59204f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +sDDAf96tcihFXdlvmuq81wW/cEbMtSBl04tDuA/qK6iKYMgmmZFU9ebWTLz/YCnyNGwlwuYNoUqgcwDZRQ4aWtMSzoMmHBWUGGtZ14j8Gprq2k+JuhgaiIP6NgVPEKKfUkDemhte8d/0Ll5eFh7vAVP7r/YNbfM9y/3TU592Twb8a4uTswKCCy08YuFQzXzJFdij1h1+otXb2EkyocMuF0n57NVPzVHbl6zGqqFgZipoTxvFHV4XaubRR5PJmQR4/zN11b2dacWlkSJ/Rb13S5rs3wnEz69tP2xW1wJ/duCHizhhN+apNsB7IxLqiMRO3/KHzCxKMbuQzzCrnK+fN1iQRRYCo4dAfP2UVWjlLX0v4NekcvH4aRqz6wXms0aNnjDAzD7gqG/8o0vLezEZTaOD3S6TQwzZgKC4SKwC4/PKkDfb2H22G3y39akQIVu0BObh8+7c/iHIKeHR0WLx+QJwericvTribVsoQCVUw5Ox4LIYsJAnpxcmA/dk0kULcUsSlWLC7W6bz2jz7/rJcj8d8a+UWs5HxSvBXmMvq6OQH+9nm5VjZ3x/j+uEumlMQ7lZgumuaIG5qku2zbpLTIXokz+vxAVeqwIU/5HzisNi9ZvY0lxb4Ma3DJxsaDbi6pz1xHs8X5nbODJdTjZKe0bKVCg8hzu9WnppOpx8NRGgt+Zu8YhZqZlVHpQEhL9pM58qn81k+rpHBmVRM6+AkwMIh6ZqTpLFWZiP6HIqR12GXhrX62c8kb4pvQOK8p+eGqWxB9P4t09AEbG0gLPRw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(40470700004)(36840700001)(46966006)(336012)(36860700001)(70586007)(426003)(70206006)(47076005)(83380400001)(2616005)(54906003)(26005)(110136005)(16576012)(478600001)(186003)(53546011)(44832011)(2906002)(36756003)(5660300002)(81166007)(356005)(41300700001)(4326008)(82740400003)(40460700003)(82310400005)(40480700001)(316002)(31696002)(8676002)(86362001)(8936002)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 19:56:09.4425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3afb3ce7-df12-4448-8161-08db3c59204f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5046 Hi Penny On 2/23/23 00:41, Penny Zheng wrote: > Static shared memory acts as reserved memory in guest, so it shall be > excluded from extended regions. > > Extended regions are taken care of under three different scenarios: > normal DomU, direct-map domain with iommu on, and direct-map domain > with iommu off. > > For normal DomU, we create a new function "remove_shm_holes_for_domU", to > firstly transfer original outputs into the format of "struct rangeset", > then use "remove_shm_from_rangeset" to remove static shm from them. > > For direct-map domain with iommu on, after we get guest shm info from "kinfo", > we use "remove_shm_from_rangeset" to remove static shm. > > For direct-map domain with iommu off, as static shm has already been taken > care of through reserved memory banks, we do nothing. > > Signed-off-by: Penny Zheng > --- > v1 -> v2: > - new commit > --- > xen/arch/arm/domain_build.c | 94 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 93 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 9b4aabaf22..4cd1e3d433 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1914,6 +1914,32 @@ static int __init handle_pci_range(const struct dt_device_node *dev, > return 0; > } > > +static int __init remove_shm_from_rangeset(const struct kernel_info *kinfo, > + struct rangeset *rangeset) > +{ > + unsigned int i; > + > + /* Remove static shared memory regions */ > + for ( i = 0; i < kinfo->shminfo.nr_banks; i++ ) > + { > + struct membank membank = kinfo->shminfo.bank[i].membank; > + paddr_t start, end; > + int res; > + > + start = membank.start; > + end = membank.start + membank.size - 1; > + res = rangeset_remove_range(rangeset, start, end); > + if ( res ) > + { > + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", > + start, end); > + return -EINVAL; > + } > + } > + > + return 0; > +} > + > /* > * Find the holes in the Host DT which can be exposed to Dom0 as extended > * regions for the special memory mappings. In order to calculate regions > @@ -1922,6 +1948,8 @@ static int __init handle_pci_range(const struct dt_device_node *dev, > * - MMIO > * - Host RAM > * - PCI aperture > + * - Static shared memory regions, which are described by special property > + * "xen,static-shm" > */ > static int __init find_memory_holes(const struct kernel_info *kinfo, > struct meminfo *ext_regions) > @@ -1997,6 +2025,14 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, > } > } > > + /* Remove static shared memory regions */ > + if ( kinfo->shminfo.nr_banks != 0 ) > + { > + res = remove_shm_from_rangeset(kinfo, mem_holes); > + if ( res ) > + goto out; > + } > + > start = 0; > end = (1ULL << p2m_ipa_bits) - 1; > res = rangeset_report_ranges(mem_holes, start, end, > @@ -2012,6 +2048,62 @@ out: > return res; > } > > +static int __init remove_shm_holes_for_domU(const struct kernel_info *kinfo, > + struct meminfo *orig_ext) > +{ > + struct rangeset *guest_holes; > + unsigned int i = 0, tail; > + int res; > + paddr_t start, end; > + > + /* No static shared memory region. */ > + if ( kinfo->shminfo.nr_banks == 0 ) > + return 0; > + > + dt_dprintk("Remove static shared memory holes for extended regions of DomU\n"); > + > + guest_holes = rangeset_new(NULL, NULL, 0); > + if ( !guest_holes ) > + return -ENOMEM; > + > + for ( ; i < orig_ext->nr_banks; i++ ) > + { > + start = orig_ext->bank[i].start; > + end = start + orig_ext->bank[i].size - 1; > + > + res = rangeset_add_range(guest_holes, start, end); > + if ( res ) > + { > + printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", > + start, end); > + goto out; > + } > + } > + > + /* Remove static shared memory regions */ > + res = remove_shm_from_rangeset(kinfo, guest_holes); > + if ( res ) > + goto out; > + > + tail = orig_ext->nr_banks - 1; > + start = orig_ext->bank[0].start; > + end = orig_ext->bank[tail].start + orig_ext->bank[tail].size - 1; > + > + /* Reset original extended regions to hold new value */ > + orig_ext->nr_banks = 0; > + res = rangeset_report_ranges(guest_holes, start, end, > + add_ext_regions, orig_ext); > + if ( res ) > + orig_ext->nr_banks = 0; > + else if ( !orig_ext->nr_banks ) > + res = -ENOENT; > + > +out: > + rangeset_destroy(guest_holes); > + > + return res; > +} > + > static int __init find_domU_holes(const struct kernel_info *kinfo, > struct meminfo *ext_regions) > { > @@ -2039,7 +2131,7 @@ static int __init find_domU_holes(const struct kernel_info *kinfo, > res = 0; > } > > - return res; > + return remove_shm_holes_for_domU(kinfo, ext_regions); We are no longer using "res" anywhere in this function, so the variable may be removed. arch/arm/domain_build.c: In function ‘find_domU_holes’: arch/arm/domain_build.c:2114:9: warning: variable ‘res’ set but not used [-Wunused-but-set-variable] 2114 | int res = -ENOENT; | ^~~ > } > > static int __init make_hypervisor_node(struct domain *d, > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Thu Apr 13 20:05:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 20:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520947.809116 (Exim 4.92) (envelope-from ) id 1pn3Bl-0001aA-3P; Thu, 13 Apr 2023 20:05:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520947.809116; Thu, 13 Apr 2023 20:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3Bk-0001a3-Uo; Thu, 13 Apr 2023 20:05:00 +0000 Received: by outflank-mailman (input) for mailman id 520947; Thu, 13 Apr 2023 20:05:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3Bj-0001Zt-W8; Thu, 13 Apr 2023 20:05:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3Bj-0004aq-T2; Thu, 13 Apr 2023 20:04:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3Bj-0008LR-9d; Thu, 13 Apr 2023 20:04:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pn3Bj-00043W-9D; Thu, 13 Apr 2023 20:04:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lEO21onNoqnZTORQ3ZvOWUKYf+S9YW6vnuYKjBClGX8=; b=iOD8B4Llfr/UhJRKDeASqWVbuE f50wSfiAZKGtSGPGRmJXLqNt64c+JGwemgTjc9To7E4oHf54mT/sL4nRrZMHZNq4K0rNJe7fp+hac hwmx3RcMy3fXMY0oovUQzzYi8TURaXWQnyttekVxUB+EaYA2W1DVnruNJqOtCgg/zlGg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180231: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 X-Osstest-Versions-That: qemuu=abb02ce0e76a8e00026699a863ab2d11d88f56d4 From: osstest service owner Date: Thu, 13 Apr 2023 20:04:59 +0000 flight 180231 qemu-mainline real [real] flight 180249 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180231/ http://logs.test-lab.xenproject.org/osstest/logs/180249/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180249-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180220 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180220 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180220 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180220 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180220 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a version targeted for testing: qemuu 9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 baseline version: qemuu abb02ce0e76a8e00026699a863ab2d11d88f56d4 Last test of basis 180220 2023-04-12 12:10:32 Z 1 days Testing same since 180231 2023-04-13 09:18:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Klaus Jensen Paolo Bonzini Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git abb02ce0e7..9d177b7f87 9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Apr 13 20:13:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 20:13:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520953.809125 (Exim 4.92) (envelope-from ) id 1pn3K3-00036D-Su; Thu, 13 Apr 2023 20:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520953.809125; Thu, 13 Apr 2023 20:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3K3-000366-QK; Thu, 13 Apr 2023 20:13:35 +0000 Received: by outflank-mailman (input) for mailman id 520953; Thu, 13 Apr 2023 20:13:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3K3-000360-9B for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 20:13:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3K3-0004i0-10; Thu, 13 Apr 2023 20:13:35 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn3K2-0004pH-S4; Thu, 13 Apr 2023 20:13:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=oSq02aCdIW2vhjwtNEB7aKRGk3ADSa7uIvd++Ul2Ca4=; b=UBkUOsckgh80kXjV3FIZLezLfT ak+xyeWNfR9lE0f/zSF8E2nJiNl2vGZEs7d60E5jzvlQ/LzyYoK/OlEriQ6M/3gqR5JkGI78z3Byo y7AN2zVNbeGkGJAFnKb8LjgYu6dkPHP7lCK8GOFEksrRHjM3Slbn1WGmpZI0Ar46nVfo=; Message-ID: Date: Thu, 13 Apr 2023 21:13:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Andrew Cooper , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Stefano Stabellini References: <20230413192201.3255984-1-andrew.cooper3@citrix.com> From: Julien Grall Subject: Re: [PATCH] xen: Fold exit paths in find_text_region() In-Reply-To: <20230413192201.3255984-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, You may want to update your runes to find the maintainers as you are CCing the x86 folks but not the REST (the patch modifies common/ after all). On 13/04/2023 20:22, Andrew Cooper wrote: > Despite rcu_read_unlock() being fully inlineable, the optimiser cannot fold > these exit paths, because of the various compiler barriers providing RCU > safety. Help the compiler out. Please mention which compiler(s) (including version) you used. > > This compiles to marginally better code in all cases. So the code itself is fine with me. But this raises a few questions. If this is marginal, then why are you doing it? What's your end goal? Lastly what do you mean by "all cases"? Is it all arch? All compilers? Anyway, if this pattern is important (TBD why), then I think we should update the CODING_STYLE with some guidance. Otherwise, we may introduce similar patterns (we already have some). > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > xen/common/virtual_region.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/xen/common/virtual_region.c b/xen/common/virtual_region.c > index 30b0b4ab9c85..5ecdba9c08ed 100644 > --- a/xen/common/virtual_region.c > +++ b/xen/common/virtual_region.c > @@ -40,20 +40,20 @@ static DEFINE_RCU_READ_LOCK(rcu_virtual_region_lock); > > const struct virtual_region *find_text_region(unsigned long addr) > { > - const struct virtual_region *region; > + const struct virtual_region *iter, *region = NULL; > > rcu_read_lock(&rcu_virtual_region_lock); > - list_for_each_entry_rcu( region, &virtual_region_list, list ) > + list_for_each_entry_rcu ( iter, &virtual_region_list, list ) > { > - if ( (void *)addr >= region->start && (void *)addr < region->end ) > + if ( (void *)addr >= iter->start && (void *)addr < iter->end ) > { > - rcu_read_unlock(&rcu_virtual_region_lock); > - return region; > + region = iter; > + break; > } > } > rcu_read_unlock(&rcu_virtual_region_lock); > > - return NULL; > + return region; > } > > void register_virtual_region(struct virtual_region *r) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 20:32:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 20:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520959.809136 (Exim 4.92) (envelope-from ) id 1pn3bi-0005Yi-G0; Thu, 13 Apr 2023 20:31:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520959.809136; Thu, 13 Apr 2023 20:31:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3bi-0005Yb-DE; Thu, 13 Apr 2023 20:31:50 +0000 Received: by outflank-mailman (input) for mailman id 520959; Thu, 13 Apr 2023 20:31:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3bh-0005YV-Ih for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 20:31:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3bh-0005Bo-6d; Thu, 13 Apr 2023 20:31:49 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn3bg-0005Be-Vj; Thu, 13 Apr 2023 20:31:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=TyxIEsaM6b1l/hR5s5xSX0h5w0Zjr2PVNfKqKVoiay0=; b=UU0yZ6CQNOv687RN68enSt5ATZ 34w0CDqDJlt9904+eDqMsPKJYLsHkUURnywVbBvmZB3jrxO4aeXh0Ym1QwEnFjI+j3vmfMgzXgADN qTNjV1hO89jZa87e6ExihV4fy9drZbAEPa+tzMRBrpva2gPjejdoDdZdAR3YD7R1lHgs=; Message-ID: <6d1b8904-374c-4392-6945-2746f97c31f6@xen.org> Date: Thu, 13 Apr 2023 21:31:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-13-jens.wiklander@linaro.org> From: Julien Grall Subject: Re: [XEN PATCH v8 12/22] xen/arm: ffa: support mapping guest RX/TX buffers In-Reply-To: <20230413071424.3273490-13-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, On 13/04/2023 08:14, Jens Wiklander wrote: > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > + register_t rx_addr, uint32_t page_count) > +{ > + uint32_t ret = FFA_RET_INVALID_PARAMETERS; > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.tee; > + struct page_info *tx_pg; > + struct page_info *rx_pg; > + p2m_type_t t; > + void *rx; > + void *tx; > + > + if ( !smccc_is_conv_64(fid) ) > + { > + /* > + * Calls using the 32-bit calling convention must ignore the upper > + * 32 bits in the argument registers. > + */ > + tx_addr &= UINT32_MAX; > + rx_addr &= UINT32_MAX; > + } > + > + if ( page_count > FFA_MAX_RXTX_PAGE_COUNT ) { Coding style: if ( ... ) { > + printk(XENLOG_ERR "ffa: RXTX_MAP: error: %u pages requested (limit %u)\n", > + page_count, FFA_MAX_RXTX_PAGE_COUNT); > + return FFA_RET_NOT_SUPPORTED; > + } > + > + /* Already mapped */ > + if ( ctx->rx ) > + return FFA_RET_DENIED; > + > + tx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(tx_addr)), &t, P2M_ALLOC); I might be missing something. Here you only get the reference on one page. Per the value of FFA_MAX_RXTX_PAGE_COUNT, it looks like the buffer can be up to 32 pages. Can you clarify? > + if ( !tx_pg ) > + return FFA_RET_INVALID_PARAMETERS; > + /* Only normal RAM for now */ > + if ( !p2m_is_ram(t) ) p2m_is_ram() would allow RAM page marked read-only in stage-2. Is it intended? If not, then I think you want to use t != p2m_ram_rw. > + goto err_put_tx_pg; > + > + rx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(rx_addr)), &t, P2M_ALLOC); > + if ( !tx_pg ) > + goto err_put_tx_pg; > + /* Only normal RAM for now */ > + if ( !p2m_is_ram(t) ) Same here. > + goto err_put_rx_pg; > + > + tx = __map_domain_page_global(tx_pg); > + if ( !tx ) > + goto err_put_rx_pg; > + > + rx = __map_domain_page_global(rx_pg); > + if ( !rx ) > + goto err_unmap_tx; > + > + ctx->rx = rx; > + ctx->tx = tx; > + ctx->rx_pg = rx_pg; > + ctx->tx_pg = tx_pg; > + ctx->page_count = page_count; > + ctx->tx_is_free = true; > + return FFA_RET_OK; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 20:34:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 20:34:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520963.809146 (Exim 4.92) (envelope-from ) id 1pn3dn-00066w-S9; Thu, 13 Apr 2023 20:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520963.809146; Thu, 13 Apr 2023 20:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3dn-00066p-P2; Thu, 13 Apr 2023 20:33:59 +0000 Received: by outflank-mailman (input) for mailman id 520963; Thu, 13 Apr 2023 20:33:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3dm-00066h-S5 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 20:33:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3dm-0005Df-HR; Thu, 13 Apr 2023 20:33:58 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn3dm-0005NF-CG; Thu, 13 Apr 2023 20:33:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gB/jvbSDlfA0EMEcuLtzZFuh9OajfqJtkl3CYchv2yE=; b=S93GEsCUK1g3QR+3J7My1mZNw8 Hqnj7mxAfragLCTnGmsuFuneY6hMKSWkdK5HPPPKgDTjg2f8zuG4JtK/ZvNMpOXNgd2eeFa+Tt7Nm rEjRX3Ud/7LYW/JEsn456EYUsFosilEldQoAzdQnQM3NY4OxNbFQmrs1GPJMxuO+4Jdg=; Message-ID: <86b582a9-861c-7d8f-beeb-3469ea7948be@xen.org> Date: Thu, 13 Apr 2023 21:33:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [XEN PATCH v8 13/22] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-14-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20230413071424.3273490-14-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, On 13/04/2023 08:14, Jens Wiklander wrote: > Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests > from a guest. The requests are forwarded to the SPMC and the response is > translated according to the FF-A version in use by the guest. > > Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the > caller (the guest in this case), so once it is done with the buffer it > must be released using FFA_RX_RELEASE before another call can be made. > > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 137 ++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 134 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 127397d8e448..74b8c517afb8 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -166,7 +166,18 @@ > #define FFA_MSG_SEND 0x8400006EU > #define FFA_MSG_POLL 0x8400006AU > > +/* > + * Structs below ending with _1_0 are defined in FF-A-1.0-REL and > + * struct ending with _1_1 are defined in FF-A-1.1-REL0. > + */ > + > /* Partition information descriptor */ > +struct ffa_partition_info_1_0 { > + uint16_t id; > + uint16_t execution_context; > + uint32_t partition_properties; > +}; > + > struct ffa_partition_info_1_1 { > uint16_t id; > uint16_t execution_context; > @@ -183,7 +194,8 @@ struct ffa_ctx { > unsigned int page_count; > /* FF-A version used by the guest */ > uint32_t guest_vers; > - bool tx_is_free; > + bool rx_is_free; I am a bit confused why this is renamed. Did you introduce tx_is_free by mistake? If not, can you name the field correctly from when it is introduced? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 20:53:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 20:53:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520967.809155 (Exim 4.92) (envelope-from ) id 1pn3wP-000057-DI; Thu, 13 Apr 2023 20:53:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520967.809155; Thu, 13 Apr 2023 20:53:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3wP-00004w-Aj; Thu, 13 Apr 2023 20:53:13 +0000 Received: by outflank-mailman (input) for mailman id 520967; Thu, 13 Apr 2023 20:53:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3wN-0008WT-Qq for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 20:53:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn3wN-0005Wj-GH; Thu, 13 Apr 2023 20:53:11 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn3wN-0005xj-B0; Thu, 13 Apr 2023 20:53:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=mtaoGJepRxHbMpQyow6E7Am+G+hQC599jwvUs8hGIwE=; b=XVNDIs8ymNEXYcWjlN+4ySOdRC ZJ5vb/yUAZJaIAS6PDc/8r/UWd6WyeBwt2FtUDAvaKb0OlCZPD2GiDwSce2OUJkDtwlBlhZ6wtL0k mg+bcTsGZO+cYeHmXwaC/+QU5KgGT0zit35tp7T88R1hdHkh2ItJ0iMQOKxpPOE7t+5o=; Message-ID: <176f5384-6e35-83bd-5f77-8b31412e8048@xen.org> Date: Thu, 13 Apr 2023 21:53:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-18-jens.wiklander@linaro.org> From: Julien Grall Subject: Re: [XEN PATCH v8 17/22] xen/arm: ffa: support sharing memory In-Reply-To: <20230413071424.3273490-18-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, On 13/04/2023 08:14, Jens Wiklander wrote: > static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > uint8_t msg) > { > @@ -781,6 +862,400 @@ out: > resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); > } > > +/* > + * Gets all page and assigns them to the supplied shared memory object. If > + * this function fails then the caller is still expected to call > + * put_shm_pages() as a cleanup. > + */ > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > + const struct ffa_address_range *range, > + uint32_t range_count, unsigned int start_page_idx, > + unsigned int *last_page_idx) > +{ > + unsigned int pg_idx = start_page_idx; > + gfn_t gfn; > + unsigned int n; > + unsigned int m; > + p2m_type_t t; > + uint64_t addr; > + > + for ( n = 0; n < range_count; n++ ) > + { > + for ( m = 0; m < range[n].page_count; m++ ) > + { > + if ( pg_idx >= shm->page_count ) > + return FFA_RET_INVALID_PARAMETERS; > + > + addr = read_atomic(&range[n].address); I am confused with the use of read_atomic() here. Is this part of the guest memory? If so, why don't page_count is also not read atomically? Also, it looks like you are using you will read the same address atomically. Shouldn't this be moved just before the loop? > + gfn = gaddr_to_gfn(addr + m * FFA_PAGE_SIZE); > + shm->pages[pg_idx] = get_page_from_gfn(d, gfn_x(gfn), &t, > + P2M_ALLOC); > + if ( !shm->pages[pg_idx] ) > + return FFA_RET_DENIED; > + /* Only normal RAM for now */ > + if ( !p2m_is_ram(t) ) > + return FFA_RET_DENIED; > + pg_idx++; > + } > + } > + > + *last_page_idx = pg_idx; > + > + return FFA_RET_OK; > +} > + > +static void put_shm_pages(struct ffa_shm_mem *shm) > +{ > + unsigned int n; > + > + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) > + { > + put_page(shm->pages[n]); > + shm->pages[n] = NULL; > + } > +} > + > +static struct ffa_shm_mem *alloc_ffa_shm_mem(struct ffa_ctx *ctx, > + unsigned int page_count) > +{ > + struct ffa_shm_mem *shm; > + > + if ( page_count >= FFA_MAX_SHM_PAGE_COUNT || > + ctx->shm_count >= FFA_MAX_SHM_COUNT ) > + return NULL; > + > + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); > + if ( shm ) > + { > + ctx->shm_count++; > + shm->page_count = page_count; > + } > + > + return shm; > +} > + > +static void free_ffa_shm_mem(struct ffa_ctx *ctx, struct ffa_shm_mem *shm) > +{ > + if ( shm ) { Coding style: if ( ... ) { but I would prefer if we remove one level of indentation and use: if ( !shm ) return; > + ASSERT(ctx->shm_count > 0); > + ctx->shm_count--; > + put_shm_pages(shm); > + xfree(shm); > + } > +} Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 20:57:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 20:57:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520971.809166 (Exim 4.92) (envelope-from ) id 1pn40B-0000iY-Tp; Thu, 13 Apr 2023 20:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520971.809166; Thu, 13 Apr 2023 20:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn40B-0000iR-Qk; Thu, 13 Apr 2023 20:57:07 +0000 Received: by outflank-mailman (input) for mailman id 520971; Thu, 13 Apr 2023 20:57:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn409-0000iH-Vf for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 20:57:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn409-0005c3-Jv; Thu, 13 Apr 2023 20:57:05 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn409-0006AB-E1; Thu, 13 Apr 2023 20:57:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/JVyhFgWOemJ/AtWKESvxq6p/h54T4vD7UzVanZl1Qs=; b=aM0jXWcfgUMfqUhSB3ANVS/cvF Ilm+D9VQ4Q7hgcbZGEjNwLiQe9CSncvP1bk2FwW/bDvJ7LuV5gymFowHSn1EXZsckZWMwgMkZoffR rXXHMy4S85y/zrajzXv235WlSaKMOoml+2q3pIsk+Vd8Mnegz0XWwKzSul73m3keJlTM=; Message-ID: Date: Thu, 13 Apr 2023 21:57:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-22-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20230413071424.3273490-22-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, On 13/04/2023 08:14, Jens Wiklander wrote: > Adds a comments with a list of unsupported FF-A interfaces and > limitations in the implemented FF-A interfaces. > > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 0948cc636871..6424c222c885 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -13,6 +13,38 @@ > * https://developer.arm.com/documentation/den0077/e > * TEEC-1.0C: TEE Client API Specification version 1.0c available at > * https://globalplatform.org/specs-library/tee-client-api-specification/ > + * > + * Notes on the the current implementstion. > + * > + * Unsupported FF-A interfaces: > + * o FFA_MSG_POLL and FFA_MSG_SEND - deprecated in FF-A-1.1-REL0 > + * o FFA_MEM_RETRIEVE_* - Used when sharing memory from an SP to a VM > + * o FFA_MEM_DONATE_* and FFA_MEM_LEND_* - Used when tranferring ownership > + * or access of a memory readion > + * o FFA_MSG_SEND2 and FFA_MSG_WAIT - Used for indirect messaging > + * o FFA_MSG_YIELD > + * o FFA_INTERRUPT - Used to report preemption > + * o FFA_RUN > + * > + * Limitations in the implemented FF-A interfaces: > + * o FFA_RXTX_MAP_*: > + * - Maps at most 32 4k pages large RX and TX buffers > + * - RT/TX buffers must be normal RAM Can you explain why this is a problem? > + * - Doesn't support forwarding this call on behalf of an endpoint > + * o FFA_MEM_SHARE_*: only supports sharing > + * - from a VM to an SP > + * - with one borrower > + * - with the memory transaction descriptor in the RX/TX buffer > + * - normal memory > + * - at most 512 kB large memory regions > + * - at most 32 shared memory regions per guest > + * o FFA_MSG_SEND_DIRECT_REQ: > + * - only supported from a VM to an SP > + * > + * There are some large locked sections with ffa_tx_buffer_lock and > + * ffa_rx_buffer_lock. Especially the ffa_tx_buffer_lock spinlock used > + * around share_shm() is a very large locked section which can let one VM > + * affect another VM. > */ > > #include Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 21:00:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 21:00:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520975.809175 (Exim 4.92) (envelope-from ) id 1pn43P-0002AD-AC; Thu, 13 Apr 2023 21:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520975.809175; Thu, 13 Apr 2023 21:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn43P-0002A6-7M; Thu, 13 Apr 2023 21:00:27 +0000 Received: by outflank-mailman (input) for mailman id 520975; Thu, 13 Apr 2023 21:00:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn43O-0002A0-KT for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 21:00:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn43N-0005iQ-NU; Thu, 13 Apr 2023 21:00:25 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pn43N-0006ML-G8; Thu, 13 Apr 2023 21:00:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Ag2m83F870Cvztjq8+K6JnjMvBiAtIBnhlonGZVMLEY=; b=NlZZYNnze0XdrXvObNrLz2QWHU X1Qt9nPDGruRyCKNd+hPwKiyy0ExOlpFpGxvTADKybzq3/9yv62FJW/NmqBxh87MIaSriXbOUv3T9 rloJAfd1XJLBcCIGBfK1apw/UxExkfDGj1+yMCKiZbFj6NoqgkkEoygaboP5uVstAWrc=; Message-ID: <7a29bc06-61b5-51e6-4625-bf19e530b975@xen.org> Date: Thu, 13 Apr 2023 22:00:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-23-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20230413071424.3273490-23-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, On 13/04/2023 08:14, Jens Wiklander wrote: > Describes a FF-A version 1.1 [1] mediator to communicate with a Secure > Partition in secure world. > > [1] https://developer.arm.com/documentation/den0077/latest > Signed-off-by: Jens Wiklander > --- > SUPPORT.md | 8 ++++++++ > docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/SUPPORT.md b/SUPPORT.md > index aa1940e55f09..1fd746f7f7f2 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -818,6 +818,14 @@ that covers the DMA of the device to be passed through. > > No support for QEMU backends in a 16K or 64K domain. > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > + > + Status, Arm64: Tech Preview > + > +There are still some code paths where a vCPU may hog a pCPU longer than > +necessary. The FF-A mediator is not yet implemented for Arm32. Part of the > +FF-A specification is not supported. NIT: You would suggest to add: "(See the top comment in ...)". So one can easily find the limitation. > + > ### ARM: Guest Device Tree support > > Status: Supported > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index 10f37990be57..bba99c576b48 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1645,6 +1645,21 @@ in OP-TEE. > > This feature is a B. > > +=item B > + > +B Allow a guest to communicate via FF-A with Secure Partitions > +(SP), default false. > + > +Currently is only a small subset of the FF-A specification supported. Just > +enough to communicate with OP-TEE. In general only direct messaging and > +sharing memory with one SP. More advanced use cases where memory might be > +shared or donated to multple SPs are not supported. Typo: s/multple/multiple/ > + > +See L for more > +informantion about FF-A. Typo: s/informantion/information/ > + > +This feature is a B. > + > =back > > =back -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 13 22:10:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 22:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520979.809185 (Exim 4.92) (envelope-from ) id 1pn58o-0000qk-DC; Thu, 13 Apr 2023 22:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520979.809185; Thu, 13 Apr 2023 22:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn58o-0000qO-AL; Thu, 13 Apr 2023 22:10:06 +0000 Received: by outflank-mailman (input) for mailman id 520979; Thu, 13 Apr 2023 22:10:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn58n-0000df-CE for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 22:10:05 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef133321-da47-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 00:10:02 +0200 (CEST) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Apr 2023 18:09:59 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5182.namprd03.prod.outlook.com (2603:10b6:208:1e7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 22:09:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Thu, 13 Apr 2023 22:09:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef133321-da47-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681423802; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=kOsCEgAqv4GvFI5JVXuSC44qWWFvhCNpXlX8jZL2Qhk=; b=Mi37dJ7hWm07CgIhi21AwzdaILHHjGdj31DhNs/twav15x7fWa3xRTER ISqV6wSy+QtPPn7TZkjAYwHhsvykK6Yq/uxBtXZkQYXsRW1AEihADdI48 UaPded8LB4K8A2W/nVb0dHff4e8dQGlbVvGIJ5zW+0f9v+pkQi+0031mK E=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 105349865 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:acNQZ6mTEvN2IO1VmQ8VXsvo5gxsJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWCmuGOanfNmWjL4t/aom18BhQ7ZLdmtNnHQc9+yFmEiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgX5QSGyxH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f49JytdRxK5vu2n7JudG9RGmeQcCeC+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieCwWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTODjqq863gD7Kmo7ExwVbl6cnbqA0HGmANdzB hY70A0vov1nnKCsZpynN/Gim1aGoxodVtx4A+A8rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVq/3LqJqTK5OQAOMHQPIyQDSGMt/N3LsIw1yBXVQb5LC7Wph9f4HTXxx TGiryUkgbgXy8kR2M2T9lfBjy+nurDZQwgt/ALVU2m5qARja+aYi5eA7FHa6bNMKdifR1zY5 HwcwZHGsaYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74Gu9OLc70KOWUJJK IronPort-HdrOrdr: A9a23:37+yoK0WQOwtXHE4mGckygqjBLYkLtp133Aq2lEZdPU1SL3gqy nKpp8mPHDP+VUssR0b9+xoW5PwJE80l6QFg7X5VI3KNGOL11dARLsSibcKqAeBJ8SRzI9gPQ oKScVD4FqaNykdsS4vizPIdOod/A== X-Talos-CUID: 9a23:5eTo2m8orICBok6Rf0uVv0wxFdt1W3/n9XjBD2aeWFtDV52qbHbFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3AmtwvtwxD5Q5UsuXFNO3smrfKGJSaqL+vC3sItql?= =?us-ascii?q?FgpO7LXd1FxrHox6QQ4Byfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,195,1677560400"; d="scan'208";a="105349865" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOQALRFoJSzgxzpef1efsMGDpP5dSD709yaikLV03/aUJaQxoP3lX3lYG4IVuf7HKZHzXa0ChRxGw3E1Bv8tteKmwD4WafeEt8+PxgnGcBgsUnoa5VREd3rBZMr3DheBH7O3HAZ+906blxQCDMalU+TLXAzDmRry3msOVo4JM/Z+SI+t+JWJoxtl7H2trUKOdew6v528kCyhORhkGqBpNmhjH21jjIbBgy/hTa3o3UjG0emTme8RK8u1VKhgyn6ufIcM8txWOJeYtLRrmbHIarKt5ykXdpOKOyr8lzob9sBmyOU5XDPrbhUxmW/81iAMj0PAmtNJVOdCGULlfo9K1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kOsCEgAqv4GvFI5JVXuSC44qWWFvhCNpXlX8jZL2Qhk=; b=hHRQSeeZx8oXQFJ1xfmyf38dut/bMagXXBaCi+j4R8qzgilQwuF8hzKuwEYfcExPUaLtJu2McBUe5MUEVh7A++TYsvglaUV+kAvzfGdIsnY1JxRqp3CWCnTGHZUru2rH/UZm9BFD7vzH/UvwT3fuRKqXI2I0VywuTFESKQwvauMogIxGI9uD62DUglo8/QIPrpGjeqeyEIVQStmDAyT0afF3ebr8GUEo/0EhcPaz+cWm1K4CylqSXhJJynA+sIBX2U0QB9akcv5/+D6z5Hrzwe9dZkvU/CYmO+iR5iL7jmKyZB3WqlGW6i3KtJ34ILvz+sLTm/9SG48ateNN9EbOkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOsCEgAqv4GvFI5JVXuSC44qWWFvhCNpXlX8jZL2Qhk=; b=dUk/llRNWMJ+d/jSavaa/Rcw1IPCCXASbJSERRy0Bb1Ag6ws/aBZokowjunKq01dSG6BMDiTibmtU9Zne5rJOzsdIQ0jjAR4DhwNdZGW07RtJ7rv2u/vdi9w32mo42W1S+iXqnPqMU1yXv4wIPRzhwMnckpHKETx6Y0GjsFHoyI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 13 Apr 2023 23:09:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] xen: Fold exit paths in find_text_region() Content-Language: en-GB To: Julien Grall , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Stefano Stabellini References: <20230413192201.3255984-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0106.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5182:EE_ X-MS-Office365-Filtering-Correlation-Id: f74696c4-a8d8-4939-e935-08db3c6bd0cd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: asoWmoNP2Yf6r8PXjelYXfpHFe6GD1V06phds8fNoIWqGI5VM6QIdhQYllznpV+of9GkjjJG+IzQQSWdEXxByUurBdrMc2LSltXqgsM9KETTHQ/NRDIraVitUY3p6D9iLzUY3X+4egbcBJqKs3A4W62Wv9PEfHTw8ALRcbdd6+/Rifk55A/fqX2nyKiJtWss7z16+cfeFfWNmKySlvjNgfT/dMNsL/CYiTjEqLt9+canh2/f9FfCrEh5HqZuMdFrLGloufOCSqJHFAw7bJb7Zbc94z/c18tILUxoTYbEa778qBqb3c7DVi9SNhbLoHz+d7tUFzRxp+iHvh/BevmOHlaElvj+7Cw+Z0jSssl5vONzU62HSE4UG8izKsO2Wdcztfv7tcB5byhaAppTW49LMPGAV+86v/QFFz/dAM2Gd89LmfUSAkNOUAwSTZ4rDdgW+u3qHZ4gA41Es2/D7eH5CBTqq+fwSdqXA6+gWY7oGtlzycRADRqnyWdlEodTQZFKlzpzd9XxlNwW5HtDjKvKl1Ir69FTDn7Tcv0EyMeWVyS83BshRgsXSm3fW3Q90X2alREUI0WmJh4xrPFljIOZuBB2veXstsyIx9tIS7uJklU4JeLZHlMqmHKkHxew5tB9zpziFtqjEYQhICJHT3hO4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199021)(2616005)(83380400001)(82960400001)(41300700001)(5660300002)(2906002)(31686004)(8936002)(38100700002)(8676002)(186003)(53546011)(6506007)(6512007)(26005)(6486002)(110136005)(6666004)(36756003)(66476007)(66556008)(4326008)(66946007)(54906003)(86362001)(31696002)(316002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWhsOEsyS2JzSUpGVjJDZDZsclNDemdYeGpUcUUrVFR6ZWNSUlZFeDgvOGQ3?= =?utf-8?B?bTdIT1pTZkxIUHV6TGZ0SGRsaXk5d3kySTZ2SWRGOERxVVJNbndhVzdlc2ho?= =?utf-8?B?bjE5SUIrVWxITlhPZkY4bHpzQXdxZHdZR2pkSUpteENFcUhNOEYwZ0NDOUIv?= =?utf-8?B?bnVEZ0hXNkJpZWJPdHhLR1VmVTQyQzN5YzMwS0IyenVobW5jRkdjalkrNmdy?= =?utf-8?B?MEFMaWMyY21VSmdwRWowVFdpeWhJejNsNlUyS0xlbm55V09NUGl1UDVveUg0?= =?utf-8?B?ZWgwcysza005aERLTndxSzF5a2V1Y1EyTlB5K1hLRzZpR1NicUZFWnV1VmdH?= =?utf-8?B?Z3FIbk9Ed0dqR0RMVXhMUWM4Ti96bEYvOTJNM2VOOWl1WjlmWEY4Z3ZIY3Jo?= =?utf-8?B?ODF6MTB3c0JveG44ejNpUkhKaG52QjU5WFQ5bFkxSEpvcThmTUhDYlRiQWZn?= =?utf-8?B?czlhSnRYaGV0eVR0L3VCK2JSOG5EbHFNOTdGZnlXRGxBb3hFK2JNZEUvQkky?= =?utf-8?B?TGtKd1gza3RwdzF2NHNPQWxpbVVJcklXZzVFR3JHSklKc2hCUWcvanUrM2ts?= =?utf-8?B?ODMwRExHSkdIK1RUY1ZnTjl0SlNyTFl4MU5QTnFPT2NyMjJXOURjMUtkN2Y0?= =?utf-8?B?UWlDckZxU3RXbzJWSHVFRWtrWFVPOEtWb25RenFHMFRHT0FSck4rb1hGeUVO?= =?utf-8?B?Z281RVdpbTkydWlya3NtVi9UT1EvQnJ2QmFKd0RObmxxTjV0V001aW9FY3hS?= =?utf-8?B?bmZxMkFnNjg4cjZ1VEQ2K2tXam1OVmY0V0pQNzhlc2xoWUxtNDc4K0ZiMDl1?= =?utf-8?B?THBIRzJIMGZBSnQwZVp0Qnl1cUhrRzhmMVBBZjB4TUhGTFRNZERFWS9pV1ZB?= =?utf-8?B?elpTbUVwTE5BdkR5UzF0TjVuZCswbkhnZUQ0UjdaS1c5OFYzd1pKZGlqYlhU?= =?utf-8?B?Y1h3WlorMmF0MkJwZ0xVLzRyZUdjNyt1UHVpWFJDdE05SnRyc2NhS2h4RGMx?= =?utf-8?B?ZGNtaE0zYmU1STZNOUJlMWVSUEZ5RGVzcDNNQjZHNXd6WEZQRmZYWFpIRTZa?= =?utf-8?B?WXVyMmNyWmQ4cGY1S2thNFFZZElJejdaMFpCbU04KzBJTktHK2IyL21KbHhM?= =?utf-8?B?bkZIeG9pMnJJcEJVMjQ0dDRYWjNaUmlKL3VEVWo1dU9lUXo1anpDeUhOZnN1?= =?utf-8?B?ZWZUQzM2ek9adm9ZTWVNaEhvMjIzK3BjL2xEQ2lVYkJLYkpUK2N0NzMvdElv?= =?utf-8?B?RUNpRnpDblVVSUJvRTRDWFlQcXU5ZzMxNmsrM1JnUDRUUUlDaTU1RW5RVjA3?= =?utf-8?B?Y0VBMk1tRlFTbzFQNWNRL0R6U2FtQ1V6ei9rcy9jb3NUdTUyNm5tUURrYnM5?= =?utf-8?B?cGVqbWpMWWRwbEk1Z29jM1dCUW5EYmp5SUNBc2k4R2pBeEZLdjRnSk5zYk9S?= =?utf-8?B?ampTemM4bStNeGFsdmNobmlsbTJhOUowdmQ3RGZwZ29HdWJoTDBWVTdZWTVl?= =?utf-8?B?Q3RETUJPN3RLRjltenVmcC9aT2dyK296dS91VFNWWjNoTzFXUisrcGtIYW9s?= =?utf-8?B?WmJRNGEzODlkZDdTS3VXbUd5T1hkb3F4REJydGFIcVBzZVU4bnVFTmIwREcz?= =?utf-8?B?WUs5MmNzQnpYYW5WM2tQSzRmNzFaWGsvM3k4Uk5qMlRFdEMxZ3dKb2tXOUZB?= =?utf-8?B?VmtSOEt2VkYyeWIwWmcrU0NublFkVFhLZXRoSzJSUUltb0lkR3hwQ09ZSjJo?= =?utf-8?B?MmpRZU11cWt3dVhRbFV6dStZbjkwbVpwL25RYW9POGlOU2pkTjQwU3lpN2VH?= =?utf-8?B?WCtpend2Nm5YYVNyc0ZVUkovUGZHZENtTzhXUmZBWGRjWEd5eEZUTCswQ3Rt?= =?utf-8?B?bkkvMkNlY0R6SlBGd0J1bXBxNm5oTnVOOWlxK2hYNXNLVWl2anpTK21wWXBl?= =?utf-8?B?TVlMZWowUVl6NUJDQkZqN3hKMmZmL3NhcEFwb05OK3MyZ2Q5a2h6Sm8vYjQ4?= =?utf-8?B?M1k1c0wvdEo0QnF6aGV4K0U3YWtKMjYrcUFhWmhxR3BRZENBSFNXbGJpZWVj?= =?utf-8?B?UmlVY2hTVFEzeXdXUm45VUxZV3RIRk5xeUdqVlp5WlJZUkhzTWF2MjlRNlZv?= =?utf-8?B?MGtYOFJNSmQvSkVuT1kwZkZYd2xmcjVHcHgrN0F2MGVpcjhWVVJ6NFJqMEdN?= =?utf-8?B?anc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zivnrkVRXoWT5eJdix3ZpBo8nZQFNFTGkJIE1WTvpTyMSklDsk0RjNKLHXJUBtOm3dJYHMm6TLzm5LZ7fPByCn3JDUWSWdTy1a9VH5Cu6mJaxD10VCRjLGVyXxdKzIbX/BAHsPA/EjWDTHuowGIpm/TSDl+3D14ebgBTn8G1itR30hisJizNYs3FPniZmQaB2EiUKiBbGUoIkXypBYrc+5A4nOt/lumk8CMiEVvLg1cJ++sbiNbOrkXOVNR0DFBfvHfeOirATAZDN9PAAinRWaVk9KlgWf8pF8kRXwT4OoEEZ+3tyPdbMaEGTyP02fZ75Wl/2GeA0YlbgtNJhIrxUaxI4xufSHrUnkiiYeeOJ7zQjeujoT4qQ75EVQjbgl97uvshcaQRL6UlPF3vz5DKLGq7ezkR80a7JEB/MgUWxAGd134i2HKeIDF+ADU1GYuZ5rLmuPQijDRGV9m4F+C59751HCh7t/pV8BOfa/k1WMMlr4+FIa5HGTEApGkxmXC8PzbxN4JS9cMnJ3/jK2scvYQ5MaRvPpEMjXTN2njiDCjDX1Jq9CLy6fABCYlQ9rlGtvlgfy2HiFvhilsarN64/MT9DwQu5hDHKnCj7vVDztZeVWiJk94R+XojIin5x3u5c56uW3TY3PVrdQJDPmMtJYgJmrIc1Ejn7dfWUSBjCos038nw48Ycd4x3CRKTaa8rAs1YKUe9W05tFp7Jx49arVVg9eKp8Sp/asHp0p/kdP7Mov4+VA8yP2ZtBh1GXC2YM8bUwdCvF+oCnMhLd6oDF4BmBWzPKAqcr6eI6C1Z1CDiLBovypLdgFNKJXqXTI2xWatI/708sAwlDyhw7IZ1eocWeh6d3r1z1QpcvWdYOgE2s2HqZed4bVmgMbCD00qn8UbYe3Rdj+yKrsFa/Ysn8w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f74696c4-a8d8-4939-e935-08db3c6bd0cd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 22:09:56.8903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o8I/HqXrYqgIeRd2QsYrN0nDJiA3jFpv1dKj+AfAMDtveP8vjGfEpLKeneOZenOayGy3scNGW4e6Re1yWUrXdqbhKDzAf2bhR8ubYdLRaKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5182 On 13/04/2023 9:13 pm, Julien Grall wrote: > > On 13/04/2023 20:22, Andrew Cooper wrote: >> Despite rcu_read_unlock() being fully inlineable, the optimiser >> cannot fold >> these exit paths, because of the various compiler barriers providing RCU >> safety.  Help the compiler out. > > Please mention which compiler(s) (including version) you used. > >> >> This compiles to marginally better code in all cases. > So the code itself is fine with me. But this raises a few questions. > If this is marginal, then why are you doing it? What's your end goal? I happened to be working in the area while fixing a bug.  But am not justifying "because I judged it to be worth doing" further; it is entirely self evident from the fact I sent the patch. Whether you meant it to be or not, the request comes across as insulting, and is not something which should be made of any submitter. But as this kind of thing has come up before, any further debate on the matter can be made to the code of conduct board. A better phrasing might have been "I'm sorry, I don't understand.  Why is this an improvement?"  But I'm only guessing as to what this issue is. But moving to the technicals aspects, in an attempt to help this along. Do you understand what folding the exit paths means?  It's a term which is used frequently enough on list that it ought to be taken for granted, and is what in my opinion makes the patch entirely self-evident. > Lastly what do you mean by "all cases"? Is it all arch? All compilers? Yes. > > Anyway, if this pattern is important (TBD why), then I think we should > update the CODING_STYLE with some guidance. Otherwise, we may > introduce similar patterns (we already have some). Perhaps, but I don't have the time, energy, or willing to dive into the viper pit which is trying to make any changes to that document at all.  Especially when there's a laundry list of more important topics that ought to take priority... ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 13 23:01:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 13 Apr 2023 23:01:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520985.809196 (Exim 4.92) (envelope-from ) id 1pn5wd-0006G8-AB; Thu, 13 Apr 2023 23:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520985.809196; Thu, 13 Apr 2023 23:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn5wd-0006G1-7J; Thu, 13 Apr 2023 23:01:35 +0000 Received: by outflank-mailman (input) for mailman id 520985; Thu, 13 Apr 2023 23:01:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn5wb-0006Fv-W4 for xen-devel@lists.xenproject.org; Thu, 13 Apr 2023 23:01:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 208ff823-da4f-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 01:01:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C5C5863341; Thu, 13 Apr 2023 23:01:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E13AFC433EF; Thu, 13 Apr 2023 23:01:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 208ff823-da4f-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681426889; bh=HkfMfx/YlMGO+2U+jZmIS1g1NsyaL0g6VbZzS6yZE1I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=V4hEkSmqMgJiHk18bhxF4FAXOuzAkGR1+sp1kueeZJLrC0/JkH9ZniLuj4aQBlCF/ tde5AVOVrgEIpTKizMg0v49bbTB0PYeoi7rIiyYbY77lJ2CUuIGxr1Lm81y6NYiVix hNF7cyRF5FuMgPKSxIq5rYinBzTjQNU6oRI8kj8c+3dmNHchnPL5ZDUZ1hu44lIYaL ZcSZ8QjhrziEAh2UlLTp0XsMlxcjx4IQGTYz+/zLNyE66+WY7Mc+S/jKjDWz6xMS+x 6xxRdQt33Mma7rs2P3QsSLeSe/CtIBgRX9ztcz41pUwCpwIz8PuyKZmDyb8H+aVgmg zzclo+F+UCD1g== Date: Thu, 13 Apr 2023 16:01:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Julien Grall , Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Stefano Stabellini Subject: Re: [PATCH] xen: Fold exit paths in find_text_region() In-Reply-To: Message-ID: References: <20230413192201.3255984-1-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-616007622-1681424106=:15580" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-616007622-1681424106=:15580 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 13 Apr 2023, Andrew Cooper wrote: > On 13/04/2023 9:13 pm, Julien Grall wrote: > > > > On 13/04/2023 20:22, Andrew Cooper wrote: > >> Despite rcu_read_unlock() being fully inlineable, the optimiser > >> cannot fold > >> these exit paths, because of the various compiler barriers providing RCU > >> safety.  Help the compiler out. > > > > Please mention which compiler(s) (including version) you used. > > > >> > >> This compiles to marginally better code in all cases. > > So the code itself is fine with me. But this raises a few questions. > > If this is marginal, then why are you doing it? What's your end goal? > > I happened to be working in the area while fixing a bug.  But am not > justifying "because I judged it to be worth doing" further; it is > entirely self evident from the fact I sent the patch. > > Whether you meant it to be or not, the request comes across as > insulting, and is not something which should be made of any submitter. > > But as this kind of thing has come up before, any further debate on the > matter can be made to the code of conduct board. > > A better phrasing might have been "I'm sorry, I don't understand.  Why > is this an improvement?"  But I'm only guessing as to what this issue is. Hi Andrew, I don't think Julien's comment was insulting. You probably thought this was a two steps process: step1: Why? step2: Gotcha! NACK! But Julien's question should be taken at face value. Julien even wrote that he thinks the code is OK. "Why is this an improvement?" is a nicer way to phrase it but both are OK in my view. When we make code improvements (not bug fixes or new features) and the improvement is marginal, I think it is an OK question to ask why you thought it was worth doing. For instance, could it be that there are other additional benefits that you didn't write down in the commit message? Such as, is the code more readable, easier to maintain, more resilient to attacks? It is also OK if it is only a marginal improvement but in any case "why are you doing it" should be or be seen as a challenge. > But moving to the technicals aspects, in an attempt to help this along. > > Do you understand what folding the exit paths means?  It's a term which > is used frequently enough on list that it ought to be taken for granted, > and is what in my opinion makes the patch entirely self-evident. > > > Lastly what do you mean by "all cases"? Is it all arch? All compilers? > > Yes. > > > > > Anyway, if this pattern is important (TBD why), then I think we should > > update the CODING_STYLE with some guidance. Otherwise, we may > > introduce similar patterns (we already have some). > > Perhaps, but I don't have the time, energy, or willing to dive into the > viper pit which is trying to make any changes to that document at all.  > Especially when there's a laundry list of more important topics that > ought to take priority... Also here, I don't think Julien meant to put one more potentially-blocking obstacle in your path to upstreaming the improvement. If folding the exit paths is an important pattern it is a good idea to make it a recommended guideline project-wide under CODING_STYLE. It makes your idea more generally applicable. Otherwise we end up with, let's say, xen/arch/x86 with good exit paths and xen/arch/arm with bad exit paths. It should not be taboo to update CODING_STYLE. In the past it was difficult, but now we have a process in place. Specifically, I am happy to add it to the agenda for the next MISRA C meeting, where we can make a snap decision on this guideline in few minutes. Once it is in CODING_STYLE, you won't have to discuss on the mailing list why you are doing this sort of things anymore, and you can follow up with dozen of patches improving exit paths everywhere. I don't think you need to wait for the next MISRA C meeting (or other calls) before following up on this one patch, but suggesting an update of CODING_STYLE I think it is positive. --8323329-616007622-1681424106=:15580-- From xen-devel-bounces@lists.xenproject.org Fri Apr 14 00:18:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 00:18:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520992.809206 (Exim 4.92) (envelope-from ) id 1pn78b-0005ci-8y; Fri, 14 Apr 2023 00:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520992.809206; Fri, 14 Apr 2023 00:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn78b-0005cb-5B; Fri, 14 Apr 2023 00:18:01 +0000 Received: by outflank-mailman (input) for mailman id 520992; Fri, 14 Apr 2023 00:17:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn78Z-0005cR-0T; Fri, 14 Apr 2023 00:17:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn78Y-0002Jx-Ue; Fri, 14 Apr 2023 00:17:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn78Y-0002zg-Gk; Fri, 14 Apr 2023 00:17:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pn78Y-0007Ap-GI; Fri, 14 Apr 2023 00:17:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tDfZ4Xi51k8E9IqFOo+R+TbzvOuZhpbbDwcG9ScHaC4=; b=Zm8uB6UFLjH1/uLBJvFW00+x4S wrbV5Jd4dXE+0jXrvWlRtJnBWhXsKvE3mPjXei32DvWNKax6xVfSsX0vQjxLuH/ZrL/BN2t11q7v4 GEKWv5FwW+8vrsm0VyPHNsxgL3MI9OiEpmGCYLjdy+3q5rfW4TfP+wOeCkMWwe/Xbh1A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180250: all pass - PUSHED X-Osstest-Versions-This: ovmf=55b67b6950e648338adfe8ec54aeb26ed89d2c97 X-Osstest-Versions-That: ovmf=d795fb571b9b2c2ee67ceaef372d5cc461767859 From: osstest service owner Date: Fri, 14 Apr 2023 00:17:58 +0000 flight 180250 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180250/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 55b67b6950e648338adfe8ec54aeb26ed89d2c97 baseline version: ovmf d795fb571b9b2c2ee67ceaef372d5cc461767859 Last test of basis 180248 2023-04-13 16:40:45 Z 0 days Testing same since 180250 2023-04-13 19:43:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: devel@edk2.groups.io Nickle Wang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d795fb571b..55b67b6950 55b67b6950e648338adfe8ec54aeb26ed89d2c97 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 14 01:00:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 01:00:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.520998.809216 (Exim 4.92) (envelope-from ) id 1pn7o3-0004FP-Ck; Fri, 14 Apr 2023 01:00:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 520998.809216; Fri, 14 Apr 2023 01:00:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn7o3-0004EX-A0; Fri, 14 Apr 2023 01:00:51 +0000 Received: by outflank-mailman (input) for mailman id 520998; Fri, 14 Apr 2023 01:00:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn7o1-0003PZ-FG; Fri, 14 Apr 2023 01:00:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn7o1-0005jd-Af; Fri, 14 Apr 2023 01:00:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn7o0-0004ao-QR; Fri, 14 Apr 2023 01:00:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pn7o0-00038e-Pv; Fri, 14 Apr 2023 01:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9o8hufXQ8Ift/7JSVqG5AnvXGlph2HNHNYbob3wY8fs=; b=4fgASHtdc6Qa5Z7AivCqpxuccA z/XtJueRqpKKs7ErgBt0tTGzU/S5gW3ibdkus/HZtB3vTbTFgtJ8F07PWG3sbqf68HLOy7ydriaJU B6NesW28o9bbh0BIu/U79ajTlhRu8OBBklhHdEHdsutCKmkzHUDT19ymQ27CMixnNmfw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180230: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=de4664485abbc0529b1eec44d0061bbfe58a28fb X-Osstest-Versions-That: linux=e62252bc55b6d4eddc6c2bdbf95a448180d6a08d From: osstest service owner Date: Fri, 14 Apr 2023 01:00:48 +0000 flight 180230 linux-linus real [real] flight 180252 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180230/ http://logs.test-lab.xenproject.org/osstest/logs/180252/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 180252-retest test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180252-retest test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 180252-retest test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 180252-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180208 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180208 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180208 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180208 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180208 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux de4664485abbc0529b1eec44d0061bbfe58a28fb baseline version: linux e62252bc55b6d4eddc6c2bdbf95a448180d6a08d Last test of basis 180208 2023-04-11 19:10:17 Z 2 days Failing since 180222 2023-04-12 16:43:41 Z 1 days 2 attempts Testing same since 180230 2023-04-13 07:36:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alessandro Manca Andy Shevchenko David Howells Jiri Kosina Linus Torvalds Martin Povišer Peter Korsgaard Philipp Jungkamp Philippe Troin Shaunak Saha Srinivas Pandruvada Tanu Malhotra Todd Brandt Vinod Koul Yang Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git e62252bc55b6..de4664485abb de4664485abbc0529b1eec44d0061bbfe58a28fb -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Apr 14 01:32:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 01:32:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521004.809226 (Exim 4.92) (envelope-from ) id 1pn8I6-0004AR-Pt; Fri, 14 Apr 2023 01:31:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521004.809226; Fri, 14 Apr 2023 01:31:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn8I6-0004AK-KK; Fri, 14 Apr 2023 01:31:54 +0000 Received: by outflank-mailman (input) for mailman id 521004; Fri, 14 Apr 2023 01:31:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn8I4-0004AD-II for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 01:31:52 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ec51e7f-da64-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 03:31:47 +0200 (CEST) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33DFVh3I012539; Fri, 14 Apr 2023 01:30:44 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3pxgh7tt83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 01:30:44 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by DU0PR03MB9633.eurprd03.prod.outlook.com (2603:10a6:10:42f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 01:30:40 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::9b45:4d32:a743:d5e3%3]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 01:30:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ec51e7f-da64-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/XYGwsbX3tlkEnTql0JyT6h3G7rqs41W4omX6rQz0T/MYWICpcFKfwgMjr+CZK4ZI/rxJLilaSfkrqMPckU4BTnuzNX1dui0rcL5vVKLsymzwqVJZb2dEtTYSweHa8dszzCjOeW7NkRlp0o8t7VpFLlFnMn8QSxdyb7lKJZXA8QtREM/PvIYN65UlW7pC5N4/hL5ugffRie+OrTrcsdgLDzyhSBdPk4QiDDiEu0H/93rd5AabYrRJavzLesDJpL15QQ0MNawZVYnlRiQFSYOaU4XnDj8jiGBSuvDGD60hB5UnN3yX6FE58cqmzMg93slUUa8CQe6hPYaeUmXytENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a8a2Eq9xah/4GejivNZd2LJafoVPQEkFOxgCLXtX3kM=; b=HvvRRQ4cDiFBS95Zes2s4CZA6aJca28+ihCmTeo4a+KGkcShzH0h46sRq6WtHdEdbONRLkxR20SvsdcpG/QywCl6K2h2cMawpq/MgWvfctmeV5QlcHO4u/01he2e0R9Yj4Tw/KTCfE2ZHe/D75yBrN+th8B0y7p9e2KpCiEHAP6ja0JHUUQw4spq0wyQQAVmjGXH7rECkmfOgSd+CIKnilenaJk6cUbtyeywsk7CiNuyqMxDEYy3ctvPNlByeRl5yC5lrAfJuSRXsAZOio+lkNIyFzXM6twN9tH7Jzi3J6+djZFYaJo2qjP0EJ8K3VcOXbL9fpnJqgnMaOt9XUL/zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a8a2Eq9xah/4GejivNZd2LJafoVPQEkFOxgCLXtX3kM=; b=gfLmVZvRp+hNCzT9TzJse23kUoVuIldOinZQ2PMKf8l0ywfsH6seT7/fDqYDs6kEJsVf+JCaQQlLyK3IA5dOAgVQPq/h2gQuSgbh1FeT/38Mr3B5Id9GjUJhtJSzDKmi8xbdbpAm54DX6yjHxXmN6AkuNtyb+FGk4cK8Epoezqw2NUel6CUnKExa8kepqdvwgRUh+z40wBzP4Icsp2geVySPR/1CeJiGaiYk1h21aFguGrOD4r3Akl1cQcsjI80NhQybm4fA23zK7ZBNMqNaQfiOwHL5Ez0bANOk4zNIgKZJ+A1Cs7f+VaVUIaGJ1BBubvXUe+1hscH1VplUY1TJeA== From: Volodymyr Babchuk To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: "xen-devel@lists.xenproject.org" , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Kevin Tian Subject: Re: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Thread-Topic: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Thread-Index: AQHZVrdzsdckomMx4kauxHkZQ597Iq79mAMAgClI2ACAAK/igIAAVGGAgAGe14CAAJvOAA== Date: Fri, 14 Apr 2023 01:30:39 +0000 Message-ID: <87leivw8qp.fsf@epam.com> References: <20230314205612.3703668-1-volodymyr_babchuk@epam.com> <20230314205612.3703668-3-volodymyr_babchuk@epam.com> <873556xa0g.fsf@epam.com> <87v8i0wyv0.fsf@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|DU0PR03MB9633:EE_ x-ms-office365-filtering-correlation-id: 5999ec03-55fa-45f9-6896-08db3c87daf7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9XjiIyxXQUmahxVs5aYvwRy5kJO19TZ1dLLbkQr4mktU7egjIwP6n/1jjiiHox08vFuXjQtXmEnGuu5441cQv+wlpVMPRA//0YglXS7di9vBEMNkWeysf494KR/yLgMGt+60Ncdw2ORY5D/TGgv8zIkMIZZ5XGXycBNCDY5p8Px7TuRherMyqdHWFXqGPqy/1l5/fBt49Q75QGe2Zmf67M/ynTXU4oHQhzbERq7hDLDajaTP3NWwMduM4NsrUv6Wd8MketO0q98+8U8g0YXzrzi5J5bLOpo+vqSlSG4NNCBOv1gn0MZDdAENKphLwNTyKVlTGC456ytG9YH5+vApaypNq41Yvr0hALKIs5rSorC+A4dcxjgT3eQjxgfSiz4WKLZS1DDp0m2CWbwkHkr+wqrqd8YKzlOE5XZ8U+T4X9ZuorzNAMpoGIkDlxbkcsNBPWDKuFZy4aUGC8EKVhDfnc6n1u+LULM5ggruK9dGZqbn1pmbShhw98wVRESM9Y4h8s3T4XF+OpmxlCrD+usJrQWod3Or4SFbBb6xxTPpJyKB/DYg5cWOwVWYb6i1YVWMA9mxNnx9GHypR0NHHu5YyYbWdOzuPJVZtaQ3xCpZQsN/wqBT4q2HY+hITdryzrQmx4hFnf82Yc4hg0Sn+9pmAg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(451199021)(30864003)(83380400001)(54906003)(2616005)(91956017)(6506007)(76116006)(6486002)(6512007)(26005)(186003)(478600001)(55236004)(7416002)(2906002)(36756003)(38100700002)(122000001)(5660300002)(66556008)(64756008)(41300700001)(66446008)(4326008)(66476007)(66946007)(6916009)(38070700005)(316002)(8676002)(86362001)(8936002)(71200400001)(66899021)(68124002)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ejRzY0JpcG5wUlF3K2QwdE1lMDVTRjhWdEIxcU15Sk43VVhkOWVObTlYemF2?= =?utf-8?B?Y2FnSm1rVjZ0N3VlNnZRaU95bi90UlhndVJtZXlURnpZdEZtU0Y0alB5eHkv?= =?utf-8?B?bWc3SjZwdXVrUkF3Q0tiYUFVdlU2ZnFvZUpyRXJ1MVNoejE3K2lqbG5DNWYv?= =?utf-8?B?V0toTVVBd29oaDgxUnZFL09xMkVOMlFTdVplSGZDVDN2eTZ1ODlOK242d1A2?= =?utf-8?B?b1h3M1FERWNqT1VUdjh4bmVLYjBrTVB0Q3ZuWXBUNm9ZeHRtV2QwUFdNSzBq?= =?utf-8?B?TVVoaC9PZmV5UU5WZWVCWW5PYnJuMkFGcWV4RnB2SFlTQWFYVnJKdG55dmZM?= =?utf-8?B?YldpOWZUSmRKZ1ArSi9za0tzVkdWWWhHMmE1WUJEQWxha0NhUTF0bHRmc1No?= =?utf-8?B?bGtiSGJHRGtBc0c3cjBlejY2UXNwaDdzRTFKTXE4cHMvUWQ5SVZBeldEQTZl?= =?utf-8?B?elNJb0pNWDJ2cXlKTUtSVjZLUi9YREdwb3d0RFRuRmdVYWRBV3pxMzF2V0JX?= =?utf-8?B?VmVQOG9CV2NiemhFYjhxMzdzd1pJQmxVejYrQkI2bERNV2RqUi9lbDBlQW5F?= =?utf-8?B?bzF6VFVkbFd5S1FUajJjWmdZaXdrNVNtZGV2Z2tDZ1VVenV0VHZNMjRjZkNy?= =?utf-8?B?Y1o2TmlmKzRWTXozOTFzNWxXYnNTeEJGbGlXeUlPL2pSb3NrRFMxYzhJTXFs?= =?utf-8?B?azQvbHJCNHBUZ3RMc09Nc0xndFUvbGRybDhhTUNWb3diMGNaeGRtYnBMQk1q?= =?utf-8?B?ZWhsbFRtQzJvQmt5THMyb25FVmJWeXVuOVdURXVMT1JJOG9kdS9SMktEZnFh?= =?utf-8?B?b1RpOEllV1VNWEtOZmdhdEtqbFdkWFRTMkdaM29VVjUyVnlXRHA3RWFVcmpj?= =?utf-8?B?SlpCSlNuUy9RSmRqY2NOdGNnTkRkcnpPUXFES3A1QlU2TllUTngraytwbmJt?= =?utf-8?B?UDYza3ptZmN4anh2L0ZTeVVvVDR6SkpZejdrQzg4OGJpR3V5cndDQTFkbi9T?= =?utf-8?B?ME1CWWRkeFhlcTFSbzlDVjNsMzNrN1Bpd1lkT2VhOG1lRzVTRXZDRVovN3dh?= =?utf-8?B?Mzk4MWtnMWNmaGI4K2NGSHFOV0tIekZ1WlhjTi9DVkxpYmUvWnprTjU2R2JY?= =?utf-8?B?TFFYY0gzQU1MaGhIVmwxZndTdVg5M1FqdUV4OWFzWU9VMDhNS1pXY0NJa041?= =?utf-8?B?YWoyaWsvYVBGb2hJdFZrZ1Z3MjZyZ05rRlRQYTJJQTh1ZFBuWE5oOXRRZG4z?= =?utf-8?B?RmVXc0VNZ29aakY5b1kyc0VVWlRLVHlHM3lmU1pMRVNrNHdVV0lEOXRyK2JD?= =?utf-8?B?Z2FFb3R4dzVmUHhkeXN3VkJ4eUFQYXpjd1BpQXpzc2svVzBiNFBPZmVQeisv?= =?utf-8?B?Y0FVd09Sa00xMnEwMXRnMW1UUlBQbGZncmNCUEFmd2N3VlVxbE5zRmV5Ulp4?= =?utf-8?B?UHRJaHJadkZNeTJJeHRyRTVyZDdiTjlmbzRvUmtwUTNuUU9jWmhmWEZ4QjVi?= =?utf-8?B?MHZXUmQzbTFQVFZ1RXl0eTVUVDRqajhHMnRmQVNzcDRrb2k4ek5JWFhKYVY2?= =?utf-8?B?eXM5TitYelZjWHZ6WVZmbXRJMm9EU2Rxcm80bllLYW1lcjZHTHR1Wm1tRkhC?= =?utf-8?B?cENCaVJ0RkxaS2pWWHA0akdNQURqSkROd3NrQWRpVXRSUWZqSWhxV0hNbDhP?= =?utf-8?B?T2tJS3pmSlRLZzRucXpDOEgzZXNmR1pUSUJabmVFVEVDam4wRGtiYmJZQUhP?= =?utf-8?B?ak9zd1JvZnh6aU9GTDA4bnFWYSs1d0lCQ0p1eVAvdm5PaVV3ZTM2RnF4d0Rn?= =?utf-8?B?V3h3dWJPbDUxbFV5VFdORVEwY0hMSlNFczJYekFMcTRqS1NvMW83cVBUempR?= =?utf-8?B?U1o5VWEydWVwdlNVSUVqR2lyZnBXZEt1b2JEc09XeGJNaTkvd2phU3M0bkk5?= =?utf-8?B?a0FVNnNUMnRKcHVLUE1maG12V0RBNlRjcHFnZ2JPaHNlNjllV09KZEk0SXVx?= =?utf-8?B?S1NNdW1lN0VZUW5lTWcxYmFhNnM1MjNYYzU4QUJiR0pvUXNiSDdaUlgyV0Zv?= =?utf-8?B?TGl4dDFjclZFcENEdW1qa3hrWXNHWWdQUU5rYzhUY1JZNkJvcFN6TmRYcnFn?= =?utf-8?B?RnAyZkZyQlVqdEZnUzhRS2tNaUN1bXRyOFJaVnpqaTl6TjJXMDA1NU1EWSt1?= =?utf-8?B?SlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <290C356A125B8C4E8892EA12C30F89E2@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5999ec03-55fa-45f9-6896-08db3c87daf7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 01:30:39.4783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IBRDax+kUaqDAwlBDAmmCbkb1/ik9iZhYZtTc5IYmxYL0EYPuD2emJEypMoAz0dkeOd4YS8d7kTTGcdRFm+lTlkhviDGB41H0j7QNRMr6Uk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB9633 X-Proofpoint-GUID: 7binSmdBOPWGMRNlQs2zZkREctIHtiSr X-Proofpoint-ORIG-GUID: 7binSmdBOPWGMRNlQs2zZkREctIHtiSr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-13_18,2023-04-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 impostorscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304140011 DQpIaSBSb2dlciwNCg0KUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdy aXRlczoNCg0KPiBPbiBXZWQsIEFwciAxMiwgMjAyMyBhdCAwOTo1NDoxMlBNICswMDAwLCBWb2xv ZHlteXIgQmFiY2h1ayB3cm90ZToNCj4+IA0KPj4gSGkgUm9nZXIsDQo+PiANCj4+IEZpcnN0IG9m IGFsbCwgSSB3YW50IHRvIHByb3ZpZGUgbGluayBbMV0gdG8gdGhlIFJGQyBzZXJpZXMgd2hlcmUg SSB0cmllZA0KPj4gdG90YWwgUENJIGxvY2tpbmcgcmV3b3JrLiBBZnRlciBkaXNjdXNzaW5nIHdp dGggSmFuLCBpdCBiZWNhbWUgY2xlYXIgZm9yDQo+PiBtZSwgdGhhdCB0YXNrIGlzIG11Y2ggaGFy ZGVyLCB0aGFuIEkgYW50aWNpcGF0ZWQuIFNvLCBpdCB3YXMgZGVjaWRlZCB0bw0KPj4gbW92ZSB3 aXRoIGEgc21hbGxlciBzdGVwcy4gRmlyc3Qgc3RlcCBpcyB0byBtYWtlIHZQQ0kgY29kZSBpbmRl cGVuZGVkDQo+PiBmcm9tIHRoZSBnbG9iYWwgUENJIGxvY2suIEFjdHVhbGx5LCB0aGlzIGlzIG5v dCB0aGUgZmlyc3QgdHJ5Lg0KPj4gT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gdHJpZWQgdG8gdXNl IHIvdyBsb2NrIGZvciB0aGlzOiBbMl0uIEJ1dCwNCj4+IEphbiBzdWdnZXN0ZWQgdG8gdXNlIHJl ZmNvdW50aW5nIGluc3RlYWQgb2Ygci93IGxvY2tzLCBhbmQgSSBsaWtlZCB0aGUNCj4+IGlkZWEu IFNvLCB0aGlzIGlzIHdoeSB5b3UgYXJlIHNlZWluZyB0aGlzIHBhdGNoIHNlcmllcy4NCj4NCj4g VGhhbmtzLCBJJ3ZlIGJlZW4gb24gbGVhdmUgZm9yIGxvbmcgcGVyaW9kcyByZWNlbnRseSBhbmQg SSd2ZSBtaXNzZWQNCj4gc29tZSBvZiB0aGUgc2VyaWVzLg0KPg0KDQpEaWQgeW91IGNoZWNrZWQg dGhpcyBSRkMgc2VyaWVzPyBJIGFtIG5vdCBhc2tpbmcgeW91IHRvIHJldmlldyBpdCwgSSBhbQ0K anVzdCBjdXJpb3VzIGFib3V0IHlvdXIgb3BpbmlvbiBvbiB0aGUgc2VsZWN0ZWQgYXBwcm9hY2gN Cg0KPj4gDQo+PiANCj4+IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3 cml0ZXM6DQo+PiANCj4+ID4gT24gVHVlLCBBcHIgMTEsIDIwMjMgYXQgMTE6NDE6MDRQTSArMDAw MCwgVm9sb2R5bXlyIEJhYmNodWsgd3JvdGU6DQo+PiA+PiANCj4+ID4+IEhpIFJvZ2VyLA0KPj4g Pj4gDQo+PiA+PiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JpdGVz Og0KPj4gPj4gDQo+PiA+PiA+IE9uIFR1ZSwgTWFyIDE0LCAyMDIzIGF0IDA4OjU2OjI5UE0gKzAw MDAsIFZvbG9keW15ciBCYWJjaHVrIHdyb3RlOg0KPj4gPj4gPj4gUHJpb3IgdG8gdGhpcyBjaGFu Z2UsIGxpZmV0aW1lIG9mIHBjaV9kZXYgb2JqZWN0cyB3YXMgcHJvdGVjdGVkIGJ5IGdsb2JhbA0K Pj4gPj4gPj4gcGNpZGV2c19sb2NrKCkuIExvbmctdGVybSBwbGFuIGlzIHRvIHJlbW92ZSB0aGlz IGxvZywgc28gd2UgbmVlZCBzb21lDQo+PiA+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIF4gbG9jaw0KPj4gPj4gPg0KPj4gPj4gPiBJIHdvdWxk bid0IHNheSByZW1vdmUsIGFzIG9uZSB3YXkgb3IgYW5vdGhlciB3ZSBuZWVkIGEgbG9jayB0byBw cm90ZWN0DQo+PiA+PiA+IGNvbmN1cnJlbnQgYWNjZXNzZXMuDQo+PiA+PiA+DQo+PiA+PiANCj4+ ID4+IEknbGwgd3JpdGUgInJlcGxhY2UgdGhpcyBnbG9iYWwgbG9jayB3aXRoIGNvdXBsZSBvZiBt b3JlIGdyYW51bGFyDQo+PiA+PiBsb2NraW5nIGRldmljZXMiDQo+PiA+PiBpZiB0aGlzIGlzIG9r YXkgZm9yIHlvdS4NCj4+ID4+IA0KPj4gPj4gPj4gb3RoZXIgbWVjaGFuaXNtIHRvIGVuc3VyZSB0 aGF0IHRob3NlIG9iamVjdHMgd2lsbCBub3QgZGlzYXBwZWFyIHVuZGVyDQo+PiA+PiA+PiBmZWV0 IG9mIGNvZGUgdGhhdCBhY2Nlc3MgdGhlbS4gUmVmZXJlbmNlIGNvdW50aW5nIGlzIGEgZ29vZCBj aG9pY2UgYXMNCj4+ID4+ID4+IGl0IHByb3ZpZGVzIGVhc3kgdG8gY29tcHJlaGVuZCB3YXkgdG8g Y29udHJvbCBvYmplY3QgbGlmZXRpbWUuDQo+PiA+PiA+PiANCj4+ID4+ID4+IFRoaXMgcGF0Y2gg YWRkcyB0d28gbmV3IGhlbHBlciBmdW5jdGlvbnM6IHBjaWRldl9nZXQoKSBhbmQNCj4+ID4+ID4+ IHBjaWRldl9wdXQoKS4gcGNpZGV2X2dldCgpIHdpbGwgaW5jcmVhc2UgcmVmZXJlbmNlIGNvdW50 ZXIsIHdoaWxlDQo+PiA+PiA+PiBwY2lkZXZfcHV0KCkgd2lsbCBkZWNyZWFzZSBpdCwgZGVzdHJv eWluZyBvYmplY3Qgd2hlbiBjb3VudGVyIHJlYWNoZXMNCj4+ID4+ID4+IHplcm8uDQo+PiA+PiA+ PiANCj4+ID4+ID4+IHBjaWRldl9nZXQoKSBzaG91bGQgYmUgdXNlZCBvbmx5IHdoZW4geW91IGFs cmVhZHkgaGF2ZSBhIHZhbGlkIHBvaW50ZXINCj4+ID4+ID4+IHRvIHRoZSBvYmplY3Qgb3IgeW91 IGFyZSBob2xkaW5nIGxvY2sgdGhhdCBwcm90ZWN0cyBvbmUgb2YgdGhlDQo+PiA+PiA+PiBsaXN0 cyAoZG9tYWluLCBwc2VnIG9yIGF0cykgdGhhdCBzdG9yZSBwY2lfZGV2IHN0cnVjdHMuDQo+PiA+ PiA+PiANCj4+ID4+ID4+IHBjaWRldl9nZXQoKSBpcyByYXJlbHkgdXNlZCBkaXJlY3RseSwgYmVj YXVzZSB0aGVyZSBhbHJlYWR5IGFyZQ0KPj4gPj4gPj4gZnVuY3Rpb25zIHRoYXQgd2lsbCBwcm92 aWRlIHZhbGlkIHBvaW50ZXIgdG8gcGNpX2RldiBzdHJ1Y3Q6DQo+PiA+PiA+PiBwY2lfZ2V0X3Bk ZXYoKSwgcGNpX2dldF9yZWFsX3BkZXYoKS4gVGhleSB3aWxsIGxvY2sgYXBwcm9wcmlhdGUgbGlz dCwNCj4+ID4+ID4+IGZpbmQgbmVlZGVkIG9iamVjdCBhbmQgaW5jcmVhc2UgaXRzIHJlZmVyZW5j ZSBjb3VudGVyIGJlZm9yZSByZXR1cm5pbmcNCj4+ID4+ID4+IHRvIHRoZSBjYWxsZXIuDQo+PiA+ PiA+PiANCj4+ID4+ID4+IE5hdHVyYWxseSwgcGNpX3B1dCgpIHNob3VsZCBiZSBjYWxsZWQgYWZ0 ZXIgZmluaXNoaW5nIHdvcmtpbmcgd2l0aCBhDQo+PiA+PiA+PiByZWNlaXZlZCBvYmplY3QuIFRo aXMgaXMgdGhlIHJlYXNvbiB3aHkgdGhpcyBwYXRjaCBoYXZlIHNvIG1hbnkNCj4+ID4+ID4+IHBj aWRldl9wdXQoKXMgYW5kIHNvIGxpdHRsZSBwY2lkZXZfZ2V0KClzOiBleGlzdGluZyBjYWxscyB0 bw0KPj4gPj4gPj4gcGNpX2dldF8qKCkgZnVuY3Rpb25zIG5vdyB3aWxsIGluY3JlYXNlIHJlZmVy ZW5jZSBjb3VudGVyDQo+PiA+PiA+PiBhdXRvbWF0aWNhbGx5LCB3ZSBqdXN0IG5lZWQgdG8gZGVj cmVhc2UgaXQgYmFjayB3aGVuIHdlIGZpbmlzaGVkLg0KPj4gPj4gPg0KPj4gPj4gPiBBZnRlciBs b29raW5nIGEgYml0IGludG8gdGhpcywgSSB3b3VsZCBsaWtlIHRvIGFzayB3aGV0aGVyIGl0J3Mg YmVlbg0KPj4gPj4gPiBjb25zaWRlcmVkIHRoZSBuZWVkIHRvIGluY3JlYXNlIHRoZSByZWZjb3Vu dCBmb3IgZWFjaCB1c2Ugb2YgYSBwZGV2Lg0KPj4gPj4gPg0KPj4gPj4gDQo+PiA+PiBUaGlzIGlz IGhvdyBMaW51eCB1c2VzIHJlZmVyZW5jZSBsb2NraW5nLiBJdCBkZWNyZWFzZXMgY29nbml0aXZl IGxvYWQNCj4+ID4+IGFuZCBjaGFuY2UgZm9yIGFuIGVycm9yLCBhcyB0aGVyZSBpcyBhIHNpbXBs ZSBzZXQgb2YgcnVsZXMsIHdoaWNoIHlvdQ0KPj4gPj4gZm9sbG93Lg0KPj4gPj4gDQo+PiA+PiA+ IEZvciBleGFtcGxlIEkgd291bGQgY29uc2lkZXIgdGhlIGluaXRpYWwgYWxsb2NfcGRldigpIHRv IHRha2UgYQ0KPj4gPj4gPiByZWZjb3VudCwgYW5kIHRoZW4gcGNpX3JlbW92ZV9kZXZpY2UoKSBf bXVzdF8gYmUgdGhlIGZ1bmN0aW9uIHRoYXQNCj4+ID4+ID4gcmVtb3ZlcyB0aGUgbGFzdCByZWZj b3VudCwgc28gdGhhdCBpdCBjYW4gcmV0dXJuIC1FQlVTWSBvdGhlcndpc2UgKHNlZQ0KPj4gPj4g PiBteSBjb21tZW50IGJlbG93KS4NCj4+ID4+IA0KPj4gPj4gSSB0ZW5kIHRvIGRpc2FncmVlIHRo ZXJlLCBhcyB0aGlzIHJ1aW5zIHRoZSB2ZXJ5IGlkZWEgb2YgcmVmZXJlbmNlDQo+PiA+PiBjb3Vu dGluZy4gV2UgY2FuJ3Qga25vdyB3aG8gZWxzZSBob2xkcyByZWZlcmVuY2UgcmlnaHQgbm93LiBP a2F5LCB3ZQ0KPj4gPj4gbWlnaHQga25vdywgYnV0IHRoaXMgcmVxdWlyZXMgYWRkaXRpb25hbCBs b2NrIHRvIHNlcmlhbGl6ZQ0KPj4gPj4gYWNjZXNzZXMuIFdoaWNoLCBpbiB0dXJuLCBtYWtlcyBy ZWZjb3VudCB1bi1uZWVkZWQuDQo+PiA+DQo+PiA+IEluIHByaW5jaXBsZSBwY2lfcmVtb3ZlX2Rl dmljZSgpIG11c3QgcmVwb3J0IHdoZXRoZXIgdGhlIGRldmljZSBpcw0KPj4gPiByZWFkeSB0byBi ZSBwaHlzaWNhbGx5IHJlbW92ZWQgZnJvbSB0aGUgc3lzdGVtLCBzbyBpdCBtdXN0IHJldHVybg0K Pj4gPiAtRUJVU1kgaWYgdGhlcmUgYXJlIHN0aWxsIHVzZXJzIGFjY2Vzc2luZyB0aGUgZGV2aWNl Lg0KPj4gPg0KPj4gPiBBIHVzZXIgd291bGQgdXNlIFBIWVNERVZPUF9tYW5hZ2VfcGNpX3JlbW92 ZSB0byBzaWduYWwgWGVuIGl0J3MgdHJ5aW5nDQo+PiA+IHRvIHBoeXNpY2FsbHkgcmVtb3ZlIGEg UENJIGRldmljZSBmcm9tIGEgc3lzdGVtLCBzbyB3ZSBtdXN0IGVuc3VyZQ0KPj4gPiB0aGF0IHdo ZW4gdGhlIGh5cGVydmlzb3IgcmV0dXJucyBzdWNjZXNzIHRoZSBkZXZpY2UgaXMgcmVhZHkgdG8g YmUNCj4+ID4gcGh5c2ljYWxseSByZW1vdmVkLg0KPj4gPg0KPj4gPiBPciBhdCBsZWFzdCB0aGF0 J3MgbXkgdW5kZXJzdGFuZGluZyBvZiBob3cgdGhpcyBzaG91bGQgd29yay4NCj4+ID4NCj4+IA0K Pj4gQXMgSSBjYW4gc2VlLCB0aGlzIGlzIG5vdCBob3cgaXQgaXMgaW1wbGVtZW50ZWQgcmlnaHQN Cj4+IG5vdy4gcGNpX3JlbW92ZV9kZXZpY2UoKSBpcyBub3QgY2hlY2tpbmcgaWYgZGV2aWNlIGlz IG5vdCBhc3NpZ25lZCB0byBhDQo+PiBkb21haW4uIElkIGRvZXMgbm90IGNoZWNrIGlmIHRoZXJl IGFyZSBzdGlsbCB1c2VycyBhY2Nlc3NpbmcgdGhlDQo+PiBkZXZpY2UuIEl0IGp1c3QgcmVsaWVz IG9uIGEgdGhlIGdsb2JhbCBQQ0kgbG9jayB0byBlbnN1cmUgdGhhdCBkZXZpY2UgaXMNCj4+IHJl bW92ZWQgaW4gYW4gb3JkZXJseSBtYW5uZXIuDQo+DQo+IFJpZ2h0LCB0aGUgZXhwZWN0YXRpb24g aXMgdGhhdCBhbnkgcGF0aCBpbnNpZGUgb2YgdGhlIGh5cGVydmlzb3IgdXNpbmcNCj4gdGhlIGRl dmljZSB3aWxsIGhvbGQgdGhlIHBjaWRldnMgbG9jaywgYW5kIHRodXMgYm55IGhvbGRpbmcgaXQg d2hpbGUNCj4gcmVtb3Zpbmcgd2UgYXNzZXJ0IHRoYXQgbm8gdXNlcnMgKGluc2lkZSB0aGUgaHlw ZXJ2aXNvcikgYXJlIGxlZnQuDQo+DQoNCk1heSBJIHByb3Bvc2VkIGEgYml0IHJlbGF4ZWQgYXNz ZXJ0aW9uPyAiV2UgYXNzZXJ0IHRoYXQgbm8gdXNlcnMgdGhhdA0KYWNjZXNzIHRoZSBkZXZpY2Ug YXJlIGxlZnQiLiBXaGF0IEkgYW0gdHJ5aW5nIGlzIHNheSB0aGVyZSwgdGhhdCBubyBvbmUNCndp bGwgdHJ5IHRvIGFjY2Vzcywgc2F5LCBkZXZpY2UncyBjb25maWcgc3BhY2UuIEJlY2F1c2UgdGhl IGRldmljZQ0KYWxyZWFkeSBtYXkgYmUgcGh5c2ljYWxseSByZW1vdmVkIGFuZCBhbnkgYWNjZXNz IHRvIHRoZSBkZXZpY2UgaXRzZWxmDQp3aWxsIGNhdXNlIGEgZmF1bHQuIEJ1dCB0aGVyZSBtYXkg YmUgdXNlcnMgdGhhdCBjYW4gYWNjZXNzIHN0cnVjdCBwZGV2DQp0aGF0IGNvcnJlc3BvbmRzIHRv IHRoaXMgZGV2aWNlLg0KDQo+IEkgZG9uJ3QgdGhpbmsgd2UgaGF2ZSBiZWVuIHZlcnkgY29uc2lz dGVudCBhYm91dCB0aGUgdXNhZ2Ugb2YgdGhlDQo+IHBjaWRldnMgbG9jaywgYW5kIGhlbmNlIG1v c3Qgb2YgdGhpcyBpcyBsaWtlbHkgYnJva2VuLiAgSG9wZWZ1bGx5DQo+IHJlbW92aW5nIGEgUENJ IGRldmljZSBmcm9tIGEgc3lzdGVtIGlzIGEgdmVyeSB1bmNvbW1vbiBvcGVyYXRpb24uDQo+DQo+ PiBNeSBwYXRjaCBzZXJpZXMgaGFzIG5vIGludGVudGlvbiB0byBjaGFuZ2UgdGhpcyBiZWhhdmlv ci4gQWxsIHdoYXQgSQ0KPj4gd2FudCB0byBhY2hpZXZlIC0gaXMgdG8gYWxsb3cgdnBjaSBjb2Rl IGFjY2VzcyBzdHJ1Y3QgcGRldiBvYmplY3RzDQo+PiB3aXRob3V0IGhvbGRpbmcgdGhlIGdsb2Jh bCBQQ0kgbG9jay4gDQo+DQo+IFRoYXQncyBhbGwgZmluZSwgYnV0IHdlIG5lZWQgdG8gbWFrZSBz dXJlIGl0IGRvZXNuJ3QgbWFrZSB0aGluZ3Mgd29yc2UNCj4gYW5kIHdoYXQgdGhleSBjdXJyZW50 bHkgYXJlLCBhbmQgaWRlYWxseSBpdCBzaG91bGQgbWFrZSB0aGluZ3MgZWFzaWVyLg0KPg0KPiBU aGF0J3Mgd2h5IEkgd291bGQgbGlrZSB0byB1bmRlcnN0YW5kIGV4YWN0bHkgd2hhdCdzIHRoZSBw dXJwb3NlIG9mDQo+IHRoZSByZWZjb3VudCwgYW5kIGhvdyBpdCBzaG91bGQgYmUgdXNlZC4gIFRo ZSB1c2FnZSBvZiB0aGUgcmVmY291bnQNCj4gc2hvdWxkIGJlIGNvbXBhdGlibGUgd2l0aCB0aGUg aW50ZW5kZWQgYmVoYXZpb3VyIG9mDQo+IHBjaV9yZW1vdmVfZGV2aWNlKCksIHJlZ2FyZGxlc3Mg b2Ygd2hldGhlciB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbg0KPiBpcyBub3QgY29ycmVjdC4g IFdlIGRvbid0IHdhbnQgdG8gYmUgcGlsaW5nIHVwIG1vcmUgYnJva2VuIHN0dWZmIG9uDQo+IHRv cCBvZiBhbiBhbHJlYWR5IGJyb2tlbiBpbXBsZW1lbnRhdGlvbi4NCj4NCg0KSSBhZ3JlZSB3aXRo IHlvdS4gSSdsbCBmaXggdGhlIGlzc3VlIHdpdGggdlBDSSwgdGhhdCB5b3UgbWVudGlvbmVkIGJl bG93DQphbmQgcHJlcGFyZSBtb3JlIGNvbXByZWhlbnNpdmUgY29tbWl0IGRlc2NyaXB0aW9uIGlu IHRoZSBuZXh0IHZlcnNpb24uDQoNCj4+ID4+ID4NCj4+ID4+ID4gVGhhdCBtYWtlcyBtZSB3b25k ZXIgaWYgZm9yIGV4YW1wbGUgY2FsbGVycyBvZiBwY2lfZ2V0X3BkZXYoZCwgc2JkZikNCj4+ID4+ ID4gZG8gbmVlZCB0byB0YWtlIGFuIGV4dHJhIHJlZmNvdW50LCBiZWNhdXNlIHN1Y2ggYWNjZXNz IGlzIGFscmVhZHkNCj4+ID4+ID4gcHJvdGVjdGVkIGZyb20gdGhlIHBkZXYgZ29pbmcgYXdheSBi eSB0aGUgZmFjdCB0aGF0IHRoZSBkZXZpY2UgaXMNCj4+ID4+ID4gYXNzaWduZWQgdG8gYSBndWVz dC4gIEJ1dCBtYXliZSBpdCdzIHRvbyBtdWNoIHdvcmsgdG8gc2VwYXJhdGUgdXNlcnMNCj4+ID4+ ID4gb2YgcGNpX2dldF9wZGV2KGQsIC4uLik7IHZzIHBjaV9nZXRfcGRldihOVUxMLCAuLi4pOy4N Cj4+ID4+ID4NCj4+ID4+ID4gVGhlcmUncyBhbHNvIGEgd2luZG93IHdoZW4gdGhlIHJlZmNvdW50 IGlzIGRyb3BwZWQgdG8gMCwgYW5kIHRoZQ0KPj4gPj4gPiBkZXN0cnVjdGlvbiBmdW5jdGlvbiBp cyBjYWxsZWQsIGJ1dCBhdCB0aGUgc2FtZSB0aW1lIGEgY29uY3VycmVudA0KPj4gPj4gPiB0aHJl YWQgY291bGQgYXR0ZW1wdCB0byB0YWtlIGEgcmVmZXJlbmNlIHRvIHRoZSBwZGV2IHN0aWxsPw0K Pj4gPj4gDQo+PiA+PiBMYXN0IHBjaWRldl9wdXQoKSB3b3VsZCBiZSBjYWxsZWQgYnkgcGNpX3Jl bW92ZV9kZXZpY2UoKSwgYWZ0ZXIgcmVtb3ZpbmcNCj4+ID4+IGl0IGZyb20gYWxsIGxpc3RzLiBU aGlzIHNob3VsZCBwcmV2ZW50IG90aGVyIHRocmVhZHMgZnJvbSBvYnRhaW5pbmcgYSB2YWxpZA0K Pj4gPj4gcmVmZXJlbmNlIHRvIHRoZSBwZGV2Lg0KPj4gPg0KPj4gPiBXaGF0IGlmIGEgY29uY3Vy cmVudCB1c2VyIGhhcyB0YWtlbiBhIHJlZmVyZW5jZSB0byB0aGUgb2JqZWN0IGJlZm9yZQ0KPj4g PiBwY2lfcmVtb3ZlX2RldmljZSgpIGhhcyByZW1vdmVkIHRoZSBkZXZpY2UgZnJvbSB0aGUgbGlz dHMsIGFuZCBzdGlsbA0KPj4gPiBob2xkcyBpdCB3aGVuIHBjaV9yZW1vdmVfZGV2aWNlKCkgcGVy Zm9ybXMgdGhlIHN1cHBvc2VkbHkgbGFzdA0KPj4gPiBwY2lkZXZfcHV0KCkgY2FsbD8NCj4+IA0K Pj4gV2VsbCwgbGV0J3MgY29uc2lkZXIgVlBDSSBjb2RlIGFzIHRoaXMgY29uY3VycmVudCB1c2Vy LCBmb3INCj4+IGV4YW1wbGUuIEZpcnN0LCBpdCB3aWxsIHRyeSB0byB0YWtlIHZwY2ktPmxvY2su IERlcGVuZGluZyBvbiB3aGVyZSBpbg0KPj4gcGNpX3JlbW92X2RldmljZSgpIHRoZXJlIHdpbGwg YmUgdGhyZWUgY2FzZXM6DQo+PiANCj4+IDEuIExvY2sgaXMgdGFrZW4gYmVmb3JlIHZwY2lfcmVt b3ZlX2RldmljZSgpIHRha2VzIHRoZSBsb2NrLiBJbiB0aGlzDQo+PiBjYXNlIHZwY2kgY29kZSB3 b3JrcyBhcyBhbHdheXMNCj4+IA0KPj4gMi4gSXQgdHJpZXMgdG8gdGFrZSB0aGUgbG9jayB3aGVu IHZwY2lfcmVtb3ZlX2RldmljZSgpIGlzIGFscmVhZHkgbG9ja2VkDQo+PiB0aGlzLiBJbiB0aGlz IGNhc2Ugd2UgYXJlIGZhbGxpbmcgdG8gdGhlIG5leHQgY2FzZToNCj4+IA0KPj4gMy4gTG9jayBp cyB0YWtlbiBhZnRlciB2cGNpX3JlbW92ZV9kZXZpY2UoKSBoYWQgZmluaXNoZWQgaXQncyB3b3Jr LiBJbiB0aGlzDQo+PiBjYXNlIHZQQ0kgY29kZSBzZWVzIHRoYXQgaXQgd2FzIGNhbGxlZCBmb3Ig YSBkZXZpY2UgaW4gYW4gaW52YWxpZCBzdGF0ZQ0KPj4gYW5kIGV4aXRzLg0KPg0KPiBGb3IgMikg YW5kIDMpIHlvdSB3aWxsIGhpdCBhIGRlcmVmZXJlbmNlLCBhcyB0aGUgbG9jayAodnBjaS0+bG9j aykNCj4gd291bGQgaGF2ZSBiZWVuIGZyZWVkIGJ5IHZwY2lfcmVtb3ZlX2RldmljZSgpIHdoaWxl IGEgY29uY3VycmVudCB1c2VyDQo+IGlzIHdhaXRpbmcgb24gcGNpX3JlbW92X2RldmljZSgpIHRv IHJlbGVhc2UgdGhlIGxvY2suDQo+DQo+IEknbSBub3Qgc3VyZSBob3cgdGhlIHVzZXIgc2VlcyB0 aGUgZGV2aWNlIGlzIGluIGFuIGludmFsaWQgc3RhdGUsDQo+IGJlY2F1c2UgaXQgd2FzIHdhaXRp bmcgb24gYSBsb2NrICh2cGNpLT5sb2NrKSB0aGF0IGhhcyBiZWVuIHJlbW92ZWQNCj4gdW5kZXIg aXQncyBmZWV0Lg0KPg0KPiBUaGlzIGlzIGFuIGV4aXN0aW5nIGlzc3VlIG5vdCBtYWRlIHdvcnNl IGJ5IHRoZSByZWZjb3VudGluZywgYnV0IGl0J3MNCj4gbm90IGEgZ3JlYXQgZXhhbXBsZS4NCj4N Cg0KWWVzLCBhZ3JlZS4gSSBhbSBnb2luZyB0byBtb3ZlIHZwY2ktPmxvY2sgdG8gdGhlIHVwcGVy IGxldmVsDQoocGRldi0+dnBjaV9sb2NrKSBhbmQgcmV3b3JrIHZQQ0kgY29kZSBzbyBpdCB3aWxs IGdyYWNlZnVsbHkgaGFuZGxlDQogcGRldi0+dnBjaSA9PSBOVUxMLg0KDQo+PiANCj4+IEFzIHlv dSBjYW4gc2VlLCB0aGVyZSBpcyBubyBjYXNlIHdoZXJlIHZQQ0kgY29kZSBpcyBydW5uaW5nIG9u IGFuIGRldmljZQ0KPj4gd2hpY2ggd2FzIHJlbW92ZWQuDQo+PiANCj4+IEFmdGVyIHZQQ0kgY29k ZSBkcm9wcyByZWZjb3VudGVyLCBwZGV2IG9iamVjdCB3aWxsIGJlIGZyZWVkIG9uY2UgYW5kIGZv cg0KPj4gYWxsLiBQbGVhc2Ugbm9kZSwgdGhhdCBJIGFtIHRhbGtpbmcgYWJvdXQgcGRldiBvYmpl Y3QgdGhlcmUsIG5vdCBhYm91dA0KPj4gUENJIGRldmljZSwgYmVjYXVzZSBQQ0kgZGV2aWNlIChh cyBhIGhpZ2gtbGV2ZWwgZW50aXR5KSB3YXMgZGVzdHJveWVkIGJ5DQo+PiBwY2lfcmVtb3ZlX2Rl dmljZSgpLiByZWZjb3VudCBpcyBuZWVkZWQganVzdCBmb3IgdGhlIGxhc3QgY2xlYW4tdXANCj4+ IG9wZXJhdGlvbnMuDQo+DQo+IFJpZ2h0LCBidXQgcGNpX3JlbW92ZV9kZXZpY2UoKSB3aWxsIHJl dHVybiBzdWNjZXNzIGV2ZW4gd2hlbiB0aGVyZSBhcmUNCj4gc29tZSB1c2VycyBob2xkaW5nIGEg cmVmY291bnQgdG8gdGhlIGRldmljZSwgd2hpY2ggaXMgSU1PIHVuZGVzaXJhYmxlLg0KPg0KPiBB cyBJIHVuZGVyc3RhbmQgaXQgdGhlIHB1cnBvc2Ugb2YgcGNpX3JlbW92ZV9kZXZpY2UoKSBpcyB0 aGF0IG9uY2UgaXQNCj4gcmV0dXJucyBzdWNjZXNzIHRoZSBkZXZpY2UgY2FuIGJlIHBoeXNpY2Fs bHkgcmVtb3ZlZCBmcm9tIHRoZSBzeXN0ZW0uDQo+DQoNClllcywgSSB0b3RhbGx5IGFncmVlIHdp dGggeW91LiBCeSBzYXlpbmcgInRoZSBkZXZpY2UgY2FuIHBoeXNpY2FsbHkgcmVtb3ZlZA0KZnJv bSB0aGUgc3lzdGVtIiB3ZSBhcmUgYXNzZXJ0aW5nIHRoYXQgbm8gb25lIHdpbGwgdHJ5IHRvIGFj Y2VzcyB0aGlzDQpkZXZpY2UgdmlhIFBDSSBidXMuIEJ1dCB0aGlzIGlzIG5vdCB0aGUgc2FtZSBh cyAibm8gb25lIHNoYWxsIGFjY2Vzcw0Kc3RydWN0IHBkZXYgZmllbGRzIGFzIGl0IHNob3VsZCBi ZSBmcmVlZCBpbW1lZGlhdGVseSIuDQoNCj4+ID4NCj4+ID4+ID4NCj4+ID4+ID4+ICAgICAgICAg IHNiZGYuZGV2Zm4gJj0gfnN0cmlkZTsNCj4+ID4+ID4+ICAgICAgICAgIHBkZXYgPSBwY2lfZ2V0 X3BkZXYoTlVMTCwgc2JkZik7DQo+PiA+PiA+PiAgICAgICAgICBpZiAoIHBkZXYgJiYgc3RyaWRl ICE9IHBkZXYtPnBoYW50b21fc3RyaWRlICkNCj4+ID4+ID4+ICsgICAgICAgIHsNCj4+ID4+ID4+ ICsgICAgICAgICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPj4gPj4gPj4gICAgICAgICAgICAgIHBk ZXYgPSBOVUxMOw0KPj4gPj4gPj4gKyAgICAgICAgfQ0KPj4gPj4gPj4gICAgICB9DQo+PiA+PiA+ PiAgDQo+PiA+PiA+PiAgICAgIHJldHVybiBwZGV2Ow0KPj4gPj4gPj4gQEAgLTU0OCwxMyArNTI2 LDE4IEBAIHN0cnVjdCBwY2lfZGV2ICpwY2lfZ2V0X3BkZXYoY29uc3Qgc3RydWN0IGRvbWFpbiAq ZCwgcGNpX3NiZGZfdCBzYmRmKQ0KPj4gPj4gPj4gICAgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRy eSAoIHBkZXYsICZwc2VnLT5hbGxkZXZzX2xpc3QsIGFsbGRldnNfbGlzdCApDQo+PiA+PiA+PiAg ICAgICAgICAgICAgaWYgKCBwZGV2LT5zYmRmLmJkZiA9PSBzYmRmLmJkZiAmJg0KPj4gPj4gPj4g ICAgICAgICAgICAgICAgICAgKCFkIHx8IHBkZXYtPmRvbWFpbiA9PSBkKSApDQo+PiA+PiA+PiAr ICAgICAgICAgICAgew0KPj4gPj4gPj4gKyAgICAgICAgICAgICAgICBwY2lkZXZfZ2V0KHBkZXYp Ow0KPj4gPj4gPj4gICAgICAgICAgICAgICAgICByZXR1cm4gcGRldjsNCj4+ID4+ID4+ICsgICAg ICAgICAgICB9DQo+PiA+PiA+PiAgICAgIH0NCj4+ID4+ID4+ICAgICAgZWxzZQ0KPj4gPj4gPj4g ICAgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIHBkZXYsICZkLT5wZGV2X2xpc3QsIGRvbWFp bl9saXN0ICkNCj4+ID4+ID4+ICAgICAgICAgICAgICBpZiAoIHBkZXYtPnNiZGYuYmRmID09IHNi ZGYuYmRmICkNCj4+ID4+ID4+ICsgICAgICAgICAgICB7DQo+PiA+PiA+PiArICAgICAgICAgICAg ICAgIHBjaWRldl9nZXQocGRldik7DQo+PiA+PiA+PiAgICAgICAgICAgICAgICAgIHJldHVybiBw ZGV2Ow0KPj4gPj4gPj4gLQ0KPj4gPj4gPj4gKyAgICAgICAgICAgIH0NCj4+ID4+ID4+ICAgICAg cmV0dXJuIE5VTEw7DQo+PiA+PiA+PiAgfQ0KPj4gPj4gPj4gIA0KPj4gPj4gPj4gQEAgLTY2Myw3 ICs2NDYsMTAgQEAgaW50IHBjaV9hZGRfZGV2aWNlKHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4s DQo+PiA+PiA+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9TQkRGKHNlZywgaW5m by0+cGh5c2ZuLmJ1cywNCj4+ID4+ID4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaW5mby0+cGh5c2ZuLmRldmZuKSk7DQo+PiA+PiA+PiAgICAgICAgICBpZiAoIHBkZXYg KQ0KPj4gPj4gPj4gKyAgICAgICAgew0KPj4gPj4gPj4gICAgICAgICAgICAgIHBmX2lzX2V4dGZu ID0gcGRldi0+aW5mby5pc19leHRmbjsNCj4+ID4+ID4+ICsgICAgICAgICAgICBwY2lkZXZfcHV0 KHBkZXYpOw0KPj4gPj4gPj4gKyAgICAgICAgfQ0KPj4gPj4gPj4gICAgICAgICAgcGNpZGV2c191 bmxvY2soKTsNCj4+ID4+ID4+ICAgICAgICAgIGlmICggIXBkZXYgKQ0KPj4gPj4gPj4gICAgICAg ICAgICAgIHBjaV9hZGRfZGV2aWNlKHNlZywgaW5mby0+cGh5c2ZuLmJ1cywgaW5mby0+cGh5c2Zu LmRldmZuLA0KPj4gPj4gPj4gQEAgLTgxOCw3ICs4MDQsOSBAQCBpbnQgcGNpX3JlbW92ZV9kZXZp Y2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbikNCj4+ID4+ID4+ICAgICAgICAgICAgICBpZiAo IHBkZXYtPmRvbWFpbiApDQo+PiA+PiA+PiAgICAgICAgICAgICAgICAgIGxpc3RfZGVsKCZwZGV2 LT5kb21haW5fbGlzdCk7DQo+PiA+PiA+PiAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19ERUJV RyAiUENJIHJlbW92ZSBkZXZpY2UgJXBwXG4iLCAmcGRldi0+c2JkZik7DQo+PiA+PiA+PiAtICAg ICAgICAgICAgZnJlZV9wZGV2KHBzZWcsIHBkZXYpOw0KPj4gPj4gPj4gKyAgICAgICAgICAgIGxp c3RfZGVsKCZwZGV2LT5hbGxkZXZzX2xpc3QpOw0KPj4gPj4gPj4gKyAgICAgICAgICAgIHBkZXZf bXNpX2RlaW5pdChwZGV2KTsNCj4+ID4+ID4+ICsgICAgICAgICAgICBwY2lkZXZfcHV0KHBkZXYp Ow0KPj4gPj4gPg0KPj4gPj4gPiBIbSwgSSB0aGluayBoZXJlIHdlIHdhbnQgdG8gbWFrZSBzdXJl IHRoYXQgdGhlIGRldmljZSBoYXMgYmVlbiBmcmVlZCwNCj4+ID4+ID4gb3IgZWxzZSB5b3Ugd291 bGQgaGF2ZSB0byByZXR1cm4gLUVCVVNZIHRvIHRoZSBjYWxscyB0byBub3RpZnkgdGhhdA0KPj4g Pj4gPiB0aGUgZGV2aWNlIGlzIHN0aWxsIGluIHVzZS4NCj4+ID4+IA0KPj4gPj4gV2h5PyBBcyBJ IGNhbiBzZWUsIHBkZXYgb2JqZWN0IGlzIHN0aWxsIG1heSBwb3RlbnRpYWxseSBiZSBhY2Nlc3Nl ZCBieQ0KPj4gPj4gc29tZSBvdGhlciBDUFUgcmlnaHQgbm93LiBTbyBwZGV2IG9iamVjdCB3aWxs IGJlIGZyZWVkIGFmdGVyIGxhc3QNCj4+ID4+IHJlZmVyZW5jZSBpcyBkcm9wcGVkLiBBcyBpdCBp cyBhbHJlYWR5IHJlbW92ZWQgZnJvbSBhbGwgdGhlIGxpc3RzLA0KPj4gPj4gcGNpX2Rldl9nZXQo KSB3aWxsIG5vdCBmaW5kIGl0IGFueW1vcmUuDQo+PiA+PiANCj4+ID4+IEFjdHVhbGx5LCBJIGNh bid0IHNlZSBob3cgdGhpcyBjYW4gaGFwcGVuIGluIHJlYWxpdHksIGFzIFZQQ0ksIE1TSSBhbmQN Cj4+ID4+IElPTU1VIGFyZSBhbHJlYWR5IGRlYWN0aXZhdGVkIGZvciB0aGlzIGRldmljZS4gU28s IG5vIG9uZSB3b3VsZCB0b3VjaCBpdC4NCj4+ID4NCj4+ID4gV291bGRuJ3QgaXQgYmUgcG9zc2li bGUgZm9yIGEgY29uY3VycmVudCB1c2VyIHRvIGhvbGQgYSByZWZlcmVuY2UgZnJvbQ0KPj4gPiBi ZWZvZSB0aGUgZGV2aWNlIGhhcyBiZWVuICdkZWFjdGl2YXRlZCc/DQo+PiA+DQo+PiANCj4+IFll cywgaXQgY2FuIGhvbGQgYSByZWZlcmVuY2UuIFRoaXMgaXMgd2h5IHdlIG5lZWQgYWRkaXRpb25h bCBsb2NraW5nIHRvDQo+PiBlbnN1cmUgdGhhdCwgc2F5LCBwY2lfY2xlYW51cF9tc2koKSBkb2Vz IG5vdCByYWNlcyB3aXRoIHJlc3Qgb2YgdGhlIE1TSQ0KPj4gY29kZS4gUmlnaHQgbm93IHRoaXMg aXMgZW5zdXJlZCBieSB0aGVuIGdsb2JhbCBQQ0kgbG9jay4NCj4+IA0KPj4gPj4gPg0KPj4gPj4g PiBJIHRoaW5rIHdlIG5lZWQgYW4gZXh0cmEgcGNpZGV2X3B1dF9maW5hbCgpIG9yIHNpbWlsYXIg dGhhdCBjYW4gYmUNCj4+ID4+ID4gdXNlZCBpbiBwY2lfcmVtb3ZlX2RldmljZSgpIHRvIGFzc2Vy dCB0aGF0IHRoZSBkZXZpY2UgaGFzIGJlZW4NCj4+ID4+ID4gYWN0dWFsbHkgcmVtb3ZlZC4NCj4+ ID4+IA0KPj4gPj4gV2lsbCBzb21ldGhpbmcgYnJlYWsgaWYgd2UgZG9uJ3QgZG8gdGhpcz8gSSBj YW4ndCBzZWUgaG93IHRoaXMgY2FuDQo+PiA+PiBoYXBwZW4uDQo+PiA+DQo+PiA+IEFzIG1lbnRp b25lZCBhYm92ZSwgb25jZSBwY2lfcmVtb3ZlX2RldmljZSgpIHJldHVybnMgMCB0aGUgYWRtaW4N Cj4+ID4gc2hvdWxkIGJlIGNhcGFibGUgb2YgcGh5c2ljYWxseSByZW1vdmluZyB0aGUgZGV2aWNl IGZyb20gdGhlIHN5c3RlbS4NCj4+ID4NCj4+IA0KPj4gVGhpcyBwYXRjaCBzZXJpZXMgZG9lcyBu b3QgYWx0ZXIgdGhpcyByZXF1aXJlbWVudC4gQWRtaW4gaXMgc3RpbGwNCj4+IGNhcGFibGUgb2Yg cGh5c2ljYWxseSByZW1vdmluZyB0aGUgZGV2aWNlIGZyb20gdGhlIHN5c3RlbS4gQWZ0ZXINCj4+ IHN1Y2Nlc3NmdWwgY2FsbCB0byB0aGUgcGNpX3JlbW92ZV9kZXZpY2UoKQ0KPg0KPiBJbmRlZWQs IGJ1dCB0aGVyZSBtaWdodCBiZSB1c2VycyBpbiB0aGUgaHlwZXJ2aXNvciBzdGlsbCBob2xkaW5n IGENCj4gcmVmZXJlbmNlIHRvIHRoZSBwZGV2Lg0KPg0KDQpyZWZlcmVuY2UgY291bnRpbmcgYWxv bmUgY2FuJ3QgcHJvdGVjdCB5b3UgZnJvbSB0aGlzDQpzaXR1YXRpb24uIEFkZGl0aW9uYWwgbG9j a2luZyBpcyByZXF1aXJlZCBpbiB0aGlzIGNhc2UuIEFuZCByaWdodCBub3cgd2UNCmhhdmUgdGhl IGdsb2JhbCBQQ0kgbG9jayB0aGF0IHByb3RlY3RzIHVzLiBBY3R1YWxseSwgYWxtb3N0IGFsbCB0 aGUgY29kZQ0KdGFrZXMgYW5kIGRyb3BzIHJlZmVyZW5jZXMgd2hpbGUgaG9sZGluZyB0aGUgZ2xv YmFsIFBDSSBsb2NrLiBPbmx5IG9uZQ0KZXhjZXB0aW9uLCBhcyBmYXIgYXMgSSBrbm93LCBpcyB0 aGUgdlBDSSBjb2RlLiBXaGljaCBJIGFtIGdvaW5nIHRvIGZpeA0KaW4gdGhlIG5leHQgdmVyc2lv bi4NCg0KQWxzbywgSSdsbCBkb3VibGUgY2hlY2sgdGhhdCBvbmx5IHZQQ0kgY29kZSBvYnRhaW5z IHJlZmVyZW5jZXMgd2hpbGUgbm90DQpob2xkaW5nIHRoZSBnbG9iYWwgbG9jay4gTXkgcmVhc29u aW5nIGlzIHRoZSBmb2xsb3dpbmc6DQoNCjEuIFJpZ2h0IG5vdyAoaS5lLiBvbiBzdGFnaW5nIGJy YW5jaCkgYWxsIGFjY2Vzc2VzIHRvIHBkZXZzIGFyZQ0KaW4gY29uc2lzdGVudCBzdGF0ZS4gVGhp cyBiYXNpY2FsbHkgbWVhbnMgdGhhdCBhbGwgY29kZSB0aGF0IGFjY2Vzcw0KcGRldnMgaXMgZG9p bmcgdGhpcyB3aGlsZSBob2xkaW5nIGFuIGFwcHJvcHJpYXRlIGxvY2suIEdsb2JhbCBQQ0kgbG9j aywNCmluIG1vc3QgY2FzZXMuIFRoaXMgbWVhbnMgdGhlIGZvbGxvd2luZzogcGRldiBjYW4ndCBk aXNhcHBlYXIgdW5kZXIgb3VyDQpmZWV0LCBubyBvbmUgcmFjaW5nIHdpdGggdXMgd2hpbGUgYWNj ZXNzaW5nIHRoZSBwZGV2LCBubyBuZXcgcGRldiBjYW4gYmUNCmNyZWF0ZWQgd2hpbGUgd2UgYXJl IGhvbGRpbmcgdGhlIGdsb2JhbCBQQ0kgbG9jay4NCg0KMi4gQWRkaW5nIHJlZmVyZW5jZSBjb3Vu dGluZyBhbG9uZSBjaGFuZ2VzIG5vdGhpbmcgaW4gdGhpcw0KcmVnYXJkLiBBY3R1YWxseSwgUENJ IGNvZGUgd2lsbCBuZWVkbGVzc2x5IGluY3JlYXNlL2RlY3JlYXNlIGFuIGF0b21pYw0Kd2hpbGUg aG9sZGluZyB0aGUgZ2xvYmFsIGxvY2suDQoNCjMuIEFzIGFsbCB3b3JrIHdpdGggUENJIGRldmlj ZXMgaXMgZG9uZSB3aGlsZSBob2xkaW5nIHRoZSBsb2NrLCB3ZSBjYW4NCmFzc2VydCB0aGF0IHJl ZmVyZW5jZSBjb3VudCBhdCB0aGUgYmVnaW5uaW5nIG9mIGEgY3JpdGljYWwgc2VjdGlvbiB3aWxs DQpiZSBlcXVhbCB0byByZWZlcmVuY2UgY291bnQgYXQgdGhlIGVuZCBvZiBhIGNyaXRpY2FsIHNl Y3Rpb24sIGJlY2F1c2UNCm15IHBhdGNoIGFkZCBfcHV0IHRvIHRoZSBldmVyeSBfZ2V0IGFsbCBh Y3Jvc3MgdGhlIGh5cGVydmlzb3IsIHdpdGggYQ0KZmV3IG5vdGFibGUgZXhjZXB0aW9uczoNCg0K My4xLiBwY2lfYWRkX2RldmljZSgpIHdpbGwgaW5pdGlhbGl6ZSBhIGRldmljZSBhbmQgc2V0IHJl ZmVyZW5jZSBjb3VudA0KdG8gMQ0KDQozLjIuIHBjaV9yZW1vdmVfZGV2aWNlKCkgd2lsbCBkZS1p bml0aWFsaXplIGEgZGV2aWNlIGFuZCBkZWNyZWFzZQ0KcmVmZXJlbmNlIGNvdW50IGJ5IDEuIEkg Y2FuIGFzc2VydCwgdGhhdCBpZiBwLjEgaXMgdHJ1ZSBhbmQgSSBkaWRuJ3QNCm1lc3NlZCB1cCB3 aXRoIGJhbGFuY2luZyBfZ2V0cy9fcHV0cyBpbiBvdGhlciBwYXJ0cyBvZiB0aGUgY29kZSwgdGhl bg0KcGNpX3JlbW92ZV9kZXZpY2UoKSB3aWxsIGFsd2F5cyByZW1vdmUgdGhlIGxhc3QgcmVmZXJl bmNlLiBUaGlzIG1heSAoYW5kDQp3aWxsKSBjaGFuZ2UgaW4gdGhlIGZ1dHVyZS4NCg0KMy4zLiBN U0kgY29kZSBob2xkcyBsb25nLXRlcm0gcG9pbnRlcnMgdG8gcGRldiwgc28NCm1zaVt4XV9jYXBh YmlsaXR5X2luaXQoKSBkb2VzIGFkZGl0aW9uYWwgX2dldCgpIGFuZCB0aGVuDQpgbXNpX2ZyZWVf aXJxKClgIGRvZXMgY29ycmVzcG9uZGluZyBfcHV0KCkuIEx1Y2tpbHkgZm9yIHVzLA0KcGNpX3Jl bW92ZV9kZXZpY2UoKSBjYWxscyBwY2lfY2xlYW51cF9tc2koKSBzbyB3ZSBjYW4gYmUgc3VyZSB0 aGF0IGRvZXMNCm5vdCBicmVhayBhc3NlcnRpb24gaW4gcC4zLjINCg0KNC4gTm93LCB3ZSB3YW50 IHZQQ0kgY29kZSB0byBiZSBhYmxlIHRvIGFjY2VzcyBQQ0kgZGV2aWNlcyB3aXRob3V0DQpob2xk aW5nIHRoZSBnbG9iYWwgUENJIGxvY2sgdGhlIHdob2xlIHRpbWUuIFRoaXMgaXMgd2hlcmUgd2Ug Y2FuDQpsZXZlcmFnZSByZWZlcmVuY2UgY291bnRpbmcuIEhlcmUgYXJlIHRoZSBhc3NlcnRpb25z Og0KDQo0LjEuIHZQQ0kgY29kZSBnZXRzIHBkZXYgcG9pbnRlciBvbmx5IHZpYSBwY2lfZ2V0X3Bk ZXYoKSBmdW5jdGlvbiwgd2hpY2gNCnJlYWRzIGZyb20gYSBsaXN0IHdoaWxlIGhvbGRpbmcgdGhl IGdsb2JhbCBQQ0kgbG9jay4gVGhhdCBtZWFucyB0aGF0DQpwY2lfZ2V0X3BkZXYoKSB3aWxsIHJl dHVybiBOVUxMIGFmdGVyIHBjaV9yZW1vdmVfZGV2aWNlKCkgZGVsZXRlcyB0aGUNCmRldmljZSBm cm9tIGFsbCBsaXN0cy4gQWxzbywgdGhhdCBtZWFucyB0aGF0IHZQQ0kgY29kZSBjYW4ndCBnZXQg cGRldg0Kd2hpbGUgcGNpX3JlbW92ZV9kZXZpY2UoKSBpcyBydW5uaW5nLCBiZWNhdXNlIHBjaV9y ZW1vdmVfZGV2aWNlKCkgaXMNCmhvbGRpbmcgdGhlIGdsb2JhbCBQQ0kgbG9jay4NCg0KNC4yLiB2 UENJIGNvZGUgd2lsbCBhbHdheXMgYWNxdWlyZSBwZGV2LT52cGNpX2xvY2sgYmVmb3JlIGFjY2Vz c2luZw0KcGRldi0+dnBjaQ0KDQo0LjMuIHBjaV9yZW1vdmVfZGV2aWNlKCkgd2lsbCBkZS1pbml0 IHZwY2kgc3RhdGUgd2hpbGUgaG9sZGluZw0KcGRldi0+dnBjaV9sb2NrDQoNCjQuNC4gdlBDSSBj b2RlIHdpbGwgbm90IHRyeSB0byBhY2Nlc3MgUENJIGRldmljZSBpZiBwZGV2LT52cGNpID09IE5V TEwNCg0KNC41LiB2UENJIGNvZGUgd2lsbCBhY2Nlc3Mgb25seSB2cGNpLXJlbGF0ZWQgZmllbGRz IGluIHN0cnVjdCBwZGV2DQoNCjQuNi4gdlBDSSBkb2VzIG5vdCBkZXBlbmRzIGFuZCBkb2VzIG5v dCBhbHRlciBub24tdlBDSS1yZWxhdGVkIHN0YXRlIG9mIGEgUENJDQpkZXZpY2UuIFRoaXMgaXMg dGhlIG1vc3QgdHJpY2t5IHBhcnQsIGJlY2F1c2UgbW9zdCBvZiB0aGUgcmVtYWluaW5nIHN0YXRl IGlzDQpwcm90ZWN0ZWQgYnkgdGhlIGdsb2JhbCBQQ0kgbG9jaywgd2hpY2ggd2UgYXJlIG5vdCBo b2xkaW5nLiBUaGF0IG1lYW5zLA0KdGhhdCB3ZSBuZWVkIHRvIGRpc2FibGUgdlBDSSB3aGlsZSBy ZS1hc3NpZ25pbmcgdGhlIFBDSSBkZXZpY2UgdG8NCmFub3RoZXIgZG9tYWluLiBBcyBJIGNhbiBz ZWUsIHRoaXMgaXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgdlBDSSBkZXBlbmRzDQpvbiBtb3JlIGJy b2FkZXIgUENJIGRldmljZSBzdGF0ZS4NCg0KVGhpcyBhcHByb2FjaCB3aWxsIG5vdCBpbnRlcmZl cmUgd2l0aCBwY2lfcmVtb3ZlX2RldmljZSgpIG9ibGlnYXRpb25zLA0KYmVjYXVzZSB3ZSBjYW4g YmUgc3VyZSB0aGF0IHJpZ2h0IG5vdyB2UENJIGlzIHRoZSBvbmx5IHVzZXIgdGhhdCBjYW4NCmhv bGQgcmVmZXJlbmNlIGNvdW50ZXIgcGFzdCBwY2lfcmVtb3ZlX2RldmljZSgpIGNhbGwgYW5kIHRo YXQgdlBDSSBjb2RlDQp3aWxsIG5vdCBhdHRlbXB0IHRvIGFjY2VzcyB0byBQQ0kgZGV2aWNlIGFm dGVyIGVuZCBvZiAsIHRodXMsIGFsbG93aW5nIGFkbWluIHRvDQpwaHlzaWNhbGx5IHJlbW90ZSB0 aGUgZGV2aWNlLg0KDQpJbiB0aGUgZnV0dXJlLCB3ZSBjYW4gZ3JhZHVhbGx5IHJlbW92ZSBvdGhl ciBwYXJ0cyBvZiB0aGUgUENJIGNvZGUgZnJvbSB1bmRlcg0KdGhlIGdsb2JhbCBQQ0kgbG9jaywg cHJvdmlkaW5nIHdlIGNhbiBnaXZlIHRoZSBzYW1lIGd1YXJhbnRlZXMgYXMgcCA0LjEtNC42DQoN Cj4+ID4+ID4+IC1zdGF0aWMgaW50IGFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2 IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgdTMyIGZsYWcpDQo+PiA+PiA+PiArc3RhdGljIGludCBh c3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1MzIg ZmxhZykNCj4+ID4+ID4+ICB7DQo+PiA+PiA+PiAgICAgIGNvbnN0IHN0cnVjdCBkb21haW5faW9t bXUgKmhkID0gZG9tX2lvbW11KGQpOw0KPj4gPj4gPj4gLSAgICBzdHJ1Y3QgcGNpX2RldiAqcGRl djsNCj4+ID4+ID4+ICsgICAgdWludDhfdCBkZXZmbjsNCj4+ID4+ID4+ICAgICAgaW50IHJjID0g MDsNCj4+ID4+ID4+ICANCj4+ID4+ID4+ICAgICAgaWYgKCAhaXNfaW9tbXVfZW5hYmxlZChkKSAp DQo+PiA+PiA+PiBAQCAtMTQyMiwxMCArMTQxMiwxMSBAQCBzdGF0aWMgaW50IGFzc2lnbl9kZXZp Y2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgdTMyIGZsYWcp DQo+PiA+PiA+PiAgDQo+PiA+PiA+PiAgICAgIC8qIGRldmljZV9hc3NpZ25lZCgpIHNob3VsZCBh bHJlYWR5IGhhdmUgY2xlYXJlZCB0aGUgZGV2aWNlIGZvciBhc3NpZ25tZW50ICovDQo+PiA+PiA+ PiAgICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsNCj4+ID4+ID4+IC0gICAgcGRldiA9IHBj aV9nZXRfcGRldihOVUxMLCBQQ0lfU0JERihzZWcsIGJ1cywgZGV2Zm4pKTsNCj4+ID4+ID4+ICAg ICAgQVNTRVJUKHBkZXYgJiYgKHBkZXYtPmRvbWFpbiA9PSBoYXJkd2FyZV9kb21haW4gfHwNCj4+ ID4+ID4+ICAgICAgICAgICAgICAgICAgICAgIHBkZXYtPmRvbWFpbiA9PSBkb21faW8pKTsNCj4+ ID4+ID4+ICANCj4+ID4+ID4+ICsgICAgZGV2Zm4gPSBwZGV2LT5kZXZmbjsNCj4+ID4+ID4+ICsN Cj4+ID4+ID4+ICAgICAgLyogRG8gbm90IGFsbG93IGJyb2tlbiBkZXZpY2VzIHRvIGJlIGFzc2ln bmVkIHRvIGd1ZXN0cy4gKi8NCj4+ID4+ID4+ICAgICAgcmMgPSAtRUJBREY7DQo+PiA+PiA+PiAg ICAgIGlmICggcGRldi0+YnJva2VuICYmIGQgIT0gaGFyZHdhcmVfZG9tYWluICYmIGQgIT0gZG9t X2lvICkNCj4+ID4+ID4+IEBAIC0xNDYwLDcgKzE0NTEsNyBAQCBzdGF0aWMgaW50IGFzc2lnbl9k ZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgdTMyIGZs YWcpDQo+PiA+PiA+PiAgIGRvbmU6DQo+PiA+PiA+PiAgICAgIGlmICggcmMgKQ0KPj4gPj4gPj4g ICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5JTkcgIiVwZDogYXNzaWduICglcHApIGZhaWxl ZCAoJWQpXG4iLA0KPj4gPj4gPj4gLSAgICAgICAgICAgICAgIGQsICZQQ0lfU0JERihzZWcsIGJ1 cywgZGV2Zm4pLCByYyk7DQo+PiA+PiA+PiArICAgICAgICAgICAgICAgZCwgJlBDSV9TQkRGKHBk ZXYtPnNlZywgcGRldi0+YnVzLCBkZXZmbiksIHJjKTsNCj4+ID4+ID4+ICAgICAgLyogVGhlIGRl dmljZSBpcyBhc3NpZ25lZCB0byBkb21faW8gc28gbWFyayBpdCBhcyBxdWFyYW50aW5lZCAqLw0K Pj4gPj4gPj4gICAgICBlbHNlIGlmICggZCA9PSBkb21faW8gKQ0KPj4gPj4gPj4gICAgICAgICAg cGRldi0+cXVhcmFudGluZSA9IHRydWU7DQo+PiA+PiA+PiBAQCAtMTU5NSw2ICsxNTg2LDkgQEAg aW50IGlvbW11X2RvX3BjaV9kb21jdGwoDQo+PiA+PiA+PiAgICAgICAgICBBU1NFUlQoZCk7DQo+ PiA+PiA+PiAgICAgICAgICAvKiBmYWxsIHRocm91Z2ggKi8NCj4+ID4+ID4+ICAgICAgY2FzZSBY RU5fRE9NQ1RMX3Rlc3RfYXNzaWduX2RldmljZToNCj4+ID4+ID4+ICsgICAgew0KPj4gPj4gPj4g KyAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiA+PiA+PiArDQo+PiA+PiA+PiAgICAg ICAgICAvKiBEb24ndCBzdXBwb3J0IHNlbGYtYXNzaWdubWVudCBvZiBkZXZpY2VzLiAqLw0KPj4g Pj4gPj4gICAgICAgICAgaWYgKCBkID09IGN1cnJlbnQtPmRvbWFpbiApDQo+PiA+PiA+PiAgICAg ICAgICB7DQo+PiA+PiA+PiBAQCAtMTYyMiwyNiArMTYxNiwzNiBAQCBpbnQgaW9tbXVfZG9fcGNp X2RvbWN0bCgNCj4+ID4+ID4+ICAgICAgICAgIHNlZyA9IG1hY2hpbmVfc2JkZiA+PiAxNjsNCj4+ ID4+ID4+ICAgICAgICAgIGJ1cyA9IFBDSV9CVVMobWFjaGluZV9zYmRmKTsNCj4+ID4+ID4+ICAg ICAgICAgIGRldmZuID0gUENJX0RFVkZOKG1hY2hpbmVfc2JkZik7DQo+PiA+PiA+PiAtDQo+PiA+ PiA+PiAgICAgICAgICBwY2lkZXZzX2xvY2soKTsNCj4+ID4+ID4+IC0gICAgICAgIHJldCA9IGRl dmljZV9hc3NpZ25lZChzZWcsIGJ1cywgZGV2Zm4pOw0KPj4gPj4gPj4gKyAgICAgICAgcGRldiA9 IHBjaV9nZXRfcGRldihOVUxMLCBQQ0lfU0JERihzZWcsIGJ1cywgZGV2Zm4pKTsNCj4+ID4+ID4+ ICsgICAgICAgIGlmICggIXBkZXYgKQ0KPj4gPj4gPj4gKyAgICAgICAgew0KPj4gPj4gPj4gKyAg ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19JTkZPICIlcHAgbm9uLWV4aXN0ZW50XG4iLA0KPj4g Pj4gPj4gKyAgICAgICAgICAgICAgICAgICAmUENJX1NCREYoc2VnLCBidXMsIGRldmZuKSk7DQo+ PiA+PiA+PiArICAgICAgICAgICAgcmV0ID0gLUVJTlZBTDsNCj4+ID4+ID4+ICsgICAgICAgICAg ICBicmVhazsNCj4+ID4+ID4+ICsgICAgICAgIH0NCj4+ID4+ID4+ICsNCj4+ID4+ID4+ICsgICAg ICAgIHJldCA9IGRldmljZV9hc3NpZ25lZChwZGV2KTsNCj4+ID4+ID4+ICAgICAgICAgIGlmICgg ZG9tY3RsLT5jbWQgPT0gWEVOX0RPTUNUTF90ZXN0X2Fzc2lnbl9kZXZpY2UgKQ0KPj4gPj4gPj4g ICAgICAgICAgew0KPj4gPj4gPj4gICAgICAgICAgICAgIGlmICggcmV0ICkNCj4+ID4+ID4+ICAg ICAgICAgICAgICB7DQo+PiA+PiA+PiAtICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19J TkZPICIlcHAgYWxyZWFkeSBhc3NpZ25lZCwgb3Igbm9uLWV4aXN0ZW50XG4iLA0KPj4gPj4gPj4g KyAgICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfSU5GTyAiJXBwIGFscmVhZHkgYXNzaWdu ZWRcbiIsDQo+PiA+PiA+PiAgICAgICAgICAgICAgICAgICAgICAgICAmUENJX1NCREYoc2VnLCBi dXMsIGRldmZuKSk7DQo+PiA+PiA+PiAgICAgICAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7DQo+ PiA+PiA+PiAgICAgICAgICAgICAgfQ0KPj4gPj4gPj4gICAgICAgICAgfQ0KPj4gPj4gPj4gICAg ICAgICAgZWxzZSBpZiAoICFyZXQgKQ0KPj4gPj4gPj4gLSAgICAgICAgICAgIHJldCA9IGFzc2ln bl9kZXZpY2UoZCwgc2VnLCBidXMsIGRldmZuLCBmbGFncyk7DQo+PiA+PiA+PiArICAgICAgICAg ICAgcmV0ID0gYXNzaWduX2RldmljZShkLCBwZGV2LCBmbGFncyk7DQo+PiA+PiA+PiArDQo+PiA+ PiA+PiArICAgICAgICBwY2lkZXZfcHV0KHBkZXYpOw0KPj4gPj4gPg0KPj4gPj4gPiBJIHdvdWxk IHRoaW5rIHlvdSBuZWVkIHRvIGtlZXAgdGhlIHJlZmNvdW50IGhlcmUgaWYgcmV0ID09IDAsIHNv IHRoYXQNCj4+ID4+ID4gdGhlIGRldmljZSBjYW5ub3QgYmUgcmVtb3ZlZCB3aGlsZSBhc3NpZ25l ZCB0byBhIGRvbWFpbj8NCj4+ID4+IA0KPj4gPj4gTG9va3MgbGlrZSB3ZSBhcmUgcGVyY2Vpdmlu ZyBmdW5jdGlvbiBvZiByZWZjbnQgaW4gYSBkaWZmZXJlbnQNCj4+ID4+IHdheXMuIEZvciBtZSwg dGhpcyBpcyB0aGUgbWVjaGFuaXNtIHRvIGd1YXJhbnRlZSB0aGF0IGlmIHdlIGhhdmUgYSB2YWxp ZA0KPj4gPj4gcG9pbnRlciB0byBhbiBvYmplY3QsIHRoaXMgb2JqZWN0IHdpbGwgbm90IGRpc2Fw cGVhciB1bmRlciBvdXINCj4+ID4+IGZlZXQuIFRoaXMgaXMgdGhlIG1haW4gZnVuY3Rpb24gb2Yg a3JlZnMgaW4gdGhlIGxpbnV4IGtlcm5lbDogaWYgeW91cg0KPj4gPj4gY29kZSBob2xkcyBhIHJl ZmVyZW5jZSB0byBhbiBvYmplY3QsIHlvdSBjYW4gYmUgc3VyZSB0aGF0IHRoaXMgb2JqZWN0IGlz DQo+PiA+PiBleGlzdHMgaW4gbWVtb3J5Lg0KPj4gPj4gDQo+PiA+PiBPbiBvdGhlciBoYW5kLCBp dCBzZWVtcyB0aGF0IHlvdSBhcmUgY29uc2lkZXJpbmcgdGhpcyByZWZjbnQgYXMgYW4gdXNhZ2UN Cj4+ID4+IGNvdW50ZXIgZm9yIGFuIGFjdHVhbCBQQ0kgZGV2aWNlLCBub3QgInN0cnVjdCBwZGV2 IiB0aGF0IHJlcHJlc2VudA0KPj4gPj4gaXQuIFRob3NlIGFyZSB0d28gcmVsYXRlZCB0aGluZ3Ms IGJ1dCBub3QgdGhlIHNhbWUuIFNvLCBJIGNhbiBzZWUgd2h5DQo+PiA+PiB5b3UgYXJlIHN1Z2dl c3RpbmcgdG8gZ2V0IGFkZGl0aW9uYWwgcmVmZXJlbmNlIHRoZXJlLiBCdXQgZm9yIG1lLCB0aGlz DQo+PiA+PiBsb29rcyB1bm5lY2Vzc2FyeTogdGhlIHZlcnkgZmlyc3QgcmVmY291bnQgaXMgb2J0 YWluZWQgaW4NCj4+ID4+IHBjaV9hZGRfZGV2aWNlKCkgYW5kIHRoZXJlIGlzIHRoZSBjb3JyZXNw b25kaW5nIGZ1bmN0aW9uDQo+PiA+PiBwY2lfcmVtb3ZlX2RldmljZSgpIHRoYXQgd2lsbCBkcm9w IHRoaXMgcmVmY291bnQuIFNvLCBmb3IgbWUsIGlmIGFkbWluDQo+PiA+PiB3YW50cyB0byByZW1v dmUgYSBQQ0kgZGV2aWNlIHdoaWNoIGlzIGFzc2lnbmVkIHRvIGEgZG9tYWluLCB0aGV5IGNhbiBk bw0KPj4gPj4gdGhpcyBhcyB0aGV5IHdlcmUgYWJsZSB0byBkbyB0aGlzIHByaW9yIHRoaXMgcGF0 Y2hlcy4NCj4+ID4NCj4+ID4gVGhpcyBpcyBhbGwgZmluZSwgYnV0IG5lZWRzIHRvIGJlIHN0YXRl ZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+PiA+DQo+PiANCj4+IFN1cmUsIEkgd2lsbCBhZGQg dGhpcy4NCj4+IA0KPj4gPj4gVGhlIG1haW4gdmFsdWUgb2YgaW50cm9kdWNpbmcgcmVmY250IGlz IHRvIGJlIGFibGUgdG8gYWNjZXNzIHBkZXYgb2JqZWN0cw0KPj4gPj4gd2l0aG91dCBob2xkaW5n IHRoZSBnbG9iYWwgcGNpZGV2c19sb2NrKCkuIFRoaXMgZG9lcyBub3QgbWVhbiB0aGF0IHlvdQ0K Pj4gPj4gZG9uJ3QgbmVlZCBsb2NraW5nIGF0IGFsbC4gQnV0IHRoaXMgYWxsb3dzIHlvdSB0byB1 c2UgcGRldi0+bG9jayAod2hpY2gNCj4+ID4+IGRvZXMgbm90IGV4aXN0cyBpbiB0aGlzIHNlcmll cywgYnV0IHdhcyBpbnRyb2R1Y2VkIGluIGEgUkZDIGVhcmxpZXIpLCBvcg0KPj4gPj4gdnBjaS0+ bG9jaywgb3IgYW55IG90aGVyIHN1YnN5c3RlbS0+bG9jay4NCj4+ID4NCj4+ID4gSSBndWVzcyBJ IHdhcyBtaXNzaW5nIHRoaXMgb3RoZXIgYml0IGFib3V0IGludHJvZHVjaW5nIGENCj4+ID4gcGVy LWRldmljZSBsb2NrLCB3b3VsZCBpdCBiZSBwb3NzaWJsZSB0byBidW5kbGUgYWxsIHRoaXMgdG9n ZXRoZXIgaW50bw0KPj4gPiBhIHNpbmdsZSBwYXRjaCBzZXJpZXM/DQo+PiANCj4+IEFzIEkgc2Fp ZCBhdCB0aGUgdG9wIG9mIHRoaXMgZW1haWwsIGl0IHdhcyB0cmllZC4gWW91IGNhbiBjaGVjayBS RkMgYXQgWzFdLg0KPj4gDQo+PiA+DQo+PiA+IEl0IHdvdWxkIGJlIGdvb2QgdG8gcGxhY2UgdGhp cyBjaGFuZ2UgdG9nZXRoZXIgd2l0aCBhbnkgb3RoZXIgbG9ja2luZw0KPj4gPiByZWxhdGVkIGNo YW5nZSB0aGF0IHlvdSBoYXZlIHBlbmRpbmcuDQo+PiANCj4+IEhvbmVzdGx5LCBteSBtYWluIGdv YWwgaXMgdG8gZml4IHRoZSBjdXJyZW50IGlzc3VlcyB3aXRoIHZQQ0ksIHNvIEFSTQ0KPj4gY2Fu IG1vdmUgZm9yd2FyZCBvbiBhZGRpbmcgUENJIHN1cHBvcnQgZm9yIHRoZSBwbGF0Zm9ybS4gU28s IEkgYW0NCj4+IGZvY3VzaW5nIG9uIHRoaXMgcmlnaHQgbm93Lg0KPg0KPiBUaGFua3MsIHdlIG5l ZWQgdG8gYmUgY2FyZWZ1bCBob3dldmVyIGFzIHRvIG5vdCBhY2N1bXVsYXRlIG1vcmUNCj4gYmFu ZGFpZHMgb24gdG9wIGp1c3QgdG8gd29ya2Fyb3VuZCB0aGUgZmFjdCB0aGF0IHRoZSBsb2NraW5n IHdlIGhhdmUNCj4gcmVnYXJkaW5nIHRoZSBwY2kgZGV2aWNlcyBpcyBub3Qgc3VpdGFibGUuDQo+ DQo+IEkgdGhpbmsgaXQncyBpbXBvcnRhbnQgdG8ga2VlcCBhbGwgdGhlIHVzYWdlcyBvZiB0aGUg cGNpX2RldiBzdHJ1Y3QgaW4NCj4gbWluZCB3aGVuIGRlc2lnbmluZyBhIHNvbHV0aW9uLg0KPg0K PiBPdmVyYWxsIGl0IHNlZW1zIGxpa2UgbWlnaHQgaGVscCB2UENJIG9uIEFybSwgSSB0aGluayB0 aGUgb25seSBtYWpvcg0KPiByZXF1ZXN0IEkgaGF2ZSBpcyB0aGUgb25lIHJlbGF0ZWQgdG8gcGNp X3JlbW92ZV9kZXZpY2UoKSBvbmx5DQo+IHJldHVybmluZyBzdWNjZXNzIHdoZW4gdGhlcmUgYXJl IG5vdCByZWZjb3VudHMgbGVmdC4NCg0KQWJvdmUgSSBoYXZlIHByb3Bvc2VkIGFub3RoZXIgdmll dyBvbiB0aGlzLiBJIGhvcGUsIGl0IHdpbGwgd29yayBmb3INCnlvdS4gSnVzdCB0byByZWl0ZXJh dGUsIGlkZWEgaXMgdG8gYWxsb3cgImhhcm1sZXNzIiByZWZjb3VudHMgdG8gYmUgbGVmdA0KYWZ0 ZXIgcmV0dXJuaW5nIGZyb20gcGNpX3JlbW92ZV9kZXZpY2UoKS4gQnkgImhhcm1sZXNzIiBJIG1l YW4gdGhhdA0Kb3duZXJzIG9mIHRob3NlIHJlZmNvdW50cyB3aWxsIG5vdCB0cnkgdG8gYWNjZXNz IHRoZSBwaHlzaWNhbCBQQ0kNCmRldmljZSBpZiBwY2lfcmVtb3ZlX2RldmljZSgpIGlzIGFscmVh ZHkgZmluaXNoZWQuDQoNCi0tIA0KV0JSLCBWb2xvZHlteXINCg== From xen-devel-bounces@lists.xenproject.org Fri Apr 14 01:51:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 01:51:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521009.809236 (Exim 4.92) (envelope-from ) id 1pn8an-0006gA-IJ; Fri, 14 Apr 2023 01:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521009.809236; Fri, 14 Apr 2023 01:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn8an-0006g3-DR; Fri, 14 Apr 2023 01:51:13 +0000 Received: by outflank-mailman (input) for mailman id 521009; Fri, 14 Apr 2023 01:51:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn8al-0006fx-Qm for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 01:51:11 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062b.outbound.protection.outlook.com [2a01:111:f400:fe1f::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2d5f50b-da66-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 03:51:08 +0200 (CEST) Received: from DU2PR04CA0263.eurprd04.prod.outlook.com (2603:10a6:10:28e::28) by AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 01:51:05 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::7c) by DU2PR04CA0263.outlook.office365.com (2603:10a6:10:28e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 01:51:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Fri, 14 Apr 2023 01:51:04 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Fri, 14 Apr 2023 01:51:04 +0000 Received: from e074ea808b3c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 00F90D79-7CBD-4E3E-8915-4F29574BB6D5.1; Fri, 14 Apr 2023 01:50:58 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e074ea808b3c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 01:50:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB6354.eurprd08.prod.outlook.com (2603:10a6:20b:367::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 01:50:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 01:50:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2d5f50b-da66-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/0dmwobpMlHVyKGJ4RopLZFrcAb9z2gbFSUg5A+kZq8=; b=r8XzEUjpKvQ2Sr5adC968nFD6E+vElDdc+fQJ8uXuVdDWAobTI5TpDRXvwZtzQb3QdsSMkLTZW/VsBIfyn4zYlVlFX7Q3ijO/eGfPiiu2zyj9L9TVnrfJT1S6Iw/OmjJ0cTXN7x0H3TVOER+1fdax6jRaDYRcfA7RTA8hjnIaCE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KxAxwgyYdWGjNAr/KqvArb3R/HiCqL3tqQu9U05MsJt9qALETe8epFwUcWY8c+B8jgMjhCLBeEHHBc5llxreKsTolKBavWGl/fYGZqEX72ZcOjVjUHEaLG0IQ46hO/67zL7ZDnaI27+OuxTRGIJnbQ+2RC32lF1Do8sB9d5CbhpKe6s0gz0B276zrKim4O342ufjOReRV6pH5Y6P3i8bZE/bfewXCf/Y01muSYcvZSHQKiKObY7Im2eie8kKlpXEm1ajkbcFFric650wStVAxBdpy7ShRlqLnS4YvTOAkfR0LRnmnhbI4NvKVB7xjq5Jge1W0AK6oEc9qLxHwzNbTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/0dmwobpMlHVyKGJ4RopLZFrcAb9z2gbFSUg5A+kZq8=; b=EeUPKXccVowS5jzkRYbk3M9MfqdAslyt9LThgi+qV4X620mPzP7xRp34U96FB67zPjd7ruTv8U0ISO1g2FRpU9bhCmXZIxpr9qJjkgxkh29EbFU7aW/KKkgXaVqf0lyjrcBaE5oC8wqH7eVD9jMTALfpE0AKYdNiO1Pys2pOAX4s6pXjoTEWMp7CThfVCj0GC/P0B/VgbK8skrN01jffub/UfHvcFU1E64irLP5u9cqcSLL14F6eWB5I6xOmfxvfCfQBwTH87955gwxZY3vOh6QJOlHSdhKdVflMwmfV1RGaAOGLFWdtsjvdZ+bdlU4gbeERKpphsO1r56pjOOAafg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/0dmwobpMlHVyKGJ4RopLZFrcAb9z2gbFSUg5A+kZq8=; b=r8XzEUjpKvQ2Sr5adC968nFD6E+vElDdc+fQJ8uXuVdDWAobTI5TpDRXvwZtzQb3QdsSMkLTZW/VsBIfyn4zYlVlFX7Q3ijO/eGfPiiu2zyj9L9TVnrfJT1S6Iw/OmjJ0cTXN7x0H3TVOER+1fdax6jRaDYRcfA7RTA8hjnIaCE= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Thread-Topic: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Thread-Index: AQHZbKpEgTyA0CRuYk66qjVY5D36Ua8qDYcw Date: Fri, 14 Apr 2023 01:50:45 +0000 Message-ID: References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-12-vikram.garhwal@amd.com> In-Reply-To: <20230411191636.26926-12-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EEFA672FD9D738488657FB1F1191A2F1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM8PR08MB6354:EE_|DBAEUR03FT053:EE_|AS8PR08MB7696:EE_ X-MS-Office365-Filtering-Correlation-Id: a1a62ec8-2f7b-481d-eb8f-08db3c8ab52f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: r2pNb9kKRMlXcx4lHZNIvkjviZLLOZ2UhOJqSEpqybuXStSDdXie8QZtPTKiP1jUv5S43gjmLATGzo6B15JXBD/1DPgOu/nNGs3cANafe7eet7xtM8xBAPzIjLphNpfCNm7cGUJVbb7APmG5vapUuGZOs3m5InLqpOLtlbMF/KmQrKGSemnlLhoGph3VVbkTNjLNB4HuxnXyADAyaqao/mPWoAgjibP5jZsyMTeU7+/9zq9rL4y6XAKHU/4slUZ/bi7iyO+I7U377Vd9Ya0cxywxWFlzy/fIBtnOsAZg5E5Px93p9hNf5NDT4i8zgdg9M3I/jCUOMmu7yRSg0lUhBKsC5I4//Y+GNeISvzSVqJwfn00F40Z3/kcupuHolJdrClFz6YQQ3KwNuhR4zBs8jtWrw5N8v8eE/BYBvENPSdWZUrdyjnX3TGIFZ7n/dUSfqrVgP2GI5ZGrEVzv1fENRL2kDf7UqPvcqDaCCofWOdVL15pNH2yOrXxpG/WVTpV27G0mejqDE6hZdEE9VkKI5yIdQ3Vxr3rhQKI3lcbrhLAqZa9NkvMhKrXWTwRTtJNrKYDMlk3/hHoD3LNMZkO4Bw1sLvluHmxBaVFeMydJHbPl0OK+PLkHi/zOa7OW8F0d X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(451199021)(33656002)(55016003)(478600001)(54906003)(110136005)(7696005)(71200400001)(122000001)(41300700001)(8676002)(8936002)(38100700002)(66556008)(66946007)(316002)(66476007)(4326008)(64756008)(66446008)(83380400001)(76116006)(9686003)(6506007)(26005)(186003)(86362001)(52536014)(4744005)(2906002)(38070700005)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6354 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3d949f1d-fa86-400a-e77e-08db3c8aa9e6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXV+i+wy95Mjja1m1HgSYJf0R+hQSAvvPZh/QP/GHg1rvbMfoCEVG/rAL4TRmyD5R/vwekMgpi+ylCZZkd0dz0cKiav5si3URuvHeq0B87i42KSUOABFYHSBSPqkgPupNX9Zi6yqLLhzsU8oKTY2xPiHzXF7ateoFUZL7/8rH/gUU4CKAbtNKUMnmbBgFS5L5F3aoDLJI7E1pF7cjlurs26Iq+gyZHa5j8wMrfTmFyDnygfZa6v2X1U5RpUBIDtDa3XJupri2G856CPuc5wejS1hpSjUzMWgUl6lvXgTMdvAqczLNMdXhOBE2VIaT2i3UMiHk75pACMd2sTQwkqZlwYSbI1V0xEFOWfdh2kqCXlVn6q8SckIhQPwpInBHkE/PNF5Hiz2KQxToD8O25m+CP8dJBj4RYs6j26rdpqn5QF+BHoMOXxbJa1xZL3gq61ZdSyepTOnG5N1FXLOyh5Sq6ErpWN7/Fdk66WPEBEwmae+taeDKzkNDxkoww9aevYUvaul1lgMJbYarVIVulrJHXmDgxIMgPgVDfbpWyYaQiM1Cf5Lw+k7mItWs+5vAtmCHsNisQwauB0OZUOTbvsHaNh1KGxtVoHiNkzdBWdNtuxWoUIvsMDIVQRSxMBKbLrc+v9JsxkeZABqax6SKLqYdFL48ld8JGHCanfCcdLMacEBItqxiB67y6+Vd7Q+5WscQ9pyU73RnpA6DMWghtvFKw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199021)(46966006)(40470700004)(36840700001)(33656002)(40460700003)(316002)(41300700001)(9686003)(26005)(81166007)(6506007)(7696005)(186003)(86362001)(47076005)(107886003)(356005)(82310400005)(36860700001)(336012)(83380400001)(82740400003)(55016003)(40480700001)(110136005)(4326008)(54906003)(70586007)(8676002)(70206006)(8936002)(5660300002)(2906002)(4744005)(52536014)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 01:51:04.6027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1a62ec8-2f7b-481d-eb8f-08db3c8ab52f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7696 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for > device_tree.h and rwlock.h >=20 > Dynamic programming ops will modify the dt_host and there might be other > function which are browsing the dt_host at the same time. To avoid the ra= ce > conditions, adding rwlock for browsing the dt_host. But adding rwlock in > device_tree.h causes following circular dependency: > device_tree.h->rwlock.h->smp.h->asm/smp.h->device_tree.h >=20 > To fix this, removed the "#include and forward declar= ed > "struct dt_device_node". >=20 > Signed-off-by: Vikram Garhwal Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 02:09:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 02:09:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521013.809246 (Exim 4.92) (envelope-from ) id 1pn8sm-0000CD-26; Fri, 14 Apr 2023 02:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521013.809246; Fri, 14 Apr 2023 02:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn8sl-0000C6-V9; Fri, 14 Apr 2023 02:09:47 +0000 Received: by outflank-mailman (input) for mailman id 521013; Fri, 14 Apr 2023 02:09:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pn8sl-0000C0-7z for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 02:09:47 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0605.outbound.protection.outlook.com [2a01:111:f400:fe02::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c1d9db4-da69-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 04:09:44 +0200 (CEST) Received: from FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) by PAXPR08MB7599.eurprd08.prod.outlook.com (2603:10a6:102:23e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.46; Fri, 14 Apr 2023 02:09:42 +0000 Received: from VI1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4a:cafe::df) by FR3P281CA0038.outlook.office365.com (2603:10a6:d10:4a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.7 via Frontend Transport; Fri, 14 Apr 2023 02:09:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT056.mail.protection.outlook.com (100.127.144.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.32 via Frontend Transport; Fri, 14 Apr 2023 02:09:40 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Fri, 14 Apr 2023 02:09:40 +0000 Received: from 84de44484703.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 734486FC-61CF-4B57-B731-BE6F4D2464D7.1; Fri, 14 Apr 2023 02:09:34 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 84de44484703.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 02:09:34 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB5520.eurprd08.prod.outlook.com (2603:10a6:803:135::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Fri, 14 Apr 2023 02:09:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 02:09:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c1d9db4-da69-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7K66/NOBOzweoXpUKEC2T8xfXCJQM7bOv4DduEzKc9A=; b=dk/6pKjfJxDt7qRUG2kkSolCHVRlhsjYKxyYVspZ8GNGdoGgwtoGQbMys9fYd7RLUvnxnCOii0gT4eclf1n24RrY8m7e5dBsElm7DE6Rybb4V2PGj56Kfhq3laS8mVqyrPxcZ9CaFjx3qSFeP1TxjNXgzHgc3SC3vDs8NWACr4g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fy1E6sTz9XEvrZFc/HlkUjpT0IkQ5wPFlzUlmVlPOkdPVYr/+/0w+uEFkRNF8/bNXzGRZMkzZ0bbt9VG9mk4meb1ZEUnjqLtAUM/C9+WplE3Xpy7H4Ff04hiVg4XJ4PyBjuoMQe6MfGNPPM2IPkhLaWjKHq5wdfTUiyHU0eFf1q5KiEQrrsQgCTBGNb7IEgAcgjSuBMB6WCVn4mtnxt6pY0gkJ7yodyu2e4qZHoRHUOnmLS39N9AtvQM2KF83fyQbSdAiC1TZMYTKjv38x0DjFoN7YFUOMYnQvKdUEFFOw6OkeDLDBrW3//w2lT9gZJ5VTxZSAy09rJYqkjSbov7UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7K66/NOBOzweoXpUKEC2T8xfXCJQM7bOv4DduEzKc9A=; b=aiwpKwOoUJY5nvmd+cqsD6r9woTfjRS8PZWmLubz6nm0BfYXUvPXFM0dofTzyirqD5TF6P52+vKqO1eOiOwfJGVQQ5tam6iH0wa+/yFpGPtlzdRSN0Xxb5i1929jo0RDUUM/fXJfBIKCdcVVn7DphM3ZF2ZPezajofQx9rQmTTdjTWGzeVhBxqr19VnQR8lCL6gWNDcafHnre7pekT+PLPRTYZR2SSxFn/jeXYb6C4UFilki7KlgUgtpZVIogiJ9xE1ZVY0tyW8ZVHUn4VhUvuIGSKLU61QPQEPM5LeHiNkaFBe9yZXvK7UEMJrt1iitHlYg3eZfP1SUMuW19NQkwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7K66/NOBOzweoXpUKEC2T8xfXCJQM7bOv4DduEzKc9A=; b=dk/6pKjfJxDt7qRUG2kkSolCHVRlhsjYKxyYVspZ8GNGdoGgwtoGQbMys9fYd7RLUvnxnCOii0gT4eclf1n24RrY8m7e5dBsElm7DE6Rybb4V2PGj56Kfhq3laS8mVqyrPxcZ9CaFjx3qSFeP1TxjNXgzHgc3SC3vDs8NWACr4g= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , Julien Grall Subject: RE: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Thread-Topic: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Thread-Index: AQHZbKpCBmKbFexulkCLTCM8AA6Zz68qDq7Q Date: Fri, 14 Apr 2023 02:09:30 +0000 Message-ID: References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-13-vikram.garhwal@amd.com> In-Reply-To: <20230411191636.26926-13-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CE209F4D9041C34993750FB80751A88B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VI1PR08MB5520:EE_|VI1EUR03FT056:EE_|PAXPR08MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 645e1be3-bc12-46c2-412b-08db3c8d4e9a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8//2IIWN6YZLqD9LMG3rU8d9L666/PPPmTIyqKZwNETnQy9M+z3Njnqpdo7+O+MGde9effTC2qa1bUe8zSUOQ2BBdVUsc+9/gbCXHJbJcKXQnr8mPLneGjwKH6xbP8HFFCmgH7xRyQ/I6FXPIncvAT5BC5AriWr/Th/1n11f9VRuyeGpxrq/rz1Dd7bszb9iFkJ8fVf8MutSDUss/gY/DLCOjAKrVidy5PAPp34nHO8cqRBHTEiUAnu+ZKTb1w5zOqjbiP0s6C9WXXUAR5v8mmjMF/Ryvbb35irIlwkNqDqgEek0IPT8acN9qjdsy5aNr+66n7bXK1mkPPDUHQyuZ98YWhG/WIh9wD3K6r24BYj4g5MCugEJVC0cuOtE5mqtM7WzmGlD5YQeiToyqGmdlXXktjO8Mdf2F+oqmfJ3ClS1MeQoU4ihI7hJ+RduIjE6SUOrKJ+SpkDV3VHJLsONr8LnpEWpiN+CmAyjCBIhkU/If2xj4VHsqkxU01wPRO6klWY+YKr6/hj6tY8y572k8gxyEAOytTO4VGM7tT+0gcgTX/ctn60GNpGUyh9pOEwgs25h59cwWo5ckG67Dd7qTIFkQAPlIDqR8BWtMImFggWz2SWJ/x/LOig/yhlxn9xD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39850400004)(366004)(396003)(136003)(376002)(451199021)(478600001)(71200400001)(7696005)(186003)(66446008)(110136005)(64756008)(26005)(5660300002)(54906003)(6506007)(9686003)(2906002)(316002)(76116006)(4326008)(66476007)(52536014)(66946007)(66556008)(8676002)(8936002)(41300700001)(122000001)(83380400001)(55016003)(38070700005)(38100700002)(86362001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5520 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 497de3b1-0aba-4402-df66-08db3c8d48a5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kQmJYxlkEmrbyNc7F8DKThMXbq0wgv5LW7Cn7koPvnPs/wzGpB7Y/QGPNbtwKMCgs3uGWTG5h5eI3rb+HPOvcRR5e6IFTrr4sIkjhSq3OCRZMD4joiHbLrhXBqDx+S3k5WnA3c9t+TtUxDKADT8nTGlJ0tqmjTe4Y9k/PZp+23nVadfOsXY9oATtbmWBSoZQBcbEpkf3LTlQssl5YPnCQV7cb9rissUWb1QTMs/dUg566y+zerxyVoTrbiIfBzp4FZVDdvUzzA0IoycBUZrAHy7xXeXzsLOiWn7dXLq0LoAoJJ+3qI+cHE+Mf7vgL6rx26JVD08LBiTNcMK78J03BKyuBqfbnl5AiQXj6GHD1P2UQBa6vUeh1Cp6WjQW5umqSV8bBjt6J5Vp8/vsi8whba3ib7d8/5rmcFSva9I+v94Zk2XBajPHDuPy0jORPGggiBEfnmXrSaAflhhSuwV35MimRfeOy5GweBSu6nZAnHNTQgeVnRGdTPqjhh0vg5Y6OaeTuY7oRzyVpKKNevjkkD5CMnZKVlG1ekks0UA0p+5lWJyEsIDVuPmte6+wZAw28sfBkObOJqlPfk5e3wlcs6YGoKhJ0whc3kPwN5IOAJPnrEfQamz5+4zc6Kyt63QFApopwxEN3sTi7NYehlTK1MfAqetqNBRT5+a+rB0YdAazvMrMk5IVlW8smU84D8dq+B65pGpT/BvQo1XRhsMvdw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199021)(36840700001)(46966006)(40470700004)(40460700003)(70206006)(8676002)(70586007)(4326008)(41300700001)(54906003)(7696005)(478600001)(110136005)(316002)(86362001)(33656002)(47076005)(83380400001)(336012)(9686003)(6506007)(26005)(52536014)(5660300002)(2906002)(8936002)(82310400005)(40480700001)(55016003)(82740400003)(356005)(81166007)(186003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 02:09:40.8750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 645e1be3-bc12-46c2-412b-08db3c8d4e9a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7599 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host >=20 > Dynamic programming ops will modify the dt_host and there might be other > function which are browsing the dt_host at the same time. To avoid the r= ace > conditions, adding rwlock for browsing the dt_host during runtime. For clarity, could you please add a little bit more details to explain why = you chose rwlock instead of normal spinlock? >=20 > Signed-off-by: Vikram Garhwal > --- > xen/common/device_tree.c | 3 +++ > xen/drivers/passthrough/device_tree.c | 39 +++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 6 +++++ > 3 files changed, 48 insertions(+) >=20 > if ( ret ) > + { > printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign > \"%s\"" > " to dom%u failed (%d)\n", > dt_node_full_name(dev), d->domain_id, ret); > + } I am not sure if it is necessary to add "{" and "}" here. > + > + read_unlock(&dt_host->lock); > break; >=20 > case XEN_DOMCTL_deassign_device: > @@ -322,25 +345,41 @@ int iommu_do_dt_domctl(struct xen_domctl > *domctl, struct domain *d, > if ( domctl->u.assign_device.flags ) > break; >=20 > + read_lock(&dt_host->lock); > + > ret =3D dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, > domctl->u.assign_device.u.dt.size, > &dev); > if ( ret ) > + { > + read_unlock(&dt_host->lock); I think instead of adding "read_unlock" in every break and return path, you can... > break; > + } >=20 > ret =3D xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev= )); > + > if ( ret ) > + { > + read_unlock(&dt_host->lock); > break; > + } >=20 > if ( d =3D=3D dom_io ) > + { > + read_unlock(&dt_host->lock); > return -EINVAL; ...do something like: ret =3D -EINVAL; break; here, and then add one single "read_unlock" before the "return ret;" in the bottom of the function? > + } >=20 > ret =3D iommu_deassign_dt_device(d, dev); >=20 > if ( ret ) > + { > printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign > \"%s\"" > " to dom%u failed (%d)\n", > dt_node_full_name(dev), d->domain_id, ret); > + } Same here. I am not sure if it is necessary to add "{" and "}". Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 05:32:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 05:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521019.809256 (Exim 4.92) (envelope-from ) id 1pnC2I-0004Cs-D8; Fri, 14 Apr 2023 05:31:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521019.809256; Fri, 14 Apr 2023 05:31:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnC2I-0004Cl-8T; Fri, 14 Apr 2023 05:31:50 +0000 Received: by outflank-mailman (input) for mailman id 521019; Fri, 14 Apr 2023 05:31:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnC2H-0004Cb-AK; Fri, 14 Apr 2023 05:31:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnC2H-0000GB-8Q; Fri, 14 Apr 2023 05:31:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnC2G-000648-KT; Fri, 14 Apr 2023 05:31:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnC2G-0002C0-Jz; Fri, 14 Apr 2023 05:31:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bAHrD2MEs+7v7xaF2/2Gh2LF4X4fcRiqsRMrtFx5RcE=; b=Il6OyxLuL4ZsRTdjiGViKuDp/E NZSTQmfge0GYuV6HhEfcCZDNLmWfigvpyC4AJ44iouosjPpFjwQSTv0DkKBUvdweYVMCX9yztoiFW dlkm4IoYX/3IFgKGO98ZY7emXnW2gntZ07nDsFLEOAqjYE8BHpUqcrg5ITDiOceVF3xM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180238: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=f872a624cbf92de9944483eea7674ef80ced1380 X-Osstest-Versions-That: xen=5ea03c570c8610d4359f8bbf5f093d215344ce3f From: osstest service owner Date: Fri, 14 Apr 2023 05:31:48 +0000 flight 180238 xen-unstable real [real] flight 180254 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180238/ http://logs.test-lab.xenproject.org/osstest/logs/180254/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180254-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 180254-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180211 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180225 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180225 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180225 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180225 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180225 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180225 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180225 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180225 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180225 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen f872a624cbf92de9944483eea7674ef80ced1380 baseline version: xen 5ea03c570c8610d4359f8bbf5f093d215344ce3f Last test of basis 180225 2023-04-13 01:53:23 Z 1 days Testing same since 180238 2023-04-13 14:38:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5ea03c570c..f872a624cb f872a624cbf92de9944483eea7674ef80ced1380 -> master From xen-devel-bounces@lists.xenproject.org Fri Apr 14 07:02:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 07:02:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521027.809270 (Exim 4.92) (envelope-from ) id 1pnDRv-00057d-8O; Fri, 14 Apr 2023 07:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521027.809270; Fri, 14 Apr 2023 07:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnDRv-00057W-5a; Fri, 14 Apr 2023 07:02:23 +0000 Received: by outflank-mailman (input) for mailman id 521027; Fri, 14 Apr 2023 07:02:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnDRt-00057O-Rz for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 07:02:22 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ac5cdcd-da92-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 09:02:17 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id v6so16443537wrv.8 for ; Fri, 14 Apr 2023 00:02:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ac5cdcd-da92-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681455737; x=1684047737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d7E/ybxLrLBiZp41oOMePR1HXiUvoIwxiKTUvhbUPiY=; b=S6kxYek8CginYMAQIc8kiF5qiwsWyuU6g8bQbgntZfAVbGipZMYTJTCOe3lqR9sNJU PCAyVzLmD6yUGzlPDRa7hiUiEklE6aKUfvEWV2g9pxjY/2ynO4kvqOW00odhEA/gezf+ uj6iZb5UOXruIEiGj0+Ojkrezxq4yvU09ioQUa2sjWfRunYPrrAsbNmaYFOXdez2n8n5 zKwILnL1Grllfkqi9Qa9sEGd42MZ8f6uCQiTWPXYyTMeEtHSpucQvxaprz88ei6E9C2u as7E/LoSZkbL9IGbe8RZt1YFcaUSG7T/B880tJZ7IpOBf+4vNsT9G8FijnjVQMXTboP6 72pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681455737; x=1684047737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d7E/ybxLrLBiZp41oOMePR1HXiUvoIwxiKTUvhbUPiY=; b=EVkqX7qwTQgdMeHBsgYsXK7i4p64h85+rR5/8ylZhxZWIIvIivzaByia2FXYGK1ySD N8XyygAJYdwFF0zzlj2Xrado/O9EfhgZO4XeudL8+seOBhE14Snw14WXRlnU/1eXyzNt kQRAAcFciakv0SRuKYTiyRj8NZEfm/QlNumeRlZ/TLgExcofuBar7m1hbvDNNMqWNgAc hAueqyYthyeMNQaxqHaymt0BR5Eu0+NOIWiU9kvceuw24xz84gjZtHsWUaCTQhic947Q f43oSMeKHRzglJ3WJF/XGn7g17hbYG9DT6PCH48BuE7z2r7g22y/TqloSyECp4jSUnUn u0mg== X-Gm-Message-State: AAQBX9chwQxJ6aT6at8Pn0SVWGmhC8zcvL+KvezBnuAMi8LQ3e89PdP6 xrGsLYGoVBQS2s6igmc90H41e50+IU20QPJ8atyNzA== X-Google-Smtp-Source: AKy350b/2rLk8o88p4VUbyle6JhVGe9hR9d819uyBdgV73sk/uZgX0GFbxXyCEIMzWz7Cw3/rrBl4ZxfoRtYYcDxmUE= X-Received: by 2002:adf:cf05:0:b0:2f6:ddbf:5bce with SMTP id o5-20020adfcf05000000b002f6ddbf5bcemr331156wrj.3.1681455736843; Fri, 14 Apr 2023 00:02:16 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-17-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 09:02:06 +0200 Message-ID: Subject: Re: [XEN PATCH v8 16/22] xen/arm: ffa: add ABI structs for sharing memory To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:49=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 16/22] xen/arm: ffa: add ABI structs for sharing > > memory > > > > Adds the ABI structs used by function FFA_MEM_SHARE and friends for > > sharing memory. > > > > Signed-off-by: Jens Wiklander > > Reviewed-by: Bertrand Marquis > > Reviewed-by: Henry Wang I'll add that. Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 07:03:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 07:03:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521031.809280 (Exim 4.92) (envelope-from ) id 1pnDTH-0005dV-J9; Fri, 14 Apr 2023 07:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521031.809280; Fri, 14 Apr 2023 07:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnDTH-0005dO-G8; Fri, 14 Apr 2023 07:03:47 +0000 Received: by outflank-mailman (input) for mailman id 521031; Fri, 14 Apr 2023 07:03:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnDTG-0005dI-GM for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 07:03:46 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7eb28b0a-da92-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 09:03:44 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id v10so3166817wmn.5 for ; Fri, 14 Apr 2023 00:03:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7eb28b0a-da92-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681455824; x=1684047824; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tGMx0rmfx67kzWt9O29eEw74QbvsMz8TesWbQZyGcC8=; b=A2xCGLMkFPbx/h9fqDpYraPYo3ESuXtY3oggNU2cCMvTPFP3avZx17oydoAS3SfmWI NkE3aYXm/bAqF68ftQbw/UBSrGtsVs5A4ZsjHi+XJlxtxLYusguKrtKTBgIM21cro8UX OR0ehdHAbCiUjcB2KAWEwQedPBEgfFNyAL3a3ZupkEVQHXUjvgHqNTgvP3PnnqM3osoP 2uSIJY8c4oBbt4zphAFlVJV733jeMiEnn1txsiPoxHmg5JHl9foXC8w7LeYN9XTcDZKX U4MLFRyS9+nvoImS6IwXXvDsDoFPGvAmNV5aZQOgLhF3lg+Rn3Be9HTEPaNOTpwY1TyM w1XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681455824; x=1684047824; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGMx0rmfx67kzWt9O29eEw74QbvsMz8TesWbQZyGcC8=; b=NBixKFAZa/0UHPuMxZklXXLZgQIwy+guMfQN6PNHS1BiGeCoqi2A7/0pHSfVJGDIfH LCsUsAQburG8G/0FWxNfwbMPCyZCrIz6T3ZTkht2EGboBZHP+wVRnwXAECjnqC0WevDk nEOxgF6NqD9+TSdsklOkI5TDO4aoc14U3zWxHFNsPe2anKO2UgCxsND96WnKUR89OyWW sBbqIZ03UZlzDs370hNu6zwvKTubJycQUxrOGcmhel86tyWbyhbD0aQPxH7d6ZXeCCQY Zl19M8bYzsy0MHHf0zCAasuEazEhPA0eA5c0xA0PXH++kLgJqNX6TTN3Pdp6Q0Y0FGFX exBA== X-Gm-Message-State: AAQBX9flPbJxBmBWJTtYZs5lWR6Ha8fLZi05Sw5yswhlAWit14WJBuud ArsL769enVHv+2rJBb3QiGh0n80HQvmFwlujN0RPEg== X-Google-Smtp-Source: AKy350ZoyKfVIgsqyF/4nTESSIivT20YSwuFJPYTkxQN1FJIwTSEP+bFEv/+UpBMZ9k2LpwG6DrAG7GbzAc3spqlToE= X-Received: by 2002:a7b:c4d0:0:b0:3f0:b15c:e6b8 with SMTP id g16-20020a7bc4d0000000b003f0b15ce6b8mr237961wmk.4.1681455823956; Fri, 14 Apr 2023 00:03:43 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-4-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 09:03:33 +0200 Message-ID: Subject: Re: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:53=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator > > > > Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a > > guest is trusted to use FF-A. > > > > Signed-off-by: Jens Wiklander > > Reviewed-by: Bertrand Marquis > > Reviewed-by: Henry Wang I'll add that. Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 08:20:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 08:20:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521037.809290 (Exim 4.92) (envelope-from ) id 1pnEf4-00057g-CT; Fri, 14 Apr 2023 08:20:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521037.809290; Fri, 14 Apr 2023 08:20:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnEf4-00056v-8o; Fri, 14 Apr 2023 08:20:02 +0000 Received: by outflank-mailman (input) for mailman id 521037; Fri, 14 Apr 2023 08:20:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnEf3-0004z5-6Q for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 08:20:01 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2540f0c4-da9d-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 10:19:59 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id l18so16577613wrb.9 for ; Fri, 14 Apr 2023 01:19:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2540f0c4-da9d-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681460399; x=1684052399; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PFpxARKtWgnRpMlcvrYFS8qiTmLjgx1JA4OmnpxuvH0=; b=i1mrDdZ2WYg3txNAEHG2ymhXtYk+Lkrdbgr29/1uLP+RlIPXAVE1f5+6f4pVZSeoPv QqLV0bq5fqSLfOWGHFiPV2aDFsNtM7X1aDAKVdN/9Zys0DM3JUEz20mKkDw1efDqGIMy 7r0zYt35/5c5uh5T9RsNtPSsdKA/3bVmHEuxGVdp12QnqqrLJ4HtyA3V5rIcSI6Uw80k MfVI5C8HzqZTxoBM69TJREJ5VHbqU1rdmUhr6tuBf1sZK2rPnf8fvXcB5nRqmyPmW3ts F85p9gDc+v7OuzJPtqCDXlMZuD4vFjzWzGpR3jUPhHKny/XPZM4xPZFOfoZf4p70nhhs Uo1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681460399; x=1684052399; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PFpxARKtWgnRpMlcvrYFS8qiTmLjgx1JA4OmnpxuvH0=; b=j5ilrHbStK23TPQJA5/4Rfqi5fJjfTLIDmTFDLjSJGzHaOTxG1uGUM/SSE2wp/NoRF YrH5fO0VkKDyYnN2JbvoFRoqdzIRU842xiJTHR6rN9vj20txnLCeRjE5kG9lRnVvpSdu 6XtI8HMq+6V/IZ6lzSXjc+I18cQAXqY3gF8BrutkMePYuB6SB7WS3i7ZGIKwRZXuLMtn bw6tdMuLXJywbIJbXTtSEuVfS9eH4FPX/1l4OA0hIgzV1/sYZ+a0iMWy5fqlesKXgaUs lVcXoOFXcp2Z0eI7yOu+DqdX4l3MelhccAI4S+5XOdcJue0CusVyAindDDdx3cDBxaXb R4dQ== X-Gm-Message-State: AAQBX9cUSQA5WeIZPX5vas9Kl5OWHiDQx/1HXi/jLMTAaLZ5yzLhlPv5 kGqHWKitxZZbNnQFvUdq7I6tMd/0OZ71rl21NnUmMw== X-Google-Smtp-Source: AKy350bilVUh/+x6GI8LJs/DLGS/LheJiFQC0zsKEuCnmKW1U2zt3b1JRIHKo8NndQZkyyldYZbAsSVDi49Jjok7GmY= X-Received: by 2002:adf:e48f:0:b0:2f5:a50c:167d with SMTP id i15-20020adfe48f000000b002f5a50c167dmr867559wrm.3.1681460398710; Fri, 14 Apr 2023 01:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-12-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 10:19:47 +0200 Message-ID: Subject: Re: [XEN PATCH v8 11/22] xen/arm: ffa: send guest events to Secure Partitions To: Julien Grall , bertrand.marquis@arm.com, Marc Bonnici , Achin Gupta Cc: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 13, 2023 at 3:24=E2=80=AFPM Julien Grall wrote= : > > Hi, > > On 13/04/2023 08:14, Jens Wiklander wrote: > > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > > + uint8_t msg) > > +{ > > + uint32_t exp_resp =3D FFA_MSG_FLAG_FRAMEWORK; > > + int32_t res; > > + > > + if ( msg =3D=3D FFA_MSG_SEND_VM_CREATED ) > > + exp_resp |=3D FFA_MSG_RESP_VM_CREATED; > > + else if ( msg =3D=3D FFA_MSG_SEND_VM_DESTROYED ) > > + exp_resp |=3D FFA_MSG_RESP_VM_DESTROYED; > > + else > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + do { > > + const struct arm_smccc_1_2_regs arg =3D { > > + .a0 =3D FFA_MSG_SEND_DIRECT_REQ_32, > > + .a1 =3D sp_id, > > + .a2 =3D FFA_MSG_FLAG_FRAMEWORK | msg, > > + .a5 =3D vm_id, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 !=3D FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 !=3D = exp_resp ) > > + { > > + /* > > + * This is an invalid response, likely due to some error i= n the > > + * implementation of the ABI. > > + */ > > + return FFA_RET_INVALID_PARAMETERS; > > + } > > + res =3D resp.a3; > > + } while ( res =3D=3D FFA_RET_INTERRUPTED || res =3D=3D FFA_RET_RET= RY ); > > This loop seems potentially unbounded to me. Can you add a comment > explaining why this is fine? In the FF-A 1.1 specification (https://developer.arm.com/documentation/den0077/e/?lang=3Den) Table 18.26 at page 330 it says that FFA_RET_INTERRUPTED and FFA_RET_RETRY should be handled in this way. When looking at this from the hypervisor's point of view it is troublesome since there isn't any guarantee that we're progressing. We should be able to rule out FFA_RET_INTERRUPTED since non-secure interrupts should be masked at this point. I'm not sure if FFA_RET_RETRY can be avoided entirely, but we should be able to put a limit on how many times we're prepared to retry. How about setting a limit of max 10 retries and treating FFA_RET_INTERRUPTED as an error? Or is it better to not loop at all and treat all but FFA_RET_OK as errors? What do others think? Thanks, Jens > > > + > > + return res; > > +} > > + > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Apr 14 08:29:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 08:29:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521041.809300 (Exim 4.92) (envelope-from ) id 1pnEoE-0006T0-7q; Fri, 14 Apr 2023 08:29:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521041.809300; Fri, 14 Apr 2023 08:29:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnEoE-0006St-56; Fri, 14 Apr 2023 08:29:30 +0000 Received: by outflank-mailman (input) for mailman id 521041; Fri, 14 Apr 2023 08:29:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnEoC-0006Sn-RU for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 08:29:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060d.outbound.protection.outlook.com [2a01:111:f400:fe0e::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 779515b0-da9e-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 10:29:26 +0200 (CEST) Received: from AS8P251CA0021.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::18) by DB9PR08MB6747.eurprd08.prod.outlook.com (2603:10a6:10:26e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 08:29:24 +0000 Received: from AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::d5) by AS8P251CA0021.outlook.office365.com (2603:10a6:20b:2f2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.33 via Frontend Transport; Fri, 14 Apr 2023 08:29:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT063.mail.protection.outlook.com (100.127.140.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.10 via Frontend Transport; Fri, 14 Apr 2023 08:29:24 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Fri, 14 Apr 2023 08:29:23 +0000 Received: from 637f994ace9a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FB9D403E-7790-49E2-BBC3-657557A7E860.1; Fri, 14 Apr 2023 08:29:16 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 637f994ace9a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 08:29:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB10366.eurprd08.prod.outlook.com (2603:10a6:10:40a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 08:29:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:29:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 779515b0-da9e-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5KpCr7vPoauzdSPAbufVUBQVHs8SNd1pw2IL59R4QU=; b=FAozWIco6QGXzWntBUnO4WKiBWOgwJwA4MWYhHb4W8P71Abxh8rbKTL6YT4LSMbx3OB92VFjsiXGW9sUkSk0ZPKiWdkcgvGFn/ju9J4/FLxXjzEeAvI3GdBvu2FPbOF+/g0eimHipQE/Pw2lcZ2gqikSvn8kcC1Wz2YQ5SQVvz8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: af4b43025101a2e4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRt15dowCb6DVE7BlkGaMCGJ06VCHQFi7Lx5ta2xrUGT15Km38+6qcB0USQbKgGz2kqr7CQuce3jB/dyokAr2I/9VyasI3TPgB+yj/6qxBFFRiDHSy+kALTLiDSt7a/cp4zxZIeN3Q//aTJZRo9iXxD3SSRgSZXDqGxhCY/VNMzkPiJyt9cfr0vvgDzAfd3X+JXtYzy2USUFdxKtu7jDh++wWDQ5VMP2NPWY2RaGfLxXtXqhKPWaPpyz15nXrY2sQ7YQbzmoO+4LnHnALs8AMwo/6rusEpN4mmv9dW3n7v6t/0BC9KA/Vx5eGYFCgpp+V17xnJEr+cSXiPMBrNy8qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u5KpCr7vPoauzdSPAbufVUBQVHs8SNd1pw2IL59R4QU=; b=CWxEd6l6Ys9G2yseBI4C8Q7zPyLGs8DR5bHcXVB9quU1aMr/F+H+c18Cr5YZWRDiHfW6YSi8SRpL1s1ljbSC/NPXmxIzOrta00iB6uuoggemsqXPmx5NINqeCBtNf8iGXur2JtnvxjtQ+wPN7CeXLF93rO2nFM3c+WJ8XWR/ldVPGyfzKI47P693eOC3rJAYjqjEBxZgG5eBarZMyN9Yiq2wB0LHydyf6ZTzp8gxKZ8BtzboNTnmrmyb3znQ7EeIW+D5UJi7/MR6ZeadUz8OQ0CsovcICtpaF4eNPY6kkBvGvsmv/Z598BGpxoyVTny91PrOOwAZ/cMHc4vRw536OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5KpCr7vPoauzdSPAbufVUBQVHs8SNd1pw2IL59R4QU=; b=FAozWIco6QGXzWntBUnO4WKiBWOgwJwA4MWYhHb4W8P71Abxh8rbKTL6YT4LSMbx3OB92VFjsiXGW9sUkSk0ZPKiWdkcgvGFn/ju9J4/FLxXjzEeAvI3GdBvu2FPbOF+/g0eimHipQE/Pw2lcZ2gqikSvn8kcC1Wz2YQ5SQVvz8= From: Bertrand Marquis To: Jens Wiklander CC: Julien Grall , Marc Bonnici , Achin Gupta , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Stefano Stabellini Subject: Re: [XEN PATCH v8 11/22] xen/arm: ffa: send guest events to Secure Partitions Thread-Topic: [XEN PATCH v8 11/22] xen/arm: ffa: send guest events to Secure Partitions Thread-Index: AQHZbdfNbAtCLjIaYEG04chauCctrq8pOrmAgAE9V4CAAAKNgA== Date: Fri, 14 Apr 2023 08:29:06 +0000 Message-ID: <9732C6EB-3346-408D-B267-9CCCE081B661@arm.com> References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-12-jens.wiklander@linaro.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DU0PR08MB10366:EE_|AM7EUR03FT063:EE_|DB9PR08MB6747:EE_ X-MS-Office365-Filtering-Correlation-Id: 79df069b-04d3-4e42-6f06-08db3cc25a88 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FcRLf50Y/01/r/9qeW7r4ntaZrDOFFoDFw1jYznHkQ93cblxDcbEYuGn2XYhgwmW+MySIWzSZt2ruPE89Z8qEyVgpU7GYXvHdIDR6lug3WCD6ZU2Ga7eOhXXKnUuDnuIIPIMliqgNiSrORYYf+OY+UkSNo9SqsCagsS+SlGyHhcQWTEyGvXd1MYN9EgjUphw8llEEHpQbvR1OrQtn3YVUdT1sbThZzzUJ7snVwHvIsMkT1enx4zAkUk5aT1xNBfRnOslL20aJ+HmEtWNGZh1gRzKu1/AQ1ZKm1KEeFnyZ9YFzC4rBx9A+Nv0u9u33eXGHOWnqwJoWWrmYeejGKrFWWVFZuasoO95xosxQS+t/s0XSDycK/LJ6QAup9bI0LbPA1C4ig5dbxY1MDUw94unDbWmhVhdS4TCufA0K5hFvDmwHywwus98WnYahFHfybg5+auAUKGW/hTsJHahS9lDKl4Eu90N/C2IiYtCRUHqzzQd1LH/8N3f+VE8Fpta7fFKetW+jy0biflciCenOL7LEOmWw0Q1T0q+mideaOjvokwD3kwdPEjTzOpx9OcRewdxOpuaNXabsus99vWJ0HYmqgIs86xcnQmYS5t9ucewALq00D1X917asKj0Sp1kDi7nnarDmIHziBaLcB+8YmnTKg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199021)(4326008)(316002)(6486002)(6916009)(2906002)(86362001)(2616005)(36756003)(8676002)(8936002)(33656002)(186003)(5660300002)(6506007)(6512007)(53546011)(38100700002)(122000001)(38070700005)(83380400001)(71200400001)(6666004)(41300700001)(54906003)(478600001)(91956017)(76116006)(66446008)(66476007)(66946007)(66556008)(64756008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <640B96E36F413347AF23CB1C6598A7E6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10366 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d190ecf-9413-43f0-8930-08db3cc2502e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hc4sryTN767UroML+SB9gIefwmynRbGt7CYaq0F1pyF9qXDqt10n1Y5sMfBioo0VmXnHL6LkFG94FV5aATPLOyhZs+Zw+ZpYm/IZ726XKDngLX4WUUorZm8aV+1ergI1B3JhICJZtN5Qt65byck+fkZFpVj3GEl6iS5jMMd5rc9Ehcr7e+YQ3KwDPE9j+ZR851XWzHBjAHp+haz6cfpaJlFt89KHQPdsPhJwtrgx7L+RjFFLcnmnPNTGcP0ohmLP5Bm1EfuHTuq+9rkA88kM1rKblISapQG4AsujPPmyHiGuoKPp+Bzj56H2xNCs1e2HLtj7+0xqw1/Nl1bmdIdRvL6bSwhZIkx4/CgxbFrIItmOWOl31qJ7J9V+6sb0hT4genCj1yAZqwNalqbKRpL/oDZC1jdMyeAb8lwxb6hwYbV8lYUiVUPrt3REyuiMqq4H9FmnyyCiX36sCKyrem/vPf+qUk5TFPHAAFNH8RbxegTiHbaDDFg/1H1xmX3M/GBPYlamogPYVHGhjcUJlt918Vw89/5sR1LjUlYXdmIUq9/8OIXo1ATNgJ9q9hMGXF7qtPQvDFiihW437mTfbn6z3Ia/Ve0AuvHOhRNr0Dh4GWuYJkZAdkEvE8RryGlsCs7g1YTDcJTZYt3O8C5cwhkIPGiw9eJpCkhKNT+6xk54ytiIfqYcG7EjGdTHxclQ5VFi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199021)(40470700004)(46966006)(36840700001)(107886003)(40460700003)(6512007)(26005)(186003)(6506007)(53546011)(54906003)(40480700001)(33656002)(478600001)(81166007)(356005)(2906002)(8676002)(8936002)(6862004)(36860700001)(83380400001)(41300700001)(336012)(5660300002)(47076005)(2616005)(82310400005)(316002)(4326008)(70206006)(70586007)(82740400003)(86362001)(6486002)(6666004)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:29:24.2488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79df069b-04d3-4e42-6f06-08db3cc25a88 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6747 SGkgSmVucywNCg0KPiBPbiAxNCBBcHIgMjAyMywgYXQgMTA6MTksIEplbnMgV2lrbGFuZGVyIDxq ZW5zLndpa2xhbmRlckBsaW5hcm8ub3JnPiB3cm90ZToNCj4gDQo+IEhpLA0KPiANCj4gT24gVGh1 LCBBcHIgMTMsIDIwMjMgYXQgMzoyNOKAr1BNIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+ IHdyb3RlOg0KPj4gDQo+PiBIaSwNCj4+IA0KPj4gT24gMTMvMDQvMjAyMyAwODoxNCwgSmVucyBX aWtsYW5kZXIgd3JvdGU6DQo+Pj4gK3N0YXRpYyBpbnQzMl90IGZmYV9kaXJlY3RfcmVxX3NlbmRf dm0odWludDE2X3Qgc3BfaWQsIHVpbnQxNl90IHZtX2lkLA0KPj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgbXNnKQ0KPj4+ICt7DQo+Pj4gKyAgICB1aW50 MzJfdCBleHBfcmVzcCA9IEZGQV9NU0dfRkxBR19GUkFNRVdPUks7DQo+Pj4gKyAgICBpbnQzMl90 IHJlczsNCj4+PiArDQo+Pj4gKyAgICBpZiAoIG1zZyA9PSBGRkFfTVNHX1NFTkRfVk1fQ1JFQVRF RCApDQo+Pj4gKyAgICAgICAgZXhwX3Jlc3AgfD0gRkZBX01TR19SRVNQX1ZNX0NSRUFURUQ7DQo+ Pj4gKyAgICBlbHNlIGlmICggbXNnID09IEZGQV9NU0dfU0VORF9WTV9ERVNUUk9ZRUQgKQ0KPj4+ ICsgICAgICAgIGV4cF9yZXNwIHw9IEZGQV9NU0dfUkVTUF9WTV9ERVNUUk9ZRUQ7DQo+Pj4gKyAg ICBlbHNlDQo+Pj4gKyAgICAgICAgcmV0dXJuIEZGQV9SRVRfSU5WQUxJRF9QQVJBTUVURVJTOw0K Pj4+ICsNCj4+PiArICAgIGRvIHsNCj4+PiArICAgICAgICBjb25zdCBzdHJ1Y3QgYXJtX3NtY2Nj XzFfMl9yZWdzIGFyZyA9IHsNCj4+PiArICAgICAgICAgICAgLmEwID0gRkZBX01TR19TRU5EX0RJ UkVDVF9SRVFfMzIsDQo+Pj4gKyAgICAgICAgICAgIC5hMSA9IHNwX2lkLA0KPj4+ICsgICAgICAg ICAgICAuYTIgPSBGRkFfTVNHX0ZMQUdfRlJBTUVXT1JLIHwgbXNnLA0KPj4+ICsgICAgICAgICAg ICAuYTUgPSB2bV9pZCwNCj4+PiArICAgICAgICB9Ow0KPj4+ICsgICAgICAgIHN0cnVjdCBhcm1f c21jY2NfMV8yX3JlZ3MgcmVzcDsNCj4+PiArDQo+Pj4gKyAgICAgICAgYXJtX3NtY2NjXzFfMl9z bWMoJmFyZywgJnJlc3ApOw0KPj4+ICsgICAgICAgIGlmICggcmVzcC5hMCAhPSBGRkFfTVNHX1NF TkRfRElSRUNUX1JFU1BfMzIgfHwgcmVzcC5hMiAhPSBleHBfcmVzcCApDQo+Pj4gKyAgICAgICAg ew0KPj4+ICsgICAgICAgICAgICAvKg0KPj4+ICsgICAgICAgICAgICAgKiBUaGlzIGlzIGFuIGlu dmFsaWQgcmVzcG9uc2UsIGxpa2VseSBkdWUgdG8gc29tZSBlcnJvciBpbiB0aGUNCj4+PiArICAg ICAgICAgICAgICogaW1wbGVtZW50YXRpb24gb2YgdGhlIEFCSS4NCj4+PiArICAgICAgICAgICAg ICovDQo+Pj4gKyAgICAgICAgICAgIHJldHVybiBGRkFfUkVUX0lOVkFMSURfUEFSQU1FVEVSUzsN Cj4+PiArICAgICAgICB9DQo+Pj4gKyAgICAgICAgcmVzID0gcmVzcC5hMzsNCj4+PiArICAgIH0g d2hpbGUgKCByZXMgPT0gRkZBX1JFVF9JTlRFUlJVUFRFRCB8fCByZXMgPT0gRkZBX1JFVF9SRVRS WSApOw0KPj4gDQo+PiBUaGlzIGxvb3Agc2VlbXMgcG90ZW50aWFsbHkgdW5ib3VuZGVkIHRvIG1l LiBDYW4geW91IGFkZCBhIGNvbW1lbnQNCj4+IGV4cGxhaW5pbmcgd2h5IHRoaXMgaXMgZmluZT8N Cj4gDQo+IEluIHRoZSBGRi1BIDEuMSBzcGVjaWZpY2F0aW9uDQo+IChodHRwczovL2RldmVsb3Bl ci5hcm0uY29tL2RvY3VtZW50YXRpb24vZGVuMDA3Ny9lLz9sYW5nPWVuKSBUYWJsZQ0KPiAxOC4y NiBhdCBwYWdlIDMzMCBpdCBzYXlzIHRoYXQgRkZBX1JFVF9JTlRFUlJVUFRFRCBhbmQgRkZBX1JF VF9SRVRSWQ0KPiBzaG91bGQgYmUgaGFuZGxlZCBpbiB0aGlzIHdheS4gV2hlbiBsb29raW5nIGF0 IHRoaXMgZnJvbSB0aGUNCj4gaHlwZXJ2aXNvcidzIHBvaW50IG9mIHZpZXcgaXQgaXMgdHJvdWJs ZXNvbWUgc2luY2UgdGhlcmUgaXNuJ3QgYW55DQo+IGd1YXJhbnRlZSB0aGF0IHdlJ3JlIHByb2dy ZXNzaW5nLg0KPiANCj4gV2Ugc2hvdWxkIGJlIGFibGUgdG8gcnVsZSBvdXQgRkZBX1JFVF9JTlRF UlJVUFRFRCBzaW5jZSBub24tc2VjdXJlDQo+IGludGVycnVwdHMgc2hvdWxkIGJlIG1hc2tlZCBh dCB0aGlzIHBvaW50LiBJJ20gbm90IHN1cmUgaWYNCj4gRkZBX1JFVF9SRVRSWSBjYW4gYmUgYXZv aWRlZCBlbnRpcmVseSwgYnV0IHdlIHNob3VsZCBiZSBhYmxlIHRvIHB1dCBhDQo+IGxpbWl0IG9u IGhvdyBtYW55IHRpbWVzIHdlJ3JlIHByZXBhcmVkIHRvIHJldHJ5Lg0KDQpUaGUgZmFjdCB0aGF0 IGludGVycnVwdHMgYXJlIG1hc2tlZCBpbiBYZW4gZG9lcyBub3QgbWVhbiB0aGV5IHdpbGwgYmUg aW4gc2VjdXJlLg0KSW4gZmFjdCB3aGF0IHdlIHNob3VsZCBkbyB3aGVuIElOVEVSUlVQVEVEIGlz IHJlY2VpdmVkIGlzIHNvbWV0aGluZyB3ZSBoYXZlDQp0byBjbGVhciB1cCBidXQgd2Ugc2hvdWxk IHVubWFzayBpbnRlcnJ1cHQgdG8gcHJvY2VzcyB0aGVtIGluIFhlbiBiZWZvcmUgcmV0cnlpbmcg SSB0aGluay4NCg0KPiANCj4gSG93IGFib3V0IHNldHRpbmcgYSBsaW1pdCBvZiBtYXggMTAgcmV0 cmllcyBhbmQgdHJlYXRpbmcNCj4gRkZBX1JFVF9JTlRFUlJVUFRFRCBhcyBhbiBlcnJvcj8gT3Ig aXMgaXQgYmV0dGVyIHRvIG5vdCBsb29wIGF0IGFsbA0KPiBhbmQgdHJlYXQgYWxsIGJ1dCBGRkFf UkVUX09LIGFzIGVycm9ycz8gV2hhdCBkbyBvdGhlcnMgdGhpbms/DQoNCkkgd291bGQgc3VnZ2Vz dCB0byBkbyBhIG1heCByZXRyeSBmb3IgYm90aCBjYXNlcyBhbmQgYWRkIGEgVE9ETyBpbiB0aGUg Y29kZS4NCldlIHdpbGwgbmVlZCB0byBkZWZpbmUgYSBnZW5lcmljIHdheSB0byBoYW5kbGUgdGhv c2UgY2FzZXMgYnV0IGF0IHRoaXMgc3RhZ2UNCklOVEVSUlVQVEVEIHNob3VsZCBiZSBjb25zaWRl cmVkIFRPRE8uDQpSRVRSWSB3aWxsIHByb2JhYmx5IHN0YXkgd2l0aCBhIGxpbWl0IGhlcmUsIGlu IHRoZSBjYXNlIG9mIGEgZ3Vlc3QgbWVzc2FnZSBib3RoDQpvZiB0aG9zZSBwb3NzaWJpbGl0aWVz IGNvdWxkIGp1c3QgYmUgcmV0dXJuZWQgdG8gdGhlIGd1ZXN0Lg0KDQoNCkRvIHlvdSBhZ3JlZSA/ DQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gVGhhbmtzLA0KPiBKZW5zDQo+IA0KPj4gDQo+ Pj4gKw0KPj4+ICsgICAgcmV0dXJuIHJlczsNCj4+PiArfQ0KPj4+ICsNCj4+IA0KPj4gQ2hlZXJz LA0KPj4gDQo+PiAtLQ0KPj4gSnVsaWVuIEdyYWxsDQoNCg0K From xen-devel-bounces@lists.xenproject.org Fri Apr 14 08:41:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 08:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521046.809310 (Exim 4.92) (envelope-from ) id 1pnEzV-0000Pn-DG; Fri, 14 Apr 2023 08:41:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521046.809310; Fri, 14 Apr 2023 08:41:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnEzV-0000Pg-AM; Fri, 14 Apr 2023 08:41:09 +0000 Received: by outflank-mailman (input) for mailman id 521046; Fri, 14 Apr 2023 08:41:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnEzU-0000Pa-5B for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 08:41:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1a::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18e770d6-daa0-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 10:41:07 +0200 (CEST) Received: from AS9PR06CA0159.eurprd06.prod.outlook.com (2603:10a6:20b:45c::26) by AS8PR08MB9744.eurprd08.prod.outlook.com (2603:10a6:20b:614::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 08:41:03 +0000 Received: from AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45c:cafe::2) by AS9PR06CA0159.outlook.office365.com (2603:10a6:20b:45c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.33 via Frontend Transport; Fri, 14 Apr 2023 08:41:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT007.mail.protection.outlook.com (100.127.140.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.33 via Frontend Transport; Fri, 14 Apr 2023 08:41:02 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Fri, 14 Apr 2023 08:41:02 +0000 Received: from 9d7f2be32ea3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F29C5BC1-AE1A-480C-A63D-C2C66DE582EA.1; Fri, 14 Apr 2023 08:40:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9d7f2be32ea3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 08:40:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB6680.eurprd08.prod.outlook.com (2603:10a6:20b:397::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 08:40:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18e770d6-daa0-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zcc1odVblejsig4qsy4m9Anh6zU8rGuBdxTtNo7iqtY=; b=rjM82foaOvVrJeDUNzBYaqDBUkQ7q/N6kQmBKIWPbGQ64nxm7N/XghyuXsT2F9jFm2fqF9/X/1iM0Xh0e0mci/vNEGlgHfeC6PROoMlzWo/WNuhKwMcAm5LT9MzRxvG7I4L3UfBlf7hFWFCsVlBO8PzGkIWF3kLtjIN0YrE+lPE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6e812a435e6285eb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gGaWOVDDZhIFh6UqPXMqVrOuDnGiNONs1nQr8gs1Fjc2xy/KUjF9O2VigdgqG+vEKxrlBxJzw/SZzjOy16ES0VUfWpoVEP1w/+RemFwfj1PtWYKdi/9205hmsG7Dkg8aiEFRsm661qSa58g1HOlPN18sWkaxGLIA/sbasKhXcNq6whyO/uRArI6FmEbLPBEwPC3xnOdT5H5ft6Xz3H23yHKo7Yxtzb7OPl6qTiFz5rXLZ/Gd+xtS/JsnldsoFP6llkNRMQidEuOkZW82tdZylUW1/512QQrdlfqXR0M6ji+UqvBjnLch5xBOxWoxxf97lg8IY/UPnMmAVltEZk+2bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zcc1odVblejsig4qsy4m9Anh6zU8rGuBdxTtNo7iqtY=; b=iRVPrKcXXz/mkMJ036ZPu/stLqYRmqdqxzC+tnTPID8hHuo+/S6BE69CmSFgNXSFhYqr+0NiA0iwVlwrYmDpgHKObretvQbtwEd4RGz5132iJ4JDWgsLF9jFC3VqKlgOiXaYlsF1hom196XG+UhdW85KzLEUPEdg6a2bsE8cH58ECZmZp/IBTEqxoVI049HZUVDjYQ+82K3ekkSiDKbxEugXb6omFQMXdVgPt82+INbyGXxXxSzrbujfpC9jAyDdcLGbPPYqNxcbwI7V+QJa1Bt5cIIq8Q/mGl910WSSdjm4aUe01v7dqGD84EP6sEjXG4bZ1h2T71ihcktNgLj2Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zcc1odVblejsig4qsy4m9Anh6zU8rGuBdxTtNo7iqtY=; b=rjM82foaOvVrJeDUNzBYaqDBUkQ7q/N6kQmBKIWPbGQ64nxm7N/XghyuXsT2F9jFm2fqF9/X/1iM0Xh0e0mci/vNEGlgHfeC6PROoMlzWo/WNuhKwMcAm5LT9MzRxvG7I4L3UfBlf7hFWFCsVlBO8PzGkIWF3kLtjIN0YrE+lPE= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v5 04/12] xen/arm: add SVE exception class handling Thread-Topic: [PATCH v5 04/12] xen/arm: add SVE exception class handling Thread-Index: AQHZbSQpoCrJkjjTIkyQmrtaVCm5Lq8qf08A Date: Fri, 14 Apr 2023 08:40:52 +0000 Message-ID: <92137CCE-1E08-4C95-9BC1-A4B83EEEC91E@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-5-luca.fancellu@arm.com> In-Reply-To: <20230412094938.2693890-5-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB6680:EE_|AM7EUR03FT007:EE_|AS8PR08MB9744:EE_ X-MS-Office365-Filtering-Correlation-Id: fc49b2fa-9d1c-4e92-8de3-08db3cc3fad6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nxPwmzvnFSe/USa0o86JHXqtJ8idwvBwzFgRoNlf0un8jL+zjegRhRi7xD9R5AhwpxdRhZ86VWtoEQHHrBgr0D3y/Vo+7JZmgcq1GowFVyU/4g6/HyyTXDsgTHFxUKx5yxx1jwAwCDM3qAVpk7M60Xc0xPQ8I1DSWhurczxIg+APipw62UW5fzwiDux/9BmaL+MjU+Mes5ofatHZXyelqPaxEJZYyrkIbgeCamVLOOKGkSgLBtYck2Rv8dhk/vQSdNSqAOy9NpQHL4Ba4MEtiyDWOfA0liWPV5M8hBsske2lIpi5744LdDcoKTOec7kqVNai37gScUEeE2ZJMjTUU2aa5ELgAohAVL41IQkYjON5GgcIX4YSJu6EzR3Ayv6m5UFXsbuXsPDrNwliFQfqd/azj+ixqGfG8B8VhZO/gbyf9PbLrD7R6CYYmze3qFVOsS2lFPYaP+3eys8SRuzUlVc/kMYJDHOJyoWKW+rjDMf4rOw3Lr4QEPJenGTi4HjIyZjDYU5VLHgXYbJkNRlw1yAxyNT+EyjA2yqjcdRBMF47FMIW6rdsHyVeK9nW3IejdotPjJ0T6C4hfeR1rJKUHky7TkeCLuNLNswTgAsRNS+tT1CVfs1Zh1auJ0ypigP4irLabV/VtNrUMcUibaUTsw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199021)(38070700005)(6512007)(186003)(6506007)(53546011)(6636002)(54906003)(37006003)(33656002)(478600001)(122000001)(2906002)(8676002)(8936002)(6862004)(83380400001)(41300700001)(5660300002)(2616005)(38100700002)(316002)(4326008)(66946007)(66556008)(91956017)(76116006)(66476007)(64756008)(66446008)(86362001)(6486002)(71200400001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <63ACCED0B18DAF439FB2E33AA5279782@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6680 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4f0ba49c-1d48-4352-3563-08db3cc3f4aa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rW9+y1RYA701dmMxyj8bWYIpK/JC3KNLWzq1A6HxjeQaQlehXnZDK4UjZtXGApYYB/2ItkaaPdk/G/Q3rCzhI3TYF2k1ukAAeami+xtpwpzyJ4jyOkzh0x4lxXKPxek+qVTo6NQX9NFiISf/XM8ZXltRf5R7ghIf0h/jXnXfmLk6ZqplhtTbLLqSAD+IHrSgXhWLXg3SZekUBGSYUKPhdP7p/m+OPlxXUBZl3f1TTvPqU5w5ccAjUIeZj2cty2Y4UZjgjQLi8xaCkWkpdiYXuyUIYAhCvT+8FBhgtNsVm02ojMkLg3cuWhYsdkF7mlNdkm9+0vgQs5CA2irTa+1f6SHuhLx2/n2853Lc9L0CpMnGhjQ8TUqxi/olI5PE3Uq+BDXI87yMZxRMXR5ce/F8/X2zgrM/WLH4ofR84N1JDuOszpTnnW9tDof2Kf3/ENnnnH5mjbEGcajTdm+3y+LoaiyPjRJYZCN+oc/4N6sn5kIYgBb7C8pfCFW5Z02nZvOupYr8IwdNIIUoux/09pJUeHZCnhYKFgbTuibPhMdKq95tZz76uqWZr0908qpfTcDeN6GcfLliC8yYvIZsazCWF2VT6C+iNGbIgrolUheKwaXeWPxy2U3ql2yBe3Cti+hUx8vXirk7gNH36FCuppMEH0R7AJzO+KJDIsO7i33SJWWhOxLQFtK2FjfoQekhcOdp393CVxmrrqbsLS10eYMf0g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199021)(46966006)(36840700001)(40470700004)(36860700001)(6862004)(47076005)(2616005)(336012)(83380400001)(54906003)(6486002)(478600001)(356005)(33656002)(37006003)(6512007)(186003)(6636002)(26005)(6506007)(107886003)(2906002)(36756003)(5660300002)(70206006)(4326008)(81166007)(41300700001)(53546011)(82310400005)(70586007)(40480700001)(8676002)(82740400003)(86362001)(316002)(40460700003)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:41:02.7086 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc49b2fa-9d1c-4e92-8de3-08db3cc3fad6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9744 Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >=20 > SVE has a new exception class with code 0x19, introduce the new code > and handle the exception. >=20 > Signed-off-by: Luca Fancellu With the comments from Julien handled you can add my: Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes from v4: > - No changes > Changes from v3: > - No changes > Changes from v2: > - No changes > Changes from v1: > - No changes > Changes from RFC: > - No changes > --- > xen/arch/arm/include/asm/processor.h | 1 + > xen/arch/arm/traps.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/= asm/processor.h > index bc683334125c..7e42ff8811fc 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -426,6 +426,7 @@ > #define HSR_EC_HVC64 0x16 > #define HSR_EC_SMC64 0x17 > #define HSR_EC_SYSREG 0x18 > +#define HSR_EC_SVE 0x19 > #endif > #define HSR_EC_INSTR_ABORT_LOWER_EL 0x20 > #define HSR_EC_INSTR_ABORT_CURR_EL 0x21 > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index a78a99ddadd0..c2e30feafd5a 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -2160,6 +2160,13 @@ void do_trap_guest_sync(struct cpu_user_regs *regs= ) > perfc_incr(trap_sysreg); > do_sysreg(regs, hsr); > break; > + case HSR_EC_SVE: > + GUEST_BUG_ON(regs_mode_is_32bit(regs)); > + gprintk(XENLOG_WARNING, > + "Domain id %d tried to use SVE while not allowed\n", > + current->domain->domain_id); > + inject_undef_exception(regs, hsr); > + break; > #endif >=20 > case HSR_EC_INSTR_ABORT_LOWER_EL: > @@ -2189,6 +2196,11 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) > case HSR_EC_BRK: > do_trap_brk(regs, hsr); > break; > + case HSR_EC_SVE: > + /* An SVE exception is a bug somewhere in hypervisor code */ > + printk("SVE trap at EL2.\n"); > + do_unexpected_trap("Hypervisor", regs); > + break; > #endif > case HSR_EC_DATA_ABORT_CURR_EL: > case HSR_EC_INSTR_ABORT_CURR_EL: > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 08:46:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 08:46:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521051.809320 (Exim 4.92) (envelope-from ) id 1pnF4Y-00012l-0q; Fri, 14 Apr 2023 08:46:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521051.809320; Fri, 14 Apr 2023 08:46:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnF4X-00012e-UD; Fri, 14 Apr 2023 08:46:21 +0000 Received: by outflank-mailman (input) for mailman id 521051; Fri, 14 Apr 2023 08:46:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnF4W-00012U-KP; Fri, 14 Apr 2023 08:46:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnF4W-0005Gr-GT; Fri, 14 Apr 2023 08:46:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnF4W-0007N6-40; Fri, 14 Apr 2023 08:46:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnF4W-0003oy-3V; Fri, 14 Apr 2023 08:46:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qMh9RedIxsTzSzUySz+FBrgZoII1lSf1la7H9WjfH3E=; b=O5wK8N9rBqzBClW/BVCJm4X8th DNDWdDJglm4RkV/EGv5S2rZMNYqOqcGaBa7QCmHyBZTd3YSluM72daGiozRuRbeMOQmWIl7CsbCUw mzPROmKpo+U803s21fO5tVgb+vsAQ2+i4/rMyTMnFvxptmiNKo0n3NXBjzUfrZDeAO4g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180251: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=7dbd6f8a27e30fe14adb3d5869097cddf24038d6 X-Osstest-Versions-That: qemuu=9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 From: osstest service owner Date: Fri, 14 Apr 2023 08:46:20 +0000 flight 180251 qemu-mainline real [real] flight 180257 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180251/ http://logs.test-lab.xenproject.org/osstest/logs/180257/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 180231 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180231 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180231 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180231 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180231 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180231 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 7dbd6f8a27e30fe14adb3d5869097cddf24038d6 baseline version: qemuu 9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 Last test of basis 180231 2023-04-13 09:18:05 Z 0 days Testing same since 180251 2023-04-13 20:08:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé David Woodhouse Juan Quintela Lukas Straub Peter Maydell Peter Xu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 7dbd6f8a27e30fe14adb3d5869097cddf24038d6 Author: Peter Maydell Date: Thu Apr 13 16:40:22 2023 +0100 Update version for v8.0.0-rc4 release Signed-off-by: Peter Maydell commit c38b2ca7387b7857a614d1a6b8be5371949156d4 Merge: 69d4e746b3 28ef5339c3 Author: Peter Maydell Date: Thu Apr 13 10:09:42 2023 +0100 Merge tag 'migration-20230412-pull-request' of https://gitlab.com/juan.quintela/qemu into staging Migration Pull request for 8.0 Last patches found: - peter xu preempt channel fixes. needed for backward compatibility with old machine types. - lukas fix to get compress working again. - fix ram on s390x. Get back to the old code, even when it shouldn't be needed, but as it fails on s390x, just revert. Later, Juan. # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEEGJn/jt6/WMzuA0uC9IfvGFhy1yMFAmQ3HgQACgkQ9IfvGFhy # 1yPXGQ/+Pf6HepNUlIr7naYOcpRriXPQF+q1zqo74F9fy2vrGcwJOI6qmRTjsX4E # 9KgXipOz7+b5wSemF7PDKcnBiwyt6UHCH+XXe0h4TpyuORbtABKRgtOhA1/sa84D # HnKp0TwImpAO26tzPa7u49aau/EEVBKAzFVcyn4w56S9qiDWicOpd5kG0CJBIsMJ # Mnvy5fXaqQRewnKiwFoJGWfyhzEToDO6Z/SkT5xYON94P+eiM2xMwXOC5WcGfmY7 # wFGDB+SuyEP8TTn7mV0mmnlFjYe4G07hVARHSDFX3ho4b6q5F+WzfW095G6QKiu9 # n3Pzr7IBGX3sgetPtYwOwGsE9JrfHMFzBRxQZZwq5GSmjk7+agkbXmV7RyV82EYs # KYOhuNF91ca0qvCrGA/eGbbJqVrd7SR5FhS4SQ7oKd5n2au/ZHoKwAgm5lBdcvES # 2TB0MBN1s0JPh6KMV8tPB2miZyqPRa++oA8qIX7Asoe1X4xVT1FwiDaFL8TO8i2A # 7uBis3KLZqOHC6dAiXlCDtaADAWgQxjcdoS1l8jTF6MgBSe+zQhXG+pcIDuSiV9N # WfDiUPY97iqPTvpzdz3Is+LbBax2uY5ZR05KSdmCBpIgfvSWMqXtwRydclt6G5h7 # ZiOcTwrgMpXdbhdsFZTqVWAJG2sTkj4TA+IezVpXzPeQNLZ+T8k= # =kW3P # -----END PGP SIGNATURE----- # gpg: Signature made Wed 12 Apr 2023 22:09:24 BST # gpg: using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723 # gpg: Good signature from "Juan Quintela " [full] # gpg: aka "Juan Quintela " [full] # Primary key fingerprint: 1899 FF8E DEBF 58CC EE03 4B82 F487 EF18 5872 D723 * tag 'migration-20230412-pull-request' of https://gitlab.com/juan.quintela/qemu: migration: fix ram_state_pending_exact() migration/ram.c: Fix migration with compress enabled migration: Recover behavior of preempt channel creation for pre-7.2 migration: Fix potential race on postcopy_qemufile_src io: tls: Inherit QIO_CHANNEL_FEATURE_SHUTDOWN on server side Signed-off-by: Peter Maydell commit 69d4e746b3a899b90d2cbf422a3ce764cf51cfbe Author: David Woodhouse Date: Wed Apr 12 19:51:01 2023 +0100 hw/xen: Fix double-free in xen_console store_con_info() Coverity spotted a double-free (CID 1508254); we g_string_free(path) and then for some reason immediately call free(path) too. We should just use g_autoptr() for it anyway, which simplifies the code a bit. Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to xen_console.c") Signed-off-by: David Woodhouse Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell commit 28ef5339c37f1f78c2fa4df2295bc0cd73a0abfd Author: Juan Quintela Date: Wed Apr 12 22:30:20 2023 +0200 migration: fix ram_state_pending_exact() I removed that bit on commit: commit c8df4a7aeffcb46020f610526eea621fa5b0cd47 Author: Juan Quintela Date: Mon Oct 3 02:00:03 2022 +0200 migration: Split save_live_pending() into state_pending_* Fixes: c8df4a7aeffcb46020f610526eea621fa5b0cd47 Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Juan Quintela commit 37502df32c4b02403fe92452c4ed1d96da3df01c Author: Lukas Straub Date: Sun Apr 2 17:06:32 2023 +0000 migration/ram.c: Fix migration with compress enabled Since ec6f3ab9, migration with compress enabled was broken, because the compress threads use a dummy QEMUFile which just acts as a buffer and that commit accidentally changed it to use the outgoing migration channel instead. Fix this by using the dummy file again in the compress threads. Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela commit 06064a671573580326b1f23a2afa2702c48d8e05 Author: Peter Xu Date: Sun Mar 26 13:25:40 2023 -0400 migration: Recover behavior of preempt channel creation for pre-7.2 In 8.0 devel window we reworked preempt channel creation, so that there'll be no race condition when the migration channel and preempt channel got established in the wrong order in commit 5655aab079. However no one noticed that the change will also be not compatible with older qemus, majorly 7.1/7.2 versions where preempt mode started to be supported. Leverage the same pre-7.2 flag introduced in the previous patch to recover the behavior hopefully before 8.0 releases, so we don't break migration when we migrate from 8.0 to older qemu binaries. Fixes: 5655aab079 ("migration: Postpone postcopy preempt channel to be after main") Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela commit 6621883f9398bc3f255968f0b4919e883bafb06c Author: Peter Xu Date: Sun Mar 26 13:25:39 2023 -0400 migration: Fix potential race on postcopy_qemufile_src postcopy_qemufile_src object should be owned by one thread, either the main thread (e.g. when at the beginning, or at the end of migration), or by the return path thread (when during a preempt enabled postcopy migration). If that's not the case the access to the object might be racy. postcopy_preempt_shutdown_file() can be potentially racy, because it's called at the end phase of migration on the main thread, however during which the return path thread hasn't yet been recycled; the recycle happens in await_return_path_close_on_source() which is after this point. It means, logically it's posslbe the main thread and the return path thread are both operating on the same qemufile. While I don't think qemufile is thread safe at all. postcopy_preempt_shutdown_file() used to be needed because that's where we send EOS to dest so that dest can safely shutdown the preempt thread. To avoid the possible race, remove this only place that a race can happen. Instead we figure out another way to safely close the preempt thread on dest. The core idea during postcopy on deciding "when to stop" is that dest will send a postcopy SHUT message to src, telling src that all data is there. Hence to shut the dest preempt thread maybe better to do it directly on dest node. This patch proposed such a way that we change postcopy_prio_thread_created into PreemptThreadStatus, so that we kick the preempt thread on dest qemu by a sequence of: mis->preempt_thread_status = PREEMPT_THREAD_QUIT; qemu_file_shutdown(mis->postcopy_qemufile_dst); While here shutdown() is probably so far the easiest way to kick preempt thread from a blocked qemu_get_be64(). Then it reads preempt_thread_status to make sure it's not a network failure but a willingness to quit the thread. We could have avoided that extra status but just rely on migration status. The problem is postcopy_ram_incoming_cleanup() is just called early enough so we're still during POSTCOPY_ACTIVE no matter what.. So just make it simple to have the status introduced. One flag x-preempt-pre-7-2 is added to keep old pre-7.2 behaviors of postcopy preempt. Fixes: 9358982744 ("migration: Send requested page directly in rp-return thread") Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela commit 86d063fa83901bc8150343ff8b03979fbea392c9 Author: Peter Xu Date: Sun Mar 26 13:25:38 2023 -0400 io: tls: Inherit QIO_CHANNEL_FEATURE_SHUTDOWN on server side TLS iochannel will inherit io_shutdown() from the master ioc, however we missed to do that on the server side. This will e.g. allow qemu_file_shutdown() to work on dest QEMU too for migration. Acked-by: Daniel P. Berrangé Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela From xen-devel-bounces@lists.xenproject.org Fri Apr 14 08:47:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 08:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521058.809330 (Exim 4.92) (envelope-from ) id 1pnF5c-0001dM-H3; Fri, 14 Apr 2023 08:47:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521058.809330; Fri, 14 Apr 2023 08:47:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnF5c-0001dF-E1; Fri, 14 Apr 2023 08:47:28 +0000 Received: by outflank-mailman (input) for mailman id 521058; Fri, 14 Apr 2023 08:47:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnF5b-0001ct-66 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 08:47:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9dd0596-daa0-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 10:47:24 +0200 (CEST) Received: from AS9PR06CA0659.eurprd06.prod.outlook.com (2603:10a6:20b:46f::35) by GV1PR08MB9916.eurprd08.prod.outlook.com (2603:10a6:150:a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 08:47:17 +0000 Received: from AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46f:cafe::52) by AS9PR06CA0659.outlook.office365.com (2603:10a6:20b:46f::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 08:47:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT037.mail.protection.outlook.com (100.127.140.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Fri, 14 Apr 2023 08:47:16 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Fri, 14 Apr 2023 08:47:16 +0000 Received: from c47710ec9854.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C7F73050-5D25-4657-B869-090F9DA7FD06.1; Fri, 14 Apr 2023 08:47:05 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c47710ec9854.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 08:47:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB8930.eurprd08.prod.outlook.com (2603:10a6:10:465::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 08:47:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9dd0596-daa0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1d++NwiHA03Rdgvx4zl7hDaFSLq9idxZRGzKkiYsaQ=; b=KSOND7mmVoUPCfp1ACxeWlZEZgIgX/b0u+VRNzQepnoyGBq2Zn0+A9aWHC9O5E+kQux0Sb2MyWbaApz+//eiAOoLW0i2j02xYmHuOnRyBN5YwLSWNXrE5FHM5SJ1pdgVcCH28awOWhj38KD1/u0ZWfh5QHKbZeEK1g5I8k/u2OY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0bf19fa0587feaaf X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DGoZ3ncKsr4whjcAEE/gXRLPPjcd/3NyEwDsZoVWYl/5YuFhs7btof7s3Woa2m0UYAsLM9JBRQJtmgaKI816cBUMf5lyKEWuFgbq/MpX+8FEVfjh6Jo5Nj6KtVOIP4PoIviaXbFx9jUyJBjX4JrkVEmEO68341WiT9/2jItW2NJ6QtF+5bhPZVwfi0ryqRFeKJjbMD7K9BXzZvjxJoZbQLSX8mXGeQhSQqDHzVPh0Vkdd1rls3yupaW8TTIaSSUQAS410KI8KUAMTMkTtqcA6K/c3IMcFQr9V9L3hOJNsd8PCAC0kowsRFG6inNbIaZ13s4QJ8NC2qCfsiG6myOh/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1d++NwiHA03Rdgvx4zl7hDaFSLq9idxZRGzKkiYsaQ=; b=hhJ+7lQrZFbdqxTZbtW6/NkxwiJQtNAR9woyT2ibogfPkIC+p539Qt1ub63ZJWVdvWWlnbc+Wed04/Mib/mtFucPfBFHNuCoC7fwZHX9gW4LUc/0UTZpYc5oh7Cub3i83JpkW6ctPjH19uVerBaDKe6J1I/wMnRozK3dZTHgy/fo2cISowHt88KTMMb7klq/s+9kWfeBG3p5L2PlWrjS1gq5mnF/g6M5JPqLSczs+r9Z4iKGAqlRS37fG0lvCueWILhBHU9PDdqLp7+X5IfIKASB1RWKiaHtR3T+/RbtLGN+VUhhOjXLShhXsdOm5mODbW8CFFu51nc3VkeEHq7daQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1d++NwiHA03Rdgvx4zl7hDaFSLq9idxZRGzKkiYsaQ=; b=KSOND7mmVoUPCfp1ACxeWlZEZgIgX/b0u+VRNzQepnoyGBq2Zn0+A9aWHC9O5E+kQux0Sb2MyWbaApz+//eiAOoLW0i2j02xYmHuOnRyBN5YwLSWNXrE5FHM5SJ1pdgVcCH28awOWhj38KD1/u0ZWfh5QHKbZeEK1g5I8k/u2OY= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v5 06/12] xen/common: add dom0 xen command line argument for Arm Thread-Topic: [PATCH v5 06/12] xen/common: add dom0 xen command line argument for Arm Thread-Index: AQHZbSQvU2J9PUHvFUGvULiLhkcjJK8qgQWA Date: Fri, 14 Apr 2023 08:47:00 +0000 Message-ID: <8796C502-0822-4559-8167-105CDA3B1163@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-7-luca.fancellu@arm.com> In-Reply-To: <20230412094938.2693890-7-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DU0PR08MB8930:EE_|AM7EUR03FT037:EE_|GV1PR08MB9916:EE_ X-MS-Office365-Filtering-Correlation-Id: faa98a15-a307-408f-9197-08db3cc4d993 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9K8gC3MTYYbnKVJUielkADJtvj7YXYmkeN0xMkDa53oiRXuweiY8mhgNKLh7TfxY9YL3HKCPiWQ8Gej2es+opJiIh+5R4Pp3j8iXUlE7iQg92LIa4MlT93byjuGT61S/rFuob9htjz6y9rVFo/hkHVwnhPouEehksAPMvVejPJlqRktvVgyKdEvbxpftpNSnbOBTCISgbLoRLTlbHCQNb/k9B+t2v1053iknBVb320+WPvj3i7iHzrexA/NONO074vJXuOj0JluLCtQQS1CC5FLhHGsskCNVxkyO3xq7YhMc6i+frYEqJcQDBOm4wt1AA8TbLe15zfqRRS+EXBZkGLlekJeaWJxS6tSM841z5vdv4JW2z72qi+WpOlE76RZje3cK+Skh3Dd0/4/5puOJQEx+uxZSI6Nkx4GW+gBy/7Sva6ck6sDkx1n15RuVI/XtTrjIsYFKrWcjEVILA1oXIP7SpWfUuXtSczDs0Atb9l4twsAJWk17m2AgPwLrnCUVk23fnN2L+C90pvF7E6RXgPxdrvBcW/Ql6jf5MjIxVSrUJDvEK8SSUa3UikUhhKyyEonjCOuaBQvwA+kaUUFeKd01XwmjURHc+BxXGOWZK/Ym6YHFVTKQeauIekk4Eflgf06B5QPhj01hOBFtYsHHIw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199021)(8676002)(8936002)(76116006)(91956017)(6862004)(41300700001)(5660300002)(66476007)(66446008)(66946007)(66556008)(2906002)(4326008)(64756008)(122000001)(316002)(6636002)(478600001)(37006003)(54906003)(86362001)(6486002)(38070700005)(38100700002)(53546011)(6506007)(186003)(6512007)(71200400001)(83380400001)(33656002)(2616005)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0A5982B861DE5D4CB675C1279DDF056C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8930 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9d2e52de-d392-4c29-8885-08db3cc4cffd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EO31HU4BPKQn4W+9HlPGkmMs6oH7ug6M0AzA3L9PY0BanFUWNVgkTmzUiv+Il/Eq9Q9HvrrLBR1hwMvR7vT9Bah5F7k0Tqhv49AVle/K/78KjUV7Hgnvyn/PuRvzLJgH0vJfZmhIbKEcS+AthMkzh/SWkMPS3BBGZQeN6tO0KmsMWbl3pJc3nKfJW7neL4n8VuOVDP0XpmZ+XzWXW94TAAkn9jTVxEtOh+u8DdBR11cHA6ArhtFwwqV4qogD2fzQy846Lw5bovJIy4B9Wozu4xWcTfBTIUb9E+DIoJd/uytr5i2E40Q10jII5LxV4Vd5cWEnASHGZeqhVBTmTeVmdSBsk3ydN9Ivg0byVdyt0x0y8dj8se+tWH69qWCPQKu6lil+jX+6xZKkackusmWjRZg1Mmi0qTpm8Z0SmHXJK4K1RA4qIEEhLWPrLCrAc2rwYNhtXoyPjOkesEHsewPp/9MOKY5dasgQQDapSsEHBehdqy+dH4tjH35AhXzt1LP+bpd+JUcVEE5ab6LSbutTkrX6sCb0Anl3nbuoA4UDVs4s1hnNH5IDSeI80E+1qiJ1dqA9uS0f/i0NCZd+JXi4qLb20dv4z3zHC/mk9yl4poMxHr+S19qCHVbu3v2/4A4Sv5mHSgARnPd1gkkSnU8kG2chu9d7NNsxmxCrs/ltQJ7cAlMTVei6FrgYJ0XajHFPLEwiY6XKnr0s6i+psfnC+w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(40470700004)(36840700001)(46966006)(4326008)(6636002)(54906003)(316002)(37006003)(70586007)(70206006)(6486002)(478600001)(5660300002)(6862004)(82310400005)(40480700001)(8936002)(41300700001)(8676002)(36756003)(356005)(53546011)(2906002)(82740400003)(81166007)(86362001)(33656002)(186003)(83380400001)(2616005)(26005)(107886003)(36860700001)(6506007)(40460700003)(6512007)(336012)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:47:16.3703 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: faa98a15-a307-408f-9197-08db3cc4d993 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB9916 Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >=20 > Currently x86 defines a Xen command line argument dom0=3D where > there can be specified dom0 controlling sub-options, to use it also > on Arm, move the code that loops through the list of arguments from > x86 to the common code and from there, call architecture specific > functions to handle the comma separated sub-options. >=20 > No functional changes are intended. >=20 > Signed-off-by: Luca Fancellu > Reviewed-by: Jan Beulich Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes from v4: > - return EINVAL in Arm implementation of parse_arch_dom0_param, > shorten variable name in the funtion from str_begin, str_end to > s, e. Removed variable rc from x86 parse_arch_dom0_param > implementation. (Jan) > - Add R-By Jan > Changes from v3: > - new patch > --- > xen/arch/arm/domain_build.c | 5 ++++ > xen/arch/x86/dom0_build.c | 48 ++++++++++++++----------------------- > xen/common/domain.c | 23 ++++++++++++++++++ > xen/include/xen/domain.h | 1 + > 4 files changed, 47 insertions(+), 30 deletions(-) >=20 > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4f9d4f9d8867..eeb4662f0eee 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -59,6 +59,11 @@ static int __init parse_dom0_mem(const char *s) > } > custom_param("dom0_mem", parse_dom0_mem); >=20 > +int __init parse_arch_dom0_param(const char *s, const char *e) > +{ > + return -EINVAL; > +} > + > /* Override macros from asm/page.h to make them work with mfn_t */ > #undef virt_to_mfn > #define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) > diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c > index 79234f18ff01..9f5300a3efbb 100644 > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -266,42 +266,30 @@ bool __initdata opt_dom0_pvh =3D !IS_ENABLED(CONFIG= _PV); > bool __initdata opt_dom0_verbose =3D IS_ENABLED(CONFIG_VERBOSE_DEBUG); > bool __initdata opt_dom0_msr_relaxed; >=20 > -static int __init cf_check parse_dom0_param(const char *s) > +int __init parse_arch_dom0_param(const char *s, const char *e) > { > - const char *ss; > - int rc =3D 0; > + int val; >=20 > - do { > - int val; > - > - ss =3D strchr(s, ','); > - if ( !ss ) > - ss =3D strchr(s, '\0'); > - > - if ( IS_ENABLED(CONFIG_PV) && !cmdline_strcmp(s, "pv") ) > - opt_dom0_pvh =3D false; > - else if ( IS_ENABLED(CONFIG_HVM) && !cmdline_strcmp(s, "pvh") ) > - opt_dom0_pvh =3D true; > + if ( IS_ENABLED(CONFIG_PV) && !cmdline_strcmp(s, "pv") ) > + opt_dom0_pvh =3D false; > + else if ( IS_ENABLED(CONFIG_HVM) && !cmdline_strcmp(s, "pvh") ) > + opt_dom0_pvh =3D true; > #ifdef CONFIG_SHADOW_PAGING > - else if ( (val =3D parse_boolean("shadow", s, ss)) >=3D 0 ) > - opt_dom0_shadow =3D val; > + else if ( (val =3D parse_boolean("shadow", s, e)) >=3D 0 ) > + opt_dom0_shadow =3D val; > #endif > - else if ( (val =3D parse_boolean("verbose", s, ss)) >=3D 0 ) > - opt_dom0_verbose =3D val; > - else if ( IS_ENABLED(CONFIG_PV) && > - (val =3D parse_boolean("cpuid-faulting", s, ss)) >=3D = 0 ) > - opt_dom0_cpuid_faulting =3D val; > - else if ( (val =3D parse_boolean("msr-relaxed", s, ss)) >=3D 0 ) > - opt_dom0_msr_relaxed =3D val; > - else > - rc =3D -EINVAL; > - > - s =3D ss + 1; > - } while ( *ss ); > + else if ( (val =3D parse_boolean("verbose", s, e)) >=3D 0 ) > + opt_dom0_verbose =3D val; > + else if ( IS_ENABLED(CONFIG_PV) && > + (val =3D parse_boolean("cpuid-faulting", s, e)) >=3D 0 ) > + opt_dom0_cpuid_faulting =3D val; > + else if ( (val =3D parse_boolean("msr-relaxed", s, e)) >=3D 0 ) > + opt_dom0_msr_relaxed =3D val; > + else > + return -EINVAL; >=20 > - return rc; > + return 0; > } > -custom_param("dom0", parse_dom0_param); >=20 > static char __initdata opt_dom0_ioports_disable[200] =3D ""; > string_param("dom0_ioports_disable", opt_dom0_ioports_disable); > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 626debbae095..7779ba088675 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -364,6 +364,29 @@ static int __init cf_check parse_extra_guest_irqs(co= nst char *s) > } > custom_param("extra_guest_irqs", parse_extra_guest_irqs); >=20 > +static int __init cf_check parse_dom0_param(const char *s) > +{ > + const char *ss; > + int rc =3D 0; > + > + do { > + int ret; > + > + ss =3D strchr(s, ','); > + if ( !ss ) > + ss =3D strchr(s, '\0'); > + > + ret =3D parse_arch_dom0_param(s, ss); > + if ( ret && !rc ) > + rc =3D ret; > + > + s =3D ss + 1; > + } while ( *ss ); > + > + return rc; > +} > +custom_param("dom0", parse_dom0_param); > + > /* > * Release resources held by a domain. There may or may not be live > * references to the domain, and it may or may not be fully constructed. > diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h > index 26f9c4f6dd5b..1df8f933d076 100644 > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -16,6 +16,7 @@ typedef union { > struct vcpu *vcpu_create(struct domain *d, unsigned int vcpu_id); >=20 > unsigned int dom0_max_vcpus(void); > +int parse_arch_dom0_param(const char *s, const char *e); > struct vcpu *alloc_dom0_vcpu0(struct domain *dom0); >=20 > int vcpu_reset(struct vcpu *); > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 08:59:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 08:59:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521065.809339 (Exim 4.92) (envelope-from ) id 1pnFGc-0003Dh-Kw; Fri, 14 Apr 2023 08:58:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521065.809339; Fri, 14 Apr 2023 08:58:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFGc-0003Da-Hu; Fri, 14 Apr 2023 08:58:50 +0000 Received: by outflank-mailman (input) for mailman id 521065; Fri, 14 Apr 2023 08:58:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFGb-0003DU-NM for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 08:58:49 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91bb34ff-daa2-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 10:58:48 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id i3so7436687wrc.4 for ; Fri, 14 Apr 2023 01:58:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91bb34ff-daa2-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681462728; x=1684054728; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2bYJqD/lritzgdgYVeCcBDk4S3KIqAcSAF9n6O03bTM=; b=F1QhtALQROLvvngu6FysJm43XIyPpeA8KPqJw74kx67WBcWqoy2fBwKLYCHrAAjUUN dRNJ/5oHnNNnu3TZNpZKidLGEzRi0OZmQ/rHhSa+RCaXu3STu3q6iXCXsI2rhT5fGQ56 oRv1bD5DqQ1WpXS7Rzuz9xMan6wZDobvBQ2klB92MXXJw7pptmDq7SeRJX4qfINxBX+K /boPNqkmd6yVFbPHk86AAF/hENHBGEEqsX3A9k1V417u7vH4srBHohiGf55BAHRSAl5S O38T2eOgmr5OfdtChbDsANzNT+K6QcV3JfP9LIhuGl8BlaDl1x4AZhQnjEvRqzOiXrb5 kJ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681462728; x=1684054728; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2bYJqD/lritzgdgYVeCcBDk4S3KIqAcSAF9n6O03bTM=; b=jZbwAWYMm6SgMF/Y9f6jrJJECUFWbjHq/gmiCQ9RBXfniTwpWOKD0LupbIVps/oC0W ZClOqt6K3R1DGq9UVIdLFwnD3Pyexq5LKli3iO/Sgc9sguGHBNhJjU2THBSc4UQGXcMf nNEKn0gBGmia2BmIkkb6h5RajBuX4u2OOkJk0WZUMkmAZMs2gNhJeFGOim6sNdqhyV8z oqTlBJrTS9fK74WgDygC6EMw1+R1zq2Lsdyoz/jbcaPGKuQW4eDs3yXRqY0PNdbpPY7l ejA1DBWxxART5i2VeHFPLJyKTWhsFwn3vz3dqbF6QlHvmPUaKq8ttui6OCemA7tm6nEr doRQ== X-Gm-Message-State: AAQBX9cEYRdqXBbkVo7r0Imii4JJQlJQx4fiQA6uCrTNbF0c+3gPI+Uc vknRq00Kj3WlyFiX5y0S3APiBeMtbi6PPrdeMF+PTQ== X-Google-Smtp-Source: AKy350atbqUjXHkQy5yQKv9rcJiaNVpf2SH4v1dIDy4x+Y7UPgU3NueaIUJzrzgaOcfU5KwWDuMlFsOxw1rUoBLG1TY= X-Received: by 2002:a05:6000:1e02:b0:2f4:2e72:5bf7 with SMTP id bj2-20020a0560001e0200b002f42e725bf7mr2813000wrb.0.1681462727910; Fri, 14 Apr 2023 01:58:47 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-3-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 10:58:37 +0200 Message-ID: Subject: Re: [XEN PATCH v8 02/22] xen/arm: tee: add a primitive FF-A mediator To: Andrew Cooper Cc: Julien Grall , xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Stefano Stabellini , Volodymyr Babchuk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 13, 2023 at 3:27=E2=80=AFPM Andrew Cooper wrote: > > On 13/04/2023 1:26 pm, Julien Grall wrote: > >> +static int ffa_domain_init(struct domain *d) > >> +{ > >> + struct ffa_ctx *ctx; > >> + > >> + if ( !ffa_version ) > >> + return -ENODEV; > >> + > >> + ctx =3D xzalloc(struct ffa_ctx); > >> + if ( !ctx ) > >> + return -ENOMEM; > >> + > >> + d->arch.tee =3D ctx; > >> + > >> + return 0; > >> +} > >> + > >> +/* This function is supposed to undo what ffa_domain_init() has done = */ > > > > I think there is a problem in the TEE framework. The callback > > .relinquish_resources() will not be called if domain_create() failed. > > So this will result to a memory leak. > > > > We also can't call .relinquish_resources() on early domain creation > > failure because relinquishing resources can take time and therefore > > needs to be preemptible. > > > > So I think we need to introduce a new callback domain_free() that will > > be called arch_domain_destroy(). Is this something you can look at? > > > Cleanup of an early domain creation failure, however you do it, is at > most "the same amount of time again". It cannot (absent of development > errors) take the same indefinite time periods of time that a full > domain_destroy() can. > > The error path in domain_create() explicitly does call domain_teardown() > so we can (eventually) purge these duplicate cleanup paths. There are > far too many easy errors to be made which occur from having split > cleanup, and we have had to issue XSAs in the past to address some of > them. (Hence the effort to try and specifically change things, and > remove the ability to introduce the errors in the first place.) > > > Right now, it is specifically awkward to do this nicely because > domain_teardown() doesn't call into a suitable arch hook. > > IMO the best option here is extend domain_teardown() with an > arch_domain_teardown() state/hook, and wire in the TEE cleanup path into > this too. > > Anything else is explicitly adding to technical debt that I (or someone > else) is going to have to revert further down the line. > > If you want, I am happy to prototype the arch_domain_teardown() bit of > the fix, but I will have to defer wiring in the TEE part to someone > capable of testing it. You're more than welcome to prototype the fix, I can test it and add it to the next version of the patch set when we're happy with the result. Thanks, Jens > > ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Apr 14 09:02:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 09:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521070.809352 (Exim 4.92) (envelope-from ) id 1pnFK3-0004gj-4Q; Fri, 14 Apr 2023 09:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521070.809352; Fri, 14 Apr 2023 09:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFK3-0004gc-13; Fri, 14 Apr 2023 09:02:23 +0000 Received: by outflank-mailman (input) for mailman id 521070; Fri, 14 Apr 2023 09:02:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFK1-0004fJ-J3 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 09:02:21 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 107cb59b-daa3-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 11:02:21 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id v27so7545821wra.13 for ; Fri, 14 Apr 2023 02:02:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 107cb59b-daa3-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681462940; x=1684054940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ocke09pCVF1SRzVO7CZh1DeCa3giZ7bYqQybME6Jk/o=; b=d9Dkol2SQp6LyvvfSh6sz8SQIy/Y4jdNGzPpL0jrhGB6vdxmXMUeT1UZNeb3ECE1cY Tsoqr1/DQqEYrAyRhyrDYBIqri1XhKt8UJba7yenr5zOG2YXeCA/VuSfHEBWEddWuOA3 qt3+ShuoUlZUjtxmF0eYqqy9ywf0vxDm3ZORxPeJckC6FGa0QJ+GY17b2pnQW8DthuVa zkL8V79vHmBfMJfruLg3d15zm47BA/WLxOE9VwkSMakiUnt6DWSbZTwTXzAZtnOAGMvp wq9dxDElmA/t+quRPtxrBd3ManFUGYqmNRVDaGGyth+KfYMd8LMX+QHMks4hoiAI8XnP wrxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681462940; x=1684054940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ocke09pCVF1SRzVO7CZh1DeCa3giZ7bYqQybME6Jk/o=; b=VGtOYtXCJp1f4IMKWJe5jBzWDesIEhjHB731YAb6Ebl7J1lCKoqwXNMRu+wU9o3nkz zfKenGWTGD1mtY+uRll1fckuAMvQPhAHlpCjFJuwxIthq6wjKL0A3NxXvwIj8RVh9XIl 1QZspTV2cPKDaLiFFhBwD6hniiPnENDVtmiE+D/STzBYScYhEwvRYRgJKJZYI2Leyt9J UwPMNRntjhlSV0kygmpx39KHVFZbYNPzL6j9yQ0RMH405mx7HatXpn98rDcBN+WvxGGh CKRgahdYhpR9pwq05aFAH/oPnaxOkFk0DKAgWVFixOIxY8NWBIQ/xI8m+ZV1mPmISXMJ 07IQ== X-Gm-Message-State: AAQBX9cG8wpbhRgwrM+3eYcF4byhELOrpuVhT2uB2sMHQemfQpLRgaTA cR1Q45dnI+dBib9BtnKOP6emeCzHlzF/JX1hrAAkHFip1Q67FuOF X-Google-Smtp-Source: AKy350a/YvgC3+sORWjYf1mdBFgj5RF2hg9YrRLfVC/y9qxUJm/ZJaYPS2L1UEt1PO5Ce8As5NBhCe8mSVaHCaHQgHY= X-Received: by 2002:a05:6000:1e02:b0:2f4:2e72:5bf7 with SMTP id bj2-20020a0560001e0200b002f42e725bf7mr2815992wrb.0.1681462940494; Fri, 14 Apr 2023 02:02:20 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 11:02:09 +0200 Message-ID: Subject: Re: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 1:16=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support > > > > Adds support for sending a FF-A direct request. Checks that the SP also > > supports handling a 32-bit direct request. 64-bit direct requests are > > not used by the mediator itself so there is not need to check for that. > > > > Signed-off-by: Jens Wiklander > > --- > > xen/arch/arm/tee/ffa.c | 112 > > +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 112 insertions(+) > > > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > > index f129879c5b81..f2cce955d981 100644 > > --- a/xen/arch/arm/tee/ffa.c > > +++ b/xen/arch/arm/tee/ffa.c > > @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) > > return true; > > } > > > > +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > > +{ > > + switch ( resp->a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp->a2 ) > > + return resp->a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + return FFA_RET_OK; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t= a2, > > + register_t a3, register_t a4) > > +{ > > + const struct arm_smccc_1_2_regs arg =3D { > > + .a0 =3D fid, > > + .a1 =3D a1, > > + .a2 =3D a2, > > + .a3 =3D a3, > > + .a4 =3D a4, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_features(uint32_t id) > > +{ > > + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); > > +} > > + > > +static bool check_mandatory_feature(uint32_t id) > > +{ > > + int32_t ret =3D ffa_features(id); > > + > > + if (ret) > > Coding style nit: You need spaces before and after "ret", i.e. > if ( ret ) > > With this fixed: > > Reviewed-by: Henry Wang I'll fix it. Thanks, Jens > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 09:05:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 09:05:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521076.809362 (Exim 4.92) (envelope-from ) id 1pnFMr-0005LP-MB; Fri, 14 Apr 2023 09:05:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521076.809362; Fri, 14 Apr 2023 09:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFMr-0005LI-JY; Fri, 14 Apr 2023 09:05:17 +0000 Received: by outflank-mailman (input) for mailman id 521076; Fri, 14 Apr 2023 09:05:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFMp-0005LC-Mg for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 09:05:15 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 772846a3-daa3-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 11:05:13 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id w24so7165558wra.10 for ; Fri, 14 Apr 2023 02:05:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 772846a3-daa3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681463113; x=1684055113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d1NtzKB2dYRlHM4v+m7fmPEZevPOYyQOjqzKBr2cZNc=; b=MWjWLVNsR9nF6e/Jinh5Pe6+jUSYad4kMBt0Er533MN9PQ48cIp67Qty5vYXGIYZBR 9KU8dG6d8NXtYhefvQxkAl5vcORqDk6+Tx60D/Ws//6u+UHJG1lDo/tpHrueT/2MmA1v CSorithRHr8LKOxwB/jSloLIK6uwbxdKRSoNZYCj3xxtP8eDjGIbEZQKpabiMyKNu4zy TLWXgwQv3Ohy6f495dWvAF+uVInDO6NXGaUY6DmzGivOynK2YFsmXR/Ks5ZEDtTxTfyK 0tQ88jLk0mQc4OdI8jvuN/OY+um+7gUOOtxEXQ/YXWVx/4fSLbFDwo4DBJioWJ1kzFrl l6PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681463113; x=1684055113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d1NtzKB2dYRlHM4v+m7fmPEZevPOYyQOjqzKBr2cZNc=; b=F2Gs6oYr8r5BL8VQcmbDQ3qph7XJ+XSdUJwPhvNbkDIg9Dx0Flbl57RnbpMxrgfuRS 89/R2bQ0B3Ka8JRs9Oui8IR2qOlEKQIw/D4q7dbSX3Wj4OaRXthx5EiIZ2WSFbMpftBd JFqIXvPVLykwitjyirUWtFXAOsSYVWHAkV0lvt17Yn2A74hJTnZCXXcSW3jmX7Y5m9p2 9rxoKa+7a2FoLr+VUPSDhDLNv57Ul7a05nBVFHiNlf2UsM+BklOId47shNIXvbwH1lkE 3yuWo94ZifCKlOuRxOjVT/voDYuaneCB1pYV77vGn3t73fyA+T4iiA7i/rga6sZiyTJN SB/A== X-Gm-Message-State: AAQBX9dIImUIVMr9k//2YyQ3pHtJQ9e9iwaidFOcuVA6i1xb2Pjk4fPB nFWCVhh3I9BLlNG3WErmB/0c1i9w+TQsv4McDHVnrd9Qh7/G1YPY X-Google-Smtp-Source: AKy350YoO09EabljTMkZJPCnVZy+a6Up4B8ihxRxUzUZg5OQ94doL5DgUB4CMxbdHjlgyhbwDz45pLGCfvQGglWn1OA= X-Received: by 2002:a5d:4441:0:b0:2c7:17b8:5759 with SMTP id x1-20020a5d4441000000b002c717b85759mr902302wrr.3.1681463112669; Fri, 14 Apr 2023 02:05:12 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-10-jens.wiklander@linaro.org> <2359695e-f8f8-cf51-27f9-5f0c776feca5@xen.org> <916BB708-3028-4AAB-BD6A-BCABAFBD7C45@arm.com> <2dba6372-330d-a068-241f-59e19b837150@xen.org> <0B0212E8-BAC7-4557-B21B-B49EB14F1D09@arm.com> In-Reply-To: <0B0212E8-BAC7-4557-B21B-B49EB14F1D09@arm.com> From: Jens Wiklander Date: Fri, 14 Apr 2023 11:05:01 +0200 Message-ID: Subject: Re: [XEN PATCH v8 09/22] xen/arm: ffa: add direct request support To: Bertrand Marquis Cc: Julien Grall , Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 13, 2023 at 3:44=E2=80=AFPM Bertrand Marquis wrote: > > Hi, > > > On 13 Apr 2023, at 15:27, Julien Grall wrote: > > > > > > > > On 13/04/2023 14:20, Bertrand Marquis wrote: > >> Hi Julien, > >>> On 13 Apr 2023, at 15:15, Julien Grall wrote: > >>> > >>> Hi, > >>> > >>> On 13/04/2023 08:14, Jens Wiklander wrote: > >>>> Adds support for sending a FF-A direct request. Checks that the SP a= lso > >>>> supports handling a 32-bit direct request. 64-bit direct requests ar= e > >>>> not used by the mediator itself so there is not need to check for th= at. > >>>> Signed-off-by: Jens Wiklander > >>>> --- > >>>> xen/arch/arm/tee/ffa.c | 112 ++++++++++++++++++++++++++++++++++++++= +++ > >>>> 1 file changed, 112 insertions(+) > >>>> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > >>>> index f129879c5b81..f2cce955d981 100644 > >>>> --- a/xen/arch/arm/tee/ffa.c > >>>> +++ b/xen/arch/arm/tee/ffa.c > >>>> @@ -181,6 +181,56 @@ static bool ffa_get_version(uint32_t *vers) > >>>> return true; > >>>> } > >>>> +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *r= esp) > >>>> +{ > >>>> + switch ( resp->a0 ) > >>>> + { > >>>> + case FFA_ERROR: > >>>> + if ( resp->a2 ) > >>>> + return resp->a2; > >>>> + else > >>>> + return FFA_RET_NOT_SUPPORTED; > >>>> + case FFA_SUCCESS_32: > >>>> + case FFA_SUCCESS_64: > >>>> + return FFA_RET_OK; > >>>> + default: > >>>> + return FFA_RET_NOT_SUPPORTED; > >>>> + } > >>>> +} > >>>> + > >>>> +static int32_t ffa_simple_call(uint32_t fid, register_t a1, registe= r_t a2, > >>>> + register_t a3, register_t a4) > >>>> +{ > >>>> + const struct arm_smccc_1_2_regs arg =3D { > >>>> + .a0 =3D fid, > >>>> + .a1 =3D a1, > >>>> + .a2 =3D a2, > >>>> + .a3 =3D a3, > >>>> + .a4 =3D a4, > >>>> + }; > >>>> + struct arm_smccc_1_2_regs resp; > >>>> + > >>>> + arm_smccc_1_2_smc(&arg, &resp); > >>>> + > >>>> + return get_ffa_ret_code(&resp); > >>>> +} > >>>> + > >>>> +static int32_t ffa_features(uint32_t id) > >>>> +{ > >>>> + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); > >>>> +} > >>>> + > >>>> +static bool check_mandatory_feature(uint32_t id) > >>>> +{ > >>>> + int32_t ret =3D ffa_features(id); > >>>> + > >>>> + if (ret) > >>>> + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing: e= rror %d\n", > >>>> + id, ret); > >>>> + > >>>> + return !ret; > >>>> +} > >>>> + > >>>> static uint16_t get_vm_id(const struct domain *d) > >>>> { > >>>> /* +1 since 0 is reserved for the hypervisor in FF-A */ > >>>> @@ -222,6 +272,57 @@ static void handle_version(struct cpu_user_regs= *regs) > >>>> set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > >>>> } > >>>> +static void handle_msg_send_direct_req(struct cpu_user_regs *regs,= uint32_t fid) > >>>> +{ > >>>> + struct arm_smccc_1_2_regs arg =3D { .a0 =3D fid, }; > >>>> + struct arm_smccc_1_2_regs resp =3D { }; > >>>> + struct domain *d =3D current->domain; > >>>> + uint32_t src_dst; > >>>> + uint64_t mask; > >>>> + > >>>> + if ( smccc_is_conv_64(fid) ) > >>>> + mask =3D GENMASK_ULL(63, 0); > >>>> + else > >>>> + mask =3D GENMASK_ULL(31, 0); > >>>> + > >>>> + src_dst =3D get_user_reg(regs, 1); > >>>> + if ( (src_dst >> 16) !=3D get_vm_id(d) ) > >>>> + { > >>>> + resp.a0 =3D FFA_ERROR; > >>>> + resp.a2 =3D FFA_RET_INVALID_PARAMETERS; > >>>> + goto out; > >>>> + } > >>>> + > >>>> + arg.a1 =3D src_dst; > >>>> + arg.a2 =3D get_user_reg(regs, 2) & mask; > >>>> + arg.a3 =3D get_user_reg(regs, 3) & mask; > >>>> + arg.a4 =3D get_user_reg(regs, 4) & mask; > >>>> + arg.a5 =3D get_user_reg(regs, 5) & mask; > >>>> + arg.a6 =3D get_user_reg(regs, 6) & mask; > >>>> + arg.a7 =3D get_user_reg(regs, 7) & mask; > >>>> + > >>>> + arm_smccc_1_2_smc(&arg, &resp); > >>>> + switch ( resp.a0 ) > >>>> + { > >>>> + case FFA_ERROR: > >>>> + case FFA_SUCCESS_32: > >>>> + case FFA_SUCCESS_64: > >>>> + case FFA_MSG_SEND_DIRECT_RESP_32: > >>>> + case FFA_MSG_SEND_DIRECT_RESP_64: > >>>> + break; > >>>> + default: > >>>> + /* Bad fid, report back. */ > >>>> + memset(&arg, 0, sizeof(arg)); > >>>> + arg.a0 =3D FFA_ERROR; > >>>> + arg.a1 =3D src_dst; > >>>> + arg.a2 =3D FFA_RET_ABORTED; > >>>> + } > >>>> + > >>>> +out: > >>>> + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3= & mask, > >>>> + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a= 7 & mask); > >>>> +} > >>>> + > >>>> static bool ffa_handle_call(struct cpu_user_regs *regs) > >>>> { > >>>> uint32_t fid =3D get_user_reg(regs, 0); > >>>> @@ -239,6 +340,10 @@ static bool ffa_handle_call(struct cpu_user_reg= s *regs) > >>>> case FFA_ID_GET: > >>>> set_regs_success(regs, get_vm_id(d), 0); > >>>> return true; > >>>> + case FFA_MSG_SEND_DIRECT_REQ_32: > >>>> + case FFA_MSG_SEND_DIRECT_REQ_64: > >>>> + handle_msg_send_direct_req(regs, fid); > >>>> + return true; > >>>> default: > >>>> gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); > >>>> @@ -326,6 +431,13 @@ static bool ffa_probe(void) > >>>> printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > >>>> major_vers, minor_vers); > >>>> + /* > >>>> + * TODO save result of checked features and use that informatio= n to > >>>> + * accept or reject requests from guests. > >>>> + */ > >>> > >>> I am not entirely sure I understand this TODO. Does it mean a guest c= an currently use a request that is not supported by FFA? > >> In fact this is a bit the opposite: in the following patch we check th= at all features we could need are supported but if a guest is only using a = subset we might not need to have all of them. > >> Idea of this TODO would be to save the features supported and refuse g= uest requests depending on the features needed for them. > > > > Thanks. I would suggest the following comment: > > > > /* > > * At the moment domains must supports the same features used by Xen. > > * TODO: Rework the code to allow domain to use a subset of the features > > * supported. > > */ > > > > Note that I am using "domains" rather than "guests" because the latter = doesn't include dom0. > > Makes sense and new comment is nice. That's better, I'll update it. Thanks, Jens > > Up to Jens to say if he is ok with it. > > Cheers > Bertrand > > > > > Cheers, > > > > -- > > Julien Grall > > From xen-devel-bounces@lists.xenproject.org Fri Apr 14 09:25:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 09:25:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521081.809372 (Exim 4.92) (envelope-from ) id 1pnFg5-0007kU-AA; Fri, 14 Apr 2023 09:25:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521081.809372; Fri, 14 Apr 2023 09:25:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFg5-0007kN-7Q; Fri, 14 Apr 2023 09:25:09 +0000 Received: by outflank-mailman (input) for mailman id 521081; Fri, 14 Apr 2023 09:25:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnFg4-0007kH-Mz for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 09:25:08 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e490ea5-daa6-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 11:25:06 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso14546482wmr.0 for ; Fri, 14 Apr 2023 02:25:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e490ea5-daa6-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681464306; x=1684056306; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Pe0+F4NozuXBYn50mLdDfoIjRN8vhOuduj2ngocD7Sw=; b=ypycx2m+3sLbqN7qTe/OMw3H1gPasVHi0uRo4EUo4dZPm6wOICpQx9x9rMYxTJ0aUd N/QLJh5NupB+k5AdSO7PLbPDMNtrYFvlX/3byQ1rmeKf1xTQH0NDeBj4Hj1AwTbLJK2+ v3k2gH2oGsfTM6lusSjyQXt7f5gnvHCQN5dQqooTMfiqdRYhgiNOXzoIzt42JJRCaEZr clh5Kg+Y+cEhS782BNamgTYYq4nV4xgLpSykuMS1M405NGPFo/aiMrAHo0zT5Zn0h/M/ dXz0BlOo1XmQc0kGdS51ZR0Oa/7uwJL0YugulgMLC/nmC8Wp9UmWVs+IASvOnOiN2g/O xApg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681464306; x=1684056306; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pe0+F4NozuXBYn50mLdDfoIjRN8vhOuduj2ngocD7Sw=; b=gyTEoXRzCaa2O4qsCJQsmMrMHYgTcmauGm3FerrMDd1r3w2z6lMUgGGUBTZb914Zyi kYF8VRwV0+MRZvAp9Uj1rEE4/80S7WMZgEUGHN5hOqFVF4Z4mqh3UHpw1JaG0Yt2MYlQ ba9JN5b5t+4cbS0Q/7/IWz5TwECu0gcXbvEm3XMJQ3IrJthiJ7PWF2APRK4sED+Sqvm3 hj54azjzAiS+BR6xsR7+4G/dJ7NFGXVksFxbEYbSeDn4RePaTEaFfndOFrNEBLS6CJkg uX+cnulKCifJQhCt0XyAvfpc3pK3xSvnkjExsbEPsQbfRqlqT8nTL06occxqWneRYaim PENQ== X-Gm-Message-State: AAQBX9cSu57o4Ui0A7PkIjbFfR4X7FNWr2PA5KgcxubiWiXxWMCaIhNZ rPxB4rfuxawall60Yzy6tVavJlw74ubW2zgPPsDCPQ== X-Google-Smtp-Source: AKy350aPZQFYIgxccfqLSGBHoPPFt6UbuzdwW6MFbQz340GnRRYB4WmiwIWjrlkRdji++vMuWKc3YQQuV4KkfzTfKnM= X-Received: by 2002:a1c:f302:0:b0:3df:97de:8bab with SMTP id q2-20020a1cf302000000b003df97de8babmr1215506wmq.4.1681464305829; Fri, 14 Apr 2023 02:25:05 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-6-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 11:24:55 +0200 Message-ID: Subject: Re: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Henry, On Thu, Apr 13, 2023 at 3:53=E2=80=AFPM Henry Wang wro= te: > > Hi Jens, > > > -----Original Message----- > > From: Jens Wiklander > > Subject: Re: [XEN PATCH v8 05/22] xen/arm: ffa: add flags for > > FFA_PARTITION_INFO_GET > > > > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > > > > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > > > > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > > > > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > > > > +#define FFA_PART_PROP_IS_MASK (3U << 4) > > > > > > I am a bit confused here, here (3U<<4) is "IS_MASK" but... > > > > > > > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > > > > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > > > > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > > > > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) > > > > > > ...here the same value is used for "IS_AUX_ID". According to > > > the spec that I referred to, bit[5:4] has the following encoding: > > > b'11: Partition ID is an auxiliary ID. Hence I guess the above > > > "IS_MASK" should be removed? > > > > FFA_PART_PROP_IS_MASK is supposed to be used when extracting the bits > > to compare with one of the other FFA_PART_PROP_IS_* defines. For > > example: > > if ((props & FFA_PART_PROP_IS_MASK) =3D=3D FFA_PART_PROP_IS_PE_ID) > > Ohh I now understand, the naming does not mean it "is a mask" but actuall= y > means "this is a mask for FFA_PART_PROP_IS_". That makes a lot of sense. > > To avoid this kind of ambiguity, do you think changing the name to someth= ing > like "FFA_PART_PROP_IS_TYPE_MASK" makes sense here? Note that this > is just my suggestion, you can decide to change or not, I am asking just > because I downloaded the whole series and found that currently > FFA_PART_PROP_IS_MASK is not used anywhere, so before it is used everywhe= re > in the code, it might be good to use a more clear name. > > > > > using > > if ((props & FFA_PART_PROP_IS_AUX_ID) =3D=3D FFA_PART_PROP_IS_PE_ID) > > > > doesn't seem right. > > Indeed. Please see my above reply. > > Personally after the above clarification, I am good with the patch, so: > > Reviewed-by: Henry Wang I'll update it as you suggest. Thanks, Jens > > Kind regards, > Henry > > > > > > > > > I confirm the values of other fields are consistent with the spec. > > > > Thanks, > > Jens > > > > > > > > Kind regards, > > > Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 10:12:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 10:12:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521088.809383 (Exim 4.92) (envelope-from ) id 1pnGPh-0004bf-SY; Fri, 14 Apr 2023 10:12:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521088.809383; Fri, 14 Apr 2023 10:12:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnGPh-0004bY-PY; Fri, 14 Apr 2023 10:12:17 +0000 Received: by outflank-mailman (input) for mailman id 521088; Fri, 14 Apr 2023 10:12:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnGPg-0004bS-1I for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 10:12:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d17f5c1b-daac-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 12:12:13 +0200 (CEST) Received: from mail-dm6nam04lp2043.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2023 06:11:16 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6016.namprd03.prod.outlook.com (2603:10b6:5:38b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 10:11:14 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Fri, 14 Apr 2023 10:11:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d17f5c1b-daac-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681467133; h=date:from:to:cc:subject:message-id:mime-version; bh=PFzL6PE3tO1+kG4mMgi3nA4szToEfZC1w+ZwpnUL/M8=; b=M+GyGvr4b/lahC4qGVh7+NhPmfNxsdCdS4X3HMw5rlnOK1Lkw4NdO6xu UGOVqRkunntDd8bSSBRUOd5X1fe+k4XstXqKuHkpQ7OUgP/ScpvWqOatS 8Npz0jX8oKvan/5qCx8W7M9T6m2iEgTDvhpzER1f0wJ3LP6qOU2l7yt4P Q=; X-IronPort-RemoteIP: 104.47.73.43 X-IronPort-MID: 105910295 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:G8vb4aMGxV6OetjvrR2klsFynXyQoLVcMsEvi/4bfWQNrUp01zcBz TYdXWjXMviKa2uheNkgOoi08x9Su8fQnNZnHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tE5wBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vZRHiZWq vE1FD4ITxDTpOK/3LPja+Y506zPLOGzVG8ekldJ6GmFSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxvzO7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqi/937eVzH6TtIQ6T5OWytFI0H6v1mEvFTYqdVW+sN6DsxvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxO4QfZjtIadhjuMpoQzUvj gONh4mxWWcpt6CJQ3WA8LvStSm1JSUeMW4FY2kDUBcB5N7g5oo0i3ojU+peLUJ8tfWtcRmY/ txAhHlu71nPpabnD5mGwG0= IronPort-HdrOrdr: A9a23:cMdDRai5a5e7VIBUSy6ubG1Bv3BQX2V13DAbv31ZSRFFG/FwyP rPoB1L737JYWgqNk3IwerwQpVoMkmsiKKdgLNhd4tKMzOWwFdAQLsSiLcKzgeKJ8SczJ8R6U 4DSdkENDSYNzET56uXj3jaYrQdKbG8geeVbIzlvhBQpHRRGthdBnBCe2Cm+yNNNW17LKt8Ob +kovBMrz2mdXl/VLXjOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPsf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFctcsvy5zX4ISdOUmRYXee r30lQd1gNImjHsl1SO0FrQMs/boXMTAjHZuBulaDDY0LDErXoBerV8bMRiA13kAgMbza9B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6qjYvf+rqGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRG+dA== X-Talos-CUID: =?us-ascii?q?9a23=3AWoxKjmhg+iAhTCpKrGp/B7TGOTJuYlvCi2+PLmK?= =?us-ascii?q?EB2NISO22SVaM+ftFnJ87?= X-Talos-MUID: 9a23:RrXPbgvXWFIIAH+yNM2n3x9MCOhKs4eSGE0xjL46m8eBJAtKAmLI X-IronPort-AV: E=Sophos;i="5.99,195,1677560400"; d="scan'208";a="105910295" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYBc2yf3qLsbeRFSjIXzZL5drvCdX5zf5eCMoBx/ZmcVFwi/ZwR2sWU7UzzgOdPRzYWanJQDU98FUMEtYpPd2zW5eTUd1ruYGmRVDxc88CxVhhy+/0PEkOnJIpf+I2v03E8KfubsLfJ7FMPgpdTpF/TYIcz3N6Zuorlll6fDbJD8NvOfW0EZ7KsAXuVFXKwvjQ72oSORY7YRSB6mZ7Bks4/8I9ToRRy0u+YdBeln2exOdxVqjrdmTvbBBGzdScdN3PZVRNv+kkXLmnkmRrDNQsIT4puZWQ/PqNuSAWJzJJdhU+r1ybCAVNnV3zJu/hQ3QvkOeJc4PNOLEOabjL++1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFzL6PE3tO1+kG4mMgi3nA4szToEfZC1w+ZwpnUL/M8=; b=Rvpv1aWSs4louvQAmCXKE6gAZfauPHvo7r9dW/kYjjmWWI3ep4m9ZfAFxuaSH/qSgEcq2/3ma5Cvi61FxodSHgbmbzRfWpJL+dogGCSKMX2ZPxdYNZlyo+zg2Ead8wGt4fUemGmvEoFib/aXsrjEG2SdPcos6DWwjQAhIuYoU1vP4AiDV4j0/DUrvffVNmxBqL7gbrWRwsSwxLem7cOztGnjyibU4soCHRpYcELH6eXrZTjNoTW4ntOfzsCGYQpoj2G+CkPmaon3mzCRlFk8MW/cblaw5CKAkW2Kq8gY7DHaLUsOqv/BCuUpCzfDuhWU8mLlxqqwkKM7SMqO/+NEew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFzL6PE3tO1+kG4mMgi3nA4szToEfZC1w+ZwpnUL/M8=; b=gVnzKdamybghucgIsk/kzjMJ3gtl5m5XVubf+lW1Bb2wdVWj6+2Z3KgTYxA2EVES50qxxODEd72sjrL0DWTORgVQZqdDz72uBzvv3Uupluq4HDYNHVQEIEgCaQqTBa2wtGlcizqEChYdaIU+01IqufpsSSZOiMtNGPl4gPZjygc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 14 Apr 2023 12:11:07 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org Cc: Anthony PERARD Subject: HEADS UP: re-adding the armhf boxes to osstest Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-ClientProxiedBy: LO4P265CA0078.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::7) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6016:EE_ X-MS-Office365-Filtering-Correlation-Id: cef0a9ef-0637-41f6-3ac2-08db3cd093a2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aQ86P+FbCCghPJS6gVwaoLIv5fLm+Fa+1b5lnxY9gvF1RkFi4/hZg9sx51Nv38DPQz0lf1lPH/wv+k7trAUc/Ha+GVUGOrB4Dk1u511AQNnwz+L3mnjaI6RVdKhPd1hh+9hN2NvqvTzhBZpZrjUgk99WAaCXRoz3ic8cHNBabE+IGDc+E6JFHEsoWySkJxSLIt+GGIU1rP+p/4xFfl2WK6X77D7PtmtvWRqClvo2JKpB+brniYjjhe14a+nr7kyz2PmFFmtXaa0gIXQf4inpGnEOmTcKd/Danefg2+YCPGKS78WODFbNuD9zzUcbT1+GunyLf1jnDaTiEFZa8INkjbatSHgLlwMk2H7lIzwNLlGoMeW/wmFc0EAGb90hjfzHwD1lsVq7FpMhml6sRqj4zsoj+lFnsG5uu0mk8Gl0V8MmHMOHWh1YmevNORoJe2IEdWGfoK0xXrOrYmN6vR45+UpZfLXMqI3EUSssEAQUdwYXKEI2GJ5odBwitCcDAissNf+GaV96qqA0rJ8s69i+kMIVzIsjGqfz+V0jeu7XeCbVPWVlhDgqWN3emHOh/xTL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199021)(6666004)(6486002)(4744005)(6916009)(66476007)(66556008)(85182001)(66946007)(4326008)(2906002)(33716001)(86362001)(38100700002)(41300700001)(82960400001)(5660300002)(8936002)(8676002)(316002)(478600001)(9686003)(6512007)(6506007)(26005)(107886003)(186003)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjBFNnB1aitxalB3SFAySjFaTUYxSzhWUHRVZTkwdFZIQVh1cWhNUXJ2dFFa?= =?utf-8?B?VDR4RGZqRkFEbmk0REFVRi91Zk0wY0xkYURrVlNmNWl5R1F6RU5DeHRiZERH?= =?utf-8?B?NXVVbmxRTzNHdTFld0cxb0cwWnl6dTZVOUhhZDh3U3drYXI4Y25QelJhdEtZ?= =?utf-8?B?WnVJSFRmcjhHOEZwWEI5bDAwMGVvWnBkTzVmYWtGZERaaGoyVnZqMDAwOFVM?= =?utf-8?B?dXdPV1ZCWW9OOVc4RUpLYlV2WlhxMjE0eXoreWJRekFpMHRuWWozcTYwcWY4?= =?utf-8?B?M2xWbXRxaWt2YVZ6MEdrR3drdCsrdDhKL2hUb1p5YUJyY05hTzlkRE8rd2Ew?= =?utf-8?B?cnhrcVZ6VmJuSVJnai9HSVNVYWFUVkNCczlYZ0tlei9Pekx3SThiV1l2ZHAy?= =?utf-8?B?MGFIblNDN1hCTDN3Q0JvaDZ3TDZSM0cxalVrWXBLVENpMGxiK3ptR2xmVzNs?= =?utf-8?B?c1VnVGJLeEtsdzR0T3JzRHNzVGNHYWZGNEEvR3ZkNk9pNjJ3M1JVSFZibzBo?= =?utf-8?B?a3JPd0xFZFM5YnIwU0dtRTFmWjNsQXdCaWcxcWExQTFVWDVaY3BnVU5aS29I?= =?utf-8?B?cUJCVjRtdmpCeUFyL2o3bGJGamtZNTEwTi9hSmtnOVhJdStwMFdFa3VuMjNF?= =?utf-8?B?a0t4VkxNR1pHMFVHQTlLREVMWGF5cnhEamdsdlp1a3RtUU90VzhPeEU1aGFU?= =?utf-8?B?ZHlEbEhVbEt0dm90TWZEKzNlZGt0azRCUm0zWWdJRDZLN3FOYWFBcXpES1hh?= =?utf-8?B?UjFqZWhjNEREQjdnakhZd09YUE44TnF3b3pOMDA2WEtNdjNsNk4zQU9lOFdh?= =?utf-8?B?cnUyQzBHanM3STlRSllhQlhIMWpFWFN1ditNTzl4MnZDTnVhMmtXdGJxdmls?= =?utf-8?B?eGdXQ044TldnN3hzMCtKUTF2MldCZHdWVzFTOG92RzVoZTZtc3lLSFoyUDgv?= =?utf-8?B?c1BHTktrbm51dGZ0MnI2SjBOaHVxSC9BVmZmK3AwTFB4Vmh0Ym9KK08yTFRI?= =?utf-8?B?bDZXMnRYb29EU3VYWFhQeWFGbmkrODdwQlVGT3Q0K3YrN2w3c1RPVFhGNUp4?= =?utf-8?B?Vlk5cGpjU2Y3VHZtOG9GOVFkUThQWEc0V2JxTFdCV1dvWWFWcDVQMFBTcHJF?= =?utf-8?B?UU1KWU9NUStybS9LNXlGRURJSzBSczQ0cHZySjF2WWw5Uk1haWZwWE9hZG9C?= =?utf-8?B?bkEyOWw0cjZvaytVelI0bTFtT2ZzOEZTbWhkcW5IQndZVjJlTzFWNlVPMVps?= =?utf-8?B?NDk0YlFYcWI3Tk1MSU41SFlSUStNcW1GVDBoV0FkdVJ5RHk5by9XcVlJUUlN?= =?utf-8?B?bitXSFZLT0Jrd3ZlbkdPbEhScVRkcXczalJHMkgzRlZnd1Q4cllPbDUxWW8v?= =?utf-8?B?KzNKMlRZd1pTelBUNDhLdG9lbjRpeHhqekVIcFIxYlpKWFZHS1hod05ydVZV?= =?utf-8?B?Y21BR3VZSXBaVHZSV0JRRTk2Nm1pd2s3d2lvVXFjVy8vS1N3cjZjaEpuSFZF?= =?utf-8?B?dUxUc1ZlRHpydHRwNnd3aGJoMGdmczdUY1hWeUJUUkw3c1Z4bVNJOEVMZXZ3?= =?utf-8?B?dWZTK3BKUS95VXdxTE5vNG9YeWN1Nmp2LzJqUG9aVkp3R0pVYmJOeGRtVUE0?= =?utf-8?B?cFpLUVc5SlZUK09OcjhFaTlORXRRQ3ZySERCY2NsT3VnUWJSaEZES3lFbThU?= =?utf-8?B?MzBlTmQvQzZlWUN6cHRJemVyT1pBK0FWYnlGdndQR2JJa2tvZytrTGNRWDJv?= =?utf-8?B?MGZiTFppTVYrUGtTanZEeGtxRVIvSWJ2aEpRcEQ3MFJWSHJpQjRBZnh2Z1Jk?= =?utf-8?B?V05GNVhRSVY0bi8zSTBXNmhySEtUR1dHa1E0ZHRxMElSSFpBTFBMZEh6bElw?= =?utf-8?B?cGthcDdiZVZSbmNYci9LTjVLcVIwQU9mZWhlYkQvcW9KcHdCK3UwOG9mSUly?= =?utf-8?B?MElXa0MrTHRDM2JYOHEvYjlhUEFCOXZZR1ExQk1iM0FBL0luSStmclBTOEpE?= =?utf-8?B?aE8rakR5ZWUrWkxlKy90aFJqSndPUzQ2Z0VLWXkzd1I0SVJGRzVDcVJtNkds?= =?utf-8?B?RThQeGpOWlBiTnZWRXNFSGVYeFkxWndqbmNQLzZWMFR4Rmtlc2M4V0s1M2Zl?= =?utf-8?Q?4Llk46QVnDBpceISOzdZNc6If?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fa+ib7boHG9ZCXXBmlkJRPeA6G6nETkNDnHNNUsrYPaY4MY8/3sA/Eq1Yg0Hte6a7kuLQrBR1uy+Nstyg6djs7I/VD2uSbed/COlvPDI4xFE9YMkJwIVPxAgEJD8LRFRgIT+bKiNK452wYDXlWMJ+kxWqDL/RgIxYqInCI6ThoHC23Tqmj9B3lAXXFp2Qr0reFQm77AXcrdoMtl7qgUKO0Su1iZdXPge2qKWS8NPfS4fkvHJ7/aKQjORiHNIbx0OYtelj/9QauQurJlwcb6F2rb+N8K04FlRiIiNs4DOjJmviDFQu+kprCibrcDJeKhLN4ajjDBUX2d3dIACu/XYWc6D5uVok1kASXL5JYvelE1+64ILavo9FWTyQrot7wT63gnA/LtKDWWt+aIffIxnmB+QRgGhLARFkj4eVwJXillI55BfA9FoCkDLldUAafQ1mIS84VUDAvYgypiZ5jeocB+LPGEKWPlN0/dDbeyxhDI1IARWx54rw1irIlHMQzLvisEFttJjmP9CgwvXTv6p2BKaZKpg6xJAfSrrXZ2TrefbCqObnRuIuFS9FpS20+z/xWza62XIp5sqQtPPJSCmTAtyojHZwL1aBvpDw8Oi+XO97E63VPZ10O403UxWn0nsLKcE92k4SxlAhB55UN3/Dsjd0yC5JXoCOovfK04wsFIirvMKJbLkg75yvy2QPFzu5aVbQvcmMzQU+iAVXvukLeAZTSSrsBGz8E4SD7pQPHxG4BnA+BjpjOS/RFFwdYe4kDdkoj62tTpRlwEGrYsFlQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cef0a9ef-0637-41f6-3ac2-08db3cd093a2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 10:11:13.2042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n1yFHiG6UAsedNJmCX8IBSYQJi4nS6cee7EPaY8oNJxz/FCPYsKkmkjrQALXk8gjBYMigCu3B9cVbYw2CQ2AhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6016 Hello, We finally had the broken PDU replaced in the osstest colo, and the armhf boxes are operational again (those are the arndales and the cubietrucks). I've run some ad-hoc tests on them and they look fine. I plan to bless them before the end of the day. As usual, keep and eye on any failures that could be caused by the newly added boxes. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Fri Apr 14 10:32:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 10:32:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521093.809393 (Exim 4.92) (envelope-from ) id 1pnGiw-00078w-L7; Fri, 14 Apr 2023 10:32:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521093.809393; Fri, 14 Apr 2023 10:32:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnGiw-00078p-IE; Fri, 14 Apr 2023 10:32:10 +0000 Received: by outflank-mailman (input) for mailman id 521093; Fri, 14 Apr 2023 10:32:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnGiu-00078j-QM for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 10:32:08 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9947ba08-daaf-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 12:32:05 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2023 06:32:03 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM6PR03MB5018.namprd03.prod.outlook.com (2603:10b6:5:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 10:31:59 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Fri, 14 Apr 2023 10:31:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9947ba08-daaf-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681468325; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=MGhRUNn4CpD1xmpI3DHftaQwUI7WuO46fEFASjxcWZk=; b=AzgWtX3u1mrMIv/nFRwOiHvWjEABMxTBi809BFhg8h5+am9u5BEjwLjR huie9gjtJyHeqSKfHS4YFjhtzqieoyh0ZXf3bEIadYTXXQU6jkhYsfIWJ 3hpxycoLF8JApU1TQQ0AamUrvz1N8pN2Kl7WWeKW0MxjHzWxRx2F9CYyB 8=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 105912536 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aMdQK6hQCGCtLtFdFTEJsSxdX161RhEKZh0ujC45NGQN5FlHY01je htvD2yGa6qOMDemeNolaITjoExSsMXTzIdhSlM/+SFkEiMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4AaCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRfDSwAQSuBoNu/g+yGRvlzntt8PO3CadZ3VnFIlVk1DN4AaLWaG+Dgw4Ad2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMpluG1YLI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqjBdNLTuDjqJaGhnW14GxKEi00CmeqsL6D0V6BB9hZB R09r39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOluU7WDgr3 V+hhM7yCHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A6d+8pog210rLVow6SP7zicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:wAS3KqgA5aTuM/n9KelGZ6MbXXBQXuUji2hC6mlwRA09TyVXrb HWoB17726NtN91YhsdcL+7Scy9qB/nhPxICMwqTNSftWrd2VdATrsSibcKqgeIc0bDH6xmtZ uIGJIOb+EYY2IK6/oSIzPVLz/j+rS6GWyT6ts2Bk0CcT1X X-Talos-CUID: =?us-ascii?q?9a23=3AeXK6JWkvgMnl2A6tSRfzkRyNdmXXOTr40Hr/GE2?= =?us-ascii?q?fMG8qFoCZWUCI5/x0t+M7zg=3D=3D?= X-Talos-MUID: 9a23:GQfEfAVZqu+X7k/q/BnKhGh4BOU337W/T3pWgapasc+qZAUlbg== X-IronPort-AV: E=Sophos;i="5.99,195,1677560400"; d="scan'208";a="105912536" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jA8372tFLxdBw9dvXiFgrmUuUpE7D1PuptSaIK0Dwq4/3HZ4s1utowIdWu7AT0ExnebK7xdzejjjgApmjhh7vGDUvRfGzzSAxy+3lLpK/FoZDsnKASPusLQc/H6jrw6gfi0UrrTlrqJ+NfcVuHbXqSnRr2yv96sxvYqwF6xRvnIkojLhnhenbEd8Bn4E1oMYOXlg5obnsJ2QZBvKgRjK53Rx5rbYvTZW77Gvlp1PAkLrt4fsFVUKWQe7g4hT4r0g5CwaAlyQKPakx3oHmfC27XQNaP6fpa0GjSMKDt5SQRuYIEG65tn/pRqr3xLt2b8GCuObXb9CqzaWYXxg6IluRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98vGd4J/+VAnQ78DBVa6BYMBArs4WMIxEMx+E+g17Cw=; b=cyJO+sxM6SaEcpatI7P5rLL95HXHncd3ov3BkMRpi9VpJby1uMGjP1cBBUZ2vu+BmqJ1AQkgoedIZxuwZIzNMOsekWIzBUcdo4P+Stla3ACL7ZIMrkNeNshrwEd27Pa/SWfGCehy+2ShVqHB/ZJ9GzuvJuLuBFbeEyjgvZgTA0MOt4whKU3UaqD6+N4BYUNE/cd5KcP8caPhy2a+WcMz/p0GiONh/rfPbVMTnElRMcCtDYav5b5vTovZ5tq7ZNHTXr5KVsOqQNXpWaXGjytrh7p5OxPiWCrtywfS0WF6bB5TNhucQqFYqTde7g3ePtNkHnyN5EJPprA971onsY9ttA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98vGd4J/+VAnQ78DBVa6BYMBArs4WMIxEMx+E+g17Cw=; b=e/wT+9qWF4A6IkLh+1uGqn7K1XVnuji4EfWTf8MPteU5LnEI96c6PBgBasG3uPNuvmwSBbIIBzAs35oPwi7X0Q8k8mBMxXkwkjhGPjCfpnc2Fe8ChuizoF5gWKMbH3pmGSwWRTk2MB8DwnaaF+ieT5HPvDLvBtg8TWuJF9KGbIY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 14 Apr 2023 12:31:53 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH v2] x86/hvm: Disallow CR0.PG 1->0 transitions when CS.L=1 Message-ID: References: <20230412183519.2996902-1-andrew.cooper3@citrix.com> <20230413150009.3145462-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230413150009.3145462-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P265CA0252.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::18) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM6PR03MB5018:EE_ X-MS-Office365-Filtering-Correlation-Id: bacdc4b9-6734-4b26-278d-08db3cd37a6f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fc4yjXWFDGufRcIQ8LrMb2Gq77JSIja0QRG/4aK6CVVlWC58y+6fhwpLwYsRAKbyS8ufXnlPMNnBpIE0FUBv6WYudM1ggXMWO8JITRXRnCbncMwZ2FSuKTZ8UDFeuUyPZrsiUgdTQt9StzrSd9s5TzT9IYKUviz2zEijbdNG2UMq2dT41uD/8n5Qy2Mdq/O9WX4qPIB4JcWYs3wtvvwrGVsL/gnDnbF6+sAbifHOaRmR1vBPRJJkvCeVTloGFnnTxe394SJcyqvKtoAqYthZs4o/tmx3/wALhbT6R1xE8itcOjqY4evTld1FogBSMkeD+5LMA09YvO46OZ8HcLqAKJGOTR6WuFfpoJqClde/66fAB83wKNErEuZeELEl4fcICB2SWB+N2Hd74aegMQ3pZaHRbeanWl1qQtk6nZBvy6dbjpTgYsKmw0AXc6GxbCe16byNIdWf7WTCLi+X9uXyBug7Z2oJ4LCtC3hW68nW1cToaYVauBp8dAguVilwSmXqgpK+1BJgWG1ysvOIUWmfrJZIqALAZz60V/I0GO1Yxexq2BJxnK7J5oZbgFbEc4s4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199021)(33716001)(85182001)(478600001)(54906003)(6636002)(6486002)(6666004)(41300700001)(82960400001)(8936002)(6862004)(8676002)(38100700002)(66946007)(316002)(4326008)(83380400001)(66476007)(66556008)(6512007)(186003)(6506007)(9686003)(26005)(86362001)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWtVanFGTk5PbWNUbWFLZVpTTmM5Vk9WcklBVllaTmk2YUtUekNxK3QxY3Ux?= =?utf-8?B?SGFaVVpSR2tRTUJrWkZaN3NWbUVRK05La2xpdm96VzRmeWJoRHMxYUdIaW50?= =?utf-8?B?eWtDT21WVTJ0R0Q2M1JaYys1T0xmaG1WNitXVTg1RTVWV3h3T3dJMm82ejU4?= =?utf-8?B?T2kvQXYxd0RsRDdOejBiSjZBZ1lnQ05nMXUzZ3I1OFFrN29FQkxqVjlsdG13?= =?utf-8?B?K3l0YWppRWo4MVdyZ2w4aHAzTHprVjNsaE52N3FlNjhGb2hHN0hzR051TXRH?= =?utf-8?B?Rnl6Rmxjem1GMzAxbi8xejhncXBlajBYUHd6NUtLVFhsNUNrWkVkMm5EYWpr?= =?utf-8?B?V1dZOExHaVpyVzN1YTllNlNMSlJsQ1JXUmtqMktmMC9ubnNRK215cUdVTURU?= =?utf-8?B?WVJ5Ymd4Nmk5WGJrK09lazVXOFNYS2h1SVErN05Gd0hTMkhVaEdmNzlmY09O?= =?utf-8?B?cHg5MUowbHVLK1NFcFpSa1VEdzdXM0ozZ3NOWUo2VnNqNlFFekkwNFlsZmJ2?= =?utf-8?B?UjZVODJmeVQvTGh0UGV1eDF1WTJNTzMvQm4wb1czMGJ1SUJ3R2RtSlBHK2c5?= =?utf-8?B?TnJ3V1RLQ2RBVWF5NmxIS0lTZDlxczkxTnVFYVdKekdhRmdMZHgrbWVkVlZX?= =?utf-8?B?ZmpHb0NMeXFTQURMTFVia0JlQUxOaDhnM3ozeXc2YW95ZFhNVkx5NjB0anVl?= =?utf-8?B?TS93NTYvQmtiY01vRmNlWWtNdnpTc1NRdUViSHcxVFVEK1JjYWdLeVM0anJp?= =?utf-8?B?RDh2d1g3c2RscmpRSXZiRzBETkQ5T21PZnBHVU9tZjUycHVSejhyays3aWl2?= =?utf-8?B?Uzg1MndHODBSMU1FZFJZYkFpMzN6YmhHdEtXdnVQR0YyYXBJdEt6a1RjYkdB?= =?utf-8?B?bG5IQldoTURQdnBqRjdWUTRaMGRUbTgzOUxxWno5VFFyV3JqSVZsS2grVUNh?= =?utf-8?B?T3RtLzZLb040WEFncFc2QnY3Z0tBZUN6bUdVSFNEQ0dRZ3BmRWlQNWJVUkNY?= =?utf-8?B?Uy8xUCtIUUVoNjdHS3h0NER6WTJnZG1mT1ZPZ2oraEdiL1p3N21xQUoxL2tZ?= =?utf-8?B?ZWlySi9paURJUVc3aVhSejJPV2FSTENJcmlqZXVOWTR5emZQZmN0TmJ5SWxn?= =?utf-8?B?K0NZbFFjQTZzR0ZvdFluWDNjNTc3SnVxYnI2K1R2WW5VN3hJSEVUODZxUkJv?= =?utf-8?B?NGlxZ29tRHF5TjNpK1Y0UFd2dGkrcmpIOTZnK0ZiZXZqL1Q3UnhPQWFnSmt5?= =?utf-8?B?RjIybmVraXkxZXJRekU2RENoVloyN0Vaa2VmcjB3clpFdFlFQjdQMjVRUkJO?= =?utf-8?B?ZFpxaDloRGtqNTJVUS9LdkwzODJyY1k3NTdkYUFoaHFNMllvdG5iSy85ajJ1?= =?utf-8?B?UFdFVWpGeG9iT001TlNXSG9pWkJFdFFKTnY1eWwxekh6QWxrRExRdmVDaHFw?= =?utf-8?B?M2tISXZBWDk5ZjhYWmJEendSUVFJU0JSTkZEWFJUc3JFZXN4dkJ4cTZHY1Nz?= =?utf-8?B?YnJhUWFla0VCTzJqRDduMm5Oa3JLMlg4S3RnZlBrYzVhNEduTWVaQXBWNFdz?= =?utf-8?B?NUhqY1JYbDdrNnJXYlI4R1FCRXNIMDI3NEVQYkg5SCtiY2ZRTExBSG1tM3ZZ?= =?utf-8?B?Q05zS2NCOGRtNW5nWjl2cHdSM3ZLSXYvbDZIbzNmTzZzTG1Vc3p0R0FhbjV6?= =?utf-8?B?RHFSVjErRVhYQ2ZvQTJxOVFYd0tHbkp2Q25PdlFRa0t5cEtyQzZBVURLL0Fu?= =?utf-8?B?blJCcmhrcExqbTZQMVNWUTZDUU9HSW9TeWcybWMvMWJ6SC9JWDRUSzVHRmJM?= =?utf-8?B?ZFNSandqV2xydTJLZlZPV3Z5ODJvS001OXpIR0xralpYbEJyWmZUZGwrRmRJ?= =?utf-8?B?eTBUcXBPSmtIcERLaXBjN2pITkc3MFBXOFhhQWpxOURpSUdOdktlcnN1WEJV?= =?utf-8?B?Z1prTkV0MStEN1VYcURrZjg4amNKcEw2WSttOE1DUE5WZ2l3cWFiZUlyT3Vr?= =?utf-8?B?UTY5QXplVk4yTEJKTGFyQWdHTmlLY1BGUUZvenJmNXZBbFY5ZG5nbFZBMU44?= =?utf-8?B?TmVYWjA4VGMrQkxFWk5qZkxsYTNjdTVBM1FpRXdSS012MGZ2UVJOdHdaenBu?= =?utf-8?B?UjgvNU1FeGthRFR6YXJsYzY5aUtYR2FlMXZDM2t5VUcwZXdyN1BKK2VHTHk3?= =?utf-8?B?NGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: InxyOcUt/WNUc9tMmw1XcwtSg8X/lTdI97ThXGiovOojTz4diAc1KnXfl2nrzi48I7Bej25pwykRORoh0S1hpVRSyX10WwikqqGsfVBt171/+/bevXBHeI9u5FRie6m9B4jyMQVfykVS+V125RP7xt99ydmDvyzLbCn000ppo1O+yxE8S3X25Nn/9BtBbogvq921JOPVvnlRpzZimbmmp9fnu8fmCtoB2vOHOrOvKS8QgzEJzGsgwOXdgv2JfXJO2BC9IsMSR3ttWmbC1SNuT5rI3DJrdaRK8Brgp+331fyQEnlwyF/W7S3dEfdVWM4IjmwIGBqVmL09ae3L8i85ml8O5teqJEaUWgm5ellEBB2vPOy1DX10Eynr8A47m6lmcQwWn2n+KdIhYQGBiJm2XL5w++2Ba/cjRl0iJwfLaqLGCZ6kPBHYX+AhOa26cenrd4ZFjT0EmNXQlIC8lipK/CaPNBcaEItaAIjWFeroJPfYYfd6+6ZwmN3v7PnBYV94J7vK+DjHxBSQBoFksP0JoQFtiNtXIUvvsyhArwSNDQTivdasjETP2O6o8JIzJ4NXAuBmBXs8ADs7e7iihVYmoXeZ/H83M37Sk4VFOowbXmYQ7IIkjsuN3ykDtpzrkHTvcVFey2kVt5MO2swDq4YPd8H7TUpDSmPTup0yEOw/fn+Pnj4FqqtOYrILrF6dI6rLB88h74CDQmaEJbQewQDoKEcmVDpj0oqFOLGghLpSFXK79T8JH+aeH362DFaqzlML5LpyV481p4VJ9jv0yPZ1K47dfhWK7zqH5mK4ja8MVmui+RIZqDEpm3W1DkG4STSQMLeNynKYkzedHEq3t0DY0Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bacdc4b9-6734-4b26-278d-08db3cd37a6f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 10:31:59.5574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B1tDuMUN5yoiphQhHDAYGoL5E+rhAgcpiPN39iJx6uJ4rtLB1+tWMF04bL09JhOzW0uQxhOEfarf+cyJ4s1CJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5018 On Thu, Apr 13, 2023 at 04:00:09PM +0100, Andrew Cooper wrote: > The Long Mode consistency checks exist to "ensure that the processor does not > enter an undefined mode or state that results in unpredictable behavior". APM > Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row > preventing the OS from trying to exit Long mode while in 64bit mode. This > could leave the CPU in Protected Mode with an %rip above the 4G boundary. > > Experimentally, AMD CPUs really do permit this state transition. An OS which > tries it hits an instant SHUTDOWN, even in cases where the truncation I expect > to be going on behind the scenes ought to result in sane continued execution. > > Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" > section instructs peoples to switch to a compatibility mode segment first > before clearing CR0.PG, which does clear out the upper bits in %rip. This is > further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 > Architecture". > > Either way, this appears to have been a genuine oversight in the AMD64 spec. > > Intel, on the other hand, rejects this state transition with #GP. > > Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to > 4.1.2 "Paging-Mode Enable" was altered from: > > If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection > exception (#GP); software should clear CR4.PCIDE before attempting to > disable paging. > > to > > If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to > clear CR0.PG causes a general-protection exception (#GP). Software should > transition to compatibility mode and clear CR4.PCIDE before attempting to > disable paging. > > which acknowledges this corner case, but there doesn't appear to be any other > discussion even in the relevant Long Mode sections. > > So it appears that Intel spotted and addressed the corner case in IA-32e mode, > but were 15 years late to document it. > > Xen was written to the AMD spec, and misses the check. Follow the Intel > behaviour, because it is more sensible and avoids hitting a VMEntry failure. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > v2: > * Restrict to when Long Mode is enabled. Maybe the subject also needs to be slightly edited to mention CS.L=1 and Long Mode enabled? Or just mention long mode instead of the code segment status? Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Apr 14 10:38:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 10:38:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521098.809403 (Exim 4.92) (envelope-from ) id 1pnGoS-0007ly-AJ; Fri, 14 Apr 2023 10:37:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521098.809403; Fri, 14 Apr 2023 10:37:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnGoS-0007lr-7C; Fri, 14 Apr 2023 10:37:52 +0000 Received: by outflank-mailman (input) for mailman id 521098; Fri, 14 Apr 2023 10:37:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnGoQ-0007ll-EI for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 10:37:50 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 655b5324-dab0-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 12:37:48 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2023 06:37:40 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5951.namprd03.prod.outlook.com (2603:10b6:a03:2de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 10:37:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Fri, 14 Apr 2023 10:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 655b5324-dab0-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681468668; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=rfFV0GyBle3d5FzWYjOjeStUQK3dx7Ex94LOto3jdzo=; b=cRKHI4VABc1xhVwVrY8qmjeSeuO5CnvCApHXdzgqQ6NHHiKFAIMq+T5f x4kcgSb/iK+ZMaD4tbk42MO+Ay1DgthfoCriGhP7VsiMOlFHqViX8i7LO bTNRGpDdcJPSB4Gvwb+zf9r+Tl0DaiQSjX+E0aiclp78FFWct+gAuIkKf M=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 104290161 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:12cF5q/pMriKJ8njN5GGDrUDon+TJUtcMsCJ2f8bNWPcYEJGY0x3y WoeXWzQPKuDNmLxc9h0bYS18h8CsMLVmNZgHARt+X08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOakX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkle3 vEGGAkdPyyPxN+/7Iq2G9U31u48eZyD0IM34hmMzBn/JNN/G9XmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTaNilAsuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAN5IReXhqKcCbFu72lAZJyZGZ2OBjei0tVe4astwM mIS9X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO0cSCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptz8+oc6i0uVSs45SPLoyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:68ja/66MJJO4o4hwlAPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-Talos-CUID: 9a23:eSbo6GzTXMHmMePCl1BNBgUEMc07QkTNnUvcYHKxJV5kGYHOGXWPrfY= X-Talos-MUID: 9a23:126ZuQgU7A7pQSKn15wyW8MpKPtizJ/+Ong3vYQLhNCCBDVfIhmbg2Hi X-IronPort-AV: E=Sophos;i="5.99,195,1677560400"; d="scan'208";a="104290161" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XeTCHPQPWglVOSTG1NGoJFacphuNobGIdeRIWr06wayTLvMYb4pW5IRW6muojxbexMbP44iREXO4HQ+Q/WSPTqBKsQ32vG1tzHyXW7HK1lukNZMpks86bQanVP59sYqCmguwIbR23T+YXgt7ZWTgVjJ60NVZdnSkLeByyLyfyLfBBL9YesLgsPBisj9So4tUCYxpYkZU6e6WEPLgEXisyYvsnYAA2xS55lS72hAgxL3F5QDrmNDQtb862HsSVLmCqu8ixSfghF/75e0GV3Oqe/Xki9NQpy8rIgAKlHI1PXy3M1GN9LSRHbp3cOG2+p4go4nTSLoxlKjcWCLysiUO4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYyf/Bzhwwa+5YfSF6UGO9nYAQLVjLy3kf5xyX+9pYo=; b=ElCcTLaqo1gEJ9ibokBSHV5F+IPuwlwSQzOc5J+YIBjrQo3ppf4Un7Dv9/xlu2CQj54SjjrWwNliQKz6M4lZ8Wv2OtlvrkdBBNjmn7lSkRJgNbi8b2Bmr3zNLSiz8WQV9h5csbk2/qXy6w4SdosyNODRtROybgh0Z/vmOk6dSMWb6kYSd1/ho7ootjDDMgGDKE44QUf7MQ3PfVTt7ViyllUvnnzPsIHVaAC2Yv/jAotiXWaIz0jE6S9X4k6POVcYw33xAwVmgpArS6eNDUU4kZm0ohBnSTOLB0H0Gd7WVsy8tOpXD2+WGquDyRXzBLkdSniiGMqsk7eHtaNeDu+31w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GYyf/Bzhwwa+5YfSF6UGO9nYAQLVjLy3kf5xyX+9pYo=; b=dHlrberag5bPoE/FAFLx3rvJK5SBM8Blg1a5bJMSIlqmUlXRaStsZhiSRlGP1aIBn3zxqDtN8sfuGEEWQ1mmjfzc4rMJ+Ze6ugvciF1yy3CZe5BuJX4Bi58SeQCVOAf5ZBWWqQG8H35doR0l4fSe3Gi1tntE25mk9J6N3S/E4Sc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 14 Apr 2023 11:37:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH v2] x86/hvm: Disallow CR0.PG 1->0 transitions when CS.L=1 Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Jan Beulich , Wei Liu References: <20230412183519.2996902-1-andrew.cooper3@citrix.com> <20230413150009.3145462-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0540.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5951:EE_ X-MS-Office365-Filtering-Correlation-Id: f3834d00-6fd6-4f91-94ac-08db3cd442da X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PenDB/QVUUE4qbnb+wRr/lqiv9y/Oyn6C+nz97hQuAnj38uejq22xVLw5z9OJVB/8riNQ8+rKcJZINUFMX04IZ9bAH4AhlpjU3yUHVugCOMs/bUwdVQlQ0YTTVM21V8tj/SyJqrsiTS/5gBN1lf5clu6eDWSVCd75HmnEWE5t87DF8h7aDb2wzi04f2ENlnuarmwdxh4Xr/k0nYlRkCF3fF/94jaTvKhjuNYrDRIZC9fSKV89qVO1lCMA73W/SmuqZSRWgSJrF7h+AU8d/qropZ04C0PEcaxQNzzWKgrxXljANtRKySxPNv6ppFFlF4fBSIB2RjeOAPEUJTG6TzPhoJYz5yOGqc2MCQw+xeiNARIYsHjI9+KrCazc86Nc0uhP3h8mO5hI2e0uuQlVCwyejWoBlKj0MCFm4CJnZN0HlXECMi/cQaJKxXE7N2XRfCs+Am42ag65snaWFTBAvZdnNpToZ0hiMpM55X4Dt6BEsNJgWijA9rxrckP+kgHP0wIDUMAdxombqAT986ZU/o1FPUHX8dCbUdtQ3+knGXXyScwjidbP7RtNItJ9VQ5rLEZhXfz2PBXJar5HohlPyyJCwe/pNqc/nEatMRlMaZ0jLZ4uCAtIMF4BcVO8f7XkReWv+cSsKpr/tLSjjaKGVkOHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199021)(6666004)(37006003)(6486002)(66476007)(66556008)(66946007)(36756003)(4326008)(2906002)(86362001)(38100700002)(41300700001)(82960400001)(5660300002)(8936002)(8676002)(6862004)(316002)(478600001)(31696002)(54906003)(6636002)(53546011)(6512007)(6506007)(26005)(31686004)(2616005)(186003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGY4ZlF6MURGa0hXWFBEckIrb2I2S2RQMWxEbjkyV0d5SUpWNWhaM1NBelQ4?= =?utf-8?B?ZVhsU25sS1p4a3dmbHVYNmxIamt1VkZyNkdLbC96cmpISitsY1kzcEpQU3U3?= =?utf-8?B?a3JoMGVZUGdEeWsrV1Z5SnVncTgzaVkzVEJ4UU15TzY5ZWdRQ3ZnbWczcDAw?= =?utf-8?B?aTlkaXpLTnNlQ2Q3dFJqNzZBY0pwZmQ5cTB6dVlmTU5oWmNxeHdXMTBPWExO?= =?utf-8?B?c1M0R0Npa0xzbGM2YmZ3VmpJWmU3Z3FNRVRWczd2QkNxSTZjcEpuTzZRZ2pL?= =?utf-8?B?Qjk4OWdVUEpTNEI5Um1TRFE3SDAzRFBpai9NQTRodW0xNlBFb3FMT2V6alVZ?= =?utf-8?B?eFNkbWcxcWtUU1RDZkdKWE0xdndMVkZqSUxqOGdpKzBFdERkclRyUFJxUXB2?= =?utf-8?B?NE9NaE5VSEQ0dzBCVXR3UFd0ZzlwdkkwclU2NHp3dFk0U0ZIY0JQT0M5S3Jk?= =?utf-8?B?QmdpRXJxd2hOOVJRbWVVaUdZN1pjazJJVEdDRlQwenhvUzQ2QnBEYkR4N3h1?= =?utf-8?B?NUZ4OGVFOUQrcDBBTHFaL3Viay9JQ2tDN3VSZUdEc1VCdzk5bVZXbmlsM2RW?= =?utf-8?B?VXc2ZERVcEp4RTErYkNLY0lpWEJPaUlXcStBS1g4Nm9xdGd1SHoyWDBuNmtQ?= =?utf-8?B?S29Tb0dzSEZyb3pjNU9mbU9NVkV5YW53bWdJMCtKM1E5cS9XR1ZxOWU2cFRK?= =?utf-8?B?bG9Ib1hPcDZ1Mmd3bjcwcjQ3TzR6OGF0TW01K0hxcml1UDJ6WWc3YllMUlZq?= =?utf-8?B?eTFwSnNPQlIwMy9USzN5MmRJSUtOSUtiOW5CUXN6Q0pQVzJOaXVTYk91NXd6?= =?utf-8?B?Z0gvSXVtU0lBdnhhdnduNFVhdUVlbkRad0JmZVdXR21vOURTS2FyMU5TU1h4?= =?utf-8?B?RWg2RmNyTjVEZHRsbDBWOHVZdWwvaFJZRFRpU1FKT1NGVzNHWE9EQ1I5NEdQ?= =?utf-8?B?cWtYbklBVWZnc3A5bldyZnpMOWhnNXNXbUJyWkxBOUNGMXU3U01hZkNUdkNO?= =?utf-8?B?YmV6aS9Oa25Qa3Q3QnlZcG5EYUZUcnBJNThnTHU2QjEvSGo0S0J3YTJVa2Zl?= =?utf-8?B?U0Rrc3N6cmhQNWZ5aWpyejNUdU1SVE5xSUVzbzhYaEJwc0FrL291OTVKYVFz?= =?utf-8?B?MStibStRdjdLdmdhdmM1azA4OXd0azljT2FCSEVRL1FuNXhyZ2ZWVkhHbS9j?= =?utf-8?B?czBZTnE0eWVuNUtBeVJYa3hiaE03ZTZQdWRad09iYUtUcHp0VnZ3K2hlTlRJ?= =?utf-8?B?QnIyTUJ1bU56Q0NVRzJXNmRyaWZzelk4WFpqcU1lcEtWdjhQU0JVSk8xTklV?= =?utf-8?B?UTBoZGZaL3JhZGlnTkxBREpRS3JSOVVISWIxRmFhaWRMWU1JYkVSZUNZamox?= =?utf-8?B?bHd1RVhCWDYvK0ZjeHFsbHNRMFFOMENvUGVPNDJ2WTVmeFhZUjZCRmNIRkNa?= =?utf-8?B?SFJlbEFzckhrOU9iRzRpTUFEb29MbzFVSzJIVVlIMi9FYXpKdHVmbXMxOHdU?= =?utf-8?B?aHFtd1ZTY3p0NmowY0lRMmlZKzBUK1pZVThpcVViVGtDU3cybmFpM1YwQk5q?= =?utf-8?B?akEwRE5wNllxMGxra3h6cXFmeGdwZ3lEZzR4ZEZHNnJ2bm1vWXVWdGIyVFRX?= =?utf-8?B?cE1icGdqbjJ4eDFORXkvRTdHcTVsVCtLWnNrSTc5d0NZbDhTck9kSnZsclFj?= =?utf-8?B?MVhBdWxwWmVVSnE4bkIwbnc2blhINWlTdDdwZ1JNaldGbElPeWF2MlRjSStM?= =?utf-8?B?ZzRIdTBXdVRKdTRQbzUzY045TzVNY2pLcFNIUGFmQ1hvamZQV0piZDNwWTgx?= =?utf-8?B?QUFocFRCRWUvTG51d2xiMHNzdE8xQ3BSZmVVMDVOcHE1NGtTTzY0a1l2OXht?= =?utf-8?B?KzAvdVM2YThxcTh2ajRHbjJrQ0h1SHBqYURFNmNub3ZaNEMzMStGMGpDWnlt?= =?utf-8?B?cXlIcXlWRHVUTjVyNEd6ZUt1WG5pRTNaZVpucUJ5U0hyb1QxdHlMMEpUdzJZ?= =?utf-8?B?NkxDZ3laR2RXZ1ltL3JvUjBCYjJYV2RlalEyLzIzMXk3N0VhU01NSHllVmd3?= =?utf-8?B?a3ZCN2pZMy82YXJubE1nMXF1eXZHenVranBQVll1SkNaaXFIdXE0ZWNDWEZK?= =?utf-8?B?am1vb2hJS1VkWE1FSkFBbVEyMmZkR2RSZm4ra2ZJd2hYSUluZllZaHpXdlR4?= =?utf-8?B?WFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CLV82Y3MtsIqNeTg16jKlJxPQuP1oAJDfRWmYMNxXwdFeDV6PAdhx655xeC1zyTrQvZhJ2y8/3/zGS1cw4LSqvDTYxLwri5AbiFzWYUpYn0ZqzuvxqJY5TCX0lq+q31P8IhgrSELqbSgzbSkYqAP+1WAI1jt9pbqEhOSUy2wVgHNsD+FcM9hSPGZmhPHBdoY6CAkglecPHx0nkILnk9xdTw2mV/R7N5KVhYzQ0itAg00V4f770YehSiZhuTqmYb8TXUB8TxLsIlgUFGt+VLQjNV6Wixi04cN4uh1mpI3f0r91ebF8TVF4oEHOF/yqlnlQrnxSV64hwuv7qqILE0TpS+rN958N/ANm3cGRHcVQDNenC20urcptttCdSYRIrFh8oSqiS8zrGkYcWDmslAveDLVQ/31bnzedCELaQ19uPyCd4WGsMPGZhoMBbgGNJe26Q0EmgMNSfRaZ6AQOvHW6tDQj5XNXTZeLOYxyrIURgYUgUa7KIaHqlC7PbWsJ0c6eItq/H/YDgHYnZcmxzxlcEp8SpxqHheDaGERtfVaRyq+Wgjnnj4cVkf9x+K2a6rMGQgKPj6lfgT2NygAtoK5QI9mBxtM457LFB3nK9GxPJ1BFdVAhBjWu+JdXA48StGTCQL1kI8Z4RXHY6/7m4KV1GKpZx8OjR2IY6uKz89XqBqakUjY4oNnJoqwOErUe3IMy3ZyKGlc5dri0DKYU+qYfI6kvWLjmIauGkjFKsaQU2VJKqDTw7KH1z8B/wHuTbA/ipzTVf3liDcL7Ivob6SQpIo9FVZiyKaZBGmahOGui3xoJNOCIMAv+YawC/+LqHG65FPWJ8jc6Q18eulJU41+Fw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3834d00-6fd6-4f91-94ac-08db3cd442da X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 10:37:36.0278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 67yGCgatj3tdcP4PdSEGI417aBtyLs3V4NFaTQQC2J+4eGG4CpFmDEQ3LAoPozSZZjKEGkaHHi9G6pk9rOyGmOfqw/Xv/LihMqS8dAwNeng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5951 On 14/04/2023 11:31 am, Roger Pau Monné wrote: > On Thu, Apr 13, 2023 at 04:00:09PM +0100, Andrew Cooper wrote: >> The Long Mode consistency checks exist to "ensure that the processor does not >> enter an undefined mode or state that results in unpredictable behavior". APM >> Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row >> preventing the OS from trying to exit Long mode while in 64bit mode. This >> could leave the CPU in Protected Mode with an %rip above the 4G boundary. >> >> Experimentally, AMD CPUs really do permit this state transition. An OS which >> tries it hits an instant SHUTDOWN, even in cases where the truncation I expect >> to be going on behind the scenes ought to result in sane continued execution. >> >> Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" >> section instructs peoples to switch to a compatibility mode segment first >> before clearing CR0.PG, which does clear out the upper bits in %rip. This is >> further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 >> Architecture". >> >> Either way, this appears to have been a genuine oversight in the AMD64 spec. >> >> Intel, on the other hand, rejects this state transition with #GP. >> >> Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to >> 4.1.2 "Paging-Mode Enable" was altered from: >> >> If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection >> exception (#GP); software should clear CR4.PCIDE before attempting to >> disable paging. >> >> to >> >> If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to >> clear CR0.PG causes a general-protection exception (#GP). Software should >> transition to compatibility mode and clear CR4.PCIDE before attempting to >> disable paging. >> >> which acknowledges this corner case, but there doesn't appear to be any other >> discussion even in the relevant Long Mode sections. >> >> So it appears that Intel spotted and addressed the corner case in IA-32e mode, >> but were 15 years late to document it. >> >> Xen was written to the AMD spec, and misses the check. Follow the Intel >> behaviour, because it is more sensible and avoids hitting a VMEntry failure. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> >> v2: >> * Restrict to when Long Mode is enabled. > Maybe the subject also needs to be slightly edited to mention CS.L=1 > and Long Mode enabled? Or just mention long mode instead of the code > segment status? > > Acked-by: Roger Pau Monné Thanks.  I think "Disallow CR0.PG 1->0 transitions in 64bit mode" is the most concise way of tweaking the subject. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Apr 14 11:08:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 11:08:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521105.809413 (Exim 4.92) (envelope-from ) id 1pnHHg-0002sd-LX; Fri, 14 Apr 2023 11:08:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521105.809413; Fri, 14 Apr 2023 11:08:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnHHg-0002sW-IC; Fri, 14 Apr 2023 11:08:04 +0000 Received: by outflank-mailman (input) for mailman id 521105; Fri, 14 Apr 2023 11:08:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnHHf-0002sQ-3F for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 11:08:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2041.outbound.protection.outlook.com [40.107.7.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ed8037b-dab4-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 13:08:01 +0200 (CEST) Received: from DB6PR07CA0023.eurprd07.prod.outlook.com (2603:10a6:6:2d::33) by AS8PR08MB7765.eurprd08.prod.outlook.com (2603:10a6:20b:521::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.42; Fri, 14 Apr 2023 11:07:32 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::73) by DB6PR07CA0023.outlook.office365.com (2603:10a6:6:2d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.7 via Frontend Transport; Fri, 14 Apr 2023 11:07:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Fri, 14 Apr 2023 11:07:31 +0000 Received: ("Tessian outbound 3570909035da:v136"); Fri, 14 Apr 2023 11:07:31 +0000 Received: from 2b4ff116f851.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 01951991-24EA-43A3-8784-E1D77A91B09B.1; Fri, 14 Apr 2023 11:07:20 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b4ff116f851.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 11:07:20 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB7770.eurprd08.prod.outlook.com (2603:10a6:10:396::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Fri, 14 Apr 2023 11:07:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 11:07:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ed8037b-dab4-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WScqcNgRrzzsOLc1vEtHNgMNFwLihiXJagzJYyK7NLA=; b=PcPjDIHCB987af/f/Yhg9lzEjikRzYuITys71LzKxUWq/Bl7M3XsAFVavHv5WwqspZJrCOvQRVZOLC2Q/NoT4iRxaLOuFEY0/VV9VQymRtay6BNMuprIItNP9+APs23y0gJo3dPRn0+OFgyD/DJZlWbMsLp8jYhqp65CX52WxTM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 031b3a79c22b1b86 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z3Tkzh2c1ZoGUpdkqNfalDpCAQj5r8ZcfQtHZiiw4I1Lm3Zag77qZm7IwCU5d+aap+9Hk+Wf3dhB0zqUDiowFh4t2kQTw0wChqBhoGpP73N/NRgxxD/3HwIPTrQolDdhipV3ZvTdNxPrs7ZOgoCDGTBLCyNegYy9iFhcuMS8P0C/7B1OusSJ51pcvGzfYB8LjztoCI1NMrQsmUS4WEdTnAGmQt8/kTgA5CILv+EXqyYPUHx0rsnRy5O1NgWBBSdZdLamxS4olXcoG9DXKNOudz9OltafLPWSjzaTAAmPfx+JNiEunWlgUOVqu/UcFBAL3MYZC20N6x+Iatojw/9CBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WScqcNgRrzzsOLc1vEtHNgMNFwLihiXJagzJYyK7NLA=; b=hksip9xfv+E+ETEdGvORtIZqAS6FQAZGhXysC5wXdp65WijFPXUVbfP0zTNi+HRkARfpXD0qz2+XadL5KoM8msPC90spHH0juCl9z0M0tjjxfRkiGl+DLlYX1VP3Lxv/TrunHzM66CZFd5jDPUP0LzID/WA6HHsDJvACdjUAQ1pYs+eVP55t7VQaH/OilprOiclAwzEIciXFI7Za82TxXKGM5xvyORFVsPrfHlXPm2AX5b3Q7drKezoH0mgcNPX+wLpkS0vJXde+ywefFz0fAToXcjUP7K4Kwes2ktj5+NmC3nILf6nLynp0sRG53a/j315ZUtqnZAKX8w1+N3LmVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WScqcNgRrzzsOLc1vEtHNgMNFwLihiXJagzJYyK7NLA=; b=PcPjDIHCB987af/f/Yhg9lzEjikRzYuITys71LzKxUWq/Bl7M3XsAFVavHv5WwqspZJrCOvQRVZOLC2Q/NoT4iRxaLOuFEY0/VV9VQymRtay6BNMuprIItNP9+APs23y0gJo3dPRn0+OFgyD/DJZlWbMsLp8jYhqp65CX52WxTM= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Topic: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Thread-Index: AQHZbSQ9GJqCFHqaX0uCiT+EC9U7s68pNK+AgAAHnICAAAGIAIAACdqAgABhBICAAP+IAA== Date: Fri, 14 Apr 2023 11:07:18 +0000 Message-ID: References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> <03cc0c98-c5ef-16f1-ed24-6a39320b08e5@xen.org> In-Reply-To: <03cc0c98-c5ef-16f1-ed24-6a39320b08e5@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB7770:EE_|DBAEUR03FT034:EE_|AS8PR08MB7765:EE_ X-MS-Office365-Filtering-Correlation-Id: a4ca2cf1-cf8b-42ef-748f-08db3cd8711f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mSe6OrypJYJnEph5zQI2X3OHzF9a0NXN9O9G4hfYRd5rRAVSOGiKAb3FV3tiwO6k00mYRNt5IdYuTKEBBMjHHjsqjsqfTXLc0cVnpEUsQgDCoG5E7fQObDNmg/bn33YELRMtaR2ixbR439cwj5Sao+JvtVH0sJIeBIcElPoJMYbH0yioTVHuhiNS6Qvu/rZPdmDP30W6lwyGep7fA/MsBWK2dhYzacIGRcOIIWgX0rOIQjFdUgbL9CsJzm6K9zJfAikY1fAywd0JDtfgK3AHnXTEDaVQtIW+NcvLTBlI0YmBjsaQtWDkK8RE0BfOolHMEV9vEPyf1Xn3n/5+c9G0vm6w3qgvv4podrXruwc26/vJhr00zfMCqAdVIPq9S1tIODD6seUJQTPKYrgL+RemwcKHIYBuE1GeBGZCZ20qaq9WWdaB8D3Q1YUYwzH8zV/vg62e/YmQnvMeIp/jTma9o+u6bDQsJ1n155w0OUuTEeQmEsA/yXjFUgrjNKpJepz+xcT/0bBxBdcrn2OhlH0XftNWbMDJVcwPzAJw1zf6/56HULkfl6wLRF7UzKoznHD/veZ0s7IdvZpqN7FdqnV0+qjA+tLGWJhHRYt+e3YbMB7M0jj8zKON4gDlOTBj1rFhR/hZkX5V53sZ30YalShHVQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199021)(36756003)(86362001)(6486002)(6916009)(71200400001)(4326008)(41300700001)(66946007)(66446008)(54906003)(64756008)(66556008)(478600001)(8676002)(66476007)(76116006)(316002)(91956017)(33656002)(2616005)(6506007)(83380400001)(6512007)(26005)(53546011)(122000001)(2906002)(5660300002)(38070700005)(8936002)(38100700002)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <340B0A6ADBD74547904684AB28BF4388@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7770 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6faa8a5a-b9cb-4700-bfc5-08db3cd8698d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l4KUBLgGKnDLkrg14ugKGOZERDVV59FENl9xpawH1Fvphjd+qbi5cEpLtaQY1W7N1EhXN7vv2f3zBpHg1vUkhlQO5h6LGE7wHkPb1Br4gOk57Pb+A2tv/RhKmOQ0N5AqJ6A0tPrlQbMUO5FXZd6ENXQyw1Rp/IFOGgVAvsi5000Ph6xuqqT4HO0rguoYUvwABeujVQy6UJpwHtZrrcln1NfGBuyW7KAJICk+QEH77ayD36uqeT0H76w61GLRCj61y8PR9RLKNfohdrjBNxkS233C59GM5Gw0l3hqKRLoum1uWIHbLgHzrB/29Dnm2GDXsWy9SppKY7FzN5xHbnLv/gLqp7KsEAOW5LAkATMluO+e3Jfbflq52lC1XSEjy9VeRmgT6AN+bKsf6CwGxolk1iR11Mg3OSz09OVMwZp1cB9vfR0g4TZaEF7Ob5xQRTgcvAl2NlcEuvQ5PaijwWVE1k+LsoFor96k6ZxaXzVczYaGGLvfCMlP5te+zpj3X1HeLhnJ/cOStV7qbfDOgc5N0/B/Kl4Yegrsr4ArAyr9UtXkIMPWFK0oslbqPs3euYhwJJ0C27SxCpCc375IDRNNW4Gw5BA9zoJHBNGWLkny4FdT6guUksIWW1JCYTP5joGDZA6jAC4BcDvpHDFPmn6xZ0kDixuuvOMwO7U8VlOG2foQLi5t1ntTpDYtfZihlL5cd0kRQih7+gUDbHNFuO6G4A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199021)(36840700001)(40470700004)(46966006)(316002)(83380400001)(41300700001)(54906003)(82310400005)(33656002)(86362001)(36860700001)(336012)(478600001)(2616005)(70206006)(81166007)(8676002)(4326008)(70586007)(36756003)(6486002)(82740400003)(47076005)(356005)(2906002)(6862004)(8936002)(186003)(40460700003)(6506007)(6512007)(26005)(53546011)(5660300002)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 11:07:31.1546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4ca2cf1-cf8b-42ef-748f-08db3cd8711f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7765 DQoNCj4gT24gMTMgQXByIDIwMjMsIGF0IDIwOjUyLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBPbiAxMy8wNC8yMDIzIDE1OjA1LCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+IE9uIDEzIEFwciAyMDIzLCBhdCAxNDozMCwgSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gDQo+Pj4gDQo+Pj4gT24g MTMvMDQvMjAyMyAxNDoyNCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4gSGkgSnVsaWVuLA0K Pj4+IA0KPj4+IEhpIEx1Y2EsDQo+Pj4gDQo+Pj4+Pj4gIEBAIC01OTQsNiArNTk3LDcgQEAgaW50 IGFyY2hfc2FuaXRpc2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21h aW4gKmNvbmZpZykNCj4+Pj4+PiAgICAgIHVuc2lnbmVkIGludCBtYXhfdmNwdXM7DQo+Pj4+Pj4g ICAgICB1bnNpZ25lZCBpbnQgZmxhZ3NfcmVxdWlyZWQgPSAoWEVOX0RPTUNUTF9DREZfaHZtIHwg WEVOX0RPTUNUTF9DREZfaGFwKTsNCj4+Pj4+PiAgICAgIHVuc2lnbmVkIGludCBmbGFnc19vcHRp b25hbCA9IChYRU5fRE9NQ1RMX0NERl9pb21tdSB8IFhFTl9ET01DVExfQ0RGX3ZwbXUpOw0KPj4+ Pj4+ICsgICAgdW5zaWduZWQgaW50IHN2ZV92bF9iaXRzID0gc3ZlX2RlY29kZV92bChjb25maWct PmFyY2guc3ZlX3ZsKTsNCj4+Pj4+PiAgICAgICAgaWYgKCAoY29uZmlnLT5mbGFncyAmIH5mbGFn c19vcHRpb25hbCkgIT0gZmxhZ3NfcmVxdWlyZWQgKQ0KPj4+Pj4+ICAgICAgew0KPj4+Pj4+IEBA IC02MDIsNiArNjA2LDI2IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0 IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+Pj4+Pj4gICAgICAgICAgcmV0dXJu IC1FSU5WQUw7DQo+Pj4+Pj4gICAgICB9DQo+Pj4+Pj4gICsgICAgLyogQ2hlY2sgZmVhdHVyZSBm bGFncyAqLw0KPj4+Pj4+ICsgICAgaWYgKCBzdmVfdmxfYml0cyA+IDAgKQ0KPj4+Pj4+ICsgICAg ew0KPj4+Pj4+ICsgICAgICAgIHVuc2lnbmVkIGludCB6Y3JfbWF4X2JpdHMgPSBnZXRfc3lzX3Zs X2xlbigpOw0KPj4+Pj4+ICsNCj4+Pj4+PiArICAgICAgICBpZiAoICF6Y3JfbWF4X2JpdHMgKQ0K Pj4+Pj4+ICsgICAgICAgIHsNCj4+Pj4+PiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5G TywgIlNWRSBpcyB1bnN1cHBvcnRlZCBvbiB0aGlzIG1hY2hpbmUuXG4iKTsNCj4+Pj4+PiArICAg ICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+Pj4+Pj4gKyAgICAgICAgfQ0KPj4+Pj4+ICsNCj4+ Pj4+PiArICAgICAgICBpZiAoIHN2ZV92bF9iaXRzID4gemNyX21heF9iaXRzICkNCj4+Pj4+PiAr ICAgICAgICB7DQo+Pj4+Pj4gKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0lORk8sDQo+Pj4+ Pj4gKyAgICAgICAgICAgICAgICAgICAgIlJlcXVlc3RlZCBTVkUgdmVjdG9yIGxlbmd0aCAoJXUp ID4gc3VwcG9ydGVkIGxlbmd0aCAoJXUpXG4iLA0KPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAg IHN2ZV92bF9iaXRzLCB6Y3JfbWF4X2JpdHMpOw0KPj4+Pj4+ICsgICAgICAgICAgICByZXR1cm4g LUVJTlZBTDsNCj4+Pj4+PiArICAgICAgICB9DQo+Pj4+PiANCj4+Pj4+IElzIFNWRSBzdXBwb3J0 ZWQgZm9yIDMyLWJpdCBndWVzdD8gSWYgbm90LCB0aGVuIHlvdSBzaG91bGQgaGFkIGEgY2hlY2sg aGVyZSB0byBwcmV2ZW50IHRoZSBjcmVhdGlvbiBvZiB0aGUgZG9tYWluIGlmIHN2ZV92bF9iaXRz IGlzIHNldC4NCj4+Pj4gTm8gU1ZFIGlzIG5vdCBzdXBwb3J0ZWQgZm9yIDMyIGJpdCBndWVzdHMs IGhlcmUgSSB0aGluayB3ZSB3aWxsIGdldCDigJxTVkUgaXMgdW5zdXBwb3J0ZWQgb24gdGhpcyBt YWNoaW5l4oCdIGJlY2F1c2UgZ2V0X3N5c192bF9sZW4oKSB3aWxsIHJldHVybiAwLg0KPj4+IA0K Pj4+IEZyb20gbXkgdW5kZXJzdGFuZGluZywgZ2V0X3N5c192bF9sZW4oKSB3aWxsIHJldHVybiB0 aGUgbGVuIHN1cHBvcnRlZCBieSB0aGUgaG9zdHMuIFNvIGlmIHlvdSBydW4gYSAzMi1iaXQgZ3Vl c3Qgb24gdG9wIG9mIGEgNjQtYml0IGhvc3RzLCB0aGVuIEkgYmVsaWV2ZSBnZXRfc3lzX3ZsX2xl bigpIHdpbGwgYmUgbm9uLXplcm8uDQo+PiBZZXMgeW91IGFyZSByaWdodCwgSSByZWFsaXNlIHRo YXQgSSBuZWVkIHRoZSBkb21haW4gdHlwZSBpbmZvcm1hdGlvbiBhbmQgSSBjYW7igJl0IGhhdmUg aXQgaW4gYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnLCBob3dldmVyIHRoZXkgbWlnaHQgaGF2 ZSBzZW5zZSB0aGVyZSwgYW5kIEkgY2FuIGRvIGEgY2hlY2sNCj4+IGxpa2UgdGhpcyBhZnRlcndh cmRzOg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9h cmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4gaW5kZXggYzFmMGQxZDc4NDMxLi5jZTEyMzVjMjU3 NjkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+ICsrKyBi L3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4gQEAgLTM2OTQsNiArMzY5NCwxMiBAQCBz dGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tYWluKHN0cnVjdCBkb21haW4gKmQsIHN0cnVj dCBrZXJuZWxfaW5mbyAqa2luZm8pDQo+PiAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICAg ICAgfQ0KPj4gICsgICAgaWYgKCBkLT5hcmNoLnN2ZV92bCAmJiAoa2luZm8tPnR5cGUgPT0gRE9N QUlOXzMyQklUKSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIHByaW50aygiU1ZFIGlzIG5vdCBh dmFpbGFibGUgZm9yIDMyLWJpdCBkb21haW5cbiIpOw0KPj4gKyAgICAgICAgcmV0dXJuIC1FSU5W QUw7DQo+PiArICAgIH0NCj4+ICsNCj4+ICAgICAgaWYgKCBpc182NGJpdF9kb21haW4oZCkgKQ0K Pj4gICAgICAgICAgdmNwdV9zd2l0Y2hfdG9fYWFyY2g2NF9tb2RlKHYpOw0KPj4gV291bGQgaXQg YmUgb2sgZm9yIHlvdT8NCj4gDQo+IGNvbnN0cnVjdF9kb21haW4oKSBpcyBvbmx5IGdvaW5nIHRv IGJlIHVzZWQgZm9yIGRvbWFpbnMgY3JlYXRlZCBieSBYZW4uIFlvdSB3b3VsZCBuZWVkIHRoZSBz YW1lIGNoZWNrIGZvciB0aGUgb25lcyBjcmVhdGVkIGJ5IHRoZSB0b29sc3RhY2suDQo+IA0KPiBE byB5b3UgbmVlZCB0byBrbm93IHRoZSBTVkUgbGVuZ3RoIHdoZW4gdGhlIGRvbWFpbiBpcyBjcmVh dGVkPyBJZiBub3QsIHRoZW4gSSB3b3VsZCBzdWdnZXN0IHRvIGNyZWF0ZSBhIG5ldyBkb21jdGwg dGhhdCB3b3VsZCBiZSBjYWxsZWQgYWZ0ZXIgd2Ugc3dpdGNoIHRoZSBkb21haW4gdG8gMzItYml0 Lg0KDQpIaSBKdWxpZW4sDQoNClllcyB0aGF04oCZcyB0cnVlLCB3ZSB3b3VsZCBsaWtlIHRvIHBy ZXZlbnQgd2hvIGlzIHVzaW5nIGh5cGVyIGNhbGxzIHRvIGhhdmUgZ3Vlc3RzIHdpdGggU1ZFIGJ1 dCAzMiBiaXRzLCBJIHRoaW5rIHRoYXQgd2l0aCB0aGlzIGNoZWNrIGl04oCZcyBwb3NzaWJsZSB0 byBhdm9pZCB0aGVtOg0KDQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2FybTY0L2RvbWN0bC5j IGIveGVuL2FyY2gvYXJtL2FybTY0L2RvbWN0bC5jDQppbmRleCAwZGU4OWI0MmM0NDguLmI3MTg5 ZThkYmJiNSAxMDA2NDQNCi0tLSBhL3hlbi9hcmNoL2FybS9hcm02NC9kb21jdGwuYw0KKysrIGIv eGVuL2FyY2gvYXJtL2FybTY0L2RvbWN0bC5jDQpAQCAtNDMsNiArNDMsOSBAQCBsb25nIHN1YmFy Y2hfZG9fZG9tY3RsKHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwsIHN0cnVjdCBkb21haW4gKmQs DQogICAgICAgICBjYXNlIDMyOg0KICAgICAgICAgICAgIGlmICggIWNwdV9oYXNfZWwxXzMyICkN CiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQorICAgICAgICAgICAgLyogU1ZFIGlz IG5vdCBzdXBwb3J0ZWQgZm9yIDMyIGJpdCBkb21haW4gKi8NCisgICAgICAgICAgICBpZiAoIGlz X3N2ZV9kb21haW4oZCkgKQ0KKyAgICAgICAgICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQog ICAgICAgICAgICAgcmV0dXJuIHN3aXRjaF9tb2RlKGQsIERPTUFJTl8zMkJJVCk7DQogICAgICAg ICBjYXNlIDY0Og0KICAgICAgICAgICAgIHJldHVybiBzd2l0Y2hfbW9kZShkLCBET01BSU5fNjRC SVQpOw0KDQpJdOKAmXMgYSBiaXQgbGF0ZSBpbiB0aGUgZ3Vlc3QgY3JlYXRpb24sIGJ1dCB3ZSBk b27igJl0IGhhdmUgdGhlIGRvbWFpbiB0eXBlIGluZm9ybWF0aW9uIGJlZm9yZSwgdGhpcyBjaGVj ayB0b2dldGhlciB3aXRoIHRoZSBjaGVjayBhYm92ZSBpbiBjb25zdHJ1Y3RfZG9tYWluIHdvdWxk DQpiZSBlbm91Z2guDQoNCldoYXQgZG8geW91IHRoaW5rPw0KDQo+IA0KPiBDaGVlcnMsDQo+IA0K PiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg0K From xen-devel-bounces@lists.xenproject.org Fri Apr 14 11:52:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 11:52:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521111.809429 (Exim 4.92) (envelope-from ) id 1pnHyD-0008FP-2n; Fri, 14 Apr 2023 11:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521111.809429; Fri, 14 Apr 2023 11:52:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnHyC-0008FI-Vx; Fri, 14 Apr 2023 11:52:00 +0000 Received: by outflank-mailman (input) for mailman id 521111; Fri, 14 Apr 2023 11:51:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnHyB-0008F8-P1; Fri, 14 Apr 2023 11:51:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnHyB-00015G-MI; Fri, 14 Apr 2023 11:51:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnHyB-0007V0-1b; Fri, 14 Apr 2023 11:51:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnHyB-0000va-14; Fri, 14 Apr 2023 11:51:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GYCAZq0QrjbnYJPPWZJYnbfYtkm42KIpbHfYyvtxG48=; b=V/5LP9Aq8YW0+AKVi3AKPWOgXo o3zoctYbhj1C/0HasAqtme4zBLNW6lhmJCXH3xPE06H9lIWxYAEOHgPIV1DS8QeaBbYQ+w9qmsoxk RC/Ma/bnL1R3GLwktMupgCcemmjA8opk/9NEkLvTrjRtDNpUslgo6WZklypGBU1dYWp8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180253: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=44149752e9987a9eac5ad78e6d3a20934b5e018d X-Osstest-Versions-That: linux=de4664485abbc0529b1eec44d0061bbfe58a28fb From: osstest service owner Date: Fri, 14 Apr 2023 11:51:59 +0000 flight 180253 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180253/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180230 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180230 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180230 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180230 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail like 180230 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180230 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 44149752e9987a9eac5ad78e6d3a20934b5e018d baseline version: linux de4664485abbc0529b1eec44d0061bbfe58a28fb Last test of basis 180230 2023-04-13 07:36:51 Z 1 days Testing same since 180253 2023-04-14 01:13:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Conole Ahmed Zaki Alex Deucher Alexander Stein Alexei Starovoitov Asahi Lina Christoph Paasch Christophe JAILLET Chunyan Zhang Claudia Draghicescu Daniel Borkmann Daniel Vetter Daniel Vetter Daniel Wheeler David S. Miller Denis Plotnikov Douglas Anderson Eric Dumazet Evan Quan Felix Huettner Florent Revest Geert Uytterhoeven George Guo Guillaume Nault Hangbin Liu Harshit Mogalapalli Hayes Wang Helge Deller Horatio Zhang Ivan Bornyakov Jakub Kicinski Jani Nikula Jay Vosburgh Jesper Dangaard Brouer Jonathan Toppins Josh Don Karol Herbst Kornel Dulęba Krzysztof Kozlowski Kuniyuki Iwashima Lars-Peter Clausen Liang Chen Linus Torvalds Linus Walleij Liu Peibao Lorenzo Bianconi Luben Tuikov Luca Czesla Luiz Augusto von Dentz Maarten Lankhorst Mark Brown Martin KaFai Lau Martin Willi Matthieu Baerts Min Li Nicolas Ferre Oleksij Rempel Paolo Abeni Peter Zijlstra (Intel) Qingqing Zhuo Radu Pirea (OSS) Rafal Romanowski Rob Herring Roman Gushchin Saravana Kannan Sasha Finkelstein Shawn Guo Stanislav Fomichev Stefan Wahren Stephen Boyd Tejun Heo Tetsuo Handa Thomas Zimmermann Toke Høiland-Jørgensen Tony Nguyen Vladimir Oltean Waiman Long WANG Xuerui Wayne Lin Wolfram Sang # for I2C Xin Long Xingyuan Mo Xu Kuohai YueHaibing Zheng Wang Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git de4664485abb..44149752e998 44149752e9987a9eac5ad78e6d3a20934b5e018d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Apr 14 12:18:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 12:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521118.809439 (Exim 4.92) (envelope-from ) id 1pnIO7-0002Ql-8n; Fri, 14 Apr 2023 12:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521118.809439; Fri, 14 Apr 2023 12:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnIO7-0002Qe-60; Fri, 14 Apr 2023 12:18:47 +0000 Received: by outflank-mailman (input) for mailman id 521118; Fri, 14 Apr 2023 12:18:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnIO5-0002QU-Uv for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 12:18:45 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7fdad166-dabe-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 14:18:44 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id n42-20020a05600c3baa00b003f0b12814aaso916025wms.0 for ; Fri, 14 Apr 2023 05:18:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fdad166-dabe-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681474724; x=1684066724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DWES7aaub1/1Y6TQPqE2JUKhfa5FJIAf7U3cNJVc0FI=; b=Cv3knVpGj3zGDEHS5ifStC8xmlavhUn+IYV/Rp9JMDHRRQi3i2r2Zda35WHr6RReaW MD17+zvXFodYhu8IT+2BiTjIS5PobJIjK/Zd0hVgY6agPnldVWLgKRMPsOvS2DcEv8q2 zAIAsyL5Va2MJD+gRfoD7CnyQS9x9IYa5vFzIvnRwnSNPjxcZb/xUx8Xg8zR+yFyGxpE /o5TCvkMnN+RwRPaxjqdW/SjZLYzam8twOJIj8CJ8FqOZu1d7bmR+fk6mgxSKpEig168 yFgCubO2mRr7UsoAYccVMSgfM8l0cULYe0RId7xJcPp2N4jjCzo/l8i8nAf8sSEb3LMw lemA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681474724; x=1684066724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DWES7aaub1/1Y6TQPqE2JUKhfa5FJIAf7U3cNJVc0FI=; b=ZYE9iDuW/LgxI9ipwHaJaJJzvzdQTJtU9xkjTJVjO4AyJfuHKGMmSYAFoMI4v8scWm q0xIS8P6Bwv8ZiMl1ANjuzUaJiHStDtfU0D2FUPrzAN1j5B/Tc3NmD86gfmkrRETqMO+ /b/ApHtiTyfcu6RQ/YLRB3oZmtfXOONEqgwsjf4A3QfajBS/lXWZpafUIW4zEN2VavTG EpY//uAky7mnlMo2er32QtT4uHMJIcvo1WRKiS2nkXp//fUDFfehm2wrYU9aUvYqUlZS kG5cb5ELgQexUz0FxTDzQhh2cQ7z0vH4nmViAuHZj2QZ2gauKSV72CEYg2sr9SoXR1l0 +56Q== X-Gm-Message-State: AAQBX9frPCSqOtebeUvEH1SY+kC9gYEbTVKbN7PHqG2Aa401scYY9h2B HthM4M8NtaVcS4NoLoK9ffMO4tZ3zdtAc7lZCUfJOw== X-Google-Smtp-Source: AKy350YdNT3Cjuz8BXV3UbjRph1dX32VinWgDt6FOIiKF226mh8dcWomBkzryF8+t9QVb3VamOwmbBdm39WjBP8Mo8Y= X-Received: by 2002:a1c:7708:0:b0:3df:97c0:1b4 with SMTP id t8-20020a1c7708000000b003df97c001b4mr1404928wmi.4.1681474723712; Fri, 14 Apr 2023 05:18:43 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-12-jens.wiklander@linaro.org> <9732C6EB-3346-408D-B267-9CCCE081B661@arm.com> In-Reply-To: <9732C6EB-3346-408D-B267-9CCCE081B661@arm.com> From: Jens Wiklander Date: Fri, 14 Apr 2023 14:18:32 +0200 Message-ID: Subject: Re: [XEN PATCH v8 11/22] xen/arm: ffa: send guest events to Secure Partitions To: Bertrand Marquis Cc: Julien Grall , Marc Bonnici , Achin Gupta , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Bertrand, On Fri, Apr 14, 2023 at 10:29=E2=80=AFAM Bertrand Marquis wrote: > > Hi Jens, > > > On 14 Apr 2023, at 10:19, Jens Wiklander wr= ote: > > > > Hi, > > > > On Thu, Apr 13, 2023 at 3:24=E2=80=AFPM Julien Grall w= rote: > >> > >> Hi, > >> > >> On 13/04/2023 08:14, Jens Wiklander wrote: > >>> +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id= , > >>> + uint8_t msg) > >>> +{ > >>> + uint32_t exp_resp =3D FFA_MSG_FLAG_FRAMEWORK; > >>> + int32_t res; > >>> + > >>> + if ( msg =3D=3D FFA_MSG_SEND_VM_CREATED ) > >>> + exp_resp |=3D FFA_MSG_RESP_VM_CREATED; > >>> + else if ( msg =3D=3D FFA_MSG_SEND_VM_DESTROYED ) > >>> + exp_resp |=3D FFA_MSG_RESP_VM_DESTROYED; > >>> + else > >>> + return FFA_RET_INVALID_PARAMETERS; > >>> + > >>> + do { > >>> + const struct arm_smccc_1_2_regs arg =3D { > >>> + .a0 =3D FFA_MSG_SEND_DIRECT_REQ_32, > >>> + .a1 =3D sp_id, > >>> + .a2 =3D FFA_MSG_FLAG_FRAMEWORK | msg, > >>> + .a5 =3D vm_id, > >>> + }; > >>> + struct arm_smccc_1_2_regs resp; > >>> + > >>> + arm_smccc_1_2_smc(&arg, &resp); > >>> + if ( resp.a0 !=3D FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != =3D exp_resp ) > >>> + { > >>> + /* > >>> + * This is an invalid response, likely due to some error= in the > >>> + * implementation of the ABI. > >>> + */ > >>> + return FFA_RET_INVALID_PARAMETERS; > >>> + } > >>> + res =3D resp.a3; > >>> + } while ( res =3D=3D FFA_RET_INTERRUPTED || res =3D=3D FFA_RET_R= ETRY ); > >> > >> This loop seems potentially unbounded to me. Can you add a comment > >> explaining why this is fine? > > > > In the FF-A 1.1 specification > > (https://developer.arm.com/documentation/den0077/e/?lang=3Den) Table > > 18.26 at page 330 it says that FFA_RET_INTERRUPTED and FFA_RET_RETRY > > should be handled in this way. When looking at this from the > > hypervisor's point of view it is troublesome since there isn't any > > guarantee that we're progressing. > > > > We should be able to rule out FFA_RET_INTERRUPTED since non-secure > > interrupts should be masked at this point. I'm not sure if > > FFA_RET_RETRY can be avoided entirely, but we should be able to put a > > limit on how many times we're prepared to retry. > > The fact that interrupts are masked in Xen does not mean they will be in = secure. > In fact what we should do when INTERRUPTED is received is something we ha= ve > to clear up but we should unmask interrupt to process them in Xen before = retrying I think. > > > > > How about setting a limit of max 10 retries and treating > > FFA_RET_INTERRUPTED as an error? Or is it better to not loop at all > > and treat all but FFA_RET_OK as errors? What do others think? > > I would suggest to do a max retry for both cases and add a TODO in the co= de. > We will need to define a generic way to handle those cases but at this st= age > INTERRUPTED should be considered TODO. > RETRY will probably stay with a limit here, in the case of a guest messag= e both > of those possibilities could just be returned to the guest. > > > Do you agree ? Sounds good to me, I'll do that. Thanks, Jens > > Cheers > Bertrand > > > > > Thanks, > > Jens > > > >> > >>> + > >>> + return res; > >>> +} > >>> + > >> > >> Cheers, > >> > >> -- > >> Julien Grall > > From xen-devel-bounces@lists.xenproject.org Fri Apr 14 12:27:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 12:27:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521122.809449 (Exim 4.92) (envelope-from ) id 1pnIWm-0003ui-3s; Fri, 14 Apr 2023 12:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521122.809449; Fri, 14 Apr 2023 12:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnIWm-0003ub-1F; Fri, 14 Apr 2023 12:27:44 +0000 Received: by outflank-mailman (input) for mailman id 521122; Fri, 14 Apr 2023 12:27:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnIWk-0003uV-MT for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 12:27:42 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c027a1bd-dabf-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 14:27:41 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id bd13-20020a05600c1f0d00b003f14c42cc99so489112wmb.2 for ; Fri, 14 Apr 2023 05:27:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c027a1bd-dabf-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681475261; x=1684067261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J3Y/hSydieebmmYwPSKCbO29GxMGDiyoGiZ+b5e5hUA=; b=tUnNWGpl9bhWPrFRwBk9shXRxXgqi12/g5dzdpqNsg57/NpcXvg+ymRCLPbz/yA4S1 u3MW4gqORASqR3ETAaG7btQvxrn8DMJvEDVLiOJDIoFrikE15WbYQ4Z4Fl0NFQ9YxYdL Mn46qIVmMxLRxICvu0pJrxcsdgIvn4ch41g3OYDbyZ7xzm5QgSLQAl53+uWQeHo6ybo7 gqFHmKoTBau3KSEeKT6VQ4swDPeALbEKsXNFMsroSYG2D3w+dhXaZt4BBifUrcgRmnym oE/8NK+R9hrA52Ll0Ku4HNibYXUozuaaQX+Rpp9glqCj19/7oX0FD2Nbr0DtbHpHEo/Y blIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681475261; x=1684067261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J3Y/hSydieebmmYwPSKCbO29GxMGDiyoGiZ+b5e5hUA=; b=c4qGbfhj7WGEa/XCQRx5Eo7Dehp7QeFWnbHoYjsd2Jf3jfq3Ofw5f1MjEkouWc5Bmk zMzoaUnHAgTOBb59kPOUPWNb6uTH7FV6bOl7uXlDk2g43PLCSOcO4KBy/wzQO/CeOPfv h15fev+CFNKxZw6TrQrNvtEqVKTctRBKzs3QzoK0jFoiYKvuGSG8MR4YsKUrwX4ymAwo Q18JZ14J35kLywIukv9hsnmGqe8Dzpt+u9/EMhTflDpkEwiUeOg3JRmhGQTPZToPkTUY lHBL1LFKXQlZtyKLWkO71txiCE+WkfteGiS/WVvlhGLDSuwnbinYkMl+FdTJVkDyT+iE x+Ag== X-Gm-Message-State: AAQBX9dNhzEdqdOm0uP1oflR1L+I0qymXzGVmkzp8l5qV9hoTNgPdMwL 3H1IWrlZm20wWuSvn1qdZL/XUMudL1JHse9GgMjrbw== X-Google-Smtp-Source: AKy350Zdm3yiMt9d+tmL4qHGNzKFgE2QaAKiri18GvmV7MGXhIEwDTKKTgN1FZtNQdKaMeR0BvsAnrA4GdKrezCFqBw= X-Received: by 2002:a05:600c:1d1b:b0:3f0:34c5:7350 with SMTP id l27-20020a05600c1d1b00b003f034c57350mr1808079wms.4.1681475261169; Fri, 14 Apr 2023 05:27:41 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-23-jens.wiklander@linaro.org> <7a29bc06-61b5-51e6-4625-bf19e530b975@xen.org> In-Reply-To: <7a29bc06-61b5-51e6-4625-bf19e530b975@xen.org> From: Jens Wiklander Date: Fri, 14 Apr 2023 14:27:28 +0200 Message-ID: Subject: Re: [XEN PATCH v8 22/22] docs: add Arm FF-A mediator To: Julien Grall Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Julien, On Thu, Apr 13, 2023 at 11:00=E2=80=AFPM Julien Grall wrot= e: > > Hi Jens, > > On 13/04/2023 08:14, Jens Wiklander wrote: > > Describes a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > [1] https://developer.arm.com/documentation/den0077/latest > > Signed-off-by: Jens Wiklander > > --- > > SUPPORT.md | 8 ++++++++ > > docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ > > 2 files changed, 23 insertions(+) > > > > diff --git a/SUPPORT.md b/SUPPORT.md > > index aa1940e55f09..1fd746f7f7f2 100644 > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -818,6 +818,14 @@ that covers the DMA of the device to be passed thr= ough. > > > > No support for QEMU backends in a 16K or 64K domain. > > > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > > + > > + Status, Arm64: Tech Preview > > + > > +There are still some code paths where a vCPU may hog a pCPU longer tha= n > > +necessary. The FF-A mediator is not yet implemented for Arm32. Part of= the > > +FF-A specification is not supported. > > NIT: You would suggest to add: "(See the top comment in ...)". So one > can easily find the limitation. Good point, I'll fix that. > > > + > > ### ARM: Guest Device Tree support > > > > Status: Supported > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > > index 10f37990be57..bba99c576b48 100644 > > --- a/docs/man/xl.cfg.5.pod.in > > +++ b/docs/man/xl.cfg.5.pod.in > > @@ -1645,6 +1645,21 @@ in OP-TEE. > > > > This feature is a B. > > > > +=3Ditem B > > + > > +B Allow a guest to communicate via FF-A with Secure Partiti= ons > > +(SP), default false. > > + > > +Currently is only a small subset of the FF-A specification supported. = Just > > +enough to communicate with OP-TEE. In general only direct messaging an= d > > +sharing memory with one SP. More advanced use cases where memory might= be > > +shared or donated to multple SPs are not supported. > > Typo: s/multple/multiple/ > > > + > > +See L for more > > +informantion about FF-A. > > Typo: s/informantion/information/ I'll fix the typos. Thanks, Jens > > > + > > +This feature is a B. > > + > > =3Dback > > > > =3Dback > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Apr 14 12:54:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 12:54:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521126.809458 (Exim 4.92) (envelope-from ) id 1pnIwW-0007JD-9p; Fri, 14 Apr 2023 12:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521126.809458; Fri, 14 Apr 2023 12:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnIwW-0007J6-74; Fri, 14 Apr 2023 12:54:20 +0000 Received: by outflank-mailman (input) for mailman id 521126; Fri, 14 Apr 2023 12:54:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnIwU-0007J0-9w for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 12:54:18 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77265b7a-dac3-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 14:54:17 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id j12so1143964wrd.2 for ; Fri, 14 Apr 2023 05:54:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77265b7a-dac3-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681476857; x=1684068857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QItX4kx36BzpBSoyjOqYoLsNvoaJtFnUqdCC7RP/lNI=; b=v3Bg82ZImQ85yF/zvQQywf+xe/LxE6fcNLtLBfXkEFkt+slxSyw0AYQnY4xLiJ7WST OWHoZ6uYNcDTI5setzhlVl5E7F4cryv3v67nPwdEBVNwZcg47ouKUTdGmAe3vBYtzxee F9YpgJaXmNFYUqWNHei0UIpfRrDxmPX+O1gJrIQ9mNWqJPG3357jesn5VoYEodN6kmJx uOxx3bieA0qw5iy9LGgZkjMm7/NjU2wx77Rb4dKhlgsdCwuoKER94kiRLXG4cNWbHxea klMUEEXG5xy2bw8tf6qp5ODrhWX597LmRu4BHYIIAkSlzUwEdJlfqTDQu1B/trYxDEyA KK6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681476857; x=1684068857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QItX4kx36BzpBSoyjOqYoLsNvoaJtFnUqdCC7RP/lNI=; b=L8MkJ/DESRMV9dyTw2uCTVL90Lp+p1ZG6l/7Sm8iqhohlE/xX/WD/ecC1z7vvM+s57 Yvb0ufQK1zSdHSKiCRW52+8lem9ME00PaQUTSTOCh3cJLakLKsWbaMjlAi6inGgJHAfg IlKW22iAbC68vW6zYulNZIzuN6ODy2UPhp1YkCWL6ONN8cO8/AqaH0eUX4STAl/KsggT gutUD/Qs/huqjz1oaAnhjKdcuUIkuEhP3UWUMJAe1tt9gVCOx4EXOFWYg1/bGDwAxsqi 8Qkz2YrU4Rw05K4UffPLyyff88MHIwROhsQiFWOktKsz+G6rZdVBKu4VGtcPCX8ryDU0 6YPg== X-Gm-Message-State: AAQBX9ewyVBeZJxqXF24iOS/MC9R9Mz5bz/owowncGYjfS0kGXDkHp/T mXNdoLwC+GyCRxnlc2QtaxUxvPZiaBbx+7NsFVxPhw== X-Google-Smtp-Source: AKy350ayl0OXgBaZesP3BYAgSJQPytVASLtqXN7bM9l2pkthiM5eJbwvddimiJgzQOEjbx7BRVkFi2ni0E1JtF44erQ= X-Received: by 2002:adf:df83:0:b0:2f4:1214:d5b4 with SMTP id z3-20020adfdf83000000b002f41214d5b4mr1062374wrl.3.1681476856678; Fri, 14 Apr 2023 05:54:16 -0700 (PDT) MIME-Version: 1.0 References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-22-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 14 Apr 2023 14:54:05 +0200 Message-ID: Subject: Re: [XEN PATCH v8 21/22] xen/arm: ffa: list current limitations To: Julien Grall Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Julien, On Thu, Apr 13, 2023 at 10:57=E2=80=AFPM Julien Grall wrot= e: > > Hi Jens, > > On 13/04/2023 08:14, Jens Wiklander wrote: > > Adds a comments with a list of unsupported FF-A interfaces and > > limitations in the implemented FF-A interfaces. > > > > Signed-off-by: Jens Wiklander > > --- > > xen/arch/arm/tee/ffa.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > > index 0948cc636871..6424c222c885 100644 > > --- a/xen/arch/arm/tee/ffa.c > > +++ b/xen/arch/arm/tee/ffa.c > > @@ -13,6 +13,38 @@ > > * https://developer.arm.com/documentation/den0077/e > > * TEEC-1.0C: TEE Client API Specification version 1.0c available at > > * https://globalplatform.org/specs-library/tee-client-api= -specification/ > > + * > > + * Notes on the the current implementstion. > > + * > > + * Unsupported FF-A interfaces: > > + * o FFA_MSG_POLL and FFA_MSG_SEND - deprecated in FF-A-1.1-REL0 > > + * o FFA_MEM_RETRIEVE_* - Used when sharing memory from an SP to a VM > > + * o FFA_MEM_DONATE_* and FFA_MEM_LEND_* - Used when tranferring owner= ship > > + * or access of a memory readion > > + * o FFA_MSG_SEND2 and FFA_MSG_WAIT - Used for indirect messaging > > + * o FFA_MSG_YIELD > > + * o FFA_INTERRUPT - Used to report preemption > > + * o FFA_RUN > > + * > > + * Limitations in the implemented FF-A interfaces: > > + * o FFA_RXTX_MAP_*: > > + * - Maps at most 32 4k pages large RX and TX buffers > > + * - RT/TX buffers must be normal RAM > > Can you explain why this is a problem? Good catch, I can't. I must have added it by mistake. I'll remove it. Thanks, Jens > > > + * - Doesn't support forwarding this call on behalf of an endpoint > > + * o FFA_MEM_SHARE_*: only supports sharing > > + * - from a VM to an SP > > + * - with one borrower > > + * - with the memory transaction descriptor in the RX/TX buffer > > + * - normal memory > > + * - at most 512 kB large memory regions > > + * - at most 32 shared memory regions per guest > > + * o FFA_MSG_SEND_DIRECT_REQ: > > + * - only supported from a VM to an SP > > + * > > + * There are some large locked sections with ffa_tx_buffer_lock and > > + * ffa_rx_buffer_lock. Especially the ffa_tx_buffer_lock spinlock used > > + * around share_shm() is a very large locked section which can let one= VM > > + * affect another VM. > > */ > > > > #include > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Apr 14 13:29:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 13:29:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521137.809471 (Exim 4.92) (envelope-from ) id 1pnJU4-0002Oo-29; Fri, 14 Apr 2023 13:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521137.809471; Fri, 14 Apr 2023 13:29:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnJU3-0002Oh-Vh; Fri, 14 Apr 2023 13:28:59 +0000 Received: by outflank-mailman (input) for mailman id 521137; Fri, 14 Apr 2023 13:28:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnJU2-0002OK-KG for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 13:28:58 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062d.outbound.protection.outlook.com [2a01:111:f400:fe1f::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d26f363-dac8-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 15:28:54 +0200 (CEST) Received: from DB8PR06CA0009.eurprd06.prod.outlook.com (2603:10a6:10:100::22) by AS8PR08MB8491.eurprd08.prod.outlook.com (2603:10a6:20b:566::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 13:28:52 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::f1) by DB8PR06CA0009.outlook.office365.com (2603:10a6:10:100::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 13:28:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Fri, 14 Apr 2023 13:28:51 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Fri, 14 Apr 2023 13:28:51 +0000 Received: from ad04a3c511c1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0CD39F26-1907-4FCF-BD32-365204672364.1; Fri, 14 Apr 2023 13:28:45 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ad04a3c511c1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 13:28:45 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV1PR08MB7732.eurprd08.prod.outlook.com (2603:10a6:150:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.43; Fri, 14 Apr 2023 13:28:43 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::6b4f:579f:6dca:8b91%5]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 13:28:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d26f363-dac8-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snhBR0/mjQ5oUipLv/cbHjCeqCM07eecgS70/ZHYkqA=; b=CLGQoFgfnVJstUBhVeTem5FqptzgBX1j1lGcpv3dH/lEbPUYciZjgPDmM+ixrAgvsOB69rWNcSMuNSg3zlqFB/uc85/nlt2V8T1vAAQM3Z3rzHcMot1SohwEeB1g/Q0v7Y8mSA7q9oJgBF181bZD5GRp13Rek1fUs1FjN9m09qU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9b15a0689fb03e2f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3o23tdmV2j6qcD/+sg5XY85DhZ3bYZyLFuLkkp6kY/p9BUa54t5HBoZIMZM/29p3OhMEARayQ0u9+B08lmhA3bdp9S18LZ+6/6YjMbDHOvbOSQHet4HizmPBXq1zD9xuqNS9+zke6Irb+LdVKY7Yb6OxalMF4a87L1wNA7LefwN0G6l1lfahg1qqqVvWN4tPp9zp/TO7aFjsHSdBgInfUJenmu6Cf+QLgoYzV2rMKU0RgYiaywAF0dEpHGr2zfGEUTqs/1gleXNmSLzaePw1DxV5/Gk23XJpbQvh/6hyA8S52XqSJwPRcTs6Y/4HEq7U3MjWRHXevBIk3JX26Au1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=snhBR0/mjQ5oUipLv/cbHjCeqCM07eecgS70/ZHYkqA=; b=PR4kRNhorLgBA0TL6UW2HCSTaw5XDCb4HGnvy0QScV4gRlM0Cu7HUbuW40F25mcu51785sHBWG2XA6sOQbL3ahvjIS/+p5kaiEfiZY6sn07QMOuO7S3RhC8aj9PwyLUaWmuHKe5YXHBLjcHZlTbfKor3229HfS3uCBj18x4FTyuo37k0PNjwFfThnxlnEFdp6sWvkVfx136wIdu7Rc/wUg8UhhCh4eiftpD2C2dmq6Ce60UVlljDC4GW0uowWoQ1F8/yRkKt2VHQOwU+gOpcLHPJkXdayBfKq78fsZhSS5Xg694UU5qW7Dn9DkbXc6AXuVGeCYWc38OT+l8EBjE2nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snhBR0/mjQ5oUipLv/cbHjCeqCM07eecgS70/ZHYkqA=; b=CLGQoFgfnVJstUBhVeTem5FqptzgBX1j1lGcpv3dH/lEbPUYciZjgPDmM+ixrAgvsOB69rWNcSMuNSg3zlqFB/uc85/nlt2V8T1vAAQM3Z3rzHcMot1SohwEeB1g/Q0v7Y8mSA7q9oJgBF181bZD5GRp13Rek1fUs1FjN9m09qU= From: Luca Fancellu To: Bertrand Marquis CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Thread-Topic: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Thread-Index: AQHZbSQxNKEijLDBi06LhQ6zHwegOK8pMc0AgAGd7gA= Date: Fri, 14 Apr 2023 13:28:42 +0000 Message-ID: <8C042AAE-8256-488C-92C6-E4C0B5DEB3C1@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-2-luca.fancellu@arm.com> <190AEC88-68BE-4DEA-84D5-9DDF0F63A365@arm.com> In-Reply-To: <190AEC88-68BE-4DEA-84D5-9DDF0F63A365@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV1PR08MB7732:EE_|DBAEUR03FT013:EE_|AS8PR08MB8491:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c3b403b-afad-491d-aa7c-08db3cec300f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ElOEsLgAC++ZrJMXt0wODsLoHfu4XhSVFlp7SotoHf7Ym2A43kT2cCQAjvX1Z7Z0+ikcp+XjBtMG9SZZMekbS/496CtCmBGieaQeUzxFe7cfK0MAczT2RsdxybngFgMJWgDUxwcZsWyqv06i6M4wlhhG7WB+eqNF5VWP1Mg4XJp2lGAqmeSM4K9cqxBzpc2X17jhh977rhOxK4FAwdMbyOkpbA4dwd7d2TYZoHH+jKsBEHAnANp1eFJIhtMnKVsNiZi3j1fxYtGW9+/t2oXDJ6Y20g3yn6jXyzVfcQxxuFXc2NWh0fLnCL06pbftyBEJdTctFDyW8bNATwv7A9GRetzZP92W6GkRGvoztCZ+XITODZQ35qUATt26AjrfcZnbAgUzWrSzXPlOEeJKjrI1Kxrzgo8cha3/gS19YtGOmdJZ/96IY2brC+yLy7/udOCm9l3wYpyclasyGfbc9rJgK35wGm4tHvXS1f/gF0prv4inkxPJGI62YOJXMp7OzH5aAs3pKRkWZjOQN+9qKxpp3f6XnkuEfYOX2WSunlnp0N1PHF5Lh+ncN+nx04Xlu+0iYGqCHVRbG/Qx2eN/bvK04sbtlzqnXeDMg0qC9fS66dLn6s6CEq+zVD2ANw0fMv7AYDdvmgNnITLs7B5gVya/tQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199021)(37006003)(4326008)(54906003)(6636002)(6486002)(66476007)(64756008)(91956017)(66556008)(66946007)(66446008)(76116006)(316002)(186003)(53546011)(6512007)(6506007)(26005)(38100700002)(2616005)(83380400001)(5660300002)(8676002)(6862004)(8936002)(41300700001)(478600001)(71200400001)(86362001)(36756003)(33656002)(38070700005)(122000001)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7732 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ce1f7720-5c70-4dfb-e03a-08db3cec2ab1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 82vQjQTbCotXVhMtalVvZns+MatpACoC6+L1QBkQflSesIChuY55h1+JFwV+o8n0yHYOJo2Dmf4GbBjOFMUvj4RBIu+im6n8YsRdae73DkUXzNWrbMzjqp712rje3IM+TOgNjxyMP+NnHpW0VxLdqFAHYQMvG11ctzprfO/m8yQSAoN1b9gibQfOOYSaFpG/bXHMg4ChbLfJICWmGlUYlnVOiyoWTmDyIITKfc9qKDT1VSqmqLsxDNfEXMiLlbOfMukRva7miCXTS5nl6tmuFaYJgO2ZY9d2Td9VnunDuX/abePMwBwL67ZKVzWguvF/eCf/b8kG+Vh6xuHFZLR+nhoNyYiV5yW/+cQoVhYznSHkYAlDA0NENAhRCDxwjiDhsOBTMyIj7ZIQxP/ld8PxYAVc0/wi7BCWMmeeCPdVqd2kNc8i8FJVasqfEZn6IfF2iB2XrJlAQjj5PLCIO2PvGksUlMs9Y5bkQCD3XrQrC4o8PiMV/QmIaR7aym3Zn0Q9lNX9IcOlFepip6umzxgGcv5wU86yJ8ml9aM3yNXTgnmDDCkmKjTejdadjxgmxNW9NMGJ9m0/6MACbvmhYC+O0dhqOYFrmxJPp/twSnGbqc+nWObmme0RKbu6nf3IObEsYeD8R0B0+HB7+OmZyTmiRPq+CgHe3qsou5P4/NIqZqgAxm6iY6TmNJGGYPQY4YfW2ZBjALGDO4quKY5wpZTQlQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199021)(40470700004)(36840700001)(46966006)(36860700001)(40480700001)(82740400003)(2616005)(336012)(47076005)(53546011)(40460700003)(107886003)(6512007)(2906002)(6506007)(33656002)(186003)(26005)(82310400005)(81166007)(356005)(8936002)(83380400001)(86362001)(70206006)(70586007)(478600001)(6486002)(36756003)(6636002)(5660300002)(6862004)(4326008)(316002)(8676002)(54906003)(41300700001)(37006003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 13:28:51.9026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c3b403b-afad-491d-aa7c-08db3cec300f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8491 > On 13 Apr 2023, at 13:47, Bertrand Marquis wro= te: >=20 > Hi Luca, >=20 >> On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >>=20 >> Enable Xen to handle the SVE extension, add code in cpufeature module >> to handle ZCR SVE register, disable trapping SVE feature on system >> boot only when SVE resources are accessed. >> While there, correct coding style for the comment on coprocessor >> trapping. >>=20 >> Now cptr_el2 is part of the domain context and it will be restored >> on context switch, this is a preparation for saving the SVE context >> which will be part of VFP operations, so restore it before the call >> to save VFP registers. >> To save an additional isb barrier, restore cptr_el2 before an >> existing isb barrier and move the call for saving VFP context after >> that barrier. >>=20 >> Change the KConfig entry to make ARM64_SVE symbol selectable, by >> default it will be not selected. >>=20 >> Create sve module and sve_asm.S that contains assembly routines for >> the SVE feature, this code is inspired from linux and it uses >> instruction encoding to be compatible with compilers that does not >> support SVE. >>=20 >> Signed-off-by: Luca Fancellu >> --- >> Changes from v4: >> - don't use fixed types in vl_to_zcr, forgot to address that in >> v3, by mistake I changed that in patch 2, fixing now (Jan) >> Changes from v3: >> - no changes >> Changes from v2: >> - renamed sve_asm.S in sve-asm.S, new files should not contain >> underscore in the name (Jan) >> Changes from v1: >> - Add assert to vl_to_zcr, it is never called with vl=3D=3D0, but just >> to be sure it won't in the future. >> Changes from RFC: >> - Moved restoring of cptr before an existing barrier (Julien) >> - Marked the feature as unsupported for now (Julien) >> - Trap and un-trap only when using SVE resources in >> compute_max_zcr() (Julien) >> --- >> xen/arch/arm/Kconfig | 10 +++-- >> xen/arch/arm/arm64/Makefile | 1 + >> xen/arch/arm/arm64/cpufeature.c | 7 ++-- >> xen/arch/arm/arm64/sve-asm.S | 48 +++++++++++++++++++++++ >> xen/arch/arm/arm64/sve.c | 50 ++++++++++++++++++++++++ >> xen/arch/arm/cpufeature.c | 6 ++- >> xen/arch/arm/domain.c | 9 +++-- >> xen/arch/arm/include/asm/arm64/sve.h | 43 ++++++++++++++++++++ >> xen/arch/arm/include/asm/arm64/sysregs.h | 1 + >> xen/arch/arm/include/asm/cpufeature.h | 14 +++++++ >> xen/arch/arm/include/asm/domain.h | 1 + >> xen/arch/arm/include/asm/processor.h | 2 + >> xen/arch/arm/setup.c | 5 ++- >> xen/arch/arm/traps.c | 28 +++++++------ >> 14 files changed, 201 insertions(+), 24 deletions(-) >> create mode 100644 xen/arch/arm/arm64/sve-asm.S >> create mode 100644 xen/arch/arm/arm64/sve.c >> create mode 100644 xen/arch/arm/include/asm/arm64/sve.h >>=20 >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 239d3aed3c7f..41f45d8d1203 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -112,11 +112,15 @@ config ARM64_PTR_AUTH >> This feature is not supported in Xen. >>=20 >> config ARM64_SVE >> - def_bool n >> + bool "Enable Scalar Vector Extension support (UNSUPPORTED)" if UNSUPPO= RTED >> depends on ARM_64 >> help >> - Scalar Vector Extension support. >> - This feature is not supported in Xen. >> + Scalar Vector Extension (SVE/SVE2) support for guests. >=20 > I would prevent to mention SVE2 here unless both versions of SVE are supp= orted with this config. > Is it the case ? Hi Bertrand, Yes both versions of SVE are supported with this config, SVE2 is a superset= of SVE that includes new instructions, but the work done in this serie for registers settings and co= ntext switch will apply to both versions. >=20 > Cheers > Bertrand From xen-devel-bounces@lists.xenproject.org Fri Apr 14 13:38:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 13:38:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521142.809482 (Exim 4.92) (envelope-from ) id 1pnJdJ-0003wV-1l; Fri, 14 Apr 2023 13:38:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521142.809482; Fri, 14 Apr 2023 13:38:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnJdI-0003wO-VK; Fri, 14 Apr 2023 13:38:32 +0000 Received: by outflank-mailman (input) for mailman id 521142; Fri, 14 Apr 2023 13:38:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnJdI-0003wI-5h for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 13:38:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7e1b::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3791077-dac9-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 15:38:28 +0200 (CEST) Received: from DUZPR01CA0164.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::18) by DBBPR08MB5995.eurprd08.prod.outlook.com (2603:10a6:10:20b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 13:38:26 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b3:cafe::29) by DUZPR01CA0164.outlook.office365.com (2603:10a6:10:4b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 13:38:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Fri, 14 Apr 2023 13:38:26 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Fri, 14 Apr 2023 13:38:26 +0000 Received: from edd4ec2fb1a0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA36389E-0F1A-45DD-95E7-C4F68C0D5028.1; Fri, 14 Apr 2023 13:38:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id edd4ec2fb1a0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 13:38:15 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB9815.eurprd08.prod.outlook.com (2603:10a6:20b:614::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 13:38:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::8e01:7058:6f40:90e1%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 13:38:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3791077-dac9-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogctp1zZxuHa8uxipGyJGj0grO+wa7ak43rkcB7fDYo=; b=wjXLIbuKeaKduD74cNxLC/HcBsd+kJc5YgO3KEecjUrsePjHtKyC/TTTXLdQp6ILXAbyapK9X57zLhVsNqQLyGLy1wL/UWi7m0HtseK15sJ0PiVYUdM84xkv6yCMQf3z16U7yx2ewtlt3Fwzkt+WVPaqjuh7DqLZg79c1yN1qxE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2afed1d247fdabf3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jyay1o0h0OidO6TELjBmi/U7fLiWNdWda92Y7hqdiB3Tw23cFlCLbovy0g2P29+Enriv8OVHUgHEnSPDKHaJUQ7VMjGkvYhbkchoN7sRY5oDtND4ZxUTLYXQJgkJps4rEyXd1GQt/HDX4WJgvLxgfD3NfgFLIFmMAoVVI2OU/jf6aOrlSjjXIOch7hWhR6zcb2BTuzgq/ioJ1o5TvZja481uFtY/we2PegC/1KLwKg8jJKTGNwjVKeP2opPw+XvLLWur2x1TUhS9ogVF2q+NQ1FBsazwdixnyjF6wuDdgnuemyf7R0yc9ka5Cd/OjtE2CCOCDKUbUn3Y23E/fGP3mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogctp1zZxuHa8uxipGyJGj0grO+wa7ak43rkcB7fDYo=; b=JYQLZjiwRgNgsk33n/zkRHoFkoVhpoirOcFsusmD5NLJzIpbZB0g8x/ZYanL6oEIWt4HBLpm0ZfgV28hpeNABUPGho6camYN93hEEr3atOv1gvFkk/vPAlGqLwyGK9LiqQ/8OvumaJ5lw5U61MOmuIrDO9DkIwJdYeH+DCpbhkadDYR+t2pzWNoGG4zbpcDETlFOitkWwA+U6SJDTt4pCDeoBT8dGEf+eFwekjTAqiNqmgJqNR5lDKqal06hTxRPSym5KFy0EGJkySoVjJgxJIm0o4vIodsGtmmRParnFpFtfhPle/Fa8Tv+3f9ZZCyNa073zzwYbKGJp7Ut0MdAAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogctp1zZxuHa8uxipGyJGj0grO+wa7ak43rkcB7fDYo=; b=wjXLIbuKeaKduD74cNxLC/HcBsd+kJc5YgO3KEecjUrsePjHtKyC/TTTXLdQp6ILXAbyapK9X57zLhVsNqQLyGLy1wL/UWi7m0HtseK15sJ0PiVYUdM84xkv6yCMQf3z16U7yx2ewtlt3Fwzkt+WVPaqjuh7DqLZg79c1yN1qxE= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Thread-Topic: [PATCH v5 01/12] xen/arm: enable SVE extension for Xen Thread-Index: AQHZbSQnZHhi12xjyUK0b5ypet9SdK8pMcIAgAGeBQCAAAKagA== Date: Fri, 14 Apr 2023 13:38:11 +0000 Message-ID: <6F8AEB0D-5DB4-44EB-BC64-F8488D4DE109@arm.com> References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-2-luca.fancellu@arm.com> <190AEC88-68BE-4DEA-84D5-9DDF0F63A365@arm.com> <8C042AAE-8256-488C-92C6-E4C0B5DEB3C1@arm.com> In-Reply-To: <8C042AAE-8256-488C-92C6-E4C0B5DEB3C1@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB9815:EE_|DBAEUR03FT031:EE_|DBBPR08MB5995:EE_ X-MS-Office365-Filtering-Correlation-Id: cd689704-318c-4190-b9e1-08db3ced8672 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ol9Er6Swuyoxq2YaWBQj3JwDEKGzYDPSxCm+aSyFacfsN++i6ZNAMRDIwe1n16pMAgSvg1fBjjUfl2FGk6Fb32ioYAp2X8nM4FwchD00erLNpSBNQ+Jhsb4OQhXbqp64IjoIviYIXC+vSFyaO0gzOFQEG/Yuah2HxNfySb59l3iscKg5/83XuSF2KraLv0Fj8qLl6yOccoRo1Oubhi6NIn4O9gDyvEk8WC9VDb5Axhm02HNfM1xTmp+9F8ZsjCDQ9lWhW4qaGSW7oLNCqkmjD3uoXU0NzdMwGKAJYskCfYHMaDu5dC4NfkIl5vxtqN1xVlCZuIgFsZ1rA36TDSwOdEN/LM18XKTIGkD3S7SUa35hM2rMKOIFmSvKbhG2AbrLNo0Dd8Gav4jrr3pZ6H6uljYRxIxro/VELN9YfL+9Am32niATCk4JDeqtl8c9d/IMShAhMK0rkYlFrOHnP6A8mZlYftuxEVZPl3L6TpGizwexW5HYoVbd7vNE4CaxO4V6htem0eVOT5ywdHUcsMZWIqNQ0JPr4wCzqXY86wg1SkgUzwe65XQUoQ/QzH4OhMVsJOocZuRD3jLTFQpJNrDFDpwypBDdVjlkGEQptkC9SRT9vth6zgFQifOyl6OZDDcZ9apVpUI/+K9bNontzXmJTw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199021)(38070700005)(26005)(186003)(6512007)(6506007)(53546011)(6636002)(54906003)(37006003)(33656002)(478600001)(122000001)(2906002)(8676002)(8936002)(6862004)(83380400001)(41300700001)(5660300002)(2616005)(38100700002)(4326008)(316002)(66946007)(66556008)(91956017)(76116006)(66476007)(64756008)(66446008)(86362001)(6486002)(71200400001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5048B202B74CC746961C6F6C754AFA56@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9815 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ec96df73-73ff-4436-74e2-08db3ced7dca X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xoc0FhZyHJZhaq4Rlt77haDNYq1EB2NwtrwBHcw0LiBrfL0ZEm3ZeJkFDTZSAhU5rs+2FoVSnhcmrgYwBqyW4124ga+OYsd8NTSt6/kWmr0PfC7zWVBVZgSEzYtkChxYigxq04qVle3YHXq8869npEJ2ysORfZz8+yw5Bb2aaT4Fouc0V/PjwJwD5ge6Bc5cm9iDgZp5avve+qqR0WNDqdWxI1zfc5w8/ksLFAVu0Ytk8v1MRUUBuLxIttEWJOzSMn7pmB+Y16u72PrzOLX/4ZmBwOoO+oPMmn/d7UjauuEtP0YOkDRsmgdS69SNaZnRKFQfc7Hp+SGIIqXGbn6IgfB4JtO+LN62dqVRLl3c+hpzRlnHeawECpJBgbMoqOi++AkVby2tsGHdcPOiGZHB4gOsmgwaRssE5OxSDNbP6L+xOvTwBSMmI2/evr7yoCbt2hx21O3e0SWZYfoA9rKdC9EyxQYUZGM6RdUkN7BQ89gA/cRRHwAzrIo+tCICllJ5O88iKQP5AXHcIPzm47EnP5jTyvcC+IFgUx6+nb/3fmlr0nE9eb2Iqbfn23Nw7riEwMRmewnZQEQwZIa2Nx4XNfoo98DgpLeeECgF4EJgxozq5aKAG4tS41c+X11RWMmzXVygArGbCzn97zn1vcnH/2dA3zLmrerJh9DZfFXg8JASj+keLNtxe74cxxkRFkGMWbVOUqrKvDbBDwmsxR/h8Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(316002)(70206006)(70586007)(4326008)(8676002)(6862004)(8936002)(2906002)(41300700001)(5660300002)(83380400001)(6636002)(478600001)(54906003)(37006003)(40460700003)(86362001)(336012)(107886003)(36756003)(26005)(6512007)(33656002)(2616005)(186003)(36860700001)(6506007)(82310400005)(6486002)(356005)(47076005)(53546011)(82740400003)(40480700001)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 13:38:26.3482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd689704-318c-4190-b9e1-08db3ced8672 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5995 Hi Luca, > On 14 Apr 2023, at 15:28, Luca Fancellu wrote: >=20 >=20 >=20 >> On 13 Apr 2023, at 13:47, Bertrand Marquis wr= ote: >>=20 >> Hi Luca, >>=20 >>> On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >>>=20 >>> Enable Xen to handle the SVE extension, add code in cpufeature module >>> to handle ZCR SVE register, disable trapping SVE feature on system >>> boot only when SVE resources are accessed. >>> While there, correct coding style for the comment on coprocessor >>> trapping. >>>=20 >>> Now cptr_el2 is part of the domain context and it will be restored >>> on context switch, this is a preparation for saving the SVE context >>> which will be part of VFP operations, so restore it before the call >>> to save VFP registers. >>> To save an additional isb barrier, restore cptr_el2 before an >>> existing isb barrier and move the call for saving VFP context after >>> that barrier. >>>=20 >>> Change the KConfig entry to make ARM64_SVE symbol selectable, by >>> default it will be not selected. >>>=20 >>> Create sve module and sve_asm.S that contains assembly routines for >>> the SVE feature, this code is inspired from linux and it uses >>> instruction encoding to be compatible with compilers that does not >>> support SVE. >>>=20 >>> Signed-off-by: Luca Fancellu >>> --- >>> Changes from v4: >>> - don't use fixed types in vl_to_zcr, forgot to address that in >>> v3, by mistake I changed that in patch 2, fixing now (Jan) >>> Changes from v3: >>> - no changes >>> Changes from v2: >>> - renamed sve_asm.S in sve-asm.S, new files should not contain >>> underscore in the name (Jan) >>> Changes from v1: >>> - Add assert to vl_to_zcr, it is never called with vl=3D=3D0, but just >>> to be sure it won't in the future. >>> Changes from RFC: >>> - Moved restoring of cptr before an existing barrier (Julien) >>> - Marked the feature as unsupported for now (Julien) >>> - Trap and un-trap only when using SVE resources in >>> compute_max_zcr() (Julien) >>> --- >>> xen/arch/arm/Kconfig | 10 +++-- >>> xen/arch/arm/arm64/Makefile | 1 + >>> xen/arch/arm/arm64/cpufeature.c | 7 ++-- >>> xen/arch/arm/arm64/sve-asm.S | 48 +++++++++++++++++++++++ >>> xen/arch/arm/arm64/sve.c | 50 ++++++++++++++++++++++++ >>> xen/arch/arm/cpufeature.c | 6 ++- >>> xen/arch/arm/domain.c | 9 +++-- >>> xen/arch/arm/include/asm/arm64/sve.h | 43 ++++++++++++++++++++ >>> xen/arch/arm/include/asm/arm64/sysregs.h | 1 + >>> xen/arch/arm/include/asm/cpufeature.h | 14 +++++++ >>> xen/arch/arm/include/asm/domain.h | 1 + >>> xen/arch/arm/include/asm/processor.h | 2 + >>> xen/arch/arm/setup.c | 5 ++- >>> xen/arch/arm/traps.c | 28 +++++++------ >>> 14 files changed, 201 insertions(+), 24 deletions(-) >>> create mode 100644 xen/arch/arm/arm64/sve-asm.S >>> create mode 100644 xen/arch/arm/arm64/sve.c >>> create mode 100644 xen/arch/arm/include/asm/arm64/sve.h >>>=20 >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index 239d3aed3c7f..41f45d8d1203 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -112,11 +112,15 @@ config ARM64_PTR_AUTH >>> This feature is not supported in Xen. >>>=20 >>> config ARM64_SVE >>> - def_bool n >>> + bool "Enable Scalar Vector Extension support (UNSUPPORTED)" if UNSUPP= ORTED >>> depends on ARM_64 >>> help >>> - Scalar Vector Extension support. >>> - This feature is not supported in Xen. >>> + Scalar Vector Extension (SVE/SVE2) support for guests. >>=20 >> I would prevent to mention SVE2 here unless both versions of SVE are sup= ported with this config. >> Is it the case ? >=20 > Hi Bertrand, >=20 > Yes both versions of SVE are supported with this config, SVE2 is a supers= et of SVE that includes new > instructions, but the work done in this serie for registers settings and = context switch will apply to both > versions. Good so this is ok then. You can add my: Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 >>=20 >> Cheers >> Bertrand From xen-devel-bounces@lists.xenproject.org Fri Apr 14 15:20:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 15:20:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521147.809492 (Exim 4.92) (envelope-from ) id 1pnLDd-0006aD-BM; Fri, 14 Apr 2023 15:20:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521147.809492; Fri, 14 Apr 2023 15:20:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLDd-0006a6-83; Fri, 14 Apr 2023 15:20:09 +0000 Received: by outflank-mailman (input) for mailman id 521147; Fri, 14 Apr 2023 15:20:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLDb-0006Zp-Bf for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 15:20:07 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3691e90-dad7-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 17:20:03 +0200 (CEST) Received: from mail-bn8nam04lp2043.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2023 11:19:59 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH7PR03MB7223.namprd03.prod.outlook.com (2603:10b6:510:243::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Fri, 14 Apr 2023 15:19:54 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::bb8d:7344:7172:6ee%3]) with mapi id 15.20.6277.038; Fri, 14 Apr 2023 15:19:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3691e90-dad7-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681485603; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=KZASkSgfwqRxMeZvPhT1iszvELyMTNOOjVdR7aVlPNk=; b=gx/grlOM4nFEmctYR7eZkuK3/21fHsDwRkA7b/SnppcspBLA8Xnc6hGB tNcwAiDVOQJyfgDIed49uX1WNTle/LZVrxkdrI4UsgLLg+GOnKH5TNAuS B3EN5qtTzbc0V+VuPK0Fcszz0PyHUWGyf8V+8n/iARSRY+GrBCasWjVIU A=; X-IronPort-RemoteIP: 104.47.74.43 X-IronPort-MID: 105442746 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PMUg7aD6EOmkpxVW/x3iw5YqxClBgxIJ4kV8jS/XYbTApD0h1zRUz 2tKWWqAPP+LN2ajedt2a97g9UpS6MTdndYwQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G9B4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw+ttLX2Yf6 sMjEwtWQDCyutu4zqCSRbw57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exruAA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WPdry7w3LCTw0sXXqooEo/o0a86vWau7UkIUEMdDkGqpqm23xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xBHADTztLb9EOrsI6RTU2k FSOmrvBBjtpqrSZD22c8rS8qim7MiwYa2QFYEc5oRAt5tDipMQ5iELJR9M7TKqt1IWpQnf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodd7xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:MRFC2aDKzDKQcg7lHejHsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwOU80lKQFmLX5WI3PYOCIghrNEGgP1+vfKl7balDDH5BmpM BdmsFFYbWfbGSS5fyKmjVQeOxQpeVvnprY5ts3mBxWPHpXguxbnnBE4kHxKDwGeCB2Qb4CUL aM7MtOoDStPVwRc8SAH3EAG8TTutHRk5riQBgeQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7hGhdf7zdNHJcqUzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iFnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjXuVm2Hqr8DVTC8zT5Mpv/MRTjLpr24b+P1s2q NC2GyU87JREBP7hSz4o/zFTQtjmEaYqWcr1cQTk3tce40Db6I5l/1owGplVLM7WA7q4oEuF+ djSOna+fZtaFufK0vUu2F+qebcLEgbL1OjeAwvq8aV2z9ZkDRS1E0D3vESmX8G6dYUV4REz/ 6sCNUmqJh+CustKY5tDuYIRsW6TkbXRwjXDW6UKVP7UIkaJnP2rYLt6rld3pDnRHUx9upypH 39aiIZiYZrEHieSvFmnac7vywleV/NEwgEkaplltpEUr6VfsuZDcTMciFqryKamYRgPiTqYY fOBHtoOY6dEYKXI/cu4+TfYegmFZBMarxghv8LH3Szn+nsFqrG8sTmTde7HsucLd9jYBK0Pk c+ X-Talos-CUID: 9a23:dKHvXG7k280+QGZHVNss9HMoRMd0bULm90yLDW+JNF9nRq+8RgrF X-Talos-MUID: 9a23:1smJzAnYnR5Fggo7No9HdnpYMvU4xPX+NXswurAd45ePbjZhPGeS2WE= X-IronPort-AV: E=Sophos;i="5.99,197,1677560400"; d="scan'208";a="105442746" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dYN+lxuu97RJHO2KlJdpI6kgwB6sLFE0RXADMxGi2OwqKy7f9forBs0JSw0nViXUe0r1ufJY9yFz7tbVIpZMIzGy+RNRdVz8LiaY8L+WuHkE6lZIITNwj9dDNg3CJ5VBf4++IzyFk4nXOMIVSC8OAqtIq9DyAYH8HbQDh/fi4s8nh9n5qbglLVfoisW13SmKZbt20+K9uYuLw2t9eGyQqqZAAG8jCdsVRaJR9Y9V11z2YI5NbKw0k4M77vgEBmNujuOeAzStj6wd4dXO3mHm9+RSmU2hw5MzFMRpOGoB5/DXhdeGPxqMUGqAE7y9OMJ6xyk7d13qIsCk033bd931EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1p+jVcCxqzh6neMgNDhH9OkgSf5UEdomAAqkuunpqpE=; b=ZGEm+0IDixL5x2Rii4qzaksWrl1r3eH1HH+dMiYCvJgYOSypVIzYxXzcums3XA7tVufYQmklpUKm8HbviKAD1RzT/k+IyHZNekyzEYrS2bYukFt653pnkzt9Rj/Q6Ofy3qGNJqEzv6tem7wM9cW5h+wReOFn7JLtCHZbnNxJO8cuII74xqm/sSIhV4kPTiaSDZKwlvEUtOEkfl4dOpO3O2NOJ+knqX205wgaq+iG5iOmdudatw+PxT6lf+zTo4ud1hzf6XRxb5SoxGEA1LApd+rklGWzvPi28/4SvZyiHmzR0uJX3tVIlLGI3LEsYyhKWCqR/uOk151YYt+9pBNxzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1p+jVcCxqzh6neMgNDhH9OkgSf5UEdomAAqkuunpqpE=; b=c0nl3uUaW82dStoUESvSzuPfx6dzPwB9RIcoXGkWCBX6rMrLAs7gj+8uyu9Dq6fY01Q58oovQcMdjMhBWooEzRGHoJYOrKGnX/59YOE/1gUEcmicV6iIjjGlkR/t9hwYZvDEGuxGYvD3j+VsG04FNj6dVTVjmRKFj55CDhYylAg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Josh Poimboeuf , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH] create-diff-object: handle missing padding at end of special section Date: Fri, 14 Apr 2023 17:19:33 +0200 Message-Id: <20230414151933.53851-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0204.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::14) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH7PR03MB7223:EE_ X-MS-Office365-Filtering-Correlation-Id: d35c8331-6aaa-47cd-d3a5-08db3cfbb2eb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GPnMOhTNJGjqYRWEdqdljf5rBh2dDiFcQzR9osoM4QwKEUBCqxGCnOXgRQaOXFd7nazPTO+2YYKvn83gnSgLDEOyVc9+Bdpyo3g6bRvYC99sUOmut63FkX+5j89Bd9JPeUnanId3kaGS221nTH9UYmDSsILK2tSHt3h5pqC/lBhhBlxAKci4csHqppoWDwzpKmPTLhFss+r7zz3whzJKZ+QinJi05IeK2wEAzdQIpZ2V7kGtmo6Z+9nM3xLyE2E61xIM/bTdBFLQL8GS5n5E/qoo8bASi+aSGEBTY/kwTomrTVR4DkxADd+yKyAUDpAyl07dCuFblu9fQ4VOyIgtoQxRBVUp5PslHa21Qp06e/g1zWtvUYJoclhWD3rTHWOiABcW2lULHMW5fs15oagUi7wnyLjH7vFWc/0R4IlCx0Bmw6UJ7thOuDuBqfK73lqmAPTJfpyYDoxn6gEkSBmI3En1gPMg+Leq9tR9zvsg28JvwCLtdd4/N8xOqk6jrwc727O6E4ZYy6RPTOQZSgLLgfDaBr5GjvdpXlrUTaZUjF4Kn3GQBWerVPSuaFcCPVLg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199021)(36756003)(6486002)(4326008)(41300700001)(6916009)(66946007)(54906003)(66556008)(478600001)(8676002)(66476007)(316002)(86362001)(2616005)(6506007)(1076003)(83380400001)(6666004)(6512007)(107886003)(26005)(2906002)(5660300002)(82960400001)(8936002)(38100700002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW1GVHlkVGtkRVhkZHN4YjJnTjdsS3NXd29EMW5iNkw1UTFQOEpic01UZTla?= =?utf-8?B?a1FNc3h5ZzNtM0MvK0FGSGZFa0NwMDJKcThHbk5LdGxqRG1IRm1wY2UvZitY?= =?utf-8?B?WktwV3g3MmNiamtFQmxKSlRpblBIVEthS0swUzMrL0E4MWkvcnAwU0pVZE1J?= =?utf-8?B?WWdQK3pKK1FIamFPc0tjU3o0YzA4Y2hzMkJRaVM5MmFZRlVUTnZMYS84ajRY?= =?utf-8?B?QzNoZHJnaXdrbzdOYlc2R0k0bzYxQm4wR1VVdlgrYS9TVkYyeFhXTk42SDFr?= =?utf-8?B?Qnlldm9yN2l2SlJUQWxZNDlnTWxOWHExaU5xSnZlZXgyWUhxZG5ncXBkRXJw?= =?utf-8?B?UDRiN1ZPWVl4b0toOFZLbmYyWmtESitZYnowNy9Ec2Jxd2VhS3FrZGF3dUZK?= =?utf-8?B?NXdLelN6TmZXT2o5bDdqRXB2NGF1Y1ZxZ21pR3hCQ0hDZEdDMVhBaEFaOC96?= =?utf-8?B?MDUybmswYU1FQVhnTkUxQjhzVHlRQ0Z5b1hJNSszSW8zcDQ5VVZPYkpGRkhH?= =?utf-8?B?QjM1Y05hSmF5bHBobWYyaTJDMXdDOElzcE9TN2ppVUlma1VMVDVyVVN5NkFm?= =?utf-8?B?dE1sS1JrWnlxOFp2UU1yYWU5djNpMTc2MXgxWldoOFVFY0tMSzlqOHhEd1Vw?= =?utf-8?B?a2JYMm9LRjFaMHprR3FHSTFnaHJIOUxkekRXMTN6N3VSYUpzUGx1YWloblJR?= =?utf-8?B?QjRWNFFvWTViQjQwWkUwSkZuN2lVWHYrMlhNdm1GZmVrbk9JNXIyejZmejJB?= =?utf-8?B?SEZCUFA3b0MxUS9oSHkvbWwrSFN0Q1VsM1hJb1BQK21zempaMmNwSjcwSzVu?= =?utf-8?B?QnpiMzhTZUZEWmN5dXNCc2F0MlRwSUt6NkxxOEV6R2hFYURKZTBIUmVaU2pE?= =?utf-8?B?Z2hiUDhXbzJzbmYzNWhUdDlJWTZDb0IxaHNYbFpMbmFaSGE3VXpLdGJOSURm?= =?utf-8?B?ZzROV1hoVlVxb3hYNnB0RUtiTGF0RkJZQkorRU93cnVRQ0JHV0hXZ3lTS0pJ?= =?utf-8?B?Q0Jabk9PQzRZRTVTRnBVNm4xSm5oM2JLdGNCdHB3RmgrYzBXYTA0VXB0bXBk?= =?utf-8?B?WkxYMzhNWW8wbXJwdkwrZmVqK09mWVFnTzVqTHdiemxGTC8vcVoxcDNzUENR?= =?utf-8?B?dHl5ZHJqVkV0ck9Vd0RZZ0ZQcHh1YjBvQ0NNeXRSMjFVNkhuYkJlSGoxdm1k?= =?utf-8?B?RjVGM0tOT0pRZkozSFhpclI4SEhaamNUb2FsTmFYQ1NYVnFlSFZzZE54MUF0?= =?utf-8?B?cnNsZkh1alRST3BQTXl5NEhvOXlTZVQwQUZlbkNkVlZ2cTY3RzZTcnZwdzM0?= =?utf-8?B?U1VvY3ZZYTVmbzQvVkxzbnpvOTBvbDNKcWJuaTFacHhZdGprbmVseEE1VDNo?= =?utf-8?B?TWVlYW45SmFQSGcyWUhnekhJSjJ6WGwrYyswZ080WnVGbi9ZODBSellkbklq?= =?utf-8?B?cTd5YkVRY1J2VE1uTk1BVFNPVjcyZDdNbFBSWmxudVdIQ21XTDJhSmRsNUFH?= =?utf-8?B?VWlLMmROSWtraXUzZGNlL1I1L2RZdWZRUmREaXdFbzY5Z0RMNFEyK2lFOGNp?= =?utf-8?B?Mnk3V2tHK3ZXemdtbnFvejJ2TEZEWEpFV094dU1aTG9VZVBtd1lEK3A4dDhL?= =?utf-8?B?enZNTHlYNDJQY2NHTWtOa3JkbEZKV3gzYk9TREFUUER2dlB0MUJGREtEU2N4?= =?utf-8?B?TzlEUXdqRWozWHlVN3NmU2M4eWd0SHRIUThWU2Y3d0RyWlVVazhHbUVoejZW?= =?utf-8?B?bDJuemtXdWdVWGFNZ1dFc1c4RVlvUWkrVkxSOVgrTjU1TTVtQzhtUlhtMzN3?= =?utf-8?B?UWpLSCtwc2Z2NTdCWXkzMGtrZ3lzaWMwWjlRd2h2VC9wbzNRWWFmMy9xbXAx?= =?utf-8?B?WmFZTDUvSUxaS29WVmxJcEZ3SUhXQXVwa2FhSE15YXUzaE14M2RLMGsrSFJN?= =?utf-8?B?bFI5R21JckVERVJzdDR2TitEQXV4aXZJWXBmMHhTSTVBemk5WG1lMURxNEp5?= =?utf-8?B?MFFiUVlPcnRvVDNqcFVCenZpYi9NekRZSzNpSzBPa1FTc0ErREFLOWZZam5G?= =?utf-8?B?anBmcTF0ZTNLQURYZnQvZWZrYUc3TURkdExHaGJ1eTlFUURRb3VqN0VBVm8z?= =?utf-8?Q?GQhBrLD50crx13IvCAF7yRSU6?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Q4bpxfPap184UEiEOiz2EhoU/tjLAvsd7BdFjsvJylMQ8yzmErntINRQe4nUANE/HX6KHMMwAqNrtJ+ncw50kWya+n8MDoBAlCsGbyNfUxlOLx8r2r72XPaKPapjkyM2fKb+BgsheehDv3fGQfE0r6gpWMilbzTHBQi8S4I4flsSR712cJBs2eywjIEiTtNB7PbXkqjlAJm20ORNkoMFai236xTy9Jwua0m9uPwo92yWsc/B3QvoB9gGKNBhPnOBx/VUvNj2HQ8G30UGeT3zlLYm1U9wFWlG49YwMz9qaobiEjOt2uG+yzHBpi6zPBxoGVjyi+WA56TqPDkfbnfpPqdXVGDLtHvgQ4rZMb2qIKaVNlmX2bWg4tiPVZLDEX3zIQltdG148aPdeVuX7cTHyLxnaXE6gB46rcqqGNf47yUKbxdZB6Tt0sZMCHuLaWdLAvtP1tGWnufAlfHO64fb/AIQk5QD6FkCvOsh7xD3AEAyNgGe3JLs0cj83bUFzHyl53FS45sai3mJuIs8ESX8Gb1aK31fFSxSHZMlvbYOXLN2g4yL/CuGt21HI1c2QOLgUHhhphMbG2ZOH61HwLKuY/X9T/x7pugbSSnuav/Kzlv/+pVsQaVk6dpYBWBG1y+zDfLvCmHmOWSLo8ghLrNz0i3zw8spnk9r1D2YwFD93d+Q7g39ZNmoLEkx1j9m5rDhxDJxo5Zq9siFTxlHFkenG3/VAS62u8xb1nWVvrS1+79OXIJKKwobZ4gYghcltj0dVWu44yKTKfpdclbNcs0q+gbaZp5RS+pfXOCOjq17K8CGsRpMGDxvVVXN7bKXvfQ+Jqxr0zVQFlpGXCjJg6zBng== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d35c8331-6aaa-47cd-d3a5-08db3cfbb2eb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 15:19:54.4118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9GfrlnQDQuZLeQeIenbIie23AMmGLK34uptR1JDTZGp/D0uBbkwheuqr+s6wNI4FlqC58LH0LYC5bcEM0YU3KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7223 From: Josh Poimboeuf The paravirt_patch_site struct has 12 bytes of data and 4 bytes of padding, for a total of 16 bytes. However, when laying out the structs in the .parainstructions section, the vmlinux script only aligns before each struct's data, not after. So the last entry doesn't have the 4-byte padding, which breaks kpatch_regenerate_special_section()'s assumption of a 16-byte struct, resulting in a memcpy past the end of the section. Fixes #747. Signed-off-by: Josh Poimboeuf This is commit: c2dc3836e862 create-diff-object: handle missing padding at end of special section In kpatch repository. I've seen the .fixup section get an alignment of 16 but a size of 81, which makes the error removed in this patch trigger. Overall I'm not sure why the original alignment check was done against the size of the section, the alignment applies to the address of the section, not its size. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc: Ross Lagerwall --- create-diff-object.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/create-diff-object.c b/create-diff-object.c index d8a003216096..67784642bcd7 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -1204,7 +1204,7 @@ static void kpatch_regenerate_special_section(struct kpatch_elf *kelf, { struct rela *rela, *safe; char *src, *dest; - int group_size, src_offset, dest_offset, include, align, aligned_size; + int group_size, src_offset, dest_offset, include; LIST_HEAD(newrelas); @@ -1234,6 +1234,18 @@ static void kpatch_regenerate_special_section(struct kpatch_elf *kelf, for ( ; src_offset < sec->base->sh.sh_size; src_offset += group_size) { group_size = special->group_size(kelf, src_offset); + + /* + * In some cases the struct has padding at the end to ensure + * that all structs after it are properly aligned. But the + * last struct in the section may not be padded. In that case, + * shrink the group_size such that it still (hopefully) + * contains the data but doesn't go past the end of the + * section. + */ + if (src_offset + group_size > sec->base->sh.sh_size) + group_size = sec->base->sh.sh_size - src_offset; + include = should_keep_rela_group(sec, src_offset, group_size); if (!include) @@ -1269,12 +1281,6 @@ static void kpatch_regenerate_special_section(struct kpatch_elf *kelf, dest_offset += group_size; } - /* verify that group_size is a divisor of aligned section size */ - align = sec->base->sh.sh_addralign; - aligned_size = ((sec->base->sh.sh_size + align - 1) / align) * align; - if (src_offset != aligned_size) - ERROR("group size mismatch for section %s\n", sec->base->name); - if (!dest_offset) { /* no changed or global functions referenced */ sec->status = sec->base->status = SAME; -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 15:58:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 15:58:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521152.809502 (Exim 4.92) (envelope-from ) id 1pnLoI-0001iJ-A9; Fri, 14 Apr 2023 15:58:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521152.809502; Fri, 14 Apr 2023 15:58:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLoI-0001iC-5y; Fri, 14 Apr 2023 15:58:02 +0000 Received: by outflank-mailman (input) for mailman id 521152; Fri, 14 Apr 2023 15:58:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLoH-0001i2-2k; Fri, 14 Apr 2023 15:58:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLoH-0006hd-1f; Fri, 14 Apr 2023 15:58:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLoG-0006zk-MQ; Fri, 14 Apr 2023 15:58:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnLoG-0007Cs-Lv; Fri, 14 Apr 2023 15:58:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KBuBFfQZqELlxjZoDe5vg5MXsq3VLmY7J8hnmSwdY/U=; b=MvTEoUI707dgw0asv8bo8cGx2r 9OAyQMPxU1hhSSnvS4QiG2k6XLlA213YMNsujq6srIXb//WY61ZoSQ0O8z6n+gMxgtN278Ksl2juL EjMvkLUwwD8qpHYUQU2cGclOyLSfM0VCtO7ky0H99sHZMpQOB4AX9FxBTkBJtauec300=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180261: all pass - PUSHED X-Osstest-Versions-This: ovmf=c9fb11f92f52e06bcb1279b467a3b2667757be44 X-Osstest-Versions-That: ovmf=55b67b6950e648338adfe8ec54aeb26ed89d2c97 From: osstest service owner Date: Fri, 14 Apr 2023 15:58:00 +0000 flight 180261 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180261/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c9fb11f92f52e06bcb1279b467a3b2667757be44 baseline version: ovmf 55b67b6950e648338adfe8ec54aeb26ed89d2c97 Last test of basis 180250 2023-04-13 19:43:30 Z 0 days Testing same since 180261 2023-04-14 13:43:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 55b67b6950..c9fb11f92f c9fb11f92f52e06bcb1279b467a3b2667757be44 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 14 16:18:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 16:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521158.809512 (Exim 4.92) (envelope-from ) id 1pnM7Z-0004fr-U0; Fri, 14 Apr 2023 16:17:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521158.809512; Fri, 14 Apr 2023 16:17:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnM7Z-0004fk-R2; Fri, 14 Apr 2023 16:17:57 +0000 Received: by outflank-mailman (input) for mailman id 521158; Fri, 14 Apr 2023 16:17:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnM7Y-0004fe-E2 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 16:17:56 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7fce995-dadf-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 18:17:53 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2023 12:17:51 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO6PR03MB6226.namprd03.prod.outlook.com (2603:10b6:5:354::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 16:17:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Fri, 14 Apr 2023 16:17:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7fce995-dadf-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681489073; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=jEZOa8afM7pe3p3pvBaKoGXqiXUTARSdTOf0VVwjX2o=; b=LpaHS1d6YNatkzxzkGpIQK9MDTSPYmwLZXbVPwwXDt3ahgMWQe0scIkf kYAmtnrU8yrij6FyHq1n+RcOoT4J0AJWiyAuUevwFTds6tAl7q92XiRHX 8C6yf4vjOduLP/yln6DPnXKk6SdeN0DTah3BpT0X57etydpufX7Vw6GtO 4=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 105450429 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jETZSq9Kj7dclMeJLKEfDrUDs3+TJUtcMsCJ2f8bNWPcYEJGY0x3x jNNXG+OO66JZTT2L9AlOoy1908C6sCHyddlGQdspH88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOakX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklEq tY6cCtSRymIoL7u/fW3Q7lr2MUKeZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUvgNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpPSODgqqQ76LGV7nUxIz4ZVUeZm+DjiECjfdVBe mMwpCV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc0XTsr0 1WOkvvzCDBvuaHTQnWYnp+XqjWoMCRTMm4GZgcDVwIO59Slq4Y25i8jVf5mGa+xy9HwRzf5x mnQqDBk3utDy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:uwxzfq0nPVxyfly5OkMGaQqjBVVyeYIsimQD101hICG9Lfbzqy n+pp8mPEHP4Ar5AEtQ/+xpOMG7IU80hqQFmLX5XI3SKjUO3VHEEGgM1/qH/9SNIUPDH41mpO 5dmspFebrN5DFB5KqU3ODSKadC/DDzytHMuQ6o9QYOcegFUcBdxjY8LjzePlx9RQFAC5Z8Po Gb/NB7qz2pfmlSRtinB1EeNtKz7OHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoiy2 7YiAb0j5/T+c1TiyWsmlM73a4m1+cJ+eEzSvBkv/JlZgkExDzYJbiJEIfyxAzd6Nvfk2rC1u O86yvIdv4Dlk84cgyO0GHQ8hil3zA053D4z1iExXPlvMziXTo/T9FMnIRDb3Limj8dVfxHod F2NliixuhqJAKFmD6468nDVhlsmEbxqX0+kfQLh3gaVYcFcrdeoYEW4UsQSf47bVXHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQ2TlLm3JyyVce2aUk7wM93YN4T4MB6/ XPM6xumr0LRsgKbbhlDONEWsezAnyle2O9DItTGyWXKEgqAQOyl3es2sRI2AiDQu128KcP X-Talos-CUID: 9a23:VsdqsmEMq9yPyaORqmJtq2Q2Qtt6W0TW6yuIHgi0ADZuFry8HAo= X-Talos-MUID: 9a23:JFrFywo9gKBXD2e0KzsezyhAH+Rn47iMMllXk5sbnc6aZANUZTjI2Q== X-IronPort-AV: E=Sophos;i="5.99,197,1677560400"; d="scan'208";a="105450429" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iSaa6kniLshVYGTCxCioV6nXhUPqC/RglUMZ8UFbbYAqx7gE+t/NfQhVb2iPPmZo/j/3wXRh/bwn1YFYm65zGGp5peMSTVT0p9pSWyqxp28s1ogrxaSVEjwGFjE/ZKgy52qwQTlki29c5Q2sLIzD+UxrrYP2/Z/d8L0OiyXYfiUtd5nsxNKnZesa25WvKeT0KPtRofW89g7P4Ya2ryEmlJ+YA55/DsQv0sxsdmuI2fr8wfvBoMGvlTL/j5ziCT/hJzIAfe9PzkqScyo8BTRkuxZmQggTVnRJVsphezyfM72YwozaggRDGzpPMvm5+/Gr18xlgouSGQ+a8nCCrt9gpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L2cWvCC3TMiknbAQJ70yQk3bXAIp5XaHNtdnUXOvN9U=; b=hc2x5vLF0vH83rcA9kpQcULumJuhq5dzBTKITvkMsd5Y8u6ZEbj7joFo+ofm67rkaHfjr7c9sQjR+odhmdQe73/JSfHte2UrrdeH8vXKgfFJGpKPn34YKrIBFZX0ASH7JIT1PZYKbtERrqFWj7rrWNGg0IbKOlVHexGMhyFcI7sLUYFpo2/AzjEFEs374Gc2R7fS3EsPTjBiLeTOJeU2bA609EQWrGJaPUuukRfMMIEWvwuy/46XdG2n/8uZdnw7JywHYCYqQVEEbj7wl/t1omqHLme+ign7X1u+xH74G8ZUY+e9LOH14wYNBmLLXh2bm19MDs4xx2g/gpgiW+AxkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2cWvCC3TMiknbAQJ70yQk3bXAIp5XaHNtdnUXOvN9U=; b=qIKEZniPG5KTLUN2Lfswd7j4WM6hl3yZJHfh72PIsy+35IaGVA3OZmmPkPFY6oTuPpPbeeEcMtrKC/w6QCbjUE8XrbBhA6N6N3B3HqV4YRvcs7XHISz3+cQ8NLOktLAni7TfBQvW44k+XZdITP/0EvBiFdiR/ZTL4/MB4qJTAsY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1377fcd2-672a-687d-468d-ddc6d5b4be70@citrix.com> Date: Fri, 14 Apr 2023 17:17:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] create-diff-object: handle missing padding at end of special section Content-Language: en-GB To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Josh Poimboeuf , Konrad Rzeszutek Wilk , Ross Lagerwall References: <20230414151933.53851-1-roger.pau@citrix.com> From: Andrew Cooper In-Reply-To: <20230414151933.53851-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0272.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO6PR03MB6226:EE_ X-MS-Office365-Filtering-Correlation-Id: fffa0f9d-4941-413e-eea9-08db3d03c9e4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7q/+OKijDl13wzd91MpbgUwycnvO7fCwGW6bnaOsWs7AwTB18BV0Dk+boi7sJPK6UPgxzfgvxJ9KlIZJhT9fHnxQitpOTqE7fhgpyDUCsUhCBVQ1JTMkvzaMebftOkD8uPmdl8ofjnrym1wILIq5172C9iv84EDNdPNMgyezANeY8G2OVwh0cILyELgZZHjpfaypKPghCIh5y2NPe5liCMjax3xEYu129sh+sfwlqN3VNrOZUwKlYmKZ/mPBTdhTld8JU8HzAxcZSLXdyk6Zvx21EQSDYHe4y6Kn8h+KBWZylxZ6vQZhu8IRJCgG87iGFnGOtQv71En+qw3tm9zEl+eIgoR4giqlzRCvU1VfLpFJTbLyIH6osqttZUBae9CaJ8gulDXmQnVIbT9ftFZJqnfMY3n2v79brws27jikoqv46Oxj5fc2fNEGHsLfvgdq+7jYiK2T6bNS9HcmT2FRezjdwkiToRELSAsfWsy9gkfi3D1OBqJ2DWoXQ3YNepkFGQSm7BV/TIw8w1xKg8yDrs081+cQTw1VnAiUOaS5jLDC7D7II/7y9ROKdR7xvFZCnHj9zYpCQgvH4P2Uu/XvpEvibH5F5Io/DJj4qQE6Fmyxd84KrIC3HgpmHvGPmtFKeXLNGQ/Q2a5Ubg/Rx4VMqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199021)(66946007)(31686004)(53546011)(4326008)(66556008)(66476007)(6506007)(26005)(6512007)(36756003)(31696002)(107886003)(2906002)(6666004)(6486002)(2616005)(186003)(86362001)(54906003)(5660300002)(8936002)(38100700002)(8676002)(478600001)(41300700001)(316002)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVBTVzZJM2pLbVMzV3gvYW5uN3J3WE9kNDRZcWpFY2IwZ0tpQXNpYU16WDZz?= =?utf-8?B?NkMvVy9rdE8yNXFXRzhzMmsrbDZJaURKTUVhUVpSWXpidFYvMkJPQXROQTJy?= =?utf-8?B?RXBnby80K1ZVRFNUbW04U3k3bndZSHRCS3dQOTRCNXFZTEdDNzVaQkF3TEVa?= =?utf-8?B?SCtML25QK2JjQ3JXb0ZvMm5yNHBzdzdXeXFpcVdsS3FRdy9NN09pRlJueC92?= =?utf-8?B?WVRGTGpqQ0QwMDkwZnlWLzh5ZjlHdkdCVDMwZXlxbURza1FoYVRJYU1mV21Y?= =?utf-8?B?b1JMYVNXYWV0Vy9RTVJuQitXaTRwN3JqekJCa2xkajl5N2QvWVNCYlN2bUQw?= =?utf-8?B?TVBPa3A2WDNhSERNRTlwckU5SzFpSzZJRWFFRE5KdFBleFpXYWVTMzJLMVRq?= =?utf-8?B?TDlWMFI0eWIyNXNCSUpNSXMyalVQbkl2a3J6dU9HanNrWk8yallrL1NMeFFk?= =?utf-8?B?eHg1ajZUTDJjYUdFZG9GRVpvcjB1aWhnUVRRRjZtNU5yR3RRL3l5amhSZm5L?= =?utf-8?B?Z3A1YnVFcmdtT0pFS3M4UlZnOEJvL1JXV3QvWk1IZnJMZDFFSm92Q1d6Mm9h?= =?utf-8?B?M1pxZVRVZzl5Z09VOEd0alVzUEZCYTNnTXhmQWhLRHZlMDN3cGdoQkxSYkk0?= =?utf-8?B?ZWYrZDFhSjN4bnNHL3ZvSTMrSHhuZ0RZMEVYZytmQmJkM3h2YlprajBSRENC?= =?utf-8?B?S0ZhYmxyWm1ycjYzV2pyVk12ekRrV3NBbkRCTk1ONGFzZmR6aG9pTldsRTlU?= =?utf-8?B?dUlpRzlwWjkxYmJpenJlYXladXBSVmFrbzRxK2wrMHMyUkRia2o0MmxsZjRW?= =?utf-8?B?TFNkcENJZ0RubEhiNEdtd3BULzdnRDVJTlFqRWVFTjRzMFJVVGp4a2dhaGdu?= =?utf-8?B?SkVkYzl0aW83NktjMFJhNWJxOVc5VjVORm9EUUdMM1VSd3crbkdCdVNtQXpL?= =?utf-8?B?R3ptZy90ckRpcG16cVcxK3VKM0RTSXpkSkVFU21lekpuWEpoT2hDdzRFc0dy?= =?utf-8?B?VzdpdmZUbnBkMHppN0M0cDR1QUhLaGhxVWc3NmZUN1I0SDVlZjByWVpaaGNS?= =?utf-8?B?UWNBUjFiVmZrZUNlNFpaZDRDcGlGd0hZd2N6UW43RE54VWxJTmhWc01sSFlU?= =?utf-8?B?Ym1ZY0pIaGtZVWJITlNmMmJBYkxRVjZpaUFvL0dFMHhUaHMvOXAxcjUyYnNC?= =?utf-8?B?Z0ZIOEtnMngzV3F4d1h5S1lJOVc2dUZDdWUzeCt3MkZPSGp1QlFaQmcwbUpF?= =?utf-8?B?elZVSm1RSlQwVWVoTFp3bUh6Q2JIRmFHa0N6SG5EZ0hVZXFPaWZnbjJQR0Vv?= =?utf-8?B?dHNScXJMZDU1aFN1V0lTLzJ4SklUL0J1V05IK01ma05iQ2lzcm4rYVdOYUdC?= =?utf-8?B?dlJlOG9meEhkRXF6NU15WFl1anpOS21qd2ZPQ2Y5L0JCNTdpa1BHaEFIWFJZ?= =?utf-8?B?N0FvMWc1MWRUM0VGMVZocElZU3NWenhoQ1FjV2txbTgrNC9xdFNKd05OejAv?= =?utf-8?B?MVVoVUM0WHN6SGlPQ212Vi9EZ2s0U3l4S3d2alhBTytUM0lQU3NHMlYvVWlZ?= =?utf-8?B?cHRZU200cUpxNjYwWnhLOWs3VFpEUTE0WE1KN1pNNFRuMWRZcGpCQzg0ekNn?= =?utf-8?B?bkcyNmRuZFpjZmEyT0hWR09pNmNHWXBqWFQyWG1XRzZyelNmOVlFc3MrK1hy?= =?utf-8?B?R1RwRk9XSWx3Uy9yM2p6LzVkUWtqRFI5a2c1Ujg4Y1VKeExoTGJvV1ROVFk4?= =?utf-8?B?Zzd2K1JJdWxUUnZrUkNra2NwTjZJVFVrM1VMRVQ3b1ZtSi91NnRTc282RGZT?= =?utf-8?B?RGUzbk1iL0h4MnVBUHZheEVqcmU4UGUzcU5hS0tjaVdTUHFYaFJaRXV1TkV2?= =?utf-8?B?Vk9ScUlmZHJ3cS9raUN4STMrWTVxVk5KdVNBL0dtemw0SSsyMm1IMzh2emYz?= =?utf-8?B?MmhzOGd3cWFnbWlwdGp4dTBsN3duamFsMjVVOHQ3K0VuUVkzYnc2R0wrcDNp?= =?utf-8?B?UjhoK2RCR1JGV055VTNzSTNNRm95RUlUUU1kT2lrUkp5bndrODlZMHRMcjRR?= =?utf-8?B?d0dPeEZnYnc1OTV4TklEOWE2cGVkL3RtRWUvVFREQ1d1eU9nOHRsZks0WTFo?= =?utf-8?B?RWoyeDlkekFVTitQZDFoRS9HcjJCbWFpSmcwL2NrVTc2OUU1QkxYOTRzV2pj?= =?utf-8?B?NkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XVEpAStNAWZFH8PfQ0r+GfgTDok5ilZrY+zeyV+V+GGUm3VnrhRmOgAyHXpY49qX/jzuW3nV9e21YMQHKyMcC6RdWKV7K9/xbp9ODSc7wLw5iZAqW64wR9+Db4i8gUcOPeUL1Phd2b9b5V4cxavOGWzuigVo5jmS4L2mqdFrQEjdKbG+/f8fY6YCcOd/a89U6pqq2gAuD4BjiSKctvgRBMxPxPcebfYOX/f+YMUZZhbCtJPy2yt6LoD1YjXB50e1NH1cBiMFT2zSYeXEWj3TNpZVGCcMRQDFlMxj4LuL2MQwLdxiKdBHAJ3PoAtFc7ps2lY6ifp+JXVkqzMZCWmMJ0GZOv4WNn19Bj/BYANpmDDMUOaBKOguZvhM5ZearwCSa41zPECTEaiwOeRUlBpK0YgLTRwBZVyYVXgS8TSgVBKxW+roUIa26ApxNfIdzwjs8Km+9YQ028h6lRalmsext2ClPey27E+MwnzG+vIBhqSdjGbsNtYgaVSty/8Aq6DGumH3rjiOHVjgmU/zLY+rhq9IXCSn5y5kGNa18fi1PckdM1ceFEDKY6HkQmcHGs/FsyXseNOr7xFgkD41RJSRG5oO2NFZ2fJWAApv877SCgMQi7C3cYAmymjsOl+BwGv5/ttmPKi2qs7NPN3zXImkS1casZQBkIWh9ZA1O+eGTaOA67uEPGj2Ngtr7+CvQN9B4n2d7UKVPY4PWr79H0aJytGfQXfSwcKvufJ5Osyyn7h7s5BUvPZk7sJMG1dtb1V3sM2FqKTsHp4vP0GB1BIbnzOk/qfODTcSuerLIajCUoUe49jlXSVd4qevPXLLe8s8B5RanwXmJrdS/tImjSkIow== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fffa0f9d-4941-413e-eea9-08db3d03c9e4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 16:17:48.8976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aOrRAlw+nO46+k16VnZ2Eh3LJNnRry5zeIbi/dyETE5fH7fCpllYvGMnFMAa2YA9T/P3dwoTZNCvSD18xqEMqal4+abrhYgwcRVdxOzFq10= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6226 On 14/04/2023 4:19 pm, Roger Pau Monne wrote: > From: Josh Poimboeuf > > The paravirt_patch_site struct has 12 bytes of data and 4 bytes of > padding, for a total of 16 bytes. However, when laying out the structs > in the .parainstructions section, the vmlinux script only aligns before > each struct's data, not after. So the last entry doesn't have the > 4-byte padding, which breaks kpatch_regenerate_special_section()'s > assumption of a 16-byte struct, resulting in a memcpy past the end of > the section. > > Fixes #747. > > Signed-off-by: Josh Poimboeuf > > This is commit: > > c2dc3836e862 create-diff-object: handle missing padding at end of special section > > In kpatch repository. > > I've seen the .fixup section get an alignment of 16 but a size of 81, > which makes the error removed in this patch trigger. Overall I'm not > sure why the original alignment check was done against the size of the > section, the alignment applies to the address of the section, not its > size. > > Signed-off-by: Roger Pau Monné Seems like a clean backport, so FWIW Acked-by: Andrew Cooper However, surely we want a correction to Xen's linker file too, to stop putting out a badly aligned section? ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Apr 14 16:18:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 16:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521162.809522 (Exim 4.92) (envelope-from ) id 1pnM8I-0005B1-8f; Fri, 14 Apr 2023 16:18:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521162.809522; Fri, 14 Apr 2023 16:18:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnM8I-0005Au-4F; Fri, 14 Apr 2023 16:18:42 +0000 Received: by outflank-mailman (input) for mailman id 521162; Fri, 14 Apr 2023 16:18:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnM8H-0005Ai-Bd; Fri, 14 Apr 2023 16:18:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnM8H-0007jR-97; Fri, 14 Apr 2023 16:18:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnM8G-0007Sk-TG; Fri, 14 Apr 2023 16:18:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnM8G-0003Rx-Sm; Fri, 14 Apr 2023 16:18:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lruf1+ZxQNmgEaak6z8+Vwj5o8cFdVs+XytGtA0+cHU=; b=VIPSR5y4B6Gj52goeTFtjdiS5q k6DmVl7EZrR+qwrCk3t0yhmzosWStSJdjM2LAvbAbg/kihqHQl44fohGQn5TPHigmT5+H3scOfD1m imde/LhR1A7DHPLkbH69s9Nxd8L7A1+hHJh5lpF2tFOTrNIom0U2PGkUeNaOmJvhvTKw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180255: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 X-Osstest-Versions-That: libvirt=152770333449cd3b78b4f5a9f1148fc1f482d842 From: osstest service owner Date: Fri, 14 Apr 2023 16:18:40 +0000 flight 180255 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180255/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 baseline version: libvirt 152770333449cd3b78b4f5a9f1148fc1f482d842 Last test of basis 180227 2023-04-13 04:20:20 Z 1 days Testing same since 180255 2023-04-14 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Eric Farman Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 1527703334..ebd004a03d ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 14 17:17:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 17:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521168.809531 (Exim 4.92) (envelope-from ) id 1pnN2d-00030T-9o; Fri, 14 Apr 2023 17:16:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521168.809531; Fri, 14 Apr 2023 17:16:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnN2d-00030M-73; Fri, 14 Apr 2023 17:16:55 +0000 Received: by outflank-mailman (input) for mailman id 521168; Fri, 14 Apr 2023 17:16:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnN2b-00030G-AK for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 17:16:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnN2a-0000a7-Ph; Fri, 14 Apr 2023 17:16:52 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.152.63]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pnN2a-00020B-Fx; Fri, 14 Apr 2023 17:16:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=soYcFvgEQFsjuqxT9VN1Dq0AYPOfz8uaTI8vt+176Ng=; b=Lr2eBqd0ktz1F/4eWxShbwRZbD ukHm3UogSPwyXfSpxWm78vTkpP9+81elqf//qzhkCPMK+BbO/WkTUJTL8bLzFW3sDRlcmvWxn6Ttm QbKYz2h1U5HYNkBE4i05z4ff7BtLw5B7BRgiOvxFmm72YwPpeWErvHQ6WuOtcIw7BPvM=; Message-ID: <7fba60ed-d159-f1bd-7edd-6e5a0c60340f@xen.org> Date: Fri, 14 Apr 2023 18:16:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230412094938.2693890-1-luca.fancellu@arm.com> <20230412094938.2693890-3-luca.fancellu@arm.com> <72f38b2b-a391-fb7c-f8c0-cf3561470875@xen.org> <4F5DC5EC-F538-42CE-A93F-2B5E3FAC13BB@arm.com> <03cc0c98-c5ef-16f1-ed24-6a39320b08e5@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 14/04/2023 12:07, Luca Fancellu wrote: > > >> On 13 Apr 2023, at 20:52, Julien Grall wrote: >> >> Hi Luca, >> >> On 13/04/2023 15:05, Luca Fancellu wrote: >>>> On 13 Apr 2023, at 14:30, Julien Grall wrote: >>>> >>>> >>>> >>>> On 13/04/2023 14:24, Luca Fancellu wrote: >>>>> Hi Julien, >>>> >>>> Hi Luca, >>>> >>>>>>> @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>>>>>> unsigned int max_vcpus; >>>>>>> unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); >>>>>>> unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); >>>>>>> + unsigned int sve_vl_bits = sve_decode_vl(config->arch.sve_vl); >>>>>>> if ( (config->flags & ~flags_optional) != flags_required ) >>>>>>> { >>>>>>> @@ -602,6 +606,26 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>>>>>> return -EINVAL; >>>>>>> } >>>>>>> + /* Check feature flags */ >>>>>>> + if ( sve_vl_bits > 0 ) >>>>>>> + { >>>>>>> + unsigned int zcr_max_bits = get_sys_vl_len(); >>>>>>> + >>>>>>> + if ( !zcr_max_bits ) >>>>>>> + { >>>>>>> + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); >>>>>>> + return -EINVAL; >>>>>>> + } >>>>>>> + >>>>>>> + if ( sve_vl_bits > zcr_max_bits ) >>>>>>> + { >>>>>>> + dprintk(XENLOG_INFO, >>>>>>> + "Requested SVE vector length (%u) > supported length (%u)\n", >>>>>>> + sve_vl_bits, zcr_max_bits); >>>>>>> + return -EINVAL; >>>>>>> + } >>>>>> >>>>>> Is SVE supported for 32-bit guest? If not, then you should had a check here to prevent the creation of the domain if sve_vl_bits is set. >>>>> No SVE is not supported for 32 bit guests, here I think we will get “SVE is unsupported on this machine” because get_sys_vl_len() will return 0. >>>> >>>> From my understanding, get_sys_vl_len() will return the len supported by the hosts. So if you run a 32-bit guest on top of a 64-bit hosts, then I believe get_sys_vl_len() will be non-zero. >>> Yes you are right, I realise that I need the domain type information and I can’t have it in arch_sanitise_domain_config, however they might have sense there, and I can do a check >>> like this afterwards: >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index c1f0d1d78431..ce1235c25769 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -3694,6 +3694,12 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) >>> return -EINVAL; >>> } >>> + if ( d->arch.sve_vl && (kinfo->type == DOMAIN_32BIT) ) >>> + { >>> + printk("SVE is not available for 32-bit domain\n"); >>> + return -EINVAL; >>> + } >>> + >>> if ( is_64bit_domain(d) ) >>> vcpu_switch_to_aarch64_mode(v); >>> Would it be ok for you? >> >> construct_domain() is only going to be used for domains created by Xen. You would need the same check for the ones created by the toolstack. >> >> Do you need to know the SVE length when the domain is created? If not, then I would suggest to create a new domctl that would be called after we switch the domain to 32-bit. > > Hi Julien, > > Yes that’s true, we would like to prevent who is using hyper calls to have guests with SVE but 32 bits, I think that with this check it’s possible to avoid them: > > diff --git a/xen/arch/arm/arm64/domctl.c b/xen/arch/arm/arm64/domctl.c > index 0de89b42c448..b7189e8dbbb5 100644 > --- a/xen/arch/arm/arm64/domctl.c > +++ b/xen/arch/arm/arm64/domctl.c > @@ -43,6 +43,9 @@ long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d, > case 32: > if ( !cpu_has_el1_32 ) > return -EINVAL; > + /* SVE is not supported for 32 bit domain */ > + if ( is_sve_domain(d) ) > + return -EOPNOTSUPP; > return switch_mode(d, DOMAIN_32BIT); > case 64: > return switch_mode(d, DOMAIN_64BIT); > > It’s a bit late in the guest creation, but we don’t have the domain type information before, this check together with the check above in construct_domain would > be enough. > > What do you think? I would be OK with this approach for now. In the longer term, we probably want to consider to set the mode when the domain is created because this can't change at runtime. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Apr 14 17:23:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 17:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521173.809541 (Exim 4.92) (envelope-from ) id 1pnN93-0004Ux-4e; Fri, 14 Apr 2023 17:23:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521173.809541; Fri, 14 Apr 2023 17:23:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnN93-0004Uq-1p; Fri, 14 Apr 2023 17:23:33 +0000 Received: by outflank-mailman (input) for mailman id 521173; Fri, 14 Apr 2023 17:23:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnN91-0004Uk-G5 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 17:23:31 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11d5e261-dae9-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 19:23:28 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by CO6PR12MB5442.namprd12.prod.outlook.com (2603:10b6:5:35b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 17:23:25 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 17:23:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11d5e261-dae9-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OobbYPp7E/tUwaL0H/DvMcsv2VP9RYcUJvVDsFl1lY5ehOXPjgTeGQ82zjy2Gr6qO34FcDutP+P0hfC/FIghfAXkUKUAelh8oK42SRMUKA8n7xxk8SGR+OlbelUlHa92B5psxhcgzl+k4cS3bODVnrRwMoEt21qvwZzsXZdZnD4vS1+7VsiSL00FSdfy1SAL3UFf3qeLPgehG4eiJv//eaMOQfC2E4f/1IKTANXsNkp3cnskgDbLSEfoK1QgOVTJK9rDIAEpbY8Khm3B+UzDcF+i0mZfzIHEt13dzv/vaoHP5MTL75+CVtE0YHuYiCTPMgrKZCh+zgFQmJbQx1nn5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ej5SWGuUgb6hps2pgI4GwpP608Nluv+8+jfvaBUuYXI=; b=Veyc6rjldKlPLkv2VXtAIN9+eJQHiE6BehYFTAXgBLiAaF0S6oOcC0XmviiQ/1NsvgpAyhcQw4Pu5+icodoviiX0dph4l1VIuJopfZfdvm5d80KUEKtRV0ox5xj47MVPxPeMvYheg/+Sxc/cDP0BlaGL5mp5LQFntJozgBSoSzgjvMc3ZV5hcd0HqwpgGO6brzq33eLend/aM6L0gLFuGrWT1OzERxWntvhvNt9RCrVhq9mNbjSTkdqWByAStMu3n8L3nMuD2PL9/f31E1MPRgF6vf1QATVRed3bqgiFdr3K02plwyHOJQ6FqD+SBMdTA45ie0mi3t/vIVZ78we6Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ej5SWGuUgb6hps2pgI4GwpP608Nluv+8+jfvaBUuYXI=; b=5ILnij7Kx8AxWQsD7JT8qGoQ6eRtqCKrJ211NNAaAciWScaFtksRYEh3c3/j+Z+Z7ajqbuTVz8EvCiRFF89pRTEWoWa8jj2Rrmo9Sh46ddcU8SOVsIoIhTUp2P9dSbVwDjRDf2qGDtTxTkdHWGqiRFULK6mULgFvRK8fsvpdVQ8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Fri, 14 Apr 2023 10:23:22 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: "sstabellini@kernel.org" , Julien Grall References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-13-vikram.garhwal@amd.com> From: Vikram Garhwal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR05CA0201.namprd05.prod.outlook.com (2603:10b6:a03:330::26) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|CO6PR12MB5442:EE_ X-MS-Office365-Filtering-Correlation-Id: 630d318b-25ee-4ed6-13d9-08db3d0cf448 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /rdxoWmQGvXsw1gtkowbXup1MuKId+vzOySCZAA1G7OoRAV3C9l00bgPy/We/nqoK7GPL/z4WriHZUjBtBGw24P/JyLnRQOv+Dm03iTVTxbj3xhQ5ZKcAo0sLgF5Yenm5wRSX2iR1YnHMBFSWAFYpbCgkubchZ4sbPxdemdmr+mhjJ9PsjKnciHtMeq6wdsQKGWbPuSfYQlk67Vu1h/QfLd2LJegA03Qf4GSS9oEnaLdZq9/SFs8s1WGaYn3M+0SOySynGk+BaXD8nyNzfjjDr4j3es3yQJjTDPHzKfM0p62OaQb+RoxkBZod3y0rVKxsRfHk9cBY/w/MAoehNA/QAgpbjSu6C6JDtecByHkXB1HpcrQzRMGPWnuhlD0HtUSXTKBA84hxMc0JfA3Bg0b0c8heIfHroTWBUpDqdwV9g3IMovp+I+dtrMlTiziUjwhxDk30iO70XydMZuRey3DIHLe79BV7xYt7cwd6IrCOWg3qyRRYme5/WWmJW1kd2qIn3EPoCf2i5BUfQS3gicvHhQpnbHkjXcFMalpuG39q+WXGqUQ5h518RtHkz0I/R6bDmpRy50RuM/1qYk1Uz2c/tpNqQFvwdfnNc3/GuHyN5B+kXrOZMy9+Fm3PQwbPuuNLVp1+Pc6nsH/9POwjkrU/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199021)(316002)(41300700001)(53546011)(6512007)(26005)(6506007)(6486002)(6666004)(38100700002)(186003)(86362001)(31696002)(2616005)(36756003)(83380400001)(66476007)(66556008)(66946007)(110136005)(4326008)(54906003)(478600001)(8676002)(8936002)(5660300002)(2906002)(31686004)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3BhQWQwWHhZQW9sUlF2NFF5Z1JGc3Q4cmh0bmd2QTNjY0o0bFRLSUVYRFdn?= =?utf-8?B?dUdQZUVqSnZLa0ZDdUkxdmpWUDd1cU9sVG1wblpNdzNHTExuNm14VlVyNHk0?= =?utf-8?B?OG5NMXhNbUljTDhsZjgvSVd0TXdkYTFYQlM4aGpVVnlNV0RDWHdpbXVZWnRN?= =?utf-8?B?aXZwb2JPVEk1NzczV0pZYmNUYUw4bC9INHhZaTJaV2lnaWVRSXlDM2p4RWVP?= =?utf-8?B?L3RkVUtmRDRnV1VlUSs0S1ZLa01ORWk4cHVUNS9iM3VMZ0xCSVFCMmhHOGxZ?= =?utf-8?B?VWdSOGN6cWhlZ1ovSzA1WXV6UFNJSGZNS0w4UVA5eVhMQWJ6NlQvaDdTeUR5?= =?utf-8?B?OFJjbnFlVk1tRWtkRnc0eFhDdGcwanJtT3BLYzIxVmxhcWg1LzM4OTZqSUlz?= =?utf-8?B?QmtTUG5UVjZyOFRPOVZQZ3N2NWw1NGh1MGkxU3gzT0dQckkvaWpYUS9zb05n?= =?utf-8?B?TzVrbHR3eWZiWUNJU3E2WXFOUmJEWU0vQnVXZSs5a3QzK0lMR2tnVzdRMFJp?= =?utf-8?B?cVRzYWVabnpkdHljMHBjQldoZWxmcFo2eGNMeS9PdmVCelBHd21wRm5lYng2?= =?utf-8?B?ei84QnF3RitRZjRBSjJZd0IrMWdjR3NGVG9VLzZSbGk3eThRM2VTZG9aRjlt?= =?utf-8?B?dDdOZTFOajUyMldxbGhFRVlLTkVMTmxhajFHUTdEejVsazJpQ3R5ZXk2cFFT?= =?utf-8?B?SkxXbFVCSG5uQ29uY0FUN2k3VXJCcHlrNkZ6S2lpcmR2dHpiUWtsdk9rdDZF?= =?utf-8?B?dWRpTkE0VGNES29QcnFCdWFTRjFhaHd5UUUremRtaFNNU2xmUzJTRlk2ZmpY?= =?utf-8?B?VkFKdVZhZmkrUFpOcWwyV1VQQUZBNThsRmhOUjE5VVlqQVN2TUkvN1ZkempD?= =?utf-8?B?Q285UW1sZHV5d3hiZ1pmU0E1QmhvaVBnNjdXeloxU3IrY1VaZFVrVC82eW9P?= =?utf-8?B?Skk2MFRSdFpNT3RKbDBPUDRrb2hiVVlIRXJFSFpKSWVFa01SWDBWTEdYMW02?= =?utf-8?B?N2JPUVdPYmxOM1Z0ZjRITDM0VkQ2MTFqT3dNS0FVUUhrMmtoVE9ucXZWR2Jw?= =?utf-8?B?TW44QXBubjc3SitsaXJoeTBjQTFlWTZScmpYdkdJdzljbmxzVis0SUVReG90?= =?utf-8?B?TTRJUS9yeXMwTFZTdWozNStzNDlpUXJRV0RZZU5jZ1ZhOERtUWg3UFdsVlV1?= =?utf-8?B?Qk9TT0J2dzBKdmhDcFprdHJnM3J6NE95ZzVuVVhMQzNWaHB1aUs4QzAzOC9F?= =?utf-8?B?c1ZYa3lheDQ2MThYdTZ3amxVUWZoOWg0VGJ4Q05SaDFTSFVOWGI1cUV4OVpK?= =?utf-8?B?dGhxWFkzTUdiV1ByNDNTYU1uZUZhby9YOXhMTU1ESlRNa0hKSklRRlFlM2Zz?= =?utf-8?B?TzRrdHJub3R3dzBTTlJGWVNUMWtJd3l0YlUydVNnV01VME1sRkJaVUdqQ3E5?= =?utf-8?B?UmwyTVovUEtTZWtPNlZ3Ylg0dmlnWHJPbEx3aGFhMnNmdVZXSng5T0dGeHd5?= =?utf-8?B?WjRwa1FDeUFiY2NNeThmWU45emwxQWNWaHFwNVNDdnFMYzNRZktteXV1cS9N?= =?utf-8?B?RDBzd2RudGJXdzRCdGl5T2xrR2hibFBEaW5KU0JXSVRraFk5R1Y5VkovSmsr?= =?utf-8?B?QlVWQWE3VlRWQkI1SDlCVFA4S29uOGJldmJHdkhGcjBmU3BXMGRENytYZG0x?= =?utf-8?B?em9RNFZxYjBOQTR3RmxTa2UyNWVPT050SUQvczJiRUxVQTJmVW9pU1JPcU9S?= =?utf-8?B?c05PZjZDeVlVUHdZdVFEU0RSSG1tRm9YRTJSbURINjB0VDIvajQvRjVYTUhh?= =?utf-8?B?ZzBMZW00UlRHOU1Ud1BzdzFFTndadS9PYUh5ZnJGbGhGV0RlUHYvelRTdlZ5?= =?utf-8?B?aVBYZS9YY2tJQndqdVJIbDQvcU84UkxxT0thdGoxOW5mSmFBWXdnT3NvK1ZK?= =?utf-8?B?MEhLMnFzbmpNYTY5OHN5QVFUa1lLNEY2LzZKSUJQWUpPZHFpVUtXeUNYbEpq?= =?utf-8?B?dzVkK1NzVWdiRlhyTVJ1VmpQQWw4V0cwVGgrMUJoZG80VFQxTjdIaEVsK0cz?= =?utf-8?B?UVVUc2plcDh1RmVYRmViK3lZcVVHWloreXU2UHFyaXg5LzEwWjEzQmFlVUJM?= =?utf-8?Q?RkNphRRsUeQ46YAxHqCEgMPre?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 630d318b-25ee-4ed6-13d9-08db3d0cf448 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 17:23:25.2225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kAArDci8ntS20m5aQNh+rArKUdN3/I2MPysXEX76yzbpILQ6jXPIHTvTcokDwy1t7YQ8w2OV/0V5xoQv7mlwRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5442 Hi Henry, On 4/13/23 7:09 PM, Henry Wang wrote: > Hi Vikram, > >> -----Original Message----- >> Subject: [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host >> >> Dynamic programming ops will modify the dt_host and there might be other >> function which are browsing the dt_host at the same time. To avoid the race >> conditions, adding rwlock for browsing the dt_host during runtime. > For clarity, could you please add a little bit more details to explain why you chose > rwlock instead of normal spinlock? rwlock is just to protect someone reading the dt_host while dynamic programming is modifying the dt_host. Initial suggestion was from Julien about adding rwlock here. For now, dynamic programming is the dt_host writer in Xen during run time. All other iommu passthrough function was just readers during run-time. So, it was better to go for r/w locks here as spinlock won't be able to difference between read and r/w access. For next version, I will add a comment in commit message. >> Signed-off-by: Vikram Garhwal >> --- >> xen/common/device_tree.c | 3 +++ >> xen/drivers/passthrough/device_tree.c | 39 +++++++++++++++++++++++++++ >> xen/include/xen/device_tree.h | 6 +++++ >> 3 files changed, 48 insertions(+) >> >> if ( ret ) >> + { >> printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign >> \"%s\"" >> " to dom%u failed (%d)\n", >> dt_node_full_name(dev), d->domain_id, ret); >> + } > I am not sure if it is necessary to add "{" and "}" here. You are right. Will remove it in next version. > >> + >> + read_unlock(&dt_host->lock); >> break; >> >> case XEN_DOMCTL_deassign_device: >> @@ -322,25 +345,41 @@ int iommu_do_dt_domctl(struct xen_domctl >> *domctl, struct domain *d, >> if ( domctl->u.assign_device.flags ) >> break; >> >> + read_lock(&dt_host->lock); >> + >> ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, >> domctl->u.assign_device.u.dt.size, >> &dev); >> if ( ret ) >> + { >> + read_unlock(&dt_host->lock); > I think instead of adding "read_unlock" in every break and return path, > you can... > >> break; >> + } >> >> ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); >> + >> if ( ret ) >> + { >> + read_unlock(&dt_host->lock); >> break; >> + } >> >> if ( d == dom_io ) >> + { >> + read_unlock(&dt_host->lock); >> return -EINVAL; > ...do something like: > > ret = -EINVAL; > break; > > here, and then add one single "read_unlock" before the "return ret;" > in the bottom of the function? Will do. > >> + } >> >> ret = iommu_deassign_dt_device(d, dev); >> >> if ( ret ) >> + { >> printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign >> \"%s\"" >> " to dom%u failed (%d)\n", >> dt_node_full_name(dev), d->domain_id, ret); >> + } > Same here. I am not sure if it is necessary to add "{" and "}". > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Fri Apr 14 17:28:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 17:28:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521177.809552 (Exim 4.92) (envelope-from ) id 1pnNDW-00056b-N2; Fri, 14 Apr 2023 17:28:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521177.809552; Fri, 14 Apr 2023 17:28:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNDW-00056U-KL; Fri, 14 Apr 2023 17:28:10 +0000 Received: by outflank-mailman (input) for mailman id 521177; Fri, 14 Apr 2023 17:28:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNDV-00056O-2w for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 17:28:09 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20619.outbound.protection.outlook.com [2a01:111:f400:fe5b::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7fba173-dae9-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 19:28:07 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by PH7PR12MB7428.namprd12.prod.outlook.com (2603:10b6:510:203::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.33; Fri, 14 Apr 2023 17:28:03 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 17:28:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7fba173-dae9-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vh+BYD92ONCseAd15jP65tOXddlfxL6EBES9X0czPozkCzcIlbm/BR6kIvZlnPtX90eLbRL8KEyl+3LKKJaAfWzH0BorPS4WPOXSu9Hp78k6izHsDvD7SKAB2jLVJXMi5ilHifiPmOOgrSLdsiDVHvIQBUVboWBabKHFeK+q72gjJ18DTMSuT6aq/xvlhbIt4yE+V9+uOBodvO3nM60RFCC16UstAY9gL9LktdZSqo79bwr4cm14/LlRybOp3JLhv0gRvU8pdjiUHqgWmhXG7Kqa2uBTZfhX1Yiq1/R/2vmZ5Vz2671d85ELyJbgBA9NttE3N/EG25S8yKhz2PXS9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+qGWBdzemzbWug6XwXX7zGjoSLRS1maroLJGXzCB7I=; b=RYjHC7wR7FtvlSgmJLENuIUBOLPYQWOJJrBqpFtFiqR+wPJuHEIruJgyABzmgvELnEQyR7J5kbU1aNkMEx5bT8Uws5I9CjpY/A4LU/ifAW/MKRaPghs5DFVCnKHgtrHFfbqu7/EEYV2axjKPC9g0x8BB3Jm82yVZSsb2iwB04/Guuo8Fu+UUZp/Y5Zv/ge26+VO38Hp5TrgaJNkfQoB+BUeNLbtNJNRId3itYveXrGL9IS+8Pq1qEu7LL8sV6s/VUv3SXML+c1WQCQ/NHAp5PIW9Pu9L0NVHAyBYOs0v6GD7mBOncs6xyXO66Lizc1F+3yOjXBcQSrwszRKDxXV+Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+qGWBdzemzbWug6XwXX7zGjoSLRS1maroLJGXzCB7I=; b=GyMroG+PWGqLtMIr5nQZstGlk0lm2WTO966wP7bV8jhMAFh5rk+1GTDe6aTgB2f3f0S1W/DQN1GYf2LRUds3liBrqRZzWJf96yapPw1FgarqN2GQ0EYWfrQzvKH2Fu31WVXEN/7JWXvpWxiLCRcyQmyBVHd7YlNsAkemnXIP1aU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <5871c848-5d44-1040-9679-7dff25161714@amd.com> Date: Fri, 14 Apr 2023 10:28:01 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 01/17] xen/arm/device: Remove __init from function type Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-2-vikram.garhwal@amd.com> <836d2629-b097-9a8e-7aea-3f83fd13228f@amd.com> From: Vikram Garhwal In-Reply-To: <836d2629-b097-9a8e-7aea-3f83fd13228f@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR17CA0067.namprd17.prod.outlook.com (2603:10b6:a03:167::44) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|PH7PR12MB7428:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b53a4c2-4231-41cc-31c7-08db3d0d9a30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8YN+Q9iv3xL1MStN8j3WUuFr8K0PoWhsPsuHzjeR0YcsyxE4/7p3tHCL4FSvDzcGOW7pdB+1ThyVdjq6P4XOhwt8AKbR/+2IMih4R8NQNZFTqXyM846IbEtyqT/CCq1hK4buV8Skbqnam0kO1CVjXnioCmdctVPSDCgMSF9JK5KTJunkUlKrgtcgMQyn1FqhlWVnHtojs3Z63oQ/vNA4vvGiYAV9zotUP3uM8QMF2Utzp3NpK6Yr5sMjHhxA+Cvd9Em7RT7kesZhfGjyUXAn6AjfNdw2I8sseyQJRz8Xwjn1Zx4btvZQjQ8LqMalaisq87vWW8kilfWKOIbJUJlSmE7OYIc8M1OwKWdvpvXJC5OfnixYtzCoLtNm1MNDboFIg7I3/I95NlpxN8EabZA/U94TH5Tius9Fwt7cBrPln5dDVXMAFsaXtJ9cT8D/h3wziRryuzKHAUQ4s8NEKwbEZWY5TPKlEXDQSKjxdkQBJ21lJJld0RBw8ytEkeDEfn9EhNLZz3KZDxNRnCq42pL5zCjG1Ri8R52dtGk0zQ7Be58FPyVNsw/80wYLqlxwMmabN6DZeeViBXudjcDC7qw+047FhYGoY8eOk3uomrqIUA5ZlIdwr/iaQf+5umpmtgY+rP4a/waITIe60uee1shTNg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(451199021)(2616005)(38100700002)(6506007)(83380400001)(316002)(478600001)(26005)(186003)(6486002)(54906003)(53546011)(6512007)(36756003)(5660300002)(66946007)(2906002)(41300700001)(31696002)(66476007)(4326008)(44832011)(8676002)(66556008)(86362001)(8936002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGg4TjIrRVFkcURnc1BMY0d5VTJ1MTNqZ2MwZ0N2UVJmNXByeXZ4VHVyajVJ?= =?utf-8?B?RGwyZ2orbnhLSWVyY01nK0owM0dtN0V3bFZGVzJ1RlJkRDcrRklNYzdVcXRQ?= =?utf-8?B?WG5CM3lkS0lLZmtRVUNTaVdhU3g2L0xjMTBRaUpPcVFjYnduTGpVRVpjNXQ4?= =?utf-8?B?Qy9ER2l6ZExTZkhtU0hQbmpDRFNhdU9GVzRJdTF2eVhGTlc1NTVkcXpjT04w?= =?utf-8?B?alA2eWw0MkU4VmtrS01iOHUyM1JGeXFVRkRGOUVhZjB4bDRyRFNPemM4dDJ5?= =?utf-8?B?Yk5adkpnTFJBeVRheW1PUkNYMGxFOW13ZXNEbU9YT201aVZuN2E5WEFLVDBN?= =?utf-8?B?TG5WRWtxcmFReDRHdnRVVXZrRDNQZCtuVll4bkozSHBsUWozbjJ2UjNVNTBT?= =?utf-8?B?VGRQcUVZaW1sUlYxakc4Z04zZlpiMVdWNWYzV3k4czVPKyswVklHdFJBczJp?= =?utf-8?B?NDRNdnVJUTNuMmp0MDd5OW9kSzd1aGM2dDVxSVV5MmRycHpkZG4yeU1zSTh6?= =?utf-8?B?bHlMQncvRXc3dDdWMnV2aWZUa3UxN0FvYzdSZVNvWHJ2S21BNjI0R1JUQ01X?= =?utf-8?B?cGdUVXBMQnpETXYza3d2N1N3NGlNV0UxQ2JTWGw4N3N1QmhWc01sU0FFTXB2?= =?utf-8?B?OUlrK0VFdldiR1dYeG1mUWxJNFhTbHF6MWhRbGxTbE5HcmZsa0J4dFRlT01F?= =?utf-8?B?WTgrWnR5VlJyb1dWRHFnV3Y5MGxNM1JpWUJuNmJteFBzU1psTkJHbE4vcmlQ?= =?utf-8?B?YUkzRFIxMmpZb1puUWJiZk5jSC9KSW1La1dPallRdGdmajcySXRDVkhpVGN0?= =?utf-8?B?d0FmTFFvZnJyTUsvQ2NDNVlyTDJoQ1ErSnZLYVhRUFRDKzU5Y0kwaHFQb0R4?= =?utf-8?B?cDMrMU1qbStsd2VidEhCUFNrTE5VYU42a3VhRXIzMkoyVTFXemFKcFpYcjA3?= =?utf-8?B?aUtvTmx2c3FHb1JnclB6ZWdnczRHS1FRNFJweW9ha2trZ2pnTDg0Z3JFSkVW?= =?utf-8?B?TjRSMmhDS3c3NGs0dUxqSWJobUZkSFV4Um1ydWZIdzRqWDF2T1lWbHZEZWZP?= =?utf-8?B?RlFJbzJEVU0vSS8zM2ZqMlBVd3ArMGU4YkdzT0l3TkJhQUl6ZE82TFl2TVQ1?= =?utf-8?B?Tms4OEkwdFFRL0lZZ0E3MnlWNmdwOG1Hc1Y1OW0xVmp5b2pPMUFyQU1LK0ps?= =?utf-8?B?d1RSK09Qd3k4ZTYybGtSNitTZmxnZXNld0FiVXhpOUh0SGkySUxVaGhpZzFT?= =?utf-8?B?aklMTGdIVW96TFZreDYrWXBXQkExZUdpYWprUXNIS3R6dk43QjIzbEN4dERy?= =?utf-8?B?bXA0REVVTU0wMElkaUlPV3dGNDduOE5aQ2hRVVdubTJCaHNUMi9XQXhMNEFR?= =?utf-8?B?MnNXTWZlYlB1S01aakNRSXdRd2YrRHVjVkRLbW1hT01TWTlWak5Gd1p4Mzdw?= =?utf-8?B?V2ZOTEYrMExtQWhsaHowUWJvTWc2aktNYnRPWHBoUlBhSUlKa0xjMVVLTFBy?= =?utf-8?B?ZEtteVFnZExsbGhBenF1VTBBQTNlNTVPUEhPb2psTkRXckI1RVdRSE1RNThS?= =?utf-8?B?dUNvdER5VHA1OERrOFVvYld5WXVZZWt4YzJFS0ZKN2lvdkJ3WHUzUVpjdFFu?= =?utf-8?B?cUNRSlB0Tm1maFhiaXk5RHpHSnRza3Z6YmhJSUk2enZSdTRieTd1UHdFb1lk?= =?utf-8?B?ZEZHZXJtUHh3NmFVV04zUGx0ZnRvN3ptSnhXWFJrNktvekVnN05xb2MzanRC?= =?utf-8?B?ZHoybDdMaVhFSldTUW5MamFNNkM4SFZ1dTllVFh2M2VhaU03clNCOERjTkxY?= =?utf-8?B?UW5qejJNOXoxWUhML0FGYk4zYnd2bFhuMnA5OFZPb2hlS1VPR1JEYTdoL1hZ?= =?utf-8?B?c09hWllkTVU2K2RPdXQwSU9nYkVkck1nenJ2S1VxYjl1cUl6RzBaU09vaUNU?= =?utf-8?B?ekY3aUNNZk9RdmJ5ZVVyWkpTMmttbEdDeDVGRVBodFVjV1hBNFZrdTlZSjNX?= =?utf-8?B?UnQ2cXFRWS9DRitucVpBalVTVE5udXdzZDJ0UWQ0Y3AzendLTndSUUl2VzMw?= =?utf-8?B?N0s4b1lyNU1DZk5Xbk9pWDVqTkR3NStlZExOVEZRbkcwWWF4M0JkYXlwVi9P?= =?utf-8?Q?m/IMQvzfg2ufiKcck8k9DnDjb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b53a4c2-4231-41cc-31c7-08db3d0d9a30 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 17:28:03.5230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hx/GCMooZyJKJTm17l0XjrZ85wnujiKalKqSkUap+ncOuEKU2c1VcIpyHOE4c985m/VzNbEe6TQUR5ZXoTLuOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7428 Hi Michal, On 4/13/23 2:19 AM, Michal Orzel wrote: > Hi Vikram, > > On 11/04/2023 21:16, Vikram Garhwal wrote: >> >> Remove __init from following function to access during runtime: >> 1. map_irq_to_domain() >> 2. handle_device_interrupt() > s/interrupt/interrupts/ since there is no handle_device_interrupt() function. > >> 3. map_range_to_domain() >> 4. unflatten_dt_node() >> 5. unflatten_device_tree() >> >> Move map_irq_to_domain() prototype from domain_build.h to setup.h. >> >> To avoid the breaking the build, following changes are also done: > 'avoid breaking' instead of 'avoid the breaking'. > >> 1. Move map_irq_to_domain(), handle_device_interrupt() and map_range_to_domain() to > s/interrupt/interrupts/ > >> device.c. After removing __init type, these functions are not specific to >> domain building, so moving them out of domain_build.c to device.c. >> 2. Remove static type from handle_device_interrupt(). >> >> Overall, these changes are done to support the dynamic programming of a nodes >> where an overlay node will be added to fdt and unflattened node will be added to >> dt_host. Furthermore, IRQ and mmio mapping will be done for the added node. >> >> Signed-off-by: Vikram Garhwal >> --- >> xen/arch/arm/device.c | 145 ++++++++++++++++++++++++ >> xen/arch/arm/domain_build.c | 142 ----------------------- >> xen/arch/arm/include/asm/domain_build.h | 2 - >> xen/arch/arm/include/asm/setup.h | 6 + >> xen/common/device_tree.c | 16 +-- >> 5 files changed, 159 insertions(+), 152 deletions(-) >> >> diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c >> index ca8539dee5..fec6e29c42 100644 >> --- a/xen/arch/arm/device.c >> +++ b/xen/arch/arm/device.c >> @@ -12,6 +12,9 @@ >> #include >> #include >> #include >> +#include >> +#include > I can't see why do we need to include this header. I will recheck if this is really needed. > >> +#include > You should keep the alphabetical order so: > - iocap goes after init.h > - setup.h goes after device.h Will change it. > Apart from that, it looks ok so: Thanks! > Reviewed-by: Michal Orzel > > ~Michal > From xen-devel-bounces@lists.xenproject.org Fri Apr 14 17:51:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 17:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521181.809562 (Exim 4.92) (envelope-from ) id 1pnNZy-0008PX-IT; Fri, 14 Apr 2023 17:51:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521181.809562; Fri, 14 Apr 2023 17:51:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNZy-0008PQ-Ff; Fri, 14 Apr 2023 17:51:22 +0000 Received: by outflank-mailman (input) for mailman id 521181; Fri, 14 Apr 2023 17:51:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNZw-0008PK-TZ for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 17:51:20 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20627.outbound.protection.outlook.com [2a01:111:f400:fe59::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5459c84-daec-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 19:51:19 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by CY5PR12MB6551.namprd12.prod.outlook.com (2603:10b6:930:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 17:51:05 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 17:51:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5459c84-daec-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ABqetQ6EY57DXnmcLwCkl4K0btJxstAwaJ0qNF+Bc1F3qZxraUKtkcgD/ptDpJeO+XX0vZQmaICMF0jDfiyjqHYwH0lTf4Ks4qW6nd9iM1Ge7Mw2MN5NgD25z0joOaQP5d0HYK2QQup/7rI4E2k5vfeDYOg45KREeEoBVUiLol8EcM6sWVPKKs7AJx1IxLCBTHqb2ZLscXP9RPgNlIqE8u6Cp/UvCKepyXcLdRIoDc3nLdhvZyY2DrdN/dco/4lNGVGYPt3kVWrc91Bnav+/r8N8qX6bb4XCNaJ8iwrr7N2PdlN1kN2Nr/1WRfGMSDbbioMAvhTYRaX9DGAINm6w3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KqWe/9nIBPcNRaEVaF8DD9CU4ey90w+PK361ATYjsSo=; b=AJhlCgC1N4a2aeMCAm/v1oXxuFsCjsttoPYusXD9PIuJaQwDCxG3bqPLMhAIbacHHbuHqWmuvm/B1M/9WXNzKWWlLcFeUBadtSuD4ET6RNSohDNXaaGeP+gCXn8qZPDBkVjMqu8WxQpWwr7ceU4mrWl+9NB7eaP1n1FrfEvsfj4ZeVSwnoecNxaprJ4nc31IdrwS4qQR7YVI+FfKNT9QRgQYKRLlG69IwPOQXLADhCbwRaNc/cEpqsxOobeyUYjQOcG0NRPvqKaRJeme9bo1o8eD1ISMyuPMQn6vbUMot4U1jhPq55u28RVVV4vcUbaVPgEN36xOAOieMqxwCAWewQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KqWe/9nIBPcNRaEVaF8DD9CU4ey90w+PK361ATYjsSo=; b=LhnejioaQtRRk7BQvGLII60UG46A2JzzIzQiRC6JANmPElPl3tOC65Djl2lvnFBad1l+gDnKupbcBpexVApwViHG2N6Wg6p4mLvbes7rwMXkdV1QwTum4OtpzbOsETB66rQxMVyvecuOpjx8zeAyQ4BcUZgkQ3st4brONxo69D4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Fri, 14 Apr 2023 10:51:02 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-3-vikram.garhwal@amd.com> <869d014a-d325-6592-d51e-e3638ba04076@xen.org> From: Vikram Garhwal In-Reply-To: <869d014a-d325-6592-d51e-e3638ba04076@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR13CA0140.namprd13.prod.outlook.com (2603:10b6:a03:2c6::25) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|CY5PR12MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: 1aaf64ef-2b85-4f80-48b3-08db3d10d184 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /TLKPjs+l451swX29auLPr892nkKcm6sOXr85PmeukLjRXpnMXkayNf9GOIu2+8BdtZTDlUppR0tz84cdgQZAh1uohhMgNSH0jzSrYQ/eBRjeFeyEezIQil5qsfepTIyghG8StIEz0tkfd13LImELuDQriqlTB1Z9Ymw2WS9Sjk32exyPFGCML2f3OZKoLeraMFd4/FJHuOCHqUMesmwO9/MhRdgN/8iastrentqnA/0TLb/I8WF6Bz6zJTEB0QmbuTg2hlX712jK/l6fd+sQqx2QfJMwA4kD37Svo2GS+ecA2EVEktz+hs/xlkFMyyXPuiRjZ+qZS3xg+Cpt6M8ZG5ihus9dOuYHfV4mr6WL5IXkwE3qFnXRGCEoh0RAUaQR1ZTKFY9JUeXkp9AY0FLSf/IvhwnEDwA94buYQ0UBbapGJdDadMzfomusiOP+M5qkAuoWpl2ebFptd90rU4+ZGxFo09zhT7YbVeog4IsHjezCndPyu+RRXicUPaZDxjUmfkFqLPJwVDsM7Z62b6Px4NpfEEK6+vADq9e2Y1WQTN3cRgnPq1/Szet6geuN+dFw1FwX8T95arRSoWXCJzyFmNEHijv4Pe8f7q3fqTxjHcc+AzNO7h879TIdlr8r1GgmwyETwQlNoaJE/9wBP+zRw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(451199021)(41300700001)(4326008)(66476007)(2616005)(66556008)(66946007)(36756003)(186003)(2906002)(44832011)(5660300002)(83380400001)(8936002)(8676002)(86362001)(31696002)(478600001)(6486002)(31686004)(6512007)(53546011)(6506007)(26005)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnpCSjFaRitScHdrUVBHdk53dkhHcksxKzFtaWVXNXlBR09yK1piUGx6Vlhu?= =?utf-8?B?Y0U3WUZMRTlRMWRVT1V1a1RIdWx0eTlWU242VEI3bzlLWll0OVk4T2FXTzVU?= =?utf-8?B?dFpXWCtvZzI4TTV5K1RCMnp0Z1RtejVYaVl2eU10YitEMFNoSSs0Y3lHRHVK?= =?utf-8?B?U3FmZWFidEd5ODFOWWVRMmhNQTJSaE9vZTkreENHU21rblVvQUpqeDFNeTlz?= =?utf-8?B?S0tUOXNucEkwT3RESHNTRDNhYnNqd2ltSXJiYktsc2JJYkNQUjdmZFhkS0Rl?= =?utf-8?B?V3ErcVROYnIrK0RtNVJXZDdIWWh2WTVpU3J5UHFCS3RMRUVzL2lBL0ROeEFO?= =?utf-8?B?SjRTNjM2N2VoenJtUUxsWDlTZEk0LzNyRUVyaWN6bmhmSnJTZ2pseVpQNzdm?= =?utf-8?B?NFB3SXpOS3Yzc0wyN00ra2VlUTh6OGhRQUR3UW9XeUJ5WnJJRFBPR1h5a0l1?= =?utf-8?B?c0ZXN1lpazdvaHZqaTlWS0VzenVhck5nL0pWTTB2czBMM3JHWmFWY1FZNUp3?= =?utf-8?B?NUE2SDZyQTZjQThVekU4bzVJVmpWZCtuR0JQQ1BnOVluV21TL0lrTnhSelNO?= =?utf-8?B?YTRqVk9WY01nZDB1bzlqNXlFLzBsaHhKY1J1OGs4OElYdDNDTittRm5HTTMx?= =?utf-8?B?eUNIbUJlK2huUVlsY05uKzdyL1dkd0pnQkpiazY4T3c5Q3ZCWExyZDRuQjdP?= =?utf-8?B?VEowcWdiR0ZPcDFLT2pubWVCMnBKTTdBVFdpUHdCc0JUNm05R2J4a0JFclVp?= =?utf-8?B?R212NGVqR1ZJU1FPVUhYcG1YRGlHRXJVcDFFS3BITEVsdTFqZFRocVcwWTV0?= =?utf-8?B?UWZuSnFxQ3pHSVd4R1RROFJYVFB5WTZ2TXVpU2pNS2kwUnNQU2ExK3lCbDhy?= =?utf-8?B?YlRCdVh0VThKanFaWmVlNmFhTUpxZTdWeWpRNXJlbXQ2dGd2M1VKLyszSldO?= =?utf-8?B?RHFySzZsVHB4UHRNVFBuQ3JuM3FaS2d6MTh6cFA2WEF4RTAyNjJRV3VJZDEw?= =?utf-8?B?RTIvWEsrL0FUbU5XNWNldHllMkdzVnhiTTh4YUZWNUtHNkVDOGNTRldtazND?= =?utf-8?B?MXM2Wm1lOWsvQ1g1Z29YanlVZGkrVEdhdVlmUWxpUEVDcFpPa2UvR05zUTBL?= =?utf-8?B?aHdmeDJzUWFuMTFVb3k1TS9hOEVkUks1NVdHcjBCRmtVcjVscG1EVUZYTTZ6?= =?utf-8?B?TjQvOWxORlI2R3MvT2NKSUpTUGFSWWdlZEJ0RG0yRktxbXFPVlpHeUhvYm4w?= =?utf-8?B?MTE4SVB0ckZlOUxEL0JibHkzNG9kWGtaVmd0aHVhakExTE81UWZDVzBkbUhw?= =?utf-8?B?SGtZUEMwZ1Y0bnl0aFpYOGd0SjRCTVhYbHFnRTJPelYvMTh5cVYvYjg2Y2hj?= =?utf-8?B?V3VjY0NtNmdxd05BOFE3cWtBR1pQdGdreFIvU2RtY2VsQkxxa01HeWdRU2lj?= =?utf-8?B?bnB5RzJxWVdTa2VQbVIzd0FLc2Nkditpb1RBYlJhdjhZemlRaHNSM1ZXUXgx?= =?utf-8?B?c3lqTUxBUVZZazB1K0RuUTB2UnFDalYxR25nNGFzamFsWU14Q1k2aHB3Z2xr?= =?utf-8?B?TUNRcURQcDd3UkxGaHhCWDZRMHVEcElWOTRBcStmbStEREpUUFRBR0VUdXZh?= =?utf-8?B?Z21TbnY4UGFSdHlJZ1ZGay9wd3g2emZ0ajhGbnJUbjBSdnhabHRVOEh1S3Vp?= =?utf-8?B?aDBYcFBibU9TTmRSL0xpUkRNK29WcVYvZDBBQXptVEtrYWZrQU5xaHJwUkhJ?= =?utf-8?B?VkFyYVJVdkRYdWc1UEtsNElyblhRNGJZZ1VISlVua3dlNUNZd0dXcUNCUUxu?= =?utf-8?B?Nmg0MHV0L2dXUzF5RGZ3ZzU3ZmtNTzNNNml6aS9jRWdQUVRKQVR2eUk2ME5v?= =?utf-8?B?MnY5WFhETzIydGdmWUZZYWFXc1Y4SEI4Y0tyM0xTUnZCQ3BscmhXZUV2bzZ0?= =?utf-8?B?dGpUZ3BHeHJ3VUZTb3V5aEtUN0QvWmROS3pZaWRyVmlLZWdIZVRoUG02enk0?= =?utf-8?B?dUlEbnBpZEZabmplbmkwOWRWQ2J6dUZ4S210NXNKOVJySHZQVHlKb3JvY2Fy?= =?utf-8?B?NTgybVk1QjZtdEVaUDBuNmliTEoyaUFlWkhJYndRNm9aSW5iclhobmphb0pO?= =?utf-8?Q?qN6WwSe3LqeF/wWwi6Y4NS0nf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aaf64ef-2b85-4f80-48b3-08db3d10d184 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 17:51:04.8250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9tgAUSelpVTgVzOdHzNY08chY0c/yUzlhCUJohAVRsik0Zxx8b5bsN0OvBfotx1ATLwPfsVlLVus4yKWWtStEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551 Hi, Julien & Michal, thanks for comments. On 4/13/23 3:03 AM, Julien Grall wrote: > Hi, > > On 11/04/2023 20:16, Vikram Garhwal wrote: >> Following changes are done to __unflatten_device_tree(): >>      1. __unflatten_device_tree() is renamed to unflatten_device_tree(). >>      2. Remove static function type. >>      3. Add handling of memory allocation. This will be useful in >> dynamic node >>          programming when we unflatten the dt during runtime memory >> allocation >>          can fail. >> >> Signed-off-by: Vikram Garhwal >> --- >>   xen/common/device_tree.c      | 10 ++++++---- >>   xen/include/xen/device_tree.h |  5 +++++ >>   2 files changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index aed38ff63c..bf847b2584 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const >> void *fdt, >>   } >>     /** >> - * __unflatten_device_tree - create tree of device_nodes from flat blob >> + * unflatten_device_tree - create tree of device_nodes from flat blob >>    * >>    * unflattens a device-tree, creating the >>    * tree of struct device_node. It also fills the "name" and "type" >> @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const >> void *fdt, >>    * @fdt: The fdt to expand >>    * @mynodes: The device_node tree created by the call >>    */ >> -static void __unflatten_device_tree(const void *fdt, >> -                                    struct dt_device_node **mynodes) >> +void unflatten_device_tree(const void *fdt, struct dt_device_node >> **mynodes) >>   { >>       unsigned long start, mem, size; >>       struct dt_device_node **allnextp = mynodes; >> @@ -2079,6 +2078,9 @@ static void __unflatten_device_tree(const void >> *fdt, >>       /* Allocate memory for the expanded device tree */ >>       mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct >> dt_device_node)); >>   +    if ( !mem ) >> +        panic("Cannot allocate memory for unflatten device tree\n"); > > After your series, unflatten_device_tree() will be called after boot, > so we should not unconditionally called panic(). Instead, > unflatten_device_tree() should return an error and let the caller > decide what to do. Looks like i misunderstood v4 comments. Will change it to propagate an error in case of failure here to the handle_add_overlay_nodes() caller and that will further forward to error to toolstack. > > I suggest to read misc/xen-error-handling.txt to understand when to > use panic()/BUG() & co. For... > > >> + >>       ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); >>         dt_dprintk("  unflattening %lx...\n", mem); >> @@ -2179,7 +2181,7 @@ dt_find_interrupt_controller(const struct >> dt_device_match *matches) >>     void __init dt_unflatten_host_device_tree(void) >>   { >> -    __unflatten_device_tree(device_tree_flattened, &dt_host); >> +    unflatten_device_tree(device_tree_flattened, &dt_host); > > ... this caller this should be a panic() (this is OK here because it > is boot code). > > But for your new caller, you should properly report the error back the > toolstack. Understood, will change it in next version. > > Also, unflatten_dt_node() (called by __unflatten_device_tree()) seems > to have some failure cases. Can you explain why they are not properly > propagated in your case? Are you trusting the device-tree to always be > valid? for dynamic_programming, while adding node(check patch: [XEN][PATCH v5 14/17] xen/arm: Implement device tree node addition functionalities), fdt_overlay_apply() is called before unflatten_device_tree() is called. fdt_overlay_apply() will catch the invalid device-tree overlay nodes. Regards, Vikram > > Cheers, > From xen-devel-bounces@lists.xenproject.org Fri Apr 14 17:54:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 17:54:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521186.809571 (Exim 4.92) (envelope-from ) id 1pnNd1-0000bs-3k; Fri, 14 Apr 2023 17:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521186.809571; Fri, 14 Apr 2023 17:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNd1-0000bl-17; Fri, 14 Apr 2023 17:54:31 +0000 Received: by outflank-mailman (input) for mailman id 521186; Fri, 14 Apr 2023 17:54:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNd0-0000bd-8o for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 17:54:30 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062f.outbound.protection.outlook.com [2a01:111:f400:7eaa::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65118504-daed-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 19:54:27 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by PH0PR12MB5434.namprd12.prod.outlook.com (2603:10b6:510:d5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 17:54:23 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 17:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65118504-daed-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wd0p5OaEyMrCDZAHixCs9kT3OPLKs/tVMjP6BJ91nJLOLMRZMlGN2g4fhawEQiVQp9BR7C9YlJDOmmVkhUIlQVdHJa2cK7AdZzM0mKJl51S8sZsOh0MlL6h8w6d2CZ2iNM/sdLlVMHsdfQhsh688bjXr4kQP1KKDY4TmnlA7knjJmr+O+L51GjvZF5Fk6T8c+uEajW2LvbBlbd+KQa5/uUIC9bjwnnJXkE803ImMK6zs4jgG5yNWZX0VXO1geUOX+xV9fDJ4GfuN2O4xuI9Jyk+4eg9NnfOCac3ORcet0NEwSrvZ1SeJ7bQl7Jh7bodTYJqlDkvlJ2ubMehKPGodgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PhD2gGUs0psgEuiecZN5i/3qHZ0Elom1MVvlI/TlWIU=; b=FiPJ+vhy4d3vAnJInwIkrNQsuD9fVDnkB9mhTmLpX1PM29nV6AqOEXVaRFQ+fpJ9otuYuyZ2EnMtVVubQuBIq4uwCJ6EbAWoyhu0mM6x6BWiz1OGG5IFijlRwxR3hupuwXgUHy9+Hb3w2bq4NBwsTS71rFcRZ7pu7iSlZbZ7VtLiQgkn2CEzWksYmfAEiiFkJRfkgJ2EmRW5w7hi7zjb9AHjzwQteRl0O9Z4yi6KZ6kK4TevL8oiTxZDpo67Mbwx5N+F/crY7BAfk9tNd1yA5jATPfEuc2BlB7jUMVuxk4oTO7ONWtZx0AC0kTpc3DvpV5h775E52iC78wpE/0LcUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PhD2gGUs0psgEuiecZN5i/3qHZ0Elom1MVvlI/TlWIU=; b=eEybioKefLPy3NEzUxyHUANAsvSrQyT88Wo+TPAbFw+vvdaPyLCK+U2SmxjGNvDtRi9ZBpQiXI1/lBkJuG6VaM/JGilhDUaexluXFqu9sSEzEmRGQCtkuo7OfhhWlj5HRCQUQQhpUhpRkXTCLUKHc8kxeLZz5IH31NHm9B/OfIc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <7dcd0b9a-f986-e6b0-46c6-95936799f39d@amd.com> Date: Fri, 14 Apr 2023 10:54:21 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target() Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Julien Grall , Vikram Garhwal , David Gibson References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-6-vikram.garhwal@amd.com> <601858e2-79b5-35da-df00-2d9061d8ff22@amd.com> From: Vikram Garhwal In-Reply-To: <601858e2-79b5-35da-df00-2d9061d8ff22@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0014.namprd13.prod.outlook.com (2603:10b6:a03:2c0::19) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|PH0PR12MB5434:EE_ X-MS-Office365-Filtering-Correlation-Id: 96a6070f-760b-45c7-0a82-08db3d1147e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jmidc8rV9PYJJJrya2oE90YRImQm76IABv0Ng23qgsvDrnblIeUoNkEF50q7zS7iWbESv9K3LL3kjvFZ15rtOeNNMNZxY6aBxN8bU77k22xPuy+M0ZycyN//ljHjEvOP7w/XEr0G2KqvazHQmue0LNLM4uYuLdGwgccC4S3xP7w/9PHQysHOOpzUd6IR7lNuVop8KlkiZgJa8sIqBIL4gWbRggxjeCbqLok7WcCrbGLrqhacIluPR1mrS2omjhLDXEAVq8kYBk9HSmAbxJthKUY6iRFM9Lll+3sdz9Stjf3Wd9vKQ6WBQj06zA4wGLRjM1Oq794PBBRA2tSWrjAK3a2hdnDJXGLszKmA+cKUvl0JIHKcaZKGludLb4mYoC3dEieKLe/c9aEcu+zk40hhZtWLuwgQY8G8lU/Mc3mBlF6oeKlnqGenVrXny3Vy0Jc0E4+l3dP20eqyJUmJAbocgmmZLCuTOB2uSy06y6NPvhzGURl4Q+rknA9MCTGmZ4BDM5fAfZzpuB3m2NJIlwTHlJsB6p+wZsX3Y6fXLxoCZEYz0YdeXYZEkucAw6guQ/DBQMXQA8NcwGCw9cXzKDLIsJdwEObBH3aOzRYZr7t66uSFfyiBQl/Z00XIvu4j3Po+/ILE4fMdclFl58m/6iwp6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199021)(44832011)(5660300002)(2616005)(8936002)(2906002)(83380400001)(31686004)(6506007)(6512007)(53546011)(26005)(38100700002)(36756003)(478600001)(6486002)(86362001)(966005)(54906003)(41300700001)(66946007)(66556008)(8676002)(66476007)(4326008)(186003)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QldWeklRQWVHWGNRcVJFaHI0QUZ0djYvamlyZXlCRy9JZktZYnVtWE9kSWFk?= =?utf-8?B?bHpYcWtkMkdJa0dnSW9Ra3E3VWpoMkJSVlRjMjlTVTdlUjd3OGVvMVVYR3Uw?= =?utf-8?B?T0UxMnI3enlBMkNiTW9sMWFFUU9SVGVNNFBPY2M1WFdHandsMXB1aXM2bGgy?= =?utf-8?B?YkQ3bHB0YjdGZ3FIV3IvODNFNVhwRHE2dVpMT3NtSUo3ekpHYnc3SWUrenVF?= =?utf-8?B?UXNnOTBOS3pDbmN4RnlveTlXdktyaXlNdWYwMHdwZ1dLK2cvTW1hUUxKTUR3?= =?utf-8?B?WlFndnJBY0h3eFlROCswTmZqZkRPQndlaWZqdE5peFFGODU5cmZqM3F0V1ly?= =?utf-8?B?cE5hamFpdUZ5eFJqbDRIWDRNaUtrbDV6TVN5SjNLNElyODJ0dmVyWFI3MW04?= =?utf-8?B?S3RiMXliVXlhRXNkdnk4VUl1RUR0TkNBYzJVVWJlazJEQzJXMDdsU0pqdFN2?= =?utf-8?B?K3A0QkxMUWVqbnNiVTZrOVlabE42UlVwOFdHdkFTemJNeDI1MWVJbWRSR0pz?= =?utf-8?B?Q2V4SWg2TXFuNmVudUNnZlZ5SVJYNHBCZkJRdDRzaCtlNkVCN2hkbGtRM0pk?= =?utf-8?B?a1p0eWRGS01GWGhRZFVnc2ttM0ptaGcrV0I3a2lVY3ppdjh4aExPaFJLbU5F?= =?utf-8?B?NGJSKzRiWlczblZDeU0xWXZzK0kxRzBDelc5bmhoM3gveHZIMmtBWHVDKzB0?= =?utf-8?B?TnhNT0FldFVIZHJrMWY4aVdoYy9mZytGMnI1RG5sMHRYdm42N01yaDYxVHNh?= =?utf-8?B?RWd5WnU2a1NBVldqby9abUhkbzVRMVViaU9CUC8vMzB2OWxxdVhlK0ZRdG1R?= =?utf-8?B?OStRZSs2dENvb1YxWVNwV0MyTUEzZTUzbUpTZUdSaUloVjIrUGxtaTcveHNS?= =?utf-8?B?eW5HV3NyUzhZSmY4YXhNTnJDZ3NwelgvbWswR3BjRkdtSlZJc0xlRDlteXNz?= =?utf-8?B?eGlKTzhjNHUxcjBQaHN5WVAzTi9qcUl2T29jbG9Wc1cwWWc4a2xueFMzemIw?= =?utf-8?B?a1V3Q0ZUTldTZE1jSnExeEhCWkNCdWIvaE5oTlJxaUxzbTlXcHNtS083T0c1?= =?utf-8?B?cERMZ2pUNnhXSVA3S3pQcVorZS9heUxueXBCcVZUbFIyYmFnUzdYWDJsYjd5?= =?utf-8?B?ZGc5bnh3dm5mSmJWcDlGeFdadmt4eUh1cGMzbU9VTktNTXlsOVplY3g2eW9j?= =?utf-8?B?aG5IbjhEb2JmL3Yrak5MY0pla0hhV0QyVnJLaGhTbm9tWG1iN0xWb2JUZEYr?= =?utf-8?B?V0xSRndUYS9HODF1MHU1Y09nSHk0QXRUcE8xNC9LSzlKQWtuSndMZG5jaVk1?= =?utf-8?B?WW1ReHVDeStJaGdIbzJBS0RkeWU0Z1UrVkZpb3NpcGJIdzhEQUR6SW1PTWEy?= =?utf-8?B?dlFKcS92Y0dDeTBLOTlDQWFwWEcwMHFhNUVGR2Vma0o3Y0lTTURjdmlwc1VF?= =?utf-8?B?cyt2UXJRZ2svTjducnNwY3dVVURhaXQ5TzlsRXd5Y3lOYnhwU09hRnN5eTgv?= =?utf-8?B?OTI0dE5LMUk3dElHVTlNbVVrbHNsU0NkSzkvWVVuSDIvbStkK0I5QTR4WERy?= =?utf-8?B?MWthZXVKWExHVnBkU1dsL2JVbTByZFdSamRDZWxMbk5UTVlhN29ubFNwZEpS?= =?utf-8?B?alNZVzBHR2xSa2RTbUdwWk5RK29KTTZZMXVVNVpzbWtGOVFnbVlNOXRYYVNs?= =?utf-8?B?NEQxSncyQkIxQXVwMFljV29qbzBxTG9OT2VVbE42UFJVZ3EwNkYxbXBsbm9n?= =?utf-8?B?M0dpR2dDY25KZFlsSW14dmFXZ0R1dlNhWThHdWwzbExDZVZUMm5ST1hTTkRs?= =?utf-8?B?cldFT0ZBSE1iK2RZT2dtRFA1cEdybXhGYXc3SEtrblZ6Mlh4R200YkZjVy9J?= =?utf-8?B?UU92SVBLWkdwZElia2JTZzczRXV0V21zMGt1MGdBVHZNTVpMQUp2WThsRk10?= =?utf-8?B?dVkzR3kxSkx2WE5hbTlOYlcrTitoK0ZZRXZwZWNDMWtHYmhjZTgyNTRPRVNi?= =?utf-8?B?TXBXQ2dPK0JhMHcyaXZvNnFBbi9IbE5KWjRlWG9XVkIxbzZIb1hYUDRJRWtQ?= =?utf-8?B?M053cVpRdWJXNUhneEwzWlF0ejBjTEEwL0oycE9ONzJWNTI3anFpT2MrRFF2?= =?utf-8?Q?l1XprhOvTtJjNkzelKMeOe+zC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96a6070f-760b-45c7-0a82-08db3d1147e1 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 17:54:23.4425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bWMVMakvUuGEK2CCSu0pQcNTbr7bUt4jwUsE800BK44orSxiEfoIObFeaDN+8+Bn3cJ/Ej9racejWYHNlF5d0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5434 Hi Michal, On 4/13/23 6:11 AM, Michal Orzel wrote: > Hi Vikram, > > On 11/04/2023 21:16, Vikram Garhwal wrote: >> >> Rename overlay_get_target() to fdt_overlay_target_offset() and remove static >> function type. >> >> This is done to get the target path for the overlay nodes which is very useful >> in many cases. For example, Xen hypervisor needs it when applying overlays >> because Xen needs to do further processing of the overlay nodes, e.g. mapping of >> resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc. >> >> Signed-off-by: Vikram Garhwal >> Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> >> Signed-off-by: David Gibson >> Origin: https://github.com/dgibson/dtc 45f3d1a095dd > Wouldn't it be better to point to the main dtc repository under kernel.org rather than github? > Origin: git://git.kernel.org/pub/scm/utils/dtc/dtc.git 45f3d1a095dd Okay, i will change it in next version. Is there any guidelines/note for this preference? Will be helpful to me in future series. >> Signed-off-by: Vikram Garhwal > In any case: > Reviewed-by: Michal Orzel Thanks you! > > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:04:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521190.809582 (Exim 4.92) (envelope-from ) id 1pnNms-0002CR-30; Fri, 14 Apr 2023 18:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521190.809582; Fri, 14 Apr 2023 18:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNmr-0002CJ-Vz; Fri, 14 Apr 2023 18:04:41 +0000 Received: by outflank-mailman (input) for mailman id 521190; Fri, 14 Apr 2023 18:04:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNmq-0002CC-MX for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:04:40 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20605.outbound.protection.outlook.com [2a01:111:f400:fe5a::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d11371bf-daee-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 20:04:38 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by IA0PR12MB8862.namprd12.prod.outlook.com (2603:10b6:208:48e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Fri, 14 Apr 2023 18:04:34 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 18:04:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d11371bf-daee-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gyACCJCGPRTYKyehYTXnmb2My8kw1SLu2n8wbD9MOx28aw4fCo1r9SNV2UuuQk+A/2yBWhi/FO7LX2+cThRgnnnUfjd1tWg34MlEdpYc4jAgnIXd0qTJO7hu6XZhqLQziRJ6lxXbFE+gz7ZGfzPWkPL17UaURvQd2G1qiNwACvnNI2t5vv/fX1X6qFRZND0IEDq8bww+9ZTumwdiG+imFRFQ3ahTKurFt8i62AA7fN9ZA3+s0FhU8PbErszzTvmBHiQdZuTe+nCUXQRJSFBclv4kxT09gU/CZgQ4NrywXGeWL8aOjGftmMmCyMrGTKHgpqxoOhMbupTri9/zsC9HbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gj6MQrbDZkzu73BonYZ+DEwZMjhrF0TKWRr5HB+2lwo=; b=BmqeWhn12GAuZ14ValTxq5wKmwc6orlWGOLzUz6yaywQzq/squmHb7LSFMUUhll6pxcYJFn/NE5pfDPls8ZnxwIyP2kmzlnER7Mjf87LhvQlmXqt5Mq3QmfuCQoj6RQKkO1NXnP6I3dbNF4oGy1l7p0hkENIRmuxJDp/oZ9VN3+oyyADyZ2n+vqiKqzgmT8ia7Xpzt7GF+CsSDczoRYA0zCR4Wcz3fPCJxaV/7aCvTNdNR9vcs9TjjApe/lu+APOzB9/NBnSgocQPpHeHTcqtjkDxvLLFAn/nwpA7iiifxZ0vWc9pim1pbBzSqUCQQPSI7DxDQlaszAQ5KBNsJQPEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gj6MQrbDZkzu73BonYZ+DEwZMjhrF0TKWRr5HB+2lwo=; b=3rXt6Zg8A32qAIT+6zPMRjYimhJVPVCHw5Vcu1m4KlvyCuccX75SZXDbNMAWrKCGbPTfbTjTJHM8Wkc7Gvdtl32tWH9VA4LBr+5TA4uUA5Sqypo1Oll5phU5JEAGFMtYpnqPz5AVdyWk6IGADzmhbMXXaD4CP84S9WcPblJ5NQs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Fri, 14 Apr 2023 11:04:31 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 06/17] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Julien Grall References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-7-vikram.garhwal@amd.com> <9211242e-102c-4468-c35b-c88f8e31b274@amd.com> From: Vikram Garhwal In-Reply-To: <9211242e-102c-4468-c35b-c88f8e31b274@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR01CA0052.prod.exchangelabs.com (2603:10b6:a03:94::29) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|IA0PR12MB8862:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f0a3844-1544-4632-5129-08db3d12b3c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yceAmFE7yzqfm9XQ4Ot8LInf3UDDKEoHUXmSveEfpeSLC6xIEoQjY5ykFa4A84hsdxVIqxgpfnUj/bkbo94w2uPNnAOh1p8NaKmofRCfJu2crNh540MXcdDO+CHEc7xERtor00Hxwq6vRlAKTpM3tc4ZYmb2f6mLv1xXbNta+6sEdQPyOFSI88nUBlPtCfnphPRGN1H6MUAZxb2LErTQOwMzLYslhjp8p24BibqMPn4HVxA+BCuZqLi0+Jaz1EAIJnTQLmvlq0xz+GlqCDFBjOqRerqrNl2CQnumGu4lVOIXPx9FRLbKpntepUabSJ+MufC8saWsHvg9j2WQ6yXysiGd8lMXH+ZWaZw0SSn7cNc3JF0smucRl9ghX7b6+Qv8ejuhguzXflnCgNhbjtNuCrmj/vu0DeaGTN4ykzOvISrc1kb+mB8MW4EAxen00wykeTyUC4VLF3YOyXb3g3LvA3vkTTNgfFz5+Z3uOOZ4uTn0G2m2q0e99DJtKz8rcBiymfG4AxUZnJIJYcdvNBDLhOHTw585Rc6Om3c7URtO62Tqfo8+slG4mURCJ6dqhfmQdbHl0p5uUskTnC8SF0EmH/Vgwiddudqw/RdUqNCOX7UU8thbRZDwFOpZIirQUAPg7zQZ4au6v6Fe1sJke2F+iR8+xeOTV2mUs5kfZRbBeAA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(39860400002)(136003)(451199021)(31686004)(86362001)(31696002)(2906002)(36756003)(6666004)(53546011)(186003)(83380400001)(2616005)(6512007)(26005)(6506007)(66556008)(6486002)(478600001)(66946007)(44832011)(66476007)(38100700002)(4326008)(8676002)(41300700001)(316002)(8936002)(5660300002)(37363002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzE4SXF6OEV6TXVKbUcyTnJtT2ZnL21aTjF4a1Vid3lneVJUWENiMkY5TUU5?= =?utf-8?B?QUY5a2lBTG9jOXdnSnMyanBMVDJ1WGdTM2swSlZpYUNpeElzYzlvK3FZQWx2?= =?utf-8?B?UDFCT3R3OC9mUW01VDlxY29KdTh4Q0F1NEIzbzUzYmM4bFJnVWpPeHNybVBK?= =?utf-8?B?bUx3MWpMaDY1WDFxRzhNVTkvZ3FLWnJER1V3cjY4YTd6aHlsdnJHelBQc2pY?= =?utf-8?B?dVFSbGtDdk5vNkNIMXF2UGN2UTJtM3FaaDVuTVRRa1paQWxIOE5iL3BKTzNE?= =?utf-8?B?M08yM2w2TWNSSU5IZXcyZEQ0N2ZmWUExclV3dWgzVmVWOTljSGltSHh6SFRG?= =?utf-8?B?NWFQQVlvWVhsd3hyM3l0elE3bTZOb0haVFNVaWZqWmI2ZEsxTTZpaEFpazY4?= =?utf-8?B?eExTVFdJQml6cUlwc3hNV0QwZS9ZbGdQYWhQd2xSOHN3ZG5ocm14ZzlBdlhP?= =?utf-8?B?NzNUZDZ5Tlh6bGt4Qk5DcVRzanpza1NtZlZXZGtRUlFYTkF0ZHAreVNwVGJ0?= =?utf-8?B?TXU1RTg5NCsraXExNU9abU1scVJZSmVFdlc1OHJiN3NDMVQzZ1pRcndDN1R5?= =?utf-8?B?OTFHV0c5NlN0N1JSOE5kc3NrOTA2SldEOS9FVCtxOTFrMk9QeGRTNit6ak9E?= =?utf-8?B?QkhneTRHa3FtdWhrcGZ3MVNndVNsMlkwSkhuemljQ2VNemplQjBUZ2d2OGpK?= =?utf-8?B?RlQ5dW5VVExQNXNxVW5PQ0pmbUsyYnB3MldxV1YrelpPV09MRXpOVndOU014?= =?utf-8?B?Q25VQUFGTFlxSWFzdStYSHpVVDBUNHlGR25uVkhVVXhpSHNGK0kwTzEvR2lz?= =?utf-8?B?Q3dCUlVLLzJIK3J4WE92TnZJZDZ4S3h0blBIVFVuZ1hVRXhSMlBLa3YxR01i?= =?utf-8?B?b2VkL1VUc25ERmFKcm1hTlJjU0twaG5rR2Z4Q3FYNklpVUJGNkovTmxMbm8y?= =?utf-8?B?Z0ZlZE8rVVNIc3pkYTFHMms1NGg2OE01c1Q4NDIxVkhHN0YrRGloZkl5V0hK?= =?utf-8?B?UnE5TXFheWJ2ODRwSXdid3VOU1FyWVdXQ0NidDIxanpWZWgwUDNISWg2WjJs?= =?utf-8?B?ZDBPaUFudWZ2VCtaRUFVNk9KeHVQeENVcEdhVThnSzdmeC9KMkpKdFN5cGsw?= =?utf-8?B?R1E4UE85aHROZWliTUE4c0JVbXVZSWJGa3VIUXZsN0ZkZk9tc2p6SGxUV3ZF?= =?utf-8?B?UW15QXFRKzgveHFSNExlTHl3NFMxOS9hR1Y5dlBmL0VNYWEzM0I2cW41ZXB3?= =?utf-8?B?c3JvOGNJU0JTT2lWSmRVOTFUU09PUHNZOWZsZWM3NmVqaFZLRWJYb3lwUzV1?= =?utf-8?B?QllGWTkyS24rYWN6REZHNHVoVWQ5STRmNjFTNWliejNhamJ1cm9JYTlRUUNy?= =?utf-8?B?TVQ5akppNXdoZjBrSHIwYmNzbDlkK1poaVZxYVJ5bHdMV0NTam1MNnBtUk9D?= =?utf-8?B?YXFtbnV5YlJQOVlmMGlEaFA0VGtHMGVHYjdrd1ZCcjNvU3VMZkFoUFVIZ3ZC?= =?utf-8?B?S3pEZG8zdTB4Z3FseFBCZjg3NzRqRit2YnVsUE1tT0dlcXkxdDBIQkJseEpr?= =?utf-8?B?VkE5SVVTdlltTHZqYUFGbzNnZUtnN3gray9sMC9WM1BGN0sySGJGbjFnWkNJ?= =?utf-8?B?dDU0VENDeHVuRHRwckVyUDl2dkdmM1NSa1lmckMzTkc0M0ZGV1ZzeWlCREMy?= =?utf-8?B?T0w5OEdRcjdwcTVhMkIyVWd6b0NJTU95amRuV1BrQTNoR3ZPVTJKbVV5Q2Fi?= =?utf-8?B?S1VpQzRrUTdSL2lraExuZjFMQnFXTnZmWVlzaVJMMmZyMHNzVGYwL0ZSaWhH?= =?utf-8?B?dng1VWlSWjZidnpUdisxRGNaL3IwemNWWXNNdmljQUZIS0tHVjliaUc1NXk1?= =?utf-8?B?WWVOb0huVHdjK2Q1ZDdrM2tEdkVXNHlPdlY3MzBlT3k0MTFhSlkxRVdUVjZ0?= =?utf-8?B?KzRONmJuRFBlWkZuVFZsL2xvdElNZmVKVlBhWWtwWmxsQk90UVVLVzVJY3d0?= =?utf-8?B?Tm9VWVRFWk8za090UDdIL0ZQT1J0c29LcHMvWGNBa0dxZVVkS3p5ZWJtSGxP?= =?utf-8?B?aGtXZUF2aERKbnBHTDFKSmZHRVBBNGgyM0padnVVT0JnVmYrNFJpRlpQL3pZ?= =?utf-8?Q?VpaJw/j6uzzY+AaKNprdygaNv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f0a3844-1544-4632-5129-08db3d12b3c6 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 18:04:33.9701 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oem9AvBT4zsnxNs1J1BFDcXb2Ol4rAB64yhQXltqR89WlKL/ungGGS8JY3RLHIc8dDVjc6iHKHiF/UqrZQ1A7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8862 Hi Michal, On 4/13/23 6:40 AM, Michal Orzel wrote: > Hi Vikram, > > On 11/04/2023 21:16, Vikram Garhwal wrote: >> >> Add device_tree_find_node_by_path() to find a matching node with path for a >> dt_device_node. >> >> Reason behind this function: >> Each time overlay nodes are added using .dtbo, a new fdt(memcpy of >> device_tree_flattened) is created and updated with overlay nodes. This >> updated fdt is further unflattened to a dt_host_new. Next, we need to find >> the overlay nodes in dt_host_new, find the overlay node's parent in dt_host >> and add the nodes as child under their parent in the dt_host. Thus we need >> this function to search for node in different unflattened device trees. > You do not mention making dt_find_node_by_path() static inline. Will add a comment about it in v6. > >> Signed-off-by: Vikram Garhwal >> --- >> xen/common/device_tree.c | 5 +++-- >> xen/include/xen/device_tree.h | 17 +++++++++++++++-- >> 2 files changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index bf847b2584..507b4ac5b6 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -358,11 +358,12 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, >> return np; >> } >> >> -struct dt_device_node *dt_find_node_by_path(const char *path) >> +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, >> + const char *path) >> { >> struct dt_device_node *np; >> >> - dt_for_each_device_node(dt_host, np) >> + dt_for_each_device_node(dt, np) >> if ( np->full_name && (dt_node_cmp(np->full_name, path) == 0) ) >> break; >> >> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h >> index 58ac12abe3..998f972ebc 100644 >> --- a/xen/include/xen/device_tree.h >> +++ b/xen/include/xen/device_tree.h >> @@ -534,13 +534,26 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, >> struct dt_device_node *dt_find_node_by_alias(const char *alias); >> >> /** >> - * dt_find_node_by_path - Find a node matching a full DT path >> + * device_tree_find_node_by_path - Generic function to find a node matching the >> + * full DT path for any given unflatten device tree >> + * @dt_node: The device tree to search > This should be @dt to match the parameter. Also, shouldn't the description say: > "the node to start searching from" > or > "device tree root node" > > FWICS, you expect to pass a root node as dt node. However, in device_tree_find_node_by_path() > you do not check if a provided node is a root node or not (e.g. no parent). Is this intended? Yeah, intent was to write a generic function where we can search from middle of a device_tree as long as we have the start node from where to search. But yeah so far for dynamic programming it's been called for a root nodes only. > > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:09:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521193.809591 (Exim 4.92) (envelope-from ) id 1pnNrC-0002oO-Jk; Fri, 14 Apr 2023 18:09:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521193.809591; Fri, 14 Apr 2023 18:09:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNrC-0002oH-H9; Fri, 14 Apr 2023 18:09:10 +0000 Received: by outflank-mailman (input) for mailman id 521193; Fri, 14 Apr 2023 18:09:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNrB-0002oB-DM for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:09:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNrB-0001vX-9J; Fri, 14 Apr 2023 18:09:09 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.152.63]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pnNrB-0004G0-31; Fri, 14 Apr 2023 18:09:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tnkLueb8MbcDuwKISZhvDbBJkG7Eu680dhtJ0tO48i0=; b=Oe/1RZpheYpNyVOx19OjkZq/3S XMEJheDEB68R21iC5Fuejj0JXlfs7/Xst0HxwfO16+3II4O3BqkYCksnqRmTd4wuf9hTlR33yDH9J B9Gjsm489cgVOy9oA085++/CG0jPKNepSyRiW6yiTnHYLHMgDYL+lXQkb6deQqSHVoxQ=; Message-ID: <1198aebe-caa7-fefe-8c09-db7a14ec7c34@xen.org> Date: Fri, 14 Apr 2023 19:09:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Content-Language: en-US To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-3-vikram.garhwal@amd.com> <869d014a-d325-6592-d51e-e3638ba04076@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 14/04/2023 18:51, Vikram Garhwal wrote: > On 4/13/23 3:03 AM, Julien Grall wrote: >> Hi, >> >> On 11/04/2023 20:16, Vikram Garhwal wrote: >>> Following changes are done to __unflatten_device_tree(): >>>      1. __unflatten_device_tree() is renamed to unflatten_device_tree(). >>>      2. Remove static function type. >>>      3. Add handling of memory allocation. This will be useful in >>> dynamic node >>>          programming when we unflatten the dt during runtime memory >>> allocation >>>          can fail. >>> >>> Signed-off-by: Vikram Garhwal >>> --- >>>   xen/common/device_tree.c      | 10 ++++++---- >>>   xen/include/xen/device_tree.h |  5 +++++ >>>   2 files changed, 11 insertions(+), 4 deletions(-) >>> >>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >>> index aed38ff63c..bf847b2584 100644 >>> --- a/xen/common/device_tree.c >>> +++ b/xen/common/device_tree.c >>> @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const >>> void *fdt, >>>   } >>>     /** >>> - * __unflatten_device_tree - create tree of device_nodes from flat blob >>> + * unflatten_device_tree - create tree of device_nodes from flat blob >>>    * >>>    * unflattens a device-tree, creating the >>>    * tree of struct device_node. It also fills the "name" and "type" >>> @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const >>> void *fdt, >>>    * @fdt: The fdt to expand >>>    * @mynodes: The device_node tree created by the call >>>    */ >>> -static void __unflatten_device_tree(const void *fdt, >>> -                                    struct dt_device_node **mynodes) >>> +void unflatten_device_tree(const void *fdt, struct dt_device_node >>> **mynodes) >>>   { >>>       unsigned long start, mem, size; >>>       struct dt_device_node **allnextp = mynodes; >>> @@ -2079,6 +2078,9 @@ static void __unflatten_device_tree(const void >>> *fdt, >>>       /* Allocate memory for the expanded device tree */ >>>       mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct >>> dt_device_node)); >>>   +    if ( !mem ) >>> +        panic("Cannot allocate memory for unflatten device tree\n"); >> >> After your series, unflatten_device_tree() will be called after boot, >> so we should not unconditionally called panic(). Instead, >> unflatten_device_tree() should return an error and let the caller >> decide what to do. > Looks like i misunderstood v4 comments. Will change it to propagate an > error in case of failure here to the handle_add_overlay_nodes() caller > and that will further forward to error to toolstack. >> >> I suggest to read misc/xen-error-handling.txt to understand when to >> use panic()/BUG() & co. For... >> >> >>> + >>>       ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); >>>         dt_dprintk("  unflattening %lx...\n", mem); >>> @@ -2179,7 +2181,7 @@ dt_find_interrupt_controller(const struct >>> dt_device_match *matches) >>>     void __init dt_unflatten_host_device_tree(void) >>>   { >>> -    __unflatten_device_tree(device_tree_flattened, &dt_host); >>> +    unflatten_device_tree(device_tree_flattened, &dt_host); >> >> ... this caller this should be a panic() (this is OK here because it >> is boot code). >> >> But for your new caller, you should properly report the error back the >> toolstack. > Understood, will change it in next version. >> >> Also, unflatten_dt_node() (called by __unflatten_device_tree()) seems >> to have some failure cases. Can you explain why they are not properly >> propagated in your case? Are you trusting the device-tree to always be >> valid? > for dynamic_programming, while adding node(check patch: [XEN][PATCH v5 > 14/17] xen/arm: Implement device tree node addition functionalities), > fdt_overlay_apply() is called before unflatten_device_tree() is called. > fdt_overlay_apply() will catch the invalid device-tree overlay nodes. I agree that in theory fdt_overlay_apply() will catch invalid device-tree. However, neither of the functions are exempts of bugs and there is no code shared between the two (they are not even coming from the same project). So we could end up in a situation where fdt_overlay_apply() works but not unflatten_device_tree(). Therefore, I would rather prefer if the latter function properly handle any errors. Note that unflatten_dt_node() already have check the validity of the DT and will return. We just need to make sure they are treated as error rather than been ignored. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:28:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:28:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521199.809601 (Exim 4.92) (envelope-from ) id 1pnO9p-0005KS-7d; Fri, 14 Apr 2023 18:28:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521199.809601; Fri, 14 Apr 2023 18:28:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnO9p-0005KL-51; Fri, 14 Apr 2023 18:28:25 +0000 Received: by outflank-mailman (input) for mailman id 521199; Fri, 14 Apr 2023 18:28:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnO9n-0005K9-J5; Fri, 14 Apr 2023 18:28:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnO9n-0002H2-Fl; Fri, 14 Apr 2023 18:28:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnO9n-00027a-1h; Fri, 14 Apr 2023 18:28:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnO9n-0000QL-1C; Fri, 14 Apr 2023 18:28:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QrJn6+JnF4EuEdXZYQHgGWBWO3b665cEZalgOdhtzsU=; b=B7X1OKN8iO7DGwGg4DBOfL6+Nz 5T6cOE6kmyFRKsuzNArTdwiExSqMRxGKNYQgsa6yf1BaJbyOzVRwMyzNI5X8wuaoz3/lWHOhs1M2h Lyp0BLcg/kL9Z30gDQPYhKx0ubfRgnM1+DU6mrrK5/KUbxn6WP9elzroKCSxUQBao50U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180262: all pass - PUSHED X-Osstest-Versions-This: ovmf=797f526ae2a83811b0ccbde0138c65a9f137eba5 X-Osstest-Versions-That: ovmf=c9fb11f92f52e06bcb1279b467a3b2667757be44 From: osstest service owner Date: Fri, 14 Apr 2023 18:28:23 +0000 flight 180262 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180262/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 797f526ae2a83811b0ccbde0138c65a9f137eba5 baseline version: ovmf c9fb11f92f52e06bcb1279b467a3b2667757be44 Last test of basis 180261 2023-04-14 13:43:27 Z 0 days Testing same since 180262 2023-04-14 16:12:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c9fb11f92f..797f526ae2 797f526ae2a83811b0ccbde0138c65a9f137eba5 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:28:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:28:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521202.809612 (Exim 4.92) (envelope-from ) id 1pnO9y-0005bD-FF; Fri, 14 Apr 2023 18:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521202.809612; Fri, 14 Apr 2023 18:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnO9y-0005b6-CO; Fri, 14 Apr 2023 18:28:34 +0000 Received: by outflank-mailman (input) for mailman id 521202; Fri, 14 Apr 2023 18:28:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnO9w-0005aB-T4 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:28:33 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20600.outbound.protection.outlook.com [2a01:111:f400:fe5b::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26b7787b-daf2-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 20:28:29 +0200 (CEST) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by IA1PR12MB7517.namprd12.prod.outlook.com (2603:10b6:208:41a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 18:28:26 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f6c3:91ae:9bd8:edea%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 18:28:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26b7787b-daf2-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a4Xy9O8E6hhy2D0uaBVXt7J8cZ2Bb/9Nq5h2iHodmEFzwrtekUEBJOAOzedJwSK/8Kg+lW3a8TlaFEFp12mfnJ2oxnmtri7BJ74DD+fgffj5nmy4c2FLwaiNgbKztcxsW+JVY+4+/9LIQxv8cipTeMuNiiP46DlMwNl26RVMy6vGQ4PaTDxaVd8ygOlLe87ONwwzWxVmUiaRjBLtRZVFiAdzM5Utun9A2ujVBgP2egB35lRao+k56krcx6w53HDRw49qjKSJGbtuaHkI3I1C2PXh4LsdPH5GrIMADFXO4VdZCpmQZhsAaRxHAklAWWQ5VFje+yUOJhwO+0gdSFuU3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=te2Eu0q5BWGrhHL/LWGAvbwYJB5zeA7tVLv/8x4nflg=; b=kJQIXVgbQPhykXGOB0LzIupgoFF3NAuPyRMTKk28cXwXrHwnXQM1Rc0G3OpMko6J4JoI3zJ29V7k1j9BIY8FSxM/irAL2/IiBGG/68nLgolXMWcsc0dQfNAaye15xWiy+/bSQpLS3SWuabNnDxTNOwDDKeAmEaSGmxXtPxdAsBpJSsfbhQggkCTWiOBK4dDfpGa3CbvtDZZ93d0Rtn6F6quOKU9GLEJkchJAdCOcGsG49sv8+Yy6fTIw7OcP3RC6tB4DD1wMtkZjp3Sg0dD4fRaVKR2vsTxmF+dbJWxZP56ZmqsSiZxsOlRAU2ZzSgVXVN2UNh0PgCuGYXGsMarxAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=te2Eu0q5BWGrhHL/LWGAvbwYJB5zeA7tVLv/8x4nflg=; b=OlIeY2VtgxXr27kZTih79qRSxWKapLumebisiWaTq56UwFnuwNcUal30/c32B/FcFw1kD7buGtpDm6IUL08KyHDzWZXlrdxicD7AjMgpzTdOiyfWAvKp5yRrAGCKlwPlR58uuESzzK/HlNifCvK35PBreFIW+g2MqfZ6Qtpm92o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <81b7b4ab-1765-67dc-0d0e-8fcf8a8f41d1@amd.com> Date: Fri, 14 Apr 2023 11:28:23 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20230411191636.26926-1-vikram.garhwal@amd.com> <20230411191636.26926-3-vikram.garhwal@amd.com> <869d014a-d325-6592-d51e-e3638ba04076@xen.org> <1198aebe-caa7-fefe-8c09-db7a14ec7c34@xen.org> From: Vikram Garhwal In-Reply-To: <1198aebe-caa7-fefe-8c09-db7a14ec7c34@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR06CA0063.namprd06.prod.outlook.com (2603:10b6:a03:14b::40) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|IA1PR12MB7517:EE_ X-MS-Office365-Filtering-Correlation-Id: be032754-80f5-49ee-529e-08db3d16093f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: niYEMMWwMNa4YMkGG49TFKV0lyedNo771oL1UoFmVm9YtYITpV9IZl/5YzVr1x+0TaKx4H0AFFDVIhscSmaZ5mMqBC4s+2hVvaMrY1k2zRfWVARrxItks9KfPJVqMBbkWFhdT4Nv3FcUgGfCch53L9csgioHT68LCgZ1h02d1yOO1AnxZPdgVzsOXbK0r+u72mcrDZcDF2mWeVOxWDKvSkQPSZslsGHC0wM6ZDHWVEZ5D9Not6RJU15HQSPtff+0rHFBb1DgLDbNEgsnJ6OX+gLKIsmRNaVvjX7sFANNRMKBZaZttMa1K3muGf4d8OzG7MDlDlLr38H50CllNFB7ZxNn0v91IZq3oUekoiwNVQ9AIaT9neJ1qDMpYAY5MF8OZI6tSDQQwpqWwX1L88iHxBdsaUQ51aue08rXnerrPoXzEdelfov2ntpyAIWqZZn923DbovpP94GpXcQlqACVOBBY5+88jHJzB8Y/issUuMwS9N6mOzMDZiE2vPaM1fRAUEBQgnYzcABrzJZLySCtJSLDnsWrjAsVMkjY2oU1EpcAvC5O5B+zToYyJvjQJF+NrwYzKM4Xz5hZaS/fbT2Virk1LY6DzhLrXcn0yFzzb0OcVabmnJmMIPFb3ezg7v6cEOsOg9xpsnhjzMTHSTkJRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199021)(6666004)(5660300002)(6486002)(66556008)(2906002)(66476007)(36756003)(4326008)(66946007)(44832011)(86362001)(38100700002)(41300700001)(8676002)(316002)(8936002)(31696002)(478600001)(53546011)(26005)(6512007)(6506007)(31686004)(2616005)(186003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmIwVnVFbjdxTXJISmNOYlJXVld6Tnd0Z1VOaTNjV0hkOFJNRHdyOTZUcUJC?= =?utf-8?B?RGQ4dW5UUXdwMWVhSUFCTmkxNGRTOGJjTnNaMkhGNDM3dHJDOFlPMk9YbVIx?= =?utf-8?B?Qm1ldVQwTFJKeEplbVl3bUFpcnN5b0M5Z2NsMXBCeU9aT3VBcVdEVVJhaWRV?= =?utf-8?B?N1g2QTJnNmx0d1dRcnhHay8yMVF6V1dLUXk4bjcyQkZvSWozR1UwMlNWb0xC?= =?utf-8?B?RnltR1V0c0E1WXNvVmVOcUpoS2JzQUVyVHUxa2hqNG9PejNhZmwzNXRyNjdD?= =?utf-8?B?NFlyY3djOWY3eDUwQTVtVUUyNkoyajFaRUJTcUowT1F6T1BCZ3dWRkJMQk41?= =?utf-8?B?Um40YW5LeldWbHd0ZkVRZHdCSVg5SGZhRDU5TWx0YjRrd1VBT1NYZjNFZTVy?= =?utf-8?B?SERWMTdselp0UnErNGJ5cDdXNzNUeXAwNjlZbmQ4L0hMUWtkUGZpOTIxVmMx?= =?utf-8?B?VGIvcDhzaXZHd2ZURUljM1AwYnh6MmlwNUlqVnZMYXpQcGNHcDdUT3psRy92?= =?utf-8?B?RkJjVFUrZnlpMnJMOHY4Ni9aR1ZXQUMyZStINzh1UmsxRFRLVW1PNlNRam9n?= =?utf-8?B?dXB6N0RTRlNHZnQ0eWRuZzBackxpMjgwdU5DWHgySzhEc2pNT21qNVByV2dO?= =?utf-8?B?ZnlyZUdINlpHLzRGNlhsUHRmUG1FTWhKS05VaVBKUkFBblBCNEU2MmJZSmNn?= =?utf-8?B?ZEcrOEw3aE16YVQxLy9XTVNlYXpqMHRydHF2ZGNtdFJWeVRiQUZZUXFuSk5p?= =?utf-8?B?ZUh5UWxWNDE3YTViMGVhSXF3UUs5VUNTY210R1cvQmxvTFY1eDFOeTFMVGY4?= =?utf-8?B?VTZRVTBMVThRTXJqWVVXeUk3YjFYbWxxWFlkdllwTTVwV3FEMnJHajFBNTZO?= =?utf-8?B?NW1pNWdtcVRzSWliZ2g3RWJGZW1lV044UHlQOFFTQVVjREt4eEozUEhaQzVp?= =?utf-8?B?Rk5IZmRhS1ZPbkt5YlNKR1hIZnBSbTNjYzB4UEh6VUozUkRMRW5ZRlJ5emY0?= =?utf-8?B?U3BVYzhIcnNsRlZoUW1LVEtuNlJIaTBuK2QzdVR0TnBkSGVPM3g0NHZiN0ZP?= =?utf-8?B?U1hiRWNpNVIzaXp4MW5jM01DM0s2Ymdudk1lN0JiNlYzbzZKMVF1U0RiKy9w?= =?utf-8?B?L0xtMmozOTVubEwzZUdKcDU5RWsybTRHck1hSU5odnhCRWd2UjdneURiNzhp?= =?utf-8?B?bnBBS3FFUVd0aDVNT0hqdUVFeG5aTDN4VkdjYmNyb0YycUhWSktYaUdHRkpW?= =?utf-8?B?S2s4OG52aWxQZTZpVlZHeTJlaWRlSjVrTExhaTVTUDVLTVVnZktmTlkxcXow?= =?utf-8?B?cEpwaHhiY0ZPb0VLblZCbUxETndwM2Z6VS9CZmR5TEtCYlVhV01kNi9IZUda?= =?utf-8?B?NXd0cUhoVHp5bUdZYXRBbE55T3Z0U2pscjJlSmFJWlVaVE90Z2lkY0gyczRY?= =?utf-8?B?aERiWncyaFRtQ2laWVFORTY2M2ErOTRLclBHMjY1VHdWWFB0eTJOTTB1WEVB?= =?utf-8?B?R01RelpPSG1zeW8zQnpvSDhTRXIwdHdVejl6dFhZaVJzcXlLYmZWWm10NG9V?= =?utf-8?B?YU42aW1KYUhmQjFYU283SnlyRDA2Q3hRL2NGb0xyWlBVNnhGaWVvd1hCSTQ3?= =?utf-8?B?N3NPR3gwOHB6cnV6R2l3K21aaFpCNU55NlhFSkhkNksrd2ZTcnhzNTVmejNO?= =?utf-8?B?Y1BicEo1OGUrWi9pTk1tTzVXZ3dNQzBxd2JXbHVidXdNZnMyRE5oQlFwV3FG?= =?utf-8?B?QXZROFk2ei96MXQwQnloKzBTTUdsZFNmMTd5VkdIa0VpbnkvQWZXQktJQmkw?= =?utf-8?B?UnVsMkdaS1lOaTU2Tm5rOTRJV1BodWJUZnNIUkptNm1vdXdvY3RWbEdCVllw?= =?utf-8?B?NTlCZy8vZ0IxeWgya0J3Mmc1UnRaSVhRaGw5bnQrMVBpNjhqV0lFUkYwcjhT?= =?utf-8?B?d3RMVmJYbzBLVElxZlN4ZjFhL0FOOGRraWxkd0IvQ1FxODNpQW9SQjMwZGVC?= =?utf-8?B?Ri9hN0ZCazA4aWhMeCtLMjAzOGhJRkVpSHA3OTFubk9maE4rWnBJVy85S0p1?= =?utf-8?B?Tm5IQ2ZjMnBIVGFrRXlkSlZHS1JNbFdWbzBVcGY5VnZrYmtrNWQvSi9iTnNw?= =?utf-8?Q?Omc0PZEMWvIFVrghesSeiEW2V?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: be032754-80f5-49ee-529e-08db3d16093f X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 18:28:25.8283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 60ZsMNeywH+AHE4n8fRUH/paPNxwMIN4g1j9f1vk7d7U1G/t01MmGIaARGMynNBcGWJeaBrA1vroMME/xySyYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7517 Hi, On 4/14/23 11:09 AM, Julien Grall wrote: > Hi, > > On 14/04/2023 18:51, Vikram Garhwal wrote: >> On 4/13/23 3:03 AM, Julien Grall wrote: >>> Hi, >>> >>> On 11/04/2023 20:16, Vikram Garhwal wrote: >>>> Following changes are done to __unflatten_device_tree(): >>>>      1. __unflatten_device_tree() is renamed to >>>> unflatten_device_tree(). >>>>      2. Remove static function type. >>>>      3. Add handling of memory allocation. This will be useful in >>>> dynamic node >>>>          programming when we unflatten the dt during runtime memory >>>> allocation >>>>          can fail. >>>> >>>> Signed-off-by: Vikram Garhwal >>>> --- >>>>   xen/common/device_tree.c      | 10 ++++++---- >>>>   xen/include/xen/device_tree.h |  5 +++++ >>>>   2 files changed, 11 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >>>> index aed38ff63c..bf847b2584 100644 >>>> --- a/xen/common/device_tree.c >>>> +++ b/xen/common/device_tree.c >>>> @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const >>>> void *fdt, >>>>   } >>>>     /** >>>> - * __unflatten_device_tree - create tree of device_nodes from flat >>>> blob >>>> + * unflatten_device_tree - create tree of device_nodes from flat blob >>>>    * >>>>    * unflattens a device-tree, creating the >>>>    * tree of struct device_node. It also fills the "name" and "type" >>>> @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const >>>> void *fdt, >>>>    * @fdt: The fdt to expand >>>>    * @mynodes: The device_node tree created by the call >>>>    */ >>>> -static void __unflatten_device_tree(const void *fdt, >>>> -                                    struct dt_device_node **mynodes) >>>> +void unflatten_device_tree(const void *fdt, struct dt_device_node >>>> **mynodes) >>>>   { >>>>       unsigned long start, mem, size; >>>>       struct dt_device_node **allnextp = mynodes; >>>> @@ -2079,6 +2078,9 @@ static void __unflatten_device_tree(const >>>> void *fdt, >>>>       /* Allocate memory for the expanded device tree */ >>>>       mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct >>>> dt_device_node)); >>>>   +    if ( !mem ) >>>> +        panic("Cannot allocate memory for unflatten device tree\n"); >>> >>> After your series, unflatten_device_tree() will be called after >>> boot, so we should not unconditionally called panic(). Instead, >>> unflatten_device_tree() should return an error and let the caller >>> decide what to do. >> Looks like i misunderstood v4 comments. Will change it to propagate >> an error in case of failure here to the handle_add_overlay_nodes() >> caller and that will further forward to error to toolstack. >>> >>> I suggest to read misc/xen-error-handling.txt to understand when to >>> use panic()/BUG() & co. For... >>> >>> >>>> + >>>>       ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); >>>>         dt_dprintk("  unflattening %lx...\n", mem); >>>> @@ -2179,7 +2181,7 @@ dt_find_interrupt_controller(const struct >>>> dt_device_match *matches) >>>>     void __init dt_unflatten_host_device_tree(void) >>>>   { >>>> -    __unflatten_device_tree(device_tree_flattened, &dt_host); >>>> +    unflatten_device_tree(device_tree_flattened, &dt_host); >>> >>> ... this caller this should be a panic() (this is OK here because it >>> is boot code). >>> >>> But for your new caller, you should properly report the error back >>> the toolstack. >> Understood, will change it in next version. >>> >>> Also, unflatten_dt_node() (called by __unflatten_device_tree()) >>> seems to have some failure cases. Can you explain why they are not >>> properly propagated in your case? Are you trusting the device-tree >>> to always be valid? >> for dynamic_programming, while adding node(check patch: [XEN][PATCH >> v5 14/17] xen/arm: Implement device tree node addition >> functionalities), fdt_overlay_apply() is called before >> unflatten_device_tree() is called. fdt_overlay_apply() will catch the >> invalid device-tree overlay nodes. > > I agree that in theory fdt_overlay_apply() will catch invalid > device-tree. However, neither of the functions are exempts of bugs and > there is no code shared between the two (they are not even coming from > the same project). > > So we could end up in a situation where fdt_overlay_apply() works but > not unflatten_device_tree(). Therefore, I would rather prefer if the > latter function properly handle any errors. > > Note that unflatten_dt_node() already have check the validity of the > DT and will return. We just need to make sure they are treated as > error rather than been ignored. Thanks for explanation. Will add error handling for unflatten_dt_node() and unflatten_device_tree() for failures. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:33:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:33:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521209.809622 (Exim 4.92) (envelope-from ) id 1pnOEz-0007KT-0o; Fri, 14 Apr 2023 18:33:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521209.809622; Fri, 14 Apr 2023 18:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOEy-0007KM-U9; Fri, 14 Apr 2023 18:33:44 +0000 Received: by outflank-mailman (input) for mailman id 521209; Fri, 14 Apr 2023 18:33:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOEx-0007KE-Ir for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:33:43 +0000 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [2607:f8b0:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1898835-daf2-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 20:33:42 +0200 (CEST) Received: by mail-ot1-x330.google.com with SMTP id 39-20020a9d04aa000000b006a1370e214aso7460524otm.11 for ; Fri, 14 Apr 2023 11:33:42 -0700 (PDT) Received: from [192.168.104.105] (c-73-32-128-233.hsd1.tx.comcast.net. [73.32.128.233]) by smtp.gmail.com with ESMTPSA id v16-20020a05683011d000b0069457b86060sm2001827otq.47.2023.04.14.11.33.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 11:33:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1898835-daf2-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681497221; x=1684089221; h=mime-version:user-agent:content-transfer-encoding:date:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=l8ln56Hzz0BqSpD/wYa3XGMyMNJG6KUwksNpEl82aL4=; b=GZ09WK/rKhSZjCLyzpEbp0gMKunpkh56PSXJmInmZIoWGCQzd7Y3XeUN4mMTHNRK6h YIs802CWOA+zKs8XC/TXtS2a7wgMGS1gdabSJNhwOLVDFl9Mc7Ei6QnOUv2/l7+F+4b8 Rnt8H5CBOAri3nIbSMigDK3BrcBAdxypPRxnjJvprvgRPVcUXWP8U53idKYEir0tOrBD 044e3Botely9gnqj5Jr4NLDdTVHnFHBHL+BizwOsjRsPVSeIlOuCmbOF+Ahl3xu7SH6V BrbTB0y4nYYxcDGEEF3NY5yVFHBJQq8FbW4IOaavJdFNkNpW5Pizj/1YsuPFV0lF1OMU ow/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681497221; x=1684089221; h=mime-version:user-agent:content-transfer-encoding:date:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l8ln56Hzz0BqSpD/wYa3XGMyMNJG6KUwksNpEl82aL4=; b=FRgTI/vasMx2Y7UFd9LLvj9dxY5WES/kKI+yXlAn5GkqlqLg99UrxEdFreObcaLrBn 6M+gUgYDDk1Zce70CPVVGmb80mSq7iLBPD2LektMNeJJ411HfHwVGLBma3ogAikS/LH5 rogTQ7o8yhLDLW+NvO7b+ORopo8gfqGCAqcJcPQ7dIE2rpM2lUjZhrbYMQhwtQ8widII R3LuOLdrYF5zCz+0k9ztTydajQHQ9kCzJ3COI3gwZuQI6yLKuKhbtW9wgm87iQX0MFiP 9BsQTfpgVSv28qDkLFN5cEYnRj9CP7q6hwrnstVDWPOWgb7VG8t+hBwk8gQJX/zzco0k N41g== X-Gm-Message-State: AAQBX9dU+shAnFQf1AbISr6O0j1aFYZQ/C6RU1B8HvGW7VCW/0K7I9P6 U7e2o+/H8uf50DLFe0X93GDzGSqp1jc= X-Google-Smtp-Source: AKy350ajpP8J7z63r+4DlL5zbJcOQK7g7+FL7nR31UiQ7mgsXV8Dj7fqnM8zV2muaCO0Mjzgh54eHw== X-Received: by 2002:a9d:6508:0:b0:68b:d61c:168f with SMTP id i8-20020a9d6508000000b0068bd61c168fmr2740829otl.11.1681497221315; Fri, 14 Apr 2023 11:33:41 -0700 (PDT) Message-ID: <56d02462173267603d7af1503d2e67cb88f2ad5a.camel@gmail.com> Subject: x86 instruction emulation backstory? From: Alex Olson To: xen-devel@lists.xenproject.org Date: Fri, 14 Apr 2023 13:33:39 -0500 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 I've been digging into VMX internals and I see why MMIO emulation pretty mu= ch requires x86 instruction emulation. Even the Linux KVM code borrowed Xen's emulation... Thus, I'm trying to understand Xen's x86 emulation implementation... How was it developed? (x86 instruction handling is incredibly complex!)=20 Was it originally part of a general purpose x86 emulator? =20 It looks like it implements more instructions than just ones that can acces= s memory, such as "AAM"? (Why is this)? Thanks -Alex From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:58:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:58:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521214.809642 (Exim 4.92) (envelope-from ) id 1pnOcF-0001eI-A2; Fri, 14 Apr 2023 18:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521214.809642; Fri, 14 Apr 2023 18:57:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOcF-0001eB-6u; Fri, 14 Apr 2023 18:57:47 +0000 Received: by outflank-mailman (input) for mailman id 521214; Fri, 14 Apr 2023 18:57:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOcD-0001O1-SR for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:57:45 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20601.outbound.protection.outlook.com [2a01:111:f400:fe59::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d0f641f-daf6-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 20:57:45 +0200 (CEST) Received: from CYZPR17CA0005.namprd17.prod.outlook.com (2603:10b6:930:8c::21) by SA1PR12MB8599.namprd12.prod.outlook.com (2603:10b6:806:254::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Fri, 14 Apr 2023 18:57:42 +0000 Received: from CY4PEPF0000C977.namprd02.prod.outlook.com (2603:10b6:930:8c:cafe::5) by CYZPR17CA0005.outlook.office365.com (2603:10b6:930:8c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 18:57:42 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000C977.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Fri, 14 Apr 2023 18:57:41 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:57:40 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 14 Apr 2023 13:57:39 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d0f641f-daf6-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVHNIhQawx2IMLPEDwhhvyQ0AskgqeAeqibmTkNk0c73CcLlidKXboAqFzuqLznrR4S6rD0D11mXho7iarj6vuSLsQhq9QAfwW0PjzJD6RO3Y3P9MQIRtAY3R6CwmXXtS0ybmAdUilByhfQOsDebq6YxwiCCObFXAqBH5A7hpVLsq2HFZEIUqvs04DvAwmiyHszIh/CyAnjcElHtdf8swOmdfaFKBM1I+V83Lgz/p22QY5GRhHKf6GvdXpzNDkiJpVb/iEb4CLoeb+fi08MPvhigVDe4NhXt9thD+DI7CmLaOQLiLzfK4NWBZDUzfLA6tqwo2yPG0wPJqT4Jz6l4eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z33OHiDZlWIHfUqu2WZ+dteJoaqpdcUN2xGgnP65iNE=; b=A3mE3zhgQQMTKZGlbzpiW3sBgba8XcUINhrq7m92V9Fvm+vTk0YrqswIrPi46ARpnEccJP8jIf2FGj/Qe2CEuVb92hyYD25GykGld5t1IREpXCS+AF7Yz86/tRmU89+LeltefTYNlU4E/JaPK7WRL3dFkDTvPbw4kQ5HICgydxOmSwGPV2Duhbffk8uybx5H1HIuNzK6EpI4SLgE1DXYtg2+wHisFd2cmCspWiAn/6qpJwj0XwgrWd8NYD3osLpWOpzDyDttMsbHMzTAeIFUksUISCc0vLmdXGO9WAXy0rANna9CRYDK3MJBwITEU2Jt7wOIQ8FJKTTXqMLZb0EX0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z33OHiDZlWIHfUqu2WZ+dteJoaqpdcUN2xGgnP65iNE=; b=kJD5WWKbFY8zyBHg9v8QvIhNtbyngzYa/AZOTwccVLfv3rBFrloYesqyh8e/99Oe7YPAU3Bld8/t3jsX/bLT8ZlJWI92xZuYfN/eIx4L6DJBqBWQBuwV73tcgYNQZ2BKKIg+P5/3KUO08Dahkz/qe2OqgH//Dgbm+upD0URVCiM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper Subject: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline Date: Fri, 14 Apr 2023 14:57:12 -0400 Message-ID: <20230414185714.292881-2-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230414185714.292881-1-stewart.hildebrand@amd.com> References: <20230414185714.292881-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C977:EE_|SA1PR12MB8599:EE_ X-MS-Office365-Filtering-Correlation-Id: 8598bab1-0dbd-4004-299e-08db3d1a1fca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wA+Jg7uRF9g5PnFKZUnpgcCiILrMoIUHeTMMQCkSlKSHyW9lhOwsiLwAtOekh4nzTNKKCqGEqvoHfXv65CdFXG6yx14/rmuI7QPvpEIqSgh2+My53Z2MogVu+49VHJx05bxf2faVlevcUbqOgCz1Xzgu2937PWfDWisOtKVeWCabiCrwKgSFrTyn/Ja4gpc6QFODy8qiEBFVhL2EF5khFrLvv2cBjRbSxgLOqhEosM/ekNhhNpP8UAoQ9HowE4AXZ1fo08n9y2/dFYtCfK3+E59zDcT2hDZ1pzAfjDCjHqUUJUHdTXQK6B92Ue5YnDJyNFQOu+jZRO/NSmIAJEEWgKRSCWnHNxKNwMMvDednyfZDr8v2VgjUD+qWd1mtNQ1gTthiRWpzHKE2BfG9u6BrfypnSaUGXflxnyntOOKvBmjBmJB2jVQ5YO1O39tB5h7MDQ/HV1J1s+/T1ge6cMxRLy2MRaN/OtkuWLerdyZkod0dzoWlh+MulvKCuA8R7D86UkTZbA/rj7gUrXZEIhMJUiXeMbUzoKcjDFun6z7me6Ea7adaHNXNcNqwj/p0cxNh0da7RzDQ7MAb289Fu4aKPXLQaoNCaKluudpWY1RujglJHthcByiJLry/b/hNmy7Kl0RqvLtuqC93ZLkq2+htPqbvTgnNdhofWFmwQDkGut+8sfQqhushKpfSOhcXR0a5ZRIJgK/wFBgEmGioMOKCZgqd4DmgBkQU+sLZOKyyddg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199021)(46966006)(40470700004)(36840700001)(2906002)(70206006)(70586007)(426003)(336012)(82310400005)(5660300002)(44832011)(36756003)(8676002)(40460700003)(8936002)(41300700001)(316002)(6916009)(4326008)(40480700001)(478600001)(54906003)(6666004)(26005)(81166007)(82740400003)(2616005)(1076003)(83380400001)(356005)(47076005)(36860700001)(86362001)(186003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 18:57:41.3749 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8598bab1-0dbd-4004-299e-08db3d1a1fca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C977.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8599 When building the hypervisor with -Og, we run into a __bad_cmpxchg link error: aarch64-none-linux-gnu-ld: prelink.o: in function `__int_cmpxchg': .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference to `__bad_cmpxchg' aarch64-none-linux-gnu-ld: .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference to `__bad_cmpxchg' aarch64-none-linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bad_cmpxchg' isn't defined aarch64-none-linux-gnu-ld: final link failed: bad value This is due to the function __guest_cmpxchg not being inlined in the -Og build with gcc 12. Fix this by marking __guest_cmpxchg always_inline. Signed-off-by: Stewart Hildebrand Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:58:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521213.809631 (Exim 4.92) (envelope-from ) id 1pnOc9-0001OE-Ty; Fri, 14 Apr 2023 18:57:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521213.809631; Fri, 14 Apr 2023 18:57:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOc9-0001O7-RI; Fri, 14 Apr 2023 18:57:41 +0000 Received: by outflank-mailman (input) for mailman id 521213; Fri, 14 Apr 2023 18:57:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOc8-0001O1-Rs for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:57:40 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20601.outbound.protection.outlook.com [2a01:111:f400:7ea9::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3968bfd1-daf6-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 20:57:39 +0200 (CEST) Received: from CY8PR19CA0012.namprd19.prod.outlook.com (2603:10b6:930:44::29) by BN9PR12MB5178.namprd12.prod.outlook.com (2603:10b6:408:11b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 18:57:35 +0000 Received: from CY4PEPF0000C976.namprd02.prod.outlook.com (2603:10b6:930:44:cafe::23) by CY8PR19CA0012.outlook.office365.com (2603:10b6:930:44::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 18:57:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000C976.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Fri, 14 Apr 2023 18:57:34 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:57:34 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 14 Apr 2023 13:57:32 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3968bfd1-daf6-11ed-b21e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jo4FIzpxPgNZ1XanipsY1GEBnOSLUWDAEhh97vvlXlmbf1j5WK7XmyMtqzEmueEid1dPUG00no7Pa7uOt9ABqrxZqvwVsoIUYdAxuH1oURdX8DlVDgVlBCZzUHm857cBef7Rx3ePy2b/QbhidfdcPFJvJ1VeFEimmoM9QAhYugMN0X7Gx//UlP0cFYIWgqAkDTSX570UpDvNBx+5zqPThsVMG+ZsoKX/mjq5otMkG2UUCkDVny0TMvDFlqLtGyHeOwo4AyJK0Nwp5WdSSQ7W72WoyP7i7Oqs7poznMhcy7lC49ThUsXH6NXEbiD/aomVDhKjN30UEjMQO7v5CuvdHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9aUhBbT3JP8LmVuEIaDIRl2xT4DCvnOTPAPCN1AMiXg=; b=NfXLuFZlxzDgTjaMQPeu7y1iSi3ARY9jKvZgKwW/p6JzGKpYg9Al0oSGOsvqOtX9GNqgLCY2X+/rNalBTTyh+/bvd3APEHVbtlXzcoSWc10QrW3cZgwfgthExHMsjc2LFdsTcCD3p176tVqUUKr0g2yxWgZQ/qOiuWf2J2tB52d+MM6FZ6PwR7smgec8brM0R/WG2z616euTuCSW8y+aGA8Gz8GJK966RbUk7dsP4sofS/kOqepyw6uq+HZTzqI/WGYg35a5Wt1y3Sp6f/C5yrLOOiEPTeFTCNqvgngFFey3niUoulb4gRNXrYd7TEWHO6xzCgEmgZTOsRpZ30k/Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9aUhBbT3JP8LmVuEIaDIRl2xT4DCvnOTPAPCN1AMiXg=; b=FGtNZlN6MHo5VXCjo1vawLFCpM6C39KNjdC96AjHYGuqX5T7Dz0wyBru1QKRe3FnlPGmTOZfrRuJ2RPGtCsZL0YPyo1KF5J5Jn4b6e8gaM7je1mjQMYYaRbPnkbZKVneA7kTsYaAD+7CvXpOyxxzYYRLwM3hr83KLlm0GGcVCTM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper Subject: [PATCH 0/3] xen/arm: fix build errors with -Og Date: Fri, 14 Apr 2023 14:57:11 -0400 Message-ID: <20230414185714.292881-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C976:EE_|BN9PR12MB5178:EE_ X-MS-Office365-Filtering-Correlation-Id: e570a07e-02ef-42c7-deef-08db3d1a1bec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o+OxKV0EcSK6N1GOgBSsp2B2Rk0UtQA+Gnsaw2RC32GktQXVo5gt3kYXcFiZIC+vQJzPI1EPUNpCemnlVwQYA+HGygb9tPqGy8a06pT+jP3vvzvdovD1IS5Zz4EYsOG4aJ7lWXidnRrJ0N9Su8mw8foFmLg5yxb8VWCpSQDt1Nhs231FZJgsmPRi4yoZ5a5BeugAAm7EShsvGbh7OE7ef/XbNtNfnjRJ8FrkBDxJ2UR2pu2qoCnQUrQpuc3BG7nAAyeHBo6VOAOprzr+ahK9C/sWmAjHBDfpGW+MjWBNlWhto61mCTt8AEMKkAIizUq6zt19SbK+2dcr7tMUMS/eEcLZVtJtQm2HEeKjbw3nbuJgL6Ph2ix3GNRXyM7mXypa03R8snW1AwFVX9pfJIJzhbo8kPl9gmV579WrfzaboqggG95mDuW2hiRxIu0JEIPq8WcpMiXU8CDf36GF4Wm1TVmKCvTZx5MxrkDh99hHKHYIfB2nH52CPjvpwJWrqNTgcsQHbOyIRZMb3C02zm09vBKdFG9pbeuP4BPvWMkV9Q8y3rF8fbvY9wN9tI8Vo3OT5lDpiOFExNp/Xy2tm0PrhLUYL2gbI1ntAD6ZDKLRgANKk3VoAPLdcFVyvAPMwj8xOEvAAcw3+cp0MySy4mb+cl7Q6woKFaeJZ9wR+AdA/2XGta/QBpz86EI7JLYVCZ8tzs1lmXWPqUd+Y+7V8xYvAA146ljG9uh2j6tUsLIFEvY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(376002)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(6666004)(5660300002)(40460700003)(4744005)(6916009)(2906002)(36756003)(4326008)(70586007)(70206006)(44832011)(86362001)(81166007)(41300700001)(82310400005)(356005)(8676002)(316002)(8936002)(82740400003)(478600001)(40480700001)(54906003)(26005)(1076003)(336012)(426003)(36860700001)(2616005)(47076005)(186003)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 18:57:34.8915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e570a07e-02ef-42c7-deef-08db3d1a1bec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C976.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5178 This is a collection of fixes needed to build the hypervisor with -Og for arm64. I build-tested this with the following command: make -j $(nproc) \ EXTRA_CFLAGS_XEN_CORE="-Og" \ XEN_TARGET_ARCH=arm64 \ CROSS_COMPILE=aarch64-none-linux-gnu- \ dist-xen Stewart Hildebrand (3): xen/arm: mark __guest_cmpxchg always_inline xen/efi: fix unitialized use warning xen/arm: fix unitialized use warning xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/include/asm/guest_atomics.h | 10 +++++----- xen/common/efi/boot.c | 9 +++++++++ 3 files changed, 15 insertions(+), 6 deletions(-) -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:58:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:58:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521215.809652 (Exim 4.92) (envelope-from ) id 1pnOcP-00020B-IA; Fri, 14 Apr 2023 18:57:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521215.809652; Fri, 14 Apr 2023 18:57:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOcP-000204-F2; Fri, 14 Apr 2023 18:57:57 +0000 Received: by outflank-mailman (input) for mailman id 521215; Fri, 14 Apr 2023 18:57:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOcO-0001yf-7e for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:57:56 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20627.outbound.protection.outlook.com [2a01:111:f400:7e88::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4297d594-daf6-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 20:57:54 +0200 (CEST) Received: from MW4PR04CA0259.namprd04.prod.outlook.com (2603:10b6:303:88::24) by CH3PR12MB8911.namprd12.prod.outlook.com (2603:10b6:610:169::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Fri, 14 Apr 2023 18:57:46 +0000 Received: from CO1NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:303:88:cafe::b3) by MW4PR04CA0259.outlook.office365.com (2603:10b6:303:88::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 18:57:45 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT004.mail.protection.outlook.com (10.13.175.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.33 via Frontend Transport; Fri, 14 Apr 2023 18:57:44 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:57:44 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:57:43 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 14 Apr 2023 13:57:42 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4297d594-daf6-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aPo3Zkau8v5cZvvTDRT5ZDoJxjWnp46Q/ftxQaGfnfgX64fe8jZa27ISThGxZfFgj2URL0unFqPXgPe7IYajX6mvs0y9CnmofDz+hTxT2aMt+8tvYfRIkoMfX84Qaa9mSH0bLdg94thJl1E1KijBSopNwkjP+oEzi2G4MEuHaXvigdpZ3c9lgiB1uTlUJWxoIIB19nxXcMZQ75a4ZXQVNfm3hB09UuYDdjm812tQjxbPqSPVyRNStF6noawt1cdIWCThivdjFAZ0Vqp8dgQc+DnxVlOiEyq/4Vt/mzCb3WGkcWqYsTOqmBkLvfcs9w7bNuhI4RzzWJpYIIvPka0d8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Op4gLrZXr+32HM/wsQS2QIeYqXOraK+iVo5JPJFoRrg=; b=PF0tw8puEGB7V1u4jMXk65LW/+c6OHWy94UvCCX/kPCviDxl6+UFeEWStJniZa2cg8W3tp1zKG7V3uWAoXQK4FZB4G0y7GpFHVfO8PAeiv2epeGIzj61IjIBjsC+07sF7YUkgoE44KPdH11MKPAGqVEYhzrrqAvAUxEcFCMRw+JYqfLYkHxAOitSo5xv5y+NFijKm04vtBHvRtmVMdTt4WZ7344MGK4pFBbQTPimQqDbabxDYqXnwqi8RKQG0HvhpbrZzoTSt7EFu8r+2sDHUREZhXqLQiDnNBttNMaphFyKPO2PXDdkRBa8R044Vh1iOz1RF2YXf/fjTh4z5iwYkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Op4gLrZXr+32HM/wsQS2QIeYqXOraK+iVo5JPJFoRrg=; b=gOhpO5lNnnXIY4VlUUeOUNUG5dcNiTSFrhvVLUPammGnNuJIaK/2xGJJ2jhcc9MlgdxmN0vESeUqlujwSKjQnSB+HT6Mte9fHiY92/XAxhWsxYhy2LkaWBGYZZi/wxdeW95ZQ5h+jgXqangf3IZ/NkRMH2KKThjRYvv8al/fekQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Jan Beulich Subject: [PATCH 2/3] xen/efi: fix unitialized use warning Date: Fri, 14 Apr 2023 14:57:13 -0400 Message-ID: <20230414185714.292881-3-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230414185714.292881-1-stewart.hildebrand@amd.com> References: <20230414185714.292881-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT004:EE_|CH3PR12MB8911:EE_ X-MS-Office365-Filtering-Correlation-Id: 03c6a0c3-bf5c-4b69-daaf-08db3d1a21e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IsgYxjrVVnc8ryVLdw6JHAKd7S4Bus9ldxYr+FiRT9sABsv4fL3jP/JAs7y607JaaF8RAC+OMQInsyCjc3yxawg5JIdVOvx68ziUFBtBgnZEcU2zdEnFEfN3S/EtiCG1T4HB9c9giYrP8OI85HGky6UaIB/jQyM/k7HwyrNeh8DqTxGPgS1syA+Gbd/VnVNTckD7EU3lFK9Syl6dR/GRrmLfrTyTyWIwfM4Zvc9p0tjjQIAIOb0jdjFUe9Ng1iFrHVwHbAf3WrJUISpcFnjWjqKZafZt26WedtrdIz9bo47N8ECM+QHzdmUMWdxLO7/uCF+kEeP3Z2HIxH4Cvwg3391ybFJKYxunJd2XQKEZbYuw/j8KZdL/lgtDkCMF33FNY6RTgMVzjfSwFGLYeGjn8TD9DWo9NWY06Ro/GHPcGNoF/zI+eM1hpx/n6S7OSTCjNbjqU06o1sGqDCwOxH4KFwIWMKWq8Z/+g3//YifkWXMHNu5x6oMH1bcwhX2w/6mGL7dygT+EDgN9hWXrdFdidVWcIQeLePBMQ9limsZuMvPyVslGEi36UlDxGu8M3rVMTzT556B7maMx4POovK+jPhy1X1hIVFmPBKUex48/8OkxgK9018IH6OzN+bniYifijBSLrEZxI003ZZPifRXgcXezB3GSd6ca1mw3ec9WRaPHSxMbrMQjZ/1fA849E0+EvxylOqbKuV81MHLET3fDe3xGGS4fE5c9FjJ4vLjUmRM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(54906003)(2906002)(36756003)(26005)(40460700003)(478600001)(8936002)(356005)(2616005)(966005)(81166007)(47076005)(1076003)(82740400003)(44832011)(83380400001)(186003)(5660300002)(426003)(336012)(86362001)(40480700001)(36860700001)(70206006)(70586007)(4326008)(6916009)(8676002)(82310400005)(316002)(41300700001)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 18:57:44.8872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03c6a0c3-bf5c-4b69-daaf-08db3d1a21e6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8911 When building the hypervisor for arm64 with -Og, we encounter a (false) uninitialized use warning: arch/arm/efi/boot.c: In function ‘efi_start’: arch/arm/efi/boot.c:1468:9: error: ‘argc’ may be used uninitialized [-Werror=maybe-uninitialized] 1468 | efi_arch_handle_cmdline(argc ? *argv : NULL, options, name.s); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/arm/efi/boot.c:1263:21: note: ‘argc’ was declared here 1263 | unsigned int i, argc; | ^~~~ cc1: all warnings being treated as errors Fix this by initializing argc. As a precaution, also initialize argv. Signed-off-by: Stewart Hildebrand --- See previous discussion here https://lists.xenproject.org/archives/html/xen-devel/2022-10/msg00805.html --- xen/common/efi/boot.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index b69c83e354ee..c5850c26af9f 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1344,6 +1344,15 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) if ( !base_video ) efi_console_set_mode(); } + else + { + /* + * Some compilers may emit a false "uninitialized use" warning for argc, + * so initialize argc/argv here to avoid the warning. + */ + argc = 0; + argv = NULL; + } PrintStr(L"Xen " XEN_VERSION_STRING XEN_EXTRAVERSION " (c/s " XEN_CHANGESET ") EFI loader\r\n"); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 18:58:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 18:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521216.809662 (Exim 4.92) (envelope-from ) id 1pnOcQ-0002JA-Qz; Fri, 14 Apr 2023 18:57:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521216.809662; Fri, 14 Apr 2023 18:57:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOcQ-0002Iz-NZ; Fri, 14 Apr 2023 18:57:58 +0000 Received: by outflank-mailman (input) for mailman id 521216; Fri, 14 Apr 2023 18:57:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOcO-0001yf-UQ for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 18:57:56 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061b.outbound.protection.outlook.com [2a01:111:f400:fe5b::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 430e94da-daf6-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 20:57:55 +0200 (CEST) Received: from CY8PR19CA0009.namprd19.prod.outlook.com (2603:10b6:930:44::14) by SA3PR12MB7997.namprd12.prod.outlook.com (2603:10b6:806:307::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Fri, 14 Apr 2023 18:57:52 +0000 Received: from CY4PEPF0000C976.namprd02.prod.outlook.com (2603:10b6:930:44:cafe::b6) by CY8PR19CA0009.outlook.office365.com (2603:10b6:930:44::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 18:57:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000C976.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.27 via Frontend Transport; Fri, 14 Apr 2023 18:57:51 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:57:51 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:57:51 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 14 Apr 2023 13:57:49 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 430e94da-daf6-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0H+L5MXch2APCSZxtNrT9Hh69YGQLyk+gOXnGelPqesd81rc4Z2e47jp+NOUEMMI2MTpPWPVdo08r2ZkO6tLYMNkV1YPQvhfvmeUYlGTCRUryXzK5n3N1pXFhyuh2BUVHS6n/UKpqFmvuj75sqoZl0Z9WR3KCu9rTITjmjtV/SPbHA2UDR6Y6qaliZJIoQopcotNipfEqdgxq8aT4vBn49Vc0o0OmNYBRDH0sCC1bmrcH0Lil78Qs5d5guAsSN9wpq6/xheCZMq+dzGD52N4PhbIV3Os4v1tLw7RL5/R4lhe/kmXrlNGhjhWjLLxuPz1LQGint5Tb/i6Cxz1TM2lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Al+YVBo/rFHAhzjUVn24nt7jKtL9yJFrezw5/WN9ImY=; b=IQ2pGTKD88+zuMPdA4wet/rig4/wySpAUmtkJ7Q5wxyP6pjpmfiBYb++Pb0DR/D0U5d16BdI8fRwCQhCkSNJt4dY2iiCeV/0Mt7fMfj2ZSWzLGoovbWsJU3RBaJ1ffF1tzwxfWO1bhwG4NUF2+Ob0z22AhZi/kSlYS4PJUlyGHZTGa72zIe0hKWp/j6ub013MP5RlPGiONui/59ZqQKpfwjjtZlCOU/zM7fYBQ7vTzexQ/B215AapaPW2C/eCmlTC0Pq0Q5uy1FujaiZhwoEQV88c2h3Z13tyAT+2Cv1+7XU1RPvzb8PX5vVDIIkVM7iy//mXgvDSkpyuKePXdpkJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Al+YVBo/rFHAhzjUVn24nt7jKtL9yJFrezw5/WN9ImY=; b=yYbMAe8et+HIY/oo+xWHW5dJ6PnoJQ7ZB485hAvYwdM1zVkZyAc46Cp9II7PgMKmtxByG/dlivHaZntZNbjbmRytIDtym/t9hxmikLzm86xLRsaAdR4DxsTEn0sGsGFQAWlhD720yDj8boZSj1+hPnZDhgvITRNbgR+doCvxpx8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/3] xen/arm: fix unitialized use warning Date: Fri, 14 Apr 2023 14:57:14 -0400 Message-ID: <20230414185714.292881-4-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230414185714.292881-1-stewart.hildebrand@amd.com> References: <20230414185714.292881-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C976:EE_|SA3PR12MB7997:EE_ X-MS-Office365-Filtering-Correlation-Id: 98d4bc59-f055-4c3c-33af-08db3d1a261d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HwO0CmzPGZaR7SXgWQBDb+ReAr9FYZhx95Uu3HjoATsfs5OwjYwfvxgBL/t8rcYE2GHPFGbT7DXYU0Wv+MAuNbbEGzpU7qjUzkwB/FQn0q5KWBW+g0Nf/t1gpTOvQNaRGAGo6fp85+l3iEaimAG3EzCWGtA9B5mLwN6vM2UoBIvZKHI64YdZhZiSzMRKZXkB4RqpTAo5x/r04w8ZHhU+vPRFts7PxxdA9V1zC1t4u4tHSZHiEI7RICbPTk0w43uiD1kkxjwPyxt5jUQzKtftu1zik3XQZlqsoJ9ToX0nhL14b5/aA5ctZEe0Cyz2qSoBefdXqVj+MTVNTpiNOKEU0+caFZLx3ctCH4vRrXcW5m9UMMSrXoGUO1pdlscHvw8I7SZMRb3m0p1URYM+nTYdMlFqHnCojf1ccy1fvZy5DR9HqquApX5+AQya/OGuQbDvtQuOB/lj0U6ZSLmaxd37KE9Vbk1+19IouDtT95zZZDVWoTa5VyarWXXQktdgaB/XlyBMA4cBJnbx4OvNOeUfBVvYFwvOnGLoThBB7MmiAVAryBhR461x3IdPd+dgT7DcpkCwrxOW/6PD5AgGvqI0HW5B+Mp+/jrYC87C9r6HFC8MnyGv0TEcTL+KVLz38tjXorUPsCH2RMEaKS12Fmkf+dvzFIS61gkLSghn1SUq4HGYpT9EAi+McxMKgq6Q+151ZOk9j3egKE5bInDQKxFNt580w46XB3ln1ARSPf4Ym28= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199021)(36840700001)(46966006)(40470700004)(316002)(82310400005)(81166007)(54906003)(82740400003)(36860700001)(356005)(70206006)(70586007)(8676002)(4326008)(6916009)(86362001)(478600001)(336012)(47076005)(426003)(2616005)(186003)(26005)(41300700001)(36756003)(1076003)(2906002)(83380400001)(40460700003)(44832011)(40480700001)(8936002)(6666004)(5660300002)(966005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 18:57:51.9856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98d4bc59-f055-4c3c-33af-08db3d1a261d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C976.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7997 When building the hypervisor with -Og, we encounter the following error: arch/arm/domain_build.c: In function ‘make_cpus_node’: arch/arm/domain_build.c:2040:12: error: ‘clock_valid’ may be used uninitialized [-Werror=maybe-uninitialized] 2040 | if ( clock_valid ) | ^ arch/arm/domain_build.c:1947:10: note: ‘clock_valid’ was declared here 1947 | bool clock_valid; | ^~~~~~~~~~~ cc1: all warnings being treated as errors Fix it by initializing the variable. Signed-off-by: Stewart Hildebrand --- See previous discussion here https://lists.xenproject.org/archives/html/xen-devel/2022-10/msg00741.html --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4f9d4f9d8867..18b350734a8e 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1944,7 +1944,7 @@ static int __init make_cpus_node(const struct domain *d, void *fdt) /* Placeholder for cpu@ + a 32-bit hexadecimal number + \0 */ char buf[13]; u32 clock_frequency; - bool clock_valid; + bool clock_valid = false; uint64_t mpidr_aff; dt_dprintk("Create cpus node\n"); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 19:16:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 19:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521230.809672 (Exim 4.92) (envelope-from ) id 1pnOtw-0005ZI-Fa; Fri, 14 Apr 2023 19:16:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521230.809672; Fri, 14 Apr 2023 19:16:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOtw-0005ZB-Bv; Fri, 14 Apr 2023 19:16:04 +0000 Received: by outflank-mailman (input) for mailman id 521230; Fri, 14 Apr 2023 19:16:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOtv-0005Z1-LK; Fri, 14 Apr 2023 19:16:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOtv-0003R8-HU; Fri, 14 Apr 2023 19:16:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnOtv-0003eq-0X; Fri, 14 Apr 2023 19:16:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnOtv-0006C6-04; Fri, 14 Apr 2023 19:16:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4SSj41JO/CP7MSjwVROwr+kuXAcYaCKL9xqydvMxrPA=; b=1KfOOnaRU+xAbSp0nd1e9uaMpg +OSF2Q3VdQu5cD19TmJMXNQVf/dXQhf5X840UYdz4ZgF37TbwMuQw0+QpTmGfhcKX7QSzpL6cMJl1 X0vLziPWbhpSsvUwRgpEVqnUatzQ/dgPkJ7RQJYOc38+EHE5tG5M9AU2K3wKduFv9ICY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180258: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=7dbd6f8a27e30fe14adb3d5869097cddf24038d6 X-Osstest-Versions-That: qemuu=9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 From: osstest service owner Date: Fri, 14 Apr 2023 19:16:03 +0000 flight 180258 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180258/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180231 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180231 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180231 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180231 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180231 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180231 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a version targeted for testing: qemuu 7dbd6f8a27e30fe14adb3d5869097cddf24038d6 baseline version: qemuu 9d177b7f87d96d1ed8fd16e222a37bd1ac8a0cd8 Last test of basis 180231 2023-04-13 09:18:05 Z 1 days Testing same since 180251 2023-04-13 20:08:41 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé David Woodhouse Juan Quintela Lukas Straub Peter Maydell Peter Xu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9d177b7f87..7dbd6f8a27 7dbd6f8a27e30fe14adb3d5869097cddf24038d6 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Apr 14 19:55:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 19:55:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521237.809681 (Exim 4.92) (envelope-from ) id 1pnPVh-0001v9-KO; Fri, 14 Apr 2023 19:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521237.809681; Fri, 14 Apr 2023 19:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnPVh-0001v2-H3; Fri, 14 Apr 2023 19:55:05 +0000 Received: by outflank-mailman (input) for mailman id 521237; Fri, 14 Apr 2023 19:55:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnPVg-0001uw-3j for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 19:55:04 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cb03373-dafe-11ed-b21e-6b7b168915f2; Fri, 14 Apr 2023 21:55:01 +0200 (CEST) Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2023 15:54:49 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6975.namprd03.prod.outlook.com (2603:10b6:8:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 19:54:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::a5a1:8cae:d45b:2030%3]) with mapi id 15.20.6277.043; Fri, 14 Apr 2023 19:54:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cb03373-dafe-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681502101; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=HU4y5Ha3VG9lUue6H00gsQGFZ8wM4KASEAKmFuchASc=; b=d9OvXNJjbdg9Yhka0x5yVFTLCBkoQBET8fIQekjZBmUWoC6J+CU3Hrma Y4ymdEVEamStvtcITYhVTmUe8gHxszm+OjU4mjMQ4fwXZrNjtncO5sA5A lA+X+DzzyCRQfbQ/UIbJTWsLNF5AoRY16lKdKD+DHZ8FlI4j6AXOvGJJp k=; X-IronPort-RemoteIP: 104.47.70.101 X-IronPort-MID: 104916228 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:TqSPj6IQUKjQfAtZFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENSgzcCn GBKWm6AOK6CMzD3c4x/ati18RtUvp7RzoQ1TQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4gViPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lWT131 MEWLgxSMEGxm7KrkeqSFeVj05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLlWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHunCdtMTufonhJsqFi6z2ZUMgAqbxz4+KTggHebdYxnF GVBr0LCqoB3riRHVOLVQx25uziFpVgVA95LFOsS5wSEy66S6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pES0cLGtHbylbSwIAuoHnuNtq1kuJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNTNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:/HMDQqFpW808v/ZMpLqE+ceALOsnbusQ8zAXPiFKJCC9F/by/f xG885rtiMc9wxhOk3I9ervBEDiex/hHPxOgbX5VI3KNDUO01HGEGgN1+rfKjTbakjDytI= X-Talos-CUID: =?us-ascii?q?9a23=3AwNmbZGlnvjqL/87RG9nqmtHgFWDXOW+FkE7xHkG?= =?us-ascii?q?+NTk3GY+JGULBoIo7n8U7zg=3D=3D?= X-Talos-MUID: 9a23:nu7dFgi6LBPVdiNToAigP8MpMe5h6eOUFXw31tZf5pCODAleZQ+ipWHi X-IronPort-AV: E=Sophos;i="5.99,197,1677560400"; d="scan'208";a="104916228" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIGLXyDojC4rX/JGQNaeOeLzli6WyYyF3FhiTeAWcOh5pyAp12FD2+bGOurDyp1fnZ56QR5dLCXQbC9i3mtJItA2gKHBpx+1iznwxtGO26MjnxzNcUeqiDd7wUSoySOX9Oir2CDuSM5/CV8emJVbDvXb4lrQxxf4FXS1Qx5z3C5jOHU0gH/dTrTQfjLbXvqISaH8hy5BP8Uqh5muj7yYPVPv7Xgnk1dPwcqD6WOhsko0NpkPVuBZArTfwqRVnd8ouuuplLBr999lj2jY00Bi8GDswKRIOA3AP1mOYFRDLo9OZBv98Pho9B2WrwbDI6lcJRfROK/yHH0uyqJEEuVODw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Quo075gM2E9iTDF5hDm7gU4UCvuyM8dFgPdI8ca8564=; b=k2VQSq5wjJrpykZVlYmBYJSxAK4B6BGlyDqF/wSK+Ep96Y0yeTo1aLMY51Vo5ye5KxSDiLVz2bbEE0YkdfjDmfvyIn7vAPLtFwf+QdcqgwMeg+vAZPzl7SPzlxwmRQWGbMPElu0eoam4I7izcG0ojBTr5TNHjj+BFaRN06Tr6jemvcUHePK6k2YU80Q7iKEOArrBdfiB0NPZMjNYxlhYAAm7SiUA2CuASAqxyoJKmJiHi5bEo4enUj3xAPSApfUB4SjDWSKoq8pzM4KOHFX2y6PFShJF4nkz0F9dHWqnDnOktBZrHu/qDgmktpRpDW0iVc6x9YxRKNYZSLYmi1nbTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Quo075gM2E9iTDF5hDm7gU4UCvuyM8dFgPdI8ca8564=; b=K2/T2v5J8GbWD5iAmReZPawYO827K8DTza2Wc7PKnhpuPYS7t5stIGVeOGw/dntTkwd4vjVjaKaRnNv9yVVBnaayI35ma60xXp4Ag3CnlQxBAX9f3iiAGTFkfId0sXSPz1HRswD2DsH/pQ0X+7b7T0AnWSb28yFG4KFv+TyT22s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <850fc508-356b-3d12-f6c4-ac0a8dc9de8b@citrix.com> Date: Fri, 14 Apr 2023 20:54:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: x86 instruction emulation backstory? Content-Language: en-GB To: Alex Olson , xen-devel@lists.xenproject.org References: <56d02462173267603d7af1503d2e67cb88f2ad5a.camel@gmail.com> From: Andrew Cooper In-Reply-To: <56d02462173267603d7af1503d2e67cb88f2ad5a.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0011.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6975:EE_ X-MS-Office365-Filtering-Correlation-Id: cb196cd2-775c-474a-43f0-08db3d22190b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U95BEPbdCA2ZWHDHGBUG3ueCFfiuNYM5NIrAGlgJJn+86uZtbusn0joQ/fIrLVHrXSRZIBbtCtBOfjh7Ml2ZC83nevWw4DLbwbqXMBibr2DOkUFxEHgsBqT5H+fBYtLFtefVYNGcNOovMxbx2WKP/sNEN/WQiy6KNtzM+K1Mo8CcVDR9PA5dgwVCKip7CJC+FnFv/agB4Vrz6E+UNbinO8BBxbqCDvc5mb3KlR6u0dywYhCJnTioiqSpcS9fBKurL3qCBjJaCQVyBbEKHoQ55MyUYb4eNgh3uEFDSBmM3Z0M5QNEguxst9sOoLPx0aChnL+x05IbLI2Zl/RIm+mhS1zBpQ1Z0mhaEpSENcsZgYVHVJQSIo+xzZmGzwuJmoWSd5HAxlNjd9v6Tb1LCRD05/USIWQOvHcrR4MPdqjZ//smu5Zq/Ils8V7kiks2zBaRvh+yXASWjWSB1+Y/QTt8BW87PvR4elXgepyJVYENGrFZziC2wAnmDvHAK5GRS07m01lAAXkHKmhN6+OF1a5cGm8taVrd3fkDz5EdKuRVmApC+DZdpNS5Vcx8XnvfD+i8Pzy3PEaMEb1RyEqwT8ZrtqiD14jBsR9nDI1uEy3QBsmJaVOvWBC2Azmt3jVTtOhhqLsu5hUqrWZcaB7NwOxOzw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199021)(6666004)(5660300002)(6486002)(966005)(66556008)(2906002)(66476007)(36756003)(66946007)(86362001)(38100700002)(82960400001)(41300700001)(8676002)(316002)(8936002)(31696002)(478600001)(53546011)(26005)(6512007)(6506007)(31686004)(2616005)(186003)(83380400001)(66574015)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjFFMmVpYmpOcFhSUFBaWjcvb1BibWM5TFdmUGFUTVVtdWNGRHlwVitudU5K?= =?utf-8?B?TXpoSWxjLy9Ec09rMUxLc3FyenpDSjFRcm5FUWJMRXUvdm5ERzZkSHNwVCsy?= =?utf-8?B?UXFoam1oM3JYQ0pFOStmSTM3Z1F5WW9FOGdCWUZvdERIa3ZDVkI2M3lRRHhG?= =?utf-8?B?aHA3Qnd5amZvU2JZcWUvMk1LM29pQ05rUFZPQXNjd1RXUjNUOThEYXdiVU9n?= =?utf-8?B?aDQzZ2YwWUorSTFlVlNTMVRVcHpCMmd1YWxTR1ZPazk0dEI3b05JODE5NTlN?= =?utf-8?B?Rk9EV3VSbnduWEZTMFdvSDlBME1pcHB0TU1HMGJyc21IdGtwc0NaeHQ3dE9C?= =?utf-8?B?YjdxcmtUNFc0ME5ub0c3VGVtSks3QWZ5UXdaYnE0NEpYWEw2MTFaeGhrUmsr?= =?utf-8?B?RFFLWS9rY1BDOHFrcEZBSDRVWi85VkNabjl4MTljbGpmcmYyVC9GbjFoNy9q?= =?utf-8?B?cG5NOWtPVFdGOFRnY3I4R3FtSUoxck1JTERtb2FSeXVHUjk3VS9xbmYrcExF?= =?utf-8?B?WUxXclZiNU5RT2JxS21iS2xBY3dlVWJsZ3RNUTJFUDBiaDF4LzZ2azNtcWVW?= =?utf-8?B?eWxkbGJlRjNXL0tRRDJ5eTdId2pSbXdMVnpRY3dvNnhvR3ZzcUwyZ1pJNWJH?= =?utf-8?B?MlpyK3hZVTQyb1dZcit6M3ZhWmdDVnZlY1Z4Uk95YlpTM3FVY3hxRkI1S1gv?= =?utf-8?B?YTVsTS9pWXh5UnVTdnJPN2IwYlRFNzhJSWNWaWRZYjBnaVJEQkxaNU9MWVkx?= =?utf-8?B?OUdDa044ek1hOFZTUVBlYmJxMWllSVZDRytWR200N1RvTEdlc3ZTeTY4K0tZ?= =?utf-8?B?TzhLWXprRlMvUkx2bklsc2FpSzJLR1ZLWitKNlpCTFdmaTBBYU53Tm55cm1t?= =?utf-8?B?Qk1JTnBSdG1BZ0ZaVDZGdmpvZERhYlNLa2dMRHZvZzZ4bFg2ZEFGdHRHbVVK?= =?utf-8?B?cVlkV0NxK2ExNWhlamRQYUNSdGp5UCtlaE00YW5DWjJlSHdNK3d4U2pDTWJu?= =?utf-8?B?ZUx5VXVWZHZOTDJuQWhrcnovUmJRVkVxNG5XUVhoK2JOWHYrejF6enFsMnJY?= =?utf-8?B?NTZBUFVPTGFVa1BBaUtVVVNEWkV1UFFXTU95MFFsRnJSUlhRVkhXZEZXb1NU?= =?utf-8?B?Tm9JeW9GQ1lnSGxTMjBESW9nbHdEWjRWRlAxSVZjN1MvVCs2Nk5QSnZzK1Yw?= =?utf-8?B?MTdtZlVoNjAwMTE1UDhKNmswenlpY2xNOXo5MmNZVVFxeUJqTklhb1IxMXY2?= =?utf-8?B?QlNlM0loSUhVWTFiaUZSRGNnSmphZ21kMWk3bjliUFVGZ0V1d0VlMXNhUFhE?= =?utf-8?B?VkpGRDl4ME5ZaHhDZnZDYTVMSEd5UGU1N3FieVNDSGI3OWFBWnpCRlJ4MDNs?= =?utf-8?B?MFdzN0hhMFdoUHlQZjR5ZUdYMk5oczhwa0hGYksxSXB1cHpOUDNWS0I0QkJ0?= =?utf-8?B?bWZJUnRJVHpZMGFEbHdhMUdBVkhkWW9xTUkwNjlWdWZQamcyallDOGFKR1Ar?= =?utf-8?B?bW1icmhzYjdTaVd5N2N4bzFGeHl2WVltSUhxSEZNWFZ5cjhNL25JQ0JFT3VX?= =?utf-8?B?QitKblVNTm8wWTNqRXZOenRMeU84TElvcE1LZjV4cEczOFJMdVFOei80SXJB?= =?utf-8?B?TlhwNkZzMjNoclR5ZTBHTXZKSEFHWjlMNURkVWtKRWdzNEd0aE9FVkMvck1y?= =?utf-8?B?VGJJdDdrNmNmdmpIUHNJSmxEeHBVMGRMZXVrRW5iRlJMaXF6elJUeXN3NUhY?= =?utf-8?B?aCttRDBhMjdMNlg1WWY3U0VjUzRPTEE5VW1NY21nY1FKRFhSSUsxUFVqaE5V?= =?utf-8?B?eCt2WXFqcTF5cENOUE9UWlowWFZqVDZXUDVLM0ZjWE9hUUdSdW91L3pmdTcy?= =?utf-8?B?MGNPNnhoVFEvZDM1WTJSZGh1UDVmRUlzRWRtR2g0MTd2dkVQeEJWWkhrMWN6?= =?utf-8?B?ZXBYcEI0NnR3ZlRtU1BHblBqbjJrVkdwOE9WYTBkZ0FnNGc5VmlTaVF0UnIx?= =?utf-8?B?SVFqbzVJN2JqcGsybHVKRkdVNHBnYm11Y3BEUHhOMWJJaUl5MkxCd1hDWVRu?= =?utf-8?B?TVpRbUM1enB2cm5FdVdnU21BZG40ZTFuRTdiMWRlcFppaDN3SUJPQjFNblMz?= =?utf-8?B?QVpIYUUxSW9MZDg0ZzJIZnFDSUNuK0p5WVplNXZDQlVlYlJRSVQvWDVDdld6?= =?utf-8?B?cmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Flvv74x3OSVXMvVVIvDGj3SaDc3MIGnQydO3FJITsZvBvLzNvE4xKttAJusOniTtRv97/1nL+oZBY2iK+G8mQXaFGPbSES6mv7OglOAMqgpv4ftEtOYTQhrWscw9o1ElzogbncKD5aCr+XRlNbNbjTwdd1QRbGo7mWCfZ/ZrBSRW+9n5xDDPb1aIeRjNyLyOub3TJDeZ+9TACo8bdZVkbEJXPWRQVDGlivFHJosEHSZz+imMcmwAjLRFV5lcmxPkzRcImqm6rhprRf61lr+ZWbBcGgbih5zJvW+Q9QLD/NJ/ymOXDKMCTQq9WCN4UVV8AGQvL8ngWb1uRGd2LhFR83itZKzmtogEBMnZPO6BcIEAhBEr1glP52zEPV3/DHiEOzKAxytaESsjRDptip0kTQ2ylRf7LAe7uEVtdRdapnwsEuRepHgDop+Hr5XyZU4/9bVaQ4as3jiHon10Y6o8NSvnF1mYtHOQgo3x2N8u7rNrU6njNMUG91Ok0835CllHja501Dk/I3XnlaePJEsc1+2G8dqrF5huiRe6e9Sz74qE2vdBtQF5D2+k5nx88IWlIcy/AEAv1jaLoHTpXDxAGbRu4CWeK/Myo+EeF60GDl6O/neI6XFpgrjAMges9Jx400DWCovr/EMj2iA7qQbKXLpDAY1uEyIRPie4wPV4A0K7mYfkcHWdPmocLicCfyaWHnPUhDqI2rvIqweJpfzdhQDjk6X+taHeb/pbRvsoFTWkqADQtXL/CMF8X/HvaFxifI45lwK3SZRmVrLgRMdovwqatCttWYN1jeymV0h9zfqo2jQla9FQUBN4uXhe4JDN X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb196cd2-775c-474a-43f0-08db3d22190b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 19:54:46.9844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +KfWLcpY+hLCffmSZFIjBa5ZJf1pMrwpc9TsuYbCsPFjWYC1YtPQnNgzVzveSC6z8Zl6uJGpeMhznhroRQAxBw1WNUfwVKxWvco0wrMroRY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6975 On 14/04/2023 7:33 pm, Alex Olson wrote: > I've been digging into VMX internals and I see why MMIO emulation pretty much > requires x86 instruction emulation. Even the Linux KVM code borrowed Xen's > emulation... > > Thus, I'm trying to understand Xen's x86 emulation implementation... > > How was it developed? (x86 instruction handling is incredibly complex!) > > Was it originally part of a general purpose x86 emulator? Xen's emulator (in this form at least) is 18 years old - March 2005 https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=4c5eeec983495e347c6ab3d40a4a70cdbdfce9af and it was written from scratch, but you can even see in the context for x86/traps.c that emulate_privileged_op() predates that.  (We decided to consolidate down to a single instruction decoder/emulator at the point that we were maintaining 4 different ad-hoc ones.) As for development, it's all there in git log if you want to go looking :). > It looks like it implements more instructions than just ones that can access > memory, such as "AAM"? (Why is this)? All instructions have an implicit memory operand at %rip.  The CPU has to fetch the opcode bytes from somewhere...  (See Introspection, later) You've found MMIO, but emulating from a #GP fault was also an important usecase even back then.  PV guest kernels execute in Ring1 (32bit) or Ring3 (64bit), therefore cannot use CPL0 instructions. While PV guests ought to use hypercalls for privileged operations, doing so completely is very expensive in an existing codebase that you're trying to port to Xen.  Therefore, Xen will emulate in a few faulting conditions, so the guest can e.g. execute RDMSR and have it function correctly (albeit painfully slowly). More recently, Hypervisor Introspection as a technology opens up a whole load of interesting cases which want emulation.  A lot of introspection boils down to removing permissions behind the scenes (e.g. making code no-execute, or making data read-only) so violations cause an exit to the hypervisor, and an introspection agent can make a judgement call.  99% of cases are fine, and should proceed. But, how do you do this?  You could lift the permissions, but then malware on other vCPUs now have a window of time where they are free to make modifications.  So instead you could pause the VM, lift the perms, singlestep the trapping vCPU, restore them perms, and unpause it.  But this has terrible performance to start with, and is an O(N^2) perf hit with then number of vCPUs the VM has. In practice, it is *far* cheaper to have Xen emulate the instruction, than it is to play with pausing, perms and singlestepping. But consider the 1% other case where continuing isn't fine.  One of the supported options is to "emulate / discard" to try and skip the instruction without making a real state modification.  This cannot be done with singlestepping, and has to be done by software somewhere.  As Xen already has an emulator, it's very easy to use a set of write_discard() hooks in place of the real ones. As to the complexity, yes and in truth, Xen's emulator isn't fully an emulator. We pretty much emulate all the integer instructions, because most of them are very simple, but we do not for the vector instructions.  What we do for vector instructions is better described as decode and replay, where we reconstruct a modified form of the instruction to operate on local state, so we can piece together the overall reads and writes without needing to implement the vector logic itself. It's also worth saying that for any locked/atomic operations, we have to issue a real instruction too, because that's the only way to get the cache coherency behaviour correct. It is also worth nothing that Xen's emulator isn't complete.  Notably, noone has implemented IRET for protected mode yet, or inter-privilege far transfers, and we've got known corner cases (e.g. interrupt shadow with Mov SS) in need of some work. We went through a spate of problems where Windows in particular kept coming up with more and more inventive instructions to use to write into the emulated VGA framebuffer, and we decided that the emulator should be as complete as we can reasonably make it.  A consequence of this is that we have some very interesting and powerful advanced security features. I hope this helps, or was at least interesting. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Apr 14 20:30:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 20:30:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521244.809694 (Exim 4.92) (envelope-from ) id 1pnQ3L-0005VH-Ar; Fri, 14 Apr 2023 20:29:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521244.809694; Fri, 14 Apr 2023 20:29:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnQ3L-0005VA-8D; Fri, 14 Apr 2023 20:29:51 +0000 Received: by outflank-mailman (input) for mailman id 521244; Fri, 14 Apr 2023 20:29:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnQ3J-0005V4-DI for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 20:29:49 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061d.outbound.protection.outlook.com [2a01:111:f400:7e88::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17de211a-db03-11ed-8611-37d641c3527e; Fri, 14 Apr 2023 22:29:46 +0200 (CEST) Received: from DM6PR07CA0116.namprd07.prod.outlook.com (2603:10b6:5:330::13) by BY5PR12MB4872.namprd12.prod.outlook.com (2603:10b6:a03:1c4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 20:29:42 +0000 Received: from DM6NAM11FT076.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::5f) by DM6PR07CA0116.outlook.office365.com (2603:10b6:5:330::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 20:29:42 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT076.mail.protection.outlook.com (10.13.173.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6298.36 via Frontend Transport; Fri, 14 Apr 2023 20:29:42 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 15:29:41 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 14 Apr 2023 13:29:40 -0700 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 14 Apr 2023 15:29:39 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17de211a-db03-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oXhrPKkMhMSjz5keQA/NtMClm2k2hhg1wfPIwEO1NR+jZoYaCvG7G31xOB75KTGCrasNtXdSvSHQu1yYCmthwSmlNITtf40zgF+9CczKQx/Ujb6WZCLrMOkXz2hSpki3MgUR2kUqQ8iH4JxvVJqyG9FrdhSdK5X9MJhzlXuZrDUzaRQsbxRzV9L+ZRKZVQXHycvLiELKlb/3ZPGuKaij9H7weeycZyWHIdQFSgRnN2OPok48aKuZqEI01bqXurLNpImW6lggACG5jYOzfon9ivaIQL0dEgze08TvFFPxWnwoRnJbturdTuJbKWVfnvBngGDAvaifKoTE22mFDatDDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S0EKJQP7OWmfg5VAzpren4WzVtEYFxSHbvtw0gR2VGo=; b=HsHMi9KuqLZdofWyOgOBaNJ4IrtavDQOf2vnIXeYzOiz+xwVf6dD2gU7m69LSXp0AGw7vJZYiR5MC61UkTLfYMBnQWggv9rIRVrGUId6WKEwN4HCkg3nP/iusRj+6oAyFE5BVJyybnH+Al4rPWyXKrHSbma9GSjf152573rDBKMypdZheeuNdwhwVtNqaoCtV7NGY6lbBdkhaDoDsyMbbQi4xFVp7OZhJPkdOE5ThbkYqi9hYUToQ+wVcpHYy0F8mmMtGDd5NaBAgW+yl3rZk8opY5278tncFotNDqaJcma6Wv+ls2/nP9og0dCVu9/npCbwW/mdZgfHVO9tuSKOLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0EKJQP7OWmfg5VAzpren4WzVtEYFxSHbvtw0gR2VGo=; b=01WKDi/kq5QAueNfmo2zGUNTAh2jl0ldPYlzH8TLj++pmg7k7mKZZBZnngM6uN3YegI9mVmcLZQMMzUNZH63hK3nS+FiHgDZpGgZi2FW85aA+Ou5BTURsKAKp++m6/GeGw97S2w3Gms8uJs7+8KrG+bBqjGdJXshE86vcz2x3yg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH] xen/vpci: initialize msix->next Date: Fri, 14 Apr 2023 16:29:32 -0400 Message-ID: <20230414202932.293688-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT076:EE_|BY5PR12MB4872:EE_ X-MS-Office365-Filtering-Correlation-Id: d09ac933-e66a-406b-242e-08db3d26fa56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dLpsv8G6C/YO8AhtPchbkjVjJgKWwIzYFhnbxg1FoPXFDpHqhDgkMJVifFlGPT7lZC71BQgkiMOr2oGihiH0uFlRUSPWLj7aBBEF/DqBAo0lA9+R/gScBY2YABbj6jMgpQvS95wfm7jM1hF6CSHRb6PuQbJWZncrvqDtQJeJ8f/SsIDox5FNIZy377Rxd866315KscGkyH1dHCmaeUw6SU6K7oewAk5ze6Zw47BECCcmYrE//uH5y8aWS40Vp2u2ETqZtOojC7CjcYEFFVoqVbI2xwT9O8pgjghFKlBMfpjdGWptN9lmuQqHS6j5Cr9brmHQwzxp+kppU1QzltAm4vXyGxXJZ3WuxHejcBEQLarfnnwuA6xwQa7hDt0eE1cKApHDQZAvs+mNGOgjP0ZG9Y8TFozb25TM9cC76dkOqWFoFP5rf0QQ5zO4zz+FjMaskShUYhacxjtUPNAKCNR4izD/aOyxBOTJb2E02/0SZaigd6CF8e32qVQK6nz2WNutZIRrsNthBwedWMn9yIuWtVP9iKjLz4BJ5hd8vPUEf/LbKP0wYwf/rngak22SN+h84BGLy7Ol/F5nCfqge7OIrTWBju2t+mIbwkBIDfZ/gQ/gB2Fr6elQui+4yd0s07U/QdjJCDS3Y60wb8rY9xI6sIoxsWDM7Y4GqWBV0JlO46Jg2gyLXgrdted+f0roWW87tznLJSRj+UeVZ3iZNPgEgdJARv9yAEWHKO2idE9Ew10= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(36860700001)(186003)(1076003)(6666004)(2906002)(4744005)(26005)(41300700001)(2616005)(426003)(336012)(82310400005)(40460700003)(478600001)(36756003)(47076005)(54906003)(4326008)(6916009)(70586007)(70206006)(356005)(86362001)(44832011)(5660300002)(316002)(81166007)(8676002)(40480700001)(82740400003)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 20:29:42.0433 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d09ac933-e66a-406b-242e-08db3d26fa56 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT076.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4872 The list was not being initialized, which could result in a crash in vpci_remove_device if no list items were added. Signed-off-by: Stewart Hildebrand --- xen/drivers/vpci/msix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 25bde77586a4..1b98c3c10a64 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -678,6 +678,8 @@ static int cf_check init_msix(struct pci_dev *pdev) if ( !msix ) return -ENOMEM; + INIT_LIST_HEAD(&msix->next); + rc = vpci_add_register(pdev->vpci, control_read, control_write, msix_control_reg(msix_offset), 2, msix); if ( rc ) -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Fri Apr 14 21:04:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 21:04:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521248.809705 (Exim 4.92) (envelope-from ) id 1pnQax-0001QF-Vc; Fri, 14 Apr 2023 21:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521248.809705; Fri, 14 Apr 2023 21:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnQax-0001Q8-Sn; Fri, 14 Apr 2023 21:04:35 +0000 Received: by outflank-mailman (input) for mailman id 521248; Fri, 14 Apr 2023 21:04:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnQaw-0001Pp-0U; Fri, 14 Apr 2023 21:04:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnQav-0006FF-Sz; Fri, 14 Apr 2023 21:04:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnQav-00016e-Gf; Fri, 14 Apr 2023 21:04:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnQav-0003B2-GH; Fri, 14 Apr 2023 21:04:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+ucC5+v6hpLgdNc5EfO3taEtjnB8mpV3KnQbTyDUdxA=; b=FsLva4Jqm6BFAH+lsfPVGNbYqE sbsJtviH9Qj49A4rzAe7v0C99QVidJdar85tGyKkmEdOBSOKSCQgz4vBtAtNm+ZeIwFVyyN21cGVq jtuiute92jBwFg+yy70GfBUpWrtmw6IJ6NKvrmQcjix19S8I2MKFBdr89hZmZMoh/KQU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180263: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=18c128ba66e6308744850aca96dbffd18f91c29b X-Osstest-Versions-That: xen=8363b1f62e561cfb73073b4b094516fcbbd7020e From: osstest service owner Date: Fri, 14 Apr 2023 21:04:33 +0000 flight 180263 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180263/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 18c128ba66e6308744850aca96dbffd18f91c29b baseline version: xen 8363b1f62e561cfb73073b4b094516fcbbd7020e Last test of basis 180237 2023-04-13 14:01:55 Z 1 days Testing same since 180263 2023-04-14 18:03:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 8363b1f62e..18c128ba66 18c128ba66e6308744850aca96dbffd18f91c29b -> smoke From xen-devel-bounces@lists.xenproject.org Fri Apr 14 22:02:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 22:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521255.809715 (Exim 4.92) (envelope-from ) id 1pnRUH-0007hN-9C; Fri, 14 Apr 2023 22:01:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521255.809715; Fri, 14 Apr 2023 22:01:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnRUH-0007hG-5j; Fri, 14 Apr 2023 22:01:45 +0000 Received: by outflank-mailman (input) for mailman id 521255; Fri, 14 Apr 2023 22:01:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnRUG-0007h6-33; Fri, 14 Apr 2023 22:01:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnRUF-0007Ul-SX; Fri, 14 Apr 2023 22:01:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnRUF-0002UP-F8; Fri, 14 Apr 2023 22:01:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnRUF-00038K-Eg; Fri, 14 Apr 2023 22:01:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VHXDYLTcSQDE8A6Lh+XdZld3+QNz2rUMTZV+8oBkVOI=; b=wIybqqAPJ2jY6Qvj0CL5p2GFKp 3786VHmuyTG1fCrdreDihvT0wBoCAz8byF2P2z42AvUDjBvOcu0bWwFFwlMhCtJu+F/3MjYskhWWf S5D+yApenDkajuw0FqyzYIQYtkFqPKAX4QJYc5/y1XBop+ncYwOcEb51cEgDazob0xjs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180256: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=8363b1f62e561cfb73073b4b094516fcbbd7020e X-Osstest-Versions-That: xen=f872a624cbf92de9944483eea7674ef80ced1380 From: osstest service owner Date: Fri, 14 Apr 2023 22:01:43 +0000 flight 180256 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180256/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 180238 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 180238 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 5 host-install(5) broken starved in 180238 test-armhf-armhf-xl-rtds 5 host-install(5) broken starved in 180238 test-armhf-armhf-libvirt 5 host-install(5) broken starved in 180238 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180238 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180238 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180238 version targeted for testing: xen 8363b1f62e561cfb73073b4b094516fcbbd7020e baseline version: xen f872a624cbf92de9944483eea7674ef80ced1380 Last test of basis 180238 2023-04-13 14:38:34 Z 1 days Testing same since 180256 2023-04-14 05:34:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-multivcpu host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-libvirt host-install(5) Not pushing. ------------------------------------------------------------ commit 8363b1f62e561cfb73073b4b094516fcbbd7020e Author: Marek Marczykowski-Górecki Date: Thu Apr 13 14:23:40 2023 +0200 automation: switch ADL hw tests to debug build This should give a lot more useful information in case of a failure, and also enable some asserts for extra checks. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521265.809760 (Exim 4.92) (envelope-from ) id 1pnT5b-0001mz-LO; Fri, 14 Apr 2023 23:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521265.809760; Fri, 14 Apr 2023 23:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5b-0001m5-FZ; Fri, 14 Apr 2023 23:44:23 +0000 Received: by outflank-mailman (input) for mailman id 521265; Fri, 14 Apr 2023 23:44:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5Z-0001Th-Vz for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:21 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46f44033-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46f44033-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232309.448345494@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=SRk3RrJ8+RSaiZTRwxMk0fG1NuTGaGpFKdBZXu8mJKE=; b=TenZelvKdY6Tx+OsImAHk36b4tbQIR+z0M1WnFpjy8y+51j9W5eVFc7Of6Sf8s0X5uq+xc 6SLC+/lL+CpUg+kTVvDAN1gjqSax0V+tVQNmmxi4coTX5o01NqKtoGfLSsdE0lb320KW1r QEHnIVRUnqLfhZgK+7fQTY+n7WOGwL6ll+eunwu5W5z5A2qnT1aRW5PuasQXgjsBUf/jBU 7xOQ39cpNhzE0/XOurXN0gDhM1Ox280g/R6YyoZtAiatQnNAao3G3M3vKjSts9mlj9G6qX S7eGW9eMYE6lWwqIwp+CRBO4mI9eSSdxCdQI74WXa5fo3DgjCo/bZ5Uwga1FYg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=SRk3RrJ8+RSaiZTRwxMk0fG1NuTGaGpFKdBZXu8mJKE=; b=GpdL477IqUbVLYXts40m+nkntEs4l/SFSgjl8WTxVs9fG2Y4NeqfbJbNj3fY+ekDTnUTf2 CVV1j8YeN8LpbeAA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 04/37] x86/smpboot: Rename start_cpu0() to soft_restart_cpu() References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:19 +0200 (CEST) This is used in the SEV play_dead() implementation to re-online CPUs. But that has nothing to do with CPU0. Signed-off-by: Thomas Gleixner Cc: Tom Lendacky --- arch/x86/include/asm/cpu.h | 2 +- arch/x86/kernel/callthunks.c | 2 +- arch/x86/kernel/head_32.S | 10 +++++----- arch/x86/kernel/head_64.S | 10 +++++----- arch/x86/kernel/sev.c | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -30,7 +30,7 @@ struct x86_cpu { #ifdef CONFIG_HOTPLUG_CPU extern int arch_register_cpu(int num); extern void arch_unregister_cpu(int); -extern void start_cpu0(void); +extern void soft_restart_cpu(void); #ifdef CONFIG_DEBUG_HOTPLUG_CPU0 extern int _debug_hotplug_cpu(int cpu, int action); #endif --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -134,7 +134,7 @@ static bool skip_addr(void *dest) if (dest == ret_from_fork) return true; #ifdef CONFIG_HOTPLUG_CPU - if (dest == start_cpu0) + if (dest == soft_restart_cpu) return true; #endif #ifdef CONFIG_FUNCTION_TRACER --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -140,16 +140,16 @@ SYM_CODE_END(startup_32) #ifdef CONFIG_HOTPLUG_CPU /* - * Boot CPU0 entry point. It's called from play_dead(). Everything has been set - * up already except stack. We just set up stack here. Then call - * start_secondary(). + * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for + * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot + * unplug. Everything is set up already except the stack. */ -SYM_FUNC_START(start_cpu0) +SYM_FUNC_START(soft_restart_cpu) movl initial_stack, %ecx movl %ecx, %esp call *(initial_code) 1: jmp 1b -SYM_FUNC_END(start_cpu0) +SYM_FUNC_END(soft_restart_cpu) #endif /* --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -377,11 +377,11 @@ SYM_CODE_END(secondary_startup_64) #ifdef CONFIG_HOTPLUG_CPU /* - * Boot CPU0 entry point. It's called from play_dead(). Everything has been set - * up already except stack. We just set up stack here. Then call - * start_secondary() via .Ljump_to_C_code. + * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for + * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot + * unplug. Everything is set up already except the stack. */ -SYM_CODE_START(start_cpu0) +SYM_CODE_START(soft_restart_cpu) ANNOTATE_NOENDBR UNWIND_HINT_EMPTY @@ -390,7 +390,7 @@ SYM_CODE_START(start_cpu0) movq TASK_threadsp(%rcx), %rsp jmp .Ljump_to_C_code -SYM_CODE_END(start_cpu0) +SYM_CODE_END(soft_restart_cpu) #endif #ifdef CONFIG_AMD_MEM_ENCRYPT --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -1326,7 +1326,7 @@ static void sev_es_play_dead(void) * If we get here, the VCPU was woken up again. Jump to CPU * startup code to get it back online. */ - start_cpu0(); + soft_restart_cpu(); } #else /* CONFIG_HOTPLUG_CPU */ #define sev_es_play_dead native_play_dead From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521261.809725 (Exim 4.92) (envelope-from ) id 1pnT5X-0000zx-KT; Fri, 14 Apr 2023 23:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521261.809725; Fri, 14 Apr 2023 23:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5X-0000zq-GR; Fri, 14 Apr 2023 23:44:19 +0000 Received: by outflank-mailman (input) for mailman id 521261; Fri, 14 Apr 2023 23:44:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5W-0000zb-I8 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:18 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 440ecfed-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 440ecfed-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.261127575@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IlHV62TWgKh1cdgK7stl2AzD5yScRMLzrcA90zGNlOQ=; b=ZSJ2jYDTvrOcSfB+q9NW+WGp94J7gVM5nWU/8DuwnoZDMu+XBZCbSUvTxL+DR4BvKxavFN jhuRONKx7L6r94CMMXtiIONzHNo1K+Igs8Z0LLNxD99J31QKLzvq4MDfPqPJUdJy0who+d mKrkRcfXkOBt5Idh86wWBXAvBPESGtEj994l0Sk8+em2iAJUZAhObLDXX+j3oXrngnpCuw zyRT6xozBWS7ZDWw8BWKkQqW6Qlj1eCTnFv9dCNIQazSMGDnTo3mcHwD/wv9ccqLmI3o2G GJGLBHoc9N7XmTNB1GAm0gwQkaNsttkeRSqEESmeoHEEgOdQdWWA8b6V/dbDuQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IlHV62TWgKh1cdgK7stl2AzD5yScRMLzrcA90zGNlOQ=; b=5y7iOO6UN0/F9Na7fC7zsih/Bs+dHvWN4EhYECYw/BugXKR0lZggZtmRr+wdRcc8V09+nR evNcawtvhTVqcwDg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 01/37] x86/smpboot: Cleanup topology_phys_to_logical_pkg()/die() References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:14 +0200 (CEST) Make topology_phys_to_logical_pkg_die() static as it's only used in smpboot.c and fixup the kernel-doc warnings for both functions. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/topology.h | 3 --- arch/x86/kernel/smpboot.c | 10 ++++++---- 2 files changed, 6 insertions(+), 7 deletions(-) --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -139,7 +139,6 @@ static inline int topology_max_smt_threa int topology_update_package_map(unsigned int apicid, unsigned int cpu); int topology_update_die_map(unsigned int dieid, unsigned int cpu); int topology_phys_to_logical_pkg(unsigned int pkg); -int topology_phys_to_logical_die(unsigned int die, unsigned int cpu); bool topology_is_primary_thread(unsigned int cpu); bool topology_smt_supported(void); #else @@ -149,8 +148,6 @@ topology_update_package_map(unsigned int static inline int topology_update_die_map(unsigned int dieid, unsigned int cpu) { return 0; } static inline int topology_phys_to_logical_pkg(unsigned int pkg) { return 0; } -static inline int topology_phys_to_logical_die(unsigned int die, - unsigned int cpu) { return 0; } static inline int topology_max_die_per_package(void) { return 1; } static inline int topology_max_smt_threads(void) { return 1; } static inline bool topology_is_primary_thread(unsigned int cpu) { return true; } --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -288,6 +288,7 @@ bool topology_smt_supported(void) /** * topology_phys_to_logical_pkg - Map a physical package id to a logical + * @phys_pkg: The physical package id to map * * Returns logical package id or -1 if not found */ @@ -304,15 +305,17 @@ int topology_phys_to_logical_pkg(unsigne return -1; } EXPORT_SYMBOL(topology_phys_to_logical_pkg); + /** * topology_phys_to_logical_die - Map a physical die id to logical + * @die_id: The physical die id to map + * @cur_cpu: The CPU for which the mapping is done * * Returns logical die id or -1 if not found */ -int topology_phys_to_logical_die(unsigned int die_id, unsigned int cur_cpu) +static int topology_phys_to_logical_die(unsigned int die_id, unsigned int cur_cpu) { - int cpu; - int proc_id = cpu_data(cur_cpu).phys_proc_id; + int cpu, proc_id = cpu_data(cur_cpu).phys_proc_id; for_each_possible_cpu(cpu) { struct cpuinfo_x86 *c = &cpu_data(cpu); @@ -323,7 +326,6 @@ int topology_phys_to_logical_die(unsigne } return -1; } -EXPORT_SYMBOL(topology_phys_to_logical_die); /** * topology_update_package_map - Update the physical to logical package map From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521267.809778 (Exim 4.92) (envelope-from ) id 1pnT5d-0002It-9h; Fri, 14 Apr 2023 23:44:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521267.809778; Fri, 14 Apr 2023 23:44:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5d-0002Ht-2x; Fri, 14 Apr 2023 23:44:25 +0000 Received: by outflank-mailman (input) for mailman id 521267; Fri, 14 Apr 2023 23:44:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5c-0001Th-G1 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:24 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48e4ba5e-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48e4ba5e-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232309.573146108@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=YH9enl+MJMA7M+jHkGDtbicNr+Ixljj01H/xHz4Qh68=; b=lpyjAm63G6/b32sEy2uepr/mwtvLxNaVZIUgygQvLzALETE8fY9zKOsUJn47ur21f6W14A V2tnHnJYBZ1CJN22W1lTtZ/rc6uajRww1SwLf8shpZdCOhX0eOSE//5WpUk6MbTpvqnR5X qZU37iLHk5J6vEkA5V5T/+OF3dsRu/6COL0XsoQ/S7QyrnGbtOZ10i5838omOG817CfU4Q wnB32letUr83o/0uqFoR5Pi8jZWinNlL6rig7eZUjtVjm5/rd8LWR2a5RVvkxhhNsMfni8 tZJwVT1nbrbuO6Pt7yiZlgUrGKoZmXqt+t1/7rlqYhGz6DIacVWHGb0RmWJU3A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=YH9enl+MJMA7M+jHkGDtbicNr+Ixljj01H/xHz4Qh68=; b=aRdJRfhum/Hx0Do87bftDWbAr15dWCqnPq1ID3UStY4wRkpCpotZQGfhlALDv9i+4/sicD Li5ESueuDU/IBvAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 06/37] x86/smpboot: Remove the CPU0 hotplug kludge References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:22 +0200 (CEST) This was introduced with commit e1c467e69040 ("x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support physical hotplug of CPU0: "We'll change this code in the future to wake up hard offlined CPU0 if real platform and request are available." 11 years later this has not happened and physical hotplug is not officially supported. Remove the cruft. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/apic.h | 1 arch/x86/include/asm/smp.h | 1 arch/x86/kernel/smpboot.c | 170 +++--------------------------------------- drivers/acpi/processor_idle.c | 4 4 files changed, 14 insertions(+), 162 deletions(-) --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -377,7 +377,6 @@ extern struct apic *__apicdrivers[], *__ * APIC functionality to boot other CPUs - only used on SMP: */ #ifdef CONFIG_SMP -extern int wakeup_secondary_cpu_via_nmi(int apicid, unsigned long start_eip); extern int lapic_can_unplug_cpu(void); #endif --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -129,7 +129,6 @@ void native_play_dead(void); void play_dead_common(void); void wbinvd_on_cpu(int cpu); int wbinvd_on_all_cpus(void); -void cond_wakeup_cpu0(void); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -216,9 +216,6 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } -static int cpu0_logical_apicid; -static int enable_start_cpu0; - /* * Activate a secondary processor. */ @@ -241,8 +238,6 @@ static void notrace start_secondary(void x86_cpuinit.early_percpu_clock_init(); smp_callin(); - enable_start_cpu0 = 0; - /* otherwise gcc will move up smp_processor_id before the cpu_init */ barrier(); /* Check TSC synchronization with the control CPU: */ @@ -410,7 +405,7 @@ void smp_store_cpu_info(int id) c->cpu_index = id; /* * During boot time, CPU0 has this setup already. Save the info when - * bringing up AP or offlined CPU0. + * bringing up an AP. */ identify_secondary_cpu(c); c->initialized = true; @@ -807,51 +802,14 @@ static void __init smp_quirk_init_udelay } /* - * Poke the other CPU in the eye via NMI to wake it up. Remember that the normal - * INIT, INIT, STARTUP sequence will reset the chip hard for us, and this - * won't ... remember to clear down the APIC, etc later. - */ -int -wakeup_secondary_cpu_via_nmi(int apicid, unsigned long start_eip) -{ - u32 dm = apic->dest_mode_logical ? APIC_DEST_LOGICAL : APIC_DEST_PHYSICAL; - unsigned long send_status, accept_status = 0; - int maxlvt; - - /* Target chip */ - /* Boot on the stack */ - /* Kick the second */ - apic_icr_write(APIC_DM_NMI | dm, apicid); - - pr_debug("Waiting for send to finish...\n"); - send_status = safe_apic_wait_icr_idle(); - - /* - * Give the other CPU some time to accept the IPI. - */ - udelay(200); - if (APIC_INTEGRATED(boot_cpu_apic_version)) { - maxlvt = lapic_get_maxlvt(); - if (maxlvt > 3) /* Due to the Pentium erratum 3AP. */ - apic_write(APIC_ESR, 0); - accept_status = (apic_read(APIC_ESR) & 0xEF); - } - pr_debug("NMI sent\n"); - - if (send_status) - pr_err("APIC never delivered???\n"); - if (accept_status) - pr_err("APIC delivery error (%lx)\n", accept_status); - - return (send_status | accept_status); -} - -static int -wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) + * Wake up AP by INIT, INIT, STARTUP sequence. + */ +static int wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) { unsigned long send_status = 0, accept_status = 0; int maxlvt, num_starts, j; + preempt_disable(); maxlvt = lapic_get_maxlvt(); /* @@ -957,6 +915,7 @@ wakeup_secondary_cpu_via_init(int phys_a if (accept_status) pr_err("APIC delivery error (%lx)\n", accept_status); + preempt_enable(); return (send_status | accept_status); } @@ -997,67 +956,6 @@ static void announce_cpu(int cpu, int ap node, cpu, apicid); } -static int wakeup_cpu0_nmi(unsigned int cmd, struct pt_regs *regs) -{ - int cpu; - - cpu = smp_processor_id(); - if (cpu == 0 && !cpu_online(cpu) && enable_start_cpu0) - return NMI_HANDLED; - - return NMI_DONE; -} - -/* - * Wake up AP by INIT, INIT, STARTUP sequence. - * - * Instead of waiting for STARTUP after INITs, BSP will execute the BIOS - * boot-strap code which is not a desired behavior for waking up BSP. To - * void the boot-strap code, wake up CPU0 by NMI instead. - * - * This works to wake up soft offlined CPU0 only. If CPU0 is hard offlined - * (i.e. physically hot removed and then hot added), NMI won't wake it up. - * We'll change this code in the future to wake up hard offlined CPU0 if - * real platform and request are available. - */ -static int -wakeup_cpu_via_init_nmi(int cpu, unsigned long start_ip, int apicid, - int *cpu0_nmi_registered) -{ - int id; - int boot_error; - - preempt_disable(); - - /* - * Wake up AP by INIT, INIT, STARTUP sequence. - */ - if (cpu) { - boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); - goto out; - } - - /* - * Wake up BSP by nmi. - * - * Register a NMI handler to help wake up CPU0. - */ - boot_error = register_nmi_handler(NMI_LOCAL, - wakeup_cpu0_nmi, 0, "wake_cpu0"); - - if (!boot_error) { - enable_start_cpu0 = 1; - *cpu0_nmi_registered = 1; - id = apic->dest_mode_logical ? cpu0_logical_apicid : apicid; - boot_error = wakeup_secondary_cpu_via_nmi(id, start_ip); - } - -out: - preempt_enable(); - - return boot_error; -} - int common_cpu_up(unsigned int cpu, struct task_struct *idle) { int ret; @@ -1086,8 +984,7 @@ int common_cpu_up(unsigned int cpu, stru * Returns zero if CPU booted OK, else error code from * ->wakeup_secondary_cpu. */ -static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle, - int *cpu0_nmi_registered) +static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { /* start_ip had better be page-aligned! */ unsigned long start_ip = real_mode_header->trampoline_start; @@ -1120,7 +1017,6 @@ static int do_boot_cpu(int apicid, int c * This grunge runs the startup process for * the targeted processor. */ - if (x86_platform.legacy.warm_reset) { pr_debug("Setting warm reset code and vector.\n"); @@ -1149,15 +1045,14 @@ static int do_boot_cpu(int apicid, int c * - Use a method from the APIC driver if one defined, with wakeup * straight to 64-bit mode preferred over wakeup to RM. * Otherwise, - * - Use an INIT boot APIC message for APs or NMI for BSP. + * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) boot_error = apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) boot_error = apic->wakeup_secondary_cpu(apicid, start_ip); else - boot_error = wakeup_cpu_via_init_nmi(cpu, start_ip, apicid, - cpu0_nmi_registered); + boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); if (!boot_error) { /* @@ -1206,9 +1101,8 @@ static int do_boot_cpu(int apicid, int c int native_cpu_up(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); - int cpu0_nmi_registered = 0; unsigned long flags; - int err, ret = 0; + int err; lockdep_assert_irqs_enabled(); @@ -1247,11 +1141,10 @@ int native_cpu_up(unsigned int cpu, stru if (err) return err; - err = do_boot_cpu(apicid, cpu, tidle, &cpu0_nmi_registered); + err = do_boot_cpu(apicid, cpu, tidle); if (err) { pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); - ret = -EIO; - goto unreg_nmi; + return err; } /* @@ -1267,15 +1160,7 @@ int native_cpu_up(unsigned int cpu, stru touch_nmi_watchdog(); } -unreg_nmi: - /* - * Clean up the nmi handler. Do this after the callin and callout sync - * to avoid impact of possible long unregister time. - */ - if (cpu0_nmi_registered) - unregister_nmi_handler(NMI_LOCAL, "wake_cpu0"); - - return ret; + return 0; } /** @@ -1373,14 +1258,6 @@ static void __init smp_cpu_index_default } } -static void __init smp_get_logical_apicid(void) -{ - if (x2apic_mode) - cpu0_logical_apicid = apic_read(APIC_LDR); - else - cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR)); -} - void __init smp_prepare_cpus_common(void) { unsigned int i; @@ -1443,8 +1320,6 @@ void __init native_smp_prepare_cpus(unsi /* Setup local timer */ x86_init.timers.setup_percpu_clockev(); - smp_get_logical_apicid(); - pr_info("CPU0: "); print_cpu_info(&cpu_data(0)); @@ -1752,18 +1627,6 @@ void play_dead_common(void) local_irq_disable(); } -/** - * cond_wakeup_cpu0 - Wake up CPU0 if needed. - * - * If NMI wants to wake up CPU0, start CPU0. - */ -void cond_wakeup_cpu0(void) -{ - if (smp_processor_id() == 0 && enable_start_cpu0) - start_cpu0(); -} -EXPORT_SYMBOL_GPL(cond_wakeup_cpu0); - /* * We need to flush the caches before going to sleep, lest we have * dirty data in our caches when we come back up. @@ -1831,8 +1694,6 @@ static inline void mwait_play_dead(void) __monitor(mwait_ptr, 0, 0); mb(); __mwait(eax, 0); - - cond_wakeup_cpu0(); } } @@ -1841,11 +1702,8 @@ void hlt_play_dead(void) if (__this_cpu_read(cpu_info.x86) >= 4) wbinvd(); - while (1) { + while (1) native_halt(); - - cond_wakeup_cpu0(); - } } void native_play_dead(void) --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -597,10 +597,6 @@ static int acpi_idle_play_dead(struct cp io_idle(cx->address); } else return -ENODEV; - -#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU) - cond_wakeup_cpu0(); -#endif } /* Never reached */ From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521266.809774 (Exim 4.92) (envelope-from ) id 1pnT5c-0002Dz-SX; Fri, 14 Apr 2023 23:44:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521266.809774; Fri, 14 Apr 2023 23:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5c-0002C8-Oh; Fri, 14 Apr 2023 23:44:24 +0000 Received: by outflank-mailman (input) for mailman id 521266; Fri, 14 Apr 2023 23:44:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5c-0000zb-4c for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:24 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47f825ef-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47f825ef-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.510911744@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=d2aa8PgTtRDs84GbzPYsg9/c/UFZj39RiJ/AAhETCGQ=; b=g4jq/m8sUm3dCRnIPA0dwXXquH1L4TZDkHABiQoYlnjqLC+rJPpJqxy/IaoXl2Ast0od+p CiKL7+fD0P/yOnSTmRwtqCgs50Gux2IhjOKxTWrY/yQZpbQgUKprRZgoR48vA7MalN2Ein wjm/JhwASW4BdRf1odYjAAQ//Da46eXuhGP3fTvTUqPqi1SEsWGcT8cUSKBsEaxJpxMwri t4TDP+VrP0GoyskBjuHSwyAZxkBjwuKAJeiqvUmsCCKQWGebsQbQ/dYW0PwkMnMEHx/+UQ Dk3BAh9FNSoDZhz5JHGwg35NvV4HQZFZp3Q2oCe3rsQbsck8yVtweC9RSpalJg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=d2aa8PgTtRDs84GbzPYsg9/c/UFZj39RiJ/AAhETCGQ=; b=6YjZFgK/aGr78TaRzK8UpHBzLtU3o1jB0TrBSGUihSUOr+Hyfc039ben0Zk8EZVKRloViH We4cnTEgROLKpkAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 05/37] x86/topology: Remove CPU0 hotplug option References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:21 +0200 (CEST) This was introduced together with commit e1c467e69040 ("x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support physical hotplug of CPU0: "We'll change this code in the future to wake up hard offlined CPU0 if real platform and request are available." 11 years later this has not happened and physical hotplug is not officially supported. Remove the cruft. Signed-off-by: Thomas Gleixner --- Documentation/admin-guide/kernel-parameters.txt | 14 --- Documentation/core-api/cpu_hotplug.rst | 13 --- arch/x86/Kconfig | 43 ---------- arch/x86/include/asm/cpu.h | 3 arch/x86/kernel/topology.c | 98 ------------------------ arch/x86/power/cpu.c | 37 --------- 6 files changed, 6 insertions(+), 202 deletions(-) --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -795,20 +795,6 @@ Format: ,,,[,] - cpu0_hotplug [X86] Turn on CPU0 hotplug feature when - CONFIG_BOOTPARAM_HOTPLUG_CPU0 is off. - Some features depend on CPU0. Known dependencies are: - 1. Resume from suspend/hibernate depends on CPU0. - Suspend/hibernate will fail if CPU0 is offline and you - need to online CPU0 before suspend/hibernate. - 2. PIC interrupts also depend on CPU0. CPU0 can't be - removed if a PIC interrupt is detected. - It's said poweroff/reboot may depend on CPU0 on some - machines although I haven't seen such issues so far - after CPU0 is offline on a few tested machines. - If the dependencies are under your control, you can - turn on cpu0_hotplug. - cpuidle.off=1 [CPU_IDLE] disable the cpuidle sub-system --- a/Documentation/core-api/cpu_hotplug.rst +++ b/Documentation/core-api/cpu_hotplug.rst @@ -127,17 +127,8 @@ Once the CPU is shutdown, it will be rem $ echo 1 > /sys/devices/system/cpu/cpu4/online smpboot: Booting Node 0 Processor 4 APIC 0x1 -The CPU is usable again. This should work on all CPUs. CPU0 is often special -and excluded from CPU hotplug. On X86 the kernel option -*CONFIG_BOOTPARAM_HOTPLUG_CPU0* has to be enabled in order to be able to -shutdown CPU0. Alternatively the kernel command option *cpu0_hotplug* can be -used. Some known dependencies of CPU0: - -* Resume from hibernate/suspend. Hibernate/suspend will fail if CPU0 is offline. -* PIC interrupts. CPU0 can't be removed if a PIC interrupt is detected. - -Please let Fenghua Yu know if you find any dependencies -on CPU0. +The CPU is usable again. This should work on all CPUs, but CPU0 is often special +and excluded from CPU hotplug. The CPU hotplug coordination ============================ --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2294,49 +2294,6 @@ config HOTPLUG_CPU def_bool y depends on SMP -config BOOTPARAM_HOTPLUG_CPU0 - bool "Set default setting of cpu0_hotpluggable" - depends on HOTPLUG_CPU - help - Set whether default state of cpu0_hotpluggable is on or off. - - Say Y here to enable CPU0 hotplug by default. If this switch - is turned on, there is no need to give cpu0_hotplug kernel - parameter and the CPU0 hotplug feature is enabled by default. - - Please note: there are two known CPU0 dependencies if you want - to enable the CPU0 hotplug feature either by this switch or by - cpu0_hotplug kernel parameter. - - First, resume from hibernate or suspend always starts from CPU0. - So hibernate and suspend are prevented if CPU0 is offline. - - Second dependency is PIC interrupts always go to CPU0. CPU0 can not - offline if any interrupt can not migrate out of CPU0. There may - be other CPU0 dependencies. - - Please make sure the dependencies are under your control before - you enable this feature. - - Say N if you don't want to enable CPU0 hotplug feature by default. - You still can enable the CPU0 hotplug feature at boot by kernel - parameter cpu0_hotplug. - -config DEBUG_HOTPLUG_CPU0 - def_bool n - prompt "Debug CPU0 hotplug" - depends on HOTPLUG_CPU - help - Enabling this option offlines CPU0 (if CPU0 can be offlined) as - soon as possible and boots up userspace with CPU0 offlined. User - can online CPU0 back after boot time. - - To debug CPU0 hotplug, you need to enable CPU0 offline/online - feature by either turning on CONFIG_BOOTPARAM_HOTPLUG_CPU0 during - compilation or giving cpu0_hotplug kernel parameter at boot. - - If unsure, say N. - config COMPAT_VDSO def_bool n prompt "Disable the 32-bit vDSO (needed for glibc 2.3.3)" --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -31,9 +31,6 @@ struct x86_cpu { extern int arch_register_cpu(int num); extern void arch_unregister_cpu(int); extern void soft_restart_cpu(void); -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 -extern int _debug_hotplug_cpu(int cpu, int action); -#endif #endif extern void ap_init_aperfmperf(void); --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -38,102 +38,12 @@ static DEFINE_PER_CPU(struct x86_cpu, cpu_devices); #ifdef CONFIG_HOTPLUG_CPU - -#ifdef CONFIG_BOOTPARAM_HOTPLUG_CPU0 -static int cpu0_hotpluggable = 1; -#else -static int cpu0_hotpluggable; -static int __init enable_cpu0_hotplug(char *str) -{ - cpu0_hotpluggable = 1; - return 1; -} - -__setup("cpu0_hotplug", enable_cpu0_hotplug); -#endif - -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 -/* - * This function offlines a CPU as early as possible and allows userspace to - * boot up without the CPU. The CPU can be onlined back by user after boot. - * - * This is only called for debugging CPU offline/online feature. - */ -int _debug_hotplug_cpu(int cpu, int action) -{ - int ret; - - if (!cpu_is_hotpluggable(cpu)) - return -EINVAL; - - switch (action) { - case 0: - ret = remove_cpu(cpu); - if (!ret) - pr_info("DEBUG_HOTPLUG_CPU0: CPU %u is now offline\n", cpu); - else - pr_debug("Can't offline CPU%d.\n", cpu); - break; - case 1: - ret = add_cpu(cpu); - if (ret) - pr_debug("Can't online CPU%d.\n", cpu); - - break; - default: - ret = -EINVAL; - } - - return ret; -} - -static int __init debug_hotplug_cpu(void) +int arch_register_cpu(int cpu) { - _debug_hotplug_cpu(0, 0); - return 0; -} - -late_initcall_sync(debug_hotplug_cpu); -#endif /* CONFIG_DEBUG_HOTPLUG_CPU0 */ - -int arch_register_cpu(int num) -{ - struct cpuinfo_x86 *c = &cpu_data(num); - - /* - * Currently CPU0 is only hotpluggable on Intel platforms. Other - * vendors can add hotplug support later. - * Xen PV guests don't support CPU0 hotplug at all. - */ - if (c->x86_vendor != X86_VENDOR_INTEL || - cpu_feature_enabled(X86_FEATURE_XENPV)) - cpu0_hotpluggable = 0; - - /* - * Two known BSP/CPU0 dependencies: Resume from suspend/hibernate - * depends on BSP. PIC interrupts depend on BSP. - * - * If the BSP dependencies are under control, one can tell kernel to - * enable BSP hotplug. This basically adds a control file and - * one can attempt to offline BSP. - */ - if (num == 0 && cpu0_hotpluggable) { - unsigned int irq; - /* - * We won't take down the boot processor on i386 if some - * interrupts only are able to be serviced by the BSP in PIC. - */ - for_each_active_irq(irq) { - if (!IO_APIC_IRQ(irq) && irq_has_action(irq)) { - cpu0_hotpluggable = 0; - break; - } - } - } - if (num || cpu0_hotpluggable) - per_cpu(cpu_devices, num).cpu.hotpluggable = 1; + struct x86_cpu *xc = per_cpu_ptr(&cpu_devices, cpu); - return register_cpu(&per_cpu(cpu_devices, num).cpu, num); + xc->cpu.hotpluggable = cpu > 0; + return register_cpu(&xc->cpu, cpu); } EXPORT_SYMBOL(arch_register_cpu); --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -351,43 +351,6 @@ static int bsp_pm_callback(struct notifi case PM_HIBERNATION_PREPARE: ret = bsp_check(); break; -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 - case PM_RESTORE_PREPARE: - /* - * When system resumes from hibernation, online CPU0 because - * 1. it's required for resume and - * 2. the CPU was online before hibernation - */ - if (!cpu_online(0)) - _debug_hotplug_cpu(0, 1); - break; - case PM_POST_RESTORE: - /* - * When a resume really happens, this code won't be called. - * - * This code is called only when user space hibernation software - * prepares for snapshot device during boot time. So we just - * call _debug_hotplug_cpu() to restore to CPU0's state prior to - * preparing the snapshot device. - * - * This works for normal boot case in our CPU0 hotplug debug - * mode, i.e. CPU0 is offline and user mode hibernation - * software initializes during boot time. - * - * If CPU0 is online and user application accesses snapshot - * device after boot time, this will offline CPU0 and user may - * see different CPU0 state before and after accessing - * the snapshot device. But hopefully this is not a case when - * user debugging CPU0 hotplug. Even if users hit this case, - * they can easily online CPU0 back. - * - * To simplify this debug code, we only consider normal boot - * case. Otherwise we need to remember CPU0's state and restore - * to that state and resolve racy conditions etc. - */ - _debug_hotplug_cpu(0, 0); - break; -#endif default: break; } From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521264.809755 (Exim 4.92) (envelope-from ) id 1pnT5b-0001jo-Bd; Fri, 14 Apr 2023 23:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521264.809755; Fri, 14 Apr 2023 23:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5b-0001jh-8F; Fri, 14 Apr 2023 23:44:23 +0000 Received: by outflank-mailman (input) for mailman id 521264; Fri, 14 Apr 2023 23:44:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5Z-0001Th-Gt for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:21 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45f0e738-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45f0e738-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232309.385574446@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IHNUiYT/aa+9U/QrFpO4u8KQro95rDNTw6iEEK5ze9o=; b=1GGWgmKl+Z16YESLBwfkaJ8pYvl0ibRrRLZ//qbrV6Rn4ejq8Bvi6vo9cC/d06/jSPEXR4 hvZPrEqwgB1nXc44jqzGpA3g8UhwvIHA09SMd8L91BmwlYgaP2m77BjOpifPA2Jp8FR9F+ c0G0jy+fXRMuNBDQtZn5Uv5VCIUDjwdIxXIzMKcFSmEiflIS9qbg0CEGaA9Azgv3qTSjMh 2Q6Nmfsfu+SPkBhJwKselmJZVd9FCtpTg9fyXFZ6j2n8kUoisHbXRgCmcH48m/s4qcThpJ o2FriQZJckk/vdgmu5g5vmRYvkI+K74QUFnLD6JN3zpP58uh1nfGpXn5o7XkuA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IHNUiYT/aa+9U/QrFpO4u8KQro95rDNTw6iEEK5ze9o=; b=cHgI8T+6dl0c5QvmY+jPTGI3Fml5ooLABkADGz2XWt8RyEwXHfElCQYbWkrIndZHTvvRK5 Onzbq0bjdDoTP8Dg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 03/37] x86/smpboot: Avoid pointless delay calibration is TSC is synchronized References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:18 +0200 (CEST) When TSC is synchronized across sockets then there is no reason in calibrating the delay for the first CPU which comes up on a socket. Just reuse the existing calibration value. This removes 100ms pointlessly wasted time from CPU hotplug. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 38 ++++++++++++++++++++++++-------------- arch/x86/kernel/tsc.c | 20 ++++++++++++++++---- 2 files changed, 40 insertions(+), 18 deletions(-) --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -178,10 +178,7 @@ static void smp_callin(void) */ apic_ap_setup(); - /* - * Save our processor parameters. Note: this information - * is needed for clock calibration. - */ + /* Save our processor parameters. */ smp_store_cpu_info(cpuid); /* @@ -192,14 +189,6 @@ static void smp_callin(void) ap_init_aperfmperf(); - /* - * Get our bogomips. - * Update loops_per_jiffy in cpu_data. Previous call to - * smp_store_cpu_info() stored a value that is close but not as - * accurate as the value just calculated. - */ - calibrate_delay(); - cpu_data(cpuid).loops_per_jiffy = loops_per_jiffy; pr_debug("Stack at about %p\n", &cpuid); wmb(); @@ -212,8 +201,24 @@ static void smp_callin(void) cpumask_set_cpu(cpuid, cpu_callin_mask); } +static void ap_calibrate_delay(void) +{ + /* + * Calibrate the delay loop and update loops_per_jiffy in cpu_data. + * smp_store_cpu_info() stored a value that is close but not as + * accurate as the value just calculated. + * + * As this is invoked after the TSC synchronization check, + * calibrate_delay_is_known() will skip the calibration routine + * when TSC is synchronized across sockets. + */ + calibrate_delay(); + cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; +} + static int cpu0_logical_apicid; static int enable_start_cpu0; + /* * Activate a secondary processor. */ @@ -240,10 +245,15 @@ static void notrace start_secondary(void /* otherwise gcc will move up smp_processor_id before the cpu_init */ barrier(); + /* Check TSC synchronization with the control CPU: */ + check_tsc_sync_target(); + /* - * Check TSC synchronization with the boot CPU: + * Calibrate the delay loop after the TSC synchronization check. + * This allows to skip the calibration when TSC is synchronized + * across sockets. */ - check_tsc_sync_target(); + ap_calibrate_delay(); speculative_store_bypass_ht_init(); --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1598,10 +1598,7 @@ void __init tsc_init(void) #ifdef CONFIG_SMP /* - * If we have a constant TSC and are using the TSC for the delay loop, - * we can skip clock calibration if another cpu in the same socket has already - * been calibrated. This assumes that CONSTANT_TSC applies to all - * cpus in the socket - this should be a safe assumption. + * Check whether existing calibration data can be reused. */ unsigned long calibrate_delay_is_known(void) { @@ -1609,6 +1606,21 @@ unsigned long calibrate_delay_is_known(v int constant_tsc = cpu_has(&cpu_data(cpu), X86_FEATURE_CONSTANT_TSC); const struct cpumask *mask = topology_core_cpumask(cpu); + /* + * If TSC has constant frequency and TSC is synchronized across + * sockets then reuse CPU0 calibration. + */ + if (constant_tsc && !tsc_unstable) + return cpu_data(0).loops_per_jiffy; + + /* + * If TSC has constant frequency and TSC is not synchronized across + * sockets and this is not the first CPU in the socket, then reuse + * the calibration value of an already online CPU on that socket. + * + * This assumes that CONSTANT_TSC is consistent for all CPUs in a + * socket. + */ if (!constant_tsc || !mask) return 0; From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521263.809745 (Exim 4.92) (envelope-from ) id 1pnT5Z-0001Te-0n; Fri, 14 Apr 2023 23:44:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521263.809745; Fri, 14 Apr 2023 23:44:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5Y-0001TX-U7; Fri, 14 Apr 2023 23:44:20 +0000 Received: by outflank-mailman (input) for mailman id 521263; Fri, 14 Apr 2023 23:44:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5X-0000zb-EL for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:19 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44f6ddd0-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44f6ddd0-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.323016954@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=sDTci1v+H+1hOBnO3MWKNQ4KSM/+mxYEdJGIWDEKpYw=; b=y8O+iHOImdrEQNmtF7SapUaot3V0yy8b8Ub9SUl+OgGsTaIJZhbZjtiR4PN4V5WCNemOca Ob8ttIQs2lYzofVI5dy3T9RFKAux9iKX/Rkv+VPjfOqV4T6XWGHXuY9IFhwqlXBTVc5Nsl KK4n8ce7YmA5TsutXdcfdM52VSR98OW8mCNQWFGg6cY3Yq6KC99p69q2+p9erXW8Qg/qAb ceQeWzd0QJGBxdpwT1wRPfHvVdxLxyyhgH/r2Dl9U2nA2Jo/APevn/jIIjbNa3EFkc7Pxb zX0dOALraGxj/DlefvHJr1NZVmMqpk/+HdfNk32Kc/stZp2q/WmPtDMIe6OaIQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=sDTci1v+H+1hOBnO3MWKNQ4KSM/+mxYEdJGIWDEKpYw=; b=HMWjVuC1heTl6ACr7VnRkYnxnf9HNU4lYZlkNOeO1jQ9uLiC6+ocCzTSyzyWZjYVjiCgZf cRj6X0w+T3BbGTBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 02/37] cpu/hotplug: Mark arch_disable_smp_support() and bringup_nonboot_cpus() __init References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:16 +0200 (CEST) No point in keeping them around. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 4 ++-- kernel/cpu.c | 2 +- kernel/smp.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1269,9 +1269,9 @@ int native_cpu_up(unsigned int cpu, stru } /** - * arch_disable_smp_support() - disables SMP support for x86 at runtime + * arch_disable_smp_support() - Disables SMP support for x86 at boottime */ -void arch_disable_smp_support(void) +void __init arch_disable_smp_support(void) { disable_ioapic_support(); } --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1502,7 +1502,7 @@ int bringup_hibernate_cpu(unsigned int s return 0; } -void bringup_nonboot_cpus(unsigned int setup_max_cpus) +void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) { unsigned int cpu; --- a/kernel/smp.c +++ b/kernel/smp.c @@ -1051,7 +1051,7 @@ EXPORT_SYMBOL(setup_max_cpus); * SMP mode to . */ -void __weak arch_disable_smp_support(void) { } +void __weak __init arch_disable_smp_support(void) { } static int __init nosmp(char *str) { From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521262.809728 (Exim 4.92) (envelope-from ) id 1pnT5X-00013M-Qc; Fri, 14 Apr 2023 23:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521262.809728; Fri, 14 Apr 2023 23:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5X-00012H-NU; Fri, 14 Apr 2023 23:44:19 +0000 Received: by outflank-mailman (input) for mailman id 521262; Fri, 14 Apr 2023 23:44:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5W-0000zb-RX for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:18 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 436b1c71-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 436b1c71-db1e-11ed-8611-37d641c3527e Message-ID: <20230414225551.858160935@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=2FBNXDCOjdNXMioUNtpnUEdjyh1DRJi8Y1Kqgx20DOM=; b=i+svBH7O/oaj7aunuMsHcDS2onKFuoOeQ13uBn0i2EZBlR0v4LMikX50FeDA9uuKtpCCb4 z/ZWJt0/vTUZz6mY9zE5iv3BQkst/GrxSi6Ihj+kSlASau5HRJFfQmM6o+Ezs2LFefuihB OfOybKBgg03vWHVVy+lwwdcxJzNP2Mj4ptIvtRem3TShasnYo0WGCg3BGy7G1RTXjq6H0Q McFUN7aC8YHh6CBsi49Ue6HNDjvXBu1uwc2ekdjKi/zkZtzpv+eFnW/uvjlxZJOJf9q5K0 HXiWxG4BHUsSjcGVIe0d8f1X+Bi3gXR6qL+GYAhvxOO7XxPoj1jAoHFb0nd3bw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=2FBNXDCOjdNXMioUNtpnUEdjyh1DRJi8Y1Kqgx20DOM=; b=CjkzjdOXpz0mr1oMcda6Lg3ZiGC4HBFA8/eiJ3o7o6axQMA6SR74jLA8yo7Mg0AL4WrPGY YXxTfH/3ZF/ENPBg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 00/37] cpu/hotplug, x86: Reworked parallel CPU bringup Date: Sat, 15 Apr 2023 01:44:13 +0200 (CEST) Hi! This is a complete rework of the parallel bringup patch series (V17) https://lore.kernel.org/lkml/20230328195758.1049469-1-usama.arif@bytedance.com to address the issues which were discovered in review: 1) The X86 microcode loader serialization requirement https://lore.kernel.org/lkml/87v8iirxun.ffs@tglx Microcode loading on HT enabled X86 CPUs requires that the microcode is loaded on the primary thread. The sibling thread(s) must be in quiescent state; either looping in a place which is aware of potential changes by the microcode update (see late loading) or in fully quiescent state, i.e. waiting for INIT/SIPI. This is required by hardware/firmware on Intel. Aside of that it's a vendor independent software correctness issue. Assume the following sequence: CPU1.0 CPU1.1 CPUID($A) Load microcode. Changes CPUID($A, $B) CPUID($B) CPU1.1 makes a decision on $A and $B which might be inconsistent due to the microcode update. The solution for this is to bringup the primary threads first and after that the siblings. Loading microcode on the siblings is a NOOP on Intel and on AMD it is guaranteed to only modify thread local state. This ensures that the APs can load microcode before reaching the alive synchronization point w/o doing any further x86 specific synchronization between the core siblings. 2) The general design issues discussed in V16 https://lore.kernel.org/lkml/87pm8y6yme.ffs@tglx The previous parallel bringup patches just glued this mechanism into the existing code without a deeper analysis of the synchronization mechanisms and without generalizing it so that the control logic is mostly in the core code and not made an architecture specific tinker space. Much of that had been pointed out 2 years ago in the discussions about the early versions of parallel bringup already. The series is based on: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip x86/apic and also available from git: git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git hotplug Background ---------- The reason why people are interested in parallel bringup is to shorten the (kexec) reboot time of cloud servers to reduce the downtime of the VM tenants. There are obviously other interesting use cases for this like VM startup time, embedded devices... The current fully serialized bringup does the following per AP: 1) Prepare callbacks (allocate, intialize, create threads) 2) Kick the AP alive (e.g. INIT/SIPI on x86) 3) Wait for the AP to report alive state 4) Let the AP continue through the atomic bringup 5) Let the AP run the threaded bringup to full online state There are two significant delays: #3 The time for an AP to report alive state in start_secondary() on x86 has been measured in the range between 350us and 3.5ms depending on vendor and CPU type, BIOS microcode size etc. #4 The atomic bringup does the microcode update. This has been measured to take up to ~8ms on the primary threads depending on the microcode patch size to apply. On a two socket SKL server with 56 cores (112 threads) the boot CPU spends on current mainline about 800ms busy waiting for the APs to come up and apply microcode. That's more than 80% of the actual onlining procedure. By splitting the actual bringup mechanism into two parts this can be reduced to waiting for the first AP to report alive or if the system is large enough the first AP is already waiting when the boot CPU finished the wake-up of the last AP. The actual solution comes in several parts ------------------------------------------ 1) [P 1-2] General cleanups (init annotations, kernel doc...) 2) [P 3] The obvious Avoid pointless delay calibration when TSC is synchronized across sockets. That removes a whopping 100ms delay for the first CPU of a socket. This is an improvement independent of parallel bringup and had been discussed two years ago already. 2) [P 3-6] Removal of the CPU0 hotplug hack. This was added 11 years ago with the promise to make this a real hardware mechanism, but that never materialized. As physical CPU hotplug is not really supported and the physical unplugging of CPU0 never materialized there is no reason to keep this cruft around. It's just maintenance ballast for no value and the removal makes implementing the parallel bringup feature way simpler. 3) [P 7-16] Cleanup of the existing bringup mechanism: a) Code reorganisation so that the general hotplug specific code is in smpboot.c and not sprinkled all over the place b) Decouple MTRR/PAT initialization from smp_callout_mask to prepare for replacing that mask with a hotplug core code synchronization mechanism. c) Make TSC synchronization function call based so that the control CPU does not have to busy wait for nothing if synchronization is not required. d) Remove the smp_callin_mask synchronization point as its not longer required due to #3c. e) Rework the sparse_irq_lock held region in the core code so that the next polling synchronization point in the x86 code can be removed to. f) Due to #3e it's not longer required to spin wait for the AP to set it's online bit. Remove wait_cpu_online() and the XENPV counterpart. So the control CPU can directly wait for the online idle completion by the AP and free the control CPU up for other work. This reduces the synchronization points in the x86 code to one, which is the AP alive one. This synchronization will be moved to core infrastructure in the next section. 4) [P 17-27] Replace the disconnected CPU state tracking The extra CPU state tracking which is used by a few architectures is completely separate from the CPU hotplug core code. Replacing it by a variant integrated in the core hotplug machinery allows to reduce architecture specific code and provides a generic synchronization mechanism for (parallel) CPU bringup/teardown. - Convert x86 over and replace the AP alive synchronization on x86 with the core variant which removes the remaining x86 hotplug synchronization masks. - Convert the other architectures usage and remove the old interface and code. 5) [P 28-30] Split the bringup into two steps First step invokes the wakeup function on the BP, e.g. SIPI/STARTUP on x86. The second one waits on the BP for the AP to report alive and releases it for the complete onlining. As the hotplug state machine allows partial bringup this allows later to kick all APs alive in a first iteration and then bring them up completely one by one afterwards. 6) [P 31] Switch the primary thread detection to a cpumask This makes the parallel bringup a simple cpumask based mechanism without tons of conditionals and checks for primary threads. 7) [P 32] Implement the parallel bringup core code The parallel bringup looks like this: 1) Bring up the primary SMT threads to the CPUHP_KICK_AP_ALIVE step one by one 2) Bring up the primary SMT threads to the CPUHP_ONLINE step one by one 3) Bring up the secondary SMT threads to the CPUHP_KICK_AP_ALIVE step one by one 4) Bring up the secondary SMT threads to the CPUHP_ONLINE step one by one In case that SMT is not supported this is obviously reduced to step #1 and #2. 8) [P 33-37] Prepare X86 for parallel bringup and enable it Caveats ------- The non X86 changes have been all compile tested. Boot and runtime testing has only be done on a few real hardware platforms and qemu as available. That definitely needs some help from the people who have these systems at their fingertips. Results and analysis -------------------- Here are numbers for a dual socket SKL 56 cores/ 112 threads machine. All numbers in milliseconds. The time measured is the time which the cpu_up() call takes for each CPU and phase. It's not exact as the system is already scheduling, handling interrupts and soft interrupts, which is obviously skewing the picture slightly. Baseline tip tree x86/apic branch. total avg/CPU min max total : 912.081 8.217 3.720 113.271 The max of 100ms is due to the silly delay calibration for the second socket which takes 100ms and was eliminated first. Also the other initial cleanups and improvements take some time away. So the real baseline becomes: total avg/CPU min max total : 785.960 7.081 3.752 36.098 The max here is on the first CPU of the second socket. 20ms of that is due to TSC synchronization and an extra 2ms to react on the SIPI. With parallel bootup enabled this becomes: total avg/CPU min max prepare: 39.108 0.352 0.238 0.883 online : 45.166 0.407 0.170 20.357 total : 84.274 0.759 0.408 21.240 That's a factor ~9.3 reduction on average. Looking at the 27 primary threads of socket 0 then this becomes even more interesting: total avg/CPU min max total : 325.764 12.065 11.981 14.125 versus: total avg/CPU min max prepare: 8.945 0.331 0.238 0.834 online : 4.830 0.179 0.170 0.212 total : 13.775 0.510 0.408 1.046 So the reduction factor is ~23.5 here. That's mostly because the 20ms TSC sync is not skewing the picture. For all 55 primaries, i.e with the 20ms TSC sync extra for socket 1 this becomes: total avg/CPU min max total : 685.489 12.463 11.975 36.098 versus: total avg/CPU min max prepare: 19.080 0.353 0.238 0.883 online : 30.283 0.561 0.170 20.357 total : 49.363 0.914 0.408 21.240 The TSC sync reduces the win to a factor of ~13.8 With 'tsc=reliable' on the command line the socket sync is disabled which brings it back to the socket 0 numbers: total avg/CPU min max prepare: 18.970 0.351 0.231 0.874 online : 10.328 0.191 0.169 0.358 total : 29.298 0.543 0.400 1.232 Now looking at the secondary threads only: total avg/CPU min max total : 100.471 1.794 0.375 4.745 versus: total avg/CPU min max prepare: 19.753 0.353 0.257 0.512 online : 14.671 0.262 0.179 3.461 total : 34.424 0.615 0.436 3.973 Still a factor of ~3. The average on the secondaries for the serialized bringup is significantly lower than for the primaries because the SIPI response time is shorter and the microcode update takes no time. This varies wildly with the system, whether microcode in BIOS is already up to date, how big the microcode patch is and how long the INIT/SIPI response time is. On an AMD Zen3 machine INIT/SIPI response time is amazingly fast (350us), but then it lacks TSC_ADJUST and does a two millisecond TSC sync test for _every_ AP. All of this sucks... Possible further enhancements ----------------------------- It's definitely worthwhile to look into reducing the cross socket TSC sync test time. It's probably safe enough to use 5ms or even 2ms instead of 20ms on systems with TSC_ADJUST and a few other 'TSC is sane' indicators. Moving it out of the hotplug path is eventually possible, but that needs some deep thoughts. Let's take the TSC sync out of the picture by adding 'tsc=reliable" to the kernel command line. So the bringup of 111 APs takes: total avg/CPU min max prepare: 38.936 0.351 0.231 0.874 online : 25.231 0.227 0.169 3.465 total : 64.167 0.578 0.400 4.339 Some of the outliers are not necessarily in the state callbacks as the system is already scheduling and handles interrupts and soft interrupts. Haven't analyzed that yet in detail. In the prepare stage which runs on the control CPU the larger steps are: smpcfd:prepare 16us avg/CPU threads:prepare 98us avg/CPU workqueue:prepare 43us avg/CPU trace/RB:prepare 135us avg/CPU The trace ringbuffer initialization allocates 354 pages and 354 control structures one by one. That probably should allocate a large page and an array of control structures and work from there. I'm sure that would reduce this significantly. Steven? smpcfd does just a percpu allocation. No idea why that takes that long. Vs. threads and workqueues. David thought about spreading out the preparation work and do it really in parallel. That's a nice idea, but the threads and workqueue prepare steps are self serializing. The workqueue one has a global mutex and aside of that both steps create kernel threads which implicitely serialize on kthreadd. alloc_percpu(), which is used by smpcfd:prepare is also globally serialized. The rest of the prepare steps is pretty much in the single digit microseconds range. On the AP side it should be possible to move some of the initialization steps before the alive synchronization point, but that really needs a lot of analysis whether the functions are safe to invoke that early and outside of the cpu_hotplug_lock held region for the case of two stage parallel bringup; see below. The largest part is: identify_secondary_cpu() 99us avg/CPU Inside of identify_secondary_cpu() the largest offender: mcheck_init() 73us avg/CPU This part is definitly worth to be looked at whether it can be at least partially moved to the early startup code before the alive synchronization point. There's a lot of deep analysis required and ideally we just rewrite the whole CPUID evaluation trainwreck completely. The rest of the AP side is low single digit microseconds except of: perf/x86:starting 14us avg/CPU smpboot/threads:online 13us avg/CPU workqueue:online 17us avg/CPU mm/vmstat:online 17us avg/CPU sched:active 30us avg/CPU sched:active is special. Onlining the first secondary HT thread on the second socket creates a 3.2ms outlier which skews the whole picture. That's caused by enabling the static key sched_smt_present which patches the world and some more. For all other APs this is really in the 1us range. This definitely could be postponed during bootup like the scheduler domain rebuild is done after the bringup. But that's still fully serialized and single threaded and obviously could be done later in the context of async parallel init. It's unclear why this is different with the fully serialized bringup where it takes significantly less time, but that's something which needs to be investigated. Is truly parallel bringup feasible? ----------------------------------- In theory yes, realistically no. Why? 1) The preparation phase Allocating memory, creating threads for the to be brought up CPU must obviously happen on an already online CPU. While it would be possible to bring up a subset of CPUs first and let them do the preparation steps for groups of still offline CPUs concurrently, the actual benefit of doing so is dubious. The prime example is kernel thread creation, which is implicitely serialized on kthreadd. A simple experiment shows that 4 concurrent workers on 4 different CPUs where each is creating 14 * 5 = 70 kernel threads are 5% slower than a single worker creating 4 * 14 * 5 = 280 threads. So we'd need to have multiple kthreadd instances to handle that, which would then serialize on tasklist lock and other things. That aside the preparation phase is also affected by the problem below. 2) Assumptions about hotplug serialization a) There are quite some assumptions about CPU bringup being fully serialized across state transitions. A lot of state callbacks rely on that and would require local locking. Adding that local locking is surely possible, but that has several downsides: - It adds complexity and makes it harder for developers to get this correct. The subtle bugs resulting out of that are going to be interesting - Fine grained locking has a charm, but only if the time spent for the actual work is larger than the time required for serialization and synchronization. Serializing a callback which takes less than a microsecond and then having a large number of CPUs contending on the lock will not make it any faster at all. That's a well known issue of parallelizing and neither made up nor kernel specific. b) Some operations definitely require to be protected by the cpu_hotplug_lock, especially those which affect cpumasks as the masks are guaranteed to be stable in a cpus_read_lock()'ed region. As this lock cannot be taken in atomic contexts, it's required that the control CPU holds the lock write locked across these state transitions. And no, we are not making this a spinlock just for that and we even can't. Just slapping a lock into the x86 specific part of the cpumask update function does not solve anything. The relevant patch in V17 is completely useless as it only serializes the actual cpumask/map modifications, but all read side users are hosed if the update would be moved before the alive synchronization point, i.e. into a non hotplug lock protected region. Even if the hotplug lock would be held accross the whole parallel bringup operation then this would still expose all usage of these masks and maps in the actual hotplug state callbacks to concurrent modifications. And no, we are not going to expose an architecture specific raw spinlock to the hotplug state callbacks, especially not to those in generic code. c) Some cpu_read_lock()'ed regions also expect that there is no CPU state transition happening which would modify their local state. This would again require local serialization. 3) The amount of work and churn: - Analyze the per architecture low level startup functions plus their descendant functions and make them ready for concurrency if necessary. - Analyze ~300 hotplug state callbacks and their descendant functions and make them ready for concurrency if necessary. - Analyze all cpus_read_lock()'ed regions and address their requirements. - Rewrite the core code to handle the cpu_hotplug_lock requirements only in distinct phases of the state machine. - Rewrite the core code to handle state callback failure and the related rollback in the context of the new rules. - ... Even if some people are dedicated enough to do that, it's very questionable whether the resulting complexity is justified. We've spent a serious amount of time to sanitize hotplug and bring it into a state where it is correct. This also made it reasonably simple for developers to implement hotplug state callbacks without having to become hotplug experts. Breaking this completely up will result in a flood of hard to diagnose subtle issues for sure. Who is going to deal with them? The experience with this series so far does not make me comfortable about that thought in any way. Summary ------- The obvious and low hanging fruits have to be solved first: - The CPUID evaluation and related setup mechanisms - The trace/ringbuffer oddity - The sched:active oddity for the first sibling on the second socket - Some other expensive things which I'm not seeing in my test setup due to lack of hardware or configuration. Anything else is pretty much wishful thinking in my opinion. To be clear. I'm not standing in the way if there is a proper solution, but that requires to respect the basic engineering rules: 1) Correctness first 2) Keep it maintainable 3) Keep it simple So far this stuff failed already at #1. I completely understand why this is important for cloud people, but the real question to ask here is what are the actual requirements. As far as I understand the main goal is to make a (kexec) reboot almost invisible to VM tenants. Now lets look at how this works: A) Freeze VMs and persist state B) kexec into the new kernel C) Restore VMs from persistant memory D) Thaw VMs So the key problem is how long it takes to get from #B to #C and finally to #D. As far as I understand #C takes a serious amount of time and cannot be parallelized for whatever reasons. At the same time the number of online CPUs required to restore the VMs state is less than the number of online CPUs required to actually operate them in #D. That means it would be good enough to return to userspace with a limited number of online CPUs as fast as possible. A certain amount of CPUs are going to be busy with restoring the VMs state, i.e. one CPU per VM. Some remaining non-busy CPU can bringup the rest of the system and the APs in order to be functional for #D, i.e the restore of VM operation. Trying to optimize this purely in kernel space by adding complexity of dubious value is simply bogus in my opinion. It's already possible today to limit the number of CPUs which are initially onlined and online the rest later from user space. There are two issue there: a) The death by MCE broadcast problem Quite some (contemporary) x86 CPU generations are affected by this: - MCE can be broadcasted to all CPUs and not only issued locally to the CPU which triggered it. - Any CPU which has CR4.MCE == 0, even if it sits in a wait for INIT/SIPI state, will cause an immediate shutdown of the machine if a broadcasted MCE is delivered. b) Do the parallel bringup via sysfs control knob The per CPU target state interface allows to do that today one by one, but it's akward and has quite some overhead. A knob to online the rest of the not yet onlined present CPUs with the benefit of the parallel bringup mechanism is missing. #a) That's a risk to take by the operator. Even the regular serialized bringup does not protect against this issue up to the point where all present CPUs have at least initialized CR4. Limiting the number of APs to online early via the kernel command line widens that window and increases the risk further by executing user space before all APs have CR4 initialized. But the same applies to a deferred online mechanism implemented in the kernel where some worker brings up the not yet online APs while the early online CPUs are already executing user space code. #b) Is a no brainer to implement on top of this. Conclusion ---------- Adding the basic parallel bringup mechanism as provided by this series makes a lot of sense. Improving particular issues as pointed out in the analysis makes sense too. But trying to solve an application specific problem fully in the kernel with tons of complexity, without exploring straight forward and simple approaches first, does not make any sense at all. Thanks, tglx --- Documentation/admin-guide/kernel-parameters.txt | 20 Documentation/core-api/cpu_hotplug.rst | 13 arch/Kconfig | 23 + arch/arm/Kconfig | 1 arch/arm/include/asm/smp.h | 2 arch/arm/kernel/smp.c | 18 arch/arm64/Kconfig | 1 arch/arm64/include/asm/smp.h | 2 arch/arm64/kernel/smp.c | 14 arch/csky/Kconfig | 1 arch/csky/include/asm/smp.h | 2 arch/csky/kernel/smp.c | 8 arch/mips/Kconfig | 1 arch/mips/cavium-octeon/smp.c | 1 arch/mips/include/asm/smp-ops.h | 1 arch/mips/kernel/smp-bmips.c | 1 arch/mips/kernel/smp-cps.c | 14 arch/mips/kernel/smp.c | 8 arch/mips/loongson64/smp.c | 1 arch/parisc/Kconfig | 1 arch/parisc/kernel/process.c | 4 arch/parisc/kernel/smp.c | 7 arch/riscv/Kconfig | 1 arch/riscv/include/asm/smp.h | 2 arch/riscv/kernel/cpu-hotplug.c | 14 arch/x86/Kconfig | 45 -- arch/x86/include/asm/apic.h | 5 arch/x86/include/asm/cpu.h | 5 arch/x86/include/asm/cpumask.h | 5 arch/x86/include/asm/processor.h | 1 arch/x86/include/asm/realmode.h | 3 arch/x86/include/asm/sev-common.h | 3 arch/x86/include/asm/smp.h | 26 - arch/x86/include/asm/topology.h | 23 - arch/x86/include/asm/tsc.h | 2 arch/x86/kernel/acpi/sleep.c | 9 arch/x86/kernel/apic/apic.c | 22 - arch/x86/kernel/callthunks.c | 4 arch/x86/kernel/cpu/amd.c | 2 arch/x86/kernel/cpu/cacheinfo.c | 21 arch/x86/kernel/cpu/common.c | 50 -- arch/x86/kernel/cpu/topology.c | 3 arch/x86/kernel/head_32.S | 14 arch/x86/kernel/head_64.S | 121 +++++ arch/x86/kernel/sev.c | 2 arch/x86/kernel/smp.c | 3 arch/x86/kernel/smpboot.c | 508 ++++++++---------------- arch/x86/kernel/topology.c | 98 ---- arch/x86/kernel/tsc.c | 20 arch/x86/kernel/tsc_sync.c | 36 - arch/x86/power/cpu.c | 37 - arch/x86/realmode/init.c | 3 arch/x86/realmode/rm/trampoline_64.S | 27 + arch/x86/xen/enlighten_hvm.c | 11 arch/x86/xen/smp_hvm.c | 16 arch/x86/xen/smp_pv.c | 56 +- drivers/acpi/processor_idle.c | 4 include/linux/cpu.h | 4 include/linux/cpuhotplug.h | 17 kernel/cpu.c | 397 +++++++++++++++++- kernel/smp.c | 2 kernel/smpboot.c | 163 ------- 62 files changed, 953 insertions(+), 976 deletions(-) From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521268.809795 (Exim 4.92) (envelope-from ) id 1pnT5g-0002uU-R9; Fri, 14 Apr 2023 23:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521268.809795; Fri, 14 Apr 2023 23:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5g-0002uL-MO; Fri, 14 Apr 2023 23:44:28 +0000 Received: by outflank-mailman (input) for mailman id 521268; Fri, 14 Apr 2023 23:44:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5f-0000zb-6J for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:27 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a08d002-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a08d002-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.634953473@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=yXU88DPM4+gDgwwKQLancKUxDjIhod/zoYFzhLlkywE=; b=uB/cdoo+FiKgxcyt6ua+eofd7Uy6FRsG6/M919LHeLaRDCm0uyHoc5a1FuwimG9z0Kg1xr I101+cnRHFikD4fqEm6lZOTxsA3yV9LXW61rrHUVlF3AiOWiBC00yRq0VhWdSwUelUpctI 5IcE3x4R3zXRKbqt7SSBKBa4oYiQTpXazjMN/L2oMlO9K+07Nyr22exnb4k00l3spzvmVc 9LRa6JkEMAonr+NJM4O1ggTmXWPqwz4bV0FKYjWVuxuelWC7S0/bYUbnT566jHXu359fFE 1kF7NH3ihq64cycQYcnuOz7AxFm2QZeP5t1J5QjP8JiYPJKiwyKDhh8WCXeClA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=yXU88DPM4+gDgwwKQLancKUxDjIhod/zoYFzhLlkywE=; b=MdNuozlhNGUku1R1Tw5i7+TfSWnt88h5jzNnGTOji+filOi1PFWkM9UpldmpxTl1Bs6qoB RP/SXlqo2sMOuJDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 07/37] x86/smpboot: Restrict soft_restart_cpu() to SEV References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:24 +0200 (CEST) Now that the CPU0 hotplug cruft is gone, the only user is AMD SEV. Signed-off-by: Thomas Gleixner Cc: Tom Lendacky --- arch/x86/kernel/callthunks.c | 2 +- arch/x86/kernel/head_32.S | 14 -------------- arch/x86/kernel/head_64.S | 2 +- 3 files changed, 2 insertions(+), 16 deletions(-) --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -133,7 +133,7 @@ static bool skip_addr(void *dest) /* Accounts directly */ if (dest == ret_from_fork) return true; -#ifdef CONFIG_HOTPLUG_CPU +#if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_AMD_MEM_ENCRYPT) if (dest == soft_restart_cpu) return true; #endif --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -138,20 +138,6 @@ SYM_CODE_START(startup_32) jmp .Ldefault_entry SYM_CODE_END(startup_32) -#ifdef CONFIG_HOTPLUG_CPU -/* - * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for - * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot - * unplug. Everything is set up already except the stack. - */ -SYM_FUNC_START(soft_restart_cpu) - movl initial_stack, %ecx - movl %ecx, %esp - call *(initial_code) -1: jmp 1b -SYM_FUNC_END(soft_restart_cpu) -#endif - /* * Non-boot CPU entry point; entered from trampoline.S * We can't lgdt here, because lgdt itself uses a data segment, but --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -375,7 +375,7 @@ SYM_CODE_END(secondary_startup_64) #include "verify_cpu.S" #include "sev_verify_cbit.S" -#ifdef CONFIG_HOTPLUG_CPU +#if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_AMD_MEM_ENCRYPT) /* * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521269.809805 (Exim 4.92) (envelope-from ) id 1pnT5i-0003Bo-9h; Fri, 14 Apr 2023 23:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521269.809805; Fri, 14 Apr 2023 23:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5i-0003BR-1Z; Fri, 14 Apr 2023 23:44:30 +0000 Received: by outflank-mailman (input) for mailman id 521269; Fri, 14 Apr 2023 23:44:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5h-0000zb-4r for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:29 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b01e6b6-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b01e6b6-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.697634212@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1Wi+qwoi+evP9/DCOV2cSOOVm8Cmr+iaowZLI6jmphg=; b=AtRfJAw/8dYgxzfcjPmLpOmGdUx0vCx8DqJiiMUmA3Cx+ZLSfVD8knv2kLNlnnW0M6wLbC T2QMHllGrZw7clK5/9Izh2AsnDdOvwLy0I4V80idxIhDm2+ZbZDLAikAULtI4e2AXQKPJr hBN5Y+KDw8n4D6Q1OvfiiBRG0iaAfEdsTfZ4cQweomKAopqUvixONL5zoVls1tMNAxyOEc sq7MkdcHTAZO6XblFcZcs66KyhWSvsJm9iqyZTxzUjsNnLQXic0xapY2RzQ/O/jDEPsPId R7R0FelILdrBFPupQz1xDszAcoMcHcibu8KNFeW7JRloBkiOApBN6zt3RCxP6g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1Wi+qwoi+evP9/DCOV2cSOOVm8Cmr+iaowZLI6jmphg=; b=erfBajWkK4A2wOU949cIjl3VUhIAl2v89iiOuXqsNlKDnlt3hip7OcUwwjvwGRE24kiwsr gNkbbyv7cvDgLNDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 08/37] x86/smpboot: Split up native_cpu_up() into separate phases and document them References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:26 +0200 (CEST) From: David Woodhouse There are four logical parts to what native_cpu_up() does on the BSP (or on the controlling CPU for a later hotplug): 1) Wake the AP by sending the INIT/SIPI/SIPI sequence. 2) Wait for the AP to make it as far as wait_for_master_cpu() which sets that CPU's bit in cpu_initialized_mask, then sets the bit in cpu_callout_mask to let the AP proceed through cpu_init(). 3) Wait for the AP to finish cpu_init() and get as far as the smp_callin() call, which sets that CPU's bit in cpu_callin_mask. 4) Perform the TSC synchronization and wait for the AP to actually mark itself online in cpu_online_mask. In preparation to allow these phases to operate in parallel on multiple APs, split them out into separate functions and document the interactions a little more clearly in both the BP and AP code paths. No functional change intended. Signed-off-by: David Woodhouse Signed-off-by: Usama Arif Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 187 +++++++++++++++++++++++++++++----------------- 1 file changed, 121 insertions(+), 66 deletions(-) --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -193,6 +193,10 @@ static void smp_callin(void) wmb(); + /* + * This runs the AP through all the cpuhp states to its target + * state (CPUHP_ONLINE in the case of serial bringup). + */ notify_cpu_starting(cpuid); /* @@ -233,14 +237,31 @@ static void notrace start_secondary(void load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif + /* + * Sync point with wait_cpu_initialized(). Before proceeding through + * cpu_init(), the AP will call wait_for_master_cpu() which sets its + * own bit in cpu_initialized_mask and then waits for the BSP to set + * its bit in cpu_callout_mask to release it. + */ cpu_init_secondary(); rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); + + /* + * Sync point with wait_cpu_callin(). The AP doesn't wait here + * but just sets the bit to let the controlling CPU (BSP) know that + * it's got this far. + */ smp_callin(); - /* otherwise gcc will move up smp_processor_id before the cpu_init */ + /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ barrier(); - /* Check TSC synchronization with the control CPU: */ + + /* + * Check TSC synchronization with the control CPU, which will do + * its part of this from wait_cpu_online(), making it an implicit + * synchronization point. + */ check_tsc_sync_target(); /* @@ -259,6 +280,7 @@ static void notrace start_secondary(void * half valid vector space. */ lock_vector_lock(); + /* Sync point with do_wait_cpu_online() */ set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); @@ -981,17 +1003,13 @@ int common_cpu_up(unsigned int cpu, stru /* * NOTE - on most systems this is a PHYSICAL apic ID, but on multiquad * (ie clustered apic addressing mode), this is a LOGICAL apic ID. - * Returns zero if CPU booted OK, else error code from + * Returns zero if startup was successfully sent, else error code from * ->wakeup_secondary_cpu. */ static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { - /* start_ip had better be page-aligned! */ unsigned long start_ip = real_mode_header->trampoline_start; - unsigned long boot_error = 0; - unsigned long timeout; - #ifdef CONFIG_X86_64 /* If 64-bit wakeup method exists, use the 64-bit mode trampoline IP */ if (apic->wakeup_secondary_cpu_64) @@ -1048,60 +1066,89 @@ static int do_boot_cpu(int apicid, int c * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) - boot_error = apic->wakeup_secondary_cpu_64(apicid, start_ip); + return apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) - boot_error = apic->wakeup_secondary_cpu(apicid, start_ip); - else - boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); + return apic->wakeup_secondary_cpu(apicid, start_ip); - if (!boot_error) { - /* - * Wait 10s total for first sign of life from AP - */ - boot_error = -1; - timeout = jiffies + 10*HZ; - while (time_before(jiffies, timeout)) { - if (cpumask_test_cpu(cpu, cpu_initialized_mask)) { - /* - * Tell AP to proceed with initialization - */ - cpumask_set_cpu(cpu, cpu_callout_mask); - boot_error = 0; - break; - } - schedule(); - } - } + return wakeup_secondary_cpu_via_init(apicid, start_ip); +} - if (!boot_error) { - /* - * Wait till AP completes initial initialization - */ - while (!cpumask_test_cpu(cpu, cpu_callin_mask)) { - /* - * Allow other tasks to run while we wait for the - * AP to come online. This also gives a chance - * for the MTRR work(triggered by the AP coming online) - * to be completed in the stop machine context. - */ - schedule(); - } - } +static int wait_cpu_cpumask(unsigned int cpu, const struct cpumask *mask) +{ + unsigned long timeout; - if (x86_platform.legacy.warm_reset) { - /* - * Cleanup possible dangling ends... - */ - smpboot_restore_warm_reset_vector(); + /* + * Wait up to 10s for the CPU to report in. + */ + timeout = jiffies + 10*HZ; + while (time_before(jiffies, timeout)) { + if (cpumask_test_cpu(cpu, mask)) + return 0; + + schedule(); } + return -1; +} - return boot_error; +/* + * Bringup step two: Wait for the target AP to reach cpu_init_secondary() + * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it + * to proceed. The AP will then proceed past setting its 'callin' bit + * and end up waiting in check_tsc_sync_target() until we reach + * do_wait_cpu_online() to tend to it. + */ +static int wait_cpu_initialized(unsigned int cpu) +{ + /* + * Wait for first sign of life from AP. + */ + if (wait_cpu_cpumask(cpu, cpu_initialized_mask)) + return -1; + + cpumask_set_cpu(cpu, cpu_callout_mask); + return 0; } -int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +/* + * Bringup step three: Wait for the target AP to reach smp_callin(). + * The AP is not waiting for us here so we don't need to parallelise + * this step. Not entirely clear why we care about this, since we just + * proceed directly to TSC synchronization which is the next sync + * point with the AP anyway. + */ +static void wait_cpu_callin(unsigned int cpu) +{ + while (!cpumask_test_cpu(cpu, cpu_callin_mask)) + schedule(); +} + +/* + * Bringup step four: Synchronize the TSC and wait for the target AP + * to reach set_cpu_online() in start_secondary(). + */ +static void wait_cpu_online(unsigned int cpu) { - int apicid = apic->cpu_present_to_apicid(cpu); unsigned long flags; + + /* + * Check TSC synchronization with the AP (keep irqs disabled + * while doing so): + */ + local_irq_save(flags); + check_tsc_sync_source(cpu); + local_irq_restore(flags); + + /* + * Wait for the AP to mark itself online, so the core caller + * can drop sparse_irq_lock. + */ + while (!cpu_online(cpu)) + schedule(); +} + +static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) +{ + int apicid = apic->cpu_present_to_apicid(cpu); int err; lockdep_assert_irqs_enabled(); @@ -1142,25 +1189,33 @@ int native_cpu_up(unsigned int cpu, stru return err; err = do_boot_cpu(apicid, cpu, tidle); - if (err) { + if (err) pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); - return err; - } - /* - * Check TSC synchronization with the AP (keep irqs disabled - * while doing so): - */ - local_irq_save(flags); - check_tsc_sync_source(cpu); - local_irq_restore(flags); + return err; +} - while (!cpu_online(cpu)) { - cpu_relax(); - touch_nmi_watchdog(); - } +int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +{ + int ret; - return 0; + ret = native_kick_ap(cpu, tidle); + if (ret) + goto out; + + ret = wait_cpu_initialized(cpu); + if (ret) + goto out; + + wait_cpu_callin(cpu); + wait_cpu_online(cpu); + +out: + /* Cleanup possible dangling ends... */ + if (x86_platform.legacy.warm_reset) + smpboot_restore_warm_reset_vector(); + + return ret; } /** From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521270.809815 (Exim 4.92) (envelope-from ) id 1pnT5j-0003W4-Sl; Fri, 14 Apr 2023 23:44:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521270.809815; Fri, 14 Apr 2023 23:44:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5j-0003VW-LV; Fri, 14 Apr 2023 23:44:31 +0000 Received: by outflank-mailman (input) for mailman id 521270; Fri, 14 Apr 2023 23:44:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5i-0000zb-Kd for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:30 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c06e6cc-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c06e6cc-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.760351424@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=38vdbwHqBLIqPwRw5MqT+R7Ll28v39Ia/30h9IRZRBU=; b=yar8EeigYdFMdQYEGUNE3USYwkYHZzKxUot+Z73dH900LQv7+iVPCq5P8CJivgiAUZW2OK 5b+Jgl5VWXA9zRjgQQpg9e2anhCtGANLrAGNoR9f6XmdTQzBRqsWpTTXFoZzvs8Un4b+Cd xQVtcABhcUTk8fKAr801BiQCOwMb7/BograiZPjfOPVUBCanspJXyCAKU5TMrWkY70q3Vf aRByfCqKTLqDcO3ENb28nyzgihvUsSGw62p4CXRy+qfa3By2TlFWN34HGdXMCTwJbS74gF n5JJnrI5zbLFVOG1tHdxNahBhTnqNGAQsLPfDS+q8FOpyMYAyy0JyNMiAMEw8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=38vdbwHqBLIqPwRw5MqT+R7Ll28v39Ia/30h9IRZRBU=; b=MftkEADdginftZmZ+/cCkpBXX8KUjRl1mx3aoGgqqGTOVFHczgdVkY20eVN/Z+ePOHG5TU YFmw4iY8ytDodjDg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 09/37] x86/smpboot: Get rid of cpu_init_secondary() References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:28 +0200 (CEST) The synchronization of the AP with the control CPU is a SMP boot problem and has nothing to do with cpu_init(). Open code cpu_init_secondary() in start_secondary() and move wait_for_master_cpu() into the SMP boot code. No functional change. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/processor.h | 1 - arch/x86/kernel/cpu/common.c | 27 --------------------------- arch/x86/kernel/smpboot.c | 24 +++++++++++++++++++----- 3 files changed, 19 insertions(+), 33 deletions(-) --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -551,7 +551,6 @@ extern void switch_gdt_and_percpu_base(i extern void load_direct_gdt(int); extern void load_fixmap_gdt(int); extern void cpu_init(void); -extern void cpu_init_secondary(void); extern void cpu_init_exception_handling(void); extern void cr4_init(void); --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2122,19 +2122,6 @@ static void dbg_restore_debug_regs(void) #define dbg_restore_debug_regs() #endif /* ! CONFIG_KGDB */ -static void wait_for_master_cpu(int cpu) -{ -#ifdef CONFIG_SMP - /* - * wait for ACK from master CPU before continuing - * with AP initialization - */ - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) - cpu_relax(); -#endif -} - static inline void setup_getcpu(int cpu) { unsigned long cpudata = vdso_encode_cpunode(cpu, early_cpu_to_node(cpu)); @@ -2238,8 +2225,6 @@ void cpu_init(void) struct task_struct *cur = current; int cpu = raw_smp_processor_id(); - wait_for_master_cpu(cpu); - ucode_cpu_init(cpu); #ifdef CONFIG_NUMA @@ -2292,18 +2277,6 @@ void cpu_init(void) load_fixmap_gdt(cpu); } -#ifdef CONFIG_SMP -void cpu_init_secondary(void) -{ - /* - * Relies on the BP having set-up the IDT tables, which are loaded - * on this CPU in cpu_init_exception_handling(). - */ - cpu_init_exception_handling(); - cpu_init(); -} -#endif - #ifdef CONFIG_MICROCODE_LATE_LOADING /** * store_cpu_caps() - Store a snapshot of CPU capabilities --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -220,6 +220,17 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } +static void wait_for_master_cpu(int cpu) +{ + /* + * Wait for release by control CPU before continuing with AP + * initialization. + */ + WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); + while (!cpumask_test_cpu(cpu, cpu_callout_mask)) + cpu_relax(); +} + /* * Activate a secondary processor. */ @@ -237,13 +248,16 @@ static void notrace start_secondary(void load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif + cpu_init_exception_handling(); + /* - * Sync point with wait_cpu_initialized(). Before proceeding through - * cpu_init(), the AP will call wait_for_master_cpu() which sets its - * own bit in cpu_initialized_mask and then waits for the BSP to set - * its bit in cpu_callout_mask to release it. + * Sync point with wait_cpu_initialized(). Sets AP in + * cpu_initialized_mask and then waits for the control CPU + * to release it. */ - cpu_init_secondary(); + wait_for_master_cpu(raw_smp_processor_id()); + + cpu_init(); rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521271.809824 (Exim 4.92) (envelope-from ) id 1pnT5l-0003pD-H5; Fri, 14 Apr 2023 23:44:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521271.809824; Fri, 14 Apr 2023 23:44:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5l-0003od-81; Fri, 14 Apr 2023 23:44:33 +0000 Received: by outflank-mailman (input) for mailman id 521271; Fri, 14 Apr 2023 23:44:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5k-0000zb-40 for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4cea9c1a-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cea9c1a-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232309.823800249@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=u2pIwytrv1vZgLx+4s6Zqq6fs8EHbK9BS70kDc1o//Q=; b=tj9xEvgya1srEI62cuunab7v24wBazw6wpcxMtpv79720yev1kGcsEOxNFRId8qJ8lqNgr q1f11vM+Nc4aB4NgnBxR6tIQfQU2iMcMUeRzBxRZmT8RWJKM3p19eh3Ukgff4IpPXHAAmQ OLzNAKEJS2vpJEbsoOLlJHaRdWtjNT4f1mD1+bDAcp/oan26jOAxfnbm6Tpuvt1St80R8P dPrGNEb4Zg6w49Q/eELNuFnnuSnEIQhX8h7OuWa4y9Uk6de034h6Q46GBDo6gmOK33DmEP YQXfDKPvV28Xy5XOo7nZYu9OBqWv20e7LFSwhwcY173bD1coDcsMG/2Q9JSTZg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=u2pIwytrv1vZgLx+4s6Zqq6fs8EHbK9BS70kDc1o//Q=; b=YNu0rancrP7gWuufcUKxrEH7bo8bWOmpZPxm7N3EMgjD1anaBUmHq23Qv/x7FzdBfUPs2b nJi2pgQCB1pCr2DA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 10/37] x86/cpu/cacheinfo: Remove cpu_callout_mask dependency References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:29 +0200 (CEST) cpu_callout_mask is used for the stop machine based MTRR/PAT init. In preparation of moving the BP/AP synchronization to the core hotplug code, use a private CPU mask for cacheinfo and manage it in the starting/dying hotplug state. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/cacheinfo.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -39,6 +39,8 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t /* Shared L2 cache maps */ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_l2c_shared_map); +static cpumask_var_t cpu_cacheinfo_mask; + /* Kernel controls MTRR and/or PAT MSRs. */ unsigned int memory_caching_control __ro_after_init; @@ -1172,8 +1174,10 @@ void cache_bp_restore(void) cache_cpu_init(); } -static int cache_ap_init(unsigned int cpu) +static int cache_ap_online(unsigned int cpu) { + cpumask_set_cpu(cpu, cpu_cacheinfo_mask); + if (!memory_caching_control || get_cache_aps_delayed_init()) return 0; @@ -1191,11 +1195,17 @@ static int cache_ap_init(unsigned int cp * lock to prevent MTRR entry changes */ stop_machine_from_inactive_cpu(cache_rendezvous_handler, NULL, - cpu_callout_mask); + cpu_cacheinfo_mask); return 0; } +static int cache_ap_offline(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, cpu_cacheinfo_mask); + return 0; +} + /* * Delayed cache initialization for all AP's */ @@ -1210,9 +1220,12 @@ void cache_aps_init(void) static int __init cache_ap_register(void) { + zalloc_cpumask_var(&cpu_cacheinfo_mask, GFP_KERNEL); + cpumask_set_cpu(smp_processor_id(), cpu_cacheinfo_mask); + cpuhp_setup_state_nocalls(CPUHP_AP_CACHECTRL_STARTING, "x86/cachectrl:starting", - cache_ap_init, NULL); + cache_ap_online, cache_ap_offline); return 0; } -core_initcall(cache_ap_register); +early_initcall(cache_ap_register); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521272.809834 (Exim 4.92) (envelope-from ) id 1pnT5n-0004CB-4H; Fri, 14 Apr 2023 23:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521272.809834; Fri, 14 Apr 2023 23:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5m-0004AO-T8; Fri, 14 Apr 2023 23:44:34 +0000 Received: by outflank-mailman (input) for mailman id 521272; Fri, 14 Apr 2023 23:44:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5k-0001Th-Ss for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4dfd662d-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dfd662d-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232309.886802016@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/ZK0+aYTDprGh+TLZnlXwtj4Vfn8D4d3BT+xMJ2O4BY=; b=vjkoNmrHuvgLnadmWDBQsaj4074jsURhSMcG/y+SAv5U7Hjl873Sfi0Y38vZ0CiBW30lkc YSRug6WOf+XkPtW/Ok7DfLfUey146jL84NdowhhogdHAP/UKxbH2eo4JQjN009SbEVnvNW 1zv9NUb4vEW1lio3uk0/iDb4xih4TRxA+1g65l9y4CxPj9/vIKfhtqspZBp17LHEOMwTUs uqFNHzjdehaY7LPLRMdLZxqYkTGv4zrW/lRcOci3KT4V49tXaioV61gsRoQXocuqUqCvtS KqU2xIzYJQYvtQyq2IG1EFa3XvWD9GUEZsifVyZD2YZ/wz91ynh5mZJDMN6fTQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/ZK0+aYTDprGh+TLZnlXwtj4Vfn8D4d3BT+xMJ2O4BY=; b=5l86SHxSNU5XjxfrY2KYmiaNiv7XnFBAOMn0HfeVzwcXghypKkHnPtf+Boxw8mjzqZQmUJ Sn14SMUAF/D/3pAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 11/37] x86/smpboot: Move synchronization masks to SMP boot code References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:31 +0200 (CEST) The usage is in smpboot.c and not in the CPU initialization code. The XEN_PV usage of cpu_callout_mask is obsolete as cpu_init() not longer waits and cacheinfo has its own CPU mask now, so cpu_callout_mask can be made static too. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/cpumask.h | 5 ----- arch/x86/kernel/cpu/common.c | 17 ----------------- arch/x86/kernel/smpboot.c | 16 ++++++++++++++++ arch/x86/xen/smp_pv.c | 3 --- 4 files changed, 16 insertions(+), 25 deletions(-) --- a/arch/x86/include/asm/cpumask.h +++ b/arch/x86/include/asm/cpumask.h @@ -4,11 +4,6 @@ #ifndef __ASSEMBLY__ #include -extern cpumask_var_t cpu_callin_mask; -extern cpumask_var_t cpu_callout_mask; -extern cpumask_var_t cpu_initialized_mask; -extern cpumask_var_t cpu_sibling_setup_mask; - extern void setup_cpu_local_masks(void); /* --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -67,14 +67,6 @@ u32 elf_hwcap2 __read_mostly; -/* all of these masks are initialized in setup_cpu_local_masks() */ -cpumask_var_t cpu_initialized_mask; -cpumask_var_t cpu_callout_mask; -cpumask_var_t cpu_callin_mask; - -/* representing cpus for which sibling maps can be computed */ -cpumask_var_t cpu_sibling_setup_mask; - /* Number of siblings per CPU package */ int smp_num_siblings = 1; EXPORT_SYMBOL(smp_num_siblings); @@ -168,15 +160,6 @@ static void ppin_init(struct cpuinfo_x86 clear_cpu_cap(c, info->feature); } -/* correctly size the local cpu masks */ -void __init setup_cpu_local_masks(void) -{ - alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callin_mask); - alloc_bootmem_cpumask_var(&cpu_callout_mask); - alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); -} - static void default_init(struct cpuinfo_x86 *c) { #ifdef CONFIG_X86_64 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -101,6 +101,13 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); +/* All of these masks are initialized in setup_cpu_local_masks() */ +static cpumask_var_t cpu_initialized_mask; +static cpumask_var_t cpu_callout_mask; +static cpumask_var_t cpu_callin_mask; +/* Representing CPUs for which sibling maps can be computed */ +static cpumask_var_t cpu_sibling_setup_mask; + /* Logical package management. We might want to allocate that dynamically */ unsigned int __max_logical_packages __read_mostly; EXPORT_SYMBOL(__max_logical_packages); @@ -1548,6 +1555,15 @@ early_param("possible_cpus", _setup_poss set_cpu_possible(i, true); } +/* correctly size the local cpu masks */ +void __init setup_cpu_local_masks(void) +{ + alloc_bootmem_cpumask_var(&cpu_initialized_mask); + alloc_bootmem_cpumask_var(&cpu_callin_mask); + alloc_bootmem_cpumask_var(&cpu_callout_mask); + alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); +} + #ifdef CONFIG_HOTPLUG_CPU /* Recompute SMT state for all CPUs on offline */ --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -254,15 +254,12 @@ cpu_initialize_context(unsigned int cpu, struct desc_struct *gdt; unsigned long gdt_mfn; - /* used to tell cpu_init() that it can proceed with initialization */ - cpumask_set_cpu(cpu, cpu_callout_mask); if (cpumask_test_and_set_cpu(cpu, xen_cpu_initialized_map)) return 0; ctxt = kzalloc(sizeof(*ctxt), GFP_KERNEL); if (ctxt == NULL) { cpumask_clear_cpu(cpu, xen_cpu_initialized_map); - cpumask_clear_cpu(cpu, cpu_callout_mask); return -ENOMEM; } From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521273.809840 (Exim 4.92) (envelope-from ) id 1pnT5n-0004KA-R7; Fri, 14 Apr 2023 23:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521273.809840; Fri, 14 Apr 2023 23:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5n-0004HW-GB; Fri, 14 Apr 2023 23:44:35 +0000 Received: by outflank-mailman (input) for mailman id 521273; Fri, 14 Apr 2023 23:44:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5m-0001Th-CM for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:34 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4edf5eb0-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4edf5eb0-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232309.948211096@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=vYiQOFtP2lP/XNgK/P8qTVjY7wF3a2V1zLIb771O4ZM=; b=ozP/whFRJCNtzWtZf47EwOD3ctF5Yl7nBhhPFmfGOp3vNuB6ZYseZErnaJuxpU20wGHlVt aTZzyJkMmm5NdQRvyG+n9diEY1Th1N+/hNKcN5FC+5wvr+HXD2qTAouaqdTP1xuZf9HF0k M58CetJX/We25l+wDbpp+iFsAladFY6A+8V0DeXEQPBkTYzbCTvagMj54yMvSeCmqTBY8B NuJdxqnKhTdSvfyUvbfD7TzIVkuVpe2zLY9+oBadLQdJiEqE/pGfpKmP3r5+H23H6uRJJs iN3tSKES7XyjbX1WXywuTqJ797O7g2NsRouRI92YsdfZkjPlG9hwc3S8b4FTCw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=vYiQOFtP2lP/XNgK/P8qTVjY7wF3a2V1zLIb771O4ZM=; b=OXd3Ubv1MGKAClArDXPNKshLMJqlxJq7sB82Sa9cgrlhWYCSXIxBkFLh2ALnT54B63KCKg PsqQBV4ALo0t5yBQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 12/37] x86/smpboot: Make TSC synchronization function call based References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:32 +0200 (CEST) Spin-waiting on the control CPU until the AP reaches the TSC synchronization is just a waste especially in the case that there is no synchronization required. As the synchronization has to run with interrupts disabled the control CPU part can just be done from a SMP function call. The upcoming AP issues that call async only in the case that synchronization is required. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/tsc.h | 2 -- arch/x86/kernel/smpboot.c | 20 +++----------------- arch/x86/kernel/tsc_sync.c | 36 +++++++++++------------------------- 3 files changed, 14 insertions(+), 44 deletions(-) --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -55,12 +55,10 @@ extern bool tsc_async_resets; #ifdef CONFIG_X86_TSC extern bool tsc_store_and_check_tsc_adjust(bool bootcpu); extern void tsc_verify_tsc_adjust(bool resume); -extern void check_tsc_sync_source(int cpu); extern void check_tsc_sync_target(void); #else static inline bool tsc_store_and_check_tsc_adjust(bool bootcpu) { return false; } static inline void tsc_verify_tsc_adjust(bool resume) { } -static inline void check_tsc_sync_source(int cpu) { } static inline void check_tsc_sync_target(void) { } #endif --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -278,11 +278,7 @@ static void notrace start_secondary(void /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ barrier(); - /* - * Check TSC synchronization with the control CPU, which will do - * its part of this from wait_cpu_online(), making it an implicit - * synchronization point. - */ + /* Check TSC synchronization with the control CPU. */ check_tsc_sync_target(); /* @@ -1144,21 +1140,11 @@ static void wait_cpu_callin(unsigned int } /* - * Bringup step four: Synchronize the TSC and wait for the target AP - * to reach set_cpu_online() in start_secondary(). + * Bringup step four: Wait for the target AP to reach set_cpu_online() in + * start_secondary(). */ static void wait_cpu_online(unsigned int cpu) { - unsigned long flags; - - /* - * Check TSC synchronization with the AP (keep irqs disabled - * while doing so): - */ - local_irq_save(flags); - check_tsc_sync_source(cpu); - local_irq_restore(flags); - /* * Wait for the AP to mark itself online, so the core caller * can drop sparse_irq_lock. --- a/arch/x86/kernel/tsc_sync.c +++ b/arch/x86/kernel/tsc_sync.c @@ -245,7 +245,6 @@ bool tsc_store_and_check_tsc_adjust(bool */ static atomic_t start_count; static atomic_t stop_count; -static atomic_t skip_test; static atomic_t test_runs; /* @@ -344,21 +343,14 @@ static inline unsigned int loop_timeout( } /* - * Source CPU calls into this - it waits for the freshly booted - * target CPU to arrive and then starts the measurement: + * The freshly booted CPU initiates this via an async SMP function call. */ -void check_tsc_sync_source(int cpu) +static void check_tsc_sync_source(void *__cpu) { + unsigned int cpu = (unsigned long)__cpu; int cpus = 2; /* - * No need to check if we already know that the TSC is not - * synchronized or if we have no TSC. - */ - if (unsynchronized_tsc()) - return; - - /* * Set the maximum number of test runs to * 1 if the CPU does not provide the TSC_ADJUST MSR * 3 if the MSR is available, so the target can try to adjust @@ -368,16 +360,9 @@ void check_tsc_sync_source(int cpu) else atomic_set(&test_runs, 3); retry: - /* - * Wait for the target to start or to skip the test: - */ - while (atomic_read(&start_count) != cpus - 1) { - if (atomic_read(&skip_test) > 0) { - atomic_set(&skip_test, 0); - return; - } + /* Wait for the target to start. */ + while (atomic_read(&start_count) != cpus - 1) cpu_relax(); - } /* * Trigger the target to continue into the measurement too: @@ -397,14 +382,14 @@ void check_tsc_sync_source(int cpu) if (!nr_warps) { atomic_set(&test_runs, 0); - pr_debug("TSC synchronization [CPU#%d -> CPU#%d]: passed\n", + pr_debug("TSC synchronization [CPU#%d -> CPU#%u]: passed\n", smp_processor_id(), cpu); } else if (atomic_dec_and_test(&test_runs) || random_warps) { /* Force it to 0 if random warps brought us here */ atomic_set(&test_runs, 0); - pr_warn("TSC synchronization [CPU#%d -> CPU#%d]:\n", + pr_warn("TSC synchronization [CPU#%d -> CPU#%u]:\n", smp_processor_id(), cpu); pr_warn("Measured %Ld cycles TSC warp between CPUs, " "turning off TSC clock.\n", max_warp); @@ -457,11 +442,12 @@ void check_tsc_sync_target(void) * SoCs the TSC is frequency synchronized, but still the TSC ADJUST * register might have been wreckaged by the BIOS.. */ - if (tsc_store_and_check_tsc_adjust(false) || tsc_clocksource_reliable) { - atomic_inc(&skip_test); + if (tsc_store_and_check_tsc_adjust(false) || tsc_clocksource_reliable) return; - } + /* Kick the control CPU into the TSC synchronization function */ + smp_call_function_single(cpumask_first(cpu_online_mask), check_tsc_sync_source, + (unsigned long *)(unsigned long)cpu, 0); retry: /* * Register this CPU's participation and wait for the From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521274.809852 (Exim 4.92) (envelope-from ) id 1pnT5r-00058F-H2; Fri, 14 Apr 2023 23:44:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521274.809852; Fri, 14 Apr 2023 23:44:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5q-00051G-KI; Fri, 14 Apr 2023 23:44:38 +0000 Received: by outflank-mailman (input) for mailman id 521274; Fri, 14 Apr 2023 23:44:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5o-0001Th-1b for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:36 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4fdcf5be-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fdcf5be-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.010585365@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=o+IIZolWdFzFoKPnCYeSD1bdkqJKKR73ExqiLPCERDI=; b=YtXMog5VLahh+j7fmWogAvr6ObdCeMs2/pQmIXREKblleGoCtvJL4rCNiqdvWzbyjDcTRQ uiN2/aQVEAqhEyWPSPIkKx0AVkXmtnjjoHfjwT3/yh44khK5MSa6L7h2bJz7b22ZDlJ6sh 00pAwnPCUJWCsn2Ejc57QMUUvq4xsRjx3LwBphTuReLzL6PmYvBpWBQh7nPpyk6UmRKfhO 2Eee0WLf6JgST16c76h3RPniWFIj95CGMwloYJMAwCCsO+gfqOq1rnGnjyKNvGqHT1gYGv P1F3HkYh07cMCdG7gc3D1VPgXDTVfI3a8otMhGht4nwU8AdufkquSsBkf+sOZA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=o+IIZolWdFzFoKPnCYeSD1bdkqJKKR73ExqiLPCERDI=; b=/GA3IGAqyXeZ0ie5H89dtUrqgSL/9oSjEmZXWUtsSX1UpgcGxjRjqmWWhXVPw2ws/g8YlI DVurnNfTpyXvJvDg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 13/37] x86/smpboot: Remove cpu_callin_mask References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:34 +0200 (CEST) Now that TSC synchronization is SMP function call based there is no reason to wait for the AP to be set in smp_callin_mask. The control CPU waits for the AP to set itself in the online mask anyway. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 61 +++++++--------------------------------------- 1 file changed, 10 insertions(+), 51 deletions(-) --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -104,7 +104,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_info); /* All of these masks are initialized in setup_cpu_local_masks() */ static cpumask_var_t cpu_initialized_mask; static cpumask_var_t cpu_callout_mask; -static cpumask_var_t cpu_callin_mask; /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -167,21 +166,16 @@ static inline void smpboot_restore_warm_ */ static void smp_callin(void) { - int cpuid; + int cpuid = smp_processor_id(); /* * If waken up by an INIT in an 82489DX configuration - * cpu_callout_mask guarantees we don't get here before - * an INIT_deassert IPI reaches our local APIC, so it is - * now safe to touch our local APIC. - */ - cpuid = smp_processor_id(); - - /* - * the boot CPU has finished the init stage and is spinning - * on callin_map until we finish. We are free to set up this - * CPU, first the APIC. (this is probably redundant on most - * boards) + * cpu_callout_mask guarantees we don't get here before an + * INIT_deassert IPI reaches our local APIC, so it is now safe to + * touch our local APIC. + * + * Set up this CPU, first the APIC, which is probably redundant on + * most boards. */ apic_ap_setup(); @@ -192,7 +186,7 @@ static void smp_callin(void) * The topology information must be up to date before * calibrate_delay() and notify_cpu_starting(). */ - set_cpu_sibling_map(raw_smp_processor_id()); + set_cpu_sibling_map(cpuid); ap_init_aperfmperf(); @@ -205,11 +199,6 @@ static void smp_callin(void) * state (CPUHP_ONLINE in the case of serial bringup). */ notify_cpu_starting(cpuid); - - /* - * Allow the master to continue. - */ - cpumask_set_cpu(cpuid, cpu_callin_mask); } static void ap_calibrate_delay(void) @@ -268,11 +257,6 @@ static void notrace start_secondary(void rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); - /* - * Sync point with wait_cpu_callin(). The AP doesn't wait here - * but just sets the bit to let the controlling CPU (BSP) know that - * it's got this far. - */ smp_callin(); /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ @@ -1112,7 +1096,7 @@ static int wait_cpu_cpumask(unsigned int * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it * to proceed. The AP will then proceed past setting its 'callin' bit * and end up waiting in check_tsc_sync_target() until we reach - * do_wait_cpu_online() to tend to it. + * wait_cpu_online() to tend to it. */ static int wait_cpu_initialized(unsigned int cpu) { @@ -1127,20 +1111,7 @@ static int wait_cpu_initialized(unsigned } /* - * Bringup step three: Wait for the target AP to reach smp_callin(). - * The AP is not waiting for us here so we don't need to parallelise - * this step. Not entirely clear why we care about this, since we just - * proceed directly to TSC synchronization which is the next sync - * point with the AP anyway. - */ -static void wait_cpu_callin(unsigned int cpu) -{ - while (!cpumask_test_cpu(cpu, cpu_callin_mask)) - schedule(); -} - -/* - * Bringup step four: Wait for the target AP to reach set_cpu_online() in + * Bringup step three: Wait for the target AP to reach set_cpu_online() in * start_secondary(). */ static void wait_cpu_online(unsigned int cpu) @@ -1170,14 +1141,6 @@ static int native_kick_ap(unsigned int c } /* - * Already booted CPU? - */ - if (cpumask_test_cpu(cpu, cpu_callin_mask)) { - pr_debug("do_boot_cpu %d Already started\n", cpu); - return -ENOSYS; - } - - /* * Save current MTRR state in case it was changed since early boot * (e.g. by the ACPI SMI) to initialize new CPUs with MTRRs in sync: */ @@ -1214,7 +1177,6 @@ int native_cpu_up(unsigned int cpu, stru if (ret) goto out; - wait_cpu_callin(cpu); wait_cpu_online(cpu); out: @@ -1330,7 +1292,6 @@ void __init smp_prepare_cpus_common(void * Setup boot CPU information */ smp_store_boot_cpu_info(); /* Final full version of the data */ - cpumask_copy(cpu_callin_mask, cpumask_of(0)); mb(); for_each_possible_cpu(i) { @@ -1545,7 +1506,6 @@ early_param("possible_cpus", _setup_poss void __init setup_cpu_local_masks(void) { alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callin_mask); alloc_bootmem_cpumask_var(&cpu_callout_mask); alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); } @@ -1609,7 +1569,6 @@ static void remove_cpu_from_maps(int cpu { set_cpu_online(cpu, false); cpumask_clear_cpu(cpu, cpu_callout_mask); - cpumask_clear_cpu(cpu, cpu_callin_mask); /* was set by cpu_init() */ cpumask_clear_cpu(cpu, cpu_initialized_mask); numa_remove_cpu(cpu); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521276.809859 (Exim 4.92) (envelope-from ) id 1pnT5t-0005Vp-5w; Fri, 14 Apr 2023 23:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521276.809859; Fri, 14 Apr 2023 23:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5s-0005Q2-CP; Fri, 14 Apr 2023 23:44:40 +0000 Received: by outflank-mailman (input) for mailman id 521276; Fri, 14 Apr 2023 23:44:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5p-0001Th-Fd for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:37 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50c924e4-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50c924e4-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.073038650@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=GyywxqWp8oXO9/e7syapChEN4EQiJFDwV+0SUoqcKJk=; b=JUqSST6sUfcIWAgxhbacXjpEmmObS6IQmZ8ClrGYKz6doTL5ISmvBQwKyUHTzWuCMn0jQ2 kxURDWFhZo9th4otAi+IQxUNu4L5D+QqiOZWbyNzW73qnBtuAg4kKtwBnKA13ZEyQuUA3X 24NTR55n5XqMxhu41NV27bpjHdQ+JlbVY0oF+P/tIz60xJTXSar+rkM76hsA2KCV9DFE63 6moUS8v6t62b1FyFg672g0WX5bUvfVeqnGzGFuSCL/S0/rzXi15l7IZ4fLWeFV2skFwkBv DN49AN17nBshRWNeN2Y+3WWvPRAiTBVV4LsFXW/N5eBDDmUXpiGL65/32uCbZA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=GyywxqWp8oXO9/e7syapChEN4EQiJFDwV+0SUoqcKJk=; b=snqZUI4TE1G36IaRc7SXm3rJmNJDzjCApFmrXGG7j+LkkvHa7rApiOe1UgrCEuxcVgy8d4 n0QkZCVyncqid6Dw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 14/37] cpu/hotplug: Rework sparse_irq locking in bringup_cpu() References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:36 +0200 (CEST) There is no harm to hold sparse_irq lock until the upcoming CPU completes in cpuhp_online_idle(). This allows to remove cpu_online() synchronization from architecture code. Signed-off-by: Thomas Gleixner --- kernel/cpu.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -558,7 +558,7 @@ static int cpuhp_kick_ap(int cpu, struct return ret; } -static int bringup_wait_for_ap(unsigned int cpu) +static int bringup_wait_for_ap_online(unsigned int cpu) { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); @@ -579,15 +579,12 @@ static int bringup_wait_for_ap(unsigned */ if (!cpu_smt_allowed(cpu)) return -ECANCELED; - - if (st->target <= CPUHP_AP_ONLINE_IDLE) - return 0; - - return cpuhp_kick_ap(cpu, st, st->target); + return 0; } static int bringup_cpu(unsigned int cpu) { + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); struct task_struct *idle = idle_thread_get(cpu); int ret; @@ -606,10 +603,23 @@ static int bringup_cpu(unsigned int cpu) /* Arch-specific enabling code. */ ret = __cpu_up(cpu, idle); - irq_unlock_sparse(); if (ret) - return ret; - return bringup_wait_for_ap(cpu); + goto out_unlock; + + ret = bringup_wait_for_ap_online(cpu); + if (ret) + goto out_unlock; + + irq_unlock_sparse(); + + if (st->target <= CPUHP_AP_ONLINE_IDLE) + return 0; + + return cpuhp_kick_ap(cpu, st, st->target); + +out_unlock: + irq_unlock_sparse(); + return ret; } static int finish_cpu(unsigned int cpu) From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521277.809862 (Exim 4.92) (envelope-from ) id 1pnT5t-0005hZ-Lh; Fri, 14 Apr 2023 23:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521277.809862; Fri, 14 Apr 2023 23:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5t-0005cc-8h; Fri, 14 Apr 2023 23:44:41 +0000 Received: by outflank-mailman (input) for mailman id 521277; Fri, 14 Apr 2023 23:44:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5r-0001Th-1T for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:39 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51b6e0db-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51b6e0db-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.133063984@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IXf0ZnAk7Rjoer1aZheyf4W/cuBQpAE5Qx39Wnoq+gw=; b=tCHY6jxHe44QdTi6vocnhUhZC/Sr8ssG31Dn8gwv5SQPDPmECHh8SvAHIYmNtqHfMlkDjb 5z/JlKFS3jn11K/mH/g/+Ow73N4W+vlAAEOR14IBfVSLYSUt09dUYIaE4ilEgx1gRiYou/ NJW3slP7Xaephbtnct1+NjMkcY39oSmvHRscafuLnWIYw0ZXn5+nds4CQ9+gIajjenAhxm MpSUlozCRJ6mr8ZNsIclfZsK1CWaX+//qVVkJTb566EfkmD5lkZR5KlXMt2cJLL6tWRV4l KlYtfdAt7sssM4QTlY+1m/BpDXqcWMvO6p1Ofmu+gKrgTD9Ra18H8OqOESasOQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IXf0ZnAk7Rjoer1aZheyf4W/cuBQpAE5Qx39Wnoq+gw=; b=ZRExhqz5gVYg/2ZXmu04kZ6TddbP4xfwFZiD+kT/UslGyVveAnCubA4h2r17G4cgTnxl1O +W+htaNbUUPcKRAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 15/37] x86/smpboot: Remove wait for cpu_online() References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:37 +0200 (CEST) Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1110,20 +1110,6 @@ static int wait_cpu_initialized(unsigned return 0; } -/* - * Bringup step three: Wait for the target AP to reach set_cpu_online() in - * start_secondary(). - */ -static void wait_cpu_online(unsigned int cpu) -{ - /* - * Wait for the AP to mark itself online, so the core caller - * can drop sparse_irq_lock. - */ - while (!cpu_online(cpu)) - schedule(); -} - static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); @@ -1170,16 +1156,9 @@ int native_cpu_up(unsigned int cpu, stru int ret; ret = native_kick_ap(cpu, tidle); - if (ret) - goto out; - - ret = wait_cpu_initialized(cpu); - if (ret) - goto out; - - wait_cpu_online(cpu); + if (!ret) + ret = wait_cpu_initialized(cpu); -out: /* Cleanup possible dangling ends... */ if (x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521282.809879 (Exim 4.92) (envelope-from ) id 1pnT5w-0006bQ-NE; Fri, 14 Apr 2023 23:44:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521282.809879; Fri, 14 Apr 2023 23:44:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5w-0006Zl-Ap; Fri, 14 Apr 2023 23:44:44 +0000 Received: by outflank-mailman (input) for mailman id 521282; Fri, 14 Apr 2023 23:44:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5t-0000zb-Ls for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:41 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52adff75-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52adff75-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.194293270@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=U86WQCD4/7f+Xqtkcp8tab/f3Qs5fwP9mDOYJzY6GfM=; b=jVIvfWfMQ/Mv7TLWicCCZIBuoCNHTQbWP9agDzTG7YCSq254hUFkclQNrmhW3hMxwO6BPK vpCyMRIt4O1v+XPm4hgw1E/lo8bQ+TLMoWfNV6id2wkbLsusQC6+QgLxHkmM7jqI5M1i8u WMWTwhPBiMRMlROawAHv6lnZ2lJwgt69Ha2d7Hel7C6kpu8UPNf7d9bEsHq2W4HMj8o6m6 dmaviMmKfYNuICvE6NIhMG4fkMK+1VZcm9tvKGIXKcaFCzlTUjXnuorDCoZhFXx/Hy5zi8 WucVMkf4GaCQOYOvuAmNqRgA5o2nLyY6ILSN9/5KO2/baOF9ZKuCj7IpPwPGyQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=U86WQCD4/7f+Xqtkcp8tab/f3Qs5fwP9mDOYJzY6GfM=; b=bwxgSYDBNDOQrQ9qYJjd5x62eInfveDh14CbqLzga+9pzOoPfQod/ugWmc+ORstEOs2az4 q8XHnTNdR1jM1HBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, David Woodhouse , Usama Arif , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 16/37] x86/xen/smp_pv: Remove wait for CPU online References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:39 +0200 (CEST) Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Whether the control CPU runs in a wait loop or sleeps in the core code waiting for the online operation to complete makes no difference. Signed-off-by: Thomas Gleixner Cc: Juergen Gross Cc: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org --- arch/x86/xen/smp_pv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -340,11 +340,11 @@ static int xen_pv_cpu_up(unsigned int cp xen_pmu_init(cpu); - rc = HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL); - BUG_ON(rc); - - while (cpu_report_state(cpu) != CPU_ONLINE) - HYPERVISOR_sched_op(SCHEDOP_yield, NULL); + /* + * Why is this a BUG? If the hypercall fails then everything can be + * rolled back, no? + */ + BUG_ON(HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL)); return 0; } From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:44:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:44:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521285.809885 (Exim 4.92) (envelope-from ) id 1pnT5x-0006kf-Gk; Fri, 14 Apr 2023 23:44:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521285.809885; Fri, 14 Apr 2023 23:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5w-0006jJ-Sf; Fri, 14 Apr 2023 23:44:44 +0000 Received: by outflank-mailman (input) for mailman id 521285; Fri, 14 Apr 2023 23:44:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5v-0000zb-Cg for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:43 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53a62147-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53a62147-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.256412375@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=e1FMo66EmKhD6c9vNMbCMEr10b7nb30z1HTBJhSwsws=; b=gZ0HEhv3acCl5QBYyuBxsWswUfiT2pTSEiPx8KAuYf607AwMRXvsLBlYW5dljp8oWs/ntm Rl62blc06B+wdYag6mxiaHF4d6UazbaaiGafHMeetJ/A7Hs5RVhUzMngs/dEe59idC0O2F aA4jOVKszqOh4s2mn+PKplYpnPle5vYAOnMKw27lKXhJvIh/kbhLy4lRj7cXXA/G581Bej PsarGBYF6AEmBjKJMVj8L9q7SGw5rle2qMtTuVh6V6kezaC/bwaovVLX9d1Zsm+GX8ANmu PhMCi/IYxY/Oqm30JTDcZDBgs/Y7EGdHwcz8miDR/Arr0Wrr//IGKwmjd5YAMQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=e1FMo66EmKhD6c9vNMbCMEr10b7nb30z1HTBJhSwsws=; b=4fNwIQeLJaYUXs5/LQAEGEGLbWkObI//eYOHt1swXrTx799wwKeZFlTzry5MJCiAr70s7q ypFOiCNeSLElyzBg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, David Woodhouse , Usama Arif , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 17/37] x86/xen/hvm: Get rid of DEAD_FROZEN handling References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:41 +0200 (CEST) No point in this conditional voodoo. Un-initializing the lock mechanism is safe to be called unconditionally even if it was already invoked when the CPU died. Remove the invocation of xen_smp_intr_free() as that has been already cleaned up in xen_cpu_dead_hvm(). Signed-off-by: Thomas Gleixner Cc: Juergen Gross Cc: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org --- arch/x86/xen/enlighten_hvm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -161,13 +161,12 @@ static int xen_cpu_up_prepare_hvm(unsign int rc = 0; /* - * This can happen if CPU was offlined earlier and - * offlining timed out in common_cpu_die(). + * If a CPU was offlined earlier and offlining timed out then the + * lock mechanism is still initialized. Uninit it unconditionally + * as it's safe to call even if already uninited. Interrupts and + * timer have already been handled in xen_cpu_dead_hvm(). */ - if (cpu_report_state(cpu) == CPU_DEAD_FROZEN) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - } + xen_uninit_lock_cpu(cpu); if (cpu_acpi_id(cpu) != U32_MAX) per_cpu(xen_vcpu_id, cpu) = cpu_acpi_id(cpu); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:48:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521288.809905 (Exim 4.92) (envelope-from ) id 1pnTA1-0002kx-NL; Fri, 14 Apr 2023 23:48:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521288.809905; Fri, 14 Apr 2023 23:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTA1-0002kq-KZ; Fri, 14 Apr 2023 23:48:57 +0000 Received: by outflank-mailman (input) for mailman id 521288; Fri, 14 Apr 2023 23:48:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6Q-0000zb-Oh for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:14 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6639473e-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6639473e-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.441918776@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=6cGHgynMBCaHRwYTrISGgGUY8IfBttwd4gSW6/8ncwo=; b=Y6MvVoIRD+b308pDJWowuLkJP8xTk8BgVllbAchtET5SCLxH3pPaTbpOYvBSvJgt29AjQn ezcDEAwpvw4go5HJCn0jDdZCGPT9MLW24qpZKb8kz2KJNNnr6JcyXOPyaUGlM/ANv9N+fq tuEJRuRxzNty3GrkhGsgHYpRhP/0DX3AEiMTFdAHD/hkrve/Z/OGirQHyoZehUi+ZLj2of nh0+zW/XB9E47Zv4MWfj7UgDu31M48dyxxMexXPIhf0Fh2Xfz56PypK/Z4RNZ1QuLpDfkl MzM4X40h1quxb59BK38sroOGy3J6fRyyYS1Nn/XWNH7x+1QZ0XFumeRWVGSB2A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=6cGHgynMBCaHRwYTrISGgGUY8IfBttwd4gSW6/8ncwo=; b=62z6QxHlYDjrTs4WKqbuHCfVc8G+x+AUIAn0i55mZeGFgkDCFd3an/Sr2oboSn6ZUcOcEh Lf1/KZWBw97ffRDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 36/37] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:12 +0200 (CEST) Implement the validation function which tells the core code whether parallel bringup is possible: 1) Valid CPUID leaf for APIC ID retrieval. For non x2APIC systmms leaf 0x1 is sufficient, otherwise leaf 0xb or 0x1f must be available. 2) Prevent parallel bringup on encrypted guests as this requires a different handling of the CPUID leaf retrieval via a call into the trusted firmware module. This is what the #VC trap handler does later on, which is not available during the very early startup. Originally-by: David Woodhouse Signed-off-by: Thomas Gleixner --- arch/x86/Kconfig | 3 +- arch/x86/kernel/cpu/common.c | 6 ----- arch/x86/kernel/smpboot.c | 49 +++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 50 insertions(+), 8 deletions(-) --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -272,8 +272,9 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO + select HOTPLUG_PARALLEL if SMP && X86_64 select HOTPLUG_SMT if SMP - select HOTPLUG_SPLIT_STARTUP if SMP + select HOTPLUG_SPLIT_STARTUP if SMP && X86_32 select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK select NEED_PER_CPU_PAGE_FIRST_CHUNK --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2127,11 +2127,7 @@ static inline void setup_getcpu(int cpu) } #ifdef CONFIG_X86_64 -static inline void ucode_cpu_init(int cpu) -{ - if (cpu) - load_ucode_ap(); -} +static inline void ucode_cpu_init(int cpu) { } static inline void tss_setup_ist(struct tss_struct *tss) { --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -58,6 +58,7 @@ #include #include #include +#include #include #include @@ -75,7 +76,7 @@ #include #include #include -#include +#include #include #include #include @@ -128,7 +129,6 @@ int arch_update_cpu_topology(void) return retval; } - static unsigned int smpboot_warm_reset_vector_count; static inline void smpboot_setup_warm_reset_vector(unsigned long start_eip) @@ -247,6 +247,8 @@ static void notrace start_secondary(void #endif cpu_init_exception_handling(); + load_ucode_ap(); + /* * Sync point with the hotplug core. Sets the sync state to ALIVE * and waits for the control CPU to release it. @@ -1251,6 +1253,49 @@ void __init smp_prepare_cpus_common(void set_cpu_sibling_map(0); } +#ifdef CONFIG_X86_64 +/* Establish whether parallel bringup can be supported. */ +bool __init arch_cpuhp_init_parallel_bringup(void) +{ + unsigned int ctrl; + + if (boot_cpu_data.cpuid_level < 0x01) { + pr_info("Parallel CPU startup disabled due to lack of CPUID\n"); + return false; + } + + /* Encrypted guests require special CPUID handling. */ + if (cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT)) { + pr_info("Parallel CPU startup disabled due to guest state encryption\n"); + return false; + } + + switch (topology_extended_leaf) { + case 0x0b: + ctrl = STARTUP_APICID_CPUID_0B; + break; + case 0x1f: + ctrl = STARTUP_APICID_CPUID_1F; + break; + case 0x00: + /* For !x2APIC mode 8 bits from leaf 0x01 are sufficient. */ + if (!x2apic_mode) { + ctrl = STARTUP_APICID_CPUID_01; + break; + } + fallthrough; + default: + pr_info("Parallel CPU startup disabled. Unsupported topology leaf %u\n", + topology_extended_leaf); + return false; + } + + pr_debug("Parallel CPU startup enabled: 0x%08x\n", ctrl); + smpboot_control = ctrl; + return true; +} +#endif + /* * Prepare for SMP bootup. * @max_cpus: configured maximum number of CPUs, It is a legacy parameter From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521294.809915 (Exim 4.92) (envelope-from ) id 1pnTA7-00033e-V2; Fri, 14 Apr 2023 23:49:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521294.809915; Fri, 14 Apr 2023 23:49:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTA7-00033X-Rb; Fri, 14 Apr 2023 23:49:03 +0000 Received: by outflank-mailman (input) for mailman id 521294; Fri, 14 Apr 2023 23:49:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT68-0000zb-7w for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:56 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57995914-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57995914-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.506665258@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=BWuCF2CiZKIQbbVy6vgpgYODjXTXdK2iLGuwNDfmq40=; b=f+z8dnbF0VfVZ2drfvyKG7CFHH0pFiyt/pWm7ehfcpt37yeWoaaqrXqvZgx9e/X+XvrZce gt4gtyv6t++LGb/9kB1kGkXRTvx7bPDMmlE2YCfC4bhE+s0E3cJidnKxtsU1uFW28KmFrm Eh1JSahdrCC66cB1rpXpEnDQUWYAaCehtBdvR4JcyEbKg1e1N2/wIL2n3XDGfkKj7+6Kc2 i/dgOOZylb3sazc82Iv1WIdzwGBFxWc2QRD+sOwDm8QUeivjB4vTaM4N2GaxbzQoD4goZa 9mik80mRNDqag2mcRqOovhsRU7cr3S59unOU29PAZedSzmpwu0Vl+6WwRIUstA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=BWuCF2CiZKIQbbVy6vgpgYODjXTXdK2iLGuwNDfmq40=; b=HrYkhb/PC8lVyjiszH07tO75RvI9fVkc6wkdtUyyzhBuNuOW308LHInmD5FALuyFMFj8ZV PF23VUQhymsOP5DA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 21/37] ARM: smp: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:47 +0200 (CEST) Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/Kconfig | 1 + arch/arm/include/asm/smp.h | 2 +- arch/arm/kernel/smp.c | 18 +++++++----------- 3 files changed, 9 insertions(+), 12 deletions(-) --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -124,6 +124,7 @@ config ARM select HAVE_SYSCALL_TRACEPOINTS select HAVE_UID16 select HAVE_VIRT_CPU_ACCOUNTING_GEN + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_FORCED_THREADING select MODULES_USE_ELF_REL select NEED_DMA_MAP_STATE --- a/arch/arm/include/asm/smp.h +++ b/arch/arm/include/asm/smp.h @@ -64,7 +64,7 @@ extern void secondary_startup_arm(void); extern int __cpu_disable(void); -extern void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } extern void arch_send_call_function_single_ipi(int cpu); extern void arch_send_call_function_ipi_mask(const struct cpumask *mask); --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -289,15 +289,11 @@ int __cpu_disable(void) } /* - * called on the thread which is asking for a CPU to be shutdown - - * waits until shutdown has completed, or it is timed out. + * called on the thread which is asking for a CPU to be shutdown after the + * shutdown completed. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU%u: cpu didn't die\n", cpu); - return; - } pr_debug("CPU%u: shutdown\n", cpu); clear_tasks_mm_cpumask(cpu); @@ -337,11 +333,11 @@ void arch_cpu_idle_dead(void) flush_cache_louis(); /* - * Tell __cpu_die() that this CPU is now safe to dispose of. Once - * this returns, power and/or clocks can be removed at any point - * from this CPU and its cache by platform_cpu_kill(). + * Tell cpuhp_bp_sync_dead() that this CPU is now safe to dispose + * of. Once this returns, power and/or clocks can be removed at + * any point from this CPU and its cache by platform_cpu_kill(). */ - (void)cpu_report_death(); + cpuhp_ap_report_dead(); /* * Ensure that the cache lines associated with that completion are From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521296.809925 (Exim 4.92) (envelope-from ) id 1pnTAB-0003Mf-AN; Fri, 14 Apr 2023 23:49:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521296.809925; Fri, 14 Apr 2023 23:49:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAB-0003MI-7X; Fri, 14 Apr 2023 23:49:07 +0000 Received: by outflank-mailman (input) for mailman id 521296; Fri, 14 Apr 2023 23:49:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6B-0000zb-8I for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:59 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a850ad4-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a850ad4-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.693105830@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=mLdwoL7i0j/gvs95W7juPrPE5guQlLpBTCOH6DWIfHg=; b=y1vQpfJDA9JbXkT4n2QDDyergrLrjhNoIcOXwKPLBgXGWR69MsWEbhct6B2Q0Beq9IabGw 8AdipYQcGyGv10JjhcWmTMA6nb+uKbsSx/MN8HdunT5YcA8SzmppaMBbV7cQ+4LIlc+rZg M4S3YtNPEpFxh9BpQS/uuKImmvSvY9SOjP7kEGHRSjocKuW8Hkd+wsQRNAhaJSu1q3Ji84 SfmMJL8bUIWPuJwGfQ1vQpsLmkVhRAcjnaf3HglDZNmuBZv36ILD3UsCeX4NSzkNQbUFEr jFiHQ+uYjIIWiDdw9m0lRurk39p0R7S/zFpzTGvsKaBrVSf8BTbzIWNSs/wA3w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=mLdwoL7i0j/gvs95W7juPrPE5guQlLpBTCOH6DWIfHg=; b=M7xQ1hL+35efJyLWe/r6UMXIs4XiyYXK60NpoJQ4tJZIRf0mH7XTaz2kcmwMNEzpQl+EWC m32CcBw/MSN+BxAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Thomas Bogendoerfer , linux-mips@vger.kernel.org, David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 24/37] MIPS: SMP_CPS: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:52 +0200 (CEST) Switch to the CPU hotplug core state tracking and synchronization mechanim. This unfortunately requires to add dead reporting to the non CPS platforms as CPS is the only user, but it allows an overall consolidation of this functionality. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org --- arch/mips/Kconfig | 1 + arch/mips/cavium-octeon/smp.c | 1 + arch/mips/include/asm/smp-ops.h | 1 + arch/mips/kernel/smp-bmips.c | 1 + arch/mips/kernel/smp-cps.c | 14 +++++--------- arch/mips/kernel/smp.c | 8 ++++++++ arch/mips/loongson64/smp.c | 1 + 7 files changed, 18 insertions(+), 9 deletions(-) --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -2356,6 +2356,7 @@ config MIPS_CPS select MIPS_CM select MIPS_CPS_PM if HOTPLUG_CPU select SMP + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select SYNC_R4K if (CEVT_R4K || CSRC_R4K) select SYS_SUPPORTS_HOTPLUG_CPU select SYS_SUPPORTS_SCHED_SMT if CPU_MIPSR6 --- a/arch/mips/cavium-octeon/smp.c +++ b/arch/mips/cavium-octeon/smp.c @@ -344,6 +344,7 @@ void play_dead(void) int cpu = cpu_number_map(cvmx_get_core_num()); idle_task_exit(); + cpuhp_ap_report_dead(); octeon_processor_boot = 0xff; per_cpu(cpu_state, cpu) = CPU_DEAD; --- a/arch/mips/include/asm/smp-ops.h +++ b/arch/mips/include/asm/smp-ops.h @@ -33,6 +33,7 @@ struct plat_smp_ops { #ifdef CONFIG_HOTPLUG_CPU int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); + void (*cleanup_dead_cpu)(unsigned cpu); #endif #ifdef CONFIG_KEXEC void (*kexec_nonboot_cpu)(void); --- a/arch/mips/kernel/smp-bmips.c +++ b/arch/mips/kernel/smp-bmips.c @@ -390,6 +390,7 @@ static void bmips_cpu_die(unsigned int c void __ref play_dead(void) { idle_task_exit(); + cpuhp_ap_report_dead(); /* flush data cache */ _dma_cache_wback_inv(0, ~0); --- a/arch/mips/kernel/smp-cps.c +++ b/arch/mips/kernel/smp-cps.c @@ -497,8 +497,7 @@ void play_dead(void) } } - /* This CPU has chosen its way out */ - (void)cpu_report_death(); + cpuhp_ap_report_dead(); cps_shutdown_this_cpu(cpu_death); @@ -521,7 +520,9 @@ static void wait_for_sibling_halt(void * } while (!(halted & TCHALT_H)); } -static void cps_cpu_die(unsigned int cpu) +static void cps_cpu_die(unsigned int cpu) { } + +static void cps_cleanup_dead_cpu(unsigned cpu) { unsigned core = cpu_core(&cpu_data[cpu]); unsigned int vpe_id = cpu_vpe_id(&cpu_data[cpu]); @@ -529,12 +530,6 @@ static void cps_cpu_die(unsigned int cpu unsigned stat; int err; - /* Wait for the cpu to choose its way out */ - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU%u: didn't offline\n", cpu); - return; - } - /* * Now wait for the CPU to actually offline. Without doing this that * offlining may race with one or more of: @@ -618,6 +613,7 @@ static const struct plat_smp_ops cps_smp #ifdef CONFIG_HOTPLUG_CPU .cpu_disable = cps_cpu_disable, .cpu_die = cps_cpu_die, + .cleanup_dead_cpu = cps_cleanup_dead_cpu, #endif #ifdef CONFIG_KEXEC .kexec_nonboot_cpu = cps_kexec_nonboot_cpu, --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -690,6 +690,14 @@ void flush_tlb_one(unsigned long vaddr) EXPORT_SYMBOL(flush_tlb_page); EXPORT_SYMBOL(flush_tlb_one); +#ifdef CONFIG_HOTPLUG_CPU +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ + if (mp_ops->cleanup_dead_cpu) + mp_ops->cleanup_dead_cpu(cpu); +} +#endif + #ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST static void tick_broadcast_callee(void *info) --- a/arch/mips/loongson64/smp.c +++ b/arch/mips/loongson64/smp.c @@ -788,6 +788,7 @@ void play_dead(void) void (*play_dead_at_ckseg1)(int *); idle_task_exit(); + cpuhp_ap_report_dead(); prid_imp = read_c0_prid() & PRID_IMP_MASK; prid_rev = read_c0_prid() & PRID_REV_MASK; From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521301.809935 (Exim 4.92) (envelope-from ) id 1pnTAF-0003jr-Jr; Fri, 14 Apr 2023 23:49:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521301.809935; Fri, 14 Apr 2023 23:49:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAF-0003je-GJ; Fri, 14 Apr 2023 23:49:11 +0000 Received: by outflank-mailman (input) for mailman id 521301; Fri, 14 Apr 2023 23:49:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT69-0000zb-8C for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:57 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 588ebefc-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 588ebefc-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.569498144@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dAqk1yNFRcZF7qilzpcfVR/70NZ8+F/SNrVuS7Hd0dk=; b=AU6aWn3llfgN87vGRPuEWQIrjtTFwK3yn2f2vw94yybrTzt5H4LRbc91tm1Xw3BwSnq5hP rQmL01eHYwGuD/tJ0f+L2+Oe406bYjAoY3D+heXxkuTKO7KuUfo+Vs6B1IlkwX6ZMSgfKv MeC7l/ITcGbKIYw5eRyObkCJegLxrMXZzPk/rNGf+zutst2sEf6AX47fGrPZphUN9CnuIP 6Hqq0/37hmlZ5Bbfm3XWsFI3yH4n+lXK8uvrCVgYW4m/9hcfQmz9XLNpsQ2ZNbshSo8dWB 0ORFcD1Xi54QY+d+vfpgXIdhI1e6dB7Jux3a2oBfTKMsXcUuUQI04NVVQTd0zA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dAqk1yNFRcZF7qilzpcfVR/70NZ8+F/SNrVuS7Hd0dk=; b=9EnFpcJNs8EwCrNKZip93QB/LFNFkvbQArfrS6NvwMyIg/IEdfp5AE2HOIUr5Sp+QKyDnB /vmf1BkRatgvPdDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 22/37] arm64: smp: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:49 +0200 (CEST) Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org --- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/smp.h | 2 +- arch/arm64/kernel/smp.c | 14 +++++--------- 3 files changed, 7 insertions(+), 10 deletions(-) --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -216,6 +216,7 @@ config ARM64 select HAVE_KPROBES select HAVE_KRETPROBES select HAVE_GENERIC_VDSO + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_DOMAIN select IRQ_FORCED_THREADING select KASAN_VMALLOC if KASAN --- a/arch/arm64/include/asm/smp.h +++ b/arch/arm64/include/asm/smp.h @@ -99,7 +99,7 @@ static inline void arch_send_wakeup_ipi_ extern int __cpu_disable(void); -extern void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } extern void cpu_die(void); extern void cpu_die_early(void); --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -333,17 +333,13 @@ static int op_cpu_kill(unsigned int cpu) } /* - * called on the thread which is asking for a CPU to be shutdown - - * waits until shutdown has completed, or it is timed out. + * Called on the thread which is asking for a CPU to be shutdown after the + * shutdown completed. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { int err; - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: cpu didn't die\n", cpu); - return; - } pr_debug("CPU%u: shutdown\n", cpu); /* @@ -370,8 +366,8 @@ void cpu_die(void) local_daif_mask(); - /* Tell __cpu_die() that this CPU is now safe to dispose of */ - (void)cpu_report_death(); + /* Tell cpuhp_bp_sync_dead() that this CPU is now safe to dispose of */ + cpuhp_ap_report_dead(); /* * Actually shutdown the CPU. This must never fail. The specific hotplug From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521302.809941 (Exim 4.92) (envelope-from ) id 1pnTAG-0003p1-4y; Fri, 14 Apr 2023 23:49:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521302.809941; Fri, 14 Apr 2023 23:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAF-0003oL-QV; Fri, 14 Apr 2023 23:49:11 +0000 Received: by outflank-mailman (input) for mailman id 521302; Fri, 14 Apr 2023 23:49:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6D-0000zb-8X for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:01 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5b94cad7-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b94cad7-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.754812729@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=R05iW7fNVcum8Q+mjf2E3yOsCRNZdrRM4MkZfsXKqKc=; b=aUiik8SryxpjaeRHuGDH1CVCPJrHdz4ToboDiBvyrgybp5D/pPkGbz7paiwVK8VODAE0fl SgTT+QXtuBbN0fpZxUWKztpQGU0bjPZSUW3fxyRe9IQVkvcbXWq/0x43vpjbVvOarJH7HV uIjYrrAOYGCrtSVeXL3Klmw/1hn994FxUZywCAJZ5ETy96ETN4uYpOv1uP93+BscjKqka+ yexDk6oAjmOIdMrSOugyHKVHXN1255/Us+8JjFFS+8Qfs8u4ygXpDFKFDNp8KDDwtuiQU3 N8RPw7aSRn8YI2NswkTZsr81vwh3F5+iNvqvFAUv07ki8YW+7xmZPHzCBoIC9w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=R05iW7fNVcum8Q+mjf2E3yOsCRNZdrRM4MkZfsXKqKc=; b=caenbNdiUoGPpEuAuhFVb0nh5RPBSUL+B8V0qrD3LKpWvQp6oNtGy6pLTh0H4xLk3s7H+h 2RFNt+MohEqWQ1CQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 25/37] parisc: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:54 +0200 (CEST) Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org --- arch/parisc/Kconfig | 1 + arch/parisc/kernel/process.c | 4 ++-- arch/parisc/kernel/smp.c | 7 +++---- 3 files changed, 6 insertions(+), 6 deletions(-) --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -56,6 +56,7 @@ config PARISC select HAVE_ARCH_SECCOMP_FILTER select HAVE_ARCH_TRACEHOOK select HAVE_REGS_AND_STACK_ACCESS_API + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select GENERIC_SCHED_CLOCK select GENERIC_IRQ_MIGRATION if SMP select HAVE_UNSTABLE_SCHED_CLOCK if SMP --- a/arch/parisc/kernel/process.c +++ b/arch/parisc/kernel/process.c @@ -166,8 +166,8 @@ void arch_cpu_idle_dead(void) local_irq_disable(); - /* Tell __cpu_die() that this CPU is now safe to dispose of. */ - (void)cpu_report_death(); + /* Tell the core that this CPU is now safe to dispose of. */ + cpuhp_ap_report_dead(); /* Ensure that the cache lines are written out. */ flush_cache_all_local(); --- a/arch/parisc/kernel/smp.c +++ b/arch/parisc/kernel/smp.c @@ -500,11 +500,10 @@ int __cpu_disable(void) void __cpu_die(unsigned int cpu) { pdc_cpu_rendezvous_lock(); +} - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: cpu didn't die\n", cpu); - return; - } +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ pr_info("CPU%u: is shutting down\n", cpu); /* set task's state to interruptible sleep */ From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521305.809955 (Exim 4.92) (envelope-from ) id 1pnTAJ-0004Uw-7K; Fri, 14 Apr 2023 23:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521305.809955; Fri, 14 Apr 2023 23:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAJ-0004UY-1w; Fri, 14 Apr 2023 23:49:15 +0000 Received: by outflank-mailman (input) for mailman id 521305; Fri, 14 Apr 2023 23:49:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6E-0000zb-8g for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:02 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c76f70e-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c76f70e-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.817955867@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=ayzVJgXuvflj3xjg1mGXZolHpFmSekkZ0AyhKY70H0Q=; b=GY2K7k5oePF4smJsnVlCWc197Gnvm2xpV+H4Y4U8e+jaRt3VB8iE9Bg1axBb2bpO+/I7XE wTG8GN8vNucA/g3rxDLFU6mc1SvUhxpbP0wveuvbhDGNZd++q35ihkBqOmSICTjhquJjYJ gQ/8Bkd6FpRUM+MX/SRhgi0pwhuLuSCrUZwmZ1fPuiU+CEObkKTMFIVqx8V0B6LfZdF2Zy vTSM8z3vPt6+fF/Bmw0aE9UGx+RqDICSvY+n8F5aACJ8IZ8FOG+IfKxylVEweXpqRrNp+K c5k4vI/XDc1rGZAhq8CumldbXaaUQJlgNjb18yycd/3lTwMlhsF9uxtK+pKsOQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=ayzVJgXuvflj3xjg1mGXZolHpFmSekkZ0AyhKY70H0Q=; b=K/mg+lwQlwHWac81k54xHqleQCPzjnE1varYnMwenALS/XLp9IX7NBh95fkmdnzkG0JM9N NgO+APSKFCAt65CA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Mark Rutland , Sabin Rapan Subject: [patch 26/37] riscv: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:55 +0200 (CEST) Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: linux-riscv@lists.infradead.org --- arch/riscv/Kconfig | 1 + arch/riscv/include/asm/smp.h | 2 +- arch/riscv/kernel/cpu-hotplug.c | 14 +++++++------- 3 files changed, 9 insertions(+), 8 deletions(-) --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -116,6 +116,7 @@ config RISCV select HAVE_RSEQ select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_DOMAIN select IRQ_FORCED_THREADING select MODULES_USE_ELF_RELA if MODULES --- a/arch/riscv/include/asm/smp.h +++ b/arch/riscv/include/asm/smp.h @@ -64,7 +64,7 @@ asmlinkage void smp_callin(void); #if defined CONFIG_HOTPLUG_CPU int __cpu_disable(void); -void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } #endif /* CONFIG_HOTPLUG_CPU */ #else --- a/arch/riscv/kernel/cpu-hotplug.c +++ b/arch/riscv/kernel/cpu-hotplug.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -48,17 +49,15 @@ int __cpu_disable(void) return ret; } +#ifdef CONFIG_HOTPLUG_CPU /* - * Called on the thread which is asking for a CPU to be shutdown. + * Called on the thread which is asking for a CPU to be shutdown, if the + * CPU reported dead to the hotplug core. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { int ret = 0; - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU %u: didn't die\n", cpu); - return; - } pr_notice("CPU%u: off\n", cpu); /* Verify from the firmware if the cpu is really stopped*/ @@ -75,9 +74,10 @@ void arch_cpu_idle_dead(void) { idle_task_exit(); - (void)cpu_report_death(); + cpuhp_ap_report_dead(); cpu_ops[smp_processor_id()]->cpu_stop(); /* It should never reach here */ BUG(); } +#endif From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521307.809959 (Exim 4.92) (envelope-from ) id 1pnTAJ-0004Yj-N2; Fri, 14 Apr 2023 23:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521307.809959; Fri, 14 Apr 2023 23:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAJ-0004XT-FQ; Fri, 14 Apr 2023 23:49:15 +0000 Received: by outflank-mailman (input) for mailman id 521307; Fri, 14 Apr 2023 23:49:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6K-0000zb-Bm for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:08 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6268d8ce-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6268d8ce-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.192114505@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=OOycMYPFVi5YhixhBoVMbIx7KiHrtAXAV72ZpNnWZL8=; b=hJ/cJ/LsDaASOUqASLPPkSC6Ps6RxfdsA7gQYRBMpPaZEuge6FBpr2f6vVc+8HZFkB/rmb RJy5f49D9C3GZ5iAOC7Zko7KcGkJJr2aVQq4d0I8MHxwSrgTL3A0ePu6a/KfQsXuVA4Xbu ajazkAeZDlEyf5WTyO4+9yNz86aTWvAhKkL+wFnm59Pu29bb/grFar2EnhIA3IYkZTtEDm 0zbDi0Vg6WqjBsnDoMhcNfUK9CtbuR2h5QYljCFrrrsyKUW96SL8J44WHxTF6P75LRzQZI y5u0fp80f4IGejFZO38GlIfCPV4fIBaOEn1NXHQkG/2n87JafGV7laJAQBArhQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=OOycMYPFVi5YhixhBoVMbIx7KiHrtAXAV72ZpNnWZL8=; b=3elqLNqpb58Nl0QV7Y5mpEmw+yXYy7Jx8aSLhWQ4/jwrJTvN020KSkN4jR6yL3KGS/kbNN oIimmB7TZWnYdBDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 32/37] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:05 +0200 (CEST) There is often significant latency in the early stages of CPU bringup, and time is wasted by waking each CPU (e.g. with SIPI/INIT/INIT on x86) and then waiting for it to respond before moving on to the next. Allow a platform to enable parallel setup which brings all to be onlined CPUs up to the CPUHP_BP_KICK_AP state. While this state advancement on the control CPU (BP) is single-threaded the important part is the last state CPUHP_BP_KICK_AP which wakes the to be onlined CPUs up. This allows the CPUs to run up to the first sychronization point cpuhp_ap_sync_alive() where they wait for the control CPU to release them one by one for the full onlining procedure. This parallelism depends on the CPU hotplug core sync mechanism which ensures that the parallel brought up CPUs wait for release before touching any state which would make the CPU visible to anything outside the hotplug control mechanism. To handle the SMT constraints of X86 correctly the bringup happens in two iterations when CONFIG_HOTPLUG_SMT is enabled. The control CPU brings up the primary SMT threads of each core first, which can load the microcode without the need to rendevouz with the thread siblings. Once that's completed it brings up the secondary SMT threads. Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner --- Documentation/admin-guide/kernel-parameters.txt | 6 + arch/Kconfig | 4 include/linux/cpuhotplug.h | 1 kernel/cpu.c | 103 ++++++++++++++++++++++-- 4 files changed, 109 insertions(+), 5 deletions(-) --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -815,6 +815,12 @@ on every CPU online, such as boot, and resume from suspend. Default: 10000 + cpuhp.parallel= + [SMP] Enable/disable parallel bringup of secondary CPUs + Format: + Default is enabled if CONFIG_HOTPLUG_PARALLEL=y. Otherwise + the parameter has no effect. + crash_kexec_post_notifiers Run kdump after running panic-notifiers and dumping kmsg. This only for the users who doubt kdump always --- a/arch/Kconfig +++ b/arch/Kconfig @@ -53,6 +53,10 @@ config HOTPLUG_SPLIT_STARTUP bool select HOTPLUG_CORE_SYNC_FULL +config HOTPLUG_PARALLEL + bool + select HOTPLUG_SPLIT_STARTUP + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -526,6 +526,7 @@ void cpuhp_ap_sync_alive(void); void arch_cpuhp_sync_state_poll(void); void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle); +bool arch_cpuhp_init_parallel_bringup(void); #ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD void cpuhp_ap_report_dead(void); --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -649,8 +649,23 @@ bool cpu_smt_possible(void) cpu_smt_control != CPU_SMT_NOT_SUPPORTED; } EXPORT_SYMBOL_GPL(cpu_smt_possible); + +static inline bool cpuhp_smt_aware(void) +{ + return topology_smt_supported(); +} + +static inline const struct cpumask *cpuhp_get_primary_thread_mask(void) +{ + return cpu_primary_thread_mask; +} #else static inline bool cpu_smt_allowed(unsigned int cpu) { return true; } +static inline bool cpuhp_smt_aware(void) { return false; } +static inline const struct cpumask *cpuhp_get_primary_thread_mask(void) +{ + return cpu_present_mask; +} #endif static inline enum cpuhp_state @@ -1743,16 +1758,94 @@ int bringup_hibernate_cpu(unsigned int s return 0; } -void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) +static void __init cpuhp_bringup_mask(const struct cpumask *mask, unsigned int ncpus, + enum cpuhp_state target) { unsigned int cpu; - for_each_present_cpu(cpu) { - if (num_online_cpus() >= setup_max_cpus) + for_each_cpu(cpu, mask) { + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); + + if (!--ncpus) break; - if (!cpu_online(cpu)) - cpu_up(cpu, CPUHP_ONLINE); + + if (cpu_up(cpu, target) && can_rollback_cpu(st)) { + /* + * If this failed then cpu_up() might have only + * rolled back to CPUHP_BP_KICK_AP for the final + * online. Clean it up. NOOP if already rolled back. + */ + WARN_ON(cpuhp_invoke_callback_range(false, cpu, st, CPUHP_OFFLINE)); + } + } +} + +#ifdef CONFIG_HOTPLUG_PARALLEL +static bool __cpuhp_parallel_bringup __ro_after_init = true; + +static int __init parallel_bringup_parse_param(char *arg) +{ + return kstrtobool(arg, &__cpuhp_parallel_bringup); +} +early_param("cpuhp.parallel", parallel_bringup_parse_param); + +/* + * On architectures which have enabled parallel bringup this invokes all BP + * prepare states for each of the to be onlined APs first. The last state + * sends the startup IPI to the APs. The APs proceed through the low level + * bringup code in parallel and then wait for the control CPU to release + * them one by one for the final onlining procedure. + * + * This avoids waiting for each AP to respond to the startup IPI in + * CPUHP_BRINGUP_CPU. + */ +static bool __init cpuhp_bringup_cpus_parallel(unsigned int ncpus) +{ + const struct cpumask *mask = cpu_present_mask; + + if (__cpuhp_parallel_bringup) + __cpuhp_parallel_bringup = arch_cpuhp_init_parallel_bringup(); + if (!__cpuhp_parallel_bringup) + return false; + + if (cpuhp_smt_aware()) { + const struct cpumask *pmask = cpuhp_get_primary_thread_mask(); + static struct cpumask tmp_mask __initdata; + + /* + * X86 requires to prevent that SMT siblings stopped while + * the primary thread does a microcode update for various + * reasons. Bring the primary threads up first. + */ + cpumask_and(&tmp_mask, mask, pmask); + cpuhp_bringup_mask(&tmp_mask, ncpus, CPUHP_BP_KICK_AP); + cpuhp_bringup_mask(&tmp_mask, ncpus, CPUHP_ONLINE); + /* Account for the online CPUs */ + ncpus -= num_online_cpus(); + if (!ncpus) + return true; + /* Create the mask for secondary CPUs */ + cpumask_andnot(&tmp_mask, mask, pmask); + mask = &tmp_mask; } + + /* Bring the not-yet started CPUs up */ + cpuhp_bringup_mask(mask, ncpus, CPUHP_BP_KICK_AP); + cpuhp_bringup_mask(mask, ncpus, CPUHP_ONLINE); + return true; +} +#else +static inline bool cpuhp_bringup_cpus_parallel(unsigned int ncpus) { return false; } +#endif /* CONFIG_HOTPLUG_PARALLEL */ + +void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) +{ + /* Try parallel bringup optimization if enabled */ + if (cpuhp_bringup_cpus_parallel(setup_max_cpus)) + return; + + /* Full per CPU serialized bringup */ + cpuhp_bringup_mask(cpu_present_mask, setup_max_cpus, CPUHP_ONLINE); } #ifdef CONFIG_PM_SLEEP_SMP From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521309.809966 (Exim 4.92) (envelope-from ) id 1pnTAK-0004m6-Ko; Fri, 14 Apr 2023 23:49:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521309.809966; Fri, 14 Apr 2023 23:49:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAK-0004js-9U; Fri, 14 Apr 2023 23:49:16 +0000 Received: by outflank-mailman (input) for mailman id 521309; Fri, 14 Apr 2023 23:49:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6H-0000zb-9F for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:05 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f612769-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f612769-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.004104404@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=ocDa9/b5b649kz9ODCiS7Obhl2xff0PGySrVJUnu/1Q=; b=Md1KUi0t4p5246hEM+Qbsg81XiYR2jMjuw8Cw1D96u97R/Z2vnRzvzyGsvg5/thdzlhagw VxVAyRxzHuR0yoObilNCNxEii10xKHOuzvMmMpympXYYlB2U8gUH+sjsIvQSBudSOTSmdM UnCqcdLP+SdXgts22XiNkil1Ao3IAY8flV5MA9J+wt6a2jzpqf6qFRYX/asyt9IKYGJESJ xr1bFKQEJqtc2y44yr2+c326EAG2BPB0FHdGHcRgBqiJBXhDU2UyMAE2uzcyA4utOsub3q p754cUuO5uG6++I5nPeZhand8mstexdu0PM3TYbIMB2kMernSkCdSX7RIPkZfA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=ocDa9/b5b649kz9ODCiS7Obhl2xff0PGySrVJUnu/1Q=; b=BXd39doKKTpBx8WPmaV0PtWPunRukkpmlrtLhowy8wImwT3Zn16BG6OqXrJtidsxX/8Ej+ driBsAHHd5CWSWBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 29/37] cpu/hotplug: Provide a split up CPUHP_BRINGUP mechanism References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:00 +0200 (CEST) The bring up logic of a to be onlined CPU consists of several parts, which are considered to be a single hotplug state: 1) Control CPU issues the wake-up 2) To be onlined CPU starts up, does the minimal initialization, reports to be alive and waits for release into the complete bring-up. 3) Control CPU waits for the alive report and releases the upcoming CPU for the complete bring-up. Allow to split this into two states: 1) Control CPU issues the wake-up After that the to be onlined CPU starts up, does the minimal initialization, reports to be alive and waits for release into the full bring-up. As this can run after the control CPU dropped the hotplug locks the code which is executed on the AP before it reports alive has to be carefully audited to not violate any of the hotplug constraints, especially not modifying any of the various cpumasks. This is really only meant to avoid waiting for the AP to react on the wake-up. Of course an architecture can move strict CPU related setup functionality, e.g. microcode loading, with care before the synchronization point to save further pointless waiting time. 2) Control CPU waits for the alive report and releases the upcoming CPU for the complete bring-up. This allows that the two states can be split up to run all to be onlined CPUs up to state #1 on the control CPU and then at a later point run state #2. This spares some of the latencies of the full serialized per CPU bringup by avoiding the per CPU wakeup/wait serialization. The assumption is that the first AP already waits when the last AP has been woken up. This obvioulsy depends on the hardware latencies and depending on the timings this might still not completely eliminate all wait scenarios. This split is just a preparatory step for enabling the parallel bringup later. The boot time bringup is still fully serialized. It has a separate config switch so that architectures which want to support parallel bringup can test the split of the CPUHP_BRINGUG step separately. To enable this the architecture must support the CPU hotplug core sync mechanism and has to be audited that there are no implicit hotplug state dependencies which require a fully serialized bringup. Signed-off-by: Thomas Gleixner --- arch/Kconfig | 4 ++ include/linux/cpuhotplug.h | 4 ++ kernel/cpu.c | 70 +++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 76 insertions(+), 2 deletions(-) --- a/arch/Kconfig +++ b/arch/Kconfig @@ -49,6 +49,10 @@ config HOTPLUG_CORE_SYNC_FULL select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select HOTPLUG_CORE_SYNC +config HOTPLUG_SPLIT_STARTUP + bool + select HOTPLUG_CORE_SYNC_FULL + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -133,6 +133,7 @@ enum cpuhp_state { CPUHP_MIPS_SOC_PREPARE, CPUHP_BP_PREPARE_DYN, CPUHP_BP_PREPARE_DYN_END = CPUHP_BP_PREPARE_DYN + 20, + CPUHP_BP_KICK_AP, CPUHP_BRINGUP_CPU, /* @@ -519,9 +520,12 @@ void cpuhp_online_idle(enum cpuhp_state static inline void cpuhp_online_idle(enum cpuhp_state state) { } #endif +struct task_struct; + void cpuhp_ap_sync_alive(void); void arch_cpuhp_sync_state_poll(void); void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); +int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle); #ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD void cpuhp_ap_report_dead(void); --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -759,6 +759,47 @@ static int bringup_wait_for_ap_online(un return 0; } +#ifdef CONFIG_HOTPLUG_SPLIT_STARTUP +static int cpuhp_kick_ap_alive(unsigned int cpu) +{ + if (!cpuhp_can_boot_ap(cpu)) + return -EAGAIN; + + return arch_cpuhp_kick_ap_alive(cpu, idle_thread_get(cpu)); +} + +static int cpuhp_bringup_ap(unsigned int cpu) +{ + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); + int ret; + + /* + * Some architectures have to walk the irq descriptors to + * setup the vector space for the cpu which comes online. + * Prevent irq alloc/free across the bringup. + */ + irq_lock_sparse(); + + ret = cpuhp_bp_sync_alive(cpu); + if (ret) + goto out_unlock; + + ret = bringup_wait_for_ap_online(cpu); + if (ret) + goto out_unlock; + + irq_unlock_sparse(); + + if (st->target <= CPUHP_AP_ONLINE_IDLE) + return 0; + + return cpuhp_kick_ap(cpu, st, st->target); + +out_unlock: + irq_unlock_sparse(); + return ret; +} +#else static int bringup_cpu(unsigned int cpu) { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); @@ -775,7 +816,6 @@ static int bringup_cpu(unsigned int cpu) */ irq_lock_sparse(); - /* Arch-specific enabling code. */ ret = __cpu_up(cpu, idle); if (ret) goto out_unlock; @@ -799,6 +839,7 @@ static int bringup_cpu(unsigned int cpu) irq_unlock_sparse(); return ret; } +#endif static int finish_cpu(unsigned int cpu) { @@ -1938,13 +1979,38 @@ static struct cpuhp_step cpuhp_hp_states .startup.single = timers_prepare_cpu, .teardown.single = timers_dead_cpu, }, - /* Kicks the plugged cpu into life */ + +#ifdef CONFIG_HOTPLUG_SPLIT_STARTUP + /* + * Kicks the AP alive. AP will wait in cpuhp_ap_sync_alive() until + * the next step will release it. + */ + [CPUHP_BP_KICK_AP] = { + .name = "cpu:kick_ap", + .startup.single = cpuhp_kick_ap_alive, + }, + + /* + * Waits for the AP to reach cpuhp_ap_sync_alive() and then + * releases it for the complete bringup. + */ + [CPUHP_BRINGUP_CPU] = { + .name = "cpu:bringup", + .startup.single = cpuhp_bringup_ap, + .teardown.single = finish_cpu, + .cant_stop = true, + }, +#else + /* + * All-in-one CPU bringup state which includes the kick alive. + */ [CPUHP_BRINGUP_CPU] = { .name = "cpu:bringup", .startup.single = bringup_cpu, .teardown.single = finish_cpu, .cant_stop = true, }, +#endif /* Final state before CPU kills itself */ [CPUHP_AP_IDLE_DEAD] = { .name = "idle:dead", From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521314.809982 (Exim 4.92) (envelope-from ) id 1pnTAM-0005G2-7n; Fri, 14 Apr 2023 23:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521314.809982; Fri, 14 Apr 2023 23:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAL-0005Ev-Rp; Fri, 14 Apr 2023 23:49:17 +0000 Received: by outflank-mailman (input) for mailman id 521314; Fri, 14 Apr 2023 23:49:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6P-0000zb-BF for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:13 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65468783-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65468783-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.379210081@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=30gAYfFq7D/rpiAsDZ0VJ8Kl0fjNcwxtQrZfJqj5x1Q=; b=slTd10Pp/4TGmD/zlEb43Gb2WKRTlAppsSoSOu/T/E5JWpZy7hpKytp5/flV3pXvlf98mG aFkvnauiXOzF9rU2jFxo9JDlLYJmNHG16yPTZ65k9zIeEDhe+RYXJnZZEJKz1jMvqGBqWY BrJbQ+/W6kvjZFEcMJnDOmBoB+wtMm7S1uu0QlhCDKdWnqg0/vW+4HXD1l1CY7ixM7tgU3 5PYqnW+jK7Z+hTrrlILf1oeW7ukViva1urpMPLhbmq0i0D+n8MofDLQxKVm+wNnRvv0a2W OS0dI9HKv3OCVLtAiJE196l54a2e8MLBX7ZcLL6pY36gkjwA0CwNz7FRv3fQXg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=30gAYfFq7D/rpiAsDZ0VJ8Kl0fjNcwxtQrZfJqj5x1Q=; b=fpHp/7lpP4jb7NBZQJ1STRnv+01MPSKMiVut7RE9SWvxHshH6nA9x03/g2I1cMS+hCTLAP Z5dLyPS0dXp2guCA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 35/37] x86/smpboot: Support parallel startup of secondary CPUs References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:10 +0200 (CEST) From: David Woodhouse Rework the real-mode startup code to allow for APs to be brought up in parallel. This is in two parts: 1. Introduce a bit-spinlock to prevent them from all using the real mode stack at the same time. 2. Avoid needing to use the global smpboot_control variable to pass each AP its CPU number. To achieve the latter, export the cpuid_to_apicid[] array so that each AP can find its own CPU number by searching therein based on its APIC ID. Introduce flags in the top bits of smpboot_control which indicate methods by which an AP should find its CPU number. For a serialized bringup, the CPU number is explicitly passed in the low bits of smpboot_control as before. For parallel mode there are flags directing the AP to find its APIC ID in CPUID leaf 0x0b or 1x1f (for X2APIC mode) or CPUID leaf 0x01 where 8 bits are sufficient, then perform the cpuid_to_apicid[] lookup with that. Aside from the fact that APs will now look up their CPU number via the newly-exported cpuid_to_apicid[] table, there is no behavioural change intended, since the parallel bootup has not yet been enabled. [ tglx: Initial proof of concept patch with bitlock and APIC ID lookup ] [ dwmw2: Rework and testing, commit message, CPUID 0x1 and CPU0 support ] [ seanc: Fix stray override of initial_gs in common_cpu_up() ] [ Oleksandr Natalenko: reported suspend/resume issue fixed in x86_acpi_suspend_lowlevel ] Co-developed-by: Thomas Gleixner Signed-off-by: Thomas Gleixner Co-developed-by: Brian Gerst Signed-off-by: Brian Gerst Signed-off-by: David Woodhouse Signed-off-by: Usama Arif Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/apic.h | 2 arch/x86/include/asm/realmode.h | 3 + arch/x86/include/asm/smp.h | 8 +++ arch/x86/kernel/acpi/sleep.c | 9 +++ arch/x86/kernel/apic/apic.c | 2 arch/x86/kernel/head_64.S | 79 ++++++++++++++++++++++++++++++++++- arch/x86/kernel/smpboot.c | 5 -- arch/x86/realmode/init.c | 3 + arch/x86/realmode/rm/trampoline_64.S | 27 +++++++++-- 9 files changed, 125 insertions(+), 13 deletions(-) --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -55,6 +55,8 @@ extern int local_apic_timer_c2_ok; extern int disable_apic; extern unsigned int lapic_timer_period; +extern int cpuid_to_apicid[]; + extern enum apic_intr_mode_id apic_intr_mode; enum apic_intr_mode_id { APIC_PIC, --- a/arch/x86/include/asm/realmode.h +++ b/arch/x86/include/asm/realmode.h @@ -52,6 +52,7 @@ struct trampoline_header { u64 efer; u32 cr4; u32 flags; + u32 lock; #endif }; @@ -64,6 +65,8 @@ extern unsigned long initial_stack; extern unsigned long initial_vc_handler; #endif +extern u32 *trampoline_lock; + extern unsigned char real_mode_blob[]; extern unsigned char real_mode_relocs[]; --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -198,4 +198,12 @@ extern unsigned int smpboot_control; #endif /* !__ASSEMBLY__ */ +/* Control bits for startup_64 */ +#define STARTUP_APICID_CPUID_1F 0x80000000 +#define STARTUP_APICID_CPUID_0B 0x40000000 +#define STARTUP_APICID_CPUID_01 0x20000000 + +/* Top 8 bits are reserved for control */ +#define STARTUP_PARALLEL_MASK 0xFF000000 + #endif /* _ASM_X86_SMP_H */ --- a/arch/x86/kernel/acpi/sleep.c +++ b/arch/x86/kernel/acpi/sleep.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include "../../realmode/rm/wakeup.h" @@ -127,7 +128,13 @@ int x86_acpi_suspend_lowlevel(void) * value is in the actual %rsp register. */ current->thread.sp = (unsigned long)temp_stack + sizeof(temp_stack); - smpboot_control = smp_processor_id(); + /* + * Ensure the CPU knows which one it is when it comes back, if + * it isn't in parallel mode and expected to work that out for + * itself. + */ + if (!(smpboot_control & STARTUP_PARALLEL_MASK)) + smpboot_control = smp_processor_id(); #endif initial_code = (unsigned long)wakeup_long64; saved_magic = 0x123456789abcdef0L; --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2377,7 +2377,7 @@ static int nr_logical_cpuids = 1; /* * Used to store mapping between logical CPU IDs and APIC IDs. */ -static int cpuid_to_apicid[] = { +int cpuid_to_apicid[] = { [0 ... NR_CPUS - 1] = -1, }; --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -25,6 +25,7 @@ #include #include #include +#include /* * We are not able to switch in one step to the final KERNEL ADDRESS SPACE @@ -234,8 +235,70 @@ SYM_INNER_LABEL(secondary_startup_64_no_ ANNOTATE_NOENDBR // above #ifdef CONFIG_SMP + /* + * For parallel boot, the APIC ID is retrieved from CPUID, and then + * used to look up the CPU number. For booting a single CPU, the + * CPU number is encoded in smpboot_control. + * + * Bit 31 STARTUP_APICID_CPUID_1F flag (use CPUID 0x1f) + * Bit 30 STARTUP_APICID_CPUID_0B flag (use CPUID 0x0b) + * Bit 29 STARTUP_APICID_CPUID_01 flag (use CPUID 0x01) + * Bit 0-23 CPU# if STARTUP_APICID_CPUID_xx flags are not set + */ movl smpboot_control(%rip), %ecx + testl $STARTUP_APICID_CPUID_1F, %ecx + jnz .Luse_cpuid_1f + testl $STARTUP_APICID_CPUID_0B, %ecx + jnz .Luse_cpuid_0b + testl $STARTUP_APICID_CPUID_01, %ecx + jnz .Luse_cpuid_01 + andl $(~STARTUP_PARALLEL_MASK), %ecx + jmp .Lsetup_cpu + +.Luse_cpuid_01: + mov $0x01, %eax + cpuid + mov %ebx, %edx + shr $24, %edx + jmp .Lsetup_AP + +.Luse_cpuid_0b: + mov $0x0B, %eax + xorl %ecx, %ecx + cpuid + jmp .Lsetup_AP + +.Luse_cpuid_1f: + mov $0x1f, %eax + xorl %ecx, %ecx + cpuid +.Lsetup_AP: + /* EDX contains the APIC ID of the current CPU */ + xorq %rcx, %rcx + leaq cpuid_to_apicid(%rip), %rbx + +.Lfind_cpunr: + cmpl (%rbx,%rcx,4), %edx + jz .Lsetup_cpu + inc %ecx +#ifdef CONFIG_FORCE_NR_CPUS + cmpl $NR_CPUS, %ecx +#else + cmpl nr_cpu_ids(%rip), %ecx +#endif + jb .Lfind_cpunr + + /* APIC ID not found in the table. Drop the trampoline lock and bail. */ + movq trampoline_lock(%rip), %rax + lock + btrl $0, (%rax) + +1: cli + hlt + jmp 1b + +.Lsetup_cpu: /* Get the per cpu offset for the given CPU# which is in ECX */ movq __per_cpu_offset(,%rcx,8), %rdx #else @@ -248,10 +311,20 @@ SYM_INNER_LABEL(secondary_startup_64_no_ * * RDX contains the per-cpu offset */ - movq pcpu_hot + X86_current_task(%rdx), %rax - movq TASK_threadsp(%rax), %rsp + movq pcpu_hot + X86_top_of_stack(%rdx), %rsp /* + * Now that this CPU is running on its own stack, drop the realmode + * protection. For the boot CPU the pointer is NULL! + */ + movq trampoline_lock(%rip), %rax + testq %rax, %rax + jz .Lsetup_gdt + lock + btrl $0, (%rax) + +.Lsetup_gdt: + /* * We must switch to a new descriptor in kernel space for the GDT * because soon the kernel won't have access anymore to the userspace * addresses where we're currently running on. We have to do that here @@ -435,6 +508,8 @@ SYM_DATA(initial_code, .quad x86_64_star #ifdef CONFIG_AMD_MEM_ENCRYPT SYM_DATA(initial_vc_handler, .quad handle_vc_boot_ghcb) #endif + +SYM_DATA(trampoline_lock, .quad 0); __FINITDATA __INIT --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -985,10 +985,7 @@ int common_cpu_up(unsigned int cpu, stru if (ret) return ret; -#ifdef CONFIG_X86_32 - /* Stack for startup_32 can be just as for start_secondary onwards */ per_cpu(pcpu_hot.top_of_stack, cpu) = task_top_of_stack(idle); -#endif return 0; } @@ -1014,7 +1011,7 @@ static int do_boot_cpu(int apicid, int c if (IS_ENABLED(CONFIG_X86_32)) { early_gdt_descr.address = (unsigned long)get_cpu_gdt_rw(cpu); initial_stack = idle->thread.sp; - } else { + } else if (!(smpboot_control & STARTUP_PARALLEL_MASK)) { smpboot_control = cpu; } --- a/arch/x86/realmode/init.c +++ b/arch/x86/realmode/init.c @@ -154,6 +154,9 @@ static void __init setup_real_mode(void) trampoline_header->flags = 0; + trampoline_lock = &trampoline_header->lock; + *trampoline_lock = 0; + trampoline_pgd = (u64 *) __va(real_mode_header->trampoline_pgd); /* Map the real mode stub as virtual == physical */ --- a/arch/x86/realmode/rm/trampoline_64.S +++ b/arch/x86/realmode/rm/trampoline_64.S @@ -37,6 +37,24 @@ .text .code16 +.macro LOAD_REALMODE_ESP + /* + * Make sure only one CPU fiddles with the realmode stack + */ +.Llock_rm\@: + btl $0, tr_lock + jnc 2f + pause + jmp .Llock_rm\@ +2: + lock + btsl $0, tr_lock + jc .Llock_rm\@ + + # Setup stack + movl $rm_stack_end, %esp +.endm + .balign PAGE_SIZE SYM_CODE_START(trampoline_start) cli # We should be safe anyway @@ -49,8 +67,7 @@ SYM_CODE_START(trampoline_start) mov %ax, %es mov %ax, %ss - # Setup stack - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP call verify_cpu # Verify the cpu supports long mode testl %eax, %eax # Check for return code @@ -93,8 +110,7 @@ SYM_CODE_START(sev_es_trampoline_start) mov %ax, %es mov %ax, %ss - # Setup stack - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP jmp .Lswitch_to_protected SYM_CODE_END(sev_es_trampoline_start) @@ -177,7 +193,7 @@ SYM_CODE_START(pa_trampoline_compat) * In compatibility mode. Prep ESP and DX for startup_32, then disable * paging and complete the switch to legacy 32-bit mode. */ - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP movw $__KERNEL_DS, %dx movl $(CR0_STATE & ~X86_CR0_PG), %eax @@ -241,6 +257,7 @@ SYM_DATA_START(trampoline_header) SYM_DATA(tr_efer, .space 8) SYM_DATA(tr_cr4, .space 4) SYM_DATA(tr_flags, .space 4) + SYM_DATA(tr_lock, .space 4) SYM_DATA_END(trampoline_header) #include "trampoline_common.S" From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521323.809996 (Exim 4.92) (envelope-from ) id 1pnTAP-0005x1-Ku; Fri, 14 Apr 2023 23:49:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521323.809996; Fri, 14 Apr 2023 23:49:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAP-0005wb-DJ; Fri, 14 Apr 2023 23:49:21 +0000 Received: by outflank-mailman (input) for mailman id 521323; Fri, 14 Apr 2023 23:49:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6B-0001Th-2o for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:59 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d9b13d7-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d9b13d7-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.880220709@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=auQqEwsU9PrP6dmLhZ2HNf+yKNnP8AcVm6NVRhQvyDs=; b=UQ9zo5ANA3bXro6uBe1FOBxXvcfoSQEiD24Xrn7vh8KjSNUhNMcqLW1wljHJEJ+e8j4GDJ N1EWMYIroPUN4YgTfbVjru09sBWEDKR5SQth1/0kGQgcTNZpj5XjpFfxTvJhJa1qZtvmXw wJMkqQYqdVRSHK1GBFiS97ApX5A77MdAt+hpRt1LADSzZH/uFNSbjXsbu3HZBSvh8G0y2P EK0CnndcvpELSRQBHbYZKRgcaUhr6Z8TtUOgSj+l3dKGuu0eZBB3TQY8X7TLCDbAdL4JaV dJXPejZzrfw0jpwXNhC/giE+cyNnTnS/yF70lli9Oe14OjMbSX5LRocaBNalvA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=auQqEwsU9PrP6dmLhZ2HNf+yKNnP8AcVm6NVRhQvyDs=; b=3UjUp0tk+qEdheiIONrPumzFg6y/RDymanoMKy3WCuwS6WRIh+kUkt2pm7bfL23mY4jSCI ishR5iLfVIQKiiCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 27/37] cpu/hotplug: Remove unused state functions References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:57 +0200 (CEST) All users converted to the hotplug core mechanism. Signed-off-by: Thomas Gleixner --- include/linux/cpu.h | 2 - kernel/smpboot.c | 75 ---------------------------------------------------- 2 files changed, 77 deletions(-) --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -193,8 +193,6 @@ static inline void play_idle(unsigned lo } #ifdef CONFIG_HOTPLUG_CPU -bool cpu_wait_death(unsigned int cpu, int seconds); -bool cpu_report_death(void); void cpuhp_report_idle_dead(void); #else static inline void cpuhp_report_idle_dead(void) { } --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -325,78 +325,3 @@ void smpboot_unregister_percpu_thread(st cpus_read_unlock(); } EXPORT_SYMBOL_GPL(smpboot_unregister_percpu_thread); - -#ifndef CONFIG_HOTPLUG_CORE_SYNC -static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); - -#ifdef CONFIG_HOTPLUG_CPU -/* - * Wait for the specified CPU to exit the idle loop and die. - */ -bool cpu_wait_death(unsigned int cpu, int seconds) -{ - int jf_left = seconds * HZ; - int oldstate; - bool ret = true; - int sleep_jf = 1; - - might_sleep(); - - /* The outgoing CPU will normally get done quite quickly. */ - if (atomic_read(&per_cpu(cpu_hotplug_state, cpu)) == CPU_DEAD) - goto update_state_early; - udelay(5); - - /* But if the outgoing CPU dawdles, wait increasingly long times. */ - while (atomic_read(&per_cpu(cpu_hotplug_state, cpu)) != CPU_DEAD) { - schedule_timeout_uninterruptible(sleep_jf); - jf_left -= sleep_jf; - if (jf_left <= 0) - break; - sleep_jf = DIV_ROUND_UP(sleep_jf * 11, 10); - } -update_state_early: - oldstate = atomic_read(&per_cpu(cpu_hotplug_state, cpu)); -update_state: - if (oldstate == CPU_DEAD) { - /* Outgoing CPU died normally, update state. */ - smp_mb(); /* atomic_read() before update. */ - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_POST_DEAD); - } else { - /* Outgoing CPU still hasn't died, set state accordingly. */ - if (!atomic_try_cmpxchg(&per_cpu(cpu_hotplug_state, cpu), - &oldstate, CPU_BROKEN)) - goto update_state; - ret = false; - } - return ret; -} - -/* - * Called by the outgoing CPU to report its successful death. Return - * false if this report follows the surviving CPU's timing out. - * - * A separate "CPU_DEAD_FROZEN" is used when the surviving CPU - * timed out. This approach allows architectures to omit calls to - * cpu_check_up_prepare() and cpu_set_state_online() without defeating - * the next cpu_wait_death()'s polling loop. - */ -bool cpu_report_death(void) -{ - int oldstate; - int newstate; - int cpu = smp_processor_id(); - - oldstate = atomic_read(&per_cpu(cpu_hotplug_state, cpu)); - do { - if (oldstate != CPU_BROKEN) - newstate = CPU_DEAD; - else - newstate = CPU_DEAD_FROZEN; - } while (!atomic_try_cmpxchg(&per_cpu(cpu_hotplug_state, cpu), - &oldstate, newstate)); - return newstate == CPU_DEAD; -} - -#endif /* #ifdef CONFIG_HOTPLUG_CPU */ -#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521332.810009 (Exim 4.92) (envelope-from ) id 1pnTAT-0006gO-4R; Fri, 14 Apr 2023 23:49:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521332.810009; Fri, 14 Apr 2023 23:49:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAS-0006eU-TR; Fri, 14 Apr 2023 23:49:24 +0000 Received: by outflank-mailman (input) for mailman id 521332; Fri, 14 Apr 2023 23:49:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6M-0000zb-9S for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:10 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 635bc938-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 635bc938-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.254849089@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=qlj4H3ejL+vBUDG3NY1lMMcGFIiTzrSNA2aqLKlihDE=; b=1GQ0vgasLWqRcJWgIXPbXDmKUvXohkJnXHYow4+Gk18ZVkMCsGTyrDjPv1CmK6RbyQU3xy sZOnCBi1gUZHMhyRrfBhTMtqyNFDPJ6vIKz6V9GUUqs40cNvVEv7vD+CBHvRT0wd1gUl1d 6b2tSiphU+RGH9LMrzC1SBAlXe4ncrHHHmvCSojPNfdfYrCZOS3cqdN5dvg1mrwkF+zHKS ZggDxsStwqH0PgeAnVkNUSmrn0NxE/MFHr8xTSF8rH/8cE10sWA0KKqw6/zjLrvWcuBEms WRc4LjINHUoNtUJjSQE1O0a6vHatkwkifR+Lal+9Qf7z5SXlNpUbZu7h4WPnRg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=qlj4H3ejL+vBUDG3NY1lMMcGFIiTzrSNA2aqLKlihDE=; b=QX/aw2ZRTXXvpaXqpLyn2DL7d4KHZGqZGPQ3AUK084YoY4i+oS2d15EjnpvV8yHLp9Q5Sc 902bNwcd/YuBSyBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 33/37] x86/topology: Store extended topology leaf information References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:07 +0200 (CEST) Save the extended topology leaf number if it exists and is valid in preparation of parallel CPU bringup. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/topology.h | 1 + arch/x86/kernel/cpu/topology.c | 3 +++ 2 files changed, 4 insertions(+) --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -121,6 +121,7 @@ extern unsigned int __max_die_per_packag #define topology_core_cpumask(cpu) (per_cpu(cpu_core_map, cpu)) #define topology_sibling_cpumask(cpu) (per_cpu(cpu_sibling_map, cpu)) +extern unsigned int topology_extended_leaf; extern unsigned int __max_logical_packages; #define topology_max_packages() (__max_logical_packages) --- a/arch/x86/kernel/cpu/topology.c +++ b/arch/x86/kernel/cpu/topology.c @@ -29,6 +29,8 @@ unsigned int __max_die_per_package __rea EXPORT_SYMBOL(__max_die_per_package); #ifdef CONFIG_SMP +unsigned int topology_extended_leaf __read_mostly; + /* * Check if given CPUID extended topology "leaf" is implemented */ @@ -72,6 +74,7 @@ int detect_extended_topology_early(struc if (leaf < 0) return -1; + topology_extended_leaf = leaf; set_cpu_cap(c, X86_FEATURE_XTOPOLOGY); cpuid_count(leaf, SMT_LEVEL, &eax, &ebx, &ecx, &edx); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521328.810005 (Exim 4.92) (envelope-from ) id 1pnTAS-0006XD-Fv; Fri, 14 Apr 2023 23:49:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521328.810005; Fri, 14 Apr 2023 23:49:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAS-0006Wc-9f; Fri, 14 Apr 2023 23:49:24 +0000 Received: by outflank-mailman (input) for mailman id 521328; Fri, 14 Apr 2023 23:49:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6J-0000zb-9G for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:07 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6158ef05-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6158ef05-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.128590508@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1po2rJ4fVgJP8Lz7zlVuql3iIT5xp2VpR+B+sueZaiQ=; b=j2f464LqemKF5EyymLaTszAtW5FGztj8vmPcDPj1wK7YU7fOHNTdZk2/K8gAJFZq9pfDGY 5swh08e6d90aHqmMGF6WkIyj8axPVjUxuJuAViwZJ1cdvU6xcoF9zb87nqcct5XNmsoX0o Y0cHSVhAJwX30WEOO0lshPZ8xsXVjRD0fZRGdhHxX3DVdfFiIehL5+rfIQAY4cxNaAwRps 53guQBH31H4F+J1+vPDF/UwhFysy5n0UHaveg6UXzsIamQzkfs0Z0QqIZPRxbWQld5Mev3 7k6omsH4VccEFnKEdLPC9J1LIDlQw0AxGEp7j6OfTQ3DxOTM+UbH+I/cU+I8Bw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1po2rJ4fVgJP8Lz7zlVuql3iIT5xp2VpR+B+sueZaiQ=; b=H0vP+GAKFQrHzIZje+HAambScu8P4RD3X0xBakqALypG7Ph1OaLTUgdSgEHGbKo8mVzf0A CNqZe/l3Ol72rcBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 31/37] x86/apic: Provide cpu_primary_thread mask References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:03 +0200 (CEST) Make the primary thread tracking CPU mask based in preparation for simpler handling of parallel bootup. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/apic.h | 2 -- arch/x86/include/asm/topology.h | 19 +++++++++++++++---- arch/x86/kernel/apic/apic.c | 20 +++++++++----------- arch/x86/kernel/smpboot.c | 12 +++--------- 4 files changed, 27 insertions(+), 26 deletions(-) --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -506,10 +506,8 @@ extern int default_check_phys_apicid_pre #endif /* CONFIG_X86_LOCAL_APIC */ #ifdef CONFIG_SMP -bool apic_id_is_primary_thread(unsigned int id); void apic_smt_update(void); #else -static inline bool apic_id_is_primary_thread(unsigned int id) { return false; } static inline void apic_smt_update(void) { } #endif --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -31,9 +31,9 @@ * CONFIG_NUMA. */ #include +#include #ifdef CONFIG_NUMA -#include #include #include @@ -139,9 +139,20 @@ static inline int topology_max_smt_threa int topology_update_package_map(unsigned int apicid, unsigned int cpu); int topology_update_die_map(unsigned int dieid, unsigned int cpu); int topology_phys_to_logical_pkg(unsigned int pkg); -bool topology_is_primary_thread(unsigned int cpu); bool topology_smt_supported(void); -#else + +extern struct cpumask __cpu_primary_thread_mask; +#define cpu_primary_thread_mask ((const struct cpumask *)&__cpu_primary_thread_mask) + +/** + * topology_is_primary_thread - Check whether CPU is the primary SMT thread + * @cpu: CPU to check + */ +static inline bool topology_is_primary_thread(unsigned int cpu) +{ + return cpumask_test_cpu(cpu, cpu_primary_thread_mask); +} +#else /* CONFIG_SMP */ #define topology_max_packages() (1) static inline int topology_update_package_map(unsigned int apicid, unsigned int cpu) { return 0; } @@ -152,7 +163,7 @@ static inline int topology_max_die_per_p static inline int topology_max_smt_threads(void) { return 1; } static inline bool topology_is_primary_thread(unsigned int cpu) { return true; } static inline bool topology_smt_supported(void) { return false; } -#endif +#endif /* !CONFIG_SMP */ static inline void arch_fix_phys_package_id(int num, u32 slot) { --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2387,20 +2387,16 @@ bool arch_match_cpu_phys_id(int cpu, u64 } #ifdef CONFIG_SMP -/** - * apic_id_is_primary_thread - Check whether APIC ID belongs to a primary thread - * @apicid: APIC ID to check - */ -bool apic_id_is_primary_thread(unsigned int apicid) +static void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid) { - u32 mask; - - if (smp_num_siblings == 1) - return true; /* Isolate the SMT bit(s) in the APICID and check for 0 */ - mask = (1U << (fls(smp_num_siblings) - 1)) - 1; - return !(apicid & mask); + u32 mask = (1U << (fls(smp_num_siblings) - 1)) - 1; + + if (smp_num_siblings == 1 || !(apicid & mask)) + cpumask_set_cpu(cpu, &__cpu_primary_thread_mask); } +#else +static inline void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid) { } #endif /* @@ -2545,6 +2541,8 @@ int generic_processor_info(int apicid, i set_cpu_present(cpu, true); num_processors++; + cpu_mark_primary_thread(cpu, apicid); + return cpu; } --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -102,6 +102,9 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); +/* CPUs which are the primary SMT threads */ +struct cpumask __cpu_primary_thread_mask __read_mostly; + /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -294,15 +297,6 @@ static void notrace start_secondary(void } /** - * topology_is_primary_thread - Check whether CPU is the primary SMT thread - * @cpu: CPU to check - */ -bool topology_is_primary_thread(unsigned int cpu) -{ - return apic_id_is_primary_thread(per_cpu(x86_cpu_to_apicid, cpu)); -} - -/** * topology_smt_supported - Check whether SMT is supported by the CPUs */ bool topology_smt_supported(void) From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521346.810025 (Exim 4.92) (envelope-from ) id 1pnTAd-0008M0-Nf; Fri, 14 Apr 2023 23:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521346.810025; Fri, 14 Apr 2023 23:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAd-0008Lr-Gf; Fri, 14 Apr 2023 23:49:35 +0000 Received: by outflank-mailman (input) for mailman id 521346; Fri, 14 Apr 2023 23:49:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT64-0001Th-In for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:52 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 599e35f4-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 599e35f4-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.631170657@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=y6SldvuVXq/pw8ptav6ZzZhZk50vNE0+ALorGdATBvE=; b=j7ir4M38uyCqNd0WpGFhlMbHqqP22sIUkP6lTXCI4ZoMelPAhB0ZW3jUKq/qNg7dgtIPyr wAgHvssp340UT3vn/QZsaFN0BbxJz/50Bk2j/ViCY7pmbdjJltpv6UUhTwyesp5uV/hH5R rn30yImLh2MbCenzGtlPdqYodmJQsWXgthmyh3VDgg8IsWfSP8TgZqODKQUJwz+InU8in3 FyxZW7Fp+CUcayGzDXYKM02cvf34xnDKNWTxsXl+QFRwELU5xV0mCQa2KjOMor4Q501Rct 0HVatbGD4qEO2xAAV9X3ZovODF8RAMi5ZzvUu9hOjJPsLeNkmpDExwTMMJ6FBg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=y6SldvuVXq/pw8ptav6ZzZhZk50vNE0+ALorGdATBvE=; b=Qg+tSuukciCk/31JBTMbNipFvroQgicaNOn31ON18qthuCRxjFkOmjqqsu/6PGW7nvHreJ GQLRpem8ebEejbCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Guo Ren , linux-csky@vger.kernel.org, David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 23/37] csky/smp: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:50 +0200 (CEST) Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Guo Ren Cc: linux-csky@vger.kernel.org --- arch/csky/Kconfig | 1 + arch/csky/include/asm/smp.h | 2 +- arch/csky/kernel/smp.c | 8 ++------ 3 files changed, 4 insertions(+), 7 deletions(-) --- a/arch/csky/Kconfig +++ b/arch/csky/Kconfig @@ -96,6 +96,7 @@ config CSKY select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select MAY_HAVE_SPARSE_IRQ select MODULES_USE_ELF_RELA if MODULES select OF --- a/arch/csky/include/asm/smp.h +++ b/arch/csky/include/asm/smp.h @@ -23,7 +23,7 @@ void __init set_send_ipi(void (*func)(co int __cpu_disable(void); -void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } #endif /* CONFIG_SMP */ --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -291,12 +291,8 @@ int __cpu_disable(void) return 0; } -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: shutdown failed\n", cpu); - return; - } pr_notice("CPU%u: shutdown\n", cpu); } @@ -304,7 +300,7 @@ void arch_cpu_idle_dead(void) { idle_task_exit(); - cpu_report_death(); + cpuhp_ap_report_dead(); while (!secondary_stack) arch_cpu_idle(); From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521351.810036 (Exim 4.92) (envelope-from ) id 1pnTAe-0008Uy-Gi; Fri, 14 Apr 2023 23:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521351.810036; Fri, 14 Apr 2023 23:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAe-0008T1-5G; Fri, 14 Apr 2023 23:49:36 +0000 Received: by outflank-mailman (input) for mailman id 521351; Fri, 14 Apr 2023 23:49:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6C-0001Th-NI for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:00 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e954127-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:45:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e954127-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.941680232@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PwaT1nVbkmNxpYn2jntunVyX300rI6JOSPoxKblUFxc=; b=J4d36wqGXDsa4D15fuC6bgECzfAAInQki6KA3SUyC98aD0yQW6gcNLFjQOCHcXv2J+orZG 5Qmhd0e6dbHL514sP/COcIuWz15soNEsWHzEh1yBv2+hd5B8wqzYOidLR2BE5cayvWqW8Z HTkU8Nrl6+H70MJnTBAZDmHlfDfKJpBLY0P7kmzee0usDqsCKruEINfZUsjihRGa5dTOub nsf1V7hsU0pvXa2Ve2ehvBeS9w4NMv0lT4Qar9j26QhzX8zbcfe2cv28EW7JmGjaOXAvGg fSx2t8XhhVFut65VN9kClCBXCqftJpibwk/DAZDt6leoEUA5kSkPTRcDM8b5qA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PwaT1nVbkmNxpYn2jntunVyX300rI6JOSPoxKblUFxc=; b=GT9ybsNnlf8a2CqrpgJaThMxA4ODF78eIoN2mtLu9TxUz4hUltbB6uZ6jFavUSEgOGT604 TxVe7hxr4awf6HAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Mark Rutland , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sabin Rapan Subject: [patch 28/37] cpu/hotplug: Reset task stack state in _cpu_up() References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:59 +0200 (CEST) From: David Woodhouse Commit dce1ca0525bf ("sched/scs: Reset task stack state in bringup_cpu()") ensured that the shadow call stack and KASAN poisoning were removed from a CPU's stack each time that CPU is brought up, not just once. This is not incorrect. However, with parallel bringup the idle thread setup will happen at a different step. As a consequence the cleanup in bringup_cpu() would be too late. Move the SCS/KASAN cleanup to the generic _cpu_up() function instead, which already ensures that the new CPU's stack is available, purely to allow for early failure. This occurs when the CPU to be brought up is in the CPUHP_OFFLINE state, which should correctly do the cleanup any time the CPU has been taken down to the point where such is needed. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Mark Rutland Reviewed-by: Mark Rutland --- kernel/cpu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -769,12 +769,6 @@ static int bringup_cpu(unsigned int cpu) return -EAGAIN; /* - * Reset stale stack state from the last time this CPU was online. - */ - scs_task_reset(idle); - kasan_unpoison_task_stack(idle); - - /* * Some architectures have to walk the irq descriptors to * setup the vector space for the cpu which comes online. * Prevent irq alloc/free across the bringup. @@ -1581,6 +1575,12 @@ static int _cpu_up(unsigned int cpu, int ret = PTR_ERR(idle); goto out; } + + /* + * Reset stale stack state from the last time this CPU was online. + */ + scs_task_reset(idle); + kasan_unpoison_task_stack(idle); } cpuhp_tasks_frozen = tasks_frozen; From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521347.810030 (Exim 4.92) (envelope-from ) id 1pnTAe-0008RI-3H; Fri, 14 Apr 2023 23:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521347.810030; Fri, 14 Apr 2023 23:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAd-0008Qb-So; Fri, 14 Apr 2023 23:49:35 +0000 Received: by outflank-mailman (input) for mailman id 521347; Fri, 14 Apr 2023 23:49:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6N-0000zb-9T for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:11 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6448a52f-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6448a52f-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.316352541@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=2PTnDdSuwes/9NjD8Pm7hXlACOxFTN9vJCNjWOfgGXM=; b=Jh6ZM0Us9GGh285BMnb5fEm77rslh++J6j/QuRkHBnu0IJ3u2WPmnGe/3gdgkhs+Itn6YC EYm2JHM+HCoiKXud+mnLR3pzE3sn62xS6OTtxoSRYTybybUo7HLhqrcnKqV1RwxPAi5wc5 OBp150tG8AHyoMw6+86zMyjFChURpnILiUkhTuUlpHCRtOIbCa3VMT62a8kcqkB8R+gKQ4 U9tfXpB5IVu1MhpvFCVN68arP6yea+vniJ2RVD3n3fNQwQKszlDZIcpnpbeZf4M7nBLa8W ZFeGomntJTFI5LAn96fL2tniH8jRiNy2rM7ZxO27HO46gpoe/qq365pH/j/4pA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=2PTnDdSuwes/9NjD8Pm7hXlACOxFTN9vJCNjWOfgGXM=; b=JDEmTRQRnlWI2RxVIaPHzb6Y3x+BSeHE+/1j/fasD5aAeXT8ZfKeZ96xHuB6wXG5qxyGWZ eqmeypWBVFC7DyAA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 34/37] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:08 +0200 (CEST) The early detection stores the extended topology leaf number which is required for parallel hotplug. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/amd.c | 2 ++ 1 file changed, 2 insertions(+) --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -692,6 +692,8 @@ static void early_init_amd(struct cpuinf } } + detect_extended_topology_early(c); + if (cpu_has(c, X86_FEATURE_TOPOEXT)) smp_num_siblings = ((cpuid_ebx(0x8000001e) >> 8) & 0xff) + 1; } From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521356.810055 (Exim 4.92) (envelope-from ) id 1pnTAh-0000yR-6M; Fri, 14 Apr 2023 23:49:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521356.810055; Fri, 14 Apr 2023 23:49:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAg-0000xI-Kl; Fri, 14 Apr 2023 23:49:38 +0000 Received: by outflank-mailman (input) for mailman id 521356; Fri, 14 Apr 2023 23:49:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5w-0001Th-NI for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:44 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54bdfe16-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54bdfe16-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.319386819@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7hAm6I9MiGtPmIXfa24B9PQ6b2IikPrY0L+IvEnJvPI=; b=jK/GS8nzEcoNMYUK0AKSW91HahqfcKmgmQ+JtmtDnur9HSlYdew/SITlGW5QELStSGh6Q/ V57WOhEWSVSxWZWhG3SaBczDcMaraK+itB6zsiGdpLQtzoC7yxxSloqDZW6B4Njz8MWDbR miMPGsiCOdTRydFFdFmiS70GYeAIK8oBwYAUlay9JYTfVbSXJ63AXiImeMdnSL+M470Et5 VfCBSEigMVHivkoKuqa+6Tu/41+RxN+9jOUZtcMtyT4RoQND7Pp1xwtWviW33NcuD2Qa/G AC+ABgPHvS+/XtBUfn+u5LoukNQ3JpVGWaLmycJWPrCSc7LATrT2CKreEiN1ng== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7hAm6I9MiGtPmIXfa24B9PQ6b2IikPrY0L+IvEnJvPI=; b=IpKwz96GwSWUZ2KDbHlOo0nFprwPP3s9jahoNB/qpcC8qkXn9/Q9MaoBQo6UsIzMi7+Hea LODiZVcbnARULPAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 18/37] cpu/hotplug: Add CPU state tracking and synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:42 +0200 (CEST) The CPU state tracking and synchronization mechanism in smpboot.c is completely independent of the hotplug code and all logic around it is implemented in architecture specific code. Except for the state reporting of the AP there is absolutely nothing architecture specific and the sychronization and decision functions can be moved into the generic hotplug core code. Provide an integrated variant and add the core synchronization and decision points. This comes in two flavours: 1) DEAD state synchronization Updated by the architecture code once the AP reaches the point where it is ready to be torn down by the control CPU, e.g. by removing power or clocks or tear down via the hypervisor. The control CPU waits for this state to be reached with a timeout. If the state is reached an architecture specific cleanup function is invoked. 2) Full state synchronization This extends #1 with AP alive synchronization. This is new functionality, which allows to replace architecture specific wait mechanims, e.g. cpumasks, completely. It also prevents that an AP which is in a limbo state can be brought up again. This can happen when an AP failed to report dead state during a previous off-line operation. The dead synchronization is what most architectures use. Only x86 makes a bringup decision based on that state at the moment. Signed-off-by: Thomas Gleixner --- arch/Kconfig | 15 +++ include/linux/cpuhotplug.h | 12 ++ kernel/cpu.c | 193 ++++++++++++++++++++++++++++++++++++++++++++- kernel/smpboot.c | 2 4 files changed, 221 insertions(+), 1 deletion(-) --- a/arch/Kconfig +++ b/arch/Kconfig @@ -34,6 +34,21 @@ config ARCH_HAS_SUBPAGE_FAULTS config HOTPLUG_SMT bool +# Selected by HOTPLUG_CORE_SYNC_DEAD or HOTPLUG_CORE_SYNC_FULL +config HOTPLUG_CORE_SYNC + bool + +# Basic CPU dead synchronization selected by architecture +config HOTPLUG_CORE_SYNC_DEAD + bool + select HOTPLUG_CORE_SYNC + +# Full CPU synchronization with alive state selected by architecture +config HOTPLUG_CORE_SYNC_FULL + bool + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU + select HOTPLUG_CORE_SYNC + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -519,4 +519,16 @@ void cpuhp_online_idle(enum cpuhp_state static inline void cpuhp_online_idle(enum cpuhp_state state) { } #endif +void cpuhp_ap_sync_alive(void); +void arch_cpuhp_sync_state_poll(void); +void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD +void cpuhp_ap_report_dead(void); +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu); +#else +static inline void cpuhp_ap_report_dead(void) { } +static inline void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { } +#endif + #endif --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -59,6 +60,7 @@ * @last: For multi-instance rollback, remember how far we got * @cb_state: The state for a single callback (install/uninstall) * @result: Result of the operation + * @ap_sync_state: State for AP synchronization * @done_up: Signal completion to the issuer of the task for cpu-up * @done_down: Signal completion to the issuer of the task for cpu-down */ @@ -76,6 +78,7 @@ struct cpuhp_cpu_state { struct hlist_node *last; enum cpuhp_state cb_state; int result; + atomic_t ap_sync_state; struct completion done_up; struct completion done_down; #endif @@ -276,6 +279,182 @@ static bool cpuhp_is_atomic_state(enum c return CPUHP_AP_IDLE_DEAD <= state && state < CPUHP_AP_ONLINE; } +/* Synchronization state management */ +enum cpuhp_sync_state { + SYNC_STATE_DEAD, + SYNC_STATE_KICKED, + SYNC_STATE_SHOULD_DIE, + SYNC_STATE_ALIVE, + SYNC_STATE_SHOULD_ONLINE, + SYNC_STATE_ONLINE, +}; + +#ifdef CONFIG_HOTPLUG_CORE_SYNC +/** + * cpuhp_ap_update_sync_state - Update synchronization state during bringup/teardown + * @state: The synchronization state to set + * + * No synchronization point. Just update of the synchronization state. + */ +static inline void cpuhp_ap_update_sync_state(enum cpuhp_sync_state state) +{ + atomic_t *st = this_cpu_ptr(&cpuhp_state.ap_sync_state); + int sync = atomic_read(st); + + while (!atomic_try_cmpxchg(st, &sync, state)); +} + +void __weak arch_cpuhp_sync_state_poll(void) { cpu_relax(); } + +static bool cpuhp_wait_for_sync_state(unsigned int cpu, enum cpuhp_sync_state state, + enum cpuhp_sync_state next_state) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + ktime_t now, end, start = ktime_get(); + int sync; + + end = start + 10ULL * NSEC_PER_SEC; + + sync = atomic_read(st); + while (1) { + if (sync == state) { + if (!atomic_try_cmpxchg(st, &sync, next_state)) + continue; + return true; + } + + now = ktime_get(); + if (now > end) { + /* Timeout. Leave the state unchanged */ + return false; + } else if (now - start < NSEC_PER_MSEC) { + /* Poll for one millisecond */ + arch_cpuhp_sync_state_poll(); + } else { + usleep_range_state(USEC_PER_MSEC, 2 * USEC_PER_MSEC, TASK_UNINTERRUPTIBLE); + } + sync = atomic_read(st); + } + return true; +} +#else /* CONFIG_HOTPLUG_CORE_SYNC */ +static inline void cpuhp_ap_update_sync_state(enum cpuhp_sync_state state) { } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD +/** + * cpuhp_ap_report_dead - Update synchronization state to DEAD + * + * No synchronization point. Just update of the synchronization state. + */ +void cpuhp_ap_report_dead(void) +{ + cpuhp_ap_update_sync_state(SYNC_STATE_DEAD); +} + +void __weak arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { } + +/* + * Late CPU shutdown synchronization point. Cannot use cpuhp_state::done_down + * because the AP cannot issue complete() at this stage. + */ +static void cpuhp_bp_sync_dead(unsigned int cpu) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + int sync = atomic_read(st); + + do { + /* CPU can have reported dead already. Don't overwrite that! */ + if (sync == SYNC_STATE_DEAD) + break; + } while (!atomic_try_cmpxchg(st, &sync, SYNC_STATE_SHOULD_DIE)); + + if (cpuhp_wait_for_sync_state(cpu, SYNC_STATE_DEAD, SYNC_STATE_DEAD)) { + /* CPU reached dead state. Invoke the cleanup function */ + arch_cpuhp_cleanup_dead_cpu(cpu); + return; + } + + /* No further action possible. Emit message and give up. */ + pr_err("CPU%u failed to report dead state\n", cpu); +} +#else /* CONFIG_HOTPLUG_CORE_SYNC_DEAD */ +static inline void cpuhp_bp_sync_dead(unsigned int cpu) { } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC_DEAD */ + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_FULL +/** + * cpuhp_ap_sync_alive - Synchronize AP with the control CPU once it is alive + * + * Updates the AP synchronization state to SYNC_STATE_ALIVE and waits + * for the BP to release it. + */ +void cpuhp_ap_sync_alive(void) +{ + atomic_t *st = this_cpu_ptr(&cpuhp_state.ap_sync_state); + + cpuhp_ap_update_sync_state(SYNC_STATE_ALIVE); + + /* Wait for the control CPU to release it. */ + while (atomic_read(st) != SYNC_STATE_SHOULD_ONLINE) + cpu_relax(); +} + +static bool cpuhp_can_boot_ap(unsigned int cpu) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + int sync = atomic_read(st); + +again: + switch (sync) { + case SYNC_STATE_DEAD: + /* CPU is properly dead */ + break; + case SYNC_STATE_KICKED: + /* CPU did not come up in previous attempt */ + break; + case SYNC_STATE_ALIVE: + /* CPU is stuck cpuhp_ap_sync_alive(). */ + break; + default: + /* CPU failed to report online or dead and is in limbo state. */ + return false; + } + + /* Prepare for booting */ + if (!atomic_try_cmpxchg(st, &sync, SYNC_STATE_KICKED)) + goto again; + + return true; +} + +void __weak arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) { } + +/* + * Early CPU bringup synchronization point. Cannot use cpuhp_state::done_up + * because the AP cannot issue complete() so early in the bringup. + */ +static int cpuhp_bp_sync_alive(unsigned int cpu) +{ + int ret = 0; + + if (!IS_ENABLED(CONFIG_HOTPLUG_CORE_SYNC_FULL)) + return 0; + + if (!cpuhp_wait_for_sync_state(cpu, SYNC_STATE_ALIVE, SYNC_STATE_SHOULD_ONLINE)) { + pr_err("CPU%u failed to report alive state\n", cpu); + ret = -EIO; + } + + /* Let the architecture cleanup the kick alive mechanics. */ + arch_cpuhp_cleanup_kick_cpu(cpu); + return ret; +} +#else /* CONFIG_HOTPLUG_CORE_SYNC_FULL */ +static inline int cpuhp_bp_sync_alive(unsigned int cpu) { return 0; } +static inline bool cpuhp_can_boot_ap(unsigned int cpu) { return true; } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC_FULL */ + /* Serializes the updates to cpu_online_mask, cpu_present_mask */ static DEFINE_MUTEX(cpu_add_remove_lock); bool cpuhp_tasks_frozen; @@ -588,6 +767,9 @@ static int bringup_cpu(unsigned int cpu) struct task_struct *idle = idle_thread_get(cpu); int ret; + if (!cpuhp_can_boot_ap(cpu)) + return -EAGAIN; + /* * Reset stale stack state from the last time this CPU was online. */ @@ -606,6 +788,10 @@ static int bringup_cpu(unsigned int cpu) if (ret) goto out_unlock; + ret = cpuhp_bp_sync_alive(cpu); + if (ret) + goto out_unlock; + ret = bringup_wait_for_ap_online(cpu); if (ret) goto out_unlock; @@ -1109,6 +1295,8 @@ static int takedown_cpu(unsigned int cpu /* This actually kills the CPU. */ __cpu_die(cpu); + cpuhp_bp_sync_dead(cpu); + tick_cleanup_dead_cpu(cpu); rcutree_migrate_callbacks(cpu); return 0; @@ -1355,8 +1543,10 @@ void cpuhp_online_idle(enum cpuhp_state if (state != CPUHP_AP_ONLINE_IDLE) return; + cpuhp_ap_update_sync_state(SYNC_STATE_ONLINE); + /* - * Unpart the stopper thread before we start the idle loop (and start + * Unpark the stopper thread before we start the idle loop (and start * scheduling); this ensures the stopper task is always available. */ stop_machine_unpark(smp_processor_id()); @@ -2722,6 +2912,7 @@ void __init boot_cpu_hotplug_init(void) { #ifdef CONFIG_SMP cpumask_set_cpu(smp_processor_id(), &cpus_booted_once_mask); + atomic_set(this_cpu_ptr(&cpuhp_state.ap_sync_state), SYNC_STATE_ONLINE); #endif this_cpu_write(cpuhp_state.state, CPUHP_ONLINE); this_cpu_write(cpuhp_state.target, CPUHP_ONLINE); --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -326,6 +326,7 @@ void smpboot_unregister_percpu_thread(st } EXPORT_SYMBOL_GPL(smpboot_unregister_percpu_thread); +#ifndef CONFIG_HOTPLUG_CORE_SYNC static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); /* @@ -488,3 +489,4 @@ bool cpu_report_death(void) } #endif /* #ifdef CONFIG_HOTPLUG_CPU */ +#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521358.810060 (Exim 4.92) (envelope-from ) id 1pnTAi-0001FV-2g; Fri, 14 Apr 2023 23:49:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521358.810060; Fri, 14 Apr 2023 23:49:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAh-0001BO-SR; Fri, 14 Apr 2023 23:49:39 +0000 Received: by outflank-mailman (input) for mailman id 521358; Fri, 14 Apr 2023 23:49:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT64-0000zb-7Z for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:52 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56a62801-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:44:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56a62801-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232310.444204883@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=OJmMK1DNsYZsN6fUmGwfeq4ERjaNgScwoVZRQqH8yUw=; b=GcFPtrg7k9VQxG3rMlumRMw5nuKtsJmdDMoJ6TSceXuK1zdHd+N9joDWuAZdo46YFNxZMP Bsg8W/+6nBYJRVuCztzAyHJQvPJSb23Tablj/SGjhsX/WUeCrmSA9nsuhw8G2JGX2NZ97t THjsQ+3MT5axiGFvQ/sUAHek0hFvHwgQKNG5VvKo8oZKr/4skgr04uS53dj+ol0BYWxhal 5oIGYZdmtf3qGjw5V88nnPJqYy7bxEgNOIlxEv9+tW18PGEfux4IdshBI1Y1RLHv+TPNLz Ddqx3nRleBLOQcei7th1ojLHd0sg0KKVmzdvEaltZ8B7BxlHVYGVjXaqhkZyww== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=OJmMK1DNsYZsN6fUmGwfeq4ERjaNgScwoVZRQqH8yUw=; b=l2/PUI4LfABzfYrIQxeqJjxovlQLjpZzH9GEF/bgX07OlI0hCc/156VAzkEe/0KLuss+2I g5EEfqF03SuN2wDg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 20/37] cpu/hotplug: Remove cpu_report_state() and related unused cruft References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:46 +0200 (CEST) No more users. Signed-off-by: Thomas Gleixner --- include/linux/cpu.h | 2 - kernel/smpboot.c | 90 ---------------------------------------------------- 2 files changed, 92 deletions(-) --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -184,8 +184,6 @@ void arch_cpu_idle_enter(void); void arch_cpu_idle_exit(void); void arch_cpu_idle_dead(void); -int cpu_report_state(int cpu); -int cpu_check_up_prepare(int cpu); void cpu_set_state_online(int cpu); void play_idle_precise(u64 duration_ns, u64 latency_ns); --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -329,97 +329,7 @@ EXPORT_SYMBOL_GPL(smpboot_unregister_per #ifndef CONFIG_HOTPLUG_CORE_SYNC static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); -/* - * Called to poll specified CPU's state, for example, when waiting for - * a CPU to come online. - */ -int cpu_report_state(int cpu) -{ - return atomic_read(&per_cpu(cpu_hotplug_state, cpu)); -} - -/* - * If CPU has died properly, set its state to CPU_UP_PREPARE and - * return success. Otherwise, return -EBUSY if the CPU died after - * cpu_wait_death() timed out. And yet otherwise again, return -EAGAIN - * if cpu_wait_death() timed out and the CPU still hasn't gotten around - * to dying. In the latter two cases, the CPU might not be set up - * properly, but it is up to the arch-specific code to decide. - * Finally, -EIO indicates an unanticipated problem. - * - * Note that it is permissible to omit this call entirely, as is - * done in architectures that do no CPU-hotplug error checking. - */ -int cpu_check_up_prepare(int cpu) -{ - if (!IS_ENABLED(CONFIG_HOTPLUG_CPU)) { - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_UP_PREPARE); - return 0; - } - - switch (atomic_read(&per_cpu(cpu_hotplug_state, cpu))) { - - case CPU_POST_DEAD: - - /* The CPU died properly, so just start it up again. */ - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_UP_PREPARE); - return 0; - - case CPU_DEAD_FROZEN: - - /* - * Timeout during CPU death, so let caller know. - * The outgoing CPU completed its processing, but after - * cpu_wait_death() timed out and reported the error. The - * caller is free to proceed, in which case the state - * will be reset properly by cpu_set_state_online(). - * Proceeding despite this -EBUSY return makes sense - * for systems where the outgoing CPUs take themselves - * offline, with no post-death manipulation required from - * a surviving CPU. - */ - return -EBUSY; - - case CPU_BROKEN: - - /* - * The most likely reason we got here is that there was - * a timeout during CPU death, and the outgoing CPU never - * did complete its processing. This could happen on - * a virtualized system if the outgoing VCPU gets preempted - * for more than five seconds, and the user attempts to - * immediately online that same CPU. Trying again later - * might return -EBUSY above, hence -EAGAIN. - */ - return -EAGAIN; - - case CPU_UP_PREPARE: - /* - * Timeout while waiting for the CPU to show up. Allow to try - * again later. - */ - return 0; - - default: - - /* Should not happen. Famous last words. */ - return -EIO; - } -} - -/* - * Mark the specified CPU online. - * - * Note that it is permissible to omit this call entirely, as is - * done in architectures that do no CPU-hotplug error checking. - */ -void cpu_set_state_online(int cpu) -{ - (void)atomic_xchg(&per_cpu(cpu_hotplug_state, cpu), CPU_ONLINE); -} - #ifdef CONFIG_HOTPLUG_CPU - /* * Wait for the specified CPU to exit the idle loop and die. */ From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521366.810075 (Exim 4.92) (envelope-from ) id 1pnTAk-0001vY-Uk; Fri, 14 Apr 2023 23:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521366.810075; Fri, 14 Apr 2023 23:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAk-0001vH-KN; Fri, 14 Apr 2023 23:49:42 +0000 Received: by outflank-mailman (input) for mailman id 521366; Fri, 14 Apr 2023 23:49:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6I-0000zb-9F for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:06 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 605f8973-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 605f8973-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.066246849@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=cY/Vb0k8l53HgnPO915OdGCDzaj2v7X/LK/0bhlR+ZM=; b=Rl28BYLRw1xoqBY2XVna4334ensDR9FZzUXIXCLNtZ0ZnRftdKxlp0PMWMq1HaFMs/Nvoh XqGn6TtnTp761vrtUa5+ABOqgv49/+dDRkb1k96bmalthN4bjNP4h3EacgIX7TIRoFoQ1L UV+FOsaKzNfqWlzPpun3ecs+zhYGqo6qHGZzsNZ57SQvznqryxMS+L3SqK9W/dGy+VDKv9 YxTV8knnunEjK8aSQH5isteVb77I0eCsLEqmlSmZcWsTyG9EdV1bj0iMexF7biZ5gNOCfj ROw3zMy677VniDryW+1xRSofiRytmHDazA6lDPsXJmr7uXM+XbDSfwEveQWQlQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=cY/Vb0k8l53HgnPO915OdGCDzaj2v7X/LK/0bhlR+ZM=; b=D1VjUKIFe77+cdNW6ebx9l5dhZNCMlm+6Ti8d+rxHqlUBIfv17CftGyUs1Xi5cbqbTIHp+ wg0OL2V4Mj/Lh/Bw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 30/37] x86/smpboot: Enable split CPU startup References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:02 +0200 (CEST) The x86 CPU bringup state currently does AP wake-up, wait for AP to respond and then release it for full bringup. It is safe to be split into a wake-up and and a separate wait+release state. Provide the required functions and enable the split CPU bringup, which prepares for parallel bringup, where the bringup of the non-boot CPUs takes two iterations: One to prepare and wake all APs and the second to wait and release them. Depending on timing this can eliminate the wait time completely. Signed-off-by: Thomas Gleixner --- arch/x86/Kconfig | 2 +- arch/x86/include/asm/smp.h | 9 ++------- arch/x86/kernel/smp.c | 2 +- arch/x86/kernel/smpboot.c | 8 ++++---- arch/x86/xen/smp_pv.c | 4 ++-- 5 files changed, 10 insertions(+), 15 deletions(-) --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -272,8 +272,8 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO - select HOTPLUG_CORE_SYNC_FULL if SMP select HOTPLUG_SMT if SMP + select HOTPLUG_SPLIT_STARTUP if SMP select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK select NEED_PER_CPU_PAGE_FIRST_CHUNK --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -40,7 +40,7 @@ struct smp_ops { void (*cleanup_dead_cpu)(unsigned cpu); void (*poll_sync_state)(void); - int (*cpu_up)(unsigned cpu, struct task_struct *tidle); + int (*kick_ap_alive)(unsigned cpu, struct task_struct *tidle); int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); void (*play_dead)(void); @@ -80,11 +80,6 @@ static inline void smp_cpus_done(unsigne smp_ops.smp_cpus_done(max_cpus); } -static inline int __cpu_up(unsigned int cpu, struct task_struct *tidle) -{ - return smp_ops.cpu_up(cpu, tidle); -} - static inline int __cpu_disable(void) { return smp_ops.cpu_disable(); @@ -123,7 +118,7 @@ void native_smp_prepare_cpus(unsigned in void calculate_max_logical_packages(void); void native_smp_cpus_done(unsigned int max_cpus); int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); -int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); +int native_kick_ap(unsigned int cpu, struct task_struct *tidle); int native_cpu_disable(void); void hlt_play_dead(void); void native_play_dead(void); --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -268,7 +268,7 @@ struct smp_ops smp_ops = { #endif .smp_send_reschedule = native_smp_send_reschedule, - .cpu_up = native_cpu_up, + .kick_ap_alive = native_kick_ap, .cpu_disable = native_cpu_disable, .play_dead = native_play_dead, --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1070,7 +1070,7 @@ static int do_boot_cpu(int apicid, int c return ret; } -static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) +int native_kick_ap(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); int err; @@ -1106,15 +1106,15 @@ static int native_kick_ap(unsigned int c return err; } -int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle) { - return native_kick_ap(cpu, tidle); + return smp_ops.kick_ap_alive(cpu, tidle); } void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) { /* Cleanup possible dangling ends... */ - if (smp_ops.cpu_up == native_cpu_up && x86_platform.legacy.warm_reset) + if (smp_ops.kick_ap_alive == native_kick_ap && x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); } --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -314,7 +314,7 @@ cpu_initialize_context(unsigned int cpu, return 0; } -static int xen_pv_cpu_up(unsigned int cpu, struct task_struct *idle) +static int xen_pv_kick_ap(unsigned int cpu, struct task_struct *idle) { int rc; @@ -438,7 +438,7 @@ static const struct smp_ops xen_smp_ops .smp_prepare_cpus = xen_pv_smp_prepare_cpus, .smp_cpus_done = xen_smp_cpus_done, - .cpu_up = xen_pv_cpu_up, + .kick_ap_alive = xen_pv_kick_ap, .cpu_die = xen_pv_cpu_die, .cleanup_dead_cpu = xen_pv_cleanup_dead_cpu, .poll_sync_state = xen_pv_poll_sync_state, From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521367.810080 (Exim 4.92) (envelope-from ) id 1pnTAl-00020F-Fv; Fri, 14 Apr 2023 23:49:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521367.810080; Fri, 14 Apr 2023 23:49:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAl-0001yy-3K; Fri, 14 Apr 2023 23:49:43 +0000 Received: by outflank-mailman (input) for mailman id 521367; Fri, 14 Apr 2023 23:49:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT5z-0001Th-Nr for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:44:47 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55b151aa-db1e-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 01:44:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55b151aa-db1e-11ed-b21e-6b7b168915f2 Message-ID: <20230414232310.382005483@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3+qlITNV53BaRfy3keVD52aWouI/gE/YQxgQoDSFHFQ=; b=d/JnboK/jkYT0GCssjVJ90Y/WenuKe1jZIeYgv20OJ8XmoGVYLF1ZTVBI388KIvGG81BdO s78WecNm45vveuEvwyWBqpgE+vTtwDzERMCqW1Wa+4ETTvB/cX6F944F3VGLD5QdOboktX oYzSxcLkz1ApMjeWZS/WTENuQtTLSkNhnQRy9RzQFKh/XLNn3yGYZts1NNhtJC5HjIGI5o GW7Dy1zD4MwOm3khrT+nIHASKJLyysL3C4C/JHrrPJSnMuLIm7wmYPRipyZTKCP/Pk5TvQ t4mSIMmTLfqg4c1OUMFcIfZVIVmu4xkWF38NJIgv/C8Mj3XL31D/6X50h3AvSA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3+qlITNV53BaRfy3keVD52aWouI/gE/YQxgQoDSFHFQ=; b=yCWdMiSVNqst3Q7S9gg95ghiR9su0xx9UWqm5RPQMRYbxRMm2BYagQWZ6uYhvAgJKN0wb7 iDVKrki61JxGxVBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, David Woodhouse , Usama Arif , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: [patch 19/37] x86/smpboot: Switch to hotplug core state synchronization References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:44:44 +0200 (CEST) The new AP state tracking and synchronization mechanism in the CPU hotplug core code allows to remove quite some x86 specific code: 1) The AP alive synchronization based on cpumasks 2) The decision whether an AP can be brought up again Signed-off-by: Thomas Gleixner Cc: Juergen Gross Cc: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org --- arch/x86/Kconfig | 1 arch/x86/include/asm/smp.h | 7 + arch/x86/kernel/smp.c | 1 arch/x86/kernel/smpboot.c | 159 ++++++++++----------------------------------- arch/x86/xen/smp_hvm.c | 16 +--- arch/x86/xen/smp_pv.c | 39 ++++++----- 6 files changed, 72 insertions(+), 151 deletions(-) --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -272,6 +272,7 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO + select HOTPLUG_CORE_SYNC_FULL if SMP select HOTPLUG_SMT if SMP select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -38,6 +38,8 @@ struct smp_ops { void (*crash_stop_other_cpus)(void); void (*smp_send_reschedule)(int cpu); + void (*cleanup_dead_cpu)(unsigned cpu); + void (*poll_sync_state)(void); int (*cpu_up)(unsigned cpu, struct task_struct *tidle); int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); @@ -90,7 +92,8 @@ static inline int __cpu_disable(void) static inline void __cpu_die(unsigned int cpu) { - smp_ops.cpu_die(cpu); + if (smp_ops.cpu_die) + smp_ops.cpu_die(cpu); } static inline void play_dead(void) @@ -122,8 +125,6 @@ void native_smp_cpus_done(unsigned int m int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); int native_cpu_disable(void); -int common_cpu_die(unsigned int cpu); -void native_cpu_die(unsigned int cpu); void hlt_play_dead(void); void native_play_dead(void); void play_dead_common(void); --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -269,7 +269,6 @@ struct smp_ops smp_ops = { .smp_send_reschedule = native_smp_send_reschedule, .cpu_up = native_cpu_up, - .cpu_die = native_cpu_die, .cpu_disable = native_cpu_disable, .play_dead = native_play_dead, --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -57,6 +57,7 @@ #include #include #include +#include #include #include @@ -101,9 +102,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); -/* All of these masks are initialized in setup_cpu_local_masks() */ -static cpumask_var_t cpu_initialized_mask; -static cpumask_var_t cpu_callout_mask; /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -169,8 +167,8 @@ static void smp_callin(void) int cpuid = smp_processor_id(); /* - * If waken up by an INIT in an 82489DX configuration - * cpu_callout_mask guarantees we don't get here before an + * If waken up by an INIT in an 82489DX configuration the alive + * synchronization guarantees we don't get here before an * INIT_deassert IPI reaches our local APIC, so it is now safe to * touch our local APIC. * @@ -216,17 +214,6 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } -static void wait_for_master_cpu(int cpu) -{ - /* - * Wait for release by control CPU before continuing with AP - * initialization. - */ - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) - cpu_relax(); -} - /* * Activate a secondary processor. */ @@ -247,11 +234,10 @@ static void notrace start_secondary(void cpu_init_exception_handling(); /* - * Sync point with wait_cpu_initialized(). Sets AP in - * cpu_initialized_mask and then waits for the control CPU - * to release it. + * Sync point with the hotplug core. Sets the sync state to ALIVE + * and waits for the control CPU to release it. */ - wait_for_master_cpu(raw_smp_processor_id()); + cpuhp_ap_sync_alive(); cpu_init(); rcu_cpu_starting(raw_smp_processor_id()); @@ -285,7 +271,6 @@ static void notrace start_secondary(void set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); - cpu_set_state_online(smp_processor_id()); x86_platform.nmi_init(); /* enable local interrupts */ @@ -736,9 +721,10 @@ static void impress_friends(void) * Allow the user to impress friends. */ pr_debug("Before bogomips\n"); - for_each_possible_cpu(cpu) - if (cpumask_test_cpu(cpu, cpu_callout_mask)) + for_each_possible_cpu(cpu) { + if (cpumask_test_cpu(cpu, cpu_online_mask)) bogosum += cpu_data(cpu).loops_per_jiffy; + } pr_info("Total of %d processors activated (%lu.%02lu BogoMIPS)\n", num_online_cpus(), bogosum/(500000/HZ), @@ -1010,6 +996,7 @@ int common_cpu_up(unsigned int cpu, stru static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { unsigned long start_ip = real_mode_header->trampoline_start; + int ret; #ifdef CONFIG_X86_64 /* If 64-bit wakeup method exists, use the 64-bit mode trampoline IP */ @@ -1050,13 +1037,6 @@ static int do_boot_cpu(int apicid, int c } } - /* - * AP might wait on cpu_callout_mask in cpu_init() with - * cpu_initialized_mask set if previous attempt to online - * it timed-out. Clear cpu_initialized_mask so that after - * INIT/SIPI it could start with a clean state. - */ - cpumask_clear_cpu(cpu, cpu_initialized_mask); smp_mb(); /* @@ -1067,47 +1047,16 @@ static int do_boot_cpu(int apicid, int c * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) - return apic->wakeup_secondary_cpu_64(apicid, start_ip); + ret = apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) - return apic->wakeup_secondary_cpu(apicid, start_ip); - - return wakeup_secondary_cpu_via_init(apicid, start_ip); -} - -static int wait_cpu_cpumask(unsigned int cpu, const struct cpumask *mask) -{ - unsigned long timeout; - - /* - * Wait up to 10s for the CPU to report in. - */ - timeout = jiffies + 10*HZ; - while (time_before(jiffies, timeout)) { - if (cpumask_test_cpu(cpu, mask)) - return 0; - - schedule(); - } - return -1; -} - -/* - * Bringup step two: Wait for the target AP to reach cpu_init_secondary() - * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it - * to proceed. The AP will then proceed past setting its 'callin' bit - * and end up waiting in check_tsc_sync_target() until we reach - * wait_cpu_online() to tend to it. - */ -static int wait_cpu_initialized(unsigned int cpu) -{ - /* - * Wait for first sign of life from AP. - */ - if (wait_cpu_cpumask(cpu, cpu_initialized_mask)) - return -1; + ret = apic->wakeup_secondary_cpu(apicid, start_ip); + else + ret = wakeup_secondary_cpu_via_init(apicid, start_ip); - cpumask_set_cpu(cpu, cpu_callout_mask); - return 0; + /* If the wakeup mechanism failed, cleanup the warm reset vector */ + if (ret) + arch_cpuhp_cleanup_kick_cpu(cpu); + return ret; } static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) @@ -1132,11 +1081,6 @@ static int native_kick_ap(unsigned int c */ mtrr_save_state(); - /* x86 CPUs take themselves offline, so delayed offline is OK. */ - err = cpu_check_up_prepare(cpu); - if (err && err != -EBUSY) - return err; - /* the FPU context is blank, nobody can own it */ per_cpu(fpu_fpregs_owner_ctx, cpu) = NULL; @@ -1153,17 +1097,29 @@ static int native_kick_ap(unsigned int c int native_cpu_up(unsigned int cpu, struct task_struct *tidle) { - int ret; - - ret = native_kick_ap(cpu, tidle); - if (!ret) - ret = wait_cpu_initialized(cpu); + return native_kick_ap(cpu, tidle); +} +void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) +{ /* Cleanup possible dangling ends... */ - if (x86_platform.legacy.warm_reset) + if (smp_ops.cpu_up == native_cpu_up && x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); +} - return ret; +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ + if (smp_ops.cleanup_dead_cpu) + smp_ops.cleanup_dead_cpu(cpu); + + if (system_state == SYSTEM_RUNNING) + pr_info("CPU %u is now offline\n", cpu); +} + +void arch_cpuhp_sync_state_poll(void) +{ + if (smp_ops.poll_sync_state) + smp_ops.poll_sync_state(); } /** @@ -1355,9 +1311,6 @@ void __init native_smp_prepare_boot_cpu( if (!IS_ENABLED(CONFIG_SMP)) switch_gdt_and_percpu_base(me); - /* already set me in cpu_online_mask in boot_cpu_init() */ - cpumask_set_cpu(me, cpu_callout_mask); - cpu_set_state_online(me); native_pv_lock_init(); } @@ -1484,8 +1437,6 @@ early_param("possible_cpus", _setup_poss /* correctly size the local cpu masks */ void __init setup_cpu_local_masks(void) { - alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callout_mask); alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); } @@ -1547,9 +1498,6 @@ static void remove_siblinginfo(int cpu) static void remove_cpu_from_maps(int cpu) { set_cpu_online(cpu, false); - cpumask_clear_cpu(cpu, cpu_callout_mask); - /* was set by cpu_init() */ - cpumask_clear_cpu(cpu, cpu_initialized_mask); numa_remove_cpu(cpu); } @@ -1600,36 +1548,11 @@ int native_cpu_disable(void) return 0; } -int common_cpu_die(unsigned int cpu) -{ - int ret = 0; - - /* We don't do anything here: idle task is faking death itself. */ - - /* They ack this in play_dead() by setting CPU_DEAD */ - if (cpu_wait_death(cpu, 5)) { - if (system_state == SYSTEM_RUNNING) - pr_info("CPU %u is now offline\n", cpu); - } else { - pr_err("CPU %u didn't die...\n", cpu); - ret = -1; - } - - return ret; -} - -void native_cpu_die(unsigned int cpu) -{ - common_cpu_die(cpu); -} - void play_dead_common(void) { idle_task_exit(); - /* Ack it */ - (void)cpu_report_death(); - + cpuhp_ap_report_dead(); /* * With physical CPU hotplug, we should halt the cpu */ @@ -1731,12 +1654,6 @@ int native_cpu_disable(void) return -ENOSYS; } -void native_cpu_die(unsigned int cpu) -{ - /* We said "no" in __cpu_disable */ - BUG(); -} - void native_play_dead(void) { BUG(); --- a/arch/x86/xen/smp_hvm.c +++ b/arch/x86/xen/smp_hvm.c @@ -55,18 +55,16 @@ static void __init xen_hvm_smp_prepare_c } #ifdef CONFIG_HOTPLUG_CPU -static void xen_hvm_cpu_die(unsigned int cpu) +static void xen_hvm_cleanup_dead_cpu(unsigned int cpu) { - if (common_cpu_die(cpu) == 0) { - if (xen_have_vector_callback) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); - } + if (xen_have_vector_callback) { + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); } } #else -static void xen_hvm_cpu_die(unsigned int cpu) +static void xen_hvm_cleanup_dead_cpu(unsigned int cpu) { BUG(); } @@ -77,7 +75,7 @@ void __init xen_hvm_smp_init(void) smp_ops.smp_prepare_boot_cpu = xen_hvm_smp_prepare_boot_cpu; smp_ops.smp_prepare_cpus = xen_hvm_smp_prepare_cpus; smp_ops.smp_cpus_done = xen_smp_cpus_done; - smp_ops.cpu_die = xen_hvm_cpu_die; + smp_ops.cleanup_dead_cpu = xen_hvm_cleanup_dead_cpu; if (!xen_have_vector_callback) { #ifdef CONFIG_PARAVIRT_SPINLOCKS --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -62,6 +62,7 @@ static void cpu_bringup(void) int cpu; cr4_init(); + cpuhp_ap_sync_alive(); cpu_init(); touch_softlockup_watchdog(); @@ -83,7 +84,7 @@ static void cpu_bringup(void) set_cpu_online(cpu, true); - cpu_set_state_online(cpu); /* Implies full memory barrier. */ + smp_mb(); /* We can take interrupts now: we're officially "up". */ local_irq_enable(); @@ -323,14 +324,6 @@ static int xen_pv_cpu_up(unsigned int cp xen_setup_runstate_info(cpu); - /* - * PV VCPUs are always successfully taken down (see 'while' loop - * in xen_cpu_die()), so -EBUSY is an error. - */ - rc = cpu_check_up_prepare(cpu); - if (rc) - return rc; - /* make sure interrupts start blocked */ per_cpu(xen_vcpu, cpu)->evtchn_upcall_mask = 1; @@ -349,6 +342,11 @@ static int xen_pv_cpu_up(unsigned int cp return 0; } +static void xen_pv_poll_sync_state(void) +{ + HYPERVISOR_sched_op(SCHEDOP_yield, NULL); +} + #ifdef CONFIG_HOTPLUG_CPU static int xen_pv_cpu_disable(void) { @@ -364,18 +362,18 @@ static int xen_pv_cpu_disable(void) static void xen_pv_cpu_die(unsigned int cpu) { - while (HYPERVISOR_vcpu_op(VCPUOP_is_up, - xen_vcpu_nr(cpu), NULL)) { + while (HYPERVISOR_vcpu_op(VCPUOP_is_up, xen_vcpu_nr(cpu), NULL)) { __set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(HZ/10); } +} - if (common_cpu_die(cpu) == 0) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); - xen_pmu_finish(cpu); - } +static void xen_pv_cleanup_dead_cpu(unsigned int cpu) +{ + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); + xen_pmu_finish(cpu); } static void __noreturn xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ @@ -397,6 +395,11 @@ static void xen_pv_cpu_die(unsigned int BUG(); } +static void xen_pv_cleanup_dead_cpu(unsigned int cpu) +{ + BUG(); +} + static void __noreturn xen_pv_play_dead(void) { BUG(); @@ -437,6 +440,8 @@ static const struct smp_ops xen_smp_ops .cpu_up = xen_pv_cpu_up, .cpu_die = xen_pv_cpu_die, + .cleanup_dead_cpu = xen_pv_cleanup_dead_cpu, + .poll_sync_state = xen_pv_poll_sync_state, .cpu_disable = xen_pv_cpu_disable, .play_dead = xen_pv_play_dead, From xen-devel-bounces@lists.xenproject.org Fri Apr 14 23:49:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 14 Apr 2023 23:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521371.810089 (Exim 4.92) (envelope-from ) id 1pnTAn-0002SG-73; Fri, 14 Apr 2023 23:49:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521371.810089; Fri, 14 Apr 2023 23:49:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnTAn-0002QR-0G; Fri, 14 Apr 2023 23:49:45 +0000 Received: by outflank-mailman (input) for mailman id 521371; Fri, 14 Apr 2023 23:49:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnT6S-0000zb-CK for xen-devel@lists.xenproject.org; Fri, 14 Apr 2023 23:45:16 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 673e1bc9-db1e-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 01:45:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 673e1bc9-db1e-11ed-8611-37d641c3527e Message-ID: <20230414232311.505152290@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681515914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=nUZSh5064m2aKoxr+KQn5JPMu6mMKtsaGAC9NSZVNms=; b=tXdZ+JNXwmoFAj/D4wiLzLK3B9Tdjf372IqdJt5Tv46gv42xMEL/Nl0g5kdyiZHT7x9AOz mlFylzsIhnrXORGzmbDeoOd0v4PWWxn8r5JfaFvKB5y4Myd0UBCMyCyRl33Zi088uSB2Ir SvONUInWoGIX09mANT0wqHnMa8plhV/+A02oVVT5ueBVnLW3psXBgZVX1wGuoSRuwDa/iV WCxZeGiReQ8KfEt87/havCjKqbuogL4jZdqFqdulIebLR5I3xNrYIQ3tyIgS/ypjvwLm3u ZY0rsKukGMk7diouGwNhACQ22cLpXT7hOtDVbk+HLvlFHbrtTgmHuHYua/2ZDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681515914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=nUZSh5064m2aKoxr+KQn5JPMu6mMKtsaGAC9NSZVNms=; b=pkIQhDhWjPpGLy6aH5XoCk5G1NoyA94urqDixfl4xi4JgoGh52mUmdlWbRdLMez3lvqnCR cNwc4JXhAqWj08Aw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , "Arjan van de Veen" , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Sabin Rapan , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland Subject: [patch 37/37] x86/smpboot: Allow parallel bringup for SEV-ES References: <20230414225551.858160935@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sat, 15 Apr 2023 01:45:13 +0200 (CEST) From: David Woodhouse Enable parallel bringup for SEV-ES guests. The APs can't actually execute the CPUID instruction directly during early startup, but they can make the GHCB call directly instead, just as the #VC trap handler would do. Thanks to Sabin for talking me through the way this works. Suggested-by: Sabin Rapan Signed-off-by: David Woodhouse Signed-off-by: Usama Arif Signed-off-by: Thomas Gleixner Reviewed-by: Tom Lendacky --- arch/x86/include/asm/sev-common.h | 3 +++ arch/x86/include/asm/smp.h | 1 + arch/x86/kernel/head_64.S | 30 ++++++++++++++++++++++++++++++ arch/x86/kernel/smpboot.c | 14 ++++++++++++-- 4 files changed, 46 insertions(+), 2 deletions(-) --- a/arch/x86/include/asm/sev-common.h +++ b/arch/x86/include/asm/sev-common.h @@ -70,6 +70,7 @@ /* GHCBData[63:12] */ \ (((u64)(v) & GENMASK_ULL(63, 12)) >> 12) +#ifndef __ASSEMBLY__ /* * SNP Page State Change Operation * @@ -161,6 +162,8 @@ struct snp_psc_desc { #define GHCB_RESP_CODE(v) ((v) & GHCB_MSR_INFO_MASK) +#endif /* __ASSEMBLY__ */ + /* * Error codes related to GHCB input that can be communicated back to the guest * by setting the lower 32-bits of the GHCB SW_EXITINFO1 field to 2. --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -202,6 +202,7 @@ extern unsigned int smpboot_control; #define STARTUP_APICID_CPUID_1F 0x80000000 #define STARTUP_APICID_CPUID_0B 0x40000000 #define STARTUP_APICID_CPUID_01 0x20000000 +#define STARTUP_APICID_SEV_ES 0x10000000 /* Top 8 bits are reserved for control */ #define STARTUP_PARALLEL_MASK 0xFF000000 --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -26,6 +26,7 @@ #include #include #include +#include /* * We are not able to switch in one step to the final KERNEL ADDRESS SPACE @@ -243,9 +244,14 @@ SYM_INNER_LABEL(secondary_startup_64_no_ * Bit 31 STARTUP_APICID_CPUID_1F flag (use CPUID 0x1f) * Bit 30 STARTUP_APICID_CPUID_0B flag (use CPUID 0x0b) * Bit 29 STARTUP_APICID_CPUID_01 flag (use CPUID 0x01) + * Bit 28 STARTUP_APICID_SEV_ES flag (CPUID 0x0b via GHCB MSR) * Bit 0-23 CPU# if STARTUP_APICID_CPUID_xx flags are not set */ movl smpboot_control(%rip), %ecx +#ifdef CONFIG_AMD_MEM_ENCRYPT + testl $STARTUP_APICID_SEV_ES, %ecx + jnz .Luse_sev_cpuid_0b +#endif testl $STARTUP_APICID_CPUID_1F, %ecx jnz .Luse_cpuid_1f testl $STARTUP_APICID_CPUID_0B, %ecx @@ -262,6 +268,30 @@ SYM_INNER_LABEL(secondary_startup_64_no_ shr $24, %edx jmp .Lsetup_AP +#ifdef CONFIG_AMD_MEM_ENCRYPT +.Luse_sev_cpuid_0b: + /* Set the GHCB MSR to request CPUID 0x0B_EDX */ + movl $MSR_AMD64_SEV_ES_GHCB, %ecx + movl $(GHCB_CPUID_REQ_EDX << 30) | GHCB_MSR_CPUID_REQ, %eax + movl $0x0b, %edx + wrmsr + + /* Perform GHCB MSR protocol */ + rep; vmmcall /* vmgexit */ + + /* + * Get the result. After the RDMSR: + * EAX should be 0xc0000005 + * EDX should have the CPUID register value and since EDX + * is the target register, no need to move the result. + */ + rdmsr + andl $GHCB_MSR_INFO_MASK, %eax + cmpl $GHCB_MSR_CPUID_RESP, %eax + jne 1f + jmp .Lsetup_AP +#endif + .Luse_cpuid_0b: mov $0x0B, %eax xorl %ecx, %ecx --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -86,6 +86,7 @@ #include #include #include +#include /* representing HT siblings of each logical CPU */ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map); @@ -1266,8 +1267,16 @@ bool __init arch_cpuhp_init_parallel_bri /* Encrypted guests require special CPUID handling. */ if (cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT)) { - pr_info("Parallel CPU startup disabled due to guest state encryption\n"); - return false; + switch (cc_get_vendor()) { + case CC_VENDOR_AMD: + ctrl = STARTUP_APICID_SEV_ES; + if (topology_extended_leaf == 0x0b) + goto setup; + fallthrough; + default: + pr_info("Parallel CPU startup disabled due to guest state encryption\n"); + return false; + } } switch (topology_extended_leaf) { @@ -1290,6 +1299,7 @@ bool __init arch_cpuhp_init_parallel_bri return false; } +setup: pr_debug("Parallel CPU startup enabled: 0x%08x\n", ctrl); smpboot_control = ctrl; return true; From xen-devel-bounces@lists.xenproject.org Sat Apr 15 02:23:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 02:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521423.810105 (Exim 4.92) (envelope-from ) id 1pnVZ5-000401-Dd; Sat, 15 Apr 2023 02:22:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521423.810105; Sat, 15 Apr 2023 02:22:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnVZ5-0003zt-7D; Sat, 15 Apr 2023 02:22:59 +0000 Received: by outflank-mailman (input) for mailman id 521423; Sat, 15 Apr 2023 02:22:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnVZ2-0003zn-Ny for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 02:22:57 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b832a43-db34-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 04:22:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b832a43-db34-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681525372; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QJ+3HwfGXzkynQSqiJEwjODBvnbypPPunqE44a4eZqg=; b=CxPzn36aSeSYE3Jhy7rnlQYNu535953G4exGqRZal1aOPbd41w1Cj9zM Q6GZSb/dAlON+mZP0j7zYN+uu7gCS0ooX4fh5MGYJQZcd4sD2d/xz8ioT ZfX8/bqvN6FnV/s5F1yRKnBSXb0ab+AmPx6ceBQLDPMYipIL8hQ6x2yfa Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 105999310 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:XjWoIqBjFW9+hRVW/1/jw5YqxClBgxIJ4kV8jS/XYbTApD0q1mYHx zEfXmiBP/eNNDH0fox/Pd+w9UoH7Z7RztFgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G9B4gRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw0956B3kVr cckCQtdUD/AruOa5amec7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9I4TXFJQExR/Az o7A11/yWTErG+aC83mAqiyBodfPxAirdp1HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFaHuRgGUtYWDOw+6ymK0KPf5wvfDW8BJgOtc/R/6pVwH2Zzk AbUwZWwX2cHXKCppWy134+ZqyvpYRMpDFRSWwBHZAopxsLGmdRm5v7QdeqPAJJZn/WsR2Gpn 2vb8Xli71kApZVVjvvmpDgrlxrp/8GUFVBtu207S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBN7falUweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPtMYPbSTxNPUtPt/Z5yEWIU/ITI2NaxwpRoAWPsgZmPGvp0mCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNJmLOAGeHr9HuZdyn3BW+I8mbcyjp/hR+ebENSH9pHZsGAfmU93VG4ve8ViEq 44Ca5rao/idOcWnChTqHUcoBQhiBRAG6Vre8KS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:XXd1qqoY9/73zW/6R1Wxb+gaV5oneYIsimQD101hICG8cqSj+f xG+85rsSMc6QxhPk3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakrDH4VmtJ uIHZIQNDSJNykZsfrH X-Talos-CUID: =?us-ascii?q?9a23=3A5i10mWmgHQehAcGSk2hIWMj2++fXOVTlwXHIeBe?= =?us-ascii?q?DNUdSGIO6CnaR1IZ/tvM7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AZnZwgQ1Blvc+NF+cnxSUFpyQHzUj2K/1KHEiq4g?= =?us-ascii?q?8+MzcawFXAzfEp2SZXdpy?= X-IronPort-AV: E=Sophos;i="5.99,198,1677560400"; d="scan'208";a="105999310" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH] xen/livepatch: Fix .altinstructions safety checks Date: Sat, 15 Apr 2023 03:22:29 +0100 Message-ID: <20230415022229.3475033-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The prior check has && vs || mixups, making it tautologically false and thus providing no safety at all. There are boundary errors too. First start with a comment describing how the .altinstructions and .altinstr_replacement sections interact, and perform suitable cross-checking. Second, rewrite the alt_instr loop entirely from scratch. Origin sites have non-zero size, and must be fully contained within .text. Any non-zero sized replacements must be fully contained within .altinstr_replacement. Fixes: f8a10174e8b1 ("xsplice: Add support for alternatives") Signed-off-by: Andrew Cooper --- CC: Konrad Rzeszutek Wilk CC: Ross Lagerwall As a further observation, .altinstr_replacement shouldn't survive beyond its use in apply_alternatives(), but the disp32 relative references (for x86 at least) in alt_instr force .altinstr_replacement to be close to the payload while being applied. --- xen/common/livepatch.c | 66 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 60 insertions(+), 6 deletions(-) diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c index 784fbd92e913..020a9648d5ba 100644 --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -803,28 +803,82 @@ static int prepare_payload(struct payload *payload, if ( sec ) { #ifdef CONFIG_HAS_ALTERNATIVE + /* + * (As of April 2023), Alternatives are formed of: + * - An .altinstructions section with an array of struct alt_instr's. + * - An .altinstr_replacement section containing instructions bytes. + * + * An individual alt_instr contains: + * - An orig reference, pointing into .text with a nonzero length + * - A repl reference, pointing into .altinstr_replacement + * + * It is legal to have zero-length replacements, meaning it is legal + * for the .altinstr_replacement section to be empty too. An + * implementation detail means that a zero-length replacement's repl + * reference will be the start of the .altinstr_replacement section. + */ + const struct livepatch_elf_sec *repl_sec; struct alt_instr *a, *start, *end; if ( !section_ok(elf, sec, sizeof(*a)) ) return -EINVAL; + /* Tolerate an empty .altinstructions section... */ + if ( sec->sec->sh_size == 0 ) + goto alt_done; + + /* ... but otherwise, there needs to be something to alter... */ + if ( payload->text_size == 0 ) + { + printk(XENLOG_ERR LIVEPATCH "%s Alternatives provided, but no .text\n", + elf->name); + return -EINVAL; + } + + /* ... and something to be altered to. */ + repl_sec = livepatch_elf_sec_by_name(elf, ".altinstr_replacement"); + if ( !repl_sec ) + { + printk(XENLOG_ERR LIVEPATCH "%s .altinstructions provided, but no .altinstr_replacement\n", + elf->name); + return -EINVAL; + } + start = sec->load_addr; end = sec->load_addr + sec->sec->sh_size; for ( a = start; a < end; a++ ) { - const void *instr = ALT_ORIG_PTR(a); - const void *replacement = ALT_REPL_PTR(a); + const void *orig = ALT_ORIG_PTR(a); + const void *repl = ALT_REPL_PTR(a); + + /* orig must be fully within .text. */ + if ( orig < payload->text_addr || + a->orig_len > payload->text_size || + orig + a->orig_len > payload->text_addr + payload->text_size ) + { + printk(XENLOG_ERR LIVEPATCH + "%s Alternative orig %p+%#x outside payload text %p+%#lx\n", + elf->name, orig, a->orig_len, payload->text_addr, payload->text_size); + return -EINVAL; + } - if ( (instr < region->start && instr >= region->end) || - (replacement < region->start && replacement >= region->end) ) + /* + * repl must be fully within .altinstr_replacement, even if they + * happen to both have zero length. + */ + if ( repl < repl_sec->load_addr || + a->repl_len > repl_sec->sec->sh_size || + repl + a->repl_len > repl_sec->load_addr + repl_sec->sec->sh_size ) { - printk(XENLOG_ERR LIVEPATCH "%s Alt patching outside payload: %p\n", - elf->name, instr); + printk(XENLOG_ERR LIVEPATCH + "%s Alternative repl %p+%#x outside .altinstr_replacement %p+%#lx\n", + elf->name, repl, a->repl_len, repl_sec->load_addr, repl_sec->sec->sh_size); return -EINVAL; } } apply_alternatives(start, end); + alt_done:; #else printk(XENLOG_ERR LIVEPATCH "%s: We don't support alternative patching\n", elf->name); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Sat Apr 15 02:55:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 02:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521427.810115 (Exim 4.92) (envelope-from ) id 1pnW4G-0007RU-S1; Sat, 15 Apr 2023 02:55:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521427.810115; Sat, 15 Apr 2023 02:55:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnW4G-0007RN-MQ; Sat, 15 Apr 2023 02:55:12 +0000 Received: by outflank-mailman (input) for mailman id 521427; Sat, 15 Apr 2023 02:55:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnW4F-0007RA-Q4; Sat, 15 Apr 2023 02:55:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnW4F-00054c-Kf; Sat, 15 Apr 2023 02:55:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnW4F-0007IN-Cd; Sat, 15 Apr 2023 02:55:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnW4F-00059q-C9; Sat, 15 Apr 2023 02:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FK8cCmDfmh1l3LhnUQjNXIJDF19GHLBnx4FDez1MPe8=; b=tVnYcpBiLwcIUNpwE+C6kSWeZo lPpKIWQfilBg2z2IN0zEL2ZeSMqvZQ6rLHbNDGjYsC/R1aKyMoCgOIAoYuHIK97sS8yFPMyemFSaa 2b4qClgPSwYo3Ck6VOA34zsCBX9HjOrfKBhjuEKcQFLi7PiSedqObAgYt5FrwTjKzvf8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180264: trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1::broken:regression linux-linus:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7a934f4bd7d6f9da84c8812da3ba42ee10f5778e X-Osstest-Versions-That: linux=44149752e9987a9eac5ad78e6d3a20934b5e018d From: osstest service owner Date: Sat, 15 Apr 2023 02:55:11 +0000 flight 180264 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180264/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-arndale 8 xen-boot fail baseline untested test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180253 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-examine 8 reboot fail starved in 180253 test-armhf-armhf-xl-multivcpu 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-vhd 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-credit2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180253 version targeted for testing: linux 7a934f4bd7d6f9da84c8812da3ba42ee10f5778e baseline version: linux 44149752e9987a9eac5ad78e6d3a20934b5e018d Last test of basis 180253 2023-04-14 01:13:19 Z 1 days Testing same since 180264 2023-04-14 18:10:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Ghiti Cheng Xu Conor Dooley Erik Brakkee Huang Rui Jason Gunthorpe Kai Vehmanen Leon Romanovsky Linus Torvalds Maher Sanalla Mario Limonciello Mark Zhang Mathis Salmen Mustafa Ismail Oswald Buddenhagen Palmer Dabbelt Paul Menzel Pierre-Louis Bossart Rafael J. Wysocki Rui Salvaterra Saravanan Vajravel Shiraz Saleem Srinivas Pandruvada Stefan Binding Takashi Iwai Takashi Sakamoto Tatyana Nikolova Wyes Karny Xu Biang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-step test-armhf-armhf-xl-credit1 host-install(5) Not pushing. (No revision log; it would be 768 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 15 04:59:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 04:59:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521434.810124 (Exim 4.92) (envelope-from ) id 1pnY0C-0002mk-Uv; Sat, 15 Apr 2023 04:59:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521434.810124; Sat, 15 Apr 2023 04:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnY0C-0002md-SA; Sat, 15 Apr 2023 04:59:08 +0000 Received: by outflank-mailman (input) for mailman id 521434; Sat, 15 Apr 2023 04:59:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnY0B-0002mX-Ib for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 04:59:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2073.outbound.protection.outlook.com [40.107.7.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e3724dc-db4a-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 06:59:03 +0200 (CEST) Received: from AS8P250CA0029.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::34) by PAVPR08MB9013.eurprd08.prod.outlook.com (2603:10a6:102:320::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sat, 15 Apr 2023 04:58:25 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:330:cafe::af) by AS8P250CA0029.outlook.office365.com (2603:10a6:20b:330::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Sat, 15 Apr 2023 04:58:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.29 via Frontend Transport; Sat, 15 Apr 2023 04:58:24 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Sat, 15 Apr 2023 04:58:23 +0000 Received: from dc3e42969725.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C967FC9F-5404-4FA0-9D2B-05D2ECF1C896.1; Sat, 15 Apr 2023 04:58:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dc3e42969725.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 15 Apr 2023 04:58:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8561.eurprd08.prod.outlook.com (2603:10a6:10:406::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Sat, 15 Apr 2023 04:58:10 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Sat, 15 Apr 2023 04:58:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e3724dc-db4a-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KrA8IWKKeeFG1W6ZwODIRDwRgiC2u6YdYMqxGQUzm+o=; b=WvOAY2AT389Io0Y6Q6dPdDw9PO3iTpM1ToxUBgWFRZUu1kyHN6lnyeKmr7cNGF4LDHXiy2RUXLZ4AU0gEjefE8sJBMpM3cmyA8jsSBaFeWjXummJ2GreWLB2Yx9PFExsnEj3PvQLAGeHxHKVP7cmSqj/GPvOvpdBQlZq2VTiYZw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g4a3+jcFMIgHiG6inAn23eq7VZsLQrTlxxRrVXbGo4ggRBdMCpEQodGQozjdfiSn9DsDQ7WOhg/eTaM6jyk1V1CjE74JinKwpIgvipIY2cEm6IxJUwrZl6HpHjs1+7gLZQlwy8Oc9hJZ5fLILLMzrsUks7ofhUXUttA1GU0j9eVMUn1fcsTABV3wRx9NowgVnFcDbfyF55WGh7akwNJsGwjgSYS8iVndodf1tH3e0blp8OqpmUEWkQnWMs7y6iCke4GQVWmG2WTtRnHO/Uw8eeNn52SDp+4XR+1+EIXfk/iRSJ+CJFHHn9QWjl8jNRa8DMPGgFYAO0YdiLtVHE0KCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KrA8IWKKeeFG1W6ZwODIRDwRgiC2u6YdYMqxGQUzm+o=; b=PoMstpCu/sgGcSt0zb2x8VJED3l9I3I9zt6BcfPZUI7peaHsAN7EYG6JzptDQwZctBHT2Ul3DWn9qQple7549qfWvv/op1as+fUJWBnbeFraEjTV9g6hcHQbVVxHR8SG6pCrkjzx1KIakrViIC4DN8HBMdgpE2YTZWdsAR8YiWPl1iPSqDIPNN1Oz4JTK4zcaPTEzo06mYQm3SjDFVIJ5MfGfTxGvqYTZV85v32OC9ZajMojSlclkw4YiGIag/lbIv+M8TsRUOJOz4oSMDTS3CX42Bh5ojHCvV8MejhnrPmu5ccb3pifru9Aa/xe+8k3/jes3SCSY2F4kWRg8EH5zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KrA8IWKKeeFG1W6ZwODIRDwRgiC2u6YdYMqxGQUzm+o=; b=WvOAY2AT389Io0Y6Q6dPdDw9PO3iTpM1ToxUBgWFRZUu1kyHN6lnyeKmr7cNGF4LDHXiy2RUXLZ4AU0gEjefE8sJBMpM3cmyA8jsSBaFeWjXummJ2GreWLB2Yx9PFExsnEj3PvQLAGeHxHKVP7cmSqj/GPvOvpdBQlZq2VTiYZw= From: Henry Wang To: Stewart Hildebrand , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper Subject: RE: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline Thread-Topic: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline Thread-Index: AQHZbwMWeR0W8wxF2kqEL5lhRIkFbK8rm8pA Date: Sat, 15 Apr 2023 04:58:10 +0000 Message-ID: References: <20230414185714.292881-1-stewart.hildebrand@amd.com> <20230414185714.292881-2-stewart.hildebrand@amd.com> In-Reply-To: <20230414185714.292881-2-stewart.hildebrand@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 68CADEA0DBE95F40B02926A97DCB8709.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8561:EE_|AM7EUR03FT041:EE_|PAVPR08MB9013:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a172917-0d1d-4062-7c39-08db3d6e0adc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Bf77KFEU5xIfyKkQXnB75sRY9w0y466ImvIDqLcbCu/Bv++ZbLIKoiuGFvfBg3yArxXI4KYZOi+IGPF/I/uxQsU1NZpDtjwZkrg3X58SfnSFiXfrxIEsh5zyuha5jFacGvSephY23H7egJKgVkqzaKEFNzPq7UkRscaGF9qBXgzrQnTAuiQJHlUOWrq8ynTBnmmTwNcGI0pChB0zN0puw9dQyChPXYlohMivcG7P3pb2vBCN+1s3j8sjGAUQbxAZBjbSVDIDdNXL6xJk0L48isSfFJJb0ft0jrrJBKpzJFTWxw1ztMh93CMm5j2UkhSWwwqCYc6ALlZxEKJcSNEs1V8LXTztghgz6e0XPKMIGz9XWFlsaqeNhDTm20gcuKmP50WaTEVYxkNR+hgGEVLwiBQsSJz4kQCYZxXmW+V+n8mCL93DoV9vMMYZ8oMkMnEhyD+ziiU6EHZwTB7rNT3WU5f2kXYbhCTAAizBhcmF9Ukns8RJ283igFaCEl9LLZbm6DHhgxKHPpZdrziWIOHHqmyGKHcPd5EW6kArnx5s65HdfMZSxhI5jYiy6BDjhrzd3lIyyDIfXxyoycvS4eeGT7NlfEUuQlPM0b3gec4U2M4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(451199021)(54906003)(478600001)(55016003)(83380400001)(7696005)(71200400001)(6506007)(9686003)(26005)(66946007)(66446008)(66556008)(76116006)(66476007)(316002)(64756008)(4326008)(110136005)(186003)(5660300002)(52536014)(8676002)(8936002)(38100700002)(2906002)(122000001)(4744005)(38070700005)(41300700001)(86362001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8561 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1899a41a-b261-4853-8d4c-08db3d6e029a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uHNtbOtWbnOrdkFRUL/AmeF+1tf1lotI/4DvYK5QV8tOroZDETIBIxqVI1sLhupSLo8ihoiqUvTCacRLQPlXhwLpOfNf7haJf9i50awwKV2UA5kuBO/NWhJ4npnoARgo+XvdgMfvEu5qI5woHIcbDaqbt3l+DTluWOGKbPAX1MkYdVJRQM8SA1tByD8nrdG68rRvBCCaLNKpPc1AMhJgIkaURhcq4gmiwymFgm5nCjy8ZLqAxbnwt1vmK3X2x7gHoKkamSO8HtnAFeGe+rts0wZgsg1wlT61qANAJ45/Eh/+SWbFqofIVi/kd67IFwfw4RasoIi8LjibgUxoEwBGiZIb2EXLZ19UxxkkcXHFmDa+eB0arDCBwLP+GUmxCL3EkzP2NHkoGQSXEGLfSHh1aPg2cowh2V1Nq/dmkoABwxmsZ8TnNi0jCuT631R+Q4e0gQhIU8wVsSu7es40yLShXzhFLnrUWCdlb0we1WtQrkLZhp6Htq9Nualywcixl0Tg3H2Yt88oWSasepSOj164Q0yBbS9nacYENrM9+9EslVm+VbqOHqxf4eyvyTut1JFKZimW8yPI3FvlDjwOhAyod9HdLhMn1sabeERTo/SbE5//TmnIWIEIpP8qvOcqa0wIrhlQg1tU78L1UG+B6iXzO3Q62mY+FPtRrplakhdNrCSLG4BAys0os7p1SfpDXsQWv7ubCNGCSBo7VBdmWbY+wA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(7696005)(41300700001)(478600001)(107886003)(81166007)(26005)(82740400003)(110136005)(54906003)(33656002)(356005)(36860700001)(6506007)(40460700003)(9686003)(82310400005)(8936002)(4326008)(336012)(52536014)(83380400001)(8676002)(47076005)(55016003)(40480700001)(70586007)(2906002)(70206006)(5660300002)(86362001)(186003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2023 04:58:24.0507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a172917-0d1d-4062-7c39-08db3d6e0adc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9013 Hi Stewart, > -----Original Message----- > Subject: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline >=20 > When building the hypervisor with -Og, we run into a __bad_cmpxchg link > error: >=20 > aarch64-none-linux-gnu-ld: prelink.o: in function `__int_cmpxchg': > .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference > to `__bad_cmpxchg' > aarch64-none-linux-gnu- > ld: .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined > reference to `__bad_cmpxchg' > aarch64-none-linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bad_cmpxchg' > isn't defined > aarch64-none-linux-gnu-ld: final link failed: bad value >=20 > This is due to the function __guest_cmpxchg not being inlined in the -Og = build > with gcc 12. Fix this by marking __guest_cmpxchg always_inline. >=20 > Signed-off-by: Stewart Hildebrand " in the end of your signoff...But anyway the patch looks good to me so: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Sat Apr 15 05:00:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 05:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521438.810135 (Exim 4.92) (envelope-from ) id 1pnY1o-0004T3-9h; Sat, 15 Apr 2023 05:00:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521438.810135; Sat, 15 Apr 2023 05:00:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnY1o-0004Sw-6t; Sat, 15 Apr 2023 05:00:48 +0000 Received: by outflank-mailman (input) for mailman id 521438; Sat, 15 Apr 2023 05:00:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnY1n-0004Sl-96 for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 05:00:47 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062e.outbound.protection.outlook.com [2a01:111:f400:7eaf::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b0ec4dd-db4a-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 07:00:46 +0200 (CEST) Received: from AM5P194CA0012.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::22) by GV1PR08MB8618.eurprd08.prod.outlook.com (2603:10a6:150:82::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Sat, 15 Apr 2023 05:00:33 +0000 Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::49) by AM5P194CA0012.outlook.office365.com (2603:10a6:203:8f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Sat, 15 Apr 2023 05:00:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Sat, 15 Apr 2023 05:00:33 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Sat, 15 Apr 2023 05:00:32 +0000 Received: from 9506945cc5da.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 399F7453-B466-471A-A2F8-A96EABF796A7.1; Sat, 15 Apr 2023 05:00:31 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9506945cc5da.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 15 Apr 2023 05:00:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB7707.eurprd08.prod.outlook.com (2603:10a6:150:52::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sat, 15 Apr 2023 05:00:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%7]) with mapi id 15.20.6298.030; Sat, 15 Apr 2023 05:00:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b0ec4dd-db4a-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rsxox0ELCpNEOYk4he/tfF4VeGmY1BM8iiwIZeOxqKE=; b=IGwo/iU9dQT0eZG8M0Wz0XWoCbSKWIPx9vNPc5NSb2DMxfF+65/VMX7Cmk9srGMYtqksYRwVvdGJBwPBV1l9PnE3PY2Qa7iE0m4dvjxZ8lHTUM3sqo8p29fr8REZTC6EHxIFi0CySnKbP/mH6XOtzE107shizdKcJObOrkaC9KE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTMJFwAqGbE6eyzWDb+wr+ULXFPqc73gXwGKttLdgpdsx35shMLAAoPjB4pVAodfiibL8HF5uV3LWd88LREPZXaSFbHcdjlXeFKNIq0CpB2IB4Ie3tgQJ1IoCWcr0PcI90ERa6haQ2a7OFWDzupAvkQtDJ145zzew2tuaqQkj/8xg8ZprlSbJ5rPBF9i2+I/TPqEHG6Fqe/GJlAmFvALDR4XH6+5o8/QwR1z+uVbmdjfU5f2+DPFT9VfhZb1AhzfYApXzh2H7tsLUNqjkpuSntHd96d4988ckKU5vkVr8ALeUizhXXLxKqaOIoJ4nqA2O46KkEpDRdLOvj2OEwnn9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rsxox0ELCpNEOYk4he/tfF4VeGmY1BM8iiwIZeOxqKE=; b=byu/r7szMOOZUXqgMnneGBUiK2vQ9aio0E7h4pB851A/kYkqSiQxoKbc7HyMyfGZ8BIgBlPTgxBUMAp+Lx63kT+BcrJ4VBiVvemFCUZsbIx1d4i9kFpNFFclcTIwTVwi7z2pWGzVaChsUL65iLUDeLsQE1H3+vQOLmOJlPXGqKjAw9QZRodckhNg4CViStfRAWo9JkFphP145NP5SL2tv+MGye5Yc+DmwU79YEYCHwaiVQZJ3vLdB/6Ysb9pJV4dBD6QTw/oEptD/Ab9BuK6FXNHo9TEBCnsBtlk7moWeOVzvV9C5HxGK7k9/bbu5XbRAyKarBOXsVQ90XAS5kC6Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rsxox0ELCpNEOYk4he/tfF4VeGmY1BM8iiwIZeOxqKE=; b=IGwo/iU9dQT0eZG8M0Wz0XWoCbSKWIPx9vNPc5NSb2DMxfF+65/VMX7Cmk9srGMYtqksYRwVvdGJBwPBV1l9PnE3PY2Qa7iE0m4dvjxZ8lHTUM3sqo8p29fr8REZTC6EHxIFi0CySnKbP/mH6XOtzE107shizdKcJObOrkaC9KE= From: Henry Wang To: Stewart Hildebrand , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 3/3] xen/arm: fix unitialized use warning Thread-Topic: [PATCH 3/3] xen/arm: fix unitialized use warning Thread-Index: AQHZbwMRTii87254YUmjLql73V41Gq8rnEuA Date: Sat, 15 Apr 2023 05:00:21 +0000 Message-ID: References: <20230414185714.292881-1-stewart.hildebrand@amd.com> <20230414185714.292881-4-stewart.hildebrand@amd.com> In-Reply-To: <20230414185714.292881-4-stewart.hildebrand@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E52D9A63ED09EC4A94CA29B101DE4A2E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GV1PR08MB7707:EE_|AM7EUR03FT025:EE_|GV1PR08MB8618:EE_ X-MS-Office365-Filtering-Correlation-Id: d9eee0af-6d71-4e1e-45b3-08db3d6e57be x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dukRCfPNJGFxQd7AgqzS3+YrgUDeaJ165m396hj4i9IRynuWbgqdpUg/PTT7SmNQzEzKbMFwCUFGawcTUxbXWnbbuKzAmdLx69lFWgH0GrtIxAYp2nD82zVAzXsLEYrWKR15euWc9V8B0D+sIYV3xMH0SjL9l0lYE3Y4i8mlWzPXOMvnJQ8RmgRqJF50NKo88QUoQiPGxXG/1Y2llvrU6T4w8i81PA36SVcATr1UxFCVmcQhoTwzOAh0PEnlydx05WS3kyP/nPtJPa0oSx962LCfOqQ5tzfXgKxp/TNtMIcGHF6q55wS8D5XkP1N+yJpIqg2YViO+cc33fpm6rf6i2sDDddfwnymG6swTkPBXDu9dhZ3uPfIPnYwPP21NwalyYdbizqrnI0j3iA1NU+hKTND+l2IO0I9IKiQI7L/AwSuNJWPSGrvRZjhSaNB+yEYXuo96Y/Mfg1vvlWd1BJDb5qJx0Lx/gC8PK4p5I6V4FOz3VsY635vXu0JIaMnHlttMHaDNIAzB71RphNB1DcQxTf83a9AVIE34Kz3UWiv1YwnR98g4xLjZsADQA35W5jQd5Xtu7WwTKHbnr2TpH/1wvrFfJb8d6gLbTgDjDmQJPNBxKzeqGUD28IV2LrqvgnU X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199021)(478600001)(110136005)(316002)(54906003)(66556008)(66476007)(66946007)(8676002)(64756008)(66446008)(76116006)(55016003)(83380400001)(33656002)(186003)(9686003)(38070700005)(2906002)(122000001)(4744005)(7696005)(4326008)(71200400001)(41300700001)(86362001)(26005)(5660300002)(8936002)(38100700002)(52536014)(6506007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7707 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a1fd1b13-0c8e-425a-59b8-08db3d6e510c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T3lvOOqLEt04U9wuBqfRFmnr2ELd2g/JrNjAkkrhh1/rux/KoOlLA/Nkql2IbmBKZ74/9N1tfpGwjM8+4ThvJhYHTCKe8QgD4BoDAcoh28d3WRu/Lt6wQuLJEH1MpjtNF58WSeLrTwMhV9cKxyPGQXduA04z3KxQvvZuhkIfU73CwpRACKsgbBz/epcU3pLxOQC/AbA5rlcLG55o+ROTKsBDTu4FLOCsO4gWN0o9XsEoCbDbHE2bzKO6HTvVwHW2jBJMSTxVjbqwsvLSCISium2S8Ca20nvLxnsWHFpPJ1GqlxC2ZZpYx1JkUq8jIo/PvOlsaMYm2PKUIhpSMNsS04WvVqlIo2kUrcvjA91dnUxsTO5vKyIbGe8C/w2ru2HS/If0r/ZPowHTpouC+o2+qbV/IUXnbQPzgvZK1J6LDzJ8EQYtNvAzaiOh693lxZVyvWbbEi8fpqTH0JSwEdcYTQ/1usHFDoQ9I5Dbuc9REZuY2WNG3ADFyPcR3aCXuqf+ZeQ1gb0D2fwi5A4j8B9cJwudaww39HZO4OUSLqGYX6uzHLNI1ZkYAyF+dWradhVTWOWQ/GqOtj5h4nUJtlvwz/npqydPs+lMbH3mLmOreW7sh1S0U/H/FOzLc1Y8RjmIAKrgG8i9AfVnkMmjvfK2Um5oImL90Sk1VHVfHqnDdtoZbNPtGvYZwcch01K3vnT8wPPaujRfU3/R8cH7H1q0jQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(376002)(39860400002)(451199021)(36840700001)(40470700004)(46966006)(5660300002)(4744005)(7696005)(40460700003)(2906002)(70586007)(4326008)(70206006)(86362001)(81166007)(82310400005)(41300700001)(33656002)(478600001)(356005)(52536014)(316002)(8936002)(82740400003)(8676002)(55016003)(40480700001)(54906003)(9686003)(110136005)(6506007)(26005)(336012)(36860700001)(107886003)(186003)(47076005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2023 05:00:33.0216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9eee0af-6d71-4e1e-45b3-08db3d6e57be X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8618 SGkgU3Rld2FydCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBTdWJqZWN0OiBb UEFUQ0ggMy8zXSB4ZW4vYXJtOiBmaXggdW5pdGlhbGl6ZWQgdXNlIHdhcm5pbmcNCj4gDQo+IFdo ZW4gYnVpbGRpbmcgdGhlIGh5cGVydmlzb3Igd2l0aCAtT2csIHdlIGVuY291bnRlciB0aGUgZm9s bG93aW5nIGVycm9yOg0KPiANCj4gYXJjaC9hcm0vZG9tYWluX2J1aWxkLmM6IEluIGZ1bmN0aW9u IOKAmG1ha2VfY3B1c19ub2Rl4oCZOg0KPiBhcmNoL2FybS9kb21haW5fYnVpbGQuYzoyMDQwOjEy OiBlcnJvcjog4oCYY2xvY2tfdmFsaWTigJkgbWF5IGJlIHVzZWQNCj4gdW5pbml0aWFsaXplZCBb LVdlcnJvcj1tYXliZS11bmluaXRpYWxpemVkXQ0KPiAgMjA0MCB8ICAgICAgICAgaWYgKCBjbG9j a192YWxpZCApDQo+ICAgICAgIHwgICAgICAgICAgICBeDQo+IGFyY2gvYXJtL2RvbWFpbl9idWls ZC5jOjE5NDc6MTA6IG5vdGU6IOKAmGNsb2NrX3ZhbGlk4oCZIHdhcyBkZWNsYXJlZCBoZXJlDQo+ ICAxOTQ3IHwgICAgIGJvb2wgY2xvY2tfdmFsaWQ7DQo+ICAgICAgIHwgICAgICAgICAgXn5+fn5+ fn5+fn4NCj4gY2MxOiBhbGwgd2FybmluZ3MgYmVpbmcgdHJlYXRlZCBhcyBlcnJvcnMNCj4gDQo+ IEZpeCBpdCBieSBpbml0aWFsaXppbmcgdGhlIHZhcmlhYmxlLg0KPiANCj4gU2lnbmVkLW9mZi1i eTogU3Rld2FydCBIaWxkZWJyYW5kIDxzdGV3YXJ0LmhpbGRlYnJhbmRAYW1kLmNvbT4NCg0KUmV2 aWV3ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRz LA0KSGVucnkNCg== From xen-devel-bounces@lists.xenproject.org Sat Apr 15 06:48:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 06:48:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521442.810145 (Exim 4.92) (envelope-from ) id 1pnZiD-0006Mu-4W; Sat, 15 Apr 2023 06:48:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521442.810145; Sat, 15 Apr 2023 06:48:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnZiD-0006Mn-1F; Sat, 15 Apr 2023 06:48:41 +0000 Received: by outflank-mailman (input) for mailman id 521442; Sat, 15 Apr 2023 06:48:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnZiB-0006Md-Pd; Sat, 15 Apr 2023 06:48:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnZiB-0002ab-Hw; Sat, 15 Apr 2023 06:48:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnZiB-0000sd-3c; Sat, 15 Apr 2023 06:48:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnZiB-0004we-3B; Sat, 15 Apr 2023 06:48:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mptt7fM3u5d2ar9YIhIuY5JB5AR4uh4SuS/Sl3eYI2Q=; b=ioFZvXhSIew9Rgd/NsceljlITJ 74aLddsFPb61+/YfBiJfo2ARKys0xDpJsV+2XbmDlUZhVCy6wiRa+y2/PXBT1K3PGcmkY2drcRbVr XMfR2zwy1UER53HU3oXWHLtiE05YmQMzumDXnkX/Ldbkv2cwXYoM3leOFSzS8BKJh8hg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180265: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/bootloader:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/kernel:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=18c128ba66e6308744850aca96dbffd18f91c29b X-Osstest-Versions-That: xen=f872a624cbf92de9944483eea7674ef80ced1380 From: osstest service owner Date: Sat, 15 Apr 2023 06:48:39 +0000 flight 180265 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180265/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 broken test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 180238 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 5 host-install(5) broken starved in 180238 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180238 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 180238 test-armhf-armhf-examine 11 examine-serial/bootloader fail starved in 180238 test-armhf-armhf-examine 12 examine-serial/kernel fail starved in 180238 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180238 version targeted for testing: xen 18c128ba66e6308744850aca96dbffd18f91c29b baseline version: xen f872a624cbf92de9944483eea7674ef80ced1380 Last test of basis 180238 2023-04-13 14:38:34 Z 1 days Failing since 180256 2023-04-14 05:34:08 Z 1 days 2 attempts Testing same since 180265 2023-04-14 22:10:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit2 broken broken-step test-armhf-armhf-xl-credit2 host-install(5) Not pushing. ------------------------------------------------------------ commit 18c128ba66e6308744850aca96dbffd18f91c29b Author: Andrew Cooper Date: Thu Jan 26 14:57:45 2023 +0000 x86/hvm: Disallow disabling paging in 64bit mode The Long Mode consistency checks exist to "ensure that the processor does not enter an undefined mode or state that results in unpredictable behavior". APM Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row preventing the OS from trying to exit Long mode while in 64bit mode. This could leave the CPU in Protected Mode with an %rip above the 4G boundary. Experimentally, AMD CPUs really do permit this state transition. An OS which tries it hits an instant SHUTDOWN, even in cases where the truncation I expect to be going on behind the scenes ought to result in sane continued execution. Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" section instructs peoples to switch to a compatibility mode segment first before clearing CR0.PG, which does clear out the upper bits in %rip. This is further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 Architecture". Either way, this appears to have been a genuine oversight in the AMD64 spec. Intel, on the other hand, rejects this state transition with #GP. Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to 4.1.2 "Paging-Mode Enable" was altered from If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP); software should clear CR4.PCIDE before attempting to disable paging. to If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP). Software should transition to compatibility mode and clear CR4.PCIDE before attempting to disable paging. which acknowledges this corner case, but there doesn't appear to be any other discussion even in the relevant Long Mode sections. So it appears that Intel spotted and addressed the corner case in IA-32e mode, but were 15 years late to document it. Xen was written to the AMD spec, and misses the check. Follow the Intel behaviour, because it is more sensible and avoids hitting a VMEntry failure. Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné commit 8363b1f62e561cfb73073b4b094516fcbbd7020e Author: Marek Marczykowski-Górecki Date: Thu Apr 13 14:23:40 2023 +0200 automation: switch ADL hw tests to debug build This should give a lot more useful information in case of a failure, and also enable some asserts for extra checks. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Apr 15 12:59:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 12:59:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521453.810155 (Exim 4.92) (envelope-from ) id 1pnfUM-0000mj-Gb; Sat, 15 Apr 2023 12:58:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521453.810155; Sat, 15 Apr 2023 12:58:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnfUM-0000mc-Df; Sat, 15 Apr 2023 12:58:46 +0000 Received: by outflank-mailman (input) for mailman id 521453; Sat, 15 Apr 2023 12:58:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnfUL-0000mW-De for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 12:58:45 +0000 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [2607:f8b0:4864:20::112d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f4959f2-db8d-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 14:58:42 +0200 (CEST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-54c12009c30so485649017b3.9 for ; Sat, 15 Apr 2023 05:58:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f4959f2-db8d-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681563521; x=1684155521; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ccV6fJmLsZscVpXweMcEv4sovH+IDrkvejv50k6gs/U=; b=BSOaYfaXyd5Wb+epLfvjrJB5ddMbSfuRSPgkDv/0OOsO8ij2hFGojnuviqXm0GCrkP ID2hBr77xwAaGcKnrXJiZAUdBojhzD8cglmd8qXgd51iUqdS7A9NAWUQz0MUF5ZcciE8 AWz1SY3aKamn3My6fXKs/8E5eqVabut4SfZKc0c5sbIlrZyG34ztRaxzO3zCWgWJeeks vL5yfHXHE0t7DNIuTqx162KoYvLaNpuXLEhcNNNv20NmCKzlwGF6mcKsLN10ua6WOBit 5o9zCg+9j1R+WkmMZNRoFuK0k+WfhwAjMsbRMXWBbGHiHnx9KcILf1NV5DEtKeNZyNxV c60w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681563521; x=1684155521; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ccV6fJmLsZscVpXweMcEv4sovH+IDrkvejv50k6gs/U=; b=lDGLnOAXcncqxY8ebXApQU5/yMSxnvxXf6MmbHA7amZ2k8YbMl/HcgDkpNESKv5K4g sUmcPqeUj1L/ZkQQwgw3MAVi4bKRRuYKkAHQe7novFJKW33ZLXOmFWE2xxARfwj3xcrL XrxRRI7gp7CLY7Do47ia3PEi1YDvr0DAgOj0idHGUpmcHsF7KQI2flDFSRpHBoo8tFkR 9nzkB8JcmMJeU2PNRSsDqIdanuhPKOrph9SNgeJoQ6FZDL22127f8eqY/zT5TboaEg79 GnkM8ZoL5v32VJZEKx1KfrrgbwwyY8e3u+Da32qPI197FSKEtVRBDLO9JPHOw3L+7m2q WZjQ== X-Gm-Message-State: AAQBX9dlN3fcijVBrFxZ3WneJHabvgsbcnJSliECeO/ZKG3h/CZgyS1n 7Ihx1H8ri6PssO1OEYyGLCwIzmYhcHfUDOlvzw== X-Google-Smtp-Source: AKy350bkbiaOTV48G/m6wg5f7oTu79ZcJL2xRJuRL2it4F9Xsb2JgTwgmruSWgxfXHK3zLR53InjScARyCku/VQAIuk= X-Received: by 2002:a81:b245:0:b0:54f:b721:5325 with SMTP id q66-20020a81b245000000b0054fb7215325mr5587058ywh.1.1681563521186; Sat, 15 Apr 2023 05:58:41 -0700 (PDT) MIME-Version: 1.0 References: <20230414225551.858160935@linutronix.de> <20230414232310.382005483@linutronix.de> In-Reply-To: <20230414232310.382005483@linutronix.de> From: Brian Gerst Date: Sat, 15 Apr 2023 08:58:30 -0400 Message-ID: Subject: Re: [patch 19/37] x86/smpboot: Switch to hotplug core state synchronization To: Thomas Gleixner Cc: LKML , x86@kernel.org, David Woodhouse , Andrew Cooper , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, David Woodhouse , Usama Arif , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 14, 2023 at 7:44=E2=80=AFPM Thomas Gleixner wrote: > > The new AP state tracking and synchronization mechanism in the CPU hotplu= g > core code allows to remove quite some x86 specific code: > > 1) The AP alive synchronization based on cpumasks > > 2) The decision whether an AP can be brought up again > > Signed-off-by: Thomas Gleixner > Cc: Juergen Gross > Cc: Boris Ostrovsky > Cc: xen-devel@lists.xenproject.org > --- > arch/x86/Kconfig | 1 > arch/x86/include/asm/smp.h | 7 + > arch/x86/kernel/smp.c | 1 > arch/x86/kernel/smpboot.c | 159 ++++++++++----------------------------= ------- > arch/x86/xen/smp_hvm.c | 16 +--- > arch/x86/xen/smp_pv.c | 39 ++++++----- > 6 files changed, 72 insertions(+), 151 deletions(-) > > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -272,6 +272,7 @@ config X86 > select HAVE_UNSTABLE_SCHED_CLOCK > select HAVE_USER_RETURN_NOTIFIER > select HAVE_GENERIC_VDSO > + select HOTPLUG_CORE_SYNC_FULL if SMP > select HOTPLUG_SMT if SMP > select IRQ_FORCED_THREADING > select NEED_PER_CPU_EMBED_FIRST_CHUNK > --- a/arch/x86/include/asm/smp.h > +++ b/arch/x86/include/asm/smp.h > @@ -38,6 +38,8 @@ struct smp_ops { > void (*crash_stop_other_cpus)(void); > void (*smp_send_reschedule)(int cpu); > > + void (*cleanup_dead_cpu)(unsigned cpu); > + void (*poll_sync_state)(void); > int (*cpu_up)(unsigned cpu, struct task_struct *tidle); > int (*cpu_disable)(void); > void (*cpu_die)(unsigned int cpu); > @@ -90,7 +92,8 @@ static inline int __cpu_disable(void) > > static inline void __cpu_die(unsigned int cpu) > { > - smp_ops.cpu_die(cpu); > + if (smp_ops.cpu_die) > + smp_ops.cpu_die(cpu); > } > > static inline void play_dead(void) > @@ -122,8 +125,6 @@ void native_smp_cpus_done(unsigned int m > int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); > int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); > int native_cpu_disable(void); > -int common_cpu_die(unsigned int cpu); > -void native_cpu_die(unsigned int cpu); > void hlt_play_dead(void); > void native_play_dead(void); > void play_dead_common(void); > --- a/arch/x86/kernel/smp.c > +++ b/arch/x86/kernel/smp.c > @@ -269,7 +269,6 @@ struct smp_ops smp_ops =3D { > .smp_send_reschedule =3D native_smp_send_reschedule, > > .cpu_up =3D native_cpu_up, > - .cpu_die =3D native_cpu_die, > .cpu_disable =3D native_cpu_disable, > .play_dead =3D native_play_dead, > > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -57,6 +57,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -101,9 +102,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); > DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); > EXPORT_PER_CPU_SYMBOL(cpu_info); > > -/* All of these masks are initialized in setup_cpu_local_masks() */ > -static cpumask_var_t cpu_initialized_mask; > -static cpumask_var_t cpu_callout_mask; > /* Representing CPUs for which sibling maps can be computed */ > static cpumask_var_t cpu_sibling_setup_mask; > > @@ -169,8 +167,8 @@ static void smp_callin(void) > int cpuid =3D smp_processor_id(); > > /* > - * If waken up by an INIT in an 82489DX configuration > - * cpu_callout_mask guarantees we don't get here before an > + * If waken up by an INIT in an 82489DX configuration the alive > + * synchronization guarantees we don't get here before an > * INIT_deassert IPI reaches our local APIC, so it is now safe to > * touch our local APIC. > * > @@ -216,17 +214,6 @@ static void ap_calibrate_delay(void) > cpu_data(smp_processor_id()).loops_per_jiffy =3D loops_per_jiffy; > } > > -static void wait_for_master_cpu(int cpu) > -{ > - /* > - * Wait for release by control CPU before continuing with AP > - * initialization. > - */ > - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); > - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) > - cpu_relax(); > -} > - > /* > * Activate a secondary processor. > */ > @@ -247,11 +234,10 @@ static void notrace start_secondary(void > cpu_init_exception_handling(); > > /* > - * Sync point with wait_cpu_initialized(). Sets AP in > - * cpu_initialized_mask and then waits for the control CPU > - * to release it. > + * Sync point with the hotplug core. Sets the sync state to ALIVE > + * and waits for the control CPU to release it. > */ > - wait_for_master_cpu(raw_smp_processor_id()); > + cpuhp_ap_sync_alive(); > > cpu_init(); > rcu_cpu_starting(raw_smp_processor_id()); > @@ -285,7 +271,6 @@ static void notrace start_secondary(void > set_cpu_online(smp_processor_id(), true); > lapic_online(); > unlock_vector_lock(); > - cpu_set_state_online(smp_processor_id()); > x86_platform.nmi_init(); > > /* enable local interrupts */ > @@ -736,9 +721,10 @@ static void impress_friends(void) > * Allow the user to impress friends. > */ > pr_debug("Before bogomips\n"); > - for_each_possible_cpu(cpu) > - if (cpumask_test_cpu(cpu, cpu_callout_mask)) > + for_each_possible_cpu(cpu) { > + if (cpumask_test_cpu(cpu, cpu_online_mask)) > bogosum +=3D cpu_data(cpu).loops_per_jiffy; This should be the same as for_each_online_cpu(). -- Brian Gerst From xen-devel-bounces@lists.xenproject.org Sat Apr 15 13:22:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 13:22:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521459.810164 (Exim 4.92) (envelope-from ) id 1pnfre-00049s-Ex; Sat, 15 Apr 2023 13:22:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521459.810164; Sat, 15 Apr 2023 13:22:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnfre-00049l-CG; Sat, 15 Apr 2023 13:22:50 +0000 Received: by outflank-mailman (input) for mailman id 521459; Sat, 15 Apr 2023 13:22:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnfrd-00049f-Ae for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 13:22:49 +0000 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [2607:f8b0:4864:20::b32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c2f217f-db90-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 15:22:46 +0200 (CEST) Received: by mail-yb1-xb32.google.com with SMTP id u13so21663658ybu.5 for ; Sat, 15 Apr 2023 06:22:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c2f217f-db90-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681564965; x=1684156965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FVzmiHK64lr1yWOA/+XrXfsMmSyuvLawYPiT7JCvob8=; b=kzN6Qldowb67XS8W5yIr9TKg8Wd1DqCY2ePREiBWY/NtxgAgDeDo2TRyur9nar8C++ HnTU0sGESuNQrLXZCmp3MbPSMe1ctHBcEzOeudm0xjlT82JqM37TyyV1w921MOnZOt6Z Yl7JLD1auTWmNaBAqeCDaHjO1FCRr0N1PCoLWMJkB962BgyPgRGiSnVZP/zKM+Wii/Z6 avk+V5z1zf7aKn7zz8tC7iPNYYczHe6njW5BJijHx4bRAJcJmA1C+2uvle8w9h0679Xe I+RvsIyQOxeJGPvDgiUZDzz/5uSuqAkakw1Oh0ISxsKLLZT6a+aMlHFulUbAlWle21kk M3lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681564965; x=1684156965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FVzmiHK64lr1yWOA/+XrXfsMmSyuvLawYPiT7JCvob8=; b=JJBwkLuzriltLTTz/O95XvOeEVsZ2WkoNAvbPX06WGZHFVt4EVTJ5O+AM/1NDgK8tF 9FKC5NrZ1cRMpD8cMUjkAClhhXoF4A2vTKvn3/8JKFqZPFKH9Cleaz8z7Dl/GgxwjwpD fNZXMFcYgOocrpDvl6iSbdaP2IZG5pPL0GqHhAi4VhwuR9pu30MjRyFhNDQ3pQ9k0qgn 8DgAlHFJyoHMoK59k0G0aIEwYtGUW7Dx52aDkrE2MeqgUFFnSLumxrksvOgAGx1TdQpF /tq3bT9Rl4zWDiWsNOe5VfplTGBZcP4uymdX21ZzyMoAsa/wrezdcWXZeOVSgG+ufC0h /3gQ== X-Gm-Message-State: AAQBX9eaeQOvmTGXtg0hFdO6TYjHV+K5ps/lUaiU/kpi1MbNGFkIKP3I 712TKP81rBOTUphBgBQjhtd1442BO6Yo/TGnwQ== X-Google-Smtp-Source: AKy350ZOA4eLsjA57UfjGyPrbRouS5+i8hiU4IROzy4HMM/uTm55VtPGAF6abh2Q+UqEwUzS/wn5tzSKLFF9guCfVhM= X-Received: by 2002:a25:df94:0:b0:b8b:f5fb:5986 with SMTP id w142-20020a25df94000000b00b8bf5fb5986mr5819247ybg.10.1681564965560; Sat, 15 Apr 2023 06:22:45 -0700 (PDT) MIME-Version: 1.0 References: <20230414225551.858160935@linutronix.de> <20230414232311.379210081@linutronix.de> In-Reply-To: <20230414232311.379210081@linutronix.de> From: Brian Gerst Date: Sat, 15 Apr 2023 09:22:34 -0400 Message-ID: Subject: Re: [patch 35/37] x86/smpboot: Support parallel startup of secondary CPUs To: Thomas Gleixner Cc: LKML , x86@kernel.org, David Woodhouse , Andrew Cooper , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 14, 2023 at 7:45=E2=80=AFPM Thomas Gleixner wrote: > > From: David Woodhouse > > Rework the real-mode startup code to allow for APs to be brought up in > parallel. This is in two parts: > > 1. Introduce a bit-spinlock to prevent them from all using the real > mode stack at the same time. > > 2. Avoid needing to use the global smpboot_control variable to pass > each AP its CPU number. > > To achieve the latter, export the cpuid_to_apicid[] array so that each > AP can find its own CPU number by searching therein based on its APIC ID. > > Introduce flags in the top bits of smpboot_control which indicate methods > by which an AP should find its CPU number. For a serialized bringup, the > CPU number is explicitly passed in the low bits of smpboot_control as > before. For parallel mode there are flags directing the AP to find its AP= IC > ID in CPUID leaf 0x0b or 1x1f (for X2APIC mode) or CPUID leaf 0x01 where = 8 > bits are sufficient, then perform the cpuid_to_apicid[] lookup with that. > > Aside from the fact that APs will now look up their CPU number via the > newly-exported cpuid_to_apicid[] table, there is no behavioural change > intended, since the parallel bootup has not yet been enabled. > > [ tglx: Initial proof of concept patch with bitlock and APIC ID lookup ] > [ dwmw2: Rework and testing, commit message, CPUID 0x1 and CPU0 support ] > [ seanc: Fix stray override of initial_gs in common_cpu_up() ] > [ Oleksandr Natalenko: reported suspend/resume issue fixed in > x86_acpi_suspend_lowlevel ] > > Co-developed-by: Thomas Gleixner > Signed-off-by: Thomas Gleixner > Co-developed-by: Brian Gerst > Signed-off-by: Brian Gerst > Signed-off-by: David Woodhouse > Signed-off-by: Usama Arif > Signed-off-by: Thomas Gleixner > --- > arch/x86/include/asm/apic.h | 2 > arch/x86/include/asm/realmode.h | 3 + > arch/x86/include/asm/smp.h | 8 +++ > arch/x86/kernel/acpi/sleep.c | 9 +++ > arch/x86/kernel/apic/apic.c | 2 > arch/x86/kernel/head_64.S | 79 ++++++++++++++++++++++++++++= ++++++- > arch/x86/kernel/smpboot.c | 5 -- > arch/x86/realmode/init.c | 3 + > arch/x86/realmode/rm/trampoline_64.S | 27 +++++++++-- > 9 files changed, 125 insertions(+), 13 deletions(-) > > --- a/arch/x86/include/asm/apic.h > +++ b/arch/x86/include/asm/apic.h > @@ -55,6 +55,8 @@ extern int local_apic_timer_c2_ok; > extern int disable_apic; > extern unsigned int lapic_timer_period; > > +extern int cpuid_to_apicid[]; > + > extern enum apic_intr_mode_id apic_intr_mode; > enum apic_intr_mode_id { > APIC_PIC, > --- a/arch/x86/include/asm/realmode.h > +++ b/arch/x86/include/asm/realmode.h > @@ -52,6 +52,7 @@ struct trampoline_header { > u64 efer; > u32 cr4; > u32 flags; > + u32 lock; > #endif > }; > > @@ -64,6 +65,8 @@ extern unsigned long initial_stack; > extern unsigned long initial_vc_handler; > #endif > > +extern u32 *trampoline_lock; > + > extern unsigned char real_mode_blob[]; > extern unsigned char real_mode_relocs[]; > > --- a/arch/x86/include/asm/smp.h > +++ b/arch/x86/include/asm/smp.h > @@ -198,4 +198,12 @@ extern unsigned int smpboot_control; > > #endif /* !__ASSEMBLY__ */ > > +/* Control bits for startup_64 */ > +#define STARTUP_APICID_CPUID_1F 0x80000000 > +#define STARTUP_APICID_CPUID_0B 0x40000000 > +#define STARTUP_APICID_CPUID_01 0x20000000 > + > +/* Top 8 bits are reserved for control */ > +#define STARTUP_PARALLEL_MASK 0xFF000000 > + > #endif /* _ASM_X86_SMP_H */ > --- a/arch/x86/kernel/acpi/sleep.c > +++ b/arch/x86/kernel/acpi/sleep.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include > #include "../../realmode/rm/wakeup.h" > @@ -127,7 +128,13 @@ int x86_acpi_suspend_lowlevel(void) > * value is in the actual %rsp register. > */ > current->thread.sp =3D (unsigned long)temp_stack + sizeof(temp_st= ack); > - smpboot_control =3D smp_processor_id(); > + /* > + * Ensure the CPU knows which one it is when it comes back, if > + * it isn't in parallel mode and expected to work that out for > + * itself. > + */ > + if (!(smpboot_control & STARTUP_PARALLEL_MASK)) > + smpboot_control =3D smp_processor_id(); > #endif > initial_code =3D (unsigned long)wakeup_long64; > saved_magic =3D 0x123456789abcdef0L; > --- a/arch/x86/kernel/apic/apic.c > +++ b/arch/x86/kernel/apic/apic.c > @@ -2377,7 +2377,7 @@ static int nr_logical_cpuids =3D 1; > /* > * Used to store mapping between logical CPU IDs and APIC IDs. > */ > -static int cpuid_to_apicid[] =3D { > +int cpuid_to_apicid[] =3D { > [0 ... NR_CPUS - 1] =3D -1, > }; > > --- a/arch/x86/kernel/head_64.S > +++ b/arch/x86/kernel/head_64.S > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > /* > * We are not able to switch in one step to the final KERNEL ADDRESS SPA= CE > @@ -234,8 +235,70 @@ SYM_INNER_LABEL(secondary_startup_64_no_ > ANNOTATE_NOENDBR // above > > #ifdef CONFIG_SMP > + /* > + * For parallel boot, the APIC ID is retrieved from CPUID, and th= en > + * used to look up the CPU number. For booting a single CPU, the > + * CPU number is encoded in smpboot_control. > + * > + * Bit 31 STARTUP_APICID_CPUID_1F flag (use CPUID 0x1f) > + * Bit 30 STARTUP_APICID_CPUID_0B flag (use CPUID 0x0b) > + * Bit 29 STARTUP_APICID_CPUID_01 flag (use CPUID 0x01) > + * Bit 0-23 CPU# if STARTUP_APICID_CPUID_xx flags are not set > + */ > movl smpboot_control(%rip), %ecx > + testl $STARTUP_APICID_CPUID_1F, %ecx > + jnz .Luse_cpuid_1f > + testl $STARTUP_APICID_CPUID_0B, %ecx > + jnz .Luse_cpuid_0b > + testl $STARTUP_APICID_CPUID_01, %ecx > + jnz .Luse_cpuid_01 > + andl $(~STARTUP_PARALLEL_MASK), %ecx > + jmp .Lsetup_cpu > + > +.Luse_cpuid_01: > + mov $0x01, %eax > + cpuid > + mov %ebx, %edx > + shr $24, %edx > + jmp .Lsetup_AP > + > +.Luse_cpuid_0b: > + mov $0x0B, %eax > + xorl %ecx, %ecx > + cpuid > + jmp .Lsetup_AP > + > +.Luse_cpuid_1f: > + mov $0x1f, %eax > + xorl %ecx, %ecx > + cpuid > > +.Lsetup_AP: > + /* EDX contains the APIC ID of the current CPU */ > + xorq %rcx, %rcx > + leaq cpuid_to_apicid(%rip), %rbx > + > +.Lfind_cpunr: > + cmpl (%rbx,%rcx,4), %edx > + jz .Lsetup_cpu > + inc %ecx > +#ifdef CONFIG_FORCE_NR_CPUS > + cmpl $NR_CPUS, %ecx > +#else > + cmpl nr_cpu_ids(%rip), %ecx > +#endif > + jb .Lfind_cpunr > + > + /* APIC ID not found in the table. Drop the trampoline lock and = bail. */ > + movq trampoline_lock(%rip), %rax > + lock > + btrl $0, (%rax) > + > +1: cli > + hlt > + jmp 1b > + > +.Lsetup_cpu: > /* Get the per cpu offset for the given CPU# which is in ECX */ > movq __per_cpu_offset(,%rcx,8), %rdx > #else > @@ -248,10 +311,20 @@ SYM_INNER_LABEL(secondary_startup_64_no_ > * > * RDX contains the per-cpu offset > */ > - movq pcpu_hot + X86_current_task(%rdx), %rax > - movq TASK_threadsp(%rax), %rsp > + movq pcpu_hot + X86_top_of_stack(%rdx), %rsp Switching to using pcpu_hot.top_of_stack is ok, but it's not completely equivalent. top_of_stack points to the end of the pt_regs structure, while the kernel stack starts below pt_regs even for kernel threads. So you need to subtract PTREGS_SIZE from the stack pointer after this. This change should also be a separate patch. -- Brian Gerst From xen-devel-bounces@lists.xenproject.org Sat Apr 15 14:05:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 14:05:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521463.810175 (Exim 4.92) (envelope-from ) id 1pngWO-0000E5-L8; Sat, 15 Apr 2023 14:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521463.810175; Sat, 15 Apr 2023 14:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pngWO-0000Dy-Gx; Sat, 15 Apr 2023 14:04:56 +0000 Received: by outflank-mailman (input) for mailman id 521463; Sat, 15 Apr 2023 14:04:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pngWM-0000Do-Io; Sat, 15 Apr 2023 14:04:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pngWM-0004Rm-Fn; Sat, 15 Apr 2023 14:04:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pngWL-0004Ep-TH; Sat, 15 Apr 2023 14:04:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pngWL-0004HR-Si; Sat, 15 Apr 2023 14:04:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qT5xkwpANFLVUY6fKj0sRZyDFGTZKnSJ9GuD6HjPlWo=; b=sIxjjxm5SqlHH/3XZ9rc7YejGE LP7mRqEu8M+heSziMo7j9jXus69EB9qNITiYLlVz7TFl7lRlKR7d4yfhVWL/8QHq0hQmOQlFp49lQ XgfR4shZHbJ7/ccYZ3dY0xyCjhyNgWgyOIOuYSRuAhItC4AkHgSSX8omjDOkZndywNns=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180266: trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7a934f4bd7d6f9da84c8812da3ba42ee10f5778e X-Osstest-Versions-That: linux=44149752e9987a9eac5ad78e6d3a20934b5e018d From: osstest service owner Date: Sat, 15 Apr 2023 14:04:53 +0000 flight 180266 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180266/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-rtds 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-credit1 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-arndale 8 xen-boot fail baseline untested test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180253 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-examine 8 reboot fail starved in 180253 test-armhf-armhf-xl-vhd 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-credit2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180253 version targeted for testing: linux 7a934f4bd7d6f9da84c8812da3ba42ee10f5778e baseline version: linux 44149752e9987a9eac5ad78e6d3a20934b5e018d Last test of basis 180253 2023-04-14 01:13:19 Z 1 days Testing same since 180264 2023-04-14 18:10:06 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Ghiti Cheng Xu Conor Dooley Erik Brakkee Huang Rui Jason Gunthorpe Kai Vehmanen Leon Romanovsky Linus Torvalds Maher Sanalla Mario Limonciello Mark Zhang Mathis Salmen Mustafa Ismail Oswald Buddenhagen Palmer Dabbelt Paul Menzel Pierre-Louis Bossart Rafael J. Wysocki Rui Salvaterra Saravanan Vajravel Shiraz Saleem Srinivas Pandruvada Stefan Binding Takashi Iwai Takashi Sakamoto Tatyana Nikolova Wyes Karny Xu Biang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-multivcpu host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) Not pushing. (No revision log; it would be 768 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 15 15:11:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 15:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521472.810184 (Exim 4.92) (envelope-from ) id 1pnhYJ-0007QA-M9; Sat, 15 Apr 2023 15:10:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521472.810184; Sat, 15 Apr 2023 15:10:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnhYJ-0007Pc-Ja; Sat, 15 Apr 2023 15:10:59 +0000 Received: by outflank-mailman (input) for mailman id 521472; Sat, 15 Apr 2023 15:10:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnhYH-0007PQ-R1; Sat, 15 Apr 2023 15:10:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnhYH-0005vs-MM; Sat, 15 Apr 2023 15:10:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnhYH-0005hX-4h; Sat, 15 Apr 2023 15:10:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnhYH-0007jZ-49; Sat, 15 Apr 2023 15:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k/DsF+cJyXIpRr5gpUwirITGrgt8HdHdifHnYioC/Qo=; b=ZifWHNAZS24B/iIXzCwC89qEmb mf7hEvJ7eb0608qU0vGWUaVWRdKLqkcTEq1pOhpdMjQ+GqhYGJQkH3x9fqaaYb6yzxk5Q1TTk2pC+ 4rUBY8r8Pbg0uG2k2W6s6s2KwOWsYSjnAaPLPx2gqC9blhqEgEHrA6vYu5uEU3fSsEhI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180267: trouble: broken/pass X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt-raw::broken:regression libvirt:test-armhf-armhf-libvirt-raw:host-install(5):broken:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=7cbbd45af115c24dba1b1be9631a32d6215ff0cc X-Osstest-Versions-That: libvirt=ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 From: osstest service owner Date: Sat, 15 Apr 2023 15:10:57 +0000 flight 180267 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180267/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 5 host-install(5) broken starved in 180255 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 180255 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180255 version targeted for testing: libvirt 7cbbd45af115c24dba1b1be9631a32d6215ff0cc baseline version: libvirt ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 Last test of basis 180255 2023-04-14 04:18:49 Z 1 days Testing same since 180267 2023-04-15 04:20:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-raw broken broken-step test-armhf-armhf-libvirt-raw host-install(5) Not pushing. ------------------------------------------------------------ commit 7cbbd45af115c24dba1b1be9631a32d6215ff0cc Author: Peter Krempa Date: Thu Apr 13 08:39:22 2023 +0200 virsh-domain-event: Make 'virshEventIOError(Reason)Print' translation friendly Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 24b56900f8eb1e508a7aa83ca5a47ce8404c6bbc Author: Peter Krempa Date: Thu Apr 13 08:39:22 2023 +0200 virsh-domain-event: Make 'virshEventWatchdogPrint' translation friendly Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 4c531e0130f5e4ba82b8df893740dba2367f4586 Author: Peter Krempa Date: Thu Apr 13 08:39:22 2023 +0200 virsh-domain-event: Make 'virshEventTrayChangePrint' translation friendly Remove construction of the event string from sub-strings marked as translatable. Without context it's impossible to translate it correctly. This slightly increases verbosity of the code but actually makes it more readable as everything is inline. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 9dc2a41f1e2df7c16ffad8b8a33e44f05ad4fa5a Author: Peter Krempa Date: Thu Apr 13 09:31:34 2023 +0200 virsh: event: Introduce virshEventPrintf Extract internals of virshEventPrint into a function that can take the format string. The function will be used in upcoming patches which make the event formatting translatable. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 13af21fb7490e4aae1514ee1318c7096eea07fcc Author: Peter Krempa Date: Thu Apr 13 09:19:27 2023 +0200 vshPrint: Add version using 'va_list' Add a version for functions which may already need to take a printf format string. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 620d9427490144a5234001c0ea80bf74dab48a03 Author: Peter Krempa Date: Thu Apr 13 09:44:05 2023 +0200 virshGraphicsAddressToString: Remove pointless translation There's no point in marking the protocol name as translatable. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 2fbb8e9a7b955ae4544fafe6cf48af0cb1147d0d Author: Peter Krempa Date: Thu Apr 13 08:30:21 2023 +0200 Don't translate strings used with VIR_DEBUG Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik Reviewed-by: Ján Tomko commit b108a73a7bcedb65a324eed692712478101848ef Author: Peter Krempa Date: Wed Apr 12 14:46:04 2023 +0200 virCgroupV1GetBlkioIo(Device)Serviced: Refactor extraction of cgroup data Rewrite the code to improve maintainability and also re-do construction of error messages which are assembled from non-translatable parts. Closes: https://gitlab.com/libvirt/libvirt/-/issues/455 Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik commit 194cfb44e77ce25d99240f24321559f569251e68 Author: Andrea Bolognani Date: Fri Apr 14 10:37:10 2023 +0200 qemu: Fix incorrect command name in error messages Signed-off-by: Andrea Bolognani From xen-devel-bounces@lists.xenproject.org Sat Apr 15 19:00:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 19:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521482.810195 (Exim 4.92) (envelope-from ) id 1pnl8G-0004zG-RV; Sat, 15 Apr 2023 19:00:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521482.810195; Sat, 15 Apr 2023 19:00:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnl8G-0004z9-NI; Sat, 15 Apr 2023 19:00:20 +0000 Received: by outflank-mailman (input) for mailman id 521482; Sat, 15 Apr 2023 19:00:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnl8E-0004ys-I3; Sat, 15 Apr 2023 19:00:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnl8E-00039I-Ck; Sat, 15 Apr 2023 19:00:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnl8D-0006Iv-U2; Sat, 15 Apr 2023 19:00:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnl8D-0001ir-TY; Sat, 15 Apr 2023 19:00:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Nb06gDW/EWxx5aIsf46XKdOKtx7sFnbzbCzrXXvM+R4=; b=Limn6tOb7LETlAaLcGYRHMRu+E Qg/1VysAlSRrfNXZbIJKcOidg6/IA4PUAjbJnhN6uZqWOZwcHALMcezSEekLeEX2Gr9U9RnClCmBF RuUa1Vek5xbjd70rVlHcuxLgjvVClsU00sH6/kwU8afxHBnAHt8+oS8WVowUVLdLDxJc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180268: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/bootloader:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/kernel:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=18c128ba66e6308744850aca96dbffd18f91c29b X-Osstest-Versions-That: xen=f872a624cbf92de9944483eea7674ef80ced1380 From: osstest service owner Date: Sat, 15 Apr 2023 19:00:17 +0000 flight 180268 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180268/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-rtds broken Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 5 host-install(5) broken starved in 180238 test-armhf-armhf-xl-arndale 8 xen-boot fail baseline untested test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180238 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180238 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-examine 11 examine-serial/bootloader fail starved in 180238 test-armhf-armhf-examine 12 examine-serial/kernel fail starved in 180238 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180238 version targeted for testing: xen 18c128ba66e6308744850aca96dbffd18f91c29b baseline version: xen f872a624cbf92de9944483eea7674ef80ced1380 Last test of basis 180238 2023-04-13 14:38:34 Z 2 days Failing since 180256 2023-04-14 05:34:08 Z 1 days 3 attempts Testing same since 180265 2023-04-14 22:10:49 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-rtds host-install(5) Not pushing. ------------------------------------------------------------ commit 18c128ba66e6308744850aca96dbffd18f91c29b Author: Andrew Cooper Date: Thu Jan 26 14:57:45 2023 +0000 x86/hvm: Disallow disabling paging in 64bit mode The Long Mode consistency checks exist to "ensure that the processor does not enter an undefined mode or state that results in unpredictable behavior". APM Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row preventing the OS from trying to exit Long mode while in 64bit mode. This could leave the CPU in Protected Mode with an %rip above the 4G boundary. Experimentally, AMD CPUs really do permit this state transition. An OS which tries it hits an instant SHUTDOWN, even in cases where the truncation I expect to be going on behind the scenes ought to result in sane continued execution. Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" section instructs peoples to switch to a compatibility mode segment first before clearing CR0.PG, which does clear out the upper bits in %rip. This is further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 Architecture". Either way, this appears to have been a genuine oversight in the AMD64 spec. Intel, on the other hand, rejects this state transition with #GP. Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to 4.1.2 "Paging-Mode Enable" was altered from If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP); software should clear CR4.PCIDE before attempting to disable paging. to If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP). Software should transition to compatibility mode and clear CR4.PCIDE before attempting to disable paging. which acknowledges this corner case, but there doesn't appear to be any other discussion even in the relevant Long Mode sections. So it appears that Intel spotted and addressed the corner case in IA-32e mode, but were 15 years late to document it. Xen was written to the AMD spec, and misses the check. Follow the Intel behaviour, because it is more sensible and avoids hitting a VMEntry failure. Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné commit 8363b1f62e561cfb73073b4b094516fcbbd7020e Author: Marek Marczykowski-Górecki Date: Thu Apr 13 14:23:40 2023 +0200 automation: switch ADL hw tests to debug build This should give a lot more useful information in case of a failure, and also enable some asserts for extra checks. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Apr 15 19:58:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 19:58:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521491.810204 (Exim 4.92) (envelope-from ) id 1pnm2V-0001vG-BK; Sat, 15 Apr 2023 19:58:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521491.810204; Sat, 15 Apr 2023 19:58:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnm2V-0001v9-8k; Sat, 15 Apr 2023 19:58:27 +0000 Received: by outflank-mailman (input) for mailman id 521491; Sat, 15 Apr 2023 19:58:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnm2U-0001v3-Bo for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 19:58:26 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df1cc446-dbc7-11ed-b21e-6b7b168915f2; Sat, 15 Apr 2023 21:58:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df1cc446-dbc7-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1681588704; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=aGoV2weU6U132U2moXp+8TbQk1yUDNrx4rdfkwTi2Og=; b=LxWTeLSksl9YTUrdoQmdezUMKliOGb8Bi1Lg3Q49PjOpmj/ZUH8M7I1T N4lDVbTjfWUgDead3ziQQI24KO8Jyba3gmG5TXfN0OPGxLCojRWPA6jab +9rnUBTcouwhqIWbiOxPo4nJbob0NzvifyYjjNRQJVMIjHMIQ2tg1l5eE 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106054553 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:0mLkD6maCYrDuNsKj2SozUro5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJNCm/UMq3eZWb0Kooja4q/8RkO7cDdydJrHgQ5rSo9QiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgX5QKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eFCDS4SYjmHvd2VmL+UW+Mv290jLfC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQth/A+ DqbozmkWXn2MvSj533U+WyhhdPDxyP7RrpPE4+y+dxD1Qj7Kms7V0RNCArTTeOCol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Mcc39QWMwar8+BuCCy4PSTspQMMinN87Q3otz FDht9DuAyZmvPuKSHae3rCOpDi2NG4eKmpqWMMfZVJbuZ+5+th110+RCI85S8ZZk+EZBxntm RWUsyQXg48srpYG+LSxvg3egzOV882hohEO2unHYo60xlonNNf5PN31uASzAeVod9jAEATY1 JQQs43Htb1VU8nQ/MCYaL9VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX aMyhe+yzMUJVJdSRfUrC79d8uxzpUQaKfzrV+rPcv1FaYVreQmM8UlGPBDAhj29yxZxy/lla f93lPpA6l5DUMxaIMeeHb9BgdfHOAhlrY8seXwL50v+iufPDJJkYbwELEGPfogE0U9wmy2Mq 4w3H5LTm31ivBjWPnG/HXg7cQpbchDWxPne96RqSwJ0ClM5RzlxVqGJn+5Jlk4Mt/09q9okN 0qVAidwoGcTT1WeQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:L7u626AZq+86ki7lHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U 4ZSdkdNOHN X-Talos-CUID: 9a23:tPFag2/TRHXsuW3tUPKVv1NOP946flTZ9kjze0KXGGwqFaSVSGbFrQ== X-Talos-MUID: 9a23:/VIeiQW2VR1AmpLq/APCw2BpKspr36j0CEATqcgBicOLFwUlbg== X-IronPort-AV: E=Sophos;i="5.99,200,1677560400"; d="scan'208";a="106054553" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH] x86/livepatch: Fix livepatch application when CET is active Date: Sat, 15 Apr 2023 20:58:16 +0100 Message-ID: <20230415195816.3717648-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Right now, trying to apply a livepatch on any system with CET shstk (AMD Zen3 or later, Intel Tiger Lake or Sapphire Rapids and later) fails as follows: (XEN) livepatch: lp: Verifying enabled expectations for all functions (XEN) common/livepatch.c:1591: livepatch: lp: timeout is 30000000ns (XEN) common/livepatch.c:1703: livepatch: lp: CPU28 - IPIing the other 127 CPUs (XEN) livepatch: lp: Applying 1 functions (XEN) hi_func: Hi! (called 1 times) (XEN) Hook executing. (XEN) Assertion 'local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu))' failed at arch/x86/smp.c:265 (XEN) *** DOUBLE FAULT *** The assertion failure is from a global (system wide) TLB flush initiated by modify_xen_mappings(). I'm not entirely sure when this broke, and I'm not sure exactly what causes the #DF's, but it doesn't really matter either because they highlight a latent bug that I'd overlooked with the CET-SS vs patching work the first place. While we're careful to arrange for the patching CPU to avoid encountering non-shstk memory with transient shstk perms, other CPUs can pick these mappings up too if they need to re-walk for uarch reasons. Another bug is that for livepatching, we only disable CET if shadow stacks are in use. Running on Intel CET systems when Xen is only using CET-IBT will crash in arch_livepatch_quiesce() when trying to clear CR0.WP with CR4.CET still active. Also, we never went and cleared the dirty bits on .rodata. This would matter (for the same reason it matters on .text - it becomes a valid target for WRSS), but we never actually patch .rodata anyway. Therefore rework how we do patching for both alternatives and livepatches. Introduce modify_xen_mappings_lite() with a purpose similar to modify_xen_mappings(), but stripped down to the bare minimum as it's used in weird contexts. Leave all complexity to the caller to handle. Instead of patching by clearing CR0.WP (and having to jump through some fragile hoops to disable CET in order to do this), just transiently relax the permissions on .text via l2_identmap[]. The perms are relaxed globally, but is safe enough. Alternatives run before we boot APs, and Livepatching runs in a quiesced state where the other CPUs are not doing anything interesting. This approach is far more robust. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Konrad Rzeszutek Wilk CC: Ross Lagerwall Pulling put_pte_flags() out of the loops in modify_xen_mappings_lite() halves the size of the function. The code generation of the typesafe pagetable helpers is terrible, both because of flags needing a 32->64 expand, and because of _PAGE_NX using cpu_has_nx behind the scene. We really should improve how all of this works. --- xen/arch/x86/alternative.c | 45 ++++++++------------ xen/arch/x86/livepatch.c | 56 ++++++++++--------------- xen/arch/x86/mm.c | 71 ++++++++++++++++++++++++++++++++ xen/common/virtual_region.c | 22 +++++++--- xen/include/xen/mm.h | 1 + xen/include/xen/virtual_region.h | 4 +- 6 files changed, 132 insertions(+), 67 deletions(-) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 2383fa66294c..fc815bc7d627 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -382,24 +382,28 @@ static int __init cf_check nmi_apply_alternatives( */ if ( !(alt_done & alt_todo) ) { - unsigned long cr0, cr4; - - cr0 = read_cr0(); - cr4 = read_cr4(); - - if ( cr4 & X86_CR4_CET ) - write_cr4(cr4 & ~X86_CR4_CET); - - /* Disable WP to allow patching read-only pages. */ - write_cr0(cr0 & ~X86_CR0_WP); + /* + * Relax perms on .text to be RWX, so we can modify them. + * + * This relaxes perms globally, but we run ahead of bringing APs + * online, so only have our own TLB to worry about. + */ + modify_xen_mappings_lite(XEN_VIRT_START + MB(2), + (unsigned long)&__2M_text_end, + PAGE_HYPERVISOR_RWX); + flush_local(FLUSH_TLB_GLOBAL); _apply_alternatives(__alt_instructions, __alt_instructions_end, alt_done); - write_cr0(cr0); - - if ( cr4 & X86_CR4_CET ) - write_cr4(cr4); + /* + * Reinstate perms on .text to be RW. This also cleans out the dirty + * bits, which matters when CET Shstk is active. + */ + modify_xen_mappings_lite(XEN_VIRT_START + MB(2), + (unsigned long)&__2M_text_end, + PAGE_HYPERVISOR_RX); + flush_local(FLUSH_TLB_GLOBAL); alt_done |= alt_todo; } @@ -454,19 +458,6 @@ static void __init _alternative_instructions(bool force) panic("Timed out waiting for alternatives self-NMI to hit\n"); set_nmi_callback(saved_nmi_callback); - - /* - * When Xen is using shadow stacks, the alternatives clearing CR0.WP and - * writing into the mappings set dirty bits, turning the mappings into - * shadow stack mappings. - * - * While we can execute from them, this would also permit them to be the - * target of WRSS instructions, so reset the dirty after patching. - */ - if ( cpu_has_xen_shstk ) - modify_xen_mappings(XEN_VIRT_START + MB(2), - (unsigned long)&__2M_text_end, - PAGE_HYPERVISOR_RX); } void __init alternative_instructions(void) diff --git a/xen/arch/x86/livepatch.c b/xen/arch/x86/livepatch.c index f2d783fdc567..a54d991c5f0f 100644 --- a/xen/arch/x86/livepatch.c +++ b/xen/arch/x86/livepatch.c @@ -61,46 +61,32 @@ int arch_livepatch_safety_check(void) int noinline arch_livepatch_quiesce(void) { - /* If Shadow Stacks are in use, disable CR4.CET so we can modify CR0.WP. */ - if ( cpu_has_xen_shstk ) - write_cr4(read_cr4() & ~X86_CR4_CET); - - /* Disable WP to allow changes to read-only pages. */ - write_cr0(read_cr0() & ~X86_CR0_WP); + /* + * Relax perms on .text to be RWX, so we can modify them. + * + * This relaxes perms globally, but all other CPUs are waiting on us. + */ + relax_virtual_region_perms(); + flush_local(FLUSH_TLB_GLOBAL); return 0; } void noinline arch_livepatch_revive(void) { - /* Reinstate WP. */ - write_cr0(read_cr0() | X86_CR0_WP); - - /* Clobber dirty bits and reinstate CET, if applicable. */ - if ( IS_ENABLED(CONFIG_XEN_SHSTK) && cpu_has_xen_shstk ) - { - unsigned long tmp; - - reset_virtual_region_perms(); - - write_cr4(read_cr4() | X86_CR4_CET); - - /* - * Fix up the return address on the shadow stack, which currently - * points at arch_livepatch_quiesce()'s caller. - * - * Note: this is somewhat fragile, and depends on both - * arch_livepatch_{quiesce,revive}() being called from the same - * function, which is currently the case. - * - * Any error will result in Xen dying with #CP, and its too late to - * recover in any way. - */ - asm volatile ("rdsspq %[ssp];" - "wrssq %[addr], (%[ssp]);" - : [ssp] "=&r" (tmp) - : [addr] "r" (__builtin_return_address(0))); - } + /* + * Reinstate perms on .text to be RX. This also cleans out the dirty + * bits, which matters when CET Shstk is active. + * + * The other CPUs waiting for us could in principle have re-walked while + * we were patching and cached the reduced perms in their TLB. Therefore, + * we need to do a global TLB flush. + * + * However, we can't use Xen's normal global TLB flush infrastructure, so + * delay the TLB flush to arch_livepatch_post_action(), which is called on + * all CPUs (including us) on the way out of patching. + */ + tighten_virtual_region_perms(); } int arch_livepatch_verify_func(const struct livepatch_func *func) @@ -197,6 +183,8 @@ void noinline arch_livepatch_revert(const struct livepatch_func *func) */ void noinline arch_livepatch_post_action(void) { + /* See arch_livepatch_revive() */ + flush_local(FLUSH_TLB_GLOBAL); } static nmi_callback_t *saved_nmi_callback; diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 36a07ef77eae..1707bcd2d15c 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5879,6 +5879,77 @@ int destroy_xen_mappings(unsigned long s, unsigned long e) return modify_xen_mappings(s, e, _PAGE_NONE); } +#if defined(CONFIG_LIVEPATCH) && defined(CONFIG_HAS_ALTERNATIVE) +/* + * Similar to modify_xen_mappings(), but used by the alternatives and + * livepatch in weird contexts. All synchronization, TLB flushing, etc is the + * responsibility of the caller, and *MUST* not be introduced here. + * + * Must be limited to XEN_VIRT_{START,END}, i.e. over l2_xenmap[]. + * Must be called with preset flags, and over present mappings. + * Must be called on leaf page boundaries. + */ +void modify_xen_mappings_lite(unsigned long s, unsigned long e, unsigned int _nf) +{ + unsigned long v = s, fm, nf; + + /* Set of valid PTE bits which may be altered. */ +#define FLAGS_MASK (_PAGE_NX|_PAGE_DIRTY|_PAGE_ACCESSED|_PAGE_RW|_PAGE_PRESENT) + _nf &= FLAGS_MASK; + + fm = put_pte_flags(FLAGS_MASK); + nf = put_pte_flags(_nf); + + ASSERT(nf & _PAGE_PRESENT); + ASSERT(IS_ALIGNED(s, PAGE_SIZE) && s >= XEN_VIRT_START); + ASSERT(IS_ALIGNED(e, PAGE_SIZE) && e <= XEN_VIRT_END); + + while ( v < e ) + { + l2_pgentry_t *pl2e = &l2_xenmap[l2_table_offset(v)]; + l2_pgentry_t l2e = l2e_read_atomic(pl2e); + unsigned int l2f = l2e_get_flags(l2e); + + ASSERT(l2f & _PAGE_PRESENT); + + if ( l2e_get_flags(l2e) & _PAGE_PSE ) + { + ASSERT(l1_table_offset(v) == 0); + + l2e_write_atomic(pl2e, l2e_from_intpte((l2e.l2 & ~fm) | nf)); + + v += 1UL << L2_PAGETABLE_SHIFT; + continue; + } + + /* else decend to l1 */ + { + l1_pgentry_t *pl1t = map_l1t_from_l2e(l2e); + + while ( v < e ) + { + l1_pgentry_t *pl1e = &pl1t[l1_table_offset(v)]; + l1_pgentry_t l1e = l1e_read_atomic(pl1e); + unsigned int l1f = l1e_get_flags(l1e); + + ASSERT(l1f & _PAGE_PRESENT); + + l1e_write_atomic(pl1e, l1e_from_intpte((l1e.l1 & ~fm) | nf)); + + v += 1UL << L1_PAGETABLE_SHIFT; + + if ( l2_table_offset(v) == 0 ) + break; + } + + unmap_domain_page(pl1t); + } + } + +#undef FLAGS_MASK +} +#endif /* LIVEPATCH || ALTERNATIVE */ + void __set_fixmap( enum fixed_addresses idx, unsigned long mfn, unsigned long flags) { diff --git a/xen/common/virtual_region.c b/xen/common/virtual_region.c index 5ecdba9c08ed..ddac5c9147e5 100644 --- a/xen/common/virtual_region.c +++ b/xen/common/virtual_region.c @@ -92,16 +92,28 @@ void unregister_virtual_region(struct virtual_region *r) remove_virtual_region(r); } -#if defined(CONFIG_LIVEPATCH) && defined(CONFIG_XEN_SHSTK) -void reset_virtual_region_perms(void) +#if defined(CONFIG_LIVEPATCH) && defined(CONFIG_X86) +void relax_virtual_region_perms(void) { const struct virtual_region *region; rcu_read_lock(&rcu_virtual_region_lock); list_for_each_entry_rcu( region, &virtual_region_list, list ) - modify_xen_mappings((unsigned long)region->start, - ROUNDUP((unsigned long)region->end, PAGE_SIZE), - PAGE_HYPERVISOR_RX); + modify_xen_mappings_lite((unsigned long)region->start, + ROUNDUP((unsigned long)region->end, PAGE_SIZE), + PAGE_HYPERVISOR_RWX); + rcu_read_unlock(&rcu_virtual_region_lock); +} + +void tighten_virtual_region_perms(void) +{ + const struct virtual_region *region; + + rcu_read_lock(&rcu_virtual_region_lock); + list_for_each_entry_rcu( region, &virtual_region_list, list ) + modify_xen_mappings_lite((unsigned long)region->start, + ROUNDUP((unsigned long)region->end, PAGE_SIZE), + PAGE_HYPERVISOR_RX); rcu_read_unlock(&rcu_virtual_region_lock); } #endif diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 9d14aed74baa..b0dc3ba9c98d 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -100,6 +100,7 @@ int map_pages_to_xen( unsigned int flags); /* Alter the permissions of a range of Xen virtual address space. */ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags); +void modify_xen_mappings_lite(unsigned long s, unsigned long e, unsigned int flags); int destroy_xen_mappings(unsigned long s, unsigned long e); /* Retrieve the MFN mapped by VA in Xen virtual address space. */ mfn_t xen_map_to_mfn(unsigned long va); diff --git a/xen/include/xen/virtual_region.h b/xen/include/xen/virtual_region.h index ba408eb87a1a..d05362071135 100644 --- a/xen/include/xen/virtual_region.h +++ b/xen/include/xen/virtual_region.h @@ -33,7 +33,9 @@ void setup_virtual_regions(const struct exception_table_entry *start, void unregister_init_virtual_region(void); void register_virtual_region(struct virtual_region *r); void unregister_virtual_region(struct virtual_region *r); -void reset_virtual_region_perms(void); + +void relax_virtual_region_perms(void); +void tighten_virtual_region_perms(void); #endif /* __XEN_VIRTUAL_REGION_H__ */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Sat Apr 15 21:04:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 21:04:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521497.810215 (Exim 4.92) (envelope-from ) id 1pnn4I-0000si-VN; Sat, 15 Apr 2023 21:04:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521497.810215; Sat, 15 Apr 2023 21:04:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnn4I-0000sb-SW; Sat, 15 Apr 2023 21:04:22 +0000 Received: by outflank-mailman (input) for mailman id 521497; Sat, 15 Apr 2023 21:04:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnn4H-0000sV-Jo for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 21:04:21 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16223bdf-dbd1-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 23:04:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16223bdf-dbd1-11ed-8611-37d641c3527e From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681592657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QvzaDLok1TQ4UelYWBZG7isf5NmoEpMzY70xaWHq6tY=; b=fIS1RUsnFKdb9xABGYfFiZCU2J2QWZeug/pOhRzYO2SSFiN67M2BraQ6i1WFD37roLQsyb 0Xo1pTWRYZ/WwMogkjjzj3I+bbwhVwR7hTC3ROy5wKT1EIYulJpr/cXNAdOvjkRz7uB3BI klyFr/vToH0lZCb+hb3VXX9pfB0N3D76XKagNMZKWitt63oRwb7aPaIvEhJSApLEK7ILRG Zkcr6A4WMIslSyduOboeP87v5gUiVRgVXC8mEjpP6oV0s0oxKgYk+mkzY1TMBc6xKWwYqj lHlMmqQccgQg7IW71Y5KizHByK/0ncSB7/Q2HObdyAE/q+s6MPivfs7vv6Bz9w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681592657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QvzaDLok1TQ4UelYWBZG7isf5NmoEpMzY70xaWHq6tY=; b=uGGpswhVFZB8lospVRZK/FCDeguM0Ticu2FJ7GXNrivH09zniqOSmq2BEICy2eBqNRVNGH 0xJtAf6AVJyuuYBQ== To: Brian Gerst Cc: LKML , x86@kernel.org, David Woodhouse , Andrew Cooper , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, David Woodhouse , Usama Arif , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: Re: [patch 19/37] x86/smpboot: Switch to hotplug core state synchronization In-Reply-To: References: <20230414225551.858160935@linutronix.de> <20230414232310.382005483@linutronix.de> Date: Sat, 15 Apr 2023 23:04:16 +0200 Message-ID: <87pm84yi0f.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Apr 15 2023 at 08:58, Brian Gerst wrote: > On Fri, Apr 14, 2023 at 7:44=E2=80=AFPM Thomas Gleixner wrote: >> pr_debug("Before bogomips\n"); >> - for_each_possible_cpu(cpu) >> - if (cpumask_test_cpu(cpu, cpu_callout_mask)) >> + for_each_possible_cpu(cpu) { >> + if (cpumask_test_cpu(cpu, cpu_online_mask)) >> bogosum +=3D cpu_data(cpu).loops_per_jiffy; > > This should be the same as for_each_online_cpu(). Duh, yes. Obviously... From xen-devel-bounces@lists.xenproject.org Sat Apr 15 21:06:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 15 Apr 2023 21:06:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521501.810226 (Exim 4.92) (envelope-from ) id 1pnn6a-0001SO-E1; Sat, 15 Apr 2023 21:06:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521501.810226; Sat, 15 Apr 2023 21:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnn6a-0001SH-9G; Sat, 15 Apr 2023 21:06:44 +0000 Received: by outflank-mailman (input) for mailman id 521501; Sat, 15 Apr 2023 21:06:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnn6Y-0001SB-LA for xen-devel@lists.xenproject.org; Sat, 15 Apr 2023 21:06:42 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a27f27c-dbd1-11ed-8611-37d641c3527e; Sat, 15 Apr 2023 23:06:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a27f27c-dbd1-11ed-8611-37d641c3527e From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681592799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3DiOB1jbfBoIoBcKhJ+tlgldd4KD5aJr4Sg6j9ebPUI=; b=P2JRe5U4lJMHWRXIblQx0pIuiWd2AghPV4KuEWvmDuReSyOVhQCCEFeElO4eRip+BZst8j FEt9t2BOSLC4o1kel1IC1nngSPriEuvEd6hiCJGBQiNkbnbNfFcto1Vl3sKZG2ESMonhFs An5RJlKu7/tSGpzgHR6Z7KG43eMP0SiKp3vTl4fTzoc+BUJC8yEtxBJufLRq9lbmeibFXN sl7kTAsogFv4BEj0maXzziyeRxITPDLItnz8esS3e+KABEeGtBs5ADBH+SUHP2X3sjvsCF sA5xfsq3ODgQ/B4I43wW92xDuUJXBh2S1RtOiUBnGhQ7c+K3ylqiGKlbM1+Z/A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681592799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3DiOB1jbfBoIoBcKhJ+tlgldd4KD5aJr4Sg6j9ebPUI=; b=QEW/hhbgWQeeaCKMhDdxi3o+5E2lnyqCY4azQRMF5wvL6dQ0zBCYuANaf/0HtZpTDBh4rO TIZpqZPJS0yZKOCg== To: Brian Gerst Cc: LKML , x86@kernel.org, David Woodhouse , Andrew Cooper , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan Subject: Re: [patch 35/37] x86/smpboot: Support parallel startup of secondary CPUs In-Reply-To: References: <20230414225551.858160935@linutronix.de> <20230414232311.379210081@linutronix.de> Date: Sat, 15 Apr 2023 23:06:38 +0200 Message-ID: <87mt38yhwh.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Apr 15 2023 at 09:22, Brian Gerst wrote: > On Fri, Apr 14, 2023 at 7:45=E2=80=AFPM Thomas Gleixner wrote: >> @@ -248,10 +311,20 @@ SYM_INNER_LABEL(secondary_startup_64_no_ >> * >> * RDX contains the per-cpu offset >> */ >> - movq pcpu_hot + X86_current_task(%rdx), %rax >> - movq TASK_threadsp(%rax), %rsp >> + movq pcpu_hot + X86_top_of_stack(%rdx), %rsp > > Switching to using pcpu_hot.top_of_stack is ok, but it's not > completely equivalent. top_of_stack points to the end of the pt_regs > structure, while the kernel stack starts below pt_regs even for kernel > threads. So you need to subtract PTREGS_SIZE from the stack pointer > after this. > > This change should also be a separate patch. You're right on both counts. From xen-devel-bounces@lists.xenproject.org Sun Apr 16 00:32:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 00:32:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521508.810234 (Exim 4.92) (envelope-from ) id 1pnqJ4-0005ae-QV; Sun, 16 Apr 2023 00:31:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521508.810234; Sun, 16 Apr 2023 00:31:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnqJ4-0005aX-N1; Sun, 16 Apr 2023 00:31:50 +0000 Received: by outflank-mailman (input) for mailman id 521508; Sun, 16 Apr 2023 00:31:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnqJ3-0005aN-3I; Sun, 16 Apr 2023 00:31:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnqJ3-00033q-01; Sun, 16 Apr 2023 00:31:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnqJ2-0004bg-CK; Sun, 16 Apr 2023 00:31:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnqJ2-0006OY-Bq; Sun, 16 Apr 2023 00:31:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q5PmMIjcN5ILZryl32+UOw6oCPOaz6UL48viKRqgDq8=; b=yeePAaHcTLiB1NmaYN6hdBaKK1 dfH0uoA752md0c6MvrBvNfiJZ8Y7D803QZ4feD0qd0p9y5dBrfOYqrWJ7V8ffREqkGT1jCHpYBHSQ b8OOxyhU4Jba7ktydi/ok1ky7jkn4XuO5LtGJdENtwaq/4hE/3FMkzdFjSIBYh52FZ+Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180269: trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7a934f4bd7d6f9da84c8812da3ba42ee10f5778e X-Osstest-Versions-That: linux=44149752e9987a9eac5ad78e6d3a20934b5e018d From: osstest service owner Date: Sun, 16 Apr 2023 00:31:48 +0000 flight 180269 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180269/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-multivcpu broken Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-arndale 8 xen-boot fail baseline untested test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180253 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-examine 8 reboot fail starved in 180253 test-armhf-armhf-libvirt 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-vhd 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-credit2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180253 version targeted for testing: linux 7a934f4bd7d6f9da84c8812da3ba42ee10f5778e baseline version: linux 44149752e9987a9eac5ad78e6d3a20934b5e018d Last test of basis 180253 2023-04-14 01:13:19 Z 1 days Testing same since 180264 2023-04-14 18:10:06 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Ghiti Cheng Xu Conor Dooley Erik Brakkee Huang Rui Jason Gunthorpe Kai Vehmanen Leon Romanovsky Linus Torvalds Maher Sanalla Mario Limonciello Mark Zhang Mathis Salmen Mustafa Ismail Oswald Buddenhagen Palmer Dabbelt Paul Menzel Pierre-Louis Bossart Rafael J. Wysocki Rui Salvaterra Saravanan Vajravel Shiraz Saleem Srinivas Pandruvada Stefan Binding Takashi Iwai Takashi Sakamoto Tatyana Nikolova Wyes Karny Xu Biang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-multivcpu broken broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-step test-armhf-armhf-xl-multivcpu host-install(5) Not pushing. (No revision log; it would be 768 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 16 04:32:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 04:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521515.810245 (Exim 4.92) (envelope-from ) id 1pnu3j-0002EN-0U; Sun, 16 Apr 2023 04:32:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521515.810245; Sun, 16 Apr 2023 04:32:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnu3i-0002EF-Q6; Sun, 16 Apr 2023 04:32:14 +0000 Received: by outflank-mailman (input) for mailman id 521515; Sun, 16 Apr 2023 04:32:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnu3h-0002E5-Qy; Sun, 16 Apr 2023 04:32:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnu3h-0007Th-E2; Sun, 16 Apr 2023 04:32:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pnu3g-00065f-Op; Sun, 16 Apr 2023 04:32:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pnu3g-0005PL-OB; Sun, 16 Apr 2023 04:32:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GJ9RrBNn6QZtTZL7DNMlit2mwhE/1BBfCBZU7ztS2Ak=; b=xlQvRivDANIGer1Bv6lqq1XkMD KuuKyhPR9W52JHSGP3i7oZE04iHGx8foCgN5llCfl4CSvf2YBpzREhkGBVNV9Z3H5fgRu07no3F7Z yZNXmVxQcR2VjKMNAwkdb/Oe7tTqDoVVQ8U9P4ycL8yUbU2dBuMYtGCJRihqcyhfuzUI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180270: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt-raw::broken:regression xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/bootloader:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/kernel:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=18c128ba66e6308744850aca96dbffd18f91c29b X-Osstest-Versions-That: xen=f872a624cbf92de9944483eea7674ef80ced1380 From: osstest service owner Date: Sun, 16 Apr 2023 04:32:12 +0000 flight 180270 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180270/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-rtds broken in 180268 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-install fail pass in 180268 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180268 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 5 host-install(5) broken baseline untested test-armhf-armhf-xl-rtds 5 host-install(5) broken in 180268 starved in 180238 test-armhf-armhf-libvirt-raw 5 host-install(5) broken starved in 180238 test-armhf-armhf-xl-arndale 8 xen-boot fail in 180268 baseline untested test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 180268 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 180268 never pass test-armhf-armhf-examine 11 examine-serial/bootloader fail in 180268 starved in 180238 test-armhf-armhf-examine 12 examine-serial/kernel fail in 180268 starved in 180238 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 180268 starved in 180238 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180238 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180238 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180238 version targeted for testing: xen 18c128ba66e6308744850aca96dbffd18f91c29b baseline version: xen f872a624cbf92de9944483eea7674ef80ced1380 Last test of basis 180238 2023-04-13 14:38:34 Z 2 days Failing since 180256 2023-04-14 05:34:08 Z 1 days 4 attempts Testing same since 180265 2023-04-14 22:10:49 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-arndale broken broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-arndale host-install(5) broken-job test-armhf-armhf-xl-rtds broken Not pushing. ------------------------------------------------------------ commit 18c128ba66e6308744850aca96dbffd18f91c29b Author: Andrew Cooper Date: Thu Jan 26 14:57:45 2023 +0000 x86/hvm: Disallow disabling paging in 64bit mode The Long Mode consistency checks exist to "ensure that the processor does not enter an undefined mode or state that results in unpredictable behavior". APM Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row preventing the OS from trying to exit Long mode while in 64bit mode. This could leave the CPU in Protected Mode with an %rip above the 4G boundary. Experimentally, AMD CPUs really do permit this state transition. An OS which tries it hits an instant SHUTDOWN, even in cases where the truncation I expect to be going on behind the scenes ought to result in sane continued execution. Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" section instructs peoples to switch to a compatibility mode segment first before clearing CR0.PG, which does clear out the upper bits in %rip. This is further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 Architecture". Either way, this appears to have been a genuine oversight in the AMD64 spec. Intel, on the other hand, rejects this state transition with #GP. Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to 4.1.2 "Paging-Mode Enable" was altered from If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP); software should clear CR4.PCIDE before attempting to disable paging. to If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP). Software should transition to compatibility mode and clear CR4.PCIDE before attempting to disable paging. which acknowledges this corner case, but there doesn't appear to be any other discussion even in the relevant Long Mode sections. So it appears that Intel spotted and addressed the corner case in IA-32e mode, but were 15 years late to document it. Xen was written to the AMD spec, and misses the check. Follow the Intel behaviour, because it is more sensible and avoids hitting a VMEntry failure. Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné commit 8363b1f62e561cfb73073b4b094516fcbbd7020e Author: Marek Marczykowski-Górecki Date: Thu Apr 13 14:23:40 2023 +0200 automation: switch ADL hw tests to debug build This should give a lot more useful information in case of a failure, and also enable some asserts for extra checks. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sun Apr 16 10:54:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 10:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521529.810254 (Exim 4.92) (envelope-from ) id 1po01i-0005u3-8l; Sun, 16 Apr 2023 10:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521529.810254; Sun, 16 Apr 2023 10:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po01i-0005tw-5t; Sun, 16 Apr 2023 10:54:34 +0000 Received: by outflank-mailman (input) for mailman id 521529; Sun, 16 Apr 2023 10:54:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po01h-0005tm-1l; Sun, 16 Apr 2023 10:54:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po01g-0008S5-Vi; Sun, 16 Apr 2023 10:54:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po01g-00067A-ER; Sun, 16 Apr 2023 10:54:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1po01g-0004Io-E4; Sun, 16 Apr 2023 10:54:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rhP1re3bB4ddfN/BnjAYKcuYjxH6M9uhnZL3GfJDOgM=; b=J645F4BxnQ0sCVs51En60NeHml hWO9PrISMsjeLliWND3Kn1y2bSxzhU5WnwYzNfa4hAVLDrSK4VOe9vsP/z630EEVgDOS6uxnrX4EO AxmuK2HrFWxvwe+s6fEe3T4UMuqR1P2I+pc1u2O53z/UUSwQYgC6gLForeETJ4DKlUPg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180271: trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking X-Osstest-Versions-This: linux=a7a55e27ad72fb0dc9281d6211cffeebef8dde65 X-Osstest-Versions-That: linux=44149752e9987a9eac5ad78e6d3a20934b5e018d From: osstest service owner Date: Sun, 16 Apr 2023 10:54:32 +0000 flight 180271 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180271/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-rtds 5 host-install(5) broken starved in 180253 test-armhf-armhf-xl-arndale 8 xen-boot fail baseline untested test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180253 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180253 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180253 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 8 reboot fail starved in 180253 test-armhf-armhf-libvirt 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-vhd 8 xen-boot fail starved in 180253 test-armhf-armhf-xl-credit2 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail starved in 180253 test-armhf-armhf-xl 8 xen-boot fail starved in 180253 test-armhf-armhf-libvirt-raw 8 xen-boot fail starved in 180253 version targeted for testing: linux a7a55e27ad72fb0dc9281d6211cffeebef8dde65 baseline version: linux 44149752e9987a9eac5ad78e6d3a20934b5e018d Last test of basis 180253 2023-04-14 01:13:19 Z 2 days Failing since 180264 2023-04-14 18:10:06 Z 1 days 4 attempts Testing same since 180271 2023-04-16 00:43:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Ghiti Cheng Xu Christoph Hellwig Conor Dooley Duy Truong Erik Brakkee Gregor Herburger Huang Rui Jason Gunthorpe Jens Axboe Jiri Kosina Kai Vehmanen Leon Romanovsky Linus Torvalds Maher Sanalla Mario Limonciello Mark Zhang Martin K. Petersen Mathis Salmen Matthias Schiffer Michal Kolar Ming Lei Mustafa Ismail Oswald Buddenhagen Palmer Dabbelt Paul Menzel Peter Korsgaard Pierre-Louis Bossart Rafael J. Wysocki Rui Salvaterra Saravanan Vajravel Shiraz Saleem Srinivas Pandruvada Stefan Binding Takashi Iwai Takashi Sakamoto Tatyana Nikolova Tharun Kumar P Wolfram Sang Wyes Karny Xu Biang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-multivcpu host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) Not pushing. (No revision log; it would be 996 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 16 11:25:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 11:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521536.810265 (Exim 4.92) (envelope-from ) id 1po0V8-0000vc-Ri; Sun, 16 Apr 2023 11:24:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521536.810265; Sun, 16 Apr 2023 11:24:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po0V8-0000vV-Om; Sun, 16 Apr 2023 11:24:58 +0000 Received: by outflank-mailman (input) for mailman id 521536; Sun, 16 Apr 2023 11:24:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po0V7-0000vJ-Jx; Sun, 16 Apr 2023 11:24:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po0V7-0000iC-HA; Sun, 16 Apr 2023 11:24:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po0V6-0006pN-VK; Sun, 16 Apr 2023 11:24:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1po0V6-00056G-Uz; Sun, 16 Apr 2023 11:24:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6uWGC8a5Dk3oXB9Gbeq6qzDOFY+KoZ8L8solsVLZyYs=; b=O4bSj+almSv1vciFi/+Sbo1+3M qQCDTbzw7CukL0LnhtX6CpfkubB4f7M0geVwTehimyU/3l6a5vk1aj/7TdBmONZKesMHkgVwhF3c1 Ruwi6t5VCTvysM3rbVOTt1vUiBgYPYIP2BBimrI+kjfLGQCg7FbpsDLXB1SyzGBykEZg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180273: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking xen-unstable:test-armhf-armhf-examine:host-install:broken:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/bootloader:fail:nonblocking xen-unstable:test-armhf-armhf-examine:examine-serial/kernel:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=18c128ba66e6308744850aca96dbffd18f91c29b X-Osstest-Versions-That: xen=f872a624cbf92de9944483eea7674ef80ced1380 From: osstest service owner Date: Sun, 16 Apr 2023 11:24:56 +0000 flight 180273 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180273/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-rtds broken in 180268 build-arm64-pvops 6 kernel-build fail REGR. vs. 180238 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180268 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 5 host-install(5) broken baseline untested test-armhf-armhf-xl-rtds 5 host-install(5) broken in 180268 starved in 180238 test-armhf-armhf-examine 5 host-install broken starved in 180238 test-armhf-armhf-xl-arndale 8 xen-boot fail in 180268 baseline untested test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 180268 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 180268 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 180268 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 180268 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 180268 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 180268 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 180268 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 180268 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 180268 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 180268 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 180268 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 180268 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 180268 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 180268 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 180268 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 180268 never pass test-armhf-armhf-examine 11 examine-serial/bootloader fail in 180268 starved in 180238 test-armhf-armhf-examine 12 examine-serial/kernel fail in 180268 starved in 180238 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180238 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180238 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180238 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180238 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180238 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180238 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180238 version targeted for testing: xen 18c128ba66e6308744850aca96dbffd18f91c29b baseline version: xen f872a624cbf92de9944483eea7674ef80ced1380 Last test of basis 180238 2023-04-13 14:38:34 Z 2 days Failing since 180256 2023-04-14 05:34:08 Z 2 days 5 attempts Testing same since 180265 2023-04-14 22:10:49 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-arndale broken broken-step test-armhf-armhf-examine host-install broken-step test-armhf-armhf-xl-arndale host-install(5) broken-job test-armhf-armhf-xl-rtds broken Not pushing. ------------------------------------------------------------ commit 18c128ba66e6308744850aca96dbffd18f91c29b Author: Andrew Cooper Date: Thu Jan 26 14:57:45 2023 +0000 x86/hvm: Disallow disabling paging in 64bit mode The Long Mode consistency checks exist to "ensure that the processor does not enter an undefined mode or state that results in unpredictable behavior". APM Vol2 Table 14-5 "Long-Mode Consistency Checks" lists them, but there is no row preventing the OS from trying to exit Long mode while in 64bit mode. This could leave the CPU in Protected Mode with an %rip above the 4G boundary. Experimentally, AMD CPUs really do permit this state transition. An OS which tries it hits an instant SHUTDOWN, even in cases where the truncation I expect to be going on behind the scenes ought to result in sane continued execution. Furthermore, right from the very outset, the APM Vol2 14.7 "Leaving Long Mode" section instructs peoples to switch to a compatibility mode segment first before clearing CR0.PG, which does clear out the upper bits in %rip. This is further backed up by Vol2 Figure 1-6 "Operating Modes of the AMD64 Architecture". Either way, this appears to have been a genuine oversight in the AMD64 spec. Intel, on the other hand, rejects this state transition with #GP. Between revision 71 (Nov 2019) and 72 (May 2020) of SDM Vol3, a footnote to 4.1.2 "Paging-Mode Enable" was altered from If CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP); software should clear CR4.PCIDE before attempting to disable paging. to If the logical processor is in 64-bit mode or if CR4.PCIDE= 1, an attempt to clear CR0.PG causes a general-protection exception (#GP). Software should transition to compatibility mode and clear CR4.PCIDE before attempting to disable paging. which acknowledges this corner case, but there doesn't appear to be any other discussion even in the relevant Long Mode sections. So it appears that Intel spotted and addressed the corner case in IA-32e mode, but were 15 years late to document it. Xen was written to the AMD spec, and misses the check. Follow the Intel behaviour, because it is more sensible and avoids hitting a VMEntry failure. Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné commit 8363b1f62e561cfb73073b4b094516fcbbd7020e Author: Marek Marczykowski-Górecki Date: Thu Apr 13 14:23:40 2023 +0200 automation: switch ADL hw tests to debug build This should give a lot more useful information in case of a failure, and also enable some asserts for extra checks. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sun Apr 16 12:50:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 12:50:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521544.810275 (Exim 4.92) (envelope-from ) id 1po1q3-0001Ys-AR; Sun, 16 Apr 2023 12:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521544.810275; Sun, 16 Apr 2023 12:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1q3-0001Yl-7T; Sun, 16 Apr 2023 12:50:39 +0000 Received: by outflank-mailman (input) for mailman id 521544; Sun, 16 Apr 2023 12:50:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1q1-0001Yf-Kl for xen-devel@lists.xenproject.org; Sun, 16 Apr 2023 12:50:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1q1-0002X8-5o; Sun, 16 Apr 2023 12:50:37 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1po1q0-0004UO-Tp; Sun, 16 Apr 2023 12:50:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=d6s+DZMw/J0/1XlNrVNF3o4YPzAck+dr1lmeDx3RelA=; b=YDM0YLM8ma8e69yFNZC3pa6VMI EN80ZkYuBbVBbTjth5YcNXFZOQlGNQWTJrauFLeZf4pJVhzBlQsnGZqUWsO6W8COcmT60KD1fJToB PoroCuJcKjHJ7QMmW2epbPaJUfjqGuSoxExmtROvyaWMwIxIiW+4v9bWNo9ovxKcERG0=; Message-ID: Date: Sun, 16 Apr 2023 13:50:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline To: Stewart Hildebrand , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper References: <20230414185714.292881-1-stewart.hildebrand@amd.com> <20230414185714.292881-2-stewart.hildebrand@amd.com> From: Julien Grall In-Reply-To: <20230414185714.292881-2-stewart.hildebrand@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stewart, On 14/04/2023 19:57, Stewart Hildebrand wrote: > When building the hypervisor with -Og, we run into a __bad_cmpxchg link error: > > aarch64-none-linux-gnu-ld: prelink.o: in function `__int_cmpxchg': > .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference to `__bad_cmpxchg' > aarch64-none-linux-gnu-ld: .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference to `__bad_cmpxchg' > aarch64-none-linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bad_cmpxchg' isn't defined > aarch64-none-linux-gnu-ld: final link failed: bad value > > This is due to the function __guest_cmpxchg not being inlined in the -Og build > with gcc 12. Fix this by marking __guest_cmpxchg always_inline. > > Signed-off-by: Stewart Hildebrand --- > I considered also changing "guest_cmpxchg64" just below in the same file to > always_inline, but I decided not to because this function does not take a size > parameter. Make sense. I will fixed the signed-off-by line issue reported by Henry while committing: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Apr 16 12:53:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 12:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521548.810285 (Exim 4.92) (envelope-from ) id 1po1sd-00027p-O2; Sun, 16 Apr 2023 12:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521548.810285; Sun, 16 Apr 2023 12:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1sd-00027i-L1; Sun, 16 Apr 2023 12:53:19 +0000 Received: by outflank-mailman (input) for mailman id 521548; Sun, 16 Apr 2023 12:53:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1sc-00027c-F6 for xen-devel@lists.xenproject.org; Sun, 16 Apr 2023 12:53:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1sc-0002ZA-5w; Sun, 16 Apr 2023 12:53:18 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1po1sc-0004Xq-1A; Sun, 16 Apr 2023 12:53:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GVZZ0J9TiOyDXbYJOrOwpCrGuXjgqWxUp/y97wdmlfY=; b=S4fbaSXbv2NLoqEod64MC0OO4h BssaHvLgdRzT7CZsK97ladi6bheqH5kOiolQhKlLKEksxmh+mYsDMzrDBkxIxQg/J/oPLhU2oNq4T 348WwdvEh6rWS8bhXSppI6PsBnOYYqQ9aHbVppU5vO/xZO7U7WQGdpdWJmG47lLELV7w=; Message-ID: <5fb567c5-1e82-a048-1cfe-f6f69e0b5ebc@xen.org> Date: Sun, 16 Apr 2023 13:53:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 3/3] xen/arm: fix unitialized use warning To: Stewart Hildebrand , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230414185714.292881-1-stewart.hildebrand@amd.com> <20230414185714.292881-4-stewart.hildebrand@amd.com> From: Julien Grall In-Reply-To: <20230414185714.292881-4-stewart.hildebrand@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Stewart, On 14/04/2023 19:57, Stewart Hildebrand wrote: > When building the hypervisor with -Og, we encounter the following error: Is this with GCC 12 as well? > arch/arm/domain_build.c: In function ‘make_cpus_node’: > arch/arm/domain_build.c:2040:12: error: ‘clock_valid’ may be used uninitialized [-Werror=maybe-uninitialized] > 2040 | if ( clock_valid ) > | ^ > arch/arm/domain_build.c:1947:10: note: ‘clock_valid’ was declared here > 1947 | bool clock_valid; > | ^~~~~~~~~~~ > cc1: all warnings being treated as errors > > Fix it by initializing the variable. > > Signed-off-by: Stewart Hildebrand > --- > See previous discussion here > https://lists.xenproject.org/archives/html/xen-devel/2022-10/msg00741.html > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4f9d4f9d8867..18b350734a8e 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1944,7 +1944,7 @@ static int __init make_cpus_node(const struct domain *d, void *fdt) > /* Placeholder for cpu@ + a 32-bit hexadecimal number + \0 */ > char buf[13]; > u32 clock_frequency; > - bool clock_valid; > + bool clock_valid = false; NIT: I would add "Keep the compiler happy with -Og" I am happy to add it while committing if you agree. Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Apr 16 12:58:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 12:58:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521553.810295 (Exim 4.92) (envelope-from ) id 1po1xI-0002kq-8p; Sun, 16 Apr 2023 12:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521553.810295; Sun, 16 Apr 2023 12:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1xI-0002kj-6E; Sun, 16 Apr 2023 12:58:08 +0000 Received: by outflank-mailman (input) for mailman id 521553; Sun, 16 Apr 2023 12:58:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1xG-0002kZ-TX; Sun, 16 Apr 2023 12:58:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1xG-0002eJ-Qf; Sun, 16 Apr 2023 12:58:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po1xG-00020T-Cu; Sun, 16 Apr 2023 12:58:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1po1xG-0002Ty-CM; Sun, 16 Apr 2023 12:58:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Rp9UZqRU4Yn8+j1dNfSgu/F7/75/bVc0HaWE4qynx2Q=; b=jIW6WbHMqsVH5zQ27gjbVoRFcp rC0Khvsz1XX3e+ThAEFJLEywMy7f2Sqs0dqKXOYzyCvMqkFMuruZj/GrC0VP6glLpAjnuO5ED0ys7 6E9ImwHyAet1ihtUuXITIm8Tpn28mUXvu4rj/qTxOXte1fhKgst8DMXOJmWsLlXV+MMU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180272: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=7cbbd45af115c24dba1b1be9631a32d6215ff0cc X-Osstest-Versions-That: libvirt=ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 From: osstest service owner Date: Sun, 16 Apr 2023 12:58:06 +0000 flight 180272 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180272/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 180255 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 180255 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 180255 version targeted for testing: libvirt 7cbbd45af115c24dba1b1be9631a32d6215ff0cc baseline version: libvirt ebd004a03dbddc52dd1b47bd6bc4607f553d5e70 Last test of basis 180255 2023-04-14 04:18:49 Z 2 days Testing same since 180267 2023-04-15 04:20:21 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git ebd004a03d..7cbbd45af1 7cbbd45af115c24dba1b1be9631a32d6215ff0cc -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Apr 16 14:32:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 14:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521563.810324 (Exim 4.92) (envelope-from ) id 1po3Qf-0004qJ-K2; Sun, 16 Apr 2023 14:32:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521563.810324; Sun, 16 Apr 2023 14:32:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qf-0004qC-HN; Sun, 16 Apr 2023 14:32:33 +0000 Received: by outflank-mailman (input) for mailman id 521563; Sun, 16 Apr 2023 14:32:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qd-0004kg-QI for xen-devel@lists.xenproject.org; Sun, 16 Apr 2023 14:32:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qd-0004yt-EG; Sun, 16 Apr 2023 14:32:31 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1po3Qd-0008OW-5c; Sun, 16 Apr 2023 14:32:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=PrRA+a+hArk7xUtxnyazbLpJIuTfGr9tkFt/D2rBWsA=; b=pI6H98/Eb5rWMeWAc7MEAK1S2+ yOC08oZ3byjikv3015NjSxPj3tSTwhTZBVS9Ayh2iDREcWeEzXdTifJnBrx9U4y1xT5jlW5LQYBt5 5Fm3aWUtF7NnBJOMi9EMr7M2RM4Y/gS1xjo8coNnPHRFCXCvOQ2PY6RJpxFgooMwc1Yk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, michal.orzel@amd.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v7 2/5] xen/arm64: Rework the memory layout Date: Sun, 16 Apr 2023 15:32:08 +0100 Message-Id: <20230416143211.72227-3-julien@xen.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230416143211.72227-1-julien@xen.org> References: <20230416143211.72227-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Xen is currently not fully compliant with the Arm Arm because it will switch the TTBR with the MMU on. In order to be compliant, we need to disable the MMU before switching the TTBR. The implication is the page-tables should contain an identity mapping of the code switching the TTBR. In most of the case we expect Xen to be loaded in low memory. I am aware of one platform (i.e AMD Seattle) where the memory start above 512GB. To give us some slack, consider that Xen may be loaded in the first 2TB of the physical address space. The memory layout is reshuffled to keep the first four slots of the zeroeth level free. All the regions currently in L0 slot 0 will not be part of slot 4 (2TB). This requires a slight tweak of the boot code because XEN_VIRT_START (2TB + 2MB) cannot be used as an immediate. This reshuffle will make trivial to create a 1:1 mapping when Xen is loaded below 2TB. Lastly, take the opportunity to check a compile time if any of the regions may overlap with the reserved area for identity mapping. Signed-off-by: Julien Grall ---- Changes in v7: - Remove all tags - Add BUILD_BUG_ON()s - Don't forget to update FRAMETABLE_VIRT_START and VMAP_VIRT_START Changes in v6: - Correct the BUILD_BUG_ON(), Xen virtual address should be above 2TB (i.e. slot0 > 4). - Add Bertrand's reviewed-by Changes in v5: - We are reserving 4 slots rather than 2. - Fix the addresses in the layout comment. - Fix the size of the region in the layout comment - Add Luca's tested-by (the reviewed-by was not added because of the changes requested by Michal) - Add Michal's reviewed-by Changes in v4: - Correct the documentation - The start address is 2TB, so slot0 is 4 not 2. Changes in v2: - Reword the commit message - Load Xen at 2TB + 2MB - Update the documentation to reflect the new layout --- xen/arch/arm/arm64/head.S | 3 ++- xen/arch/arm/include/asm/config.h | 38 +++++++++++++++++++++---------- xen/arch/arm/mm.c | 23 +++++++++++++++---- 3 files changed, 46 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 4a3f87117c83..663f5813b12e 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -607,7 +607,8 @@ create_page_tables: * need an additional 1:1 mapping, the virtual mapping will * suffice. */ - cmp x19, #XEN_VIRT_START + ldr x0, =XEN_VIRT_START + cmp x19, x0 bne 1f ret 1: diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 5df0e4c4959b..2cfe5e480256 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -72,16 +72,13 @@ #include /* - * Common ARM32 and ARM64 layout: + * ARM32 layout: * 0 - 2M Unmapped * 2M - 4M Xen text, data, bss * 4M - 6M Fixmap: special-purpose 4K mapping slots * 6M - 10M Early boot mapping of FDT * 10M - 12M Livepatch vmap (if compiled in) * - * ARM32 layout: - * 0 - 12M - * * 32M - 128M Frametable: 32 bytes per page for 12GB of RAM * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address * space @@ -90,14 +87,23 @@ * 2G - 4G Domheap: on-demand-mapped * * ARM64 layout: - * 0x0000000000000000 - 0x0000007fffffffff (512GB, L0 slot [0]) - * 0 - 12M + * 0x0000000000000000 - 0x000001ffffffffff (2TB, L0 slots [0..3]) + * + * Reserved to identity map Xen + * + * 0x0000020000000000 - 0x0000027fffffffff (512GB, L0 slot [4] + * (Relative offsets) + * 0 - 2M Unmapped + * 2M - 4M Xen text, data, bss + * 4M - 6M Fixmap: special-purpose 4K mapping slots + * 6M - 10M Early boot mapping of FDT + * 10M - 12M Livepatch vmap (if compiled in) * * 1G - 2G VMAP: ioremap and early_ioremap * * 32G - 64G Frametable: 56 bytes per page for 2TB of RAM * - * 0x0000008000000000 - 0x00007fffffffffff (127.5TB, L0 slots [1..255]) + * 0x0000028000000000 - 0x00007fffffffffff (125TB, L0 slots [5..255]) * Unused * * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) @@ -107,7 +113,17 @@ * Unused */ +#ifdef CONFIG_ARM_32 #define XEN_VIRT_START _AT(vaddr_t, MB(2)) +#else + +#define SLOT0_ENTRY_BITS 39 +#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) +#define SLOT0_ENTRY_SIZE SLOT0(1) + +#define XEN_VIRT_START (SLOT0(4) + _AT(vaddr_t, MB(2))) +#endif + #define XEN_VIRT_SIZE _AT(vaddr_t, MB(2)) #define FIXMAP_VIRT_START (XEN_VIRT_START + XEN_VIRT_SIZE) @@ -163,14 +179,12 @@ #else /* ARM_64 */ -#define SLOT0_ENTRY_BITS 39 -#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) -#define SLOT0_ENTRY_SIZE SLOT0(1) +#define IDENTITY_MAPPING_AREA_NR_L0 4 -#define VMAP_VIRT_START GB(1) +#define VMAP_VIRT_START (SLOT0(4) + GB(1)) #define VMAP_VIRT_SIZE GB(1) -#define FRAMETABLE_VIRT_START GB(32) +#define FRAMETABLE_VIRT_START (SLOT0(4) + GB(32)) #define FRAMETABLE_SIZE GB(32) #define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index b99806af996c..1d09d61dd922 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -153,7 +153,19 @@ static void __init __maybe_unused build_assertions(void) #endif /* Page table structure constraints */ #ifdef CONFIG_ARM_64 - BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START)); + /* + * The first few slots of the L0 table is reserved for the identity + * mapping. Check that none of the other regions are overlapping + * with it. + */ +#define CHECK_OVERLAP_WITH_IDMAP(virt) \ + BUILD_BUG_ON(zeroeth_table_offset(virt) < IDENTITY_MAPPING_AREA_NR_L0) + + CHECK_OVERLAP_WITH_IDMAP(XEN_VIRT_START); + CHECK_OVERLAP_WITH_IDMAP(VMAP_VIRT_START); + CHECK_OVERLAP_WITH_IDMAP(FRAMETABLE_VIRT_START); + CHECK_OVERLAP_WITH_IDMAP(DIRECTMAP_VIRT_START); +#undef CHECK_OVERLAP_WITH_IDMAP #endif BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); #ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE @@ -496,10 +508,11 @@ void __init setup_pagetables(unsigned long boot_phys_offset) phys_offset = boot_phys_offset; #ifdef CONFIG_ARM_64 - p = (void *) xen_pgtable; - p[0] = pte_of_xenaddr((uintptr_t)xen_first); - p[0].pt.table = 1; - p[0].pt.xn = 0; + pte = pte_of_xenaddr((uintptr_t)xen_first); + pte.pt.table = 1; + pte.pt.xn = 0; + xen_pgtable[zeroeth_table_offset(XEN_VIRT_START)] = pte; + p = (void *) xen_first; #else p = (void *) cpu0_pgtable; -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Sun Apr 16 14:32:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 14:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521566.810350 (Exim 4.92) (envelope-from ) id 1po3Qi-0005Qx-ID; Sun, 16 Apr 2023 14:32:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521566.810350; Sun, 16 Apr 2023 14:32:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qi-0005QR-Cu; Sun, 16 Apr 2023 14:32:36 +0000 Received: by outflank-mailman (input) for mailman id 521566; Sun, 16 Apr 2023 14:32:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qh-0005KJ-Q6 for xen-devel@lists.xenproject.org; Sun, 16 Apr 2023 14:32:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qh-0004zi-Jn; Sun, 16 Apr 2023 14:32:35 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1po3Qh-0008OW-Bd; Sun, 16 Apr 2023 14:32:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=YpmUTbbN8N1AmFmYpme9CCnV9PdTeXnSWyUsvtOcdzM=; b=gjJkxYry1/LQBlw8e8hXlFcBbY GEvlnQN6nMu/zu/3ZH4L1SbBijbLKa5v1myPtTn5gmQejc2Mtpb9JJwSCK041KND7JsKGDTRjQEfx GhouvrWn7scItXdDpj4vnil/SZYsLquqiMIBsb+a9iBlHZrnWlnkWP/5yglBN9yK/zuE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, michal.orzel@amd.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Luca Fancellu Subject: [PATCH v7 5/5] xen/arm64: smpboot: Directly switch to the runtime page-tables Date: Sun, 16 Apr 2023 15:32:11 +0100 Message-Id: <20230416143211.72227-6-julien@xen.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230416143211.72227-1-julien@xen.org> References: <20230416143211.72227-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Switching TTBR while the MMU is on is not safe. Now that the identity mapping will not clash with the rest of the memory layout, we can avoid creating temporary page-tables every time a CPU is brought up. The arm32 code will use a different approach. So this issue is for now only resolved on arm64. Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu Reviewed-by: Bertrand Marquis ---- Changes in v7: - Remove the tested-by tag because of the layout reshuffle in the previous patches. Changes in v6: - Add Bertrand's reviewed-by Changes in v5: - Add Luca's reviewed-by and tested-by tags. Changes in v4: - Somehow I forgot to send it in v3. So re-include it. Changes in v2: - Remove arm32 code --- xen/arch/arm/arm32/smpboot.c | 4 ++++ xen/arch/arm/arm64/head.S | 29 +++++++++-------------------- xen/arch/arm/arm64/smpboot.c | 15 ++++++++++++++- xen/arch/arm/include/asm/smp.h | 1 + xen/arch/arm/smpboot.c | 1 + 5 files changed, 29 insertions(+), 21 deletions(-) diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c index e7368665d50d..518e9f9c7e70 100644 --- a/xen/arch/arm/arm32/smpboot.c +++ b/xen/arch/arm/arm32/smpboot.c @@ -21,6 +21,10 @@ int arch_cpu_up(int cpu) return platform_cpu_up(cpu); } +void arch_cpu_up_finish(void) +{ +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5efd442b24af..a61b4d3c2738 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -308,6 +308,7 @@ real_start_efi: bl check_cpu_mode bl cpu_init bl create_page_tables + load_paddr x0, boot_pgtable bl enable_mmu /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ @@ -365,29 +366,14 @@ GLOBAL(init_secondary) #endif bl check_cpu_mode bl cpu_init - bl create_page_tables + load_paddr x0, init_ttbr + ldr x0, [x0] bl enable_mmu /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ ldr x0, =secondary_switched br x0 secondary_switched: - /* - * Non-boot CPUs need to move on to the proper pagetables, which were - * setup in init_secondary_pagetables. - * - * XXX: This is not compliant with the Arm Arm. - */ - ldr x4, =init_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */ - ldr x4, [x4] /* Actual value */ - dsb sy - msr TTBR0_EL2, x4 - dsb sy - isb - tlbi alle2 - dsb sy /* Ensure completion of TLB flush */ - isb - #ifdef CONFIG_EARLY_PRINTK /* Use a virtual address to access the UART. */ ldr x23, =EARLY_UART_VIRTUAL_ADDRESS @@ -672,9 +658,13 @@ ENDPROC(create_page_tables) * mapping. In other word, the caller is responsible to switch to the runtime * mapping. * - * Clobbers x0 - x3 + * Inputs: + * x0 : Physical address of the page tables. + * + * Clobbers x0 - x4 */ enable_mmu: + mov x4, x0 PRINT("- Turning on paging -\r\n") /* @@ -685,8 +675,7 @@ enable_mmu: dsb nsh /* Write Xen's PT's paddr into TTBR0_EL2 */ - load_paddr x0, boot_pgtable - msr TTBR0_EL2, x0 + msr TTBR0_EL2, x4 isb mrs x0, SCTLR_EL2 diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 694fbf67e62a..9637f424699e 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -106,10 +106,23 @@ int __init arch_cpu_init(int cpu, struct dt_device_node *dn) int arch_cpu_up(int cpu) { + int rc; + if ( !smp_enable_ops[cpu].prepare_cpu ) return -ENODEV; - return smp_enable_ops[cpu].prepare_cpu(cpu); + update_identity_mapping(true); + + rc = smp_enable_ops[cpu].prepare_cpu(cpu); + if ( rc ) + update_identity_mapping(false); + + return rc; +} + +void arch_cpu_up_finish(void) +{ + update_identity_mapping(false); } /* diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h index 8133d5c29572..a37ca55bff2c 100644 --- a/xen/arch/arm/include/asm/smp.h +++ b/xen/arch/arm/include/asm/smp.h @@ -25,6 +25,7 @@ extern void noreturn stop_cpu(void); extern int arch_smp_init(void); extern int arch_cpu_init(int cpu, struct dt_device_node *dn); extern int arch_cpu_up(int cpu); +extern void arch_cpu_up_finish(void); int cpu_up_send_sgi(int cpu); diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 412ae2286906..4a89b3a8345b 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -500,6 +500,7 @@ int __cpu_up(unsigned int cpu) init_data.cpuid = ~0; smp_up_cpu = MPIDR_INVALID; clean_dcache(smp_up_cpu); + arch_cpu_up_finish(); if ( !cpu_online(cpu) ) { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Sun Apr 16 14:32:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 16 Apr 2023 14:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.521562.810315 (Exim 4.92) (envelope-from ) id 1po3Qd-0004an-8x; Sun, 16 Apr 2023 14:32:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 521562.810315; Sun, 16 Apr 2023 14:32:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qd-0004ag-5n; Sun, 16 Apr 2023 14:32:31 +0000 Received: by outflank-mailman (input) for mailman id 521562; Sun, 16 Apr 2023 14:32:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qc-0004Vb-Fm for xen-devel@lists.xenproject.org; Sun, 16 Apr 2023 14:32:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1po3Qc-0004yh-4v; Sun, 16 Apr 2023 14:32:30 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1po3Qb-0008OW-Sa; Sun, 16 Apr 2023 14:32:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=cmPpxvjkrxWFma6zTaRewwdEQPiJX9jNoQsgck6jnCg=; b=Ar/he/eeHYx7LDhVsytD0xoHaB S6IqcvMjyjBF9tUOme/pTwD7kgJGvxsK7QMExWVNcpLQeYk5vvKJR6V9QeNG05NWcUMjp3JvpVjOQ mlNR8x+7ltvWuv3oiEtOFnuag/etvQQEo16wVxX1jdy4gEOmqJN36Wszou3XzA+9rAxI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, michal.orzel@amd.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [PATCH v7 1/5] xen/arm32: head: Widen the use of the temporary mapping Date: Sun, 16 Apr 2023 15:32:07 +0100 Message-Id: <20230416143211.72227-2-julien@xen.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230416143211.72227-1-julien@xen.org> References: <20230416143211.72227-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, the temporary mapping is only used when the virtual runtime region of Xen is clashing with the physical region. In follow-up patches, we will rework how secondary CPU bring-up works and it will be convenient to use the fixmap area for accessing the root page-table (it is per-cpu). Rework the code to use temporary mapping when the Xen physical address is not overlapping with the temporary mapping. This also has the advantage to simplify the logic to identity map Xen. Signed-off-by: Julien Grall Reviewed-by: Henry Wang Tested-by: Henry Wang Reviewed-by: Michal Orzel ---- Even if this patch is rewriting part of the previous patch, I decided to keep them separated to help the review. The "follow-up patches" are still in draft at the moment. I still haven't find a way to split them nicely and not require too much more work in the coloring side. I have provided some medium-term goal in the cover letter. Changes in v6: - Add Henry's reviewed-by and tested-by tag - Add Michal's reviewed-by - Add newline in remove_identity_mapping for clarity Changes in v5: - Fix typo in a comment - No need to link boot_{second, third}_id again if we need to create a temporary area. Changes in v3: - Resolve conflicts after switching from "ldr rX,